*** jwcroppe has quit IRC | 00:00 | |
*** Marga_ has quit IRC | 00:03 | |
*** Marga_ has joined #openstack-nova | 00:03 | |
*** willsama has quit IRC | 00:04 | |
*** mriedem has quit IRC | 00:04 | |
openstackgerrit | Jianghua Wang proposed openstack/nova: xenapi: OVS agent updates the wrong port when using XenServer + Neutron https://review.openstack.org/242846 | 00:05 |
---|---|---|
openstackgerrit | Jianghua Wang proposed openstack/nova: xenapi: OVS agent updates the wrong port when using XenServer + Neutron https://review.openstack.org/242846 | 00:07 |
*** dims has joined #openstack-nova | 00:08 | |
*** pratikma_ has quit IRC | 00:12 | |
*** lskyw has joined #openstack-nova | 00:13 | |
*** dims has quit IRC | 00:16 | |
*** Marga_ has quit IRC | 00:17 | |
*** ndipanov has joined #openstack-nova | 00:19 | |
*** ijuwang has quit IRC | 00:20 | |
*** Marga_ has joined #openstack-nova | 00:21 | |
*** hemna is now known as hemnafk | 00:21 | |
*** rfolco has joined #openstack-nova | 00:22 | |
*** armax has joined #openstack-nova | 00:23 | |
*** yamahata has joined #openstack-nova | 00:23 | |
*** EinstCrazy has quit IRC | 00:23 | |
*** Marga_ has quit IRC | 00:25 | |
*** sshen has joined #openstack-nova | 00:27 | |
*** mc_nair has quit IRC | 00:27 | |
*** jinxing has joined #openstack-nova | 00:29 | |
*** jinxing has quit IRC | 00:30 | |
*** jinxing has joined #openstack-nova | 00:30 | |
*** jinxing has quit IRC | 00:32 | |
*** sneti has joined #openstack-nova | 00:33 | |
*** subscope has quit IRC | 00:34 | |
*** achanda has joined #openstack-nova | 00:36 | |
*** sneti has quit IRC | 00:39 | |
*** mnestratov has quit IRC | 00:39 | |
*** mriedem has joined #openstack-nova | 00:42 | |
*** ctrath has quit IRC | 00:43 | |
*** nic has quit IRC | 00:44 | |
*** emagana has quit IRC | 00:49 | |
*** salv-orlando has quit IRC | 00:49 | |
*** stackdump has quit IRC | 00:54 | |
*** diogogmt has quit IRC | 00:54 | |
*** gyee has joined #openstack-nova | 00:56 | |
*** sfinucan__ has quit IRC | 00:58 | |
*** zhangjn has joined #openstack-nova | 01:01 | |
*** sshen_ has joined #openstack-nova | 01:06 | |
*** sshen has quit IRC | 01:06 | |
*** spandhe has quit IRC | 01:06 | |
*** spandhe has joined #openstack-nova | 01:07 | |
*** edtubill has joined #openstack-nova | 01:11 | |
*** EinstCrazy has joined #openstack-nova | 01:12 | |
*** thorst has joined #openstack-nova | 01:17 | |
*** lskyw has quit IRC | 01:18 | |
*** jyuso1 has joined #openstack-nova | 01:19 | |
*** obondarev has quit IRC | 01:20 | |
*** thorst has quit IRC | 01:20 | |
*** Marga_ has joined #openstack-nova | 01:21 | |
*** ssurana has quit IRC | 01:23 | |
*** zhenguo has joined #openstack-nova | 01:23 | |
*** edtubill has quit IRC | 01:24 | |
*** abitha has quit IRC | 01:25 | |
*** edtubill has joined #openstack-nova | 01:26 | |
*** Marga_ has quit IRC | 01:26 | |
*** dims has joined #openstack-nova | 01:27 | |
*** otter768 has joined #openstack-nova | 01:28 | |
*** electrocucaracha has quit IRC | 01:28 | |
*** obondarev has joined #openstack-nova | 01:29 | |
*** mtanino has quit IRC | 01:30 | |
*** suro-patz has quit IRC | 01:31 | |
*** terryyao has joined #openstack-nova | 01:33 | |
*** otter768 has quit IRC | 01:33 | |
*** pixelbeat has quit IRC | 01:34 | |
*** harlowja has quit IRC | 01:38 | |
*** harlowja_ has joined #openstack-nova | 01:38 | |
*** Yanyanhu has joined #openstack-nova | 01:38 | |
*** EinstCra_ has joined #openstack-nova | 01:40 | |
*** angdraug has quit IRC | 01:40 | |
*** edtubill has quit IRC | 01:42 | |
*** changbl has joined #openstack-nova | 01:43 | |
*** EinstCrazy has quit IRC | 01:43 | |
*** pratikmallya has joined #openstack-nova | 01:47 | |
*** breitz has quit IRC | 01:49 | |
*** terryyao_ has joined #openstack-nova | 01:51 | |
openstackgerrit | Jianghua Wang proposed openstack/nova: xenapi: OVS agent updates the wrong port when using XenServer + Neutron https://review.openstack.org/242846 | 01:52 |
*** browne has quit IRC | 01:56 | |
*** salv-orlando has joined #openstack-nova | 01:57 | |
*** gcb has joined #openstack-nova | 01:58 | |
*** salv-orlando has quit IRC | 01:59 | |
*** salv-orlando has joined #openstack-nova | 01:59 | |
*** stackdump has joined #openstack-nova | 02:01 | |
*** edmondsw has quit IRC | 02:04 | |
*** pratikmallya has quit IRC | 02:11 | |
*** rfolco has quit IRC | 02:12 | |
*** spandhe has quit IRC | 02:12 | |
*** angdraug has joined #openstack-nova | 02:19 | |
*** seanw1 has quit IRC | 02:19 | |
*** seanw1 has joined #openstack-nova | 02:20 | |
*** diogogmt has joined #openstack-nova | 02:20 | |
*** haomaiwang has joined #openstack-nova | 02:21 | |
*** Marga_ has joined #openstack-nova | 02:22 | |
*** suro-patz has joined #openstack-nova | 02:23 | |
*** suro-patz has quit IRC | 02:24 | |
*** Marga_ has quit IRC | 02:26 | |
*** pratikmallya has joined #openstack-nova | 02:30 | |
*** Marga_ has joined #openstack-nova | 02:32 | |
*** emagana has joined #openstack-nova | 02:35 | |
*** emagana has quit IRC | 02:40 | |
*** su_zhang has joined #openstack-nova | 02:42 | |
*** bharath has joined #openstack-nova | 02:43 | |
*** emagana has joined #openstack-nova | 02:46 | |
*** salv-orlando has quit IRC | 02:46 | |
*** isq has quit IRC | 02:52 | |
*** isq has joined #openstack-nova | 02:52 | |
*** isq has quit IRC | 02:53 | |
*** isq has joined #openstack-nova | 02:53 | |
openstackgerrit | Wen Zhi Yu proposed openstack/nova: Clean up network resources when reschedule fails https://review.openstack.org/243477 | 02:54 |
*** yamahata has quit IRC | 02:54 | |
*** edtubill has joined #openstack-nova | 02:54 | |
*** arunkant has joined #openstack-nova | 02:55 | |
*** unicell has quit IRC | 02:56 | |
*** jamielennox is now known as jamielennox|away | 03:00 | |
*** haomaiwang has quit IRC | 03:01 | |
*** haomaiwang has joined #openstack-nova | 03:01 | |
*** gcb has quit IRC | 03:08 | |
*** jamielennox|away is now known as jamielennox | 03:10 | |
*** zhangjn has quit IRC | 03:11 | |
*** zhangjn has joined #openstack-nova | 03:11 | |
*** sshen_ is now known as sshen | 03:12 | |
*** venkat_p has joined #openstack-nova | 03:13 | |
*** stackdump has quit IRC | 03:14 | |
*** venkat_p has left #openstack-nova | 03:14 | |
*** su_zhang has quit IRC | 03:15 | |
*** vilobhmm has quit IRC | 03:18 | |
*** angdraug has quit IRC | 03:22 | |
*** sshen has quit IRC | 03:22 | |
*** hightall has joined #openstack-nova | 03:22 | |
*** sshen has joined #openstack-nova | 03:23 | |
*** gyee has quit IRC | 03:23 | |
*** gcb has joined #openstack-nova | 03:25 | |
*** emagana has quit IRC | 03:27 | |
*** otter768 has joined #openstack-nova | 03:29 | |
*** pumaranikar has joined #openstack-nova | 03:29 | |
*** otter768 has quit IRC | 03:33 | |
*** jerrygb has quit IRC | 03:33 | |
*** jerrygb has joined #openstack-nova | 03:34 | |
*** agireud has joined #openstack-nova | 03:34 | |
openstackgerrit | wuhao proposed openstack/nova: Fix a spelling mistake in the log https://review.openstack.org/243907 | 03:37 |
*** fawadkhaliq has joined #openstack-nova | 03:39 | |
*** agireud has quit IRC | 03:39 | |
*** pratikmallya has quit IRC | 03:40 | |
*** agireud has joined #openstack-nova | 03:41 | |
*** dave-mcc_ has quit IRC | 03:45 | |
*** dims has quit IRC | 03:46 | |
*** r-daneel has quit IRC | 03:47 | |
*** salv-orlando has joined #openstack-nova | 03:47 | |
*** pumaranikar has quit IRC | 03:49 | |
*** hightall has quit IRC | 03:50 | |
*** kylek3h has quit IRC | 03:50 | |
*** apoorvad has quit IRC | 03:50 | |
*** kylek3h has joined #openstack-nova | 03:50 | |
*** salv-orlando has quit IRC | 03:52 | |
*** kylek3h has quit IRC | 03:55 | |
*** emagana has joined #openstack-nova | 03:56 | |
*** Marga__ has joined #openstack-nova | 03:59 | |
*** haomaiwang has quit IRC | 04:01 | |
*** haomaiwang has joined #openstack-nova | 04:01 | |
*** Marga_ has quit IRC | 04:02 | |
*** wanghao has joined #openstack-nova | 04:05 | |
openstackgerrit | wanghao proposed openstack/nova: Fix invalid Image&block device mapping combination https://review.openstack.org/171984 | 04:05 |
*** flyingtt has quit IRC | 04:06 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/243936 | 04:06 |
*** mriedem has quit IRC | 04:08 | |
openstackgerrit | Jianghua Wang proposed openstack/nova: xenapi: OVS agent updates the wrong port when using XenServer + Neutron https://review.openstack.org/242846 | 04:10 |
*** jinxing has joined #openstack-nova | 04:12 | |
*** stevemar_ has joined #openstack-nova | 04:13 | |
*** Marga__ has quit IRC | 04:14 | |
*** diogogmt has quit IRC | 04:16 | |
*** stevemar_ has quit IRC | 04:16 | |
*** fawadkhaliq has quit IRC | 04:17 | |
*** emagana has quit IRC | 04:18 | |
*** Sree has joined #openstack-nova | 04:22 | |
*** bharath has quit IRC | 04:27 | |
*** links has joined #openstack-nova | 04:28 | |
*** bharath has joined #openstack-nova | 04:28 | |
*** gongysh_ has joined #openstack-nova | 04:31 | |
*** hogepodge has quit IRC | 04:35 | |
*** hightall has joined #openstack-nova | 04:39 | |
*** jwcroppe has joined #openstack-nova | 04:41 | |
*** salv-orlando has joined #openstack-nova | 04:48 | |
*** pratikmallya has joined #openstack-nova | 04:49 | |
*** kylek3h has joined #openstack-nova | 04:51 | |
*** Sree has quit IRC | 04:52 | |
*** Sree has joined #openstack-nova | 04:52 | |
*** Marga_ has joined #openstack-nova | 04:52 | |
*** salv-orlando has quit IRC | 04:52 | |
*** Marga_ has quit IRC | 04:53 | |
*** Marga_ has joined #openstack-nova | 04:54 | |
*** pratikmallya has quit IRC | 04:55 | |
*** kylek3h has quit IRC | 04:55 | |
*** vishwanathj has quit IRC | 04:57 | |
*** baoli has quit IRC | 04:57 | |
*** baoli has joined #openstack-nova | 04:58 | |
*** mdrabe has joined #openstack-nova | 04:58 | |
*** haomaiwang has quit IRC | 05:01 | |
*** stackdump has joined #openstack-nova | 05:01 | |
*** haomaiwa_ has joined #openstack-nova | 05:01 | |
*** fawadkhaliq has joined #openstack-nova | 05:02 | |
*** edtubill has quit IRC | 05:03 | |
*** mdrabe has quit IRC | 05:04 | |
*** stackdump has quit IRC | 05:05 | |
*** Sree has quit IRC | 05:06 | |
*** Sree has joined #openstack-nova | 05:11 | |
*** rha has quit IRC | 05:12 | |
*** baoli has quit IRC | 05:20 | |
*** baoli has joined #openstack-nova | 05:20 | |
*** suro-patz has joined #openstack-nova | 05:21 | |
*** baoli has quit IRC | 05:25 | |
*** links has quit IRC | 05:26 | |
*** baoli has joined #openstack-nova | 05:27 | |
*** jerrygb has quit IRC | 05:28 | |
*** jinxing has quit IRC | 05:28 | |
*** Sree_ has joined #openstack-nova | 05:29 | |
*** stevemar_ has joined #openstack-nova | 05:29 | |
*** jerrygb has joined #openstack-nova | 05:29 | |
*** suro-patz has quit IRC | 05:29 | |
*** Sree_ is now known as Guest90523 | 05:29 | |
*** otter768 has joined #openstack-nova | 05:29 | |
*** jinxing has joined #openstack-nova | 05:30 | |
*** su_zhang has joined #openstack-nova | 05:30 | |
*** frickler has quit IRC | 05:31 | |
*** stevemar_ has quit IRC | 05:31 | |
*** Sree has quit IRC | 05:32 | |
*** jerrygb has quit IRC | 05:33 | |
*** otter768 has quit IRC | 05:34 | |
*** subscope has joined #openstack-nova | 05:45 | |
*** su_zhang has quit IRC | 05:47 | |
*** Marga_ has quit IRC | 05:48 | |
*** achanda has quit IRC | 05:54 | |
*** eliqiao has quit IRC | 05:55 | |
*** lpetrut has joined #openstack-nova | 05:58 | |
*** links has joined #openstack-nova | 05:58 | |
*** eliqiao has joined #openstack-nova | 05:59 | |
*** haomaiwa_ has quit IRC | 06:01 | |
*** haomaiwang has joined #openstack-nova | 06:01 | |
*** fawadkhaliq has quit IRC | 06:01 | |
*** fawadkhaliq has joined #openstack-nova | 06:02 | |
*** nikhil has quit IRC | 06:02 | |
*** nikhil has joined #openstack-nova | 06:02 | |
*** fawadk has joined #openstack-nova | 06:03 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata https://review.openstack.org/242727 | 06:03 |
*** fawadkhaliq has quit IRC | 06:04 | |
*** artom_ has joined #openstack-nova | 06:05 | |
*** bharath has quit IRC | 06:06 | |
*** marzif_ has joined #openstack-nova | 06:06 | |
*** artom has quit IRC | 06:07 | |
*** q3k has quit IRC | 06:08 | |
*** daemontool has quit IRC | 06:08 | |
*** q3k has joined #openstack-nova | 06:09 | |
*** bharath has joined #openstack-nova | 06:17 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: Introduce utility module for pcp https://review.openstack.org/203163 | 06:17 |
*** vilobhmm has joined #openstack-nova | 06:24 | |
*** bharath has quit IRC | 06:24 | |
*** jamielennox is now known as jamielennox|away | 06:29 | |
*** subscope has quit IRC | 06:32 | |
*** lpetrut has quit IRC | 06:33 | |
*** achanda has joined #openstack-nova | 06:34 | |
*** spandhe has joined #openstack-nova | 06:36 | |
*** bharath has joined #openstack-nova | 06:37 | |
*** pratikmallya has joined #openstack-nova | 06:39 | |
*** moshele has joined #openstack-nova | 06:46 | |
*** frickler has joined #openstack-nova | 06:49 | |
*** jfding has quit IRC | 06:52 | |
*** jinxing_ has joined #openstack-nova | 06:53 | |
*** vilobhmm has quit IRC | 06:54 | |
*** mjura has joined #openstack-nova | 06:54 | |
*** lpetrut has joined #openstack-nova | 06:54 | |
*** ihrachys has joined #openstack-nova | 06:54 | |
openstackgerrit | venkatesh proposed openstack/nova: make the driver.Scheduler as abstract class https://review.openstack.org/212016 | 06:54 |
*** jinxing has quit IRC | 06:56 | |
*** browne has joined #openstack-nova | 06:57 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova-specs: Add new filter 'ShelveAggregateAffinityFilter' https://review.openstack.org/234013 | 06:57 |
*** jinxing_ has quit IRC | 07:00 | |
*** garyk1 has joined #openstack-nova | 07:00 | |
*** haomaiwang has quit IRC | 07:01 | |
*** 16WAAQM31 has joined #openstack-nova | 07:01 | |
*** garyk1 has quit IRC | 07:01 | |
*** garyk2 has joined #openstack-nova | 07:01 | |
*** garyk1 has joined #openstack-nova | 07:02 | |
*** garyk2 has quit IRC | 07:02 | |
*** bharath has quit IRC | 07:05 | |
*** spandhe has quit IRC | 07:07 | |
*** jinxing has joined #openstack-nova | 07:08 | |
*** lsmola has joined #openstack-nova | 07:16 | |
*** jwcroppe has quit IRC | 07:17 | |
*** jwcroppe has joined #openstack-nova | 07:17 | |
*** ihrachys has quit IRC | 07:18 | |
*** Guest90523 has quit IRC | 07:19 | |
*** Sree has joined #openstack-nova | 07:20 | |
*** scheuran has joined #openstack-nova | 07:20 | |
*** baoli has quit IRC | 07:20 | |
*** baoli has joined #openstack-nova | 07:21 | |
*** kylek3h has joined #openstack-nova | 07:22 | |
*** jwcroppe has quit IRC | 07:22 | |
*** bharath has joined #openstack-nova | 07:22 | |
*** cfriesen__ has quit IRC | 07:23 | |
*** rdopiera has joined #openstack-nova | 07:24 | |
*** Sree has quit IRC | 07:25 | |
*** baoli has quit IRC | 07:25 | |
*** nkrinner has joined #openstack-nova | 07:26 | |
*** kylek3h has quit IRC | 07:26 | |
*** Marga_ has joined #openstack-nova | 07:28 | |
*** bharath has quit IRC | 07:28 | |
*** armax has quit IRC | 07:29 | |
*** stevemar_ has joined #openstack-nova | 07:29 | |
*** jerrygb has joined #openstack-nova | 07:30 | |
*** otter768 has joined #openstack-nova | 07:30 | |
*** jhesketh has quit IRC | 07:31 | |
*** jhesketh has joined #openstack-nova | 07:31 | |
*** pratikmallya has quit IRC | 07:32 | |
*** stevemar_ has quit IRC | 07:32 | |
*** otter768 has quit IRC | 07:35 | |
*** jerrygb has quit IRC | 07:36 | |
openstackgerrit | garyk proposed openstack/nova: VMware: expand support for Opaque networks https://review.openstack.org/165750 | 07:36 |
*** logan2 has quit IRC | 07:40 | |
*** logan2 has joined #openstack-nova | 07:40 | |
*** nelsnels_ has joined #openstack-nova | 07:41 | |
*** bharath has joined #openstack-nova | 07:41 | |
*** jamielennox|away has quit IRC | 07:41 | |
*** dansmith has quit IRC | 07:42 | |
*** whydidyoustealmy has joined #openstack-nova | 07:42 | |
*** Marga__ has joined #openstack-nova | 07:43 | |
*** Marga_ has quit IRC | 07:43 | |
*** jyuso1 has quit IRC | 07:43 | |
*** barra204 has quit IRC | 07:43 | |
*** liusheng has quit IRC | 07:43 | |
*** nelsnelson has quit IRC | 07:44 | |
*** jyuso1 has joined #openstack-nova | 07:44 | |
*** afazekas|sick has quit IRC | 07:44 | |
*** liusheng has joined #openstack-nova | 07:44 | |
*** dansmith has joined #openstack-nova | 07:44 | |
*** dansmith is now known as Guest40458 | 07:44 | |
*** mordred has quit IRC | 07:44 | |
*** liverpooler has joined #openstack-nova | 07:45 | |
*** lpetrut has quit IRC | 07:48 | |
*** rha has joined #openstack-nova | 07:48 | |
*** rha has quit IRC | 07:49 | |
*** eglynn has joined #openstack-nova | 07:49 | |
*** afazekas has joined #openstack-nova | 07:50 | |
*** rha has joined #openstack-nova | 07:50 | |
*** bharath has quit IRC | 07:50 | |
*** achanda has quit IRC | 07:51 | |
*** paul-carlton has joined #openstack-nova | 07:53 | |
*** eliqiao has quit IRC | 07:55 | |
*** eliqiao has joined #openstack-nova | 07:56 | |
*** fawadk has quit IRC | 07:57 | |
*** achanda has joined #openstack-nova | 07:57 | |
*** fawadkhaliq has joined #openstack-nova | 07:58 | |
*** paul-carlton has quit IRC | 08:00 | |
*** kylek3h has joined #openstack-nova | 08:00 | |
*** 16WAAQM31 has quit IRC | 08:01 | |
*** haomaiwang has joined #openstack-nova | 08:01 | |
*** terryyao_ has quit IRC | 08:01 | |
*** danpb has joined #openstack-nova | 08:04 | |
*** kylek3h has quit IRC | 08:04 | |
*** bharath has joined #openstack-nova | 08:06 | |
*** Sree has joined #openstack-nova | 08:07 | |
*** subscope has joined #openstack-nova | 08:07 | |
ndipanov | johnthetubaguy, if you have some time this week https://review.openstack.org/#/c/212472/ | 08:13 |
ndipanov | I feel it has had a good amount of discussion | 08:13 |
*** fawadkhaliq has quit IRC | 08:13 | |
*** jichen has joined #openstack-nova | 08:14 | |
*** mpavone has joined #openstack-nova | 08:14 | |
*** paul-carlton has joined #openstack-nova | 08:15 | |
*** mpavone has quit IRC | 08:15 | |
*** eglynn has quit IRC | 08:18 | |
*** markmc has quit IRC | 08:18 | |
*** Sree has quit IRC | 08:18 | |
*** Sree has joined #openstack-nova | 08:19 | |
*** paul-carlton has quit IRC | 08:19 | |
*** spandhe has joined #openstack-nova | 08:19 | |
*** spandhe_ has joined #openstack-nova | 08:20 | |
*** alex_klimov has joined #openstack-nova | 08:21 | |
*** lucas-afk is now known as lucasagomes | 08:23 | |
*** Sree has quit IRC | 08:23 | |
*** spandhe has quit IRC | 08:24 | |
*** spandhe_ is now known as spandhe | 08:24 | |
*** jamielennox|away has joined #openstack-nova | 08:31 | |
*** jamielennox|away is now known as jamielennox | 08:31 | |
*** Guest13749 is now known as tdurakov | 08:33 | |
*** paul-carlton has joined #openstack-nova | 08:35 | |
*** stevemar_ has joined #openstack-nova | 08:35 | |
*** gszasz has joined #openstack-nova | 08:36 | |
*** achanda has quit IRC | 08:36 | |
openstackgerrit | octopuszhang proposed openstack/nova: remove wrong comments https://review.openstack.org/244002 | 08:38 |
*** stevemar_ has quit IRC | 08:38 | |
*** pratikmallya has joined #openstack-nova | 08:38 | |
*** achanda has joined #openstack-nova | 08:39 | |
*** Marga__ has quit IRC | 08:42 | |
*** Marga_ has joined #openstack-nova | 08:43 | |
*** ihrachys has joined #openstack-nova | 08:45 | |
*** rk4n has joined #openstack-nova | 08:46 | |
*** jlanoux has joined #openstack-nova | 08:47 | |
*** rk4n has quit IRC | 08:50 | |
*** subscope has quit IRC | 08:52 | |
alex_xu | ndipanov: re: https://review.openstack.org/#/c/231887, I agree the db layer shouldn't include application logic. or does make sense we do that in the instance object? there are multiple instance.destory() in the code we need check them one by one, that is a little pain deal with each one. | 08:54 |
alex_xu | for example https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L884 | 08:54 |
*** achanda has quit IRC | 08:57 | |
*** zhangtao has quit IRC | 08:57 | |
*** derekh has joined #openstack-nova | 08:57 | |
*** pratikmallya has quit IRC | 08:58 | |
*** spandhe has quit IRC | 08:59 | |
*** pratikmallya has joined #openstack-nova | 08:59 | |
*** e0ne has joined #openstack-nova | 09:00 | |
*** pratikmallya has quit IRC | 09:00 | |
*** haomaiwang has quit IRC | 09:01 | |
*** haomaiwang has joined #openstack-nova | 09:01 | |
*** jinxing has quit IRC | 09:01 | |
*** ociuhandu has quit IRC | 09:03 | |
*** moshele has quit IRC | 09:03 | |
*** spandhe has joined #openstack-nova | 09:03 | |
*** rotbeard has joined #openstack-nova | 09:04 | |
*** subscope has joined #openstack-nova | 09:08 | |
*** jinxing has joined #openstack-nova | 09:08 | |
*** moshele has joined #openstack-nova | 09:09 | |
*** browne has quit IRC | 09:09 | |
tangchen_ | alex_xu: Just FYI, I'm ready for the API doc work. You can contact me in IRC, and email (tangchen@cn.fujitsu.com). | 09:09 |
openstackgerrit | huan proposed openstack/nova: XenAPI:Resolve Nova/Neutron race condition https://review.openstack.org/241127 | 09:09 |
tangchen_ | alex_xu: I'm in Chinese Beijing time zone. | 09:10 |
*** yangyapeng has joined #openstack-nova | 09:11 | |
ndipanov | alex_xu, hmmm | 09:12 |
*** eglynn has joined #openstack-nova | 09:12 | |
*** fawadkhaliq has joined #openstack-nova | 09:12 | |
*** liusheng has quit IRC | 09:14 | |
ndipanov | so the problem there is that because we use the decorator for those in compute manager - we rely on them existing after the object .destroy() call | 09:14 |
ndipanov | which ever way you look at it - the problem is that events are not fully implemented in Nova, they are added to ad-hoc places | 09:15 |
ndipanov | alex_xu, ^ | 09:15 |
*** liusheng has joined #openstack-nova | 09:16 | |
ndipanov | it would maybe make sense to do it in destroy and provide a flag to defer it in case we are inside a context that know how to handle it | 09:17 |
ndipanov | no idea | 09:17 |
johnthetubaguy | ndipanov: I suspect thats ready too, given the summit discussion, will get to that one today, just about to review all the specs with +2s already | 09:18 |
openstackgerrit | Balazs Gibizer proposed openstack/nova-specs: Add notification for service status change https://review.openstack.org/182350 | 09:23 |
johnthetubaguy | ndipanov: agreed, with the events thing, totally need to find an approach we are happy with, and start applying it consistently, its kinda crazy right now | 09:23 |
*** fawadkhaliq has quit IRC | 09:23 | |
ndipanov | johnthetubaguy, it's about this https://review.openstack.org/#/c/231887/9/nova/compute/utils.py,cm | 09:24 |
johnthetubaguy | ndipanov: yeah, just taking a peak, certainly hints at the bigger issue we have around this stuff | 09:25 |
*** spandhe has quit IRC | 09:25 | |
gibi | alaski, bauzas: I updated Add notification for service | 09:26 |
gibi | status change https://review.openstack.org/182350 | 09:26 |
*** markmc has joined #openstack-nova | 09:26 | |
gibi | based on the discussison yesterday | 09:26 |
*** huanxie has joined #openstack-nova | 09:26 | |
*** BobBall_AWOL is now known as BobBall | 09:27 | |
johnthetubaguy | ndipanov: alex_xu: I wonder if the zero-th cell stuff could help us here, a dead host instance is move to the zero-th cell, then deleted in there, or some such... maybe that makes it worse | 09:27 |
*** liusheng has quit IRC | 09:27 | |
*** liusheng has joined #openstack-nova | 09:27 | |
johnthetubaguy | gibi: we need to get that blueprint approved, is it on a list somewhere already? | 09:27 |
johnthetubaguy | gibi: actually, don't you have a spec up for that somewhere? | 09:28 |
* johnthetubaguy face palm | 09:28 | |
johnthetubaguy | thats the spec, yes. hmm | 09:28 |
*** ociuhandu has joined #openstack-nova | 09:28 | |
gibi | johnthetubaguy: I think it is ready for approval, alaski had some comment yesterday but the last change is quite small | 09:29 |
*** huanxie has quit IRC | 09:29 | |
*** hightall has quit IRC | 09:30 | |
gibi | johnthetubaguy: I'm hasitating to do the same update on the versioned notification change spec as it is mostly consmetical there and related mostly to the implementation itself | 09:30 |
johnthetubaguy | gibi: yeah, I think that makes sense | 09:30 |
johnthetubaguy | gibi: i see the bigger spec mostly as directional | 09:31 |
gibi | johnthetubaguy: I have your +2 on the versioned notification spec already I will ping dansmith or some other core to get a second one today | 09:31 |
*** otter768 has joined #openstack-nova | 09:31 | |
bauzas | gibi: ack, today is a national holiday in France so I'll review it by tomorrow | 09:32 |
gibi | johnthetubaguy: yesterday we hade the first subteam meating but we have low attendance, hoping for a better one next week | 09:32 |
BobBall | johnthetubaguy: #openstack-meeting :) | 09:32 |
gibi | bauzas: happy holiday, thanks for the effort :) | 09:32 |
johnthetubaguy | bauzas: go forth and enjoy the holiday | 09:33 |
johnthetubaguy | BobBall: that would be the meeting reminder that I pressed dissmiss on too early | 09:33 |
johnthetubaguy | gibi: takes time to build momentum, good to get it rolling! | 09:34 |
gibi | johnthetubaguy: OK. I will push it forward :) | 09:35 |
BobBall | :D | 09:35 |
* johnthetubaguy metaphorically applies grease under versioned notifications | 09:35 | |
*** otter768 has quit IRC | 09:36 | |
garyk1 | ndipanov: a real no brainer if possible - https://review.openstack.org/218644 | 09:37 |
ndipanov | garyk1, even that is a stretch for me today :) | 09:37 |
garyk1 | :) | 09:37 |
ndipanov | garyk1, is this one of those us vs uk spelling things | 09:37 |
garyk1 | ndipanov: a moscow mule can solve all problems | 09:37 |
ndipanov | I am not going anywhere near that stuff | 09:37 |
*** lpetrut has joined #openstack-nova | 09:38 | |
*** ociuhandu_ has joined #openstack-nova | 09:39 | |
*** ociuhandu has quit IRC | 09:40 | |
*** ociuhandu_ is now known as ociuhandu | 09:40 | |
*** belmoreira has joined #openstack-nova | 09:41 | |
*** paul-carlton has quit IRC | 09:43 | |
*** gongysh_ has quit IRC | 09:44 | |
*** fawadkhaliq has joined #openstack-nova | 09:44 | |
*** mordred has joined #openstack-nova | 09:45 | |
*** terryyao has quit IRC | 09:45 | |
*** jistr has joined #openstack-nova | 09:45 | |
*** subscope has quit IRC | 09:46 | |
*** janiceonchn has joined #openstack-nova | 09:46 | |
*** sudipto has joined #openstack-nova | 09:46 | |
*** baoli has joined #openstack-nova | 09:48 | |
openstackgerrit | Matthew Booth proposed openstack/nova: Remove duplicate server.kill on test shutdown https://review.openstack.org/244027 | 09:51 |
*** gcb has quit IRC | 09:52 | |
*** baoli has quit IRC | 09:53 | |
*** alex_klimov has quit IRC | 09:56 | |
*** zhenguo has quit IRC | 09:56 | |
*** janiceonchn has quit IRC | 09:57 | |
*** subscope has joined #openstack-nova | 09:58 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: enginefacade: 'flavor' https://review.openstack.org/244029 | 09:58 |
*** Yanyanhu has quit IRC | 09:59 | |
*** ZZelle has joined #openstack-nova | 10:00 | |
*** haomaiwang has quit IRC | 10:01 | |
*** haomaiwa_ has joined #openstack-nova | 10:01 | |
*** rk4n has joined #openstack-nova | 10:02 | |
alex_xu | ndipanov: sorry, just get home | 10:03 |
ndipanov | alex_xu, no worries | 10:03 |
alex_xu | ndipanov: emm...a little hard to chocie, got it the events isn't good for now. how about we just ensure all the events was deleted for now? or you still perfer fix it in the compute-node side first | 10:04 |
ndipanov | alex_xu, well - I'd say I could live with a object fix with a flag to not do it | 10:06 |
alex_xu | ndipanov: ok, thanks :) | 10:06 |
*** aix has joined #openstack-nova | 10:08 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: Introduce utility module for pcp https://review.openstack.org/203163 | 10:09 |
andrearosa | gibi: I missed the meeting last night I am catching up right now, unfortunately that time doesn't work for me very well | 10:10 |
*** ihrachys has quit IRC | 10:16 | |
*** ihrachys has joined #openstack-nova | 10:17 | |
gibi | andrearosa: no problem. This time is hard for me too, but it seems we have interested parties from Australia as well, so we have to compromise | 10:19 |
*** ptm_away is now known as PaulMurray | 10:19 | |
gibi | andrearosa: if you have any question regarding the yesterday's meeting just ping me | 10:19 |
PaulMurray | johnthetubaguy, I gave a spec a -1 for having the priorities section in it on the grounds that it will be public documentation so it should be in right format. | 10:20 |
PaulMurray | johnthetubaguy, do you think that is over the top? | 10:20 |
danpb | PaulMurray: if that's the only problem with the spec, then its probably something can could be patched as a trivial followup patch | 10:20 |
danpb | if there's other issues then it should be fixed at the same time | 10:21 |
andrearosa | gibi: yes I understand that. Thanks for the offer, I agree with the mission statement and please add me as reviewer when you put the patch for the service status notification change, even if it is just a WIP | 10:21 |
alex_xu | tangchen_: cool, thanks! you can free to take tasks from https://etherpad.openstack.org/p/nova-v2.1-api-doc , free to reach me for any question | 10:21 |
*** pixelbeat has joined #openstack-nova | 10:22 | |
PaulMurray | danpb, johnthetubaguy ok - I'll change it to a nit and leave that guidance then, thanks | 10:22 |
gibi | andrearosa: great, I will add you to the reviews :) | 10:22 |
*** janiceonchn has joined #openstack-nova | 10:24 | |
*** janiceonchn has quit IRC | 10:24 | |
*** janiceonchn has joined #openstack-nova | 10:25 | |
*** janiceonchn has quit IRC | 10:25 | |
johnthetubaguy | PaulMurray: yeah, +1 to danpb's comment, I am worried more about the content right now, feel free to add a follow on patch to fix that | 10:25 |
danpb | PaulMurray: you could in fact alternatively just submit a dependant patch yourself to delete the section | 10:25 |
*** janiceonchn has joined #openstack-nova | 10:26 | |
PaulMurray | danpb, ok, thanks | 10:27 |
*** jinxing has quit IRC | 10:28 | |
PaulMurray | johnthetubaguy, danpb BTW - its this one - I think its ready to go: https://review.openstack.org/#/c/194990/ | 10:28 |
PaulMurray | split network plane for live migration | 10:28 |
johnthetubaguy | PaulMurray: cool, I do see the nice list of specs in the etherpad, I should go through those | 10:31 |
gibi | johnthetubaguy: You reviewed previously the https://review.openstack.org/#/c/240858/ Deprecate nova-manage service subcommand patche. I fixed your comments and I think this patch shall land early as it deprecate things. Could you please check it? | 10:32 |
kashyap | johnthetubaguy: Not sure if you've noticed already, your update on Nova talk is covered by LWN - https://lwn.net/Articles/662943/ | 10:33 |
*** alex_klimov has joined #openstack-nova | 10:34 | |
johnthetubaguy | kashyap: I have not | 10:34 |
johnthetubaguy | kashyap: thanks for the heads up :) | 10:34 |
kashyap | Nice to see folks at LWN cover OpenStack. | 10:35 |
*** paul-carlton has joined #openstack-nova | 10:35 | |
*** stevemar_ has joined #openstack-nova | 10:36 | |
*** nikhil has quit IRC | 10:36 | |
*** nikhil has joined #openstack-nova | 10:36 | |
*** markvoelker has quit IRC | 10:37 | |
openstackgerrit | Paul Murray proposed openstack/nova-specs: Trivial format fix for split network plane spec https://review.openstack.org/244041 | 10:37 |
*** stevemar_ has quit IRC | 10:38 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Remove onSharedStorage from evacuate API https://review.openstack.org/243562 | 10:40 |
*** cdent has joined #openstack-nova | 10:45 | |
PaulMurray | johnthetubaguy, ndipanov do you have a moment, its about volume operations and task states | 10:45 |
ndipanov | PaulMurray, you got anything easier maybe? P vs NP? the middle east? | 10:49 |
ndipanov | :) | 10:49 |
PaulMurray | ndipanov, hmmm, let me think... no | 10:50 |
ndipanov | PaulMurray, jk - what about volumes? | 10:50 |
PaulMurray | ndipanov, talking to dansmith and PhilDay I realised there is a synchronization problem with volume ops because they don't set task states | 10:50 |
ndipanov | hmm | 10:50 |
PaulMurray | there has been this bug for a while: https://bugs.launchpad.net/nova/+bug/1275144 | 10:50 |
openstack | Launchpad bug 1275144 in OpenStack Compute (nova) "Volume operations should set task state" [Low,Confirmed] - Assigned to Paul Murray (pmurray) | 10:51 |
PaulMurray | basically volume operations and rebuild/migrate/shelve etc are not mutually exclusive | 10:51 |
ndipanov | PaulMurray, seems like a legit issue | 10:51 |
PaulMurray | so we're proposing fixing that | 10:51 |
ndipanov | we could still have races with task state though | 10:52 |
ndipanov | but it would be an improvement | 10:52 |
PaulMurray | anything in particular? | 10:52 |
*** subscope has quit IRC | 10:53 | |
ndipanov | well check instance state checks it but does not set it in an atomic way | 10:53 |
ndipanov | I think | 10:53 |
*** omasz has joined #openstack-nova | 10:53 | |
*** subscope has joined #openstack-nova | 10:53 | |
PaulMurray | makes sense - I haven't dug into that - I expected it but kept my head in the sand | 10:53 |
*** claudiub has joined #openstack-nova | 10:53 | |
ndipanov | PaulMurray, emperor is naked | 10:54 |
ndipanov | :) | 10:54 |
*** omasz has left #openstack-nova | 10:54 | |
PaulMurray | I was about to sort it under the bug but then found this spec doing the same thing: https://review.openstack.org/#/c/243096/ | 10:54 |
ndipanov | so from my pov - this seems lika a legit issue - we are blocking some operations with a instance-wide semaphore on the compute hosts I think | 10:54 |
PaulMurray | oops, wrong spec | 10:54 |
ndipanov | that might be another approach | 10:55 |
ndipanov | s/blocking/serializing/ | 10:55 |
PaulMurray | It would have some interesting benefits | 10:55 |
PaulMurray | at the moment there is a call to reserve a name that is done as an rpc to the compute manager | 10:55 |
PaulMurray | that could be done locally if using task state to serialize | 10:56 |
PaulMurray | This is the spec I meant: https://review.openstack.org/#/c/216578/ | 10:56 |
ndipanov | PaulMurray, what if we had some kind of a... distributed lock manager... | 10:58 |
PaulMurray | ndipanov, don't even go there :) | 10:58 |
jaypipes | danpb: mornin. so, I'm cool with many of the changes in your pull request -- though the inheritance as you've designed with the o.vo objects won't work as designed, AFAICT). however, would it be OK with you if I go and create a vif-plug-ovs repository and pull the ovs and ovs hybrid plug code into there, so we have an actual plug driver to test with? | 10:58 |
johnthetubaguy | PaulMurray: yeah, been looking at the spec a bit | 10:59 |
johnthetubaguy | PaulMurray: the main issue I had is it broke the API semantics | 10:59 |
danpb | jaypipes: the inheritance should work - i used the same approach for my oslo-devsupport package and it worked there | 10:59 |
jaypipes | danpb: also, thanks very much for doing all the administrative legwork on gerrit and lp! | 10:59 |
jaypipes | danpb: ok. | 11:00 |
*** aysyd has joined #openstack-nova | 11:00 | |
danpb | unles there's been a regression in ovo since then of course... | 11:00 |
ndipanov | PaulMurray, I will read the spec and try to think about how we could leverage the locking that already exists | 11:00 |
jaypipes | danpb: on the vif-plug-ovs repo, you OK if I create that before merging your PR? | 11:00 |
danpb | i guess i should add some unit tests though to validate that it does indeed work :-) | 11:00 |
jaypipes | danpb: heh, yeah, we do need that of course, but hey, we've got some time to get that in order. | 11:00 |
ndipanov | imho task states are broken for that sort of thing | 11:00 |
*** haomaiwa_ has quit IRC | 11:01 | |
danpb | jaypipes: so you want to have a separate git repo that only contains the ovs plugin, as a kind of "best practice" illustration to vendors ? | 11:01 |
johnthetubaguy | ndipanov: +1 thats were the tasks idea was (partly) heading, but it grew too big an stalled | 11:01 |
*** haomaiwa_ has joined #openstack-nova | 11:01 | |
jaypipes | danpb: right, exactly. | 11:01 |
PaulMurray | johnthetubaguy, ndipanov at the moment the task state part is replicated between RuiChen spec and mine: https://review.openstack.org/#/c/216578/ and https://review.openstack.org/#/c/243096/ | 11:01 |
danpb | ok, that sounds fine to me | 11:01 |
johnthetubaguy | ndipanov: PaulMurray: my worry with that spec is it stops all volume attach/detach happening in paralel | 11:01 |
openstackgerrit | melanie witt proposed openstack/nova: Omit RescheduledException in instance_fault.message https://review.openstack.org/165751 | 11:02 |
openstackgerrit | melanie witt proposed openstack/nova: Add RPCIsSynchronousFixture for synchronous RPC casts https://review.openstack.org/244045 | 11:02 |
openstackgerrit | melanie witt proposed openstack/nova: Add a functional test for instance fault message with retry https://review.openstack.org/244046 | 11:02 |
jaypipes | danpb: k, I'll get on that this morning. | 11:02 |
danpb | so all the other "legacy" plugins can stay in nova/virt/libvirt then until we delete it in say Oxxxx | 11:02 |
ndipanov | johnthetubaguy, that is not good definitely | 11:02 |
PaulMurray | johnthetubaguy, only for an instance? Did it happen in parallel before? attach was synchronized | 11:02 |
jaypipes | danpb: cool with me. | 11:02 |
ndipanov | PaulMurray, on the compute node | 11:02 |
*** kairat has joined #openstack-nova | 11:02 | |
johnthetubaguy | PaulMurray: not from the API user perspective | 11:02 |
ndipanov | which is fine | 11:02 |
johnthetubaguy | ndipanov: yeah +1 your description of it | 11:03 |
danpb | jaypipes: i was thinking we should have a 'noop' plugin as part of omain os-vif repo too | 11:03 |
danpb | jaypipes: since , eg the 'bridge' vif config doesn't require any plug/unplug actions in the simple case | 11:03 |
PaulMurray | johnthetubaguy, so the problem is if you issue a second attach/detach while one is going on, you get an error return | 11:03 |
ndipanov | johnthetubaguy, yeah tasks would define this sort of stuff but bring a whole lot more | 11:03 |
johnthetubaguy | PaulMurray: what about rebasing your spec on top of Rui's spec? I know thats creating a painful chain, but that feels about right | 11:03 |
PaulMurray | johnthetubaguy, I'm happy with that | 11:04 |
johnthetubaguy | ndipanov: yeah, thinking no resize while any volume of vif attach is happening, is what we want | 11:04 |
PaulMurray | I think we need some agreement on the task approach though - I can see your point about serializing the operations | 11:04 |
johnthetubaguy | ndipanov: bit worried that over complicates things though | 11:04 |
PaulMurray | at the API | 11:04 |
jaypipes | danpb: yeah, that makes sense (though we should just call it bridge.py instead of noop and document that it contains an example plugin class. | 11:05 |
danpb | jaypipes: oh, and btw, before you merge that patch series, note that i have not tested it in any way whatsoever | 11:05 |
danpb | jaypipes: so it undoubtably has python syntax errors hiding in it somewhere | 11:05 |
jaypipes | danpb: lol, the whole thing hasn't been tested anywhere, so no worries :) | 11:05 |
danpb | ok, i guess #1 job is writing some unit tests :-) | 11:05 |
danpb | sahid might be interested in working on that | 11:05 |
jaypipes | danpb: it's a poc after all ;) right, first step is testing writing, but of course, that will be easier once we remove a whole bunch of stuff ;) | 11:05 |
johnthetubaguy | PaulMurray: yeah, for me its about keeping the API backwards compatible, but allowing the bug fix of stopping resize before an attach has finished, a new micro version could tell you about the state, but the old version stays the same as much as possible, I feel we have to do that | 11:06 |
danpb | jaypipes: btw do you have a pypi account ? if so let me know your username so i can grant permission os-vif module | 11:06 |
*** zhangjn has quit IRC | 11:06 | |
jaypipes | danpb: yup, I do. it's JayPipes | 11:07 |
*** yangyapeng has quit IRC | 11:07 | |
*** EinstCra_ has quit IRC | 11:07 | |
PaulMurray | johnthetubaguy, we have the problem that an API server and a compute manager can be on different code during upgrade. So API would need to know what | 11:07 |
danpb | jaypipes: hmm, is that correct capitalization - it claims that user doesn't exist | 11:08 |
PaulMurray | version of compute manager was going to handle the operation | 11:08 |
PaulMurray | If we included that it didn't do it for an old API, would that help (not sure how) | 11:08 |
jichen | alex_xu: are you around? | 11:08 |
johnthetubaguy | PaulMurray: I think we simply don't add the new state until all the computes are upgraded (i.e. the RPC API pin is lifted) | 11:08 |
jaypipes | danpb: Jay.Pipes maybe? | 11:09 |
alex_xu | jichen: hi, i'm here | 11:09 |
jaypipes | danpb: sorry, been a while since I released the talons library... | 11:09 |
danpb | yep, that works | 11:10 |
jaypipes | coolio, thanks. | 11:10 |
jichen | alex_xu: do we need open bugs for each item on https://etherpad.openstack.org/p/nova-v2.1-api-doc ? | 11:10 |
* jaypipes slaps PyPI for its insolence | 11:10 | |
kairat | Folks, During the image-upload I have found the following in Horizon: Images can be provided via an HTTP/HTTPS URL or be uploaded from your local file system. Compressed image binaries are supported (.zip and .tar.gz.). Do I understand correctly that if smb downloads a compressed image then he won't be able to boot it in Nova? | 11:11 |
alex_xu | jichen: emm...I think we needn't, as we already track them in the etherpad. But maybe we can have one bug to for this work | 11:11 |
kairat | here is horizon source: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/images/templates/images/images/_create.html | 11:11 |
PaulMurray | johnthetubaguy, that's good - what about the backward compatible API? Does one API server handle multiple versions at once? | 11:11 |
jichen | alex_xu: um.. open a bug is fine , let me do this and see how doc guys react | 11:11 |
kairat | I think this needs to be corrected but would like a confirmation from nova | 11:12 |
alex_xu | jichen: yea, see how doc team manage them. to be clear, I mean just one bug and put this etherpad link into it https://etherpad.openstack.org/p/nova-v2.1-api-doc | 11:12 |
jaypipes | kairat: yes, AFAIK, if someone uploads a compressed image, it will not be bootable by Nova. | 11:13 |
jichen | alex_xu: yeah, I have similar thought, but this might need their agreement since it will be hard for them to check , anyway, let me open it first | 11:13 |
kairat | jaypipes, ok, thanks | 11:14 |
*** subscope has quit IRC | 11:14 | |
jaypipes | kairat: that said, perhaps Horizon is actuall decompressing those uploads before passing them off to Glance? | 11:14 |
johnthetubaguy | PaulMurray: we do track that now (if that patch has merged) | 11:14 |
johnthetubaguy | PaulMurray: but you are right, you want all API nodes and all Compute nodes upgraded | 11:15 |
johnthetubaguy | PaulMurray: its tempting to claim API nodes are upgraded before you upgrade the compute nodes, but not sure we want to bake in that restriction | 11:15 |
kairat | jaypipes, AFAIK, no(i have seen some bugs about it). But I will check with Horizon guys. | 11:16 |
johnthetubaguy | PaulMurray: I would rather do the API last, but its a little impractical | 11:16 |
PaulMurray | johnthetubaguy, I'll try to coordinate with RuiChen to get his spec sorted with these issues and make mine depend on his. We can discuss more on the spec if needed - I've taken enough of your time now. | 11:19 |
johnthetubaguy | PaulMurray: thats cool, this is important stuff, appreciate you helping push this forward | 11:19 |
PaulMurray | thanks johnthetubaguy ndipanov | 11:19 |
openstackgerrit | Roman Bogorodskiy proposed openstack/nova-specs: User-controlled SR-IOV ports allocation https://review.openstack.org/182242 | 11:21 |
*** haomaiwa_ has quit IRC | 11:21 | |
*** haomaiwa_ has joined #openstack-nova | 11:21 | |
*** amotoki has joined #openstack-nova | 11:22 | |
*** stevemar_ has joined #openstack-nova | 11:23 | |
*** fawadkhaliq has quit IRC | 11:26 | |
*** stevemar_ has quit IRC | 11:26 | |
johnthetubaguy | PaulMurray: ndipanov: came up with a slightly horrid idea of looking a pending instance actions in the database to block the changing of tasks state from None to something else, that seems to meet all our goals at least, added comments in the spec | 11:27 |
johnthetubaguy | at least with that described in the spec, we have a clear choice between two viable directions | 11:27 |
johnthetubaguy | (an the complexity trade offs) | 11:28 |
alex_xu | jichen: ok, thanks | 11:29 |
*** EinstCrazy has joined #openstack-nova | 11:31 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: Introduce utility module for pcp https://review.openstack.org/203163 | 11:32 |
*** otter768 has joined #openstack-nova | 11:32 | |
*** liusheng has quit IRC | 11:33 | |
*** liusheng has joined #openstack-nova | 11:34 | |
*** rfolco has joined #openstack-nova | 11:34 | |
*** fawadkhaliq has joined #openstack-nova | 11:34 | |
*** ihrachys has joined #openstack-nova | 11:35 | |
*** gcb has joined #openstack-nova | 11:35 | |
*** zhangjn has joined #openstack-nova | 11:35 | |
*** fawadkhaliq has quit IRC | 11:35 | |
*** fawadkhaliq has joined #openstack-nova | 11:36 | |
*** otter768 has quit IRC | 11:37 | |
openstackgerrit | Roman Bogorodskiy proposed openstack/nova-specs: Distribute PCI Requests Across Multiple Devices https://review.openstack.org/142094 | 11:37 |
*** markvoelker has joined #openstack-nova | 11:37 | |
tdurakov | PaulMurray, hi, are you around? | 11:39 |
*** dims has joined #openstack-nova | 11:41 | |
PaulMurray | tdurakov, hi, yes I am | 11:42 |
*** markvoelker has quit IRC | 11:42 | |
tdurakov | PaulMurray, have you decided when to run subteam meeting? | 11:42 |
kashyap | There was a note on the mailing list that it's Tuesdays (some time, I have to look up). | 11:43 |
PaulMurray | yes, the patch for the IRC slot merged last night: Tuesdays at 1400 on openstack-meeting-3 | 11:44 |
*** kairat has left #openstack-nova | 11:44 | |
tdurakov | kashyap, PaulMurray, yep, Tuesdays at 1400 UTC on #openstack-meeting-3 starting. Just wanted to get some confirmation about | 11:44 |
tdurakov | thx | 11:44 |
PaulMurray | I will send another email to confirm today - I'm also just fixing up the wiki page with linkes etc and will send the email | 11:44 |
PaulMurray | tdurakov, I saw your patch for the CI job - I will get jLanoux to track it and help if he can | 11:47 |
openstackgerrit | Roman Bogorodskiy proposed openstack/nova-specs: User-controlled SR-IOV ports allocation https://review.openstack.org/182242 | 11:48 |
tdurakov | PaulMurray, sounds great:) there is another one in nova, where actually all magic should be done. Need to merge them first, than can continue with reconfiguration env for that | 11:48 |
PaulMurray | tdurakov, cool, thanks | 11:49 |
PaulMurray | do you have links | 11:49 |
PaulMurray | are they the ones in the etherpad ? | 11:50 |
tdurakov | PaulMurray, there is an etherpad with phases for this job, thanks a lot to sdague for that https://etherpad.openstack.org/p/live-migration-multinode Link for nova patch: https://review.openstack.org/#/c/243557/ | 11:50 |
tdurakov | also i've added draft for nfs inetherpad. it would be located in nova project | 11:51 |
*** kmartin has quit IRC | 11:52 | |
andrearosa | alex_xu: do you have time to discuss about your comments on https://review.openstack.org/226199 ? | 11:52 |
openstackgerrit | Sergey Nikitin proposed openstack/nova: enginefacade: 'instance_tags' https://review.openstack.org/244058 | 11:53 |
alex_xu | andrearosa: yea | 11:53 |
andrearosa | alex_xu: good. As regards the soft reboot we do not want to fall back to hard reboot as that will abort the live migration | 11:54 |
*** haomaiwa_ has quit IRC | 11:55 | |
*** smatzek has joined #openstack-nova | 11:55 | |
andrearosa | alex_xu: we can pass the info about that a live migration is in place down to the driver to avoid to call the hard reboot, how does it sound to you? | 11:55 |
tdurakov | has anyone problems with devstack right nova? | 11:56 |
tdurakov | *right now | 11:56 |
alex_xu | andrearosa: yea, that sounds work. | 11:57 |
*** zhangjn has quit IRC | 11:58 | |
BobBall | When attaching to an iSCSI block device, is (target_host, target_port, targetIQN) guaranteed to give you a single device? In general I might expect to also check the LUN or SCSIID, but these parameters aren't used (as far as I can see) by the libvirt driver? | 11:58 |
BobBall | oh - maybe I am blind... | 11:58 |
andrearosa | alex_xu: as regards the task_state I was thinking to leave nova managing what does at the moment but then add more logic to reverse the task_state to migrating if the migration is still running (don't know how to check it at the moment but I think there is a way) | 11:59 |
alex_xu | andrearosa: what is vm status to show for user? after the status rebooting, the status back to live migrating? | 11:59 |
alex_xu | andrearosa: yea, that works | 12:00 |
*** stevemar_ has joined #openstack-nova | 12:00 | |
andrearosa | alex_xu: last thing you were right about lock/unlock and rename they are already alloes operations, sorry for that. | 12:00 |
alex_xu | andrearosa: np | 12:00 |
andrearosa | alex_xu: I am going to recap everything in a new patch set. | 12:01 |
*** kylek3h has joined #openstack-nova | 12:01 | |
alex_xu | andrearosa: cool, thanks, and better write those reboot concern in the patch set | 12:01 |
*** rubasov has quit IRC | 12:01 | |
andrearosa | alex_xu: sure, thanks for your time. | 12:01 |
*** doug-fis_ is now known as doug-fish | 12:02 | |
alex_xu | andrearosa: np :) | 12:02 |
*** zhangjn has joined #openstack-nova | 12:02 | |
*** fawadkhaliq has quit IRC | 12:02 | |
*** subscope has joined #openstack-nova | 12:05 | |
*** kylek3h has quit IRC | 12:05 | |
*** mwagner has quit IRC | 12:08 | |
tdurakov | sdague, hi, seen your +2 for hook in nova, so when it's being merged, could we merge project-config part too? | 12:09 |
*** e0ne has quit IRC | 12:11 | |
openstackgerrit | jichenjc proposed openstack/nova: Make lock policy default to admin or owner https://review.openstack.org/242213 | 12:18 |
*** e0ne has joined #openstack-nova | 12:18 | |
*** Guest40458 has quit IRC | 12:19 | |
*** jwcroppe has joined #openstack-nova | 12:20 | |
*** rubasov has joined #openstack-nova | 12:20 | |
*** PaulMurray is now known as PaulMurray_lunch | 12:21 | |
sdague | tdurakov: so I withdrew the +2 for a minute, can you update the script with a header that explains a bit more about why it's there, or put a README in the live_migration directory? | 12:22 |
sdague | because it doesn't have a lot of context for other reviewers at this point | 12:22 |
sdague | and it would be good to stand on it's own as a review | 12:23 |
*** dansmith has joined #openstack-nova | 12:23 | |
*** dansmith is now known as Guest71273 | 12:23 | |
tdurakov | sdague, ok, sure, I'll add some info in header of this script | 12:24 |
afaranha | Hello, do anyone here runs devstack with SSL? And if so, how can I configure Nova to work with SSL? | 12:24 |
afaranha | When I use the curl command passing the ca-cert.pem it works fine, but using nova client it return "verify failed" | 12:24 |
sdague | tdurakov: thanks | 12:24 |
jaypipes | johnthetubaguy: I'm fine adding rest apis instead of nova-manage commands for the resource-providers thing. was trying to keep the (growing) scope down :) | 12:28 |
johnthetubaguy | jaypipes: yeah, keeping the scope small makes sense, maybe add a second spec for the REST API, although thats a little crazy? | 12:28 |
*** Marga_ has quit IRC | 12:30 | |
*** Marga_ has joined #openstack-nova | 12:30 | |
*** openstackgerrit has quit IRC | 12:31 | |
*** openstackgerrit has joined #openstack-nova | 12:32 | |
jaypipes | johnthetubaguy: no, I'll add the REST API scope to this one.. no worries. Need to change the os-simple-tenant-usage API extension imlpementation anyway because of this. | 12:33 |
*** lucasagomes is now known as lucas-hungry | 12:33 | |
jaypipes | sdague, johnthetubaguy, melwitt: the dependent patches from https://review.openstack.org/#/c/221310 look to be sensible and straightforward, if you have a chance to review, thanks in advance. | 12:34 |
johnthetubaguy | jaypipes: OK, makes sense | 12:34 |
*** mnestratov has joined #openstack-nova | 12:34 | |
johnthetubaguy | jaypipes: ah, these ones: https://review.openstack.org/#/q/topic:bp/new-oslodb-enginefacade,n,z | 12:35 |
jaypipes | johnthetubaguy: right. | 12:35 |
*** jinxing has joined #openstack-nova | 12:35 | |
jaypipes | johnthetubaguy: the base is now merged. the dependent patches incrementally enable the facade in the DB API. | 12:35 |
*** thorst has joined #openstack-nova | 12:35 | |
sdague | jaypipes: oh, so because the dependent patch merged, and those aren't a series, but a fan out, gerrit looses all the relationship info | 12:36 |
*** jerrygb has joined #openstack-nova | 12:37 | |
jaypipes | sdague: they are a series because they are topic-related, but are not strictly dependent on each other, yeah.. | 12:37 |
sdague | yep, I get it now | 12:38 |
sdague | is there a good pointer to the basics of engine fascade so I can educate myself enough for reviewing properly? | 12:38 |
openstackgerrit | Timofey Durakov proposed openstack/nova: Hook for live-migration job https://review.openstack.org/243557 | 12:38 |
tdurakov | sdague, jaypipes, done, please review again | 12:38 |
jaypipes | sdague: there is a very lengthy docstring in oslo.db, yeah... one sec, grabbing link. | 12:38 |
*** pratikmallya has joined #openstack-nova | 12:39 | |
*** Marga_ has quit IRC | 12:39 | |
*** Marga_ has joined #openstack-nova | 12:40 | |
jaypipes | sdague: actually, https://github.com/openstack/oslo.db/blob/master/doc/source/usage.rst covers the important bits. | 12:41 |
sdague | tdurakov: +2 | 12:41 |
jaypipes | sdague: but the idea here is that we are removing the manual session object handling/parameters and replacing with decorators that describe the sqlalchemy API function as either participating in a reader or writer transaction context. | 12:42 |
*** pratikmallya has quit IRC | 12:42 | |
sdague | and the writer / reader is signaling usage so that locking is optimized? | 12:43 |
jaypipes | sdague: correct. | 12:43 |
jaypipes | sdague: you will notice that these patches remove the use of: | 12:43 |
jaypipes | with session.begin(): | 12:43 |
jaypipes | blocks. | 12:43 |
openstackgerrit | Sudipta Biswas proposed openstack/nova: Introduce utility module for pcp https://review.openstack.org/203163 | 12:43 |
jaypipes | because the transaction handling is all done by the facade's transaction contexts | 12:43 |
sdague | yep, I think the only last question is around things like the foo.save(session=context.session) | 12:44 |
tdurakov | sdague, thank you! | 12:44 |
sdague | is that just because objects aren't aware | 12:45 |
*** thorst has quit IRC | 12:45 | |
jaypipes | sdague: hmm, I think dansmith had removed all uses of that (and replaced with save(context) instead, which would pass the context objec to the DB API method instead of any sesion. | 12:45 |
sdague | I'm looking at - https://review.openstack.org/#/c/239915/8/nova/db/sqlalchemy/api.py,cm | 12:45 |
sdague | it seems all the saves are done that way | 12:46 |
jaypipes | oh, yes, sorry I thought you meant the nova.objects.XXX.save() methods! | 12:46 |
mnestratov | Hi, all | 12:46 |
mnestratov | johnthetubaguy: thnak you for approving https://review.openstack.org/#/c/184295/ | 12:47 |
sdague | oh, right, I guess these are models not objects, my bad | 12:47 |
jaypipes | sdague: yes, the *SQLAlchemy* model object's save() method should always use the context.session parameter instead of the implicit session object (this gets rid of those annoying "cannot save orphaned object" messages. | 12:47 |
sdague | gotcha. I wonder if there is a way to make that more automatic in some way... | 12:48 |
mnestratov | johnthetubaguy: just wanted to make you a bit happier - we have CI as promised | 12:48 |
jaypipes | sdague: from what I gather from zzzeek, we deliberately wanted that to be explicit and not implicit any more. | 12:49 |
sdague | but, anyway, this makes sense to me now, I'll go through them in a few | 12:49 |
sdague | ok, that's cool | 12:49 |
*** astupnikov has joined #openstack-nova | 12:49 | |
sdague | for an effort like this in the future it might be nice to just have an email fired out with "reviewer notes" just so more people can get up to speed with the changes and review them faster, but I get it now. | 12:50 |
*** thorst has joined #openstack-nova | 12:50 | |
jaypipes | sdague: agreed completely. | 12:51 |
mnestratov | johnthetubaguy: see http://ci-watch.tintri.com/project?project=nova Virtuozzo CI, Virtuozzo Storage CI - are ours, and the storage one is testing https://review.openstack.org/#/c/190843/ changes | 12:51 |
*** astupnikov has quit IRC | 12:51 | |
*** markvoelker has joined #openstack-nova | 12:53 | |
sdague | jaypipes: https://review.openstack.org/#/c/240275/8/nova/db/sqlalchemy/api.py,cm soft_delete doesn't need a session? or is that because it got it handed it by the model that was created? | 12:53 |
sdague | L6371 | 12:54 |
*** rook has joined #openstack-nova | 12:54 | |
sdague | yeh, so there is a contradiction, the soft_delete here - https://review.openstack.org/#/c/244029/1/nova/db/sqlalchemy/api.py,cm does get passed a session | 12:55 |
sdague | so, one of those is wrong | 12:55 |
sdague | L4802 | 12:55 |
sdague | or I'm missing a subtlety | 12:56 |
*** pratikmallya has joined #openstack-nova | 12:58 | |
*** markvoelker has quit IRC | 12:58 | |
*** jhesketh has quit IRC | 12:58 | |
*** dims has quit IRC | 12:59 | |
jaypipes | sdague: looking.. | 12:59 |
*** fawadkhaliq has joined #openstack-nova | 12:59 | |
*** jhesketh has joined #openstack-nova | 13:00 | |
*** PaulMurray_lunch is now known as PaulMurray | 13:01 | |
*** gcb has quit IRC | 13:02 | |
jaypipes | sdague: looks like that is fine. It's not a contradiction. the SoftDeletMixin.soft_delete() expects a session argument: https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/models.py#L144 | 13:02 |
*** gcb has joined #openstack-nova | 13:03 | |
*** salv-orlando has joined #openstack-nova | 13:03 | |
sdague | jaypipes: ok, but when done as a model_query it returns a query, which has soft_delete as a mixin that doesn't need it? | 13:06 |
sdague | I guess that's just a bit of a confusing polymophism :) | 13:06 |
sdague | but so be it | 13:06 |
jaypipes | sdague: one sec, gimme a few, on phone now :) | 13:06 |
sdague | ok, no prob | 13:06 |
*** salv-orlando has quit IRC | 13:09 | |
*** jinxing has quit IRC | 13:10 | |
*** jyuso1 has quit IRC | 13:11 | |
*** takedakn has joined #openstack-nova | 13:11 | |
sdague | I had another general question, it was very clear before when sessions end and things commit or rollback | 13:14 |
*** Marga_ has quit IRC | 13:14 | |
*** achanda has joined #openstack-nova | 13:15 | |
sdague | in https://review.openstack.org/#/c/242019/6/nova/db/sqlalchemy/api.py,cm - when does the commit trigger for those things in context.session.add ?, when the function ends? | 13:15 |
*** xyang1 has joined #openstack-nova | 13:17 | |
*** dprince has joined #openstack-nova | 13:18 | |
*** achanda has quit IRC | 13:19 | |
dprince | TripleO has been broken for weeks due to this Nova bug. https://bugs.launchpad.net/tripleo/+bug/1513879 | 13:20 |
openstack | Launchpad bug 1513879 in OpenStack Compute (nova) "NeutronClientException: 404 Not Found" [High,In progress] - Assigned to Derek Higgins (derekh) | 13:20 |
dprince | Any core reviews on this (easy) fix would be appreciated... https://review.openstack.org/#/c/242158/ | 13:20 |
*** Marga_ has joined #openstack-nova | 13:21 | |
*** gcb has quit IRC | 13:21 | |
sdague | dprince: garyk indications it's just a client lib revision issue? | 13:24 |
garyk1 | sdague: i think that the issue is when the neutron plugin does not have l3 support. the fix looks good to me | 13:25 |
*** gcb has joined #openstack-nova | 13:25 | |
garyk1 | i tried to reproduce on trunk but was able to. i am not sure which plugin derrick is using | 13:26 |
*** bharath has quit IRC | 13:27 | |
dprince | sdague: so it was actually a Nova commit that brought this about... c62f698ef1f1e69bd5eb3c6544ee305f96488d42 | 13:27 |
dprince | got busy around summit and didn't catch this until last week | 13:28 |
sdague | what is the actual exception type that's exposed here when it fails this way | 13:28 |
sdague | because poking inside neutron client exception internals is a thing we'd kind of like to avoid if possible | 13:29 |
*** kylek3h has joined #openstack-nova | 13:29 | |
*** baoli has joined #openstack-nova | 13:30 | |
dprince | sdague: agree, but we view this as a regression. THe previous code worked... now it doesn't | 13:30 |
*** edmondsw has joined #openstack-nova | 13:31 | |
sdague | ok, sure, but before putting a bunch more ugly in here, it would be good to figure out if the right fix is actually neutronclient | 13:31 |
*** kylek3h has quit IRC | 13:31 | |
sdague | because I don't understand why it wouldn't return a sane thing here | 13:31 |
*** baoli_ has joined #openstack-nova | 13:31 | |
*** fawadkhaliq has quit IRC | 13:32 | |
*** fawadkhaliq has joined #openstack-nova | 13:32 | |
*** otter768 has joined #openstack-nova | 13:33 | |
johnthetubaguy | sdague: is it just me, or maybe we want both versions, so it could consider raising NotFound in the future? | 13:34 |
*** baoli has quit IRC | 13:35 | |
sdague | johnthetubaguy: well, if we fix neutronclient to be more coherent, get the release, and bump the minimum, it fixes it plus is less prone to future breaking | 13:35 |
johnthetubaguy | sdague: ah, true | 13:36 |
sdague | because it looks from comments that everyone expected this to be the contract | 13:36 |
sdague | https://review.openstack.org/#/c/242158/3/nova/tests/unit/network/test_neutronv2.py,cm seems to indication it's not an l3 issue, it's project not found exception from neutron | 13:36 |
sdague | is that because it's really an untranslated keystone exception? | 13:38 |
*** lykinsbd has joined #openstack-nova | 13:38 | |
*** otter768 has quit IRC | 13:38 | |
*** shardy has joined #openstack-nova | 13:38 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Added method is_supported to check API microversions https://review.openstack.org/240218 | 13:38 |
*** dave-mccowan has joined #openstack-nova | 13:41 | |
*** haomaiwang has joined #openstack-nova | 13:41 | |
*** mwagner has joined #openstack-nova | 13:42 | |
*** w_verdugo has quit IRC | 13:43 | |
*** pratikmallya has quit IRC | 13:44 | |
*** Marga_ has quit IRC | 13:44 | |
*** jichen has quit IRC | 13:46 | |
*** w_verdugo has joined #openstack-nova | 13:49 | |
derekh | sdague: even if it is fixed in neutron client, shoulnd the nova code be handling both the current case and the fixed ? | 13:49 |
derekh | sdague: context, this patch https://review.openstack.org/#/c/242158/ | 13:50 |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Added method is_supported to check API microversions https://review.openstack.org/240218 | 13:52 |
*** lykinsbd has quit IRC | 13:54 | |
*** subscope has quit IRC | 13:54 | |
*** markvoelker has joined #openstack-nova | 13:54 | |
mdbooth | sdague: https://review.openstack.org/#/c/244027/ :) Rethinking the semantics of the patch that broke it. | 13:54 |
*** lykinsbd has joined #openstack-nova | 13:55 | |
danpb | johnthetubaguy: as PTL we need your +1 on https://review.openstack.org/#/c/244097/ & https://review.openstack.org/#/c/244006 to approve setup of os-vif in infra, as we're saying it is under the Nova umbrella | 13:55 |
ansiwen | alaski: hi, I fixed a bug you reported. May wanna have a look? https://review.openstack.org/#/c/243616 | 13:56 |
sdague | derekh: the bug report is currently entirely a stack trace, it doesn't explain the request flow that gets you there and what's going on. Before reverting we need to at least understand a little. | 13:57 |
*** bharath has joined #openstack-nova | 13:57 | |
dprince | derekh: if we need to go and fix this in neutron/neutronclient then fine... but we should probably (at least try) to get Nova to bump their neutronclient once that happens if they only want the new codepath | 13:58 |
sdague | mdbooth: can we get that rechecked a few times | 13:58 |
derekh | sdague: its not a revert, ok I'll find out the neutronclient codepath | 13:58 |
*** markvoelker has quit IRC | 13:58 | |
sdague | derekh: or more details would be nice, like I said, the bug right now is just a stack trace | 13:59 |
sdague | and the patch implies it would only be triggered if you asked for non existant project_ids | 13:59 |
johnthetubaguy | danpb: cool, +1ed those | 13:59 |
lbelivea | ndipanov: following our discussion, please review https://review.openstack.org/#/c/242573/4 when you have a chance | 14:00 |
*** rlrossit has joined #openstack-nova | 14:00 | |
sdague | danpb: let me go see if I can shake a second +2 to get the repo built | 14:00 |
*** haomaiwang has quit IRC | 14:01 | |
openstackgerrit | Lorenzo Affetti proposed openstack/nova: FakeDriver: adding and removing instances on live migration. https://review.openstack.org/243613 | 14:01 |
*** mgoddard_ has joined #openstack-nova | 14:01 | |
*** haomaiwang has joined #openstack-nova | 14:01 | |
danpb | sdague: cool thanks | 14:01 |
derekh | sdague: yes it shows an exception that used to be caught and now clearly isn't, its not due to non existant project_ids its because our undercloud doesn't have a l3 agent and this is how neutron behaves when there is no L3 agent | 14:02 |
derekh | sdague: gotta do a school run will add more to the bug when I'm back | 14:02 |
*** bharath has quit IRC | 14:03 | |
*** mdrabe has joined #openstack-nova | 14:03 | |
sdague | derekh: hmmm except the code commit that put this in says this is how it does work in that case | 14:03 |
*** links has quit IRC | 14:04 | |
*** josecastroleon has joined #openstack-nova | 14:04 | |
*** mgoddard has quit IRC | 14:05 | |
*** pratikmallya has joined #openstack-nova | 14:05 | |
sdague | mdbooth: so if we pass recheck 5 times on that patch, I'm +2 | 14:06 |
sdague | mdbooth: I put a -1 on it for now just to indicate that expectation (with comments) | 14:07 |
*** fawadkhaliq has quit IRC | 14:07 | |
sdague | mdbooth: this also tripped up part of ceilometer, do they have an equiv fix? | 14:07 |
*** baoli_ has quit IRC | 14:08 | |
*** sudipto has quit IRC | 14:08 | |
*** rotbeard has quit IRC | 14:08 | |
*** agireud has quit IRC | 14:08 | |
*** NightKhaos has quit IRC | 14:08 | |
*** arif-ali has quit IRC | 14:08 | |
*** lyarwood has quit IRC | 14:08 | |
*** pratikma_ has joined #openstack-nova | 14:08 | |
*** ccarmack has joined #openstack-nova | 14:09 | |
*** pratikmallya has quit IRC | 14:10 | |
*** ctrath has joined #openstack-nova | 14:11 | |
*** su_zhang has joined #openstack-nova | 14:13 | |
*** subscope has joined #openstack-nova | 14:13 | |
*** dims has joined #openstack-nova | 14:15 | |
*** baoli_ has joined #openstack-nova | 14:15 | |
*** sudipto has joined #openstack-nova | 14:15 | |
*** rotbeard has joined #openstack-nova | 14:15 | |
*** agireud has joined #openstack-nova | 14:15 | |
*** NightKhaos has joined #openstack-nova | 14:15 | |
*** arif-ali has joined #openstack-nova | 14:15 | |
*** lyarwood has joined #openstack-nova | 14:15 | |
*** markvoelker has joined #openstack-nova | 14:15 | |
mdbooth | sdague: I'll look, thanks for the heads up. | 14:16 |
*** bharath has joined #openstack-nova | 14:16 | |
*** Piet has quit IRC | 14:17 | |
*** aix has quit IRC | 14:18 | |
*** mriedem has joined #openstack-nova | 14:21 | |
*** rotbeard has quit IRC | 14:21 | |
*** dims has quit IRC | 14:23 | |
*** Piet has joined #openstack-nova | 14:25 | |
*** dims has joined #openstack-nova | 14:26 | |
*** ijuwang has joined #openstack-nova | 14:27 | |
*** haomaiwang has quit IRC | 14:28 | |
*** cfriesen__ has joined #openstack-nova | 14:28 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: test:clean up wrong value in method CONF.set_override https://review.openstack.org/242416 | 14:28 |
*** haomaiwang has joined #openstack-nova | 14:28 | |
*** zhangjn has quit IRC | 14:28 | |
*** marzif_ has quit IRC | 14:29 | |
*** kylek3h has joined #openstack-nova | 14:33 | |
*** eharney has quit IRC | 14:36 | |
mriedem | johnthetubaguy: do you know if anyone from rax is going to take this over? https://review.openstack.org/#/c/215311/ | 14:37 |
mriedem | mikal: ^ | 14:37 |
mriedem | we have the lxc job in nova's experimental queue | 14:38 |
*** annegentle has joined #openstack-nova | 14:38 | |
johnthetubaguy | mriedem: his manager is trying to find someone to take it on, don't think he has found someone with spare cycles yet | 14:39 |
mriedem | ok | 14:39 |
*** Piet has quit IRC | 14:40 | |
mriedem | just offer him and comstud buckets of cash to come back | 14:40 |
*** bradjones|away is now known as bradjones | 14:40 | |
johnthetubaguy | mriedem: yeah, glad ew got that lxc gob in experimental, now to get it working I think dwalak (?) is pushing on that | 14:40 |
*** lucas-hungry is now known as lucasagomes | 14:40 | |
johnthetubaguy | mriedem: I am assuming they tried that already | 14:40 |
*** david-ly_ has joined #openstack-nova | 14:41 | |
*** takedakn has quit IRC | 14:41 | |
*** su_zhang has quit IRC | 14:42 | |
*** david-lyle has quit IRC | 14:42 | |
*** aix has joined #openstack-nova | 14:49 | |
*** diogogmt has joined #openstack-nova | 14:50 | |
*** mc_nair has joined #openstack-nova | 14:51 | |
*** signed8bit has joined #openstack-nova | 14:52 | |
*** dustins has joined #openstack-nova | 14:54 | |
*** Guest71273 is now known as dansmith | 14:54 | |
*** annegentle has quit IRC | 14:55 | |
*** mlavalle has joined #openstack-nova | 14:55 | |
mlavalle | johnthetubaguy: ping | 14:55 |
*** dansmith is now known as Guest36605 | 14:55 | |
raildo | johnthetubaguy: hey, now all test are passing, and I updated the bp status for 'needs code review' https://blueprints.launchpad.net/nova/+spec/nested-quota-driver-api :) | 14:58 |
*** annegentle has joined #openstack-nova | 14:58 | |
openstackgerrit | Anne Gentle proposed openstack/nova: Rearranges to create new Compute API Guide https://review.openstack.org/230186 | 14:58 |
openstackgerrit | John Garbutt proposed openstack/nova: Handle DB failures in servicegroup DB driver https://review.openstack.org/233914 | 14:59 |
*** annegentle has quit IRC | 15:00 | |
*** pradk has joined #openstack-nova | 15:00 | |
*** takedakn has joined #openstack-nova | 15:00 | |
*** dustins has quit IRC | 15:00 | |
*** haomaiwang has quit IRC | 15:01 | |
*** dustins has joined #openstack-nova | 15:01 | |
*** haomaiwang has joined #openstack-nova | 15:01 | |
*** dustins has quit IRC | 15:01 | |
*** fawadkhaliq has joined #openstack-nova | 15:01 | |
*** dims has quit IRC | 15:03 | |
*** breitz has joined #openstack-nova | 15:03 | |
*** claudiub has quit IRC | 15:04 | |
*** Guest36605 is now known as dansmith | 15:06 | |
mriedem | mnestratov: are you around? | 15:06 |
openstackgerrit | Sergey Nikitin proposed openstack/nova: WIP: enginefacade: 'fixed_ip' https://review.openstack.org/240811 | 15:07 |
openstackgerrit | Sergey Nikitin proposed openstack/nova: enginefacade: 'instance' https://review.openstack.org/244146 | 15:07 |
mnestratov | mriedem: yeah | 15:07 |
mriedem | mnestratov: i also asked in https://review.openstack.org/#/c/190843/ but does that allow attaching volumes using the vz storage backend to vz containers? | 15:07 |
mriedem | this is currently marked as missing http://docs.openstack.org/developer/nova/support-matrix.html#operation_attach_volume | 15:08 |
*** mgoddard has joined #openstack-nova | 15:11 | |
*** mgoddard_ has quit IRC | 15:11 | |
*** vladikr has joined #openstack-nova | 15:12 | |
*** yonglihe has joined #openstack-nova | 15:13 | |
*** diogogmt has quit IRC | 15:14 | |
johnthetubaguy | mlavalle: sorry, missed your pin, can I help? | 15:14 |
mnestratov | mriedem: that's right, with this change we can attach volumes to containers | 15:16 |
mlavalle | johnthetubaguy: just want to bring your attention to this spec: https://review.openstack.org/#/c/90150/ It's the DNS integration. When you guys have a chance, please review it | 15:16 |
*** thangp has joined #openstack-nova | 15:16 | |
*** garyk1 has quit IRC | 15:17 | |
mlavalle | johnthetubaguy: really looking forward to get it apporved for Mitaka | 15:17 |
mlavalle | approved^^^ | 15:17 |
*** yonglihe has quit IRC | 15:18 | |
*** yonglihe_ is now known as yonglihe | 15:18 | |
*** breitz has quit IRC | 15:18 | |
*** breitz1 has joined #openstack-nova | 15:18 | |
*** heyongli_ has joined #openstack-nova | 15:18 | |
*** mrkz has joined #openstack-nova | 15:19 | |
*** sneti has joined #openstack-nova | 15:20 | |
*** marzif_ has joined #openstack-nova | 15:20 | |
*** claudiub has joined #openstack-nova | 15:21 | |
*** breitz1 is now known as breitz | 15:22 | |
johnthetubaguy | mlavalle: that is on my TODO list, can't promise it will be today I am afraid. | 15:22 |
*** stackdump has joined #openstack-nova | 15:24 | |
mriedem | mnestratov: can you find a man page for pstorage-mount? i'm not finding one via google, just this: https://openvz.org/w/index.php?title=Virtuozzo_Storage | 15:24 |
*** eharney has joined #openstack-nova | 15:25 | |
mlavalle | johnthetubaguy: thanks! have a nice day :-) | 15:26 |
*** takedakn has quit IRC | 15:26 | |
mnestratov | mriedem: here you are https://openvz.org/Virtuozzo_Storage | 15:27 |
mnestratov | http://download.parallels.com/doc/pcs/pdf/Parallels_Cloud_Storage.pdf | 15:27 |
mriedem | 404 | 15:27 |
*** sfinucan has joined #openstack-nova | 15:27 | |
mriedem | https://download.openvz.org/doc/man-pages.pdf | 15:27 |
mnestratov | mriedem: oops | 15:27 |
*** claudiub has quit IRC | 15:28 | |
*** sneti has quit IRC | 15:28 | |
mriedem | but pstorage-mount isn't in that doc | 15:28 |
*** sneti has joined #openstack-nova | 15:28 | |
mnestratov | yeah, probably renaming issue | 15:28 |
*** stackdump has quit IRC | 15:28 | |
openstackgerrit | Andrea Rosa proposed openstack/nova-specs: Allow more instance operations during live migration https://review.openstack.org/226199 | 15:31 |
mnestratov | mriedem: hmm, I didn't know we have issues with documentations, trying to find out where I can get them | 15:31 |
*** kfarr has joined #openstack-nova | 15:31 | |
*** otter768 has joined #openstack-nova | 15:34 | |
*** HenryG has quit IRC | 15:34 | |
krotscheck | Could I get some core eyes on a CORS patch? [/ba-dum-bump] https://review.openstack.org/#/c/236993/ | 15:37 |
*** burgerk has joined #openstack-nova | 15:37 | |
*** salv-orlando has joined #openstack-nova | 15:38 | |
*** HenryG has joined #openstack-nova | 15:38 | |
mnestratov | mriedem: may be the best way to get full man pages is to install rpm, very little info is here http://download.cloudserver.odin.com/doc/pcs/en_us/parallels/6/current/pdf/Parallels_Cloud_Storage_Administrators_Guide.pdf | 15:38 |
*** bharath has quit IRC | 15:38 | |
*** otter768 has quit IRC | 15:39 | |
*** electrocucaracha has joined #openstack-nova | 15:41 | |
*** tonytan4ever has joined #openstack-nova | 15:44 | |
*** edtubill has joined #openstack-nova | 15:44 | |
openstackgerrit | dstepanenko proposed openstack/nova: WIP: This is 2nd part of changes according to pci-generate-stats blueprint. https://review.openstack.org/243131 | 15:47 |
*** tongli has joined #openstack-nova | 15:48 | |
*** emagana has joined #openstack-nova | 15:48 | |
*** dustins has joined #openstack-nova | 15:49 | |
sdague | danpb: https://review.openstack.org/#/c/244006/ is merged, repo should exist shortly | 15:52 |
danpb | great | 15:53 |
danpb | jaypipes: we're almost there for infra ^^^^ | 15:54 |
*** mtanino has joined #openstack-nova | 15:56 | |
*** armax has joined #openstack-nova | 15:56 | |
*** mdrabe has quit IRC | 15:57 | |
mriedem | mnestratov: ok, comments in https://review.openstack.org/#/c/190843/ | 15:57 |
mnestratov | mriedem: | 15:57 |
mnestratov | wget https://download.openvz.org/pstorage/current/pstorage-client-6.0.5-25.x86_64.rpm | 15:57 |
mnestratov | wget https://download.openvz.org/pstorage/current/pstorage-ctl-6.0.5-25.x86_64.rpm | 15:57 |
mnestratov | wget https://download.openvz.org/pstorage/current/pstorage-libs-shared-6.0.5-25.x86_64.rpm | 15:57 |
mnestratov | then | 15:57 |
mnestratov | yum install pstorage-libs-shared-6.0.5-25.x86_64.rpm | 15:57 |
mnestratov | yum install pstorage-ctl-6.0.5-25.x86_64.rpm | 15:57 |
mnestratov | yum install pstorage-client-6.0.5-25.x86_64.rpm | 15:57 |
mnestratov | man pstorage-mount | 15:57 |
mriedem | ew | 15:58 |
mriedem | can't that just be on a vz docs page somewhere? | 15:58 |
*** rook has quit IRC | 15:58 | |
jaypipes | danpb: sweet, thank you. I'm about 2 hours away from vif-plug-ovs completion. | 15:58 |
danpb | nb, our very first commit will need to have passing unit tests :-) | 15:59 |
danpb | i figure we just squash the history from your current git repo and push it as a single review | 15:59 |
*** haomaiwang has quit IRC | 16:01 | |
*** rook has joined #openstack-nova | 16:01 | |
*** Piet has joined #openstack-nova | 16:01 | |
*** haomaiwang has joined #openstack-nova | 16:01 | |
johnthetubaguy | danpb: can't infra do some import for you, behind gerrit? | 16:01 |
johnthetubaguy | danpb: although I guess its not much history to loose | 16:02 |
*** openstackgerrit has quit IRC | 16:02 | |
*** lbelivea has quit IRC | 16:02 | |
*** diogogmt has joined #openstack-nova | 16:02 | |
*** liverpooler has quit IRC | 16:02 | |
sfinucan | Could I ask what's the process for modifying a spec? For example, can they be modified once approved (i.e. to clarify something) and is it then a trivial reapproval? | 16:02 |
mnestratov | mriedem: it should have been, but I didn't find it. Responsinble people aren't around | 16:02 |
dansmith | sfinucan: yes | 16:02 |
*** openstackgerrit has joined #openstack-nova | 16:02 | |
johnthetubaguy | sfinucan: just put a change up for a spec, and it gets reviewed as normal | 16:03 |
sfinucan | dansmith: awesome. December 3 looms large... :) | 16:03 |
mnestratov | mriedem: thank for review, will try to address asap | 16:03 |
*** hogepodge has joined #openstack-nova | 16:03 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: config options: centralize section "serial_console" https://review.openstack.org/244177 | 16:03 |
*** kmartin has joined #openstack-nova | 16:04 | |
*** tonytan4ever has quit IRC | 16:04 | |
danpb | johnthetubaguy: yes, but I didn't think the current history was very important/useful, and this forces us to be good about unit testing the initial code :-) | 16:05 |
*** thedodd has joined #openstack-nova | 16:05 | |
johnthetubaguy | danpb: makes sense | 16:05 |
openstackgerrit | Matthew Booth proposed openstack/nova: Fix typo in test_post_select_populate https://review.openstack.org/244178 | 16:06 |
*** rook has quit IRC | 16:06 | |
mirrorbox | jaypipes: hey, are you around? | 16:07 |
*** david-ly_ is now known as david-lyle | 16:07 | |
*** rlrossit has quit IRC | 16:09 | |
openstackgerrit | Andrew Bogott proposed openstack/nova: Add disk_minimum_physical_free_space_ratio option to disk filter. https://review.openstack.org/242251 | 16:09 |
*** baoli_ has quit IRC | 16:10 | |
jaypipes | mirrorbox: just grabbing something to eat (getting grumpy...). will be back in about an hour, ok? | 16:10 |
*** marzif__ has joined #openstack-nova | 16:11 | |
jwcroppe | jaypipes: but you're always grumpy :) | 16:11 |
jaypipes | lol | 16:12 |
mirrorbox | jaypipes: bon appetit! just wanted to ping you to take a look at updates at https://review.openstack.org/#/c/182242/ | 16:12 |
*** rlrossit has joined #openstack-nova | 16:13 | |
*** belmoreira has quit IRC | 16:13 | |
jaypipes | mirrorbox: yup, it's on my list of reviews for today. | 16:13 |
sdague | https://github.com/openstack/os-vif looks like it's a thing as of 3 minutes ago, so go for it | 16:13 |
*** mdrabe has joined #openstack-nova | 16:14 | |
*** boris-42_ has joined #openstack-nova | 16:14 | |
*** subscope has quit IRC | 16:14 | |
*** whenry_ has joined #openstack-nova | 16:15 | |
*** subscope has joined #openstack-nova | 16:15 | |
*** tangchen__ has joined #openstack-nova | 16:16 | |
*** notmorga1 has joined #openstack-nova | 16:16 | |
mirrorbox | jaypipes: great, thanks | 16:16 |
*** subscope has quit IRC | 16:16 | |
mirrorbox | hm, and there were stuff i wanted to ask about os-vif btw | 16:16 |
*** EmilienM has quit IRC | 16:17 | |
*** kashyap has quit IRC | 16:17 | |
*** jdurgin1 has quit IRC | 16:17 | |
*** notmorgan has quit IRC | 16:17 | |
*** q3k has quit IRC | 16:17 | |
*** edtubill has quit IRC | 16:17 | |
*** marzif_ has quit IRC | 16:17 | |
*** boris-42 has quit IRC | 16:17 | |
*** wverdugo500 has quit IRC | 16:17 | |
*** sileht has quit IRC | 16:17 | |
*** tangchen_ has quit IRC | 16:17 | |
*** scheuran has quit IRC | 16:17 | |
*** tanee has quit IRC | 16:17 | |
*** dguitarbite has quit IRC | 16:17 | |
*** subscope has joined #openstack-nova | 16:17 | |
*** scheuran has joined #openstack-nova | 16:17 | |
*** EmilienM_ has joined #openstack-nova | 16:17 | |
*** wverdugo500 has joined #openstack-nova | 16:17 | |
*** tanee has joined #openstack-nova | 16:17 | |
*** dguitarbite has joined #openstack-nova | 16:17 | |
*** q3k1 has joined #openstack-nova | 16:17 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: config options: add hacking check for help text length https://review.openstack.org/242078 | 16:17 |
*** ctrath has quit IRC | 16:17 | |
*** kashyap has joined #openstack-nova | 16:17 | |
PaulMurray | RuiChen, are you around? | 16:18 |
*** dustins has quit IRC | 16:18 | |
*** EmilienM_ is now known as EmilienM | 16:18 | |
*** suro-patz has joined #openstack-nova | 16:18 | |
*** notmorga1 is now known as notmorgan | 16:18 | |
*** sileht has joined #openstack-nova | 16:18 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/243936 | 16:19 |
PaulMurray | RuiChen, wanted to talk about https://review.openstack.org/#/c/216578/ - I'll catch up with you later | 16:19 |
*** jdurgin1 has joined #openstack-nova | 16:19 | |
*** boris-42_ is now known as boris-42 | 16:19 | |
*** ctrath has joined #openstack-nova | 16:21 | |
*** dustins has joined #openstack-nova | 16:21 | |
openstackgerrit | Anne Gentle proposed openstack/nova: Rearranges to create new Compute API Guide https://review.openstack.org/230186 | 16:22 |
openstackgerrit | Dan Smith proposed openstack/nova: Fix race in _poll_shelved_instances task https://review.openstack.org/243724 | 16:22 |
openstackgerrit | Dan Smith proposed openstack/nova: Fix impotent _poll_shelved_instances tests https://review.openstack.org/243740 | 16:22 |
ccarmack | mriedem: do you a little time to look at my reply to your comments on https://review.openstack.org/#/c/228908/10/specs/mitaka/approved/user-settable-server-description.rst | 16:23 |
*** salv-orlando has quit IRC | 16:23 | |
*** janiceonchn has quit IRC | 16:23 | |
*** gcb has quit IRC | 16:24 | |
mriedem | when i get to it | 16:24 |
*** whenry_ has quit IRC | 16:25 | |
heyongli_ | hi, now PCI CI occasionally hit bug: https://bugs.launchpad.net/oslo.db/+bug/1477080. if any one know how to elimated this bug effect before it finally packaged, ping me please. | 16:27 |
openstack | Launchpad bug 1477080 in oslo.db "No _writer_maker attribute on enginefacade.writer" [Medium,In progress] - Assigned to Mike Bayer (zzzeek) | 16:27 |
*** klkumar has joined #openstack-nova | 16:27 | |
*** subscope has quit IRC | 16:27 | |
*** alex_klimov has quit IRC | 16:27 | |
*** subscope has joined #openstack-nova | 16:29 | |
mriedem | rpodolyaka: snikitin: ^ | 16:29 |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs: Add 'auto' case to virt-driver CPU thread pinning https://review.openstack.org/244198 | 16:29 |
*** dims has joined #openstack-nova | 16:30 | |
*** subscope has quit IRC | 16:30 | |
garyk | mriedem: can you please look at https://review.openstack.org/#/c/165750/ | 16:31 |
zzzeek | heyongli_: that can't be quite the same thing | 16:31 |
*** josecastroleon has quit IRC | 16:32 | |
heyongli_ | zzzeek, what's the different there? any idea? | 16:32 |
zzzeek | heyongli_: ive no idea why youd be seeing an issue w nova which is still on legacyfacade, unless this is the new version that just merged enginefacade | 16:32 |
mriedem | garyk: that's a lot of +1 | 16:33 |
heyongli_ | here is a example log:http://52.27.155.124/243557/2/screen-logs/n-api.log.gz | 16:33 |
*** vladikr has quit IRC | 16:33 | |
mriedem | too many +1, -1! | 16:33 |
*** subscope has joined #openstack-nova | 16:33 | |
openstackgerrit | Derek Higgins proposed openstack/nova: Handle a NeutronClientException 404 Error for floating ips https://review.openstack.org/242158 | 16:33 |
sfinucan | danpb: mriedem: I would be grateful if you could check in on that thread pinning spec rework when possible. I'm blocked by both that and the 'bug/1501358' changes from Nikola :( | 16:35 |
sfinucan | Code reviews for the rest of the day, it seems :) | 16:35 |
heyongli_ | zzzeek, CI testing, some patch hit that, i just don't know what exactly happened in that bug. some patch does running into _writer_maker then hit that. | 16:35 |
zzzeek | heyongli_: OK but this is unreleased code right | 16:36 |
sdague | mriedem: https://review.openstack.org/#/c/243327/1 is such an unlucky change | 16:36 |
heyongli_ | zzzeek, that mean some oslo package too new for nava, right, let me check that. | 16:36 |
garyk | mriedem: the request was that for all vmware patches we get a couple of guys to look. | 16:37 |
*** suro-patz has quit IRC | 16:37 | |
mriedem | garyk: i know, i was joking | 16:37 |
mriedem | garyk: i'm reviewing it now | 16:37 |
garyk | :) | 16:37 |
garyk | thanks | 16:37 |
openstackgerrit | Andrea Rosa proposed openstack/nova-specs: Allow more instance operations during live migration https://review.openstack.org/226199 | 16:37 |
mriedem | sdague: would be nice if e-r was commenting on changes | 16:37 |
sdague | yeh | 16:37 |
mriedem | i thought clarkb got that sorted out? | 16:37 |
sdague | ok, so I'm a little confused about the ebtables errors | 16:37 |
*** dprince has quit IRC | 16:38 | |
sdague | because we get these collision failures some times | 16:38 |
sdague | and yet, we don't ever seem to have any content in ebtables | 16:39 |
*** marzif__ has quit IRC | 16:39 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add 'hw_cpu_threads_policy' to ImageMetaProps https://review.openstack.org/202647 | 16:39 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=separate' scheduling https://review.openstack.org/202652 | 16:39 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Make use of 'InstanceNUMACell.cpu_policy' field https://review.openstack.org/202653 | 16:39 |
openstackgerrit | Stephen Finucane proposed openstack/nova: trivial: Make use of 'CPU(Thread)Allocation' enum https://review.openstack.org/202654 | 16:39 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=isolate' scheduling https://review.openstack.org/202655 | 16:39 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add 'cpu_policy' and 'cpu_threads_policy' fields https://review.openstack.org/202648 | 16:39 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=avoid' filtering https://review.openstack.org/202649 | 16:39 |
openstackgerrit | Stephen Finucane proposed openstack/nova: trivial: Add some logs to 'numa_topology_filter' https://review.openstack.org/202650 | 16:39 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=require' scheduling https://review.openstack.org/202651 | 16:39 |
*** haomaiwang has quit IRC | 16:40 | |
*** ndipanov has quit IRC | 16:41 | |
*** vilobhmm has joined #openstack-nova | 16:42 | |
*** liusheng has quit IRC | 16:42 | |
*** liusheng has joined #openstack-nova | 16:43 | |
*** dims has quit IRC | 16:44 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: FakeDriver: adding and removing instances on live migration. https://review.openstack.org/243613 | 16:45 |
zzzeek | heyongli_: can you please post your issue as a new issue on nova ? thanks | 16:45 |
*** garyk has quit IRC | 16:46 | |
mirrorbox | johnthetubaguy: hi John. could you suggest what would be a realistic plan to move toward bsd support wrt. os-vif etc? | 16:46 |
mirrorbox | johnthetubaguy: context: linux_net spec | 16:47 |
*** scheuran has quit IRC | 16:47 | |
*** mjura has quit IRC | 16:49 | |
*** apoorvad has joined #openstack-nova | 16:49 | |
heyongli_ | zzzeek, sure, that's also a good idea. | 16:51 |
*** garyk has joined #openstack-nova | 16:51 | |
johnthetubaguy | PaulMurray: just looking at live-migrate query and cancel spec, it mentions token expiery | 16:52 |
johnthetubaguy | PaulMurray: do you know the IRC nick of that spec author? | 16:52 |
*** ociuhandu has quit IRC | 16:52 | |
*** lykinsbd has quit IRC | 16:52 | |
johnthetubaguy | PaulMurray: oh wait, I found it | 16:52 |
johnthetubaguy | paul-carlton: just taking a look at your spec, if you are around https://review.openstack.org/#/c/228828/11/specs/mitaka/approved/refresh-abort-live-migration.rst,cm | 16:52 |
johnthetubaguy | mirrorbox: honestly, it feels like something that should be done in Neutron, looking at their ML2 plugin and making that work on BSD | 16:53 |
johnthetubaguy | mirrorbox: I don't really want us adding features like BSD support into nova-network, if we can help it | 16:54 |
dansmith | sdague: https://review.openstack.org/#/c/242158/4 | 16:54 |
dansmith | sdague: I think that's ready | 16:54 |
*** ociuhandu has joined #openstack-nova | 16:54 | |
*** pixelbeat has quit IRC | 16:55 | |
johnthetubaguy | dansmith: ah, that looks like what I expected to see for that fix | 16:55 |
dansmith | johnthetubaguy: yeah | 16:55 |
johnthetubaguy | dansmith: oh wait, doesn't the unit test only cover one of the code paths now? | 16:55 |
*** hemna has joined #openstack-nova | 16:55 | |
*** jlanoux has quit IRC | 16:55 | |
dansmith | johnthetubaguy: the original patch included a test for the new case it added, right/ | 16:55 |
johnthetubaguy | dansmith: this patch seems to modify the existing test for the old code path though | 16:56 |
dansmith | hmm, maybe it didn't because they didn't remove it | 16:56 |
dansmith | ah, right, duh | 16:56 |
dansmith | heh, sdague just +Wd it | 16:56 |
dansmith | johnthetubaguy: I'll follow up and fix the tests | 16:57 |
sdague | oh, sorry, I missed that bit | 16:57 |
sdague | yeh, followup fix for the tests seems fine | 16:57 |
*** edtubill has joined #openstack-nova | 16:57 | |
dansmith | it's okay, let's land the fix and unblock people | 16:57 |
johnthetubaguy | yeah, I am cool with that | 16:57 |
sdague | just ping me when that's up so we can land the second patch quick as well | 16:57 |
dansmith | okay | 16:57 |
*** mgoddard has quit IRC | 16:59 | |
*** mgoddard_ has joined #openstack-nova | 16:59 | |
*** ccarmack has quit IRC | 17:00 | |
*** vilobhmm has quit IRC | 17:00 | |
*** tonytan4ever has joined #openstack-nova | 17:01 | |
*** suro-patz has joined #openstack-nova | 17:03 | |
openstackgerrit | Dan Smith proposed openstack/nova: Add test coverage for both types of not-found-ness in neutronclient for floating https://review.openstack.org/244219 | 17:03 |
dansmith | sdague: ^ | 17:03 |
*** thedodd has quit IRC | 17:04 | |
sdague | dansmith: +2 | 17:04 |
dansmith | johnthetubaguy: ^ | 17:04 |
heyongli_ | zzzeek, new bug filled https://bugs.launchpad.net/nova/+bug/1515326, it does not exactly same, just a same named function in nova api. thank you. | 17:04 |
openstack | Launchpad bug 1515326 in OpenStack Compute (nova) " nova.api.openstack.extensions AttributeError: '_TransactionFactory' object has no attribute '_writer_maker'" [Undecided,New] | 17:04 |
*** thedodd has joined #openstack-nova | 17:04 | |
mirrorbox | johnthetubaguy: nova-network and vif stuff share quite a lot of code, though things could be done on neutron part as well. the question is what's the plan regarding os-vif integration? | 17:05 |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova-specs: Libvirt: Use the virtlogd deamon for logs https://review.openstack.org/234291 | 17:06 |
*** rushil has joined #openstack-nova | 17:06 | |
dansmith | sdague: do you think there's any way we're hitting this race in our tests sometimes, leading to shelve-related failrues? https://review.openstack.org/#/c/243724/ | 17:07 |
johnthetubaguy | mirrorbox: unsure right now, leaving that with danpb and jaypipes to sort out, I suspect its a case of creating os-vif-lib then seeing what can be re-used from inside there | 17:07 |
dansmith | sdague: we run that task by default and with the periodic staggered start, I would think we could be running it during a normal test run | 17:07 |
sdague | dansmith: it seems like it could be a thing | 17:08 |
sdague | the shelved tests are the most flakey multinode tests right now | 17:08 |
dansmith | right | 17:08 |
*** q3k1 is now known as q3k | 17:08 | |
mirrorbox | johnthetubaguy: do you know if there's some specs / meetings to follow on that subject? | 17:08 |
mriedem | garyk: reviewed https://review.openstack.org/#/c/165750/ | 17:09 |
*** nikhil_k has joined #openstack-nova | 17:09 | |
sdague | dansmith: help me understand that one | 17:09 |
jaypipes | mirrorbox: the plan is to gradually replace the plug/unplug code in nova/virt/libvirt/vif.py with the os-vif library's driver interface (which loads plug drivers via stevedore) | 17:09 |
johnthetubaguy | mirrorbox: the spec for os-vif is merged now, I would ask danpb or jaypipes for more details... ah there we go | 17:09 |
danpb | mirrorbox: johnthetubaguy os-vif is not intended to contain any code related to host OS networking setup | 17:10 |
*** prometheanfire has joined #openstack-nova | 17:10 | |
danpb | it will purely define the plugin interface & object model | 17:10 |
dansmith | sdague: we shelve a guest and then race with delete or unshelve or anything else | 17:10 |
dansmith | sdague: and we'll surely race with volume attach/detach once PaulMurray adds that | 17:10 |
danpb | any refactoring of stuff like linux_net is being punted | 17:10 |
prometheanfire | can nova handle multiple hypervisor arches in one region? say armv8 and x86_64 | 17:10 |
danpb | as that really belongs in standalone libraries on pypi | 17:10 |
prometheanfire | iirc, the scheduler can handle it | 17:10 |
danpb | or network helpers under oslo etc | 17:11 |
garyk | mriedem: thanks | 17:11 |
sdague | dansmith: what would the task_state be there that's leaking through? | 17:11 |
mriedem | prometheanfire: should be able to using host aggregates | 17:11 |
sdague | I guess I just need an example to get this in my head | 17:11 |
jaypipes | mirrorbox: danpb just did an excellent job summarizing the strategy. :) | 17:11 |
dansmith | sdague: deleting for the delete case.. PaulMurray is going to have to add some for volume attach | 17:11 |
mirrorbox | danpb: so, basically, there will be os-vif with just interface and some third party repos with the actual os-specific stuff? | 17:11 |
dansmith | sdague: regardless, we should pretty much never be setting task_state on an instance without passing expected_task_state | 17:12 |
*** moshele has quit IRC | 17:12 | |
*** nikhil has quit IRC | 17:12 | |
sdague | dansmith: ok, sure | 17:12 |
mirrorbox | I've seen a repo on github and there was some actuall implementation there. though I understand that it must be very new and stuff was just copied over from linux_net and friends | 17:12 |
prometheanfire | mriedem: cool, was thinking of getting an a couple of the new tx1s to test on | 17:12 |
dansmith | sdague: because that's our only way to detect a race that would override that lock | 17:12 |
*** liusheng has quit IRC | 17:12 | |
dansmith | sdague: you see the race with unshelve though right? | 17:13 |
dansmith | sdague: you shelve the instance, then race with the task to set unshelving or shelving_offloading | 17:13 |
danpb | mirrorbox: don't consider that github repo to reflect current intention - that's a PoC jay did a while ago | 17:13 |
*** liusheng has joined #openstack-nova | 17:13 | |
dansmith | sdague: if you do, then the instance starts getting unloaded off the compute host as you're trying to start it there | 17:13 |
danpb | and we've got a bunchof changes to it pending | 17:13 |
*** salv-orlando has joined #openstack-nova | 17:13 | |
*** subscope has quit IRC | 17:13 | |
jaypipes | PaulMurray: how would rebuilding an instance from source image be "less costly" than launching a new instance from a base image? | 17:13 |
mirrorbox | danpb: ah, I see. so the question is: how to follow the os-vif related stuff to check what's going on? | 17:14 |
danpb | mirrorbox: eg this https://github.com/jaypipes/os_vif/pull/3 | 17:14 |
danpb | mirrorbox: we're in process of setting up infrastructure (launchpad, gerrit, teams, etc) | 17:14 |
sdague | dansmith: yeh, seems reasonable | 17:14 |
danpb | we'll announce on openstack-dev when its all ready | 17:14 |
sdague | whether or not it fixes our gate races, this seems like the old code is wrong | 17:14 |
sdague | +A | 17:15 |
jaypipes | mirrorbox: right. I'm pushing up the first vif-plug-ovs repository and danpb's PR #3 will remove the plugin examples that are currently in the jaypipes/os_vif lib. | 17:15 |
dansmith | sdague: it's definitely wrong, yeah | 17:15 |
mirrorbox | danpb: great, looking forward to it | 17:15 |
dansmith | sdague: it would just be awesome if it improves stuff visibly | 17:15 |
sdague | dansmith: agree | 17:15 |
mirrorbox | jaypipes: danpb: fwiw, this os-vif looks like a good idea to me :) | 17:15 |
*** jistr is now known as jistr|off | 17:16 | |
*** jistr|off has quit IRC | 17:16 | |
mriedem | wtf does this mean? https://review.openstack.org/#/c/242158/4/nova/network/neutronv2/api.py | 17:16 |
mriedem | neutron client is currrently using NeutronClientException when there is no L3 API | 17:16 |
*** prometheanfire has left #openstack-nova | 17:16 | |
sdague | mriedem: yes | 17:17 |
danpb | mriedem: it is supposed to use NotFound, but mistakenly uses NeutronClientException | 17:17 |
mriedem | so a bug in neutronclient right? | 17:17 |
sdague | well, I think it's more that everything in neutron client is a bunch of generic transforms | 17:17 |
*** rook has joined #openstack-nova | 17:18 | |
dansmith | mriedem: yeah, and we've been papering over it for a while, which is why we're having it stay until neutronclient gets fixed | 17:18 |
sdague | so if neutron doesn't return a very structured error document, which it only does when the API actually talks to an agent, it falls back into this generic mapping | 17:18 |
mriedem | "Because it means you have to know the topology of the services on the neutron side in order to use python-neutronclient correctly." | 17:18 |
mriedem | my eyes are bleeding | 17:18 |
mriedem | so umm, let's just go back to writing our own in tree neutron rest API service like tempest has :) | 17:19 |
*** tdurakov is now known as Guest49793 | 17:19 | |
mriedem | i tihnk someone else said they'd work on that in YVR | 17:19 |
*** tdurakov has joined #openstack-nova | 17:19 | |
sdague | https://github.com/openstack/python-neutronclient/blob/adc53158c8d6f62882cdedf842e757a539baad5c/neutronclient/v2_0/client.py#L38-L88 | 17:19 |
sdague | so, read that block of code | 17:20 |
*** danpb has quit IRC | 17:20 | |
sdague | then wash out your mouth | 17:20 |
mriedem | i usually throw up out of my nose too | 17:20 |
mriedem | it's a whole big thing with me | 17:20 |
sdague | https://github.com/openstack/python-neutronclient/blob/adc53158c8d6f62882cdedf842e757a539baad5c/neutronclient/v2_0/client.py#L52 is really the crux of it | 17:20 |
mriedem | ah ok | 17:21 |
mriedem | well that's nice | 17:21 |
mriedem | you might get NotFound, you might not | 17:21 |
sdague | right | 17:21 |
mriedem | so handle everything | 17:21 |
mriedem | btw, let me kick you in the balls quick while i'm at it | 17:21 |
sdague | so, it should give us NotFound all the time | 17:21 |
sdague | the current nova work around at least comments to that fact, and the bug has been put on neutronclient | 17:21 |
*** pixelbeat has joined #openstack-nova | 17:22 | |
mriedem | yeah, the comment was just a bit confusing | 17:22 |
mriedem | "neutron client is buggy and can return either exception type, so we have to handle both" | 17:22 |
mriedem | anyway, meh, doesn't matter | 17:22 |
*** nic has joined #openstack-nova | 17:22 | |
mriedem | thanks for explaining | 17:22 |
sdague | yeh, no prob. | 17:22 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/243936 | 17:22 |
*** diogogmt_ has joined #openstack-nova | 17:23 | |
*** rook has quit IRC | 17:23 | |
johnthetubaguy | oh, so it has to hit here for us to get nice exceptions: https://github.com/openstack/python-neutronclient/blob/adc53158c8d6f62882cdedf842e757a539baad5c/neutronclient/v2_0/client.py#L69 | 17:23 |
mriedem | yeah | 17:24 |
mriedem | it has a mapping | 17:24 |
johnthetubaguy | bummer | 17:24 |
*** sayali has quit IRC | 17:24 | |
*** diogogmt has quit IRC | 17:24 | |
*** diogogmt_ is now known as diogogmt | 17:24 | |
mriedem | https://github.com/openstack/python-neutronclient/blob/adc53158c8d6f62882cdedf842e757a539baad5c/neutronclient/common/exceptions.py#L103 | 17:24 |
mriedem | i think something else too, like they have a PortNotFound | 17:25 |
mriedem | https://github.com/openstack/python-neutronclient/blob/adc53158c8d6f62882cdedf842e757a539baad5c/neutronclient/common/exceptions.py#L114 | 17:25 |
sdague | mriedem: the mapping is only used if you get the structured error doc from neutron | 17:25 |
sdague | which I guess you only get if it talked to an agent | 17:25 |
sdague | not if that agent isn't there | 17:25 |
sdague | so we hit the else in L77 | 17:26 |
*** tpeoples has quit IRC | 17:26 | |
*** tdp has joined #openstack-nova | 17:26 | |
sdague | and don't get to use the mapping in L67 | 17:26 |
*** tdp has quit IRC | 17:27 | |
openstackgerrit | Andrew Laski proposed openstack/nova: Cells: Support external network events https://review.openstack.org/184155 | 17:27 |
*** tpeoples has joined #openstack-nova | 17:27 | |
mriedem | dansmith: i have my finger on +W but wanted you to see a comment first https://review.openstack.org/#/c/244219/1/nova/tests/unit/network/test_neutronv2.py | 17:27 |
*** pratikma_ has quit IRC | 17:28 | |
dansmith | mriedem: I consider fixed to be "and released | 17:28 |
dansmith | since that's all we use | 17:28 |
mriedem | well, the bigger point was "in neutronclient" | 17:28 |
*** suro-patz has quit IRC | 17:28 | |
dansmith | the other comment in the code mentions neutronclient | 17:29 |
dansmith | but if you want it changed, I can | 17:29 |
dansmith | (after the meeting I'm in) | 17:29 |
*** lpetrut has quit IRC | 17:29 | |
mriedem | naw, +W, i didn't see the comment below it | 17:29 |
*** kmartin has quit IRC | 17:31 | |
*** klkumar has quit IRC | 17:32 | |
*** cdent has quit IRC | 17:32 | |
*** subscope has joined #openstack-nova | 17:33 | |
*** heyongli_ has quit IRC | 17:33 | |
*** dustins has quit IRC | 17:34 | |
*** dustins has joined #openstack-nova | 17:34 | |
*** klkumar has joined #openstack-nova | 17:34 | |
*** subscope has quit IRC | 17:35 | |
*** otter768 has joined #openstack-nova | 17:35 | |
*** markvoelker has quit IRC | 17:35 | |
*** vilobhmm has joined #openstack-nova | 17:36 | |
*** sayali has joined #openstack-nova | 17:36 | |
*** rfolco has quit IRC | 17:37 | |
*** whenry_ has joined #openstack-nova | 17:38 | |
paul-carlton | johnthetubaguy I agree, it should be split up into several specs | 17:38 |
*** spandhe has joined #openstack-nova | 17:38 | |
*** kmartin has joined #openstack-nova | 17:40 | |
*** otter768 has quit IRC | 17:40 | |
paul-carlton | Did you see my email dlist titled [openstack-dev] [nova] live migration management approach yesterday | 17:40 |
*** ccarmack has joined #openstack-nova | 17:41 | |
paul-carlton | I was thinking that we could simplify this stuff by adding additional actions to the instance object | 17:41 |
*** ijw has joined #openstack-nova | 17:41 | |
paul-carlton | Your comment on https://review.openstack.org/#/c/229040/ seems to suggest this is something you would support? | 17:42 |
*** annegentle has joined #openstack-nova | 17:43 | |
*** jdurgin1 has quit IRC | 17:43 | |
*** mlavalle has quit IRC | 17:44 | |
*** browne has joined #openstack-nova | 17:44 | |
*** sudipto has quit IRC | 17:44 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: Removes support for Hyper-V Server 2008 R2 https://review.openstack.org/237643 | 17:44 |
openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: adds os-win library https://review.openstack.org/212102 | 17:44 |
*** hwoarang has quit IRC | 17:45 | |
*** ssurana has joined #openstack-nova | 17:45 | |
*** claudiub has joined #openstack-nova | 17:45 | |
*** hwoarang has joined #openstack-nova | 17:45 | |
*** hwoarang has joined #openstack-nova | 17:45 | |
*** lucasagomes is now known as lucas-dinner | 17:46 | |
*** e0ne has quit IRC | 17:47 | |
*** heyongli_ has joined #openstack-nova | 17:48 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: adds os-win library https://review.openstack.org/212102 | 17:48 |
PaulMurray | jaypipes, something to do with networking | 17:49 |
PaulMurray | jaypipes, basically the image is not an issue because they are cached on host disk | 17:50 |
PaulMurray | jaypipes, worst case comes for creating a new instance because it may end up where there is no cached image | 17:50 |
*** pratikmallya has joined #openstack-nova | 17:51 | |
PaulMurray | jaypipes, I think ocnfiguring other things is the biggest cost | 17:51 |
claudiub | mriedem: hi. regarding the discussion yesterday, about the possible os_win exceptions leaking outside the HyperVDriver, what do you think of this? https://review.openstack.org/#/c/212102/23/nova/virt/hyperv/driver.py | 17:51 |
*** tjones has joined #openstack-nova | 17:51 | |
*** su_zhang has joined #openstack-nova | 17:53 | |
jaypipes | PaulMurray: ? but a rebuild doesn't ensure that the instance will be rebuilt on a host that contains the cached image either. | 17:54 |
heyongli_ | zzzeek, i check the enginefacade.py in the oslo.db 3.1.0, which global requirements need it >3.0.0, so this is a legal version. what do you mean that not released? | 17:54 |
*** achanda has joined #openstack-nova | 17:54 | |
zzzeek | heyongli_: new code in *nova* that uses that new oslo.db API | 17:55 |
zzzeek | heyongli_: I referenced the blueprint in the exsiting issue you commented on | 17:55 |
*** heyongli_ has quit IRC | 17:55 | |
PaulMurray | jaypipes, I think the image is not the bottleneck - even if it has the same problem cache miss problem (which node-pool doesn't because its images are everywhere) its no worse | 17:56 |
*** heyongli_ has joined #openstack-nova | 17:56 | |
PaulMurray | the image copy generally isn't needed so other things become the bottleneck | 17:56 |
jaypipes | gotcha | 17:57 |
*** lpetrut has joined #openstack-nova | 17:57 | |
PaulMurray | I would have to dig up why they are more costly than expected - its problem to do with churn and freeing resources | 17:57 |
PaulMurray | and almost certainly related to neutron | 17:57 |
PaulMurray | I'll find out and let you know | 17:57 |
*** vladikr has joined #openstack-nova | 17:58 | |
*** achanda has quit IRC | 17:58 | |
*** tonytan4ever has quit IRC | 17:58 | |
mriedem | claudiub: hmm, it's better probably | 18:00 |
*** achanda has joined #openstack-nova | 18:00 | |
*** kmartin has quit IRC | 18:00 | |
mriedem | claudiub: i thought about doing a decorator like that at one point in the neutronv2 api code in nova | 18:00 |
mriedem | to convert NeutronClientExceptions to NovaException | 18:00 |
*** baoli has joined #openstack-nova | 18:01 | |
*** derekh has quit IRC | 18:02 | |
*** ijuwang has quit IRC | 18:03 | |
*** ijuwang has joined #openstack-nova | 18:04 | |
*** ihrachys has quit IRC | 18:05 | |
*** PaulMurray is now known as ptm_away | 18:05 | |
*** harlowja_ has quit IRC | 18:08 | |
*** lpetrut has quit IRC | 18:08 | |
*** tdurakov has quit IRC | 18:11 | |
*** klkumar has quit IRC | 18:11 | |
*** baoli has quit IRC | 18:13 | |
*** sacharya_ has joined #openstack-nova | 18:13 | |
*** baoli has joined #openstack-nova | 18:14 | |
*** sacharya_ has quit IRC | 18:18 | |
*** rk4n has quit IRC | 18:18 | |
*** pratikma_ has joined #openstack-nova | 18:20 | |
*** suro-patz has joined #openstack-nova | 18:21 | |
*** sacharya has joined #openstack-nova | 18:22 | |
*** jaypipes has quit IRC | 18:22 | |
*** e0ne has joined #openstack-nova | 18:22 | |
*** lpetrut has joined #openstack-nova | 18:23 | |
*** pratikmallya has quit IRC | 18:23 | |
*** ccesario has joined #openstack-nova | 18:24 | |
*** baoli has quit IRC | 18:25 | |
openstackgerrit | Andreas Jaeger proposed openstack/nova: Rearranges to create new Compute API Guide https://review.openstack.org/230186 | 18:26 |
*** baoli has joined #openstack-nova | 18:26 | |
*** abitha has joined #openstack-nova | 18:27 | |
*** abitha has quit IRC | 18:27 | |
*** abitha has joined #openstack-nova | 18:28 | |
yonglihe | zzzeek ok let me dig into that to see if。this should be done somehing in CI or leave it as this | 18:28 |
*** boris-42 has quit IRC | 18:28 | |
*** markvoelker has joined #openstack-nova | 18:31 | |
openstackgerrit | Andreas Jaeger proposed openstack/nova: Rearranges to create new Compute API Guide https://review.openstack.org/230186 | 18:32 |
*** rlrossit has quit IRC | 18:32 | |
*** ctrath has quit IRC | 18:32 | |
*** rook has joined #openstack-nova | 18:33 | |
*** dims has joined #openstack-nova | 18:36 | |
*** tdurakov has joined #openstack-nova | 18:36 | |
*** baoli has quit IRC | 18:37 | |
*** baoli has joined #openstack-nova | 18:38 | |
*** eglynn has quit IRC | 18:38 | |
*** liusheng has quit IRC | 18:40 | |
*** liusheng has joined #openstack-nova | 18:40 | |
*** harlowja has joined #openstack-nova | 18:42 | |
*** jaypipes has joined #openstack-nova | 18:42 | |
*** ctrath has joined #openstack-nova | 18:42 | |
*** rlrossit has joined #openstack-nova | 18:43 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/243936 | 18:43 |
*** harlowja_ has joined #openstack-nova | 18:44 | |
*** harlowja has quit IRC | 18:44 | |
*** fawadkhaliq has quit IRC | 18:45 | |
*** meh_di has joined #openstack-nova | 18:47 | |
*** ccarmack has quit IRC | 18:47 | |
meh_di | Hi all dear developer | 18:47 |
*** _yonglihe has joined #openstack-nova | 18:47 | |
meh_di | I have a question about the "forced_host" in nova/compute/api.py | 18:48 |
meh_di | in method "_handle_availability_zone" mention admins should specify hosts via az using az:host:node. | 18:49 |
*** baoli has quit IRC | 18:49 | |
*** baoli has joined #openstack-nova | 18:50 | |
*** ccarmack has joined #openstack-nova | 18:51 | |
meh_di | i have confused weather admin should specifies the host to run the given instance(s) , what is the role of scheduler | 18:52 |
mriedem | sweet https://review.openstack.org/#/c/243663/ finally merged | 18:55 |
*** doug-fish has quit IRC | 18:56 | |
*** doug-fish has joined #openstack-nova | 18:57 | |
*** heyongli_ has quit IRC | 18:57 | |
*** annegentle has quit IRC | 18:58 | |
*** daemontool has joined #openstack-nova | 18:59 | |
krotscheck | Could I get some cores to look at https://review.openstack.org/#/c/236993/ ? It's got tests and everything :) | 19:00 |
*** Piet has quit IRC | 19:01 | |
*** baoli has quit IRC | 19:01 | |
*** baoli has joined #openstack-nova | 19:01 | |
*** doug-fish has quit IRC | 19:02 | |
krotscheck | alaski, dansmith, jaypipes, mriedem, mikal, sdague, melwitt ^^ Pretty please? :) | 19:02 |
*** mriedem has quit IRC | 19:02 | |
dansmith | krotscheck: you pinged every core, so this must be an emergency | 19:03 |
dansmith | let me stop what I'm doing and click on your patch | 19:03 |
dansmith | krotscheck: looks like that needs a major spec, so I -2d per our usual policy | 19:03 |
sdague | dansmith: it's covered by a cross project spec, that's typically sufficient here | 19:05 |
dansmith | sdague: presumably at least a specless bp for tracking | 19:05 |
*** edtubill has quit IRC | 19:06 | |
*** tonytan4ever has joined #openstack-nova | 19:06 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/243936 | 19:07 |
krotscheck | dansmith: Pinging every core == emergency? Thanks for clarifying that, I was just hoping to draw it to the attention of a core other than sdague. | 19:08 |
dansmith | krotscheck: yeah, it's pretty ridiculous to do that | 19:09 |
krotscheck | dansmith: Do you have a suggestion on how in the future I can draw attention to a patch without annoying you? | 19:09 |
dansmith | krotscheck: a spec or blueprint puts it on our radar, otherwise following our procedures of getting it on the tracking etherpad would be good | 19:10 |
dansmith | krotscheck: you know, like under our api subteam heading | 19:10 |
*** mriedem has joined #openstack-nova | 19:10 | |
meh_di | please someone answer my question | 19:11 |
*** markmc has quit IRC | 19:11 | |
krotscheck | dansmith: Gotcha, and thanks for clarifying. Unforutnately each project has its own governance structure and snowflakey goodness, and with 20+ patches of this sort I haven't been able to research how each project wants to be treated. | 19:12 |
*** ihrachys has joined #openstack-nova | 19:12 | |
*** baoli has quit IRC | 19:13 | |
*** baoli has joined #openstack-nova | 19:14 | |
mriedem | cburgess: nic: is this something you guys care about https://review.openstack.org/#/c/239798/? | 19:14 |
mriedem | being such heavy users of ceph | 19:14 |
nic | Hey, I've been watching what I eat... | 19:15 |
*** IanGovett has joined #openstack-nova | 19:16 | |
mriedem | you're note eating that one | 19:16 |
mriedem | *not | 19:16 |
mriedem | i'm trying to gauge how much operator interest there is in ceph-backed volume encryption | 19:16 |
ctrath | mriedem, dansmith: Regarding Alex's comment on https://review.openstack.org/#/c/203751/14/nova/db/sqlalchemy/api.py,cm .. Do you think I should pursue getting related tables via metadata, or should I keep the list as a hardcoded list? | 19:16 |
*** achanda has quit IRC | 19:16 | |
*** doug-fish has joined #openstack-nova | 19:16 | |
mriedem | ctrath: i think metadata is ideal | 19:17 |
nic | It has come up for us, we are interested in it, but more for Cinder volumes than ephemeral storage | 19:17 |
mriedem | there is a db migration that does something like that with meta | 19:17 |
ctrath | ok.. I'll change it and put a patch | 19:17 |
mriedem | ctrath: this https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/migrate_repo/versions/267_instance_uuid_non_nullable.py | 19:17 |
ctrath | mriedem: thanks | 19:18 |
mriedem | that scans for tables with an instance_uuid column | 19:18 |
meh_di | I have a question about the "forced_host" in nova/compute/api.py , in method "_handle_availability_zone" mention admins should specify hosts via az using az:host:node. I have confused weather admin should specifies the host to run the given instance(s) , what is the role of scheduler | 19:18 |
*** whenry_ has quit IRC | 19:19 | |
*** tdurakov has quit IRC | 19:20 | |
*** sacharya has quit IRC | 19:20 | |
mriedem | meh_di: have you checked the code to see where forced_host is used? | 19:20 |
nic | mreidem: and I, for one, am ob-board with the dogpile of folks that want the solution to this to native QEMU | 19:21 |
*** salv-orlando has quit IRC | 19:22 | |
*** kmartin has joined #openstack-nova | 19:23 | |
mriedem | nic: can you comment as such in the spec? | 19:23 |
mriedem | meh_di: looks like forced_hosts is used to filter possible hosts out of the scheduler | 19:24 |
mriedem | so if the az is like az::host1 and you have (host1, host2) to check, you would only allow host1 | 19:24 |
*** salv-orlando has joined #openstack-nova | 19:24 | |
*** baoli has quit IRC | 19:25 | |
meh_di | mriedem: method _create_instance calls the method handle_az = self._handle_availability_zone and in the _handle _availablity_zone used the forced_host, this is my understanding. | 19:25 |
*** baoli has joined #openstack-nova | 19:26 | |
mriedem | the api code puts the forced host/node into the filter properties for the scheduler | 19:26 |
mriedem | yes, and that gets put into the build request that the scheduler processes | 19:26 |
mriedem | https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L466 | 19:26 |
mriedem | this creates the filter properties dict passed to the scheduler https://github.com/openstack/nova/blob/master/nova/compute/api.py#L978 | 19:27 |
*** aysyd has quit IRC | 19:27 | |
*** dustins has quit IRC | 19:29 | |
*** davideagnello has quit IRC | 19:29 | |
*** davideagnello has joined #openstack-nova | 19:29 | |
*** edtubill has joined #openstack-nova | 19:30 | |
*** dustins has joined #openstack-nova | 19:31 | |
*** ociuhandu has quit IRC | 19:32 | |
*** josecastroleon has joined #openstack-nova | 19:32 | |
*** Marga_ has joined #openstack-nova | 19:33 | |
*** abitha has quit IRC | 19:33 | |
*** aysyd has joined #openstack-nova | 19:33 | |
*** Piet has joined #openstack-nova | 19:33 | |
*** aix has quit IRC | 19:33 | |
*** achanda has joined #openstack-nova | 19:34 | |
*** tdurakov has joined #openstack-nova | 19:35 | |
*** otter768 has joined #openstack-nova | 19:36 | |
*** josecastroleon has quit IRC | 19:36 | |
*** davideag_ has joined #openstack-nova | 19:37 | |
*** baoli has quit IRC | 19:38 | |
*** baoli has joined #openstack-nova | 19:38 | |
*** baoli has quit IRC | 19:39 | |
*** dane-fichter has joined #openstack-nova | 19:39 | |
*** rdopiera has quit IRC | 19:40 | |
*** sacharya has joined #openstack-nova | 19:40 | |
*** davideagnello has quit IRC | 19:40 | |
*** otter768 has quit IRC | 19:40 | |
*** baoli has joined #openstack-nova | 19:41 | |
*** sacharya_ has joined #openstack-nova | 19:41 | |
*** achanda has quit IRC | 19:42 | |
*** davideagnello has joined #openstack-nova | 19:42 | |
*** dustins has quit IRC | 19:42 | |
*** tdurakov has quit IRC | 19:42 | |
*** dustins has joined #openstack-nova | 19:42 | |
*** baoli_ has joined #openstack-nova | 19:44 | |
*** sacharya has quit IRC | 19:44 | |
*** davideag_ has quit IRC | 19:45 | |
*** baoli has quit IRC | 19:47 | |
*** aysyd has quit IRC | 19:48 | |
*** angdraug has joined #openstack-nova | 19:49 | |
*** meh_di has left #openstack-nova | 19:51 | |
*** Marga_ has quit IRC | 19:51 | |
*** salv-orlando has quit IRC | 19:52 | |
*** Marga_ has joined #openstack-nova | 19:52 | |
*** aysyd has joined #openstack-nova | 19:52 | |
openstackgerrit | Michael Krotscheck proposed openstack/nova: Added CORS support to Nova https://review.openstack.org/236993 | 19:53 |
*** salv-orlando has joined #openstack-nova | 19:53 | |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs: Add 'auto' case to virt-driver CPU thread pinning https://review.openstack.org/244198 | 19:53 |
*** baoli_ has quit IRC | 19:54 | |
*** baoli has joined #openstack-nova | 19:54 | |
*** lhcheng has joined #openstack-nova | 19:54 | |
*** lhcheng has left #openstack-nova | 19:54 | |
openstackgerrit | Hans Lindgren proposed openstack/nova: Use TimeFixture from oslo_utils to override time in tests https://review.openstack.org/237616 | 19:55 |
*** jichen has joined #openstack-nova | 19:55 | |
*** su_zhang has quit IRC | 19:55 | |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs: Add 'auto' case to virt-driver CPU thread pinning https://review.openstack.org/244198 | 19:56 |
*** su_zhang has joined #openstack-nova | 19:56 | |
*** gszasz has quit IRC | 19:56 | |
*** electrocucaracha has quit IRC | 19:56 | |
krotscheck | dansmith: I've added a blueprint as requested, and linked the spec. Can you please remove the -2? | 19:56 |
dansmith | krotscheck: now add this to the agenda for next week's meeting, and if we can approve it as a specless bp, then I'll remove | 19:57 |
krotscheck | Alright | 19:57 |
krotscheck | dansmith: Link to the agenda? | 19:58 |
mriedem | this weeks meeting | 19:58 |
mriedem | https://www.google.com/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=openstack%20nova%20meeting | 19:58 |
*** salv-orlando has quit IRC | 19:58 | |
dansmith | krotscheck: http://lmgtfy.com/?q=openstack+nova+meeting+agenda | 19:58 |
krotscheck | dansmith: I'm sorry, are you annoyed at me or something? | 19:59 |
dansmith | krotscheck: yep :) | 19:59 |
openstackgerrit | Stephen Finucane proposed openstack/nova: force_config_drive: StrOpt -> BoolOpt https://review.openstack.org/237762 | 19:59 |
*** ociuhandu has joined #openstack-nova | 19:59 | |
_yonglihe | zzzeek, seemDavanums hit same thing as i did. i not sure what exactly trigger this till now. any hint? | 20:00 |
mriedem | sfinucan: i thought we already approved that | 20:00 |
krotscheck | dansmith: So you're intentionally making me jump through hoops because you're annoyed at me? | 20:00 |
mriedem | what happened | 20:00 |
sfinucan | dansmith: mriedem: The darn gate doesn't like me :'( | 20:00 |
mriedem | sfinucan: still, just needed to be rebased or what? | 20:00 |
sfinucan | I've been running recheck for a week - there was a merge conflict | 20:00 |
mriedem | ah | 20:00 |
dansmith | krotscheck: no? | 20:00 |
sfinucan | yeah, just a rebase | 20:00 |
zzzeek | _yonglihe: it has to do with improper usage of the new enginefacade API, e.g. calling upon a decorated function without the enginefacade being correctly configured | 20:01 |
dansmith | krotscheck: I'm helping you learn google because I'm annoyed at you, but this is how we get things on the roadmap | 20:01 |
zzzeek | _yonglihe: otp right now | 20:01 |
*** ihrachys has quit IRC | 20:01 | |
krotscheck | dansmith: In that case, could you please be a little more professional about it? | 20:01 |
mriedem | sfinucan: got it | 20:01 |
sfinucan | thanks mriedem. dansmith: would appreciate a trivial re-approval on same, if you wouldn't mind? https://review.openstack.org/237762 | 20:02 |
mriedem | sfinucan: it's approved | 20:03 |
dansmith | sfinucan: mriedem is too fast :) | 20:03 |
*** electrocucaracha has joined #openstack-nova | 20:03 | |
sfinucan | dansmith: I know. I love it | 20:03 |
*** _yonglihe has quit IRC | 20:04 | |
*** paul-carlton has left #openstack-nova | 20:05 | |
*** e0ne has quit IRC | 20:06 | |
yonglihe | zzzeek not sure if it could be a configration error | 20:06 |
*** su_zhang has quit IRC | 20:08 | |
krotscheck | johnthetubaguy: Hey, in what section in the nova-spc-review-tracking etherpad should I put a new spec that I'd like raised at the meeting? | 20:08 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Make flavor-manage api call destroy using Flavor object https://review.openstack.org/244291 | 20:08 |
krotscheck | I'm not certain if that should go at the top, under not-previously-approved..... | 20:08 |
*** alex_klimov has joined #openstack-nova | 20:09 | |
mriedem | krotscheck: if it doesn't have a spec, there is a sectoin for specless bp's | 20:09 |
krotscheck | mriedem: It's got a x-project spec, but not one in nova-specs. | 20:09 |
mriedem | so openstack-specs? | 20:10 |
mriedem | oslo-specs? | 20:10 |
krotscheck | mriedem: openstack-specs. | 20:10 |
krotscheck | https://blueprints.launchpad.net/nova/+spec/nova-cors | 20:10 |
*** mwagner has quit IRC | 20:11 | |
mriedem | krotscheck: done https://etherpad.openstack.org/p/mitaka-nova-spec-review-tracking | 20:13 |
mriedem | there is a section called "Specless blueprints" | 20:13 |
mriedem | and sub-sections for things that were previously approved or not | 20:13 |
mriedem | this is not previously approved so i listed i there | 20:14 |
mriedem | *it | 20:14 |
krotscheck | mriedem: Thanks. | 20:14 |
krotscheck | I think sdague moved it under API? | 20:14 |
sdague | yeh, I just stuck it under API | 20:14 |
sdague | it's not a perfect fit, but it's kind of close | 20:14 |
krotscheck | Crossed wires. My bad. | 20:14 |
*** _yonglihe has joined #openstack-nova | 20:14 | |
dansmith | sdague: the code belongs there, | 20:14 |
dansmith | the spec under specless blueprints, IMHO | 20:15 |
dansmith | and an item on the agenda so we hit it | 20:15 |
sdague | dansmith: ok, the description on the top is - "These are specs and specless blueprints that need approving for the priority themes." | 20:15 |
mriedem | krotscheck: https://wiki.openstack.org/wiki/Meetings/Nova | 20:15 |
mriedem | "Review of specless blueprints" | 20:15 |
sdague | this is not the priority review etherpad | 20:15 |
mriedem | paste it in there | 20:15 |
sdague | it's the spec review etherpad | 20:16 |
openstackgerrit | Andreas Jaeger proposed openstack/nova: Rearranges to create new Compute API Guide https://review.openstack.org/230186 | 20:16 |
krotscheck | mriedem: Gothca | 20:16 |
krotscheck | Thanks | 20:16 |
dansmith | sdague: ah yep | 20:16 |
sdague | unless I completely don't understand what's supposed to be in this one | 20:16 |
dansmith | sdague: I dont' really know why we have this one this time, TBH | 20:16 |
krotscheck | mriedem: So paste it in there, even though it needs to go into the etherpad as well? | 20:16 |
krotscheck | Or... | 20:16 |
* krotscheck is a bit confused as to what needs to go where. | 20:17 | |
mriedem | sdague: so CORS is a high priority for nova in mitaka since it's v2.1 something? | 20:17 |
sdague | dansmith: oh, the separate etherpad, me either, I was just trying to go with the flow | 20:17 |
dansmith | yeah | 20:17 |
mriedem | gdi | 20:17 |
mriedem | who's on first? | 20:17 |
sdague | mriedem: well it's a cross project push that's API related | 20:17 |
*** jaypipes has quit IRC | 20:17 | |
sdague | mriedem: I'm happy to stick it somewhere else as well | 20:17 |
*** rfolco has joined #openstack-nova | 20:17 | |
dansmith | personally I think it belongs in the specless group | 20:18 |
mriedem | you know, in the time we've spent talking about this we could have just approved the nova bp | 20:18 |
dansmith | because we hit those in the meeting expecting to be done | 20:18 |
krotscheck | Well, I've updated the meeting agenda. | 20:18 |
sdague | mriedem: I agree :) | 20:19 |
sdague | it's really freaking straight forward | 20:19 |
sdague | it was a cross project spec, everyone was good with it | 20:19 |
sdague | it's basically one patch | 20:20 |
krotscheck | As soon as there's some consensus on what else I need to update where I'll be happy to do that. | 20:20 |
mriedem | dansmith: so i'm going to approve the bp | 20:20 |
mriedem | cool? | 20:20 |
sdague | because all the real code is in oslo_middleware | 20:20 |
dansmith | mriedem: yeah | 20:20 |
mriedem | done | 20:21 |
mriedem | https://blueprints.launchpad.net/nova/+spec/nova-cors | 20:21 |
mriedem | let's never talk about this ever again | 20:21 |
krotscheck | mriedem: Thank you. So now I wait for the meeting tomorrow? | 20:23 |
mriedem | nope | 20:23 |
mriedem | go forth and write code | 20:23 |
mriedem | or reply to code review comments, etc | 20:23 |
mriedem | i'll remove from the meeting agenda | 20:23 |
sdague | krotscheck: no, now just update your patch to have bp:nova-cors in the commit message | 20:23 |
sdague | so it will track against that | 20:23 |
mriedem | and dansmith can remove his -2 | 20:24 |
openstackgerrit | Michael Krotscheck proposed openstack/nova: Added CORS support to Nova https://review.openstack.org/236993 | 20:24 |
sdague | oh, it's already done, never mind | 20:24 |
krotscheck | OOps | 20:24 |
*** rook has quit IRC | 20:24 | |
krotscheck | Well, sorry. I thought I needed ot use different commit syntax for bp: | 20:25 |
krotscheck | apparently blueprint also works | 20:25 |
sdague | yeh, it does, I didn't realize that was already in there | 20:25 |
krotscheck | dansmith, mriedem, sdague Thanks for all your help :) | 20:25 |
*** tonytan4ever has quit IRC | 20:26 | |
*** rfolco has quit IRC | 20:28 | |
*** pratikma_ has quit IRC | 20:28 | |
sfinucan | Before I go deleting them all (:)), what are these tests supposed to be doing? https://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_fields.py#L328 | 20:33 |
*** ctrath has quit IRC | 20:33 | |
sfinucan | dansmith: that should probably be directed at you. The tests I linked seem to test the basic functionality of 'Enum' field type, but they don't test this field but instead every single subclass of that | 20:34 |
sfinucan | seems like a waste of time to me, though I'm sure it's not | 20:34 |
dansmith | sfinucan: enum is tested in the library | 20:35 |
*** markmc has joined #openstack-nova | 20:35 | |
dansmith | sfinucan: sfinucan they validate that we don't remove something from those enums, at least | 20:35 |
dansmith | sfinucan: they were from a time when enum was not in the library, so testing the stringification ability is probably not necessary at this point | 20:35 |
sfinucan | dansmith: OK, so mostly legacy reasons? Would it be safe to delete them? | 20:36 |
sfinucan | The best code is no code, or so I've been told :) | 20:36 |
*** ccarmack has quit IRC | 20:36 | |
dansmith | sfinucan: I don't think that you should remove them, no. but you can remove the test_stringify* cases from them | 20:37 |
sfinucan | OK. Should I include them for new Enum-type fields | 20:37 |
dansmith | actually, if you check that the enum *values* are included in the hash check then you can remove them | 20:38 |
sfinucan | like this? https://review.openstack.org/#/c/202647/11 | 20:38 |
*** rushil has quit IRC | 20:38 | |
dansmith | no | 20:38 |
dansmith | just a sec, I'll do it | 20:39 |
*** salv-orlando has joined #openstack-nova | 20:39 | |
dansmith | sfinucan: okay, yeah it covers it now, so I would propose a removal of those and add danpb to it | 20:40 |
dansmith | sfinucan: those are his tests | 20:40 |
*** tjones has quit IRC | 20:40 | |
sfinucan | dansmith: Just to confirm, remove all the tests or just the stringify checks? | 20:41 |
dansmith | the whole test for each of the enum variants | 20:41 |
* dansmith really doesn't like that we subclass those like that | 20:42 | |
dansmith | sfinucan: he's the proponent of doing enums that way, so he may disagree | 20:42 |
*** ccarmack has joined #openstack-nova | 20:43 | |
sfinucan | dansmith: OK, that's fair. I'll open a bug and submit changes. It's not like deleting code is particularly difficult to do | 20:44 |
sfinucan | Maybe I can ransom his enum tests for my approval of the CPU threading spec :evilcackle: | 20:44 |
sfinucan | Thanks, once again. Appreciate the help | 20:45 |
*** ctrath has joined #openstack-nova | 20:45 | |
*** tonytan4ever has joined #openstack-nova | 20:46 | |
*** apoorvad has quit IRC | 20:47 | |
*** pratikmallya has joined #openstack-nova | 20:49 | |
*** pratikmallya has quit IRC | 20:50 | |
*** pratikmallya has joined #openstack-nova | 20:51 | |
*** kmartin has quit IRC | 20:52 | |
*** belmoreira has joined #openstack-nova | 20:53 | |
*** su_zhang has joined #openstack-nova | 20:53 | |
zzzeek | yonglihe / dims : the error is that the configure() method in nova sqlalchemy/api.py has not been called. they are using private member access in get_session() and breaking the API | 20:54 |
*** mwagner has joined #openstack-nova | 20:54 | |
*** penick has joined #openstack-nova | 20:56 | |
*** su_zhang has quit IRC | 20:57 | |
sfinucan | dansmith: Wait a second - do we no longer have to update parents when we change a child object? | 20:58 |
dansmith | sfinucan: that is a correct statement | 20:58 |
sfinucan | dansmith: niiiiiiice :) | 20:58 |
dansmith | sfinucan: you're welcome :) | 20:59 |
*** su_zhang has joined #openstack-nova | 20:59 | |
dims | zzzeek y, added pavel kholkin and sergey nikitin as some of this started from review https://review.openstack.org/#/c/221310/ | 20:59 |
*** lnxnut has joined #openstack-nova | 20:59 | |
*** electrocucaracha has quit IRC | 20:59 | |
zzzeek | dims: yes, its basically related to that. | 20:59 |
dims | zzzeek they have a lot more in the pipe - https://review.openstack.org/#/q/project:openstack/nova+topic:bp/new-oslodb-enginefacade,n,z | 21:00 |
*** rk4n has joined #openstack-nova | 21:00 | |
zzzeek | dims: yes, but this particular patch is where they're trying to keep LegacyEngineFacade in place, but aren't checking that configure() was called. im not sure how its supposed to get called | 21:00 |
zzzeek | dims: but, if it werent called, nova would fail to function at all | 21:01 |
dims | right | 21:01 |
*** gszasz has joined #openstack-nova | 21:01 | |
_yonglihe | zzzeek, nice, dims, seems need more patch to fixed totally. | 21:01 |
*** rk4n has quit IRC | 21:03 | |
*** rk4n has joined #openstack-nova | 21:04 | |
*** annegentle has joined #openstack-nova | 21:06 | |
*** _yonglihe has quit IRC | 21:08 | |
*** aysyd has quit IRC | 21:10 | |
*** tjones has joined #openstack-nova | 21:11 | |
*** daemontool has quit IRC | 21:11 | |
*** tjones has left #openstack-nova | 21:11 | |
*** aysyd has joined #openstack-nova | 21:13 | |
mriedem | dansmith: did you want to update anything here https://review.openstack.org/#/c/242603/ ? i think alaski and i were thinking we'd try setting the bdm.uuid before we call bdm.create (in my change probably) | 21:14 |
mriedem | still rechecking that bdm logging change to get in so not a rush | 21:14 |
dansmith | mriedem: are you thinking that is causing the failure at the top? I hadn't made that connection, so I was just leaving it be | 21:15 |
mriedem | alaski and i talked about at least logging when _from_db_object was creating the uuid for us, since it shouldn't really happen except for older bdm's | 21:15 |
mriedem | that hadn't migrated yet | 21:15 |
mriedem | in the case of create, the db create method should be setting the uuid and then _from_db_object would use that | 21:16 |
mriedem | i think we were more worried about the save() case | 21:16 |
dansmith | yeah, that needs fixing, I just didn't realize you thought it was the cause | 21:16 |
mriedem | well, | 21:16 |
mriedem | when i looked at the logs from the last run, everything looked ok, so the only thing i can think is we're double creating b/c we have 2 bdms with different uuids somehow | 21:17 |
*** apoorvad has joined #openstack-nova | 21:17 | |
mriedem | so at the top when we query the db by uuid, it's not there (even though there is one for that instance, but a different uuid) and we create the 2nd one | 21:17 |
mriedem | but until my logging patch lands and we recreate with a new set of logs, it's hard to know | 21:17 |
*** Marga_ has quit IRC | 21:17 | |
mriedem | so we could wait for that too | 21:18 |
*** pratikma_ has joined #openstack-nova | 21:18 | |
*** sacharya_ has quit IRC | 21:18 | |
*** kmartin has joined #openstack-nova | 21:18 | |
dansmith | well, I should just work on that then I guess | 21:20 |
*** rk4n has quit IRC | 21:21 | |
*** pratikmallya has quit IRC | 21:21 | |
*** electrocucaracha has joined #openstack-nova | 21:22 | |
*** salv-orlando has quit IRC | 21:22 | |
*** pratikma_ has quit IRC | 21:23 | |
*** sacharya has joined #openstack-nova | 21:23 | |
cburgess | mriedem: Reading the spec now and discussing it internally. I'll provide some feedback on it shortly. | 21:23 |
*** nic1 has joined #openstack-nova | 21:23 | |
*** nic has quit IRC | 21:24 | |
*** penick has quit IRC | 21:24 | |
mriedem | cburgess: cool, thanks | 21:25 |
*** salv-orlando has joined #openstack-nova | 21:25 | |
*** mrkz has quit IRC | 21:26 | |
*** rook has joined #openstack-nova | 21:26 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add 'hw_cpu_threads_policy' to ImageMetaProps https://review.openstack.org/202647 | 21:27 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add 'cpu_policy' and 'cpu_threads_policy' fields https://review.openstack.org/202648 | 21:27 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=avoid' filtering https://review.openstack.org/202649 | 21:27 |
openstackgerrit | Stephen Finucane proposed openstack/nova: trivial: Add some logs to 'numa_topology_filter' https://review.openstack.org/202650 | 21:27 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=require' scheduling https://review.openstack.org/202651 | 21:27 |
*** mrkz has joined #openstack-nova | 21:27 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: cells: skip 5 networking scenario tests that use floating IPs https://review.openstack.org/244319 | 21:28 |
*** lnxnut has quit IRC | 21:29 | |
*** electrocucaracha has quit IRC | 21:32 | |
*** mc_nair has quit IRC | 21:32 | |
*** dane-fichter has quit IRC | 21:34 | |
*** otter768 has joined #openstack-nova | 21:37 | |
*** rushil has joined #openstack-nova | 21:40 | |
*** otter768 has quit IRC | 21:42 | |
*** aysyd has quit IRC | 21:42 | |
*** Marga_ has joined #openstack-nova | 21:43 | |
*** rushil has quit IRC | 21:44 | |
*** belmoreira has quit IRC | 21:46 | |
*** pratikmallya has joined #openstack-nova | 21:51 | |
*** electrocucaracha has joined #openstack-nova | 21:51 | |
*** lpetrut has quit IRC | 21:52 | |
*** achanda has joined #openstack-nova | 21:53 | |
cburgess | mriedem: Done, short version, not a fan. | 21:53 |
mriedem | cburgess: great, thanks | 21:54 |
cburgess | Happy to remove my -1 if others disagree with me and want to move forward. | 21:54 |
*** pratikma_ has joined #openstack-nova | 21:54 | |
*** marcusvrn_ has quit IRC | 21:55 | |
*** krtaylor has quit IRC | 21:56 | |
*** pratikmallya has quit IRC | 21:57 | |
*** jichen has quit IRC | 21:57 | |
*** subscope has joined #openstack-nova | 21:57 | |
*** thangp has quit IRC | 21:59 | |
*** smatzek has quit IRC | 22:00 | |
*** thedodd has quit IRC | 22:02 | |
*** thedodd has joined #openstack-nova | 22:02 | |
*** subscope has quit IRC | 22:02 | |
ansiwen | alaski isn't in today, right? | 22:03 |
mriedem | ansiwen: right | 22:04 |
ansiwen | mriedem: you know about tomorrow? | 22:04 |
alaski | I'm around, I've just been in meetings almost literally all afternoon | 22:05 |
*** achanda has quit IRC | 22:05 | |
ansiwen | alaski: oh, I see, hi | 22:05 |
mriedem | alaski: are you officially off paternity leave now? | 22:05 |
alaski | mriedem: yep. | 22:06 |
*** annegentle has quit IRC | 22:06 | |
*** penick has joined #openstack-nova | 22:07 | |
*** alex_klimov has quit IRC | 22:08 | |
alaski | ansiwen: hi | 22:09 |
*** krtaylor has joined #openstack-nova | 22:09 | |
ansiwen | alaski: I'm new with openstack and as first task I fixed a bug you reported. If you have the chance to have a look: https://review.openstack.org/#/c/243616 | 22:09 |
alaski | ansiwen: heh, I just reviewed that | 22:10 |
ansiwen | alaski: oh, cool | 22:10 |
alaski | my only real concern is the test that appears to be named wrong | 22:10 |
ansiwen | alaski: no, it's named correctly, since the fake instace has a image_ref by default... but I was also thinking about explicitly setting it nevertheless, because else exactly this misunderstanding will happen | 22:12 |
*** salv-orlando has quit IRC | 22:13 | |
alaski | ansiwen: yeah, that would be good. I didn't expect that it would be set by default | 22:13 |
ansiwen | me neither, but removing it from the default and fixing all tests that rely on it might be a PITA | 22:14 |
*** stackdump has joined #openstack-nova | 22:14 | |
alaski | very likely | 22:14 |
ansiwen | and sure about the test permutations? I always learned: no redundant tests, keep them othogonal | 22:15 |
ansiwen | I can put all permutations in, but usually it's considered bad practice | 22:15 |
alaski | testing all permutations is useful if someone changes the method later. what are corner cases now may not be then. | 22:16 |
alaski | but you have the two main tests I'm concerned with so I'm not going to -1 for other tests | 22:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova: cells: skip 5 networking scenario tests that use floating IPs https://review.openstack.org/244319 | 22:17 |
*** pratikmallya has joined #openstack-nova | 22:17 | |
ansiwen | alaski: I don't have a strong opinion there and I have to touch it again anyways, so I do as you prefer | 22:18 |
*** rlrossit has left #openstack-nova | 22:19 | |
*** pratikma_ has quit IRC | 22:19 | |
*** pradk has quit IRC | 22:20 | |
openstackgerrit | Vilobh Meshram proposed openstack/nova: Aggregate Extra Specs Filter should return if extra_specs is empty https://review.openstack.org/241016 | 22:20 |
*** edmondsw has quit IRC | 22:23 | |
*** doug-fish has quit IRC | 22:27 | |
*** doug-fish has joined #openstack-nova | 22:28 | |
openstackgerrit | Michael Krotscheck proposed openstack/nova: Added CORS support to Nova https://review.openstack.org/236993 | 22:29 |
*** wverdugo500 has quit IRC | 22:30 | |
*** w_verdugo has quit IRC | 22:30 | |
*** doug-fis_ has joined #openstack-nova | 22:30 | |
*** doug-fish has quit IRC | 22:32 | |
*** achanda has joined #openstack-nova | 22:33 | |
*** doug-fis_ has quit IRC | 22:34 | |
*** sacharya has quit IRC | 22:39 | |
*** sacharya has joined #openstack-nova | 22:40 | |
*** achanda has quit IRC | 22:42 | |
*** doug-fish has joined #openstack-nova | 22:43 | |
dansmith | mriedem: alaski: so for save, I think we should just error if there is no uuid, but not generate there | 22:43 |
dansmith | if we pulled from the DB, we should have one (even if generated). If we don't something is weird | 22:43 |
mriedem | dansmith: the case was a get on a bdm before the db migration to add the uuid | 22:44 |
mriedem | i think | 22:44 |
mriedem | so you added the generator to save() b/c it's non-nullable in the bdm object | 22:45 |
dansmith | mriedem: right, but we generate it in _from_db_obj() | 22:45 |
mriedem | so you want to check and fail in save() itself? | 22:45 |
mriedem | i'm ok with that | 22:45 |
dansmith | yes | 22:45 |
mriedem | i think you're saying what alaski and i are agreeing with | 22:45 |
mriedem | we're all on the same page | 22:45 |
*** thorst has quit IRC | 22:46 | |
*** edtubill has quit IRC | 22:46 | |
dansmith | well, the comments said generate in save and generate in create | 22:46 |
dansmith | that's not what I'm saying | 22:46 |
*** whenry_ has joined #openstack-nova | 22:47 | |
mriedem | i don't want to look it up but what you said above is what i think we want | 22:47 |
*** doug-fish has quit IRC | 22:47 | |
dansmith | yep | 22:47 |
*** penick has quit IRC | 22:47 | |
mriedem | alright, have to head out | 22:48 |
*** dustins has quit IRC | 22:48 | |
*** mriedem has quit IRC | 22:48 | |
*** pratikmallya has quit IRC | 22:49 | |
*** sacharya_ has joined #openstack-nova | 22:50 | |
*** eharney has quit IRC | 22:51 | |
*** burgerk has quit IRC | 22:51 | |
*** sacharya has quit IRC | 22:53 | |
*** tongli has quit IRC | 22:58 | |
*** signed8bit is now known as signed8bit_ZZZzz | 23:01 | |
*** stackdump has quit IRC | 23:02 | |
openstackgerrit | Dan Smith proposed openstack/nova: cells: create block device mappings in API cell https://review.openstack.org/242649 | 23:02 |
openstackgerrit | Dan Smith proposed openstack/nova: Make BlockDeviceMapping object support uuid https://review.openstack.org/242603 | 23:02 |
openstackgerrit | Dan Smith proposed openstack/nova: Add uuid column to BlockDeviceMapping https://review.openstack.org/242602 | 23:02 |
*** mdrabe has quit IRC | 23:02 | |
*** sneti has quit IRC | 23:03 | |
*** annegentle has joined #openstack-nova | 23:04 | |
*** ctrath has quit IRC | 23:04 | |
*** Piet has quit IRC | 23:06 | |
*** baoli has quit IRC | 23:07 | |
*** baoli has joined #openstack-nova | 23:08 | |
*** stackdump has joined #openstack-nova | 23:09 | |
*** sacharya_ has quit IRC | 23:09 | |
*** ctrath has joined #openstack-nova | 23:10 | |
*** amotoki has quit IRC | 23:10 | |
*** signed8bit_ZZZzz is now known as signed8bit | 23:12 | |
*** mc_nair has joined #openstack-nova | 23:12 | |
*** ZZelle has quit IRC | 23:13 | |
*** ZZelle has joined #openstack-nova | 23:17 | |
*** vilobhmm has quit IRC | 23:17 | |
*** vilobhmm has joined #openstack-nova | 23:17 | |
*** gszasz has quit IRC | 23:18 | |
*** ZZelle has quit IRC | 23:21 | |
*** Piet has joined #openstack-nova | 23:25 | |
*** w_verdugo has joined #openstack-nova | 23:26 | |
*** ndipanov has joined #openstack-nova | 23:28 | |
*** ijuwang has quit IRC | 23:31 | |
*** boris-42 has joined #openstack-nova | 23:33 | |
*** emagana has quit IRC | 23:34 | |
*** otter768 has joined #openstack-nova | 23:37 | |
*** ctrath has quit IRC | 23:39 | |
*** su_zhang has quit IRC | 23:41 | |
*** otter768 has quit IRC | 23:42 | |
*** janiceonchn has joined #openstack-nova | 23:42 | |
*** mrkz has quit IRC | 23:42 | |
*** annegentle has quit IRC | 23:43 | |
*** Marga_ has quit IRC | 23:43 | |
*** Marga_ has joined #openstack-nova | 23:43 | |
*** kmartin has quit IRC | 23:46 | |
*** kmartin has joined #openstack-nova | 23:46 | |
*** doug-fish has joined #openstack-nova | 23:47 | |
*** thorst has joined #openstack-nova | 23:49 | |
*** doug-fish has quit IRC | 23:50 | |
*** signed8bit is now known as signed8bit_ZZZzz | 23:53 | |
*** thorst_ has joined #openstack-nova | 23:54 | |
*** thorst_ has quit IRC | 23:55 | |
*** thorst has quit IRC | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!