Wednesday, 2015-11-11

*** jwcroppe has quit IRC00:00
*** Marga_ has quit IRC00:03
*** Marga_ has joined #openstack-nova00:03
*** willsama has quit IRC00:04
*** mriedem has quit IRC00:04
openstackgerritJianghua Wang proposed openstack/nova: xenapi: OVS agent updates the wrong port when using XenServer + Neutron  https://review.openstack.org/24284600:05
openstackgerritJianghua Wang proposed openstack/nova: xenapi: OVS agent updates the wrong port when using XenServer + Neutron  https://review.openstack.org/24284600:07
*** dims has joined #openstack-nova00:08
*** pratikma_ has quit IRC00:12
*** lskyw has joined #openstack-nova00:13
*** dims has quit IRC00:16
*** Marga_ has quit IRC00:17
*** ndipanov has joined #openstack-nova00:19
*** ijuwang has quit IRC00:20
*** Marga_ has joined #openstack-nova00:21
*** hemna is now known as hemnafk00:21
*** rfolco has joined #openstack-nova00:22
*** armax has joined #openstack-nova00:23
*** yamahata has joined #openstack-nova00:23
*** EinstCrazy has quit IRC00:23
*** Marga_ has quit IRC00:25
*** sshen has joined #openstack-nova00:27
*** mc_nair has quit IRC00:27
*** jinxing has joined #openstack-nova00:29
*** jinxing has quit IRC00:30
*** jinxing has joined #openstack-nova00:30
*** jinxing has quit IRC00:32
*** sneti has joined #openstack-nova00:33
*** subscope has quit IRC00:34
*** achanda has joined #openstack-nova00:36
*** sneti has quit IRC00:39
*** mnestratov has quit IRC00:39
*** mriedem has joined #openstack-nova00:42
*** ctrath has quit IRC00:43
*** nic has quit IRC00:44
*** emagana has quit IRC00:49
*** salv-orlando has quit IRC00:49
*** stackdump has quit IRC00:54
*** diogogmt has quit IRC00:54
*** gyee has joined #openstack-nova00:56
*** sfinucan__ has quit IRC00:58
*** zhangjn has joined #openstack-nova01:01
*** sshen_ has joined #openstack-nova01:06
*** sshen has quit IRC01:06
*** spandhe has quit IRC01:06
*** spandhe has joined #openstack-nova01:07
*** edtubill has joined #openstack-nova01:11
*** EinstCrazy has joined #openstack-nova01:12
*** thorst has joined #openstack-nova01:17
*** lskyw has quit IRC01:18
*** jyuso1 has joined #openstack-nova01:19
*** obondarev has quit IRC01:20
*** thorst has quit IRC01:20
*** Marga_ has joined #openstack-nova01:21
*** ssurana has quit IRC01:23
*** zhenguo has joined #openstack-nova01:23
*** edtubill has quit IRC01:24
*** abitha has quit IRC01:25
*** edtubill has joined #openstack-nova01:26
*** Marga_ has quit IRC01:26
*** dims has joined #openstack-nova01:27
*** otter768 has joined #openstack-nova01:28
*** electrocucaracha has quit IRC01:28
*** obondarev has joined #openstack-nova01:29
*** mtanino has quit IRC01:30
*** suro-patz has quit IRC01:31
*** terryyao has joined #openstack-nova01:33
*** otter768 has quit IRC01:33
*** pixelbeat has quit IRC01:34
*** harlowja has quit IRC01:38
*** harlowja_ has joined #openstack-nova01:38
*** Yanyanhu has joined #openstack-nova01:38
*** EinstCra_ has joined #openstack-nova01:40
*** angdraug has quit IRC01:40
*** edtubill has quit IRC01:42
*** changbl has joined #openstack-nova01:43
*** EinstCrazy has quit IRC01:43
*** pratikmallya has joined #openstack-nova01:47
*** breitz has quit IRC01:49
*** terryyao_ has joined #openstack-nova01:51
openstackgerritJianghua Wang proposed openstack/nova: xenapi: OVS agent updates the wrong port when using XenServer + Neutron  https://review.openstack.org/24284601:52
*** browne has quit IRC01:56
*** salv-orlando has joined #openstack-nova01:57
*** gcb has joined #openstack-nova01:58
*** salv-orlando has quit IRC01:59
*** salv-orlando has joined #openstack-nova01:59
*** stackdump has joined #openstack-nova02:01
*** edmondsw has quit IRC02:04
*** pratikmallya has quit IRC02:11
*** rfolco has quit IRC02:12
*** spandhe has quit IRC02:12
*** angdraug has joined #openstack-nova02:19
*** seanw1 has quit IRC02:19
*** seanw1 has joined #openstack-nova02:20
*** diogogmt has joined #openstack-nova02:20
*** haomaiwang has joined #openstack-nova02:21
*** Marga_ has joined #openstack-nova02:22
*** suro-patz has joined #openstack-nova02:23
*** suro-patz has quit IRC02:24
*** Marga_ has quit IRC02:26
*** pratikmallya has joined #openstack-nova02:30
*** Marga_ has joined #openstack-nova02:32
*** emagana has joined #openstack-nova02:35
*** emagana has quit IRC02:40
*** su_zhang has joined #openstack-nova02:42
*** bharath has joined #openstack-nova02:43
*** emagana has joined #openstack-nova02:46
*** salv-orlando has quit IRC02:46
*** isq has quit IRC02:52
*** isq has joined #openstack-nova02:52
*** isq has quit IRC02:53
*** isq has joined #openstack-nova02:53
openstackgerritWen Zhi Yu proposed openstack/nova: Clean up network resources when reschedule fails  https://review.openstack.org/24347702:54
*** yamahata has quit IRC02:54
*** edtubill has joined #openstack-nova02:54
*** arunkant has joined #openstack-nova02:55
*** unicell has quit IRC02:56
*** jamielennox is now known as jamielennox|away03:00
*** haomaiwang has quit IRC03:01
*** haomaiwang has joined #openstack-nova03:01
*** gcb has quit IRC03:08
*** jamielennox|away is now known as jamielennox03:10
*** zhangjn has quit IRC03:11
*** zhangjn has joined #openstack-nova03:11
*** sshen_ is now known as sshen03:12
*** venkat_p has joined #openstack-nova03:13
*** stackdump has quit IRC03:14
*** venkat_p has left #openstack-nova03:14
*** su_zhang has quit IRC03:15
*** vilobhmm has quit IRC03:18
*** angdraug has quit IRC03:22
*** sshen has quit IRC03:22
*** hightall has joined #openstack-nova03:22
*** sshen has joined #openstack-nova03:23
*** gyee has quit IRC03:23
*** gcb has joined #openstack-nova03:25
*** emagana has quit IRC03:27
*** otter768 has joined #openstack-nova03:29
*** pumaranikar has joined #openstack-nova03:29
*** otter768 has quit IRC03:33
*** jerrygb has quit IRC03:33
*** jerrygb has joined #openstack-nova03:34
*** agireud has joined #openstack-nova03:34
openstackgerritwuhao proposed openstack/nova: Fix a spelling mistake in the log  https://review.openstack.org/24390703:37
*** fawadkhaliq has joined #openstack-nova03:39
*** agireud has quit IRC03:39
*** pratikmallya has quit IRC03:40
*** agireud has joined #openstack-nova03:41
*** dave-mcc_ has quit IRC03:45
*** dims has quit IRC03:46
*** r-daneel has quit IRC03:47
*** salv-orlando has joined #openstack-nova03:47
*** pumaranikar has quit IRC03:49
*** hightall has quit IRC03:50
*** kylek3h has quit IRC03:50
*** apoorvad has quit IRC03:50
*** kylek3h has joined #openstack-nova03:50
*** salv-orlando has quit IRC03:52
*** kylek3h has quit IRC03:55
*** emagana has joined #openstack-nova03:56
*** Marga__ has joined #openstack-nova03:59
*** haomaiwang has quit IRC04:01
*** haomaiwang has joined #openstack-nova04:01
*** Marga_ has quit IRC04:02
*** wanghao has joined #openstack-nova04:05
openstackgerritwanghao proposed openstack/nova: Fix invalid Image&block device mapping combination  https://review.openstack.org/17198404:05
*** flyingtt has quit IRC04:06
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/24393604:06
*** mriedem has quit IRC04:08
openstackgerritJianghua Wang proposed openstack/nova: xenapi: OVS agent updates the wrong port when using XenServer + Neutron  https://review.openstack.org/24284604:10
*** jinxing has joined #openstack-nova04:12
*** stevemar_ has joined #openstack-nova04:13
*** Marga__ has quit IRC04:14
*** diogogmt has quit IRC04:16
*** stevemar_ has quit IRC04:16
*** fawadkhaliq has quit IRC04:17
*** emagana has quit IRC04:18
*** Sree has joined #openstack-nova04:22
*** bharath has quit IRC04:27
*** links has joined #openstack-nova04:28
*** bharath has joined #openstack-nova04:28
*** gongysh_ has joined #openstack-nova04:31
*** hogepodge has quit IRC04:35
*** hightall has joined #openstack-nova04:39
*** jwcroppe has joined #openstack-nova04:41
*** salv-orlando has joined #openstack-nova04:48
*** pratikmallya has joined #openstack-nova04:49
*** kylek3h has joined #openstack-nova04:51
*** Sree has quit IRC04:52
*** Sree has joined #openstack-nova04:52
*** Marga_ has joined #openstack-nova04:52
*** salv-orlando has quit IRC04:52
*** Marga_ has quit IRC04:53
*** Marga_ has joined #openstack-nova04:54
*** pratikmallya has quit IRC04:55
*** kylek3h has quit IRC04:55
*** vishwanathj has quit IRC04:57
*** baoli has quit IRC04:57
*** baoli has joined #openstack-nova04:58
*** mdrabe has joined #openstack-nova04:58
*** haomaiwang has quit IRC05:01
*** stackdump has joined #openstack-nova05:01
*** haomaiwa_ has joined #openstack-nova05:01
*** fawadkhaliq has joined #openstack-nova05:02
*** edtubill has quit IRC05:03
*** mdrabe has quit IRC05:04
*** stackdump has quit IRC05:05
*** Sree has quit IRC05:06
*** Sree has joined #openstack-nova05:11
*** rha has quit IRC05:12
*** baoli has quit IRC05:20
*** baoli has joined #openstack-nova05:20
*** suro-patz has joined #openstack-nova05:21
*** baoli has quit IRC05:25
*** links has quit IRC05:26
*** baoli has joined #openstack-nova05:27
*** jerrygb has quit IRC05:28
*** jinxing has quit IRC05:28
*** Sree_ has joined #openstack-nova05:29
*** stevemar_ has joined #openstack-nova05:29
*** jerrygb has joined #openstack-nova05:29
*** suro-patz has quit IRC05:29
*** Sree_ is now known as Guest9052305:29
*** otter768 has joined #openstack-nova05:29
*** jinxing has joined #openstack-nova05:30
*** su_zhang has joined #openstack-nova05:30
*** frickler has quit IRC05:31
*** stevemar_ has quit IRC05:31
*** Sree has quit IRC05:32
*** jerrygb has quit IRC05:33
*** otter768 has quit IRC05:34
*** subscope has joined #openstack-nova05:45
*** su_zhang has quit IRC05:47
*** Marga_ has quit IRC05:48
*** achanda has quit IRC05:54
*** eliqiao has quit IRC05:55
*** lpetrut has joined #openstack-nova05:58
*** links has joined #openstack-nova05:58
*** eliqiao has joined #openstack-nova05:59
*** haomaiwa_ has quit IRC06:01
*** haomaiwang has joined #openstack-nova06:01
*** fawadkhaliq has quit IRC06:01
*** fawadkhaliq has joined #openstack-nova06:02
*** nikhil has quit IRC06:02
*** nikhil has joined #openstack-nova06:02
*** fawadk has joined #openstack-nova06:03
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata  https://review.openstack.org/24272706:03
*** fawadkhaliq has quit IRC06:04
*** artom_ has joined #openstack-nova06:05
*** bharath has quit IRC06:06
*** marzif_ has joined #openstack-nova06:06
*** artom has quit IRC06:07
*** q3k has quit IRC06:08
*** daemontool has quit IRC06:08
*** q3k has joined #openstack-nova06:09
*** bharath has joined #openstack-nova06:17
openstackgerritSudipta Biswas proposed openstack/nova: Introduce utility module for pcp  https://review.openstack.org/20316306:17
*** vilobhmm has joined #openstack-nova06:24
*** bharath has quit IRC06:24
*** jamielennox is now known as jamielennox|away06:29
*** subscope has quit IRC06:32
*** lpetrut has quit IRC06:33
*** achanda has joined #openstack-nova06:34
*** spandhe has joined #openstack-nova06:36
*** bharath has joined #openstack-nova06:37
*** pratikmallya has joined #openstack-nova06:39
*** moshele has joined #openstack-nova06:46
*** frickler has joined #openstack-nova06:49
*** jfding has quit IRC06:52
*** jinxing_ has joined #openstack-nova06:53
*** vilobhmm has quit IRC06:54
*** mjura has joined #openstack-nova06:54
*** lpetrut has joined #openstack-nova06:54
*** ihrachys has joined #openstack-nova06:54
openstackgerritvenkatesh proposed openstack/nova: make the driver.Scheduler as abstract class  https://review.openstack.org/21201606:54
*** jinxing has quit IRC06:56
*** browne has joined #openstack-nova06:57
openstackgerritTakashi NATSUME proposed openstack/nova-specs: Add new filter 'ShelveAggregateAffinityFilter'  https://review.openstack.org/23401306:57
*** jinxing_ has quit IRC07:00
*** garyk1 has joined #openstack-nova07:00
*** haomaiwang has quit IRC07:01
*** 16WAAQM31 has joined #openstack-nova07:01
*** garyk1 has quit IRC07:01
*** garyk2 has joined #openstack-nova07:01
*** garyk1 has joined #openstack-nova07:02
*** garyk2 has quit IRC07:02
*** bharath has quit IRC07:05
*** spandhe has quit IRC07:07
*** jinxing has joined #openstack-nova07:08
*** lsmola has joined #openstack-nova07:16
*** jwcroppe has quit IRC07:17
*** jwcroppe has joined #openstack-nova07:17
*** ihrachys has quit IRC07:18
*** Guest90523 has quit IRC07:19
*** Sree has joined #openstack-nova07:20
*** scheuran has joined #openstack-nova07:20
*** baoli has quit IRC07:20
*** baoli has joined #openstack-nova07:21
*** kylek3h has joined #openstack-nova07:22
*** jwcroppe has quit IRC07:22
*** bharath has joined #openstack-nova07:22
*** cfriesen__ has quit IRC07:23
*** rdopiera has joined #openstack-nova07:24
*** Sree has quit IRC07:25
*** baoli has quit IRC07:25
*** nkrinner has joined #openstack-nova07:26
*** kylek3h has quit IRC07:26
*** Marga_ has joined #openstack-nova07:28
*** bharath has quit IRC07:28
*** armax has quit IRC07:29
*** stevemar_ has joined #openstack-nova07:29
*** jerrygb has joined #openstack-nova07:30
*** otter768 has joined #openstack-nova07:30
*** jhesketh has quit IRC07:31
*** jhesketh has joined #openstack-nova07:31
*** pratikmallya has quit IRC07:32
*** stevemar_ has quit IRC07:32
*** otter768 has quit IRC07:35
*** jerrygb has quit IRC07:36
openstackgerritgaryk proposed openstack/nova: VMware: expand support for Opaque networks  https://review.openstack.org/16575007:36
*** logan2 has quit IRC07:40
*** logan2 has joined #openstack-nova07:40
*** nelsnels_ has joined #openstack-nova07:41
*** bharath has joined #openstack-nova07:41
*** jamielennox|away has quit IRC07:41
*** dansmith has quit IRC07:42
*** whydidyoustealmy has joined #openstack-nova07:42
*** Marga__ has joined #openstack-nova07:43
*** Marga_ has quit IRC07:43
*** jyuso1 has quit IRC07:43
*** barra204 has quit IRC07:43
*** liusheng has quit IRC07:43
*** nelsnelson has quit IRC07:44
*** jyuso1 has joined #openstack-nova07:44
*** afazekas|sick has quit IRC07:44
*** liusheng has joined #openstack-nova07:44
*** dansmith has joined #openstack-nova07:44
*** dansmith is now known as Guest4045807:44
*** mordred has quit IRC07:44
*** liverpooler has joined #openstack-nova07:45
*** lpetrut has quit IRC07:48
*** rha has joined #openstack-nova07:48
*** rha has quit IRC07:49
*** eglynn has joined #openstack-nova07:49
*** afazekas has joined #openstack-nova07:50
*** rha has joined #openstack-nova07:50
*** bharath has quit IRC07:50
*** achanda has quit IRC07:51
*** paul-carlton has joined #openstack-nova07:53
*** eliqiao has quit IRC07:55
*** eliqiao has joined #openstack-nova07:56
*** fawadk has quit IRC07:57
*** achanda has joined #openstack-nova07:57
*** fawadkhaliq has joined #openstack-nova07:58
*** paul-carlton has quit IRC08:00
*** kylek3h has joined #openstack-nova08:00
*** 16WAAQM31 has quit IRC08:01
*** haomaiwang has joined #openstack-nova08:01
*** terryyao_ has quit IRC08:01
*** danpb has joined #openstack-nova08:04
*** kylek3h has quit IRC08:04
*** bharath has joined #openstack-nova08:06
*** Sree has joined #openstack-nova08:07
*** subscope has joined #openstack-nova08:07
ndipanovjohnthetubaguy, if you have some time this week https://review.openstack.org/#/c/212472/08:13
ndipanovI feel it has had a good amount of discussion08:13
*** fawadkhaliq has quit IRC08:13
*** jichen has joined #openstack-nova08:14
*** mpavone has joined #openstack-nova08:14
*** paul-carlton has joined #openstack-nova08:15
*** mpavone has quit IRC08:15
*** eglynn has quit IRC08:18
*** markmc has quit IRC08:18
*** Sree has quit IRC08:18
*** Sree has joined #openstack-nova08:19
*** paul-carlton has quit IRC08:19
*** spandhe has joined #openstack-nova08:19
*** spandhe_ has joined #openstack-nova08:20
*** alex_klimov has joined #openstack-nova08:21
*** lucas-afk is now known as lucasagomes08:23
*** Sree has quit IRC08:23
*** spandhe has quit IRC08:24
*** spandhe_ is now known as spandhe08:24
*** jamielennox|away has joined #openstack-nova08:31
*** jamielennox|away is now known as jamielennox08:31
*** Guest13749 is now known as tdurakov08:33
*** paul-carlton has joined #openstack-nova08:35
*** stevemar_ has joined #openstack-nova08:35
*** gszasz has joined #openstack-nova08:36
*** achanda has quit IRC08:36
openstackgerritoctopuszhang proposed openstack/nova: remove wrong comments  https://review.openstack.org/24400208:38
*** stevemar_ has quit IRC08:38
*** pratikmallya has joined #openstack-nova08:38
*** achanda has joined #openstack-nova08:39
*** Marga__ has quit IRC08:42
*** Marga_ has joined #openstack-nova08:43
*** ihrachys has joined #openstack-nova08:45
*** rk4n has joined #openstack-nova08:46
*** jlanoux has joined #openstack-nova08:47
*** rk4n has quit IRC08:50
*** subscope has quit IRC08:52
alex_xundipanov: re: https://review.openstack.org/#/c/231887, I agree the db layer shouldn't include application logic. or does make sense we do that in the instance object? there are multiple instance.destory() in the code we need check them one by one, that is a little pain deal with each one.08:54
alex_xufor example https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L88408:54
*** achanda has quit IRC08:57
*** zhangtao has quit IRC08:57
*** derekh has joined #openstack-nova08:57
*** pratikmallya has quit IRC08:58
*** spandhe has quit IRC08:59
*** pratikmallya has joined #openstack-nova08:59
*** e0ne has joined #openstack-nova09:00
*** pratikmallya has quit IRC09:00
*** haomaiwang has quit IRC09:01
*** haomaiwang has joined #openstack-nova09:01
*** jinxing has quit IRC09:01
*** ociuhandu has quit IRC09:03
*** moshele has quit IRC09:03
*** spandhe has joined #openstack-nova09:03
*** rotbeard has joined #openstack-nova09:04
*** subscope has joined #openstack-nova09:08
*** jinxing has joined #openstack-nova09:08
*** moshele has joined #openstack-nova09:09
*** browne has quit IRC09:09
tangchen_alex_xu: Just FYI, I'm ready for the API doc work. You can contact me in IRC, and email (tangchen@cn.fujitsu.com).09:09
openstackgerrithuan proposed openstack/nova: XenAPI:Resolve Nova/Neutron race condition  https://review.openstack.org/24112709:09
tangchen_alex_xu: I'm in Chinese Beijing time zone.09:10
*** yangyapeng has joined #openstack-nova09:11
ndipanovalex_xu, hmmm09:12
*** eglynn has joined #openstack-nova09:12
*** fawadkhaliq has joined #openstack-nova09:12
*** liusheng has quit IRC09:14
ndipanovso the problem there is that because we use the decorator for those in compute manager - we rely on them existing after the object .destroy() call09:14
ndipanovwhich ever way you look at it - the problem is that events are not fully implemented in Nova, they are added to ad-hoc places09:15
ndipanovalex_xu, ^09:15
*** liusheng has joined #openstack-nova09:16
ndipanovit would maybe make sense to do it in destroy and provide a flag to defer it in case we are inside a context that know how to handle it09:17
ndipanovno idea09:17
johnthetubaguyndipanov: I suspect thats ready too, given the summit discussion, will get to that one today, just about to review all the specs with +2s already09:18
openstackgerritBalazs Gibizer proposed openstack/nova-specs: Add notification for service status change  https://review.openstack.org/18235009:23
johnthetubaguyndipanov: agreed, with the events thing, totally need to find an approach we are happy with, and start applying it consistently, its kinda crazy right now09:23
*** fawadkhaliq has quit IRC09:23
ndipanovjohnthetubaguy, it's about this https://review.openstack.org/#/c/231887/9/nova/compute/utils.py,cm09:24
johnthetubaguyndipanov: yeah, just taking a peak, certainly hints at the bigger issue we have around this stuff09:25
*** spandhe has quit IRC09:25
gibialaski, bauzas: I updated  Add notification for service09:26
gibistatus change  https://review.openstack.org/18235009:26
*** markmc has joined #openstack-nova09:26
gibibased on the discussison yesterday09:26
*** huanxie has joined #openstack-nova09:26
*** BobBall_AWOL is now known as BobBall09:27
johnthetubaguyndipanov: alex_xu: I wonder if the zero-th cell stuff could help us here, a dead host instance is move to the zero-th cell, then deleted in there, or some such... maybe that makes it worse09:27
*** liusheng has quit IRC09:27
*** liusheng has joined #openstack-nova09:27
johnthetubaguygibi: we need to get that blueprint approved, is it on a list somewhere already?09:27
johnthetubaguygibi: actually, don't you have a spec up for that somewhere?09:28
* johnthetubaguy face palm09:28
johnthetubaguythats the spec, yes. hmm09:28
*** ociuhandu has joined #openstack-nova09:28
gibijohnthetubaguy: I think it is ready for approval, alaski had some comment yesterday but the last change is quite small09:29
*** huanxie has quit IRC09:29
*** hightall has quit IRC09:30
gibijohnthetubaguy: I'm hasitating to do the same update on the versioned notification change spec as it is mostly consmetical there and related mostly to the implementation itself09:30
johnthetubaguygibi: yeah, I think that makes sense09:30
johnthetubaguygibi: i see the bigger spec mostly as directional09:31
gibijohnthetubaguy: I have your +2 on the versioned notification spec already I will ping dansmith or some other core to get a second one today09:31
*** otter768 has joined #openstack-nova09:31
bauzasgibi: ack, today is a national holiday in France so I'll review it by tomorrow09:32
gibijohnthetubaguy: yesterday we hade the first subteam meating but we have low attendance, hoping for a better one next week09:32
BobBalljohnthetubaguy: #openstack-meeting :)09:32
gibibauzas: happy holiday, thanks for the effort :)09:32
johnthetubaguybauzas: go forth and enjoy the holiday09:33
johnthetubaguyBobBall: that would be the meeting reminder that I pressed dissmiss on too early09:33
johnthetubaguygibi: takes time to build momentum, good to get it rolling!09:34
gibijohnthetubaguy: OK. I will push it forward :)09:35
BobBall:D09:35
* johnthetubaguy metaphorically applies grease under versioned notifications09:35
*** otter768 has quit IRC09:36
garyk1ndipanov: a real no brainer if possible - https://review.openstack.org/21864409:37
ndipanovgaryk1, even that is a stretch for me today :)09:37
garyk1:)09:37
ndipanovgaryk1, is this one of those us vs uk spelling things09:37
garyk1ndipanov: a moscow mule can solve all problems09:37
ndipanovI am not going anywhere near that stuff09:37
*** lpetrut has joined #openstack-nova09:38
*** ociuhandu_ has joined #openstack-nova09:39
*** ociuhandu has quit IRC09:40
*** ociuhandu_ is now known as ociuhandu09:40
*** belmoreira has joined #openstack-nova09:41
*** paul-carlton has quit IRC09:43
*** gongysh_ has quit IRC09:44
*** fawadkhaliq has joined #openstack-nova09:44
*** mordred has joined #openstack-nova09:45
*** terryyao has quit IRC09:45
*** jistr has joined #openstack-nova09:45
*** subscope has quit IRC09:46
*** janiceonchn has joined #openstack-nova09:46
*** sudipto has joined #openstack-nova09:46
*** baoli has joined #openstack-nova09:48
openstackgerritMatthew Booth proposed openstack/nova: Remove duplicate server.kill on test shutdown  https://review.openstack.org/24402709:51
*** gcb has quit IRC09:52
*** baoli has quit IRC09:53
*** alex_klimov has quit IRC09:56
*** zhenguo has quit IRC09:56
*** janiceonchn has quit IRC09:57
*** subscope has joined #openstack-nova09:58
openstackgerritPavel Kholkin proposed openstack/nova: enginefacade: 'flavor'  https://review.openstack.org/24402909:58
*** Yanyanhu has quit IRC09:59
*** ZZelle has joined #openstack-nova10:00
*** haomaiwang has quit IRC10:01
*** haomaiwa_ has joined #openstack-nova10:01
*** rk4n has joined #openstack-nova10:02
alex_xundipanov: sorry, just get home10:03
ndipanovalex_xu, no worries10:03
alex_xundipanov: emm...a little hard to chocie, got it the events isn't good for now. how about we just ensure all the events was deleted for now? or you still perfer fix it in the compute-node side first10:04
ndipanovalex_xu, well - I'd say I could live with a object fix with a flag to not do it10:06
alex_xundipanov: ok, thanks :)10:06
*** aix has joined #openstack-nova10:08
openstackgerritSudipta Biswas proposed openstack/nova: Introduce utility module for pcp  https://review.openstack.org/20316310:09
andrearosagibi: I missed the meeting last night I am catching up right now, unfortunately that time doesn't work for me very well10:10
*** ihrachys has quit IRC10:16
*** ihrachys has joined #openstack-nova10:17
gibiandrearosa: no problem. This time is hard for me too, but it seems we have interested parties from Australia as well, so we have to compromise10:19
*** ptm_away is now known as PaulMurray10:19
gibiandrearosa: if you have any question regarding the yesterday's meeting just ping me10:19
PaulMurrayjohnthetubaguy, I gave a spec a -1 for having the priorities section in it on the grounds that it will be public documentation so it should be in right format.10:20
PaulMurrayjohnthetubaguy, do you think that is over the top?10:20
danpbPaulMurray: if that's the only problem with the spec, then its probably something can could be patched as a trivial followup patch10:20
danpbif there's other issues then it should be fixed at the same time10:21
andrearosagibi: yes I understand that. Thanks for the offer, I agree with the mission statement and please add me as reviewer when you put the patch for the service status notification change, even if it is just a WIP10:21
alex_xutangchen_: cool, thanks! you can free to take tasks from https://etherpad.openstack.org/p/nova-v2.1-api-doc , free to reach me for any question10:21
*** pixelbeat has joined #openstack-nova10:22
PaulMurraydanpb, johnthetubaguy  ok - I'll change it to a nit and leave that guidance then, thanks10:22
gibiandrearosa: great, I will add you to the reviews :)10:22
*** janiceonchn has joined #openstack-nova10:24
*** janiceonchn has quit IRC10:24
*** janiceonchn has joined #openstack-nova10:25
*** janiceonchn has quit IRC10:25
johnthetubaguyPaulMurray: yeah, +1 to danpb's comment, I am worried more about the content right now, feel free to add a follow on patch to fix that10:25
danpbPaulMurray: you could in fact alternatively just submit a dependant patch yourself to delete the section10:25
*** janiceonchn has joined #openstack-nova10:26
PaulMurraydanpb, ok, thanks10:27
*** jinxing has quit IRC10:28
PaulMurrayjohnthetubaguy, danpb BTW - its this one - I think its ready to go: https://review.openstack.org/#/c/194990/10:28
PaulMurraysplit network plane for live migration10:28
johnthetubaguyPaulMurray: cool, I do see the nice list of specs in the etherpad, I should go through those10:31
gibijohnthetubaguy: You reviewed previously the https://review.openstack.org/#/c/240858/ Deprecate nova-manage service subcommand patche. I fixed your comments and I think this patch shall land early as it deprecate things. Could you please check it?10:32
kashyapjohnthetubaguy: Not sure if you've noticed already, your update on Nova talk is covered by LWN - https://lwn.net/Articles/662943/10:33
*** alex_klimov has joined #openstack-nova10:34
johnthetubaguykashyap: I have not10:34
johnthetubaguykashyap: thanks for the heads up :)10:34
kashyapNice to see folks at LWN cover OpenStack.10:35
*** paul-carlton has joined #openstack-nova10:35
*** stevemar_ has joined #openstack-nova10:36
*** nikhil has quit IRC10:36
*** nikhil has joined #openstack-nova10:36
*** markvoelker has quit IRC10:37
openstackgerritPaul Murray proposed openstack/nova-specs: Trivial format fix for split network plane spec  https://review.openstack.org/24404110:37
*** stevemar_ has quit IRC10:38
openstackgerritBalazs Gibizer proposed openstack/nova: Remove onSharedStorage from evacuate API  https://review.openstack.org/24356210:40
*** cdent has joined #openstack-nova10:45
PaulMurrayjohnthetubaguy, ndipanov do you have a moment, its about volume operations and task states10:45
ndipanovPaulMurray, you got anything easier maybe? P vs NP? the middle east?10:49
ndipanov:)10:49
PaulMurrayndipanov, hmmm, let me think... no10:50
ndipanovPaulMurray, jk - what about volumes?10:50
PaulMurrayndipanov, talking to dansmith and PhilDay I realised there is a synchronization problem with volume ops because they don't set task states10:50
ndipanovhmm10:50
PaulMurraythere has been this bug for a while: https://bugs.launchpad.net/nova/+bug/127514410:50
openstackLaunchpad bug 1275144 in OpenStack Compute (nova) "Volume operations should set task state" [Low,Confirmed] - Assigned to Paul Murray (pmurray)10:51
PaulMurraybasically volume operations and rebuild/migrate/shelve etc are not mutually exclusive10:51
ndipanovPaulMurray, seems like a legit issue10:51
PaulMurrayso we're proposing fixing that10:51
ndipanovwe could still have races with task state though10:52
ndipanovbut it would be an improvement10:52
PaulMurrayanything in particular?10:52
*** subscope has quit IRC10:53
ndipanovwell check instance state checks it but does not set it in an atomic way10:53
ndipanovI think10:53
*** omasz has joined #openstack-nova10:53
*** subscope has joined #openstack-nova10:53
PaulMurraymakes sense - I haven't dug into that - I expected it but kept my head in the sand10:53
*** claudiub has joined #openstack-nova10:53
ndipanovPaulMurray, emperor is naked10:54
ndipanov:)10:54
*** omasz has left #openstack-nova10:54
PaulMurrayI was about to sort it under the bug but then found this spec doing the same thing: https://review.openstack.org/#/c/243096/10:54
ndipanovso from my pov - this seems lika a legit issue - we are blocking some operations with a instance-wide semaphore on the compute hosts I think10:54
PaulMurrayoops, wrong spec10:54
ndipanovthat might be another approach10:55
ndipanovs/blocking/serializing/10:55
PaulMurrayIt would have some interesting benefits10:55
PaulMurrayat the moment there is a call to reserve a name that is done as an rpc to the compute manager10:55
PaulMurraythat could be done locally if using task state to serialize10:56
PaulMurrayThis is the spec I meant: https://review.openstack.org/#/c/216578/10:56
ndipanovPaulMurray, what if we had some kind of a... distributed lock manager...10:58
PaulMurrayndipanov, don't even go there :)10:58
jaypipesdanpb: mornin. so, I'm cool with many of the changes in your pull request -- though the inheritance as you've designed with the o.vo objects won't work as designed, AFAICT). however, would it be OK with you if I go and create a vif-plug-ovs repository and pull the ovs and ovs hybrid plug code into there, so we have an actual plug driver to test with?10:58
johnthetubaguyPaulMurray: yeah, been looking at the spec a bit10:59
johnthetubaguyPaulMurray: the main issue I had is it broke the API semantics10:59
danpbjaypipes: the inheritance should work - i used the same approach for my oslo-devsupport package and it worked there10:59
jaypipesdanpb: also, thanks very much for doing all the administrative legwork on gerrit and lp!10:59
jaypipesdanpb: ok.11:00
*** aysyd has joined #openstack-nova11:00
danpbunles there's been a regression in ovo since then of course...11:00
ndipanovPaulMurray, I will read the spec and try to think about how we could leverage the locking that already exists11:00
jaypipesdanpb: on the vif-plug-ovs repo, you OK if I create that before merging your PR?11:00
danpbi guess i should add some unit tests though to validate that it does indeed work :-)11:00
jaypipesdanpb: heh, yeah, we do need that of course, but hey, we've got some time to get that in order.11:00
ndipanovimho task states are broken for that sort of thing11:00
*** haomaiwa_ has quit IRC11:01
danpbjaypipes: so you want to have a separate git repo that only contains the ovs plugin, as a kind of "best practice" illustration to vendors ?11:01
johnthetubaguyndipanov: +1 thats were the tasks idea was (partly) heading, but it grew too big an stalled11:01
*** haomaiwa_ has joined #openstack-nova11:01
jaypipesdanpb: right, exactly.11:01
PaulMurrayjohnthetubaguy, ndipanov at the moment the task state part is replicated between RuiChen spec and mine: https://review.openstack.org/#/c/216578/ and https://review.openstack.org/#/c/243096/11:01
danpbok, that sounds fine to me11:01
johnthetubaguyndipanov: PaulMurray: my worry with that spec is it stops all volume attach/detach happening in paralel11:01
openstackgerritmelanie witt proposed openstack/nova: Omit RescheduledException in instance_fault.message  https://review.openstack.org/16575111:02
openstackgerritmelanie witt proposed openstack/nova: Add RPCIsSynchronousFixture for synchronous RPC casts  https://review.openstack.org/24404511:02
openstackgerritmelanie witt proposed openstack/nova: Add a functional test for instance fault message with retry  https://review.openstack.org/24404611:02
jaypipesdanpb: k, I'll get on that this morning.11:02
danpbso all the other "legacy" plugins  can stay in nova/virt/libvirt then until we delete it in say Oxxxx11:02
ndipanovjohnthetubaguy, that is not good definitely11:02
PaulMurrayjohnthetubaguy, only for an instance? Did it happen in parallel before? attach was synchronized11:02
jaypipesdanpb: cool with me.11:02
ndipanovPaulMurray, on the compute node11:02
*** kairat has joined #openstack-nova11:02
johnthetubaguyPaulMurray: not from the API user perspective11:02
ndipanovwhich is fine11:02
johnthetubaguyndipanov: yeah +1 your description of it11:03
danpbjaypipes: i was thinking we should have a 'noop'  plugin as part of omain os-vif repo too11:03
danpbjaypipes: since , eg the 'bridge' vif config doesn't require any plug/unplug actions in the simple case11:03
PaulMurrayjohnthetubaguy, so the problem is if you issue a second attach/detach while one is going on, you get an error return11:03
ndipanovjohnthetubaguy, yeah tasks would define this sort of stuff but bring a whole lot more11:03
johnthetubaguyPaulMurray: what about rebasing your spec on top of Rui's spec? I know thats creating a painful chain, but that feels about right11:03
PaulMurrayjohnthetubaguy, I'm happy with that11:04
johnthetubaguyndipanov: yeah, thinking no resize while any volume of vif attach is happening, is what we want11:04
PaulMurrayI think we need some agreement on the task approach though - I can see your point about serializing the operations11:04
johnthetubaguyndipanov: bit worried that over complicates things though11:04
PaulMurrayat the API11:04
jaypipesdanpb: yeah, that makes sense (though we should just call it bridge.py instead of noop and document that it contains an example plugin class.11:05
danpbjaypipes: oh, and btw, before you merge that patch series, note that i have not tested it in any way whatsoever11:05
danpbjaypipes: so it undoubtably has python syntax errors hiding in it somewhere11:05
jaypipesdanpb: lol, the whole thing hasn't been tested anywhere, so no worries :)11:05
danpbok, i guess #1 job is writing some unit tests :-)11:05
danpbsahid might be interested in working on that11:05
jaypipesdanpb: it's a poc after all ;) right, first step is testing writing, but of course, that will be easier once we remove a whole bunch of stuff ;)11:05
johnthetubaguyPaulMurray: yeah, for me its about keeping the API backwards compatible, but allowing the bug fix of stopping resize before an attach has finished, a new micro version could tell you about the state, but the old version stays the same as much as possible, I feel we have to do that11:06
danpbjaypipes: btw do you have a pypi account ?  if so let me know your username so i can grant permission os-vif module11:06
*** zhangjn has quit IRC11:06
jaypipesdanpb: yup, I do. it's JayPipes11:07
*** yangyapeng has quit IRC11:07
*** EinstCra_ has quit IRC11:07
PaulMurrayjohnthetubaguy, we have the problem that an API server and a compute manager can be on different code during upgrade. So API would need to know what11:07
danpbjaypipes: hmm, is that correct capitalization - it claims that user doesn't exist11:08
PaulMurrayversion of compute manager was going to handle the operation11:08
PaulMurrayIf we included that it didn't do it for an old API, would that help (not sure how)11:08
jichenalex_xu: are you around?11:08
johnthetubaguyPaulMurray: I think we simply don't add the new state until all the computes are upgraded (i.e. the RPC API pin is lifted)11:08
jaypipesdanpb: Jay.Pipes maybe?11:09
alex_xujichen: hi, i'm here11:09
jaypipesdanpb: sorry, been a while since I released the talons library...11:09
danpbyep, that works11:10
jaypipescoolio, thanks.11:10
jichenalex_xu: do we need open bugs for each item on https://etherpad.openstack.org/p/nova-v2.1-api-doc  ?11:10
* jaypipes slaps PyPI for its insolence11:10
kairatFolks, During the image-upload I have found the following in Horizon: Images can be provided via an HTTP/HTTPS URL or be uploaded from your local file system. Compressed image binaries are supported (.zip and .tar.gz.). Do I understand correctly that if smb downloads a compressed image then he won't be able to boot it in Nova?11:11
alex_xujichen: emm...I think we needn't, as we already track them in the etherpad. But maybe we can have one bug to for this work11:11
kairathere is horizon source: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/images/templates/images/images/_create.html11:11
PaulMurrayjohnthetubaguy, that's good - what about the backward compatible API? Does one API server handle multiple versions at once?11:11
jichenalex_xu: um.. open a bug is fine , let me do this and see how doc guys react11:11
kairatI think this needs to be corrected but would like a confirmation from nova11:12
alex_xujichen: yea, see how doc team manage them. to be clear, I mean just one bug and put this etherpad link into it https://etherpad.openstack.org/p/nova-v2.1-api-doc11:12
jaypipeskairat: yes, AFAIK, if someone uploads a compressed image, it will not be bootable by Nova.11:13
jichenalex_xu: yeah, I have similar thought, but this might need their agreement since it will be hard for them to check , anyway, let me open it first11:13
kairatjaypipes, ok, thanks11:14
*** subscope has quit IRC11:14
jaypipeskairat: that said, perhaps Horizon is actuall decompressing those uploads before passing them off to Glance?11:14
johnthetubaguyPaulMurray: we do track that now (if that patch has merged)11:14
johnthetubaguyPaulMurray: but you are right, you want all API nodes and all Compute nodes upgraded11:15
johnthetubaguyPaulMurray: its tempting to claim API nodes are upgraded before you upgrade the compute nodes, but not sure we want to bake in that restriction11:15
kairatjaypipes, AFAIK, no(i have seen some bugs about it). But I will check with Horizon guys.11:16
johnthetubaguyPaulMurray: I would rather do the API last, but its a little impractical11:16
PaulMurrayjohnthetubaguy, I'll try to coordinate with RuiChen to get his spec sorted with these issues and make mine depend on his. We can discuss more on the spec if needed - I've taken enough of your time now.11:19
johnthetubaguyPaulMurray: thats cool, this is important stuff, appreciate you helping push this forward11:19
PaulMurraythanks johnthetubaguy ndipanov11:19
openstackgerritRoman Bogorodskiy proposed openstack/nova-specs: User-controlled SR-IOV ports allocation  https://review.openstack.org/18224211:21
*** haomaiwa_ has quit IRC11:21
*** haomaiwa_ has joined #openstack-nova11:21
*** amotoki has joined #openstack-nova11:22
*** stevemar_ has joined #openstack-nova11:23
*** fawadkhaliq has quit IRC11:26
*** stevemar_ has quit IRC11:26
johnthetubaguyPaulMurray: ndipanov: came up with a slightly horrid idea of looking a pending instance actions in the database to block the changing of tasks state from None to something else, that seems  to meet all our goals at least, added comments in the spec11:27
johnthetubaguyat least with that described in the spec, we have a clear choice between two viable directions11:27
johnthetubaguy(an the complexity trade offs)11:28
alex_xujichen: ok, thanks11:29
*** EinstCrazy has joined #openstack-nova11:31
openstackgerritSudipta Biswas proposed openstack/nova: Introduce utility module for pcp  https://review.openstack.org/20316311:32
*** otter768 has joined #openstack-nova11:32
*** liusheng has quit IRC11:33
*** liusheng has joined #openstack-nova11:34
*** rfolco has joined #openstack-nova11:34
*** fawadkhaliq has joined #openstack-nova11:34
*** ihrachys has joined #openstack-nova11:35
*** gcb has joined #openstack-nova11:35
*** zhangjn has joined #openstack-nova11:35
*** fawadkhaliq has quit IRC11:35
*** fawadkhaliq has joined #openstack-nova11:36
*** otter768 has quit IRC11:37
openstackgerritRoman Bogorodskiy proposed openstack/nova-specs: Distribute PCI Requests Across Multiple Devices  https://review.openstack.org/14209411:37
*** markvoelker has joined #openstack-nova11:37
tdurakovPaulMurray, hi, are you around?11:39
*** dims has joined #openstack-nova11:41
PaulMurraytdurakov, hi, yes I am11:42
*** markvoelker has quit IRC11:42
tdurakovPaulMurray, have you decided when to run subteam meeting?11:42
kashyapThere was a note on the mailing list that it's Tuesdays (some time, I have to look up).11:43
PaulMurrayyes, the patch for the IRC slot merged last night: Tuesdays at 1400 on openstack-meeting-311:44
*** kairat has left #openstack-nova11:44
tdurakovkashyap, PaulMurray, yep, Tuesdays at 1400 UTC on #openstack-meeting-3 starting. Just wanted to get some confirmation about11:44
tdurakovthx11:44
PaulMurrayI will send another email to confirm today - I'm also just fixing up the wiki page with linkes etc and will send the email11:44
PaulMurraytdurakov, I saw your patch for the CI job - I will get jLanoux to track it and help if he can11:47
openstackgerritRoman Bogorodskiy proposed openstack/nova-specs: User-controlled SR-IOV ports allocation  https://review.openstack.org/18224211:48
tdurakovPaulMurray, sounds great:) there is another one in nova, where actually all magic should be done. Need to merge them first, than can continue with reconfiguration env for that11:48
PaulMurraytdurakov, cool, thanks11:49
PaulMurraydo you have links11:49
PaulMurrayare they the ones in the etherpad ?11:50
tdurakovPaulMurray, there is an etherpad with phases for this job, thanks a lot to sdague for that https://etherpad.openstack.org/p/live-migration-multinode Link for nova patch: https://review.openstack.org/#/c/243557/11:50
tdurakovalso i've added draft for nfs inetherpad. it would be located in nova project11:51
*** kmartin has quit IRC11:52
andrearosaalex_xu: do you have time to discuss about your comments on https://review.openstack.org/226199 ?11:52
openstackgerritSergey Nikitin proposed openstack/nova: enginefacade: 'instance_tags'  https://review.openstack.org/24405811:53
alex_xuandrearosa: yea11:53
andrearosaalex_xu: good. As regards the soft reboot we do not want to fall back to hard reboot as that will abort the live migration11:54
*** haomaiwa_ has quit IRC11:55
*** smatzek has joined #openstack-nova11:55
andrearosaalex_xu: we can pass the info about that a live migration is in place down to the driver to avoid to call the hard reboot, how does it sound to you?11:55
tdurakovhas anyone problems with devstack right nova?11:56
tdurakov*right now11:56
alex_xuandrearosa: yea, that sounds work.11:57
*** zhangjn has quit IRC11:58
BobBallWhen attaching to an iSCSI block device, is (target_host, target_port, targetIQN) guaranteed to give you a single device?  In general I might expect to also check the LUN or SCSIID, but these parameters aren't used (as far as I can see) by the libvirt driver?11:58
BobBalloh - maybe I am blind...11:58
andrearosaalex_xu: as regards the task_state I was thinking to leave nova managing what does at the moment but then add more logic to reverse the task_state to migrating if the migration is still running (don't know how to check it at the moment but I think there is a way)11:59
alex_xuandrearosa: what is vm status to show for user? after the status rebooting, the status back to live migrating?11:59
alex_xuandrearosa: yea, that works12:00
*** stevemar_ has joined #openstack-nova12:00
andrearosaalex_xu: last thing you were right about lock/unlock and rename they are already alloes operations, sorry for that.12:00
alex_xuandrearosa: np12:00
andrearosaalex_xu: I am going to recap everything in a new patch set.12:01
*** kylek3h has joined #openstack-nova12:01
alex_xuandrearosa: cool, thanks, and better write those reboot concern in the patch set12:01
*** rubasov has quit IRC12:01
andrearosaalex_xu: sure, thanks for your time.12:01
*** doug-fis_ is now known as doug-fish12:02
alex_xuandrearosa: np :)12:02
*** zhangjn has joined #openstack-nova12:02
*** fawadkhaliq has quit IRC12:02
*** subscope has joined #openstack-nova12:05
*** kylek3h has quit IRC12:05
*** mwagner has quit IRC12:08
tdurakovsdague, hi, seen your +2 for hook in nova, so when it's being merged, could we merge project-config part too?12:09
*** e0ne has quit IRC12:11
openstackgerritjichenjc proposed openstack/nova: Make lock policy default to admin or owner  https://review.openstack.org/24221312:18
*** e0ne has joined #openstack-nova12:18
*** Guest40458 has quit IRC12:19
*** jwcroppe has joined #openstack-nova12:20
*** rubasov has joined #openstack-nova12:20
*** PaulMurray is now known as PaulMurray_lunch12:21
sdaguetdurakov: so I withdrew the +2 for a minute, can you update the script with a header that explains a bit more about why it's there, or put a README in the live_migration directory?12:22
sdaguebecause it doesn't have a lot of context for other reviewers at this point12:22
sdagueand it would be good to stand on it's own as a review12:23
*** dansmith has joined #openstack-nova12:23
*** dansmith is now known as Guest7127312:23
tdurakovsdague, ok, sure, I'll add some info in header of this script12:24
afaranhaHello, do anyone here runs devstack with SSL? And if so, how can I configure Nova to work with SSL?12:24
afaranhaWhen I use the curl command passing the ca-cert.pem it works fine, but using nova client it return "verify failed"12:24
sdaguetdurakov: thanks12:24
jaypipesjohnthetubaguy: I'm fine adding rest apis instead of nova-manage commands for the resource-providers thing. was trying to keep the (growing) scope down :)12:28
johnthetubaguyjaypipes: yeah, keeping the scope small makes sense, maybe add a second spec for the REST API, although thats a little crazy?12:28
*** Marga_ has quit IRC12:30
*** Marga_ has joined #openstack-nova12:30
*** openstackgerrit has quit IRC12:31
*** openstackgerrit has joined #openstack-nova12:32
jaypipesjohnthetubaguy: no, I'll add the REST API scope to this one.. no worries. Need to change the os-simple-tenant-usage API extension imlpementation anyway because of this.12:33
*** lucasagomes is now known as lucas-hungry12:33
jaypipessdague, johnthetubaguy, melwitt: the dependent patches from https://review.openstack.org/#/c/221310 look to be sensible and straightforward, if you have a chance to review, thanks in advance.12:34
johnthetubaguyjaypipes: OK, makes sense12:34
*** mnestratov has joined #openstack-nova12:34
johnthetubaguyjaypipes: ah, these ones: https://review.openstack.org/#/q/topic:bp/new-oslodb-enginefacade,n,z12:35
jaypipesjohnthetubaguy: right.12:35
*** jinxing has joined #openstack-nova12:35
jaypipesjohnthetubaguy: the base is now merged. the dependent patches incrementally enable the facade in the DB API.12:35
*** thorst has joined #openstack-nova12:35
sdaguejaypipes: oh, so because the dependent patch merged, and those aren't a series, but a fan out, gerrit looses all the relationship info12:36
*** jerrygb has joined #openstack-nova12:37
jaypipessdague: they are a series because they are topic-related, but are not strictly dependent on each other, yeah..12:37
sdagueyep, I get it now12:38
sdagueis there a good pointer to the basics of engine fascade so I can educate myself enough for reviewing properly?12:38
openstackgerritTimofey Durakov proposed openstack/nova: Hook for live-migration job  https://review.openstack.org/24355712:38
tdurakovsdague, jaypipes,  done, please review again12:38
jaypipessdague: there is a very lengthy docstring in oslo.db, yeah... one sec, grabbing link.12:38
*** pratikmallya has joined #openstack-nova12:39
*** Marga_ has quit IRC12:39
*** Marga_ has joined #openstack-nova12:40
jaypipessdague: actually, https://github.com/openstack/oslo.db/blob/master/doc/source/usage.rst covers the important bits.12:41
sdaguetdurakov: +212:41
jaypipessdague: but the idea here is that we are removing the manual session object handling/parameters and replacing with decorators that describe the sqlalchemy API function as either participating in a reader or writer transaction context.12:42
*** pratikmallya has quit IRC12:42
sdagueand the writer / reader is signaling usage so that locking is optimized?12:43
jaypipessdague: correct.12:43
jaypipessdague: you will notice that these patches remove the use of:12:43
jaypipeswith session.begin():12:43
jaypipesblocks.12:43
openstackgerritSudipta Biswas proposed openstack/nova: Introduce utility module for pcp  https://review.openstack.org/20316312:43
jaypipesbecause the transaction handling is all done by the facade's transaction contexts12:43
sdagueyep, I think the only last question is around things like the foo.save(session=context.session)12:44
tdurakovsdague, thank you!12:44
sdagueis that just because objects aren't aware12:45
*** thorst has quit IRC12:45
jaypipessdague: hmm, I think dansmith had removed all uses of that (and replaced with save(context) instead, which would pass the context objec to the DB API method instead of any sesion.12:45
sdagueI'm looking at - https://review.openstack.org/#/c/239915/8/nova/db/sqlalchemy/api.py,cm12:45
sdagueit seems all the saves are done that way12:46
jaypipesoh, yes, sorry I thought you meant the nova.objects.XXX.save() methods!12:46
mnestratovHi, all12:46
mnestratovjohnthetubaguy: thnak you for approving https://review.openstack.org/#/c/184295/12:47
sdagueoh, right, I guess these are models not objects, my bad12:47
jaypipessdague: yes, the *SQLAlchemy* model object's save() method should always use the context.session parameter instead of the implicit session object (this gets rid of those annoying "cannot save orphaned object" messages.12:47
sdaguegotcha. I wonder if there is a way to make that more automatic in some way...12:48
mnestratovjohnthetubaguy: just wanted to make you a bit happier - we have CI as promised12:48
jaypipessdague: from what I gather from zzzeek, we deliberately wanted that to be explicit and not implicit any more.12:49
sdaguebut, anyway, this makes sense to me now, I'll go through them in a few12:49
sdagueok, that's cool12:49
*** astupnikov has joined #openstack-nova12:49
sdaguefor an effort like this in the future it might be nice to just have an email fired out with "reviewer notes" just so more people can get up to speed with the changes and review them faster, but I get it now.12:50
*** thorst has joined #openstack-nova12:50
jaypipessdague: agreed completely.12:51
mnestratovjohnthetubaguy: see http://ci-watch.tintri.com/project?project=nova   Virtuozzo CI, Virtuozzo Storage CI - are ours, and the storage one is testing https://review.openstack.org/#/c/190843/ changes12:51
*** astupnikov has quit IRC12:51
*** markvoelker has joined #openstack-nova12:53
sdaguejaypipes: https://review.openstack.org/#/c/240275/8/nova/db/sqlalchemy/api.py,cm soft_delete doesn't need a session? or is that because it got it handed it by the model that was created?12:53
sdagueL637112:54
*** rook has joined #openstack-nova12:54
sdagueyeh, so there is a contradiction, the soft_delete here - https://review.openstack.org/#/c/244029/1/nova/db/sqlalchemy/api.py,cm does get passed a session12:55
sdagueso, one of those is wrong12:55
sdagueL480212:55
sdagueor I'm missing a subtlety12:56
*** pratikmallya has joined #openstack-nova12:58
*** markvoelker has quit IRC12:58
*** jhesketh has quit IRC12:58
*** dims has quit IRC12:59
jaypipessdague: looking..12:59
*** fawadkhaliq has joined #openstack-nova12:59
*** jhesketh has joined #openstack-nova13:00
*** PaulMurray_lunch is now known as PaulMurray13:01
*** gcb has quit IRC13:02
jaypipessdague: looks like that is fine. It's not a contradiction. the SoftDeletMixin.soft_delete() expects a session argument: https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/models.py#L14413:02
*** gcb has joined #openstack-nova13:03
*** salv-orlando has joined #openstack-nova13:03
sdaguejaypipes: ok, but when done as a model_query it returns a query, which has soft_delete as a mixin that doesn't need it?13:06
sdagueI guess that's just a bit of a confusing polymophism :)13:06
sdaguebut so be it13:06
jaypipessdague: one sec, gimme a few, on phone now :)13:06
sdagueok, no prob13:06
*** salv-orlando has quit IRC13:09
*** jinxing has quit IRC13:10
*** jyuso1 has quit IRC13:11
*** takedakn has joined #openstack-nova13:11
sdagueI had another general question, it was very clear before when sessions end and things commit or rollback13:14
*** Marga_ has quit IRC13:14
*** achanda has joined #openstack-nova13:15
sdaguein https://review.openstack.org/#/c/242019/6/nova/db/sqlalchemy/api.py,cm - when does the commit trigger for those things in context.session.add ?, when the function ends?13:15
*** xyang1 has joined #openstack-nova13:17
*** dprince has joined #openstack-nova13:18
*** achanda has quit IRC13:19
dprinceTripleO has been broken for weeks due to this Nova bug. https://bugs.launchpad.net/tripleo/+bug/151387913:20
openstackLaunchpad bug 1513879 in OpenStack Compute (nova) "NeutronClientException: 404 Not Found" [High,In progress] - Assigned to Derek Higgins (derekh)13:20
dprinceAny core reviews on this (easy) fix would be appreciated... https://review.openstack.org/#/c/242158/13:20
*** Marga_ has joined #openstack-nova13:21
*** gcb has quit IRC13:21
sdaguedprince: garyk indications it's just a client lib revision issue?13:24
garyk1sdague: i think that the issue is when the neutron plugin does not have l3 support. the fix looks good to me13:25
*** gcb has joined #openstack-nova13:25
garyk1i tried to reproduce on trunk but was able to. i am not sure which plugin derrick is using13:26
*** bharath has quit IRC13:27
dprincesdague: so it was actually a Nova commit that brought this about... c62f698ef1f1e69bd5eb3c6544ee305f96488d4213:27
dprincegot busy around summit and didn't catch this until last week13:28
sdaguewhat is the actual exception type that's exposed here when it fails this way13:28
sdaguebecause poking inside neutron client exception internals is a thing we'd kind of like to avoid if possible13:29
*** kylek3h has joined #openstack-nova13:29
*** baoli has joined #openstack-nova13:30
dprincesdague: agree, but we view this as a regression. THe previous code worked... now it doesn't13:30
*** edmondsw has joined #openstack-nova13:31
sdagueok, sure, but before putting a bunch more ugly in here, it would be good to figure out if the right fix is actually neutronclient13:31
*** kylek3h has quit IRC13:31
sdaguebecause I don't understand why it wouldn't return a sane thing here13:31
*** baoli_ has joined #openstack-nova13:31
*** fawadkhaliq has quit IRC13:32
*** fawadkhaliq has joined #openstack-nova13:32
*** otter768 has joined #openstack-nova13:33
johnthetubaguysdague: is it just me, or maybe we want both versions, so it could consider raising NotFound in the future?13:34
*** baoli has quit IRC13:35
sdaguejohnthetubaguy: well, if we fix neutronclient to be more coherent, get the release, and bump the minimum, it fixes it plus is less prone to future breaking13:35
johnthetubaguysdague: ah, true13:36
sdaguebecause it looks from comments that everyone expected this to be the contract13:36
sdaguehttps://review.openstack.org/#/c/242158/3/nova/tests/unit/network/test_neutronv2.py,cm seems to indication it's not an l3 issue, it's project not found exception from neutron13:36
sdagueis that because it's really an untranslated keystone exception?13:38
*** lykinsbd has joined #openstack-nova13:38
*** otter768 has quit IRC13:38
*** shardy has joined #openstack-nova13:38
openstackgerritSergey Nikitin proposed openstack/nova: Added method is_supported to check API microversions  https://review.openstack.org/24021813:38
*** dave-mccowan has joined #openstack-nova13:41
*** haomaiwang has joined #openstack-nova13:41
*** mwagner has joined #openstack-nova13:42
*** w_verdugo has quit IRC13:43
*** pratikmallya has quit IRC13:44
*** Marga_ has quit IRC13:44
*** jichen has quit IRC13:46
*** w_verdugo has joined #openstack-nova13:49
derekhsdague: even if it is fixed in neutron client, shoulnd the nova code be handling both the current case and the fixed ?13:49
derekhsdague: context, this patch https://review.openstack.org/#/c/242158/13:50
openstackgerritSergey Nikitin proposed openstack/nova: Added method is_supported to check API microversions  https://review.openstack.org/24021813:52
*** lykinsbd has quit IRC13:54
*** subscope has quit IRC13:54
*** markvoelker has joined #openstack-nova13:54
mdboothsdague: https://review.openstack.org/#/c/244027/ :) Rethinking the semantics of the patch that broke it.13:54
*** lykinsbd has joined #openstack-nova13:55
danpbjohnthetubaguy: as PTL we need your +1  on https://review.openstack.org/#/c/244097/  & https://review.openstack.org/#/c/244006   to approve setup of os-vif  in infra, as we're saying it is under the Nova umbrella13:55
ansiwenalaski: hi, I fixed a bug you reported. May wanna have a look? https://review.openstack.org/#/c/24361613:56
sdaguederekh: the bug report is currently entirely a stack trace, it doesn't explain the request flow that gets you there and what's going on. Before reverting we need to at least understand a little.13:57
*** bharath has joined #openstack-nova13:57
dprincederekh: if we need to go and fix this in neutron/neutronclient then fine... but we should probably (at least try) to get Nova to bump their neutronclient once that happens if they only want the new codepath13:58
sdaguemdbooth: can we get that rechecked a few times13:58
derekhsdague: its not a revert, ok I'll find out the neutronclient codepath13:58
*** markvoelker has quit IRC13:58
sdaguederekh: or more details would be nice, like I said, the bug right now is just a stack trace13:59
sdagueand the patch implies it would only be triggered if you asked for non existant project_ids13:59
johnthetubaguydanpb: cool, +1ed those13:59
lbeliveandipanov: following our discussion, please review https://review.openstack.org/#/c/242573/4 when you have a chance14:00
*** rlrossit has joined #openstack-nova14:00
sdaguedanpb: let me go see if I can shake a second +2 to get the repo built14:00
*** haomaiwang has quit IRC14:01
openstackgerritLorenzo Affetti proposed openstack/nova: FakeDriver: adding and removing instances on live migration.  https://review.openstack.org/24361314:01
*** mgoddard_ has joined #openstack-nova14:01
*** haomaiwang has joined #openstack-nova14:01
danpbsdague: cool thanks14:01
derekhsdague: yes it shows an exception that used to be caught and now clearly isn't, its not due to non existant project_ids its because our undercloud doesn't have a l3 agent and this is how neutron behaves when there is no L3 agent14:02
derekhsdague: gotta do a school run will add more to the bug when I'm back14:02
*** bharath has quit IRC14:03
*** mdrabe has joined #openstack-nova14:03
sdaguederekh: hmmm except the code commit that put this in says this is how it does work in that case14:03
*** links has quit IRC14:04
*** josecastroleon has joined #openstack-nova14:04
*** mgoddard has quit IRC14:05
*** pratikmallya has joined #openstack-nova14:05
sdaguemdbooth: so if we pass recheck 5 times on that patch, I'm +214:06
sdaguemdbooth: I put a -1 on it for now just to indicate that expectation (with comments)14:07
*** fawadkhaliq has quit IRC14:07
sdaguemdbooth: this also tripped up part of ceilometer, do they have an equiv fix?14:07
*** baoli_ has quit IRC14:08
*** sudipto has quit IRC14:08
*** rotbeard has quit IRC14:08
*** agireud has quit IRC14:08
*** NightKhaos has quit IRC14:08
*** arif-ali has quit IRC14:08
*** lyarwood has quit IRC14:08
*** pratikma_ has joined #openstack-nova14:08
*** ccarmack has joined #openstack-nova14:09
*** pratikmallya has quit IRC14:10
*** ctrath has joined #openstack-nova14:11
*** su_zhang has joined #openstack-nova14:13
*** subscope has joined #openstack-nova14:13
*** dims has joined #openstack-nova14:15
*** baoli_ has joined #openstack-nova14:15
*** sudipto has joined #openstack-nova14:15
*** rotbeard has joined #openstack-nova14:15
*** agireud has joined #openstack-nova14:15
*** NightKhaos has joined #openstack-nova14:15
*** arif-ali has joined #openstack-nova14:15
*** lyarwood has joined #openstack-nova14:15
*** markvoelker has joined #openstack-nova14:15
mdboothsdague: I'll look, thanks for the heads up.14:16
*** bharath has joined #openstack-nova14:16
*** Piet has quit IRC14:17
*** aix has quit IRC14:18
*** mriedem has joined #openstack-nova14:21
*** rotbeard has quit IRC14:21
*** dims has quit IRC14:23
*** Piet has joined #openstack-nova14:25
*** dims has joined #openstack-nova14:26
*** ijuwang has joined #openstack-nova14:27
*** haomaiwang has quit IRC14:28
*** cfriesen__ has joined #openstack-nova14:28
openstackgerritChangBo Guo(gcb) proposed openstack/nova: test:clean up wrong value in method CONF.set_override  https://review.openstack.org/24241614:28
*** haomaiwang has joined #openstack-nova14:28
*** zhangjn has quit IRC14:28
*** marzif_ has quit IRC14:29
*** kylek3h has joined #openstack-nova14:33
*** eharney has quit IRC14:36
mriedemjohnthetubaguy: do you know if anyone from rax is going to take this over? https://review.openstack.org/#/c/215311/14:37
mriedemmikal: ^14:37
mriedemwe have the lxc job in nova's experimental queue14:38
*** annegentle has joined #openstack-nova14:38
johnthetubaguymriedem: his manager is trying to find someone to take it on, don't think he has found someone with spare cycles yet14:39
mriedemok14:39
*** Piet has quit IRC14:40
mriedemjust offer him and comstud buckets of cash to come back14:40
*** bradjones|away is now known as bradjones14:40
johnthetubaguymriedem: yeah, glad ew got that lxc gob in experimental, now to get it working I think dwalak (?) is pushing on that14:40
*** lucas-hungry is now known as lucasagomes14:40
johnthetubaguymriedem: I am assuming they tried that already14:40
*** david-ly_ has joined #openstack-nova14:41
*** takedakn has quit IRC14:41
*** su_zhang has quit IRC14:42
*** david-lyle has quit IRC14:42
*** aix has joined #openstack-nova14:49
*** diogogmt has joined #openstack-nova14:50
*** mc_nair has joined #openstack-nova14:51
*** signed8bit has joined #openstack-nova14:52
*** dustins has joined #openstack-nova14:54
*** Guest71273 is now known as dansmith14:54
*** annegentle has quit IRC14:55
*** mlavalle has joined #openstack-nova14:55
mlavallejohnthetubaguy: ping14:55
*** dansmith is now known as Guest3660514:55
raildojohnthetubaguy: hey, now all test are passing, and I updated the bp status for 'needs code review' https://blueprints.launchpad.net/nova/+spec/nested-quota-driver-api :)14:58
*** annegentle has joined #openstack-nova14:58
openstackgerritAnne Gentle proposed openstack/nova: Rearranges to create new Compute API Guide  https://review.openstack.org/23018614:58
openstackgerritJohn Garbutt proposed openstack/nova: Handle DB failures in servicegroup DB driver  https://review.openstack.org/23391414:59
*** annegentle has quit IRC15:00
*** pradk has joined #openstack-nova15:00
*** takedakn has joined #openstack-nova15:00
*** dustins has quit IRC15:00
*** haomaiwang has quit IRC15:01
*** dustins has joined #openstack-nova15:01
*** haomaiwang has joined #openstack-nova15:01
*** dustins has quit IRC15:01
*** fawadkhaliq has joined #openstack-nova15:01
*** dims has quit IRC15:03
*** breitz has joined #openstack-nova15:03
*** claudiub has quit IRC15:04
*** Guest36605 is now known as dansmith15:06
mriedemmnestratov: are you around?15:06
openstackgerritSergey Nikitin proposed openstack/nova: WIP: enginefacade: 'fixed_ip'  https://review.openstack.org/24081115:07
openstackgerritSergey Nikitin proposed openstack/nova: enginefacade: 'instance'  https://review.openstack.org/24414615:07
mnestratovmriedem: yeah15:07
mriedemmnestratov: i also asked in https://review.openstack.org/#/c/190843/ but does that allow attaching volumes using the vz storage backend to vz containers?15:07
mriedemthis is currently marked as missing http://docs.openstack.org/developer/nova/support-matrix.html#operation_attach_volume15:08
*** mgoddard has joined #openstack-nova15:11
*** mgoddard_ has quit IRC15:11
*** vladikr has joined #openstack-nova15:12
*** yonglihe has joined #openstack-nova15:13
*** diogogmt has quit IRC15:14
johnthetubaguymlavalle: sorry, missed your pin, can I help?15:14
mnestratovmriedem: that's right, with this change we can attach volumes to containers15:16
mlavallejohnthetubaguy: just want to bring your attention to this spec: https://review.openstack.org/#/c/90150/ It's the DNS integration. When you guys have a chance, please review it15:16
*** thangp has joined #openstack-nova15:16
*** garyk1 has quit IRC15:17
mlavallejohnthetubaguy: really looking forward to get it apporved for Mitaka15:17
mlavalleapproved^^^15:17
*** yonglihe has quit IRC15:18
*** yonglihe_ is now known as yonglihe15:18
*** breitz has quit IRC15:18
*** breitz1 has joined #openstack-nova15:18
*** heyongli_ has joined #openstack-nova15:18
*** mrkz has joined #openstack-nova15:19
*** sneti has joined #openstack-nova15:20
*** marzif_ has joined #openstack-nova15:20
*** claudiub has joined #openstack-nova15:21
*** breitz1 is now known as breitz15:22
johnthetubaguymlavalle: that is on my TODO list, can't promise it will be today I am afraid.15:22
*** stackdump has joined #openstack-nova15:24
mriedemmnestratov: can you find a man page for pstorage-mount? i'm not finding one via google, just this: https://openvz.org/w/index.php?title=Virtuozzo_Storage15:24
*** eharney has joined #openstack-nova15:25
mlavallejohnthetubaguy: thanks! have a nice day :-)15:26
*** takedakn has quit IRC15:26
mnestratovmriedem: here you are https://openvz.org/Virtuozzo_Storage15:27
mnestratovhttp://download.parallels.com/doc/pcs/pdf/Parallels_Cloud_Storage.pdf15:27
mriedem40415:27
*** sfinucan has joined #openstack-nova15:27
mriedemhttps://download.openvz.org/doc/man-pages.pdf15:27
mnestratovmriedem: oops15:27
*** claudiub has quit IRC15:28
*** sneti has quit IRC15:28
mriedembut pstorage-mount isn't in that doc15:28
*** sneti has joined #openstack-nova15:28
mnestratovyeah, probably renaming issue15:28
*** stackdump has quit IRC15:28
openstackgerritAndrea Rosa proposed openstack/nova-specs: Allow more instance operations during live migration  https://review.openstack.org/22619915:31
mnestratovmriedem: hmm, I didn't know we have issues with documentations, trying to find out where I can get them15:31
*** kfarr has joined #openstack-nova15:31
*** otter768 has joined #openstack-nova15:34
*** HenryG has quit IRC15:34
krotscheckCould I get some core eyes on a CORS patch? [/ba-dum-bump] https://review.openstack.org/#/c/236993/15:37
*** burgerk has joined #openstack-nova15:37
*** salv-orlando has joined #openstack-nova15:38
*** HenryG has joined #openstack-nova15:38
mnestratovmriedem: may be the best way to get full man pages is to install rpm, very little info is here http://download.cloudserver.odin.com/doc/pcs/en_us/parallels/6/current/pdf/Parallels_Cloud_Storage_Administrators_Guide.pdf15:38
*** bharath has quit IRC15:38
*** otter768 has quit IRC15:39
*** electrocucaracha has joined #openstack-nova15:41
*** tonytan4ever has joined #openstack-nova15:44
*** edtubill has joined #openstack-nova15:44
openstackgerritdstepanenko proposed openstack/nova: WIP: This is 2nd part of changes according to pci-generate-stats blueprint.  https://review.openstack.org/24313115:47
*** tongli has joined #openstack-nova15:48
*** emagana has joined #openstack-nova15:48
*** dustins has joined #openstack-nova15:49
sdaguedanpb: https://review.openstack.org/#/c/244006/ is merged, repo should exist shortly15:52
danpbgreat15:53
danpbjaypipes: we're almost there for infra ^^^^15:54
*** mtanino has joined #openstack-nova15:56
*** armax has joined #openstack-nova15:56
*** mdrabe has quit IRC15:57
mriedemmnestratov: ok, comments in https://review.openstack.org/#/c/190843/15:57
mnestratovmriedem:15:57
mnestratovwget https://download.openvz.org/pstorage/current/pstorage-client-6.0.5-25.x86_64.rpm15:57
mnestratovwget https://download.openvz.org/pstorage/current/pstorage-ctl-6.0.5-25.x86_64.rpm15:57
mnestratovwget  https://download.openvz.org/pstorage/current/pstorage-libs-shared-6.0.5-25.x86_64.rpm15:57
mnestratovthen15:57
mnestratovyum install pstorage-libs-shared-6.0.5-25.x86_64.rpm15:57
mnestratovyum install pstorage-ctl-6.0.5-25.x86_64.rpm15:57
mnestratovyum install pstorage-client-6.0.5-25.x86_64.rpm15:57
mnestratovman pstorage-mount15:57
mriedemew15:58
mriedemcan't that just be on a vz docs page somewhere?15:58
*** rook has quit IRC15:58
jaypipesdanpb: sweet, thank you. I'm about 2 hours away from vif-plug-ovs completion.15:58
danpbnb, our very first commit will need to have passing unit tests :-)15:59
danpbi figure we just squash the history from your current git repo and push it as a single review15:59
*** haomaiwang has quit IRC16:01
*** rook has joined #openstack-nova16:01
*** Piet has joined #openstack-nova16:01
*** haomaiwang has joined #openstack-nova16:01
johnthetubaguydanpb: can't infra do some import for you, behind gerrit?16:01
johnthetubaguydanpb: although I guess its not much history to loose16:02
*** openstackgerrit has quit IRC16:02
*** lbelivea has quit IRC16:02
*** diogogmt has joined #openstack-nova16:02
*** liverpooler has quit IRC16:02
sfinucanCould I ask what's the process for modifying a spec? For example, can they be modified once approved (i.e. to clarify something) and is it then a trivial reapproval?16:02
mnestratovmriedem: it should have been, but I didn't find it. Responsinble people aren't around16:02
dansmithsfinucan: yes16:02
*** openstackgerrit has joined #openstack-nova16:02
johnthetubaguysfinucan: just put a change up for a spec, and it gets reviewed as normal16:03
sfinucandansmith: awesome. December 3 looms large... :)16:03
mnestratovmriedem: thank for review, will try to address asap16:03
*** hogepodge has joined #openstack-nova16:03
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: config options: centralize section "serial_console"  https://review.openstack.org/24417716:03
*** kmartin has joined #openstack-nova16:04
*** tonytan4ever has quit IRC16:04
danpbjohnthetubaguy: yes, but I didn't think the current history was very important/useful, and this forces us to be good about unit testing the initial code :-)16:05
*** thedodd has joined #openstack-nova16:05
johnthetubaguydanpb: makes sense16:05
openstackgerritMatthew Booth proposed openstack/nova: Fix typo in test_post_select_populate  https://review.openstack.org/24417816:06
*** rook has quit IRC16:06
mirrorboxjaypipes: hey, are you around?16:07
*** david-ly_ is now known as david-lyle16:07
*** rlrossit has quit IRC16:09
openstackgerritAndrew Bogott proposed openstack/nova: Add disk_minimum_physical_free_space_ratio option to disk filter.  https://review.openstack.org/24225116:09
*** baoli_ has quit IRC16:10
jaypipesmirrorbox: just grabbing something to eat (getting grumpy...). will be back in about an hour, ok?16:10
*** marzif__ has joined #openstack-nova16:11
jwcroppejaypipes: but you're always grumpy  :)16:11
jaypipeslol16:12
mirrorboxjaypipes: bon appetit! just wanted to ping you to take a look at updates at https://review.openstack.org/#/c/182242/16:12
*** rlrossit has joined #openstack-nova16:13
*** belmoreira has quit IRC16:13
jaypipesmirrorbox: yup, it's on my list of reviews for today.16:13
sdaguehttps://github.com/openstack/os-vif looks like it's a thing as of 3 minutes ago, so go for it16:13
*** mdrabe has joined #openstack-nova16:14
*** boris-42_ has joined #openstack-nova16:14
*** subscope has quit IRC16:14
*** whenry_ has joined #openstack-nova16:15
*** subscope has joined #openstack-nova16:15
*** tangchen__ has joined #openstack-nova16:16
*** notmorga1 has joined #openstack-nova16:16
mirrorboxjaypipes: great, thanks16:16
*** subscope has quit IRC16:16
mirrorboxhm, and there were stuff i wanted to ask about os-vif btw16:16
*** EmilienM has quit IRC16:17
*** kashyap has quit IRC16:17
*** jdurgin1 has quit IRC16:17
*** notmorgan has quit IRC16:17
*** q3k has quit IRC16:17
*** edtubill has quit IRC16:17
*** marzif_ has quit IRC16:17
*** boris-42 has quit IRC16:17
*** wverdugo500 has quit IRC16:17
*** sileht has quit IRC16:17
*** tangchen_ has quit IRC16:17
*** scheuran has quit IRC16:17
*** tanee has quit IRC16:17
*** dguitarbite has quit IRC16:17
*** subscope has joined #openstack-nova16:17
*** scheuran has joined #openstack-nova16:17
*** EmilienM_ has joined #openstack-nova16:17
*** wverdugo500 has joined #openstack-nova16:17
*** tanee has joined #openstack-nova16:17
*** dguitarbite has joined #openstack-nova16:17
*** q3k1 has joined #openstack-nova16:17
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: config options: add hacking check for help text length  https://review.openstack.org/24207816:17
*** ctrath has quit IRC16:17
*** kashyap has joined #openstack-nova16:17
PaulMurrayRuiChen, are you around?16:18
*** dustins has quit IRC16:18
*** EmilienM_ is now known as EmilienM16:18
*** suro-patz has joined #openstack-nova16:18
*** notmorga1 is now known as notmorgan16:18
*** sileht has joined #openstack-nova16:18
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/24393616:19
PaulMurrayRuiChen, wanted to talk about https://review.openstack.org/#/c/216578/ - I'll catch up with you later16:19
*** jdurgin1 has joined #openstack-nova16:19
*** boris-42_ is now known as boris-4216:19
*** ctrath has joined #openstack-nova16:21
*** dustins has joined #openstack-nova16:21
openstackgerritAnne Gentle proposed openstack/nova: Rearranges to create new Compute API Guide  https://review.openstack.org/23018616:22
openstackgerritDan Smith proposed openstack/nova: Fix race in _poll_shelved_instances task  https://review.openstack.org/24372416:22
openstackgerritDan Smith proposed openstack/nova: Fix impotent _poll_shelved_instances tests  https://review.openstack.org/24374016:22
ccarmackmriedem: do you a little time to look at my reply to your comments on https://review.openstack.org/#/c/228908/10/specs/mitaka/approved/user-settable-server-description.rst16:23
*** salv-orlando has quit IRC16:23
*** janiceonchn has quit IRC16:23
*** gcb has quit IRC16:24
mriedemwhen i get to it16:24
*** whenry_ has quit IRC16:25
heyongli_hi, now PCI CI occasionally hit bug: https://bugs.launchpad.net/oslo.db/+bug/1477080. if any one know how to elimated this bug effect before it finally packaged, ping me please.16:27
openstackLaunchpad bug 1477080 in oslo.db "No _writer_maker attribute on enginefacade.writer" [Medium,In progress] - Assigned to Mike Bayer (zzzeek)16:27
*** klkumar has joined #openstack-nova16:27
*** subscope has quit IRC16:27
*** alex_klimov has quit IRC16:27
*** subscope has joined #openstack-nova16:29
mriedemrpodolyaka: snikitin: ^16:29
openstackgerritStephen Finucane proposed openstack/nova-specs: Add 'auto' case to virt-driver CPU thread pinning  https://review.openstack.org/24419816:29
*** dims has joined #openstack-nova16:30
*** subscope has quit IRC16:30
garykmriedem: can you please look at https://review.openstack.org/#/c/165750/16:31
zzzeekheyongli_: that can't be quite the same thing16:31
*** josecastroleon has quit IRC16:32
heyongli_zzzeek, what's the different there? any idea?16:32
zzzeekheyongli_: ive no idea why youd be seeing an issue w nova which is still on legacyfacade, unless this is the new version that just merged enginefacade16:32
mriedemgaryk: that's a lot of +116:33
heyongli_here is a example log:http://52.27.155.124/243557/2/screen-logs/n-api.log.gz16:33
*** vladikr has quit IRC16:33
mriedemtoo many +1, -1!16:33
*** subscope has joined #openstack-nova16:33
openstackgerritDerek Higgins proposed openstack/nova: Handle a NeutronClientException 404 Error for floating ips  https://review.openstack.org/24215816:33
sfinucandanpb: mriedem: I would be grateful if you could check in on that thread pinning spec rework when possible. I'm blocked by both that and the 'bug/1501358' changes from Nikola :(16:35
sfinucanCode reviews for the rest of the day, it seems :)16:35
heyongli_zzzeek, CI testing, some patch hit that, i just don't know what exactly happened in that bug. some patch does running into _writer_maker then hit that.16:35
zzzeekheyongli_: OK but this is unreleased code right16:36
sdaguemriedem: https://review.openstack.org/#/c/243327/1 is such an unlucky change16:36
heyongli_zzzeek, that mean some oslo package too new for nava, right, let me check that.16:36
garykmriedem: the request was that for all vmware patches we get a couple of guys to look.16:37
*** suro-patz has quit IRC16:37
mriedemgaryk: i know, i was joking16:37
mriedemgaryk: i'm reviewing it now16:37
garyk:)16:37
garykthanks16:37
openstackgerritAndrea Rosa proposed openstack/nova-specs: Allow more instance operations during live migration  https://review.openstack.org/22619916:37
mriedemsdague: would be nice if e-r was commenting on changes16:37
sdagueyeh16:37
mriedemi thought clarkb got that sorted out?16:37
sdagueok, so I'm a little confused about the ebtables errors16:37
*** dprince has quit IRC16:38
sdaguebecause we get these collision failures some times16:38
sdagueand yet, we don't ever seem to have any content in ebtables16:39
*** marzif__ has quit IRC16:39
openstackgerritStephen Finucane proposed openstack/nova: Add 'hw_cpu_threads_policy' to ImageMetaProps  https://review.openstack.org/20264716:39
openstackgerritStephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=separate' scheduling  https://review.openstack.org/20265216:39
openstackgerritStephen Finucane proposed openstack/nova: Make use of 'InstanceNUMACell.cpu_policy' field  https://review.openstack.org/20265316:39
openstackgerritStephen Finucane proposed openstack/nova: trivial: Make use of 'CPU(Thread)Allocation' enum  https://review.openstack.org/20265416:39
openstackgerritStephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=isolate' scheduling  https://review.openstack.org/20265516:39
openstackgerritStephen Finucane proposed openstack/nova: Add 'cpu_policy' and 'cpu_threads_policy' fields  https://review.openstack.org/20264816:39
openstackgerritStephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=avoid' filtering  https://review.openstack.org/20264916:39
openstackgerritStephen Finucane proposed openstack/nova: trivial: Add some logs to 'numa_topology_filter'  https://review.openstack.org/20265016:39
openstackgerritStephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=require' scheduling  https://review.openstack.org/20265116:39
*** haomaiwang has quit IRC16:40
*** ndipanov has quit IRC16:41
*** vilobhmm has joined #openstack-nova16:42
*** liusheng has quit IRC16:42
*** liusheng has joined #openstack-nova16:43
*** dims has quit IRC16:44
openstackgerritStephen Finucane proposed openstack/nova: FakeDriver: adding and removing instances on live migration.  https://review.openstack.org/24361316:45
zzzeekheyongli_: can you please post your issue as a new issue on nova ?  thanks16:45
*** garyk has quit IRC16:46
mirrorboxjohnthetubaguy: hi John. could you suggest what would be a realistic plan to move toward bsd support wrt. os-vif etc?16:46
mirrorboxjohnthetubaguy: context: linux_net spec16:47
*** scheuran has quit IRC16:47
*** mjura has quit IRC16:49
*** apoorvad has joined #openstack-nova16:49
heyongli_zzzeek, sure, that's also a good idea.16:51
*** garyk has joined #openstack-nova16:51
johnthetubaguyPaulMurray: just looking at live-migrate query and cancel spec, it mentions token expiery16:52
johnthetubaguyPaulMurray: do you know the IRC nick of that spec author?16:52
*** ociuhandu has quit IRC16:52
*** lykinsbd has quit IRC16:52
johnthetubaguyPaulMurray: oh wait, I found it16:52
johnthetubaguypaul-carlton: just taking a look at your spec, if you are around https://review.openstack.org/#/c/228828/11/specs/mitaka/approved/refresh-abort-live-migration.rst,cm16:52
johnthetubaguymirrorbox: honestly, it feels like something that should be done in Neutron, looking at their ML2 plugin and making that work on BSD16:53
johnthetubaguymirrorbox: I don't really want us adding features like BSD support into nova-network, if we can help it16:54
dansmithsdague: https://review.openstack.org/#/c/242158/416:54
dansmithsdague: I think that's ready16:54
*** ociuhandu has joined #openstack-nova16:54
*** pixelbeat has quit IRC16:55
johnthetubaguydansmith: ah, that looks like what I expected to see for that fix16:55
dansmithjohnthetubaguy: yeah16:55
johnthetubaguydansmith: oh wait, doesn't the unit test only cover one of the code paths now?16:55
*** hemna has joined #openstack-nova16:55
*** jlanoux has quit IRC16:55
dansmithjohnthetubaguy: the original patch included a test for the new case it added, right/16:55
johnthetubaguydansmith: this patch seems to modify the existing test for the old code path though16:56
dansmithhmm, maybe it didn't because they didn't remove it16:56
dansmithah, right, duh16:56
dansmithheh, sdague just +Wd it16:56
dansmithjohnthetubaguy: I'll follow up and fix the tests16:57
sdagueoh, sorry, I missed that bit16:57
sdagueyeh, followup fix for the tests seems fine16:57
*** edtubill has joined #openstack-nova16:57
dansmithit's okay, let's land the fix and unblock people16:57
johnthetubaguyyeah, I am cool with that16:57
sdaguejust ping me when that's up so we can land the second patch quick as well16:57
dansmithokay16:57
*** mgoddard has quit IRC16:59
*** mgoddard_ has joined #openstack-nova16:59
*** ccarmack has quit IRC17:00
*** vilobhmm has quit IRC17:00
*** tonytan4ever has joined #openstack-nova17:01
*** suro-patz has joined #openstack-nova17:03
openstackgerritDan Smith proposed openstack/nova: Add test coverage for both types of not-found-ness in neutronclient for floating  https://review.openstack.org/24421917:03
dansmithsdague: ^17:03
*** thedodd has quit IRC17:04
sdaguedansmith: +217:04
dansmithjohnthetubaguy: ^17:04
heyongli_zzzeek, new bug filled https://bugs.launchpad.net/nova/+bug/1515326,  it does not exactly same, just a same named function in nova api. thank you.17:04
openstackLaunchpad bug 1515326 in OpenStack Compute (nova) " nova.api.openstack.extensions AttributeError: '_TransactionFactory' object has no attribute '_writer_maker'" [Undecided,New]17:04
*** thedodd has joined #openstack-nova17:04
mirrorboxjohnthetubaguy: nova-network and vif stuff share quite a lot of code, though things could be done on neutron part as well. the question is what's the plan regarding os-vif integration?17:05
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova-specs: Libvirt: Use the virtlogd deamon for logs  https://review.openstack.org/23429117:06
*** rushil has joined #openstack-nova17:06
dansmithsdague: do you think there's any way we're hitting this race in our tests sometimes, leading to shelve-related failrues? https://review.openstack.org/#/c/243724/17:07
johnthetubaguymirrorbox: unsure right now, leaving that with danpb and jaypipes to sort out, I suspect its a case of creating os-vif-lib then seeing what can be re-used from inside there17:07
dansmithsdague: we run that task by default and with the periodic staggered start, I would think we could be running it during a normal test run17:07
sdaguedansmith: it seems like it could be a thing17:08
sdaguethe shelved tests are the most flakey multinode tests right now17:08
dansmithright17:08
*** q3k1 is now known as q3k17:08
mirrorboxjohnthetubaguy: do you know if there's some specs / meetings to follow on that subject?17:08
mriedemgaryk: reviewed https://review.openstack.org/#/c/165750/17:09
*** nikhil_k has joined #openstack-nova17:09
sdaguedansmith: help me understand that one17:09
jaypipesmirrorbox: the plan is to gradually replace the plug/unplug code in nova/virt/libvirt/vif.py with the os-vif library's driver interface (which loads plug drivers via stevedore)17:09
johnthetubaguymirrorbox: the spec for os-vif is merged now, I would ask danpb or jaypipes for more details... ah there we go17:09
danpbmirrorbox: johnthetubaguy  os-vif is not intended to contain any code related to host OS networking setup17:10
*** prometheanfire has joined #openstack-nova17:10
danpbit will purely define the plugin interface & object model17:10
dansmithsdague: we shelve a guest and then race with delete or unshelve or anything else17:10
dansmithsdague: and we'll surely race with volume attach/detach once PaulMurray adds that17:10
danpbany refactoring of stuff like linux_net is being punted17:10
prometheanfirecan nova handle multiple hypervisor arches in one region? say armv8 and x86_6417:10
danpbas that really belongs in standalone libraries on pypi17:10
prometheanfireiirc, the scheduler can handle it17:10
danpbor network helpers under oslo etc17:11
garykmriedem: thanks17:11
sdaguedansmith: what would the task_state be there that's leaking through?17:11
mriedemprometheanfire: should be able to using host aggregates17:11
sdagueI guess I just need an example to get this in my head17:11
jaypipesmirrorbox: danpb just did an excellent job summarizing the strategy. :)17:11
dansmithsdague: deleting for the delete case.. PaulMurray is going to have to add some for volume attach17:11
mirrorboxdanpb: so, basically, there will be os-vif with just interface and some third party repos with the actual os-specific stuff?17:11
dansmithsdague: regardless, we should pretty much never be setting task_state on an instance without passing expected_task_state17:12
*** moshele has quit IRC17:12
*** nikhil has quit IRC17:12
sdaguedansmith: ok, sure17:12
mirrorboxI've seen a repo on github and there was some actuall implementation there. though I understand that it must be very new and stuff was just copied over from linux_net and friends17:12
prometheanfiremriedem: cool, was thinking of getting an a couple of the new tx1s to test on17:12
dansmithsdague: because that's our only way to detect a race that would override that lock17:12
*** liusheng has quit IRC17:12
dansmithsdague: you see the race with unshelve though right?17:13
dansmithsdague: you shelve the instance, then race with the task to set unshelving or shelving_offloading17:13
danpbmirrorbox: don't consider that github repo to reflect current intention - that's a PoC jay did a while ago17:13
*** liusheng has joined #openstack-nova17:13
dansmithsdague: if you do, then the instance starts getting unloaded off the compute host as you're trying to start it there17:13
danpband we've got a bunchof changes to it pending17:13
*** salv-orlando has joined #openstack-nova17:13
*** subscope has quit IRC17:13
jaypipesPaulMurray: how would rebuilding an instance from source image be "less costly" than launching a new instance from a base image?17:13
mirrorboxdanpb: ah, I see. so the question is: how to follow the os-vif related stuff to check what's going on?17:14
danpbmirrorbox: eg this  https://github.com/jaypipes/os_vif/pull/317:14
danpbmirrorbox: we're in process of setting up infrastructure (launchpad, gerrit, teams, etc)17:14
sdaguedansmith: yeh, seems reasonable17:14
danpbwe'll announce on openstack-dev when its all ready17:14
sdaguewhether or not it fixes our gate races, this seems like the old code is wrong17:14
sdague+A17:15
jaypipesmirrorbox: right. I'm pushing up the first vif-plug-ovs repository and danpb's PR #3 will remove the plugin examples that are currently in the jaypipes/os_vif lib.17:15
dansmithsdague: it's definitely wrong, yeah17:15
mirrorboxdanpb: great, looking forward to it17:15
dansmithsdague: it would just be awesome if it improves stuff visibly17:15
sdaguedansmith: agree17:15
mirrorboxjaypipes: danpb: fwiw, this os-vif looks like a good idea to me :)17:15
*** jistr is now known as jistr|off17:16
*** jistr|off has quit IRC17:16
mriedemwtf does this mean? https://review.openstack.org/#/c/242158/4/nova/network/neutronv2/api.py17:16
mriedemneutron client is currrently using NeutronClientException when there is no L3 API17:16
*** prometheanfire has left #openstack-nova17:16
sdaguemriedem: yes17:17
danpbmriedem:  it is supposed to use  NotFound, but mistakenly uses NeutronClientException17:17
mriedemso a bug in neutronclient right?17:17
sdaguewell, I think it's more that everything in neutron client is a bunch of generic transforms17:17
*** rook has joined #openstack-nova17:18
dansmithmriedem: yeah, and we've been papering over it for a while, which is why we're having it stay until neutronclient gets fixed17:18
sdagueso if neutron doesn't return a very structured error document, which it only does when the API actually talks to an agent, it falls back into this generic mapping17:18
mriedem"Because it means you have to know the topology of the services on the neutron side in order to use python-neutronclient correctly."17:18
mriedemmy eyes are bleeding17:18
mriedemso umm, let's just go back to writing our own in tree neutron rest API service like tempest has :)17:19
*** tdurakov is now known as Guest4979317:19
mriedemi tihnk someone else said they'd work on that in YVR17:19
*** tdurakov has joined #openstack-nova17:19
sdaguehttps://github.com/openstack/python-neutronclient/blob/adc53158c8d6f62882cdedf842e757a539baad5c/neutronclient/v2_0/client.py#L38-L8817:19
sdagueso, read that block of code17:20
*** danpb has quit IRC17:20
sdaguethen wash out your mouth17:20
mriedemi usually throw up out of my nose too17:20
mriedemit's a whole big thing with me17:20
sdaguehttps://github.com/openstack/python-neutronclient/blob/adc53158c8d6f62882cdedf842e757a539baad5c/neutronclient/v2_0/client.py#L52 is really the crux of it17:20
mriedemah ok17:21
mriedemwell that's nice17:21
mriedemyou might get NotFound, you might not17:21
sdagueright17:21
mriedemso handle everything17:21
mriedembtw, let me kick you in the balls quick while i'm at it17:21
sdagueso, it should give us NotFound all the time17:21
sdaguethe current nova work around at least comments to that fact, and the bug has been put on neutronclient17:21
*** pixelbeat has joined #openstack-nova17:22
mriedemyeah, the comment was just a bit confusing17:22
mriedem"neutron client is buggy and can return either exception type, so we have to handle both"17:22
mriedemanyway, meh, doesn't matter17:22
*** nic has joined #openstack-nova17:22
mriedemthanks for explaining17:22
sdagueyeh, no prob.17:22
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/24393617:22
*** diogogmt_ has joined #openstack-nova17:23
*** rook has quit IRC17:23
johnthetubaguyoh, so it has to hit here for us to get nice exceptions: https://github.com/openstack/python-neutronclient/blob/adc53158c8d6f62882cdedf842e757a539baad5c/neutronclient/v2_0/client.py#L6917:23
mriedemyeah17:24
mriedemit has a mapping17:24
johnthetubaguybummer17:24
*** sayali has quit IRC17:24
*** diogogmt has quit IRC17:24
*** diogogmt_ is now known as diogogmt17:24
mriedemhttps://github.com/openstack/python-neutronclient/blob/adc53158c8d6f62882cdedf842e757a539baad5c/neutronclient/common/exceptions.py#L10317:24
mriedemi think something else too, like they have a PortNotFound17:25
mriedemhttps://github.com/openstack/python-neutronclient/blob/adc53158c8d6f62882cdedf842e757a539baad5c/neutronclient/common/exceptions.py#L11417:25
sdaguemriedem: the mapping is only used if you get the structured error doc from neutron17:25
sdaguewhich I guess you only get if it talked to an agent17:25
sdaguenot if that agent isn't there17:25
sdagueso we hit the else in L7717:26
*** tpeoples has quit IRC17:26
*** tdp has joined #openstack-nova17:26
sdagueand don't get to use the mapping in L6717:26
*** tdp has quit IRC17:27
openstackgerritAndrew Laski proposed openstack/nova: Cells: Support external network events  https://review.openstack.org/18415517:27
*** tpeoples has joined #openstack-nova17:27
mriedemdansmith: i have my finger on +W but wanted you to see a comment first https://review.openstack.org/#/c/244219/1/nova/tests/unit/network/test_neutronv2.py17:27
*** pratikma_ has quit IRC17:28
dansmithmriedem: I consider fixed to be "and released17:28
dansmithsince that's all we use17:28
mriedemwell, the bigger point was "in neutronclient"17:28
*** suro-patz has quit IRC17:28
dansmiththe other comment in the code mentions neutronclient17:29
dansmithbut if you want it changed, I can17:29
dansmith(after the meeting I'm in)17:29
*** lpetrut has quit IRC17:29
mriedemnaw, +W, i didn't see the comment below it17:29
*** kmartin has quit IRC17:31
*** klkumar has quit IRC17:32
*** cdent has quit IRC17:32
*** subscope has joined #openstack-nova17:33
*** heyongli_ has quit IRC17:33
*** dustins has quit IRC17:34
*** dustins has joined #openstack-nova17:34
*** klkumar has joined #openstack-nova17:34
*** subscope has quit IRC17:35
*** otter768 has joined #openstack-nova17:35
*** markvoelker has quit IRC17:35
*** vilobhmm has joined #openstack-nova17:36
*** sayali has joined #openstack-nova17:36
*** rfolco has quit IRC17:37
*** whenry_ has joined #openstack-nova17:38
paul-carltonjohnthetubaguy I agree, it should be split up into several specs17:38
*** spandhe has joined #openstack-nova17:38
*** kmartin has joined #openstack-nova17:40
*** otter768 has quit IRC17:40
paul-carltonDid you see my email dlist titled [openstack-dev] [nova] live migration management approach yesterday17:40
*** ccarmack has joined #openstack-nova17:41
paul-carltonI was thinking that we could simplify this stuff by adding additional actions to the instance object17:41
*** ijw has joined #openstack-nova17:41
paul-carltonYour comment on https://review.openstack.org/#/c/229040/ seems to suggest this is something you would support?17:42
*** annegentle has joined #openstack-nova17:43
*** jdurgin1 has quit IRC17:43
*** mlavalle has quit IRC17:44
*** browne has joined #openstack-nova17:44
*** sudipto has quit IRC17:44
openstackgerritClaudiu Belu proposed openstack/nova: Removes support for Hyper-V Server 2008 R2  https://review.openstack.org/23764317:44
openstackgerritClaudiu Belu proposed openstack/nova: Hyper-V: adds os-win library  https://review.openstack.org/21210217:44
*** hwoarang has quit IRC17:45
*** ssurana has joined #openstack-nova17:45
*** claudiub has joined #openstack-nova17:45
*** hwoarang has joined #openstack-nova17:45
*** hwoarang has joined #openstack-nova17:45
*** lucasagomes is now known as lucas-dinner17:46
*** e0ne has quit IRC17:47
*** heyongli_ has joined #openstack-nova17:48
openstackgerritClaudiu Belu proposed openstack/nova: Hyper-V: adds os-win library  https://review.openstack.org/21210217:48
PaulMurrayjaypipes, something to do with networking17:49
PaulMurrayjaypipes, basically the image is not an issue because they are cached on host disk17:50
PaulMurrayjaypipes, worst case comes for creating a new instance because it may end up where there is no cached image17:50
*** pratikmallya has joined #openstack-nova17:51
PaulMurrayjaypipes, I think ocnfiguring other things is the biggest cost17:51
claudiubmriedem: hi. regarding the discussion yesterday, about the possible os_win exceptions leaking outside the HyperVDriver, what do you think of this? https://review.openstack.org/#/c/212102/23/nova/virt/hyperv/driver.py17:51
*** tjones has joined #openstack-nova17:51
*** su_zhang has joined #openstack-nova17:53
jaypipesPaulMurray: ? but a rebuild doesn't ensure that the instance will be rebuilt on a host that contains the cached image either.17:54
heyongli_zzzeek, i check the enginefacade.py in the oslo.db 3.1.0, which global requirements need it >3.0.0, so this is a legal version.  what do you mean that not released?17:54
*** achanda has joined #openstack-nova17:54
zzzeekheyongli_: new code in *nova* that uses that new oslo.db API17:55
zzzeekheyongli_: I referenced the blueprint in the exsiting issue you commented on17:55
*** heyongli_ has quit IRC17:55
PaulMurrayjaypipes, I think the image is not the bottleneck - even if it has the same problem cache miss problem (which node-pool doesn't because its images are everywhere) its no worse17:56
*** heyongli_ has joined #openstack-nova17:56
PaulMurraythe image copy generally isn't needed so other things become the bottleneck17:56
jaypipesgotcha17:57
*** lpetrut has joined #openstack-nova17:57
PaulMurrayI would have to dig up why they are more costly than expected - its problem to do with churn and freeing resources17:57
PaulMurrayand almost certainly related to neutron17:57
PaulMurrayI'll find out and let you know17:57
*** vladikr has joined #openstack-nova17:58
*** achanda has quit IRC17:58
*** tonytan4ever has quit IRC17:58
mriedemclaudiub: hmm, it's better probably18:00
*** achanda has joined #openstack-nova18:00
*** kmartin has quit IRC18:00
mriedemclaudiub: i thought about doing a decorator like that at one point in the neutronv2 api code in nova18:00
mriedemto convert NeutronClientExceptions to NovaException18:00
*** baoli has joined #openstack-nova18:01
*** derekh has quit IRC18:02
*** ijuwang has quit IRC18:03
*** ijuwang has joined #openstack-nova18:04
*** ihrachys has quit IRC18:05
*** PaulMurray is now known as ptm_away18:05
*** harlowja_ has quit IRC18:08
*** lpetrut has quit IRC18:08
*** tdurakov has quit IRC18:11
*** klkumar has quit IRC18:11
*** baoli has quit IRC18:13
*** sacharya_ has joined #openstack-nova18:13
*** baoli has joined #openstack-nova18:14
*** sacharya_ has quit IRC18:18
*** rk4n has quit IRC18:18
*** pratikma_ has joined #openstack-nova18:20
*** suro-patz has joined #openstack-nova18:21
*** sacharya has joined #openstack-nova18:22
*** jaypipes has quit IRC18:22
*** e0ne has joined #openstack-nova18:22
*** lpetrut has joined #openstack-nova18:23
*** pratikmallya has quit IRC18:23
*** ccesario has joined #openstack-nova18:24
*** baoli has quit IRC18:25
openstackgerritAndreas Jaeger proposed openstack/nova: Rearranges to create new Compute API Guide  https://review.openstack.org/23018618:26
*** baoli has joined #openstack-nova18:26
*** abitha has joined #openstack-nova18:27
*** abitha has quit IRC18:27
*** abitha has joined #openstack-nova18:28
yonglihezzzeek ok let me dig into that to see if。this should be done somehing in CI or leave it as this18:28
*** boris-42 has quit IRC18:28
*** markvoelker has joined #openstack-nova18:31
openstackgerritAndreas Jaeger proposed openstack/nova: Rearranges to create new Compute API Guide  https://review.openstack.org/23018618:32
*** rlrossit has quit IRC18:32
*** ctrath has quit IRC18:32
*** rook has joined #openstack-nova18:33
*** dims has joined #openstack-nova18:36
*** tdurakov has joined #openstack-nova18:36
*** baoli has quit IRC18:37
*** baoli has joined #openstack-nova18:38
*** eglynn has quit IRC18:38
*** liusheng has quit IRC18:40
*** liusheng has joined #openstack-nova18:40
*** harlowja has joined #openstack-nova18:42
*** jaypipes has joined #openstack-nova18:42
*** ctrath has joined #openstack-nova18:42
*** rlrossit has joined #openstack-nova18:43
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/24393618:43
*** harlowja_ has joined #openstack-nova18:44
*** harlowja has quit IRC18:44
*** fawadkhaliq has quit IRC18:45
*** meh_di has joined #openstack-nova18:47
*** ccarmack has quit IRC18:47
meh_diHi all dear developer18:47
*** _yonglihe has joined #openstack-nova18:47
meh_diI have a question about the "forced_host" in nova/compute/api.py18:48
meh_diin method "_handle_availability_zone" mention admins should  specify hosts via az using az:host:node.18:49
*** baoli has quit IRC18:49
*** baoli has joined #openstack-nova18:50
*** ccarmack has joined #openstack-nova18:51
meh_dii have confused weather admin should specifies the host to run the given instance(s) , what is the role of  scheduler18:52
mriedemsweet https://review.openstack.org/#/c/243663/ finally merged18:55
*** doug-fish has quit IRC18:56
*** doug-fish has joined #openstack-nova18:57
*** heyongli_ has quit IRC18:57
*** annegentle has quit IRC18:58
*** daemontool has joined #openstack-nova18:59
krotscheckCould I get some cores to look at https://review.openstack.org/#/c/236993/ ? It's got tests and everything :)19:00
*** Piet has quit IRC19:01
*** baoli has quit IRC19:01
*** baoli has joined #openstack-nova19:01
*** doug-fish has quit IRC19:02
krotscheckalaski, dansmith, jaypipes, mriedem, mikal, sdague, melwitt ^^ Pretty please? :)19:02
*** mriedem has quit IRC19:02
dansmithkrotscheck: you pinged every core, so this must be an emergency19:03
dansmithlet me stop what I'm doing and click on your patch19:03
dansmithkrotscheck: looks like that needs a major spec, so I -2d per our usual policy19:03
sdaguedansmith: it's covered by a cross project spec, that's typically sufficient here19:05
dansmithsdague: presumably at least a specless bp for tracking19:05
*** edtubill has quit IRC19:06
*** tonytan4ever has joined #openstack-nova19:06
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/24393619:07
krotscheckdansmith: Pinging every core == emergency? Thanks for clarifying that, I was just hoping to draw it to the attention of a core other than sdague.19:08
dansmithkrotscheck: yeah, it's pretty ridiculous to do that19:09
krotscheckdansmith: Do you have a suggestion on how in the future I can draw attention to a patch without annoying you?19:09
dansmithkrotscheck: a spec or blueprint puts it on our radar, otherwise following our procedures of getting it on the tracking etherpad would be good19:10
dansmithkrotscheck: you know, like under our api subteam heading19:10
*** mriedem has joined #openstack-nova19:10
meh_diplease someone answer my question19:11
*** markmc has quit IRC19:11
krotscheckdansmith: Gotcha, and thanks for clarifying. Unforutnately each project has its own governance structure and snowflakey goodness, and with 20+ patches of this sort I haven't been able to research how each project wants to be treated.19:12
*** ihrachys has joined #openstack-nova19:12
*** baoli has quit IRC19:13
*** baoli has joined #openstack-nova19:14
mriedemcburgess: nic: is this something you guys care about https://review.openstack.org/#/c/239798/?19:14
mriedembeing such heavy users of ceph19:14
nicHey, I've been watching what I eat...19:15
*** IanGovett has joined #openstack-nova19:16
mriedemyou're note eating that one19:16
mriedem*not19:16
mriedemi'm trying to gauge how much operator interest there is in ceph-backed volume encryption19:16
ctrathmriedem, dansmith: Regarding Alex's comment on https://review.openstack.org/#/c/203751/14/nova/db/sqlalchemy/api.py,cm .. Do you think I should pursue getting related tables via metadata, or should I keep the list as a hardcoded list?19:16
*** achanda has quit IRC19:16
*** doug-fish has joined #openstack-nova19:16
mriedemctrath: i think metadata is ideal19:17
nicIt has come up for us, we are interested in it, but more for Cinder volumes than ephemeral storage19:17
mriedemthere is a db migration that does something like that with meta19:17
ctrathok.. I'll change it and put a patch19:17
mriedemctrath: this https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/migrate_repo/versions/267_instance_uuid_non_nullable.py19:17
ctrathmriedem: thanks19:18
mriedemthat scans for tables with an instance_uuid column19:18
meh_diI have a question about the "forced_host" in nova/compute/api.py ,   in method "_handle_availability_zone" mention admins should  specify hosts via az using az:host:node. I have confused weather admin should specifies the host to run the given instance(s) , what is the role of  scheduler19:18
*** whenry_ has quit IRC19:19
*** tdurakov has quit IRC19:20
*** sacharya has quit IRC19:20
mriedemmeh_di: have you checked the code to see where forced_host is used?19:20
nicmreidem: and I, for one, am ob-board with the dogpile of folks that want the solution to this to native QEMU19:21
*** salv-orlando has quit IRC19:22
*** kmartin has joined #openstack-nova19:23
mriedemnic: can you comment as such in the spec?19:23
mriedemmeh_di: looks like forced_hosts is used to filter possible hosts out of the scheduler19:24
mriedemso if the az is like az::host1 and you have (host1, host2) to check, you would only allow host119:24
*** salv-orlando has joined #openstack-nova19:24
*** baoli has quit IRC19:25
meh_dimriedem:  method _create_instance  calls the method handle_az = self._handle_availability_zone and in the _handle _availablity_zone used the forced_host, this is my understanding.19:25
*** baoli has joined #openstack-nova19:26
mriedemthe api code puts the forced host/node into the filter properties for the scheduler19:26
mriedemyes, and that gets put into the build request that the scheduler processes19:26
mriedemhttps://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L46619:26
mriedemthis creates the filter properties dict passed to the scheduler https://github.com/openstack/nova/blob/master/nova/compute/api.py#L97819:27
*** aysyd has quit IRC19:27
*** dustins has quit IRC19:29
*** davideagnello has quit IRC19:29
*** davideagnello has joined #openstack-nova19:29
*** edtubill has joined #openstack-nova19:30
*** dustins has joined #openstack-nova19:31
*** ociuhandu has quit IRC19:32
*** josecastroleon has joined #openstack-nova19:32
*** Marga_ has joined #openstack-nova19:33
*** abitha has quit IRC19:33
*** aysyd has joined #openstack-nova19:33
*** Piet has joined #openstack-nova19:33
*** aix has quit IRC19:33
*** achanda has joined #openstack-nova19:34
*** tdurakov has joined #openstack-nova19:35
*** otter768 has joined #openstack-nova19:36
*** josecastroleon has quit IRC19:36
*** davideag_ has joined #openstack-nova19:37
*** baoli has quit IRC19:38
*** baoli has joined #openstack-nova19:38
*** baoli has quit IRC19:39
*** dane-fichter has joined #openstack-nova19:39
*** rdopiera has quit IRC19:40
*** sacharya has joined #openstack-nova19:40
*** davideagnello has quit IRC19:40
*** otter768 has quit IRC19:40
*** baoli has joined #openstack-nova19:41
*** sacharya_ has joined #openstack-nova19:41
*** achanda has quit IRC19:42
*** davideagnello has joined #openstack-nova19:42
*** dustins has quit IRC19:42
*** tdurakov has quit IRC19:42
*** dustins has joined #openstack-nova19:42
*** baoli_ has joined #openstack-nova19:44
*** sacharya has quit IRC19:44
*** davideag_ has quit IRC19:45
*** baoli has quit IRC19:47
*** aysyd has quit IRC19:48
*** angdraug has joined #openstack-nova19:49
*** meh_di has left #openstack-nova19:51
*** Marga_ has quit IRC19:51
*** salv-orlando has quit IRC19:52
*** Marga_ has joined #openstack-nova19:52
*** aysyd has joined #openstack-nova19:52
openstackgerritMichael Krotscheck proposed openstack/nova: Added CORS support to Nova  https://review.openstack.org/23699319:53
*** salv-orlando has joined #openstack-nova19:53
openstackgerritStephen Finucane proposed openstack/nova-specs: Add 'auto' case to virt-driver CPU thread pinning  https://review.openstack.org/24419819:53
*** baoli_ has quit IRC19:54
*** baoli has joined #openstack-nova19:54
*** lhcheng has joined #openstack-nova19:54
*** lhcheng has left #openstack-nova19:54
openstackgerritHans Lindgren proposed openstack/nova: Use TimeFixture from oslo_utils to override time in tests  https://review.openstack.org/23761619:55
*** jichen has joined #openstack-nova19:55
*** su_zhang has quit IRC19:55
openstackgerritStephen Finucane proposed openstack/nova-specs: Add 'auto' case to virt-driver CPU thread pinning  https://review.openstack.org/24419819:56
*** su_zhang has joined #openstack-nova19:56
*** gszasz has quit IRC19:56
*** electrocucaracha has quit IRC19:56
krotscheckdansmith: I've added a blueprint as requested, and linked the spec. Can you please remove the -2?19:56
dansmithkrotscheck: now add this to the agenda for next week's meeting, and if we can approve it as a specless bp, then I'll remove19:57
krotscheckAlright19:57
krotscheckdansmith: Link to the agenda?19:58
mriedemthis weeks meeting19:58
mriedemhttps://www.google.com/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=openstack%20nova%20meeting19:58
*** salv-orlando has quit IRC19:58
dansmithkrotscheck: http://lmgtfy.com/?q=openstack+nova+meeting+agenda19:58
krotscheckdansmith: I'm sorry, are you annoyed at me or something?19:59
dansmithkrotscheck: yep :)19:59
openstackgerritStephen Finucane proposed openstack/nova: force_config_drive: StrOpt -> BoolOpt  https://review.openstack.org/23776219:59
*** ociuhandu has joined #openstack-nova19:59
_yonglihezzzeek, seemDavanums hit same thing as i did. i not sure what exactly trigger this till now. any hint?20:00
mriedemsfinucan: i thought we already approved that20:00
krotscheckdansmith: So you're intentionally making me jump through hoops because you're annoyed at me?20:00
mriedemwhat happened20:00
sfinucandansmith: mriedem: The darn gate doesn't like me :'(20:00
mriedemsfinucan: still, just needed to be rebased or what?20:00
sfinucanI've been running recheck for a week - there was a merge conflict20:00
mriedemah20:00
dansmithkrotscheck: no?20:00
sfinucanyeah, just a rebase20:00
zzzeek_yonglihe: it has to do with improper usage of the new enginefacade API, e.g. calling upon a decorated function without the enginefacade being correctly configured20:01
dansmithkrotscheck: I'm helping you learn google because I'm annoyed at you, but this is how we get things on the roadmap20:01
zzzeek_yonglihe: otp right now20:01
*** ihrachys has quit IRC20:01
krotscheckdansmith: In that case, could you please be a little more professional about it?20:01
mriedemsfinucan: got it20:01
sfinucanthanks mriedem. dansmith: would appreciate a trivial re-approval on same, if you wouldn't mind? https://review.openstack.org/23776220:02
mriedemsfinucan: it's approved20:03
dansmithsfinucan: mriedem is too fast :)20:03
*** electrocucaracha has joined #openstack-nova20:03
sfinucandansmith: I know. I love it20:03
*** _yonglihe has quit IRC20:04
*** paul-carlton has left #openstack-nova20:05
*** e0ne has quit IRC20:06
yonglihezzzeek not sure if it could be a configration error20:06
*** su_zhang has quit IRC20:08
krotscheckjohnthetubaguy: Hey, in what section in the nova-spc-review-tracking etherpad should I put a new spec that I'd like raised at the meeting?20:08
openstackgerritHans Lindgren proposed openstack/nova: Make flavor-manage api call destroy using Flavor object  https://review.openstack.org/24429120:08
krotscheckI'm not certain if that should go at the top, under not-previously-approved.....20:08
*** alex_klimov has joined #openstack-nova20:09
mriedemkrotscheck: if it doesn't have a spec, there is a sectoin for specless bp's20:09
krotscheckmriedem: It's got a x-project spec, but not one in nova-specs.20:09
mriedemso openstack-specs?20:10
mriedemoslo-specs?20:10
krotscheckmriedem: openstack-specs.20:10
krotscheckhttps://blueprints.launchpad.net/nova/+spec/nova-cors20:10
*** mwagner has quit IRC20:11
mriedemkrotscheck: done https://etherpad.openstack.org/p/mitaka-nova-spec-review-tracking20:13
mriedemthere is a section called "Specless blueprints"20:13
mriedemand sub-sections for things that were previously approved or not20:13
mriedemthis is not previously approved so i listed i there20:14
mriedem*it20:14
krotscheckmriedem: Thanks.20:14
krotscheckI think sdague moved it under API?20:14
sdagueyeh, I just stuck it under API20:14
sdagueit's not a perfect fit, but it's kind of close20:14
krotscheckCrossed wires. My bad.20:14
*** _yonglihe has joined #openstack-nova20:14
dansmithsdague: the code belongs there,20:14
dansmiththe spec under specless blueprints, IMHO20:15
dansmithand an item on the agenda so we hit it20:15
sdaguedansmith: ok, the description on the top is - "These are specs and specless blueprints that need approving for the priority themes."20:15
mriedemkrotscheck: https://wiki.openstack.org/wiki/Meetings/Nova20:15
mriedem"Review of specless blueprints"20:15
sdaguethis is not the priority review etherpad20:15
mriedempaste it in there20:15
sdagueit's the spec review etherpad20:16
openstackgerritAndreas Jaeger proposed openstack/nova: Rearranges to create new Compute API Guide  https://review.openstack.org/23018620:16
krotscheckmriedem: Gothca20:16
krotscheckThanks20:16
dansmithsdague: ah yep20:16
sdagueunless I completely don't understand what's supposed to be in this one20:16
dansmithsdague: I dont' really know why we have this one this time, TBH20:16
krotscheckmriedem: So paste it in there, even though it needs to go into the etherpad as well?20:16
krotscheckOr...20:16
* krotscheck is a bit confused as to what needs to go where.20:17
mriedemsdague: so CORS is a high priority for nova in mitaka since it's v2.1 something?20:17
sdaguedansmith: oh, the separate etherpad, me either, I was just trying to go with the flow20:17
dansmithyeah20:17
mriedemgdi20:17
mriedemwho's on first?20:17
sdaguemriedem: well it's a cross project push that's API related20:17
*** jaypipes has quit IRC20:17
sdaguemriedem: I'm happy to stick it somewhere else as well20:17
*** rfolco has joined #openstack-nova20:17
dansmithpersonally I think it belongs in the specless group20:18
mriedemyou know, in the time we've spent talking about this we could have just approved the nova bp20:18
dansmithbecause we hit those in the meeting expecting to be done20:18
krotscheckWell, I've updated the meeting agenda.20:18
sdaguemriedem: I agree :)20:19
sdagueit's really freaking straight forward20:19
sdagueit was a cross project spec, everyone was good with it20:19
sdagueit's basically one patch20:20
krotscheckAs soon as there's some consensus on what else I need to update where I'll be happy to do that.20:20
mriedemdansmith: so i'm going to approve the bp20:20
mriedemcool?20:20
sdaguebecause all the real code is in oslo_middleware20:20
dansmithmriedem: yeah20:20
mriedemdone20:21
mriedemhttps://blueprints.launchpad.net/nova/+spec/nova-cors20:21
mriedemlet's never talk about this ever again20:21
krotscheckmriedem: Thank you. So now I wait for the meeting tomorrow?20:23
mriedemnope20:23
mriedemgo forth and write code20:23
mriedemor reply to code review comments, etc20:23
mriedemi'll remove from the meeting agenda20:23
sdaguekrotscheck: no, now just update your patch to have bp:nova-cors  in the commit message20:23
sdagueso it will track against that20:23
mriedemand dansmith can remove his -220:24
openstackgerritMichael Krotscheck proposed openstack/nova: Added CORS support to Nova  https://review.openstack.org/23699320:24
sdagueoh, it's already done, never mind20:24
krotscheckOOps20:24
*** rook has quit IRC20:24
krotscheckWell, sorry. I thought I needed ot use different commit syntax for bp:20:25
krotscheckapparently blueprint also works20:25
sdagueyeh, it does, I didn't realize that was already in there20:25
krotscheckdansmith, mriedem, sdague Thanks for all your help :)20:25
*** tonytan4ever has quit IRC20:26
*** rfolco has quit IRC20:28
*** pratikma_ has quit IRC20:28
sfinucanBefore I go deleting them all (:)), what are these tests supposed to be doing? https://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_fields.py#L32820:33
*** ctrath has quit IRC20:33
sfinucandansmith: that should probably be directed at you. The tests I linked seem to test the basic functionality of 'Enum' field type, but they don't test this field but instead every single subclass of that20:34
sfinucanseems like a waste of time to me, though I'm sure it's not20:34
dansmithsfinucan: enum is tested in the library20:35
*** markmc has joined #openstack-nova20:35
dansmithsfinucan: sfinucan they validate that we don't remove something from those enums, at least20:35
dansmithsfinucan: they were from a time when enum was not in the library, so testing the stringification ability is probably not necessary at this point20:35
sfinucandansmith: OK, so mostly legacy reasons? Would it be safe to delete them?20:36
sfinucanThe best code is no code, or so I've been told :)20:36
*** ccarmack has quit IRC20:36
dansmithsfinucan: I don't think that you should remove them, no. but you can remove the test_stringify* cases from them20:37
sfinucanOK. Should I include them for new Enum-type fields20:37
dansmithactually, if you check that the enum *values* are included in the hash check then you can remove them20:38
sfinucanlike this? https://review.openstack.org/#/c/202647/1120:38
*** rushil has quit IRC20:38
dansmithno20:38
dansmithjust a sec, I'll do it20:39
*** salv-orlando has joined #openstack-nova20:39
dansmithsfinucan: okay, yeah it covers it now, so I would propose a removal of those and add danpb to it20:40
dansmithsfinucan: those are his tests20:40
*** tjones has quit IRC20:40
sfinucandansmith: Just to confirm, remove all the tests or just the stringify checks?20:41
dansmiththe whole test for each of the enum variants20:41
* dansmith really doesn't like that we subclass those like that20:42
dansmithsfinucan: he's the proponent of doing enums that way, so he may disagree20:42
*** ccarmack has joined #openstack-nova20:43
sfinucandansmith: OK, that's fair. I'll open a bug and submit changes. It's not like deleting code is particularly difficult to do20:44
sfinucanMaybe I can ransom his enum tests for my approval of the CPU threading spec :evilcackle:20:44
sfinucanThanks, once again. Appreciate the help20:45
*** ctrath has joined #openstack-nova20:45
*** tonytan4ever has joined #openstack-nova20:46
*** apoorvad has quit IRC20:47
*** pratikmallya has joined #openstack-nova20:49
*** pratikmallya has quit IRC20:50
*** pratikmallya has joined #openstack-nova20:51
*** kmartin has quit IRC20:52
*** belmoreira has joined #openstack-nova20:53
*** su_zhang has joined #openstack-nova20:53
zzzeekyonglihe / dims : the error is that the configure() method in nova sqlalchemy/api.py has not been called.  they are using private member access in get_session() and breaking the API20:54
*** mwagner has joined #openstack-nova20:54
*** penick has joined #openstack-nova20:56
*** su_zhang has quit IRC20:57
sfinucandansmith: Wait a second - do we no longer have to update parents when we change a child object?20:58
dansmithsfinucan: that is a correct statement20:58
sfinucandansmith: niiiiiiice :)20:58
dansmithsfinucan: you're welcome :)20:59
*** su_zhang has joined #openstack-nova20:59
dimszzzeek y, added pavel kholkin and sergey nikitin as some of this started from review https://review.openstack.org/#/c/221310/20:59
*** lnxnut has joined #openstack-nova20:59
*** electrocucaracha has quit IRC20:59
zzzeekdims: yes, its basically related to that.20:59
dimszzzeek they have a lot more in the pipe - https://review.openstack.org/#/q/project:openstack/nova+topic:bp/new-oslodb-enginefacade,n,z21:00
*** rk4n has joined #openstack-nova21:00
zzzeekdims: yes, but this particular patch is where they're trying to keep LegacyEngineFacade in place, but aren't checking that configure() was called.  im not sure how its supposed to get called21:00
zzzeekdims: but, if it werent called, nova would fail to function at all21:01
dimsright21:01
*** gszasz has joined #openstack-nova21:01
_yonglihezzzeek, nice, dims, seems need more patch to fixed totally.21:01
*** rk4n has quit IRC21:03
*** rk4n has joined #openstack-nova21:04
*** annegentle has joined #openstack-nova21:06
*** _yonglihe has quit IRC21:08
*** aysyd has quit IRC21:10
*** tjones has joined #openstack-nova21:11
*** daemontool has quit IRC21:11
*** tjones has left #openstack-nova21:11
*** aysyd has joined #openstack-nova21:13
mriedemdansmith: did you want to update anything here https://review.openstack.org/#/c/242603/ ? i think alaski and i were thinking we'd try setting the bdm.uuid before we call bdm.create (in my change probably)21:14
mriedemstill rechecking that bdm logging change to get in so not a rush21:14
dansmithmriedem: are you thinking that is causing the failure at the top? I hadn't made that connection, so I was just leaving it be21:15
mriedemalaski and i talked about at least logging when _from_db_object was creating the uuid for us, since it shouldn't really happen except for older bdm's21:15
mriedemthat hadn't migrated yet21:15
mriedemin the case of create, the db create method should be setting the uuid and then _from_db_object would use that21:16
mriedemi think we were more worried about the save() case21:16
dansmithyeah, that needs fixing, I just didn't realize you thought it was the cause21:16
mriedemwell,21:16
mriedemwhen i looked at the logs from the last run, everything looked ok, so the only thing i can think is we're double creating b/c we have 2 bdms with different uuids somehow21:17
*** apoorvad has joined #openstack-nova21:17
mriedemso at the top when we query the db by uuid, it's not there (even though there is one for that instance, but a different uuid) and we create the 2nd one21:17
mriedembut until my logging patch lands and we recreate with a new set of logs, it's hard to know21:17
*** Marga_ has quit IRC21:17
mriedemso we could wait for that too21:18
*** pratikma_ has joined #openstack-nova21:18
*** sacharya_ has quit IRC21:18
*** kmartin has joined #openstack-nova21:18
dansmithwell, I should just work on that then I guess21:20
*** rk4n has quit IRC21:21
*** pratikmallya has quit IRC21:21
*** electrocucaracha has joined #openstack-nova21:22
*** salv-orlando has quit IRC21:22
*** pratikma_ has quit IRC21:23
*** sacharya has joined #openstack-nova21:23
cburgessmriedem: Reading the spec now and discussing it internally. I'll provide some feedback on it shortly.21:23
*** nic1 has joined #openstack-nova21:23
*** nic has quit IRC21:24
*** penick has quit IRC21:24
mriedemcburgess: cool, thanks21:25
*** salv-orlando has joined #openstack-nova21:25
*** mrkz has quit IRC21:26
*** rook has joined #openstack-nova21:26
openstackgerritStephen Finucane proposed openstack/nova: Add 'hw_cpu_threads_policy' to ImageMetaProps  https://review.openstack.org/20264721:27
openstackgerritStephen Finucane proposed openstack/nova: Add 'cpu_policy' and 'cpu_threads_policy' fields  https://review.openstack.org/20264821:27
openstackgerritStephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=avoid' filtering  https://review.openstack.org/20264921:27
openstackgerritStephen Finucane proposed openstack/nova: trivial: Add some logs to 'numa_topology_filter'  https://review.openstack.org/20265021:27
openstackgerritStephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=require' scheduling  https://review.openstack.org/20265121:27
*** mrkz has joined #openstack-nova21:27
openstackgerritMatt Riedemann proposed openstack/nova: cells: skip 5 networking scenario tests that use floating IPs  https://review.openstack.org/24431921:28
*** lnxnut has quit IRC21:29
*** electrocucaracha has quit IRC21:32
*** mc_nair has quit IRC21:32
*** dane-fichter has quit IRC21:34
*** otter768 has joined #openstack-nova21:37
*** rushil has joined #openstack-nova21:40
*** otter768 has quit IRC21:42
*** aysyd has quit IRC21:42
*** Marga_ has joined #openstack-nova21:43
*** rushil has quit IRC21:44
*** belmoreira has quit IRC21:46
*** pratikmallya has joined #openstack-nova21:51
*** electrocucaracha has joined #openstack-nova21:51
*** lpetrut has quit IRC21:52
*** achanda has joined #openstack-nova21:53
cburgessmriedem: Done, short version, not a fan.21:53
mriedemcburgess: great, thanks21:54
cburgessHappy to remove my -1 if others disagree with me and want to move forward.21:54
*** pratikma_ has joined #openstack-nova21:54
*** marcusvrn_ has quit IRC21:55
*** krtaylor has quit IRC21:56
*** pratikmallya has quit IRC21:57
*** jichen has quit IRC21:57
*** subscope has joined #openstack-nova21:57
*** thangp has quit IRC21:59
*** smatzek has quit IRC22:00
*** thedodd has quit IRC22:02
*** thedodd has joined #openstack-nova22:02
*** subscope has quit IRC22:02
ansiwenalaski isn't in today, right?22:03
mriedemansiwen: right22:04
ansiwenmriedem: you know about tomorrow?22:04
alaskiI'm around, I've just been in meetings almost literally all afternoon22:05
*** achanda has quit IRC22:05
ansiwenalaski: oh, I see, hi22:05
mriedemalaski: are you officially off paternity leave now?22:05
alaskimriedem: yep.22:06
*** annegentle has quit IRC22:06
*** penick has joined #openstack-nova22:07
*** alex_klimov has quit IRC22:08
alaskiansiwen: hi22:09
*** krtaylor has joined #openstack-nova22:09
ansiwenalaski: I'm new with openstack and as first task I fixed a bug you reported. If you have the chance to have a look: https://review.openstack.org/#/c/24361622:09
alaskiansiwen: heh, I just reviewed that22:10
ansiwenalaski: oh, cool22:10
alaskimy only real concern is the test that appears to be named wrong22:10
ansiwenalaski: no, it's named correctly, since the fake instace has a image_ref by default... but I was also thinking about explicitly setting it nevertheless, because else exactly this misunderstanding will happen22:12
*** salv-orlando has quit IRC22:13
alaskiansiwen: yeah, that would be good.  I didn't expect that it would be set by default22:13
ansiwenme neither, but removing it from the default and fixing all tests that rely on it might be a PITA22:14
*** stackdump has joined #openstack-nova22:14
alaskivery likely22:14
ansiwenand sure about the test permutations? I always learned: no redundant tests, keep them othogonal22:15
ansiwenI can put all permutations in, but usually it's considered bad practice22:15
alaskitesting all permutations is useful if someone changes the method later.  what are corner cases now may not be then.22:16
alaskibut you have the two main tests I'm concerned with so I'm not going to -1 for other tests22:17
openstackgerritMatt Riedemann proposed openstack/nova: cells: skip 5 networking scenario tests that use floating IPs  https://review.openstack.org/24431922:17
*** pratikmallya has joined #openstack-nova22:17
ansiwenalaski: I don't have a strong opinion there and I have to touch it again anyways, so I do as you prefer22:18
*** rlrossit has left #openstack-nova22:19
*** pratikma_ has quit IRC22:19
*** pradk has quit IRC22:20
openstackgerritVilobh Meshram proposed openstack/nova: Aggregate Extra Specs Filter should return if extra_specs is empty  https://review.openstack.org/24101622:20
*** edmondsw has quit IRC22:23
*** doug-fish has quit IRC22:27
*** doug-fish has joined #openstack-nova22:28
openstackgerritMichael Krotscheck proposed openstack/nova: Added CORS support to Nova  https://review.openstack.org/23699322:29
*** wverdugo500 has quit IRC22:30
*** w_verdugo has quit IRC22:30
*** doug-fis_ has joined #openstack-nova22:30
*** doug-fish has quit IRC22:32
*** achanda has joined #openstack-nova22:33
*** doug-fis_ has quit IRC22:34
*** sacharya has quit IRC22:39
*** sacharya has joined #openstack-nova22:40
*** achanda has quit IRC22:42
*** doug-fish has joined #openstack-nova22:43
dansmithmriedem: alaski: so for save, I think we should just error if there is no uuid, but not generate there22:43
dansmithif we pulled from the DB, we should have one (even if generated). If we don't something is weird22:43
mriedemdansmith: the case was a get on a bdm before the db migration to add the uuid22:44
mriedemi think22:44
mriedemso you added the generator to save() b/c it's non-nullable in the bdm object22:45
dansmithmriedem: right, but we generate it in _from_db_obj()22:45
mriedemso you want to check and fail in save() itself?22:45
mriedemi'm ok with that22:45
dansmithyes22:45
mriedemi think you're saying what alaski and i are agreeing with22:45
mriedemwe're all on the same page22:45
*** thorst has quit IRC22:46
*** edtubill has quit IRC22:46
dansmithwell, the comments said generate in save and generate in create22:46
dansmiththat's not what I'm saying22:46
*** whenry_ has joined #openstack-nova22:47
mriedemi don't want to look it up but what you said above is what i think we want22:47
*** doug-fish has quit IRC22:47
dansmithyep22:47
*** penick has quit IRC22:47
mriedemalright, have to head out22:48
*** dustins has quit IRC22:48
*** mriedem has quit IRC22:48
*** pratikmallya has quit IRC22:49
*** sacharya_ has joined #openstack-nova22:50
*** eharney has quit IRC22:51
*** burgerk has quit IRC22:51
*** sacharya has quit IRC22:53
*** tongli has quit IRC22:58
*** signed8bit is now known as signed8bit_ZZZzz23:01
*** stackdump has quit IRC23:02
openstackgerritDan Smith proposed openstack/nova: cells: create block device mappings in API cell  https://review.openstack.org/24264923:02
openstackgerritDan Smith proposed openstack/nova: Make BlockDeviceMapping object support uuid  https://review.openstack.org/24260323:02
openstackgerritDan Smith proposed openstack/nova: Add uuid column to BlockDeviceMapping  https://review.openstack.org/24260223:02
*** mdrabe has quit IRC23:02
*** sneti has quit IRC23:03
*** annegentle has joined #openstack-nova23:04
*** ctrath has quit IRC23:04
*** Piet has quit IRC23:06
*** baoli has quit IRC23:07
*** baoli has joined #openstack-nova23:08
*** stackdump has joined #openstack-nova23:09
*** sacharya_ has quit IRC23:09
*** ctrath has joined #openstack-nova23:10
*** amotoki has quit IRC23:10
*** signed8bit_ZZZzz is now known as signed8bit23:12
*** mc_nair has joined #openstack-nova23:12
*** ZZelle has quit IRC23:13
*** ZZelle has joined #openstack-nova23:17
*** vilobhmm has quit IRC23:17
*** vilobhmm has joined #openstack-nova23:17
*** gszasz has quit IRC23:18
*** ZZelle has quit IRC23:21
*** Piet has joined #openstack-nova23:25
*** w_verdugo has joined #openstack-nova23:26
*** ndipanov has joined #openstack-nova23:28
*** ijuwang has quit IRC23:31
*** boris-42 has joined #openstack-nova23:33
*** emagana has quit IRC23:34
*** otter768 has joined #openstack-nova23:37
*** ctrath has quit IRC23:39
*** su_zhang has quit IRC23:41
*** otter768 has quit IRC23:42
*** janiceonchn has joined #openstack-nova23:42
*** mrkz has quit IRC23:42
*** annegentle has quit IRC23:43
*** Marga_ has quit IRC23:43
*** Marga_ has joined #openstack-nova23:43
*** kmartin has quit IRC23:46
*** kmartin has joined #openstack-nova23:46
*** doug-fish has joined #openstack-nova23:47
*** thorst has joined #openstack-nova23:49
*** doug-fish has quit IRC23:50
*** signed8bit is now known as signed8bit_ZZZzz23:53
*** thorst_ has joined #openstack-nova23:54
*** thorst_ has quit IRC23:55
*** thorst has quit IRC23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!