*** stevemar_ has joined #openstack-nova | 00:00 | |
*** haomaiwang has quit IRC | 00:01 | |
*** haomaiwang has joined #openstack-nova | 00:01 | |
*** zhangjn has joined #openstack-nova | 00:02 | |
*** jerrygb has quit IRC | 00:18 | |
*** sacharya has quit IRC | 00:20 | |
*** ircuser-1 has quit IRC | 00:23 | |
*** mriedem has quit IRC | 00:30 | |
*** EinstCrazy has quit IRC | 00:30 | |
*** otter768 has joined #openstack-nova | 00:36 | |
*** ndipanov has joined #openstack-nova | 00:36 | |
*** apoorvad has joined #openstack-nova | 00:37 | |
*** stevemar_ has quit IRC | 00:42 | |
*** rk4n has quit IRC | 00:42 | |
*** stevemar_ has joined #openstack-nova | 00:44 | |
*** stevemar_ has quit IRC | 00:49 | |
*** tjones has quit IRC | 00:51 | |
*** vilobhmm has joined #openstack-nova | 00:53 | |
*** otter768_ has joined #openstack-nova | 00:54 | |
*** otter768 has quit IRC | 00:55 | |
openstackgerrit | Alex Xu proposed openstack/nova-specs: Make block_migration and host flags in live-migration API https://review.openstack.org/245543 | 00:57 |
---|---|---|
*** mwagner has quit IRC | 01:00 | |
*** agireud has quit IRC | 01:00 | |
*** haomaiwang has quit IRC | 01:01 | |
*** haomaiwang has joined #openstack-nova | 01:01 | |
*** ed__ has quit IRC | 01:01 | |
*** otter768_ has quit IRC | 01:02 | |
*** liusheng has joined #openstack-nova | 01:02 | |
*** otter768 has joined #openstack-nova | 01:03 | |
*** pm90_ has quit IRC | 01:03 | |
*** agireud has joined #openstack-nova | 01:03 | |
*** jyuso1 has joined #openstack-nova | 01:04 | |
*** markvoelker has joined #openstack-nova | 01:06 | |
*** otter768 has quit IRC | 01:07 | |
*** agireud has quit IRC | 01:08 | |
*** EinstCrazy has joined #openstack-nova | 01:08 | |
*** markvoelker has quit IRC | 01:10 | |
*** agireud has joined #openstack-nova | 01:10 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Split-network-plane-for-live-migration https://review.openstack.org/245005 | 01:22 |
*** pixelbeat has quit IRC | 01:24 | |
*** sneti has joined #openstack-nova | 01:25 | |
*** pm90_ has joined #openstack-nova | 01:27 | |
*** haomaiwang has quit IRC | 01:28 | |
*** bapalm has quit IRC | 01:29 | |
*** kgalanov has quit IRC | 01:32 | |
*** serverascode has quit IRC | 01:32 | |
*** auggy has quit IRC | 01:33 | |
*** sballe has quit IRC | 01:33 | |
*** dougwig has quit IRC | 01:33 | |
*** erlon has quit IRC | 01:33 | |
*** davidlenwell has quit IRC | 01:33 | |
*** Nakato has quit IRC | 01:33 | |
*** gus has quit IRC | 01:33 | |
*** darrenc has quit IRC | 01:33 | |
*** mgagne has quit IRC | 01:33 | |
*** nikhil has quit IRC | 01:33 | |
*** darrenc has joined #openstack-nova | 01:33 | |
*** jhesketh has quit IRC | 01:33 | |
*** wendar has quit IRC | 01:33 | |
*** nikhil|afk has joined #openstack-nova | 01:33 | |
*** toan has quit IRC | 01:33 | |
*** wendar_ has joined #openstack-nova | 01:33 | |
*** auggy has joined #openstack-nova | 01:33 | |
*** kgalanov has joined #openstack-nova | 01:33 | |
*** swamireddy has quit IRC | 01:34 | |
*** tr3buchet has quit IRC | 01:34 | |
*** jamielennox has quit IRC | 01:34 | |
*** davidlenwell has joined #openstack-nova | 01:34 | |
*** adam_g has quit IRC | 01:35 | |
*** jroll has quit IRC | 01:35 | |
*** d34dh0r53 has quit IRC | 01:35 | |
*** Nakato has joined #openstack-nova | 01:35 | |
*** thorst has joined #openstack-nova | 01:35 | |
*** toan has joined #openstack-nova | 01:35 | |
*** thorst has quit IRC | 01:36 | |
*** zhenguo has quit IRC | 01:36 | |
*** sballe has joined #openstack-nova | 01:36 | |
*** erlon has joined #openstack-nova | 01:37 | |
*** gus has joined #openstack-nova | 01:37 | |
*** serverascode has joined #openstack-nova | 01:37 | |
*** jhesketh has joined #openstack-nova | 01:37 | |
*** tr3buchet has joined #openstack-nova | 01:37 | |
*** jroll has joined #openstack-nova | 01:38 | |
*** adam_g has joined #openstack-nova | 01:38 | |
*** d34dh0r53 has joined #openstack-nova | 01:38 | |
*** mgagne has joined #openstack-nova | 01:38 | |
*** adam_g has quit IRC | 01:38 | |
*** adam_g has joined #openstack-nova | 01:38 | |
*** mgagne is now known as Guest91043 | 01:38 | |
*** jerrygb has joined #openstack-nova | 01:39 | |
*** dougwig has joined #openstack-nova | 01:40 | |
*** jamielennox has joined #openstack-nova | 01:41 | |
*** pm90_ has quit IRC | 01:41 | |
*** EinstCrazy has quit IRC | 01:43 | |
*** zhenguo has joined #openstack-nova | 01:43 | |
*** swamireddy has joined #openstack-nova | 01:44 | |
*** EinstCrazy has joined #openstack-nova | 01:45 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add expected_task_state for instance.save() used by block_device_mapping https://review.openstack.org/245038 | 01:55 |
*** EinstCrazy has quit IRC | 01:55 | |
*** bapalm has joined #openstack-nova | 01:56 | |
*** EinstCrazy has joined #openstack-nova | 01:56 | |
*** Yanyanhu has joined #openstack-nova | 01:59 | |
*** coreywright has quit IRC | 02:02 | |
*** jerrygb has quit IRC | 02:04 | |
*** bapalm has quit IRC | 02:04 | |
*** dims has joined #openstack-nova | 02:06 | |
*** coreywright has joined #openstack-nova | 02:08 | |
openstackgerrit | Zhenyu Zheng proposed openstack/python-novaclient: Make 'nova-list' correctly decode unicode strings https://review.openstack.org/244940 | 02:15 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add project-id and user-id when list server-groups https://review.openstack.org/209018 | 02:18 |
openstackgerrit | Zhenyu Zheng proposed openstack/python-novaclient: Make 'nova-list' correctly decode unicode strings https://review.openstack.org/244940 | 02:19 |
*** Kevin_Zheng has joined #openstack-nova | 02:21 | |
*** dave-mccowan has joined #openstack-nova | 02:21 | |
*** jerrygb has joined #openstack-nova | 02:26 | |
*** oomichi has joined #openstack-nova | 02:33 | |
*** takashin has joined #openstack-nova | 02:35 | |
*** sripriya has joined #openstack-nova | 02:36 | |
*** apoorvad has quit IRC | 02:36 | |
*** thorst has joined #openstack-nova | 02:36 | |
*** thorst has quit IRC | 02:41 | |
*** haomaiwang has joined #openstack-nova | 02:45 | |
*** haomaiwang has quit IRC | 02:48 | |
*** 20WACHN4K has joined #openstack-nova | 02:49 | |
openstackgerrit | Wen Zhi Yu proposed openstack/nova: Move disk allocation ratio to ResourceTracker https://review.openstack.org/245619 | 02:51 |
*** agireud has quit IRC | 02:55 | |
*** _cerberus_ has left #openstack-nova | 02:55 | |
*** agireud has joined #openstack-nova | 02:57 | |
*** RuiChen has joined #openstack-nova | 02:58 | |
*** 20WACHN4K has quit IRC | 03:01 | |
*** unicell has joined #openstack-nova | 03:01 | |
*** haomaiwang has joined #openstack-nova | 03:01 | |
*** otter768 has joined #openstack-nova | 03:03 | |
*** venkat_p has joined #openstack-nova | 03:04 | |
*** takashin has left #openstack-nova | 03:04 | |
*** markvoelker has joined #openstack-nova | 03:07 | |
*** otter768 has quit IRC | 03:07 | |
*** sripriya_ has joined #openstack-nova | 03:10 | |
*** markvoelker has quit IRC | 03:11 | |
*** sripriya has quit IRC | 03:13 | |
*** sripriya has joined #openstack-nova | 03:15 | |
*** sripriya_ has quit IRC | 03:18 | |
*** armax has joined #openstack-nova | 03:21 | |
*** sripriya has quit IRC | 03:22 | |
*** vilobhmm has quit IRC | 03:23 | |
*** gcb has joined #openstack-nova | 03:25 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add expected_task_state for instance.save() used by block_device_mapping https://review.openstack.org/245038 | 03:36 |
*** apoorvad has joined #openstack-nova | 03:36 | |
*** otter768 has joined #openstack-nova | 03:37 | |
*** venkat_p has left #openstack-nova | 03:40 | |
*** armax has quit IRC | 03:40 | |
*** ircuser-1 has joined #openstack-nova | 03:40 | |
*** apoorvad has quit IRC | 03:41 | |
*** jogo has quit IRC | 03:41 | |
*** vilobhmm has joined #openstack-nova | 03:44 | |
openstackgerrit | lyanchih proposed openstack/nova: Listing volumes does not provide a link to next element https://review.openstack.org/237999 | 03:45 |
*** dims has quit IRC | 03:47 | |
*** dims has joined #openstack-nova | 03:48 | |
*** vilobhmm has quit IRC | 03:49 | |
*** vilobhmm has joined #openstack-nova | 03:49 | |
openstackgerrit | lyanchih proposed openstack/nova: libvirt - Add log if libguestfs can't read host kernel https://review.openstack.org/237547 | 03:49 |
*** vilobhmm has quit IRC | 03:50 | |
*** haomaiwang has quit IRC | 03:51 | |
*** haomaiwang has joined #openstack-nova | 03:51 | |
openstackgerrit | Zhenyu Zheng proposed openstack/python-novaclient: Make 'nova-list' correctly decode unicode strings https://review.openstack.org/244940 | 03:52 |
*** gongysh has joined #openstack-nova | 03:55 | |
*** haomaiwang has quit IRC | 04:01 | |
*** haomaiwang has joined #openstack-nova | 04:01 | |
*** dims has quit IRC | 04:08 | |
*** agireud has quit IRC | 04:10 | |
*** links has joined #openstack-nova | 04:11 | |
*** sacharya has joined #openstack-nova | 04:15 | |
*** agireud has joined #openstack-nova | 04:21 | |
*** klkumar has joined #openstack-nova | 04:25 | |
*** prashup has quit IRC | 04:30 | |
*** fawadkhaliq has joined #openstack-nova | 04:33 | |
*** Sree has joined #openstack-nova | 04:33 | |
tonyb | Anyone want to +2 this https://review.openstack.org/245621 ? | 04:33 |
*** otter768 has quit IRC | 04:35 | |
*** sneti has quit IRC | 04:52 | |
*** sneti has joined #openstack-nova | 04:53 | |
*** pradipta has joined #openstack-nova | 04:59 | |
*** haomaiwang has quit IRC | 05:01 | |
*** haomaiwang has joined #openstack-nova | 05:01 | |
*** sneti has quit IRC | 05:02 | |
openstackgerrit | Vipin Balachandran proposed openstack/nova: VMware: Raise DiskNotFound for missing disk device https://review.openstack.org/243734 | 05:03 |
*** amotoki has joined #openstack-nova | 05:06 | |
*** sileht has quit IRC | 05:12 | |
*** fawadkhaliq has quit IRC | 05:21 | |
*** fawadkhaliq has joined #openstack-nova | 05:22 | |
*** klkumar has quit IRC | 05:24 | |
*** klkumar has joined #openstack-nova | 05:28 | |
*** sacharya has quit IRC | 05:28 | |
*** amotoki has quit IRC | 05:31 | |
*** mdrabe has joined #openstack-nova | 05:33 | |
*** jogo has joined #openstack-nova | 05:37 | |
*** mdrabe has quit IRC | 05:38 | |
*** mwagner has joined #openstack-nova | 05:39 | |
*** dave-mccowan has quit IRC | 05:39 | |
*** angdraug has joined #openstack-nova | 05:48 | |
*** zhangjn has quit IRC | 05:52 | |
*** zhangjn has joined #openstack-nova | 05:53 | |
*** zhangjn has quit IRC | 05:53 | |
*** zhangjn has joined #openstack-nova | 05:54 | |
*** haomaiwang has quit IRC | 06:01 | |
*** haomaiwang has joined #openstack-nova | 06:01 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata https://review.openstack.org/242727 | 06:03 |
*** Marga_ has joined #openstack-nova | 06:04 | |
*** irenab has quit IRC | 06:04 | |
openstackgerrit | Zhenyu Zheng proposed openstack/python-novaclient: Make 'nova-list' correctly decode unicode strings https://review.openstack.org/244940 | 06:09 |
*** yonglihe has quit IRC | 06:10 | |
*** stevemar_ has joined #openstack-nova | 06:11 | |
*** lpetrut has joined #openstack-nova | 06:12 | |
*** stevemar_ has quit IRC | 06:14 | |
*** rcernin has joined #openstack-nova | 06:16 | |
*** lpetrut has quit IRC | 06:17 | |
openstackgerrit | octopuszhang proposed openstack/nova: Use JSON format instead of json format https://review.openstack.org/220875 | 06:20 |
*** shakamunyi has joined #openstack-nova | 06:21 | |
*** markmc has quit IRC | 06:23 | |
*** markmc has joined #openstack-nova | 06:23 | |
*** jamielennox is now known as jamielennox|away | 06:25 | |
*** dhellmann has quit IRC | 06:28 | |
*** frickler has quit IRC | 06:28 | |
*** frickler has joined #openstack-nova | 06:28 | |
*** dhellmann has joined #openstack-nova | 06:28 | |
*** sacharya has joined #openstack-nova | 06:29 | |
*** lpetrut has joined #openstack-nova | 06:29 | |
*** dhellmann has quit IRC | 06:34 | |
*** sacharya has quit IRC | 06:34 | |
*** dhellmann has joined #openstack-nova | 06:34 | |
*** irenab has joined #openstack-nova | 06:35 | |
*** otter768 has joined #openstack-nova | 06:35 | |
*** vilobhmm has joined #openstack-nova | 06:38 | |
*** shakamunyi has quit IRC | 06:39 | |
*** otter768 has quit IRC | 06:40 | |
*** vilobhmm has quit IRC | 06:40 | |
*** hightall has joined #openstack-nova | 06:43 | |
*** moshele has joined #openstack-nova | 06:45 | |
*** moshele has quit IRC | 06:51 | |
*** vilobhmm has joined #openstack-nova | 06:53 | |
*** shakamunyi has joined #openstack-nova | 06:54 | |
*** haomaiwang has quit IRC | 07:01 | |
*** haomaiwang has joined #openstack-nova | 07:01 | |
*** jerrygb has quit IRC | 07:03 | |
*** suro-patz has joined #openstack-nova | 07:04 | |
*** garyk has joined #openstack-nova | 07:05 | |
*** apoorvad has joined #openstack-nova | 07:07 | |
*** mjura has joined #openstack-nova | 07:07 | |
*** markvoelker has joined #openstack-nova | 07:08 | |
*** nikhil has joined #openstack-nova | 07:08 | |
*** Nakato_ has joined #openstack-nova | 07:09 | |
*** moshele has joined #openstack-nova | 07:09 | |
*** davidlenwell_ has joined #openstack-nova | 07:10 | |
*** sileht has joined #openstack-nova | 07:11 | |
*** anish__ has joined #openstack-nova | 07:11 | |
*** SamYaple_ has joined #openstack-nova | 07:11 | |
*** slagle_ has joined #openstack-nova | 07:11 | |
*** jhesketh_ has joined #openstack-nova | 07:12 | |
*** markvoelker has quit IRC | 07:13 | |
*** anthonyper_ has joined #openstack-nova | 07:14 | |
*** kgalanov_ has joined #openstack-nova | 07:14 | |
*** dgonzalez_ has joined #openstack-nova | 07:15 | |
*** nikhil|afk has quit IRC | 07:15 | |
*** davidlenwell has quit IRC | 07:15 | |
*** Nakato has quit IRC | 07:15 | |
*** jhesketh has quit IRC | 07:15 | |
*** d34dh0r53 has quit IRC | 07:15 | |
*** anish has quit IRC | 07:15 | |
*** slagle has quit IRC | 07:15 | |
*** zhenguo has quit IRC | 07:15 | |
*** auggy has quit IRC | 07:15 | |
*** kgalanov has quit IRC | 07:15 | |
*** junjie has quit IRC | 07:15 | |
*** dgonzalez has quit IRC | 07:15 | |
*** scottda has quit IRC | 07:15 | |
*** rook- has quit IRC | 07:15 | |
*** anthonyper has quit IRC | 07:15 | |
*** tristanC has quit IRC | 07:15 | |
*** SamYaple has quit IRC | 07:15 | |
*** dgonzalez_ is now known as dgonzalez | 07:15 | |
*** anthonyper_ is now known as anthonyper | 07:15 | |
*** kgalanov_ is now known as kgalanov | 07:16 | |
*** d34dh0r53 has joined #openstack-nova | 07:16 | |
*** auggy has joined #openstack-nova | 07:16 | |
*** sahid has joined #openstack-nova | 07:16 | |
*** junjie has joined #openstack-nova | 07:17 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add expected_task_state for instance.save() used by block_device_mapping https://review.openstack.org/245038 | 07:17 |
*** lpetrut has quit IRC | 07:19 | |
*** zhenguo has joined #openstack-nova | 07:19 | |
*** scottda has joined #openstack-nova | 07:19 | |
snikitin | Hi guys! Can we backport patches with performance fixes into stable branches? Or we backport just bug fixes? | 07:19 |
*** tristanC has joined #openstack-nova | 07:20 | |
*** Nakato_ is now known as Nakato | 07:20 | |
*** boris-42 has joined #openstack-nova | 07:23 | |
*** lpetrut has joined #openstack-nova | 07:24 | |
garyk | ndipanov: please can you look at https://review.openstack.org/240706 i needed to rebase | 07:28 |
garyk | another no brainer https://review.openstack.org/245520 | 07:28 |
garyk | ps they are not vmware related :) | 07:28 |
garyk | snikitin: which patch? | 07:29 |
snikitin | garyk: this https://review.openstack.org/#/c/229964/ | 07:29 |
*** suro-patz has quit IRC | 07:30 | |
*** rmart04 has joined #openstack-nova | 07:32 | |
*** nkrinner has joined #openstack-nova | 07:33 | |
*** moshele has quit IRC | 07:34 | |
*** scheuran has joined #openstack-nova | 07:34 | |
*** ZZelle has joined #openstack-nova | 07:34 | |
*** lpetrut has quit IRC | 07:35 | |
openstackgerrit | Zhenyu Zheng proposed openstack/python-novaclient: Make 'nova-list' correctly decode unicode strings https://review.openstack.org/244940 | 07:36 |
*** ZZelle has quit IRC | 07:36 | |
*** alexschm has joined #openstack-nova | 07:37 | |
*** rmart04 has quit IRC | 07:37 | |
*** korzen has joined #openstack-nova | 07:43 | |
*** fawadkhaliq has quit IRC | 07:44 | |
*** belmoreira has joined #openstack-nova | 07:44 | |
garyk | snikitin: i think that it certainly has value. i suggest asking johnthetubaguy or ndipanov as they were the cores that approved it. Any performance improvement like this that does not have any API changes is certainly work a backport in my opinion | 07:45 |
*** anish__ is now known as anish | 07:45 | |
*** liverpooler has joined #openstack-nova | 07:46 | |
snikitin | garyk: thank you garyk. I'll ask them | 07:46 |
*** moshele has joined #openstack-nova | 07:49 | |
*** tojuvone has quit IRC | 07:49 | |
*** schwicke has joined #openstack-nova | 07:49 | |
*** abhishekk has joined #openstack-nova | 07:51 | |
ndipanov | snikitin, well it's really up to the stable maint team | 07:51 |
ndipanov | which I am not on | 07:51 |
ndipanov | I would not find it too unreasonable to do in this case | 07:52 |
*** vilobhmm has quit IRC | 07:52 | |
*** rdopiera has joined #openstack-nova | 07:53 | |
ndipanov | garyk, is stable maint btw :) | 07:55 |
ndipanov | mriedem is another person who would have a say in this | 07:55 |
garyk | ndipanov: i am in favor of backporting this. i was just trying to get additional inputs from those who approved it :) | 07:56 |
garyk | snikitin: please backport then | 07:56 |
snikitin | ndipanov, garyk: thanks, will backport, | 07:57 |
ndipanov | especially since it may actually lead to a bugfix | 07:58 |
*** haomaiwang has quit IRC | 08:01 | |
*** haomaiwang has joined #openstack-nova | 08:01 | |
*** e0ne has joined #openstack-nova | 08:04 | |
*** lsmola has joined #openstack-nova | 08:07 | |
*** josecastroleon has joined #openstack-nova | 08:08 | |
*** rmart04 has joined #openstack-nova | 08:09 | |
*** nkrinner has quit IRC | 08:10 | |
*** hightall has quit IRC | 08:11 | |
*** ccard_ has joined #openstack-nova | 08:13 | |
*** nkrinner has joined #openstack-nova | 08:15 | |
*** Jeffrey4l has joined #openstack-nova | 08:16 | |
*** jichen has joined #openstack-nova | 08:17 | |
*** apoorvad has quit IRC | 08:18 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add project-id and user-id when list server-groups https://review.openstack.org/209018 | 08:21 |
*** lpetrut has joined #openstack-nova | 08:24 | |
*** jichen has quit IRC | 08:27 | |
*** ildikov has joined #openstack-nova | 08:28 | |
*** ankit_ag has joined #openstack-nova | 08:32 | |
*** tobe has joined #openstack-nova | 08:34 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Fix project_id in API sample docs https://review.openstack.org/245661 | 08:35 |
oomichi | alex_xu: hihao! | 08:36 |
alex_xu | oomichi: hi :) | 08:36 |
*** otter768 has joined #openstack-nova | 08:36 | |
alex_xu | oomichi: I guess you want to say nihao :) | 08:37 |
oomichi | alex_xu: oops, yes. your are right ;-) | 08:37 |
oomichi | alex_xu: and congress for your nova-core! | 08:37 |
alex_xu | oomichi: thanks :) | 08:37 |
oomichi | alex_xu: :) | 08:38 |
oomichi | alex_xu: btw, I have a little stupid patch: https://review.openstack.org/#/c/245661/ | 08:38 |
oomichi | alex_xu: I'd like to get your opinion about that | 08:39 |
oomichi | alex_xu: API sample docs contain invalid format values like this | 08:39 |
oomichi | alex_xu: because these values are fixed on tpl files on sample/functional tests. | 08:40 |
alex_xu | oomichi: it is nice fix, the api sample is close the real scene will be better | 08:40 |
oomichi | alex_xu: yeah, completely agree with you. | 08:40 |
*** thorst has joined #openstack-nova | 08:40 | |
oomichi | alex_xu: and that is one reason why I tried to use tempest.log for API sample docs. | 08:40 |
alex_xu | oomichi: as I remember the project_id is just str, no format strict, right? | 08:41 |
*** ndipanov has quit IRC | 08:41 | |
alex_xu | oomichi: emm...one more good point for get api sample docs from tempest | 08:41 |
*** otter768 has quit IRC | 08:41 | |
oomichi | alex_xu: it is fine to make tempest thing out of scope now ;-) | 08:42 |
oomichi | alex_xu: project_id is genarated in Keystone with uuid format | 08:42 |
alex_xu | oomichi: if the api sample generated from tempest side, how to integrate with swagger spec which generated from nova side | 08:42 |
alex_xu | oomichi: heh, ok :) | 08:42 |
oomichi | alex_xu: yeah, that is difficult point. | 08:42 |
*** sudipto has joined #openstack-nova | 08:42 | |
oomichi | alex_xu: yeah, make it out of scope now | 08:42 |
oomichi | :-) | 08:42 |
alex_xu | oomichi: I'm working new patchset for swagger poc, hope I can work out tomorrow | 08:43 |
alex_xu | oomichi: it based the way use swagger in the nova code. | 08:43 |
oomichi | alex_xu: super cool !! | 08:44 |
oomichi | alex_xu: I much prefer to see that | 08:44 |
alex_xu | oomichi: yeah | 08:44 |
*** jlanoux has joined #openstack-nova | 08:44 | |
oomichi | alex_xu: going back to project_id | 08:45 |
alex_xu | oomichi: yea | 08:45 |
oomichi | alex_xu: https://review.openstack.org/#/c/209018 also is adding project_id to sample files | 08:45 |
*** thorst has quit IRC | 08:45 | |
oomichi | alex_xu: and I'd like to make them uuid format for fitting actula environments | 08:46 |
bauzas | good morning Nova | 08:46 |
oomichi | bauzas: hi :) | 08:46 |
alex_xu | oomichi: yea, agree | 08:46 |
bauzas | oomichi: hi :) | 08:46 |
* alex_xu have clock for the time of go home, it is bauzas say good morning | 08:47 | |
oomichi | alex_xu: thanks :-) | 08:47 |
* oomichi oomichi also needs to go back to home when bauzas says "good morning" ;-) | 08:48 | |
bauzas | :) | 08:49 |
alex_xu | oomichi: np | 08:50 |
*** exploreshaifali has joined #openstack-nova | 08:50 | |
oomichi | bauzas: congress for your core also :) | 08:52 |
bauzas | oomichi: ty :) | 08:53 |
*** paul-carlton has joined #openstack-nova | 08:54 | |
*** korzen has quit IRC | 08:56 | |
*** tdurakov has joined #openstack-nova | 08:57 | |
gcb | alex_xu, bauzas, congratulations! | 08:58 |
bauzas | ty | 08:58 |
alex_xu | gcb: thanks :) | 08:58 |
*** paul-carlton has quit IRC | 08:58 | |
*** fawadkhaliq has joined #openstack-nova | 08:59 | |
gcb | alex_xu, bauzas , I'm working on https://review.openstack.org/#/c/242416/. Fix nova common issues in unit test. | 09:00 |
gcb | can you help look at it and give any comments ? | 09:00 |
*** haomaiwang has quit IRC | 09:01 | |
*** haomaiwang has joined #openstack-nova | 09:01 | |
openstackgerrit | Marian Horban proposed openstack/nova: Double detach volume causes server fault https://review.openstack.org/244683 | 09:02 |
*** jerrygb has joined #openstack-nova | 09:04 | |
alex_xu | gcb: yea, put in my review list, will take a look at later | 09:04 |
gcb | alex_xu: thanks | 09:05 |
alex_xu | gcb: np | 09:05 |
*** jerrygb has quit IRC | 09:08 | |
*** markvoelker has joined #openstack-nova | 09:09 | |
openstackgerrit | Zhenyu Zheng proposed openstack/python-novaclient: Make 'nova-list' correctly decode unicode strings https://review.openstack.org/244940 | 09:10 |
*** romainh has joined #openstack-nova | 09:10 | |
*** lpetrut has quit IRC | 09:10 | |
*** yassine has joined #openstack-nova | 09:13 | |
*** markvoelker has quit IRC | 09:13 | |
*** rmart04 has quit IRC | 09:16 | |
*** lpetrut has joined #openstack-nova | 09:17 | |
tangchen__ | ndipanov: Hi, Nikola. I'm looking at the following spec and patch from you. | 09:18 |
tangchen__ | ndipanov: https://review.openstack.org/#/c/136077/ | 09:18 |
tangchen__ | ndipanov: https://review.openstack.org/#/c/141799/ | 09:18 |
tangchen__ | ndipanov: Fujitsu needs this functionality badly. So may I continue this work based on your patch and spec ? | 09:19 |
*** lpetrut has quit IRC | 09:19 | |
*** e0ne has quit IRC | 09:21 | |
*** e0ne has joined #openstack-nova | 09:21 | |
*** xek_ is now known as xek | 09:22 | |
openstackgerrit | huan proposed openstack/nova: XenAPI:Resolve Nova/Neutron race condition https://review.openstack.org/241127 | 09:24 |
*** flip214 has joined #openstack-nova | 09:24 | |
flip214 | Can somebody help me with this messages from nova-conductor, please? http://paste.lisp.org/display/159614 | 09:25 |
flip214 | to me it looks as if the rabbitmq connection broke while using it... that's with a devstack setup. | 09:25 |
*** rk4n has joined #openstack-nova | 09:27 | |
*** marzif_ has joined #openstack-nova | 09:30 | |
*** lpetrut has joined #openstack-nova | 09:30 | |
*** fawadk has joined #openstack-nova | 09:31 | |
*** MarcF has joined #openstack-nova | 09:34 | |
*** fawadkhaliq has quit IRC | 09:34 | |
*** andrearo1 is now known as andrearosa | 09:37 | |
*** marzif_ has quit IRC | 09:39 | |
*** jistr has joined #openstack-nova | 09:40 | |
*** Guest45766 is now known as BobBall | 09:40 | |
*** ociuhandu has quit IRC | 09:40 | |
*** marzif_ has joined #openstack-nova | 09:40 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Changed filter_by() to filter() during filtering instances in db API https://review.openstack.org/245677 | 09:41 |
johnthetubaguy | flip214: folks on #openstack are probably better at rabbit questions, it does look like rabbit died, but I am not sure | 09:41 |
*** rubasov has joined #openstack-nova | 09:41 | |
flip214 | johnthetubaguy: thanks! | 09:42 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Add service status notification https://review.openstack.org/245678 | 09:44 |
*** frickler has quit IRC | 09:44 | |
*** tobe has quit IRC | 09:44 | |
*** danpb has joined #openstack-nova | 09:44 | |
*** tobe has joined #openstack-nova | 09:45 | |
abhishekk | johnthetubaguy: hi, you around? | 09:47 |
*** Guest4687 is now known as PaulMurray | 09:47 | |
*** frickler has joined #openstack-nova | 09:48 | |
johnthetubaguy | abhishekk: I am | 09:49 |
abhishekk | johnthetubaguy: I have replied to your comments on https://review.openstack.org/135387 | 09:50 |
abhishekk | could you please take a look when you get time? | 09:50 |
*** gcb has quit IRC | 09:51 | |
*** subscope has joined #openstack-nova | 09:52 | |
johnthetubaguy | abhishekk: yes, will do | 09:53 |
abhishekk | johnthetubaguy: thank you | 09:53 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Fix cinder volume stuck in swap_volume https://review.openstack.org/207385 | 09:54 |
*** alexschm has quit IRC | 09:57 | |
*** zhenguo has quit IRC | 09:58 | |
*** alexschm has joined #openstack-nova | 09:59 | |
openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: libvirt: make live_migration_uri flag dependent on virt_type https://review.openstack.org/175780 | 09:59 |
*** tdurakov has quit IRC | 09:59 | |
*** zhangjn has quit IRC | 09:59 | |
*** tdurakov has joined #openstack-nova | 10:00 | |
*** schwicke has quit IRC | 10:00 | |
*** haomaiwang has quit IRC | 10:01 | |
*** haomaiwang has joined #openstack-nova | 10:01 | |
*** lpetrut has quit IRC | 10:01 | |
*** pradipta has quit IRC | 10:02 | |
*** claudiub has joined #openstack-nova | 10:04 | |
*** alexschm has quit IRC | 10:05 | |
*** Yanyanhu has quit IRC | 10:07 | |
*** cdent has joined #openstack-nova | 10:07 | |
*** cdent has left #openstack-nova | 10:08 | |
*** rotbeard has joined #openstack-nova | 10:08 | |
*** lpetrut has joined #openstack-nova | 10:10 | |
*** deepakcs has joined #openstack-nova | 10:13 | |
*** fawadk has quit IRC | 10:14 | |
*** ajo has joined #openstack-nova | 10:14 | |
ajo | bauzas: ping | 10:15 |
bauzas | ajo: heya | 10:15 |
ajo | johnthetubaguy : bauzas , about the latest talks on getting the scheduler pluggable, (looking from the neutron point of view & the QoS use cases) | 10:15 |
ajo | would you have some time for pointing me into relevant code to get my head wrapped around it? :) | 10:16 |
*** openstackgerrit has quit IRC | 10:16 | |
bauzas | ajo: you mean the resource providers BP ? | 10:16 |
ajo | bauzas: I'm totally unaware of nova-scheduler BPs (yet) :) | 10:17 |
bauzas | ajo: sec, there was an etherpad at the last summit | 10:17 |
*** openstackgerrit has joined #openstack-nova | 10:17 | |
ajo | bauzas: but we're looking into ways to push neutron data to the scheduler, and add plug points into it, so neutron could influence scheduler decissions too, based on resources | 10:17 |
johnthetubaguy | ajo: there is a spec up for review | 10:17 |
ajo | (like availability of certain networks on certain compute nodes, or the availability of bandwidth, etc..) | 10:17 |
ajo | oh, nice | 10:18 |
johnthetubaguy | ajo: https://review.openstack.org/#/c/225546/ | 10:18 |
johnthetubaguy | it focuses on shared storage | 10:18 |
ajo | bauzas , johnthetubaguy , I'd like to collaborate on helping define an api that works also for other projects | 10:18 |
ajo | ah, nice | 10:18 |
ajo | so other projects are already looking into this too | 10:18 |
*** alexschm has joined #openstack-nova | 10:18 | |
johnthetubaguy | the idea of a pool of resources consumed by instances | 10:18 |
johnthetubaguy | right now everything comes from the compute node | 10:19 |
ajo | johnthetubaguy , aha | 10:19 |
johnthetubaguy | jaypipe's spec unhooks that link | 10:19 |
ajo | johnthetubaguy , I will start by reading the spec, thanks a lot | 10:19 |
johnthetubaguy | now, IP addresses or cinder volumes, are all nice groups of shared capacity you might need, that could be co-located with hosts | 10:20 |
johnthetubaguy | but yeah, shared storage is the basis of the split here | 10:20 |
johnthetubaguy | consider various pools of shared storage attached to differenet groups of hosts | 10:20 |
johnthetubaguy | basically the same model we need for external projects | 10:20 |
bauzas | johnthetubaguy: since I have pretty low memory in my brain (like 32KB), I don't exactly remember the details, but I remember ndipanov talking about some neutron bits at the end of the SR-IOV session | 10:20 |
ajo | johnthetubaguy , I was also considering the option to provide discoverable "scheduler bits" (not sure what's the proper name here) which could be published by other projects, and consumed by the scheduler in realtime | 10:21 |
ajo | bauzas ^ | 10:21 |
johnthetubaguy | ajo: not sure I get the context there, what the problem you want to solve? | 10:21 |
ajo | with the proper api, so, those would influence the decission, based on the information previously pushed by -whatever- | 10:21 |
bauzas | ajo: yeah, the paradigm is that projects push stats to the scheduler, not the scheduler getting those | 10:21 |
johnthetubaguy | that should be in that spec of jays | 10:22 |
ajo | johnthetubaguy : for example, bandwidth availability, it's a consumable resource on compute nodes, | 10:22 |
johnthetubaguy | well its acutally missing right now | 10:22 |
bauzas | ajo: but I feel we discussed that in Tokyo, but my brain is playing with me | 10:22 |
johnthetubaguy | ah, so that one is a bit different | 10:22 |
ajo | bauzas , I think probably, with Ihar and NIkola Dipanov, I wasn't there this year, sorry guys ':) | 10:22 |
johnthetubaguy | ajo: I would certainly read jay's spec, and that should help | 10:22 |
johnthetubaguy | I think it capture a lot of the summit discussion | 10:23 |
ajo | yeah, let's start there, thanks bauzas , johnthetubaguy | 10:23 |
* bauzas needs more caffeine | 10:23 | |
*** alexschm has quit IRC | 10:24 | |
*** fawadkhaliq has joined #openstack-nova | 10:25 | |
*** ociuhandu has joined #openstack-nova | 10:26 | |
*** pixelbeat has joined #openstack-nova | 10:30 | |
*** alex_klimov has joined #openstack-nova | 10:30 | |
*** ociuhandu has quit IRC | 10:31 | |
bauzas | snap, does anyone noticed that the cells job is failing for stable/liberty ? | 10:31 |
* bauzas looks | 10:31 | |
bauzas | tonyb: still here? | 10:31 |
bauzas | tonyb: heh, just saw my own time, I guess nope | 10:32 |
bauzas | tempest.scenario.test_server_multinode.TestServerMultinode.test_schedule_to_all_nodes seems pretty new | 10:33 |
*** ociuhandu has joined #openstack-nova | 10:34 | |
*** tobe has quit IRC | 10:36 | |
*** otter768 has joined #openstack-nova | 10:37 | |
*** prashup has joined #openstack-nova | 10:38 | |
prashup | hi guys | 10:38 |
prashup | i m facing a strange issue. while booting a VM . the image getting downloaded is of zero size. | 10:38 |
prashup | the code checks the checksum and it is fine. but the image size is zero in /var/lib/nova/instances/_base | 10:39 |
prashup | any pointers how to fix it ? | 10:39 |
bauzas | johnthetubaguy: do you have any idea on if it's the master tempest who runs the stable branches ? | 10:39 |
*** schwicke has joined #openstack-nova | 10:40 | |
bauzas | johnthetubaguy: can't find neither a liberty branch or tag in https://github.com/openstack/tempest/tree/master/tempest | 10:40 |
*** jhesketh_ has quit IRC | 10:40 | |
bauzas | sdague: take your time but when you'll have time, I'd love to get your insights re: tempest.scenario.test_server_multinode.TestServerMultinode.test_schedule_to_all_nodes that seems to fail liberty stable job | 10:41 |
*** fawadkhaliq has quit IRC | 10:41 | |
johnthetubaguy | bauzas: tempest is branchless now | 10:42 |
johnthetubaguy | bauzas: you should run the same against both | 10:42 |
*** otter768 has quit IRC | 10:42 | |
*** lpetrut has quit IRC | 10:42 | |
*** fawadkhaliq has joined #openstack-nova | 10:42 | |
bauzas | johnthetubaguy: okay, so that means that if a new test is merged, then it's run against the stable branches too ? | 10:42 |
johnthetubaguy | prashup: #openstack can help with usage issues, it sounds a bit like you have a bad image in glance, that is of zero size? | 10:42 |
*** tdurakov has quit IRC | 10:42 | |
bauzas | I'm pretty rookie for stable CI issues | 10:43 |
*** tdurakov has joined #openstack-nova | 10:43 | |
*** tdurakov has quit IRC | 10:43 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: config options: add hacking check for help text length https://review.openstack.org/242078 | 10:43 |
johnthetubaguy | bauzas: yeas, I think so... although generally I think they try and skip tests that know they can't run, like with a version miss match, or protected by an off by default feature flag, etc | 10:43 |
bauzas | johnthetubaguy: yup that makes sense | 10:44 |
johnthetubaguy | bauzas: I am no expert though, I am afraid, its mostly theoretical knowledge that I have around that stuff | 10:44 |
bauzas | so, I'm trying to see if *all* cell job runs for stable/liberty are failing or not | 10:44 |
bauzas | due to that new test | 10:44 |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: config options: add hacking check for help text length https://review.openstack.org/242078 | 10:45 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Deprecate nova-manage service subcommand https://review.openstack.org/240858 | 10:45 |
bauzas | meh, logstash is only logging master runs... | 10:46 |
*** jhesketh has joined #openstack-nova | 10:47 | |
prashup | johnthetubaguy images are good. i have ensured it from /var/lib/glance/images | 10:48 |
*** exploreshaifali has quit IRC | 10:49 | |
bauzas | sdague: FWIW https://bugs.launchpad.net/nova/+bug/1516566 | 10:50 |
openstack | Launchpad bug 1516566 in OpenStack Compute (nova) "TestServerMultinode.test_schedule_to_all_nodes fails in gate-tempest-dsvm-cells for Liberty" [Undecided,New] | 10:50 |
*** subscope has quit IRC | 10:51 | |
ajo | bauzas , johnthetubaguy , I read the spec, what I was thinking of is tangential to Jay's spec. In the neutron case we are not looking for host aggregate resource pools (yet), but only compute-node resources. But we could need to push new resource types, and values for compute nodes from an "extension" to the nova-compute set in place by neutron (for example), or let the neutron-*-agent do it, so the scheduler would have that available. | 10:52 |
ajo | And them, plug something into the scheduler, to consider that information at scheduling time. | 10:52 |
ajo | and then. | 10:52 |
*** exploreshaifali has joined #openstack-nova | 10:53 | |
*** subscope has joined #openstack-nova | 10:53 | |
ajo | Simple example, compute node 1 has access to external networks A & B, and pushes that to the scheduler database, compute node has access to B & C, does the same... | 10:53 |
ajo | VM is requested with port A (connected to net C)... | 10:54 |
ajo | the scheduler may need to send the VM only to compute node 2 | 10:54 |
ajo | (sorry I ommited the node 2 part) | 10:54 |
ajo | ---- | 10:54 |
bauzas | sdague: bingo http://logs.openstack.org/20/243320/3/check/gate-tempest-dsvm-cells/5952387/logs/screen-n-sch.txt.gz#_2015-11-16_04_41_58_981 | 10:57 |
bauzas | ajo: sorry, I'm just in the middle of investigating a CI problem that seems to fail 100% of the jobs | 10:58 |
ajo | another case: neutron-*-agent (or neutron plugin into nova-compute) gather and declare the amount of bandwidth it's available for every network on each compute node., (we could think of updating such information from the computes as resources go away by new ports, but that would be racy...), we should probably have another plug point (somewhere) to redouce the count of those resources. | 10:58 |
ajo | bauzas : ack | 10:58 |
ajo | bauzas : consider trying oslogmerger (https://github.com/mangelajo/oslogmerger / pip install oslogmerger) if you need to correlate several logs from the run | 10:59 |
ajo | bauzas , you just give it a list of URLs to the logs, and an alias to each url, and will dump via STDOUT a correlated/coalesced log | 10:59 |
bauzas | ajo: well, I'm pretty used to follow using req-id but I could take a look :) | 10:59 |
*** lpetrut has joined #openstack-nova | 10:59 | |
ajo | oslogmerger url1:NCOMP url2:QAGT url3:... | 11:00 |
ajo | bauzas, I developed it lately out of similar pain trying to trace req-ids across several nodes :D | 11:00 |
*** haomaiwang has quit IRC | 11:01 | |
ajo | it's yet a poc, needs polishing, but it's being helpful so far :) | 11:01 |
*** alexschm has joined #openstack-nova | 11:01 | |
*** haomaiwang has joined #openstack-nova | 11:01 | |
*** rfolco has joined #openstack-nova | 11:02 | |
bauzas | oh snap | 11:03 |
bauzas | https://github.com/openstack/nova/commit/876679c08f05eaa2a90b1f053b65b78a0af433df | 11:03 |
bauzas | should be backported to liberty ^ | 11:04 |
johnthetubaguy | ajo: OK, so certain networks only available on certain hosts, that similar to the cinder case, makes sense | 11:06 |
johnthetubaguy | ajo: the reality is, we are reworking the scheduler so we can add these sorts of things in a way we can maintain | 11:07 |
sdague | bauzas: what's up? | 11:07 |
bauzas | sdague: okay, I found the issue and I saw you updating the cells RC | 11:08 |
bauzas | sdague: the stable liberty branch is failing because of https://github.com/openstack/nova/commit/876679c08f05eaa2a90b1f053b65b78a0af433df | 11:08 |
sdague | yeh, I noticed it on friday night after I was done for the day | 11:08 |
bauzas | well, it's failing because it's missing | 11:08 |
bauzas | so, I'm backporting it atm | 11:08 |
sdague | sounds great, I'll fast approve | 11:08 |
johnthetubaguy | ajo: the plan in my head was more around mapping host aggregates, to locality concepts in other services, I have someone at rackspace (randall) writing this up into a spec | 11:09 |
*** markvoelker has joined #openstack-nova | 11:10 | |
ajo | johnthetubaguy , you mean using host aggregates to handle single-node resources too? | 11:10 |
ajo | (for externally provided resources) | 11:10 |
johnthetubaguy | ajo: no, only for the association pieice | 11:10 |
ajo | I need to re-read jay spec, may be that can be generalized to also track compute-node only resources in a modular way (if that makes any sense, probably not..) | 11:11 |
johnthetubaguy | ajo: the bandwidth on the node, did come up at some point, for that one, I think you need to read the resource object spec: http://specs.openstack.org/openstack/nova-specs/specs/mitaka/approved/resource-objects.html | 11:12 |
ajo | thanks | 11:12 |
bauzas | sdague: https://review.openstack.org/245712 | 11:12 |
*** stevemar_ has joined #openstack-nova | 11:12 | |
*** dims has joined #openstack-nova | 11:12 | |
ajo | johnthetubaguy : thanks for guiding me through all the related stuff | 11:12 |
bauzas | ajo: (so, back to your problem) | 11:13 |
*** romainh has quit IRC | 11:14 | |
ajo | bauzas++ that was quick | 11:14 |
*** markvoelker has quit IRC | 11:14 | |
bauzas | ajo: if you see jaypipes's spec, you'll see that I left a few comments for decoupling the aggregate bits aiming to solve the 'multi-hosts' issue from the other bits aiming to solve the heterogenous resources issue | 11:14 |
ajo | bauzas: aha, that'd make sense | 11:14 |
bauzas | ajo: the aggregate proposal from jay is just a way to have one concept for grouping resources in case you need to group them | 11:15 |
bauzas | ajo: so jay proposed to reuse the concept of aggregates, which I'm okay with thaty | 11:15 |
*** stevemar_ has quit IRC | 11:15 | |
*** korzen has joined #openstack-nova | 11:16 | |
bauzas | ajo: but IMHO, if you don't need to group resource providers, then you can directly have a specific resource provider that doesn't need an agg | 11:16 |
bauzas | the agg is just the resource provider in cause it's a shared resource | 11:16 |
bauzas | case* | 11:16 |
ajo | bauzas: in our most complex case (tracking the available bandwidth on compute nodes), | 11:17 |
bauzas | ajo: well, that one is a bit different | 11:18 |
ajo | we would need to push information about the avail bandwidth (per network), and then, provide some way to make that consumed. | 11:18 |
ajo | bauzas : and it's neutron responsibility to know how much bw an specific port consumes | 11:18 |
bauzas | ajo: do you want to give b/w information from the VIF standpoint, or from the port ? | 11:18 |
ajo | bauzas, we have that now decoupled from the port, by a reference to "QoS policy id" | 11:19 |
bauzas | I see | 11:19 |
bauzas | but what's the relationship ? | 11:19 |
bauzas | one qos id per router or port ? | 11:19 |
ajo | qos policies are like "flavors" | 11:20 |
bauzas | I guess you can set a policy per port, right? | 11:20 |
ajo | 1 policy : N ports | 11:20 |
bauzas | yup, that I understand it's a policy | 11:20 |
ajo | I guess, to make things fluid, | 11:20 |
bauzas | so each port is attached to 1 or more policies? | 11:21 |
ajo | bauzas : 1 max | 11:21 |
bauzas | and you can only get one port per VIF right? | 11:21 |
*** links has quit IRC | 11:21 | |
ajo | bauzas, I guess (not sure what happens with containers in VMs) | 11:22 |
* bauzas played with Neutron in a very far far galaxy long time ago | 11:22 | |
ajo | :-) | 11:22 |
ajo | bauzas , how does nova get the information from the port in neutron? via API?, VIF inspection? | 11:23 |
bauzas | ajo: but my question is : what kind of information do you want to provide ? is that just the policy type, or a more discrete value, like the % of b/w ? | 11:23 |
ajo | bauzas , I don't care as long as we can make scheduling based decisions and accounting of b/w per network type | 11:24 |
ajo | bauzas , we could provide the policy type, and the policies | 11:24 |
bauzas | ajo: you have a good question that I can't answer yet | 11:24 |
johnthetubaguy | ajo: we keep the port information in our network-info-cache thing, basically first filled up when you create the instance and get info back from neutron on the port binding, etc, etc | 11:24 |
ajo | aha | 11:25 |
bauzas | ajo: for the moment, it's the virt driver which reports the resources to the Resource Tracker that writes in DB | 11:25 |
johnthetubaguy | ajo: it would be great to get your problem written up in a nova spec, just the problem spec bit | 11:25 |
ajo | johnthetubaguy , that sounds like a good idea, | 11:25 |
bauzas | johnthetubaguy: I remember some discussion on that, but since I'm pretty not network-seasoned, I missed some crucial bits | 11:25 |
*** gongysh has quit IRC | 11:26 | |
ajo | bauzas : ack, | 11:26 |
ajo | bauzas , may be we could somehow use the vif plugging mechanism to exchange extra information on ports, like the bw they consume on nets | 11:26 |
ajo | but, that could change in runtime, | 11:27 |
ajo | for example if somebody modifies the policy | 11:27 |
johnthetubaguy | the problem for me is tracking neutron resources in our resource tracker, that feels odd to me, but maybe its like SR-IOV, its a resource nova tracks and hands out to neutron on port attach/detach | 11:27 |
ajo | the port limit is rised up, ... the extra / or lower bw consumption needs to be accounted. | 11:27 |
bauzas | johnthetubaguy: that was basically the stuff that was discussed during that SR-IOV session | 11:27 |
*** gcb has joined #openstack-nova | 11:27 | |
johnthetubaguy | ajo: we already have aync updates for some things, via a call back system | 11:27 |
johnthetubaguy | ajo: but honestly, that sounds like it should be a resize operations, as you might need to move the instance | 11:28 |
*** exploreshaifali has quit IRC | 11:28 | |
ajo | yes, the complexity is making the scheduler aware of resources provided by others in the nodes (or as aggregates -jay spec-) | 11:28 |
bauzas | right, I'm concerned by the conceptual issue of modifying a policy at runtime | 11:28 |
bauzas | like | 11:28 |
ajo | johnthetubaguy : or block the operation at api level: "host -X cannot satisfy the new policy..." | 11:29 |
ajo | bauzas ^ | 11:29 |
bauzas | imagine that your port is enforcing a very low quality constraint like it is at the moment | 11:29 |
ajo | that should be the right approach, at least for a start | 11:29 |
*** sudipto has quit IRC | 11:29 | |
ajo | bauzas , yes, I understand, you either move the instance away, or block the request because it cannot be satisfied | 11:29 |
bauzas | what would happen if your operator suddently decides to modify it to a very strict policy? | 11:30 |
ajo | then it's up to the admin, or tenant to move the instances before trying to modify the policy again | 11:30 |
bauzas | that's impacting other ports, right ? | 11:30 |
johnthetubaguy | ajo: that would be hard to do if its a neutron API call to change a Nova controlled resource, that sounds wrong, almost feels like it lives in the Nova flavor | 11:30 |
johnthetubaguy | ajo: you can't leave that stuff up to the admin or tenant, IMHO | 11:30 |
bauzas | right, you could pass that information thru a flavor | 11:31 |
johnthetubaguy | ajo: like when a user wants more memory, we go find them it, we don't hope that overcommit will do the trick, and the admin has made room for it | 11:31 |
johnthetubaguy | bauzas: I am thinking keep it like SR-IOV, roughly | 11:31 |
ajo | johnthetubaguy : I wasn't proposing overcommit, but , blocking the request to "ask for more resources" on the neutron side | 11:31 |
*** vladikr has quit IRC | 11:32 | |
johnthetubaguy | ajo: now what I would love is to have neutron port flavors, and maybe map those to instance flavors (to some extent) | 11:32 |
ajo | johnthetubaguy , bauzas : I agree, if we can automate migrating VMs to accomodate that, that's ideal, but I think that may need to be a long term goal, not a first implementation | 11:32 |
bauzas | johnthetubaguy: I feel the same | 11:32 |
ajo | johnthetubaguy : that's remembering of my initial proposal :) | 11:32 |
ajo | our neutron port flavors are the policies :) | 11:33 |
ajo | johnthetubaguy : that's more ore less what I was proposing on the QoS meeting 2-3 months ago, irenab too | 11:33 |
ajo | but not sure if we're talking about the same thing exactly | 11:33 |
johnthetubaguy | I think we need neutron port flavors regardless | 11:34 |
johnthetubaguy | yeah, time for a spec to try iron things out I think | 11:34 |
ajo | johnthetubaguy , what do you mean by neutron port flavors exactly? | 11:34 |
ajo | can you give me an example | 11:34 |
ajo | johnthetubaguy , yeah, let's stop after this one and move to a spec | 11:34 |
johnthetubaguy | gold, silver, bronze port flavors | 11:34 |
ajo | johnthetubaguy : defined in neutron? | 11:34 |
* bauzas running out for lunch | 11:35 | |
ajo | johnthetubaguy : ok, we already have that, that are qos-policies = port-flavors as you define them | 11:35 |
irenab | this is exposed via nova api? | 11:35 |
*** ferest has joined #openstack-nova | 11:35 | |
johnthetubaguy | gold is SR-IOV, silver = 10GB (shared), bronze = 1GB (shared), all defined in neutron | 11:35 |
ajo | ok, we could have an extra abstraction | 11:35 |
ajo | providing a vnic type + qos policy | 11:35 |
ajo | and that would be the flavor | 11:36 |
johnthetubaguy | you create a port of "gold" type, on network, A, and pass that into nova | 11:36 |
ajo | aha, ok, but then nova is on the sames issues of accounting resources (bw) | 11:36 |
johnthetubaguy | the nova flavor might then say, it needs gold ports, or support silver and bronze ports, defaults to silver, for example | 11:36 |
ajo | aha | 11:36 |
irenab | johnthetubaguy: if you require port to be crearted in advance , then no need for the additional abstraction | 11:37 |
irenab | you can create port and set everything you need, then pass to nova. | 11:37 |
ajo | the world is upside down today :D | 11:37 |
johnthetubaguy | Nova wants to either be passed a set of port uuids, or not passed anything | 11:37 |
irenab | no networks uuids? | 11:37 |
*** josecastroleon has quit IRC | 11:38 | |
johnthetubaguy | thats there for backwards compatibility, but we wish that wasn't possible | 11:38 |
ajo | but still, ok, the port flavor (vnic type + qos policy) abstraction is nice | 11:38 |
ajo | then | 11:38 |
johnthetubaguy | port flavor I am thinking | 11:38 |
ajo | the scheduler may need to be aware of the qos policy details and the resources to do the right scheduling | 11:38 |
johnthetubaguy | the user that wants SR-IOV just asks for that flavor, they don't need to do any PCI binding mapping themselves | 11:38 |
johnthetubaguy | yes, there are lots of things still needed | 11:39 |
*** josecastroleon has joined #openstack-nova | 11:39 | |
johnthetubaguy | but with that layer of abstraction, it all becomes a bit easier to reason about I feel | 11:39 |
sdague | anyone else want to take a quick sanity check on gibi_'s https://review.openstack.org/#/c/240858 it has a bunch of +2s on friday, but we were holding it up for the release note | 11:39 |
*** ferest has quit IRC | 11:39 | |
irenab | johnthetubaguy: Can you please clarify the user actions? I am not sure I see why currently it is not possible. If user wants SR-IOV port, he just sets vnic_type=direct | 11:40 |
irenab | for the port he creates and then passes it to nova | 11:40 |
openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: SameHostFilter should fail if host does not have instances https://review.openstack.org/229030 | 11:40 |
johnthetubaguy | irenab: how does the user choose between two different types of SRIOV | 11:40 |
johnthetubaguy | sdague: ah, sweet, taking a look | 11:40 |
ajo | johnthetubaguy , I think it's two types of vnic types | 11:41 |
johnthetubaguy | ajo: agreed, in the new model | 11:41 |
irenab | what do you mean by different types of SR-IOV? | 11:41 |
ajo | irenab , pci pass through, or tap/interface (I'm not sure of the naming) I guess? | 11:42 |
BobBall | Help :( I'm struggling with some python 2/3 unicode fun. In py2 I must pass a string, in py3 I must pass unicode, but it seems that sometimes in real scenarios, on py2, the string is actually already unicode (perhaps because I'm formatting with some of the substitutions already being unicode?). How can I convert to str iff python2 and leave as unicode (which it will already be) iff py3? This is for the string argument to uuid.uuid5() | 11:42 |
irenab | operator makes the binding of the NIC to provider net | 11:42 |
irenab | ajo: indeed, there are 2 different vnic_types | 11:42 |
johnthetubaguy | irenab: I am thinking two different vendors in the same cloud, or a macvtap vs non-macvtap, possible different base line speeds, etc, could be lots of variations | 11:43 |
irenab | I am just trying to see what we gain by additional abstraction and how user (Tenant) gets fsimple way to consume it | 11:44 |
johnthetubaguy | the user shouldn't be exposed to all the implementation details, when they just don't need to understand those | 11:44 |
irenab | Different vendors may be supported via Host aggregates | 11:44 |
irenab | I have dejavu of 2 years ago :-) | 11:44 |
johnthetubaguy | likewise, I am saying the same thing I did two years ago, I wish we had port flavors to stop the user needing to know implementation details | 11:45 |
tangchen__ | johnthetubaguy, alex_xu, bauzas: hi, may I ask a question ? Please refer to: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L1889 | 11:46 |
tangchen__ | johnthetubaguy, alex_xu, bauzas: I don't understand what the "regular expression matching" means here. | 11:47 |
tangchen__ | johnthetubaguy, alex_xu, bauzas: I think this what will be executed when we run nova list --sort key:asc | 11:47 |
*** xek has quit IRC | 11:47 | |
tangchen__ | johnthetubaguy, alex_xu, bauzas: I can understand the exact matching. But what does the regular expression matching mean ? | 11:48 |
*** Sree has quit IRC | 11:49 | |
tangchen__ | johnthetubaguy, alex_xu, bauzas: Does that mean when I run "nova list --sort hostname:asc", it will also sort by "host" ? | 11:49 |
*** Sree has joined #openstack-nova | 11:49 | |
irenab | johnthetubaguy: so for different vendors it seems more like Host Aggregates than neutron port level to me. | 11:49 |
ajo | johnthetubaguy , I agree port flavors would be a good thing in general, I have a better understanding of what you mean now, although it's a different issue from what I was trying to fix, it's related, and it's worth spending time on it | 11:50 |
johnthetubaguy | tangchen__: have you read this bit of the code: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L2047 | 11:50 |
*** tdurakov has joined #openstack-nova | 11:50 | |
ajo | johnthetubaguy : I will look into it. | 11:50 |
johnthetubaguy | ajo: I did catch up with armax on port flavors, its worth catching up with him about those | 11:51 |
*** ZZelle has joined #openstack-nova | 11:51 | |
*** Sree has quit IRC | 11:54 | |
alex_xu | tangchen__: yea, you can take a look at the code johnthetubaguy point out. I think it's only about filter | 11:54 |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: Finish post live migration even when port binding fails https://review.openstack.org/235994 | 11:55 |
tangchen__ | johnthetubaguy: I didn't go deeper into that function. I think it is something related to sql. | 11:55 |
*** links has joined #openstack-nova | 11:55 | |
tangchen__ | alex_xu: I'm not quite familiar with sql, could you please give me a little example ? | 11:56 |
tangchen__ | alex_xu: If it takes too much time, then I will read the code myself. :) | 11:57 |
tangchen__ | alex_xu: If I run something like this: nova list --sort vm_*:desc | 11:58 |
alex_xu | tangchen__: I guess you may need learn something about http://docs.sqlalchemy.org/en/rel_1_0/ | 11:58 |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: Finish post live migration even when exception occurs https://review.openstack.org/235994 | 11:58 |
tangchen__ | alex_xu: it will be error. | 11:58 |
*** links has quit IRC | 11:59 | |
tangchen__ | johnthetubaguy, alex_xu: OK, I'll read it. Thanks. :) | 11:59 |
*** haomaiwang has quit IRC | 12:01 | |
*** haomaiwa_ has joined #openstack-nova | 12:01 | |
alex_xu | tangchen__: that is used to specify sort key, not the filter. you can look at the help of option '--ip', that accept regexp | 12:01 |
tangchen__ | alex_xu: Which option --ip? | 12:02 |
tangchen__ | alex_xu: nova list has no such option | 12:03 |
*** ihrachys has joined #openstack-nova | 12:03 | |
alex_xu | tangchen__: you can see 'nova help list' | 12:03 |
tangchen__ | alex_xu: Ah, my bad. It has an --ip option | 12:03 |
tangchen__ | alex_xu: Will see that. Thx. ;) | 12:04 |
alex_xu | tangchen__: np | 12:04 |
ajo | johnthetubaguy : ack about syncing with armax | 12:04 |
*** jerrygb has joined #openstack-nova | 12:04 | |
johnthetubaguy | alex_xu: tangchen__: sounds like we might need some more API docs that cover these details? | 12:05 |
tangchen__ | johnthetubaguy, alex_xu: Yes, I think so. And I'd like to take this job, since I'm learning it now. :) | 12:06 |
openstackgerrit | Harshada Mangesh Kakad proposed openstack/python-novaclient: nova list with unicode VM name gives UnicodeEncodeError https://review.openstack.org/245736 | 12:06 |
alex_xu | tangchen__: cool, thanks :) | 12:06 |
tangchen__ | johnthetubaguy, alex_xu: I'll try to find out what that means. If I cannot, I'll come to you guys for help. :) | 12:07 |
tangchen__ | Thx | 12:07 |
*** jerrygb has quit IRC | 12:09 | |
*** josecastroleon has quit IRC | 12:09 | |
openstackgerrit | jichenjc proposed openstack/nova: Add more 'actions' for server concepts doc https://review.openstack.org/236947 | 12:13 |
*** EinstCrazy has quit IRC | 12:14 | |
markus_z | tonyb: Are you around? I'd like to talk about a gate job which runs a (somewhat) current version of libvirt | 12:18 |
*** josecastroleon has joined #openstack-nova | 12:19 | |
*** smatzek has joined #openstack-nova | 12:20 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: DO NOT MERGE https://review.openstack.org/245050 | 12:22 |
*** zhenguo has joined #openstack-nova | 12:22 | |
*** fawadkhaliq has quit IRC | 12:23 | |
*** deepakcs has quit IRC | 12:29 | |
*** baoli has joined #openstack-nova | 12:30 | |
johnthetubaguy | tangchen__: help with the docs is awesome, thank you :) | 12:30 |
johnthetubaguy | markus_z: he lives in Australia, totally want to see us make progress with the bleeding edge libvirt gate thing :) | 12:31 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Remove onSharedStorage from evacuate API https://review.openstack.org/243562 | 12:31 |
markus_z | johnthetubaguy: Ah, thanks, I though he's in my timezone. | 12:32 |
markus_z | johnthetubaguy: Yeah, I started digging with the libvirt gate jobs. | 12:33 |
*** baoli has quit IRC | 12:33 | |
openstackgerrit | John Garbutt proposed openstack/nova: Added 'insecure' option to ironic section in nova.conf https://review.openstack.org/232560 | 12:33 |
*** baoli has joined #openstack-nova | 12:33 | |
*** ihrachys has quit IRC | 12:33 | |
*** lucasagomes is now known as lucas-hungry | 12:35 | |
*** Sree has joined #openstack-nova | 12:35 | |
*** ihrachys has joined #openstack-nova | 12:36 | |
markus_z | johnthetubaguy: Can we move ^ to the /nova/conf folder? | 12:37 |
*** baoli has quit IRC | 12:38 | |
*** tdurakov has quit IRC | 12:38 | |
openstackgerrit | javeme proposed openstack/nova: Return more accurate error msg for live migration https://review.openstack.org/243105 | 12:38 |
*** EinstCrazy has joined #openstack-nova | 12:38 | |
*** otter768 has joined #openstack-nova | 12:38 | |
*** moshele has quit IRC | 12:38 | |
*** ekarlso has quit IRC | 12:39 | |
*** ekarlso has joined #openstack-nova | 12:39 | |
*** EinstCrazy has quit IRC | 12:39 | |
*** yassine has quit IRC | 12:39 | |
*** EinstCrazy has joined #openstack-nova | 12:39 | |
*** moshele has joined #openstack-nova | 12:39 | |
*** baoli has joined #openstack-nova | 12:40 | |
*** markvoelker has joined #openstack-nova | 12:40 | |
*** claudiub has quit IRC | 12:41 | |
*** claudiub has joined #openstack-nova | 12:42 | |
*** otter768 has quit IRC | 12:43 | |
*** tdurakov has joined #openstack-nova | 12:43 | |
tdurakov | johnthetubaguy, hi, do you have time to review this: https://review.openstack.org/#/c/216329/ ? | 12:43 |
*** baoli_ has joined #openstack-nova | 12:43 | |
johnthetubaguy | tdurakov: hi, its on my todo list, but I can't promise to get there quickly I am afraid | 12:44 |
*** aysyd has joined #openstack-nova | 12:44 | |
johnthetubaguy | droowning in specs right now | 12:44 |
*** markvoelker has quit IRC | 12:45 | |
* johnthetubaguy runs away for lunch | 12:45 | |
tdurakov | johnthetubaguy, ok, np, i'm fighting with ci-job right now, so it's not critical | 12:45 |
*** baoli has quit IRC | 12:45 | |
tdurakov | bon appétit | 12:45 |
*** alexschm has quit IRC | 12:46 | |
*** Guest51663 is now known as beagles | 12:47 | |
*** openstack has joined #openstack-nova | 12:50 | |
*** fawadkhaliq has joined #openstack-nova | 12:50 | |
*** jaypipes has joined #openstack-nova | 12:51 | |
*** moshele has quit IRC | 12:52 | |
*** fawadkhaliq has quit IRC | 12:52 | |
*** moshele has joined #openstack-nova | 12:53 | |
*** marzif_ has quit IRC | 12:55 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: DO NOT MERGE https://review.openstack.org/245050 | 12:57 |
*** kylek3h_ has quit IRC | 12:58 | |
*** eliqiao1 has joined #openstack-nova | 12:58 | |
*** alexschm has joined #openstack-nova | 12:59 | |
tangchen__ | alex_xu: Maybe I missed something, but I cannot find anything about sort key on that page. | 13:00 |
*** ihrachys has quit IRC | 13:00 | |
*** haomaiwa_ has quit IRC | 13:01 | |
tangchen__ | ales_xu: IIUC, the parameters are filters. | 13:01 |
*** haomaiwang has joined #openstack-nova | 13:01 | |
alex_xu | tangchen__: about sort you can get some info from https://github.com/openstack/nova/blob/master/api-guide/source/paginated_collections.rst | 13:02 |
alex_xu | tangchen__: it will great if we can link the above sort info into the api-ref | 13:03 |
*** eliqiao1 has quit IRC | 13:04 | |
*** yassine has joined #openstack-nova | 13:04 | |
*** yassine has quit IRC | 13:04 | |
*** yassine has joined #openstack-nova | 13:04 | |
*** ihrachys has joined #openstack-nova | 13:04 | |
tangchen__ | alex_xu: yes. But I think digging the code may be the only way that we can find out all the sort keys. And I'll try it. Thx. ;) | 13:05 |
alex_xu | tangchen__: yea, if have to dig the code to find out all, that approve our api doc is really bad | 13:06 |
*** romainh has joined #openstack-nova | 13:06 | |
tangchen__ | alex_xu: Will send a patch if I find them. Thx :) | 13:07 |
*** paul-carlton has joined #openstack-nova | 13:07 | |
*** garyk has quit IRC | 13:07 | |
*** dave-mccowan has joined #openstack-nova | 13:08 | |
alex_xu | tangchen__: np | 13:08 |
*** exploreshaifali has joined #openstack-nova | 13:12 | |
*** markvoelker has joined #openstack-nova | 13:13 | |
johnthetubaguy | alex_xu: is this already on our todo list? | 13:13 |
alex_xu | johnthetubaguy: good point, thanks | 13:14 |
alex_xu | tangchen__: could you put the problem you found about sort and filter in the etherpad https://etherpad.openstack.org/p/nova-v2.1-api-doc, that is good for tracking what people working on, avoid duplicated work. | 13:15 |
*** pm90_ has joined #openstack-nova | 13:15 | |
*** pradk has joined #openstack-nova | 13:16 | |
alex_xu | tangchen__: and mark the your name after the problem item if you are working on | 13:16 |
*** ankit_ag has quit IRC | 13:17 | |
*** leseb has joined #openstack-nova | 13:18 | |
*** Marga_ has joined #openstack-nova | 13:19 | |
*** abhishekk has quit IRC | 13:23 | |
tangchen__ | alex_xu: Done. Please check it just in case that I put it wrong. | 13:24 |
*** Marga_ has quit IRC | 13:24 | |
*** marzif has joined #openstack-nova | 13:24 | |
alex_xu | tangchen__: thanks, I moved it to the line 61, it's better under the servers api | 13:26 |
*** marzif has quit IRC | 13:28 | |
*** edmondsw has joined #openstack-nova | 13:28 | |
*** marzif has joined #openstack-nova | 13:28 | |
*** subscope has quit IRC | 13:30 | |
tangchen__ | alex_xu: OK. ;) | 13:30 |
*** tdurakov has quit IRC | 13:30 | |
*** stevemar_ has joined #openstack-nova | 13:33 | |
*** kylek3h has joined #openstack-nova | 13:35 | |
*** alejandrito has joined #openstack-nova | 13:36 | |
*** tdurakov_ has joined #openstack-nova | 13:36 | |
*** Savemech has quit IRC | 13:37 | |
markus_z | tdurakov_: You're working on a CI job for the live-migration, right? I'd like to introduce a job for bleeding edge libvirt. Do you have a pointer for me where to start? | 13:39 |
tdurakov_ | markus_z, hi, you need to add template to project_config for that | 13:40 |
*** haomaiwang has quit IRC | 13:40 | |
johnthetubaguy | markus_z: I am unsure who was last working on this, I think there was talk (from danpb ?) about using fedora as the base OS, so the packages are available | 13:40 |
tdurakov_ | markus_z, here for example: https://review.openstack.org/#/c/243013/ | 13:41 |
*** Savemech has joined #openstack-nova | 13:42 | |
markus_z | tdurakov_: Yesss, thanks, that's what I was looking for | 13:42 |
danpb | i'm not sure who was working on it i'm afraid | 13:42 |
bauzas | sdague: I'm cool with approving https://review.openstack.org/#/c/240858 given there is already an UpgradeImpact tag | 13:42 |
*** sudipto has joined #openstack-nova | 13:42 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: libvirt: Add ppc for arch for NUMA https://review.openstack.org/245765 | 13:42 |
tdurakov_ | johnthetubaguy, live-migration job is on me, or you are talking about job for bleeding edge libvirt? | 13:42 |
*** burgerk has joined #openstack-nova | 13:42 | |
bauzas | sdague: no need to hold it until reno lands IMHO | 13:42 |
bauzas | (and FWIW, reno landed in master, but we're still missing the job https://review.openstack.org/#/c/242027/ | 13:43 |
bauzas | gibi_: around ? | 13:43 |
markus_z | johnthetubaguy: danpb: I'll talk to tonyb tomorrow morning. Depending on that I'm going to post on the ML to get feedback about the plan. | 13:43 |
markus_z | does that make sense? ^ | 13:43 |
bauzas | markus_z: nova-scheduler meeting in 15 mins, you wanting to fingerpoint against us ? | 13:44 |
openstackgerrit | Bob Ball proposed openstack/nova: XenAPI: Cope with more Cinder backends https://review.openstack.org/244789 | 13:44 |
bauzas | markus_z: did you see any recent bug that you'd like to complain about , | 13:44 |
bauzas | ? | 13:44 |
bauzas | :) | 13:44 |
johnthetubaguy | markus_z: OK makes sense, its worth asking if anyone in #openstack-infra knows if someone is still digging into bleeding edge libvirt | 13:44 |
markus_z | bauzas: Ah, you mean wrt bugs. Not today, I think. | 13:45 |
markus_z | bauzas: But thanks for the offer :) | 13:45 |
bauzas | markus_z: sorry, yup bugs | 13:45 |
bauzas | markus_z: heh, you always have a seat :) | 13:45 |
markus_z | johnthetubaguy: yepp, I'll do that | 13:45 |
*** subscope has joined #openstack-nova | 13:46 | |
sahid | jaypipes: about os_vif i saw that you separate all drivers which is i think good but don't we want to ship at least with os-vif a plugin like linux_brige ? this one could be owned by community | 13:47 |
*** jyuso1 has quit IRC | 13:47 | |
sahid | we can like that provide some libs to help building plugins | 13:47 |
jaypipes | sahid: gimme a few... on a call. danpb has some details about that too | 13:48 |
sahid | s/owned/maintained | 13:48 |
sahid | jaypipes: yep | 13:48 |
*** boris-42 has quit IRC | 13:48 | |
*** ihrachys has quit IRC | 13:49 | |
*** tdurakov_ has quit IRC | 13:51 | |
*** tdurakov_ has joined #openstack-nova | 13:51 | |
*** ihrachys has joined #openstack-nova | 13:52 | |
*** tdurakov_ has quit IRC | 13:52 | |
*** tpeoples has quit IRC | 13:52 | |
*** ubuntu1 is now known as anteaya | 13:52 | |
*** rushiagr_away has quit IRC | 13:52 | |
*** tpeoples has joined #openstack-nova | 13:52 | |
*** auggy has quit IRC | 13:53 | |
*** zhiyan has quit IRC | 13:53 | |
*** andrewbogott has quit IRC | 13:53 | |
*** BadCub has quit IRC | 13:53 | |
*** aweeks has quit IRC | 13:53 | |
*** DuncanT has quit IRC | 13:53 | |
*** greghaynes has quit IRC | 13:53 | |
*** aweeks has joined #openstack-nova | 13:53 | |
bauzas | markus_z: re: your email for conf opts, do you have any change in place for updating http://docs.openstack.org/developer/nova/code-review.html ? | 13:54 |
markus_z | bauzas: After checking the bug list, there are 3 bugs which might benefit from a second pair of eyes. I'm going to say a few words in your meeting if possible. | 13:54 |
*** sballe has quit IRC | 13:54 | |
bauzas | markus_z: cool, some people are hanging around, looking for direction | 13:54 |
bauzas | markus_z: that would benefit for them | 13:54 |
*** zhiyan has joined #openstack-nova | 13:54 | |
*** greghaynes has joined #openstack-nova | 13:54 | |
*** garyk has joined #openstack-nova | 13:54 | |
*** auggy has joined #openstack-nova | 13:54 | |
markus_z | bauzas: Oh, thanks! I'll push an update to the code review guidelines this day. | 13:54 |
bauzas | markus_z: okay, ping me then once it's done, I'll make sure to review it asap | 13:55 |
markus_z | bauzas: Thanks! (congrats to your new role btw) | 13:55 |
bauzas | markus_z: IMHO you could also mention in a follow-up email that change | 13:55 |
openstackgerrit | sahid proposed openstack/nova: libvirt: verify cpu bw policy capability for host https://review.openstack.org/224726 | 13:56 |
*** BadCub has joined #openstack-nova | 13:56 | |
bauzas | markus_z: heh thanks, that means that I have to follow the mailing-list now for ensuring that I can bravely -1 any config change not doing what you want :po | 13:56 |
sdague | bauzas: reno already landed | 13:56 |
*** andrewbogott has joined #openstack-nova | 13:56 | |
*** sballe has joined #openstack-nova | 13:56 | |
bauzas | sdague: the CI patch ? | 13:56 |
sdague | +Aing gibi_'s patch | 13:56 |
sdague | oh, the CI side... I don't know | 13:56 |
sdague | that's not part of docs target? | 13:57 |
*** rushiagr_away has joined #openstack-nova | 13:57 | |
bauzas | sdague: https://review.openstack.org/#/c/242027/ | 13:57 |
*** DuncanT has joined #openstack-nova | 13:57 | |
bauzas | sdague: nope | 13:57 |
markus_z | bauzas: That would be awesome :D | 13:57 |
pkholkin | jaypipes, johnthetubaguy: hello guys, could you please take a look at keypairs-pagination spec https://review.openstack.org/#/c/239663/, thanks! | 13:57 |
bauzas | sdague: that's a distinct job | 13:57 |
*** rlrossit has joined #openstack-nova | 13:57 | |
sdague | bauzas: hmmm, is there a reason we couldn't put it into the docs job? | 13:57 |
bauzas | sdague: so we can +W gibi_'s change because there is an upgradeimpact tag but we should hold any change having reno files until the CI job lands | 13:57 |
*** vladikr has joined #openstack-nova | 13:58 | |
sdague | it seems really weird to build up and throw away a whole guest, so nearly an hour of cloud time, for this job which is rarely going to have anything to look at | 13:58 |
bauzas | sdague: that's a good question, and dhellmann made an answer in my change because mriedem asked for quite the same | 13:58 |
bauzas | meh, not in my change | 13:59 |
sdague | actually, mriedem asked a different question | 13:59 |
*** jlanoux has quit IRC | 13:59 | |
bauzas | okay, then that's thrown out of my mind with possibly bad SNR, but it's because it should be uplodaded differently from the docs target AFAICU | 13:59 |
*** subscope has quit IRC | 14:00 | |
sdague | right, so is the only issue the publisher? | 14:00 |
bauzas | not sure, let's move that convo to #openstack-release | 14:00 |
bauzas | well, actually, I have a meeting to run now :/ | 14:01 |
*** jlanoux has joined #openstack-nova | 14:01 | |
*** lucas-hungry is now known as lucasagomes | 14:01 | |
bauzas | nova-scheduler meeting on #openstack-meeting-alt now | 14:01 |
*** boris-42 has joined #openstack-nova | 14:01 | |
*** nikhil_k_ is now known as nikhil__ | 14:03 | |
*** sgordon has joined #openstack-nova | 14:04 | |
*** ihrachys has quit IRC | 14:05 | |
*** jichen has joined #openstack-nova | 14:05 | |
*** mdrabe has joined #openstack-nova | 14:07 | |
*** zhenguo has quit IRC | 14:08 | |
*** dustins has joined #openstack-nova | 14:08 | |
*** ekarlso has quit IRC | 14:09 | |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: Update binding:profile for SR-IOV ports https://review.openstack.org/242573 | 14:09 |
*** xyang1 has joined #openstack-nova | 14:09 | |
*** moshele has quit IRC | 14:09 | |
*** andrewbogott has quit IRC | 14:10 | |
*** andrewbogott has joined #openstack-nova | 14:10 | |
*** klkumar has quit IRC | 14:13 | |
*** nikhil__ is now known as nikhil_k | 14:15 | |
*** tdurakov_ has joined #openstack-nova | 14:15 | |
*** ihrachys has joined #openstack-nova | 14:16 | |
openstackgerrit | jichenjc proposed openstack/nova: Change Invalid exception to a specified exception https://review.openstack.org/232506 | 14:17 |
*** angdraug has quit IRC | 14:17 | |
*** sacharya has joined #openstack-nova | 14:17 | |
*** haomaiwang has joined #openstack-nova | 14:17 | |
*** achanda has joined #openstack-nova | 14:19 | |
*** Marga_ has joined #openstack-nova | 14:19 | |
*** Sree has quit IRC | 14:20 | |
*** klkumar has joined #openstack-nova | 14:21 | |
*** Sree has joined #openstack-nova | 14:21 | |
*** sacharya has quit IRC | 14:22 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: review guide: add location details for config options https://review.openstack.org/245789 | 14:23 |
markus_z | bauzas: ^ | 14:23 |
*** ctrath has joined #openstack-nova | 14:23 | |
*** jichen has quit IRC | 14:24 | |
*** Marga_ has quit IRC | 14:24 | |
*** moshele has joined #openstack-nova | 14:24 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: DO NOT MERGE https://review.openstack.org/245050 | 14:25 |
*** Sree has quit IRC | 14:25 | |
bauzas | markus_z: CC'd thanks | 14:25 |
*** ijuwang has joined #openstack-nova | 14:28 | |
*** jerrygb has joined #openstack-nova | 14:29 | |
*** klkumar has quit IRC | 14:29 | |
*** jerrygb has quit IRC | 14:29 | |
*** jerrygb has joined #openstack-nova | 14:29 | |
*** mriedem has joined #openstack-nova | 14:30 | |
*** cfriesen__ has joined #openstack-nova | 14:31 | |
openstackgerrit | Alexander Schmidt proposed openstack/nova-specs: Libvirt: AIO mode for disk devices https://review.openstack.org/232514 | 14:32 |
*** angdraug has joined #openstack-nova | 14:32 | |
rlrossit | dansmith: if container_format isn't nullable (https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L64), should the image_meta tests be setting it to None? (https://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_image_meta.py#L72) | 14:33 |
rlrossit | I'm trying to convert that to an enum and it's blowing up in from_dict on those None's | 14:33 |
*** ekarlso has joined #openstack-nova | 14:33 | |
*** tongli has joined #openstack-nova | 14:33 | |
*** smatzek has quit IRC | 14:33 | |
*** ihrachys has quit IRC | 14:34 | |
mriedem | rlrossit: see https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L25 | 14:34 |
mriedem | https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L96-L100 | 14:34 |
rlrossit | mriedem: wut... then why isn't that field marked as nullable? | 14:34 |
rlrossit | gotcha | 14:35 |
rlrossit | man.... | 14:35 |
mriedem | yeah that makes your enum job harder | 14:35 |
rlrossit | no doubt | 14:35 |
mriedem | i guess you'd need a DEFAULT enum value or something | 14:35 |
rlrossit | I might just add a None that's ''? | 14:36 |
*** ed__ has joined #openstack-nova | 14:36 | |
mriedem | shrug | 14:36 |
*** breitz has joined #openstack-nova | 14:36 | |
*** sneti has joined #openstack-nova | 14:37 | |
*** logan2 has quit IRC | 14:37 | |
dansmith | rlrossit: if something is not nullable, then it's can't be None | 14:37 |
rlrossit | dansmith: mriedem showed me the light | 14:37 |
rlrossit | by showing where we have commented that that's a mistake :P | 14:37 |
*** klkumar has joined #openstack-nova | 14:37 | |
*** otter768 has joined #openstack-nova | 14:39 | |
*** lascii is now known as alaski | 14:39 | |
*** ihrachys has joined #openstack-nova | 14:42 | |
*** sneti has quit IRC | 14:42 | |
*** pm90__ has joined #openstack-nova | 14:42 | |
*** prashup has quit IRC | 14:42 | |
*** garyk has quit IRC | 14:43 | |
*** otter768 has quit IRC | 14:44 | |
*** pm90_ has quit IRC | 14:44 | |
*** ihrachys has quit IRC | 14:45 | |
*** ihrachys has joined #openstack-nova | 14:46 | |
*** lykinsbd has joined #openstack-nova | 14:47 | |
*** tdurakov_ is now known as tdurakov | 14:49 | |
openstackgerrit | Roman Podoliaka proposed openstack/nova: libvirt: delete the last file link in _supports_direct_io() https://review.openstack.org/224764 | 14:49 |
*** bapalm has joined #openstack-nova | 14:51 | |
*** willsama has joined #openstack-nova | 14:53 | |
*** willsama has quit IRC | 14:53 | |
*** ihrachys has quit IRC | 14:53 | |
*** bapalm has quit IRC | 14:53 | |
*** marzif has quit IRC | 14:54 | |
*** marzif has joined #openstack-nova | 14:55 | |
*** pumaranikar has joined #openstack-nova | 14:57 | |
*** marzif has quit IRC | 14:58 | |
*** marzif has joined #openstack-nova | 14:59 | |
*** marzif is now known as daemontool | 15:00 | |
*** haomaiwang has quit IRC | 15:01 | |
*** haomaiwang has joined #openstack-nova | 15:01 | |
*** amotoki has joined #openstack-nova | 15:03 | |
*** ihrachys has joined #openstack-nova | 15:03 | |
*** bapalm has joined #openstack-nova | 15:04 | |
*** sudipto has quit IRC | 15:05 | |
openstackgerrit | James Page proposed openstack/nova: Add 'lxd' to the list of recognized hypervisors https://review.openstack.org/245811 | 15:06 |
openstackgerrit | James Page proposed openstack/nova: Add 'lxd' to the list of recognized hypervisors https://review.openstack.org/245811 | 15:07 |
*** cdent has joined #openstack-nova | 15:07 | |
*** cdent has left #openstack-nova | 15:07 | |
*** irenab has quit IRC | 15:08 | |
*** smatzek has joined #openstack-nova | 15:08 | |
*** sneti has joined #openstack-nova | 15:10 | |
*** pece has joined #openstack-nova | 15:11 | |
*** sneti has quit IRC | 15:12 | |
*** sneti_ has joined #openstack-nova | 15:12 | |
*** achanda has quit IRC | 15:13 | |
*** annegentle has joined #openstack-nova | 15:14 | |
*** achanda has joined #openstack-nova | 15:16 | |
*** nic has joined #openstack-nova | 15:17 | |
*** SamYaple_ is now known as SamYaple | 15:17 | |
*** mtanino has joined #openstack-nova | 15:20 | |
*** Marga_ has joined #openstack-nova | 15:20 | |
*** pumaranikar has quit IRC | 15:25 | |
*** Marga_ has quit IRC | 15:25 | |
*** pm90__ is now known as pratikmallya | 15:26 | |
*** garyk has joined #openstack-nova | 15:27 | |
*** josecastroleon has quit IRC | 15:27 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: review guide: add location details for config options https://review.openstack.org/245789 | 15:27 |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: review guide: add location details for config options https://review.openstack.org/245789 | 15:27 |
openstackgerrit | John Garbutt proposed openstack/nova: Live migration failure in API doesn't revert task_state of vm https://review.openstack.org/168916 | 15:28 |
*** wverdugo500 has joined #openstack-nova | 15:29 | |
openstackgerrit | Dan Smith proposed openstack/nova: Add release note for API DB migration requirements https://review.openstack.org/245828 | 15:29 |
dansmith | sdague: ^ | 15:30 |
*** smatzek has quit IRC | 15:30 | |
dansmith | bauzas: alaski: also ^ | 15:30 |
*** ihrachys has quit IRC | 15:31 | |
alaski | cool | 15:31 |
mdbooth | Does anybody happen to know what part of our unittest framework implements the test timeout? | 15:31 |
bauzas | dansmith: sure, looking at the CI patch | 15:31 |
bauzas | dansmith: to see whether we have it running | 15:32 |
dansmith | bauzas: ah, well, this is a requirement for landing the grenade patch to make this actually happen | 15:32 |
sdague | mdbooth: it's in nova/test.py | 15:32 |
mdbooth | sdague: Thanks. Wasn't sure if it was in nova or a library. | 15:32 |
sdague | bauzas: I approved the CI patch | 15:32 |
sdague | mdbooth: https://github.com/openstack/nova/blob/876679c08f05eaa2a90b1f053b65b78a0af433df/nova/tests/fixtures.py#L167-L193 | 15:33 |
bauzas | sdague: yup, ty https://review.openstack.org/#/c/242027/ | 15:33 |
markus_z | dansmith: If a review has a "UpgradeImpact" keyword in its commit message, should this patch then also include a change for the release notes? | 15:33 |
mriedem | markus_z: yes | 15:33 |
sdague | it's actually using a base feature of fixtures, and we have our own fixture to setup the way we want it | 15:33 |
dansmith | markus_z: apparently.. I'm not up on all the plans for reno usage | 15:33 |
bauzas | mriedem: mriedem: we can decouple the reno change from the implementation patch, but that should be in a series | 15:34 |
markus_z | mriedem: Is "UpgradeImpact" then obsolete, since the note is part of the patch set? | 15:34 |
*** ihrachys has joined #openstack-nova | 15:34 | |
dhellmann | dansmith, markus_z : any time you would have done something to ensure a release note went into the wiki, you should now add a note using a reno input file instead | 15:34 |
mdbooth | sdague: Cool. As a secondary issue to the oslo.messaging thing last week, I'm curious why the timeout was at 160 seconds rather than 60 seconds. | 15:34 |
mriedem | markus_z: i'd say if the reno change is in the same change, then we don't need the tag | 15:34 |
mriedem | bauzas: i'd prefer to see them in the same change | 15:34 |
*** pratikmallya has quit IRC | 15:34 | |
bauzas | mriedem: having the reno file in the same patch makes a backport a bit hard I guess - although we shouldn't backport something with an UpgradeImpact tho : | 15:34 |
mriedem | just like docs updates for the hypervisor support matrix, else we forget about them | 15:34 |
bauzas | :D | 15:35 |
mriedem | bauzas: right | 15:35 |
mdbooth | sdague: In redesigning the patch, I might look at ways of making it more kill friendly. | 15:35 |
markus_z | mriedem: Yepp, makes sense to keep it in the same patch | 15:35 |
*** ljxiash has joined #openstack-nova | 15:35 | |
dhellmann | bauzas : having the reno file in the patch with the code *is the point of using reno* for backports :-) | 15:35 |
dansmith | mriedem: I feel like the reno patch can't always be exactly with all the things affecting the release note, but whenever possible it makes sense to me | 15:35 |
sdague | mdbooth: I don't know historically why it's 160 | 15:35 |
bauzas | dhellmann: mriedem: okay, I rally the consensus :) | 15:35 |
markus_z | dhellmann: Cool, great to see the tighter coupling of change to release note. | 15:35 |
dhellmann | dansmith : reno files can be edited after the original patch, too | 15:35 |
sdague | but that's the value in .testr.conf | 15:35 |
markus_z | I like that | 15:35 |
dansmith | dhellmann: sure, but not all patches will translate to a single line in the release note | 15:36 |
mriedem | dansmith: if it's a single change bug fix it should be in the same change, if it's a bp series that runs all cycle, then sure it goes at the end | 15:36 |
dansmith | mriedem: right, exactly | 15:36 |
mdbooth | sdague: Ah, ok. In that case there's no issue, I guess. I thought it was messing with the timeout somehow. | 15:36 |
dhellmann | dansmith : sure, I just meant if something is left out of the note, that doesn't require a new note | 15:36 |
bauzas | mriedem: +1 | 15:36 |
dansmith | dhellmann: aye | 15:36 |
sdague | mdbooth: https://github.com/openstack/nova/blob/876679c08f05eaa2a90b1f053b65b78a0af433df/.testr.conf#L4 | 15:36 |
sdague | that's where it comes from | 15:36 |
mdbooth | sdague: Got it. Well, it works :) | 15:37 |
bauzas | dansmith: are you comfortable with waiting the reno job to land before we approve https://review.openstack.org/#/c/245828/1 ? | 15:37 |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Add ContainerFormat field https://review.openstack.org/245834 | 15:37 |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Use ContainerFormat instead of strings https://review.openstack.org/245835 | 15:37 |
dansmith | bauzas: depends on how long it takes I guess | 15:37 |
*** eglynn has joined #openstack-nova | 15:38 | |
bauzas | dansmith: checking zuul | 15:38 |
bauzas | dansmith: it's already +W'd by sdague | 15:38 |
dansmith | ah, then sure | 15:38 |
markus_z | dhellmann: The hash-ish value in the file name (-6245f39d36885d1c.yaml) is explained in your ML post I guess? | 15:38 |
bauzas | oh snap | 15:38 |
dhellmann | markus_z : that's just a random value to ensure a unique filename | 15:39 |
bauzas | so, https://review.openstack.org/#/c/242027/ depends on https://review.openstack.org/#/q/Ibd74e62b6f36076dbec17dd146632fd42aad6eb2,n,z | 15:39 |
dhellmann | markus_z : it's described in the reno docs | 15:39 |
markus_z | dhellmann: Ah, I thought so, must have missed it, thanks! | 15:39 |
bauzas | the master branch is merged, but the liberty one was failing due to a cells job issue that is fixed but needs to land | 15:39 |
*** salv-orlando has joined #openstack-nova | 15:39 | |
dhellmann | markus_z : np, it's going to take a while to get everyone up to speed on the new system, that's why I wanted to start right away | 15:39 |
bauzas | what happens with Depend-On ? I guess it's blocked until | 15:39 |
bauzas | *all* changes with the same change-id are merged, right? | 15:40 |
bauzas | I need to reread some sdague's thread on the ML | 15:40 |
dansmith | bauzas: yeah | 15:40 |
bauzas | snap | 15:40 |
*** pratikmallya has joined #openstack-nova | 15:41 | |
sdague | yeh, and it's *all* changes. so if you abandon a change, you are stuck. | 15:41 |
dansmith | we also probably need a regex for just-adding-a-release-note patches to only run the reno job, once that's in | 15:41 |
bauzas | dansmith: that should be in place | 15:41 |
sdague | dansmith: yeh, it's already there more or less | 15:41 |
bauzas | dansmith: https://review.openstack.org/#/c/242027/2/zuul/layout.yaml,cm | 15:41 |
dansmith | well, my patch is getting the full slew of patches | 15:41 |
dansmith | er, tests | 15:41 |
bauzas | dansmith: because ^ isn't merged yet | 15:42 |
dansmith | okay | 15:42 |
dansmith | oh I see | 15:42 |
sdague | bauzas: did the tempest exclusion land yet? | 15:42 |
bauzas | which is stuck because it depends on a stable patch which itself is blocked because of a cells job issue that is fixed by https://review.openstack.org/#/c/245712/ | 15:42 |
bauzas | sdague: not yet | 15:43 |
sdague | bauzas: can you rebase your change on that? | 15:43 |
sdague | then we can approve the reno one and it can run in parallel | 15:43 |
bauzas | sdague: oh, you mean rebasing the reno liberty series on top of https://review.openstack.org/#/c/245712/ ? | 15:44 |
bauzas | sdague: sure I can | 15:44 |
sdague | yeh | 15:44 |
sdague | then we can get good test results | 15:44 |
bauzas | that sounds a very good idea | 15:44 |
*** thangp has joined #openstack-nova | 15:45 | |
*** marzif_ has joined #openstack-nova | 15:46 | |
*** ctrath has quit IRC | 15:46 | |
*** exploreshaifali has quit IRC | 15:47 | |
*** ihrachys has quit IRC | 15:47 | |
*** daemontool has quit IRC | 15:49 | |
*** ihrachys has joined #openstack-nova | 15:50 | |
*** mc_nair has joined #openstack-nova | 15:52 | |
*** mdrabe has quit IRC | 15:52 | |
bauzas | sdague: FWIW https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/liberty+topic:add-reno,n,z | 15:52 |
*** eharney has joined #openstack-nova | 15:52 | |
*** daemontool has joined #openstack-nova | 15:53 | |
*** ihrachys has quit IRC | 15:53 | |
*** fawadkhaliq has joined #openstack-nova | 15:53 | |
*** marzif_ has quit IRC | 15:54 | |
sdague | bauzas: thanks, approved | 15:54 |
bauzas | sdague: ty | 15:54 |
*** ctrath has joined #openstack-nova | 15:56 | |
bauzas | sdague: johnthetubaguy: dansmith: markus_z just wrote a new code-review.rst change for the config opts https://review.openstack.org/#/c/245789/3/doc/source/code-review.rst,cm | 15:57 |
*** ihrachys has joined #openstack-nova | 15:58 | |
*** rpodolyaka1 has joined #openstack-nova | 15:58 | |
*** pumaranikar has joined #openstack-nova | 15:58 | |
*** dustins has quit IRC | 15:59 | |
johnthetubaguy | bauzas: markus_z: do we want that to be part of the blueprint, just to help tracking? | 15:59 |
bauzas | johnthetubaguy: since the spec was approved, I felt it was important to document that as part of a code review | 15:59 |
bauzas | johnthetubaguy: unsure if we need to track that in the BP tho | 15:59 |
bauzas | johnthetubaguy: that's actually already in the whiteboard https://blueprints.launchpad.net/nova/+spec/centralize-config-options :) | 16:00 |
johnthetubaguy | bauzas: don't have to, just it should be more reviews that way | 16:00 |
*** haomaiwang has quit IRC | 16:01 | |
johnthetubaguy | true | 16:01 |
*** haomaiwang has joined #openstack-nova | 16:01 | |
bauzas | johnthetubaguy: the tag isn't there, but since he said "blueprint foo" in the message, the magic of launchpad did the trick | 16:01 |
johnthetubaguy | bauzas: I am blind, I see that now | 16:02 |
markus_z | I was unsure about the topic but thought that maybe some folks have a query on "topic:review-guide". | 16:02 |
*** emagana has joined #openstack-nova | 16:02 | |
dansmith | bauzas: markus_z should we land that doc before nova/config/* are created? | 16:03 |
dansmith | I kinda think not | 16:03 |
markus_z | dansmith: Shouldn't be necessary | 16:03 |
*** ameade has quit IRC | 16:03 | |
*** ameade has joined #openstack-nova | 16:04 | |
bauzas | dansmith: fair point | 16:04 |
dansmith | markus_z: it seems confusing to me that you mention a file that is not in the tree | 16:04 |
markus_z | dansmith: It's just a reminder for reviewers. Would be sad if I move stuff to "nove/conf" and others push new ones to the functional modules. | 16:04 |
bauzas | markus_z: you should rebase on top of your change | 16:04 |
dansmith | markus_z: yeah, but.. | 16:04 |
markus_z | dansmith: ah, ok, I see the issue | 16:04 |
dansmith | markus_z: at least one file in nova/conf so it exists would be good I think | 16:04 |
*** pratikmallya has quit IRC | 16:05 | |
markus_z | dansmith: jepp, makes sense, I'll do that | 16:05 |
dansmith | thanks | 16:05 |
*** tdurakov has quit IRC | 16:05 | |
edleafe | markus_z: for the conf stuff, do you need me to handle the scheduler changes? | 16:06 |
markus_z | edleafe: That would be awesome! | 16:07 |
edleafe | markus_z: it's a great idea - glad to help out | 16:07 |
*** jlanoux has quit IRC | 16:07 | |
*** wverdugo500 has quit IRC | 16:08 | |
markus_z | edleafe: Thanks! I owe you one. | 16:08 |
edleafe | markus_z: nah, all in a day's work... | 16:08 |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: review guide: add location details for config options https://review.openstack.org/245789 | 16:08 |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: config options: centralize section "serial_console" https://review.openstack.org/244177 | 16:08 |
*** mdrabe has joined #openstack-nova | 16:09 | |
markus_z | edleafe: I use this etherpad for the organization: https://etherpad.openstack.org/p/config-options | 16:10 |
*** tonytan4ever has joined #openstack-nova | 16:10 | |
edleafe | markus_z: thanks. bookmarked. | 16:11 |
*** Piet has quit IRC | 16:11 | |
*** belmoreira has quit IRC | 16:11 | |
*** josecastroleon has joined #openstack-nova | 16:11 | |
*** mjura has quit IRC | 16:12 | |
*** alex_klimov has quit IRC | 16:14 | |
*** arunkant has quit IRC | 16:15 | |
*** smatzek has joined #openstack-nova | 16:16 | |
*** ihrachys has quit IRC | 16:16 | |
*** ihrachys has joined #openstack-nova | 16:17 | |
*** mdrabe has quit IRC | 16:19 | |
*** tpeoples has quit IRC | 16:19 | |
*** tdp has joined #openstack-nova | 16:19 | |
*** tdp has quit IRC | 16:19 | |
*** amotoki has quit IRC | 16:19 | |
*** tpeoples has joined #openstack-nova | 16:19 | |
*** Marga_ has joined #openstack-nova | 16:21 | |
*** hemnafk is now known as hemna | 16:21 | |
*** wendar_ is now known as wendar | 16:26 | |
*** Marga_ has quit IRC | 16:26 | |
markus_z | pkholkin: I'm not sure if you noticed the update from invalid->new in https://bugs.launchpad.net/nova/+bug/1503179 | 16:28 |
openstack | Launchpad bug 1503179 in OpenStack Compute (nova) "nic ordering is inconsistent between hard reboot" [Undecided,New] - Assigned to Pavel Kholkin (pkholkin) | 16:28 |
pkholkin | markus_z: hello, thanks for the update, but I tested it when marked it as invalid and didn't see any problems | 16:30 |
*** jwcroppe has joined #openstack-nova | 16:30 | |
*** jdurgin has joined #openstack-nova | 16:31 | |
*** pratikmallya has joined #openstack-nova | 16:31 | |
*** alex_xu has quit IRC | 16:31 | |
*** Yingxin has quit IRC | 16:32 | |
*** ihrachys has quit IRC | 16:33 | |
*** gzhai3 has quit IRC | 16:33 | |
openstackgerrit | Tiago Mello proposed openstack/nova: libvirt: Handle unsupported Spice feature per arch https://review.openstack.org/203809 | 16:33 |
*** pratikma_ has joined #openstack-nova | 16:33 | |
mriedem | how long before we start abusing in tree release notes | 16:34 |
markus_z | pkholkin: The comment #4 talks about "kilo" and your patch was for master. Maybe it was still an issue in Kilo. | 16:34 |
mriedem | we should start an office pool | 16:34 |
*** tjones has joined #openstack-nova | 16:34 | |
*** eliqiao_ has joined #openstack-nova | 16:34 | |
*** Yingxin has joined #openstack-nova | 16:34 | |
*** yonglihe has joined #openstack-nova | 16:34 | |
markus_z | mriedem: How would the abuse look like? | 16:34 |
mriedem | i just pointed out that we could have a release note for this also https://review.openstack.org/#/c/216917/ | 16:34 |
*** gzhai3 has joined #openstack-nova | 16:34 | |
*** suro-patz has joined #openstack-nova | 16:34 | |
mriedem | abuse as in release notes for everything, which overwhelms readers and they don't read them | 16:35 |
pkholkin | markus_z: ok, we are working on enginefacade now, will take a look if have time | 16:35 |
markus_z | pkholkin: thanks! | 16:35 |
*** alex_xu has joined #openstack-nova | 16:35 | |
markus_z | mriedem: yeah, I've added a topic on the next nova meeting to discuss some guidelines, but a ML post would make also make sense I guess. | 16:36 |
pkholkin | mriedem: Hello Matt, could you please take a look at keypairs-pagination spec https://review.openstack.org/#/c/239663/, thanks! | 16:36 |
mriedem | pkholkin: did that ML thread get sorted out? | 16:36 |
*** pratikmallya has quit IRC | 16:36 | |
pkholkin | mriedem: I don't know ( | 16:36 |
pkholkin | no information about it | 16:36 |
mriedem | ok, i don't feel like doing a bunch of pre-reading homework right now :) | 16:37 |
*** matrohon has joined #openstack-nova | 16:37 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: WIP: enginefacade: 'instance' https://review.openstack.org/244146 | 16:37 |
*** eliqiao has quit IRC | 16:37 | |
openstackgerrit | John Garbutt proposed openstack/nova: docs: update the API faults concept guide https://review.openstack.org/243066 | 16:38 |
openstackgerrit | Diana Clarke proposed openstack/nova: Use ServiceList object rather than direct db call https://review.openstack.org/243694 | 16:38 |
pkholkin | mriedem: ok, maybe some time :) | 16:38 |
openstackgerrit | Harshada Mangesh Kakad proposed openstack/python-novaclient: nova list with unicode VM name gives UnicodeEncodeError https://review.openstack.org/245736 | 16:38 |
mriedem | pkholkin: from the ML thread it sounds like getting agreement in the API WG on pagination is a dependency http://specs.openstack.org/openstack/api-wg/guidelines/pagination_filter_sort.html | 16:39 |
*** jerrygb has quit IRC | 16:39 | |
mriedem | which is https://review.openstack.org/#/c/190743/ | 16:39 |
*** dustins has joined #openstack-nova | 16:40 | |
*** otter768 has joined #openstack-nova | 16:40 | |
*** wverdugo500 has joined #openstack-nova | 16:40 | |
*** ihrachys has joined #openstack-nova | 16:40 | |
openstackgerrit | John Garbutt proposed openstack/nova: docs: update the API faults concept guide https://review.openstack.org/243066 | 16:40 |
*** korzen has quit IRC | 16:41 | |
*** josecastroleon has quit IRC | 16:41 | |
*** sacharya has joined #openstack-nova | 16:42 | |
*** Piet has joined #openstack-nova | 16:43 | |
pkholkin | mriedem: looking | 16:43 |
*** paul-carlton has quit IRC | 16:44 | |
*** otter768 has quit IRC | 16:45 | |
*** wverdugo500 has quit IRC | 16:45 | |
*** mgoddard_ has joined #openstack-nova | 16:45 | |
openstackgerrit | John Garbutt proposed openstack/nova-specs: Proposal for cells v2 scheduling interaction https://review.openstack.org/239995 | 16:46 |
*** jlanoux has joined #openstack-nova | 16:46 | |
*** jerrygb has joined #openstack-nova | 16:47 | |
*** annasort has joined #openstack-nova | 16:48 | |
*** mgoddard has quit IRC | 16:49 | |
*** matrohon has quit IRC | 16:50 | |
*** armax has joined #openstack-nova | 16:50 | |
*** achanda has quit IRC | 16:51 | |
*** ed__ has quit IRC | 16:51 | |
*** tonytan4ever has quit IRC | 16:54 | |
*** apoorvad has joined #openstack-nova | 16:54 | |
*** sudipto has joined #openstack-nova | 16:55 | |
*** gcb has quit IRC | 16:55 | |
*** rlrossit has quit IRC | 16:56 | |
*** moshele has quit IRC | 16:56 | |
*** alexschm has quit IRC | 16:56 | |
*** ctrath has quit IRC | 16:58 | |
*** mgoddard has joined #openstack-nova | 16:58 | |
*** mgoddard_ has quit IRC | 16:58 | |
*** ctrath has joined #openstack-nova | 16:58 | |
bauzas | mriedem: in theory, every UpgradeImpact deserves a relnote, right ? :) | 16:58 |
bauzas | mriedem: so we were only brief because we were lazy :p | 16:58 |
mriedem | bauzas: not theory | 16:58 |
mriedem | UpgradeImpact is always a release note. | 16:59 |
*** Sree has joined #openstack-nova | 16:59 | |
mriedem | DocImpact was always questionable | 16:59 |
mriedem | i.e. config options, manuals, sometimes release notes | 16:59 |
mriedem | but a lot of time people slap DocImpact on their change and don't explain what the doc impact is | 16:59 |
bauzas | mriedem: okay so we need to trust reno :) | 17:00 |
mriedem | they just assume the docs team will get the bug and figure it out | 17:00 |
bauzas | ++ | 17:00 |
*** apoorvad has quit IRC | 17:00 | |
*** Piet has quit IRC | 17:00 | |
*** haomaiwang has quit IRC | 17:01 | |
markus_z | yeah, most of the time I couldn't figure out what the docimpact should be... | 17:01 |
*** 18WAA5P6F has joined #openstack-nova | 17:01 | |
*** rlrossit has joined #openstack-nova | 17:01 | |
*** rdopiera has quit IRC | 17:01 | |
mriedem | then -1 and ask for clarification in the commit message for the DocImpact | 17:02 |
mriedem | the guide on those tags actually says you should explain with the tag what the impact is | 17:02 |
markus_z | I did | 17:02 |
*** jaypipes has quit IRC | 17:02 | |
*** whenry_ has quit IRC | 17:03 | |
*** ihrachys_ has joined #openstack-nova | 17:05 | |
*** ihrachys has quit IRC | 17:06 | |
markus_z | well, I'm curious how reno will work for us, let's see | 17:07 |
openstackgerrit | Sudipta Biswas proposed openstack/nova: libvirt: Add ppc for arch for NUMA https://review.openstack.org/245765 | 17:07 |
openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: imagecache: set base_dir as a property https://review.openstack.org/209912 | 17:10 |
openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: imagecache: implement listing of cached images https://review.openstack.org/209913 | 17:10 |
openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: virt: add method for obtaining the list of cached images https://review.openstack.org/209914 | 17:10 |
openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: libvirt: implement get_cached_images method https://review.openstack.org/209915 | 17:10 |
openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: scheduler: weight nodes based on their cached images https://review.openstack.org/173304 | 17:10 |
openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: compute: add new image cache monitor https://review.openstack.org/173303 | 17:10 |
*** nkrinner has quit IRC | 17:11 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: libvirt: Add ppc for arch for NUMA https://review.openstack.org/245765 | 17:11 |
kashyap | markus_z: I thought there was a doc that notes _what_ kinds of things need a DocImpact (besides obvious things like new config entries, default config attribute changes, things that impact upgrade) | 17:11 |
openstackgerrit | Ed Leafe proposed openstack/nova: DO NOT MERGE - WIP https://review.openstack.org/245891 | 17:13 |
edleafe | markus_z: ^^ | 17:13 |
*** scheuran has quit IRC | 17:13 | |
markus_z | edleafe: great, I'll take look | 17:13 |
edleafe | Just did a small bit to see if I'm on the right track | 17:13 |
*** tdurakov_ has joined #openstack-nova | 17:13 | |
markus_z | kashyap: I think the infra-manual has an entry, sec | 17:14 |
mriedem | sdague: you might want to weigh in on the marker debate here https://review.openstack.org/#/c/190743/ | 17:14 |
mriedem | that seems to be the only thing really holding that up | 17:14 |
mriedem | alex_xu: ^ | 17:14 |
*** davidlenwell_ is now known as davidlenwell | 17:15 | |
markus_z | kashyap: https://wiki.openstack.org/wiki/Documentation/DocImpact | 17:15 |
kashyap | Yep, thanks for fishing it out | 17:15 |
mriedem | " or if you're just not sure, just add "DocImpact" to a line in your commit message." | 17:16 |
mriedem | so the docs are a bit bipolar | 17:16 |
mriedem | https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references | 17:16 |
markus_z | Yeah, I'm stumbling over that line too | 17:16 |
mriedem | "The DocImpact line contains the string DocImpact, and a comment about why the change impacts documentation." | 17:16 |
*** rameshg87 has joined #openstack-nova | 17:16 | |
mriedem | anyway, i prefer the latter | 17:17 |
*** ihrachys_ has quit IRC | 17:18 | |
*** burgerk_ has joined #openstack-nova | 17:19 | |
*** logan2 has joined #openstack-nova | 17:20 | |
*** rameshg87 has left #openstack-nova | 17:21 | |
*** Marga_ has joined #openstack-nova | 17:22 | |
*** burgerk has quit IRC | 17:22 | |
*** mriedem has quit IRC | 17:22 | |
*** rpodolyaka1 has quit IRC | 17:24 | |
*** ihrachys has joined #openstack-nova | 17:24 | |
*** tonytan4ever has joined #openstack-nova | 17:25 | |
*** ihrachys has quit IRC | 17:25 | |
*** apoorvad has joined #openstack-nova | 17:26 | |
*** unicell has quit IRC | 17:26 | |
*** e0ne has quit IRC | 17:27 | |
*** Marga_ has quit IRC | 17:27 | |
*** Guest91043 is now known as mgagne | 17:28 | |
*** mgagne has joined #openstack-nova | 17:28 | |
openstackgerrit | Bob Ball proposed openstack/nova: XenAPI: Fix race in rotate_xen_guest_logs https://review.openstack.org/245898 | 17:28 |
BobBall | johnthetubaguy: ^ :) | 17:29 |
*** mgagne is now known as Guest91043 | 17:29 | |
*** suro-patz has quit IRC | 17:29 | |
*** Guest91043 is now known as mgagne | 17:29 | |
*** ihrachys has joined #openstack-nova | 17:29 | |
*** prashup has joined #openstack-nova | 17:29 | |
*** romainh has quit IRC | 17:30 | |
*** nic has quit IRC | 17:31 | |
*** angdraug has quit IRC | 17:32 | |
*** schwicke has quit IRC | 17:33 | |
*** slagle_ is now known as slagle | 17:33 | |
*** armax has quit IRC | 17:34 | |
*** armax has joined #openstack-nova | 17:39 | |
johnthetubaguy | BobBall: feel free to add that into the sub team list, unlikley to get to that today I am afraid | 17:40 |
*** jaypipes has joined #openstack-nova | 17:40 | |
BobBall | Wasn't meaning today - that link was just for your enjoyment | 17:40 |
*** nic has joined #openstack-nova | 17:40 | |
BobBall | Since we were talking about the logging the other day | 17:41 |
*** lpetrut has quit IRC | 17:42 | |
*** sahid has quit IRC | 17:42 | |
*** rcernin has quit IRC | 17:42 | |
markus_z | edleafe: Let me know if my feedback on your change is understandable. | 17:43 |
*** ljxiash has quit IRC | 17:43 | |
edleafe | markus_z: I was just responding on gerrit, but let me ask you here instead. | 17:44 |
markus_z | edleafe: sure, go ahead | 17:44 |
edleafe | there was no such OptGroup in the current scheduler/manager.py | 17:44 |
edleafe | I didn't want to change anything, just move it | 17:44 |
edleafe | Are OptGroups required now to work? | 17:45 |
markus_z | edleafe: No, they are not required. | 17:45 |
*** paul-carlton has joined #openstack-nova | 17:45 | |
markus_z | edleafe: But they allow to give a greater context because they have a "help" attribute too. | 17:45 |
*** klkumar has quit IRC | 17:46 | |
edleafe | markus_z: understood. I just didn't want to confuse things by changing how they appear | 17:46 |
edleafe | markus_z: other than the additional help text, of course :) | 17:46 |
markus_z | edleafe: Yeah, I was also unsure if I didn't introduce too much in one change. I tried it this way. | 17:47 |
*** ihrachys has quit IRC | 17:47 | |
*** angdraug has joined #openstack-nova | 17:47 | |
edleafe | markus_z: I was going by your serial console stuff, and it already had the OptGroup | 17:47 |
*** ihrachys has joined #openstack-nova | 17:48 | |
openstackgerrit | Dan Smith proposed openstack/nova-specs: Enable SR-IOV physical functions assignment with Neutron port https://review.openstack.org/239875 | 17:48 |
edleafe | markus_z: so moving forward, should we avoid changing as much as possible? Or add groupings where there aren't any? | 17:48 |
markus_z | edleafe: The usage of it was new. The code used plain "serial_console" as group *name*. | 17:48 |
*** ihrachys has quit IRC | 17:49 | |
markus_z | edleafe: You mean splitting up existing nova.conf sections? | 17:49 |
markus_z | like "scheduler"? | 17:50 |
*** angdraug has quit IRC | 17:50 | |
*** rlrossit has quit IRC | 17:50 | |
*** ctrath has quit IRC | 17:50 | |
*** nic has quit IRC | 17:50 | |
dansmith | jaypipes: can you look at this in the realm of the os-vif thing? https://review.openstack.org/#/c/239875 | 17:50 |
openstackgerrit | Bob Ball proposed openstack/nova: XenAPI: Cope with more Cinder backends https://review.openstack.org/244789 | 17:50 |
edleafe | markus_z: no, I meant adding OptGroups where there aren't any in the current code | 17:50 |
johnthetubaguy | markus_z: I was looking at the config change, and wondering if we should just do the straight move, then do the updates? | 17:51 |
markus_z | johnthetubaguy: You mean splitting it up? patch1: move opts, patch2: update help? | 17:52 |
johnthetubaguy | markus_z: edleafe: like the idea of move being really simple, with basically zero test changes, then following up with fix ups once the file is full | 17:52 |
johnthetubaguy | markus_z: yeah, its tempting to recommend that | 17:52 |
johnthetubaguy | markus_z: would that be reasonable? or is that making for way too much work | 17:53 |
johnthetubaguy | markus_z: I am just thinking, the move should be quite a simple review, and it leaves the arguments around text on the second change | 17:53 |
markus_z | johnthetubaguy: It's reasonable. I wanted to keep the amount of patches low. | 17:53 |
*** ihrachys has joined #openstack-nova | 17:54 | |
*** armax has quit IRC | 17:54 | |
*** daemontool has quit IRC | 17:54 | |
johnthetubaguy | markus_z: yeah, understood, its defiantly a trade off | 17:54 |
markus_z | johnthetubaguy: And I don't have another "hard" argument to have everything in one patch. | 17:54 |
*** ctrath has joined #openstack-nova | 17:54 | |
*** danpb has quit IRC | 17:54 | |
edleafe | johnthetubaguy: so first get all the options moved unchanged, and then update the help? | 17:54 |
johnthetubaguy | markus_z: I just think the move patches are going to conflict a lot, so its good to get them through the system quickly | 17:54 |
*** rlrossit has joined #openstack-nova | 17:54 | |
johnthetubaguy | edleafe: thats what my gut is telling me | 17:54 |
edleafe | johnthetubaguy: makes sense from a reviewing POV | 17:55 |
markus_z | johnthetubaguy: I trust your gut :) | 17:55 |
johnthetubaguy | heh | 17:55 |
edleafe | johnthetubaguy: markus_z: ok, I'll push an update later | 17:56 |
jaypipes | dansmith: looking. | 17:56 |
raildo | johnthetubaguy: ping, I was thinking in create a sub-team for review the nested quota code and start discussing the quota re-desing. what do you think? | 17:56 |
markus_z | edleafe: OK, cool. I have to leave for today, it's late for me. | 17:56 |
markus_z | johnthetubaguy: thanks for having a look at it. I update my patch tomorrow morning. | 17:57 |
markus_z | *I'm going to | 17:57 |
johnthetubaguy | markus_z: sounds good, have a good evening | 17:57 |
edleafe | markus_z: no worries. I hope to have it up by the time you wake up. :) | 17:57 |
*** rk4n has quit IRC | 17:58 | |
*** edtubill has joined #openstack-nova | 17:58 | |
*** edtubill has quit IRC | 17:59 | |
*** 18WAA5P6F has quit IRC | 18:01 | |
*** haomaiwang has joined #openstack-nova | 18:01 | |
*** edtubill has joined #openstack-nova | 18:02 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Removed extra spaces from double line strings https://review.openstack.org/242989 | 18:02 |
*** mriedem has joined #openstack-nova | 18:03 | |
*** snikitin2 has joined #openstack-nova | 18:03 | |
snikitin2 | johnthetubaguy: Hi John! You approved patch. https://review.openstack.org/#/c/242989/ but it got merge conflict :( could you please reaprove this trivial fix? | 18:05 |
*** ihrachys has quit IRC | 18:05 | |
*** harlowja has joined #openstack-nova | 18:06 | |
*** jlanoux has quit IRC | 18:06 | |
johnthetubaguy | snikitin2: np | 18:06 |
*** unicell has joined #openstack-nova | 18:07 | |
snikitin2 | johnthetubaguy: thanks | 18:07 |
*** armax has joined #openstack-nova | 18:07 | |
*** armax has quit IRC | 18:07 | |
*** edtubill has quit IRC | 18:07 | |
johnthetubaguy | raildo: seems worth a try, I have had chance to catch up with melwitt to talk about quotas since the summit | 18:07 |
*** edtubill has joined #openstack-nova | 18:08 | |
*** claudiub has quit IRC | 18:09 | |
*** ihrachys has joined #openstack-nova | 18:10 | |
*** suro-patz has joined #openstack-nova | 18:10 | |
*** edtubill has quit IRC | 18:10 | |
*** edtubill has joined #openstack-nova | 18:11 | |
*** rcernin has joined #openstack-nova | 18:12 | |
*** jichen has joined #openstack-nova | 18:12 | |
raildo | so, what I have to do? talk with some cores? put a topic in the neext nova meeting? | 18:13 |
raildo | johnthetubaguy: ^ | 18:13 |
*** edtubill has quit IRC | 18:14 | |
*** armax has joined #openstack-nova | 18:14 | |
*** lucasagomes is now known as lucas-dinner | 18:15 | |
*** tdurakov_ has quit IRC | 18:15 | |
*** armax has quit IRC | 18:15 | |
*** edtubill has joined #openstack-nova | 18:17 | |
*** paul-carlton has quit IRC | 18:17 | |
*** kfarr has joined #openstack-nova | 18:17 | |
*** paul-carlton has joined #openstack-nova | 18:18 | |
*** doug-fish has quit IRC | 18:20 | |
*** doug-fish has joined #openstack-nova | 18:21 | |
*** ihrachys has quit IRC | 18:22 | |
*** Sree has quit IRC | 18:22 | |
*** penick has joined #openstack-nova | 18:23 | |
*** Marga_ has joined #openstack-nova | 18:23 | |
johnthetubaguy | raildo: there is no process for creating a subteam, and you don't need permission, more details here: https://wiki.openstack.org/wiki/Nova#Nova_subteams | 18:23 |
raildo | johnthetubaguy: got it. thanks :) | 18:23 |
*** lpetrut has joined #openstack-nova | 18:24 | |
*** e0ne has joined #openstack-nova | 18:24 | |
*** doug-fish has quit IRC | 18:25 | |
*** Marga__ has joined #openstack-nova | 18:26 | |
*** ctrath has quit IRC | 18:27 | |
*** Marga__ has quit IRC | 18:27 | |
*** Marga_ has quit IRC | 18:27 | |
*** lucas-dinner has quit IRC | 18:27 | |
*** ctrath has joined #openstack-nova | 18:28 | |
*** Marga_ has joined #openstack-nova | 18:28 | |
*** ssurana has joined #openstack-nova | 18:29 | |
*** jistr has quit IRC | 18:29 | |
*** fawadkhaliq has quit IRC | 18:29 | |
*** penick has quit IRC | 18:30 | |
*** ociuhandu has quit IRC | 18:31 | |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: Add way to pause VM during live migration https://review.openstack.org/245921 | 18:31 |
*** tdurakov_ has joined #openstack-nova | 18:32 | |
*** rpodolyaka1 has joined #openstack-nova | 18:32 | |
*** penick has joined #openstack-nova | 18:32 | |
*** rpodolyaka1 has quit IRC | 18:34 | |
*** vilobhmm has joined #openstack-nova | 18:34 | |
*** rpodolyaka1 has joined #openstack-nova | 18:34 | |
*** lucasagomes has joined #openstack-nova | 18:35 | |
*** mgoddard_ has joined #openstack-nova | 18:35 | |
*** mgoddard has quit IRC | 18:38 | |
*** mgoddard_ has quit IRC | 18:40 | |
*** vilobhmm has quit IRC | 18:40 | |
*** vilobhmm has joined #openstack-nova | 18:40 | |
*** PaulMurray is now known as ptm_away | 18:40 | |
*** vilobhmm has quit IRC | 18:41 | |
*** otter768 has joined #openstack-nova | 18:41 | |
*** rpodolyaka1 has quit IRC | 18:41 | |
*** ijuwang has quit IRC | 18:41 | |
*** vilobhmm has joined #openstack-nova | 18:41 | |
*** vilobhmm has quit IRC | 18:41 | |
*** vilobhmm has joined #openstack-nova | 18:42 | |
*** thorst_ has quit IRC | 18:43 | |
*** thorst_ has joined #openstack-nova | 18:44 | |
*** salv-orlando has quit IRC | 18:44 | |
*** thorst_ has quit IRC | 18:44 | |
*** thorst_ has joined #openstack-nova | 18:45 | |
*** doug-fish has joined #openstack-nova | 18:46 | |
*** otter768 has quit IRC | 18:46 | |
*** thorst_ has quit IRC | 18:46 | |
*** thorst_ has joined #openstack-nova | 18:47 | |
*** thorst_ has quit IRC | 18:49 | |
*** thorst_ has joined #openstack-nova | 18:49 | |
*** rpodolyaka1 has joined #openstack-nova | 18:49 | |
openstackgerrit | jichenjc proposed openstack/nova: Change Invalid exception to a specified exception https://review.openstack.org/232506 | 18:50 |
*** daemontool has joined #openstack-nova | 18:50 | |
*** mgoddard has joined #openstack-nova | 18:50 | |
mriedem | alex_xu: is ting zhang a person or a bot (running intel CI)? | 18:50 |
*** paul-carlton has quit IRC | 18:50 | |
mriedem | nevermind, not intel | 18:51 |
mriedem | hmm, what is http://openstratus-gerrit-3993.phx-os1.stratus.dev.ebay.com:9090/job/test-gerrit-plugin-2/11/ ? | 18:51 |
mriedem | anteaya: have you heard of a ting zhang? | 18:51 |
mriedem | doing 3rd party CI? | 18:51 |
*** snikitin2 has quit IRC | 18:52 | |
*** ctrath has quit IRC | 18:53 | |
*** rlrossit has quit IRC | 18:53 | |
*** paul-carlton has joined #openstack-nova | 18:53 | |
anteaya | I have not | 18:54 |
mriedem | i guess ebay 3rd party ci... | 18:54 |
anteaya | what patch? | 18:55 |
openstackgerrit | Harshada Mangesh Kakad proposed openstack/python-novaclient: nova list with unicode VM name gives UnicodeEncodeError https://review.openstack.org/245736 | 18:55 |
mriedem | several | 18:55 |
mriedem | e.g. https://review.openstack.org/#/c/231720/ | 18:55 |
anteaya | I had a mighty good chat with a John? from ebay at the operators summit | 18:55 |
jichen | mriedem: ting zhang very like a chinese name :), ting is given name and zhang is faimiy name | 18:55 |
mriedem | jichen: yeah, i assumed :) | 18:56 |
jichen | yeah :) | 18:56 |
mriedem | i'm wondering more why they are running 3rd party ci | 18:56 |
anteaya | they can't use a personal account for automated purposes | 18:56 |
anteaya | I'm shutting them off | 18:56 |
mriedem | that's what it looks like they are doing | 18:56 |
mriedem | ok | 18:56 |
openstackgerrit | Diana Clarke proposed openstack/nova: Remove IN-predicate warnings https://review.openstack.org/240638 | 18:56 |
mriedem | build started, build successful | 18:57 |
anteaya | thanks for letting me know | 18:57 |
mriedem | using someone's email | 18:57 |
mriedem | np | 18:57 |
anteaya | yup | 18:57 |
anteaya | or theirs | 18:57 |
*** ctrath has joined #openstack-nova | 18:57 | |
*** doug-fis_ has joined #openstack-nova | 18:58 | |
*** prashup has quit IRC | 18:58 | |
*** rlrossit has joined #openstack-nova | 19:00 | |
*** pratikma_ is now known as pratikmallya | 19:00 | |
*** penick has quit IRC | 19:00 | |
*** doug-fi__ has joined #openstack-nova | 19:00 | |
*** paul-carlton has quit IRC | 19:00 | |
*** haomaiwang has quit IRC | 19:01 | |
*** doug-fish has quit IRC | 19:01 | |
*** haomaiwang has joined #openstack-nova | 19:01 | |
*** doug-fis_ has quit IRC | 19:02 | |
*** penick has joined #openstack-nova | 19:03 | |
*** Guest29831 is now known as mfisch | 19:04 | |
*** mfisch is now known as Guest80875 | 19:04 | |
*** burt has joined #openstack-nova | 19:05 | |
*** penick has quit IRC | 19:05 | |
*** daemontool has quit IRC | 19:05 | |
*** armax has joined #openstack-nova | 19:05 | |
*** Guest17963 is now known as med_ | 19:05 | |
*** med_ has joined #openstack-nova | 19:05 | |
anteaya | sorry it was John from Walmart I had a good chat with | 19:06 |
anteaya | not seeing Don Kehn on irc atm, he gets paid by eBay I think right now | 19:07 |
*** vilobhmm1 has joined #openstack-nova | 19:07 | |
*** emagana has quit IRC | 19:08 | |
*** emagana has joined #openstack-nova | 19:08 | |
*** vilobhmm has quit IRC | 19:09 | |
*** armax has quit IRC | 19:09 | |
dansmith | diana_clarke: I will re-apply the +2 immediately if you fix the comment | 19:11 |
diana_clarke | dansmith: will do, thanks! | 19:12 |
*** tdurakov_ has quit IRC | 19:12 | |
*** penick has joined #openstack-nova | 19:14 | |
*** rfolco has quit IRC | 19:17 | |
*** sudipto has quit IRC | 19:18 | |
*** lpetrut has quit IRC | 19:21 | |
*** yassine has quit IRC | 19:23 | |
*** armax has joined #openstack-nova | 19:23 | |
*** mdrabe has joined #openstack-nova | 19:24 | |
*** edtubill has quit IRC | 19:25 | |
*** salv-orlando has joined #openstack-nova | 19:25 | |
*** browne has joined #openstack-nova | 19:27 | |
*** armax has quit IRC | 19:27 | |
*** edtubill has joined #openstack-nova | 19:30 | |
*** sahid has joined #openstack-nova | 19:30 | |
*** rk4n has joined #openstack-nova | 19:30 | |
*** browne has quit IRC | 19:30 | |
*** sahid has quit IRC | 19:31 | |
*** mlavalle has joined #openstack-nova | 19:32 | |
mlavalle | johnthetubaguy: ping | 19:32 |
*** tjones has left #openstack-nova | 19:34 | |
*** rk4n has quit IRC | 19:36 | |
*** vilobhmm1 has quit IRC | 19:39 | |
*** vilobhmm has joined #openstack-nova | 19:39 | |
*** vilobhmm has quit IRC | 19:41 | |
*** vilobhmm has joined #openstack-nova | 19:42 | |
*** josecastroleon has joined #openstack-nova | 19:42 | |
openstackgerrit | Ed Leafe proposed openstack/nova-specs: Configurable Resource Tracker https://review.openstack.org/245940 | 19:42 |
edleafe | johnthetubaguy: bauzas: lxsli: jaypipes: ^^ | 19:43 |
*** tdurakov_ has joined #openstack-nova | 19:43 | |
openstackgerrit | Lianhao Lu proposed openstack/nova-specs: Add new API to list compute node metric names https://review.openstack.org/180049 | 19:45 |
*** josecastroleon has quit IRC | 19:46 | |
*** electrocucaracha has joined #openstack-nova | 19:48 | |
*** ijuwang has joined #openstack-nova | 19:48 | |
*** irenab has joined #openstack-nova | 19:50 | |
*** READ10 has joined #openstack-nova | 19:50 | |
*** pixelbeat has quit IRC | 19:53 | |
*** rk4n has joined #openstack-nova | 19:54 | |
*** whenry_ has joined #openstack-nova | 19:54 | |
*** samueldmq has quit IRC | 19:55 | |
*** s1rp has joined #openstack-nova | 19:56 | |
*** rotbeard has quit IRC | 19:56 | |
*** pixelbeat has joined #openstack-nova | 19:56 | |
*** salv-orlando has quit IRC | 19:56 | |
*** s1rp_ has quit IRC | 19:57 | |
*** melwitt has quit IRC | 19:57 | |
*** maurosr has quit IRC | 19:58 | |
*** melwitt has joined #openstack-nova | 19:58 | |
*** tonytan4ever has quit IRC | 19:58 | |
*** 7JTAASV77 has quit IRC | 19:58 | |
*** maurosr has joined #openstack-nova | 19:58 | |
*** zzzeek has quit IRC | 19:58 | |
*** rcernin has quit IRC | 19:58 | |
*** kevinbenton has quit IRC | 19:59 | |
*** kevinbenton has joined #openstack-nova | 19:59 | |
*** strictlyb has joined #openstack-nova | 20:01 | |
*** haomaiwang has quit IRC | 20:01 | |
*** zzzeek has joined #openstack-nova | 20:01 | |
*** haomaiwang has joined #openstack-nova | 20:01 | |
*** penick has quit IRC | 20:02 | |
*** IanGovett has joined #openstack-nova | 20:03 | |
*** ZZelle_ has joined #openstack-nova | 20:06 | |
*** mgoddard has quit IRC | 20:06 | |
*** penick has joined #openstack-nova | 20:06 | |
*** eglynn_ has joined #openstack-nova | 20:07 | |
*** eglynn has quit IRC | 20:07 | |
*** pixelbeat has quit IRC | 20:08 | |
*** rushil has joined #openstack-nova | 20:09 | |
*** ctrath has quit IRC | 20:09 | |
*** e0ne has quit IRC | 20:09 | |
*** Marga_ has quit IRC | 20:12 | |
*** salv-orlando has joined #openstack-nova | 20:14 | |
*** whenry_ has quit IRC | 20:14 | |
*** lpetrut has joined #openstack-nova | 20:15 | |
*** tonytan4ever has joined #openstack-nova | 20:15 | |
*** tdurakov_ has quit IRC | 20:19 | |
*** mwagner has quit IRC | 20:19 | |
*** mwagner has joined #openstack-nova | 20:21 | |
*** ctrath has joined #openstack-nova | 20:21 | |
*** tdurakov_ has joined #openstack-nova | 20:22 | |
*** liverpooler has quit IRC | 20:23 | |
*** lucasagomes is now known as lucas-afk | 20:23 | |
mriedem | alaski: might want to make sure i'm not smoking crack here https://review.openstack.org/#/c/244789/ | 20:23 |
mriedem | since i don't review much xen code | 20:23 |
mriedem | pretty sure there is an upgrade impact there | 20:23 |
*** ctrath has quit IRC | 20:24 | |
*** doug-fi__ is now known as doug-fish | 20:24 | |
*** baoli_ has quit IRC | 20:27 | |
*** sripriya has joined #openstack-nova | 20:27 | |
*** rlrossit has quit IRC | 20:28 | |
alaski | mriedem: yeah, destroy would definitely be broken | 20:28 |
*** sripriya_ has joined #openstack-nova | 20:29 | |
alaski | well, maybe not in general. but for a specific case it would be | 20:29 |
mriedem | destroy with a volume attached before that change | 20:30 |
mriedem | right | 20:30 |
*** ctrath has joined #openstack-nova | 20:31 | |
*** rlrossit has joined #openstack-nova | 20:32 | |
alaski | typically the volume sr is looked up by backtracking from the instance->VBD->SR so it doesn't matter what the SR uuid actually is | 20:32 |
alaski | but there's a case where the instance is gone and the SR is still attached, and there we look up by what the SR uuid should be | 20:32 |
*** sripriya has quit IRC | 20:34 | |
*** aginwala has joined #openstack-nova | 20:34 | |
alaski | from a quick look that's the only case that wouldn't be handled | 20:35 |
*** changbl has quit IRC | 20:36 | |
*** Piet has joined #openstack-nova | 20:36 | |
mriedem | yeah that's what i found | 20:37 |
mriedem | when detaching the volume it uses the device mountpoint | 20:37 |
mriedem | not the sr uuid | 20:37 |
*** matrohon has joined #openstack-nova | 20:40 | |
*** otter768 has joined #openstack-nova | 20:42 | |
*** schwicke has joined #openstack-nova | 20:42 | |
melwitt | mriedem: what do you think the state of this bug should be set to now? I don't think it should be Fixed Released but I wasn't sure whether to set it back to Confirmed or if you might think it's Invalid at this point? https://bugs.launchpad.net/nova/+bug/1323658 | 20:42 |
openstack | Launchpad bug 1323658 in OpenStack Compute (nova) "Nova resize/restart results in guest ending up in inconsistent state with Neutron" [Medium,Fix released] - Assigned to Dariusz Smigiel (smigiel-dariusz) | 20:42 |
mriedem | melwitt: there wasn't an official nova fix, just some logging changes that i added from what i recall | 20:44 |
mriedem | i guess we can call those fix released? | 20:44 |
*** IanGovett has quit IRC | 20:44 | |
mriedem | idk, if it's fixed it was probably fixed in neutron somehow | 20:44 |
*** moshele has joined #openstack-nova | 20:44 | |
*** suro-patz has quit IRC | 20:45 | |
melwitt | mriedem: yeah, they set it to Fix Released because they couldn't reproduce the problem in devstack | 20:46 |
*** READ10 has quit IRC | 20:46 | |
*** otter768 has quit IRC | 20:46 | |
mriedem | works for me | 20:47 |
*** rpodolyaka1 has quit IRC | 20:47 | |
mriedem | if someone asked what the fix was or when it was released.... | 20:47 |
mriedem | we'll just act like we didn't hear the question | 20:47 |
*** baoli has joined #openstack-nova | 20:47 | |
*** suro-patz has joined #openstack-nova | 20:47 | |
bauzas | meh, why not Won't fix then ? | 20:48 |
* bauzas loves interrupting people :) | 20:48 | |
*** baoli has quit IRC | 20:48 | |
*** rpodolyaka1 has joined #openstack-nova | 20:48 | |
*** schwicke has quit IRC | 20:48 | |
*** baoli has joined #openstack-nova | 20:48 | |
melwitt | usually we wouldn't put Fix Committed or Fix Released if there's no patch cited | 20:48 |
*** sripriya has joined #openstack-nova | 20:48 | |
bauzas | melwitt: yeah, my take | 20:48 |
*** ekarlso has quit IRC | 20:50 | |
*** ekarlso has joined #openstack-nova | 20:50 | |
melwitt | Won't Fix makes sense I think, I'll change it to that | 20:50 |
mriedem | umm | 20:50 |
mriedem | i'd just mark as invalid if you're going to do that | 20:50 |
bauzas | sec, checking a release process change with launchpad | 20:50 |
mriedem | it's not like we won't fix the thing, it's that we never could figure it out and now it's not a problem | 20:50 |
*** aginwala has quit IRC | 20:50 | |
bauzas | IIRC, there will no longer be Fix Released | 20:51 |
*** sripriya_ has quit IRC | 20:51 | |
*** aginwala has joined #openstack-nova | 20:51 | |
melwitt | yeah, okay | 20:51 |
bauzas | fair enough | 20:52 |
*** yamahata has joined #openstack-nova | 20:55 | |
*** jichen has quit IRC | 20:55 | |
*** aginwala has quit IRC | 20:56 | |
dansmith | alaski: are you working on this or do you need help? https://review.openstack.org/#/c/211753/ | 20:59 |
*** aginwala has joined #openstack-nova | 21:00 | |
*** haomaiwang has quit IRC | 21:01 | |
*** haomaiwang has joined #openstack-nova | 21:01 | |
alaski | dansmith: I'm working on it. I had to rework some assumptions in the tests, which are ultimately making them better I think | 21:01 |
dansmith | okay | 21:01 |
*** rpodolyaka1 has quit IRC | 21:02 | |
bauzas | dansmith: rereading reno usage, it seems that the prelude section is for each release http://docs.openstack.org/developer/reno/usage.html#editing-a-release-note | 21:04 |
dansmith | ah | 21:04 |
dansmith | I didn't grok that any of them were optional until after I got past that | 21:05 |
bauzas | dansmith: so, I'm currently trying to see what could happen when we have multiple relnotes for the same release | 21:05 |
dansmith | bauzas: okay.. still kinda seems like it's worth a general note for something as major as needing a new DB | 21:05 |
bauzas | dansmith: yup, I feel it's okay, I just need to see what happens | 21:05 |
dansmith | okay | 21:06 |
dansmith | I bet dhellmann knows | 21:06 |
bauzas | fersur | 21:06 |
tonyb | bauzas: sup? | 21:06 |
tonyb | markus_z: Still around? | 21:06 |
bauzas | tonyb: heh, goodness | 21:07 |
bauzas | tonyb: this morning, we had a cells issue for liberty, remember? | 21:07 |
bauzas | tonyb: it's fixed | 21:07 |
tonyb | bauzas: woot! | 21:07 |
*** rpodolyaka1 has joined #openstack-nova | 21:07 | |
tonyb | bauzas: DO you have a link to the bug/review? | 21:07 |
bauzas | tonyb: yup | 21:07 |
tonyb | Oh "cells is a sad panda about scheduler hints"? | 21:08 |
*** raildo is now known as raildo-afk | 21:08 | |
bauzas | https://review.openstack.org/#/c/245712/ | 21:08 |
bauzas | right | 21:08 |
* tonyb sees it in his inbox | 21:08 | |
tonyb | bauzas: Thanks for lettign me know. | 21:08 |
bauzas | np | 21:08 |
tonyb | bauzas: Also Congrats! | 21:09 |
bauzas | :) | 21:09 |
*** rpodolyaka1 has quit IRC | 21:09 | |
*** sileht has quit IRC | 21:09 | |
*** smatzek has quit IRC | 21:11 | |
*** tdurakov_ has quit IRC | 21:11 | |
*** tdurakov_ has joined #openstack-nova | 21:13 | |
openstackgerrit | Mitsuhiro Tanino proposed openstack/nova-specs: Volume support for multi hypervisors https://review.openstack.org/245986 | 21:14 |
openstackgerrit | Matt Riedemann proposed openstack/nova: xen: mask auth_password in StorageError raised from _parse_volume_info https://review.openstack.org/245987 | 21:14 |
bauzas | dansmith: yeah, so it merges all the YAML files into the same HTML for each section | 21:15 |
*** dustins has quit IRC | 21:16 | |
*** tonytan4ever has quit IRC | 21:17 | |
*** jamielennox|away is now known as jamielennox | 21:18 | |
bauzas | dansmith: okay, so if another relnote provides another prelude, it's trampled by your change | 21:18 |
bauzas | dansmith: trying to see whether we can bullet your change | 21:18 |
bauzas | oh sec, no | 21:20 |
bauzas | dansmith: okay, it's all good... I just forgot to commit my local yaml | 21:20 |
openstackgerrit | Diana Clarke proposed openstack/nova: Use ServiceList object rather than direct db call https://review.openstack.org/243694 | 21:21 |
*** vladikr has quit IRC | 21:21 | |
mriedem | i was wondering about prelude in multiple release notes | 21:22 |
mriedem | the docs say they are aggregated, i thought | 21:22 |
mriedem | but it does say 'general info about the release' | 21:22 |
*** doug-fish has quit IRC | 21:24 | |
bauzas | mriedem: yup, they are merged | 21:24 |
bauzas | mriedem: I just checked that | 21:25 |
*** pratikmallya has quit IRC | 21:25 | |
*** doug-fish has joined #openstack-nova | 21:25 | |
*** baoli has quit IRC | 21:25 | |
*** sripriya_ has joined #openstack-nova | 21:25 | |
*** tonytan4ever has joined #openstack-nova | 21:26 | |
*** aginwala has quit IRC | 21:26 | |
bauzas | mriedem: so the prelude comment looks good to me, it's quite general | 21:27 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add relnote for ERT deprecation https://review.openstack.org/245993 | 21:27 |
*** sripriya__ has joined #openstack-nova | 21:27 | |
*** alex_klimov has joined #openstack-nova | 21:29 | |
*** rpodolyaka1 has joined #openstack-nova | 21:30 | |
*** sripriya has quit IRC | 21:30 | |
*** sripriya_ has quit IRC | 21:30 | |
*** daemontool has joined #openstack-nova | 21:32 | |
*** suro-patz has quit IRC | 21:33 | |
*** suro-patz has joined #openstack-nova | 21:33 | |
*** jaypipes has quit IRC | 21:35 | |
*** markvoelker has quit IRC | 21:37 | |
*** pratikmallya has joined #openstack-nova | 21:38 | |
*** pratikma_ has joined #openstack-nova | 21:39 | |
*** thangp has quit IRC | 21:42 | |
*** pratikmallya has quit IRC | 21:43 | |
*** moshele has quit IRC | 21:43 | |
*** pratikma_ has quit IRC | 21:45 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Scheduler RPC API select_dests() https://review.openstack.org/199205 | 21:45 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify left filters for RequestSpec https://review.openstack.org/202678 | 21:45 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Prepare filters for using RequestSpec object https://review.openstack.org/197912 | 21:45 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify conductor to use RequestSpec object https://review.openstack.org/203078 | 21:45 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify metric-related filters for RequestSpec https://review.openstack.org/202676 | 21:45 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Use RequestSpec in the ChanceScheduler https://review.openstack.org/199051 | 21:45 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify NUMA, PCI and num_instances filters for RequestSpec https://review.openstack.org/202677 | 21:45 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Aggregate filters for RequestSpec https://review.openstack.org/202674 | 21:45 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify default filters for RequestSpec https://review.openstack.org/202675 | 21:45 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Affinity filter for RequestSpec https://review.openstack.org/202673 | 21:45 |
*** rushil has quit IRC | 21:47 | |
*** aginwala has joined #openstack-nova | 21:48 | |
dansmith | bauzas: wait, I don't understand.. there can only be one prelude? | 21:48 |
bauzas | dansmith: no | 21:48 |
bauzas | dansmith: I confused you, sorry | 21:49 |
bauzas | dansmith: there can be multiple preludes | 21:49 |
bauzas | dansmith: I was confused because reno checks the git commits while I was creating a local yaml file without adding a new patch | 21:50 |
*** tonytan4ever has quit IRC | 21:50 | |
dansmith | okay I'm still confused, but that's fine | 21:50 |
bauzas | dansmith: to be clear, there can be multiple changes with a prelude section | 21:50 |
dansmith | right | 21:51 |
bauzas | dansmith: when building the HTML, reno merges all preludes into the same paragraph | 21:51 |
dansmith | agh | 21:51 |
dansmith | I see | 21:51 |
bauzas | (by adding a new line) | 21:51 |
*** Marga_ has joined #openstack-nova | 21:52 | |
bauzas | dansmith: so we need to have preludes quite general, but yours looks fine to me | 21:52 |
dhellmann | the prelude is really meant to summarize a release or highlight a big new thing in the release, so it shouldn't be used for every note | 21:53 |
dansmith | this fits that description | 21:54 |
bauzas | yup | 21:54 |
bauzas | hence my +2 | 21:54 |
dhellmann | k | 21:55 |
*** tonytan4ever has joined #openstack-nova | 21:55 | |
bauzas | mriedem: just saw the OSSN notice for TrustedFilter on -dev | 21:55 |
bauzas | mriedem: since https://review.openstack.org/#/c/194592/ was not having an UpgradeImpact, we missed the opportunity to say to the operators "eh, your dog" | 21:55 |
bauzas | mriedem: do you think we should add a note to the liberty branch ? | 21:56 |
bauzas | or modify the wiki relnotes? | 21:57 |
mriedem | bauzas: marking it experimental was in master | 21:57 |
bauzas | mriedem: https://review.openstack.org/#/c/194592/5/setup.cfg was merged for liberty, right? | 21:57 |
mriedem | it's marked as experimental in the docs and in the logs if you use it, so i don't think we need a release note update for it | 21:57 |
bauzas | mriedem: okay, fair enough but I'm a bit unhappy by seeing the OSSN | 21:58 |
*** daemontool has quit IRC | 21:58 | |
*** matrohon has quit IRC | 21:59 | |
mriedem | bauzas: no, that landed in master | 21:59 |
*** daemontool has joined #openstack-nova | 21:59 | |
mriedem | according to the 'included in' thing in gerrit | 22:00 |
mriedem | btw, what do you mean by 'eh, your dog' | 22:00 |
mriedem | ? | 22:00 |
bauzas | eh, your problem | 22:00 |
*** changbl has joined #openstack-nova | 22:00 | |
*** rpodolyaka1 has quit IRC | 22:00 | |
*** haomaiwang has quit IRC | 22:01 | |
mriedem | marking something as experimental doesn't mean we don't have to handle security issues in it | 22:01 |
bauzas | mriedem: okay, I trust you, I'm just confused by the setup.cfg file and the merge date | 22:01 |
*** haomaiwang has joined #openstack-nova | 22:01 | |
bauzas | mriedem: fair point, I just wrote a long email about that one :) | 22:01 |
mriedem | there is no setup.cfg change in that review | 22:02 |
*** dustins has joined #openstack-nova | 22:02 | |
mriedem | 11pm | 22:02 |
mriedem | time to call it a ball | 22:02 |
mriedem | :) | 22:02 |
bauzas | mriedem: I play with the URL to get https://review.openstack.org/#/c/194592/5/setup.cfg | 22:02 |
bauzas | hah | 22:02 |
*** vilobhmm has quit IRC | 22:03 | |
mriedem | that doesn't show me anythin | 22:03 |
*** vilobhmm has joined #openstack-nova | 22:03 | |
bauzas | mriedem: oh, probably because you're still using the old change view in Gerrit UI | 22:03 |
mriedem | yup | 22:03 |
mriedem | i'll never let go | 22:03 |
bauzas | heh, old Gerrit UI = http://www.commitstrip.com/en/2015/09/28/scumbag-chrome/ | 22:04 |
bauzas | and currently watching https://en.wikipedia.org/wiki/Kaamelott at the same time so I'm safe :) | 22:04 |
*** klindgren has joined #openstack-nova | 22:06 | |
*** thorst_ has quit IRC | 22:07 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: xen: mask passwords in volume connection_data dict https://review.openstack.org/245987 | 22:07 |
openstackgerrit | Bob Ball proposed openstack/nova: XenAPI: Cope with more Cinder backends https://review.openstack.org/244789 | 22:07 |
*** thorst_ has joined #openstack-nova | 22:07 | |
*** ekarlso has quit IRC | 22:11 | |
dansmith | my change to add a single text file for reno is failing all unit tests | 22:12 |
*** thorst_ has quit IRC | 22:12 | |
* dansmith waits for jenkins' BS answer | 22:12 | |
*** aysyd has quit IRC | 22:13 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Remove skips for resize tests from tempest-dsvm-cells-rc https://review.openstack.org/242594 | 22:14 |
klindgren | is Alexandre Levine here? If so could you ping me re: the user_data modification spec? Wondering how thats going to work with config-drive since config drive basically never gets recreated? | 22:15 |
mriedem | dansmith: oslo releases today | 22:15 |
*** tdurakov_ has quit IRC | 22:15 | |
mriedem | dansmith: have some logs? | 22:15 |
dansmith | mriedem: lovely | 22:15 |
dansmith | not yet | 22:15 |
dansmith | waiting for it to finish | 22:15 |
mriedem | http://logs.openstack.org/20/243320/4/gate/gate-nova-python27/37b1b32/console.html | 22:16 |
mriedem | ovo | 22:16 |
mriedem | looks like infinite recursion | 22:16 |
dansmith | cripes | 22:16 |
*** pratikmallya has joined #openstack-nova | 22:17 | |
mriedem | https://bugs.launchpad.net/nova/+bug/1516805 | 22:17 |
openstack | Launchpad bug 1516805 in OpenStack Compute (nova) "nova unit tests failing with infinite recursion with oslo.versionedobjects 0.13.0" [Undecided,New] | 22:17 |
*** jhesketh has quit IRC | 22:17 | |
*** lpetrut has quit IRC | 22:17 | |
dims | mriedem : dansmith : o.vo regression? | 22:18 |
*** pratikma_ has joined #openstack-nova | 22:18 | |
dansmith | I'm trying to figure out what we've even changed | 22:18 |
dansmith | lately | 22:18 |
*** alex_klimov has quit IRC | 22:18 | |
*** pratikmallya has quit IRC | 22:18 | |
*** jhesketh has joined #openstack-nova | 22:18 | |
*** rlrossit has left #openstack-nova | 22:19 | |
*** pratikmallya has joined #openstack-nova | 22:19 | |
dims | dansmith http://logs.openstack.org/65/245465/1/check/gate-releases-tox-list-changes/426cf54/console.html#_2015-11-15_03_30_30_526 | 22:19 |
*** rlrossit has joined #openstack-nova | 22:20 | |
dansmith | yeah, I think there's only one functional change in that list | 22:20 |
mriedem | dansmith: dims: changes https://gist.github.com/mriedem/bffd9d16c440c0da5a76 | 22:20 |
*** doug-fish has quit IRC | 22:20 | |
mriedem | c85f3bb | 22:20 |
mriedem | that's the one | 22:20 |
*** rlrossit has left #openstack-nova | 22:20 | |
*** ekarlso has joined #openstack-nova | 22:20 | |
dims | mriedem if you yank that out does it work then? | 22:20 |
mriedem | https://review.openstack.org/#/c/224862/ | 22:20 |
*** doug-fish has joined #openstack-nova | 22:21 | |
*** sripriya__ has quit IRC | 22:21 | |
mriedem | umm | 22:21 |
mriedem | i'd have to get that setup locally first | 22:22 |
dansmith | do we use that fixture in nova? | 22:22 |
mriedem | http://logs.openstack.org/20/243320/4/gate/gate-nova-python27/37b1b32/console.html#_2015-11-16_21_00_30_238 | 22:22 |
mriedem | we must | 22:22 |
*** pratikma_ has quit IRC | 22:22 | |
dims | mriedem dansmith i got to step out for a bit, i can push a .1 release if needed quickly that's the quickest way to untangle (g-r blocks take for ever). | 22:23 |
suro-patz | jpipes: dansmith: jwcroppe: request your attention to https://review.openstack.org/#/c/243825/ | 22:23 |
mriedem | dansmith: seems like a problem with the mock... | 22:23 |
*** pumaranikar has quit IRC | 22:24 | |
dansmith | dims: if it's just to remove that from the fixture, then that's a no brainer | 22:24 |
mriedem | it's barfing here https://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_floating_ip.py#L171 | 22:24 |
*** pumaranikar has joined #openstack-nova | 22:24 | |
*** IanGovett has joined #openstack-nova | 22:24 | |
*** doug-fish has quit IRC | 22:24 | |
mriedem | ah | 22:25 |
mriedem | it's this fa7b1afb924b3d863d37a9f617e55027382df933 | 22:25 |
dansmith | yeah, that's the functional change | 22:25 |
mriedem | yup, the recursion is there | 22:25 |
dansmith | we already had that in nova before o.vo | 22:25 |
dansmith | because we had to get that in for liberty | 22:25 |
dansmith | the fixture might fix it too | 22:26 |
dansmith | the problem is, removing that is a breaking API change to the library | 22:26 |
jwcroppe | suro-parts: Re: bug https://bugs.launchpad.net/nova/+bug/1514997 ... what did you expect the percentages to be? | 22:26 |
openstack | Launchpad bug 1514997 in OpenStack Compute (nova) "Metrics filter receives wrong metric value" [Undecided,In progress] - Assigned to Surojit Pathak (suro-patz) | 22:26 |
dansmith | but if we do it quickly it's probably better than lots of damage | 22:26 |
mriedem | sdague: can you push this through? https://review.openstack.org/#/c/246002/ | 22:26 |
dansmith | and we probably need to revert the fixture to go with it | 22:26 |
jwcroppe | suro-patz: ^^^ | 22:26 |
mriedem | dansmith: we can block 0.13.0 and figure it out | 22:26 |
*** jamielennox is now known as jamielennox|away | 22:27 | |
dansmith | that takes longer though right? | 22:27 |
mriedem | yeah | 22:27 |
dansmith | I guess if it's just nova unit tests it's not too bad | 22:27 |
mriedem | let me check | 22:27 |
*** yamahata has quit IRC | 22:27 | |
mriedem | should only be nova | 22:27 |
jwcroppe | suro-patz: the percentages are represented as ints, so it's possible that some small non-zero value will become 0 | 22:27 |
*** aginwala has quit IRC | 22:28 | |
mriedem | hmm, logstash is only showing this on one change | 22:28 |
mriedem | that can't be right though | 22:29 |
*** aginwala has joined #openstack-nova | 22:29 | |
dansmith | I'm sure mine is hitting it too | 22:29 |
dansmith | py27 and py34 fail on a new reno file | 22:29 |
*** doug-fish has joined #openstack-nova | 22:29 | |
*** pixelbeat has joined #openstack-nova | 22:29 | |
suro-patz | jwcroppe: IFAIK, percentages are stored as a normalized value in [0,1] - the commit https://github.com/openstack/nova/commit/87e1d8fab2b5888e711f07001025600fe709aaa7 was by you only | 22:30 |
suro-patz | jwcroppe: now, nova-scheduler reads this value, as object, with Integer as field type | 22:30 |
mriedem | dansmith: yeah logstash is just not up to date | 22:30 |
dansmith | ah, wait | 22:31 |
suro-patz | jwcroppe: any value in [0,1), typecast as Integer will become 0 obviously | 22:31 |
dansmith | mriedem: faster fix I think | 22:31 |
dansmith | and the right one | 22:31 |
dansmith | it's because of the mock in our fixture because of how we do our registry right now | 22:32 |
jwcroppe | suro-patz: the values always were stored as floating points in the DB. | 22:32 |
*** thorst_ has joined #openstack-nova | 22:32 | |
*** dave-mccowan has quit IRC | 22:32 | |
suro-patz | jwcroppe: as the metrics are CPU percentage, it is more likely to get a zero value - I suggest you going through the review/bug - https://review.openstack.org/#/c/243825/1, https://bugs.launchpad.net/nova/+bug/1514997, whenever you have time | 22:33 |
openstack | Launchpad bug 1514997 in OpenStack Compute (nova) "Metrics filter receives wrong metric value" [Undecided,In progress] - Assigned to Surojit Pathak (suro-patz) | 22:33 |
jwcroppe | suro-patz: so the fix we did before was to convert from int --> float when the message goes out over the message queue | 22:33 |
*** aginwala has quit IRC | 22:33 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Block oslo.versionedobjects 0.13.0 https://review.openstack.org/246011 | 22:33 |
mriedem | dansmith: ok | 22:33 |
dansmith | mriedem: bug for this yet? | 22:33 |
*** vilobhmm has quit IRC | 22:33 | |
mriedem | https://bugs.launchpad.net/oslo.versionedobjects/+bug/1516805 | 22:33 |
openstack | Launchpad bug 1516805 in OpenStack Compute (nova) "nova unit tests failing with infinite recursion with oslo.versionedobjects 0.13.0" [Undecided,In progress] - Assigned to Matt Riedemann (mriedem) | 22:33 |
*** vilobhmm has joined #openstack-nova | 22:34 | |
suro-patz | jwcroppe: https://github.com/openstack/nova/blob/master/nova/objects/monitor_metric.py#L40 still refers the field as Integer and that's where the bug is | 22:34 |
*** doug-fish has quit IRC | 22:34 | |
*** ZZelle_ has quit IRC | 22:34 | |
*** jaypipes has joined #openstack-nova | 22:34 | |
dims | mriedem if it is just nova unit tests, why block entirely? | 22:34 |
dansmith | dims: mriedem : | 22:35 |
openstackgerrit | Dan Smith proposed openstack/nova: Fix Nova's indirection fixture override https://review.openstack.org/246013 | 22:35 |
dansmith | mriedem: see the override just above this one | 22:35 |
dansmith | I need to finish cleaning that up, but this is the easy fix for the moment | 22:35 |
suro-patz | jwcroppe: I suggest add some print statements printing the cpu.percentage values in MetricsFilter, with the config suggested in https://bugs.launchpad.net/nova/+bug/1514997 , and you will find that all of those percent values are coming as 0 | 22:35 |
openstack | Launchpad bug 1514997 in OpenStack Compute (nova) "Metrics filter receives wrong metric value" [Undecided,In progress] - Assigned to Surojit Pathak (suro-patz) | 22:35 |
dansmith | mriedem: fixes one test I tried locally, doing a full run again now | 22:36 |
suro-patz | jwcroppe: host_state.metrics /value | 22:36 |
dansmith | but should be obvious fix | 22:36 |
*** thorst_ has quit IRC | 22:36 | |
mriedem | dansmith: so copies the fixture from ovo | 22:36 |
mriedem | and that will be fine with ovo < 0.13.0 since it wouldn't be used | 22:36 |
dansmith | mriedem: yes | 22:36 |
mriedem | ok, what's the TODO on removing that? | 22:37 |
jwcroppe | suro-patz: have you looked at the values in the compute_nodes.metrics column? | 22:37 |
dansmith | mriedem: I need to look.. probably just removing more of nova's now-duplicated stuff, but might need to break something into pieces | 22:37 |
*** edtubill has quit IRC | 22:38 | |
dansmith | mriedem: oh, right, so this is because we have to subclass the o.vo registry... so I probably need to just do some monkeying with mocks or something | 22:38 |
jwcroppe | suro-patz: I'm not asserting that the filter is working properly (that may well be a lingering issue we need to fix), but I'm just wondering if you have looked at the data in the database as well to check the values? | 22:38 |
mriedem | dansmith: yeah, i commented in your review, our fake indirection hack extends the ovo fixture indirection api, so why wouldn't we just get that one? | 22:39 |
mriedem | oh i see | 22:40 |
suro-patz | jwcroppe: the data in db looks fine. I had captured that at https://bugs.launchpad.net/nova/+bug/1514997 and mentioned that in the bug too | 22:40 |
openstack | Launchpad bug 1514997 in OpenStack Compute (nova) "Metrics filter receives wrong metric value" [Undecided,In progress] - Assigned to Surojit Pathak (suro-patz) | 22:40 |
mriedem | nova registery | 22:40 |
suro-patz | jwcroppe: http://paste.openstack.org/show/478481/ | 22:40 |
dansmith | mriedem: hmm, some other completely different fails.. let me look at those first | 22:41 |
jwcroppe | suro-patz: ok, so the data in the DB is correct | 22:41 |
jwcroppe | suro-patz: (which is also the same data that is sent out via the message queue for recipients like Ceilometer) | 22:41 |
suro-patz | jwcroppe: that's what I mentioned, the issue is in reading the data from DB as object | 22:42 |
mriedem | dims: we'd block in g-r so we can block in nova, if we need to | 22:42 |
mriedem | doesn't matter if it's only nova | 22:42 |
suro-patz | jwcroppe: we are trying to read a float as Integer and thus losing the data most of the time given the type of the data and the normalization | 22:42 |
*** otter768 has joined #openstack-nova | 22:43 | |
jwcroppe | suro-patz: ok, yep... so the code reading the data is busted. That makes sense. | 22:43 |
suro-patz | jwcroppe: cool! | 22:43 |
*** aginwala has joined #openstack-nova | 22:43 | |
suro-patz | jwcroppe: Whenever you have time, if you can chime into the review, it would be great … | 22:43 |
jwcroppe | suro-patz: yeah, I will do that. thanks for catching this... looks like the effects of the original bug had a few other tentacles out there | 22:44 |
suro-patz | as jpipes: also was referring to the earlier check-in of https://github.com/openstack/nova/commit/87e1d8fab2b5888e711f07001025600fe709aaa7 | 22:44 |
suro-patz | jwcroppe: thanks! | 22:45 |
jwcroppe | speaking of tentacles, that is dansmith's favorite thing | 22:45 |
* dansmith barfs all over jwcroppe | 22:45 | |
jwcroppe | lol | 22:46 |
mriedem | people pay for that in some corners of the internet | 22:46 |
*** tongli has quit IRC | 22:46 | |
openstackgerrit | Dan Smith proposed openstack/nova: Fix Nova's indirection fixture override https://review.openstack.org/246013 | 22:47 |
dansmith | mriedem: first time is free | 22:47 |
dansmith | mriedem: ^^ fixed, with fixme | 22:47 |
*** otter768 has quit IRC | 22:47 | |
mriedem | question inline | 22:50 |
*** jwang_ has joined #openstack-nova | 22:51 | |
*** apoorvad_ has joined #openstack-nova | 22:51 | |
dansmith | I was typing out an explanation because I knew it would trip you up :) | 22:51 |
suro-patz | dansmith: rlrossit had suggested to get some guidance from you on obj_make_compatible() for the given scenario - I would appreciate if you can glance over https://review.openstack.org/#/c/243825/1 and comments | 22:51 |
*** baoli has joined #openstack-nova | 22:52 | |
*** masayukig has quit IRC | 22:52 | |
*** toabctl has quit IRC | 22:52 | |
*** mwagner has quit IRC | 22:52 | |
jwcroppe | suro-patz: I just left a comment | 22:53 |
dansmith | mriedem: I might be able to remove MyObj2 now, but I'll do that follow-on | 22:53 |
*** apoorvad has quit IRC | 22:53 | |
*** gridinv has quit IRC | 22:53 | |
*** greghaynes_ has quit IRC | 22:53 | |
*** shaohe_feng has quit IRC | 22:53 | |
*** lxsli has quit IRC | 22:53 | |
*** rubasov has quit IRC | 22:54 | |
*** sabari has quit IRC | 22:54 | |
*** mordred has quit IRC | 22:54 | |
*** sshen has quit IRC | 22:54 | |
*** snikitin has quit IRC | 22:54 | |
*** jeblair has quit IRC | 22:54 | |
*** rods has quit IRC | 22:54 | |
*** gridinv has joined #openstack-nova | 22:54 | |
*** jwang__ has quit IRC | 22:54 | |
*** mrodden has quit IRC | 22:54 | |
*** hwoarang has quit IRC | 22:54 | |
*** aarefiev has quit IRC | 22:54 | |
*** alaski has quit IRC | 22:54 | |
*** sshen has joined #openstack-nova | 22:54 | |
mriedem | ok, i had looked at MyObj2 and was looking for a sub object or something, but now i see the obj_name override | 22:55 |
*** sabari has joined #openstack-nova | 22:55 | |
mriedem | i'm glad you expected it to trip me up, | 22:55 |
*** hwoarang has joined #openstack-nova | 22:55 | |
*** hwoarang has joined #openstack-nova | 22:55 | |
*** burt has quit IRC | 22:55 | |
mriedem | since none of this is in no way confusing to anyone else :) | 22:55 |
dansmith | mriedem: right, because of the name override | 22:55 |
*** rubasov has joined #openstack-nova | 22:55 | |
mriedem | +2 | 22:55 |
suro-patz | jwcroppe: trying to understand your comment better - is not the proposed patch modifying to read it as float, and avoid truncation? | 22:56 |
dansmith | mriedem: well, I dunno what to say.. make it work and be less confusing and I'll sign up | 22:56 |
mriedem | jaypipes: https://review.openstack.org/#/c/246013/ | 22:56 |
*** jeblair has joined #openstack-nova | 22:56 | |
dansmith | suro-patz: you just need an obj_make_compatible() that converts that field to an integer if the desired version is less than the version in which you bumped it | 22:56 |
dansmith | suro-patz: I haven't read the rest of your patch, but that's what needs to be done for the version side of it | 22:56 |
dansmith | melwitt: you around to +W that gate-fixin' change? | 22:57 |
*** shaohe_robot has joined #openstack-nova | 22:57 | |
openstackgerrit | Andrew Laski proposed openstack/nova: Add persistence to the RequestSpec object https://review.openstack.org/211753 | 22:57 |
* melwitt emerges from cave | 22:57 | |
mriedem | melwitt: https://review.openstack.org/#/c/246013/ | 22:57 |
mriedem | dansmith: btw, we'll have to backport that to stable/liberty | 22:57 |
dansmith | okay | 22:57 |
mriedem | since we don't cap anything anymore | 22:58 |
mriedem | and upper-constraints isn't testing nova's unit tests | 22:58 |
*** brad[] has quit IRC | 22:58 | |
*** med_ has quit IRC | 22:58 | |
*** Guest80875 has quit IRC | 22:58 | |
*** brad[] has joined #openstack-nova | 22:58 | |
dansmith | mriedem: https://review.openstack.org/246022 | 22:58 |
*** mfisch has joined #openstack-nova | 22:58 | |
*** mfisch is now known as Guest73509 | 22:59 | |
*** hparekh2 has joined #openstack-nova | 22:59 | |
*** tonytan4ever has quit IRC | 22:59 | |
*** masayukig has joined #openstack-nova | 22:59 | |
*** alaski has joined #openstack-nova | 22:59 | |
*** toabctl has joined #openstack-nova | 22:59 | |
*** rods has joined #openstack-nova | 22:59 | |
*** sc68cal_ has joined #openstack-nova | 22:59 | |
*** mrodden has joined #openstack-nova | 23:00 | |
*** ssurana1 has joined #openstack-nova | 23:00 | |
*** s1rp_ has joined #openstack-nova | 23:00 | |
*** haomaiwang has quit IRC | 23:01 | |
* mriedem goes to make dinner | 23:01 | |
*** mriedem is now known as mriedem_away | 23:01 | |
*** dustins has quit IRC | 23:01 | |
mriedem_away | +2 on all those things btw | 23:01 |
melwitt | dansmith: why don't we need to do the mock and MyObj for the other TestRemoteObject tests test_minor_version_less and test_revision_ignored? | 23:01 |
suro-patz | dansmith: obj_make_compatible() change applies for the software with higher version. On writer() this change has no impact - so obj_make_compatible() won't have any impact. On reader(), the conversion to integer will re-enforce the bug itself. So does not gain us much, unless I am missing something | 23:01 |
dansmith | melwitt: because of why they fail I think | 23:01 |
*** toure has joined #openstack-nova | 23:02 | |
dansmith | melwitt: I'm going to follow up and remove MyObj2, which will force me to hit any of those remaining tests | 23:02 |
*** med_ has joined #openstack-nova | 23:02 | |
dansmith | suro-patz: it doesn't matter, you have to write the compatibility routine if you bump the object | 23:02 |
*** med_ is now known as Guest12059 | 23:02 | |
*** haomaiwa_ has joined #openstack-nova | 23:02 | |
melwitt | dansmith: okay, so this is just targeting the ones that are affected as part of the bug | 23:02 |
dansmith | melwitt: yeah, the bug is that that override wasn't in place in the fixture, but it tickled those other tests | 23:03 |
suro-patz | dansmith: it is hard to write code, which is NOP :) | 23:03 |
dansmith | suro-patz: it should be trivial | 23:03 |
suro-patz | dansmith: I know it is trivial, but if it has no impact or usefulness, should we add it? That's the question I have | 23:04 |
*** beekneemech has joined #openstack-nova | 23:05 | |
dansmith | suro-patz: if you send that object to an older node and don't have the routine, it will crash. end of story. | 23:05 |
*** raginbaj- has joined #openstack-nova | 23:06 | |
*** aarefiev has joined #openstack-nova | 23:06 | |
*** snikitin has joined #openstack-nova | 23:06 | |
melwitt | dansmith: I see test_minor_version_less and test_revision_ignored in the list of failures with recursion depth exceeded. does that mean they are failing in the same way or no? http://logs.openstack.org/20/243320/4/gate/gate-nova-python27/37b1b32/testr_results.html.gz | 23:06 |
*** dave-mccowan has joined #openstack-nova | 23:06 | |
*** abramley_ has joined #openstack-nova | 23:06 | |
*** IanGovett has quit IRC | 23:06 | |
*** s1rp has quit IRC | 23:06 | |
*** lucas-afk has quit IRC | 23:06 | |
*** ssurana has quit IRC | 23:06 | |
*** edmondsw has quit IRC | 23:06 | |
*** pradk has quit IRC | 23:06 | |
*** ircuser-1 has quit IRC | 23:06 | |
*** sdague has quit IRC | 23:06 | |
*** raginbajin has quit IRC | 23:06 | |
*** toure_ has quit IRC | 23:06 | |
*** leseb- has quit IRC | 23:06 | |
*** hamzy has quit IRC | 23:06 | |
*** abramley has quit IRC | 23:06 | |
*** pkholkin has quit IRC | 23:06 | |
*** hparekh has quit IRC | 23:06 | |
*** bnemec has quit IRC | 23:06 | |
*** sc68cal has quit IRC | 23:06 | |
*** rook has quit IRC | 23:06 | |
*** lifeless has quit IRC | 23:06 | |
*** inara has quit IRC | 23:06 | |
*** jamiec has quit IRC | 23:06 | |
*** mdrabe has quit IRC | 23:06 | |
*** rook has joined #openstack-nova | 23:06 | |
*** abramley_ is now known as abramley | 23:06 | |
dansmith | melwitt: they were failing for the reason that caused me to have to add the override, but they aren't failing for me locally when I run with that fix, but the other three were | 23:07 |
*** annegentle has quit IRC | 23:07 | |
dansmith | melwitt: since we're trying to just unblock the gate, I didn't want to do the resulting major cleanup before we unblock everyone | 23:07 |
*** raginbaj- is now known as raginbajin | 23:07 | |
*** apoorvad_ is now known as apoorvad | 23:07 | |
*** mordred has joined #openstack-nova | 23:07 | |
*** sdague has joined #openstack-nova | 23:07 | |
*** annegentle has joined #openstack-nova | 23:07 | |
*** leseb_ has joined #openstack-nova | 23:07 | |
*** pumaranikar has quit IRC | 23:07 | |
*** greghaynes_ has joined #openstack-nova | 23:07 | |
*** inara has joined #openstack-nova | 23:07 | |
melwitt | dansmith: I see, thanks | 23:08 |
*** lxsli has joined #openstack-nova | 23:08 | |
dansmith | melwitt: I have the bigger cleanup in progress right now | 23:08 |
suro-patz | dansmith: If version A views a field of an object as Int, and version A+1 has the field as float, you mean node with A will crash on receiving an object from a node (A+1)? I expect truncation and wrong interpretation of value. But I am trying to understand how would it crash … | 23:09 |
*** lifeless has joined #openstack-nova | 23:09 | |
*** lucasagomes has joined #openstack-nova | 23:09 | |
dansmith | suro-patz: the problem comes when A+1 goes to send the object to A | 23:10 |
dansmith | suro-patz: >>> int('1.0') | 23:10 |
dansmith | Traceback (most recent call last): | 23:10 |
dansmith | File "<stdin>", line 1, in <module> | 23:10 |
dansmith | ValueError: invalid literal for int() with base 10: '1.0' | 23:10 |
melwitt | dansmith: +W. cool. I was trying to wrap my head around what the difference was between those 3 and failed :) | 23:10 |
dansmith | melwitt: yeah, shouldn't have had to do that in the same patch, but alas | 23:10 |
*** kylek3h has quit IRC | 23:10 | |
*** lucasagomes is now known as lucas-afk | 23:11 | |
*** alejandrito has quit IRC | 23:11 | |
*** ijuwang has quit IRC | 23:13 | |
suro-patz | dansmith: I see - from your explanation it seems all the values are read/written as literal/string, which explains why it would crash. Otherwise, int(1.0) works fine | 23:13 |
*** hamzy has joined #openstack-nova | 23:13 | |
*** edmondsw has joined #openstack-nova | 23:13 | |
*** pkholkin has joined #openstack-nova | 23:13 | |
dansmith | suro-patz: it has nothing to do with reading and writing from the database, it has to do with RPC communication and the serialization that comes with that | 23:14 |
*** sacharya has quit IRC | 23:15 | |
dansmith | the field type determines how it is serialized and deserialized, so if you define it as an int and then pass it something non-integer-like, it'll explode | 23:15 |
*** emagana has quit IRC | 23:15 | |
*** ircuser-1 has joined #openstack-nova | 23:15 | |
*** emagana has joined #openstack-nova | 23:15 | |
*** Guest73509 is now known as Guest80875 | 23:16 | |
suro-patz | dansmith: in other words, what I understand serdes will treat the values as literals, right? | 23:16 |
*** rk4n has quit IRC | 23:16 | |
dansmith | suro-patz: I don't understand that sentence, but (de-)serialization converts everything to a string on the wire | 23:17 |
openstackgerrit | Dan Smith proposed openstack/nova: Clean up legacy multi-version test constructs https://review.openstack.org/246030 | 23:17 |
dansmith | melwitt: I think that'll ^^ work | 23:17 |
suro-patz | dansmith: serdes => serialization, deserialization | 23:18 |
dansmith | melwitt: obviously I'd rather not backport the cleanup | 23:18 |
dansmith | suro-patz: yeah, i got that part | 23:18 |
suro-patz | dansmith: thanks for the explanation, got the argument! | 23:18 |
suro-patz | dansmith: will add the necessary code in obj_make_compatible() | 23:18 |
*** zhangjn has joined #openstack-nova | 23:19 | |
melwitt | dansmith: ah, yeah. that's a lot | 23:20 |
*** jhesketh has quit IRC | 23:21 | |
*** annegentle has quit IRC | 23:22 | |
*** annegentle has joined #openstack-nova | 23:22 | |
*** ociuhandu has joined #openstack-nova | 23:22 | |
*** jhesketh has joined #openstack-nova | 23:23 | |
*** electrocucaracha has quit IRC | 23:24 | |
dansmith | mriedem_away: the backport failed a bunch of cells tests, but I don't really know why.. | 23:25 |
*** baoli has quit IRC | 23:29 | |
*** daemontool has quit IRC | 23:29 | |
*** zhangjn has quit IRC | 23:32 | |
*** sneti_ has quit IRC | 23:32 | |
*** aginwala has quit IRC | 23:33 | |
*** eliqiao has joined #openstack-nova | 23:35 | |
*** jamielennox|away is now known as jamielennox | 23:37 | |
*** Marga__ has joined #openstack-nova | 23:37 | |
*** ctrath has quit IRC | 23:37 | |
*** eliqiao_ has quit IRC | 23:38 | |
*** Marga_ has quit IRC | 23:39 | |
*** aginwala has joined #openstack-nova | 23:39 | |
*** aginwala has quit IRC | 23:41 | |
*** aginwala_ has joined #openstack-nova | 23:41 | |
*** ekarlso has quit IRC | 23:41 | |
mriedem_away | dansmith: hmm, yeah i don't know either | 23:43 |
mriedem_away | i'll see if i can reproduce that locally | 23:43 |
*** tpeoples is now known as tpeoples_away | 23:45 | |
*** aginwala has joined #openstack-nova | 23:46 | |
*** ekarlso has joined #openstack-nova | 23:47 | |
*** aginwal__ has joined #openstack-nova | 23:48 | |
alex_xu | mriedem_away: yea, ting zhang isn't intel people | 23:48 |
*** aginwala_ has quit IRC | 23:49 | |
*** aginwala has quit IRC | 23:51 | |
*** aginwal__ has quit IRC | 23:51 | |
*** rook0- has joined #openstack-nova | 23:54 | |
*** ekarlso has quit IRC | 23:57 | |
*** ekarlso has joined #openstack-nova | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!