| *** haomaiwa_ has joined #openstack-nova | 00:01 | |
| *** thorst_afk has quit IRC | 00:01 | |
| *** penick has quit IRC | 00:05 | |
| dansmith | edleafe: +1 | 00:05 |
|---|---|---|
| *** su_zhang_ has joined #openstack-nova | 00:09 | |
| *** su_zhang has quit IRC | 00:09 | |
| *** haomaiwa_ has quit IRC | 00:09 | |
| *** krtaylor has joined #openstack-nova | 00:12 | |
| openstackgerrit | Jay Pipes proposed openstack/nova: Added supports_requests method to PciDeviceList https://review.openstack.org/242087 | 00:17 |
| *** Sukhdev has joined #openstack-nova | 00:20 | |
| *** n0ano has joined #openstack-nova | 00:26 | |
| *** sdague has quit IRC | 00:26 | |
| *** zenoway has joined #openstack-nova | 00:28 | |
| *** nic has quit IRC | 00:29 | |
| *** Sukhdev has quit IRC | 00:29 | |
| *** Jeffrey4l has joined #openstack-nova | 00:32 | |
| *** eil397 has joined #openstack-nova | 00:32 | |
| *** zenoway has quit IRC | 00:33 | |
| *** mylu has quit IRC | 00:35 | |
| *** kasey-alusi has joined #openstack-nova | 00:37 | |
| kasey-alusi | Hey all - I had a question about https://bugs.launchpad.net/nova/+bug/1514550 it looks like the initial assignee removed him/herself from the bug. Can I pick it up? Also - it looks like the review is still up - if I pick it up should that one be abandoned? | 00:39 |
| openstack | Launchpad bug 1514550 in OpenStack Compute (nova) "nova.cells.messaging.instance_update_at_top is assuming it gets an Instance object" [Low,In progress] - Assigned to Kasey Alusi (kasey-alusi) | 00:39 |
| *** mylu has joined #openstack-nova | 00:43 | |
| *** salv-orlando has joined #openstack-nova | 00:45 | |
| *** mylu has quit IRC | 00:46 | |
| *** diana_clarke has joined #openstack-nova | 00:46 | |
| *** daemontool has quit IRC | 00:47 | |
| *** kasey-alusi has quit IRC | 00:50 | |
| *** gongysh has joined #openstack-nova | 00:54 | |
| *** qeelee has joined #openstack-nova | 00:56 | |
| *** eil397 has quit IRC | 00:57 | |
| *** RichardRaseley has quit IRC | 00:57 | |
| *** mylu has joined #openstack-nova | 00:58 | |
| *** devanand1 has joined #openstack-nova | 00:59 | |
| *** vilobhmm11 has quit IRC | 00:59 | |
| *** devanand1 has quit IRC | 00:59 | |
| *** devananda has quit IRC | 00:59 | |
| *** thorst_afk has joined #openstack-nova | 00:59 | |
| openstackgerrit | Jay Pipes proposed openstack/nova: Added supports_requests method to PciDeviceList https://review.openstack.org/242087 | 01:01 |
| *** rotbeard has joined #openstack-nova | 01:01 | |
| *** ijw has quit IRC | 01:01 | |
| *** devananda has joined #openstack-nova | 01:01 | |
| *** ijw has joined #openstack-nova | 01:02 | |
| *** mylu has quit IRC | 01:03 | |
| *** yhvh has joined #openstack-nova | 01:03 | |
| *** hoangcx has joined #openstack-nova | 01:04 | |
| *** zenoway has joined #openstack-nova | 01:04 | |
| yhvh | hey, trying to upgrade from liberty to master to try a feature, getting CantStartEngineError: no sql_connection parameter is established | 01:04 |
| yhvh | any ideas? | 01:04 |
| *** mylu has joined #openstack-nova | 01:04 | |
| *** thorst_afk has quit IRC | 01:05 | |
| *** thorst_afk has joined #openstack-nova | 01:05 | |
| *** mylu has quit IRC | 01:06 | |
| *** haomaiwa_ has joined #openstack-nova | 01:06 | |
| *** thorst_afk has quit IRC | 01:06 | |
| *** salv-orlando has quit IRC | 01:07 | |
| *** thorst_afk has joined #openstack-nova | 01:07 | |
| *** mrkz has quit IRC | 01:08 | |
| *** shawnmaten has quit IRC | 01:08 | |
| *** ducttape_ has joined #openstack-nova | 01:08 | |
| *** zenoway has quit IRC | 01:08 | |
| *** vilobhmm11 has joined #openstack-nova | 01:10 | |
| yhvh | Nova api log http://paste.openstack.org/show/488295/ | 01:11 |
| *** thorst_afk has quit IRC | 01:12 | |
| *** haomaiwa_ has quit IRC | 01:13 | |
| *** aorourke is now known as aorourke-afk | 01:13 | |
| *** sheel has joined #openstack-nova | 01:14 | |
| *** mylu has joined #openstack-nova | 01:15 | |
| *** ducttape_ has quit IRC | 01:15 | |
| *** EinstCrazy has joined #openstack-nova | 01:16 | |
| *** zz_dimtruck is now known as dimtruck | 01:17 | |
| *** mylu has quit IRC | 01:17 | |
| *** edtubill has quit IRC | 01:18 | |
| *** mylu has joined #openstack-nova | 01:19 | |
| *** mtanino has quit IRC | 01:21 | |
| *** mnestratov has quit IRC | 01:21 | |
| *** davechen_afk is now known as grassy | 01:22 | |
| *** mylu has quit IRC | 01:23 | |
| *** haomaiwang has joined #openstack-nova | 01:25 | |
| *** devananda has quit IRC | 01:26 | |
| eliqiao_ | hi johnthetubaguy, are you there? can you take a look at my reply on https://review.openstack.org/#/c/275585/5/nova/objects/migrate_data.py | 01:26 |
| *** devananda has joined #openstack-nova | 01:27 | |
| *** devananda has quit IRC | 01:27 | |
| yhvh | seems like I need to upgrade db | 01:29 |
| *** devananda has joined #openstack-nova | 01:30 | |
| *** apearson has quit IRC | 01:31 | |
| *** haomaiwang has quit IRC | 01:33 | |
| *** zenoway has joined #openstack-nova | 01:39 | |
| *** EinstCrazy has quit IRC | 01:40 | |
| *** mylu has joined #openstack-nova | 01:41 | |
| *** su_zhang_ has quit IRC | 01:41 | |
| *** su_zhang has joined #openstack-nova | 01:41 | |
| *** EinstCrazy has joined #openstack-nova | 01:42 | |
| *** qeelee_ has joined #openstack-nova | 01:42 | |
| *** qeelee has quit IRC | 01:42 | |
| *** qeelee_ is now known as qeelee | 01:42 | |
| *** ijw has quit IRC | 01:43 | |
| *** zenoway has quit IRC | 01:44 | |
| *** su_zhang has quit IRC | 01:45 | |
| *** ijw has joined #openstack-nova | 01:46 | |
| *** ijw has quit IRC | 01:48 | |
| *** ijw has joined #openstack-nova | 01:48 | |
| *** dims has quit IRC | 01:49 | |
| *** ljxiash has joined #openstack-nova | 01:49 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/285044 | 01:51 |
| *** gyee has quit IRC | 01:55 | |
| *** annasort has joined #openstack-nova | 01:55 | |
| *** thorst_afk has joined #openstack-nova | 01:57 | |
| *** mylu has quit IRC | 02:00 | |
| *** hoangcx has quit IRC | 02:01 | |
| *** lyanchih has joined #openstack-nova | 02:02 | |
| *** zenoway has joined #openstack-nova | 02:03 | |
| *** mylu has joined #openstack-nova | 02:08 | |
| *** zenoway has quit IRC | 02:10 | |
| *** ZZelle_ has quit IRC | 02:14 | |
| *** rk4n has quit IRC | 02:14 | |
| *** rk4n has joined #openstack-nova | 02:14 | |
| *** ljxiash has quit IRC | 02:16 | |
| *** ljxiash has joined #openstack-nova | 02:18 | |
| *** READ10 has joined #openstack-nova | 02:20 | |
| *** haomaiwang has joined #openstack-nova | 02:21 | |
| *** knikolla has joined #openstack-nova | 02:21 | |
| openstackgerrit | lyanchih proposed openstack/nova: NUMATopologyFilter raise exception and not continue filter next node https://review.openstack.org/200630 | 02:28 |
| *** qeelee has quit IRC | 02:29 | |
| *** zenoway has joined #openstack-nova | 02:30 | |
| *** qeelee has joined #openstack-nova | 02:31 | |
| *** jwcroppe has joined #openstack-nova | 02:31 | |
| *** rk4n has quit IRC | 02:32 | |
| *** mylu has quit IRC | 02:34 | |
| *** zenoway has quit IRC | 02:34 | |
| *** mylu has joined #openstack-nova | 02:35 | |
| *** baoli has joined #openstack-nova | 02:36 | |
| *** ducttape_ has joined #openstack-nova | 02:37 | |
| *** mylu has quit IRC | 02:39 | |
| *** browne has quit IRC | 02:39 | |
| *** yamahata has quit IRC | 02:39 | |
| *** ducttape_ has quit IRC | 02:40 | |
| *** vilobhmm11 has quit IRC | 02:40 | |
| *** vilobhmm11 has joined #openstack-nova | 02:42 | |
| *** ducttape_ has joined #openstack-nova | 02:44 | |
| *** ducttape_ has quit IRC | 02:46 | |
| *** fawadkhaliq has joined #openstack-nova | 02:48 | |
| *** gcb has quit IRC | 02:48 | |
| *** abitha has quit IRC | 02:49 | |
| *** ducttape_ has joined #openstack-nova | 02:53 | |
| *** zenoway has joined #openstack-nova | 02:54 | |
| *** wanghao has quit IRC | 02:54 | |
| *** wanghao has joined #openstack-nova | 02:55 | |
| *** delatte has quit IRC | 02:56 | |
| *** vilobhmm11 has quit IRC | 02:56 | |
| *** zenoway has quit IRC | 02:58 | |
| *** haomaiwang has quit IRC | 03:01 | |
| *** haomaiwang has joined #openstack-nova | 03:01 | |
| *** ctrath has joined #openstack-nova | 03:04 | |
| *** BobBall has quit IRC | 03:05 | |
| *** pushkaru has quit IRC | 03:05 | |
| *** gcb has joined #openstack-nova | 03:05 | |
| *** BobBall has joined #openstack-nova | 03:07 | |
| *** BobBall is now known as Guest28827 | 03:08 | |
| *** thorst_afk has quit IRC | 03:09 | |
| *** thorst_afk has joined #openstack-nova | 03:09 | |
| *** dims has joined #openstack-nova | 03:10 | |
| *** apoorvad has quit IRC | 03:11 | |
| *** knikolla has quit IRC | 03:15 | |
| *** ianw has quit IRC | 03:16 | |
| *** ctrath has quit IRC | 03:16 | |
| *** thorst_afk has quit IRC | 03:18 | |
| *** ctrath has joined #openstack-nova | 03:18 | |
| *** ianw has joined #openstack-nova | 03:19 | |
| *** ijw has quit IRC | 03:24 | |
| *** boris-42 has quit IRC | 03:24 | |
| *** ljxiash_ has joined #openstack-nova | 03:25 | |
| *** ljxiash_ has quit IRC | 03:26 | |
| *** links has joined #openstack-nova | 03:26 | |
| *** ljxiash_ has joined #openstack-nova | 03:26 | |
| *** mingyu has quit IRC | 03:27 | |
| *** mingyu has joined #openstack-nova | 03:27 | |
| *** sheel has quit IRC | 03:27 | |
| *** ljxiash has quit IRC | 03:27 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Deprecated option 'mkisofs_cmd' for removal https://review.openstack.org/262744 | 03:28 |
| *** zenoway has joined #openstack-nova | 03:29 | |
| *** ljxiash_ has quit IRC | 03:31 | |
| *** fawadkhaliq has quit IRC | 03:32 | |
| *** zenoway has quit IRC | 03:34 | |
| *** ijw has joined #openstack-nova | 03:35 | |
| *** jwcroppe has quit IRC | 03:37 | |
| *** jwcroppe has joined #openstack-nova | 03:37 | |
| *** Kennan has quit IRC | 03:39 | |
| *** Kennan has joined #openstack-nova | 03:39 | |
| *** ijw has quit IRC | 03:40 | |
| *** amotoki has joined #openstack-nova | 03:41 | |
| *** jwcroppe has quit IRC | 03:42 | |
| *** browne has joined #openstack-nova | 03:42 | |
| *** ducttape_ has quit IRC | 03:46 | |
| *** qeelee has quit IRC | 03:50 | |
| *** ctrath has quit IRC | 03:50 | |
| *** markvoelker has quit IRC | 03:51 | |
| *** hoangcx has joined #openstack-nova | 03:55 | |
| *** mingyu has quit IRC | 03:55 | |
| *** mingyu has joined #openstack-nova | 03:55 | |
| *** erlon has quit IRC | 03:56 | |
| *** Marga_ has quit IRC | 03:57 | |
| *** Marga_ has joined #openstack-nova | 03:58 | |
| *** haomaiwang has quit IRC | 04:01 | |
| *** haomaiwang has joined #openstack-nova | 04:01 | |
| *** edtubill has joined #openstack-nova | 04:02 | |
| *** Marga_ has quit IRC | 04:03 | |
| *** amotoki has quit IRC | 04:05 | |
| *** zenoway has joined #openstack-nova | 04:05 | |
| *** lyanchih has quit IRC | 04:05 | |
| *** baoli has quit IRC | 04:07 | |
| *** baoli has joined #openstack-nova | 04:09 | |
| *** edtubill has quit IRC | 04:09 | |
| *** zenoway has quit IRC | 04:09 | |
| *** mingyu has quit IRC | 04:10 | |
| *** mingyu has joined #openstack-nova | 04:11 | |
| *** armax has joined #openstack-nova | 04:11 | |
| *** thorst_afk has joined #openstack-nova | 04:15 | |
| *** brad[] has quit IRC | 04:17 | |
| *** hamzy has joined #openstack-nova | 04:18 | |
| *** baoli has quit IRC | 04:18 | |
| *** Marga_ has joined #openstack-nova | 04:19 | |
| *** baoli has joined #openstack-nova | 04:20 | |
| *** amotoki has joined #openstack-nova | 04:20 | |
| *** READ10 has quit IRC | 04:20 | |
| *** Marga_ has quit IRC | 04:21 | |
| *** Marga_ has joined #openstack-nova | 04:21 | |
| *** thorst_afk has quit IRC | 04:23 | |
| *** gongysh has quit IRC | 04:23 | |
| *** vilobhmm11 has joined #openstack-nova | 04:25 | |
| *** tbachman has joined #openstack-nova | 04:28 | |
| *** gcb has quit IRC | 04:29 | |
| *** amotoki has quit IRC | 04:30 | |
| *** amotoki has joined #openstack-nova | 04:35 | |
| *** vilobhmm11 has quit IRC | 04:39 | |
| *** jwcroppe has joined #openstack-nova | 04:39 | |
| *** vilobhmm11 has joined #openstack-nova | 04:39 | |
| *** mylu has joined #openstack-nova | 04:41 | |
| *** zenoway has joined #openstack-nova | 04:41 | |
| *** qeelee has joined #openstack-nova | 04:41 | |
| *** gcb has joined #openstack-nova | 04:41 | |
| *** zenoway has quit IRC | 04:45 | |
| *** dimtruck is now known as zz_dimtruck | 04:49 | |
| *** markvoelker has joined #openstack-nova | 04:51 | |
| *** markvoelker has quit IRC | 04:56 | |
| *** qeelee has quit IRC | 04:57 | |
| *** fawadkhaliq has joined #openstack-nova | 04:58 | |
| *** amotoki has quit IRC | 05:00 | |
| *** haomaiwang has quit IRC | 05:01 | |
| *** haomaiwang has joined #openstack-nova | 05:01 | |
| *** shyama has joined #openstack-nova | 05:03 | |
| *** shyama has quit IRC | 05:04 | |
| *** ducttape_ has joined #openstack-nova | 05:05 | |
| *** amotoki has joined #openstack-nova | 05:07 | |
| *** jwcroppe has quit IRC | 05:12 | |
| *** gcb has quit IRC | 05:13 | |
| *** ljxiash has joined #openstack-nova | 05:13 | |
| *** gongysh has joined #openstack-nova | 05:16 | |
| *** zenoway has joined #openstack-nova | 05:16 | |
| *** baoli has quit IRC | 05:17 | |
| *** ljxiash has quit IRC | 05:17 | |
| *** ljxiash has joined #openstack-nova | 05:17 | |
| *** edtubill has joined #openstack-nova | 05:18 | |
| *** thorst_afk has joined #openstack-nova | 05:20 | |
| *** zenoway has quit IRC | 05:21 | |
| *** ljxiash has quit IRC | 05:22 | |
| *** lyanchih has joined #openstack-nova | 05:22 | |
| *** mylu has quit IRC | 05:25 | |
| *** tbachman has quit IRC | 05:26 | |
| *** thorst_afk has quit IRC | 05:27 | |
| *** gcb has joined #openstack-nova | 05:30 | |
| *** oomichi_ has joined #openstack-nova | 05:30 | |
| *** oomichi_ has quit IRC | 05:31 | |
| *** mingyu has quit IRC | 05:32 | |
| *** mingyu has joined #openstack-nova | 05:33 | |
| *** tbachman has joined #openstack-nova | 05:34 | |
| *** mubirru has joined #openstack-nova | 05:35 | |
| *** mylu has joined #openstack-nova | 05:35 | |
| *** ducttape_ has quit IRC | 05:37 | |
| *** vilobhmm11 has quit IRC | 05:39 | |
| *** ljxiash has joined #openstack-nova | 05:41 | |
| *** su_zhang has joined #openstack-nova | 05:43 | |
| *** tbachman has quit IRC | 05:45 | |
| *** inc0 has joined #openstack-nova | 05:46 | |
| *** tbachman has joined #openstack-nova | 05:46 | |
| *** tbachman has quit IRC | 05:47 | |
| openstackgerrit | Zhengguang Ou proposed openstack/nova: libvirt: fix race condition in detach volume and create image https://review.openstack.org/166152 | 05:50 |
| *** zenoway has joined #openstack-nova | 05:52 | |
| *** qeelee has joined #openstack-nova | 05:52 | |
| *** inc0 has quit IRC | 05:52 | |
| *** zenoway has quit IRC | 05:56 | |
| *** ljxiash has quit IRC | 05:57 | |
| *** ljxiash has joined #openstack-nova | 05:58 | |
| *** ljxiash_ has joined #openstack-nova | 05:59 | |
| *** Marga_ has quit IRC | 06:00 | |
| *** haomaiwang has quit IRC | 06:01 | |
| *** haomaiwang has joined #openstack-nova | 06:01 | |
| *** ljxiash__ has joined #openstack-nova | 06:01 | |
| *** ljxiash has quit IRC | 06:02 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: Xen: Calculate block_migration if it's None https://review.openstack.org/254101 | 06:02 |
| openstackgerrit | Eli Qiao proposed openstack/nova: Allow block_migration and disk_over_commit to be None https://review.openstack.org/254102 | 06:02 |
| openstackgerrit | Eli Qiao proposed openstack/nova: Libvirt: Calculate block_migration if it's None https://review.openstack.org/275585 | 06:02 |
| openstackgerrit | Eli Qiao proposed openstack/nova: API: Improve os-migrateLive input parameters https://review.openstack.org/259319 | 06:02 |
| *** ljxiash_ has quit IRC | 06:05 | |
| *** wanghao has quit IRC | 06:05 | |
| *** wanghao has joined #openstack-nova | 06:06 | |
| *** wanghao has quit IRC | 06:07 | |
| *** wanghao has joined #openstack-nova | 06:08 | |
| *** vilobhmm11 has joined #openstack-nova | 06:09 | |
| *** eliqiao has joined #openstack-nova | 06:09 | |
| *** mkrai_ has joined #openstack-nova | 06:15 | |
| *** Marga_ has joined #openstack-nova | 06:17 | |
| *** jwcroppe has joined #openstack-nova | 06:19 | |
| *** baoli has joined #openstack-nova | 06:22 | |
| *** abhishekk_ has joined #openstack-nova | 06:24 | |
| *** thorst_afk has joined #openstack-nova | 06:25 | |
| *** baoli has quit IRC | 06:26 | |
| *** links has quit IRC | 06:26 | |
| *** ljxiash__ has quit IRC | 06:27 | |
| *** armax has quit IRC | 06:31 | |
| *** thorst_afk has quit IRC | 06:32 | |
| *** ljxiash has joined #openstack-nova | 06:33 | |
| *** ljxiash has quit IRC | 06:34 | |
| *** ljxiash has joined #openstack-nova | 06:34 | |
| *** su_zhang has quit IRC | 06:34 | |
| *** su_zhang has joined #openstack-nova | 06:35 | |
| *** nkrinner has joined #openstack-nova | 06:37 | |
| *** dims has quit IRC | 06:37 | |
| *** baoli has joined #openstack-nova | 06:37 | |
| *** ljxiash has quit IRC | 06:39 | |
| *** su_zhang has quit IRC | 06:39 | |
| *** baoli has quit IRC | 06:42 | |
| *** sheel has joined #openstack-nova | 06:43 | |
| *** edtubill has quit IRC | 06:44 | |
| *** josecastroleon has joined #openstack-nova | 06:48 | |
| *** ljxiash has joined #openstack-nova | 06:50 | |
| *** jwcroppe has quit IRC | 06:52 | |
| *** haomaiwang has quit IRC | 06:52 | |
| *** markvoelker has joined #openstack-nova | 06:53 | |
| *** haomaiwang has joined #openstack-nova | 06:53 | |
| *** tyagiprince has joined #openstack-nova | 06:56 | |
| *** sudipto has joined #openstack-nova | 06:56 | |
| *** Daisy_ has joined #openstack-nova | 06:57 | |
| *** markvoelker has quit IRC | 06:57 | |
| *** ankit_ag has joined #openstack-nova | 06:58 | |
| *** haomaiwang has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-nova | 07:01 | |
| *** Daisy_ has quit IRC | 07:01 | |
| *** ljxiash has quit IRC | 07:01 | |
| *** ljxiash has joined #openstack-nova | 07:02 | |
| *** mnestratov has joined #openstack-nova | 07:03 | |
| *** rcernin has joined #openstack-nova | 07:05 | |
| *** mkrai_ has quit IRC | 07:08 | |
| *** gongysh has quit IRC | 07:08 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Moved tags filtering tests to TestInstanceTagsFiltering test case https://review.openstack.org/258515 | 07:10 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Added db API layer to add instance tag-list filtering support https://review.openstack.org/248805 | 07:10 |
| *** scheuran has joined #openstack-nova | 07:12 | |
| *** paul-carlton1 has joined #openstack-nova | 07:12 | |
| *** mpavone has joined #openstack-nova | 07:13 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Added server tags controller https://review.openstack.org/128940 | 07:14 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Added server tags support in nova-api https://review.openstack.org/268932 | 07:14 |
| *** mjura has joined #openstack-nova | 07:19 | |
| *** ljxiash has quit IRC | 07:20 | |
| *** jichen has joined #openstack-nova | 07:21 | |
| *** claudiub has joined #openstack-nova | 07:22 | |
| *** lpetrut has joined #openstack-nova | 07:27 | |
| *** salv-orlando has joined #openstack-nova | 07:29 | |
| *** thorst_afk has joined #openstack-nova | 07:30 | |
| *** daemontool has joined #openstack-nova | 07:31 | |
| *** ljxiash has joined #openstack-nova | 07:32 | |
| *** thorst_afk has quit IRC | 07:39 | |
| *** tomoiaga has joined #openstack-nova | 07:39 | |
| *** ihrachys has joined #openstack-nova | 07:39 | |
| *** rotbeard has left #openstack-nova | 07:42 | |
| *** tomoiaga has quit IRC | 07:43 | |
| *** harlowja_at_home has quit IRC | 07:44 | |
| *** ildikov has joined #openstack-nova | 07:46 | |
| *** jwcroppe has joined #openstack-nova | 07:49 | |
| openstackgerrit | Wenzhi Yu proposed openstack/nova: Rewrite 'test_filter_schedule_skipping' method using Mock https://review.openstack.org/285146 | 07:49 |
| *** tomoiaga has joined #openstack-nova | 07:51 | |
| *** zenoway has joined #openstack-nova | 07:56 | |
| *** mylu has quit IRC | 07:56 | |
| *** haomaiwang has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-nova | 08:01 | |
| *** zhangjn has quit IRC | 08:02 | |
| *** josecastroleon has quit IRC | 08:05 | |
| *** zhangjn has joined #openstack-nova | 08:07 | |
| *** belmoreira has joined #openstack-nova | 08:08 | |
| *** josecastroleon has joined #openstack-nova | 08:08 | |
| *** rdopiera has joined #openstack-nova | 08:09 | |
| *** browne has quit IRC | 08:11 | |
| *** paul-carlton1 has quit IRC | 08:13 | |
| *** ljxiash has quit IRC | 08:16 | |
| *** jwcroppe has quit IRC | 08:22 | |
| *** phuongnh has joined #openstack-nova | 08:25 | |
| *** jlanoux has joined #openstack-nova | 08:26 | |
| *** paul-carlton1 has joined #openstack-nova | 08:27 | |
| *** matrohon has joined #openstack-nova | 08:27 | |
| *** achanda has quit IRC | 08:29 | |
| *** ljxiash has joined #openstack-nova | 08:31 | |
| *** achanda has joined #openstack-nova | 08:33 | |
| *** gszasz has joined #openstack-nova | 08:35 | |
| *** daemontool has quit IRC | 08:35 | |
| *** thorst_afk has joined #openstack-nova | 08:36 | |
| *** daemontool has joined #openstack-nova | 08:36 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: API: Improve os-migrateLive input parameters https://review.openstack.org/259319 | 08:37 |
| *** jlanoux has quit IRC | 08:37 | |
| *** jlanoux has joined #openstack-nova | 08:38 | |
| *** thorst_afk has quit IRC | 08:43 | |
| *** gongysh has joined #openstack-nova | 08:44 | |
| *** lyanchih has quit IRC | 08:45 | |
| *** lpetrut has quit IRC | 08:47 | |
| *** tyagiprince has quit IRC | 08:51 | |
| *** tyagiprince has joined #openstack-nova | 08:51 | |
| *** markvoelker has joined #openstack-nova | 08:53 | |
| *** vilobhmm11 has quit IRC | 08:54 | |
| openstackgerrit | pallavi proposed openstack/nova: Update time is not updated when metadata of aggregate is updated https://review.openstack.org/284023 | 08:56 |
| *** paul-carlton1 has quit IRC | 08:56 | |
| *** markvoelker has quit IRC | 08:57 | |
| *** tyagiprince has quit IRC | 08:58 | |
| *** haomaiwang has quit IRC | 09:01 | |
| *** haomaiwa_ has joined #openstack-nova | 09:01 | |
| *** lucas-afk is now known as lucasagomes | 09:02 | |
| *** achanda has quit IRC | 09:03 | |
| *** nikhil has quit IRC | 09:04 | |
| *** danpb has joined #openstack-nova | 09:09 | |
| *** rcernin has quit IRC | 09:14 | |
| *** jlanoux has quit IRC | 09:17 | |
| *** jwcroppe has joined #openstack-nova | 09:19 | |
| *** salv-orlando has quit IRC | 09:19 | |
| *** salv-orlando has joined #openstack-nova | 09:19 | |
| *** paul-carlton1 has joined #openstack-nova | 09:20 | |
| *** yassine__ has joined #openstack-nova | 09:27 | |
| *** jistr has joined #openstack-nova | 09:27 | |
| *** rcernin has joined #openstack-nova | 09:28 | |
| openstackgerrit | jichenjc proposed openstack/nova: Handle Instance Exceptions in add&remove fix ip https://review.openstack.org/285183 | 09:29 |
| *** jlanoux has joined #openstack-nova | 09:30 | |
| *** sudipto has quit IRC | 09:30 | |
| *** mgoddard_ has joined #openstack-nova | 09:31 | |
| *** aagrawal has joined #openstack-nova | 09:32 | |
| *** ihrachys_ has joined #openstack-nova | 09:32 | |
| *** mnestratov|2 has joined #openstack-nova | 09:32 | |
| *** sfinucan has joined #openstack-nova | 09:32 | |
| *** rpodolyaka_ has joined #openstack-nova | 09:33 | |
| *** jwcroppe_ has joined #openstack-nova | 09:34 | |
| *** mnestratov has quit IRC | 09:35 | |
| *** rpodolyaka has quit IRC | 09:35 | |
| *** ishant has joined #openstack-nova | 09:35 | |
| *** jwcroppe has quit IRC | 09:35 | |
| *** ihrachys has quit IRC | 09:35 | |
| *** ankit_ag has quit IRC | 09:35 | |
| *** wanghao has quit IRC | 09:35 | |
| *** mgoddard has quit IRC | 09:35 | |
| *** rpodolyaka_ is now known as rpodolyaka | 09:35 | |
| *** wanghao has joined #openstack-nova | 09:35 | |
| *** fawadkhaliq has quit IRC | 09:37 | |
| *** gongysh has quit IRC | 09:39 | |
| *** gongysh has joined #openstack-nova | 09:40 | |
| *** thorst_afk has joined #openstack-nova | 09:41 | |
| *** PaulMurray has joined #openstack-nova | 09:41 | |
| PaulMurray | good morning all | 09:42 |
| *** sudipto has joined #openstack-nova | 09:43 | |
| PaulMurray | shaohe_feng, how are you doing with https://review.openstack.org/#/c/258771 - I read comments about mocks+DB etc. | 09:46 |
| PaulMurray | shaohe_feng, I think andrearosa will be following with the same kind of changes | 09:47 |
| *** Jeffrey4l_ has joined #openstack-nova | 09:47 | |
| *** thorst_afk has quit IRC | 09:48 | |
| *** Jeffrey4l has quit IRC | 09:49 | |
| *** tyagiprince has joined #openstack-nova | 09:49 | |
| *** ndipanov has joined #openstack-nova | 09:50 | |
| *** davideagle_ has joined #openstack-nova | 09:50 | |
| *** jwcroppe_ has quit IRC | 09:53 | |
| *** EinstCrazy has quit IRC | 09:55 | |
| *** grassy is now known as davechen_afk | 09:56 | |
| *** salv-orlando has quit IRC | 10:00 | |
| *** haomaiwa_ has quit IRC | 10:01 | |
| *** haomaiwang has joined #openstack-nova | 10:01 | |
| *** salv-orlando has joined #openstack-nova | 10:08 | |
| *** qeelee has quit IRC | 10:09 | |
| *** lyanchih has joined #openstack-nova | 10:10 | |
| *** salv-orlando has quit IRC | 10:11 | |
| *** salv-orlando has joined #openstack-nova | 10:12 | |
| *** derekh has joined #openstack-nova | 10:13 | |
| *** ljxiash has quit IRC | 10:14 | |
| *** rk4n has joined #openstack-nova | 10:16 | |
| *** daemontool has quit IRC | 10:16 | |
| *** lyanchih has quit IRC | 10:19 | |
| openstackgerrit | Pawel Koniszewski proposed openstack/nova: Live migration failure in API leaves VM in MIGRATING state https://review.openstack.org/168916 | 10:19 |
| openstackgerrit | ShaoHe Feng proposed openstack/nova: Add new APIs and deprecate old API for migrations https://review.openstack.org/258771 | 10:22 |
| *** ljxiash has joined #openstack-nova | 10:23 | |
| *** haomaiwang has quit IRC | 10:23 | |
| shaohe_feng | andrearosa: ping | 10:24 |
| *** lpetrut has joined #openstack-nova | 10:26 | |
| *** sdague has joined #openstack-nova | 10:27 | |
| *** hoangcx has quit IRC | 10:27 | |
| PaulMurray | shaohe_feng, andrearosa will be back in a minute | 10:27 |
| *** ishant has quit IRC | 10:27 | |
| PaulMurray | shaohe_feng, did you see my question above? | 10:27 |
| eliqiao_ | hi johnthetubaguy, I have a question about nova object, do you have time to discuss? | 10:28 |
| *** Bobba is now known as BobBall | 10:28 | |
| shaohe_feng | PaulMurray: yes. I have seen. | 10:28 |
| PaulMurray | shaohe_feng, I saw your new patchset - looking now | 10:29 |
| shaohe_feng | PaulMurray: I have update it without mock. | 10:29 |
| *** haomaiwang has joined #openstack-nova | 10:29 | |
| shaohe_feng | let me show you. | 10:29 |
| PaulMurray | shaohe_feng, what time zone are you in? | 10:31 |
| shaohe_feng | PaulMurray: OK. Do I need to update andrearosa‘s patch. | 10:31 |
| eliqiao_ | johnthetubaguy: oh, I see your comment, and no question now. Thanks. | 10:31 |
| PaulMurray | shaohe_feng, andrearosa can do that | 10:31 |
| shaohe_feng | PaulMurray: OK, great. | 10:31 |
| PaulMurray | shaohe_feng, you also have https://review.openstack.org/#/c/281335/ | 10:31 |
| shaohe_feng | PaulMurray: yes, need to fix it. | 10:32 |
| shaohe_feng | PaulMurray: sorry. | 10:32 |
| PaulMurray | shaohe_feng, I don't know what time zone you are in? if it helps we can double up with you and work on the patches while you sleep? | 10:33 |
| *** achanda has joined #openstack-nova | 10:33 | |
| shaohe_feng | PaulMurray: I'm GMT+8 | 10:33 |
| andrearosa | shaohe_feng: hi, I am on it | 10:34 |
| *** ducttape_ has joined #openstack-nova | 10:34 | |
| andrearosa | shaohe_feng: I am looking at your patch right now | 10:34 |
| johnthetubaguy | eliqiao_: cool, yeah, makes sense now, thanks for the ping | 10:34 |
| sdague | shaohe_feng: can we get rid of that last mock in the https://review.openstack.org/#/c/258771/35/nova/tests/functional/api_sample_tests/test_migrations.py | 10:34 |
| shaohe_feng | PaulMurray: will go to sleep six hours later. you can ping me, during these time. | 10:34 |
| *** davideagle_ has quit IRC | 10:34 | |
| PaulMurray | shaohe_feng, ok - thanks - lets us know if there is anything we can do to help - including working on things you don't get finished | 10:35 |
| sdague | shaohe_feng: it should just be flipping the setUp to do creates() | 10:35 |
| shaohe_feng | andrearosa: good catch. will remove it. thanks. | 10:36 |
| openstackgerrit | Gleb Stepanov proposed openstack/nova: Console log copy for block live migratiob https://review.openstack.org/284674 | 10:37 |
| sdague | andrearosa: to give some context, when I was playing with the patches last night I realized the mocks were causing the api sample content to not be what real people would get. A big part of what the samples are used for is our REST documentation, so it's kind of important it actually goes through the entire API <-> db process. | 10:37 |
| eliqiao_ | johnthetubaguy: Thanks for your review and +2. Really appriate for your kindly help :). | 10:37 |
| shaohe_feng | PaulMurray: OK. if any issue on the patch. you can help if I'm in to sleep | 10:37 |
| shaohe_feng | PaulMurray: thanks. | 10:37 |
| *** lyanchih has joined #openstack-nova | 10:37 | |
| shaohe_feng | sdague: what is "flipping the setUp " | 10:38 |
| *** lyanchih has quit IRC | 10:38 | |
| sdague | shaohe_feng: instead of filling up self.migrations | 10:38 |
| *** achanda has quit IRC | 10:38 | |
| sdague | just do a create() on your migration objects | 10:38 |
| andrearosa | shaohe_feng: thanks, but sdague spot it :) | 10:39 |
| andrearosa | sdague: thanks for the context | 10:39 |
| sdague | andrearosa: fortunately, this can mostly be solved by just doing a .create() on objects you build, because we've got a db and service stack. | 10:40 |
| openstackgerrit | Gábor Antal proposed openstack/nova: Replaced unittest to unittest2 for consistency https://review.openstack.org/285209 | 10:41 |
| sdague | I'm going to go clean out other mocks that landed in that part of the tree. I didn't realize how badly it could mess up things until last night. | 10:42 |
| andrearosa | sdague: that is off-topic for now, but working on functional tests I see sometinmes we use the client but not always I wonder if we should make it consistent for all functional tests...but as I said that is not the right time to discuss that | 10:42 |
| sdague | sometimes use the client in which way? | 10:42 |
| sdague | or in not which way? | 10:42 |
| shaohe_feng | sdague: thanks, working on to get rid of last mock. just a minutes. | 10:43 |
| andrearosa | sdague: I'll give us some example later, maybe I ma just misreading the code. I'll work on fixing my tests now | 10:44 |
| sdague | shaohe_feng: no prob, just ping me when done and I'll look it all over again | 10:44 |
| shaohe_feng | sdague: OK. really sorry. I do not aware of this is a functional test. should use really db instead of mock. | 10:45 |
| *** thorst_afk has joined #openstack-nova | 10:45 | |
| sdague | shaohe_feng: no worries. I didn't catch it early. And there are other examples in that directory that do that. So it's an honest mistake by all of us. | 10:46 |
| shaohe_feng | sdague: we can help to clean up other mocks. :) | 10:47 |
| *** davideagle_ has joined #openstack-nova | 10:47 | |
| *** erlon has joined #openstack-nova | 10:48 | |
| openstackgerrit | jichenjc proposed openstack/python-novaclient: move migrations from extension https://review.openstack.org/285213 | 10:48 |
| alex_xu | shaohe_feng: sdague, one more small comment in https://review.openstack.org/#/c/258771/35/nova/api/openstack/compute/server_migrations.py , not sure does it make sense, but hope that can help user clear this API is only used for in-progress LM | 10:49 |
| alex_xu | or just ignore that if it really super nit | 10:50 |
| *** jwcroppe has joined #openstack-nova | 10:50 | |
| shaohe_feng | alex_xu: I'm also not a native English speaker. | 10:51 |
| alex_xu | shaohe_feng: nvm, I won't block on it | 10:51 |
| shaohe_feng | alex_xu: do not really which it's more clear to express it. | 10:52 |
| shaohe_feng | do not really know | 10:52 |
| alex_xu | shaohe_feng: yes, most of time I'm same with you :) | 10:53 |
| sdague | alex_xu: honestly, I think we can discuss and clean up language on that later some time | 10:53 |
| *** thorst_afk has quit IRC | 10:53 | |
| alex_xu | sdague: yup, agree with that, not something critical | 10:53 |
| sdague | I'd like to make sure the fundamentals are solid and land all this, and things we can clean up after we can do in follow ups | 10:53 |
| alex_xu | +1 | 10:54 |
| johnthetubaguy | eliqiao_: I just realised I sent you down a bad path to reuse that old exception, sorry. I think we are better just adding a new one in that patch where you start using it, and just adding that exception into the API handlers, etc. It should be a separate patch if we need to remove the old one. | 10:54 |
| *** markvoelker has joined #openstack-nova | 10:54 | |
| eliqiao_ | johnthetubaguy: do you prefer I done it in compute api patch? | 10:54 |
| johnthetubaguy | eliqiao_: yeah, I think it needs to be done in that patch, I added some comments, sorry about that! | 10:55 |
| openstackgerrit | Jianghua Wang proposed openstack/nova: XenAPI: introduce unit test for XenAPI plugins https://review.openstack.org/283962 | 10:55 |
| eliqiao_ | johnthetubaguy: okay, thanks for point me out, I will do a update as soon as possible. | 10:55 |
| johnthetubaguy | eliqiao_: its so we get a logical set of changes at each step (removing the unused exception should really be a totally separate patch, for example) | 10:55 |
| johnthetubaguy | don't worry about that removing the old exception for now | 10:55 |
| johnthetubaguy | sdague: alex_xu: I was just going to look through the https://review.openstack.org/#/c/258771 chain, are there things you are both waiting for in there? | 10:56 |
| *** salv-orlando has quit IRC | 10:57 | |
| *** ljxiash has quit IRC | 10:57 | |
| eliqiao_ | johnthetubaguy: gotcha. do you feel okay for this exception naming? https://review.openstack.org/#/c/259319/19/nova/exception.py@1854 | 10:57 |
| *** ducttape_ has quit IRC | 10:57 | |
| sdague | johnthetubaguy: the removal of mock use in the api_samples tests | 10:57 |
| sdague | which shaohe_feng is working on | 10:58 |
| sdague | then I think we're good | 10:58 |
| alex_xu | yup, nothing from me | 10:58 |
| openstackgerrit | Sheel Rana proposed openstack/nova: Use of metadata id instead of metadata name https://review.openstack.org/285222 | 10:58 |
| sdague | johnthetubaguy: for context - https://review.openstack.org/#/c/258771/34/nova/tests/unit/api/openstack/compute/test_server_migrations.py@163 - I found last night | 10:58 |
| *** markvoelker has quit IRC | 10:58 | |
| johnthetubaguy | eliqiao_: yeah, I think so... maybe the wording could be more like: API v2.23 requires all the Mitaka upgrade to be complete, before it is available. or something like that? | 10:59 |
| eliqiao_ | johnthetubaguy: okay, thanks, I will try to make things clearly as you told. | 10:59 |
| johnthetubaguy | sdague: oh... very good spot, need to be mocking the return of DB objects right? | 11:00 |
| sdague | johnthetubaguy: no | 11:00 |
| sdague | just save the objects | 11:00 |
| sdague | we have a database | 11:00 |
| sdague | then the REST api requests are the full wsgi stack to the source data | 11:00 |
| * alex_xu learned on more thing again | 11:00 | |
| sdague | so the likelihood of them being real is much higher | 11:00 |
| *** haomaiwang has quit IRC | 11:01 | |
| johnthetubaguy | sdague: oh, OK, didn't know we were doing that, but yeah, that makes them a lot more real | 11:01 |
| sdague | for instance, correctly filtering out on types and status | 11:01 |
| sdague | which wasn't happening in PS 34 | 11:01 |
| *** haomaiwang has joined #openstack-nova | 11:01 | |
| johnthetubaguy | yeah, its a very good point | 11:01 |
| johnthetubaguy | I guess thats why they take so long to run, those tests, but thats fair enough, otherwise we are not really testing them | 11:02 |
| sdague | right, the point is that we actually test our full stack as much as reasonable | 11:03 |
| sdague | in the original samples everything gets created via REST calls. I think in this case bypassing to the db layer is ok. Building all these migrations up entirely via REST would be tricky. | 11:05 |
| sdague | but we definitely want to avoid mocks if we can | 11:05 |
| andrearosa | sdague: you want to avoid mocks because they are functional tests, right? | 11:05 |
| shaohe_feng | sdague: johnthetubaguy: so all the tests on functional dir should not use mock, should access the really db, right? | 11:05 |
| sdague | andrearosa: correct | 11:05 |
| sdague | shaohe_feng: in general, yes. There may be exceptions. | 11:06 |
| *** rk4n has quit IRC | 11:06 | |
| shaohe_feng | sdague: yes. agree. | 11:06 |
| *** rk4n has joined #openstack-nova | 11:07 | |
| andrearosa | sdague: I agree with you and more a read the functional tests and more I agree and see your point. | 11:07 |
| johnthetubaguy | sdague: I do wonder if we have too many error messages here, I was kinda expecting all the filtering to be done at the DB layer. just worried folks will start parsing the 404 responses. although maybe I am overthinking it? certainly not a blocker for me, just curious what you think: https://review.openstack.org/#/c/258771/35/nova/api/openstack/compute/server_migrations.py@127 | 11:08 |
| johnthetubaguy | sdague: so we are adding links to everything listed via /os-migrations, but most of them will return 404 all the time, as they are not live-migrations, is that a bit odd? I guess we have to just live with that? | 11:10 |
| openstackgerrit | Jianghua Wang proposed openstack/nova: XenAPI: introduce unit test for XenAPI plugins https://review.openstack.org/283962 | 11:10 |
| sdague | oh... | 11:11 |
| sdague | right, so I kind of assumed we didn't in the non live migration case. | 11:11 |
| sdague | .... | 11:11 |
| *** rk4n has quit IRC | 11:12 | |
| sdague | ug. so... I have an idea, but it means we're changing things again. | 11:13 |
| *** rk4n has joined #openstack-nova | 11:13 | |
| sdague | it seems like migration type could/should surface in /os-migrations, and links only in the live-migration case. | 11:13 |
| sdague | there was a reason we were trying to avoid type in that screen though, right? (I'm lost in the history now) | 11:14 |
| sdague | johnthetubaguy: also, there is no competing 2.23 right now right? Because I definitely don't want to be hitting version rebases on this stuff. | 11:14 |
| BobBall | johnthetubaguy: citrix xenserver CI is fixed; could it be re-added to the CI group please | 11:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: virt/hardware: Check for threads when "required" https://review.openstack.org/285232 | 11:14 |
| johnthetubaguy | sdague: good question, I think we dropped the type for the new migration list, as they are all live-migrations | 11:14 |
| sdague | johnthetubaguy: yeh, I don't want it on the new view | 11:14 |
| *** haomaiwang has quit IRC | 11:14 | |
| sdague | but on the old view | 11:15 |
| johnthetubaguy | sdague: hmm, maybe there is one... https://review.openstack.org/#/c/259319/19 | 11:15 |
| johnthetubaguy | sdague: the old view was created before there were types, like before we added the live-migrate stuff | 11:15 |
| johnthetubaguy | sdague: I am actually wondering if we don't list live-migrates in there, now I am thinking about it... goes digging... | 11:15 |
| sdague | johnthetubaguy: right, it predates types | 11:16 |
| sdague | but in the spec we didn't want to extend certain things about it | 11:16 |
| sdague | exposing type doesn't seem like an issue | 11:16 |
| sdague | ok, I -1ed eliqiao_'s patch and said we should slot it as 2.25 so we don't interfere with these | 11:16 |
| johnthetubaguy | sdague: its and admin facing things, it makes sense to me | 11:16 |
| johnthetubaguy | sdague: thats a good idea | 11:17 |
| johnthetubaguy | sdague: FWIW, I normally treat +W as passed FF rather than merge, but I don't want to rely on that | 11:17 |
| openstackgerrit | jichenjc proposed openstack/python-novaclient: Deprecate run_test.sh https://review.openstack.org/285238 | 11:18 |
| sdague | johnthetubaguy: what our deadlines on the clock? | 11:18 |
| johnthetubaguy | we have till Thursday morning, really | 11:19 |
| sdague | johnthetubaguy: so, on overloading 404 and a lot of specific error messages, I think it's fine for now. It errors on the side of detail to the user who will be an admin. | 11:20 |
| johnthetubaguy | prehaps python-novaclient is looking dodgy, we have to do our final mitaka release by that date | 11:20 |
| johnthetubaguy | sdague: fair | 11:20 |
| *** qeelee has joined #openstack-nova | 11:20 | |
| eliqiao_ | sdague: okay, 2.24 's ready to merge? | 11:20 |
| sdague | eliqiao_: 2.23 and 2.24 are stacked up right now, and we're just working through the last issues | 11:21 |
| *** Daisy has joined #openstack-nova | 11:21 | |
| sdague | honestly I want to get them merged today | 11:21 |
| sdague | johnthetubaguy: ok, back to the root concern. Exposing links that are dead. | 11:21 |
| johnthetubaguy | yep | 11:21 |
| eliqiao_ | sdague: okay, I will do the rebase on top of them, thanks | 11:22 |
| *** gongysh has quit IRC | 11:22 | |
| *** mnestratov has joined #openstack-nova | 11:22 | |
| sdague | if we expose type, and only provide links on live-migration... that seems like the right interface | 11:22 |
| sdague | then you will know why there isn't a link | 11:22 |
| *** jwcroppe has quit IRC | 11:23 | |
| johnthetubaguy | true, you get to discover when | 11:23 |
| *** mingyu has quit IRC | 11:23 | |
| sdague | that actually looks like only about 2 lines of code change, plus updating tests | 11:24 |
| *** mingyu has joined #openstack-nova | 11:24 | |
| alex_xu | it is ok keep the link always here, but add the type | 11:24 |
| sdague | alex_xu: it's a little rude to give people a link we know doesn't exist | 11:25 |
| alex_xu | because we tell people /servers/id/migration is in-progress LM only, that is the contract | 11:25 |
| johnthetubaguy | sdague: yeah, looks like we just left this as a todo: https://github.com/openstack/nova/commit/13fb2d26d44532296e8bcd4804b2c64191401064 | 11:25 |
| *** mnestratov|2 has quit IRC | 11:25 | |
| johnthetubaguy | sdague: interestingly None is a possible type | 11:25 |
| johnthetubaguy | well, unknown, I suppose is the more accurate | 11:26 |
| sdague | https://review.openstack.org/#/c/258771/35/nova/api/openstack/compute/migrations.py@53 | 11:26 |
| alex_xu | sdague: emm...yeah, just don't like field show something and don't show something, too much thing for user to discover... | 11:26 |
| sdague | alex_xu: honestly, it's better than giving them a link which is always 404 | 11:26 |
| openstackgerrit | jichenjc proposed openstack/nova: Handle Instance Exceptions in add&remove fix ip https://review.openstack.org/285183 | 11:27 |
| alex_xu | sdague: ok, that is also right point | 11:27 |
| sdague | shaohe_feng: how are things going? let me know if you need to call it a day and need other people to take over on these tweaks. | 11:27 |
| *** mingyu has quit IRC | 11:27 | |
| *** mingyu has joined #openstack-nova | 11:28 | |
| sdague | johnthetubaguy: ok, so we need to decide where the finish line is for sure on this patch. Because we've found a bunch of things this week during review, and we keep thinking we're near the end. Most of those catches were really imporant, don't get me wrong. | 11:28 |
| sdague | but if we address this dead link issue, is that success? | 11:29 |
| sdague | or are there any other concerns on the table | 11:29 |
| *** mingyu has quit IRC | 11:32 | |
| *** mingyu has joined #openstack-nova | 11:32 | |
| *** mpavone has quit IRC | 11:32 | |
| *** armax has joined #openstack-nova | 11:32 | |
| *** EinstCrazy has joined #openstack-nova | 11:32 | |
| *** mpavone has joined #openstack-nova | 11:33 | |
| johnthetubaguy | sdague: I think that has to be success (or death) | 11:34 |
| johnthetubaguy | sdague: I think it should be success, I am kinda annoyed that last one only just came to me an hour ago | 11:34 |
| shaohe_feng | sdague: seems the sample data and the doc data are not same. I'm trying to lookup it. | 11:34 |
| shaohe_feng | sdague: I have seen other's comments need to address. maybe need take more time to address them. | 11:35 |
| *** achanda has joined #openstack-nova | 11:35 | |
| sdague | shaohe_feng: if you push the patch I can look | 11:35 |
| shaohe_feng | sdague: OK. thank you. | 11:35 |
| *** armax has quit IRC | 11:36 | |
| sdague | and help debug | 11:36 |
| *** sudipto has quit IRC | 11:36 | |
| *** rk4n has quit IRC | 11:36 | |
| *** mingyu has quit IRC | 11:36 | |
| *** rk4n has joined #openstack-nova | 11:36 | |
| *** mingyu has joined #openstack-nova | 11:37 | |
| *** mpavone_ has joined #openstack-nova | 11:38 | |
| *** mpavone_ has quit IRC | 11:38 | |
| *** mpavone has quit IRC | 11:38 | |
| *** achanda has quit IRC | 11:39 | |
| openstackgerrit | Sean Dague proposed openstack/nova: Deprecate conductor manager option https://review.openstack.org/284332 | 11:41 |
| *** phuongnh has quit IRC | 11:42 | |
| *** cdent has joined #openstack-nova | 11:44 | |
| shaohe_feng | johnthetubaguy: https://review.openstack.org/#/c/258771/35/nova/db/sqlalchemy/api.py@4551 | 11:45 |
| shaohe_feng | johnthetubaguy: should I use migration_get_all_by_filters ? but I need to add a new filter "instance_uuid" | 11:46 |
| sdague | shaohe_feng: no, I think you are right | 11:46 |
| shaohe_feng | sdague: got it. | 11:47 |
| *** davideagle_ has quit IRC | 11:48 | |
| sdague | shaohe_feng: ok, is there a patch I can help with, or are you still working through issues locally? | 11:48 |
| shaohe_feng | sdague: https://review.openstack.org/#/c/258771/35/doc/api_samples/os-migrations/v2.23/migrations-get.json@16 only live migration need the link, and others drop it? | 11:49 |
| sdague | shaohe_feng: right | 11:49 |
| sdague | and put migration_type back into the view | 11:49 |
| shaohe_feng | sdague: got it. | 11:50 |
| sdague | I think it's 2 lines of code change here - https://review.openstack.org/#/c/258771/35/nova/api/openstack/compute/migrations.py@53 | 11:50 |
| sdague | then fixing up the samples to match | 11:50 |
| *** thorst_afk has joined #openstack-nova | 11:50 | |
| alex_xu | shaohe_feng: fyi, if you need help, i'm still at office | 11:50 |
| shaohe_feng | alex_xu: OK. let me clear every comment, and then ping you. | 11:51 |
| shaohe_feng | alex_xu: thanks | 11:51 |
| *** davideagle_ has joined #openstack-nova | 11:51 | |
| alex_xu | shaohe_feng: ok, np | 11:52 |
| shaohe_feng | sdague: https://review.openstack.org/#/c/258771/35/nova/tests/functional/api_sample_tests/test_server_migrations.py@141 I need to construct the instances as johnthetubaguy says? This will take some time to do it. | 11:53 |
| shaohe_feng | alex_xu: you can help me on it. ^ | 11:53 |
| sdague | shaohe_feng: wait, that seems ok | 11:53 |
| sdague | johnthetubaguy: what is your concern there? | 11:53 |
| *** mpavone has joined #openstack-nova | 11:53 | |
| *** mpavone has quit IRC | 11:53 | |
| sdague | shaohe_feng: I actually think instance.create() is fine here | 11:54 |
| shaohe_feng | sdague: let me keep it here. | 11:54 |
| alex_xu | also as my understand, it is sdague prefered | 11:54 |
| sdague | shaohe_feng: yeh, I think - https://review.openstack.org/#/c/258771/35/nova/tests/functional/api_sample_tests/test_server_migrations.py looks fine to me now | 11:54 |
| sdague | I'm not sure what johnthetubaguy's concern is | 11:55 |
| shaohe_feng | sdague: let me fix the link issue for live migration. this need minutes . | 11:55 |
| sdague | shaohe_feng: great, sounds good | 11:55 |
| *** thorst_afk has quit IRC | 11:57 | |
| *** qeelee has quit IRC | 11:58 | |
| *** baoli has joined #openstack-nova | 11:58 | |
| openstackgerrit | Dmitry Stepanenko proposed openstack/nova: Added supports_requests method to PciDeviceList https://review.openstack.org/242087 | 11:59 |
| *** smatzek has joined #openstack-nova | 12:00 | |
| *** ihrachys_ is now known as ihrachys | 12:03 | |
| *** baoli has quit IRC | 12:03 | |
| *** rk4n has quit IRC | 12:04 | |
| *** baoli has joined #openstack-nova | 12:04 | |
| *** Daisy has quit IRC | 12:07 | |
| *** aysyd has joined #openstack-nova | 12:07 | |
| johnthetubaguy | sdague: shaohe_feng: sorry, I stepped away, looking... | 12:07 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: DO_NOT_MERGE https://review.openstack.org/284634 | 12:07 |
| *** Daisy has joined #openstack-nova | 12:07 | |
| *** mubirru has quit IRC | 12:08 | |
| sdague | ndipanov: in https://review.openstack.org/#/c/221162/10/nova/virt/libvirt/driver.py - why are we juggling 2 lists of the instance uuids here? | 12:08 |
| johnthetubaguy | sdague: oh, total missread, sorry shaohe_feng | 12:08 |
| ndipanov | sdague, well one is the uuids we get from libvirt | 12:09 |
| sdague | right | 12:10 |
| ndipanov | sdague, and then I guess we actually don't need the second one | 12:10 |
| ndipanov | since we only need the uuids | 12:10 |
| *** gcb has quit IRC | 12:10 | |
| danpb | you check whether the instance is known to nova before gettnig the BDM | 12:11 |
| *** gcb has joined #openstack-nova | 12:11 | |
| danpb | which needs the local_instances dict | 12:11 |
| danpb | this makes some sense, since libguestfs could create temporary instances | 12:11 |
| ndipanov | danpb, right | 12:11 |
| danpb | and we don't want to fall over if we hit those | 12:11 |
| sdague | ok, but then shouldn't we safely convert in the InstanceList | 12:12 |
| danpb | you could just catch any exception from driver.get_block_device_info() to deal with that | 12:12 |
| sdague | then use that list to loop through | 12:12 |
| *** Daisy has quit IRC | 12:12 | |
| sdague | mostly looping on the original dom list | 12:12 |
| eliqiao_ | hi danpb can you help to check if you can +w on https://review.openstack.org/275585 (libvirt related already has +2) | 12:12 |
| sdague | then checking inline on the other list | 12:12 |
| sdague | seemed kind of confusing | 12:12 |
| *** ccesario has quit IRC | 12:12 | |
| sdague | I do get converting from the dom list to the nova aware list | 12:13 |
| ndipanov | sdague, ah no | 12:13 |
| danpb | actualy, we don't need the local_instances dict in fact | 12:13 |
| ndipanov | we actually need the instance object | 12:13 |
| ndipanov | no we do | 12:13 |
| *** krotscheck_dcm is now known as krotscheck | 12:13 | |
| ndipanov | we need the object | 12:13 |
| ndipanov | see 6960 | 12:13 |
| ndipanov | so that's why | 12:13 |
| danpb | oh you need the nova Instance() objet in order to call get_block_device_info | 12:13 |
| ndipanov | danpb, well I think it actually only uses the root_device :( | 12:14 |
| *** haomaiwang has joined #openstack-nova | 12:14 | |
| ndipanov | which means pulling all of that stuff is a massive waste | 12:14 |
| ndipanov | but... | 12:14 |
| *** daemontool has joined #openstack-nova | 12:14 | |
| danpb | so yeah, i think you really do need both lists here | 12:14 |
| ndipanov | that whole thing is just a big pile of sad really | 12:14 |
| sdague | right, I'm actually ok with that. I was more wondering why the for loop isn't over the Instance() list | 12:14 |
| *** aysyd has quit IRC | 12:15 | |
| ndipanov | sdague, I assume to keep the previous (also wrong) behavior | 12:15 |
| *** baoli has quit IRC | 12:15 | |
| sdague | because it seems like the only reason to do that is to account for non nova libvirt guests, which we say we don't do. And libguestfs ones are short lived enough they shouldn't be an issue. | 12:15 |
| danpb | i wouldn't want to assume they won't be an issue | 12:16 |
| danpb | i could easily see them happening to be alive when this method is called | 12:16 |
| ndipanov | sdague, in the case there is local non-nova instance - local_instances[guest.uuid] blows up | 12:16 |
| ndipanov | so that right there might be a good -1 | 12:16 |
| *** eliqiao has quit IRC | 12:16 | |
| ndipanov | reason | 12:16 |
| sdague | ndipanov: no, it's checked for | 12:17 |
| *** eliqiao_ is now known as eliqiao | 12:17 | |
| *** eliqiao__ has joined #openstack-nova | 12:17 | |
| ndipanov | ah yes | 12:17 |
| *** eliqiao__ is now known as eliqiao_ | 12:17 | |
| *** aysyd has joined #openstack-nova | 12:17 | |
| lpetrut | Hi guys, is there any reason why the LiveMigrateData object is not registered? see the register_if(False) here: https://github.com/openstack/nova/blob/master/nova/objects/migrate_data.py#L27 | 12:17 |
| ndipanov | lpetrut, we never use the superclass | 12:17 |
| *** davideagle_ has quit IRC | 12:18 | |
| ndipanov | but specific driver implementations | 12:18 |
| ndipanov | I think that's why | 12:18 |
| ndipanov | (saw that yesterday and this is what I told myself before moving on) | 12:18 |
| sdague | I guess if the answer is this is the way it's got to be... I can accept it. I just wanted to make sure it had to be this confusing. | 12:18 |
| *** cdelatte has joined #openstack-nova | 12:18 | |
| *** haomaiwang has quit IRC | 12:19 | |
| ndipanov | sdague, I think we need the dom to pass into Guest | 12:19 |
| ndipanov | so that's why it was more convenient to loop over it maybe | 12:19 |
| lpetrut | well, for Hyper-V we don't use this object at all, so we don't have a driver specific implementation. Basically, the super class will always be used. Now, the idea is that the fact that this object is not registered, breaks live migration for Hyper-V :) | 12:19 |
| ndipanov | lpetrut, I guess you want to have a subclass? | 12:19 |
| ndipanov | which does nothing | 12:20 |
| ndipanov | (no idea) | 12:20 |
| *** baoli has joined #openstack-nova | 12:20 | |
| *** jwcroppe has joined #openstack-nova | 12:20 | |
| *** salv-orlando has joined #openstack-nova | 12:20 | |
| lpetrut | that would make sense, we could return a generic object here: https://github.com/openstack/nova/blob/master/nova/objects/migrate_data.py#L60 | 12:20 |
| lpetrut | so that we don't break other drivers (vmware may be affected as well) | 12:21 |
| ndipanov | lpetrut, yeah we should probably register it actually... | 12:21 |
| ndipanov | ping dansmith once he's on | 12:21 |
| lpetrut | great, thanks | 12:21 |
| ndipanov | sdague, so looking at that code again... bdms[guest.uuid] blow up? | 12:22 |
| ndipanov | can* | 12:22 |
| *** baoli has quit IRC | 12:23 | |
| *** mingyu has quit IRC | 12:24 | |
| sdague | I don't know. What the bdmslist behavior for the empty case? | 12:24 |
| *** mingyu has joined #openstack-nova | 12:24 | |
| johnthetubaguy | danpb: it would be great if you could double check how the live-migrate is being cancelled, its likely to be a follow up patch at this point, but just wondered if you had any ideas around it: https://review.openstack.org/#/c/277971/18/nova/virt/libvirt/driver.py | 12:24 |
| danpb | johnthetubaguy: what do mean exactly ? | 12:25 |
| *** ccesario has joined #openstack-nova | 12:25 | |
| johnthetubaguy | danpb: we call abortJob, but its not clear to me if thats actually live-migrate or not, it feels like it could be a bit racey | 12:25 |
| danpb | i already answered that on patch 14 | 12:26 |
| danpb | it is fine because nova checks that the VM is in the migrating state | 12:26 |
| danpb | and nothing in nova will start a different kind of job while in that state | 12:26 |
| johnthetubaguy | danpb: yeah, I see that now, it just doesn't feel very safe | 12:26 |
| sdague | johnthetubaguy: I think if we see it as an issue later we can address it | 12:27 |
| sdague | but I think for this patch land, it's as good as it gets | 12:27 |
| danpb | there's not actually anything else in libvirt that uses that job facility now anyway | 12:27 |
| danpb | the drive mirror stuff uses a block job facility, which is per-disk instead of per-domain | 12:27 |
| johnthetubaguy | danpb: ah, OK | 12:28 |
| johnthetubaguy | it feels like we are safe enough for now | 12:28 |
| danpb | getType() doesn't do what you think it does btw | 12:28 |
| johnthetubaguy | danpb: I was worried you might say that | 12:28 |
| danpb | it just tells you whether the job is unbounded execution time, or finite execution time | 12:28 |
| johnthetubaguy | oh, right | 12:29 |
| *** mingyu has quit IRC | 12:29 | |
| *** mingyu has joined #openstack-nova | 12:29 | |
| PaulMurray | johnthetubaguy, danpb the check for the migrating task state in the API is only really safe so long as the abort action doesn't get over taken between the API server and the compute manager by another request that came in through another API server | 12:31 |
| *** amotoki_ has joined #openstack-nova | 12:32 | |
| danpb | PaulMurray: could add a check int eh compute manager then | 12:32 |
| PaulMurray | danpb, yes, that was what I was thingking | 12:32 |
| PaulMurray | its like the scheduler stuff checking in the compute manager again | 12:32 |
| *** raildo-afk is now known as raildo | 12:32 | |
| sdague | yeh, I think the code we have is as good as it gets right now. I'd not overthink this one. | 12:32 |
| johnthetubaguy | PaulMurray: yeah, it was that case I am worrying about, lets do this as a follow up patch | 12:32 |
| PaulMurray | johnthetubaguy, sounds good - I'll comment on it in the patch | 12:33 |
| alex_xu | sdague: I think we won't fix this, right? https://review.openstack.org/#/c/284068 | 12:33 |
| sdague | johnthetubaguy: this is an admin API. I think if a site has multiple admin tools playing whack-a-mole with starting / deleting live migrations they probably have bigger issues. | 12:34 |
| alex_xu | sdague: it is related to what we will return in https://review.openstack.org/277971 | 12:34 |
| *** davideagle_ has joined #openstack-nova | 12:34 | |
| *** rk4n has joined #openstack-nova | 12:34 | |
| *** claudiub has quit IRC | 12:34 | |
| *** amotoki has quit IRC | 12:34 | |
| sdague | alex_xu: sorry, I've got other context in my head. Can you narrow the question | 12:35 |
| openstackgerrit | Gleb Stepanov proposed openstack/nova: Console log copy for block live migratiob https://review.openstack.org/284674 | 12:37 |
| alex_xu | sdague: sorry for just jump in. This patch https://review.openstack.org/#/c/284068 try to fix InvalidMigrationState from 400 to 409, but we just decde return 400 in https://review.openstack.org/277971, we better ensure what we want to return before merge 277971 | 12:37 |
| * andrearosa goes for lunch | 12:38 | |
| *** markvoelker has joined #openstack-nova | 12:40 | |
| *** mnestratov|2 has joined #openstack-nova | 12:41 | |
| sdague | alex_xu: I'd say just keep the 400 for now. Honestly, I'm mostly of the camp that using more than 400, 403, 404 isn't really useful | 12:41 |
| *** sfinucan_ has joined #openstack-nova | 12:41 | |
| *** sfinucan has quit IRC | 12:42 | |
| pkoniszewski | sdague: alex_xu: this is something that johnthetubaguy pointed, that we are here inconsistent with API guideline | 12:42 |
| BobBall | sdague: Do you have the powah to re-add the Citrix CI (uid 10385) to the nova-ci group? | 12:42 |
| sdague | BobBall: nope | 12:43 |
| johnthetubaguy | BobBall: I might, let me check | 12:43 |
| johnthetubaguy | I guess its fixed now right | 12:43 |
| BobBall | ah - awesome thanks johnthetubaguy | 12:43 |
| BobBall | yup. Guess you missed my request earlier :D | 12:43 |
| *** takedakn has joined #openstack-nova | 12:43 | |
| johnthetubaguy | BobBall: didn't see anything earlier, but I did loose IRC for a bit, so you might have hit that outage! | 12:44 |
| *** mnestratov has quit IRC | 12:44 | |
| alex_xu | sdague: ok, at least 400->409 need another microversion I think, so leave that discussion to 284068 | 12:44 |
| johnthetubaguy | BobBall: actually, I am just blind | 12:44 |
| BobBall | No worries either way :) | 12:44 |
| sdague | pkoniszewski: I do get that, I also don't think that anyone is realistically coding to our status codes, because they are all over the map | 12:44 |
| *** markvoelker has quit IRC | 12:44 | |
| sdague | and they aren't enough information to make a decision | 12:44 |
| johnthetubaguy | my main worry was keeping the two new APIs consistent, if we can | 12:45 |
| pkoniszewski | i think that abort is consistent with force already | 12:45 |
| johnthetubaguy | now, honestly, its all 4xx which is the bit I am mostly worried about | 12:45 |
| sdague | the only way we get programatic recovery on errors is with structured error docs | 12:45 |
| johnthetubaguy | so thinking on this, I do worry that GET produces a 404 but the POST action gives a 400, that seems a little odd to me, but I don't really want to loose too much sleep over it | 12:46 |
| * johnthetubaguy notices low energy, and the time, goes to eat... | 12:47 | |
| BobBall | johnthetubaguy: Thanks - turned on voting again and the first 6 incorrect -1's have been fixed to +1s | 12:47 |
| *** rk4n has quit IRC | 12:47 | |
| BobBall | johnthetubaguy: Re-running all failed tests in the last 24 hours now - so will take some time. | 12:48 |
| *** MCoLo has quit IRC | 12:48 | |
| johnthetubaguy | BobBall: sweet | 12:48 |
| BobBall | sdague: and btw, thanks for pointing me at the project-config fix - shortened the time to getting it back up and running. I would have really struggled to understand what was going on without that :) | 12:48 |
| *** thorst_afk has joined #openstack-nova | 12:50 | |
| sdague | BobBall: why does the xenserver-ci use a devstack-gate fork? | 12:50 |
| sdague | that seems to make you pretty susceptible to breaks there, and not be able to take fixes | 12:50 |
| *** takedakn has quit IRC | 12:50 | |
| *** rk4n has joined #openstack-nova | 12:51 | |
| BobBall | sdague: yup... https://github.com/citrix-openstack/devstack-gate/commits/master Main issue is we don't use ZUUL so don't have zuul-merger running and need to merge ZUUL_REF. | 12:51 |
| sdague | BobBall: ah | 12:51 |
| sdague | is that a thing you are going to change? | 12:52 |
| BobBall | Yes. | 12:52 |
| BobBall | *really hopes that sdague doesn't ask "when" as the next question* | 12:52 |
| *** abhishekk_ has quit IRC | 12:52 | |
| sdague | heh | 12:52 |
| BobBall | No, but seriously, we've got a project in the works ATM to set up YAJI (yet another jenkins instance) which I hope to migrate this to. | 12:53 |
| *** jwcroppe has quit IRC | 12:53 | |
| BobBall | Main blocker is I want to use upstream nodepool first - but that'll need us to change our hideously complex image building so that we don't need to reboot the node several times during image creation ;) | 12:54 |
| BobBall | So who knows - it might be just a couple of weeks before it's all shifted over to the third party CI puppet stuff | 12:55 |
| *** gcb has quit IRC | 12:55 | |
| *** aagrawal has quit IRC | 12:57 | |
| *** mingyu has quit IRC | 12:58 | |
| *** mingyu has joined #openstack-nova | 12:58 | |
| *** claudiub has joined #openstack-nova | 13:03 | |
| openstackgerrit | Gleb Stepanov proposed openstack/nova: Fix backing file copying https://review.openstack.org/282275 | 13:06 |
| *** zenoway has quit IRC | 13:09 | |
| *** lucasagomes is now known as lucas-hungry | 13:09 | |
| *** zenoway has joined #openstack-nova | 13:09 | |
| *** baoli has joined #openstack-nova | 13:10 | |
| *** ducttape_ has joined #openstack-nova | 13:13 | |
| *** mingyu has quit IRC | 13:14 | |
| *** mingyu has joined #openstack-nova | 13:14 | |
| *** daemontool has quit IRC | 13:15 | |
| *** MCoLo has joined #openstack-nova | 13:15 | |
| *** daemontool has joined #openstack-nova | 13:16 | |
| cdent | jaypipes: When you get a chance can you gaze upon this and let me know if I'm heading in the right direction. It's been harder than usual to tease out the object's interface: https://review.openstack.org/#/c/284963/ | 13:16 |
| cdent | It's far from done, but I don't want to get too far along and find it is all wrong. | 13:16 |
| *** daemontool has quit IRC | 13:17 | |
| *** baoli_ has joined #openstack-nova | 13:17 | |
| *** daemontool has joined #openstack-nova | 13:18 | |
| *** mingyu has quit IRC | 13:18 | |
| *** mingyu has joined #openstack-nova | 13:18 | |
| *** thorst_afk is now known as thorst | 13:18 | |
| kashyap | johnthetubaguy: Heya, when you get a moment, do you mind taking a re-look at this? -- https://review.openstack.org/#/c/168916/ | 13:19 |
| *** markvoelker has joined #openstack-nova | 13:20 | |
| kashyap | Pinging you explicitly because, you noted a couple of concerns before. | 13:20 |
| *** baoli has quit IRC | 13:20 | |
| kashyap | There've been more than a few revisions after that. Thanks! | 13:20 |
| sfinucan_ | ndipanov: In your opinion, what _should_ happen if someone requests a pinned instance without enabling the NUMATopologyFilter? | 13:21 |
| sfinucan_ | In fact, should it have anything to do with pinning? | 13:22 |
| *** mnestratov has joined #openstack-nova | 13:23 | |
| *** tomoiaga has quit IRC | 13:23 | |
| *** ric has joined #openstack-nova | 13:23 | |
| *** daemontool has quit IRC | 13:24 | |
| *** brad[] has joined #openstack-nova | 13:25 | |
| ndipanov | sfinucan_, well currently it will work it will just not be considered when scheduling | 13:26 |
| *** mnestratov|2 has quit IRC | 13:26 | |
| sfinucan_ | ndipanov: Hmm, so we need to duplicate all of the checks provided by filters in case said filters are disabled? | 13:28 |
| sfinucan_ | e.g. make sure there's enough memory available in case someone disabled the RAMFilter? | 13:28 |
| sfinucan_ | Just making sure I'm not duplicating stuff without a good reason... :) | 13:29 |
| *** sfinucan_ has quit IRC | 13:31 | |
| ndipanov | left | 13:32 |
| ndipanov | how rude :) | 13:32 |
| *** sfinucan has joined #openstack-nova | 13:32 | |
| ndipanov | jus kidding | 13:32 |
| ndipanov | sfinucan, so | 13:32 |
| johnthetubaguy | kashyap: does that generate a 500 response from the API? | 13:32 |
| ndipanov | that's why we have thos horrible limits kwarg | 13:32 |
| ndipanov | sfinucan, that's how the scheduler tells the compute node what needs to be "claimed" | 13:32 |
| kashyap | johnthetubaguy: I'm still catching up with comments on that review | 13:33 |
| ndipanov | but cpu pinning works a bit differently | 13:33 |
| openstackgerrit | ShaoHe Feng proposed openstack/nova: Add new APIs and deprecate old API for migrations https://review.openstack.org/258771 | 13:33 |
| shaohe_feng | sdague: I have update a new version. add only add link for in progress live migration. and add testcases for it. | 13:33 |
| ndipanov | maybe we should change that | 13:33 |
| shaohe_feng | johnthetubaguy: ^ | 13:34 |
| sfinucan | ndipanov: I think so | 13:34 |
| sfinucan | Stumbled upon this issue purely by accident https://bugs.launchpad.net/nova/+bug/1550269. One of those "oh, I never thought of that" bugs | 13:35 |
| openstack | Launchpad bug 1550269 in OpenStack Compute (nova) "'hw:cpu_thread_policy=require' does not function correctly if NUMATopologyFilter is disabled" [Undecided,In progress] - Assigned to Stephen Finucane (sfinucan) | 13:35 |
| pkoniszewski | johnthetubaguy: yes, it reports 500 | 13:35 |
| sfinucan | Something for N, perhaps | 13:35 |
| pkoniszewski | johnthetubaguy: it reraises oslo messaging exception after putting VM in ERROR state | 13:35 |
| *** ducttape_ has quit IRC | 13:35 | |
| johnthetubaguy | pkoniszewski: that does feel a bit terrible, returning the 500 | 13:35 |
| pkoniszewski | well, it is really an internal error, but... | 13:35 |
| *** fawadkhaliq has joined #openstack-nova | 13:36 | |
| pkoniszewski | but im really thinking of abandoning this one and saying that it's fine that we leave VM in migrating state when there is a mess in messaging | 13:36 |
| johnthetubaguy | pkoniszewski: yeah, just thinking through the options | 13:36 |
| johnthetubaguy | pkoniszewski: that is a much worse option | 13:36 |
| pkoniszewski | we really don't know what happened and putting VM in error state might be error-prone | 13:36 |
| johnthetubaguy | no, thats totally the correct thing to do | 13:36 |
| pkoniszewski | ok | 13:36 |
| pkoniszewski | im thinking of situation that we need to check VM state somewhere below | 13:37 |
| johnthetubaguy | we do that in lots of places for exactly this case, arg, something bad has happened, we should stop now | 13:37 |
| pkoniszewski | we will hide real state of a VM, it might be ACTIVE or PAUSED | 13:37 |
| johnthetubaguy | pkoniszewski: we usually do, in the save using expected state calls | 13:37 |
| johnthetubaguy | yes, we hide it, because the most important thing is the admin needs to go an clean up the mess | 13:37 |
| *** achanda has joined #openstack-nova | 13:37 | |
| shaohe_feng | sdague: johnthetubaguy: the test case include 4 cases: 1: in progress live migration, add link and migrate_type. 2. non in-progress live migration(such as errorr), do not add link and migrate_type 3, in-progress non live migration 4, non in-progress non live migration | 13:38 |
| *** haomaiwang has joined #openstack-nova | 13:38 | |
| kashyap | pkoniszewski: Ah, you're here and already responded to John. Cool | 13:39 |
| sdague | shaohe_feng: great, give me 5 minutes and I'll look through it | 13:39 |
| shaohe_feng | sdague: Thank you. | 13:39 |
| pkoniszewski | kashyap: thanks for bringing this up, i have a mess in my head regarding this issue | 13:39 |
| sdague | shaohe_feng: migration_type should be listed for all the migrations in the list, right? | 13:40 |
| *** edleafe is now known as figleaf | 13:40 | |
| sdague | shaohe_feng: yeh, sorry, if I wasn't clear on that | 13:40 |
| sdague | delete the else on https://review.openstack.org/#/c/258771/36/nova/api/openstack/compute/migrations.py | 13:40 |
| sdague | 69-70 | 13:41 |
| kashyap | pkoniszewski: No worries, I haven't reproduced the issue myself yet. Trying to narrow down to a smaller reproducer on a single-node DevStack on my laptop | 13:41 |
| johnthetubaguy | pkoniszewski: hmm, I might be coming around to your thinking, the messaging timeout may or may not mean there is a problem... | 13:41 |
| pkoniszewski | so in case we put VM to error and we will check only for ACTIVE/PAUSE states in .save() we will make even bigger mes | 13:41 |
| johnthetubaguy | kashyap: put a sleep statement in the compute task API, that should do it | 13:41 |
| pkoniszewski | exactly, this is really weird scenario | 13:41 |
| shaohe_feng | sdague: OK, let me fix it. | 13:41 |
| kashyap | johnthetubaguy: Ah, that sounds simplest, one minute is enough? - time.sleep(60) | 13:42 |
| pkoniszewski | there is a chance that conductor will consume message but will not respond | 13:42 |
| pkoniszewski | kashyap: yes, it should be | 13:42 |
| shaohe_feng | sdague: above 2.23, we add migrate_type for all. right? but links just for in progress live migration. | 13:42 |
| sdague | shaohe_feng: yes | 13:42 |
| pkoniszewski | or comput api will not even reach conductor... | 13:42 |
| *** achanda has quit IRC | 13:42 | |
| kashyap | Okay, will go for it | 13:42 |
| kashyap | Thanks | 13:42 |
| sdague | shaohe_feng: I really think you just have to delete the else and we're good | 13:43 |
| sdague | as well as update the samples to match that | 13:43 |
| johnthetubaguy | kashyap: depends on your config for the RPC timeout | 13:43 |
| shaohe_feng | sdague: OK. got it. you need to wait. I also need to update the test case. you know the testcase always takes me some time. | 13:43 |
| kashyap | johnthetubaguy: Yep, I'll check that too, and do a bit of heuristics | 13:43 |
| sdague | shaohe_feng: yep | 13:43 |
| sdague | shaohe_feng: I think everything else in th patch seems reasonable at this point | 13:44 |
| sdague | johnthetubaguy: can you go through it as well? | 13:44 |
| shaohe_feng | sdague: OK. let me fix the last issue ASAP. | 13:44 |
| johnthetubaguy | sdague: yes, I will jump on that in 5 mins after this bug things kashyap pkoniszewski are asking about | 13:45 |
| sdague | ok | 13:45 |
| *** ccarmack has joined #openstack-nova | 13:45 | |
| *** ric has quit IRC | 13:47 | |
| johnthetubaguy | pkoniszewski kashyap attempted to dump my current thinking on that patch now, its a bit rambling, and basically says, maybe don't set the instance to error, because the most likely case is that the live-migrate will complete, despite the timeout, and if it fails, most likely the conductor will set it to error anyways | 13:49 |
| *** jwcroppe has joined #openstack-nova | 13:50 | |
| *** edmondsw has joined #openstack-nova | 13:50 | |
| kashyap | johnthetubaguy: Thanks, I began following that change only since yesterday. I notice that it still needs more thought | 13:51 |
| johnthetubaguy | sdague: shaohe_feng: do we want an empty list of links by default, when its not in progress? | 13:52 |
| johnthetubaguy | or is that messier | 13:52 |
| pkoniszewski | johnthetubaguy: i will go through your comment, thanks | 13:54 |
| *** dims has joined #openstack-nova | 13:54 | |
| *** daemontool has joined #openstack-nova | 13:54 | |
| sdague | johnthetubaguy: I think that's messier | 13:55 |
| alex_xu | shaohe_feng: I thought we should always return migration_type? | 13:56 |
| sdague | alex_xu: yeh, he's working on that now | 13:56 |
| alex_xu | sdague: ah, ok, got it | 13:56 |
| *** armax has joined #openstack-nova | 13:57 | |
| sdague | I'll put that comment in the review, I just gave the feedback here | 13:57 |
| *** ljxiash has joined #openstack-nova | 13:57 | |
| *** jwcroppe has quit IRC | 13:58 | |
| openstackgerrit | ShaoHe Feng proposed openstack/nova: Add new APIs and deprecate old API for migrations https://review.openstack.org/258771 | 14:00 |
| bauzas | johnthetubaguy: (currently on PTO but wanting to discuss with you) | 14:00 |
| *** haomaiwang has quit IRC | 14:01 | |
| *** mjura has quit IRC | 14:01 | |
| *** haomaiwang has joined #openstack-nova | 14:01 | |
| bauzas | johnthetubaguy: so, in https://review.openstack.org/#/c/284959/2/nova/cells/rpcapi.py@119 you asked to provide a version ? | 14:01 |
| johnthetubaguy | bauzas: part of me wants to force you to go enjoy your PTO, but looking | 14:01 |
| bauzas | johnthetubaguy: if so, that would need to modify the RPC API and Manager, right? | 14:01 |
| johnthetubaguy | bauzas: yes | 14:01 |
| *** ljxiash has quit IRC | 14:01 | |
| bauzas | mmmm | 14:02 |
| shaohe_feng | sdague: https://review.openstack.org/#/c/258771/37/nova/api/openstack/compute/migrations.py@70 | 14:02 |
| shaohe_feng | sdague: update it. also update testcase. | 14:02 |
| bauzas | johnthetubaguy: as I discussed with alaski (also on PTO), we agreed on not providing the RequestSpec for the cells v1 - hence my commit msg | 14:02 |
| bauzas | johnthetubaguy: but sure, I can work for that | 14:03 |
| johnthetubaguy | bauzas: I mean its not needed right, and agreed we don't need to pass the request spec down | 14:03 |
| johnthetubaguy | s/needed/required/ | 14:03 |
| bauzas | TBH, my main concern is that we would have to merge it soon | 14:03 |
| johnthetubaguy | true | 14:03 |
| bauzas | okay, let's discuss it back on Monday - since that's a bugfix, we can merge it after m3 | 14:04 |
| johnthetubaguy | bauzas: +1 lets talk monday | 14:04 |
| bauzas | honestly, taking a PTO when you are alone with your last daughter sleeping makes you looking at your computer :D | 14:05 |
| *** rlrossit has joined #openstack-nova | 14:06 | |
| *** mdrabe has joined #openstack-nova | 14:06 | |
| shaohe_feng | sdague: sorry, https://review.openstack.org/#/c/258771/37/nova/api/openstack/api_version_request.py@69 I think some doc still need to update it. change it to "Add ref link and migration_type for /os-migrations" | 14:06 |
| *** clenimar has joined #openstack-nova | 14:06 | |
| shaohe_feng | sdague: let me update a new version to fix doc string. the Patch is some bigger, easy to miss something. | 14:07 |
| bauzas | jaypipes: edleafe: can see 2 changes having the same topic https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:compute-node-db-resource-providers | 14:07 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Remove unused methods in nova/utils.py https://review.openstack.org/284580 | 14:08 |
| clenimar | auggy: hey :) | 14:08 |
| *** zhangjn has quit IRC | 14:08 | |
| sdague | shaohe_feng: ok, I'm also ok with doc fixes as a follow up patch | 14:08 |
| sdague | the core logic of this patch, and the samples all look good to me | 14:08 |
| sdague | shaohe_feng: but ifyou can fix the docs quick, I'm good with that as well | 14:09 |
| *** zhangjn has joined #openstack-nova | 14:09 | |
| andrearosa | shaohe_feng: sdague good I am going to rebase my patch on top of the shaoe_feng PS37 | 14:09 |
| shaohe_feng | sdague: OK. let me fix it ASAP. | 14:09 |
| shaohe_feng | andrearosa: I need to fix some doc string. | 14:10 |
| *** Bjoern_ has joined #openstack-nova | 14:11 | |
| *** Bjoern_ is now known as Bjoern_zZzZzZzZ | 14:11 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Fix string interpolations at logging calls https://review.openstack.org/281627 | 14:11 |
| *** Bjoern_zZzZzZzZ is now known as Bjoern_ | 14:12 | |
| andrearosa | shaohe_feng: saw that but that should be a trivial rebase for me | 14:12 |
| *** takedakn has joined #openstack-nova | 14:13 | |
| *** ctrath has joined #openstack-nova | 14:13 | |
| *** takedakn has quit IRC | 14:14 | |
| *** EinstCrazy has quit IRC | 14:14 | |
| *** Zaina has left #openstack-nova | 14:15 | |
| *** rtheis has joined #openstack-nova | 14:15 | |
| *** daemontool has quit IRC | 14:16 | |
| *** daemontool has joined #openstack-nova | 14:16 | |
| *** xyang1 has joined #openstack-nova | 14:17 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova: virt/hardware: Fix 'isolate' case on non-SMT hosts https://review.openstack.org/285321 | 14:17 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: virt/hardware: Add diagnostic logs for scheduling https://review.openstack.org/285322 | 14:17 |
| openstackgerrit | Dmitry Stepanenko proposed openstack/nova: Added supports_requests method to PciDeviceList https://review.openstack.org/242087 | 14:18 |
| *** daemontool_ has joined #openstack-nova | 14:18 | |
| jaypipes | bauzas: yeah, edleafe's build on my first one. | 14:20 |
| bauzas | jaypipes: yup, I saw that, thanks | 14:20 |
| * bauzas says bye again | 14:21 | |
| *** jaypipes is now known as sicklypipes | 14:22 | |
| *** daemontool has quit IRC | 14:22 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova: libvirt: Always test if instance storage is shared https://review.openstack.org/281913 | 14:23 |
| *** lucas-hungry is now known as lucasagomes | 14:23 | |
| *** jichen has quit IRC | 14:24 | |
| sicklypipes | sdague: not sure I'd classify https://bugs.launchpad.net/nova/+bug/1549984 as Low, really. it's a data corruption/state corruption bug in my opinion. | 14:25 |
| openstack | Launchpad bug 1549984 in OpenStack Compute (nova) "PCI devices claimed on compute node during _claim_test()" [Low,Confirmed] - Assigned to Jay Pipes (jaypipes) | 14:25 |
| *** burt has joined #openstack-nova | 14:25 | |
| sfinucan | ndipanov: Not sure when bug fixes stop going in, but there are patches for three pinning-related bugs hanging out on Gerrit now (#1550317, #1550269, #1417723) | 14:25 |
| sfinucan | (they're bug numbers) | 14:25 |
| ndipanov | sfinucan, they never stop going in | 14:25 |
| *** nkrinner has quit IRC | 14:26 | |
| ndipanov | sfinucan, but the fact that you assumed they do speaks volumes imho ;) | 14:26 |
| sfinucan | ndipanov: Even after mitaka-3? | 14:26 |
| sdague | sicklypipes: if you want to change priority feel free, you left it in new / undecided | 14:26 |
| shaohe_feng | andrearosa: yes. so sorry block you. | 14:26 |
| ndipanov | sfinucan, you added me to those bugs yes? | 14:27 |
| sicklypipes | sdague: yes, I know because I didn't feel correct setting the priority and status myself :) | 14:27 |
| sfinucan | ndipanov: Sure did | 14:27 |
| sdague | sicklypipes: oh, you should totally set it yourself if you feel like yuo know the answers | 14:27 |
| ndipanov | sfinucan, yeah I have them marked in my inbox | 14:27 |
| sfinucan | ndipanov: Moving onto investigation of that shelve/resize, which is apparently still broken per the Intel NFV CI :( | 14:27 |
| andrearosa | shaohe_feng: np at all, thanks for pushing on that patch | 14:27 |
| sfinucan | not as broken as it was though, which is progress? :) | 14:28 |
| ndipanov | sfinucan, I saw the fail - I don't think it's related | 14:28 |
| ndipanov | sfinucan, personally | 14:28 |
| *** baoli has joined #openstack-nova | 14:28 | |
| sicklypipes | sdague: I'm not trying to be funny, Sean. | 14:29 |
| sdague | sicklypipes: ... ? | 14:29 |
| openstackgerrit | ShaoHe Feng proposed openstack/nova: Add new APIs and deprecate old API for migrations https://review.openstack.org/258771 | 14:29 |
| shaohe_feng | andrearosa: ^ | 14:29 |
| sicklypipes | sdague: I thought you were saying that I thought I knew all the answers. That's not what I'm trying to say. | 14:30 |
| andrearosa | shaohe_feng: ack | 14:30 |
| sdague | sicklypipes: no, sorry, I meant that if you have an opinion on the severity of a bug, please set it when you create it | 14:30 |
| sicklypipes | sdague: ah, ok. | 14:30 |
| sdague | and move to confirmed if you are sure it's a thing | 14:30 |
| shaohe_feng | sdague: I have update a new one. to fix doc string for add a new migration_type. 3 doc strings update. | 14:31 |
| sdague | otherwise it's just generated load on bug triage team to try to guess answers when you already had that info | 14:31 |
| *** baoli_ has quit IRC | 14:31 | |
| sdague | shaohe_feng: ok, looking now | 14:32 |
| shaohe_feng | sdague: thank you. | 14:32 |
| sdague | shaohe_feng: lgtm | 14:32 |
| sdague | +2 | 14:32 |
| figleaf | sicklypipes: yes, I copied you topic. Is that incorrect? If so, I'll change i | 14:32 |
| figleaf | it | 14:32 |
| sicklypipes | figleaf: no, was cool with me. | 14:33 |
| cdent | sicklypipes: a) sorry you sick b) did you see my earlier request for "am i on the right track" feedback on https://review.openstack.org/#/c/284963/ , if not here it is again pretty please | 14:33 |
| sicklypipes | cdent: will look at that shortly. sorry :( | 14:33 |
| shaohe_feng | sdague: thank you. now I'm glad to go home. | 14:34 |
| sdague | shaohe_feng: thanks for all your hard work here | 14:34 |
| cdent | sicklypipes: s'alright, I'm just not terribly confident on this one so don't want to wander too far afield | 14:34 |
| figleaf | sicklypipes: ah, ok. Wasn't sure if that screwed up people's dashboards or anything | 14:34 |
| sdague | johnthetubaguy / alex_xu I'm going afk for a bit. I think https://review.openstack.org/258771 is ready to go | 14:35 |
| sicklypipes | figleaf: nah, I think the problem was the commit summary was virtually idential :) | 14:35 |
| sicklypipes | identical. | 14:35 |
| alex_xu | sdague: nothing from me also | 14:35 |
| *** mingyu has quit IRC | 14:35 | |
| shaohe_feng | sdague: happy to do it. have a nice weekend. bye. | 14:35 |
| *** baoli has quit IRC | 14:35 | |
| *** erno has quit IRC | 14:35 | |
| *** mingyu has joined #openstack-nova | 14:35 | |
| johnthetubaguy | sdague: alex_xu: same here | 14:36 |
| *** davideagle_ has quit IRC | 14:36 | |
| *** su_zhang has joined #openstack-nova | 14:36 | |
| alex_xu | johnthetubaguy: I done the +w | 14:36 |
| *** amotoki_ has quit IRC | 14:36 | |
| *** dansmith is now known as superdan | 14:36 | |
| *** mingyu has quit IRC | 14:36 | |
| *** mingyu has joined #openstack-nova | 14:36 | |
| openstackgerrit | garyk proposed openstack/nova: VMware: remove deprecation warnings from oslo_versionedobjects https://review.openstack.org/284286 | 14:37 |
| *** ljxiash has joined #openstack-nova | 14:37 | |
| sdague | ok, so andrearosa just needs to respin his on top of it, mostly cleaning up the samples tests, and then that will be ready to go | 14:38 |
| andrearosa | sdague: I am on it | 14:38 |
| sdague | I should be back in an hour or so to check that out | 14:38 |
| openstackgerrit | Dmitry Stepanenko proposed openstack/nova: Go away from using PciDeviceStats consume_requests https://review.openstack.org/243131 | 14:40 |
| openstackgerrit | Dmitry Stepanenko proposed openstack/nova: Deprecate ComputeNode pci_device_pools field https://review.openstack.org/247692 | 14:40 |
| openstackgerrit | Dmitry Stepanenko proposed openstack/nova: Add PciDevicePoolList.get_all method https://review.openstack.org/250757 | 14:40 |
| *** paul-carlton1 has quit IRC | 14:40 | |
| *** eharney has joined #openstack-nova | 14:42 | |
| *** knikolla has joined #openstack-nova | 14:43 | |
| *** davideagle_ has joined #openstack-nova | 14:44 | |
| *** sc68cal has joined #openstack-nova | 14:44 | |
| *** inc0 has joined #openstack-nova | 14:45 | |
| *** chhavi has joined #openstack-nova | 14:45 | |
| *** gcb has joined #openstack-nova | 14:46 | |
| *** amotoki has joined #openstack-nova | 14:48 | |
| *** mingyu has quit IRC | 14:50 | |
| *** mingyu has joined #openstack-nova | 14:50 | |
| *** inc0 has quit IRC | 14:50 | |
| *** baoli has joined #openstack-nova | 14:51 | |
| *** zz_dimtruck is now known as dimtruck | 14:53 | |
| *** jwcroppe has joined #openstack-nova | 14:54 | |
| *** fawadkhaliq has quit IRC | 14:55 | |
| *** sfinucan has quit IRC | 14:55 | |
| *** ducttape_ has joined #openstack-nova | 14:56 | |
| superdan | sdague: I don't understand your comment here: https://review.openstack.org/#/c/284905/ | 14:58 |
| *** mriedem has joined #openstack-nova | 14:58 | |
| *** READ10 has joined #openstack-nova | 14:59 | |
| *** edtubill has joined #openstack-nova | 15:00 | |
| *** haomaiwang has quit IRC | 15:01 | |
| *** daemontool_ has quit IRC | 15:01 | |
| *** haomaiwang has joined #openstack-nova | 15:01 | |
| *** amotoki has quit IRC | 15:02 | |
| *** mrkz has joined #openstack-nova | 15:03 | |
| *** delattec has joined #openstack-nova | 15:04 | |
| *** daemontool has joined #openstack-nova | 15:05 | |
| cdent | thanks very much for the comment figleaf, most of the problems your seeing are the result of "aw, screw it, it's late, I'm tired, I'm going to bed, but I'd like to leave something for people to look at" | 15:06 |
| figleaf | cdent: yeah, I kinda figured that. | 15:06 |
| *** cdelatte has quit IRC | 15:06 | |
| figleaf | Just wanted to add those notes | 15:06 |
| cdent | yeah, is useful to have | 15:06 |
| figleaf | Believe me, I could have been much more naggy, but I'm in a good mood :) | 15:07 |
| cdent | in case its not obviousl, I'm tdd-ing, and the cleanup will come much later | 15:07 |
| *** burgerk has joined #openstack-nova | 15:08 | |
| figleaf | cdent: heh, that's why I never took to TDD that strongly. Once I get it working I want to move on, no go back and tidy up. | 15:08 |
| cdent | In this case I had to tdd because I had no idea what I was trying to create, except for something that could answer the api described in the spec and the distance of that from an ovo is sizable | 15:09 |
| *** jwcroppe has quit IRC | 15:11 | |
| figleaf | cdent: I'm sure superdan will find all sorts of improvements. My ovo-fu is not all that strong | 15:11 |
| cdent | I'm sure he will | 15:13 |
| mriedem | good morning! | 15:14 |
| *** irenab has joined #openstack-nova | 15:14 | |
| *** paul-carlton1 has joined #openstack-nova | 15:14 | |
| *** inc0 has joined #openstack-nova | 15:23 | |
| PaulMurray | johnthetubaguy, sdague thanks for working along with andrearosa and shaohe_feng - I've been watching but busy this morning | 15:24 |
| PaulMurray | alex_xu, ^^ | 15:24 |
| *** baoli has quit IRC | 15:24 | |
| *** aorourke-afk is now known as aorourke | 15:24 | |
| *** achanda has joined #openstack-nova | 15:24 | |
| *** nikhil has joined #openstack-nova | 15:25 | |
| *** delatte has joined #openstack-nova | 15:28 | |
| *** jschlueter has quit IRC | 15:29 | |
| *** gcb has quit IRC | 15:30 | |
| *** delattec has quit IRC | 15:30 | |
| *** davideagle_ has quit IRC | 15:31 | |
| openstackgerrit | Andrea Rosa proposed openstack/nova: Abort an ongoing live migration https://review.openstack.org/277971 | 15:31 |
| *** davideagle_ has joined #openstack-nova | 15:33 | |
| *** mubirru has joined #openstack-nova | 15:33 | |
| *** lyanchih has joined #openstack-nova | 15:35 | |
| andrearosa | sdague: I put a new patch, not 100% sure about a thing in the functional tests, I put my doubt in gerrit, can you have a look when you have time, please? | 15:36 |
| sdague | andrearosa: sure, will look now | 15:37 |
| openstackgerrit | Petrut Lucian proposed openstack/nova: objects: register LiveMigrateData https://review.openstack.org/285370 | 15:38 |
| *** baoli has joined #openstack-nova | 15:39 | |
| sdague | superdan: in that same test file there are times when do_test does not get called directly, but only through assertRaises. I honestly don't know enough ast depth to know if that's going to catch those cases. | 15:40 |
| superdan | sdague: it seems to work properly to me | 15:40 |
| sdague | it just seems like a lot of work to not use with test.nested() which is nearly the same syntax | 15:40 |
| superdan | sdague: the only things it catches in that file are the actual issues | 15:40 |
| *** baoli_ has joined #openstack-nova | 15:41 | |
| superdan | sdague: well, two people spent a couple hours out of their day to try to come up with a hacking check like you asked, so it's clearly not a trivial thing, right? | 15:42 |
| *** mubirru has quit IRC | 15:42 | |
| lpetrut | superdan: Hi, could you please take a look over this one-liner patch ? https://review.openstack.org/#/c/285370/ The fact that the LiveMigrationData object is not registered broke Hyper-V live migration, which does not have a driver specific implementation of it | 15:42 |
| *** tbachman has joined #openstack-nova | 15:43 | |
| superdan | lpetrut: yeah, I don't want to register it, I want you to just create an object of your own and register it, even if it doesn't have anything else in it | 15:43 |
| *** belmoreira has quit IRC | 15:43 | |
| lpetrut | fair enough, I was wondering what's the reason it is not registered | 15:43 |
| *** baoli has quit IRC | 15:44 | |
| superdan | lpetrut: because it's just a base class | 15:44 |
| superdan | I mean, we could, I'd just prefer we be symmetric | 15:44 |
| sdague | superdan: I didn't actually ask for a hacking rule, I asked the question about why we were using that pattern which I found error prone. It seems more straight forward to just use test.nested(). I think we disagree about that being more ugly. So I'll just leave it as agree to disagree. | 15:44 |
| sdague | andrearosa: that patch looks good | 15:45 |
| sdague | I'm +2 | 15:45 |
| andrearosa | sdague: saw your comment, thanks | 15:45 |
| superdan | sdague: you specifically said I should look at a hacking rule, implying that you'd leave it alone if I did, so ... I was trying to be constructive | 15:45 |
| superdan | sdague: but happy to just disagree if you are | 15:45 |
| superdan | I don't really think the hacking check is unuseful though, because it's catching all real issues AFAICT | 15:46 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: API: Exposes host capabilities via the nova hypervisor API https://review.openstack.org/285378 | 15:46 |
| superdan | only two of the things you raised, but several other crufty ones | 15:47 |
| *** tyagiprince has quit IRC | 15:48 | |
| sdague | well, I feel like it's a bad pattern. But I'm just going to stay out of it at this point, because I seem to be in the minority on that opinion. | 15:48 |
| *** mriedem has quit IRC | 15:49 | |
| *** paul-carlton1 has quit IRC | 15:49 | |
| *** mdrabe has quit IRC | 15:49 | |
| *** achanda has quit IRC | 15:51 | |
| superdan | sdague: okay | 15:51 |
| *** josecastroleon has quit IRC | 15:51 | |
| cdent | sicklypipes: sorry, I had to disagree with you on an api thing | 15:53 |
| *** mriedem has joined #openstack-nova | 15:53 | |
| *** mtanino has joined #openstack-nova | 15:54 | |
| *** mriedem is now known as mriedem_meeting | 15:54 | |
| sicklypipes | cdent: ok | 15:55 |
| *** penick has joined #openstack-nova | 15:55 | |
| *** busterswt has joined #openstack-nova | 15:55 | |
| *** lyanchih has quit IRC | 15:58 | |
| *** mnestratov has quit IRC | 15:58 | |
| *** salv-orl_ has joined #openstack-nova | 15:59 | |
| *** yamahata has joined #openstack-nova | 16:00 | |
| *** haomaiwang has quit IRC | 16:01 | |
| *** haomaiwang has joined #openstack-nova | 16:01 | |
| *** salv-orlando has quit IRC | 16:01 | |
| *** browne has joined #openstack-nova | 16:02 | |
| *** paul-carlton1 has joined #openstack-nova | 16:03 | |
| *** hemnafk is now known as hemna | 16:04 | |
| *** davideagle_ has quit IRC | 16:06 | |
| *** haplo37 has joined #openstack-nova | 16:06 | |
| *** mdrabe has joined #openstack-nova | 16:06 | |
| *** daemontool has quit IRC | 16:07 | |
| *** baoli_ has quit IRC | 16:08 | |
| *** mriedem_meeting has quit IRC | 16:08 | |
| superdan | figleaf: did you see my comments in the backlog? | 16:09 |
| figleaf | superdan: about compute_node_update? Yup | 16:12 |
| superdan | okay | 16:12 |
| *** logan- has quit IRC | 16:14 | |
| *** zenoway has quit IRC | 16:14 | |
| *** logan- has joined #openstack-nova | 16:14 | |
| openstackgerrit | Gleb Stepanov proposed openstack/nova: Console log copy for block live migratiob https://review.openstack.org/284674 | 16:14 |
| *** mriedem has joined #openstack-nova | 16:14 | |
| *** zenoway has joined #openstack-nova | 16:14 | |
| *** mriedem has quit IRC | 16:18 | |
| *** mriedem has joined #openstack-nova | 16:18 | |
| openstackgerrit | Gleb Stepanov proposed openstack/nova: Fix wrong watermark state during live migration https://review.openstack.org/279616 | 16:18 |
| *** zenoway has quit IRC | 16:19 | |
| *** dims has quit IRC | 16:22 | |
| *** armax has quit IRC | 16:22 | |
| *** jdurgin1 has joined #openstack-nova | 16:24 | |
| openstackgerrit | Mark Doffman proposed openstack/nova: Cleanup rescue images on unrescue when using RBD. https://review.openstack.org/241777 | 16:24 |
| *** armax has joined #openstack-nova | 16:25 | |
| *** paul-carlton1 has quit IRC | 16:25 | |
| andrearosa | is Andrey Kurilin around? | 16:25 |
| *** scheuran has quit IRC | 16:25 | |
| andrearosa | andreykurilin: ping | 16:25 |
| mriedem | BobBall: is the xen project and server ci fixed now? | 16:27 |
| *** rk4n has quit IRC | 16:29 | |
| *** rcernin has quit IRC | 16:31 | |
| openstackgerrit | Scott DAngelo proposed openstack/nova: api_version_request.matches does not accept a string or None https://review.openstack.org/285409 | 16:31 |
| BobBall | mriedem: yes - and voting. All -1 votes should be re-run in the next few hours. | 16:32 |
| mriedem | BobBall: https://review.openstack.org/#/admin/groups/511,members | 16:32 |
| mriedem | xenproject ci isn't in there, i can add it | 16:32 |
| mriedem | what's the email again? | 16:32 |
| BobBall | mriedem: oh! I thought it was voting! | 16:33 |
| BobBall | openstack-ci@xenproject.org | 16:33 |
| *** thorst is now known as thorst_afk | 16:33 | |
| mriedem | i got it | 16:33 |
| mriedem | claudiub: is the hyper-v ci busted? | 16:34 |
| *** armax has quit IRC | 16:34 | |
| *** BobBall is now known as BobBall_AWOL | 16:37 | |
| *** penick_ has joined #openstack-nova | 16:37 | |
| *** ihrachys has quit IRC | 16:39 | |
| *** daemontool has joined #openstack-nova | 16:40 | |
| *** penick has quit IRC | 16:40 | |
| *** penick_ is now known as penick | 16:40 | |
| claudiub | mriedem: haven't checked it fully, but I heard that the live migration is currently broken due to recent changes. this should fix that issue: https://review.openstack.org/#/c/285370/ | 16:41 |
| mriedem | claudiub: hmm, hyper-v doesn't support live migration though i thought | 16:42 |
| mriedem | superdan: ^ i'm assuming you're -1 on that change | 16:42 |
| claudiub | hyper-v supported live-migration since windows server 2012. | 16:42 |
| openstackgerrit | Dan Smith proposed openstack/nova: WIP: Migrate compute node stats to Inventory objects https://review.openstack.org/279313 | 16:43 |
| openstackgerrit | Dan Smith proposed openstack/nova: Use new inventory schema in all compute_node gets https://review.openstack.org/284833 | 16:43 |
| superdan | mriedem: I already told him I was yeah | 16:43 |
| mriedem | so looking at https://github.com/openstack/nova/blob/master/nova/virt/hyperv/livemigrationops.py | 16:44 |
| superdan | figleaf: sorry I rebased your patch | 16:44 |
| mriedem | nothing gets stuffed into migrate_data or pulled from it | 16:44 |
| claudiub | indeed, we didn't need anything. | 16:44 |
| mriedem | but hyper-v should probably have it's own migrate data subclass object, that is just bare i guess | 16:44 |
| superdan | sicklypipes: there is the inventory migration patch.. it still fails a RT test which is really ugly to fix because of all the indirection now, but working on it now. wanted it up for people to look at | 16:45 |
| superdan | mriedem: yep | 16:45 |
| openstackgerrit | Gleb Stepanov proposed openstack/nova: Style improvements https://review.openstack.org/283557 | 16:45 |
| *** mgoddard__ has joined #openstack-nova | 16:45 | |
| mriedem | claudiub: marked the bug as high severity and mitaka-rc-potential | 16:46 |
| mriedem | should be an easy fix though | 16:46 |
| openstackgerrit | Mark Doffman proposed openstack/nova: Add manage command for cell0. https://review.openstack.org/275266 | 16:48 |
| openstackgerrit | Mark Doffman proposed openstack/nova: Map instances to cell0 on failed schedule https://review.openstack.org/267827 | 16:48 |
| openstackgerrit | Mark Doffman proposed openstack/nova: Manage db sync command for cell0 https://review.openstack.org/274885 | 16:48 |
| *** mgoddard_ has quit IRC | 16:49 | |
| *** rdopiera has quit IRC | 16:50 | |
| *** Bjoern_ is now known as BjoernT | 16:50 | |
| *** davideagle_ has joined #openstack-nova | 16:51 | |
| openstackgerrit | Gleb Stepanov proposed openstack/nova: pep8 improvements for BaseCoreFilter. https://review.openstack.org/285427 | 16:51 |
| *** Marga_ has quit IRC | 16:51 | |
| claudiub | mriedem: thanks. as for other hyper-v ci related issues, seems that there were some build errors due to some networking issues. my coleague on the hyper-v ci team says that it's fixed. | 16:52 |
| *** Marga_ has joined #openstack-nova | 16:52 | |
| openstackgerrit | Chris Dent proposed openstack/nova: WIP Add ResourcePool object https://review.openstack.org/284963 | 16:53 |
| openstackgerrit | Mark Doffman proposed openstack/nova: Add BuildRequest object https://review.openstack.org/278124 | 16:55 |
| *** davideagle_ has quit IRC | 16:55 | |
| *** angdraug has joined #openstack-nova | 16:56 | |
| *** Marga_ has quit IRC | 16:57 | |
| *** Marga_ has joined #openstack-nova | 16:57 | |
| *** harlowja_at_home has joined #openstack-nova | 16:58 | |
| *** claudiub|2 has joined #openstack-nova | 17:00 | |
| *** haomaiwang has quit IRC | 17:01 | |
| *** apoorvad has joined #openstack-nova | 17:01 | |
| *** haomaiwang has joined #openstack-nova | 17:01 | |
| *** Marga_ has quit IRC | 17:02 | |
| *** claudiub has quit IRC | 17:02 | |
| figleaf | superdan: no worries | 17:06 |
| superdan | it's working good though, thanks for doing that | 17:06 |
| *** vilobhmm11 has joined #openstack-nova | 17:07 | |
| *** jlanoux has quit IRC | 17:09 | |
| *** dims has joined #openstack-nova | 17:09 | |
| *** browne has quit IRC | 17:09 | |
| *** achanda has joined #openstack-nova | 17:10 | |
| *** dims has quit IRC | 17:10 | |
| *** BobBall_1WOL has joined #openstack-nova | 17:10 | |
| *** kylek3h_ has joined #openstack-nova | 17:11 | |
| *** melwitt_ has joined #openstack-nova | 17:12 | |
| *** diana_clarke1 has joined #openstack-nova | 17:12 | |
| *** taneee has joined #openstack-nova | 17:12 | |
| *** rhagarty__ has joined #openstack-nova | 17:12 | |
| *** xek__ has joined #openstack-nova | 17:13 | |
| *** mingyu_ has joined #openstack-nova | 17:13 | |
| *** Kennan2 has joined #openstack-nova | 17:13 | |
| *** baoli has joined #openstack-nova | 17:13 | |
| *** ljxiash_ has joined #openstack-nova | 17:13 | |
| *** yamahata__ has joined #openstack-nova | 17:14 | |
| *** dstepanenko_ has joined #openstack-nova | 17:14 | |
| *** rk4n has joined #openstack-nova | 17:14 | |
| *** tbachman_ has joined #openstack-nova | 17:15 | |
| *** xwizard has joined #openstack-nova | 17:15 | |
| *** j_king_ has joined #openstack-nova | 17:15 | |
| *** gzhai1 has joined #openstack-nova | 17:15 | |
| *** mikal_ has joined #openstack-nova | 17:15 | |
| *** diegows_ has joined #openstack-nova | 17:16 | |
| *** gibi_ has joined #openstack-nova | 17:16 | |
| *** tonyb_ has joined #openstack-nova | 17:16 | |
| *** huats__ has joined #openstack-nova | 17:16 | |
| *** spring_ has joined #openstack-nova | 17:16 | |
| *** kfox1111_ has joined #openstack-nova | 17:16 | |
| *** Yingxin_ has joined #openstack-nova | 17:16 | |
| *** sshen_ has joined #openstack-nova | 17:16 | |
| *** jeblair_ has joined #openstack-nova | 17:17 | |
| *** ansiwen_ has joined #openstack-nova | 17:17 | |
| mriedem | is sean diggity dague out today? | 17:17 |
| *** ptm has joined #openstack-nova | 17:17 | |
| johnthetubaguy | he was around earlier on | 17:17 |
| *** Nakato_ has joined #openstack-nova | 17:17 | |
| *** paul-carlton1 has joined #openstack-nova | 17:17 | |
| *** rodrigod` has joined #openstack-nova | 17:18 | |
| *** coreycb` has joined #openstack-nova | 17:18 | |
| *** matrohon has quit IRC | 17:19 | |
| *** tbachman has quit IRC | 17:20 | |
| *** mingyu has quit IRC | 17:20 | |
| *** ljxiash has quit IRC | 17:20 | |
| *** edmondsw has quit IRC | 17:20 | |
| *** yassine__ has quit IRC | 17:20 | |
| *** hamzy has quit IRC | 17:20 | |
| *** Kennan has quit IRC | 17:20 | |
| *** diana_clarke has quit IRC | 17:20 | |
| *** xek_ has quit IRC | 17:20 | |
| *** huats has quit IRC | 17:20 | |
| *** rodrigods has quit IRC | 17:20 | |
| *** zul has quit IRC | 17:20 | |
| *** rhagarty_ has quit IRC | 17:20 | |
| *** dstepanenko has quit IRC | 17:20 | |
| *** ekarlso- has quit IRC | 17:20 | |
| *** kylek3h has quit IRC | 17:20 | |
| *** BobBall_AWOL has quit IRC | 17:20 | |
| *** Nakato has quit IRC | 17:20 | |
| *** anteaya has quit IRC | 17:20 | |
| *** krotscheck has quit IRC | 17:20 | |
| *** isq_ has quit IRC | 17:20 | |
| *** davechen_afk has quit IRC | 17:20 | |
| *** _fortis has quit IRC | 17:20 | |
| *** masayukig has quit IRC | 17:20 | |
| *** j_king has quit IRC | 17:20 | |
| *** lucasagomes has quit IRC | 17:20 | |
| *** tonyb has quit IRC | 17:20 | |
| *** sshen has quit IRC | 17:20 | |
| *** mikal has quit IRC | 17:20 | |
| *** mkoderer__ has quit IRC | 17:20 | |
| *** morgabra has quit IRC | 17:20 | |
| *** gzhai has quit IRC | 17:20 | |
| *** xwizard___ has quit IRC | 17:20 | |
| *** strictlyb has quit IRC | 17:20 | |
| *** auggy has quit IRC | 17:20 | |
| *** bswartz has quit IRC | 17:20 | |
| *** coreycb has quit IRC | 17:20 | |
| *** afazekas has quit IRC | 17:20 | |
| *** tanee has quit IRC | 17:20 | |
| *** jeblair has quit IRC | 17:20 | |
| *** ansiwen has quit IRC | 17:20 | |
| *** ptm_away has quit IRC | 17:20 | |
| *** bapalm has quit IRC | 17:20 | |
| *** gibi has quit IRC | 17:20 | |
| *** diegows has quit IRC | 17:20 | |
| *** Yingxin has quit IRC | 17:20 | |
| *** melwitt has quit IRC | 17:20 | |
| *** snikitin has quit IRC | 17:20 | |
| *** kfox1111 has quit IRC | 17:20 | |
| *** tbachman_ is now known as tbachman | 17:20 | |
| *** Yingxin_ is now known as Yingxin | 17:20 | |
| *** krotscheck has joined #openstack-nova | 17:20 | |
| *** su_zhang has quit IRC | 17:20 | |
| *** afazekas has joined #openstack-nova | 17:21 | |
| *** bapalm has joined #openstack-nova | 17:21 | |
| *** strictlyb has joined #openstack-nova | 17:21 | |
| *** su_zhang has joined #openstack-nova | 17:21 | |
| *** mkoderer___ has joined #openstack-nova | 17:21 | |
| *** dims has joined #openstack-nova | 17:22 | |
| *** morgabra has joined #openstack-nova | 17:22 | |
| *** lucasagomes has joined #openstack-nova | 17:22 | |
| *** lucasagomes_ has joined #openstack-nova | 17:22 | |
| *** lucasagomes has quit IRC | 17:22 | |
| *** _fortis_ has joined #openstack-nova | 17:23 | |
| *** lucasagomes_ is now known as lucasagomes | 17:23 | |
| *** baoli has quit IRC | 17:24 | |
| *** baoli has joined #openstack-nova | 17:24 | |
| *** su_zhang has quit IRC | 17:25 | |
| *** rlrossit has quit IRC | 17:26 | |
| *** snikitin has joined #openstack-nova | 17:26 | |
| *** masayukig has joined #openstack-nova | 17:26 | |
| *** yassine__ has joined #openstack-nova | 17:27 | |
| *** ekarlso- has joined #openstack-nova | 17:27 | |
| *** zul has joined #openstack-nova | 17:27 | |
| *** edmondsw has joined #openstack-nova | 17:27 | |
| *** auggy has joined #openstack-nova | 17:27 | |
| *** hamzy has joined #openstack-nova | 17:28 | |
| *** anteaya has joined #openstack-nova | 17:28 | |
| PaulMurray | johnthetubaguy, do you have time to look at the abort live migration patch https://review.openstack.org/#/c/277971 | 17:29 |
| PaulMurray | johnthetubaguy, sdague has +2 - its currently waiting in the check queue (has been for some time) | 17:29 |
| johnthetubaguy | damm it, I was half way through that, and got pulled away | 17:29 |
| johnthetubaguy | going back to it | 17:29 |
| PaulMurray | johnthetubaguy, thanks | 17:29 |
| *** wasmum has joined #openstack-nova | 17:30 | |
| *** rk4n has quit IRC | 17:30 | |
| *** baoli has quit IRC | 17:32 | |
| *** lpetrut has quit IRC | 17:32 | |
| *** BjoernT has quit IRC | 17:34 | |
| *** _fortis_ is now known as _fortis | 17:35 | |
| *** kylek3h has joined #openstack-nova | 17:36 | |
| *** lpetrut has joined #openstack-nova | 17:37 | |
| *** vilobhmm11 has quit IRC | 17:38 | |
| *** kylek3h_ has quit IRC | 17:38 | |
| mriedem | easy fix that neutron needs https://review.openstack.org/#/c/283847/ | 17:39 |
| mriedem | sicklypipes: superdan: johnthetubaguy: ^ | 17:39 |
| mriedem | danpb: ^ | 17:40 |
| mriedem | since it's libvirt vif stuff | 17:40 |
| *** jdurgin1 has quit IRC | 17:41 | |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: live-mig: Add claims and proper resource tracking https://review.openstack.org/244489 | 17:42 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: functional: Grab the service version from the module https://review.openstack.org/285459 | 17:42 |
| auggy | clenimar: hi! | 17:42 |
| ndipanov | superdan, easy +2 this way https://review.openstack.org/#/c/285459/ | 17:43 |
| openstackgerrit | Chris Dent proposed openstack/nova: Add Allocation and AllocationList objects https://review.openstack.org/282442 | 17:45 |
| mriedem | ndipanov: +2 | 17:46 |
| ndipanov | mriedem, gracias | 17:46 |
| mriedem | sean did something like that recently with microveresions in the functional tests | 17:46 |
| andrearosa | gmail.com | 17:47 |
| andrearosa | wrong window :) | 17:47 |
| *** eil397 has joined #openstack-nova | 17:48 | |
| *** jistr has quit IRC | 17:49 | |
| *** eil397 has left #openstack-nova | 17:50 | |
| *** davideagle_ has joined #openstack-nova | 17:50 | |
| *** nic has joined #openstack-nova | 17:52 | |
| *** su_zhang has joined #openstack-nova | 17:53 | |
| *** Guest28827 has quit IRC | 17:54 | |
| *** jschlueter has joined #openstack-nova | 17:55 | |
| *** browne has joined #openstack-nova | 17:56 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Add service binary/host to service is down log for context https://review.openstack.org/284980 | 17:58 |
| *** vilobhmm11 has joined #openstack-nova | 17:59 | |
| *** derekh has quit IRC | 18:00 | |
| *** haomaiwang has quit IRC | 18:01 | |
| *** haomaiwang has joined #openstack-nova | 18:01 | |
| *** vilobhmm11 has quit IRC | 18:02 | |
| *** ndipanov has quit IRC | 18:02 | |
| clenimar | auggy: o/ | 18:03 |
| clenimar | auggy: just to ask about bug #1494116 | 18:03 |
| openstack | bug 1494116 in python-novaclient "SessionClient doesn't have last_request_id" [High,In progress] https://launchpad.net/bugs/1494116 - Assigned to Augustina Ragwitz (auggy) | 18:03 |
| clenimar | auggy: is there a patch being worked on? | 18:04 |
| *** danpb has quit IRC | 18:04 | |
| *** rodrigod` is now known as rodrigods | 18:04 | |
| clenimar | auggy: i couldn't find it :( | 18:04 |
| auggy | clenimar: I haven't pushed anything, just been working on it locally, sorry about that | 18:05 |
| *** su_zhang has quit IRC | 18:06 | |
| openstackgerrit | Petrut Lucian proposed openstack/nova: objects: add HyperVLiveMigrateData stub https://review.openstack.org/285370 | 18:07 |
| clenimar | auggy: no problem | 18:08 |
| clenimar | auggy: thanks :) | 18:08 |
| openstackgerrit | Andrea Rosa proposed openstack/python-novaclient: Add nova client server-migration-list and server-migration-show https://review.openstack.org/281335 | 18:09 |
| *** dims is now known as dimsum__ | 18:09 | |
| *** Marga_ has joined #openstack-nova | 18:10 | |
| auggy | clenimar: I'll push my stuff and update the bug today, sorry for the confusion | 18:10 |
| *** lpetrut has quit IRC | 18:10 | |
| *** RichardRaseley has joined #openstack-nova | 18:11 | |
| *** ijw has joined #openstack-nova | 18:11 | |
| *** Marga__ has joined #openstack-nova | 18:11 | |
| *** Marga__ has quit IRC | 18:12 | |
| *** rtheis has quit IRC | 18:12 | |
| *** Marga_ has quit IRC | 18:12 | |
| clenimar | auggy: thanks | 18:13 |
| *** Marga_ has joined #openstack-nova | 18:13 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Mark 'network_device_mtu' as deprecated https://review.openstack.org/284818 | 18:13 |
| cfriesen | is there a way to confirm that my proposed commit is queued up in the check pipeline? | 18:13 |
| *** Marga_ has quit IRC | 18:13 | |
| *** ijw has quit IRC | 18:14 | |
| mriedem | cfriesen: status.openstack.org/zuul | 18:14 |
| mriedem | put the change number in the text area and click the checkbox to expand | 18:14 |
| *** ijw has joined #openstack-nova | 18:14 | |
| *** Marga_ has joined #openstack-nova | 18:14 | |
| mriedem | change number being the thing in the url | 18:14 |
| mriedem | e.g. 284818 | 18:14 |
| *** paul-carlton1 has quit IRC | 18:15 | |
| *** su_zhang has joined #openstack-nova | 18:16 | |
| cfriesen | mriedem: tried that, no luck. I'm looking at change 283861, requested recheck this morning. The VMware NSX CI check has reported in, but everything else is from yesterday. | 18:16 |
| *** clenimar has quit IRC | 18:16 | |
| mriedem | cfriesen: huh, idk, i just rechecked it | 18:17 |
| *** mgoddard__ has quit IRC | 18:17 | |
| *** mgoddard has joined #openstack-nova | 18:17 | |
| mriedem | maybe jenkins just hates your chagne | 18:17 |
| mriedem | *change | 18:17 |
| *** dimtruck is now known as zz_dimtruck | 18:17 | |
| cfriesen | mriedem: wouldn't surprise me | 18:18 |
| mriedem | i'm out for the afternoon, good day all | 18:18 |
| *** mriedem has quit IRC | 18:18 | |
| openstackgerrit | Andrea Rosa proposed openstack/python-novaclient: Support for abort an ongoing live migration https://review.openstack.org/284296 | 18:21 |
| kashyap | superdan: Sorry to pest, when you get a moment, would appreciate if you can write your thoughts - https://review.openstack.org/#/c/168916/ | 18:22 |
| *** thorst_afk is now known as thorst_ | 18:23 | |
| andrearosa | johnthetubaguy: FYI: I've rebased and put new python-novaclient patches for the server-migration-list/show and abort-live-migration. | 18:23 |
| *** vilobhmm11 has joined #openstack-nova | 18:23 | |
| kashyap | s/pest/pester/ (If I wanted to use the word 'pest', maybe I could reword it as "Sorry for being a pest" :-)) | 18:23 |
| *** vilobhmm11 has quit IRC | 18:23 | |
| *** vilobhmm11 has joined #openstack-nova | 18:23 | |
| andrearosa | any novaclient core-reviewer is very welcome to have a look at this: https://review.openstack.org/#/c/281335/4 | 18:23 |
| superdan | kashyap: I was going to comment earlier but that patch isn't really doing what I was thinking earlier | 18:23 |
| superdan | kashyap: in fact that patch covers a verrrrry tiny window of failure, since that call doesn't block until the migration is done | 18:24 |
| superdan | but yeah, I'll comment in a bit | 18:24 |
| kashyap | superdan: Sure, I realize it takes time to go through it, hence just "priming your cache" | 18:24 |
| kashyap | Thanks, take your sweet time! | 18:24 |
| kashyap | I'm about to wind up for the night | 18:24 |
| *** rk4n has joined #openstack-nova | 18:27 | |
| *** su_zhang has quit IRC | 18:28 | |
| *** su_zhang has joined #openstack-nova | 18:29 | |
| *** bjornar__ has joined #openstack-nova | 18:30 | |
| *** abitha has joined #openstack-nova | 18:33 | |
| *** ducttape_ has quit IRC | 18:34 | |
| *** pushkaru has joined #openstack-nova | 18:34 | |
| *** armax has joined #openstack-nova | 18:35 | |
| *** vilobhmm11 has quit IRC | 18:37 | |
| *** zenoway has joined #openstack-nova | 18:39 | |
| *** knikolla has quit IRC | 18:40 | |
| *** knikolla has joined #openstack-nova | 18:40 | |
| *** vilobhmm11 has joined #openstack-nova | 18:41 | |
| openstackgerrit | Andrea Rosa proposed openstack/python-novaclient: Add nova client server-migration-list and server-migration-show https://review.openstack.org/281335 | 18:42 |
| openstackgerrit | Andrea Rosa proposed openstack/python-novaclient: Support for abort an ongoing live migration https://review.openstack.org/284296 | 18:43 |
| *** zenoway has quit IRC | 18:44 | |
| *** abitha has quit IRC | 18:44 | |
| *** haomaiwang has quit IRC | 18:46 | |
| *** haomaiwang has joined #openstack-nova | 18:48 | |
| *** rodrigods has quit IRC | 18:49 | |
| *** rodrigods has joined #openstack-nova | 18:50 | |
| *** achanda has quit IRC | 18:51 | |
| *** jichen has joined #openstack-nova | 18:53 | |
| *** lpetrut has joined #openstack-nova | 18:54 | |
| openstackgerrit | Andrea Rosa proposed openstack/python-novaclient: Add nova client server-migration-list and server-migration-show https://review.openstack.org/281335 | 18:54 |
| *** achanda has joined #openstack-nova | 18:55 | |
| *** agireud has quit IRC | 18:55 | |
| *** bswartz has joined #openstack-nova | 18:55 | |
| openstackgerrit | Andrea Rosa proposed openstack/python-novaclient: Support for abort an ongoing live migration https://review.openstack.org/284296 | 18:55 |
| *** agireud has joined #openstack-nova | 18:57 | |
| *** vilobhmm11 has quit IRC | 19:00 | |
| *** rk4n has quit IRC | 19:00 | |
| *** haomaiwang has quit IRC | 19:01 | |
| *** READ10 has quit IRC | 19:01 | |
| *** 92AAAEL3R has joined #openstack-nova | 19:01 | |
| *** vilobhmm11 has joined #openstack-nova | 19:01 | |
| *** su_zhang has quit IRC | 19:03 | |
| *** su_zhang has joined #openstack-nova | 19:04 | |
| *** RichardRaseley has quit IRC | 19:05 | |
| *** delattec has joined #openstack-nova | 19:06 | |
| *** sdague has quit IRC | 19:06 | |
| *** delatte has quit IRC | 19:08 | |
| *** su_zhang has quit IRC | 19:08 | |
| *** delatte has joined #openstack-nova | 19:09 | |
| *** inc0 has quit IRC | 19:10 | |
| *** jwcroppe has joined #openstack-nova | 19:11 | |
| *** su_zhang has joined #openstack-nova | 19:11 | |
| *** delattec has quit IRC | 19:11 | |
| *** jed56 has quit IRC | 19:13 | |
| *** ZZelle_ has joined #openstack-nova | 19:13 | |
| *** melwitt_ is now known as melwitt | 19:14 | |
| *** su_zhang has quit IRC | 19:15 | |
| *** wasmum has quit IRC | 19:15 | |
| *** baoli has joined #openstack-nova | 19:15 | |
| *** su_zhang has joined #openstack-nova | 19:15 | |
| cdent | sicklypipes: you present? quick question about the inventory model | 19:16 |
| *** dimsum__ has quit IRC | 19:16 | |
| * PaulMurray says good night | 19:16 | |
| *** jschlueter has quit IRC | 19:17 | |
| *** PaulMurray has quit IRC | 19:17 | |
| *** chhavi has quit IRC | 19:17 | |
| cdent | sicklypipes: I'm pretty sure we're missing a constraint here: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/migrate_repo/versions/314_add_resource_provider_tables.py#L42-L59 we need a unique constraint on resource_provider_id, resource_class_id | 19:18 |
| *** inc0 has joined #openstack-nova | 19:18 | |
| *** gzhai2 has joined #openstack-nova | 19:20 | |
| cdent | I can add it to the migration here to avoid yet more migrations: https://review.openstack.org/#/c/281837/ | 19:20 |
| *** zenoway has joined #openstack-nova | 19:21 | |
| cdent | superdan: you around to say something on all that ^ ? | 19:22 |
| *** inc0 has quit IRC | 19:22 | |
| *** baoli has quit IRC | 19:22 | |
| *** baoli has joined #openstack-nova | 19:23 | |
| *** gzhai1 has quit IRC | 19:23 | |
| superdan | hmm | 19:23 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: RT: aborting claims clears instance host and NUMA info https://review.openstack.org/281483 | 19:23 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: objects: Allow instance to reset the NUMA topology https://review.openstack.org/281482 | 19:23 |
| superdan | cdent: what if a compute node has two pools of disk? | 19:23 |
| *** ducttape_ has joined #openstack-nova | 19:23 | |
| *** ndipanov has joined #openstack-nova | 19:24 | |
| cdent | superdan: from commentary on the resource pool spec it seems that's not the desired case, but perhaps for compute nodes it is different: see the comments from jay and roman here: https://review.openstack.org/#/c/253187/12 | 19:24 |
| superdan | hmm | 19:25 |
| *** wasmum has joined #openstack-nova | 19:25 | |
| superdan | I think the goal would be long-term to allow that to happen | 19:25 |
| *** inc0 has joined #openstack-nova | 19:25 | |
| ndipanov | superdan, one more easy one here https://review.openstack.org/#/c/281482/ | 19:25 |
| superdan | an external thing could just maintain two uuids | 19:25 |
| cdent | superdan, I'll leave a note where I am now, and move on. The stuff I'm doing will work either way | 19:26 |
| superdan | cdent: fewer migrations would be good if we need it | 19:26 |
| openstackgerrit | Eric Brown proposed openstack/nova: scheduler: do not update HostState if compute_node has no valid data https://review.openstack.org/261145 | 19:27 |
| superdan | I guess without a uniqueness we wouldn't know which pool of disk we're allocated against, eh? | 19:27 |
| *** baoli has quit IRC | 19:28 | |
| *** baoli has joined #openstack-nova | 19:28 | |
| *** inc0 has quit IRC | 19:28 | |
| cdent | superdan: pretty much | 19:30 |
| *** inc0 has joined #openstack-nova | 19:30 | |
| *** Bjoern_ has joined #openstack-nova | 19:31 | |
| superdan | ndipanov: your easy patch quota is exhausted for the week.. try again monday | 19:31 |
| *** Jeffrey4l__ has joined #openstack-nova | 19:32 | |
| *** inc0 has quit IRC | 19:33 | |
| *** baoli has quit IRC | 19:33 | |
| *** Jeffrey4l_ has quit IRC | 19:35 | |
| *** porunov has joined #openstack-nova | 19:38 | |
| *** aginwala has joined #openstack-nova | 19:44 | |
| *** vilobhmm11 has quit IRC | 19:47 | |
| *** vilobhmm111 has joined #openstack-nova | 19:48 | |
| *** erhudy has joined #openstack-nova | 19:48 | |
| *** shawnmaten has joined #openstack-nova | 19:49 | |
| *** jwcroppe has quit IRC | 19:54 | |
| *** rk4n has joined #openstack-nova | 19:58 | |
| *** baoli has joined #openstack-nova | 19:58 | |
| *** zz_dimtruck is now known as dimtruck | 19:59 | |
| *** 92AAAEL3R has quit IRC | 20:01 | |
| *** haomaiwang has joined #openstack-nova | 20:01 | |
| *** eharney has quit IRC | 20:02 | |
| *** aginwala has quit IRC | 20:02 | |
| *** baoli has quit IRC | 20:03 | |
| *** baoli has joined #openstack-nova | 20:05 | |
| *** aginwala has joined #openstack-nova | 20:06 | |
| *** nelsnelson has quit IRC | 20:06 | |
| *** baoli has quit IRC | 20:11 | |
| *** sdague has joined #openstack-nova | 20:13 | |
| *** eharney has joined #openstack-nova | 20:17 | |
| *** baoli has joined #openstack-nova | 20:18 | |
| openstackgerrit | Sven Anderson proposed openstack/nova: Don't use memcached for caching metadata for now https://review.openstack.org/285530 | 20:19 |
| *** alejandrito has joined #openstack-nova | 20:20 | |
| *** shawnmaten has quit IRC | 20:22 | |
| *** yarkot_ has joined #openstack-nova | 20:22 | |
| *** yarkot_ has quit IRC | 20:26 | |
| *** shawnmaten has joined #openstack-nova | 20:26 | |
| *** su_zhang has quit IRC | 20:27 | |
| *** su_zhang has joined #openstack-nova | 20:28 | |
| *** baoli has quit IRC | 20:28 | |
| *** kfarr has joined #openstack-nova | 20:28 | |
| *** whenry has joined #openstack-nova | 20:29 | |
| *** angdraug has quit IRC | 20:30 | |
| *** rk4n has quit IRC | 20:31 | |
| *** baoli has joined #openstack-nova | 20:31 | |
| *** shawnmaten has quit IRC | 20:32 | |
| *** su_zhang has quit IRC | 20:32 | |
| *** eharney_ has joined #openstack-nova | 20:32 | |
| *** pushkaru has quit IRC | 20:33 | |
| *** eharney has quit IRC | 20:33 | |
| *** eharney_ is now known as eharney | 20:33 | |
| openstackgerrit | Chris Dent proposed openstack/nova: WIP Add ResourcePool object https://review.openstack.org/284963 | 20:33 |
| *** cdent has quit IRC | 20:34 | |
| *** omnipresent has joined #openstack-nova | 20:34 | |
| *** baoli has quit IRC | 20:37 | |
| *** zenoway has quit IRC | 20:37 | |
| *** shawnmaten has joined #openstack-nova | 20:39 | |
| *** aginwala has quit IRC | 20:42 | |
| *** omnipresent has quit IRC | 20:42 | |
| *** zenoway has joined #openstack-nova | 20:43 | |
| *** achanda has quit IRC | 20:45 | |
| kfox1111_ | I've got a hypervisor that was reinstalled that had vm's on it. | 20:48 |
| kfox1111_ | force-delete isn't working on them. | 20:48 |
| kfox1111_ | whats the best way to clear them out? | 20:48 |
| *** dims has joined #openstack-nova | 20:48 | |
| *** claudiub has joined #openstack-nova | 20:53 | |
| *** annasort has quit IRC | 20:54 | |
| *** aginwala has joined #openstack-nova | 20:54 | |
| *** dave-mccowan has quit IRC | 20:56 | |
| *** claudiub|2 has quit IRC | 20:57 | |
| *** fesp has joined #openstack-nova | 20:58 | |
| *** haomaiwang has quit IRC | 21:01 | |
| *** haomaiwang has joined #openstack-nova | 21:01 | |
| *** davideagle_ has quit IRC | 21:03 | |
| *** su_zhang has joined #openstack-nova | 21:05 | |
| *** smatzek has quit IRC | 21:06 | |
| *** kfarr has quit IRC | 21:10 | |
| *** yarkot_ has joined #openstack-nova | 21:13 | |
| *** delattec has joined #openstack-nova | 21:15 | |
| *** alejandrito has quit IRC | 21:16 | |
| *** delatte has quit IRC | 21:17 | |
| *** nelsnelson has joined #openstack-nova | 21:20 | |
| *** delattec has quit IRC | 21:20 | |
| *** baoli has joined #openstack-nova | 21:21 | |
| *** delattec has joined #openstack-nova | 21:22 | |
| *** davideagle has joined #openstack-nova | 21:22 | |
| *** claudiub|2 has joined #openstack-nova | 21:25 | |
| *** rk4n has joined #openstack-nova | 21:27 | |
| *** claudiub has quit IRC | 21:28 | |
| *** baoli has quit IRC | 21:29 | |
| *** claudiub has joined #openstack-nova | 21:29 | |
| *** yarkot_ has quit IRC | 21:29 | |
| *** claudiub|2 has quit IRC | 21:31 | |
| openstackgerrit | Chris Friesen proposed openstack/nova: check max_net_count against min_count when booting https://review.openstack.org/283861 | 21:31 |
| *** apoorvad has quit IRC | 21:35 | |
| *** aginwala has quit IRC | 21:36 | |
| *** fesp has quit IRC | 21:37 | |
| *** ctrath has quit IRC | 21:38 | |
| *** fesp has joined #openstack-nova | 21:38 | |
| *** nikhil has quit IRC | 21:39 | |
| openstackgerrit | Sven Anderson proposed openstack/nova: Don't use memcached for caching metadata for now https://review.openstack.org/285530 | 21:40 |
| *** agireud has quit IRC | 21:41 | |
| *** jamielennox is now known as jamielennox|away | 21:43 | |
| *** agireud has joined #openstack-nova | 21:43 | |
| *** porunov has quit IRC | 21:45 | |
| *** browne has quit IRC | 21:46 | |
| *** shawnmaten has quit IRC | 21:47 | |
| openstackgerrit | melanie witt proposed openstack/nova: Use db connection from RequestContext during queries https://review.openstack.org/272329 | 21:47 |
| *** pushkaru has joined #openstack-nova | 21:48 | |
| kfox1111_ | any ideas on the force-delete? | 21:48 |
| *** browne has joined #openstack-nova | 21:49 | |
| melwitt | kfox1111_: what's the result when you try to delete them? do you get an error? | 21:51 |
| *** apoorvad has joined #openstack-nova | 21:52 | |
| kfox1111_ | the compute node wasn't fully up it seems. after restarting nova-compute, I could delete it. | 21:53 |
| *** scottda is now known as scottda_is_outta | 21:56 | |
| openstackgerrit | Sven Anderson proposed openstack/nova: Avoid parallel DB queries of identical metadata https://review.openstack.org/285562 | 21:56 |
| *** nikhil has joined #openstack-nova | 21:57 | |
| *** baoli has joined #openstack-nova | 21:57 | |
| *** baoli has quit IRC | 21:59 | |
| *** salv-orlando has joined #openstack-nova | 21:59 | |
| *** haomaiwang has quit IRC | 22:01 | |
| *** eharney has quit IRC | 22:01 | |
| *** rk4n has quit IRC | 22:01 | |
| *** haomaiwang has joined #openstack-nova | 22:01 | |
| *** salv-orl_ has quit IRC | 22:02 | |
| *** jschlueter has joined #openstack-nova | 22:02 | |
| *** ccarmack has quit IRC | 22:02 | |
| *** boden has joined #openstack-nova | 22:05 | |
| *** aginwala has joined #openstack-nova | 22:07 | |
| *** sheel has quit IRC | 22:07 | |
| *** toure_ is now known as toure | 22:09 | |
| *** toure is now known as toure_ | 22:09 | |
| *** baoli has joined #openstack-nova | 22:11 | |
| *** knikolla has quit IRC | 22:11 | |
| *** tbachman has quit IRC | 22:14 | |
| *** Marga_ has quit IRC | 22:16 | |
| *** Marga_ has joined #openstack-nova | 22:16 | |
| *** davideagle has quit IRC | 22:17 | |
| *** browne has quit IRC | 22:17 | |
| *** smatzek has joined #openstack-nova | 22:20 | |
| *** smatzek has quit IRC | 22:21 | |
| *** davideagle_ has joined #openstack-nova | 22:23 | |
| *** browne has joined #openstack-nova | 22:24 | |
| *** thorst_ has quit IRC | 22:26 | |
| *** whenry has quit IRC | 22:29 | |
| *** baoli has quit IRC | 22:31 | |
| *** su_zhang has quit IRC | 22:32 | |
| *** su_zhang has joined #openstack-nova | 22:32 | |
| *** davideagle_ has quit IRC | 22:32 | |
| *** baoli has joined #openstack-nova | 22:33 | |
| *** edtubill has quit IRC | 22:33 | |
| *** yamahata has quit IRC | 22:37 | |
| *** baoli has quit IRC | 22:39 | |
| *** su_zhang has quit IRC | 22:39 | |
| *** su_zhang has joined #openstack-nova | 22:39 | |
| *** burgerk has quit IRC | 22:41 | |
| *** thorst has joined #openstack-nova | 22:42 | |
| *** dimtruck is now known as zz_dimtruck | 22:43 | |
| *** ndipanov has quit IRC | 22:44 | |
| *** baoli has joined #openstack-nova | 22:45 | |
| openstackgerrit | melanie witt proposed openstack/nova: Add a cell and host mapping utility to nova-manage https://review.openstack.org/270565 | 22:46 |
| *** aginwala has quit IRC | 22:46 | |
| *** thorst has quit IRC | 22:46 | |
| *** marcusvrn_ has quit IRC | 22:47 | |
| *** Marga_ has quit IRC | 22:48 | |
| *** aginwala has joined #openstack-nova | 22:49 | |
| *** Marga_ has joined #openstack-nova | 22:49 | |
| *** baoli has quit IRC | 22:52 | |
| *** zz_dimtruck is now known as dimtruck | 22:52 | |
| *** boden has quit IRC | 22:53 | |
| *** Marga_ has quit IRC | 22:53 | |
| *** abitha has joined #openstack-nova | 22:55 | |
| *** burt has quit IRC | 22:56 | |
| *** baoli has joined #openstack-nova | 22:58 | |
| *** rk4n has joined #openstack-nova | 22:58 | |
| *** fesp has quit IRC | 22:59 | |
| *** haomaiwang has quit IRC | 23:01 | |
| *** mdrabe has quit IRC | 23:01 | |
| *** haomaiwa_ has joined #openstack-nova | 23:01 | |
| *** baoli has quit IRC | 23:02 | |
| *** aginwala has quit IRC | 23:06 | |
| *** NightKhaos has quit IRC | 23:06 | |
| *** dims has quit IRC | 23:07 | |
| *** yassine__ has quit IRC | 23:07 | |
| *** wanghao has quit IRC | 23:08 | |
| *** wanghao has joined #openstack-nova | 23:09 | |
| *** ducttape_ has quit IRC | 23:10 | |
| *** daemontool_ has joined #openstack-nova | 23:10 | |
| *** xyang1 has quit IRC | 23:11 | |
| *** dimtruck is now known as zz_dimtruck | 23:12 | |
| *** Bjoern_ has quit IRC | 23:12 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: Clean up networks with SR-IOV binding on reschedule https://review.openstack.org/283198 | 23:13 |
| *** yamahata has joined #openstack-nova | 23:13 | |
| *** aginwala has joined #openstack-nova | 23:13 | |
| *** daemontool has quit IRC | 23:13 | |
| *** Marga_ has joined #openstack-nova | 23:15 | |
| *** rk4n has quit IRC | 23:15 | |
| *** jichen has quit IRC | 23:15 | |
| *** rk4n has joined #openstack-nova | 23:16 | |
| *** ccard_ has joined #openstack-nova | 23:16 | |
| *** baoli has joined #openstack-nova | 23:19 | |
| *** ccard__ has quit IRC | 23:19 | |
| *** Marga_ has quit IRC | 23:19 | |
| *** pushkaru has quit IRC | 23:21 | |
| *** armax has quit IRC | 23:23 | |
| *** haplo37 has quit IRC | 23:24 | |
| *** armax has joined #openstack-nova | 23:25 | |
| *** tbachman has joined #openstack-nova | 23:27 | |
| openstackgerrit | Eric Brown proposed openstack/nova: scheduler: do not update HostState if compute_node has no valid data https://review.openstack.org/261145 | 23:29 |
| *** angdraug has joined #openstack-nova | 23:29 | |
| *** lpetrut has quit IRC | 23:31 | |
| *** dims has joined #openstack-nova | 23:34 | |
| *** rk4n has quit IRC | 23:34 | |
| *** erlon has quit IRC | 23:36 | |
| *** tbachman has quit IRC | 23:37 | |
| *** tbachman has joined #openstack-nova | 23:38 | |
| *** edmondsw has quit IRC | 23:39 | |
| *** haplo37 has joined #openstack-nova | 23:40 | |
| *** erhudy has quit IRC | 23:40 | |
| *** rk4n has joined #openstack-nova | 23:45 | |
| *** rk4n has quit IRC | 23:47 | |
| *** tbachman has quit IRC | 23:51 | |
| *** aginwala has quit IRC | 23:52 | |
| *** zz_dimtruck is now known as dimtruck | 23:53 | |
| *** Marga_ has joined #openstack-nova | 23:55 | |
| *** aginwala has joined #openstack-nova | 23:55 | |
| *** aorourke is now known as aorourke-afk | 23:55 | |
| *** ccarmack has joined #openstack-nova | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!