| *** ndipanov has quit IRC | 00:00 | |
| *** mriedem has joined #openstack-nova | 00:01 | |
| *** haomaiwa_ has quit IRC | 00:01 | |
| *** haomaiwang has joined #openstack-nova | 00:01 | |
| *** vilobhmm11 has quit IRC | 00:02 | |
| *** Swami has quit IRC | 00:03 | |
| *** vilobhmm11 has joined #openstack-nova | 00:03 | |
| *** vilobhmm11 has quit IRC | 00:05 | |
| *** takedakn has joined #openstack-nova | 00:06 | |
| *** vilobhmm11 has joined #openstack-nova | 00:07 | |
| *** dims has joined #openstack-nova | 00:08 | |
| *** mylu has quit IRC | 00:08 | |
| *** mylu has joined #openstack-nova | 00:10 | |
| *** ianw has quit IRC | 00:10 | |
| *** Jeffrey4l has joined #openstack-nova | 00:12 | |
| *** armax has joined #openstack-nova | 00:14 | |
| *** armax has quit IRC | 00:14 | |
| *** mrkz has quit IRC | 00:16 | |
| *** efried has quit IRC | 00:16 | |
| *** mrkz has joined #openstack-nova | 00:16 | |
| *** yuntongjin has joined #openstack-nova | 00:17 | |
| *** efried has joined #openstack-nova | 00:18 | |
| *** sdague has joined #openstack-nova | 00:22 | |
| *** openstack has joined #openstack-nova | 00:24 | |
| *** nic has quit IRC | 00:25 | |
| *** sdague has quit IRC | 00:26 | |
| *** baoli has joined #openstack-nova | 00:27 | |
| *** mylu has quit IRC | 00:27 | |
| *** mylu has joined #openstack-nova | 00:27 | |
| *** mtanino has quit IRC | 00:28 | |
| *** ssurana1 has quit IRC | 00:28 | |
| *** takedakn has quit IRC | 00:29 | |
| *** fawadkhaliq has quit IRC | 00:30 | |
| *** yuntongjin1 has joined #openstack-nova | 00:32 | |
| *** fawadkhaliq has joined #openstack-nova | 00:33 | |
| *** yuntongjin has quit IRC | 00:34 | |
| *** mylu has quit IRC | 00:35 | |
| *** erlon has quit IRC | 00:37 | |
| *** eharney has quit IRC | 00:37 | |
| *** mylu has joined #openstack-nova | 00:39 | |
| *** yuntongjin has joined #openstack-nova | 00:40 | |
| *** mylu has quit IRC | 00:40 | |
| *** yuntongjin1 has quit IRC | 00:42 | |
| *** baoli has quit IRC | 00:42 | |
| *** yuntongjin1 has joined #openstack-nova | 00:43 | |
| *** angdraug has quit IRC | 00:43 | |
| *** yuntongjin has quit IRC | 00:45 | |
| *** mylu has joined #openstack-nova | 00:45 | |
| *** dims has joined #openstack-nova | 00:45 | |
| *** mylu has quit IRC | 00:46 | |
| openstackgerrit | Mark Doffman proposed openstack/nova-specs: Add new probabilistic placement algorithm. https://review.openstack.org/293139 | 00:47 |
|---|---|---|
| *** mylu has joined #openstack-nova | 00:48 | |
| *** zz_dimtruck is now known as dimtruck | 00:49 | |
| *** mylu has quit IRC | 00:50 | |
| *** oomichi has quit IRC | 00:50 | |
| *** oomichi has joined #openstack-nova | 00:51 | |
| *** hoangcx has joined #openstack-nova | 00:52 | |
| *** phuongnh has joined #openstack-nova | 00:52 | |
| *** afazekas has quit IRC | 00:53 | |
| *** Jeffrey4l has quit IRC | 00:53 | |
| *** oomichi has quit IRC | 00:55 | |
| *** dave-mccowan has joined #openstack-nova | 00:57 | |
| *** Kennan has quit IRC | 00:58 | |
| *** fawadkhaliq has quit IRC | 00:58 | |
| *** afazekas has joined #openstack-nova | 00:59 | |
| *** oomichi has joined #openstack-nova | 01:00 | |
| *** haomaiwang has quit IRC | 01:01 | |
| *** haomaiwang has joined #openstack-nova | 01:01 | |
| *** fawadkhaliq has joined #openstack-nova | 01:02 | |
| *** fawadkhaliq has quit IRC | 01:02 | |
| *** ZZelle has quit IRC | 01:03 | |
| *** david-lyle has joined #openstack-nova | 01:04 | |
| *** fawadkhaliq has joined #openstack-nova | 01:06 | |
| *** fawadkhaliq has quit IRC | 01:06 | |
| *** dims has quit IRC | 01:07 | |
| *** Kennan has joined #openstack-nova | 01:10 | |
| *** dims has joined #openstack-nova | 01:12 | |
| *** mylu has joined #openstack-nova | 01:14 | |
| *** mylu has quit IRC | 01:15 | |
| *** fawadkhaliq has joined #openstack-nova | 01:18 | |
| *** fawadkhaliq has quit IRC | 01:19 | |
| *** EinstCrazy has joined #openstack-nova | 01:21 | |
| *** haomaiwang has quit IRC | 01:23 | |
| *** ccarmack has joined #openstack-nova | 01:23 | |
| *** tiendc has joined #openstack-nova | 01:23 | |
| *** boris-42 has quit IRC | 01:24 | |
| *** ljxiash has joined #openstack-nova | 01:25 | |
| *** oomichi has quit IRC | 01:25 | |
| *** afazekas has quit IRC | 01:25 | |
| *** ccarmack has quit IRC | 01:27 | |
| *** oomichi has joined #openstack-nova | 01:28 | |
| *** afazekas has joined #openstack-nova | 01:28 | |
| *** dims has quit IRC | 01:29 | |
| *** dims has joined #openstack-nova | 01:29 | |
| *** fawadkhaliq has joined #openstack-nova | 01:30 | |
| *** Daisy has joined #openstack-nova | 01:31 | |
| *** fawadkhaliq has quit IRC | 01:31 | |
| *** MVenesio has joined #openstack-nova | 01:32 | |
| *** akshai has quit IRC | 01:33 | |
| openstackgerrit | Bin Zhou proposed openstack/nova: upgrade connection_info when Ceph mon IP changed https://review.openstack.org/289813 | 01:34 |
| *** ljxiash has quit IRC | 01:35 | |
| *** ljxiash has joined #openstack-nova | 01:36 | |
| *** MVenesio has quit IRC | 01:36 | |
| *** vilobhmm11 has quit IRC | 01:36 | |
| *** mrkz has quit IRC | 01:36 | |
| *** Daisy has quit IRC | 01:37 | |
| *** vishwanathj has joined #openstack-nova | 01:37 | |
| *** Daisy has joined #openstack-nova | 01:37 | |
| *** ljxiash has quit IRC | 01:40 | |
| *** fawadkhaliq has joined #openstack-nova | 01:42 | |
| *** Daisy has quit IRC | 01:42 | |
| *** mylu has joined #openstack-nova | 01:42 | |
| *** mriedem has quit IRC | 01:42 | |
| *** mylu has quit IRC | 01:44 | |
| *** kaisers1 has joined #openstack-nova | 01:44 | |
| *** kaisers has quit IRC | 01:45 | |
| *** ljjjustin has joined #openstack-nova | 01:50 | |
| *** fawadkhaliq has quit IRC | 01:51 | |
| *** fawadkhaliq has joined #openstack-nova | 01:51 | |
| *** dims has quit IRC | 01:52 | |
| *** yamahata has joined #openstack-nova | 01:53 | |
| *** mgoddard has quit IRC | 01:54 | |
| *** baoli has joined #openstack-nova | 01:55 | |
| *** dims has joined #openstack-nova | 01:56 | |
| openstackgerrit | Feng Xi Yan proposed openstack/nova: <VMWare> Allocate free bus for new SCSI controller https://review.openstack.org/272414 | 01:56 |
| *** haomaiwang has joined #openstack-nova | 02:00 | |
| *** haomaiwang has quit IRC | 02:01 | |
| *** haomaiwa_ has joined #openstack-nova | 02:01 | |
| *** dims has quit IRC | 02:03 | |
| *** apoorvad has quit IRC | 02:03 | |
| *** dims has joined #openstack-nova | 02:05 | |
| *** akshai has joined #openstack-nova | 02:05 | |
| *** fawadkhaliq has quit IRC | 02:06 | |
| *** woodster_ has quit IRC | 02:07 | |
| *** akshai_ has joined #openstack-nova | 02:07 | |
| *** mylu has joined #openstack-nova | 02:08 | |
| *** mylu has quit IRC | 02:09 | |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Lowercase aggregate metadata keys due to case insensitivity https://review.openstack.org/283868 | 02:09 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Lowercase aggregate metadata keys due to case insensitivity https://review.openstack.org/283868 | 02:10 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: add regression test for bug #1538011 https://review.openstack.org/283364 | 02:10 |
| openstack | bug 1538011 in OpenStack Compute (nova) "Metadata keys are not case sensitive" [High,In progress] https://launchpad.net/bugs/1538011 - Assigned to Augustina Ragwitz (auggy) | 02:10 |
| *** akshai has quit IRC | 02:10 | |
| *** baoli_ has joined #openstack-nova | 02:11 | |
| *** ljxiash has joined #openstack-nova | 02:12 | |
| *** baoli has quit IRC | 02:14 | |
| *** liusheng has quit IRC | 02:16 | |
| *** liusheng has joined #openstack-nova | 02:16 | |
| *** vilobhmm11 has joined #openstack-nova | 02:18 | |
| *** thorst_ has quit IRC | 02:18 | |
| *** mylu has joined #openstack-nova | 02:20 | |
| *** vilobhmm111 has joined #openstack-nova | 02:20 | |
| *** yamahata has quit IRC | 02:21 | |
| *** mylu has quit IRC | 02:21 | |
| *** vilobhmm11 has quit IRC | 02:22 | |
| *** baoli_ has quit IRC | 02:23 | |
| *** baoli has joined #openstack-nova | 02:23 | |
| *** mylu has joined #openstack-nova | 02:25 | |
| *** fawadkhaliq has joined #openstack-nova | 02:25 | |
| *** mylu has quit IRC | 02:27 | |
| *** mylu has joined #openstack-nova | 02:27 | |
| *** Daisy has joined #openstack-nova | 02:28 | |
| *** mylu has quit IRC | 02:29 | |
| *** Daisy_ has joined #openstack-nova | 02:29 | |
| *** baoli has quit IRC | 02:29 | |
| *** yamahata has joined #openstack-nova | 02:29 | |
| *** Daisy__ has joined #openstack-nova | 02:31 | |
| *** fawadkhaliq has quit IRC | 02:32 | |
| *** Daisy has quit IRC | 02:33 | |
| *** Daisy has joined #openstack-nova | 02:33 | |
| *** ducttape_ has joined #openstack-nova | 02:33 | |
| *** mylu has joined #openstack-nova | 02:34 | |
| *** Daisy_ has quit IRC | 02:34 | |
| *** baoli has joined #openstack-nova | 02:35 | |
| *** mylu has quit IRC | 02:35 | |
| *** mylu has joined #openstack-nova | 02:35 | |
| *** houming has joined #openstack-nova | 02:36 | |
| *** Daisy__ has quit IRC | 02:37 | |
| *** unicell has quit IRC | 02:37 | |
| *** Daisy has quit IRC | 02:37 | |
| *** Daisy has joined #openstack-nova | 02:39 | |
| *** yamahata has quit IRC | 02:39 | |
| *** mylu has quit IRC | 02:40 | |
| *** READ10 has quit IRC | 02:47 | |
| *** mylu has joined #openstack-nova | 02:49 | |
| *** tbachman_ has joined #openstack-nova | 02:49 | |
| *** tbachman has quit IRC | 02:51 | |
| *** tbachman_ is now known as tbachman | 02:51 | |
| *** gcb has quit IRC | 02:51 | |
| *** Jeffrey4l has joined #openstack-nova | 02:57 | |
| *** krtaylor has quit IRC | 02:58 | |
| *** haukebruno has joined #openstack-nova | 02:58 | |
| *** mylu has quit IRC | 02:59 | |
| *** haomaiwa_ has quit IRC | 03:01 | |
| *** haomaiwang has joined #openstack-nova | 03:01 | |
| *** tbachman_ has joined #openstack-nova | 03:03 | |
| *** mylu has joined #openstack-nova | 03:03 | |
| *** gcb has joined #openstack-nova | 03:04 | |
| *** ctrath has joined #openstack-nova | 03:04 | |
| *** tbachman has quit IRC | 03:04 | |
| *** tbachman_ is now known as tbachman | 03:04 | |
| *** ssurana has joined #openstack-nova | 03:06 | |
| *** krtaylor has joined #openstack-nova | 03:10 | |
| *** gcb has quit IRC | 03:11 | |
| *** mylu has quit IRC | 03:13 | |
| *** ducttape_ has quit IRC | 03:14 | |
| *** houming has quit IRC | 03:14 | |
| *** houming_ has joined #openstack-nova | 03:14 | |
| *** mylu has joined #openstack-nova | 03:16 | |
| *** dave-mccowan has quit IRC | 03:17 | |
| *** mylu has quit IRC | 03:18 | |
| *** thorst has joined #openstack-nova | 03:19 | |
| *** Daisy has quit IRC | 03:19 | |
| *** ctrath has quit IRC | 03:22 | |
| *** dimtruck is now known as zz_dimtruck | 03:25 | |
| *** ducttape_ has joined #openstack-nova | 03:26 | |
| *** gcb has joined #openstack-nova | 03:26 | |
| *** thorst has quit IRC | 03:27 | |
| *** mylu has joined #openstack-nova | 03:27 | |
| *** yuntongjin1 has quit IRC | 03:28 | |
| *** mylu has quit IRC | 03:29 | |
| *** _ducttape_ has joined #openstack-nova | 03:29 | |
| *** ducttape_ has quit IRC | 03:29 | |
| *** MVenesio has joined #openstack-nova | 03:32 | |
| *** gongysh has joined #openstack-nova | 03:34 | |
| *** dims has quit IRC | 03:37 | |
| *** MVenesio has quit IRC | 03:37 | |
| *** ljxiash has quit IRC | 03:38 | |
| *** baoli has quit IRC | 03:39 | |
| *** sridharg has joined #openstack-nova | 03:41 | |
| *** aswadr has joined #openstack-nova | 03:47 | |
| *** aswadr_ has joined #openstack-nova | 03:47 | |
| *** akshai_ has quit IRC | 03:52 | |
| *** Daisy has joined #openstack-nova | 03:54 | |
| *** haomaiwang has quit IRC | 04:01 | |
| *** haomaiwang has joined #openstack-nova | 04:01 | |
| *** gongysh has quit IRC | 04:04 | |
| *** vishwanathj has quit IRC | 04:05 | |
| *** knikolla has quit IRC | 04:06 | |
| *** josecastroleon1 has joined #openstack-nova | 04:06 | |
| *** josecastroleon has quit IRC | 04:06 | |
| *** whenry has quit IRC | 04:06 | |
| *** links has joined #openstack-nova | 04:10 | |
| *** vilobhmm111 has quit IRC | 04:11 | |
| *** vilobhmm11 has joined #openstack-nova | 04:11 | |
| *** fawadkhaliq has joined #openstack-nova | 04:14 | |
| *** flwang1 has quit IRC | 04:16 | |
| *** Daisy has quit IRC | 04:20 | |
| *** vilobhmm11 has quit IRC | 04:21 | |
| *** _ducttape_ has quit IRC | 04:24 | |
| *** Daisy has joined #openstack-nova | 04:24 | |
| *** thorst has joined #openstack-nova | 04:25 | |
| *** Daisy has quit IRC | 04:29 | |
| *** ducttape_ has joined #openstack-nova | 04:30 | |
| *** thorst has quit IRC | 04:32 | |
| *** akshai has joined #openstack-nova | 04:36 | |
| *** vilobhmm11 has joined #openstack-nova | 04:42 | |
| *** ducttape_ has quit IRC | 04:44 | |
| *** mylu has joined #openstack-nova | 04:44 | |
| *** mylu has quit IRC | 04:45 | |
| *** gcb has quit IRC | 04:46 | |
| openstackgerrit | Feng Xi Yan proposed openstack/nova: <VMWare> Allocate free bus for new SCSI controller https://review.openstack.org/272414 | 04:52 |
| *** haomaiwang has quit IRC | 05:01 | |
| *** haomaiwang has joined #openstack-nova | 05:01 | |
| *** akshai_ has joined #openstack-nova | 05:04 | |
| *** gcb has joined #openstack-nova | 05:05 | |
| *** mylu has joined #openstack-nova | 05:06 | |
| *** akshai has quit IRC | 05:07 | |
| *** yamahata has joined #openstack-nova | 05:07 | |
| *** ssurana has quit IRC | 05:08 | |
| *** ljxiash has joined #openstack-nova | 05:09 | |
| *** ljxiash has quit IRC | 05:10 | |
| *** ljxiash has joined #openstack-nova | 05:10 | |
| *** clduser_ has quit IRC | 05:12 | |
| *** clduser has joined #openstack-nova | 05:12 | |
| *** ssurana has joined #openstack-nova | 05:13 | |
| *** boris-42 has joined #openstack-nova | 05:14 | |
| *** Daisy has joined #openstack-nova | 05:15 | |
| *** _xin1 has quit IRC | 05:22 | |
| *** _xin has joined #openstack-nova | 05:22 | |
| *** ccarmack has joined #openstack-nova | 05:24 | |
| *** _xin has quit IRC | 05:25 | |
| *** alex_xu has quit IRC | 05:25 | |
| openstackgerrit | Abhishek Talwar proposed openstack/python-novaclient: aggregate-details changed to aggregate-show https://review.openstack.org/292277 | 05:26 |
| *** sc68cal has joined #openstack-nova | 05:26 | |
| *** _xin has joined #openstack-nova | 05:28 | |
| *** unicell has joined #openstack-nova | 05:28 | |
| openstackgerrit | Abhishek Talwar proposed openstack/python-novaclient: aggregate-details changed to aggregate-show https://review.openstack.org/292277 | 05:29 |
| *** ccarmack has quit IRC | 05:29 | |
| *** thorst has joined #openstack-nova | 05:30 | |
| *** vishwanathj has joined #openstack-nova | 05:31 | |
| *** alex_xu has joined #openstack-nova | 05:31 | |
| *** vishwanathj has quit IRC | 05:31 | |
| *** Jeffrey4l has quit IRC | 05:32 | |
| *** MVenesio has joined #openstack-nova | 05:33 | |
| *** thorst has quit IRC | 05:37 | |
| *** MVenesio has quit IRC | 05:37 | |
| openstackgerrit | Abhishek Talwar proposed openstack/python-novaclient: flavor-id should be only integer or UUID https://review.openstack.org/287702 | 05:41 |
| *** fawadkhaliq has quit IRC | 05:42 | |
| *** fawadkhaliq has joined #openstack-nova | 05:43 | |
| *** akshai_ has quit IRC | 05:44 | |
| *** david-lyle has quit IRC | 05:45 | |
| *** david-lyle has joined #openstack-nova | 05:45 | |
| *** mylu has quit IRC | 05:46 | |
| *** deepakcs has joined #openstack-nova | 05:48 | |
| *** Daisy has quit IRC | 05:48 | |
| *** Daisy has joined #openstack-nova | 05:48 | |
| *** vishwanathj has joined #openstack-nova | 05:48 | |
| *** vishwanathj has quit IRC | 05:51 | |
| *** mylu has joined #openstack-nova | 05:52 | |
| *** fawadkhaliq has quit IRC | 05:52 | |
| *** fawadkhaliq has joined #openstack-nova | 05:53 | |
| *** moshele has joined #openstack-nova | 05:56 | |
| *** mylu has quit IRC | 05:57 | |
| *** liverpooler has quit IRC | 05:59 | |
| *** haomaiwang has quit IRC | 06:01 | |
| *** flwang1 has joined #openstack-nova | 06:01 | |
| *** haomaiwang has joined #openstack-nova | 06:01 | |
| openstackgerrit | Tomoki Sekiyama proposed openstack/nova: Fix multipath iSCSI encrypted volume attach failure https://review.openstack.org/196482 | 06:01 |
| *** flwang1 has quit IRC | 06:09 | |
| *** Daisy_ has joined #openstack-nova | 06:10 | |
| *** Daisy has quit IRC | 06:13 | |
| *** aswadr has quit IRC | 06:18 | |
| *** gongysh has joined #openstack-nova | 06:19 | |
| *** astupnikov has joined #openstack-nova | 06:20 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata https://review.openstack.org/291556 | 06:23 |
| *** Daisy_ has quit IRC | 06:26 | |
| *** Daisy has joined #openstack-nova | 06:27 | |
| *** ekuris_ has joined #openstack-nova | 06:29 | |
| *** Daisy has quit IRC | 06:31 | |
| *** moshele has quit IRC | 06:32 | |
| *** vishwanathj has joined #openstack-nova | 06:34 | |
| openstackgerrit | Wenzhi Yu proposed openstack/nova-specs: Move calculation of 'disk_available_least' to ResourceTracker https://review.openstack.org/293272 | 06:34 |
| *** vishwanathj is now known as vishwanathj_zzz | 06:35 | |
| *** thorst has joined #openstack-nova | 06:35 | |
| *** sc68cal has quit IRC | 06:36 | |
| *** esracelik has joined #openstack-nova | 06:40 | |
| *** harlowja_at_home has quit IRC | 06:41 | |
| *** thorst has quit IRC | 06:42 | |
| *** ssurana has quit IRC | 06:44 | |
| *** ishant has joined #openstack-nova | 06:50 | |
| *** Daisy has joined #openstack-nova | 06:55 | |
| *** ljjjustin has quit IRC | 06:58 | |
| *** ljjjustin has joined #openstack-nova | 06:58 | |
| *** hoangcx has quit IRC | 06:59 | |
| *** esracelik has quit IRC | 07:00 | |
| *** haomaiwang has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-nova | 07:01 | |
| openstackgerrit | Wenzhi Yu proposed openstack/nova-specs: Move calculation of 'disk_available_least' to ResourceTracker https://review.openstack.org/293272 | 07:02 |
| *** fawadkhaliq has quit IRC | 07:03 | |
| *** ihrachys has joined #openstack-nova | 07:03 | |
| *** hoangcx has joined #openstack-nova | 07:04 | |
| *** fawadkhaliq has joined #openstack-nova | 07:04 | |
| *** ihrachys has quit IRC | 07:06 | |
| *** mjura has joined #openstack-nova | 07:07 | |
| *** zenoway has joined #openstack-nova | 07:10 | |
| *** zenoway has quit IRC | 07:12 | |
| *** zenoway has joined #openstack-nova | 07:12 | |
| *** flwang1 has joined #openstack-nova | 07:13 | |
| *** lpetrut has joined #openstack-nova | 07:15 | |
| *** tesseract has joined #openstack-nova | 07:16 | |
| *** tesseract is now known as Guest64967 | 07:17 | |
| *** nkrinner has joined #openstack-nova | 07:17 | |
| *** jaosorior has joined #openstack-nova | 07:18 | |
| *** Guest64967 has quit IRC | 07:21 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Enhance value check for option notify_on_state_change https://review.openstack.org/242717 | 07:23 |
| *** Marga_ has quit IRC | 07:25 | |
| *** fawadkhaliq has quit IRC | 07:25 | |
| *** fawadkhaliq has joined #openstack-nova | 07:26 | |
| *** fawadkhaliq has quit IRC | 07:26 | |
| *** fawadkhaliq has joined #openstack-nova | 07:27 | |
| *** browne has quit IRC | 07:27 | |
| *** ljxiash has quit IRC | 07:30 | |
| *** flwang1 has quit IRC | 07:30 | |
| *** ljxiash has joined #openstack-nova | 07:31 | |
| *** ljxiash has quit IRC | 07:32 | |
| *** MVenesio has joined #openstack-nova | 07:34 | |
| *** ljxiash has joined #openstack-nova | 07:36 | |
| *** tesseract- has joined #openstack-nova | 07:36 | |
| *** gcb has quit IRC | 07:36 | |
| *** moshele has joined #openstack-nova | 07:36 | |
| *** Marga_ has joined #openstack-nova | 07:38 | |
| *** MVenesio has quit IRC | 07:38 | |
| *** thorst has joined #openstack-nova | 07:40 | |
| *** Marga_ has quit IRC | 07:41 | |
| *** Marga_ has joined #openstack-nova | 07:41 | |
| *** Marga_ has quit IRC | 07:42 | |
| *** Marga_ has joined #openstack-nova | 07:43 | |
| *** mariusv_ has quit IRC | 07:44 | |
| *** mariusv has quit IRC | 07:44 | |
| *** mariusv has joined #openstack-nova | 07:45 | |
| *** lunarlamp has joined #openstack-nova | 07:48 | |
| *** thorst has quit IRC | 07:48 | |
| *** gcb has joined #openstack-nova | 07:49 | |
| *** liverpooler has joined #openstack-nova | 07:49 | |
| *** klkumar has joined #openstack-nova | 07:54 | |
| *** scheuran has joined #openstack-nova | 07:56 | |
| *** jwcroppe has quit IRC | 07:57 | |
| *** belmoreira has joined #openstack-nova | 07:58 | |
| *** jwcroppe has joined #openstack-nova | 07:58 | |
| *** haomaiwang has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-nova | 08:01 | |
| *** yuywz has joined #openstack-nova | 08:02 | |
| *** jwcroppe has quit IRC | 08:02 | |
| *** erno has joined #openstack-nova | 08:03 | |
| *** lpetrut has quit IRC | 08:04 | |
| *** ihrachys has joined #openstack-nova | 08:04 | |
| *** y_sawai has joined #openstack-nova | 08:10 | |
| *** matrohon has joined #openstack-nova | 08:11 | |
| *** liverpooler has quit IRC | 08:14 | |
| *** hoangcx has quit IRC | 08:14 | |
| *** liverpooler has joined #openstack-nova | 08:14 | |
| *** esracelik has joined #openstack-nova | 08:17 | |
| *** jichen has joined #openstack-nova | 08:18 | |
| *** MCoLo has joined #openstack-nova | 08:19 | |
| *** hoangcx has joined #openstack-nova | 08:19 | |
| *** permalac has joined #openstack-nova | 08:20 | |
| *** kbyrne has joined #openstack-nova | 08:22 | |
| *** EinstCrazy has quit IRC | 08:23 | |
| *** cdent has joined #openstack-nova | 08:26 | |
| *** atuvenie has joined #openstack-nova | 08:26 | |
| *** roeyc has joined #openstack-nova | 08:27 | |
| *** EinstCrazy has joined #openstack-nova | 08:30 | |
| openstackgerrit | xhzhf proposed openstack/nova: Support-matrix of vmware for chap is wrong https://review.openstack.org/293309 | 08:31 |
| *** yamahata has quit IRC | 08:33 | |
| *** roeyc has quit IRC | 08:36 | |
| cdent | p!spy | 08:37 |
| *** ig0r_ has quit IRC | 08:39 | |
| *** slaweq_ has joined #openstack-nova | 08:43 | |
| slaweq_ | hello | 08:43 |
| slaweq_ | I'm looking for API calls rate limit in nova | 08:43 |
| slaweq_ | I found that there is such middleware (legacy) in v2 api | 08:43 |
| slaweq_ | but there is no such think in current v2.1 api | 08:43 |
| slaweq_ | can You maybe tell me why (or give me some links where it is explained) | 08:44 |
| slaweq_ | is this middleware deprecated? | 08:44 |
| slaweq_ | or maybe I should use something else in v21 api? | 08:44 |
| *** andymaier has joined #openstack-nova | 08:45 | |
| *** thorst has joined #openstack-nova | 08:46 | |
| doffm | Doesn't rate limiting sit in-front of the API in a proxy now? | 08:48 |
| doffm | I actually don't know. slaweq_ You may be better off asking in #openstack. | 08:48 |
| *** Drankis has joined #openstack-nova | 08:49 | |
| cdent | slaweq_: I think doffm is right. The rate limiting is handled at a layer above the api code, established by the paste config | 08:52 |
| *** thorst has quit IRC | 08:52 | |
| slaweq_ | ok, thx | 08:55 |
| *** paul-carlton2 has joined #openstack-nova | 08:56 | |
| slaweq_ | cdent: but about what paste config You are talking? | 08:57 |
| slaweq_ | for v2 it was configured in api-paste.ini config file | 08:57 |
| slaweq_ | but for v21 it's not there | 08:57 |
| slaweq_ | hmm | 08:58 |
| slaweq_ | and also in docs for liberty: http://docs.openstack.org/liberty/config-reference/content/list-of-compute-config-options.html#config_table_nova_api | 08:58 |
| *** aswadr has joined #openstack-nova | 08:58 | |
| slaweq_ | there is info that "Rate limiting is removed from v2.1 api." | 08:58 |
| cdent | slaweq_: yeah, appears you are right, I was confusing the sizelimit and ratelimit middlewares | 08:58 |
| slaweq_ | but I still don't know why... :/ | 08:58 |
| *** ljxiash has quit IRC | 08:58 | |
| *** vilobhmm11 has quit IRC | 08:59 | |
| cdent | sorry, I don't know the history | 08:59 |
| slaweq_ | cdent: no prob :) | 09:00 |
| cdent | here we go slaweq_: there's discussion of why in this review: https://review.openstack.org/#/c/34821/ | 09:00 |
| *** haomaiwang has quit IRC | 09:01 | |
| *** haomaiwang has joined #openstack-nova | 09:01 | |
| slaweq_ | thx | 09:01 |
| cdent | basic summary: not fit for purpose | 09:01 |
| slaweq_ | I will read it | 09:01 |
| *** dedery has joined #openstack-nova | 09:02 | |
| bauzas | good morning Nova | 09:04 |
| *** ljxiash has joined #openstack-nova | 09:05 | |
| *** ljjjustin has quit IRC | 09:07 | |
| *** jlanoux has joined #openstack-nova | 09:07 | |
| *** paul-carlton2 has quit IRC | 09:08 | |
| *** ljjjustin has joined #openstack-nova | 09:08 | |
| openstackgerrit | Moshe Levi proposed openstack/nova: libvirt: Fix ssh driver to to prevent prompting https://review.openstack.org/293328 | 09:09 |
| *** wanghao has quit IRC | 09:09 | |
| *** wanghao has joined #openstack-nova | 09:09 | |
| johnthetubaguy | slaweq_: yeah, cdent is correct, that rate limiting stuff only works if you have one API node, which makes it mostly pointless, most folks use some generic REST API tool to ratelimit, AFAIK. | 09:10 |
| *** ljxiash has quit IRC | 09:10 | |
| johnthetubaguy | bauzas: hows the reno stuff we want in going? | 09:10 |
| *** salv-orlando has joined #openstack-nova | 09:11 | |
| *** sridharg has quit IRC | 09:11 | |
| *** aswadr has left #openstack-nova | 09:12 | |
| slaweq_ | johnthetubaguy: thx | 09:12 |
| *** mgoddard has joined #openstack-nova | 09:12 | |
| slaweq_ | I think that now I understand it better after reading comments on this review :) | 09:12 |
| doffm | bauzas: Morning. | 09:13 |
| johnthetubaguy | slaweq_: do let us know if there are admin docs that could be clearer, might be worth a doc bug detailing the confusion | 09:14 |
| *** yuywz has quit IRC | 09:16 | |
| bauzas | johnthetubaguy: so we have a reno problem that's not blocking | 09:16 |
| bauzas | johnthetubaguy: basically, reverting changes doesn't remove the reno note | 09:16 |
| bauzas | johnthetubaguy: so I discussed with dhellmann and he has a patch that I need to test | 09:16 |
| bauzas | in the meanwhile, I'm verifying that most of the notes that we did yesterday and accepted are mertged | 09:17 |
| bauzas | johnthetubaguy: I haven't looked at the translations, are you planning a RC2 at least for those ? | 09:17 |
| johnthetubaguy | bauzas: ah, I did wonder about that | 09:17 |
| *** ZZelle has joined #openstack-nova | 09:17 | |
| bauzas | that's my main point before tagging RC1 | 09:18 |
| bauzas | that and the reno files | 09:18 |
| johnthetubaguy | bauzas: we *have* to do RC2 for translations anyways, as RC1 is the hard string freeze | 09:18 |
| johnthetubaguy | bauzas: I should ask that the bot is doing | 09:18 |
| bauzas | okay | 09:18 |
| bauzas | do we have a current zanata change to approve ? | 09:19 |
| bauzas | johnthetubaguy: so, about the notes, all of them are merged but the prelude section | 09:19 |
| bauzas | johnthetubaguy: mriedem was having a concern about https://review.openstack.org/#/c/292785/1/releasenotes/notes/mitaka_prelude-c8b955ed78a5ad65.yaml | 09:20 |
| bauzas | johnthetubaguy: do you remember when we dropped EC2 ? | 09:20 |
| bauzas | johnthetubaguy: my concern is that http://docs.openstack.org/releasenotes/nova/unreleased.html#id5 is confusing because 2 notes are saying different things | 09:21 |
| *** ndipanov has joined #openstack-nova | 09:22 | |
| johnthetubaguy | bauzas: can we put a note in the bullet to ignore the previous note? | 09:23 |
| *** ferhat has joined #openstack-nova | 09:23 | |
| ferhat | hello all | 09:24 |
| bauzas | johnthetubaguy: actually, I'm about to write a last reno change for fixing that, plus a formatting nit I saw | 09:24 |
| *** jistr has joined #openstack-nova | 09:24 | |
| bauzas | johnthetubaguy: so, the thing is, we should probably also merge the prelude section before RC1 | 09:24 |
| bauzas | johnthetubaguy: because if we merge that once the branch is splitted, it would be a newton thing, right? | 09:25 |
| *** Daisy has quit IRC | 09:25 | |
| johnthetubaguy | bauzas: well, we can backport, but I was assuming that would be in RC1, yes | 09:26 |
| *** Daisy has joined #openstack-nova | 09:26 | |
| johnthetubaguy | actually, you can't really backport it, I guess | 09:26 |
| bauzas | johnthetubaguy: we can surely backport, sure, but the main commit will be newton | 09:26 |
| johnthetubaguy | yeah, which is not what we want | 09:26 |
| bauzas | exactly | 09:26 |
| johnthetubaguy | hmm, I am starting to dislike bits of this reno stuff | 09:27 |
| bauzas | okay, give me 10 mins, sorting out the relnotes | 09:27 |
| johnthetubaguy | its close, though, better than just me making up some stuff on the last day of the release | 09:27 |
| bauzas | I agree | 09:28 |
| openstackgerrit | Zhenyu Zheng proposed openstack/python-novaclient: Add changes-since support when list servers https://review.openstack.org/286423 | 09:30 |
| *** Daisy has quit IRC | 09:30 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for driver attach_interfaces capability https://review.openstack.org/272471 | 09:31 |
| *** BobBall has joined #openstack-nova | 09:31 | |
| openstackgerrit | John Garbutt proposed openstack/nova: xenapi: Fix up passing sr_uuid_map https://review.openstack.org/293085 | 09:31 |
| BobBall | Will check out that change in a bit johnthetubaguy - thanks. | 09:32 |
| bauzas | johnthetubaguy: you agree with https://github.com/openstack/nova/blob/master/releasenotes/notes/disable_ec2_api_by_default-0ec0946433fc7119.yaml not being correct now, right? | 09:32 |
| *** dedery_ has joined #openstack-nova | 09:32 | |
| openstackgerrit | John Garbutt proposed openstack/nova: xenapi: Fix up passing sr_uuid_map https://review.openstack.org/293085 | 09:33 |
| openstackgerrit | John Garbutt proposed openstack/nova: xenapi: Fix up issues with live-migrate for xenapi https://review.openstack.org/292937 | 09:33 |
| *** derekh has joined #openstack-nova | 09:34 | |
| *** ljxiash has joined #openstack-nova | 09:35 | |
| *** MVenesio has joined #openstack-nova | 09:35 | |
| *** rk4n has joined #openstack-nova | 09:35 | |
| johnthetubaguy | bauzas: yeah, we removed it now right? | 09:36 |
| *** yassine__ has joined #openstack-nova | 09:36 | |
| bauzas | johnthetubaguy: yup | 09:36 |
| bauzas | AFAIK | 09:36 |
| bauzas | maybe sdague could help us in the next hour | 09:36 |
| *** dedery has quit IRC | 09:37 | |
| johnthetubaguy | bauzas: yeah, it will not work at all this realse | 09:37 |
| johnthetubaguy | release | 09:37 |
| johnthetubaguy | so that means folks need to update their paste.ini, I think | 09:37 |
| johnthetubaguy | although I think we made that limp on, for now, if I remember correctly | 09:37 |
| *** mjura has quit IRC | 09:37 | |
| bauzas | okay, I'm just nearly done with updating the change for fixing the formatting nits + the removal problem we have | 09:37 |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Make config option daemon's help string more accurate https://review.openstack.org/292837 | 09:38 |
| *** lucas-dinner is now known as lucasagomes | 09:38 | |
| *** MVenesio has quit IRC | 09:39 | |
| *** rk4n has quit IRC | 09:39 | |
| *** rk4n has joined #openstack-nova | 09:39 | |
| *** ljxiash has quit IRC | 09:40 | |
| *** sdague has joined #openstack-nova | 09:43 | |
| *** thorst has joined #openstack-nova | 09:50 | |
| *** dims has joined #openstack-nova | 09:51 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add a prelude section for Mitaka relnotes https://review.openstack.org/292785 | 09:53 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Fix reno for RC1 https://review.openstack.org/293345 | 09:53 |
| *** openstackgerrit has quit IRC | 09:53 | |
| *** openstackgerrit_ is now known as openstackgerrit | 09:53 | |
| bauzas | johnthetubaguy: last reno changes I feel ^ | 09:53 |
| *** openstackgerrit has quit IRC | 09:53 | |
| *** openstackgerrit_ has joined #openstack-nova | 09:54 | |
| *** openstackgerrit_ is now known as openstackgerrit | 09:54 | |
| *** openstackgerrit_ has joined #openstack-nova | 09:55 | |
| *** openstackgerrit has quit IRC | 09:55 | |
| *** openstackgerrit has joined #openstack-nova | 09:56 | |
| openstackgerrit | garyk proposed openstack/nova: VMware: make the opaque network attachment more robust https://review.openstack.org/284121 | 09:56 |
| *** thorst has quit IRC | 09:57 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/python-novaclient: Add changes-since support when list servers https://review.openstack.org/286423 | 09:59 |
| *** sdague has quit IRC | 10:00 | |
| *** haomaiwang has quit IRC | 10:01 | |
| *** allen_gao has quit IRC | 10:01 | |
| *** haomaiwang has joined #openstack-nova | 10:01 | |
| *** sdague has joined #openstack-nova | 10:03 | |
| *** sridharg has joined #openstack-nova | 10:03 | |
| johnthetubaguy | bauzas: not sure about the commit message for this change: https://review.openstack.org/#/c/293345/1 seems a bit confusing, maybe just go from three paragraphs that describe each of the changes? | 10:04 |
| johnthetubaguy | bauzas: the reno bits make sense I think | 10:04 |
| bauzas | johnthetubaguy: sure, lemme do that | 10:05 |
| *** sridharg has quit IRC | 10:05 | |
| *** sridharg has joined #openstack-nova | 10:05 | |
| *** mylu has joined #openstack-nova | 10:08 | |
| *** lpetrut has joined #openstack-nova | 10:09 | |
| *** allen_gao has joined #openstack-nova | 10:10 | |
| *** sdague has quit IRC | 10:11 | |
| *** sdague has joined #openstack-nova | 10:12 | |
| *** mylu has quit IRC | 10:13 | |
| markus_z | bauzas: Do you have a minute? I don't understand what's happening with https://review.openstack.org/#/c/291733/ It's not listed in any of the zuul queues. Got it "stuck"? | 10:13 |
| *** hoangcx has quit IRC | 10:13 | |
| bauzas | markus_z: sec, fixing a last minute problem with reno and I'm done | 10:13 |
| BobBall | johnthetubaguy: Holding nodes in our RAX CI is harder than I remembered; full logs uploaded to http://2e3c642e4296924ff05d-66873027c2788bdf1c2707eeb3e7052a.r54.cf5.rackcdn.com/mitaka-lm-bug/compute1/ and http://2e3c642e4296924ff05d-66873027c2788bdf1c2707eeb3e7052a.r54.cf5.rackcdn.com/mitaka-lm-bug/DevStackOSDomU/ | 10:14 |
| johnthetubaguy | BobBall: thats showing a syntax error still, I think | 10:16 |
| johnthetubaguy | BobBall: I don't think thats present in the latest version of the patch series | 10:16 |
| BobBall | What's worse is that the swift upload is broken | 10:16 |
| johnthetubaguy | ah... | 10:17 |
| BobBall | Yes; that was the logs from last night not including the two changes you made this morning. | 10:17 |
| johnthetubaguy | rhr QOULS SO IR | 10:17 |
| johnthetubaguy | markus_z: we had issues yesterday where due to a gerrit restart you need to recheck changes | 10:17 |
| johnthetubaguy | markus_z: unsure if thats related | 10:17 |
| *** ljjjustin has left #openstack-nova | 10:18 | |
| markus_z | johnthetubaguy: ah, could be, the +W from matt was yesterday | 10:18 |
| *** cdelatte has quit IRC | 10:19 | |
| markus_z | johnthetubaguy: So, I just leave a "recheck" as comment and then zuul will pick it up again? | 10:19 |
| markus_z | didn't we have a "reverify" once? | 10:19 |
| sdague | markus_z: I poked it with another +A | 10:19 |
| sdague | recheck doesn't often work in these cases | 10:20 |
| sdague | because you need the state transition bit | 10:20 |
| markus_z | sdague: Ah, good to know, thanks for poking it. | 10:20 |
| sdague | markus_z: there was about a 12 hour window where a bad regex was in the zuul definition that blocked things from running | 10:20 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add a prelude section for Mitaka relnotes https://review.openstack.org/292785 | 10:21 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Fix reno for RC1 https://review.openstack.org/293345 | 10:21 |
| bauzas | johnthetubaguy: sdague^ | 10:21 |
| bauzas | johnthetubaguy: I also added 2 points in the bus change | 10:21 |
| *** PaulMurray has joined #openstack-nova | 10:22 | |
| markus_z | sdague: OK, I see the spike in the zuul job queue in Grafana. I didn't check that before I asked. | 10:22 |
| sdague | markus_z: no worries | 10:22 |
| bauzas | markus_z: I guess your point was fixed by sdague, right? | 10:24 |
| markus_z | bauzas: yep, right | 10:24 |
| johnthetubaguy | BobBall: maybe the bigger question is does the latest patchset fix the issue? | 10:25 |
| *** zenoway has quit IRC | 10:26 | |
| *** claudiub has joined #openstack-nova | 10:27 | |
| BobBall | johnthetubaguy: Indeed; will be checking that just now. | 10:27 |
| sdague | markus_z: I just queried for a bunch of things that were stuck on the nova side and flushed them | 10:27 |
| sdague | let me know if you see others | 10:27 |
| markus_z | sdague: thanks, will do | 10:27 |
| *** daemontool has joined #openstack-nova | 10:28 | |
| sdague | johnthetubaguy: can we not do things like this please - https://review.openstack.org/#/c/292431 | 10:33 |
| sdague | especially as I think there was a different set of patches earlier in the cycle going the other way | 10:33 |
| johnthetubaguy | sdague: sorry, yeah, I thought we went the other way | 10:33 |
| *** EinstCrazy has quit IRC | 10:34 | |
| johnthetubaguy | sdague: I was tempted to -2 with saying we don't have a pep8 thing to check this, so lets not bother with these patches, I guess that was the rule at one point | 10:34 |
| openstackgerrit | Alexis Lee proposed openstack/nova: Wait for device to be mapped https://review.openstack.org/215613 | 10:35 |
| *** dedery has joined #openstack-nova | 10:37 | |
| *** shaohe_feng has joined #openstack-nova | 10:37 | |
| *** dedery_ has quit IRC | 10:40 | |
| *** gcb has quit IRC | 10:40 | |
| *** dedery has quit IRC | 10:41 | |
| *** zenoway has joined #openstack-nova | 10:41 | |
| sdague | regardless of the pep8 rule, I get somewhat annoyed with "this makes things clearer" when it doesn't. | 10:41 |
| *** zenoway has quit IRC | 10:42 | |
| *** zenoway has joined #openstack-nova | 10:42 | |
| *** mkrcmari__ has quit IRC | 10:42 | |
| *** phuongnh has quit IRC | 10:42 | |
| *** shaohe_feng has quit IRC | 10:44 | |
| *** shaohe_feng has joined #openstack-nova | 10:44 | |
| *** shaohe_feng_robo has joined #openstack-nova | 10:45 | |
| *** ferhat has quit IRC | 10:46 | |
| openstackgerrit | Abhishek Talwar proposed openstack/python-novaclient: flavor-id should be only integer or UUID https://review.openstack.org/287702 | 10:47 |
| *** ljxiash has joined #openstack-nova | 10:51 | |
| *** Wenzhi has joined #openstack-nova | 10:52 | |
| *** gcb has joined #openstack-nova | 10:52 | |
| *** boden has joined #openstack-nova | 10:52 | |
| *** dims has quit IRC | 10:53 | |
| *** shaohe_feng has quit IRC | 10:54 | |
| *** shaohe_feng has joined #openstack-nova | 10:54 | |
| *** thorst has joined #openstack-nova | 10:55 | |
| *** ociuhandu has quit IRC | 10:55 | |
| *** ljxiash has quit IRC | 10:56 | |
| *** salv-orlando has quit IRC | 10:56 | |
| *** tbachman has quit IRC | 10:57 | |
| *** sridharg has quit IRC | 10:58 | |
| *** pece has joined #openstack-nova | 10:59 | |
| *** flwang1 has joined #openstack-nova | 10:59 | |
| *** dims has joined #openstack-nova | 10:59 | |
| bauzas | sdague: in case you could verify that https://review.openstack.org/#/c/293345/2/releasenotes/notes/disable_ec2_api_by_default-0ec0946433fc7119.yaml is right | 10:59 |
| bauzas | sdague: IIUC, we removed the ec2 commands | 11:00 |
| bauzas | sdague: so, now, ec2 is like out of tree | 11:00 |
| *** haomaiwang has quit IRC | 11:01 | |
| sdague | bauzas: hmmm.... wait so the release notes all build up and we don't have a defined line there? | 11:01 |
| *** gongysh has quit IRC | 11:01 | |
| bauzas | sdague: the problem is that removing a reno file doesn't remove it from the relnotes | 11:01 |
| *** haomaiwang has joined #openstack-nova | 11:01 | |
| *** tbachman has joined #openstack-nova | 11:01 | |
| bauzas | sdague: since this yaml was merged, it was confusing with another bullet saying that EC2 API is out-of-tree | 11:02 |
| sdague | ...o_O | 11:02 |
| sdague | is that a thing that's being worked on? | 11:02 |
| sdague | I guess, my assumption in how this would work is that this would exit, but clearly be referenced to an older branch | 11:02 |
| *** thorst has quit IRC | 11:02 | |
| openstackgerrit | Chris Dent proposed openstack/nova: Workaround stall in py34 unit tests https://review.openstack.org/293372 | 11:03 |
| sdague | I guess if that's what we have to do, so be it, but this seems pretty confusing | 11:03 |
| cdent | sdague: that ^^ patch is related to the py34 slowdown we were discussing the other day | 11:03 |
| bauzas | sdague: not sure I understand you, sorry | 11:04 |
| cdent | I traced it back to an eventlet lockup. There's a fix in that patch, but it is dirty. | 11:04 |
| *** shaohe_feng has quit IRC | 11:04 | |
| bauzas | sdague: for Mitaka, we have 2 conflicting bullets about EC2 | 11:04 |
| bauzas | sdague: http://docs.openstack.org/releasenotes/nova/unreleased.html#id5 | 11:05 |
| *** shaohe_feng has joined #openstack-nova | 11:05 | |
| sdague | bauzas: right, I get that our published release notes are wrong | 11:05 |
| bauzas | "As of Kilo the in tree EC2 API is marked as deprecated. The in tree EC2 API is now disabled by default. You have to add ec2 to the enabled_apis configuration parameter if you stil want to use it." vs. " All code and tests for Nova’s EC2 and ObjectStore API support which was deprecated in Kilo (https://wiki.openstack.org/wiki/ReleaseNotes/Kilo#Upgrade_Notes_2) has been completely removed in Mitaka. This has been replaced by th | 11:05 |
| sdague | and i get this is the way to hack around reno to make them right | 11:05 |
| sdague | but it seems like we shouldn't have to do that | 11:05 |
| sdague | long term | 11:05 |
| bauzas | sdague: yeah, so I discussed that with dhellmann | 11:06 |
| sdague | you should never have to delete a release note artifact | 11:06 |
| bauzas | sdague: and he provided me https://review.openstack.org/#/c/293078/1 to verify | 11:06 |
| *** Jeffrey4l has joined #openstack-nova | 11:06 | |
| sdague | so, sure, I still don't think we should have to delete it either | 11:06 |
| bauzas | sdague: but I'd like to make sure that our relnotes are happy for mitaka and not waiting for reno to be updated | 11:06 |
| sdague | bauzas: sure | 11:07 |
| sdague | but that fix isn't really the fix either, right? | 11:07 |
| bauzas | it's a workaround | 11:07 |
| sdague | I seems completely wrong to have to go back through and delete release notes | 11:07 |
| sdague | the release notes should have some understanding of what release they apply to | 11:07 |
| bauzas | sdague: have you seen my commit msg ? | 11:08 |
| bauzas | sdague: I agree with you, the relnotes are provided for the milestones | 11:08 |
| sdague | bauzas: I think we are talking past each other | 11:09 |
| bauzas | sdague: I'm really sorry, it's probably me that not understanding your point :( | 11:09 |
| bauzas | I'm just testing locally the reno change dhellmann wrote for making sure that reverts are not leaving the notes there | 11:10 |
| sdague | ok, lets take a new example - https://github.com/openstack/nova/blob/298a821a3290ccba6992008d81410ba022b7ca50/releasenotes/notes/deprecate_db_driver-91c76ca8011d663c.yaml#L1 | 11:10 |
| sdague | in Newton what are we going to do with that | 11:10 |
| bauzas | sdague: that YAML file won't be rendered in the newton output | 11:11 |
| moshele | ndipanov: hi | 11:11 |
| sdague | bauzas: what is the mechanism for that? | 11:11 |
| bauzas | sdague: it's scanning git commits for the release | 11:11 |
| *** mkrcmari__ has joined #openstack-nova | 11:11 | |
| bauzas | sdague: tbc, it's scanning git commits for the master branch that haven't been released | 11:12 |
| bauzas | sdague: unless you specifically ask the reno scanner to only look at a specific branch | 11:12 |
| sdague | oh, because it's doing deep git inspection | 11:12 |
| bauzas | eg. https://raw.githubusercontent.com/openstack/nova/master/releasenotes/source/liberty.rst | 11:12 |
| bauzas | yeah | 11:12 |
| sdague | though, if we fix a typo in stable then we have to be divergent forever? | 11:12 |
| bauzas | the case didn't happen yet, but that's a good question | 11:13 |
| bauzas | say that liberty relnotes are bad | 11:13 |
| sdague | it seems like it's going to be a lot easier to understand going forward if this stops doing magical git things, and instead uses subdirs | 11:13 |
| BobBall | johnthetubaguy: Still no :/ http://2e3c642e4296924ff05d-66873027c2788bdf1c2707eeb3e7052a.r54.cf5.rackcdn.com/mitaka-lm-bug/compute1/ and http://2e3c642e4296924ff05d-66873027c2788bdf1c2707eeb3e7052a.r54.cf5.rackcdn.com/mitaka-lm-bug/devstackosdomu/ - still getting the Cannot load 'sr_uuid_map' in the base class | 11:13 |
| bauzas | then, for fixing that, we'd have to provide a specific commit against the stable branch, not something merged in master | 11:13 |
| bauzas | sdague: that's indeed a good point | 11:14 |
| sdague | because 3 releases in, figuring out why certain release notes are rendering and not with git magic is going to get insance | 11:14 |
| sdague | insane | 11:14 |
| *** haukebruno has quit IRC | 11:14 | |
| bauzas | yeah I agree | 11:14 |
| bauzas | actually, reno supports that already | 11:14 |
| bauzas | I mean, subdirs | 11:14 |
| sdague | oh, can we move to that model instead of a branch model? | 11:14 |
| johnthetubaguy | BobBall: OK, should have some real logs this time, unit tests are slowly getting there, some real issues to fix up in those | 11:14 |
| *** shaohe_feng has quit IRC | 11:14 | |
| johnthetubaguy | sdague: hmm, that does sound a whole deal easier | 11:15 |
| bauzas | sdague: not really, it's just that we can modify the relnotessubdir value in http://docs.openstack.org/developer/reno/sphinxext.html | 11:15 |
| *** klkumar has quit IRC | 11:15 | |
| *** Wenzhi has quit IRC | 11:15 | |
| bauzas | oops, I meant the notesdir | 11:15 |
| *** shaohe_feng has joined #openstack-nova | 11:15 | |
| bauzas | sdague: so that would still scan the full list of git commits, but it would have a list of yaml files per release | 11:16 |
| BobBall | johnthetubaguy: What shall I investigate? (so we don't overlap) | 11:16 |
| bauzas | sdague: I can actually try to do this, lemme check | 11:16 |
| johnthetubaguy | BobBall: is the date wrong on your box? the logs still seem old | 11:17 |
| sdague | bauzas: anyway, I think that this is feedback we should give. I think that the current reno model with 3 or 4 active branches is going to become way too frustrating. And getting off git magic to explicit directories would be way better. | 11:17 |
| bauzas | sdague: the only problem I see is backports of changes including a note | 11:17 |
| sdague | bauzas: problem with what? | 11:18 |
| BobBall | Nope: 2016-03-16 11:03:02.303 TRACE oslo_messaging.rpc.dispatcher NotImplementedError: Cannot load 'sr_uuid_map' in the base class | 11:18 |
| *** openstackgerrit has quit IRC | 11:18 | |
| bauzas | sdague: ie. say that you have a bugfix change that includes a reno file | 11:18 |
| johnthetubaguy | BobBall: I guess maybe output the migrate_data to the log at the start of the live-migrate method, see what it has | 11:18 |
| bauzas | sdague: that bugfix is merged in master | 11:18 |
| johnthetubaguy | BobBall: actually the start of each method, so we can track what is happening | 11:18 |
| *** openstackgerrit has joined #openstack-nova | 11:18 | |
| ndipanov | moshele, hola | 11:18 |
| johnthetubaguy | BobBall: by the way, which live-migrate types are you testing here? | 11:18 |
| sdague | ok, so you have to retarget the reno | 11:18 |
| sdague | to a different directory | 11:18 |
| sdague | yeh, it's not super ideal, but the current magic is a bit weird | 11:19 |
| bauzas | sdague: given that currently, the notes directory is the same for all branches, it's perfectly okay to backport (if wanted) that change to eg. liberty and not needing to modify the reno file path | 11:19 |
| BobBall | johnthetubaguy: Just --block-migrate so far; then will remove that when that works. I presume specifying it is still the easier one. | 11:19 |
| sdague | that being said, we're not supposed to be doing feature backports, so it should be the exception | 11:19 |
| bauzas | sdague: that way, the git scan finds that note for both the unreleased (ie. master) file, and for the stable branch file | 11:19 |
| bauzas | sdague: security fixes | 11:19 |
| bauzas | sdague: not speaking of featurs | 11:20 |
| sdague | yeh, sure | 11:20 |
| johnthetubaguy | BobBall: its the one I am worried about at least, I just don't see why the data is not getting out of pre-live-migrate, and the logs are playing hard to get on me | 11:20 |
| BobBall | johnthetubaguy: I guess TTL on CDN is too high... | 11:20 |
| moshele | ndipanov: did you see my comment in https://review.openstack.org/#/c/242573/ | 11:20 |
| sdague | well, the current stuff seems pretty confusing, because it creates this "can't fix old release notes that aren't clear" | 11:20 |
| bauzas | sdague: but I agree, we should prevent such changes that impact upgrade paths or features | 11:20 |
| sdague | unless you zero them out | 11:20 |
| sdague | like you had to do | 11:21 |
| bauzas | sdague: ideally, I'd have git rm that yaml, but I was hit by https://review.openstack.org/#/c/293078/1 | 11:21 |
| BobBall | johnthetubaguy: RAX CDN only lets us have a minimum 15 minute TTL - so I'll need to upload to new directories each time. | 11:21 |
| bauzas | so I hope this is temporary | 11:21 |
| openstackgerrit | Sergey Belous proposed openstack/nova: do not merge, trying to run tempest with enabled os-vif https://review.openstack.org/286086 | 11:21 |
| sdague | bauzas: ok, except that's confusing | 11:21 |
| moshele | ndipanov: I failed to understand if something else got broken or the patch work by mistake | 11:21 |
| sdague | because you now have a directory with release notes | 11:22 |
| bauzas | I agree, that's like tribal knowledge | 11:22 |
| sdague | some are missing | 11:22 |
| bauzas | sdague: some are missing because of the bug | 11:22 |
| sdague | bauzas: you'd still have to delete this one regardless right? | 11:22 |
| bauzas | sdague: but you should have the same comments between the yaml files and the output | 11:22 |
| sdague | because it got modified during this cycle for some reason | 11:22 |
| bauzas | sdague: at that point of time, I agree | 11:22 |
| sdague | I feel like if "deleting renos to be consistent" is a thing, we should git rm -f the whole structure at the beginning of a new branch | 11:23 |
| bauzas | sdague: tbc, at a point in time, anyone can build relnotes that should surface the same comments than in the YAML files for that specific point in time | 11:23 |
| bauzas | anyway, I need to drop off for lunch, but interesting talk :) | 11:23 |
| sdague | ok | 11:23 |
| bauzas | we should loop back with dhellmann | 11:24 |
| *** haomaiwang has quit IRC | 11:24 | |
| johnthetubaguy | BobBall: dang it, I see the issue now... | 11:24 |
| *** rtheis has joined #openstack-nova | 11:24 | |
| johnthetubaguy | BobBall: _call_live_migrate_command gets called from two places, I only saw one of them, you are hitting errors in the other one | 11:24 |
| BobBall | Ah ok - no new logs needed yet then? :) | 11:24 |
| BobBall | Ahhh joy. | 11:25 |
| *** shaohe_feng has quit IRC | 11:25 | |
| *** shaohe_feng has joined #openstack-nova | 11:25 | |
| *** Daisy has joined #openstack-nova | 11:26 | |
| johnthetubaguy | BobBall: assert_can_migrate and migrate_send should talk the same params right? | 11:26 |
| johnthetubaguy | BobBall: I think we actually have some bugs hiding in here | 11:27 |
| BobBall | yes, confirmed that they do take the same params in XenAPI | 11:28 |
| *** hieulq has joined #openstack-nova | 11:29 | |
| BobBall | and I think they are? | 11:29 |
| *** klkumar has joined #openstack-nova | 11:29 | |
| *** hieulq has quit IRC | 11:31 | |
| *** smatzek has joined #openstack-nova | 11:31 | |
| *** Daisy has quit IRC | 11:31 | |
| *** robby_ has joined #openstack-nova | 11:32 | |
| openstackgerrit | John Garbutt proposed openstack/nova: xenapi: Fix up passing of sr_uuid_map https://review.openstack.org/293085 | 11:32 |
| johnthetubaguy | BobBall: can you review that, while I improve the tests a touch, does that make sense? basically sr_uuid_map is not defined when we call check, but it is for migrate_send | 11:32 |
| BobBall | johnthetubaguy: That'll be fine. We're asserting that Nova gets the right SRs defined in sr_uuid_map and that they exist on the destination. | 11:33 |
| BobBall | I pressume that migrate_check could reject it if we requst an SR not on the destination, but that would be a bug in the nova code if we did. | 11:34 |
| johnthetubaguy | BobBall: true | 11:34 |
| *** shaohe_feng has quit IRC | 11:35 | |
| *** thorst has joined #openstack-nova | 11:35 | |
| *** MVenesio has joined #openstack-nova | 11:36 | |
| *** shaohe_feng has joined #openstack-nova | 11:36 | |
| *** y_sawai has quit IRC | 11:37 | |
| *** rfolco has joined #openstack-nova | 11:39 | |
| *** MVenesio has quit IRC | 11:41 | |
| *** ihrachys has quit IRC | 11:42 | |
| *** ihrachys has joined #openstack-nova | 11:42 | |
| *** ihrachys has quit IRC | 11:42 | |
| *** moshele has quit IRC | 11:43 | |
| *** cdent has quit IRC | 11:43 | |
| *** ishant has quit IRC | 11:43 | |
| *** erlon has joined #openstack-nova | 11:44 | |
| *** cdelatte has joined #openstack-nova | 11:44 | |
| *** shaohe_feng has quit IRC | 11:45 | |
| *** cdelatte has quit IRC | 11:46 | |
| *** shaohe_feng has joined #openstack-nova | 11:46 | |
| *** cdelatte has joined #openstack-nova | 11:48 | |
| *** moshele has joined #openstack-nova | 11:49 | |
| openstackgerrit | Zhengguang Ou proposed openstack/nova: libvirt: fix detach volume race condition https://review.openstack.org/290510 | 11:49 |
| *** allen_gao has quit IRC | 11:50 | |
| *** rk4n_ has joined #openstack-nova | 11:51 | |
| *** allen_gao has joined #openstack-nova | 11:51 | |
| *** dave-mccowan has joined #openstack-nova | 11:52 | |
| *** rk4n has quit IRC | 11:54 | |
| *** shaohe_feng has quit IRC | 11:55 | |
| *** robcresswell has joined #openstack-nova | 11:56 | |
| *** shaohe_feng has joined #openstack-nova | 11:56 | |
| *** mylu has joined #openstack-nova | 11:56 | |
| *** salv-orlando has joined #openstack-nova | 11:57 | |
| robcresswell | Wondering if anyone could point me in the right direction: Does specifying a port-id when launching an instance hit any particular policy calls other than compute:create? Wondering if attach_interface factors in. | 11:57 |
| BobBall | johnthetubaguy: Now working with the --block-migrate flag. | 11:57 |
| johnthetubaguy | BobBall: awesome, how are the others looking, I guess they need the aggregate change | 11:58 |
| johnthetubaguy | BobBall: actually, did you try with auto? | 11:58 |
| BobBall | I'm testing all 3 changes combined, with the aggregate change. Auto failed and uploading the logs now. | 11:58 |
| *** tiendc has quit IRC | 12:00 | |
| BobBall | johnthetubaguy: vmops.py:2210 - cannot load block_migration in the base class | 12:00 |
| openstackgerrit | garyk proposed openstack/nova: VMware: make the opaque network attachment more robust https://review.openstack.org/284121 | 12:00 |
| *** raildo-afk is now known as raildo | 12:00 | |
| johnthetubaguy | BobBall: darn, that figures I guess | 12:00 |
| BobBall | johnthetubaguy: full logs at http://2e3c642e4296924ff05d-66873027c2788bdf1c2707eeb3e7052a.r54.cf5.rackcdn.com/mitaka-lm-bug/1458129487/ | 12:00 |
| BobBall | johnthetubaguy: It may be because of my aggregate change - I'm setting block_migration = True but the new code was setting destcheck_data.block_migration | 12:01 |
| *** pece has quit IRC | 12:01 | |
| BobBall | johnthetubaguy: Let me rebase my aggregate change to the bottom of the pile so I can fix it there. | 12:01 |
| *** dedery has joined #openstack-nova | 12:01 | |
| *** robby_ has quit IRC | 12:02 | |
| johnthetubaguy | BobBall: can you put it on the top of the chain | 12:02 |
| johnthetubaguy | BobBall: so the final patch fixes the non_block_migration, that way | 12:02 |
| BobBall | johnthetubaguy: we have 3 changes: aggregate, sr_map, block_migration. Currently in that order. | 12:02 |
| openstackgerrit | John Garbutt proposed openstack/nova: xenapi: Fix up passing of sr_uuid_map https://review.openstack.org/293085 | 12:03 |
| *** mylu has quit IRC | 12:03 | |
| openstackgerrit | John Garbutt proposed openstack/nova: xenapi: Fix up issues with live-migrate for xenapi https://review.openstack.org/292937 | 12:04 |
| *** dedery has quit IRC | 12:04 | |
| BobBall | johnthetubaguy: The aggregate change is needed first (really) but the block_migration change modifies my current aggregate fix | 12:04 |
| *** smatzek has quit IRC | 12:04 | |
| johnthetubaguy | BobBall: OK, I was thinking that should come last, let me take a quick peak at that on your branch | 12:05 |
| *** shaohe_feng has quit IRC | 12:06 | |
| *** shaohe_feng has joined #openstack-nova | 12:06 | |
| *** baoli has joined #openstack-nova | 12:07 | |
| *** smatzek has joined #openstack-nova | 12:08 | |
| johnthetubaguy | BobBall: oh, I see, thats a bit nasty... | 12:08 |
| *** jaosorior has quit IRC | 12:08 | |
| BobBall | Aggregate fix needs to be the bottom (or second) on the pile, with a slightly modified block_migration fix at the top | 12:08 |
| *** jaosorior has joined #openstack-nova | 12:09 | |
| *** pece has joined #openstack-nova | 12:09 | |
| *** jaosorior has quit IRC | 12:09 | |
| *** aysyd has joined #openstack-nova | 12:09 | |
| BobBall | I'm working on UT for the aggregate fix ATM then will push | 12:09 |
| *** cdent has joined #openstack-nova | 12:10 | |
| cdent | p!spy | 12:10 |
| *** pece has quit IRC | 12:10 | |
| *** jaosorior has joined #openstack-nova | 12:11 | |
| johnthetubaguy | BobBall: you are right, your fix isn't quite right given the changes at the top of the change, just trying something... | 12:12 |
| *** pece has joined #openstack-nova | 12:13 | |
| BobBall | johnthetubaguy: Indeed. Maybe actually we put block_migration change at the base, then yours, then aggregate fix? | 12:13 |
| BobBall | LM wouldn't work until it was all merged ofc | 12:13 |
| openstackgerrit | John Garbutt proposed openstack/nova: Fix LM aggregate bug https://review.openstack.org/293393 | 12:13 |
| johnthetubaguy | so I tried it on the end | 12:13 |
| johnthetubaguy | but, yeah, it all fails till its all there I guess, hmm | 12:13 |
| BobBall | indeed - anything like that will work. I was just trying to get LM with --block-migration first before tacking on the auto change; but in reality the order doesn't matter. | 12:14 |
| markus_z | melwitt: Could you have a look at https://bugs.launchpad.net/python-novaclient/+bug/1557888 if you find time? I'm unsure about the strategy of printing output after executing a nova CLI command. | 12:15 |
| openstack | Launchpad bug 1557888 in python-novaclient "Nova CLI - No message on nova-agent deletion" [Undecided,Incomplete] - Assigned to Preeti (pandey-preeti1) | 12:15 |
| johnthetubaguy | BobBall: so I made a one line change in your patch that might have fixed it: https://review.openstack.org/#/c/293393/1/nova/virt/xenapi/vmops.py@2190 | 12:16 |
| *** shaohe_feng has quit IRC | 12:16 | |
| *** haomaiwang has joined #openstack-nova | 12:16 | |
| BobBall | johnthetubaguy: Yeah - I said that should fix it above :) | 12:16 |
| BobBall | I'll try that series. | 12:16 |
| *** shaohe_feng has joined #openstack-nova | 12:17 | |
| johnthetubaguy | BobBall: awesome | 12:17 |
| *** haomaiwang has quit IRC | 12:20 | |
| *** sahid has joined #openstack-nova | 12:22 | |
| dims | sdague : seen this yet? https://wiki.openstack.org/wiki/Jacket | 12:24 |
| *** EinstCrazy has joined #openstack-nova | 12:24 | |
| openstackgerrit | John Garbutt proposed openstack/nova: xenapi: Fix up passing of sr_uuid_map https://review.openstack.org/293085 | 12:24 |
| openstackgerrit | John Garbutt proposed openstack/nova: xenapi: fix the live-migrate aggregate check https://review.openstack.org/293393 | 12:24 |
| openstackgerrit | John Garbutt proposed openstack/nova: xenapi: Fix up issues with live-migrate for xenapi https://review.openstack.org/292937 | 12:24 |
| *** ociuhandu has joined #openstack-nova | 12:25 | |
| jaypipes | morning folks. | 12:26 |
| sdague | dims: I was kind of ignoring it | 12:26 |
| dims | :) | 12:26 |
| *** shaohe_feng has quit IRC | 12:26 | |
| BobBall | johnthetubaguy: Both auto mode and specifying --block-migrate on the CLI work with the latest series (from 5 minutes ago... before those uploads just now :P) | 12:26 |
| *** rodrigods has quit IRC | 12:26 | |
| *** rodrigods has joined #openstack-nova | 12:26 | |
| cdent | sdague: I put more comments on: https://review.openstack.org/#/c/293372/ basically "what now?" | 12:27 |
| *** shaohe_feng has joined #openstack-nova | 12:27 | |
| openstackgerrit | sahid proposed openstack/nova: network: make nova to handle port_security_enabled=False https://review.openstack.org/284095 | 12:27 |
| sdague | cdent: you are changing the test | 12:27 |
| johnthetubaguy | dims: eek | 12:27 |
| sdague | but the test runs the same code as the mainpath use of it | 12:27 |
| *** salv-orlando has quit IRC | 12:28 | |
| johnthetubaguy | BobBall: cool, sounds like we are tracking it down | 12:28 |
| dims | johnthetubaguy : indeed | 12:28 |
| *** pcaruana has quit IRC | 12:28 | |
| johnthetubaguy | BobBall: I am going for lunch, do you want to work on unit tests on the aggregate thing, and I can do the top patch | 12:28 |
| johnthetubaguy | BobBall: let me add one comment on your patch quickly | 12:29 |
| cdent | sdague: the test is broken. The use of eventlet in tests is broken. This is a way to fix it so that py34 test runs don't timeout while still confirming the thing that the test wants to confirm. The fact that that eventlet is mysterious and behaves weirdly is something that we already know and is neither confirmed nor denied by this test. | 12:29 |
| BobBall | I'm also going to grab lunch - but will happily work on the UT etc for the aggregate patch once I'm refueled | 12:29 |
| *** akshai has joined #openstack-nova | 12:29 | |
| *** rk4n has joined #openstack-nova | 12:30 | |
| sahid | johnthetubaguy, since number of bug reported against https://review.openstack.org/#/c/284095/ don't you think you think that could be | 12:30 |
| sahid | interesting to have it in our tree for RC? | 12:30 |
| cdent | I agree that it is entirely confusing that fixing this one thing gets us past the hump without immediately going on to another one, but: eventlet. | 12:30 |
| johnthetubaguy | BobBall: added a comment here: https://review.openstack.org/#/c/293393/2/nova/virt/xenapi/vmops.py@2209 | 12:30 |
| sdague | cdent: ok but that means - https://github.com/openstack/nova/blob/298a821a3290ccba6992008d81410ba022b7ca50/nova/tests/functional/wsgi/test_flavor_manage.py#L1 would never work on python3 either | 12:31 |
| sdague | or anything in the functional tree | 12:31 |
| johnthetubaguy | sahid: possibly, not sure I have seen that before now, did you tag the bug? | 12:31 |
| *** fawadkhaliq has quit IRC | 12:31 | |
| sdague | the test isn't broken. The test represents the same call path we use when we call this code for real. | 12:32 |
| cdent | sdague: The test I've fixed blocks every single time. Why other things do not block is beyond my ken. | 12:32 |
| sdague | the code that we are calling is broken | 12:32 |
| sahid | johnthetubaguy: no, no - what kind of tag should i set ? | 12:32 |
| sdague | cdent: because we don't run the functional tests under python3 | 12:32 |
| *** rk4n_ has quit IRC | 12:32 | |
| *** mylu has joined #openstack-nova | 12:32 | |
| cdent | sdague: we can cross that bridge when we come to it? | 12:32 |
| sdague | but that's not going to always be the case. This is unit testing the fixtures we use on that side | 12:32 |
| cdent | what we're going to discover is that the use of eventlet to test the api servers in python3 it utterly broken | 12:33 |
| cdent | and we'll have to fix it then | 12:33 |
| cdent | but in the meantime we can move forward | 12:33 |
| BobBall | johnthetubaguy: The exceptions cannot be raised there as we have either specified block_migration or it has been determined by one of the exceptions being raised earily. Now we're detecting block migration we don't need to ensure the host is in the aggregate at 2209, so we can remove that check. | 12:33 |
| johnthetubaguy | sahid: we are doing the usual tracking of RC potential bugs by using this list: https://bugs.launchpad.net/nova/+bugs?field.tag=mitaka-rc-potential | 12:33 |
| BobBall | johnthetubaguy: I think? | 12:33 |
| cdent | sdague: You could send me off to fix the fixtures, but I don't have time for that right now. I do have time to fix the fact that a py34 test blocks. | 12:33 |
| *** boris-42 has quit IRC | 12:34 | |
| BobBall | johnthetubaguy: And it's not a new exception; just raised in slightly different circumstances | 12:34 |
| sdague | cdent: ok, that's fine. I do get concerned about the work around because this is a really early warning about a bigger issue that we have to crack. | 12:35 |
| *** mylu_ has joined #openstack-nova | 12:35 | |
| cdent | sdague: yeah, I totally get that | 12:35 |
| sahid | johnthetubaguy: done | 12:35 |
| *** lucasagomes is now known as lucas-hungry | 12:35 | |
| johnthetubaguy | BobBall: its the other way around, when you users requested block_migrate=false, if its not in an aggregate, we raise, and that bubbles up to the API handing, ish | 12:35 |
| BobBall | johnthetubaguy: But that same exception could still have bubbled up; and it was the right exception to raise | 12:36 |
| cdent | sdague: hopefully by the time we need to cross that bridge we will have more strategies for extracting eventlet out of the tests or python3 eventlet will have miraculously matured. at the moment we know, from many inputs, that it has not | 12:36 |
| *** shaohe_feng has quit IRC | 12:36 | |
| openstackgerrit | Gleb Stepanov proposed openstack/nova: Add console log offset https://review.openstack.org/292473 | 12:36 |
| *** shaohe_feng has joined #openstack-nova | 12:37 | |
| BobBall | johnthetubaguy: MigrationPreCheckError is only the right exception if we're checking the _destination_ host with get_host_uuid_from_aggregate | 12:37 |
| BobBall | johnthetubaguy: But that check is for the source host, making sure that it is in an aggregate in the first place. At that point the only valid exception would be AggregateHostNotFound not MigrationPreCheckError | 12:37 |
| *** MVenesio has joined #openstack-nova | 12:38 | |
| *** mylu has quit IRC | 12:38 | |
| BobBall | oh no... I see what you mean. | 12:38 |
| johnthetubaguy | BobBall: you are probably right though, that other one might be wrong, when its used like this | 12:38 |
| BobBall | Awesome. This is running on the dest so dest is the current aggregate. There is potentially a case where we try and migrate from a host that isn't in an aggregate to a dest that is in an aggregate (but doesn't have src in that aggregate) | 12:39 |
| BobBall | Eurgh. | 12:39 |
| johnthetubaguy | BobBall: yeah, the exception gets handled here: https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L174 | 12:39 |
| johnthetubaguy | oops, it doesn't | 12:40 |
| johnthetubaguy | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L322 | 12:40 |
| *** rdopiera has joined #openstack-nova | 12:40 | |
| *** mylu_ has quit IRC | 12:40 | |
| sdague | cdent: yeh, I was just wonder if it might make for a good unit test to push the folks that have been doing eventlet python3 bits into using as an example of a thing to fix | 12:41 |
| * cdent is starting a posting to the ml | 12:42 | |
| johnthetubaguy | BobBall: arg, also here: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/migrate_server.py#L105 | 12:42 |
| BobBall | johnthetubaguy: OK - let's change it. Set ensure_host_in_aggregate to catch AggregateHostNotFound and raise as MigrationPreCheckError. That'd be the right move IMO. | 12:43 |
| johnthetubaguy | BobBall: sounds correct | 12:44 |
| *** shaohe_feng has quit IRC | 12:47 | |
| *** shaohe_feng has joined #openstack-nova | 12:48 | |
| *** pradk has joined #openstack-nova | 12:51 | |
| *** jlvillal has quit IRC | 12:52 | |
| *** jlvillal has joined #openstack-nova | 12:52 | |
| * alex_xu reminders nova api meeting in 8 mins | 12:53 | |
| *** gmann_ has joined #openstack-nova | 12:53 | |
| *** gmann_ has quit IRC | 12:53 | |
| *** gmann_ has joined #openstack-nova | 12:53 | |
| *** gszasz has joined #openstack-nova | 12:55 | |
| *** shaohe_feng has quit IRC | 12:57 | |
| doffm | cdent: So is python3 eventlet wierdness a known thing? | 12:57 |
| cdent | doffm: https://github.com/eventlet/eventlet/pull/275/commits/58a55efad1578487f2bc8f6d3b46176f752a8489 | 12:57 |
| cdent | was a recently related changed | 12:57 |
| *** eharney has joined #openstack-nova | 12:57 | |
| *** shaohe_feng has joined #openstack-nova | 12:58 | |
| BobBall | johnthetubaguy: Actually, I think we don't need AggregateHostNotFound here and the safest thing to do is just use MigratePreCheckError. AggregateHostNotFound is only caught in one place and it's re-raised. | 12:59 |
| *** ptm_away has joined #openstack-nova | 13:00 | |
| *** ducttape_ has joined #openstack-nova | 13:00 | |
| cdent | doffm: looks like there's ongoing discussion about related problems: https://github.com/eventlet/eventlet/issues/274 | 13:00 |
| doffm | cdent: Ughh, must have coffee before thinking about this. | 13:01 |
| cdent | yeah, I've gone very deep into the coffee pot this morning | 13:01 |
| *** rk4n has quit IRC | 13:01 | |
| *** Jeffrey4l has quit IRC | 13:02 | |
| *** rk4n has joined #openstack-nova | 13:02 | |
| *** PaulMurray has quit IRC | 13:02 | |
| openstackgerrit | Sean Dague proposed openstack/nova: WIP: experiments with RST and API docs https://review.openstack.org/292420 | 13:03 |
| *** rcernin has joined #openstack-nova | 13:03 | |
| *** shaohe_feng has quit IRC | 13:07 | |
| *** jwcroppe has joined #openstack-nova | 13:08 | |
| *** shaohe_feng has joined #openstack-nova | 13:08 | |
| *** kaisers1 has quit IRC | 13:09 | |
| *** rlrossit has joined #openstack-nova | 13:10 | |
| *** e0ne has joined #openstack-nova | 13:10 | |
| openstackgerrit | Sergey Belous proposed openstack/nova: Do not merge. Patch exists for testing os-vif with Nova https://review.openstack.org/286086 | 13:11 |
| *** ducttape_ has quit IRC | 13:11 | |
| rdopiera | pkoniszewski: hi, do you have a moment? I wonder what the status of https://review.openstack.org/#/c/185958/9 is... would you have a moment to talk about it? | 13:12 |
| *** zhenq has joined #openstack-nova | 13:12 | |
| *** zhenq has left #openstack-nova | 13:13 | |
| *** zhenq has joined #openstack-nova | 13:13 | |
| *** Jeffrey4l has joined #openstack-nova | 13:14 | |
| *** kro_sinus_hell is now known as krot_sinus_purga | 13:15 | |
| *** krot_sinus_purga is now known as kro_sniffles | 13:15 | |
| *** ctrath has joined #openstack-nova | 13:15 | |
| *** smcginnis_away is now known as smcginnis | 13:15 | |
| pkoniszewski | rdopiera: i need to drop, going to orthodontist, we can talk later or tomorrow | 13:16 |
| sahid | jaypipes: any chance you want to review something related to NUMA/HP? | 13:17 |
| *** shaohe_feng has quit IRC | 13:17 | |
| *** rk4n_ has joined #openstack-nova | 13:18 | |
| *** haukebruno has joined #openstack-nova | 13:18 | |
| *** shaohe_feng has joined #openstack-nova | 13:18 | |
| jaypipes | sahid: sure thing. | 13:18 |
| rdopiera | pkoniszewski: ok, enjoy your drilling :) | 13:19 |
| *** kaisers has joined #openstack-nova | 13:19 | |
| doffm | johnthetubaguy: When you have the time could you take a quick look at https://review.openstack.org/#/c/293139/ (spec). Let me know what you think. | 13:19 |
| doffm | Planning to get some scale testing done on it, if people don't hate it. | 13:19 |
| sahid | jaypipes: cool thanks, https://review.openstack.org/#/c/292499 | 13:19 |
| *** gcb has quit IRC | 13:19 | |
| *** xyang1 has joined #openstack-nova | 13:19 | |
| *** rk4n has quit IRC | 13:20 | |
| *** ljxiash has joined #openstack-nova | 13:22 | |
| *** ig0r_ has joined #openstack-nova | 13:24 | |
| *** vladik has joined #openstack-nova | 13:24 | |
| *** lucas-hungry is now known as lucasagomes | 13:26 | |
| *** kaisers has quit IRC | 13:26 | |
| *** ljxiash has quit IRC | 13:26 | |
| *** Jeffrey4l has quit IRC | 13:27 | |
| *** e0ne has quit IRC | 13:27 | |
| *** shaohe_feng has quit IRC | 13:28 | |
| *** rk4n has joined #openstack-nova | 13:28 | |
| *** kaisers has joined #openstack-nova | 13:28 | |
| *** mriedem has joined #openstack-nova | 13:28 | |
| *** fawadkhaliq has joined #openstack-nova | 13:29 | |
| *** shaohe_feng has joined #openstack-nova | 13:29 | |
| *** salv-orlando has joined #openstack-nova | 13:29 | |
| *** haomaiwang has joined #openstack-nova | 13:29 | |
| *** hanrong has joined #openstack-nova | 13:29 | |
| *** hanrong has left #openstack-nova | 13:30 | |
| mriedem | johnthetubaguy: bauzas: are we waiting on anything for rc1? | 13:31 |
| *** rk4n_ has quit IRC | 13:32 | |
| bauzas | mriedem: yup, the prelude section | 13:32 |
| *** ducttape_ has joined #openstack-nova | 13:32 | |
| bauzas | mriedem: https://review.openstack.org/#/c/292785/ | 13:32 |
| mriedem | looking | 13:32 |
| bauzas | mriedem: and I discussed with john, we'll add the translations into a RC2 | 13:32 |
| bauzas | mriedem: was reviewing https://wiki.openstack.org/wiki/Nova/ReleaseChecklist | 13:32 |
| *** gcb has joined #openstack-nova | 13:33 | |
| mriedem | bauzas: did you have a separate change for reno about the ec2 api removal? | 13:33 |
| bauzas | mriedem: yup, was merged | 13:33 |
| bauzas | mriedem: https://review.openstack.org/#/c/293345/ | 13:33 |
| mriedem | https://review.openstack.org/#/c/293345/2/releasenotes/notes/disable_ec2_api_by_default-0ec0946433fc7119.yaml looks weird | 13:34 |
| bauzas | mriedem: see the commit msg | 13:34 |
| mriedem | ah ok | 13:35 |
| *** deepakcs has quit IRC | 13:35 | |
| bauzas | mriedem: I actually just noticed that https://review.openstack.org/#/c/293014/2/releasenotes/notes/lock_policy-75bea372036acbd5.yaml didn't work out | 13:36 |
| bauzas | so, there is a reno change about that | 13:36 |
| *** Drankis has quit IRC | 13:36 | |
| *** smatzek has quit IRC | 13:36 | |
| bauzas | I should also have emptied the above lock_policy yaml in the bus actually... | 13:36 |
| mriedem | yeah http://docs-draft.openstack.org/85/292785/3/check/gate-nova-releasenotes/89ad0bd//releasenotes/build/html/unreleased.html#id5 | 13:37 |
| mriedem | bauzas: do you want to fix that quick? | 13:37 |
| mriedem | i think we could fast approve | 13:37 |
| bauzas | mriedem: sure | 13:37 |
| dansmith | BobBall: johnthetubaguy: you tested live migration after the object changes.. why is it broken now? are there multiple ways to live migrate in xen or something? | 13:37 |
| *** ishant has joined #openstack-nova | 13:37 | |
| bauzas | mriedem: I'm actually trying to figure out how many yaml files were deleted that we missed | 13:38 |
| *** shaohe_feng has quit IRC | 13:38 | |
| johnthetubaguy | dansmith: that was my question to, not sure how this happened | 13:38 |
| dansmith | johnthetubaguy: yeah, hmm | 13:38 |
| *** shaohe_feng has joined #openstack-nova | 13:39 | |
| *** doug-fish has quit IRC | 13:39 | |
| *** salv-orlando has quit IRC | 13:40 | |
| BobBall | dansmith: I tried to go back and re-test to bisect and find the broken changes, but it's a bit tricky because of various changes such as the scheduler class name which aren't trivial to cherry-pick. | 13:41 |
| bauzas | mriedem: oh terrible I figured out a couple of deleted yamls still in the notes, fixing that | 13:41 |
| *** edmondsw has joined #openstack-nova | 13:41 | |
| bauzas | [sbauza@sbauza nova]$ git log --diff-filter=D --oneline releasenotes/notes/ | 13:41 |
| bauzas | 83467b8 Add release note for policy sample file update | 13:41 |
| bauzas | 56d1293 Revert "virt: reserved hugepages on compute host" | 13:41 |
| bauzas | 969c81f Revert "Added new scheduler filter: AggregateTypeExtraSpecsAffinityFilter" | 13:41 |
| bauzas | 8b65185 Revert "Enable options for oslo.reports" | 13:42 |
| bauzas | erm | 13:42 |
| *** doug-fish has joined #openstack-nova | 13:42 | |
| mriedem | oy | 13:42 |
| *** mdrabe has joined #openstack-nova | 13:42 | |
| bauzas | okay, typey typey | 13:42 |
| bauzas | dhellmann: you should probably communicate to all teams that reverts are not removing relnotes | 13:43 |
| dhellmann | bauzas : I have a patch up to fix that, so when the new reno is released with the fix they'll disappear | 13:43 |
| bauzas | dhellmann: we have 5 commits to clean-up | 13:43 |
| dhellmann | bauzas : do what you expect to work, and we'll fix reno | 13:43 |
| bauzas | dhellmann: agreed, I know your change, remember | 13:43 |
| dhellmann | yep | 13:43 |
| dhellmann | still, good idea so folks don't get alarmed | 13:44 |
| bauzas | dhellmann: my biggest worry is that the reno package upgrade won't be in time for mitaka | 13:44 |
| dhellmann | it should happen this week | 13:44 |
| bauzas | dhellmann: in the meantime, I'm flushing out the content of those files | 13:44 |
| bauzas | that's a preventive measure | 13:44 |
| bauzas | and I'd drop those empty files once reno is upgraded | 13:44 |
| *** ptm_away has quit IRC | 13:45 | |
| bauzas | dhellmann: see my workaround here https://review.openstack.org/#/c/293345/ | 13:45 |
| jichen | oomichi: hi, do you have time to talk about https://review.openstack.org/#/c/288153/ | 13:45 |
| dhellmann | bauzas : good plan | 13:46 |
| *** ducttape_ has quit IRC | 13:46 | |
| *** doug-fish has quit IRC | 13:46 | |
| *** shaohe_feng has quit IRC | 13:48 | |
| *** shaohe_feng has joined #openstack-nova | 13:50 | |
| dansmith | BobBall: okay | 13:51 |
| dansmith | BobBall: so there are things up I should help review right? | 13:51 |
| johnthetubaguy | dansmith: need some decent unit tests on some of the patches still, just about to start back on those | 13:52 |
| dansmith | okay | 13:52 |
| *** cleong has joined #openstack-nova | 13:53 | |
| auggy | johnthetubaguy: i can follow up on the i18n stuff to see if there are any translation patches | 13:54 |
| *** mtanino has joined #openstack-nova | 13:54 | |
| *** mriedem is now known as mriedem_meeting | 13:54 | |
| *** gmann_ has quit IRC | 13:54 | |
| *** armax has joined #openstack-nova | 13:54 | |
| auggy | i volunteered to be CPL for that with the disclaimer of being fairly new ;) | 13:55 |
| johnthetubaguy | doffm: I did actually try out, I think we a version of that on our cells scheduler at the moment actually, I should take a look post RC1, my main memory is that negative weights blew my mind, and did you see this one where I remove weights: https://review.openstack.org/#/c/256323/ | 13:55 |
| johnthetubaguy | auggy: awesome, that would be great, thank you | 13:55 |
| johnthetubaguy | auggy: I think we changed how we do that at some point | 13:55 |
| BobBall | I think the two main issues were what seems to be a change in behaviour of AggregateList (perhaps if you weren't in an aggregate it would return [None] before but now returns []), and the changes around migrate_send_data being passed all the way through to support auto detecting block_migration | 13:55 |
| BobBall | dansmith: ^^ | 13:55 |
| sdague | dhellmann: I think there are some subtleties of the fact that reno is using the git history and not the contents of a directory that makes for unexpected situations | 13:55 |
| auggy | johnthetubaguy: lol ok, i just went by what the zanata folks had told me the process was | 13:56 |
| *** houming_ has quit IRC | 13:56 | |
| dansmith | BobBall: oh, I think that latter one came after the original migration patches, so that makes sense | 13:56 |
| dhellmann | sdague : yeah, I noted that bug. that'll have to wait for newton, but I think we can try to address it | 13:56 |
| *** PaulMurray has joined #openstack-nova | 13:56 | |
| sdague | dhellmann: cool | 13:56 |
| dhellmann | sdague : there's a pretty narrowly focused spot to make the change, it's just a matter of time | 13:57 |
| johnthetubaguy | BobBall: I was going to start tidying this one up now: https://review.openstack.org/#/c/292937/ | 13:57 |
| BobBall | dansmith: We do have a working series of patches though - but as johnthetubaguy says, more work on unit tests going on | 13:57 |
| dhellmann | sdague : I think the main issue was differentiating between a local file on the "current" branch and versions of that file (or not having it at all) on other branches | 13:58 |
| BobBall | johnthetubaguy: Are your unit tests clean on https://review.openstack.org/#/c/293085/6 now? | 13:58 |
| *** shaohe_feng has quit IRC | 13:58 | |
| *** pushkaru has joined #openstack-nova | 13:58 | |
| *** smatzek has joined #openstack-nova | 13:58 | |
| BobBall | johnthetubaguy: I think you wanted 293085 as the base, right? then 292937 then 293393? | 13:59 |
| sdague | dhellmann: yeh, though I think as we're managing 3 or 4 active branches with this content, it's going to get more confusing | 13:59 |
| johnthetubaguy | BobBall: I switched it around, I liked your suggested order, in the end, once I understood your patch better | 13:59 |
| *** shaohe_feng has joined #openstack-nova | 13:59 | |
| johnthetubaguy | BobBall: the middle patch should work, I want to do a review of it, because the tests are too messy really | 14:00 |
| BobBall | johnthetubaguy: So you want me to fix UT at the base with the aggregate check in 293393? | 14:00 |
| dhellmann | sdague : yeah, some of the refactoring work I've done to deal with caching for non-git use will actually make this easier to solve, but that hasn't landed yet | 14:00 |
| sdague | dhellmann: cool, sounds like you have it under hand | 14:00 |
| johnthetubaguy | BobBall: ideally check out the latest gerrit version of that aggregate fix, yeah | 14:00 |
| openstackgerrit | garyk proposed openstack/nova: Virt: add context to attach and detach interface https://review.openstack.org/209362 | 14:00 |
| *** doug-fish has joined #openstack-nova | 14:00 | |
| *** doug-fish has quit IRC | 14:01 | |
| *** haomaiwang has quit IRC | 14:01 | |
| johnthetubaguy | BobBall: I will work on the top one, and I will try not to kill your changes, honest, although not sure how easy that actually is | 14:01 |
| *** doug-fish has joined #openstack-nova | 14:01 | |
| *** haomaiwang has joined #openstack-nova | 14:01 | |
| *** rk4n_ has joined #openstack-nova | 14:01 | |
| *** mgoddard_ has joined #openstack-nova | 14:01 | |
| *** edtubill has joined #openstack-nova | 14:02 | |
| *** ivase has joined #openstack-nova | 14:02 | |
| *** dmellado is now known as dmellado|lunch | 14:02 | |
| BobBall | johnthetubaguy: That's fine. I'll work on the bottom one, then you just need to rebase the 2nd one on the bottom one. | 14:03 |
| *** rk4n has quit IRC | 14:04 | |
| BobBall | Any ideas how to avoid race conditions with large (32 CPU) boxes running tox? :) I'm getting TypeError: this TransactionFactory is already started randomly which kills dozens of tests when it occurs | 14:04 |
| *** mgoddard has quit IRC | 14:05 | |
| *** lhinds_ has joined #openstack-nova | 14:06 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Fix reno reverts that are still shown https://review.openstack.org/293450 | 14:06 |
| bauzas | mriedem_meeting: johnthetubaguy: sdague: one last clean-up and we should be good to go | 14:06 |
| *** mgagne has quit IRC | 14:07 | |
| *** toan has quit IRC | 14:07 | |
| *** mgagne has joined #openstack-nova | 14:07 | |
| *** toan has joined #openstack-nova | 14:08 | |
| *** busterswt has joined #openstack-nova | 14:08 | |
| bauzas | johnthetubaguy: once the above is merged, I think we should be good for RC1 | 14:08 |
| bauzas | unless someone sees a blocker | 14:09 |
| *** shaohe_feng has quit IRC | 14:09 | |
| bauzas | markus_z: any recent bug that which would need to stop RC1 ? | 14:09 |
| *** shaohe_feng has joined #openstack-nova | 14:09 | |
| *** ducttape_ has joined #openstack-nova | 14:10 | |
| johnthetubaguy | bauzas: awesome, thank you | 14:10 |
| johnthetubaguy | bauzas: the xenapi fix live-migrate would be nice to have, but given we need an RC2, and the code is not yet ready for review, I say its missed RC1 | 14:10 |
| bauzas | johnthetubaguy: yeah I'm just reviewing https://bugs.launchpad.net/nova/+bugs?field.tag=mitaka-rc-potential | 14:11 |
| bauzas | 4 open bugs | 14:11 |
| *** pwnall has joined #openstack-nova | 14:11 | |
| johnthetubaguy | yeah, we had a few new ones that need a peak | 14:11 |
| bauzas | sahid: not sure https://bugs.launchpad.net/nova/+bug/1460630 needs to block RC1 | 14:11 |
| openstack | Launchpad bug 1460630 in OpenStack Compute (nova) "nova should not verify "port_security_enabled" according the info from network" [Undecided,In progress] - Assigned to sahid (sahid-ferdjaoui) | 14:12 |
| openstackgerrit | Bob Ball proposed openstack/nova: xenapi: Fix the live-migrate aggregate check https://review.openstack.org/293393 | 14:12 |
| bauzas | sahid: at least it's not a mitaka regression | 14:12 |
| dansmith | bauzas: agreed | 14:13 |
| BobBall | d'oh - missed one of my changes... hang on.. | 14:13 |
| *** knikolla has joined #openstack-nova | 14:13 | |
| bauzas | sahid: that's something we could backport to mitaka if that's merged at newton | 14:14 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Short proof of concept for gabby test framework https://review.openstack.org/293456 | 14:14 |
| robcresswell | Quick question, sorry if I'm misunderstanding; does booting with a port-id hit the attach_interface policy, or is it just the create policy that is applied? | 14:14 |
| openstackgerrit | Bob Ball proposed openstack/nova: xenapi: Fix the live-migrate aggregate check https://review.openstack.org/293393 | 14:14 |
| BobBall | johnthetubaguy: ^^ I think (hope) that's OK for review now. | 14:15 |
| bauzas | sahid: I'm also concerned by https://bugs.launchpad.net/nova/+bug/1543149 given it's not a regression | 14:15 |
| openstack | Launchpad bug 1543149 in OpenStack Compute (nova) "Reserve host pages on compute nodes" [High,In progress] - Assigned to sahid (sahid-ferdjaoui) | 14:15 |
| openstackgerrit | Sean Dague proposed openstack/nova: WIP: experiments with RST and API docs https://review.openstack.org/292420 | 14:15 |
| *** salv-orlando has joined #openstack-nova | 14:15 | |
| johnthetubaguy | BobBall: which line generates the keyerror, that looks a bit odd now | 14:16 |
| johnthetubaguy | BobBall: I guess thats the .metadata[hostname] bit? | 14:16 |
| BobBall | johnthetubaguy: Line immediately before the exception, with the metadata[hostname] | 14:16 |
| bauzas | BobBall: johnthetubaguy: how things are going with the XenAPI driver ? | 14:16 |
| bauzas | s/driver/bug | 14:16 |
| BobBall | bauzas: It's a source of continued joy and happiness. | 14:16 |
| BobBall | bauzas: (We have working patches - just tidying them up) | 14:17 |
| johnthetubaguy | yeah that | 14:17 |
| BobBall | johnthetubaguy: Want a "if hostname in .metadata" instead? | 14:17 |
| johnthetubaguy | tidy up and quick re-test | 14:17 |
| johnthetubaguy | BobBall: sounds good | 14:17 |
| dansmith | johnthetubaguy: BobBall noted some issues in the second patch for sr_uuid_map | 14:18 |
| openstackgerrit | garyk proposed openstack/nova: VMware: prevent volume deletion if volume in instance folder https://review.openstack.org/193103 | 14:18 |
| *** shaohe_feng has quit IRC | 14:19 | |
| *** shaohe_feng has joined #openstack-nova | 14:20 | |
| *** mspreitz has joined #openstack-nova | 14:21 | |
| bauzas | mriedem_meeting: that sounds a gate problem, hence Critical, right ? | 14:21 |
| bauzas | oh man | 14:21 |
| bauzas | missing the link | 14:22 |
| bauzas | snap | 14:22 |
| bauzas | https://bugs.launchpad.net/nova/+bug/1480305 is much better | 14:22 |
| openstack | Launchpad bug 1480305 in OpenStack Compute (nova) "DBDeadlock inserting into instance_extra" [Medium,In progress] - Assigned to John Garbutt (johngarbutt) | 14:22 |
| bauzas | johnthetubaguy: just reviewing the above ^ why are you thinking it's worth waiting for it for RC1 ? | 14:22 |
| bauzas | speaking of https://review.openstack.org/#/c/292800/ | 14:22 |
| openstackgerrit | Bob Ball proposed openstack/nova: xenapi: Fix the live-migrate aggregate check https://review.openstack.org/293393 | 14:23 |
| *** jichen has quit IRC | 14:23 | |
| johnthetubaguy | bauzas: its not now, it was causing gate issues for neutron, and seemed worth doing, but it too late now | 14:23 |
| bauzas | johnthetubaguy: I'm about to +2 it given some notice about the possible cell impact, but I'd drop mitaka-rc-potential, agreed ? | 14:24 |
| johnthetubaguy | bauzas: yeah, thats fine | 14:25 |
| *** ducttape_ has quit IRC | 14:25 | |
| *** Daisy_ has joined #openstack-nova | 14:26 | |
| dansmith | johnthetubaguy: BobBall just to be clear, the base migratedata object should never be used by your driver, nor received anywhere.. it's just a base class for inheritance purposes, which is why it's not registered | 14:27 |
| *** zenoway has quit IRC | 14:27 | |
| johnthetubaguy | dansmith: yeah agreed, the issue we saw what unset attributes triggering a not found in base class error, so we had to use the "in" checks, is that normal? | 14:28 |
| *** mrkz has joined #openstack-nova | 14:28 | |
| *** ducttape_ has joined #openstack-nova | 14:28 | |
| *** Swami has joined #openstack-nova | 14:29 | |
| *** shaohe_feng has quit IRC | 14:29 | |
| *** zz_dimtruck is now known as dimtruck | 14:29 | |
| dansmith | johnthetubaguy: yeah, if it's possible to be unset, then you need to check | 14:30 |
| *** fawadkhaliq has quit IRC | 14:30 | |
| *** shaohe_feng has joined #openstack-nova | 14:30 | |
| dansmith | johnthetubaguy: that's a kinda fundamental objects thing, since we can always have unset fields (potentially-lazy-loaded for db-type objects) | 14:30 |
| *** aswadr_ has quit IRC | 14:30 | |
| *** fawadkhaliq has joined #openstack-nova | 14:30 | |
| johnthetubaguy | dansmith: yeah, I see your point, you need that for lazy load, got it | 14:30 |
| dansmith | johnthetubaguy: the other option is to always send it over the wire of course, but I was mirroring the existing code that didn't always send it for whatever reason | 14:30 |
| dansmith | yeah | 14:30 |
| *** rk4n has joined #openstack-nova | 14:30 | |
| johnthetubaguy | dansmith: yeah, that makes sense | 14:31 |
| *** Daisy_ has quit IRC | 14:31 | |
| *** zenoway has joined #openstack-nova | 14:31 | |
| BobBall | dansmith / johnthetubaguy: FYI I think the aggregate issue fixed in https://review.openstack.org/#/c/293393 may have been introduced when NovaObjectDictCompat was removed | 14:32 |
| dansmith | BobBall: yeah | 14:32 |
| johnthetubaguy | ah... I see | 14:32 |
| dansmith | BobBall: I would say you could blame rlrossit, but with no xen live migration tests, he really can't be blamed :) | 14:32 |
| *** sc68cal has joined #openstack-nova | 14:33 | |
| BobBall | Well since rlrossit doesn't seem to be here at the moment, I might blame him anyway. Just don't tell him I did so. | 14:33 |
| dansmith | heh | 14:33 |
| *** dedery has joined #openstack-nova | 14:33 | |
| *** rk4n_ has quit IRC | 14:33 | |
| BobBall | But yeah... Xen live migration tests do seem to be somewhat required | 14:33 |
| dansmith | aye | 14:34 |
| dansmith | well, only if you want to keep it working I guess :) | 14:34 |
| auggy | johnthetubaguy: re: translations, I am following up with the i18n folks to make sure, but the gerrit query the zanata team gave me shows zero open translations. it shows the last submission as from sept last year and that has already been merged | 14:34 |
| BobBall | I suppose keeping live migration is kinda important... ;) | 14:34 |
| johnthetubaguy | auggy: OK, I saw similar things, not sure if thats correct or not | 14:35 |
| BobBall | It's on our backlog of things to add. Got a new CI env setting up soon, so will hopefully be able to use that. | 14:35 |
| dansmith | bauzas: johnthetubaguy so which things are waiting for for rc1 specifically? | 14:35 |
| *** ducttape_ has quit IRC | 14:35 | |
| auggy | johnthetubaguy: i sent an email to the i18n mailing list just letting them know we're cutting RC1 so if they have anything for us, we need it like *now* | 14:35 |
| johnthetubaguy | auggy: thanks for digging, I am expecting an RC2 to include translations anyways | 14:35 |
| bauzas | dansmith: only a reno change AFAIK plus the xen live-mig but we could do the latter for RC2 | 14:35 |
| johnthetubaguy | auggy: mostly because hard string freeze hits with RC1 | 14:35 |
| auggy | johnthetubaguy: kk, i'll keep an eye on it | 14:35 |
| johnthetubaguy | auggy: thank you :) | 14:35 |
| auggy | johnthetubaguy: yeah the hard string freeze | 14:35 |
| dansmith | bauzas: the xen ones should be rc2, IMHO | 14:36 |
| * auggy is learning things! | 14:36 | |
| *** dedery has quit IRC | 14:36 | |
| bauzas | dansmith: okay, so the only blocker is https://review.openstack.org/#/c/293450/ | 14:36 |
| johnthetubaguy | dansmith: +1 | 14:37 |
| dansmith | bauzas: got it | 14:37 |
| bauzas | dansmith: johnthetubaguy: are we planning to do RPC pins during RC2 ? | 14:37 |
| bauzas | are we also planning to bump major RPC versions ? | 14:38 |
| dansmith | bauzas: we bumped last time, I think we're good this time | 14:38 |
| bauzas | for bumps, gotcha | 14:38 |
| bauzas | but for the version aliases ? | 14:38 |
| dansmith | we do that post-release right? | 14:38 |
| bauzas | I know that we have the 'auto' value | 14:38 |
| bauzas | dansmith: that was an open question :) | 14:38 |
| johnthetubaguy | dansmith: so the checklist says its the other way around, its before release | 14:39 |
| bauzas | if we do that post-release, it's finr | 14:39 |
| bauzas | johnthetubaguy: yeah that | 14:39 |
| bauzas | we should verify | 14:39 |
| johnthetubaguy | dansmith: I guess you want N-1 to have the pin for the name of the N-1 release? | 14:39 |
| johnthetubaguy | and use that same config as you roll forward | 14:39 |
| *** shaohe_feng has quit IRC | 14:39 | |
| dansmith | yeah, I think the first few times we backported the alias | 14:39 |
| dansmith | so that's why I think of it as after | 14:40 |
| dansmith | because if we had to change rpc in rc3, we'd have to move the alias | 14:40 |
| *** wanghao has quit IRC | 14:40 | |
| dansmith | since we know we're going to have an rc2, let's hold off | 14:40 |
| dansmith | in case we have to do something stupid for this xen thing | 14:40 |
| johnthetubaguy | yeah, that works | 14:40 |
| *** shaohe_feng has joined #openstack-nova | 14:40 | |
| *** wanghao has joined #openstack-nova | 14:41 | |
| bauzas | dansmith: not sure I understood the point, you said that we should do the aliases during rc2 | 14:43 |
| bauzas | ? | 14:43 |
| dansmith | yeah | 14:43 |
| bauzas | I mean, at the last release candidate, gotcha | 14:43 |
| openstackgerrit | Chris Dent proposed openstack/nova: Work around stall in py34 unit tests https://review.openstack.org/293372 | 14:43 |
| bauzas | okay, wfm | 14:43 |
| bauzas | johnthetubaguy: actively monitoring zuul for prepping the release patch, if you agree | 14:45 |
| bauzas | I don't know yet the merged patch sha1 | 14:45 |
| bauzas | for topping rc1 | 14:45 |
| *** esracelik has quit IRC | 14:46 | |
| *** mgoddard_ has quit IRC | 14:47 | |
| *** mgoddard has joined #openstack-nova | 14:47 | |
| *** shaohe_feng has quit IRC | 14:50 | |
| *** sahid has left #openstack-nova | 14:50 | |
| openstackgerrit | Alexis Lee proposed openstack/nova: Add FK bw_usage_cache.uuid -> instances.uuid https://review.openstack.org/248780 | 14:51 |
| *** shaohe_feng has joined #openstack-nova | 14:51 | |
| sbelous | pkholkin: ping | 14:53 |
| *** mriedem_meeting is now known as mriedem | 14:56 | |
| mriedem | bauzas: what gate problem? | 14:56 |
| mriedem | bauzas: do you mean the xen live migration thing? | 14:57 |
| doffm | johnthetubaguy: I had not seen that. Will read through now. | 14:58 |
| openstackgerrit | Bob Ball proposed openstack/nova: xenapi: Fix the live-migrate aggregate check https://review.openstack.org/293393 | 14:59 |
| bauzas | mriedem: no sorry, https://bugs.launchpad.net/nova/+bug/1480305 | 15:00 |
| openstack | Launchpad bug 1480305 in OpenStack Compute (nova) "DBDeadlock inserting into instance_extra" [Medium,In progress] - Assigned to John Garbutt (johngarbutt) | 15:00 |
| doffm | johnthetubaguy: I have thought a bunch about negative weights for the probability placment. Haven't put it in the spec yet. I ended up just considering the total weight a measurement of 'emptiness' of a host. | 15:00 |
| *** shaohe_feng has quit IRC | 15:00 | |
| bauzas | mriedem: but that seems not really needing a critical | 15:00 |
| rlrossit | dansmith: BobBall: I love taking blame | 15:00 |
| *** ctrath has quit IRC | 15:00 | |
| *** haomaiwang has quit IRC | 15:01 | |
| BobBall | Win-win then! :) | 15:01 |
| *** ctrath has joined #openstack-nova | 15:01 | |
| *** shaohe_feng has joined #openstack-nova | 15:01 | |
| *** haomaiwang has joined #openstack-nova | 15:01 | |
| *** AJaeger has joined #openstack-nova | 15:01 | |
| cdent | rlrossit: I'm hungry and have a headache, can I blame you? | 15:02 |
| rlrossit | cdent: go for it | 15:02 |
| cdent | rlrossit: you bastard, why you make me suffer so? | 15:02 |
| rlrossit | it's also my fault that america isn't great, that's why we need someone to make it great again | 15:02 |
| cdent | If I didn't have a headacahe america would be great again | 15:03 |
| AJaeger | nova team, the compute API Guide contains a few sphinx bugs when build, I fixed these with https://review.openstack.org/292137 and also enabled warnings as errors to avoid regressions. The job is non-voting currently - could you review and tell me whether it's ok, please? | 15:03 |
| mriedem | bauzas: that's been around for a long time | 15:03 |
| bauzas | mriedem: that's what I saw, hence me saying it's not critical | 15:04 |
| doffm | johnthetubaguy: I took the weight 'as-is' without really worrying how it was normalized or combined. | 15:04 |
| doffm | alaski: Are we having a cells meeting today? | 15:07 |
| alaski | doffm: yes sir | 15:07 |
| alaski | in just under two hours | 15:07 |
| *** sfinucan has joined #openstack-nova | 15:07 | |
| doffm | Fantastic. | 15:07 |
| openstackgerrit | sahid proposed openstack/nova: livirt: handle reserved pages size https://review.openstack.org/292500 | 15:08 |
| openstackgerrit | sahid proposed openstack/nova: virt: reserved hugepages on compute host https://review.openstack.org/292499 | 15:08 |
| *** READ10 has joined #openstack-nova | 15:08 | |
| *** mdrabe has quit IRC | 15:09 | |
| *** mdrabe has joined #openstack-nova | 15:09 | |
| *** shaohe_feng has quit IRC | 15:10 | |
| *** shaohe_feng has joined #openstack-nova | 15:11 | |
| *** edtubill has quit IRC | 15:13 | |
| *** yamahata has joined #openstack-nova | 15:15 | |
| *** david-lyle has quit IRC | 15:15 | |
| *** david-lyle has joined #openstack-nova | 15:15 | |
| *** dmellado|lunch is now known as dmellado | 15:15 | |
| *** ociuhandu has quit IRC | 15:16 | |
| *** purplerbot has quit IRC | 15:16 | |
| *** purplerbot has joined #openstack-nova | 15:17 | |
| *** ekuris_ has quit IRC | 15:17 | |
| *** knikolla has quit IRC | 15:17 | |
| *** liverpooler has quit IRC | 15:17 | |
| BobBall | johnthetubaguy: What's the next step on the LM bug? Do you need help in fixing your change or rebasing on https://review.openstack.org/#/c/293393 ? | 15:18 |
| *** gjayavelu has joined #openstack-nova | 15:18 | |
| mriedem | jaypipes: dansmith: alaski: johnthetubaguy: bauzas: commented on that db deadlock thing https://review.openstack.org/#/c/292800/ | 15:18 |
| johnthetubaguy | BobBall: sorry, yeah, I am working through my change and the little fix ups, doing that full time now, rather than during a meeting, so should be making progress now! | 15:19 |
| jaypipes | mriedem: looking... | 15:19 |
| BobBall | johnthetubaguy: No worries; just shout if you need my help or when there is a new combined change I can test. | 15:19 |
| dansmith | johnthetubaguy: mriedem: Is this something to do with recent enginefacade stuff? | 15:20 |
| bauzas | mriedem: so I feel your point looks good, was just +2ing because I thought it was a very smart workaround for that until we have a better solution | 15:20 |
| dansmith | I hadn't heard of this being a problem before | 15:20 |
| mriedem | dansmith: it's been around since last year | 15:20 |
| mriedem | dansmith: http://status.openstack.org//elastic-recheck/#1480305 | 15:20 |
| mriedem | it's not very frequent | 15:20 |
| johnthetubaguy | dansmith: yeah, I thought the same honestly, but it seems to have been cropping up for a while | 15:20 |
| dansmith | okay | 15:20 |
| bauzas | mriedem: TBH, I'm concerned by a cells v2 world where we would create instances in the DB after we have a BuildRequest | 15:20 |
| dansmith | I'm not really sure why creating new things would deadlock I guess | 15:20 |
| dansmith | but I wouldn't know | 15:20 |
| *** shaohe_feng has quit IRC | 15:20 | |
| mriedem | i'm just wondering if creating all of the new things at once is causing the deadlock | 15:21 |
| bauzas | mriedem: hoping that kind of situation in a cells v2 world would be nicer to fix | 15:21 |
| mriedem | but this is only 5 hits in 10 days | 15:21 |
| bauzas | mriedem: that was what I was supposing | 15:21 |
| johnthetubaguy | mriedem: I am having a similar feeling, I do wonder if we committed in the same order each time we would avoid the deadlock | 15:21 |
| openstackgerrit | Gleb Stepanov proposed openstack/nova: Console log copy for block live migration https://review.openstack.org/284674 | 15:21 |
| *** shaohe_feng has joined #openstack-nova | 15:21 | |
| johnthetubaguy | google seems to suggest using select...for update to force an ordering, but that just breaks galera | 15:22 |
| *** knikolla has joined #openstack-nova | 15:22 | |
| johnthetubaguy | all I discovered was that I clearly don't understand how INSERT generated deadlocks :( | 15:22 |
| dansmith | yeah | 15:22 |
| mriedem | hence my ping to mr mysql | 15:22 |
| openstackgerrit | Sergey Belous proposed openstack/nova: Do not merge. Patch exists for testing os-vif with Nova https://review.openstack.org/286086 | 15:22 |
| *** ociuhandu has joined #openstack-nova | 15:23 | |
| johnthetubaguy | mriedem: ah, I meant to ping him, but forgot to do that | 15:23 |
| *** dedery has joined #openstack-nova | 15:25 | |
| sdague | so, under pymysql we can have multiple db things going on in a single worker, unlike the c lib one | 15:29 |
| *** moshele has quit IRC | 15:29 | |
| *** browne has joined #openstack-nova | 15:29 | |
| openstackgerrit | Gleb Stepanov proposed openstack/nova: Add console log offset https://review.openstack.org/292473 | 15:29 |
| sdague | so is this an issue where we yielded because something else in a complex transaction, and another API request comes in triggering something similar | 15:30 |
| dansmith | I guess if we lock the table and yield to something else that goes to lock the table | 15:30 |
| *** shaohe_feng has quit IRC | 15:31 | |
| johnthetubaguy | oh... thats possible | 15:31 |
| dansmith | we had parallelism here before, | 15:31 |
| sdague | we should only be row locking, but are there transactions we're in the middle of? | 15:31 |
| sdague | dansmith: we hard paralleism at the worker level right? | 15:31 |
| dansmith | but only across workers, which wouldn't cause one to deadlock | 15:31 |
| *** shaohe_feng has joined #openstack-nova | 15:31 | |
| dansmith | right | 15:31 |
| dansmith | what I mean is, | 15:31 |
| sdague | now we are potentially sharing a connection | 15:32 |
| dansmith | we had parallelism before from mysql's perspective, but not within our workers which could double acquire | 15:32 |
| *** dedery has quit IRC | 15:32 | |
| sdague | which would also explain the low frequency | 15:32 |
| dansmith | yeah | 15:32 |
| sdague | because it just is a legit race under load right now | 15:32 |
| *** dedery has joined #openstack-nova | 15:32 | |
| *** fawadkhaliq has quit IRC | 15:33 | |
| sdague | I would bet if you look at the logs there are 2 simultaneous creates on different API requests in the same API worker | 15:33 |
| johnthetubaguy | could it just be our delay that triggers the deadlock detection for false reasons? | 15:33 |
| sdague | honestly, it's all just speculation at this point, going through detailed logs would be required | 15:34 |
| *** fawadkhaliq has joined #openstack-nova | 15:34 | |
| dansmith | johnthetubaguy: what delay? | 15:34 |
| sdague | would also be interesting if we could instrument the exception path to dump more details when this happens | 15:34 |
| *** david-lyle_ has joined #openstack-nova | 15:34 | |
| johnthetubaguy | dansmith: eventlet letting another thread do things while we are stalled | 15:34 |
| *** david-lyle has quit IRC | 15:34 | |
| dansmith | so I thought the deadlock comes from the sql client | 15:35 |
| johnthetubaguy | sdague: I just wonder how we check we aquire the locks in the same order | 15:35 |
| dansmith | like, I didn't think it was time-based | 15:35 |
| dansmith | johnthetubaguy: a guru-meditation dump at the time would show us with two greenthreads in that path at the same time | 15:35 |
| dansmith | we might be able to instrument that detection in the handler | 15:36 |
| johnthetubaguy | ah, right, thats a good idea | 15:36 |
| dansmith | check the rest of our siblings to see if they have a stack frame equivalent to ours at the place where we raised or something | 15:36 |
| johnthetubaguy | its tempting to do that for all DB deadlock retries by default, in some ways? | 15:36 |
| sdague | that stacktrace is super ass confusing | 15:36 |
| *** jaosorior has quit IRC | 15:36 | |
| dansmith | well, right, it'd be something we'd want to do generically | 15:36 |
| dansmith | sdague: link? | 15:37 |
| mriedem | sdague: it's wrapped in lots of decorators | 15:37 |
| mriedem | http://logs.openstack.org/20/275420/25/gate/gate-tempest-dsvm-neutron-linuxbridge/cb556d1/logs/screen-n-api.txt.gz?#_2016-03-15_02_04_36_061 | 15:37 |
| sdague | http://logstash.openstack.org/#dashboard/file/logstash.json?query=_id%3AAVN7pq9Kw4vKJcnDtV7U | 15:37 |
| sdague | well that's the logstash one I was looking at | 15:37 |
| *** vishwanathj_zzz is now known as vishwanathj | 15:38 | |
| dansmith | johnthetubaguy: yeah, see it comes from mysql | 15:38 |
| *** fawadkhaliq has quit IRC | 15:38 | |
| sdague | right it's definitely from mysql | 15:38 |
| dansmith | so that one is different than instance_extra | 15:39 |
| dansmith | but similar | 15:39 |
| johnthetubaguy | OK, its good to rule that out | 15:39 |
| dansmith | a second thing we create in the create instance path | 15:39 |
| dansmith | er, wait | 15:39 |
| knikolla | when snapshotting a vm, does glance call back to nova? | 15:40 |
| mriedem | that's liberty http://logs.openstack.org/08/292608/2/check/gate-grenade-dsvm/5c6efdf/logs/old/screen-n-api.txt | 15:40 |
| mriedem | the hit in that logstash query is liberty | 15:40 |
| mriedem | which is why the line numbers threw me off | 15:40 |
| dansmith | ohhh | 15:41 |
| mriedem | which didn't have the enginefacade stuff | 15:41 |
| dansmith | we're in instance create | 15:41 |
| *** shaohe_feng has quit IRC | 15:41 | |
| mriedem | yeah | 15:41 |
| dansmith | which calls ec2_instance_create | 15:41 |
| *** jroll has quit IRC | 15:41 | |
| dansmith | which saves instances? | 15:41 |
| *** jroll has joined #openstack-nova | 15:41 | |
| *** jroll has quit IRC | 15:41 | |
| *** jroll has joined #openstack-nova | 15:41 | |
| mriedem | i think that commits the transation | 15:41 |
| mriedem | *transaction | 15:41 |
| johnthetubaguy | I think thats where the flush happens | 15:41 |
| johnthetubaguy | yeah, that | 15:41 |
| dansmith | oh, that's the sqla ref, nevermind | 15:41 |
| *** shaohe_feng has joined #openstack-nova | 15:41 | |
| mriedem | which is why i was suggesting, insert the instance record first, then insert the foreign key table records | 15:42 |
| mriedem | rather than a mega commit | 15:42 |
| mriedem | b/c it has to sort through all the backrefs | 15:42 |
| dansmith | well, I don't think that's the right fix | 15:42 |
| dansmith | it'd just be mitigation | 15:42 |
| mriedem | sure, so is retrying on deadlock | 15:43 |
| dansmith | yep, yep | 15:43 |
| johnthetubaguy | well, I do wonder if enforcing the order would avoid the deadlock | 15:43 |
| johnthetubaguy | i.e. force we always acquire the locks in the same order, somehow | 15:43 |
| johnthetubaguy | but I guess thats across all db transactions, which doesn't totally sound that tractable, I guess | 15:44 |
| dansmith | I don't think so | 15:44 |
| dansmith | because we could yield at any point during any one of these, AFAIK | 15:44 |
| bauzas | folks, got to leave soon (wife's birthday), so I'm about to tag RC1 by tomorrow morning (or later tonight, will reconnect) | 15:45 |
| bauzas | johnthetubaguy: you okay? | 15:45 |
| *** pwnall has quit IRC | 15:45 | |
| dansmith | we can tag once that other patch lands right? | 15:45 |
| johnthetubaguy | bauzas: I think so, are all the reno things in now? | 15:45 |
| johnthetubaguy | right | 15:45 |
| bauzas | https://review.openstack.org/293450 is 15 mins away from being merged | 15:45 |
| johnthetubaguy | I think we can tag once that lands | 15:45 |
| dansmith | johnthetubaguy: +1 | 15:45 |
| mriedem | we're not waiting for the xen live migration thing? | 15:46 |
| dansmith | no | 15:46 |
| johnthetubaguy | cool, I will push up the release patch once it merges | 15:46 |
| bauzas | mriedem: no, planned as rc2 | 15:46 |
| bauzas | johnthetubaguy: sounds good to me | 15:46 |
| johnthetubaguy | RC2 is needed for translations anyways | 15:46 |
| bauzas | (interesting thoughts on the db deadlock, need to scrollback) | 15:46 |
| johnthetubaguy | if we get the xen one merged soon ish, then we backport it before final release | 15:46 |
| bauzas | agreed | 15:46 |
| johnthetubaguy | bauzas: have a good evening | 15:47 |
| bauzas | well, will reconnect later :p | 15:47 |
| *** mylu has joined #openstack-nova | 15:47 | |
| *** shaohe_feng has quit IRC | 15:51 | |
| *** browne has quit IRC | 15:51 | |
| *** shaohe_feng has joined #openstack-nova | 15:52 | |
| *** apoorvad has joined #openstack-nova | 15:52 | |
| dansmith | reno patch just got reset, it's #5 in the gate | 15:55 |
| johnthetubaguy | hey, ho, its moving up | 15:55 |
| claudiub | it's the final countdown! | 15:57 |
| AJaeger | johnthetubaguy, sdague, nova team: I just pinged on #openstack-infra but want to tell you here as well: 293526 and 292472 and rename gate-nova-python27 to gate-nova-python27-db etc in project-config. So, that in a followup we can remove database setup from the normal python27 jobs (similar for python34 etc). Could you review those, please? This is part of our infra consolidation on one trusty image. | 15:57 |
| dansmith | https://www.youtube.com/watch?v=9jK-NcRmVcw | 15:57 |
| AJaeger | if there are questions, let's discuss on #openstack-infra | 15:58 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Handle race in allocate_for_instance https://review.openstack.org/221803 | 15:59 |
| *** dedery has quit IRC | 15:59 | |
| *** artom_ has joined #openstack-nova | 15:59 | |
| *** haomaiwang has quit IRC | 16:01 | |
| *** haomaiwang has joined #openstack-nova | 16:01 | |
| *** e0ne has joined #openstack-nova | 16:01 | |
| *** shaohe_feng has quit IRC | 16:01 | |
| *** klkumar has quit IRC | 16:01 | |
| *** shaohe_feng has joined #openstack-nova | 16:02 | |
| *** fawadkhaliq has joined #openstack-nova | 16:04 | |
| *** matrohon has quit IRC | 16:05 | |
| *** cdent has quit IRC | 16:05 | |
| *** harlowja_at_home has joined #openstack-nova | 16:07 | |
| mriedem | tjones_zzzz: how can i tell why this failed? http://208.91.1.172/logs/nova-vc6-dsvm-tempest/272414/18/2944/ | 16:09 |
| mriedem | devstack was fine | 16:09 |
| mriedem | there are no test results or console log that i can see from a test run | 16:09 |
| mriedem | looks like n-api didn't start http://208.91.1.172/logs/nova-vc6-dsvm-tempest/272414/18/2944/n-api.log.gz?level=TRACE | 16:09 |
| *** geekinutah has joined #openstack-nova | 16:10 | |
| markus_z | bauzas: I was afk. The bugs which came in the last 24 hours were not serious. | 16:11 |
| markus_z | bauzas: It looks like only the xen one is left | 16:11 |
| *** EinstCrazy has quit IRC | 16:11 | |
| *** belmoreira has quit IRC | 16:11 | |
| *** shaohe_feng has quit IRC | 16:12 | |
| mriedem | sdague: shouldn't devstack fail if one of the services in the ENABLED_SERVICES list didn't start? | 16:12 |
| dansmith | BobBall: AggregateList.get_by_host() is returning [None] ? | 16:12 |
| *** shaohe_feng has joined #openstack-nova | 16:12 | |
| *** allen_gao has quit IRC | 16:13 | |
| auggy | johnthetubaguy: i'll send an email to the i18n list letting them know we plan to include translations in RC2 | 16:14 |
| *** harlowja_at_home has quit IRC | 16:15 | |
| *** allen_gao has joined #openstack-nova | 16:15 | |
| johnthetubaguy | auggy: OK, thats what they asked us to do with the Hard vs Soft freeze last cycle, at least, really good idea to double check what they want from us there | 16:16 |
| auggy | johnthetubaguy: np, i am on it | 16:17 |
| johnthetubaguy | auggy: :) | 16:17 |
| *** kfarr has joined #openstack-nova | 16:17 | |
| dansmith | now #1 in the gate, 20m to merge | 16:19 |
| *** Swami has quit IRC | 16:19 | |
| *** allen_gao has quit IRC | 16:20 | |
| *** david-lyle_ is now known as david-lyle | 16:20 | |
| *** paul-carlton1 has quit IRC | 16:20 | |
| *** shaohe_feng has quit IRC | 16:22 | |
| *** harlowja_at_home has joined #openstack-nova | 16:22 | |
| *** shaohe_feng has joined #openstack-nova | 16:22 | |
| *** allen_gao has joined #openstack-nova | 16:23 | |
| *** dedery has joined #openstack-nova | 16:25 | |
| openstackgerrit | sahid proposed openstack/nova: libvirt: handle reserved pages size https://review.openstack.org/292500 | 16:27 |
| openstackgerrit | sahid proposed openstack/nova: virt: reserved hugepages on compute host https://review.openstack.org/292499 | 16:27 |
| *** mgoddard has quit IRC | 16:28 | |
| *** mgoddard has joined #openstack-nova | 16:28 | |
| *** pwnall has joined #openstack-nova | 16:30 | |
| *** cdent has joined #openstack-nova | 16:30 | |
| *** astupnikov has quit IRC | 16:31 | |
| *** shaohe_feng has quit IRC | 16:32 | |
| *** fawadkhaliq has quit IRC | 16:32 | |
| *** shaohe_feng has joined #openstack-nova | 16:33 | |
| *** dedery has quit IRC | 16:33 | |
| *** fawadkhaliq has joined #openstack-nova | 16:33 | |
| *** mdrabe_ has joined #openstack-nova | 16:33 | |
| *** fawadkhaliq has quit IRC | 16:33 | |
| *** mdrabe has quit IRC | 16:34 | |
| *** ljxiash has joined #openstack-nova | 16:36 | |
| *** Swami has joined #openstack-nova | 16:37 | |
| *** browne has joined #openstack-nova | 16:38 | |
| openstackgerrit | John Garbutt proposed openstack/nova: xenapi: Fix when auto block_migration in the API https://review.openstack.org/292937 | 16:38 |
| openstackgerrit | John Garbutt proposed openstack/nova: xenapi: refactor check_can_live_migrate_destination https://review.openstack.org/293553 | 16:38 |
| auggy | johnthetubaguy: so it looks like the search I was using was outdated :/ | 16:38 |
| *** links has quit IRC | 16:38 | |
| *** dedery has joined #openstack-nova | 16:38 | |
| auggy | johnthetubaguy: i got this from the mailing list - https://review.openstack.org/#/c/291556/ | 16:38 |
| johnthetubaguy | auggy: ah, oops, we should try get that in before we tag, I guess | 16:39 |
| auggy | johnthetubaguy: the branch is zanata/translations not transifex/translations apparantly | 16:39 |
| johnthetubaguy | ah, right | 16:40 |
| auggy | i can't remember where i got that old link from, i thought someone in the i18n channel gave it tme | 16:40 |
| johnthetubaguy | I know I was missing something | 16:40 |
| johnthetubaguy | yeah, I found the old link in their wiki somehwere, so worth updating that I guess | 16:40 |
| dansmith | johnthetubaguy: that reno patch is out of the queue | 16:41 |
| dansmith | johnthetubaguy: i.e. merged | 16:41 |
| johnthetubaguy | ah, cools | 16:42 |
| johnthetubaguy | I guess, do we want to wait for translations as well, I think we might just want to cut anayways | 16:42 |
| *** matrohon has joined #openstack-nova | 16:42 | |
| dansmith | johnthetubaguy: I kinda feel like we should just cut rc1.. we could wait forever.. we know we have rc2 coming | 16:42 |
| *** shaohe_feng has quit IRC | 16:42 | |
| *** Daisy has joined #openstack-nova | 16:42 | |
| johnthetubaguy | dansmith: yeah, we can do a quick RC2 if we have to | 16:43 |
| *** mdrabe has joined #openstack-nova | 16:43 | |
| johnthetubaguy | I will get that patch up now | 16:43 |
| *** eil397 has joined #openstack-nova | 16:43 | |
| dansmith | johnthetubaguy: the translations aren't a rush right? | 16:43 |
| dansmith | why wouldn't they just wait for the rc2 with the xen fix and whatever else we're waiting for? | 16:43 |
| *** shaohe_feng has joined #openstack-nova | 16:43 | |
| johnthetubaguy | no, rush, really | 16:43 |
| johnthetubaguy | there will be more updates by the time we hit RC2, which is expected | 16:43 |
| johnthetubaguy | there are not loads of them yet, anyways | 16:43 |
| *** jlanoux has quit IRC | 16:44 | |
| *** mdrabe_ has quit IRC | 16:45 | |
| markus_z | AJaeger: The -1 is only because I thing we can use "toctree hidden" in https://review.openstack.org/#/c/292137/2 | 16:45 |
| markus_z | AJaeger: Maybe adding the nits in a next patch set and everything should be fine then | 16:46 |
| markus_z | s/thing/think | 16:46 |
| *** e0ne has quit IRC | 16:47 | |
| *** e0ne_ has joined #openstack-nova | 16:47 | |
| dansmith | johnthetubaguy: you can line this up right behind the newton open if you want: | 16:47 |
| *** Daisy has quit IRC | 16:47 | |
| dansmith | https://review.openstack.org/#/c/289449/ | 16:47 |
| dansmith | johnthetubaguy: we still can't land the sanity check migration until grenade gets updated, but I have a query saved to find and -2 any other migrations and will keep checking for them | 16:48 |
| auggy | johnthetubaguy: ok cool, so to confirm, translations are going into RC2 | 16:48 |
| johnthetubaguy | dansmith: I am not quite sure how we do the newton open anymore, given we don't have a version in setup.cfg, just working that out | 16:48 |
| dansmith | johnthetubaguy: ah, okay | 16:48 |
| dansmith | well, when you do, please un- -2 that patch so we can get it in early | 16:49 |
| *** scheuran has quit IRC | 16:49 | |
| dansmith | johnthetubaguy: I should get a patch up for the rpc aliases too, for rc2 huh? | 16:49 |
| *** flwang1 has quit IRC | 16:49 | |
| mriedem | i'd tihnk stable/mitaka is just created from the rc1 tag | 16:49 |
| johnthetubaguy | we should do that | 16:49 |
| *** READ10 has quit IRC | 16:49 | |
| johnthetubaguy | mriedem: yeah, I think thats how it work, but not 100% sure | 16:49 |
| johnthetubaguy | normally we just pick the commit before landing the open release commit | 16:50 |
| *** e0ne has joined #openstack-nova | 16:50 | |
| *** dedery has quit IRC | 16:50 | |
| *** fawadkhaliq has joined #openstack-nova | 16:50 | |
| *** e0ne_ has quit IRC | 16:50 | |
| *** fawadkhaliq has quit IRC | 16:51 | |
| *** fawadkhaliq has joined #openstack-nova | 16:51 | |
| *** nic has joined #openstack-nova | 16:52 | |
| *** shaohe_feng has quit IRC | 16:53 | |
| *** mylu has quit IRC | 16:53 | |
| *** e0ne has quit IRC | 16:53 | |
| *** shaohe_feng has joined #openstack-nova | 16:54 | |
| *** nkrinner has quit IRC | 16:54 | |
| dansmith | johnthetubaguy: | 16:55 |
| openstackgerrit | Dan Smith proposed openstack/nova: Set RPC version aliases for Mitaka https://review.openstack.org/293565 | 16:55 |
| *** pwnall has quit IRC | 16:55 | |
| *** unicell has quit IRC | 16:56 | |
| auggy | johnthetubaguy: i should probably add the translations change to one of our etherpads, which one is the best one? mitaka-nova-priorities? | 16:57 |
| *** zenoway has quit IRC | 16:58 | |
| *** geekinutah has quit IRC | 16:58 | |
| johnthetubaguy | auggy: so its limbo time, as the etherpad still has mitaka in the name | 16:59 |
| *** pushkaru has quit IRC | 16:59 | |
| *** pushkaru has joined #openstack-nova | 16:59 | |
| *** raildo is now known as raildo-afk | 17:00 | |
| johnthetubaguy | dansmith: I guess we don't do pins for the ComputeTaskAPI | 17:00 |
| *** e0ne has joined #openstack-nova | 17:00 | |
| johnthetubaguy | auggy: lets stay on this one till release I guess: https://etherpad.openstack.org/p/mitaka-nova-priorities-tracking | 17:00 |
| *** haomaiwang has quit IRC | 17:01 | |
| dansmith | johnthetubaguy: pins for either conductor api don't really make sense anyway | 17:01 |
| johnthetubaguy | dansmith: true | 17:01 |
| markus_z | mriedem: I was thinking about the mitaka-backport-potential tag for bugs. | 17:01 |
| auggy | johnthetubaguy: alright! i'll just tack it onto the end of the etherpad in its own section | 17:01 |
| markus_z | mriedem: Does it make sense to put that on all open bugs when we release RC? | 17:01 |
| *** dedery has joined #openstack-nova | 17:01 | |
| *** haomaiwang has joined #openstack-nova | 17:01 | |
| mriedem | markus_z: all? | 17:01 |
| johnthetubaguy | markus_z: for finding RC2 bugs I guess? | 17:01 |
| markus_z | mriedem: yeah | 17:02 |
| mriedem | markus_z: i think anything that was rc potential but didn't make it is mitaka-backport-potential | 17:02 |
| markus_z | johnthetubaguy: I though about when someone fixes a bug in Newton|Ocata that this is already there | 17:02 |
| mriedem | i don't know how many open bugs we have, but it seems wrong to just blanket apply that tag | 17:02 |
| johnthetubaguy | yeah, lets only add the tag when we need it | 17:02 |
| markus_z | mriedem: I wasn't sure if that would be overkill to be honest | 17:02 |
| johnthetubaguy | its a judgment call if it needs the backport | 17:03 |
| markus_z | johnthetubaguy: mriedem: ok, understood | 17:03 |
| *** shaohe_feng has quit IRC | 17:03 | |
| johnthetubaguy | I think we want the rc-potential tag still, as once we do RC2, we need to decide if we want an RC3, for example | 17:03 |
| mriedem | markus_z: if there are confirmed/triaged/in-progress bugs that were reported against mitaka (or liberty), then i could see adding the mitaka-backport-potential tag, but that's probably still a lot of bugs | 17:03 |
| *** shaohe_feng has joined #openstack-nova | 17:04 | |
| dansmith | definitely not blanket-apply | 17:04 |
| markus_z | mriedem: yep, it's a lot | 17:05 |
| markus_z | johnthetubaguy: The rc-blocker tag got removed from a few, but they should still be in the etherpad | 17:06 |
| johnthetubaguy | dansmith: I think I got the correct commit here: https://review.openstack.org/#/c/293562/1 | 17:06 |
| dansmith | johnthetubaguy: I'm the wrong one to ask.. I've messed that up multiple times I think :D | 17:06 |
| dansmith | dhellmann: ^ | 17:06 |
| dansmith | or mriedem | 17:07 |
| johnthetubaguy | dansmith: just checking its the correct git hash for that last patch really | 17:07 |
| dansmith | well, | 17:07 |
| dansmith | at one point someone told me it was supposed to be the merge commit | 17:07 |
| dansmith | and then not | 17:07 |
| dansmith | and then again | 17:07 |
| dansmith | so I dunno ;P | 17:07 |
| johnthetubaguy | commit a5486b32a3c476f3ad584d8ff7c4eda2bb3e400d | 17:07 |
| johnthetubaguy | 2016-03-16 17:01:28.325 | Author: Sylvain Bauza <sbauza@redhat.com> | 17:07 |
| johnthetubaguy | 2016-03-16 17:01:28.325 | Date: Wed Mar 16 14:52:21 2016 +0100 | 17:07 |
| johnthetubaguy | 2016-03-16 17:01:28.325 | | 17:07 |
| johnthetubaguy | 2016-03-16 17:01:28.326 | Fix reno reverts that are still shown | 17:07 |
| *** lpetrut has quit IRC | 17:07 | |
| johnthetubaguy | so it has that one in | 17:08 |
| johnthetubaguy | I guess thats the main thing | 17:08 |
| mriedem | should be 99ad55ad9d0e954b8a175a61271a6f150cc05039 | 17:08 |
| johnthetubaguy | cool | 17:08 |
| *** jistr has quit IRC | 17:12 | |
| *** shaohe_feng has quit IRC | 17:13 | |
| *** shaohe_feng has joined #openstack-nova | 17:14 | |
| markus_z | johnthetubaguy: I added the "RC2 (potential)" section in the etherpad. It contains the bugs which are not in RC1 but were|are tagged with rc-blocker. | 17:15 |
| *** paul-carlton2 has joined #openstack-nova | 17:15 | |
| johnthetubaguy | markus_z: coolness | 17:17 |
| *** mspreitz has quit IRC | 17:17 | |
| markus_z | johnthetubaguy: AJaeger has found some doc issue which might be interesting for a RC2? https://review.openstack.org/#/c/292137/2 | 17:18 |
| *** dedery has quit IRC | 17:19 | |
| johnthetubaguy | markus_z: that just gets uploaded from master, so I think its ok not backporting that at the moment | 17:20 |
| markus_z | johnthetubaguy: Ah, you're right, I forgot that | 17:21 |
| *** shaohe_feng has quit IRC | 17:23 | |
| openstackgerrit | Bob Ball proposed openstack/nova: xenapi: Fix the live-migrate aggregate check https://review.openstack.org/293393 | 17:24 |
| *** shaohe_feng has joined #openstack-nova | 17:24 | |
| openstackgerrit | Thomas Maddox proposed openstack/nova: [WIP - DO NOT MERGE] Testing LXC Gate https://review.openstack.org/274792 | 17:26 |
| thomasem | johnthetubaguy: mriedem: Was having much better success with Fedora 23 yesterday, fyi. | 17:27 |
| *** unicell has joined #openstack-nova | 17:27 | |
| dansmith | BobBall: found a couple bugs in that latest patch | 17:27 |
| thomasem | I put up a patch here: https://review.openstack.org/#/c/293585/ and set the WIP test patch where I'm invoking the experimental pipeline to depend on the Change ID: https://review.openstack.org/#/c/274792/10 | 17:28 |
| *** lpetrut has joined #openstack-nova | 17:28 | |
| thomasem | That should pull in the dependent project-config in that experimental pipeline, correct? | 17:28 |
| *** e0ne has quit IRC | 17:30 | |
| mriedem | johnthetubaguy: in the cells meeting we're talking about lining up priorities for newton, wrt cells v2 specs, do you have any objection to just starting a new newton priorities etherpad now? i'm assuming cellsv2 wll be on that list | 17:31 |
| *** lucasagomes is now known as lucas-afk | 17:33 | |
| *** shaohe_feng has quit IRC | 17:34 | |
| *** shaohe_feng has joined #openstack-nova | 17:35 | |
| johnthetubaguy | mriedem: sounds cool to me | 17:35 |
| openstackgerrit | Thomas Maddox proposed openstack/nova: [WIP - DO NOT MERGE] Testing LXC Gate https://review.openstack.org/274792 | 17:35 |
| johnthetubaguy | mriedem: just put a link at the top of the mitaka one telling people where to find the new one I guess, then I am happy | 17:36 |
| *** ndipanov has quit IRC | 17:36 | |
| mriedem | johnthetubaguy: ok | 17:36 |
| *** armax has quit IRC | 17:37 | |
| *** sfinucan has quit IRC | 17:38 | |
| *** johnthetubaguy_ has joined #openstack-nova | 17:39 | |
| *** atuvenie has quit IRC | 17:40 | |
| *** mylu has joined #openstack-nova | 17:41 | |
| *** johnthetubaguy has quit IRC | 17:41 | |
| *** johnthetubaguy_ is now known as johnthetubaguy | 17:41 | |
| *** lpetrut has quit IRC | 17:43 | |
| *** ctrath1 has joined #openstack-nova | 17:43 | |
| BobBall | dansmith: Oops... Indeed - the standard return value must be [] or None I guess otherwise I don't see how it could work... | 17:43 |
| dansmith | yeah | 17:44 |
| dansmith | well, | 17:44 |
| *** shaohe_feng has quit IRC | 17:44 | |
| dansmith | BobBall: you mean for mock? | 17:44 |
| BobBall | yeah | 17:44 |
| dansmith | BobBall: the standard return value is a MagicMock() | 17:44 |
| *** gszasz has quit IRC | 17:44 | |
| BobBall | Ho hum. I wonder why the code 'worked' with a MagicMock then... | 17:44 |
| *** ctrath has quit IRC | 17:44 | |
| *** shaohe_feng has joined #openstack-nova | 17:45 | |
| dansmith | yeah, that was my question | 17:45 |
| *** vishwanathj is now known as vishwanathj_chow | 17:45 | |
| rdopiera | MagicMock is falsy | 17:45 |
| BobBall | I wonder what len(MagicMock) is :) I'm hoping it's 0 | 17:46 |
| *** sdague has quit IRC | 17:46 | |
| BobBall | w00t - it is 0 | 17:46 |
| BobBall | That's why the unit tests pass. | 17:46 |
| johnthetubaguy | oh my, joy | 17:46 |
| BobBall | Presumably MagicMock implements all of the things to look like an iterable as well... | 17:47 |
| rdopiera | it "implements" all attributes and returns MagicMock from them | 17:48 |
| mriedem | johnthetubaguy: we're waiting to +W this right? https://review.openstack.org/#/c/291556 | 17:48 |
| johnthetubaguy | mriedem: I think we can +W that right away | 17:49 |
| *** fawadkhaliq has quit IRC | 17:49 | |
| mriedem | ok | 17:49 |
| *** derekh has quit IRC | 17:50 | |
| *** fawadkhaliq has joined #openstack-nova | 17:50 | |
| *** mdrabe has quit IRC | 17:51 | |
| *** mdrabe has joined #openstack-nova | 17:51 | |
| *** sdague has joined #openstack-nova | 17:52 | |
| *** rlrossit has quit IRC | 17:52 | |
| dansmith | mriedem: your comment about "the flavor in the server body" -- do you mean the instance attributes like memory_mb and stuff that are actually attached to the instance itself? | 17:52 |
| dansmith | there's no actual flavor: attribute inside the instance that I know of | 17:52 |
| *** rcernin has quit IRC | 17:53 | |
| dansmith | mriedem: or do you mean this: https://github.com/openstack/nova/blob/master/doc/api_samples/all_extensions/server-get-resp.json#L14 ? | 17:53 |
| mriedem | that | 17:53 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/views/servers.py#L121 | 17:54 |
| *** salv-orl_ has joined #openstack-nova | 17:54 | |
| dansmith | okay, I'm confused, because we can't stop returning that without breaking the api, which is the whole point of this spec, right? | 17:54 |
| *** shaohe_feng has quit IRC | 17:54 | |
| sdague | this is the new flavor links spec? | 17:55 |
| *** shaohe_feng has joined #openstack-nova | 17:55 | |
| alaski | sdague: yeah | 17:55 |
| dansmith | sdague: yeah | 17:55 |
| sdague | dansmith: a thing I realized when writing that up is that the fields we'd actually expose on this new resource end up being < bytes than the links to the resource | 17:56 |
| *** salv-orlando has quit IRC | 17:56 | |
| sdague | so there is an argument to be made for just inline them in the server representation | 17:57 |
| dansmith | sdague: but the point here is to keep the api working, not to reduce the size right? | 17:57 |
| *** lhinds_ has quit IRC | 17:57 | |
| dansmith | sdague: and, if we dump flavors later, it seems less bad to me to have a broken or missing link field, than to remove a whole chunk of attributes | 17:57 |
| sdague | the point is to stop regularly handing out busted links | 17:57 |
| dansmith | well, the point for me is not really the existing bugs, | 17:58 |
| dansmith | but to not break that entirely with cellsv2 | 17:58 |
| sdague | and that any graphical tool is basically *always* making the double call | 17:58 |
| dansmith | because if we move flavors to the api, we're unable to honor that | 17:58 |
| sdague | dansmith: or if you delete a flavor today | 17:58 |
| dansmith | yep, understand | 17:58 |
| sdague | the delete case exposes it without cells already | 17:58 |
| dansmith | I know, I just said I don't care as much about that | 17:59 |
| dansmith | it's nice to fix it for sure | 17:59 |
| *** mgoddard_ has joined #openstack-nova | 17:59 | |
| dansmith | but with cellsv2 (which will be all of nova) it'll be permanently broken | 17:59 |
| dansmith | which is more of a concern to me | 17:59 |
| dansmith | or rather, delaying cellsv2 as a result of not wanting to break it (or redesign more first) | 17:59 |
| *** browne has quit IRC | 17:59 | |
| sdague | sure | 17:59 |
| alaski | so rather than debating these two alternatives why not do both? do what sdague has currently proposed as a short term thing with an eventual goal of moving towards jaypipes suggestion | 18:00 |
| *** PaulMurray has quit IRC | 18:00 | |
| dansmith | jaypipes' suggestion is not really doable today I think, | 18:00 |
| dansmith | because it requires some more thinking and abstraction of things | 18:00 |
| dansmith | I think sdague's suggestion was to just inline the same thing in the server itself. right sdague ? | 18:01 |
| *** haomaiwang has quit IRC | 18:01 | |
| jaypipes | dansmith: gimme a bit.. on a meeting | 18:01 |
| sdague | dansmith: right | 18:01 |
| alaski | yeah. it could be a dependency of the resource provider work in motion and be handled as part of that effrot later | 18:01 |
| *** haomaiwang has joined #openstack-nova | 18:01 | |
| dansmith | sdague: yeah, so if you want to inline the flavor and provide the link, that's fine | 18:01 |
| dansmith | sdague: but I think jaypipes would argue that he'd rather keep the link and inline some other representation later | 18:01 |
| mriedem | dansmith: sdague: that was an alternative proposed, | 18:01 |
| mriedem | inlining it i mean | 18:01 |
| openstackgerrit | John Garbutt proposed openstack/nova: xenapi: rename dest_check_data to migrate_data https://review.openstack.org/293537 | 18:01 |
| sdague | right, that was an alternative, sorry | 18:02 |
| mriedem | the spec as written has a link | 18:02 |
| sdague | dansmith: I don't know what "also provide a link" means | 18:02 |
| dansmith | the thing is, we already have inlined copies of most of this stuff | 18:02 |
| sdague | dansmith: we don't | 18:02 |
| *** browne has joined #openstack-nova | 18:02 | |
| *** mgoddard has quit IRC | 18:02 | |
| dansmith | we do on the instance, but not in the api, I see my fault | 18:02 |
| sdague | right | 18:02 |
| sdague | the spec as written is that we have it in the instance, use the instance data instead and do almost the same thing | 18:03 |
| sdague | however, in walking that through, it actually made me wonder why (as expresssed in an alternative) we don't just return that information inline | 18:03 |
| dansmith | sdague: the spec as writen says we just fix the link | 18:03 |
| sdague | dansmith: correct | 18:04 |
| mriedem | but sdague likes the alternative inline approach now | 18:04 |
| *** baoli has quit IRC | 18:04 | |
| dansmith | so, when we discussed this in vancouver I think it was, | 18:04 |
| *** shaohe_feng has quit IRC | 18:04 | |
| mriedem | this came out of a ML thread i thought | 18:04 |
| dansmith | the plan was (I thought) to cheat and expose the new link even for v2.0 people to avoid breaking them | 18:04 |
| alaski | sdague: for now there is some dissatisfaction with how the data is modeled, so moving it inline might be better of waiting until some of the resource provider rework is done | 18:04 |
| dansmith | alaski: right, see I was thinking that instead of inlining the thing jaypipes hates, keep it separate as a formal flavor resource | 18:05 |
| mriedem | personally i tend to like the inline idea so i don't have to make 2 calls | 18:05 |
| dansmith | alaski: and then inline the thing he wants after we do the modeling | 18:05 |
| *** shaohe_feng has joined #openstack-nova | 18:05 | |
| alaski | dansmith: agreed | 18:05 |
| sdague | dansmith: no, I never intended to break our contract on this one | 18:05 |
| *** lpetrut has joined #openstack-nova | 18:05 | |
| dansmith | mriedem: I don't see how that doesn't make jaypipes more mad | 18:05 |
| dansmith | sdague: not sure which way you mean.. we break our contract with v2.0 people if we don't keep a working link in there, right? | 18:06 |
| sdague | adding a new resource on v2.0 seems like a bad call | 18:06 |
| alaski | mriedem: ultimately we should inline, but not with the current flavor model, is my thinking | 18:06 |
| dansmith | alaski: +1 | 18:06 |
| mriedem | dansmith: if not inlining helps with the future resource stuff, then i'm fine with just fixing the link | 18:06 |
| dansmith | mriedem: I think that makes more sense to me | 18:07 |
| mriedem | as written in the spec | 18:07 |
| openstackgerrit | sean mooney proposed openstack/nova: stop setting mtu when plugging vhost-user ports https://review.openstack.org/271444 | 18:07 |
| *** geekinutah has joined #openstack-nova | 18:07 | |
| dansmith | sdague: well, I was sure we talked about exposing it just so the link would be there, but... okay | 18:07 |
| dansmith | sdague: horizon breaks today if we do that, right? | 18:07 |
| *** haukebruno has quit IRC | 18:07 | |
| sdague | because people are just going to hardcode GET /v2/{foo}/servers/{id}/flavor into their toolkits, and it will break on a bunch of public clouds | 18:07 |
| dansmith | which means horizon from today won't work with nova +1 | 18:07 |
| mriedem | horizon uses novaclient so i'm not sure what they do | 18:08 |
| sdague | horizon today follows links we provide, but exposing resources retroactively causes all these other issues | 18:08 |
| dansmith | sdague: we could store a uuid in the instance flavor and make it unpredictable :D | 18:08 |
| dansmith | sdague: well, that means horizon of today doesn't work with newton | 18:08 |
| dansmith | which seems bad to me, and I thought that was the whole point of doing this route instead of just removing the link entirely | 18:09 |
| *** ccarmack has joined #openstack-nova | 18:09 | |
| sdague | so in newton, the v2 API just doesn't work, is what you are telling me? | 18:10 |
| dansmith | well, that's how it would be right? | 18:10 |
| dansmith | and not just v2, but v2.N where N is less than 30 or whatever we're at right now | 18:11 |
| dansmith | just seems like the lesser of two evils to leak a new resource back than to break everyone | 18:11 |
| openstackgerrit | John Garbutt proposed openstack/nova: xenapi: rename dest_check_data to migrate_data https://review.openstack.org/293537 | 18:11 |
| sdague | when you leak a new resource back, what you actually do is create a ton of client software that doesn't work on all the public clouds | 18:12 |
| dansmith | I hear you | 18:12 |
| dansmith | but newtony client software won't work on them either | 18:12 |
| dansmith | er, existing clients on newtony servers | 18:13 |
| sdague | which was exactly the thing we were trying to avoid in doing the microversion approach and being careful about it | 18:13 |
| dansmith | whatever :) | 18:13 |
| openstackgerrit | John Garbutt proposed openstack/nova: xenapi: Fix up passing of sr_uuid_map https://review.openstack.org/293085 | 18:13 |
| sdague | so, I guess I don't understand with all the care to other parts of upgrade, how that can be the case :) | 18:13 |
| openstackgerrit | John Garbutt proposed openstack/nova: xenapi: Fix when auto block_migration in the API https://review.openstack.org/292937 | 18:13 |
| dansmith | I just don't see how we can move flavors out of the API as we need to for cellsv2 and not break every existing client right now | 18:13 |
| sdague | but, anyway, I think this is going to need a high bw pow wow, because I'm obviously missing bits | 18:14 |
| dansmith | okay | 18:14 |
| mriedem | i'm lost too on the 'moving flavors out of the api' thing | 18:14 |
| *** rlrossit has joined #openstack-nova | 18:14 | |
| dansmith | mriedem: moving them out of the cell and into the api | 18:14 |
| alaski | flavor links will be broken for deleted flavors | 18:14 |
| mriedem | changing the link in a microversion so it's a sub-resource on server allows us to get around the deleted flavor thing in the flavors api | 18:14 |
| dansmith | perhaps a confusing choice of words | 18:14 |
| mriedem | sure, | 18:14 |
| sdague | alaski: s/will be/are/ | 18:15 |
| *** shaohe_feng has quit IRC | 18:15 | |
| mriedem | but with the subresource we get the flavor out of instance.flavor | 18:15 |
| alaski | sdague: fair | 18:15 |
| *** shaohe_feng has joined #openstack-nova | 18:15 | |
| openstackgerrit | Andreas Jaeger proposed openstack/nova: Error on API Guide warnings https://review.openstack.org/292137 | 18:15 |
| dansmith | mriedem: right, but if we don't generate the flavor link for 2.0 people because they don't have the resource, then the link is missing or empty | 18:16 |
| johnthetubaguy | honestly, I feel we need to think about a flavor "lifecycle" a little bit more | 18:16 |
| alaski | by not exposing this throught all api versions we're saying that we're breaking the api for all versions less than the introduction of this new flavor thing | 18:16 |
| dansmith | right | 18:16 |
| openstackgerrit | Bob Ball proposed openstack/nova: xenapi: Fix the live-migrate aggregate check https://review.openstack.org/293393 | 18:16 |
| *** READ10 has joined #openstack-nova | 18:16 | |
| dansmith | so we can break the api a little with a leaky thing, | 18:16 |
| mriedem | "For clarity, you might want to mention whether or not the server response body will have a flavor entry with the existing flavor id and links to the flavors API or if you plan on removing that as part of this (which I don't think we should do)." | 18:16 |
| dansmith | or we can break it completely by not letting the thing leak | 18:16 |
| mriedem | is what i said in bristol | 18:16 |
| mriedem | and -1ed the spec | 18:16 |
| *** vilobhmm11 has joined #openstack-nova | 18:17 | |
| melwitt | johnthetubaguy: +1 | 18:17 |
| sdague | so, I'm happy to do a high bw thing at some point, because I don't understand why the existing flavor links are unsupportable. But I think that we're not going to sort it in irc today | 18:17 |
| alaski | sdague: it takes them from sometimes works to never works, when deleted | 18:18 |
| dansmith | alaski: so I've lost my context on one point actually, and maybe I'm completely crazy and making this harder than it needs to be | 18:18 |
| openstackgerrit | Thierry Carrez proposed openstack/nova: Update reno for stable/mitaka https://review.openstack.org/293635 | 18:18 |
| openstackgerrit | Andreas Jaeger proposed openstack/nova: Error on API Guide warnings https://review.openstack.org/292137 | 18:18 |
| jaypipes | dansmith, sdague, mriedem: ok, sorry guys, my meeting is done now. I can talk if you'd like. | 18:18 |
| johnthetubaguy | I do prefer the always breaks when flavor is deleted | 18:18 |
| dansmith | alaski: for cellsv2, we move flavors from the cell to the api database, which means we effectively lose the ability to even lie about the link between the instance and the flavor right? | 18:18 |
| *** tesseract- has quit IRC | 18:19 | |
| sdague | alaski: is the delete case the only issue? | 18:19 |
| alaski | sdague: I believe so | 18:19 |
| dansmith | alaski: this all came about as a solution to our needing to move flavors, but I've lost context on some of that | 18:19 |
| openstackgerrit | Thierry Carrez proposed openstack/nova: Update reno for stable/mitaka https://review.openstack.org/293635 | 18:19 |
| AJaeger | markus_z: updated https://review.openstack.org/#/c/292137, addressed all your suggestions | 18:19 |
| sdague | right, so I think that's probably acceptable casualty to not break some other stuff. If they want the right answer, they can use a microversion. | 18:20 |
| johnthetubaguy | so bigger picture, there could be an "active" flavor thing, where you have image_meta + on boot override + flavor at time of boot | 18:20 |
| *** zenoway has joined #openstack-nova | 18:20 | |
| alaski | dansmith: I don't think we lose the ability to link, or lie about it :), it's really that we lose the ability to link to deleted flavors | 18:20 |
| johnthetubaguy | so flavors could get modified after the instance booted, ish | 18:20 |
| mriedem | alaski: dansmith: because the flavors API today reads soft deleted flavors, | 18:20 |
| mriedem | which goes away with the flavors in the api db | 18:21 |
| dansmith | alaski: mriedem: remember 20 minutes ago when I asked about what was blocking the moving of flavors to the api db and you pointed at this as why? | 18:21 |
| mriedem | which is why thiscame up | 18:21 |
| dansmith | mriedem: ahh, right, that's it | 18:21 |
| mriedem | but we said that api is already broken if you hard delete the flavors | 18:21 |
| alaski | right | 18:21 |
| alaski | right now it sometimes works, in the future it will never work | 18:21 |
| mriedem | so while we have the instance flavor stuff in the instance itself, we said, why not just show that as a subresource on the server | 18:21 |
| johnthetubaguy | which people do when then prune their DB | 18:22 |
| sdague | right, so we can't retroactively fix that issue. We can say, we suggest you use this new version of our API, and things will be better | 18:22 |
| mriedem | johnthetubaguy: right | 18:22 |
| sdague | and I think that's fine | 18:22 |
| mriedem | sdague: +1 | 18:22 |
| sdague | for non deleted flavors, all is still fine | 18:22 |
| sdague | even on the old API | 18:22 |
| dansmith | okay, so I may be wrapping some of this up in resource provider stuff where we lose linkages for non-uuid' things or whatever | 18:22 |
| dansmith | because there are duplicates in places | 18:23 |
| mriedem | my only question is why we can't still provide the link to the flavor sub-resource so we don't have to drop server['flavor']['links'], if we're worried about that | 18:23 |
| mriedem | we just change the lnk | 18:23 |
| mriedem | *link | 18:23 |
| sdague | mriedem: we could, it seems kind of weird | 18:23 |
| dansmith | well, so, my question is this | 18:23 |
| alaski | dansmith: that would affect current v1 users, except that flavors in a cell need to match the api already or other breakages happen so there won't be two different flavors with the same id | 18:23 |
| sdague | mriedem: because "OS-FLV-DISABLED:disabled": false, | 18:23 |
| melwitt | are we saying we want links to deleted flavors after flavors turn to hard deleted? I didn't think we want that | 18:23 |
| sdague | is kind of pointless | 18:24 |
| dansmith | for older clients, are we going to try to maintain the link if the flavor looks like it's still there? | 18:24 |
| mriedem | melwitt: no, that's what we're trying to solve | 18:24 |
| sdague | as is "os-flavor-access:is_public": true, | 18:24 |
| mriedem | dansmith: i suggestd that in the spec too | 18:24 |
| dansmith | okay | 18:24 |
| mriedem | "I think we need to be clear about what we're going to do with the existing part of the server response body that has the flavor in it. FWIW I think we should return it, at least if it still exists." | 18:24 |
| sdague | and I don't think we wanted bookmark links on the subresource | 18:24 |
| *** shaohe_feng has quit IRC | 18:25 | |
| *** ishant has quit IRC | 18:25 | |
| *** akshai has quit IRC | 18:25 | |
| *** shaohe_feng has joined #openstack-nova | 18:26 | |
| dansmith | alaski: so does this really need to block cells stuff if we migrate flavors and maintain the links? soft deleted flavors will appear to have been purged, which they will for anyone before the microversion that adds this anyway | 18:26 |
| jaypipes | so did you guys want to have a high bw discussion about this? | 18:27 |
| mriedem | personally, i want some coffee | 18:28 |
| alaski | dansmith: if we're all okay with that then no it doesn't need to block | 18:28 |
| dansmith | jaypipes: no | 18:28 |
| mriedem | i don't think this is blocking really, i never really did, | 18:28 |
| mriedem | but i think the spec is still useful | 18:28 |
| mriedem | on it's own | 18:28 |
| dansmith | mriedem: except you brought it up as the blocking thing :) | 18:28 |
| alaski | but some people do rely on that so I think we just wanted to not break it knowingly | 18:29 |
| mriedem | dansmith: because we soft blocked it months ago | 18:29 |
| BobBall | dansmith: Looking better? https://review.openstack.org/#/c/293393 | 18:29 |
| alaski | jaypipes: to summarize what I think you're interested in, some of us agree that we should remodel resources and drop them inline on the instance, but not hold up the current proposal if it blocks cells | 18:30 |
| alaski | so do it in two steps rather than either/or | 18:30 |
| openstackgerrit | Mark Doffman proposed openstack/nova-specs: Move aggregates tables to the API database https://review.openstack.org/288084 | 18:30 |
| mriedem | bbiab | 18:30 |
| jaypipes | alaski: and then, what, deprecate the flavors/ subresource from the API some time in the future? | 18:30 |
| alaski | jaypipes: wasn't discussed, but that's what I would want to see | 18:31 |
| jaypipes | alaski: I'd be cool with that. | 18:31 |
| openstackgerrit | John Garbutt proposed openstack/nova: xenapi: Fix when auto block_migration in the API https://review.openstack.org/292937 | 18:32 |
| *** READ10 has quit IRC | 18:32 | |
| dansmith | BobBall: yeah | 18:32 |
| alaski | jaypipes: cool. I think we're all mostly on the same page then | 18:32 |
| jaypipes | alaski: as long as dansmith is happy, I'm happy. | 18:32 |
| dansmith | jaypipes: oh stop it | 18:33 |
| *** akshai has joined #openstack-nova | 18:33 | |
| dansmith | :) | 18:33 |
| * jaypipes giggles | 18:33 | |
| *** pwnall has joined #openstack-nova | 18:33 | |
| BobBall | Awesome. | 18:33 |
| * cfriesen__ is scared | 18:33 | |
| melwitt | alaski: by deprecate the flavors API does that mean just the bookmark part or lose the ability to list flavors etc? | 18:33 |
| jaypipes | cfriesen__: be afraid. be very afraid. :P | 18:33 |
| alaski | melwitt: just the link in the instance view, and subresource of instance. flavors api would remain unchanged | 18:34 |
| melwitt | alaski: gotcha | 18:34 |
| diana_clarke | dansmith: I've been asked to revisit metadata cache performance. Is there anything you think I should know before I dive in? | 18:34 |
| diana_clarke | dansmith: I'm asking because you have -1 & -2 votes on the existing patches, and the launchpad issue is assigned to you. | 18:34 |
| diana_clarke | dansmith: So far, I've reviewed these: http://paste.openstack.org/show/490771/ | 18:34 |
| *** mriedem has quit IRC | 18:35 | |
| *** shaohe_feng has quit IRC | 18:35 | |
| *** shaohe_feng has joined #openstack-nova | 18:36 | |
| *** paul-carlton2 has quit IRC | 18:36 | |
| *** pwnall has quit IRC | 18:36 | |
| dansmith | diana_clarke: back in a bit | 18:37 |
| *** mriedem has joined #openstack-nova | 18:38 | |
| *** rk4n_ has joined #openstack-nova | 18:38 | |
| diana_clarke | dansmith: Thanks, no rush. | 18:39 |
| *** cdent has quit IRC | 18:40 | |
| *** Marga_ has quit IRC | 18:40 | |
| AJaeger | markus_z: no need to backport my change, we only publish from master... It should go into master soonish so that we have great documentation... | 18:40 |
| sdague | johnthetubaguy: are we back to having an open master? | 18:41 |
| *** mylu has quit IRC | 18:41 | |
| johnthetubaguy | sdague: yes | 18:41 |
| johnthetubaguy | sdague: I should send an ML note | 18:41 |
| *** rk4n has quit IRC | 18:42 | |
| sdague | johnthetubaguy: great | 18:43 |
| johnthetubaguy | sdague: so ttx totally beat me to it on the email front | 18:44 |
| johnthetubaguy | sdague: the one thing is we need to block DB migrations till we get the placeholders in | 18:44 |
| sdague | johnthetubaguy: that email should also probably say we can't land db migrations | 18:44 |
| dansmith | johnthetubaguy: I'll send that mail | 18:45 |
| johnthetubaguy | dansmith: OK, cools | 18:45 |
| *** shaohe_feng has quit IRC | 18:45 | |
| *** rlrossit has quit IRC | 18:46 | |
| *** shaohe_feng has joined #openstack-nova | 18:46 | |
| *** BobBall is now known as BobBall_AWOL | 18:47 | |
| *** sfinucan has joined #openstack-nova | 18:47 | |
| *** baoli has joined #openstack-nova | 18:49 | |
| *** fawadkhaliq has quit IRC | 18:49 | |
| openstackgerrit | Mark Doffman proposed openstack/nova-specs: Move networking tables to the API db. https://review.openstack.org/291382 | 18:50 |
| *** mylu has joined #openstack-nova | 18:53 | |
| *** mgoddard_ has quit IRC | 18:54 | |
| *** mgoddard has joined #openstack-nova | 18:54 | |
| *** moshele has joined #openstack-nova | 18:55 | |
| *** shaohe_feng has quit IRC | 18:56 | |
| *** pece has quit IRC | 18:56 | |
| *** shaohe_feng has joined #openstack-nova | 18:56 | |
| *** rlrossit_ has joined #openstack-nova | 18:57 | |
| *** Daisy has joined #openstack-nova | 18:58 | |
| *** haomaiwang has quit IRC | 19:01 | |
| mriedem | sean-k-m1: comments inline https://review.openstack.org/#/c/271444/ | 19:01 |
| *** vishwanathj_chow is now known as vishwanathj | 19:01 | |
| *** haomaiwa_ has joined #openstack-nova | 19:01 | |
| *** Swami has quit IRC | 19:02 | |
| *** claudiub has quit IRC | 19:03 | |
| *** Swami has joined #openstack-nova | 19:03 | |
| *** Daisy has quit IRC | 19:03 | |
| mriedem | edleafe: can you take a look at this bug? confirm it or other? https://bugs.launchpad.net/nova/+bug/1477098 | 19:03 |
| openstack | Launchpad bug 1477098 in OpenStack Compute (nova) "When you unshelve an instance, AggregateImagePropertiesIsolation filter doesn't work." [Undecided,New] | 19:03 |
| mriedem | it's been sitting in New for awhile | 19:03 |
| *** pumarani__ has joined #openstack-nova | 19:03 | |
| *** jichen has joined #openstack-nova | 19:04 | |
| *** harlowja has joined #openstack-nova | 19:04 | |
| mriedem | rlrossit_: did you want to look at this? https://review.openstack.org/#/c/293393/ | 19:04 |
| rlrossit_ | mriedem: is that the one I got thrown under the bus for earlier today? | 19:05 |
| dansmith | diana_clarke: so.. is there a specific question? | 19:05 |
| *** mkrcmari__ has quit IRC | 19:05 | |
| *** wanghao has quit IRC | 19:05 | |
| mriedem | rlrossit_: yes | 19:05 |
| *** shaohe_feng has quit IRC | 19:06 | |
| *** wanghao has joined #openstack-nova | 19:06 | |
| *** shaohe_feng has joined #openstack-nova | 19:07 | |
| *** pushkaru has quit IRC | 19:07 | |
| diana_clarke | dansmith: I get the impression (but I could be wrong), that you think the metadata cache should be fine as-is now that it's not doing a bunch of lazy loads for each request, and that otherwise config-drive should be used. | 19:09 |
| *** sfinucan has quit IRC | 19:10 | |
| dansmith | diana_clarke: well, yes on config drive, because that's our preferred thing as a project | 19:10 |
| dansmith | but yeah, I think the majority of the performance issues with metadata as it was in liberty are probably resolved | 19:10 |
| dansmith | at least, the ones related to the lazy-loads I mean | 19:10 |
| dansmith | I think that not stashing the whole instance in the cache is probably a reasonable change to make, although I wouldn't prioritize it unless there's something compelling | 19:11 |
| *** moshele has quit IRC | 19:12 | |
| *** moshele has joined #openstack-nova | 19:12 | |
| *** cdent has joined #openstack-nova | 19:13 | |
| *** salv-orl_ has quit IRC | 19:15 | |
| *** shaohe_feng has quit IRC | 19:16 | |
| *** shaohe_feng has joined #openstack-nova | 19:17 | |
| *** ssurana has joined #openstack-nova | 19:17 | |
| diana_clarke | dansmith: Okay, I'll start by profiling master (vs liberty) and perhaps increase test coverage if need be. | 19:17 |
| diana_clarke | dansmith: The launchpad ticket is assigned to you. Do you plan on working in this area too? I don't want to get in your way. | 19:18 |
| dansmith | diana_clarke: I didn't assign it to myself, so feel free to take it | 19:19 |
| *** browne has quit IRC | 19:19 | |
| *** ircuser-1 has quit IRC | 19:19 | |
| *** ssurana has quit IRC | 19:22 | |
| *** browne has joined #openstack-nova | 19:22 | |
| *** pece has joined #openstack-nova | 19:25 | |
| *** irenab_ has joined #openstack-nova | 19:26 | |
| *** shaohe_feng has quit IRC | 19:26 | |
| doffm | mriedem, edleafe, bauzas: There is a very good chance that https://bugs.launchpad.net/nova/+bug/1477098 was fixed by the request spec work right? | 19:26 |
| openstack | Launchpad bug 1477098 in OpenStack Compute (nova) "When you unshelve an instance, AggregateImagePropertiesIsolation filter doesn't work." [Undecided,New] | 19:26 |
| *** kro_sniffles is now known as kro_mnckn_doc | 19:27 | |
| *** shaohe_feng has joined #openstack-nova | 19:27 | |
| *** irenab has quit IRC | 19:28 | |
| *** irenab_ is now known as irenab | 19:28 | |
| *** daemontool has quit IRC | 19:28 | |
| *** eliqiao has quit IRC | 19:29 | |
| *** eliqiao has joined #openstack-nova | 19:29 | |
| *** akshai has quit IRC | 19:30 | |
| *** yamahata has quit IRC | 19:34 | |
| *** ociuhandu has quit IRC | 19:35 | |
| *** Marga_ has joined #openstack-nova | 19:36 | |
| *** mylu has quit IRC | 19:36 | |
| *** shaohe_feng has quit IRC | 19:37 | |
| *** shaohe_feng has joined #openstack-nova | 19:37 | |
| *** akshai has joined #openstack-nova | 19:39 | |
| *** moshele has quit IRC | 19:39 | |
| *** mylu has joined #openstack-nova | 19:41 | |
| *** browne has quit IRC | 19:42 | |
| *** gjayavelu has quit IRC | 19:43 | |
| *** ssurana has joined #openstack-nova | 19:45 | |
| dansmith | melwitt: wanna +W this? https://review.openstack.org/#/c/289449 | 19:45 |
| dansmith | needs to land firstly in newton now that it's open | 19:45 |
| dansmith | the newton PTL has already +2d | 19:45 |
| melwitt | on it | 19:46 |
| dansmith | thanks | 19:46 |
| *** e0ne has joined #openstack-nova | 19:46 | |
| *** harlowja has quit IRC | 19:46 | |
| *** shaohe_feng has quit IRC | 19:47 | |
| *** gjayavelu has joined #openstack-nova | 19:48 | |
| *** shaohe_feng has joined #openstack-nova | 19:48 | |
| melwitt | dansmith: actually, shouldn't it be range(320, 330) in https://review.openstack.org/#/c/289449/4/nova/tests/unit/db/test_migrations.py ? | 19:52 |
| dansmith | gdi | 19:53 |
| dansmith | because rebase | 19:53 |
| melwitt | yeah | 19:54 |
| *** ig0r_ has quit IRC | 19:55 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Add placeholder migrations for Mitaka backports https://review.openstack.org/289449 | 19:55 |
| openstackgerrit | Dan Smith proposed openstack/nova: Add Newton sanity check migration https://review.openstack.org/289450 | 19:55 |
| dansmith | I actually want to make that test file able to ignore _placeholder migrations so we don't have to do this error-prone thing | 19:55 |
| melwitt | ah, yeah | 19:55 |
| *** ociuhandu has joined #openstack-nova | 19:56 | |
| *** shaohe_feng has quit IRC | 19:57 | |
| *** shaohe_feng has joined #openstack-nova | 19:58 | |
| openstackgerrit | jichenjc proposed openstack/nova: Change REGEX for instance display name filter https://review.openstack.org/282190 | 19:58 |
| *** sfinucan has joined #openstack-nova | 19:58 | |
| *** ericksonsantos has joined #openstack-nova | 19:58 | |
| melwitt | mriedem: we had to respin https://review.openstack.org/289449 because of the unit test if you want to take a look ^ | 19:59 |
| mriedem | i'm looking | 19:59 |
| *** haomaiwa_ has quit IRC | 20:01 | |
| *** moshele has joined #openstack-nova | 20:01 | |
| *** haomaiwang has joined #openstack-nova | 20:01 | |
| *** salv-orlando has joined #openstack-nova | 20:01 | |
| *** claudiub has joined #openstack-nova | 20:03 | |
| *** gjayavelu has quit IRC | 20:04 | |
| *** claudiub|2 has joined #openstack-nova | 20:05 | |
| *** sfinucan has quit IRC | 20:06 | |
| *** rk4n_ has quit IRC | 20:06 | |
| *** gjayavelu has joined #openstack-nova | 20:06 | |
| *** fhermeni has joined #openstack-nova | 20:07 | |
| fhermeni | hi | 20:07 |
| *** shaohe_feng has quit IRC | 20:07 | |
| *** shaohe_feng has joined #openstack-nova | 20:08 | |
| *** claudiub has quit IRC | 20:08 | |
| openstackgerrit | Joe Cropper proposed openstack/nova: Add get_host_memory_stats virt driver API https://review.openstack.org/288838 | 20:09 |
| openstackgerrit | Joe Cropper proposed openstack/nova: Add memory metric monitor https://review.openstack.org/288848 | 20:09 |
| *** moshele has quit IRC | 20:10 | |
| mriedem | doffm: https://review.openstack.org/#/c/266425/ | 20:10 |
| *** pc_m has joined #openstack-nova | 20:12 | |
| *** smatzek has quit IRC | 20:13 | |
| *** cdent has quit IRC | 20:15 | |
| mriedem | jaypipes: i'm cleaning up old specs so dropped https://review.openstack.org/#/c/137669/ just fyi | 20:16 |
| mriedem | it's not personal :) | 20:16 |
| mriedem | rlrossit_: gibi: you might be interested in https://review.openstack.org/#/c/137669/ | 20:16 |
| jaypipes | mriedem: np :) | 20:16 |
| mriedem | mordred: are you planning on pursuing this? https://review.openstack.org/#/c/167202/ | 20:17 |
| *** AJaeger has left #openstack-nova | 20:17 | |
| *** shaohe_feng has quit IRC | 20:18 | |
| *** penick has joined #openstack-nova | 20:18 | |
| *** shaohe_feng has joined #openstack-nova | 20:18 | |
| *** ssurana has quit IRC | 20:19 | |
| *** mylu has quit IRC | 20:19 | |
| *** rtheis has quit IRC | 20:20 | |
| *** mylu has joined #openstack-nova | 20:20 | |
| mriedem | alaski: should we pursue this? https://review.openstack.org/#/c/182445/ or is anyone else planning on working on quotas? | 20:22 |
| mriedem | i saw the quota service/lib ML explosion this morning | 20:22 |
| *** ssurana has joined #openstack-nova | 20:22 | |
| alaski | I am not planning on working on that for now. someone mentioned ccarmack might be interested in it and if not I'll abandon | 20:23 |
| mriedem | i was just going to call out ccarm | 20:24 |
| mriedem | ccarmack: | 20:24 |
| ccarmack | I thought we were investigating root causes of quota out-of-sync | 20:24 |
| melwitt | yeah, we had a quick chat here about quotas the other day and I think ccarmack and doffm had some interest in working on getting some functional tests together to get us a real baseline on what quotas are doing as we go toward a design | 20:25 |
| ccarmack | melwitt had an etherpad for that | 20:25 |
| ccarmack | melwitt: yes that's right | 20:25 |
| mriedem | https://etherpad.openstack.org/p/nova-quotas | 20:25 |
| melwitt | yeah, was grabbing the link. I added it to the quotas subteam section of the priorities etherpad to help capture the work and ideas as we go | 20:26 |
| mriedem | i'll hook that back into the review etherpad | 20:26 |
| mriedem | melwitt: ahh good | 20:26 |
| alaski | that would indicate the spec is early at this point so I can abandon until testing/research is done | 20:26 |
| *** sbezverk has quit IRC | 20:26 | |
| melwitt | we kept talking about it on ML etc about how we don't *really* know what's going on with quotas right now and it would be good to know that and also be able to test new designs and it would help prioritize any such quota work | 20:27 |
| ccarmack | mriedem: so I'm ok with abadon with "quotas reimagined" | 20:27 |
| mriedem | yeah, agree on abandoning that until we have some functional tests | 20:28 |
| *** shaohe_feng has quit IRC | 20:28 | |
| *** shaohe_feng has joined #openstack-nova | 20:28 | |
| *** penick has quit IRC | 20:29 | |
| alaski | done | 20:30 |
| *** toure_ is now known as toure | 20:30 | |
| *** baoli has quit IRC | 20:32 | |
| *** diogogmt has joined #openstack-nova | 20:33 | |
| *** penick has joined #openstack-nova | 20:33 | |
| *** ircuser-1 has joined #openstack-nova | 20:33 | |
| *** shaohe_feng has quit IRC | 20:38 | |
| *** shaohe_feng has joined #openstack-nova | 20:39 | |
| *** andymaier has quit IRC | 20:41 | |
| openstackgerrit | Mark Doffman proposed openstack/nova: Add database tables to CellsV2 database split docs https://review.openstack.org/277543 | 20:44 |
| *** lpetrut has quit IRC | 20:44 | |
| bauzas | alaski: melwitt: sorry, I was out tonight | 20:46 |
| bauzas | so I missed the cells v2 meeting | 20:46 |
| alaski | bauzas: no worries. as always it just means you've volunteered for everything | 20:46 |
| *** shaohe_feng has quit IRC | 20:48 | |
| *** ianw has joined #openstack-nova | 20:48 | |
| *** cleong has quit IRC | 20:50 | |
| *** shaohe_feng has joined #openstack-nova | 20:50 | |
| mriedem | easy +W for specs core https://review.openstack.org/#/c/248142/ | 20:52 |
| *** aysyd has quit IRC | 20:52 | |
| *** mylu has quit IRC | 20:53 | |
| *** zhenq has quit IRC | 20:57 | |
| *** zhenq has joined #openstack-nova | 20:57 | |
| *** e0ne has quit IRC | 20:58 | |
| *** shaohe_feng has quit IRC | 20:59 | |
| *** shaohe_feng has joined #openstack-nova | 20:59 | |
| *** pumarani__ has quit IRC | 21:00 | |
| *** woodster_ has joined #openstack-nova | 21:00 | |
| *** thorst has quit IRC | 21:01 | |
| *** haomaiwang has quit IRC | 21:01 | |
| *** haomaiwa_ has joined #openstack-nova | 21:01 | |
| *** vilobhmm11 has quit IRC | 21:02 | |
| *** vilobhmm11 has joined #openstack-nova | 21:02 | |
| *** thorst has joined #openstack-nova | 21:03 | |
| *** vilobhmm11 has quit IRC | 21:03 | |
| *** vilobhmm11 has joined #openstack-nova | 21:03 | |
| *** pushkaru has joined #openstack-nova | 21:04 | |
| *** achanda has joined #openstack-nova | 21:05 | |
| *** penick has quit IRC | 21:05 | |
| *** READ10 has joined #openstack-nova | 21:07 | |
| *** thorst has quit IRC | 21:07 | |
| openstackgerrit | jichenjc proposed openstack/nova: WIP: add regression test for 1546396 https://review.openstack.org/293709 | 21:08 |
| *** toure is now known as toure_ | 21:08 | |
| openstackgerrit | Sean Dague proposed openstack/nova: WIP: attempt to parse content inside table cells https://review.openstack.org/293710 | 21:09 |
| *** shaohe_feng has quit IRC | 21:09 | |
| *** shaohe_feng has joined #openstack-nova | 21:09 | |
| mriedem | nova specs dashboard if anyone wants one http://tinyurl.com/hjhu75e | 21:10 |
| *** doug-fish has quit IRC | 21:11 | |
| *** doug-fish has joined #openstack-nova | 21:12 | |
| auggy | can i get a dashboard of dashboards in my dashboard? | 21:12 |
| *** Daisy has joined #openstack-nova | 21:14 | |
| *** toure_ is now known as toure | 21:14 | |
| *** rfolco has quit IRC | 21:14 | |
| *** browne has joined #openstack-nova | 21:16 | |
| *** rlrossit_ has quit IRC | 21:17 | |
| melwitt | mriedem: nice, added it to My Menu | 21:18 |
| mriedem | one thing i don't get is i +2ed https://review.openstack.org/#/c/284633/ and now it doesn't show up in my dashboard | 21:18 |
| *** Daisy has quit IRC | 21:18 | |
| mriedem | oh i suppose b/c i +2ed it so i don't need to see it now | 21:19 |
| *** kro_mnckn_doc has quit IRC | 21:19 | |
| *** shaohe_feng has quit IRC | 21:19 | |
| *** anteaya has quit IRC | 21:19 | |
| *** samueldmq has quit IRC | 21:19 | |
| *** shaohe_feng has joined #openstack-nova | 21:20 | |
| *** mdrabe has quit IRC | 21:23 | |
| *** achanda has quit IRC | 21:24 | |
| *** gjayavelu has quit IRC | 21:24 | |
| *** nickchase has joined #openstack-nova | 21:25 | |
| dansmith | melwitt: so what is the state of db and mq connection switching? | 21:27 |
| *** achanda has joined #openstack-nova | 21:28 | |
| *** rdopiera has quit IRC | 21:28 | |
| *** shaohe_feng has quit IRC | 21:29 | |
| *** shaohe_feng has joined #openstack-nova | 21:30 | |
| *** eharney has quit IRC | 21:30 | |
| *** darrenc is now known as darren_afk | 21:31 | |
| *** vilobhmm11 has quit IRC | 21:32 | |
| alaski | dansmith: db switching merged, though nothing is using it | 21:32 |
| *** pradk has quit IRC | 21:32 | |
| *** vilobhmm11 has joined #openstack-nova | 21:32 | |
| *** jichen has quit IRC | 21:33 | |
| *** knikolla has quit IRC | 21:34 | |
| dansmith | alaski: okay I thought so | 21:35 |
| dansmith | alaski: and the actual flavor migration is still pending somewhere? | 21:35 |
| melwitt | dansmith: also I have a WIP patch up for the mq connection switching https://review.openstack.org/#/c/274955/ where I tested it locally with only build_and_run_instance and so far so good | 21:35 |
| *** gjayavelu has joined #openstack-nova | 21:35 | |
| *** achanda has quit IRC | 21:36 | |
| melwitt | it needs a rebase and more work | 21:36 |
| dansmith | okay | 21:36 |
| alaski | dansmith: https://review.openstack.org/#/c/213041/ | 21:36 |
| *** e0ne has joined #openstack-nova | 21:37 | |
| dansmith | alaski: okay I thought the code was owned by someone else.. did it shift? | 21:37 |
| alaski | not that I know of. But someone else may need to take over. I need to reach out to CERN to see what sort of involvement they'll have this cycle | 21:38 |
| dansmith | well, I was wondering if I should just ask to take it over | 21:39 |
| dansmith | since I have a history of screwing up, er, pulling off, these things | 21:39 |
| alaski | yeah, you should definitely see about taking over | 21:39 |
| melwitt | +1 | 21:39 |
| *** shaohe_feng has quit IRC | 21:40 | |
| *** e0ne has quit IRC | 21:40 | |
| dansmith | I feel like alaski just said "you should definitely see about getting kicked in the nuts" | 21:40 |
| melwitt | lol | 21:40 |
| *** shaohe_feng has joined #openstack-nova | 21:41 | |
| alaski | pretty much, though you did basically volunteer for it | 21:41 |
| *** nickchase has quit IRC | 21:41 | |
| melwitt | hey, you said something crazy and we're like...roll with it! | 21:41 |
| alaski | I mean if that's what you're into who's to judge | 21:42 |
| dansmith | alaski: I am into some kinky shit | 21:43 |
| bauzas | eh, nice, RC1 is on the shelf | 21:44 |
| *** ccarmack has left #openstack-nova | 21:44 | |
| *** matrohon has quit IRC | 21:45 | |
| *** darren_afk is now known as darrenc | 21:46 | |
| *** achanda has joined #openstack-nova | 21:47 | |
| alaski | dansmith: we all know you're a masochist for taking on the online migration instance_extra thing, among other horrible projects | 21:48 |
| dansmith | alaski: I still have nightmares | 21:48 |
| melwitt | is something afoot with the py34 job? https://review.openstack.org/#/c/289449/ failed it | 21:49 |
| melwitt | build time out | 21:49 |
| *** permalac has quit IRC | 21:50 | |
| *** shaohe_feng has quit IRC | 21:50 | |
| dansmith | melwitt: I give that afoot usage a 5/10.. weak justification | 21:50 |
| dansmith | and yes | 21:50 |
| dansmith | there is a thread on the list | 21:50 |
| melwitt | argh! | 21:50 |
| *** shaohe_feng has joined #openstack-nova | 21:51 | |
| dansmith | melwitt: alaski: so, this patch is not something we can merge right now because it assumes flavors are all migrated when they're not | 21:51 |
| bauzas | oh man, that deprecation warning for nova.rpc is terrible for the logs :p | 21:51 |
| mriedem | melwitt: see cdent's eventlet + py34 thread | 21:53 |
| melwitt | dansmith: the placeholders? | 21:53 |
| *** kfarr has quit IRC | 21:53 | |
| dansmith | melwitt: no the flavors patch | 21:54 |
| alaski | dansmith: it's migrating the flavors right? | 21:54 |
| *** MVenesio has quit IRC | 21:54 | |
| dansmith | alaski: FlavorList.get_all() assumes they're all in the api_db, AFAIC | 21:55 |
| dansmith | T | 21:55 |
| melwitt | dansmith: the one we were just talking about with active migration? it intends to online migrate flavors but there are problems in it | 21:55 |
| dansmith | I don't think it does intend to do that | 21:55 |
| *** alex_xu has quit IRC | 21:56 | |
| dansmith | except maybe by saying "this intends to migrate live" | 21:56 |
| alaski | I think it's the intent, though the implementation may not back that up | 21:56 |
| *** mriedem has quit IRC | 21:57 | |
| melwitt | yeah live migrate flavors. it does things like try lookup in api db, if not found, get it from main db, then only write to api db. that sort of thing | 21:57 |
| *** ctrath1 has quit IRC | 21:58 | |
| *** alex_xu has joined #openstack-nova | 21:58 | |
| dansmith | melwitt: I don't think so | 21:59 |
| melwitt | I wrote a lot of comments in there | 21:59 |
| dansmith | at least, not across the board | 21:59 |
| melwitt | right. I wrote comments about the gaps I saw | 21:59 |
| dansmith | okay | 22:00 |
| *** shaohe_feng has quit IRC | 22:00 | |
| *** haomaiwa_ has quit IRC | 22:01 | |
| melwitt | namely L713 https://review.openstack.org/#/c/213041/24/nova/objects/flavor.py | 22:01 |
| *** shaohe_feng has joined #openstack-nova | 22:01 | |
| *** haomaiwang has joined #openstack-nova | 22:01 | |
| dansmith | alaski: melwitt: and your thought is that we take advantage of some cycle in which we can only ever have a cell of one to do the migration lively, knowing we can easily connect to both databases and not need to iterate over N cells? | 22:01 |
| * dansmith is already starting to regret volunteering for this | 22:02 | |
| melwitt | too late! | 22:02 |
| alaski | hah | 22:02 |
| alaski | dansmith: yes. even in a multiple cells case all cells must match flavors so it shouldn't matter, but we assume a cell of one for now | 22:03 |
| dansmith | alaski: how many flavors at RAX? can you tell me in public? | 22:03 |
| *** boden has quit IRC | 22:03 | |
| alaski | tbh I don't know, but they're all in the public listing. maybe 30 or so? | 22:03 |
| dansmith | seriously? that's it? | 22:04 |
| alaski | yeah, nothing too crazy | 22:04 |
| *** vilobhmm111 has joined #openstack-nova | 22:04 | |
| dansmith | so I mean | 22:04 |
| melwitt | that's an order of magnitude lower than I expected | 22:04 |
| dansmith | if we're talking about 30ish flavors, it's almost worth something kinda crazy to just migrate the whole she'bang in one go | 22:05 |
| dansmith | also, | 22:05 |
| dansmith | correct me if I'm wrong, but shouldn't we nearly be able to reuse all the existing db machinery and control what we're talking to just with the db connection in the context? | 22:05 |
| *** alex_xu has quit IRC | 22:06 | |
| *** vilobhmm11 has quit IRC | 22:06 | |
| alaski | there were slight changes in the model so I don't think that'll work | 22:07 |
| dansmith | okay and we've already got the tables in the api db I guess? | 22:07 |
| alaski | I do think it's worth looking at doing it in one go, but who knows what crazy flavor explosion someone has created for themselves | 22:08 |
| alaski | dansmith: yes | 22:08 |
| *** rfolco has joined #openstack-nova | 22:08 | |
| dansmith | yeah, I know IBM was auto-creating flavors by the pantload at one point | 22:08 |
| *** davideagnello has quit IRC | 22:08 | |
| *** davideagnello has joined #openstack-nova | 22:09 | |
| *** alex_xu has joined #openstack-nova | 22:09 | |
| alaski | it should still be a quick migration, but we sort of set the precedent of doing everything online at this point | 22:10 |
| dansmith | alaski: so flavor has hardly ever changed. I wonder if it might be easier to set the current flavor aside and build a new flavor class at the current version or something | 22:10 |
| *** shaohe_feng has quit IRC | 22:10 | |
| dansmith | alaski: I didn't mean do it offline ahead of time | 22:10 |
| melwitt | I also know of a case where there are a lot of flavors in a deployment | 22:10 |
| alaski | dansmith: ahh, gotcha | 22:11 |
| dansmith | I meant something online that just says "I'm your huckleberry" and just takes the bullet for the cloud and does the migration | 22:11 |
| *** rfolco has quit IRC | 22:11 | |
| alaski | dansmith: I would support building a new flavor | 22:11 |
| dansmith | actual doc quote optional | 22:11 |
| alaski | dansmith: +3 for Tombstone reference | 22:11 |
| melwitt | haha, nice | 22:11 |
| *** pushkaru has quit IRC | 22:12 | |
| dansmith | if matt is going to be ptl, he's going to be a lot less fun, so someone has to do it | 22:12 |
| alaski | I'm onboard with both of those ideas | 22:12 |
| alaski | heh, you need to be quick with the youtube links though | 22:12 |
| alaski | dinner has arrived, gotta run | 22:13 |
| dansmith | nobody commented on my final countdown link above | 22:13 |
| alaski | :( | 22:14 |
| * alaski actually goes | 22:14 | |
| melwitt | I didn't see a final countdown link | 22:14 |
| *** pcm_ has joined #openstack-nova | 22:14 | |
| *** mattymo_ has joined #openstack-nova | 22:15 | |
| *** shaohe_feng_ has joined #openstack-nova | 22:16 | |
| *** mattymo has quit IRC | 22:16 | |
| *** pc_m has quit IRC | 22:16 | |
| *** dims_ has joined #openstack-nova | 22:16 | |
| *** shaohe_feng_ is now known as shaohe_feng | 22:16 | |
| *** erlon has quit IRC | 22:17 | |
| *** geekinutah has quit IRC | 22:17 | |
| auggy | dansmith: sorry, i was late to the game when i saw it but i appreciated it :D | 22:17 |
| dansmith | heh | 22:17 |
| auggy | this was pretty epic, I totally saw it - https://www.youtube.com/watch?v=Y8RekdmX7UA | 22:18 |
| *** dims has quit IRC | 22:18 | |
| auggy | seeing that show made me want to learn to play the keytar | 22:19 |
| *** fhermeni has quit IRC | 22:20 | |
| *** yamahata has joined #openstack-nova | 22:20 | |
| *** shaohe_feng has quit IRC | 22:21 | |
| *** shaohe_feng has joined #openstack-nova | 22:21 | |
| *** vilobhmm111 has quit IRC | 22:22 | |
| *** vilobhmm11 has joined #openstack-nova | 22:23 | |
| jaypipes | mmm, my deck82 just arrived. | 22:23 |
| auggy | ooh fancy :) I use a HHKB | 22:26 |
| auggy | i like the clackity clackity key sounds | 22:26 |
| jaypipes | indeed | 22:27 |
| jaypipes | ^ typed on my deck82 ;) | 22:27 |
| auggy | hehe | 22:29 |
| melwitt | dansmith: to your earlier question, the db connection in the context is only for main dbs, not the api db. unless you set the attr in the context to be the api db connection | 22:29 |
| dansmith | melwitt: okay, well, the models differ a little anyway, so.. | 22:30 |
| melwitt | okay | 22:31 |
| *** shaohe_feng has quit IRC | 22:31 | |
| *** nic has left #openstack-nova | 22:31 | |
| *** nic has joined #openstack-nova | 22:31 | |
| *** shaohe_feng has joined #openstack-nova | 22:32 | |
| *** READ10 has quit IRC | 22:33 | |
| *** penick has joined #openstack-nova | 22:34 | |
| *** busterswt has quit IRC | 22:34 | |
| *** pushkaru has joined #openstack-nova | 22:35 | |
| dansmith | manmelso | 22:35 |
| dansmith | wow | 22:35 |
| dansmith | no idea what that was | 22:35 |
| dansmith | melwitt: what would you think about making the migration happen only on save(), | 22:35 |
| melwitt | lol | 22:36 |
| *** penick has quit IRC | 22:36 | |
| dansmith | and make save (a) write the new thing to do the api database and delete the thing from the original database before it returns/commits the transaction | 22:36 |
| dansmith | then, | 22:36 |
| dansmith | we could make all the get commands look in the old db first, which means they might see an old flavor briefly if they race with the update | 22:37 |
| dansmith | but that's okay because eventual consistency | 22:37 |
| dansmith | and then we can cache the flavors we've looked for and not found in the old db, so we don't look there anymore, | 22:37 |
| dansmith | with some per-process startup flag of "are there any flavors in the old db" flag to know if we even need to check anymore | 22:37 |
| dansmith | quickly that flag will be False and we remove it in O | 22:38 |
| dansmith | hmm, there was no (b) in there | 22:38 |
| melwitt | :) | 22:38 |
| melwitt | makes sense to me. I like the idea of migrating on save only | 22:39 |
| dansmith | okay | 22:40 |
| *** penick has joined #openstack-nova | 22:40 | |
| *** shaohe_feng has quit IRC | 22:41 | |
| *** shaohe_feng has joined #openstack-nova | 22:42 | |
| melwitt | dansmith: startup flag will just do a sweep to see if it gets anything for a flavor get all? | 22:43 |
| *** edmondsw has quit IRC | 22:43 | |
| dansmith | melwitt: just a SELECT count() FROM flavors | 22:44 |
| dansmith | which should be super fast | 22:44 |
| *** pumarani__ has joined #openstack-nova | 22:45 | |
| melwitt | dansmith: much better. that knows to ignore the soft deleted ones then | 22:46 |
| *** doug-fis_ has joined #openstack-nova | 22:47 | |
| *** pushkaru has quit IRC | 22:47 | |
| *** yamahata has quit IRC | 22:48 | |
| *** ivase has quit IRC | 22:48 | |
| melwitt | or you just have the read_deleted='no'. anyway | 22:49 |
| *** ivase has joined #openstack-nova | 22:49 | |
| *** Jeffrey4l has joined #openstack-nova | 22:49 | |
| dansmith | oh god | 22:50 |
| dansmith | lots of conflicts | 22:50 |
| *** doug-fish has quit IRC | 22:50 | |
| melwitt | :( | 22:51 |
| *** doug-fis_ has quit IRC | 22:51 | |
| *** shaohe_feng has quit IRC | 22:51 | |
| *** shaohe_feng has joined #openstack-nova | 22:52 | |
| *** xyang1 has quit IRC | 22:52 | |
| dansmith | melwitt: okay, you can have this one and I'll go find something else | 22:55 |
| melwitt | haha! | 22:56 |
| * melwitt runs for the hills | 22:56 | |
| *** yamahata has joined #openstack-nova | 22:57 | |
| *** mriedem has joined #openstack-nova | 22:57 | |
| *** jwcroppe has quit IRC | 22:59 | |
| *** pushkaru has joined #openstack-nova | 22:59 | |
| *** jwcroppe has joined #openstack-nova | 22:59 | |
| alaski | dansmith: if you're just migrating on save() I assume you're planning some task to go through and save() each flavor? | 23:00 |
| *** haomaiwang has quit IRC | 23:01 | |
| dansmith | alaski: sure, just like we have for the other migrations | 23:01 |
| dansmith | alaski: you saw the generic command on nova-migrate we have now right? | 23:01 |
| alaski | yeah | 23:01 |
| *** haomaiwa_ has joined #openstack-nova | 23:01 | |
| *** shaohe_feng has quit IRC | 23:02 | |
| alaski | flavors aren't saved that much compared to other objects so something like that would be needed | 23:02 |
| *** karlamrhein has joined #openstack-nova | 23:02 | |
| dansmith | yeah | 23:02 |
| dansmith | alaski: you saw my half baked idea above then? | 23:02 |
| alaski | yep | 23:02 |
| *** davideagnello has quit IRC | 23:02 | |
| *** pumarani__ has quit IRC | 23:02 | |
| * dansmith waits for alaski to make poop on it | 23:03 | |
| *** shaohe_feng has joined #openstack-nova | 23:03 | |
| alaski | I think my only question is why look for flavors in the old db first? | 23:03 |
| *** davideagnello has joined #openstack-nova | 23:04 | |
| *** pushkaru has quit IRC | 23:04 | |
| alaski | if you look in the api db first you don't need a flag to know when to switch | 23:04 |
| dansmith | alaski: well, I was thinking it would help in the case where you might need to abort | 23:04 |
| *** jwcroppe has quit IRC | 23:04 | |
| *** pushkaru has joined #openstack-nova | 23:04 | |
| dansmith | alaski: so, you'd never look in the new db unless it was missing from the old one, which means it's already written fully to the new one | 23:05 |
| dansmith | because the thing was brought up about having half-written the projects but not the flavor or whatever | 23:05 |
| dansmith | but maybe that's silly | 23:05 |
| *** vishwanathj has quit IRC | 23:06 | |
| alaski | I guess it depends on the complexity of writing the flavor and all it's associated rows atomically | 23:06 |
| dansmith | I guess if you can write the whole thing, flavor, projects, extra_specs in one transaction and make sure it lands, then it's okay | 23:06 |
| alaski | yeah | 23:07 |
| dansmith | I was just thinking that we kinda need atomicity over two databases, | 23:07 |
| dansmith | and while something could be half-created, it's easy to make sure it's deleted | 23:07 |
| alaski | if you write to the api db first and only delete when done I think that could be two transactions | 23:08 |
| alaski | but we would have to ensure it can't be half created | 23:08 |
| alaski | I'm fine either way, just asking really | 23:08 |
| dansmith | sure, across the two, but depends on .. yeah, atomic create in the api | 23:08 |
| *** yassine__ has quit IRC | 23:08 | |
| alaski | looking up in the cell and then slowly switching to the api db is surely easier than going the other way | 23:09 |
| alaski | with just the cost of a flag | 23:09 |
| * alaski alaski hovered but did not poop on the idea | 23:10 | |
| melwitt | LOL | 23:10 |
| dansmith | well, I think it's less complex to hit the api db first, | 23:10 |
| dansmith | assuming the create is atomic | 23:11 |
| dansmith | anyway, whatever | 23:11 |
| dansmith | I think we should migrate on save() | 23:11 |
| alaski | +1 | 23:11 |
| *** krotscheck has joined #openstack-nova | 23:11 | |
| dansmith | take the hit there, which is infrequent and likely to be done completely by the task anyway | 23:11 |
| dansmith | and optimize for it being done quickly | 23:11 |
| dansmith | in fact, | 23:11 |
| dansmith | you could also argue that the only thing we should do is: | 23:11 |
| dansmith | create in new db | 23:12 |
| dansmith | check first in new, fallback to old when getting via id | 23:12 |
| *** shaohe_feng has quit IRC | 23:12 | |
| dansmith | and only migrate from the tool | 23:12 |
| alaski | right, that's what I was thinking originally | 23:12 |
| dansmith | I guess the deal is you could technically race with some update | 23:12 |
| dansmith | but it's also probably reasonable to expect that admins could not update flavors for a minute while they run their tool | 23:13 |
| *** shaohe_feng has joined #openstack-nova | 23:13 | |
| alaski | yeah | 23:14 |
| *** sdague has quit IRC | 23:14 | |
| dansmith | even with 300 flavors, you should be able to do that in nearly zero time | 23:14 |
| alaski | agreed. it's not much data | 23:14 |
| *** dimtruck is now known as zz_dimtruck | 23:15 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Flavor object which support both DB with active migration https://review.openstack.org/213041 | 23:15 |
| openstackgerrit | Dan Smith proposed openstack/nova: Use the api database fixture in tests https://review.openstack.org/293758 | 23:15 |
| dansmith | I rebased that, addressed a couple of the nits and split out the test base change ^ | 23:16 |
| alaski | awesome. I'm heading out for the evening but I'll take a look in the morning | 23:17 |
| melwitt | dansmith: I just -1 the test change, that patch goes way back to before it already got added to the base test case | 23:17 |
| dansmith | recess approved | 23:17 |
| dansmith | oh is it already there? | 23:17 |
| melwitt | that sentence barely made sense. it is now. it wasn't when this patch first started | 23:18 |
| *** zenoway has quit IRC | 23:18 | |
| *** yamahata has quit IRC | 23:18 | |
| dansmith | ah I see it | 23:18 |
| dansmith | it didn't conflict and I didn't see it in the immediate vicinity | 23:19 |
| *** fawadkhaliq has joined #openstack-nova | 23:19 | |
| *** gjayavelu has quit IRC | 23:19 | |
| dansmith | cool, one more thing out of that mondo patch | 23:19 |
| openstackgerrit | Dan Smith proposed openstack/nova: Flavor object which support both DB with active migration https://review.openstack.org/213041 | 23:19 |
| melwitt | yeah, it got caught up in the mix. I just realized it immediately when I saw the patch subject line | 23:19 |
| *** samueldmq has joined #openstack-nova | 23:20 | |
| mriedem | hmm, melwitt: dansmith: that bp was marked complete https://blueprints.launchpad.net/openstack/nova/+spec/flavor-cell-api | 23:21 |
| dansmith | also, if we delete from the old db when we're done, we don't need to do much for the union operation I think | 23:21 |
| *** anteaya has joined #openstack-nova | 23:21 | |
| dansmith | mriedem: lol, very much not complete | 23:21 |
| mriedem | yeah | 23:21 |
| mriedem | i'm going to re-open and then we need to re-propose the spec for newton | 23:22 |
| dansmith | yeah | 23:22 |
| melwitt | hm, that's odd | 23:22 |
| *** shaohe_feng has quit IRC | 23:22 | |
| mriedem | dansmith: should i assign the bp to you now? | 23:22 |
| *** shaohe_feng has joined #openstack-nova | 23:23 | |
| melwitt | ohh, I see the title was renamed to "(partial)" | 23:23 |
| dansmith | mriedem: I dunno, I asked the person if I could steal it from them, but no answer in the last 45 minutes :) | 23:23 |
| melwitt | so I guess johnthetubaguy was thinking to open a new one for the remainder of the work? | 23:24 |
| mriedem | well, the spec still points at this bp, | 23:24 |
| mriedem | and the spec has to be re-proposed | 23:24 |
| *** akshai has quit IRC | 23:24 | |
| mriedem | so i think we're ok with just keeping this one, please i just re-opened it | 23:24 |
| *** karlamrhein has quit IRC | 23:25 | |
| melwitt | :P | 23:26 |
| mriedem | s/please/plus/ | 23:26 |
| *** shaohe_feng has quit IRC | 23:32 | |
| *** shaohe_feng has joined #openstack-nova | 23:33 | |
| *** nic has quit IRC | 23:34 | |
| *** rook-lappy has joined #openstack-nova | 23:34 | |
| *** mriedem1 has joined #openstack-nova | 23:35 | |
| *** achanda has quit IRC | 23:36 | |
| *** mriedem has quit IRC | 23:37 | |
| *** vilobhmm11 has quit IRC | 23:37 | |
| *** diogogmt has quit IRC | 23:38 | |
| *** vilobhmm11 has joined #openstack-nova | 23:38 | |
| *** tjones_zzzz has left #openstack-nova | 23:39 | |
| *** pushkaru has quit IRC | 23:40 | |
| *** ducttape_ has joined #openstack-nova | 23:41 | |
| *** shaohe_feng has quit IRC | 23:43 | |
| *** doug-fish has joined #openstack-nova | 23:43 | |
| *** shaohe_feng has joined #openstack-nova | 23:43 | |
| *** pece has quit IRC | 23:44 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs: Re-propose: Add Flavor tables to API Database https://review.openstack.org/293761 | 23:44 |
| *** jwcroppe has joined #openstack-nova | 23:44 | |
| *** mylu has joined #openstack-nova | 23:44 | |
| *** ducttape_ has quit IRC | 23:47 | |
| *** eil397 has quit IRC | 23:49 | |
| *** vilobhmm11 has quit IRC | 23:53 | |
| *** shaohe_feng has quit IRC | 23:53 | |
| *** mylu has quit IRC | 23:53 | |
| *** salv-orl_ has joined #openstack-nova | 23:54 | |
| *** shaohe_feng has joined #openstack-nova | 23:54 | |
| *** MVenesio has joined #openstack-nova | 23:55 | |
| *** salv-orlando has quit IRC | 23:57 | |
| *** penick has quit IRC | 23:57 | |
| *** MVenesio has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!