Tuesday, 2016-06-14

*** ihrachys has joined #openstack-nova00:01
openstackgerritClaudiu Belu proposed openstack/nova: policy: Add defaults in code (part 2)  https://review.openstack.org/32885100:04
openstackgerritClaudiu Belu proposed openstack/nova: policy: Add defaults in code (part 1)  https://review.openstack.org/32885000:04
openstackgerritClaudiu Belu proposed openstack/nova: policy: Add defaults in code (part 3)  https://review.openstack.org/32922700:04
openstackgerritClaudiu Belu proposed openstack/nova: policy: Add defaults in code (part 4)  https://review.openstack.org/32922800:04
*** sameo_ has quit IRC00:06
*** shaohe_feng has quit IRC00:09
*** shaohe_feng has joined #openstack-nova00:10
*** anteaya has joined #openstack-nova00:11
*** claudiub has quit IRC00:15
*** rrecio has quit IRC00:17
*** ihrachys has quit IRC00:17
*** jamesdenton has joined #openstack-nova00:18
*** diogogmt has quit IRC00:18
*** shaohe_feng has quit IRC00:19
*** thorst has joined #openstack-nova00:19
*** shaohe_feng has joined #openstack-nova00:20
*** sacharya has joined #openstack-nova00:20
*** sacharya_ has quit IRC00:20
*** tbachman has quit IRC00:21
*** ircuser-1 has quit IRC00:21
*** tbachman has joined #openstack-nova00:21
openstackgerritLudovic Beliveau proposed openstack/nova: Trivial: Remove image_meta from update_usage_from_migration()  https://review.openstack.org/32923300:21
openstackgerritLudovic Beliveau proposed openstack/nova: Trivial: Remove unused argument image_meta from update_usage_from_migration()  https://review.openstack.org/32923300:23
*** jwcroppe_ has quit IRC00:23
*** Jeffrey4l has joined #openstack-nova00:23
*** MikeG451_ has quit IRC00:24
*** tbachman_ has joined #openstack-nova00:27
*** baoli has quit IRC00:28
*** baoli has joined #openstack-nova00:28
*** betherly has quit IRC00:28
*** betherly has joined #openstack-nova00:29
*** jianghuaw has quit IRC00:29
*** shaohe_feng has quit IRC00:29
*** mtanin___ has joined #openstack-nova00:30
*** tbachman has quit IRC00:30
*** yamahata has quit IRC00:30
*** tbachman_ is now known as tbachman00:30
*** shaohe_feng has joined #openstack-nova00:30
*** ircuser-1 has joined #openstack-nova00:30
*** mtanino has quit IRC00:31
*** yamahata has joined #openstack-nova00:31
*** jwcroppe has joined #openstack-nova00:33
*** rrecio has joined #openstack-nova00:37
*** rrecio_ has joined #openstack-nova00:38
*** shaohe_feng has quit IRC00:39
*** thorst has quit IRC00:40
*** shaohe_feng has joined #openstack-nova00:40
*** tbachman has left #openstack-nova00:41
*** sacharya has quit IRC00:41
*** zz_dimtruck is now known as dimtruck00:41
*** thorst has joined #openstack-nova00:41
*** tbachman has joined #openstack-nova00:41
*** rrecio has quit IRC00:41
*** browne has quit IRC00:41
*** Sukhdev has quit IRC00:49
*** rrecio_ has quit IRC00:49
*** thorst has quit IRC00:49
*** shaohe_feng has quit IRC00:50
*** shaohe_feng has joined #openstack-nova00:50
*** ijw has quit IRC00:51
*** baoli has quit IRC00:53
*** ijw has joined #openstack-nova00:55
*** cheneydc has joined #openstack-nova00:56
*** dimtruck is now known as zz_dimtruck00:57
*** stewie925 has quit IRC00:58
*** hoangcx has quit IRC00:59
*** tbachman has quit IRC01:00
*** shaohe_feng has quit IRC01:00
*** ssurana has joined #openstack-nova01:00
*** shaohe_feng has joined #openstack-nova01:00
*** zul has joined #openstack-nova01:04
*** Apoorva_ has quit IRC01:04
*** amotoki has joined #openstack-nova01:06
*** fishcried has joined #openstack-nova01:10
*** shaohe_feng has quit IRC01:10
*** fishcried has quit IRC01:10
*** shaohe_feng has joined #openstack-nova01:11
*** Daisy has joined #openstack-nova01:12
*** ijw has quit IRC01:13
*** hoangcx has joined #openstack-nova01:13
*** timello_ has quit IRC01:14
*** baoli has joined #openstack-nova01:16
*** shaohe_feng has quit IRC01:20
*** amotoki has quit IRC01:21
*** shaohe_feng has joined #openstack-nova01:21
*** artom has joined #openstack-nova01:22
*** fragatina has quit IRC01:23
*** hoangcx has quit IRC01:25
*** baoli has quit IRC01:26
*** hoangcx has joined #openstack-nova01:27
*** shaohe_feng has quit IRC01:31
*** pushkaru has quit IRC01:31
*** shaohe_feng has joined #openstack-nova01:31
*** pushkaru has joined #openstack-nova01:32
*** EinstCrazy has joined #openstack-nova01:33
*** thorst has joined #openstack-nova01:34
*** Daisy has quit IRC01:34
*** Daisy has joined #openstack-nova01:35
*** Daisy_ has joined #openstack-nova01:35
*** Daisy_ has quit IRC01:36
*** Daisy_ has joined #openstack-nova01:36
*** Daisy has quit IRC01:39
*** amotoki has joined #openstack-nova01:39
*** pushkaru has quit IRC01:40
*** zz_dimtruck is now known as dimtruck01:41
*** zul has quit IRC01:41
*** shaohe_feng has quit IRC01:41
*** shaohe_feng has joined #openstack-nova01:42
*** raunak has quit IRC01:46
openstackgerritGhanshyam Mann proposed openstack/nova: Remove python code validation specific to legacy_v2  https://review.openstack.org/32893101:47
*** hoangcx has quit IRC01:48
gmannmriedem_away: ^^ check if this is ok.01:49
*** hoangcx_ has joined #openstack-nova01:50
*** EinstCra_ has joined #openstack-nova01:51
*** shaohe_feng has quit IRC01:51
*** shaohe_feng has joined #openstack-nova01:52
*** abcxyz has joined #openstack-nova01:52
*** hoangcx_ has quit IRC01:53
*** hoangcx_ has joined #openstack-nova01:53
*** zul has joined #openstack-nova01:54
*** abcxyz has quit IRC01:55
*** EinstCrazy has quit IRC01:55
*** ssurana has quit IRC01:55
*** hoangcx_ is now known as hoangcx01:56
*** Daisy has joined #openstack-nova01:58
*** EinstCra_ has quit IRC01:58
*** abcxyz has joined #openstack-nova01:59
*** EinstCrazy has joined #openstack-nova01:59
*** sacharya has joined #openstack-nova01:59
*** sacharya has quit IRC01:59
*** Daisy_ has quit IRC02:00
*** EinstCrazy has quit IRC02:01
*** hoangcx has quit IRC02:01
*** shaohe_feng has quit IRC02:01
*** shaohe_feng has joined #openstack-nova02:02
*** EinstCrazy has joined #openstack-nova02:03
*** dimtruck is now known as zz_dimtruck02:06
*** erlon has quit IRC02:06
*** hoangcx has joined #openstack-nova02:06
*** zz_dimtruck is now known as dimtruck02:06
*** amotoki has quit IRC02:07
*** abcxyz has quit IRC02:07
*** amotoki has joined #openstack-nova02:07
*** abcxyz has joined #openstack-nova02:07
*** tbachman has joined #openstack-nova02:09
*** mfisch has quit IRC02:10
*** Daisy has quit IRC02:11
*** Daisy has joined #openstack-nova02:11
*** shaohe_feng has quit IRC02:12
*** gjayavelu has quit IRC02:12
*** yamahata has quit IRC02:12
*** shaohe_feng has joined #openstack-nova02:13
*** mtanino has joined #openstack-nova02:16
*** mtanin___ has quit IRC02:18
*** Daisy_ has joined #openstack-nova02:20
*** EinstCrazy has quit IRC02:20
*** shaohe_feng has quit IRC02:22
*** shaohe_feng has joined #openstack-nova02:23
*** Daisy has quit IRC02:23
*** EinstCrazy has joined #openstack-nova02:29
*** ssurana has joined #openstack-nova02:29
*** ssurana has quit IRC02:30
*** dave-mccowan has quit IRC02:32
*** shaohe_feng has quit IRC02:32
*** abcxyz has quit IRC02:32
*** shaohe_feng has joined #openstack-nova02:33
*** sacharya has joined #openstack-nova02:34
*** abcxyz has joined #openstack-nova02:34
*** ssurana has joined #openstack-nova02:35
*** ssurana has quit IRC02:36
*** mtanino has quit IRC02:37
*** artom has quit IRC02:38
*** artom has joined #openstack-nova02:39
*** amotoki has quit IRC02:40
*** shaohe_feng has quit IRC02:42
*** shaohe_feng has joined #openstack-nova02:43
openstackgerritTakashi NATSUME proposed openstack/nova: Add swap volume notifications samples  https://review.openstack.org/32886602:43
openstackgerritTakashi NATSUME proposed openstack/nova: Add swap volume notifications (start, end)  https://review.openstack.org/25028302:44
*** EinstCrazy has quit IRC02:45
*** EinstCrazy has joined #openstack-nova02:45
*** ssurana has joined #openstack-nova02:46
openstackgerritTakashi NATSUME proposed openstack/nova: Add swap volume notifications (error)  https://review.openstack.org/32805502:47
openstackgerritTakashi NATSUME proposed openstack/nova: Add swap volume notifications samples  https://review.openstack.org/32886602:47
*** jamesdenton has quit IRC02:48
*** woodster_ has quit IRC02:48
*** sacharya_ has joined #openstack-nova02:49
*** ssurana has quit IRC02:50
*** takashin has joined #openstack-nova02:51
*** sacharya has quit IRC02:52
*** sudipto has joined #openstack-nova02:52
*** shaohe_feng has quit IRC02:53
*** amotoki has joined #openstack-nova02:54
*** artom_ has joined #openstack-nova02:55
*** ijw has joined #openstack-nova02:56
*** shaohe_feng has joined #openstack-nova02:56
*** raunak has joined #openstack-nova02:56
*** artom has quit IRC02:56
*** amotoki has quit IRC02:57
*** thorst has quit IRC03:00
*** gjayavelu has joined #openstack-nova03:00
*** thorst has joined #openstack-nova03:00
*** EinstCrazy has quit IRC03:01
*** adisky has joined #openstack-nova03:02
*** shaohe_feng has quit IRC03:03
*** EinstCrazy has joined #openstack-nova03:04
*** shaohe_feng has joined #openstack-nova03:04
*** ijw has quit IRC03:04
*** abcxyz has quit IRC03:05
*** tbachman has quit IRC03:07
*** links has joined #openstack-nova03:08
*** thorst has quit IRC03:09
*** abcxyz has joined #openstack-nova03:09
*** pwnall1 has quit IRC03:10
*** tbachman has joined #openstack-nova03:10
*** openstackgerrit has quit IRC03:11
*** openstackgerrit has joined #openstack-nova03:11
*** shaohe_feng has quit IRC03:13
*** shaohe_feng has joined #openstack-nova03:16
*** M00nr41n has joined #openstack-nova03:17
*** dimtruck is now known as zz_dimtruck03:18
*** rama_y has quit IRC03:18
*** abcxyz has quit IRC03:19
*** caowei has joined #openstack-nova03:19
*** abcxyz has joined #openstack-nova03:20
*** M00nr41n has quit IRC03:21
*** shaohe_feng has quit IRC03:23
*** shaohe_feng has joined #openstack-nova03:24
*** sacharya_ has quit IRC03:27
*** sacharya has joined #openstack-nova03:28
openstackgerritAnusha Unnam proposed openstack/nova: Transform instance.resize notifications  https://review.openstack.org/32925503:28
*** yamahata has joined #openstack-nova03:29
*** sacharya_ has joined #openstack-nova03:30
*** abcxyz has quit IRC03:31
*** abcxyz has joined #openstack-nova03:32
*** sacharya has quit IRC03:32
*** sacharya has joined #openstack-nova03:33
*** shaohe_feng has quit IRC03:34
openstackgerritAnusha Unnam proposed openstack/nova: Transform instance.resize notifications  https://review.openstack.org/32925503:34
*** shaohe_feng has joined #openstack-nova03:34
*** sacharya_ has quit IRC03:36
*** klkumar has joined #openstack-nova03:39
*** raunak has quit IRC03:39
*** raunak has joined #openstack-nova03:41
*** shaohe_feng has quit IRC03:44
*** vishwanathj has joined #openstack-nova03:44
*** shaohe_feng has joined #openstack-nova03:44
*** ociuhandu has quit IRC03:45
*** ociuhandu has joined #openstack-nova03:49
*** ducttape_ has quit IRC03:50
*** abcxyz has quit IRC03:51
*** abcxyz has joined #openstack-nova03:52
*** shaohe_feng has quit IRC03:54
*** shaohe_feng has joined #openstack-nova03:55
*** ayoung has quit IRC03:56
*** caowei has quit IRC03:57
*** vishwanathj has quit IRC03:58
*** fishcried has joined #openstack-nova03:58
*** vishwanathj has joined #openstack-nova03:58
*** abcxyz has quit IRC04:00
*** zerda2 has joined #openstack-nova04:02
*** abcxyz has joined #openstack-nova04:03
*** shaohe_feng has quit IRC04:04
*** shaohe_feng has joined #openstack-nova04:05
*** ociuhandu has quit IRC04:05
*** thorst has joined #openstack-nova04:07
*** huyang has quit IRC04:08
*** wanghao has quit IRC04:10
*** shz has joined #openstack-nova04:11
*** wanghao has joined #openstack-nova04:11
*** raunak has quit IRC04:12
*** hanzhang has quit IRC04:14
*** thorst has quit IRC04:14
*** shaohe_feng has quit IRC04:15
*** diga has joined #openstack-nova04:15
*** shaohe_feng has joined #openstack-nova04:15
*** markvoelker has quit IRC04:16
*** vishwana_ has joined #openstack-nova04:17
*** vishwanathj has quit IRC04:20
*** vishwana_ has quit IRC04:22
*** vishwanathj has joined #openstack-nova04:24
*** shaohe_feng has quit IRC04:25
*** shaohe_feng has joined #openstack-nova04:26
*** Daisy_ has quit IRC04:26
*** sree_ has joined #openstack-nova04:27
*** sree_ is now known as Guest9463104:27
*** raunak has joined #openstack-nova04:33
*** shaohe_feng has quit IRC04:35
*** shaohe_feng has joined #openstack-nova04:35
*** abcxyz has quit IRC04:36
*** ssurana has joined #openstack-nova04:36
openstackgerritAndrew Laski proposed openstack/nova: Add CellMappingList object  https://review.openstack.org/32921604:36
*** sudipto has quit IRC04:37
*** abcxyz has joined #openstack-nova04:39
*** pcaruana has quit IRC04:39
*** diga has quit IRC04:39
*** irenab has quit IRC04:41
*** ratailor has joined #openstack-nova04:41
openstackgerritSivasathurappan Radhakrishnan proposed openstack/nova: Transform instance.shutdown notifications  https://review.openstack.org/32921404:44
*** fragatina has joined #openstack-nova04:45
*** diga has joined #openstack-nova04:45
*** shaohe_feng has quit IRC04:45
*** artom_ has quit IRC04:46
*** shaohe_feng has joined #openstack-nova04:46
*** artom has joined #openstack-nova04:47
*** fragatina has quit IRC04:50
*** caowei has joined #openstack-nova04:51
*** klkumar has quit IRC04:53
*** klkumar1 has joined #openstack-nova04:53
*** klkumar1 has quit IRC04:54
*** zhenguo_ has joined #openstack-nova04:54
*** klkumar has joined #openstack-nova04:55
*** shaohe_feng has quit IRC04:56
*** shaohe_feng has joined #openstack-nova04:56
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Fix parameters in os-instance-usage-audit-log  https://review.openstack.org/32898105:00
*** M00nr41n has joined #openstack-nova05:00
*** ssurana has quit IRC05:03
*** ssurana has joined #openstack-nova05:04
*** sheel has joined #openstack-nova05:05
*** ssurana has quit IRC05:05
*** moshele has joined #openstack-nova05:06
*** shaohe_feng has quit IRC05:06
*** shaohe_feng has joined #openstack-nova05:07
*** ishant|away is now known as ishant05:07
*** Daisy has joined #openstack-nova05:07
*** ssurana has joined #openstack-nova05:08
*** lpetrut has joined #openstack-nova05:09
*** Daisy_ has joined #openstack-nova05:11
*** Daisy has quit IRC05:11
*** jaosorior has joined #openstack-nova05:11
*** thorst has joined #openstack-nova05:12
*** ssurana has quit IRC05:13
*** sacharya has quit IRC05:16
*** sacharya has joined #openstack-nova05:16
*** shaohe_feng has quit IRC05:16
*** markvoelker has joined #openstack-nova05:17
*** shaohe_feng has joined #openstack-nova05:17
*** salv-orl_ has quit IRC05:17
*** ljxiash has joined #openstack-nova05:17
*** vladikr has quit IRC05:18
*** salv-orlando has joined #openstack-nova05:18
*** sridharg has joined #openstack-nova05:18
*** thorst has quit IRC05:19
*** markvoelker has quit IRC05:22
*** itamarl has joined #openstack-nova05:22
*** prateek has joined #openstack-nova05:25
*** shaohe_feng has quit IRC05:26
*** shaohe_feng has joined #openstack-nova05:27
*** salv-orl_ has joined #openstack-nova05:29
*** ssurana has joined #openstack-nova05:29
*** prateek has quit IRC05:30
*** ecelik has joined #openstack-nova05:31
*** salv-orlando has quit IRC05:31
*** ssurana has quit IRC05:34
*** ssurana has joined #openstack-nova05:34
*** salv-orl_ has quit IRC05:34
*** salv-orlando has joined #openstack-nova05:34
*** shaohe_feng has quit IRC05:37
*** shaohe_feng has joined #openstack-nova05:38
*** EinstCrazy has quit IRC05:40
*** raunak has quit IRC05:40
*** Guest94631 has quit IRC05:46
*** sree has joined #openstack-nova05:47
*** shaohe_feng has quit IRC05:47
*** shaohe_feng has joined #openstack-nova05:48
*** sree has quit IRC05:49
*** sree has joined #openstack-nova05:50
*** cfriesen has quit IRC05:53
openstackgerritChangBo Guo(gcb) proposed openstack/nova: Deprecated option 'mkisofs_cmd' for removal  https://review.openstack.org/26274405:53
openstackgerritChangBo Guo(gcb) proposed openstack/nova: Fix outdated parameter network_info description in virt/driver  https://review.openstack.org/26316605:54
*** vishwanathj has quit IRC05:54
*** shaohe_feng has quit IRC05:57
*** shaohe_feng has joined #openstack-nova05:58
*** Sukhdev has joined #openstack-nova06:00
*** ssurana has quit IRC06:00
*** liverpooler has quit IRC06:00
*** liverpooler has joined #openstack-nova06:01
*** ssurana has joined #openstack-nova06:02
*** ssurana has quit IRC06:07
*** chandankumar has joined #openstack-nova06:07
*** shaohe_feng has quit IRC06:07
*** shaohe_feng has joined #openstack-nova06:08
*** Daisy_ has quit IRC06:11
*** rcernin has joined #openstack-nova06:11
*** Daisy has joined #openstack-nova06:12
*** salv-orlando has quit IRC06:13
*** salv-orlando has joined #openstack-nova06:14
*** Daisy has quit IRC06:16
*** pcaruana has joined #openstack-nova06:16
*** thorst has joined #openstack-nova06:16
*** jbernard has quit IRC06:17
*** shaohe_feng has quit IRC06:18
*** paul-carlton2 has quit IRC06:18
*** csatari has joined #openstack-nova06:19
*** jbernard has joined #openstack-nova06:19
*** vishwanathj has joined #openstack-nova06:19
*** apoorv has joined #openstack-nova06:19
*** shaohe_feng has joined #openstack-nova06:21
*** abcxyz has quit IRC06:21
*** abcxyz has joined #openstack-nova06:22
*** yamahata has quit IRC06:23
*** thorst has quit IRC06:24
*** yamahata has joined #openstack-nova06:26
*** shaohe_feng has quit IRC06:28
*** shaohe_feng has joined #openstack-nova06:29
openstackgerritDinesh Bhor proposed openstack/nova: Return HTTP 200 on list for invalid status  https://review.openstack.org/31596406:30
*** chandankumar has quit IRC06:32
*** EinstCrazy has joined #openstack-nova06:32
*** Daisy has joined #openstack-nova06:33
ratailorI am sending a patchset which is a dependency of another patchset under review. When I try to push my patch, it sends two patches in which one is a duplicate of patchset under review. Can someone let me know how to just send the last patch, and not the one it is dependent on ?06:38
*** jwcroppe has quit IRC06:38
*** shaohe_feng has quit IRC06:38
*** EinstCrazy has quit IRC06:39
*** shaohe_feng has joined #openstack-nova06:39
*** Sukhdev has quit IRC06:39
*** ihrachys has joined #openstack-nova06:41
*** EinstCrazy has joined #openstack-nova06:41
*** andreas_s has joined #openstack-nova06:42
*** EinstCrazy has quit IRC06:44
*** sudipto has joined #openstack-nova06:44
*** EinstCrazy has joined #openstack-nova06:44
*** prateek has joined #openstack-nova06:46
*** laszloh has joined #openstack-nova06:46
*** abcxyz has quit IRC06:46
*** jwcroppe has joined #openstack-nova06:47
ratailoropenstack, I am sending a patchset which is a dependency of another patchset under review. When I try to push my patch, it sends two patches in which one is a duplicate of patchset under review. Can someone let me know how to just send the last patch, and not the one it is dependent on ?06:47
openstackgerritRong Han proposed openstack/nova: [libvirt]Optimize _get_instance_disk_info  https://review.openstack.org/29759806:47
prateekratailor, i have also faced such a problem, does someone know how to do what Rajesh has asked ?06:47
*** openstackgerrit has quit IRC06:48
*** openstackgerrit has joined #openstack-nova06:48
*** shaohe_feng has quit IRC06:48
*** chandankumar has joined #openstack-nova06:49
*** shaohe_feng has joined #openstack-nova06:49
*** ociuhandu has joined #openstack-nova06:50
*** mpavone has joined #openstack-nova06:51
*** ducttape_ has joined #openstack-nova06:51
*** tesseract has joined #openstack-nova06:56
*** Hosam has joined #openstack-nova06:56
*** Hosam has quit IRC06:56
*** ducttape_ has quit IRC06:56
*** Hosam has joined #openstack-nova06:56
sudiptoratailor, prateek it doesn't send a new patchset for the parent unless you have switched repos or changed revisions of the parent and your new patchset wants to get updated with the latest references.06:57
prateeksudipto, thanks06:57
ratailorsudipto, thanks06:57
*** shaohe_feng has quit IRC06:59
*** shaohe_feng has joined #openstack-nova06:59
*** EinstCrazy has quit IRC06:59
*** EinstCrazy has joined #openstack-nova07:00
*** abcxyz has joined #openstack-nova07:00
openstackgerritSudipta Biswas proposed openstack/nova: Introduce utility module for pcp  https://review.openstack.org/20316307:00
openstackgerritSudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor  https://review.openstack.org/26677307:00
*** hoangcx has quit IRC07:03
*** sacharya has quit IRC07:03
*** abcxyz has quit IRC07:04
openstackgerritPawel Koniszewski proposed openstack/nova: Add new configuration option to turn auto converge on/off  https://review.openstack.org/26600107:05
*** hoangcx has joined #openstack-nova07:06
*** shaohe_feng has quit IRC07:09
*** edand has joined #openstack-nova07:09
*** shaohe_feng has joined #openstack-nova07:10
*** vtech has joined #openstack-nova07:11
csatariI have a correction to the documentation where tempest-dsvm-intel-nfv fails with some totally unrelated error. Is there any hint what can be the problem?07:12
csatarihttps://review.openstack.org/#/c/327112/07:12
*** gjayavelu has quit IRC07:16
*** hoangcx has quit IRC07:17
sudiptocsatari, i don't think it's related to your patch. Just do a re-check and see if it fails again/07:18
sudipto?07:18
*** markvoelker has joined #openstack-nova07:18
csatarisudipto: Thanks. I've tried "recheck tempest-dsvm-intel-nfv".07:19
*** shaohe_feng has quit IRC07:19
csatariBut for me it seems that some othe rbuild job is executed.07:19
csatariJenkins returns with this:07:20
*** shaohe_feng has joined #openstack-nova07:20
csatariPatch Set 1:07:20
csatariBuild succeeded (check pipeline).07:20
csatari    gate-nova-docs SUCCESS in 3m 59s07:20
csatari    gate-nova-pep8 SUCCESS in 6m 19s07:20
csatari    gate-nova-api-ref SUCCESS in 3m 24s07:20
csatariBut the status is still "tempest-dsvm-intel-nfvFAILURE in 37m 56s"07:20
*** pece has joined #openstack-nova07:21
*** jichen has joined #openstack-nova07:21
*** thorst has joined #openstack-nova07:22
*** markvoelker has quit IRC07:22
*** jlanoux has joined #openstack-nova07:26
*** hoangcx has joined #openstack-nova07:28
*** thorst has quit IRC07:29
*** shaohe_feng has quit IRC07:29
*** shaohe_feng has joined #openstack-nova07:30
*** dmk0202 has joined #openstack-nova07:32
*** pece has quit IRC07:32
*** sree has quit IRC07:33
*** sree has joined #openstack-nova07:34
*** irenab has joined #openstack-nova07:35
*** jaosorior is now known as jaosorior_brb07:35
*** jlanoux has quit IRC07:37
*** paul-carlton2 has joined #openstack-nova07:37
*** EinstCrazy has quit IRC07:37
*** jlanoux has joined #openstack-nova07:38
*** takashin_ has joined #openstack-nova07:38
*** sree has quit IRC07:38
*** takashin has quit IRC07:39
*** jlanoux has quit IRC07:39
*** shaohe_feng has quit IRC07:40
*** EinstCrazy has joined #openstack-nova07:40
*** shaohe_feng has joined #openstack-nova07:40
*** yamahata has quit IRC07:41
*** lpetrut has quit IRC07:42
openstackgerritmelanie witt proposed openstack/nova: Disallow instance tag set for invalid instance states  https://review.openstack.org/32930407:43
*** salv-orlando has quit IRC07:44
*** salv-orlando has joined #openstack-nova07:44
*** EinstCrazy has quit IRC07:45
*** EinstCrazy has joined #openstack-nova07:45
*** sree has joined #openstack-nova07:47
*** fragatina has joined #openstack-nova07:49
*** EinstCrazy has quit IRC07:49
BobBalljohnthetubaguy: Could you re-add Citrix XenServer CI to https://review.openstack.org/#/admin/groups/511,members pls07:49
*** EinstCrazy has joined #openstack-nova07:50
BobBalljohnthetubaguy: Fix merged 6 hours ago, so we want to recheck all failed jobs https://review.openstack.org/#/c/328836/07:50
*** shaohe_feng has quit IRC07:50
*** shaohe_feng has joined #openstack-nova07:50
*** M00nr41n has left #openstack-nova07:50
openstackgerritZhenyu Zheng proposed openstack/nova: Add pagination and changes-since for instance-actions  https://review.openstack.org/32632607:53
*** fragatina has quit IRC07:55
*** EinstCrazy has quit IRC07:55
*** hoangcx has quit IRC07:57
*** hoangcx has joined #openstack-nova07:58
*** zzzeek has quit IRC08:00
*** danpb has joined #openstack-nova08:00
*** zzzeek has joined #openstack-nova08:00
*** shaohe_feng has quit IRC08:00
*** EinstCrazy has joined #openstack-nova08:01
*** jlanoux has joined #openstack-nova08:02
*** shaohe_feng has joined #openstack-nova08:03
*** roeyc has joined #openstack-nova08:07
*** sfinucan has joined #openstack-nova08:10
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c  https://review.openstack.org/30334508:10
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c  https://review.openstack.org/30334508:10
*** shaohe_feng has quit IRC08:10
*** shaohe_feng has joined #openstack-nova08:11
*** lhinds_ has joined #openstack-nova08:12
csatarisudipto: And the build log still dates back for the first execution: http://intel-openstack-ci-logs.ovh/12/327112/1/check/tempest-dsvm-intel-nfv/0db06f2/08:12
csatariShall I try a full recheck?08:13
csatariWhat can go wrong ;)08:13
*** artom has quit IRC08:14
*** artom has joined #openstack-nova08:15
sudiptocsatari, sorry, was out for lunch. Yeah try a full recheck08:16
*** Daisy has quit IRC08:19
*** Daisy has joined #openstack-nova08:19
*** ljxiash has quit IRC08:20
*** shaohe_feng has quit IRC08:21
*** shaohe_feng has joined #openstack-nova08:22
*** sameo_ has joined #openstack-nova08:23
*** muawiakhan has joined #openstack-nova08:24
*** mvk has quit IRC08:24
openstackgerritSudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor  https://review.openstack.org/26677308:25
*** diga has quit IRC08:25
*** thorst has joined #openstack-nova08:26
openstackgerritjichenjc proposed openstack/nova: Use instance object instead of db record  https://review.openstack.org/23421808:27
*** pece has joined #openstack-nova08:28
openstackgerritAlvaro Lopez Garcia proposed openstack/nova: Ensure that periodic reclaim is able to clean DB deleted instances  https://review.openstack.org/32325008:29
*** shaohe_feng has quit IRC08:31
*** shaohe_feng has joined #openstack-nova08:32
*** ljxiash has joined #openstack-nova08:32
*** hoangcx has quit IRC08:33
*** thorst has quit IRC08:34
*** mnestratov has joined #openstack-nova08:35
*** hoangcx has joined #openstack-nova08:35
*** cdent has joined #openstack-nova08:37
*** jaosorior_brb has quit IRC08:39
*** jaosorior_brb has joined #openstack-nova08:40
*** vishwanathj has quit IRC08:40
*** derekh has joined #openstack-nova08:40
*** vishwanathj has joined #openstack-nova08:41
*** shaohe_feng has quit IRC08:41
*** shaohe_feng has joined #openstack-nova08:42
*** eglynn has joined #openstack-nova08:43
*** Qiming is now known as Qiming_afk08:43
openstackgerritDaniel Berrange proposed openstack/nova: os-vif: convert libvirt driver to use os-vif library  https://review.openstack.org/26967208:44
*** hoangcx has quit IRC08:45
*** srushti has joined #openstack-nova08:46
*** yassine has joined #openstack-nova08:48
*** matrohon has joined #openstack-nova08:50
srushtijohnthetubaguy: Hi, Could you please review this patch https://review.openstack.org/#/c/324320/08:51
*** mvk has joined #openstack-nova08:51
*** shaohe_feng has quit IRC08:51
*** EinstCrazy has quit IRC08:52
*** ducttape_ has joined #openstack-nova08:52
*** shaohe_feng has joined #openstack-nova08:52
*** jaosorior_brb is now known as jaosorior08:53
*** EinstCrazy has joined #openstack-nova08:54
*** Dinesh_Bhor has joined #openstack-nova08:55
*** ducttape_ has quit IRC08:58
*** artom has quit IRC08:58
openstackgerritGhanshyam Mann proposed openstack/nova: api-ref: verify images.inc  https://review.openstack.org/32687109:00
*** artom has joined #openstack-nova09:00
tdurakovjohnthetubaguy: hi, are you around?09:01
*** shaohe_feng has quit IRC09:02
johnthetubaguytdurakov: I am09:02
*** shaohe_feng has joined #openstack-nova09:02
* cdent watches johnthetubaguy and tdurakov because he's lonely09:02
*** Daisy_ has joined #openstack-nova09:02
* johnthetubaguy waves at cdent to in the hope of making him feel better09:03
tdurakovjohnthetubaguy: take a look: https://github.com/openstack/nova/blob/master/nova/virt/xenapi/pool.py#L104  - I feel it worth to call rpcapi from compute manager, rather than driver package module09:03
* cdent squeeeeees09:03
tdurakovcdent: hey:)09:03
tdurakovjohnthetubaguy: what do you think?09:03
openstackgerritZhenyu Zheng proposed openstack/nova: Add pagination and changes-since for instance-actions  https://review.openstack.org/32632609:04
johnthetubaguytdurakov: I personally want to remove all that stuff09:05
johnthetubaguytdurakov: but not sure BobBall agrees yet (about the pool support)09:05
johnthetubaguytdurakov: I am not sure its worth fixing right now09:05
tdurakovjohnthetubaguy: hah, it solution too:)09:05
tdurakovsure09:05
*** Qiming_afk is now known as Qiming09:06
*** gszasz has joined #openstack-nova09:06
*** Daisy has quit IRC09:06
*** lpetrut has joined #openstack-nova09:10
openstackgerritTimofey Durakov proposed openstack/nova: rest api version bumped for async pre live migration checks  https://review.openstack.org/31493209:10
openstackgerritTimofey Durakov proposed openstack/nova: Make live migration checks async  https://review.openstack.org/31111609:10
openstackgerritTimofey Durakov proposed openstack/nova: Added instance actions for conductor  https://review.openstack.org/31111509:10
*** EinstCrazy has quit IRC09:10
*** EinstCrazy has joined #openstack-nova09:10
*** Daisy_ has quit IRC09:10
*** Daisy has joined #openstack-nova09:11
tdurakovcdent, johnthetubaguy, could you take a look, when have some time^09:11
*** shaohe_feng has quit IRC09:12
*** shaohe_feng has joined #openstack-nova09:12
cdenttdurakov: sure09:13
*** sambetts|afk is now known as sambetts09:14
*** Daisy has quit IRC09:15
*** EinstCrazy has quit IRC09:18
*** EinstCrazy has joined #openstack-nova09:18
*** shaohe_feng has quit IRC09:22
*** chandankumar has quit IRC09:23
*** shaohe_feng has joined #openstack-nova09:23
openstackgerritGhanshyam Mann proposed openstack/nova: Remove extra expected error code (413) from image metadata  https://review.openstack.org/32933509:28
*** PaulMurray has joined #openstack-nova09:29
johnthetubaguymriedem_away: this one needs the -2 removing now: https://review.openstack.org/#/c/297574/09:31
*** thorst has joined #openstack-nova09:32
*** shaohe_feng has quit IRC09:32
*** EinstCrazy has quit IRC09:33
*** shaohe_feng has joined #openstack-nova09:33
*** EinstCrazy has joined #openstack-nova09:33
*** zenoway has joined #openstack-nova09:34
*** ljxiash has quit IRC09:38
*** artom has quit IRC09:38
*** ljxiash has joined #openstack-nova09:38
*** artom has joined #openstack-nova09:38
*** thorst has quit IRC09:39
*** chandankumar has joined #openstack-nova09:39
*** EinstCrazy has quit IRC09:41
*** EinstCrazy has joined #openstack-nova09:41
openstackgerritEli Qiao proposed openstack/nova: libvirt: add perf event support when create instance  https://review.openstack.org/32089709:41
openstackgerritEli Qiao proposed openstack/nova: libvirt: Add migration support for perf event support  https://review.openstack.org/32933909:41
openstackgerritZhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding  https://review.openstack.org/21756709:42
*** gjayavelu has joined #openstack-nova09:43
*** gjayavelu has quit IRC09:43
*** shaohe_feng has quit IRC09:43
*** gjayavelu has joined #openstack-nova09:43
*** ljxiash has quit IRC09:43
*** shaohe_feng has joined #openstack-nova09:43
*** tyrola has joined #openstack-nova09:44
*** roeyc has quit IRC09:44
*** EinstCrazy has quit IRC09:45
*** EinstCrazy has joined #openstack-nova09:46
*** mvk has quit IRC09:50
*** ociuhandu has quit IRC09:51
*** mvk has joined #openstack-nova09:51
*** EinstCrazy has quit IRC09:53
*** shaohe_feng has quit IRC09:53
*** EinstCrazy has joined #openstack-nova09:53
*** shaohe_feng has joined #openstack-nova09:54
*** apoorv has quit IRC09:54
*** apoorv has joined #openstack-nova09:59
*** fishcried has quit IRC09:59
* mdbooth can no longer remember the difference between block_device_mapping (pre conversion), block_device_mapping (post conversion), block_device_info, disk_info, block_disk_info, volumes (when it's cinder), volumes (when it's any disk), image (when it's from glance), image (when it's not)10:00
mdboothI consider myself successfully thoroughly confused10:01
*** cheneydc has quit IRC10:01
*** claudiub has joined #openstack-nova10:02
*** EinstCrazy has quit IRC10:03
*** EinstCrazy has joined #openstack-nova10:03
PaulMurraymdbooth, collaborative development, its the future !10:03
*** shaohe_feng has quit IRC10:03
*** sree has quit IRC10:05
*** shaohe_feng has joined #openstack-nova10:06
*** sgordon` is now known as sgordon10:06
*** links has quit IRC10:07
*** dmk0202 has quit IRC10:08
*** hoangcx has joined #openstack-nova10:10
openstackgerritGhanshyam Mann proposed openstack/nova: Publish proxy APIs deprecation in api ref doc  https://review.openstack.org/32935710:12
gmannjohnthetubaguy: mriedem_away alex_xu oomichi : ^^ please check if this looks fine. deprecation of nova proxy APi in doc10:13
*** ociuhandu has joined #openstack-nova10:13
*** shaohe_feng has quit IRC10:13
*** shaohe_feng has joined #openstack-nova10:14
*** ptm_away has joined #openstack-nova10:15
*** PaulMurray has quit IRC10:18
*** rk4n has joined #openstack-nova10:20
*** muawiakhan has quit IRC10:20
*** links has joined #openstack-nova10:20
*** shaohe_feng has quit IRC10:24
*** shaohe_feng has joined #openstack-nova10:24
*** EinstCrazy has quit IRC10:25
*** jlanoux_ has joined #openstack-nova10:25
*** hoangcx has quit IRC10:26
*** gjayavelu has quit IRC10:26
*** hoangcx has joined #openstack-nova10:26
*** jlanoux has quit IRC10:28
*** sdague has joined #openstack-nova10:31
*** EinstCrazy has joined #openstack-nova10:32
*** roeyc has joined #openstack-nova10:34
*** amotoki_ has joined #openstack-nova10:34
*** shaohe_feng has quit IRC10:34
*** shaohe_feng has joined #openstack-nova10:35
*** thorst has joined #openstack-nova10:35
*** EinstCrazy has quit IRC10:36
*** amotoki_ has quit IRC10:37
*** salv-orlando has quit IRC10:38
*** salv-orlando has joined #openstack-nova10:39
*** sameo_ has quit IRC10:40
*** takashin_ has left #openstack-nova10:41
*** cdent has quit IRC10:43
*** thorst has quit IRC10:44
*** shaohe_feng has quit IRC10:44
*** shaohe_feng has joined #openstack-nova10:45
*** hoangcx has quit IRC10:45
*** ishant is now known as ishant|away10:45
*** EinstCrazy has joined #openstack-nova10:45
*** jlanoux has joined #openstack-nova10:46
*** ljxiash has joined #openstack-nova10:46
openstackgerritSudipta Biswas proposed openstack/nova: Introduce utility module for pcp  https://review.openstack.org/20316310:46
openstackgerritMatthew Booth proposed openstack/nova: rename libvirt has_default_ephemeral  https://review.openstack.org/32936610:46
*** hoangcx has joined #openstack-nova10:47
*** jlanoux_ has quit IRC10:48
*** jwcroppe has quit IRC10:51
*** jwcroppe has joined #openstack-nova10:51
*** ljxiash has quit IRC10:53
*** ducttape_ has joined #openstack-nova10:54
*** shaohe_feng has quit IRC10:54
*** yassine has quit IRC10:55
*** shaohe_feng has joined #openstack-nova10:56
*** sudipto has quit IRC10:56
*** salv-orlando has quit IRC10:58
*** salv-orlando has joined #openstack-nova10:58
*** ducttape_ has quit IRC10:59
*** caowei has quit IRC11:00
*** sahid has joined #openstack-nova11:02
*** shaohe_feng has quit IRC11:05
*** shaohe_feng has joined #openstack-nova11:06
*** permalac has quit IRC11:09
*** gszasz has quit IRC11:13
*** jwcroppe has quit IRC11:14
*** shaohe_feng has quit IRC11:15
*** sheel has quit IRC11:15
*** shaohe_feng has joined #openstack-nova11:16
openstackgerritMatthew Booth proposed openstack/nova: Rename convert_volume and convert_all_volumes in virt.block_device  https://review.openstack.org/32938111:16
*** canan has quit IRC11:16
*** rtheis has joined #openstack-nova11:16
*** liverpooler has quit IRC11:17
*** liverpooler has joined #openstack-nova11:17
*** cdent has joined #openstack-nova11:17
*** ljxiash has joined #openstack-nova11:18
*** EinstCrazy has quit IRC11:22
cdentsdague: "api-no-more-extensions" is an excellent context flesher. to you or whoever wrote that, thanks11:22
sdaguecdent: yeh, I wrote that up yesterday11:23
cdentnice work11:23
*** ljxiash has quit IRC11:23
*** jwcroppe has joined #openstack-nova11:23
sdaguethanks11:23
*** ociuhandu has quit IRC11:23
*** ociuhandu has joined #openstack-nova11:23
*** xenogear has quit IRC11:25
*** rk4n has quit IRC11:25
*** shaohe_feng has quit IRC11:25
*** shaohe_feng has joined #openstack-nova11:26
*** ociuhandu has quit IRC11:26
*** ociuhandu has joined #openstack-nova11:26
*** salv-orl_ has joined #openstack-nova11:28
*** sree has joined #openstack-nova11:29
*** mnestratov has quit IRC11:31
*** salv-orlando has quit IRC11:32
*** sree has quit IRC11:34
*** vtech has quit IRC11:35
*** rodrigods has quit IRC11:35
*** vtech has joined #openstack-nova11:35
*** rodrigods has joined #openstack-nova11:35
*** shaohe_feng has quit IRC11:35
*** shaohe_feng has joined #openstack-nova11:36
*** zenoway has quit IRC11:38
*** zenoway has joined #openstack-nova11:38
*** thorst has joined #openstack-nova11:41
*** thorst_ has joined #openstack-nova11:43
*** jed56 has quit IRC11:45
*** rk4n has joined #openstack-nova11:46
*** shaohe_feng has quit IRC11:46
openstackgerritChangBo Guo(gcb) proposed openstack/nova: Use min parameter to restrict live-migration config options  https://review.openstack.org/32331311:46
*** shaohe_feng has joined #openstack-nova11:47
*** thorst has quit IRC11:47
*** abalutoiu has joined #openstack-nova11:48
*** thorst_ is now known as thorst11:49
*** omnipresent has joined #openstack-nova11:50
*** baoli has joined #openstack-nova11:51
*** baoli_ has joined #openstack-nova11:52
*** zenoway has quit IRC11:53
*** raildo-afk is now known as raildo11:54
*** apoorv has quit IRC11:54
*** ducttape_ has joined #openstack-nova11:54
*** sahid has quit IRC11:55
*** shaohe_feng has quit IRC11:56
*** baoli has quit IRC11:56
*** aysyd has joined #openstack-nova11:57
*** shaohe_feng has joined #openstack-nova11:57
*** winston-d_ has quit IRC11:57
*** gszasz has joined #openstack-nova11:58
*** takedakn has joined #openstack-nova11:58
*** ljxiash has joined #openstack-nova11:59
*** sahid has joined #openstack-nova12:01
openstackgerritjichenjc proposed openstack/nova: Remove 413 expect in servers.py  https://review.openstack.org/32940212:02
*** jed56 has joined #openstack-nova12:02
BobBallsdague: If you have a few minutes (possibly less) - I'd appreciate thoughts on https://review.openstack.org/#/c/328892/12:03
*** ducttape_ has quit IRC12:03
openstackgerritKevin Zhao proposed openstack/nova: Set the virtio scsi controller index for virtio-scsi controller  https://review.openstack.org/32940312:03
*** sree has joined #openstack-nova12:04
sdagueBobBall: yep, good catch12:04
*** ljxiash has quit IRC12:05
sdagueBobBall: do you have the commit reference for when that was introduced?12:05
BobBallCan get it easily - 1 sec12:05
sdaguewe should probably reference that in the commit message12:06
sdagueonce it's in there, I'm fine fast approving that one, because it's a really crisp bug12:06
*** shaohe_feng has quit IRC12:06
BobBallI6d0f09950ea1200d3367a53aa4a3eea9be7abc6612:06
sdagueand those kinds of devstack bugs should be fixed quickly12:07
BobBallWill add it12:07
openstackgerritChris Dent proposed openstack/nova: Add delete_, update_ and add_ inventory to ResourceProvider  https://review.openstack.org/32827612:07
openstackgerritChris Dent proposed openstack/nova: Add support for resource inventories to placement API  https://review.openstack.org/32915212:07
openstackgerritChris Dent proposed openstack/nova: Add a ResourceProviderList object  https://review.openstack.org/32830712:07
openstackgerritChris Dent proposed openstack/nova: Add set_inventory() method on ResourceProvider  https://review.openstack.org/32644012:07
openstackgerritChris Dent proposed openstack/nova: Add initial framing of placement API  https://review.openstack.org/32914912:07
openstackgerritChris Dent proposed openstack/nova: Add support for resource_providers urls  https://review.openstack.org/32915112:07
openstackgerritChris Dent proposed openstack/nova: Add microversion support for the placement API  https://review.openstack.org/32915012:07
openstackgerritChris Dent proposed openstack/nova: WIP experiment with the remainder of the placement API  https://review.openstack.org/29310412:07
*** shaohe_feng has joined #openstack-nova12:07
BobBallsdague: Do we have an "Introduced-By: " tag to shame bug introducers automatically? :P12:08
BobBall(Just kidding)12:08
BobBallAdded reference12:08
openstackgerritClaudiu Belu proposed openstack/nova: policy: Add defaults in code (part 1)  https://review.openstack.org/32885012:10
*** fragatina has joined #openstack-nova12:11
*** daemontool has joined #openstack-nova12:11
*** pradk has joined #openstack-nova12:12
*** markvoelker has joined #openstack-nova12:13
*** palexster has quit IRC12:15
*** matrohon has quit IRC12:15
*** cdent has quit IRC12:16
*** fragatina has quit IRC12:16
*** shaohe_feng has quit IRC12:16
*** shaohe_feng has joined #openstack-nova12:17
*** sahid has quit IRC12:17
*** cdent has joined #openstack-nova12:17
*** laszloh has left #openstack-nova12:18
*** ptm_away has quit IRC12:18
*** ljxiash has joined #openstack-nova12:19
*** palexster has joined #openstack-nova12:21
openstackgerritLee Yarwood proposed openstack/nova: libvirt: Volume backed instances should not call imagebacked during cleanup  https://review.openstack.org/32903012:23
*** ljxiash has quit IRC12:24
*** zerda2 has quit IRC12:24
*** matrohon has joined #openstack-nova12:25
*** shaohe_feng has quit IRC12:27
*** smatzek has joined #openstack-nova12:27
*** shaohe_feng has joined #openstack-nova12:28
*** kaisers1 has quit IRC12:29
*** Hosam has quit IRC12:29
*** Hosam has joined #openstack-nova12:30
*** ivase has joined #openstack-nova12:30
*** salv-orl_ has quit IRC12:33
*** salv-orlando has joined #openstack-nova12:34
*** Hosam has quit IRC12:34
*** shaohe_feng has quit IRC12:37
csatarisudipto: Okay, I'm running a full recheck. Thanks for the help/12:37
*** csatari has quit IRC12:38
*** shaohe_feng has joined #openstack-nova12:38
sdaguejohnthetubaguy: you about?12:39
johnthetubaguysdague: I am12:39
sdaguejohnthetubaguy: because I've now fully lost context, can you be more specific about your -1 here - https://review.openstack.org/#/c/325502/ ?12:39
openstackgerritEd Leafe proposed openstack/nova: Correct the network config option help text  https://review.openstack.org/31872612:40
*** yassine has joined #openstack-nova12:40
johnthetubaguysdague: I think a rebase lost this change from alex: https://review.openstack.org/#/c/325502/8..912:40
sdagueah12:41
openstackgerritSean Dague proposed openstack/nova: api-ref: add version 2.3 parameters to servers  https://review.openstack.org/32550212:44
*** pwnall has joined #openstack-nova12:44
johnthetubaguysdague: gerrit is getting very cleaver these days, +W as alex's vote came back to life12:45
sdagueyeh12:45
sdaguealso... the fact that we have 3 server views was tripping me up12:46
sdagueon the folding patch12:46
sdaguecreate, basic, show12:46
sdagueI guess that's so that admin pass can hook create but not the others, but it's still a bit wonky12:46
*** shaohe_feng has quit IRC12:47
johnthetubaguyyeah, that stuff is totally maddening, or however you spell that12:47
*** shaohe_feng has joined #openstack-nova12:48
*** jamesdenton has joined #openstack-nova12:50
danpbfyi, i'd love to see some cores  review the os-vif integration patch for nova, as its finally ready for merge from my pov https://review.openstack.org/#/c/269672/12:50
*** stack_ has joined #openstack-nova12:50
*** stack_ has quit IRC12:51
sdaguedanpb: given that we tripped up on the privsep helper upgrade on os-brick this weekend, how do you imagine the rolling upgrade story goes here?12:51
danpbsdague: that's first i've heard of that - what was the problem ?12:52
sdagueI put a summary email out on the list this morning about what went down12:52
sdaguelet me dig up the link12:52
sdaguehttp://lists.openstack.org/pipermail/openstack-dev/2016-June/097293.html12:52
danpbthanks12:52
*** chandankumar has quit IRC12:53
sdaguewe haven't gotten to agreed solution yet, but that at least hopefully frames the problem12:53
*** takedakn has quit IRC12:53
danpbso IIUC the crux of the problem was that nova.conf did not get the config opt needed to tell privsep to use rootwrap for running its helper12:54
danpband so upgrade was just working by luck because CI had a blanket allow-all rule for sudo12:54
bauzascdent: aloha, maybe we should discuss on https://review.openstack.org/#/c/326440/15/nova/objects/resource_provider.py12:54
*** klkumar has quit IRC12:55
danpbsdague: sounds like os-vif will certainly hit the same problem, as you'll remember we just had to add a devstack rule to set nova.conf to use rootwrap for privsep12:55
sdagueyep12:55
bauzascdent: tbc, we're already incrementing and persisting the generation bit by https://review.openstack.org/#/c/326440/15/nova/objects/resource_provider.py@141 right12:55
danpbseems that perhaps we ought to make nova explicitly override the defaults for privsep somehow12:55
danpbas basically every user of privsep is going to hit the same problem as long as privsep defaults to using sudo directly12:56
sdaguedanpb: yeh, that might work. I was hoping to see what the cinder folks working through this ran into.12:56
danpbeg, privsep.set_default_helper(...nova rootwrap...)12:56
danpbi'll reply on list12:57
bauzascdent: my point is that we could have 2 calls to _set_inventory that would do something like <A: transaction><B:transaction><B:wait><A:increment_DB_generation><B:increment_Db_generation><A:increment_object_generation><B:increment_object_generation>12:57
bauzasor even terribe12:57
*** shaohe_feng has quit IRC12:57
bauzascdent: <A: transaction><B:transaction><B:wait><A:increment_DB_generation><B:increment_Db_generation><B:increment_object_generation><A:increment_object_generation>12:58
*** shaohe_feng has joined #openstack-nova12:58
cdenthi bauzas, catching up12:59
*** lindycoder has joined #openstack-nova12:59
*** gstepanov has joined #openstack-nova12:59
dansmithbauzas: yeah, incrementing in python in the object there is not how I expected this to work12:59
*** zhs has joined #openstack-nova13:00
*** salv-orlando has quit IRC13:00
*** salv-orlando has joined #openstack-nova13:00
*** lindycod_ has joined #openstack-nova13:00
cdentit's done that way just as a convenience. the database has already been updated, and we'd like the caller's view to reflect what just happened _in their context_. Since the only thing that has changed on the rp was generation, this way is simple.13:01
cdentwe don't want the caller A's generation to be whatever the generation would be after both A and B were done, only A13:01
cdentbut it quite likely I'm understanding what the problem is?13:01
dansmithcdent: we should do that from what we read from the db though, right?13:01
cdents/I'm/I'm not/13:02
cdentwe haven't done a select, just an update, which only succeeds if the generation matched13:02
cdent(or a delete or an insert)13:02
cdent(or all three of them)13:03
bauzascdent: well, MHO is that the generation field is only a DB-related item13:03
dansmithI'm not sure I can show that it's wrong, nor am I sure that it is, it just seems fundamentally wrong to assume13:03
dansmithyeah, that ^13:03
*** lindycoder has quit IRC13:04
bauzascdent: having the object incrementing it means that it would then be just an object-related item which would then create some confusion13:04
*** xyang1 has joined #openstack-nova13:04
cdentlet me try to lay it out as I understand it, and you guys can perhaps tell me that I've got it wrong, or in the process you might see that it is cool:13:04
bauzascdent: plus the fact you explictly need to obj_reset_changes() to make sure you won't trample the DB field13:04
cdentA loads a resource provider, it has a generation.13:05
cdentA has some inventory, calls set_inventory. At the end of set_inventory we validate that the (in thise case) insert of inventory was okay by comparing the generation we have with the generation in the db. If they match, we increment the generation in db.13:06
cdentAt this stage we could just stop, A has done what it wanted to do and we could require A to re-reload itself.13:06
cdentHowever as a matter of convenience since we _know_ what the generation is as far as this current interaction is concerned, we can set it on the object13:07
cdentEOF13:08
bauzascdent: what if when setting the new inventory, we just return the now-persisted generation bit13:08
*** shaohe_feng has quit IRC13:08
openstackgerritLudovic Beliveau proposed openstack/nova: Fix revert on migration with SR-IOV  https://review.openstack.org/32617413:08
openstackgerritLudovic Beliveau proposed openstack/nova: Allocate PCI devices on migration  https://review.openstack.org/32898313:08
bauzaswhich could be the same in case we have a duplication13:08
bauzasthat case, there is no need to reload it13:08
dansmithbauzas: right, that's what I'd prefer13:08
*** shaohe_feng has joined #openstack-nova13:08
cdentif there had been duplication, then set_inventory will have an exception and the transaction will rollback and A's value for generation will be what it was before. Are you saying that it should be what client B made it become?13:09
openstackgerritjichenjc proposed openstack/nova: Update stable API doc to indicate code removal  https://review.openstack.org/32706613:10
*** mdrabe has joined #openstack-nova13:10
* cdent feels like his missing something13:10
cdentbauzas: can you expand on what you mean by "which could be the same in case we have a duplication"13:11
bauzassec13:11
openstackgerritAnh Tran proposed openstack/nova: Enables Py34 tests for unit.api.openstack.compute.test_server_actions  https://review.openstack.org/32943513:13
*** diogogmt has joined #openstack-nova13:13
*** klkumar has joined #openstack-nova13:14
bauzascdent: http://paste.openstack.org/show/515981/13:16
dansmithFWIW, I really thought jaypipes said this was going to be incremented in sql13:17
cdentit _is_ incremented in sql13:18
cdenthttps://review.openstack.org/#/c/326440/15/nova/objects/resource_provider.py@12713:18
*** Dinesh_Bhor has quit IRC13:18
*** shaohe_feng has quit IRC13:18
* cdent looks at bauzas thing13:19
*** shaohe_feng has joined #openstack-nova13:19
bauzascdent: it is incremented in SQL, I agree13:19
bauzasso, why not returning that value ?13:19
*** kylek3h has joined #openstack-nova13:19
*** omnipresent has quit IRC13:20
*** dave-mccowan has joined #openstack-nova13:20
*** pilgrimstack has joined #openstack-nova13:20
*** zenoway has joined #openstack-nova13:20
dansmithcdent: you're right, I skimmed that too quickly..13:20
dansmithcdent: even more reason to do what bauzas is saying :)13:21
*** FL1SK has quit IRC13:21
* bauzas needs coffee13:21
cdentbauzas: to do the change you've just suggested would require changing the conditionals (which is not a problem), but your change is, functionally, exactly the same as mine (with some added dryness). Your queries made it sound like you wanted a db read. The reason it looks the way it does now is because jay wrote the conditionals and I added in the bumping the generation later (when I added more tests).13:22
cdent"can't we use the value in the db" is not the same as what you've suggested13:22
dansmithcdent: we want the thing we read or write from/to the database to inform the property of the object when we're done13:22
*** raildo has left #openstack-nova13:23
*** pilgrimstack has quit IRC13:24
*** amotoki has joined #openstack-nova13:24
*** zenoway has quit IRC13:25
cdentdansmith: so returning an integer from a method that is the sum of a constant and a value that's been on the object from the start counts as "being informed by the database"? (I'm referring to the paste from bauzas: http://paste.openstack.org/show/515981/ )13:25
* cdent joins bauzas at the coffee maker13:26
dansmithcdent: ah, I see your point, and why I was confused about this not being done in sql13:26
* dansmith got up at 4:45 to take his wife to the airport and has not yet had his coffee13:26
* cdent makes a cup for dan13:27
dansmithcdent: so the thing is, it's not incremented in sql right? It's incremented in python and *set* in sql13:27
bauzascdent: there is a big difference between your increment and mine13:27
openstackgerritVictor Stinner proposed openstack/nova: Port test_pipelib and test_policy to Python 3  https://review.openstack.org/32204013:28
cdentdansmith: correct13:28
bauzascdent: the one you made is done out of the transaction, and updated secondly by the object13:28
cdentbauzas: which is?13:28
*** diogogmt has quit IRC13:28
*** shaohe_feng has quit IRC13:28
cdentbauzas: that's actually on purpose, and I'll explain why after my coffee is done13:28
bauzascdent: while here, I'm assuming we call an interface which is something like UPDATE_AND_GET13:29
bauzascdent: please don't me speak about design patterns...13:29
dansmithcdent: so to my earlier point, if we're merely setting the column to $value, then returning $value from that function is indeed "returning what is in the database"13:29
bauzasdon't let* me speak13:29
*** ericksonsantos has joined #openstack-nova13:29
* cdent has coffee, reads13:30
dansmithcdent: which is good enough for me13:30
dansmithcdent: setting it to a thing in a function and then later setting it to the thing we're pretty sure that function set it to is the thing I don't like13:31
*** shaohe_feng has joined #openstack-nova13:31
cdentdansmith: okay, good, that's gets to the crux of _my_ confusion:13:31
cdent(first off I'm happy to change it, and will, so it does the dan+bauzas version of "returning what is in the db")13:32
dansmithyour confusion is that you're not sure if we want the updated value after a racing transaction?13:32
cdentbut: in what circumstance would rp.gen + 1 be different between the two calls?13:33
*** rfolco has joined #openstack-nova13:33
*** woodster_ has joined #openstack-nova13:33
cdentmy code is only reachable if the generation swap was successful13:33
dansmithcdent: at *least* in the case where this gets augmented in one place but not two later down the road13:33
dansmithyou have logic in two places.. extremely important logic13:33
*** mriedem_away is now known as mriedem13:33
cdentyeah, I get that part, which is why I'm happy to change it: bad maintenance13:34
*** Vek has quit IRC13:34
cdentbut what I'm hearing you guys suggesting is that there might actually be a chance of it being wrong, and I  want to know what that is for my edification13:34
*** lhinds_ has quit IRC13:34
dansmithcdent: no, that's why I said this above:13:34
*** erlon has joined #openstack-nova13:35
dansmith[06:03:53]  <dansmith>I'm not sure I can show that it's wrong, nor am I sure that it is, it just seems fundamentally wrong to assume13:35
*** PaulMurray has joined #openstack-nova13:35
cdentand bauzas, do you have a scenario where it can break, or is just (justifiable) caution?13:35
bauzasokay, lemme draw the end of world13:36
cdentdansmith, while bauzas is drawing that, can you tell me: a) I have to reset_changes? b) where should I do it in the new improved version?13:37
bauzascdent: so, we both agree the code section in _set_inventory() is not synchronized ? even more difficult, it's a remotable method, right?13:38
dansmithcdent: on L198?13:38
dansmithbauzas: _set_inventory() is not remotable13:38
* dansmith becomes very pedantic13:38
* cdent nods at dansmith 13:38
*** shaohe_feng has quit IRC13:38
bauzasdansmith: well, I'm blinded then by set_inventory which calls out _set_inventory13:39
*** shaohe_feng has joined #openstack-nova13:39
bauzasdansmith: because the former is said remotable13:39
dansmithcdent: yeah, obj_reset_changes() un-dirties all the fields for the caller so if they were to run obj_what_changed() on their object afterwards, it would look clean, i.e. "nothing else that needs to be saved to the db"13:39
mriedemjohnthetubaguy: -2 lifted13:40
*** smatzek has quit IRC13:40
dansmithbauzas: I know, I'm just being persnickety13:40
bauzasokay, let's be pedantic :D13:41
*** edmondsw has joined #openstack-nova13:41
*** ljxiash has joined #openstack-nova13:41
bauzasso... rp.set_inventory() is remotable and not synchronized13:41
bauzaswhich means 2 method calls would then be checking the generation bit at the same time13:42
cdentwhich is why the generation bit exists at all13:42
*** mmandel has joined #openstack-nova13:43
johnthetubaguymriedem: had a look through the specs, spotted a few out of sync and approved them13:43
*** mtanino has joined #openstack-nova13:43
mriedemthanks13:43
Prophidysmriedem, a question about this one : https://blueprints.launchpad.net/nova/+spec/purge-deleted-instances-cmd is it still relevant ? can we integrate the older-than in the archive too ? or I need to do a new blueprint ?13:43
ProphidysThe older-than is implemented in the review here : https://review.openstack.org/#/c/203751/13:44
mriedemProphidys: the purge command there is separate from the archive command13:44
Prophidysok so new blueprint :-(13:44
mriedemProphidys: older-than is not going to work well with the archive command in it's current form13:44
mriedemthe purge command only worked on instances and things that instances depend on in the schema13:45
*** eharney has joined #openstack-nova13:45
mriedemwhich is why older-than would work for instances as the target13:45
cdentbauzas?13:45
mriedemarchive does a blanket copy to shadow tables of all records in all tables until you hit max_count13:45
*** ctrath has joined #openstack-nova13:45
mriedemso older-than doesn't really make a ton of sense there13:45
dansmithmriedem: right, but people want to do that with a date range instead of a row count13:46
mriedemthe max_count thing in archive db is kind of busted in it's current form anyway in my opinion13:46
dansmithmriedem: i.e. run from cron.monthly with --older-than=60 or something, which isn't possible with max_rows13:46
*** fifieldt has joined #openstack-nova13:47
mriedemalright, go for it13:47
Prophidysmriedem, we can implement a older-than in archive too I think, we just do it for the instances table and after we get all dependencies from this subset13:47
Prophidysmriedem, thank you13:48
mriedemProphidys: i'm not sure i'd like that13:48
mriedemit changes the behavior of archive depending on which thing you're using, date range or max_rows13:48
bauzascdent: sorry had to do something else13:48
mriedemif you're going to just archive instances and it's dependencies, i think i'd rather see a new command rather than munge that into the archive cmd we have today13:48
bauzasyeah, so you understand why I don't really like updating the generation field by the object ? because it's something incremented by the API DB rather13:48
bauzaswhich could be out of that service13:49
bauzasoops13:49
dansmithmriedem: because current archive hits more than instances?13:49
*** shaohe_feng has quit IRC13:49
mriedemdansmith: yes, it hits everything13:49
mriedemuntil max_count13:49
mriedemor whatever13:49
dansmithmriedem: which makes it even less useful13:49
Prophidysyeah the max_count sucks it can create inconsistencies13:49
mriedemthe max-rows thing is already busted13:49
*** shaohe_feng has joined #openstack-nova13:49
mriedemi agree there13:49
dansmithmriedem: can we call that a bug and fix it with a new command? :P13:50
Prophidysdansmith, +213:50
*** burt has joined #openstack-nova13:50
Prophidys:-)13:50
ProphidysWe can do it in 2 step13:50
*** EinstCrazy has joined #openstack-nova13:50
Prophidyscreate an exclusive option --older-than=X (we can't use --max-rows and --older-than at the same time)13:51
Prophidysolder-than do it the clean way13:51
cdentbauzas: yeah, I think we've resolved that _increment... should return the new generation, for sake of better maintenance13:51
Prophidysand after that we deprecate --max-rows13:51
mriedemProphidys: but is older-than only on instances and it's deps or everything13:51
mriedem?13:51
mriedembecause if it's only instances, how do you archive block_device_mappings for instance?13:52
Prophidysinstances and it's deps include everything no ?13:52
dansmithProphidys: well, I think he's saying a new command like archive_instances that is specifically targeted at instances, and add --older-than to that13:52
mriedemyes, that13:52
*** ptm_away has joined #openstack-nova13:52
dansmithmriedem: instance and its deps13:52
mriedemwhich is what the purge command was going to be13:52
johnthetubaguyyeah, that sounds like what folks are wanting13:52
*** zenoway has joined #openstack-nova13:53
mriedemyou can still end up with other cruft13:53
dansmithProphidys: you don't care if they're archived or purged, you just want them out of the main db right?13:53
dansmithwhich I think is what most people want13:53
mriedembut i guess that's what the archive command would be used to cleanup then - for everything else13:53
openstackgerritChris Dent proposed openstack/nova: Add delete_, update_ and add_ inventory to ResourceProvider  https://review.openstack.org/32827613:53
openstackgerritChris Dent proposed openstack/nova: Add support for resource inventories to placement API  https://review.openstack.org/32915213:53
openstackgerritChris Dent proposed openstack/nova: Add a ResourceProviderList object  https://review.openstack.org/32830713:53
openstackgerritChris Dent proposed openstack/nova: Add set_inventory() method on ResourceProvider  https://review.openstack.org/32644013:53
*** ptm_away is now known as PaulMurray_13:53
openstackgerritChris Dent proposed openstack/nova: Add initial framing of placement API  https://review.openstack.org/32914913:53
openstackgerritChris Dent proposed openstack/nova: Add support for resource_providers urls  https://review.openstack.org/32915113:53
openstackgerritChris Dent proposed openstack/nova: Add microversion support for the placement API  https://review.openstack.org/32915013:53
openstackgerritChris Dent proposed openstack/nova: WIP experiment with the remainder of the placement API  https://review.openstack.org/29310413:53
johnthetubaguymriedem: yeah, it could do the non-instance stuff13:53
Prophidysdansmith, right13:54
*** sameo has joined #openstack-nova13:54
cdentbauzas, dansmith is https://review.openstack.org/#/c/326440/ now more like you would prefer?13:54
mriedemProphidys: sounds like you just want to work on the purge command then13:54
Prophidysthe archived thing can be good to debug, but in fact I want a production DB clean to read13:54
dansmithmriedem: the existing archive command would break the new instance-targeted one right? because it's going to delete things that --older-than would have left13:54
mriedemwhich already had an approved spec in mitaka13:54
cdentdansmith, bauzas: I've left the module methods in place for the time being as that's the precedent that jay set when he initially wrote the stuff. maybe he'll jump in at some point.13:55
mriedemdansmith: yeah13:55
dansmithProphidys: do you want to pick up that purge patch?13:55
mriedemwell, 'break' depends on usage13:55
*** PaulMurray has quit IRC13:55
mriedemBroken as  a Service?13:55
dansmithmriedem: "could break" by deleting BDMs before the instance is set to actually go13:55
PaulMurray_Live migration meeting in 5 mins on #openstack-meeting-3 PaulMurray paul-carlton2 eliqiao shaohe_feng pkoniszewski jlanoux yuntongjin mdbooth kashyap kmartin claudiub tobasco tdurakov andreas_s abhishekk diana_clarke13:55
mriedemdansmith: archive would still archive the instances first13:55
mriedemunless it was changed13:55
*** cdelatte has joined #openstack-nova13:56
dansmithmriedem: purge deletes straight from the main db right?13:56
mriedemyes13:56
*** irenab has quit IRC13:56
dansmithmriedem: if we had an archive_instances, and you used the existing archive command with it, it might archive BDM rows that belong to instances that haven't been archived, is my point13:56
dansmithbut focusing on purge would be better all around, IMHO13:56
ProphidysOk I start with the purge command13:57
dansmithmriedem: I guess we're past the point of resurrecting previously approved specs, but this seems important and out-of-the-critical-path enough to want to capitalize on Prophidys' interest...13:57
*** shaohe_feng has quit IRC13:59
ProphidysIf you want my vision, I think a unified command to archive and purge when it's archived should be perfect (like archive every day, and purge archive older than X days)13:59
mriedemProphidys: if you can re-propose the spec for newton i think we can give it an exception to resurrect the bp13:59
openstackgerritGergely Csatari proposed openstack/nova: api-ref: console types.  https://review.openstack.org/32946213:59
dansmithProphidys: start with instance-focused purge-only and then expand from there I think14:00
*** shaohe_feng has joined #openstack-nova14:00
Prophidysdansmith, mriedem ok I start with that14:00
dansmithProphidys: I think most people would like to see the shadow tables go away, so the archive option should be a discussion for later14:00
Prophidysperfect14:00
*** vnogin has joined #openstack-nova14:01
Prophidysmriedem, dansmith thank you for your time14:02
*** PaulMurray_ has quit IRC14:02
*** PaulMurray has joined #openstack-nova14:02
dansmithProphidys: thanks for wanting to work on this.. it's been neglected for too long14:02
*** burgerk has joined #openstack-nova14:02
*** smatzek has joined #openstack-nova14:03
*** zz_dimtruck is now known as dimtruck14:03
*** jaosorior has quit IRC14:05
*** cfriesen has joined #openstack-nova14:06
openstackgerritSudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor  https://review.openstack.org/26677314:07
*** sudipto has joined #openstack-nova14:07
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c  https://review.openstack.org/30334514:08
openstackgerritTimofey Durakov proposed openstack/nova: [dnm] nfs fix for xenial  https://review.openstack.org/32946614:09
*** shaohe_feng has quit IRC14:09
*** lucas___ has joined #openstack-nova14:10
*** roeyc has quit IRC14:10
openstackgerritMatt Riedemann proposed openstack/nova: Skip NFS and Ceph in live migration job test run  https://review.openstack.org/32788614:11
mriedemjohnthetubaguy: ^14:11
openstackgerritJohn Garbutt proposed openstack/nova: WIP: split allocate_for_instance to update + create  https://review.openstack.org/32896614:11
dansmithjohnthetubaguy: oooh14:12
* dansmith hands johnthetubaguy a cookie14:12
*** ducttape_ has joined #openstack-nova14:12
*** shaohe_feng has joined #openstack-nova14:12
*** MikeG451_ has joined #openstack-nova14:12
*** ducttape_ has quit IRC14:12
*** ducttape_ has joined #openstack-nova14:13
johnthetubaguydansmith: yeah, there is some stuff up there that shuffles things around, slowly getting somewhere ish, that last patch looks like a monkey bashing a keyboard right now, but fixing that14:13
*** mrkz has joined #openstack-nova14:13
dansmithjohnthetubaguy: hah, well, cool14:13
mriedemi would selfishly like the get me a network stuff to get in before that code is all ripped apart14:14
*** links has quit IRC14:14
johnthetubaguymriedem: given how much some folks are kicking and screaming about that, I wouldn't be against that14:15
*** roeyc has joined #openstack-nova14:15
mriedemthe changes aren't all that big, but there are changes in validate_networks and allocate_for_instance flows in that series14:15
openstackgerritMaciej Szankin proposed openstack/nova: config options: improve help for noVNC  https://review.openstack.org/31945314:16
*** ratailor has quit IRC14:17
mriedemhttps://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/get-me-a-network+status:open14:17
mriedemi also have the tempest test running against that series now14:17
*** prateek has quit IRC14:19
*** rlrossit has joined #openstack-nova14:19
*** shaohe_feng has quit IRC14:20
*** vladikr has joined #openstack-nova14:21
*** EinstCrazy has quit IRC14:21
rlrossitgibi: I have way too many meetings today, and I haven't done any reviews since last week's meeting, so I'll be missing out on the notifications meeting today14:22
rlrossitI have to catch up from being out Friday & Monday14:22
openstackgerritPushkar Umaranikar proposed openstack/nova: Transform instance.suspend notifications  https://review.openstack.org/32908914:22
*** haypo has joined #openstack-nova14:22
haypohello. i recently wrote https://review.openstack.org/#/c/322040/ a simple python3 fix which was approved but failed to merge because of a conflict. i fixed the conflict the day after and now it's waiting again for your review!14:23
haypo(approval)14:23
haypoi plan to split dims two giant patches into smaller patches, easier to review14:24
*** mnestratov has joined #openstack-nova14:24
*** shaohe_feng has joined #openstack-nova14:24
mriedemgmann: yup, +2 on https://review.openstack.org/#/c/328931/ now - nice work14:28
*** ctrath has quit IRC14:29
*** shaohe_feng has quit IRC14:30
*** shaohe_feng has joined #openstack-nova14:30
*** adisky has quit IRC14:30
openstackgerritSergey Nikitin proposed openstack/nova: api-ref: added docs for microversion 2.26  https://review.openstack.org/32708914:30
openstackgerritSergey Nikitin proposed openstack/nova: Added missed response to test_server_tags  https://review.openstack.org/32708814:30
*** mriedem1 has joined #openstack-nova14:31
*** ctrath has joined #openstack-nova14:31
mriedem1pretty easy +W https://review.openstack.org/#/c/328931/14:32
*** mriedem has quit IRC14:33
*** bzurawski has joined #openstack-nova14:33
bzurawskiHello14:33
*** kaisers has joined #openstack-nova14:33
bzurawskiI have a question about rate limit in openstack14:34
bzurawskibecuase i can't find any API rate limit mechanism, is it deprecated, or implemented in other way ?14:34
*** sree has quit IRC14:35
*** Hosam has joined #openstack-nova14:35
*** ayoung has joined #openstack-nova14:36
mriedem1bzurawski: there was a rate limit option in the v2 api but that's not in v2.114:36
gibirlrossit: thanks for the heads up, I think your reviews is a lot more important than being present on the meeting. :)14:36
*** tanee is now known as tanee_away14:37
*** rfolco has quit IRC14:37
bzurawskimriedem1: oki, and is there other way of limitation HTTP requests, or it's completly depracted with v2.114:37
bzurawski?14:37
mriedem1bzurawski: it's a good question which i don't have the answer for, the config options docs aren't helpful14:38
mriedem1(BoolOpt) Whether to use per-user rate limiting for the api. This option  is only used by v2 api. Rate limiting is removed from v2.1 api.14:38
*** jwcroppe_ has joined #openstack-nova14:39
mriedem1sdague: oomichi: gmann: alex_xu: ^ any more details?14:39
*** shaohe_feng has quit IRC14:40
*** BjoernT has joined #openstack-nova14:40
sdaguebzurawski: it's gone entirely14:40
*** snikitin_ has joined #openstack-nova14:40
sdaguethe in tree solution didn't work the moment you had > 1 api server14:41
*** shaohe_feng has joined #openstack-nova14:41
sdaguebecause rate limiting was per api server14:41
*** jwcroppe has quit IRC14:41
sdaguethis is something which needs a dedicated solution that synchronizes the metrics across all your api servers14:41
*** mdrabe has quit IRC14:42
*** tanee_away is now known as tanee14:43
bzurawskisdague: oki, so let's say that i want to put some limitations on HTTP requests because clients is making to many of them, is there any way or something that allow me to do it in v2.114:44
bzurawski?14:44
*** pacoblox has joined #openstack-nova14:44
bzurawskisdague: because i'm looking now at api/openstack/compute/limits.py14:44
bzurawskisdague: aaa, no, it's not for what i want, sorry :)14:45
sdaguebzurawski: there is nothing in tree14:45
*** jwcroppe_ has quit IRC14:45
*** eharney has quit IRC14:45
*** rfolco has joined #openstack-nova14:46
sdaguethere was a general community discussion around this at least a year ago that the current rate limitting mechanism was broken by design, so had no value to move forward14:46
mriedem1bzurawski: probably a good question for the #openstack-operators channel or mailing list to see what others are using14:46
bzurawskimriedem1: oki, will do that14:46
bzurawskimriedem1: sdague thanks for your help :)14:47
*** jwcroppe_ has joined #openstack-nova14:47
sdaguebzurawski: this would definitely be a really good thing to exist in OpenStack wide14:47
mriedem1we should probably update the config option docs for api_rate_limit=False14:47
sdagueit should be generalized beyond nova, work as a paste middleware, and have some memcache server or something to do counting14:47
mriedem1i.e. this is gone in v2.1 and there is no in-tree replacement14:47
sdaguemriedem1: yeh, probably14:47
mriedem1sdague: i can try to wordsmith that quick14:48
bzurawskisdague: totally agree14:48
*** artom has quit IRC14:49
bzurawskisdague: i have done it like you said with memcache and middleware for v214:49
bzurawskibut if in v2.1 rate limiting is gone, that it's not useful in master :P14:49
sdaguebzurawski: ok, well, middleware can reject the requests before they even get there14:49
sdaguenova shouldn't actually know anything about rate limitting14:50
*** artom has joined #openstack-nova14:50
bzurawskisdague: why ?14:50
*** jwcroppe has joined #openstack-nova14:50
*** shaohe_feng has quit IRC14:50
sdaguebecause these should be url based limits before you effectively get to any of the nova logic14:50
sdaguethe old solution worked this way14:51
tdurakovsdague: hi, have you seen https://review.openstack.org/#/c/329483/114:51
*** shaohe_feng has joined #openstack-nova14:51
sdaguetdurakov: +214:51
*** jwcroppe_ has quit IRC14:52
*** klkumar has quit IRC14:52
*** rrecio has joined #openstack-nova14:54
tdurakovmriedem1: could we merge this^14:54
*** klkumar has joined #openstack-nova14:54
*** rrecio_ has joined #openstack-nova14:54
bzurawskisdague: hmm, so maybe it's good moment to talk about this limitations on some meeting, what you think ?14:55
bzurawskibecause such mechanism, would be really helpful, if it will exist14:55
sdaguebzurawski: https://github.com/openstack/nova/blob/c8ec9ebf379c61d73c5671a75dd2a4e4ae1403fb/nova/api/openstack/compute/legacy_v2/limits.py#L258 - when that rate limitting middleware is in place, it does an early wsgi fault return super early14:55
sdaguebzurawski: I 100% agree that something like this should exist14:55
sdaguebut it can be like the CORS work, middleware that's entirely independent of any project14:55
*** amotoki has quit IRC14:55
*** eharney has joined #openstack-nova14:56
sdagueoh, sorry, it's actually even worse than per server14:56
sdagueit's actually per process14:56
sdagueso you will end up hitting rate limits randomly between x and Nx (where N is the number of api worker processes) that you have14:57
*** rrecio has quit IRC14:58
sdaguebzurawski: is your concern that the values for rates aren't stored in Nova's db any more?14:58
*** sacharya has joined #openstack-nova14:58
*** mdrabe has joined #openstack-nova14:58
sdaguebecause if you have a working middleware stack, that shouldn't really change here14:58
*** diga has joined #openstack-nova14:59
*** gjayavelu has joined #openstack-nova15:00
*** jwcroppe has quit IRC15:00
*** shaohe_feng has quit IRC15:01
*** sacharya_ has joined #openstack-nova15:01
*** jwcroppe has joined #openstack-nova15:01
*** jwcroppe_ has joined #openstack-nova15:01
*** shaohe_feng has joined #openstack-nova15:01
*** pacoblox1 has joined #openstack-nova15:02
*** siva_krishnan has joined #openstack-nova15:02
*** MarcF has joined #openstack-nova15:03
luis5tbHi danpb. I found what it could be a bug into the live migration monitoring function (https://bugs.launchpad.net/nova/+bug/1591240)15:03
openstackLaunchpad bug 1591240 in OpenStack Compute (nova) "progress_watermark is not updated" [Undecided,New]15:03
*** MarcF has quit IRC15:03
*** sacharya has quit IRC15:04
luis5tbbasically, if the first time it goes inside the if block, progress_watermark is initialized to 0, then it will not enter in the block anymore, and progress_watermark will not be updated15:04
*** roeyc has quit IRC15:04
*** itamarl has quit IRC15:04
*** gagehugo has joined #openstack-nova15:04
*** ssurana has joined #openstack-nova15:04
luis5tbwhich leads to trigger live-migration aborts even if progress is being made15:04
*** gjayavelu has quit IRC15:05
doffmmdbooth: Thanks for review. Have abandoned my competing RBD cleanup rescue images fix.15:05
*** jwcroppe has quit IRC15:05
*** yamahata has joined #openstack-nova15:05
*** pacoblox has quit IRC15:05
*** PaulMurray has quit IRC15:06
tdurakovPaulMurray, mriedem1, johnthetubaguy:  looks like nfs is fixed http://logs.openstack.org/66/329466/1/experimental/gate-tempest-dsvm-multinode-live-migration/e6b6e45/console.html#_2016-06-14_14_48_28_37215:06
mdboothdoffm: Sorry about that :/ Wish these things were easier to notice.15:06
mriedem1tdurakov: ok, setup passed, one of the tests failed15:07
*** Jeffrey4l has quit IRC15:07
*** zenoway has quit IRC15:07
tdurakovmriedem1: yup15:07
johnthetubaguytdurakov: ah, but it did fail I guess?15:07
siva_krishnanHi All! I have not been able to restart n-api service  in devstack after I pulled this change https://review.openstack.org/#/c/280851/9. Has anyone faced similar issue ?15:08
tdurakovjohnthetubaguy, mriedem1 one of tests, as http://logs.openstack.org/66/329466/1/experimental/gate-tempest-dsvm-multinode-live-migration/e6b6e45/console.html#_2016-06-14_14_49_08_309 is passed i think it shouldn't be connected to nfs at all15:08
*** fifieldt has quit IRC15:08
mriedem1tdurakov: yeah...15:08
johnthetubaguyyeah, looks like it could be the general issue?15:09
doffmmdbooth: Its OK, glad the new patch looks better.15:09
mriedem1tdurakov: want to update your patch to close bug 1590929 ?15:09
openstackbug 1590929 in OpenStack Compute (nova) "gate-tempest-dsvm-multinode-live-migration fails NFS setup on ubuntu 16.04 nodes" [Medium,Confirmed] https://launchpad.net/bugs/159092915:09
*** pacoblox1 has quit IRC15:09
tdurakovsure, btw it will break this for trusty I guess15:10
tdurakovis it ok?15:10
tdurakovor should we check ubuntu version?15:10
tdurakovmriedem1: ^15:10
*** shaohe_feng has quit IRC15:11
*** pradk has quit IRC15:11
dansmithmriedem1: shouldn't we be good on the network request tuple deal at this point? or are there still things passing tuples?15:11
*** rcernin has quit IRC15:11
mriedem1dansmith: there might still be things15:11
*** jwcroppe has joined #openstack-nova15:11
mriedem1dansmith: https://review.openstack.org/#/c/309574/16/nova/network/neutronv2/api.py is checking for None15:11
mriedem1because that's what the code was checking before15:11
*** shaohe_feng has joined #openstack-nova15:11
*** mmandel has quit IRC15:12
dansmithmriedem1: why change it? I thought you changed it because you moved the objectification above15:12
*** tbachman has quit IRC15:12
*** snikitin_ has quit IRC15:12
dansmithmriedem1: and does the former mean you know there are places, or you're just being defensive instead of checking?15:12
mriedem1i could make it check is None again15:12
bzurawskisdague: there is oslo.middleware, so maybe it can be used for rate limits ?15:12
*** jwcroppe_ has quit IRC15:13
*** pacoblox has joined #openstack-nova15:13
mriedem1dansmith: i think there are places, it's been awhile since i've looked for sure, and in meetings all morning15:13
bzurawskisdague: how CORS works, it's separate module so nova doesn't know about it ?15:13
dansmithmriedem1: okay15:13
mriedem1dansmith: i think it's a matter of compute rpc api15:13
mriedem1not being a minimum to send the object list15:13
*** edand has quit IRC15:13
dansmithmriedem1: ah, okay, maybe15:13
dansmithfeels like it's been a long time, so I'm surprised, but...maybe15:14
sdaguebzurawski: api-paste.ini pipelines as just stacks of modules15:14
sdaguebzurawski: they don't have to all be in the nova tree15:14
mriedem1bzurawski: fyi http://lists.openstack.org/pipermail/openstack-operators/2016-June/010692.html15:14
*** pece has quit IRC15:15
*** abalutoiu has quit IRC15:15
*** ssurana has quit IRC15:15
bzurawskimriedem1: thanks :)15:16
openstackgerritMoshe Levi proposed openstack/nova: Update available resources before confirm stage  https://review.openstack.org/32735615:17
mriedem1sdague: heh, actually, since the legacy_v2 code is removed, api_rate_limit config option isn't used anywhere, so i guess i'll just remove that too...15:17
sdaguemriedem1: yeh, I was wondering that15:18
*** Vek has joined #openstack-nova15:18
*** jlanoux has quit IRC15:18
mriedem1i'll just remove it quick15:18
*** pilgrimstack has joined #openstack-nova15:18
openstackgerritSivasathurappan Radhakrishnan proposed openstack/nova: Help text for the mks options  https://review.openstack.org/32360815:19
bzurawskisdague: so basically this rate limitation could be putted into oslo.middleware (code) and putted into api-paste.ini (pipeline)15:19
*** zenoway has joined #openstack-nova15:19
sdaguebzurawski: sure, or even some other library15:19
*** FL1SK has joined #openstack-nova15:20
*** shaohe_feng has quit IRC15:21
*** paul-carlton2 has quit IRC15:22
*** jaugustine has joined #openstack-nova15:22
openstackgerritSujitha proposed openstack/nova: Improve help text for glance options  https://review.openstack.org/32400715:22
*** jaugustine has quit IRC15:23
*** pilgrimstack has quit IRC15:24
*** shaohe_feng has joined #openstack-nova15:24
*** stewie925 has joined #openstack-nova15:24
mriedem1sdague: the change that removed the usage of api_rate_limit has a general reno on removing the legacy v2 api code https://review.openstack.org/#/c/312314/6/releasenotes/notes/remove-legacy-v2-api-7ac6d74edaedf011.yaml15:25
*** salv-orlando has quit IRC15:25
mriedem1so i'm not sure we need a reno for actually removing the option, but maybe?15:25
mriedem1just to say it's removed and was broken anyway15:25
sdaguemriedem1: what's the commit look like where it defaults to false?15:25
*** salv-orlando has joined #openstack-nova15:26
mriedem1i'll have to look it up, it's probably old15:26
sdaguethe conversation was really around when it was set to false15:26
sdaguethat's when we decided the code was basically useless15:27
*** rrecio_ has quit IRC15:27
*** rrecio has joined #openstack-nova15:27
mriedem1sdague: https://review.openstack.org/#/c/34821/15:28
bzurawskisdague: mriedem1 do you think that is worth broach this subject on some meeting ?15:28
mriedem1DocImpact15:28
*** chandankumar has joined #openstack-nova15:28
mriedem1which means no docs15:28
mriedem1sdague: but it was made false in havana15:28
mriedem1so pretty damn old15:28
mriedem1and nothing in the havana release notes https://wiki.openstack.org/wiki/ReleaseNotes/Havana15:29
mriedem1so maybe just a reno in the 'other' section15:29
sdaguebzurawski: what meeting do you think it would be effective to bring up in?15:29
*** salv-orlando has quit IRC15:30
openstackgerritSujitha proposed openstack/nova: Improve help text for floating ips options.  https://review.openstack.org/31830915:30
*** salv-orlando has joined #openstack-nova15:30
mriedem1i.e. 'the option was disabled by default in havana, it didn't work if api servers > 1, and is no longer used now that the legacy v2 api code is gone'15:30
*** diga has quit IRC15:30
*** tongli has joined #openstack-nova15:31
sdaguemriedem1: it's actually worse than that15:31
sdagueit doesn't work consistently if you have > 1 api worker15:31
sdaguebecause it's an in process counter15:31
*** shaohe_feng has quit IRC15:31
*** artom_ has joined #openstack-nova15:31
mriedem1so, how about, it was just broken15:32
mriedem1disabled in havana15:32
*** artom has quit IRC15:32
mriedem1and now removed15:32
sdagueyeh15:32
*** shaohe_feng has joined #openstack-nova15:32
sdagueI'm grinding on some unit tests, I'll put something up after that15:32
mdboothIt looks to me like the libvirt driver calculates disk overcommit for file-backed disks using file size rather than allocated size15:32
mdboothWhich would defeat the point of calculating it, right?15:33
*** liverpooler has quit IRC15:34
*** mmandel has joined #openstack-nova15:34
mdboothUnless it's not sparse. I guess that would be ok for non-metadata-preallocated qcow2 disks15:35
mdboothBut not for metadata-preallocated qcow2 disks, or flat disks15:35
*** ctrath has left #openstack-nova15:35
*** ctrath has joined #openstack-nova15:36
*** lucas___ has quit IRC15:38
*** permalac has joined #openstack-nova15:38
*** lucas___ has joined #openstack-nova15:38
*** gjayavelu has joined #openstack-nova15:38
*** chandankumar has quit IRC15:40
*** shaohe_feng has quit IRC15:42
*** shaohe_feng has joined #openstack-nova15:43
*** lucas____ has joined #openstack-nova15:43
*** lucas___ has quit IRC15:43
*** delattec has joined #openstack-nova15:44
mriedem1sdague: i was going to put up the removal patch, just testing it now15:44
*** jdillaman has quit IRC15:44
sdaguemriedem1: ok, cool15:46
sdagueI'm close to this disk config extension fold working15:46
*** cdelatte has quit IRC15:47
*** lucas____ has quit IRC15:47
*** ssurana has joined #openstack-nova15:48
*** ssurana has quit IRC15:48
*** gjayavelu has quit IRC15:48
mriedem1sdague: ok, track it against https://blueprints.launchpad.net/nova/+spec/api-no-more-extensions please15:48
sdagueyep15:49
*** delattec has quit IRC15:51
*** jlanoux has joined #openstack-nova15:52
openstackgerritMichael Turek proposed openstack/nova: Ironic: use portgroups  https://review.openstack.org/20616315:52
*** shaohe_feng has quit IRC15:52
*** gjayavelu has joined #openstack-nova15:52
*** shaohe_feng has joined #openstack-nova15:53
*** andreas_s has quit IRC15:53
*** artom_ has quit IRC15:53
*** delattec has joined #openstack-nova15:53
openstackgerritMoshe Levi proposed openstack/nova-specs: User-controlled SR-IOV ports allocation  https://review.openstack.org/18224215:53
*** jwcroppe_ has joined #openstack-nova15:54
*** MikeG451_ has quit IRC15:55
*** jwcroppe has quit IRC15:55
*** gcb has quit IRC15:55
*** gcb has joined #openstack-nova15:56
openstackgerritLudovic Beliveau proposed openstack/nova: Fix revert on migration with SR-IOV  https://review.openstack.org/32617415:57
openstackgerritLudovic Beliveau proposed openstack/nova: Allocate PCI devices on migration  https://review.openstack.org/32898315:57
openstackgerritLudovic Beliveau proposed openstack/nova: Update binding:profile for SR-IOV ports  https://review.openstack.org/24257315:57
*** ivase has quit IRC15:58
*** yassine has quit IRC15:58
dansmithcdent: can you address these things quickly? https://review.openstack.org/#/c/326440/1715:58
dansmithif not, I'll do it15:58
*** artom has joined #openstack-nova15:58
*** jaypipes has joined #openstack-nova15:59
cdentdansmith: I can do it, within about an hour15:59
dansmithcdent: okay15:59
*** PaulMurray has joined #openstack-nova15:59
cdentneed to flush a bit of state, but I have that branch in disarray at the moment, so better it be me16:00
*** ivase has joined #openstack-nova16:00
dansmithok16:00
cdentcomments makes sense though, I can do that16:00
openstackgerritAndrey Volkov proposed openstack/nova: Make instance as second arg in compute api calls  https://review.openstack.org/32771316:00
dansmithcool16:01
*** thorst is now known as thorst_afk16:01
*** hemnafk is now known as hemna16:02
*** shaohe_feng has quit IRC16:02
*** shaohe_feng has joined #openstack-nova16:03
*** ivase has quit IRC16:03
openstackgerritmelanie witt proposed openstack/nova: Disallow instance tag set for invalid instance states  https://review.openstack.org/32930416:03
*** matrohon has quit IRC16:04
*** ljxiash has quit IRC16:05
openstackgerritBalazs Gibizer proposed openstack/nova: Transform instance.update notification  https://review.openstack.org/32592316:05
*** raunak has joined #openstack-nova16:05
*** vtech has quit IRC16:05
*** mpavone has quit IRC16:06
*** MikeG451_ has joined #openstack-nova16:06
*** jaugustine has joined #openstack-nova16:08
*** gjayavelu has quit IRC16:08
openstackgerritSergey Nikitin proposed openstack/nova: api-ref: added docs for microversion 2.26  https://review.openstack.org/32708916:08
openstackgerritAnusha Unnam proposed openstack/nova: Transform instance.resize notifications  https://review.openstack.org/32925516:09
*** raunak has quit IRC16:10
*** xyang1 has quit IRC16:10
*** ivase has joined #openstack-nova16:10
*** ijw has joined #openstack-nova16:11
pkholkinbauzas: Hi Sylvain, thank you very much for v2.28 novaclient patch!16:12
*** lucas___ has joined #openstack-nova16:12
bauzaspkholkin: np16:12
*** shaohe_feng has quit IRC16:12
pkholkinbauzas: I returned too late to do smth :)16:12
*** raunak has joined #openstack-nova16:12
*** gjayavelu has joined #openstack-nova16:13
*** xyang1 has joined #openstack-nova16:13
*** sridharg has quit IRC16:13
bauzasI still need to write my own 2.29 and 2.30 patches :)16:13
*** shaohe_feng has joined #openstack-nova16:13
*** rlrossit has quit IRC16:13
*** ctrath has quit IRC16:13
pkholkinbauzas: as I understand flatten_dict is not needed for 2.28 but is needed for older versions, so it you decided not to change anything here?16:14
dimshaypo : ack. thanks16:14
*** efoley has joined #openstack-nova16:14
*** yamahata has quit IRC16:14
*** ivase has quit IRC16:15
*** mriedem has joined #openstack-nova16:15
*** gjayavelu has quit IRC16:15
*** gjayavelu has joined #openstack-nova16:15
*** permalac has quit IRC16:16
*** ctrath has joined #openstack-nova16:16
*** Apoorva has joined #openstack-nova16:16
*** anush__ has joined #openstack-nova16:16
openstackgerritSean Dague proposed openstack/nova: Tear down os-disk-config part 1  https://review.openstack.org/32718816:16
openstackgerritSean Dague proposed openstack/nova: Tear down of os-disk-config part 2  https://review.openstack.org/32954916:16
*** lucas___ has quit IRC16:17
*** Apoorva has quit IRC16:17
*** rlrossit has joined #openstack-nova16:17
*** rlrossit has quit IRC16:17
*** rlrossit has joined #openstack-nova16:17
*** yamahata has joined #openstack-nova16:18
*** Apoorva has joined #openstack-nova16:18
*** jaugustine has quit IRC16:18
*** mriedem1 has quit IRC16:18
*** lucas___ has joined #openstack-nova16:18
bzurawskisdague: this one https://wiki.openstack.org/wiki/Meetings/Nova16:19
*** lucas___ has quit IRC16:19
*** lucas___ has joined #openstack-nova16:19
bzurawskisdague: i'm do not know exactly what is happening at such meetings, so i can be wrong :)16:19
sdaguebzurawski: sure, we could add it there. What kind of outcome are you looking for16:19
bzurawskioutcome you mean what i want to achive on this meeting ?16:20
bzurawskisdague: ^16:21
sdaguebzurawski: yeh, because knowing what you are hoping to acheive would be useful in figuring out what the right audience for the conversation16:21
mriedembzurawski: i recommend reading that operators thread i started, there have already been several replies16:22
mriedemon the api rate limiting topic16:22
*** shaohe_feng has quit IRC16:23
sdagueI also put it into a more general conversation for one of the upcoming TC meetings, but that would be mostly about finding like minded folks16:23
*** shaohe_feng has joined #openstack-nova16:23
openstackgerritMatt Riedemann proposed openstack/nova: Remove api_rate_limit config option  https://review.openstack.org/32955416:24
bzurawskisdague: i just want to know what other developers thinking about it, and maybe after that is it worth it to create blueprint for such feature ?16:24
bzurawskimriedem: yep, i've read this16:24
sdaguebzurawski: right, well it definitely wouldn't be in Nova16:25
bzurawskisdague: aaaa, you're right :/16:25
bzurawskiit's oslo at least, oki, sorry my mistake :)16:25
sdagueI think the ops mailing list is most likely discussion forum right now to find the right like minded folks16:25
bzurawskisdague: oki, will use it in first step :)16:26
bzurawskisdague: mriedem thanks for your help and support :)16:26
auggygood morning!16:27
*** daemontool has quit IRC16:28
*** daemontool has joined #openstack-nova16:29
*** clenimar has joined #openstack-nova16:29
snetiHi all, I'm facing issue with restarting nova services. Getting error: TypeError: __init__() got an unexpected keyword argument 'restart_method' in n-api and ValueError: invalid limits: cpu_time16:29
sneti in n-cpu. Anybody facing this issue?16:29
*** vtech has joined #openstack-nova16:29
mriedemsneti: you need the latest oslo.concurrency16:29
mriedemsneti: are you on mitaka or master?16:29
snetimriedem, I'm on master16:30
mriedemok, update oslo.concurrency16:30
mriedemto 1.8.016:30
mriedemsorry, 3.8.016:30
snetimriedem, thank you!! will try that16:30
*** zenoway has quit IRC16:31
*** Sukhdev has joined #openstack-nova16:31
*** zenoway has joined #openstack-nova16:31
mriedemjohnthetubaguy: live migration job passed after skipping nfs and ceph16:31
mriedemhttp://logs.openstack.org/86/327886/3/experimental/gate-tempest-dsvm-multinode-live-migration/475fbc3/console.html16:31
mriedemtdurakov: ^16:32
mriedemso i'm not sure if we should enable nfs again now or not, we should probably at least check on the failure in tdurakov's test run first16:32
tdurakovmriedem: could we confirm that without nfs and ceph job become stable on 16.04?16:33
*** shaohe_feng has quit IRC16:33
*** gszasz has quit IRC16:33
*** ijw has quit IRC16:33
*** anush__ has quit IRC16:33
tdurakovI mean is it stable, or we are just lucky once16:34
*** shaohe_feng has joined #openstack-nova16:34
*** nkrinner is now known as nkrinner_afk16:34
*** anush__ has joined #openstack-nova16:34
*** jaypipes has quit IRC16:35
*** ijw has joined #openstack-nova16:35
*** fragatina has joined #openstack-nova16:36
*** zenoway has quit IRC16:36
*** jlanoux has quit IRC16:36
*** fragatin_ has joined #openstack-nova16:36
*** moshele has quit IRC16:38
*** anush__ has quit IRC16:38
*** tongli has quit IRC16:39
*** fragatina has quit IRC16:40
*** daemontool has quit IRC16:43
*** tesseract has quit IRC16:43
*** shaohe_feng has quit IRC16:43
*** diga has joined #openstack-nova16:43
*** sfinucan has quit IRC16:44
*** shaohe_feng has joined #openstack-nova16:44
openstackgerritSarafraj Singh proposed openstack/nova: Adding details in general purpose feature matrix [1]  https://review.openstack.org/32732616:44
mriedemtdurakov: i don't think we'll know until we get some runs w/o nfs and ceph16:45
mriedemtdurakov: so i think we should probably merge my patch to skip nfs/ceph, let that run for a few days and see if we're hitting the same failures as before16:45
*** ssurana has joined #openstack-nova16:46
tdurakovmriedem: agree, let's gather some stats16:46
*** mvk has quit IRC16:47
tdurakovThan will enable other backends step by step16:47
mriedemtdurakov: find me a +W for this then :) https://review.openstack.org/#/c/327886/16:48
*** wanghao has quit IRC16:49
*** salv-orlando has quit IRC16:49
*** wanghao has joined #openstack-nova16:49
*** salv-orlando has joined #openstack-nova16:50
*** ijw has quit IRC16:50
*** danpb has quit IRC16:50
gibizhs: hi! I answered you question in https://review.openstack.org/#/c/313654/ Could you check it please?16:51
*** Daisy has joined #openstack-nova16:52
*** gjayavelu has quit IRC16:52
tdurakovmriedem: left comment16:53
*** shaohe_feng has quit IRC16:53
tdurakov+116:54
mriedemdansmith: sdague: want to +W this in so we can start seeing how stable the live migration job is with the basic config? https://review.openstack.org/#/c/327886/16:54
*** shaohe_feng has joined #openstack-nova16:54
mriedemalthough,16:54
mriedemtdurakov: we already run the basic live migration config in the multinode job right?16:54
mriedemwhich is non-voting in the check queue16:55
tdurakovmriedem: check pipeline contains multinode job with full tempest suite16:55
mriedemyeah, i guess this would tell us in a more targeted way16:55
mriedembut you have to run the job manually16:56
tdurakovmriedem: what about moving it to check pipeline, non-voting of course?16:56
*** Daisy has quit IRC16:56
*** browne has joined #openstack-nova16:56
mriedemtdurakov: not sure16:57
mriedemit would raise the visibility16:57
mriedembut if we did that, would we disable the live migration tests in the multinode job?16:57
mriedemand make that voting since i think the only reason it's non-voting is because of the flaky live migration tests16:57
mriedemi think that would be the course16:57
tdurakovI'd run both for a while, it's a question of 2-3 days to decide about its stability16:57
*** sajeesh has joined #openstack-nova16:58
mriedemtdurakov: sure, let's revisit next week maybe, next live migration meeting?16:58
tdurakovyup16:58
*** acabot has quit IRC16:59
*** pushkaru has joined #openstack-nova16:59
tdurakovso to summarize, we leave live-migration job in experimental pipeline till next live-migration meeting, to decide whether it's stable or not16:59
mriedemyup17:00
tdurakovsounds good17:00
*** tblakeslee has joined #openstack-nova17:01
openstackgerritJohn Garbutt proposed openstack/nova: Extract _filter_hypervisor_macs  https://review.openstack.org/32956917:01
*** tblakeslee_ has joined #openstack-nova17:02
*** irenab has joined #openstack-nova17:02
*** ivase has joined #openstack-nova17:02
*** ijw has joined #openstack-nova17:02
*** acabot has joined #openstack-nova17:03
*** shaohe_feng has quit IRC17:04
*** shaohe_feng has joined #openstack-nova17:04
*** lpetrut has quit IRC17:05
*** sajeesh has quit IRC17:05
*** tblakeslee has quit IRC17:06
*** tblakeslee_ is now known as tblakeslee17:06
*** markus_z has joined #openstack-nova17:06
*** thorst_afk is now known as thorst17:07
*** tblakeslee has quit IRC17:09
stewie925hello all, I would like to work on the api-ref parameter verification for 'os-floating-ips.inc'17:10
*** vtech has quit IRC17:10
*** diga_ has joined #openstack-nova17:11
*** diga has quit IRC17:12
*** McNinja has quit IRC17:13
stewie925tho I'd like some clarification on how to do the verification17:13
openstackgerritChris Dent proposed openstack/nova: Add Allocation and AllocationList objects  https://review.openstack.org/28244217:13
openstackgerritChris Dent proposed openstack/nova: Add delete_, update_ and add_ inventory to ResourceProvider  https://review.openstack.org/32827617:13
openstackgerritChris Dent proposed openstack/nova: Add support for resource inventories to placement API  https://review.openstack.org/32915217:13
openstackgerritChris Dent proposed openstack/nova: Add a ResourceProviderList object  https://review.openstack.org/32830717:13
openstackgerritChris Dent proposed openstack/nova: Add set_inventory() method on ResourceProvider  https://review.openstack.org/32644017:13
openstackgerritChris Dent proposed openstack/nova: Add initial framing of placement API  https://review.openstack.org/32914917:13
openstackgerritChris Dent proposed openstack/nova: Add support for resource_providers urls  https://review.openstack.org/32915117:13
openstackgerritChris Dent proposed openstack/nova: Add microversion support for the placement API  https://review.openstack.org/32915017:13
openstackgerritChris Dent proposed openstack/nova: WIP experiment with the remainder of the placement API  https://review.openstack.org/29310417:13
openstackgerritChris Dent proposed openstack/nova: WIP Add a Usage and UsageList object  https://review.openstack.org/32957517:13
cdentthere ya go dansmith, I think that's go what you were hoping for17:13
*** McNinja has joined #openstack-nova17:13
*** shaohe_feng has quit IRC17:14
*** edand has joined #openstack-nova17:14
mriedemstewie925: just post the question and if someone can answer they will/might17:14
*** wanghao has quit IRC17:14
*** shaohe_feng has joined #openstack-nova17:15
*** wanghao has joined #openstack-nova17:16
*** ducttape_ has quit IRC17:17
mriedemmdbooth: diana_clarke: is this the head of the libvirt imagebackend refactor series as of today? https://review.openstack.org/#/c/326947/17:17
mriedemlooks like it but wanted to check before making this devstack change depend on it17:17
raj_singhstewie925: Here is wiki for reference https://wiki.openstack.org/wiki/NovaAPIRef17:17
*** klkumar has quit IRC17:17
*** pradk has joined #openstack-nova17:17
stewie925for paremeter verification - i'd like to know how to specifically ensure that the parameter list is complete17:17
mriedemstewie925: it's mostly checking api samples, checking code, and possibly testing it out with devstack17:17
*** zehua has quit IRC17:17
mriedemstewie925: the rest is up to good code review17:17
*** ijw__ has joined #openstack-nova17:17
*** mvk has joined #openstack-nova17:18
*** ijw__ has quit IRC17:18
stewie925hi raj_singh yes I am actually looking at that doc right now :)17:18
*** zehua has joined #openstack-nova17:19
mriedemstewie925: if you're learning, it's also probably helpful to just take your best attempt and then learn through code review if you missed something17:19
mriedemrather than try to get it perfect in patch set 117:19
*** ijw__ has joined #openstack-nova17:19
*** ijw has quit IRC17:20
stewie925oh I see, thank you17:20
*** rama_y has joined #openstack-nova17:21
mriedemmdbooth: diana_clarke: fyi https://review.openstack.org/#/c/318262/17:22
*** lixiaoy1 has quit IRC17:22
*** alex_xu has quit IRC17:22
*** gzhai2 has quit IRC17:23
*** ijw has joined #openstack-nova17:24
*** lixiaoy1 has joined #openstack-nova17:24
*** shaohe_feng has quit IRC17:24
*** gzhai2 has joined #openstack-nova17:24
*** alex_xu has joined #openstack-nova17:25
*** salv-orlando has quit IRC17:26
*** salv-orlando has joined #openstack-nova17:26
*** shaohe_feng has joined #openstack-nova17:27
*** ducttape_ has joined #openstack-nova17:28
*** salv-orl_ has joined #openstack-nova17:29
markus_znova bugs team meeting in 30 min in openstack-meeting-417:31
*** moshele has joined #openstack-nova17:32
*** salv-orlando has quit IRC17:32
openstackgerritSivasathurappan Radhakrishnan proposed openstack/nova: [WIP]Improve help text for allocation_ratio_opts  https://review.openstack.org/32959317:32
*** shaohe_feng has quit IRC17:34
*** shaohe_feng has joined #openstack-nova17:35
*** jwcroppe has joined #openstack-nova17:37
*** gzhai2 has quit IRC17:37
*** markus_z has quit IRC17:38
*** gzhai2 has joined #openstack-nova17:38
*** markus_z has joined #openstack-nova17:38
*** mriedem1 has joined #openstack-nova17:38
*** diga_ has quit IRC17:39
*** jwcroppe_ has quit IRC17:39
*** mriedem has quit IRC17:40
*** JoseMello has joined #openstack-nova17:40
*** tonytan4ever has joined #openstack-nova17:41
*** jdillaman has joined #openstack-nova17:41
*** jwcroppe_ has joined #openstack-nova17:41
mriedem1dansmith: to answer your earlier question, validate_networks is specifically passed a list of tuples https://github.com/openstack/nova/blob/master/nova/compute/api.py#L42217:41
mriedem1i think b/c of nova-net, checking17:42
*** mriedem1 is now known as mriedem17:42
*** sambetts is now known as sambetts|afk17:42
*** jwcroppe has quit IRC17:42
mriedemdansmith: and that's because we don't convert it to a tuple in network rpcapi https://github.com/openstack/nova/blob/master/nova/network/rpcapi.py#L20217:44
mriedemwould be an easy change though17:44
mriedemmayhap i'll do that17:44
*** shaohe_feng has quit IRC17:45
*** ociuhandu has quit IRC17:45
*** shaohe_feng has joined #openstack-nova17:45
*** kfarr has joined #openstack-nova17:45
*** ihrachys has quit IRC17:46
*** gjayavelu has joined #openstack-nova17:47
dansmithmriedem: cool17:47
*** gjayavelu has quit IRC17:47
openstackgerritSarafraj Singh proposed openstack/nova: WIP - Improve help context of key_manager.py  https://review.openstack.org/32959917:47
mriedemdansmith: also on https://review.openstack.org/#/c/309574/16/nova/network/neutronv2/api.py@1130 i remembered why I changed it to if not requested_networks - because if it's an empty list, the conversion above won't evaluate to true and then [].auto_allocate will fail17:49
openstackgerritJohn Garbutt proposed openstack/nova: Rename _process_requested_networks  https://review.openstack.org/32960017:49
openstackgerritJohn Garbutt proposed openstack/nova: WIP: Extract _validate_requested_network_ids  https://review.openstack.org/32960117:49
mriedemi guess way up in the REST API, requested_networks is going to be None unless the user passed something in on the request17:51
*** tbachman has joined #openstack-nova17:51
mriedemso i guess worrying about an empty list is pointless17:51
*** mtanino has quit IRC17:51
openstackgerritChris Dent proposed openstack/nova: WIP Add a Usage and UsageList object  https://review.openstack.org/32957517:51
openstackgerritChris Dent proposed openstack/nova: WIP experiment with the remainder of the placement API  https://review.openstack.org/29310417:51
mriedemit might be possible to pass networks=[] in on the server request, but that'd be dumb...17:53
*** jwcroppe has joined #openstack-nova17:53
*** ijw has quit IRC17:53
*** shaohe_feng has quit IRC17:55
*** jwcroppe_ has quit IRC17:55
*** ijw has joined #openstack-nova17:55
*** vishwanathj has quit IRC17:56
*** shaohe_feng has joined #openstack-nova17:56
markus_znova bugs team meeting in 5 min in #openstack-meeting-417:56
*** ijw has quit IRC17:57
*** ctrath has quit IRC17:57
*** xenogear has joined #openstack-nova17:57
*** tpepper is now known as tcpepper18:01
*** tyrola has quit IRC18:02
*** tcpepper has quit IRC18:03
mriedemBobBall: anthonyper: fyi, new bug, something you'd probably care about https://bugs.launchpad.net/nova/+bug/159236218:03
openstackLaunchpad bug 1592362 in OpenStack Compute (nova) "[XenAPI] add a maximum retry count for vbd unplug" [Low,Confirmed] - Assigned to Jianghua Wang (wjh-fresh)18:03
*** tpepper has joined #openstack-nova18:03
*** tpepper has quit IRC18:04
*** tpepper has joined #openstack-nova18:04
*** tpepper has quit IRC18:04
*** shaohe_feng has quit IRC18:05
*** shaohe_feng has joined #openstack-nova18:06
*** shihanzhang has joined #openstack-nova18:06
*** shz has quit IRC18:07
*** sudipto has quit IRC18:08
*** mtanino has joined #openstack-nova18:08
mriedembauzas: look familiar? https://bugs.launchpad.net/nova/+bug/159224118:09
openstackLaunchpad bug 1592241 in OpenStack Compute (nova) "memory_mb_used of compute node do not consider reserved_huge_pages" [Undecided,New] - Assigned to liuxiuli (liu-lixiu)18:09
*** dmk0202 has joined #openstack-nova18:09
bauzasmriedem: well, not really18:09
mriedemyeah, nvm18:10
mriedemmaybe sahid would be able to help on that one18:10
* bauzas currently investigating a n-net issue with a local devstack running on an OVH cloud :/18:10
*** salv-orl_ has quit IRC18:10
bauzasgraaah18:10
*** salv-orlando has joined #openstack-nova18:11
*** salv-orlando has quit IRC18:11
*** salv-orlando has joined #openstack-nova18:12
*** raunak has quit IRC18:12
clarkbbauzas: I probably know what the issue is18:12
bauzasclarkb: orly ?18:12
clarkbbauzas: nova net reconfigures your eth0 and doesn't like that OVH uses a /32 on eth0 with the default gateway not in that range18:12
clarkbso nova net fails to configure networking and the host breaks18:13
melwittdoes anyone happen to know why a python traceback might skip a step in a trace? example, I see nova/objects/service.py followed by nova/db/sqlalchemy/api.py and it's not showing the intermediate step of nova/db/api.py18:13
bauzasclarkb: tbc, when booting an instance from a devstack AIO, my VM is trampled18:13
*** tbachman_ has joined #openstack-nova18:13
clarkbbauzas: yes18:13
bauzasclarkb: yes, that's the problem18:13
clarkbyou cna avoid this by creating a bridge to point nova net at and then if you like you can attach that bridge to the external world18:13
bauzasclarkb: any workaround ?18:13
bauzasmmm18:13
clarkbbasically you have to tell nova net not to use eth018:14
bauzasclarkb: do we have kind of a script for that ?18:14
*** mvk_ has joined #openstack-nova18:14
clarkbbauzas: devstack-gate does it but doesn't give nested VMs external connectivity18:14
*** moshele has quit IRC18:14
bauzasmeh18:14
clarkband when I brought it up with nova no one was interested in fixing nova net18:14
clarkbso I doubt you willget much traction there18:14
bauzasclarkb: you mean using the FLAT_INTERFACE=<my_bridge> ?18:14
*** tbachman has quit IRC18:15
clarkbya18:15
*** tbachman_ is now known as tbachman18:15
*** ctrath has joined #openstack-nova18:15
*** Sukhdev has quit IRC18:15
bauzasclarkb: do you have a bug ?18:15
openstackgerritVladik Romanovsky proposed openstack/nova: libvirt: attach configdrive after instance XML  https://review.openstack.org/30333518:15
openstackgerritVladik Romanovsky proposed openstack/nova: objects: adding an update method to virtual_interface  https://review.openstack.org/31061818:15
bauzasclarkb: for devstack ?18:15
openstackgerritVladik Romanovsky proposed openstack/nova: objects: Add devices_metadata to instance object  https://review.openstack.org/32792018:15
openstackgerritVladik Romanovsky proposed openstack/nova: db: add a device_metadata column to instance_extra  https://review.openstack.org/31888318:15
openstackgerritVladik Romanovsky proposed openstack/nova: Device tagging metadata API support  https://review.openstack.org/30451118:15
openstackgerritVladik Romanovsky proposed openstack/nova: objects: new InstanceDevicesMetadata object  https://review.openstack.org/31888418:15
clarkbbauzas: no I was told it wasn't a bug18:15
openstackgerritVladik Romanovsky proposed openstack/nova: Device tagging API support  https://review.openstack.org/30451018:15
openstackgerritVladik Romanovsky proposed openstack/nova: Compute manager device tagging support  https://review.openstack.org/26401718:15
clarkbbauzas: hence the undesire to not fix anything :)18:15
bauzasclarkb: well, I understand18:15
openstackgerritVladik Romanovsky proposed openstack/nova: Libvirt driver implementation of device tagging  https://review.openstack.org/26401618:15
*** shaohe_feng has quit IRC18:15
clarkband if anything it is an issue iwth nova not with devstack18:15
*** tbachman has quit IRC18:15
clarkbdevstack has nothing to do wit hit18:15
bauzasclarkb: I'll speak at a local conf tomorrow and will run a workshop about using devstack18:16
bauzasclarkb: so the local OVH guys gave us some credit vouchers18:16
*** shaohe_feng has joined #openstack-nova18:16
bauzasclarkb: but it looks it's a problem...18:16
clarkbyes in nova net18:16
clarkbyou will have the same issue if you nova net without devstack18:16
bauzasyup, yup, I understand18:17
*** mvk has quit IRC18:17
bauzasneutron AIO then ?18:17
clarkbthat may be simplest18:17
bauzasmmm18:17
*** ijw has joined #openstack-nova18:17
bauzasor creating a bond and using it for FLAT_INTERFACE like you said ?18:18
clarkbya18:18
clarkbso that nova net doesn't get confused by the eth0 config18:18
bauzasI see18:18
bauzasclarkb: you're in US TZ right ?18:18
clarkbI am18:18
*** tbachman has joined #openstack-nova18:19
openstackgerritMatt Riedemann proposed openstack/nova: Skip network allocation if 'none' is requested  https://review.openstack.org/30963818:19
bauzasclarkb: in case that works, I should send you a kitkat :p18:19
openstackgerritMatt Riedemann proposed openstack/nova: nova-net: handle 'auto' network request in allocate_for_instance  https://review.openstack.org/29790618:19
openstackgerritMatt Riedemann proposed openstack/nova: Bump the service version for get-me-a-network support  https://review.openstack.org/31895318:19
openstackgerritMatt Riedemann proposed openstack/nova: Skip network validation if explicitly requesting no networks  https://review.openstack.org/30960218:19
openstackgerritMatt Riedemann proposed openstack/nova: neutron: handle 'auto' network request in allocate_for_instance  https://review.openstack.org/31627518:19
openstackgerritMatt Riedemann proposed openstack/nova: Add helpers to NetworkRequest(List) objects for auto/none cases  https://review.openstack.org/29787118:19
openstackgerritMatt Riedemann proposed openstack/nova: Add REST API support for get me a network  https://review.openstack.org/31639818:19
openstackgerritMatt Riedemann proposed openstack/nova: neutron: validate auto-allocate is available  https://review.openstack.org/30957418:19
*** stewie925 has quit IRC18:23
*** raunak has joined #openstack-nova18:24
vladikrdansmith, Hi, when you'll have a moment, could you please look at the device tagging series. particularly https://review.openstack.org/#/c/318884, https://review.openstack.org/#/c/327920 ?18:24
dansmithvladikr: cool, yep18:25
*** efoley has quit IRC18:25
*** joshw42 has joined #openstack-nova18:25
vladikrdansmith, thanks18:25
*** shaohe_feng has quit IRC18:26
openstackgerritmelanie witt proposed openstack/nova: Add output of the DB calls found by DatabasePoisonFixture  https://review.openstack.org/32857318:26
*** lpetrut has joined #openstack-nova18:26
*** raunak has quit IRC18:26
*** raunak has joined #openstack-nova18:26
*** shaohe_feng has joined #openstack-nova18:26
mriedemhmm, we probably have a bug here:18:28
mriedemhttps://github.com/openstack/nova/blob/14.0.0.0b1/nova/api/metadata/base.py#L30918:28
mriedemthat assumes if you have instance.key_name then instance.keypairs will be at least a list of length 118:28
mriedembut if we can't find that keypair in instance_extra or the keypairs table, the list would be empty https://github.com/openstack/nova/blob/14.0.0.0b1/nova/objects/instance.py#L86918:29
*** baoli_ has quit IRC18:29
*** dmk0202 has quit IRC18:30
*** harlowja has quit IRC18:30
mriedemhttps://bugs.launchpad.net/nova/+bug/159216718:30
openstackLaunchpad bug 1592167 in OpenStack Compute (nova) "Deleted keypair causes metadata failure" [Undecided,Incomplete]18:30
dansmithmriedem: if key name18:31
dansmithmriedem: we don't look it up anymore, so if key_name is set, it's in the list18:31
mriedemiff the keypair isn't in instance_extra18:31
*** rlrossit has quit IRC18:31
dansmithah, I guess yeah18:32
*** markus_z has quit IRC18:32
*** harlowja has joined #openstack-nova18:32
mriedemyeah there is this https://github.com/openstack/nova/blob/14.0.0.0b1/nova/compute/api.py#L94618:32
dansmithmriedem: you see this from a bug/18:32
mriedemdansmith: the bug was reported against kilo18:33
mriedemdansmith: so i was checking the master code to see if it could still happen18:33
mriedemwhich it looks like it could, if you deleted the keypair from the main db before the keypair on the instance was migrated to instance_extra18:33
dansmithoh, okay, good :D18:33
dansmithyeah18:33
mriedemand then later try to get metadata by json from the metadata service18:33
dansmithyup18:33
*** anush__ has joined #openstack-nova18:33
mriedemso i guess we should just check the length of that instance.keypairs list in the metadata api18:34
mriedemor let this raise up? https://github.com/openstack/nova/blob/14.0.0.0b1/nova/objects/instance.py#L86918:34
mriedemand handle that in the metadata api - that would be backportable18:34
dansmithno it wouldn't18:34
dansmiththat doesn't exist in kilo18:35
mriedemno, but the flavornotfound does18:35
mriedemthat was the bug18:35
mriedemhttps://github.com/openstack/nova/blob/stable/kilo/nova/api/metadata/base.py#L31418:35
dansmithwe should just check the list length18:35
dansmithbecause that's the behavior you'll get if you delete a keypair where instances have a key_name still18:35
dansmithI can do that on master if you want18:35
mriedemi can do it quick18:35
mriedemmitaka would have a separate fix if we wanted to fix in mitaka https://github.com/openstack/nova/blob/stable/mitaka/nova/api/metadata/base.py#L32718:36
*** shaohe_feng has quit IRC18:36
*** shaohe_feng has joined #openstack-nova18:36
mriedemassigned myself the bug so i've got dibs :)18:37
dansmithheh18:37
mriedemthis is what you get when you attend the bug meeting18:37
mriedemmore work18:37
* cdent writes wisdom from dear leader in little notebook: "Never attend meetings"18:40
*** bzurawski has quit IRC18:41
*** lucas___ has quit IRC18:43
mriedemheh, to update MetadataTestCase or OpenStackMetadataTestCase - that is the question18:44
*** salv-orlando has quit IRC18:45
*** sdague has quit IRC18:46
*** salv-orlando has joined #openstack-nova18:46
*** shaohe_feng has quit IRC18:46
*** lifeless has quit IRC18:46
*** shaohe_feng has joined #openstack-nova18:47
bauzasclarkb: could you please point me the devstack-gate script for OVH VMs ?18:47
*** lucas___ has joined #openstack-nova18:47
*** lucas___ has quit IRC18:47
*** lifeless has joined #openstack-nova18:47
*** lucas___ has joined #openstack-nova18:47
clarkbbauzas: https://git.openstack.org/cgit/openstack-infra/devstack-gate/tree/devstack-vm-gate.sh#n6918:47
bauzasclarkb: because I need to give a static bridge for getting a /24 netmask :(18:47
bauzasclarkb: k thanks18:49
*** vtech has joined #openstack-nova18:50
*** rk4n has quit IRC18:54
*** syjulian has quit IRC18:54
*** syjulian has joined #openstack-nova18:54
*** edand has quit IRC18:56
*** shaohe_feng has quit IRC18:56
*** shaohe_feng has joined #openstack-nova18:57
mriedemdansmith: actually i'm not sure what we should return in this case, 404 from the api seems correct if you deleted your keypair...returning metadata w/o the keys or public_keys item in the response seems wrong18:58
*** zenoway has joined #openstack-nova18:58
mriedemi mean, we should avoid the IndexError18:58
dansmithmriedem: but you don't want 404 for the whole deal, right?18:58
openstackgerritKaren Bradshaw proposed openstack/nova: api-ref, os-availability-zone.inc  https://review.openstack.org/32184718:59
mriedemwouldn't we 404 from the rest api in case like this?18:59
dansmithmriedem: yeah, but this is where we build the whole metadata object right?18:59
mriedemyeah18:59
mriedemwait, no19:00
*** lucas___ has quit IRC19:00
mriedemthat happens in the InstanceMetadata object constructor19:00
mriedemwell, __init__19:00
dansmith_metadata_as_json is where we build the whole thing right?19:00
mriedemthis is handling the meta_data.json request19:00
*** eglynn has quit IRC19:00
dansmithwe can't fail there or metadata is completely inaccessible right?19:00
mriedemyeah, for meta_data.json19:01
mriedemwhich is the most useful stuff19:01
mriedemjust not sure what the correct thing is for the response, don't include those keys in the dict or include them with empty values19:01
*** tbachman_ has joined #openstack-nova19:01
dansmithmriedem: the same behavior as if you don't have a key, I'd say19:01
*** lucas___ has joined #openstack-nova19:02
mriedemyeah was just thinking that19:02
mriedemand probably log something19:02
mriedemfor when the ticket is opened19:02
dansmithyeah19:02
mriedem'well you deleted your ticket, numbnuts'19:02
mriedems/ticket/keypair/19:02
dansmithLOG.warning('Stupid user calling in 3...2...1...')19:02
mriedemok, meeting19:02
mriedemheh19:02
*** lucas___ has quit IRC19:02
*** lucas___ has joined #openstack-nova19:03
*** ctrath has quit IRC19:04
*** lucas___ has quit IRC19:04
*** lucas___ has joined #openstack-nova19:04
*** tbachman has quit IRC19:05
*** tbachman_ is now known as tbachman19:05
*** dmk0202 has joined #openstack-nova19:05
*** raunak has quit IRC19:06
*** sdake has quit IRC19:06
*** ctrath has joined #openstack-nova19:06
*** shaohe_feng has quit IRC19:07
*** sdake has joined #openstack-nova19:07
*** shaohe_feng has joined #openstack-nova19:07
*** omnipresent has joined #openstack-nova19:08
*** zenoway has quit IRC19:10
*** fragatin_ has quit IRC19:12
*** tbachman has quit IRC19:13
*** anush__ has quit IRC19:14
*** PaulMurray has quit IRC19:14
openstackgerritPushkar Umaranikar proposed openstack/nova: [WIP] Improve help text for compute manager options  https://review.openstack.org/32963919:16
*** shaohe_feng has quit IRC19:17
*** shaohe_feng has joined #openstack-nova19:17
*** anush__ has joined #openstack-nova19:21
openstackgerritChris Dent proposed openstack/nova: Add Allocation and AllocationList objects  https://review.openstack.org/28244219:22
openstackgerritChris Dent proposed openstack/nova: Add delete_, update_ and add_ inventory to ResourceProvider  https://review.openstack.org/32827619:22
openstackgerritChris Dent proposed openstack/nova: Add support for resource inventories to placement API  https://review.openstack.org/32915219:22
openstackgerritChris Dent proposed openstack/nova: Add a ResourceProviderList object  https://review.openstack.org/32830719:22
openstackgerritChris Dent proposed openstack/nova: Add set_inventory() method on ResourceProvider  https://review.openstack.org/32644019:22
openstackgerritChris Dent proposed openstack/nova: Add initial framing of placement API  https://review.openstack.org/32914919:22
openstackgerritChris Dent proposed openstack/nova: WIP Add a Usage and UsageList object  https://review.openstack.org/32957519:22
openstackgerritChris Dent proposed openstack/nova: Add support for resource_providers urls  https://review.openstack.org/32915119:22
openstackgerritChris Dent proposed openstack/nova: Add microversion support for the placement API  https://review.openstack.org/32915019:22
openstackgerritChris Dent proposed openstack/nova: WIP experiment with the remainder of the placement API  https://review.openstack.org/29310419:22
openstackgerritChris Dent proposed openstack/nova: Add support for usages in the placement API  https://review.openstack.org/32964319:22
*** jwcroppe has quit IRC19:22
bauzasclarkb: thanks for the tip about changing the netmask but it seems OVH doesn't like it :(19:23
clarkbyou can't change the netmask on eth019:23
bauzason br0 I did19:23
clarkbyou make a new virtual interface that nova net can talk to19:23
clarkbthen if you want external connectivity for your nova net VMs you can bridge across to eth019:23
bauzassec, maybe I'm confused19:24
bauzasI bridged eth0 on a br0 if19:24
bauzasbr0 was either dhcp or static19:24
bauzastbh, my network skills are a bit not good :/19:25
*** tonytan4ever has quit IRC19:25
clarkbbauzas: I would start just with br0 and no eth0 bridging19:26
clarkbyour nested VMs wont be able to internet but you can confirm everything else wO19:26
clarkbRKs19:26
bauzasI see19:26
bauzasso a static br019:26
bauzasthat I would define19:27
bauzaswirthout external plug19:27
clarkbya it doesn't even need an address or mask can just be l2 device19:27
bauzasright19:27
*** shaohe_feng has quit IRC19:27
bauzasbecause n-net will set it19:27
bauzask, I can try19:27
*** shaohe_feng has joined #openstack-nova19:28
*** rlrossit has joined #openstack-nova19:29
*** ociuhandu has joined #openstack-nova19:29
*** tblakeslee has joined #openstack-nova19:29
*** tblakeslee has quit IRC19:29
*** baoli has joined #openstack-nova19:31
*** mriedem has quit IRC19:31
*** stewie925 has joined #openstack-nova19:32
*** mriedem has joined #openstack-nova19:34
*** ijw__ has quit IRC19:34
*** ayoung_ has joined #openstack-nova19:34
*** shaohe_feng has quit IRC19:37
*** shaohe_feng has joined #openstack-nova19:38
*** lucas___ has quit IRC19:39
*** tyrola has joined #openstack-nova19:40
*** Sukhdev has joined #openstack-nova19:42
*** rfolco has quit IRC19:43
*** salv-orlando has quit IRC19:43
*** salv-orlando has joined #openstack-nova19:44
*** dimtruck is now known as zz_dimtruck19:44
*** baoli has quit IRC19:44
*** delattec has quit IRC19:45
*** baoli has joined #openstack-nova19:45
*** harlowja_ has joined #openstack-nova19:45
*** derekh has quit IRC19:46
*** ijw_ has joined #openstack-nova19:46
*** burgerk has quit IRC19:46
*** shaohe_feng has quit IRC19:48
*** chandankumar has joined #openstack-nova19:48
*** harlowja has quit IRC19:49
*** tbachman has joined #openstack-nova19:49
*** shaohe_feng has joined #openstack-nova19:50
*** tbachman_ has joined #openstack-nova19:50
*** raunak has joined #openstack-nova19:50
*** rfolco has joined #openstack-nova19:50
*** tyrola has quit IRC19:52
diana_clarkemriedem: Thanks for the one-off patch for 'flat' testing! My apologies for not responding sooner. May I rebase it so it sits on top of the patch that exercises the changes?19:53
diana_clarke(after seeing it pass where it is first)19:53
mriedemdiana_clarke: sue19:54
mriedem*sure19:54
*** tbachman has quit IRC19:54
*** tbachman_ is now known as tbachman19:54
diana_clarkemriedem: Thanks!19:55
*** sdague has joined #openstack-nova19:56
mriedemdansmith: what do you think about log level for that missing keypair thing? debug or warning?19:56
*** pilgrimstack has joined #openstack-nova19:56
dansmithmriedem: definitely error with blinking ANSI text19:57
dansmithmriedem: debug seems fine to me19:57
dansmithmriedem: if we do it higher, a user can just delete a keypair and spam the logs by DoSing their metadata server19:57
*** shaohe_feng has quit IRC19:58
mriedemaight19:58
mriedemthe unit test was easier to write than i expected19:58
*** burgerk has joined #openstack-nova19:58
*** shaohe_feng has joined #openstack-nova19:58
diana_clarkemriedem: Oh nevermind. This is in devstack (rather than nova). The answer to my next question might be in the meeting minutes from earlier. Apologies for the noise.19:59
mriedemdiana_clarke: yeah, devstack change that depends-on what i thought was the top of the refactor series as of today19:59
mriedembtw, the test should be done running now20:00
mriedemyeah, all green https://review.openstack.org/#/c/318262/20:00
mriedemand images_type=flat in nova.conf as expected http://logs.openstack.org/62/318262/2/check/gate-tempest-dsvm-full/7c43e03/logs/etc/nova/nova.conf.txt.gz20:00
*** edleafe_ has joined #openstack-nova20:00
openstackgerritClaudiu Belu proposed openstack/nova: policy: Add defaults in code (part 1)  https://review.openstack.org/32885020:01
*** tyrola has joined #openstack-nova20:02
openstackgerritSivasathurappan Radhakrishnan proposed openstack/nova: Improve help text for allocation_ratio_opts  https://review.openstack.org/32959320:02
*** yamahata has quit IRC20:05
*** zz_dimtruck is now known as dimtruck20:06
*** ducttape_ has quit IRC20:07
*** shaohe_feng has quit IRC20:08
diana_clarkemriedem: that "remove max size ..." patch is sitting on top of master (but same topic). If I've understood correctly, I'll need to change the depends on to point to: https://review.openstack.org/#/c/282580/20:08
*** ctrath has quit IRC20:08
*** shaohe_feng has joined #openstack-nova20:09
*** tyrola has quit IRC20:09
openstackgerritMatt Riedemann proposed openstack/nova: Handle keypair not found from metadata server  https://review.openstack.org/32966120:09
mriedemdansmith: ^20:09
*** flwang has quit IRC20:10
mriedemdiana_clarke: i made it point at the top of the series20:11
mriedemwhich is https://review.openstack.org/#/c/326947/20:11
mriedemi thought anyway20:11
*** ctrath has joined #openstack-nova20:11
mriedemor maybe not, i get confused between same topic and related changes20:11
mriedemdiana_clarke: so you're saying https://review.openstack.org/#/c/282580/ is the top of the series we care about testing, right? if so, i can update the devstack change quick20:12
*** cdelatte has joined #openstack-nova20:12
*** rlrossit has quit IRC20:12
*** pilgrimstack has quit IRC20:12
diana_clarkemriedem: exactly, thanks!20:12
*** anush__ has quit IRC20:13
dansmithmriedem: -220:13
*** anush__ has joined #openstack-nova20:13
mriedemheh i knew that delattr would raise a stink20:13
dansmithmriedem: I'm not sure how that test is passing20:13
dansmithunless fakemetadata is being too generous or something20:14
mriedemfake creates a fake instance obj and fake keypair obj and sets that on the instance20:14
mriedemdansmith: the reason i didn't set an empty list was then we wouldn't hit the lazy-load code20:14
dansmithwell, you're not hitting it now20:15
mriedemyeah i am20:15
dansmithbecause you deleted the thing that does the lazy loading20:15
openstackgerritJulian proposed openstack/nova: WIP Add unit tests for nova.virt.firewall.IpTablesFirewallDriver (Part 2)  https://review.openstack.org/32543520:15
mriedemthat's why i mock objects.Instance.get_by_uuid20:15
mriedemw/o that the trace for the failure was in _load_keypairs20:15
dansmithmriedem: show me the rest of the trace then, because you deleted the @property that does the loading :)20:16
*** ducttape_ has joined #openstack-nova20:16
*** ducttape_ has quit IRC20:16
*** ducttape_ has joined #openstack-nova20:16
mriedemrecreating it20:16
*** anush__ has quit IRC20:17
*** anush__ has joined #openstack-nova20:17
mriedemdansmith: https://gist.github.com/mriedem/b71ca1e00503aee0d5f2bb29dc5028a620:18
*** cdent has quit IRC20:18
mriedemkeypairs is an attribute on the instance object20:18
mriedemnot a @property20:18
*** shaohe_feng has quit IRC20:18
openstackgerritmelanie witt proposed openstack/nova: Add output of the DB calls found by DatabasePoisonFixture  https://review.openstack.org/32857320:19
*** shaohe_feng has joined #openstack-nova20:19
dansmithmriedem: all things in fields become @property objects on the object they're for, when we register20:19
mriedemok....so how do you explain that stacktrace that's in _load_keypairs?20:20
dansmithI dunno, but go look at the first thing it's hitting in o.vo20:20
mriedemif this is too gross, i'll just add a kwarg to fake_inst_obj to not create the keypair20:20
dansmiththe getter20:20
mriedemi'd like to avoid looking at ovo atm20:20
dansmithmriedem: the lazy-load behavior is not what you're testing though20:20
mriedemi'll just modify the fake_inst_obj method to not create a keypair and set it on the test instnace20:20
dansmithmriedem: just set instance.keypairs = KeypairList()20:21
dansmithdoes fake_InstanceMetadata do something unhelpful maybe?20:21
mriedemnot really20:22
mriedemjust creates the InstanceMetadata object with the stuff you pass into that helper method,20:22
mriedemand stub out the security group API20:22
*** anush__ has quit IRC20:22
mriedemi realize this test is testing more than just the unit that's changing20:22
mriedembut i did that to actually recreate the failure20:23
mriedembecause if _load_keypairs changes for some reason, it could change the behavior of this in the metadata api20:24
dansmithhttps://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L64-L9620:24
dansmithyou're deleting the thing we set on L9620:24
dansmithwhich is the thing that does the load on L6720:24
mriedemyeah self.obj_load_attr(name)20:24
dansmithyou can delete instance._obj_keypairs to do the thing you want,20:25
dansmithbut the fact that it's passing now makes me suspicious20:25
mriedemidk, but i know i'm getting into obj_load_attr because: File "nova/objects/instance.py", line 971, in obj_load_attr20:25
dansmithyep20:25
openstackgerritPushkar Umaranikar proposed openstack/nova: [WIP] Improve help text for compute manager options  https://review.openstack.org/32963920:25
mriedemi'll just update the stub helper to not set the keypair on the instance to begin with20:25
mriedemthat's cleaner to me20:25
dansmithwell, that's fine, but it's still concerning20:25
*** flwang has joined #openstack-nova20:26
*** dmk0202 has quit IRC20:26
dansmithmriedem: https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L9020:26
mriedembrb20:26
dansmithmriedem: I implemented delete at some point apparently20:26
dansmithso that's why I guess :D20:26
*** dmk0202 has joined #openstack-nova20:26
*** diogogmt has joined #openstack-nova20:27
*** mriedem1 has joined #openstack-nova20:27
*** jichen has quit IRC20:28
*** shaohe_feng has quit IRC20:29
*** shaohe_feng has joined #openstack-nova20:30
openstackgerritPushkar Umaranikar proposed openstack/nova: Remove mox from tests/unit/objects/test_aggregate.py  https://review.openstack.org/29964420:30
*** mriedem has quit IRC20:30
*** pradk has quit IRC20:31
*** mriedem1 is now known as mriedem20:32
*** dmk0202 has quit IRC20:33
mriedemdansmith: so i just changed the test, but now you're +220:34
mriedemi guess i'll just drop that20:35
mriedemif you're cool with delattr20:35
dansmithmriedem: either way20:35
mriedemi'll just leave it20:35
mriedemsmaller change that way20:35
mriedemcan we still be friends after this?20:36
mriedemwill you still come to my bday party?!20:36
*** rlrossit has joined #openstack-nova20:36
melwittlol20:36
mriedemmy daughter says she won't go to someone's bday party or invite someone to her bday party if they have a falling out on any particular day20:37
mriedemi'm going to adopt that also20:37
dansmithheh20:38
auggyi think that's a fair philosophy20:38
melwittalaski: on the instance tag valid states thing, the way I did it adds an additional db read of the instance to check the state. that can be avoided by doing the state validation in the db api layer but I guessed that wouldn't be desired20:38
*** shaohe_feng has quit IRC20:39
auggyare there incentives for the person to win back their birthday party invitation?20:39
auggyie, a pony20:39
*** mkrcmari__ has joined #openstack-nova20:39
mriedemauggy: they are 5 year olds, they forget about it by the next day20:39
auggymriedem: ah so the "birthday party invite status" would only be a daily metric ;)20:40
mriedemtypically20:40
alaskimelwitt: doing it in the db api would be more complex I think. the get() can return an "instance" that's a real instance or a BuildRequest instance, moving the state validation elsewhere would have to replicate that split20:41
mriedemdiana_clarke: https://review.openstack.org/#/c/318262/ is updated, we'll see how it does20:41
*** shaohe_feng has joined #openstack-nova20:42
*** rfolco has quit IRC20:42
melwittalaski: I didn't think about that. for all the instance tag apis there's a check in there _check_instance_exists_in_project and that's how instance could have been reused20:42
*** mvk_ has quit IRC20:43
*** diogogmt has quit IRC20:43
diana_clarkemriedem: Thanks, fingers crossed. I'm currently looking into the ploop errors.20:44
melwittalaski: which would only work after scheduling but we need to be able to check the state before that. so I see what you mean20:44
*** pacoblox has quit IRC20:45
*** mvk_ has joined #openstack-nova20:45
mriedemdiana_clarke: has the -1 on https://review.openstack.org/#/c/279669/ been addressed?20:45
*** chandankumar has quit IRC20:45
mriedemguessing not20:45
alaskimelwitt: exactly20:45
diana_clarkemriedem: I don't think so.20:46
dansmithmriedem: I kinda feel like we should have some functional tests on that guy that can actually create/delete images on disk20:47
dansmithmriedem: given how much trouble we've had with the imagecache thus far, and kinda set the stage for validating it like that going forward20:47
*** diogogmt has joined #openstack-nova20:48
mriedemdoes that require sudo? or just write to a temp dir i guess for the test20:48
*** mkrcmari__ has quit IRC20:48
*** smatzek has quit IRC20:49
*** shaohe_feng has quit IRC20:49
dansmithyeah, not if we do it in a temp location20:49
*** gagehugo has quit IRC20:49
dansmithanyway, biab20:49
*** mnestratov has quit IRC20:49
*** shaohe_feng has joined #openstack-nova20:50
mriedemdiana_clarke: any idea on how hard it would be to add a functional test for https://review.openstack.org/#/c/279669/20:50
mriedem?20:50
*** edmondsw has quit IRC20:52
*** kfarr has quit IRC20:53
*** thorst has quit IRC20:54
*** thorst has joined #openstack-nova20:55
*** ayoung_ has quit IRC20:57
*** ayoung has quit IRC20:57
*** mvk has joined #openstack-nova20:58
diana_clarkemriedem: Dunno, but I'm happy to give it a shot :) I'll add it to my list.20:58
*** rtheis has quit IRC20:59
*** thorst has quit IRC20:59
*** shaohe_feng has quit IRC20:59
*** anush__ has joined #openstack-nova20:59
*** akshai has joined #openstack-nova20:59
*** mvk_ has quit IRC20:59
*** tbachman has quit IRC20:59
*** eharney has quit IRC21:01
*** shaohe_feng has joined #openstack-nova21:02
*** ivase has quit IRC21:02
*** anush__ has quit IRC21:03
*** darrenc is now known as darrenc_afk21:03
*** anush__ has joined #openstack-nova21:04
*** fragatina has joined #openstack-nova21:05
*** ivase has joined #openstack-nova21:05
*** gyee has joined #openstack-nova21:06
*** aysyd has quit IRC21:08
openstackgerritmelanie witt proposed openstack/nova: Add output of the DB calls found by DatabasePoisonFixture  https://review.openstack.org/32857321:08
*** _gryf has quit IRC21:08
*** smatzek has joined #openstack-nova21:09
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/32967921:09
*** _gryf has joined #openstack-nova21:09
*** shaohe_feng has quit IRC21:10
mriedemthis must be wrong https://github.com/openstack/nova/blob/master/nova/virt/libvirt/utils.py#L18721:10
*** ivase has quit IRC21:10
*** shaohe_feng has joined #openstack-nova21:10
*** pacoblox has joined #openstack-nova21:11
*** yamahata has joined #openstack-nova21:12
mriedemi guess for a functional test, we'd still have to stub out the api service and it's download method, and have a fake image registry with some test image,21:14
mriedemand download would just copy a fake image file into place21:14
mriedemthe tricky part would be fetch_to_raw calling qemu_img_info21:15
mriedemthat would have to be stubbed out21:15
mriedemdiana_clarke: dansmith: ^21:16
dansmithmriedem: why tricky? the point would be to actually use that right?21:16
mriedemwe do already have a fake image service with some test images, just not sure if it supports download21:16
mriedemdansmith: we can't call qemu-img from a functional test21:17
mriedemit's not a devstack env21:17
dansmithmriedem: I thought we have real libvirt in functional?21:17
mriedemshiiiiit naw21:17
mriedemfunctional is really just some running services, all external services stubbed out, db + wsgi21:18
*** woodster_ has quit IRC21:18
dansmithokay, I guess that's right21:19
dansmithfunctional_devstack was supposed to give us that21:19
dansmithor whatever21:19
diana_clarkedansmith: So... I'm looking at those ploop errors (virtuozzo ci), and the traceback lines don't match the code at that particular patchset and I can't for the life of me see why. Have you seen this before?21:19
dansmithnot being able to actually use qemu-img in there makes it less useful21:19
*** shaohe_feng has quit IRC21:20
dansmithdiana_clarke: you should talk to one of the owners21:20
*** shaohe_feng has joined #openstack-nova21:20
openstackgerritSam Betts proposed openstack/nova: Eliminate resource tracker to host manager races  https://review.openstack.org/30834821:20
dansmithdiana_clarke: from what I saw it looked like they were definitely running your code, but maybe they're doing something nefarious like pre-patching or something?21:21
diana_clarkedansmith: I'm sure it's me, not them. And that I'm just doing something stupid.21:21
diana_clarkedansmith: Yup, it's for sure the new code.21:21
*** smatzek has quit IRC21:22
diana_clarkedansmith: but the code it claims is on line 1222, I can't find. http://paste.openstack.org/show/516034/21:22
diana_clarkedansmith: In fact, I don't see anything with a "--hdd"...21:24
mriedemdiana_clarke: i think i know where that is, sec21:24
mriedemi had some questions about their ci in an unrelated review for implementing resize for virtuozzo21:24
mriedemhttps://review.openstack.org/#/c/182257/21:24
mriedemhttps://review.openstack.org/#/c/182257/39/nova/virt/libvirt/imagebackend.py21:25
mriedemthere is your --hdd21:25
mriedemso they are patching the unmerged change into their CI21:25
mriedemdiana_clarke: where is your change with the results? i can check the stack log21:25
dansmithmriedem: yikes21:25
mriedemyeah21:26
mriedemthe thing i mentioned in their review was i didn't see extend called here at all https://review.openstack.org/#/c/182257/39/nova/virt/disk/api.py21:26
mriedemin their ci run21:26
*** burgerk has quit IRC21:26
mriedemmore specifically, i didn't see "Checking if we can resize image" in the n-cpu logs21:26
*** stewie925 has quit IRC21:29
diana_clarkeNow, I'm confused... my patch is running on top of this unmerged patch?21:29
dansmithdiana_clarke: potentially, which is uncool21:30
diana_clarke(also thanks! I was starting to feel crazy not being able to find that hdd thing)21:30
dansmithdiana_clarke: i.e. not what is supposed to be happening21:30
*** shaohe_feng has quit IRC21:30
*** lindycod_ has quit IRC21:30
mriedemdiana_clarke: dansmith: http://openstack-3rd-party-virtuozzo-ci-logs.virtuozzo.com/80/282580/11/check/check-dsvm-tempest-vz7-exe-minimal/9c8e3c9/logs/devstacklog.txt.gz21:30
diana_clarkedansmith: I should have asked earlier. I spent a while on that...21:30
mriedemsearch for21:30
mriedem"2016-06-11 00:05:50.945 | 44b6772 libvirt: virtuozzo instance resize support"21:30
dansmithugh21:30
dansmithuncool21:31
*** shaohe_feng has joined #openstack-nova21:31
*** joshw42 has quit IRC21:31
*** pacoblox has quit IRC21:31
*** stacker has joined #openstack-nova21:31
mriedemthe weird thing is i don't even see where that is cloned or checked out21:32
dansmithmriedem: I suppose it's also possibly just a bug in their stuff and is patching on top of a dirty tree or something, but that seems unlikely to not be causing lots of other problems21:33
*** pacoblox has joined #openstack-nova21:33
*** anush__ has quit IRC21:33
*** pushkaru has quit IRC21:36
*** pushkaru has joined #openstack-nova21:36
openstackgerritAndrew Laski proposed openstack/nova: Policy-in-code servers rules  https://review.openstack.org/32912221:36
dansmithmriedem: re: your comment on that base patch just now, I know functional doesn't run against devstack, I just thought we were able to yank in more deps for functional (i.e. I thought we didn't expect them to run in a full vacuum)21:37
mriedemgit remote set-url origin http://git.sw.ru/scm/openstack/devstack.git21:37
mriedemthey pull their own devstack21:38
*** jwcroppe has joined #openstack-nova21:38
dansmithwow21:38
mriedemdiana_clarke: dansmith: bingo http://openstack-3rd-party-virtuozzo-ci-logs.virtuozzo.com/80/282580/11/check/check-dsvm-tempest-vz7-exe-minimal/9c8e3c9/console.html.gz21:39
mriedemlook for 23:48:46 2016-06-10 23:48:58.872 | + [[ 282580 -ne 182257 ]]21:39
*** pradk has joined #openstack-nova21:39
dansmithcripes21:39
mriedemheh21:39
*** tbachman has joined #openstack-nova21:39
*** cdelatte has quit IRC21:39
mriedemi don't see mnestratov around21:40
mriedemso i guess dev ML...21:40
dansmithyeah21:40
mriedemon it21:40
*** shaohe_feng has quit IRC21:40
diana_clarkemriedem: thanks, I really appreciate it.21:40
mriedemnp21:41
mriedemi said i'd start reviewing that series this week, so far one patch down :)21:41
*** shaohe_feng has joined #openstack-nova21:41
mriedemwell, one half of one patch21:41
*** Sukhdev has quit IRC21:46
*** shaohe_feng has quit IRC21:51
*** sileht has quit IRC21:51
mriedemalright, email sent to dev list21:51
*** shaohe_feng has joined #openstack-nova21:51
mriedemin as nice a language as possible21:51
*** sileht has joined #openstack-nova21:52
*** mmandel has quit IRC21:52
*** darrenc_afk is now known as darrenc21:54
*** kylek3h has quit IRC21:56
*** dimtruck is now known as zz_dimtruck21:58
*** Sukhdev has joined #openstack-nova21:59
*** shaohe_feng has quit IRC22:01
*** shaohe_feng has joined #openstack-nova22:04
*** burt has quit IRC22:05
*** browne has quit IRC22:08
*** ijw_ has quit IRC22:10
*** rlrossit has quit IRC22:10
*** mdrabe has quit IRC22:11
*** shaohe_feng has quit IRC22:11
*** mriedem is now known as mriedem_away22:12
*** shaohe_feng has joined #openstack-nova22:12
*** jamesdenton has quit IRC22:12
*** Sukhdev has quit IRC22:14
openstackgerritVladik Romanovsky proposed openstack/nova: libvirt: attach configdrive after instance XML  https://review.openstack.org/30333522:14
openstackgerritVladik Romanovsky proposed openstack/nova: objects: adding an update method to virtual_interface  https://review.openstack.org/31061822:14
openstackgerritVladik Romanovsky proposed openstack/nova: objects: Add devices_metadata to instance object  https://review.openstack.org/32792022:14
openstackgerritVladik Romanovsky proposed openstack/nova: db: add a device_metadata column to instance_extra  https://review.openstack.org/31888322:14
openstackgerritVladik Romanovsky proposed openstack/nova: Device tagging metadata API support  https://review.openstack.org/30451122:14
openstackgerritVladik Romanovsky proposed openstack/nova: objects: new InstanceDevicesMetadata object  https://review.openstack.org/31888422:14
openstackgerritVladik Romanovsky proposed openstack/nova: Device tagging API support  https://review.openstack.org/30451022:14
openstackgerritVladik Romanovsky proposed openstack/nova: Compute manager device tagging support  https://review.openstack.org/26401722:14
openstackgerritVladik Romanovsky proposed openstack/nova: Libvirt driver implementation of device tagging  https://review.openstack.org/26401622:14
*** Sukhdev has joined #openstack-nova22:15
*** baoli has quit IRC22:15
*** stewie925 has joined #openstack-nova22:15
stewie925hi guys, I am trying to commit my changes to gerrit -  I did 'git add' and set my gerrit remote correctly22:16
*** Sukhdev has quit IRC22:16
*** akshai has quit IRC22:16
*** Sukhdev has joined #openstack-nova22:17
*** akshai has joined #openstack-nova22:17
stewie925however, I created commit-msg using 'touch' instead of 'curl' - so I got error in 'git review' that  change-id is required22:17
stewie925so I went back and deleted the commit-msg, and re-created it correctly using 'curl' command22:18
stewie925however, this time when I did 'git commit'  it says there is "nothing to commit"22:18
*** jwcroppe has quit IRC22:20
*** shaohe_feng has quit IRC22:21
*** shaohe_feng has joined #openstack-nova22:22
*** edleafe_ has quit IRC22:24
*** openstackstatus has quit IRC22:25
*** openstack has joined #openstack-nova22:27
*** browne has joined #openstack-nova22:27
auggystewie925: have you committed to openstack projects in gerrit before?22:27
stewie925hi auggy yes I did, quite a few times - I messed up this go round with the commit-msg creation - my bad22:28
*** rcernin has joined #openstack-nova22:28
auggystewie925: ok, and you have git-review set up?22:28
stewie925yes I did22:28
stewie925so what happened is, I should have run "curl -Lo .git/hooks/commit-msg http://review.openstack.org/tools/hooks/commit-msg "  when creating the commit-msg22:29
stewie925but I did 'touch .git/hooks/commit-msg' instead which messed things up22:29
stewie925so I trashed the commit-msg file and did it correctly using the "curl -Lo .git/hooks/commit-msg http://review.openstack.org/tools/hooks/commit-msg "22:30
auggystewie925: i don't think i've ever done my git commits that way before, are you following some docs somewhere that tell you to do it like that?22:30
*** catintheroof has quit IRC22:30
stewie925oh let me try something... brb22:30
*** sameo has joined #openstack-nova22:30
*** ctrath has quit IRC22:31
*** shaohe_feng has quit IRC22:32
*** rk4n has quit IRC22:32
*** shaohe_feng has joined #openstack-nova22:32
*** ijw_ has joined #openstack-nova22:36
*** stewie925 has quit IRC22:36
*** p01nt3r75 has joined #openstack-nova22:37
*** mtanino has quit IRC22:38
*** ccl_ has joined #openstack-nova22:39
*** ccl_ is now known as Guest4263722:39
*** shaohe_feng has quit IRC22:42
*** shaohe_feng has joined #openstack-nova22:43
*** mtanino has joined #openstack-nova22:43
*** ducttape_ has quit IRC22:43
*** rk4n has joined #openstack-nova22:48
*** rk4n has quit IRC22:50
*** gongysh has joined #openstack-nova22:50
*** Sukhdev has quit IRC22:51
*** shaohe_feng has quit IRC22:52
*** rk4n has joined #openstack-nova22:52
*** shaohe_feng has joined #openstack-nova22:53
*** ssurana has quit IRC22:54
*** rk4n has quit IRC22:54
*** stewie925 has joined #openstack-nova22:54
stewie925sorry auggy, had bad internet connection22:54
stewie925i got to resolve the commit-msg issue22:54
auggystewie925: are you following some documentation that tells you to manually run curl to create the commit msg? if so, could you provide the link to it?22:55
openstackgerritSTEW TY proposed openstack/nova: api-ref example verification for os-floating-ips  https://review.openstack.org/32970422:56
stewie925oh sure - let me get it22:57
stewie925btw I just committed my first api-ref22:57
stewie925example verification22:57
auggystewie925: so, that manual curl you're doing is done by git-review22:57
auggystewie925: which is why i'm curious what docs you are following that are telling you to do that22:58
*** mvk_ has joined #openstack-nova22:58
*** JoseMello has quit IRC22:59
*** stewie925_ has joined #openstack-nova23:01
*** mvk has quit IRC23:01
*** stewie925 has quit IRC23:02
*** rk4n has joined #openstack-nova23:02
stewie925_hey auggy its actually our internal documentation23:02
stewie925_to do that step23:02
*** shaohe_feng has quit IRC23:02
stewie925_curl -Lo .git/hooks/commit-msg http://review.openstack.org/tools/hooks/commit-msg23:03
auggystewie925_: ah, i know some places have firewall issues, is that why? if you do "git review -s" on your branch, what happens?23:03
auggystewie925_: are you able to use "git review" commands without errors?23:03
stewie925_yeah that was my other mistake, forgot to run the -s for the git review23:03
stewie925_yes I have been able to fix that issue - and committed my example verification to gerrit :)23:04
stewie925_jsut within 10 min ago :)23:04
auggystewie925_: so, when you commit, you should have that hook locally and you shouldn't need to use that curl command23:04
auggystewie925_: when you commit, it should just put a commit id at the bottom of your commit message23:05
stewie925_yes that should have been automatic, right23:05
auggystewie925_: and then you just do "git review" and it will post your change23:05
stewie925_it will automatically generate the change-id23:05
auggystewie925_: ok, i guess i didn't understand why you were manually running that curl command23:05
*** shaohe_feng has joined #openstack-nova23:05
*** MikeG451_ has quit IRC23:05
stewie925_oh auggy, I was just following our internal document steps on committing23:05
auggystewie925_: alright, well it sounds like you either need to update it or stick to the official openstack developer docs ;)23:06
stewie925_and I missed a step :)23:06
auggystewie925_: if your internal docs indicate that you have additional steps, you'll probably need to get help from your colleagues as folks here won't have enough context to really help you troubleshoot that i think23:07
*** irenab_ has joined #openstack-nova23:07
stewie925_thank you, auggy23:07
mtreinishstewie925_: you might want to refer to: http://docs.openstack.org/infra/manual/developers.html#development-workflow (and update your internal doc to point to that)23:08
stewie925_thank you for sharing mtreinish - reviewing the doc now and bookmarked it23:09
stewie925_test23:10
mtreinishstewie925_: actually this section covers the steps you were going through: http://docs.openstack.org/infra/manual/developers.html#starting-work-on-a-new-project (same doc just a different section)23:10
*** irenab has quit IRC23:10
*** irenab_ is now known as irenab23:10
*** jamesdenton has joined #openstack-nova23:12
*** shaohe_feng has quit IRC23:13
*** salv-orlando has quit IRC23:14
*** jamesden_ has joined #openstack-nova23:14
*** salv-orlando has joined #openstack-nova23:14
*** shaohe_feng has joined #openstack-nova23:15
openstackgerritFei Long Wang proposed openstack/nova: Add a check before deleting compute serivce  https://review.openstack.org/32363323:16
*** ayoung has joined #openstack-nova23:17
*** jamesdenton has quit IRC23:17
*** hoangcx has quit IRC23:18
*** Sukhdev has joined #openstack-nova23:20
*** stewie925 has joined #openstack-nova23:21
*** stewie925_ has quit IRC23:21
*** lpetrut has quit IRC23:22
*** akshai has quit IRC23:23
*** shaohe_feng has quit IRC23:23
*** shaohe_feng has joined #openstack-nova23:23
*** BjoernT has quit IRC23:24
*** Jeffrey4l has joined #openstack-nova23:29
*** salv-orl_ has joined #openstack-nova23:29
*** browne has quit IRC23:30
*** salv-orlando has quit IRC23:32
*** sdake has quit IRC23:32
*** shaohe_feng has quit IRC23:33
*** sdake has joined #openstack-nova23:33
openstackgerritmelanie witt proposed openstack/nova: Add instance groups tables to the API database  https://review.openstack.org/32971923:34
*** shaohe_feng has joined #openstack-nova23:34
*** browne has joined #openstack-nova23:35
*** rcernin has quit IRC23:40
*** stewie925 has quit IRC23:41
*** shaohe_feng has quit IRC23:43
*** stewie925 has joined #openstack-nova23:43
*** shaohe_feng has joined #openstack-nova23:44
*** Sukhdev has quit IRC23:45
*** lbeliveau has quit IRC23:46
*** lbeliveau has joined #openstack-nova23:47
*** sdague has quit IRC23:53
*** rk4n has quit IRC23:53
*** shaohe_feng has quit IRC23:54
*** shaohe_feng has joined #openstack-nova23:54
*** hoangcx has joined #openstack-nova23:55
*** xyang1 has quit IRC23:56
*** rk4n has joined #openstack-nova23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!