*** ihrachys has joined #openstack-nova | 00:01 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: policy: Add defaults in code (part 2) https://review.openstack.org/328851 | 00:04 |
---|---|---|
openstackgerrit | Claudiu Belu proposed openstack/nova: policy: Add defaults in code (part 1) https://review.openstack.org/328850 | 00:04 |
openstackgerrit | Claudiu Belu proposed openstack/nova: policy: Add defaults in code (part 3) https://review.openstack.org/329227 | 00:04 |
openstackgerrit | Claudiu Belu proposed openstack/nova: policy: Add defaults in code (part 4) https://review.openstack.org/329228 | 00:04 |
*** sameo_ has quit IRC | 00:06 | |
*** shaohe_feng has quit IRC | 00:09 | |
*** shaohe_feng has joined #openstack-nova | 00:10 | |
*** anteaya has joined #openstack-nova | 00:11 | |
*** claudiub has quit IRC | 00:15 | |
*** rrecio has quit IRC | 00:17 | |
*** ihrachys has quit IRC | 00:17 | |
*** jamesdenton has joined #openstack-nova | 00:18 | |
*** diogogmt has quit IRC | 00:18 | |
*** shaohe_feng has quit IRC | 00:19 | |
*** thorst has joined #openstack-nova | 00:19 | |
*** shaohe_feng has joined #openstack-nova | 00:20 | |
*** sacharya has joined #openstack-nova | 00:20 | |
*** sacharya_ has quit IRC | 00:20 | |
*** tbachman has quit IRC | 00:21 | |
*** ircuser-1 has quit IRC | 00:21 | |
*** tbachman has joined #openstack-nova | 00:21 | |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: Trivial: Remove image_meta from update_usage_from_migration() https://review.openstack.org/329233 | 00:21 |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: Trivial: Remove unused argument image_meta from update_usage_from_migration() https://review.openstack.org/329233 | 00:23 |
*** jwcroppe_ has quit IRC | 00:23 | |
*** Jeffrey4l has joined #openstack-nova | 00:23 | |
*** MikeG451_ has quit IRC | 00:24 | |
*** tbachman_ has joined #openstack-nova | 00:27 | |
*** baoli has quit IRC | 00:28 | |
*** baoli has joined #openstack-nova | 00:28 | |
*** betherly has quit IRC | 00:28 | |
*** betherly has joined #openstack-nova | 00:29 | |
*** jianghuaw has quit IRC | 00:29 | |
*** shaohe_feng has quit IRC | 00:29 | |
*** mtanin___ has joined #openstack-nova | 00:30 | |
*** tbachman has quit IRC | 00:30 | |
*** yamahata has quit IRC | 00:30 | |
*** tbachman_ is now known as tbachman | 00:30 | |
*** shaohe_feng has joined #openstack-nova | 00:30 | |
*** ircuser-1 has joined #openstack-nova | 00:30 | |
*** mtanino has quit IRC | 00:31 | |
*** yamahata has joined #openstack-nova | 00:31 | |
*** jwcroppe has joined #openstack-nova | 00:33 | |
*** rrecio has joined #openstack-nova | 00:37 | |
*** rrecio_ has joined #openstack-nova | 00:38 | |
*** shaohe_feng has quit IRC | 00:39 | |
*** thorst has quit IRC | 00:40 | |
*** shaohe_feng has joined #openstack-nova | 00:40 | |
*** tbachman has left #openstack-nova | 00:41 | |
*** sacharya has quit IRC | 00:41 | |
*** zz_dimtruck is now known as dimtruck | 00:41 | |
*** thorst has joined #openstack-nova | 00:41 | |
*** tbachman has joined #openstack-nova | 00:41 | |
*** rrecio has quit IRC | 00:41 | |
*** browne has quit IRC | 00:41 | |
*** Sukhdev has quit IRC | 00:49 | |
*** rrecio_ has quit IRC | 00:49 | |
*** thorst has quit IRC | 00:49 | |
*** shaohe_feng has quit IRC | 00:50 | |
*** shaohe_feng has joined #openstack-nova | 00:50 | |
*** ijw has quit IRC | 00:51 | |
*** baoli has quit IRC | 00:53 | |
*** ijw has joined #openstack-nova | 00:55 | |
*** cheneydc has joined #openstack-nova | 00:56 | |
*** dimtruck is now known as zz_dimtruck | 00:57 | |
*** stewie925 has quit IRC | 00:58 | |
*** hoangcx has quit IRC | 00:59 | |
*** tbachman has quit IRC | 01:00 | |
*** shaohe_feng has quit IRC | 01:00 | |
*** ssurana has joined #openstack-nova | 01:00 | |
*** shaohe_feng has joined #openstack-nova | 01:00 | |
*** zul has joined #openstack-nova | 01:04 | |
*** Apoorva_ has quit IRC | 01:04 | |
*** amotoki has joined #openstack-nova | 01:06 | |
*** fishcried has joined #openstack-nova | 01:10 | |
*** shaohe_feng has quit IRC | 01:10 | |
*** fishcried has quit IRC | 01:10 | |
*** shaohe_feng has joined #openstack-nova | 01:11 | |
*** Daisy has joined #openstack-nova | 01:12 | |
*** ijw has quit IRC | 01:13 | |
*** hoangcx has joined #openstack-nova | 01:13 | |
*** timello_ has quit IRC | 01:14 | |
*** baoli has joined #openstack-nova | 01:16 | |
*** shaohe_feng has quit IRC | 01:20 | |
*** amotoki has quit IRC | 01:21 | |
*** shaohe_feng has joined #openstack-nova | 01:21 | |
*** artom has joined #openstack-nova | 01:22 | |
*** fragatina has quit IRC | 01:23 | |
*** hoangcx has quit IRC | 01:25 | |
*** baoli has quit IRC | 01:26 | |
*** hoangcx has joined #openstack-nova | 01:27 | |
*** shaohe_feng has quit IRC | 01:31 | |
*** pushkaru has quit IRC | 01:31 | |
*** shaohe_feng has joined #openstack-nova | 01:31 | |
*** pushkaru has joined #openstack-nova | 01:32 | |
*** EinstCrazy has joined #openstack-nova | 01:33 | |
*** thorst has joined #openstack-nova | 01:34 | |
*** Daisy has quit IRC | 01:34 | |
*** Daisy has joined #openstack-nova | 01:35 | |
*** Daisy_ has joined #openstack-nova | 01:35 | |
*** Daisy_ has quit IRC | 01:36 | |
*** Daisy_ has joined #openstack-nova | 01:36 | |
*** Daisy has quit IRC | 01:39 | |
*** amotoki has joined #openstack-nova | 01:39 | |
*** pushkaru has quit IRC | 01:40 | |
*** zz_dimtruck is now known as dimtruck | 01:41 | |
*** zul has quit IRC | 01:41 | |
*** shaohe_feng has quit IRC | 01:41 | |
*** shaohe_feng has joined #openstack-nova | 01:42 | |
*** raunak has quit IRC | 01:46 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Remove python code validation specific to legacy_v2 https://review.openstack.org/328931 | 01:47 |
*** hoangcx has quit IRC | 01:48 | |
gmann | mriedem_away: ^^ check if this is ok. | 01:49 |
*** hoangcx_ has joined #openstack-nova | 01:50 | |
*** EinstCra_ has joined #openstack-nova | 01:51 | |
*** shaohe_feng has quit IRC | 01:51 | |
*** shaohe_feng has joined #openstack-nova | 01:52 | |
*** abcxyz has joined #openstack-nova | 01:52 | |
*** hoangcx_ has quit IRC | 01:53 | |
*** hoangcx_ has joined #openstack-nova | 01:53 | |
*** zul has joined #openstack-nova | 01:54 | |
*** abcxyz has quit IRC | 01:55 | |
*** EinstCrazy has quit IRC | 01:55 | |
*** ssurana has quit IRC | 01:55 | |
*** hoangcx_ is now known as hoangcx | 01:56 | |
*** Daisy has joined #openstack-nova | 01:58 | |
*** EinstCra_ has quit IRC | 01:58 | |
*** abcxyz has joined #openstack-nova | 01:59 | |
*** EinstCrazy has joined #openstack-nova | 01:59 | |
*** sacharya has joined #openstack-nova | 01:59 | |
*** sacharya has quit IRC | 01:59 | |
*** Daisy_ has quit IRC | 02:00 | |
*** EinstCrazy has quit IRC | 02:01 | |
*** hoangcx has quit IRC | 02:01 | |
*** shaohe_feng has quit IRC | 02:01 | |
*** shaohe_feng has joined #openstack-nova | 02:02 | |
*** EinstCrazy has joined #openstack-nova | 02:03 | |
*** dimtruck is now known as zz_dimtruck | 02:06 | |
*** erlon has quit IRC | 02:06 | |
*** hoangcx has joined #openstack-nova | 02:06 | |
*** zz_dimtruck is now known as dimtruck | 02:06 | |
*** amotoki has quit IRC | 02:07 | |
*** abcxyz has quit IRC | 02:07 | |
*** amotoki has joined #openstack-nova | 02:07 | |
*** abcxyz has joined #openstack-nova | 02:07 | |
*** tbachman has joined #openstack-nova | 02:09 | |
*** mfisch has quit IRC | 02:10 | |
*** Daisy has quit IRC | 02:11 | |
*** Daisy has joined #openstack-nova | 02:11 | |
*** shaohe_feng has quit IRC | 02:12 | |
*** gjayavelu has quit IRC | 02:12 | |
*** yamahata has quit IRC | 02:12 | |
*** shaohe_feng has joined #openstack-nova | 02:13 | |
*** mtanino has joined #openstack-nova | 02:16 | |
*** mtanin___ has quit IRC | 02:18 | |
*** Daisy_ has joined #openstack-nova | 02:20 | |
*** EinstCrazy has quit IRC | 02:20 | |
*** shaohe_feng has quit IRC | 02:22 | |
*** shaohe_feng has joined #openstack-nova | 02:23 | |
*** Daisy has quit IRC | 02:23 | |
*** EinstCrazy has joined #openstack-nova | 02:29 | |
*** ssurana has joined #openstack-nova | 02:29 | |
*** ssurana has quit IRC | 02:30 | |
*** dave-mccowan has quit IRC | 02:32 | |
*** shaohe_feng has quit IRC | 02:32 | |
*** abcxyz has quit IRC | 02:32 | |
*** shaohe_feng has joined #openstack-nova | 02:33 | |
*** sacharya has joined #openstack-nova | 02:34 | |
*** abcxyz has joined #openstack-nova | 02:34 | |
*** ssurana has joined #openstack-nova | 02:35 | |
*** ssurana has quit IRC | 02:36 | |
*** mtanino has quit IRC | 02:37 | |
*** artom has quit IRC | 02:38 | |
*** artom has joined #openstack-nova | 02:39 | |
*** amotoki has quit IRC | 02:40 | |
*** shaohe_feng has quit IRC | 02:42 | |
*** shaohe_feng has joined #openstack-nova | 02:43 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Add swap volume notifications samples https://review.openstack.org/328866 | 02:43 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Add swap volume notifications (start, end) https://review.openstack.org/250283 | 02:44 |
*** EinstCrazy has quit IRC | 02:45 | |
*** EinstCrazy has joined #openstack-nova | 02:45 | |
*** ssurana has joined #openstack-nova | 02:46 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Add swap volume notifications (error) https://review.openstack.org/328055 | 02:47 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Add swap volume notifications samples https://review.openstack.org/328866 | 02:47 |
*** jamesdenton has quit IRC | 02:48 | |
*** woodster_ has quit IRC | 02:48 | |
*** sacharya_ has joined #openstack-nova | 02:49 | |
*** ssurana has quit IRC | 02:50 | |
*** takashin has joined #openstack-nova | 02:51 | |
*** sacharya has quit IRC | 02:52 | |
*** sudipto has joined #openstack-nova | 02:52 | |
*** shaohe_feng has quit IRC | 02:53 | |
*** amotoki has joined #openstack-nova | 02:54 | |
*** artom_ has joined #openstack-nova | 02:55 | |
*** ijw has joined #openstack-nova | 02:56 | |
*** shaohe_feng has joined #openstack-nova | 02:56 | |
*** raunak has joined #openstack-nova | 02:56 | |
*** artom has quit IRC | 02:56 | |
*** amotoki has quit IRC | 02:57 | |
*** thorst has quit IRC | 03:00 | |
*** gjayavelu has joined #openstack-nova | 03:00 | |
*** thorst has joined #openstack-nova | 03:00 | |
*** EinstCrazy has quit IRC | 03:01 | |
*** adisky has joined #openstack-nova | 03:02 | |
*** shaohe_feng has quit IRC | 03:03 | |
*** EinstCrazy has joined #openstack-nova | 03:04 | |
*** shaohe_feng has joined #openstack-nova | 03:04 | |
*** ijw has quit IRC | 03:04 | |
*** abcxyz has quit IRC | 03:05 | |
*** tbachman has quit IRC | 03:07 | |
*** links has joined #openstack-nova | 03:08 | |
*** thorst has quit IRC | 03:09 | |
*** abcxyz has joined #openstack-nova | 03:09 | |
*** pwnall1 has quit IRC | 03:10 | |
*** tbachman has joined #openstack-nova | 03:10 | |
*** openstackgerrit has quit IRC | 03:11 | |
*** openstackgerrit has joined #openstack-nova | 03:11 | |
*** shaohe_feng has quit IRC | 03:13 | |
*** shaohe_feng has joined #openstack-nova | 03:16 | |
*** M00nr41n has joined #openstack-nova | 03:17 | |
*** dimtruck is now known as zz_dimtruck | 03:18 | |
*** rama_y has quit IRC | 03:18 | |
*** abcxyz has quit IRC | 03:19 | |
*** caowei has joined #openstack-nova | 03:19 | |
*** abcxyz has joined #openstack-nova | 03:20 | |
*** M00nr41n has quit IRC | 03:21 | |
*** shaohe_feng has quit IRC | 03:23 | |
*** shaohe_feng has joined #openstack-nova | 03:24 | |
*** sacharya_ has quit IRC | 03:27 | |
*** sacharya has joined #openstack-nova | 03:28 | |
openstackgerrit | Anusha Unnam proposed openstack/nova: Transform instance.resize notifications https://review.openstack.org/329255 | 03:28 |
*** yamahata has joined #openstack-nova | 03:29 | |
*** sacharya_ has joined #openstack-nova | 03:30 | |
*** abcxyz has quit IRC | 03:31 | |
*** abcxyz has joined #openstack-nova | 03:32 | |
*** sacharya has quit IRC | 03:32 | |
*** sacharya has joined #openstack-nova | 03:33 | |
*** shaohe_feng has quit IRC | 03:34 | |
openstackgerrit | Anusha Unnam proposed openstack/nova: Transform instance.resize notifications https://review.openstack.org/329255 | 03:34 |
*** shaohe_feng has joined #openstack-nova | 03:34 | |
*** sacharya_ has quit IRC | 03:36 | |
*** klkumar has joined #openstack-nova | 03:39 | |
*** raunak has quit IRC | 03:39 | |
*** raunak has joined #openstack-nova | 03:41 | |
*** shaohe_feng has quit IRC | 03:44 | |
*** vishwanathj has joined #openstack-nova | 03:44 | |
*** shaohe_feng has joined #openstack-nova | 03:44 | |
*** ociuhandu has quit IRC | 03:45 | |
*** ociuhandu has joined #openstack-nova | 03:49 | |
*** ducttape_ has quit IRC | 03:50 | |
*** abcxyz has quit IRC | 03:51 | |
*** abcxyz has joined #openstack-nova | 03:52 | |
*** shaohe_feng has quit IRC | 03:54 | |
*** shaohe_feng has joined #openstack-nova | 03:55 | |
*** ayoung has quit IRC | 03:56 | |
*** caowei has quit IRC | 03:57 | |
*** vishwanathj has quit IRC | 03:58 | |
*** fishcried has joined #openstack-nova | 03:58 | |
*** vishwanathj has joined #openstack-nova | 03:58 | |
*** abcxyz has quit IRC | 04:00 | |
*** zerda2 has joined #openstack-nova | 04:02 | |
*** abcxyz has joined #openstack-nova | 04:03 | |
*** shaohe_feng has quit IRC | 04:04 | |
*** shaohe_feng has joined #openstack-nova | 04:05 | |
*** ociuhandu has quit IRC | 04:05 | |
*** thorst has joined #openstack-nova | 04:07 | |
*** huyang has quit IRC | 04:08 | |
*** wanghao has quit IRC | 04:10 | |
*** shz has joined #openstack-nova | 04:11 | |
*** wanghao has joined #openstack-nova | 04:11 | |
*** raunak has quit IRC | 04:12 | |
*** hanzhang has quit IRC | 04:14 | |
*** thorst has quit IRC | 04:14 | |
*** shaohe_feng has quit IRC | 04:15 | |
*** diga has joined #openstack-nova | 04:15 | |
*** shaohe_feng has joined #openstack-nova | 04:15 | |
*** markvoelker has quit IRC | 04:16 | |
*** vishwana_ has joined #openstack-nova | 04:17 | |
*** vishwanathj has quit IRC | 04:20 | |
*** vishwana_ has quit IRC | 04:22 | |
*** vishwanathj has joined #openstack-nova | 04:24 | |
*** shaohe_feng has quit IRC | 04:25 | |
*** shaohe_feng has joined #openstack-nova | 04:26 | |
*** Daisy_ has quit IRC | 04:26 | |
*** sree_ has joined #openstack-nova | 04:27 | |
*** sree_ is now known as Guest94631 | 04:27 | |
*** raunak has joined #openstack-nova | 04:33 | |
*** shaohe_feng has quit IRC | 04:35 | |
*** shaohe_feng has joined #openstack-nova | 04:35 | |
*** abcxyz has quit IRC | 04:36 | |
*** ssurana has joined #openstack-nova | 04:36 | |
openstackgerrit | Andrew Laski proposed openstack/nova: Add CellMappingList object https://review.openstack.org/329216 | 04:36 |
*** sudipto has quit IRC | 04:37 | |
*** abcxyz has joined #openstack-nova | 04:39 | |
*** pcaruana has quit IRC | 04:39 | |
*** diga has quit IRC | 04:39 | |
*** irenab has quit IRC | 04:41 | |
*** ratailor has joined #openstack-nova | 04:41 | |
openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova: Transform instance.shutdown notifications https://review.openstack.org/329214 | 04:44 |
*** fragatina has joined #openstack-nova | 04:45 | |
*** diga has joined #openstack-nova | 04:45 | |
*** shaohe_feng has quit IRC | 04:45 | |
*** artom_ has quit IRC | 04:46 | |
*** shaohe_feng has joined #openstack-nova | 04:46 | |
*** artom has joined #openstack-nova | 04:47 | |
*** fragatina has quit IRC | 04:50 | |
*** caowei has joined #openstack-nova | 04:51 | |
*** klkumar has quit IRC | 04:53 | |
*** klkumar1 has joined #openstack-nova | 04:53 | |
*** klkumar1 has quit IRC | 04:54 | |
*** zhenguo_ has joined #openstack-nova | 04:54 | |
*** klkumar has joined #openstack-nova | 04:55 | |
*** shaohe_feng has quit IRC | 04:56 | |
*** shaohe_feng has joined #openstack-nova | 04:56 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix parameters in os-instance-usage-audit-log https://review.openstack.org/328981 | 05:00 |
*** M00nr41n has joined #openstack-nova | 05:00 | |
*** ssurana has quit IRC | 05:03 | |
*** ssurana has joined #openstack-nova | 05:04 | |
*** sheel has joined #openstack-nova | 05:05 | |
*** ssurana has quit IRC | 05:05 | |
*** moshele has joined #openstack-nova | 05:06 | |
*** shaohe_feng has quit IRC | 05:06 | |
*** shaohe_feng has joined #openstack-nova | 05:07 | |
*** ishant|away is now known as ishant | 05:07 | |
*** Daisy has joined #openstack-nova | 05:07 | |
*** ssurana has joined #openstack-nova | 05:08 | |
*** lpetrut has joined #openstack-nova | 05:09 | |
*** Daisy_ has joined #openstack-nova | 05:11 | |
*** Daisy has quit IRC | 05:11 | |
*** jaosorior has joined #openstack-nova | 05:11 | |
*** thorst has joined #openstack-nova | 05:12 | |
*** ssurana has quit IRC | 05:13 | |
*** sacharya has quit IRC | 05:16 | |
*** sacharya has joined #openstack-nova | 05:16 | |
*** shaohe_feng has quit IRC | 05:16 | |
*** markvoelker has joined #openstack-nova | 05:17 | |
*** shaohe_feng has joined #openstack-nova | 05:17 | |
*** salv-orl_ has quit IRC | 05:17 | |
*** ljxiash has joined #openstack-nova | 05:17 | |
*** vladikr has quit IRC | 05:18 | |
*** salv-orlando has joined #openstack-nova | 05:18 | |
*** sridharg has joined #openstack-nova | 05:18 | |
*** thorst has quit IRC | 05:19 | |
*** markvoelker has quit IRC | 05:22 | |
*** itamarl has joined #openstack-nova | 05:22 | |
*** prateek has joined #openstack-nova | 05:25 | |
*** shaohe_feng has quit IRC | 05:26 | |
*** shaohe_feng has joined #openstack-nova | 05:27 | |
*** salv-orl_ has joined #openstack-nova | 05:29 | |
*** ssurana has joined #openstack-nova | 05:29 | |
*** prateek has quit IRC | 05:30 | |
*** ecelik has joined #openstack-nova | 05:31 | |
*** salv-orlando has quit IRC | 05:31 | |
*** ssurana has quit IRC | 05:34 | |
*** ssurana has joined #openstack-nova | 05:34 | |
*** salv-orl_ has quit IRC | 05:34 | |
*** salv-orlando has joined #openstack-nova | 05:34 | |
*** shaohe_feng has quit IRC | 05:37 | |
*** shaohe_feng has joined #openstack-nova | 05:38 | |
*** EinstCrazy has quit IRC | 05:40 | |
*** raunak has quit IRC | 05:40 | |
*** Guest94631 has quit IRC | 05:46 | |
*** sree has joined #openstack-nova | 05:47 | |
*** shaohe_feng has quit IRC | 05:47 | |
*** shaohe_feng has joined #openstack-nova | 05:48 | |
*** sree has quit IRC | 05:49 | |
*** sree has joined #openstack-nova | 05:50 | |
*** cfriesen has quit IRC | 05:53 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Deprecated option 'mkisofs_cmd' for removal https://review.openstack.org/262744 | 05:53 |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Fix outdated parameter network_info description in virt/driver https://review.openstack.org/263166 | 05:54 |
*** vishwanathj has quit IRC | 05:54 | |
*** shaohe_feng has quit IRC | 05:57 | |
*** shaohe_feng has joined #openstack-nova | 05:58 | |
*** Sukhdev has joined #openstack-nova | 06:00 | |
*** ssurana has quit IRC | 06:00 | |
*** liverpooler has quit IRC | 06:00 | |
*** liverpooler has joined #openstack-nova | 06:01 | |
*** ssurana has joined #openstack-nova | 06:02 | |
*** ssurana has quit IRC | 06:07 | |
*** chandankumar has joined #openstack-nova | 06:07 | |
*** shaohe_feng has quit IRC | 06:07 | |
*** shaohe_feng has joined #openstack-nova | 06:08 | |
*** Daisy_ has quit IRC | 06:11 | |
*** rcernin has joined #openstack-nova | 06:11 | |
*** Daisy has joined #openstack-nova | 06:12 | |
*** salv-orlando has quit IRC | 06:13 | |
*** salv-orlando has joined #openstack-nova | 06:14 | |
*** Daisy has quit IRC | 06:16 | |
*** pcaruana has joined #openstack-nova | 06:16 | |
*** thorst has joined #openstack-nova | 06:16 | |
*** jbernard has quit IRC | 06:17 | |
*** shaohe_feng has quit IRC | 06:18 | |
*** paul-carlton2 has quit IRC | 06:18 | |
*** csatari has joined #openstack-nova | 06:19 | |
*** jbernard has joined #openstack-nova | 06:19 | |
*** vishwanathj has joined #openstack-nova | 06:19 | |
*** apoorv has joined #openstack-nova | 06:19 | |
*** shaohe_feng has joined #openstack-nova | 06:21 | |
*** abcxyz has quit IRC | 06:21 | |
*** abcxyz has joined #openstack-nova | 06:22 | |
*** yamahata has quit IRC | 06:23 | |
*** thorst has quit IRC | 06:24 | |
*** yamahata has joined #openstack-nova | 06:26 | |
*** shaohe_feng has quit IRC | 06:28 | |
*** shaohe_feng has joined #openstack-nova | 06:29 | |
openstackgerrit | Dinesh Bhor proposed openstack/nova: Return HTTP 200 on list for invalid status https://review.openstack.org/315964 | 06:30 |
*** chandankumar has quit IRC | 06:32 | |
*** EinstCrazy has joined #openstack-nova | 06:32 | |
*** Daisy has joined #openstack-nova | 06:33 | |
ratailor | I am sending a patchset which is a dependency of another patchset under review. When I try to push my patch, it sends two patches in which one is a duplicate of patchset under review. Can someone let me know how to just send the last patch, and not the one it is dependent on ? | 06:38 |
*** jwcroppe has quit IRC | 06:38 | |
*** shaohe_feng has quit IRC | 06:38 | |
*** EinstCrazy has quit IRC | 06:39 | |
*** shaohe_feng has joined #openstack-nova | 06:39 | |
*** Sukhdev has quit IRC | 06:39 | |
*** ihrachys has joined #openstack-nova | 06:41 | |
*** EinstCrazy has joined #openstack-nova | 06:41 | |
*** andreas_s has joined #openstack-nova | 06:42 | |
*** EinstCrazy has quit IRC | 06:44 | |
*** sudipto has joined #openstack-nova | 06:44 | |
*** EinstCrazy has joined #openstack-nova | 06:44 | |
*** prateek has joined #openstack-nova | 06:46 | |
*** laszloh has joined #openstack-nova | 06:46 | |
*** abcxyz has quit IRC | 06:46 | |
*** jwcroppe has joined #openstack-nova | 06:47 | |
ratailor | openstack, I am sending a patchset which is a dependency of another patchset under review. When I try to push my patch, it sends two patches in which one is a duplicate of patchset under review. Can someone let me know how to just send the last patch, and not the one it is dependent on ? | 06:47 |
openstackgerrit | Rong Han proposed openstack/nova: [libvirt]Optimize _get_instance_disk_info https://review.openstack.org/297598 | 06:47 |
prateek | ratailor, i have also faced such a problem, does someone know how to do what Rajesh has asked ? | 06:47 |
*** openstackgerrit has quit IRC | 06:48 | |
*** openstackgerrit has joined #openstack-nova | 06:48 | |
*** shaohe_feng has quit IRC | 06:48 | |
*** chandankumar has joined #openstack-nova | 06:49 | |
*** shaohe_feng has joined #openstack-nova | 06:49 | |
*** ociuhandu has joined #openstack-nova | 06:50 | |
*** mpavone has joined #openstack-nova | 06:51 | |
*** ducttape_ has joined #openstack-nova | 06:51 | |
*** tesseract has joined #openstack-nova | 06:56 | |
*** Hosam has joined #openstack-nova | 06:56 | |
*** Hosam has quit IRC | 06:56 | |
*** ducttape_ has quit IRC | 06:56 | |
*** Hosam has joined #openstack-nova | 06:56 | |
sudipto | ratailor, prateek it doesn't send a new patchset for the parent unless you have switched repos or changed revisions of the parent and your new patchset wants to get updated with the latest references. | 06:57 |
prateek | sudipto, thanks | 06:57 |
ratailor | sudipto, thanks | 06:57 |
*** shaohe_feng has quit IRC | 06:59 | |
*** shaohe_feng has joined #openstack-nova | 06:59 | |
*** EinstCrazy has quit IRC | 06:59 | |
*** EinstCrazy has joined #openstack-nova | 07:00 | |
*** abcxyz has joined #openstack-nova | 07:00 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: Introduce utility module for pcp https://review.openstack.org/203163 | 07:00 |
openstackgerrit | Sudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor https://review.openstack.org/266773 | 07:00 |
*** hoangcx has quit IRC | 07:03 | |
*** sacharya has quit IRC | 07:03 | |
*** abcxyz has quit IRC | 07:04 | |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: Add new configuration option to turn auto converge on/off https://review.openstack.org/266001 | 07:05 |
*** hoangcx has joined #openstack-nova | 07:06 | |
*** shaohe_feng has quit IRC | 07:09 | |
*** edand has joined #openstack-nova | 07:09 | |
*** shaohe_feng has joined #openstack-nova | 07:10 | |
*** vtech has joined #openstack-nova | 07:11 | |
csatari | I have a correction to the documentation where tempest-dsvm-intel-nfv fails with some totally unrelated error. Is there any hint what can be the problem? | 07:12 |
csatari | https://review.openstack.org/#/c/327112/ | 07:12 |
*** gjayavelu has quit IRC | 07:16 | |
*** hoangcx has quit IRC | 07:17 | |
sudipto | csatari, i don't think it's related to your patch. Just do a re-check and see if it fails again/ | 07:18 |
sudipto | ? | 07:18 |
*** markvoelker has joined #openstack-nova | 07:18 | |
csatari | sudipto: Thanks. I've tried "recheck tempest-dsvm-intel-nfv". | 07:19 |
*** shaohe_feng has quit IRC | 07:19 | |
csatari | But for me it seems that some othe rbuild job is executed. | 07:19 |
csatari | Jenkins returns with this: | 07:20 |
*** shaohe_feng has joined #openstack-nova | 07:20 | |
csatari | Patch Set 1: | 07:20 |
csatari | Build succeeded (check pipeline). | 07:20 |
csatari | gate-nova-docs SUCCESS in 3m 59s | 07:20 |
csatari | gate-nova-pep8 SUCCESS in 6m 19s | 07:20 |
csatari | gate-nova-api-ref SUCCESS in 3m 24s | 07:20 |
csatari | But the status is still "tempest-dsvm-intel-nfvFAILURE in 37m 56s" | 07:20 |
*** pece has joined #openstack-nova | 07:21 | |
*** jichen has joined #openstack-nova | 07:21 | |
*** thorst has joined #openstack-nova | 07:22 | |
*** markvoelker has quit IRC | 07:22 | |
*** jlanoux has joined #openstack-nova | 07:26 | |
*** hoangcx has joined #openstack-nova | 07:28 | |
*** thorst has quit IRC | 07:29 | |
*** shaohe_feng has quit IRC | 07:29 | |
*** shaohe_feng has joined #openstack-nova | 07:30 | |
*** dmk0202 has joined #openstack-nova | 07:32 | |
*** pece has quit IRC | 07:32 | |
*** sree has quit IRC | 07:33 | |
*** sree has joined #openstack-nova | 07:34 | |
*** irenab has joined #openstack-nova | 07:35 | |
*** jaosorior is now known as jaosorior_brb | 07:35 | |
*** jlanoux has quit IRC | 07:37 | |
*** paul-carlton2 has joined #openstack-nova | 07:37 | |
*** EinstCrazy has quit IRC | 07:37 | |
*** jlanoux has joined #openstack-nova | 07:38 | |
*** takashin_ has joined #openstack-nova | 07:38 | |
*** sree has quit IRC | 07:38 | |
*** takashin has quit IRC | 07:39 | |
*** jlanoux has quit IRC | 07:39 | |
*** shaohe_feng has quit IRC | 07:40 | |
*** EinstCrazy has joined #openstack-nova | 07:40 | |
*** shaohe_feng has joined #openstack-nova | 07:40 | |
*** yamahata has quit IRC | 07:41 | |
*** lpetrut has quit IRC | 07:42 | |
openstackgerrit | melanie witt proposed openstack/nova: Disallow instance tag set for invalid instance states https://review.openstack.org/329304 | 07:43 |
*** salv-orlando has quit IRC | 07:44 | |
*** salv-orlando has joined #openstack-nova | 07:44 | |
*** EinstCrazy has quit IRC | 07:45 | |
*** EinstCrazy has joined #openstack-nova | 07:45 | |
*** sree has joined #openstack-nova | 07:47 | |
*** fragatina has joined #openstack-nova | 07:49 | |
*** EinstCrazy has quit IRC | 07:49 | |
BobBall | johnthetubaguy: Could you re-add Citrix XenServer CI to https://review.openstack.org/#/admin/groups/511,members pls | 07:49 |
*** EinstCrazy has joined #openstack-nova | 07:50 | |
BobBall | johnthetubaguy: Fix merged 6 hours ago, so we want to recheck all failed jobs https://review.openstack.org/#/c/328836/ | 07:50 |
*** shaohe_feng has quit IRC | 07:50 | |
*** shaohe_feng has joined #openstack-nova | 07:50 | |
*** M00nr41n has left #openstack-nova | 07:50 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 07:53 |
*** fragatina has quit IRC | 07:55 | |
*** EinstCrazy has quit IRC | 07:55 | |
*** hoangcx has quit IRC | 07:57 | |
*** hoangcx has joined #openstack-nova | 07:58 | |
*** zzzeek has quit IRC | 08:00 | |
*** danpb has joined #openstack-nova | 08:00 | |
*** zzzeek has joined #openstack-nova | 08:00 | |
*** shaohe_feng has quit IRC | 08:00 | |
*** EinstCrazy has joined #openstack-nova | 08:01 | |
*** jlanoux has joined #openstack-nova | 08:02 | |
*** shaohe_feng has joined #openstack-nova | 08:03 | |
*** roeyc has joined #openstack-nova | 08:07 | |
*** sfinucan has joined #openstack-nova | 08:10 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/303345 | 08:10 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/303345 | 08:10 |
*** shaohe_feng has quit IRC | 08:10 | |
*** shaohe_feng has joined #openstack-nova | 08:11 | |
*** lhinds_ has joined #openstack-nova | 08:12 | |
csatari | sudipto: And the build log still dates back for the first execution: http://intel-openstack-ci-logs.ovh/12/327112/1/check/tempest-dsvm-intel-nfv/0db06f2/ | 08:12 |
csatari | Shall I try a full recheck? | 08:13 |
csatari | What can go wrong ;) | 08:13 |
*** artom has quit IRC | 08:14 | |
*** artom has joined #openstack-nova | 08:15 | |
sudipto | csatari, sorry, was out for lunch. Yeah try a full recheck | 08:16 |
*** Daisy has quit IRC | 08:19 | |
*** Daisy has joined #openstack-nova | 08:19 | |
*** ljxiash has quit IRC | 08:20 | |
*** shaohe_feng has quit IRC | 08:21 | |
*** shaohe_feng has joined #openstack-nova | 08:22 | |
*** sameo_ has joined #openstack-nova | 08:23 | |
*** muawiakhan has joined #openstack-nova | 08:24 | |
*** mvk has quit IRC | 08:24 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor https://review.openstack.org/266773 | 08:25 |
*** diga has quit IRC | 08:25 | |
*** thorst has joined #openstack-nova | 08:26 | |
openstackgerrit | jichenjc proposed openstack/nova: Use instance object instead of db record https://review.openstack.org/234218 | 08:27 |
*** pece has joined #openstack-nova | 08:28 | |
openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: Ensure that periodic reclaim is able to clean DB deleted instances https://review.openstack.org/323250 | 08:29 |
*** shaohe_feng has quit IRC | 08:31 | |
*** shaohe_feng has joined #openstack-nova | 08:32 | |
*** ljxiash has joined #openstack-nova | 08:32 | |
*** hoangcx has quit IRC | 08:33 | |
*** thorst has quit IRC | 08:34 | |
*** mnestratov has joined #openstack-nova | 08:35 | |
*** hoangcx has joined #openstack-nova | 08:35 | |
*** cdent has joined #openstack-nova | 08:37 | |
*** jaosorior_brb has quit IRC | 08:39 | |
*** jaosorior_brb has joined #openstack-nova | 08:40 | |
*** vishwanathj has quit IRC | 08:40 | |
*** derekh has joined #openstack-nova | 08:40 | |
*** vishwanathj has joined #openstack-nova | 08:41 | |
*** shaohe_feng has quit IRC | 08:41 | |
*** shaohe_feng has joined #openstack-nova | 08:42 | |
*** eglynn has joined #openstack-nova | 08:43 | |
*** Qiming is now known as Qiming_afk | 08:43 | |
openstackgerrit | Daniel Berrange proposed openstack/nova: os-vif: convert libvirt driver to use os-vif library https://review.openstack.org/269672 | 08:44 |
*** hoangcx has quit IRC | 08:45 | |
*** srushti has joined #openstack-nova | 08:46 | |
*** yassine has joined #openstack-nova | 08:48 | |
*** matrohon has joined #openstack-nova | 08:50 | |
srushti | johnthetubaguy: Hi, Could you please review this patch https://review.openstack.org/#/c/324320/ | 08:51 |
*** mvk has joined #openstack-nova | 08:51 | |
*** shaohe_feng has quit IRC | 08:51 | |
*** EinstCrazy has quit IRC | 08:52 | |
*** ducttape_ has joined #openstack-nova | 08:52 | |
*** shaohe_feng has joined #openstack-nova | 08:52 | |
*** jaosorior_brb is now known as jaosorior | 08:53 | |
*** EinstCrazy has joined #openstack-nova | 08:54 | |
*** Dinesh_Bhor has joined #openstack-nova | 08:55 | |
*** ducttape_ has quit IRC | 08:58 | |
*** artom has quit IRC | 08:58 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: api-ref: verify images.inc https://review.openstack.org/326871 | 09:00 |
*** artom has joined #openstack-nova | 09:00 | |
tdurakov | johnthetubaguy: hi, are you around? | 09:01 |
*** shaohe_feng has quit IRC | 09:02 | |
johnthetubaguy | tdurakov: I am | 09:02 |
*** shaohe_feng has joined #openstack-nova | 09:02 | |
* cdent watches johnthetubaguy and tdurakov because he's lonely | 09:02 | |
*** Daisy_ has joined #openstack-nova | 09:02 | |
* johnthetubaguy waves at cdent to in the hope of making him feel better | 09:03 | |
tdurakov | johnthetubaguy: take a look: https://github.com/openstack/nova/blob/master/nova/virt/xenapi/pool.py#L104 - I feel it worth to call rpcapi from compute manager, rather than driver package module | 09:03 |
* cdent squeeeeees | 09:03 | |
tdurakov | cdent: hey:) | 09:03 |
tdurakov | johnthetubaguy: what do you think? | 09:03 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 09:04 |
johnthetubaguy | tdurakov: I personally want to remove all that stuff | 09:05 |
johnthetubaguy | tdurakov: but not sure BobBall agrees yet (about the pool support) | 09:05 |
johnthetubaguy | tdurakov: I am not sure its worth fixing right now | 09:05 |
tdurakov | johnthetubaguy: hah, it solution too:) | 09:05 |
tdurakov | sure | 09:05 |
*** Qiming_afk is now known as Qiming | 09:06 | |
*** gszasz has joined #openstack-nova | 09:06 | |
*** Daisy has quit IRC | 09:06 | |
*** lpetrut has joined #openstack-nova | 09:10 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: rest api version bumped for async pre live migration checks https://review.openstack.org/314932 | 09:10 |
openstackgerrit | Timofey Durakov proposed openstack/nova: Make live migration checks async https://review.openstack.org/311116 | 09:10 |
openstackgerrit | Timofey Durakov proposed openstack/nova: Added instance actions for conductor https://review.openstack.org/311115 | 09:10 |
*** EinstCrazy has quit IRC | 09:10 | |
*** EinstCrazy has joined #openstack-nova | 09:10 | |
*** Daisy_ has quit IRC | 09:10 | |
*** Daisy has joined #openstack-nova | 09:11 | |
tdurakov | cdent, johnthetubaguy, could you take a look, when have some time^ | 09:11 |
*** shaohe_feng has quit IRC | 09:12 | |
*** shaohe_feng has joined #openstack-nova | 09:12 | |
cdent | tdurakov: sure | 09:13 |
*** sambetts|afk is now known as sambetts | 09:14 | |
*** Daisy has quit IRC | 09:15 | |
*** EinstCrazy has quit IRC | 09:18 | |
*** EinstCrazy has joined #openstack-nova | 09:18 | |
*** shaohe_feng has quit IRC | 09:22 | |
*** chandankumar has quit IRC | 09:23 | |
*** shaohe_feng has joined #openstack-nova | 09:23 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Remove extra expected error code (413) from image metadata https://review.openstack.org/329335 | 09:28 |
*** PaulMurray has joined #openstack-nova | 09:29 | |
johnthetubaguy | mriedem_away: this one needs the -2 removing now: https://review.openstack.org/#/c/297574/ | 09:31 |
*** thorst has joined #openstack-nova | 09:32 | |
*** shaohe_feng has quit IRC | 09:32 | |
*** EinstCrazy has quit IRC | 09:33 | |
*** shaohe_feng has joined #openstack-nova | 09:33 | |
*** EinstCrazy has joined #openstack-nova | 09:33 | |
*** zenoway has joined #openstack-nova | 09:34 | |
*** ljxiash has quit IRC | 09:38 | |
*** artom has quit IRC | 09:38 | |
*** ljxiash has joined #openstack-nova | 09:38 | |
*** artom has joined #openstack-nova | 09:38 | |
*** thorst has quit IRC | 09:39 | |
*** chandankumar has joined #openstack-nova | 09:39 | |
*** EinstCrazy has quit IRC | 09:41 | |
*** EinstCrazy has joined #openstack-nova | 09:41 | |
openstackgerrit | Eli Qiao proposed openstack/nova: libvirt: add perf event support when create instance https://review.openstack.org/320897 | 09:41 |
openstackgerrit | Eli Qiao proposed openstack/nova: libvirt: Add migration support for perf event support https://review.openstack.org/329339 | 09:41 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding https://review.openstack.org/217567 | 09:42 |
*** gjayavelu has joined #openstack-nova | 09:43 | |
*** gjayavelu has quit IRC | 09:43 | |
*** shaohe_feng has quit IRC | 09:43 | |
*** gjayavelu has joined #openstack-nova | 09:43 | |
*** ljxiash has quit IRC | 09:43 | |
*** shaohe_feng has joined #openstack-nova | 09:43 | |
*** tyrola has joined #openstack-nova | 09:44 | |
*** roeyc has quit IRC | 09:44 | |
*** EinstCrazy has quit IRC | 09:45 | |
*** EinstCrazy has joined #openstack-nova | 09:46 | |
*** mvk has quit IRC | 09:50 | |
*** ociuhandu has quit IRC | 09:51 | |
*** mvk has joined #openstack-nova | 09:51 | |
*** EinstCrazy has quit IRC | 09:53 | |
*** shaohe_feng has quit IRC | 09:53 | |
*** EinstCrazy has joined #openstack-nova | 09:53 | |
*** shaohe_feng has joined #openstack-nova | 09:54 | |
*** apoorv has quit IRC | 09:54 | |
*** apoorv has joined #openstack-nova | 09:59 | |
*** fishcried has quit IRC | 09:59 | |
* mdbooth can no longer remember the difference between block_device_mapping (pre conversion), block_device_mapping (post conversion), block_device_info, disk_info, block_disk_info, volumes (when it's cinder), volumes (when it's any disk), image (when it's from glance), image (when it's not) | 10:00 | |
mdbooth | I consider myself successfully thoroughly confused | 10:01 |
*** cheneydc has quit IRC | 10:01 | |
*** claudiub has joined #openstack-nova | 10:02 | |
*** EinstCrazy has quit IRC | 10:03 | |
*** EinstCrazy has joined #openstack-nova | 10:03 | |
PaulMurray | mdbooth, collaborative development, its the future ! | 10:03 |
*** shaohe_feng has quit IRC | 10:03 | |
*** sree has quit IRC | 10:05 | |
*** shaohe_feng has joined #openstack-nova | 10:06 | |
*** sgordon` is now known as sgordon | 10:06 | |
*** links has quit IRC | 10:07 | |
*** dmk0202 has quit IRC | 10:08 | |
*** hoangcx has joined #openstack-nova | 10:10 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Publish proxy APIs deprecation in api ref doc https://review.openstack.org/329357 | 10:12 |
gmann | johnthetubaguy: mriedem_away alex_xu oomichi : ^^ please check if this looks fine. deprecation of nova proxy APi in doc | 10:13 |
*** ociuhandu has joined #openstack-nova | 10:13 | |
*** shaohe_feng has quit IRC | 10:13 | |
*** shaohe_feng has joined #openstack-nova | 10:14 | |
*** ptm_away has joined #openstack-nova | 10:15 | |
*** PaulMurray has quit IRC | 10:18 | |
*** rk4n has joined #openstack-nova | 10:20 | |
*** muawiakhan has quit IRC | 10:20 | |
*** links has joined #openstack-nova | 10:20 | |
*** shaohe_feng has quit IRC | 10:24 | |
*** shaohe_feng has joined #openstack-nova | 10:24 | |
*** EinstCrazy has quit IRC | 10:25 | |
*** jlanoux_ has joined #openstack-nova | 10:25 | |
*** hoangcx has quit IRC | 10:26 | |
*** gjayavelu has quit IRC | 10:26 | |
*** hoangcx has joined #openstack-nova | 10:26 | |
*** jlanoux has quit IRC | 10:28 | |
*** sdague has joined #openstack-nova | 10:31 | |
*** EinstCrazy has joined #openstack-nova | 10:32 | |
*** roeyc has joined #openstack-nova | 10:34 | |
*** amotoki_ has joined #openstack-nova | 10:34 | |
*** shaohe_feng has quit IRC | 10:34 | |
*** shaohe_feng has joined #openstack-nova | 10:35 | |
*** thorst has joined #openstack-nova | 10:35 | |
*** EinstCrazy has quit IRC | 10:36 | |
*** amotoki_ has quit IRC | 10:37 | |
*** salv-orlando has quit IRC | 10:38 | |
*** salv-orlando has joined #openstack-nova | 10:39 | |
*** sameo_ has quit IRC | 10:40 | |
*** takashin_ has left #openstack-nova | 10:41 | |
*** cdent has quit IRC | 10:43 | |
*** thorst has quit IRC | 10:44 | |
*** shaohe_feng has quit IRC | 10:44 | |
*** shaohe_feng has joined #openstack-nova | 10:45 | |
*** hoangcx has quit IRC | 10:45 | |
*** ishant is now known as ishant|away | 10:45 | |
*** EinstCrazy has joined #openstack-nova | 10:45 | |
*** jlanoux has joined #openstack-nova | 10:46 | |
*** ljxiash has joined #openstack-nova | 10:46 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: Introduce utility module for pcp https://review.openstack.org/203163 | 10:46 |
openstackgerrit | Matthew Booth proposed openstack/nova: rename libvirt has_default_ephemeral https://review.openstack.org/329366 | 10:46 |
*** hoangcx has joined #openstack-nova | 10:47 | |
*** jlanoux_ has quit IRC | 10:48 | |
*** jwcroppe has quit IRC | 10:51 | |
*** jwcroppe has joined #openstack-nova | 10:51 | |
*** ljxiash has quit IRC | 10:53 | |
*** ducttape_ has joined #openstack-nova | 10:54 | |
*** shaohe_feng has quit IRC | 10:54 | |
*** yassine has quit IRC | 10:55 | |
*** shaohe_feng has joined #openstack-nova | 10:56 | |
*** sudipto has quit IRC | 10:56 | |
*** salv-orlando has quit IRC | 10:58 | |
*** salv-orlando has joined #openstack-nova | 10:58 | |
*** ducttape_ has quit IRC | 10:59 | |
*** caowei has quit IRC | 11:00 | |
*** sahid has joined #openstack-nova | 11:02 | |
*** shaohe_feng has quit IRC | 11:05 | |
*** shaohe_feng has joined #openstack-nova | 11:06 | |
*** permalac has quit IRC | 11:09 | |
*** gszasz has quit IRC | 11:13 | |
*** jwcroppe has quit IRC | 11:14 | |
*** shaohe_feng has quit IRC | 11:15 | |
*** sheel has quit IRC | 11:15 | |
*** shaohe_feng has joined #openstack-nova | 11:16 | |
openstackgerrit | Matthew Booth proposed openstack/nova: Rename convert_volume and convert_all_volumes in virt.block_device https://review.openstack.org/329381 | 11:16 |
*** canan has quit IRC | 11:16 | |
*** rtheis has joined #openstack-nova | 11:16 | |
*** liverpooler has quit IRC | 11:17 | |
*** liverpooler has joined #openstack-nova | 11:17 | |
*** cdent has joined #openstack-nova | 11:17 | |
*** ljxiash has joined #openstack-nova | 11:18 | |
*** EinstCrazy has quit IRC | 11:22 | |
cdent | sdague: "api-no-more-extensions" is an excellent context flesher. to you or whoever wrote that, thanks | 11:22 |
sdague | cdent: yeh, I wrote that up yesterday | 11:23 |
cdent | nice work | 11:23 |
*** ljxiash has quit IRC | 11:23 | |
*** jwcroppe has joined #openstack-nova | 11:23 | |
sdague | thanks | 11:23 |
*** ociuhandu has quit IRC | 11:23 | |
*** ociuhandu has joined #openstack-nova | 11:23 | |
*** xenogear has quit IRC | 11:25 | |
*** rk4n has quit IRC | 11:25 | |
*** shaohe_feng has quit IRC | 11:25 | |
*** shaohe_feng has joined #openstack-nova | 11:26 | |
*** ociuhandu has quit IRC | 11:26 | |
*** ociuhandu has joined #openstack-nova | 11:26 | |
*** salv-orl_ has joined #openstack-nova | 11:28 | |
*** sree has joined #openstack-nova | 11:29 | |
*** mnestratov has quit IRC | 11:31 | |
*** salv-orlando has quit IRC | 11:32 | |
*** sree has quit IRC | 11:34 | |
*** vtech has quit IRC | 11:35 | |
*** rodrigods has quit IRC | 11:35 | |
*** vtech has joined #openstack-nova | 11:35 | |
*** rodrigods has joined #openstack-nova | 11:35 | |
*** shaohe_feng has quit IRC | 11:35 | |
*** shaohe_feng has joined #openstack-nova | 11:36 | |
*** zenoway has quit IRC | 11:38 | |
*** zenoway has joined #openstack-nova | 11:38 | |
*** thorst has joined #openstack-nova | 11:41 | |
*** thorst_ has joined #openstack-nova | 11:43 | |
*** jed56 has quit IRC | 11:45 | |
*** rk4n has joined #openstack-nova | 11:46 | |
*** shaohe_feng has quit IRC | 11:46 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Use min parameter to restrict live-migration config options https://review.openstack.org/323313 | 11:46 |
*** shaohe_feng has joined #openstack-nova | 11:47 | |
*** thorst has quit IRC | 11:47 | |
*** abalutoiu has joined #openstack-nova | 11:48 | |
*** thorst_ is now known as thorst | 11:49 | |
*** omnipresent has joined #openstack-nova | 11:50 | |
*** baoli has joined #openstack-nova | 11:51 | |
*** baoli_ has joined #openstack-nova | 11:52 | |
*** zenoway has quit IRC | 11:53 | |
*** raildo-afk is now known as raildo | 11:54 | |
*** apoorv has quit IRC | 11:54 | |
*** ducttape_ has joined #openstack-nova | 11:54 | |
*** sahid has quit IRC | 11:55 | |
*** shaohe_feng has quit IRC | 11:56 | |
*** baoli has quit IRC | 11:56 | |
*** aysyd has joined #openstack-nova | 11:57 | |
*** shaohe_feng has joined #openstack-nova | 11:57 | |
*** winston-d_ has quit IRC | 11:57 | |
*** gszasz has joined #openstack-nova | 11:58 | |
*** takedakn has joined #openstack-nova | 11:58 | |
*** ljxiash has joined #openstack-nova | 11:59 | |
*** sahid has joined #openstack-nova | 12:01 | |
openstackgerrit | jichenjc proposed openstack/nova: Remove 413 expect in servers.py https://review.openstack.org/329402 | 12:02 |
*** jed56 has joined #openstack-nova | 12:02 | |
BobBall | sdague: If you have a few minutes (possibly less) - I'd appreciate thoughts on https://review.openstack.org/#/c/328892/ | 12:03 |
*** ducttape_ has quit IRC | 12:03 | |
openstackgerrit | Kevin Zhao proposed openstack/nova: Set the virtio scsi controller index for virtio-scsi controller https://review.openstack.org/329403 | 12:03 |
*** sree has joined #openstack-nova | 12:04 | |
sdague | BobBall: yep, good catch | 12:04 |
*** ljxiash has quit IRC | 12:05 | |
sdague | BobBall: do you have the commit reference for when that was introduced? | 12:05 |
BobBall | Can get it easily - 1 sec | 12:05 |
sdague | we should probably reference that in the commit message | 12:06 |
sdague | once it's in there, I'm fine fast approving that one, because it's a really crisp bug | 12:06 |
*** shaohe_feng has quit IRC | 12:06 | |
BobBall | I6d0f09950ea1200d3367a53aa4a3eea9be7abc66 | 12:06 |
sdague | and those kinds of devstack bugs should be fixed quickly | 12:07 |
BobBall | Will add it | 12:07 |
openstackgerrit | Chris Dent proposed openstack/nova: Add delete_, update_ and add_ inventory to ResourceProvider https://review.openstack.org/328276 | 12:07 |
openstackgerrit | Chris Dent proposed openstack/nova: Add support for resource inventories to placement API https://review.openstack.org/329152 | 12:07 |
openstackgerrit | Chris Dent proposed openstack/nova: Add a ResourceProviderList object https://review.openstack.org/328307 | 12:07 |
openstackgerrit | Chris Dent proposed openstack/nova: Add set_inventory() method on ResourceProvider https://review.openstack.org/326440 | 12:07 |
openstackgerrit | Chris Dent proposed openstack/nova: Add initial framing of placement API https://review.openstack.org/329149 | 12:07 |
openstackgerrit | Chris Dent proposed openstack/nova: Add support for resource_providers urls https://review.openstack.org/329151 | 12:07 |
openstackgerrit | Chris Dent proposed openstack/nova: Add microversion support for the placement API https://review.openstack.org/329150 | 12:07 |
openstackgerrit | Chris Dent proposed openstack/nova: WIP experiment with the remainder of the placement API https://review.openstack.org/293104 | 12:07 |
*** shaohe_feng has joined #openstack-nova | 12:07 | |
BobBall | sdague: Do we have an "Introduced-By: " tag to shame bug introducers automatically? :P | 12:08 |
BobBall | (Just kidding) | 12:08 |
BobBall | Added reference | 12:08 |
openstackgerrit | Claudiu Belu proposed openstack/nova: policy: Add defaults in code (part 1) https://review.openstack.org/328850 | 12:10 |
*** fragatina has joined #openstack-nova | 12:11 | |
*** daemontool has joined #openstack-nova | 12:11 | |
*** pradk has joined #openstack-nova | 12:12 | |
*** markvoelker has joined #openstack-nova | 12:13 | |
*** palexster has quit IRC | 12:15 | |
*** matrohon has quit IRC | 12:15 | |
*** cdent has quit IRC | 12:16 | |
*** fragatina has quit IRC | 12:16 | |
*** shaohe_feng has quit IRC | 12:16 | |
*** shaohe_feng has joined #openstack-nova | 12:17 | |
*** sahid has quit IRC | 12:17 | |
*** cdent has joined #openstack-nova | 12:17 | |
*** laszloh has left #openstack-nova | 12:18 | |
*** ptm_away has quit IRC | 12:18 | |
*** ljxiash has joined #openstack-nova | 12:19 | |
*** palexster has joined #openstack-nova | 12:21 | |
openstackgerrit | Lee Yarwood proposed openstack/nova: libvirt: Volume backed instances should not call imagebacked during cleanup https://review.openstack.org/329030 | 12:23 |
*** ljxiash has quit IRC | 12:24 | |
*** zerda2 has quit IRC | 12:24 | |
*** matrohon has joined #openstack-nova | 12:25 | |
*** shaohe_feng has quit IRC | 12:27 | |
*** smatzek has joined #openstack-nova | 12:27 | |
*** shaohe_feng has joined #openstack-nova | 12:28 | |
*** kaisers1 has quit IRC | 12:29 | |
*** Hosam has quit IRC | 12:29 | |
*** Hosam has joined #openstack-nova | 12:30 | |
*** ivase has joined #openstack-nova | 12:30 | |
*** salv-orl_ has quit IRC | 12:33 | |
*** salv-orlando has joined #openstack-nova | 12:34 | |
*** Hosam has quit IRC | 12:34 | |
*** shaohe_feng has quit IRC | 12:37 | |
csatari | sudipto: Okay, I'm running a full recheck. Thanks for the help/ | 12:37 |
*** csatari has quit IRC | 12:38 | |
*** shaohe_feng has joined #openstack-nova | 12:38 | |
sdague | johnthetubaguy: you about? | 12:39 |
johnthetubaguy | sdague: I am | 12:39 |
sdague | johnthetubaguy: because I've now fully lost context, can you be more specific about your -1 here - https://review.openstack.org/#/c/325502/ ? | 12:39 |
openstackgerrit | Ed Leafe proposed openstack/nova: Correct the network config option help text https://review.openstack.org/318726 | 12:40 |
*** yassine has joined #openstack-nova | 12:40 | |
johnthetubaguy | sdague: I think a rebase lost this change from alex: https://review.openstack.org/#/c/325502/8..9 | 12:40 |
sdague | ah | 12:41 |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: add version 2.3 parameters to servers https://review.openstack.org/325502 | 12:44 |
*** pwnall has joined #openstack-nova | 12:44 | |
johnthetubaguy | sdague: gerrit is getting very cleaver these days, +W as alex's vote came back to life | 12:45 |
sdague | yeh | 12:45 |
sdague | also... the fact that we have 3 server views was tripping me up | 12:46 |
sdague | on the folding patch | 12:46 |
sdague | create, basic, show | 12:46 |
sdague | I guess that's so that admin pass can hook create but not the others, but it's still a bit wonky | 12:46 |
*** shaohe_feng has quit IRC | 12:47 | |
johnthetubaguy | yeah, that stuff is totally maddening, or however you spell that | 12:47 |
*** shaohe_feng has joined #openstack-nova | 12:48 | |
*** jamesdenton has joined #openstack-nova | 12:50 | |
danpb | fyi, i'd love to see some cores review the os-vif integration patch for nova, as its finally ready for merge from my pov https://review.openstack.org/#/c/269672/ | 12:50 |
*** stack_ has joined #openstack-nova | 12:50 | |
*** stack_ has quit IRC | 12:51 | |
sdague | danpb: given that we tripped up on the privsep helper upgrade on os-brick this weekend, how do you imagine the rolling upgrade story goes here? | 12:51 |
danpb | sdague: that's first i've heard of that - what was the problem ? | 12:52 |
sdague | I put a summary email out on the list this morning about what went down | 12:52 |
sdague | let me dig up the link | 12:52 |
sdague | http://lists.openstack.org/pipermail/openstack-dev/2016-June/097293.html | 12:52 |
danpb | thanks | 12:52 |
*** chandankumar has quit IRC | 12:53 | |
sdague | we haven't gotten to agreed solution yet, but that at least hopefully frames the problem | 12:53 |
*** takedakn has quit IRC | 12:53 | |
danpb | so IIUC the crux of the problem was that nova.conf did not get the config opt needed to tell privsep to use rootwrap for running its helper | 12:54 |
danpb | and so upgrade was just working by luck because CI had a blanket allow-all rule for sudo | 12:54 |
bauzas | cdent: aloha, maybe we should discuss on https://review.openstack.org/#/c/326440/15/nova/objects/resource_provider.py | 12:54 |
*** klkumar has quit IRC | 12:55 | |
danpb | sdague: sounds like os-vif will certainly hit the same problem, as you'll remember we just had to add a devstack rule to set nova.conf to use rootwrap for privsep | 12:55 |
sdague | yep | 12:55 |
bauzas | cdent: tbc, we're already incrementing and persisting the generation bit by https://review.openstack.org/#/c/326440/15/nova/objects/resource_provider.py@141 right | 12:55 |
danpb | seems that perhaps we ought to make nova explicitly override the defaults for privsep somehow | 12:55 |
danpb | as basically every user of privsep is going to hit the same problem as long as privsep defaults to using sudo directly | 12:56 |
sdague | danpb: yeh, that might work. I was hoping to see what the cinder folks working through this ran into. | 12:56 |
danpb | eg, privsep.set_default_helper(...nova rootwrap...) | 12:56 |
danpb | i'll reply on list | 12:57 |
bauzas | cdent: my point is that we could have 2 calls to _set_inventory that would do something like <A: transaction><B:transaction><B:wait><A:increment_DB_generation><B:increment_Db_generation><A:increment_object_generation><B:increment_object_generation> | 12:57 |
bauzas | or even terribe | 12:57 |
*** shaohe_feng has quit IRC | 12:57 | |
bauzas | cdent: <A: transaction><B:transaction><B:wait><A:increment_DB_generation><B:increment_Db_generation><B:increment_object_generation><A:increment_object_generation> | 12:58 |
*** shaohe_feng has joined #openstack-nova | 12:58 | |
cdent | hi bauzas, catching up | 12:59 |
*** lindycoder has joined #openstack-nova | 12:59 | |
*** gstepanov has joined #openstack-nova | 12:59 | |
dansmith | bauzas: yeah, incrementing in python in the object there is not how I expected this to work | 12:59 |
*** zhs has joined #openstack-nova | 13:00 | |
*** salv-orlando has quit IRC | 13:00 | |
*** salv-orlando has joined #openstack-nova | 13:00 | |
*** lindycod_ has joined #openstack-nova | 13:00 | |
cdent | it's done that way just as a convenience. the database has already been updated, and we'd like the caller's view to reflect what just happened _in their context_. Since the only thing that has changed on the rp was generation, this way is simple. | 13:01 |
cdent | we don't want the caller A's generation to be whatever the generation would be after both A and B were done, only A | 13:01 |
cdent | but it quite likely I'm understanding what the problem is? | 13:01 |
dansmith | cdent: we should do that from what we read from the db though, right? | 13:01 |
cdent | s/I'm/I'm not/ | 13:02 |
cdent | we haven't done a select, just an update, which only succeeds if the generation matched | 13:02 |
cdent | (or a delete or an insert) | 13:02 |
cdent | (or all three of them) | 13:03 |
bauzas | cdent: well, MHO is that the generation field is only a DB-related item | 13:03 |
dansmith | I'm not sure I can show that it's wrong, nor am I sure that it is, it just seems fundamentally wrong to assume | 13:03 |
dansmith | yeah, that ^ | 13:03 |
*** lindycoder has quit IRC | 13:04 | |
bauzas | cdent: having the object incrementing it means that it would then be just an object-related item which would then create some confusion | 13:04 |
*** xyang1 has joined #openstack-nova | 13:04 | |
cdent | let me try to lay it out as I understand it, and you guys can perhaps tell me that I've got it wrong, or in the process you might see that it is cool: | 13:04 |
bauzas | cdent: plus the fact you explictly need to obj_reset_changes() to make sure you won't trample the DB field | 13:04 |
cdent | A loads a resource provider, it has a generation. | 13:05 |
cdent | A has some inventory, calls set_inventory. At the end of set_inventory we validate that the (in thise case) insert of inventory was okay by comparing the generation we have with the generation in the db. If they match, we increment the generation in db. | 13:06 |
cdent | At this stage we could just stop, A has done what it wanted to do and we could require A to re-reload itself. | 13:06 |
cdent | However as a matter of convenience since we _know_ what the generation is as far as this current interaction is concerned, we can set it on the object | 13:07 |
cdent | EOF | 13:08 |
bauzas | cdent: what if when setting the new inventory, we just return the now-persisted generation bit | 13:08 |
*** shaohe_feng has quit IRC | 13:08 | |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: Fix revert on migration with SR-IOV https://review.openstack.org/326174 | 13:08 |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: Allocate PCI devices on migration https://review.openstack.org/328983 | 13:08 |
bauzas | which could be the same in case we have a duplication | 13:08 |
bauzas | that case, there is no need to reload it | 13:08 |
dansmith | bauzas: right, that's what I'd prefer | 13:08 |
*** shaohe_feng has joined #openstack-nova | 13:08 | |
cdent | if there had been duplication, then set_inventory will have an exception and the transaction will rollback and A's value for generation will be what it was before. Are you saying that it should be what client B made it become? | 13:09 |
openstackgerrit | jichenjc proposed openstack/nova: Update stable API doc to indicate code removal https://review.openstack.org/327066 | 13:10 |
*** mdrabe has joined #openstack-nova | 13:10 | |
* cdent feels like his missing something | 13:10 | |
cdent | bauzas: can you expand on what you mean by "which could be the same in case we have a duplication" | 13:11 |
bauzas | sec | 13:11 |
openstackgerrit | Anh Tran proposed openstack/nova: Enables Py34 tests for unit.api.openstack.compute.test_server_actions https://review.openstack.org/329435 | 13:13 |
*** diogogmt has joined #openstack-nova | 13:13 | |
*** klkumar has joined #openstack-nova | 13:14 | |
bauzas | cdent: http://paste.openstack.org/show/515981/ | 13:16 |
dansmith | FWIW, I really thought jaypipes said this was going to be incremented in sql | 13:17 |
cdent | it _is_ incremented in sql | 13:18 |
cdent | https://review.openstack.org/#/c/326440/15/nova/objects/resource_provider.py@127 | 13:18 |
*** Dinesh_Bhor has quit IRC | 13:18 | |
*** shaohe_feng has quit IRC | 13:18 | |
* cdent looks at bauzas thing | 13:19 | |
*** shaohe_feng has joined #openstack-nova | 13:19 | |
bauzas | cdent: it is incremented in SQL, I agree | 13:19 |
bauzas | so, why not returning that value ? | 13:19 |
*** kylek3h has joined #openstack-nova | 13:19 | |
*** omnipresent has quit IRC | 13:20 | |
*** dave-mccowan has joined #openstack-nova | 13:20 | |
*** pilgrimstack has joined #openstack-nova | 13:20 | |
*** zenoway has joined #openstack-nova | 13:20 | |
dansmith | cdent: you're right, I skimmed that too quickly.. | 13:20 |
dansmith | cdent: even more reason to do what bauzas is saying :) | 13:21 |
*** FL1SK has quit IRC | 13:21 | |
* bauzas needs coffee | 13:21 | |
cdent | bauzas: to do the change you've just suggested would require changing the conditionals (which is not a problem), but your change is, functionally, exactly the same as mine (with some added dryness). Your queries made it sound like you wanted a db read. The reason it looks the way it does now is because jay wrote the conditionals and I added in the bumping the generation later (when I added more tests). | 13:22 |
cdent | "can't we use the value in the db" is not the same as what you've suggested | 13:22 |
dansmith | cdent: we want the thing we read or write from/to the database to inform the property of the object when we're done | 13:22 |
*** raildo has left #openstack-nova | 13:23 | |
*** pilgrimstack has quit IRC | 13:24 | |
*** amotoki has joined #openstack-nova | 13:24 | |
*** zenoway has quit IRC | 13:25 | |
cdent | dansmith: so returning an integer from a method that is the sum of a constant and a value that's been on the object from the start counts as "being informed by the database"? (I'm referring to the paste from bauzas: http://paste.openstack.org/show/515981/ ) | 13:25 |
* cdent joins bauzas at the coffee maker | 13:26 | |
dansmith | cdent: ah, I see your point, and why I was confused about this not being done in sql | 13:26 |
* dansmith got up at 4:45 to take his wife to the airport and has not yet had his coffee | 13:26 | |
* cdent makes a cup for dan | 13:27 | |
dansmith | cdent: so the thing is, it's not incremented in sql right? It's incremented in python and *set* in sql | 13:27 |
bauzas | cdent: there is a big difference between your increment and mine | 13:27 |
openstackgerrit | Victor Stinner proposed openstack/nova: Port test_pipelib and test_policy to Python 3 https://review.openstack.org/322040 | 13:28 |
cdent | dansmith: correct | 13:28 |
bauzas | cdent: the one you made is done out of the transaction, and updated secondly by the object | 13:28 |
cdent | bauzas: which is? | 13:28 |
*** diogogmt has quit IRC | 13:28 | |
*** shaohe_feng has quit IRC | 13:28 | |
cdent | bauzas: that's actually on purpose, and I'll explain why after my coffee is done | 13:28 |
bauzas | cdent: while here, I'm assuming we call an interface which is something like UPDATE_AND_GET | 13:29 |
bauzas | cdent: please don't me speak about design patterns... | 13:29 |
dansmith | cdent: so to my earlier point, if we're merely setting the column to $value, then returning $value from that function is indeed "returning what is in the database" | 13:29 |
bauzas | don't let* me speak | 13:29 |
*** ericksonsantos has joined #openstack-nova | 13:29 | |
* cdent has coffee, reads | 13:30 | |
dansmith | cdent: which is good enough for me | 13:30 |
dansmith | cdent: setting it to a thing in a function and then later setting it to the thing we're pretty sure that function set it to is the thing I don't like | 13:31 |
*** shaohe_feng has joined #openstack-nova | 13:31 | |
cdent | dansmith: okay, good, that's gets to the crux of _my_ confusion: | 13:31 |
cdent | (first off I'm happy to change it, and will, so it does the dan+bauzas version of "returning what is in the db") | 13:32 |
dansmith | your confusion is that you're not sure if we want the updated value after a racing transaction? | 13:32 |
cdent | but: in what circumstance would rp.gen + 1 be different between the two calls? | 13:33 |
*** rfolco has joined #openstack-nova | 13:33 | |
*** woodster_ has joined #openstack-nova | 13:33 | |
cdent | my code is only reachable if the generation swap was successful | 13:33 |
dansmith | cdent: at *least* in the case where this gets augmented in one place but not two later down the road | 13:33 |
dansmith | you have logic in two places.. extremely important logic | 13:33 |
*** mriedem_away is now known as mriedem | 13:33 | |
cdent | yeah, I get that part, which is why I'm happy to change it: bad maintenance | 13:34 |
*** Vek has quit IRC | 13:34 | |
cdent | but what I'm hearing you guys suggesting is that there might actually be a chance of it being wrong, and I want to know what that is for my edification | 13:34 |
*** lhinds_ has quit IRC | 13:34 | |
dansmith | cdent: no, that's why I said this above: | 13:34 |
*** erlon has joined #openstack-nova | 13:35 | |
dansmith | [06:03:53] <dansmith>I'm not sure I can show that it's wrong, nor am I sure that it is, it just seems fundamentally wrong to assume | 13:35 |
*** PaulMurray has joined #openstack-nova | 13:35 | |
cdent | and bauzas, do you have a scenario where it can break, or is just (justifiable) caution? | 13:35 |
bauzas | okay, lemme draw the end of world | 13:36 |
cdent | dansmith, while bauzas is drawing that, can you tell me: a) I have to reset_changes? b) where should I do it in the new improved version? | 13:37 |
bauzas | cdent: so, we both agree the code section in _set_inventory() is not synchronized ? even more difficult, it's a remotable method, right? | 13:38 |
dansmith | cdent: on L198? | 13:38 |
dansmith | bauzas: _set_inventory() is not remotable | 13:38 |
* dansmith becomes very pedantic | 13:38 | |
* cdent nods at dansmith | 13:38 | |
*** shaohe_feng has quit IRC | 13:38 | |
bauzas | dansmith: well, I'm blinded then by set_inventory which calls out _set_inventory | 13:39 |
*** shaohe_feng has joined #openstack-nova | 13:39 | |
bauzas | dansmith: because the former is said remotable | 13:39 |
dansmith | cdent: yeah, obj_reset_changes() un-dirties all the fields for the caller so if they were to run obj_what_changed() on their object afterwards, it would look clean, i.e. "nothing else that needs to be saved to the db" | 13:39 |
mriedem | johnthetubaguy: -2 lifted | 13:40 |
*** smatzek has quit IRC | 13:40 | |
dansmith | bauzas: I know, I'm just being persnickety | 13:40 |
bauzas | okay, let's be pedantic :D | 13:41 |
*** edmondsw has joined #openstack-nova | 13:41 | |
*** ljxiash has joined #openstack-nova | 13:41 | |
bauzas | so... rp.set_inventory() is remotable and not synchronized | 13:41 |
bauzas | which means 2 method calls would then be checking the generation bit at the same time | 13:42 |
cdent | which is why the generation bit exists at all | 13:42 |
*** mmandel has joined #openstack-nova | 13:43 | |
johnthetubaguy | mriedem: had a look through the specs, spotted a few out of sync and approved them | 13:43 |
*** mtanino has joined #openstack-nova | 13:43 | |
mriedem | thanks | 13:43 |
Prophidys | mriedem, a question about this one : https://blueprints.launchpad.net/nova/+spec/purge-deleted-instances-cmd is it still relevant ? can we integrate the older-than in the archive too ? or I need to do a new blueprint ? | 13:43 |
Prophidys | The older-than is implemented in the review here : https://review.openstack.org/#/c/203751/ | 13:44 |
mriedem | Prophidys: the purge command there is separate from the archive command | 13:44 |
Prophidys | ok so new blueprint :-( | 13:44 |
mriedem | Prophidys: older-than is not going to work well with the archive command in it's current form | 13:44 |
mriedem | the purge command only worked on instances and things that instances depend on in the schema | 13:45 |
*** eharney has joined #openstack-nova | 13:45 | |
mriedem | which is why older-than would work for instances as the target | 13:45 |
cdent | bauzas? | 13:45 |
mriedem | archive does a blanket copy to shadow tables of all records in all tables until you hit max_count | 13:45 |
*** ctrath has joined #openstack-nova | 13:45 | |
mriedem | so older-than doesn't really make a ton of sense there | 13:45 |
dansmith | mriedem: right, but people want to do that with a date range instead of a row count | 13:46 |
mriedem | the max_count thing in archive db is kind of busted in it's current form anyway in my opinion | 13:46 |
dansmith | mriedem: i.e. run from cron.monthly with --older-than=60 or something, which isn't possible with max_rows | 13:46 |
*** fifieldt has joined #openstack-nova | 13:47 | |
mriedem | alright, go for it | 13:47 |
Prophidys | mriedem, we can implement a older-than in archive too I think, we just do it for the instances table and after we get all dependencies from this subset | 13:47 |
Prophidys | mriedem, thank you | 13:48 |
mriedem | Prophidys: i'm not sure i'd like that | 13:48 |
mriedem | it changes the behavior of archive depending on which thing you're using, date range or max_rows | 13:48 |
bauzas | cdent: sorry had to do something else | 13:48 |
mriedem | if you're going to just archive instances and it's dependencies, i think i'd rather see a new command rather than munge that into the archive cmd we have today | 13:48 |
bauzas | yeah, so you understand why I don't really like updating the generation field by the object ? because it's something incremented by the API DB rather | 13:48 |
bauzas | which could be out of that service | 13:49 |
bauzas | oops | 13:49 |
dansmith | mriedem: because current archive hits more than instances? | 13:49 |
*** shaohe_feng has quit IRC | 13:49 | |
mriedem | dansmith: yes, it hits everything | 13:49 |
mriedem | until max_count | 13:49 |
mriedem | or whatever | 13:49 |
dansmith | mriedem: which makes it even less useful | 13:49 |
Prophidys | yeah the max_count sucks it can create inconsistencies | 13:49 |
mriedem | the max-rows thing is already busted | 13:49 |
*** shaohe_feng has joined #openstack-nova | 13:49 | |
mriedem | i agree there | 13:49 |
dansmith | mriedem: can we call that a bug and fix it with a new command? :P | 13:50 |
Prophidys | dansmith, +2 | 13:50 |
*** burt has joined #openstack-nova | 13:50 | |
Prophidys | :-) | 13:50 |
Prophidys | We can do it in 2 step | 13:50 |
*** EinstCrazy has joined #openstack-nova | 13:50 | |
Prophidys | create an exclusive option --older-than=X (we can't use --max-rows and --older-than at the same time) | 13:51 |
Prophidys | older-than do it the clean way | 13:51 |
cdent | bauzas: yeah, I think we've resolved that _increment... should return the new generation, for sake of better maintenance | 13:51 |
Prophidys | and after that we deprecate --max-rows | 13:51 |
mriedem | Prophidys: but is older-than only on instances and it's deps or everything | 13:51 |
mriedem | ? | 13:51 |
mriedem | because if it's only instances, how do you archive block_device_mappings for instance? | 13:52 |
Prophidys | instances and it's deps include everything no ? | 13:52 |
dansmith | Prophidys: well, I think he's saying a new command like archive_instances that is specifically targeted at instances, and add --older-than to that | 13:52 |
mriedem | yes, that | 13:52 |
*** ptm_away has joined #openstack-nova | 13:52 | |
dansmith | mriedem: instance and its deps | 13:52 |
mriedem | which is what the purge command was going to be | 13:52 |
johnthetubaguy | yeah, that sounds like what folks are wanting | 13:52 |
*** zenoway has joined #openstack-nova | 13:53 | |
mriedem | you can still end up with other cruft | 13:53 |
dansmith | Prophidys: you don't care if they're archived or purged, you just want them out of the main db right? | 13:53 |
dansmith | which I think is what most people want | 13:53 |
mriedem | but i guess that's what the archive command would be used to cleanup then - for everything else | 13:53 |
openstackgerrit | Chris Dent proposed openstack/nova: Add delete_, update_ and add_ inventory to ResourceProvider https://review.openstack.org/328276 | 13:53 |
openstackgerrit | Chris Dent proposed openstack/nova: Add support for resource inventories to placement API https://review.openstack.org/329152 | 13:53 |
openstackgerrit | Chris Dent proposed openstack/nova: Add a ResourceProviderList object https://review.openstack.org/328307 | 13:53 |
openstackgerrit | Chris Dent proposed openstack/nova: Add set_inventory() method on ResourceProvider https://review.openstack.org/326440 | 13:53 |
*** ptm_away is now known as PaulMurray_ | 13:53 | |
openstackgerrit | Chris Dent proposed openstack/nova: Add initial framing of placement API https://review.openstack.org/329149 | 13:53 |
openstackgerrit | Chris Dent proposed openstack/nova: Add support for resource_providers urls https://review.openstack.org/329151 | 13:53 |
openstackgerrit | Chris Dent proposed openstack/nova: Add microversion support for the placement API https://review.openstack.org/329150 | 13:53 |
openstackgerrit | Chris Dent proposed openstack/nova: WIP experiment with the remainder of the placement API https://review.openstack.org/293104 | 13:53 |
johnthetubaguy | mriedem: yeah, it could do the non-instance stuff | 13:53 |
Prophidys | dansmith, right | 13:54 |
*** sameo has joined #openstack-nova | 13:54 | |
cdent | bauzas, dansmith is https://review.openstack.org/#/c/326440/ now more like you would prefer? | 13:54 |
mriedem | Prophidys: sounds like you just want to work on the purge command then | 13:54 |
Prophidys | the archived thing can be good to debug, but in fact I want a production DB clean to read | 13:54 |
dansmith | mriedem: the existing archive command would break the new instance-targeted one right? because it's going to delete things that --older-than would have left | 13:54 |
mriedem | which already had an approved spec in mitaka | 13:54 |
cdent | dansmith, bauzas: I've left the module methods in place for the time being as that's the precedent that jay set when he initially wrote the stuff. maybe he'll jump in at some point. | 13:55 |
mriedem | dansmith: yeah | 13:55 |
dansmith | Prophidys: do you want to pick up that purge patch? | 13:55 |
mriedem | well, 'break' depends on usage | 13:55 |
*** PaulMurray has quit IRC | 13:55 | |
mriedem | Broken as a Service? | 13:55 |
dansmith | mriedem: "could break" by deleting BDMs before the instance is set to actually go | 13:55 |
PaulMurray_ | Live migration meeting in 5 mins on #openstack-meeting-3 PaulMurray paul-carlton2 eliqiao shaohe_feng pkoniszewski jlanoux yuntongjin mdbooth kashyap kmartin claudiub tobasco tdurakov andreas_s abhishekk diana_clarke | 13:55 |
mriedem | dansmith: archive would still archive the instances first | 13:55 |
mriedem | unless it was changed | 13:55 |
*** cdelatte has joined #openstack-nova | 13:56 | |
dansmith | mriedem: purge deletes straight from the main db right? | 13:56 |
mriedem | yes | 13:56 |
*** irenab has quit IRC | 13:56 | |
dansmith | mriedem: if we had an archive_instances, and you used the existing archive command with it, it might archive BDM rows that belong to instances that haven't been archived, is my point | 13:56 |
dansmith | but focusing on purge would be better all around, IMHO | 13:56 |
Prophidys | Ok I start with the purge command | 13:57 |
dansmith | mriedem: I guess we're past the point of resurrecting previously approved specs, but this seems important and out-of-the-critical-path enough to want to capitalize on Prophidys' interest... | 13:57 |
*** shaohe_feng has quit IRC | 13:59 | |
Prophidys | If you want my vision, I think a unified command to archive and purge when it's archived should be perfect (like archive every day, and purge archive older than X days) | 13:59 |
mriedem | Prophidys: if you can re-propose the spec for newton i think we can give it an exception to resurrect the bp | 13:59 |
openstackgerrit | Gergely Csatari proposed openstack/nova: api-ref: console types. https://review.openstack.org/329462 | 13:59 |
dansmith | Prophidys: start with instance-focused purge-only and then expand from there I think | 14:00 |
*** shaohe_feng has joined #openstack-nova | 14:00 | |
Prophidys | dansmith, mriedem ok I start with that | 14:00 |
dansmith | Prophidys: I think most people would like to see the shadow tables go away, so the archive option should be a discussion for later | 14:00 |
Prophidys | perfect | 14:00 |
*** vnogin has joined #openstack-nova | 14:01 | |
Prophidys | mriedem, dansmith thank you for your time | 14:02 |
*** PaulMurray_ has quit IRC | 14:02 | |
*** PaulMurray has joined #openstack-nova | 14:02 | |
dansmith | Prophidys: thanks for wanting to work on this.. it's been neglected for too long | 14:02 |
*** burgerk has joined #openstack-nova | 14:02 | |
*** smatzek has joined #openstack-nova | 14:03 | |
*** zz_dimtruck is now known as dimtruck | 14:03 | |
*** jaosorior has quit IRC | 14:05 | |
*** cfriesen has joined #openstack-nova | 14:06 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor https://review.openstack.org/266773 | 14:07 |
*** sudipto has joined #openstack-nova | 14:07 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/303345 | 14:08 |
openstackgerrit | Timofey Durakov proposed openstack/nova: [dnm] nfs fix for xenial https://review.openstack.org/329466 | 14:09 |
*** shaohe_feng has quit IRC | 14:09 | |
*** lucas___ has joined #openstack-nova | 14:10 | |
*** roeyc has quit IRC | 14:10 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Skip NFS and Ceph in live migration job test run https://review.openstack.org/327886 | 14:11 |
mriedem | johnthetubaguy: ^ | 14:11 |
openstackgerrit | John Garbutt proposed openstack/nova: WIP: split allocate_for_instance to update + create https://review.openstack.org/328966 | 14:11 |
dansmith | johnthetubaguy: oooh | 14:12 |
* dansmith hands johnthetubaguy a cookie | 14:12 | |
*** ducttape_ has joined #openstack-nova | 14:12 | |
*** shaohe_feng has joined #openstack-nova | 14:12 | |
*** MikeG451_ has joined #openstack-nova | 14:12 | |
*** ducttape_ has quit IRC | 14:12 | |
*** ducttape_ has joined #openstack-nova | 14:13 | |
johnthetubaguy | dansmith: yeah, there is some stuff up there that shuffles things around, slowly getting somewhere ish, that last patch looks like a monkey bashing a keyboard right now, but fixing that | 14:13 |
*** mrkz has joined #openstack-nova | 14:13 | |
dansmith | johnthetubaguy: hah, well, cool | 14:13 |
mriedem | i would selfishly like the get me a network stuff to get in before that code is all ripped apart | 14:14 |
*** links has quit IRC | 14:14 | |
johnthetubaguy | mriedem: given how much some folks are kicking and screaming about that, I wouldn't be against that | 14:15 |
*** roeyc has joined #openstack-nova | 14:15 | |
mriedem | the changes aren't all that big, but there are changes in validate_networks and allocate_for_instance flows in that series | 14:15 |
openstackgerrit | Maciej Szankin proposed openstack/nova: config options: improve help for noVNC https://review.openstack.org/319453 | 14:16 |
*** ratailor has quit IRC | 14:17 | |
mriedem | https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/get-me-a-network+status:open | 14:17 |
mriedem | i also have the tempest test running against that series now | 14:17 |
*** prateek has quit IRC | 14:19 | |
*** rlrossit has joined #openstack-nova | 14:19 | |
*** shaohe_feng has quit IRC | 14:20 | |
*** vladikr has joined #openstack-nova | 14:21 | |
*** EinstCrazy has quit IRC | 14:21 | |
rlrossit | gibi: I have way too many meetings today, and I haven't done any reviews since last week's meeting, so I'll be missing out on the notifications meeting today | 14:22 |
rlrossit | I have to catch up from being out Friday & Monday | 14:22 |
openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Transform instance.suspend notifications https://review.openstack.org/329089 | 14:22 |
*** haypo has joined #openstack-nova | 14:22 | |
haypo | hello. i recently wrote https://review.openstack.org/#/c/322040/ a simple python3 fix which was approved but failed to merge because of a conflict. i fixed the conflict the day after and now it's waiting again for your review! | 14:23 |
haypo | (approval) | 14:23 |
haypo | i plan to split dims two giant patches into smaller patches, easier to review | 14:24 |
*** mnestratov has joined #openstack-nova | 14:24 | |
*** shaohe_feng has joined #openstack-nova | 14:24 | |
mriedem | gmann: yup, +2 on https://review.openstack.org/#/c/328931/ now - nice work | 14:28 |
*** ctrath has quit IRC | 14:29 | |
*** shaohe_feng has quit IRC | 14:30 | |
*** shaohe_feng has joined #openstack-nova | 14:30 | |
*** adisky has quit IRC | 14:30 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: api-ref: added docs for microversion 2.26 https://review.openstack.org/327089 | 14:30 |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Added missed response to test_server_tags https://review.openstack.org/327088 | 14:30 |
*** mriedem1 has joined #openstack-nova | 14:31 | |
*** ctrath has joined #openstack-nova | 14:31 | |
mriedem1 | pretty easy +W https://review.openstack.org/#/c/328931/ | 14:32 |
*** mriedem has quit IRC | 14:33 | |
*** bzurawski has joined #openstack-nova | 14:33 | |
bzurawski | Hello | 14:33 |
*** kaisers has joined #openstack-nova | 14:33 | |
bzurawski | I have a question about rate limit in openstack | 14:34 |
bzurawski | becuase i can't find any API rate limit mechanism, is it deprecated, or implemented in other way ? | 14:34 |
*** sree has quit IRC | 14:35 | |
*** Hosam has joined #openstack-nova | 14:35 | |
*** ayoung has joined #openstack-nova | 14:36 | |
mriedem1 | bzurawski: there was a rate limit option in the v2 api but that's not in v2.1 | 14:36 |
gibi | rlrossit: thanks for the heads up, I think your reviews is a lot more important than being present on the meeting. :) | 14:36 |
*** tanee is now known as tanee_away | 14:37 | |
*** rfolco has quit IRC | 14:37 | |
bzurawski | mriedem1: oki, and is there other way of limitation HTTP requests, or it's completly depracted with v2.1 | 14:37 |
bzurawski | ? | 14:37 |
mriedem1 | bzurawski: it's a good question which i don't have the answer for, the config options docs aren't helpful | 14:38 |
mriedem1 | (BoolOpt) Whether to use per-user rate limiting for the api. This option is only used by v2 api. Rate limiting is removed from v2.1 api. | 14:38 |
*** jwcroppe_ has joined #openstack-nova | 14:39 | |
mriedem1 | sdague: oomichi: gmann: alex_xu: ^ any more details? | 14:39 |
*** shaohe_feng has quit IRC | 14:40 | |
*** BjoernT has joined #openstack-nova | 14:40 | |
sdague | bzurawski: it's gone entirely | 14:40 |
*** snikitin_ has joined #openstack-nova | 14:40 | |
sdague | the in tree solution didn't work the moment you had > 1 api server | 14:41 |
*** shaohe_feng has joined #openstack-nova | 14:41 | |
sdague | because rate limiting was per api server | 14:41 |
*** jwcroppe has quit IRC | 14:41 | |
sdague | this is something which needs a dedicated solution that synchronizes the metrics across all your api servers | 14:41 |
*** mdrabe has quit IRC | 14:42 | |
*** tanee_away is now known as tanee | 14:43 | |
bzurawski | sdague: oki, so let's say that i want to put some limitations on HTTP requests because clients is making to many of them, is there any way or something that allow me to do it in v2.1 | 14:44 |
bzurawski | ? | 14:44 |
*** pacoblox has joined #openstack-nova | 14:44 | |
bzurawski | sdague: because i'm looking now at api/openstack/compute/limits.py | 14:44 |
bzurawski | sdague: aaa, no, it's not for what i want, sorry :) | 14:45 |
sdague | bzurawski: there is nothing in tree | 14:45 |
*** jwcroppe_ has quit IRC | 14:45 | |
*** eharney has quit IRC | 14:45 | |
*** rfolco has joined #openstack-nova | 14:46 | |
sdague | there was a general community discussion around this at least a year ago that the current rate limitting mechanism was broken by design, so had no value to move forward | 14:46 |
mriedem1 | bzurawski: probably a good question for the #openstack-operators channel or mailing list to see what others are using | 14:46 |
bzurawski | mriedem1: oki, will do that | 14:46 |
bzurawski | mriedem1: sdague thanks for your help :) | 14:47 |
*** jwcroppe_ has joined #openstack-nova | 14:47 | |
sdague | bzurawski: this would definitely be a really good thing to exist in OpenStack wide | 14:47 |
mriedem1 | we should probably update the config option docs for api_rate_limit=False | 14:47 |
sdague | it should be generalized beyond nova, work as a paste middleware, and have some memcache server or something to do counting | 14:47 |
mriedem1 | i.e. this is gone in v2.1 and there is no in-tree replacement | 14:47 |
sdague | mriedem1: yeh, probably | 14:47 |
mriedem1 | sdague: i can try to wordsmith that quick | 14:48 |
bzurawski | sdague: totally agree | 14:48 |
*** artom has quit IRC | 14:49 | |
bzurawski | sdague: i have done it like you said with memcache and middleware for v2 | 14:49 |
bzurawski | but if in v2.1 rate limiting is gone, that it's not useful in master :P | 14:49 |
sdague | bzurawski: ok, well, middleware can reject the requests before they even get there | 14:49 |
sdague | nova shouldn't actually know anything about rate limitting | 14:50 |
*** artom has joined #openstack-nova | 14:50 | |
bzurawski | sdague: why ? | 14:50 |
*** jwcroppe has joined #openstack-nova | 14:50 | |
*** shaohe_feng has quit IRC | 14:50 | |
sdague | because these should be url based limits before you effectively get to any of the nova logic | 14:50 |
sdague | the old solution worked this way | 14:51 |
tdurakov | sdague: hi, have you seen https://review.openstack.org/#/c/329483/1 | 14:51 |
*** shaohe_feng has joined #openstack-nova | 14:51 | |
sdague | tdurakov: +2 | 14:51 |
*** jwcroppe_ has quit IRC | 14:52 | |
*** klkumar has quit IRC | 14:52 | |
*** rrecio has joined #openstack-nova | 14:54 | |
tdurakov | mriedem1: could we merge this^ | 14:54 |
*** klkumar has joined #openstack-nova | 14:54 | |
*** rrecio_ has joined #openstack-nova | 14:54 | |
bzurawski | sdague: hmm, so maybe it's good moment to talk about this limitations on some meeting, what you think ? | 14:55 |
bzurawski | because such mechanism, would be really helpful, if it will exist | 14:55 |
sdague | bzurawski: https://github.com/openstack/nova/blob/c8ec9ebf379c61d73c5671a75dd2a4e4ae1403fb/nova/api/openstack/compute/legacy_v2/limits.py#L258 - when that rate limitting middleware is in place, it does an early wsgi fault return super early | 14:55 |
sdague | bzurawski: I 100% agree that something like this should exist | 14:55 |
sdague | but it can be like the CORS work, middleware that's entirely independent of any project | 14:55 |
*** amotoki has quit IRC | 14:55 | |
*** eharney has joined #openstack-nova | 14:56 | |
sdague | oh, sorry, it's actually even worse than per server | 14:56 |
sdague | it's actually per process | 14:56 |
sdague | so you will end up hitting rate limits randomly between x and Nx (where N is the number of api worker processes) that you have | 14:57 |
*** rrecio has quit IRC | 14:58 | |
sdague | bzurawski: is your concern that the values for rates aren't stored in Nova's db any more? | 14:58 |
*** sacharya has joined #openstack-nova | 14:58 | |
*** mdrabe has joined #openstack-nova | 14:58 | |
sdague | because if you have a working middleware stack, that shouldn't really change here | 14:58 |
*** diga has joined #openstack-nova | 14:59 | |
*** gjayavelu has joined #openstack-nova | 15:00 | |
*** jwcroppe has quit IRC | 15:00 | |
*** shaohe_feng has quit IRC | 15:01 | |
*** sacharya_ has joined #openstack-nova | 15:01 | |
*** jwcroppe has joined #openstack-nova | 15:01 | |
*** jwcroppe_ has joined #openstack-nova | 15:01 | |
*** shaohe_feng has joined #openstack-nova | 15:01 | |
*** pacoblox1 has joined #openstack-nova | 15:02 | |
*** siva_krishnan has joined #openstack-nova | 15:02 | |
*** MarcF has joined #openstack-nova | 15:03 | |
luis5tb | Hi danpb. I found what it could be a bug into the live migration monitoring function (https://bugs.launchpad.net/nova/+bug/1591240) | 15:03 |
openstack | Launchpad bug 1591240 in OpenStack Compute (nova) "progress_watermark is not updated" [Undecided,New] | 15:03 |
*** MarcF has quit IRC | 15:03 | |
*** sacharya has quit IRC | 15:04 | |
luis5tb | basically, if the first time it goes inside the if block, progress_watermark is initialized to 0, then it will not enter in the block anymore, and progress_watermark will not be updated | 15:04 |
*** roeyc has quit IRC | 15:04 | |
*** itamarl has quit IRC | 15:04 | |
*** gagehugo has joined #openstack-nova | 15:04 | |
*** ssurana has joined #openstack-nova | 15:04 | |
luis5tb | which leads to trigger live-migration aborts even if progress is being made | 15:04 |
*** gjayavelu has quit IRC | 15:05 | |
doffm | mdbooth: Thanks for review. Have abandoned my competing RBD cleanup rescue images fix. | 15:05 |
*** jwcroppe has quit IRC | 15:05 | |
*** yamahata has joined #openstack-nova | 15:05 | |
*** pacoblox has quit IRC | 15:05 | |
*** PaulMurray has quit IRC | 15:06 | |
tdurakov | PaulMurray, mriedem1, johnthetubaguy: looks like nfs is fixed http://logs.openstack.org/66/329466/1/experimental/gate-tempest-dsvm-multinode-live-migration/e6b6e45/console.html#_2016-06-14_14_48_28_372 | 15:06 |
mdbooth | doffm: Sorry about that :/ Wish these things were easier to notice. | 15:06 |
mriedem1 | tdurakov: ok, setup passed, one of the tests failed | 15:07 |
*** Jeffrey4l has quit IRC | 15:07 | |
*** zenoway has quit IRC | 15:07 | |
tdurakov | mriedem1: yup | 15:07 |
johnthetubaguy | tdurakov: ah, but it did fail I guess? | 15:07 |
siva_krishnan | Hi All! I have not been able to restart n-api service in devstack after I pulled this change https://review.openstack.org/#/c/280851/9. Has anyone faced similar issue ? | 15:08 |
tdurakov | johnthetubaguy, mriedem1 one of tests, as http://logs.openstack.org/66/329466/1/experimental/gate-tempest-dsvm-multinode-live-migration/e6b6e45/console.html#_2016-06-14_14_49_08_309 is passed i think it shouldn't be connected to nfs at all | 15:08 |
*** fifieldt has quit IRC | 15:08 | |
mriedem1 | tdurakov: yeah... | 15:08 |
johnthetubaguy | yeah, looks like it could be the general issue? | 15:09 |
doffm | mdbooth: Its OK, glad the new patch looks better. | 15:09 |
mriedem1 | tdurakov: want to update your patch to close bug 1590929 ? | 15:09 |
openstack | bug 1590929 in OpenStack Compute (nova) "gate-tempest-dsvm-multinode-live-migration fails NFS setup on ubuntu 16.04 nodes" [Medium,Confirmed] https://launchpad.net/bugs/1590929 | 15:09 |
*** pacoblox1 has quit IRC | 15:09 | |
tdurakov | sure, btw it will break this for trusty I guess | 15:10 |
tdurakov | is it ok? | 15:10 |
tdurakov | or should we check ubuntu version? | 15:10 |
tdurakov | mriedem1: ^ | 15:10 |
*** shaohe_feng has quit IRC | 15:11 | |
*** pradk has quit IRC | 15:11 | |
dansmith | mriedem1: shouldn't we be good on the network request tuple deal at this point? or are there still things passing tuples? | 15:11 |
*** rcernin has quit IRC | 15:11 | |
mriedem1 | dansmith: there might still be things | 15:11 |
*** jwcroppe has joined #openstack-nova | 15:11 | |
mriedem1 | dansmith: https://review.openstack.org/#/c/309574/16/nova/network/neutronv2/api.py is checking for None | 15:11 |
mriedem1 | because that's what the code was checking before | 15:11 |
*** shaohe_feng has joined #openstack-nova | 15:11 | |
*** mmandel has quit IRC | 15:12 | |
dansmith | mriedem1: why change it? I thought you changed it because you moved the objectification above | 15:12 |
*** tbachman has quit IRC | 15:12 | |
*** snikitin_ has quit IRC | 15:12 | |
dansmith | mriedem1: and does the former mean you know there are places, or you're just being defensive instead of checking? | 15:12 |
mriedem1 | i could make it check is None again | 15:12 |
bzurawski | sdague: there is oslo.middleware, so maybe it can be used for rate limits ? | 15:12 |
*** jwcroppe_ has quit IRC | 15:13 | |
*** pacoblox has joined #openstack-nova | 15:13 | |
mriedem1 | dansmith: i think there are places, it's been awhile since i've looked for sure, and in meetings all morning | 15:13 |
bzurawski | sdague: how CORS works, it's separate module so nova doesn't know about it ? | 15:13 |
dansmith | mriedem1: okay | 15:13 |
mriedem1 | dansmith: i think it's a matter of compute rpc api | 15:13 |
mriedem1 | not being a minimum to send the object list | 15:13 |
*** edand has quit IRC | 15:13 | |
dansmith | mriedem1: ah, okay, maybe | 15:13 |
dansmith | feels like it's been a long time, so I'm surprised, but...maybe | 15:14 |
sdague | bzurawski: api-paste.ini pipelines as just stacks of modules | 15:14 |
sdague | bzurawski: they don't have to all be in the nova tree | 15:14 |
mriedem1 | bzurawski: fyi http://lists.openstack.org/pipermail/openstack-operators/2016-June/010692.html | 15:14 |
*** pece has quit IRC | 15:15 | |
*** abalutoiu has quit IRC | 15:15 | |
*** ssurana has quit IRC | 15:15 | |
bzurawski | mriedem1: thanks :) | 15:16 |
openstackgerrit | Moshe Levi proposed openstack/nova: Update available resources before confirm stage https://review.openstack.org/327356 | 15:17 |
mriedem1 | sdague: heh, actually, since the legacy_v2 code is removed, api_rate_limit config option isn't used anywhere, so i guess i'll just remove that too... | 15:17 |
sdague | mriedem1: yeh, I was wondering that | 15:18 |
*** Vek has joined #openstack-nova | 15:18 | |
*** jlanoux has quit IRC | 15:18 | |
mriedem1 | i'll just remove it quick | 15:18 |
*** pilgrimstack has joined #openstack-nova | 15:18 | |
openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova: Help text for the mks options https://review.openstack.org/323608 | 15:19 |
bzurawski | sdague: so basically this rate limitation could be putted into oslo.middleware (code) and putted into api-paste.ini (pipeline) | 15:19 |
*** zenoway has joined #openstack-nova | 15:19 | |
sdague | bzurawski: sure, or even some other library | 15:19 |
*** FL1SK has joined #openstack-nova | 15:20 | |
*** shaohe_feng has quit IRC | 15:21 | |
*** paul-carlton2 has quit IRC | 15:22 | |
*** jaugustine has joined #openstack-nova | 15:22 | |
openstackgerrit | Sujitha proposed openstack/nova: Improve help text for glance options https://review.openstack.org/324007 | 15:22 |
*** jaugustine has quit IRC | 15:23 | |
*** pilgrimstack has quit IRC | 15:24 | |
*** shaohe_feng has joined #openstack-nova | 15:24 | |
*** stewie925 has joined #openstack-nova | 15:24 | |
mriedem1 | sdague: the change that removed the usage of api_rate_limit has a general reno on removing the legacy v2 api code https://review.openstack.org/#/c/312314/6/releasenotes/notes/remove-legacy-v2-api-7ac6d74edaedf011.yaml | 15:25 |
*** salv-orlando has quit IRC | 15:25 | |
mriedem1 | so i'm not sure we need a reno for actually removing the option, but maybe? | 15:25 |
mriedem1 | just to say it's removed and was broken anyway | 15:25 |
sdague | mriedem1: what's the commit look like where it defaults to false? | 15:25 |
*** salv-orlando has joined #openstack-nova | 15:26 | |
mriedem1 | i'll have to look it up, it's probably old | 15:26 |
sdague | the conversation was really around when it was set to false | 15:26 |
sdague | that's when we decided the code was basically useless | 15:27 |
*** rrecio_ has quit IRC | 15:27 | |
*** rrecio has joined #openstack-nova | 15:27 | |
mriedem1 | sdague: https://review.openstack.org/#/c/34821/ | 15:28 |
bzurawski | sdague: mriedem1 do you think that is worth broach this subject on some meeting ? | 15:28 |
mriedem1 | DocImpact | 15:28 |
*** chandankumar has joined #openstack-nova | 15:28 | |
mriedem1 | which means no docs | 15:28 |
mriedem1 | sdague: but it was made false in havana | 15:28 |
mriedem1 | so pretty damn old | 15:28 |
mriedem1 | and nothing in the havana release notes https://wiki.openstack.org/wiki/ReleaseNotes/Havana | 15:29 |
mriedem1 | so maybe just a reno in the 'other' section | 15:29 |
sdague | bzurawski: what meeting do you think it would be effective to bring up in? | 15:29 |
*** salv-orlando has quit IRC | 15:30 | |
openstackgerrit | Sujitha proposed openstack/nova: Improve help text for floating ips options. https://review.openstack.org/318309 | 15:30 |
*** salv-orlando has joined #openstack-nova | 15:30 | |
mriedem1 | i.e. 'the option was disabled by default in havana, it didn't work if api servers > 1, and is no longer used now that the legacy v2 api code is gone' | 15:30 |
*** diga has quit IRC | 15:30 | |
*** tongli has joined #openstack-nova | 15:31 | |
sdague | mriedem1: it's actually worse than that | 15:31 |
sdague | it doesn't work consistently if you have > 1 api worker | 15:31 |
sdague | because it's an in process counter | 15:31 |
*** shaohe_feng has quit IRC | 15:31 | |
*** artom_ has joined #openstack-nova | 15:31 | |
mriedem1 | so, how about, it was just broken | 15:32 |
mriedem1 | disabled in havana | 15:32 |
*** artom has quit IRC | 15:32 | |
mriedem1 | and now removed | 15:32 |
sdague | yeh | 15:32 |
*** shaohe_feng has joined #openstack-nova | 15:32 | |
sdague | I'm grinding on some unit tests, I'll put something up after that | 15:32 |
mdbooth | It looks to me like the libvirt driver calculates disk overcommit for file-backed disks using file size rather than allocated size | 15:32 |
mdbooth | Which would defeat the point of calculating it, right? | 15:33 |
*** liverpooler has quit IRC | 15:34 | |
*** mmandel has joined #openstack-nova | 15:34 | |
mdbooth | Unless it's not sparse. I guess that would be ok for non-metadata-preallocated qcow2 disks | 15:35 |
mdbooth | But not for metadata-preallocated qcow2 disks, or flat disks | 15:35 |
*** ctrath has left #openstack-nova | 15:35 | |
*** ctrath has joined #openstack-nova | 15:36 | |
*** lucas___ has quit IRC | 15:38 | |
*** permalac has joined #openstack-nova | 15:38 | |
*** lucas___ has joined #openstack-nova | 15:38 | |
*** gjayavelu has joined #openstack-nova | 15:38 | |
*** chandankumar has quit IRC | 15:40 | |
*** shaohe_feng has quit IRC | 15:42 | |
*** shaohe_feng has joined #openstack-nova | 15:43 | |
*** lucas____ has joined #openstack-nova | 15:43 | |
*** lucas___ has quit IRC | 15:43 | |
*** delattec has joined #openstack-nova | 15:44 | |
mriedem1 | sdague: i was going to put up the removal patch, just testing it now | 15:44 |
*** jdillaman has quit IRC | 15:44 | |
sdague | mriedem1: ok, cool | 15:46 |
sdague | I'm close to this disk config extension fold working | 15:46 |
*** cdelatte has quit IRC | 15:47 | |
*** lucas____ has quit IRC | 15:47 | |
*** ssurana has joined #openstack-nova | 15:48 | |
*** ssurana has quit IRC | 15:48 | |
*** gjayavelu has quit IRC | 15:48 | |
mriedem1 | sdague: ok, track it against https://blueprints.launchpad.net/nova/+spec/api-no-more-extensions please | 15:48 |
sdague | yep | 15:49 |
*** delattec has quit IRC | 15:51 | |
*** jlanoux has joined #openstack-nova | 15:52 | |
openstackgerrit | Michael Turek proposed openstack/nova: Ironic: use portgroups https://review.openstack.org/206163 | 15:52 |
*** shaohe_feng has quit IRC | 15:52 | |
*** gjayavelu has joined #openstack-nova | 15:52 | |
*** shaohe_feng has joined #openstack-nova | 15:53 | |
*** andreas_s has quit IRC | 15:53 | |
*** artom_ has quit IRC | 15:53 | |
*** delattec has joined #openstack-nova | 15:53 | |
openstackgerrit | Moshe Levi proposed openstack/nova-specs: User-controlled SR-IOV ports allocation https://review.openstack.org/182242 | 15:53 |
*** jwcroppe_ has joined #openstack-nova | 15:54 | |
*** MikeG451_ has quit IRC | 15:55 | |
*** jwcroppe has quit IRC | 15:55 | |
*** gcb has quit IRC | 15:55 | |
*** gcb has joined #openstack-nova | 15:56 | |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: Fix revert on migration with SR-IOV https://review.openstack.org/326174 | 15:57 |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: Allocate PCI devices on migration https://review.openstack.org/328983 | 15:57 |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: Update binding:profile for SR-IOV ports https://review.openstack.org/242573 | 15:57 |
*** ivase has quit IRC | 15:58 | |
*** yassine has quit IRC | 15:58 | |
dansmith | cdent: can you address these things quickly? https://review.openstack.org/#/c/326440/17 | 15:58 |
dansmith | if not, I'll do it | 15:58 |
*** artom has joined #openstack-nova | 15:58 | |
*** jaypipes has joined #openstack-nova | 15:59 | |
cdent | dansmith: I can do it, within about an hour | 15:59 |
dansmith | cdent: okay | 15:59 |
*** PaulMurray has joined #openstack-nova | 15:59 | |
cdent | need to flush a bit of state, but I have that branch in disarray at the moment, so better it be me | 16:00 |
*** ivase has joined #openstack-nova | 16:00 | |
dansmith | ok | 16:00 |
cdent | comments makes sense though, I can do that | 16:00 |
openstackgerrit | Andrey Volkov proposed openstack/nova: Make instance as second arg in compute api calls https://review.openstack.org/327713 | 16:00 |
dansmith | cool | 16:01 |
*** thorst is now known as thorst_afk | 16:01 | |
*** hemnafk is now known as hemna | 16:02 | |
*** shaohe_feng has quit IRC | 16:02 | |
*** shaohe_feng has joined #openstack-nova | 16:03 | |
*** ivase has quit IRC | 16:03 | |
openstackgerrit | melanie witt proposed openstack/nova: Disallow instance tag set for invalid instance states https://review.openstack.org/329304 | 16:03 |
*** matrohon has quit IRC | 16:04 | |
*** ljxiash has quit IRC | 16:05 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Transform instance.update notification https://review.openstack.org/325923 | 16:05 |
*** raunak has joined #openstack-nova | 16:05 | |
*** vtech has quit IRC | 16:05 | |
*** mpavone has quit IRC | 16:06 | |
*** MikeG451_ has joined #openstack-nova | 16:06 | |
*** jaugustine has joined #openstack-nova | 16:08 | |
*** gjayavelu has quit IRC | 16:08 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: api-ref: added docs for microversion 2.26 https://review.openstack.org/327089 | 16:08 |
openstackgerrit | Anusha Unnam proposed openstack/nova: Transform instance.resize notifications https://review.openstack.org/329255 | 16:09 |
*** raunak has quit IRC | 16:10 | |
*** xyang1 has quit IRC | 16:10 | |
*** ivase has joined #openstack-nova | 16:10 | |
*** ijw has joined #openstack-nova | 16:11 | |
pkholkin | bauzas: Hi Sylvain, thank you very much for v2.28 novaclient patch! | 16:12 |
*** lucas___ has joined #openstack-nova | 16:12 | |
bauzas | pkholkin: np | 16:12 |
*** shaohe_feng has quit IRC | 16:12 | |
pkholkin | bauzas: I returned too late to do smth :) | 16:12 |
*** raunak has joined #openstack-nova | 16:12 | |
*** gjayavelu has joined #openstack-nova | 16:13 | |
*** xyang1 has joined #openstack-nova | 16:13 | |
*** sridharg has quit IRC | 16:13 | |
bauzas | I still need to write my own 2.29 and 2.30 patches :) | 16:13 |
*** shaohe_feng has joined #openstack-nova | 16:13 | |
*** rlrossit has quit IRC | 16:13 | |
*** ctrath has quit IRC | 16:13 | |
pkholkin | bauzas: as I understand flatten_dict is not needed for 2.28 but is needed for older versions, so it you decided not to change anything here? | 16:14 |
dims | haypo : ack. thanks | 16:14 |
*** efoley has joined #openstack-nova | 16:14 | |
*** yamahata has quit IRC | 16:14 | |
*** ivase has quit IRC | 16:15 | |
*** mriedem has joined #openstack-nova | 16:15 | |
*** gjayavelu has quit IRC | 16:15 | |
*** gjayavelu has joined #openstack-nova | 16:15 | |
*** permalac has quit IRC | 16:16 | |
*** ctrath has joined #openstack-nova | 16:16 | |
*** Apoorva has joined #openstack-nova | 16:16 | |
*** anush__ has joined #openstack-nova | 16:16 | |
openstackgerrit | Sean Dague proposed openstack/nova: Tear down os-disk-config part 1 https://review.openstack.org/327188 | 16:16 |
openstackgerrit | Sean Dague proposed openstack/nova: Tear down of os-disk-config part 2 https://review.openstack.org/329549 | 16:16 |
*** lucas___ has quit IRC | 16:17 | |
*** Apoorva has quit IRC | 16:17 | |
*** rlrossit has joined #openstack-nova | 16:17 | |
*** rlrossit has quit IRC | 16:17 | |
*** rlrossit has joined #openstack-nova | 16:17 | |
*** yamahata has joined #openstack-nova | 16:18 | |
*** Apoorva has joined #openstack-nova | 16:18 | |
*** jaugustine has quit IRC | 16:18 | |
*** mriedem1 has quit IRC | 16:18 | |
*** lucas___ has joined #openstack-nova | 16:18 | |
bzurawski | sdague: this one https://wiki.openstack.org/wiki/Meetings/Nova | 16:19 |
*** lucas___ has quit IRC | 16:19 | |
*** lucas___ has joined #openstack-nova | 16:19 | |
bzurawski | sdague: i'm do not know exactly what is happening at such meetings, so i can be wrong :) | 16:19 |
sdague | bzurawski: sure, we could add it there. What kind of outcome are you looking for | 16:19 |
bzurawski | outcome you mean what i want to achive on this meeting ? | 16:20 |
bzurawski | sdague: ^ | 16:21 |
sdague | bzurawski: yeh, because knowing what you are hoping to acheive would be useful in figuring out what the right audience for the conversation | 16:21 |
mriedem | bzurawski: i recommend reading that operators thread i started, there have already been several replies | 16:22 |
mriedem | on the api rate limiting topic | 16:22 |
*** shaohe_feng has quit IRC | 16:23 | |
sdague | I also put it into a more general conversation for one of the upcoming TC meetings, but that would be mostly about finding like minded folks | 16:23 |
*** shaohe_feng has joined #openstack-nova | 16:23 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Remove api_rate_limit config option https://review.openstack.org/329554 | 16:24 |
bzurawski | sdague: i just want to know what other developers thinking about it, and maybe after that is it worth it to create blueprint for such feature ? | 16:24 |
bzurawski | mriedem: yep, i've read this | 16:24 |
sdague | bzurawski: right, well it definitely wouldn't be in Nova | 16:25 |
bzurawski | sdague: aaaa, you're right :/ | 16:25 |
bzurawski | it's oslo at least, oki, sorry my mistake :) | 16:25 |
sdague | I think the ops mailing list is most likely discussion forum right now to find the right like minded folks | 16:25 |
bzurawski | sdague: oki, will use it in first step :) | 16:26 |
bzurawski | sdague: mriedem thanks for your help and support :) | 16:26 |
auggy | good morning! | 16:27 |
*** daemontool has quit IRC | 16:28 | |
*** daemontool has joined #openstack-nova | 16:29 | |
*** clenimar has joined #openstack-nova | 16:29 | |
sneti | Hi all, I'm facing issue with restarting nova services. Getting error: TypeError: __init__() got an unexpected keyword argument 'restart_method' in n-api and ValueError: invalid limits: cpu_time | 16:29 |
sneti | in n-cpu. Anybody facing this issue? | 16:29 |
*** vtech has joined #openstack-nova | 16:29 | |
mriedem | sneti: you need the latest oslo.concurrency | 16:29 |
mriedem | sneti: are you on mitaka or master? | 16:29 |
sneti | mriedem, I'm on master | 16:30 |
mriedem | ok, update oslo.concurrency | 16:30 |
mriedem | to 1.8.0 | 16:30 |
mriedem | sorry, 3.8.0 | 16:30 |
sneti | mriedem, thank you!! will try that | 16:30 |
*** zenoway has quit IRC | 16:31 | |
*** Sukhdev has joined #openstack-nova | 16:31 | |
*** zenoway has joined #openstack-nova | 16:31 | |
mriedem | johnthetubaguy: live migration job passed after skipping nfs and ceph | 16:31 |
mriedem | http://logs.openstack.org/86/327886/3/experimental/gate-tempest-dsvm-multinode-live-migration/475fbc3/console.html | 16:31 |
mriedem | tdurakov: ^ | 16:32 |
mriedem | so i'm not sure if we should enable nfs again now or not, we should probably at least check on the failure in tdurakov's test run first | 16:32 |
tdurakov | mriedem: could we confirm that without nfs and ceph job become stable on 16.04? | 16:33 |
*** shaohe_feng has quit IRC | 16:33 | |
*** gszasz has quit IRC | 16:33 | |
*** ijw has quit IRC | 16:33 | |
*** anush__ has quit IRC | 16:33 | |
tdurakov | I mean is it stable, or we are just lucky once | 16:34 |
*** shaohe_feng has joined #openstack-nova | 16:34 | |
*** nkrinner is now known as nkrinner_afk | 16:34 | |
*** anush__ has joined #openstack-nova | 16:34 | |
*** jaypipes has quit IRC | 16:35 | |
*** ijw has joined #openstack-nova | 16:35 | |
*** fragatina has joined #openstack-nova | 16:36 | |
*** zenoway has quit IRC | 16:36 | |
*** jlanoux has quit IRC | 16:36 | |
*** fragatin_ has joined #openstack-nova | 16:36 | |
*** moshele has quit IRC | 16:38 | |
*** anush__ has quit IRC | 16:38 | |
*** tongli has quit IRC | 16:39 | |
*** fragatina has quit IRC | 16:40 | |
*** daemontool has quit IRC | 16:43 | |
*** tesseract has quit IRC | 16:43 | |
*** shaohe_feng has quit IRC | 16:43 | |
*** diga has joined #openstack-nova | 16:43 | |
*** sfinucan has quit IRC | 16:44 | |
*** shaohe_feng has joined #openstack-nova | 16:44 | |
openstackgerrit | Sarafraj Singh proposed openstack/nova: Adding details in general purpose feature matrix [1] https://review.openstack.org/327326 | 16:44 |
mriedem | tdurakov: i don't think we'll know until we get some runs w/o nfs and ceph | 16:45 |
mriedem | tdurakov: so i think we should probably merge my patch to skip nfs/ceph, let that run for a few days and see if we're hitting the same failures as before | 16:45 |
*** ssurana has joined #openstack-nova | 16:46 | |
tdurakov | mriedem: agree, let's gather some stats | 16:46 |
*** mvk has quit IRC | 16:47 | |
tdurakov | Than will enable other backends step by step | 16:47 |
mriedem | tdurakov: find me a +W for this then :) https://review.openstack.org/#/c/327886/ | 16:48 |
*** wanghao has quit IRC | 16:49 | |
*** salv-orlando has quit IRC | 16:49 | |
*** wanghao has joined #openstack-nova | 16:49 | |
*** salv-orlando has joined #openstack-nova | 16:50 | |
*** ijw has quit IRC | 16:50 | |
*** danpb has quit IRC | 16:50 | |
gibi | zhs: hi! I answered you question in https://review.openstack.org/#/c/313654/ Could you check it please? | 16:51 |
*** Daisy has joined #openstack-nova | 16:52 | |
*** gjayavelu has quit IRC | 16:52 | |
tdurakov | mriedem: left comment | 16:53 |
*** shaohe_feng has quit IRC | 16:53 | |
tdurakov | +1 | 16:54 |
mriedem | dansmith: sdague: want to +W this in so we can start seeing how stable the live migration job is with the basic config? https://review.openstack.org/#/c/327886/ | 16:54 |
*** shaohe_feng has joined #openstack-nova | 16:54 | |
mriedem | although, | 16:54 |
mriedem | tdurakov: we already run the basic live migration config in the multinode job right? | 16:54 |
mriedem | which is non-voting in the check queue | 16:55 |
tdurakov | mriedem: check pipeline contains multinode job with full tempest suite | 16:55 |
mriedem | yeah, i guess this would tell us in a more targeted way | 16:55 |
mriedem | but you have to run the job manually | 16:56 |
tdurakov | mriedem: what about moving it to check pipeline, non-voting of course? | 16:56 |
*** Daisy has quit IRC | 16:56 | |
*** browne has joined #openstack-nova | 16:56 | |
mriedem | tdurakov: not sure | 16:57 |
mriedem | it would raise the visibility | 16:57 |
mriedem | but if we did that, would we disable the live migration tests in the multinode job? | 16:57 |
mriedem | and make that voting since i think the only reason it's non-voting is because of the flaky live migration tests | 16:57 |
mriedem | i think that would be the course | 16:57 |
tdurakov | I'd run both for a while, it's a question of 2-3 days to decide about its stability | 16:57 |
*** sajeesh has joined #openstack-nova | 16:58 | |
mriedem | tdurakov: sure, let's revisit next week maybe, next live migration meeting? | 16:58 |
tdurakov | yup | 16:58 |
*** acabot has quit IRC | 16:59 | |
*** pushkaru has joined #openstack-nova | 16:59 | |
tdurakov | so to summarize, we leave live-migration job in experimental pipeline till next live-migration meeting, to decide whether it's stable or not | 16:59 |
mriedem | yup | 17:00 |
tdurakov | sounds good | 17:00 |
*** tblakeslee has joined #openstack-nova | 17:01 | |
openstackgerrit | John Garbutt proposed openstack/nova: Extract _filter_hypervisor_macs https://review.openstack.org/329569 | 17:01 |
*** tblakeslee_ has joined #openstack-nova | 17:02 | |
*** irenab has joined #openstack-nova | 17:02 | |
*** ivase has joined #openstack-nova | 17:02 | |
*** ijw has joined #openstack-nova | 17:02 | |
*** acabot has joined #openstack-nova | 17:03 | |
*** shaohe_feng has quit IRC | 17:04 | |
*** shaohe_feng has joined #openstack-nova | 17:04 | |
*** lpetrut has quit IRC | 17:05 | |
*** sajeesh has quit IRC | 17:05 | |
*** tblakeslee has quit IRC | 17:06 | |
*** tblakeslee_ is now known as tblakeslee | 17:06 | |
*** markus_z has joined #openstack-nova | 17:06 | |
*** thorst_afk is now known as thorst | 17:07 | |
*** tblakeslee has quit IRC | 17:09 | |
stewie925 | hello all, I would like to work on the api-ref parameter verification for 'os-floating-ips.inc' | 17:10 |
*** vtech has quit IRC | 17:10 | |
*** diga_ has joined #openstack-nova | 17:11 | |
*** diga has quit IRC | 17:12 | |
*** McNinja has quit IRC | 17:13 | |
stewie925 | tho I'd like some clarification on how to do the verification | 17:13 |
openstackgerrit | Chris Dent proposed openstack/nova: Add Allocation and AllocationList objects https://review.openstack.org/282442 | 17:13 |
openstackgerrit | Chris Dent proposed openstack/nova: Add delete_, update_ and add_ inventory to ResourceProvider https://review.openstack.org/328276 | 17:13 |
openstackgerrit | Chris Dent proposed openstack/nova: Add support for resource inventories to placement API https://review.openstack.org/329152 | 17:13 |
openstackgerrit | Chris Dent proposed openstack/nova: Add a ResourceProviderList object https://review.openstack.org/328307 | 17:13 |
openstackgerrit | Chris Dent proposed openstack/nova: Add set_inventory() method on ResourceProvider https://review.openstack.org/326440 | 17:13 |
openstackgerrit | Chris Dent proposed openstack/nova: Add initial framing of placement API https://review.openstack.org/329149 | 17:13 |
openstackgerrit | Chris Dent proposed openstack/nova: Add support for resource_providers urls https://review.openstack.org/329151 | 17:13 |
openstackgerrit | Chris Dent proposed openstack/nova: Add microversion support for the placement API https://review.openstack.org/329150 | 17:13 |
openstackgerrit | Chris Dent proposed openstack/nova: WIP experiment with the remainder of the placement API https://review.openstack.org/293104 | 17:13 |
openstackgerrit | Chris Dent proposed openstack/nova: WIP Add a Usage and UsageList object https://review.openstack.org/329575 | 17:13 |
cdent | there ya go dansmith, I think that's go what you were hoping for | 17:13 |
*** McNinja has joined #openstack-nova | 17:13 | |
*** shaohe_feng has quit IRC | 17:14 | |
*** edand has joined #openstack-nova | 17:14 | |
mriedem | stewie925: just post the question and if someone can answer they will/might | 17:14 |
*** wanghao has quit IRC | 17:14 | |
*** shaohe_feng has joined #openstack-nova | 17:15 | |
*** wanghao has joined #openstack-nova | 17:16 | |
*** ducttape_ has quit IRC | 17:17 | |
mriedem | mdbooth: diana_clarke: is this the head of the libvirt imagebackend refactor series as of today? https://review.openstack.org/#/c/326947/ | 17:17 |
mriedem | looks like it but wanted to check before making this devstack change depend on it | 17:17 |
raj_singh | stewie925: Here is wiki for reference https://wiki.openstack.org/wiki/NovaAPIRef | 17:17 |
*** klkumar has quit IRC | 17:17 | |
*** pradk has joined #openstack-nova | 17:17 | |
stewie925 | for paremeter verification - i'd like to know how to specifically ensure that the parameter list is complete | 17:17 |
mriedem | stewie925: it's mostly checking api samples, checking code, and possibly testing it out with devstack | 17:17 |
*** zehua has quit IRC | 17:17 | |
mriedem | stewie925: the rest is up to good code review | 17:17 |
*** ijw__ has joined #openstack-nova | 17:17 | |
*** mvk has joined #openstack-nova | 17:18 | |
*** ijw__ has quit IRC | 17:18 | |
stewie925 | hi raj_singh yes I am actually looking at that doc right now :) | 17:18 |
*** zehua has joined #openstack-nova | 17:19 | |
mriedem | stewie925: if you're learning, it's also probably helpful to just take your best attempt and then learn through code review if you missed something | 17:19 |
mriedem | rather than try to get it perfect in patch set 1 | 17:19 |
*** ijw__ has joined #openstack-nova | 17:19 | |
*** ijw has quit IRC | 17:20 | |
stewie925 | oh I see, thank you | 17:20 |
*** rama_y has joined #openstack-nova | 17:21 | |
mriedem | mdbooth: diana_clarke: fyi https://review.openstack.org/#/c/318262/ | 17:22 |
*** lixiaoy1 has quit IRC | 17:22 | |
*** alex_xu has quit IRC | 17:22 | |
*** gzhai2 has quit IRC | 17:23 | |
*** ijw has joined #openstack-nova | 17:24 | |
*** lixiaoy1 has joined #openstack-nova | 17:24 | |
*** shaohe_feng has quit IRC | 17:24 | |
*** gzhai2 has joined #openstack-nova | 17:24 | |
*** alex_xu has joined #openstack-nova | 17:25 | |
*** salv-orlando has quit IRC | 17:26 | |
*** salv-orlando has joined #openstack-nova | 17:26 | |
*** shaohe_feng has joined #openstack-nova | 17:27 | |
*** ducttape_ has joined #openstack-nova | 17:28 | |
*** salv-orl_ has joined #openstack-nova | 17:29 | |
markus_z | nova bugs team meeting in 30 min in openstack-meeting-4 | 17:31 |
*** moshele has joined #openstack-nova | 17:32 | |
*** salv-orlando has quit IRC | 17:32 | |
openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova: [WIP]Improve help text for allocation_ratio_opts https://review.openstack.org/329593 | 17:32 |
*** shaohe_feng has quit IRC | 17:34 | |
*** shaohe_feng has joined #openstack-nova | 17:35 | |
*** jwcroppe has joined #openstack-nova | 17:37 | |
*** gzhai2 has quit IRC | 17:37 | |
*** markus_z has quit IRC | 17:38 | |
*** gzhai2 has joined #openstack-nova | 17:38 | |
*** markus_z has joined #openstack-nova | 17:38 | |
*** mriedem1 has joined #openstack-nova | 17:38 | |
*** diga_ has quit IRC | 17:39 | |
*** jwcroppe_ has quit IRC | 17:39 | |
*** mriedem has quit IRC | 17:40 | |
*** JoseMello has joined #openstack-nova | 17:40 | |
*** tonytan4ever has joined #openstack-nova | 17:41 | |
*** jdillaman has joined #openstack-nova | 17:41 | |
*** jwcroppe_ has joined #openstack-nova | 17:41 | |
mriedem1 | dansmith: to answer your earlier question, validate_networks is specifically passed a list of tuples https://github.com/openstack/nova/blob/master/nova/compute/api.py#L422 | 17:41 |
mriedem1 | i think b/c of nova-net, checking | 17:42 |
*** mriedem1 is now known as mriedem | 17:42 | |
*** sambetts is now known as sambetts|afk | 17:42 | |
*** jwcroppe has quit IRC | 17:42 | |
mriedem | dansmith: and that's because we don't convert it to a tuple in network rpcapi https://github.com/openstack/nova/blob/master/nova/network/rpcapi.py#L202 | 17:44 |
mriedem | would be an easy change though | 17:44 |
mriedem | mayhap i'll do that | 17:44 |
*** shaohe_feng has quit IRC | 17:45 | |
*** ociuhandu has quit IRC | 17:45 | |
*** shaohe_feng has joined #openstack-nova | 17:45 | |
*** kfarr has joined #openstack-nova | 17:45 | |
*** ihrachys has quit IRC | 17:46 | |
*** gjayavelu has joined #openstack-nova | 17:47 | |
dansmith | mriedem: cool | 17:47 |
*** gjayavelu has quit IRC | 17:47 | |
openstackgerrit | Sarafraj Singh proposed openstack/nova: WIP - Improve help context of key_manager.py https://review.openstack.org/329599 | 17:47 |
mriedem | dansmith: also on https://review.openstack.org/#/c/309574/16/nova/network/neutronv2/api.py@1130 i remembered why I changed it to if not requested_networks - because if it's an empty list, the conversion above won't evaluate to true and then [].auto_allocate will fail | 17:49 |
openstackgerrit | John Garbutt proposed openstack/nova: Rename _process_requested_networks https://review.openstack.org/329600 | 17:49 |
openstackgerrit | John Garbutt proposed openstack/nova: WIP: Extract _validate_requested_network_ids https://review.openstack.org/329601 | 17:49 |
mriedem | i guess way up in the REST API, requested_networks is going to be None unless the user passed something in on the request | 17:51 |
*** tbachman has joined #openstack-nova | 17:51 | |
mriedem | so i guess worrying about an empty list is pointless | 17:51 |
*** mtanino has quit IRC | 17:51 | |
openstackgerrit | Chris Dent proposed openstack/nova: WIP Add a Usage and UsageList object https://review.openstack.org/329575 | 17:51 |
openstackgerrit | Chris Dent proposed openstack/nova: WIP experiment with the remainder of the placement API https://review.openstack.org/293104 | 17:51 |
mriedem | it might be possible to pass networks=[] in on the server request, but that'd be dumb... | 17:53 |
*** jwcroppe has joined #openstack-nova | 17:53 | |
*** ijw has quit IRC | 17:53 | |
*** shaohe_feng has quit IRC | 17:55 | |
*** jwcroppe_ has quit IRC | 17:55 | |
*** ijw has joined #openstack-nova | 17:55 | |
*** vishwanathj has quit IRC | 17:56 | |
*** shaohe_feng has joined #openstack-nova | 17:56 | |
markus_z | nova bugs team meeting in 5 min in #openstack-meeting-4 | 17:56 |
*** ijw has quit IRC | 17:57 | |
*** ctrath has quit IRC | 17:57 | |
*** xenogear has joined #openstack-nova | 17:57 | |
*** tpepper is now known as tcpepper | 18:01 | |
*** tyrola has quit IRC | 18:02 | |
*** tcpepper has quit IRC | 18:03 | |
mriedem | BobBall: anthonyper: fyi, new bug, something you'd probably care about https://bugs.launchpad.net/nova/+bug/1592362 | 18:03 |
openstack | Launchpad bug 1592362 in OpenStack Compute (nova) "[XenAPI] add a maximum retry count for vbd unplug" [Low,Confirmed] - Assigned to Jianghua Wang (wjh-fresh) | 18:03 |
*** tpepper has joined #openstack-nova | 18:03 | |
*** tpepper has quit IRC | 18:04 | |
*** tpepper has joined #openstack-nova | 18:04 | |
*** tpepper has quit IRC | 18:04 | |
*** shaohe_feng has quit IRC | 18:05 | |
*** shaohe_feng has joined #openstack-nova | 18:06 | |
*** shihanzhang has joined #openstack-nova | 18:06 | |
*** shz has quit IRC | 18:07 | |
*** sudipto has quit IRC | 18:08 | |
*** mtanino has joined #openstack-nova | 18:08 | |
mriedem | bauzas: look familiar? https://bugs.launchpad.net/nova/+bug/1592241 | 18:09 |
openstack | Launchpad bug 1592241 in OpenStack Compute (nova) "memory_mb_used of compute node do not consider reserved_huge_pages" [Undecided,New] - Assigned to liuxiuli (liu-lixiu) | 18:09 |
*** dmk0202 has joined #openstack-nova | 18:09 | |
bauzas | mriedem: well, not really | 18:09 |
mriedem | yeah, nvm | 18:10 |
mriedem | maybe sahid would be able to help on that one | 18:10 |
* bauzas currently investigating a n-net issue with a local devstack running on an OVH cloud :/ | 18:10 | |
*** salv-orl_ has quit IRC | 18:10 | |
bauzas | graaah | 18:10 |
*** salv-orlando has joined #openstack-nova | 18:11 | |
*** salv-orlando has quit IRC | 18:11 | |
*** salv-orlando has joined #openstack-nova | 18:12 | |
*** raunak has quit IRC | 18:12 | |
clarkb | bauzas: I probably know what the issue is | 18:12 |
bauzas | clarkb: orly ? | 18:12 |
clarkb | bauzas: nova net reconfigures your eth0 and doesn't like that OVH uses a /32 on eth0 with the default gateway not in that range | 18:12 |
clarkb | so nova net fails to configure networking and the host breaks | 18:13 |
melwitt | does anyone happen to know why a python traceback might skip a step in a trace? example, I see nova/objects/service.py followed by nova/db/sqlalchemy/api.py and it's not showing the intermediate step of nova/db/api.py | 18:13 |
bauzas | clarkb: tbc, when booting an instance from a devstack AIO, my VM is trampled | 18:13 |
*** tbachman_ has joined #openstack-nova | 18:13 | |
clarkb | bauzas: yes | 18:13 |
bauzas | clarkb: yes, that's the problem | 18:13 |
clarkb | you cna avoid this by creating a bridge to point nova net at and then if you like you can attach that bridge to the external world | 18:13 |
bauzas | clarkb: any workaround ? | 18:13 |
bauzas | mmm | 18:13 |
clarkb | basically you have to tell nova net not to use eth0 | 18:14 |
bauzas | clarkb: do we have kind of a script for that ? | 18:14 |
*** mvk_ has joined #openstack-nova | 18:14 | |
clarkb | bauzas: devstack-gate does it but doesn't give nested VMs external connectivity | 18:14 |
*** moshele has quit IRC | 18:14 | |
bauzas | meh | 18:14 |
clarkb | and when I brought it up with nova no one was interested in fixing nova net | 18:14 |
clarkb | so I doubt you willget much traction there | 18:14 |
bauzas | clarkb: you mean using the FLAT_INTERFACE=<my_bridge> ? | 18:14 |
*** tbachman has quit IRC | 18:15 | |
clarkb | ya | 18:15 |
*** tbachman_ is now known as tbachman | 18:15 | |
*** ctrath has joined #openstack-nova | 18:15 | |
*** Sukhdev has quit IRC | 18:15 | |
bauzas | clarkb: do you have a bug ? | 18:15 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: libvirt: attach configdrive after instance XML https://review.openstack.org/303335 | 18:15 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: objects: adding an update method to virtual_interface https://review.openstack.org/310618 | 18:15 |
bauzas | clarkb: for devstack ? | 18:15 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: objects: Add devices_metadata to instance object https://review.openstack.org/327920 | 18:15 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: db: add a device_metadata column to instance_extra https://review.openstack.org/318883 | 18:15 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: Device tagging metadata API support https://review.openstack.org/304511 | 18:15 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: objects: new InstanceDevicesMetadata object https://review.openstack.org/318884 | 18:15 |
clarkb | bauzas: no I was told it wasn't a bug | 18:15 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: Device tagging API support https://review.openstack.org/304510 | 18:15 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: Compute manager device tagging support https://review.openstack.org/264017 | 18:15 |
clarkb | bauzas: hence the undesire to not fix anything :) | 18:15 |
bauzas | clarkb: well, I understand | 18:15 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: Libvirt driver implementation of device tagging https://review.openstack.org/264016 | 18:15 |
*** shaohe_feng has quit IRC | 18:15 | |
clarkb | and if anything it is an issue iwth nova not with devstack | 18:15 |
*** tbachman has quit IRC | 18:15 | |
clarkb | devstack has nothing to do wit hit | 18:15 |
bauzas | clarkb: I'll speak at a local conf tomorrow and will run a workshop about using devstack | 18:16 |
bauzas | clarkb: so the local OVH guys gave us some credit vouchers | 18:16 |
*** shaohe_feng has joined #openstack-nova | 18:16 | |
bauzas | clarkb: but it looks it's a problem... | 18:16 |
clarkb | yes in nova net | 18:16 |
clarkb | you will have the same issue if you nova net without devstack | 18:16 |
bauzas | yup, yup, I understand | 18:17 |
*** mvk has quit IRC | 18:17 | |
bauzas | neutron AIO then ? | 18:17 |
clarkb | that may be simplest | 18:17 |
bauzas | mmm | 18:17 |
*** ijw has joined #openstack-nova | 18:17 | |
bauzas | or creating a bond and using it for FLAT_INTERFACE like you said ? | 18:18 |
clarkb | ya | 18:18 |
clarkb | so that nova net doesn't get confused by the eth0 config | 18:18 |
bauzas | I see | 18:18 |
bauzas | clarkb: you're in US TZ right ? | 18:18 |
clarkb | I am | 18:18 |
*** tbachman has joined #openstack-nova | 18:19 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Skip network allocation if 'none' is requested https://review.openstack.org/309638 | 18:19 |
bauzas | clarkb: in case that works, I should send you a kitkat :p | 18:19 |
openstackgerrit | Matt Riedemann proposed openstack/nova: nova-net: handle 'auto' network request in allocate_for_instance https://review.openstack.org/297906 | 18:19 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Bump the service version for get-me-a-network support https://review.openstack.org/318953 | 18:19 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Skip network validation if explicitly requesting no networks https://review.openstack.org/309602 | 18:19 |
openstackgerrit | Matt Riedemann proposed openstack/nova: neutron: handle 'auto' network request in allocate_for_instance https://review.openstack.org/316275 | 18:19 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add helpers to NetworkRequest(List) objects for auto/none cases https://review.openstack.org/297871 | 18:19 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add REST API support for get me a network https://review.openstack.org/316398 | 18:19 |
openstackgerrit | Matt Riedemann proposed openstack/nova: neutron: validate auto-allocate is available https://review.openstack.org/309574 | 18:19 |
*** stewie925 has quit IRC | 18:23 | |
*** raunak has joined #openstack-nova | 18:24 | |
vladikr | dansmith, Hi, when you'll have a moment, could you please look at the device tagging series. particularly https://review.openstack.org/#/c/318884, https://review.openstack.org/#/c/327920 ? | 18:24 |
dansmith | vladikr: cool, yep | 18:25 |
*** efoley has quit IRC | 18:25 | |
*** joshw42 has joined #openstack-nova | 18:25 | |
vladikr | dansmith, thanks | 18:25 |
*** shaohe_feng has quit IRC | 18:26 | |
openstackgerrit | melanie witt proposed openstack/nova: Add output of the DB calls found by DatabasePoisonFixture https://review.openstack.org/328573 | 18:26 |
*** lpetrut has joined #openstack-nova | 18:26 | |
*** raunak has quit IRC | 18:26 | |
*** raunak has joined #openstack-nova | 18:26 | |
*** shaohe_feng has joined #openstack-nova | 18:26 | |
mriedem | hmm, we probably have a bug here: | 18:28 |
mriedem | https://github.com/openstack/nova/blob/14.0.0.0b1/nova/api/metadata/base.py#L309 | 18:28 |
mriedem | that assumes if you have instance.key_name then instance.keypairs will be at least a list of length 1 | 18:28 |
mriedem | but if we can't find that keypair in instance_extra or the keypairs table, the list would be empty https://github.com/openstack/nova/blob/14.0.0.0b1/nova/objects/instance.py#L869 | 18:29 |
*** baoli_ has quit IRC | 18:29 | |
*** dmk0202 has quit IRC | 18:30 | |
*** harlowja has quit IRC | 18:30 | |
mriedem | https://bugs.launchpad.net/nova/+bug/1592167 | 18:30 |
openstack | Launchpad bug 1592167 in OpenStack Compute (nova) "Deleted keypair causes metadata failure" [Undecided,Incomplete] | 18:30 |
dansmith | mriedem: if key name | 18:31 |
dansmith | mriedem: we don't look it up anymore, so if key_name is set, it's in the list | 18:31 |
mriedem | iff the keypair isn't in instance_extra | 18:31 |
*** rlrossit has quit IRC | 18:31 | |
dansmith | ah, I guess yeah | 18:32 |
*** markus_z has quit IRC | 18:32 | |
*** harlowja has joined #openstack-nova | 18:32 | |
mriedem | yeah there is this https://github.com/openstack/nova/blob/14.0.0.0b1/nova/compute/api.py#L946 | 18:32 |
dansmith | mriedem: you see this from a bug/ | 18:32 |
mriedem | dansmith: the bug was reported against kilo | 18:33 |
mriedem | dansmith: so i was checking the master code to see if it could still happen | 18:33 |
mriedem | which it looks like it could, if you deleted the keypair from the main db before the keypair on the instance was migrated to instance_extra | 18:33 |
dansmith | oh, okay, good :D | 18:33 |
dansmith | yeah | 18:33 |
mriedem | and then later try to get metadata by json from the metadata service | 18:33 |
dansmith | yup | 18:33 |
*** anush__ has joined #openstack-nova | 18:33 | |
mriedem | so i guess we should just check the length of that instance.keypairs list in the metadata api | 18:34 |
mriedem | or let this raise up? https://github.com/openstack/nova/blob/14.0.0.0b1/nova/objects/instance.py#L869 | 18:34 |
mriedem | and handle that in the metadata api - that would be backportable | 18:34 |
dansmith | no it wouldn't | 18:34 |
dansmith | that doesn't exist in kilo | 18:35 |
mriedem | no, but the flavornotfound does | 18:35 |
mriedem | that was the bug | 18:35 |
mriedem | https://github.com/openstack/nova/blob/stable/kilo/nova/api/metadata/base.py#L314 | 18:35 |
dansmith | we should just check the list length | 18:35 |
dansmith | because that's the behavior you'll get if you delete a keypair where instances have a key_name still | 18:35 |
dansmith | I can do that on master if you want | 18:35 |
mriedem | i can do it quick | 18:35 |
mriedem | mitaka would have a separate fix if we wanted to fix in mitaka https://github.com/openstack/nova/blob/stable/mitaka/nova/api/metadata/base.py#L327 | 18:36 |
*** shaohe_feng has quit IRC | 18:36 | |
*** shaohe_feng has joined #openstack-nova | 18:36 | |
mriedem | assigned myself the bug so i've got dibs :) | 18:37 |
dansmith | heh | 18:37 |
mriedem | this is what you get when you attend the bug meeting | 18:37 |
mriedem | more work | 18:37 |
* cdent writes wisdom from dear leader in little notebook: "Never attend meetings" | 18:40 | |
*** bzurawski has quit IRC | 18:41 | |
*** lucas___ has quit IRC | 18:43 | |
mriedem | heh, to update MetadataTestCase or OpenStackMetadataTestCase - that is the question | 18:44 |
*** salv-orlando has quit IRC | 18:45 | |
*** sdague has quit IRC | 18:46 | |
*** salv-orlando has joined #openstack-nova | 18:46 | |
*** shaohe_feng has quit IRC | 18:46 | |
*** lifeless has quit IRC | 18:46 | |
*** shaohe_feng has joined #openstack-nova | 18:47 | |
bauzas | clarkb: could you please point me the devstack-gate script for OVH VMs ? | 18:47 |
*** lucas___ has joined #openstack-nova | 18:47 | |
*** lucas___ has quit IRC | 18:47 | |
*** lifeless has joined #openstack-nova | 18:47 | |
*** lucas___ has joined #openstack-nova | 18:47 | |
clarkb | bauzas: https://git.openstack.org/cgit/openstack-infra/devstack-gate/tree/devstack-vm-gate.sh#n69 | 18:47 |
bauzas | clarkb: because I need to give a static bridge for getting a /24 netmask :( | 18:47 |
bauzas | clarkb: k thanks | 18:49 |
*** vtech has joined #openstack-nova | 18:50 | |
*** rk4n has quit IRC | 18:54 | |
*** syjulian has quit IRC | 18:54 | |
*** syjulian has joined #openstack-nova | 18:54 | |
*** edand has quit IRC | 18:56 | |
*** shaohe_feng has quit IRC | 18:56 | |
*** shaohe_feng has joined #openstack-nova | 18:57 | |
mriedem | dansmith: actually i'm not sure what we should return in this case, 404 from the api seems correct if you deleted your keypair...returning metadata w/o the keys or public_keys item in the response seems wrong | 18:58 |
*** zenoway has joined #openstack-nova | 18:58 | |
mriedem | i mean, we should avoid the IndexError | 18:58 |
dansmith | mriedem: but you don't want 404 for the whole deal, right? | 18:58 |
openstackgerrit | Karen Bradshaw proposed openstack/nova: api-ref, os-availability-zone.inc https://review.openstack.org/321847 | 18:59 |
mriedem | wouldn't we 404 from the rest api in case like this? | 18:59 |
dansmith | mriedem: yeah, but this is where we build the whole metadata object right? | 18:59 |
mriedem | yeah | 18:59 |
mriedem | wait, no | 19:00 |
*** lucas___ has quit IRC | 19:00 | |
mriedem | that happens in the InstanceMetadata object constructor | 19:00 |
mriedem | well, __init__ | 19:00 |
dansmith | _metadata_as_json is where we build the whole thing right? | 19:00 |
mriedem | this is handling the meta_data.json request | 19:00 |
*** eglynn has quit IRC | 19:00 | |
dansmith | we can't fail there or metadata is completely inaccessible right? | 19:00 |
mriedem | yeah, for meta_data.json | 19:01 |
mriedem | which is the most useful stuff | 19:01 |
mriedem | just not sure what the correct thing is for the response, don't include those keys in the dict or include them with empty values | 19:01 |
*** tbachman_ has joined #openstack-nova | 19:01 | |
dansmith | mriedem: the same behavior as if you don't have a key, I'd say | 19:01 |
*** lucas___ has joined #openstack-nova | 19:02 | |
mriedem | yeah was just thinking that | 19:02 |
mriedem | and probably log something | 19:02 |
mriedem | for when the ticket is opened | 19:02 |
dansmith | yeah | 19:02 |
mriedem | 'well you deleted your ticket, numbnuts' | 19:02 |
mriedem | s/ticket/keypair/ | 19:02 |
dansmith | LOG.warning('Stupid user calling in 3...2...1...') | 19:02 |
mriedem | ok, meeting | 19:02 |
mriedem | heh | 19:02 |
*** lucas___ has quit IRC | 19:02 | |
*** lucas___ has joined #openstack-nova | 19:03 | |
*** ctrath has quit IRC | 19:04 | |
*** lucas___ has quit IRC | 19:04 | |
*** lucas___ has joined #openstack-nova | 19:04 | |
*** tbachman has quit IRC | 19:05 | |
*** tbachman_ is now known as tbachman | 19:05 | |
*** dmk0202 has joined #openstack-nova | 19:05 | |
*** raunak has quit IRC | 19:06 | |
*** sdake has quit IRC | 19:06 | |
*** ctrath has joined #openstack-nova | 19:06 | |
*** shaohe_feng has quit IRC | 19:07 | |
*** sdake has joined #openstack-nova | 19:07 | |
*** shaohe_feng has joined #openstack-nova | 19:07 | |
*** omnipresent has joined #openstack-nova | 19:08 | |
*** zenoway has quit IRC | 19:10 | |
*** fragatin_ has quit IRC | 19:12 | |
*** tbachman has quit IRC | 19:13 | |
*** anush__ has quit IRC | 19:14 | |
*** PaulMurray has quit IRC | 19:14 | |
openstackgerrit | Pushkar Umaranikar proposed openstack/nova: [WIP] Improve help text for compute manager options https://review.openstack.org/329639 | 19:16 |
*** shaohe_feng has quit IRC | 19:17 | |
*** shaohe_feng has joined #openstack-nova | 19:17 | |
*** anush__ has joined #openstack-nova | 19:21 | |
openstackgerrit | Chris Dent proposed openstack/nova: Add Allocation and AllocationList objects https://review.openstack.org/282442 | 19:22 |
openstackgerrit | Chris Dent proposed openstack/nova: Add delete_, update_ and add_ inventory to ResourceProvider https://review.openstack.org/328276 | 19:22 |
openstackgerrit | Chris Dent proposed openstack/nova: Add support for resource inventories to placement API https://review.openstack.org/329152 | 19:22 |
openstackgerrit | Chris Dent proposed openstack/nova: Add a ResourceProviderList object https://review.openstack.org/328307 | 19:22 |
openstackgerrit | Chris Dent proposed openstack/nova: Add set_inventory() method on ResourceProvider https://review.openstack.org/326440 | 19:22 |
openstackgerrit | Chris Dent proposed openstack/nova: Add initial framing of placement API https://review.openstack.org/329149 | 19:22 |
openstackgerrit | Chris Dent proposed openstack/nova: WIP Add a Usage and UsageList object https://review.openstack.org/329575 | 19:22 |
openstackgerrit | Chris Dent proposed openstack/nova: Add support for resource_providers urls https://review.openstack.org/329151 | 19:22 |
openstackgerrit | Chris Dent proposed openstack/nova: Add microversion support for the placement API https://review.openstack.org/329150 | 19:22 |
openstackgerrit | Chris Dent proposed openstack/nova: WIP experiment with the remainder of the placement API https://review.openstack.org/293104 | 19:22 |
openstackgerrit | Chris Dent proposed openstack/nova: Add support for usages in the placement API https://review.openstack.org/329643 | 19:22 |
*** jwcroppe has quit IRC | 19:22 | |
bauzas | clarkb: thanks for the tip about changing the netmask but it seems OVH doesn't like it :( | 19:23 |
clarkb | you can't change the netmask on eth0 | 19:23 |
bauzas | on br0 I did | 19:23 |
clarkb | you make a new virtual interface that nova net can talk to | 19:23 |
clarkb | then if you want external connectivity for your nova net VMs you can bridge across to eth0 | 19:23 |
bauzas | sec, maybe I'm confused | 19:24 |
bauzas | I bridged eth0 on a br0 if | 19:24 |
bauzas | br0 was either dhcp or static | 19:24 |
bauzas | tbh, my network skills are a bit not good :/ | 19:25 |
*** tonytan4ever has quit IRC | 19:25 | |
clarkb | bauzas: I would start just with br0 and no eth0 bridging | 19:26 |
clarkb | your nested VMs wont be able to internet but you can confirm everything else wO | 19:26 |
clarkb | RKs | 19:26 |
bauzas | I see | 19:26 |
bauzas | so a static br0 | 19:26 |
bauzas | that I would define | 19:27 |
bauzas | wirthout external plug | 19:27 |
clarkb | ya it doesn't even need an address or mask can just be l2 device | 19:27 |
bauzas | right | 19:27 |
*** shaohe_feng has quit IRC | 19:27 | |
bauzas | because n-net will set it | 19:27 |
bauzas | k, I can try | 19:27 |
*** shaohe_feng has joined #openstack-nova | 19:28 | |
*** rlrossit has joined #openstack-nova | 19:29 | |
*** ociuhandu has joined #openstack-nova | 19:29 | |
*** tblakeslee has joined #openstack-nova | 19:29 | |
*** tblakeslee has quit IRC | 19:29 | |
*** baoli has joined #openstack-nova | 19:31 | |
*** mriedem has quit IRC | 19:31 | |
*** stewie925 has joined #openstack-nova | 19:32 | |
*** mriedem has joined #openstack-nova | 19:34 | |
*** ijw__ has quit IRC | 19:34 | |
*** ayoung_ has joined #openstack-nova | 19:34 | |
*** shaohe_feng has quit IRC | 19:37 | |
*** shaohe_feng has joined #openstack-nova | 19:38 | |
*** lucas___ has quit IRC | 19:39 | |
*** tyrola has joined #openstack-nova | 19:40 | |
*** Sukhdev has joined #openstack-nova | 19:42 | |
*** rfolco has quit IRC | 19:43 | |
*** salv-orlando has quit IRC | 19:43 | |
*** salv-orlando has joined #openstack-nova | 19:44 | |
*** dimtruck is now known as zz_dimtruck | 19:44 | |
*** baoli has quit IRC | 19:44 | |
*** delattec has quit IRC | 19:45 | |
*** baoli has joined #openstack-nova | 19:45 | |
*** harlowja_ has joined #openstack-nova | 19:45 | |
*** derekh has quit IRC | 19:46 | |
*** ijw_ has joined #openstack-nova | 19:46 | |
*** burgerk has quit IRC | 19:46 | |
*** shaohe_feng has quit IRC | 19:48 | |
*** chandankumar has joined #openstack-nova | 19:48 | |
*** harlowja has quit IRC | 19:49 | |
*** tbachman has joined #openstack-nova | 19:49 | |
*** shaohe_feng has joined #openstack-nova | 19:50 | |
*** tbachman_ has joined #openstack-nova | 19:50 | |
*** raunak has joined #openstack-nova | 19:50 | |
*** rfolco has joined #openstack-nova | 19:50 | |
*** tyrola has quit IRC | 19:52 | |
diana_clarke | mriedem: Thanks for the one-off patch for 'flat' testing! My apologies for not responding sooner. May I rebase it so it sits on top of the patch that exercises the changes? | 19:53 |
diana_clarke | (after seeing it pass where it is first) | 19:53 |
mriedem | diana_clarke: sue | 19:54 |
mriedem | *sure | 19:54 |
*** tbachman has quit IRC | 19:54 | |
*** tbachman_ is now known as tbachman | 19:54 | |
diana_clarke | mriedem: Thanks! | 19:55 |
*** sdague has joined #openstack-nova | 19:56 | |
mriedem | dansmith: what do you think about log level for that missing keypair thing? debug or warning? | 19:56 |
*** pilgrimstack has joined #openstack-nova | 19:56 | |
dansmith | mriedem: definitely error with blinking ANSI text | 19:57 |
dansmith | mriedem: debug seems fine to me | 19:57 |
dansmith | mriedem: if we do it higher, a user can just delete a keypair and spam the logs by DoSing their metadata server | 19:57 |
*** shaohe_feng has quit IRC | 19:58 | |
mriedem | aight | 19:58 |
mriedem | the unit test was easier to write than i expected | 19:58 |
*** burgerk has joined #openstack-nova | 19:58 | |
*** shaohe_feng has joined #openstack-nova | 19:58 | |
diana_clarke | mriedem: Oh nevermind. This is in devstack (rather than nova). The answer to my next question might be in the meeting minutes from earlier. Apologies for the noise. | 19:59 |
mriedem | diana_clarke: yeah, devstack change that depends-on what i thought was the top of the refactor series as of today | 19:59 |
mriedem | btw, the test should be done running now | 20:00 |
mriedem | yeah, all green https://review.openstack.org/#/c/318262/ | 20:00 |
mriedem | and images_type=flat in nova.conf as expected http://logs.openstack.org/62/318262/2/check/gate-tempest-dsvm-full/7c43e03/logs/etc/nova/nova.conf.txt.gz | 20:00 |
*** edleafe_ has joined #openstack-nova | 20:00 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: policy: Add defaults in code (part 1) https://review.openstack.org/328850 | 20:01 |
*** tyrola has joined #openstack-nova | 20:02 | |
openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova: Improve help text for allocation_ratio_opts https://review.openstack.org/329593 | 20:02 |
*** yamahata has quit IRC | 20:05 | |
*** zz_dimtruck is now known as dimtruck | 20:06 | |
*** ducttape_ has quit IRC | 20:07 | |
*** shaohe_feng has quit IRC | 20:08 | |
diana_clarke | mriedem: that "remove max size ..." patch is sitting on top of master (but same topic). If I've understood correctly, I'll need to change the depends on to point to: https://review.openstack.org/#/c/282580/ | 20:08 |
*** ctrath has quit IRC | 20:08 | |
*** shaohe_feng has joined #openstack-nova | 20:09 | |
*** tyrola has quit IRC | 20:09 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Handle keypair not found from metadata server https://review.openstack.org/329661 | 20:09 |
mriedem | dansmith: ^ | 20:09 |
*** flwang has quit IRC | 20:10 | |
mriedem | diana_clarke: i made it point at the top of the series | 20:11 |
mriedem | which is https://review.openstack.org/#/c/326947/ | 20:11 |
mriedem | i thought anyway | 20:11 |
*** ctrath has joined #openstack-nova | 20:11 | |
mriedem | or maybe not, i get confused between same topic and related changes | 20:11 |
mriedem | diana_clarke: so you're saying https://review.openstack.org/#/c/282580/ is the top of the series we care about testing, right? if so, i can update the devstack change quick | 20:12 |
*** cdelatte has joined #openstack-nova | 20:12 | |
*** rlrossit has quit IRC | 20:12 | |
*** pilgrimstack has quit IRC | 20:12 | |
diana_clarke | mriedem: exactly, thanks! | 20:12 |
*** anush__ has quit IRC | 20:13 | |
dansmith | mriedem: -2 | 20:13 |
*** anush__ has joined #openstack-nova | 20:13 | |
mriedem | heh i knew that delattr would raise a stink | 20:13 |
dansmith | mriedem: I'm not sure how that test is passing | 20:13 |
dansmith | unless fakemetadata is being too generous or something | 20:14 |
mriedem | fake creates a fake instance obj and fake keypair obj and sets that on the instance | 20:14 |
mriedem | dansmith: the reason i didn't set an empty list was then we wouldn't hit the lazy-load code | 20:14 |
dansmith | well, you're not hitting it now | 20:15 |
mriedem | yeah i am | 20:15 |
dansmith | because you deleted the thing that does the lazy loading | 20:15 |
openstackgerrit | Julian proposed openstack/nova: WIP Add unit tests for nova.virt.firewall.IpTablesFirewallDriver (Part 2) https://review.openstack.org/325435 | 20:15 |
mriedem | that's why i mock objects.Instance.get_by_uuid | 20:15 |
mriedem | w/o that the trace for the failure was in _load_keypairs | 20:15 |
dansmith | mriedem: show me the rest of the trace then, because you deleted the @property that does the loading :) | 20:16 |
*** ducttape_ has joined #openstack-nova | 20:16 | |
*** ducttape_ has quit IRC | 20:16 | |
*** ducttape_ has joined #openstack-nova | 20:16 | |
mriedem | recreating it | 20:16 |
*** anush__ has quit IRC | 20:17 | |
*** anush__ has joined #openstack-nova | 20:17 | |
mriedem | dansmith: https://gist.github.com/mriedem/b71ca1e00503aee0d5f2bb29dc5028a6 | 20:18 |
*** cdent has quit IRC | 20:18 | |
mriedem | keypairs is an attribute on the instance object | 20:18 |
mriedem | not a @property | 20:18 |
*** shaohe_feng has quit IRC | 20:18 | |
openstackgerrit | melanie witt proposed openstack/nova: Add output of the DB calls found by DatabasePoisonFixture https://review.openstack.org/328573 | 20:19 |
*** shaohe_feng has joined #openstack-nova | 20:19 | |
dansmith | mriedem: all things in fields become @property objects on the object they're for, when we register | 20:19 |
mriedem | ok....so how do you explain that stacktrace that's in _load_keypairs? | 20:20 |
dansmith | I dunno, but go look at the first thing it's hitting in o.vo | 20:20 |
mriedem | if this is too gross, i'll just add a kwarg to fake_inst_obj to not create the keypair | 20:20 |
dansmith | the getter | 20:20 |
mriedem | i'd like to avoid looking at ovo atm | 20:20 |
dansmith | mriedem: the lazy-load behavior is not what you're testing though | 20:20 |
mriedem | i'll just modify the fake_inst_obj method to not create a keypair and set it on the test instnace | 20:20 |
dansmith | mriedem: just set instance.keypairs = KeypairList() | 20:21 |
dansmith | does fake_InstanceMetadata do something unhelpful maybe? | 20:21 |
mriedem | not really | 20:22 |
mriedem | just creates the InstanceMetadata object with the stuff you pass into that helper method, | 20:22 |
mriedem | and stub out the security group API | 20:22 |
*** anush__ has quit IRC | 20:22 | |
mriedem | i realize this test is testing more than just the unit that's changing | 20:22 |
mriedem | but i did that to actually recreate the failure | 20:23 |
mriedem | because if _load_keypairs changes for some reason, it could change the behavior of this in the metadata api | 20:24 |
dansmith | https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L64-L96 | 20:24 |
dansmith | you're deleting the thing we set on L96 | 20:24 |
dansmith | which is the thing that does the load on L67 | 20:24 |
mriedem | yeah self.obj_load_attr(name) | 20:24 |
dansmith | you can delete instance._obj_keypairs to do the thing you want, | 20:25 |
dansmith | but the fact that it's passing now makes me suspicious | 20:25 |
mriedem | idk, but i know i'm getting into obj_load_attr because: File "nova/objects/instance.py", line 971, in obj_load_attr | 20:25 |
dansmith | yep | 20:25 |
openstackgerrit | Pushkar Umaranikar proposed openstack/nova: [WIP] Improve help text for compute manager options https://review.openstack.org/329639 | 20:25 |
mriedem | i'll just update the stub helper to not set the keypair on the instance to begin with | 20:25 |
mriedem | that's cleaner to me | 20:25 |
dansmith | well, that's fine, but it's still concerning | 20:25 |
*** flwang has joined #openstack-nova | 20:26 | |
*** dmk0202 has quit IRC | 20:26 | |
dansmith | mriedem: https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L90 | 20:26 |
mriedem | brb | 20:26 |
dansmith | mriedem: I implemented delete at some point apparently | 20:26 |
dansmith | so that's why I guess :D | 20:26 |
*** dmk0202 has joined #openstack-nova | 20:26 | |
*** diogogmt has joined #openstack-nova | 20:27 | |
*** mriedem1 has joined #openstack-nova | 20:27 | |
*** jichen has quit IRC | 20:28 | |
*** shaohe_feng has quit IRC | 20:29 | |
*** shaohe_feng has joined #openstack-nova | 20:30 | |
openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Remove mox from tests/unit/objects/test_aggregate.py https://review.openstack.org/299644 | 20:30 |
*** mriedem has quit IRC | 20:30 | |
*** pradk has quit IRC | 20:31 | |
*** mriedem1 is now known as mriedem | 20:32 | |
*** dmk0202 has quit IRC | 20:33 | |
mriedem | dansmith: so i just changed the test, but now you're +2 | 20:34 |
mriedem | i guess i'll just drop that | 20:35 |
mriedem | if you're cool with delattr | 20:35 |
dansmith | mriedem: either way | 20:35 |
mriedem | i'll just leave it | 20:35 |
mriedem | smaller change that way | 20:35 |
mriedem | can we still be friends after this? | 20:36 |
mriedem | will you still come to my bday party?! | 20:36 |
*** rlrossit has joined #openstack-nova | 20:36 | |
melwitt | lol | 20:36 |
mriedem | my daughter says she won't go to someone's bday party or invite someone to her bday party if they have a falling out on any particular day | 20:37 |
mriedem | i'm going to adopt that also | 20:37 |
dansmith | heh | 20:38 |
auggy | i think that's a fair philosophy | 20:38 |
melwitt | alaski: on the instance tag valid states thing, the way I did it adds an additional db read of the instance to check the state. that can be avoided by doing the state validation in the db api layer but I guessed that wouldn't be desired | 20:38 |
*** shaohe_feng has quit IRC | 20:39 | |
auggy | are there incentives for the person to win back their birthday party invitation? | 20:39 |
auggy | ie, a pony | 20:39 |
*** mkrcmari__ has joined #openstack-nova | 20:39 | |
mriedem | auggy: they are 5 year olds, they forget about it by the next day | 20:39 |
auggy | mriedem: ah so the "birthday party invite status" would only be a daily metric ;) | 20:40 |
mriedem | typically | 20:40 |
alaski | melwitt: doing it in the db api would be more complex I think. the get() can return an "instance" that's a real instance or a BuildRequest instance, moving the state validation elsewhere would have to replicate that split | 20:41 |
mriedem | diana_clarke: https://review.openstack.org/#/c/318262/ is updated, we'll see how it does | 20:41 |
*** shaohe_feng has joined #openstack-nova | 20:42 | |
*** rfolco has quit IRC | 20:42 | |
melwitt | alaski: I didn't think about that. for all the instance tag apis there's a check in there _check_instance_exists_in_project and that's how instance could have been reused | 20:42 |
*** mvk_ has quit IRC | 20:43 | |
*** diogogmt has quit IRC | 20:43 | |
diana_clarke | mriedem: Thanks, fingers crossed. I'm currently looking into the ploop errors. | 20:44 |
melwitt | alaski: which would only work after scheduling but we need to be able to check the state before that. so I see what you mean | 20:44 |
*** pacoblox has quit IRC | 20:45 | |
*** mvk_ has joined #openstack-nova | 20:45 | |
mriedem | diana_clarke: has the -1 on https://review.openstack.org/#/c/279669/ been addressed? | 20:45 |
*** chandankumar has quit IRC | 20:45 | |
mriedem | guessing not | 20:45 |
alaski | melwitt: exactly | 20:45 |
diana_clarke | mriedem: I don't think so. | 20:46 |
dansmith | mriedem: I kinda feel like we should have some functional tests on that guy that can actually create/delete images on disk | 20:47 |
dansmith | mriedem: given how much trouble we've had with the imagecache thus far, and kinda set the stage for validating it like that going forward | 20:47 |
*** diogogmt has joined #openstack-nova | 20:48 | |
mriedem | does that require sudo? or just write to a temp dir i guess for the test | 20:48 |
*** mkrcmari__ has quit IRC | 20:48 | |
*** smatzek has quit IRC | 20:49 | |
*** shaohe_feng has quit IRC | 20:49 | |
dansmith | yeah, not if we do it in a temp location | 20:49 |
*** gagehugo has quit IRC | 20:49 | |
dansmith | anyway, biab | 20:49 |
*** mnestratov has quit IRC | 20:49 | |
*** shaohe_feng has joined #openstack-nova | 20:50 | |
mriedem | diana_clarke: any idea on how hard it would be to add a functional test for https://review.openstack.org/#/c/279669/ | 20:50 |
mriedem | ? | 20:50 |
*** edmondsw has quit IRC | 20:52 | |
*** kfarr has quit IRC | 20:53 | |
*** thorst has quit IRC | 20:54 | |
*** thorst has joined #openstack-nova | 20:55 | |
*** ayoung_ has quit IRC | 20:57 | |
*** ayoung has quit IRC | 20:57 | |
*** mvk has joined #openstack-nova | 20:58 | |
diana_clarke | mriedem: Dunno, but I'm happy to give it a shot :) I'll add it to my list. | 20:58 |
*** rtheis has quit IRC | 20:59 | |
*** thorst has quit IRC | 20:59 | |
*** shaohe_feng has quit IRC | 20:59 | |
*** anush__ has joined #openstack-nova | 20:59 | |
*** akshai has joined #openstack-nova | 20:59 | |
*** mvk_ has quit IRC | 20:59 | |
*** tbachman has quit IRC | 20:59 | |
*** eharney has quit IRC | 21:01 | |
*** shaohe_feng has joined #openstack-nova | 21:02 | |
*** ivase has quit IRC | 21:02 | |
*** anush__ has quit IRC | 21:03 | |
*** darrenc is now known as darrenc_afk | 21:03 | |
*** anush__ has joined #openstack-nova | 21:04 | |
*** fragatina has joined #openstack-nova | 21:05 | |
*** ivase has joined #openstack-nova | 21:05 | |
*** gyee has joined #openstack-nova | 21:06 | |
*** aysyd has quit IRC | 21:08 | |
openstackgerrit | melanie witt proposed openstack/nova: Add output of the DB calls found by DatabasePoisonFixture https://review.openstack.org/328573 | 21:08 |
*** _gryf has quit IRC | 21:08 | |
*** smatzek has joined #openstack-nova | 21:09 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/329679 | 21:09 |
*** _gryf has joined #openstack-nova | 21:09 | |
*** shaohe_feng has quit IRC | 21:10 | |
mriedem | this must be wrong https://github.com/openstack/nova/blob/master/nova/virt/libvirt/utils.py#L187 | 21:10 |
*** ivase has quit IRC | 21:10 | |
*** shaohe_feng has joined #openstack-nova | 21:10 | |
*** pacoblox has joined #openstack-nova | 21:11 | |
*** yamahata has joined #openstack-nova | 21:12 | |
mriedem | i guess for a functional test, we'd still have to stub out the api service and it's download method, and have a fake image registry with some test image, | 21:14 |
mriedem | and download would just copy a fake image file into place | 21:14 |
mriedem | the tricky part would be fetch_to_raw calling qemu_img_info | 21:15 |
mriedem | that would have to be stubbed out | 21:15 |
mriedem | diana_clarke: dansmith: ^ | 21:16 |
dansmith | mriedem: why tricky? the point would be to actually use that right? | 21:16 |
mriedem | we do already have a fake image service with some test images, just not sure if it supports download | 21:16 |
mriedem | dansmith: we can't call qemu-img from a functional test | 21:17 |
mriedem | it's not a devstack env | 21:17 |
dansmith | mriedem: I thought we have real libvirt in functional? | 21:17 |
mriedem | shiiiiit naw | 21:17 |
mriedem | functional is really just some running services, all external services stubbed out, db + wsgi | 21:18 |
*** woodster_ has quit IRC | 21:18 | |
dansmith | okay, I guess that's right | 21:19 |
dansmith | functional_devstack was supposed to give us that | 21:19 |
dansmith | or whatever | 21:19 |
diana_clarke | dansmith: So... I'm looking at those ploop errors (virtuozzo ci), and the traceback lines don't match the code at that particular patchset and I can't for the life of me see why. Have you seen this before? | 21:19 |
dansmith | not being able to actually use qemu-img in there makes it less useful | 21:19 |
*** shaohe_feng has quit IRC | 21:20 | |
dansmith | diana_clarke: you should talk to one of the owners | 21:20 |
*** shaohe_feng has joined #openstack-nova | 21:20 | |
openstackgerrit | Sam Betts proposed openstack/nova: Eliminate resource tracker to host manager races https://review.openstack.org/308348 | 21:20 |
dansmith | diana_clarke: from what I saw it looked like they were definitely running your code, but maybe they're doing something nefarious like pre-patching or something? | 21:21 |
diana_clarke | dansmith: I'm sure it's me, not them. And that I'm just doing something stupid. | 21:21 |
diana_clarke | dansmith: Yup, it's for sure the new code. | 21:21 |
*** smatzek has quit IRC | 21:22 | |
diana_clarke | dansmith: but the code it claims is on line 1222, I can't find. http://paste.openstack.org/show/516034/ | 21:22 |
diana_clarke | dansmith: In fact, I don't see anything with a "--hdd"... | 21:24 |
mriedem | diana_clarke: i think i know where that is, sec | 21:24 |
mriedem | i had some questions about their ci in an unrelated review for implementing resize for virtuozzo | 21:24 |
mriedem | https://review.openstack.org/#/c/182257/ | 21:24 |
mriedem | https://review.openstack.org/#/c/182257/39/nova/virt/libvirt/imagebackend.py | 21:25 |
mriedem | there is your --hdd | 21:25 |
mriedem | so they are patching the unmerged change into their CI | 21:25 |
mriedem | diana_clarke: where is your change with the results? i can check the stack log | 21:25 |
dansmith | mriedem: yikes | 21:25 |
mriedem | yeah | 21:26 |
mriedem | the thing i mentioned in their review was i didn't see extend called here at all https://review.openstack.org/#/c/182257/39/nova/virt/disk/api.py | 21:26 |
mriedem | in their ci run | 21:26 |
*** burgerk has quit IRC | 21:26 | |
mriedem | more specifically, i didn't see "Checking if we can resize image" in the n-cpu logs | 21:26 |
*** stewie925 has quit IRC | 21:29 | |
diana_clarke | Now, I'm confused... my patch is running on top of this unmerged patch? | 21:29 |
dansmith | diana_clarke: potentially, which is uncool | 21:30 |
diana_clarke | (also thanks! I was starting to feel crazy not being able to find that hdd thing) | 21:30 |
dansmith | diana_clarke: i.e. not what is supposed to be happening | 21:30 |
*** shaohe_feng has quit IRC | 21:30 | |
*** lindycod_ has quit IRC | 21:30 | |
mriedem | diana_clarke: dansmith: http://openstack-3rd-party-virtuozzo-ci-logs.virtuozzo.com/80/282580/11/check/check-dsvm-tempest-vz7-exe-minimal/9c8e3c9/logs/devstacklog.txt.gz | 21:30 |
diana_clarke | dansmith: I should have asked earlier. I spent a while on that... | 21:30 |
mriedem | search for | 21:30 |
mriedem | "2016-06-11 00:05:50.945 | 44b6772 libvirt: virtuozzo instance resize support" | 21:30 |
dansmith | ugh | 21:30 |
dansmith | uncool | 21:31 |
*** shaohe_feng has joined #openstack-nova | 21:31 | |
*** joshw42 has quit IRC | 21:31 | |
*** pacoblox has quit IRC | 21:31 | |
*** stacker has joined #openstack-nova | 21:31 | |
mriedem | the weird thing is i don't even see where that is cloned or checked out | 21:32 |
dansmith | mriedem: I suppose it's also possibly just a bug in their stuff and is patching on top of a dirty tree or something, but that seems unlikely to not be causing lots of other problems | 21:33 |
*** pacoblox has joined #openstack-nova | 21:33 | |
*** anush__ has quit IRC | 21:33 | |
*** pushkaru has quit IRC | 21:36 | |
*** pushkaru has joined #openstack-nova | 21:36 | |
openstackgerrit | Andrew Laski proposed openstack/nova: Policy-in-code servers rules https://review.openstack.org/329122 | 21:36 |
dansmith | mriedem: re: your comment on that base patch just now, I know functional doesn't run against devstack, I just thought we were able to yank in more deps for functional (i.e. I thought we didn't expect them to run in a full vacuum) | 21:37 |
mriedem | git remote set-url origin http://git.sw.ru/scm/openstack/devstack.git | 21:37 |
mriedem | they pull their own devstack | 21:38 |
*** jwcroppe has joined #openstack-nova | 21:38 | |
dansmith | wow | 21:38 |
mriedem | diana_clarke: dansmith: bingo http://openstack-3rd-party-virtuozzo-ci-logs.virtuozzo.com/80/282580/11/check/check-dsvm-tempest-vz7-exe-minimal/9c8e3c9/console.html.gz | 21:39 |
mriedem | look for 23:48:46 2016-06-10 23:48:58.872 | + [[ 282580 -ne 182257 ]] | 21:39 |
*** pradk has joined #openstack-nova | 21:39 | |
dansmith | cripes | 21:39 |
mriedem | heh | 21:39 |
*** tbachman has joined #openstack-nova | 21:39 | |
*** cdelatte has quit IRC | 21:39 | |
mriedem | i don't see mnestratov around | 21:40 |
mriedem | so i guess dev ML... | 21:40 |
dansmith | yeah | 21:40 |
mriedem | on it | 21:40 |
*** shaohe_feng has quit IRC | 21:40 | |
diana_clarke | mriedem: thanks, I really appreciate it. | 21:40 |
mriedem | np | 21:41 |
mriedem | i said i'd start reviewing that series this week, so far one patch down :) | 21:41 |
*** shaohe_feng has joined #openstack-nova | 21:41 | |
mriedem | well, one half of one patch | 21:41 |
*** Sukhdev has quit IRC | 21:46 | |
*** shaohe_feng has quit IRC | 21:51 | |
*** sileht has quit IRC | 21:51 | |
mriedem | alright, email sent to dev list | 21:51 |
*** shaohe_feng has joined #openstack-nova | 21:51 | |
mriedem | in as nice a language as possible | 21:51 |
*** sileht has joined #openstack-nova | 21:52 | |
*** mmandel has quit IRC | 21:52 | |
*** darrenc_afk is now known as darrenc | 21:54 | |
*** kylek3h has quit IRC | 21:56 | |
*** dimtruck is now known as zz_dimtruck | 21:58 | |
*** Sukhdev has joined #openstack-nova | 21:59 | |
*** shaohe_feng has quit IRC | 22:01 | |
*** shaohe_feng has joined #openstack-nova | 22:04 | |
*** burt has quit IRC | 22:05 | |
*** browne has quit IRC | 22:08 | |
*** ijw_ has quit IRC | 22:10 | |
*** rlrossit has quit IRC | 22:10 | |
*** mdrabe has quit IRC | 22:11 | |
*** shaohe_feng has quit IRC | 22:11 | |
*** mriedem is now known as mriedem_away | 22:12 | |
*** shaohe_feng has joined #openstack-nova | 22:12 | |
*** jamesdenton has quit IRC | 22:12 | |
*** Sukhdev has quit IRC | 22:14 | |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: libvirt: attach configdrive after instance XML https://review.openstack.org/303335 | 22:14 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: objects: adding an update method to virtual_interface https://review.openstack.org/310618 | 22:14 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: objects: Add devices_metadata to instance object https://review.openstack.org/327920 | 22:14 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: db: add a device_metadata column to instance_extra https://review.openstack.org/318883 | 22:14 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: Device tagging metadata API support https://review.openstack.org/304511 | 22:14 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: objects: new InstanceDevicesMetadata object https://review.openstack.org/318884 | 22:14 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: Device tagging API support https://review.openstack.org/304510 | 22:14 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: Compute manager device tagging support https://review.openstack.org/264017 | 22:14 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: Libvirt driver implementation of device tagging https://review.openstack.org/264016 | 22:14 |
*** Sukhdev has joined #openstack-nova | 22:15 | |
*** baoli has quit IRC | 22:15 | |
*** stewie925 has joined #openstack-nova | 22:15 | |
stewie925 | hi guys, I am trying to commit my changes to gerrit - I did 'git add' and set my gerrit remote correctly | 22:16 |
*** Sukhdev has quit IRC | 22:16 | |
*** akshai has quit IRC | 22:16 | |
*** Sukhdev has joined #openstack-nova | 22:17 | |
*** akshai has joined #openstack-nova | 22:17 | |
stewie925 | however, I created commit-msg using 'touch' instead of 'curl' - so I got error in 'git review' that change-id is required | 22:17 |
stewie925 | so I went back and deleted the commit-msg, and re-created it correctly using 'curl' command | 22:18 |
stewie925 | however, this time when I did 'git commit' it says there is "nothing to commit" | 22:18 |
*** jwcroppe has quit IRC | 22:20 | |
*** shaohe_feng has quit IRC | 22:21 | |
*** shaohe_feng has joined #openstack-nova | 22:22 | |
*** edleafe_ has quit IRC | 22:24 | |
*** openstackstatus has quit IRC | 22:25 | |
*** openstack has joined #openstack-nova | 22:27 | |
*** browne has joined #openstack-nova | 22:27 | |
auggy | stewie925: have you committed to openstack projects in gerrit before? | 22:27 |
stewie925 | hi auggy yes I did, quite a few times - I messed up this go round with the commit-msg creation - my bad | 22:28 |
*** rcernin has joined #openstack-nova | 22:28 | |
auggy | stewie925: ok, and you have git-review set up? | 22:28 |
stewie925 | yes I did | 22:28 |
stewie925 | so what happened is, I should have run "curl -Lo .git/hooks/commit-msg http://review.openstack.org/tools/hooks/commit-msg " when creating the commit-msg | 22:29 |
stewie925 | but I did 'touch .git/hooks/commit-msg' instead which messed things up | 22:29 |
stewie925 | so I trashed the commit-msg file and did it correctly using the "curl -Lo .git/hooks/commit-msg http://review.openstack.org/tools/hooks/commit-msg " | 22:30 |
auggy | stewie925: i don't think i've ever done my git commits that way before, are you following some docs somewhere that tell you to do it like that? | 22:30 |
*** catintheroof has quit IRC | 22:30 | |
stewie925 | oh let me try something... brb | 22:30 |
*** sameo has joined #openstack-nova | 22:30 | |
*** ctrath has quit IRC | 22:31 | |
*** shaohe_feng has quit IRC | 22:32 | |
*** rk4n has quit IRC | 22:32 | |
*** shaohe_feng has joined #openstack-nova | 22:32 | |
*** ijw_ has joined #openstack-nova | 22:36 | |
*** stewie925 has quit IRC | 22:36 | |
*** p01nt3r75 has joined #openstack-nova | 22:37 | |
*** mtanino has quit IRC | 22:38 | |
*** ccl_ has joined #openstack-nova | 22:39 | |
*** ccl_ is now known as Guest42637 | 22:39 | |
*** shaohe_feng has quit IRC | 22:42 | |
*** shaohe_feng has joined #openstack-nova | 22:43 | |
*** mtanino has joined #openstack-nova | 22:43 | |
*** ducttape_ has quit IRC | 22:43 | |
*** rk4n has joined #openstack-nova | 22:48 | |
*** rk4n has quit IRC | 22:50 | |
*** gongysh has joined #openstack-nova | 22:50 | |
*** Sukhdev has quit IRC | 22:51 | |
*** shaohe_feng has quit IRC | 22:52 | |
*** rk4n has joined #openstack-nova | 22:52 | |
*** shaohe_feng has joined #openstack-nova | 22:53 | |
*** ssurana has quit IRC | 22:54 | |
*** rk4n has quit IRC | 22:54 | |
*** stewie925 has joined #openstack-nova | 22:54 | |
stewie925 | sorry auggy, had bad internet connection | 22:54 |
stewie925 | i got to resolve the commit-msg issue | 22:54 |
auggy | stewie925: are you following some documentation that tells you to manually run curl to create the commit msg? if so, could you provide the link to it? | 22:55 |
openstackgerrit | STEW TY proposed openstack/nova: api-ref example verification for os-floating-ips https://review.openstack.org/329704 | 22:56 |
stewie925 | oh sure - let me get it | 22:57 |
stewie925 | btw I just committed my first api-ref | 22:57 |
stewie925 | example verification | 22:57 |
auggy | stewie925: so, that manual curl you're doing is done by git-review | 22:57 |
auggy | stewie925: which is why i'm curious what docs you are following that are telling you to do that | 22:58 |
*** mvk_ has joined #openstack-nova | 22:58 | |
*** JoseMello has quit IRC | 22:59 | |
*** stewie925_ has joined #openstack-nova | 23:01 | |
*** mvk has quit IRC | 23:01 | |
*** stewie925 has quit IRC | 23:02 | |
*** rk4n has joined #openstack-nova | 23:02 | |
stewie925_ | hey auggy its actually our internal documentation | 23:02 |
stewie925_ | to do that step | 23:02 |
*** shaohe_feng has quit IRC | 23:02 | |
stewie925_ | curl -Lo .git/hooks/commit-msg http://review.openstack.org/tools/hooks/commit-msg | 23:03 |
auggy | stewie925_: ah, i know some places have firewall issues, is that why? if you do "git review -s" on your branch, what happens? | 23:03 |
auggy | stewie925_: are you able to use "git review" commands without errors? | 23:03 |
stewie925_ | yeah that was my other mistake, forgot to run the -s for the git review | 23:03 |
stewie925_ | yes I have been able to fix that issue - and committed my example verification to gerrit :) | 23:04 |
stewie925_ | jsut within 10 min ago :) | 23:04 |
auggy | stewie925_: so, when you commit, you should have that hook locally and you shouldn't need to use that curl command | 23:04 |
auggy | stewie925_: when you commit, it should just put a commit id at the bottom of your commit message | 23:05 |
stewie925_ | yes that should have been automatic, right | 23:05 |
auggy | stewie925_: and then you just do "git review" and it will post your change | 23:05 |
stewie925_ | it will automatically generate the change-id | 23:05 |
auggy | stewie925_: ok, i guess i didn't understand why you were manually running that curl command | 23:05 |
*** shaohe_feng has joined #openstack-nova | 23:05 | |
*** MikeG451_ has quit IRC | 23:05 | |
stewie925_ | oh auggy, I was just following our internal document steps on committing | 23:05 |
auggy | stewie925_: alright, well it sounds like you either need to update it or stick to the official openstack developer docs ;) | 23:06 |
stewie925_ | and I missed a step :) | 23:06 |
auggy | stewie925_: if your internal docs indicate that you have additional steps, you'll probably need to get help from your colleagues as folks here won't have enough context to really help you troubleshoot that i think | 23:07 |
*** irenab_ has joined #openstack-nova | 23:07 | |
stewie925_ | thank you, auggy | 23:07 |
mtreinish | stewie925_: you might want to refer to: http://docs.openstack.org/infra/manual/developers.html#development-workflow (and update your internal doc to point to that) | 23:08 |
stewie925_ | thank you for sharing mtreinish - reviewing the doc now and bookmarked it | 23:09 |
stewie925_ | test | 23:10 |
mtreinish | stewie925_: actually this section covers the steps you were going through: http://docs.openstack.org/infra/manual/developers.html#starting-work-on-a-new-project (same doc just a different section) | 23:10 |
*** irenab has quit IRC | 23:10 | |
*** irenab_ is now known as irenab | 23:10 | |
*** jamesdenton has joined #openstack-nova | 23:12 | |
*** shaohe_feng has quit IRC | 23:13 | |
*** salv-orlando has quit IRC | 23:14 | |
*** jamesden_ has joined #openstack-nova | 23:14 | |
*** salv-orlando has joined #openstack-nova | 23:14 | |
*** shaohe_feng has joined #openstack-nova | 23:15 | |
openstackgerrit | Fei Long Wang proposed openstack/nova: Add a check before deleting compute serivce https://review.openstack.org/323633 | 23:16 |
*** ayoung has joined #openstack-nova | 23:17 | |
*** jamesdenton has quit IRC | 23:17 | |
*** hoangcx has quit IRC | 23:18 | |
*** Sukhdev has joined #openstack-nova | 23:20 | |
*** stewie925 has joined #openstack-nova | 23:21 | |
*** stewie925_ has quit IRC | 23:21 | |
*** lpetrut has quit IRC | 23:22 | |
*** akshai has quit IRC | 23:23 | |
*** shaohe_feng has quit IRC | 23:23 | |
*** shaohe_feng has joined #openstack-nova | 23:23 | |
*** BjoernT has quit IRC | 23:24 | |
*** Jeffrey4l has joined #openstack-nova | 23:29 | |
*** salv-orl_ has joined #openstack-nova | 23:29 | |
*** browne has quit IRC | 23:30 | |
*** salv-orlando has quit IRC | 23:32 | |
*** sdake has quit IRC | 23:32 | |
*** shaohe_feng has quit IRC | 23:33 | |
*** sdake has joined #openstack-nova | 23:33 | |
openstackgerrit | melanie witt proposed openstack/nova: Add instance groups tables to the API database https://review.openstack.org/329719 | 23:34 |
*** shaohe_feng has joined #openstack-nova | 23:34 | |
*** browne has joined #openstack-nova | 23:35 | |
*** rcernin has quit IRC | 23:40 | |
*** stewie925 has quit IRC | 23:41 | |
*** shaohe_feng has quit IRC | 23:43 | |
*** stewie925 has joined #openstack-nova | 23:43 | |
*** shaohe_feng has joined #openstack-nova | 23:44 | |
*** Sukhdev has quit IRC | 23:45 | |
*** lbeliveau has quit IRC | 23:46 | |
*** lbeliveau has joined #openstack-nova | 23:47 | |
*** sdague has quit IRC | 23:53 | |
*** rk4n has quit IRC | 23:53 | |
*** shaohe_feng has quit IRC | 23:54 | |
*** shaohe_feng has joined #openstack-nova | 23:54 | |
*** hoangcx has joined #openstack-nova | 23:55 | |
*** xyang1 has quit IRC | 23:56 | |
*** rk4n has joined #openstack-nova | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!