| *** shaohe_feng has quit IRC | 00:07 | |
| *** shaohe_feng has joined #openstack-nova | 00:08 | |
| *** Hosam has quit IRC | 00:10 | |
| *** ducttape_ has quit IRC | 00:14 | |
| *** shaohe_feng has quit IRC | 00:18 | |
| *** shaohe_feng has joined #openstack-nova | 00:18 | |
| *** pacoblox has joined #openstack-nova | 00:24 | |
| *** rook has joined #openstack-nova | 00:26 | |
| *** thorst has joined #openstack-nova | 00:27 | |
| *** shaohe_feng has quit IRC | 00:28 | |
| *** shaohe_feng has joined #openstack-nova | 00:29 | |
| *** raunak has quit IRC | 00:31 | |
| *** thorst has quit IRC | 00:36 | |
| *** thorst has joined #openstack-nova | 00:37 | |
| *** shaohe_feng has quit IRC | 00:38 | |
| *** tblakeslee has joined #openstack-nova | 00:39 | |
| *** shaohe_feng has joined #openstack-nova | 00:39 | |
| *** ducttape_ has joined #openstack-nova | 00:40 | |
| *** Wenzhi_ has quit IRC | 00:42 | |
| *** Wenzhi has joined #openstack-nova | 00:42 | |
| *** thorst has quit IRC | 00:44 | |
| *** pacoblox has quit IRC | 00:45 | |
| *** pacoblox has joined #openstack-nova | 00:45 | |
| *** akshai has joined #openstack-nova | 00:45 | |
| *** shaohe_feng has quit IRC | 00:48 | |
| *** shaohe_feng has joined #openstack-nova | 00:49 | |
| zehua | 司法考试的结合技术很多人看 | 00:51 |
|---|---|---|
| *** markvoelker has joined #openstack-nova | 00:51 | |
| *** raunak has joined #openstack-nova | 00:52 | |
| *** hoangcx has joined #openstack-nova | 00:54 | |
| *** markvoelker has quit IRC | 00:56 | |
| *** shaohe_feng has quit IRC | 00:59 | |
| *** tblakeslee has quit IRC | 00:59 | |
| *** shaohe_feng has joined #openstack-nova | 01:00 | |
| *** anush__ has joined #openstack-nova | 01:01 | |
| *** cheneydc has joined #openstack-nova | 01:04 | |
| *** dimtruck is now known as zz_dimtruck | 01:06 | |
| *** akshai has quit IRC | 01:06 | |
| *** shaohe_feng has quit IRC | 01:09 | |
| *** shaohe_feng has joined #openstack-nova | 01:10 | |
| *** ljxiash has joined #openstack-nova | 01:15 | |
| *** anush__ has quit IRC | 01:15 | |
| *** ducttape_ has quit IRC | 01:19 | |
| *** shaohe_feng has quit IRC | 01:19 | |
| *** jinquan has joined #openstack-nova | 01:19 | |
| *** ljxiash has quit IRC | 01:20 | |
| *** shaohe_feng has joined #openstack-nova | 01:20 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Parameter verification for os-simple-tenant-usage.inc https://review.openstack.org/333654 | 01:22 |
| *** akshai has joined #openstack-nova | 01:22 | |
| *** smatzek has joined #openstack-nova | 01:23 | |
| *** ljxiash has joined #openstack-nova | 01:23 | |
| *** pacoblox has quit IRC | 01:25 | |
| *** akshai_ has joined #openstack-nova | 01:25 | |
| *** pacoblox has joined #openstack-nova | 01:25 | |
| *** salv-orl_ has quit IRC | 01:25 | |
| *** akshai has quit IRC | 01:28 | |
| *** ljxiash has quit IRC | 01:28 | |
| *** shaohe_feng has quit IRC | 01:29 | |
| *** phuongnh has joined #openstack-nova | 01:29 | |
| *** shaohe_feng has joined #openstack-nova | 01:30 | |
| *** raunak has quit IRC | 01:30 | |
| *** pacoblox has quit IRC | 01:31 | |
| *** pacoblox has joined #openstack-nova | 01:31 | |
| *** smatzek has quit IRC | 01:32 | |
| *** raunak has joined #openstack-nova | 01:32 | |
| *** tbachman has quit IRC | 01:34 | |
| *** amotoki has joined #openstack-nova | 01:34 | |
| *** kevin_zh has joined #openstack-nova | 01:34 | |
| *** akshai has joined #openstack-nova | 01:35 | |
| *** baoli has joined #openstack-nova | 01:36 | |
| *** pacoblox has quit IRC | 01:36 | |
| *** pacoblox has joined #openstack-nova | 01:36 | |
| *** akshai_ has quit IRC | 01:38 | |
| *** shaohe_feng has quit IRC | 01:40 | |
| *** pacoblox1 has joined #openstack-nova | 01:40 | |
| *** shaohe_feng has joined #openstack-nova | 01:41 | |
| *** pacoblox has quit IRC | 01:41 | |
| *** thorst has joined #openstack-nova | 01:42 | |
| *** RuiChen has joined #openstack-nova | 01:43 | |
| *** ljxiash has joined #openstack-nova | 01:43 | |
| *** EinstCrazy has joined #openstack-nova | 01:45 | |
| *** thorst has quit IRC | 01:50 | |
| *** shaohe_feng has quit IRC | 01:50 | |
| *** smatzek has joined #openstack-nova | 01:50 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Return 400 when SecurityGroupCannotBeApplied is raised https://review.openstack.org/323332 | 01:50 |
| *** shaohe_feng has joined #openstack-nova | 01:51 | |
| *** takashin has joined #openstack-nova | 01:51 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Remove mox in test_block_device_mapping_v1.py https://review.openstack.org/308746 | 01:51 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Set 'serial' to new volume ID in swap volumes https://review.openstack.org/257135 | 01:51 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Stop using mox stubs in nova/tests/unit/virt/disk https://review.openstack.org/322778 | 01:51 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Stop using mox stubs in nova/tests/unit/cells https://review.openstack.org/323287 | 01:51 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Archive migrations table https://review.openstack.org/323684 | 01:51 |
| *** markvoelker has joined #openstack-nova | 01:52 | |
| *** mriedem has quit IRC | 01:54 | |
| *** salv-orlando has joined #openstack-nova | 01:56 | |
| *** markvoelker has quit IRC | 01:57 | |
| *** anush__ has joined #openstack-nova | 01:59 | |
| *** shaohe_feng has quit IRC | 02:00 | |
| *** shaohe_feng has joined #openstack-nova | 02:01 | |
| *** EinstCra_ has joined #openstack-nova | 02:04 | |
| *** pacoblox has joined #openstack-nova | 02:05 | |
| *** pacoblox1 has quit IRC | 02:05 | |
| *** salv-orlando has quit IRC | 02:05 | |
| *** EinstCrazy has quit IRC | 02:06 | |
| *** thorst has joined #openstack-nova | 02:08 | |
| *** pacoblox has quit IRC | 02:08 | |
| *** shaohe_feng has quit IRC | 02:10 | |
| *** pacoblox has joined #openstack-nova | 02:11 | |
| *** shaohe_feng has joined #openstack-nova | 02:11 | |
| *** thorst has quit IRC | 02:12 | |
| *** pacoblox has quit IRC | 02:13 | |
| *** thorst has joined #openstack-nova | 02:13 | |
| *** Daisy has joined #openstack-nova | 02:14 | |
| *** baoli has quit IRC | 02:14 | |
| *** anush__ has quit IRC | 02:17 | |
| *** houming has joined #openstack-nova | 02:20 | |
| *** shaohe_feng has quit IRC | 02:21 | |
| *** EinstCrazy has joined #openstack-nova | 02:21 | |
| *** smatzek has quit IRC | 02:22 | |
| *** shaohe_feng has joined #openstack-nova | 02:22 | |
| *** thorst has quit IRC | 02:22 | |
| *** baoli has joined #openstack-nova | 02:22 | |
| *** sdake_ has quit IRC | 02:23 | |
| *** EinstCra_ has quit IRC | 02:24 | |
| *** pacoblox has joined #openstack-nova | 02:24 | |
| *** jichen has joined #openstack-nova | 02:28 | |
| *** raunak has quit IRC | 02:29 | |
| *** shaohe_feng has quit IRC | 02:31 | |
| *** Daisy has quit IRC | 02:31 | |
| *** Daisy has joined #openstack-nova | 02:32 | |
| *** zz_dimtruck is now known as dimtruck | 02:32 | |
| *** shaohe_feng has joined #openstack-nova | 02:32 | |
| *** raunak has joined #openstack-nova | 02:33 | |
| *** baoli has quit IRC | 02:36 | |
| *** DaiDV has joined #openstack-nova | 02:36 | |
| *** Daisy has quit IRC | 02:36 | |
| *** gongysh has joined #openstack-nova | 02:37 | |
| *** DaiDV has quit IRC | 02:38 | |
| *** Daisy has joined #openstack-nova | 02:40 | |
| *** shaohe_feng has quit IRC | 02:41 | |
| *** shaohe_feng has joined #openstack-nova | 02:42 | |
| *** raunak has quit IRC | 02:46 | |
| *** baoli has joined #openstack-nova | 02:46 | |
| *** ducttape_ has joined #openstack-nova | 02:50 | |
| *** shaohe_feng has quit IRC | 02:51 | |
| *** pacoblox has quit IRC | 02:52 | |
| *** shaohe_feng has joined #openstack-nova | 02:52 | |
| *** markvoelker has joined #openstack-nova | 02:53 | |
| *** ducttape_ has quit IRC | 02:54 | |
| *** pacoblox has joined #openstack-nova | 02:55 | |
| *** zhangyufei has joined #openstack-nova | 02:57 | |
| *** markvoelker has quit IRC | 02:57 | |
| zhangyufei | could anyone help review this,https://review.openstack.org/#/c/317306/ | 02:58 |
| *** shaohe_feng has quit IRC | 03:02 | |
| *** salv-orlando has joined #openstack-nova | 03:02 | |
| *** shaohe_feng has joined #openstack-nova | 03:03 | |
| *** baoli has quit IRC | 03:03 | |
| *** akshai has quit IRC | 03:05 | |
| *** pacoblox has quit IRC | 03:06 | |
| *** pacoblox has joined #openstack-nova | 03:06 | |
| *** gcb has joined #openstack-nova | 03:08 | |
| *** Sukhdev has joined #openstack-nova | 03:10 | |
| *** salv-orlando has quit IRC | 03:10 | |
| *** pacoblox has quit IRC | 03:11 | |
| *** ducttape_ has joined #openstack-nova | 03:12 | |
| *** shaohe_feng has quit IRC | 03:12 | |
| *** shaohe_feng has joined #openstack-nova | 03:13 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: libvirt: Add migration support for perf event support https://review.openstack.org/329339 | 03:15 |
| *** akshai has joined #openstack-nova | 03:20 | |
| *** thorst has joined #openstack-nova | 03:22 | |
| *** shaohe_feng has quit IRC | 03:22 | |
| *** shaohe_feng has joined #openstack-nova | 03:23 | |
| *** Jeffrey4l_ has quit IRC | 03:23 | |
| *** chenfei has quit IRC | 03:24 | |
| *** robcresswell has quit IRC | 03:24 | |
| *** chenfei has joined #openstack-nova | 03:26 | |
| *** robcresswell has joined #openstack-nova | 03:27 | |
| *** thorst has quit IRC | 03:27 | |
| *** zhangyufei has quit IRC | 03:29 | |
| *** shaohe_feng has quit IRC | 03:32 | |
| *** zerda2 has joined #openstack-nova | 03:33 | |
| *** shaohe_feng has joined #openstack-nova | 03:33 | |
| *** tbachman has joined #openstack-nova | 03:34 | |
| *** pacoblox has joined #openstack-nova | 03:34 | |
| *** zhangyufei has joined #openstack-nova | 03:35 | |
| *** Jeffrey4l_ has joined #openstack-nova | 03:36 | |
| *** ljxiash has quit IRC | 03:38 | |
| *** ljxiash has joined #openstack-nova | 03:39 | |
| *** Daisy has quit IRC | 03:40 | |
| *** pacoblox1 has joined #openstack-nova | 03:40 | |
| *** pacoblox has quit IRC | 03:40 | |
| *** Daisy has joined #openstack-nova | 03:40 | |
| *** sacharya has joined #openstack-nova | 03:41 | |
| *** shaohe_feng has quit IRC | 03:43 | |
| *** ljxiash has quit IRC | 03:43 | |
| *** shaohe_feng has joined #openstack-nova | 03:43 | |
| *** Daisy has quit IRC | 03:45 | |
| *** pacoblox has joined #openstack-nova | 03:46 | |
| *** pacoblox1 has quit IRC | 03:46 | |
| *** jwcroppe has joined #openstack-nova | 03:49 | |
| *** shaohe_feng has quit IRC | 03:53 | |
| *** shaohe_feng has joined #openstack-nova | 03:53 | |
| *** markvoelker has joined #openstack-nova | 03:54 | |
| *** ducttape_ has quit IRC | 03:56 | |
| *** nkrinner_afk is now known as nkrinner | 03:56 | |
| *** markvoelker has quit IRC | 03:58 | |
| *** pacoblox has quit IRC | 03:59 | |
| *** pacoblox has joined #openstack-nova | 03:59 | |
| *** Jeffrey4l_ has quit IRC | 04:00 | |
| *** dimtruck is now known as zz_dimtruck | 04:02 | |
| *** zz_dimtruck is now known as dimtruck | 04:03 | |
| *** shaohe_feng has quit IRC | 04:03 | |
| *** shaohe_feng has joined #openstack-nova | 04:04 | |
| *** pacoblox1 has joined #openstack-nova | 04:06 | |
| *** pacoblox has quit IRC | 04:06 | |
| *** salv-orlando has joined #openstack-nova | 04:07 | |
| *** akshai has quit IRC | 04:09 | |
| *** Jeffrey4l_ has joined #openstack-nova | 04:09 | |
| *** Daisy has joined #openstack-nova | 04:10 | |
| *** shaohe_feng has quit IRC | 04:13 | |
| *** shaohe_feng has joined #openstack-nova | 04:14 | |
| *** Daisy has quit IRC | 04:15 | |
| *** links has joined #openstack-nova | 04:15 | |
| *** salv-orlando has quit IRC | 04:15 | |
| *** ljxiash has joined #openstack-nova | 04:16 | |
| *** pacoblox1 has quit IRC | 04:18 | |
| *** Jeffrey4l_ has quit IRC | 04:21 | |
| *** ljxiash has quit IRC | 04:21 | |
| *** tbachman has quit IRC | 04:22 | |
| *** shaohe_feng has quit IRC | 04:24 | |
| *** shaohe_feng has joined #openstack-nova | 04:24 | |
| *** thorst has joined #openstack-nova | 04:25 | |
| *** amotoki has quit IRC | 04:27 | |
| *** ljxiash has joined #openstack-nova | 04:28 | |
| *** thorst has quit IRC | 04:32 | |
| *** shaohe_feng has quit IRC | 04:34 | |
| *** shaohe_feng has joined #openstack-nova | 04:35 | |
| *** amotoki has joined #openstack-nova | 04:36 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs: Enable cold migration with target host https://review.openstack.org/334286 | 04:37 |
| *** Jeffrey4l_ has joined #openstack-nova | 04:39 | |
| *** salv-orlando has joined #openstack-nova | 04:42 | |
| *** shaohe_feng has quit IRC | 04:44 | |
| *** amotoki has quit IRC | 04:44 | |
| *** shaohe_feng has joined #openstack-nova | 04:45 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs: Enable cold migration with target host https://review.openstack.org/334286 | 04:45 |
| openstackgerrit | Dao Cong Tien proposed openstack/nova: [WIP] Ironic Driver: override get_serial_console() https://review.openstack.org/328157 | 04:48 |
| *** salv-orlando has quit IRC | 04:50 | |
| *** shaohe_feng has quit IRC | 04:54 | |
| *** markvoelker has joined #openstack-nova | 04:54 | |
| *** shaohe_feng has joined #openstack-nova | 04:55 | |
| *** markvoelker has quit IRC | 04:59 | |
| *** irenab has quit IRC | 05:00 | |
| *** amotoki has joined #openstack-nova | 05:02 | |
| *** shaohe_feng has quit IRC | 05:05 | |
| *** shaohe_feng has joined #openstack-nova | 05:05 | |
| *** dimtruck is now known as zz_dimtruck | 05:06 | |
| *** ducttape_ has joined #openstack-nova | 05:07 | |
| *** Daisy has joined #openstack-nova | 05:07 | |
| *** ducttape_ has quit IRC | 05:12 | |
| *** shaohe_feng has quit IRC | 05:15 | |
| *** gcb has quit IRC | 05:15 | |
| *** shaohe_feng has joined #openstack-nova | 05:15 | |
| *** yamahata has quit IRC | 05:17 | |
| *** yamahata has joined #openstack-nova | 05:18 | |
| *** kevin_zh has quit IRC | 05:21 | |
| *** kevin_zh has joined #openstack-nova | 05:21 | |
| *** shaohe_feng has quit IRC | 05:25 | |
| *** shaohe_feng has joined #openstack-nova | 05:26 | |
| *** imcsk8 has quit IRC | 05:26 | |
| *** Daisy has quit IRC | 05:26 | |
| *** Daisy has joined #openstack-nova | 05:27 | |
| *** gcb has joined #openstack-nova | 05:28 | |
| *** chandankumar has joined #openstack-nova | 05:28 | |
| *** thorst has joined #openstack-nova | 05:29 | |
| *** ratailor has joined #openstack-nova | 05:29 | |
| *** edand has joined #openstack-nova | 05:31 | |
| *** jwcroppe has quit IRC | 05:31 | |
| *** jwcroppe has joined #openstack-nova | 05:32 | |
| *** Daisy_ has joined #openstack-nova | 05:32 | |
| *** imcsk8 has joined #openstack-nova | 05:34 | |
| *** shaohe_feng has quit IRC | 05:35 | |
| *** thorst has quit IRC | 05:36 | |
| *** shaohe_feng has joined #openstack-nova | 05:36 | |
| *** Daisy has quit IRC | 05:36 | |
| *** mariusv has quit IRC | 05:36 | |
| *** lunarlamp is now known as mariusv | 05:36 | |
| openstackgerrit | Kien Nguyen proposed openstack/nova: Remove mox from nova/tests/unit/cells/test_cells_manager.py(2) https://review.openstack.org/334185 | 05:36 |
| *** jwcroppe has quit IRC | 05:36 | |
| *** klkumar has joined #openstack-nova | 05:37 | |
| *** salv-orlando has joined #openstack-nova | 05:38 | |
| openstackgerrit | Kien Nguyen proposed openstack/nova: Remove mox from nova/tests/unit/cells/test_cells_manager.py https://review.openstack.org/334184 | 05:40 |
| openstackgerrit | Kien Nguyen proposed openstack/nova: Remove mox from nova/tests/unit/cells/test_cells_manager.py(3) https://review.openstack.org/334186 | 05:40 |
| *** fragatina has joined #openstack-nova | 05:40 | |
| *** fragatina has quit IRC | 05:40 | |
| openstackgerrit | Kien Nguyen proposed openstack/nova: Remove mox from nova/tests/unit/cells/test_cells_manager.py(4) https://review.openstack.org/334187 | 05:41 |
| *** fragatina has joined #openstack-nova | 05:41 | |
| openstackgerrit | Kien Nguyen proposed openstack/nova: Remove mox from nova/tests/unit/cells/test_cells_manager.py(5) https://review.openstack.org/334189 | 05:42 |
| openstackgerrit | Kien Nguyen proposed openstack/nova: Remove mox from nova/tests/unit/cells/test_cells_manager.py(6) https://review.openstack.org/334232 | 05:43 |
| *** mariusv has quit IRC | 05:43 | |
| openstackgerrit | Kien Nguyen proposed openstack/nova: Remove mox from nova/tests/unit/cells/test_cells_manager.py(2) https://review.openstack.org/334185 | 05:43 |
| openstackgerrit | Kien Nguyen proposed openstack/nova: Remove mox from nova/tests/unit/cells/test_cells_manager.py(3) https://review.openstack.org/334186 | 05:44 |
| openstackgerrit | Kien Nguyen proposed openstack/nova: Remove mox from nova/tests/unit/cells/test_cells_manager.py(5) https://review.openstack.org/334189 | 05:44 |
| openstackgerrit | Kien Nguyen proposed openstack/nova: Remove mox from nova/tests/unit/cells/test_cells_manager.py(6) https://review.openstack.org/334232 | 05:45 |
| *** shaohe_feng has quit IRC | 05:46 | |
| *** masayukig has quit IRC | 05:46 | |
| *** masayukig_ has joined #openstack-nova | 05:46 | |
| *** shaohe_feng has joined #openstack-nova | 05:47 | |
| *** diga has joined #openstack-nova | 05:47 | |
| openstackgerrit | Kien Nguyen proposed openstack/nova: Remove mox from nova/tests/unit/cells/test_cells_manager.py(2) https://review.openstack.org/334185 | 05:48 |
| *** mfedosin has joined #openstack-nova | 05:48 | |
| *** mariusv has joined #openstack-nova | 05:50 | |
| *** mariusv has quit IRC | 05:51 | |
| *** gcb has quit IRC | 05:52 | |
| *** markvoelker has joined #openstack-nova | 05:55 | |
| openstackgerrit | Kien Nguyen proposed openstack/nova: Remove mox from nova/tests/unit/cells/test_cells_manager.py(4) https://review.openstack.org/334187 | 05:55 |
| *** shaohe_feng has quit IRC | 05:56 | |
| *** kylek3h has joined #openstack-nova | 05:56 | |
| *** shaohe_feng has joined #openstack-nova | 05:57 | |
| openstackgerrit | Kien Nguyen proposed openstack/nova: Remove mox from nova/tests/unit/cells/test_cells_manager.py https://review.openstack.org/334184 | 05:58 |
| *** EinstCrazy has quit IRC | 05:59 | |
| *** markvoelker has quit IRC | 06:00 | |
| *** edand has quit IRC | 06:01 | |
| *** kylek3h has quit IRC | 06:01 | |
| openstackgerrit | Kien Nguyen proposed openstack/nova: Remove mox from nova/tests/unit/cells/test_cells_manager.py(2) https://review.openstack.org/334185 | 06:05 |
| *** shaohe_feng has quit IRC | 06:06 | |
| *** sudipto has joined #openstack-nova | 06:07 | |
| *** ducttape_ has joined #openstack-nova | 06:08 | |
| *** shaohe_feng has joined #openstack-nova | 06:09 | |
| openstackgerrit | Kien Nguyen proposed openstack/nova: Remove mox in nova/tests/unit/api/openstack/compute (1) https://review.openstack.org/334297 | 06:10 |
| *** amotoki has quit IRC | 06:10 | |
| *** gcb has joined #openstack-nova | 06:11 | |
| *** ducttape_ has quit IRC | 06:12 | |
| openstackgerrit | Kien Nguyen proposed openstack/nova: Remove mox from nova/tests/unit/cells/test_cells_manager.py(3) https://review.openstack.org/334186 | 06:13 |
| *** amotoki has joined #openstack-nova | 06:13 | |
| openstackgerrit | Kien Nguyen proposed openstack/nova: Remove mox from nova/tests/unit/cells/test_cells_manager.py(4) https://review.openstack.org/334187 | 06:15 |
| *** shaohe_feng has quit IRC | 06:16 | |
| *** shaohe_feng has joined #openstack-nova | 06:17 | |
| openstackgerrit | Kien Nguyen proposed openstack/nova: Remove mox in nova/tests/unit/api/openstack/compute (1) https://review.openstack.org/334297 | 06:18 |
| *** Daisy_ has quit IRC | 06:19 | |
| *** Daisy has joined #openstack-nova | 06:20 | |
| *** mjura has joined #openstack-nova | 06:21 | |
| *** EinstCrazy has joined #openstack-nova | 06:24 | |
| *** Sukhdev has quit IRC | 06:25 | |
| *** hieulq has joined #openstack-nova | 06:26 | |
| *** shaohe_feng has quit IRC | 06:27 | |
| openstackgerrit | Li Yingjun proposed openstack/nova: Microversion 2.31 adds pagination support for hypervisors https://review.openstack.org/326940 | 06:27 |
| *** shaohe_feng has joined #openstack-nova | 06:27 | |
| *** rcernin has joined #openstack-nova | 06:27 | |
| *** mjura has quit IRC | 06:28 | |
| *** liverpooler has joined #openstack-nova | 06:28 | |
| *** zerda2 has quit IRC | 06:29 | |
| *** zerda2 has joined #openstack-nova | 06:30 | |
| *** zerda2 has quit IRC | 06:30 | |
| *** M00nr41n has joined #openstack-nova | 06:33 | |
| *** andreas_s has joined #openstack-nova | 06:33 | |
| *** jwcroppe has joined #openstack-nova | 06:33 | |
| *** thorst has joined #openstack-nova | 06:34 | |
| *** shaohe_feng has quit IRC | 06:37 | |
| *** pbandark has joined #openstack-nova | 06:38 | |
| *** shaohe_feng has joined #openstack-nova | 06:38 | |
| *** jwcroppe has quit IRC | 06:40 | |
| *** mpavone has joined #openstack-nova | 06:40 | |
| *** pcaruana has joined #openstack-nova | 06:41 | |
| *** mjura has joined #openstack-nova | 06:41 | |
| *** thorst has quit IRC | 06:41 | |
| *** moshele has joined #openstack-nova | 06:42 | |
| *** Daisy_ has joined #openstack-nova | 06:43 | |
| *** sthillma has joined #openstack-nova | 06:44 | |
| *** EinstCrazy has quit IRC | 06:44 | |
| *** Daisy has quit IRC | 06:46 | |
| *** shaohe_feng has quit IRC | 06:47 | |
| *** sthillma has quit IRC | 06:48 | |
| *** zz_dimtruck is now known as dimtruck | 06:49 | |
| *** shaohe_feng has joined #openstack-nova | 06:50 | |
| *** jlanoux has joined #openstack-nova | 06:53 | |
| *** ashokt has joined #openstack-nova | 06:53 | |
| *** gcb has quit IRC | 06:53 | |
| *** zhangjn has quit IRC | 06:54 | |
| *** zhangjn has joined #openstack-nova | 06:54 | |
| *** sacharya has quit IRC | 06:55 | |
| *** markvoelker has joined #openstack-nova | 06:56 | |
| *** EinstCrazy has joined #openstack-nova | 06:56 | |
| *** lpetrut has joined #openstack-nova | 06:57 | |
| *** shaohe_feng has quit IRC | 06:57 | |
| *** shaohe_feng has joined #openstack-nova | 06:58 | |
| *** amotoki has quit IRC | 06:58 | |
| *** tesseract- has joined #openstack-nova | 06:59 | |
| *** markvoelker has quit IRC | 07:01 | |
| *** jamielennox is now known as jamielennox|away | 07:01 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Allow monitor plugins to set own metric object https://review.openstack.org/270341 | 07:03 |
| *** ttx has quit IRC | 07:03 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 07:03 |
| *** ttx has joined #openstack-nova | 07:04 | |
| *** gcb has joined #openstack-nova | 07:05 | |
| *** yamahata has quit IRC | 07:06 | |
| *** shaohe_feng has quit IRC | 07:08 | |
| *** shaohe_feng has joined #openstack-nova | 07:08 | |
| *** ducttape_ has joined #openstack-nova | 07:09 | |
| *** manikanta has quit IRC | 07:09 | |
| *** belmoreira has joined #openstack-nova | 07:09 | |
| *** gcb has quit IRC | 07:11 | |
| *** jed56 has joined #openstack-nova | 07:11 | |
| *** ihrachys has joined #openstack-nova | 07:12 | |
| *** sheel has joined #openstack-nova | 07:12 | |
| *** prateek has joined #openstack-nova | 07:14 | |
| *** ducttape_ has quit IRC | 07:14 | |
| openstackgerrit | zhufl proposed openstack/nova: Remove unnecessary __init__ https://review.openstack.org/334310 | 07:14 |
| *** fishcried1 has joined #openstack-nova | 07:17 | |
| *** fishcried1 has quit IRC | 07:18 | |
| *** shaohe_feng has quit IRC | 07:18 | |
| *** shaohe_feng has joined #openstack-nova | 07:19 | |
| *** muawiakhan has joined #openstack-nova | 07:21 | |
| *** amotoki has joined #openstack-nova | 07:22 | |
| *** zerda2 has joined #openstack-nova | 07:23 | |
| *** Oku_OS-away is now known as Oku_OS | 07:28 | |
| *** shaohe_feng has quit IRC | 07:28 | |
| *** amotoki has quit IRC | 07:28 | |
| *** gcb has joined #openstack-nova | 07:29 | |
| *** lpetrut has quit IRC | 07:29 | |
| *** shaohe_feng has joined #openstack-nova | 07:29 | |
| *** dmk0202 has joined #openstack-nova | 07:31 | |
| *** pacoblox has joined #openstack-nova | 07:31 | |
| *** masayukig_ is now known as masayukig | 07:33 | |
| *** ljxiash has quit IRC | 07:35 | |
| *** ljxiash has joined #openstack-nova | 07:36 | |
| *** pacoblox has quit IRC | 07:36 | |
| *** jwcroppe has joined #openstack-nova | 07:37 | |
| *** sahid has joined #openstack-nova | 07:37 | |
| *** oanson has joined #openstack-nova | 07:38 | |
| *** shaohe_feng has quit IRC | 07:38 | |
| *** amotoki has joined #openstack-nova | 07:39 | |
| *** shaohe_feng has joined #openstack-nova | 07:39 | |
| *** thorst has joined #openstack-nova | 07:40 | |
| *** ljxiash has quit IRC | 07:40 | |
| *** jwcroppe has quit IRC | 07:42 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata https://review.openstack.org/331996 | 07:46 |
| *** thorst has quit IRC | 07:46 | |
| *** danpb has joined #openstack-nova | 07:47 | |
| *** lpetrut has joined #openstack-nova | 07:48 | |
| *** zhangyufei has quit IRC | 07:48 | |
| *** kevinzh has joined #openstack-nova | 07:49 | |
| *** shaohe_feng has quit IRC | 07:49 | |
| *** shaohe_feng has joined #openstack-nova | 07:49 | |
| *** kevinzs has joined #openstack-nova | 07:50 | |
| *** kevin_zh has quit IRC | 07:50 | |
| *** pilgrimstack has joined #openstack-nova | 07:50 | |
| *** zhangyufei has joined #openstack-nova | 07:50 | |
| *** zenoway has joined #openstack-nova | 07:51 | |
| *** kevinzs is now known as kevin_zh | 07:52 | |
| *** kevinzh has quit IRC | 07:54 | |
| *** markus_z has joined #openstack-nova | 07:55 | |
| *** sacharya has joined #openstack-nova | 07:56 | |
| *** permalac has joined #openstack-nova | 07:56 | |
| *** irenab has joined #openstack-nova | 07:58 | |
| *** shaohe_feng has quit IRC | 07:59 | |
| *** shaohe_feng has joined #openstack-nova | 07:59 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** sacharya has quit IRC | 08:01 | |
| *** lpetrut has quit IRC | 08:01 | |
| *** zzzeek has joined #openstack-nova | 08:02 | |
| *** lucas-afk is now known as lucasagomes | 08:02 | |
| *** Qiming has quit IRC | 08:03 | |
| *** salv-orlando has quit IRC | 08:04 | |
| *** ljxiash has joined #openstack-nova | 08:04 | |
| *** jlanoux has quit IRC | 08:05 | |
| *** Qiming has joined #openstack-nova | 08:06 | |
| *** nicolasbock has quit IRC | 08:07 | |
| *** sameo has joined #openstack-nova | 08:09 | |
| *** roeyc has joined #openstack-nova | 08:09 | |
| *** shaohe_feng has quit IRC | 08:09 | |
| *** nicolasbock has joined #openstack-nova | 08:09 | |
| *** ducttape_ has joined #openstack-nova | 08:10 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/303345 | 08:10 |
| *** shaohe_feng has joined #openstack-nova | 08:10 | |
| *** Hosam has joined #openstack-nova | 08:10 | |
| *** rpodolyaka_pto is now known as rpodolyaka | 08:12 | |
| *** Kevin_Zheng has quit IRC | 08:13 | |
| *** RuiChen has quit IRC | 08:13 | |
| *** haypo has joined #openstack-nova | 08:14 | |
| *** ducttape_ has quit IRC | 08:16 | |
| *** nicolasbock has quit IRC | 08:17 | |
| *** itamarl has joined #openstack-nova | 08:17 | |
| markus_z | danpb: Would you help me to clarify your comment at https://review.openstack.org/#/c/323765/8/nova/virt/libvirt/driver.py@2675 please? | 08:19 |
| markus_z | danpb: I assume you're talking about the complete "flush pty" code block | 08:19 |
| *** shaohe_feng has quit IRC | 08:19 | |
| markus_z | danpb: But want to double-check before I push a new ps. | 08:20 |
| *** shaohe_feng has joined #openstack-nova | 08:20 | |
| danpb | markus_z: well essentially I'm saying that you should not have 2 separate codepaths for any of this | 08:21 |
| danpb | we should have the same filename (console.log) in all cases, and we can simply blindly look for it and not bother parsing the xml | 08:22 |
| danpb | because we know it should exists for all vms | 08:22 |
| markus_z | agreed, I've changed that already locally | 08:22 |
| danpb | that code at 2675 is only there so you can raise ConsoleNotAvailable if there's no console found in the XML | 08:23 |
| *** nicolasbock has joined #openstack-nova | 08:23 | |
| danpb | i'm saying that's pointlessly complicated, as we could simply raise ConsoleNotAvailable if console.log file does not exist, and thus ignore XML parsing entirely | 08:24 |
| *** zhangyufei has quit IRC | 08:24 | |
| markus_z | I did understand it a little differently. In line 2680 the pty device is flushed into the "console.log" file, that's what the code is looking for in line 2668-2675 | 08:25 |
| *** salv-orlando has joined #openstack-nova | 08:25 | |
| sudipto | bauzas, hi, thanks for the review of https://review.openstack.org/#/c/270341/, i have added the release note per your discretion, could you please take a look at it sometime? Thanks. | 08:25 |
| markus_z | Are you suggesting to get rid of the flushing? | 08:25 |
| danpb | hmm, not noticed that before, but it looks totally insane | 08:28 |
| markus_z | to be honest, I'm not really sure if that piece of code ever gets executed | 08:28 |
| danpb | i'm struggling to imagine wtf.com it was thought running dd like that would do | 08:30 |
| *** shaohe_feng has quit IRC | 08:30 | |
| danpb | i suggest just deleting that bit of code in a prior patch | 08:30 |
| *** shaohe_feng has joined #openstack-nova | 08:30 | |
| openstackgerrit | zhufl proposed openstack/nova: Remove unused LOG https://review.openstack.org/334345 | 08:31 |
| danpb | it seems to date back to earliest ever days of nova and was added in a3d003d7ec92f3ae23a667954a790c71efdbfdbe with no explanation or justification of why it was needed | 08:31 |
| markus_z | danpb: wow, that's old. :/ | 08:32 |
| markus_z | danpb: OK, I'm going to put a change in the middle which gets rid of this. | 08:33 |
| danpb | ok | 08:33 |
| markus_z | danpb: thanks for having a look at this | 08:33 |
| *** phuongnh has quit IRC | 08:34 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Introduce the memory bandwidth monitor https://review.openstack.org/329783 | 08:35 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Introduce utility module for pcp https://review.openstack.org/203163 | 08:35 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Allow monitor plugins to set own metric object https://review.openstack.org/270341 | 08:35 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor https://review.openstack.org/266773 | 08:35 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Update setup.cfg for memory bandwidth monitor https://review.openstack.org/329785 | 08:35 |
| *** hieulq has quit IRC | 08:36 | |
| *** derekh has joined #openstack-nova | 08:36 | |
| sudipto | Hi, I have all the code up for adding the memory-bw monitor to nova ^^, can I please get some core reviews! Thanks in advance! | 08:37 |
| *** zhangyufei has joined #openstack-nova | 08:38 | |
| *** jwcroppe has joined #openstack-nova | 08:38 | |
| *** fawadkhaliq has joined #openstack-nova | 08:39 | |
| openstackgerrit | John Hua proposed openstack/nova: POC: WIP: XenAPI: device tagging https://review.openstack.org/333781 | 08:40 |
| *** shaohe_feng has quit IRC | 08:40 | |
| *** shaohe_feng has joined #openstack-nova | 08:41 | |
| BobBall | danpb: Any chance you could look at the patch (https://review.openstack.org/#/c/251271/) for the spec you reviewed? As a reminder, it's adding a bridge so security groups can be applied when using OVSHybridIptablesFirewallDriver following the same pattern as libvirt. | 08:41 |
| openstackgerrit | John Hua proposed openstack/nova: POC: WIP: XenAPI: device tagging https://review.openstack.org/333781 | 08:42 |
| *** RuiChen has joined #openstack-nova | 08:42 | |
| *** jwcroppe has quit IRC | 08:43 | |
| *** thorst has joined #openstack-nova | 08:44 | |
| danpb | BobBall: ok | 08:46 |
| BobBall | Awesome, thanks. | 08:47 |
| openstackgerrit | Song Dan Dan proposed openstack/nova: api-ref: correct the order of APIs in server-tags https://review.openstack.org/334353 | 08:48 |
| *** yassine__ has joined #openstack-nova | 08:49 | |
| *** hieulq has joined #openstack-nova | 08:50 | |
| *** muawiakhan has quit IRC | 08:50 | |
| *** muawiakhan has joined #openstack-nova | 08:50 | |
| *** shaohe_feng has quit IRC | 08:50 | |
| *** shaohe_feng has joined #openstack-nova | 08:51 | |
| *** thorst has quit IRC | 08:52 | |
| *** sacharya has joined #openstack-nova | 08:57 | |
| *** lpetrut has joined #openstack-nova | 08:58 | |
| *** lchen_ has quit IRC | 08:59 | |
| *** hoangcx has quit IRC | 09:00 | |
| *** shaohe_feng has quit IRC | 09:00 | |
| *** shaohe_feng has joined #openstack-nova | 09:01 | |
| *** sacharya has quit IRC | 09:01 | |
| *** hshiina has joined #openstack-nova | 09:02 | |
| *** lchen_ has joined #openstack-nova | 09:05 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Allow monitor plugins to set own metric object https://review.openstack.org/270341 | 09:09 |
| *** shaohe_feng has quit IRC | 09:11 | |
| *** hieulq has quit IRC | 09:11 | |
| *** shaohe_feng has joined #openstack-nova | 09:11 | |
| *** ducttape_ has joined #openstack-nova | 09:12 | |
| *** sambetts|afk is now known as sambetts | 09:13 | |
| openstackgerrit | Li Yingjun proposed openstack/nova: Microversion 2.32 adds pagination support for hypervisors https://review.openstack.org/326940 | 09:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/python-novaclient: DNM: Check if gate still works https://review.openstack.org/334363 | 09:14 |
| *** sheel has quit IRC | 09:15 | |
| *** ducttape_ has quit IRC | 09:17 | |
| *** hieulq has joined #openstack-nova | 09:19 | |
| *** lchen_ has quit IRC | 09:21 | |
| *** shaohe_feng has quit IRC | 09:21 | |
| *** shaohe_feng has joined #openstack-nova | 09:22 | |
| *** lchen_ has joined #openstack-nova | 09:23 | |
| *** Daisy_ has quit IRC | 09:23 | |
| *** Daisy has joined #openstack-nova | 09:24 | |
| *** amotoki has quit IRC | 09:24 | |
| *** amotoki has joined #openstack-nova | 09:25 | |
| *** amotoki has quit IRC | 09:25 | |
| *** jamielennox|away is now known as jamielennox | 09:26 | |
| *** Kevin_Zheng has joined #openstack-nova | 09:27 | |
| *** shaohe_feng has quit IRC | 09:31 | |
| *** shaohe_feng has joined #openstack-nova | 09:32 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Transform instance.update notification https://review.openstack.org/325923 | 09:32 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Pre-add instance actions to avoid merge conflicts https://review.openstack.org/334368 | 09:32 |
| *** Daisy_ has joined #openstack-nova | 09:33 | |
| *** lixiaoy1_ has quit IRC | 09:33 | |
| *** kylek3h has joined #openstack-nova | 09:33 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Pre-add instance actions to avoid merge conflicts https://review.openstack.org/330513 | 09:34 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Transform instance.update notification https://review.openstack.org/325923 | 09:34 |
| *** lixiaoy1 has joined #openstack-nova | 09:35 | |
| *** Daisy has quit IRC | 09:36 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: hyper-v: device tagging https://review.openstack.org/331889 | 09:36 |
| *** ljxiash has quit IRC | 09:37 | |
| *** ljxiash has joined #openstack-nova | 09:37 | |
| *** claudiub has joined #openstack-nova | 09:37 | |
| *** sameo has quit IRC | 09:38 | |
| *** kylek3h has quit IRC | 09:38 | |
| *** Daisy_ has quit IRC | 09:39 | |
| *** Daisy has joined #openstack-nova | 09:39 | |
| *** jwcroppe has joined #openstack-nova | 09:39 | |
| *** abalutoiu has joined #openstack-nova | 09:40 | |
| *** shaohe_feng has quit IRC | 09:41 | |
| openstackgerrit | Yang Shengming proposed openstack/nova: prevent resize down with ceph backend in libvirt driver https://review.openstack.org/325708 | 09:42 |
| *** lixiaoy1 has quit IRC | 09:42 | |
| *** shaohe_feng has joined #openstack-nova | 09:43 | |
| *** dimtruck is now known as zz_dimtruck | 09:43 | |
| *** Daisy has quit IRC | 09:44 | |
| *** lixiaoy1 has joined #openstack-nova | 09:44 | |
| *** mdavidson has joined #openstack-nova | 09:44 | |
| *** jwcroppe has quit IRC | 09:44 | |
| *** ljxiash has quit IRC | 09:44 | |
| *** Daisy has joined #openstack-nova | 09:44 | |
| openstackgerrit | Dao Cong Tien proposed openstack/nova: Remove mox from api/openstack/compute/test_console_auth_tokens.py https://review.openstack.org/321435 | 09:45 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Add swap volume notifications (start, end) https://review.openstack.org/250283 | 09:46 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Add swap volume notifications (error) https://review.openstack.org/328055 | 09:48 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Add swap volume notifications samples https://review.openstack.org/328866 | 09:48 |
| *** Daisy has quit IRC | 09:49 | |
| *** thorst has joined #openstack-nova | 09:49 | |
| *** aspiers has left #openstack-nova | 09:49 | |
| *** chandankumar has quit IRC | 09:50 | |
| *** shaohe_feng has quit IRC | 09:52 | |
| *** tyrola has joined #openstack-nova | 09:52 | |
| *** shaohe_feng has joined #openstack-nova | 09:52 | |
| *** thorst has quit IRC | 09:57 | |
| *** shaohe_feng has quit IRC | 10:02 | |
| *** shaohe_feng has joined #openstack-nova | 10:03 | |
| *** amotoki has joined #openstack-nova | 10:06 | |
| *** cheneydc has quit IRC | 10:06 | |
| openstackgerrit | Andrea Rosa proposed openstack/nova: Enabling detach root volume for shelved_offloaded https://review.openstack.org/326899 | 10:06 |
| openstackgerrit | Andrea Rosa proposed openstack/nova: Attach/detach root volume for shelved_offloaded https://review.openstack.org/317446 | 10:06 |
| openstackgerrit | Andrea Rosa proposed openstack/nova: Adding device_present field to bdm table https://review.openstack.org/268053 | 10:06 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Introduce utility module for pcp https://review.openstack.org/203163 | 10:08 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor https://review.openstack.org/266773 | 10:11 |
| openstackgerrit | Radoslav Gerganov proposed openstack/python-novaclient: Add support for microversion 2.31 https://review.openstack.org/334390 | 10:12 |
| *** shaohe_feng has quit IRC | 10:12 | |
| *** ducttape_ has joined #openstack-nova | 10:13 | |
| *** shaohe_feng has joined #openstack-nova | 10:13 | |
| *** ljxiash has joined #openstack-nova | 10:13 | |
| *** zhangyufei has quit IRC | 10:13 | |
| *** zhangyufei has joined #openstack-nova | 10:13 | |
| *** dims has quit IRC | 10:14 | |
| openstackgerrit | Nguyen Phuong An proposed openstack/nova: Stop using mox from tests/unit/test_service.py https://review.openstack.org/334395 | 10:14 |
| *** PaulMurray has joined #openstack-nova | 10:15 | |
| *** sameo has joined #openstack-nova | 10:16 | |
| *** ducttape_ has quit IRC | 10:17 | |
| *** ljxiash has quit IRC | 10:18 | |
| *** dims has joined #openstack-nova | 10:20 | |
| *** shaohe_feng has quit IRC | 10:22 | |
| *** shaohe_feng has joined #openstack-nova | 10:23 | |
| openstackgerrit | Yang Shengming proposed openstack/nova: prevent resize down with ceph backend in libvirt driver https://review.openstack.org/325708 | 10:24 |
| *** jichen has quit IRC | 10:25 | |
| *** tbachman has joined #openstack-nova | 10:25 | |
| *** sudipto has quit IRC | 10:29 | |
| *** roeyc has quit IRC | 10:29 | |
| *** sdague has joined #openstack-nova | 10:32 | |
| *** shaohe_feng has quit IRC | 10:33 | |
| *** shaohe_feng has joined #openstack-nova | 10:34 | |
| *** gszasz has joined #openstack-nova | 10:34 | |
| openstackgerrit | Hieu LE proposed openstack/nova: Remove mox from unit/network/test_manager.py (1) https://review.openstack.org/334409 | 10:38 |
| *** fawadkhaliq has quit IRC | 10:39 | |
| *** jwcroppe has joined #openstack-nova | 10:41 | |
| openstackgerrit | Hieu LE proposed openstack/nova: Remove mox from unit/virt/libvirt/test_imagebackend.py (1) https://review.openstack.org/334409 | 10:41 |
| *** links has quit IRC | 10:43 | |
| *** shaohe_feng has quit IRC | 10:43 | |
| *** jichen has joined #openstack-nova | 10:43 | |
| *** mfedosin has quit IRC | 10:43 | |
| *** shaohe_feng has joined #openstack-nova | 10:44 | |
| *** GB21 has joined #openstack-nova | 10:45 | |
| *** EinstCrazy has quit IRC | 10:45 | |
| *** jwcroppe has quit IRC | 10:46 | |
| openstackgerrit | bailin.zhang proposed openstack/nova: Delete reduplicate code in test_compute_mgr.py https://review.openstack.org/331108 | 10:47 |
| *** sridharg has joined #openstack-nova | 10:48 | |
| *** fragatina has quit IRC | 10:48 | |
| *** fragatina has joined #openstack-nova | 10:49 | |
| *** pacoblox has joined #openstack-nova | 10:49 | |
| *** daemontool has joined #openstack-nova | 10:50 | |
| *** houming has quit IRC | 10:50 | |
| sdague | alex_xu: you able to take a look at this - https://review.openstack.org/#/c/332261/ ? | 10:50 |
| *** houming has joined #openstack-nova | 10:51 | |
| *** shaohe_feng has quit IRC | 10:53 | |
| *** shaohe_feng has joined #openstack-nova | 10:54 | |
| *** thorst has joined #openstack-nova | 10:54 | |
| *** links has joined #openstack-nova | 10:55 | |
| *** pacoblox has quit IRC | 10:56 | |
| *** erlon has joined #openstack-nova | 10:57 | |
| *** sacharya has joined #openstack-nova | 10:58 | |
| *** salv-orl_ has joined #openstack-nova | 10:59 | |
| *** markvoelker has joined #openstack-nova | 10:59 | |
| *** salv-orl_ has quit IRC | 11:01 | |
| *** Daisy has joined #openstack-nova | 11:01 | |
| *** thorst has quit IRC | 11:02 | |
| *** salv-orlando has quit IRC | 11:02 | |
| *** sacharya has quit IRC | 11:02 | |
| gibi_ | it seems that python-novaclient gate is broken due to dbus-1 package issue. I opened https://bugs.launchpad.net/python-novaclient/+bug/1596499 to track it | 11:03 |
| openstack | Launchpad bug 1596499 in python-novaclient "test env setup fails due to missing python-dbus" [Undecided,New] | 11:03 |
| *** chandankumar has joined #openstack-nova | 11:03 | |
| *** markvoelker has quit IRC | 11:03 | |
| *** shaohe_feng has quit IRC | 11:03 | |
| *** shaohe_feng has joined #openstack-nova | 11:04 | |
| *** zhangyufei_ has joined #openstack-nova | 11:06 | |
| *** Daisy has quit IRC | 11:06 | |
| *** zhangyufei has quit IRC | 11:06 | |
| *** zhangyufei_ is now known as zhangyufei | 11:06 | |
| *** baoli has joined #openstack-nova | 11:07 | |
| *** tyrola has quit IRC | 11:08 | |
| *** baoli_ has joined #openstack-nova | 11:08 | |
| *** tyrola has joined #openstack-nova | 11:09 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: policy: Replaces 'authorize' in nova-api (part 2) https://review.openstack.org/330034 | 11:09 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Pre-add instance actions to avoid merge conflicts https://review.openstack.org/330513 | 11:09 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Transform instance.update notification https://review.openstack.org/325923 | 11:09 |
| openstackgerrit | Paul Murray proposed openstack/nova: Add server uuid to console URLs https://review.openstack.org/325382 | 11:10 |
| openstackgerrit | Paul Murray proposed openstack/nova: Convert websocketproxy to use db for token validation https://review.openstack.org/333990 | 11:10 |
| gibi_ | johnthetubaguy: I read your suggestion about and 'unknown' value here https://review.openstack.org/#/c/313654/35/nova/objects/fields.py but i don't really get it | 11:11 |
| gibi_ | johnthetubaguy: what backporting scenario is in your mind? | 11:11 |
| johnthetubaguy | gibi_: ah, sorry, I didn't explain that well | 11:11 |
| *** sridharg has quit IRC | 11:12 | |
| johnthetubaguy | gibi_: so I think I was talking pre-coffee nonsense, but let me double check with you | 11:12 |
| *** baoli has quit IRC | 11:12 | |
| gibi_ | johnthetubaguy: I'm also a bit in a monday brain state | 11:12 |
| johnthetubaguy | gibi_: I was thinking about the main code getting and added enum property, and what would happen | 11:12 |
| johnthetubaguy | gibi_: I was thinking about converting unknown values to "unknown", in those cases | 11:12 |
| gibi_ | johnthetubaguy: if there is a new InstanceState then we add it to the enum, bump the version of the related notification | 11:12 |
| gibi_ | johnthetubaguy: ahh so you don't want to update the notification when the new state is added | 11:13 |
| gibi_ | johnthetubaguy: I guess you are right because it will be hard to detect when a new possible state is added | 11:13 |
| *** ducttape_ has joined #openstack-nova | 11:13 | |
| *** shaohe_feng has quit IRC | 11:14 | |
| gibi_ | johnthetubaguy: rlrossit promised to make a follow up patch to remove the duplication, that might solve this issue as well | 11:14 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Add swap volume notifications (start, end) https://review.openstack.org/250283 | 11:14 |
| gibi_ | johnthetubaguy: I mean the duplication between the vm_states and the InstanceState enum | 11:15 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Add swap volume notifications (error) https://review.openstack.org/328055 | 11:15 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Add swap volume notifications samples https://review.openstack.org/328866 | 11:15 |
| gibi_ | johnthetubaguy: if it is not duplicate then adding a new state means an an automatic version bump as well | 11:15 |
| johnthetubaguy | gibi_: sorry, I got disconnected, but I am I am agreeing with you, its not an issue | 11:15 |
| johnthetubaguy | agreeing with you now | 11:16 |
| *** wanghao_ has joined #openstack-nova | 11:16 | |
| johnthetubaguy | gibi_: another thing popped into my head, should we add a reno note, when we add a new notification? | 11:16 |
| *** chandankumar has quit IRC | 11:16 | |
| *** shaohe_feng has joined #openstack-nova | 11:17 | |
| gibi_ | I'm planning to add a reno note after the feature freeze about all the transformed notifications so far. Regarding totally new notifications I think we should add a reno note | 11:17 |
| *** bjornar has quit IRC | 11:17 | |
| *** sree has joined #openstack-nova | 11:17 | |
| *** ducttape_ has quit IRC | 11:18 | |
| johnthetubaguy | gibi_: cool, thats a good idea, saves too many merge conflicts | 11:18 |
| *** Jeffrey4l_ has quit IRC | 11:18 | |
| gibi_ | johnthetubaguy: yeah. Secretly I hope that we can merge some of the transofmation doen by OSICs people before the freeze | 11:19 |
| johnthetubaguy | gibi_: me too | 11:19 |
| gibi_ | johnthetubaguy: and after the freeze I have some followup patches to do, collected on the wiki https://wiki.openstack.org/wiki/Nova/VersionedNotificationTransformation#Follow_up_tasks | 11:19 |
| openstackgerrit | Jinquan Ni proposed openstack/nova-specs: Modify PCI without numa node info treatment https://review.openstack.org/334419 | 11:20 |
| *** fawadkhaliq has joined #openstack-nova | 11:20 | |
| *** bjornar has joined #openstack-nova | 11:21 | |
| *** sree has quit IRC | 11:21 | |
| johnthetubaguy | gibi_: ah, good context, thank you | 11:21 |
| *** sree has joined #openstack-nova | 11:21 | |
| openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: Ensure that periodic reclaim cleans DB deleted instances https://review.openstack.org/323250 | 11:23 |
| openstackgerrit | Jinquan Ni proposed openstack/nova-specs: Modify PCI without numa node info treatment https://review.openstack.org/334419 | 11:23 |
| *** shaohe_feng has quit IRC | 11:24 | |
| *** mariusv has joined #openstack-nova | 11:24 | |
| *** mariusv has quit IRC | 11:24 | |
| *** mariusv has joined #openstack-nova | 11:24 | |
| *** mariusv has quit IRC | 11:24 | |
| markus_z | danpb: IIUC "virt/test_virt_drivers.py" and "libvirt/test_driver.py" have a contradicting expectation for "get_console_output". | 11:24 |
| markus_z | danpb: expects string: http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/virt/test_virt_drivers.py#n584 | 11:25 |
| *** shaohe_feng has joined #openstack-nova | 11:25 | |
| markus_z | danpb: expects exception: http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/virt/libvirt/test_driver.py#n10237 | 11:25 |
| *** sree has quit IRC | 11:25 | |
| markus_z | danpb: The result is the same for the end user. Any preferences here? | 11:25 |
| gibi_ | johnthetubaguy: regarding the duplicated test code, you are right, it is also defined in the server_group functional test. | 11:28 |
| johnthetubaguy | gibi_: hmm... thats where it is | 11:28 |
| johnthetubaguy | gibi_: maybe we need to extract a helpers class somewhere? | 11:28 |
| gibi_ | johnthetubaguy: I can move that to a common place but that will be something similar to the _IntegratedHelpers | 11:28 |
| johnthetubaguy | gibi_: yeah, that sounds good, thank you! | 11:28 |
| gibi_ | johnthetubaguy: and If I know correctly we hate IntegratedHelpers | 11:29 |
| gibi_ | johnthetubaguy: but I don't know the reason | 11:29 |
| johnthetubaguy | gibi_: so we want to keep the tests simple, rather than opaque | 11:29 |
| johnthetubaguy | gibi_: I would go for a simple set of utils you can explicitly call in your test | 11:30 |
| gibi_ | johnthetubaguy: me too. Let's but it in the IntegratedHelpers and see the objections if any | 11:30 |
| *** Jeffrey4l_ has joined #openstack-nova | 11:30 | |
| *** sree has joined #openstack-nova | 11:31 | |
| johnthetubaguy | gibi_: yeah, I would make the move a separate patch I guess | 11:31 |
| *** roeyc has joined #openstack-nova | 11:31 | |
| * johnthetubaguy runs away to get some food | 11:31 | |
| gibi_ | johnthetubaguy: you mean, do it before the instance.delete starts to use it or after it? | 11:32 |
| gibi_ | johnthetubaguy: will do after it, that make more sense to me | 11:32 |
| gibi_ | johnthetubaguy: enjoy your lunch | 11:32 |
| *** shaohe_feng has quit IRC | 11:34 | |
| *** GB21 has quit IRC | 11:35 | |
| *** shaohe_feng has joined #openstack-nova | 11:35 | |
| johnthetubaguy | gibi_: either could work, I was thinking before, but I don't mind | 11:36 |
| *** Jeffrey4l_ has quit IRC | 11:38 | |
| *** houming has quit IRC | 11:42 | |
| *** jwcroppe has joined #openstack-nova | 11:42 | |
| *** shaohe_feng has quit IRC | 11:44 | |
| *** luis5tb has joined #openstack-nova | 11:45 | |
| *** agireud has quit IRC | 11:45 | |
| *** shaohe_feng has joined #openstack-nova | 11:45 | |
| *** akshai has joined #openstack-nova | 11:46 | |
| *** jwcroppe has quit IRC | 11:47 | |
| *** akshai has quit IRC | 11:48 | |
| *** thorst has joined #openstack-nova | 11:50 | |
| *** thorst_ has joined #openstack-nova | 11:51 | |
| *** mfedosin has joined #openstack-nova | 11:52 | |
| *** thorst has quit IRC | 11:55 | |
| *** shaohe_feng has quit IRC | 11:55 | |
| *** shaohe_feng has joined #openstack-nova | 11:56 | |
| *** raildo-a` is now known as raildo | 11:56 | |
| *** Jeffrey4l_ has joined #openstack-nova | 11:58 | |
| *** GB21 has joined #openstack-nova | 11:58 | |
| *** lucasagomes is now known as lucas-hungry | 11:59 | |
| alex_xu | sdague: yea, will check that | 11:59 |
| *** rtheis has joined #openstack-nova | 11:59 | |
| frickler | haypo: https://review.openstack.org/332738 needs a rebase, do you want to do it yourself or should I push the version I've come up with for you to crosscheck? | 11:59 |
| *** ducttape_ has joined #openstack-nova | 12:00 | |
| *** aysyd has joined #openstack-nova | 12:00 | |
| *** manikanta has joined #openstack-nova | 12:01 | |
| *** Daisy has joined #openstack-nova | 12:01 | |
| alex_xu | sdague: johnthetubaguy Should we added next page link when pagination? just found the flavor and servers API have the next page link. But for those pagination propose in newton didn't includes the links. | 12:01 |
| *** zerda2 has quit IRC | 12:03 | |
| *** daemontool has quit IRC | 12:05 | |
| *** Hosam_ has joined #openstack-nova | 12:05 | |
| *** daemontool has joined #openstack-nova | 12:05 | |
| *** shaohe_feng has quit IRC | 12:05 | |
| *** shaohe_feng has joined #openstack-nova | 12:06 | |
| *** rodrigods has quit IRC | 12:06 | |
| *** rodrigods has joined #openstack-nova | 12:06 | |
| *** prateek has quit IRC | 12:07 | |
| openstackgerrit | bailin.zhang proposed openstack/nova: Delete reduplicate code in test_compute_mgr.py https://review.openstack.org/331108 | 12:08 |
| *** amotoki has quit IRC | 12:08 | |
| *** Hosam has quit IRC | 12:08 | |
| *** amotoki has joined #openstack-nova | 12:09 | |
| *** diga has quit IRC | 12:11 | |
| *** tblakeslee has joined #openstack-nova | 12:11 | |
| *** Daisy has quit IRC | 12:11 | |
| *** Daisy has joined #openstack-nova | 12:11 | |
| *** markvoelker has joined #openstack-nova | 12:14 | |
| *** shaohe_feng has quit IRC | 12:15 | |
| *** agireud has joined #openstack-nova | 12:16 | |
| *** shaohe_feng has joined #openstack-nova | 12:16 | |
| manikanta | Hai | 12:17 |
| manikanta | i have developed a feature in kilo in my local devstack how to use that feauture in mitaka in my local devstack ?? | 12:18 |
| *** krtaylor has quit IRC | 12:18 | |
| manikanta | an any body help | 12:18 |
| *** Daisy_ has joined #openstack-nova | 12:18 | |
| *** Daisy has quit IRC | 12:20 | |
| *** pradk has joined #openstack-nova | 12:21 | |
| *** ducttape_ has quit IRC | 12:24 | |
| kevin_zh | sdague: Hi sdague, could you give some comments about https://review.openstack.org/#/c/329403/ if you have a moment? It's about virtio-scsi index | 12:24 |
| haypo | frickler: hi. i wanted until the first patch of my serie was merged | 12:25 |
| haypo | frickler: i got merged during the lunch. i will rebase my patch serie ;) | 12:25 |
| *** shaohe_feng has quit IRC | 12:25 | |
| *** shaohe_feng has joined #openstack-nova | 12:26 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: policy: Replaces 'authorize' in nova-api (part 4) https://review.openstack.org/330036 | 12:27 |
| *** syjulian has joined #openstack-nova | 12:28 | |
| *** Daisy_ has quit IRC | 12:28 | |
| *** Daisy has joined #openstack-nova | 12:28 | |
| *** derekh is now known as derekh_afk | 12:29 | |
| *** chandankumar has joined #openstack-nova | 12:29 | |
| *** eharney has joined #openstack-nova | 12:29 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Example verification for os-agents.inc https://review.openstack.org/334453 | 12:30 |
| *** fawadkhaliq has quit IRC | 12:31 | |
| *** takashin has left #openstack-nova | 12:32 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: numa: Fixes NUMA topology related unit tests https://review.openstack.org/278835 | 12:32 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: libvirt: fixes python 3 related unit tests https://review.openstack.org/278834 | 12:32 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Fixes python 3 unit tests https://review.openstack.org/278810 | 12:32 |
| *** fawadkhaliq has joined #openstack-nova | 12:32 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: compute: fixes python 3 related unit tests https://review.openstack.org/300262 | 12:32 |
| openstackgerrit | Pavel Kholkin proposed openstack/nova: Microversion 2.32 adds keypairs pagination support https://review.openstack.org/284868 | 12:35 |
| *** Hosam has joined #openstack-nova | 12:35 | |
| *** GB21 has quit IRC | 12:35 | |
| *** shaohe_feng has quit IRC | 12:36 | |
| *** shaohe_feng has joined #openstack-nova | 12:36 | |
| *** fawadkhaliq has quit IRC | 12:37 | |
| *** Hosam_ has quit IRC | 12:38 | |
| *** amotoki has quit IRC | 12:39 | |
| *** ivase has joined #openstack-nova | 12:40 | |
| *** lpetrut has quit IRC | 12:40 | |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port test_fakelibvirt to Python 3 https://review.openstack.org/333251 | 12:41 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port ironic test_driver to Python 3 https://review.openstack.org/333250 | 12:41 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port libvirt test_driver to Python 3 https://review.openstack.org/333249 | 12:41 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port test_virt_drivers to Python 3 https://review.openstack.org/333248 | 12:41 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port test_ipv6 to py3 and simplify to_global() https://review.openstack.org/332701 | 12:41 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port virt test_hardware to Python 3 https://review.openstack.org/333247 | 12:41 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port pci unit tests to Python 3 https://review.openstack.org/332791 | 12:41 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port test_metadata to Python 3 https://review.openstack.org/332738 | 12:41 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port test_hacking to Python 3 https://review.openstack.org/332737 | 12:41 |
| *** sudipto has joined #openstack-nova | 12:43 | |
| *** jichen has quit IRC | 12:43 | |
| *** jwcroppe has joined #openstack-nova | 12:44 | |
| *** salv-orlando has joined #openstack-nova | 12:44 | |
| *** rwmjones_ is now known as rwmjones | 12:46 | |
| *** shaohe_feng has quit IRC | 12:46 | |
| *** shaohe_feng has joined #openstack-nova | 12:46 | |
| *** kylek3h has joined #openstack-nova | 12:46 | |
| *** tbachman has quit IRC | 12:47 | |
| openstackgerrit | Alex Szarka proposed openstack/nova: Recover instances when physical data is missing https://review.openstack.org/322341 | 12:47 |
| *** svenkat has joined #openstack-nova | 12:47 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Don't use 'updated_at' to check service's status https://review.openstack.org/297085 | 12:48 |
| *** ratailor has quit IRC | 12:48 | |
| *** jwcroppe has quit IRC | 12:48 | |
| johnthetubaguy | alex_xu: hmm, good point, its odd to only do half of that, in many ways | 12:49 |
| johnthetubaguy | alex_xu: I can't remember where the api-wg have got with that now | 12:49 |
| *** luis5tb has quit IRC | 12:49 | |
| *** rlrossit has joined #openstack-nova | 12:51 | |
| *** salv-orlando has quit IRC | 12:51 | |
| *** akshai has joined #openstack-nova | 12:51 | |
| *** sayalilunkad has joined #openstack-nova | 12:52 | |
| *** matrohon has joined #openstack-nova | 12:52 | |
| *** moshele has quit IRC | 12:52 | |
| *** moshele has joined #openstack-nova | 12:52 | |
| *** svenkat has left #openstack-nova | 12:52 | |
| openstackgerrit | Alex Szarka proposed openstack/nova: Recover instances when physical data is missing https://review.openstack.org/322341 | 12:54 |
| *** gcb has quit IRC | 12:55 | |
| *** shaohe_feng has quit IRC | 12:56 | |
| *** smatzek has joined #openstack-nova | 12:57 | |
| *** shaohe_feng has joined #openstack-nova | 12:57 | |
| haypo | frickler: done. i rebased me serie ;) i just sent an email to ask for help to review them | 12:58 |
| openstackgerrit | Bob Ball proposed openstack/nova: XenAPI: Add option for running nova independently from hypervisor https://review.openstack.org/332216 | 12:59 |
| openstackgerrit | Bob Ball proposed openstack/nova: XenAPI: Perform disk operations in dom0 https://review.openstack.org/331254 | 12:59 |
| openstackgerrit | Bob Ball proposed openstack/nova: XenAPI: Stream config drive to XAPI https://review.openstack.org/332215 | 12:59 |
| frickler | haypo: great, I'll take a look later | 13:00 |
| *** derekh_afk is now known as derekh | 13:01 | |
| bauzas | good morning Nova | 13:01 |
| * bauzas is baby-sitting today due to a lovely child pox, yeah... | 13:01 | |
| *** edmondsw has joined #openstack-nova | 13:01 | |
| *** akshai has quit IRC | 13:05 | |
| *** oanson has quit IRC | 13:05 | |
| *** shaohe_feng has quit IRC | 13:06 | |
| *** tbachman has joined #openstack-nova | 13:06 | |
| *** shaohe_feng has joined #openstack-nova | 13:07 | |
| *** fawadkhaliq has joined #openstack-nova | 13:09 | |
| *** akshai has joined #openstack-nova | 13:09 | |
| *** ljxiash has joined #openstack-nova | 13:09 | |
| *** Hosam_ has joined #openstack-nova | 13:09 | |
| *** lucas-hungry is now known as lucasagomes | 13:09 | |
| *** sdake has joined #openstack-nova | 13:10 | |
| openstackgerrit | octopuszhang proposed openstack/nova: Allow irrelevant,self-defined specs in ComputeCapacityFilter https://review.openstack.org/317306 | 13:10 |
| *** ctrath has joined #openstack-nova | 13:11 | |
| *** krtaylor has joined #openstack-nova | 13:11 | |
| *** zhangyufei has quit IRC | 13:12 | |
| *** fawadkhaliq has quit IRC | 13:12 | |
| *** ducttape_ has joined #openstack-nova | 13:12 | |
| *** nkrinner is now known as nkrinner_afk | 13:13 | |
| *** Hosam has quit IRC | 13:13 | |
| alex_xu | johnthetubaguy: there is patch for pagination in api-wg, but it still in-progress https://review.openstack.org/#/c/190743/ | 13:13 |
| *** muawiakhan has quit IRC | 13:14 | |
| *** muawiakhan has joined #openstack-nova | 13:14 | |
| rlrossit | gibi_: johnthetubaguy: so what's this going on about duplication in https://review.openstack.org/#/c/313654/ ? | 13:14 |
| *** ctrath has quit IRC | 13:16 | |
| *** EinstCrazy has joined #openstack-nova | 13:16 | |
| *** ducttape_ has quit IRC | 13:16 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: policy: Replaces 'authorize' in nova-api (part 3) https://review.openstack.org/330035 | 13:16 |
| *** prateek has joined #openstack-nova | 13:16 | |
| johnthetubaguy | rlrossit: I think gibi is extracting some stuff into a common place where both tests can use it | 13:16 |
| *** shaohe_feng has quit IRC | 13:17 | |
| johnthetubaguy | rlrossit: maybe it depends which duplication you are talking about I guess | 13:17 |
| rlrossit | johnthetubaguy: oh those enums? yeah I was going to push up a patch for that, but I got too consumed in my scheduler experimenting... | 13:17 |
| *** shaohe_feng has joined #openstack-nova | 13:17 | |
| *** pacoblox has joined #openstack-nova | 13:17 | |
| gibi_ | johnthetubaguy, rlrossit: yeah, I'm doing that right now | 13:17 |
| rlrossit | johnthetubaguy: whatever you un-reviewed for | 13:18 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: policy: Replaces 'authorize' in nova-api (part 2) https://review.openstack.org/330034 | 13:18 |
| johnthetubaguy | yeah, the test stuff, gibi is on that right now | 13:18 |
| lyarwood | mdbooth: https://review.openstack.org/#/c/329030/6 - can you take another look at this review this week? | 13:18 |
| *** sdake_ has joined #openstack-nova | 13:20 | |
| *** pbandark has quit IRC | 13:20 | |
| *** sdake has quit IRC | 13:21 | |
| edleafe | bauzas: you have my sympathy. It's never fun having a cranky child. | 13:22 |
| *** mriedem has joined #openstack-nova | 13:23 | |
| *** pbandark has joined #openstack-nova | 13:23 | |
| *** mdrabe has joined #openstack-nova | 13:24 | |
| *** Dinesh_Bhor has joined #openstack-nova | 13:24 | |
| pkoniszewski | johnthetubaguy: hi, what do you mean here in your comment https://review.openstack.org/#/c/326874/19/nova/virt/libvirt/driver.py ? live_migration_flag is already deprecated (since Mitaka) and shouldn't be used | 13:24 |
| bauzas | edleafe: :) | 13:24 |
| pkoniszewski | johnthetubaguy: we also don't check this flag anymore (apart from tunnelling thing) | 13:25 |
| *** pacoblox has quit IRC | 13:26 | |
| pkoniszewski | johnthetubaguy: ah, sorry, you are right, we still have this parser | 13:26 |
| *** cleong has joined #openstack-nova | 13:27 | |
| *** shaohe_feng has quit IRC | 13:27 | |
| johnthetubaguy | pkoniszewski: just replied inline to give more context on the request, hopefully that helps | 13:28 |
| *** shaohe_feng has joined #openstack-nova | 13:28 | |
| *** gagehugo has joined #openstack-nova | 13:28 | |
| pkoniszewski | johnthetubaguy: thanks | 13:28 |
| *** diogogmt has quit IRC | 13:29 | |
| openstackgerrit | Muawia Khan proposed openstack/nova: Remove network information from IOVisor vif https://review.openstack.org/299253 | 13:30 |
| *** belmoreira has quit IRC | 13:31 | |
| *** pradk has quit IRC | 13:31 | |
| openstackgerrit | John Garbutt proposed openstack/nova: Refactor to create _ensure_no_port_binding_failure https://review.openstack.org/327011 | 13:32 |
| *** klkumar has quit IRC | 13:32 | |
| pkholkin | mriedem: good monday:) please look once again my patch https://review.openstack.org/#/c/284868 | 13:33 |
| pkholkin | there were several comments from me and from Alex Xu | 13:33 |
| mriedem | pkholkin: ah i forgot all about keypairs in the api db happening in the keypair object | 13:34 |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: libvirt: virtlogd: use virtlogd for char devices https://review.openstack.org/323765 | 13:34 |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: libvirt: simplify "get_console_output" interface https://review.openstack.org/334480 | 13:34 |
| mriedem | that certainly makes this messier | 13:34 |
| pkholkin | I think we should call alaski ) | 13:35 |
| *** shaohe_feng has quit IRC | 13:35 | |
| mriedem | this is all his fault | 13:35 |
| alaski | seems likely | 13:35 |
| *** shaohe_feng has joined #openstack-nova | 13:35 | |
| pkholkin | ) Hi Andrew, please take a look at this pagination patchm too https://review.openstack.org/#/c/284868 | 13:36 |
| openstackgerrit | John Garbutt proposed openstack/nova: Refactor to create _ensure_no_port_binding_failure https://review.openstack.org/327011 | 13:36 |
| *** luis5tb has joined #openstack-nova | 13:36 | |
| *** ravikama_ has joined #openstack-nova | 13:37 | |
| *** mdrabe has quit IRC | 13:37 | |
| *** shaohe_feng has quit IRC | 13:37 | |
| *** mdrabe has joined #openstack-nova | 13:38 | |
| *** shaohe_feng has joined #openstack-nova | 13:38 | |
| jaypipes | johnthetubaguy, mriedem, dansmith, danpb: your review on https://review.openstack.org/#/c/332124/ would be appreciated. thanks in advance! | 13:38 |
| mriedem | jaypipes: notice that the live migration job failed? http://logs.openstack.org/24/332124/11/check/gate-tempest-dsvm-multinode-live-migration/7522609/ | 13:39 |
| alaski | pkholkin: sorting the result looks like the simplest thing here | 13:39 |
| johnthetubaguy | jaypipes: can't hit that right away, but I hope to look through that chain soon-ish | 13:39 |
| mriedem | http://logs.openstack.org/24/332124/11/check/gate-tempest-dsvm-multinode-full/9ee470d/console.html passed though so could be a job setup fluke | 13:40 |
| pkholkin | alaski: is it ok if api keypairs and main keypairs will be shuffled in the result ? | 13:40 |
| pkholkin | mriedem: ^ | 13:40 |
| mriedem | i haven't seen this failure before though http://logs.openstack.org/24/332124/11/check/gate-tempest-dsvm-multinode-live-migration/7522609/logs/screen-n-cpu.txt.gz?level=TRACE#_2016-06-25_09_23_39_778 | 13:40 |
| alaski | pkholkin: oh, nvm. I thought there was a sort key here | 13:40 |
| pkholkin | if you add sort before concatinating | 13:41 |
| *** ctrath has joined #openstack-nova | 13:41 | |
| *** pwnall has joined #openstack-nova | 13:41 | |
| jaypipes | tdurakov: see mriedem's comment above pls. | 13:41 |
| alaski | pkholkin: honestly I wouldn't worry about sorting here | 13:41 |
| dansmith | mriedem: I think that means qemu exited unexpectedly | 13:41 |
| *** burgerk has joined #openstack-nova | 13:41 | |
| *** xyang1 has joined #openstack-nova | 13:41 | |
| pkholkin | alaski: as for me I prefre not to sort them | 13:42 |
| dansmith | so could be worth a recheck | 13:42 |
| alaski | pkholkin: cool. I'm leaving a comment | 13:42 |
| pkholkin | but the result will not be sorted by name in this case | 13:42 |
| pkholkin | alaski: thanks! | 13:43 |
| mriedem | yikes http://tinyurl.com/hjehrmv | 13:43 |
| openstackgerrit | John Garbutt proposed openstack/nova: On port update check port binding worked https://review.openstack.org/327012 | 13:45 |
| openstackgerrit | Gleb Stepanov proposed openstack/nova: Pin HTTP response codes to API microversions https://review.openstack.org/305369 | 13:45 |
| *** _d34dh0r53_ is now known as d34dh0r53 | 13:45 | |
| *** pradk has joined #openstack-nova | 13:45 | |
| *** jwcroppe has joined #openstack-nova | 13:45 | |
| *** klkumar has joined #openstack-nova | 13:45 | |
| openstackgerrit | John Garbutt proposed openstack/nova: On port update check port binding worked https://review.openstack.org/327012 | 13:46 |
| *** eharney has quit IRC | 13:46 | |
| *** luis5tb has quit IRC | 13:47 | |
| *** tongli has joined #openstack-nova | 13:47 | |
| *** shaohe_feng has quit IRC | 13:47 | |
| *** kfarr has joined #openstack-nova | 13:48 | |
| *** salv-orlando has joined #openstack-nova | 13:48 | |
| mriedem | jaypipes: left some comments | 13:48 |
| mriedem | not sure why that one method had to be split up in the compute manager | 13:48 |
| *** shaohe_feng has joined #openstack-nova | 13:48 | |
| *** gagehugo has quit IRC | 13:49 | |
| pkholkin | alex_xu: mriedem: alaski left comment about sorting to https://review.openstack.org/#/c/284868 | 13:49 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: policy: Replaces 'authorize' in nova-api (part 4) https://review.openstack.org/330036 | 13:50 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: WIP: policy: clean-up https://review.openstack.org/333925 | 13:50 |
| pkholkin | also please find other issues ) | 13:50 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: policy: Replaces 'authorize' in nova-api (part 5) https://review.openstack.org/333514 | 13:50 |
| *** jwcroppe has quit IRC | 13:50 | |
| *** klkumar has quit IRC | 13:50 | |
| *** eharney has joined #openstack-nova | 13:51 | |
| jaypipes | mriedem: cheers | 13:51 |
| *** muawiakhan has quit IRC | 13:52 | |
| *** amotoki has joined #openstack-nova | 13:53 | |
| *** gstepanov has quit IRC | 13:53 | |
| *** gongysh has quit IRC | 13:53 | |
| edleafe | Nova scheduler subteam meeting in 5 minutes in #openstack-meeting-alt | 13:55 |
| sudipto | mriedem, wanted request for a review: https://review.openstack.org/#/c/270341/ ? I have addressed the comments. | 13:55 |
| *** salv-orlando has quit IRC | 13:55 | |
| *** kproskurin has joined #openstack-nova | 13:55 | |
| *** burgerk has quit IRC | 13:55 | |
| *** ctrath has quit IRC | 13:56 | |
| bauzas | jaypipes: mriedem: some non-prio BP change that could need eyes :) https://review.openstack.org/#/c/270341/13 | 13:56 |
| *** ducttape_ has joined #openstack-nova | 13:56 | |
| *** M00nr41n has quit IRC | 13:56 | |
| mriedem | mnestratov|2: fyi, vz compute ci failed a resize test on the resize patch http://openstack-3rd-party-virtuozzo-ci-logs.virtuozzo.com/57/182257/55/check/check-dsvm-tempest-vz7-exe-minimal/788a5f7/console.html | 13:57 |
| *** shaohe_feng has quit IRC | 13:58 | |
| *** Hosam_ has quit IRC | 13:58 | |
| kproskurin | Hello folks. Im trying to launch VMs in really experemental env from the trunk. And got this: http://paste.openstack.org/show/523563/ Looks like nova is trying to use system disk to create a volume for instance. I dont want this. I dont have a cinder and I dont want to use any disk for a lvm volumes. Can I still launch VMs using just a file as a volume?.. | 13:58 |
| mnestratov|2 | mriedem: yeah I know. thanks for pointing this out | 13:58 |
| *** shaohe_feng has joined #openstack-nova | 13:58 | |
| mnestratov|2 | actually we found a bug in tempest | 13:59 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port test_fakelibvirt to Python 3 https://review.openstack.org/333251 | 13:59 |
| *** akshai has quit IRC | 13:59 | |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port ironic test_driver to Python 3 https://review.openstack.org/333250 | 13:59 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port libvirt test_driver to Python 3 https://review.openstack.org/333249 | 13:59 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port test_virt_drivers to Python 3 https://review.openstack.org/333248 | 13:59 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port virt test_hardware to Python 3 https://review.openstack.org/333247 | 13:59 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port pci unit tests to Python 3 https://review.openstack.org/332791 | 13:59 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port test_metadata to Python 3 https://review.openstack.org/332738 | 13:59 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port test_hacking to Python 3 https://review.openstack.org/332737 | 13:59 |
| mnestratov|2 | and preparing a review for it | 13:59 |
| *** ctrath has joined #openstack-nova | 13:59 | |
| *** ametts has joined #openstack-nova | 14:00 | |
| openstackgerrit | Karen Bradshaw proposed openstack/nova: api-ref: os-volumes.inc https://review.openstack.org/320048 | 14:00 |
| *** diga has joined #openstack-nova | 14:00 | |
| *** mnestratov|2 is now known as mnestratov | 14:00 | |
| *** EinstCrazy has quit IRC | 14:00 | |
| *** burt has joined #openstack-nova | 14:01 | |
| mnestratov | the problem is how test_resize_server_from_manual_to_auto treats alternate_flavor | 14:01 |
| edleafe | jaypipes: bauzas: johnthetubaguy: scheduler meeting? | 14:02 |
| *** mmandel has joined #openstack-nova | 14:02 | |
| mriedem | sudipto: jaypipes was +2 on https://review.openstack.org/#/c/270341/ so he's probably a better person to ask | 14:02 |
| mnestratov | it reuses the same server and just switches original flavor with alt one, which makes an attempt to resize down | 14:03 |
| *** akshai has joined #openstack-nova | 14:03 | |
| mnestratov | if you run tests in several threads, you will probably not hit the bug, but if you run them just in 1 thread, the bug will trigger 100% | 14:04 |
| *** liverpooler has quit IRC | 14:05 | |
| *** amotoki has quit IRC | 14:05 | |
| *** mfisch has joined #openstack-nova | 14:06 | |
| *** mfisch has quit IRC | 14:06 | |
| *** mfisch has joined #openstack-nova | 14:06 | |
| *** shaohe_feng has quit IRC | 14:08 | |
| *** stefan_amann has joined #openstack-nova | 14:08 | |
| mnestratov | and the problem is that our CI currently runs in one thread | 14:08 |
| *** shaohe_feng has joined #openstack-nova | 14:08 | |
| sahid | jaypipes, mriedem if you have a moment today, wht about to make it merged https://review.openstack.org/#/c/312014/ | 14:09 |
| dansmith | mnestratov: can you get around it by just changing the order of your main/alternate flavors to be small..big ? | 14:09 |
| *** amotoki has joined #openstack-nova | 14:10 | |
| *** amotoki has quit IRC | 14:11 | |
| mnestratov | dansmith: no matter what ordre is for these two tests test_resize_server_from_manual_to_auto and test_resize_server_from_auto_to_manual if they run one after another | 14:11 |
| dansmith | mnestratov: okay | 14:11 |
| mnestratov | *order | 14:11 |
| *** diogogmt has joined #openstack-nova | 14:12 | |
| mnestratov | we could skip them but prefered fixing the bug | 14:12 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Introduce the memory bandwidth monitor https://review.openstack.org/329783 | 14:12 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Introduce utility module for pcp https://review.openstack.org/203163 | 14:12 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor https://review.openstack.org/266773 | 14:12 |
| markus_z | dansmith: FYI, there's an upgrade relevant bug report, maybe you can have a look sometime https://bugs.launchpad.net/nova/+bug/1596119 | 14:12 |
| openstack | Launchpad bug 1596119 in OpenStack Compute (nova) "Can't delete instance with numa_topology after upgrading from kilo" [Undecided,New] | 14:12 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Update setup.cfg for memory bandwidth monitor https://review.openstack.org/329785 | 14:12 |
| *** luis5tb has joined #openstack-nova | 14:12 | |
| *** cdelatte has joined #openstack-nova | 14:13 | |
| *** MikeG451 has joined #openstack-nova | 14:13 | |
| *** sameo has quit IRC | 14:13 | |
| stefan_amann | I have two questions on https://review.openstack.org/#/c/320832/: 1) Implementation state is 'blocked'. But I think this can be removed since the blueprint and spec has been approved for Cinder? And question 2) I introduced a new connector in os-brick. But the Jenkins checks fail because the os-brick code is back-level. Can anyone help me resolving this? Thanks!! | 14:14 |
| dansmith | markus_z: okay, that bug is strange.. we should point sahid at it too | 14:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Pre-add instance actions to avoid merge conflicts https://review.openstack.org/330513 | 14:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Transform instance.update notification https://review.openstack.org/325923 | 14:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Transform instance.delete notifications https://review.openstack.org/313654 | 14:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Moving test helpers to a common place https://review.openstack.org/334503 | 14:14 |
| *** mjura has quit IRC | 14:15 | |
| jaypipes | sahid: done. | 14:16 |
| *** GB21 has joined #openstack-nova | 14:17 | |
| *** lpetrut has joined #openstack-nova | 14:17 | |
| *** shaohe_feng has quit IRC | 14:18 | |
| markus_z | sahid: FYI too: https://bugs.launchpad.net/nova/+bug/1596119 (I haven't found a duplicate or otherwise related bug to this) | 14:19 |
| openstack | Launchpad bug 1596119 in OpenStack Compute (nova) "Can't delete instance with numa_topology after upgrading from kilo" [Undecided,New] | 14:19 |
| *** mkoderer__ has quit IRC | 14:21 | |
| *** shaohe_feng has joined #openstack-nova | 14:21 | |
| openstackgerrit | Jay Pipes proposed openstack/nova-specs: resource-providers: Populate allocation fields https://review.openstack.org/300177 | 14:21 |
| dansmith | markus_z: it might just be a misconfigured deployment, but since it's related to that feature, I just thought sahid should be aware of it in case it's something more involved | 14:22 |
| *** woodster_ has joined #openstack-nova | 14:22 | |
| jaypipes | dansmith, mriedem, edleafe, bauzas: ^^ updated resource providers allocations spec. | 14:22 |
| gibi_ | johnthetubaguy, rlrossit: I moved the test code duplication to a common place https://review.openstack.org/334503 | 14:22 |
| *** ayoung has joined #openstack-nova | 14:22 | |
| *** hshiina has quit IRC | 14:22 | |
| *** kevin_zh has quit IRC | 14:22 | |
| bauzas | jaypipes: kewl | 14:22 |
| * bauzas opens a tab | 14:22 | |
| gibi_ | johnthetubaguy, rlrossit: and updated the instance.delete https://review.openstack.org/313654 to use from the common place | 14:22 |
| *** Daisy has quit IRC | 14:23 | |
| *** mlavalle has joined #openstack-nova | 14:23 | |
| mlavalle | jaypipes: ping | 14:23 |
| markus_z | dansmith: Does the upgrade process produce any special logs? I'm not sure which information to ask the bug reporter. | 14:25 |
| dansmith | markus_z: you saw my reply right? | 14:25 |
| markus_z | whops, no, one sec | 14:25 |
| mdbooth | dansmith mriedem: Incidentally, in case you hadn't already please hold off the libvirt storage pools reviews for a couple of days. We had some things come up last week around resize which has resulted in a fair amount of extra work. The backend patches themselves aren't going to change much/at all, but the way driver calls it will be quite different. | 14:25 |
| *** sameo has joined #openstack-nova | 14:26 | |
| mlavalle | jaypipes: do you have time for a quick question before leaving for the airport? | 14:26 |
| dansmith | mdbooth: ack | 14:26 |
| markus_z | dansmith: OK, thanks, I haven't thought about that. | 14:26 |
| *** ssurana has joined #openstack-nova | 14:27 | |
| *** Prophidys has quit IRC | 14:27 | |
| *** claudiub|2 has joined #openstack-nova | 14:27 | |
| *** shaohe_feng has quit IRC | 14:28 | |
| jaypipes | mlavalle: yep | 14:29 |
| markus_z | dansmith: That means we don't intercept a service registration if the versions don't match, right? | 14:29 |
| *** shaohe_feng has joined #openstack-nova | 14:29 | |
| *** salv-orlando has joined #openstack-nova | 14:30 | |
| dansmith | markus_z: we do more now than we used to back then | 14:30 |
| markus_z | dansmith: IOW, if the conductor service (kilo) starts, it doesn't sense for liberty compute service (or something like that)? | 14:30 |
| *** claudiub has quit IRC | 14:30 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Introduce utility module for pcp https://review.openstack.org/203163 | 14:30 |
| markus_z | dansmith: Yes, sure, I don't doubt that. I haven't done an upgrade yet, my knowledge isn't very good in that area. | 14:31 |
| mlavalle | jaypipes: I see a lot of good progress in implementation of generic resource pools: https://review.openstack.org/#/q/topic:bp/generic-resource-pools. But the scheduler also has to be updated to use this in making placement decisions. Right? | 14:31 |
| jaypipes | mlavalle: yup. | 14:32 |
| mlavalle | jaypipes: is that work already in progress? or is that going to start after generic pools resources are finished? | 14:33 |
| *** Prophidys has joined #openstack-nova | 14:33 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor https://review.openstack.org/266773 | 14:33 |
| jaypipes | mlavalle: going to start after the g-r-p series is done. | 14:34 |
| *** cdelatte has quit IRC | 14:34 | |
| openstackgerrit | John Garbutt proposed openstack/nova: Always call port_update in allocate_for_instance https://review.openstack.org/326970 | 14:35 |
| openstackgerrit | John Garbutt proposed openstack/nova: Extract _filter_hypervisor_macs https://review.openstack.org/329569 | 14:35 |
| mriedem | mnestratov: it would be good to use the full config option help for the new options here https://review.openstack.org/#/c/190843/30/nova/conf/libvirt.py | 14:35 |
| mriedem | mnestratov: i won't block on that for the FF, but it would be good to get done before another core shows up | 14:35 |
| mnestratov | mriedem: another review or current? | 14:36 |
| mriedem | mnestratov: current would be best | 14:36 |
| mnestratov | mriedem: ok | 14:36 |
| mriedem | sdague: did you still have an issue with this? https://review.openstack.org/#/c/312014/ | 14:36 |
| sdague | mriedem: looking | 14:37 |
| mriedem | re: token expired vs misconfig | 14:37 |
| mriedem | sdague: we get a lot of bugs about misconfig resulting in 500s | 14:37 |
| mlavalle | jaypipes: do you think that will happen in Newton? | 14:37 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Introduce the memory bandwidth monitor https://review.openstack.org/329783 | 14:37 |
| sdague | mriedem: right. So, I actually think a 500 is the right thing to do on a misconfigured nova, because 401 makes it assume the user can do something to fix it | 14:38 |
| jaypipes | mlavalle: :( I'm not sure, man. | 14:38 |
| sdague | 401 is, go reset your password | 14:38 |
| sdague | the 500 should be more clear as to why though | 14:38 |
| mriedem | is there a way to tell if a token would be valid but it's expired? | 14:38 |
| sdague | because in the case of a misconfigured Nova, the server is actually in error. It can't do the job. | 14:38 |
| artom | bauzas, some comments for you here: https://review.openstack.org/#/c/331490 | 14:38 |
| *** Daisy has joined #openstack-nova | 14:39 | |
| *** shaohe_feng has quit IRC | 14:39 | |
| sdague | mriedem: I don't know off the top of my head, we could ask keystone folks | 14:39 |
| mlavalle | jaypipes: ok, I know you are in a hurry. Have a nice trip and thank you for taking the time to answer my questions | 14:39 |
| mnestratov | mriedem: here is a review for tempest to fix our CI failure on resize, if you are interested https://review.openstack.org/#/c/334505 | 14:39 |
| mriedem | i'm guessing any info about the token would be swallowed up in the neutronclient | 14:39 |
| bauzas | artom: k | 14:39 |
| jaypipes | mlavalle: no worries man. I'll update you if anything changes. | 14:39 |
| *** shaohe_feng has joined #openstack-nova | 14:40 | |
| mriedem | mnestratov: might want to report a bug against tempest for that | 14:40 |
| sdague | mriedem: maybe... but it would be nice to separate those if we could | 14:40 |
| artom | bauzas, hopefully I'm making sense - I've had too coffees but I feel like I need 5 more :D | 14:40 |
| mnestratov | mriedem: ok | 14:40 |
| mnestratov | will do | 14:40 |
| bauzas | artom: honestly, the real problem is that we really suck at providing capabilities in some good abstractional facade | 14:40 |
| bauzas | artom: and your change is just hit by the bus | 14:41 |
| *** thorst__ has joined #openstack-nova | 14:41 | |
| bauzas | artom: because it's just an hot topic and we really hate how we're doing things at the moment for knowing whether compute A is good or not | 14:41 |
| openstackgerrit | Jinquan Ni proposed openstack/nova-specs: Modify PCI without numa node info treatment https://review.openstack.org/334419 | 14:42 |
| sdague | mriedem: actually, an expired token is never going to be a 500 error | 14:42 |
| *** Hosam has joined #openstack-nova | 14:42 | |
| artom | bauzas, I'll take your word for it - about the suckage that is ;) | 14:42 |
| openstackgerrit | Jinquan Ni proposed openstack/nova: libvirt:code flow problem in wait_for_job https://review.openstack.org/320750 | 14:42 |
| *** cfriesen has joined #openstack-nova | 14:43 | |
| sdague | because that would assume that you had a connection that lasted > 1 hour | 14:43 |
| artom | bauzas, the flavor extra specs bit seems like it's a good start to me, but it's only limited to, well, flavor extra specs. | 14:43 |
| markus_z | PaulMurray: A probably stupid question: We *do* support a live-migration back to N-1 hosts, right? | 14:43 |
| *** Daisy has quit IRC | 14:43 | |
| *** jaugustine has joined #openstack-nova | 14:44 | |
| *** thorst_ has quit IRC | 14:45 | |
| mriedem | sdague: well nova gets a 401 from neutronclient | 14:46 |
| *** ociuhandu has joined #openstack-nova | 14:46 | |
| mriedem | but that's passed through to the nova rest api which results in a 500 b/c we aren't handling NeutronClientException in the nova rest API | 14:46 |
| sdague | mriedem: under what circumstances? | 14:46 |
| mnestratov | mriedem: actually there is a bug already https://bugs.launchpad.net/tempest/+bug/1358221 | 14:46 |
| openstack | Launchpad bug 1358221 in tempest "tempest resize tests do not consider hypervisors that don't allow resize down" [Undecided,Confirmed] | 14:46 |
| sdague | tokens are good for an hour | 14:46 |
| *** akshai has quit IRC | 14:46 | |
| *** sameo_ has joined #openstack-nova | 14:47 | |
| *** jwcroppe has joined #openstack-nova | 14:47 | |
| sdague | mriedem: I get that if neutron fails in this way, it's a 500 | 14:48 |
| *** ayoung_ has joined #openstack-nova | 14:48 | |
| openstackgerrit | Mikhail Feoktistov proposed openstack/nova: libvirt: virtuozzo instance resize support https://review.openstack.org/182257 | 14:48 |
| mriedem | sdague: looking back at other bugs related to this, https://bugs.launchpad.net/nova/+bug/1563513 is definitely a misconfig | 14:49 |
| openstack | Launchpad bug 1563513 in OpenStack Compute (nova) "Unexpected Exception in API Error when creating instance with Neutron" [Undecided,Invalid] | 14:49 |
| mriedem | which sahid's change isn't going to address | 14:49 |
| *** shaohe_feng has quit IRC | 14:49 | |
| *** karts is now known as karthiks | 14:49 | |
| *** Prophidys has quit IRC | 14:49 | |
| sdague | but it seems like the only time this would be an issue is when the token is generated before talking to Nova API (which is fine, that happens a bunch), and is used in a long standing process (which is also fine), and just manages to get past the time limit hitting nova-api, with 5 seconds to spare, then hits neutron with expired token | 14:49 |
| *** Trozz_ has joined #openstack-nova | 14:49 | |
| *** shaohe_feng has joined #openstack-nova | 14:50 | |
| sdague | which is a bug, but it's a very narrow bug, and masking out the misconfig as if it's a user auth problem seems like a worse direction to head | 14:50 |
| *** belmoreira has joined #openstack-nova | 14:50 | |
| artom | mriedem, so https://review.openstack.org/#/c/305120/ is (mostly) passing - there's a failure in the layer4 job, but I don't think it's related to the code. Also the patch itself obviously needs more work, but at least it shows the API works | 14:51 |
| *** david-lyle_ has joined #openstack-nova | 14:51 | |
| PaulMurray | markus_z, sort of | 14:51 |
| *** akshai has joined #openstack-nova | 14:51 | |
| *** jwcroppe has quit IRC | 14:55 | |
| *** jschlueter has joined #openstack-nova | 14:55 | |
| PaulMurray | markus_z, the block_migration flag changed its meaning slightly in 2.23 (I think) | 14:55 |
| PaulMurray | markus_z, as long as you use an api version that is present on N-1 you are ok | 14:55 |
| sahid | dansmith, markus_z just notice https://bugs.launchpad.net/nova/+bug/1596119 | 14:55 |
| sahid | I keep an eye on this, let see if reporter is going to give more information | 14:55 |
| openstack | Launchpad bug 1596119 in OpenStack Compute (nova) "Can't delete instance with numa_topology after upgrading from kilo" [Undecided,Incomplete] | 14:55 |
| dansmith | sahid: cool | 14:55 |
| PaulMurray | markus_z, or specifically liberty hosts don't know how to automatically figure out selective block migration | 14:55 |
| *** jschlueter has quit IRC | 14:55 | |
| *** mpavone has quit IRC | 14:55 | |
| *** Prophidys has joined #openstack-nova | 14:55 | |
| *** Prophidys has quit IRC | 14:55 | |
| *** Prophidys has joined #openstack-nova | 14:55 | |
| *** andreas_s has quit IRC | 14:55 | |
| *** Trozz_ is now known as Trozz | 14:55 | |
| *** david-lyle has quit IRC | 14:55 | |
| *** crinkle_ is now known as crinkle | 14:55 | |
| *** sameo has quit IRC | 14:56 | |
| *** kevin_zh has joined #openstack-nova | 14:56 | |
| *** pwnall has quit IRC | 14:56 | |
| *** jaypipes has quit IRC | 14:56 | |
| markus_z | PaulMurray: I was wondering because I didn't find a version info in the libvirt migration data object. | 14:57 |
| *** amotoki has joined #openstack-nova | 14:57 | |
| markus_z | PaulMurray: My assumption was, that we sometimes have to update the domain XML based on the version of libvirt on the target host. | 14:57 |
| *** sacharya has joined #openstack-nova | 14:57 | |
| *** itamarl has quit IRC | 14:58 | |
| *** ctrath has quit IRC | 14:59 | |
| *** shaohe_feng has quit IRC | 14:59 | |
| markus_z | PaulMurray: To be more specific, I'm working on the utilization of a libvirt 1.3.3 feature ("virtlogd") for Newton. | 15:00 |
| *** shaohe_feng has joined #openstack-nova | 15:01 | |
| *** sdake has joined #openstack-nova | 15:01 | |
| *** kevinzh has joined #openstack-nova | 15:01 | |
| markus_z | PaulMurray: Hm, after typing my questions and assumptions I see now that my question is wrong... | 15:01 |
| *** prateek_ has joined #openstack-nova | 15:01 | |
| markus_z | I could also have the case where I migrate between two Newton nodes but with different libvirt versions. | 15:01 |
| *** jistr is now known as jistr|mtg | 15:01 | |
| *** mvk_ has quit IRC | 15:02 | |
| *** sdake_ has quit IRC | 15:03 | |
| *** ctrath has joined #openstack-nova | 15:04 | |
| *** prateek has quit IRC | 15:04 | |
| *** kevin_zh has quit IRC | 15:04 | |
| markus_z | PaulMurray: nevermind, I have to think more about it, sorry | 15:04 |
| *** krotscheck is now known as krotscheck_dcm | 15:05 | |
| *** muawiakhan has joined #openstack-nova | 15:07 | |
| PaulMurray | markus_z, np | 15:09 |
| *** doffm has quit IRC | 15:09 | |
| *** david-lyle_ is now known as david-lyle | 15:09 | |
| *** thorst__ is now known as thorst_ | 15:09 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Add swap volume notifications (start, end) https://review.openstack.org/250283 | 15:09 |
| PaulMurray | markus_z, FYI certain features are only available in certain versions of libvirt & qemu - e.g. selective block migration | 15:09 |
| *** john51 has joined #openstack-nova | 15:09 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Add swap volume notifications (error) https://review.openstack.org/328055 | 15:09 |
| PaulMurray | an attempt to do something it can't should fail and rollback at worst | 15:09 |
| *** ayoung has quit IRC | 15:09 | |
| *** ayoung_ is now known as ayoung | 15:09 | |
| *** shaohe_feng has quit IRC | 15:09 | |
| *** shaohe_feng has joined #openstack-nova | 15:10 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Add swap volume notifications samples https://review.openstack.org/328866 | 15:10 |
| PaulMurray | the libvirt versions are checked in the virt driver | 15:10 |
| *** kevinzh is now known as kevin_zh | 15:10 | |
| *** ctrath1 has joined #openstack-nova | 15:10 | |
| PaulMurray | but I think you are right that they are not compared between hosts | 15:10 |
| *** belmoreira has quit IRC | 15:10 | |
| danpb | mriedem: i'm struggling to understand what the blocker problem is here with the privsep update https://review.openstack.org/#/c/329769 | 15:11 |
| mriedem | sudipto: i hae to say i'm not crazy about this pcp driver in nova | 15:11 |
| mriedem | danpb: it doesn't fix the grenade issue | 15:11 |
| *** tyrola has quit IRC | 15:11 | |
| mriedem | danpb: see https://review.openstack.org/#/c/331885/ | 15:11 |
| *** tyrola has joined #openstack-nova | 15:11 | |
| danpb | mriedem: that last comment though just shows that the node isn't getting the new privsep installed | 15:12 |
| sudipto | mriedem, the reason being? | 15:12 |
| danpb | which seems like a separate unrelated problem | 15:12 |
| mriedem | sudipto: it's not tested at all, so when pcp changes it's api and does a release upstream, we'll be broken and not know it | 15:12 |
| sudipto | mriedem, do you have a suggestion by which this could be averted? | 15:12 |
| *** ctrath has quit IRC | 15:13 | |
| *** john51_ has quit IRC | 15:13 | |
| mriedem | sudipto: not any good ones no | 15:13 |
| mdbooth | lyarwood: I'm looking at https://review.openstack.org/#/c/270289/17/nova/virt/libvirt/driver.py and assuming I'm being dim | 15:13 |
| mdbooth | Line 2540 | 15:13 |
| mdbooth | Wouldn't rescue_images['image_id'] be a uuid, not a dict? | 15:14 |
| sudipto | mriedem, ok but that would be the case with any external library right? | 15:14 |
| sudipto | and i am version controlling on the API - so that's a way to protect IMHO | 15:15 |
| mriedem | sudipto: yeah, but that's also why we try to avoid those in nova, especially if we can't enable them in ci runs | 15:15 |
| mriedem | sudipto: where does that happen? | 15:15 |
| *** jistr|mtg is now known as jistr | 15:16 | |
| *** pwnall has joined #openstack-nova | 15:16 | |
| mriedem | danpb: i think that comment was old/invalid | 15:16 |
| mriedem | danpb: that was the mitaka node i think | 15:17 |
| sudipto | mriedem, well by external library i meant - something that has an external API dependency...(and is not a part of openstack's maintenance headache)....however, if there's a way to enable this in the CI framework - will that be satisfactory? | 15:17 |
| *** fragatina has quit IRC | 15:17 | |
| *** fragatina has joined #openstack-nova | 15:17 | |
| openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova: Improve help text for vmware https://review.openstack.org/333616 | 15:17 |
| danpb | mriedem: how/where are we seeing that os-brick is still broken during upgrade ? | 15:17 |
| mriedem | http://logs.openstack.org/85/331885/2/check/gate-grenade-dsvm-multinode/415e1bc/ | 15:18 |
| danpb | IIUC, the ci would pass even with the old code | 15:18 |
| mriedem | danpb: this http://logs.openstack.org/85/331885/2/check/gate-grenade-dsvm-multinode/415e1bc/logs/new/screen-n-cpu.txt.gz?level=TRACE#_2016-06-21_16_21_30_994 | 15:18 |
| mriedem | danpb: have yo useen the dev list thread on this? | 15:18 |
| mriedem | the newer one | 15:18 |
| danpb | mriedem: ah ok | 15:18 |
| mriedem | http://lists.openstack.org/pipermail/openstack-dev/2016-June/098010.html | 15:19 |
| mriedem | and http://lists.openstack.org/pipermail/openstack-dev/2016-June/097904.html | 15:19 |
| lyarwood | mdbooth: yeah checking | 15:19 |
| *** shaohe_feng has quit IRC | 15:20 | |
| artom | bauzas, just because we're pressed for time and you know that code waaay better than I do, what's the "standard" way for the scheduler to ask the virt driver about a certain capability? | 15:20 |
| mriedem | sudipto: is the lib available on ubuntu 14.04/16.04? as in could we install it from devstack on master? | 15:20 |
| artom | bauzas, because your point about rolling migrations definitely puts the nail in the coffin for just checking hv-type. | 15:20 |
| *** ssurana has quit IRC | 15:21 | |
| *** shaohe_feng has joined #openstack-nova | 15:21 | |
| bauzas | artom: I'm just looking at something about that | 15:21 |
| danpb | mriedem: so IIUC the crux of the problem is that 'pip install foobar' only installs python code and doesn't install rootwrap filters which are installed separately by devstack or $whatever-installer ? | 15:21 |
| *** yamahata has joined #openstack-nova | 15:22 | |
| *** gongysh has joined #openstack-nova | 15:22 | |
| openstackgerrit | John Garbutt proposed openstack/nova: Create _validate_requested_port_ids https://review.openstack.org/329600 | 15:22 |
| sudipto | mriedem, http://pcp.io/download.html - i am not sure if this answers your question though. | 15:22 |
| lyarwood | mdbooth: yeah that's broken, isn't tested etc. I'll sort it out after this call. | 15:22 |
| mdbooth | lyarwood: Cool. It was just a cursory look, so I didn't want to leave a stupid -1 :) | 15:23 |
| *** mmandel has quit IRC | 15:23 | |
| *** pbandark has quit IRC | 15:24 | |
| mriedem | sudipto: so how about throwing up a devstack change which installs pcp | 15:24 |
| mriedem | danpb: yeah, | 15:24 |
| sudipto | mriedem, that sounds good to me, however - this is an optional plugin, so i guess we could still do it? | 15:24 |
| danpb | mriedem: what prevents us writing a custom setup.py rule to install the files at same time as the code ? | 15:25 |
| mriedem | sudipto: optional or not, we generally want more than fake stubs with unit tests for things that have external dependencies | 15:26 |
| *** BjoernT has joined #openstack-nova | 15:26 | |
| sudipto | mriedem, ok sure. Let me read up a bit on how to do this, I may need your help. Hope that's ok... | 15:26 |
| mriedem | sudipto: e.g. osinfo is optional for the libvirt driver but we do install it in devstack so it's available when we try to load it up in CI runs | 15:26 |
| sudipto | mriedem, i mean i just need the help on how to get it on devstack... | 15:27 |
| mriedem | danpb: nothing that i know of | 15:27 |
| mriedem | sudipto: under files/ in devstack | 15:27 |
| mriedem | there are the per-distro native packages | 15:27 |
| *** diga has quit IRC | 15:27 | |
| sudipto | mriedem, ok sure... | 15:27 |
| *** tbachman has quit IRC | 15:27 | |
| *** matrohon has quit IRC | 15:29 | |
| openstackgerrit | Sujitha proposed openstack/nova: Improve help text for floating ips options. https://review.openstack.org/318309 | 15:30 |
| *** dmk0202 has quit IRC | 15:30 | |
| *** shaohe_feng has quit IRC | 15:30 | |
| *** shaohe_feng has joined #openstack-nova | 15:31 | |
| *** harlowja_at_home has joined #openstack-nova | 15:31 | |
| *** derekh is now known as derekh_afk | 15:31 | |
| *** moshele has quit IRC | 15:33 | |
| *** roeyc has quit IRC | 15:34 | |
| *** cdelatte has joined #openstack-nova | 15:34 | |
| *** ssurana has joined #openstack-nova | 15:37 | |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.create_ip notification https://review.openstack.org/332876 | 15:37 |
| *** matrohon has joined #openstack-nova | 15:38 | |
| *** tbachman has joined #openstack-nova | 15:38 | |
| *** pcaruana has quit IRC | 15:38 | |
| *** MikeG451 has quit IRC | 15:39 | |
| *** tesseract- has quit IRC | 15:40 | |
| *** shaohe_feng has quit IRC | 15:40 | |
| *** shaohe_feng has joined #openstack-nova | 15:41 | |
| *** M00nr41n has joined #openstack-nova | 15:41 | |
| gibi_ | hi, there is a quite simple test code move around https://review.openstack.org/#/c/334503/ that needs a second +2. | 15:42 |
| *** mmandel has joined #openstack-nova | 15:42 | |
| *** bnemec has quit IRC | 15:43 | |
| *** bnemec has joined #openstack-nova | 15:43 | |
| *** daemontool has quit IRC | 15:44 | |
| *** tonytan4ever has joined #openstack-nova | 15:44 | |
| *** cdelatte has quit IRC | 15:45 | |
| *** GB21 has quit IRC | 15:46 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Transform instance.update notification https://review.openstack.org/325923 | 15:46 |
| *** bnemec has quit IRC | 15:50 | |
| *** ssurana has quit IRC | 15:51 | |
| *** cdelatte has joined #openstack-nova | 15:51 | |
| *** bnemec has joined #openstack-nova | 15:52 | |
| *** cdelatte has quit IRC | 15:52 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Pre-add instance actions to avoid merge conflicts https://review.openstack.org/330513 | 15:52 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Transform instance.update notification https://review.openstack.org/325923 | 15:52 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Moving test helpers to a common place https://review.openstack.org/334503 | 15:52 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Transform instance.delete notifications https://review.openstack.org/313654 | 15:52 |
| openstackgerrit | STEW TY proposed openstack/nova: Complete verification for os-floating-ips-bulk https://review.openstack.org/333075 | 15:52 |
| *** links has quit IRC | 15:52 | |
| *** shaohe_feng has quit IRC | 15:52 | |
| melwitt | johnthetubaguy: fyi a non-priority review you might be interested in, nova-manage command for refreshing quota usage https://review.openstack.org/#/c/299487/ | 15:53 |
| *** baoli_ has quit IRC | 15:54 | |
| johnthetubaguy | melwitt: good call out, I should hit that one soon ish | 15:54 |
| *** hshiina has joined #openstack-nova | 15:54 | |
| mriedem | stefan_amann: https://blueprints.launchpad.net/nova/+spec/linux-ficon-support is blocked because the brick driver hasn't been merged and released in os-brick | 15:54 |
| openstackgerrit | Mikhail Feoktistov proposed openstack/nova: libvirt: support user password settings in virtuozzo https://review.openstack.org/330643 | 15:54 |
| openstackgerrit | John Garbutt proposed openstack/nova: Extract _validate_requested_network_ids https://review.openstack.org/329601 | 15:54 |
| melwitt | johnthetubaguy: cool. note that I think ccarmack isn't working on nova anymore so I rebased and addressed my own comments on the patches, and will address further comments that come in | 15:54 |
| mriedem | stefan_amann: the depends-on to the os-brick change in https://review.openstack.org/#/c/320832/ doesn't work because zuul doesn't pull the os-brick change in, it installs the os-brick package | 15:54 |
| *** sree has quit IRC | 15:54 | |
| johnthetubaguy | melwitt: ah, gotcha | 15:54 |
| *** BjoernT has quit IRC | 15:54 | |
| *** shaohe_feng_ has joined #openstack-nova | 15:54 | |
| *** shaohe_feng_ is now known as shaohe_feng | 15:54 | |
| stefan_amann | mriedem: thanks. So the os-brick change needs to be merged first, correct? | 15:56 |
| mriedem | stefan_amann: yes | 15:57 |
| mriedem | and released | 15:57 |
| stefan_amann | mriedem: ok, thanks! | 15:57 |
| *** tbachman has quit IRC | 15:58 | |
| *** prateek_ has quit IRC | 15:58 | |
| PaulMurray | mriedem, I've just realised I missed a field out in that database table for console auth | 15:59 |
| mriedem | way2go | 15:59 |
| PaulMurray | mriedem, it doesn't affect anything else much, but I will need to add it | 16:00 |
| *** Trozz is now known as zzTrozz | 16:00 | |
| PaulMurray | groan..... | 16:00 |
| *** sneti has joined #openstack-nova | 16:00 | |
| *** zzTrozz is now known as Trozz_ | 16:01 | |
| *** shaohe_feng has quit IRC | 16:01 | |
| *** Trozz_ is now known as Trozz | 16:01 | |
| *** Trozz has quit IRC | 16:01 | |
| *** shaohe_feng has joined #openstack-nova | 16:02 | |
| *** haypo has left #openstack-nova | 16:02 | |
| *** gszasz has quit IRC | 16:02 | |
| *** tbachman has joined #openstack-nova | 16:05 | |
| *** Trozz has joined #openstack-nova | 16:06 | |
| *** sacharya has quit IRC | 16:09 | |
| gibi_ | rlrossit: I guess you saw the bug report that our object hash calculations does not really use the SCHEMA: https://bugs.launchpad.net/oslo.versionedobjects/+bug/1595552 Do you agree with the way forward in https://review.openstack.org/#/c/333382/ ? | 16:09 |
| openstack | Launchpad bug 1595552 in oslo.versionedobjects "ObjectVersionChecker.test_hashes does not use extra_func to generate the hash" [Undecided,New] - Assigned to Balazs Gibizer (balazs-gibizer) | 16:09 |
| *** yamahata has quit IRC | 16:10 | |
| *** irenab has quit IRC | 16:10 | |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP: Make allocate_for_instance skip create option https://review.openstack.org/332712 | 16:10 |
| openstackgerrit | John Garbutt proposed openstack/nova: Reduce complexity in _stub_allocate_for_instance https://review.openstack.org/332086 | 16:10 |
| openstackgerrit | John Garbutt proposed openstack/nova: Reorder allocate_for_instance preamble https://review.openstack.org/329850 | 16:10 |
| openstackgerrit | John Garbutt proposed openstack/nova: Extract _update_ports_for_instance https://review.openstack.org/329851 | 16:10 |
| openstackgerrit | John Garbutt proposed openstack/nova: Extract port create from allocate_for_instance https://review.openstack.org/328966 | 16:10 |
| openstackgerrit | John Garbutt proposed openstack/nova: Make _validate_requested_network_ids return a dict https://review.openstack.org/329849 | 16:10 |
| *** luis5tb has quit IRC | 16:10 | |
| *** shaohe_feng has quit IRC | 16:11 | |
| *** shaohe_feng has joined #openstack-nova | 16:12 | |
| *** sacharya has joined #openstack-nova | 16:12 | |
| rlrossit | gibi_: yup that looks good to me | 16:12 |
| gibi_ | rlrossit: unfortunately we first need to extend oslo then I can fix nova | 16:12 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: policy: Replaces 'authorize' in nova-api (part 3) https://review.openstack.org/330035 | 16:13 |
| *** BjoernT has joined #openstack-nova | 16:13 | |
| *** BjoernT is now known as Bjoern_zZzZzZzZ | 16:13 | |
| *** markus_z has quit IRC | 16:13 | |
| gibi_ | rlrossit: thanks for quick review | 16:13 |
| mriedem | mdbooth: this makes an assumption that the image format is raw https://github.com/openstack/nova/blob/5f70f1977ddcd5965d4908a20ae9380756885a08/nova/virt/disk/api.py#L244 | 16:14 |
| mriedem | but that might not be the case, right, given the if condition above | 16:14 |
| mriedem | it could be an rbd image | 16:14 |
| mriedem | if (not isinstance(image, imgmodel.LocalImage) or image.format != imgmodel.FORMAT_RAW): | 16:14 |
| mriedem | or can you not have a qcow2 rbd image? | 16:15 |
| *** slunkad_ has quit IRC | 16:15 | |
| mdbooth | mriedem: Nope, rbd is always raw | 16:15 |
| * mdbooth is just processing that code | 16:15 | |
| *** sameo_ has quit IRC | 16:15 | |
| mriedem | ok, in which case we just log a message saying we don't know and return false | 16:15 |
| *** ayoung has quit IRC | 16:16 | |
| *** sameo has joined #openstack-nova | 16:16 | |
| mdbooth | mriedem: Wouldn't rbd take the first path through that conditional? | 16:16 |
| mdbooth | Because it's not a LocalImage? | 16:16 |
| * mdbooth checks | 16:16 | |
| mriedem | mdbooth: gah, yes you're correct | 16:16 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: Allow multi-attach in compute api https://review.openstack.org/271047 | 16:16 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: libvirt: Allow multiple volume attachments https://review.openstack.org/267587 | 16:16 |
| mdbooth | mriedem: I wonder about doing this anyway, though. What's the efficiency gain? | 16:17 |
| mdbooth | It would have to be a lot to warrant 2 code paths | 16:17 |
| *** stefan_amann has quit IRC | 16:17 | |
| bauzas | artom: sorry, had to fix a patch series, but now I'm here | 16:18 |
| mdbooth | Given that almost nobody will be running the second path and nobody's complaining about it, I might be inclined to delete it. | 16:18 |
| bauzas | artom: so, I was looking at the ComputeNode facade, and I remembered that we have a supported_hv_specs field | 16:18 |
| danpb | mriedem: mdbooth technically we could create a qcow2 rbd volume, but fortunately we've not gone down that mind-bending insane path :-) | 16:18 |
| mriedem | mdbooth: i guess to avoid the libguestfs setup / inspection? | 16:19 |
| mdbooth | danpb: Yeah, it's also hard-coded in the backend :) | 16:19 |
| bauzas | artom: which maps our supported_instances field in the HostManager | 16:19 |
| mdbooth | mriedem: Right, but if you're running either qcow2 or rbd then you'll be doing that anyway | 16:19 |
| mdbooth | Which covers almost everybody, right? | 16:19 |
| mdbooth | And if almost everybody's not complaining, we might as well delete the optimisation. | 16:20 |
| *** chandankumar_ has joined #openstack-nova | 16:20 | |
| danpb | mdbooth: you mean remove the case in is_image_extendable that directly uses e2label ? | 16:21 |
| mdbooth | danpb: Yeah | 16:21 |
| *** sdague has quit IRC | 16:21 | |
| bauzas | artom: https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L223-L227 | 16:21 |
| *** shaohe_feng has quit IRC | 16:21 | |
| mdbooth | less code == better | 16:21 |
| bauzas | artom: and https://github.com/openstack/nova/blob/master/nova/scheduler/filters/image_props_filter.py#L44 | 16:22 |
| danpb | mdbooth: yeah, sounds like a very good idea to me | 16:22 |
| *** gongysh has quit IRC | 16:22 | |
| *** chandankumar has quit IRC | 16:22 | |
| danpb | even if you don't want guesfs, the localfs impl will still work | 16:22 |
| bauzas | artom: (the filter is an example of what's passed in, so we compare against the image props) | 16:22 |
| danpb | so there's no compelling reason to special case raw in that way | 16:22 |
| *** shaohe_feng has joined #openstack-nova | 16:22 | |
| bauzas | artom: but, here, you have an idea on how to make sure your filter can select based on capabilities | 16:23 |
| *** eglynn has joined #openstack-nova | 16:23 | |
| *** Bjoern_zZzZzZzZ is now known as BjoernT | 16:23 | |
| bauzas | artom: now, the problem is that you still need to comment which hv_spec would be good | 16:23 |
| sudipto | mriedem, a commit like this would help? https://review.openstack.org/#/c/278142/ | 16:24 |
| *** mdrabe has quit IRC | 16:24 | |
| bauzas | artom: I then would actually wonder if we shouldn't rather provide by the API (and the ReqSpec) which hv_spec to use | 16:24 |
| bauzas | like, saying "okay, I need to use device tagging, so, I'll add to the request which hv_spec we should use" | 16:25 |
| bauzas | dansmith: ^ | 16:25 |
| mdbooth | Interestingly, I think I just noticed that ImageCacheManager automatically delete the backing files of ephemeral disks. | 16:25 |
| *** bvanhav has joined #openstack-nova | 16:26 | |
| * mdbooth will have to check in more detail in the morning, but at first glance I think it only considers as in use the backing files of swap disks and root disks | 16:26 | |
| *** irenab has joined #openstack-nova | 16:27 | |
| artom | bauzas, doesn't your own comment about rolling upgrades rule out using any sort of hv_spec? | 16:28 |
| mriedem | sudipto: yeah | 16:28 |
| sudipto | mriedem, thanks will do... | 16:28 |
| bauzas | artom: yup, because instead of providing a boolean, we should provide a list of hv_specs in the RequestSpec | 16:30 |
| bauzas | artom: so the filter would compare between the list of asked hv_specs and what the supported_instances items are... | 16:30 |
| bauzas | that way, the API would only need to make sure that *all* computes would support that specific HVSpec | 16:31 |
| *** ayoung has joined #openstack-nova | 16:31 | |
| *** stewie925 has joined #openstack-nova | 16:31 | |
| bauzas | that needs a bit more of logic, but at least, this is not something the scheduler would know | 16:31 |
| *** moshele has joined #openstack-nova | 16:31 | |
| *** shaohe_feng has quit IRC | 16:31 | |
| artom | bauzas, sorry I'm being slow - you're saying the compute API would put a list of HVSpecs in the RequestSpec | 16:32 |
| bauzas | yup | 16:32 |
| *** sahid has quit IRC | 16:32 | |
| artom | Then the filter compares those to the supported_hv_type in the ComputeNode? | 16:32 |
| bauzas | zactly | 16:32 |
| *** shaohe_feng has joined #openstack-nova | 16:32 | |
| bauzas | well, it would compare against host_state.supported_instances tbc | 16:32 |
| artom | Right, but host_state is a ComputeNode, no? | 16:33 |
| bauzas | not exactly | 16:33 |
| bauzas | see my first link | 16:33 |
| bauzas | it's something a bit sad | 16:33 |
| bauzas | artom: but we transform a good versioned object into a silly dict, yeah indeed :) | 16:34 |
| *** Sukhdev_ has joined #openstack-nova | 16:34 | |
| artom | bauzas, oh, right, I scrolled up the noticed the HostState class | 16:34 |
| bauzas | well, not a dict of course, rather an unversioned python object | 16:34 |
| artom | Which updates itself from a ComputeNode | 16:34 |
| bauzas | yup | 16:34 |
| *** Apoorva has joined #openstack-nova | 16:35 | |
| bauzas | pretty easy to read, meh ? /ironic | 16:35 |
| artom | Heh, dansmith is spinning in his grave ;) | 16:35 |
| *** GB21 has joined #openstack-nova | 16:35 | |
| *** kevinzh has joined #openstack-nova | 16:35 | |
| bauzas | artom: that leaves the problem of rolling upgrades tho :) | 16:35 |
| *** jlanoux has joined #openstack-nova | 16:36 | |
| bauzas | artom: and how you provide a list of 'virt drivers' you know working with that feature | 16:36 |
| artom | bauzas, we could version the HVType object :) | 16:36 |
| bauzas | artom: ideally, that would be something we should discover, but I'm okay if that's something we provide at a first time as a attribute | 16:36 |
| *** amotoki has quit IRC | 16:37 | |
| danpb | artom: bauzas ultimately this is not actually a new problem | 16:37 |
| *** harlowja_at_home has quit IRC | 16:37 | |
| danpb | we're got this same problem with pretty much every virt driver feature we add and have never tried to solve it so far | 16:37 |
| *** tyrola has quit IRC | 16:37 | |
| danpb | eg you can tag a image as using virtio disks, but we have no way to ensure the VM is scheduled on a host that necessarily supports that | 16:38 |
| artom | danpb, damn, I was hoping you'd say "and here's how we've solved it" :( | 16:38 |
| danpb | the whole problem of compute hypervisor features vs image requested features has been ignored for ages | 16:38 |
| danpb | and i think it really needs to be considered as a general broad problem to solve, not try to get a solution that just works for role tagging | 16:38 |
| bauzas | yup, I totally agree with danpb | 16:38 |
| danpb | IOW, i think solving this is out of scope for the role tagging work | 16:39 |
| artom | So what happens concretely in this case? With bauzas guidance I'm totally up for working on the broader problem, but does it mean for now that I just abandon my filter patch? | 16:39 |
| bauzas | danpb: sure, but tbh, there are 2 problems here | 16:39 |
| *** kevin_zh has quit IRC | 16:39 | |
| bauzas | #1 how we select hosts based on some constraints | 16:39 |
| bauzas | #2 how we provide those constraints to the scheduler, given some edge cases (like rolling upgrades) | 16:40 |
| claudiub|2 | artom: hey dude. how | 16:40 |
| *** kevinzh has quit IRC | 16:40 | |
| claudiub|2 | artom: how's it going? :) | 16:40 |
| danpb | if people need to guarantee that the guests are placed on a host which supports role tagging, for now they should just use the existing filters that match on hypervisor type + version | 16:40 |
| artom | claudiub|2, bro. | 16:40 |
| bauzas | danpb: that's one way indeed | 16:40 |
| danpb | until we can come up with a way for compute nodes to report what they support to the schedular in a fine grained manner | 16:40 |
| claudiub|2 | artom: i was thinking. would you want to tag ephemerals as well? especially if you have more than 1? | 16:40 |
| *** jvgrant_ has quit IRC | 16:42 | |
| bauzas | danpb: tbc, I'm okay with adding a generic filter that would accept a list of constraints from a request_spec and would only filter a list of hosts matching those HVSpecs | 16:42 |
| *** gongysh has joined #openstack-nova | 16:42 | |
| *** jvgrant_ has joined #openstack-nova | 16:42 | |
| danpb | claudiub|2: yep, we should be able to tag any disk entry in the BDM | 16:42 |
| *** shaohe_feng has quit IRC | 16:42 | |
| danpb | claudiub|2: whether its backed by a glance image, cinder volume, or plain ephemeral disk | 16:42 |
| *** mdrabe has joined #openstack-nova | 16:42 | |
| claudiub|2 | danpb: I see. | 16:42 |
| *** shaohe_feng has joined #openstack-nova | 16:42 | |
| artom | claudiub|2, I don't think we have any code specifically for ephemerals, but if we've done our job right any BDM is taggable, as danpb said. | 16:43 |
| danpb | yeah, it should "just work" | 16:43 |
| *** mfedosin has quit IRC | 16:43 | |
| claudiub|2 | danpb: artom: soo, any idea how to tag, or what name should the tags for ephemerals have? | 16:43 |
| danpb | tags are entirely arbitrarily defined by the end user | 16:44 |
| *** rama_y has joined #openstack-nova | 16:44 | |
| claudiub|2 | danpb: artom: same question for image-backed instances, what tag should the root disk have? | 16:44 |
| danpb | claudiub|2: again, whatever the user wants to give it | 16:45 |
| artom | claudiub|2, keep in mind - it's the user who sets the tag. He can set a --block-device blah tag=yurmum, or --block-device and no tag, or whatever | 16:45 |
| claudiub|2 | agreed, but how can a user pass this tag? | 16:45 |
| danpb | magic-unicorn-disk or tasty-baby-seals or $whatever | 16:45 |
| bauzas | artom: danpb: I need to drop from here, but I'll look at your discussion later | 16:46 |
| danpb | claudiub|2: its a new field in the BDM | 16:46 |
| artom | bauzas, hey, quickly before you bounce | 16:46 |
| openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Improve help text for compute manager options https://review.openstack.org/329639 | 16:46 |
| bauzas | artom: you got like 0.2msec | 16:46 |
| artom | bauzas, Is the preliminary conclusion that you're OK with no tagging filter in the short term, and we solve this properly in the future? | 16:46 |
| bauzas | artom: there are ways to ask operators to use the existing filters, so I would say yes | 16:47 |
| artom | bauzas, great, much thanks :) I'll be sure to include some documentation to that effect, in reno perhaps | 16:47 |
| artom | Have fun with whatever you're doing :) | 16:48 |
| bauzas | artom: but you need to make it very clear or you would suffer from the pain of supporting bug reports | 16:48 |
| artom | bauzas, for sure. | 16:48 |
| bauzas | artom: that said, it seems there was a previous discussion about that, so make sure you bounce back to dansmith, mriedem and I dunno whoelse | 16:48 |
| artom | bauzas, yep, poking dansmith was my next step :) | 16:49 |
| *** matrohon has quit IRC | 16:49 | |
| bauzas | artom: in the case where they disagree with not providing a filter for that specific case, I'm fine with the proposal of writing a generic filter which would compare what I mentioned earlier | 16:49 |
| * mriedem isn't following the conversation | 16:50 | |
| bauzas | artom: the real problem is that you shouldn't default it anyway IMHO | 16:50 |
| bauzas | mriedem: a-ha | 16:50 |
| * bauzas loves telling people's names and leave | 16:50 | |
| artom | mriedem, I don't remember if you were involved in the original discussion - perhaps not, which is why you may not have context ;) | 16:50 |
| mriedem | trying to eat lunch before the nova/cinder meeting in 10 min | 16:50 |
| artom | mriedem, bon appetit, I won't harass you for reviews then. You're free game after the cinder meeting though :D | 16:51 |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Improve help text of flavors config options https://review.openstack.org/332930 | 16:51 |
| mriedem | artom: get those tempest tests working? | 16:52 |
| *** shaohe_feng has quit IRC | 16:52 | |
| artom | mriedem, got, in the past - my ping to you must have been lost in the ether this morning | 16:52 |
| *** tblakeslee has quit IRC | 16:52 | |
| *** yamahata has joined #openstack-nova | 16:53 | |
| mriedem | and the scheduling question is if we need the scheduler to land a boot request on a host that is new enough to support tagging vifs/bdms? | 16:53 |
| *** stewie925 has quit IRC | 16:53 | |
| artom | mriedem, on a host that supports it in general, yeah | 16:53 |
| mriedem | artom: we have a few newish things like that, like volume multiattach and get me a network | 16:54 |
| artom | mriedem, did you do anything to the scheduler in get me a network? | 16:54 |
| mriedem | we were going to check the compute service version in the api and fail if requesting multiattach and it's not supported yet | 16:54 |
| *** vladikr has joined #openstack-nova | 16:54 | |
| mriedem | artom: no for get me a network if the minimum compute service version isn't new enough we treat 'auto' as None like today | 16:55 |
| *** shaohe_feng has joined #openstack-nova | 16:55 | |
| *** _ducttape_ has joined #openstack-nova | 16:55 | |
| artom | mriedem, ah, you're lucky to have behaviour to fall back on :) | 16:55 |
| mriedem | for device tags you could fail the request | 16:55 |
| mriedem | which is what the scheduler would do if it coudn't find a valid host | 16:56 |
| artom | Fail in the API? Isn't that extreme? The API would have to check with every compute node whether it's virt driver support tagging... | 16:57 |
| artom | Or am I missing your point completely? | 16:57 |
| openstackgerrit | Eyal Posener proposed openstack/nova: Fix nova-compute service start order https://review.openstack.org/334566 | 16:57 |
| *** chandankumar__ has joined #openstack-nova | 16:58 | |
| *** ducttape_ has quit IRC | 16:58 | |
| *** chandankumar__ is now known as chandankumar | 16:59 | |
| mriedem | artom: the rest api just checks the minimum compute service version | 16:59 |
| *** salv-orl_ has joined #openstack-nova | 16:59 | |
| *** fawadkhaliq has joined #openstack-nova | 16:59 | |
| mriedem | artom: https://review.openstack.org/#/c/316398/27/nova/api/openstack/compute/servers.py@518 | 16:59 |
| artom | mriedem, ok, so if there are computes in the cloud with higher versions... too bad, we fail anyways? | 17:00 |
| mriedem | artom: it's fail fast | 17:00 |
| mriedem | yes | 17:00 |
| mriedem | if you don't have a scheduler filter that can make this work with mixed computes | 17:00 |
| *** belmoreira has joined #openstack-nova | 17:00 | |
| *** ljxiash has quit IRC | 17:00 | |
| mriedem | otherwise you're basically saying, sure i'll accept your request, but nuts to you if we don't land it by chance on a compute that can fulfill the request | 17:00 |
| *** chandankumar_ has quit IRC | 17:00 | |
| mriedem | and then we'll get bugs, as bauzas pointed out | 17:00 |
| artom | mriedem, danpb was was saying that's basically how it works for some image properties already | 17:01 |
| *** abalutoiu has quit IRC | 17:01 | |
| artom | And that the work around for tagging was to have operators filter on virt driver and version, which they can do with the current filters | 17:01 |
| danpb | mriedem: very many other image properties have that characteristic to some degree or other | 17:01 |
| danpb | unless you set up tags based on hypervisor type + version | 17:01 |
| mriedem | artom: danpb: just because it sucks today does it means we should continue sucking? | 17:01 |
| artom | mriedem, to be clear, I like your solution, it's definitely simple, if a bit "brutal" | 17:02 |
| mriedem | the long term solution is the host capabilities stuff | 17:02 |
| danpb | mriedem: there's a crude solution based on filtering with hyprevisor type + version stuff | 17:02 |
| danpb | mriedem: long term we clearly want a general purpose capabilities based soln | 17:02 |
| *** salv-orlando has quit IRC | 17:02 | |
| *** claudiub|2 has quit IRC | 17:02 | |
| *** shaohe_feng has quit IRC | 17:02 | |
| *** MikeG451 has joined #openstack-nova | 17:03 | |
| mriedem | artom: danpb: is the workaround using flavor extra specs? | 17:03 |
| *** shaohe_feng has joined #openstack-nova | 17:03 | |
| *** belmoreira has quit IRC | 17:03 | |
| bauzas | mriedem: ImagePropsFilter rather | 17:04 |
| * bauzas drops again :) | 17:04 | |
| mriedem | so if you want to add device tags, use a specific image with special properties for scheduling to work | 17:04 |
| mriedem | otherwise it works by chance | 17:04 |
| mriedem | is this in a release note somewhere? | 17:04 |
| *** Sukhdev_ has quit IRC | 17:05 | |
| artom | mriedem, not yet, but it can be if that's the consensus we reach | 17:05 |
| danpb | mriedem: nb, every thing just works fine if you have a homogeneous cloud deployment | 17:05 |
| *** ihrachys has quit IRC | 17:06 | |
| danpb | only if you have multiple hypervisors or mixed versions do you need extra work | 17:06 |
| mriedem | danpb: sure, which is probably fine for small private clouds | 17:06 |
| *** ayoung has quit IRC | 17:06 | |
| danpb | yep and at least in short term that's what will be the case for the NFV use case that wants this feature most | 17:06 |
| artom | Hrmm, so wouldn't that favor mriedem's service version approach? | 17:06 |
| mriedem | artom: i think that at least needs to be in a release note in the REST API change probably | 17:06 |
| artom | If we assume 80% of clouds are homogenous, we can just check service version until the correct solution with capabilities is developed? | 17:07 |
| *** chandankumar has quit IRC | 17:07 | |
| mriedem | but it would also be a different approach for what we planned for multiattach, which was to fail fast in the rest api | 17:07 |
| artom | 80/20 effort results, etc etc :) | 17:07 |
| mriedem | volume multiattach is also an NFV thing | 17:07 |
| mriedem | i just don't like that we bake all of these special things into nova that are very single use focused assuming private homogenous clouds / use cases | 17:08 |
| artom | Well, nova is pretty much everything to anyone, so that kind of feature is bound to happen ;) | 17:08 |
| *** woodster_ has quit IRC | 17:09 | |
| *** zenoway has quit IRC | 17:09 | |
| *** zenoway has joined #openstack-nova | 17:10 | |
| * artom will push an update with the service version check, let folks shoot it down in review | 17:10 | |
| mriedem | artom: yeah i know, but it's also why we're removing hooks and plug points | 17:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Don't immediately null host/node when shelving https://review.openstack.org/332243 | 17:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Evaluate 'task_state' in resource (de)allocation https://review.openstack.org/323269 | 17:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Remove mox in nova/tests/unit/compute/test_shelve.py https://review.openstack.org/334572 | 17:12 |
| *** shaohe_feng has quit IRC | 17:12 | |
| *** Sukhdev_ has joined #openstack-nova | 17:13 | |
| *** shaohe_feng has joined #openstack-nova | 17:13 | |
| *** zenoway has quit IRC | 17:14 | |
| openstackgerrit | Mikhail Feoktistov proposed openstack/nova: libvirt: virtuozzo instance resize support https://review.openstack.org/182257 | 17:18 |
| dansmith | artom: bauzas: sorry, monday morning is meeting hell for me | 17:19 |
| *** cdelatte has joined #openstack-nova | 17:19 | |
| artom | dansmith, welcome, time to be productive :) | 17:19 |
| *** ssurana has joined #openstack-nova | 17:20 | |
| dansmith | heh | 17:20 |
| artom | artom, so, there are a few options being floated by people to avoid booting tagged instances on virt drivers that don't support it | 17:20 |
| artom | mriedem is just checking for min service version in the multiattach stuff - I think it's simple, albeit perhaps a bit brutal since it "screws over" heterogenous clouds where some computes would have supported tagging | 17:21 |
| artom | danpb is saying do it though ImagePropsFilter | 17:21 |
| *** ayoung has joined #openstack-nova | 17:22 | |
| *** danpb has quit IRC | 17:22 | |
| * artom just realized he pinged *himself* instead of dansmith | 17:22 | |
| *** shaohe_feng has quit IRC | 17:23 | |
| artom | Everyone agrees we need to solve it properly with compute capabilities in the long run, but we haven't reached consensus for what do to now with device tagging | 17:23 |
| dansmith | service version is good, but not sufficient.. I don't like the image properties approach personally | 17:23 |
| dansmith | artom: I need to go look at that patch I think, as I haven't gotten that far up the stack | 17:23 |
| dansmith | artom: give me a bit to get post-meeting food and then I will | 17:24 |
| *** penick has joined #openstack-nova | 17:24 | |
| *** shaohe_feng has joined #openstack-nova | 17:24 | |
| artom | dansmith, enjoy :) | 17:24 |
| *** krtaylor has quit IRC | 17:24 | |
| *** harlowja has quit IRC | 17:25 | |
| openstackgerrit | STEW TY proposed openstack/nova: Complete verification for os-floating-ips-bulk https://review.openstack.org/333075 | 17:26 |
| *** mfedosin has joined #openstack-nova | 17:28 | |
| *** chandankumar has joined #openstack-nova | 17:30 | |
| *** TravT has quit IRC | 17:32 | |
| *** shaohe_feng has quit IRC | 17:33 | |
| *** harlowja has joined #openstack-nova | 17:33 | |
| *** penick_ has joined #openstack-nova | 17:33 | |
| *** shaohe_feng has joined #openstack-nova | 17:34 | |
| *** Sukhdev_ has quit IRC | 17:34 | |
| *** penick has quit IRC | 17:35 | |
| *** penick_ is now known as penick | 17:35 | |
| dansmith | artom: mriedem so I was just thinking about this whilst cooking up some of what artom would call "just bacon" | 17:35 |
| mriedem | so !ham | 17:36 |
| dansmith | the scheduler filter could always be disabled by the admin, which means we basically can't rely on it for api semantics anyway | 17:36 |
| dansmith | I think that we could do the following two things: | 17:36 |
| dansmith | 1. Check the service version and punt on the request if they ask for tags and everything is not upgraded | 17:36 |
| dansmith | 2. Check the local virt capabilities in compute manager (no RPC required) and reject the instance if we hit a hypervisor with a driver that doesn't support it | 17:37 |
| *** sabari has joined #openstack-nova | 17:37 | |
| dansmith | and then maybe punt on the scheduler filter until we can do it properly with recorded capabilities | 17:37 |
| *** amotoki has joined #openstack-nova | 17:37 | |
| *** abalutoiu has joined #openstack-nova | 17:37 | |
| *** zz_dimtruck is now known as dimtruck | 17:37 | |
| artom | dansmith, would we ever reach 2 if we do 1? | 17:38 |
| dansmith | since the filter could always be disabled for performance by the admins, we can't really guarantee it'll always be there -- the best we can do is not start an instance if you ask for a tag and the hypervisor doesn't support it | 17:38 |
| dansmith | artom: #1 is for fast-fail during an upgrade.. failures under #2 are more costly | 17:38 |
| artom | (Also, Canadian bacon is ham here, and bacon is bacon everywhere) | 17:38 |
| dansmith | oh, then ham :) | 17:39 |
| dansmith | less funny that way, but okay.. lesson learned | 17:39 |
| * artom just checked wikipedia, and it's actually back bacon | 17:39 | |
| artom | In my defense, it looks like ham | 17:39 |
| artom | On the picture | 17:39 |
| artom | And I look at pictures and avoid reading if I can help it :D | 17:39 |
| dansmith | heh | 17:40 |
| dansmith | mriedem: so, thoughts on that plan? | 17:40 |
| *** jaugustine has quit IRC | 17:40 | |
| mriedem | so #2 is for everything that's not libvirt | 17:40 |
| mriedem | raise BuildRescheduledException or whatever? | 17:40 |
| dansmith | for the moment, but patches are pending for two other drivers | 17:40 |
| dansmith | hyper-v might even be ready for review actually | 17:40 |
| * artom just got it - 1 is for older libvirts, 2 is for other drivers | 17:41 | |
| mriedem | i didn't think about the scheduler filter being disabled, so yeah, i think that's a decent plan | 17:41 |
| dansmith | artom: yeah, kinda | 17:41 |
| mriedem | we have to do the same for multiattach so yeah | 17:41 |
| *** irenab has quit IRC | 17:41 | |
| artom | dansmith, yeah, I think claudiu took the WIP/POC tag off that one | 17:41 |
| dansmith | okay I will comment on that review and maybe try to bring it up with bauzas when he shows back up | 17:41 |
| dansmith | artom: yeah, I saw that so assumed it was getting closer | 17:42 |
| artom | dansmith, BTW, there's a xenapi patch up as wlel | 17:42 |
| dansmith | sweet | 17:42 |
| artom | https://review.openstack.org/#/c/333781/ | 17:42 |
| *** amotoki has quit IRC | 17:42 | |
| *** jaugustine has joined #openstack-nova | 17:42 | |
| *** shaohe_feng has quit IRC | 17:43 | |
| openstackgerrit | Evgeny Antyshev proposed openstack/nova: libvirt: add nova volume driver for vzstorage https://review.openstack.org/190843 | 17:44 |
| openstackgerrit | Evgeny Antyshev proposed openstack/nova: libvirt: remove vzstorage rootwrap filters https://review.openstack.org/334171 | 17:44 |
| *** shaohe_feng has joined #openstack-nova | 17:44 | |
| *** moshele has quit IRC | 17:44 | |
| bvanhav | Hi, encountered an issue creating creating a snapshot of a server in nova using master... opened https://bugs.launchpad.net/nova/+bug/1596602 to track the problem | 17:45 |
| openstack | Launchpad bug 1596602 in OpenStack Compute (nova) "Instance Snapshot failure" [Undecided,New] | 17:45 |
| *** sneti has quit IRC | 17:45 | |
| *** salv-orl_ has quit IRC | 17:47 | |
| *** dimtruck is now known as zz_dimtruck | 17:47 | |
| rlrossit | gibi_: you still want me to follow up on transferring the enum you made in the instance.delete patch over to the original module you copied them from? | 17:47 |
| rlrossit | now that this patch train is a little more stable I'll take it up | 17:47 |
| eantyshev | mriedem, edleafe: Hello! I've just made better help text for https://review.openstack.org/190843 | 17:48 |
| *** doffm has joined #openstack-nova | 17:48 | |
| mriedem | eantyshev: cool, thanks, will check that out shortly | 17:48 |
| *** fragatina has quit IRC | 17:49 | |
| dansmith | artom: okay I commented on three patches to that effect.. you good to run on that? | 17:49 |
| dansmith | artom: the net is, a couple checks on compute manager and REST, and then move the scheduler patch to the end or something | 17:49 |
| *** timello has quit IRC | 17:50 | |
| dansmith | vladikr: ^ | 17:50 |
| vladikr | dansmith, readin | 17:50 |
| vladikr | reading | 17:50 |
| edleafe | eantyshev: thanks - will take a look at it | 17:50 |
| mriedem | artom: if/when you add the service version check to the rest api, there is the caching stuff to do, which affects some tests - see https://review.openstack.org/#/c/316398/ | 17:50 |
| mriedem | artom: feel free to copy that if it gets in faster | 17:51 |
| mriedem | i.e. https://review.openstack.org/#/c/316398/27/nova/tests/unit/cmd/test_nova_api.py | 17:51 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Add microversion support to images unit tests https://review.openstack.org/333626 | 17:51 |
| *** tblakeslee has joined #openstack-nova | 17:52 | |
| *** tonytan4ever has quit IRC | 17:52 | |
| *** shaohe_feng has quit IRC | 17:53 | |
| *** irenab has joined #openstack-nova | 17:54 | |
| *** shaohe_feng has joined #openstack-nova | 17:54 | |
| *** tblakeslee_ has joined #openstack-nova | 17:55 | |
| *** gongysh has quit IRC | 17:55 | |
| *** TravT has joined #openstack-nova | 17:56 | |
| vladikr | dansmith, cool, thanks. Btw, artom has commented on the config drive attach patch. Could you please look at this again? | 17:57 |
| *** tblakeslee has quit IRC | 17:57 | |
| *** tblakeslee_ is now known as tblakeslee | 17:57 | |
| dansmith | okay | 17:58 |
| *** TravT has quit IRC | 18:00 | |
| *** tonytan4ever has joined #openstack-nova | 18:00 | |
| *** lucasagomes is now known as lucas-afk | 18:01 | |
| openstackgerrit | Giridhar Jayavelu proposed openstack/nova: VMware: support limits via image meta data https://review.openstack.org/180942 | 18:01 |
| openstackgerrit | Giridhar Jayavelu proposed openstack/nova: Objects: add limits, reservations and shares to ImageMetaProps object https://review.openstack.org/188321 | 18:01 |
| *** TravT has joined #openstack-nova | 18:01 | |
| dansmith | vladikr: hmm, I don't like that answer | 18:01 |
| dansmith | vladikr: got any others? ideally, ones that make me look less dumb? | 18:01 |
| *** zz_dimtruck is now known as dimtruck | 18:03 | |
| *** Apoorva has quit IRC | 18:03 | |
| *** salv-orlando has joined #openstack-nova | 18:03 | |
| *** dimtruck is now known as zz_dimtruck | 18:03 | |
| *** Apoorva has joined #openstack-nova | 18:03 | |
| *** kfarr_ has joined #openstack-nova | 18:03 | |
| *** jaugustine has quit IRC | 18:04 | |
| *** shaohe_feng has quit IRC | 18:04 | |
| *** kfarr has quit IRC | 18:04 | |
| vladikr | dansmith, hmm, sorry, I probably didn't see it being offensive. I wasn't part of that discussion between you and artom. | 18:04 |
| dansmith | vladikr: I'm just joking | 18:05 |
| *** tblakeslee has quit IRC | 18:05 | |
| *** salv-orlando has quit IRC | 18:06 | |
| vladikr | dansmith, In general, I think that there is only one case we are not handling.. probably we | 18:06 |
| *** salv-orlando has joined #openstack-nova | 18:06 | |
| vladikr | dansmith, need to recreate the config drive on hard_reboot | 18:06 |
| *** jaugustine has joined #openstack-nova | 18:06 | |
| openstackgerrit | Kam Nasim proposed openstack/nova: Fixes exception during a swap to no swap resize https://review.openstack.org/300616 | 18:06 |
| dansmith | vladikr: but only after attach supports tag right? | 18:06 |
| vladikr | dansmith, yeah | 18:06 |
| *** shaohe_feng has joined #openstack-nova | 18:06 | |
| *** sneti has joined #openstack-nova | 18:07 | |
| dansmith | vladikr: but when that happens you'll have to remove that existence check | 18:07 |
| dansmith | or delete it first or something | 18:07 |
| vladikr | dansmith, probably.. yes. | 18:07 |
| *** diogogmt has quit IRC | 18:09 | |
| *** sneti has quit IRC | 18:10 | |
| *** diogogmt has joined #openstack-nova | 18:10 | |
| *** _ducttape_ has quit IRC | 18:10 | |
| *** timello has joined #openstack-nova | 18:13 | |
| *** shaohe_feng has quit IRC | 18:14 | |
| *** ctrath1 has quit IRC | 18:14 | |
| *** shaohe_feng has joined #openstack-nova | 18:15 | |
| *** ctrath has joined #openstack-nova | 18:15 | |
| *** Sukhdev_ has joined #openstack-nova | 18:16 | |
| openstackgerrit | Mikhail Feoktistov proposed openstack/nova: libvirt: virtuozzo instance resize support https://review.openstack.org/182257 | 18:17 |
| *** tblakeslee has joined #openstack-nova | 18:17 | |
| artom | dansmith, yeah, I'm good to roll on the manager/scheduler/api | 18:18 |
| dansmith | artom: sweet | 18:18 |
| artom | dansmith, wait, move the scheduler to the end? | 18:18 |
| artom | We're keeping the scheduler patch? | 18:18 |
| dansmith | artom: right, move it to the end but probably have to not merge it until post-newton when we have better infra to select nodes with a particular capability, but won't affect us being able to use this now | 18:19 |
| artom | dansmith, but... we won't need the scheduler filter if the API and manager do their checks, will we? Or you're using it as a basis for future capabilities-based work? | 18:20 |
| diana_clarke | Is there such a thing as a coverage report for Nova from a Tempest perspective? A way of determining the gaps in Tempest coverage for Nova? | 18:20 |
| *** sneti has joined #openstack-nova | 18:21 | |
| openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Improve help text for compute manager options https://review.openstack.org/329639 | 18:21 |
| dansmith | artom: I'm saying we cover our asses with the api and manager checks for now, but long-term we should have a scheduler filter also that helps us avoid picking a back compute host in a heterogeneous deployment, once we have things to base a decision on (i.e. capabilities) | 18:21 |
| dansmith | artom: it'll be an optimization against making poor decisions in the long run, but we don't really have good data to go on at the moment | 18:22 |
| *** hshiina has quit IRC | 18:22 | |
| *** lpetrut has quit IRC | 18:22 | |
| artom | dansmith, I think that sounds like what I said, so we probably understand the same thing ;) | 18:22 |
| dansmith | artom: so as long as we don't do something _wrong_ like put one of these on a vmware host, then we're okay | 18:22 |
| dansmith | artom: okay :) | 18:22 |
| openstackgerrit | Feodor Tersin proposed openstack/nova: libvirt: Fix wrong _is_booted_from_volume usages https://review.openstack.org/334609 | 18:23 |
| artom | dansmith, also, about the config drive - the first implementation of tagging that hopefully makes it in soon won't support attachment of tagged vnics/volumes, but you can definitely detach them | 18:23 |
| artom | To me that sounds like the config drive needs to be refreshed... | 18:23 |
| *** ravikama_ has quit IRC | 18:24 | |
| dansmith | artom: ah, good point, and you could re-attach something in the same place but for a different purpose | 18:24 |
| dansmith | which could be confusing | 18:24 |
| *** shaohe_feng has quit IRC | 18:24 | |
| *** sneti_ has joined #openstack-nova | 18:24 | |
| sudipto | mriedem, pcp can install on ubuntu/fedora/centos/rhel - via just a yum install or apt-get install as appropriate...however for suse it provides a direct download - in which case, do we need to include anything for suse for devstack? | 18:25 |
| *** shaohe_feng has joined #openstack-nova | 18:25 | |
| artom | dansmith, and you're saying we can't just recreate it every time because we don't persist the injected files after the initial boot request... | 18:26 |
| dansmith | right | 18:26 |
| dansmith | so we kinda need a merge/update type thing | 18:26 |
| artom | What's easier though, merge/update or persist the injected files? | 18:26 |
| dansmith | which is obviously a bit of a thing | 18:26 |
| dansmith | artom: well, I dunno to be honest | 18:26 |
| *** timello has quit IRC | 18:26 | |
| dansmith | artom: update config drive is not database or RPC-involved, which is .. good :) | 18:26 |
| *** ayoung has quit IRC | 18:27 | |
| artom | dansmith, hah, indeed :) Does that mean there's already something in place for update? | 18:27 |
| openstackgerrit | Paul Murray proposed openstack/nova: Add console auth object https://review.openstack.org/320063 | 18:27 |
| openstackgerrit | Paul Murray proposed openstack/nova: Add access_url to console_auth_tokens table https://review.openstack.org/334614 | 18:27 |
| dansmith | artom: there doesn't look like anything to me, so we'd have to do it I think | 18:27 |
| artom | Yeeeeyyy :( | 18:27 |
| dansmith | artom: tangent for a sec: | 18:28 |
| *** lpetrut has joined #openstack-nova | 18:28 | |
| dansmith | artom: the two things you can tag are block and network devices, yes? | 18:28 |
| artom | dansmith, yes | 18:28 |
| *** tonytan4ever has quit IRC | 18:28 | |
| dansmith | artom: (I could go look this up, but:) and you index them each how exactly? nic by PCI address and disk by something like uuid or what? | 18:28 |
| artom | dansmith, define index in that question | 18:29 |
| mriedem | sudipto: i think we skip it for suse | 18:29 |
| sudipto | mriedem, sure. | 18:29 |
| dansmith | artom: meaning, how does the user look at the metadata and find the associated device? | 18:29 |
| dansmith | artom: from inside the instance I mean, if I were to do it manually | 18:29 |
| artom | dansmith, only hardware metadata, so no UUID | 18:29 |
| artom | MAC and PCI address for vnics | 18:29 |
| artom | serial, path, stuff like that for disks | 18:30 |
| dansmith | s#and#and/or# | 18:30 |
| artom | ... wut? | 18:30 |
| artom | That's a lof of hashes and slashes... | 18:30 |
| vladikr | dansmith, that's already in bdm | 18:30 |
| dansmith | so for nic we'd likely have the same PCI address if we detatched and re-attached something else, but the mac would almost definitely be different unless we used the same port, which would mean the metadata applies anyway | 18:30 |
| dansmith | artom: you know sed lets you use any character other than / right? :) | 18:31 |
| artom | dansmith, huh, TIL, thanks :) | 18:31 |
| vladikr | dansmith, we are handling only pci addresses for now | 18:32 |
| dansmith | vladikr: so no mac for nics? | 18:32 |
| *** timello has joined #openstack-nova | 18:32 | |
| artom | (But can it use unicode emojis? :D ) | 18:32 |
| dansmith | artom: dunno :) | 18:32 |
| artom | Uh, there are definitely MACs | 18:32 |
| artom | So, I think it depends a lot on how libvirt does thing | 18:32 |
| *** ctrath has quit IRC | 18:32 | |
| artom | But yeah, the MAC is very likely to change | 18:32 |
| *** ctrath has joined #openstack-nova | 18:33 | |
| dansmith | ((HEAD)% echo foo | sed '💩foo💩bar💩' | 18:33 |
| dansmith | sed: -e expression #1, char 1: unknown command: `�' | 18:33 |
| artom | Unless it's the same port, as you said, in which case it's de facto the same NIC | 18:33 |
| *** Sukhdev_ has quit IRC | 18:33 | |
| artom | I love that you tried that :D | 18:33 |
| dansmith | I'm trying to gauge how big of a deal it is that we don't update the metadata after detach/attach of non-tag-supporting operations post-boot | 18:33 |
| *** PaulMurray has quit IRC | 18:34 | |
| dansmith | oh waut | 18:34 |
| artom | dansmith, just to be clear, in the API it's definitely updated | 18:34 |
| dansmith | ((HEAD)% echo foo | sed 's💩foo💩bar💩' | 18:34 |
| dansmith | sed: -e expression #1, char 2: delimiter character is not a single-byte character | 18:34 |
| *** rcernin has quit IRC | 18:34 | |
| dansmith | artom: right, I know | 18:34 |
| artom | This is a case of the config drive lagging behing after detaching a thing, even after instance reboot | 18:34 |
| *** shaohe_feng has quit IRC | 18:34 | |
| artom | Forever, essentially | 18:35 |
| *** shaohe_feng has joined #openstack-nova | 18:35 | |
| dansmith | artom: right, good point, it has to lag before a reboot | 18:36 |
| dansmith | artom: so it can lag, we should reduce that lag to only "since last boot" and not "since inception" but maybe that's an okay caveat at the moment | 18:36 |
| artom | dansmith, yeah, we don't do anything while the instance is running - it's probably not a good idea to play with a mounted filesystem "from underneath" while it's mounted | 18:37 |
| dansmith | yeah, can't do that for sure | 18:37 |
| artom | But wait, injected files isn't persisted... | 18:37 |
| artom | Oh, right, the config drive image is | 18:37 |
| artom | Never mind | 18:37 |
| dansmith | that's why we need update and not replace | 18:37 |
| dansmith | right | 18:37 |
| dansmith | okay, so: | 18:37 |
| dansmith | I think we should make sure to document this as a known issue, probably in your reno wherever that is in this stack, | 18:38 |
| *** tonytan4ever has joined #openstack-nova | 18:38 | |
| dansmith | and I seriously do want you to work on updating the config drive after merging this, | 18:38 |
| dansmith | because having metadata be stale forever is not okay, IMHO | 18:38 |
| dansmith | but if you pinky swear I shan't argue that we should resolve it before merge | 18:38 |
| artom | I swear on the back of this bacon. | 18:39 |
| *** lpetrut has quit IRC | 18:39 | |
| dansmith | heh | 18:39 |
| artom | (We could pass it off as a bug - "no no, we 4 realz didn't think of it, IRC logs notwithstanding, we *just* noticed the config drive is stale) | 18:39 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Add microversion support to image metadata unit tests https://review.openstack.org/333625 | 18:40 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Add microversion support to images unit tests https://review.openstack.org/333626 | 18:40 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Restrict Metadata to Lower Case Keys https://review.openstack.org/329697 | 18:40 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Add microversion support to server metadata unit tests https://review.openstack.org/333551 | 18:40 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Add microversion support to server actions unit tests https://review.openstack.org/333568 | 18:40 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Add microversion support to flavors extraspecs unit test https://review.openstack.org/333590 | 18:40 |
| dansmith | artom: heh, yeah.. well, known issue in reno followed by a bug is reasonably legit I think | 18:40 |
| *** salv-orlando has quit IRC | 18:40 | |
| artom | dansmith, sweet, thanks for being cool about this :) | 18:40 |
| *** sudipto has quit IRC | 18:41 | |
| dansmith | well, I'm just one person of course, gotta convince the others | 18:41 |
| artom | I could offer them some of this delicious bacon I just swore on :) | 18:42 |
| artom | The swearing adds flavor :D | 18:42 |
| dansmith | heh | 18:42 |
| dansmith | bacon is rarely hard to give away | 18:42 |
| openstackgerrit | Mikhail Feoktistov proposed openstack/nova: libvirt: support user password settings in virtuozzo https://review.openstack.org/330643 | 18:43 |
| *** sudipto has joined #openstack-nova | 18:43 | |
| *** pacoblox has joined #openstack-nova | 18:43 | |
| *** Hosam has quit IRC | 18:44 | |
| *** shaohe_feng has quit IRC | 18:45 | |
| *** shaohe_feng has joined #openstack-nova | 18:45 | |
| openstackgerrit | Mikhail Feoktistov proposed openstack/nova: libvirt: virtuozzo instance resize support https://review.openstack.org/182257 | 18:46 |
| *** pacoblox has quit IRC | 18:47 | |
| *** pacoblox has joined #openstack-nova | 18:49 | |
| *** kfarr_ has quit IRC | 18:50 | |
| *** sudipto has quit IRC | 18:51 | |
| *** pradk has quit IRC | 18:54 | |
| *** tblakeslee has quit IRC | 18:54 | |
| *** shaohe_feng has quit IRC | 18:56 | |
| mriedem | GET sdague | 18:56 |
| mriedem | 404 | 18:56 |
| *** shaohe_feng has joined #openstack-nova | 18:56 | |
| *** pradk has joined #openstack-nova | 18:56 | |
| *** tblakeslee has joined #openstack-nova | 18:57 | |
| *** pacoblox has quit IRC | 18:57 | |
| *** paul-carlton2 has joined #openstack-nova | 18:57 | |
| openstackgerrit | Jens Rosenboom proposed openstack/nova: Tests in test_ipv6 are broken https://review.openstack.org/333841 | 18:58 |
| *** paul-carlton2 has quit IRC | 18:59 | |
| *** rlrossit has quit IRC | 19:00 | |
| *** paul-carlton2 has joined #openstack-nova | 19:00 | |
| *** paul-carlton2 has quit IRC | 19:01 | |
| *** claudiub has joined #openstack-nova | 19:01 | |
| *** svenkat has joined #openstack-nova | 19:02 | |
| *** sudipto has joined #openstack-nova | 19:03 | |
| mriedem | or cdent | 19:03 |
| mriedem | or jaypipes | 19:04 |
| mriedem | gdi | 19:04 |
| *** rcernin has joined #openstack-nova | 19:04 | |
| *** sacharya_ has joined #openstack-nova | 19:04 | |
| *** mfedosin has quit IRC | 19:05 | |
| sudipto | mriedem, trying to understand your comment on https://review.openstack.org/#/c/203163/27/nova/virt/libvirt/pcp_utils.py - the last 2 comments...you mean there should be more severity than an exception? | 19:05 |
| *** shaohe_feng has quit IRC | 19:05 | |
| svenkat | Can anyone look at https://review.openstack.org/#/c/331707/ its out for review and fixes problem with evacuate under a speciic case. | 19:06 |
| *** shaohe_feng has joined #openstack-nova | 19:06 | |
| *** sacharya has quit IRC | 19:07 | |
| *** pacoblox has joined #openstack-nova | 19:07 | |
| mriedem | sudipto: less severity | 19:08 |
| mriedem | sudipto: see https://specs.openstack.org/openstack/openstack-specs/specs/log-guidelines.html | 19:08 |
| mriedem | logging at error level and dropping a stacktrace generally means page the admin/operator of the cloud because things are broken | 19:08 |
| mriedem | the things in https://review.openstack.org/#/c/203163/27/nova/virt/libvirt/pcp_utils.py seem like misconfiguration warnings | 19:09 |
| sudipto | mriedem, got it! Thx. Yeah i should not be raising an exception there! | 19:09 |
| mriedem | well it's not raising an exception, it's logging an exception at error level with a stacktrace | 19:09 |
| sudipto | mriedem, yeah...sorry...typo. | 19:09 |
| mriedem | is this called in a loop? | 19:09 |
| *** pacoblox has quit IRC | 19:09 | |
| sudipto | mriedem, it's a generic module but let's say if it's used by the memory bandwidth module - then this would be called every 1 min...given there's a test on the version of pcp for this memory bandwidth metric - ideally we should not be hitting this code at all. However, given there's situation where more events are tracked via this module (can be any perf event) - this could potentially get logged. | 19:11 |
| *** akshai has quit IRC | 19:12 | |
| *** akshai has joined #openstack-nova | 19:12 | |
| *** salv-orlando has joined #openstack-nova | 19:12 | |
| mriedem | sudipto: can't pcp be down? | 19:13 |
| mriedem | it's a daemon right? | 19:14 |
| *** ducttape_ has joined #openstack-nova | 19:14 | |
| sudipto | mriedem, yeah good point...i guess that case needs to be handled - where pcp daemon is stopped in between... | 19:15 |
| sudipto | mriedem, i will have that handled... | 19:15 |
| *** shaohe_feng has quit IRC | 19:15 | |
| *** pradk has quit IRC | 19:16 | |
| *** akshai has quit IRC | 19:16 | |
| *** shaohe_feng has joined #openstack-nova | 19:16 | |
| *** salv-orlando has quit IRC | 19:17 | |
| sudipto | mriedem, i guess it's a fair assumption that if the pcpd is stopped in between, it would require the n-cpu to be restarted in order to make the monitor work? | 19:17 |
| mriedem | sudipto: why? | 19:18 |
| mriedem | because of: self.pmfg = PMAPI.fetchgroup(C_API.PM_CONTEXT_HOST, "local:") ? | 19:19 |
| mriedem | as in we have to reconnect? | 19:19 |
| sudipto | mriedem, yeah | 19:19 |
| *** ihrachys has joined #openstack-nova | 19:19 | |
| sudipto | mriedem, but let me experiment around that... | 19:19 |
| sudipto | mriedem, it might be possible to use the same fd ... | 19:19 |
| mriedem | sudipto: we could set a dirty flag if we lose the connection and then try to reconnect | 19:19 |
| sudipto | mriedem, sure... | 19:20 |
| mriedem | rather than restarting n-cpu | 19:20 |
| *** Sukhdev_ has joined #openstack-nova | 19:20 | |
| artom | With all this talk of pcp, can... can I just leave this here: https://www.youtube.com/watch?v=Ah7ApyeyneY | 19:23 |
| *** oanson has joined #openstack-nova | 19:24 | |
| *** sacharya has joined #openstack-nova | 19:24 | |
| *** shaohe_feng has quit IRC | 19:26 | |
| mriedem | sudipto: shouldn't https://review.openstack.org/#/c/329783/ come before https://review.openstack.org/#/c/266773/ ? | 19:26 |
| *** shaohe_feng has joined #openstack-nova | 19:27 | |
| sudipto | mriedem, umm if it does come before that then we will start hitting the NotImplementedError, no? | 19:27 |
| *** salv-orlando has joined #openstack-nova | 19:27 | |
| *** sacharya_ has quit IRC | 19:28 | |
| mriedem | oh i guess because of https://review.openstack.org/#/c/329783/8/nova/compute/monitors/numa_mem_bw/virt_driver.py@61 | 19:28 |
| mriedem | so the bw monitor calls back into the method in the virt driver... | 19:28 |
| sudipto | yeah... | 19:28 |
| *** pradk has joined #openstack-nova | 19:28 | |
| mriedem | i'm also not a fan of the mutable get_current_memory_bw thing | 19:29 |
| *** pradk has quit IRC | 19:29 | |
| mriedem | it's not returning anything, it's passing an object in by reference to mutate it | 19:29 |
| *** moshele has joined #openstack-nova | 19:29 | |
| sudipto | mriedem, yeah that was basically derived out of the discussions during the spec review. danpb wanted to make sure that the libvirt driver is able to send some sort of an object back - instead of a dicts... | 19:30 |
| *** mfedosin has joined #openstack-nova | 19:30 | |
| mriedem | yeah but it doesn't send anything back | 19:30 |
| sudipto | mriedem, yeah - i guess your concern is - what if the values aren't mutated into it? | 19:30 |
| mriedem | like for cpu, it calls stats = self.driver.get_host_cpu_stats() | 19:31 |
| mriedem | and then uses stats to modify the monitor object for cpu | 19:31 |
| mriedem | which is self._data = {} | 19:31 |
| mriedem | so not an object, but same idea | 19:31 |
| mriedem | where is ResourceMonitorError ever handled by anything? | 19:31 |
| *** Jeffrey4l__ has joined #openstack-nova | 19:32 | |
| *** bvanhav has quit IRC | 19:32 | |
| sudipto | mriedem, yeah however, that design has an issue because it passes a dict back to the monitor - now let's say it's OK for linux to have those keys - but for something like hyperv has other representations...in such a case the cpu monitor according to me is not going to work in it's present form... | 19:32 |
| sudipto | mriedem, no i don't think anything handles the ResourceMonitorError | 19:33 |
| *** sneti_ has quit IRC | 19:34 | |
| mriedem | hmm, i guess i see the point, i'd expect to handle that like we do for the MigrateData object, which has a common base class and then hypervisor specific subclasses | 19:34 |
| *** Jeffrey4l_ has quit IRC | 19:34 | |
| sudipto | mriedem, ok... | 19:34 |
| *** ihrachys has quit IRC | 19:35 | |
| *** ociuhandu has quit IRC | 19:36 | |
| *** akshai has joined #openstack-nova | 19:36 | |
| *** shaohe_feng has quit IRC | 19:36 | |
| *** harlowja has quit IRC | 19:36 | |
| dansmith | mriedem: I just said a bunch of those things on the reviews | 19:37 |
| *** ctrath has quit IRC | 19:37 | |
| dansmith | mriedem: although I don't think we need a hypervisor-specific subclass of an object.. at least, I hope not | 19:37 |
| *** shaohe_feng has joined #openstack-nova | 19:37 | |
| *** svenkat has quit IRC | 19:38 | |
| sudipto | dansmith, agreed. I actually thought of having one method that would do both metrics - for max and for current bw since they are mostly identical. I will make that change. | 19:38 |
| *** ctrath has joined #openstack-nova | 19:38 | |
| sudipto | dansmith, however i am not sure if the cpu monitor should be extended for this one, given they are two individual metrics? | 19:38 |
| *** sdake has quit IRC | 19:38 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: numa: Fixes NUMA topology related unit tests https://review.openstack.org/278835 | 19:38 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: libvirt: fixes python 3 related unit tests https://review.openstack.org/278834 | 19:38 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Fixes python 3 unit tests https://review.openstack.org/278810 | 19:38 |
| *** amotoki has joined #openstack-nova | 19:39 | |
| sudipto | dansmith, you also prefer a similar dict based exchange between the monitor and the driver module then? | 19:39 |
| dansmith | sudipto: yes | 19:39 |
| dansmith | sudipto: I don't feel strongly about collapsing them or not | 19:39 |
| dansmith | it's fine if they need to be separate, but the memory one should not require 2 (and more later) calls.. for sure | 19:40 |
| *** sdake has joined #openstack-nova | 19:40 | |
| *** ihrachys has joined #openstack-nova | 19:41 | |
| sudipto | dansmith, dict exchanges make the keys specific for the libvirt driver, no? | 19:41 |
| dansmith | sudipto: how is it not going to be that way? an object doesn't fix that, unless you wrap the virt-specific code in the object | 19:42 |
| *** ayoung has joined #openstack-nova | 19:42 | |
| *** oanson has quit IRC | 19:43 | |
| sudipto | dansmith, ok, my consideration was around - abstracting the metric name (to obtain the bandwidth) inside the virt driver and only exchange data in terms of metric_object fields (in this case numa_*)...however that name could be also passed in the form a dict i suppose... | 19:44 |
| *** amotoki has quit IRC | 19:44 | |
| *** yassine__ has quit IRC | 19:44 | |
| dansmith | oh that reminds me of something I forgot to say | 19:44 |
| *** shaohe_feng has quit IRC | 19:46 | |
| dansmith | sudipto: I get your point, but you can do most of your virt-specific massaging in your method to return the stats | 19:46 |
| dansmith | sudipto: and return a hopefully normalized set of things from there I think | 19:47 |
| *** shaohe_feng has joined #openstack-nova | 19:47 | |
| dansmith | sudipto: this whole thing is far too simplistic anyway I think, so you're really just looking for relative scalar comparisons, IMHO | 19:47 |
| *** svenkat has joined #openstack-nova | 19:47 | |
| sudipto | dansmith, this is not the same as the cpu monitor btw...it's reported against a NUMA node and it's not for memory (there's a different bp for that) - but is for the memory bandwidth...(which is tracked a layer below). | 19:48 |
| sudipto | dansmith, ok... | 19:48 |
| *** derekh_afk is now known as derekh | 19:48 | |
| dansmith | sudipto: I don't see the distinction | 19:48 |
| *** sneti_ has joined #openstack-nova | 19:48 | |
| dansmith | sudipto: why not return "memory related crap" in a single call, which can include per-node bandwidth and "color of the DIMMs" if you want :) | 19:49 |
| *** mfedosin has quit IRC | 19:49 | |
| *** jlanoux has quit IRC | 19:49 | |
| sudipto | dansmith, absolutely, i am not debating collapsing that into one call for sure. However, i was just talking about the fancy naming comment :) | 19:49 |
| dansmith | I know | 19:50 |
| *** mfedosin has joined #openstack-nova | 19:50 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: policy: Replaces 'authorize' in nova-api (part 4) https://review.openstack.org/330036 | 19:50 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: policy: Replaces 'authorize' in nova-api (part 5) https://review.openstack.org/333514 | 19:50 |
| *** fawadkhaliq has quit IRC | 19:51 | |
| mriedem | populate_metrics makes me sad | 19:51 |
| *** fawadkhaliq has joined #openstack-nova | 19:51 | |
| mriedem | pass in a MonitorMetricList object and have each monitor add objects to that list, | 19:51 |
| mriedem | but one monitor could like, reset the list | 19:52 |
| mriedem | and remove the metrics that the other monitors added | 19:52 |
| *** harlowja has joined #openstack-nova | 19:52 | |
| sudipto | mriedem, that could happen if you have two monitors reporting the same metric? | 19:53 |
| mriedem | that too | 19:53 |
| mriedem | i just in general don't like populate type methods | 19:53 |
| mriedem | "here is this thing that i really depend on being correct, you can modify it, but please don't break it for me" | 19:53 |
| sudipto | mriedem, i think that's not allowed...(i do remember some of the test cases Jay Pipes had written around it)... | 19:54 |
| tdurakov | dansmith: hi, seen your comments, thanks for reviewing, so I check version here https://review.openstack.org/#/c/332124/11/nova/compute/rpcapi.py | 19:54 |
| tdurakov | dansmith: as it's new rpc method, with no previous version | 19:54 |
| *** akshai_ has joined #openstack-nova | 19:54 | |
| sudipto | mriedem, ok - but the problem is - some of them may not be setting the same fields of the metric_object... in such a case, the other approach could have been to have a getattr('xyz', none) - kinda check in the get_metrics call (erstwhile)... | 19:55 |
| dansmith | tdurakov: yeah, you should not allow the call to complete if the version is less than the one added | 19:55 |
| tdurakov | dansmith: ok, will update patch shortly | 19:55 |
| sudipto | mriedem, i think my previous design was that (really months old now), but i will try to dig into those old conversations and find out why this approach was chosen... | 19:55 |
| *** moshele has quit IRC | 19:56 | |
| *** ihrachys has quit IRC | 19:56 | |
| *** fawadkhaliq has quit IRC | 19:56 | |
| openstackgerrit | dane-fichter proposed openstack/nova: Improve image signature verification failure notification https://review.openstack.org/332802 | 19:56 |
| *** shaohe_feng has quit IRC | 19:56 | |
| dansmith | tdurakov: thanks | 19:57 |
| *** sambetts is now known as sambetts|afk | 19:57 | |
| dansmith | tdurakov: I'm walking away for a bit, but will try to look when I get back | 19:57 |
| tdurakov | sure | 19:57 |
| mriedem | ew and ComputeNode.metrics is still just a json blob, we should make that a MonitorMetricList at some point | 19:57 |
| sudipto | mriedem, yeah - versioned notifications i suppose. | 19:58 |
| mriedem | no, just, we have an object to model these | 19:58 |
| mriedem | we should use the object refs | 19:58 |
| *** akshai has quit IRC | 19:58 | |
| mriedem | else the caller of ComputeNode.metrics has to convert it to a MonitorMetricList explicitly | 19:58 |
| mriedem | yeah, HostState in the scheduler | 19:59 |
| mriedem | self.metrics = objects.MonitorMetricList.from_json(compute.metrics) | 19:59 |
| mriedem | exactly what i expected to find | 19:59 |
| sudipto | mriedem, ok, the other thing i was stating is - when we populate this metrics into the compute node, we are explicitly converting it into a json blob. if we make that an object - it would be alright. | 20:00 |
| *** shaohe_feng has joined #openstack-nova | 20:00 | |
| cfriesen | I'm hitting something weird with devstack...when I run "stack.sh" it's downgrading my oslo.concurrency to 3.7.0, at which point nova chokes since it wants 3.7.1. I'm running stable/mitaka branch of devstack, with a customized mitaka nova repo. | 20:00 |
| sudipto | mriedem, however in order to make that an object, we would have to bump the MonitorMetricList object to include host_ip and some two other fields...that's on my list as a TO-DO under the notifications BP. | 20:00 |
| *** kfarr has joined #openstack-nova | 20:01 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: compute: fixes python 3 related unit tests https://review.openstack.org/300262 | 20:01 |
| sudipto | mriedem, talking about this code: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L479 | 20:01 |
| cfriesen | does devstack have a list of requirements somewhere that I need to update? why would it downgrade from an already-installed 3.7.1? | 20:03 |
| *** tongli has quit IRC | 20:04 | |
| *** Sukhdev_ has quit IRC | 20:04 | |
| mriedem | sudipto: yeah i saw it | 20:04 |
| mriedem | which is what got me going down the object / json blob path | 20:05 |
| mriedem | of rage | 20:05 |
| sudipto | mriedem, ok...yeah i wish to fix that too...however - the non-prio dates close on thursday :( | 20:05 |
| *** svenkat_ has joined #openstack-nova | 20:06 | |
| *** svenkat has quit IRC | 20:06 | |
| *** svenkat_ is now known as svenkat | 20:06 | |
| sudipto | mriedem, dansmith just for my clarification, i am trying to understand why mutating the list object is a bad idea? | 20:06 |
| sudipto | between the monitor and the virt drivers that is? | 20:07 |
| *** shaohe_feng has quit IRC | 20:07 | |
| *** shaohe_feng has joined #openstack-nova | 20:08 | |
| *** woodster_ has joined #openstack-nova | 20:08 | |
| sudipto | is it just with regards to making the calculations more like the cpu monitor or is there a technical glitch that i am failing to understand? :( | 20:08 |
| mriedem | sudipto: it's not that it doesn't work, i just don't like that design pattern | 20:09 |
| sudipto | mriedem, ok.. | 20:10 |
| mriedem | as in i tend to like my builders separate from the providers | 20:11 |
| mriedem | the builder calls an interface to get some metrics, and uses the results to build it's list | 20:11 |
| mriedem | rather than delegating that to a random monitor object | 20:11 |
| mriedem | or virt driver | 20:11 |
| mriedem | but that's just me | 20:11 |
| sudipto | hmm ok... | 20:12 |
| mriedem | because if you have to change something on how the building is done, you have to do it in all of the virt drivers rather than a single place | 20:12 |
| sudipto | hmm ok makes sense... | 20:12 |
| sudipto | mriedem, dansmith appreciate your time in going through the patches. I think it's getting hard for me to keep my eyes open now (1:40 AM) - despite the euro cup on TV...I shall try and address all the comments by tomorrow. | 20:13 |
| mriedem | and i don't like get_* methods that don't return anything :) | 20:13 |
| mriedem | sudipto: get some sleep | 20:13 |
| sudipto | mriedem, ok thanks again!! | 20:13 |
| mriedem | sudipto: there is another kind of PCP that will keep you awake | 20:13 |
| sudipto | mriedem, lol yeah - i know what you mean :) | 20:13 |
| *** GB21 has quit IRC | 20:16 | |
| *** shaohe_feng has quit IRC | 20:17 | |
| *** shaohe_feng has joined #openstack-nova | 20:18 | |
| openstackgerrit | Giridhar Jayavelu proposed openstack/nova: VMware: support limits via image meta data https://review.openstack.org/180942 | 20:18 |
| openstackgerrit | Giridhar Jayavelu proposed openstack/nova: Objects: add limits, reservations and shares to ImageMetaProps object https://review.openstack.org/188321 | 20:18 |
| *** sudipto has quit IRC | 20:19 | |
| *** sdake_ has joined #openstack-nova | 20:19 | |
| *** mfedosin has quit IRC | 20:21 | |
| *** sdake has quit IRC | 20:22 | |
| *** ociuhandu has joined #openstack-nova | 20:22 | |
| *** chandankumar has quit IRC | 20:23 | |
| *** rlrossit has joined #openstack-nova | 20:24 | |
| *** shaohe_feng has quit IRC | 20:27 | |
| *** irenab has quit IRC | 20:27 | |
| *** smatzek has quit IRC | 20:30 | |
| *** shaohe_feng has joined #openstack-nova | 20:30 | |
| *** derekh has quit IRC | 20:33 | |
| *** GB21 has joined #openstack-nova | 20:34 | |
| *** smatzek has joined #openstack-nova | 20:35 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Added support for new block device format in vmops https://review.openstack.org/246299 | 20:37 |
| *** oanson has joined #openstack-nova | 20:37 | |
| *** shaohe_feng has quit IRC | 20:37 | |
| *** shaohe_feng has joined #openstack-nova | 20:38 | |
| *** fawadkhaliq has joined #openstack-nova | 20:39 | |
| *** fawadkhaliq has quit IRC | 20:39 | |
| *** Apoorva has quit IRC | 20:40 | |
| *** Apoorva has joined #openstack-nova | 20:40 | |
| *** fawadkhaliq has joined #openstack-nova | 20:40 | |
| *** svenkat has quit IRC | 20:43 | |
| *** fawadkhaliq has quit IRC | 20:45 | |
| *** yamahata has quit IRC | 20:46 | |
| *** pacoblox has joined #openstack-nova | 20:46 | |
| *** yamahata has joined #openstack-nova | 20:46 | |
| *** yamahata has quit IRC | 20:48 | |
| *** shaohe_feng has quit IRC | 20:48 | |
| *** yamahata has joined #openstack-nova | 20:48 | |
| *** tbachman_ has joined #openstack-nova | 20:48 | |
| *** tbachman has quit IRC | 20:49 | |
| *** tbachman_ is now known as tbachman | 20:49 | |
| *** shaohe_feng has joined #openstack-nova | 20:49 | |
| *** sdake has joined #openstack-nova | 20:49 | |
| *** irenab has joined #openstack-nova | 20:50 | |
| mriedem | dansmith: i actually think numa_mem_bw_if_you_have_numa_otherwise_this_is_not_so_useful_for_you_kthx is a very useful name | 20:51 |
| openstackgerrit | Mikhail Chernik proposed openstack/nova: Fix require thread poicy for multi-NUMA computes https://review.openstack.org/334659 | 20:52 |
| *** edmondsw has quit IRC | 20:52 | |
| *** sdake_ has quit IRC | 20:53 | |
| *** ctrath has quit IRC | 20:53 | |
| *** catintheroof has joined #openstack-nova | 20:55 | |
| *** mlavalle has left #openstack-nova | 20:55 | |
| *** sneti_ has quit IRC | 20:56 | |
| dansmith | heh | 20:58 |
| *** smatzek has quit IRC | 20:58 | |
| *** thorst_ has quit IRC | 20:58 | |
| *** shaohe_feng has quit IRC | 20:58 | |
| *** ctrath has joined #openstack-nova | 20:58 | |
| *** shaohe_feng has joined #openstack-nova | 20:58 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: WIP: policy: clean-up https://review.openstack.org/333925 | 20:59 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: policy: Replaces 'authorize' in nova-api (part 5) https://review.openstack.org/333514 | 20:59 |
| *** pacoblox has quit IRC | 21:01 | |
| *** kfarr has quit IRC | 21:01 | |
| *** mvk_ has joined #openstack-nova | 21:01 | |
| *** fawadkhaliq has joined #openstack-nova | 21:01 | |
| *** lchen_ has quit IRC | 21:02 | |
| *** cdelatte has quit IRC | 21:03 | |
| *** lchen_ has joined #openstack-nova | 21:03 | |
| *** cdelatte has joined #openstack-nova | 21:03 | |
| *** mkrcmari__ has joined #openstack-nova | 21:05 | |
| *** lucas-afk has quit IRC | 21:06 | |
| *** aysyd has quit IRC | 21:07 | |
| *** raildo is now known as raildo-afk | 21:07 | |
| *** mvk has joined #openstack-nova | 21:07 | |
| *** shaohe_feng has quit IRC | 21:08 | |
| *** mvk_ has quit IRC | 21:09 | |
| *** sneti_ has joined #openstack-nova | 21:09 | |
| *** shaohe_feng has joined #openstack-nova | 21:09 | |
| *** cleong has quit IRC | 21:09 | |
| *** mkrcmari__ has quit IRC | 21:10 | |
| openstackgerrit | Timofey Durakov proposed openstack/nova: live_migration_cleanup method introduced https://review.openstack.org/302611 | 21:11 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: Remove unused migrate_data param from driver cleanup and destroy https://review.openstack.org/280653 | 21:11 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: call pre_live_migration from conductor https://review.openstack.org/291160 | 21:11 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: centralize checks before live-migration https://review.openstack.org/332124 | 21:11 |
| tdurakov | mriedem, alaski, dansmith, fyi: first patch in the chain above^ is updated, all comments are addressed | 21:11 |
| *** sdake_ has joined #openstack-nova | 21:12 | |
| alaski | okay | 21:12 |
| *** manikanta has quit IRC | 21:12 | |
| dansmith | tdurakov: so why did you split that one thing out? | 21:13 |
| *** lucasagomes has joined #openstack-nova | 21:13 | |
| tdurakov | dansmith: which one? | 21:13 |
| *** sdake has quit IRC | 21:13 | |
| dansmith | tdurakov: _live_migrate_destination_check() | 21:13 |
| dansmith | is split from the parent, but for no real reason that I can see, and unrelated to adding the cleanup thing? | 21:14 |
| mriedem | dansmith: the device tagging stuff from the api, the tags go on what? ports that we create? | 21:14 |
| dansmith | mriedem: ports and bdms currently | 21:14 |
| dansmith | mriedem: eventually pci devices too | 21:14 |
| mriedem | ok, just going through the rest api change now | 21:15 |
| mriedem | finding some issues | 21:15 |
| mriedem | after the get me a network rest api change i did i'm very keen on all of this crap, plus everything sdague is making me review | 21:15 |
| mriedem | he doesn't give me a choice | 21:15 |
| *** sdake has joined #openstack-nova | 21:16 | |
| dansmith | very keen on being able to figure out which port is which you mean? | 21:16 |
| mriedem | very keen on all of the microversion request validation crap | 21:16 |
| mriedem | and extension folding stuff | 21:16 |
| dansmith | okay | 21:16 |
| tdurakov | dansmith: trying to make method shorter, and a bit cleaner, could unsplit it | 21:16 |
| mriedem | e.g. he changed the bdmv2 schema in an unversioned way | 21:16 |
| mriedem | dansmith: plus, 0 tests | 21:17 |
| dansmith | tdurakov: it doesn't help, IMHO.. just seems like unrelated noise | 21:17 |
| *** sdake_ has quit IRC | 21:17 | |
| tdurakov | dansmith: 5 min | 21:17 |
| tdurakov | will update ps | 21:17 |
| *** eharney has quit IRC | 21:17 | |
| dansmith | tdurakov: I have some other things I think, so hold on | 21:18 |
| *** ivase has quit IRC | 21:18 | |
| tdurakov | dansmith: ok, will wait for comments then | 21:18 |
| *** shaohe_feng has quit IRC | 21:18 | |
| mriedem | artom: your device tags rest api change has 0 tests | 21:19 |
| *** ivase has joined #openstack-nova | 21:19 | |
| *** rlrossit has quit IRC | 21:19 | |
| *** shaohe_feng has joined #openstack-nova | 21:19 | |
| *** lucasagomes has quit IRC | 21:19 | |
| *** p01nt3r75 has joined #openstack-nova | 21:20 | |
| artom | mriedem, yeah, I'll have to look up existing examples on how to do those | 21:21 |
| mriedem | artom: https://review.openstack.org/#/c/316398/ | 21:22 |
| mriedem | ^ is probably a lot of what you'd need to get started | 21:22 |
| mriedem | also, do you have anything changing https://github.com/openstack/nova/blob/master/nova/block_device.py#L176 ? | 21:23 |
| mriedem | to populate the tag in the bdm dict? | 21:23 |
| *** ivase has quit IRC | 21:24 | |
| *** fawadkhaliq has quit IRC | 21:24 | |
| artom | mriedem, IIRC that's "magic" | 21:24 |
| artom | Let me find you the code bit | 21:24 |
| mriedem | bdm black magic? | 21:24 |
| mriedem | sounds about right | 21:24 |
| artom | mriedem, https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L514 | 21:26 |
| artom | I think that's it | 21:26 |
| artom | It basically passes the whole dict allong | 21:26 |
| artom | *along | 21:26 |
| *** lucasagomes has joined #openstack-nova | 21:27 | |
| mriedem | hmm https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/block_device_mapping.py#L49 | 21:27 |
| mriedem | then what is ^ for? | 21:27 |
| mriedem | and is that before we hit https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L514 | 21:28 |
| mriedem | artom: yeah https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L489 | 21:28 |
| mriedem | the bdm extension is called before it gets the bdm list from the create_kwargs | 21:29 |
| mriedem | to massage it | 21:29 |
| *** shaohe_feng has quit IRC | 21:29 | |
| artom | It's been so long since I actually wrote this patch that I forgot most of the fine-grained logic :/ | 21:29 |
| *** shaohe_feng has joined #openstack-nova | 21:30 | |
| artom | It definitely gets passed to the compute api eventually, but I couldn't tell you know right this moment... | 21:30 |
| artom | *you how | 21:30 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/block_device.py#L176 is mostly validation i guess | 21:30 |
| mriedem | and for everything that passes validation it goes back in the block device dict | 21:30 |
| * artom nods fake-knowingly | 21:31 | |
| mriedem | you win this time, artom | 21:31 |
| artom | Haha :D Thanks for the comments, btw - I'm in the process of coding up the changes to the manager and API that we agreed on with Dan, I'll incorporate your feedback into them as well | 21:32 |
| *** thorst_ has joined #openstack-nova | 21:34 | |
| *** _ducttape_ has joined #openstack-nova | 21:34 | |
| *** mvk_ has joined #openstack-nova | 21:35 | |
| *** permalac_ has joined #openstack-nova | 21:35 | |
| *** permalac has quit IRC | 21:36 | |
| tdurakov | dansmith: are you around? | 21:36 |
| dansmith | tdurakov: yeah | 21:36 |
| tdurakov | dansmith: what do you think would be better? separate method or extra param? | 21:36 |
| tdurakov | I'd prefer method | 21:36 |
| dansmith | tdurakov: I think a separate method is cleaner, but maybe slightly more work, but..yeah if you're good with it | 21:37 |
| dansmith | also makes removing it later easier.. just nuke the old one | 21:37 |
| *** smatzek has joined #openstack-nova | 21:37 | |
| tdurakov | dansmith: acked, btw haven't seen comments about version object history comments before.:) will change that either | 21:38 |
| *** ducttape_ has quit IRC | 21:38 | |
| dansmith | tdurakov: service version you mean? | 21:38 |
| *** thorst_ has quit IRC | 21:38 | |
| *** mvk has quit IRC | 21:38 | |
| tdurakov | dansmith: yeah | 21:38 |
| dansmith | tdurakov: well, it's a bit of a losing proposition once there was an example in the history :D | 21:39 |
| *** shaohe_feng has quit IRC | 21:39 | |
| dansmith | tdurakov: it's mostly a personal nit | 21:39 |
| *** fawadkhaliq has joined #openstack-nova | 21:39 | |
| dansmith | tdurakov: I should sneak in there and fix the other ones some night real late :D | 21:39 |
| tdurakov | :-D | 21:40 |
| *** shaohe_feng has joined #openstack-nova | 21:40 | |
| tdurakov | dansmith: need to go now, will address comments tomorrow, thank you | 21:40 |
| dansmith | tdurakov: okay poke me when I should look again | 21:40 |
| *** mkrcmari__ has joined #openstack-nova | 21:41 | |
| *** mkrcmari__ has quit IRC | 21:43 | |
| *** fawadkhaliq has quit IRC | 21:43 | |
| *** smatzek has quit IRC | 21:43 | |
| *** mvk has joined #openstack-nova | 21:44 | |
| *** jaugustine has quit IRC | 21:44 | |
| *** mvk_ has quit IRC | 21:44 | |
| artom | We don't have a metadata JSON schema documentation somewhere, do we? | 21:44 |
| artom | So that I can put something along the lines of "the full metadata schema can be found at <blah>" | 21:45 |
| artom | And also update <blah> to include the new tagging stuff | 21:45 |
| *** fawadkhaliq has joined #openstack-nova | 21:45 | |
| * dansmith doesn't know | 21:46 | |
| *** oanson has quit IRC | 21:46 | |
| mriedem | "Unable to set 'kernel_id' to 'None'. Reason: None is not of type u'string'" | 21:47 |
| mriedem | i'm pretty sure we had a duplicate bug for this | 21:47 |
| mriedem | nikhil: ^? | 21:47 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1596602 | 21:47 |
| openstack | Launchpad bug 1596602 in OpenStack Compute (nova) "Instance Snapshot failure" [Undecided,New] | 21:47 |
| *** tblakeslee has quit IRC | 21:49 | |
| *** fawadkhaliq has quit IRC | 21:49 | |
| *** shaohe_feng has quit IRC | 21:49 | |
| *** _ducttape_ has quit IRC | 21:50 | |
| *** kproskurin has quit IRC | 21:51 | |
| *** muawiakhan has quit IRC | 21:52 | |
| *** shaohe_feng has joined #openstack-nova | 21:52 | |
| *** kylek3h has quit IRC | 21:52 | |
| *** rtheis has quit IRC | 21:52 | |
| *** sneti_ has quit IRC | 21:53 | |
| *** ctrath has quit IRC | 21:54 | |
| mriedem | nvm i found the duplicate | 21:55 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Refactor block_device_mapping handling during boot https://review.openstack.org/334094 | 21:55 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add block_device_mappings to BuildRequest https://review.openstack.org/334095 | 21:55 |
| *** mriedem has quit IRC | 21:55 | |
| *** catintheroof has quit IRC | 21:55 | |
| *** tbachman has quit IRC | 21:56 | |
| *** sneti_ has joined #openstack-nova | 21:57 | |
| *** shaohe_feng has quit IRC | 21:59 | |
| *** shaohe_feng has joined #openstack-nova | 22:00 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add Allocation and AllocationList objects https://review.openstack.org/282442 | 22:02 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add support for resource inventories to placement API https://review.openstack.org/329152 | 22:02 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add a ResourceProviderList object https://review.openstack.org/328307 | 22:02 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add initial framing of placement API https://review.openstack.org/329149 | 22:02 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: WIP Add a Usage and UsageList object https://review.openstack.org/329575 | 22:02 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add support for resource_providers urls https://review.openstack.org/329151 | 22:02 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add support for usages in the placement API https://review.openstack.org/329643 | 22:02 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add microversion support for the placement API https://review.openstack.org/329150 | 22:02 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: WIP experiment with the remainder of the placement API https://review.openstack.org/293104 | 22:02 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Transform selector 404 and 405 into webob exceptions https://review.openstack.org/331483 | 22:02 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Remove faultwrap middleware https://review.openstack.org/331482 | 22:02 |
| *** Daisy has joined #openstack-nova | 22:03 | |
| *** ravikama_ has joined #openstack-nova | 22:03 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add Allocation and AllocationList objects https://review.openstack.org/282442 | 22:04 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add support for resource inventories to placement API https://review.openstack.org/329152 | 22:04 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add a ResourceProviderList object https://review.openstack.org/328307 | 22:04 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add initial framing of placement API https://review.openstack.org/329149 | 22:04 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: WIP Add a Usage and UsageList object https://review.openstack.org/329575 | 22:04 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add support for resource_providers urls https://review.openstack.org/329151 | 22:04 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add support for usages in the placement API https://review.openstack.org/329643 | 22:04 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add microversion support for the placement API https://review.openstack.org/329150 | 22:04 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: WIP experiment with the remainder of the placement API https://review.openstack.org/293104 | 22:04 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Transform selector 404 and 405 into webob exceptions https://review.openstack.org/331483 | 22:04 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Remove faultwrap middleware https://review.openstack.org/331482 | 22:04 |
| *** muawiakhan has joined #openstack-nova | 22:05 | |
| *** mdrabe has quit IRC | 22:06 | |
| *** Daisy has quit IRC | 22:07 | |
| *** syjulian has quit IRC | 22:08 | |
| *** mmandel has quit IRC | 22:08 | |
| *** wanghao_ has quit IRC | 22:08 | |
| *** stewie925 has joined #openstack-nova | 22:09 | |
| *** zul_ has joined #openstack-nova | 22:09 | |
| *** shaohe_feng has quit IRC | 22:10 | |
| *** fawadkhaliq has joined #openstack-nova | 22:10 | |
| *** shaohe_feng has joined #openstack-nova | 22:10 | |
| openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova: Improve help text for allocation_ratio_opts https://review.openstack.org/329593 | 22:11 |
| stewie925 | hello guys, just a really dumb question here - I am working on body and example verifications for os-fixed-ips : how do I know which fixed ip address to assign? | 22:11 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: libvirt: update guest time after suspend https://review.openstack.org/316116 | 22:11 |
| *** zul has quit IRC | 22:12 | |
| *** eglynn has quit IRC | 22:14 | |
| *** fawadkhaliq has quit IRC | 22:14 | |
| *** sneti_ has quit IRC | 22:15 | |
| *** akshai_ has quit IRC | 22:19 | |
| *** shaohe_feng has quit IRC | 22:20 | |
| *** clduser has quit IRC | 22:21 | |
| *** shaohe_feng has joined #openstack-nova | 22:21 | |
| *** jamielennox is now known as jamielennox|away | 22:21 | |
| *** clduser has joined #openstack-nova | 22:21 | |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Add microversion support to image metadata unit tests https://review.openstack.org/333625 | 22:24 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Add microversion support to images unit tests https://review.openstack.org/333626 | 22:24 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Restrict Metadata to Lower Case Keys https://review.openstack.org/329697 | 22:24 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Add microversion support to server metadata unit tests https://review.openstack.org/333551 | 22:24 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Add microversion support to server actions unit tests https://review.openstack.org/333568 | 22:24 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Add microversion support to flavors extraspecs unit test https://review.openstack.org/333590 | 22:24 |
| *** ametts has quit IRC | 22:28 | |
| openstackgerrit | Maciej Szankin proposed openstack/nova: config options: Improve help for conductor https://review.openstack.org/324784 | 22:28 |
| *** ducttape_ has joined #openstack-nova | 22:30 | |
| *** shaohe_feng has quit IRC | 22:30 | |
| *** shaohe_feng has joined #openstack-nova | 22:31 | |
| openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova: Improve help text for cloudpipe https://review.openstack.org/331285 | 22:33 |
| *** tyrola has joined #openstack-nova | 22:34 | |
| openstackgerrit | Matthew Treinish proposed openstack/nova: Add nova-manage command to lower case metadata https://review.openstack.org/329737 | 22:35 |
| *** ssurana has quit IRC | 22:36 | |
| *** ssurana has joined #openstack-nova | 22:38 | |
| *** Apoorva has quit IRC | 22:38 | |
| *** Apoorva has joined #openstack-nova | 22:38 | |
| *** ducttape_ has quit IRC | 22:39 | |
| *** muawiakhan has quit IRC | 22:39 | |
| *** ducttape_ has joined #openstack-nova | 22:39 | |
| *** shaohe_feng has quit IRC | 22:40 | |
| *** ametts has joined #openstack-nova | 22:41 | |
| *** shaohe_feng has joined #openstack-nova | 22:41 | |
| *** abalutoiu_ has joined #openstack-nova | 22:42 | |
| *** abalutoiu has quit IRC | 22:43 | |
| *** BjoernT has quit IRC | 22:43 | |
| *** tbachman has joined #openstack-nova | 22:45 | |
| *** ssurana has quit IRC | 22:45 | |
| *** ametts has quit IRC | 22:48 | |
| *** abalutoiu_ has quit IRC | 22:48 | |
| *** shaohe_feng has quit IRC | 22:51 | |
| *** shaohe_feng has joined #openstack-nova | 22:51 | |
| *** tbachman has quit IRC | 22:52 | |
| *** tbachman has joined #openstack-nova | 22:52 | |
| *** ducttape_ has quit IRC | 22:52 | |
| *** TravT has quit IRC | 22:54 | |
| *** mvk_ has joined #openstack-nova | 22:58 | |
| *** salv-orl_ has joined #openstack-nova | 22:59 | |
| *** jwcroppe has joined #openstack-nova | 23:00 | |
| *** gjayavelu has joined #openstack-nova | 23:00 | |
| *** shaohe_feng has quit IRC | 23:01 | |
| *** salv-orlando has quit IRC | 23:01 | |
| *** tonytan4ever has quit IRC | 23:02 | |
| *** mvk has quit IRC | 23:02 | |
| *** shaohe_feng has joined #openstack-nova | 23:02 | |
| *** xyang1 has quit IRC | 23:08 | |
| *** s1061123 has quit IRC | 23:09 | |
| *** shaohe_feng has quit IRC | 23:11 | |
| *** shaohe_feng has joined #openstack-nova | 23:12 | |
| *** s1061123 has joined #openstack-nova | 23:13 | |
| *** TravT has joined #openstack-nova | 23:17 | |
| *** ravikama_ has quit IRC | 23:19 | |
| *** shaohe_feng has quit IRC | 23:21 | |
| *** shaohe_feng has joined #openstack-nova | 23:22 | |
| *** sameo has quit IRC | 23:24 | |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Restrict Metadata to Lower Case Keys https://review.openstack.org/329697 | 23:24 |
| *** bjornar has quit IRC | 23:29 | |
| *** fawadkhaliq has joined #openstack-nova | 23:30 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Add DeviceTaggingFilter to scheduler https://review.openstack.org/331490 | 23:31 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: libvirt: attach configdrive after instance XML https://review.openstack.org/303335 | 23:31 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging metadata API support https://review.openstack.org/304511 | 23:31 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging API support https://review.openstack.org/304510 | 23:31 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Compute manager device tagging support https://review.openstack.org/264017 | 23:31 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Libvirt driver implementation of device tagging https://review.openstack.org/264016 | 23:31 |
| *** shaohe_feng has quit IRC | 23:32 | |
| *** shaohe_feng has joined #openstack-nova | 23:32 | |
| openstackgerrit | Chris Friesen proposed openstack/nova: Allow logging detailed info only on sched failure https://review.openstack.org/331306 | 23:33 |
| *** ducttape_ has joined #openstack-nova | 23:34 | |
| *** fawadkhaliq has quit IRC | 23:35 | |
| *** bjornar has joined #openstack-nova | 23:39 | |
| *** sacharya has quit IRC | 23:40 | |
| *** tyrola has quit IRC | 23:41 | |
| *** amotoki has joined #openstack-nova | 23:41 | |
| *** shaohe_feng has quit IRC | 23:42 | |
| *** tyrola has joined #openstack-nova | 23:42 | |
| *** shaohe_feng has joined #openstack-nova | 23:43 | |
| *** jamielennox|away is now known as jamielennox | 23:43 | |
| *** amotoki has quit IRC | 23:45 | |
| *** ducttape_ has quit IRC | 23:47 | |
| *** stewie925 has quit IRC | 23:47 | |
| openstackgerrit | Matthew Treinish proposed openstack/nova: Add nova-manage command to lower case metadata https://review.openstack.org/329737 | 23:51 |
| *** ducttape_ has joined #openstack-nova | 23:52 | |
| *** shaohe_feng has quit IRC | 23:52 | |
| *** mnestratov has quit IRC | 23:53 | |
| *** shaohe_feng has joined #openstack-nova | 23:53 | |
| *** tyrola has quit IRC | 23:55 | |
| *** pwnall has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!