| *** sacharya_ has quit IRC | 00:00 | |
| *** ravikama_ has quit IRC | 00:00 | |
| *** markvoelker has quit IRC | 00:01 | |
| *** markvoelker has joined #openstack-nova | 00:02 | |
| *** markvoelker has quit IRC | 00:02 | |
| *** diogogmt has quit IRC | 00:02 | |
| *** markvoelker has joined #openstack-nova | 00:02 | |
| *** diogogmt has joined #openstack-nova | 00:03 | |
| *** salv-orl_ has quit IRC | 00:05 | |
| *** salv-orlando has joined #openstack-nova | 00:05 | |
| *** akshai has quit IRC | 00:07 | |
| *** shaohe_feng has quit IRC | 00:08 | |
| *** shaohe_feng has joined #openstack-nova | 00:09 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Stop using mox stubs in nova/tests/unit/virt/disk https://review.openstack.org/322778 | 00:09 |
|---|---|---|
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Stop using mox stubs in nova/tests/unit/cells https://review.openstack.org/323287 | 00:09 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Archive migrations table https://review.openstack.org/323684 | 00:09 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Set 'serial' to new volume ID in swap volumes https://review.openstack.org/257135 | 00:09 |
| *** salv-orlando has quit IRC | 00:10 | |
| *** thorst has joined #openstack-nova | 00:13 | |
| *** jwcroppe has quit IRC | 00:14 | |
| *** jwcroppe has joined #openstack-nova | 00:14 | |
| *** diogogmt has quit IRC | 00:16 | |
| *** shaohe_feng has quit IRC | 00:18 | |
| *** shaohe_feng has joined #openstack-nova | 00:18 | |
| *** jwcroppe has quit IRC | 00:18 | |
| *** edmondsw has quit IRC | 00:19 | |
| *** gjayavelu has joined #openstack-nova | 00:20 | |
| *** diogogmt has joined #openstack-nova | 00:21 | |
| *** thorst has quit IRC | 00:21 | |
| *** gjayavelu has quit IRC | 00:24 | |
| *** shaohe_feng has quit IRC | 00:28 | |
| *** shaohe_feng has joined #openstack-nova | 00:29 | |
| *** rama_y has joined #openstack-nova | 00:29 | |
| mriedem_away | eliqiao: yeah | 00:37 |
| *** mriedem_away is now known as mriedem | 00:37 | |
| *** shaohe_feng has quit IRC | 00:39 | |
| *** shaohe_feng has joined #openstack-nova | 00:39 | |
| *** apanaitiu has quit IRC | 00:39 | |
| *** hoangcx has joined #openstack-nova | 00:39 | |
| mriedem | dansmith: i'm +2 on the vz resize patch now https://review.openstack.org/#/c/182257/ the ci reported success on ps59, everything after that was just reno changes | 00:43 |
| mriedem | i'll hit the libvirt device tagging change before the end of the night | 00:44 |
| *** zul has joined #openstack-nova | 00:45 | |
| *** shaohe_feng has quit IRC | 00:49 | |
| openstackgerrit | Rong Han proposed openstack/nova: Reset migration.dest_node after finish_revert_resize successfully. https://review.openstack.org/335270 | 00:50 |
| *** shaohe_feng has joined #openstack-nova | 00:50 | |
| *** rama_y has quit IRC | 00:51 | |
| openstackgerrit | Rong Han proposed openstack/nova: Reset migration.dest_node after finish_revert_resize successfully https://review.openstack.org/335270 | 00:53 |
| *** thorst has joined #openstack-nova | 00:59 | |
| *** shaohe_feng has quit IRC | 00:59 | |
| *** edand has joined #openstack-nova | 01:01 | |
| *** shaohe_feng has joined #openstack-nova | 01:02 | |
| dansmith | mriedem: right on, I +Wd | 01:03 |
| *** cheneydc has joined #openstack-nova | 01:04 | |
| *** sameo has quit IRC | 01:06 | |
| *** edand has quit IRC | 01:06 | |
| *** cheneydc has quit IRC | 01:07 | |
| *** shaohe_feng has quit IRC | 01:09 | |
| *** shaohe_feng has joined #openstack-nova | 01:10 | |
| openstackgerrit | Hieu LE proposed openstack/nova: Config options: improve libvirt help text (1) https://review.openstack.org/316539 | 01:10 |
| *** sacharya has joined #openstack-nova | 01:11 | |
| *** salv-orlando has joined #openstack-nova | 01:12 | |
| *** kevin_zh has joined #openstack-nova | 01:12 | |
| *** kevinzh has joined #openstack-nova | 01:12 | |
| *** Jeffrey4l has joined #openstack-nova | 01:15 | |
| mriedem | artom: vladikr: the tempest test fails in cleanup, some notes inline https://review.openstack.org/#/c/305120/ | 01:17 |
| mriedem | the good news is it looks like it's getting to teardown at least | 01:18 |
| *** Sukhdev has quit IRC | 01:18 | |
| mriedem | the crappy thing is it only runs in a non-voting job that we don't even run on nova changes | 01:18 |
| *** gabriel-bezerra has quit IRC | 01:18 | |
| mriedem | gate-tempest-dsvm-neutron-full-ssh | 01:18 |
| *** ericksonsantos has quit IRC | 01:18 | |
| *** clenimar has quit IRC | 01:18 | |
| *** shaohe_feng has quit IRC | 01:22 | |
| *** salv-orlando has quit IRC | 01:22 | |
| *** shaohe_feng has joined #openstack-nova | 01:22 | |
| *** yamahata has joined #openstack-nova | 01:22 | |
| *** openstack has joined #openstack-nova | 01:24 | |
| *** keekz has joined #openstack-nova | 01:24 | |
| *** raildo is now known as raildo-afk | 01:27 | |
| *** raildo-afk is now known as raildo | 01:27 | |
| openstackgerrit | Li Yingjun proposed openstack/nova: Microversion 2.32 adds pagination support for hypervisors https://review.openstack.org/326940 | 01:28 |
| *** EinstCrazy has joined #openstack-nova | 01:30 | |
| *** shaohe_feng has quit IRC | 01:30 | |
| *** shaohe_feng has joined #openstack-nova | 01:30 | |
| *** ericksonsantos has joined #openstack-nova | 01:30 | |
| *** clenimar has joined #openstack-nova | 01:30 | |
| *** gabriel-bezerra has joined #openstack-nova | 01:33 | |
| *** Daisy has joined #openstack-nova | 01:33 | |
| *** ctrath has quit IRC | 01:33 | |
| *** wangqun has joined #openstack-nova | 01:34 | |
| *** ctrath has joined #openstack-nova | 01:34 | |
| *** woodster_ has quit IRC | 01:39 | |
| *** shihanzhang has quit IRC | 01:39 | |
| *** shaohe_feng has quit IRC | 01:40 | |
| *** shaohe_feng has joined #openstack-nova | 01:41 | |
| *** thorst has quit IRC | 01:43 | |
| *** zhangyufei has joined #openstack-nova | 01:43 | |
| *** thorst has joined #openstack-nova | 01:44 | |
| mriedem | dansmith: +2 on https://review.openstack.org/#/c/264016/ now | 01:46 |
| *** zhangyufei has quit IRC | 01:46 | |
| artom | mriedem, yeah, I figured I'd push the failing Tempest test to show that at least the testing-the-api-part works | 01:48 |
| artom | I need to figure out how to do cleanup properly | 01:49 |
| artom | Once again, thanks for the late reviews :) | 01:49 |
| *** shaohe_feng has quit IRC | 01:50 | |
| *** shaohe_feng has joined #openstack-nova | 01:51 | |
| *** thorst has quit IRC | 01:52 | |
| *** gjayavelu has joined #openstack-nova | 01:53 | |
| *** zz_dimtruck is now known as dimtruck | 01:57 | |
| dansmith | mriedem: woot | 02:00 |
| dansmith | did the service_version thing in the next patch get fixed? | 02:00 |
| *** shaohe_feng has quit IRC | 02:01 | |
| *** shaohe_feng has joined #openstack-nova | 02:01 | |
| artom | dansmith, yes! https://review.openstack.org/#/c/264017/ | 02:02 |
| mriedem | seems ok | 02:02 |
| *** EinstCra_ has joined #openstack-nova | 02:02 | |
| *** yamahata has quit IRC | 02:02 | |
| mriedem | however, i think i've spotted an issue | 02:02 |
| openstackgerrit | STEW TY proposed openstack/nova: Complete verification for api-ref os-flavor-extra-specs https://review.openstack.org/333651 | 02:04 |
| mriedem | artom: dansmith: i've rained on the parade here https://review.openstack.org/#/c/264017/63/nova/compute/manager.py | 02:04 |
| *** EinstCrazy has quit IRC | 02:05 | |
| mriedem | pre-created ports won't get tagged | 02:06 |
| artom | mriedem, claudiu actually raised that in his testing - he saw it as, if you have two nics on the same network, they get the tag or lack thereof of the last nic in the boot request | 02:06 |
| artom | We cowardly were hoping to punt this to post-FF as a bug | 02:07 |
| mriedem | i'm not really following that scenaroi | 02:08 |
| mriedem | *scenario | 02:08 |
| artom | Say you boot with --nic net-id=blah,tag=blah --nic net-id=blah | 02:09 |
| artom | Same net | 02:09 |
| artom | First nic has tag, second one doesn't | 02:09 |
| artom | No tags get assigned, because in that loop we only check for network ID | 02:09 |
| artom | Two nics, same network ID, whatever nic the loop ends with is what gets applied to all nics with that network ID | 02:10 |
| dansmith | mriedem: do we persist the port_id in the vif structure? | 02:10 |
| *** stewie925 has quit IRC | 02:10 | |
| mriedem | dansmith: i'm pretty sure | 02:10 |
| artom | dansmith, yeah, the fix shouldn't be hard | 02:11 |
| *** shaohe_feng has quit IRC | 02:11 | |
| dansmith | mriedem: so we should be able to match on networkid, port id or address per usual right? | 02:11 |
| dansmith | actually, maybe port id will always be set by this point? | 02:11 |
| mriedem | dansmith: https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L1867 | 02:11 |
| dansmith | er, maybe we don't update it | 02:11 |
| *** shaohe_feng has joined #openstack-nova | 02:11 | |
| mriedem | calling _build_network_info_model happens at the end of allocate_for_instance | 02:12 |
| mriedem | right before we return that to the compute manager | 02:12 |
| mriedem | which uses that vif list to tag the stuff | 02:12 |
| dansmith | okay | 02:12 |
| mriedem | which we should use to set the vif.uuid when creating that in the compute manager | 02:13 |
| mriedem | it doesn't get us around the pre-created port issue though | 02:13 |
| dansmith | what I'm not clear on is, do we have to do the trifecta? match on portid, networkid, and address? | 02:14 |
| dansmith | because I think we'll end up with a fourth thing when we get segments, right? | 02:14 |
| mriedem | you can't specify network and port id in the same nic on the request | 02:15 |
| mriedem | it's either port or network | 02:15 |
| dansmith | or address | 02:15 |
| mriedem | yeah | 02:15 |
| mriedem | but address is fine for either | 02:15 |
| dansmith | I'm asking if we have to handle all three in that libvirt function | 02:15 |
| mriedem | god i had to write down this acceptance matrix in my get me a network spec | 02:15 |
| mriedem | which libvirt function? | 02:16 |
| mriedem | _build_device_metadata? | 02:16 |
| dansmith | do we not update the network request with the portid all the time once we've allocated it? | 02:16 |
| mriedem | no | 02:16 |
| dansmith | no in _apply_vif_tag() | 02:16 |
| mriedem | the network request is basically immuatable i think | 02:16 |
| *** salv-orlando has joined #openstack-nova | 02:16 | |
| dansmith | it just sucks to have to spread that 3-way switching logic everywhere that has to deal with a request | 02:17 |
| mriedem | the network request is not changed after it hits the compute api | 02:17 |
| mriedem | and we don't persist the network request so you can't look it up later or modify it | 02:17 |
| mriedem | well.....we have the request spec :) | 02:17 |
| *** tyrola has joined #openstack-nova | 02:18 | |
| dansmith | well, anyway, artom you on top of that fixup tomorrow? | 02:18 |
| mriedem | request spec doesn't store requested_networks today though | 02:18 |
| artom | dansmith, for the manager? I think so... is the conclusion that we do end up doing that trifecta match, as you call it? | 02:19 |
| dansmith | yeah, I guess | 02:19 |
| *** shaohe_feng has quit IRC | 02:21 | |
| *** houming has joined #openstack-nova | 02:21 | |
| *** shaohe_feng has joined #openstack-nova | 02:21 | |
| *** tyrola has quit IRC | 02:22 | |
| mriedem | we could also fail the request if you request duplicate nics with a tag | 02:22 |
| dansmith | why? that doesn't seem helpful | 02:22 |
| mriedem | to avoid the thing artom was describing above | 02:22 |
| dansmith | if you want two nics on the same segment for bonding and you tag those as something, that's legit I think | 02:23 |
| dansmith | I think full matching of the request (the trifecta as it is now known heretofore) will resolve that | 02:23 |
| mriedem | i didn't say it was a good idea | 02:23 |
| mriedem | :) | 02:23 |
| artom | dansmith, yeah, except we have to way of knowing which one has the tag and which doesn't | 02:23 |
| dansmith | frankly I'm digesting too much queso right now to really have good ideas | 02:24 |
| mriedem | it's actually like a quadfecta | 02:24 |
| mriedem | with pci | 02:24 |
| *** salv-orlando has quit IRC | 02:24 | |
| mriedem | megatuple 4ever | 02:24 |
| mriedem | yeah i seriously don't want to be talking about this anymore today, i've just dumped -1s all over :) | 02:24 |
| dansmith | artom: okay let's talk about it tomorrow when I'm fresher | 02:24 |
| mriedem | i need some kenny powers before bed | 02:24 |
| mriedem | eliqiao: i'll hit that perf event patch first thing in the morning | 02:25 |
| artom | dansmith, sure | 02:25 |
| openstackgerrit | Li Yingjun proposed openstack/nova: Adds view builders for hypervisors controller https://review.openstack.org/335282 | 02:25 |
| artom | mriedem, I'll try to post a WIP that address the, err, "concrete" feedback on the API patch | 02:25 |
| *** baoli_ has quit IRC | 02:25 | |
| artom | Unit tests are still WIP, but functional tests I think are OK | 02:26 |
| mriedem | heh, yeah i actually have some real -1 worthy stuff in there | 02:26 |
| *** sacharya_ has joined #openstack-nova | 02:26 | |
| dansmith | artom: oh I see what you mean on the lack of a tagged one | 02:26 |
| mriedem | artom: there aren't any functional api sample tests in there | 02:26 |
| mriedem | the api sample docs do not a test make | 02:26 |
| artom | mriedem, "concrete" was a bad word | 02:26 |
| *** erlon has quit IRC | 02:26 | |
| mriedem | actionable | 02:26 |
| artom | mriedem, not posted yet, but they're here locally | 02:26 |
| mriedem | is the business word for it | 02:26 |
| dansmith | artom: we can probably do something sane like make a list of the network requests and pop them out as we use them so that we don't give N things M tags | 02:26 |
| artom | mriedem, actionable at 22:30 :) | 02:27 |
| artom | Like, I'm not going to lay some unit tests in 10 minutes | 02:27 |
| artom | But I can fix some conditionals | 02:27 |
| *** ctrath has quit IRC | 02:27 | |
| mriedem | i can lay most things in less than 10 minutes | 02:27 |
| mriedem | but that's not something i usually brag about | 02:27 |
| artom | Yeah, I'd keep that to myself if I were you | 02:27 |
| dansmith | okay, that's the cue.. I'm out | 02:28 |
| mriedem | anywho, with that, i'll bit you adieu | 02:28 |
| *** sacharya has quit IRC | 02:28 | |
| *** mriedem has quit IRC | 02:28 | |
| *** shaohe_feng has quit IRC | 02:31 | |
| *** rfolco has joined #openstack-nova | 02:31 | |
| *** rfolco has quit IRC | 02:32 | |
| *** rfolco has joined #openstack-nova | 02:32 | |
| *** shaohe_feng has joined #openstack-nova | 02:34 | |
| *** code-R has joined #openstack-nova | 02:37 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Add DeviceTaggingFilter to scheduler https://review.openstack.org/331490 | 02:39 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging metadata API support https://review.openstack.org/304511 | 02:39 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging API support https://review.openstack.org/304510 | 02:39 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Compute manager device tagging support https://review.openstack.org/264017 | 02:39 |
| * artom hopes what he posted makes sense. | 02:42 | |
| *** shaohe_feng has quit IRC | 02:42 | |
| artom | And on that, sleep. | 02:42 |
| artom | Season finale of GoT will wait again. | 02:42 |
| *** armax_ has joined #openstack-nova | 02:42 | |
| *** shaohe_feng has joined #openstack-nova | 02:42 | |
| *** TravT has quit IRC | 02:43 | |
| *** TravT has joined #openstack-nova | 02:43 | |
| *** armax has quit IRC | 02:44 | |
| *** armax_ is now known as armax | 02:44 | |
| openstackgerrit | Li Yingjun proposed openstack/nova: Microversion 2.32 adds pagination support for hypervisors https://review.openstack.org/326940 | 02:47 |
| *** sheel has joined #openstack-nova | 02:48 | |
| *** prateek has joined #openstack-nova | 02:48 | |
| *** akshai has joined #openstack-nova | 02:49 | |
| *** yamahata has joined #openstack-nova | 02:49 | |
| *** thorst has joined #openstack-nova | 02:50 | |
| openstackgerrit | Li Yingjun proposed openstack/nova: Adds view builders for hypervisors controller https://review.openstack.org/335282 | 02:51 |
| *** svenkat has joined #openstack-nova | 02:51 | |
| *** shaohe_feng has quit IRC | 02:52 | |
| *** shaohe_feng has joined #openstack-nova | 02:53 | |
| *** fragatina has quit IRC | 02:55 | |
| *** fragatina has joined #openstack-nova | 02:55 | |
| *** Daisy has quit IRC | 02:56 | |
| *** Daisy has joined #openstack-nova | 02:56 | |
| *** svenkat has quit IRC | 02:57 | |
| *** thorst has quit IRC | 02:57 | |
| *** gjayavelu has quit IRC | 02:58 | |
| *** klkumar has joined #openstack-nova | 02:58 | |
| openstackgerrit | Li Yingjun proposed openstack/nova-specs: Flavor notifications spec https://review.openstack.org/321336 | 03:01 |
| *** akshai_ has joined #openstack-nova | 03:01 | |
| *** gyee has quit IRC | 03:02 | |
| *** shaohe_feng has quit IRC | 03:02 | |
| *** cheneydc has joined #openstack-nova | 03:03 | |
| *** shaohe_feng has joined #openstack-nova | 03:03 | |
| *** akshai has quit IRC | 03:05 | |
| *** jamielennox is now known as jamielennox|away | 03:07 | |
| *** jamielennox|away is now known as jamielennox | 03:07 | |
| *** dimtruck is now known as zz_dimtruck | 03:12 | |
| *** shaohe_feng has quit IRC | 03:12 | |
| *** jwcroppe has joined #openstack-nova | 03:12 | |
| *** shaohe_feng has joined #openstack-nova | 03:13 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 03:14 |
| *** prateek has quit IRC | 03:17 | |
| *** krtaylor has joined #openstack-nova | 03:18 | |
| *** krtaylor has quit IRC | 03:20 | |
| *** DaiDV has joined #openstack-nova | 03:20 | |
| *** DaiDV has quit IRC | 03:20 | |
| *** sacharya_ has quit IRC | 03:20 | |
| *** sacharya has joined #openstack-nova | 03:20 | |
| *** salv-orlando has joined #openstack-nova | 03:21 | |
| *** prateek has joined #openstack-nova | 03:22 | |
| *** shaohe_feng has quit IRC | 03:23 | |
| *** shaohe_feng has joined #openstack-nova | 03:23 | |
| *** salv-orlando has quit IRC | 03:26 | |
| *** imcsk8 has quit IRC | 03:26 | |
| *** imcsk8 has joined #openstack-nova | 03:26 | |
| *** sree has joined #openstack-nova | 03:29 | |
| *** prateek has quit IRC | 03:30 | |
| *** shaohe_feng has quit IRC | 03:33 | |
| *** shaohe_feng has joined #openstack-nova | 03:34 | |
| *** prateek has joined #openstack-nova | 03:35 | |
| *** ducttape_ has joined #openstack-nova | 03:35 | |
| openstackgerrit | Li Yingjun proposed openstack/nova: Implement hypervisor notifications https://review.openstack.org/315312 | 03:36 |
| *** akshai_ has quit IRC | 03:37 | |
| *** akshai has joined #openstack-nova | 03:38 | |
| *** gongysh has joined #openstack-nova | 03:39 | |
| *** jwcroppe has quit IRC | 03:41 | |
| *** shaohe_feng has quit IRC | 03:43 | |
| *** shaohe_feng has joined #openstack-nova | 03:44 | |
| *** sacharya has quit IRC | 03:49 | |
| *** Daisy has quit IRC | 03:49 | |
| *** sacharya has joined #openstack-nova | 03:49 | |
| *** Daisy has joined #openstack-nova | 03:49 | |
| *** shaohe_feng has quit IRC | 03:53 | |
| *** shaohe_feng has joined #openstack-nova | 03:54 | |
| *** Daisy has quit IRC | 03:54 | |
| *** salv-orlando has joined #openstack-nova | 03:54 | |
| *** thorst has joined #openstack-nova | 03:55 | |
| *** salv-orlando has quit IRC | 04:00 | |
| *** thorst has quit IRC | 04:03 | |
| *** shaohe_feng has quit IRC | 04:04 | |
| *** shaohe_feng has joined #openstack-nova | 04:04 | |
| *** ducttape_ has quit IRC | 04:07 | |
| *** houming has quit IRC | 04:11 | |
| *** shaohe_feng has quit IRC | 04:14 | |
| *** shaohe_feng has joined #openstack-nova | 04:15 | |
| *** zerda2 has joined #openstack-nova | 04:15 | |
| *** links has joined #openstack-nova | 04:22 | |
| *** prateek has quit IRC | 04:23 | |
| *** shaohe_feng has quit IRC | 04:24 | |
| *** shaohe_feng has joined #openstack-nova | 04:25 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/333181 | 04:26 |
| *** armax has quit IRC | 04:29 | |
| *** liverpooler has quit IRC | 04:30 | |
| *** jwcroppe has joined #openstack-nova | 04:30 | |
| *** salv-orlando has joined #openstack-nova | 04:30 | |
| *** markvoelker has quit IRC | 04:31 | |
| *** akshai has quit IRC | 04:32 | |
| *** salv-orlando has quit IRC | 04:33 | |
| *** Sukhdev has joined #openstack-nova | 04:34 | |
| *** shaohe_feng has quit IRC | 04:34 | |
| *** code-R has quit IRC | 04:34 | |
| *** shaohe_feng has joined #openstack-nova | 04:35 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/333181 | 04:36 |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Remove invalid test for config option scheduler_host_manager https://review.openstack.org/327477 | 04:36 |
| *** ratailor has joined #openstack-nova | 04:38 | |
| *** ratailor has quit IRC | 04:40 | |
| *** ratailor has joined #openstack-nova | 04:40 | |
| *** sudipto has joined #openstack-nova | 04:42 | |
| *** gongysh has quit IRC | 04:43 | |
| *** shaohe_feng has quit IRC | 04:45 | |
| *** shaohe_feng has joined #openstack-nova | 04:45 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs: Fix Newton approved specs list https://review.openstack.org/335306 | 04:46 |
| *** browne has quit IRC | 04:50 | |
| *** DaiDV has joined #openstack-nova | 04:51 | |
| *** rcernin has joined #openstack-nova | 04:53 | |
| *** shaohe_feng has quit IRC | 04:55 | |
| *** shaohe_feng has joined #openstack-nova | 04:55 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Introduce the memory bandwidth monitor https://review.openstack.org/329783 | 04:58 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor https://review.openstack.org/266773 | 04:58 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Update setup.cfg for memory bandwidth monitor https://review.openstack.org/329785 | 04:58 |
| *** pcaruana has quit IRC | 04:58 | |
| *** salv-orlando has joined #openstack-nova | 04:59 | |
| *** sacharya has quit IRC | 05:00 | |
| *** thorst has joined #openstack-nova | 05:01 | |
| *** Daisy has joined #openstack-nova | 05:01 | |
| openstackgerrit | Dao Cong Tien proposed openstack/nova: Ironic Driver: override get_serial_console() https://review.openstack.org/328157 | 05:02 |
| *** Daisy has quit IRC | 05:03 | |
| *** Daisy has joined #openstack-nova | 05:04 | |
| *** shaohe_feng has quit IRC | 05:05 | |
| *** shaohe_feng has joined #openstack-nova | 05:05 | |
| *** salv-orlando has quit IRC | 05:06 | |
| *** M00nr41n has quit IRC | 05:06 | |
| *** jwcroppe has quit IRC | 05:07 | |
| *** thorst has quit IRC | 05:08 | |
| *** code-R has joined #openstack-nova | 05:09 | |
| *** claudiub has joined #openstack-nova | 05:10 | |
| *** code-R_ has joined #openstack-nova | 05:12 | |
| *** salv-orlando has joined #openstack-nova | 05:14 | |
| *** code-R has quit IRC | 05:15 | |
| *** shaohe_feng has quit IRC | 05:15 | |
| *** shaohe_feng has joined #openstack-nova | 05:16 | |
| *** pbandark has joined #openstack-nova | 05:16 | |
| *** code-R has joined #openstack-nova | 05:17 | |
| *** code-R_ has quit IRC | 05:17 | |
| *** code-R has quit IRC | 05:17 | |
| *** prateek has joined #openstack-nova | 05:19 | |
| *** moshele has joined #openstack-nova | 05:23 | |
| *** prateek has quit IRC | 05:23 | |
| *** shaohe_feng has quit IRC | 05:26 | |
| *** shaohe_feng has joined #openstack-nova | 05:26 | |
| *** jwcroppe has joined #openstack-nova | 05:27 | |
| *** takashin has joined #openstack-nova | 05:28 | |
| *** gjayavelu has joined #openstack-nova | 05:32 | |
| *** markvoelker has joined #openstack-nova | 05:32 | |
| *** pc_m has quit IRC | 05:33 | |
| *** rcernin has quit IRC | 05:33 | |
| openstackgerrit | huan proposed openstack/nova: XenAPI: Do not rely on XenAPI to get device names https://review.openstack.org/213112 | 05:34 |
| *** pc_m has joined #openstack-nova | 05:34 | |
| *** GB21 has joined #openstack-nova | 05:35 | |
| *** shaohe_feng has quit IRC | 05:36 | |
| *** shaohe_feng has joined #openstack-nova | 05:36 | |
| *** prateek has joined #openstack-nova | 05:37 | |
| *** markvoelker has quit IRC | 05:37 | |
| *** ducttape_ has joined #openstack-nova | 05:38 | |
| *** ducttape_ has quit IRC | 05:42 | |
| *** GB21 has quit IRC | 05:44 | |
| gjayavelu | Hi johnthetubaguy: when you get chance, can you please take a look at these patches https://review.openstack.org/#/c/196171 & https://review.openstack.org/#/c/204219/. thanks! | 05:44 |
| *** shaohe_feng has quit IRC | 05:46 | |
| *** edand has joined #openstack-nova | 05:47 | |
| *** shaohe_feng has joined #openstack-nova | 05:47 | |
| *** chandankumar has joined #openstack-nova | 05:49 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs: Fix blueprints and specs link in ocata template https://review.openstack.org/335312 | 05:51 |
| *** nkrinner_afk is now known as nkrinner | 05:54 | |
| *** EinstCra_ has quit IRC | 05:55 | |
| *** mjura has joined #openstack-nova | 05:55 | |
| *** shaohe_feng has quit IRC | 05:56 | |
| *** EinstCrazy has joined #openstack-nova | 05:57 | |
| *** ociuhandu has joined #openstack-nova | 05:57 | |
| *** shaohe_feng has joined #openstack-nova | 05:57 | |
| *** mjura has quit IRC | 06:00 | |
| *** liverpooler has joined #openstack-nova | 06:00 | |
| *** mjura has joined #openstack-nova | 06:00 | |
| *** edand has quit IRC | 06:01 | |
| *** Daisy has quit IRC | 06:03 | |
| *** edand has joined #openstack-nova | 06:03 | |
| *** Daisy has joined #openstack-nova | 06:03 | |
| *** apanaitiu has joined #openstack-nova | 06:05 | |
| *** thorst has joined #openstack-nova | 06:05 | |
| *** rcernin has joined #openstack-nova | 06:05 | |
| *** shaohe_feng has quit IRC | 06:07 | |
| *** M00nr41n has joined #openstack-nova | 06:08 | |
| *** Daisy has quit IRC | 06:08 | |
| *** paul-carlton2 has joined #openstack-nova | 06:09 | |
| *** shaohe_feng has joined #openstack-nova | 06:09 | |
| *** thorst has quit IRC | 06:12 | |
| *** GB21 has joined #openstack-nova | 06:13 | |
| *** pcaruana has joined #openstack-nova | 06:16 | |
| *** shaohe_feng has quit IRC | 06:17 | |
| *** abalutoiu_ has joined #openstack-nova | 06:17 | |
| *** abalutoiu_ has quit IRC | 06:17 | |
| *** tyrola has joined #openstack-nova | 06:18 | |
| *** shaohe_feng has joined #openstack-nova | 06:18 | |
| *** pcaruana is now known as pcaruana|afk| | 06:19 | |
| *** lpetrut has joined #openstack-nova | 06:19 | |
| *** andreas_s has joined #openstack-nova | 06:20 | |
| *** M00nr41n has quit IRC | 06:22 | |
| *** M00nr41n has joined #openstack-nova | 06:23 | |
| *** tyrola has quit IRC | 06:23 | |
| *** Sukhdev has quit IRC | 06:24 | |
| *** lpetrut has quit IRC | 06:24 | |
| *** ftersin has joined #openstack-nova | 06:24 | |
| *** sridharg has joined #openstack-nova | 06:26 | |
| *** Daisy has joined #openstack-nova | 06:26 | |
| *** ftersin has quit IRC | 06:27 | |
| *** shaohe_feng has quit IRC | 06:27 | |
| *** fragatina has quit IRC | 06:29 | |
| *** shaohe_feng has joined #openstack-nova | 06:30 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: api-ref: verify assisted-volume-snapshots.inc https://review.openstack.org/326975 | 06:30 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 06:31 |
| *** markvoelker has joined #openstack-nova | 06:33 | |
| *** M00nr41n has quit IRC | 06:33 | |
| *** aloga_ has joined #openstack-nova | 06:34 | |
| *** M00nr41n has joined #openstack-nova | 06:34 | |
| *** sahid has joined #openstack-nova | 06:37 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: api-ref: verify assisted-volume-snapshots.inc https://review.openstack.org/326975 | 06:37 |
| *** markvoelker has quit IRC | 06:37 | |
| *** shaohe_feng has quit IRC | 06:37 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: api-ref: verify assisted-volume-snapshots.inc https://review.openstack.org/326975 | 06:38 |
| *** shaohe_feng has joined #openstack-nova | 06:38 | |
| *** luis5tb has joined #openstack-nova | 06:38 | |
| gmann_ | johnthetubaguy: ^^ updated as per comments, check if it looks fine now. | 06:39 |
| *** amotoki has joined #openstack-nova | 06:39 | |
| gmann_ | johnthetubaguy: also i want to change the "id" value in response from create_info['id'] to snapshot_id which is more meaningful | 06:41 |
| gmann_ | johnthetubaguy: let me add patch for that | 06:41 |
| openstackgerrit | Pawel Koniszewski proposed openstack/nova: Extend live-migration-force-complete to use postcopy if available https://review.openstack.org/329077 | 06:42 |
| openstackgerrit | Pawel Koniszewski proposed openstack/nova: Add automatic switching to postcopy mode when migration is not progressing https://review.openstack.org/328499 | 06:42 |
| *** phuongnh has joined #openstack-nova | 06:45 | |
| *** shaohe_feng has quit IRC | 06:48 | |
| *** muawiakhan has joined #openstack-nova | 06:49 | |
| *** muawiakhan has quit IRC | 06:49 | |
| *** pcaruana|afk| is now known as pcaruana | 06:49 | |
| openstackgerrit | Tony Breeds proposed openstack/nova: DNM: testing removal of non libguestfs injection paths https://review.openstack.org/324720 | 06:49 |
| *** mpavone has joined #openstack-nova | 06:50 | |
| *** muawiakhan has joined #openstack-nova | 06:50 | |
| *** shaohe_feng has joined #openstack-nova | 06:50 | |
| *** jlanoux has joined #openstack-nova | 06:52 | |
| *** diga has joined #openstack-nova | 06:53 | |
| *** aloga_ has quit IRC | 06:53 | |
| *** jed56 has joined #openstack-nova | 06:53 | |
| *** sudipto has quit IRC | 06:54 | |
| *** itamarl has joined #openstack-nova | 06:55 | |
| *** belmoreira has joined #openstack-nova | 06:56 | |
| *** shaohe_feng has quit IRC | 06:58 | |
| *** shaohe_feng has joined #openstack-nova | 06:58 | |
| *** diga has quit IRC | 07:08 | |
| *** shaohe_feng has quit IRC | 07:08 | |
| *** shaohe_feng has joined #openstack-nova | 07:08 | |
| *** tesseract- has joined #openstack-nova | 07:09 | |
| *** thorst has joined #openstack-nova | 07:10 | |
| openstackgerrit | Muawia Khan proposed openstack/nova: Remove network information from IOVisor vif https://review.openstack.org/299253 | 07:11 |
| *** DaiDV has quit IRC | 07:12 | |
| *** imcsk8 has quit IRC | 07:16 | |
| *** imcsk8 has joined #openstack-nova | 07:16 | |
| *** tlbr has quit IRC | 07:17 | |
| *** thorst has quit IRC | 07:17 | |
| *** roeyc has joined #openstack-nova | 07:18 | |
| *** shaohe_feng has quit IRC | 07:18 | |
| *** shaohe_feng has joined #openstack-nova | 07:19 | |
| *** tlbr has joined #openstack-nova | 07:19 | |
| *** ratailor has quit IRC | 07:22 | |
| *** jwcroppe has quit IRC | 07:23 | |
| openstackgerrit | Andreas Jaeger proposed openstack/python-novaclient: List system dependencies for running common tests https://review.openstack.org/334984 | 07:24 |
| *** kevin_zh has quit IRC | 07:24 | |
| *** kevinzh has quit IRC | 07:24 | |
| *** kevin_zh has joined #openstack-nova | 07:24 | |
| *** kevinzh has joined #openstack-nova | 07:24 | |
| *** DaiDV has joined #openstack-nova | 07:27 | |
| *** shaohe_feng has quit IRC | 07:29 | |
| *** diga has joined #openstack-nova | 07:29 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | 07:29 |
| *** GB21 has quit IRC | 07:30 | |
| *** shaohe_feng has joined #openstack-nova | 07:30 | |
| bauzas | good morning Nova | 07:30 |
| *** gjayavelu has quit IRC | 07:32 | |
| *** markvoelker has joined #openstack-nova | 07:34 | |
| *** zz_dimtruck is now known as dimtruck | 07:34 | |
| *** liusheng has quit IRC | 07:34 | |
| *** RuiChen has quit IRC | 07:34 | |
| *** liusheng has joined #openstack-nova | 07:35 | |
| openstackgerrit | Paul Murray proposed openstack/nova: Convert websocketproxy to use db for token validation https://review.openstack.org/333990 | 07:36 |
| *** amotoki has quit IRC | 07:37 | |
| *** paul-carlton2 has quit IRC | 07:38 | |
| *** markvoelker has quit IRC | 07:38 | |
| *** EinstCrazy has quit IRC | 07:39 | |
| *** shaohe_feng has quit IRC | 07:39 | |
| *** shaohe_feng has joined #openstack-nova | 07:40 | |
| *** ducttape_ has joined #openstack-nova | 07:40 | |
| *** EinstCrazy has joined #openstack-nova | 07:40 | |
| *** Daisy has quit IRC | 07:41 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata https://review.openstack.org/331996 | 07:42 |
| *** Daisy has joined #openstack-nova | 07:42 | |
| *** amotoki has joined #openstack-nova | 07:43 | |
| *** ducttape_ has quit IRC | 07:44 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 07:45 |
| *** Daisy has quit IRC | 07:45 | |
| *** Daisy has joined #openstack-nova | 07:45 | |
| *** lpetrut has joined #openstack-nova | 07:46 | |
| *** RuiChen has joined #openstack-nova | 07:46 | |
| *** shaohe_feng has quit IRC | 07:49 | |
| *** lchen_ has quit IRC | 07:50 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add check of capabilities for detach interface https://review.openstack.org/308115 | 07:50 |
| *** shaohe_feng has joined #openstack-nova | 07:50 | |
| *** RuiChen has quit IRC | 07:51 | |
| *** lchen_ has joined #openstack-nova | 07:51 | |
| *** EinstCrazy has quit IRC | 07:52 | |
| *** jichen has joined #openstack-nova | 07:52 | |
| *** EinstCrazy has joined #openstack-nova | 07:53 | |
| *** ccard has joined #openstack-nova | 07:53 | |
| *** paul-carlton2 has joined #openstack-nova | 07:54 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Return snapshot_id in os-assisted-volume-snapshots POST https://review.openstack.org/335349 | 07:55 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Remove mox in tests/unit/objects/test_security_group https://review.openstack.org/307135 | 07:58 |
| *** hshiina has joined #openstack-nova | 07:59 | |
| *** shaohe_feng has quit IRC | 07:59 | |
| *** luis5tb has quit IRC | 07:59 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** tlbr has quit IRC | 08:00 | |
| *** ratailor has joined #openstack-nova | 08:00 | |
| *** shaohe_feng has joined #openstack-nova | 08:00 | |
| *** zzzeek has joined #openstack-nova | 08:00 | |
| *** RuiChen has joined #openstack-nova | 08:01 | |
| *** ratailor has quit IRC | 08:02 | |
| *** ratailor has joined #openstack-nova | 08:02 | |
| *** mvk has joined #openstack-nova | 08:02 | |
| openstackgerrit | Lucian Petrut proposed openstack/nova: Hyper-V: properly handle shared storage https://review.openstack.org/335114 | 08:02 |
| *** ihrachys has joined #openstack-nova | 08:03 | |
| *** tlbr has joined #openstack-nova | 08:03 | |
| *** ratailor has quit IRC | 08:03 | |
| *** Manikanta has joined #openstack-nova | 08:03 | |
| lyarwood | mdbooth: Morning, could I ask for another review of my stable-rescue series? https://review.openstack.org/#/q/topic:bp/virt-rescue-stable-disk-devices+status:open | 08:04 |
| *** ratailor has joined #openstack-nova | 08:04 | |
| *** tlbr has quit IRC | 08:04 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Remove mox in tests/unit/objects/test_quotas https://review.openstack.org/307141 | 08:05 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Remove mox in tests/unit/objects/test_instance_info_cache https://review.openstack.org/307155 | 08:05 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Remove mox in tests/unit/objects/test_pci_device https://review.openstack.org/307615 | 08:06 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Return snapshot_id in os-assisted-volume-snapshots POST https://review.openstack.org/335349 | 08:07 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Remove mox in tests/unit/objects/test_compute_node https://review.openstack.org/307625 | 08:07 |
| *** tlbr has joined #openstack-nova | 08:07 | |
| gmann_ | johnthetubaguy: alex_xu oomichi : Can you check this one (for assisted_volume_snapshot API )- https://review.openstack.org/#/c/335349/ | 08:08 |
| alex_xu | gmann_: put it in my review list, will try to reach that later | 08:09 |
| gmann_ | alex_xu: Thanks. very fast response :) | 08:09 |
| johnthetubaguy | gmann_: I still think that will need a new microversion | 08:09 |
| *** shaohe_feng has quit IRC | 08:10 | |
| *** takashin has left #openstack-nova | 08:10 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/303345 | 08:10 |
| gmann_ | johnthetubaguy: humm, even no API change actually | 08:10 |
| johnthetubaguy | gmann_: yeah, sorry, I was thinking you were dropping it in the API | 08:10 |
| johnthetubaguy | gmann_: I thought I added this comment on the API ref review that was updating that stuff | 08:10 |
| *** shaohe_feng has joined #openstack-nova | 08:11 | |
| gmann_ | johnthetubaguy: yea, i too struggled to add api-ref for that | 08:11 |
| openstackgerrit | sahid proposed openstack/nova: network: handle unauthorized exception from neutron https://review.openstack.org/312014 | 08:11 |
| johnthetubaguy | gmann_: so it does change the API I think | 08:11 |
| *** jwcroppe has joined #openstack-nova | 08:12 | |
| gmann_ | johnthetubaguy: humm, i thought just fixing the bug by returning the meaningful and expected id value | 08:12 |
| johnthetubaguy | gmann_: so its possible a user relies on the id they pass in (all be it un used by nova) getting passed back in that return value | 08:13 |
| johnthetubaguy | gmann_: frankly, I think we should return an empty response, and update the return status code | 08:14 |
| johnthetubaguy | but thats a new microversion | 08:14 |
| gmann_ | johnthetubaguy: yea if returning empty then its microversion | 08:15 |
| *** thorst has joined #openstack-nova | 08:15 | |
| gibi_ | johnthetubaguy: hi! I fixed your comments in the instance.update transformation https://review.openstack.org/#/c/325923/ . Could you check it pleases? | 08:15 |
| *** markus_z has joined #openstack-nova | 08:15 | |
| gmann_ | johnthetubaguy: but as this is only used by cinder does not seems worth of microversion | 08:15 |
| gmann_ | i thought of returning correct id value and not sure anyone using this API was comparing/relying on that dummy value | 08:16 |
| johnthetubaguy | gmann_: true, other than clarity of the API | 08:16 |
| johnthetubaguy | gmann_: right, we have no idea how people use our API, so we are not allowed to break the contract | 08:16 |
| *** dimtruck is now known as zz_dimtruck | 08:17 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP Don't check cinder volume states during attach https://review.openstack.org/315789 | 08:17 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: [WIP] Remove check_attach https://review.openstack.org/335358 | 08:17 |
| *** shaohe_feng has quit IRC | 08:20 | |
| *** shaohe_feng has joined #openstack-nova | 08:20 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: [WIP] Remove check_attach https://review.openstack.org/335358 | 08:20 |
| *** DaiDV has quit IRC | 08:20 | |
| *** klkumar has quit IRC | 08:21 | |
| lyarwood | Does anyone know the XenProject CI recheck command before I start spamming comments into a change? I can't seem to find it documented anywhere. | 08:21 |
| *** danpb has joined #openstack-nova | 08:22 | |
| *** thorst has quit IRC | 08:23 | |
| johnthetubaguy | lyarwood: it normally says in its comment | 08:23 |
| johnthetubaguy | xen: recheck I think | 08:23 |
| johnthetubaguy | yeah, it says: Build failed. To recheck use 'xen: recheck'. | 08:24 |
| *** roeyc has quit IRC | 08:24 | |
| lyarwood | johnthetubaguy: yeah sorry, lack of coffee this morning, I just went straight to the wiki and didn't even think to toggle CI comments back on and read them, *sigh* | 08:25 |
| lyarwood | johnthetubaguy: thanks :) | 08:25 |
| johnthetubaguy | lyarwood: no worries, I asked BobBall to find that out myself | 08:25 |
| openstackgerrit | Weiwei Gu proposed openstack/nova: migration volume failed for invalid type https://review.openstack.org/315864 | 08:26 |
| *** roeyc has joined #openstack-nova | 08:27 | |
| *** Daisy has quit IRC | 08:28 | |
| *** jwcroppe has quit IRC | 08:28 | |
| *** Daisy has joined #openstack-nova | 08:28 | |
| *** tyrola has joined #openstack-nova | 08:29 | |
| alex_xu | gmann_: agree with johnthetubaguy on your patch, remove it with microvresion is more safe. | 08:29 |
| *** shaohe_feng has quit IRC | 08:30 | |
| *** ratailor has quit IRC | 08:30 | |
| openstackgerrit | Dao Cong Tien proposed openstack/nova: Ironic Driver: override get_serial_console() https://review.openstack.org/328157 | 08:30 |
| *** shaohe_feng has joined #openstack-nova | 08:31 | |
| *** GB21 has joined #openstack-nova | 08:31 | |
| gibi_ | bauzas: hi! if you have some review time then there are commits in the notification transformation chain that needs a second +2. Chain starts here https://review.openstack.org/#/c/313654/ | 08:32 |
| *** sameo has joined #openstack-nova | 08:32 | |
| *** ratailor has joined #openstack-nova | 08:32 | |
| gmann_ | alex_xu: johnthetubaguy: humm. thinking more on this.. | 08:32 |
| gmann_ | johnthetubaguy: on this - https://review.openstack.org/#/c/326975/7/api-ref/source/parameters.yaml | 08:33 |
| bauzas | gibi_: ack, in a meeting for the next hour, but will try :) | 08:33 |
| gmann_ | johnthetubaguy: mentioning "cinder uuid" will be not good i think as it can be anything | 08:33 |
| johnthetubaguy | gibi_: will try finish off those others ASAP | 08:33 |
| gmann_ | johnthetubaguy: thats why i just mentioned ID passed in create information | 08:33 |
| johnthetubaguy | gmann_: agreed, sorry my comment in there was missleading | 08:33 |
| *** PaulMurray has joined #openstack-nova | 08:34 | |
| johnthetubaguy | gmann_: ignore that one, read the other comments, I think we just say its an arbitry string that gets passed back to the user | 08:34 |
| gmann_ | johnthetubaguy: cool, ll update that | 08:34 |
| *** markvoelker has joined #openstack-nova | 08:34 | |
| *** diga has quit IRC | 08:34 | |
| johnthetubaguy | gmann_: need the same for the id in the response too | 08:34 |
| *** klkumar has joined #openstack-nova | 08:35 | |
| gibi_ | bauzas, johnthetubaguy: thanks a lot! | 08:35 |
| gmann_ | johnthetubaguy: yea, ll try to capture that also | 08:35 |
| *** luis5tb has joined #openstack-nova | 08:37 | |
| markus_z | dims: Do you maybe remember why you put this to "incomplete"? https://bugs.launchpad.net/nova/+bug/1418187 | 08:37 |
| openstack | Launchpad bug 1418187 in nova (Ubuntu) "_get_host_numa_topology assumes numa cell has memory" [Medium,Incomplete] | 08:37 |
| markus_z | sahid: You're the assignee ^ | 08:37 |
| *** ratailor has quit IRC | 08:38 | |
| *** zz_dimtruck is now known as dimtruck | 08:38 | |
| *** ratailor has joined #openstack-nova | 08:38 | |
| *** markvoelker has quit IRC | 08:38 | |
| *** roeyc has quit IRC | 08:39 | |
| *** dmk0202 has joined #openstack-nova | 08:39 | |
| *** shaohe_feng has quit IRC | 08:40 | |
| sahid | markus_z: it's fixed, no? | 08:41 |
| *** ducttape_ has joined #openstack-nova | 08:41 | |
| *** shaohe_feng has joined #openstack-nova | 08:41 | |
| sahid | this patch should have fixed that issue https://review.openstack.org/gitweb?p=openstack/nova.git;a=commitdiff;h=8df48025c36c8bc595f346f0b76ee010ae86737d | 08:41 |
| markus_z | sahid: I'm not sure, is it? | 08:41 |
| *** cheneydc has quit IRC | 08:41 | |
| *** paul-carlton2 has quit IRC | 08:42 | |
| markus_z | sahid: You said so otherwise in the commit message "Also this cannot be considered come a fix for bug 1418187 ..." | 08:42 |
| openstack | bug 1418187 in nova (Ubuntu) "_get_host_numa_topology assumes numa cell has memory" [Medium,Incomplete] https://launchpad.net/bugs/1418187 | 08:42 |
| sahid | yes in a long term perspective, related to the scheduling | 08:42 |
| *** diga has joined #openstack-nova | 08:43 | |
| markus_z | does it make sense to close this one and open a new one which states the problem from a scheduler POV? | 08:44 |
| *** speller has joined #openstack-nova | 08:44 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | 08:44 |
| sahid | markus_z: yes, but actually I think Nikola introcued some patch to let the placement be done by the kernel itself but I can't really remember | 08:45 |
| *** ducttape_ has quit IRC | 08:46 | |
| sahid | it's probably not relevant anymore | 08:46 |
| markus_z | Would you then add a few lines to that bug report and clarify that and close it? Right now the bug triage got a little confused what to do with this. | 08:47 |
| *** speller has quit IRC | 08:49 | |
| pkoniszewski | hello, can i ask for reapprove on this series - https://review.openstack.org/#/q/topic:bp/auto-live-migration-completion ? it failed due to merge conflict, rebase was clean on 2 patches so there is just +W missing | 08:49 |
| openstackgerrit | John Hua proposed openstack/nova: POC: WIP: XenAPI: device tagging https://review.openstack.org/333781 | 08:49 |
| *** shaohe_feng has quit IRC | 08:51 | |
| sahid | markus_z: ok | 08:51 |
| *** yassine__ has joined #openstack-nova | 08:51 | |
| *** shaohe_feng has joined #openstack-nova | 08:51 | |
| markus_z | thanks | 08:51 |
| markus_z | danpb: Good morning. During the virtlogd tests I've seen that the boot message won't get printed into the "console.log" file *unless* I'm already connected to the terminal (executing a 'reboot' for example). | 08:52 |
| *** derekh has joined #openstack-nova | 08:52 | |
| markus_z | danpb: Folks from my Linux department looked into it and they guess that this could be an issue in qemu itself. | 08:53 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: api-ref: verify assisted-volume-snapshots.inc https://review.openstack.org/326975 | 08:53 |
| gmann_ | johnthetubaguy: check if its fine now, added a NOTE also for that id(let me know if does not suits there) | 08:54 |
| gmann_ | johnthetubaguy: link - https://review.openstack.org/326975 | 08:55 |
| tdurakov | johnthetubaguy: ping | 08:55 |
| *** paul-carlton2 has joined #openstack-nova | 08:56 | |
| markus_z | anthonyper: Good morning, got a minute to talk about "get console output"? I'm still breaking it (for XEN) with https://review.openstack.org/#/c/334480/4 and I think I need a second pair of eyes. | 08:57 |
| openstackgerrit | Pawel Koniszewski proposed openstack/nova: libvirt: Live migration fails when config_drive_format=iso9660 https://review.openstack.org/234659 | 08:57 |
| *** mfeoktistov has joined #openstack-nova | 08:58 | |
| *** gongysh has joined #openstack-nova | 08:58 | |
| *** roeyc has joined #openstack-nova | 09:00 | |
| *** shaohe_feng has quit IRC | 09:01 | |
| *** shaohe_feng has joined #openstack-nova | 09:02 | |
| *** lpetrut has quit IRC | 09:04 | |
| *** lpetrut has joined #openstack-nova | 09:04 | |
| *** pece has joined #openstack-nova | 09:08 | |
| johnthetubaguy | tdurakov: hi, I am around | 09:08 |
| tdurakov | could you please review https://review.openstack.org/#/c/332124/ | 09:08 |
| tdurakov | johnthetubaguy: new workflow, without extra param to existing method | 09:09 |
| *** EinstCrazy has quit IRC | 09:10 | |
| johnthetubaguy | tdurakov: ah, you going for adding new methods, I think that may well end up cleaner, will take a look | 09:10 |
| *** ratailor has quit IRC | 09:11 | |
| *** EinstCrazy has joined #openstack-nova | 09:11 | |
| tdurakov | johnthetubaguy: thanks! | 09:11 |
| *** ratailor has joined #openstack-nova | 09:11 | |
| *** shaohe_feng has quit IRC | 09:11 | |
| *** shaohe_feng has joined #openstack-nova | 09:12 | |
| *** imcsk8 has quit IRC | 09:12 | |
| *** imcsk8 has joined #openstack-nova | 09:12 | |
| johnthetubaguy | tdurakov: any chance you could update the git commit message describing the old flow, and the new flow you are adding? | 09:13 |
| tdurakov | 5 min | 09:13 |
| tdurakov | will do | 09:13 |
| tdurakov | johnthetubaguy: ^ | 09:13 |
| *** EinstCra_ has joined #openstack-nova | 09:14 | |
| *** luis5tb has quit IRC | 09:16 | |
| *** EinstCrazy has quit IRC | 09:17 | |
| *** mgoddard has joined #openstack-nova | 09:17 | |
| openstackgerrit | Dao Cong Tien proposed openstack/nova: Stop using mox from unit/virt/xenapi/stubs.py https://review.openstack.org/334848 | 09:18 |
| openstackgerrit | Ricardo Noriega proposed openstack/nova: Fix some typos https://review.openstack.org/335078 | 09:20 |
| *** ratailor has quit IRC | 09:20 | |
| *** thorst has joined #openstack-nova | 09:20 | |
| *** shaohe_feng has quit IRC | 09:21 | |
| tdurakov | johnthetubaguy: could you please explain about min_version? | 09:22 |
| *** Alexei_987 has joined #openstack-nova | 09:22 | |
| *** DaiDV has joined #openstack-nova | 09:22 | |
| *** Alexei_987 has left #openstack-nova | 09:22 | |
| *** ratailor has joined #openstack-nova | 09:23 | |
| *** roeyc has quit IRC | 09:23 | |
| *** shaohe_feng has joined #openstack-nova | 09:24 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Add namespace oslo.db.concurrency in nova-config-generator.conf https://review.openstack.org/335394 | 09:25 |
| *** ociuhandu has quit IRC | 09:25 | |
| *** sudipto has joined #openstack-nova | 09:27 | |
| *** gongysh has quit IRC | 09:27 | |
| *** thorst has quit IRC | 09:28 | |
| johnthetubaguy | tdurakov: yes, the idea is we report the service version for every compute node | 09:29 |
| johnthetubaguy | tdurakov: so we know when every compute node has been upgraded | 09:30 |
| tdurakov | is it in database? | 09:30 |
| johnthetubaguy | tdurakov: its used for data migrations in the conductor | 09:30 |
| johnthetubaguy | tdurakov: yes, it gets cached in each service, and refreshed on a SIG_HUP | 09:30 |
| johnthetubaguy | its what is used to do the auto pinning of the RPC version | 09:30 |
| johnthetubaguy | actually, maybe thats the same information... | 09:31 |
| *** EinstCra_ has quit IRC | 09:31 | |
| tdurakov | johnthetubaguy: could you point me please to the code? | 09:31 |
| *** EinstCrazy has joined #openstack-nova | 09:31 | |
| *** shaohe_feng has quit IRC | 09:32 | |
| *** Daisy has quit IRC | 09:32 | |
| johnthetubaguy | tdurakov: its spread all over the shop, but let me point at a usage of it... https://github.com/openstack/nova/blob/master/nova/objects/pci_device.py#L118 | 09:32 |
| *** Daisy has joined #openstack-nova | 09:32 | |
| *** shaohe_feng has joined #openstack-nova | 09:32 | |
| tdurakov | johnthetubaguy: acked, will address comments and ping you bit later | 09:34 |
| *** GB21 has quit IRC | 09:35 | |
| *** mvk has quit IRC | 09:35 | |
| *** mvk has joined #openstack-nova | 09:36 | |
| *** roeyc has joined #openstack-nova | 09:36 | |
| johnthetubaguy | tdurakov: not sure we need to use min_service version, see the updated comment | 09:36 |
| *** amotoki has quit IRC | 09:37 | |
| *** Daisy has quit IRC | 09:37 | |
| openstackgerrit | Maciej Szankin proposed openstack/nova: config options: Improve help for conductor https://review.openstack.org/324784 | 09:38 |
| tdurakov | johnthetubaguy: yup, need to update tests anyway | 09:38 |
| *** hshiina has quit IRC | 09:38 | |
| tdurakov | and commit message | 09:38 |
| *** Daisy has joined #openstack-nova | 09:39 | |
| *** ducttape_ has joined #openstack-nova | 09:41 | |
| *** shaohe_feng has quit IRC | 09:42 | |
| *** Daisy has quit IRC | 09:43 | |
| *** shaohe_feng has joined #openstack-nova | 09:43 | |
| *** ducttape_ has quit IRC | 09:46 | |
| *** DaiDV has quit IRC | 09:48 | |
| *** salv-orlando has quit IRC | 09:50 | |
| *** amotoki has joined #openstack-nova | 09:50 | |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: libvirt: simplify "get_console_output" interface https://review.openstack.org/334480 | 09:51 |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: DON'T MERGE: more logs for change Ic3c22b96937 https://review.openstack.org/335404 | 09:51 |
| *** shaohe_feng has quit IRC | 09:52 | |
| *** shaohe_feng has joined #openstack-nova | 09:52 | |
| *** GB21 has joined #openstack-nova | 09:53 | |
| *** roeyc has quit IRC | 09:56 | |
| *** sree has quit IRC | 09:56 | |
| openstackgerrit | Hieu LE proposed openstack/nova: Remove mox from unit/virt/libvirt/test_imagebackend.py (2) https://review.openstack.org/335411 | 10:02 |
| *** shaohe_feng has quit IRC | 10:02 | |
| *** shaohe_feng has joined #openstack-nova | 10:03 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Added support for new block device format in vmops https://review.openstack.org/246299 | 10:03 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: hyper-v: device tagging https://review.openstack.org/331889 | 10:03 |
| *** gjayavelu has joined #openstack-nova | 10:04 | |
| *** gjayavelu has quit IRC | 10:09 | |
| *** hoangcx has quit IRC | 10:13 | |
| *** shaohe_feng has quit IRC | 10:13 | |
| *** shaohe_feng has joined #openstack-nova | 10:13 | |
| *** dedery has joined #openstack-nova | 10:16 | |
| *** jichen has quit IRC | 10:21 | |
| *** salv-orlando has joined #openstack-nova | 10:22 | |
| *** shaohe_feng has quit IRC | 10:23 | |
| *** amotoki has quit IRC | 10:23 | |
| *** ftersin has joined #openstack-nova | 10:23 | |
| *** thorst has joined #openstack-nova | 10:25 | |
| *** shaohe_feng has joined #openstack-nova | 10:26 | |
| *** salv-orlando has quit IRC | 10:27 | |
| openstackgerrit | John Garbutt proposed openstack/nova: Make Ironic options definitions consistent https://review.openstack.org/331881 | 10:29 |
| openstackgerrit | John Garbutt proposed openstack/nova: Make Ironic options definitions consistent https://review.openstack.org/331881 | 10:31 |
| openstackgerrit | John Garbutt proposed openstack/nova: Improve help context of ironic options https://review.openstack.org/332433 | 10:31 |
| *** thorst has quit IRC | 10:33 | |
| *** amotoki has joined #openstack-nova | 10:33 | |
| *** shaohe_feng has quit IRC | 10:33 | |
| *** wangqun has quit IRC | 10:34 | |
| *** roeyc has joined #openstack-nova | 10:35 | |
| *** ratailor has quit IRC | 10:36 | |
| *** shaohe_feng has joined #openstack-nova | 10:36 | |
| *** markvoelker has joined #openstack-nova | 10:36 | |
| *** sambetts|afk is now known as sambetts|deadlin | 10:36 | |
| *** sudipto has quit IRC | 10:36 | |
| *** sahid has quit IRC | 10:37 | |
| *** sambetts|deadlin is now known as sambetts|halfher | 10:38 | |
| *** GB21 has quit IRC | 10:38 | |
| *** sambetts|halfher is now known as sambetts|HAK | 10:38 | |
| *** sambetts|HAK is now known as sambetts|HFK | 10:38 | |
| *** sahid has joined #openstack-nova | 10:39 | |
| *** markvoelker has quit IRC | 10:40 | |
| PaulMurray | Hi sahid, do you have a moment to talk about your comments on https://review.openstack.org/#/c/320063/16/nova/objects/console_connection.py | 10:41 |
| *** ratailor has joined #openstack-nova | 10:41 | |
| *** sambetts|HFK is now known as sam|schrodinger | 10:41 | |
| *** sam|schrodinger is now known as sambetts|cat | 10:42 | |
| *** ducttape_ has joined #openstack-nova | 10:42 | |
| *** shaohe_feng has quit IRC | 10:43 | |
| *** amotoki has quit IRC | 10:44 | |
| sahid | PaulMurray: if that is possible for you I prefer to talk throught the review system | 10:45 |
| *** diga has quit IRC | 10:45 | |
| PaulMurray | sahid, I can do that as well, but sometimes a chat is quicker to get an understanding - if you have a minute | 10:45 |
| sahid | PaulMurray: ok | 10:46 |
| PaulMurray | I was actually just adding a comment, but wanted to get your thoughts | 10:46 |
| PaulMurray | at the moment there is a dict being passed around with the connection information | 10:46 |
| *** shaohe_feng has joined #openstack-nova | 10:46 | |
| PaulMurray | the plan is to replace that with this object | 10:47 |
| *** ducttape_ has quit IRC | 10:47 | |
| *** zenoway has joined #openstack-nova | 10:47 | |
| PaulMurray | that's why I put the token back in the object | 10:47 |
| PaulMurray | so I think it needs to be a field for that purpose | 10:47 |
| PaulMurray | does that make sense to you ? | 10:47 |
| mnestratov | hello all | 10:47 |
| *** GB21 has joined #openstack-nova | 10:48 | |
| mnestratov | need some review for https://review.openstack.org/#/c/217679 please | 10:48 |
| *** gszasz has joined #openstack-nova | 10:50 | |
| openstackgerrit | Rong Han proposed openstack/nova: Allow "revert_resize" to recover error instance after resize/migrate https://review.openstack.org/334747 | 10:50 |
| anthonyper | markus_z: Hi, I'll have a look at the "get console output" and try to understand what is broken. | 10:52 |
| *** ratailor has quit IRC | 10:52 | |
| openstackgerrit | Lucian Petrut proposed openstack/nova: Hyper-V: properly handle shared storage https://review.openstack.org/335114 | 10:52 |
| *** sudipto has joined #openstack-nova | 10:53 | |
| *** shaohe_feng has quit IRC | 10:54 | |
| *** ratailor has joined #openstack-nova | 10:54 | |
| *** shaohe_feng has joined #openstack-nova | 10:54 | |
| openstackgerrit | John Garbutt proposed openstack/nova: Config Options: Improve help text for debugger https://review.openstack.org/311822 | 10:55 |
| *** ratailor has quit IRC | 10:55 | |
| *** EinstCrazy has quit IRC | 10:55 | |
| *** ratailor has joined #openstack-nova | 10:55 | |
| openstackgerrit | John Garbutt proposed openstack/nova: Config Options: Improve help text for debugger https://review.openstack.org/311822 | 10:56 |
| *** salv-orlando has joined #openstack-nova | 10:56 | |
| sahid | PaulMurray: you mean you need to pass this object with the token field to consoleauth service ? | 10:57 |
| PaulMurray | no, it is passed between compute manager and api | 10:57 |
| *** ecelik has joined #openstack-nova | 10:58 | |
| PaulMurray | but not at the moment - the relevant parts are packed into a dict | 10:58 |
| *** mfedosin has joined #openstack-nova | 10:58 | |
| sahid | so if that attribute is not in fields it will be lost during the trasnfert, that what you mena? | 10:59 |
| *** salv-orl_ has joined #openstack-nova | 10:59 | |
| openstackgerrit | John Garbutt proposed openstack/nova: Help text for the ephemeral storage options https://review.openstack.org/324907 | 11:00 |
| markus_z | anthonyper: Thanks! I also pushed https://review.openstack.org/#/c/335404/1 to get more log output. | 11:00 |
| *** chhavi has joined #openstack-nova | 11:01 | |
| openstackgerrit | John Garbutt proposed openstack/nova: Help text for the ephemeral storage options https://review.openstack.org/324907 | 11:01 |
| PaulMurray | sahid - yes, that's right | 11:01 |
| openstackgerrit | Evgeny Antyshev proposed openstack/nova: Release note for vzstorage volume driver https://review.openstack.org/335439 | 11:02 |
| *** amotoki has joined #openstack-nova | 11:02 | |
| sahid | i see, this object starts to be kind of obscure, some fields are delcared and not stored and some others are not declared but stored | 11:03 |
| *** salv-orlando has quit IRC | 11:03 | |
| *** shaohe_feng has quit IRC | 11:04 | |
| *** mfedosin has quit IRC | 11:04 | |
| *** shaohe_feng has joined #openstack-nova | 11:04 | |
| *** salv-orl_ has quit IRC | 11:05 | |
| *** smatzek has joined #openstack-nova | 11:05 | |
| PaulMurray | sahid, yes, it is odd - if we could store the token in the database it wouldn't be a problem, but that is considered a security flaw | 11:05 |
| PaulMurray | sahid, so we need to store a hash instead. | 11:05 |
| sahid | PaulMurray: it was not possible to have two objects ? one for the database represantion and one other generated when we need to transfert it over the wire ? | 11:06 |
| PaulMurray | sahid, I'm not sure I understand why. One purpose of objects is to separate db representation from the object representation. Its ok to transform the fields. | 11:08 |
| PaulMurray | sahid, I agree the code in this case looks hacky - jsut trying to find a neat way to write it | 11:09 |
| johnthetubaguy | does the object just hold the hash value? | 11:09 |
| PaulMurray | johnthetubaguy, what I have done so far is include a field called 'token' but store a field called 'token_hash' - I don't retain the hash in the object. | 11:10 |
| johnthetubaguy | does that may the from_db call very strange? | 11:11 |
| PaulMurray | johnthetubaguy, we need to provide the token to retrieve the object, so that gets hashed to do the lookup and put in the object | 11:11 |
| johnthetubaguy | make^ | 11:11 |
| PaulMurray | That is what is odd - swapping items in the dict: https://review.openstack.org/#/c/320063/16/nova/objects/console_connection.py | 11:11 |
| johnthetubaguy | so, if the object just had a token_hash field only, that wouldn't work I guess? | 11:12 |
| *** lucasagomes is now known as lucas-hungry | 11:13 | |
| PaulMurray | I guess so, but we also need the token | 11:13 |
| *** svenkat has joined #openstack-nova | 11:13 | |
| johnthetubaguy | right, thats my question, who needs the token | 11:13 |
| johnthetubaguy | it feels like the object should just store the token hash, and an RPC call that needs the token, gets that string passed to it directly? | 11:14 |
| *** shaohe_feng has quit IRC | 11:14 | |
| *** sudipto has quit IRC | 11:14 | |
| johnthetubaguy | or like sahid said, we have a separate object for RPC, but that might end up being overkill in this case | 11:15 |
| *** shaohe_feng has joined #openstack-nova | 11:15 | |
| *** luis5tb has joined #openstack-nova | 11:15 | |
| johnthetubaguy | (assuming the token is an opaque string) | 11:15 |
| PaulMurray | ...thinking | 11:15 |
| PaulMurray | The reasons I got stuck is I made the object generate the token. There is an authorize() method that generates a token and creates the object in the datbase | 11:16 |
| johnthetubaguy | PaulMurray: that could return the token, and set the token_hash on the object, I supose? | 11:17 |
| PaulMurray | Yes, that is what I did first time around. | 11:17 |
| PaulMurray | I've been back and forth with this | 11:17 |
| johnthetubaguy | oh, did that not work for some other reason? | 11:17 |
| PaulMurray | The token is needed for a url (for consoles) | 11:18 |
| *** mfedosin has joined #openstack-nova | 11:18 | |
| PaulMurray | I put the url generation in the object as well - if the object knows the token everything can be encapsulated in it | 11:18 |
| PaulMurray | if not everything has to be done separately | 11:19 |
| johnthetubaguy | the problem is, you read the object from the database, and it should be complete, I feel | 11:19 |
| johnthetubaguy | where is the code for who calls authorize to get the token? | 11:19 |
| PaulMurray | I did think about doing this in the db api methods instead of the object. I think that makes a lot of sense. | 11:20 |
| PaulMurray | Then the object doesn't need to know | 11:20 |
| johnthetubaguy | ah, so this is very close... | 11:20 |
| johnthetubaguy | PaulMurray: what if you just have the field token_hash? | 11:20 |
| johnthetubaguy | PaulMurray: surely everything is happy then? | 11:20 |
| johnthetubaguy | (as you already return the generated token) | 11:20 |
| PaulMurray | what do you mean? | 11:20 |
| johnthetubaguy | instead of your object field being token | 11:21 |
| johnthetubaguy | make it the token_hash | 11:21 |
| johnthetubaguy | everything else stays the same | 11:21 |
| *** bvanhav has joined #openstack-nova | 11:21 | |
| PaulMurray | yes, but then I have to keep the token as well as the object and if I call a method on the object that needs the token I have to pass it in. | 11:22 |
| PaulMurray | ...and check that the right token is being passed in | 11:22 |
| johnthetubaguy | PaulMurray: yes, I think thats a good thing, we should be explicit about who has the token | 11:22 |
| johnthetubaguy | PaulMurray: so I don't see any object methods that need self.token, am I missing something? | 11:23 |
| PaulMurray | The access_url property | 11:23 |
| *** ftersin_ has joined #openstack-nova | 11:24 | |
| *** kolesovdv has joined #openstack-nova | 11:24 | |
| johnthetubaguy | PaulMurray: ah, so so why not return that from authorize? | 11:24 |
| PaulMurray | https://review.openstack.org/#/c/320063/16/nova/objects/console_connection.py@62 | 11:24 |
| *** shaohe_feng has quit IRC | 11:24 | |
| PaulMurray | the token or the url ? | 11:25 |
| johnthetubaguy | the url | 11:25 |
| *** shaohe_feng has joined #openstack-nova | 11:25 | |
| PaulMurray | actually I do return the token | 11:25 |
| PaulMurray | maybe... | 11:25 |
| johnthetubaguy | right, instead return the url, and store the hash in the object | 11:25 |
| PaulMurray | That may work actually. | 11:26 |
| *** ftersin has quit IRC | 11:26 | |
| johnthetubaguy | its more like generate_access_url at that point, I guess | 11:26 |
| PaulMurray | yes | 11:26 |
| PaulMurray | I did start with that access_url property being a function that took the token as a property. | 11:27 |
| PaulMurray | ...as a parameter I mean | 11:27 |
| PaulMurray | but I'm not sure I need the token to be returned - except that it makes the refactor a pain | 11:27 |
| PaulMurray | I think this is not going to make it in the next two days | 11:28 |
| *** sree has joined #openstack-nova | 11:28 | |
| *** rodrigods has quit IRC | 11:28 | |
| PaulMurray | so I'll think around it a bit more | 11:28 |
| *** rodrigods has joined #openstack-nova | 11:28 | |
| johnthetubaguy | OK | 11:28 |
| PaulMurray | thanks though - useful as alway | 11:28 |
| johnthetubaguy | you might want to think more about the create call | 11:29 |
| *** tinbar has joined #openstack-nova | 11:29 | |
| johnthetubaguy | PaulMurray: maybe return the url and the object from a create method? | 11:29 |
| *** tinbar has quit IRC | 11:29 | |
| *** irenab has quit IRC | 11:29 | |
| johnthetubaguy | the object allows you to validate tokens, that being its main use, I assume | 11:30 |
| *** jlanoux has quit IRC | 11:30 | |
| PaulMurray | it also stores the information needed for the proxies to connect to the correct instance | 11:31 |
| PaulMurray | It needs the extrenal access details to validate the method used to connect | 11:31 |
| PaulMurray | it needs the internal access details to connect - and to check with the compute manager that it is going to connect to the right thing | 11:32 |
| PaulMurray | and it needs the token as a credential | 11:32 |
| PaulMurray | So there is actually more checking going on then it appears at first | 11:32 |
| *** sree has quit IRC | 11:33 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: hyper-v: device tagging https://review.openstack.org/331889 | 11:33 |
| johnthetubaguy | PaulMurray: yeah, so I think the model is wrong here... | 11:33 |
| johnthetubaguy | PaulMurray: thinking about this more, create a separate object just for the ConsoleAuthToken (i.e. the hash that is stored), but have that as a field in a (non persisted) object called ConsoleConnection, I think there are two objects here, with different APIs | 11:34 |
| *** shaohe_feng has quit IRC | 11:35 | |
| *** shaohe_feng has joined #openstack-nova | 11:35 | |
| *** dimtruck is now known as zz_dimtruck | 11:36 | |
| PaulMurray | did you mean "ConsoleAuthToken is a non-persisted field in ConsoleConnection" | 11:36 |
| PaulMurray | or ConsoleConnection is nont persisted ? | 11:36 |
| *** markvoelker has joined #openstack-nova | 11:37 | |
| mdbooth | lyarwood danpb: Got a minute to talk about stable rescue? | 11:37 |
| mdbooth | I'm just reviewing lyarwood's patch, and I've spotted a potential issue | 11:38 |
| mdbooth | However, I don't see how it works in the existing code either | 11:38 |
| mdbooth | Issue is with config disks | 11:38 |
| mdbooth | The new stable rescue adds the existing config disk to the rescue domain xml | 11:38 |
| mdbooth | It *doesn't* add the rescue config disk to the domain xml | 11:39 |
| mdbooth | Which means that we'll presumably use the non-rescue config disk | 11:39 |
| mdbooth | However, the existing code doesn't seem to add any config disk to the domain xml | 11:39 |
| mdbooth | So how on earth does it work? | 11:39 |
| johnthetubaguy | PaulMurray: I mean ConsoleConnection has no persistent fields, one of those is the ConsoleAuthToken object that is persisted | 11:39 |
| *** irenab has joined #openstack-nova | 11:40 | |
| mdbooth | Also, what would be the implications of adding 2 config disks to the same guest? | 11:40 |
| mdbooth | iow, perhaps stable should only add the rescue config disk, but that would be a wart in itself. | 11:40 |
| *** markvoelker has quit IRC | 11:41 | |
| danpb | mdbooth: i didn't know there was a separate config disk for rescue mode ? why would that be needed ? | 11:41 |
| lyarwood | mdbooth: ah wait, check _get_guest_storage_config, it looks like we only add the old disk.conf to the domain in both cases | 11:41 |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Return instance of Guest from method write_instance_config https://review.openstack.org/265146 | 11:41 |
| danpb | afaik the only extra disk was supposed to be the rescue image disk | 11:41 |
| mdbooth | danpb: We specifically generate a 'rescue config disk' | 11:42 |
| mdbooth | There's a 'rescue_password' | 11:42 |
| danpb | mdbooth: why ? | 11:42 |
| mdbooth | which I assume lives in the rescue config disk | 11:42 |
| PaulMurray | johnthetubaguy, I have to go - I will think more, thanks | 11:42 |
| lyarwood | mdbooth: sorry correction ,that's only if disk.config is in the mapping that it isn't for the original unstable rescues | 11:42 |
| *** thorst has joined #openstack-nova | 11:42 | |
| *** ducttape_ has joined #openstack-nova | 11:43 | |
| *** ayoung has quit IRC | 11:43 | |
| lyarwood | mdbooth: that's also injected into the rescue image if configured | 11:43 |
| * mdbooth doesn't know where the rescue password comes from or how important it is | 11:43 | |
| mdbooth | lyarwood: Only if there's no config disk | 11:43 |
| mdbooth | iirc | 11:43 |
| *** amotoki has quit IRC | 11:44 | |
| mdbooth | Oh, that code has changed in the last couple of days | 11:44 |
| danpb | mdbooth: if there's a changed passwd, i'd expect the original config disk to be rebuilt to include it - certainly having 2 config disks on one vm doesn't make sense | 11:44 |
| mdbooth | danpb: Well it might not be changed, just different | 11:44 |
| mdbooth | i.e. 1 for rescue, 1 for not | 11:44 |
| claudiub | alaski: hi. you previously had a +2 on this, can you approve pls? https://review.openstack.org/#/c/330035/ | 11:44 |
| mdbooth | I don't know what the contract is here | 11:45 |
| *** shaohe_feng has quit IRC | 11:45 | |
| *** ociuhandu has joined #openstack-nova | 11:45 | |
| mdbooth | Um... | 11:45 |
| lyarwood | mdbooth: AFAICT for a rescue we will attempt to inject the new pass into the rescue image if CONF.libvirt.inject_partition != -2 but anyway that isn't the issue here | 11:45 |
| *** shaohe_feng has joined #openstack-nova | 11:45 | |
| mdbooth | With change I931421ea688641e2ceb212c6dc099639c53433f2 we're now doing injection when there's a config disk, whereas previously we didn't | 11:46 |
| *** fifieldt has quit IRC | 11:47 | |
| mdbooth | lyarwood: I wonder if ^^^ was an unintentional consequence of this recently merged change | 11:47 |
| *** ducttape_ has quit IRC | 11:47 | |
| mdbooth | artom: ^^^ | 11:47 |
| mdbooth | I wonder if this is a problem | 11:48 |
| mdbooth | If we're now doing injection where previously we didn't, could that break users? | 11:48 |
| alaski | claudiub: got it | 11:49 |
| *** chandankumar has quit IRC | 11:50 | |
| artom | mdbooth, yeah, that's... potentially a problem | 11:51 |
| mdbooth | lyarwood: I'm just going to dump my review comments as is | 11:51 |
| *** chandankumar has joined #openstack-nova | 11:51 | |
| lyarwood | mdbooth: thanks, just to confirm that for the original unstable rescues we don't add the config disk, for the new stable rescues we add the original config disk | 11:53 |
| *** ratailor has quit IRC | 11:53 | |
| mdbooth | Can anybody add context to this? I understand how config disks are created and added to a domain, but honestly not really how user's use them. | 11:53 |
| pkoniszewski | johnthetubaguy: hi, could you reapprove https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/auto-live-migration-completion ? We lost +W on two patches due to a rebase, auto converge patch had a conflict so lost everything | 11:53 |
| lyarwood | mdbooth: http://docs.openstack.org/user-guide/cli_config_drive.html might help | 11:54 |
| mdbooth | lyarwood: I'm not convinced the rescue password ever worked | 11:54 |
| lyarwood | mdbooth: and http://cloudinit.readthedocs.io/en/latest/topics/datasources.html | 11:54 |
| mdbooth | So how did users log in? | 11:54 |
| lyarwood | mdbooth: well there's no logging in with most rescue images | 11:55 |
| mdbooth | Hardcoded admin password in the root image? | 11:55 |
| *** shaohe_feng has quit IRC | 11:55 | |
| lyarwood | mdbooth: live ISOs etc just drop into a rescue shell and allow you to poke around | 11:55 |
| *** aysyd has joined #openstack-nova | 11:56 | |
| mdbooth | With no authentication, in a cloud environment, and your data attached | 11:56 |
| *** shaohe_feng has joined #openstack-nova | 11:56 | |
| mdbooth | Over the network | 11:56 |
| mdbooth | Nice | 11:56 |
| *** jlanoux has joined #openstack-nova | 11:56 | |
| *** akshai has joined #openstack-nova | 11:57 | |
| lyarwood | mdbooth: over a console, not over the network | 11:57 |
| lyarwood | mdbooth: well, in terms of ssh etc that I assume you mean right? | 11:57 |
| mdbooth | Ah, ok | 11:57 |
| mdbooth | Yeah | 11:57 |
| *** sean-k-mooney has quit IRC | 11:57 | |
| * mdbooth wasn't thinking about login over console | 11:57 | |
| mdbooth | So, I guess that previously the rescue disk worked because you could log in over console | 11:58 |
| mdbooth | So network info not required | 11:58 |
| mdbooth | admin password is hardcoded or not required | 11:58 |
| *** jwcroppe has joined #openstack-nova | 11:58 | |
| mdbooth | Stable now uses original admin password. This is better, but possibly still wrong? | 11:59 |
| mdbooth | artom: Do you plan to fix the injection thing? | 11:59 |
| artom | mdbooth, we are now :) | 12:00 |
| mdbooth | artom: :) | 12:00 |
| artom | Everyone missed that in the FF craziness | 12:00 |
| lyarwood | mdbooth: well they both methods of rescue pass the rescue_password as admin_password to _create_images that will try to inject it if configured at present | 12:01 |
| mdbooth | artom: I'm embarassed to say I've never even looked at the series :( | 12:01 |
| artom | mdbooth, nothing to be embarrassed about - if it makes you feel better, I have no idea what a storage pool even is, but I've heard you're working on them? | 12:02 |
| *** phuongnh has quit IRC | 12:02 | |
| *** fifieldt has joined #openstack-nova | 12:02 | |
| *** takedakn has joined #openstack-nova | 12:03 | |
| *** ducttape_ has joined #openstack-nova | 12:04 | |
| *** xyang1 has joined #openstack-nova | 12:04 | |
| *** pece has quit IRC | 12:05 | |
| *** ducttape_ has quit IRC | 12:05 | |
| *** jwcroppe has quit IRC | 12:05 | |
| *** shaohe_feng has quit IRC | 12:05 | |
| *** shaohe_feng has joined #openstack-nova | 12:06 | |
| *** ducttape_ has joined #openstack-nova | 12:06 | |
| mdbooth | lyarwood: So, I do have a concern | 12:07 |
| mdbooth | I think that currently it's broken. rescue_password has no effect. | 12:07 |
| *** markvoelker has joined #openstack-nova | 12:08 | |
| mdbooth | With stable rescue, that will still be the case, but the non-rescue config disk will be used, so the non-rescue admin password and network config will be used for rescue. | 12:08 |
| *** GB21 has quit IRC | 12:08 | |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.add_fixed_ip notification https://review.openstack.org/332876 | 12:09 |
| mdbooth | That means that we can never fix rescue in the future to use the rescue config explicitly passed in by the api without breaking users relying on the broken behaviour | 12:09 |
| lyarwood | mdbooth: that's assuming cloud-init etc is used in the rescue image but yeah | 12:09 |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: DON'T MERGE: more logs for change Ic3c22b96937 https://review.openstack.org/335461 | 12:09 |
| mdbooth | To me, that falls under 'inevitable future regression' | 12:09 |
| mdbooth | So, do we care? | 12:10 |
| *** baoli has joined #openstack-nova | 12:10 | |
| *** salv-orlando has joined #openstack-nova | 12:10 | |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: DON'T MERGE: more logs for change Ic3c22b96937 https://review.openstack.org/335461 | 12:10 |
| mdbooth | Well, do we care *enough*? | 12:10 |
| *** mgoddard has quit IRC | 12:10 | |
| lyarwood | mdbooth: ack, I should be able to correct this so that we use the .rescue config for stable rescues now along with the nits you've added to the review | 12:10 |
| mdbooth | Because stable rescue is an awesome feature, and this is a relatively small thing. | 12:10 |
| *** wangqun has joined #openstack-nova | 12:11 | |
| mdbooth | lyarwood: Would we have to remove the existing config disk? | 12:11 |
| mdbooth | To ensure we don't pick it up accidentally? | 12:11 |
| *** GB21 has joined #openstack-nova | 12:11 | |
| lyarwood | mdbooth: we could but I think we can ensure it isn't picked up at all | 12:12 |
| lyarwood | mdbooth: I'll give it a try anyway, fix the nits and report back | 12:12 |
| mdbooth | I'll take your word on that, because I know nothing about cloud-init | 12:12 |
| lyarwood | mdbooth: right, by not picked up I mean that it isn't going to be added to the domain for the rescue | 12:13 |
| lyarwood | mdbooth: we can't stop it from being picked up within the domain if cloud-init etc is there | 12:13 |
| mdbooth | lyarwood: Gotcha | 12:13 |
| *** vishwanathj has joined #openstack-nova | 12:13 | |
| *** klkumar has quit IRC | 12:13 | |
| lyarwood | mdbooth: and if a user wants to play around with it they can do during a normal boot, they don't need a rescue to do that | 12:13 |
| kashyap | artom: It's just a data store (could be local storage on your FS, or NFS, etc). To get a quick sense, on your system which has libvirtd dunning, do `virsh pool list` & `virsh pool-info default`. | 12:13 |
| mdbooth | That's still a wart by the stable rescue manifesto, I think, because there's an aspect of the instance you can't inspect from the rescue instance. | 12:13 |
| mdbooth | But probably not a big deal in practise. | 12:14 |
| lyarwood | Yeah true, worth a line in the commit and release note | 12:14 |
| *** salv-orlando has quit IRC | 12:14 | |
| *** shaohe_feng has quit IRC | 12:16 | |
| *** shaohe_feng has joined #openstack-nova | 12:17 | |
| *** ljxiash has joined #openstack-nova | 12:17 | |
| *** ivase has joined #openstack-nova | 12:18 | |
| *** mgoddard has joined #openstack-nova | 12:21 | |
| *** lucas-hungry is now known as lucasagomes | 12:22 | |
| *** ducttape_ has quit IRC | 12:23 | |
| *** eharney has quit IRC | 12:24 | |
| *** akshai has quit IRC | 12:24 | |
| *** ftersin has joined #openstack-nova | 12:25 | |
| *** shaohe_feng has quit IRC | 12:26 | |
| *** baoli has quit IRC | 12:26 | |
| *** shaohe_feng has joined #openstack-nova | 12:27 | |
| *** ftersin_ has quit IRC | 12:27 | |
| *** akshai has joined #openstack-nova | 12:27 | |
| *** pradk has joined #openstack-nova | 12:28 | |
| *** akshai_ has joined #openstack-nova | 12:28 | |
| openstackgerrit | Paul Carlton proposed openstack/nova: Permit Live Migration of Rescued Instances https://review.openstack.org/308198 | 12:29 |
| openstackgerrit | Paul Carlton proposed openstack/nova: Add a test utility for checking mock calls with objects https://review.openstack.org/333947 | 12:29 |
| paul-carlton2 | johnthetubaguy can you review my changes/comments in the above pls, doing the api changes now | 12:30 |
| *** baoli has joined #openstack-nova | 12:30 | |
| *** erlon has joined #openstack-nova | 12:32 | |
| *** akshai has quit IRC | 12:32 | |
| *** muawiakhan has quit IRC | 12:33 | |
| openstackgerrit | Alexis Lee proposed openstack/nova: Make LM downtime params mutable https://review.openstack.org/319254 | 12:34 |
| openstackgerrit | Alexis Lee proposed openstack/nova: Make LM timeout params mutable https://review.openstack.org/319203 | 12:35 |
| *** muawiakhan has joined #openstack-nova | 12:35 | |
| *** baoli has quit IRC | 12:35 | |
| *** zenoway has quit IRC | 12:35 | |
| *** shaohe_feng has quit IRC | 12:36 | |
| *** sree has joined #openstack-nova | 12:36 | |
| *** vishwanathj has quit IRC | 12:37 | |
| *** shaohe_feng has joined #openstack-nova | 12:37 | |
| *** andreas_s has quit IRC | 12:37 | |
| *** diogogmt has quit IRC | 12:38 | |
| *** salv-orlando has joined #openstack-nova | 12:39 | |
| *** luis5tb has quit IRC | 12:39 | |
| paul-carlton2 | If I add a static method to 'class Instances' do I need to add a new version? | 12:40 |
| *** chandankumar has quit IRC | 12:45 | |
| *** tbachman has quit IRC | 12:45 | |
| *** eharney has joined #openstack-nova | 12:45 | |
| *** zenoway has joined #openstack-nova | 12:46 | |
| *** salv-orlando has quit IRC | 12:46 | |
| *** shaohe_feng has quit IRC | 12:46 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Depracate Images Proxy APIs https://review.openstack.org/332631 | 12:46 |
| openstackgerrit | Alex Xu proposed openstack/nova: Deprecate Baremetal and fping API https://review.openstack.org/333824 | 12:46 |
| openstackgerrit | Alex Xu proposed openstack/nova: Deprecated networks related proxy APIs https://review.openstack.org/333151 | 12:46 |
| openstackgerrit | Alex Xu proposed openstack/nova: Filter network related quotas out of quotas API in 2.31 https://review.openstack.org/333825 | 12:46 |
| openstackgerrit | Alex Xu proposed openstack/nova: Deprecate FixedIP related proxy APIs https://review.openstack.org/333152 | 12:46 |
| openstackgerrit | Alex Xu proposed openstack/nova: Deprecated floating ip related proxy APIs https://review.openstack.org/333821 | 12:46 |
| openstackgerrit | Alex Xu proposed openstack/nova: Deprecate SecurityGroup related proxy API https://review.openstack.org/333822 | 12:46 |
| openstackgerrit | Alex Xu proposed openstack/nova: Deprecate volumes related APIs https://review.openstack.org/333823 | 12:46 |
| *** shaohe_feng has joined #openstack-nova | 12:47 | |
| *** salv-orlando has joined #openstack-nova | 12:48 | |
| *** gongysh has joined #openstack-nova | 12:48 | |
| *** tbachman has joined #openstack-nova | 12:48 | |
| *** roeyc has quit IRC | 12:48 | |
| *** edmondsw has joined #openstack-nova | 12:48 | |
| alaski | paul-carlton2: if it's not a remotable method I don't believe it changes the object hash which would require a new version. It likely depends on what exactly you're doing but a non remotable static method may not need a new version | 12:48 |
| * alex_xu reminds the nova api meeting will begin in 10 mins in #openstack-meeting-4 channel | 12:50 | |
| *** andreas_s has joined #openstack-nova | 12:52 | |
| *** wangqun has quit IRC | 12:52 | |
| *** diogogmt has joined #openstack-nova | 12:52 | |
| *** EinstCrazy has joined #openstack-nova | 12:53 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: policy: Replaces 'authorize' in nova-api (part 4) https://review.openstack.org/330036 | 12:53 |
| *** sudipto has joined #openstack-nova | 12:54 | |
| claudiub | ^ pls reapprove. :) | 12:54 |
| claudiub | alaski: ^ | 12:54 |
| alaski | done | 12:56 |
| claudiub | \o/ | 12:56 |
| *** shaohe_feng has quit IRC | 12:57 | |
| openstackgerrit | Gleb Stepanov proposed openstack/nova: Pin HTTP response codes to API microversions https://review.openstack.org/305369 | 12:57 |
| *** shaohe_feng has joined #openstack-nova | 12:57 | |
| *** gmann has joined #openstack-nova | 12:57 | |
| *** zerda2 has quit IRC | 12:58 | |
| * alex_xu reminders nova api meeting is running | 13:01 | |
| *** GB21 has quit IRC | 13:02 | |
| paul-carlton2 | alaski, thanks, i'm just getting minimum version of compute service, I'll see what reviewer say | 13:02 |
| *** zenoway has quit IRC | 13:02 | |
| *** tyrola_ has joined #openstack-nova | 13:03 | |
| *** pwnall has joined #openstack-nova | 13:03 | |
| *** liverpooler has quit IRC | 13:03 | |
| *** tyrola has quit IRC | 13:04 | |
| *** rlrossit has joined #openstack-nova | 13:04 | |
| *** woodster_ has joined #openstack-nova | 13:05 | |
| *** sameo has quit IRC | 13:05 | |
| *** shaohe_feng has quit IRC | 13:07 | |
| *** shaohe_feng has joined #openstack-nova | 13:08 | |
| *** mdrabe has joined #openstack-nova | 13:08 | |
| *** tblakeslee has joined #openstack-nova | 13:08 | |
| *** M00nr41n has quit IRC | 13:11 | |
| *** ihrachys has quit IRC | 13:11 | |
| *** mriedem has joined #openstack-nova | 13:12 | |
| *** ihrachys has joined #openstack-nova | 13:13 | |
| openstackgerrit | John Garbutt proposed openstack/nova: api-ref: os-certificates.inc https://review.openstack.org/323365 | 13:14 |
| *** code-R has joined #openstack-nova | 13:17 | |
| *** sdake has joined #openstack-nova | 13:17 | |
| *** shaohe_feng has quit IRC | 13:17 | |
| *** shaohe_feng has joined #openstack-nova | 13:18 | |
| *** sameo has joined #openstack-nova | 13:18 | |
| edleafe | Can anyone explain why https://review.openstack.org/#/c/282419/ is stuck? It has 3 +2s, and was +W'd almost 2 months ago. | 13:21 |
| *** code-R_ has joined #openstack-nova | 13:21 | |
| mriedem | edleafe: dependencies in the series aren't merged | 13:21 |
| *** sdake_ has joined #openstack-nova | 13:22 | |
| *** sdake has quit IRC | 13:22 | |
| edleafe | mriedem: ah, ok | 13:22 |
| *** svenkat_ has joined #openstack-nova | 13:22 | |
| edleafe | It's not hugely important; just wondering why it was still there | 13:23 |
| *** svenkat has quit IRC | 13:23 | |
| *** svenkat_ is now known as svenkat | 13:23 | |
| *** ducttape_ has joined #openstack-nova | 13:24 | |
| *** code-R has quit IRC | 13:24 | |
| *** ftersin_ has joined #openstack-nova | 13:25 | |
| *** sdake has joined #openstack-nova | 13:26 | |
| *** sdake_ has quit IRC | 13:27 | |
| *** rook has quit IRC | 13:27 | |
| *** c64cosmin has joined #openstack-nova | 13:27 | |
| *** shaohe_feng has quit IRC | 13:27 | |
| *** ftersin has quit IRC | 13:28 | |
| *** roeyc has joined #openstack-nova | 13:28 | |
| *** ducttape_ has quit IRC | 13:29 | |
| *** cleong has joined #openstack-nova | 13:29 | |
| *** shaohe_feng has joined #openstack-nova | 13:30 | |
| *** oomichi_ has joined #openstack-nova | 13:32 | |
| *** edand has quit IRC | 13:32 | |
| *** diogogmt has quit IRC | 13:32 | |
| *** mdrabe has quit IRC | 13:34 | |
| *** mdrabe has joined #openstack-nova | 13:35 | |
| dansmith | mriedem: I think I posted a solution for the "two nics on a network with different tags" problem on the manager patch | 13:35 |
| *** links has quit IRC | 13:36 | |
| mriedem | get right out of town | 13:36 |
| paul-carlton2 | yes | 13:36 |
| paul-carlton2 | wrong window¬ | 13:37 |
| openstackgerrit | Paul Carlton proposed openstack/nova: API changes for live migration of rescued instance https://review.openstack.org/328280 | 13:37 |
| *** shaohe_feng has quit IRC | 13:38 | |
| gibi_ | mriedem: hi! It is a frindly reminder about the notification transformation patches. The 3 important patch only needs second +2 https://review.openstack.org/#/c/313654/ | 13:38 |
| *** shaohe_feng has joined #openstack-nova | 13:38 | |
| mriedem | dansmith: ok, i'll look after the api meeting and once my caffeine headache goes away | 13:40 |
| dansmith | mriedem: sure | 13:40 |
| vladikr | dansmith, Morning, but what is there are 3? :) What if we will add a tag field to the VIF model and tag these in allocate_for_instance (for neutron), then in the manager, we could run over the vifs and if it's not neutron we will do the same as we do now.. won't it work? | 13:40 |
| vladikr | s/is/if | 13:40 |
| *** roeyc has quit IRC | 13:41 | |
| *** code-R_ has quit IRC | 13:41 | |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.add_fixed_ip notification https://review.openstack.org/332876 | 13:41 |
| dansmith | vladikr: yeah, that is probably okay too. I hate touching the vif model because it's so ill-defined, but that will probably be okay | 13:41 |
| *** code-R has joined #openstack-nova | 13:41 | |
| markus_z | Should I execute functional tests in a VM or is it ok to use my local machine? The docs I found don't clarify that: http://docs.openstack.org/developer/nova/test_strategy.html?highlight=functional#functional-tests | 13:41 |
| dansmith | vladikr: did you see my suggestion in the manager patch for just counting? | 13:42 |
| dansmith | I'm not really sure why that wouldn't work either | 13:42 |
| *** ayoung has joined #openstack-nova | 13:42 | |
| *** ayoung has quit IRC | 13:42 | |
| *** rlrossit has quit IRC | 13:42 | |
| *** ayoung has joined #openstack-nova | 13:42 | |
| vladikr | dansmith, ah, did you just comment ? looking | 13:42 |
| openstackgerrit | Evgeny Antyshev proposed openstack/nova: Release note for vzstorage volume driver https://review.openstack.org/335439 | 13:42 |
| dansmith | no, last night | 13:42 |
| dansmith | vladikr: https://review.openstack.org/#/c/264017/63/nova/compute/manager.py | 13:43 |
| *** muawiakhan has quit IRC | 13:43 | |
| dansmith | vladikr: line 1352, second part of the comment | 13:43 |
| *** efried has quit IRC | 13:43 | |
| *** Qiming has quit IRC | 13:44 | |
| *** Qiming has joined #openstack-nova | 13:44 | |
| mdbooth | artom: In https://review.openstack.org/#/c/303335/, how does moving the creation of the config disk change anything about its contents? | 13:44 |
| mdbooth | Or did I miss something? | 13:44 |
| *** jaugustine has joined #openstack-nova | 13:44 | |
| dansmith | mdbooth: we have to move it to late enough that we have device assignments | 13:44 |
| dansmith | mdbooth: like PCI | 13:44 |
| mdbooth | dansmith: I can't see where they're passed in, though | 13:45 |
| mdbooth | Or is that patch not there, yet? | 13:45 |
| dansmith | mdbooth: next patch | 13:45 |
| * mdbooth stops searching for something that's not there :) | 13:45 | |
| dansmith | well, maybe the one after that actually, but.. | 13:45 |
| lyarwood | artom / dansmith ; and that's something that would be useful during a rescue? | 13:45 |
| dansmith | lyarwood: down the road we need to regenerate the config drive any time we boot the instance, so yeah | 13:46 |
| mdbooth | artom: Are you filing a bug for the injection thing, btw? | 13:46 |
| *** klkumar has joined #openstack-nova | 13:46 | |
| *** mgoddard_ has joined #openstack-nova | 13:46 | |
| * mdbooth would give it a big red scary regression flag personally. | 13:46 | |
| lyarwood | dansmith: right, even if we are booting from a rescue image that is likely a different OS install (live or otherwise)? | 13:46 |
| dansmith | mdbooth: which injection thing? | 13:46 |
| dansmith | lyarwood: absolutely | 13:47 |
| mdbooth | dansmith: With the new patch, we're now injecting into the root disk even if we're using a config disk | 13:47 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Introduce the memory bandwidth monitor https://review.openstack.org/329783 | 13:47 |
| dansmith | mdbooth: I don't know what you're talking about :) | 13:47 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Introduce utility module for pcp https://review.openstack.org/203163 | 13:47 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor https://review.openstack.org/266773 | 13:47 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Update setup.cfg for memory bandwidth monitor https://review.openstack.org/329785 | 13:47 |
| *** ctrath has joined #openstack-nova | 13:48 | |
| *** shaohe_feng has quit IRC | 13:48 | |
| *** shaohe_feng has joined #openstack-nova | 13:48 | |
| mdbooth | dansmith: https://review.openstack.org/#/c/303335/41/nova/virt/libvirt/driver.py line 3001 of before code | 13:48 |
| sudipto | gibi_, thanks for the review. I have incorporated your comments ^ can you pls take a look when you can? | 13:48 |
| gibi_ | sudipto: looking... | 13:49 |
| *** mpavone has quit IRC | 13:49 | |
| dansmith | mdbooth: ah, I don't think that's intentional | 13:49 |
| mdbooth | Yeah, we discussed it earlier. | 13:49 |
| mdbooth | Not worth a revert, but should be fixed asap. | 13:50 |
| dansmith | ah, sorry | 13:50 |
| dansmith | yeah, agreed | 13:50 |
| *** mgoddard has quit IRC | 13:50 | |
| *** thumpba has joined #openstack-nova | 13:50 | |
| * dansmith is all caught up now (hopefully) | 13:50 | |
| lyarwood | dansmith: final question, and this is all still valid even if the disk ordering has changed as a result of the rescue? I should really go and read the tagging spec I guess. | 13:50 |
| *** thumpba has quit IRC | 13:51 | |
| vladikr | mdbooth, I can handle it , won't checking for configdrive.required_by(instance) will fix it? | 13:51 |
| dansmith | lyarwood: meaning does stable disks in rescue obviate the need for tagging? | 13:51 |
| *** thumpba has joined #openstack-nova | 13:51 | |
| *** mmandel has joined #openstack-nova | 13:51 | |
| dansmith | vladikr: I think so yeah | 13:51 |
| vladikr | okay, I'll submit a patch | 13:51 |
| *** tyrola_ has quit IRC | 13:51 | |
| *** prateek has quit IRC | 13:52 | |
| lyarwood | dansmith: well the original unstable method changed the order, stable should keep it the same and I'm assuming can still use the provided metadata | 13:52 |
| vladikr | dansmith, wrt the requested_networks .. I think your suggestion is easier. Also, can't we rely on the fact that requested_networks and nwinfo should be in the same order? | 13:52 |
| dansmith | lyarwood: yeah, but it's not that we need the metadata to be different in rescue, we need it to be refreshed any chance we get | 13:52 |
| *** diga has joined #openstack-nova | 13:53 | |
| dansmith | lyarwood: for example, lets say I'm automating a rescue, so I set a piece of metadata on each instance and then rescue them and run a script that checks that metadata value in order to do a thing | 13:53 |
| dansmith | lyarwood: if I'm on metadata server that works great, but if I'm on configdrive and don't regen when I boot into rescue, I never see the new value | 13:54 |
| dansmith | vladikr: not sure about the order, you'd have to validate that, but agreed, I think not mucking with the network model is ideal if we can manage :) | 13:54 |
| *** chandankumar has joined #openstack-nova | 13:54 | |
| *** ssurana has joined #openstack-nova | 13:54 | |
| dansmith | lyarwood: is there something that causes you issues with this? | 13:54 |
| *** apanaitiu has quit IRC | 13:56 | |
| *** ametts has joined #openstack-nova | 13:56 | |
| *** shaohe_feng has quit IRC | 13:58 | |
| lyarwood | dansmith: sorry, I just didn't think that was a valid use case for a rescue, stable or otherwise | 13:59 |
| *** shaohe_feng has joined #openstack-nova | 13:59 | |
| openstackgerrit | Gene Kuo proposed openstack/nova: Fix nova delete with EFI booted VMs https://review.openstack.org/335512 | 13:59 |
| gmann | mriedem: no we are not changing the response as it need version bump | 14:00 |
| lyarwood | dansmith: I've been thinking of them in terms of physical hosts and what you would typically do to rescue them, live ISOs, manually pulling off data etc | 14:00 |
| alex_xu | mriedem: yea, as gmann said | 14:00 |
| *** ajo_ has joined #openstack-nova | 14:00 | |
| dansmith | lyarwood: okay | 14:00 |
| gmann | mriedem: only question, should we do that(which need version bump) | 14:00 |
| *** rlrossit has joined #openstack-nova | 14:00 | |
| *** rook- has joined #openstack-nova | 14:00 | |
| mdbooth | dansmith: So, I hate lyarwood's test: https://review.openstack.org/#/c/270289/18/nova/tests/unit/virt/libvirt/test_driver.py :) | 14:01 |
| openstackgerrit | Gene Kuo proposed openstack/nova: Fix nova delete with EFI booted VMs https://review.openstack.org/335512 | 14:01 |
| gmann | or leave as it is as its not so critical and creating issues even response is not good in this API | 14:01 |
| *** pece has joined #openstack-nova | 14:01 | |
| mdbooth | However, I've offered to write him a new one | 14:01 |
| mdbooth | Given we're up against a deadline, though, mind if I run it by you first? | 14:01 |
| *** c64cosmin has quit IRC | 14:02 | |
| mriedem | gmann: alex_xu: the id change in the response is a behavior change | 14:02 |
| mriedem | so it needs a microversion imo | 14:02 |
| dansmith | mdbooth: hmm, yeah, not sure I see where any ordering is really validated there | 14:02 |
| *** sameo is now known as sameo_afk | 14:02 | |
| gmann | mriedem: yes, it need version bump | 14:03 |
| mdbooth | dansmith: I was planning to attempt to rewrite the test to actually generate the xml | 14:03 |
| *** jaugustine has quit IRC | 14:03 | |
| mdbooth | Then parse the xml to pull out disk paths and ordering | 14:03 |
| *** mgoddard_ has quit IRC | 14:03 | |
| gmann | mriedem: but should we do that change? or leave as it is currently | 14:03 |
| *** ajo_ has quit IRC | 14:03 | |
| dansmith | mdbooth: yeah, that's the only thing that really matters, right? that the xml is in the right order | 14:03 |
| mriedem | gmann: it seems like busy work if no one cares about this | 14:03 |
| *** jwcroppe has joined #openstack-nova | 14:04 | |
| *** ajo_ has joined #openstack-nova | 14:04 | |
| mriedem | we don't even test that api | 14:04 |
| gmann | yea | 14:04 |
| *** artom2 has joined #openstack-nova | 14:04 | |
| mdbooth | dansmith: Ok, cool, thanks. I'll get on it. | 14:04 |
| *** sridharg has quit IRC | 14:04 | |
| mnestratov | any chances to get this reviewed and merged until FF https://review.openstack.org/#/c/217679 ? | 14:04 |
| dansmith | mdbooth: is lyarwood the violent type? | 14:04 |
| gmann | mriedem: or let's iterate it in O as not much bandwidth in Newton | 14:05 |
| mdbooth | dansmith: He lives somewhere that's inaccessible by all forms of modern transport, so I'm not sure it matters. | 14:05 |
| dansmith | mdbooth: oh good | 14:05 |
| artom2 | mdboith, vladikr, thanks for handling that config drive fix - I have an appointment this morning, so I'm not home for a bit | 14:05 |
| dansmith | mnestratov: that hasn't been waiting for a year yet, so probably not | 14:05 |
| dansmith | mnestratov: (embarrassed sarcasm) | 14:06 |
| *** zenoway has joined #openstack-nova | 14:06 | |
| lyarwood | mdbooth: haha thanks again ;) | 14:06 |
| paul-carlton2 | mdbooth, doesn't he live in Hereford? That is were the Special Air Service is based so he might know someone! | 14:06 |
| danpb | paul-carlton2: hehe, yeah, don't wanna upset that lot | 14:06 |
| *** ajo_ has quit IRC | 14:07 | |
| mriedem | mnestratov: on https://review.openstack.org/#/c/217679 you can probably guess what i'm going to ask | 14:07 |
| *** ajo_ has joined #openstack-nova | 14:07 | |
| mnestratov | mriedem: CI? | 14:07 |
| *** gmann has quit IRC | 14:07 | |
| mriedem | bingo | 14:07 |
| lyarwood | paul-carlton2: 99% of the population around here claim to be in the regiment so you never know :) | 14:08 |
| *** shaohe_feng has quit IRC | 14:08 | |
| mnestratov | mriedem: both reported | 14:09 |
| mnestratov | ah | 14:09 |
| *** ajo_ has quit IRC | 14:09 | |
| mriedem | mnestratov: the vz compute ci isn't running the rescue test | 14:09 |
| mnestratov | you mean rescue tests | 14:09 |
| mnestratov | yeah | 14:09 |
| *** shaohe_feng has joined #openstack-nova | 14:09 | |
| *** jwcroppe has quit IRC | 14:09 | |
| *** takedakn has quit IRC | 14:10 | |
| *** andreas_s has quit IRC | 14:10 | |
| gibi_ | sudipto: +1 for the first patch and left a comment in the second patch | 14:11 |
| sudipto | gibi_, thanks. working on the second one and will get back shortly. | 14:11 |
| *** burt has joined #openstack-nova | 14:11 | |
| dansmith | mnestratov: if you will work on a CI run I will go review in parallel | 14:11 |
| mnestratov | of course, forgot we didn't add it | 14:11 |
| dansmith | mnestratov: even though it hasn't been a year yet | 14:11 |
| dansmith | mnestratov: (again, very much sarcasm) | 14:12 |
| *** oomichi_ has quit IRC | 14:12 | |
| *** mdrabe has quit IRC | 14:12 | |
| mnestratov | dansmith: thus we can wait | 14:12 |
| mnestratov | :) | 14:12 |
| *** tonytan4ever has joined #openstack-nova | 14:12 | |
| gibi_ | sudipto: just ping me when it is up and I will check | 14:12 |
| dansmith | mnestratov: :) | 14:12 |
| sudipto | gibi_, sure...very shortly, i hope. | 14:12 |
| *** tblakeslee has quit IRC | 14:13 | |
| mriedem | mnestratov: the change itself seems fine | 14:13 |
| *** mdrabe has joined #openstack-nova | 14:13 | |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: libvirt: virtlogd: use virtlogd for char devices https://review.openstack.org/323765 | 14:14 |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: libvirt: simplify "get_console_output" interface https://review.openstack.org/334480 | 14:14 |
| *** dedery has quit IRC | 14:14 | |
| *** tblakeslee has joined #openstack-nova | 14:15 | |
| *** breton_ is now known as breton | 14:15 | |
| mnestratov | mriedem: to me too :) | 14:15 |
| *** sdake has quit IRC | 14:16 | |
| mriedem | dansmith: i actually like this change https://review.openstack.org/#/c/270287/ because that closes the gap on everything that calls _build_device_metadata getting bdms | 14:16 |
| mriedem | coincidentally | 14:16 |
| dansmith | mriedem: cool | 14:16 |
| mriedem | so, we might have another compute service version api block check thing for this https://review.openstack.org/#/c/270288/ | 14:17 |
| mriedem | because the compute api was always blocking this https://review.openstack.org/#/c/270288/16/nova/compute/api.py | 14:17 |
| *** sdake has joined #openstack-nova | 14:17 | |
| *** sdake has quit IRC | 14:17 | |
| mriedem | now it won't, the compute manager will | 14:17 |
| *** klkumar has quit IRC | 14:17 | |
| *** zenoway has quit IRC | 14:17 | |
| mriedem | but not all computes are going to be upgraded at the same time in a large cloud | 14:18 |
| openstackgerrit | Roman Podoliaka proposed openstack/python-novaclient: Make it possible to list quotas with details https://review.openstack.org/335524 | 14:18 |
| *** shaohe_feng has quit IRC | 14:19 | |
| mriedem | danpb: lyarwood: see comment in https://review.openstack.org/#/c/270288/ | 14:19 |
| mriedem | you can't just lift a pin in the api like that | 14:19 |
| *** shaohe_feng has joined #openstack-nova | 14:19 | |
| mriedem | can't assume all computes in the deployment are upgraded at the same time | 14:19 |
| *** sdake has joined #openstack-nova | 14:19 | |
| paul-carlton2 | https://review.openstack.org/#/c/333989/4 has updated compute api version to 4.13 does that mean my change has to be updated to use 4.14? | 14:20 |
| *** mgoddard has joined #openstack-nova | 14:20 | |
| paul-carlton2 | I've got a rebase issue when trying to push a new patch up | 14:20 |
| mriedem | paul-carlton2: i don't see any rpc api version bump in there | 14:20 |
| mriedem | paul-carlton2: you mean https://review.openstack.org/#/c/333988/4/nova/compute/rpcapi.py | 14:21 |
| paul-carlton2 | Maybe I got wrong change | 14:21 |
| mriedem | so yes, you're at 4.14 now | 14:21 |
| *** ducttape_ has joined #openstack-nova | 14:21 | |
| paul-carlton2 | ok, I'll change it | 14:21 |
| alaski | there's a lot of contention for compute rpcapi and service versions right now | 14:22 |
| lyarwood | mriedem: ack thanks | 14:22 |
| openstackgerrit | Jinquan Ni proposed openstack/nova: libvirt:code flow problem in wait_for_job https://review.openstack.org/320750 | 14:22 |
| mriedem | lyarwood: also, https://review.openstack.org/#/c/270288/ should be using a virt driver capability checked in the compute manager, | 14:23 |
| *** sc68cal has quit IRC | 14:23 | |
| mriedem | not in each virt driver that doesn't support said capability | 14:23 |
| lyarwood | mriedem: understood, appears I really should've been paying attention to the device tagging series | 14:24 |
| *** sree has quit IRC | 14:24 | |
| mriedem | lyarwood: well, virt driver capabiliites are pretty standard for something like this | 14:25 |
| *** sc68cal has joined #openstack-nova | 14:25 | |
| *** andreas_s has joined #openstack-nova | 14:25 | |
| *** ftersin has joined #openstack-nova | 14:26 | |
| *** nkrinner is now known as nkrinner_afk | 14:26 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Bump service version for BuildRequest deletion https://review.openstack.org/332478 | 14:26 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Stop instance build if BuildRequest deleted https://review.openstack.org/332479 | 14:26 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Refactor block_device_mapping handling during boot https://review.openstack.org/334094 | 14:26 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add block_device_mappings to BuildRequest https://review.openstack.org/334095 | 14:26 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Cells: Handle delete with BuildRequest https://review.openstack.org/325985 | 14:26 |
| *** pkoniszewski has quit IRC | 14:26 | |
| dansmith | mnestratov: really not critical to change that reno, | 14:26 |
| dansmith | mnestratov: and you could do it after this patch if you want.. but your call | 14:27 |
| mnestratov | dansmith: it will take 5 minutes | 14:27 |
| openstackgerrit | Paul Carlton proposed openstack/nova: Permit Live Migration of Rescued Instances https://review.openstack.org/308198 | 14:27 |
| dansmith | mnestratov: okay | 14:27 |
| *** pkoniszewski has joined #openstack-nova | 14:28 | |
| *** ftersin_ has quit IRC | 14:28 | |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port test_fakelibvirt to Python 3 https://review.openstack.org/333251 | 14:29 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port ironic test_driver to Python 3 https://review.openstack.org/333250 | 14:29 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port libvirt test_driver to Python 3 https://review.openstack.org/333249 | 14:29 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port test_virt_drivers to Python 3 https://review.openstack.org/333248 | 14:29 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port virt test_hardware to Python 3 https://review.openstack.org/333247 | 14:29 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port pci unit tests to Python 3 https://review.openstack.org/332791 | 14:29 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port test_metadata to Python 3 https://review.openstack.org/332738 | 14:29 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Port test_hacking to Python 3 https://review.openstack.org/332737 | 14:29 |
| *** shaohe_feng has quit IRC | 14:29 | |
| *** shaohe_feng has joined #openstack-nova | 14:30 | |
| openstackgerrit | Maxim Nestratov proposed openstack/nova: libvirt: virtuozzo instance rescue mode support https://review.openstack.org/217679 | 14:30 |
| openstackgerrit | Paul Carlton proposed openstack/nova: API changes for live migration of rescued instance https://review.openstack.org/328280 | 14:30 |
| *** amotoki has joined #openstack-nova | 14:31 | |
| *** gszasz has quit IRC | 14:32 | |
| dansmith | mnestratov: looks cool, thanks | 14:32 |
| dansmith | mnestratov: ~4 hours again? | 14:32 |
| *** mdrabe has quit IRC | 14:32 | |
| mnestratov | dansmith: let me check | 14:32 |
| *** mdrabe has joined #openstack-nova | 14:32 | |
| *** Daisy has joined #openstack-nova | 14:33 | |
| *** syjulian has joined #openstack-nova | 14:34 | |
| *** gszasz has joined #openstack-nova | 14:34 | |
| *** dedery has joined #openstack-nova | 14:34 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Introduce the memory bandwidth monitor https://review.openstack.org/329783 | 14:35 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor https://review.openstack.org/266773 | 14:35 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Update setup.cfg for memory bandwidth monitor https://review.openstack.org/329785 | 14:35 |
| *** ctrath has quit IRC | 14:35 | |
| mnestratov | dansmith: yeah, looks like this | 14:35 |
| *** itamarl has quit IRC | 14:35 | |
| *** mdrabe has quit IRC | 14:36 | |
| sudipto | gibi_, ^ done. You may have to restore your vote on the pcp one coz i committed them in a chain... | 14:36 |
| mnestratov | dansmith: thanks for review | 14:36 |
| *** mdrabe has joined #openstack-nova | 14:36 | |
| dansmith | mnestratov: okay, well, I'll check back later then, thanks for being responsive | 14:37 |
| *** Daisy has quit IRC | 14:37 | |
| sudipto | dansmith, mriedem can i request a review on the pcp patches...i have incorporated your review comments ... (just worried about the ff - that's all) | 14:38 |
| *** amotoki has quit IRC | 14:38 | |
| *** ctrath has joined #openstack-nova | 14:38 | |
| dansmith | sudipto: I know, they're on the list. kinda hoping to see a review from jaypipes on there too | 14:38 |
| *** tjones has joined #openstack-nova | 14:38 | |
| *** mdrabe_ has joined #openstack-nova | 14:39 | |
| openstackgerrit | Paul Murray proposed openstack/nova: Alternative console authorization object https://review.openstack.org/335535 | 14:39 |
| sudipto | dansmith, sure. I wonder jaypipes would be able to review them before the deadline :( he seemed to have traveled out to detroit... | 14:39 |
| *** shaohe_feng has quit IRC | 14:39 | |
| *** shaohe_feng has joined #openstack-nova | 14:39 | |
| kashyap | danpb: Is this a 'reasonably ugly' way to try to convince Nova to install custom QEMU package via rootwrap? http://paste.openstack.org/show/524071/ | 14:41 |
| *** mdrabe has quit IRC | 14:42 | |
| gibi_ | sudipto: looking.. | 14:42 |
| *** armax has joined #openstack-nova | 14:43 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Improve help context of ironic options https://review.openstack.org/332433 | 14:44 |
| gibi_ | sudipto: looks good to me, thanks | 14:44 |
| *** gstepanov has joined #openstack-nova | 14:44 | |
| *** aloga_ has joined #openstack-nova | 14:45 | |
| sudipto | gibi_, thanks!! | 14:46 |
| *** amotoki has joined #openstack-nova | 14:46 | |
| markus_z | kashyap: (on a side note) Do you have a tutorial somewhere which shows how to create those debs? | 14:47 |
| markus_z | kashyap: AFAIU you're using root wrap the correct way | 14:47 |
| *** MikeG451 has joined #openstack-nova | 14:48 | |
| kashyap | markus_z: I didn't create these custom debs. Dave Gilbert, QEMU developer created it | 14:48 |
| mnestratov | dansmith: hmm, I underestimated the number of patches in the zuul queue, looks like this time it will take much more time to report - about 10 hours | 14:49 |
| kashyap | markus_z: He's added some custom 'fprintf's plus some debugging macros to catch potential errors, in the event that Volume-based migration bug is reproduced. | 14:49 |
| dansmith | mnestratov: oof, okay :) | 14:49 |
| *** shaohe_feng has quit IRC | 14:49 | |
| johnthetubaguy | dansmith: I replied to your comment on this patch, it was intentional basically: https://review.openstack.org/#/c/327012/ | 14:49 |
| dansmith | mnestratov: mriedem doesn't sleep so I'm sure he'll notice when it reports | 14:50 |
| *** shaohe_feng has joined #openstack-nova | 14:50 | |
| kashyap | markus_z: Thanks for confirming that rootwrap change, I'll push a Test-Only change to see if that bug occurs, and thus capturing some errors | 14:50 |
| markus_z | kashyap: In case you didn't already know, "util.execute" returns a tuple of stdout+stderr, in case you wanna parse that. | 14:51 |
| mnestratov | dansmith: mriedem is a happy man if he doens't need to sleep | 14:51 |
| kashyap | markus_z: I see. I can post a change, and you can see it in full to comment there. /me back in a few min | 14:51 |
| dansmith | johnthetubaguy: okay will look in a sec | 14:52 |
| mriedem | gibi_: it's on the list for today | 14:52 |
| gibi_ | mriedem: thanks | 14:52 |
| clarkb | kashyap: it might be easier to do that via a devstack change? I dont have all the context here but that srems like a weird place to do it | 14:52 |
| mnestratov | it's a pity that zuul doesnt have an ability to raise a priority of a certain change | 14:54 |
| markus_z | kashyap: I guess the package "qemu-block-extra_2.5+dfsg-5ubuntu10.2dgilbert1_amd64.deb" should be downloaded by wget as well? You're using the same URL twice in that call. | 14:54 |
| *** pbandark has quit IRC | 14:55 | |
| dansmith | mnestratov: zuul is opensource, as I understand it :P | 14:56 |
| clarkb | kashyap: but that would allow you to have package install done with the rest of the installation, then any nova changes can depend on the devstack change for further debugging | 14:56 |
| mriedem | mnestratov: heh, and reshuffle the queue and piss everyone else off :) unless yo'ure just talking about your ci | 14:57 |
| *** ctrath has quit IRC | 14:57 | |
| openstackgerrit | Feodor Tersin proposed openstack/nova: libvirt: Remove duplicated logic in check_can_live_migrate_source https://review.openstack.org/335542 | 14:57 |
| dansmith | mriedem: I assume he means for their CI | 14:57 |
| dansmith | mriedem: for times like this :) | 14:57 |
| kashyap | clarkb: Reading your comments now | 14:57 |
| clarkb | mnestratov: you can "promote" a change within a queue with zuul | 14:58 |
| kashyap | markus_z: Good catch, the second URL should be different. Fixing that. | 14:58 |
| clarkb | mnestratov: you can also directly enqueue | 14:58 |
| mnestratov | clarkb: really | 14:59 |
| mnestratov | how? | 14:59 |
| *** ctrath has joined #openstack-nova | 14:59 | |
| dansmith | clarkb: dammit clarkb, I had ten hours of quiet until you came along :P | 14:59 |
| *** gszasz has quit IRC | 14:59 | |
| kashyap | clarkb: No more Nova changes. We just need more debugging info from QEMU when we see this failure: https://bugs.launchpad.net/nova/+bug/1524898 | 14:59 |
| openstack | Launchpad bug 1524898 in OpenStack Compute (nova) "Volume based live migration aborted unexpectedly" [High,Confirmed] | 14:59 |
| *** shaohe_feng has quit IRC | 15:00 | |
| kashyap | clarkb: And those QEMU builds have additional debugging info | 15:00 |
| *** shaohe_feng has joined #openstack-nova | 15:00 | |
| markus_z | clarkb: I still have the open todo to make https://github.com/openstack/devstack-plugin-additional-pkg-repos work in our CI. That would be the cleaner way to do it. | 15:00 |
| clarkb | `zuul enueue` and `zuul promote` | 15:00 |
| markus_z | But I didn't have the time yet. I've put it on my list for the week R-11 | 15:00 |
| *** luis5tb has joined #openstack-nova | 15:01 | |
| diga | edleafe: https://blueprints.launchpad.net/nova/+spec/license-cost-aware-vm-placement | 15:01 |
| clarkb | kashyap: then ya I would use a one off devstack change because doing that in nova with rootwrap seems like a massive violation of wjat rootwrap is there for | 15:01 |
| openstackgerrit | Paul Carlton proposed openstack/nova: Permit Live Migration of Rescued Instances https://review.openstack.org/308198 | 15:01 |
| *** pilgrimstack1 has joined #openstack-nova | 15:02 | |
| kashyap | clarkb: Yeah, realize this is an insane hack, only for debugging. So, where do I make this change in DevStack? | 15:02 |
| *** pilgrimstack has quit IRC | 15:02 | |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Improve mocking of Image objects in test_driver https://review.openstack.org/333242 | 15:02 |
| clarkb | kashyap: probably in lib/nova | 15:02 |
| diga | edleafe: Can you go through this link, it was submitted in juno release & now I am re-implementing for current release. | 15:02 |
| *** artom2 has quit IRC | 15:02 | |
| mdbooth | lyarwood: Could you have a look at ^^^ for me? I'm going to try to use it for your test. | 15:02 |
| edleafe | diga: is there any code? Or a spec outlining a proposed implementation? | 15:03 |
| jed56 | edleafe: +1 :) | 15:03 |
| diga | edleafe: I can add spec for this | 15:03 |
| openstackgerrit | Paul Carlton proposed openstack/nova: API changes for live migration of rescued instance https://review.openstack.org/328280 | 15:03 |
| diga | code is old which is implemented at juno cycle | 15:03 |
| lyarwood | mdbooth: looking | 15:04 |
| diga | I will send you over the mail | 15:04 |
| edleafe | diga: so the basic idea is to only place VMs on certain hosts, based on licensing costs? | 15:04 |
| *** yamahata has quit IRC | 15:04 | |
| clarkb | dansmith: I'm sorry, I saw rootwrap was being used to install random packages from internet and couldnt look away :) | 15:04 |
| diga | edleafe: yes | 15:04 |
| *** thumpba has quit IRC | 15:04 | |
| *** muawiakhan has joined #openstack-nova | 15:04 | |
| mriedem | is there a reason we don't have an api microversion for the series to rescue volume-backed instances | 15:05 |
| mriedem | ? | 15:05 |
| mriedem | how does a client know they can try this? | 15:05 |
| kashyap | clarkb: I thought I wouldn't be caught | 15:05 |
| mriedem | lyarwood: ^ | 15:05 |
| dansmith | clarkb: no, that was in reference to the zuul promotion thing | 15:05 |
| edleafe | diga: can't any of the existing approaches, like host aggregates, accomplish what is needed? | 15:06 |
| dansmith | mriedem: so I thought about that at first, but the error we raise seems to imply "you can't run rescue on _this_ instance" | 15:06 |
| dansmith | mriedem: which I would think implies that you may be able to run it on _some_ instances | 15:06 |
| *** chhavi has quit IRC | 15:06 | |
| diga | edleafe: I dont think only host aggreegates will work | 15:06 |
| diga | I will send you doc whole idea behind this | 15:07 |
| mriedem | dansmith: lyarwood's change removes an explicit block in the compute api for volume-backed instances doing rescue | 15:07 |
| diga | edleafe: I will send you doc whole idea behind this | 15:07 |
| dansmith | mriedem: I know, but see the exception that is used? | 15:07 |
| *** tbachman has quit IRC | 15:07 | |
| lyarwood | mriedem: aside from my own ignorance nope | 15:07 |
| edleafe | diga: I ask because I know Rackspace solved a similar concern in the past | 15:07 |
| diga | edleafe: okay | 15:08 |
| edleafe | diga: such as not mixing Windows and Linux issues on the same host | 15:08 |
| diga | edleafe: okay | 15:08 |
| diga | edleafe: this contains, some data center licensing cost also involved | 15:08 |
| lyarwood | mriedem: I'm not sure I follow anyway, I understand the pinning point you made re the compute api before but why would this need any changes in the api itself? | 15:09 |
| *** dedery_ has joined #openstack-nova | 15:09 | |
| openstackgerrit | Daniel Berrange proposed openstack/nova: DO NOT MERGE - ROOAAAAAARRRR ! Testing live migration bug. https://review.openstack.org/335549 | 15:09 |
| diga | its not about only os license but here we can look hypervisor licensing etc | 15:09 |
| *** sacharya has joined #openstack-nova | 15:09 | |
| markus_z | :D | 15:09 |
| *** gongysh has quit IRC | 15:09 | |
| diga | edleafe: its not about only os license but here we can look hypervisor licensing etc | 15:09 |
| diga | edleafe: i will be back in sometime | 15:10 |
| *** shaohe_feng has quit IRC | 15:10 | |
| dansmith | mriedem: actually, the reason specifically mentions that you can't rescue volume-backed as a general statement, so maybe nevermind | 15:10 |
| edleafe | diga: sure, I understand. I'm just wondering if a similar approach might work | 15:10 |
| edleafe | diga: ok | 15:10 |
| mriedem | lyarwood: so as a user i can reasonably expect to rescue a volume-backed instance and the api won't vomit on me | 15:10 |
| dansmith | mriedem: I was looking more at "InstanceNotRescuable" | 15:10 |
| *** shaohe_feng has joined #openstack-nova | 15:10 | |
| mriedem | lyarwood: it's the same thing as trying to tag devices before that's available | 15:11 |
| mriedem | how do i as a user know i can try that if there isn't a microversion? | 15:11 |
| mriedem | because it's really an api change | 15:11 |
| mriedem | the rescue series is a behavior change in the api | 15:11 |
| mtreinish | danpb: I like the t-rex :) | 15:11 |
| lyarwood | mriedem: ah right understood | 15:11 |
| *** kevin_zh has quit IRC | 15:11 | |
| mriedem | lyarwood: i was trying to think of how we could test this in tempest | 15:11 |
| mriedem | w/o a feature toggle | 15:12 |
| *** gszasz has joined #openstack-nova | 15:12 | |
| mriedem | and you can't really | 15:12 |
| *** kevinzh has quit IRC | 15:12 | |
| mriedem | w/o a microversion | 15:12 |
| *** tesseract- has quit IRC | 15:12 | |
| *** prateek has joined #openstack-nova | 15:12 | |
| mriedem | mtreinish is probably going to get tired of me pushing nova people to write tempest tests | 15:12 |
| mdbooth | lyarwood: Grr, that patch has another minor dep | 15:12 |
| *** dedery has quit IRC | 15:13 | |
| mtreinish | mriedem: heh, nah I wish other projects pushed as much | 15:13 |
| mtreinish | I just get tired of you bugging me to review patches before ff | 15:13 |
| *** cdelatte has joined #openstack-nova | 15:13 | |
| *** dedery_ has quit IRC | 15:13 | |
| mriedem | mtreinish: the bugging rolls downhill | 15:14 |
| mriedem | they bug me, i bug you | 15:14 |
| lyarwood | mdbooth: np I get the feeling this series isn't going anywhere fast ;) | 15:14 |
| *** rcernin has quit IRC | 15:14 | |
| lyarwood | mriedem: kk, I did have a tempest test up for this that had an on/off configurable for running the tests, the microversion approach is obviously better :) | 15:15 |
| *** ctrath has quit IRC | 15:15 | |
| *** sheel has quit IRC | 15:15 | |
| mriedem | lyarwood: sorry to spring this on you at this point | 15:15 |
| *** sacharya_ has joined #openstack-nova | 15:16 | |
| *** ctrath has joined #openstack-nova | 15:16 | |
| gstepanov | mriedem: What do you think about bug/1579876 maybe 205( Reset content) that also has no payload will be more appropriate in this case | 15:16 |
| dansmith | mriedem: by the same argument, though, without instance capabilities, tempest can't know that from outside because it doesn't know what hypervisor you're using | 15:16 |
| *** catintheroof has joined #openstack-nova | 15:16 | |
| lyarwood | mriedem: np at all, I really appricate the reviews, it's just a shame they are so late in the cycle before ff | 15:17 |
| *** pcaruana has quit IRC | 15:17 | |
| *** efried has joined #openstack-nova | 15:17 | |
| mriedem | dansmith: yeah that's the other wrinkle | 15:17 |
| mriedem | we have the same issue with tags | 15:17 |
| mriedem | and volume multiattach | 15:17 |
| mnestratov | clarkb: thanks a lot, didn't know it | 15:17 |
| dansmith | mriedem: yeah | 15:18 |
| *** sacharya has quit IRC | 15:18 | |
| mriedem | https://review.openstack.org/#/c/270288/16/nova/compute/api.py is still a global block on this for all virt drivers | 15:18 |
| mriedem | there is no indication to a user that they can start requesting these now and expect it to work for at least one virt driver | 15:18 |
| dansmith | yeah, not arguing that a microversion is a good way to indicate that it's now possible | 15:19 |
| mriedem | i think for stuff like this rax would disable it via policy | 15:19 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: DO NOT MERGE - ROOAAAAAARRRR ! Testing live migration bug. https://review.openstack.org/335549 | 15:19 |
| mriedem | rax/anyone | 15:19 |
| dansmith | I think that we didn't communicate that it was not universally impossible before | 15:19 |
| dansmith | so it's a little grey to me whether we need to start or not, | 15:19 |
| dansmith | but that's fine | 15:19 |
| dansmith | becoming more explicit is always better | 15:20 |
| *** shaohe_feng has quit IRC | 15:20 | |
| mriedem | i'm trying to remember fei long's thing from a few releases back | 15:20 |
| mriedem | i think that was volume-backed instance backups? | 15:20 |
| dansmith | the backup thing? | 15:20 |
| mriedem | it's disabled in the api | 15:20 |
| dansmith | yeah, was thinking about that earlier | 15:20 |
| mriedem | i think we eventually came to the same conclusion on that one | 15:21 |
| dansmith | yep | 15:21 |
| openstackgerrit | Paul Carlton proposed openstack/nova: Permit Live Migration of Rescued Instances https://review.openstack.org/308198 | 15:21 |
| doffm | alaski: Will we have a cells meeting today? I know its approaching freeze, so everyone might be busy. | 15:22 |
| openstackgerrit | Paul Carlton proposed openstack/nova: API changes for live migration of rescued instance https://review.openstack.org/328280 | 15:22 |
| mriedem | let's skip the cells meeting | 15:22 |
| dansmith | \o/ | 15:22 |
| *** shaohe_feng has joined #openstack-nova | 15:25 | |
| *** andreas_s has quit IRC | 15:25 | |
| diga | edleafe: if you have the link of which rackspace has implemented, I will go through it | 15:25 |
| edleafe | diga: there's no link that I know of | 15:26 |
| diga | edleafe: ok | 15:26 |
| edleafe | I used to work there, and remember this being talked about | 15:26 |
| diga | edleafe: okay | 15:26 |
| *** ftersin_ has joined #openstack-nova | 15:27 | |
| openstackgerrit | Gene Kuo proposed openstack/nova: Fix nova delete with EFI booted VMs https://review.openstack.org/335512 | 15:27 |
| *** Sukhdev has joined #openstack-nova | 15:27 | |
| *** ftersin has quit IRC | 15:28 | |
| diga | edleafe: I need to re-check on this | 15:28 |
| diga | edleafe: thank you! | 15:29 |
| edleafe | diga: sure! | 15:29 |
| openstackgerrit | Paul Murray proposed openstack/nova: Alternative console authorization object https://review.openstack.org/335535 | 15:30 |
| *** code-R has quit IRC | 15:30 | |
| *** shaohe_feng has quit IRC | 15:30 | |
| *** rcernin has joined #openstack-nova | 15:30 | |
| *** amotoki has quit IRC | 15:31 | |
| *** code-R has joined #openstack-nova | 15:31 | |
| *** tbachman has joined #openstack-nova | 15:31 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: add todo about bdms in _build_device_metadata https://review.openstack.org/335563 | 15:31 |
| mriedem | artom: dansmith: ^ | 15:31 |
| *** shaohe_feng has joined #openstack-nova | 15:31 | |
| openstackgerrit | Gleb Stepanov proposed openstack/nova: [WIP] Change server delete response code https://review.openstack.org/335564 | 15:31 |
| *** muawiakhan has quit IRC | 15:32 | |
| *** pcaruana has joined #openstack-nova | 15:32 | |
| kashyap | danpb: LOL, 10x improvement over your 'kaboom' the commit message! https://review.openstack.org/#/c/335549/ | 15:32 |
| kashyap | s/the// | 15:32 |
| *** code-R has quit IRC | 15:35 | |
| *** claudiub has quit IRC | 15:35 | |
| *** eharney has quit IRC | 15:38 | |
| *** tbachman has quit IRC | 15:38 | |
| *** tbachman has joined #openstack-nova | 15:39 | |
| *** luis5tb has quit IRC | 15:40 | |
| *** thumpba has joined #openstack-nova | 15:41 | |
| *** shaohe_feng has quit IRC | 15:41 | |
| mriedem | dansmith: artom: vladikr: i left a reply in https://review.openstack.org/#/c/264017/63/nova/compute/manager.py about the vif tag stuff, i think we should do that in allocate_for_instance, which would also fix the pre-allocated port scenario | 15:41 |
| mriedem | brb | 15:41 |
| *** gszasz has quit IRC | 15:41 | |
| dansmith | mriedem: so the opposite of what I said this morning then? | 15:41 |
| *** shaohe_feng has joined #openstack-nova | 15:41 | |
| artom | mriedem, is allocate_for_instance called even in the Neutron case? | 15:42 |
| dansmith | yeah | 15:42 |
| artom | dansmith, that's yes to my question? | 15:42 |
| vladikr | yes | 15:42 |
| vladikr | :) | 15:42 |
| artom | Dammit. | 15:42 |
| artom | It's not going a lot... mostly calling to network_rpcapi.allocate_for_instance | 15:43 |
| dansmith | artom: yes to your question | 15:43 |
| *** belmoreira has quit IRC | 15:43 | |
| *** Nakato has quit IRC | 15:43 | |
| artom | I don't see what we gain by moving to allocate_for_instance in network.api... | 15:44 |
| dansmith | me either, but I haven't read his comment yet | 15:44 |
| artom | And does network_rpcapi.allocate_for_instance also get called in the Neutron case? That's what's doing most of the work... | 15:44 |
| *** Nakato has joined #openstack-nova | 15:45 | |
| johnthetubaguy | no rpc calls in the neutron case, but it all goes through the network api base, kinda | 15:45 |
| *** amotoki has joined #openstack-nova | 15:45 | |
| mriedem | artom: yes | 15:45 |
| mriedem | artom: no actually | 15:45 |
| mriedem | that's nova-net | 15:45 |
| dansmith | I guess he just doesn't like the trifecta match in the compute code, which I don't like either, | 15:45 |
| mriedem | network rpc api is nova-net | 15:45 |
| mriedem | this is really a tag on the vif | 15:45 |
| mriedem | which is created in allocate_for_instance | 15:45 |
| dansmith | but I also don't really like adding more gorp into allocate for instance either | 15:46 |
| mriedem | and if you provide a pre-allocated port on boot, with a tag, we don't honor that tag | 15:46 |
| *** gongysh has joined #openstack-nova | 15:46 | |
| artom | mriedem, we'd still be doing the trifecta match, though, right? | 15:46 |
| *** david-lyle has quit IRC | 15:46 | |
| mriedem | because of this matching in the compute manager | 15:46 |
| mriedem | artom: i don't really see why | 15:46 |
| dansmith | artom: yes, but we already do it in the network code, | 15:46 |
| *** tbachman_ has joined #openstack-nova | 15:46 | |
| dansmith | which is his point I think | 15:46 |
| mriedem | in neutron you have a tag and you apply it to the port | 15:46 |
| mriedem | the port either existed before or nova created it, that doesn't matter here | 15:46 |
| *** tbachman has quit IRC | 15:46 | |
| *** tbachman_ is now known as tbachman | 15:46 | |
| mriedem | and we build that into the vif model | 15:46 |
| artom | dansmith, do we? I don't see it in allocate_for_instance... | 15:47 |
| mriedem | which would also allow us to avoid querying the database from the libvirt driver | 15:47 |
| mriedem | artom: we have requested_networks right here for neutron https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L553 | 15:47 |
| dansmith | artom: we do, but it's less match-y because we have more information about what is going on I think | 15:47 |
| mriedem | right | 15:48 |
| mriedem | it's explicit | 15:48 |
| * artom must be looking at the wrong code... | 15:48 | |
| vladikr | then we will have to modify the VIF model, which dansmith didn't like | 15:48 |
| dansmith | mriedem: so we can't generate the same VIF model later on though, because we won't have network request, right? | 15:49 |
| artom | https://github.com/openstack/nova/blob/master/nova/network/api.py#L214 ... | 15:49 |
| dansmith | mriedem: so VIF will have tag in there at one point in time but not later | 15:49 |
| dansmith | artom: that's the n-net code | 15:49 |
| mriedem | artom: https://github.com/openstack/nova/blob/master/nova/network/api.py#L214 is nova-net | 15:49 |
| *** sheel has joined #openstack-nova | 15:49 | |
| *** prateek has quit IRC | 15:49 | |
| mriedem | dansmith: hmm, because it won't be on the port... | 15:49 |
| mriedem | in neutron | 15:49 |
| dansmith | mriedem: right | 15:50 |
| mriedem | however | 15:50 |
| mriedem | HOWEVER | 15:50 |
| artom | mriedem, but we can't do it in just Neutron though, can we? | 15:50 |
| mriedem | just create the VirtualInterface in the nova db | 15:50 |
| mriedem | you're already doing that in the compute manager | 15:50 |
| artom | The reason we did it in manager originally was to support nova-network as well... | 15:50 |
| mriedem | just do that in the neutron allocate_for_instance code | 15:50 |
| mriedem | sure, it's a convenience | 15:50 |
| mriedem | but it's broken | 15:50 |
| mriedem | so it's not convenient :) | 15:50 |
| *** shaohe_feng has quit IRC | 15:51 | |
| *** yamahata has joined #openstack-nova | 15:51 | |
| mriedem | the compute manager shouldn't be creating VIF entries in the db really anyway, that's the job of the network api | 15:51 |
| mriedem | it doesn't make a huge difference really, but separation of duties | 15:51 |
| *** paul-carlton2 has quit IRC | 15:51 | |
| dansmith | not sure I really agree with that | 15:51 |
| dansmith | in n-net, then yeah, | 15:51 |
| *** shaohe_feng has joined #openstack-nova | 15:52 | |
| dansmith | but you're basically pushing this to happening in n-api or n-cond | 15:52 |
| mriedem | why? | 15:52 |
| dansmith | because the neutron api code runs wherever it's called from | 15:52 |
| mriedem | we only call allocate_for_instance from n-cpu | 15:52 |
| artom | Also, this is because we're reuising the virtual_interfaces table that was originally for nova-net for tags | 15:52 |
| *** claudiub has joined #openstack-nova | 15:52 | |
| dansmith | mriedem: not after the refactor | 15:52 |
| artom | With Neutron normally it'd be completely empty | 15:52 |
| artom | But we're saving tags there | 15:52 |
| mriedem | artom: yes i realize | 15:52 |
| mriedem | n-api creates ports now? | 15:53 |
| mriedem | and then binds to a host in n-cpu right? | 15:53 |
| mriedem | that was the idea | 15:53 |
| dansmith | mriedem: eventually the binding moves too | 15:54 |
| mriedem | so create in n-api/conductor, then update in n-cpu | 15:54 |
| mriedem | ok | 15:54 |
| dansmith | it doesn't really matter, | 15:54 |
| dansmith | the tagging and device metadata stuff is purely a compute concept to me, so pushing things for it out to the network periphery doesn't seem like a major win to me | 15:55 |
| dansmith | I mean, it puts some network stuff near other network stuff, | 15:55 |
| dansmith | but some tagging and virtual device stuff away from others like it | 15:55 |
| dansmith | so I dunno, I guess I don't have a strong opinion, | 15:55 |
| *** diogogmt has joined #openstack-nova | 15:55 | |
| dansmith | but I also don't really see the point, other than the slight gain to be had by re-using the existing match-y logic in the api | 15:55 |
| artom | Can I push what I have as a WIP so we have something more concrete to tear to shres? | 15:55 |
| artom | *shreds? | 15:55 |
| dansmith | but it means we have to do the same thing in two places instead of one, right? | 15:56 |
| *** ecelik has quit IRC | 15:56 | |
| dansmith | mriedem: we need to add code to n-net's allocate and neutrons | 15:56 |
| *** kevinzh has joined #openstack-nova | 15:56 | |
| *** eharney has joined #openstack-nova | 15:56 | |
| mriedem | yeah, but it's like what, a couple of lines in n-net when creating the vif object in the db? | 15:56 |
| dansmith | well, maybe we get it for free for n-net wherever we create VirtualInterface today, I dunno | 15:56 |
| mriedem | you just have to set the tag on the vif object before n-net creates it | 15:56 |
| mriedem | and we have the requested_networks list there | 15:56 |
| mriedem | i haven't plumbed that all through, but it shouldn't be bad | 15:57 |
| mriedem | it's not just the matching for free, | 15:57 |
| mriedem | it's also the other case you brought up in the comment | 15:57 |
| * mriedem gets it | 15:57 | |
| *** cdelatte has quit IRC | 15:57 | |
| mriedem | "It doesn't really matter, other than that if you have two different tags on the same network, we will (I think) assign the same tag to both, instead of each getting one of the tags, right?" | 15:57 |
| mriedem | ^ is a bug | 15:57 |
| dansmith | right, but we don't have to move this code to make that right | 15:58 |
| mriedem | if you are doing it in allocate_for_instance you have the specific request object with the tag and can apply it properly | 15:58 |
| dansmith | mriedem: the only reason they hit that now is because they iterate the two lists in the wrong order :) | 15:58 |
| mriedem | so let's get the change up and we'll see what it looks like | 15:59 |
| mriedem | as artom said | 15:59 |
| *** cdelatte has joined #openstack-nova | 15:59 | |
| mriedem | "if vif['network']['id'] == req_net.network_id:" is totally f'ing with me | 15:59 |
| dansmith | vladikr: so if you create the vif in the network code you won't need to modify model::VIF I think, which was the thing I hate the most | 15:59 |
| artom | mriedem, prepare to be f'ed with some more, the new stuff is uglier :P | 15:59 |
| *** moshele has quit IRC | 15:59 | |
| artom | But works - in my head. | 15:59 |
| *** amotoki has quit IRC | 15:59 | |
| mriedem | artom: tests and more tests | 16:00 |
| *** jaugustine has joined #openstack-nova | 16:00 | |
| vladikr | dansmith, yea, I was thinking about a different scenario | 16:00 |
| dansmith | okay | 16:00 |
| artom | mriedem, hey, I said WIP :) | 16:00 |
| *** _ducttape_ has joined #openstack-nova | 16:00 | |
| mriedem | let's just delete nova-net at the midcycle | 16:01 |
| *** shaohe_feng has quit IRC | 16:01 | |
| openstackgerrit | Kristi Nikolla proposed openstack/python-novaclient: Deprecated the `--volume-service-name` option https://review.openstack.org/306473 | 16:01 |
| *** kevinzs has joined #openstack-nova | 16:01 | |
| *** shaohe_feng has joined #openstack-nova | 16:02 | |
| *** ducttape_ has quit IRC | 16:03 | |
| *** klkumar has joined #openstack-nova | 16:03 | |
| *** GB21 has joined #openstack-nova | 16:04 | |
| *** kevinzh has quit IRC | 16:04 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging metadata API support https://review.openstack.org/304511 | 16:05 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging API support https://review.openstack.org/304510 | 16:05 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Compute manager device tagging support https://review.openstack.org/264017 | 16:05 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Declare supports_device_tagging in all drivers https://review.openstack.org/335573 | 16:05 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Add DeviceTaggingFilter to scheduler https://review.openstack.org/331490 | 16:06 |
| artom | mriedem, dansmith there ^^ | 16:06 |
| artom | Also, I've added https://review.openstack.org/335573 | 16:07 |
| *** haplo37_ has joined #openstack-nova | 16:07 | |
| *** jlanoux has quit IRC | 16:07 | |
| *** gongysh has quit IRC | 16:07 | |
| dansmith | artom: what change is that? not moving things into the network api.. | 16:08 |
| dansmith | that's just the trifecta match in the original place? | 16:08 |
| artom | dansmith, yeah, trifecta match | 16:08 |
| *** GB21 has quit IRC | 16:08 | |
| artom | Just to show what the code might look like | 16:08 |
| dansmith | okay | 16:08 |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Deprecate barbican options https://review.openstack.org/317684 | 16:08 |
| artom | https://review.openstack.org/#/c/335573/ is because we forgot to add the supports_device_tagging capability to all virt drivers | 16:09 |
| *** ljxiash has quit IRC | 16:11 | |
| dansmith | artom: pretty sure that mriedem is going to point at that "by address" function as justification :) | 16:11 |
| dansmith | also, I can't even count how deeply nested these loops are, | 16:11 |
| dansmith | which is legitimately pretty terrible | 16:11 |
| artom | dansmith, I don't disagree, but don't have a better idea just yet :( | 16:11 |
| *** shaohe_feng has quit IRC | 16:11 | |
| artom | Also, the by_address loop is in the case of two nics on the same net with different IPs | 16:12 |
| *** ljxiash has joined #openstack-nova | 16:12 | |
| artom | Don't want to get the tags mixed up in that case | 16:12 |
| dansmith | I know, but, | 16:12 |
| *** shaohe_feng has joined #openstack-nova | 16:12 | |
| dansmith | if it's in the network api it's more explicit and we don't have to go n^3 looping through all our data to try to find things :) | 16:12 |
| artom | True... | 16:13 |
| artom | I mean, I don't think the telcos wanting for NFV are running nova-net, so we can just not support it... | 16:13 |
| dansmith | I don't really see him backing down, so probably just wasting time arguing otherwise :) | 16:13 |
| artom | *wanting tagging | 16:13 |
| dansmith | the n-net case is the super easy one though | 16:13 |
| dansmith | so not even worth arguing that | 16:13 |
| dansmith | plus, despite the arguments that this is NFV-only, this is absolutely critical for everyone, IMHO :) | 16:14 |
| mriedem | oh did you say NFV? | 16:14 |
| mriedem | well, let me +W here quick | 16:14 |
| artom | Well, NFV is where this originally came from | 16:14 |
| mriedem | say no more | 16:14 |
| dansmith | artom: yeah, but arguing that only NFV people will use this is silly :) | 16:14 |
| *** markus_z has quit IRC | 16:14 | |
| artom | mriedem, thank you for protrating yourself before your lord and master the telcos ;) | 16:14 |
| mriedem | i bow down | 16:15 |
| mriedem | in their glory | 16:15 |
| *** EinstCrazy has quit IRC | 16:15 | |
| *** paul-carlton2 has joined #openstack-nova | 16:15 | |
| *** svenkat has quit IRC | 16:15 | |
| *** ctrath has quit IRC | 16:16 | |
| mriedem | i haven't looked at the change yet | 16:16 |
| *** HenryG has quit IRC | 16:16 | |
| alaski | doffm: mriedem dansmith I'm fine with skipping the cells meeting today | 16:16 |
| carl_baldwin | mriedem: ping | 16:16 |
| *** code-R has joined #openstack-nova | 16:16 | |
| *** HenryG has joined #openstack-nova | 16:16 | |
| mriedem | carl_baldwin: this isn't THE ping is it?! | 16:17 |
| carl_baldwin | mriedem: PING | 16:17 |
| carl_baldwin | :) | 16:17 |
| mriedem | damn my past self for making future promises | 16:17 |
| *** MikeG451 has quit IRC | 16:18 | |
| alaski | melwitt: bauzas unless you have a burning issue to talk about we're going to skip the cells meeting today. everyone is busy with FF coming up | 16:18 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Correct the network config option help text https://review.openstack.org/318726 | 16:18 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the network options (3) https://review.openstack.org/281901 | 16:18 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the network options (4) https://review.openstack.org/282039 | 16:18 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Remove unused config option 'fake_call' https://review.openstack.org/282419 | 16:18 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the network options (2) https://review.openstack.org/280438 | 16:18 |
| carl_baldwin | mriedem: So, just following up on your email. It'd be *really* nice to work something out to where Nova won't error on a port with deferred port binding. | 16:18 |
| artom | So wait, regardless of whether a port was asked for in the API, Neutron alwyas creates a port? | 16:18 |
| mriedem | artom: no | 16:19 |
| mriedem | artom: if you provide a port, nova updates it with host binding details | 16:19 |
| melwitt | alaski: makes sense. sounds good to me to skip | 16:19 |
| mriedem | if you provide a network id, nova creates a port on that netowrk | 16:19 |
| *** claudiub has quit IRC | 16:19 | |
| artom | mriedem, I said Neutron didn't I? OK, Nova creates a port on that network | 16:19 |
| *** code-R_ has joined #openstack-nova | 16:20 | |
| *** ctrath has joined #openstack-nova | 16:20 | |
| *** david-lyle has joined #openstack-nova | 16:20 | |
| *** slunkad_ has quit IRC | 16:20 | |
| *** andreykurilin has quit IRC | 16:20 | |
| mriedem | carl_baldwin: ok let me dig up the change | 16:20 |
| *** _ducttape_ has quit IRC | 16:20 | |
| *** sayalilunkad has joined #openstack-nova | 16:20 | |
| artom | The point being, with the Neutron API, there ends up being a port | 16:20 |
| carl_baldwin | mriedem: https://review.openstack.org/299591 | 16:20 |
| carl_baldwin | sorry I was slow on that. Partly gerrit's slowness. | 16:21 |
| mriedem | artom: yes | 16:21 |
| mriedem | if we're given a fixed ip address, it's for an existing port | 16:21 |
| *** david-lyle has quit IRC | 16:21 | |
| mriedem | well, not 100% on that | 16:21 |
| mriedem | the fixed ip always throws me | 16:21 |
| *** david-lyle has joined #openstack-nova | 16:21 | |
| *** jaugustine has quit IRC | 16:21 | |
| artom | mriedem, hrmm, I'll look at the code some more, thank you :) | 16:21 |
| *** andreykurilin has joined #openstack-nova | 16:22 | |
| dansmith | this is why we should never add anything to network_api ever, because it's terrible | 16:22 |
| *** shaohe_feng has quit IRC | 16:22 | |
| *** shaohe_feng has joined #openstack-nova | 16:22 | |
| dansmith | this is why we should never add anything to network_api ever, because it's terrible | 16:22 |
| dansmith | oops | 16:22 |
| *** david-lyle has quit IRC | 16:22 | |
| *** browne has joined #openstack-nova | 16:22 | |
| dansmith | but yes, worth saying twice :D | 16:22 |
| danpb | lol, | 16:22 |
| *** code-R has quit IRC | 16:23 | |
| *** david-lyle has joined #openstack-nova | 16:23 | |
| *** ducttape_ has joined #openstack-nova | 16:23 | |
| *** raildo is now known as raildo-afk | 16:23 | |
| *** kevinzh has joined #openstack-nova | 16:23 | |
| mriedem | artom: ah for the fixed ip case, we create a port, and associate it with the fixed ip | 16:24 |
| Daviey | mriedem: Hey. Sorry, i missed your response... standard centos7, virsh version = libvirt 1.2.17 | 16:25 |
| *** david-lyle has quit IRC | 16:25 | |
| *** cdelatte has quit IRC | 16:25 | |
| *** david-lyle has joined #openstack-nova | 16:25 | |
| mriedem | artom: coincidentally, carl_baldwin's patch above that he wants to talk about is sort of related here | 16:25 |
| mriedem | Daviey: i'd ask danpb while he's here | 16:25 |
| danpb | huh ? | 16:25 |
| Daviey | danpb: Hi, I'm running Master via kolla.. and with live-migration I am getting: "Migration error: Your libvirt version does not support the VIR_DOMAIN_XML_MIGRATABLE flag or your destination node does not support retrieving listen addresses" .. I have checked that the instance vnc is via 0.0.0.0 and virsh capabilties is showing tcp and rdma as supported transports. Any pointers? | 16:26 |
| Daviey | danpb: (I tried redefining the domain with vnc 0.0.0.0) | 16:26 |
| *** raildo-afk is now known as raildo | 16:26 | |
| Daviey | I was thinking of trying to revert, https://review.openstack.org/#/c/254709/ to see if it is a regression | 16:27 |
| mriedem | carl_baldwin: so neutron is going to start putting a new flag in the port to tell nova if it's deferred allocation or not, and if it's deferred, we don't care about fixed ips being on the port | 16:27 |
| *** pushkaru has joined #openstack-nova | 16:27 | |
| openstackgerrit | STEW TY proposed openstack/nova: Complete verification for os-floating-ips-bulk https://review.openstack.org/333075 | 16:27 |
| mriedem | for older neutron, or existing ports, the deferred flag won't be in the port details | 16:27 |
| *** kevinzs has quit IRC | 16:27 | |
| *** ihrachys has quit IRC | 16:27 | |
| mriedem | and we restrict as normal | 16:27 |
| carl_baldwin | mriedem: Yes. | 16:27 |
| carl_baldwin | mriedem: That approach came from a discussion between armax and johnthetubaguy if I'm not mistaken. | 16:28 |
| mriedem | those guys | 16:28 |
| *** kevinzh has quit IRC | 16:29 | |
| mriedem | carl_baldwin: so this comes to mind https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L409 | 16:29 |
| mriedem | b/c we were just talking about this in here | 16:29 |
| carl_baldwin | mriedem: Another thought was to always defer checking for fixed_ips until after host binding. | 16:29 |
| danpb | Daviey: hmm, you should only get to that codepath if VIR_DOMAIN_XML_MIGRATABLE is not defined in the libvirt module | 16:29 |
| mriedem | if you request a port id and fixed ip in the request today it blows up | 16:29 |
| *** ftersin_ has quit IRC | 16:29 | |
| danpb | Daviey: but if you claim 1.2.17 version that should be fine | 16:29 |
| * carl_baldwin reading back a bit... | 16:30 | |
| danpb | unless perhaps your libvirt-python install is much older than your core libvirt install | 16:30 |
| mriedem | carl_baldwin: don't bother :) | 16:30 |
| Daviey | hmmm | 16:30 |
| *** MikeG451 has joined #openstack-nova | 16:30 | |
| johnthetubaguy | carl_baldwin: I wouldn't trust those folks, I lost track of where we are at right now | 16:31 |
| *** mdrabe_ has quit IRC | 16:31 | |
| *** dmk0202 has quit IRC | 16:31 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Deprecate barbican options https://review.openstack.org/317684 | 16:31 |
| carl_baldwin | mriedem: I've got to run out for an hour or so. I'll ping when back. It sounds like you get the gist of the patch. | 16:32 |
| mriedem | carl_baldwin: ok, i'll leave comments in the change | 16:32 |
| *** shaohe_feng has quit IRC | 16:32 | |
| carl_baldwin | mriedem: Thanks! | 16:32 |
| *** shaohe_feng has joined #openstack-nova | 16:32 | |
| *** pilgrimstack has joined #openstack-nova | 16:32 | |
| *** browne has quit IRC | 16:33 | |
| *** pilgrimstack1 has quit IRC | 16:33 | |
| *** mdrabe has joined #openstack-nova | 16:33 | |
| mriedem | johnthetubaguy: maybe you want to check my reply in here https://review.openstack.org/#/c/299591/ | 16:34 |
| mriedem | i'm not following the comment about checking after host binding | 16:34 |
| mriedem | i'm assuming that means, move the port/fixed_ip check to after the point that we update the host | 16:35 |
| mriedem | s/host/port/ | 16:35 |
| mriedem | with the host binding details | 16:35 |
| mriedem | but will neutron have associated a fixed IP with the port by the time the port update API returns? | 16:35 |
| *** pcaruana has quit IRC | 16:36 | |
| *** s1061123 has quit IRC | 16:36 | |
| *** jaugustine has joined #openstack-nova | 16:37 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Deprecate barbican options https://review.openstack.org/317684 | 16:38 |
| mriedem | dansmith: not to totally distact you, but if you have comments... https://review.openstack.org/#/c/299591/ | 16:40 |
| openstackgerrit | STEW TY proposed openstack/nova: Complete verification for os-floating-ips-bulk https://review.openstack.org/333075 | 16:41 |
| dansmith | okay | 16:41 |
| *** cdelatte has joined #openstack-nova | 16:42 | |
| *** shaohe_feng has quit IRC | 16:42 | |
| *** shaohe_feng has joined #openstack-nova | 16:43 | |
| *** paul-carlton2 has quit IRC | 16:43 | |
| openstackgerrit | Daniel Berrange proposed openstack/nova: DO NOT MERGE - ROOAAAAAARRRR ! Testing live migration bug. https://review.openstack.org/335549 | 16:44 |
| *** rcernin has quit IRC | 16:45 | |
| mriedem | artom: vladikr: going through that update now | 16:45 |
| *** sahid has quit IRC | 16:46 | |
| mriedem | so another thing i forgot about, but weren't we going to check the supports_device_tagging virt driver capability in the compute manager and fail if requested tags but the driver doesn't support that yet? | 16:48 |
| mriedem | and raise a reschedule exception? | 16:48 |
| *** stewie925 has joined #openstack-nova | 16:48 | |
| *** cdelatte has quit IRC | 16:48 | |
| *** jaugustine has quit IRC | 16:51 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Improve help text in cinder.py https://review.openstack.org/321064 | 16:51 |
| *** shaohe_feng has quit IRC | 16:52 | |
| *** shaohe_feng has joined #openstack-nova | 16:53 | |
| dansmith | mriedem: that's in the compute manager patch already | 16:54 |
| dansmith | mriedem: in neutronapi, I guess I can just look at ports_in_requested_order and just create VIFs from that, right? | 16:54 |
| dansmith | they should all have network, port, and address set at that point? | 16:54 |
| dansmith | oh, nm, those are just port ids | 16:55 |
| *** fifieldt has quit IRC | 16:55 | |
| mriedem | dansmith: the compute manager patch doesn't check the virt driver capability | 16:55 |
| mriedem | https://review.openstack.org/#/c/264017/65/nova/compute/manager.py | 16:55 |
| dansmith | mriedem: L1760 | 16:55 |
| mriedem | ha | 16:56 |
| mriedem | i'll be damned | 16:56 |
| *** salv-orl_ has joined #openstack-nova | 16:59 | |
| *** mmandel has quit IRC | 16:59 | |
| artom | mriedem, I can't help but interpreting your -1 as "there's hope for this ugliness yet" as opposed to "no, we're definitely moving this to neutronapi" ;) | 17:00 |
| mriedem | artom: dansmith: vladikr: comments inline https://review.openstack.org/#/c/264017/ | 17:00 |
| mriedem | artom: i don't hate it | 17:00 |
| mriedem | i'll say that | 17:00 |
| mriedem | there is a ton of processing for sure as dansmith pointd out | 17:00 |
| mriedem | i have to go get some pizza now though | 17:01 |
| *** mriedem is now known as mriedem_lunch | 17:01 | |
| artom | That's quite a pizza cliffhanger... | 17:01 |
| *** krotscheck is now known as krotscheck_vaca | 17:01 | |
| *** krotscheck_vaca is now known as krot_vaca_jul19 | 17:01 | |
| *** ctrath has quit IRC | 17:01 | |
| *** TravT has quit IRC | 17:01 | |
| *** salv-orlando has quit IRC | 17:02 | |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add the 'min' param to IntOpts where applicable https://review.openstack.org/335585 | 17:02 |
| *** shaohe_feng has quit IRC | 17:03 | |
| *** READ10 has joined #openstack-nova | 17:03 | |
| *** claudiub has joined #openstack-nova | 17:03 | |
| *** TravT has joined #openstack-nova | 17:04 | |
| *** ftersin has joined #openstack-nova | 17:04 | |
| *** diga has quit IRC | 17:04 | |
| *** ssurana has quit IRC | 17:05 | |
| *** shaohe_feng has joined #openstack-nova | 17:05 | |
| *** ljxiash has quit IRC | 17:06 | |
| *** abalutoiu has quit IRC | 17:06 | |
| *** pushkaru has quit IRC | 17:07 | |
| *** sdake_ has joined #openstack-nova | 17:08 | |
| *** mvk has quit IRC | 17:08 | |
| *** Sukhdev has quit IRC | 17:09 | |
| openstackgerrit | Pavel Kholkin proposed openstack/nova: Microversion 2.32 adds keypairs pagination support https://review.openstack.org/284868 | 17:09 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Add microversion support to images unit tests https://review.openstack.org/333626 | 17:09 |
| *** sdake has quit IRC | 17:10 | |
| *** pilgrimstack has quit IRC | 17:11 | |
| *** Jeffrey4l has quit IRC | 17:11 | |
| *** shaohe_feng has quit IRC | 17:13 | |
| *** shaohe_feng has joined #openstack-nova | 17:13 | |
| openstackgerrit | Anusha Unnam proposed openstack/nova: Improve the help text for compute timeout_opts https://review.openstack.org/317693 | 17:15 |
| *** dmk0202 has joined #openstack-nova | 17:16 | |
| *** lucasagomes is now known as lucas-afk | 17:17 | |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Fix revert on migration with SR-IOV https://review.openstack.org/326174 | 17:17 |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Raise exception if PCI device spec is not found https://review.openstack.org/331830 | 17:17 |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Allocate PCI devices on migration https://review.openstack.org/328983 | 17:18 |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Update binding:profile for SR-IOV ports https://review.openstack.org/242573 | 17:18 |
| *** shaohe_feng has quit IRC | 17:23 | |
| *** shaohe_feng has joined #openstack-nova | 17:24 | |
| *** paul-carlton2 has joined #openstack-nova | 17:24 | |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Add microversion support to images unit tests https://review.openstack.org/333626 | 17:25 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Restrict Metadata to Lower Case Keys https://review.openstack.org/329697 | 17:25 |
| *** gcb has quit IRC | 17:26 | |
| *** gcb has joined #openstack-nova | 17:26 | |
| *** svenkat has joined #openstack-nova | 17:26 | |
| *** abalutoiu has joined #openstack-nova | 17:27 | |
| *** mmandel has joined #openstack-nova | 17:28 | |
| *** qadaemon has joined #openstack-nova | 17:28 | |
| *** klkumar has quit IRC | 17:31 | |
| *** pushkaru has joined #openstack-nova | 17:31 | |
| *** danpb has quit IRC | 17:32 | |
| *** lpetrut has quit IRC | 17:32 | |
| *** PaulMurray has quit IRC | 17:33 | |
| *** svenkat has quit IRC | 17:33 | |
| *** shaohe_feng has quit IRC | 17:33 | |
| dansmith | johnthetubaguy: around still by chance? | 17:34 |
| *** mfeoktistov has quit IRC | 17:34 | |
| *** shaohe_feng has joined #openstack-nova | 17:34 | |
| johnthetubaguy | dansmith: I am | 17:34 |
| dansmith | johnthetubaguy: in neutronapi, if we get provided a port and thus call _update_port(), | 17:34 |
| dansmith | we don't seem to get back the full details of the port to refresh our view | 17:34 |
| *** salv-orl_ has quit IRC | 17:34 | |
| dansmith | does that mean that if we were provided a port by port_id, that we don't get the 'address' of the port right away? | 17:35 |
| *** salv-orlando has joined #openstack-nova | 17:35 | |
| *** qadaemon has quit IRC | 17:35 | |
| dansmith | johnthetubaguy: address is the only real thing we have to compare the vif to the hypervisor's view, and it's not clear to me that we'll always have that at the time we're running allocate_for_instance there | 17:35 |
| *** svenkat has joined #openstack-nova | 17:36 | |
| johnthetubaguy | dansmith: I think we actually do show_port on those and get the updated view | 17:36 |
| dansmith | johnthetubaguy: where, earlier in the api or something? | 17:36 |
| johnthetubaguy | dansmith: let me find that, one sec | 17:36 |
| dansmith | johnthetubaguy: we don't have a whole "port" in this code, even if it was provided, just a port_id | 17:37 |
| *** pwnall has quit IRC | 17:37 | |
| johnthetubaguy | dansmith: https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L383 | 17:38 |
| dansmith | so maybe during the rebuild of the nw_info we do right after, but.. | 17:38 |
| johnthetubaguy | we kinda throw it away a bit | 17:38 |
| dansmith | johnthetubaguy: hmm | 17:39 |
| dansmith | johnthetubaguy: interestingly, I think this might conflict with something mriedem_lunch said that started this whole thing: | 17:39 |
| dansmith | https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L428-L432 | 17:39 |
| dansmith | he said we wouldn't have request.network_id if we requested a port directly, but we will after this | 17:39 |
| dansmith | johnthetubaguy: ah, well, we have that ports dict in allocate_for_instance as a return from that method, so that helps a lot thanks | 17:40 |
| johnthetubaguy | dansmith: yeah, that line triggers us fetching the network later on I think | 17:41 |
| *** tblakeslee has quit IRC | 17:42 | |
| *** sameo_afk is now known as sameo | 17:42 | |
| openstackgerrit | Paul Carlton proposed openstack/nova: Permit Live Migration of Rescued Instances https://review.openstack.org/308198 | 17:43 |
| *** shaohe_feng has quit IRC | 17:44 | |
| *** sudipto has quit IRC | 17:44 | |
| *** shaohe_feng has joined #openstack-nova | 17:44 | |
| *** rcernin has joined #openstack-nova | 17:44 | |
| *** paul-carlton2 has quit IRC | 17:46 | |
| *** ayoung has quit IRC | 17:47 | |
| *** ayoung has joined #openstack-nova | 17:47 | |
| *** pwnall has joined #openstack-nova | 17:49 | |
| *** derekh is now known as derekh_afk | 17:50 | |
| *** browne has joined #openstack-nova | 17:54 | |
| *** shaohe_feng has quit IRC | 17:54 | |
| *** pece has quit IRC | 17:54 | |
| *** ctrath has joined #openstack-nova | 17:54 | |
| *** mriedem_lunch is now known as mriedem | 17:55 | |
| *** shaohe_feng has joined #openstack-nova | 17:55 | |
| *** sdake_ has quit IRC | 17:55 | |
| openstackgerrit | octopuszhang proposed openstack/nova: Allow irrelevant,self-defined specs in ComputeCapacityFilter https://review.openstack.org/317306 | 17:56 |
| mriedem | pizza time is over | 17:56 |
| dansmith | mriedem: see this? https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L428-L432 | 17:56 |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.add_fixed_ip notification https://review.openstack.org/332876 | 17:56 |
| dansmith | not sure if that happens early enough that we always have the network_id where we needed it, but just fyi | 17:57 |
| *** pilgrimstack has joined #openstack-nova | 17:57 | |
| *** permalac has quit IRC | 17:57 | |
| dansmith | mriedem: is this what you're thinking? http://pastebin.com/MEkaxdYX | 17:57 |
| mriedem | i'm not following | 17:57 |
| *** _ducttape_ has joined #openstack-nova | 17:57 | |
| *** pwnall has quit IRC | 17:58 | |
| mriedem | dansmith: re: the paste, yeah pretty much | 17:58 |
| dansmith | okay | 17:58 |
| dansmith | mriedem: re the other thing, you started down this path because they were looking at network_request.network_id always, | 17:59 |
| dansmith | and said it wasn't set if they requested a port specifically | 17:59 |
| dansmith | but that code in neutronv2 updates the network_id from the port information if they requested a port | 17:59 |
| *** muawiakhan has joined #openstack-nova | 18:00 | |
| *** ducttape_ has quit IRC | 18:00 | |
| *** mvk has joined #openstack-nova | 18:00 | |
| mriedem | # If requesting a specific port, automatically process | 18:00 |
| mriedem | # the network for that port as if it were explicitly | 18:00 |
| mriedem | # requested. | 18:00 |
| mriedem | request.network_id = port['network_id'] | 18:00 |
| mriedem | yeah | 18:00 |
| dansmith | yeah, that | 18:00 |
| dansmith | I thought that happened earlier in api if they request a port when we validate it, but apparently it happens there | 18:01 |
| mriedem | so we want to rely on that in the compute manager? allocate_for_instance mutating the requestd_networks list? | 18:01 |
| mriedem | yeah it happens in n-cpu | 18:01 |
| dansmith | I was just pointing it out | 18:01 |
| mriedem | ok | 18:02 |
| mriedem | the available macs stuff is also only for ironic | 18:02 |
| *** jaugustine has joined #openstack-nova | 18:02 | |
| mriedem | so to set the mac on the vif that we store in the nova db, it has to come from the port after creating the port | 18:02 |
| *** bkopilov has quit IRC | 18:03 | |
| dansmith | are you saying that re: my paste? | 18:03 |
| mriedem | yeah | 18:03 |
| dansmith | okay I'm going to have to refactor some of what johnthetubaguy did in that case | 18:03 |
| mriedem | port = port_client.create_port(port_req_body) | 18:04 |
| mriedem | the response might have the mac in it | 18:04 |
| *** kolesovdv has quit IRC | 18:04 | |
| dansmith | yeah, it better | 18:04 |
| *** shaohe_feng has quit IRC | 18:04 | |
| dansmith | otherwise (a) we're fucked and (b) they're not very restful | 18:04 |
| mriedem | according to http://developer.openstack.org/api-ref-networking-v2.html#createPort the response has the mac in it | 18:05 |
| mriedem | cool yeah so we'd have what we need to create the vif object in the nova db in allocate for instance | 18:05 |
| mriedem | if we wanted to go that route | 18:05 |
| *** shaohe_feng has joined #openstack-nova | 18:05 | |
| *** rlrossit has quit IRC | 18:07 | |
| *** ftersin has quit IRC | 18:07 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/333181 | 18:07 |
| dansmith | mriedem: it's going to take me a bit to get all the different ways tested in this neutron module-o-doom | 18:08 |
| mriedem | is anyone specing out the nova-net changes? | 18:08 |
| dansmith | I did them but haven't tested yet of course | 18:08 |
| dansmith | okay grabbing it from the port response already in the neutron tests works | 18:10 |
| *** rlrossit has joined #openstack-nova | 18:10 | |
| *** zz_dimtruck is now known as dimtruck | 18:10 | |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Add microversion support to images unit tests https://review.openstack.org/333626 | 18:13 |
| *** akshai_ has quit IRC | 18:13 | |
| dansmith | god these tests suck | 18:14 |
| *** shaohe_feng has quit IRC | 18:14 | |
| *** shaohe_feng has joined #openstack-nova | 18:15 | |
| mriedem | the tests are great | 18:15 |
| mriedem | you suck | 18:15 |
| mriedem | i write new mock things for everything in there in different classes, but you have to deal with the old stuff yeah | 18:15 |
| mriedem | which is terrible | 18:15 |
| *** dimtruck is now known as zz_dimtruck | 18:16 | |
| openstackgerrit | octopuszhang proposed openstack/nova: Allow irrelevant,self-defined specs in ComputeCapacityFilter https://review.openstack.org/317306 | 18:17 |
| artom | That's a weird commit message title... | 18:18 |
| artom | mriedem, the service version caching thing, did that come up when you were writing unit tests? | 18:19 |
| artom | Or is that needed for the check to actually work in Real Life? | 18:19 |
| *** mrhillsman has quit IRC | 18:21 | |
| *** Apoorva has joined #openstack-nova | 18:22 | |
| mriedem | +2 on this to close a bp series if anyone is around to review https://review.openstack.org/#/c/329339/ | 18:22 |
| mriedem | artom: real. mothertruckin'. life. | 18:23 |
| *** codebauss has joined #openstack-nova | 18:23 | |
| mriedem | actually dansmith pointed it out before i wrote that code | 18:23 |
| *** codebauss is now known as mrhillsman | 18:23 | |
| mriedem | it works w/o the cache, but it means we have to go to the db every time | 18:23 |
| artom | 'Go to the db' is the Nova equivalent of 'Go to your room!' | 18:24 |
| dansmith | I'm running unit tests on this one more time and then I'll push it up to see if it still *actually* works | 18:24 |
| *** shaohe_feng has quit IRC | 18:25 | |
| dansmith | still haven't made it to breakfast.. guess I'm skipping straight to lunch | 18:25 |
| artom | dansmith, you're pushing the compute manager patch, right? | 18:25 |
| dansmith | artom: in a few yeah | 18:25 |
| artom | Mind incorporating what mriedem and I agreed on in https://review.openstack.org/#/c/335573/ ? | 18:25 |
| mriedem | dansmith: lucky charms, fast and easy | 18:25 |
| stewie925 | hi guys, I created an instance and I tried to do 'nova virtual-interface-list <instance name>' but I got 'Listing virtual interfaces is not supported by this cloud' error message. | 18:26 |
| artom | Ie, to .get('supports_device_tagging', None) instead of straight up assuming it exists | 18:26 |
| dansmith | I have stenographied insults against mriedem's mother in the code.. see if you can spot them | 18:26 |
| artom | Steganographied, but OK, I'll look | 18:26 |
| dansmith | artom: yeah, that | 18:26 |
| openstackgerrit | Ed Leafe proposed openstack/nova: WIP - Accept multiple hosts for live migration https://review.openstack.org/327809 | 18:26 |
| mriedem | stewie925: you're using neutron right? | 18:27 |
| mriedem | that's why | 18:27 |
| stewie925 | yeah | 18:27 |
| stewie925 | ohhh | 18:27 |
| mriedem | vifs are only created in the nova db for nova-network | 18:27 |
| mriedem | you want neutron list-ports | 18:27 |
| *** shaohe_feng has joined #openstack-nova | 18:27 | |
| mriedem | or port-list or whatever | 18:27 |
| artom | dansmith, and then I'll get rid of https://review.openstack.org/#/c/335573/ entirely | 18:27 |
| *** diana has joined #openstack-nova | 18:28 | |
| *** diana is now known as Guest6059 | 18:28 | |
| stewie925 | thank you so much mriedem ! Looks like I need to update local.conf to enable nova-network and restack | 18:28 |
| *** pilgrimstack has quit IRC | 18:29 | |
| dansmith | artom: okie | 18:29 |
| artom | stewie925, out of the box with no local.conf nova-network is what gets used | 18:29 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Bump service version for BuildRequest deletion https://review.openstack.org/332478 | 18:29 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Stop instance build if BuildRequest deleted https://review.openstack.org/332479 | 18:29 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Refactor block_device_mapping handling during boot https://review.openstack.org/334094 | 18:29 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add block_device_mappings to BuildRequest https://review.openstack.org/334095 | 18:29 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Cells: Handle delete with BuildRequest https://review.openstack.org/325985 | 18:29 |
| *** Guest6059 has left #openstack-nova | 18:29 | |
| *** akshai has joined #openstack-nova | 18:29 | |
| mriedem | stewie925: yeah i'm not sure why you care | 18:29 |
| mriedem | stewie925: just use neutron port-list | 18:29 |
| mriedem | it's the same thing | 18:29 |
| artom | stewie925, so unless you have specific requirements I'd just spin up a new devstack with no local.conf | 18:30 |
| artom | In my experience, once a devstack is up, you don't touch it. | 18:30 |
| stewie925 | yeah because Im doing the api-ref verification for the virtual-interface-list :| | 18:30 |
| artom | Ever. | 18:30 |
| *** eglynn has quit IRC | 18:30 | |
| *** diana has joined #openstack-nova | 18:30 | |
| *** zz_dimtruck is now known as dimtruck | 18:30 | |
| *** diana has quit IRC | 18:31 | |
| *** TravT has quit IRC | 18:31 | |
| *** jaugustine has quit IRC | 18:31 | |
| mriedem | oh i see | 18:31 |
| mriedem | that api is going to be deprecated soon anyway | 18:31 |
| mriedem | but ok | 18:31 |
| *** ociuhandu has quit IRC | 18:32 | |
| *** dmk0202 has quit IRC | 18:32 | |
| *** sambetts|cat is now known as sambetts|afk | 18:33 | |
| artom | At midcycle ;) | 18:33 |
| *** diana has joined #openstack-nova | 18:33 | |
| stewie925 | oh... thanks for the information, mriedem (about the deprecation) | 18:33 |
| mriedem | artom: i was joking about deleting nova-net at the midcycle | 18:33 |
| *** diana is now known as Guest14238 | 18:33 | |
| mriedem | :) | 18:33 |
| artom | Aww man, I'd planned the parade and everything | 18:34 |
| *** dmk0202 has joined #openstack-nova | 18:34 | |
| *** tjones has left #openstack-nova | 18:34 | |
| *** shaohe_feng has quit IRC | 18:35 | |
| *** TravT has joined #openstack-nova | 18:35 | |
| *** tr3buchet has quit IRC | 18:35 | |
| *** tblakeslee has joined #openstack-nova | 18:36 | |
| *** pwnall has joined #openstack-nova | 18:36 | |
| *** shaohe_feng has joined #openstack-nova | 18:36 | |
| *** tr3buchet has joined #openstack-nova | 18:36 | |
| *** dmk0202 has quit IRC | 18:37 | |
| *** dimtruck is now known as zz_dimtruck | 18:37 | |
| *** Guest14238 has quit IRC | 18:38 | |
| mriedem | gibi_: question in https://review.openstack.org/#/c/313654/37/nova/compute/manager.py | 18:39 |
| *** diana_clarke has quit IRC | 18:40 | |
| *** diana_clarke has joined #openstack-nova | 18:40 | |
| *** amotoki has joined #openstack-nova | 18:41 | |
| *** _diana_ has joined #openstack-nova | 18:42 | |
| *** ayoung has quit IRC | 18:44 | |
| *** ayoung has joined #openstack-nova | 18:44 | |
| *** fragatina has joined #openstack-nova | 18:44 | |
| *** fragatina has quit IRC | 18:44 | |
| *** fragatina has joined #openstack-nova | 18:45 | |
| *** _ducttape_ has quit IRC | 18:45 | |
| *** shaohe_feng has quit IRC | 18:45 | |
| *** shaohe_feng has joined #openstack-nova | 18:46 | |
| *** ducttape_ has joined #openstack-nova | 18:46 | |
| *** amotoki has quit IRC | 18:47 | |
| *** derekh_afk is now known as derekh_afk_ish | 18:47 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Compute manager device tagging support https://review.openstack.org/264017 | 18:47 |
| dansmith | (pep8 fix) | 18:49 |
| openstackgerrit | Dan Smith proposed openstack/nova: Compute manager device tagging support https://review.openstack.org/264017 | 18:49 |
| dansmith | mriedem: artom ^ | 18:49 |
| *** jaugustine has joined #openstack-nova | 18:50 | |
| dansmith | I need a couple unit tests for the n-net case, but want to get a run going | 18:50 |
| *** mfedosin has quit IRC | 18:53 | |
| *** thumpba has quit IRC | 18:54 | |
| *** lpetrut has joined #openstack-nova | 18:54 | |
| *** shaohe_feng has quit IRC | 18:55 | |
| *** sheel has quit IRC | 18:55 | |
| *** jaugustine has quit IRC | 18:56 | |
| *** shaohe_feng has joined #openstack-nova | 18:56 | |
| *** tbachman has quit IRC | 18:56 | |
| *** jaugustine has joined #openstack-nova | 18:56 | |
| *** fragatina has quit IRC | 18:56 | |
| *** tbachman has joined #openstack-nova | 18:57 | |
| artom | dansmith, posted a thing, but I think the logic is good? Also, the Tempest test should probably be updated to test with ports and same-network stuff... | 18:58 |
| mriedem | exposing instance_type.id from the rest api caused problems during hte migration to the api db right? | 18:58 |
| mriedem | dansmith: alaski: ^ | 18:58 |
| *** tbachman_ has joined #openstack-nova | 18:59 | |
| *** _diana_ has left #openstack-nova | 19:00 | |
| dansmith | artom: I think mriedem is going to let us slide on making sure that at least the current tempest test works and fix any bugs we find after we land this and augment the test | 19:00 |
| *** ctrath has quit IRC | 19:00 | |
| *** Sukhdev has joined #openstack-nova | 19:01 | |
| artom | dansmith, I can get behind that, but if I can squeeze in a Tempest test refresh I'll try and do that | 19:01 |
| artom | To have more confidence, etc etc | 19:01 |
| dansmith | sure don't not do it of course :) | 19:01 |
| *** stevemar has quit IRC | 19:02 | |
| *** sambetts|afk has quit IRC | 19:02 | |
| *** clarkb has quit IRC | 19:02 | |
| *** clarkb has joined #openstack-nova | 19:02 | |
| *** muawiakhan has quit IRC | 19:02 | |
| *** kuzko_ has joined #openstack-nova | 19:03 | |
| *** kuzko has quit IRC | 19:03 | |
| *** muawiakhan has joined #openstack-nova | 19:03 | |
| *** tbachman has quit IRC | 19:03 | |
| *** tbachman_ is now known as tbachman | 19:03 | |
| *** stevemar has joined #openstack-nova | 19:03 | |
| *** sambetts has joined #openstack-nova | 19:04 | |
| mriedem | so, exposing primary key id fields out of the api has been a pain in our ass right? | 19:04 |
| mriedem | and not something we should continue doing | 19:04 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Do not try to backport when db has older object version https://review.openstack.org/335629 | 19:05 |
| *** ctrath has joined #openstack-nova | 19:05 | |
| dansmith | mriedem: yes | 19:05 |
| dansmith | mriedem: breaks cells specifically | 19:05 |
| *** shaohe_feng has quit IRC | 19:06 | |
| *** shaohe_feng has joined #openstack-nova | 19:06 | |
| mriedem | ok https://review.openstack.org/#/c/313654/37/nova/notifications/objects/instance.py@140 | 19:06 |
| mriedem | the new versioned notification stuff is going to expose the flavor id (primary key) in the instance action notification | 19:06 |
| dansmith | mriedem: instance_type_id isn't an integer either | 19:06 |
| dansmith | mriedem: but yes, definitely -2 on that | 19:07 |
| mriedem | 'instance_type_id': fields.IntegerField(nullable=True), | 19:07 |
| mriedem | that's in the Instance object | 19:07 |
| *** thumpba has joined #openstack-nova | 19:07 | |
| mriedem | 'instance_type_id': instance_type['id'], | 19:07 |
| dansmith | that's the internal db id, which is not the same as instance_type_id as exposed by the api | 19:07 |
| dansmith | i.d. not the useful thing | 19:07 |
| dansmith | er, i.e. | 19:07 |
| *** zzelle_ has joined #openstack-nova | 19:07 | |
| *** thumpba has quit IRC | 19:07 | |
| mriedem | heh, yeah | 19:08 |
| *** tbachman has quit IRC | 19:08 | |
| mriedem | flavorid is what we want | 19:08 |
| mriedem | which is a string | 19:08 |
| dansmith | right | 19:08 |
| mriedem | defaults to a uuid | 19:08 |
| mriedem | ok | 19:08 |
| *** thumpba has joined #openstack-nova | 19:08 | |
| *** tbachman has joined #openstack-nova | 19:08 | |
| *** thumpba_ has joined #openstack-nova | 19:11 | |
| *** thumpba has quit IRC | 19:11 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: policy: Replaces 'authorize' in nova-api (part 5) https://review.openstack.org/333514 | 19:12 |
| *** thumpba has joined #openstack-nova | 19:14 | |
| *** sdake has joined #openstack-nova | 19:14 | |
| mriedem | is instance.image_href an int (id field) or uuid? | 19:15 |
| *** thumpba_ has quit IRC | 19:15 | |
| *** aloga_ has quit IRC | 19:15 | |
| *** shaohe_feng has quit IRC | 19:16 | |
| mriedem | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L772 | 19:16 |
| *** derekh_afk_ish has quit IRC | 19:16 | |
| *** shaohe_feng has joined #openstack-nova | 19:17 | |
| *** thumpba has quit IRC | 19:19 | |
| *** thumpba has joined #openstack-nova | 19:19 | |
| *** thumpba has quit IRC | 19:20 | |
| *** thumpba has joined #openstack-nova | 19:20 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Improve help text in cinder.py Improve help text for cinder config options https://review.openstack.org/321064 | 19:23 |
| *** tbachman_ has joined #openstack-nova | 19:23 | |
| *** thumpba_ has joined #openstack-nova | 19:23 | |
| *** thumpba_ has quit IRC | 19:24 | |
| *** thumpba_ has joined #openstack-nova | 19:24 | |
| *** tbachman has quit IRC | 19:24 | |
| *** tbachman_ is now known as tbachman | 19:24 | |
| *** ihrachys has joined #openstack-nova | 19:25 | |
| *** thumpba_ has quit IRC | 19:25 | |
| *** thumpba_ has joined #openstack-nova | 19:25 | |
| *** READ10 has quit IRC | 19:25 | |
| *** thumpba has quit IRC | 19:25 | |
| *** thumpba_ has quit IRC | 19:25 | |
| *** ssurana has joined #openstack-nova | 19:25 | |
| dansmith | oh great.. fails 20 some tests in py27 in the gate, but happy locally | 19:26 |
| *** shaohe_feng has quit IRC | 19:26 | |
| *** shaohe_feng has joined #openstack-nova | 19:27 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Compute manager device tagging support https://review.openstack.org/264017 | 19:27 |
| *** TM1 has quit IRC | 19:27 | |
| *** Daisy has joined #openstack-nova | 19:29 | |
| *** Daisy_ has joined #openstack-nova | 19:29 | |
| *** cdelatte has joined #openstack-nova | 19:30 | |
| openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Improve help text for resource tracker options https://review.openstack.org/320147 | 19:30 |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Improve help text for cinder config options https://review.openstack.org/321064 | 19:31 |
| *** akshai has quit IRC | 19:31 | |
| melwitt | mriedem: earlier today we merged a 3rd fix attempt for https://bugs.launchpad.net/nova/+bug/1404867 and I've noticed some gate failures that look related to it http://goo.gl/y5fu1I | 19:31 |
| openstack | Launchpad bug 1404867 in OpenStack Compute (nova) "Volume remains in-use status, if instance booted from volume is deleted in error state" [Low,Fix released] - Assigned to Samuel Matzek (smatzek) | 19:31 |
| *** akshai has joined #openstack-nova | 19:32 | |
| *** cdelatte has quit IRC | 19:32 | |
| mriedem | melwitt: ha | 19:32 |
| mriedem | smatzek: ^ | 19:33 |
| *** cdelatte has joined #openstack-nova | 19:33 | |
| *** cdelatte has quit IRC | 19:33 | |
| *** Daisy has quit IRC | 19:33 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Improve help text for cinder config options https://review.openstack.org/321064 | 19:33 |
| *** Daisy_ has quit IRC | 19:33 | |
| smatzek | melwitt: do you have a link to the gate failures? | 19:34 |
| melwitt | smatzek: yeah, the link I put earlier http://goo.gl/y5fu1I you have to change the time period manually to longer than the last 15 min | 19:35 |
| alaski | melwitt: I noticed that as well | 19:35 |
| openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Improve help text for compute manager options https://review.openstack.org/329639 | 19:35 |
| *** pushkaru has quit IRC | 19:35 | |
| alaski | smatzek: http://logs.openstack.org/94/334094/4/check/gate-tempest-dsvm-neutron-full/1200ad2/ is one example | 19:36 |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Fix revert on migration with SR-IOV https://review.openstack.org/326174 | 19:36 |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Raise exception if PCI device spec is not found https://review.openstack.org/331830 | 19:36 |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Allocate PCI devices on migration https://review.openstack.org/328983 | 19:36 |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Update binding:profile for SR-IOV ports https://review.openstack.org/242573 | 19:36 |
| *** shaohe_feng has quit IRC | 19:36 | |
| melwitt | I don't understand what's going on yet. it's not running the "local_delete" code as there are log messages for that and I'm not seeing those | 19:37 |
| *** shaohe_feng has joined #openstack-nova | 19:37 | |
| melwitt | it looks like the path it "probably" took is to try instance.destroy() first and got an ObjectActionError which we assume was host changed, so we instance.refresh() and then try the delete on the compute host | 19:37 |
| alaski | that's what I thought as well. but then it should have instance.host and apparently doesn't | 19:38 |
| *** chandankumar has quit IRC | 19:38 | |
| melwitt | but during that, instance.host is found to be not set, and it should have been set on the instance.refresh(). we don't have any debug logging for the refreshing part so there's not anything much to go on | 19:38 |
| mriedem | def _do_delete(self, context, instance, bdms, reservations=None, | 19:39 |
| mriedem | local=False): | 19:39 |
| mriedem | the reservation callback defaults to local=False | 19:39 |
| mriedem | so it's trying to rpc to the compute | 19:39 |
| mriedem | which the instance doesn't have a host | 19:39 |
| mriedem | this thing cb(context, instance, bdms, | 19:39 |
| mriedem | reservations=quotas.reservations) | 19:39 |
| mriedem | cb is _do_delete | 19:40 |
| mriedem | which defaults to local=False | 19:40 |
| mriedem | whacka whacka | 19:40 |
| *** bvanhav has quit IRC | 19:40 | |
| *** muawiakhan has quit IRC | 19:40 | |
| melwitt | yeah, the code goes through a series of attempts, first trying to local delete if not instance.host but if host changes during that, we fall back to a nonlocal delete | 19:40 |
| mriedem | https://review.openstack.org/#/c/256059/13/nova/compute/api.py@1637 | 19:41 |
| mriedem | melwitt: you even called that out | 19:41 |
| mriedem | should be an easy fix | 19:41 |
| mriedem | pass local=local_delete to cb | 19:42 |
| melwitt | mriedem: yeah, I have a follow-up patch up that tests it. it's supposed to be doing the nonlocal delete if the local delete gets a host changed during | 19:42 |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Improve help text of flavors config options https://review.openstack.org/332930 | 19:42 |
| *** ivase has quit IRC | 19:43 | |
| mriedem | bbiab | 19:43 |
| *** catintheroof has quit IRC | 19:43 | |
| alaski | it would help a lot if instance were logged fully | 19:44 |
| melwitt | so it seems like it's doing the right thing but the instance.host wasn't populated during the instance.refresh(). but with almost no logs it's impossible to tell | 19:44 |
| melwitt | I'm trying to think how it was working before the patch because the logic was very similar | 19:45 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging API support https://review.openstack.org/304510 | 19:45 |
| alaski | melwitt: before the callback only occurred if it definitely was not a local delete, now it can occur under more conditions | 19:46 |
| alaski | though I'm also still confused how instance.host isn't populated | 19:46 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging metadata API support https://review.openstack.org/304511 | 19:46 |
| *** fragatina has joined #openstack-nova | 19:47 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Add DeviceTaggingFilter to scheduler https://review.openstack.org/331490 | 19:47 |
| *** shaohe_feng has quit IRC | 19:47 | |
| *** mriedem1 has joined #openstack-nova | 19:47 | |
| alaski | ObjectActionError is also raise if id or uuid is not set, though I can't imagine either of those is true here | 19:48 |
| melwitt | alaski: I thought the only difference now is that we're calling "not instance.host and vm_state ERROR" a local delete too whereas before it wasn't and would therefore bypass the volume detach logic | 19:48 |
| melwitt | alaski: yeah, same thought | 19:48 |
| *** tbachman has quit IRC | 19:48 | |
| openstackgerrit | Ed Leafe proposed openstack/nova: Return HTTP 400 on list for invalid status https://review.openstack.org/315964 | 19:48 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Return HTTP 200 on list for invalid status https://review.openstack.org/335648 | 19:48 |
| openstackgerrit | Dan Smith proposed openstack/nova: Compute manager device tagging support https://review.openstack.org/264017 | 19:48 |
| *** mriedem has quit IRC | 19:49 | |
| *** shaohe_feng has joined #openstack-nova | 19:49 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Add DeviceTaggingFilter to scheduler https://review.openstack.org/331490 | 19:49 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging metadata API support https://review.openstack.org/304511 | 19:49 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging API support https://review.openstack.org/304510 | 19:50 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Compute manager device tagging support https://review.openstack.org/264017 | 19:50 |
| dansmith | artom: did you rebase on mine from two seconds ago? | 19:50 |
| artom | dansmith, yeeeaahhh | 19:50 |
| artom | Which few seconds ago? | 19:50 |
| *** akshai has quit IRC | 19:50 | |
| artom | :S | 19:50 |
| dansmith | not enough seconds ago | 19:50 |
| dansmith | or too many | 19:50 |
| artom | Apparently not | 19:50 |
| mriedem1 | alaski: melwitt: so revert until we sort it out and are comfortable? | 19:51 |
| *** mriedem1 is now known as mriedem | 19:51 | |
| alaski | melwitt: mostly. the only other real difference I'm seeing is that a ComputeHostNotFound used to skip the cb and now doesn't appear to | 19:51 |
| mriedem | i'm not sure why passing local=local_delete to cb wouldn't fix it | 19:51 |
| artom | dansmith, my stuff is stashed, so if it's easier for you, re-push whatever you need | 19:51 |
| *** fragatina has quit IRC | 19:51 | |
| dansmith | artom: yeah, have to convince gerrit to let me | 19:51 |
| artom | And I'll re-checkout the patch, apply my stash, and push again | 19:51 |
| openstackgerrit | Dan Smith proposed openstack/nova: Compute manager device tagging support https://review.openstack.org/264017 | 19:52 |
| dansmith | artom: ^ | 19:52 |
| alaski | mriedem: I think it would fix it, but it also leaks. In this case we know the instance is on a host but we would perform a local delete | 19:52 |
| alaski | though we may be doing that now | 19:52 |
| alaski | I'm sure there's a periodic to clean it up, but... | 19:53 |
| *** akshai has joined #openstack-nova | 19:53 | |
| mriedem | hmm | 19:53 |
| artom | dansmith, ah, cool, I think I just need to rebase in Gerrit then | 19:53 |
| dansmith | artom: just remember that if you have to push again, else you'll break it | 19:53 |
| alaski | mriedem: I think a revert is the right answer, it would just be nice to avoid it as this is attempt #4 to fix a bug | 19:54 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging API support https://review.openstack.org/304510 | 19:54 |
| mriedem | alaski: heh, yeah | 19:54 |
| mriedem | but | 19:54 |
| mriedem | the commit message even calls out all of the previous reverts | 19:54 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging metadata API support https://review.openstack.org/304511 | 19:54 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Add DeviceTaggingFilter to scheduler https://review.openstack.org/331490 | 19:55 |
| alaski | yep. I've been dealing with the delete code recently, it's an absolute nightmare so I'm not surprised this keeps happening | 19:55 |
| artom | Do we still need to keep trudging the filter one around ^^^ ? It's clearly not getting merged in anywhere close to its current state | 19:55 |
| *** fragatina has joined #openstack-nova | 19:55 | |
| smatzek | the patch took ~7 months to land this last time. Would it possibly be better to see if melwitt's follow on patch would fix it, and if not, revert both? | 19:56 |
| melwitt | mriedem, alaski: yeah ... we can revert it and I'll work on it locally to see what's going on to fix it and re-propose | 19:56 |
| mriedem | smatzek: we're rushing to FF tomorrow | 19:56 |
| mriedem | so breaking the gate while people are trying to land code isn't great | 19:56 |
| dansmith | artom: just drop it locally.. it'll stay orphaned in gerrit which is fine for now | 19:57 |
| smatzek | mriedem, agreed | 19:57 |
| melwitt | smatzek: my follow on just checks that things fall through as we expect when the instance host changes. I'm not sure what's going on right now with it in the gate being that there's not any logging of the instance or refreshes | 19:57 |
| alaski | smatzek: part of why it took so long is because it's hard to have confidence that this works when these fixes keep breaking the gate | 19:57 |
| *** shaohe_feng has quit IRC | 19:57 | |
| artom | dansmith, next time I respin :) | 19:57 |
| * artom moves on to the Tempest test | 19:57 | |
| *** shaohe_feng has joined #openstack-nova | 19:57 | |
| artom | Although, food first would be nice, I think I forgot lunch today | 19:58 |
| *** Guest20454 is now known as mgagne | 19:58 | |
| *** mgagne has joined #openstack-nova | 19:58 | |
| alaski | melwitt: smatzek if we revert this we could push it up again with additional logging and just recheck loop until it fails to get more info | 19:59 |
| melwitt | alaski: yeah, definitely | 20:00 |
| alaski | is anyone proposing a revert yet? | 20:00 |
| openstackgerrit | Pavel Kholkin proposed openstack/nova: Microversion 2.32 adds keypairs pagination support https://review.openstack.org/284868 | 20:02 |
| *** amotoki has joined #openstack-nova | 20:02 | |
| melwitt | alaski: I didn't. mriedem are you? or alaski you want to propose the revert? | 20:02 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Revert "Detach volume after deleting instance with no host" https://review.openstack.org/335652 | 20:02 |
| alaski | I just pushed the gerrit button | 20:02 |
| melwitt | boom | 20:02 |
| *** Prophidys has quit IRC | 20:04 | |
| *** slagle has quit IRC | 20:04 | |
| *** gcb has quit IRC | 20:05 | |
| *** gcb has joined #openstack-nova | 20:06 | |
| *** amotoki has quit IRC | 20:06 | |
| mriedem | alaski: melwitt: thanks | 20:07 |
| *** shaohe_feng has quit IRC | 20:07 | |
| *** shaohe_feng has joined #openstack-nova | 20:07 | |
| *** aloga_ has joined #openstack-nova | 20:09 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: WIP: policy: clean-up https://review.openstack.org/333925 | 20:09 |
| *** jwcroppe has joined #openstack-nova | 20:11 | |
| *** tbachman has joined #openstack-nova | 20:12 | |
| *** aloga_ has quit IRC | 20:13 | |
| *** muawiakhan has joined #openstack-nova | 20:13 | |
| dansmith | artom: mriedem: functional is going to fail on that patch because of the stupid service update sample | 20:15 |
| dansmith | I have it fixed locally but trying to let it get through a run on the rest of the things | 20:15 |
| dansmith | also rechecked the tempest test just now | 20:15 |
| *** shaohe_feng has quit IRC | 20:17 | |
| *** muawiakhan has quit IRC | 20:18 | |
| *** shaohe_feng has joined #openstack-nova | 20:18 | |
| *** Apoorva has quit IRC | 20:18 | |
| openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Improve help text for quota options https://review.openstack.org/332865 | 20:19 |
| *** stevemar_ has joined #openstack-nova | 20:24 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Adds Hyper-V OVS ViF driver https://review.openstack.org/140045 | 20:25 |
| mriedem | dansmith: ok, i have to catch up to the changes after this meeting | 20:26 |
| dansmith | I guess I'll run off and do some other stuff while this runs | 20:27 |
| *** shaohe_feng has quit IRC | 20:28 | |
| *** shaohe_feng has joined #openstack-nova | 20:28 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Bump service version for BuildRequest deletion https://review.openstack.org/332478 | 20:29 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Stop instance build if BuildRequest deleted https://review.openstack.org/332479 | 20:29 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Cells: Handle delete with BuildRequest https://review.openstack.org/325985 | 20:29 |
| *** aloga_ has joined #openstack-nova | 20:31 | |
| *** _ducttape_ has joined #openstack-nova | 20:32 | |
| *** ducttape_ has quit IRC | 20:34 | |
| *** shaohe_feng has quit IRC | 20:38 | |
| *** shaohe_feng has joined #openstack-nova | 20:38 | |
| *** tonytan4ever has quit IRC | 20:40 | |
| *** fragatina has quit IRC | 20:40 | |
| openstackgerrit | Ryan Rossiter proposed openstack/nova: Removed enum duplication from nova.compute https://review.openstack.org/335066 | 20:45 |
| * auggy just got the no cells meeting memo ;D ha | 20:46 | |
| *** mirrorbox has quit IRC | 20:46 | |
| openstackgerrit | Anusha Unnam proposed openstack/nova: Improve help text for interval_opts https://review.openstack.org/331761 | 20:46 |
| openstackgerrit | Clif Houck proposed openstack/nova-specs: Spec for supporting authentication methods based on image metadata https://review.openstack.org/326073 | 20:47 |
| auggy | i'm like dansmith the other week when we didn't have a meeting, trying to make some progress on that grenade job so i have something to report lol | 20:47 |
| *** shaohe_feng has quit IRC | 20:48 | |
| *** shaohe_feng has joined #openstack-nova | 20:48 | |
| *** _ducttape_ has quit IRC | 20:50 | |
| *** ducttape_ has joined #openstack-nova | 20:50 | |
| carl_baldwin | mriedem: FYI, I responded to your comments on https://review.openstack.org/#/c/299591 | 20:52 |
| *** akshai has quit IRC | 20:52 | |
| *** dmk0202 has joined #openstack-nova | 20:54 | |
| *** aloga_ has quit IRC | 20:56 | |
| *** andymaier has joined #openstack-nova | 20:56 | |
| *** andymaier has quit IRC | 20:58 | |
| openstackgerrit | Anusha Unnam proposed openstack/nova: Improve help text for compute_opts https://review.openstack.org/329514 | 20:58 |
| *** shaohe_feng has quit IRC | 20:58 | |
| *** haplo37_ has quit IRC | 20:59 | |
| *** shaohe_feng has joined #openstack-nova | 20:59 | |
| *** _ducttape_ has joined #openstack-nova | 20:59 | |
| *** svenkat has quit IRC | 21:00 | |
| openstackgerrit | Ed Leafe proposed openstack/nova: Return HTTP 200 on list for invalid status https://review.openstack.org/335648 | 21:01 |
| *** rlrossit has quit IRC | 21:02 | |
| *** lchen_ has quit IRC | 21:02 | |
| *** claudiub has quit IRC | 21:02 | |
| *** ducttape_ has quit IRC | 21:02 | |
| *** raildo is now known as raildo-afk | 21:03 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add nova-manage commands for policy helpers https://review.openstack.org/335667 | 21:03 |
| dansmith | mriedem: artom: FWIW, that patch passed everything but functional as expected on base nova.. still waiting on the tempest test | 21:04 |
| *** lchen_ has joined #openstack-nova | 21:04 | |
| mriedem | carl_baldwin: reading | 21:05 |
| artom | dansmith, I think I inherited your service func test failure in my API patch :) | 21:06 |
| dansmith | artom: yeah, I don't think you bumped the service notification example | 21:07 |
| dansmith | and if you did, it got lost in a rebase or soemthing | 21:07 |
| artom | dansmith, I think I did for 12->13, and then didn't for 13->14 | 21:07 |
| dansmith | soundsright :) | 21:08 |
| openstackgerrit | Mark Doffman proposed openstack/nova: Make Aggregate metadata functions work with API db https://review.openstack.org/297350 | 21:08 |
| openstackgerrit | Mark Doffman proposed openstack/nova: Block aggregate creation until main database empty https://review.openstack.org/315235 | 21:08 |
| openstackgerrit | Mark Doffman proposed openstack/nova: Add data migration methods for Aggregate. https://review.openstack.org/314782 | 21:08 |
| openstackgerrit | Mark Doffman proposed openstack/nova: Make Aggregate.save work with the API db https://review.openstack.org/305466 | 21:08 |
| artom | dansmith, I'm going to respin to fix the last failing tests in the API, want me to fix the service func test as well? | 21:08 |
| openstackgerrit | Mark Doffman proposed openstack/nova: Aggregate create and destroy work against API db https://review.openstack.org/314781 | 21:08 |
| openstackgerrit | Mark Doffman proposed openstack/nova: Make Aggregate host operations work against API db https://review.openstack.org/296597 | 21:08 |
| dansmith | artom: I have it fixed locally, but hold off for a sec | 21:08 |
| dansmith | artom: the tempest test is running and if you update anything it will reset it | 21:09 |
| *** shaohe_feng has quit IRC | 21:09 | |
| artom | dansmith, haha, I'm not that far advanced yet | 21:09 |
| *** shaohe_feng has joined #openstack-nova | 21:09 | |
| dansmith | artom: okay well, when it's done I'll push the service change and you can rebase on top | 21:09 |
| mriedem | carl_baldwin: replies inline | 21:09 |
| carl_baldwin | mriedem: looking... | 21:09 |
| artom | dansmith, ok | 21:09 |
| mriedem | dansmith: artom: so i can start looking at the compute manager changes now right? | 21:10 |
| mriedem | i'm so excited | 21:10 |
| artom | But can you hide it? | 21:10 |
| dansmith | mriedem: yeah | 21:10 |
| artom | mriedem, also, I think the API change is finally ready for your | 21:10 |
| *** mirrorbox has joined #openstack-nova | 21:10 | |
| *** mirrorbox has quit IRC | 21:10 | |
| *** mirrorbox has joined #openstack-nova | 21:10 | |
| artom | When you find that famous 25th hour | 21:11 |
| *** jaugustine has quit IRC | 21:12 | |
| *** _ducttape_ has quit IRC | 21:14 | |
| mriedem | missing some of my earlier comments from ps65 | 21:14 |
| mriedem | tsk tsk | 21:14 |
| *** cleong has quit IRC | 21:14 | |
| *** muawiakhan has joined #openstack-nova | 21:14 | |
| *** ducttape_ has joined #openstack-nova | 21:14 | |
| mriedem | for all of these "net.obj_attr_is_set('tag')" | 21:14 |
| mriedem | can't we do 'if 'tag' in net'? | 21:14 |
| mriedem | it's a nit, but it's nicer looking | 21:15 |
| *** rfolco has quit IRC | 21:18 | |
| *** shaohe_feng has quit IRC | 21:19 | |
| *** shaohe_feng has joined #openstack-nova | 21:20 | |
| *** muawiakhan has quit IRC | 21:20 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Improve help context of ironic options https://review.openstack.org/332433 | 21:20 |
| *** ayoung has quit IRC | 21:20 | |
| *** thorst has quit IRC | 21:21 | |
| *** amotoki has joined #openstack-nova | 21:22 | |
| *** efried1 has joined #openstack-nova | 21:23 | |
| *** baoli has joined #openstack-nova | 21:24 | |
| *** aysyd has quit IRC | 21:24 | |
| melwitt | mriedem: object __contains__ calls obj_attr_is_set, I learned a thing | 21:24 |
| *** efried has quit IRC | 21:25 | |
| mriedem | i think i added it | 21:25 |
| melwitt | a-ha! | 21:25 |
| *** efried has joined #openstack-nova | 21:25 | |
| mriedem | so a semi rhetorical question | 21:25 |
| melwitt | yeah, you knew the secrets | 21:26 |
| *** amotoki has quit IRC | 21:26 | |
| *** derekh has joined #openstack-nova | 21:27 | |
| *** smatzek has quit IRC | 21:27 | |
| *** efried1 has quit IRC | 21:27 | |
| *** tbachman has quit IRC | 21:29 | |
| *** shaohe_feng has quit IRC | 21:29 | |
| *** shaohe_feng has joined #openstack-nova | 21:30 | |
| *** derekh has quit IRC | 21:31 | |
| openstackgerrit | Anusha Unnam proposed openstack/nova: Improve help text for xenapi_session_opts https://review.openstack.org/322322 | 21:32 |
| *** tbachman has joined #openstack-nova | 21:33 | |
| mriedem | hmmmmmmmmm | 21:34 |
| mriedem | our schema says that you can boot a server with a network uuid, port or fixed_ip | 21:34 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: libvirt: inject files when config drive is not requested https://review.openstack.org/335676 | 21:34 |
| mriedem | if you request a specific port, then you can't request network id or fixed IP in the same network object | 21:34 |
| mriedem | but if you don't request port, and only fixed_ip but no network uuid | 21:35 |
| mriedem | it's a keyerror | 21:35 |
| mriedem | which i guess you get a 400 saying you're missing the uuid value | 21:35 |
| mriedem | i guess we can't model that with jsonschema | 21:36 |
| *** baoli has quit IRC | 21:39 | |
| *** shaohe_feng has quit IRC | 21:39 | |
| *** shaohe_feng has joined #openstack-nova | 21:40 | |
| dansmith | tempest passed | 21:40 |
| mriedem | well... | 21:40 |
| mriedem | the job failed http://logs.openstack.org/20/305120/10/check/gate-tempest-dsvm-neutron-full-ssh/23315fd/ | 21:41 |
| mriedem | but | 21:41 |
| mriedem | the test passed http://logs.openstack.org/20/305120/10/check/gate-tempest-dsvm-neutron-full-ssh/23315fd/console.html#_2016-06-29_20_49_17_137738 | 21:41 |
| mriedem | \o/ | 21:41 |
| *** ducttape_ has quit IRC | 21:41 | |
| mriedem | so that's good | 21:41 |
| mriedem | dansmith: just note that that's the only job which tests this, that non-voting neutron full ssh job | 21:41 |
| mriedem | jenkins +1 doesn't mean much | 21:42 |
| *** ducttape_ has joined #openstack-nova | 21:42 | |
| mriedem | the job failure is a result of problems in cleanup in the test | 21:42 |
| mriedem | known issue | 21:42 |
| openstackgerrit | STEW TY proposed openstack/nova: Example verification for os-fixed-ips.inc https://review.openstack.org/335678 | 21:42 |
| *** tbachman has quit IRC | 21:42 | |
| dansmith | mriedem: okay I hadn't looked | 21:43 |
| dansmith | just saw it on my other screen | 21:43 |
| artom | 2016-06-29 20:49:17.137738 | {2} tempest.api.compute.servers.test_device_tagging.DeviceTaggingTest.test_device_tagging [59.477169s] ... ok | 21:44 |
| artom | 2016-06-29 20:49:18.228583 | {2} tearDownClass (tempest.api.compute.servers.test_device_tagging.DeviceTaggingTest) [0.000000s] ... FAILED | 21:44 |
| artom | The test-test passed :) | 21:44 |
| mriedem | yup, known issue | 21:44 |
| mriedem | i'm through the nova-net changes, those look good | 21:44 |
| *** ducttape_ has quit IRC | 21:44 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Compute manager device tagging support https://review.openstack.org/264017 | 21:44 |
| mriedem | had to octuple check the server api again | 21:44 |
| *** ducttape_ has joined #openstack-nova | 21:44 | |
| dansmith | mriedem's comments plus the service version ^ | 21:45 |
| mriedem | so it's not a bdm it's the DriverBlockDevice? | 21:45 |
| dansmith | yeah, see the test | 21:45 |
| dansmith | although | 21:46 |
| dansmith | not sure that's doing the right thing necessarily.. not sure which of the nesting dolls we have in _build_and_run_instance | 21:46 |
| dansmith | artom: did you check that? | 21:46 |
| *** thorst has joined #openstack-nova | 21:46 | |
| *** tbachman has joined #openstack-nova | 21:46 | |
| mriedem | the unit tests are using bdm = fake_block_device.FakeDbBlockDeviceDict | 21:46 |
| dansmith | right | 21:46 |
| mriedem | which is maybe not what the actual code is using | 21:47 |
| dansmith | trying to verify | 21:47 |
| mriedem | actually i think this is a BlockDeviceMappingList | 21:47 |
| mriedem | it gets converted in _prep_block_devices | 21:47 |
| artom | I... I think it's the Dict | 21:47 |
| artom | from nova/block_device.py | 21:47 |
| dansmith | mriedem: not sure that's getting converted from objects.BlockDevice though | 21:48 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging API support https://review.openstack.org/304510 | 21:48 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging metadata API support https://review.openstack.org/304511 | 21:49 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Add DeviceTaggingFilter to scheduler https://review.openstack.org/331490 | 21:49 |
| mriedem | ffs why can't we just have one thing to represent bdms | 21:49 |
| dansmith | ah, yep it is | 21:49 |
| dansmith | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L482-L497 | 21:50 |
| *** shaohe_feng has quit IRC | 21:50 | |
| mriedem | \o/ | 21:50 |
| * dansmith wags his finger at artom | 21:50 | |
| * mriedem wags his finger at dansmith | 21:50 | |
| *** shaohe_feng has joined #openstack-nova | 21:50 | |
| *** thorst has quit IRC | 21:50 | |
| * artom is wagged at :( | 21:51 | |
| artom | Context is churning too quickly in my head, my mental stack is like, the size of a peanut | 21:51 |
| *** baoli has joined #openstack-nova | 21:52 | |
| mriedem | a couple more comments in there | 21:53 |
| *** diogogmt has quit IRC | 21:53 | |
| mriedem | one of the test wrinkles is missing | 21:54 |
| mriedem | that the virt capabilities key isn't in the dict | 21:54 |
| *** baoli has quit IRC | 21:54 | |
| *** rcernin has quit IRC | 21:54 | |
| mriedem | reviewing the neutronv2 api changes now | 21:55 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: trivial: comment about vif object address field https://review.openstack.org/335682 | 21:58 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging metadata API support https://review.openstack.org/304511 | 21:58 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging API support https://review.openstack.org/304510 | 21:58 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Compute manager device tagging support https://review.openstack.org/264017 | 21:58 |
| *** ctrath has quit IRC | 21:59 | |
| *** shaohe_feng has quit IRC | 22:00 | |
| *** shaohe_feng has joined #openstack-nova | 22:01 | |
| dansmith | I missed one of the netreqs too | 22:01 |
| mriedem | we have a problem in the neutronv2 api code too | 22:02 |
| *** lpetrut has quit IRC | 22:02 | |
| mriedem | dansmith: comments in https://review.openstack.org/#/c/264017/72 | 22:04 |
| mriedem | we potentially change the mac address | 22:04 |
| *** baoli has joined #openstack-nova | 22:05 | |
| *** mmandel has quit IRC | 22:05 | |
| mriedem | alright, i have to pick up my daughter and head home. i'm solo parenting for a few hours, but i'll be on later. | 22:05 |
| *** baoli has quit IRC | 22:06 | |
| mriedem | i can maybe justify pb&j and tv for a few hours, for the greater good of openstack | 22:06 |
| openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Improve help text for compute manager options https://review.openstack.org/329639 | 22:06 |
| *** mriedem has quit IRC | 22:07 | |
| dansmith | dammit | 22:07 |
| *** thorst has joined #openstack-nova | 22:07 | |
| *** mriedem has joined #openstack-nova | 22:07 | |
| *** mriedem has quit IRC | 22:07 | |
| *** baoli has joined #openstack-nova | 22:08 | |
| *** zzelle_ has quit IRC | 22:08 | |
| *** dmk0202 has quit IRC | 22:08 | |
| *** baoli has quit IRC | 22:08 | |
| *** ihrachys has quit IRC | 22:08 | |
| *** shaohe_feng has quit IRC | 22:10 | |
| *** shaohe_feng has joined #openstack-nova | 22:11 | |
| *** ducttape_ has quit IRC | 22:11 | |
| *** mdrabe has quit IRC | 22:11 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/333181 | 22:11 |
| *** cdelatte has joined #openstack-nova | 22:12 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Compute manager device tagging support https://review.openstack.org/264017 | 22:16 |
| *** ametts has quit IRC | 22:16 | |
| dansmith | artom: running a final full py27 on that ^ and then you should rebase | 22:16 |
| dansmith | hopefully mriedem will be too distracted by children to find anything else | 22:17 |
| *** baoli has joined #openstack-nova | 22:17 | |
| artom | dansmith, I already pushed out my API fix | 22:17 |
| artom | I caught you between two pushed | 22:18 |
| dansmith | artom: but not on top of my patch from a minute ago, right? | 22:18 |
| artom | *pushes | 22:18 |
| artom | No, at 17:58 | 22:18 |
| *** baoli has quit IRC | 22:18 | |
| dansmith | artom: right, so need one more rebase right? | 22:19 |
| *** burt has quit IRC | 22:19 | |
| *** cdelatte has quit IRC | 22:19 | |
| dansmith | I can do it in gerrit I guess | 22:20 |
| *** xyang1 has quit IRC | 22:20 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Device tagging API support https://review.openstack.org/304510 | 22:20 |
| *** shaohe_feng has quit IRC | 22:20 | |
| *** shaohe_feng has joined #openstack-nova | 22:21 | |
| *** baoli has joined #openstack-nova | 22:21 | |
| *** rtheis has quit IRC | 22:22 | |
| *** tbachman_ has joined #openstack-nova | 22:23 | |
| *** abc has joined #openstack-nova | 22:24 | |
| *** abc is now known as Guest79590 | 22:24 | |
| *** Apoorva has joined #openstack-nova | 22:24 | |
| *** tbachman has quit IRC | 22:24 | |
| *** tbachman_ is now known as tbachman | 22:24 | |
| *** rama_y has joined #openstack-nova | 22:25 | |
| *** ayoung has joined #openstack-nova | 22:27 | |
| *** Apoorva has quit IRC | 22:28 | |
| *** baoli has quit IRC | 22:28 | |
| *** shaohe_feng has quit IRC | 22:31 | |
| *** shaohe_feng has joined #openstack-nova | 22:31 | |
| openstackgerrit | Anusha Unnam proposed openstack/nova: Improve the help text for compute timeout_opts https://review.openstack.org/317693 | 22:34 |
| *** baoli has joined #openstack-nova | 22:34 | |
| *** baoli has quit IRC | 22:35 | |
| *** stevemar_ has quit IRC | 22:38 | |
| *** tblakeslee has quit IRC | 22:38 | |
| *** efried has quit IRC | 22:38 | |
| *** shaohe_feng has quit IRC | 22:41 | |
| *** shaohe_feng has joined #openstack-nova | 22:41 | |
| *** sdake_ has joined #openstack-nova | 22:42 | |
| *** cdelatte has joined #openstack-nova | 22:42 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: Device tagging metadata API support https://review.openstack.org/304511 | 22:42 |
| *** amotoki has joined #openstack-nova | 22:42 | |
| *** sdake has quit IRC | 22:45 | |
| *** edmondsw has quit IRC | 22:46 | |
| *** amotoki has quit IRC | 22:47 | |
| *** baoli has joined #openstack-nova | 22:48 | |
| *** baoli has quit IRC | 22:49 | |
| *** sdake_ has quit IRC | 22:49 | |
| *** cdelatte has quit IRC | 22:51 | |
| *** shaohe_feng has quit IRC | 22:51 | |
| openstackgerrit | melanie witt proposed openstack/nova: DO NOT MERGE: Testing reverted patch https://review.openstack.org/335697 | 22:51 |
| *** shaohe_feng has joined #openstack-nova | 22:52 | |
| *** code-R_ has quit IRC | 22:52 | |
| *** sameo has quit IRC | 22:54 | |
| *** baoli has joined #openstack-nova | 22:55 | |
| openstackgerrit | STEW TY proposed openstack/nova: Complete verification for os-virtual-interfaces https://review.openstack.org/335702 | 22:56 |
| *** baoli has quit IRC | 22:56 | |
| *** diogogmt has joined #openstack-nova | 22:56 | |
| *** thorst has quit IRC | 22:58 | |
| *** baoli has joined #openstack-nova | 22:58 | |
| *** thorst has joined #openstack-nova | 22:59 | |
| *** salv-orl_ has joined #openstack-nova | 22:59 | |
| *** baoli has quit IRC | 22:59 | |
| *** sdake has joined #openstack-nova | 23:01 | |
| *** shaohe_feng has quit IRC | 23:01 | |
| *** shaohe_feng has joined #openstack-nova | 23:02 | |
| *** salv-orlando has quit IRC | 23:03 | |
| *** rfolco has joined #openstack-nova | 23:03 | |
| *** rfolco has quit IRC | 23:03 | |
| *** sdake has quit IRC | 23:04 | |
| *** muawiakhan has joined #openstack-nova | 23:07 | |
| *** thorst has quit IRC | 23:07 | |
| *** rfolco has joined #openstack-nova | 23:10 | |
| *** baoli has joined #openstack-nova | 23:11 | |
| *** rfolco has quit IRC | 23:11 | |
| *** muawiakhan has quit IRC | 23:11 | |
| *** mriedem has joined #openstack-nova | 23:11 | |
| *** shaohe_feng has quit IRC | 23:12 | |
| *** baoli has quit IRC | 23:12 | |
| *** shaohe_feng has joined #openstack-nova | 23:12 | |
| *** rfolco has joined #openstack-nova | 23:13 | |
| *** rfolco has quit IRC | 23:13 | |
| *** rfolco_ has joined #openstack-nova | 23:13 | |
| *** jamielennox is now known as jamielennox|away | 23:13 | |
| *** rfolco_ has quit IRC | 23:14 | |
| *** rfolco_ has joined #openstack-nova | 23:14 | |
| mriedem | oh no i've been summoned for jury duty | 23:14 |
| *** rfolco_ has quit IRC | 23:14 | |
| *** shaohe_feng has quit IRC | 23:22 | |
| *** shaohe_feng has joined #openstack-nova | 23:22 | |
| *** gjayavelu has joined #openstack-nova | 23:25 | |
| *** gjayavelu has quit IRC | 23:25 | |
| *** Prophidys has joined #openstack-nova | 23:25 | |
| *** baoli has joined #openstack-nova | 23:28 | |
| *** code-R has joined #openstack-nova | 23:28 | |
| *** baoli has quit IRC | 23:29 | |
| *** shaohe_feng has quit IRC | 23:32 | |
| *** shaohe_feng has joined #openstack-nova | 23:32 | |
| *** slagle has joined #openstack-nova | 23:33 | |
| *** dingboopt has joined #openstack-nova | 23:34 | |
| *** erlon has quit IRC | 23:36 | |
| *** syjulian has quit IRC | 23:38 | |
| *** yassine__ has quit IRC | 23:40 | |
| *** shaohe_feng has quit IRC | 23:42 | |
| *** shaohe_feng has joined #openstack-nova | 23:43 | |
| mriedem | dansmith: so gd close https://review.openstack.org/#/c/264017/ | 23:46 |
| dansmith | mriedem: give me a sec | 23:47 |
| mriedem | also, we were good with the BuildAbortException in the compute manager rather than RescheduleException? | 23:48 |
| dansmith | yeah, artom and I talked it over a couple days ago and if it's the other, | 23:49 |
| dansmith | it's really not a very nice DoS vector | 23:49 |
| openstackgerrit | Dan Smith proposed openstack/nova: Compute manager device tagging support https://review.openstack.org/264017 | 23:51 |
| dansmith | mriedem: when we have the scheduler filter we won't hit it, and until then, it's kindof an attack if you can cause a bunch of expensive reschedules | 23:51 |
| dansmith | mriedem: ^ | 23:51 |
| *** jamielennox|away is now known as jamielennox | 23:51 | |
| mriedem | alright | 23:52 |
| dansmith | I swear I squashed that print out | 23:52 |
| dansmith | I blame git | 23:53 |
| *** shaohe_feng has quit IRC | 23:53 | |
| *** shaohe_feng has joined #openstack-nova | 23:53 | |
| mriedem | is self.instance.uuid an object in that neutron test? | 23:54 |
| mriedem | or a dict? | 23:54 |
| dansmith | an object, I checked | 23:55 |
| dansmith | L396 | 23:55 |
| dansmith | and it runs for me | 23:55 |
| dansmith | I started with dict syntax because other tests use it, but knew you'd nail my ass if you found it to be an object | 23:55 |
| mriedem | ah ok self.instance = self._fake_instance_object(self.instance) | 23:55 |
| mriedem | i noticed self.instance was a dict in the init | 23:55 |
| mriedem | ha | 23:56 |
| *** sacharya_ has quit IRC | 23:56 | |
| mriedem | alright, well, i think this is gd ready to go | 23:56 |
| dansmith | now I have to find someone else to +W it since my cooties are all over it | 23:56 |
| mriedem | yeah, that's the hard part | 23:57 |
| dansmith | mikal: I will be your best friend if you review this: https://review.openstack.org/#/c/264017 | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!