jaypipes | Redcavalier: best chance would be to post your question to the openstack-dev@ mailing list, but we can try our best to point you in a direction. | 00:00 |
---|---|---|
Redcavalier | Essentially, when I start the scheduler I get RuntimeError: (u'Cannot load host manager from configuration scheduler_host_manager = %(conf)s.', {'conf': 'host_manager'}) | 00:00 |
Redcavalier | This is a new message that was added in mitaka I believe. For some reason, Nova is not able to load its default value for the scheduler host manager. | 00:00 |
jaypipes | Redcavalier: what release are you updating from? | 00:01 |
Redcavalier | liberty | 00:01 |
jaypipes | and can you pastebin your nova.conf on the scheduler please? | 00:02 |
Redcavalier | yes | 00:02 |
Redcavalier | only the parameters regarding the scheduler | 00:02 |
Redcavalier | if that's fine | 00:02 |
jaypipes | Redcavalier: sure | 00:02 |
*** ivase has joined #openstack-nova | 00:03 | |
*** Swami has quit IRC | 00:03 | |
*** ivase_ has quit IRC | 00:03 | |
Redcavalier | http://pastebin.com/q6ae7ULg | 00:04 |
jaypipes | Redcavalier: try just deleting the scheduler_host_manager line. | 00:04 |
*** diogogmt has quit IRC | 00:04 | |
Redcavalier | same issue | 00:05 |
Redcavalier | If that helps also, I remember that at some point, I installed Rally on my controller1 and it broke the setup a little. I was able to repair it, but since my controller1 and 2 sometimes behave differently | 00:05 |
Redcavalier | for example, here I have this issue on my controller 1 but not on my controller 2 | 00:05 |
Redcavalier | uninstalling and reinstalling packages doesn't fix it either. It's really a mystery. | 00:06 |
*** BjoernT has joined #openstack-nova | 00:07 | |
*** sdake has joined #openstack-nova | 00:08 | |
*** ivase_ has joined #openstack-nova | 00:08 | |
Redcavalier | but in this case, it sounds like it litteraly can't find the "host_manager" refered to here, even though there's like only 2 possible values for that and I'm not using ironic. | 00:09 |
*** BjoernT has quit IRC | 00:09 | |
jaypipes | Redcavalier: please pastebin your setup.cfg file from the scheduler machine. | 00:09 |
*** shaohe_feng has quit IRC | 00:09 | |
*** ivase has quit IRC | 00:10 | |
Redcavalier | that's something I've been looking around for and unable to find. Is there a default path for it? | 00:10 |
*** shaohe_feng has joined #openstack-nova | 00:10 | |
jaypipes | Redcavalier: did you install from source or package? | 00:10 |
Redcavalier | package | 00:11 |
Redcavalier | RDO actually | 00:12 |
*** Apoorva has quit IRC | 00:12 | |
*** Apoorva has joined #openstack-nova | 00:12 | |
Redcavalier | that could very well be part of the issue actually | 00:13 |
jaypipes | Redcavalier: sounds to me like there's something messed up with the package's entrypoints configuration. Your best bet would be to chat with one of the RH packaging folks. I think dprince on #openstack-dev might be able to help. | 00:13 |
Redcavalier | ah, thank you | 00:13 |
jaypipes | Redcavalier: if not Dan (dprince) should be able to direct you to a good person for assistance. | 00:14 |
Redcavalier | yes, that will help | 00:14 |
*** ivase has joined #openstack-nova | 00:14 | |
*** ivase_ has quit IRC | 00:15 | |
*** Swami has joined #openstack-nova | 00:19 | |
*** shaohe_feng has quit IRC | 00:20 | |
*** shaohe_feng has joined #openstack-nova | 00:20 | |
*** ivase_ has joined #openstack-nova | 00:20 | |
*** Swami has quit IRC | 00:20 | |
*** rrecio has quit IRC | 00:20 | |
*** Swami has joined #openstack-nova | 00:20 | |
*** ivase has quit IRC | 00:21 | |
openstackgerrit | STEW TY proposed openstack/nova: Complete verification of servers-action-fixed-ip.inc https://review.openstack.org/338606 | 00:21 |
*** zz_dimtruck is now known as dimtruck | 00:22 | |
*** Swami_ has joined #openstack-nova | 00:23 | |
*** Swami has quit IRC | 00:25 | |
*** thorst has joined #openstack-nova | 00:25 | |
*** ivase has joined #openstack-nova | 00:26 | |
*** ivase_ has quit IRC | 00:27 | |
*** claudiub|2 has joined #openstack-nova | 00:30 | |
*** shaohe_feng has quit IRC | 00:30 | |
*** shaohe_feng has joined #openstack-nova | 00:31 | |
*** penick has joined #openstack-nova | 00:31 | |
*** ivase_ has joined #openstack-nova | 00:32 | |
*** claudiub has quit IRC | 00:32 | |
*** thorst has quit IRC | 00:32 | |
*** ivase has quit IRC | 00:32 | |
*** mirrorbo1 is now known as mirrobox | 00:37 | |
*** mirrobox is now known as mirrorbox | 00:37 | |
*** mirrorbox has quit IRC | 00:37 | |
*** mirrorbox has joined #openstack-nova | 00:37 | |
*** ivase has joined #openstack-nova | 00:38 | |
*** ivase_ has quit IRC | 00:38 | |
*** shaohe_feng has quit IRC | 00:40 | |
*** shaohe_feng has joined #openstack-nova | 00:41 | |
*** ducttape_ has joined #openstack-nova | 00:41 | |
*** ducttape_ has joined #openstack-nova | 00:41 | |
*** salv-orl_ has quit IRC | 00:42 | |
*** david-lyle has quit IRC | 00:42 | |
*** hoangcx has joined #openstack-nova | 00:43 | |
*** rfolco_ has quit IRC | 00:43 | |
*** ivase_ has joined #openstack-nova | 00:43 | |
*** ivase has quit IRC | 00:44 | |
openstackgerrit | Jay Pipes proposed openstack/nova-specs: Amend placement REST API with allocation records https://review.openstack.org/338618 | 00:44 |
jaypipes | dansmith: ^ | 00:44 |
*** david-lyle__ has joined #openstack-nova | 00:45 | |
*** david-lyle__ has quit IRC | 00:45 | |
*** qeelee has joined #openstack-nova | 00:47 | |
*** sdake has quit IRC | 00:49 | |
*** ivase has joined #openstack-nova | 00:49 | |
*** thorst has joined #openstack-nova | 00:49 | |
*** ivase_ has quit IRC | 00:50 | |
jaypipes | dansmith: nm, need to rework that :( forgot about the transaction semantics for batching of the allocation records for a consumer. | 00:50 |
*** shaohe_feng has quit IRC | 00:50 | |
*** shaohe_feng has joined #openstack-nova | 00:51 | |
*** ctrath has quit IRC | 00:51 | |
*** ducttape_ has quit IRC | 00:51 | |
*** ducttape_ has joined #openstack-nova | 00:53 | |
*** Sukhdev has joined #openstack-nova | 00:53 | |
*** kevin_zh has joined #openstack-nova | 00:54 | |
*** ivase_ has joined #openstack-nova | 00:55 | |
*** ivase has quit IRC | 00:55 | |
*** MikeG451 has quit IRC | 00:57 | |
*** Apoorva_ has joined #openstack-nova | 00:58 | |
*** nic has left #openstack-nova | 01:01 | |
*** kevin_zh has quit IRC | 01:01 | |
*** shaohe_feng has quit IRC | 01:01 | |
*** ivase has joined #openstack-nova | 01:01 | |
*** ivase_ has quit IRC | 01:01 | |
*** kevin_zh has joined #openstack-nova | 01:01 | |
*** shaohe_feng has joined #openstack-nova | 01:02 | |
*** Apoorva has quit IRC | 01:02 | |
openstackgerrit | Jay Pipes proposed openstack/nova-specs: Amend placement REST API with allocation records https://review.openstack.org/338618 | 01:02 |
jaypipes | dansmith: ok, now done. :) ^^ | 01:02 |
*** Apoorva_ has quit IRC | 01:03 | |
*** rook has quit IRC | 01:03 | |
*** fishcried has joined #openstack-nova | 01:05 | |
*** kevin_zh has quit IRC | 01:05 | |
*** rama_y has quit IRC | 01:05 | |
*** kevin_zh has joined #openstack-nova | 01:05 | |
*** hieulq has quit IRC | 01:05 | |
*** hieulq_ is now known as hieulq | 01:05 | |
*** hieulq is now known as Guest52040 | 01:06 | |
*** ducttape_ has quit IRC | 01:07 | |
*** ivase_ has joined #openstack-nova | 01:07 | |
*** ivase has quit IRC | 01:07 | |
*** shaohe_feng has quit IRC | 01:11 | |
*** shaohe_feng has joined #openstack-nova | 01:11 | |
*** ctrath has joined #openstack-nova | 01:12 | |
*** thorst has quit IRC | 01:12 | |
*** ivase has joined #openstack-nova | 01:12 | |
*** kevin_zh has quit IRC | 01:13 | |
*** thorst has joined #openstack-nova | 01:13 | |
*** kevin_zh has joined #openstack-nova | 01:13 | |
*** ivase_ has quit IRC | 01:14 | |
*** kevin_zh has quit IRC | 01:16 | |
*** kevin_zh has joined #openstack-nova | 01:17 | |
*** ivase_ has joined #openstack-nova | 01:18 | |
*** ivase has quit IRC | 01:19 | |
*** hieulq_ has joined #openstack-nova | 01:19 | |
*** fishcried has quit IRC | 01:20 | |
*** shaohe_feng has quit IRC | 01:21 | |
*** code-R has quit IRC | 01:21 | |
*** code-R_ has joined #openstack-nova | 01:21 | |
*** EinstCrazy has joined #openstack-nova | 01:22 | |
*** thorst has quit IRC | 01:22 | |
*** shaohe_feng has joined #openstack-nova | 01:22 | |
*** ivase has joined #openstack-nova | 01:24 | |
*** ivase_ has quit IRC | 01:25 | |
*** gjayavelu has quit IRC | 01:25 | |
openstackgerrit | Yingxin Cheng proposed openstack/nova: Amend reqired policy in numa topology filter https://review.openstack.org/338632 | 01:27 |
*** Swami has joined #openstack-nova | 01:27 | |
*** YifanZeng has joined #openstack-nova | 01:28 | |
*** ducttape_ has joined #openstack-nova | 01:28 | |
*** code-R_ has quit IRC | 01:29 | |
*** ivase_ has joined #openstack-nova | 01:30 | |
*** ravikama_ has quit IRC | 01:30 | |
*** Sukhdev has quit IRC | 01:30 | |
*** Swami_ has quit IRC | 01:30 | |
*** ivase has quit IRC | 01:31 | |
*** yuikotakadamori has joined #openstack-nova | 01:31 | |
*** shaohe_feng has quit IRC | 01:31 | |
openstackgerrit | Jinquan Ni proposed openstack/nova: manager:mark a vm that resume failed https://review.openstack.org/289745 | 01:32 |
*** Daisy has joined #openstack-nova | 01:32 | |
*** shaohe_feng has joined #openstack-nova | 01:32 | |
openstackgerrit | Jay Pipes proposed openstack/nova-specs: resource-providers: Populate allocation fields https://review.openstack.org/300177 | 01:33 |
jaypipes | dansmith: k, hopefully addressed your and edleafe's comments in ^^ | 01:33 |
*** mtanino has joined #openstack-nova | 01:33 | |
jaypipes | \quit | 01:33 |
*** jaypipes has quit IRC | 01:33 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding https://review.openstack.org/217567 | 01:34 |
*** yuikotakadamori has quit IRC | 01:35 | |
*** ivase has joined #openstack-nova | 01:36 | |
*** code-R has joined #openstack-nova | 01:36 | |
*** ivase_ has quit IRC | 01:36 | |
*** wangqun has joined #openstack-nova | 01:38 | |
*** tonytan4ever has quit IRC | 01:41 | |
*** ivase_ has joined #openstack-nova | 01:41 | |
*** shaohe_feng has quit IRC | 01:42 | |
*** shaohe_feng has joined #openstack-nova | 01:43 | |
*** ivase has quit IRC | 01:43 | |
*** rook has joined #openstack-nova | 01:44 | |
openstackgerrit | liuxiuli proposed openstack/nova: Modify docstring of numa_get_reserved_huge_pages method https://review.openstack.org/338261 | 01:47 |
*** hieulq_ has quit IRC | 01:47 | |
*** ivase has joined #openstack-nova | 01:47 | |
*** ivase_ has quit IRC | 01:48 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Example and body verification of os-quota-sets.inc https://review.openstack.org/338140 | 01:49 |
*** Guest52040 has quit IRC | 01:50 | |
*** sdake has joined #openstack-nova | 01:50 | |
*** shaohe_feng has quit IRC | 01:52 | |
*** shaohe_feng has joined #openstack-nova | 01:53 | |
*** ivase_ has joined #openstack-nova | 01:53 | |
*** ivase has quit IRC | 01:54 | |
*** claudiub has joined #openstack-nova | 01:54 | |
*** pacoblox has joined #openstack-nova | 01:56 | |
openstackgerrit | Tina Kevin proposed openstack/nova: Check block job info before abort it https://review.openstack.org/337226 | 01:58 |
*** claudiub|2 has quit IRC | 01:58 | |
*** ivase has joined #openstack-nova | 01:59 | |
*** ravikama_ has joined #openstack-nova | 01:59 | |
*** ivase_ has quit IRC | 02:00 | |
*** hieulq has joined #openstack-nova | 02:00 | |
*** DaiDV has joined #openstack-nova | 02:02 | |
*** shaohe_feng has quit IRC | 02:02 | |
*** shaohe_feng has joined #openstack-nova | 02:03 | |
*** ivase_ has joined #openstack-nova | 02:04 | |
openstackgerrit | Tina Kevin proposed openstack/nova: Check block job info before abort it https://review.openstack.org/337226 | 02:05 |
*** ivase has quit IRC | 02:05 | |
openstackgerrit | Eli Qiao proposed openstack/nova: API: catch InstanceNotReady exception. https://review.openstack.org/338034 | 02:06 |
*** diogogmt has joined #openstack-nova | 02:07 | |
*** browne has quit IRC | 02:10 | |
openstackgerrit | Zhenguo Niu proposed openstack/nova: Set node's resources unavailable if no ports associated https://review.openstack.org/321014 | 02:10 |
*** ivase has joined #openstack-nova | 02:10 | |
*** ivase_ has quit IRC | 02:11 | |
*** shaohe_feng has quit IRC | 02:12 | |
*** shaohe_feng has joined #openstack-nova | 02:13 | |
*** cdelatte has quit IRC | 02:14 | |
*** ivase_ has joined #openstack-nova | 02:16 | |
*** ivase has quit IRC | 02:16 | |
*** salv-orlando has joined #openstack-nova | 02:19 | |
*** oss_xzdong has joined #openstack-nova | 02:20 | |
*** gjayavelu has joined #openstack-nova | 02:21 | |
*** Swami_ has joined #openstack-nova | 02:21 | |
*** unicell1 has quit IRC | 02:22 | |
*** thorst has joined #openstack-nova | 02:22 | |
*** ivase has joined #openstack-nova | 02:22 | |
*** ivase_ has quit IRC | 02:23 | |
*** shaohe_feng has quit IRC | 02:23 | |
*** shaohe_feng has joined #openstack-nova | 02:23 | |
*** DaiDV has quit IRC | 02:24 | |
*** wanghao_ has joined #openstack-nova | 02:25 | |
*** Swami has quit IRC | 02:25 | |
*** salv-orlando has quit IRC | 02:26 | |
*** thorst has quit IRC | 02:27 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Example and body verification of os-quota-sets.inc https://review.openstack.org/338140 | 02:28 |
*** ivase_ has joined #openstack-nova | 02:28 | |
*** ivase has quit IRC | 02:29 | |
*** shaohe_feng has quit IRC | 02:33 | |
openstackgerrit | Chen Fan proposed openstack/nova: api-ref: unify the delete response infomation https://review.openstack.org/338651 | 02:33 |
*** ivase has joined #openstack-nova | 02:33 | |
*** thorst has joined #openstack-nova | 02:34 | |
*** shaohe_feng has joined #openstack-nova | 02:34 | |
*** thorst has quit IRC | 02:34 | |
*** ducttape_ has quit IRC | 02:34 | |
*** ivase_ has quit IRC | 02:34 | |
*** Swami__ has joined #openstack-nova | 02:35 | |
*** rtheis has quit IRC | 02:35 | |
*** yamahata has quit IRC | 02:38 | |
*** Swami_ has quit IRC | 02:39 | |
*** ivase_ has joined #openstack-nova | 02:39 | |
*** ivase has quit IRC | 02:40 | |
*** gjayavelu has quit IRC | 02:40 | |
*** tonytan4ever has joined #openstack-nova | 02:42 | |
*** shaohe_feng has quit IRC | 02:43 | |
*** shaohe_feng has joined #openstack-nova | 02:44 | |
*** ivase has joined #openstack-nova | 02:45 | |
*** ivase_ has quit IRC | 02:46 | |
*** tonytan4ever has quit IRC | 02:47 | |
*** DaiDV has joined #openstack-nova | 02:49 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding https://review.openstack.org/217567 | 02:50 |
*** ivase_ has joined #openstack-nova | 02:51 | |
*** ivase has quit IRC | 02:52 | |
*** shaohe_feng has quit IRC | 02:53 | |
*** baoli has joined #openstack-nova | 02:54 | |
*** rook has quit IRC | 02:54 | |
*** shaohe_feng has joined #openstack-nova | 02:54 | |
*** browne has joined #openstack-nova | 02:54 | |
*** salv-orlando has joined #openstack-nova | 02:55 | |
openstackgerrit | Anusha Unnam proposed openstack/nova: Transform instance.resize notifications https://review.openstack.org/329255 | 02:56 |
*** baoli_ has joined #openstack-nova | 02:56 | |
*** tbachman has quit IRC | 02:57 | |
*** ivase has joined #openstack-nova | 02:57 | |
*** Nakato has quit IRC | 02:57 | |
*** ivase_ has quit IRC | 02:57 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add support matrix for attach and detach interfaces https://review.openstack.org/312801 | 02:58 |
*** woodster_ has quit IRC | 02:59 | |
*** baoli has quit IRC | 02:59 | |
*** salv-orlando has quit IRC | 02:59 | |
*** ivase_ has joined #openstack-nova | 03:02 | |
openstackgerrit | bailin.zhang proposed openstack/nova: Unplug vifs when VM create failed https://review.openstack.org/331113 | 03:03 |
*** ivase has quit IRC | 03:03 | |
*** Nakato has joined #openstack-nova | 03:03 | |
*** shaohe_feng has quit IRC | 03:04 | |
*** Daisy has quit IRC | 03:04 | |
*** shaohe_feng has joined #openstack-nova | 03:04 | |
openstackgerrit | bailin.zhang proposed openstack/nova: Unplug vifs when VM create failed https://review.openstack.org/331113 | 03:04 |
*** Redcavalier has quit IRC | 03:05 | |
*** tjones has joined #openstack-nova | 03:06 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Example and body verification of os-quota-sets.inc https://review.openstack.org/338140 | 03:08 |
*** ivase_ has quit IRC | 03:08 | |
*** ivase has joined #openstack-nova | 03:09 | |
*** Swami_ has joined #openstack-nova | 03:09 | |
*** Daisy has joined #openstack-nova | 03:10 | |
*** coreywright has quit IRC | 03:10 | |
*** gjayavelu has joined #openstack-nova | 03:11 | |
*** tjones has left #openstack-nova | 03:12 | |
*** Swami__ has quit IRC | 03:12 | |
openstackgerrit | javeme proposed openstack/nova: Check server_group_members quota as soon as possible https://review.openstack.org/337251 | 03:13 |
*** shaohe_feng has quit IRC | 03:14 | |
*** ivase_ has joined #openstack-nova | 03:14 | |
*** Daisy_ has joined #openstack-nova | 03:14 | |
*** shaohe_feng has joined #openstack-nova | 03:14 | |
*** Daisy has quit IRC | 03:15 | |
*** ivase has quit IRC | 03:15 | |
openstackgerrit | jichenjc proposed openstack/nova: Verify os-aggregates.inc on sample files https://review.openstack.org/333114 | 03:16 |
openstackgerrit | Jianghua Wang proposed openstack/nova: XenAPI: add unit test for plugin bandwidth https://review.openstack.org/286445 | 03:17 |
*** DaiDV has quit IRC | 03:17 | |
*** ivase has joined #openstack-nova | 03:20 | |
*** vishwanathj has joined #openstack-nova | 03:20 | |
*** ivase_ has quit IRC | 03:21 | |
*** ducttape_ has joined #openstack-nova | 03:22 | |
*** jwcroppe has quit IRC | 03:24 | |
*** shaohe_feng has quit IRC | 03:24 | |
*** jwcroppe has joined #openstack-nova | 03:24 | |
*** shaohe_feng has joined #openstack-nova | 03:25 | |
*** ivase_ has joined #openstack-nova | 03:26 | |
*** ivase has quit IRC | 03:27 | |
*** tonytan4ever has joined #openstack-nova | 03:27 | |
*** coreywright has joined #openstack-nova | 03:28 | |
*** gjayavelu has quit IRC | 03:28 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/333181 | 03:28 |
*** jwcroppe has quit IRC | 03:29 | |
*** salv-orlando has joined #openstack-nova | 03:29 | |
*** ivase has joined #openstack-nova | 03:31 | |
*** ivase_ has quit IRC | 03:33 | |
*** shaohe_feng has quit IRC | 03:34 | |
*** thorst has joined #openstack-nova | 03:34 | |
*** ducttape_ has quit IRC | 03:35 | |
*** Daisy_ has quit IRC | 03:36 | |
*** salv-orlando has quit IRC | 03:36 | |
*** shaohe_feng has joined #openstack-nova | 03:37 | |
*** ivase_ has joined #openstack-nova | 03:37 | |
*** ivase has quit IRC | 03:38 | |
*** ljxiash has joined #openstack-nova | 03:40 | |
*** Daisy has joined #openstack-nova | 03:41 | |
*** ljxiash has quit IRC | 03:42 | |
*** zerda2 has joined #openstack-nova | 03:43 | |
*** jamielennox is now known as jamielennox|away | 03:43 | |
*** ivase has joined #openstack-nova | 03:43 | |
*** thorst has quit IRC | 03:43 | |
*** ivase_ has quit IRC | 03:44 | |
*** shaohe_feng has quit IRC | 03:45 | |
*** sree has joined #openstack-nova | 03:45 | |
*** Daisy has quit IRC | 03:46 | |
*** shaohe_feng has joined #openstack-nova | 03:47 | |
*** Daisy has joined #openstack-nova | 03:47 | |
*** sdake has quit IRC | 03:48 | |
*** code-R_ has joined #openstack-nova | 03:49 | |
*** ivase_ has joined #openstack-nova | 03:49 | |
*** ivase has quit IRC | 03:50 | |
*** DaiDV has joined #openstack-nova | 03:50 | |
openstackgerrit | John Hua proposed openstack/nova: POC: WIP: XenAPI: device tagging https://review.openstack.org/333781 | 03:50 |
*** code-R has quit IRC | 03:51 | |
*** chandankumar has joined #openstack-nova | 03:52 | |
*** Daisy has quit IRC | 03:52 | |
*** Daisy has joined #openstack-nova | 03:53 | |
*** shyama has joined #openstack-nova | 03:54 | |
*** shaohe_feng has quit IRC | 03:55 | |
*** ivase has joined #openstack-nova | 03:55 | |
*** ivase_ has quit IRC | 03:55 | |
*** shaohe_feng has joined #openstack-nova | 03:55 | |
*** jamielennox|away is now known as jamielennox | 03:56 | |
*** lbeliveau has quit IRC | 03:57 | |
*** mtanino has quit IRC | 03:57 | |
*** Daisy has quit IRC | 03:58 | |
*** gjayavelu has joined #openstack-nova | 03:59 | |
*** gjayavelu has quit IRC | 03:59 | |
*** pacoblox has quit IRC | 03:59 | |
*** lbeliveau has joined #openstack-nova | 03:59 | |
*** shyama has quit IRC | 04:00 | |
*** ivase_ has joined #openstack-nova | 04:00 | |
*** browne has quit IRC | 04:01 | |
*** ivase has quit IRC | 04:02 | |
*** Swami__ has joined #openstack-nova | 04:02 | |
*** links has joined #openstack-nova | 04:03 | |
*** pacoblox has joined #openstack-nova | 04:04 | |
*** Daisy has joined #openstack-nova | 04:04 | |
*** shaohe_feng has quit IRC | 04:05 | |
*** shaohe_feng has joined #openstack-nova | 04:05 | |
*** Swami_ has quit IRC | 04:06 | |
*** ivase has joined #openstack-nova | 04:06 | |
*** ivase_ has quit IRC | 04:07 | |
*** Daisy_ has joined #openstack-nova | 04:07 | |
*** Daisy has quit IRC | 04:09 | |
*** sheel has joined #openstack-nova | 04:09 | |
*** yuikotak_ has joined #openstack-nova | 04:10 | |
*** Daisy_ has quit IRC | 04:12 | |
*** unicell has joined #openstack-nova | 04:12 | |
*** ivase_ has joined #openstack-nova | 04:12 | |
*** harlowja_at_home has joined #openstack-nova | 04:12 | |
*** ivase has quit IRC | 04:12 | |
*** Daisy has joined #openstack-nova | 04:14 | |
*** DaiDV has quit IRC | 04:15 | |
*** shaohe_feng has quit IRC | 04:15 | |
*** shaohe_feng has joined #openstack-nova | 04:16 | |
*** DaiDV has joined #openstack-nova | 04:17 | |
*** ivase has joined #openstack-nova | 04:18 | |
*** ivase_ has quit IRC | 04:18 | |
*** DaiDV has quit IRC | 04:21 | |
*** shyama has joined #openstack-nova | 04:22 | |
*** harlowja_at_home has quit IRC | 04:22 | |
*** ivase_ has joined #openstack-nova | 04:23 | |
*** ivase has quit IRC | 04:25 | |
*** shaohe_feng has quit IRC | 04:26 | |
*** jwcroppe has joined #openstack-nova | 04:26 | |
*** shaohe_feng has joined #openstack-nova | 04:26 | |
*** jwcroppe has quit IRC | 04:28 | |
*** ivase has joined #openstack-nova | 04:29 | |
*** ivase_ has quit IRC | 04:31 | |
*** sdake has joined #openstack-nova | 04:32 | |
*** jamielennox is now known as jamielennox|away | 04:35 | |
*** ivase_ has joined #openstack-nova | 04:35 | |
*** DaiDV has joined #openstack-nova | 04:35 | |
*** oanson has joined #openstack-nova | 04:35 | |
*** shaohe_feng has quit IRC | 04:36 | |
*** ivase has quit IRC | 04:36 | |
*** shaohe_feng has joined #openstack-nova | 04:37 | |
*** salv-orlando has joined #openstack-nova | 04:39 | |
*** baoli_ has quit IRC | 04:40 | |
openstackgerrit | Sujitha proposed openstack/nova: Transform instance.pause notifications https://review.openstack.org/329141 | 04:40 |
*** ivase has joined #openstack-nova | 04:41 | |
*** thorst has joined #openstack-nova | 04:41 | |
*** ivase_ has quit IRC | 04:42 | |
*** jamielennox|away is now known as jamielennox | 04:42 | |
*** dimtruck is now known as zz_dimtruck | 04:43 | |
*** tonytan4ever has quit IRC | 04:44 | |
*** Swami_ has joined #openstack-nova | 04:45 | |
*** shaohe_feng has quit IRC | 04:46 | |
*** shaohe_feng has joined #openstack-nova | 04:47 | |
*** ivase_ has joined #openstack-nova | 04:47 | |
*** salv-orlando has quit IRC | 04:47 | |
*** ivase has quit IRC | 04:47 | |
*** thorst has quit IRC | 04:48 | |
*** Sukhdev has joined #openstack-nova | 04:49 | |
*** salv-orlando has joined #openstack-nova | 04:49 | |
*** prateek has joined #openstack-nova | 04:50 | |
*** Swami__ has quit IRC | 04:50 | |
*** sdake has quit IRC | 04:51 | |
*** yuikotak_ has quit IRC | 04:51 | |
*** Jeffrey4l_ has joined #openstack-nova | 04:51 | |
*** ivase has joined #openstack-nova | 04:53 | |
*** ivase_ has quit IRC | 04:53 | |
*** sdake has joined #openstack-nova | 04:54 | |
*** shaohe_feng has quit IRC | 04:56 | |
*** shaohe_feng has joined #openstack-nova | 04:57 | |
*** ivase_ has joined #openstack-nova | 04:58 | |
*** ivase has quit IRC | 04:59 | |
*** ratailor has joined #openstack-nova | 05:01 | |
*** yamahata has joined #openstack-nova | 05:01 | |
*** ivase has joined #openstack-nova | 05:04 | |
*** sree has quit IRC | 05:05 | |
*** ivase_ has quit IRC | 05:05 | |
*** gjayavelu has joined #openstack-nova | 05:06 | |
*** ducttape_ has joined #openstack-nova | 05:06 | |
*** shaohe_feng has quit IRC | 05:07 | |
*** shaohe_feng has joined #openstack-nova | 05:07 | |
*** DaiDV has quit IRC | 05:09 | |
*** gjayavelu has quit IRC | 05:10 | |
*** lpetrut has joined #openstack-nova | 05:10 | |
*** ivase_ has joined #openstack-nova | 05:10 | |
*** ivase has quit IRC | 05:11 | |
*** pacoblox has quit IRC | 05:11 | |
*** ducttape_ has quit IRC | 05:12 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: Added support for new block device format in vmops https://review.openstack.org/246299 | 05:14 |
*** ivase has joined #openstack-nova | 05:16 | |
*** ivase_ has quit IRC | 05:17 | |
*** shaohe_feng has quit IRC | 05:17 | |
*** shaohe_feng has joined #openstack-nova | 05:17 | |
openstackgerrit | John Hua proposed openstack/nova: XenAPI: device tagging https://review.openstack.org/333781 | 05:18 |
*** Daisy has quit IRC | 05:18 | |
*** Daisy has joined #openstack-nova | 05:18 | |
*** ivase_ has joined #openstack-nova | 05:21 | |
*** ivase has quit IRC | 05:22 | |
*** Daisy has quit IRC | 05:23 | |
*** bharathk has joined #openstack-nova | 05:23 | |
*** gjayavelu has joined #openstack-nova | 05:25 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding https://review.openstack.org/217567 | 05:25 |
*** sdake has quit IRC | 05:26 | |
*** shaohe_feng has quit IRC | 05:27 | |
*** shaohe_feng has joined #openstack-nova | 05:28 | |
*** ivase has joined #openstack-nova | 05:28 | |
*** ivase_ has quit IRC | 05:28 | |
oomichi | alex_xu: hello | 05:29 |
alex_xu | oomichi: hi | 05:29 |
oomichi | alex_xu: I put a comment on https://review.openstack.org/#/c/332631 | 05:29 |
oomichi | alex_xu: happy if you see it | 05:29 |
alex_xu | oomichi: thanks for the review | 05:31 |
alex_xu | oomichi: i also thought that method, but that means the unittest only valid in the last patch | 05:31 |
alex_xu | oomichi: the johnthetubaguy's propose, we squash all the patches into single one, after people reviewed all the patch. I feel your propose and johnthetubaguy's propose both are good to me. | 05:32 |
*** ivase_ has joined #openstack-nova | 05:33 | |
oomichi | alex_xu: johnthetubaguy's idea is interesting for me because I never see such patch(maybe a single super huge patch) :) | 05:33 |
alex_xu | oomichi: yea, a single super patch after reviewed | 05:34 |
*** chhavi has joined #openstack-nova | 05:34 | |
alex_xu | oomichi: emm...I can't decide which one is best, how about we waiting for other people feedback, then I will update the patch. | 05:35 |
*** ivase has quit IRC | 05:35 | |
oomichi | alex_xu: maybe that can be a trap. To make patches ready, we will put +2 on several separated patches. then johnthetubaguy will -2 on these patches to make them into a single. | 05:36 |
oomichi | alex_xu: then our disagreement ratio is up ;) | 05:36 |
alex_xu | oomichi: heh :) | 05:36 |
alex_xu | oomichi: we still miss something in the first patch and last second patch. | 05:37 |
*** M00nr41n has joined #openstack-nova | 05:37 | |
openstackgerrit | jichenjc proposed openstack/nova: Verify os-aggregates.inc on sample files https://review.openstack.org/333114 | 05:37 |
alex_xu | but i will try to update the patch asap | 05:37 |
*** gcb has joined #openstack-nova | 05:37 | |
*** shaohe_feng has quit IRC | 05:37 | |
*** shaohe_feng has joined #openstack-nova | 05:38 | |
*** ivase has joined #openstack-nova | 05:39 | |
*** abalutoiu has quit IRC | 05:39 | |
*** sudipto has joined #openstack-nova | 05:39 | |
*** diga has joined #openstack-nova | 05:39 | |
*** ivase_ has quit IRC | 05:40 | |
oomichi | tonyb: mikal: johnthetubaguy: can you take a look at mriedem_afk's stable patch? https://review.openstack.org/#/c/336577/ | 05:40 |
*** chandankumar has quit IRC | 05:40 | |
alex_xu | oomichi: emm... i'm kind of more like your propose, we have untitest result in the last patch is enough, and we are more safe. But let's waiting for more feedback, before update patch, due to it is really a lot of patches. | 05:40 |
oomichi | alex_xu: heh, yeah and we can avoid the trap ;) | 05:41 |
oomichi | alex_xu: and I'd like to find the unit test way | 05:41 |
alex_xu | oomichi: heh, yea, and thanks for the comment again :) | 05:42 |
*** Daisy has joined #openstack-nova | 05:45 | |
*** ivase_ has joined #openstack-nova | 05:45 | |
*** ivase has quit IRC | 05:45 | |
*** thorst has joined #openstack-nova | 05:47 | |
*** shaohe_feng has quit IRC | 05:48 | |
*** shaohe_feng has joined #openstack-nova | 05:48 | |
*** Daisy has quit IRC | 05:49 | |
*** Daisy has joined #openstack-nova | 05:49 | |
*** Daisy has quit IRC | 05:50 | |
*** Daisy has joined #openstack-nova | 05:50 | |
*** ivase has joined #openstack-nova | 05:50 | |
*** ivase_ has quit IRC | 05:51 | |
*** shyama has quit IRC | 05:51 | |
*** sree_ has joined #openstack-nova | 05:51 | |
*** shyama has joined #openstack-nova | 05:51 | |
*** sree_ is now known as Guest12760 | 05:52 | |
openstackgerrit | Yingxin Cheng proposed openstack/nova: Amend reqired policy in numa topology filter https://review.openstack.org/338632 | 05:53 |
*** Swami__ has joined #openstack-nova | 05:53 | |
*** lpetrut has quit IRC | 05:54 | |
*** thorst has quit IRC | 05:54 | |
*** Daisy has quit IRC | 05:55 | |
*** Daisy has joined #openstack-nova | 05:56 | |
*** ivase has quit IRC | 05:57 | |
*** ivase has joined #openstack-nova | 05:57 | |
*** Swami_ has quit IRC | 05:57 | |
*** lpetrut has joined #openstack-nova | 05:58 | |
*** andreykurilin has quit IRC | 05:58 | |
*** shaohe_feng has quit IRC | 05:58 | |
*** wanghao_ has quit IRC | 05:58 | |
*** shaohe_feng has joined #openstack-nova | 05:59 | |
openstackgerrit | zhoujunqiang proposed openstack/nova: api-ref: body verification of os-agents https://review.openstack.org/338705 | 05:59 |
*** mjura has joined #openstack-nova | 05:59 | |
*** zhangyufei has joined #openstack-nova | 06:00 | |
*** Daisy has quit IRC | 06:00 | |
zhangyufei | This pacth ignore irrelevant keys for ComputeCapacityFilter, tests ok, need review.Thanks. https://review.openstack.org/#/c/317306/ | 06:00 |
*** Daisy has joined #openstack-nova | 06:01 | |
*** shyama has quit IRC | 06:01 | |
*** ivase_ has joined #openstack-nova | 06:02 | |
*** ivase has quit IRC | 06:04 | |
*** mjura has quit IRC | 06:07 | |
*** Swami__ has quit IRC | 06:08 | |
*** ivase has joined #openstack-nova | 06:08 | |
*** shaohe_feng has quit IRC | 06:08 | |
*** ivase_ has quit IRC | 06:08 | |
*** shaohe_feng has joined #openstack-nova | 06:09 | |
*** jwcroppe has joined #openstack-nova | 06:09 | |
*** sdake has joined #openstack-nova | 06:10 | |
*** fragatina has quit IRC | 06:10 | |
*** Swami__ has joined #openstack-nova | 06:10 | |
*** lpetrut has quit IRC | 06:10 | |
*** fragatina has joined #openstack-nova | 06:11 | |
*** kevin_zh has quit IRC | 06:12 | |
*** zhangyufei has quit IRC | 06:13 | |
*** ivase_ has joined #openstack-nova | 06:14 | |
*** Sukhdev has quit IRC | 06:14 | |
*** chandankumar has joined #openstack-nova | 06:14 | |
*** ivase has quit IRC | 06:14 | |
*** tonytan4ever has joined #openstack-nova | 06:14 | |
*** edand has joined #openstack-nova | 06:16 | |
*** gjayavelu has quit IRC | 06:18 | |
*** shaohe_feng has quit IRC | 06:18 | |
*** rcernin has joined #openstack-nova | 06:18 | |
*** sdake has quit IRC | 06:19 | |
*** shaohe_feng has joined #openstack-nova | 06:19 | |
*** ivase has joined #openstack-nova | 06:19 | |
*** sdake has joined #openstack-nova | 06:19 | |
*** tonytan4ever has quit IRC | 06:20 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Adds Hyper-V UEFI Secure Boot https://review.openstack.org/209581 | 06:20 |
*** mjura has joined #openstack-nova | 06:20 | |
*** ivase_ has quit IRC | 06:20 | |
*** ljxiash has joined #openstack-nova | 06:22 | |
*** Swami__ has quit IRC | 06:23 | |
*** jwcroppe has quit IRC | 06:24 | |
*** lpetrut has joined #openstack-nova | 06:24 | |
*** huanxie has joined #openstack-nova | 06:25 | |
*** ivase_ has joined #openstack-nova | 06:26 | |
*** ivase has quit IRC | 06:26 | |
*** Daisy_ has joined #openstack-nova | 06:28 | |
*** shaohe_feng has quit IRC | 06:29 | |
*** sdake has quit IRC | 06:29 | |
*** shaohe_feng has joined #openstack-nova | 06:29 | |
*** armax has quit IRC | 06:30 | |
*** Daisy has quit IRC | 06:31 | |
*** ivase has joined #openstack-nova | 06:31 | |
*** andreas_s has joined #openstack-nova | 06:31 | |
*** Dinesh_Bhor has joined #openstack-nova | 06:31 | |
*** ivase_ has quit IRC | 06:32 | |
*** Daisy_ has quit IRC | 06:33 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Remove mox in tests/unit/objects/test_security_group https://review.openstack.org/307135 | 06:33 |
*** Daisy has joined #openstack-nova | 06:33 | |
*** ivase_ has joined #openstack-nova | 06:37 | |
*** coreywright has quit IRC | 06:37 | |
*** abalutoiu has joined #openstack-nova | 06:37 | |
*** ivase has quit IRC | 06:37 | |
*** gjayavelu has joined #openstack-nova | 06:38 | |
*** paul-carlton2 has joined #openstack-nova | 06:38 | |
*** sdake has joined #openstack-nova | 06:39 | |
*** Daisy has quit IRC | 06:39 | |
*** p01nt3r75 has quit IRC | 06:39 | |
*** liverpooler has joined #openstack-nova | 06:39 | |
*** shaohe_feng has quit IRC | 06:39 | |
*** Daisy has joined #openstack-nova | 06:39 | |
*** shaohe_feng has joined #openstack-nova | 06:40 | |
*** ivase has joined #openstack-nova | 06:43 | |
*** ivase_ has quit IRC | 06:43 | |
*** Daisy has quit IRC | 06:44 | |
*** Daisy has joined #openstack-nova | 06:44 | |
openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova: Transform instance.shutdown notifications https://review.openstack.org/329214 | 06:47 |
*** jed56 has joined #openstack-nova | 06:48 | |
*** ivase_ has joined #openstack-nova | 06:48 | |
*** winston-d_ has joined #openstack-nova | 06:49 | |
*** ivase has quit IRC | 06:49 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Example and body verification of os-quota-sets.inc https://review.openstack.org/338140 | 06:49 |
*** shaohe_feng has quit IRC | 06:49 | |
*** Daisy has quit IRC | 06:49 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Remove mox in tests/unit/objects/test_instance_info_cache https://review.openstack.org/307155 | 06:49 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Remove mox in tests/unit/objects/test_pci_device https://review.openstack.org/307615 | 06:50 |
*** shaohe_feng has joined #openstack-nova | 06:50 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Remove mox in tests/unit/objects/test_compute_node https://review.openstack.org/307625 | 06:50 |
*** sahid has joined #openstack-nova | 06:51 | |
*** Daisy has joined #openstack-nova | 06:51 | |
openstackgerrit | LisaLi proposed openstack/nova: Recover link of device_path when detaching encryptors https://review.openstack.org/338716 | 06:51 |
*** thorst has joined #openstack-nova | 06:52 | |
*** coreywright has joined #openstack-nova | 06:53 | |
*** ivase has joined #openstack-nova | 06:54 | |
*** sdake has quit IRC | 06:55 | |
*** ivase_ has quit IRC | 06:55 | |
*** sridharg has joined #openstack-nova | 06:55 | |
*** giri has joined #openstack-nova | 06:56 | |
*** mpavone has joined #openstack-nova | 06:56 | |
*** gjayavelu has quit IRC | 06:57 | |
*** lpetrut has quit IRC | 06:58 | |
*** thorst has quit IRC | 06:59 | |
*** shaohe_feng has quit IRC | 06:59 | |
*** shaohe_feng has joined #openstack-nova | 07:00 | |
*** ivase_ has joined #openstack-nova | 07:00 | |
*** ivase has quit IRC | 07:01 | |
*** tesseract- has joined #openstack-nova | 07:03 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: Added support for new block device format in vmops https://review.openstack.org/246299 | 07:04 |
*** ivase_ has quit IRC | 07:06 | |
*** code-R has joined #openstack-nova | 07:07 | |
*** code-R_ has quit IRC | 07:07 | |
*** ivase has joined #openstack-nova | 07:08 | |
openstackgerrit | Tuan proposed openstack/nova: Replace unicode with six.text_type https://review.openstack.org/338722 | 07:08 |
*** shaohe_feng has quit IRC | 07:10 | |
*** kevin_zh has joined #openstack-nova | 07:10 | |
*** shaohe_feng has joined #openstack-nova | 07:10 | |
*** ivase_ has joined #openstack-nova | 07:12 | |
*** ivase has quit IRC | 07:12 | |
*** paul-carlton2 has quit IRC | 07:14 | |
*** ivase has joined #openstack-nova | 07:17 | |
*** ivase_ has quit IRC | 07:18 | |
*** itamarl has joined #openstack-nova | 07:19 | |
*** shaohe_feng has quit IRC | 07:20 | |
*** sahid has quit IRC | 07:20 | |
*** shaohe_feng has joined #openstack-nova | 07:20 | |
*** chhavi_ has joined #openstack-nova | 07:21 | |
*** chhavi has quit IRC | 07:21 | |
*** ivase_ has joined #openstack-nova | 07:23 | |
*** sahid has joined #openstack-nova | 07:24 | |
*** ivase has quit IRC | 07:24 | |
*** code-R has quit IRC | 07:24 | |
*** omnipresent has joined #openstack-nova | 07:26 | |
*** paul-carlton2 has joined #openstack-nova | 07:26 | |
*** zenoway_ has joined #openstack-nova | 07:27 | |
gibi_ | mriedem_afk: checked your comment on reservation_id in the notification sample test, thanks for the suggestion, I will propose some follow up to refactor it | 07:28 |
*** ivase has joined #openstack-nova | 07:29 | |
openstackgerrit | javeme proposed openstack/nova: Check server_group_members quota as soon as possible https://review.openstack.org/337251 | 07:29 |
*** zhangjn has quit IRC | 07:29 | |
*** ivase_ has quit IRC | 07:30 | |
*** shaohe_feng has quit IRC | 07:30 | |
*** ljxiash has quit IRC | 07:30 | |
openstackgerrit | Arnaud Morin proposed openstack/nova: Add a small debug line to show selection location https://review.openstack.org/338736 | 07:30 |
*** shaohe_feng has joined #openstack-nova | 07:30 | |
*** omnipresent has quit IRC | 07:31 | |
*** ljxiash has joined #openstack-nova | 07:31 | |
*** zhangjn has joined #openstack-nova | 07:32 | |
*** jwcroppe has joined #openstack-nova | 07:32 | |
*** yamahata has quit IRC | 07:34 | |
*** ivase_ has joined #openstack-nova | 07:35 | |
*** ljxiash has quit IRC | 07:35 | |
*** ljxiash has joined #openstack-nova | 07:35 | |
*** ivase has quit IRC | 07:35 | |
*** ljxiash has quit IRC | 07:35 | |
*** ljxiash has joined #openstack-nova | 07:36 | |
*** jlanoux has joined #openstack-nova | 07:40 | |
*** shaohe_feng has quit IRC | 07:40 | |
*** ivase has joined #openstack-nova | 07:40 | |
*** ljxiash has quit IRC | 07:41 | |
*** shaohe_feng has joined #openstack-nova | 07:41 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata https://review.openstack.org/331996 | 07:41 |
*** ivase_ has quit IRC | 07:41 | |
openstackgerrit | Béla Vancsics proposed openstack/nova: Transform instance.shelve notifications https://review.openstack.org/332696 | 07:44 |
*** ivase_ has joined #openstack-nova | 07:46 | |
*** ivase has quit IRC | 07:47 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding https://review.openstack.org/217567 | 07:47 |
*** sahid has quit IRC | 07:48 | |
*** sahid has joined #openstack-nova | 07:48 | |
openstackgerrit | Tang Chen proposed openstack/nova: api-ref: Parameter verification for servers-actions.inc Part 1 https://review.openstack.org/338126 | 07:48 |
*** shaohe_feng has quit IRC | 07:51 | |
*** shaohe_feng has joined #openstack-nova | 07:51 | |
*** salv-orlando has quit IRC | 07:51 | |
*** salv-orlando has joined #openstack-nova | 07:52 | |
*** ivase has joined #openstack-nova | 07:52 | |
*** ljxiash has joined #openstack-nova | 07:53 | |
*** ivase_ has quit IRC | 07:53 | |
*** thorst has joined #openstack-nova | 07:55 | |
*** zenoway has joined #openstack-nova | 07:56 | |
*** mvk has joined #openstack-nova | 07:57 | |
*** ratailor is now known as ratailor|Lunch | 07:57 | |
*** zenoway_ has quit IRC | 07:57 | |
*** ljxiash has quit IRC | 07:57 | |
*** ivase has quit IRC | 07:58 | |
*** nkrinner_afk is now known as nkrinner | 07:58 | |
*** ivase has joined #openstack-nova | 07:58 | |
*** markus_z has joined #openstack-nova | 07:59 | |
*** pilgrimstack has joined #openstack-nova | 07:59 | |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-nova | 08:00 | |
*** nkrinner has quit IRC | 08:01 | |
*** shaohe_feng has quit IRC | 08:01 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Example and body verification of os-quota-sets.inc https://review.openstack.org/338140 | 08:01 |
*** paul-carlton2 has quit IRC | 08:02 | |
*** ljxiash has joined #openstack-nova | 08:02 | |
*** shaohe_feng has joined #openstack-nova | 08:02 | |
*** gongysh has joined #openstack-nova | 08:02 | |
*** thorst has quit IRC | 08:03 | |
*** ivase_ has joined #openstack-nova | 08:04 | |
openstackgerrit | John Hua proposed openstack/nova: XenAPI: device tagging https://review.openstack.org/333781 | 08:04 |
*** BobBall_AWOL is now known as BobBall | 08:04 | |
*** jwcroppe has quit IRC | 08:05 | |
*** ivase has quit IRC | 08:05 | |
BobBall | mikal / mriedem_afk: Got a spec for the 'context stuff' so I know what you were talking about? :) | 08:06 |
*** nkrinner has joined #openstack-nova | 08:06 | |
*** tyrola has joined #openstack-nova | 08:09 | |
*** shyama has joined #openstack-nova | 08:09 | |
*** fragatina has quit IRC | 08:09 | |
*** tyrola has quit IRC | 08:10 | |
*** ivase has joined #openstack-nova | 08:10 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/303345 | 08:10 |
*** ivase_ has quit IRC | 08:10 | |
openstackgerrit | John Hua proposed openstack/nova: XenAPI: device tagging https://review.openstack.org/333781 | 08:10 |
*** tyrola has joined #openstack-nova | 08:10 | |
*** shaohe_feng has quit IRC | 08:11 | |
*** shaohe_feng has joined #openstack-nova | 08:11 | |
*** nkrinner has quit IRC | 08:12 | |
*** ducttape_ has joined #openstack-nova | 08:12 | |
*** DaiDV has joined #openstack-nova | 08:15 | |
*** tonytan4ever has joined #openstack-nova | 08:15 | |
*** ivase_ has joined #openstack-nova | 08:16 | |
*** ivase has quit IRC | 08:16 | |
*** ducttape_ has quit IRC | 08:17 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Complete verification of os-instance-actions.inc https://review.openstack.org/338753 | 08:18 |
*** openstackgerrit has quit IRC | 08:18 | |
*** openstackgerrit has joined #openstack-nova | 08:18 | |
BobBall | artom: Could you review https://review.openstack.org/#/c/333781 please? Particularly thinking about the use of 'path' | 08:19 |
*** derekh has joined #openstack-nova | 08:19 | |
BobBall | (and the fact that we have up to 4 possible addresses depending on the guest configurating...) | 08:20 |
*** tonytan4ever has quit IRC | 08:20 | |
*** lpetrut has joined #openstack-nova | 08:21 | |
*** ivase has joined #openstack-nova | 08:21 | |
*** shaohe_feng has quit IRC | 08:21 | |
*** shaohe_feng has joined #openstack-nova | 08:22 | |
*** ivase_ has quit IRC | 08:22 | |
*** nkrinner has joined #openstack-nova | 08:26 | |
*** ivase_ has joined #openstack-nova | 08:27 | |
*** ivase has quit IRC | 08:27 | |
*** paul-carlton2 has joined #openstack-nova | 08:28 | |
*** pcaruana has joined #openstack-nova | 08:30 | |
*** shaohe_feng has quit IRC | 08:32 | |
*** ivase has joined #openstack-nova | 08:33 | |
*** ivase_ has quit IRC | 08:33 | |
*** Daisy_ has joined #openstack-nova | 08:34 | |
*** shaohe_feng has joined #openstack-nova | 08:35 | |
*** ociuhandu has joined #openstack-nova | 08:35 | |
*** jwcroppe has joined #openstack-nova | 08:35 | |
*** jwcroppe has quit IRC | 08:37 | |
*** Daisy has quit IRC | 08:37 | |
openstackgerrit | Alex Xu proposed openstack/nova: API: catch InstanceNotReady exception. https://review.openstack.org/338034 | 08:37 |
*** paul-carlton2 has quit IRC | 08:38 | |
*** sambetts|afk is now known as sambetts | 08:38 | |
*** paul-carlton2 has joined #openstack-nova | 08:38 | |
*** ivase_ has joined #openstack-nova | 08:38 | |
*** Daisy_ has quit IRC | 08:38 | |
*** ivase has quit IRC | 08:39 | |
openstackgerrit | Yingxin Cheng proposed openstack/nova: Amend reqired policy in numa topology filter https://review.openstack.org/338632 | 08:39 |
*** Daisy has joined #openstack-nova | 08:40 | |
openstackgerrit | John Hua proposed openstack/nova: XenAPI: device tagging https://review.openstack.org/333781 | 08:40 |
*** ratailor|Lunch is now known as ratailor | 08:41 | |
*** jwcroppe has joined #openstack-nova | 08:41 | |
*** shaohe_feng has quit IRC | 08:42 | |
*** shaohe_feng has joined #openstack-nova | 08:42 | |
openstackgerrit | Yingxin Cheng proposed openstack/nova: Amend reqired policy in numa topology filter https://review.openstack.org/338632 | 08:43 |
*** ivase_ has quit IRC | 08:45 | |
*** ivase has joined #openstack-nova | 08:45 | |
*** chhavi_ has quit IRC | 08:46 | |
*** Daisy has quit IRC | 08:48 | |
*** karthiks has quit IRC | 08:48 | |
*** Daisy has joined #openstack-nova | 08:48 | |
*** danpb has joined #openstack-nova | 08:49 | |
openstackgerrit | Dao Cong Tien proposed openstack/nova: Ironic Driver: override get_serial_console() https://review.openstack.org/328157 | 08:49 |
*** chhavi_ has joined #openstack-nova | 08:49 | |
*** karthiks has joined #openstack-nova | 08:50 | |
openstackgerrit | Arnaud Morin proposed openstack/nova: Add a small debug line to show selection location https://review.openstack.org/338736 | 08:50 |
*** ivase_ has joined #openstack-nova | 08:50 | |
*** eglynn has joined #openstack-nova | 08:50 | |
*** dingboopt has joined #openstack-nova | 08:51 | |
*** ivase has quit IRC | 08:51 | |
*** tyrola has quit IRC | 08:51 | |
*** shaohe_feng has quit IRC | 08:52 | |
*** sudipto has quit IRC | 08:53 | |
pkoniszewski | danpb: hey, are u there? | 08:53 |
*** shaohe_feng has joined #openstack-nova | 08:53 | |
openstackgerrit | Alex Xu proposed openstack/nova: api-ref: Complete all the verifications of remote consoles https://review.openstack.org/338051 | 08:53 |
*** sameo_ has joined #openstack-nova | 08:54 | |
*** PaulMurray has joined #openstack-nova | 08:54 | |
danpb | pkoniszewski: not yet, i'm a figment of your imagination until i've finished catching up with email :-) | 08:55 |
*** ivase has joined #openstack-nova | 08:56 | |
PaulMurray | danpb, FYI - hemna said he would look at https://bugs.launchpad.net/nova/+bug/1524898 | 08:56 |
openstack | Launchpad bug 1524898 in OpenStack Compute (nova) "Volume based live migration aborted unexpectedly" [High,Confirmed] | 08:56 |
*** ivase_ has quit IRC | 08:56 | |
PaulMurray | danpb, but he is just back from holiday, so I'll check back in with him at some point | 08:57 |
*** Daisy has quit IRC | 08:58 | |
*** tyrola has joined #openstack-nova | 09:00 | |
*** thorst has joined #openstack-nova | 09:01 | |
*** YifanZeng has quit IRC | 09:01 | |
*** ivase_ has joined #openstack-nova | 09:02 | |
*** YifanZeng has joined #openstack-nova | 09:02 | |
*** ivase has quit IRC | 09:02 | |
*** shaohe_feng has quit IRC | 09:02 | |
*** salv-orlando has quit IRC | 09:03 | |
*** shaohe_feng has joined #openstack-nova | 09:03 | |
*** claudiub has quit IRC | 09:04 | |
*** jwcroppe has quit IRC | 09:04 | |
*** sudipto has joined #openstack-nova | 09:06 | |
*** Daisy has joined #openstack-nova | 09:06 | |
*** ivase has joined #openstack-nova | 09:08 | |
*** cheneydc has joined #openstack-nova | 09:08 | |
*** ivase_ has quit IRC | 09:08 | |
*** thorst has quit IRC | 09:09 | |
*** roeyc has joined #openstack-nova | 09:09 | |
pkoniszewski | danpb: ping me please when you have few minutes, i found out that we are using block-migration for volume-backed VMs with local disks and i wonder how bad it is (and if it is bad at all) | 09:11 |
*** sudipto has quit IRC | 09:12 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: Verify "needs:check_deprecation_status" for serial_console.py https://review.openstack.org/338780 | 09:12 |
*** shaohe_feng has quit IRC | 09:13 | |
*** ducttape_ has joined #openstack-nova | 09:13 | |
*** shaohe_feng has joined #openstack-nova | 09:14 | |
*** ivase has quit IRC | 09:14 | |
*** ivase_ has joined #openstack-nova | 09:14 | |
*** ociuhandu has quit IRC | 09:14 | |
*** sur_ has joined #openstack-nova | 09:14 | |
sur_ | hii all, Is there any documentation for "openstack installation on ubuntu 15.01" | 09:14 |
sur_ | pls help me | 09:15 |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: [libvirt] Live migration fails when config_drive_format=iso9660 https://review.openstack.org/234659 | 09:16 |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: TEST - DO NOT MERGE https://review.openstack.org/337810 | 09:16 |
*** ducttape_ has quit IRC | 09:17 | |
*** tyrola has quit IRC | 09:18 | |
*** sur_ has quit IRC | 09:19 | |
*** ivase has joined #openstack-nova | 09:19 | |
*** kaisers1 has joined #openstack-nova | 09:19 | |
openstackgerrit | Tina Kevin proposed openstack/nova: Instance can not resize ephemeral disk https://review.openstack.org/320759 | 09:19 |
*** tyrola has joined #openstack-nova | 09:19 | |
openstackgerrit | David Edery proposed openstack/nova: Fix failed snapshot on VMs with SRIOV ports https://review.openstack.org/287515 | 09:20 |
*** ivase_ has quit IRC | 09:20 | |
*** chhavi_ has quit IRC | 09:22 | |
*** fragatina has joined #openstack-nova | 09:22 | |
*** shaohe_feng has quit IRC | 09:23 | |
*** shaohe_feng has joined #openstack-nova | 09:23 | |
*** acabot has joined #openstack-nova | 09:24 | |
*** ivase_ has joined #openstack-nova | 09:25 | |
*** ivase has quit IRC | 09:25 | |
*** sudipto has joined #openstack-nova | 09:27 | |
*** huanxie has quit IRC | 09:30 | |
*** ivase has joined #openstack-nova | 09:31 | |
johnthetubaguy | alex_xu: oomichi: I think the worry was patches get in that change the max microversion while the whole chain is merging in the gate. | 09:31 |
*** tonytan4ever has joined #openstack-nova | 09:31 | |
*** ivase_ has quit IRC | 09:32 | |
*** oss_xzdong has quit IRC | 09:32 | |
*** shaohe_feng has quit IRC | 09:33 | |
*** shaohe_feng has joined #openstack-nova | 09:34 | |
openstackgerrit | javeme proposed openstack/nova: Check server_group_members quota as soon as possible https://review.openstack.org/337251 | 09:34 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Stop accepting imageRef as non UUID https://review.openstack.org/338802 | 09:35 |
*** tonytan4ever has quit IRC | 09:35 | |
*** ivase_ has joined #openstack-nova | 09:36 | |
*** ivase has quit IRC | 09:37 | |
*** cheneydc has quit IRC | 09:40 | |
markus_z | gmann: You've done a lot of functional tests, right? I'd like to have your feedback on my first one: https://review.openstack.org/#/c/338416/ | 09:41 |
markus_z | I'm not entirely sure if that's how it is supposed to be. | 09:41 |
*** ivase has joined #openstack-nova | 09:42 | |
*** ivase_ has quit IRC | 09:43 | |
*** shaohe_feng has quit IRC | 09:43 | |
*** shaohe_feng has joined #openstack-nova | 09:44 | |
*** Daisy has quit IRC | 09:44 | |
johnthetubaguy | alex_xu: should we have a microversion bump to advertise this one? https://review.openstack.org/#/c/334747/6 | 09:45 |
*** Daisy has joined #openstack-nova | 09:45 | |
kashyap | markus_z: Nice catch - that bug, you seem to be the first to test w/o VNC w/ a serial console, then :-) | 09:47 |
markus_z | sfinucan: That's the patch which makes the burndown chart working: http://paste.openstack.org/show/526868/ | 09:47 |
*** ljxiash has quit IRC | 09:47 | |
*** ljxiash has joined #openstack-nova | 09:48 | |
markus_z | kashyap: yeah, it's a funny IBM system z thing. Unfortunately our CI is not yet fully ready (95% done), it would have detected it. | 09:48 |
*** ivase_ has joined #openstack-nova | 09:48 | |
*** ivase has quit IRC | 09:49 | |
*** Daisy has quit IRC | 09:49 | |
markus_z | sfinucan: I'm going to push that on my server in the afternoon (some meetings today). Thanks a lot for the preparation! | 09:49 |
paul-carlton2 | johnthetubaguy, what is Sylvain Bauza irc name and is he around today? | 09:50 |
johnthetubaguy | paul-carlton2: you want bauzas | 09:50 |
markus_z | paul-carlton2: bauzas :) | 09:50 |
sfinucan | markus_z: Excellent. Let me know when it's up :) | 09:50 |
*** Daisy has joined #openstack-nova | 09:50 | |
bauzas | mmm ? :) | 09:50 |
paul-carlton2 | bauzas, hi | 09:51 |
danpb | pkoniszewski: ok, what's up ? | 09:51 |
paul-carlton2 | johnthetubaguy, markus_z ta | 09:51 |
* bauzas a bit off for prepping the midcycle, but okay | 09:51 | |
openstackgerrit | Tina Kevin proposed openstack/nova: Instance can not resize ephemeral disk https://review.openstack.org/320759 | 09:51 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding https://review.openstack.org/217567 | 09:51 |
markus_z | paul-carlton2: http://www.openstack.org/community/members/ is your "facebook" of OpenStack | 09:51 |
paul-carlton2 | bauzas, I've been asked to backport the fix that makes live migration honour anti-affinity policy to our mitaka release | 09:52 |
*** gongysh has quit IRC | 09:52 | |
johnthetubaguy | markus_z: ah yes, my PR didn't yet catch active reviews (and probably screwed up the formatting) | 09:52 |
bauzas | markus_z: oh gosh http://www.openstack.org/community/members/profile/8407 | 09:52 |
*** ljxiash has quit IRC | 09:52 | |
bauzas | paul-carlton2: mmm, okay | 09:53 |
bauzas | paul-carlton2: AFAIR, it was merged by mitaka | 09:53 |
paul-carlton2 | I assume bp check-destination-on-migrations-newton did this fix? | 09:53 |
paul-carlton2 | so it should work in mitaka? | 09:53 |
bauzas | paul-carlton2: so, we merged a series by mitaka | 09:54 |
*** shaohe_feng has quit IRC | 09:54 | |
johnthetubaguy | oh did we do live-migrate first, I couldn't remember the order | 09:54 |
bauzas | paul-carlton2: what's merged in mitaka was related to look at the RequesSpec persistent | 09:54 |
*** ivase has joined #openstack-nova | 09:54 | |
bauzas | paul-carlton2: and then, for newton, we only added the API modifications | 09:54 |
*** ivase_ has quit IRC | 09:54 | |
*** shyama has quit IRC | 09:55 | |
*** shaohe_feng has joined #openstack-nova | 09:55 | |
paul-carlton2 | so might be a reasonably doable backport | 09:55 |
*** Daisy has quit IRC | 09:55 | |
*** fishcried has joined #openstack-nova | 09:55 | |
pkoniszewski | paul-carlton2: it is supported even in Liberty | 09:55 |
bauzas | paul-carlton2: https://review.openstack.org/#/q/topic:bp/check-destination-on-migrations+is:merged | 09:55 |
pkoniszewski | paul-carlton2: i mean, since Liberty live migration honours affinity/anti-affinity policies | 09:56 |
bauzas | paul-carlton2: vs. https://review.openstack.org/#/q/topic:bp/check-destination-on-migrations-newton+is:merged | 09:56 |
*** Daisy has joined #openstack-nova | 09:56 | |
bauzas | paul-carlton2: so, IIUC you, we merged https://review.openstack.org/#/c/277800/ for mitaka | 09:57 |
*** klkumar has joined #openstack-nova | 09:57 | |
bauzas | Tags 13.0.0, 13.0.0.0b3, 13.0.0.0rc1, 13.0.0.0rc2, 13.0.0.0rc3, 13.1.0, 14.0.0.0b1 | 09:57 |
bauzas | which means that above patch was merged by Mitaka-3 | 09:58 |
pkoniszewski | danpb: so, in mitaka we changed LM api a bit, so that nova can calculate whether it should use live migration or block migration | 09:58 |
pkoniszewski | danpb: but because of this check https://github.com/openstack/nova/blob/660ecaee66ccab895b282c2ed45c95c809ad6833/nova/virt/libvirt/driver.py#L5592 | 09:58 |
pkoniszewski | danpb: nova chooses block live migration for volume-backed VMs with local disks | 09:58 |
danpb | sure, that's right - any time you've local read-write disks we need to block migrate | 09:58 |
bauzas | paul-carlton2: is that answering your question ? you don't need to backport to mitaka, it's already in mitaka | 09:59 |
*** fishcried has quit IRC | 09:59 | |
pkoniszewski | danpb: i would say that from nova perspective it works perfectly fine, it even helps to live migrate volume-backed VMs with, .e.g, config drive | 09:59 |
pkoniszewski | danpb: but not sure how does it look like from libvirt perspective | 09:59 |
bauzas | paul-carlton2: I mean, the fact that we honor scheduler hints for live-migration calls if and only if the operator doesn't provide a destination host | 09:59 |
pkoniszewski | there is this selective disk migration thing which makes that it works, if it is fine from libvirt perspective then its even better for nova | 09:59 |
paul-carlton2 | bauzas, Thanks, let me check again I trusted the user that it did not work in the Mitaka version of our product, just checked it worked in Newton devstack | 09:59 |
paul-carlton2 | thanks | 10:00 |
bauzas | k, no worries | 10:00 |
*** gongysh has joined #openstack-nova | 10:00 | |
*** ivase has quit IRC | 10:00 | |
*** ivase_ has joined #openstack-nova | 10:00 | |
bauzas | paul-carlton2: what we changed in newton is that we changed the UX behavious where we verify anytime the scheduler even if the user provides a destination flag to the request | 10:00 |
*** Daisy has quit IRC | 10:01 | |
bauzas | paul-carlton2: for the bug to be valid, you need to verify with your reporter that their doesn't provided a destination flag | 10:01 |
paul-carlton2 | bauzas, Thanks, will do | 10:01 |
*** kevin_zh has quit IRC | 10:01 | |
danpb | pkoniszewski: i'm not sure i'm understanding what the problem is ? | 10:01 |
bauzas | oh gosh, my english | 10:01 |
bauzas | that they didn't provided* | 10:01 |
danpb | whats the scenario you think is broken | 10:01 |
*** Daisy has joined #openstack-nova | 10:02 | |
* bauzas is always confused by your grammar and tenses | 10:02 | |
*** shaohe_feng has quit IRC | 10:04 | |
*** shaohe_feng has joined #openstack-nova | 10:05 | |
*** ivase has joined #openstack-nova | 10:05 | |
*** Daisy has quit IRC | 10:07 | |
*** ivase_ has quit IRC | 10:07 | |
*** thorst has joined #openstack-nova | 10:07 | |
*** daemontool has joined #openstack-nova | 10:07 | |
*** Daisy has joined #openstack-nova | 10:07 | |
*** fragatina has quit IRC | 10:07 | |
*** giri has quit IRC | 10:08 | |
*** gcb has quit IRC | 10:08 | |
*** hoangcx has quit IRC | 10:09 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/303345 | 10:10 |
*** EinstCrazy has quit IRC | 10:11 | |
*** ivase_ has joined #openstack-nova | 10:11 | |
*** pacoblox has joined #openstack-nova | 10:12 | |
*** ivase has quit IRC | 10:12 | |
*** Daisy has quit IRC | 10:12 | |
*** Daisy has joined #openstack-nova | 10:13 | |
*** qeelee has quit IRC | 10:13 | |
*** shhjwang has quit IRC | 10:13 | |
*** ducttape_ has joined #openstack-nova | 10:13 | |
*** DaiDV has quit IRC | 10:14 | |
*** thorst has quit IRC | 10:14 | |
*** shaohe_feng has quit IRC | 10:14 | |
mdbooth | Heh, test_spawn_with_config_drive doesn't specify a config drive in its setup. It only passes because it doesn't test that one was created :) | 10:14 |
*** pacoblox has quit IRC | 10:15 | |
*** shaohe_feng has joined #openstack-nova | 10:15 | |
gibi_ | johnthetubaguy: hi! this patch needs a re-approve https://review.openstack.org/#/c/332696/ | 10:15 |
johnthetubaguy | gibi_: ah, sweet. | 10:17 |
gibi_ | johnthetubaguy: as well as https://review.openstack.org/#/c/329141/10 | 10:17 |
*** ivase has joined #openstack-nova | 10:17 | |
*** Daisy has quit IRC | 10:17 | |
*** ivase_ has quit IRC | 10:17 | |
lyarwood | mdbooth: while you're talking about tests, are you manually running things or are you launching them from within pycharms? | 10:18 |
mdbooth | lyarwood: I always run them manually. | 10:18 |
*** ducttape_ has quit IRC | 10:18 | |
mdbooth | Is it even possible/desirable to do it from pycharms? | 10:18 |
* mdbooth hasn't bothered looking | 10:18 | |
*** Daisy has joined #openstack-nova | 10:18 | |
paul-carlton2 | lyarwood, what version of pycharms do you use | 10:18 |
gibi_ | johnthetubaguy: and this as well https://review.openstack.org/#/c/329255/11 :) | 10:19 |
lyarwood | mdbooth: yeah same | 10:19 |
* mdbooth views pycharms as vim with extra python smarts | 10:19 | |
lyarwood | paul-carlton2: erm, let me check, the latest I think | 10:19 |
paul-carlton2 | am I right that tox support was only added in 2016 version? | 10:19 |
mdbooth | i.e. refactor and definition lookup | 10:19 |
lyarwood | paul-carlton2: 2016.1 | 10:19 |
gibi_ | johnthetubaguy: thanks! | 10:19 |
mdbooth | I'm sure I use about 1% of its functionality | 10:19 |
paul-carlton2 | ta | 10:19 |
lyarwood | paul-carlton2: no idea but I'll take a look | 10:19 |
* lyarwood only just switched to pycharms from vim+jedi-vim etc | 10:20 | |
mdbooth | lyarwood: pycharms vim mode is pretty good | 10:20 |
johnthetubaguy | oooh, there is a vim mode, interesting... | 10:21 |
mdbooth | Does all the basics at least very well | 10:21 |
* mdbooth misses 'gq' in pycharms | 10:21 | |
mdbooth | johnthetubaguy: Yeah, you don't have to retrain your fingers :) | 10:21 |
johnthetubaguy | very smart idea they had there, I should maybe reconsider not using that | 10:21 |
*** salv-orlando has joined #openstack-nova | 10:22 | |
*** Daisy has quit IRC | 10:23 | |
*** ivase_ has joined #openstack-nova | 10:23 | |
*** ivase has quit IRC | 10:23 | |
*** wangqun has quit IRC | 10:23 | |
*** Daisy has joined #openstack-nova | 10:24 | |
*** ljxiash has joined #openstack-nova | 10:24 | |
*** shaohe_feng has quit IRC | 10:24 | |
*** tbachman has joined #openstack-nova | 10:25 | |
lyarwood | mdbooth: ah thanks for the reminder | 10:26 |
*** jwcroppe has joined #openstack-nova | 10:26 | |
*** gongysh has quit IRC | 10:26 | |
*** jwcroppe has quit IRC | 10:27 | |
*** shaohe_feng has joined #openstack-nova | 10:27 | |
*** fragatina has joined #openstack-nova | 10:27 | |
*** ivase has joined #openstack-nova | 10:28 | |
*** Daisy has quit IRC | 10:29 | |
*** ljxiash has quit IRC | 10:29 | |
*** ivase_ has quit IRC | 10:29 | |
*** tbachman has quit IRC | 10:30 | |
*** ivase_ has joined #openstack-nova | 10:34 | |
*** shaohe_feng has quit IRC | 10:35 | |
*** Daisy has joined #openstack-nova | 10:35 | |
*** ivase has quit IRC | 10:35 | |
*** shaohe_feng has joined #openstack-nova | 10:36 | |
*** rodrigods has quit IRC | 10:36 | |
*** rodrigods has joined #openstack-nova | 10:36 | |
*** ljxiash has joined #openstack-nova | 10:39 | |
*** Daisy has quit IRC | 10:40 | |
*** ivase has joined #openstack-nova | 10:40 | |
*** ivase_ has quit IRC | 10:40 | |
*** salv-orl_ has joined #openstack-nova | 10:43 | |
*** fragatina has quit IRC | 10:44 | |
*** shaohe_feng has quit IRC | 10:45 | |
*** shaohe_feng has joined #openstack-nova | 10:46 | |
*** ivase_ has joined #openstack-nova | 10:46 | |
*** Daisy has joined #openstack-nova | 10:46 | |
*** salv-orlando has quit IRC | 10:46 | |
*** qeelee has joined #openstack-nova | 10:46 | |
*** qeelee has quit IRC | 10:46 | |
*** hoangcx has joined #openstack-nova | 10:46 | |
*** ivase has quit IRC | 10:46 | |
* mdbooth just created a git alias for this command I use a lot: git merge-base --fork-point master | 10:47 | |
mdbooth | It gives you the commit at which you forked from master | 10:47 |
*** moshele has joined #openstack-nova | 10:48 | |
mdbooth | Very useful for interactive rebases | 10:48 |
bauzas | mdbooth: not sure I see the usefulness but okay :p | 10:48 |
bauzas | given you rebase your series against *something* you know | 10:48 |
mdbooth | If all you want to do is re-order some patches without a rebase | 10:48 |
mdbooth | for eg | 10:49 |
sfinucan | mdbooth: Didn't know about the '--fork-point' arg. Nifty! | 10:49 |
mdbooth | I guess it makes more sense when your series is over 20 patches long :) | 10:49 |
bauzas | mdbooth: ah okay, well, in general, I tend to do that differently | 10:49 |
mdbooth | In that case it means 'the first patch in my series' | 10:49 |
bauzas | mdbooth: like saying, my local master branch is only updated when I want to | 10:50 |
bauzas | mdbooth: but if I need to pull the latest, then I totally need to rebase on it | 10:50 |
bauzas | mdbooth: and you know that git review does a rebase against the gerrit remote anyway, right? | 10:50 |
mdbooth | bauzas: Not if you disable it, it doesn't ;) | 10:50 |
*** Daisy has quit IRC | 10:50 | |
bauzas | mdbooth: why would you do that ? | 10:51 |
* mdbooth likes to do 1 thing at a time | 10:51 | |
bauzas | mdbooth: sure, you would -R | 10:51 |
bauzas | mdbooth: but that's something I don't see good | 10:51 |
mdbooth | Couple of reasons, firstly for review, it makes it possible to see what changed between versions. | 10:51 |
bauzas | mdbooth: for that, I have a blogpost :) | 10:51 |
mdbooth | Secondly, because it means what I push isn't what I developed | 10:52 |
bauzas | mdbooth: and also, there is a git review subcommand :) | 10:52 |
*** ivase has joined #openstack-nova | 10:52 | |
*** Daisy has joined #openstack-nova | 10:52 | |
* mdbooth doesn't like implicit rebase, pretty much ever | 10:52 | |
mdbooth | If I'm going to rebase, I'll rebase | 10:52 |
*** ivase_ has quit IRC | 10:53 | |
openstackgerrit | Chen Fan proposed openstack/nova: api-ref: body and example verification for os-hypervisor.inc https://review.openstack.org/338053 | 10:54 |
kashyap | mdbooth: The "--fork-point" tip is nice. Heard it first time. | 10:54 |
bauzas | mdbooth: so, you explicitely disabled git-review rebases in your config ? woah. | 10:55 |
bauzas | mdbooth: I can see things other way | 10:55 |
*** shaohe_feng has quit IRC | 10:55 | |
*** claudiub has joined #openstack-nova | 10:55 | |
bauzas | mdbooth: if I'm taking code I didn't written, then it's a good opportunity to look at it and understand what it impacts my own contrib | 10:55 |
bauzas | just silently pushing code without taking care of rebases just means you loose the ability to understand why Jenkins does -1 your change | 10:56 |
*** shaohe_feng has joined #openstack-nova | 10:56 | |
bauzas | but anyway | 10:56 |
*** Daisy has quit IRC | 10:56 | |
bauzas | it's not Friday, I don't want to troll | 10:56 |
bauzas | ...and I use Atom :p | 10:57 |
danpb | mdbooth: oh, that's very nice alias when you have multiple branches, and one branch is based off another branch, instead of off master | 10:57 |
mdbooth | danpb: That too | 10:57 |
*** ivase_ has joined #openstack-nova | 10:58 | |
*** rtheis has joined #openstack-nova | 10:58 | |
*** jwcroppe has joined #openstack-nova | 10:58 | |
mdbooth | You have to specify the branch you want to find the fork-point from explicitly, though | 10:58 |
*** ivase has quit IRC | 10:58 | |
danpb | oh true, i guess that's not actually any easier than just git rebase branchname | 10:59 |
*** Guest12760 has quit IRC | 10:59 | |
mdbooth | danpb: How about 'find me the fork-point from the tracking branch' | 11:00 |
mdbooth | I'll bet you could write that | 11:01 |
*** sree__ has joined #openstack-nova | 11:01 | |
mdbooth | s/you could/it's not hard to/ | 11:01 |
*** f10d4 has quit IRC | 11:03 | |
clarkb | bauzas: git review -R is not required as it will only rebase if conflicts exist | 11:03 |
clarkb | mdbooth: ^ | 11:04 |
*** ivase has joined #openstack-nova | 11:04 | |
*** salv-orlando has joined #openstack-nova | 11:04 | |
bauzas | clarkb: you mean that git-review doesn't automatically rebase ? | 11:04 |
clarkb | in hoch case you will know because rebase yells at you. it is all very explicit | 11:04 |
bauzas | clarkb: I thought it was automatic | 11:04 |
*** ivase_ has quit IRC | 11:04 | |
*** salv-orlando has quit IRC | 11:04 | |
mdbooth | clarkb: I normally wait til gerrit tells me about it, tbh | 11:04 |
bauzas | clarkb: that's a good thing to know | 11:04 |
mdbooth | Then I find some time to fix it | 11:04 |
clarkb | bauzas: no thats not quite what I mean either :) it does auto rebase but it resets head if the rebase is clean | 11:05 |
bauzas | ooooh ok | 11:05 |
bauzas | just a check | 11:05 |
mdbooth | clarkb: That's pretty nice, actually | 11:05 |
clarkb | the effect is to push your code exactly as is unless it conflicts | 11:05 |
mdbooth | clarkb: That wasn't always the case, was it? | 11:05 |
*** shaohe_feng has quit IRC | 11:05 | |
clarkb | mdbooth: no, but its been that wy for years now | 11:05 |
bauzas | clarkb: that's excellent, indeed | 11:06 |
mdbooth | clarkb: orly? I've hit the messy version compare thing. Maybe I've been around more years :) | 11:06 |
*** shaohe_feng has joined #openstack-nova | 11:06 | |
mdbooth | Anyway, that's great | 11:06 |
*** thorst has joined #openstack-nova | 11:06 | |
clarkb | mdbooth: or you use your ancient distro install of git review or something | 11:06 |
bauzas | anyway, we run our tests against the latest master | 11:07 |
mdbooth | clarkb: Hah. Yeah, I used the one in Fedora. | 11:07 |
*** salv-orl_ has quit IRC | 11:07 | |
bauzas | so, that's why I don't really understand why you need to figure out which particular SHA1 was the top of your local branch | 11:07 |
clarkb | in any case use of -R shpuld only be necessary if you want to push changes that cannot merge because they conflict with the target branch | 11:07 |
mdbooth | clarkb: Where do the cool kids get git-review from? | 11:07 |
bauzas | pip | 11:08 |
bauzas | (in my case) | 11:08 |
clarkb | yes pypi/pip | 11:08 |
mdbooth | Weird | 11:08 |
*** Daisy has joined #openstack-nova | 11:08 | |
* mdbooth would never think to look for a git extension in pip | 11:08 | |
*** sudipto has quit IRC | 11:09 | |
*** ivase_ has joined #openstack-nova | 11:09 | |
edand | apt-get install git-review | 11:09 |
bauzas | then you're stuck with your distro | 11:10 |
*** ivase has quit IRC | 11:10 | |
clarkb | at this point current distro releases should have fine git review versions because git review is fairly static now | 11:11 |
*** efoley has joined #openstack-nova | 11:12 | |
*** Daisy has quit IRC | 11:13 | |
*** ducttape_ has joined #openstack-nova | 11:14 | |
*** ivase has joined #openstack-nova | 11:15 | |
*** f10d4 has joined #openstack-nova | 11:16 | |
*** shaohe_feng has quit IRC | 11:16 | |
*** ivase_ has quit IRC | 11:16 | |
*** shaohe_feng has joined #openstack-nova | 11:16 | |
*** ducttape_ has quit IRC | 11:19 | |
*** kevin_zh has joined #openstack-nova | 11:19 | |
*** Daisy has joined #openstack-nova | 11:20 | |
*** bvanhav has joined #openstack-nova | 11:20 | |
*** moshele has quit IRC | 11:20 | |
*** ivase_ has joined #openstack-nova | 11:21 | |
*** ivase has quit IRC | 11:21 | |
*** Daisy has quit IRC | 11:24 | |
*** Daisy has joined #openstack-nova | 11:25 | |
*** kevin_zh has quit IRC | 11:26 | |
*** shaohe_feng has quit IRC | 11:26 | |
*** ivase has joined #openstack-nova | 11:27 | |
*** shaohe_feng has joined #openstack-nova | 11:27 | |
*** ivase_ has quit IRC | 11:27 | |
*** kevin_zh has joined #openstack-nova | 11:27 | |
*** ayoung has quit IRC | 11:27 | |
tdurakov | alex_xu, alaski, hi folks, are you around? | 11:28 |
*** f10d4 has quit IRC | 11:28 | |
*** Daisy has quit IRC | 11:30 | |
*** jwcroppe has quit IRC | 11:30 | |
*** Daisy has joined #openstack-nova | 11:31 | |
*** GB21 has joined #openstack-nova | 11:32 | |
*** ivase_ has joined #openstack-nova | 11:33 | |
*** ivase has quit IRC | 11:33 | |
*** roeyc has quit IRC | 11:33 | |
*** Daisy has quit IRC | 11:35 | |
*** ociuhandu has joined #openstack-nova | 11:35 | |
*** shaohe_feng has quit IRC | 11:36 | |
*** Daisy has joined #openstack-nova | 11:36 | |
*** tbachman has joined #openstack-nova | 11:37 | |
*** shaohe_feng has joined #openstack-nova | 11:37 | |
*** ivase has joined #openstack-nova | 11:38 | |
*** ivase_ has quit IRC | 11:39 | |
*** ayoung has joined #openstack-nova | 11:39 | |
*** EinstCrazy has joined #openstack-nova | 11:40 | |
*** Daisy has quit IRC | 11:41 | |
*** Daisy has joined #openstack-nova | 11:42 | |
*** f10d4 has joined #openstack-nova | 11:42 | |
*** kevin_zh has quit IRC | 11:43 | |
*** ivase_ has joined #openstack-nova | 11:44 | |
*** ivase has quit IRC | 11:45 | |
*** thorst_ has joined #openstack-nova | 11:45 | |
*** shaohe_feng has quit IRC | 11:46 | |
*** Daisy has quit IRC | 11:47 | |
*** shaohe_feng has joined #openstack-nova | 11:47 | |
*** cdelatte has joined #openstack-nova | 11:48 | |
*** ayoung has quit IRC | 11:48 | |
*** kevin_zh has joined #openstack-nova | 11:48 | |
*** thorst has quit IRC | 11:49 | |
*** jwcroppe has joined #openstack-nova | 11:49 | |
*** ivase has joined #openstack-nova | 11:50 | |
*** gszasz has joined #openstack-nova | 11:50 | |
*** ivase_ has quit IRC | 11:51 | |
*** kevin_zh has quit IRC | 11:51 | |
*** kevin_zh has joined #openstack-nova | 11:51 | |
*** bharathk has quit IRC | 11:51 | |
*** jwcroppe has quit IRC | 11:54 | |
openstackgerrit | javeme proposed openstack/nova: Check server_group_members quota as soon as possible https://review.openstack.org/337251 | 11:54 |
*** rfolco_ has joined #openstack-nova | 11:55 | |
*** ivase_ has joined #openstack-nova | 11:55 | |
*** tbachman has quit IRC | 11:56 | |
*** tbachman_ has joined #openstack-nova | 11:56 | |
*** ivase has quit IRC | 11:56 | |
*** shaohe_feng has quit IRC | 11:57 | |
*** rook has joined #openstack-nova | 11:58 | |
*** Daisy has joined #openstack-nova | 11:59 | |
*** f10d4 has quit IRC | 11:59 | |
*** f10d4 has joined #openstack-nova | 12:00 | |
*** shaohe_feng has joined #openstack-nova | 12:00 | |
*** claudiub has quit IRC | 12:00 | |
*** ivase has joined #openstack-nova | 12:02 | |
*** ivase_ has quit IRC | 12:02 | |
*** thorst_ is now known as thorst | 12:02 | |
*** ducttape_ has joined #openstack-nova | 12:03 | |
*** Daisy has quit IRC | 12:03 | |
*** ducttape_ has quit IRC | 12:04 | |
pkholkin | alaski: dansmith: hi folks! I've answered the question regarding 'marker is name' https://review.openstack.org/#/c/338226 | 12:05 |
*** ducttape_ has joined #openstack-nova | 12:05 | |
markus_z | sfinucan: johnthetubaguy: Up and running: http://45.55.105.55:8082/config-options.html | 12:06 |
*** maurosr has quit IRC | 12:06 | |
markus_z | bauzas: Got your warpaint ready for tonight? ;) | 12:07 |
*** shaohe_feng has quit IRC | 12:07 | |
*** ivase_ has joined #openstack-nova | 12:07 | |
*** dingboopt has quit IRC | 12:08 | |
*** shaohe_feng has joined #openstack-nova | 12:08 | |
*** ivase has quit IRC | 12:08 | |
*** maurosr has joined #openstack-nova | 12:09 | |
*** kevin_zh has quit IRC | 12:09 | |
artom | BobBall, yep, I'll take a look | 12:09 |
*** IanGovett has joined #openstack-nova | 12:10 | |
*** Daisy has joined #openstack-nova | 12:10 | |
bauzas | markus_z: a-ha http://www.t4lk.co/celebrities/hugo-lloris/2016-07-07/Voila-comment-je-veux-tre-ce-soir-contre-les-artificiers-allemands | 12:10 |
markus_z | he he he | 12:11 |
*** hoangcx has quit IRC | 12:11 | |
*** ivase has joined #openstack-nova | 12:13 | |
*** ivase_ has quit IRC | 12:13 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: Add functional regression test for bug 1595962 https://review.openstack.org/338416 | 12:14 |
openstack | bug 1595962 in OpenStack Compute (nova) "live migration with disabled vnc/spice not possible" [Undecided,In progress] https://launchpad.net/bugs/1595962 - Assigned to Markus Zoeller (markus_z) (mzoeller) | 12:14 |
*** baoli has joined #openstack-nova | 12:14 | |
openstackgerrit | Lee Yarwood proposed openstack/nova: WIP - compute: Refresh connection_info on migration rollback https://review.openstack.org/338929 | 12:15 |
*** Daisy has quit IRC | 12:15 | |
lyarwood | ^ would anyone from the live-migration subteam be able to review this, also anyone with experience moxing bdm.save()'s etc as I can't get the test to pass locally. | 12:15 |
*** baoli_ has joined #openstack-nova | 12:15 | |
*** sree__ has quit IRC | 12:15 | |
lyarwood | mdbooth: ^ not sure if you have time today to take a look at this as you've been working on various bdm touching tests recently | 12:15 |
*** Daisy has joined #openstack-nova | 12:16 | |
mdbooth | lyarwood: I'm not going to look now, but can you badger me about this tomorrow? | 12:16 |
danpb | lyarwood: so, IIUC, the problem you're fixing there is that we've updated the database BDM based on the target host state ? | 12:16 |
*** aysyd has joined #openstack-nova | 12:16 | |
danpb | lyarwood: even though we're still on the source host due to failure | 12:16 |
lyarwood | danpb: correct | 12:16 |
lyarwood | danpb: yeah we've failed back to the src | 12:17 |
*** shaohe_feng has quit IRC | 12:17 | |
*** shaohe_feng has joined #openstack-nova | 12:18 | |
*** ivase_ has joined #openstack-nova | 12:19 | |
*** ivase has quit IRC | 12:19 | |
*** baoli has quit IRC | 12:19 | |
*** gjayavelu has joined #openstack-nova | 12:20 | |
*** Daisy has quit IRC | 12:20 | |
lyarwood | mdbooth: sorry, yeah that's not a problem, thanks! | 12:20 |
*** mdavidson has quit IRC | 12:21 | |
*** Daisy has joined #openstack-nova | 12:21 | |
*** ratailor has quit IRC | 12:21 | |
*** liverpooler has quit IRC | 12:22 | |
*** chhavi_ has joined #openstack-nova | 12:23 | |
*** zerda2 has quit IRC | 12:23 | |
*** tyrola has quit IRC | 12:23 | |
*** tyrola has joined #openstack-nova | 12:24 | |
*** ivase has joined #openstack-nova | 12:24 | |
*** gjayavelu has quit IRC | 12:25 | |
johnthetubaguy | markus_z: whoop! thank you | 12:25 |
*** ljxiash has quit IRC | 12:26 | |
*** ivase_ has quit IRC | 12:26 | |
xavvior | Please can someone review this patchset? Fix this bug: #1585494. https://review.openstack.org/#/c/322341/ | 12:26 |
openstack | bug 1585494 in OpenStack Compute (nova) "Rebuild instance, if the physical data is missing (at start)" [Undecided,In progress] https://launchpad.net/bugs/1585494 - Assigned to Alex Szarka (xavvior) | 12:26 |
*** ljxiash has joined #openstack-nova | 12:26 | |
*** f10d4 has quit IRC | 12:27 | |
*** eharney has joined #openstack-nova | 12:27 | |
johnthetubaguy | markus_z: I added a link in to here: https://wiki.openstack.org/wiki/ConfigOptionsConsistency | 12:27 |
*** shaohe_feng has quit IRC | 12:27 | |
*** ducttape_ has quit IRC | 12:28 | |
*** f10d4 has joined #openstack-nova | 12:28 | |
*** shaohe_feng has joined #openstack-nova | 12:28 | |
*** rtheis has quit IRC | 12:29 | |
markus_z | johnthetubaguy: Cool, I have added the link below the header line | 12:29 |
*** f10d4 has quit IRC | 12:30 | |
*** f10d4 has joined #openstack-nova | 12:30 | |
*** ivase_ has joined #openstack-nova | 12:30 | |
*** ljxiash has quit IRC | 12:31 | |
*** ivase has quit IRC | 12:31 | |
*** Daisy has quit IRC | 12:31 | |
*** winston-d_ has quit IRC | 12:33 | |
*** tonytan4ever has joined #openstack-nova | 12:33 | |
*** roeyc has joined #openstack-nova | 12:34 | |
*** mdrabe has joined #openstack-nova | 12:35 | |
*** Raildo has joined #openstack-nova | 12:35 | |
*** ivase has joined #openstack-nova | 12:36 | |
*** tyrola has quit IRC | 12:36 | |
*** ivase_ has quit IRC | 12:37 | |
*** zzzeek has quit IRC | 12:37 | |
*** tyrola has joined #openstack-nova | 12:37 | |
*** mdavidson has joined #openstack-nova | 12:37 | |
*** pradk has quit IRC | 12:37 | |
*** tonytan4ever has quit IRC | 12:38 | |
*** shaohe_feng has quit IRC | 12:38 | |
*** Daisy has joined #openstack-nova | 12:38 | |
*** IanGovett has quit IRC | 12:38 | |
*** EinstCrazy has quit IRC | 12:40 | |
*** shaohe_feng has joined #openstack-nova | 12:40 | |
*** tbachman_ has quit IRC | 12:40 | |
*** Harikrishna has joined #openstack-nova | 12:41 | |
*** Raildo has quit IRC | 12:41 | |
Harikrishna | Hi Team, I'm getting a strange error when I adding a new compute node to the existing environment, can anyone help me?? | 12:42 |
*** ivase_ has joined #openstack-nova | 12:42 | |
*** Daisy has quit IRC | 12:42 | |
*** kodoku has joined #openstack-nova | 12:42 | |
Harikrishna | 2016-07-07 17:50:43.840 16130 INFO neutron.agent.common.ovs_lib [req-22d7cc90-0fb7-4ca9-8893-0220b4049cc2 ] Port c47ef230-792a-433c-b27f-2cc3629c8639 not present in bridge br-int | 12:43 |
*** ivase has quit IRC | 12:43 | |
*** jaypipes has joined #openstack-nova | 12:43 | |
Harikrishna | can any one tell me what might be the reason for above error?? | 12:43 |
*** wangqun has joined #openstack-nova | 12:43 | |
*** Daisy has joined #openstack-nova | 12:44 | |
*** tbachman has joined #openstack-nova | 12:44 | |
*** oanson has quit IRC | 12:46 | |
*** shaohe_feng has quit IRC | 12:48 | |
*** ivase has joined #openstack-nova | 12:48 | |
*** ivase_ has quit IRC | 12:48 | |
*** shaohe_feng has joined #openstack-nova | 12:49 | |
*** Daisy has quit IRC | 12:49 | |
jaypipes | morning everyone. | 12:50 |
*** Raildo has joined #openstack-nova | 12:50 | |
*** Daisy has joined #openstack-nova | 12:51 | |
*** diga has quit IRC | 12:52 | |
*** tbachman_ has joined #openstack-nova | 12:52 | |
*** tbachman has quit IRC | 12:52 | |
*** tbachman_ is now known as tbachman | 12:52 | |
*** f10d4 has quit IRC | 12:52 | |
*** jwcroppe has joined #openstack-nova | 12:52 | |
*** jamesdenton has joined #openstack-nova | 12:53 | |
*** ivase_ has joined #openstack-nova | 12:53 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Add a hacking rule for string interpolation at logging https://review.openstack.org/334844 | 12:54 |
*** ivase has quit IRC | 12:55 | |
*** Daisy has quit IRC | 12:56 | |
*** Raildo has quit IRC | 12:56 | |
*** jwcroppe has quit IRC | 12:57 | |
openstackgerrit | sahid proposed openstack/nova: live-mig: Add claims and proper resource tracking https://review.openstack.org/244489 | 12:57 |
openstackgerrit | sahid proposed openstack/nova: libvirt: pass libvirt reference methods to migration https://review.openstack.org/328997 | 12:57 |
openstackgerrit | sahid proposed openstack/nova: libvirt: live-migrate updates NUMA and cpus in the XML https://review.openstack.org/286744 | 12:57 |
*** chandankumar has quit IRC | 12:58 | |
*** xenogear has joined #openstack-nova | 12:58 | |
*** shaohe_feng has quit IRC | 12:58 | |
*** shaohe_feng has joined #openstack-nova | 12:59 | |
*** rlrossit has joined #openstack-nova | 12:59 | |
*** wangqun has quit IRC | 13:00 | |
*** ivase has joined #openstack-nova | 13:00 | |
Dinesh_Bhor | oomichi: Hi, Could you please take a look at it: https://review.openstack.org/#/c/315964/ | 13:00 |
*** ivase_ has quit IRC | 13:01 | |
*** links has quit IRC | 13:02 | |
*** Daisy has joined #openstack-nova | 13:02 | |
*** DaiDV has joined #openstack-nova | 13:02 | |
jaypipes | danpb: yeah, dansmith corrected me on IRC about the glob versus regex syntax thing... oof. | 13:03 |
kodoku | Hi, anyone why compute request nova API every 10 min ? | 13:03 |
kodoku | anyone know* | 13:03 |
jaypipes | danpb: what I had suggested is making a brand new config option instead of changing the existing pci_passthrough_whitelist option's interpretation. thoughts? | 13:04 |
jaypipes | kodoku: it's not requesting the nova api. it's sending a message to update the compute node's resource status to the nova-conductor which writes a record to the database every 10 minutes. | 13:04 |
*** ivase_ has joined #openstack-nova | 13:05 | |
*** ivase has quit IRC | 13:06 | |
*** Daisy has quit IRC | 13:07 | |
*** sdake has joined #openstack-nova | 13:07 | |
danpb | jaypipes: i don't mind either way on that point | 13:07 |
danpb | jaypipes: i had in fact suggesting a separately named config option in an earlier draft of the spec | 13:07 |
kodoku | jaypipes I can see compute request nova API with servers/detail?all_tenants=True&changes-since=...... | 13:08 |
danpb | jaypipes: a completely different approach would be to have pci_whitelist_match=glob|regex config param to indicate how to interpret the current param | 13:08 |
kodoku | jaypipes How can I configure compute for use internalURL endpoint ? default it's publicURL | 13:08 |
*** shaohe_feng has quit IRC | 13:08 | |
*** xyang1 has joined #openstack-nova | 13:08 | |
jaypipes | danpb: yep, that's another option indeed. | 13:09 |
*** hoangcx has joined #openstack-nova | 13:09 | |
jaypipes | danpb: I think I support the new config option and deprecate the old, since the regex matching would be more expressive and powerful anyway. | 13:09 |
kodoku | jaypipes and why compute not use AMQP for that ? :=) | 13:09 |
*** shaohe_feng has joined #openstack-nova | 13:09 | |
danpb | jaypipes: yeah, it would be nice to just kill off the old option after a release or two | 13:09 |
danpb | so we can drop the globbing code entirely at some point | 13:10 |
markus_z | johnthetubaguy: Ah, I understood you wrong, but I get it now. | 13:10 |
jaypipes | kodoku: for user-type questions, please see /topic of this channel. better to ask questions on the mailing list (openstack@lists.openstack.org). what are you referring to as "the compute"? | 13:10 |
jaypipes | danpb: ++ | 13:10 |
johnthetubaguy | markus_z: likewise actually, I see your link to the wiki now | 13:10 |
kodoku | compute is the compute node with just nova-compute service | 13:11 |
markus_z | :D | 13:11 |
jaypipes | kodoku: the compute node only communicates over AMQP. it doesn't communciate with the Nova API service. | 13:11 |
*** ivase has joined #openstack-nova | 13:11 | |
*** DaiDV has quit IRC | 13:11 | |
*** ivase_ has quit IRC | 13:11 | |
*** tonytan4ever has joined #openstack-nova | 13:12 | |
*** ducttape_ has joined #openstack-nova | 13:12 | |
*** ducttape_ has quit IRC | 13:13 | |
kodoku | jaypipes ok it's maybe ceilometer compute agent, I'll try to stop ceilometer agent and wait 10 min | 13:14 |
*** M00nr41n has quit IRC | 13:15 | |
*** tblakeslee has joined #openstack-nova | 13:16 | |
*** READ10 has joined #openstack-nova | 13:16 | |
*** yamahata has joined #openstack-nova | 13:16 | |
*** ivase_ has joined #openstack-nova | 13:17 | |
sfinucan | markus_z: Tool looks good. Nice one | 13:17 |
sfinucan | On a wiki somewhere? | 13:17 |
*** andreykurilin has joined #openstack-nova | 13:17 | |
*** ivase has quit IRC | 13:17 | |
markus_z | sfinucan: Thanks to you and john, I just plugged it together. John added it to https://wiki.openstack.org/wiki/ConfigOptionsConsistency | 13:18 |
jaypipes | kodoku: ah, yes, that is likely what "the compuyte" is :) | 13:18 |
*** GB21 has quit IRC | 13:18 | |
*** chandankumar has joined #openstack-nova | 13:18 | |
*** Daisy has joined #openstack-nova | 13:18 | |
*** vladikr has joined #openstack-nova | 13:19 | |
*** shaohe_feng has quit IRC | 13:19 | |
*** mtanino has joined #openstack-nova | 13:19 | |
*** shaohe_feng has joined #openstack-nova | 13:19 | |
*** ctrath has quit IRC | 13:20 | |
markus_z | sfinucan: As FF is done, I can focus more on that now. | 13:20 |
*** Harikrishna has quit IRC | 13:20 | |
*** fragatina has joined #openstack-nova | 13:21 | |
*** woodster_ has joined #openstack-nova | 13:21 | |
kodoku | jaypipes ok it's ceilometer agent :) | 13:21 |
*** diogogmt has quit IRC | 13:21 | |
*** ivase has joined #openstack-nova | 13:22 | |
tdurakov | johnthetubaguy, mriedem_afk, hi folks, could you please explain meaning of this check https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/test_migrate_server.py#L136-L137 ? | 13:22 |
*** ivase_ has quit IRC | 13:23 | |
*** sdake_ has joined #openstack-nova | 13:23 | |
*** Daisy has quit IRC | 13:23 | |
*** baoli_ has quit IRC | 13:24 | |
openstackgerrit | Matthew Booth proposed openstack/nova: Remove max_size argument to images.fetch and fetch_to_raw https://review.openstack.org/326947 | 13:25 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Fix signature and behaviour of fake get_disk_backing_file https://review.openstack.org/337242 | 13:25 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Fix fake _disk_info data in LibvirtDriverTestCase https://review.openstack.org/328366 | 13:25 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Pass path to Image base class https://review.openstack.org/333271 | 13:25 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Replace some uses of invalid uuids in test_driver https://review.openstack.org/333978 | 13:25 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Remove some unnecessary mocking in test_driver https://review.openstack.org/333979 | 13:25 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Rewrite _test_finish_migration https://review.openstack.org/337159 | 13:25 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: rewrite test_rescue and test_rescue_config_drive https://review.openstack.org/335966 | 13:25 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Use valid uuids and fnames in test_create_image_initrd https://review.openstack.org/333241 | 13:26 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Improve mocking of imagebackend disks https://review.openstack.org/333242 | 13:26 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Pass instance object to _create_images_and_backing in test https://review.openstack.org/333243 | 13:26 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Test disk creation in test_hard_reboot https://review.openstack.org/338993 | 13:26 |
*** diogogmt has joined #openstack-nova | 13:26 | |
*** cleong has joined #openstack-nova | 13:27 | |
*** sdake has quit IRC | 13:27 | |
*** cdent has joined #openstack-nova | 13:27 | |
*** ivase_ has joined #openstack-nova | 13:28 | |
Dinesh_Bhor | mriedem_afk: Hi, Could you please share the information with me , when it will be the new release of sqlalchemy-migrate lib ? | 13:28 |
*** takedakn has joined #openstack-nova | 13:29 | |
*** shaohe_feng has quit IRC | 13:29 | |
*** ivase has quit IRC | 13:30 | |
*** shaohe_feng has joined #openstack-nova | 13:30 | |
*** Daisy has joined #openstack-nova | 13:30 | |
mriedem_afk | tdurakov: idk, i guess the note above it explains it, i'd probably ask alex_xu | 13:30 |
*** mriedem_afk is now known as mriedem | 13:30 | |
mriedem | Dinesh_Bhor: i hadn't planned one | 13:30 |
mriedem | Dinesh_Bhor: is there something critical that needs to be released? | 13:30 |
tdurakov | mriedem: this check just werify just method is decorated properly | 13:31 |
*** shyama has joined #openstack-nova | 13:31 | |
*** rlrossit has quit IRC | 13:31 | |
*** rtheis has joined #openstack-nova | 13:32 | |
Dinesh_Bhor | mriedem: not that much critical but there are my for patches open for review in nova,cinder, glance and keystone which are dependent on the patch which is merged recently in sqlalchemy-migrate lib. | 13:33 |
*** ivase has joined #openstack-nova | 13:34 | |
*** rlrossit has joined #openstack-nova | 13:34 | |
*** Daisy has quit IRC | 13:34 | |
*** ivase_ has quit IRC | 13:35 | |
mriedem | tdurakov: yeah i guess gmann added it here https://github.com/openstack/nova/commit/c36d2b3d80b14b44fdc441ba350da4bec846da76 | 13:35 |
mriedem | because it changed the test to not go through wsgi | 13:35 |
*** Daisy has joined #openstack-nova | 13:35 | |
*** tbachman has quit IRC | 13:35 | |
mriedem | Dinesh_Bhor: this https://github.com/openstack/sqlalchemy-migrate/commit/2a326810362508cbb50be1eed405ba9208804010? | 13:36 |
mriedem | or this https://github.com/openstack/sqlalchemy-migrate/commit/9356e5e28aff46b98db9619b55dc191b6843a217 | 13:36 |
tdurakov | mriedem: the problem here is that it starts to fail once I've decorated controller's _migrate_live with @wsgi.Controller.api_version("2.34") | 13:36 |
Dinesh_Bhor | mriedem: yes | 13:36 |
mriedem | Dinesh_Bhor: what nova change is dependent on that? | 13:36 |
*** baoli has joined #openstack-nova | 13:37 | |
Dinesh_Bhor | mriedem: https://review.openstack.org/#/c/296920/ this one. | 13:37 |
*** zz_dimtruck is now known as dimtruck | 13:38 | |
johnthetubaguy | tdurakov: that means the method only works for that specific version, so that will break existing users, do you have a link? | 13:38 |
*** shaohe_feng has quit IRC | 13:39 | |
*** diogogmt has quit IRC | 13:40 | |
*** ivase_ has joined #openstack-nova | 13:40 | |
*** Daisy has quit IRC | 13:40 | |
johnthetubaguy | tdurakov: the test is just checking for v2.1 vs legacy ways of returning the status code, actually that code can probably now be deleted, since we dropped the legacy API stuff | 13:40 |
*** shaohe_feng has joined #openstack-nova | 13:40 | |
*** ivase has quit IRC | 13:41 | |
*** Daisy has joined #openstack-nova | 13:41 | |
*** mtanino has quit IRC | 13:43 | |
*** f10d4 has joined #openstack-nova | 13:43 | |
tdurakov | johnthetubaguy: yes, but it fails, because of Controller.api_version I'm adding | 13:43 |
johnthetubaguy | tdurakov: can you link to your patch? | 13:43 |
*** baoli has quit IRC | 13:44 | |
johnthetubaguy | tdurakov: what you are saying is only allow the API to work for version 2.34, so it will fail unless that on an additional method | 13:44 |
tdurakov | johnthetubaguy: working on update for https://review.openstack.org/#/c/314932/ here is the snipper | 13:44 |
tdurakov | s/snippet | 13:44 |
tdurakov | http://xsnippet.org/361836/ | 13:44 |
*** zzzeek has joined #openstack-nova | 13:44 | |
*** pradk has joined #openstack-nova | 13:44 | |
tdurakov | johnthetubaguy: ^ | 13:44 |
tdurakov | this separation causes tests to fail | 13:45 |
tdurakov | because api_version hides duplicates in class-level dict with ordered by version methods | 13:45 |
*** Daisy has quit IRC | 13:45 | |
*** ducttape_ has joined #openstack-nova | 13:45 | |
johnthetubaguy | tdurakov: as an aside, I would create a helper method for most of that stuff, like get_args, or something | 13:46 |
johnthetubaguy | tdurakov: right, gotcha | 13:46 |
mriedem | yeah the duplication there is not fun | 13:46 |
*** ivase has joined #openstack-nova | 13:46 | |
*** sudipto has joined #openstack-nova | 13:46 | |
tdurakov | so there is no actually wsgi_code attribute | 13:46 |
*** ivase_ has quit IRC | 13:46 | |
tdurakov | take a look | 13:46 |
tdurakov | http://xsnippet.org/361839/ | 13:46 |
*** Daisy has joined #openstack-nova | 13:46 | |
tdurakov | johnthetubaguy:^ | 13:46 |
openstackgerrit | Weiwei Gu proposed openstack/nova: migration volume failed for invalid type https://review.openstack.org/315864 | 13:47 |
johnthetubaguy | tdurakov: I kinda assumed its trying to read what @wsgi.response(202) adds | 13:47 |
tdurakov | yeah, but actual methods are hidden) | 13:47 |
tdurakov | in dict | 13:47 |
johnthetubaguy | yeah | 13:48 |
tdurakov | if we really want to verify response code I'd rewrite this code | 13:48 |
johnthetubaguy | yeah, I think thats the plan, verify the response code | 13:49 |
*** dingboopt has joined #openstack-nova | 13:49 | |
johnthetubaguy | I guess it should go a level up to make that easier | 13:49 |
mriedem | tdurakov: http://docs.openstack.org/developer/nova/api_microversion_dev.html#in-code | 13:49 |
mriedem | "In nova/api/openstack/wsgi.py we define an @api_version decorator which is intended to be used on top-level Controller methods. It is not appropriate for lower-level methods." | 13:49 |
tdurakov | smth like https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/test_keypairs.py#L323-L333 | 13:49 |
mriedem | is _migrate_live a 'lower-level method'? | 13:49 |
*** shaohe_feng has quit IRC | 13:49 | |
*** ctrath has joined #openstack-nova | 13:50 | |
mriedem | where else is @wsgi.Controller.api_version used? | 13:50 |
mriedem | are there any other action methods that use that? | 13:50 |
tdurakov | keypairs | 13:50 |
*** shaohe_feng has joined #openstack-nova | 13:50 | |
tdurakov | mriedem: ^ | 13:50 |
mriedem | tdurakov: those are top level methods though | 13:51 |
johnthetubaguy | hmm, interesting... | 13:51 |
*** Daisy has quit IRC | 13:51 | |
mriedem | create/delete/show/index keypairs | 13:51 |
tdurakov | mriedem: oh, action methods | 13:51 |
mriedem | it's on all of those top level methods | 13:51 |
tdurakov | mriedem: not sure | 13:51 |
tdurakov | then | 13:51 |
mriedem | yeah i'm thinking the _migrate_live is a 'lower level' method | 13:51 |
mriedem | and you can't use that decorator as the docs say | 13:51 |
*** ivase_ has joined #openstack-nova | 13:51 | |
johnthetubaguy | yeah, its an indirect method I guess, making it lower level | 13:52 |
tdurakov | mriedem: ok, how should i split these methods then? http://xsnippet.org/361836/ - I've tried this way | 13:52 |
*** Daisy has joined #openstack-nova | 13:52 | |
*** ivase has quit IRC | 13:52 | |
johnthetubaguy | can't you just do an if clause around that call that has the except clause? | 13:52 |
mriedem | http://docs.openstack.org/developer/nova/api_microversion_dev.html#when-not-using-decorators | 13:53 |
johnthetubaguy | yeah, that method | 13:53 |
tdurakov | johnthetubaguy: I could but it will be not that good... | 13:53 |
tdurakov | more ifs | 13:53 |
mriedem | sec there is another way | 13:54 |
alaski | the code that tdurakov has should work though right? | 13:54 |
*** burt has joined #openstack-nova | 13:54 | |
mriedem | alaski: which code? | 13:54 |
*** Raildo has joined #openstack-nova | 13:54 | |
alaski | http://xsnippet.org/361836/ | 13:54 |
mriedem | not according to the docs with that api_version decorator | 13:55 |
alaski | two methods with the same name with different api_version decorators | 13:55 |
johnthetubaguy | so I am surpised it fails, this could just be a unit test issue | 13:55 |
johnthetubaguy | its the response_code bit | 13:55 |
mriedem | alaski: i'm assuming the docs say it has to be a top level method for a reason | 13:55 |
mriedem | but we'd really need alex_xu, gmann, oomichi or sdague to explain that | 13:55 |
tdurakov | mriedem: btw what is the reason of such limitation for api_version? | 13:55 |
mriedem | you're asking the wrong guy | 13:55 |
alaski | mriedem: you mean just having _ as the prefix? | 13:55 |
mriedem | alaski: i thought because it was an action method | 13:56 |
mriedem | but, | 13:56 |
mriedem | looky here https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/fixed_ips.py | 13:56 |
alaski | looking at http://docs.openstack.org/developer/nova/api_microversion_dev.html#changing-a-method-s-behavior it seems like what he has matches | 13:56 |
mriedem | i did the same thing for _fill_reserved_status | 13:56 |
johnthetubaguy | I assume this issue is more about the unit test not reading this correctly? | 13:56 |
johnthetubaguy | tdurakov: did the functional tests pass OK? | 13:56 |
mriedem | could it be the order of the decorators? | 13:56 |
tdurakov | johnthetubaguy: started with ut | 13:57 |
tdurakov | give me 5 mins | 13:57 |
mriedem | tdurakov: what if you make @wsgi.Controller.api_version the first decorator rather than the last? | 13:57 |
tdurakov | will run functional | 13:57 |
*** Daisy has quit IRC | 13:57 | |
*** ivase has joined #openstack-nova | 13:57 | |
*** mmandel has joined #openstack-nova | 13:57 | |
*** ivase_ has quit IRC | 13:58 | |
*** Daisy has joined #openstack-nova | 13:58 | |
johnthetubaguy | mriedem: ooh... thats a good point actually | 13:58 |
tdurakov | mriedem: 5 mins, schedulled functional, but imho it won't help | 13:58 |
*** dimtruck is now known as zz_dimtruck | 13:58 | |
johnthetubaguy | you need the decorators under the version switch | 13:58 |
tdurakov | johnthetubaguy: understood | 13:59 |
*** shaohe_feng has quit IRC | 14:00 | |
mriedem | the other thing is yeah, the unit tests are just calling the method on the controller, not going through wsgi | 14:00 |
mriedem | so if we don't go through the wsgi layer, it's not hitting the decorator to determine which versioned method to call | 14:00 |
mriedem | so the unit tests are probably just calling the first one | 14:00 |
mriedem | which is not what tdurakov wants | 14:00 |
*** ericksonsantos has quit IRC | 14:00 | |
*** baoli has joined #openstack-nova | 14:01 | |
*** shaohe_feng has joined #openstack-nova | 14:01 | |
mriedem | so https://github.com/openstack/nova/commit/c36d2b3d80b14b44fdc441ba350da4bec846da76 is kind of bogus | 14:01 |
tdurakov | mriedem: + my idea was to rewrite it same way as keypairs being tested | 14:01 |
mriedem | it makes testing a single version of a thing at that point in time more convenient | 14:01 |
*** code-R has joined #openstack-nova | 14:01 | |
tdurakov | mriedem, johnthetubaguy reordering decorators doesn't help | 14:01 |
mriedem | yeah it's the unit test that's busted | 14:02 |
*** Daisy has quit IRC | 14:02 | |
mriedem | it doesn't go through wsgi so doesn't know which versioned method to pick | 14:02 |
tdurakov | AttributeError: 'function' object has no attribute 'wsgi_code' | 14:02 |
mriedem | sucks that change went in almost a year and a half ago | 14:02 |
mriedem | or we could have reverted it | 14:02 |
*** artom has quit IRC | 14:02 | |
*** ivase_ has joined #openstack-nova | 14:03 | |
*** mgould is now known as mgould|meeting | 14:03 | |
*** Daisy has joined #openstack-nova | 14:03 | |
tdurakov | johnthetubaguy, mriedem, alaski once functional tests running... could I use @api_version on non top-level methods? | 14:04 |
*** ivase has quit IRC | 14:04 | |
alaski | tdurakov: I think it has to be a top level method, but it can have a _ prefix | 14:04 |
alaski | as I understand it | 14:04 |
mriedem | tdurakov: yeah | 14:04 |
mriedem | it's the unit tests that are broken | 14:04 |
mriedem | right here https://review.openstack.org/#/c/148445/5/nova/tests/unit/api/openstack/compute/admin_only_action_common.py@77 | 14:05 |
frickler | if someone could raise the importance of https://bugs.launchpad.net/nova/+bug/1597596 that would be great, it is affecting us in production. I also think I have pretty much localized what is going wrong, but it probably needs someone who understands the async code better to fix it | 14:05 |
openstack | Launchpad bug 1597596 in OpenStack Compute (nova) "network not always cleaned up when spawning VMs" [Undecided,In progress] - Assigned to Aihua Edward Li (aihuaedwardli) | 14:05 |
*** sheel has quit IRC | 14:05 | |
openstackgerrit | Tina Kevin proposed openstack/nova: Instance can not resize ephemeral disk https://review.openstack.org/320759 | 14:07 |
*** Daisy has quit IRC | 14:08 | |
jaypipes | edleafe, mriedem, johnthetubaguy, alaski: not sure if you guys caught my two (pretty critical) amendments to the generic-resource-pools and resource-providers-allocations blueprints last night. Here they are if you have a chance to take a gander: https://review.openstack.org/#/c/338618/ and https://review.openstack.org/#/c/300177/ | 14:08 |
jaypipes | ignore the python27 checks... | 14:08 |
*** ivase has joined #openstack-nova | 14:09 | |
*** Daisy has joined #openstack-nova | 14:09 | |
*** ivase_ has quit IRC | 14:09 | |
* tdurakov functional still running | 14:10 | |
*** shaohe_feng has quit IRC | 14:10 | |
edleafe | jaypipes: yep, saw that in the scrollback. I'll jump on it soon. | 14:10 |
*** shaohe_feng has joined #openstack-nova | 14:11 | |
*** baoli has quit IRC | 14:11 | |
*** baoli has joined #openstack-nova | 14:12 | |
jaypipes | edleafe: cheers mate, appreciated | 14:12 |
*** tonytan_brb has joined #openstack-nova | 14:12 | |
*** artom has joined #openstack-nova | 14:13 | |
*** Daisy has quit IRC | 14:13 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: 'limit' and 'marker' support for db_api and keypair_obj https://review.openstack.org/338226 | 14:14 |
*** Daisy has joined #openstack-nova | 14:14 | |
*** ivase_ has joined #openstack-nova | 14:15 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: Microversion 2.34 adds keypairs pagination support https://review.openstack.org/284868 | 14:15 |
*** ivase has quit IRC | 14:15 | |
*** tonytan4ever has quit IRC | 14:15 | |
pkholkin | alaski: thanks for review! | 14:16 |
pkholkin | please once again) https://review.openstack.org/#/c/338226/ | 14:16 |
pkholkin | fixed object comment | 14:16 |
pkholkin | mriedem: please look the patch | 14:17 |
*** chandankumar has quit IRC | 14:17 | |
pkholkin | Andrew marked as +2 :) | 14:17 |
pkholkin | dansmith: thanks for review, too! | 14:17 |
pkholkin | sorry for this dirty comment) | 14:17 |
*** mlavalle has joined #openstack-nova | 14:18 | |
tdurakov | mriedem, johnthetubaguy, alaski: fyi, the order of decorators are important, from the functional tests point of view: http://xsnippet.org/361840/ - this order works, this one: http://xsnippet.org/361841/ fails: http://xsnippet.org/361842/ | 14:19 |
*** Daisy has quit IRC | 14:19 | |
mlavalle | cdent: ping | 14:19 |
cdent | hi mlavalle | 14:20 |
tdurakov | so I'm going to rewrite ut with the same way they are done for keypairs, e.g. https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/test_keypairs.py#L323-L333 | 14:20 |
*** Daisy has joined #openstack-nova | 14:20 | |
tdurakov | mriedem, alaski, johnthetubaguy are you ok with this? | 14:20 |
*** prateek has quit IRC | 14:20 | |
*** shaohe_feng has quit IRC | 14:20 | |
*** ljxiash has joined #openstack-nova | 14:20 | |
*** ivase has joined #openstack-nova | 14:20 | |
*** zz_dimtruck is now known as dimtruck | 14:21 | |
mlavalle | cdent: I am a Neutron development, who is trying to implement Scenarios 2a and 2b from http://specs.openstack.org/openstack/nova-specs/specs/newton/approved/generic-resource-pools.html. I have a couple of questions. May I still a few minutes of your time? | 14:21 |
alaski | tdurakov: yeah, testing at the request level seems fine to me | 14:21 |
*** ivase_ has quit IRC | 14:21 | |
*** shaohe_feng has joined #openstack-nova | 14:21 | |
tdurakov | alaski: ok | 14:21 |
cdent | mlavalle: I can try to help, sure, but I can't guarantee of being any use | 14:22 |
mriedem | pkholkin: big ol' -1 | 14:22 |
*** Raildo has quit IRC | 14:23 | |
openstackgerrit | Jay Pipes proposed openstack/nova-specs: resource-providers: Populate allocation fields https://review.openstack.org/300177 | 14:23 |
mriedem | alex_xu: do you foresee any issues with paging by name for keypairs in https://review.openstack.org/#/c/338226/ ? | 14:23 |
mriedem | alex_xu: the main issue being name is only unique within a user_id | 14:23 |
mlavalle | cdent: I want to try to start prototyping on the Neutron side, the interaction with Nova using the g-r-p rest api. How close are the series of patches here https://review.openstack.org/#/q/topic:bp/generic-resource-pools,n,z to be able to be deployed in my test environment and start using the api? | 14:23 |
mriedem | but we also only list by user_id | 14:23 |
mriedem | tdurakov: i'm ok with that, just make a new class | 14:24 |
mriedem | MigrateServerTestsV234 or whatever | 14:24 |
*** EinstCra_ has joined #openstack-nova | 14:24 | |
*** jaugustine has joined #openstack-nova | 14:24 | |
openstackgerrit | Jay Pipes proposed openstack/nova-specs: Amend placement REST API with allocation records https://review.openstack.org/338618 | 14:24 |
mriedem | and you probably can't inherit what's in admin_only_action_common.CommonTests really | 14:24 |
*** Daisy has quit IRC | 14:25 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: config options: Improve help for SPICE https://review.openstack.org/317046 | 14:25 |
*** BjoernT has joined #openstack-nova | 14:25 | |
*** Daisy has joined #openstack-nova | 14:25 | |
mriedem | crap. meetings. | 14:26 |
cdent | mlavalle: with what's there, it is possible to create providers and inventories over the api, but not yet associate aggregates or make allocations. Nor does the resource tracker or scheduler do anything with the information yet. Without the aggregate handling, it can't really be of much use yet. | 14:26 |
mlavalle | cdent: my thinking is not only to prototype on the Neutron side but be able to provide feedback to you with feedback as an early adopter (the earliest?) | 14:26 |
*** ivase_ has joined #openstack-nova | 14:26 | |
cdent | mlavalle: getting early feedback would be awesome | 14:26 |
*** ivase has quit IRC | 14:27 | |
cdent | mlavalle: but as I say above the amount of interaction you can do is somewhat limited | 14:27 |
mlavalle | cdent: I understand that it is early and I won't get th full functionality. But I want to start moving early. I am willing to go through the pain of helping you guys grow this | 14:27 |
mlavalle | cdent: I understand that the scheduler side is still quite green | 14:28 |
*** mtanino has joined #openstack-nova | 14:28 | |
*** hoangcx has quit IRC | 14:28 | |
dansmith | cdent: do you want me to address jaypipes' comments on the allocation patch? | 14:29 |
*** penick has quit IRC | 14:29 | |
*** diga has joined #openstack-nova | 14:29 | |
*** gcb has joined #openstack-nova | 14:29 | |
*** mriedem1 has joined #openstack-nova | 14:29 | |
cdent | dansmith: if you could that would be great, I'm travelling again today, after a few brief hours of checking in this morning. thanks. | 14:29 |
openstackgerrit | Maciej Szankin proposed openstack/nova: config options: Improve help for base https://review.openstack.org/324559 | 14:30 |
dansmith | cdent: yep, that's why I'm asing | 14:30 |
dansmith | asking | 14:30 |
*** hoangcx has joined #openstack-nova | 14:30 | |
*** Daisy has quit IRC | 14:30 | |
*** shaohe_feng has quit IRC | 14:30 | |
*** ctrath has quit IRC | 14:31 | |
*** mriedem has quit IRC | 14:31 | |
*** Daisy has joined #openstack-nova | 14:31 | |
*** shaohe_feng has joined #openstack-nova | 14:31 | |
cdent | mlavalle: there's no client code yet, but the json used is quite simple and clear enough from the specs and that yaml files used by the gabbi tests | 14:31 |
openstackgerrit | Jay Pipes proposed openstack/nova-specs: Amend placement REST API with allocation records https://review.openstack.org/338618 | 14:31 |
jaypipes | cdent: addressed all your review comments on ^^ | 14:32 |
* cdent has had gerrit misread then | 14:32 | |
* cdent rereaders | 14:32 | |
*** diogogmt has joined #openstack-nova | 14:32 | |
*** ivase has joined #openstack-nova | 14:32 | |
*** ivase_ has quit IRC | 14:33 | |
*** ctrath has joined #openstack-nova | 14:33 | |
mlavalle | cdent: two more questions and I'll stop. I see you wil be traveling: 1) out of that series of patchsets, which one would you pick to deploy? | 14:34 |
cdent | mlavalle: either https://review.openstack.org/#/c/293104/ or https://review.openstack.org/#/c/329643/ (the first one has endpoints for dealing with aggregates but they don't work, the second does not) | 14:35 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: doc: fix disk=0 use case in flavor doc https://review.openstack.org/339034 | 14:35 |
*** Daisy has quit IRC | 14:36 | |
mlavalle | cdent: I am perfectly fine crafting rest requests with curl or a brwoser based rest client. When you refer to the client, are we talking about nova client or osc? Is anyone working on that? | 14:36 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: doc: fix disk=0 use case in flavor doc https://review.openstack.org/339034 | 14:37 |
*** raildo-afk is now known as raildo | 14:37 | |
cdent | jaypipes: still a minor wart | 14:38 |
*** ivase_ has joined #openstack-nova | 14:38 | |
*** MikeG451 has joined #openstack-nova | 14:38 | |
cdent | mlavalle: the idea is to create a openstack-placementclient at some point, which would have an osc plugin, I've started looking into that but haven't made any significant progress yet | 14:39 |
*** ivase has quit IRC | 14:39 | |
mlavalle | cdent: thanks for your answers. I will bug again later. In the meantime, have a nice trip | 14:40 |
*** moshele has joined #openstack-nova | 14:40 | |
cdent | thanks mlavalle | 14:40 |
cdent | mlavalle: feel free to ask me questions whenever I'm around, or post something to the mailing list and I'll probably see that and then other people can follow along too | 14:41 |
*** shaohe_feng has quit IRC | 14:41 | |
mlavalle | cdent: :-) | 14:41 |
*** tbachman has joined #openstack-nova | 14:41 | |
*** tonytan_brb is now known as tonytan4ever | 14:41 | |
*** shaohe_feng has joined #openstack-nova | 14:42 | |
*** burgerk has joined #openstack-nova | 14:43 | |
*** hoangcx has quit IRC | 14:43 | |
*** hoangcx has joined #openstack-nova | 14:43 | |
*** ivase has joined #openstack-nova | 14:44 | |
*** ivase_ has quit IRC | 14:44 | |
bauzas | cdent: I'm still a bit sad to see an openstack-placementclient honestly | 14:44 |
*** salv-orlando has joined #openstack-nova | 14:44 | |
*** salv-orl_ has joined #openstack-nova | 14:45 | |
bauzas | cdent: when did we have this discussion ? | 14:45 |
bauzas | tbc, when did the consensus happen ? | 14:45 |
openstackgerrit | Alex Szarka proposed openstack/nova: Typo fix: remove multiple whitespace https://review.openstack.org/339040 | 14:45 |
*** coreywright has quit IRC | 14:45 | |
jaypipes | cdent: yeah, generally I like to keep unrelated questions like that one about authorization in either separate amendments to a spec or discussions on the code itself. Tryiong to answer all questions like that just causes focus to be lost. | 14:45 |
bauzas | not during the midcycle, neither the summit | 14:46 |
cdent | bauzas: It's on the spec, isn't it? | 14:46 |
*** itamarl_ has joined #openstack-nova | 14:47 | |
*** klkumar has quit IRC | 14:47 | |
bauzas | cdent: that says "openstack resource-pools" as an example | 14:47 |
cdent | bauzas: but I guess it isn't really explicit. | 14:47 |
*** vishwanathj has quit IRC | 14:47 | |
bauzas | cdent: that's not also adding a work item | 14:48 |
*** edand has quit IRC | 14:48 | |
cdent | bauzas: so I don't really know. What's the disadvantage of it not being a plugin? | 14:48 |
*** ayoung has joined #openstack-nova | 14:48 | |
*** vishwanathj has joined #openstack-nova | 14:48 | |
openstackgerrit | Jay Pipes proposed openstack/nova-specs: Amend placement REST API with allocation records https://review.openstack.org/338618 | 14:48 |
jaypipes | cdent: k, fixed. | 14:48 |
*** moshele has quit IRC | 14:48 | |
bauzas | cdent: and tbh, I wouldn't like a huuuuge spec providing lots of documentation and just adding a new openstack client repo silently | 14:48 |
bauzas | cdent: I'm just thinking of adding the placement within the same repo | 14:49 |
*** salv-orlando has quit IRC | 14:49 | |
cdent | jaypipes: yeah, it's just not very clear how to keep those types of questions remembered/in the foreground, other than just continuous hassling and risk of forgetting, so I've ended up with using gerrit as a kind of amanuensis | 14:49 |
*** itamarl has quit IRC | 14:49 | |
*** itamarl_ is now known as itamarl | 14:49 | |
*** ivase_ has joined #openstack-nova | 14:49 | |
*** takedakn has quit IRC | 14:50 | |
*** jaugustine has quit IRC | 14:50 | |
*** ivase has quit IRC | 14:50 | |
*** itamarl has quit IRC | 14:50 | |
*** _diana_ has quit IRC | 14:51 | |
*** shaohe_feng has quit IRC | 14:51 | |
bauzas | cdent: for example, I was thinking of the novaclient package having submodules like compute and placement | 14:51 |
*** pushkaru has joined #openstack-nova | 14:51 | |
*** ametts has joined #openstack-nova | 14:51 | |
bauzas | cdent: ie. novaclient.compute.v2 and novaclient.placement.v1 | 14:51 |
*** shaohe_feng has joined #openstack-nova | 14:52 | |
cdent | jaypipes: that still doesn't really answer the question about what to do with an allocation list that includes a resource class when the target provider doesn't have inventory for that class | 14:54 |
*** hoangcx has quit IRC | 14:54 | |
*** jwcroppe has joined #openstack-nova | 14:54 | |
*** ivase has joined #openstack-nova | 14:55 | |
cdent | bauzas: that will mean that people who want to create or manage resource pools need to import novaclient, which seems not quite right to me | 14:55 |
pumaranikar | johnthetubaguy, I have updated this patch https://review.openstack.org/#/c/247176/. Please have a look when you get time | 14:55 |
*** ctrath has quit IRC | 14:56 | |
*** ivase_ has quit IRC | 14:56 | |
bauzas | cdent: they need to have nova installed either way | 14:56 |
bauzas | and we're talking here of cinder and neutron | 14:56 |
bauzas | which already ship that dep | 14:56 |
*** chhavi_ has quit IRC | 14:57 | |
cdent | i'm talking about a client machine, not a controller or compute machine, just somewhere someone is talking to an openstack deployment | 14:57 |
bauzas | again, the problem is not about being technical, it's about adding a new repo | 14:57 |
edleafe | I'd really be against adding this to novaclient | 14:57 |
jaypipes | cdent: then please update the spec with some text that answers that quiestion. | 14:57 |
edleafe | Just one more thing to have to separate later | 14:57 |
edleafe | I agree that we need to discuss this first, though | 14:58 |
*** coreywright has joined #openstack-nova | 14:58 | |
bauzas | what I really dislike is that we're forcing ourselves to split whatever we can because we love to | 14:58 |
cdent | jaypipes: I would except that I don't know the answer, but I'll think on it and do it after I get to the next destination. | 14:59 |
bauzas | I certainly agree with the fact that one day, we'll be grown-ups and ready to have the placement API flying by its own wings, but that deserves a bit of attention | 14:59 |
openstackgerrit | Ed Leafe proposed openstack/nova: Fix opt description for scheduler.py https://review.openstack.org/339046 | 14:59 |
jaypipes | bauzas: I don't understand what you mean by "forcing ourselves to split whatever we can because we love to". | 14:59 |
*** rrecio has joined #openstack-nova | 14:59 | |
bauzas | jaypipes: the fact that we have a long-term goal that is not ready to be there yet | 14:59 |
jaypipes | cdent: ok. | 15:00 |
edleafe | bauzas: we have been working for several cycles on untangling the scheduler's interface from nova internals. | 15:00 |
*** jwcroppe has quit IRC | 15:00 | |
edleafe | bauzas: adding a new entanglement doesn't seem like it helps that goal. | 15:00 |
*** svenkat has joined #openstack-nova | 15:00 | |
jaypipes | bauzas: honestly, if we don't move faster and get this stuff done, we're going to be crushed by the wave of "let's just ditch nova because k8s does everything better". I am tired of delaying, delaying, delaying everything for the status quo and getting pinged by everyone under the sun why the scheduler and resource tracker code in Nova is so horrible and resistant to change. | 15:01 |
*** ctrath has joined #openstack-nova | 15:01 | |
*** shaohe_feng has quit IRC | 15:01 | |
*** ivase has quit IRC | 15:01 | |
*** ivase has joined #openstack-nova | 15:01 | |
bauzas | jaypipes: trust me, I can be patient :) | 15:02 |
*** bharath has joined #openstack-nova | 15:02 | |
bauzas | so, the thing is, yes we can do the split | 15:02 |
*** shaohe_feng has joined #openstack-nova | 15:02 | |
*** mjura has quit IRC | 15:02 | |
bauzas | I'm just balancing the benefits of doing the split vs. keeping it in the same repo | 15:03 |
*** rhagarty__ has quit IRC | 15:03 | |
*** jaugustine has joined #openstack-nova | 15:03 | |
edleafe | bauzas: why is the repo it's in relevant? | 15:03 |
edleafe | bauzas: IOW, how does the same repo help Nova and/or scheduler | 15:03 |
bauzas | edleafe: because we have a community nurtiting that repo | 15:04 |
*** klkumar has joined #openstack-nova | 15:04 | |
edleafe | bauzas: but they will have zero knowledge of placement issues | 15:04 |
edleafe | bauzas: so that won't help the placement stuff at all | 15:05 |
bauzas | honestly, I'll continue to review | 15:05 |
*** efried has quit IRC | 15:06 | |
*** gongysh has joined #openstack-nova | 15:06 | |
alex_xu | mriedem1: I didn't see any problem sort keypair by name, as api only can get keypair for one user. | 15:06 |
*** ivase_ has joined #openstack-nova | 15:07 | |
*** ivase has quit IRC | 15:08 | |
*** efried has joined #openstack-nova | 15:08 | |
openstackgerrit | Alex Szarka proposed openstack/nova: Typo fix: remove multiple whitespace https://review.openstack.org/339040 | 15:08 |
alex_xu | tdurakov: anything I can help? I'm try to read the channel log | 15:09 |
*** chandankumar has joined #openstack-nova | 15:09 | |
tdurakov | alex_xu: hi, could you please read channel history, for a hour or so and provide your opinion on this | 15:10 |
alex_xu | tdurakov: yea, let me read | 15:11 |
openstackgerrit | Ed Leafe proposed openstack/nova: Fix opt description for scheduler.py https://review.openstack.org/339046 | 15:11 |
alaski | cdent: jaypipes on the generic resource pools allocation API addition, a consumer is a compute? Really my question is "is a consumer a single entity, or are there concerns about races with updates?" | 15:11 |
tdurakov | alex_xu: thanks! | 15:11 |
*** shaohe_feng has quit IRC | 15:11 | |
*** mgould|meeting is now known as mgould | 15:12 | |
*** ivase has joined #openstack-nova | 15:13 | |
*** sdake_ has quit IRC | 15:13 | |
*** ivase_ has quit IRC | 15:14 | |
*** sdake has joined #openstack-nova | 15:14 | |
cdent | alaski: for the time being a consumer id will usually be an instance, and the resource provider id will often be a compute (unless it is shared disk or something). So racing isn't really an issue on that specific request. | 15:14 |
*** pumarani__ has joined #openstack-nova | 15:14 | |
*** pushkaru has quit IRC | 15:14 | |
alex_xu | tdurakov: you should change the code for https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/test_migrate_server.py#L136-L137 | 15:14 |
cdent | alaski: where the need for care comes in is validating if the allocation is okay, which is handled by the generation stuff | 15:14 |
mriedem1 | gibi_: there are 3 versioned notifications that can still get in for newton, but need rebase - pause, resize and restore | 15:15 |
mriedem1 | gibi_: just fyi | 15:15 |
mriedem1 | i'm -2ing the rest | 15:15 |
openstackgerrit | Anusha Unnam proposed openstack/nova: Transform instance.resize notifications https://review.openstack.org/329255 | 15:15 |
tdurakov | alex_xu: yes, working on it, to do it the way it's done for key-pairs | 15:15 |
alex_xu | tdurakov: the code will like this: migrate_live_method = self.controller._migrate_live; ...execute migrate_live_method; status_init = migrate_live_method.wsgi_code | 15:16 |
*** sridharg has quit IRC | 15:16 | |
*** Daisy has joined #openstack-nova | 15:16 | |
tdurakov | alex_xu: this will not work | 15:16 |
tdurakov | alex_xu: due to api_version decorator things | 15:16 |
*** rrecio_ has joined #openstack-nova | 15:17 | |
*** ababich has quit IRC | 15:17 | |
*** rrecio has quit IRC | 15:17 | |
alex_xu | tdurakov: it works | 15:17 |
*** priteau has joined #openstack-nova | 15:17 | |
alex_xu | tdurakov: it is same with this patch https://review.openstack.org/#/c/333151/5/nova/tests/unit/api/openstack/compute/test_networks.py@405 | 15:17 |
gibi_ | mriedem1: thanks for the heads up, I'm following those up | 15:18 |
* tdurakov reading | 15:18 | |
gibi_ | mriedem1: Do I understand correctly that the deadline for those are Wednesday? | 15:18 |
alex_xu | tdurakov: and yes, it really related to api_version decorator. The reason is the implementation of Microversion only wrap the function when it executed. | 15:18 |
*** shaohe_feng has joined #openstack-nova | 15:19 | |
*** ivase_ has joined #openstack-nova | 15:19 | |
openstackgerrit | Drew Thorstensen proposed openstack/os-vif: Inclusion of PowerVM SEA VIF Type https://review.openstack.org/339059 | 15:19 |
*** ivase has quit IRC | 15:19 | |
*** mriedem has joined #openstack-nova | 15:19 | |
*** sudipto has quit IRC | 15:19 | |
alex_xu | tdurakov: the root reason is at here https://github.com/openstack/nova/blob/master/nova/api/openstack/wsgi.py#L894 | 15:19 |
jaypipes | alaski: no, a consumer is an instance UUID. | 15:20 |
tdurakov | alex_xu: yup, seen this code | 15:20 |
*** davidlenwell has quit IRC | 15:20 | |
*** Daisy has quit IRC | 15:20 | |
jaypipes | alaski: i.e. the instance is the thing consuming the resource. | 15:20 |
tdurakov | alex_xu: thanks for pointing to https://review.openstack.org/#/c/333151/5/nova/tests/unit/api/openstack/compute/test_networks.py@405 will try to do the same | 15:20 |
alex_xu | tdurakov: np | 15:21 |
*** akshai has joined #openstack-nova | 15:21 | |
alaski | cdent: jaypipes great, thanks. At some point I need to draw this all out because I can't keep the different entities straight in my head | 15:21 |
*** code-R has quit IRC | 15:21 | |
*** david-lyle__ has joined #openstack-nova | 15:21 | |
*** shaohe_feng has quit IRC | 15:22 | |
*** mpavone has quit IRC | 15:22 | |
*** jaugustine has quit IRC | 15:22 | |
*** mriedem1 has quit IRC | 15:22 | |
tdurakov | alex_xu: one more question | 15:22 |
*** shaohe_feng has joined #openstack-nova | 15:23 | |
dansmith | bauzas: jaypipes: I was just about to push a new set with the fixes for jaypipes' comments to the bottom patch | 15:23 |
dansmith | bauzas: jaypipes I just replied to bauzas' comment from a few minutes ago, so please check that and decide what you want before I push | 15:23 |
dansmith | I *really* don't understand why it matters if we have destroy and don't use it, but definitely think id should stay as it is | 15:24 |
alex_xu | tdurakov: yup, please | 15:24 |
tdurakov | alex_xu: patch you've shared depricates methods, but if there were 2 versions of the method how this one will work: https://review.openstack.org/#/c/333151/5/nova/tests/unit/api/openstack/compute/test_networks.py@405 | 15:24 |
*** ivase has joined #openstack-nova | 15:24 | |
bauzas | dansmith: I also made a reply | 15:24 |
*** david-lyle__ is now known as david-lyle | 15:24 | |
bauzas | dansmith: not sure whether it was earlier | 15:24 |
dansmith | bauzas: I just replied to your reply | 15:24 |
dansmith | like 45 seconds ago | 15:25 |
bauzas | dansmith: non-remotable is okay to me | 15:25 |
bauzas | the only concern I had was the fact it was a remotable one | 15:25 |
dansmith | okay, non-remotable means I have to change something, which I'd rather not do, | 15:25 |
dansmith | so I only want to change it if jaypipes wants it non-remotable too | 15:25 |
*** mriedem1 has joined #openstack-nova | 15:25 | |
dansmith | "this may be hard to support later" holds no water with me as I don't see why it would be hard later | 15:25 |
alex_xu | tdurakov: the microversion is read from the HTTPRequest object, there is example at line 715 | 15:25 |
*** ivase_ has quit IRC | 15:26 | |
alex_xu | tdurakov: so specify the version you want to run | 15:26 |
*** mriedem has quit IRC | 15:26 | |
tdurakov | alex_xu: ok, let me try this:) | 15:26 |
alex_xu | tdurakov: without version means to request min version | 15:27 |
*** shyama has quit IRC | 15:28 | |
bauzas | dansmith: well, I was rather thinking of us finding that a .delete_by_rp(rp_id ) signature would be better in the future | 15:28 |
openstackgerrit | John Garbutt proposed openstack/nova: Don't cache RPC pin when service_version is 0 https://review.openstack.org/339072 | 15:28 |
dansmith | bauzas: okay, but I don't see why that would make supporting the current thing hard later, especially if it's not used | 15:29 |
johnthetubaguy | dansmith: I am curious what you think about this bug and my fix idea: https://review.openstack.org/#/c/339072 | 15:29 |
*** andreas_s has quit IRC | 15:29 | |
*** davidlenwell has joined #openstack-nova | 15:30 | |
*** ivase_ has joined #openstack-nova | 15:30 | |
*** ctrath has quit IRC | 15:30 | |
dansmith | johnthetubaguy: ah, like if everything has been down for more than a few minutes we get a zero result? | 15:30 |
bauzas | dansmith: well, it was tied to the point I was wondering whether it was good to expose the allocation.id field | 15:30 |
*** ivase has quit IRC | 15:30 | |
dansmith | johnthetubaguy: if we made it to this part of the code, haven't we already brought ourselves up such that we wouldn't get zero? | 15:30 |
bauzas | dansmith: but anyway, let's leave jaypipes voice on it | 15:31 |
tdurakov | alex_xu: awesome, works | 15:31 |
tdurakov | alex_xu: thanks a lot! | 15:31 |
johnthetubaguy | dansmith: I think this is initial deploy, if you start nova-conductor before your nova-compute is up | 15:32 |
*** shaohe_feng has quit IRC | 15:32 | |
dansmith | johnthetubaguy: ah, right, right, okay | 15:32 |
*** ctrath has joined #openstack-nova | 15:32 | |
*** Daisy has joined #openstack-nova | 15:32 | |
dansmith | johnthetubaguy: so are we far enough along that we could just change that service logic so that if you get zero, you assume latest instead of oldest? | 15:32 |
cfriesen__ | do we record anywhere in the instance that it's on an LVM backend? (as opposed to qcow2) | 15:32 |
*** shaohe_feng has joined #openstack-nova | 15:33 | |
alex_xu | tdurakov: np :) | 15:33 |
johnthetubaguy | dansmith: so that was the other way I was thinking about this, we could move the zero version up to 2.11 or something? | 15:33 |
mriedem1 | apparently we don't have a functional api test for listing keypairs by a specific user_id | 15:33 |
*** mriedem1 is now known as mriedem | 15:33 | |
cfriesen__ | I'm trying to prevent an attempted live migration from an LVM backend to a host with a qcow2 backend...currently it doesn't error out until after it has started the migratin. | 15:33 |
dansmith | johnthetubaguy: I guess, but after we're past the support interval of "before we added service-version" then a zero actually means we're a fresh deploy right? | 15:35 |
dansmith | johnthetubaguy: I guess maybe you could still get into trouble if the deployment is off for a couple hours and then you start back up and everything has moved on | 15:35 |
alex_xu | johnthetubaguy: good point on https://review.openstack.org/#/c/334747, i missed that point, it sounds like a microversion, maybe we should bring that to api meeting to confirm that. | 15:35 |
dansmith | johnthetubaguy: I dunno, could go either way | 15:35 |
*** ivase has joined #openstack-nova | 15:36 | |
johnthetubaguy | dansmith: oh, thats true, if we cache the old version and we are on a fresh install, its a bit odd | 15:36 |
*** ivase_ has quit IRC | 15:36 | |
johnthetubaguy | dansmith: yeah, I am leaning towards just skip the cache until its non-zero, seems simpler | 15:36 |
dansmith | johnthetubaguy: yeah, probably safer to just not assume if we have no data | 15:37 |
johnthetubaguy | yeah | 15:37 |
*** cdent has quit IRC | 15:37 | |
*** Daisy has quit IRC | 15:37 | |
*** jaugustine has joined #openstack-nova | 15:37 | |
*** tbachman_ has joined #openstack-nova | 15:37 | |
mriedem | pkholkin: fyi https://bugs.launchpad.net/nova/+bug/1599904 | 15:38 |
openstack | Launchpad bug 1599904 in OpenStack Compute (nova) "There is no API sample functional test for listing keypairs for another user" [Medium,Triaged] | 15:38 |
*** tbachman has quit IRC | 15:39 | |
*** tbachman_ is now known as tbachman | 15:39 | |
*** cdent has joined #openstack-nova | 15:39 | |
openstackgerrit | Lee Yarwood proposed openstack/nova: compute: Refresh connection_info on migration rollback https://review.openstack.org/338929 | 15:39 |
dansmith | johnthetubaguy: maybe not cache and select the latest? because this is still going to do the wrong thing, it's just not going to cache it right? | 15:40 |
*** dimtruck is now known as zz_dimtruck | 15:40 | |
*** Satya_ has joined #openstack-nova | 15:41 | |
Satya_ | Hi Everyone | 15:41 |
openstackgerrit | Dan Smith proposed openstack/nova: Add Allocation and AllocationList objects https://review.openstack.org/282442 | 15:41 |
openstackgerrit | Dan Smith proposed openstack/nova: Add support for resource inventories to placement API https://review.openstack.org/329152 | 15:41 |
openstackgerrit | Dan Smith proposed openstack/nova: Implement ResourceProvider.destroy() https://review.openstack.org/337925 | 15:41 |
Satya_ | I have a intresting question Can i boot a VM without glance? | 15:41 |
openstackgerrit | Dan Smith proposed openstack/nova: Add initial framing of placement API https://review.openstack.org/329149 | 15:41 |
openstackgerrit | Dan Smith proposed openstack/nova: Add a Usage and UsageList object https://review.openstack.org/329575 | 15:41 |
openstackgerrit | Dan Smith proposed openstack/nova: Add support for resource_providers urls https://review.openstack.org/329151 | 15:42 |
*** GB21 has joined #openstack-nova | 15:42 | |
*** ivase_ has joined #openstack-nova | 15:42 | |
openstackgerrit | Dan Smith proposed openstack/nova: Add support for usages in the placement API https://review.openstack.org/329643 | 15:42 |
openstackgerrit | Dan Smith proposed openstack/nova: Improve 404 and 405 response tests https://review.openstack.org/331483 | 15:42 |
dansmith | jaypipes: bauzas: I propose we just move forward with the CRUD operations as they are ^ | 15:42 |
*** yamahata has quit IRC | 15:42 | |
*** ivase has quit IRC | 15:42 | |
dansmith | if we don't use them, we can remove them without much trouble | 15:42 |
*** shaohe_feng has quit IRC | 15:42 | |
bauzas | okay, I trust you :) | 15:42 |
diana_clarke | mriedem, dansmith: Are there any other tempest tests that need written for this release? I have one up for review. Figured I might as well write a few more (if need be) to learn more on this front, | 15:43 |
*** TravT_ is now known as TravT | 15:43 | |
*** shaohe_feng has joined #openstack-nova | 15:43 | |
mriedem | diana_clarke: i have a not so easy one probably | 15:43 |
diana_clarke | mriedem: I'm willing to try ;) | 15:43 |
Satya_ | does anyone aware of it? | 15:43 |
dansmith | diana_clarke: your tempest test is doing the thing we said not to do, right? | 15:43 |
diana_clarke | dansmith: For now, anyway. | 15:44 |
*** Daisy has joined #openstack-nova | 15:44 | |
*** gjayavelu has joined #openstack-nova | 15:44 | |
mriedem | diana_clarke: L18 here https://etherpad.openstack.org/p/newton-nova-meetup | 15:44 |
*** fragatina has quit IRC | 15:45 | |
*** liverpooler has joined #openstack-nova | 15:46 | |
mriedem | auggy: get down on it https://bugs.launchpad.net/nova/+bug/1599911 | 15:46 |
openstack | Launchpad bug 1599911 in OpenStack Compute (nova) "os-keypairs api-ref doesn't include user_id request parameter for listing keypairs for another user" [Medium,Triaged] | 15:46 |
*** paul-carlton2 has quit IRC | 15:47 | |
* mriedem hopes someone likes kool and the gang | 15:47 | |
*** ivase has joined #openstack-nova | 15:48 | |
*** sdake has quit IRC | 15:48 | |
*** ivase_ has quit IRC | 15:48 | |
*** pcaruana has quit IRC | 15:49 | |
*** Daisy has quit IRC | 15:49 | |
openstackgerrit | Lee Yarwood proposed openstack/nova: compute: Refresh connection_info on migration rollback https://review.openstack.org/338929 | 15:49 |
*** Daisy has joined #openstack-nova | 15:49 | |
*** gongysh has quit IRC | 15:50 | |
edleafe | markus_z: around? Got a config option question | 15:50 |
dansmith | mriedem: heh | 15:50 |
*** sdake has joined #openstack-nova | 15:51 | |
*** roeyc1 has joined #openstack-nova | 15:51 | |
*** roeyc has quit IRC | 15:51 | |
mriedem | dansmith: alaski: alex_xu: pkholkin: so listing keypairs with name as a marker has some issues | 15:52 |
mriedem | name is only unique per user | 15:52 |
*** shaohe_feng has quit IRC | 15:52 | |
dansmith | mriedem: I saw your comment | 15:52 |
mriedem | and you can only list keypairs for other users after v2.10 | 15:52 |
dansmith | good catch | 15:52 |
mriedem | but i guess with the paging stuff it's 2.34 now or something | 15:53 |
johnthetubaguy | is it always one other user? | 15:53 |
*** ivase_ has joined #openstack-nova | 15:53 | |
mriedem | so i guess with the paging stuff for keypairs we can know that another user_id can be passed in, else it just uses the context | 15:53 |
johnthetubaguy | i.e. the list is only ever for one user still? | 15:53 |
mriedem | johnthetubaguy: yes | 15:53 |
*** shaohe_feng has joined #openstack-nova | 15:53 | |
*** pumarani__ has quit IRC | 15:53 | |
mriedem | my worry was what the next link would look like | 15:53 |
mriedem | because if the marker is based on a name within a given user_id context, then the next link has to maintain that specific user_id | 15:54 |
johnthetubaguy | yeah, it does, good point | 15:54 |
alex_xu | mriedem: good point | 15:54 |
mriedem | but id as marker also has issues | 15:54 |
*** mmandel has quit IRC | 15:54 | |
*** Daisy has quit IRC | 15:54 | |
*** ivase has quit IRC | 15:54 | |
mriedem | because keypair 3 could be user A and keypair 4 could be user B | 15:54 |
dansmith | mriedem: why does that matter? | 15:54 |
mriedem | i guess if you're paging, you just need all keypairs for user A with id>3 | 15:54 |
mriedem | dansmith: it doesn't | 15:55 |
dansmith | mriedem: we hand them marker and they can't know | 15:55 |
dansmith | okay | 15:55 |
mriedem | yeah i was just thinking through this out loud | 15:55 |
dansmith | gotcha | 15:55 |
*** chhavi_ has joined #openstack-nova | 15:55 | |
*** Daisy has joined #openstack-nova | 15:55 | |
*** derekh has quit IRC | 15:55 | |
alex_xu | mriedem: sounds ok for id | 15:56 |
*** cdent has quit IRC | 15:56 | |
alex_xu | mriedem: oops, i got you, same problem with user_id even use id | 15:56 |
*** dharinic_ has joined #openstack-nova | 15:56 | |
*** klkumar has quit IRC | 15:56 | |
*** zenoway has quit IRC | 15:57 | |
*** cdent has joined #openstack-nova | 15:58 | |
*** jaugustine has quit IRC | 15:58 | |
mriedem | bleh | 15:58 |
*** rama_y has joined #openstack-nova | 15:58 | |
auggy | mriedem: what did I do now??? | 15:58 |
*** ivase has joined #openstack-nova | 15:59 | |
* auggy is on vacation this week hence the radio silence | 15:59 | |
*** ivase_ has quit IRC | 15:59 | |
mriedem | auggy: just figured you'd want to fix an easy api-ref bug | 15:59 |
mriedem | feel free to go back to the price is right | 15:59 |
auggy | Oh thx!! | 16:00 |
*** Daisy has quit IRC | 16:00 | |
auggy | Ha-ha oh man, I think they were filming that in pdx recently or something | 16:00 |
*** tbachman has quit IRC | 16:00 | |
*** code-R has joined #openstack-nova | 16:01 | |
*** Daisy has joined #openstack-nova | 16:01 | |
alex_xu | mriedem: looks like the exised code already take care the query parameters https://github.com/openstack/nova/blob/master/nova/api/openstack/common.py#L423 | 16:01 |
mriedem | alex_xu: yeah, was just looking at novaclient | 16:02 |
mriedem | DEBUG (connectionpool:395) "GET /v2.1/os-keypairs?user_id=7f245aee48a74b62a974a015567f2efb HTTP/1.1" 200 16 | 16:02 |
mriedem | i wasn't sure if user_id was a query or body parameter | 16:02 |
mriedem | so the next link will copy the query parameters, and throw the limit/marker on their for the next link | 16:02 |
alex_xu | mriedem: it is a query param | 16:02 |
mriedem | yup | 16:02 |
mriedem | ok, so i'm not as scared | 16:02 |
*** shaohe_feng has quit IRC | 16:03 | |
*** code-R_ has joined #openstack-nova | 16:03 | |
openstackgerrit | bailin.zhang proposed openstack/nova: Unplug vifs when VM create failed https://review.openstack.org/331113 | 16:03 |
*** shaohe_feng has joined #openstack-nova | 16:03 | |
mriedem | alex_xu: i'd feel better if we fixed bug 1599904 | 16:04 |
openstack | bug 1599904 in OpenStack Compute (nova) "There is no API sample functional test for listing keypairs for another user" [Medium,Triaged] https://launchpad.net/bugs/1599904 - Assigned to Anusha Unnam (anusha-unnam) | 16:04 |
mriedem | and had a functional api sample for testing listing keypairs for another user | 16:04 |
*** Daisy has quit IRC | 16:05 | |
*** ivase_ has joined #openstack-nova | 16:05 | |
*** ivase has quit IRC | 16:05 | |
*** code-R has quit IRC | 16:06 | |
*** Daisy has joined #openstack-nova | 16:06 | |
gcb | nova core reviewers, I have been working on make nova unit test woks same with production environment when using method set_override from oslo.config | 16:06 |
gcb | and have some commits ready for review : https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1517839 | 16:07 |
*** jlanoux has quit IRC | 16:08 | |
gcb | please help review them when you are free,thanks | 16:08 |
*** armax has joined #openstack-nova | 16:09 | |
*** sdake has quit IRC | 16:09 | |
mriedem | gcb: a lot of the tests use self.flags which calls CONF.set_override | 16:09 |
mriedem | gcb: could we just isolate everything through self.flags and add a hacking rule for not using CONF.set_override in tests? | 16:09 |
*** rcernin has quit IRC | 16:10 | |
*** ivase has joined #openstack-nova | 16:10 | |
openstackgerrit | Sarafraj Singh proposed openstack/nova: Use auth_type instead of auth_plugin https://review.openstack.org/307498 | 16:11 |
*** Daisy has quit IRC | 16:11 | |
*** ivase_ has quit IRC | 16:11 | |
*** Daisy has joined #openstack-nova | 16:12 | |
gcb | mriedem I planned to set enforce_type=True in each place , but it seems ugly , then I decided to only fix violations in consuming projects | 16:12 |
*** paul-carlton2 has joined #openstack-nova | 16:13 | |
mriedem | gcb: i'm saying, self.flags in the base nova test should pass enforce_type=True, | 16:13 |
mriedem | and we convert all CONF.set_override in nova's tests to use self.flags | 16:13 |
*** shaohe_feng has quit IRC | 16:13 | |
mriedem | and add a nova hacking rule to not use CONF.set_override | 16:13 |
mriedem | else we'll just keep hitting these if enforce_type=False is the default in oslo.config | 16:13 |
gcb | and set enforce_type =True in oslo.config | 16:13 |
*** shaohe_feng has joined #openstack-nova | 16:14 | |
mriedem | gcb: that's certainly a backward incompatible API change in oslo.config and would require a major version bump when releasing that from the lib | 16:14 |
mriedem | does set_override emit a warning when enforce_type=False today? | 16:15 |
gcb | I think CONF.set_override and self.flag are both OK, in some place we can only use CONF.set_override | 16:15 |
*** mmandel has joined #openstack-nova | 16:15 | |
*** dedery has joined #openstack-nova | 16:15 | |
gcb | no | 16:15 |
*** Daisy has quit IRC | 16:16 | |
*** ivase_ has joined #openstack-nova | 16:16 | |
*** dedery has quit IRC | 16:16 | |
*** gjayavelu has quit IRC | 16:17 | |
*** ivase has quit IRC | 16:17 | |
mriedem | gcb: i guess warning on enforce_type=False would be bad if i actually wanted it to be False | 16:17 |
mriedem | so should only warn if it's going away | 16:17 |
*** Daisy has joined #openstack-nova | 16:17 | |
gcb | enfore_type=False means don't check config option's value , that's bad as I know | 16:18 |
gcb | you can find my plan in https://bugs.launchpad.net/oslo.config/+bug/1517839 | 16:18 |
openstack | Launchpad bug 1517839 in OpenStack Compute (nova) "Make CONF.set_override with parameter enforce_type=True by default" [Low,In progress] - Assigned to Pallavi (pallavi-s) | 16:18 |
*** gjayavelu has joined #openstack-nova | 16:18 | |
*** nkrinner is now known as nkrinner_afk | 16:18 | |
gcb | I agree we need a version bump if we set enforce_type=True by default in oslo.config | 16:19 |
*** sdake has joined #openstack-nova | 16:20 | |
*** diga has quit IRC | 16:21 | |
*** M00nr41n has joined #openstack-nova | 16:21 | |
gcb | self.flags is only available for the test which inherits from class TestCase in https://github.com/openstack/nova/blob/master/nova/test.py#L165 | 16:22 |
gcb | that means we still need CONF.set_override in nova | 16:22 |
*** ivase has joined #openstack-nova | 16:22 | |
mriedem | gcb: which is every test in nova | 16:22 |
alaski | mriedem: just catching up, is using name any more of an issue than anything else with listing for other users? It seemed like the end result was that everything is fine? | 16:22 |
mriedem | gcb: sure but we can change def flags in nova to pass enforce_type=True to https://github.com/openstack/nova/blob/master/nova/test.py#L285 | 16:23 |
*** jianghuaw has joined #openstack-nova | 16:23 | |
*** tesseract- has quit IRC | 16:23 | |
mriedem | gcb: and then have a hacking rule so that no unit tests in nova use CONF.set_override | 16:23 |
*** ivase_ has quit IRC | 16:23 | |
mriedem | and all go through self.flags so we can control / enforce that check there | 16:23 |
*** shaohe_feng has quit IRC | 16:23 | |
alaski | mriedem: dansmith to be clear I'm fine with using 'id' for this, but someone should -1 and say that | 16:23 |
mriedem | alaski: i think ultimately it's fine | 16:23 |
mriedem | the db queries are wrong for checking the marker, those need to use user_id for filtering | 16:24 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Cleanup test_create_configdrive https://review.openstack.org/339114 | 16:24 |
alaski | mriedem: yeah, definitely | 16:24 |
mriedem | but the next link will copy the query params so we should be ok there | 16:24 |
*** shaohe_feng has joined #openstack-nova | 16:24 | |
mriedem | if the marker is id, then the sorting can't be on name | 16:24 |
gcb | mriedem , we can do that after we fix violations | 16:24 |
openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova: Remove context object in oslo.log method https://review.openstack.org/317109 | 16:24 |
alaski | mriedem: right, I assume the sort should match the marker | 16:25 |
*** sdake has quit IRC | 16:25 | |
*** ssurana has joined #openstack-nova | 16:25 | |
mriedem | and sorting by name is nice, but you could also do that in the client | 16:25 |
alaski | yeah | 16:26 |
dansmith | mriedem: I can't tell what you're arguing for | 16:26 |
mriedem | gdi | 16:26 |
mriedem | i'm just, | 16:26 |
mriedem | gdi | 16:26 |
dansmith | you seem to be saying that you're okay with name markers? | 16:27 |
mriedem | i don't have a strong opinion either way really, name is new and weird so i feel weird about it | 16:27 |
*** abalutoiu has quit IRC | 16:27 | |
dansmith | okay | 16:27 |
dansmith | seems like id is the most clear and simple way to go to me | 16:27 |
*** sdake has joined #openstack-nova | 16:27 | |
mriedem | id would certainly make the marker check simpler | 16:28 |
*** Daisy has quit IRC | 16:28 | |
mriedem | and be consistent with some other paging support we have | 16:28 |
*** ivase_ has joined #openstack-nova | 16:28 | |
mriedem | someone put out a smoke signal to sdague in the woods to get his 2 cents | 16:28 |
mriedem | i'm going to lunch | 16:28 |
*** ivase has quit IRC | 16:28 | |
mriedem | unicode in the next link could be goofy | 16:28 |
dansmith | right that was a point I had earlier | 16:29 |
alaski | true, but we already allow querying by name | 16:29 |
gcb | mriedem, I will change def flags in nova to pass enforce_type=True after we merged the commits of fixing violations | 16:29 |
alaski | name is the primary way to lookup a keypair | 16:29 |
*** ducttape_ has quit IRC | 16:29 | |
dansmith | alaski: I don't see what that has to do with the marker | 16:29 |
alaski | nothing, just that I don't think we should worry about having name in the next link | 16:30 |
dansmith | okay | 16:30 |
mriedem | oh right, i forgot that 'id' in the REST API code is actually keyname in the keypair API | 16:30 |
mriedem | gdi i hate that also | 16:30 |
mriedem | but when i tried to change that shit broke | 16:30 |
mriedem | it done broke | 16:30 |
*** tpatzig has quit IRC | 16:30 | |
*** mkoderer has quit IRC | 16:30 | |
*** haplo37_ has joined #openstack-nova | 16:31 | |
*** tpatzig has joined #openstack-nova | 16:31 | |
alaski | yeah, our api params are weird | 16:31 |
dansmith | "weird" is a really nice way to put it | 16:31 |
mriedem | so given that point i'm probably less weirded out by name being the marker | 16:31 |
*** mkoderer has joined #openstack-nova | 16:31 | |
*** BobBall is now known as BobBall_AWOL | 16:32 | |
mriedem | anyway, food | 16:32 |
*** gcb has quit IRC | 16:32 | |
*** mriedem is now known as mriedem_fudd | 16:32 | |
dansmith | I totally don't understand what the marker has to do with anything | 16:32 |
dansmith | our marker could be "page number" for all the client should care about it | 16:32 |
PaulMurray | pci question coming up....... | 16:32 |
PaulMurray | hypervisor-show doesn't list pci devices | 16:33 |
PaulMurray | do you think it should ? | 16:33 |
alaski | dansmith: right. that's why I'm fine just leaving name there as it is now | 16:33 |
PaulMurray | I'm trying to think about where that should go | 16:33 |
dansmith | alaski: whatever, you guys merge it then :) | 16:33 |
*** paul-carlton2 has quit IRC | 16:33 | |
*** shaohe_feng has quit IRC | 16:33 | |
*** ivase has joined #openstack-nova | 16:34 | |
*** Daisy has joined #openstack-nova | 16:34 | |
*** ivase_ has quit IRC | 16:34 | |
alaski | dansmith: I'm also fine with id. we just need one person to care enough to say "this is what it's going to be!" | 16:34 |
*** chhavi_ has quit IRC | 16:34 | |
*** shaohe_feng has joined #openstack-nova | 16:34 | |
*** shz has joined #openstack-nova | 16:35 | |
PaulMurray | jaypipes, any thoughts on pci qeustion above ? | 16:37 |
*** lpetrut has quit IRC | 16:37 | |
*** shihanzhang has quit IRC | 16:37 | |
*** Daisy has quit IRC | 16:39 | |
cfriesen__ | PaulMurray: I think it should, at least for admin | 16:39 |
*** ivase_ has joined #openstack-nova | 16:39 | |
PaulMurray | cfriesen__, I was also wondering what form it should take - I think we only have access to the device pools summary in the database | 16:40 |
*** sahid has quit IRC | 16:40 | |
*** ivase has quit IRC | 16:40 | |
PaulMurray | it does seem like the obvious place for it - unless people think it should be a neutron thing | 16:41 |
lbeliveau | PaulMurray: pci_devices in the db has the state (available, allocated, etc.) of each PCI devices | 16:41 |
cfriesen__ | PaulMurray: technically we can support pci devices that aren't NICs | 16:41 |
PaulMurray | cfriesen__, true - good point | 16:41 |
*** cfriesen__ is now known as cfriesen | 16:42 | |
openstackgerrit | Vasyl Saienko proposed openstack/nova: WIP: Set vnic_type for Ironic instances https://review.openstack.org/339124 | 16:42 |
*** eantyshev has joined #openstack-nova | 16:43 | |
*** shaohe_feng has quit IRC | 16:44 | |
*** shaohe_feng has joined #openstack-nova | 16:44 | |
*** Daisy has joined #openstack-nova | 16:45 | |
*** yamahata has joined #openstack-nova | 16:45 | |
*** unicell has quit IRC | 16:45 | |
*** ivase has joined #openstack-nova | 16:45 | |
*** ivase_ has quit IRC | 16:46 | |
PaulMurray | lbeliveau, of course you're right - I did some patch up work before on device pools and seems I completely forgot the devices are there | 16:46 |
*** browne has joined #openstack-nova | 16:46 | |
* PaulMurray goes back to actually looking at the code | 16:46 | |
*** paul-carlton2 has joined #openstack-nova | 16:47 | |
*** tyrola has quit IRC | 16:47 | |
*** lucasagomes is now known as lucas|afk | 16:48 | |
*** Apoorva has joined #openstack-nova | 16:48 | |
lbeliveau | PaulMurray: so PciDevices could be filtered out by node id for a given hypervisor | 16:49 |
*** Apoorva has quit IRC | 16:49 | |
pkholkin | mriedem_fudd: very sorry, missed the discussion ( | 16:49 |
pkholkin | saw that bug, will look | 16:49 |
*** Daisy has quit IRC | 16:50 | |
pkholkin | copied you discussion, will read | 16:50 |
PaulMurray | lbeliveau, PciDeviceList.get_by_compute_node() | 16:50 |
pkholkin | mriedem_fudd: so, what was the decision? | 16:50 |
PaulMurray | yep - so that's pretty much all we need | 16:50 |
pkholkin | will look the comments in the patch too | 16:50 |
lbeliveau | PaulMurray: yeah forgot about it :) | 16:50 |
*** cdent has quit IRC | 16:50 | |
pkholkin | alaski: ^ | 16:51 |
*** Daisy has joined #openstack-nova | 16:51 | |
*** ivase_ has joined #openstack-nova | 16:51 | |
alaski | pkholkin: there's no strong decision, but there's more comfort with using id than name | 16:52 |
*** paul-carlton2 has quit IRC | 16:52 | |
*** ivase has quit IRC | 16:52 | |
pkholkin | alaski: shouldn't be the same problems if using ID? | 16:52 |
alaski | I think everything is mostly the same either way. however id does avoid the issue of a new entry being missed while paging | 16:53 |
*** shaohe_feng has quit IRC | 16:54 | |
dansmith | pkholkin: hint: I think alaski and mriedem_fudd will approve it if you leave it as name | 16:54 |
pkholkin | do you that problem with unstable order? (when some kp becomes in the middle of the response)? | 16:54 |
pkholkin | dansmith: :) | 16:54 |
dansmith | pkholkin: so just "forget" to ping me and you should be golden | 16:54 |
*** shaohe_feng has joined #openstack-nova | 16:55 | |
pkholkin | dansmith: I will think about you suggestion :) | 16:55 |
*** Daisy has quit IRC | 16:55 | |
pkholkin | as for me, I like names | 16:55 |
dansmith | it's okay to be wrong | 16:56 |
dansmith | if you weren't wrong then I wouldn't be right, and that's not as fun, so... :D | 16:56 |
pkholkin | :) | 16:56 |
*** Daisy has joined #openstack-nova | 16:56 | |
pkholkin | unfortunately I can't merge it myself :) | 16:56 |
openstackgerrit | Ed Leafe proposed openstack/nova: Fix opt group and type for scheduler.py https://review.openstack.org/339136 | 16:57 |
*** ivase has joined #openstack-nova | 16:57 | |
pkholkin | dansmith: do you like IDs? | 16:57 |
dansmith | pkholkin: I friggin LOVE them | 16:57 |
*** Apoorva has joined #openstack-nova | 16:57 | |
pkholkin | okay) | 16:57 |
openstackgerrit | John Garbutt proposed openstack/nova: Don't cache RPC pin when service_version is 0 https://review.openstack.org/339072 | 16:57 |
*** ivase_ has quit IRC | 16:58 | |
*** jwcroppe has joined #openstack-nova | 16:58 | |
*** yamahata has quit IRC | 16:58 | |
*** yamahata has joined #openstack-nova | 16:58 | |
*** cdelatte has quit IRC | 16:58 | |
*** gjayavelu has quit IRC | 17:00 | |
pkholkin | alaski: dansmith: would it be ok that in spec we have 'marker=name' ? | 17:00 |
* pkholkin thinking about changing) | 17:00 | |
alaski | yes. we amend specs when things change | 17:00 |
*** PaulMurray has quit IRC | 17:01 | |
pkholkin | ok | 17:01 |
*** ctrath has quit IRC | 17:01 | |
dansmith | pkholkin: but not for things like this where three people like a thing and one person does not | 17:02 |
*** roeyc1 has quit IRC | 17:02 | |
*** jwcroppe has quit IRC | 17:02 | |
*** Sukhdev has joined #openstack-nova | 17:02 | |
markus_z | edleafe: yep, I'm back again, 1on1 took longer than expected | 17:02 |
*** klindgren__ is now known as klindgren | 17:02 | |
pkholkin | hm | 17:02 |
edleafe | markus_z: the question is about the check_opt_group_and_type | 17:03 |
*** ivase_ has joined #openstack-nova | 17:03 | |
edleafe | markus_z: Should we be creating new groups for things that kind of go together? | 17:03 |
*** ivase has quit IRC | 17:03 | |
edleafe | markus_z: Or is the intent something else? | 17:04 |
markus_z | edleafe: creating new groups is OK | 17:04 |
*** cleong has quit IRC | 17:04 | |
*** shaohe_feng has quit IRC | 17:04 | |
edleafe | markus_z: for example, in scheduler.py, there are a couple of 'baremetal' options | 17:05 |
markus_z | edleafe: wrt to the scheduler options, it's valid to create a new group called "scheduler" | 17:05 |
*** shaohe_feng has joined #openstack-nova | 17:05 | |
edleafe | does that require a 'baremetal' or 'ironic' group? | 17:05 |
edleafe | markus_z: same for 'isolated hosts / images' | 17:05 |
markus_z | let me have a short glance on them | 17:05 |
edleafe | k | 17:06 |
*** Daisy has quit IRC | 17:07 | |
markus_z | edleafe: honestly, I think having a group "scheduler" for generic options and another group "scheduler_baremetal" could be reasonable. | 17:07 |
*** dingboopt has quit IRC | 17:08 | |
markus_z | The specific scope is scheduling, and some are restricted to the compute node type | 17:08 |
markus_z | IOW, I wouldn't move the "*_baremetal_*" scheduler options into the "ironic" group. | 17:08 |
*** ivase has joined #openstack-nova | 17:08 | |
edleafe | markus_z: so that will require a code change anywhere those options are used, along with a reno? | 17:09 |
markus_z | I'm not entirely sure if I could make myself clear. | 17:09 |
markus_z | edleafe: yes | 17:09 |
markus_z | very low risk code changes IMO | 17:09 |
*** ivase_ has quit IRC | 17:10 | |
edleafe | markus_z: low risk, sure, but high merge conflict potential :) | 17:10 |
markus_z | right, I tend to suppress that :) | 17:11 |
*** sdake has quit IRC | 17:11 | |
*** ducttape_ has joined #openstack-nova | 17:11 | |
markus_z | Maybe is the early start of Ocata the best point in time for group changes? | 17:11 |
markus_z | uh, very bad English, it's getting late | 17:11 |
edleafe | markus_z: better than my German | 17:12 |
openstackgerrit | John Garbutt proposed openstack/nova: WIP: sketch of set vnic_type correctly for ironic https://review.openstack.org/339143 | 17:12 |
markus_z | :) we practice that in Barcelona | 17:12 |
sneti | hi johnthetubaguy, gibi_ Can you please review my versioned notifications patch. I've resolved the merge conflicts. https://review.openstack.org/#/c/329141/ | 17:12 |
edleafe | markus_z: so hold off on the group changes until Ocata? | 17:12 |
*** tbachman has joined #openstack-nova | 17:12 | |
markus_z | I wouldn't necessarily do them as the very first item, yes | 17:12 |
markus_z | the very first prio is still to create a proper help text | 17:13 |
edleafe | markus_z: well, it's group *and* type in the flag | 17:13 |
*** Daisy has joined #openstack-nova | 17:13 | |
edleafe | markus_z: I'm trying to clear the flags | 17:13 |
markus_z | hm, *thinks* | 17:14 |
*** ivase_ has joined #openstack-nova | 17:14 | |
markus_z | No, doing this as one of the last items would be the best IMO | 17:14 |
*** baoli has quit IRC | 17:14 | |
*** shaohe_feng has quit IRC | 17:14 | |
markus_z | And start of Ocata should be the best timeframe to deal with the possible merge conflicts | 17:15 |
edleafe | markus_z: ok, I'll drop that one and focus on the others | 17:15 |
*** ivase has quit IRC | 17:15 | |
octopuszhang | this patch needs review,thanks. https://review.openstack.org/#/c/317306/ | 17:15 |
*** ducttape_ has quit IRC | 17:15 | |
markus_z | Cool, thanks :) | 17:15 |
*** shaohe_feng has joined #openstack-nova | 17:15 | |
markus_z | edleafe: You've already seen http://45.55.105.55:8082/config-options.html ? | 17:16 |
markus_z | nice and shiny :) | 17:16 |
edleafe | markus_z: yes, that's what I'm working from | 17:16 |
markus_z | great | 17:16 |
*** kenperkins has joined #openstack-nova | 17:17 | |
*** Daisy has quit IRC | 17:17 | |
*** ducttape_ has joined #openstack-nova | 17:18 | |
*** unicell has joined #openstack-nova | 17:19 | |
kenperkins | so I'm not super familiar with how nova API is implemented; are administrative nova apis different than end user apis? are they the same but using repose for access control? trying to gain some insight here | 17:19 |
*** chenfei has quit IRC | 17:20 | |
*** zz_dimtruck is now known as dimtruck | 17:20 | |
*** Qiming has quit IRC | 17:20 | |
*** chenfei has joined #openstack-nova | 17:20 | |
*** ivase_ has quit IRC | 17:20 | |
*** ivase has joined #openstack-nova | 17:20 | |
kenperkins | pointers to code would be great | 17:21 |
alaski | kenperkins: repose is not related to the nova api. it can be deployed in front as a proxy for rate limiting and auth, but it's not specific to nova as I understand it | 17:22 |
*** danpb has quit IRC | 17:22 | |
kenperkins | ok good clarification ty | 17:22 |
alaski | there's no fundamental difference between user and admin apis in nova, just different policy controls | 17:22 |
*** GB21 has quit IRC | 17:23 | |
kenperkins | can you expand on "policy controls" ? not familiar with that | 17:24 |
*** shz has quit IRC | 17:24 | |
kenperkins | I'm look at https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L579 trying to find the code that implements `self.compute_api.create` | 17:24 |
alaski | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1461 | 17:25 |
*** shaohe_feng has quit IRC | 17:25 | |
*** shihanzhang has joined #openstack-nova | 17:25 | |
*** jed56 has quit IRC | 17:25 | |
kenperkins | ty | 17:25 |
alaski | nova uses the olso.policy library to check the context object against predefined policies | 17:25 |
alaski | with the relevant bits in the context being provided by calling out to keystone | 17:25 |
alaski | it's mostly checking roles and comparing the project_id | 17:26 |
*** ivase_ has joined #openstack-nova | 17:26 | |
alaski | some admin rules are defined in http://git.openstack.org/cgit/openstack/nova/tree/nova/policies/admin_actions.py | 17:26 |
melwitt | gate-tempest-dsvm-postgres-full has been having a SSHTimeout extravaganza lately | 17:26 |
alaski | kenperkins: the actual policy check looks like https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L515 | 17:27 |
*** shyama has joined #openstack-nova | 17:27 | |
kenperkins | reading | 17:27 |
*** ivase has quit IRC | 17:27 | |
*** shaohe_feng has joined #openstack-nova | 17:27 | |
openstackgerrit | John Garbutt proposed openstack/nova: WIP: sketch of set vnic_type correctly for ironic https://review.openstack.org/339143 | 17:28 |
openstackgerrit | Charles Volzka proposed openstack/nova: Add memory metric monitor https://review.openstack.org/288848 | 17:28 |
john5223 | Hello all. So I am trying to write a custom quota driver for nova. The reserve function currently gets the deltas for the servers requested. anyone know if there is a way to access the actual flavors requested? ( https://github.com/openstack/nova/blob/stable/mitaka/nova/quota.py#L486 ) | 17:29 |
*** xavvior has quit IRC | 17:30 | |
*** ivase has joined #openstack-nova | 17:32 | |
*** mgould is now known as mgould|afk | 17:32 | |
*** sdake has joined #openstack-nova | 17:32 | |
*** ivase_ has quit IRC | 17:32 | |
*** unicell has quit IRC | 17:33 | |
*** unicell1 has joined #openstack-nova | 17:33 | |
*** sdake_ has joined #openstack-nova | 17:34 | |
kenperkins | alaski: maybe you can help; I notice that `GET /servers/<id>` returns `tenant_id` as part of the response, but I can't find in this implementation where tenant_id is provided either to the create | 17:34 |
kenperkins | do you know/where tenant id comes through | 17:35 |
*** code-R_ has quit IRC | 17:35 | |
*** shaohe_feng has quit IRC | 17:35 | |
*** shaohe_feng has joined #openstack-nova | 17:36 | |
edleafe | kenperkins: it is part of the auth credentials that are sent with the create call | 17:37 |
*** sdake has quit IRC | 17:37 | |
edleafe | kenperkins: either tenant_name or tenant_id | 17:37 |
*** ivase_ has joined #openstack-nova | 17:37 | |
*** Qiming has joined #openstack-nova | 17:38 | |
*** ivase has quit IRC | 17:38 | |
*** salv-orlando has joined #openstack-nova | 17:38 | |
*** rlrossit has quit IRC | 17:38 | |
*** salv-orl_ has quit IRC | 17:39 | |
kenperkins | hey edleafe | 17:40 |
kenperkins | would that be what context.user_id is here: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L513 | 17:40 |
alaski | it ultimately ends up in the context, after being verified with keystone | 17:40 |
alaski | http://git.openstack.org/cgit/openstack/nova/tree/nova/api/auth.py#n120 | 17:40 |
edleafe | hey kenperkins | 17:40 |
kenperkins | sounds like yep | 17:40 |
alaski | context.project_id | 17:40 |
kenperkins | project_id is what? | 17:41 |
alaski | same as tenant_id | 17:41 |
kenperkins | oh project_id is tenant_id? | 17:41 |
alaski | yeah | 17:41 |
*** lpetrut has joined #openstack-nova | 17:41 | |
edleafe | kenperkins: for today. Maybe we'll change it again next year :) | 17:41 |
kenperkins | heh | 17:42 |
kenperkins | so long story short; there are just "api"s in nova, and policy checks like https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L515 is where access control is checked | 17:42 |
kenperkins | but otherwise, it's not like you have one admin api for get_instance, and another end user api for the same function | 17:42 |
alaski | correct | 17:43 |
edleafe | kenperkins: yeah. Not a separate endpoint | 17:43 |
kenperkins | are there cases where the response changes as a function of context? | 17:43 |
kenperkins | i.e. more properties if you have administrative context? | 17:43 |
*** ivase has joined #openstack-nova | 17:43 | |
alaski | yes | 17:43 |
alaski | I'm not sure if there's anything on instance | 17:44 |
*** ivase_ has quit IRC | 17:44 | |
alaski | but instance-actions and instance-action-events have more data if admin | 17:44 |
alaski | instance-faults as well I believe | 17:44 |
alaski | so I guess an instance in an error state might | 17:44 |
kenperkins | <looking> | 17:45 |
edleafe | kenperkins: I just fixed a bug that was due to extra info being fetched for admins: https://review.openstack.org/335648 | 17:45 |
edleafe | kenperkins: so yeah, the response can differ | 17:45 |
*** shaohe_feng has quit IRC | 17:45 | |
alaski | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/views/servers.py#L278-L282 | 17:46 |
*** shaohe_feng has joined #openstack-nova | 17:46 | |
kenperkins | perfect thank you for that example alaski | 17:46 |
*** M00nr41n has quit IRC | 17:47 | |
kenperkins | edleafe: looking back to your familiarity with rackspace's nova implementation, was the auth check done by repose mutually exclusive to auth checks done in nova proper? | 17:47 |
kenperkins | or does repose actually set auth data on the proxied call to nova | 17:47 |
* edleafe clears those old cobwebs | 17:48 | |
*** markus_z has quit IRC | 17:48 | |
edleafe | kenperkins: IIRC, repose didn't actually create the context nova needs | 17:48 |
kenperkins | ok | 17:48 |
edleafe | kenperkins: the Rackspace auth did that | 17:48 |
*** ivase has quit IRC | 17:49 | |
*** ivase_ has joined #openstack-nova | 17:49 | |
edleafe | kenperkins: dolphm would be a better source than I | 17:50 |
*** phuongnh has joined #openstack-nova | 17:50 | |
*** lpetrut has quit IRC | 17:50 | |
kenperkins | thanks edleafe | 17:51 |
*** hemna has quit IRC | 17:51 | |
*** tbachman_ has joined #openstack-nova | 17:52 | |
*** tbachman has quit IRC | 17:52 | |
*** tbachman_ is now known as tbachman | 17:52 | |
*** daemontool has quit IRC | 17:52 | |
*** catintheroof has joined #openstack-nova | 17:53 | |
*** ducttape_ has quit IRC | 17:53 | |
*** jaugustine has joined #openstack-nova | 17:53 | |
*** M00nr41n has joined #openstack-nova | 17:54 | |
*** rlrossit has joined #openstack-nova | 17:54 | |
openstackgerrit | octopuszhang proposed openstack/nova: Allow irrelevant,self-defined specs in ComputeCapacityFilter https://review.openstack.org/317306 | 17:54 |
*** mriedem_fudd is now known as mriedem | 17:55 | |
*** ivase has joined #openstack-nova | 17:55 | |
*** M00nr41n has quit IRC | 17:55 | |
*** hemna has joined #openstack-nova | 17:55 | |
*** salv-orlando has quit IRC | 17:55 | |
*** shaohe_feng has quit IRC | 17:55 | |
*** ivase_ has quit IRC | 17:56 | |
*** shaohe_feng has joined #openstack-nova | 17:56 | |
openstackgerrit | Alexandre Levine proposed openstack/nova: POC Imagebackend complete refactoring. PLEASE DO NOT REVIEW. https://review.openstack.org/336921 | 17:56 |
mriedem | melwitt: postgresql job ssh timeout extravaganza? | 17:57 |
*** sdake_ has quit IRC | 17:57 | |
melwitt | mriedem: I'm seeing a lot of ssh timeout fails in that job the past two days | 17:57 |
mriedem | http://tinyurl.com/zx6fabn | 17:58 |
*** tjones has joined #openstack-nova | 17:58 | |
mriedem | melwitt: it's not just that job | 17:58 |
*** jwcroppe has joined #openstack-nova | 17:58 | |
*** salv-orlando has joined #openstack-nova | 17:58 | |
mriedem | melwitt: that is the top gate bug though http://status.openstack.org//elastic-recheck/index.html#1355573 | 17:59 |
*** igordcard has quit IRC | 17:59 | |
*** igordcard has joined #openstack-nova | 17:59 | |
melwitt | a-ha | 18:01 |
*** ivase_ has joined #openstack-nova | 18:01 | |
*** gjayavelu has joined #openstack-nova | 18:01 | |
mriedem | seems to have started spiking around 7/5 | 18:01 |
*** ivase has quit IRC | 18:01 | |
mriedem | those are nova-net jobs too | 18:01 |
mriedem | melwitt: actually you're right | 18:02 |
mriedem | it's just the postgres job | 18:02 |
*** lpetrut has joined #openstack-nova | 18:02 | |
mriedem | mtreinish: what's special about the postgres job again besides the metadata service? | 18:02 |
*** baoli has joined #openstack-nova | 18:03 | |
*** jwcroppe has quit IRC | 18:04 | |
*** david-lyle has quit IRC | 18:04 | |
*** bharath has quit IRC | 18:05 | |
*** ducttape_ has joined #openstack-nova | 18:05 | |
melwitt | mriedem: I think you're right based on the logstash query from the e-r status page there are other jobs in there too | 18:05 |
openstackgerrit | Sujitha proposed openstack/nova: Add user_id request parameter in os-keypairs list https://review.openstack.org/339166 | 18:05 |
*** gjayavelu has quit IRC | 18:05 | |
*** ducttape_ has quit IRC | 18:05 | |
mriedem | melwitt: there are other jobs but postgres is by far the main failure | 18:05 |
mriedem | if you look at build_name | 18:05 |
melwitt | yeah | 18:06 |
*** shaohe_feng has quit IRC | 18:06 | |
mriedem | http://goo.gl/ZIDYil | 18:06 |
*** david-lyle has joined #openstack-nova | 18:06 | |
mriedem | so the job uses nova-net and it runs the metadata service | 18:06 |
mriedem | i think it's other wrinkle was it used to run keystone with eventlet, but that's gone | 18:06 |
*** shaohe_feng has joined #openstack-nova | 18:06 | |
mriedem | clarkb: am i missing anything about what's special about the postgres job besides the nova metadata api? | 18:07 |
*** ivase has joined #openstack-nova | 18:07 | |
*** jaugustine has quit IRC | 18:07 | |
john5223 | So in order to get flavor passed to my custom quota driver i need to change nova compute api here?? https://github.com/openstack/nova/blob/master/nova/compute/api.py#L292 ? that sucks its not already given to quota driver and only delta is | 18:07 |
*** jaugustine has joined #openstack-nova | 18:08 | |
mriedem | custom quota driver? | 18:08 |
*** ivase_ has quit IRC | 18:08 | |
*** ctrath has joined #openstack-nova | 18:08 | |
mriedem | dansmith: alaski: johnthetubaguy: weren't we going to deprecate https://github.com/openstack/nova/blob/master/nova/conf/quota.py#L89 for classloading? | 18:09 |
dansmith | mriedem: by definition I would think | 18:09 |
*** haleyb has joined #openstack-nova | 18:10 | |
john5223 | yeah. trying to write a quota based off a billing module instead of set limits on instances, cores, etc | 18:10 |
john5223 | quota driver* | 18:10 |
*** efoley has quit IRC | 18:11 | |
alaski | mriedem: dansmith we do have two quota drivers in tree which is probably why it wasn't deprecated | 18:11 |
clarkb | mriedem: keystone is/was run with eventlet in that job | 18:11 |
clarkb | mriedem: but otherwise shouldn't be anything special | 18:11 |
mriedem | alaski: yeah but we have 2 in tree scheduler managers too | 18:11 |
mriedem | we could just use choices for that | 18:11 |
dansmith | alaski: so we should enforce that it's those two values | 18:11 |
alaski | yeah, no reason not to do that | 18:12 |
dansmith | I shall | 18:12 |
*** sheel has joined #openstack-nova | 18:12 | |
mriedem | rax doesn't have a special quota driver? or is that just special quota classes/flavor classes? | 18:12 |
*** ivase_ has joined #openstack-nova | 18:12 | |
alaski | they have quota classes, but I don't think it plugged in there | 18:12 |
clarkb | mriedem: I do know that rax iad had issues iirc | 18:12 |
clarkb | possible its related to that | 18:13 |
*** ivase has quit IRC | 18:13 | |
mriedem | clarkb: yeah the failures are mostly in rax nodes too but then we should see the same rate of failures for non-pg jobs | 18:13 |
mriedem | which we don't | 18:13 |
clarkb | ya I do not know why that particular job would be affected more | 18:15 |
melwitt | mriedem: I'm not sure if this is relevant, failed to get user-data from the metadata service http://logs.openstack.org/21/299621/7/check/gate-tempest-dsvm-postgres-full/e935cfa/console.html#_2016-07-07_16_57_07_105179 | 18:15 |
clarkb | oh ya if ^ that fails then ssh won't work | 18:15 |
*** TravT_ has joined #openstack-nova | 18:15 | |
john5223 | so guess i'll just modify nova compute api to pass along the instance_type for now. no other way to get that request data from inside QuotaDriver right? | 18:16 |
*** shaohe_feng has quit IRC | 18:16 | |
*** baoli has quit IRC | 18:17 | |
dansmith | mriedem: alaski: Hmm, I thought ListOpt had a "valid values" type thing, but it seems like not | 18:17 |
*** shaohe_feng has joined #openstack-nova | 18:17 | |
*** gyee has joined #openstack-nova | 18:17 | |
*** gjayavelu has joined #openstack-nova | 18:17 | |
*** prateek has joined #openstack-nova | 18:17 | |
mriedem | dansmith: the choices kwarg | 18:17 |
*** gjayavelu has quit IRC | 18:17 | |
mriedem | dansmith: however, if you use that now before it's deprecated then it's a straight up break for anything not in the choices list | 18:18 |
dansmith | mriedem: so? | 18:18 |
openstackgerrit | Alexandre Levine proposed openstack/nova: POC Imagebackend complete refactoring. PLEASE DO NOT REVIEW. https://review.openstack.org/336921 | 18:18 |
mriedem | we've had a deprecation period for the other pluggable managers | 18:18 |
*** ivase has joined #openstack-nova | 18:18 | |
dansmith | I didn't think we did | 18:18 |
mriedem | network_api_class is still deprecated but pluggable | 18:18 |
mriedem | re: gluon | 18:18 |
*** ivase_ has quit IRC | 18:18 | |
dansmith | uncool | 18:18 |
*** TravT has quit IRC | 18:19 | |
mriedem | hooks are still deprecated, etc | 18:19 |
mriedem | i think we have to have a deprecation period to signal it's going away first | 18:19 |
dansmith | hooks are different, but fine | 18:19 |
*** eglynn has quit IRC | 18:19 | |
*** TravT_ has quit IRC | 18:21 | |
jaypipes | mgould|afk: omg, the extra_specs_ops filter in the Nova scheduler is the devil incarnate, I know... | 18:21 |
jaypipes | mgould|afk: but if you REALLY want to pull your remaining hair out, check out the matching in the ComputeCapabilitiesFilter. | 18:21 |
dansmith | mriedem: there are probably some things marked deprecated that need culling from the looks of it | 18:22 |
*** sameo_ has quit IRC | 18:22 | |
* jaypipes puts on some old metallica and prepares for Gerrit battle. | 18:22 | |
*** jaugustine has quit IRC | 18:23 | |
*** ivase_ has joined #openstack-nova | 18:24 | |
john5223 | I added a compute monitor for ssd and then rewrote ComputeCapabilitiesFilter a little to be able to add metadata to flavor for choosing SSD instead of doing host aggregates. that was fun :) | 18:24 |
*** ivase has quit IRC | 18:25 | |
*** code-R has joined #openstack-nova | 18:25 | |
john5223 | thought i had a bug until i relized there was <all> and <all-in> | 18:25 |
alaski | dansmith: mriedem yeah, I was also under the impression that we needed a deprecation timeperiod | 18:25 |
jaypipes | john5223: yeah, it's awful... | 18:26 |
dansmith | alaski: I dunno, I can see why, but on the other hand, if we don't consider something other than those two to be a valid valid, then just adding constraints shouldn't require a notification period | 18:26 |
dansmith | but that's fine | 18:26 |
mriedem | john5223: fyi, you're hacking a bunch of pluggable stuff that may not be pluggable in the near future | 18:26 |
*** shaohe_feng has quit IRC | 18:26 | |
mriedem | like the compute monitor | 18:26 |
mriedem | and quota driver | 18:26 |
*** mpavone has joined #openstack-nova | 18:26 | |
*** mpavone has quit IRC | 18:27 | |
john5223 | will you be switching to entry points or not pluggable at all? | 18:27 |
alaski | dansmith: it's mostly just a signal to say if you need to keep doing this custom thing open a spec upstream for it | 18:27 |
*** shaohe_feng has joined #openstack-nova | 18:27 | |
dansmith | mriedem: I believe network_api is fair game now, as it was deprecated in mitaka | 18:27 |
*** code-R_ has joined #openstack-nova | 18:27 | |
mriedem | john5223: not pluggable at all | 18:28 |
mriedem | dansmith: yeah | 18:28 |
dansmith | mriedem: I shall do that one after this | 18:28 |
alaski | john5223: the idea is that if what you're doing is valuable propose it for inclusion in upstream | 18:28 |
*** eharney has quit IRC | 18:29 | |
openstackgerrit | Dan Smith proposed openstack/nova: Deprecate the quota_driver config option https://review.openstack.org/339173 | 18:29 |
*** ivase has joined #openstack-nova | 18:29 | |
*** code-R has quit IRC | 18:30 | |
*** ivase_ has quit IRC | 18:30 | |
*** armax_ has joined #openstack-nova | 18:32 | |
john5223 | why would you take away ability to make things pluggable though? isn't that whats so great about openstack | 18:33 |
*** jaugustine has joined #openstack-nova | 18:33 | |
mriedem | john5223: it's a barrier to interoperability for one, | 18:34 |
jaypipes | john5223: no :) we want things to behave the same from one installation to another. | 18:34 |
jaypipes | what mriedem said :) | 18:34 |
mriedem | also, people ask for changes in the upstream code to enable things in their out of tree drivers, like the issue yo'ure having with not having the flavor from the request when reserving quota | 18:34 |
dansmith | +1 | 18:34 |
*** armax has quit IRC | 18:34 | |
*** armax_ is now known as armax | 18:34 | |
mriedem | and we don't test these unversioned interfaces, so we can break them, and break people using them, and then they come with bugs and expect fixes | 18:34 |
*** shyama has quit IRC | 18:35 | |
*** ivase_ has joined #openstack-nova | 18:36 | |
*** ivase has quit IRC | 18:36 | |
*** shaohe_feng has quit IRC | 18:36 | |
openstackgerrit | Andrew Laski proposed openstack/nova: WIP Create Instance from BuildRequest if not in a cell https://review.openstack.org/263927 | 18:37 |
*** shaohe_feng has joined #openstack-nova | 18:37 | |
john5223 | mriedem: is that everyone or just nova? i noticed keystone changed from plugins to entrypoints. is keystone keeping those entry points as far as you know? | 18:37 |
mriedem | john5223: nova is definitely more strict about entrypoints/plugins than the other openstack projects | 18:38 |
dansmith | john5223: keystone is in a different spot in the stack, and plugins for different backend auths make more sense to me | 18:38 |
john5223 | k cool | 18:39 |
dansmith | john5223: there's really no reason to override the quota driver except to make it behave differently | 18:39 |
*** rcernin has joined #openstack-nova | 18:39 | |
john5223 | b/c i have a lot of plugins for keystone too :) | 18:39 |
dansmith | and that's what we want to avoid | 18:39 |
mriedem | john5223: do you have a lot of API extensions as well? | 18:39 |
john5223 | and thats what i'm trying to do. ha :) i want no hard limit quotas, and only a billing limit quota | 18:39 |
john5223 | no API extensions currently | 18:39 |
*** ivase_ has quit IRC | 18:41 | |
*** ivase has joined #openstack-nova | 18:41 | |
openstackgerrit | Sarafraj Singh proposed openstack/nova: Case-sensitive neutron security groups https://review.openstack.org/302095 | 18:43 |
*** jianghuaw has quit IRC | 18:44 | |
*** ljxiash has quit IRC | 18:44 | |
*** claudiub has joined #openstack-nova | 18:45 | |
*** dharinic_ has quit IRC | 18:45 | |
*** baoli has joined #openstack-nova | 18:46 | |
*** shaohe_feng has quit IRC | 18:47 | |
*** ivase_ has joined #openstack-nova | 18:47 | |
*** ivase has quit IRC | 18:47 | |
*** shaohe_feng has joined #openstack-nova | 18:48 | |
openstackgerrit | Dan Smith proposed openstack/nova: Remove deprecated network_api_class option https://review.openstack.org/339184 | 18:48 |
*** woodster_ has quit IRC | 18:49 | |
*** jaugustine has quit IRC | 18:49 | |
sneti | Hi mriedem, I was looking at this bug: https://bugs.launchpad.net/nova/+bug/1494841. This was moved to wish list and also has a bp which is not yet approved. https://blueprints.launchpad.net/nova/+spec/filter-nova-manage-vm-list. Can I work on this? | 18:50 |
openstack | Launchpad bug 1494841 in OpenStack Compute (nova) "nova-manage vm list active" [Wishlist,Confirmed] - Assigned to Sujitha (sujitha-neti) | 18:50 |
*** Sukhdev has quit IRC | 18:50 | |
*** jaugustine has joined #openstack-nova | 18:50 | |
mriedem | sneti: hmm, why can't they use the rest api? | 18:52 |
*** ivase has joined #openstack-nova | 18:53 | |
mriedem | sneti: for the most part, nova-manage is meant to be deprecated / feature frozen | 18:53 |
*** tbachman has quit IRC | 18:53 | |
*** ivase_ has quit IRC | 18:54 | |
*** daemontool has joined #openstack-nova | 18:54 | |
sneti | mriedem, that is true. nova-manage is mostly deprecated. In that case, the bug can be moved to Wont Fix or Invalid right | 18:54 |
mriedem | kfox1111: ^? | 18:54 |
mriedem | you reported the bug kfox1111 | 18:54 |
*** tbachman has joined #openstack-nova | 18:54 | |
openstackgerrit | Dao Cong Tien proposed openstack/nova: Ironic Driver: override get_serial_console() https://review.openstack.org/328157 | 18:55 |
*** jianghuaw has joined #openstack-nova | 18:56 | |
*** sambetts is now known as sambetts|afk | 18:57 | |
*** rrecio_ has quit IRC | 18:57 | |
*** shaohe_feng has quit IRC | 18:57 | |
*** shaohe_feng has joined #openstack-nova | 18:58 | |
*** ociuhandu has quit IRC | 18:58 | |
*** rrecio has joined #openstack-nova | 18:58 | |
*** ivase_ has joined #openstack-nova | 18:59 | |
*** ivase has quit IRC | 18:59 | |
*** baoli has quit IRC | 19:00 | |
mriedem | melwitt: i think the user-data thing is a red herring | 19:00 |
*** f10d4 has quit IRC | 19:00 | |
*** f10d4 has joined #openstack-nova | 19:00 | |
*** baoli has joined #openstack-nova | 19:00 | |
openstackgerrit | Andrew Laski proposed openstack/nova: Create Instance from BuildRequest if not in a cell https://review.openstack.org/263927 | 19:01 |
openstackgerrit | Andrew Laski proposed openstack/nova: instance.name should be blank if instance.id is not set https://review.openstack.org/327342 | 19:01 |
openstackgerrit | Andrew Laski proposed openstack/nova: Bump service version for BuildRequest deletion https://review.openstack.org/332478 | 19:01 |
openstackgerrit | Andrew Laski proposed openstack/nova: Stop instance build if BuildRequest deleted https://review.openstack.org/332479 | 19:01 |
openstackgerrit | Andrew Laski proposed openstack/nova: Add block_device_mappings to BuildRequest https://review.openstack.org/334095 | 19:01 |
openstackgerrit | Andrew Laski proposed openstack/nova: Cells: Handle delete with BuildRequest https://review.openstack.org/325985 | 19:01 |
*** armax_ has joined #openstack-nova | 19:01 | |
*** EinstCra_ has quit IRC | 19:01 | |
*** EinstCrazy has joined #openstack-nova | 19:02 | |
mriedem | melwitt: unless this is a separate bug http://logs.openstack.org/21/299621/7/check/gate-tempest-dsvm-postgres-full/e935cfa/logs/screen-n-api-meta.txt.gz#_2016-07-07_16_55_22_094 | 19:02 |
*** tbachman has quit IRC | 19:02 | |
*** armax has quit IRC | 19:03 | |
*** armax_ is now known as armax | 19:03 | |
*** zhs_s has joined #openstack-nova | 19:04 | |
*** lpetrut has quit IRC | 19:04 | |
*** ivase has joined #openstack-nova | 19:05 | |
*** jwcroppe has joined #openstack-nova | 19:05 | |
*** jwcroppe has quit IRC | 19:05 | |
*** jwcroppe has joined #openstack-nova | 19:05 | |
*** ivase_ has quit IRC | 19:05 | |
haleyb | mriedem: can you take a look at https://review.openstack.org/#/c/313070/ ? it's a follow-on from some other neutron and nova changes to make sure the hypervisor doesn't auto-configure an IPv6 address on it's bridges | 19:05 |
*** zhs_ss has quit IRC | 19:06 | |
*** shaohe_feng has quit IRC | 19:07 | |
*** jaugustine has quit IRC | 19:07 | |
*** jaugustine has joined #openstack-nova | 19:08 | |
*** shaohe_feng has joined #openstack-nova | 19:08 | |
*** jaugustine has quit IRC | 19:08 | |
*** jaugustine has joined #openstack-nova | 19:09 | |
*** ivase_ has joined #openstack-nova | 19:10 | |
*** ivase has quit IRC | 19:11 | |
*** prateek has quit IRC | 19:12 | |
*** salv-orlando has quit IRC | 19:12 | |
*** woodster_ has joined #openstack-nova | 19:13 | |
openstackgerrit | Alexandre Levine proposed openstack/nova: POC Imagebackend complete refactoring. PLEASE DO NOT REVIEW. https://review.openstack.org/336921 | 19:14 |
*** ivase has joined #openstack-nova | 19:16 | |
*** ivase_ has quit IRC | 19:17 | |
*** shaohe_feng has quit IRC | 19:17 | |
*** shaohe_feng has joined #openstack-nova | 19:18 | |
*** kodoku has quit IRC | 19:20 | |
*** ivase has quit IRC | 19:22 | |
*** ivase_ has joined #openstack-nova | 19:22 | |
*** ametts has quit IRC | 19:23 | |
*** bogdan has joined #openstack-nova | 19:24 | |
*** cdelatte has joined #openstack-nova | 19:25 | |
bogdan | hi, I am trying to run Nova with Libvirt LXC and instances seems to be fine but I cannot attach LVM based Cinder volumes, is this functionality by design available, should I look for errors in my config or is it completely non-supported combination? Thank! | 19:25 |
*** jaugustine has quit IRC | 19:25 | |
*** chandankumar has quit IRC | 19:26 | |
*** jaugustine has joined #openstack-nova | 19:27 | |
*** ivase has joined #openstack-nova | 19:27 | |
mriedem | bogdan: not supported http://docs.openstack.org/developer/nova/support-matrix.html#operation_attach_volume | 19:28 |
*** shaohe_feng has quit IRC | 19:28 | |
*** baoli has quit IRC | 19:28 | |
*** ivase_ has quit IRC | 19:29 | |
bogdan | mriedem, how about this then https://bugs.launchpad.net/nova/+bug/1330981? it sounds as if it is fixed... | 19:29 |
openstack | Launchpad bug 1330981 in OpenStack Compute (nova) "Cannot attach volumes to LXC instances" [Undecided,Fix released] - Assigned to Vladik Romanovsky (vladik-romanovsky) | 19:29 |
mriedem | bogdan: huh, well, we have an lxc ci job | 19:30 |
mriedem | let's see if that attaches volumes | 19:30 |
*** Jeffrey4l_ has quit IRC | 19:31 | |
*** shaohe_feng has joined #openstack-nova | 19:31 | |
bogdan | mriedem, what is this lxc ci job? | 19:31 |
mriedem | it is legend | 19:31 |
*** Jeffrey4l_ has joined #openstack-nova | 19:31 | |
*** jaugustine has quit IRC | 19:32 | |
bogdan | sorry, I am a bit new to the space, not aware of all the terminology, what is legend :)? | 19:32 |
mriedem | a joke, sec | 19:32 |
mriedem | we have a ci job that tests with lxc | 19:32 |
mriedem | but it's in the experimental job queue, because it mostly doesn't work | 19:32 |
*** tonytan4ever has quit IRC | 19:32 | |
mriedem | bogdan: i.e. http://logs.openstack.org/21/336921/13/experimental/gate-tempest-dsvm-lxc-f23/7e7cc2e/ | 19:32 |
*** tbachman has joined #openstack-nova | 19:32 | |
bogdan | I would need it for experimental workloads, not for productive | 19:32 |
siva_krishnan | Can someone please help me in creating network with with vlan id. I tried following command 'nova network-create public --fixed-range-v4 100.0.0.0/24 --vlan 100' but with no sucess. Let me know if any config option needs to be changed | 19:33 |
*** ivase_ has joined #openstack-nova | 19:33 | |
f10d4 | 11 | 19:33 |
mriedem | bogdan: apparently we don't test volumes in that job, tempest is configured to not run cinder | 19:33 |
*** baoli has joined #openstack-nova | 19:34 | |
*** ivase has quit IRC | 19:34 | |
mriedem | because devstack disables it | 19:34 |
bogdan | hm, so you mean there is no chance to run volumes on LXC instances? | 19:35 |
mriedem | bogdan: https://github.com/openstack-dev/devstack/blob/master/lib/tempest#L534 | 19:35 |
mriedem | bogdan: i'm saying we don't test it today in this ci job and our support matrix says it's not supported for lxc, but as you noted, there was a bug that 'fixed' it | 19:35 |
bogdan | how about Docker instances? I do not see it mentioned on that page at all | 19:35 |
mriedem | bogdan: nova-docker is an out of tree driver for nova | 19:35 |
mriedem | so we don't keep track of it's support matrix | 19:36 |
mriedem | the virtuozzo driver (libvirt) in nova is for containers and supports attaching volumes in the newton release (master) | 19:36 |
bogdan | Ok, maybe I talk to the author of the bugfix... I saw that the code that was "fixed" in Juno is not available in Liberty for example ... so probably this fix somehow did not survive in later releases | 19:36 |
mriedem | vladikr: ^? | 19:36 |
mriedem | vladikr is the one that 'fixed' https://bugs.launchpad.net/nova/+bug/1330981 | 19:37 |
openstack | Launchpad bug 1330981 in OpenStack Compute (nova) "Cannot attach volumes to LXC instances" [Undecided,Fix released] - Assigned to Vladik Romanovsky (vladik-romanovsky) | 19:37 |
bogdan | yep | 19:37 |
vladikr | mriedem, bogdan, looking | 19:37 |
bogdan | 10x :) | 19:37 |
mriedem | thomasem: do you know if you can attach volumes with lxc in nova? | 19:38 |
*** shaohe_feng has quit IRC | 19:38 | |
vladikr | mriedem, bogdan, I think this one intended to fix the "boot from volume" scenario for lxc, not sure if it works for hot attach (I assume this is what you are trying to do) | 19:38 |
bogdan | yes | 19:38 |
*** shaohe_feng has joined #openstack-nova | 19:39 | |
*** TravT has joined #openstack-nova | 19:39 | |
bogdan | vladikr, so I could still have some larger image to boot from and later use it as regular volume for storage? | 19:39 |
bogdan | would that work? | 19:39 |
*** ivase has joined #openstack-nova | 19:39 | |
*** ivase_ has quit IRC | 19:39 | |
openstackgerrit | Alex Szarka proposed openstack/nova: Typo error fix https://review.openstack.org/339203 | 19:40 |
*** MikeG451 has quit IRC | 19:41 | |
openstackgerrit | Jay Pipes proposed openstack/nova: rt: Pass nodename to internal RT methods https://review.openstack.org/334031 | 19:41 |
openstackgerrit | Jay Pipes proposed openstack/nova: rt: Pass the nodename to RT.instance_claim() https://review.openstack.org/334032 | 19:41 |
openstackgerrit | Jay Pipes proposed openstack/nova: rt: Pass nodename into RT.re[build|size]_claim() https://review.openstack.org/334033 | 19:41 |
openstackgerrit | Jay Pipes proposed openstack/nova: rt: Remove RT.nodename attribute entirely https://review.openstack.org/334034 | 19:41 |
openstackgerrit | Jay Pipes proposed openstack/nova: rt: Add virt driver get_inventory() method https://review.openstack.org/334035 | 19:41 |
openstackgerrit | Andrew Laski proposed openstack/nova: Create Instance from BuildRequest if not in a cell https://review.openstack.org/263927 | 19:41 |
openstackgerrit | Jay Pipes proposed openstack/nova: rt: Implement Hyper-V get_inventory() method https://review.openstack.org/334036 | 19:41 |
openstackgerrit | Jay Pipes proposed openstack/nova: rt: Add get_inventory() implementation for vCenter https://review.openstack.org/334037 | 19:41 |
openstackgerrit | Andrew Laski proposed openstack/nova: instance.name should be blank if instance.id is not set https://review.openstack.org/327342 | 19:41 |
openstackgerrit | Jay Pipes proposed openstack/nova: rt: Add get_inventory() method for Ironic https://review.openstack.org/334038 | 19:41 |
thomasem | mriedem: I do not. That is one of those features we haven't checked out yet, I'm afraid. I'm assuming you're talking about Cinder volumes? | 19:41 |
openstackgerrit | Jay Pipes proposed openstack/nova: rt: Implement XenAPI get_inventory() method https://review.openstack.org/339204 | 19:41 |
mriedem | kfox1111: so novaclient isn't going to work for you? | 19:41 |
openstackgerrit | Andrew Laski proposed openstack/nova: Cells: Handle delete with BuildRequest https://review.openstack.org/325985 | 19:41 |
mriedem | thomasem: yeah | 19:41 |
vladikr | bogdan, I'm not exactly sure what you mean. I'm trying to say that you should be able to use a volume as your root and boot from it. However, I don't think you can add any more volumes to lxc which are not root | 19:41 |
*** mdrabe has quit IRC | 19:41 | |
thomasem | Yeah, haven't exercised that code path yet, I'm afraid. :( | 19:41 |
thomasem | I'm going to bet that it'll fail, though. | 19:42 |
thomasem | But, worth a shot. | 19:42 |
vladikr | bogdan, If you have logs available somewhere, I can take a look | 19:42 |
thomasem | Just requires some perms, like mknod, I think. | 19:42 |
bogdan | vladikr, I've sent you some logs to your email (@enovance) earlier today, will paste it here too now | 19:43 |
vladikr | bogdan, enovance was long ago ;) | 19:43 |
*** Apoorva has quit IRC | 19:43 | |
*** ociuhandu has joined #openstack-nova | 19:44 | |
bogdan | vladikr, sorry didn't know that :), here it is http://paste.openstack.org/show/527034/ | 19:44 |
bogdan | thomasem, were you referring my case with the mknod perms? I have no idea what that is :) | 19:45 |
*** ivase_ has joined #openstack-nova | 19:45 | |
*** mdrabe has joined #openstack-nova | 19:45 | |
openstackgerrit | Jay Pipes proposed openstack/nova-specs: resource-providers: Populate allocation fields https://review.openstack.org/300177 | 19:45 |
jaypipes | alaski: addressed your review comments on ^^, thanks! | 19:45 |
*** ivase has quit IRC | 19:46 | |
jaypipes | dansmith: oh? what's using ResourceProvider already? | 19:47 |
bogdan | vladikr, mriedem, thomasem, I will try out the scenario that vladikr suggested - have a root volume, but in case I fail with that one I would ask a more generic question - if LXC instances cannot attach volumes, what would you recommend for a lightweight hypervisor or other container technology that would support volumes? | 19:47 |
dansmith | jaypipes: see the previous comments? | 19:47 |
jaypipes | dansmith: save me from looking up the comments :) | 19:47 |
dansmith | jaypipes: the code is still in compute node that creates a RP and Inventory, and that happens over the wire | 19:47 |
jaypipes | hmm, I thought we'd removed that when we reverted the migration stuff. | 19:48 |
*** Apoorva has joined #openstack-nova | 19:48 | |
vladikr | bogdan, it looks like a similar issue that was with the root disks, but will need to look into that. I think it would be best if you'll open a bug | 19:48 |
dansmith | jaypipes: well (a) I thought you had too, but just because you remove all the code that used it and then re-add it later does't mean you get to reset the version history :D | 19:48 |
dansmith | hmm, put a (b) in there somewhere | 19:48 |
*** shaohe_feng has quit IRC | 19:48 | |
mtreinish | mriedem: those are the 2 things now. Back in the day postgres used to deploy keystone with eventlet,but thats not a thing anymore. Fwiw, it's all in the job def: https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/devstack-gate.yaml#L1759 | 19:49 |
*** tonytan4ever has joined #openstack-nova | 19:49 | |
*** lpetrut has joined #openstack-nova | 19:49 | |
bogdan | vladikr, I will do that but let me first check your suggestion with the root volume | 19:50 |
openstackgerrit | STEW TY proposed openstack/nova: Complete verification of servers-action-fixed-ip.inc https://review.openstack.org/338606 | 19:51 |
*** shaohe_feng has joined #openstack-nova | 19:51 | |
jaypipes | dansmith: oh... so create_inventory() and update_inventory() are the only places that ever used those objects, and those methods aren't called from anywhere... so should be safe to remove (since the inventories and allocations and resource_providers tables those methods were writing to were in the cell DB anyway and those tables are worthless now that all that has been moved to the API database. | 19:51 |
*** ivase has joined #openstack-nova | 19:51 | |
*** ivase_ has quit IRC | 19:51 | |
*** bvanhav has quit IRC | 19:51 | |
dansmith | jaypipes: they are called from the scheduler client code | 19:51 |
jaypipes | ffs | 19:52 |
dansmith | jaypipes: and, it does't really matter what DB they are or were in.. if we sent them over the wire, we could encounter some deployment that still has that code from a couple weeks ago | 19:52 |
dansmith | jaypipes: what's the big deal? it's just a bump | 19:52 |
jaypipes | yeah, no, there's no big deal | 19:52 |
jaypipes | dansmith: I was just sure I'd removed all of that stuff.. | 19:53 |
dansmith | jaypipes: I thought so too, but it still doesn't matter, IMHO | 19:53 |
jaypipes | dansmith: I'd still like to remove all that code. | 19:53 |
dansmith | without the bump a CDer would get a really (really) strange message if something new called that new method against an older node | 19:53 |
*** bogdan_ has joined #openstack-nova | 19:53 | |
dansmith | jaypipes: but your spec says we're doing that exact thing :) | 19:54 |
* dansmith hasn't checked for a spec update yet | 19:54 | |
jaypipes | dansmith: which spec? the allocation one or the compute-node-inventory-newton one? | 19:54 |
*** bogdan has quit IRC | 19:54 | |
dansmith | jaypipes: the allocation one says (or said yesterday) that we'd be just using the objects directly from RT, which is what that code is doing (but for inventory) | 19:55 |
*** tonytan_brb has joined #openstack-nova | 19:55 | |
jaypipes | dansmith: I've amended that allocations spec to call the placement REST API (that didn't exist) for allocations per your request yesterday afternoon. | 19:55 |
jaypipes | dansmith: and amended the generic resource pools spec with additional REST API calls for setting the allocations for a consumer. | 19:56 |
bogdan_ | vladikr, any suggestion on how can I build LXC image that contains the OS and is at the same time 50 gigs larger? would you point me to an article or something? | 19:56 |
*** tonytan4ever has quit IRC | 19:56 | |
dansmith | jaypipes: okay, so, IMHO, we should remove those in the same patch where we start making REST calls out of them | 19:56 |
*** ivase_ has joined #openstack-nova | 19:57 | |
jaypipes | dansmith: sounds like a good plan. | 19:57 |
dansmith | jaypipes: changes to that second patch of cdent's for your comments just now coming up | 19:57 |
jaypipes | dansmith: I've abandoned the patch where I was doing the update via objects.ResourceProvider.set_inventory() BTW. | 19:57 |
openstackgerrit | Dan Smith proposed openstack/nova: Add support for resource inventories to placement API https://review.openstack.org/329152 | 19:57 |
openstackgerrit | Dan Smith proposed openstack/nova: Implement ResourceProvider.destroy() https://review.openstack.org/337925 | 19:57 |
openstackgerrit | Dan Smith proposed openstack/nova: Add initial framing of placement API https://review.openstack.org/329149 | 19:57 |
openstackgerrit | Dan Smith proposed openstack/nova: Add a Usage and UsageList object https://review.openstack.org/329575 | 19:57 |
openstackgerrit | Dan Smith proposed openstack/nova: Add support for resource_providers urls https://review.openstack.org/329151 | 19:57 |
openstackgerrit | Dan Smith proposed openstack/nova: Add support for usages in the placement API https://review.openstack.org/329643 | 19:57 |
openstackgerrit | Dan Smith proposed openstack/nova: Improve 404 and 405 response tests https://review.openstack.org/331483 | 19:57 |
jaypipes | dansmith: that original PoC one... (https://review.openstack.org/#/c/334039/) | 19:58 |
dansmith | jaypipes: okay, you've abandoned that patch... I've abandoned all hope. Sounds like we'rein a good spot | 19:58 |
*** ivase has quit IRC | 19:58 | |
jaypipes | dansmith: you will note the abandon note on there :) | 19:58 |
jaypipes | lol | 19:58 |
*** shaohe_feng has quit IRC | 19:58 | |
*** shaohe_feng has joined #openstack-nova | 19:59 | |
*** gszasz has quit IRC | 20:00 | |
openstackgerrit | Alexandre Levine proposed openstack/nova: POC Imagebackend complete refactoring. PLEASE DO NOT REVIEW. https://review.openstack.org/336921 | 20:02 |
*** ivase has joined #openstack-nova | 20:02 | |
*** jwcroppe has quit IRC | 20:03 | |
*** ivase_ has quit IRC | 20:03 | |
dansmith | jaypipes: I missed one? | 20:04 |
jaypipes | dansmith: yeah, the first line in that method :) | 20:05 |
jaypipes | dansmith: it's cool dude :) | 20:05 |
dansmith | jaypipes: oh right, that one was so ugly I didn't even see it | 20:05 |
vladikr | bogdan_, sorry.. | 20:05 |
vladikr | bogdan_, I think you could do it with virt-resize , I'll find a link | 20:06 |
vladikr | bogdan_, http://libguestfs.org/virt-resize.1.html | 20:06 |
dansmith | jaypipes: jammin' your way shortly | 20:06 |
openstackgerrit | Dan Smith proposed openstack/nova: Add support for resource inventories to placement API https://review.openstack.org/329152 | 20:07 |
openstackgerrit | Dan Smith proposed openstack/nova: Implement ResourceProvider.destroy() https://review.openstack.org/337925 | 20:07 |
openstackgerrit | Dan Smith proposed openstack/nova: Add initial framing of placement API https://review.openstack.org/329149 | 20:07 |
openstackgerrit | Dan Smith proposed openstack/nova: Add a Usage and UsageList object https://review.openstack.org/329575 | 20:07 |
openstackgerrit | Dan Smith proposed openstack/nova: Add support for resource_providers urls https://review.openstack.org/329151 | 20:07 |
openstackgerrit | Dan Smith proposed openstack/nova: Add support for usages in the placement API https://review.openstack.org/329643 | 20:07 |
openstackgerrit | Dan Smith proposed openstack/nova: Improve 404 and 405 response tests https://review.openstack.org/331483 | 20:07 |
*** Satya_ has quit IRC | 20:07 | |
*** ivase has quit IRC | 20:09 | |
*** ivase_ has joined #openstack-nova | 20:09 | |
*** shaohe_feng has quit IRC | 20:09 | |
*** baoli has quit IRC | 20:09 | |
*** shaohe_feng has joined #openstack-nova | 20:10 | |
jaypipes | mriedem, johnthetubaguy, alaski, edleafe, bauzas: your review on https://review.openstack.org/#/c/282442/ and https://review.openstack.org/#/c/337925/ would be great. Thanks in advance! | 20:12 |
*** lpetrut has quit IRC | 20:12 | |
bauzas | jaypipes: https://www.theguardian.com/football/live/2016/jul/07/germany-france-euro-2016-semi-final-live | 20:13 |
bauzas | jaypipes: but sure, when I'll have time | 20:13 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Remove live-migration from nova-manage man page https://review.openstack.org/339218 | 20:14 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Deprecate nova-manage vm list command https://review.openstack.org/339219 | 20:14 |
mriedem | sneti: ^ | 20:14 |
*** ivase has joined #openstack-nova | 20:14 | |
jaypipes | bauzas: doh! cool, totally understand :) | 20:14 |
dansmith | I have never once let sports get in the way of something important | 20:14 |
dansmith | just sayin' | 20:14 |
bauzas | markus_z is not around tho | 20:15 |
bauzas | that's sad | 20:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Deprecate nova-manage vm list command https://review.openstack.org/339219 | 20:15 |
*** ivase_ has quit IRC | 20:15 | |
mriedem | dansmith: not even http://www.imdb.com/title/tt0093692/ ? | 20:15 |
dansmith | heh | 20:15 |
*** baoli has joined #openstack-nova | 20:16 | |
mriedem | a winner never listens to the odds | 20:16 |
mriedem | words to live by | 20:16 |
edleafe | bauzas: wish I could find a live stream of that! | 20:16 |
bogdan_ | vladikr, now I realized that if I try the "Boot from image (creates new volume)" option it asks me for Device size (GB), so I used it and during instance creation I got a new volume auto created and "in use" :) which is good, but the instance creation fails with this message that says nothing to me: http://paste.openstack.org/show/527038/ | 20:17 |
edleafe | jaypipes: added those to my ever-growing browser tabs | 20:17 |
*** shaohe_feng has quit IRC | 20:19 | |
*** ivase_ has joined #openstack-nova | 20:20 | |
*** shaohe_feng has joined #openstack-nova | 20:20 | |
*** ivase has quit IRC | 20:20 | |
*** jamesdenton has quit IRC | 20:20 | |
vladikr | bogdan_, yea, that was fix in mitaka: https://review.openstack.org/#/c/215311/ | 20:21 |
vladikr | fixed* | 20:21 |
bogdan_ | vladikr, can I safely patch my Liberty with that fix? | 20:22 |
bogdan_ | vladikr, just wondering if your fix for the root volume for LXC was done back in Juno, how was this thing functioning if you say the latter bug was fixed in Mitaka,how about Liberty :)? | 20:25 |
*** ivase has joined #openstack-nova | 20:25 | |
openstackgerrit | Dan Smith proposed openstack/nova: Remove deprecated network_api_class option https://review.openstack.org/339184 | 20:26 |
*** ivase_ has quit IRC | 20:26 | |
vladikr | bogdan_, something broke the original functionality in kilo or liberty, there was no lxc ci back then to check that everything is working (not even now) | 20:27 |
bogdan_ | vladikr, do you think I could use the Mitaka fix in Liberty? | 20:28 |
*** tonytan_brb has quit IRC | 20:29 | |
*** shaohe_feng has quit IRC | 20:29 | |
vladikr | bogdan_, I don't know how will it apply, but if you are applying it in non-production, you can just try | 20:30 |
*** shaohe_feng has joined #openstack-nova | 20:30 | |
mriedem | bogdan_: stable/liberty upstream is in security/critical fix only mode | 20:31 |
mriedem | so that patch won't apply upstream for liberty | 20:31 |
*** ivase_ has joined #openstack-nova | 20:31 | |
*** mat128 is now known as mat128|afk | 20:31 | |
*** ivase has quit IRC | 20:32 | |
*** liverpooler has quit IRC | 20:32 | |
bogdan_ | mriedem, I know it is security fix only mode, I was rather referring to patching my local installation | 20:33 |
bogdan_ | I guess I will just have to try it out | 20:33 |
*** daemontool has quit IRC | 20:36 | |
*** ivase has joined #openstack-nova | 20:37 | |
*** ivase_ has quit IRC | 20:38 | |
*** cdent has joined #openstack-nova | 20:39 | |
*** shaohe_feng has quit IRC | 20:39 | |
*** shaohe_feng has joined #openstack-nova | 20:40 | |
*** baoli has quit IRC | 20:41 | |
alaski | dansmith: jaypipes question on https://review.openstack.org/#/c/282442/61 | 20:41 |
*** ducttape_ has joined #openstack-nova | 20:41 | |
*** baoli has joined #openstack-nova | 20:41 | |
dansmith | alaski: oh actually it might already do it | 20:42 |
sneti | mriedem, thanks for looking into this. | 20:42 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Stop using mox stubs in nova/tests/unit/cells https://review.openstack.org/323287 | 20:42 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Remove mox in test_block_device_mapping_v1.py https://review.openstack.org/308746 | 20:43 |
*** ivase_ has joined #openstack-nova | 20:43 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Parameter verification for os-simple-tenant-usage.inc https://review.openstack.org/333654 | 20:43 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Stop using mox stubs in nova/tests/unit/virt/disk https://review.openstack.org/322778 | 20:43 |
*** ivase has quit IRC | 20:43 | |
dansmith | alaski: tests pass without it | 20:43 |
alaski | cool | 20:44 |
*** salv-orlando has joined #openstack-nova | 20:44 | |
openstackgerrit | Dan Smith proposed openstack/nova: Add Allocation and AllocationList objects https://review.openstack.org/282442 | 20:45 |
openstackgerrit | Dan Smith proposed openstack/nova: Add support for resource inventories to placement API https://review.openstack.org/329152 | 20:45 |
openstackgerrit | Dan Smith proposed openstack/nova: Implement ResourceProvider.destroy() https://review.openstack.org/337925 | 20:45 |
openstackgerrit | Dan Smith proposed openstack/nova: Add initial framing of placement API https://review.openstack.org/329149 | 20:45 |
openstackgerrit | Dan Smith proposed openstack/nova: Add a Usage and UsageList object https://review.openstack.org/329575 | 20:45 |
openstackgerrit | Dan Smith proposed openstack/nova: Add support for resource_providers urls https://review.openstack.org/329151 | 20:45 |
openstackgerrit | Dan Smith proposed openstack/nova: Add support for usages in the placement API https://review.openstack.org/329643 | 20:45 |
openstackgerrit | Dan Smith proposed openstack/nova: Improve 404 and 405 response tests https://review.openstack.org/331483 | 20:45 |
*** hemanthm is now known as hemanthm|afk | 20:45 | |
*** sheel has quit IRC | 20:45 | |
*** cdent has quit IRC | 20:46 | |
*** salv-orlando has quit IRC | 20:46 | |
*** salv-orlando has joined #openstack-nova | 20:46 | |
alaski | dansmith: did you try https://review.openstack.org/#/c/337925/6/nova/objects/resource_provider.py without the module level method? The fixtures issue which made that necessary should be fixed now | 20:46 |
alaski | I don't care if you change it, just curious | 20:47 |
alaski | those can all be converted at some later time | 20:47 |
*** cdent has joined #openstack-nova | 20:47 | |
dansmith | alaski: yeah I have asked him several times to remove the module-level ones | 20:47 |
dansmith | alaski: because it's good now | 20:47 |
dansmith | alaski: I've been trying not to enforce my own review on his patches whilst updating them for other feedback | 20:47 |
alaski | heh, I assumed that was your patch because the previous one was | 20:48 |
dansmith | alaski: it's not my patch actually, I just split one of his out one time and have been forever branded with ownership by gerrit | 20:48 |
openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Adds Hyper-V UEFI Secure Boot https://review.openstack.org/209581 | 20:48 |
openstackgerrit | Claudiu Belu proposed openstack/nova: hyperv: Autospec all the used os-win utils https://review.openstack.org/339232 | 20:48 |
alaski | yeah, I see that now | 20:48 |
*** ivase has joined #openstack-nova | 20:49 | |
*** ivase_ has quit IRC | 20:49 | |
*** shaohe_feng has quit IRC | 20:50 | |
*** jianghuaw has quit IRC | 20:50 | |
*** shaohe_feng has joined #openstack-nova | 20:50 | |
cdent | If we're talking about module level db methods, I was planning to change them, but I think my response to that fact got buried in the shuffle in the past couple days | 20:50 |
cdent | I asked if I should do them in the existing patches or in a followup that did a general cleanup | 20:51 |
cdent | dansmith, alaski ^^ | 20:51 |
*** priteau has quit IRC | 20:51 | |
alaski | I'm fine either way | 20:51 |
dansmith | cdent: at least once you said "I prefer it this way" I think, but regardless, follow-up is fine with me | 20:51 |
dansmith | I think that was the only response I saw | 20:52 |
cdent | I do prefer it that way, but I don't want to go against the grain | 20:52 |
dansmith | thanks | 20:52 |
cdent | how about: We let the two at the bottom of that stack merge and then I'll put a clean up in at the new bottom before the api framing? | 20:52 |
dansmith | sure | 20:53 |
cdent | ✔ | 20:53 |
alaski | I'm looking at this patch and foresee the bug report that says "I can't delete my resource provider because there are allocations, but there shouldn't be any" | 20:54 |
dansmith | alaski: yep, which is why I think keeping a standalone delete method is almost definitely going to get used :) | 20:54 |
*** tonytan4ever has joined #openstack-nova | 20:54 | |
*** ivase_ has joined #openstack-nova | 20:54 | |
edleafe | Guess bauzas isn't doing any more work tonight :) | 20:54 |
alaski | dansmith: yeah | 20:54 |
bauzas | well, the match just ended :) | 20:55 |
cdent | the whole structure is very dependent on the database actually behaving | 20:55 |
*** ivase has quit IRC | 20:55 | |
bauzas | thanks France for leaving me going to the Nova meeting ! | 20:55 |
edleafe | bauzas: figured you'd be celbrating! | 20:55 |
openstackgerrit | Anusha Unnam proposed openstack/nova: rename the option scheduler_default_filters https://review.openstack.org/339233 | 20:55 |
edleafe | celebrating, even | 20:56 |
*** fragatina has joined #openstack-nova | 20:56 | |
alaski | cdent: I have faith in the db. I have less faith in Nova dealing with something like a SIGHUP and not deallocating something. | 20:56 |
dansmith | alaski: right :) | 20:56 |
dansmith | alaski: or any other number of ways this will get effed up | 20:57 |
bauzas | edleafe: that's just semifinale, I leave my champaign in the refrigator :p | 20:57 |
edleafe | bauzas: :) | 20:57 |
cdent | do we imagine resource providers being deleted frequently? | 20:57 |
cdent | alaski: but yeah... | 20:57 |
dansmith | cdent: no, just frequently enough for people to never remember how they un-fscked their data the last time they tried | 20:58 |
mriedem | nova meeting in 2 minutes | 20:58 |
alaski | dansmith: yep | 20:58 |
cdent | such are the costs of state duplication, I guess | 20:59 |
alaski | cdent: I'm just thinking aloud. I think this patch does the right thing | 20:59 |
dansmith | it'll be much more fun when things are in two databases and you can't write simple queries to find the inconsistencies :) | 20:59 |
cdent | I think it does the right thing in the context that it has chosen. | 20:59 |
*** shaohe_feng has quit IRC | 21:00 | |
*** ivase has joined #openstack-nova | 21:00 | |
*** svenkat has quit IRC | 21:00 | |
*** ivase_ has quit IRC | 21:01 | |
*** shaohe_feng has joined #openstack-nova | 21:01 | |
*** lchen_ has quit IRC | 21:02 | |
*** lchen_ has joined #openstack-nova | 21:03 | |
*** ivase has quit IRC | 21:06 | |
*** ivase has joined #openstack-nova | 21:07 | |
*** bogdan_ has quit IRC | 21:07 | |
*** baoli has quit IRC | 21:09 | |
*** shaohe_feng has quit IRC | 21:10 | |
*** shaohe_feng has joined #openstack-nova | 21:11 | |
*** ivase_ has joined #openstack-nova | 21:12 | |
*** priteau has joined #openstack-nova | 21:13 | |
*** ivase has quit IRC | 21:13 | |
*** priteau has quit IRC | 21:13 | |
*** mtanino has quit IRC | 21:14 | |
*** jaypipes has quit IRC | 21:15 | |
*** rcernin has quit IRC | 21:17 | |
*** pacoblox has joined #openstack-nova | 21:17 | |
*** ivase has joined #openstack-nova | 21:18 | |
*** ivase_ has quit IRC | 21:18 | |
*** agireud has quit IRC | 21:20 | |
*** shaohe_feng has quit IRC | 21:20 | |
*** david-lyle has quit IRC | 21:21 | |
*** shaohe_feng has joined #openstack-nova | 21:21 | |
*** haplo37_ has quit IRC | 21:22 | |
anteaya | g-r-p? | 21:22 |
dansmith | generic resource pools | 21:23 |
dims | gorp? :) | 21:23 |
*** david-lyle has joined #openstack-nova | 21:23 | |
dansmith | dims: depends on your level of frustration :) | 21:23 |
anteaya | dansmith: thank you | 21:23 |
dims | :) | 21:24 |
*** ivase_ has joined #openstack-nova | 21:24 | |
*** ivase has quit IRC | 21:24 | |
*** lpetrut has joined #openstack-nova | 21:29 | |
*** ivase has joined #openstack-nova | 21:29 | |
*** raildo is now known as raildo-afk | 21:30 | |
*** burgerk has quit IRC | 21:30 | |
*** ivase_ has quit IRC | 21:30 | |
*** shaohe_feng has quit IRC | 21:31 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: rest api version bumped for async pre live migration checks https://review.openstack.org/314932 | 21:32 |
*** aysyd has quit IRC | 21:33 | |
*** shaohe_feng has joined #openstack-nova | 21:33 | |
*** ayoung has quit IRC | 21:34 | |
*** MikeG451 has joined #openstack-nova | 21:34 | |
*** ivase_ has joined #openstack-nova | 21:35 | |
*** ozialien10 has joined #openstack-nova | 21:35 | |
*** ivase has quit IRC | 21:36 | |
tdurakov | dansmith, mriedem, alaski, alex_xu hi, all comments are addressed, could you please take a look^ | 21:36 |
dansmith | tdurakov: you know I get an email every time you push, right? :) | 21:37 |
tdurakov | dansmith: ok, understood) | 21:38 |
cdent | dansmith: am I correct in understanding that you have no immediate plans to further change allocation and resource provider destroy, so I'm not going to cheese you or me up by starting on some of the stuff above it? | 21:40 |
*** diogogmt has quit IRC | 21:40 | |
*** ivase has joined #openstack-nova | 21:41 | |
*** shaohe_feng has quit IRC | 21:41 | |
dansmith | cdent: no immediate plans nope | 21:41 |
*** ivase_ has quit IRC | 21:41 | |
cdent | thanks | 21:41 |
*** shaohe_feng has joined #openstack-nova | 21:42 | |
*** baoli has joined #openstack-nova | 21:42 | |
*** ivase_ has joined #openstack-nova | 21:46 | |
*** ivase has quit IRC | 21:47 | |
*** diogogmt has joined #openstack-nova | 21:47 | |
*** yamahata has quit IRC | 21:47 | |
cdent | dansmith: when I do this module level method cleanup, would you like me to also move all the private class/object methods to the top of the ResourceProvider class? | 21:48 |
*** yamahata has joined #openstack-nova | 21:50 | |
*** shaohe_feng has quit IRC | 21:51 | |
*** shaohe_feng has joined #openstack-nova | 21:52 | |
*** pacoblox has quit IRC | 21:52 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: hyperv: Autospec all the used os-win utils https://review.openstack.org/339232 | 21:52 |
*** rlrossit has quit IRC | 21:53 | |
*** pacoblox has joined #openstack-nova | 21:53 | |
*** ivase has joined #openstack-nova | 21:53 | |
*** ivase_ has quit IRC | 21:53 | |
*** xyang1 has quit IRC | 21:54 | |
*** bogdan has joined #openstack-nova | 21:55 | |
*** rtheis has quit IRC | 21:56 | |
*** burt has quit IRC | 21:57 | |
*** ivase_ has joined #openstack-nova | 21:58 | |
*** ivase has quit IRC | 21:59 | |
*** tonytan4ever has quit IRC | 22:00 | |
*** shaohe_feng has quit IRC | 22:01 | |
bogdan | mriedem, you mentioned that in Newton there is volume attachment support for Libvirt Virtuozzo CT, right? any guidance on how to configure it? | 22:02 |
*** shaohe_feng has joined #openstack-nova | 22:02 | |
*** artom has quit IRC | 22:02 | |
*** thorst has quit IRC | 22:03 | |
mriedem | bogdan: http://specs.openstack.org/openstack/nova-specs/specs/newton/approved/libvirt-vzstorage-volume-support.html | 22:03 |
*** pacoblox has quit IRC | 22:03 | |
*** ivase has joined #openstack-nova | 22:04 | |
*** mmandel has quit IRC | 22:04 | |
claudiub | mriedem: the autospecing patch: https://review.openstack.org/#/c/339232/1 | 22:05 |
bogdan | Thanks mriedem! | 22:05 |
*** ivase_ has quit IRC | 22:05 | |
*** pacoblox has joined #openstack-nova | 22:05 | |
*** Raildo has joined #openstack-nova | 22:06 | |
*** darrenc is now known as darrenc_afk | 22:06 | |
openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova: Provide more duplicate VLAN network error info https://review.openstack.org/339253 | 22:06 |
*** Raildo has quit IRC | 22:06 | |
*** david-lyle has quit IRC | 22:07 | |
*** mdrabe has quit IRC | 22:08 | |
*** ivase_ has joined #openstack-nova | 22:10 | |
mriedem | diana_clarke: look familiar http://logs.openstack.org/21/299621/7/gate/gate-tempest-dsvm-postgres-full/c182c88/logs/screen-n-cpu.txt.gz#_2016-07-07_21_08_11_773 ? | 22:10 |
*** artom has joined #openstack-nova | 22:10 | |
*** ivase has quit IRC | 22:10 | |
*** akshai_ has joined #openstack-nova | 22:11 | |
*** shaohe_feng has quit IRC | 22:12 | |
*** shaohe_feng has joined #openstack-nova | 22:12 | |
*** akshai has quit IRC | 22:15 | |
diana_clarke | mriedem: The over committed errors? I recall someone mentioning them this week, but I don't know much about this. | 22:15 |
*** TravT has quit IRC | 22:15 | |
*** ivase has joined #openstack-nova | 22:15 | |
*** ivase_ has quit IRC | 22:16 | |
mriedem | diana_clarke: ok https://bugs.launchpad.net/nova/+bug/1600031 | 22:17 |
openstack | Launchpad bug 1600031 in OpenStack Compute (nova) "libvirt: KeyError in _get_disk_over_committed_size_total" [Medium,Confirmed] | 22:17 |
*** ducttape_ has quit IRC | 22:17 | |
mriedem | that's called from a periodic task | 22:18 |
mriedem | and the code in the driver isn't filtering out deleted instances | 22:19 |
*** tjones has left #openstack-nova | 22:19 | |
mriedem | and this is a delete test | 22:19 |
mriedem | so my guess is we're racing with something doing cleanup | 22:19 |
*** hoangcx has joined #openstack-nova | 22:19 | |
mriedem | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22_get_disk_over_committed_size_total%5C%22%20AND%20message%3A%5C%22local_instances%5Bguest.uuid%5D%2C%20bdms%5Bguest.uuid%5D)%5C%22%20AND%20message%3A%5C%22KeyError%5C%22%20AND%20tags%3A%5C%22screen-n-cpu.txt%5C%22&from=7d | 22:20 |
openstackgerrit | Alexandre Levine proposed openstack/nova: POC Imagebackend complete refactoring. PLEASE DO NOT REVIEW. https://review.openstack.org/336921 | 22:20 |
*** Swanson has joined #openstack-nova | 22:20 | |
mriedem | looks like it's new in the last 24 hours | 22:20 |
mriedem | alaski: you were playing with bdm deletion right? | 22:21 |
*** ivase_ has joined #openstack-nova | 22:21 | |
*** pacoblox has quit IRC | 22:21 | |
*** ivase has quit IRC | 22:22 | |
*** shaohe_feng has quit IRC | 22:22 | |
*** ozialien10 has quit IRC | 22:22 | |
*** shaohe_feng has joined #openstack-nova | 22:23 | |
*** pacoblox has joined #openstack-nova | 22:26 | |
*** TravT has joined #openstack-nova | 22:26 | |
*** darrenc_afk is now known as darrenc | 22:26 | |
*** ivase has joined #openstack-nova | 22:27 | |
*** lpetrut has quit IRC | 22:27 | |
*** ivase_ has quit IRC | 22:28 | |
*** lpetrut has joined #openstack-nova | 22:28 | |
melwitt | mriedem: I hope it's not related to https://review.openstack.org/#/c/335697/ again | 22:28 |
mriedem | melwitt: i just saw that :) | 22:28 |
mriedem | melwitt: it's either that or https://review.openstack.org/#/c/334094/ | 22:29 |
*** ctrath has quit IRC | 22:29 | |
mriedem | i think it's alaski's change though | 22:30 |
mriedem | it introduces a race where the bdm exists but not with the instance_uuid set | 22:30 |
*** salv-orlando has quit IRC | 22:30 | |
mriedem | dansmith: johnthetubaguy: fyi ^ | 22:32 |
melwitt | my change has those errors in the postgres job and his doesn't | 22:32 |
*** shaohe_feng has quit IRC | 22:32 | |
mriedem | melwitt: check logstash above, it's a race | 22:32 |
mriedem | it shows up in several changes and jobs | 22:32 |
mriedem | it doesn't cause failures per se, but it makes the available resource task in the compute fail | 22:33 |
*** ivase_ has joined #openstack-nova | 22:33 | |
*** shaohe_feng has joined #openstack-nova | 22:33 | |
melwitt | okay. I was concerned my change somehow started it by seeing the errors on my change but not his | 22:33 |
*** dimtruck is now known as zz_dimtruck | 22:33 | |
mriedem | melwitt: hmm, it might be your change, is there something to check for logging? | 22:34 |
*** ivase has quit IRC | 22:34 | |
*** salv-orlando has joined #openstack-nova | 22:34 | |
melwitt | mriedem: what do you mean? | 22:35 |
*** tblakeslee has quit IRC | 22:35 | |
mriedem | we should only do local delete if the instance's host is down right? | 22:35 |
melwitt | if instance.host is not set | 22:36 |
melwitt | also | 22:36 |
alaski | mriedem: with my change bdm isn't written to the db until instance_uuid is set | 22:36 |
mriedem | melwitt: it did it in alaski's change, but in the cells job | 22:37 |
mriedem | alaski: ok that would do it | 22:37 |
melwitt | oh, okay | 22:37 |
mriedem | the task in the libvirt driver gets the instances from the host via libvirt | 22:37 |
mriedem | their uuids | 22:37 |
mriedem | queries the db for them | 22:37 |
mriedem | then queries the db for bdms with those instance uuids | 22:37 |
*** lpetrut has quit IRC | 22:38 | |
mriedem | then loops over them and checks to see if the instances are in the 'local' guest list, which it is, but it doesn't check if the guest uuid is in the bdm list | 22:38 |
mriedem | which it's not now, because of the delayed bdm create | 22:38 |
mriedem | https://github.com/openstack/nova/blob/d2a89a85354ab7253d034335aa2eb996e81b6f1c/nova/virt/libvirt/driver.py#L6794 | 22:38 |
alaski | I mean the bdm has an instance_uuid when it's written | 22:38 |
*** EinstCrazy has quit IRC | 22:38 | |
alaski | it should be functionally equivalent to what was there before | 22:39 |
mriedem | alaski: but the bdm isn't created until the instance_uuid is set right? | 22:39 |
alaski | right, but that's what happened before | 22:39 |
*** salv-orlando has quit IRC | 22:39 | |
*** ivase has joined #openstack-nova | 22:39 | |
*** ivase_ has quit IRC | 22:39 | |
*** catintheroof has quit IRC | 22:40 | |
alaski | https://review.openstack.org/#/c/334094/7/nova/compute/api.py@966 | 22:40 |
alaski | the create is in the same place | 22:40 |
alaski | it just creates the bdm object earlier, but creates in the db at the same place | 22:40 |
mriedem | # TODO(alaski): Why is this done? | 22:42 |
mriedem | heh, | 22:42 |
mriedem | i knew the answer to that like 2 weeks ago | 22:42 |
mriedem | b/c i was looking at that same thing | 22:42 |
*** shaohe_feng has quit IRC | 22:42 | |
alaski | all I could gather was that it was related to ephemerals, but I didn't chase the rabbit down the hole | 22:43 |
openstackgerrit | Aihua Edward Li proposed openstack/nova: Fix code path when network is not cleaned up https://review.openstack.org/335788 | 22:43 |
*** shaohe_feng has joined #openstack-nova | 22:43 | |
*** ivase_ has joined #openstack-nova | 22:44 | |
*** ivase has quit IRC | 22:46 | |
mikal | mriedem: I'm working on that functional test now. Its going a bit slow because I've never written one before and I need to add a new service to the fixtures to get it going. | 22:48 |
mikal | mriedem: so, vaguely flailing | 22:48 |
mriedem | mikal: be strong | 22:48 |
mikal | Heh | 22:50 |
mikal | Its also slow because I'm totally on vacation this week, which makes finding time at a PC hard... | 22:50 |
*** thorst has joined #openstack-nova | 22:50 | |
*** ivase has joined #openstack-nova | 22:50 | |
mriedem | alaski: i think i see the problem | 22:50 |
mriedem | alaski: in the before times, we didn't create the bdm in the db if volume_size == 0 | 22:51 |
mriedem | well, nvm, we still don't | 22:51 |
alaski | okay, I've been looking at melwitts patch and not seeing what could happen there | 22:51 |
*** ivase_ has quit IRC | 22:51 | |
mriedem | i was going to say, we didn't set instance_uuid on the bdm if bdm.volume_size == 0, but we didn't create it in the db either | 22:51 |
mriedem | so i'm not sure what setting the instance_uuid on the bdm that we aren't going to create here does | 22:52 |
alaski | yeah | 22:52 |
*** pradk has quit IRC | 22:52 | |
alaski | hmm | 22:52 |
*** shaohe_feng has quit IRC | 22:53 | |
mriedem | mikal: you have minions right? | 22:53 |
*** shaohe_feng has joined #openstack-nova | 22:54 | |
alaski | mriedem: should do nothing, we apparently throw block_device_mapping away in conductor and fetch from the db | 22:54 |
*** thorst has quit IRC | 22:54 | |
alaski | http://git.openstack.org/cgit/openstack/nova/tree/nova/conductor/manager.py#n482 | 22:54 |
alaski | # TODO(ndipanov): Remove block_device_mapping and legacy_bdm in version | 22:55 |
alaski | # 2.0 of the RPC API. | 22:55 |
*** ivase_ has joined #openstack-nova | 22:56 | |
alaski | dinner time | 22:56 |
* alaski & | 22:56 | |
*** ivase has quit IRC | 22:57 | |
melwitt | in n-cpu.log I see it cleaning up instance files "Instance has had 0 of 5 cleanup attempts _run_pending_deletes" and that instance is the one that keeps failing on KeyError after that | 22:58 |
melwitt | in the periodic task | 22:58 |
mikal | mriedem: the only nova minion is tonyb and he's on vacation too | 22:58 |
mriedem | melwitt: yeah i saw that too | 22:58 |
openstackgerrit | Weiwei Gu proposed openstack/nova: migration volume failed for invalid type https://review.openstack.org/315864 | 23:00 |
*** salv-orlando has joined #openstack-nova | 23:01 | |
*** ivase has joined #openstack-nova | 23:02 | |
*** ivase_ has quit IRC | 23:02 | |
*** kenperkins has quit IRC | 23:03 | |
*** shaohe_feng has quit IRC | 23:03 | |
*** shaohe_feng has joined #openstack-nova | 23:04 | |
*** john51 has quit IRC | 23:04 | |
*** unicell1 has quit IRC | 23:04 | |
*** john51 has joined #openstack-nova | 23:04 | |
melwitt | mriedem: that's weird, it's like cleaning up instance files before the domain is destroyed. and it would do that if a local delete occurred, and a local delete would cleanup the bdms too | 23:04 |
*** unicell has joined #openstack-nova | 23:05 | |
*** ivase_ has joined #openstack-nova | 23:08 | |
*** ivase has quit IRC | 23:08 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Adds Hyper-V UEFI Secure Boot https://review.openstack.org/209581 | 23:09 |
mriedem | melwitt: yeah so i'm thinking it's not alaski's change now, | 23:09 |
*** salv-orlando has quit IRC | 23:09 | |
mriedem | because his change is all api, we wouldn't even have the instance (guest) with that uuid on the host at this point | 23:09 |
mriedem | so it must be a race in delete | 23:10 |
melwitt | yeah. this particular test does an immediate delete so it'll be while spawning. and if instance.host isn't set at the time, local delete will happen and nuke the bdms, and the compute node tries to assume they're there | 23:11 |
melwitt | I don't yet understand how my change causes this to show up | 23:12 |
mriedem | melwitt: the test waits for the instance to be active | 23:12 |
mriedem | at least the one i was looking at | 23:12 |
mriedem | DeleteServersAdminTestJSON | 23:13 |
melwitt | oh, hmm | 23:13 |
mriedem | http://git.openstack.org/cgit/openstack/tempest/tree/tempest/api/compute/servers/test_delete_server.py#n130 | 23:13 |
*** shaohe_feng has quit IRC | 23:13 | |
*** ivase has joined #openstack-nova | 23:13 | |
mriedem | is there anything with the local delete stuff checking for error status? | 23:13 |
*** amotoki has quit IRC | 23:14 | |
melwitt | okay, yes. my change allows local delete for instances in error state, where previously that was not the case | 23:14 |
mriedem | if instance.vm_state in (vm_states.SHELVED_OFFLOADED, vm_states.ERROR): | 23:14 |
mriedem | bingo | 23:14 |
*** shaohe_feng has joined #openstack-nova | 23:14 | |
mriedem | revert #30?! | 23:14 |
*** hieulq_ has joined #openstack-nova | 23:14 | |
*** takashin has joined #openstack-nova | 23:15 | |
*** ivase_ has quit IRC | 23:15 | |
*** hieulq has quit IRC | 23:16 | |
*** zehua has quit IRC | 23:16 | |
melwitt | thinking ... it local deletes if instance.host is not set and instance in error state | 23:17 |
mriedem | so expect_no_instance_host will be True | 23:19 |
mriedem | but instance.host is set | 23:19 |
mriedem | so "if not instance.host and not expect_no_instance_host" will eval to False | 23:19 |
*** gabor_antal has quit IRC | 23:19 | |
mriedem | which drops us to "if not expect_no_instance_host" | 23:19 |
*** ivase_ has joined #openstack-nova | 23:19 | |
mriedem | which evals to False | 23:19 |
*** zehua has joined #openstack-nova | 23:19 | |
mriedem | and then "if not is_local_delete:" | 23:19 |
mriedem | which is False | 23:19 |
mriedem | because is_local_delete = True | 23:20 |
*** ivase has quit IRC | 23:20 | |
mriedem | so we get to https://review.openstack.org/#/c/335697/2/nova/compute/api.py@1658 | 23:20 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Add a hacking rule for string interpolation at logging https://review.openstack.org/334844 | 23:20 |
mriedem | honestly the test is pretty terrible | 23:21 |
melwitt | that's the same path it would take without my change, I think | 23:21 |
mriedem | no it wouldn't | 23:21 |
*** BjoernT has quit IRC | 23:21 | |
mriedem | because if not shelved_offloaded would be true | 23:21 |
mriedem | so we'd call "is_local_delete = not self.servicegroup_api.service_is_up( | 23:21 |
mriedem | service)" | 23:21 |
mriedem | which would be False | 23:21 |
mriedem | this local delete stuff is the worst ever | 23:22 |
mriedem | i think it goes: | 23:22 |
melwitt | ah, dammit | 23:22 |
mriedem | 1. local delete | 23:22 |
mriedem | 2. bdms | 23:22 |
mriedem | 3. cells v1 | 23:22 |
mriedem | maybe cells v1 first | 23:22 |
melwitt | so really we need to completely untie shelved offloaded from error state. because we only want local delete 'if not instance.host and vm_states.ERROR' | 23:23 |
mriedem | yar | 23:23 |
*** shaohe_feng has quit IRC | 23:23 | |
mriedem | nit: rename expect_no_instance_host to expect_instance_host :) | 23:24 |
*** pacoblox has quit IRC | 23:24 | |
mriedem | the negative logic in here is hurting my head | 23:24 |
*** shaohe_feng has joined #openstack-nova | 23:24 | |
melwitt | haha, well, I think there might not be that at all because I think those checks have to be independent | 23:24 |
mriedem | so the good news is this is really not blowing anything up so far from what i can tell, although it could cause scheduling issues in production since we're not doing disk accounting properly | 23:25 |
*** claudiub has quit IRC | 23:25 | |
mriedem | but the gate isn't falling over | 23:25 |
*** ivase_ has quit IRC | 23:25 | |
mriedem | but again, the test is pretty hacky | 23:25 |
*** ivase has joined #openstack-nova | 23:26 | |
mriedem | resetting an instance to ERROR state is weird | 23:26 |
mriedem | but i guess that's just to recreate a failed build | 23:26 |
melwitt | yeah, true. I had been running delete race tests locally before I took that patch out of WIP but I wasn't running that particular test. I was focusing on the delete of unscheduled instances | 23:26 |
melwitt | and things went well so I thought I finally found the right fix. argh | 23:27 |
mriedem | dude | 23:27 |
mriedem | you know there is no right fix for this code | 23:27 |
mriedem | except flamethrower | 23:27 |
melwitt | good point. relatively I mean | 23:27 |
melwitt | haha | 23:27 |
melwitt | mriedem: so is it okay if I just fix this or do we need to do a revert and re-fix again? | 23:29 |
mriedem | melwitt: just fix it | 23:29 |
*** bogdan has quit IRC | 23:29 | |
melwitt | okay. on it | 23:29 |
mriedem | given the failure rate | 23:29 |
mriedem | we should probably be able to tell easily if it's fixed | 23:29 |
melwitt | yeah | 23:30 |
mriedem | now i've totally lost interest in pursuing the md pg bug for the night | 23:30 |
*** ivase_ has joined #openstack-nova | 23:31 | |
*** john51_ has joined #openstack-nova | 23:31 | |
*** thorst has joined #openstack-nova | 23:31 | |
melwitt | I know. I started out looking at that too and look what happened | 23:31 |
melwitt | I didn't see anything helpful, the 404 in metadata service logs appears to be 'normal' from what I saw in successful runs | 23:32 |
*** fmccrthy has quit IRC | 23:32 | |
*** ivase has quit IRC | 23:33 | |
melwitt | and I don't know what the successful console log looks like for an instance being brought up via the metadata service. I don't think we have that in the build logs anywhere in the case of successful ssh | 23:33 |
*** john51 has quit IRC | 23:33 | |
melwitt | I guess in the failed console log we should be able to tell if it got the keys or not but I was missing it | 23:33 |
*** shaohe_feng has quit IRC | 23:34 | |
*** fmccrthy has joined #openstack-nova | 23:34 | |
*** pacoblox has joined #openstack-nova | 23:34 | |
*** shaohe_feng has joined #openstack-nova | 23:35 | |
*** salv-orlando has joined #openstack-nova | 23:35 | |
*** thorst has quit IRC | 23:36 | |
*** ayoung has joined #openstack-nova | 23:36 | |
*** ivase has joined #openstack-nova | 23:37 | |
*** ivase_ has quit IRC | 23:37 | |
*** pacoblox has quit IRC | 23:37 | |
*** fragatina has quit IRC | 23:40 | |
mriedem | looks like the fixed IP lease is coming in late | 23:40 |
melwitt | yeah. I feel like I've seen that a lot though, in general. if you're referring to the warnings in the logs | 23:42 |
*** ivase_ has joined #openstack-nova | 23:42 | |
*** ivase has quit IRC | 23:43 | |
openstackgerrit | Chris Dent proposed openstack/nova: Add support for resource inventories to placement API https://review.openstack.org/329152 | 23:44 |
openstackgerrit | Chris Dent proposed openstack/nova: Add initial framing of placement API https://review.openstack.org/329149 | 23:44 |
openstackgerrit | Chris Dent proposed openstack/nova: Add a Usage and UsageList object https://review.openstack.org/329575 | 23:44 |
openstackgerrit | Chris Dent proposed openstack/nova: Add support for resource_providers urls https://review.openstack.org/329151 | 23:44 |
openstackgerrit | Chris Dent proposed openstack/nova: Add support for usages in the placement API https://review.openstack.org/329643 | 23:44 |
openstackgerrit | Chris Dent proposed openstack/nova: WIP experiment with the remainder of the placement API https://review.openstack.org/293104 | 23:44 |
*** claudiub has joined #openstack-nova | 23:44 | |
*** shaohe_feng has quit IRC | 23:44 | |
openstackgerrit | Chris Dent proposed openstack/nova: Improve 404 and 405 response tests https://review.openstack.org/331483 | 23:44 |
openstackgerrit | Chris Dent proposed openstack/nova: Clean up helper methods in ResourceProvider https://review.openstack.org/339281 | 23:44 |
*** shaohe_feng has joined #openstack-nova | 23:45 | |
*** ducttape_ has joined #openstack-nova | 23:46 | |
mriedem | melwitt: not sure, sdague had fixed some issues with nova-net there by recycling the fixed IPs from the db | 23:46 |
mriedem | i added some comments in https://bugs.launchpad.net/nova/+bug/1600005 after digging through the logs | 23:46 |
openstack | Launchpad bug 1600005 in OpenStack Compute (nova) "gate-tempest-dsvm-postgres-full ssh timeout failures spiking since 7/4" [High,Confirmed] | 23:46 |
*** diogogmt has quit IRC | 23:46 | |
mriedem | laura is making dinner though and i'm like an hour late so i'm going to be in bigger trouble, so need to head out | 23:47 |
melwitt | mriedem: ah, right. the least recently used ip thing | 23:47 |
*** salv-orlando has quit IRC | 23:47 | |
melwitt | okay, seeya! | 23:47 |
*** mriedem is now known as mriedem_afk | 23:47 | |
*** ivase has joined #openstack-nova | 23:48 | |
*** ivase_ has quit IRC | 23:49 | |
*** thorst has joined #openstack-nova | 23:52 | |
*** code-R_ has quit IRC | 23:54 | |
*** diogogmt has joined #openstack-nova | 23:54 | |
*** shaohe_feng has quit IRC | 23:54 | |
*** ivase_ has joined #openstack-nova | 23:55 | |
*** ivase has quit IRC | 23:55 | |
*** shaohe_feng has joined #openstack-nova | 23:55 | |
*** thorst has quit IRC | 23:57 | |
*** rrecio has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!