*** baoli has joined #openstack-nova | 00:00 | |
*** sameo has quit IRC | 00:01 | |
*** browne has quit IRC | 00:01 | |
sdague | gmann: done, thanks | 00:07 |
---|---|---|
gmann | sdague: Thanks :) | 00:07 |
*** shaohe_feng has quit IRC | 00:08 | |
*** shaohe_feng has joined #openstack-nova | 00:09 | |
sdague | gmann / alex_xu - https://review.openstack.org/#/c/324068/ is probably in a close enough form that if anyone wanted to start digging in on implementation, we could get the spec and patch landed this week | 00:09 |
sdague | about to head off for the night, but thought I'd bring that one back to the forefront. We should probably talk about it during the API meeting tomorrow as well | 00:09 |
*** baoli has quit IRC | 00:11 | |
gmann | sdague: Thanks. i will check that. | 00:11 |
*** hoangcx2 has quit IRC | 00:11 | |
*** MikeG451_ has quit IRC | 00:12 | |
*** jamielennox is now known as jamielennox|away | 00:12 | |
*** baoli has joined #openstack-nova | 00:13 | |
*** eil397 has quit IRC | 00:14 | |
*** sdague has quit IRC | 00:16 | |
*** shaohe_feng has quit IRC | 00:18 | |
*** shaohe_feng has joined #openstack-nova | 00:19 | |
*** dimtruck is now known as zz_dimtruck | 00:19 | |
oomichi | gmann: hi, did you read https://review.openstack.org/#/c/324068/3/specs/newton/approved/user_id_based_policy_enforcement.rst ? | 00:21 |
*** rama_y has joined #openstack-nova | 00:21 | |
oomichi | gmann: I could not catch sdague before his today work finishing | 00:22 |
gmann | oomichi: reading the same as pointed by sdague too | 00:22 |
*** jamespd_ has left #openstack-nova | 00:22 | |
gmann | oomichi: of that spec? | 00:22 |
oomichi | gmann: yeah. line 77 | 00:22 |
oomichi | gmann: on the spec, users can reboot servers which are owned by different users? | 00:23 |
*** baoli has quit IRC | 00:23 | |
oomichi | gmann: means the user policy is not checked on reboot action? | 00:23 |
oomichi | gmann: | 00:25 |
oomichi | gmann: I will put some comments on that anyways | 00:25 |
gmann | oomichi: i do think so | 00:25 |
gmann | oomichi: sorry do->do not | 00:26 |
oomichi | gmann: the user policy should be checked on the reboot action? | 00:26 |
oomichi | gmann: if so, I agree with that | 00:27 |
*** diogogmt has quit IRC | 00:27 | |
*** zz_dimtruck is now known as dimtruck | 00:28 | |
*** shaohe_feng has quit IRC | 00:28 | |
*** erlon has joined #openstack-nova | 00:29 | |
*** nic has quit IRC | 00:29 | |
*** shaohe_feng has joined #openstack-nova | 00:29 | |
*** armax has quit IRC | 00:29 | |
gmann | oomichi: actually line are not much clear but after reading 2-3 times, i understand reboot operation will check the user_id along with other destructive actions | 00:30 |
*** Swami has quit IRC | 00:31 | |
*** armax has joined #openstack-nova | 00:34 | |
*** TravT has quit IRC | 00:34 | |
*** rama_y has quit IRC | 00:35 | |
*** thorst has joined #openstack-nova | 00:36 | |
*** hoangcx has joined #openstack-nova | 00:38 | |
*** shaohe_feng has quit IRC | 00:38 | |
*** shaohe_feng has joined #openstack-nova | 00:39 | |
*** code-R has joined #openstack-nova | 00:42 | |
*** thorst has quit IRC | 00:42 | |
*** thorst has joined #openstack-nova | 00:43 | |
*** code-R_ has joined #openstack-nova | 00:44 | |
*** sdake_ has quit IRC | 00:45 | |
*** code-R has quit IRC | 00:47 | |
*** sdake has joined #openstack-nova | 00:47 | |
*** tonytan4ever has joined #openstack-nova | 00:47 | |
*** code-R_ has quit IRC | 00:48 | |
*** mtanin___ has quit IRC | 00:48 | |
*** shaohe_feng has quit IRC | 00:49 | |
*** code-R has joined #openstack-nova | 00:49 | |
*** shaohe_feng has joined #openstack-nova | 00:49 | |
*** zhs__ has joined #openstack-nova | 00:51 | |
*** Sukhdev has quit IRC | 00:52 | |
*** hieulq has quit IRC | 00:52 | |
*** tonytan4ever has quit IRC | 00:53 | |
*** zhs_ has quit IRC | 00:54 | |
*** hoangcx2 has joined #openstack-nova | 00:54 | |
*** ducttape_ has quit IRC | 00:54 | |
*** ducttape_ has joined #openstack-nova | 00:56 | |
*** oomichi has quit IRC | 00:57 | |
*** shaohe_feng has quit IRC | 00:59 | |
*** shaohe_feng has joined #openstack-nova | 01:00 | |
*** hoangcx2 has quit IRC | 01:01 | |
*** hoangcx2 has joined #openstack-nova | 01:02 | |
*** sdake has quit IRC | 01:04 | |
*** kaisers_ has joined #openstack-nova | 01:06 | |
*** shaohe_feng has quit IRC | 01:09 | |
*** shaohe_feng has joined #openstack-nova | 01:10 | |
*** kaisers_ has quit IRC | 01:11 | |
openstackgerrit | Anush Krishnamurthy proposed openstack/nova: Improve consistency in cert https://review.openstack.org/332650 | 01:11 |
*** ijw has joined #openstack-nova | 01:14 | |
*** ducttape_ has quit IRC | 01:17 | |
*** Apoorva has quit IRC | 01:18 | |
*** dimtruck is now known as zz_dimtruck | 01:19 | |
*** shaohe_feng has quit IRC | 01:19 | |
*** shaohe_feng has joined #openstack-nova | 01:20 | |
*** hoangcx2 has quit IRC | 01:23 | |
*** hoangcx2 has joined #openstack-nova | 01:24 | |
*** ijw has quit IRC | 01:25 | |
*** ljxiash has joined #openstack-nova | 01:27 | |
*** shaohe_feng has quit IRC | 01:30 | |
*** kevin_zh has joined #openstack-nova | 01:30 | |
*** shaohe_feng has joined #openstack-nova | 01:30 | |
*** ljxiash has quit IRC | 01:32 | |
*** ljxiash has joined #openstack-nova | 01:33 | |
*** openstackgerrit has quit IRC | 01:33 | |
*** openstackgerrit has joined #openstack-nova | 01:34 | |
*** hoangcx2 has quit IRC | 01:34 | |
*** TravT has joined #openstack-nova | 01:35 | |
*** hoangcx2 has joined #openstack-nova | 01:36 | |
*** woodster_ has quit IRC | 01:39 | |
*** shaohe_feng has quit IRC | 01:40 | |
*** shaohe_feng has joined #openstack-nova | 01:41 | |
*** baoli has joined #openstack-nova | 01:41 | |
*** jwcroppe has quit IRC | 01:42 | |
*** jaypipes has quit IRC | 01:43 | |
*** mingyu has joined #openstack-nova | 01:43 | |
openstackgerrit | Alex Xu proposed openstack/nova: Add networks to quota's update json-schema when network quota enabled https://review.openstack.org/347588 | 01:45 |
*** ljxiash has quit IRC | 01:46 | |
*** zz_dimtruck is now known as dimtruck | 01:47 | |
*** thorst has quit IRC | 01:48 | |
*** ljxiash has joined #openstack-nova | 01:48 | |
*** thorst has joined #openstack-nova | 01:48 | |
*** tonytan4ever has joined #openstack-nova | 01:49 | |
*** shaohe_feng has quit IRC | 01:50 | |
*** hoangcx2 has quit IRC | 01:51 | |
*** ljxiash has quit IRC | 01:53 | |
*** shaohe_feng has joined #openstack-nova | 01:53 | |
*** tonytan4ever has quit IRC | 01:53 | |
*** ljxiash has joined #openstack-nova | 01:54 | |
*** mingyu has quit IRC | 01:54 | |
*** thorst has quit IRC | 01:57 | |
*** TravT has quit IRC | 01:59 | |
openstackgerrit | Alex Xu proposed openstack/nova: Remove the useless version calculation for proxy api deprecated version https://review.openstack.org/347593 | 02:00 |
*** shaohe_feng has quit IRC | 02:00 | |
*** shaohe_feng has joined #openstack-nova | 02:01 | |
openstackgerrit | Hironori Shiina proposed openstack/nova: Allow empty CPU info of hypervisors https://review.openstack.org/346868 | 02:02 |
*** TravT has joined #openstack-nova | 02:03 | |
*** coolsvap_ has joined #openstack-nova | 02:04 | |
*** thorst has joined #openstack-nova | 02:06 | |
*** thorst has quit IRC | 02:06 | |
openstackgerrit | liuxiuli proposed openstack/nova: Modify request numa_topology when resize https://review.openstack.org/340270 | 02:09 |
*** armax has quit IRC | 02:10 | |
*** shaohe_feng has quit IRC | 02:11 | |
*** shaohe_feng has joined #openstack-nova | 02:11 | |
*** sdake has joined #openstack-nova | 02:12 | |
*** eliqiao has quit IRC | 02:12 | |
*** eliqiao has joined #openstack-nova | 02:12 | |
*** TravT has quit IRC | 02:12 | |
*** baoli has quit IRC | 02:17 | |
*** TravT has joined #openstack-nova | 02:18 | |
*** shaohe_feng has quit IRC | 02:21 | |
*** shaohe_feng has joined #openstack-nova | 02:21 | |
*** salv-orl_ has quit IRC | 02:21 | |
*** StevenK has joined #openstack-nova | 02:22 | |
*** unicell has quit IRC | 02:23 | |
*** lixiaoy1 has quit IRC | 02:23 | |
*** Jeffrey4l has joined #openstack-nova | 02:26 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Add a hacking rule for string interpolation at logging https://review.openstack.org/334844 | 02:30 |
*** shaohe_feng has quit IRC | 02:31 | |
*** baoli has joined #openstack-nova | 02:32 | |
*** shaohe_feng has joined #openstack-nova | 02:34 | |
*** yamahata has quit IRC | 02:34 | |
*** tonytan4ever has joined #openstack-nova | 02:35 | |
*** mingyu has joined #openstack-nova | 02:39 | |
*** jamielennox|away is now known as jamielennox | 02:41 | |
*** shaohe_feng has quit IRC | 02:41 | |
*** TravT has quit IRC | 02:42 | |
*** shaohe_feng has joined #openstack-nova | 02:42 | |
*** ducttape_ has joined #openstack-nova | 02:48 | |
*** TravT has joined #openstack-nova | 02:51 | |
*** shaohe_feng has quit IRC | 02:52 | |
*** zerda2 has joined #openstack-nova | 02:52 | |
*** baoli has quit IRC | 02:52 | |
*** shaohe_feng has joined #openstack-nova | 02:53 | |
*** ljxiash has quit IRC | 02:53 | |
*** sdake has quit IRC | 02:53 | |
*** ducttape_ has quit IRC | 02:53 | |
*** kaisers_ has joined #openstack-nova | 02:55 | |
*** ljxiash has joined #openstack-nova | 02:56 | |
*** ljxiash has quit IRC | 02:58 | |
*** ljxiash has joined #openstack-nova | 02:59 | |
*** kaisers_ has quit IRC | 02:59 | |
*** TravT has quit IRC | 03:00 | |
*** shaohe_feng has quit IRC | 03:02 | |
*** shaohe_feng has joined #openstack-nova | 03:02 | |
*** gyee has quit IRC | 03:03 | |
*** TravT has joined #openstack-nova | 03:05 | |
*** thorst has joined #openstack-nova | 03:07 | |
*** baoli has joined #openstack-nova | 03:10 | |
*** mingyu has quit IRC | 03:10 | |
*** mingyu has joined #openstack-nova | 03:11 | |
*** abalutoiu_ has joined #openstack-nova | 03:12 | |
*** shaohe_feng has quit IRC | 03:12 | |
*** sdake has joined #openstack-nova | 03:12 | |
*** shaohe_feng has joined #openstack-nova | 03:13 | |
*** TravT has quit IRC | 03:14 | |
*** thumpba has joined #openstack-nova | 03:15 | |
*** abalutoiu has quit IRC | 03:15 | |
*** mingyu has quit IRC | 03:15 | |
*** thorst has quit IRC | 03:16 | |
*** baoli has quit IRC | 03:17 | |
*** thumpba has quit IRC | 03:18 | |
*** TravT has joined #openstack-nova | 03:19 | |
*** mingyu has joined #openstack-nova | 03:19 | |
*** ljxiash has quit IRC | 03:20 | |
*** salv-orlando has joined #openstack-nova | 03:22 | |
*** shaohe_feng has quit IRC | 03:22 | |
*** shaohe_feng has joined #openstack-nova | 03:23 | |
*** RuiChen has joined #openstack-nova | 03:24 | |
*** ljxiash has joined #openstack-nova | 03:26 | |
*** erlon has quit IRC | 03:26 | |
*** salv-orlando has quit IRC | 03:28 | |
openstackgerrit | Jianghua Wang proposed openstack/nova-specs: Xenapi: a new VDI store via streaming https://review.openstack.org/274045 | 03:28 |
*** eliqiao has quit IRC | 03:29 | |
*** ljxiash has quit IRC | 03:30 | |
*** eliqiao has joined #openstack-nova | 03:31 | |
*** ducttape_ has joined #openstack-nova | 03:31 | |
*** TravT has quit IRC | 03:33 | |
*** shaohe_feng has quit IRC | 03:33 | |
*** shaohe_feng has joined #openstack-nova | 03:33 | |
*** TravT has joined #openstack-nova | 03:34 | |
*** TravT has quit IRC | 03:35 | |
*** TravT has joined #openstack-nova | 03:35 | |
*** ducttape_ has quit IRC | 03:36 | |
*** oanson has joined #openstack-nova | 03:40 | |
*** shaohe_feng has quit IRC | 03:43 | |
*** shaohe_feng has joined #openstack-nova | 03:44 | |
*** dikonoor has joined #openstack-nova | 03:46 | |
*** sheel has joined #openstack-nova | 03:48 | |
*** harlowja_at_home has joined #openstack-nova | 03:52 | |
*** shaohe_feng has quit IRC | 03:53 | |
*** links has joined #openstack-nova | 03:54 | |
*** shaohe_feng has joined #openstack-nova | 03:54 | |
*** tbachman has joined #openstack-nova | 03:57 | |
*** lpetrut has joined #openstack-nova | 03:59 | |
*** dimtruck is now known as zz_dimtruck | 03:59 | |
*** oanson has quit IRC | 04:00 | |
*** thumpba has joined #openstack-nova | 04:00 | |
*** unicell has joined #openstack-nova | 04:02 | |
*** shaohe_feng has quit IRC | 04:03 | |
*** thumpba has quit IRC | 04:06 | |
*** shaohe_feng has joined #openstack-nova | 04:06 | |
*** kaisers_ has joined #openstack-nova | 04:07 | |
*** kaisers_ has quit IRC | 04:07 | |
*** links has quit IRC | 04:09 | |
*** wcriswelc has joined #openstack-nova | 04:11 | |
*** stewie925 has quit IRC | 04:12 | |
*** links has joined #openstack-nova | 04:12 | |
*** xenogear has quit IRC | 04:13 | |
*** shaohe_feng has quit IRC | 04:14 | |
*** wcriswell has quit IRC | 04:14 | |
*** shaohe_feng has joined #openstack-nova | 04:14 | |
*** thumpba has joined #openstack-nova | 04:15 | |
*** thorst has joined #openstack-nova | 04:15 | |
*** RuiChen has quit IRC | 04:18 | |
*** diga has joined #openstack-nova | 04:18 | |
*** sree has joined #openstack-nova | 04:20 | |
*** thorst has quit IRC | 04:21 | |
*** harlowja_at_home has quit IRC | 04:22 | |
*** ljxiash has joined #openstack-nova | 04:23 | |
*** salv-orlando has joined #openstack-nova | 04:24 | |
*** shaohe_feng has quit IRC | 04:24 | |
*** shaohe_feng has joined #openstack-nova | 04:25 | |
*** TravT has quit IRC | 04:25 | |
*** thumpba has quit IRC | 04:27 | |
*** stewie925 has joined #openstack-nova | 04:27 | |
*** ljxiash has quit IRC | 04:27 | |
*** TravT has joined #openstack-nova | 04:28 | |
*** salv-orlando has quit IRC | 04:28 | |
*** lpetrut has quit IRC | 04:30 | |
*** jamielennox is now known as jamielennox|away | 04:30 | |
*** bks has joined #openstack-nova | 04:31 | |
*** vishwanathj has quit IRC | 04:32 | |
*** chandankumar has joined #openstack-nova | 04:33 | |
*** liverpooler has quit IRC | 04:34 | |
*** shaohe_feng has quit IRC | 04:34 | |
*** shaohe_feng has joined #openstack-nova | 04:35 | |
*** thumpba has joined #openstack-nova | 04:36 | |
*** GB21 has joined #openstack-nova | 04:39 | |
*** shaohe_feng has quit IRC | 04:44 | |
*** shaohe_feng has joined #openstack-nova | 04:45 | |
*** mingyu has quit IRC | 04:47 | |
*** TravT has quit IRC | 04:47 | |
*** TravT has joined #openstack-nova | 04:51 | |
*** jamielennox|away is now known as jamielennox | 04:51 | |
*** shaohe_feng has quit IRC | 04:55 | |
*** shaohe_feng has joined #openstack-nova | 04:55 | |
*** ducttape_ has joined #openstack-nova | 04:57 | |
*** yamahata has joined #openstack-nova | 05:00 | |
*** adisky has joined #openstack-nova | 05:00 | |
*** ducttape_ has quit IRC | 05:02 | |
*** GB21 has quit IRC | 05:03 | |
*** GB21 has joined #openstack-nova | 05:03 | |
*** takedakn has joined #openstack-nova | 05:04 | |
*** mingyu has joined #openstack-nova | 05:04 | |
*** ratailor has joined #openstack-nova | 05:05 | |
*** TravT has quit IRC | 05:05 | |
*** shaohe_feng has quit IRC | 05:05 | |
*** shaohe_feng has joined #openstack-nova | 05:06 | |
*** moshele has joined #openstack-nova | 05:08 | |
*** pbandark has joined #openstack-nova | 05:08 | |
*** takedakn has quit IRC | 05:09 | |
*** TravT has joined #openstack-nova | 05:09 | |
*** TravT has quit IRC | 05:14 | |
*** browne has joined #openstack-nova | 05:14 | |
*** salv-orlando has joined #openstack-nova | 05:14 | |
*** shaohe_feng has quit IRC | 05:15 | |
*** shaohe_feng has joined #openstack-nova | 05:16 | |
*** ekuris has joined #openstack-nova | 05:17 | |
*** moshele has quit IRC | 05:19 | |
*** thorst has joined #openstack-nova | 05:20 | |
*** browne has quit IRC | 05:20 | |
openstackgerrit | Taku Izumi proposed openstack/nova-specs: libvirt: Time synchronization with qemu guest agent when resuming VM https://review.openstack.org/347625 | 05:21 |
*** maestropandy has joined #openstack-nova | 05:21 | |
*** ljxiash has joined #openstack-nova | 05:24 | |
*** oanson has joined #openstack-nova | 05:24 | |
*** GB21 has quit IRC | 05:25 | |
*** shaohe_feng has quit IRC | 05:25 | |
*** thorst has quit IRC | 05:26 | |
*** beagles has quit IRC | 05:26 | |
*** shaohe_feng has joined #openstack-nova | 05:26 | |
*** GB21 has joined #openstack-nova | 05:27 | |
*** bks has quit IRC | 05:29 | |
*** ljxiash has quit IRC | 05:29 | |
*** muawiakhan has joined #openstack-nova | 05:31 | |
*** shaohe_feng has quit IRC | 05:36 | |
*** shaohe_feng has joined #openstack-nova | 05:37 | |
*** jianghuaw has joined #openstack-nova | 05:37 | |
*** ecelik has joined #openstack-nova | 05:37 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Adjust MySQL access with eventlet https://review.openstack.org/338093 | 05:40 |
*** mingyu has quit IRC | 05:45 | |
*** shaohe_feng has quit IRC | 05:46 | |
*** shaohe_feng has joined #openstack-nova | 05:47 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Remove deprecated configuration option network_device_mtu https://review.openstack.org/319543 | 05:48 |
*** GB21 has quit IRC | 05:49 | |
*** ljxiash has joined #openstack-nova | 05:50 | |
*** GB21 has joined #openstack-nova | 05:51 | |
*** hieulq has joined #openstack-nova | 05:52 | |
*** EinstCrazy has joined #openstack-nova | 05:53 | |
*** maestropandy has quit IRC | 05:54 | |
*** edand has joined #openstack-nova | 05:55 | |
*** coolsvap_ is now known as coolsvap | 05:56 | |
*** shaohe_feng has quit IRC | 05:56 | |
*** shaohe_feng has joined #openstack-nova | 05:57 | |
*** EinstCrazy has quit IRC | 05:58 | |
*** unicell has quit IRC | 05:58 | |
*** ducttape_ has joined #openstack-nova | 05:58 | |
*** thorst has joined #openstack-nova | 06:01 | |
*** EinstCrazy has joined #openstack-nova | 06:02 | |
*** unicell has joined #openstack-nova | 06:02 | |
*** nkrinner_afk is now known as nkrinner | 06:02 | |
*** ducttape_ has quit IRC | 06:02 | |
*** mingyu has joined #openstack-nova | 06:06 | |
*** shaohe_feng has quit IRC | 06:06 | |
*** shaohe_feng has joined #openstack-nova | 06:07 | |
*** thorst has quit IRC | 06:08 | |
*** edand has quit IRC | 06:09 | |
*** EinstCra_ has joined #openstack-nova | 06:12 | |
*** code-R has quit IRC | 06:12 | |
*** code-R has joined #openstack-nova | 06:13 | |
*** tbachman has quit IRC | 06:13 | |
*** GB21 has quit IRC | 06:15 | |
*** GB21 has joined #openstack-nova | 06:16 | |
*** EinstCrazy has quit IRC | 06:16 | |
*** sdake has quit IRC | 06:16 | |
*** shaohe_feng has quit IRC | 06:17 | |
*** shaohe_feng has joined #openstack-nova | 06:18 | |
*** GB21 has quit IRC | 06:21 | |
*** moshele has joined #openstack-nova | 06:25 | |
openstackgerrit | Taku Izumi proposed openstack/nova-specs: libvirt: Time synchronization with qemu guest agent when resuming VM https://review.openstack.org/347625 | 06:26 |
*** abalutoiu_ has quit IRC | 06:26 | |
*** shaohe_feng has quit IRC | 06:27 | |
*** shaohe_feng has joined #openstack-nova | 06:27 | |
*** salv-orl_ has joined #openstack-nova | 06:28 | |
*** salv-orlando has quit IRC | 06:31 | |
*** liverpooler has joined #openstack-nova | 06:31 | |
*** shaohe_feng has quit IRC | 06:37 | |
*** shaohe_feng has joined #openstack-nova | 06:38 | |
*** GB21 has joined #openstack-nova | 06:40 | |
*** tesseract- has joined #openstack-nova | 06:44 | |
*** abalutoiu has joined #openstack-nova | 06:45 | |
*** sdake has joined #openstack-nova | 06:45 | |
*** rcernin has joined #openstack-nova | 06:47 | |
*** cfriesen_ has quit IRC | 06:47 | |
*** shaohe_feng has quit IRC | 06:47 | |
*** shaohe_feng has joined #openstack-nova | 06:48 | |
*** maestropandy has joined #openstack-nova | 06:48 | |
*** ameade has quit IRC | 06:49 | |
*** zhiyan has quit IRC | 06:49 | |
*** briancurtin has quit IRC | 06:49 | |
*** ildikov has quit IRC | 06:50 | |
*** ildikov has joined #openstack-nova | 06:51 | |
*** briancurtin has joined #openstack-nova | 06:52 | |
*** zhiyan has joined #openstack-nova | 06:52 | |
*** ameade has joined #openstack-nova | 06:52 | |
*** thumpba has quit IRC | 06:53 | |
*** nkrinner has quit IRC | 06:54 | |
*** nkrinner has joined #openstack-nova | 06:57 | |
openstackgerrit | Chen Fan proposed openstack/nova: context: change the name 'rule' to 'action' in context.can https://review.openstack.org/347651 | 06:58 |
*** shaohe_feng has quit IRC | 06:58 | |
*** mjura has joined #openstack-nova | 06:58 | |
*** shaohe_feng has joined #openstack-nova | 06:58 | |
*** ljxiash has quit IRC | 06:59 | |
*** ducttape_ has joined #openstack-nova | 06:59 | |
*** sdake has quit IRC | 07:01 | |
*** cfriesen_ has joined #openstack-nova | 07:03 | |
*** ducttape_ has quit IRC | 07:03 | |
*** nkrinner has quit IRC | 07:05 | |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/303345 | 07:07 |
*** thorst has joined #openstack-nova | 07:08 | |
*** shaohe_feng has quit IRC | 07:08 | |
openstackgerrit | MANJUNATH PATIL proposed openstack/nova: Handling devname exception in PCI whitelist. https://review.openstack.org/345925 | 07:08 |
*** sridharg has joined #openstack-nova | 07:08 | |
*** shaohe_feng has joined #openstack-nova | 07:09 | |
*** diga has quit IRC | 07:11 | |
*** thorst has quit IRC | 07:14 | |
*** markus_z has joined #openstack-nova | 07:15 | |
*** thumpba has joined #openstack-nova | 07:15 | |
*** ljxiash has joined #openstack-nova | 07:15 | |
*** nkrinner has joined #openstack-nova | 07:18 | |
*** thumpba has quit IRC | 07:18 | |
*** shaohe_feng has quit IRC | 07:18 | |
*** shaohe_feng has joined #openstack-nova | 07:19 | |
*** amotoki has joined #openstack-nova | 07:19 | |
*** vdrok has quit IRC | 07:22 | |
*** mingyu has quit IRC | 07:22 | |
*** vdrok has joined #openstack-nova | 07:23 | |
*** salv-orlando has joined #openstack-nova | 07:25 | |
*** salv-orl_ has quit IRC | 07:25 | |
*** shaohe_feng has quit IRC | 07:28 | |
*** andreas_s has joined #openstack-nova | 07:29 | |
*** shaohe_feng has joined #openstack-nova | 07:29 | |
*** sc68cal has quit IRC | 07:33 | |
*** sc68cal has joined #openstack-nova | 07:33 | |
*** jlanoux has joined #openstack-nova | 07:34 | |
*** isq_ has quit IRC | 07:34 | |
*** isq_ has joined #openstack-nova | 07:34 | |
*** hemnafk has quit IRC | 07:35 | |
*** adreznec has quit IRC | 07:35 | |
*** diga has joined #openstack-nova | 07:35 | |
*** andrearosa has quit IRC | 07:35 | |
*** hemnafk has joined #openstack-nova | 07:35 | |
*** andrearosa has joined #openstack-nova | 07:35 | |
*** mtreinish has quit IRC | 07:36 | |
*** mtreinish has joined #openstack-nova | 07:36 | |
*** code-R has quit IRC | 07:37 | |
*** jogo has quit IRC | 07:38 | |
*** rdo has quit IRC | 07:38 | |
*** code-R has joined #openstack-nova | 07:38 | |
*** maestropandy has quit IRC | 07:38 | |
*** xenogear has joined #openstack-nova | 07:39 | |
*** shaohe_feng has quit IRC | 07:39 | |
*** shaohe_feng has joined #openstack-nova | 07:39 | |
*** adreznec has joined #openstack-nova | 07:39 | |
*** lennyb has quit IRC | 07:40 | |
*** jogo has joined #openstack-nova | 07:40 | |
*** lennyb has joined #openstack-nova | 07:41 | |
openstackgerrit | Chen Fan proposed openstack/nova: policy: verifying forced_host's target should have self.project_id https://review.openstack.org/347673 | 07:41 |
*** takedakn has joined #openstack-nova | 07:42 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata https://review.openstack.org/331996 | 07:47 |
*** shaohe_feng has quit IRC | 07:49 | |
*** shaohe_feng has joined #openstack-nova | 07:49 | |
bauzas | good morning Nova | 07:56 |
*** tonytan4ever has quit IRC | 07:58 | |
*** GB21 has quit IRC | 07:58 | |
*** tonytan4ever has joined #openstack-nova | 07:59 | |
*** shaohe_feng has quit IRC | 07:59 | |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-nova | 08:00 | |
*** ducttape_ has joined #openstack-nova | 08:00 | |
*** shaohe_feng has joined #openstack-nova | 08:00 | |
*** derekh has joined #openstack-nova | 08:03 | |
*** ducttape_ has quit IRC | 08:04 | |
*** sameo has joined #openstack-nova | 08:05 | |
*** chandankumar has quit IRC | 08:07 | |
*** phschwartz has quit IRC | 08:08 | |
*** phschwartz has joined #openstack-nova | 08:08 | |
*** jogo has quit IRC | 08:09 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova: NUMA: include orphan threads with policy prefer https://review.openstack.org/344992 | 08:09 |
*** ihrachys has joined #openstack-nova | 08:09 | |
*** shaohe_feng has quit IRC | 08:09 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/303345 | 08:10 |
*** shaohe_feng has joined #openstack-nova | 08:10 | |
*** salv-orlando has quit IRC | 08:10 | |
*** jdurgin has quit IRC | 08:11 | |
*** tonytan4ever has quit IRC | 08:11 | |
*** danpb has joined #openstack-nova | 08:11 | |
*** thorst has joined #openstack-nova | 08:11 | |
*** chandankumar has joined #openstack-nova | 08:11 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova: NUMA: fix require policy assume 2 threads per core https://review.openstack.org/346207 | 08:11 |
*** jogo has joined #openstack-nova | 08:11 | |
*** salv-orlando has joined #openstack-nova | 08:12 | |
*** yassine has joined #openstack-nova | 08:12 | |
*** jdurgin has joined #openstack-nova | 08:12 | |
*** yassine is now known as Guest9888 | 08:13 | |
*** hoonetorg has quit IRC | 08:13 | |
*** gszasz has joined #openstack-nova | 08:15 | |
*** jlanoux has quit IRC | 08:16 | |
*** jlanoux has joined #openstack-nova | 08:16 | |
*** RuiChen has joined #openstack-nova | 08:17 | |
*** hoonetorg has joined #openstack-nova | 08:17 | |
*** salv-orlando has quit IRC | 08:17 | |
*** thorst has quit IRC | 08:18 | |
*** mingyu has joined #openstack-nova | 08:18 | |
*** shaohe_feng has quit IRC | 08:20 | |
*** shaohe_feng has joined #openstack-nova | 08:20 | |
*** code-R has quit IRC | 08:21 | |
*** hshiina has joined #openstack-nova | 08:22 | |
*** diga has quit IRC | 08:24 | |
*** lucas-dinner is now known as lucasagomes | 08:24 | |
*** sudipto has joined #openstack-nova | 08:25 | |
*** shaohe_feng has quit IRC | 08:30 | |
*** shaohe_feng has joined #openstack-nova | 08:30 | |
*** takedakn1 has joined #openstack-nova | 08:33 | |
*** takedakn has quit IRC | 08:33 | |
*** takedakn1 is now known as takedakn | 08:33 | |
*** shaohe_feng has quit IRC | 08:40 | |
*** shaohe_feng has joined #openstack-nova | 08:40 | |
lyarwood | Morning all, I'm looking for core reviews on https://review.openstack.org/#/c/318266/ if anyone has the time this morning. | 08:41 |
*** priteau has joined #openstack-nova | 08:43 | |
*** rdo has joined #openstack-nova | 08:44 | |
*** efoley has joined #openstack-nova | 08:44 | |
*** EinstCra_ has quit IRC | 08:45 | |
*** EinstCrazy has joined #openstack-nova | 08:46 | |
*** efoley_ has joined #openstack-nova | 08:46 | |
*** zhangjn has quit IRC | 08:47 | |
*** EinstCrazy has quit IRC | 08:47 | |
*** EinstCrazy has joined #openstack-nova | 08:47 | |
*** roeyc has joined #openstack-nova | 08:49 | |
*** efoley has quit IRC | 08:49 | |
*** shaohe_feng has quit IRC | 08:50 | |
*** shaohe_feng has joined #openstack-nova | 08:51 | |
*** zhangjn has joined #openstack-nova | 08:52 | |
*** GB21 has joined #openstack-nova | 08:53 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova: Call release_dhcp via RPC to ensure correct host https://review.openstack.org/325361 | 08:53 |
artom | lyarwood, your time zone condemns you :) | 08:55 |
*** bks has joined #openstack-nova | 08:56 | |
artom | Looking at that review, mriedem and dansmith are involved, you might have a better chance if you catch them when they wake up | 08:56 |
lyarwood | artom: haha yeah, that or they are all hiding1 | 08:56 |
*** priteau has quit IRC | 08:57 | |
lyarwood | artom: yeah, just wanted to get some additional eyes on it now while I'm around to sort any issues out | 08:57 |
* lyarwood has a growing backlog of bugfixes to get reviewed | 08:57 | |
lyarwood | artom: why on earth are you awake at this time btw? :D | 08:57 |
*** hshiina has quit IRC | 08:57 | |
openstackgerrit | Chen Fan proposed openstack/nova: policy: verifying forced_host's target should have context.project_id https://review.openstack.org/347673 | 08:58 |
artom | lyarwood, if you ever find an answer to that question, let me know | 08:58 |
lyarwood | artom: ah forgot, kids :) | 08:59 |
artom | lyarwood, hah, not even, both are sleeping soundly, not that it was ever an issue for the oldest | 09:00 |
artom | I just... woke up | 09:00 |
artom | And since once I'm awake it takes me hours to get back to sleep... | 09:00 |
artom | Might as well get some Nova time in, since the day will likely consists of other stuff | 09:00 |
*** ducttape_ has joined #openstack-nova | 09:01 | |
*** tonytan4ever has joined #openstack-nova | 09:01 | |
*** shaohe_feng has quit IRC | 09:01 | |
*** shaohe_feng has joined #openstack-nova | 09:01 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: test_keypairs_list_for_different_users for v2.10 https://review.openstack.org/347462 | 09:02 |
artom | lyarwood, shoot me a review for one of those bugfixes - I'd be useless on that driver detach patch, but I have time for other endeavours :) | 09:02 |
*** tonytan4ever has quit IRC | 09:05 | |
*** ducttape_ has quit IRC | 09:05 | |
*** efoley__ has joined #openstack-nova | 09:07 | |
*** GB21 has quit IRC | 09:07 | |
*** efoley_ has quit IRC | 09:09 | |
*** GB21 has joined #openstack-nova | 09:11 | |
*** fragatina has joined #openstack-nova | 09:11 | |
*** shaohe_feng has quit IRC | 09:11 | |
*** fragatina has quit IRC | 09:11 | |
*** fragatina has joined #openstack-nova | 09:12 | |
*** shaohe_feng has joined #openstack-nova | 09:12 | |
*** thorst has joined #openstack-nova | 09:16 | |
*** EinstCrazy has quit IRC | 09:17 | |
*** fragatina has quit IRC | 09:17 | |
*** ljxiash has quit IRC | 09:19 | |
*** maestropandy has joined #openstack-nova | 09:19 | |
*** GB21 has quit IRC | 09:20 | |
*** shaohe_feng has quit IRC | 09:21 | |
*** shaohe_feng has joined #openstack-nova | 09:22 | |
*** thorst has quit IRC | 09:23 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Fix wrong override value of config option vswitch_name https://review.openstack.org/328691 | 09:24 |
*** EinstCra_ has joined #openstack-nova | 09:25 | |
*** fragatina has joined #openstack-nova | 09:26 | |
*** EinstCra_ has quit IRC | 09:27 | |
*** EinstCrazy has joined #openstack-nova | 09:28 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Fix wrong override value of config option proxyclient_address https://review.openstack.org/328698 | 09:30 |
lyarwood | artom: yo sorry missed your last, https://review.openstack.org/#/q/status:open+topic:%255Ebug.*+branch:master+owner:%22Lee+Yarwood+%253Clyarwood%2540redhat.com%253E%22 , I'll sort the conflicts out shortly. | 09:31 |
*** nherciu has joined #openstack-nova | 09:31 | |
*** fragatina has quit IRC | 09:31 | |
*** shaohe_feng has quit IRC | 09:31 | |
openstackgerrit | Lee Yarwood proposed openstack/nova: libvirt: Use the recreated config disk during a rescue https://review.openstack.org/335884 | 09:32 |
*** shaohe_feng has joined #openstack-nova | 09:32 | |
openstackgerrit | Lee Yarwood proposed openstack/nova: libvirt: Fix the clean up of resize-revert for volume backed instances https://review.openstack.org/329030 | 09:32 |
openstackgerrit | Lee Yarwood proposed openstack/nova: compute: Use stashed connector during local deletes https://review.openstack.org/340951 | 09:32 |
openstackgerrit | Lee Yarwood proposed openstack/nova: block_device: Make refresh_conn_infos py3 compatible https://review.openstack.org/342111 | 09:32 |
*** dansmith has quit IRC | 09:33 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Make sure config option public_interface with correct override value https://review.openstack.org/325749 | 09:33 |
*** dansmith has joined #openstack-nova | 09:35 | |
*** dansmith is now known as Guest41069 | 09:35 | |
*** ftersin has joined #openstack-nova | 09:40 | |
*** muawiakhan has quit IRC | 09:41 | |
*** muawiakhan has joined #openstack-nova | 09:41 | |
*** EinstCra_ has joined #openstack-nova | 09:42 | |
*** shaohe_feng has quit IRC | 09:42 | |
*** shaohe_feng has joined #openstack-nova | 09:42 | |
*** EinstCrazy has quit IRC | 09:43 | |
openstackgerrit | Jianghua Wang proposed openstack/nova-specs: XenAPI: support VGPU via passthrough PCI https://review.openstack.org/280099 | 09:45 |
*** hoobaman has joined #openstack-nova | 09:45 | |
hoobaman | hi | 09:45 |
*** rdo has quit IRC | 09:45 | |
hoobaman | i am currently testing qos frontend support in liberty | 09:45 |
*** muawiakhan has quit IRC | 09:45 | |
hoobaman | however it cannot set these extra specs through horizon, the qos frontend functionality included in horizon does not seem to be libvirt/nova related | 09:47 |
hoobaman | it only works through nova manage | 09:47 |
hoobaman | is this normal? | 09:47 |
*** liusheng has quit IRC | 09:47 | |
*** roeyc has quit IRC | 09:48 | |
*** tangchen has quit IRC | 09:50 | |
*** tangchen_ has quit IRC | 09:50 | |
*** yuelongguang has quit IRC | 09:50 | |
*** shaohe_feng has quit IRC | 09:52 | |
*** shaohe_feng has joined #openstack-nova | 09:53 | |
ftersin | hoobaman: hi. you probably need to ask it in horizon channel | 09:56 |
hoobaman | ftersin: ok thx for the feedback :) | 09:57 |
*** maestropandy has quit IRC | 09:57 | |
ftersin | btw, recently i successfully set custom extra specs via horizon on liberty | 09:57 |
hoobaman | ftersin: can you share on how you dit this? :) | 09:57 |
ftersin | on existing flavor click metadata (or edit), then type key name on the left side and key value on the right side | 09:59 |
*** muawiakhan has joined #openstack-nova | 10:00 | |
ftersin | the extra specs key was not related to qos, but it was my custom key | 10:00 |
ftersin | i saw that the pop-up had some pre-existing keys, but did not try to use them | 10:01 |
ftersin | anyway, i believe this is offtopic here :/ | 10:01 |
hoobaman | ftersin: ok many thanks, i look into it | 10:02 |
*** shaohe_feng has quit IRC | 10:02 | |
*** shaohe_feng has joined #openstack-nova | 10:03 | |
*** tangchen_ has joined #openstack-nova | 10:04 | |
*** tangchen has joined #openstack-nova | 10:04 | |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: [libvirt] Remove live_migration_flag & block_migration_flag https://review.openstack.org/334860 | 10:05 |
*** mvk has quit IRC | 10:07 | |
*** muawiakhan has quit IRC | 10:08 | |
*** edand has joined #openstack-nova | 10:12 | |
*** shaohe_feng has quit IRC | 10:12 | |
*** EinstCra_ has quit IRC | 10:13 | |
*** EinstCrazy has joined #openstack-nova | 10:13 | |
*** shaohe_feng has joined #openstack-nova | 10:13 | |
openstackgerrit | Chen Fan proposed openstack/nova: exception: throw a NotFound exception when we don't find the flavor https://review.openstack.org/347745 | 10:19 |
openstackgerrit | Gábor Antal proposed openstack/nova: Fixed invalid UUIDs in unit tests https://review.openstack.org/347748 | 10:22 |
*** shaohe_feng has quit IRC | 10:23 | |
*** thorst has joined #openstack-nova | 10:23 | |
openstackgerrit | Alexis Lee proposed openstack/nova: VNC: Strip cookies containing brackets https://review.openstack.org/347750 | 10:23 |
*** shaohe_feng has joined #openstack-nova | 10:24 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova: doc: fix disk=0 use case in flavor doc https://review.openstack.org/339034 | 10:26 |
*** maestropandy has joined #openstack-nova | 10:27 | |
*** gabor_antal has joined #openstack-nova | 10:28 | |
*** thorst has quit IRC | 10:29 | |
*** ociuhandu has joined #openstack-nova | 10:30 | |
openstackgerrit | Alexis Lee proposed openstack/nova: VNC: Strip cookies containing brackets https://review.openstack.org/347750 | 10:31 |
*** hoangcx has quit IRC | 10:33 | |
*** shaohe_feng has quit IRC | 10:33 | |
*** shaohe_feng has joined #openstack-nova | 10:33 | |
openstackgerrit | MANJUNATH PATIL proposed openstack/nova: Handling devname exception in PCI whitelist. https://review.openstack.org/345925 | 10:34 |
*** mvk has joined #openstack-nova | 10:38 | |
*** tbachman has joined #openstack-nova | 10:38 | |
*** Satya_ has joined #openstack-nova | 10:38 | |
Satya_ | Hi | 10:38 |
*** Satya_ has quit IRC | 10:39 | |
*** hoangcx has joined #openstack-nova | 10:41 | |
*** shaohe_feng has quit IRC | 10:43 | |
*** takedakn has quit IRC | 10:45 | |
*** shaohe_feng has joined #openstack-nova | 10:46 | |
*** sudipto has quit IRC | 10:47 | |
*** yamahata has quit IRC | 10:48 | |
*** maestropandy has quit IRC | 10:51 | |
*** shaohe_feng has quit IRC | 10:53 | |
*** shaohe_feng has joined #openstack-nova | 10:54 | |
*** yuikotakadamori has joined #openstack-nova | 11:00 | |
*** mingyu has quit IRC | 11:03 | |
*** rtheis has joined #openstack-nova | 11:03 | |
*** shaohe_feng has quit IRC | 11:04 | |
*** shaohe_feng has joined #openstack-nova | 11:05 | |
*** mingyu has joined #openstack-nova | 11:05 | |
*** zhs__ has quit IRC | 11:08 | |
*** zhs__ has joined #openstack-nova | 11:09 | |
*** salv-orlando has joined #openstack-nova | 11:09 | |
*** mingyu has quit IRC | 11:10 | |
*** roeyc has joined #openstack-nova | 11:10 | |
*** rmart04 has joined #openstack-nova | 11:12 | |
*** zerda2 has quit IRC | 11:12 | |
*** lucasagomes is now known as lucas-hungry | 11:13 | |
*** shaohe_feng has quit IRC | 11:14 | |
*** shaohe_feng has joined #openstack-nova | 11:15 | |
danpb | markus_z: did you see my Q on the qemu bug about virtlogd | 11:16 |
tdurakov | hi folks | 11:18 |
*** bvanhav has joined #openstack-nova | 11:18 | |
tdurakov | do we have any guides on api-ref? I wonder how this should be done: https://review.openstack.org/#/c/345652/2/api-ref/source/parameters.yaml | 11:18 |
*** hoangcx2 has joined #openstack-nova | 11:21 | |
*** hoangcx has quit IRC | 11:21 | |
*** rdo has joined #openstack-nova | 11:23 | |
artom | tdurakov, hrmm, maybe have two block_migration params? | 11:23 |
artom | One boolean, pre-2.25, one string, post-2.25? | 11:23 |
tdurakov | artom: yeah, I was thinking about it, or as alternative it's possible to mention about the change in description | 11:24 |
*** shaohe_feng has quit IRC | 11:24 | |
*** takedakn has joined #openstack-nova | 11:25 | |
*** muawiakhan has joined #openstack-nova | 11:26 | |
openstackgerrit | Yuiko Takada Mori proposed openstack/nova: Move OVSvApp driver to from networking-vsphere repository https://review.openstack.org/347772 | 11:26 |
*** thorst has joined #openstack-nova | 11:26 | |
artom | tdurakov, the two params thing might not pass tests, something might complain about duplicate params | 11:26 |
artom | But if it works I think I'd prefer that, FWIW | 11:27 |
*** shaohe_feng has joined #openstack-nova | 11:27 | |
tdurakov | artom: yes, I haven't found pattern you proposed in current paramseters.yaml, but for me it seems ok | 11:27 |
tdurakov | if it pass all generations and tests, of course | 11:27 |
artom | I know in novaclient, when a command line argument had a new key added, that's what I did to reflect the change in the help text: https://review.openstack.org/#/c/299222/20/novaclient/v2/shell.py@442 | 11:28 |
artom | I realize it's a different context entirely, but the larger logic is the same | 11:28 |
tdurakov | artom, feel free to review:) | 11:29 |
artom | (In that link specifically, --block-device got a new tag key in 2.32, so I put two --block-device, each with a different help text and wrapped in versioned utils.args) | 11:29 |
*** sdague has joined #openstack-nova | 11:30 | |
kevin_zh | danpb: Hi Daniel, I have sent you an email about the bug "Nova can't delete instance with nvram", if you have a moment, pls give some comments | 11:30 |
*** thorst has quit IRC | 11:31 | |
kevin_zh | danpb: The title is "Question about : Qemu: don't refuse to undefine a guest with NVRAM file". Big Thanks~ | 11:31 |
danpb | [please just keep discussion on the reviews | 11:31 |
*** takedakn has quit IRC | 11:32 | |
*** ociuhandu has quit IRC | 11:33 | |
Cassowary_ | Hi all, does anyone know the reason for, VM resizing time to increase faster if you continuously increase CPU or DISK resources by +1 (e.g. 1-2, 2-3, 3-4, 4-5). Whereas, when you increase from 1 to any other (e.g. 1-2, 1-2, 1,3, 1-4, 1-5) it takes less time in comparison. Can anyone give an explanation for this? I have plotted two graphs. | 11:33 |
Cassowary_ | https://www.dropbox.com/s/5e8xrrctu0rcwx3/CPU%20scaling%20%20-%20continuous%20vs%20increasing%20from%201.png?dl=0 | 11:33 |
Cassowary_ | https://www.dropbox.com/s/txpkb8k6mpyexv8/CPU%20scaling%20-%20increase%20from%201.png?dl=0 | 11:33 |
Cassowary_ | The first graph shows the VM CPU resize time (y axis) vs number of vCPUs (x axis) of continuous (blue) and resize from a VM with 1 vCPU (green) scenarios.The second graph shows the VM CPU resize time (y axis) vs number of vCPUs (x axis), when resized from a VM with 1 vCPU at each step (The green line in first graph). The error bars show the standard error of | 11:33 |
Cassowary_ | the gathered values at each step, as I did resize multiple times to get a mean value. | 11:33 |
Cassowary_ | Thanks! | 11:33 |
*** shaohe_feng has quit IRC | 11:34 | |
*** shaohe_feng has joined #openstack-nova | 11:35 | |
*** ociuhandu has joined #openstack-nova | 11:35 | |
tdurakov | Cassowary_: it's strange, because especially cpu resize is only kind of editing domain definition, disk resize is almost the same as qemu-img resize afair | 11:37 |
Cassowary_ | tdurakov: :( | 11:39 |
Cassowary_ | I thought I was missing something here. | 11:40 |
kevin_zh | danpb: OK~ I am not sure that for bug 1567807 "nova delete doesn't work with EFI booted VMs", we need to modify Nova to fix it or wait for libvirt to change its code(change to "don't refuse to undefine a guest with NVRAM file")? | 11:40 |
openstack | bug 1567807 in OpenStack Compute (nova) "nova delete doesn't work with EFI booted VMs" [Low,In progress] https://launchpad.net/bugs/1567807 - Assigned to Ching Kuo (gene-kuo) | 11:40 |
artom | tdurakov, I posted what can only be described as a rant on that review :P | 11:41 |
*** diga has joined #openstack-nova | 11:41 | |
*** shaohe_feng has quit IRC | 11:45 | |
kevin_zh | danpb: I see you have submited a patch to libvirt for this in 2015 | 11:45 |
*** Sukhdev has joined #openstack-nova | 11:45 | |
*** shaohe_feng has joined #openstack-nova | 11:45 | |
danpb | kevin_zh: i've commented on the review https://review.openstack.org/#/c/335512/4 | 11:46 |
kevin_zh | danpb: Great ~ Thanks~ | 11:47 |
*** cdelatte has joined #openstack-nova | 11:48 | |
*** thorst has joined #openstack-nova | 11:49 | |
*** erlon has joined #openstack-nova | 11:51 | |
*** takedakn has joined #openstack-nova | 11:54 | |
*** shaohe_feng has quit IRC | 11:55 | |
*** shaohe_feng has joined #openstack-nova | 11:55 | |
*** thorst has quit IRC | 11:56 | |
*** rfolco has joined #openstack-nova | 12:00 | |
*** thorst has joined #openstack-nova | 12:02 | |
*** ducttape_ has joined #openstack-nova | 12:03 | |
*** sree has quit IRC | 12:04 | |
*** ducttape_ has quit IRC | 12:05 | |
*** kevin_zh is now known as kevinz | 12:05 | |
*** shaohe_feng has quit IRC | 12:05 | |
*** ducttape_ has joined #openstack-nova | 12:06 | |
*** shaohe_feng has joined #openstack-nova | 12:06 | |
*** rodrigods has quit IRC | 12:09 | |
*** rodrigods has joined #openstack-nova | 12:09 | |
markus_z | danpb: yes, I've seen it, thanks for pinging me though. I still have that system, so I should have that command you're asking for somewhere in the qemu logs I guess? | 12:10 |
danpb | yep | 12:10 |
markus_z | OK, I'll collect that and update the bug report. | 12:11 |
*** andymaier has joined #openstack-nova | 12:12 | |
*** pradk has joined #openstack-nova | 12:12 | |
*** aysyd has joined #openstack-nova | 12:12 | |
*** ratailor has quit IRC | 12:12 | |
eliqiao | hi johnthetubaguy , around? | 12:13 |
johnthetubaguy | yep yep | 12:13 |
eliqiao | alex_xu just noticed me that he can not host today's meeting. | 12:14 |
openstackgerrit | NolwennCauchois proposed openstack/nova: Clean up second ephemeral disk https://review.openstack.org/341008 | 12:14 |
eliqiao | would you give a hand? johnthetubaguy | 12:14 |
*** ljxiash has joined #openstack-nova | 12:14 | |
johnthetubaguy | happy to, although sdague might have more context in his head to help drive that. | 12:15 |
eliqiao | okay, that would be great help. thanks you :) | 12:15 |
eliqiao | s/s// | 12:15 |
*** shaohe_feng has quit IRC | 12:15 | |
*** maestropandy has joined #openstack-nova | 12:16 | |
*** shaohe_feng has joined #openstack-nova | 12:16 | |
*** lucas-hungry is now known as lucasagomes | 12:17 | |
*** tonytan4ever has joined #openstack-nova | 12:17 | |
*** ljxiash has quit IRC | 12:19 | |
*** tonytan4ever has quit IRC | 12:22 | |
*** ducttape_ has quit IRC | 12:22 | |
*** claudiub has joined #openstack-nova | 12:22 | |
openstackgerrit | John Garbutt proposed openstack/nova: Option registration consistency for availability_zone.py https://review.openstack.org/344466 | 12:22 |
*** sdake has joined #openstack-nova | 12:23 | |
openstackgerrit | Arnaud Morin proposed openstack/nova: Add a small debug line to show selection location https://review.openstack.org/338736 | 12:25 |
*** shaohe_feng has quit IRC | 12:26 | |
*** shaohe_feng has joined #openstack-nova | 12:27 | |
*** yuikotakadamori has quit IRC | 12:27 | |
openstackgerrit | John Garbutt proposed openstack/nova: Option Consistency for availability_zone.py https://review.openstack.org/344466 | 12:28 |
openstackgerrit | John Garbutt proposed openstack/nova: Deprecate barbican options https://review.openstack.org/317684 | 12:30 |
*** diga has quit IRC | 12:31 | |
*** chandankumar has quit IRC | 12:31 | |
sdague | johnthetubaguy: after the month of non regular work, I'm not sure I do. But I'll be there :) | 12:32 |
*** beagles has joined #openstack-nova | 12:35 | |
*** shaohe_feng has quit IRC | 12:36 | |
anush- | mikal: could you please take a look at https://review.openstack.org/#/c/332650/ again. tox was failing due to expected carriage return and I made that change between patch 11 & 12 | 12:36 |
*** shaohe_feng has joined #openstack-nova | 12:36 | |
*** JoseMello has joined #openstack-nova | 12:38 | |
*** claudiub|2 has joined #openstack-nova | 12:39 | |
*** gmann_ has joined #openstack-nova | 12:40 | |
*** EinstCrazy has quit IRC | 12:40 | |
*** vishwanathj has joined #openstack-nova | 12:42 | |
openstackgerrit | Gleb Stepanov proposed openstack/nova: [WIP] Init allocated ports set https://review.openstack.org/347479 | 12:42 |
*** claudiub has quit IRC | 12:43 | |
markus_z | danpb: Do you mean this: http://paste.openstack.org/show/542559/ ? | 12:43 |
johnthetubaguy | gibi: curious if you seen this https://review.openstack.org/#/c/321336/5 I think search light needs a few extra things, and we need searchlight to help with cells, although ironically not for the flavor stuff | 12:45 |
*** tbachman has quit IRC | 12:45 | |
danpb | markus_z: yes | 12:46 |
*** shaohe_feng has quit IRC | 12:46 | |
*** c64cosmin has joined #openstack-nova | 12:46 | |
*** shaohe_feng has joined #openstack-nova | 12:47 | |
*** tbachman has joined #openstack-nova | 12:49 | |
*** woodster_ has joined #openstack-nova | 12:49 | |
*** baoli has joined #openstack-nova | 12:49 | |
gibi | johnthetubaguy: looking | 12:50 |
*** baoli_ has joined #openstack-nova | 12:50 | |
johnthetubaguy | gibi: its for ocata, and I haven't looked yet, but it might be a good source of "notification friends" :) | 12:51 |
gibi | johnthetubaguy: I reviewd it in May but I will re-review it now | 12:51 |
sdague | johnthetubaguy - https://review.openstack.org/#/c/347430/ is the os-certificates deprecation | 12:52 |
sdague | that we talked about landing at mid cycle | 12:53 |
*** efoley__ has quit IRC | 12:53 | |
johnthetubaguy | sdague: ah, that came up the other day around some config options | 12:54 |
*** baoli has quit IRC | 12:55 | |
*** sheel has quit IRC | 12:56 | |
*** ekuris has quit IRC | 12:56 | |
danpb | sean-k-mooney: fyi i requested a new os-vif release https://review.openstack.org/#/c/347808/ | 12:56 |
*** shaohe_feng has quit IRC | 12:56 | |
*** shaohe_feng has joined #openstack-nova | 12:57 | |
johnthetubaguy | nova-api meeting time over in -4 | 13:02 |
*** oanson has quit IRC | 13:04 | |
*** tblakeslee has joined #openstack-nova | 13:05 | |
*** coolsvap is now known as coolsvap_ | 13:07 | |
*** shaohe_feng has quit IRC | 13:07 | |
*** shaohe_feng has joined #openstack-nova | 13:07 | |
*** carolynvs has joined #openstack-nova | 13:07 | |
*** links has quit IRC | 13:08 | |
*** vgridnev has joined #openstack-nova | 13:09 | |
*** chandankumar has joined #openstack-nova | 13:10 | |
*** rlrossit has joined #openstack-nova | 13:11 | |
*** mdrabe has joined #openstack-nova | 13:11 | |
openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: Ensure that periodic reclaim cleans DB deleted instances https://review.openstack.org/323250 | 13:11 |
*** carolynvs has quit IRC | 13:11 | |
*** edmondsw has joined #openstack-nova | 13:17 | |
sean-k-mooney | danpb: a thanks for letting me know. how does that work? will a bot automatically tag and push the pip package when that is mergered? | 13:17 |
*** liverpooler has quit IRC | 13:17 | |
*** shaohe_feng has quit IRC | 13:17 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: removed db_exc.DBDuplicateEntry in bw_usage_update https://review.openstack.org/250807 | 13:17 |
danpb | sean-k-mooney: once someone approves that review, its all magic :-) | 13:17 |
*** shaohe_feng has joined #openstack-nova | 13:17 | |
sean-k-mooney | danpb: i have previously done release for networking-ovs-dpdk by hand but ok cool. ill keep an eye on the review | 13:18 |
*** matrohon has joined #openstack-nova | 13:18 | |
*** tosky has joined #openstack-nova | 13:20 | |
*** diana_clarke has joined #openstack-nova | 13:20 | |
*** adisky has quit IRC | 13:21 | |
*** akshai has joined #openstack-nova | 13:21 | |
vgridnev | is there a way to use directly nova-network in current upstream without proxies? we (sahara team) had a nova-network job that was creating security groups, but now it's falling with the following logs: | 13:23 |
vgridnev | http://logs.openstack.org/06/347406/3/check/gate-sahara-dsvm-scenario-nova-heat/391bf43/logs/screen-h-eng.txt.gz?level=WARNING | 13:23 |
*** xyang1 has joined #openstack-nova | 13:24 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: removed db_exc.DBDuplicateEntry in bw_usage_update https://review.openstack.org/250807 | 13:25 |
*** cleong has joined #openstack-nova | 13:26 | |
*** kevinz has quit IRC | 13:26 | |
sdague | vgridnev: that seems to be talking to neutron | 13:27 |
*** shaohe_feng has quit IRC | 13:27 | |
*** shaohe_feng has joined #openstack-nova | 13:28 | |
*** admin0 has joined #openstack-nova | 13:31 | |
*** mriedem has joined #openstack-nova | 13:31 | |
vgridnev | sdague, but actually heat is creating nova client for creating security groups: https://github.com/openstack/heat/blob/master/heat/engine/resources/aws/ec2/security_group.py#L54 | 13:31 |
admin0 | hi all .. if nova schedule is slow . where could the bottlenecks be ? | 13:31 |
*** david-lyle_ has joined #openstack-nova | 13:31 | |
*** david-lyle_ has quit IRC | 13:31 | |
admin0 | sorry | 13:31 |
admin0 | nova shelve | 13:31 |
sdague | vgridnev: the way I read that stack trace is that it's not, it's using neutron client, and there is no neutron endpoint, so it explodes | 13:32 |
*** tjones has joined #openstack-nova | 13:34 | |
*** david-lyle has quit IRC | 13:34 | |
*** eliqiao has quit IRC | 13:34 | |
*** ducttape_ has joined #openstack-nova | 13:36 | |
*** code-R has joined #openstack-nova | 13:37 | |
*** shaohe_feng has quit IRC | 13:37 | |
*** shaohe_feng has joined #openstack-nova | 13:38 | |
*** efried has joined #openstack-nova | 13:40 | |
*** ayoung has joined #openstack-nova | 13:41 | |
*** maestropandy has left #openstack-nova | 13:42 | |
*** eliqiao has joined #openstack-nova | 13:43 | |
*** shaohe_feng has quit IRC | 13:48 | |
*** Guest41069 is now known as dansmith | 13:48 | |
*** shaohe_feng has joined #openstack-nova | 13:49 | |
*** code-R_ has joined #openstack-nova | 13:49 | |
*** ecelik has quit IRC | 13:51 | |
*** code-R has quit IRC | 13:52 | |
-openstackstatus- NOTICE: Gerrit is being restarted now to relieve performance degradation | 13:53 | |
*** kevin_zh has joined #openstack-nova | 13:54 | |
*** takedakn has quit IRC | 13:55 | |
*** ctrath has joined #openstack-nova | 13:56 | |
*** Fdaisuke has joined #openstack-nova | 13:57 | |
lxsli | dansmith: at the midcycle you said the service version flag needs to be mutable, please can you tell me the exact name of that? | 13:57 |
*** shaohe_feng has quit IRC | 13:58 | |
*** gmann_ has quit IRC | 13:58 | |
*** dikonoor has quit IRC | 13:58 | |
dansmith | lxsli: service_version is calculated, it's not a flag.. if you see that somewhere someone probably mistyped or misunderstood | 13:59 |
*** shaohe_feng has joined #openstack-nova | 13:59 | |
*** burt has joined #openstack-nova | 13:59 | |
*** sudipto has joined #openstack-nova | 13:59 | |
*** rmart04 has quit IRC | 13:59 | |
johnthetubaguy | I guess I was thinking about this one: https://github.com/openstack/nova/blob/master/nova/conf/upgrade_levels.py#L98 but if we get that switched to auto, we should be fine | 13:59 |
openstackgerrit | Mark Doffman proposed openstack/nova: Integrate OSprofiler and Nova https://review.openstack.org/254703 | 14:00 |
lxsli | johnthetubaguy: so 'auto' is smart enough to only upgrade the version once all computes will support it? Neat! | 14:01 |
*** kevin_zh has quit IRC | 14:01 | |
johnthetubaguy | lxsli: sig_hup triggers the reload of finding the min service version, its cool | 14:02 |
*** kevin_zh has joined #openstack-nova | 14:02 | |
lxsli | ah I see, OK cool | 14:02 |
*** pilgrimstack has joined #openstack-nova | 14:02 | |
mriedem | sdague: seems we should maybe update the wording on this wiki https://wiki.openstack.org/wiki/VersionDiscovery#id | 14:02 |
mriedem | "Id versions follow semantic versioning and thus backwards compatibility is implied by a version numbering with the same major version and higher minor version number. For example an advertised version of "2.3" will maintain compatibility with of its calls with versions "2.0", "2.1", and "2.2" as well as all included patch versions. " | 14:02 |
mriedem | since that's not true for 2.36 | 14:03 |
mriedem | or 2.37 | 14:03 |
sdague | mriedem: probably, that super predates mv | 14:03 |
mriedem | yeah, it's linked from the api docs though | 14:03 |
*** admin0 has quit IRC | 14:03 | |
sdague | ok, which ones? | 14:03 |
*** jwcroppe has joined #openstack-nova | 14:03 | |
*** admin0 has joined #openstack-nova | 14:03 | |
sdague | and agreed, we should fix that, and pull it all up into rst docs somewhere | 14:04 |
mriedem | http://developer.openstack.org/api-ref.html | 14:04 |
*** pilgrimstack1 has quit IRC | 14:04 | |
mriedem | "This version is under development or contains features that are otherwise subject to change. For more information about API status values and version information, see Version Discovery. " | 14:04 |
mriedem | yikes | 14:04 |
mriedem | the link to 'Version Discovery' | 14:04 |
*** code-R_ has quit IRC | 14:05 | |
sdague | ok, that's in the global api-ref, any idea which repo that is in? | 14:05 |
sdague | it's very specific to keystone actually, looks like it was basically written by jamielennox | 14:05 |
*** code-R has joined #openstack-nova | 14:05 | |
*** cdent has joined #openstack-nova | 14:06 | |
*** eliqiao has quit IRC | 14:06 | |
mikal | Morning | 14:07 |
*** Swami has joined #openstack-nova | 14:07 | |
stevemar | sdague: mriedem we could move that into the keystone v3 specific APIs | 14:07 |
*** code-R_ has joined #openstack-nova | 14:07 | |
dansmith | mikal: ping with fire | 14:07 |
mriedem | sdague: i assume it's openstack-manuals | 14:07 |
mikal | dansmith: please not the fire, anything but that! | 14:07 |
dansmith | heh | 14:08 |
*** ababich has quit IRC | 14:08 | |
mriedem | or now api-ref | 14:08 |
mriedem | *no | 14:08 |
mikal | So I talked to gus and he was going to leave some questions on the review, but I haven't had a chance to check that thing yet | 14:08 |
mikal | But those questions were minor, and he seemed happy enough | 14:08 |
*** shaohe_feng has quit IRC | 14:08 | |
mriedem | https://github.com/openstack/api-site/blob/master/api-ref-guides/src/preface.xml | 14:08 |
*** eliqiao has joined #openstack-nova | 14:09 | |
*** shaohe_feng has joined #openstack-nova | 14:09 | |
*** Swami has quit IRC | 14:09 | |
*** chandankumar has quit IRC | 14:10 | |
*** Swami has joined #openstack-nova | 14:10 | |
*** code-R has quit IRC | 14:11 | |
openstackgerrit | John Garbutt proposed openstack/nova: Improve help text for floating ips options. https://review.openstack.org/318309 | 14:11 |
*** yuelongguang has joined #openstack-nova | 14:11 | |
*** aswadr_ has joined #openstack-nova | 14:11 | |
mriedem | sdague: stevemar: anyway it's api-site repo | 14:11 |
mriedem | i'm lost in the xml | 14:11 |
*** mingyu has joined #openstack-nova | 14:13 | |
*** bks has quit IRC | 14:13 | |
openstackgerrit | John Garbutt proposed openstack/nova: Improve help text for floating ips options. https://review.openstack.org/318309 | 14:13 |
*** abalutoiu has quit IRC | 14:14 | |
bauzas | mriedem: I heard about your big stick for people not writing Tempest tests for microversions they provide :) | 14:14 |
mriedem | bauzas: you did? | 14:14 |
bauzas | mriedem: so, here is the thing, do you think we should Tempest test the behavioural change I made for evacuate and live-migrate in the 2.29 and 2.30 microversions ? | 14:15 |
bauzas | evacuate is kinda hard stuff for Tempest, nope ? | 14:15 |
sdague | bauzas: yeh, you have to take compute service offline | 14:16 |
sdague | so.... not really viable in normal runs | 14:16 |
dansmith | mikal: okay, sounds like gus was missing quite a bit of context | 14:16 |
*** roeyc has quit IRC | 14:16 | |
*** zz_dimtruck is now known as dimtruck | 14:16 | |
sdague | mikal: right, his primary concern seems to be the venv question | 14:16 |
mriedem | bauzas: tempest tests for features/microversions/things we can test in tempest should be the rule, but there are exceptions | 14:17 |
sdague | but I'm a little confused there, because my code just moves into code the solution that was being pushed with filters changes | 14:17 |
sdague | so, if my thing doesn't work, then the other thing didn't either | 14:17 |
mriedem | bauzas: but as i was telling ken'ichi last night, we do a shit job of holding people to the testing they say they'll provide when they write a spec | 14:17 |
*** tonytan4ever has joined #openstack-nova | 14:17 | |
bauzas | mriedem: yup, so I think testing evacuate in that precise context is hard | 14:17 |
*** ababich has joined #openstack-nova | 14:17 | |
mriedem | bauzas: evacuate is something we don't test in tempest, right, so it would get an exception | 14:18 |
bauzas | mriedem: but I could take a look on how I could test my live-mig change | 14:18 |
bauzas | ie. the 2.30 microversion | 14:18 |
mriedem | bauzas: i think someone already has a tempest patch up for that stuff | 14:18 |
mriedem | bauzas: i'd ask tdurokov | 14:18 |
bauzas | tdurakov: aloha ? | 14:18 |
tdurakov | bauzas: hi | 14:18 |
*** shaohe_feng has quit IRC | 14:18 | |
dansmith | sdague: yeah I think he's confused about that | 14:19 |
bauzas | mriedem: I like when a plan comes together | 14:19 |
sdague | mikal: do you have any further thoughts on that? | 14:19 |
sdague | because I'm not sure I understand what I'd do differently here | 14:19 |
*** shaohe_feng has joined #openstack-nova | 14:20 | |
bauzas | tdurakov: see the log, I was wondering if it was worth testing the 2.30 microversion about live-migrations checking the scheduler | 14:20 |
tdurakov | bauzas: I thought we decided to test every microversion to reduce debt, but test only latest on gates, right | 14:21 |
ababich | mriedem: Hi! Please, take a look at https://review.openstack.org/#/c/346966 . It will allow to close bug https://bugs.launchpad.net/nova/+bug/1606496 | 14:21 |
openstack | Launchpad bug 1606496 in OpenStack Compute (nova) "Instance affinity filters do not work in a heterogeneous cloud with Ironic computes " [High,In progress] - Assigned to Roman Podoliaka (rpodolyaka) | 14:21 |
tdurakov | bauzas: I think mriedem talks about this https://review.openstack.org/#/c/338256/ | 14:21 |
bauzas | tdurakov: sure, my point was rather about whether someone already wrote that for me | 14:21 |
bauzas | tdurakov: mmm, that's 2.33 | 14:22 |
tdurakov | bauzas: I haven't seen at least | 14:22 |
bauzas | tdurakov: okay, so I should write one for 2.30 | 14:22 |
mikal | sdague: I think it probably just works. I think he's just saying we need to make sure we test it. | 14:23 |
*** rlrossit has quit IRC | 14:23 | |
dansmith | and we did right? | 14:23 |
sdague | mikal: ok, but I'm not sure what a valid test is for that, because it's the same paths we already have, and we don't do anything like this in our gate | 14:23 |
*** claudiub|2 has quit IRC | 14:24 | |
sdague | and... I'm not sure which kind of venv config is a valid test here, as that's not part of any deployment model I'm familiar with | 14:24 |
*** sudipto has quit IRC | 14:24 | |
rpodolyaka | ababich: I'm still working on the follow up change to close it properly, will try to upload it later today or tomorrow | 14:24 |
*** tosky has quit IRC | 14:24 | |
sdague | I wonder if we could move forward with this, get the 5.0.0 out there, and know that if we hit an issue we can spin a 5.0.1 to address | 14:25 |
*** andymaier has quit IRC | 14:25 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: Improve consistency in API https://review.openstack.org/332176 | 14:26 |
mikal | So, OSA (Rckspace's thing) deploys venvs I think | 14:26 |
ababich | rpodolyaka: tnx for info! | 14:26 |
mikal | Let me check with them when they come back to their desks | 14:26 |
*** anush_ has joined #openstack-nova | 14:26 | |
*** liverpooler has joined #openstack-nova | 14:27 | |
mriedem | we also deploy in venvs | 14:27 |
openstackgerrit | Moshe Levi proposed openstack/nova: jsonutils.loads only if hypervisor.cpu_info is not None https://review.openstack.org/347870 | 14:28 |
mriedem | i have a test env, is there something that needs specific testing? | 14:28 |
mriedem | i guess pulling in that rootwrap change and using os-brick 4.1.0 | 14:28 |
mriedem | ? | 14:28 |
mikal | mriedem: gus wants us to verify that we can run privsep-helper via rootwrap when privsep-helper is in the venv not the system path | 14:29 |
*** shaohe_feng has quit IRC | 14:29 | |
sdague | mikal: but if we can't, then everything is f'ed anyway, right | 14:29 |
openstackgerrit | Jim Rollenhagen proposed openstack/nova: Move extra_specs_ops to oslo.utils https://review.openstack.org/308403 | 14:29 |
sdague | because adding privsep-helper to compute.filters would also fail | 14:29 |
*** shaohe_feng has joined #openstack-nova | 14:30 | |
sdague | this is the thing I do not understand | 14:30 |
sdague | the path processing is 100% the same as the assumed working model | 14:30 |
mikal | Yeah, I get that. I think it was a last minute "hey we should check" | 14:30 |
mikal | So, we should check, but not freak out just yet | 14:30 |
sdague | mikal: ok, and if it doesn't work, we delete privsep entirely? | 14:31 |
johnthetubaguy | if we drop priv sep from our filters in master, would that not test it? | 14:31 |
*** gszasz_ has joined #openstack-nova | 14:31 | |
sdague | johnthetubaguy: no, it's exactly the same | 14:31 |
mikal | sdague: yes, and become hermits | 14:31 |
sdague | that's the point, and that's my frustration | 14:31 |
mikal | sdague: but let's just hold off on that now | 14:31 |
sdague | johnthetubaguy: if this patch is not valid, neither is our entire strategy of putting privsep-helper in compute.filters | 14:32 |
dansmith | mriedem: sdague: aren't we supposed to not add docstrings on tests? https://review.openstack.org/#/c/325361/7/nova/tests/unit/network/test_manager.py | 14:32 |
*** tosky has joined #openstack-nova | 14:32 | |
sdague | dansmith: no, not any more | 14:32 |
sdague | that was just a nose thing | 14:32 |
johnthetubaguy | sdague: true | 14:32 |
*** gszasz has quit IRC | 14:32 | |
dansmith | sdague: meaning we're back to "it's okay to add docstrings" now? | 14:32 |
sdague | dansmith: yes | 14:32 |
dansmith | okay thnaks | 14:32 |
sdague | we should honestly probably try to encourage people to add them | 14:33 |
sdague | they are super helpful some times on refactoring tests | 14:33 |
*** chandankumar has joined #openstack-nova | 14:33 | |
*** artom2 has joined #openstack-nova | 14:34 | |
dansmith | sdague: well, comment blocks serve that purpose too, but anyway | 14:35 |
sdague | dansmith: sure, they could be that as well | 14:35 |
sdague | but, some preamble for tests is useful | 14:35 |
dansmith | yes | 14:35 |
sdague | and not using docstrings was just because nose used those instead of test names | 14:36 |
sdague | which made it much harder to figure out failures | 14:36 |
*** kevin_zh is now known as kevinz | 14:38 | |
*** cgalan has joined #openstack-nova | 14:39 | |
*** aysyd has quit IRC | 14:39 | |
*** shaohe_feng has quit IRC | 14:39 | |
dansmith | yep | 14:39 |
*** diga has joined #openstack-nova | 14:39 | |
*** shaohe_feng has joined #openstack-nova | 14:40 | |
*** ljxiash has joined #openstack-nova | 14:40 | |
mriedem | artom: small thing to fix in that patch | 14:40 |
*** siva_krish has joined #openstack-nova | 14:40 | |
artom2 | mriedem, which one? | 14:41 |
mriedem | artom2: https://review.openstack.org/#/c/325361/7/nova/tests/unit/network/test_manager.py | 14:41 |
artom2 | I literally copy pasted the existing test, but OK :) | 14:41 |
artom2 | I'll address it when I'm back home | 14:41 |
mikal | sdague: so I do think its reasonable to remember that this rootwrap thing was not how gus intended privsep to work, its a hack we added later to work around some things | 14:43 |
tonyb | .... rootwraps search path comes from exec_dirs in .... etc/nova/rootwrap.conf | 14:43 |
sdague | tonyb: or path, if it's not set | 14:43 |
*** claudiub|2 has joined #openstack-nova | 14:43 | |
*** aysyd has joined #openstack-nova | 14:43 | |
*** abalutoiu has joined #openstack-nova | 14:44 | |
sdague | tonyb: https://review.openstack.org/#/c/344450/2/oslo_rootwrap/wrapper.py@52 | 14:44 |
mikal | If PATH is as set for the parent process, it would just work I think | 14:44 |
sdague | mikal: yes | 14:45 |
sdague | I commented in the review, where that is being calculated | 14:45 |
mikal | Worst case, can't the deployer write a 2 line shell script which is on the system path that activates a venv and then runs privsep-helper? | 14:45 |
*** pbandark has quit IRC | 14:45 | |
tonyb | sdague: okay. | 14:46 |
sdague | privsep-helper will need to be installed in the same venv as nova, but as soon as it's in requirements.txt, then it will be | 14:46 |
sdague | which it will be as soon as we start landing code that can use it | 14:46 |
tonyb | mikal: if PATH is set and there is no exec_dirs in the config | 14:46 |
mikal | So I think that means we think we're fine? | 14:47 |
mikal | And could all be a bit less angry at each other? | 14:47 |
sdague | mikal: right, that was my point :) | 14:47 |
mikal | Ok, so why no hugs? | 14:47 |
dims_ | pong sdague | 14:47 |
mikal | HUG ME | 14:47 |
* dims_ hugs mikal | 14:47 | |
mikal | Awww | 14:47 |
sdague | mikal: ok, this is where I was starting | 14:47 |
dims_ | :) | 14:47 |
tonyb | "other duties as required" | 14:47 |
sdague | I think that through code inspection, we believe that gus's last bit of -1 is already covered by existing code | 14:48 |
*** yamahata has joined #openstack-nova | 14:48 | |
bauzas | johnthetubaguy: alaski: in case people want to chime in, I have a High prio bugfix for making sure resizes are checking the right flavor https://review.openstack.org/#/c/347387/ | 14:48 |
sdague | in which case, I'd move to get another +2 on this, land it, get the release out | 14:48 |
markus_z | tdurakov: did you ever encounter this in the live-migration hooks: http://logs.openstack.org/71/347471/1/check/gate-tempest-dsvm-multinode-live-migration/3e9cb73/console.html#_2016-07-26_16_48_29_475471 ? | 14:48 |
sdague | and if there is anything that got missed, we can always fix it in 5.0.1 | 14:49 |
*** ctrath has quit IRC | 14:49 | |
*** shaohe_feng has quit IRC | 14:49 | |
sdague | mikal / tonyb: opinions on that? | 14:49 |
dims_ | sdague : mikal : do we want to let https://review.openstack.org/#/c/344450/ in before gus takes his -1 back? | 14:50 |
mikal | sdague: I need to re-read the review, please hold | 14:50 |
dansmith | mriedem: the mox usage in there is existing, right? and he's copying the stub_out that is already there | 14:50 |
*** shaohe_feng has joined #openstack-nova | 14:50 | |
sdague | dims_: that's what I'm proposing. I feel like gus put a very specific concern in for the grounds of his -1. | 14:50 |
mriedem | dansmith: it's a new test | 14:50 |
dansmith | mriedem: I'd rather he fix the bug and then refactor the tests (or vice versa) | 14:50 |
mriedem | dansmith: we shouldn't use mox in new tets | 14:50 |
dansmith | mriedem: but it's a copy of the test above | 14:50 |
mriedem | dansmith: so? | 14:50 |
dansmith | mriedem: if he copies a test and rewrites it it's much harder for me to quickly see that it's the same thing | 14:51 |
sdague | and that we've verified that the existing code seems to cover that case | 14:51 |
* dims_ waiting for mikal to answer | 14:51 | |
dims_ | sdague : ack | 14:51 |
artom2 | bauzas, is https://review.openstack.org/#/c/340270/ doing the same thing as your bug fix? | 14:51 |
*** ctrath has joined #openstack-nova | 14:51 | |
mriedem | dansmith: it's like one mox | 14:52 |
artom2 | I only have my phone right now, but they look related... | 14:52 |
*** code-R_ has quit IRC | 14:52 | |
*** code-R has joined #openstack-nova | 14:52 | |
dims_ | gus : ping in case you are up early | 14:52 |
tdurakov | markus_z: I'd expect that NOVA_CONF is not defined | 14:52 |
dims_ | gus : let's move forward on this please | 14:52 |
tdurakov | markus_z: you could check it by echoing it before calling | 14:52 |
tonyb | I *think* we're good. My only worry about landing this with gus's -1 are interpersonal rather than technical | 14:52 |
*** oanson has joined #openstack-nova | 14:53 | |
tdurakov | or just redefine it NOVA_CONF=${NOVA_CONF:-/etc/nova/nova.conf} | 14:53 |
bauzas | artom2: kinda related, but I think not the same problem | 14:53 |
dims_ | tonyb : it's 3 lines of code essentially there in that review | 14:53 |
markus_z | tdurakov: I thought it's defined somewhere before. I'll add a little more echos. Thanks | 14:53 |
artom2 | bauzas, right, that one is for mums only | 14:54 |
artom2 | numa | 14:54 |
bauzas | heh, mums | 14:54 |
artom2 | OK, I'm out, that's a sign I need to leave | 14:54 |
mriedem | dansmith: artom2: so L1781 was what showed up in my 5..6 diff, so don't change that test | 14:54 |
markus_z | tdurakov: dang it, you're right. copy/paste issue | 14:55 |
tdurakov | markus_z: np | 14:55 |
artom2 | mriedem, so... we're good? | 14:55 |
dims_ | tonyb : can you please mark a +1 there? | 14:55 |
dansmith | mriedem: I'm not sure what you mean, he didn't change that line in the final version | 14:56 |
mriedem | L1731 is the new change | 14:56 |
mriedem | i was diffing 5..6 patchsets | 14:56 |
mriedem | and test_deallocate_fixed_rpc_pinned shows up as a new test | 14:56 |
mriedem | with mox, mock and fixtures | 14:56 |
tonyb | dims_: Yeah. | 14:56 |
mriedem | now that i just look at patch set 6 by itself, it see it's different | 14:56 |
sdague | tonyb: I do get that, but I also think that given the TZ delay we're going to keep grinding here. At least in nova if you -1 with a specific reason, and the rest of the core team realizes the reason is resolved, we just move ahead | 14:56 |
sdague | I get that oslo may be different | 14:57 |
artom2 | it is a new test, copied verbatim from an existing one, with one change unrelated to mox mock etc | 14:57 |
sdague | but I also know how much is backed up behind getting this out there | 14:57 |
*** mdrabe has quit IRC | 14:57 | |
dims_ | sdague : will let this in by end of our day today one way or another | 14:58 |
sdague | and it feels like we can definitely fix any edge issues in a follow on to the 5.0.0 release in parallel to unblocking os-brick and os-vif | 14:58 |
mriedem | artom2: yeah but we also don't like propagating tests that use mox, those are opportunities to get rid of mox usage | 14:58 |
mriedem | which is in the docs | 14:58 |
mriedem | if this is going to cause a bunch of stress i can drop my -1 | 14:58 |
*** nkrinner has quit IRC | 14:58 | |
artom2 | mriedem, like I said, I'll address the feedback :) | 14:58 |
mriedem | #4 here btw http://docs.openstack.org/infra/manual/developers.html#peer-review | 14:59 |
dansmith | mriedem: 4.2 covers us IMHO | 14:59 |
artom2 | I suppose it's better to have one test that follows guidelines add opposed to none, even if it's inconsistent | 14:59 |
*** coolsvap_ is now known as coolsvap | 14:59 | |
*** admin0 has quit IRC | 14:59 | |
artom2 | *as | 14:59 |
dansmith | I know 4.3 says change it all up too, | 14:59 |
dansmith | but in this case, seeing that they're the same is valuable, IMHO | 14:59 |
*** shaohe_feng has quit IRC | 14:59 | |
artom2 | OK, really have to bounce now | 15:00 |
*** jistr is now known as jistr|call | 15:00 | |
*** artom2 has quit IRC | 15:00 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: WIP: live-migration test for serial console https://review.openstack.org/347471 | 15:00 |
*** shaohe_feng has joined #openstack-nova | 15:00 | |
mriedem | ffs, if this is the difference between the fix merging today or not, then let's just approve it | 15:00 |
*** nkrinner has joined #openstack-nova | 15:00 | |
mriedem | +W | 15:01 |
mriedem | er +2 | 15:01 |
mriedem | but we have py3 race failures b/c of mox and because we don't clean house on it, so we're just making more work for ourselves later | 15:01 |
dansmith | mriedem: I'm refactoring them now | 15:02 |
*** admin0 has joined #openstack-nova | 15:02 | |
alex_xu | johnthetubaguy: sdague sorry, i can't make the meeting. a little uncomfortable today. anyway i will check the meeting log later. and will back to work tomorrow if lucky | 15:04 |
sdague | alex_xu: no prob, hope you feel better tomorrow | 15:05 |
alex_xu | sdague: thanks | 15:05 |
*** mdrabe has joined #openstack-nova | 15:05 | |
bauzas | artom: I'm unclear where the numa related information is passed by the old model when resizing, was that thanks to the flavor ? | 15:05 |
*** nkrinner has quit IRC | 15:08 | |
*** shaohe_feng has quit IRC | 15:10 | |
*** liverpooler has quit IRC | 15:10 | |
*** shaohe_feng has joined #openstack-nova | 15:11 | |
*** rrecio has joined #openstack-nova | 15:11 | |
*** sridharg has quit IRC | 15:12 | |
*** syjulian_ has joined #openstack-nova | 15:13 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: config options: Improve help for base https://review.openstack.org/324559 | 15:13 |
*** gszasz_ has quit IRC | 15:13 | |
*** mtanino has joined #openstack-nova | 15:14 | |
*** odyssey4me has joined #openstack-nova | 15:14 | |
odyssey4me | o/ | 15:14 |
zzzeek | lazy nova question: the database tables in models.BASE and in api_models.API_BASE are mutually exclusive to the "main" and "api" databases, right? | 15:14 |
openstackgerrit | Gleb Stepanov proposed openstack/nova: Skip malformed cookies https://review.openstack.org/346090 | 15:15 |
odyssey4me | mikal you had a question about using rootwrap with venvs? | 15:15 |
*** kenperkins has joined #openstack-nova | 15:16 | |
odyssey4me | OpenStack-Ansible has been using venvs since Liberty for all services. We implement the venv path as the first in line for the rootwrap config: we ensure that the venv patch is first in line in the rootwrap config: https://github.com/openstack/openstack-ansible-os_nova/blob/master/templates/rootwrap.conf.j2#L13 | 15:16 |
odyssey4me | *path | 15:16 |
odyssey4me | urgh, my keyboard skills are lacking today | 15:16 |
*** pcaruana has quit IRC | 15:17 | |
sdague | odyssey4me: cool | 15:18 |
openstackgerrit | Dan Smith proposed openstack/nova: Refactor deallocate_fixed tests to use one mock approach instead of three https://review.openstack.org/347893 | 15:18 |
dansmith | mriedem: artom ^ | 15:18 |
sdague | odyssey4me: makes total sense | 15:18 |
sdague | so as soon as privsep is in nova's requirements.txt, it will end up in that path, and all will be good | 15:19 |
odyssey4me | sdague sounds good to me, as soon as that switch is ready for roader testing feel free to ping me so that we can put up a review to try it out in OSA | 15:19 |
diana_clarke | dansmith: I | 15:20 |
diana_clarke | lol | 15:20 |
dansmith | diana_clarke: J | 15:20 |
sdague | odyssey4me: yeh, we need this rootwrap patch and release, then that code should start flowing in | 15:20 |
*** shaohe_feng has quit IRC | 15:20 | |
*** sudipto has joined #openstack-nova | 15:20 | |
*** syjulian_ has quit IRC | 15:20 | |
sdague | if that release happens next week, I'd expect we start landing this stuff next week | 15:20 |
*** shaohe_feng has joined #openstack-nova | 15:21 | |
diana_clarke | dansmith: I'm a bit nervous about rebasing mdbooth's entire patch series. Instead I just pushed the change to the bottom patch you wanted. | 15:21 |
dansmith | diana_clarke: nervous why? | 15:21 |
*** nkrinner has joined #openstack-nova | 15:22 | |
*** armax has joined #openstack-nova | 15:22 | |
diana_clarke | dansmith: But that might have been a mistake b/c now the ones that follow after don't "line up" in the "related changes" gerrit list. | 15:22 |
dansmith | diana_clarke: right, they're all orhaned now | 15:23 |
diana_clarke | dansmith: nervous because there is some sort of timing issue with large patch series, and after the first couple they will all fail to merge. | 15:23 |
*** sudipto has quit IRC | 15:23 | |
diana_clarke | and then I have to manually recheck them all, unless someone knows a better way | 15:23 |
dansmith | diana_clarke: just because the series touches everything | 15:23 |
mikal | sdague / odyssey4me: So its puppies and kittens the whole way down | 15:24 |
dansmith | diana_clarke: if they get into conflict, you need to rebase anyway to really fix it | 15:24 |
*** rcernin has quit IRC | 15:24 | |
sdague | mikal: sounds like | 15:24 |
sdague | dims_ just hit the +A button on it | 15:24 |
sdague | so now once that is in, we can get the release cut, and start moving on os-brick and os-vif | 15:25 |
diana_clarke | dansmith: sure, but mdbooth had some scripts that rebased them one at a time so that it didn't trigger the infra timing issue | 15:25 |
*** gszasz_ has joined #openstack-nova | 15:25 | |
diana_clarke | dansmith: I should have asked for them b/c I'm not sure how he was getting around it | 15:25 |
diana_clarke | dansmith: anyhoo, I'll just rebase from the top then, and manually recheck them all when I trigger the timing bug I guess | 15:26 |
*** raj_singh_ has joined #openstack-nova | 15:26 | |
dansmith | diana_clarke: really not sure what "infra timing issue" you're referring to | 15:26 |
dansmith | diana_clarke: rebasing them whole stack will run a check on all of them since they're all "new" | 15:26 |
*** admin0 has quit IRC | 15:27 | |
*** GB21 has joined #openstack-nova | 15:27 | |
diana_clarke | It's been mentioned here a few times (the known infra timing issue with large patch series). mriedem probably understands what I'm talking about. | 15:27 |
bhagyashri | mriedem: Hi, could you please take a look at it, https://review.openstack.org/#/c/320787/ | 15:27 |
*** mjura has quit IRC | 15:28 | |
*** code-R has quit IRC | 15:28 | |
diana_clarke | dansmith: yes, that's what it *should* do, but in practice they are all going to auto-fail after the fire few in the series | 15:29 |
diana_clarke | s/fire/first/ | 15:29 |
dansmith | clarkb: fungi: is that a thing? ^ | 15:29 |
*** andreas_s has quit IRC | 15:29 | |
fungi | diana_clarke: dansmith: that doesn't ring a bell. can you elaborate? | 15:30 |
*** shaohe_feng has quit IRC | 15:30 | |
dansmith | either way, that series is large enough that by the time we merge the next few, we'll have to rebase it anyway I expect | 15:31 |
fungi | the only issue i'm aware of breaking large patch series is that if they're all approved together then the jgit in gerrit has trouble with n-way octopus merges come time to finally merge them into the branch after passing | 15:31 |
*** shaohe_feng has joined #openstack-nova | 15:31 | |
mriedem | is there some magic incantation to getting glanceclient debug logs on nova-compute? i thought setting the default_log_levels config option would do it, but apparently not | 15:32 |
mriedem | plus sending debug=True when creating glanceclient | 15:32 |
fungi | so you'll get the first 4 or so merged, and then gerrit will report a merge conflict on the next one because jgit's merge conflict resolution is terribad, and then the changes that all depend on that will mark as failed because a required change failed to merge | 15:32 |
*** kevin_zh has joined #openstack-nova | 15:32 | |
dansmith | fungi: yeah, that's on merge and for hairy things, but not on check, AFAIK right? | 15:33 |
mriedem | diana_clarke: you'll just have to recheck the rest that have the merge failed message | 15:33 |
*** kevinz has quit IRC | 15:33 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: config options: Improve help for base https://review.openstack.org/324559 | 15:33 |
mriedem | jeblair knows about it | 15:33 |
fungi | dansmith: right, everywhere besides the final merge-down after passing the gate, zuul is using cgit to calculate merges (albeit with most complex resolution algorithms disabled to try and approximate the awfulness that is jgit) | 15:34 |
mriedem | he upped some timeouts or something when i was complaining about it in a large series | 15:34 |
dansmith | mriedem: are you talking about on merge or check? | 15:34 |
*** aysyd has quit IRC | 15:34 | |
diana_clarke | mriedem: Yup, I know. If I understood correctly, dansmith that was surprised to hear that you need to manually recheck large patch series because they fail to merge as a rule (I've been told b/c of timing issues). | 15:34 |
*** aysyd has joined #openstack-nova | 15:35 | |
mriedem | dansmith: check | 15:35 |
*** jistr|call is now known as jistr | 15:35 | |
mriedem | i hit it every time after the first couple of changes when my get-me-a-network series was large | 15:35 |
dansmith | hmm, that's not a thing I know about | 15:35 |
*** READ10 has joined #openstack-nova | 15:36 | |
dansmith | (nor fungi apparently) | 15:36 |
dansmith | is this a post-jenkins recent thing somehow? | 15:36 |
*** ducttape_ has quit IRC | 15:37 | |
dansmith | I've not noticed this in prior large set pushes.. my resource attribute set a couple weeks ago was like ten big and didn't suffer this fate | 15:37 |
*** sudipto has joined #openstack-nova | 15:38 | |
dansmith | diana_clarke: regardless, I can't even walk the first few in order now because they're orphaned, so a rebase to get the bottom few to be happy would be good | 15:38 |
diana_clarke | dansmith: okie dokie | 15:38 |
*** oanson has quit IRC | 15:39 | |
fungi | mriedem: dansmith: possibly related, gerrit 2.11 seems to seriously bloat its git repos with unreferenced objects, and we weren't garbage-collecting (because before we upgraded to 2.11 in december it wasn't really needed), so the nova repo there grew to around 50gb in size over the months since. a week or so ago we were finally comfortable with our gc tests to turn it on, and now that repo is back | 15:40 |
fungi | down around 5gb. that may have been causing unusually inflated query lag for zuul particularly when trying to handle nova change lokups | 15:40 |
dansmith | ah, interesting | 15:40 |
*** shaohe_feng has quit IRC | 15:40 | |
fungi | now we git gc all the repos on gerrit weekly (cron job that fires early sundays utc) | 15:41 |
*** sudipto has quit IRC | 15:41 | |
danpb | wow, that's fun | 15:41 |
*** shaohe_feng has joined #openstack-nova | 15:41 | |
tonyb | fungi is that in system-config somewhere? I'd like to gc my local clones as they're pretty big and y'all have done the work to know what's safe ;P | 15:42 |
danpb | i guess whatever gerrit is doing doesn't trigger git auto-gc ? | 15:42 |
*** david-lyle has joined #openstack-nova | 15:43 | |
*** liverpooler has joined #openstack-nova | 15:43 | |
danpb | tonyb: you can just run a plain 'git gc' on any local repo checkout | 15:43 |
*** diogogmt has joined #openstack-nova | 15:44 | |
*** chandankumar has quit IRC | 15:44 | |
*** code-R has joined #openstack-nova | 15:44 | |
*** chandankumar has joined #openstack-nova | 15:44 | |
tonyb | danpb: don't you need to do somethign smart with the reflog to free up more 'HEADS' to discard? | 15:44 |
fungi | tonyb: yep, http://git.openstack.org/cgit/openstack-infra/puppet-gerrit/tree/manifests/cron.pp | 15:45 |
tonyb | fungi: thanks. | 15:46 |
fungi | tonyb: in our configuration that boils down to `find /home/gerrit2/review_site/git/ -type d -name \"*.git\" -print -exec git --git-dir=\"{}\" gc \\;` | 15:46 |
fungi | tonyb: note those are bare repos, hence the .git extensions on them | 15:46 |
fungi | tonyb: but as danpb says, it's just `git gc` in the repo basically | 15:47 |
tonyb | fungi: okay. perhaps I'm overestimating the size reduction I shoudl expect | 15:47 |
fungi | tonyb: if you want to _seriously_ clean up and reset your repos to freshness, this is what i do: http://paste.openstack.org/show/542616/ (note that i also am religious about pushing my work in progress up to gerrit consistently and not keeping anything important in local topic branches) | 15:48 |
moshele | mriedem, dansmith: can you review some pci patches https://review.openstack.org/#/c/347509/ and https://review.openstack.org/#/c/347444/ and https://review.openstack.org/#/c/347558/ | 15:49 |
openstackgerrit | Matt Riedemann proposed openstack/nova: DNM: enable glanceclient debug logging https://review.openstack.org/347914 | 15:49 |
*** jlanoux has quit IRC | 15:50 | |
tonyb | fungi: Yeah I'm not that religious but I could certainly modify that to drop all the review branches | 15:50 |
tonyb | fungi: Thanks again | 15:51 |
*** shaohe_feng has quit IRC | 15:51 | |
fungi | tonyb: also that ls-projects file referenced in the script is generated with my clone updating script that i also run periodically: http://paste.openstack.org/show/542618/ | 15:51 |
*** shaohe_feng has joined #openstack-nova | 15:52 | |
fungi | and that's where i'm also correcting remotes, pruning remote branches, et cetera | 15:52 |
fungi | with this, i maintain a mostly up-to-date mirror of all the repos we host in gerrit | 15:52 |
fungi | which comes in really handy if i need to script up mass changes across a large slice of them | 15:53 |
*** sudipto has joined #openstack-nova | 15:53 | |
tonyb | fungi: interesting that you manually set the gerrit remote/url rather then running git review -s | 15:53 |
fungi | danpb: the reason what gerrit is doing doesn't trigger auto-gc is that it's not using cgit. it's using jgit, which doesn't auto-gc | 15:54 |
danpb | ah right | 15:54 |
fungi | tonyb: yeah, it's a quick and dirty script. it could just as well git review -s | 15:55 |
*** jwcroppe has quit IRC | 15:55 | |
fungi | which would have the side benefit of also grabbing the gerrit commit hook | 15:55 |
*** unicell1 has joined #openstack-nova | 15:55 | |
tonyb | fungi: Mine is functionally similar http://paste.openstack.org/show/542620/ only it has half implemented detection of moved projects | 15:55 |
fungi | tonyb: since i totally blow away non-upstream content anyway, i opted to punt on renames and eat the recloning hit on those rare occasions | 15:56 |
*** matrohon has quit IRC | 15:56 | |
tonyb | fungi: and deals with some of my "dirty" directories | 15:56 |
*** markus_z has quit IRC | 15:56 | |
tonyb | fungi: yeah that's reasonable | 15:57 |
*** cgalan has quit IRC | 15:57 | |
*** unicell has quit IRC | 15:57 | |
*** hemnafk is now known as hemna | 15:57 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: config options: Improve help for SPICE https://review.openstack.org/317046 | 15:57 |
fungi | i considered it, but a lot of added complexity for minimal benefit | 15:58 |
fungi | also we don't have a really good mechanism for identifying renames other than announcing them... otherwise i'd script up that detection and use it to "fix" my gertty databases | 15:58 |
*** tjones has left #openstack-nova | 16:00 | |
*** sudipto has quit IRC | 16:00 | |
tonyb | fungi: yeah. I had a script that dropped the gerrit remote and then re-created it after rename but that assumes that it was just a namespace change ie {stackforge,openstack/foo-project | 16:00 |
tonyb | fungi: if we rename the repo that script blows up | 16:01 |
fungi | which is basically the only renaming we do since last fall | 16:01 |
*** code-R has quit IRC | 16:01 | |
fungi | er, last spring for you | 16:01 |
tonyb | :) | 16:01 |
*** shaohe_feng has quit IRC | 16:01 | |
fungi | late last year | 16:01 |
*** thorst is now known as thorst_afk | 16:01 | |
* fungi curses his lingering hemisphericentrism | 16:01 | |
*** shaohe_feng has joined #openstack-nova | 16:02 | |
tonyb | fungi: :) I think we've taken over the nova channel long enough ;P | 16:02 |
openstackgerrit | Yves-Gwenael Bourhis proposed openstack/nova: Reduce time and memory usage of tenant usage. https://review.openstack.org/343734 | 16:03 |
*** gszasz_ has quit IRC | 16:03 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: config options: improve help netconf https://review.openstack.org/319384 | 16:03 |
*** claudiub|2 has quit IRC | 16:04 | |
*** raj_singh_ has quit IRC | 16:04 | |
*** armax has quit IRC | 16:04 | |
*** tyrola has joined #openstack-nova | 16:05 | |
openstackgerrit | Michael Still proposed openstack/nova: Refuse to have negative console ttls https://review.openstack.org/347040 | 16:06 |
*** kevin_zh has quit IRC | 16:07 | |
mriedem | danpb: i've got libvirt/qemu taking like 99% cpu on a compute node, with not really any errors/warnings in the libvirtd.logs - is there something easy to check? i think i've got a hosed instance | 16:07 |
mriedem | i haven't enabled libvirt debug logging (yet) | 16:07 |
*** TravT has joined #openstack-nova | 16:07 | |
*** tyrola_ has joined #openstack-nova | 16:10 | |
*** chandankumar has quit IRC | 16:10 | |
*** chandankumar has joined #openstack-nova | 16:11 | |
*** tyrola_ has quit IRC | 16:11 | |
mriedem | looks like it was a rogue instance, i had a hung snapshot | 16:11 |
*** shaohe_feng has quit IRC | 16:11 | |
mriedem | deleted the instance and now libvirt is back to normal | 16:11 |
*** shaohe_feng has joined #openstack-nova | 16:12 | |
*** ducttape_ has joined #openstack-nova | 16:12 | |
*** jwcroppe has joined #openstack-nova | 16:13 | |
*** itlinux has quit IRC | 16:13 | |
*** armax has joined #openstack-nova | 16:13 | |
*** tyrola has quit IRC | 16:13 | |
*** unicell1 has quit IRC | 16:14 | |
*** nkrinner is now known as nkrinner_afk | 16:14 | |
*** nic has joined #openstack-nova | 16:15 | |
*** code-R has joined #openstack-nova | 16:15 | |
*** kevin_zh has joined #openstack-nova | 16:15 | |
*** slunkad_ has quit IRC | 16:15 | |
*** sudipto has joined #openstack-nova | 16:15 | |
*** chandankumar has quit IRC | 16:16 | |
*** sayalilunkad has joined #openstack-nova | 16:17 | |
*** chandankumar has joined #openstack-nova | 16:17 | |
artom | Dammit http://logs.openstack.org/61/325361/7/gate/gate-nova-python27-db-ubuntu-xenial/8121e0a/console.html | 16:18 |
artom | Screw it, CLOSED EVERYTHINGHATESME | 16:18 |
openstackgerrit | Maciej Szankin proposed openstack/nova: Improve consistency in API https://review.openstack.org/332176 | 16:20 |
*** cgalan has joined #openstack-nova | 16:21 | |
*** shaohe_feng has quit IRC | 16:21 | |
*** shaohe_feng has joined #openstack-nova | 16:22 | |
*** edand has quit IRC | 16:23 | |
*** kevin_zh has quit IRC | 16:23 | |
openstackgerrit | Moshe Levi proposed openstack/nova: jsonutils.loads only if hypervisor.cpu_info is not None https://review.openstack.org/347870 | 16:24 |
*** sayalilunkad has quit IRC | 16:25 | |
*** ctrath has quit IRC | 16:25 | |
*** Apoorva has joined #openstack-nova | 16:25 | |
mriedem | artom: a failure like that hates everyone equally | 16:26 |
openstackgerrit | Michael Still proposed openstack/nova: Move quota options to a config group. https://review.openstack.org/346869 | 16:27 |
*** thorst_afk is now known as thorst | 16:27 | |
*** ijw has joined #openstack-nova | 16:27 | |
*** ftersin has left #openstack-nova | 16:27 | |
artom | mriedem, so I'm finally part of the cool gang of hated everyones? | 16:27 |
*** david-lyle has quit IRC | 16:28 | |
*** dikonoor has joined #openstack-nova | 16:29 | |
*** ijw has quit IRC | 16:29 | |
mriedem | nice, glance has a allow_additional_image_properties config | 16:29 |
mriedem | defaults to true, but if you set it to false, interop issues | 16:29 |
mriedem | the schema changes based on config | 16:29 |
danpb | mriedem: check that the guest isn't running a 100% cpu workload :-) | 16:29 |
mriedem | danpb: cirros guest | 16:29 |
*** ijw has joined #openstack-nova | 16:29 | |
mriedem | danpb: i think the snapshot just went crazy or something, but virsh said the domain was running, so idk | 16:30 |
*** shaohe_feng has quit IRC | 16:32 | |
*** shaohe_feng has joined #openstack-nova | 16:32 | |
*** ljxiash has quit IRC | 16:33 | |
openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Add server admin actions to general purpose feature matrix https://review.openstack.org/345708 | 16:33 |
*** code-R_ has joined #openstack-nova | 16:34 | |
*** haleyb has joined #openstack-nova | 16:34 | |
*** ctrath has joined #openstack-nova | 16:36 | |
*** yamahata has quit IRC | 16:37 | |
*** code-R has quit IRC | 16:37 | |
*** abalutoiu_ has joined #openstack-nova | 16:37 | |
*** sayalilunkad has joined #openstack-nova | 16:38 | |
*** chandankumar_ has joined #openstack-nova | 16:39 | |
*** mvk has quit IRC | 16:39 | |
*** tjones has joined #openstack-nova | 16:40 | |
*** chandankumar has quit IRC | 16:40 | |
*** tjones has left #openstack-nova | 16:40 | |
*** abalutoiu has quit IRC | 16:40 | |
*** derekh has quit IRC | 16:42 | |
*** shaohe_feng has quit IRC | 16:42 | |
*** shaohe_feng has joined #openstack-nova | 16:43 | |
openstackgerrit | Gleb Stepanov proposed openstack/nova: [WIP] Init allocated ports set https://review.openstack.org/347479 | 16:44 |
*** chandankumar_ has quit IRC | 16:44 | |
*** Sukhdev has quit IRC | 16:44 | |
*** tjones has joined #openstack-nova | 16:46 | |
*** tjones has left #openstack-nova | 16:48 | |
openstackgerrit | Brian Haley proposed openstack/nova: Revert "raise exception ComputeHostNotFound if host is not found" https://review.openstack.org/347945 | 16:50 |
mriedem | sdague: well i figured out why snapshot fails with glance v2 for us | 16:50 |
mriedem | it's awesome | 16:50 |
*** READ10 has quit IRC | 16:51 | |
mriedem | we don't deploy https://github.com/openstack/glance/blob/master/etc/schema-image.json - which if you don't have that, you can't pass kernel_id or ramdisk_id=None, which is exactly what nova does https://github.com/openstack/nova/blob/master/nova/image/glance.py#L849 | 16:51 |
mriedem | we don't fail upstream ci because devstack sets all of this up | 16:51 |
mriedem | and allow_additional_image_properties defaults to True in glance config, but if you set that to False, then you can't pass kernel_id/ramdisk_id at all | 16:52 |
mriedem | so nova is making a bunch of assumptions based on how devstack works, which i guess shouldn't be surprising | 16:52 |
*** shaohe_feng has quit IRC | 16:52 | |
*** READ10 has joined #openstack-nova | 16:52 | |
*** Apoorva_ has joined #openstack-nova | 16:53 | |
openstackgerrit | Roman Podoliaka proposed openstack/nova: ironic_host_manager: fix population of instances info on schedule https://review.openstack.org/346966 | 16:53 |
openstackgerrit | Roman Podoliaka proposed openstack/nova: WIP ironic_host_manager: fix population of instances info on start https://review.openstack.org/347948 | 16:53 |
*** shaohe_feng has joined #openstack-nova | 16:53 | |
*** lucasagomes is now known as lucas-dinner | 16:55 | |
*** Apoorva has quit IRC | 16:56 | |
*** nherciu has quit IRC | 17:00 | |
johnthetubaguy | pumaranikar: hey, just got a worry about this bit: https://review.openstack.org/#/c/344483/3/doc/source/feature_matrix_gp.ini@257 | 17:01 |
johnthetubaguy | pumaranikar: is that really true? | 17:01 |
*** shaohe_feng has quit IRC | 17:02 | |
openstackgerrit | Anusha Unnam proposed openstack/nova: Config options consistency for cell.py https://review.openstack.org/347954 | 17:03 |
*** shaohe_feng has joined #openstack-nova | 17:03 | |
*** moshele has quit IRC | 17:04 | |
*** muawiakhan has quit IRC | 17:05 | |
*** Swami has quit IRC | 17:05 | |
*** BobBall is now known as BobBall_AWOL | 17:06 | |
*** unicell has joined #openstack-nova | 17:07 | |
openstackgerrit | Sarafraj Singh proposed openstack/nova: Adding functional tests for 2.3 microversion https://review.openstack.org/347544 | 17:07 |
johnthetubaguy | do folks know, is this the only ironic job that runs on nova right now? http://logs.openstack.org/72/339072/5/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-tinyipa/cbbd8ec/console.html | 17:10 |
raj_singh | johnthetubaguy: gate-tempest-dsvm-ironic-pxe_ipa-nv | 17:12 |
*** ctrath has quit IRC | 17:12 | |
raj_singh | johnthetubaguy: This was the job last time I checked, might have changed now | 17:12 |
*** tesseract- has quit IRC | 17:13 | |
*** shaohe_feng has quit IRC | 17:13 | |
*** shaohe_feng has joined #openstack-nova | 17:13 | |
*** links has joined #openstack-nova | 17:15 | |
*** sdake has quit IRC | 17:15 | |
pumaranikar | johnthetubaguy, no its not true. I need to change tag for ironic | 17:18 |
openstackgerrit | Clenimar Filemon proposed openstack/nova: Support Identity v3 when connecting to Ironic https://review.openstack.org/300154 | 17:18 |
pumaranikar | johnthetubaguy, I will check and update accordingly. | 17:19 |
*** david-lyle has joined #openstack-nova | 17:20 | |
*** rama_y has joined #openstack-nova | 17:21 | |
*** shaohe_feng has quit IRC | 17:23 | |
*** david-lyle has quit IRC | 17:23 | |
*** shaohe_feng has joined #openstack-nova | 17:23 | |
*** ctrath has joined #openstack-nova | 17:23 | |
*** david-lyle_ has joined #openstack-nova | 17:23 | |
mriedem | diana_clarke: commented on https://review.openstack.org/#/c/343922/ - i'm not sure why we want/need the coverage job running on all changes in the check queue | 17:24 |
mriedem | i'd be fine with experimental for running it on demand | 17:24 |
*** david-lyle_ is now known as david-lyle | 17:24 | |
mriedem | clarkb: does the coverage job in the post queue post results somewhere? like an html page that infra hosts? | 17:25 |
*** david-lyle_ has joined #openstack-nova | 17:25 | |
diana_clarke | mriedem: I like being able to see how a particular patch changes the overall coverage, and coverage takes 30 min for me to run locally. | 17:26 |
*** abalutoiu__ has joined #openstack-nova | 17:26 | |
mriedem | for a particular patch, you can run it through the job in the experimental queue | 17:26 |
mriedem | i don't think we care about it in check on every change | 17:26 |
dansmith | yeah, if it takes 30 minutes locally, | 17:26 |
dansmith | that's a lot of extra work for the workers for pretty minimal gain | 17:27 |
diana_clarke | FWIW: That patch was prompted by this thread: http://lists.openstack.org/pipermail/openstack-dev/2016-July/099501.html | 17:28 |
mriedem | sdague: do you have the rootwrap 5.0.0 release request queued up? else i can | 17:29 |
*** david-lyle has quit IRC | 17:29 | |
*** abalutoiu_ has quit IRC | 17:30 | |
*** Apoorva_ has quit IRC | 17:30 | |
mriedem | diana_clarke: i'm fine with it in the experimental queue if someone wants to see the results but doesn't want to run it locally | 17:30 |
*** Apoorva has joined #openstack-nova | 17:30 | |
mriedem | diana_clarke: as a reviewer though, i'm not going to be digging into coverage job results for patches that are passing tests | 17:30 |
mriedem | well, or at all really | 17:31 |
mriedem | unless it's like a major test refactor | 17:31 |
*** shaohe_feng has quit IRC | 17:33 | |
diana_clarke | mriedem: okie dokie. I use coverage when I review to make sure the new code is actually covered by tests, but perhaps that's just me. I'll ditch it. | 17:33 |
*** david-lyle_ has quit IRC | 17:34 | |
diana_clarke | (thanks for the review!) | 17:34 |
mriedem | diana_clarke: again, s/check/experimental/ | 17:34 |
mriedem | totally fine | 17:34 |
*** david-lyle_ has joined #openstack-nova | 17:34 | |
*** shaohe_feng has joined #openstack-nova | 17:34 | |
*** abalutoiu__ has quit IRC | 17:35 | |
*** tonytan_brb has joined #openstack-nova | 17:36 | |
*** abalutoiu__ has joined #openstack-nova | 17:36 | |
*** syjulian has joined #openstack-nova | 17:36 | |
*** browne has joined #openstack-nova | 17:37 | |
*** tonytan4ever has quit IRC | 17:38 | |
diana_clarke | man... rebasing someone else's 30+ patch series is difficult. I keep throwing it away, worried I've messed up. | 17:38 |
*** yamahata has joined #openstack-nova | 17:39 | |
*** tosky has quit IRC | 17:39 | |
openstackgerrit | Gábor Antal proposed openstack/nova: Fixed invalid UUIDs in unit tests https://review.openstack.org/347748 | 17:40 |
*** diga has quit IRC | 17:40 | |
openstackgerrit | Mike Fedosin proposed openstack/nova: Don't set empty kernel_id and ramdisk_id to glance image https://review.openstack.org/347971 | 17:41 |
*** david-lyle_ has quit IRC | 17:42 | |
openstackgerrit | Gábor Antal proposed openstack/nova: Fixed invalid UUIDs in unit tests https://review.openstack.org/347748 | 17:42 |
*** eil397 has joined #openstack-nova | 17:43 | |
*** shaohe_feng has quit IRC | 17:43 | |
*** shaohe_feng has joined #openstack-nova | 17:44 | |
*** ihrachys has quit IRC | 17:44 | |
*** abalutoiu_ has joined #openstack-nova | 17:45 | |
*** ijw has quit IRC | 17:45 | |
*** sdague has quit IRC | 17:46 | |
*** sabari has quit IRC | 17:47 | |
*** dikonoor has quit IRC | 17:48 | |
*** sabari has joined #openstack-nova | 17:48 | |
*** abalutoiu__ has quit IRC | 17:48 | |
*** jaypipes has joined #openstack-nova | 17:49 | |
*** mingyu has quit IRC | 17:52 | |
*** danpb has quit IRC | 17:53 | |
*** shaohe_feng has quit IRC | 17:54 | |
*** sdague has joined #openstack-nova | 17:54 | |
*** links has quit IRC | 17:54 | |
*** mingyu has joined #openstack-nova | 17:54 | |
*** shaohe_feng has joined #openstack-nova | 17:54 | |
dansmith | jaypipes: did you see the comment on this? https://review.openstack.org/#/c/334031/3 | 17:56 |
*** mvk has joined #openstack-nova | 17:58 | |
sdague | mriedem: I have not yet | 17:59 |
sdague | mriedem: ... on the glance side, is it expected from a glance perspective that file is deployed? | 18:00 |
*** sudipto has quit IRC | 18:00 | |
sdague | perhaps we should get the glance project to put the schemas in code instead of config, this seems to be another one of those state tracking problems | 18:00 |
mriedem | sdague: i don't know if it's expected, but it shouldn't be expected to be the same as in tree since it's in /etc | 18:00 |
mriedem | most of the schema is in code | 18:01 |
mriedem | the required things i guess | 18:01 |
sdague | mriedem: I didn't quite parse the last bit there | 18:01 |
mriedem | optional / additionalProperties are configurable | 18:01 |
mriedem | parse this https://review.openstack.org/#/c/316398/29/api-ref/source/servers.inc :) | 18:01 |
mriedem | unrelated, but wanted your opinion on listing those samples | 18:01 |
*** MikeG451 has joined #openstack-nova | 18:03 | |
*** shaohe_feng has quit IRC | 18:04 | |
openstackgerrit | Arun yerra proposed openstack/nova-specs: Proposal for standardizing hardware NIC capabilities. https://review.openstack.org/341341 | 18:04 |
*** shaohe_feng has joined #openstack-nova | 18:05 | |
sdague | mriedem: I like the idea of a new sample for 2.37 because the structure of the new field is clearer with an example then with docs, I don't think we need to backfill all possible iterations before it | 18:06 |
sdague | I would also call it 2.37 with automatic networks, or something in describing it | 18:06 |
mriedem | ok, i won't do a version range then on the first one, just maybe note it's 2.1 | 18:07 |
dansmith | mriedem: mark +1ed the previous patch before I fixed a test rebase conflict, and I think you said you were good if he was: https://review.openstack.org/#/c/318266/18 | 18:07 |
*** jamielennox is now known as jamielennox|away | 18:10 | |
mriedem | forgot all about that change | 18:12 |
jaypipes | dansmith: yep, getting there. lightning storms last night took out networking (hardwired not wireless, weirdly) at my house and had to get things "fixed" today | 18:13 |
dansmith | jaypipes: heh, okay | 18:13 |
jaypipes | dansmith: as you know, I am an electronics whizkid so it was an easy effort. | 18:14 |
dansmith | indeed | 18:14 |
*** shaohe_feng has quit IRC | 18:14 | |
mriedem | jaypipes: flip the breaker? | 18:15 |
jaypipes | mriedem: pretty much. | 18:15 |
*** mingyu has quit IRC | 18:16 | |
*** shaohe_feng has joined #openstack-nova | 18:17 | |
*** unicell has quit IRC | 18:18 | |
*** baoli_ has quit IRC | 18:18 | |
*** unicell has joined #openstack-nova | 18:18 | |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: Allow multi-attach in compute api https://review.openstack.org/271047 | 18:19 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: libvirt: Allow multiple volume attachments https://review.openstack.org/267587 | 18:19 |
*** sridharg has joined #openstack-nova | 18:19 | |
*** ociuhandu has quit IRC | 18:21 | |
*** Swami has joined #openstack-nova | 18:22 | |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Don't call _create_image from finish_migration https://review.openstack.org/337160 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Rename import of nova.virt.disk.api in driver https://review.openstack.org/333521 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Add DiskFromImage and DiskFromFunc https://review.openstack.org/333522 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Rewrite _test_finish_migration https://review.openstack.org/337159 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Don't check config disk during cold migration https://review.openstack.org/337158 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Rewrite test_rescue and test_rescue_config_drive https://review.openstack.org/335966 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Separate functions to get root, ephemeral, and swap https://review.openstack.org/333984 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Combine injection info in InstanceConfig https://review.openstack.org/337790 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Replace _create_images_and_backing in _hard_reboot https://review.openstack.org/337789 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Fix fake _disk_info data in LibvirtDriverTestCase https://review.openstack.org/328366 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Use fake_imagebackend in functional https://review.openstack.org/345553 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Add create_from_image and create_from_func to Backend https://review.openstack.org/333244 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Resize an existing disk https://review.openstack.org/332416 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Add check_backing_from_func & check_backing_from_image https://review.openstack.org/322285 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Fix invalid test data https://review.openstack.org/333241 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Update tests to mock create_from_* https://review.openstack.org/345427 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Improve mocking of imagebackend disks https://review.openstack.org/333242 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Pass object to _create_images_and_backing in test https://review.openstack.org/333243 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Add create_from_image & create_from_func for Qcow2 https://review.openstack.org/320610 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Pass is_block_dev explicitly from create_from_func https://review.openstack.org/333263 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Cleanup test_create_configdrive https://review.openstack.org/339114 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Add _create_external_boot_disks https://review.openstack.org/333980 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Never copy a swap disk during cold migration https://review.openstack.org/331115 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Remove some unnecessary mocking in test_driver https://review.openstack.org/333979 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Don't re-resize disks in finish_migration() https://review.openstack.org/331118 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Don't create ephemerals or swap in _create_image https://review.openstack.org/339474 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Cleanup spawn tests https://review.openstack.org/344175 | 18:23 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Replace _create_images_and_backing in pre_live_migration https://review.openstack.org/342224 | 18:24 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Rename Backend snapshot and image https://review.openstack.org/333272 | 18:24 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Introduce ImageCacheLocalDir https://review.openstack.org/279669 | 18:24 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Test disk creation in test_hard_reboot https://review.openstack.org/338993 | 18:24 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Reset can_fallocate in test_prealloc_image https://review.openstack.org/344168 | 18:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add REST API support for get me a network https://review.openstack.org/316398 | 18:24 |
*** shaohe_feng has quit IRC | 18:24 | |
*** zul_ has joined #openstack-nova | 18:25 | |
*** zul has quit IRC | 18:25 | |
*** ayoung has quit IRC | 18:25 | |
*** shaohe_feng has joined #openstack-nova | 18:25 | |
sdague | diana_clarke: in https://review.openstack.org/#/c/328366/15 it seems that 15 reverted to back to patch 13 that dansmith had a -1 on, so his -1 is back | 18:26 |
dansmith | oye | 18:27 |
diana_clarke | sdague: yeah... sorry about that | 18:27 |
dansmith | maybe we should split that series in the middle to avoid flooding the workers every time we have to rebase? | 18:27 |
dansmith | just pause in the middle somewhere | 18:27 |
dansmith | sdague: ^ | 18:28 |
*** mnestratov has quit IRC | 18:29 | |
sdague | dansmith: yeh, that might be a good idea, cause that series does eat up a good percentage of CI when it gets rebase | 18:29 |
dansmith | yeah and it's conflict-heavy so we know there will be multiple rebases before it all lands | 18:30 |
sdague | I mean if people are reviewing the whole stack every time, it's fine | 18:30 |
sdague | but if people are only going 5 patches deep, we could optimize for turn around instead | 18:30 |
dansmith | yeah the latter I think | 18:31 |
dansmith | I've certainly not make it through more than a few at the bottom at a time | 18:31 |
sdague | yeh, then it's probably better to just pick the smaller working set, and rebase those get them fixed, landed | 18:31 |
*** baoli has joined #openstack-nova | 18:34 | |
*** shaohe_feng has quit IRC | 18:35 | |
*** shaohe_feng has joined #openstack-nova | 18:35 | |
sdague | dansmith: anyway, is the bottom patch there really -1ed by you? I was mostly trying to figure out the mismatch between your last comment and the patch votes. | 18:35 |
dansmith | sdague: yep, it contains unrelated damage to an instance structure | 18:37 |
dansmith | which was removed in 14, but re-introduced in 15 | 18:37 |
diana_clarke | I think True is an invalid value, and None is probably better. | 18:38 |
sdague | ok, just checking | 18:38 |
dansmith | diana_clarke: but it's unrelated to the change, so if we fix that, we should do it separately | 18:39 |
diana_clarke | he did say as much in the commit message | 18:40 |
diana_clarke | Anyhoo, now that I've rebased with master, I can fix that again and squash the fix, unless you want me to stop. | 18:41 |
dansmith | you mean unsquash? | 18:42 |
diana_clarke | heh | 18:42 |
dansmith | my preference would be to re-fix the bottom patch, and then submit only 5-10 of the bottom ones to get it up there | 18:43 |
*** ericksonsantos has quit IRC | 18:44 | |
*** tonytan_brb has quit IRC | 18:44 | |
*** shaohe_feng has quit IRC | 18:45 | |
*** shaohe_feng has joined #openstack-nova | 18:46 | |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: NUMA: include orphan threads with policy prefer https://review.openstack.org/344992 | 18:46 |
*** cdent has quit IRC | 18:48 | |
*** beagles is now known as beagles-brb | 18:51 | |
diana_clarke | dansmith: I know how to change just _one_ patch in the series (and orphan it), and I know how to change _all_ patches in the series (and squash fixes etc), but I don't know how to just change just _some_ of them. | 18:51 |
dansmith | diana_clarke: git review -d <pick-a-patch> | 18:52 |
dansmith | git rebase -i master | 18:52 |
dansmith | fix the first one, then review | 18:52 |
dansmith | diana_clarke: is that what you're looking for? | 18:52 |
diana_clarke | dansmith: That's what I did first (which orphaned it). | 18:52 |
dansmith | diana_clarke: you can also keep the full stack, and then just before review, check out one of the middle patches and review from that point in the stack | 18:53 |
*** dimtruck is now known as zz_dimtruck | 18:53 | |
dansmith | you're looking to effectively orphan a set of them at the top | 18:53 |
diana_clarke | oh! if orphaning is the goal, then I know how to do that. | 18:54 |
dansmith | you can't resubmit the bottom ones and not the top ones without orphaning them | 18:54 |
dansmith | so yeah | 18:54 |
diana_clarke | okie dokie, I thought I had to do this without orphaning any of the patches | 18:55 |
*** shaohe_feng has quit IRC | 18:55 | |
diana_clarke | mdbooth is totally going to kill me when he gets back... | 18:55 |
*** shaohe_feng has joined #openstack-nova | 18:56 | |
dansmith | nah | 18:56 |
dansmith | more patches merged == better | 18:56 |
dansmith | you're just going to blame me anyway, so he'll rage at me if he's going to :) | 18:56 |
*** david-lyle_ has joined #openstack-nova | 18:57 | |
*** zz_dimtruck is now known as dimtruck | 18:57 | |
*** abalutoiu__ has joined #openstack-nova | 18:59 | |
*** abalutoiu_ has quit IRC | 19:02 | |
*** shaohe_feng has quit IRC | 19:05 | |
*** beagles-brb is now known as beagles | 19:06 | |
*** shaohe_feng has joined #openstack-nova | 19:07 | |
*** david-lyle_ is now known as david-lyle | 19:07 | |
*** fifieldt has quit IRC | 19:08 | |
*** sridharg has quit IRC | 19:09 | |
*** haplo37__ has joined #openstack-nova | 19:09 | |
mriedem | dansmith: lyarwood: so i don't blow up stats i'm not -1ing but i'd like to see my comments addressed on https://review.openstack.org/#/c/318266/ | 19:11 |
mriedem | otherwise it looks ok | 19:11 |
*** shaohe_feng has quit IRC | 19:16 | |
*** shaohe_feng has joined #openstack-nova | 19:16 | |
*** tonytan4ever has joined #openstack-nova | 19:17 | |
*** fifieldt has joined #openstack-nova | 19:18 | |
*** READ10 has quit IRC | 19:19 | |
*** coolsvap has quit IRC | 19:21 | |
mriedem | does conductor create the neutron ports now? | 19:21 |
mriedem | got a vif plug timeout but the instance doesn't have a host listed in nova show | 19:22 |
mriedem | and neutron port-list is empty, so thinking nova cleaned it up? | 19:22 |
*** ctrath has quit IRC | 19:25 | |
*** sdake has joined #openstack-nova | 19:25 | |
*** shaohe_feng has quit IRC | 19:26 | |
*** shaohe_feng has joined #openstack-nova | 19:27 | |
dansmith | mriedem: you LOGrolled me again | 19:27 |
mriedem | LOGrolled you? | 19:27 |
mriedem | at least i didn't -1 | 19:27 |
dansmith | hit me up with log convention trivia | 19:27 |
dansmith | but makes sense of course, especially given the reason for those logs | 19:28 |
mriedem | heh, -1 then | 19:28 |
mriedem | since you dropped the +2 | 19:28 |
mriedem | let's coordinate all scores | 19:28 |
dansmith | I can fix it for him in a minute, he's probably gone for the day | 19:29 |
*** bvanhav has quit IRC | 19:31 | |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Fix fake _disk_info data in LibvirtDriverTestCase https://review.openstack.org/328366 | 19:31 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Use fake_imagebackend in functional https://review.openstack.org/345553 | 19:31 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Remove some unnecessary mocking in test_driver https://review.openstack.org/333979 | 19:31 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Fix invalid test data https://review.openstack.org/333241 | 19:31 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Improve mocking of imagebackend disks https://review.openstack.org/333242 | 19:31 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Pass object to _create_images_and_backing in test https://review.openstack.org/333243 | 19:31 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Reset can_fallocate in test_prealloc_image https://review.openstack.org/344168 | 19:32 |
diana_clarke | dansmith: trying again with just the bottom 7 | 19:32 |
openstackgerrit | Dan Smith proposed openstack/nova: compute: Skip driver detach calls for non local instances https://review.openstack.org/318266 | 19:32 |
dansmith | mriedem: ^ | 19:32 |
dansmith | diana_clarke: smaller list for sure | 19:33 |
dansmith | I have to run do a thing and then I'll be back and can look | 19:33 |
diana_clarke | dansmith: No rush, I'm on your timezone this week so I might be gone by then. | 19:34 |
* dansmith didn't know he had been invaded | 19:34 | |
dansmith | diana_clarke: I normally work your timezone's hours :) | 19:34 |
diana_clarke | dansmith: Our meetings are so early here! | 19:35 |
dansmith | nahhh | 19:35 |
dansmith | diana_clarke: if you want sympathy for PDT timing, talk to melwitt :D | 19:36 |
*** shaohe_feng has quit IRC | 19:36 | |
melwitt | hah | 19:36 |
*** shaohe_feng has joined #openstack-nova | 19:37 | |
diana_clarke | dansmith: so will cores know where to start reviewing now that I've orphaned the bottom 7 patches? | 19:37 |
diana_clarke | oh! the +2 magically came back | 19:39 |
mriedem | do we unbind the host from an instance on scheduling aborts? | 19:40 |
mriedem | i've never seen that before | 19:40 |
*** anush_ has quit IRC | 19:40 | |
mriedem | bauzas: ^? | 19:41 |
*** sdake has quit IRC | 19:43 | |
openstackgerrit | Clif Houck proposed openstack/nova: Add Image Remote Authentication Verification https://review.openstack.org/330773 | 19:44 |
mriedem | oh i see it | 19:44 |
mriedem | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1829 | 19:45 |
mriedem | self._nil_out_instance_obj_host_and_node(instance) | 19:45 |
mriedem | makes tracking down which compute the instance was building on kind of messy | 19:46 |
mriedem | when you don't have logsatsh | 19:46 |
*** shaohe_feng has quit IRC | 19:46 | |
*** shaohe_feng has joined #openstack-nova | 19:47 | |
*** jamesdenton has joined #openstack-nova | 19:47 | |
dansmith | mriedem: fixed alignment | 19:49 |
openstackgerrit | Dan Smith proposed openstack/nova: compute: Skip driver detach calls for non local instances https://review.openstack.org/318266 | 19:49 |
mriedem | oh hot damn | 19:49 |
jaypipes | mriedem: https://review.openstack.org/#/c/343120/ should be good to go, FYI | 19:50 |
*** sdake has joined #openstack-nova | 19:53 | |
*** jdurgin has quit IRC | 19:53 | |
mriedem | jaypipes: will check it out - can you also take a look at this? https://review.openstack.org/#/c/347971/ | 19:54 |
mriedem | jaypipes: it's glance, so you love it | 19:54 |
*** shaohe_feng has quit IRC | 19:57 | |
*** shaohe_feng has joined #openstack-nova | 19:58 | |
openstackgerrit | Sarafraj Singh proposed openstack/nova: Adding functional tests for 2.3 microversion https://review.openstack.org/347544 | 20:00 |
jaypipes | mriedem: done. | 20:01 |
*** ctrath has joined #openstack-nova | 20:02 | |
mriedem | jaypipes: ok on that spec amendment, | 20:05 |
mriedem | * `409 Conflict` if another process updated any existing inventory record | 20:05 |
mriedem | since the `resource_provider_generation` view marker was returned. | 20:05 |
mriedem | is what i was hoping to see - basically the new PUT wipes out any existing inventories for the RP right? | 20:06 |
mriedem | and if we have racing updates to the RP we will fail if one of them doesn't have the latest data (generation id?) | 20:06 |
*** shaohe_feng has quit IRC | 20:07 | |
*** shaohe_feng has joined #openstack-nova | 20:08 | |
*** Apoorva has quit IRC | 20:09 | |
openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Add details to general purpose feature matrix https://review.openstack.org/344483 | 20:12 |
*** akshai has quit IRC | 20:15 | |
*** shihanzhang has joined #openstack-nova | 20:17 | |
*** tangchen has quit IRC | 20:17 | |
*** eil397 has quit IRC | 20:17 | |
*** cdelatte has quit IRC | 20:17 | |
*** shaohe_feng has quit IRC | 20:17 | |
*** ihrachys has joined #openstack-nova | 20:17 | |
*** shz has quit IRC | 20:18 | |
mriedem | edleafe: ^? | 20:18 |
*** shaohe_feng has joined #openstack-nova | 20:18 | |
*** tangchen has joined #openstack-nova | 20:19 | |
*** ericksonsantos has joined #openstack-nova | 20:20 | |
dansmith | mriedem: the put does replace all current inventories, if that's what you're asking | 20:21 |
mriedem | dansmith: right, but the generation id is to make sure we're calling with the latest known state of the RP right? | 20:23 |
mriedem | although if you're overwriting all inventories for an RP, i'm not sure why it matters | 20:24 |
dansmith | mriedem: it does matter, and yes that's the reason | 20:24 |
dansmith | mriedem: it's to avoid two things updating the inventories at the same time, so for example: | 20:24 |
dansmith | I am the disk script, so I fetch the current set, update the disk amount and PUT | 20:25 |
dansmith | you are the memory script, and you do the same but for the memory | 20:25 |
* edleafe reads scrollback | 20:25 | |
dansmith | you want to have a single consistent view, which will be wrong if we both win | 20:25 |
dansmith | so the generation and retry is specifically to make sure those are serialized | 20:25 |
edleafe | mriedem: what dansmith said. If the generation doesn't match, it's a race, and the update is rejected | 20:26 |
* dansmith gets himself a cookie for being right | 20:27 | |
*** shaohe_feng has quit IRC | 20:27 | |
mriedem | yeah, right, | 20:28 |
* edleafe envisions dansmith weighing 900 lbs with all those cookies | 20:28 | |
mriedem | but disk and ram scripts are doing a PUT with all inventories, or just their specific ones? | 20:28 |
dansmith | edleafe: if only.. | 20:28 |
dansmith | mriedem: all | 20:28 |
*** shaohe_feng has joined #openstack-nova | 20:28 | |
dansmith | mriedem: which is why they need to know if one that they don't control has changed since they fetched | 20:28 |
mriedem | yup | 20:29 |
*** JoseMello has quit IRC | 20:30 | |
*** ducttape_ has quit IRC | 20:31 | |
*** aswadr_ has quit IRC | 20:31 | |
*** cleong has quit IRC | 20:35 | |
*** tjones has joined #openstack-nova | 20:36 | |
*** tjones has left #openstack-nova | 20:37 | |
*** shaohe_feng has quit IRC | 20:38 | |
*** shaohe_feng has joined #openstack-nova | 20:39 | |
*** artom_ has joined #openstack-nova | 20:41 | |
*** artom has quit IRC | 20:41 | |
openstackgerrit | Jay Pipes proposed openstack/nova-specs: Amend placement REST API with allocation records https://review.openstack.org/338618 | 20:41 |
*** artom_ has quit IRC | 20:42 | |
*** artom_ has joined #openstack-nova | 20:42 | |
*** oomichi has joined #openstack-nova | 20:43 | |
*** Apoorva has joined #openstack-nova | 20:45 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Default image.size to 0 when extracting v1 image attributes https://review.openstack.org/347571 | 20:46 |
*** sdake has quit IRC | 20:46 | |
*** shaohe_feng has quit IRC | 20:48 | |
*** shaohe_feng has joined #openstack-nova | 20:49 | |
*** cdelatte has joined #openstack-nova | 20:51 | |
*** ayoung has joined #openstack-nova | 20:55 | |
*** abalutoiu_ has joined #openstack-nova | 20:55 | |
*** thorst has quit IRC | 20:55 | |
openstackgerrit | Anusha Unnam proposed openstack/nova: Remove deprecated manager option in cells.py https://review.openstack.org/348039 | 20:55 |
*** ducttape_ has joined #openstack-nova | 20:57 | |
*** shaohe_feng has quit IRC | 20:58 | |
*** abalutoiu__ has quit IRC | 20:59 | |
*** shaohe_feng has joined #openstack-nova | 20:59 | |
*** jamesdenton has quit IRC | 21:03 | |
bauzas | mriedem: sorry was afk | 21:04 |
bauzas | mriedem: what's up ? | 21:04 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Use fake_imagebackend in functional https://review.openstack.org/345553 | 21:04 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Remove some unnecessary mocking in test_driver https://review.openstack.org/333979 | 21:04 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Improve mocking of imagebackend disks https://review.openstack.org/333242 | 21:04 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Pass object to _create_images_and_backing in test https://review.openstack.org/333243 | 21:04 |
openstackgerrit | Diana Clarke proposed openstack/nova: libvirt: Reset can_fallocate in test setUp() https://review.openstack.org/344168 | 21:04 |
bauzas | scrolling back, but no clear explanation | 21:05 |
mriedem | bauzas: was debugging something where scheduling failed b/c of networking (vif plug timeout), hit BuildAbortException, and was trying to find which compute (of 400) the instance built on | 21:06 |
mriedem | since nova-show didn't show instance.host | 21:06 |
mriedem | anyway, figured it out - we null out the host and node props on the instance in the compute manager when we hit BuildAbortException | 21:06 |
bauzas | yup, by the exception | 21:08 |
*** clenimar has quit IRC | 21:08 | |
*** shaohe_feng has quit IRC | 21:08 | |
*** shaohe_feng has joined #openstack-nova | 21:09 | |
*** jdurgin has joined #openstack-nova | 21:10 | |
*** jamielennox|away is now known as jamielennox | 21:17 | |
*** mingyu has joined #openstack-nova | 21:17 | |
*** shaohe_feng has quit IRC | 21:19 | |
*** shaohe_feng has joined #openstack-nova | 21:20 | |
mriedem | we don't have ELK yet either so it was messy finding the compute node for that instance | 21:21 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add the ability to configure glanceclient debug logging https://review.openstack.org/347914 | 21:21 |
openstackgerrit | Matt Riedemann proposed openstack/nova: DNM: enable glanceclient debug logging https://review.openstack.org/348046 | 21:21 |
mriedem | grepping the nova-scheduler logs did the trick though | 21:21 |
*** mingyu has quit IRC | 21:21 | |
*** rtheis has quit IRC | 21:22 | |
*** david-lyle has quit IRC | 21:25 | |
*** shaohe_feng has quit IRC | 21:29 | |
openstackgerrit | Anusha Unnam proposed openstack/nova: Config options consistency for consoleauth.py https://review.openstack.org/348050 | 21:29 |
*** shaohe_feng has joined #openstack-nova | 21:30 | |
*** admin0 has joined #openstack-nova | 21:32 | |
*** xinliang has quit IRC | 21:37 | |
openstackgerrit | Eric Fried proposed openstack/nova: cleanup_live_migration_destination_check spacing https://review.openstack.org/348054 | 21:37 |
*** shaohe_feng has quit IRC | 21:39 | |
*** shaohe_feng has joined #openstack-nova | 21:40 | |
openstackgerrit | Anush Krishnamurthy proposed openstack/nova: Deprecate cert option https://review.openstack.org/348055 | 21:41 |
openstackgerrit | Sarafraj Singh proposed openstack/nova: Deprecate cert option https://review.openstack.org/348055 | 21:46 |
tonyb | dansmith: so https://review.openstack.org/#/c/345633/ merged which is in the oposite direction to what we said at the mid-cycle | 21:46 |
dansmith | tonyb: le sigh | 21:47 |
dansmith | tonyb: you want to put up a revert and I'll +2 it? | 21:47 |
*** admin0 has quit IRC | 21:47 | |
dansmith | tonyb: we have a fast revert policy for things like this | 21:47 |
tonyb | dansmith: Sure. | 21:48 |
*** xinliang has joined #openstack-nova | 21:49 | |
*** shaohe_feng has quit IRC | 21:49 | |
*** shaohe_feng has joined #openstack-nova | 21:50 | |
*** rfolco has quit IRC | 21:50 | |
*** tonytan4ever has quit IRC | 21:51 | |
*** haplo37__ has quit IRC | 21:52 | |
openstackgerrit | Tony Breeds proposed openstack/nova: Revert "Don't assert exact to_dict output" https://review.openstack.org/348057 | 21:54 |
openstackgerrit | Anush Krishnamurthy proposed openstack/nova: Deprecate cert option https://review.openstack.org/348055 | 21:54 |
*** admin0 has joined #openstack-nova | 21:55 | |
mriedem | melwitt: should we just drop this? https://review.openstack.org/#/c/293800/ i don't plan on working on it | 21:57 |
dansmith | mriedem: or melwitt: can you +W this per fast-revert policy? https://review.openstack.org/#/c/348057/1 | 21:57 |
*** sameo_ has joined #openstack-nova | 21:57 | |
*** rama_y has quit IRC | 21:57 | |
mriedem | dansmith: i wasn't part of the midcycle discussion on that one | 21:57 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Remove unused validation code for quota_sets https://review.openstack.org/348059 | 21:57 |
dansmith | mriedem: only tony and I were really | 21:58 |
mriedem | sell me quick | 21:58 |
dansmith | mriedem: they removed an assertion of what the context looks like on the wire so they can change it and potentially break us | 21:58 |
melwitt | mriedem: I want to keep it. I made it work and thought it would be useful | 21:58 |
dansmith | mriedem: tonyb was going to make the test properly check for the old and new, and assert they're compatible | 21:59 |
*** tblakeslee has quit IRC | 21:59 | |
mriedem | dansmith: oh so rather than exact dict compare, this is like a subset | 21:59 |
*** shaohe_feng has quit IRC | 22:00 | |
dansmith | mriedem: right | 22:00 |
mriedem | so they could add things to the to_dict() response and we wouldn't know about it | 22:00 |
tonyb | mriedem: I was going to keep the exact dict but add ashim to work with old and new | 22:00 |
dansmith | this is worth us being pedantic about.. the breakage is a good thing | 22:00 |
*** shaohe_feng has joined #openstack-nova | 22:00 | |
*** sameo has quit IRC | 22:01 | |
*** rama_y has joined #openstack-nova | 22:01 | |
mriedem | +W | 22:02 |
*** c64cosmin has quit IRC | 22:03 | |
*** mdrabe has quit IRC | 22:03 | |
*** efried has quit IRC | 22:04 | |
*** abalutoiu_ has quit IRC | 22:04 | |
*** ducttape_ has quit IRC | 22:05 | |
mriedem | melwitt: should probably drop the WIP: prefix then huh | 22:06 |
melwitt | mriedem: yeah, I must have glossed over that. I'll remove the WIP | 22:07 |
mriedem | melwitt: there are also some TODOs in there about skipping until some bug is fixed, but the tests aren't actually skipped | 22:07 |
*** burt has quit IRC | 22:09 | |
openstackgerrit | Sarafraj Singh proposed openstack/nova: Remove deprecated manager option in cells.py https://review.openstack.org/348039 | 22:09 |
melwitt | mriedem: ah ... right. I must have been seeing if it worked in the gate and forgot to put the real skips in and remove the WIP, or something | 22:09 |
*** oomichi has quit IRC | 22:10 | |
*** shaohe_feng has quit IRC | 22:10 | |
*** shaohe_feng has joined #openstack-nova | 22:11 | |
*** oomichi has joined #openstack-nova | 22:11 | |
*** tziarko has quit IRC | 22:12 | |
*** mriedem has quit IRC | 22:12 | |
*** xyang1 has quit IRC | 22:13 | |
*** salv-orlando has quit IRC | 22:13 | |
openstackgerrit | Anush Krishnamurthy proposed openstack/nova: Update tags for Cache config option https://review.openstack.org/348064 | 22:17 |
*** salv-orlando has joined #openstack-nova | 22:17 | |
*** hemna is now known as hemnafk | 22:18 | |
*** tbachman has quit IRC | 22:20 | |
*** shaohe_feng has quit IRC | 22:20 | |
*** shaohe_feng has joined #openstack-nova | 22:21 | |
*** david-lyle has joined #openstack-nova | 22:22 | |
*** salv-orlando has quit IRC | 22:23 | |
*** ctrath has quit IRC | 22:23 | |
*** pwnall1 has joined #openstack-nova | 22:23 | |
*** tbachman has joined #openstack-nova | 22:24 | |
*** jaypipes has quit IRC | 22:24 | |
*** edmondsw has quit IRC | 22:25 | |
*** david-lyle has quit IRC | 22:25 | |
*** eil397 has joined #openstack-nova | 22:25 | |
*** david-lyle has joined #openstack-nova | 22:25 | |
openstackgerrit | Michael Still proposed openstack/nova: Add support for vd2 user contet to other drivers https://review.openstack.org/348066 | 22:25 |
*** shaohe_feng has quit IRC | 22:30 | |
openstackgerrit | Michael Still proposed openstack/nova: Add support for vd2 user context to other drivers https://review.openstack.org/348066 | 22:31 |
*** shaohe_feng has joined #openstack-nova | 22:31 | |
*** diogogmt_ has joined #openstack-nova | 22:33 | |
openstackgerrit | Anusha Unnam proposed openstack/nova: Improve help text for xenapi_session_opts https://review.openstack.org/322322 | 22:33 |
*** diogogmt has quit IRC | 22:34 | |
*** diogogmt_ is now known as diogogmt | 22:34 | |
*** TravT_ has joined #openstack-nova | 22:35 | |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: Allocate PCI devices on migration https://review.openstack.org/328983 | 22:37 |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: Fixes for race conditions in revert migration with SR-IOV https://review.openstack.org/339765 | 22:37 |
*** TravT has quit IRC | 22:37 | |
*** jwcroppe has quit IRC | 22:40 | |
*** jwcroppe has joined #openstack-nova | 22:41 | |
*** shaohe_feng has quit IRC | 22:41 | |
*** shaohe_feng has joined #openstack-nova | 22:44 | |
*** jwcroppe has quit IRC | 22:45 | |
*** jamielennox is now known as jamielennox|away | 22:45 | |
*** thorst_ has joined #openstack-nova | 22:47 | |
*** david-lyle has quit IRC | 22:50 | |
*** david-lyle_ has joined #openstack-nova | 22:50 | |
*** tjones has joined #openstack-nova | 22:50 | |
*** TravT_ has quit IRC | 22:51 | |
openstackgerrit | Tony Breeds proposed openstack/nova: Add support for oslo.context 2.6.0 https://review.openstack.org/342604 | 22:51 |
*** shaohe_feng has quit IRC | 22:51 | |
tonyb | dansmith: ^^ that's what I thought we talked about. happy to fix it if I messed up. | 22:52 |
*** shaohe_feng has joined #openstack-nova | 22:52 | |
dansmith | tonyb: yep, looking | 22:52 |
tonyb | dansmith: Thanks | 22:53 |
*** aysyd has quit IRC | 22:54 | |
dansmith | tonyb: so that test works because we assert the value is always there, which it is even with the old context because of the default, right? and then we'll need a conditional in the test to bump the req? | 22:55 |
*** diogogmt has quit IRC | 22:55 | |
*** thorst_ has quit IRC | 22:55 | |
*** zhs__ has quit IRC | 22:56 | |
*** zhs__ has joined #openstack-nova | 22:56 | |
*** diogogmt has joined #openstack-nova | 22:56 | |
*** thorst_ has joined #openstack-nova | 22:56 | |
tonyb | dansmith: it's always there because we add it if oslo.context is < 2.5.0 | 22:56 |
dansmith | tonyb: you mean we always add it if it's not there (which would be <2.5.0) right? I see now, we're checking the wire format in the first one, which is post-mod | 22:57 |
tonyb | dansmith: so if we pass the attribute as a kwarg to the oldcontext oslo ignores it, if we don't pass it then we get the default | 22:57 |
dansmith | so yeah, cool | 22:57 |
tonyb | Yeah. | 22:58 |
*** dimtruck is now known as zz_dimtruck | 22:58 | |
tonyb | dansmith: Do we wnat additional tesst to show the old/new combo's work? | 22:59 |
dansmith | tonyb: you mean a from_dict with the older format? | 23:00 |
tonyb | dansmith: yeah | 23:00 |
dansmith | I dunno, I mean, I guess that's extra ocd which is good | 23:01 |
*** siva_krish has quit IRC | 23:01 | |
*** david-lyle_ has quit IRC | 23:01 | |
*** shaohe_feng has quit IRC | 23:01 | |
dansmith | tonyb: so just a test_convert_from_dict_to_dict_version_2_4_x() | 23:01 |
dansmith | yeah I guess | 23:01 |
*** siva_krish has joined #openstack-nova | 23:02 | |
*** vishwanathj has quit IRC | 23:02 | |
tonyb | dansmith: ok I'll do that thing | 23:02 |
*** shaohe_feng has joined #openstack-nova | 23:02 | |
*** siva_krish has quit IRC | 23:03 | |
*** siva_krish has joined #openstack-nova | 23:03 | |
*** mriedem has joined #openstack-nova | 23:03 | |
*** thorst_ has quit IRC | 23:04 | |
*** abalutoiu has joined #openstack-nova | 23:05 | |
*** siva_krish has quit IRC | 23:08 | |
*** abalutoiu has quit IRC | 23:08 | |
*** shaohe_feng has quit IRC | 23:12 | |
*** shaohe_feng has joined #openstack-nova | 23:13 | |
tonyb | How do you guys work with the long delays in the check pipeline? It's a whole new world ;P | 23:14 |
dansmith | lol | 23:15 |
*** artom_ has quit IRC | 23:16 | |
openstackgerrit | Anush Krishnamurthy proposed openstack/nova: Deprecate cert option https://review.openstack.org/348055 | 23:17 |
*** sdake has joined #openstack-nova | 23:17 | |
*** artom has joined #openstack-nova | 23:21 | |
mriedem | long delays? | 23:21 |
mriedem | tonyb: if you run for reqs PTL, are you going to also run for stable PTL or let it lapse? | 23:21 |
mriedem | or both? | 23:22 |
tonyb | mriedem: both | 23:22 |
*** shaohe_feng has quit IRC | 23:22 | |
*** shaohe_feng has joined #openstack-nova | 23:23 | |
tonyb | mriedem: If I *had* to choose stable would be #1 (unless you know you're going to come back into the fold ;P) | 23:23 |
mtreinish | tonyb: you should sink one of the ships | 23:23 |
*** hoangcx2 has quit IRC | 23:24 | |
tonyb | mtreinish: hehe, I could try to fold reqs into stable but that's a bit nuts | 23:24 |
*** hoangcx has joined #openstack-nova | 23:24 | |
*** sdake has quit IRC | 23:25 | |
openstackgerrit | John Griffith proposed openstack/nova: Implement new attach/detach Cinder flow https://review.openstack.org/348079 | 23:25 |
*** artom has quit IRC | 23:26 | |
jgriffith | gahh | 23:26 |
*** abalutoiu has joined #openstack-nova | 23:26 | |
mriedem | tonyb: i won't be stable PTL nope | 23:27 |
tonyb | mriedem: ;P | 23:27 |
mriedem | it's mtreinish's turn | 23:27 |
*** artom has joined #openstack-nova | 23:29 | |
*** abalutoiu_ has joined #openstack-nova | 23:29 | |
mtreinish | I will burn it to the ground | 23:29 |
mtreinish | you probably don't want me to do it | 23:29 |
mriedem | mtreinish: i don't work on a distro anymore | 23:30 |
mriedem | so meh | 23:30 |
mriedem | i'm living the CD life now | 23:31 |
dansmith | livin' la via loca | 23:31 |
dansmith | er, vida | 23:31 |
*** shaohe_feng has quit IRC | 23:32 | |
*** abalutoiu has quit IRC | 23:32 | |
mriedem | please don't bring ricky martin into this | 23:33 |
*** shaohe_feng has joined #openstack-nova | 23:33 | |
*** nic has quit IRC | 23:35 | |
*** Sukhdev has joined #openstack-nova | 23:36 | |
*** mtanino has quit IRC | 23:37 | |
*** ducttape_ has joined #openstack-nova | 23:37 | |
*** tjones has left #openstack-nova | 23:37 | |
gus | sdague/dansmith/mikal/mriedem: So my venv concern was that: with an explicit privsep-helper entry in rootwrap filters, the deployer human/tool can easily modify the command to have some specific path that isn't in the usual sudoers $PATH. There's no opportunity to modify the equivalent hardcoded privsep-helper entry. | 23:41 |
mriedem | gus: does anyone do that? | 23:42 |
*** shaohe_feng has quit IRC | 23:42 | |
gus | well, I was thinking it _had_ to be done for venvs. | 23:42 |
*** salv-orlando has joined #openstack-nova | 23:42 | |
gus | dims_: oh, and fwiw, 1am is indeed "too early" for me to be awake ;) | 23:43 |
*** shaohe_feng has joined #openstack-nova | 23:43 | |
gus | So I'm not clear from the overnight review comments or irc backlog - has someone actually tried it in a venv? | 23:44 |
*** abalutoiu_ has quit IRC | 23:45 | |
gus | specifically, I'm wondering if PYTHONPATH gets set correctly via some magic I haven't found yet by code inspection. | 23:45 |
*** abalutoiu has joined #openstack-nova | 23:45 | |
*** Guest9888 has quit IRC | 23:46 | |
*** salv-orlando has quit IRC | 23:47 | |
*** Apoorva_ has joined #openstack-nova | 23:49 | |
*** artom has quit IRC | 23:50 | |
*** rrecio has quit IRC | 23:51 | |
tonyb | gus: I did some testing in a venv, but it was pretty basic | 23:51 |
*** artom has joined #openstack-nova | 23:52 | |
gus | cool. so long as privsep-helper starts, I think we're good. | 23:52 |
*** Apoorva has quit IRC | 23:52 | |
tonyb | gus: it replies on privsep-helper being an unqualified filter, PATH being set correctly for the venv and the default (ie missing) exec_dirs | 23:52 |
*** shaohe_feng has quit IRC | 23:53 | |
*** Apoorva_ has quit IRC | 23:53 | |
*** shaohe_feng has joined #openstack-nova | 23:53 | |
openstackgerrit | Tony Breeds proposed openstack/nova: Add support for oslo.context 2.6.0 https://review.openstack.org/342604 | 23:54 |
gus | ... and (in the venv case) that starts $venv/bin/python, and python's sys.path automatically picks up ../lib - ok, got it. | 23:54 |
clarkb | if you activate a venv it sets $PATH properly too | 23:54 |
*** diogogmt has quit IRC | 23:55 | |
tonyb | clarkb: Yeah you have to activate the venv or $PATH is incorrect but sys.path is ok | 23:56 |
*** code-R_ has quit IRC | 23:56 | |
gus | clarkb: not on the other side of sudo - which resets all the good bits of the environment. | 23:56 |
clarkb | gus: right you'd have to sudo -E or source the activate file as part of your sudo command | 23:57 |
*** hoangcx2 has joined #openstack-nova | 23:58 | |
mriedem | gus: odyssey4me said they'd be testing it out in openstack-ansible too once it landed and was released | 23:58 |
gus | tonyb: it looks like rootwrap uses exec_dirs to find the executable, but doesn't actually propagate exec_dirs into PATH. So it will be able to start privsep-helper fine, but privsep-helper won't be able to find any other commands in the venv if required. I think that's probably fine in practice. | 23:58 |
mriedem | i'm not sure that the rootwrap 5.0.0 release is queued up though | 23:59 |
gus | mriedem: sure, I was hoping we could test it before then however ;) .. as we have no done. | 23:59 |
mriedem | oh here it is https://review.openstack.org/#/c/347983/ | 23:59 |
gus | *now done. | 23:59 |
mriedem | gus: yeah the fear is having this creep to far | 23:59 |
mriedem | we want to land it and get it burnt in | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!