*** jvgrant has quit IRC | 00:00 | |
*** shaohe_feng has quit IRC | 00:01 | |
*** jwcroppe has quit IRC | 00:01 | |
*** shaohe_feng has joined #openstack-nova | 00:01 | |
*** testing1234 has quit IRC | 00:03 | |
*** kragniz1 has joined #openstack-nova | 00:03 | |
*** ducttape_ has quit IRC | 00:05 | |
*** sameo_ has quit IRC | 00:06 | |
*** diogogmt has quit IRC | 00:08 | |
*** shaohe_feng has quit IRC | 00:11 | |
*** shaohe_feng has joined #openstack-nova | 00:12 | |
*** ducttape_ has joined #openstack-nova | 00:14 | |
*** hoangcx2 has quit IRC | 00:16 | |
*** hoangcx has joined #openstack-nova | 00:16 | |
*** mingyu has joined #openstack-nova | 00:17 | |
*** baoli has joined #openstack-nova | 00:17 | |
*** devkulkarni1 has quit IRC | 00:19 | |
*** Swami has quit IRC | 00:20 | |
*** devkulkarni1 has joined #openstack-nova | 00:20 | |
*** shaohe_feng has quit IRC | 00:21 | |
*** pooja has joined #openstack-nova | 00:21 | |
*** mingyu has quit IRC | 00:22 | |
*** shaohe_feng has joined #openstack-nova | 00:22 | |
*** gouthamr has joined #openstack-nova | 00:23 | |
pooja | Hi, I was having an issue when using 'nova rebuild' command as (nova/scheduler/filters/image_props_filter.py) image_props = spec.get('image', {}).get('properties', {}) fails | 00:25 |
---|---|---|
oomichi | pooja: did you submit it on the launchpad? | 00:26 |
pooja | The request_spec in scheduler filter_properties has just image id in spec.get('image') but it expects a dict, with properties | 00:26 |
pooja | Hi oomichi, no.. I was not sure if its a product bug | 00:26 |
pooja | Is rebuild a valid operation for instances that failed to schedule with NoValidHostFound error to begin with? | 00:27 |
oomichi | pooja: it is nice to submit it with the details(logs, config, etc) | 00:27 |
pooja | sure, will file a bug | 00:27 |
oomichi | pooja: thanks | 00:27 |
oomichi | pooja: ah, NoValidHostFound error happens on that? | 00:28 |
pooja | No instance failed to spawn with NoValidHostFound and then I did rebuild after removing some constraints | 00:28 |
pooja | It failed with this error on rebuild - AttributeError: 'unicode' object has no attribute 'get' | 00:28 |
oomichi | pooja: that seems a bug, and good to report that | 00:29 |
pooja | Sure, will report it | 00:29 |
pooja | In the meantime, is there another api to reschedule a failed instance? | 00:30 |
*** ducttape_ has quit IRC | 00:31 | |
*** shaohe_feng has quit IRC | 00:31 | |
oomichi | mriedem: I guess https://review.openstack.org/#/c/351960 is easy for you | 00:32 |
oomichi | pooja: I guess the instance never booted at all, so isn't it fine to just "create a server" again? | 00:34 |
mriedem | oomichi: why would the floating IP have a port_id but the port doesn't exist? | 00:34 |
*** shaohe_feng has joined #openstack-nova | 00:34 | |
*** code-R has joined #openstack-nova | 00:36 | |
pooja | oomichi: I wanted to use the same server uuid since its part of a heat template, so needed a way to reschedule without the availability zone constraint on failure | 00:36 |
*** code-R_ has joined #openstack-nova | 00:37 | |
*** hamzy has joined #openstack-nova | 00:38 | |
*** code-R has quit IRC | 00:40 | |
*** raunak has quit IRC | 00:40 | |
*** shaohe_feng has quit IRC | 00:42 | |
*** mlavalle has quit IRC | 00:42 | |
*** shaohe_feng has joined #openstack-nova | 00:43 | |
gmann | alex_xu: on almost all policy tests i saw we use override policy rule with "project: non_fake" | 00:44 |
gmann | alex_xu: what exactly we want to tests there, "override rule with any string and check it fail" or "we want to override different project_id and then check if policy fail" ? | 00:45 |
*** sdake has joined #openstack-nova | 00:46 | |
gmann | alex_xu: like - https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/test_admin_actions.py#L78 | 00:46 |
gmann | alex_xu: if our motive was to tests later one then we should change project to project_id in all tests | 00:47 |
gmann | alex_xu: and if first one then current tests are fine | 00:47 |
*** devkulkarni2 has joined #openstack-nova | 00:48 | |
*** devkulkarni1 has quit IRC | 00:48 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Add tests for user_id policy enforcement on stop https://review.openstack.org/353335 | 00:48 |
*** shaohe_feng has quit IRC | 00:52 | |
*** code-R_ has quit IRC | 00:53 | |
*** shaohe_feng has joined #openstack-nova | 00:53 | |
*** code-R has joined #openstack-nova | 00:53 | |
oomichi | mriedem: yeah, that was I asked you | 00:53 |
oomichi | mriedem: I wrote my idea on https://review.openstack.org/#/c/351960 | 00:53 |
*** davidlenwell has quit IRC | 00:53 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server pause action https://review.openstack.org/352221 | 00:53 |
openstackgerrit | Hieu LE proposed openstack/nova: Config options: improve libvirt help text (2) https://review.openstack.org/316550 | 01:01 |
*** rfolco has quit IRC | 01:02 | |
*** shaohe_feng has quit IRC | 01:02 | |
mriedem | good news, got 1 novaclient test passing on this direct glance change, only like 140+ more to go | 01:03 |
*** shaohe_feng has joined #openstack-nova | 01:03 | |
*** raunak has joined #openstack-nova | 01:05 | |
*** davidlenwell has joined #openstack-nova | 01:05 | |
*** diogogmt has joined #openstack-nova | 01:05 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: Fix consistency in crypto conf https://review.openstack.org/354348 | 01:06 |
*** gouthamr_ has joined #openstack-nova | 01:06 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Return None in get_instance_id_by_floating_address https://review.openstack.org/351960 | 01:09 |
*** gouthamr has quit IRC | 01:10 | |
*** vishwanathj has quit IRC | 01:10 | |
oomichi | mriedem: thanks, ^^^ is updated | 01:11 |
oomichi | mriedem: btw, now novaclient is not only for nova? | 01:11 |
*** tonytan4ever has joined #openstack-nova | 01:11 | |
*** mingyu has joined #openstack-nova | 01:11 | |
mriedem | oomichi: https://review.openstack.org/#/c/354349/ | 01:11 |
mriedem | no, to support 2.36 in novaclient we have to make it not rely on it's own proxy APIs | 01:11 |
mriedem | which 404 in 2.36 | 01:12 |
oomichi | mriedem: yeah, I saw that | 01:12 |
*** shaohe_feng has quit IRC | 01:12 | |
*** _diana_ has joined #openstack-nova | 01:13 | |
*** shaohe_feng has joined #openstack-nova | 01:13 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: Improve consistency in libvirt https://review.openstack.org/353679 | 01:13 |
*** baoli has quit IRC | 01:13 | |
*** devkulkarni2 has quit IRC | 01:14 | |
oomichi | mriedem: for translating "image name" <-> "image id", novaclient needs to access glance api directly instead of proxying api | 01:14 |
*** gouthamr_ is now known as gouthamr | 01:14 | |
*** zhangjn has quit IRC | 01:14 | |
oomichi | mriedem: that means novaclient is not only for nova api | 01:15 |
*** jaypipes has quit IRC | 01:15 | |
oomichi | mriedem: maybe we(novaclient) will need to take care of glance api also | 01:15 |
openstackgerrit | Maciej Szankin proposed openstack/nova: Improve consistency in libvirt https://review.openstack.org/353679 | 01:16 |
*** Apoorva has quit IRC | 01:16 | |
*** tonytan4ever has quit IRC | 01:16 | |
*** zhangjn has joined #openstack-nova | 01:16 | |
oomichi | mriedem: that seems the burden is moving to client side from nova itself | 01:16 |
mriedem | well, the api part of novaclient won't do that | 01:18 |
mriedem | that requires an image id | 01:18 |
mriedem | but the CLI has convenience things for passing in image name and we lookup the id | 01:18 |
*** rpodolyaka_ has joined #openstack-nova | 01:18 | |
mriedem | but yeah we really need to just deprecate the CLI and move to osc | 01:18 |
mriedem | we're going to have to do the same for networks | 01:18 |
oomichi | mriedem: yeah, the translation is very useful for cli users. | 01:19 |
*** Apoorva has joined #openstack-nova | 01:20 | |
*** rpodolyaka has quit IRC | 01:21 | |
*** rpodolyaka_ is now known as rpodolyaka | 01:21 | |
*** shaohe_feng has quit IRC | 01:23 | |
*** Apoorva has quit IRC | 01:23 | |
*** wangqun has joined #openstack-nova | 01:23 | |
*** Apoorva has joined #openstack-nova | 01:23 | |
oomichi | mriedem: is openstackclient alternative instead? TBH, I am not good at current situation of clients side | 01:24 |
oomichi | openstackclient is for cross-projects and it seems easy to handle this kind of thing | 01:25 |
oomichi | but it doesn't support microversions anyways.. | 01:25 |
mriedem | right osc doesn't support microversions yet | 01:25 |
mriedem | which is why we haven't deprecated the nova cli | 01:26 |
*** shaohe_feng has joined #openstack-nova | 01:26 | |
mriedem | well, osc doesn't support microversions yet as far as i know, i don't know what the status on that is | 01:26 |
oomichi | mriedem: yeah, according to the code of osc, you are right. | 01:27 |
oomichi | there is not any code which passes microversions on https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/client.py | 01:28 |
*** baoli has joined #openstack-nova | 01:29 | |
*** unicell has quit IRC | 01:29 | |
*** EinstCrazy has joined #openstack-nova | 01:30 | |
*** unicell has joined #openstack-nova | 01:30 | |
* oomichi necessary to bring kids into a swiming pool just before dinner | 01:30 | |
*** oomichi has quit IRC | 01:30 | |
*** mingyu has quit IRC | 01:31 | |
*** vishwanathj has joined #openstack-nova | 01:32 | |
*** zhangjl has joined #openstack-nova | 01:33 | |
*** zhangjl has left #openstack-nova | 01:33 | |
*** shaohe_feng has quit IRC | 01:33 | |
*** shaohe_feng has joined #openstack-nova | 01:34 | |
alex_xu | gmann: when I write those patch, I think of later one | 01:34 |
alex_xu | gmann: non_fake is a project_id | 01:35 |
openstackgerrit | Maciej Szankin proposed openstack/nova: config options: Improve help for SPICE https://review.openstack.org/317046 | 01:36 |
gmann | alex_xu: humm, may be then we need to cleanup those tests to do like - "project_id:non_fake" | 01:38 |
*** takedakn has joined #openstack-nova | 01:39 | |
gmann | alex_xu: to test the right behavior on project_id things | 01:39 |
*** mingyu has joined #openstack-nova | 01:42 | |
*** takedakn has quit IRC | 01:43 | |
*** shaohe_feng has quit IRC | 01:43 | |
*** pooja has quit IRC | 01:43 | |
*** shaohe_feng has joined #openstack-nova | 01:44 | |
*** unicell has quit IRC | 01:46 | |
*** mingyu has quit IRC | 01:47 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server resize action https://review.openstack.org/354478 | 01:50 |
alex_xu | gmann: emm...sorry I didn't get you. project_id:non_fake already is current test to do? | 01:52 |
*** shaohe_feng has quit IRC | 01:53 | |
gmann | alex_xu: i think only in few tests like start stop - https://review.openstack.org/#/c/353335/5/nova/tests/unit/api/openstack/compute/test_server_start_stop.py | 01:53 |
gmann | alex_xu: for other tests we might need to change project:non_fake - > project_id:non_fake | 01:54 |
*** shaohe_feng has joined #openstack-nova | 01:54 | |
alex_xu | gmann: ah, I got it. I wrote project_id as project, that is typo mistake.... | 01:55 |
gmann | alex_xu: oh | 01:55 |
gmann | alex_xu: but m afraid that project_id will not work for all API as we do not enforce project_id at API layer we do in DB as johnthetubaguy pointed | 01:56 |
gmann | alex_xu: may be those tests will fail then | 01:56 |
alex_xu | gmann: emm....there must be a lot of copy/paste when write those patches... | 01:56 |
gmann | alex_xu: yea, true | 01:57 |
*** _diana_ has quit IRC | 01:57 | |
*** jwcroppe has joined #openstack-nova | 01:58 | |
*** jwcroppe has quit IRC | 01:58 | |
alex_xu | gmann: actually we fake the get_instance method | 01:58 |
*** jwcroppe has joined #openstack-nova | 01:58 | |
*** jamesden_ has joined #openstack-nova | 01:59 | |
gmann | alex_xu: not for all policy tests in current situation, those are passing as policy gets failed due to 'project: non_fake' string | 01:59 |
alex_xu | gmann: oops, i get your words, yes, without target, that may not works | 01:59 |
gmann | alex_xu: yes | 01:59 |
alex_xu | gmann: maybe just leave it alone, we have clear plan whether we need pass all the target in the future | 02:00 |
*** sdake has quit IRC | 02:01 | |
alex_xu | 's/we have clear plan/after we have clear plan/' | 02:01 |
gmann | alex_xu: ok, but it worth to do for those where we pass user_id and project_id at target now | 02:01 |
alex_xu | gmann: +1 | 02:01 |
gmann | alex_xu: other we can cleanup later | 02:01 |
alex_xu | gmann: yea | 02:01 |
gmann | alex_xu: ok, i will make changes with user_id patch | 02:01 |
alex_xu | gmann: cool | 02:02 |
gmann | alex_xu: Thanks :) | 02:02 |
*** ducttape_ has joined #openstack-nova | 02:02 | |
alex_xu | gmann: np, I will try to review them when the patch updated | 02:02 |
*** yamahata has quit IRC | 02:02 | |
gmann | alex_xu: Thanks. i will try to finish those by today | 02:02 |
gmann | alex_xu: ll ping you once all are ready | 02:02 |
alex_xu | gmann: yea, cool | 02:03 |
*** shaohe_feng has quit IRC | 02:04 | |
*** jamesden_ has quit IRC | 02:04 | |
*** shaohe_feng has joined #openstack-nova | 02:04 | |
mriedem | armax: if it makes you feel any better about us breaking neutron + LB in the gate today with the os-vif change, we also pulled that into our preprod cloud tonight and completely blew it up too :) | 02:05 |
*** ducttape_ has quit IRC | 02:06 | |
*** yamahata has joined #openstack-nova | 02:07 | |
*** hoangcx has quit IRC | 02:07 | |
*** ivase has joined #openstack-nova | 02:08 | |
alex_xu | mriedem: is it possiable we implement fallback for those help method https://github.com/openstack/python-novaclient/blob/master/novaclient/utils.py#L277 if this is single point which is used by CLI to access proxy api.... | 02:08 |
mriedem | alex_xu: yes, sdague and i have been working on that all day https://review.openstack.org/#/c/354349/ | 02:09 |
alex_xu | mriedem: if we are going to the way get rid of all the proxy API call in the CLI, that sounds like we can't finish this in newton | 02:09 |
mriedem | i'm working on cleaning up the unit tests right noww | 02:09 |
alex_xu | mriedem:cool! | 02:09 |
mriedem | alex_xu: right now it's looking like image and network, and just the proxy for GET on name translation | 02:09 |
mriedem | i.e. image name / net name given, we look up the resource to get the id to pass to the REST API | 02:10 |
*** ivase has quit IRC | 02:10 | |
mriedem | we require volume IDs so no cinder proxying | 02:10 |
*** ivase has joined #openstack-nova | 02:10 | |
mriedem | the network thing is going to be a bit different since it's going to be conditional on the 2.36 microversion | 02:10 |
mriedem | for < 2.36 we call the nova proxy api | 02:10 |
mriedem | >= 2.36 we call neutron | 02:10 |
mriedem | but sdague and i haven't gotten deep into the details of that yet, need to get the image stuff working first | 02:11 |
alex_xu | mriedem: got it, so the plan is call the neutron API directly? | 02:11 |
mriedem | yeah | 02:12 |
*** sdake has joined #openstack-nova | 02:13 | |
*** jamesdenton has joined #openstack-nova | 02:13 | |
*** shaohe_feng has quit IRC | 02:14 | |
alex_xu | mriedem: ok, got it, not sure how complex of that, anyway I will read that patch and think about it more. | 02:14 |
*** Apoorva_ has joined #openstack-nova | 02:14 | |
*** shaohe_feng has joined #openstack-nova | 02:15 | |
*** Apoorva_ has quit IRC | 02:15 | |
*** raunak has quit IRC | 02:15 | |
mriedem | ok, i hope to have unit tests passing before i go to bed, | 02:16 |
mriedem | i'll push up whatever WIP i have before then anyway | 02:16 |
*** gongysh has joined #openstack-nova | 02:17 | |
*** gyee has quit IRC | 02:17 | |
*** Apoorva has quit IRC | 02:17 | |
*** woodster_ has quit IRC | 02:19 | |
armax | mriedem: not quite, it’s good to know we’re not the only ones experiencing grief :) | 02:20 |
*** ljxiash_ has joined #openstack-nova | 02:21 | |
mriedem | the fix is top of gate queue at least | 02:22 |
*** shaohe_feng has quit IRC | 02:24 | |
*** shaohe_feng has joined #openstack-nova | 02:25 | |
*** zerda2 has joined #openstack-nova | 02:28 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for force_delete server https://review.openstack.org/354485 | 02:29 |
*** bswartz has quit IRC | 02:33 | |
*** shaohe_feng has quit IRC | 02:34 | |
*** sdake has quit IRC | 02:34 | |
*** shaohe_feng has joined #openstack-nova | 02:35 | |
*** bswartz has joined #openstack-nova | 02:37 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Add tests for user_id policy enforcement on stop https://review.openstack.org/353335 | 02:37 |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Don't pass argument sqlite_db in method set_defaults https://review.openstack.org/350947 | 02:39 |
*** EinstCrazy has quit IRC | 02:39 | |
*** hoangcx has joined #openstack-nova | 02:40 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Add tests for user_id policy enforcement on stop https://review.openstack.org/353335 | 02:40 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server pause action https://review.openstack.org/352221 | 02:40 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server resize action https://review.openstack.org/354478 | 02:41 |
*** EinstCrazy has joined #openstack-nova | 02:43 | |
*** shaohe_feng has quit IRC | 02:45 | |
*** shaohe_feng has joined #openstack-nova | 02:45 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server resize action https://review.openstack.org/354478 | 02:48 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for force_delete server https://review.openstack.org/354485 | 02:48 |
*** ayoung has joined #openstack-nova | 02:49 | |
*** sdake has joined #openstack-nova | 02:54 | |
*** shaohe_feng has quit IRC | 02:55 | |
*** betherly has quit IRC | 02:55 | |
*** zhiyan has quit IRC | 02:55 | |
*** johnsom has quit IRC | 02:55 | |
*** tdurakov has quit IRC | 02:56 | |
*** ameade has quit IRC | 02:56 | |
*** shaohe_feng has joined #openstack-nova | 02:56 | |
*** ijw has quit IRC | 02:59 | |
*** betherly has joined #openstack-nova | 02:59 | |
*** johnsom has joined #openstack-nova | 03:00 | |
*** tdurakov has joined #openstack-nova | 03:00 | |
*** amotoki has joined #openstack-nova | 03:02 | |
*** ducttape_ has joined #openstack-nova | 03:03 | |
*** hoangcx has quit IRC | 03:03 | |
*** zhiyan has joined #openstack-nova | 03:03 | |
*** ameade has joined #openstack-nova | 03:03 | |
*** diogogmt has quit IRC | 03:05 | |
*** shaohe_feng has quit IRC | 03:05 | |
*** shaohe_feng has joined #openstack-nova | 03:06 | |
*** sudipto has joined #openstack-nova | 03:06 | |
*** sudipto_ has joined #openstack-nova | 03:06 | |
*** ducttape_ has quit IRC | 03:07 | |
*** amotoki has quit IRC | 03:11 | |
openstackgerrit | John Hua proposed openstack/nova: Use physical utilisation for cached images https://review.openstack.org/353862 | 03:13 |
*** raunak has joined #openstack-nova | 03:13 | |
*** yamahata has quit IRC | 03:14 | |
*** shaohe_feng has quit IRC | 03:15 | |
*** shaohe_feng has joined #openstack-nova | 03:16 | |
*** amotoki has joined #openstack-nova | 03:22 | |
*** sdake has quit IRC | 03:24 | |
*** shaohe_feng has quit IRC | 03:26 | |
*** shaohe_feng has joined #openstack-nova | 03:26 | |
*** EinstCra_ has joined #openstack-nova | 03:29 | |
*** amotoki has quit IRC | 03:31 | |
*** EinstCrazy has quit IRC | 03:32 | |
*** links has joined #openstack-nova | 03:33 | |
*** gouthamr has quit IRC | 03:35 | |
*** amotoki has joined #openstack-nova | 03:35 | |
*** shaohe_feng has quit IRC | 03:36 | |
*** shaohe_feng has joined #openstack-nova | 03:36 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server shelve action https://review.openstack.org/354499 | 03:37 |
*** baoli has quit IRC | 03:43 | |
*** sudipto_ has quit IRC | 03:43 | |
*** sudipto has quit IRC | 03:43 | |
*** ayoung has quit IRC | 03:45 | |
*** shaohe_feng has quit IRC | 03:46 | |
*** shaohe_feng has joined #openstack-nova | 03:47 | |
openstackgerrit | Patrick East proposed openstack/nova: Add release note to warn about os-brick lock dir https://review.openstack.org/354502 | 03:47 |
*** raunak has quit IRC | 03:47 | |
*** liverpooler has quit IRC | 03:49 | |
*** raunak has joined #openstack-nova | 03:49 | |
*** hoangcx has joined #openstack-nova | 03:51 | |
*** sdake has joined #openstack-nova | 03:54 | |
*** shaohe_feng has quit IRC | 03:56 | |
*** shaohe_feng has joined #openstack-nova | 03:57 | |
*** hoangcx has quit IRC | 03:57 | |
*** amotoki has quit IRC | 04:01 | |
*** ducttape_ has joined #openstack-nova | 04:03 | |
*** vishwanathj has quit IRC | 04:06 | |
*** shaohe_feng has quit IRC | 04:07 | |
*** shaohe_feng has joined #openstack-nova | 04:07 | |
*** ducttape_ has quit IRC | 04:08 | |
*** rkmrhj has joined #openstack-nova | 04:09 | |
*** Sukhdev has joined #openstack-nova | 04:09 | |
*** dikonoor has joined #openstack-nova | 04:09 | |
*** amotoki has joined #openstack-nova | 04:09 | |
*** amotoki has quit IRC | 04:10 | |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient: Look up image names directly in glance https://review.openstack.org/354349 | 04:11 |
mriedem | omfg yes ^ | 04:11 |
*** amotoki has joined #openstack-nova | 04:11 | |
*** tonytan4ever has joined #openstack-nova | 04:12 | |
*** fragatina has quit IRC | 04:16 | |
*** mingyu has joined #openstack-nova | 04:16 | |
*** tonytan4ever has quit IRC | 04:17 | |
*** shaohe_feng has quit IRC | 04:17 | |
*** shaohe_feng has joined #openstack-nova | 04:17 | |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient: Look up image names directly in glance https://review.openstack.org/354349 | 04:19 |
*** ljxiash_ has quit IRC | 04:22 | |
prometheanfire | oh god | 04:22 |
prometheanfire | please | 04:22 |
prometheanfire | do that one | 04:22 |
mriedem | ha | 04:23 |
mriedem | prometheanfire: now you're reminding me of the neutronclient 5.1.0 issue | 04:23 |
prometheanfire | mriedem: :( | 04:24 |
prometheanfire | :P | 04:24 |
*** vishwanathj has joined #openstack-nova | 04:26 | |
*** vishwanathj has quit IRC | 04:26 | |
*** gongysh has quit IRC | 04:26 | |
*** mingyu has quit IRC | 04:26 | |
*** shaohe_feng has quit IRC | 04:27 | |
mriedem | do you have a link to that again? | 04:27 |
mriedem | nvm https://review.openstack.org/#/c/353443/ | 04:27 |
*** shaohe_feng has joined #openstack-nova | 04:28 | |
mriedem | well, i don't know where the test results were | 04:29 |
mriedem | is it a separate patch? | 04:29 |
mriedem | oh nvm | 04:29 |
mriedem | http://logs.openstack.org/43/353443/2/check/gate-cross-nova-python27-db-ubuntu-xenial/2b8780d/ | 04:29 |
mriedem | this is what broke it https://review.openstack.org/#/c/348096/ | 04:32 |
*** code-R_ has joined #openstack-nova | 04:32 | |
prometheanfire | sorry, distracted | 04:32 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Add tests for user_id policy enforcement on trigger_crash_dump https://review.openstack.org/354510 | 04:32 |
prometheanfire | playing no mans sky :P | 04:32 |
*** jamesdenton has quit IRC | 04:33 | |
*** code-R_ has quit IRC | 04:34 | |
*** code-R_ has joined #openstack-nova | 04:35 | |
*** code-R has quit IRC | 04:35 | |
*** gongysh has joined #openstack-nova | 04:36 | |
*** shaohe_feng has quit IRC | 04:37 | |
*** hshiina has joined #openstack-nova | 04:37 | |
*** shaohe_feng has joined #openstack-nova | 04:38 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/354459 | 04:38 |
*** takedakn has joined #openstack-nova | 04:39 | |
*** sudipto has joined #openstack-nova | 04:43 | |
*** sudipto_ has joined #openstack-nova | 04:43 | |
*** takedakn has quit IRC | 04:43 | |
*** ratailor has joined #openstack-nova | 04:45 | |
*** sudipto_ has quit IRC | 04:46 | |
*** sudipto has quit IRC | 04:46 | |
*** shaohe_feng has quit IRC | 04:48 | |
*** shaohe_feng has joined #openstack-nova | 04:48 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/354459 | 04:53 |
*** Sukhdev has quit IRC | 04:54 | |
*** shaohe_feng has quit IRC | 04:58 | |
*** shaohe_feng has joined #openstack-nova | 04:58 | |
*** fragatina has joined #openstack-nova | 04:58 | |
*** fragatina has quit IRC | 05:03 | |
*** hoangcx has joined #openstack-nova | 05:03 | |
*** jaosorior has joined #openstack-nova | 05:04 | |
*** hoangcx has quit IRC | 05:06 | |
*** shaohe_feng has quit IRC | 05:08 | |
*** prateek_ has joined #openstack-nova | 05:10 | |
*** ivase has quit IRC | 05:10 | |
*** ivase has joined #openstack-nova | 05:10 | |
*** prateek_ has quit IRC | 05:11 | |
*** shaohe_feng has joined #openstack-nova | 05:11 | |
*** prateek has joined #openstack-nova | 05:11 | |
*** jwcroppe has quit IRC | 05:11 | |
*** jwcroppe has joined #openstack-nova | 05:12 | |
rkmrhj | macsz: Sorry for late at night. Have you recheck my bug report(#1587285) that I heard yesterday? | 05:13 |
*** mriedem has quit IRC | 05:14 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Log warning when user set improper config option value https://review.openstack.org/354532 | 05:15 |
macsz | rkmrhj: oh sorry, I forgot :( adding reminder for tomorrow. Sorry! :( | 05:15 |
*** chandankumar has joined #openstack-nova | 05:16 | |
*** jwcroppe has quit IRC | 05:16 | |
*** shaohe_feng has quit IRC | 05:18 | |
*** shaohe_feng has joined #openstack-nova | 05:19 | |
*** shaohe_feng has quit IRC | 05:29 | |
*** vishwanathj has joined #openstack-nova | 05:29 | |
*** shaohe_feng has joined #openstack-nova | 05:29 | |
*** vishwanathj has quit IRC | 05:29 | |
*** sdake has quit IRC | 05:32 | |
*** raunak has quit IRC | 05:33 | |
*** coolsvap has joined #openstack-nova | 05:34 | |
*** unicell has joined #openstack-nova | 05:35 | |
rkmrhj | macsz: Thanks a lot. If you can't recheck, please inherit rechecking to next bug skimming duty member. | 05:37 |
*** shaohe_feng has quit IRC | 05:39 | |
*** shaohe_feng has joined #openstack-nova | 05:39 | |
*** amotoki_ has joined #openstack-nova | 05:40 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server changePassword action https://review.openstack.org/354537 | 05:40 |
*** pbandark has joined #openstack-nova | 05:41 | |
*** amotoki has quit IRC | 05:43 | |
*** rama_y has joined #openstack-nova | 05:44 | |
*** nkrinner_afk is now known as nkrinner | 05:45 | |
*** unicell has quit IRC | 05:49 | |
*** unicell has joined #openstack-nova | 05:49 | |
*** shaohe_feng has quit IRC | 05:49 | |
openstackgerrit | Rajesh Tailor proposed openstack/nova: Fix race for compute node create record, on compute-start https://review.openstack.org/304415 | 05:49 |
*** unicell has quit IRC | 05:50 | |
*** shaohe_feng has joined #openstack-nova | 05:50 | |
*** unicell has joined #openstack-nova | 05:50 | |
*** rcernin has quit IRC | 05:51 | |
*** code-R has joined #openstack-nova | 05:53 | |
*** code-R_ has quit IRC | 05:56 | |
*** shaohe_feng has quit IRC | 05:59 | |
*** ivase_ has joined #openstack-nova | 06:00 | |
*** shaohe_feng has joined #openstack-nova | 06:00 | |
*** ivase has quit IRC | 06:02 | |
*** coreywright has quit IRC | 06:02 | |
*** esracelik has joined #openstack-nova | 06:02 | |
*** esracelik is now known as ecelik | 06:02 | |
*** armax has quit IRC | 06:05 | |
*** ducttape_ has joined #openstack-nova | 06:05 | |
*** shaohe_feng has quit IRC | 06:10 | |
*** ducttape_ has quit IRC | 06:10 | |
*** shaohe_feng has joined #openstack-nova | 06:10 | |
*** code-R has quit IRC | 06:11 | |
*** code-R has joined #openstack-nova | 06:11 | |
*** shaohe_feng has quit IRC | 06:20 | |
*** shaohe_feng has joined #openstack-nova | 06:21 | |
*** rcernin has joined #openstack-nova | 06:21 | |
*** oomichi has joined #openstack-nova | 06:30 | |
*** shaohe_feng has quit IRC | 06:30 | |
*** shaohe_feng has joined #openstack-nova | 06:31 | |
*** ljxiash has joined #openstack-nova | 06:31 | |
*** code-R_ has joined #openstack-nova | 06:34 | |
*** code-R has quit IRC | 06:34 | |
*** shaohe_feng has quit IRC | 06:40 | |
*** nkrinner has quit IRC | 06:41 | |
*** shaohe_feng has joined #openstack-nova | 06:41 | |
*** nkrinner has joined #openstack-nova | 06:42 | |
*** nkrinner has quit IRC | 06:42 | |
*** nkrinner has joined #openstack-nova | 06:42 | |
*** coreywright has joined #openstack-nova | 06:43 | |
*** diga_ has joined #openstack-nova | 06:44 | |
*** ljxiash_ has joined #openstack-nova | 06:44 | |
*** ivase_ has quit IRC | 06:45 | |
*** ivase has joined #openstack-nova | 06:45 | |
*** ljxiash has quit IRC | 06:46 | |
*** zhangjn has quit IRC | 06:48 | |
*** zhangjn has joined #openstack-nova | 06:49 | |
*** nkrinner is now known as nkrinner_afk | 06:49 | |
*** ecelik has quit IRC | 06:50 | |
*** shaohe_feng has quit IRC | 06:51 | |
*** shaohe_feng has joined #openstack-nova | 06:51 | |
*** kevinz has joined #openstack-nova | 06:54 | |
*** GB21 has joined #openstack-nova | 06:58 | |
*** tesseract- has joined #openstack-nova | 06:59 | |
*** shaohe_feng has quit IRC | 07:01 | |
*** shaohe_feng has joined #openstack-nova | 07:01 | |
*** ljxiash_ has quit IRC | 07:02 | |
*** esracelik has joined #openstack-nova | 07:03 | |
*** ljxiash_ has joined #openstack-nova | 07:04 | |
*** ducttape_ has joined #openstack-nova | 07:06 | |
*** esracelik is now known as ecelik | 07:06 | |
*** daemontool has joined #openstack-nova | 07:06 | |
openstackgerrit | John Hua proposed openstack/nova: Use physical utilisation for cached images https://review.openstack.org/353862 | 07:06 |
*** oanson has joined #openstack-nova | 07:07 | |
*** mingyu has joined #openstack-nova | 07:08 | |
*** ljxiash_ has quit IRC | 07:08 | |
*** shaohe_feng has quit IRC | 07:11 | |
*** shaohe_feng has joined #openstack-nova | 07:11 | |
*** ducttape_ has quit IRC | 07:11 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server delete https://review.openstack.org/354555 | 07:13 |
*** oomichi has quit IRC | 07:14 | |
*** rkrum has quit IRC | 07:16 | |
openstackgerrit | xhzhf proposed openstack/nova: [sr-iov] pci passthrough whitelist doesn't support mult node https://review.openstack.org/354557 | 07:17 |
*** yamahata has joined #openstack-nova | 07:19 | |
*** shaohe_feng has quit IRC | 07:21 | |
*** GB21 has quit IRC | 07:22 | |
*** mingyu has quit IRC | 07:22 | |
*** shaohe_feng has joined #openstack-nova | 07:22 | |
*** markus_z has joined #openstack-nova | 07:24 | |
*** sridharg has joined #openstack-nova | 07:24 | |
*** ljxiash has joined #openstack-nova | 07:27 | |
*** RuiChen has joined #openstack-nova | 07:28 | |
*** nkrinner_afk is now known as nkrinner | 07:30 | |
*** shaohe_feng has quit IRC | 07:32 | |
*** f10d4 has quit IRC | 07:33 | |
*** markvoelker has quit IRC | 07:34 | |
*** shaohe_feng has joined #openstack-nova | 07:34 | |
*** jichen has joined #openstack-nova | 07:36 | |
*** ljxiash has quit IRC | 07:37 | |
*** jamielennox|away has quit IRC | 07:38 | |
*** shaohe_feng has quit IRC | 07:42 | |
*** shaohe_feng has joined #openstack-nova | 07:43 | |
*** f10d4 has joined #openstack-nova | 07:46 | |
openstackgerrit | xhzhf proposed openstack/nova: [vncproxy] log for closing web is misleading https://review.openstack.org/353807 | 07:46 |
openstackgerrit | xhzhf proposed openstack/nova: [sr-iov] pci passthrough whitelist doesn't support multi node https://review.openstack.org/354557 | 07:47 |
*** jamielennox|away has joined #openstack-nova | 07:47 | |
*** jamielennox|away is now known as jamielennox | 07:48 | |
*** shaohe_feng has quit IRC | 07:52 | |
*** shaohe_feng has joined #openstack-nova | 07:52 | |
*** yamahata has quit IRC | 07:55 | |
*** tonytan4ever has joined #openstack-nova | 07:59 | |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-nova | 08:01 | |
*** shaohe_feng has quit IRC | 08:02 | |
*** shaohe_feng has joined #openstack-nova | 08:03 | |
*** tonytan4ever has quit IRC | 08:03 | |
openstackgerrit | John Hua proposed openstack/nova: Use physical utilisation for cached images https://review.openstack.org/353862 | 08:06 |
*** matrohon has joined #openstack-nova | 08:07 | |
*** ducttape_ has joined #openstack-nova | 08:08 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/303345 | 08:10 |
openstackgerrit | John Garbutt proposed openstack/nova: Verified deprecation status for vnc options https://review.openstack.org/353666 | 08:11 |
*** ducttape_ has quit IRC | 08:12 | |
*** shaohe_feng has quit IRC | 08:13 | |
*** code-R_ has quit IRC | 08:13 | |
*** shaohe_feng has joined #openstack-nova | 08:13 | |
*** lucas-dinner is now known as lucasagomes | 08:15 | |
johnthetubaguy | alex_xu: gmann: just looking at the policy stuff | 08:15 |
johnthetubaguy | I think we can loop back on that servers one later | 08:15 |
*** ljxiash has joined #openstack-nova | 08:16 | |
gmann | johnthetubaguy: did not get | 08:16 |
johnthetubaguy | gmann: I was really meaning, lets just merge the current version of your patch: https://review.openstack.org/#/c/353335/7 | 08:17 |
johnthetubaguy | I was talking a bit to sdague yesterday about that one | 08:17 |
johnthetubaguy | lets come back later and fix up the other policy stuff in there, so it only passes the project_id | 08:17 |
johnthetubaguy | gmann: does that make more sense? | 08:18 |
alex_xu | johnthetubaguy: got it, +1 | 08:18 |
gmann | johnthetubaguy: ah, you mean fix for project_id one | 08:18 |
alex_xu | gmann: I guess johnthetubaguy pointed to my comment? | 08:19 |
johnthetubaguy | yeah, there are quite a few non-standard policy checks in that file, lets worry about that as follow up bug fixes | 08:19 |
johnthetubaguy | alex_xu: yeah, I think I had similar comments on an earlier patchset that sdague put up | 08:19 |
gmann | johnthetubaguy: alex_xu i see. | 08:20 |
*** rmart04 has joined #openstack-nova | 08:20 | |
alex_xu | johnthetubaguy: gmann just +w :) | 08:20 |
gmann | johnthetubaguy: alex_xu yea we can cleanup those later. | 08:20 |
johnthetubaguy | the deadline is looking real soon, is the summary | 08:20 |
alex_xu | johnthetubaguy: question about https://review.openstack.org/#/c/353666/3/nova/conf/vnc.py, those 'deprecated_group' already be there one release, should we remove them? | 08:20 |
gmann | johnthetubaguy: alex_xu anyways i will last patch to remove user_id from start server which will remove those | 08:21 |
*** danpb has joined #openstack-nova | 08:21 | |
alex_xu | gmann: cool, thanks | 08:21 |
johnthetubaguy | alex_xu: basically, trying to do the minimum change at this point | 08:21 |
johnthetubaguy | alex_xu: I hoped we would have a tool out this cycle to help admins detect when they use deprecated names and groups, so its easier to fix up their config | 08:21 |
*** GB21 has joined #openstack-nova | 08:21 | |
*** oanson has quit IRC | 08:21 | |
johnthetubaguy | alex_xu: its super cheap to leave them there till we get that tool sorted | 08:22 |
gmann | johnthetubaguy: alex_xu i left with update and evacuate one, ll post soon | 08:22 |
johnthetubaguy | alex_xu: turns out oslo can do multiple alias names now, anyways | 08:22 |
*** ljxiash has quit IRC | 08:22 | |
*** shaohe_feng has quit IRC | 08:23 | |
*** shaohe_feng has joined #openstack-nova | 08:23 | |
alex_xu | johnthetubaguy: ok, got it, the patch title is a little confuse. should we keep the 'needs:check_deprecation_status 'flag'? | 08:24 |
johnthetubaguy | alex_xu: the plan is to drop all those tags by the end of the cycle | 08:25 |
johnthetubaguy | alex_xu: mostly its about spotting unused or still things, and adding a TODO to deprecate it next cycle | 08:25 |
alex_xu | johnthetubaguy: ok, cool, so just follow the plan :) | 08:25 |
*** sameo has joined #openstack-nova | 08:26 | |
johnthetubaguy | alex_xu: yeah, changed the plan to reduce the review load, since its this late in the cycle | 08:26 |
*** carl_baldwin_ has joined #openstack-nova | 08:31 | |
*** shaohe_feng has quit IRC | 08:33 | |
*** shaohe_feng has joined #openstack-nova | 08:34 | |
*** markvoelker has joined #openstack-nova | 08:34 | |
*** carl_baldwin has quit IRC | 08:35 | |
*** carl_baldwin_ is now known as carl_baldwin | 08:35 | |
*** oanson has joined #openstack-nova | 08:36 | |
*** markvoelker has quit IRC | 08:39 | |
*** cdent has joined #openstack-nova | 08:39 | |
*** ljxiash has joined #openstack-nova | 08:40 | |
*** shaohe_feng has quit IRC | 08:43 | |
Dinesh_Bhor | Hi all, is there a documentation on how to configure SSL with nova ? If anyone is having , please share. | 08:44 |
*** shaohe_feng has joined #openstack-nova | 08:44 | |
johnthetubaguy | Dinesh_Bhor: please ask on #openstack for operator questsions, see channel topic | 08:45 |
johnthetubaguy | Dinesh_Bhor: having said that, I think you want this doc: http://docs.openstack.org/security-guide/api-endpoints.html | 08:46 |
*** ihrachys has joined #openstack-nova | 08:47 | |
Dinesh_Bhor | johnthetubaguy: ok, Thank you. | 08:48 |
*** shaohe_feng has quit IRC | 08:54 | |
*** ljxiash has quit IRC | 08:54 | |
*** mnestratov|3 has joined #openstack-nova | 08:54 | |
*** shaohe_feng has joined #openstack-nova | 08:54 | |
johnthetubaguy | gmann: not sure about the unit tests in this one: https://review.openstack.org/#/c/354537/1 | 08:54 |
*** mnestratov|3 has quit IRC | 08:54 | |
*** ljxiash has joined #openstack-nova | 08:54 | |
*** gszasz has joined #openstack-nova | 08:54 | |
*** hshiina has quit IRC | 08:55 | |
gmann | johnthetubaguy: actually i have to use separate req as same project_id is being passed in get_instance stub if we use self.req | 08:57 |
gmann | johnthetubaguy: i want to override the project_id in req and diff than instance | 08:57 |
gmann | johnthetubaguy: I did that to avoid mock.patch.object in each tests and do stub in setUp | 08:58 |
*** ljxiash has quit IRC | 08:59 | |
johnthetubaguy | gmann: can't you just update self.req just before passing that into the next method? | 08:59 |
johnthetubaguy | i.e. I think line190 just goes to self.req | 09:00 |
gmann | johnthetubaguy: i can but sme updated one will be passed to stub method and fake instance get created with that | 09:00 |
johnthetubaguy | gmann: but that has already executed before your test has started | 09:00 |
johnthetubaguy | (using the old value) | 09:00 |
*** code-R has joined #openstack-nova | 09:01 | |
johnthetubaguy | hmm, its a bit nasty either way I guess | 09:01 |
gmann | johnthetubaguy: but that callable function is stubbed | 09:01 |
johnthetubaguy | gmann: oh... I see what you mean | 09:01 |
*** cdent has quit IRC | 09:02 | |
johnthetubaguy | gmann: OK, cools, seems the simplest way to do, miss read that execution order | 09:02 |
gmann | johnthetubaguy: yea, we have lot of hoch poch in unit test actually :) | 09:02 |
gmann | trying to do minimum changes | 09:03 |
johnthetubaguy | yeah, agreed | 09:03 |
johnthetubaguy | we should do something to help this policy stuff as a follow up | 09:03 |
* johnthetubaguy has to run off for a little bit | 09:03 | |
*** shaohe_feng has quit IRC | 09:04 | |
*** shaohe_feng has joined #openstack-nova | 09:05 | |
*** code-R has quit IRC | 09:05 | |
openstackgerrit | Gleb Stepanov proposed openstack/nova: [WIP] Init allocated ports set https://review.openstack.org/347479 | 09:06 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server changePassword action https://review.openstack.org/354537 | 09:07 |
*** ducttape_ has joined #openstack-nova | 09:09 | |
*** aloga has quit IRC | 09:10 | |
*** aloga has joined #openstack-nova | 09:11 | |
openstackgerrit | Gleb Stepanov proposed openstack/nova: Refactor aggregate image properties https://review.openstack.org/353568 | 09:11 |
*** ducttape_ has quit IRC | 09:13 | |
*** shaohe_feng has quit IRC | 09:14 | |
*** shaohe_feng has joined #openstack-nova | 09:15 | |
*** cdent has joined #openstack-nova | 09:17 | |
*** amotoki has joined #openstack-nova | 09:20 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server update https://review.openstack.org/354610 | 09:23 |
*** amotoki_ has quit IRC | 09:23 | |
gmann | johnthetubaguy: in this update one, i have to do lot of updates in existing tests for project_id, user_id in stub instance - https://review.openstack.org/354610 | 09:24 |
*** shaohe_feng has quit IRC | 09:24 | |
openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: Ensure that periodic reclaim cleans DB deleted instances https://review.openstack.org/323250 | 09:25 |
*** shaohe_feng has joined #openstack-nova | 09:25 | |
markus_z | tdurakov: Got a minute? My live_migration_serial_console test gets executed due to the hook (so far so good) but it fails and would like to see the logs but don't find them. | 09:25 |
markus_z | tdurakov: The "console.log" says the "n-sproxy.log" is available: http://logs.openstack.org/71/347471/14/check/gate-tempest-dsvm-multinode-live-migration/fc74b36/console.html#_2016-08-11_15_15_53_913763 | 09:27 |
markus_z | but I don't find them in the test run | 09:28 |
markus_z | http://logs.openstack.org/71/347471/14/check/gate-tempest-dsvm-multinode-live-migration/fc74b36/ | 09:28 |
tdurakov | markus_z: hi, let me check | 09:29 |
tdurakov | I meAn | 09:29 |
tdurakov | s/ I mean 2 minutes | 09:29 |
*** shaohe_feng has quit IRC | 09:35 | |
*** shaohe_feng has joined #openstack-nova | 09:36 | |
*** markvoelker has joined #openstack-nova | 09:36 | |
*** rama_y has quit IRC | 09:37 | |
openstackgerrit | Rajesh Tailor proposed openstack/nova: Fix race for compute node create record, on compute-start https://review.openstack.org/304415 | 09:37 |
*** markvoelker has quit IRC | 09:40 | |
*** amotoki_ has joined #openstack-nova | 09:41 | |
openstackgerrit | xhzhf proposed openstack/nova: [network] nova with neutron can not inject ip address to vm https://review.openstack.org/354616 | 09:42 |
openstackgerrit | Rikimaru Honjo proposed openstack/nova: Add checks for preventing unexpected detaching volume https://review.openstack.org/354617 | 09:42 |
*** andrey-mp has joined #openstack-nova | 09:42 | |
*** amotoki has quit IRC | 09:44 | |
*** ivase has quit IRC | 09:45 | |
*** shaohe_feng has quit IRC | 09:45 | |
*** shaohe_feng has joined #openstack-nova | 09:45 | |
*** ivase has joined #openstack-nova | 09:45 | |
*** sdague has joined #openstack-nova | 09:46 | |
*** matrohon has quit IRC | 09:48 | |
andrey-mp | hi, can anyone check this patchset - https://review.openstack.org/#/c/352455/2 This reverts quota's behaviour in nova... | 09:48 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/354459 | 09:49 |
*** lpetrut has joined #openstack-nova | 09:50 | |
*** code-R has joined #openstack-nova | 09:55 | |
*** shaohe_feng has quit IRC | 09:55 | |
*** shaohe_feng has joined #openstack-nova | 09:56 | |
*** TRUMP-PENCE has joined #openstack-nova | 09:58 | |
*** code-R has quit IRC | 10:00 | |
tdurakov | markus_z: the thing is that hook actually failed | 10:01 |
tdurakov | I'll left comment | 10:01 |
tdurakov | markus_z: done | 10:04 |
*** EinstCra_ has quit IRC | 10:05 | |
*** shaohe_feng has quit IRC | 10:05 | |
*** shaohe_feng has joined #openstack-nova | 10:06 | |
*** gongysh has quit IRC | 10:08 | |
*** mnestratov has quit IRC | 10:09 | |
*** ducttape_ has joined #openstack-nova | 10:09 | |
*** lpetrut1 has joined #openstack-nova | 10:09 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/303345 | 10:10 |
*** mnestratov has joined #openstack-nova | 10:10 | |
*** lpetrut has quit IRC | 10:11 | |
*** lpetrut1 is now known as lpetrut | 10:11 | |
*** rkmrhj has left #openstack-nova | 10:12 | |
*** coolsvap is now known as _coolsvap_ | 10:13 | |
*** ducttape_ has quit IRC | 10:14 | |
*** mvk has quit IRC | 10:14 | |
*** mvk has joined #openstack-nova | 10:14 | |
*** amotoki_ has quit IRC | 10:15 | |
*** shaohe_feng has quit IRC | 10:16 | |
openstackgerrit | Prateek Arora proposed openstack/nova: Handle ConnectFailure from keystone when neutron is down https://review.openstack.org/327706 | 10:16 |
*** shaohe_feng has joined #openstack-nova | 10:17 | |
*** Rodrigo_BR has quit IRC | 10:23 | |
*** shaohe_feng has quit IRC | 10:26 | |
*** shaohe_feng has joined #openstack-nova | 10:27 | |
*** amotoki has joined #openstack-nova | 10:27 | |
markus_z | tdurakov: The "console.log" says it executed the tempest tests. All of them because I didn't specify the regex to limit the amount of tests. | 10:29 |
markus_z | tdurakov: IOW, I think I can use "run_tempest" without an regex. | 10:30 |
markus_z | tdurakov: Therefore I don't understand what you mean with "the hook failed" | 10:30 |
hieulq | johnthetubaguy: markus_z can you take a look at this patch https://review.openstack.org/#/c/316550/ | 10:30 |
openstackgerrit | Sean Dague proposed openstack/python-novaclient: Make novaclient functional tests use pretty tox https://review.openstack.org/354638 | 10:34 |
markus_z | hieulq: yep, will do that today | 10:34 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server delete https://review.openstack.org/354555 | 10:35 |
*** shaohe_feng has quit IRC | 10:36 | |
*** shaohe_feng has joined #openstack-nova | 10:37 | |
*** wangqun has quit IRC | 10:39 | |
*** daemontool has quit IRC | 10:39 | |
hieulq | markus_z: thanks | 10:40 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server delete https://review.openstack.org/354555 | 10:40 |
*** daemontool has joined #openstack-nova | 10:41 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server update https://review.openstack.org/354610 | 10:41 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server update https://review.openstack.org/354610 | 10:41 |
*** shaohe_feng has quit IRC | 10:46 | |
*** daemontool_ has joined #openstack-nova | 10:47 | |
*** shaohe_feng has joined #openstack-nova | 10:47 | |
*** daemontool has quit IRC | 10:47 | |
*** ivase has quit IRC | 10:48 | |
gmann | johnthetubaguy: sdague alex_xu : we want to enforce user_id on evacuate also right? as this is already admin only | 10:49 |
*** code-R has joined #openstack-nova | 10:49 | |
sdague | gmann: yes, it's on the list | 10:49 |
gmann | sdague: ok | 10:49 |
sdague | gmann: remember, this only takes effect if people are changing their policy file | 10:49 |
sdague | so it being admin only in policy doesn't mean anything | 10:49 |
gmann | sdague: but it need admin password also for evacuation | 10:50 |
sdague | gmann: link? | 10:50 |
gmann | sdague: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/evacuate.py#L51 | 10:51 |
gmann | sdague: ah, if no admin password then we generate one and proceed | 10:51 |
*** kragniz1 has quit IRC | 10:52 | |
sdague | right, that's setting the adminPass on the guest | 10:53 |
*** kragniz1 has joined #openstack-nova | 10:53 | |
sdague | it's not that we're checking against it | 10:53 |
*** code-R has quit IRC | 10:53 | |
gmann | sdague: yup, on new rebuilt instance | 10:53 |
gmann | sdague: make sense. doing for that.. | 10:53 |
*** shaohe_feng has quit IRC | 10:57 | |
*** shaohe_feng has joined #openstack-nova | 10:57 | |
*** kragniz1 has quit IRC | 10:59 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: live-migration test hook for serial console https://review.openstack.org/347471 | 11:04 |
*** mnestratov has quit IRC | 11:05 | |
*** JoseMello has joined #openstack-nova | 11:06 | |
*** shaohe_feng has quit IRC | 11:07 | |
*** shaohe_feng has joined #openstack-nova | 11:07 | |
*** ducttape_ has joined #openstack-nova | 11:10 | |
openstackgerrit | Chen Fan proposed openstack/nova: context: change the name 'rule' to 'action' in context.can https://review.openstack.org/347651 | 11:13 |
*** ducttape_ has quit IRC | 11:14 | |
*** kragniz1 has joined #openstack-nova | 11:15 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server evacuate https://review.openstack.org/354656 | 11:16 |
*** shaohe_feng has quit IRC | 11:17 | |
*** kragniz1 has quit IRC | 11:18 | |
*** kragniz1 has joined #openstack-nova | 11:18 | |
*** shaohe_feng has joined #openstack-nova | 11:20 | |
*** RuiChen has quit IRC | 11:25 | |
*** shaohe_feng has quit IRC | 11:27 | |
*** shaohe_feng has joined #openstack-nova | 11:28 | |
*** GB21 has quit IRC | 11:28 | |
*** jaosorior has quit IRC | 11:29 | |
*** manous has joined #openstack-nova | 11:29 | |
*** jaosorior has joined #openstack-nova | 11:30 | |
*** amotoki has quit IRC | 11:30 | |
manous | hi | 11:31 |
manous | please how can is solve this on mitaka ? http://paste.openstack.org/show/555955/ | 11:32 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Remove user_id policy enforcement from server start https://review.openstack.org/354662 | 11:32 |
*** kragniz is now known as Guest66666 | 11:36 | |
*** kragniz1 is now known as kragniz | 11:36 | |
*** markvoelker has joined #openstack-nova | 11:37 | |
*** shaohe_feng has quit IRC | 11:38 | |
*** GB21 has joined #openstack-nova | 11:38 | |
*** shaohe_feng has joined #openstack-nova | 11:38 | |
*** jistr has quit IRC | 11:39 | |
prateek | manous, can you please turn on the debug logs and then try | 11:40 |
*** f10d4 has quit IRC | 11:40 | |
*** f10d4 has joined #openstack-nova | 11:40 | |
manous | oka | 11:40 |
*** dansmith has quit IRC | 11:40 | |
prateek | manous, pastebin the glance logs after that | 11:40 |
*** StevenK has quit IRC | 11:41 | |
gmann | sdague: johnthetubaguy apart from action listed in spec we have user_id things in 3 more place | 11:41 |
*** amotoki has joined #openstack-nova | 11:41 | |
gmann | sdague: johnthetubaguy : unlock_override and instance_action-> index and show | 11:41 |
manous | glance image-list work fine | 11:41 |
*** dansmith has joined #openstack-nova | 11:41 | |
*** dansmith is now known as Guest13957 | 11:42 | |
*** markvoelker has quit IRC | 11:42 | |
tdurakov | markus_z: it looks like job just hasn't finished in time and was terminated | 11:42 |
*** StevenK has joined #openstack-nova | 11:42 | |
gmann | sdague: johnthetubaguy : https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/lock_server.py#L51 | 11:42 |
gmann | sdague: johnthetubaguy https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/instance_actions.py#L66-L76 | 11:42 |
markus_z | tdurakov: ohhh, so it didn't have the chance to collect the data? | 11:43 |
*** zerda2 has quit IRC | 11:43 | |
prateek | manous, start with the following logs, nova-api.log, nova-conductor.log and then glance logs, find the exception and paste bin them | 11:43 |
*** code-R has joined #openstack-nova | 11:43 | |
markus_z | tdurakov: I pushed a new ps which hopefully gives me more insight why things are failing. It also has the regex you suggested. | 11:43 |
tdurakov | markus_z: possible, http://logs.openstack.org/71/347471/14/check/gate-tempest-dsvm-multinode-live-migration/fc74b36/console.html#_2016-08-11_15_18_49_967318 - tests are failed, so that's the reason I think we should limit tests only live-migration | 11:44 |
*** ftersin has joined #openstack-nova | 11:44 | |
tdurakov | yeah, saw it, let's just wait for results | 11:44 |
ftersin | mdbooth: hi, are you around? | 11:45 |
markus_z | tdurakov: agreed, executing a subset should be a good trade-off between finding issues and burning CI resources. | 11:45 |
* markus_z waits patiently | 11:46 | |
*** snikitin has quit IRC | 11:47 | |
*** shaohe_feng has quit IRC | 11:48 | |
*** gouthamr has joined #openstack-nova | 11:48 | |
*** code-R has quit IRC | 11:48 | |
*** shaohe_feng has joined #openstack-nova | 11:49 | |
*** mnestratov has joined #openstack-nova | 11:56 | |
*** ratailor has quit IRC | 11:57 | |
*** tblakes has joined #openstack-nova | 11:58 | |
*** shaohe_feng has quit IRC | 11:58 | |
*** gongysh has joined #openstack-nova | 11:59 | |
*** tonytan4ever has joined #openstack-nova | 12:00 | |
*** lucasagomes is now known as lucas-hungry | 12:00 | |
*** shaohe_feng has joined #openstack-nova | 12:01 | |
*** jaypipes has joined #openstack-nova | 12:02 | |
*** tonytan4ever has quit IRC | 12:05 | |
*** diga_ has quit IRC | 12:05 | |
*** alaski is now known as lascii | 12:05 | |
jroll | /b 179 | 12:07 |
jroll | oops | 12:07 |
*** GB21 has quit IRC | 12:08 | |
*** shaohe_feng has quit IRC | 12:08 | |
*** prateek has quit IRC | 12:08 | |
*** shaohe_feng has joined #openstack-nova | 12:09 | |
*** amotoki has quit IRC | 12:10 | |
*** ducttape_ has joined #openstack-nova | 12:11 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Fix policy tests for project_id enforcement https://review.openstack.org/354690 | 12:11 |
gmann | sdague: johnthetubaguy alex_xu : all patches for policy things are up - https://review.openstack.org/#/q/project:openstack/nova+branch:master+topic:bp/user_id_based_policy_enforcement | 12:13 |
*** xyang1 has joined #openstack-nova | 12:14 | |
gmann | sdague: johnthetubaguy alex_xu : if needed we can do for these 3 place also (at least passing user_id, project_id explicitly in target)- unlock_override and instance_action-> index and show | 12:14 |
gmann | sdague: johnthetubaguy alex_xu : currently complete instance is being passed there | 12:15 |
*** ducttape_ has quit IRC | 12:15 | |
*** amotoki has joined #openstack-nova | 12:16 | |
*** ducttape_ has joined #openstack-nova | 12:16 | |
*** shaohe_feng has quit IRC | 12:19 | |
*** shaohe_feng has joined #openstack-nova | 12:19 | |
mdbooth | ftersin: Yup, I am now | 12:21 |
*** wangqun has joined #openstack-nova | 12:21 | |
johnthetubaguy | gmann: will take a peak at the updated series right now | 12:23 |
johnthetubaguy | gmann: for stuff that passes the instance as a target, the fix should be only passing the project_id, I believe | 12:23 |
gmann | johnthetubaguy: not user_id also? | 12:24 |
*** jistr has joined #openstack-nova | 12:24 | |
ftersin | mdbooth: thank you for review of https://review.openstack.org/#/c/334609 | 12:24 |
johnthetubaguy | gmann: nope, we are only adding user_id in that very small minimal list of places, it shouldn't be anywhere else | 12:24 |
ftersin | mdbooth: could you also take a look at other pathes in the series? | 12:25 |
johnthetubaguy | gmann: thats why I didn't want us to use the helper function | 12:25 |
gmann | johnthetubaguy: ok | 12:25 |
ftersin | mdbooth: and probably you should look at the 3rd version of this patch, because it changes some your recent code | 12:25 |
mdbooth | ftersin: I took a brief look at the other 2. There was nothing which scared me :) | 12:26 |
* mdbooth will look closer. | 12:26 | |
*** jwcroppe has joined #openstack-nova | 12:26 | |
ftersin | mdbooth: you commented the 2nd version, but in the 3rd version i merged my code with your changes of disk_info in tests | 12:28 |
*** nolwenn has joined #openstack-nova | 12:29 | |
mdbooth | ftersin: Ah, fix for volume-backed? | 12:29 |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: Update binding:profile for SR-IOV ports on resize-revert https://review.openstack.org/347444 | 12:29 |
*** shaohe_feng has quit IRC | 12:29 | |
mdbooth | Sorry, I thought you were talking about the third patch in the series | 12:29 |
*** ivase has joined #openstack-nova | 12:29 | |
*** amotoki has quit IRC | 12:29 | |
*** shaohe_feng has joined #openstack-nova | 12:30 | |
ftersin | mdbooth: the 3rd patch is interesting also. it completely reverts some old code. But at the first patch i fixes this code. And the way i do it raises questions. | 12:30 |
*** jistr has quit IRC | 12:31 | |
ftersin | mdbooth: i mean the part with strange equation len(disk_infos) > int(not booted_from_volume) | 12:31 |
mdbooth | ftersin: The third patch removes that logic I can't parse :) | 12:31 |
mdbooth | Yeah | 12:31 |
*** amotoki has joined #openstack-nova | 12:31 | |
ftersin | mdbooth: so that i think if core reviewers approve the removal, i can reorder the patch set to remove that logic at the first | 12:32 |
mdbooth | ftersin: That would be better, I think. | 12:32 |
*** jistr has joined #openstack-nova | 12:32 | |
* mdbooth should look in more detail, though | 12:33 | |
*** gongysh has quit IRC | 12:33 | |
*** adreznec has quit IRC | 12:33 | |
ftersin | mdbooth: what do you think about chances of that old code to be removed? my concern is that core reviewers do not like to remove something. | 12:34 |
*** markvoelker has joined #openstack-nova | 12:35 | |
ftersin | mdbooth: but the main point of the patch set is to fix the bug, i.e. i need the first review to be merged | 12:35 |
mdbooth | I've managed to delete a bunch lately. I think deleting cruft is extremely valuable, personally. | 12:35 |
*** adreznec has joined #openstack-nova | 12:35 | |
*** amotoki has quit IRC | 12:35 | |
mdbooth | Well, I *really* don't like that has_local_disks logic. It scares the hell out of me, and this code is scary enough already. | 12:35 |
*** wangqun has quit IRC | 12:36 | |
*** baoli has joined #openstack-nova | 12:36 | |
mdbooth | I can well believe that you have a proof of its correctness, but it's still incomprehensible to regular mortals. | 12:36 |
sdague | gmann: cool | 12:36 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Remove user_id policy enforcement from server start https://review.openstack.org/354662 | 12:37 |
gmann | sdague: johnthetubaguy like this right - https://review.openstack.org/354662 | 12:37 |
gmann | sdague: johnthetubaguy passing user_id from context | 12:37 |
*** code-R has joined #openstack-nova | 12:37 | |
*** baoli_ has joined #openstack-nova | 12:37 | |
ftersin | mdbooth: i could rewrite it with a set of temporary variables, named pretty well to understand the logic | 12:37 |
ansiwen | is someone taking care of ec2api? the default value of bucket_path is set to $pybasedir, which is pointless, because it's not writeable. Not sure if this is a packaging or a module problem... | 12:37 |
johnthetubaguy | gmann: should just pass project_id, I think | 12:38 |
nolwenn | hello ! I made a patch to clean up the second ephemeral disk. Would it be possible that people make a review to have some returns? | 12:38 |
nolwenn | https://review.openstack.org/#/c/341008/ | 12:38 |
andrey-mp | ansiwen: i care - which version do you use? | 12:38 |
johnthetubaguy | gmann: because start is not on that list: http://specs.openstack.org/openstack/nova-specs/specs/newton/approved/user_id_based_policy_enforcement.html | 12:38 |
gmann | johnthetubaguy: yea, but user_id is from context not from instance | 12:39 |
ansiwen | andrey-mp: awesome... :-) | 12:39 |
johnthetubaguy | gmann: but why? | 12:39 |
gmann | johnthetubaguy: i think we need to pass both for oslo policy not? | 12:39 |
*** shaohe_feng has quit IRC | 12:39 | |
johnthetubaguy | gmann: really? | 12:39 |
gmann | johnthetubaguy: am not sure, i remember the bug you pointed out earlier but not sure | 12:40 |
ansiwen | andrey-mp: I deploy with puppet-ec2api, how can I find out which version it is? | 12:40 |
*** shaohe_feng has joined #openstack-nova | 12:40 | |
johnthetubaguy | gmann: what was project_id, because of the default policy | 12:40 |
ftersin | mdbooth: but i'd prefer to remove it at the first. The author of the code said me that it was a mistake to do that. Moreover now he proposes to revert it: https://review.openstack.org/#/c/337056/ | 12:40 |
andrey-mp | ansiwen: which oepnstack version I mean | 12:40 |
ansiwen | andrey-mp: master | 12:40 |
*** baoli has quit IRC | 12:41 | |
ansiwen | andrey-mp: https://review.openstack.org/#/c/352552/ | 12:41 |
*** jistr has quit IRC | 12:41 | |
ansiwen | andrey-mp: this is how the resulting config looks like: http://logs.openstack.org/52/352552/3/check/gate-puppet-ec2api-puppet-beaker-rspec-centos-7/347faee/logs/etc/ec2api/ec2api.conf.txt.gz | 12:41 |
ftersin | mdbooth: what do you think: are there enough reasons for core reviewers to approve the removal? | 12:41 |
openstackgerrit | Tomi Juvonen proposed openstack/nova-specs: Maintenance reason to server https://review.openstack.org/310510 | 12:42 |
*** code-R has quit IRC | 12:42 | |
*** ducttape_ has quit IRC | 12:42 | |
ansiwen | andrey-mp: it fails, because it tries to create /usr/lib/python2.7/site-packages/buckets, which fails of course | 12:42 |
mdbooth | ftersin: I hadn't appreciated the importance of the third patch and had only looked at it briefly. | 12:42 |
ftersin | mdbooth: and the last question - what core should i ping to approve this? | 12:42 |
mdbooth | ftersin: I'm going to spend some time right now looking at this thoroughly, then I'll get back to you. | 12:43 |
*** pbandark has quit IRC | 12:43 | |
ftersin | mdbooth: thanks | 12:43 |
andrey-mp | ansiwen: s3 implementation in ec2api stores bucket to some data directory - I think that you should configure this directory (let me see key name) | 12:44 |
*** rkrum has joined #openstack-nova | 12:45 | |
ansiwen | andrey-mp: but the default value should be something reasonable I guess... not pybasedir I assume? | 12:45 |
cdent | jaypipes: do you have an opinion on what the python interface should be for setting/adding/removing aggregates from a resource provider? There was code in the past (since removed) that used an aggregates field on the resource provider but given how we are managing inventories we may prefer to just use methods. Your opinion? | 12:45 |
andrey-mp | ansiwen: this was copyied from nova - and we didn't change this behaviour | 12:46 |
*** rlrossit has joined #openstack-nova | 12:46 | |
andrey-mp | this string in the config file - '#buckets_path=$state_path/buckets' | 12:47 |
andrey-mp | ansiwen: ^ | 12:47 |
*** rfolco has joined #openstack-nova | 12:47 | |
andrey-mp | ansiwen: so all projects have to configure state_path in config file - in this case bucket will be placed there | 12:47 |
*** amotoki has joined #openstack-nova | 12:47 | |
ansiwen | andrey-mp: so it's wrong to create a config file with no state_path defined? you can't rely on the default value? | 12:48 |
ansiwen | andrey-mp: and this line is commented out, will a value state_path still be picked up? | 12:48 |
ansiwen | andrey-mp: I have to fix this problem, and I'm just trying to figure our the correct approach to do this | 12:49 |
*** shaohe_feng has quit IRC | 12:49 | |
ansiwen | andrey-mp: so any suggestions are highly appreciated :-) | 12:50 |
andrey-mp | ansiwen: yeah, it's wrong. nova has same default value for state_path | 12:50 |
*** shaohe_feng has joined #openstack-nova | 12:50 | |
openstackgerrit | John Garbutt proposed openstack/nova: Remove user_id policy enforcement from server start https://review.openstack.org/354662 | 12:50 |
andrey-mp | ansiwen: check puppets for nova - how they configure state_path value. | 12:50 |
ansiwen | andrey-mp: I see, will do that, thanks a bunch! | 12:50 |
*** rkrum has quit IRC | 12:50 | |
*** edleafe is now known as figleaf | 12:51 | |
openstackgerrit | John Garbutt proposed openstack/nova: Allow authorization by user_id for server changePassword action https://review.openstack.org/354537 | 12:52 |
ftersin | ansiwen: hi. am i right that you setup s3 server from ec2-api by puppets? since this server is not intended to be in production, may i ask you - why do you set up it? | 12:52 |
openstackgerrit | jichenjc proposed openstack/nova: WIP: not use cert and private key in glance client https://review.openstack.org/354706 | 12:52 |
*** rlrossit has quit IRC | 12:53 | |
*** links has quit IRC | 12:53 | |
ansiwen | ftersin: I have no idea :-) let me explain my situation: | 12:53 |
openstackgerrit | jichenjc proposed openstack/nova: refactory query user_id code for quota-sets https://review.openstack.org/280165 | 12:54 |
gmann | johnthetubaguy: if user override policy with "user_id:%(user_id)s" and if we do not pass user_id=context.user_id in target then, policy will fail on start server | 12:54 |
johnthetubaguy | gmann: thats exactly our intent | 12:55 |
mdbooth | ftersin: Are you planning to backport this, btw? | 12:55 |
johnthetubaguy | gmann: we don't want anyone using that policy, it breaks the API semantics | 12:55 |
gmann | johnthetubaguy: but in all other place where user_id and project_id a re default of context it pass even operator override polivy with "user_id:%(user_id)s | 12:55 |
* mdbooth assumes yes | 12:55 | |
johnthetubaguy | gmann: true, but that will "work" by accident | 12:56 |
ansiwen | ftersin: I have to integrate puppet-ec2api into tripleO, and at the moment puppet-ec2api doesn't work, because it tries to create a bucket directory in a non-writeable directory. so you say, puppet-ec2api shouldn't deplay the s3 server in the first place? | 12:56 |
*** rlrossit has joined #openstack-nova | 12:56 | |
johnthetubaguy | gmann: I want that code to have the default target of {} ASAP | 12:56 |
ansiwen | ftersin: see here: https://review.openstack.org/#/c/352552/ | 12:56 |
andrey-mp | ansiwen: production deployment must use swift/swift3 for S3 implementation | 12:56 |
openstackgerrit | jichenjc proposed openstack/nova: Verify os-aggregates.inc on sample files https://review.openstack.org/333114 | 12:57 |
gmann | johnthetubaguy: so we always want to say wrong policy if they do "user_id:%(user_id)s for non user_id honors API action | 12:57 |
ftersin | mdbooth: frankly i have no thought about it. I need this fix for ScaleIO ephemeral driver, to contribute it to upstream. I have an alternative solution for previous releases. And this bug is fixed in the solution. So that i do not need to backport it. | 12:57 |
andrey-mp | ansiwen: s3 implementation from ec2api is only for testing - this implementation doesn't have authorization at all for example | 12:58 |
ftersin | mdbooth: but perhaps someone else wants it once | 12:58 |
ansiwen | andrey-mp, ftersin: so you would say that this line is wrong: https://review.openstack.org/gitweb?p=openstack/puppet-ec2api.git;a=blob;f=spec/acceptance/basic_ec2api_spec.rb;h=147349408d5e5a659d86255c67334967bf974785;hb=26c34eae13aa66a5c295b8ec848d0f0834b0c9e9#l38 | 12:59 |
mdbooth | ftersin: I was just considering the edict for 'no new mox', which https://review.openstack.org/#/c/335542/ technically falls foul of. | 12:59 |
gmann | johnthetubaguy: i got it "user_id:%(user_id)s is always for user_id enforcement which we do not want to pass for default cases. | 12:59 |
mdbooth | However, if you planned to backport it, it wouldn't make sense to add a bunch of almost entirely irrelevant additional test churn. | 12:59 |
gmann | johnthetubaguy: and yea default target {} will make all API consistent on that | 12:59 |
ansiwen | andrey-mp, ftersin: so ::ec2api::s3 shouldn't be deployed in testing, right? | 13:00 |
*** shaohe_feng has quit IRC | 13:00 | |
*** zul has quit IRC | 13:00 | |
ansiwen | andrey-mp, ftersin: could you give me a hint, which components of puppet-ec2api are "supported" and can be tested against? | 13:00 |
*** lucas-hungry is now known as lucasagomes | 13:00 | |
*** shaohe_feng has joined #openstack-nova | 13:00 | |
andrey-mp | ansiwen: ec2api::s3 - it can be deployed in testing. and it shouldn't be deployed in production | 13:01 |
andrey-mp | ansiwen: but all components are supported and should be tested ) | 13:01 |
ftersin | ansiwen: you can see our thoughts about s3 server at the end of install section of ec2-api's readme (https://github.com/openstack/ec2-api#installation) | 13:01 |
*** tonytan4ever has joined #openstack-nova | 13:01 | |
*** baoli_ has quit IRC | 13:02 | |
ansiwen | andrey-mp: ok, so we should still test it in puppet-ec2api and fix the state_path thing, ok... | 13:02 |
andrey-mp | ansiwen: yes, it's true | 13:02 |
*** jistr has joined #openstack-nova | 13:03 | |
ftersin | mdbooth: since that patch reverts some changes, it restores old code... | 13:04 |
*** daemontool_ has quit IRC | 13:05 | |
*** prateek has joined #openstack-nova | 13:05 | |
*** tonytan4ever has quit IRC | 13:06 | |
*** zul has joined #openstack-nova | 13:07 | |
ftersin | mdbooth: it is not so hard to change "new" mox to mock. but in this case the change will not be a pure reverting. do not know if it is important | 13:08 |
mdbooth | ftersin: I'd hope not. I'd certainly flag this as a pragmatic exception. | 13:08 |
jaypipes | cdent: I'd prefer to just use methods, yes. | 13:10 |
*** shaohe_feng has quit IRC | 13:10 | |
jaypipes | and good morning cdent. :) | 13:10 |
*** jaypipes is now known as leakypipes | 13:10 | |
*** kevinz has quit IRC | 13:10 | |
cdent | jaypipes: cool and good afternoon | 13:10 |
cdent | thanks | 13:10 |
*** jwcroppe has quit IRC | 13:11 | |
cdent | that makes things easier | 13:11 |
*** jistr has quit IRC | 13:13 | |
*** shaohe_feng has joined #openstack-nova | 13:13 | |
*** manous has quit IRC | 13:13 | |
*** kylek3h has joined #openstack-nova | 13:13 | |
*** fragatina has joined #openstack-nova | 13:13 | |
*** sdake has joined #openstack-nova | 13:14 | |
*** edmondsw has joined #openstack-nova | 13:14 | |
mdbooth | ftersin: +1 from me on the revert, and I'd support re-ordering the patches. | 13:16 |
*** pwnall has joined #openstack-nova | 13:16 | |
ftersin | ansiwen: i hope this ec2api::s3 puppet does not intended for production usage as well? It should be used for some kind of test deployments only. Am i right? Who can i ask more about this puppet purposes? | 13:16 |
ftersin | ansiwen: does -> is | 13:17 |
*** mdrabe has joined #openstack-nova | 13:17 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: live-migration test hook for serial console https://review.openstack.org/347471 | 13:18 |
*** kylek3h has quit IRC | 13:18 | |
*** fragatina has quit IRC | 13:18 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server delete https://review.openstack.org/354555 | 13:18 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server update https://review.openstack.org/354610 | 13:19 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server evacuate https://review.openstack.org/354656 | 13:19 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Remove user_id policy enforcement from server start https://review.openstack.org/354662 | 13:19 |
ansiwen | ftersin: I have nothing to do with puppet-ec2api so far, I just have the task to integrate it into tripleO, so operators can deploy a ec2api. It sounds like you are suggesting we should not expose the s3 service to an installer, right? | 13:19 |
ftersin | mdbooth: ok, thanks. before to reorder the series i'd like to approve the revert with a +2er. who of them can help me with that? | 13:19 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Fix policy tests for project_id enforcement https://review.openstack.org/354690 | 13:20 |
gmann | johnthetubaguy: rebased the series | 13:20 |
gmann | johnthetubaguy: and for pass tests in https://review.openstack.org/#/c/354690/ | 13:20 |
*** shaohe_feng has quit IRC | 13:20 | |
gmann | johnthetubaguy: existing tests go with admin or "project_id:%(project_id)s" and that tests explicitly tests "project_id:%(project_id)s" only | 13:21 |
*** shaohe_feng has joined #openstack-nova | 13:21 | |
ansiwen | ftersin: will it ever be usable for production usage? | 13:21 |
ftersin | ansiwen: correct | 13:21 |
andrey-mp | Does anybody can approve this review https://review.openstack.org/#/c/352455/ ? It reverts quota's behaviour. due to this bug I can't install devstack with fake virt driver. | 13:21 |
ftersin | ansiwen: never | 13:21 |
ansiwen | ftersin: I see | 13:22 |
*** tonytan4ever has joined #openstack-nova | 13:22 | |
ansiwen | ftersin: ok, then it's really the question why a puppet module should test it. it can be tested in ec2api itself... | 13:22 |
ftersin | ansiwen: it has a lot of omissions: authentification, acl, multinode ability | 13:22 |
*** pwnall has quit IRC | 13:23 | |
mdbooth | ftersin: The advantage of just doing it first is that then the revert becomes a dependency of a bugfix | 13:24 |
mdbooth | And bugfixes are generally higher priority | 13:24 |
andrey-mp | ansiwen: as I understand - puppet module tests own resources, right? | 13:24 |
mdbooth | I don't even think that's gaming anything, because it really does improve the bugfix | 13:24 |
ansiwen | andrey-mp: it does functional tests as well... | 13:25 |
ftersin | ansiwen: it is tested in ec2-api, it is used in CI to verify some cases, using lightweight (w/o Swift) deployment | 13:25 |
andrey-mp | ansiwen: I think that it's better to remove s3 manifest at all from this puppet | 13:25 |
sdague | hmmm no dansmith yet? | 13:26 |
ftersin | mdbooth: hmm, sounds good | 13:26 |
*** ababich1 has quit IRC | 13:26 | |
ansiwen | andrey-mp: ok... I will propose it | 13:26 |
*** jwcroppe has joined #openstack-nova | 13:27 | |
*** jamesdenton has joined #openstack-nova | 13:29 | |
*** rama_y has joined #openstack-nova | 13:29 | |
*** shaohe_feng has quit IRC | 13:30 | |
*** shaohe_feng has joined #openstack-nova | 13:31 | |
*** code-R has joined #openstack-nova | 13:31 | |
*** chandankumar has quit IRC | 13:31 | |
*** code-R has quit IRC | 13:36 | |
*** s1061123 has joined #openstack-nova | 13:37 | |
*** s1061123_ has quit IRC | 13:37 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Remove user_id policy enforcement from instance_actions https://review.openstack.org/354726 | 13:37 |
*** pwnall has joined #openstack-nova | 13:38 | |
*** rodrigods has quit IRC | 13:39 | |
*** rodrigods has joined #openstack-nova | 13:40 | |
*** mriedem has joined #openstack-nova | 13:40 | |
*** shaohe_feng has quit IRC | 13:41 | |
*** shaohe_feng has joined #openstack-nova | 13:41 | |
mriedem | sdague: did you look over the changes to https://review.openstack.org/#/c/354349/ ? | 13:42 |
*** ducttape_ has joined #openstack-nova | 13:43 | |
sdague | mriedem: yeh, I was trying to work through the mitaka test issue | 13:43 |
sdague | because we unconditionally test microversions, even if the cloud we are hitting doesn't support them | 13:43 |
sdague | which should be easy enough to change to skips | 13:44 |
sdague | but in doing so, I discovered that a default stable/mitaka devstack has no flavors | 13:44 |
openstackgerrit | Dan Smith proposed openstack/nova: Make simple_cell_setup idempotent https://review.openstack.org/354734 | 13:44 |
mriedem | sdague: i created a stable/mitaka devstack the other day and it had flavors | 13:45 |
sdague | the tempest ones | 13:45 |
sdague | we took out the flavor part of the db migrations | 13:46 |
sdague | but forgot to backport this - https://review.openstack.org/#/c/354710/ | 13:46 |
*** sdake has quit IRC | 13:46 | |
mriedem | sdague: i have them all | 13:46 |
sdague | mriedem: ... hmmm | 13:46 |
mriedem | i'm at dcb218d63e044a7b88ce2b5b0eae6b6cd1663961 | 13:46 |
sdague | oh, gdi | 13:47 |
mriedem | did you mean the special sdague custom ones? | 13:47 |
*** ducttape_ has quit IRC | 13:48 | |
sdague | I forgot how flakey the branch changing in devstack is | 13:48 |
mriedem | ok, i just git cloned devstack and git checkout stable/mitaka | 13:48 |
mriedem | easy peasy | 13:48 |
sdague | yeh, well, this box had previously done devstack master | 13:48 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Remove user_id policy enforcement from unlock_override https://review.openstack.org/354737 | 13:49 |
lascii | Guest13957: johnthetubaguy left a comment on the original review suggesting something like https://review.openstack.org/#/c/354734. I never really expected the command to be run more than once though. | 13:49 |
*** Guest13957 is now known as dansmith | 13:50 | |
*** dansmith is now known as Guest37890 | 13:50 | |
Guest37890 | lascii: well, I'm actually not sure it's going to be specifically needed here, but I expect puppet people would appreciate just being able to run it | 13:50 |
Guest37890 | gdi | 13:50 |
*** nkrinner is now known as nkrinner_afk | 13:50 | |
*** Guest37890 is now known as dansmith | 13:51 | |
*** shaohe_feng has quit IRC | 13:51 | |
johnthetubaguy | seems easier to make it idempotent, stops nasty surprizes | 13:51 |
dansmith | yeah | 13:51 |
*** shaohe_feng has joined #openstack-nova | 13:51 | |
lascii | yeah, idempotence is good. But I don't want folks to feel the need to run it multiple times. it's intended to be a fire and forget thing | 13:51 |
*** Dinesh_Bhor has quit IRC | 13:52 | |
dansmith | well, I print a thing | 13:52 |
*** ecelik has quit IRC | 13:52 | |
openstackgerrit | Andrew Laski proposed openstack/nova: Add ObjectListBase concat methods https://review.openstack.org/352587 | 13:52 |
openstackgerrit | Andrew Laski proposed openstack/nova: Fix migration list + MigrationList operation https://review.openstack.org/353694 | 13:52 |
*** thorst_ has joined #openstack-nova | 13:53 | |
lascii | my concern really stems from wanting deployers to use something like https://review.openstack.org/#/c/328491 for cell maintenance and not abuse the setup command | 13:53 |
lascii | I'm not complaining though. not failing in the setup command is good | 13:54 |
dansmith | but this command is before that command, right? | 13:54 |
dansmith | you have to do the initial cell setup once and then you can add hosts over and over | 13:55 |
dansmith | let me see if it's actually required here and then we can discuss the meta question if you want | 13:55 |
lascii | sure | 13:55 |
dansmith | at a minimum it should not explode with a stack trace like it does today :) | 13:56 |
sdague | mriedem: did you see my email about os-brick locks? | 13:56 |
lascii | +1 | 13:56 |
*** vishwanathj has joined #openstack-nova | 13:56 | |
*** eharney has joined #openstack-nova | 13:56 | |
*** sdake has joined #openstack-nova | 13:56 | |
mriedem | sdague: already replied, twice | 13:57 |
mriedem | sdague: did you see my email about get me a network schema changes? | 13:57 |
*** thorst_ has quit IRC | 13:57 | |
*** dansmith is now known as superdan | 13:57 | |
lascii | dansmith: I'm just wondering how we incentivize folks to use the add_host command when the setup command will also do what they want but is The Wrong Thing(tm). anyways, just overthinking it for the moment | 13:58 |
*** TravT_ has joined #openstack-nova | 13:59 | |
superdan | lascii: the simple command only does anything the first time you run it | 13:59 |
sdague | mriedem: I saw that it existed, I didn't digest it | 13:59 |
superdan | with my mchange | 13:59 |
*** diogogmt has joined #openstack-nova | 13:59 | |
superdan | lascii: don't they still have to run that once before they use add_host? | 14:00 |
sdague | I was trying to get these novaclient changes passing stable (and completely screwing up my stable setup in the process apparently) | 14:00 |
*** anush_ has joined #openstack-nova | 14:00 | |
*** kylek3h has joined #openstack-nova | 14:01 | |
*** shaohe_feng has quit IRC | 14:01 | |
lascii | superdan: yeah, the process should be run the simple command once and then run add_host anytime a host or hosts are added | 14:01 |
mriedem | sdague: i'm a little less concerned about getting the current state of novaclient passing on stable/mitaka, but more worried about 2.36 | 14:01 |
mriedem | since that's the breaking change | 14:02 |
*** shaohe_feng has joined #openstack-nova | 14:02 | |
mriedem | but yeah it looks like it's really just the functional tests are not capping the api version based on what's available from the server | 14:02 |
lascii | superdan: but the map_cell_and_hosts within the simple command will also end up adding hosts I believe. but I think I'm overly worrying about it | 14:02 |
*** TravT has quit IRC | 14:02 | |
cdent | sdague: if you get a chance today to restamp the bottom three starting at https://review.openstack.org/#/c/352573/ that would be great. Once those three are in I can parallelize those that follow and avoid some of the "depends on merge that failed" problem that was happening last night ought to be less of an issue | 14:02 |
*** rhagarty_ has joined #openstack-nova | 14:03 | |
sdague | mriedem: ok, which bits about 2.36? | 14:03 |
sdague | mriedem: or more importantly, what are the outstanding bits you think we're missing | 14:04 |
*** rhagarty has quit IRC | 14:04 | |
openstackgerrit | Jay Pipes proposed openstack/nova-specs: Resource providers: dynamic resource classes https://review.openstack.org/312696 | 14:04 |
*** pradk has quit IRC | 14:05 | |
mriedem | sdague: we still have to do the network name translation part | 14:05 |
mriedem | i'm in meetings for like the next 1.5 hours | 14:05 |
*** baoli has joined #openstack-nova | 14:05 | |
sdague | ok, I'll get back a master stack on a different NUC and run that in parallel | 14:05 |
*** jaugustine_ has joined #openstack-nova | 14:05 | |
ansiwen | andrey-mp: https://review.openstack.org/#/c/354732/ | 14:06 |
sdague | mriedem: you have a couple of commands that fail that should pass? | 14:06 |
sdague | I knew the image ones off the top of my head | 14:06 |
mriedem | sdague: nova boot --nic net-name=public | 14:07 |
*** bnemec is now known as beekneemech | 14:07 | |
*** pradk has joined #openstack-nova | 14:07 | |
*** rhagarty_ has quit IRC | 14:08 | |
*** burgerk has joined #openstack-nova | 14:09 | |
sdague | mriedem: ok, cool, I'll poke on that | 14:10 |
mriedem | sdague: i think we're ok with the image patch...i feel weird about it given the amount of unit testing that i had to change, | 14:10 |
mriedem | but the only thing that really needed to change in the actual shell code was the image delete stuff | 14:11 |
mriedem | i could add functional tests for those if we have reservations, or i'll just pull it down and test that stuff out locally a bit | 14:11 |
*** shaohe_feng has quit IRC | 14:11 | |
andrey-mp | ansiwen: good ) | 14:12 |
sdague | is there a volume name issue out there as well? | 14:12 |
*** jwcroppe has quit IRC | 14:12 | |
*** jaugustine_ has quit IRC | 14:12 | |
*** thorst_ has joined #openstack-nova | 14:14 | |
*** shaohe_feng has joined #openstack-nova | 14:14 | |
*** _coolsvap_ is now known as coolsvap | 14:16 | |
*** zenoway has joined #openstack-nova | 14:19 | |
mriedem | sdague: pretty sure there isn't | 14:21 |
mriedem | you have to pass volume id to the cli | 14:21 |
mriedem | i know that because we completely removed the cs.volumes/snapshots/types api code | 14:21 |
mriedem | so the shell wouldn't have anything to call for that translation | 14:21 |
sdague | mriedem: ok, good | 14:21 |
*** shaohe_feng has quit IRC | 14:22 | |
*** shaohe_feng has joined #openstack-nova | 14:23 | |
*** raunak has joined #openstack-nova | 14:26 | |
sdague | mriedem: you want to kick this in as well - https://review.openstack.org/#/c/354638/ - just makes debugging these novaclient tests easier | 14:31 |
*** ducttape_ has joined #openstack-nova | 14:32 | |
*** shaohe_feng has quit IRC | 14:32 | |
*** hemanthm|afk is now known as hemanthm | 14:33 | |
*** mlavalle has joined #openstack-nova | 14:33 | |
*** whenry has joined #openstack-nova | 14:33 | |
markus_z | johnthetubaguy: Maybe you could have a look at https://review.openstack.org/#/c/352455/2 | 14:33 |
*** vladikr has joined #openstack-nova | 14:33 | |
mriedem | sdague: done | 14:34 |
mriedem | sdague: in that vein, i'm pretty proud of this change i made last night https://review.openstack.org/#/c/354349/4/novaclient/tests/unit/fakes.py | 14:34 |
mriedem | after banging my head against the wall | 14:34 |
mriedem | for several hours | 14:34 |
*** devkulkarni1 has joined #openstack-nova | 14:34 | |
*** code-R has joined #openstack-nova | 14:34 | |
mriedem | i could pull that out as a separate change, but whatever | 14:34 |
*** shaohe_feng has joined #openstack-nova | 14:35 | |
*** baoli has quit IRC | 14:36 | |
*** baoli has joined #openstack-nova | 14:36 | |
*** tanvirt has joined #openstack-nova | 14:36 | |
*** jistr has joined #openstack-nova | 14:39 | |
*** zenoway has quit IRC | 14:40 | |
*** zenoway has joined #openstack-nova | 14:40 | |
*** rhagarty has joined #openstack-nova | 14:41 | |
*** devkulkarni1 has quit IRC | 14:41 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: live-migration test hook for serial console https://review.openstack.org/347471 | 14:41 |
*** shaohe_feng has quit IRC | 14:42 | |
*** raunak has quit IRC | 14:43 | |
*** shaohe_feng has joined #openstack-nova | 14:43 | |
*** zenoway has quit IRC | 14:45 | |
*** woodster_ has joined #openstack-nova | 14:45 | |
*** zz_dimtruck is now known as dimtruck | 14:46 | |
EmilienM | hi, I'm not sure if it's a bug but I noticed since recently, nova-scheduler and nova-consoleauth (maybe more services) are failing to start if AMQP is not ready (see logs). I thought it would retry until it works | 14:47 |
EmilienM | http://logs.openstack.org/55/354355/4/check/gate-puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial-nv/dda4cc6/logs/nova/nova-consoleauth.txt.gz#_2016-08-12_12_11_08_712 | 14:47 |
EmilienM | it sounds like it try during 16 seconds and then the service stops | 14:47 |
EmilienM | we are running trunk | 14:48 |
*** devkulkarni1 has joined #openstack-nova | 14:48 | |
sdague | EmilienM: could it be an oslo.message change? | 14:51 |
sdague | because at this point I think all that logic is outside of nova | 14:51 |
superdan | lascii: sorry, call.. so my change to the simple command makes it completely not do anything if you call it a second time.. it just fails and bails.. it will not do the second step | 14:51 |
EmilienM | sdague: I checked recent commits in oslo.messaging and oslo.service and I haven't noticed anything about that | 14:52 |
*** mdrabe has quit IRC | 14:52 | |
*** shaohe_feng has quit IRC | 14:52 | |
*** devkulkarni1 has quit IRC | 14:52 | |
*** rlrossit_ has joined #openstack-nova | 14:52 | |
lascii | superdan: it's https://review.openstack.org/#/c/354734/1/nova/cmd/manage.py@1193 that does somewhat the same thing as add_hosts | 14:53 |
*** shaohe_feng has joined #openstack-nova | 14:53 | |
superdan | lascii: okay, can I put that after the cell0 mapping to make it not happen? | 14:54 |
mriedem | no recent kombu or amqp changes in upper-constraints | 14:54 |
*** devkulkarni has joined #openstack-nova | 14:54 | |
superdan | lascii: whatever, I think we need to make this idempotent one way or the other.. my day is stacking up fast, so let me get the grenade thing working, and we can discuss what to do about this later, okay? | 14:54 |
EmilienM | of course we could ensure that rabbit is ready before nova tries to start in puppet | 14:55 |
EmilienM | but I figured it would be useful to share this info with you | 14:55 |
lascii | superdan: yeah. no argument on the idempotence. switching the two should work. but worrying about it later is fine with me | 14:55 |
*** zenoway has joined #openstack-nova | 14:55 | |
superdan | lascii: we can worry about it before merge, I mean | 14:56 |
*** rlrossit has quit IRC | 14:56 | |
*** rrecio has joined #openstack-nova | 14:56 | |
lascii | superdan: yeah, once it's proven to be working we can discuss it | 14:57 |
*** rrecio_ has joined #openstack-nova | 14:58 | |
*** mdrabe has joined #openstack-nova | 14:59 | |
*** _ducttape_ has joined #openstack-nova | 14:59 | |
*** ijw has joined #openstack-nova | 15:00 | |
sdague | mriedem: hmmm... os-networks is returning a 200 at 2.35? | 15:00 |
*** jdurgin1 has joined #openstack-nova | 15:00 | |
*** EinstCrazy has joined #openstack-nova | 15:00 | |
mriedem | sdague: do you have a nova-network devstack or neutron? | 15:01 |
sdague | neutron | 15:01 |
*** rrecio has quit IRC | 15:01 | |
openstackgerrit | Sarafraj Singh proposed openstack/nova: Improve help text for glance options https://review.openstack.org/324007 | 15:01 |
mriedem | oh yeah the proxy will work either way for that one | 15:01 |
mriedem | sdague: 2.36 is the breaking api | 15:01 |
mriedem | 2.35 is fine | 15:01 |
sdague | oh, we've forced the fallback | 15:02 |
johnthetubaguy | markus_z: dang it, I thought I -1ed a few patches for that, but I see it was only some of the options in that file that are correct | 15:02 |
openstackgerrit | jichenjc proposed openstack/nova: not use cert and private key in glance client https://review.openstack.org/354706 | 15:02 |
*** shaohe_feng has quit IRC | 15:03 | |
*** ducttape_ has quit IRC | 15:03 | |
*** shaohe_feng has joined #openstack-nova | 15:03 | |
*** abhishekk has quit IRC | 15:04 | |
mriedem | sdague: not yet | 15:04 |
mriedem | sdague: are you on vanila novaclient? | 15:05 |
mriedem | https://review.openstack.org/#/c/347514/ does the fallback to 2.35 | 15:05 |
sdague | no, this is with the image patch | 15:05 |
mriedem | ok, that shouldn't fallback to 2.35 | 15:05 |
mriedem | https://review.openstack.org/#/c/347514/ adds the 2.36 support, so you shouldn't even get to 2.36 yet | 15:05 |
mriedem | https://review.openstack.org/#/c/347514/6/novaclient/__init__.py | 15:05 |
openstackgerrit | John Garbutt proposed openstack/nova: Allow Nova Quotas to be Disabled https://review.openstack.org/352455 | 15:06 |
*** sheel has joined #openstack-nova | 15:06 | |
sdague | mriedem: ok, though apparently I'll need to do something else to my config to make this work | 15:06 |
sdague | ExternalNetworkAttachForbidden: It is not allowed to create an interface on external network e9bdb773-08de-4454-9505-393a5ee1c1a8 | 15:06 |
mriedem | sdague: which nic are you trying to attach to? | 15:07 |
markus_z | johnthetubaguy: thanks for https://github.com/openstack/openstack-doc-tools/commit/4f0433f btw, looks really nice. | 15:08 |
mriedem | try: nova boot --flavor 42 --nic net-name=private --image ? --poll test | 15:08 |
mriedem | i'd think you could attach to the 'public' network though, not sure what's up there | 15:08 |
*** armax has joined #openstack-nova | 15:08 | |
johnthetubaguy | markus_z: no worries, I hate the patch, but it does what we needed :) | 15:08 |
mriedem | i have my own local.conf for neutron, i haven't tried the defaults yet | 15:08 |
sdague | ok, private seems to be getting further | 15:08 |
johnthetubaguy | markus_z: we have a few bugs there still, because of how we use "*" and because we sometimes indent I think | 15:08 |
markus_z | johnthetubaguy: yeah, I had that on my todo list for ages :( | 15:09 |
sdague | mriedem: pastebin your config? | 15:09 |
johnthetubaguy | markus_z: going to go through the config reference with a fine tooth comb once we get back feature freeze | 15:09 |
mriedem | sdague: http://paste.openstack.org/show/556116/ | 15:09 |
johnthetubaguy | markus_z: got some of the OSIC docs folks on hand to help review and edit those changes | 15:09 |
markus_z | johnthetubaguy: ah, explains why some get rendered differently | 15:09 |
sdague | mriedem: also... this is what the defaults currently look like - https://review.openstack.org/#/c/354658/ - was trying to push a new devstack doc update daily | 15:09 |
mriedem | full disclosure, it's rtheis' config | 15:09 |
johnthetubaguy | markus_z: the bug is ln465 I think, or its a bug with how we currently have help text, depending on how you look at it | 15:10 |
*** ayoung has joined #openstack-nova | 15:10 | |
mriedem | i don't use 75% of that local.conf really | 15:11 |
johnthetubaguy | markus_z: I am thinking of writing a pep8 check to catch all that formatting stuff, we actually need to wrap the lines early, else the sample file goes silly as well | 15:11 |
markus_z | johnthetubaguy: I'm trying to run tox for the manuals project but it doesn't use the code I have locally | 15:11 |
sdague | mriedem: other than the service changes, that's all what I've got | 15:11 |
markus_z | johnthetubaguy: Did you do something to test that locally? | 15:11 |
*** xyang1 has quit IRC | 15:11 | |
johnthetubaguy | markus_z: yeah, its nasty actually, there is a README somewhere, let me find it... | 15:11 |
sdague | most of that is commented out | 15:12 |
johnthetubaguy | markus_z: https://github.com/openstack/openstack-doc-tools/blob/master/autogenerate_config_docs/README.rst | 15:12 |
markus_z | johnthetubaguy: I think I remember a python package which checks plain text for rst format | 15:12 |
*** xyang1 has joined #openstack-nova | 15:12 | |
johnthetubaguy | markus_z: honestly, I think we should only use the subset that works with the tooling, just "*" and "``" I think | 15:12 |
openstackgerrit | jichenjc proposed openstack/nova: Add log for instance with host field set https://review.openstack.org/354781 | 15:12 |
mriedem | sdague: and? | 15:13 |
mriedem | stack@newton:~$ nova network-list | 15:13 |
mriedem | +--------------------------------------+---------+------+ | 15:13 |
mriedem | | ID | Label | Cidr | | 15:13 |
mriedem | +--------------------------------------+---------+------+ | 15:13 |
mriedem | | 3d724099-b8f6-464f-ad43-bd092e8e8320 | public | - | | 15:13 |
mriedem | | fcdad99f-3b6d-4376-bbd9-e8f9190390c4 | private | - | | 15:13 |
mriedem | +--------------------------------------+---------+------+ | 15:13 |
markus_z | johnthetubaguy: yeah, fair enough, that's all we should need IMO | 15:13 |
mriedem | same networks? | 15:13 |
*** shaohe_feng has quit IRC | 15:13 | |
sdague | yeh | 15:13 |
*** rmart04 has quit IRC | 15:13 | |
mriedem | sdague: oh, router:external | True | 15:13 |
mriedem | for public | 15:13 |
mriedem | you can't use that | 15:13 |
mriedem | so you have to use the private nic | 15:13 |
mriedem | that's why you're hitting ExternalNetworkAttachForbidden | 15:14 |
sdague | ok, well, at least it's broken in a known way | 15:14 |
mriedem | that's working as designed bro! | 15:14 |
sdague | though, it's a little sad that we don't detect that until n-cpu | 15:14 |
mriedem | yeah, we could probably move that to validate_networks | 15:14 |
johnthetubaguy | markus_z: cool, I think we can get away with just that | 15:14 |
mriedem | b/c we have the same code to find the available network | 15:14 |
sdague | "yep totally works!" "ERROR" | 15:14 |
mriedem | we just aren't checking the external thing until n-cpu | 15:15 |
*** eharney has quit IRC | 15:15 | |
*** eharney_ has joined #openstack-nova | 15:15 | |
*** jaosorior has quit IRC | 15:15 | |
mriedem | i think i was talking about this with someone awhile back too, b/c there is a policy check in the neutron code in nova around this too | 15:15 |
mriedem | which is really weird | 15:15 |
sdague | ok, well this will be my afternoon, but I'll end up taking a break soon to go hit lunch with mtreinish | 15:16 |
*** nolwenn has quit IRC | 15:16 | |
*** shaohe_feng has joined #openstack-nova | 15:16 | |
openstackgerrit | Andrey Shestakov proposed openstack/nova: Add support for detaching interfaces in ironic https://review.openstack.org/347410 | 15:16 |
mriedem | ok, i'm going to work on getting a nv functional novaclient + neutron job going | 15:16 |
mriedem | posted a thread to the ML about how to configure that since i have someone here that can work on it i think | 15:16 |
*** eharney_ is now known as eharney | 15:16 | |
mriedem | but not sure about the best way to do the config/check for neutron | 15:16 |
sdague | network in the service catalog | 15:17 |
sdague | just run with that | 15:17 |
mriedem | ok, that's my preferred approach | 15:17 |
mriedem | cool | 15:17 |
*** code-R has quit IRC | 15:18 | |
markus_z | johnthetubaguy: Is "$sentinel$" some rst magic? | 15:18 |
*** rhagarty_ has joined #openstack-nova | 15:18 | |
johnthetubaguy | markus_z: i substitute that later on with real RST | 15:18 |
markus_z | johnthetubaguy: oh, ok, simpler than I thought :) | 15:19 |
*** andrey-mp has left #openstack-nova | 15:19 | |
johnthetubaguy | markus_z: :) the nasty bit is the number of spaces in that substituted string has to match the indent in the template | 15:20 |
*** rhagarty has quit IRC | 15:20 | |
*** yamahata has joined #openstack-nova | 15:20 | |
*** devkulkarni has quit IRC | 15:20 | |
prateek | leakypipes, regarding your comment on the patch https://review.openstack.org/#/c/327706/, i can see that glance does and cinder also handle conn failures the same way, its just that neutron was missing a wrapper in client | 15:20 |
prateek | leakypipes, can you please help me understand if that is wrong so that i can further work on it in line with your comment ? | 15:21 |
*** devkulkarni has joined #openstack-nova | 15:23 | |
*** thorst_ has quit IRC | 15:23 | |
*** shaohe_feng has quit IRC | 15:23 | |
*** pcaruana has quit IRC | 15:23 | |
*** EinstCrazy has quit IRC | 15:23 | |
*** jistr is now known as jistr|call | 15:23 | |
*** thorst_ has joined #openstack-nova | 15:24 | |
*** shaohe_feng has joined #openstack-nova | 15:24 | |
*** eharney_ has joined #openstack-nova | 15:27 | |
*** TravT_ has quit IRC | 15:27 | |
*** thorst_ has quit IRC | 15:28 | |
*** eharney has quit IRC | 15:29 | |
mriedem | sdague: for your post-lunch reading, this is the thread on that external network policy check thing http://lists.openstack.org/pipermail/openstack-dev/2016-June/096919.html | 15:29 |
*** danpb has quit IRC | 15:29 | |
*** beagles is now known as beagles_brb | 15:29 | |
*** sridharg has quit IRC | 15:30 | |
*** sulmer has joined #openstack-nova | 15:30 | |
*** haplo37_ has joined #openstack-nova | 15:30 | |
openstackgerrit | jichenjc proposed openstack/nova: prevent non-admin user search soft-delete server https://review.openstack.org/258472 | 15:31 |
*** dikonoor has quit IRC | 15:31 | |
*** thorst_ has joined #openstack-nova | 15:31 | |
*** markus_z has quit IRC | 15:32 | |
*** TravT has joined #openstack-nova | 15:33 | |
*** ayoung has quit IRC | 15:33 | |
*** shaohe_feng has quit IRC | 15:33 | |
*** shaohe_feng has joined #openstack-nova | 15:34 | |
*** thorst__ has joined #openstack-nova | 15:35 | |
openstackgerrit | jichenjc proposed openstack/nova: Add comment about how status field changed https://review.openstack.org/354119 | 15:35 |
*** thorst_ has quit IRC | 15:36 | |
*** Cassowary has quit IRC | 15:37 | |
*** Cassowary has joined #openstack-nova | 15:37 | |
*** Vek has quit IRC | 15:38 | |
*** sdake_ has joined #openstack-nova | 15:39 | |
*** pbandark has joined #openstack-nova | 15:39 | |
*** thorst__ has quit IRC | 15:40 | |
johnthetubaguy | does anyone remember why tunneled live-migration was on by default, was that a security thing? | 15:40 |
johnthetubaguy | https://review.openstack.org/#/c/350480 | 15:41 |
*** jichen has quit IRC | 15:41 | |
*** sdake has quit IRC | 15:41 | |
*** jichen has joined #openstack-nova | 15:42 | |
*** jistr|call is now known as jistr | 15:42 | |
*** shaohe_feng has quit IRC | 15:44 | |
sdague | heh, neat, neutron is using file extensions in addition to mime types - http://10.42.0.53:9696/v2.0/networks.json?fields=id&name=private | 15:45 |
sdague | ok, heading out to get food, but the switcheroo shouldn't be too bad here | 15:46 |
*** jichen has quit IRC | 15:46 | |
*** jwcroppe has joined #openstack-nova | 15:47 | |
*** shaohe_feng has joined #openstack-nova | 15:47 | |
*** rcernin has quit IRC | 15:47 | |
*** ivase has quit IRC | 15:48 | |
*** mdrabe has quit IRC | 15:49 | |
*** mdrabe has joined #openstack-nova | 15:50 | |
*** mdrabe has quit IRC | 15:52 | |
*** mdrabe has joined #openstack-nova | 15:52 | |
*** thorst_ has joined #openstack-nova | 15:53 | |
*** _ducttape_ has quit IRC | 15:53 | |
*** shaohe_feng has quit IRC | 15:54 | |
*** ducttape_ has joined #openstack-nova | 15:54 | |
*** vladikr has quit IRC | 15:55 | |
*** vladikr has joined #openstack-nova | 15:55 | |
*** thorst_ has quit IRC | 15:55 | |
*** thorst_ has joined #openstack-nova | 15:56 | |
*** shaohe_feng has joined #openstack-nova | 15:57 | |
*** beagles_brb is now known as beagles | 15:57 | |
superdan | lascii: http://logs.openstack.org/65/354265/6/check/gate-grenade-dsvm-multinode/09c6cce/logs/grenade.sh.txt.gz#_2016-08-12_15_42_05_224 | 15:57 |
*** krtaylor has quit IRC | 15:59 | |
*** Apoorva has joined #openstack-nova | 15:59 | |
*** sdake_ has quit IRC | 15:59 | |
*** haplo37_ has quit IRC | 16:00 | |
*** eharney_ is now known as eharney | 16:00 | |
*** yamahata has quit IRC | 16:03 | |
*** shaohe_feng has quit IRC | 16:04 | |
openstackgerrit | Dan Smith proposed openstack/nova: Make simple_cell_setup idempotent https://review.openstack.org/354734 | 16:05 |
*** shaohe_feng has joined #openstack-nova | 16:05 | |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: Replace mox with mock in test_validate_bdm https://review.openstack.org/353638 | 16:06 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: Remove check_attach https://review.openstack.org/335358 | 16:06 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: Replace mox with mock in test_cinder https://review.openstack.org/352572 | 16:06 |
*** TRUMP-PENCE has quit IRC | 16:07 | |
*** raunak has joined #openstack-nova | 16:09 | |
prometheanfire | mriedem: hi :D | 16:10 |
*** TRUMP-PENCE has joined #openstack-nova | 16:10 | |
*** annegentle has joined #openstack-nova | 16:10 | |
prometheanfire | mriedem: here's the reminder | 16:10 |
mriedem | prometheanfire: heh | 16:11 |
mriedem | well, i opened that bug last night | 16:11 |
mriedem | but i'm doing about 10 other things atm which trump that | 16:11 |
prometheanfire | ya, saw that | 16:11 |
*** oanson has quit IRC | 16:11 | |
prometheanfire | that's fine, it's just a reminder :P | 16:11 |
*** pbandark has quit IRC | 16:12 | |
*** prateek_ has joined #openstack-nova | 16:13 | |
*** code-R has joined #openstack-nova | 16:13 | |
*** code-R_ has joined #openstack-nova | 16:13 | |
*** shaohe_feng has quit IRC | 16:14 | |
*** prateek has quit IRC | 16:16 | |
mriedem | https://bugs.launchpad.net/nova/+bug/1612494 in case someone else wants to hack on this | 16:16 |
openstack | Launchpad bug 1612494 in OpenStack Compute (nova) "neutronv2 unit tests fail with python-neutronclient 5.1.0" [High,Confirmed] | 16:16 |
*** code-R has quit IRC | 16:17 | |
*** shaohe_feng has joined #openstack-nova | 16:17 | |
*** clenimar_ has joined #openstack-nova | 16:20 | |
*** oanson has joined #openstack-nova | 16:24 | |
*** parora has joined #openstack-nova | 16:24 | |
*** shaohe_feng has quit IRC | 16:25 | |
*** mingyu has joined #openstack-nova | 16:25 | |
*** mingyu has quit IRC | 16:25 | |
*** shaohe_feng has joined #openstack-nova | 16:25 | |
*** clenimar_ has quit IRC | 16:26 | |
*** yamahata has joined #openstack-nova | 16:26 | |
*** mingyu has joined #openstack-nova | 16:27 | |
*** mingyu has quit IRC | 16:28 | |
*** prateek_ has quit IRC | 16:28 | |
*** daidv has joined #openstack-nova | 16:28 | |
*** fragatina has joined #openstack-nova | 16:30 | |
*** fragatin_ has joined #openstack-nova | 16:31 | |
*** fragatina has quit IRC | 16:35 | |
*** shaohe_feng has quit IRC | 16:35 | |
*** tesseract- has quit IRC | 16:35 | |
*** shaohe_feng has joined #openstack-nova | 16:35 | |
*** EinstCrazy has joined #openstack-nova | 16:36 | |
*** rrecio_ has quit IRC | 16:36 | |
lascii | superdan: woot! | 16:40 |
superdan | lascii: reordered the nova code to fail first and re-used your devstack function in grenade | 16:41 |
superdan | so if that works I think we're good | 16:42 |
*** stewie925 has joined #openstack-nova | 16:44 | |
*** shaohe_feng has quit IRC | 16:45 | |
*** shaohe_feng has joined #openstack-nova | 16:46 | |
openstackgerrit | Alberto Murillo proposed openstack/nova: Create additional hosts file for dnsmasq before using it. https://review.openstack.org/210627 | 16:46 |
stewie925 | hi guys, am working on ConfigOption cleanup but I notice that http://45.55.105.55:8082/config-options.html is no longer updated | 16:48 |
raj_singh | stewie925: Sometimes it takes a little while to reflect changes in that chart | 16:49 |
stewie925 | hi raj - I see that "ephemeral_storage.py" frst patch (removing the needs: tag) was committed in July (https://review.openstack.org/#/c/348487/1) but its still showing To Do today | 16:52 |
*** rlrossit_ has quit IRC | 16:54 | |
*** rlrossit has joined #openstack-nova | 16:54 | |
*** sulmer has quit IRC | 16:55 | |
*** lucasagomes is now known as lucas-dinner | 16:55 | |
*** unicell has quit IRC | 16:55 | |
*** shaohe_feng has quit IRC | 16:55 | |
*** unicell has joined #openstack-nova | 16:56 | |
*** shaohe_feng has joined #openstack-nova | 16:56 | |
raj_singh | stewie925: must be some issue with linking of that specific file, I will take a look next week. | 16:58 |
stewie925 | thank you raj_singh - no problem | 16:58 |
kevinbenton | mriedem: you coming to the neutron mid-cycle? :) | 16:59 |
*** rlrossit has quit IRC | 16:59 | |
*** anush_ has quit IRC | 17:00 | |
*** shaohe_feng has quit IRC | 17:06 | |
*** shaohe_feng has joined #openstack-nova | 17:06 | |
*** dikonoor has joined #openstack-nova | 17:08 | |
*** oomichi has joined #openstack-nova | 17:08 | |
*** woodster_ has quit IRC | 17:09 | |
openstackgerrit | Michael Glaser proposed openstack/nova: Check opt consistency for neutron.py https://review.openstack.org/349605 | 17:12 |
*** ayoung has joined #openstack-nova | 17:13 | |
*** shaohe_feng has quit IRC | 17:16 | |
*** devkulkarni has quit IRC | 17:16 | |
*** shaohe_feng has joined #openstack-nova | 17:16 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Return None in get_instance_id_by_floating_address https://review.openstack.org/351960 | 17:17 |
*** baoli has quit IRC | 17:19 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Remove unnecessary debug logs of normal API ops https://review.openstack.org/351962 | 17:19 |
*** tri2sing has joined #openstack-nova | 17:21 | |
*** coolsvap has quit IRC | 17:21 | |
cfriesen_ | Where in the code does CONF.upgrade_levels actually get set? | 17:23 |
*** dikonoor has quit IRC | 17:23 | |
*** krtaylor has joined #openstack-nova | 17:23 | |
*** prateek_ has joined #openstack-nova | 17:24 | |
*** code-R_ has quit IRC | 17:25 | |
*** sheel has quit IRC | 17:26 | |
*** shaohe_feng has quit IRC | 17:26 | |
*** parora has quit IRC | 17:27 | |
*** shaohe_feng has joined #openstack-nova | 17:27 | |
*** mingyu has joined #openstack-nova | 17:28 | |
*** jdurgin1 has quit IRC | 17:29 | |
*** jwcroppe has quit IRC | 17:29 | |
*** rlrossit has joined #openstack-nova | 17:29 | |
superdan | lascii: grenade-multinode passed and the logs look legit | 17:31 |
superdan | it will be a while before the rest finish | 17:31 |
superdan | but I think we're good | 17:31 |
lascii | awesome | 17:31 |
superdan | when sdague comes back I | 17:32 |
superdan | will see if he can look at the grenade bits | 17:32 |
openstackgerrit | Patrick East proposed openstack/nova: Add release note to warn about os-brick lock dir https://review.openstack.org/354502 | 17:32 |
lascii | cool. The nova stuff all looked good to me | 17:32 |
*** mingyu has quit IRC | 17:32 | |
superdan | the nova stuff goes first, so we can move on that at any point when we have test results | 17:33 |
*** rlrossit has quit IRC | 17:34 | |
*** shaohe_feng has quit IRC | 17:36 | |
*** Vek has joined #openstack-nova | 17:37 | |
superdan | lascii: yes, we'll ask sdague for a grenadeyness assessment, exactly | 17:38 |
*** shaohe_feng has joined #openstack-nova | 17:39 | |
*** rrecio has joined #openstack-nova | 17:40 | |
*** ijw has quit IRC | 17:40 | |
lascii | I had to debate that term a bit, grenadic?, grenadonic?, ahh grenadey | 17:40 |
superdan | lascii: I believe the proper term is "grenadeliness" | 17:41 |
*** rrecio_ has joined #openstack-nova | 17:41 | |
superdan | "this code, I must say, possesses excellent grenadeliness" | 17:41 |
lascii | yeah, I missed the mark there | 17:42 |
superdan | heh | 17:42 |
openstackgerrit | Feodor Tersin proposed openstack/nova: libvirt: Fix wrong _is_booted_from_volume usages https://review.openstack.org/334609 | 17:42 |
openstackgerrit | Feodor Tersin proposed openstack/nova: Delete duplicate check when live-migrating https://review.openstack.org/337056 | 17:42 |
openstackgerrit | Feodor Tersin proposed openstack/nova: libvirt: Simplify internal usage of get_instance_disk_info https://review.openstack.org/334901 | 17:42 |
*** rrecio has quit IRC | 17:44 | |
*** ihrachys has quit IRC | 17:46 | |
*** Swami has joined #openstack-nova | 17:46 | |
armax | sdague, superdan: ping re https://review.openstack.org/#/c/351876/ | 17:46 |
armax | anything I can do to help? I am not quite sure I am fully up to speed on the latest eents | 17:46 |
armax | events | 17:46 |
*** oanson has quit IRC | 17:46 | |
*** shaohe_feng has quit IRC | 17:47 | |
superdan | armax: you can abandon | 17:47 |
superdan | armax: I have proper fixes proposed | 17:47 |
superdan | armax: https://review.openstack.org/#/c/353670/ | 17:47 |
armax | superdan: you are indeed super then! it’s not just the nick | 17:47 |
*** shaohe_feng has joined #openstack-nova | 17:47 | |
superdan | armax: only on fridays | 17:48 |
*** zenoway has quit IRC | 17:48 | |
armax | superdan: still, that’s quite a feat! | 17:48 |
superdan | heh | 17:48 |
*** zenoway has joined #openstack-nova | 17:48 | |
*** EinstCrazy has quit IRC | 17:48 | |
kevinbenton | superdan: armax doesn't allow us to have fun nicknames on fridays :( | 17:49 |
kevinbenton | :P | 17:49 |
superdan | kevinbenton: what a tyrant | 17:49 |
armax | me? | 17:49 |
armax | kevinbenton finds every opportunity to be mean to me :’( | 17:49 |
*** tonytan4ever has quit IRC | 17:49 | |
superdan | heh | 17:49 |
*** sdague has quit IRC | 17:51 | |
kevinbenton | superdan: i see here that https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L256-L257 is not privileged if get_client is called | 17:51 |
kevinbenton | do you happen to know if a privileged client is ever passed in? | 17:52 |
superdan | kevinbenton: no, I'd have to grep | 17:52 |
armax | johnthetubaguy: ^ | 17:52 |
armax | johnthetubaguy: I brought in the big guns | 17:52 |
*** zenoway has quit IRC | 17:53 | |
kevinbenton | i can dig into it if nobody knows off the top of their head | 17:53 |
johnthetubaguy | armax: :) | 17:53 |
armax | kevinbenton: see? I am only making compliments | 17:53 |
johnthetubaguy | so I think a privileged client is passed in | 17:53 |
johnthetubaguy | when port_binding is enabled | 17:53 |
johnthetubaguy | but I would have to go double check | 17:53 |
johnthetubaguy | oh wait... its simpler | 17:54 |
*** devananda has quit IRC | 17:54 | |
*** krtaylor has quit IRC | 17:54 | |
kevinbenton | johnthetubaguy: can we always use an unprivileged client in this particular chunk of code? | 17:54 |
johnthetubaguy | hmm, no its not... I was going to say we call it in a periodic task with admin, but I am not sure we hit that side of the else clause in that case | 17:54 |
johnthetubaguy | kevinbenton: so I have a plan to split this into two methods | 17:55 |
johnthetubaguy | kevinbenton: one for when we have a list of net_ids, the other when we don't | 17:55 |
johnthetubaguy | kevinbenton: once we do that, it should be much clearer | 17:55 |
kevinbenton | johnthetubaguy: ok, well the issue is that the net listings should be done as a tenant | 17:55 |
*** sulmer has joined #openstack-nova | 17:55 | |
johnthetubaguy | kevinbenton: so we can't in the periodic task to update the network_info (at the moment, at least) | 17:56 |
johnthetubaguy | kevinbenton: but I think we are really just fetching a specific list in that case, but I could be remembering wrongly | 17:56 |
*** shaohe_feng has quit IRC | 17:57 | |
kevinbenton | johnthetubaguy: if it's fetching IDs, that's cool | 17:57 |
kevinbenton | johnthetubaguy: the problem is that listing networks as an admin doesn't really get you all of the networks that a tenant might be able to access | 17:57 |
johnthetubaguy | kevinbenton: yeah, not 100% on that, will need to trace to double check | 17:57 |
*** shaohe_feng has joined #openstack-nova | 17:57 | |
kevinbenton | johnthetubaguy: RBAC (added in Liberty) allows a network to be shared to a specific tenant | 17:57 |
kevinbenton | johnthetubaguy: and it won't show 'shared' = True to the admin | 17:58 |
johnthetubaguy | kevinbenton: I think if we split that in two, we should be able to list shared and unshared in the single call I guess | 17:58 |
johnthetubaguy | kevinbenton: ah... gotcha | 17:58 |
johnthetubaguy | kevinbenton | 17:58 |
johnthetubaguy | oops | 17:58 |
johnthetubaguy | kevinbenton: I guess we probably shouldn't "fix" that, as it will break existing clients | 17:58 |
johnthetubaguy | knowing it works with the user tenant is good info, we should be able to work with | 17:59 |
kevinbenton | johnthetubaguy: how would it break clients? | 17:59 |
*** oanson has joined #openstack-nova | 17:59 | |
johnthetubaguy | kevinbenton: if they rely on that not returning the shared networks, they will get a nasty surpize | 17:59 |
kevinbenton | johnthetubaguy: but it does return shared networks | 18:00 |
*** sulmer has quit IRC | 18:00 | |
johnthetubaguy | kevinbenton: well, when your not admin only I guess? | 18:00 |
*** lpetrut has quit IRC | 18:00 | |
*** sdague has joined #openstack-nova | 18:00 | |
johnthetubaguy | kevinbenton: I may just be confused, its 7pm on a friday for me | 18:01 |
kevinbenton | johnthetubaguy: sorry, let me clarify. Right now this function is attempting to get all networks a tenant can access, shared and owned by the tenant | 18:01 |
johnthetubaguy | ack | 18:01 |
kevinbenton | johnthetubaguy: but it's doing this with admin creds, so querying on the shared flag won't show ones shared to specific tenants | 18:01 |
*** TRUMP-PENCE has quit IRC | 18:02 | |
*** fragatin_ has quit IRC | 18:02 | |
kevinbenton | johnthetubaguy: however, when a tenant does a net-list, they will see networks shared to them as 'shared', whether it's via RBAC or globally shared | 18:02 |
kevinbenton | johnthetubaguy: so basically right now this method is just missing some networks because it doesn't have the right perspective | 18:02 |
johnthetubaguy | kevinbenton: ah... I missed the RBAC vs global thing | 18:02 |
johnthetubaguy | kevinbenton: if we drop the shared:false flag, would we just get all the shared ones (assuming its not admin with the above bug) | 18:03 |
*** lpetrut has joined #openstack-nova | 18:03 | |
kevinbenton | johnthetubaguy: yep, one single query with the tenant would get you all networks that tenant is allowed to access | 18:03 |
*** TRUMP-PENCE has joined #openstack-nova | 18:03 | |
johnthetubaguy | kevinbenton: awesome, so that does clear things up | 18:03 |
johnthetubaguy | kevinbenton: I am creating a big list of TODOs for next cycle, so this really clears that one up nicely :) | 18:04 |
kevinbenton | johnthetubaguy: cool | 18:04 |
kevinbenton | johnthetubaguy: technically this will even work now if a regular VM boot does these listing operations unprivileged | 18:05 |
johnthetubaguy | kevinbenton: this is the stuff, I will add some comments from your info, so I don't forget them over the weekend! https://review.openstack.org/#/c/353982/ | 18:05 |
johnthetubaguy | kevinbenton: cool, yeah, I hope we can get away with doing just that | 18:05 |
kevinbenton | johnthetubaguy: awesome | 18:06 |
kevinbenton | johnthetubaguy: i always forget about the auto net listing looking for things to latch onto | 18:06 |
*** shaohe_feng has quit IRC | 18:07 | |
johnthetubaguy | kevinbenton: there is always one more thing in that code | 18:07 |
johnthetubaguy | kevinbenton: I added a comment here, for me to tidy up those notes: https://review.openstack.org/#/c/353982/2/specs/ocata/approved/neutron-interaction-refresh-ocata.rst@196 | 18:08 |
*** lpetrut has quit IRC | 18:08 | |
*** shaohe_feng has joined #openstack-nova | 18:08 | |
johnthetubaguy | armax: kevinbenton: thanks for helping clear that up, sounds promising | 18:08 |
kevinbenton | johnthetubaguy: no prob. ultimately i would like to get nova to not use the admin client for anything other than background information refresh like you mentioned | 18:10 |
kevinbenton | johnthetubaguy: and setting port binding details | 18:10 |
johnthetubaguy | kevinbenton: yeah, we might actually be quite close to that already, (kinda by accident) | 18:11 |
johnthetubaguy | kevinbenton: well, we do update_port with the admin client, which does loads of things including port binding, but thats more an efficiency thing | 18:12 |
kevinbenton | excellent. it's just always something that worries me because it means nova has to approximate everything the policy engine in neutron would do | 18:12 |
johnthetubaguy | kevinbenton: +1 | 18:12 |
*** ftersin has left #openstack-nova | 18:13 | |
johnthetubaguy | kevinbenton: we might actually want some observer role for that background refresh, longer term | 18:13 |
*** rama_y has quit IRC | 18:13 | |
*** parora has joined #openstack-nova | 18:14 | |
* johnthetubaguy goes to get some food | 18:14 | |
kevinbenton | johnthetubaguy: yeah, that makes sense | 18:15 |
kevinbenton | johnthetubaguy: also getting good makes sense | 18:15 |
kevinbenton | johnthetubaguy: ttyl :) | 18:15 |
*** baoli has joined #openstack-nova | 18:17 | |
*** shaohe_feng has quit IRC | 18:17 | |
*** prateek_ has quit IRC | 18:18 | |
*** shaohe_feng has joined #openstack-nova | 18:18 | |
*** sdake has joined #openstack-nova | 18:21 | |
*** jichen has joined #openstack-nova | 18:25 | |
*** devananda has joined #openstack-nova | 18:26 | |
openstackgerrit | John Garbutt proposed openstack/nova: Improve help text for interval_opts https://review.openstack.org/331761 | 18:27 |
*** shaohe_feng has quit IRC | 18:28 | |
*** shaohe_feng has joined #openstack-nova | 18:28 | |
*** rlrossit has joined #openstack-nova | 18:30 | |
*** rlrossit has quit IRC | 18:35 | |
*** rlrossit has joined #openstack-nova | 18:37 | |
*** shaohe_feng has quit IRC | 18:38 | |
*** shaohe_feng has joined #openstack-nova | 18:38 | |
*** krtaylor has joined #openstack-nova | 18:39 | |
*** devkulkarni1 has joined #openstack-nova | 18:40 | |
*** amotoki has quit IRC | 18:42 | |
*** rlrossit has quit IRC | 18:42 | |
*** lpetrut has joined #openstack-nova | 18:43 | |
*** lpetrut has quit IRC | 18:43 | |
*** rama_y has joined #openstack-nova | 18:44 | |
*** sdake has quit IRC | 18:45 | |
*** wasmum has quit IRC | 18:47 | |
*** agireud has quit IRC | 18:47 | |
*** shaohe_feng has quit IRC | 18:48 | |
*** sulmer has joined #openstack-nova | 18:48 | |
*** rlrossit_ has joined #openstack-nova | 18:48 | |
*** shaohe_feng has joined #openstack-nova | 18:48 | |
*** wasmum has joined #openstack-nova | 18:49 | |
*** tonytan4ever has joined #openstack-nova | 18:50 | |
mriedem | kevinbenton: neutron midcycle? | 18:53 |
*** mgoddard_ has joined #openstack-nova | 18:54 | |
*** agireud has joined #openstack-nova | 18:55 | |
*** tonytan4ever has quit IRC | 18:55 | |
mriedem | heh ireland next week? | 18:55 |
mriedem | nope | 18:55 |
*** daidv has quit IRC | 18:55 | |
superdan | mriedem: you wanna slam some easy patches for the cells upgrade testing? | 18:56 |
mriedem | like, summer slam? | 18:57 |
mriedem | '95 | 18:57 |
mriedem | ? | 18:57 |
superdan | yes exactly like that | 18:57 |
superdan | https://review.openstack.org/#/c/354261/ | 18:57 |
superdan | although leakypipes still has a -1 on the bottom, but I think he'll probably acquiesce | 18:57 |
mriedem | jaybird is -1 | 18:57 |
*** mgoddard has quit IRC | 18:57 | |
*** shaohe_feng has quit IRC | 18:58 | |
*** shaohe_feng has joined #openstack-nova | 18:59 | |
*** mgoddard_ has quit IRC | 18:59 | |
mriedem | will take a look | 18:59 |
superdan | need to land those before I can hassle sdague about the grenade ones | 18:59 |
sdague | mriedem: ... notable thing, the service catalog 3 card monty trick here does mean we're sending all the same headers to the other services that we would send to nova | 19:00 |
sdague | which, shouldn't be a problem | 19:00 |
sdague | but I did notice the mv headers are there | 19:00 |
mriedem | sdague: you lost me | 19:00 |
mriedem | and have me thinking of mordred | 19:00 |
sdague | no, I'm talking to you | 19:01 |
mriedem | oh the context manager | 19:01 |
sdague | this is the neutron call we make | 19:01 |
sdague | DEBUG (session:337) REQ: curl -g -i -X GET http://10.42.0.53:9696/v2.0/networks?name=private -H "OpenStack-API-Version: compute 2.35" -H "User-Agent: python-novaclient" -H "Accept: application/json" -H "X-OpenStack-Nova-API-Version: 2.35" -H "X-Auth-Token: {SHA1}8510eb704356f855f2c028fdb9b3c5c6dc44da83" | 19:01 |
mriedem | mv = microversion, not move, got it :) | 19:01 |
mriedem | yeah, ok | 19:01 |
sdague | ah, yeh, my bad | 19:01 |
*** fragatina has joined #openstack-nova | 19:01 | |
mriedem | i mean, we could filter those out at some point if we cared | 19:01 |
sdague | right | 19:01 |
sdague | I don't think they matter | 19:01 |
mriedem | shouldn't | 19:02 |
sdague | but I'm at least telling someone else they exist | 19:02 |
sdague | so it's not just a thing I figured out, then forgot later | 19:02 |
mriedem | watch out for buses | 19:02 |
*** fifieldt has quit IRC | 19:03 | |
*** kevinz has joined #openstack-nova | 19:06 | |
openstackgerrit | Sean Dague proposed openstack/python-novaclient: WIP: use neutron for network name -> id resolution https://review.openstack.org/354981 | 19:06 |
sdague | mriedem: ok, that's the possitive through case for network lookup | 19:07 |
sdague | it needs the version switching logic | 19:07 |
*** krtaylor has quit IRC | 19:07 | |
sdague | but that seems to work fine on my devstack | 19:07 |
mriedem | superdan: lascii: leakypipes: comments inline https://review.openstack.org/#/c/354261/ | 19:08 |
mriedem | it's ok, but some usability comments inline | 19:08 |
*** krtaylor has joined #openstack-nova | 19:08 | |
*** shaohe_feng has quit IRC | 19:09 | |
superdan | mriedem: thanks.. what's the translation policy? not everything in that file is marked | 19:09 |
*** code-R has joined #openstack-nova | 19:09 | |
superdan | so I assumed not | 19:09 |
*** shaohe_feng has joined #openstack-nova | 19:09 | |
*** tonytan4ever has joined #openstack-nova | 19:10 | |
mriedem | it's user facing so i assume it's supposed to be translated | 19:10 |
*** code-R_ has joined #openstack-nova | 19:10 | |
*** kevinz has quit IRC | 19:11 | |
superdan | it's not really intended to be, but fine | 19:13 |
*** code-R has quit IRC | 19:13 | |
mriedem | i'm not -1 on that | 19:14 |
mriedem | was just saing | 19:14 |
openstackgerrit | Andreas Jaeger proposed openstack/python-novaclient: Move other-requirements.txt to bindep.txt https://review.openstack.org/355014 | 19:14 |
mriedem | *saying | 19:14 |
superdan | yeah, it's fine I just didn't know | 19:14 |
*** sulmer has quit IRC | 19:15 | |
*** sulmer has joined #openstack-nova | 19:15 | |
cfriesen_ | does anyone know what the situation is with cpu hotplug for x86-64 in qemu? | 19:16 |
cfriesen_ | I suppose that's offtopic, so never mind. :) | 19:17 |
*** raunak has quit IRC | 19:17 | |
*** fifieldt has joined #openstack-nova | 19:18 | |
*** shaohe_feng has quit IRC | 19:19 | |
*** shaohe_feng has joined #openstack-nova | 19:20 | |
sdague | mriedem: does the net-name currently work with neutron backends? | 19:24 |
mriedem | yeah | 19:24 |
sdague | ah, I lost a return | 19:27 |
sdague | my bad | 19:27 |
*** thorst_ has quit IRC | 19:27 | |
superdan | sdague: I know you're busy but if you could skim those grenade patches for obvious "I will never let you do this" things I'd appreciate it | 19:27 |
*** devkulkarni2 has joined #openstack-nova | 19:28 | |
superdan | mriedem: I was doing that thing you just said | 19:28 |
openstackgerrit | Dan Smith proposed openstack/nova: Make simple_cell_setup idempotent https://review.openstack.org/354734 | 19:28 |
openstackgerrit | Dan Smith proposed openstack/nova: Add cell_v2 verify_instance command https://review.openstack.org/354261 | 19:28 |
*** fragatina has quit IRC | 19:28 | |
superdan | which is here ^ | 19:28 |
*** devkulkarni1 has quit IRC | 19:29 | |
*** fragatina has joined #openstack-nova | 19:29 | |
*** fragatina has quit IRC | 19:29 | |
openstackgerrit | Sean Dague proposed openstack/python-novaclient: WIP: use neutron for network name -> id resolution https://review.openstack.org/354981 | 19:29 |
*** shaohe_feng has quit IRC | 19:29 | |
sdague | superdan: yeh, I think I got that novaclient stuff as far as I'm going today | 19:29 |
sdague | mriedem: the novaclient patch there has things working for real, I'm sure it blows unit tests all over the place | 19:30 |
superdan | sdague: okay, starts here: https://review.openstack.org/#/c/354264/ | 19:30 |
*** shaohe_feng has joined #openstack-nova | 19:30 | |
mriedem | sdague: yeah i'll pick it up from here | 19:30 |
mriedem | thanks | 19:30 |
superdan | sdague: mriedem, lascii, and leakypipes are beating me up over the nova manage thing you made me add, in case it gets me any sympathy points | 19:30 |
lascii | I prefer to call it "polishing" | 19:31 |
superdan | well, it does involve rubbing | 19:32 |
mriedem | tsk tsk | 19:32 |
mriedem | alignment brotha | 19:32 |
superdan | wat | 19:32 |
superdan | gah | 19:33 |
openstackgerrit | Dan Smith proposed openstack/nova: Make simple_cell_setup idempotent https://review.openstack.org/354734 | 19:33 |
superdan | shit | 19:33 |
sdague | superdan: ok, patch one seems functionally fine. I think we should just make sure that pre/post is the names we want to live forever as this is pretty static interface. (I'm wondering if old/new or base/target are better / worse given existing terminology) | 19:34 |
mriedem | we could also validate the uuid is a uuid, but i'm really nit picking now | 19:34 |
sdague | https://review.openstack.org/#/c/354265/7/projects/60_nova/upgrade.sh ... | 19:34 |
sdague | the create_cell function has be worried | 19:34 |
sdague | that a nova-manage command? | 19:34 |
openstackgerrit | Dan Smith proposed openstack/nova: Make simple_cell_setup idempotent https://review.openstack.org/354734 | 19:34 |
openstackgerrit | Dan Smith proposed openstack/nova: Add cell_v2 verify_instance command https://review.openstack.org/354261 | 19:34 |
superdan | sdague: no that's in lascii's devstack patch | 19:34 |
lascii | https://review.openstack.org/#/c/322311/4/lib/nova | 19:34 |
superdan | sdague: also, the logs show it works properly, just FYI | 19:35 |
superdan | sdague: fine if you want to nit over pre/post, just tell me what to make them | 19:35 |
sdague | ok, I would rather put that nova-manage command inline in grenade | 19:35 |
superdan | sdague: really? I had it that way and was SURE you'd make me change it :) | 19:35 |
*** thorst_ has joined #openstack-nova | 19:35 | |
sdague | no, on the upgrade side I really want things explicit for everything except start | 19:36 |
superdan | okay | 19:36 |
*** devkulkarni2 has quit IRC | 19:37 | |
sdague | the upgrade scripts try to be as unbound to devstack as we can, so that other tools can glean what we are doing for upgrade more easily | 19:37 |
superdan | sdague: this sets off a big set of dependent patches when I push, so.. tell me what you want the pre/post to be and I'll push it | 19:37 |
*** devkulkarni1 has joined #openstack-nova | 19:38 | |
superdan | base/target? | 19:38 |
sdague | yeh, give me a sec, I saw these for the first time in code 5 minutes ago :) | 19:38 |
superdan | I demand an answer now | 19:38 |
*** shaohe_feng has quit IRC | 19:39 | |
sdague | ok, how about we go for explicit and do pre-upgrade / post-upgrade, which means if we need to add other phases later we're not doing things like pre-pre | 19:40 |
*** shaohe_feng has joined #openstack-nova | 19:40 | |
superdan | okay | 19:40 |
*** thorst_ has quit IRC | 19:40 | |
sdague | so, if you do that change, and unwind the create_cell call in the grenade script, I'm good with those 2 | 19:40 |
sdague | and will +2 them | 19:41 |
superdan | moments | 19:41 |
*** oanson has quit IRC | 19:41 | |
*** sulmer has quit IRC | 19:41 | |
*** devkulkarni1 has quit IRC | 19:41 | |
*** devkulkarni1 has joined #openstack-nova | 19:41 | |
*** sulmer has joined #openstack-nova | 19:41 | |
superdan | sdague: done.. you don't have to +2 now, I just wanted some early smoke signals | 19:43 |
superdan | we have to land the two (tiny) nova patches first anyway | 19:43 |
*** sulmer has quit IRC | 19:46 | |
*** matrohon has joined #openstack-nova | 19:49 | |
*** liusheng has quit IRC | 19:50 | |
*** shaohe_feng has quit IRC | 19:50 | |
*** sulmer has joined #openstack-nova | 19:50 | |
*** liusheng has joined #openstack-nova | 19:50 | |
*** shaohe_feng has joined #openstack-nova | 19:50 | |
*** Apoorva has quit IRC | 19:52 | |
mriedem | i'm +2 on the bottom nova change | 19:53 |
*** mvk has quit IRC | 19:54 | |
superdan | thanks | 19:56 |
*** niloofar has joined #openstack-nova | 19:56 | |
niloofar | Hi all | 19:57 |
niloofar | Is anyone know How can I stop nova from writing log to local disk? | 19:57 |
niloofar | I have rsylog server setup, and I dont like to keep the log on local server | 19:58 |
*** gouthamr has quit IRC | 19:59 | |
*** shaohe_feng has quit IRC | 20:00 | |
parora | niloofar, you could try changing the log file destination in the nova.conf | 20:00 |
*** shaohe_feng has joined #openstack-nova | 20:01 | |
niloofar | but it will still in local disk | 20:01 |
sdague | mriedem: ok, I'm fading out for the week. I'll look back in the state of patches on monday, and see where we are at from getting this stuff landed. | 20:01 |
*** devkulkarni1 has quit IRC | 20:01 | |
mriedem | yup i just pulled it down | 20:01 |
mriedem | will hack on this a bit | 20:01 |
niloofar | I like to log written locally on the server | 20:01 |
parora | niloofar, how about putting it as /dev/null | 20:01 |
parora | ? | 20:01 |
superdan | sdague: thanks for hitting those | 20:01 |
openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Improve help text for compute manager options https://review.openstack.org/329639 | 20:02 |
niloofar | you mean in nova.conf for log path I change it to logdir=/dev/null ? | 20:03 |
parora | niloofar, yeah, try it on a test server first but redirecting your logs to /dev/null should leave you log less | 20:04 |
*** mnestratov has quit IRC | 20:04 | |
niloofar | Thank you very much, I will git it atry | 20:04 |
parora | niloofar, ywc | 20:04 |
*** raunak has joined #openstack-nova | 20:05 | |
mriedem | mordred: did you say that you can get network details in neutron via name or id? | 20:05 |
mriedem | mordred: was wondering if we can just do a /networks/name here https://review.openstack.org/#/c/354981/2/novaclient/v2/networks.py@54 | 20:06 |
* mordred looks | 20:06 | |
parora | oomichi, can you please look into https://review.openstack.org/#/c/327706/ when you have time, i have tried to address your review comments | 20:06 |
niloofar | I just tried | 20:07 |
niloofar | I changed logdir tp /var/null | 20:07 |
niloofar | I restarted my nova-compute few times | 20:07 |
parora | */dev/null | 20:07 |
niloofar | sorry typo I meant /dev/null | 20:08 |
*** xyang1 has quit IRC | 20:08 | |
niloofar | but I still see the logs | 20:08 |
niloofar | any idea? | 20:09 |
mriedem | niloofar: so, this isn't a support channel | 20:10 |
mriedem | niloofar: these are questions better asked in the #openstack channel, or ask.openstack.org, or the general openstack mailing list | 20:10 |
*** shaohe_feng has quit IRC | 20:10 | |
*** shaohe_feng has joined #openstack-nova | 20:11 | |
niloofar | I see, I already ask there as well | 20:11 |
niloofar | I was hopping there is a setting I can use in nova.conf file | 20:12 |
niloofar | which a developer might know | 20:12 |
openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Removing duplicates from columns_to_join list https://review.openstack.org/342299 | 20:15 |
*** lpetrut has joined #openstack-nova | 20:16 | |
mordred | mriedem: hrm. I apparently may have lied - it seems possible now that the magic happens in neutronclient | 20:16 |
mordred | mriedem: I just did some testing using a direct requests session | 20:16 |
mriedem | ok | 20:17 |
mordred | >>> c.get('/v2.0/networks/6d6357ac-0f70-4afa-8bd7-c274cc4ea235').json() | 20:17 |
mordred | works | 20:17 |
mordred | >>> c.get('/v2.0/networks?name=public').json() | 20:17 |
mordred | works | 20:17 |
mordred | but >>> c.get('/v2.0/networks?name=6d6357ac-0f70-4afa-8bd7-c274cc4ea235').json() | 20:17 |
mordred | returns [] | 20:17 |
*** gouthamr has joined #openstack-nova | 20:17 | |
mordred | as does >>> c.get('/v2.0/networks?id=public').json() | 20:18 |
mordred | so - sorry for the misinformation | 20:18 |
*** shaohe_feng has quit IRC | 20:20 | |
*** shaohe_feng has joined #openstack-nova | 20:21 | |
*** xyang1 has joined #openstack-nova | 20:22 | |
mriedem | np, thanks for looking it up for me :) | 20:23 |
mriedem | i'm lazy | 20:23 |
superdan | mordred: you can read that as "I never trust anything you say so I am not surprised" | 20:24 |
* superdan decodes mriedem speak for a small fee | 20:24 | |
*** yamahata has quit IRC | 20:25 | |
mordred | superdan: :) | 20:26 |
*** tri2sing has quit IRC | 20:26 | |
mordred | superdan: to be clear, I also never trust anything I say | 20:26 |
mordred | it's one of the topics on which mriedem and I agree | 20:26 |
superdan | heh | 20:27 |
*** Apoorva has joined #openstack-nova | 20:27 | |
*** shaohe_feng has quit IRC | 20:31 | |
*** shaohe_feng has joined #openstack-nova | 20:31 | |
*** sdake has joined #openstack-nova | 20:32 | |
*** ihrachys has joined #openstack-nova | 20:33 | |
*** niloofar has quit IRC | 20:39 | |
*** haplo37_ has joined #openstack-nova | 20:39 | |
*** shaohe_feng has quit IRC | 20:41 | |
*** shaohe_feng has joined #openstack-nova | 20:42 | |
*** parora has quit IRC | 20:42 | |
openstackgerrit | jichenjc proposed openstack/nova: not use cert and private key in glance client https://review.openstack.org/354706 | 20:42 |
*** mingyu has joined #openstack-nova | 20:43 | |
*** tblakes has quit IRC | 20:44 | |
*** rfolco has quit IRC | 20:46 | |
*** mingyu has quit IRC | 20:47 | |
*** agireud has quit IRC | 20:48 | |
*** jichen has quit IRC | 20:49 | |
-openstackstatus- NOTICE: The Gerrit service on review.openstack.org is restarting for a scheduled upgrade, but should return to service momentarily: http://lists.openstack.org/pipermail/openstack-dev/2016-August/101394.html | 20:50 | |
*** shaohe_feng has quit IRC | 20:51 | |
mriedem | wtf, where is nova.network.model.Route.interface set? | 20:51 |
mriedem | for ovs runs? | 20:51 |
*** oomichi has quit IRC | 20:51 | |
*** oomichi has joined #openstack-nova | 20:52 | |
*** shaohe_feng has joined #openstack-nova | 20:52 | |
openstackgerrit | Michael Glaser proposed openstack/nova: Check opt consistency for neutron.py https://review.openstack.org/349605 | 20:53 |
*** agireud has joined #openstack-nova | 20:55 | |
*** gouthamr has quit IRC | 20:58 | |
*** ducttape_ has quit IRC | 20:58 | |
-openstackstatus- NOTICE: The Mediawiki service at wiki.openstack.org will be offline from 21:00 UTC until approximately 23:00 UTC for a planned upgrade http://lists.openstack.org/pipermail/openstack-dev/2016-August/101395.html | 20:58 | |
*** ChanServ changes topic to "The Mediawiki service at wiki.openstack.org will be offline from 21:00 UTC until approximately 23:00 UTC for a planned upgrade http://lists.openstack.org/pipermail/openstack-dev/2016-August/101395.html" | 20:58 | |
*** shaohe_feng has quit IRC | 21:01 | |
mriedem | sean-k-mooney: leakypipes: you around? | 21:02 |
*** shaohe_feng has joined #openstack-nova | 21:02 | |
mriedem | we're blowing up on not setting this in the os-vif code in nova https://github.com/openstack/os-vif/blob/master/os_vif/objects/route.py#L28 | 21:03 |
mriedem | https://bugs.launchpad.net/nova/+bug/1612812 | 21:03 |
openstack | Launchpad bug 1612812 in OpenStack Compute (nova) "OS-VIF: Interface missing from Route Object. (OVS)" [Undecided,New] | 21:03 |
*** burgerk has quit IRC | 21:03 | |
patrickeast | mriedem: hey, i added a comment on https://review.openstack.org/#/c/354502/ about the os-brick lock dir thingy | 21:03 |
mriedem | for neutron the route gets added here https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L2158 | 21:03 |
mriedem | but interface isn't set | 21:04 |
patrickeast | mriedem: let me know what you'd like to have happen there, where its more info or a bug or whatever | 21:04 |
mriedem | https://github.com/openstack/nova/blob/master/nova/network/model.py#L223 | 21:04 |
mriedem | set on the os-vif route object here https://github.com/openstack/nova/blob/master/nova/network/os_vif_util.py#L139 | 21:04 |
mriedem | but we don't ever set nova.network.model.Route.interface anywhere in nova | 21:04 |
mriedem | AND | 21:04 |
mriedem | i don't see anything in the neutron data model for Route.interface | 21:04 |
mriedem | https://github.com/openstack/neutron/blob/master/neutron/objects/subnet.py#L67 | 21:05 |
mriedem | armax: HenryG: ^ | 21:05 |
mriedem | am i missing something? | 21:05 |
doffm | os-vif object with presumably non-optional interface field here https://github.com/openstack/os-vif/blob/master/os_vif/objects/route.py#L28 | 21:05 |
mriedem | or was Route.interface just added to nova's nw model but never used? | 21:05 |
mriedem | apparently we don't fail on this in the openstack CI b/c we aren't using subnets with routes | 21:06 |
mriedem | http://logs.openstack.org/99/340599/2/gate/gate-tempest-dsvm-neutron-full-ubuntu-xenial/3128550/logs/screen-n-cpu.txt.gz#_2016-08-12_17_08_55_248 | 21:06 |
mriedem | 'routes': [] | 21:06 |
*** lpetrut has quit IRC | 21:07 | |
*** pwnall has quit IRC | 21:07 | |
mriedem | so looks to me like a lie was propagated to os-vif | 21:07 |
mriedem | and the interface field should be nullable=True | 21:07 |
* mriedem wishes some os-vif peeps were around | 21:08 | |
*** pwnall has joined #openstack-nova | 21:08 | |
*** pwnall1 has joined #openstack-nova | 21:10 | |
*** pwnall has quit IRC | 21:10 | |
*** fragatina has joined #openstack-nova | 21:11 | |
*** shaohe_feng has quit IRC | 21:12 | |
*** shaohe_feng has joined #openstack-nova | 21:12 | |
*** rfolco has joined #openstack-nova | 21:16 | |
*** tblakes has joined #openstack-nova | 21:16 | |
*** yamahata has joined #openstack-nova | 21:16 | |
*** rfolco has quit IRC | 21:16 | |
*** rlrossit_ has quit IRC | 21:16 | |
openstackgerrit | Alberto Murillo proposed openstack/nova: linux_net.py adds --addn-hosts parameter to dnsmasq when using nova network in multi_host mode. https://review.openstack.org/210627 | 21:18 |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient: Use neutron for network name -> id resolution https://review.openstack.org/354981 | 21:18 |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient: Look up image names directly in glance https://review.openstack.org/354349 | 21:18 |
*** fragatina has quit IRC | 21:19 | |
*** sulmer has quit IRC | 21:21 | |
*** edmondsw has quit IRC | 21:22 | |
*** shaohe_feng has quit IRC | 21:22 | |
*** shaohe_feng has joined #openstack-nova | 21:23 | |
*** sdake has quit IRC | 21:23 | |
*** lascii is now known as alaski | 21:23 | |
*** lpetrut has joined #openstack-nova | 21:27 | |
*** oomichi has quit IRC | 21:28 | |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient: Use neutron for network name -> id resolution https://review.openstack.org/354981 | 21:28 |
*** oomichi has joined #openstack-nova | 21:29 | |
*** dimtruck is now known as zz_dimtruck | 21:29 | |
*** tonytan4ever has quit IRC | 21:30 | |
*** rama_y has quit IRC | 21:31 | |
*** Hosam has joined #openstack-nova | 21:32 | |
*** shaohe_feng has quit IRC | 21:32 | |
*** shaohe_feng has joined #openstack-nova | 21:32 | |
openstackgerrit | melanie witt proposed openstack/nova: Make req spec and RT aware of volume-backed instances https://review.openstack.org/355091 | 21:34 |
*** leakypipes has quit IRC | 21:34 | |
openstackgerrit | Matt Riedemann proposed openstack/os-vif: Make Route.interface nullable https://review.openstack.org/355093 | 21:35 |
mriedem | sean-k-mooney: ^ | 21:35 |
armax | mriedem: what are you missing in the RouterInterface model? | 21:39 |
*** ihrachys has quit IRC | 21:39 | |
mriedem | armax: this is Route.interface | 21:40 |
mriedem | subnet.host_routes | 21:40 |
mriedem | is a list of routes | 21:40 |
mriedem | but there is no 'interface' field on those routes | 21:40 |
mriedem | but nova's nw info model assumes there is | 21:40 |
mriedem | and os-vif expects it to be non-None | 21:40 |
mriedem | https://github.com/openstack/os-vif/blob/master/os_vif/objects/route.py#L28 is non-nullable | 21:40 |
armax | um | 21:40 |
mriedem | nova sets it here https://github.com/openstack/nova/blob/master/nova/network/os_vif_util.py#L139 | 21:41 |
*** jamesdenton has quit IRC | 21:41 | |
mriedem | but nova net sets that field https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L2158 | 21:41 |
armax | we never had an interface attribute on router interfaces | 21:41 |
mriedem | so it's always None | 21:41 |
mriedem | armax: ha, yeah :) | 21:41 |
armax | ever | 21:41 |
mriedem | cool | 21:41 |
mriedem | can you ack that os-vif patch? | 21:41 |
mriedem | i'm doing a workaround in nova for now | 21:41 |
* armax checks | 21:41 | |
mriedem | maybe some out of tree enablement BS at some point | 21:41 |
mriedem | or another bp that never materialized | 21:42 |
mriedem | but if you have a subnet with host_routes set, you're busted right now | 21:42 |
*** gszasz has quit IRC | 21:42 | |
armax | question is | 21:42 |
armax | do you think we should have one? | 21:42 |
*** shaohe_feng has quit IRC | 21:42 | |
*** lpetrut has quit IRC | 21:42 | |
*** shaohe_feng has joined #openstack-nova | 21:43 | |
mriedem | no | 21:43 |
mriedem | well, nova never tries to set one | 21:43 |
*** Hosam_ has joined #openstack-nova | 21:43 | |
mriedem | superdan: field=None isn't the same as field not set right? | 21:43 |
mriedem | so if i want to avoid "ValueError: Fieldinterface' cannot be None" i can just not set the field, right? | 21:44 |
superdan | mriedem: correct, field=None is "set..to None" | 21:44 |
superdan | mriedem: you can yes | 21:44 |
mriedem | ok | 21:44 |
armax | mriedem: are you sure you don’t want to use the interface field to carry over a port id or a subnet id? | 21:44 |
doffm | interface="FIXME:Workaround" | 21:44 |
armax | mriedem: but to be fair | 21:44 |
armax | mriedem: if you do do need that, you’d rather name it after what’s exposed by neutron no? | 21:45 |
*** sameo_ has joined #openstack-nova | 21:45 | |
*** Hosam has quit IRC | 21:46 | |
*** sameo has quit IRC | 21:46 | |
*** Hosam has joined #openstack-nova | 21:46 | |
*** jistr has quit IRC | 21:47 | |
mriedem | armax: i don't know we'd all of a sudden need a thing that's never been set in nova before | 21:48 |
mriedem | and isn't modeled in neutron, at least not in that way | 21:48 |
armax | mriedem: agreed | 21:48 |
*** fragatina has joined #openstack-nova | 21:48 | |
*** fragatina has quit IRC | 21:50 | |
*** Hosam_ has quit IRC | 21:50 | |
openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Api-ref: Improve os-migrateLive input parameters https://review.openstack.org/345652 | 21:50 |
*** haplo37_ has quit IRC | 21:50 | |
*** fragatina has joined #openstack-nova | 21:50 | |
*** jistr has joined #openstack-nova | 21:51 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: os-vif: do not set Route.interface if None https://review.openstack.org/355098 | 21:51 |
mriedem | superdan: alaski: melwitt: can you take a quick look at ^ please? this is blowing up our preprod cloud internally, it's pretty obviously wrong | 21:51 |
mriedem | i'd bug danpb or jaypipes but they aren't around | 21:52 |
melwitt | sure | 21:52 |
*** xyang1 has quit IRC | 21:52 | |
*** shaohe_feng has quit IRC | 21:53 | |
superdan | mriedem: seems like you're not testing that path | 21:53 |
*** shaohe_feng has joined #openstack-nova | 21:53 | |
mriedem | which one? | 21:54 |
*** thorst_ has joined #openstack-nova | 21:54 | |
superdan | the "if is None" pth | 21:54 |
mriedem | it does here https://review.openstack.org/#/c/355098/1/nova/tests/unit/network/test_os_vif_util.py | 21:55 |
superdan | and I'm not sure why you're removing that interface | 21:55 |
mriedem | nova.network.model.Route defaults interface to None | 21:55 |
superdan | oh I see | 21:55 |
mriedem | test_nova_to_osvif_routes tests with 2 routes, one set and one not | 21:55 |
mriedem | setting it to None is the bug | 21:55 |
superdan | okay | 21:55 |
mriedem | also, os-vif doesn't use the Route.interface anywhere either | 21:55 |
mriedem | so it's just totally vestigial | 21:55 |
mriedem | i didn't want to remoe the nova.network.model stuff until danpb could confirm that on monday though | 21:56 |
mriedem | hence the FIXME | 21:56 |
superdan | yeah | 21:56 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Change hypervisor_type to actual value https://review.openstack.org/355099 | 21:56 |
alaski | looks like melwitt and superdan are on it, but I can ack if needed. The patch looks reasonable to me | 21:57 |
mriedem | thanks, i have to head out to get maya | 21:58 |
mriedem | i'll get https://review.openstack.org/#/c/354734/ later tonight | 21:59 |
*** mriedem has quit IRC | 21:59 | |
*** tanvirt has quit IRC | 21:59 | |
*** pradk has quit IRC | 22:00 | |
*** ijw has joined #openstack-nova | 22:00 | |
*** jistr has quit IRC | 22:00 | |
*** Hosam has quit IRC | 22:02 | |
*** shaohe_feng has quit IRC | 22:03 | |
*** shaohe_feng has joined #openstack-nova | 22:04 | |
openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Api-ref: Improve os-migrateLive input parameters https://review.openstack.org/345652 | 22:05 |
openstackgerrit | melanie witt proposed openstack/nova: Make req spec and RT aware of volume-backed instances https://review.openstack.org/355091 | 22:06 |
*** ducttape_ has joined #openstack-nova | 22:07 | |
*** sdague has quit IRC | 22:07 | |
*** jistr has joined #openstack-nova | 22:09 | |
*** tomaz_ has quit IRC | 22:10 | |
*** mdrabe has quit IRC | 22:11 | |
*** beekneemech is now known as bnemec-pto | 22:12 | |
*** shaohe_feng has quit IRC | 22:13 | |
*** cdent has quit IRC | 22:13 | |
*** shaohe_feng has joined #openstack-nova | 22:14 | |
*** kylek3h has quit IRC | 22:16 | |
*** jistr has quit IRC | 22:19 | |
*** TravT has quit IRC | 22:21 | |
*** tblakes has quit IRC | 22:21 | |
*** shaohe_feng has quit IRC | 22:23 | |
*** tonytan4ever has joined #openstack-nova | 22:25 | |
*** TravT has joined #openstack-nova | 22:25 | |
*** jistr has joined #openstack-nova | 22:25 | |
*** shaohe_feng has joined #openstack-nova | 22:26 | |
*** rama_y has joined #openstack-nova | 22:27 | |
*** ijw has quit IRC | 22:28 | |
*** shaohe_feng has quit IRC | 22:34 | |
*** shaohe_feng has joined #openstack-nova | 22:34 | |
*** ducttape_ has quit IRC | 22:35 | |
*** ducttape_ has joined #openstack-nova | 22:36 | |
*** armax has quit IRC | 22:40 | |
*** ducttape_ has quit IRC | 22:40 | |
*** palexster has quit IRC | 22:42 | |
*** annegentle has quit IRC | 22:43 | |
*** shaohe_feng has quit IRC | 22:44 | |
*** shaohe_feng has joined #openstack-nova | 22:44 | |
*** code-R_ has quit IRC | 22:50 | |
*** markvoelker has quit IRC | 22:53 | |
*** shaohe_feng has quit IRC | 22:54 | |
*** shaohe_feng has joined #openstack-nova | 22:54 | |
*** figleaf is now known as edleafe | 22:56 | |
-openstackstatus- NOTICE: ok https://wiki.openstack.org/ is now running Mediawiki 1.27.0; please let us know in #openstack-infra if anything seems wrong | 23:00 | |
*** ChanServ changes topic to "ok https://wiki.openstack.org/ is now running Mediawiki 1.27.0; please let us know in #openstack-infra if anything seems wrong" | 23:00 | |
*** vishwanathj has quit IRC | 23:02 | |
*** armax has joined #openstack-nova | 23:04 | |
*** shaohe_feng has quit IRC | 23:04 | |
*** shaohe_feng has joined #openstack-nova | 23:05 | |
*** ChanServ changes topic to "This channel is for Nova development. For support of Nova deployments, please use #openstack. Please see: https://wiki.openstack.org/wiki/Nova/Newton_Release_Schedule" | 23:06 | |
-openstackstatus- NOTICE: https://wiki.openstack.org/ is now running Mediawiki 1.27.0; please let us know in #openstack-infra if anything seems wrong | 23:06 | |
*** jlk has joined #openstack-nova | 23:11 | |
*** sameo_ has quit IRC | 23:12 | |
*** sameo has joined #openstack-nova | 23:12 | |
*** shaohe_feng has quit IRC | 23:15 | |
*** shaohe_feng has joined #openstack-nova | 23:15 | |
jlk | How crazy would I be to try to implement my own scheduler_driver that would sit above the filter_scheduler in order to send some requests through the regular host_manager and other requests through the ironic host manager? (obviously with different filters used in each of those managers). | 23:15 |
jlk | I'm trying to figure out a way to implement VMs and bare metal in the same cloud without going cells v1 | 23:15 |
*** thorst_ has quit IRC | 23:17 | |
*** shaohe_feng has quit IRC | 23:25 | |
*** shaohe_feng has joined #openstack-nova | 23:25 | |
*** thorst_ has joined #openstack-nova | 23:26 | |
*** jwcroppe has joined #openstack-nova | 23:26 | |
*** thorst_ has quit IRC | 23:30 | |
*** rrecio_ has quit IRC | 23:31 | |
*** raunak has quit IRC | 23:32 | |
*** rama_y has quit IRC | 23:33 | |
*** sdake has joined #openstack-nova | 23:33 | |
*** rama_y has joined #openstack-nova | 23:33 | |
*** ijw has joined #openstack-nova | 23:34 | |
*** shaohe_feng has quit IRC | 23:35 | |
*** shaohe_feng has joined #openstack-nova | 23:36 | |
*** ijw has quit IRC | 23:41 | |
*** agireud has quit IRC | 23:44 | |
*** shaohe_feng has quit IRC | 23:45 | |
*** ijw has joined #openstack-nova | 23:46 | |
*** shaohe_feng has joined #openstack-nova | 23:46 | |
*** rama_y has quit IRC | 23:47 | |
stewie925 | hey guys, can anyone share how to do gerrit search on a file path like 'nova/conf/xenserver.py'? | 23:50 |
*** ducttape_ has joined #openstack-nova | 23:53 | |
*** agireud has joined #openstack-nova | 23:53 | |
*** markvoelker has joined #openstack-nova | 23:54 | |
*** Swami has quit IRC | 23:55 | |
*** shaohe_feng has quit IRC | 23:56 | |
raj_singh | stewie925: https://review.openstack.org/#/q/project:openstack/nova+file:xenserver.py+status:open refer this | 23:56 |
*** baoli has quit IRC | 23:56 | |
*** shaohe_feng has joined #openstack-nova | 23:57 | |
stewie925 | nahh that wouldnt work | 23:57 |
stewie925 | but yes Ive tried that | 23:57 |
stewie925 | so far the only one that works is using a partial regex like "file:^.*/conf/xenserver.py" | 23:57 |
stewie925 | but its okay, I'll try asking in the gerrit room on Monday | 23:58 |
stewie925 | raj_singh: but thanks :) | 23:58 |
*** markvoelker has quit IRC | 23:59 | |
*** gouthamr has joined #openstack-nova | 23:59 | |
*** yamahata has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!