Monday, 2016-08-15

*** ducttape_ has quit IRC00:00
*** thorst_ has joined #openstack-nova00:00
*** hoangcx2 has joined #openstack-nova00:01
*** raunak has quit IRC00:03
*** baoli has quit IRC00:04
*** raunak has joined #openstack-nova00:05
*** hoangcx has quit IRC00:05
*** shaohe_feng has quit IRC00:06
*** shaohe_feng has joined #openstack-nova00:07
*** thorst_ has quit IRC00:09
*** thorst_ has joined #openstack-nova00:10
*** baoli has joined #openstack-nova00:12
*** shaohe_feng has quit IRC00:16
*** shaohe_feng has joined #openstack-nova00:17
*** thorst_ has quit IRC00:19
*** su_zhang has joined #openstack-nova00:22
*** jwcroppe has joined #openstack-nova00:23
*** shaohe_feng has quit IRC00:27
*** shaohe_feng has joined #openstack-nova00:28
*** jwcroppe has quit IRC00:28
openstackgerritLi Yingjun proposed openstack/nova: Adds view builders for hypervisors controller  https://review.openstack.org/33528200:31
*** thorst_ has joined #openstack-nova00:34
*** raunak has quit IRC00:37
*** shaohe_feng has quit IRC00:37
*** shaohe_feng has joined #openstack-nova00:38
*** thorst_ has quit IRC00:39
*** mingyu has joined #openstack-nova00:42
*** mingyu has quit IRC00:46
*** shaohe_feng has quit IRC00:47
*** shaohe_feng has joined #openstack-nova00:48
*** greghaynes has quit IRC00:48
*** greghaynes has joined #openstack-nova00:49
*** thorst_ has joined #openstack-nova00:53
*** thorst_ has quit IRC00:53
*** hoangcx has joined #openstack-nova00:54
*** shaohe_feng has quit IRC00:57
openstackgerritMatt Riedemann proposed openstack/python-novaclient: WIP: Skip nova-network-only tests if using Neutron  https://review.openstack.org/35521500:58
*** mriedem has quit IRC00:58
*** shaohe_feng has joined #openstack-nova00:58
*** cheneydc has joined #openstack-nova00:59
*** ducttape_ has joined #openstack-nova01:01
*** bswartz has joined #openstack-nova01:02
*** cheneydc has quit IRC01:05
*** ducttape_ has quit IRC01:05
*** shaohe_feng has quit IRC01:08
*** shaohe_feng has joined #openstack-nova01:08
*** smatzek has joined #openstack-nova01:09
*** lixiaoy1 has quit IRC01:10
*** bswartz has quit IRC01:13
*** zhangjl has joined #openstack-nova01:14
*** zhangjl has left #openstack-nova01:14
*** su_zhang has quit IRC01:17
*** su_zhang has joined #openstack-nova01:17
*** shaohe_feng has quit IRC01:18
openstackgerritTakashi NATSUME proposed openstack/nova-specs: Fix Newton approved specs list  https://review.openstack.org/33530601:18
*** shaohe_feng has joined #openstack-nova01:18
openstackgerritTakashi NATSUME proposed openstack/nova-specs: Fix blueprints and specs link in ocata template  https://review.openstack.org/33531201:18
*** lixiaoy1 has joined #openstack-nova01:19
*** takashin has joined #openstack-nova01:19
*** mingyu has joined #openstack-nova01:20
*** EinstCrazy has joined #openstack-nova01:23
*** kevinz has joined #openstack-nova01:27
*** shaohe_feng has quit IRC01:28
*** shaohe_feng has joined #openstack-nova01:31
*** ljxiash has joined #openstack-nova01:32
openstackgerritTakashi NATSUME proposed openstack/nova: Add a hacking rule for string interpolation at logging  https://review.openstack.org/33484401:32
openstackgerritTakashi NATSUME proposed openstack/nova-specs: Abort Cold Migration  https://review.openstack.org/33473201:33
openstackgerritTakashi NATSUME proposed openstack/nova-specs: Add swap volume notifications  https://review.openstack.org/34071501:33
openstackgerritTakashi NATSUME proposed openstack/nova-specs: Enable cold migration with target host  https://review.openstack.org/33428601:33
openstackgerritTakashi NATSUME proposed openstack/nova-specs: Check the destination host in cold migration  https://review.openstack.org/33472501:34
openstackgerritTakashi NATSUME proposed openstack/nova: Fix an error in archiving 'migrations' table  https://review.openstack.org/32368401:34
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Fix wrong parameters in os-volumes.inc  https://review.openstack.org/34711201:34
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Fix 'id' (attachment_id) parameters  https://review.openstack.org/34986301:34
openstackgerritTakashi NATSUME proposed openstack/nova: Set 'serial' to new volume ID in swap volumes  https://review.openstack.org/25713501:34
openstackgerritTakashi NATSUME proposed openstack/nova: Stop using mox stubs in nova/tests/unit/cells  https://review.openstack.org/32328701:35
openstackgerritTakashi NATSUME proposed openstack/nova: Stop using mox stubs in nova/tests/unit/virt/disk  https://review.openstack.org/32277801:35
*** kevinz has quit IRC01:35
*** shaohe_feng has quit IRC01:38
*** shaohe_feng has joined #openstack-nova01:39
*** yamahata has joined #openstack-nova01:41
*** smatzek has quit IRC01:41
*** tonytan4ever has joined #openstack-nova01:42
*** hoangcx2 has quit IRC01:42
*** vishwanathj has joined #openstack-nova01:43
*** vishwanathj has quit IRC01:43
*** hoangcx2 has joined #openstack-nova01:45
*** ducttape_ has joined #openstack-nova01:46
*** wangqun has joined #openstack-nova01:46
*** tonytan4ever has quit IRC01:47
*** shaohe_feng has quit IRC01:49
*** shaohe_feng has joined #openstack-nova01:49
*** thorst_ has joined #openstack-nova01:52
*** ducttape_ has quit IRC01:56
*** baoli has quit IRC01:56
*** su_zhang has quit IRC01:59
*** shaohe_feng has quit IRC01:59
*** shaohe_feng has joined #openstack-nova02:00
*** ljxiash has quit IRC02:00
*** tonytan4ever has joined #openstack-nova02:01
*** thorst_ has quit IRC02:07
*** thorst_ has joined #openstack-nova02:08
*** shaohe_feng has quit IRC02:09
*** jamielennox is now known as jamielennox|away02:10
*** shaohe_feng has joined #openstack-nova02:10
*** thorst_ has quit IRC02:16
*** ljxiash has joined #openstack-nova02:17
*** kevinz has joined #openstack-nova02:18
*** shaohe_feng has quit IRC02:19
*** shaohe_feng has joined #openstack-nova02:20
*** jwcroppe has joined #openstack-nova02:26
*** shaohe_feng has quit IRC02:30
*** jamielennox|away is now known as jamielennox02:30
*** shaohe_feng has joined #openstack-nova02:30
*** gongysh has joined #openstack-nova02:30
*** jwcroppe has quit IRC02:31
*** ducttape_ has joined #openstack-nova02:32
openstackgerritEli Qiao proposed openstack/nova: libvirt: cleanup never used migratable flag checking  https://review.openstack.org/31035202:33
*** gongysh has quit IRC02:37
*** shaohe_feng has quit IRC02:40
*** gothicmindfood has quit IRC02:40
*** lixiaoy1 has quit IRC02:40
*** shaohe_feng has joined #openstack-nova02:41
openstackgerritHieu LE proposed openstack/nova: Config options: improve libvirt help text (2)  https://review.openstack.org/31655002:45
*** shaohe_feng has quit IRC02:50
*** zerda2 has joined #openstack-nova02:51
*** shaohe_feng has joined #openstack-nova02:51
*** amotoki has quit IRC02:54
*** amotoki has joined #openstack-nova02:55
*** amotoki has quit IRC02:56
*** shaohe_feng has quit IRC03:00
*** shaohe_feng has joined #openstack-nova03:02
*** ducttape_ has quit IRC03:02
*** gcb has joined #openstack-nova03:02
*** hoangcx2 has quit IRC03:03
*** shaohe_feng has quit IRC03:11
*** shaohe_feng has joined #openstack-nova03:11
*** thorst_ has joined #openstack-nova03:15
*** shaohe_feng has quit IRC03:21
*** thorst_ has quit IRC03:21
*** baoli has joined #openstack-nova03:24
*** shaohe_feng has joined #openstack-nova03:24
openstackgerritClenimar Filemon proposed openstack/nova: Support Identity v3 when connecting to Ironic  https://review.openstack.org/30015403:28
*** shaohe_feng has quit IRC03:31
*** shaohe_feng has joined #openstack-nova03:32
*** baoli has quit IRC03:39
*** amotoki has joined #openstack-nova03:39
*** shaohe_feng has quit IRC03:41
openstackgerritLisaLi proposed openstack/nova: Attach/detach encrypted volume during swap_volume  https://review.openstack.org/25280903:42
*** shaohe_feng has joined #openstack-nova03:44
openstackgerritDao Cong Tien proposed openstack/nova: Remove mox from api/openstack/compute/test_deferred_delete.py  https://review.openstack.org/32034603:45
*** tonytan4ever has quit IRC03:46
*** su_zhang has joined #openstack-nova03:52
*** shaohe_feng has quit IRC03:52
*** shaohe_feng has joined #openstack-nova03:53
*** EinstCrazy has quit IRC03:53
*** _diana_ has joined #openstack-nova03:54
*** ljxiash has quit IRC04:00
*** amotoki has quit IRC04:01
*** shaohe_feng has quit IRC04:02
*** ducttape_ has joined #openstack-nova04:02
*** shaohe_feng has joined #openstack-nova04:03
*** ekuris has joined #openstack-nova04:03
*** hshiina has joined #openstack-nova04:07
*** ducttape_ has quit IRC04:07
*** amotoki has joined #openstack-nova04:09
*** shaohe_feng has quit IRC04:12
*** mingyu has quit IRC04:12
*** shaohe_feng has joined #openstack-nova04:13
*** mingyu has joined #openstack-nova04:13
*** amotoki has quit IRC04:13
*** amotoki has joined #openstack-nova04:17
*** thorst_ has joined #openstack-nova04:18
*** mingyu has quit IRC04:18
*** shaohe_feng has quit IRC04:22
*** shaohe_feng has joined #openstack-nova04:23
*** armax has joined #openstack-nova04:24
*** vishwanathj has joined #openstack-nova04:25
*** thorst_ has quit IRC04:26
*** armax has quit IRC04:29
*** jwcroppe has joined #openstack-nova04:29
*** shaohe_feng has quit IRC04:33
*** gouthamr has quit IRC04:33
*** EinstCrazy has joined #openstack-nova04:33
*** shaohe_feng has joined #openstack-nova04:33
*** jwcroppe has quit IRC04:33
openstackgerritGhanshyam Mann proposed openstack/nova: Remove user_id policy enforcement from server start  https://review.openstack.org/35466204:39
openstackgerritChangBo Guo(gcb) proposed openstack/nova: Log warning when user set improper config option value  https://review.openstack.org/35453204:42
*** ljxiash has joined #openstack-nova04:42
*** shaohe_feng has quit IRC04:43
*** shaohe_feng has joined #openstack-nova04:44
*** jaosorior has joined #openstack-nova04:47
*** ljxiash has quit IRC04:47
openstackgerritRikimaru Honjo proposed openstack/nova: Add checks for preventing unexpected detaching volume  https://review.openstack.org/35461704:50
*** shaohe_feng has quit IRC04:53
*** shaohe_feng has joined #openstack-nova04:54
*** EinstCrazy has quit IRC04:54
*** EinstCrazy has joined #openstack-nova04:55
*** vishwanathj has quit IRC04:55
*** _diana_ has quit IRC04:57
*** EinstCrazy has quit IRC04:59
*** EinstCrazy has joined #openstack-nova05:00
*** shaohe_feng has quit IRC05:04
*** ducttape_ has joined #openstack-nova05:04
*** shaohe_feng has joined #openstack-nova05:04
*** bswartz has joined #openstack-nova05:07
*** ducttape_ has quit IRC05:08
*** pbandark has joined #openstack-nova05:14
*** shaohe_feng has quit IRC05:14
*** markmc has quit IRC05:15
*** shaohe_feng has joined #openstack-nova05:15
*** markmc has joined #openstack-nova05:15
*** vishwanathj has joined #openstack-nova05:15
*** lucas-dinner has quit IRC05:15
*** vishwanathj is now known as vishwanathj_zzz05:16
*** mingyu has joined #openstack-nova05:19
*** lucasagomes has joined #openstack-nova05:19
*** GB21 has joined #openstack-nova05:21
*** mingyu has quit IRC05:23
*** shaohe_feng has quit IRC05:24
*** shaohe_feng has joined #openstack-nova05:24
*** dmsimard has quit IRC05:25
*** rcernin has joined #openstack-nova05:25
*** thorst_ has joined #openstack-nova05:25
*** EinstCrazy has quit IRC05:26
*** dmsimard has joined #openstack-nova05:27
*** EinstCrazy has joined #openstack-nova05:27
*** EinstCra_ has joined #openstack-nova05:30
*** thorst_ has quit IRC05:31
*** EinstCrazy has quit IRC05:31
*** shaohe_feng has quit IRC05:34
*** shaohe_feng has joined #openstack-nova05:35
*** ljxiash has joined #openstack-nova05:39
*** esracelik has joined #openstack-nova05:41
*** esracelik is now known as ecelik05:41
openstackgerritDao Cong Tien proposed openstack/nova: Remove mox from unit/api/openstack/compute/test_serversV21.py  https://review.openstack.org/32082105:42
*** shaohe_feng has quit IRC05:45
*** shaohe_feng has joined #openstack-nova05:45
*** rkrum has joined #openstack-nova05:47
openstackgerritHieu LE proposed openstack/nova: Config options: improve libvirt help text (2)  https://review.openstack.org/31655005:50
*** baoli has joined #openstack-nova05:51
*** shaohe_feng has quit IRC05:55
*** ljxiash has quit IRC05:55
*** shaohe_feng has joined #openstack-nova05:55
*** baoli has quit IRC05:56
*** ljxiash has joined #openstack-nova05:57
*** ljxiash_ has joined #openstack-nova05:58
openstackgerritLi Yingjun proposed openstack/nova: Adds view builders for hypervisors controller  https://review.openstack.org/33528205:58
*** liverpooler has joined #openstack-nova05:59
*** ljxiash_ has quit IRC06:00
*** ljxiash_ has joined #openstack-nova06:00
*** hieulq has quit IRC06:00
*** agireud has quit IRC06:01
*** ljxiash has quit IRC06:01
*** ducttape_ has joined #openstack-nova06:04
*** shaohe_feng has quit IRC06:05
*** shaohe_feng has joined #openstack-nova06:06
*** hieulq has joined #openstack-nova06:07
*** ducttape_ has quit IRC06:09
*** agireud has joined #openstack-nova06:10
*** shaohe_feng has quit IRC06:15
*** shaohe_feng has joined #openstack-nova06:15
*** ljxiash_ has quit IRC06:16
*** moshele has joined #openstack-nova06:18
*** jwcroppe has joined #openstack-nova06:23
*** shaohe_feng has quit IRC06:26
*** armax has joined #openstack-nova06:26
*** shaohe_feng has joined #openstack-nova06:27
*** jwcroppe has quit IRC06:28
*** thorst_ has joined #openstack-nova06:29
*** armax has quit IRC06:31
*** david-lyle has joined #openstack-nova06:36
*** shaohe_feng has quit IRC06:36
*** pcaruana has joined #openstack-nova06:36
*** shaohe_feng has joined #openstack-nova06:36
*** thorst_ has quit IRC06:36
*** houming has joined #openstack-nova06:38
*** david-lyle_ has quit IRC06:39
*** shaohe_feng has quit IRC06:46
*** shaohe_feng has joined #openstack-nova06:47
*** tonytan4ever has joined #openstack-nova06:47
*** belmoreira has joined #openstack-nova06:48
*** phuongnh has joined #openstack-nova06:49
*** tonytan4ever has quit IRC06:52
*** ljxiash has joined #openstack-nova06:54
*** wangqun has quit IRC06:54
*** gcb has quit IRC06:56
*** shaohe_feng has quit IRC06:56
*** shaohe_feng has joined #openstack-nova06:57
*** ljxiash has quit IRC06:58
*** Thelo has joined #openstack-nova07:02
*** ducttape_ has joined #openstack-nova07:05
*** shaohe_feng has quit IRC07:07
*** rkrum has quit IRC07:07
*** shaohe_feng has joined #openstack-nova07:07
*** ducttape_ has quit IRC07:09
*** Thelo has quit IRC07:10
*** ljxiash has joined #openstack-nova07:10
*** Thelo has joined #openstack-nova07:12
*** shaohe_feng has quit IRC07:17
*** shaohe_feng has joined #openstack-nova07:17
*** Thelo has left #openstack-nova07:17
*** su_zhang has quit IRC07:25
*** markus_z has joined #openstack-nova07:26
*** shaohe_feng has quit IRC07:27
*** shaohe_feng has joined #openstack-nova07:28
*** matrohon has joined #openstack-nova07:28
*** ihrachys has joined #openstack-nova07:31
*** amotoki_ has joined #openstack-nova07:32
*** thorst_ has joined #openstack-nova07:34
*** lpetrut has joined #openstack-nova07:34
*** amotoki has quit IRC07:35
*** yamahata has quit IRC07:36
*** shaohe_feng has quit IRC07:37
*** GB21 has quit IRC07:38
*** shaohe_feng has joined #openstack-nova07:38
*** thorst_ has quit IRC07:41
*** shaohe_feng has quit IRC07:48
*** shaohe_feng has joined #openstack-nova07:48
*** ljxiash has quit IRC07:51
*** wangqun has joined #openstack-nova07:53
*** GB21 has joined #openstack-nova07:53
*** roeyc has joined #openstack-nova07:58
*** shaohe_feng has quit IRC07:58
*** dimtruck is now known as zz_dimtruck07:59
*** shaohe_feng has joined #openstack-nova07:59
*** wangqun has quit IRC07:59
*** ljxiash has joined #openstack-nova07:59
*** zzzeek has quit IRC08:00
*** sdake has joined #openstack-nova08:01
*** zzzeek has joined #openstack-nova08:02
openstackgerritNguyen Hung Phuong proposed openstack/nova: Clean imports in code In some part in the code we import objects. In the Openstack style guidelines they recommend to import only modules. We need to fix that.  https://review.openstack.org/35535908:02
*** tonytan4ever has joined #openstack-nova08:03
*** ducttape_ has joined #openstack-nova08:06
openstackgerritGhanshyam Mann proposed openstack/nova: Remove user_id policy enforcement from instance_actions  https://review.openstack.org/35472608:07
openstackgerritGhanshyam Mann proposed openstack/nova: Remove user_id policy enforcement from unlock_override  https://review.openstack.org/35473708:07
*** tonytan4ever has quit IRC08:08
openstackgerritGhanshyam Mann proposed openstack/nova: Fix policy tests for project_id enforcement  https://review.openstack.org/35469008:08
*** shaohe_feng has quit IRC08:08
*** shaohe_feng has joined #openstack-nova08:08
*** Hosam has joined #openstack-nova08:09
*** ducttape_ has quit IRC08:11
*** sdake has quit IRC08:15
*** shaohe_feng has quit IRC08:18
*** shaohe_feng has joined #openstack-nova08:19
*** lyarwood has joined #openstack-nova08:20
*** danpb has joined #openstack-nova08:21
markus_zAnyone from Intel NFV CI here?08:26
markus_zIt looks like the recheck command doesn't work: https://review.openstack.org/#/c/323765/21 (12. Aug 09:27 without response)08:27
*** mnestratov has joined #openstack-nova08:27
*** shaohe_feng has quit IRC08:29
*** shaohe_feng has joined #openstack-nova08:29
*** houming has quit IRC08:30
*** Thelo has joined #openstack-nova08:34
*** sdake has joined #openstack-nova08:35
*** shaohe_feng has quit IRC08:39
*** thorst_ has joined #openstack-nova08:39
*** shaohe_feng has joined #openstack-nova08:40
*** houming has joined #openstack-nova08:40
*** markvoelker has joined #openstack-nova08:41
*** tuanla_ has joined #openstack-nova08:42
*** sdake has quit IRC08:43
*** markvoelker has quit IRC08:45
*** thorst_ has quit IRC08:47
*** lpetrut has quit IRC08:47
*** shaohe_feng has quit IRC08:49
*** houming has quit IRC08:50
*** shaohe_feng has joined #openstack-nova08:52
*** Thelo has quit IRC08:52
*** Gibi has joined #openstack-nova08:53
*** hshiina has quit IRC08:55
*** mvk has joined #openstack-nova08:56
*** houming has joined #openstack-nova08:57
*** lpetrut has joined #openstack-nova08:58
*** shaohe_feng has quit IRC08:59
*** shaohe_feng has joined #openstack-nova09:00
*** ducttape_ has joined #openstack-nova09:07
*** shaohe_feng has quit IRC09:10
*** andrey-mp has joined #openstack-nova09:10
*** shaohe_feng has joined #openstack-nova09:10
openstackgerritNguyen Hung Phuong proposed openstack/nova: Clean imports in code  https://review.openstack.org/35535909:10
*** ducttape_ has quit IRC09:11
*** lixiaoy1 has joined #openstack-nova09:12
tdurakovmarkus_z: hi, have you tried mails, mentioned here https://wiki.openstack.org/wiki/ThirdPartySystems/Intel_NFV_CI ?09:15
*** ljxiash has quit IRC09:16
*** ljxiash has joined #openstack-nova09:17
*** ljxiash_ has joined #openstack-nova09:19
*** shaohe_feng has quit IRC09:20
*** shaohe_feng has joined #openstack-nova09:20
*** ljxiash has quit IRC09:22
openstackgerritDao Cong Tien proposed openstack/nova: Stop using mox from compute/test_volumes.py  https://review.openstack.org/32325709:23
*** oanson has joined #openstack-nova09:28
*** armax has joined #openstack-nova09:28
*** lpetrut has quit IRC09:30
*** shaohe_feng has quit IRC09:30
*** shaohe_feng has joined #openstack-nova09:31
*** ljxiash_ has quit IRC09:32
*** armax has quit IRC09:33
*** jichen has joined #openstack-nova09:33
*** efoley has joined #openstack-nova09:35
markus_ztdurakov: thanks, will do exactly that in 1h in case nobody is listening here.09:35
tdurakovmarkus_z: yeah, just in case)09:36
*** jaosorior is now known as jaosorior_brb09:38
*** lixiaoy1 has quit IRC09:39
*** lixiaoy1_ has joined #openstack-nova09:39
openstackgerritTakashi NATSUME proposed openstack/nova: Remove unused code in nova/api/validator.py  https://review.openstack.org/35539209:39
*** shaohe_feng has quit IRC09:40
*** shaohe_feng has joined #openstack-nova09:41
*** hoangcx has quit IRC09:41
markus_zFYI: trivial patch: ^09:42
*** roeyc has quit IRC09:43
*** thorst_ has joined #openstack-nova09:45
*** sdake has joined #openstack-nova09:46
*** roeyc has joined #openstack-nova09:47
*** ftersin has joined #openstack-nova09:48
*** hoangcx has joined #openstack-nova09:49
*** shaohe_feng has quit IRC09:51
*** shaohe_feng has joined #openstack-nova09:51
*** thorst_ has quit IRC09:52
*** roeyc has quit IRC09:52
*** wangqun has joined #openstack-nova09:57
*** oanson has quit IRC09:58
sfinucanmarkus_z: try wznoinsk09:58
tdurakovmarkus_z: heh, about the patch above, I wonder where other method from validator.py are used?09:59
wznoinskmarkus_z: checking10:00
*** shaohe_feng has quit IRC10:01
*** shaohe_feng has joined #openstack-nova10:02
*** prithiv has joined #openstack-nova10:03
andrey-mpdanpb: could you look to this bug - https://bugs.launchpad.net/nova/+bug/1612953 ?10:04
openstackLaunchpad bug 1612953 in OpenStack Compute (nova) "fail to boot instance with port of specfic subnet (regression)" [Undecided,New]10:04
*** tonytan4ever has joined #openstack-nova10:04
*** wangqun has quit IRC10:05
wznoinskmarkus_z: it commented on 10:3310:05
wznoinsk(~32min ago)10:05
*** ducttape_ has joined #openstack-nova10:08
*** tonytan4ever has quit IRC10:08
*** hoangcx has quit IRC10:10
*** zenoway has joined #openstack-nova10:10
*** shaohe_feng has quit IRC10:11
*** prithiv has quit IRC10:11
danpbandrey-mp: that;s already reported and fixed10:12
*** ducttape_ has quit IRC10:12
*** shaohe_feng has joined #openstack-nova10:12
*** edand has joined #openstack-nova10:13
wznoinskwould someone know which iptables are relevant (except for REDIRECT in nat) to make the metadata service working (neutron proxy -> nova metadata) when not using routed network? (no qrouter netns etc.) ?10:14
*** prithiv has joined #openstack-nova10:16
*** zz_dimtruck is now known as dimtruck10:18
*** EinstCra_ has quit IRC10:20
*** jwcroppe has joined #openstack-nova10:20
*** shaohe_feng has quit IRC10:21
*** shaohe_feng has joined #openstack-nova10:22
andrey-mpdanpb: could you point me to fix?10:25
danpbsee the bug i marked it dup of10:26
andrey-mpthanks10:27
*** jwcroppe has quit IRC10:27
kevinzdanpb: Nice meeting you~ If you have time,Could you give some comments to https://review.openstack.org/#/c/329403/10:27
*** dimtruck is now known as zz_dimtruck10:28
danpbkevinz: plesae stop pinging me every day10:29
danpbif i had time i would have commented already10:29
openstackgerritbailin.zhang proposed openstack/nova: Unplug vifs when VM create failed  https://review.openstack.org/33111310:30
*** jaosorior_brb is now known as jaosorior10:31
*** sdague has joined #openstack-nova10:31
kevinzdanpb: OK, sorry for disturb you :-) I will wait10:31
*** shaohe_feng has quit IRC10:32
*** shaohe_feng has joined #openstack-nova10:32
*** prithiv has quit IRC10:35
*** prithiv has joined #openstack-nova10:35
markus_zwznoinsk: yep, that's for the recheck I triggered today, which is fine. Out of curiosity: is your Zuul publicly accessible?10:37
markus_ztdurakov: Do you mean the other "validate_*" methods?10:37
wznoinskmarkus_z: it's not10:40
markus_zwznoinsk: OK, thanks10:40
wznoinskmarkus_z: I see zuul had issues reporting results back on 12 Aug, connectivity issue10:41
*** shaohe_feng has quit IRC10:42
markus_zwznoinsk: That explains that it didn't vote again after the recheck command. no biggie. Thanks for being reachable here in #nova10:42
*** markvoelker has joined #openstack-nova10:42
*** shaohe_feng has joined #openstack-nova10:42
wznoinskmarkus_z: no problem10:43
*** hieulq has quit IRC10:44
*** lpetrut has joined #openstack-nova10:45
*** prithiv has quit IRC10:46
*** markvoelker has quit IRC10:47
openstackgerritTakashi NATSUME proposed openstack/nova: Remove nova/api/validator.py  https://review.openstack.org/35539210:48
openstackgerritRikimaru Honjo proposed openstack/nova: Add checks for preventing unexpected detaching volume  https://review.openstack.org/35461710:51
*** shaohe_feng has quit IRC10:52
*** shaohe_feng has joined #openstack-nova10:53
*** andrey-mp has left #openstack-nova10:53
*** phuongnh has quit IRC10:58
*** roeyc has joined #openstack-nova10:59
openstackgerritTina Kevin proposed openstack/nova: Instance can not resize ephemeral disk  https://review.openstack.org/32075911:02
*** shaohe_feng has quit IRC11:02
*** shaohe_feng has joined #openstack-nova11:03
*** thorst_ has joined #openstack-nova11:04
*** lpetrut has quit IRC11:06
*** Hosam_ has joined #openstack-nova11:07
*** ducttape_ has joined #openstack-nova11:08
*** Hosam has quit IRC11:10
*** shaohe_feng has quit IRC11:13
*** ducttape_ has quit IRC11:13
*** shaohe_feng has joined #openstack-nova11:14
openstackgerritFeodor Tersin proposed openstack/nova: libvirt: Fix wrong call of _is_booted_from_volume  https://review.openstack.org/33460911:15
openstackgerritFeodor Tersin proposed openstack/nova: libvirt: Delete duplicate check when live-migrating  https://review.openstack.org/33705611:15
openstackgerritFeodor Tersin proposed openstack/nova: libvirt: Simplify internal usage of get_instance_disk_info  https://review.openstack.org/33490111:15
*** lucasagomes is now known as lucas-hungry11:16
*** zerda2 has quit IRC11:17
*** bvanhav has joined #openstack-nova11:22
*** shaohe_feng has quit IRC11:23
*** shaohe_feng has joined #openstack-nova11:24
openstackgerritJens Rosenboom proposed openstack/nova: Fix ephemaral disk creation  https://review.openstack.org/35541511:24
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: live-migration test hook for serial console  https://review.openstack.org/34747111:27
*** armax has joined #openstack-nova11:30
*** amotoki_ has quit IRC11:31
*** shaohe_feng has quit IRC11:33
*** amotoki has joined #openstack-nova11:34
*** jaosorior has quit IRC11:34
*** armax has quit IRC11:35
*** jaosorior has joined #openstack-nova11:35
*** shaohe_feng has joined #openstack-nova11:36
*** amotoki has quit IRC11:37
tdurakovmarkus_z: left comment on that patch, so looks like nova is not using validator.py anymore11:38
*** rodrigods has quit IRC11:38
*** rodrigods has joined #openstack-nova11:38
markus_ztdurakov: yeah, I have seen it right now, good catch! Less code to maintain.11:38
*** shaohe_feng has quit IRC11:43
*** shaohe_feng has joined #openstack-nova11:44
*** gcb has joined #openstack-nova11:45
*** amotoki has joined #openstack-nova11:48
openstackgerritAndrey Volkov proposed openstack/nova: Tests: use fakes.HTTPRequest in compute tests  https://review.openstack.org/35332611:51
openstackgerritAndrey Volkov proposed openstack/nova: Wrap servers detail API call in single transaction  https://review.openstack.org/35295011:51
*** rfolco has joined #openstack-nova11:51
*** shaohe_feng has quit IRC11:54
*** shaohe_feng has joined #openstack-nova11:54
openstackgerritSean Dague proposed openstack/python-novaclient: Use neutron for network name -> id resolution  https://review.openstack.org/35498111:57
*** baoli_ has joined #openstack-nova12:00
*** sdake has quit IRC12:02
*** shaohe_feng has quit IRC12:04
*** edmondsw has joined #openstack-nova12:04
*** shaohe_feng has joined #openstack-nova12:05
*** tonytan4ever has joined #openstack-nova12:05
*** smatzek has joined #openstack-nova12:06
*** sdake has joined #openstack-nova12:06
*** JoseMello has joined #openstack-nova12:08
*** ducttape_ has joined #openstack-nova12:09
*** tonytan4ever has quit IRC12:09
*** gouthamr has joined #openstack-nova12:10
tdurakovjohnthetubaguy: hi, are you around? https://review.openstack.org/#/c/350480/3/releasenotes/notes/libvirt-change-default-value-of-live-migration-tunnelled-4248cf76df605fdf.yaml - do you mean that it's should be explicitly mentioned that it's about encryption?12:11
*** gcb has quit IRC12:12
*** Hosam has joined #openstack-nova12:12
*** ducttape_ has quit IRC12:12
*** gcb has joined #openstack-nova12:13
*** ducttape_ has joined #openstack-nova12:13
*** tonytan4ever has joined #openstack-nova12:13
*** shaohe_feng has quit IRC12:14
*** shaohe_feng has joined #openstack-nova12:15
*** jwcroppe has joined #openstack-nova12:15
*** Hosam_ has quit IRC12:16
*** amotoki has quit IRC12:16
*** zz_dimtruck is now known as dimtruck12:18
*** Zara has quit IRC12:20
*** amotoki has joined #openstack-nova12:23
*** alineb has joined #openstack-nova12:23
*** shaohe_feng has quit IRC12:24
*** shaohe_feng has joined #openstack-nova12:25
*** jwcroppe has quit IRC12:26
*** takashin has left #openstack-nova12:26
*** lucas-hungry is now known as lucasagomes12:27
*** ftersin has quit IRC12:27
*** amotoki has quit IRC12:28
*** dimtruck is now known as zz_dimtruck12:28
*** markvoelker has joined #openstack-nova12:30
*** woodster_ has joined #openstack-nova12:32
*** pradk has joined #openstack-nova12:33
*** shaohe_feng has quit IRC12:35
*** GB21 has quit IRC12:35
*** shaohe_feng has joined #openstack-nova12:35
*** mtanino has joined #openstack-nova12:35
*** ducttape_ has quit IRC12:35
*** tuanla_ has quit IRC12:36
*** sdake has quit IRC12:38
openstackgerritgaryk proposed openstack/nova: VIF: add in missing translation  https://review.openstack.org/35544712:43
*** kevinz has quit IRC12:44
*** shaohe_feng has quit IRC12:45
*** jaypipes has joined #openstack-nova12:45
*** shaohe_feng has joined #openstack-nova12:46
*** rkrum has joined #openstack-nova12:47
*** Zara has joined #openstack-nova12:47
*** rlrossit has joined #openstack-nova12:49
*** hshiina has joined #openstack-nova12:52
*** vladikr has joined #openstack-nova12:53
*** gcb has quit IRC12:55
*** shaohe_feng has quit IRC12:55
*** shaohe_feng has joined #openstack-nova12:56
*** xyang1 has joined #openstack-nova12:56
*** PaulMurray has joined #openstack-nova12:59
openstackgerritJay Pipes proposed openstack/nova-specs: Resource providers: custom resource classes  https://review.openstack.org/31269613:01
jaypipesedleafe, cdent: ^^13:02
*** ftersin has joined #openstack-nova13:03
*** kylek3h has joined #openstack-nova13:03
*** zz_dimtruck is now known as dimtruck13:04
alex_xujaypipes: good morning, quick question, whether LIVE_MIGRATION, LIVE_RESIZE can be a capabilities?13:04
*** houming has quit IRC13:04
*** shaohe_feng has quit IRC13:05
jaypipesalex_xu: no. those aren't things that a user would request (since users should have no idea which compute host their guest is on nor do users ever trigger live migration themselves.13:05
jaypipesalex_xu: those are, of course, things that we can/should expose to administrators via the "capabilities REST API" that alaski and others have been discussing (the thing that is more alike to the old GET /extensions API call)13:07
alex_xujaypipes: ok, thanks. I'm still thinking the case people want to boot instance it can support LIVE_RESIZE. And the capabilities discovery API may need to know whether th....13:07
alex_xujaypipes: :) I just type on the halfway...13:08
jaypipesalex_xu: which brings up a good point that we should settle on the name of these different things :) We've been calling both of those different things "capabilities".13:08
*** mdrabe has joined #openstack-nova13:08
jaypipesalex_xu: users don't boot instances and request that they can live-resize it... it's just not something cloud users do, really.13:08
alaskialex_xu: I think LIVE_MIGRATION/LIVE_RESIZE might depend on host "capabilities" but not something called LIVE_MIGRATION. It might be something like cpu_arch or whatever is relevant13:09
jaypipesalex_xu: just like users never issue a live-migrate command themselves.13:09
jaypipesalaski: ++13:09
*** shaohe_feng has joined #openstack-nova13:10
alex_xualaski: ah, i got you, learned :)13:10
*** rkrum has quit IRC13:10
PaulMurrayjaypipes, resize is issued by users13:11
alex_xuI just say no LIVE_MIGRATION/LIVE_RESIZE won't depend on any hardware caps13:11
*** rkrum has joined #openstack-nova13:11
jaypipesPaulMurray: users don't request to launch an instance that can only land on a host that supports hot-resizing, though... what use case does that serve?13:12
edleafejaypipes: +1'd the spec13:12
jaypipesedleafe: cheerio.13:12
alex_xujaypipes: alaski but the reality is we have many different virt driver, those virt driver have different caps to support different action. so that is fault of our API13:12
alex_xus/fault of our API/fault of API?/13:12
PaulMurrayjaypipes, fare enough, just pointing out that users initiate resize - admins to migrate13:13
jaypipesPaulMurray: understood.13:13
PaulMurrays/fare/fair/13:13
*** ducttape_ has joined #openstack-nova13:14
* alex_xu back to think about those13:15
jaypipesalex_xu: the capabilities part of the placement API isn't intended to determine what *actions* a user can take. It's intended to determine what *features* or *attributes* a resource provider has that make it a good fit for a requested workload.13:15
*** shaohe_feng has quit IRC13:16
*** rkrum has quit IRC13:16
jaypipesalex_xu: while the discovery API that alaski has been working on is intended to answer the question of "can I perform this *action* against this particular OpenStack cloud?"13:17
alex_xujaypipes: actions need resource provider have the live_resize feature13:17
alex_xujaypipes: yes, whether I can perform this action, depend on the policy and whether hypervisor support this action13:17
johnthetubaguytdurakov: I basically mean it should mention the behaviour change, that by default live-migrate traffic will no longer be encrypted.13:18
jaypipesalex_xu: think of the difference like this: the capabilities part of the placement API describes *adjectives* (i.e. is this apple red? is it tasty?) whereas the capabilities discovery API answers the question "what can I do with this?" (i.e. can I pick apples at this orchard?)13:18
*** shaohe_feng has joined #openstack-nova13:19
*** jwcroppe has joined #openstack-nova13:19
PaulMurrayalex_xu, do you expect to have a mix of hosts, some that can and some that can't do live resize presented to one tenant?13:19
*** amotoki has joined #openstack-nova13:19
jaypipesalex_xu: obviously we need both of those things in the REST API. we just need to be very careful not to mix policy stuff with "features" or "adjectives" that describe the resources that a resource provider provides :)13:19
alex_xujaypipes: yes, so how can we answer the question of "what can i do with this"13:20
alex_xuPaulMurray: good point13:20
jaypipesalex_xu: we need a REST API for that :) it just shouldn't be the same REST API as the proposed placement API capabilities stuff. Something like GET /policies would be good with me, though policy is an overloaded term already (as is capabilities). Guh, naming is *hard*! :)13:21
alex_xujaypipes: yea, policy discovery, capabilities discovery, I hate those also :)13:23
jaypipesalex_xu: I was discussing the naming of these things with alaski the other day. We couldn't come up with good terms for them.13:24
alex_xuheh :)13:24
*** GB21 has joined #openstack-nova13:24
*** ravikama_ has joined #openstack-nova13:25
*** shaohe_feng has quit IRC13:26
*** jamesden_ has joined #openstack-nova13:27
*** shaohe_feng has joined #openstack-nova13:27
alaskijust sent a message to the ML soliciting naming assistance13:27
PaulMurrayalaski, DNS - distributed naming solicitation13:31
*** belmoreira has quit IRC13:31
alaskiPaulMurray: exactly, just a simple DNS query13:31
jaypipeshehe13:32
*** ducttape_ has quit IRC13:33
*** tonytan4ever has quit IRC13:33
*** mriedem has joined #openstack-nova13:34
mriedemrar!13:34
jaypipesmriedem: grawr!13:34
mriedemsdague: on the network proxy thing in novaclient, i was thinking over the weekend that we should merge that in with dansmith's change to fallback to 2.3513:36
sdaguemriedem: on the novaclient front, how about this other direction for networks - https://review.openstack.org/#/c/354981/13:36
*** shaohe_feng has quit IRC13:36
sdaguemriedem: I think we want to take a different approach13:36
sdaguewhich is to always go to neutron if we can13:36
*** shaohe_feng has joined #openstack-nova13:36
*** jwcroppe has quit IRC13:37
mriedemsdague: ok, i was having similar thoughts also after working on making the functional tests work with neutron13:38
mriedemdoing the catalog lookup that is13:38
sdaguethe functional tests there exploded because of running out of time13:39
sdaguewe may need to extend the timeout if we're putting more tests into that bucket13:39
mriedemhow about saving the has_neutron result as an attr in the client?13:41
*** GB21 has quit IRC13:41
sdaguealso... ug - https://github.com/openstack/python-novaclient/blob/cbef3db003deb2bafb0cd3beaa993950a7185d3e/novaclient/tests/unit/v2/test_shell.py#L674-L676 test mocking out other part of other test13:41
mriedemso we only have to look it up once?13:41
sdaguemriedem: it's not a network call13:42
mriedemnice, mock the mock13:42
mriedemwhat's not a network call?13:42
sdagueget_endpoint13:42
mriedemright, in a given session is that going to change?13:43
mriedemi guess we recreate the client on each call,13:43
mriedemso storing as an attr in the client won't buy much13:43
sdagueit would just add a caching complexity13:43
sdaguewhen all you are saving is a dozen instructions13:43
mriedemso the functional timeouts aren't just me13:44
mriedemi was noticing the same when running my use-neutron functional job patch13:44
*** pwnall has joined #openstack-nova13:44
sdagueyeh, I think we just grew the test bucket13:45
sdagueand given that the tests run serially13:45
*** tblakes has joined #openstack-nova13:45
mriedemok, i also noticed over the weekend that we're leaking resources in the functional run13:46
*** shaohe_feng has quit IRC13:46
*** shaohe_feng has joined #openstack-nova13:47
mriedemsdague: so when we get to dansmith's 2.36 change, i guess we'd have to just special case the fallback nova-net proxy call if we're not using neutron, and use 2.3513:47
mriedemto be consistent with the other 2.35 network CLI fallback13:47
mriedembut hopefully with your change that won't be as many things13:48
*** rlrossit has quit IRC13:48
openstackgerritJay Pipes proposed openstack/nova: rt: Refactor unit test for trackable migrations  https://review.openstack.org/35261013:48
openstackgerritJay Pipes proposed openstack/nova: rt: Create multiple resize claim unit test  https://review.openstack.org/35262513:49
openstackgerritJay Pipes proposed openstack/nova: rt: delete test_resource_tracker.py  https://review.openstack.org/35380013:49
*** belmoreira has joined #openstack-nova13:50
sdaguemriedem: why?13:50
mriedemsdague: are you going to hack on this today or do you want me to? i also have to sort out what i'm doing with the get-me-a-network REST API last minute change request, because i'm on pager duty this week and on vacation next week13:50
mriedemso need to prioritize13:50
sdaguemriedem: I'm trying to get unit tests passing right now13:50
mriedemsdague: because in dan's change we fallback to  2.35 for network CLIs, i'd think we'd do the same here if not using neutron but the request is >=2.3613:51
mriedemotherwise it's kind of weird, we'll list networks for you but you can't boot with those networks, you'll get a 40413:51
mriedemnot here as in your change, here as in the use case but in dan's change13:51
sdaguemriedem: oh, because the fallback code is only on the shell13:51
sdagueright13:52
mriedemright13:52
mriedemok13:52
*** rlrossit_ has joined #openstack-nova13:52
mriedemif we're good with that, then i think we can land this change and the image proxy change and move forward with dan's13:52
sdagueyeh13:52
mriedemwait why would the functional tests now be timing out on your change that's checking to see if we're using neutron? the functional job is using nova-network13:53
sdaguebecause, they are pretty close to the timing line13:54
mriedemthe extra endpoint lookup pushes that over?13:54
sdagueno13:54
openstackgerritVladik Romanovsky proposed openstack/nova: tests: verify cpu pinning with prefer policy  https://review.openstack.org/35547513:54
sdaguetest runs have variance of 20 - 30%13:54
*** burt has joined #openstack-nova13:54
sdaguegiven cloud providers, noisy neighbors, network perf on mirrors13:54
*** ayoung has joined #openstack-nova13:55
edleafeScheduler subteam meeting in 5 minutes in #openstack-meeting-alt13:55
sdagueso if we're getting close to the line, sometimes we'll go over it regardless of the contents of the patch13:55
openstackgerritVladik Romanovsky proposed openstack/nova: tests: verify cpu pinning with prefer policy  https://review.openstack.org/35547513:55
sdaguehas_neutron probably takes about 0.002s to execute13:55
*** rtheis has joined #openstack-nova13:56
*** shaohe_feng has quit IRC13:57
mriedemok13:57
*** shaohe_feng has joined #openstack-nova13:57
mriedemsdague: when you get a minute this morning, i could use your input on this http://lists.openstack.org/pipermail/openstack-dev/2016-August/101499.html since if i'm going to change it i have to get that done this week.13:58
openstackgerritSean Dague proposed openstack/python-novaclient: Use neutron for network name -> id resolution  https://review.openstack.org/35498113:58
openstackgerritVladik Romanovsky proposed openstack/nova: adding debug info for pinning calculation  https://review.openstack.org/35515013:59
sdaguemriedem: ok, I honestly haven't looked at your change in a while, so I can switch gears over there while these tests run13:59
*** dims has quit IRC13:59
*** anush_ has joined #openstack-nova14:00
*** ftersin_ has joined #openstack-nova14:00
*** oanson has joined #openstack-nova14:01
*** ftersin has quit IRC14:02
*** ecelik has quit IRC14:03
*** ducttape_ has joined #openstack-nova14:04
*** venusf has joined #openstack-nova14:04
mriedemfyi this will unblock neutronclient 5.1.0 from getting into upper-constraints http://lists.openstack.org/pipermail/openstack-dev/2016-August/101499.html14:05
*** dims has joined #openstack-nova14:05
*** shaohe_feng has quit IRC14:07
*** mingyu has joined #openstack-nova14:07
*** shaohe_feng has joined #openstack-nova14:07
*** GB21 has joined #openstack-nova14:07
*** su_zhang has joined #openstack-nova14:08
*** venusf has left #openstack-nova14:08
*** venusf has joined #openstack-nova14:09
*** mtanino has quit IRC14:09
mriedemandrewbogott: https://review.openstack.org/#/c/355210/14:09
mriedemfor when you get to mitaka14:09
*** Hosam has quit IRC14:10
*** sdake has joined #openstack-nova14:10
*** Hosam has joined #openstack-nova14:10
venusfHi ,guys. As we know, there are more than one nova-api thread for processing restful api request, but how can I know which nova-api thread process the reqeust I send?14:11
*** annegentle has joined #openstack-nova14:14
*** kevinz has joined #openstack-nova14:14
*** Hosam has quit IRC14:15
*** jaypipes has quit IRC14:17
*** shaohe_feng has quit IRC14:17
sdaguemriedem: so, from a code structure perspective on - https://review.openstack.org/#/c/316398/35/nova/api/openstack/compute/servers.py ...14:18
sdagueit's a bit convoluted to pass that third parameter down multiple layers in the stack to cause different behavior14:18
*** rrecio has joined #openstack-nova14:18
sdaguewhy not just blast those out as different functions?14:19
*** brian_price has joined #openstack-nova14:20
*** shaohe_feng has joined #openstack-nova14:20
*** fragatina has joined #openstack-nova14:20
*** jaypipes has joined #openstack-nova14:21
*** fragatina has quit IRC14:21
*** fragatina has joined #openstack-nova14:21
*** tri2sing has joined #openstack-nova14:23
*** burgerk has joined #openstack-nova14:23
*** tonytan4ever has joined #openstack-nova14:23
mriedemsdague: that's the way it worked out, given the existing requested_networks list allowed non-uuid values for the network id and such. plus port/fixed ip handling etc. i mean i could have probably at the top level avoided calling _get_requested_networks and just check for auto/none and fail if anything else is specified14:24
*** lpetrut has joined #openstack-nova14:24
mriedemsdague: but i think that's where ken'ichi was asking, why even allow the auto/none as the network uuid in a list if it's just a single string value in the request will work14:24
mriedemit would simplify the validation logic, basically networks would be a string or a list14:24
mriedemand if it's a string, it has to be auto/none14:24
mriedemif it's a list, it's whatever is supported today14:25
*** rrecio_ has joined #openstack-nova14:26
*** ametts has joined #openstack-nova14:26
*** annegentle has quit IRC14:27
*** shaohe_feng has quit IRC14:27
*** shaohe_feng has joined #openstack-nova14:28
*** rrecio has quit IRC14:28
sdagueyeh, it's just really dense to unpack and walk through, I'd much rather divert a lot earlier with the special case14:28
*** burt has quit IRC14:29
mriedemi can look at doing that, if we stick with this request format14:29
mriedemif we change how server.networks is represented, then...14:29
sdagueI'm massively suspicious of boolean parameters that are "do things differently"14:29
sdagueok, so what's actually the request format question?14:29
*** dimtruck is now known as zz_dimtruck14:29
mriedemfor auto/none, change from server.networks = [{'uuid': 'auto'}] to server.networks = 'auto'14:30
mriedemsame for 'none'14:30
*** oanson has quit IRC14:30
sdagueoh, yeh, that makes a ton more sense to me14:30
*** pcaruana has quit IRC14:30
sdague+1 on that14:30
mriedemif you want multiple nics, or specific networks, you use the list format14:30
mriedemfor auto/none you doe the direct string one14:30
mriedemok, i'll start working on that change then. it would be awesome if i could hide some of the validation for that in jsonschema, but i'm not super familiar with being fancy in jsonschema14:31
sdagueyeh, alex_xu / oomichi are the ones that probably would know best how to do that14:32
sdagueI'm just not sure how we change out the type on a field14:32
*** burt has joined #openstack-nova14:32
sdaguethere is definitely already an enum mechanism14:33
*** armax has joined #openstack-nova14:33
* alex_xu reading the log14:33
*** devkulkarni has joined #openstack-nova14:33
*** zz_dimtruck is now known as dimtruck14:34
*** edand has quit IRC14:34
mriedemalex_xu: basically, https://review.openstack.org/#/c/316398/35/nova/api/openstack/compute/schemas/servers.py@3714:34
mriedemcan we define server.networks as an array or a string?14:34
mriedemwell, array or enum?14:34
mriedemmaybe using oneOf?14:35
mriedemlike here https://review.openstack.org/#/c/316398/35/nova/api/openstack/compute/schemas/servers.py@8914:35
alex_xumriedem: i'm thinking of oneOf also14:35
mriedemok, i'll play with that i guess14:35
mriedemthat's going to be my day today14:36
*** armax has quit IRC14:37
*** mdrabe has quit IRC14:37
*** shaohe_feng has quit IRC14:38
*** shaohe_feng has joined #openstack-nova14:38
*** rtheis has quit IRC14:38
openstackgerritCarl Baldwin proposed openstack/nova: Abort on HostNotCompatibleWithFixedIpsClient  https://review.openstack.org/34627814:39
*** jdurgin1 has joined #openstack-nova14:39
*** roeyc has quit IRC14:39
*** vishwanathj_zzz is now known as vishwanathj14:40
*** JoseMello has quit IRC14:40
sdaguemriedem: ok, I'll try to run with your test fixes14:40
sdagueto get the functional tests working on the neutron side14:40
alex_xumriedem: we have example like this https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/user_data.py#L23 I think pretty close14:41
sdaguemriedem: before you go completely down that rabbit hole. The os-brick locking issue remains in a nebulous state14:41
*** kevinz has quit IRC14:41
*** devkulkarni has quit IRC14:42
syjulianjaypipes, mikal: hi michael and jay. If you guys are available could you review this third part of my change https://review.openstack.org/#/c/354277/ ?14:42
*** krtaylor has quit IRC14:42
*** devkulkarni has joined #openstack-nova14:43
mriedemsdague: this? https://review.openstack.org/#/c/355215/14:43
mriedemi started ^14:43
mriedembut there are still like 10 failures14:43
*** andrearosa has quit IRC14:44
*** ducttape_ has quit IRC14:44
sdaguemriedem: yeh, I'll run with that, I've got the environment up locally anyway14:44
mriedemsdague: on the lock_path thing, i think the best we can do for newton is (1) use the same lock_path for nova/cinder in devstack if we're going to recommend that in release notes, (2) add the release notes to nova/cinder - for whatever that's worth, and (3) update the lock_path option help text in oslo14:44
*** mdrabe has joined #openstack-nova14:45
mriedemwe're not going to start using tooz at this point14:45
mriedemin newton i mean14:45
sdagueok, so I had blocked 1 until 2 was sorted14:45
mriedemand i blocked 2 until 1 and 3 were done :)14:45
mriedembut i think patrickeast and i are on the same page14:45
sdagueno, 2 has to go first14:45
sdaguewe do this all the time on the grenade side14:45
mriedemwell, i didn't block, but i asked for 1 and 314:46
sdagueyou don't get to hack the gate with non default config unless it's explained in projects14:46
mriedemsure, 3 is what i really wanted14:46
mriedemthe actual config option help text getting updated14:46
sdaguewhat do you envision 3 looks like?14:46
mriedemhttps://review.openstack.org/#/c/355269/1/oslo_concurrency/lockutils.py14:47
*** shaohe_feng has quit IRC14:48
sdaguemriedem: so... this also means that cinder & nova services have to run as the same users selinux context, right?14:48
*** shaohe_feng has joined #openstack-nova14:48
*** sdake has quit IRC14:48
sdaguedansmith / danpb - do you know what the rhel story is there?14:48
mriedemsdague: just commented on something like that in the patch14:49
mriedemsince it says, 'restrict this for the user that needs to write to the dir' but now you'd have 214:49
danpbsdague: well they wouldn't need to runthe same context, but you'd need to grant both of them permission to write to those files14:50
openstackgerritAndrew Laski proposed openstack/nova: Add ObjectListBase concat methods  https://review.openstack.org/35258714:50
openstackgerritAndrew Laski proposed openstack/nova: Fix migration list + MigrationList operation  https://review.openstack.org/35369414:50
sdaguedanpb: on rhel do the nova / cinder processes run under dedicated service users? or under some combinded one?14:51
*** venusf has left #openstack-nova14:51
dansmithsdague: different users14:52
dansmithsdague: but that's not an selinux thing14:52
*** jbernard1 has joined #openstack-nova14:52
dansmithsdague: so they need unix perms and selinux policy to touch the same things14:52
sdaguedansmith: ok, so setting the lock_path the same will also mean they have to be in the same group, and that g+w bits have to exist on the lock_path and all files14:52
sdaguefor it to work under rhel14:53
mriedemsdague: so alternatively,14:53
dansmithsdague: no different for ubuntu, AFAIK14:53
mriedemthis is latent and we punt14:53
mriedemand say, it's a race condition and you might hit it and might need to retry14:53
sdaguedansmith: ok, sure, I don't have an ubuntu stack running right now14:53
dansmithsdague: just confirmed, cinder and nova run as different users on ubuntu14:53
dansmithsdague: selinux is easier to fix than the group-write perms, AFAIK14:54
sdagueyeh, so this seems like a wreck for distros14:54
dansmithbecause it's not really user specific14:54
sdaguedansmith: right14:54
dansmithyou can directly say "nova can write cinder lock types" or whatever14:54
sdagueI knew that rhel had other selinux policy here, I wasn't sure if that made it better or worse14:54
danpbyou could use POSIX ACLs too14:54
danpb(to avoid group write + shared group )14:55
dansmithsdague: I certainly agree that them having to share a file lock is kinda icky14:55
danpbbut agree this is all just revolting14:55
*** ociuhandu has joined #openstack-nova14:55
danpbwhats the actual thing cinder+nova are racing on ?14:55
dansmithdanpb: thread on the ML14:56
dansmithsdague: if you run cinder and nova inside service containers, which is common and becoming more common, this won't be a possibility anyway14:56
sdaguedanpb the crux of the issue is os-brick uses @lockutils.synchronized and expects it to work, but it's being called from 2 different services14:56
dansmithwell, depending on your container, but...14:56
danpbi saw the thread, but didn't see specific example of the commands hitting the problem14:56
sdaguedansmith: ah, right14:56
sdaguedanpb: yeh, I'm not sure all the comands in question, I just saw the devstack patch which I was told was needed, which raised a red flag in my mind14:57
danpbis there a concrete example of something tha tbreaks ?14:57
mriedemthere was an example, i'm trying to find it14:58
*** shaohe_feng has quit IRC14:58
*** shaohe_feng has joined #openstack-nova14:59
mriedemoh it's a comment in the review https://review.openstack.org/#/c/354502/14:59
mriedem"As far as specific issues, we've seen races with attaching/detaching  iscsi volumes where os-brick needs to determine whether it was the last  LUN being used for an iscsi session. You can have problems where one  detach removes a device while the attach process is running scans on the  bus. Things like that."14:59
*** kylek3h_ has joined #openstack-nova15:00
dansmithX(15:00
danpbi can't help thinking some of that should be solved at a higher level15:00
dansmithyou mean lower level?15:00
mriedemso i think everyone is in agreement that the current situation sucks,15:01
mriedemthe question is what can be done, if anything, in newton15:01
danpbdansmith: no, as in avoid the need for os-brick to decide whether its the last LUN or not15:01
mriedemand if recommending that nova/cinder share a lock_path on the same host in the docs and release notes15:01
dansmithdanpb: that's the point of brick to some degree I think15:02
danpbdansmith: by Nova keeping track of whether the iSCSI target is used by any VMs or not15:02
mriedemdanpb: cinder should track that, and i think jgriffith is actually working on that15:02
danpbos-brick is stateless though afaik  ?15:02
*** kylek3h has quit IRC15:02
mriedemos-brick is stateless correct15:02
danpbif it wasn't stateless, it wouldn't have to run iscsiadm commands to figure out if it was the last LUN, and thus wouldn't hit the race15:02
*** hshiina has quit IRC15:02
jgriffithmriedem: +115:03
dansmithmriedem: the service containers thing breaks any sort of file-based lock I think15:03
jgriffithdansmith: yes brick is stateless15:03
jgriffithand should be IMO15:03
mriedemdansmith: how about venvs?15:03
mriedemsame situation?15:03
dansmithjgriffith: I know, I don't disagree, I meant that brick is supposed to insulate nova from knowing those things15:03
dansmithmriedem: no, venvs are fine15:03
danpbdansmith: well you can have shared folders between different containers, but again it all sucks15:03
jgriffithdansmith: yeah, I get ya15:04
dansmithdanpb: sure, but that makes it extra terrible :)15:04
jgriffithdansmith: TBH that was what I thought the entire point of Brick was :)15:04
dansmithjgriffith: :)15:04
jgriffithotherwise we don't gain anything from it but another project to maintain15:04
dansmiththat's a gain? :P15:04
openstackgerritRaghuveer Shenoy proposed openstack/nova-specs: Support SR-IOV and PCI statistics through Nova API  https://review.openstack.org/34200115:05
jgriffithdansmith: you can't see my sarcasm and rolling eyes from there?15:05
dansmithjgriffith: I totally can, just playing along :)15:05
jgriffithUnfortunately none of what i'm working on will go in N15:05
*** su_zhang has quit IRC15:05
jgriffithdansmith: haha15:05
*** devkulkarni has quit IRC15:05
*** devkulkarni has joined #openstack-nova15:06
*** devkulkarni has quit IRC15:06
sdaguemriedem: it's not stateless if it allows lock files15:06
jgriffithIn retrospect I should've just tackled moving all of the tracking before trying to reimplement attach/detach... but honestly that code is so messy at this point hacking in state tracking was just plane awful15:06
*** lpetrut has quit IRC15:06
*** rcernin has quit IRC15:06
jgriffithsdague: it should be stateless... but Nova and Cinder aren't.  And we have this weird thing now of both of those consuming/sharing that module at the same time15:07
jgriffithsdague: Our design is flawed15:07
jgriffithwe're trying to pretend that brick and be a static module and be stateless, but it can't because we don't have a central entity tracking the connection info15:08
jgriffithsometimes it's in Nova, sometimes it's in Cinder, and even worse some times we just don't worry about it :(15:08
johnthetubaguyjgriffith: so the new plan is to add all that tracking in Cinder?15:08
*** shaohe_feng has quit IRC15:08
jgriffithjohnthetubaguy: yes15:08
*** shaohe_feng has joined #openstack-nova15:09
johnthetubaguyjgriffith: cool, just checking I am still keeping track15:09
jgriffithjohnthetubaguy: no more split brain or confusing hacks trying to guess what's going on and making assumptions15:09
jgriffithand for the record, most of the badness is on the cinder side15:09
johnthetubaguyjgriffith: yeah, it sounds good, I am basically talking to neutron about doing the same thing with port bindings15:09
jgriffithjohnthetubaguy: ahh.. that makes sense15:09
jgriffithsimilar problems/challenges15:10
jgriffithdefinitely a pattern we could use more broadly I think15:10
johnthetubaguyjgriffith: they have the added complexity of needing to track the *active* binding, although its driver specific15:10
*** kevinz has joined #openstack-nova15:10
jgriffithyeah, that's EXACTLY what led to the hackiness in Cinder15:10
*** mvk has quit IRC15:10
jgriffithlots of *clever* adds to the Cinder manager to force it to specific drivers will15:11
jgriffithand that's kinda why things are such a mess now15:11
johnthetubaguyyeah, for neutron I am assuming all drivers need the active tracking15:11
johnthetubaguyin my current draft of things, anyways15:11
jgriffithit became the least understood code in Cinder... although now it no longer has that distinction for better or worse15:11
johnthetubaguycinder its more the shared per host connection issue I guess?15:11
sdagueok, well regardless of how we got here, how do we come up with something that's not a completely fail for newton?15:12
jgriffithsdague: for newton?15:12
sdagueyes15:12
sdaguebecause this shared lock_path I don't think is even viable15:12
dansmithsdague: oh I have a great idea for newton15:12
sdaguegiven the unix user issues15:12
johnthetubaguysdague: the brick and lock files bit?15:13
sdagueyes15:13
dansmithsdague: time.sleep(random.random()*100)15:13
dansmithinstalock ^15:13
jgriffithsdague: the problem is that I can't come up with a way to address it that doesn't include API changes15:13
jgriffithvolume-attach/volume-detach15:13
jgriffithand that ship sailed a few weeks ago as I understood it15:13
sdagueis smcginnis up and about yet?15:14
smcginnissdague: Yep15:14
johnthetubaguyso I understand someone is going to shoot me for saying this, did we rule out using sudo/root to acquire the shared lock file, as a short term hack?15:14
* smcginnis reads backscroll15:14
danpbthe ideal way to solve it would be to have a privileged linux iscsi service with API you could just call out to perform tasks15:14
dansmithjohnthetubaguy: that doesn't fix containers15:15
danpbthat service would take care of locking itself15:15
sdaguedanpb: yeh, and that for every driver15:15
dansmithjohnthetubaguy: service containers I mean, without having to have a special piece of shared filesystem mapped in15:15
johnthetubaguydansmith: yes, dang it.15:15
sdaguedanpb: the same pattern for iscsi seems to be repeated for others15:15
danpbsdague: in some ways, we'd actually be doing just that with privsep15:16
sdaguethe race windows might be smaller given how the backends work, but I don't think we can write them off15:16
johnthetubaguythats basically the privsep pattern, I guess15:16
danpband since privsep runs privileged, it doesn't have the user/group perm problem15:16
*** kevinz has quit IRC15:16
*** kevinz has joined #openstack-nova15:17
danpbso you could say os-brick could use lock.synchronized, provided it used privsep, and annotated the privileged methods, not the unprivileged ones15:17
jgriffithhas anybody considered how valuable the locks in brick actually are?15:17
johnthetubaguydoes privsep communication work between containers?15:17
danpbjohnthetubaguy: don't think anyone's figured that out yet :-)15:18
jgriffithsdague: kinda to your point about the race window....15:18
sdagueok, wait, lets hold off on containers for a second, because the scope of the problem might be different than we were considering15:18
dansmithjohnthetubaguy: if you're using filesystem locks, then no15:18
danpbdansmith: not neccessarily15:18
*** shaohe_feng has quit IRC15:19
dansmithdanpb: lock.synchronized only works single-process unless you use external=True15:19
danpbdansmith: service containers already have bucket loads of shared filesystem paths15:19
jgriffithwe're really just talking about two calls right?  Connect, Disconnect and extend?15:19
smcginnisMaths :)15:19
danpbso it potentially only means adding another fielsystem sub-dir passthrough for the service container15:19
sdaguejgriffith: well, I think that's the overall question15:19
dansmithdanpb: but they depend on how your containers are set up15:19
*** shaohe_feng has joined #openstack-nova15:19
dansmithdanpb: it just means yet another thing, agreed, I just think it's terrible to do that15:20
jgriffithsdague: well my point being that I've never thought connect and disconnect should have them at  all15:20
sdague"15:20
sdagueAs far as specific issues, we've seen races with attaching/detaching iscsi volumes where os-brick needs to determine whether it was the last LUN being used for an iscsi session. You can have problems where one detach removes a device while the attach process is running scans on the bus. Things like that.15:20
sdague"15:20
*** phschwartz has quit IRC15:20
jgriffithsdague: we already provide reserve/unreserve on the Cinder side, we should just use those15:20
smcginnisjgriffith: I think we can have rescan collisions if we don't lock.15:20
johnthetubaguyjgriffith: long term I think we can, but for newton?15:21
jgriffithsmcginnis: on you mean the initiator specific side?15:21
smcginnisjgriffith: Yes. Although if we are serializing things outside of the attach flow we shouldn't need to be concerned with that in brick.15:21
johnthetubaguyso... if every brick user had its own lock, what breaks? cinder rescan while nova is attaching?15:21
smcginnisjohnthetubaguy: I believe that is the concern from my understanding.15:22
jgriffithcinder rescan?15:22
dansmithis the problem when we have cinder co-located with n-cpu, or only between competing n-cpu things?15:22
sdaguesmcginnis: just in the iscsi case?15:22
sdaguedansmith: yes, I believe so15:22
dansmithsdague: which?15:23
sdaguethe colocation15:23
smcginnisjgriffith: Err..15:23
dansmithokay15:23
dansmiththought so, but wanted to make sure15:23
smcginnisYeah, I believe this is only a colocation issue.15:23
sdaguethat's what patrickeast said in the devstack review, which is why he didn't think it was a big deal to make the change - https://review.openstack.org/#/c/341744/ - because a lot of people would be isolated fromit15:24
dansmithin that case,15:25
dansmithI think I'd rather not introduce some half-baked hack that potentially has wide implications, and just document it15:25
*** moshele has quit IRC15:25
dansmiththe race is either leaking targets or potentially causing a build to fail, right?15:25
johnthetubaguythe work around is run both services as the same user, with access to a shared filesystem?15:26
dansmithwe have known issues in release notes for a reason.. "if you run these two things on the same box, they may compete in the following way"15:26
mriedemi'm fine with a release note with a known issue, but i think we also want something in the lock_path option description15:27
smcginnisI like the idea of also putting it in the help text. Just to try to raise visibility.15:27
dansmithjohnthetubaguy: not sure the existing locks protect us, otherwise we'd fail to ever grab locks when they're owned by other processes15:27
mriedembecause anyone new to opentsack in ocata isn't going to see the newton release note15:27
dansmithjohnthetubaguy: we'd fail instead of block it hink15:27
dansmithmriedem: new people don't read release notes?15:27
prometheanfiremriedem: https://review.openstack.org/355526 you might want to combine this with your review15:27
mriedemdansmith: for newton?15:27
dansmithmriedem: we keep this as a known issue until we fix it15:28
mriedemdansmith: release notes are based on tag15:28
sdagueok, so we'd just have to remember to carry forward15:28
dansmithmriedem: I'm just saying don't rush this for newton,15:28
sdaguemriedem: yeh, but we can manually carry forward15:28
dansmithmaybe jgriffith's tracking stuff will make it not a problem in ocata, right?15:28
openstackgerritCarl Baldwin proposed openstack/nova: Abort on HostNotCompatibleWithFixedIpsClient  https://review.openstack.org/34627815:28
mriedemdansmith: well, unless you're using icehouse level cinder15:28
mriedem:)15:28
mriedemcough rax cough15:28
johnthetubaguydansmith: I suspect thats a bit of code where we just throw away exceptions again? I remember something about that in the past15:29
dansmithmriedem: in which case you already know :)15:29
prometheanfiremriedem: hi :P15:29
*** shaohe_feng has quit IRC15:29
jgriffithdansmith: I think so...but frankly I'm trying to get some clarification from folks on why those locks are even there... still no real concrete answers15:29
sdaguesmcginnis: is there a narrower retry path we could put into place to mitigate in os-brick15:29
dansmithjohnthetubaguy: I hope not, because we're hoping to block on the lock, but..15:29
prometheanfireguess what version of openstack osuosl has deployed15:29
sdagueso we're not pretending to rely on those locks15:29
* jgriffith is chatting with authors in cinder channel15:29
prometheanfireI'll give a hint, it's not maintained anymore15:29
mriedemprometheanfire: he has a depends-on to https://review.openstack.org/#/c/355526/15:29
mriedemwhich is the same thing you were saying to combine it with15:29
mriedemthe depends-on should be fine15:29
smcginnissdague: We're kind of discussing that now.15:29
*** shaohe_feng has joined #openstack-nova15:29
smcginnisNeed to understand exactly when this is an issue and why.15:30
prometheanfiremriedem: updating gr without uc will break the world15:30
sdagueok, I'll go over there15:30
mriedemprometheanfire: the g-r change depends on the u-c change which depends on the nova change15:30
mriedemprometheanfire: the chaining is all good15:30
prometheanfirealso, do people know that osuosl has an openstack cluster running on openpower15:30
johnthetubaguysdague: I am good with the known issue, I am just curious if there is a way to reduce the sting15:30
prometheanfiremriedem: oh, I totally missed the depends on at the bottom15:30
mriedem:)15:31
*** pwnall has quit IRC15:31
*** su_zhang has joined #openstack-nova15:31
prometheanfireya, used to it being spaced on it's own line15:31
prometheanfireanyway, ack'd15:31
*** diogogmt has joined #openstack-nova15:33
*** armax has joined #openstack-nova15:33
*** sameo has joined #openstack-nova15:34
*** mdrabe has quit IRC15:35
*** mdrabe has joined #openstack-nova15:35
*** baoli_ has quit IRC15:35
*** kfarr has joined #openstack-nova15:37
*** armax has quit IRC15:37
*** belmoreira has quit IRC15:38
*** shaohe_feng has quit IRC15:39
*** harlowja_at_home has joined #openstack-nova15:40
*** shaohe_feng has joined #openstack-nova15:40
*** haplo37__ has joined #openstack-nova15:41
*** devkulkarni has joined #openstack-nova15:41
openstackgerritMaciej Szankin proposed openstack/nova: Improve help text for service options.  https://review.openstack.org/33286115:43
mriedemalex_xu: while you're around, i posted a question to the ML on this get me a network server.networks thing, i was fixing the legacy support for passing a network uuid of br-uuid form, but no longer really need to do that15:43
mriedemso wondering if i should continue fixing that in the 2.37 microversion or just drop it to avoid additional complexity in the change15:43
mriedemi'm kind of leaning toward the latter15:43
*** pwnall has joined #openstack-nova15:43
openstackgerritSarafraj Singh proposed openstack/nova: Improve help text for glance options  https://review.openstack.org/32400715:43
mriedemif we wanted to fix that at some point it would have to be a new microversion though15:43
*** sameo has quit IRC15:44
mriedemunless we consider passing non-uuids for networks as a bug15:44
openstackgerritMaciej Szankin proposed openstack/nova: Improve help text for service options.  https://review.openstack.org/33286115:44
*** sameo has joined #openstack-nova15:44
*** rlrossit_ has quit IRC15:44
openstackgerritSergey Nikitin proposed openstack/nova: DO NOT MERGE: get instance diagnostic  https://review.openstack.org/35554015:47
*** PaulMurray has quit IRC15:47
*** ekuris has quit IRC15:47
openstackgerritRoman Podoliaka proposed openstack/nova: placement: add filtering by attrs to resource_providers  https://review.openstack.org/34304615:49
*** shaohe_feng has quit IRC15:49
*** shaohe_feng has joined #openstack-nova15:50
*** pbandark has quit IRC15:50
*** hshiina has joined #openstack-nova15:50
openstackgerritRoman Podoliaka proposed openstack/nova: ironic_host_manager: fix population of instances info on schedule  https://review.openstack.org/34696615:50
openstackgerritRoman Podoliaka proposed openstack/nova: ironic_host_manager: fix population of instances info on start  https://review.openstack.org/34794815:50
*** Apoorva has joined #openstack-nova15:51
openstackgerritMaciej Szankin proposed openstack/nova: Deprecate all topic conf options  https://review.openstack.org/35160815:51
*** jichen has quit IRC15:53
*** Sukhdev has joined #openstack-nova15:53
openstackgerritJulian proposed openstack/nova: Add unit tests for nova.virt.firewall.IpTablesFirewallDriver (Part 4)  https://review.openstack.org/35555015:56
raj_singhsfinucan: When you get a chance can you comment on https://review.openstack.org/#/c/35358015:56
*** Apoorva has quit IRC15:57
*** brig-man has joined #openstack-nova15:57
*** mtanino has joined #openstack-nova15:57
sfinucanraj_singh: Hey :) I think my comments still stand?15:58
sfinucanThose markers at the top of the file are to indicate that work still needs to be done on the file. No point removing them and generating burndown if it's not actually true, no?15:58
*** shaohe_feng has quit IRC16:00
raj_singhsfinucan: Well for other cases yes, but for grouping we are removing the flags and adding todo's.16:00
sfinucanraj_singh: Can I ask why? The marker seemed like a good approach?16:00
raj_singhsfinucan: And for some political reasons too16:00
raj_singh:)16:00
*** shaohe_feng has joined #openstack-nova16:01
sfinucanraj_singh: ah16:01
*** yamahata has joined #openstack-nova16:01
*** BjoernT has joined #openstack-nova16:02
*** mat128 is now known as mat128|afk16:02
*** GB21 has quit IRC16:05
*** kylek3h_ has quit IRC16:06
*** markus_z has quit IRC16:07
*** kylek3h_ has joined #openstack-nova16:08
*** shaohe_feng has quit IRC16:10
*** ihrachys has quit IRC16:10
*** dims has quit IRC16:10
*** shaohe_feng has joined #openstack-nova16:11
kfarrsdague thanks for your comments on https://review.openstack.org/#/c/338518/ .  Do you think a google hangout would still be worthwhile?  Thanks!!16:11
openstackgerritAndrey Volkov proposed openstack/nova: Eliminate additional DB queries in nova lists  https://review.openstack.org/35555816:11
sdaguekfarr: is there anything in newton that you are blocked on here?16:11
*** efried has quit IRC16:12
sdaguebecause it wasn't entirely clear from that spec, and if the answer to that is no, I'd like to push this until after freeze to talk about16:12
sdagueand if the answer is yes, I'd like to understand that one more16:12
*** raj_singh has left #openstack-nova16:13
*** raj_singh has joined #openstack-nova16:13
mriedemsdague: i'm going to keep the change in 2.37 for enforcing server.networks.uuid to be a uuid rather than just a string,16:14
mriedemwe should close that door while we're in here16:14
sdaguemriedem: +116:15
mriedemi've already waffled over that 3 times in the last hour :)16:15
kfarrsdague, I was just concerned that the original patch would be reverted if I did not attempt to address concerns this cycle16:15
*** zenoway has quit IRC16:15
*** zenoway has joined #openstack-nova16:16
kfarrsdague but if the code is currently fine as is for Newton, I'm also ok with waiting until freeze to discuss it16:16
sdagueyeh, I think we're ok for newton.16:16
*** lucasagomes is now known as lucas-afk16:17
sdaguehonestly, I think the post freeze conversation needs to be a wider one about could we make barbican required at the iaas layer, because there are a lot of encryption features that would be good to be there out of the box that are all wonky with barbican not being in the fold16:18
*** ducttape_ has joined #openstack-nova16:18
mdboothdansmith: So, the gotFiles and imported_files thing16:18
dansmithmdbooth: the __init__ method of the new fixture is not called by any existing tests16:18
mdboothdansmith: Right, but the existing tests already call these things gotFiles and imported_files16:18
dansmithmdbooth: sure, but none will break if you name that one properly16:18
mdboothI'm not a fan of the way these tests work, btw, which is why I wrote the disks dict16:18
dansmithmdbooth: I think the previous pass you got was because you had to slowly evolve that name16:19
mdboothI consider them legacy, and imminently doomed16:19
dansmithso keep anything named so that you don't have to break tests, but for new things I think you should be moving to the proper name16:19
kfarrsdague, ok thanks.  Agreed that it would be good to have that conversation.  Would be fantastic to have barbican as a dependency.  I'll be back in touch at the beginning of September then?16:19
sdaguekfarr: sounds great16:19
mdboothCalling them the same in both places is less confusing imho, even if the name is horrible16:19
mdboothThis is purely for interoperability until the users have been rewritten16:20
mdboothIt's not an interface which will hang around, because the fixture provides a better one16:20
*** shaohe_feng has quit IRC16:20
*** zenoway has quit IRC16:20
mdboothMy new and rewritten tests exclusively use the new interfaces16:20
mdboothdansmith: Anyway, I can rename them, it's not a big deal16:21
*** shaohe_feng has joined #openstack-nova16:21
dansmithmdbooth: you know I'm talking only about the gotFiles in the __init__ on the constructor and on the class, right? those are used in like four places, and all new16:21
*** su_zhang has quit IRC16:21
mdboothSure, they're new because the constructor is new. But all the callers have an existing thing called gotFiles which they used to update themselves.16:22
mdboothNow the pass it to the fixture, and the fixture updates it.16:22
mdboothWhen they're rewritten, they will no longer have a thing called gotFiles.16:22
dansmithwhatever, don't rename it if you want and if jaypipes is fine then whatever.. however, it's all new code, it's a thing that is used internally to a few things with the fixture, and should not be named like that16:23
mdboothThis is purely for interoperability so I don't have to rewrite those tests completely.16:23
dansmithit is NOT for interop :)16:23
dansmithnothing existing calls it :)16:23
jaypipesdansmith: yeah, 345427 removes gotFiles entirely. currently reviewing that patch now.16:24
*** lbeliveau has quit IRC16:24
jaypipesdansmith: though I agree with you it's new code.16:24
dansmithyeah.16:25
jaypipesdansmith: but five patches later, it goes bye-bye16:25
mdboothjaypipes: Incidentally, I didn't especially like those new generator functions in driver. I have a patch locally which pulls them all into a new module.16:25
mdboothThe new module basically works the same way, but has a cleaner calling interface.16:25
mdboothIt will have its own tests, and this, I think will address your real concerns about the unitiness of the driver tests16:26
mdboothThe new interface is a StoragePolicy object with methods like local_disk() and ephemerals()16:26
mdboothAnd it returns objects on which you just call create()16:26
jaypipesmdbooth: yeah, I'm pretty deep into the reviews of this series now. I'm liking the end state.16:26
mdboothSo tests can easily mock at that level, and just check that we called create()16:27
mdboothNo need to worry about what ephemerals there should be, or whether there was a legacy backing file or whatever16:27
*** lbeliveau has joined #openstack-nova16:28
*** harlowja_at_home has quit IRC16:28
dansmithmdbooth: so I just made the change in like 60 seconds16:28
mdboothAnyway, as I say it's basically just code motion.16:28
dansmithif you're respinning I don't think it's a large ask16:28
*** ametts_ has joined #openstack-nova16:28
dansmithbut if jaypipes is going to +2 it anyway, then do what you want16:28
mdboothdansmith: You rewrote the tests which use gotFiles to assert on disks instead?16:28
dansmithmdbooth: nothing outside the fixture references the fixture's gotFiles16:29
mdboothdansmith: Yeah, that change is absolutely no problem.16:29
*** yamahata has quit IRC16:29
mdboothI was just proposing to use the same, wrong name in both places :)16:29
mdboothYou could rename it in the callers too, I guess.16:30
*** ametts has quit IRC16:30
mdboothIs that what you did?16:30
mdboothdansmith: Anyway, you had at least 1 thing which should have been a pep8 failure imho16:30
*** shaohe_feng has quit IRC16:30
mdboothAnd you ask for some re-indentation16:30
cmartinI am trying to work on some mox to mock conversion in test_virt_drivers and I am unsure of how to convert self.mox.UnsetStubs() can anybody help or point me to some documentation I can refer to?16:30
mdboothSo I was going to respin anyway16:30
mdboothNot a problem16:30
openstackgerritPushkar Umaranikar proposed openstack/nova: Add related options to floating ip config options  https://review.openstack.org/35556116:31
*** shaohe_feng has joined #openstack-nova16:31
dansmithmdbooth: yes, you could fix it with git show and sed :)16:31
mdboothMeh. I try to keep my patches small... :P16:31
mdboothIt's np, I'll do it first thing in the morning.16:31
dansmithmdbooth: it won't change the line count at all16:31
*** Apoorva has joined #openstack-nova16:31
dansmithmdbooth: I'll do it for you in a bit16:31
mdboothdansmith: Ok, cool. Thanks. I'll check in the morning and do it anyway if you haven't.16:32
openstackgerritJohn Garbutt proposed openstack/nova: Improve consistency in libvirt  https://review.openstack.org/35367916:32
*** Jeffrey4l_ has quit IRC16:33
dansmithmdbooth: whatever, it'll make conflicts on the following patches16:33
dansmithmdbooth: I'll take my meds and shut up for five patches16:33
*** bwallis has quit IRC16:36
*** kevinz has quit IRC16:36
mriedemcmartin: the mox->mock conversion is on hold as an effort until ocata16:38
cmartinmriedem: oh ok then I'll find a different blueprint to work on16:39
*** nic has joined #openstack-nova16:39
mriedemcmartin: fwiw, we're really closing down for the release, so at this point, bug triage, reviews and bug fixes are most valuable16:40
mriedemwe've got 3 weeks until feature freeze16:40
jaypipesmdbooth: k, I'm clear through reviews of the largest series of your code. let me know if you have any questions on my comments.16:40
*** shaohe_feng has quit IRC16:41
*** devkulkarni1 has joined #openstack-nova16:41
*** shaohe_feng has joined #openstack-nova16:41
*** dims has joined #openstack-nova16:42
cmartinmriedem: ok I'll just do that then16:43
*** devkulkarni has quit IRC16:44
*** oomichi has joined #openstack-nova16:45
openstackgerritJohn Garbutt proposed openstack/nova: Deprecate all topic conf options  https://review.openstack.org/35160816:45
mriedemcmartin: something else that's easy to hack on https://bugs.launchpad.net/python-novaclient/+bug/161310516:45
openstackLaunchpad bug 1613105 in python-novaclient "functional tests leak cinder volumes" [Undecided,New]16:45
mriedemthere are a few places in the novaclient functional tests that create a volume for testing but don't cleanup the volume16:46
*** dims has quit IRC16:47
*** anush__ has joined #openstack-nova16:47
jaypipessyjulian: done.16:48
*** shaohe_feng has quit IRC16:51
*** anush_ has quit IRC16:51
*** shaohe_feng has joined #openstack-nova16:52
*** dims has joined #openstack-nova16:53
*** tonytan4ever has quit IRC16:54
*** rama_y has joined #openstack-nova16:54
*** GB21 has joined #openstack-nova16:55
*** lucas-afk is now known as lucasagomes16:58
sdaguemriedem: you want to +1 this - https://review.openstack.org/355566 ?16:59
mriedemdone17:00
*** anush__ has quit IRC17:00
openstackgerritMaciej Szankin proposed openstack/nova: Deprecate all topic conf options  https://review.openstack.org/35160817:00
*** sdake has joined #openstack-nova17:00
*** shaohe_feng has quit IRC17:01
*** shaohe_feng has joined #openstack-nova17:02
*** bwallis has joined #openstack-nova17:02
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/35445917:03
sfinucanBobBall: johnthetubaguy: I'm going to jump offline soon, but before I forget: is the XenAPI code still stuck with Python 2.4?17:05
johnthetubaguysfinucan: for the plugins, yes17:05
sfinucanjohnthetubaguy: drat - noqa time so17:05
BobBallSo yes, in dom017:05
BobBallnon-py3 compatible bits?17:05
ildikovjohnthetubaguy: mriedem: we have the meeting if there's anything from your side you would like to hear or say17:05
*** jaosorior has quit IRC17:06
johnthetubaguyildikov: did we cover most bits in channel already? not sure if we got got the bottom of the locks stuff17:06
ildikovjohnthetubaguy: I haven't read the last bits, but that's covered and nothing else regarding the API interactions stuff, then it should be fine17:07
*** mat128|afk is now known as mat12817:07
*** harlowja has joined #openstack-nova17:08
*** yamahata has joined #openstack-nova17:09
*** shaohe_feng has quit IRC17:11
*** edand has joined #openstack-nova17:12
*** shaohe_feng has joined #openstack-nova17:12
*** ihrachys has joined #openstack-nova17:12
sfinucanBobBall: Yeah, I'm working on that .py extension thing again17:13
sfinucanCan't fix 'Exception, exc' -> 'Exception as exc'17:14
*** danpb has quit IRC17:15
beaglesvladikr, quick question about PCI device lists... say someone has a PF linked to an OVS bridge and whitelists it, would nova be able to filter it out of the pci_stats?17:15
*** oanson has joined #openstack-nova17:16
openstackgerritStephen Finucane proposed openstack/nova: plugins/xenserver: Add '.py' extension  https://review.openstack.org/28943117:17
openstackgerritStephen Finucane proposed openstack/nova: plugins/xenserver: Resolve PEP8 issues  https://review.openstack.org/35557417:17
*** su_zhang has joined #openstack-nova17:17
beaglesvladikr, on one hand I don't really want it to be because I don't like the idea of what could happen if a guest actually boots and pulls it in17:18
vladikrbeagles, hmm... I doubt it. if the device is online and has a capability of a physical function , I think we would count it .17:19
vladikrbeagle, the pf will disappear from the host while the guest is using it, iirc17:20
vladikrbeagles, ^^17:21
beaglesvladikr, ack17:21
*** su_zhang has quit IRC17:21
*** yuelongguang has quit IRC17:21
beaglesvladikr, and at that point, if the interface was being used for something important ... kaboom :)17:21
vladikrbeagles, do you think we should filter it out?17:22
*** shaohe_feng has quit IRC17:22
*** su_zhang has joined #openstack-nova17:22
vladikrbeagles, true17:22
*** krtaylor has joined #openstack-nova17:22
beaglesvladikr, also a confirmation - a device won't be recognized by the resource tracker *unless* it has virtual functions associated with it?17:22
*** shaohe_feng has joined #openstack-nova17:22
vladikrbeagles, it doesn't has to have active virtual functions, just a capability17:23
beaglesvladikr, regarding filtering it... I don't know how we can do that really and really, this is the admin's responsibility to make sure that they don't something silly like that :)17:23
*** yuelongguang has joined #openstack-nova17:23
beaglesvladikr, that's what the whitelist is for after all17:24
vladikrbeagles, https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L507217:24
vladikrbeagles, yea, true17:24
*** mingyu has quit IRC17:24
*** lucasagomes is now known as lucas-dinner17:25
jaypipesalaski: https://review.openstack.org/#/c/352610/417:25
*** ayoung has quit IRC17:25
beaglesvladikr, in the nodedev-dumpxml, virt_functions doesn't show up unless there numvfs > 017:26
beaglesvladikr, I don't know if it does the same with the API though17:26
jaypipesalaski: https://review.openstack.org/#/c/312696/17:28
*** ihrachys has quit IRC17:29
*** shaohe_feng has quit IRC17:32
openstackgerritMatt Riedemann proposed openstack/nova: Add REST API support for get me a network  https://review.openstack.org/31639817:33
mriedemsdague: alex_xu: oomichi: thar she blar ^ the new format makes the validation a lot simpler17:33
vladikrbeagles, hmm..  you're right, I don't see it17:34
oomichimriedem: thanks, will check it later. how about tempest side?17:34
mriedemoomichi: that's next17:34
mriedemand the novaclient change17:34
mriedemand the spec17:34
oomichimriedem: ok, will check them also later17:35
*** shaohe_feng has joined #openstack-nova17:35
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Return None in get_instance_id_by_floating_address  https://review.openstack.org/35196017:37
*** rcernin has joined #openstack-nova17:37
*** kfarr has quit IRC17:37
beaglesvladikr, oah.. there's a comment in the code right below that moshele added that mentions it is dependent on libvirt version17:40
*** TravT has quit IRC17:40
*** ayoung has joined #openstack-nova17:41
*** shaohe_feng has quit IRC17:42
*** shaohe_feng has joined #openstack-nova17:43
*** tbachman has joined #openstack-nova17:44
*** tonytan4ever has joined #openstack-nova17:45
*** dbite has joined #openstack-nova17:45
*** JoseMello has joined #openstack-nova17:47
beaglesvladikr, mmmm. does the pci whitelisting mechanism work for PFs?17:47
*** raunak has joined #openstack-nova17:48
vladikrbeagles, ah, I was puzzled for a moment, why does it work on my workstation.. :)17:48
vladikrbeagles, it supposed to17:48
beaglesvladikr, I'm not sure how the match operation is supposed to work17:49
vladikrbeagles, are you using an alias or are you attaching the pf as a neutron port?17:50
beaglesvladikr, wait a sec.. misreading this a bit17:50
beaglesvladikr, well, actually that begs the next question, are PFs stored in the pci_devices table/17:51
beaglesvladikr, it isn't from what I'm seeing on this particular host - I'm just trying to rule out misconfiguration :)17:51
*** shaohe_feng has quit IRC17:52
vladikrbeagles, yes, afaik, they should be stored.17:52
*** hshiina has quit IRC17:53
*** shaohe_feng has joined #openstack-nova17:53
oomichimriedem: dansmith pointed strictly on https://review.openstack.org/#/c/31639817:54
mriedemgdi17:55
dansmithoomichi: mriedem appreciates typo fixes, as he is a fellow lover of proper spelling and grammar17:55
*** GB21 has quit IRC17:56
*** edand has quit IRC17:56
dansmithoomichi: other than that nit, I think it all makes sense to me.. are you close to +2 on that/17:56
vladikrbeagles, btw, if you are using an alias, you should add "device_type":"type-PF" to it, in addition to the vendor/product ids17:56
*** ijw has joined #openstack-nova17:56
beaglesvladikr, mmmm... okay17:56
beaglesvladikr, was using a devname and type-PF is specified17:56
beaglesvladikr, it's kinda weird because the VFs are getting in17:57
oomichidansmith: heh, I know. mriedem sometime put typos on his patches17:57
*** Sukhdev has quit IRC17:58
mriedemit's a test to see if anyone notices17:58
dansmithoomichi: I think he puts them in on purpose sometimes to see if people are paying attention17:58
dansmithhah17:58
beaglesvladikr, the thing that caught my eye was https://github.com/openstack/nova/blob/master/nova/pci/devspec.py#L16317:58
mriedemwow17:58
beaglesvladikr, but then I realized I needed to check what PciAddress actually does ;)17:58
vladikr:)17:59
oomichidansmith: I was ready to put my +2 because I missed it. I can avoid higher my disagreement ratio(that is already high18:00
dansmithoomichi: heh, okay, well, if you can hit it again once he fixes that typo then I'll circle back with it and we can be done :)18:00
mriedemi'm also going to move the 'br-x' uuid thing in the release note to the upgrade or other section18:01
mriedemsince that's not really a feature18:01
vladikrbeagles, if you'll switch to a debug mode you should see all the available device being reported18:02
beaglesvladikr, yeah, they are appearing the hypervisor's list but I suspect they are being filtered out by the whitelist. I just need to work out what the "gotcha" is :)18:02
*** shaohe_feng has quit IRC18:03
*** electrocucaracha has joined #openstack-nova18:03
*** shaohe_feng has joined #openstack-nova18:03
electrocucarachajaypipes: ping?18:04
vladikrbeagles, there is this : https://github.com/openstack/nova/blob/master/nova/pci/stats.py#L15618:04
*** pwnall has quit IRC18:04
vladikrbeagles, maybe it doesn't work well if you are whitelisting these by devname, as oppose to using a alias in the extra_specs or a direct-physical binding?18:06
beaglesvladikr, yeah, that's what I'm wondering18:07
vladikrbeagles, maybe whitelisting devname doesn18:08
vladikrbeagles, doesn't whitelist itself18:08
vladikronly anything that has a parent that matches the pci_address of that dev..18:09
*** nic has quit IRC18:10
vladikrwe should probably log the pool spec somewhere ..18:10
beaglesvladikr, yup that's kind of where my head is at..18:12
electrocucarachajohnthetubaguy: ping?18:12
openstackgerritMatt Riedemann proposed openstack/nova: Add REST API support for get me a network  https://review.openstack.org/31639818:12
beaglesvladikr, PciAddress::match()'s 2nd parameter is that of the parent_address (apparently) which isn't going to match properly18:12
*** shaohe_feng has quit IRC18:13
*** ihrachys has joined #openstack-nova18:13
*** shaohe_feng has joined #openstack-nova18:14
openstackgerritGuillaume Espanel proposed openstack/nova: Reduce time and memory usage of tenant usage.  https://review.openstack.org/34373418:15
beaglesvladikr, I wonder if we are getting bad synergy with an older version of libvirt18:19
beaglesvladikr, as in it might just all work with libvirtd >= 1.3.018:19
*** tblakes has quit IRC18:19
beaglesvladikr, unfortunately, I can't look deeper at the moment :(18:20
sdaguemriedem: the new version of this looks so much better18:20
sdagueyay for pushing the validation back to the json schema18:20
*** Apoorva_ has joined #openstack-nova18:20
*** dbite has quit IRC18:20
*** dbite has joined #openstack-nova18:21
vladikrbeagles, why do you think so? Is it because of the capability that will be exposed in 1.3?18:21
beaglesvladikr, idk, just spitballing as to why it's coming up now18:22
*** xyang1 has quit IRC18:22
vladikrbeagles, I tend to think that it's just how the devname resolution in devspec works ..18:22
beaglesvladikr, :) yeah18:23
*** shaohe_feng has quit IRC18:23
*** shaohe_feng has joined #openstack-nova18:23
*** tblakes has joined #openstack-nova18:23
*** Apoorva has quit IRC18:24
beaglesvladikr, going to try vendor/product/pci address whitelist18:24
*** mingyu has joined #openstack-nova18:25
vladikrbeagles, ok, I'll try to see how to improve the devspec to include the device itself..18:25
beaglesvladikr, cool thanks18:25
*** xyang1 has joined #openstack-nova18:26
*** dbite has quit IRC18:30
*** mingyu has quit IRC18:30
*** jichen has joined #openstack-nova18:30
*** ftersin_ has left #openstack-nova18:31
mriedemsdague: yeah18:33
*** shaohe_feng has quit IRC18:33
mriedemoh and +W even18:33
mriedemnice18:33
*** neophy has joined #openstack-nova18:33
*** shaohe_feng has joined #openstack-nova18:34
sdaguemriedem: you want to rereview - https://review.openstack.org/#/c/354981, I assume it will pass functional, but not while running on rax. And still waiting for the timeout increase to land.18:35
*** efoley has quit IRC18:36
mriedemyeah18:36
*** ayoung has quit IRC18:37
openstackgerritSarafraj Singh proposed openstack/nova: Remove deprecated manager classes in service.py  https://review.openstack.org/33855318:39
*** tbachman has quit IRC18:40
openstackgerritSarafraj Singh proposed openstack/nova: Remove deprecated manager classes in service.py  https://review.openstack.org/33855318:40
openstackgerritSarafraj Singh proposed openstack/nova: Remove deprecated manager classes in service.py  https://review.openstack.org/33855318:41
jaypipeselectrocucaracha: pong18:41
*** rcernin has quit IRC18:42
electrocucarachahey jaypipes, we're working on the implementation of OVO in neutron and I noticed that you submitted a bp in juno for adding a validation for StringFields18:42
electrocucarachahttps://blueprints.launchpad.net/nova/+spec/string-field-max-length18:43
electrocucarachajaypipes: ^18:43
*** ijw has quit IRC18:43
*** shaohe_feng has quit IRC18:44
*** ijw has joined #openstack-nova18:44
*** marst has joined #openstack-nova18:44
*** tbachman has joined #openstack-nova18:44
*** shaohe_feng has joined #openstack-nova18:44
jaypipeselectrocucaracha: is there a question in there somewhere? :)18:45
electrocucarachajaypipes: sorry, I forgot to make the question, hahaa18:46
*** Apoorva_ has quit IRC18:46
electrocucarachajaypipes: the question is, I noticed that oslo-versionedobjects doesn't have that validation implemented18:46
electrocucarachahttps://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/fields.py#L711-L71218:46
*** Apoorva has joined #openstack-nova18:47
electrocucarachajaypipes: I would like to know if there were something to block the implementation of that?18:47
openstackgerritDanil Akhmetov proposed openstack/nova: Handle user-defined ephemeral disk size if provided  https://review.openstack.org/35252218:47
electrocucarachajaypipes: or it was only implemented for nova18:47
jaypipeselectrocucaracha: it wasn't implemented in Nova, no. I will obselete that blueprint.18:47
*** pwnall has joined #openstack-nova18:48
electrocucarachajaypipes: I think that's still valuable to have it, maybe we can retake that effort18:48
jaypipeselectrocucaracha: I wouldn't mind adding that functionality to ovo, however IIRC the pushback I received from dansmith is that we would not be able to control the versioning of the field if the max length changed over time...18:48
*** ijw has quit IRC18:49
* electrocucaracha is thinking18:49
jaypipeselectrocucaracha: but it was a long time ago, so honestly, I don't really know at this point :)18:49
dansmithI don't know that I said that, fwiw.. if you add a new string type that embeds the length into the representation used for the versioning then it's probably fine18:50
jaypipeselectrocucaracha: there are lots of fields that can change their schema over time (e.g. Enum or StateMachine-based fields) that we don't have a mechanism that I know of to control version bumps of the contained objects if the definitions of the fields change.18:50
*** haplo37__ has quit IRC18:50
*** ijw has joined #openstack-nova18:50
dansmithjaypipes: we just don't change them in incompatible ways, or we handle it in the backporting routines18:50
jaypipesdansmith: right, I just meant there's no code-based control or enforcement of that.18:51
dansmithjaypipes: electrocucaracha the length getting longer is the only real problem, and you'd just have to truncate or fail during backport somehow18:51
jaypipesdansmith: you mean the length getting shorter I presume?18:51
dansmiththe version hash can _detect_ a violation, but otherwise, correct yeah18:51
dansmithjaypipes: well either I guess18:52
*** efried has joined #openstack-nova18:52
dansmithjaypipes: if you send something too long to an older node with a shorter limit, then that's a problem18:52
jaypipesdansmith: ah, right indeed.18:52
mriedemsdague: aren't the magic callbacks in https://review.openstack.org/#/c/354981/6/novaclient/tests/unit/v2/fakes.py@1912 awesome?18:52
sdaguemriedem: yeh, but at least they are predictable18:53
openstackgerritMaciej Szankin proposed openstack/nova: Fix check_config_option_in_central_place  https://review.openstack.org/35559718:53
mriedemright, once you get it down in your head why things fail it's not so bad18:53
electrocucarachajaypipes: dansmith I didn't think about that scenario, but it makes sense18:54
*** shaohe_feng has quit IRC18:54
*** shaohe_feng has joined #openstack-nova18:55
*** su_zhang has quit IRC18:56
*** rcrit has joined #openstack-nova18:56
rcritmikal, ping re auth and the new vendor data REST API18:57
mriedemsdague: is anything testing the has_neutron=True case?18:57
sdaguemriedem: yeh, that's why the new get_v2_0_networks call exists19:04
*** haplo37__ has joined #openstack-nova19:04
*** shaohe_feng has quit IRC19:04
sdagueapparently we're default True on that in the tests19:04
openstackgerritSarafraj Singh proposed openstack/nova: Improve help text for glance options  https://review.openstack.org/32400719:05
mriedemsdague: oh because the fake get_endpoint() is returning "http://nova-api:8774/v2.1/190a755eef2e4aac9f06aa6be9786385"19:05
mriedemand the has_neutron sees that and assumes it's cool19:06
sdagueah, right19:06
*** shaohe_feng has joined #openstack-nova19:06
*** fifieldt has quit IRC19:07
*** TravT has joined #openstack-nova19:09
*** Swami has joined #openstack-nova19:10
*** haplo37__ has quit IRC19:10
openstackgerritMaciej Szankin proposed openstack/nova: Fix check_config_option_in_central_place  https://review.openstack.org/35559719:10
*** kfarr has joined #openstack-nova19:10
*** ametts_ has quit IRC19:13
*** shaohe_feng has quit IRC19:14
openstackgerritSarafraj Singh proposed openstack/nova: Remove redundant check from code  https://review.openstack.org/35012219:14
*** shaohe_feng has joined #openstack-nova19:15
*** tblakes has quit IRC19:15
*** TravT_ has joined #openstack-nova19:15
mriedemsdague: you want me to hack on https://review.openstack.org/#/c/354981/ while you're in infra looking at why the job is slow?19:16
*** devkulkarni has joined #openstack-nova19:17
*** devkulkarni1 has quit IRC19:17
sdaguemriedem: I'm about to swing back of to it. It might make the most sense if you want to work on the testing piece. Unless you want to swap and give me the testing and you do this one.19:17
*** ametts_ has joined #openstack-nova19:18
mriedemi can poke on the testing one, or i'll work on rebasing dan's change on top of this19:18
*** ametts_ has quit IRC19:18
*** fifieldt has joined #openstack-nova19:19
*** ametts has joined #openstack-nova19:19
*** TravT has quit IRC19:19
mriedemVek: WIP :) https://review.openstack.org/#/c/355215/19:21
*** haplo37__ has joined #openstack-nova19:22
mriedemsdague: also, https://review.openstack.org/#/c/355148/ would be helpful in case the things i'm seeing locally are not the same we'd hit upstream19:22
*** Hosam has joined #openstack-nova19:23
*** tblakes has joined #openstack-nova19:24
*** shaohe_feng has quit IRC19:25
sdaguemriedem: yeh, though I'd rather get a local working stack first before we do that instead of burning nodes when we know it's borked19:25
*** Sukhdev has joined #openstack-nova19:25
mriedemsure19:25
mriedemi love the smell of borked burning nodes in the morning19:25
*** shaohe_feng has joined #openstack-nova19:25
*** su_zhang has joined #openstack-nova19:26
mriedemalaski: dansmith: uh oh http://logs.openstack.org/98/316398/37/check/gate-tempest-dsvm-cells/61db698/logs/devstacklog.txt.gz#_2016-08-15_19_18_06_08919:28
mriedemcells v1 job19:29
dansmithmriedem: we broke ironic too19:29
dansmithmriedem: revert is in the pipeline19:29
dansmithit's an ordering thing and I have an adjustment up to test as well19:29
mriedemok, can you link me to the thing so i can e-r it?19:30
dansmithI would love to19:30
alaskidansmith: we may need to not run the migration for cellsv1, or ignore the error. there are no hosts in the top level cell so it will always return that19:30
dansmithbut jroll's username on gerrit is UNSEARCHABLE19:30
jrollwat19:30
jrolljim@jimrollenhagen.com19:30
dansmithalaski: ah, good point19:30
mriedemhttps://review.openstack.org/#/c/355599/19:31
alaskiI forget that we said v1 users will need to do the complicated thing19:31
*** bvanhav has quit IRC19:31
alaskislightly more complicated19:31
mriedemwe don't run cells v1 on devstack changes?19:31
mriedemmust be in the experimental queue19:31
openstackgerritSarafraj Singh proposed openstack/nova: Remove redundant check from code  https://review.openstack.org/35012219:32
*** su_zhang has quit IRC19:34
*** oanson has quit IRC19:34
*** shaohe_feng has quit IRC19:35
mriedemyou can't find jroll in LP either19:35
jrollO_o19:35
jrollthis is the downside of nobody knowing my actual name, eh19:35
*** shaohe_feng has joined #openstack-nova19:35
jrollmriedem: LP is jim-rollenhagen if you actually need it19:36
mriedemjimmy mcjam von rollenhaggen V?19:36
jrolls/V/IV/19:37
jrollclose though!19:37
mriedemapollo dies and you fought the russians in IV19:37
mriedemclassic19:37
*** tonytan4ever has quit IRC19:41
*** ankur-gupta-f has joined #openstack-nova19:42
sdaguemriedem: so for - https://review.openstack.org/#/c/354981/ your concern is there are no unit tests?19:44
dansmithalaski: wow, you really "touched" a lot of people with that five line change19:44
sdaguefor the find_network bits19:44
*** shaohe_feng has quit IRC19:45
*** shaohe_feng has joined #openstack-nova19:46
mriedemsdague: yeah it looks like we're not hitting any of that code somehow19:47
mriedemsdague: i'm not sure why though since i thought https://review.openstack.org/#/c/354981/6/novaclient/tests/unit/v2/fakes.py would handle it19:47
mriedembut maybe that was before you added the mock to just have client.has_neutron return False?19:47
*** ijw has quit IRC19:48
mriedemunless it's functional tests, i didn't run those19:48
sdagueit will get run when the command is run for real19:48
sdagueI don't think we have tests on this part of the shell at all19:48
*** electrocucaracha has left #openstack-nova19:48
*** ayoung has joined #openstack-nova19:48
mriedemwe do for the ones that you added the mock to return False right?19:49
*** yamahata has quit IRC19:49
mriedemin https://review.openstack.org/#/c/354981/6/novaclient/tests/unit/v2/test_shell.py19:49
*** yamahata has joined #openstack-nova19:49
alaskidansmith: do I get a prize, or just get to be the target of ire?19:49
dansmithalaski: sadly the ire is the prize19:50
openstackgerritMaciej Szankin proposed openstack/nova: config options: Improve help for SPICE  https://review.openstack.org/31704619:50
sdaguemriedem: ah, right19:50
jrollpft, I'll totally buy alaski a beer, I like people that find fragile things19:50
sdaguemriedem: ok, yeh, I'll pop some more into there19:51
mriedemcool19:51
sdaguethat's actually a bit easier than the thing I was going to do19:52
sdaguefwiw, it works for reals, just not in the tests19:52
*** prateek has joined #openstack-nova19:53
*** fragatina has quit IRC19:53
*** shaohe_feng has quit IRC19:55
*** shaohe_feng has joined #openstack-nova19:56
*** tonytan4ever has joined #openstack-nova19:58
*** oomichi_ has joined #openstack-nova20:02
*** oomichi has quit IRC20:03
*** oomichi_ is now known as oomichi20:03
*** shaohe_feng has quit IRC20:06
*** Apoorva has quit IRC20:06
mriedemweird, do we run novnc in devstack when using neutron but not when using nova-net?20:06
*** shaohe_feng has joined #openstack-nova20:06
mriedembecause novaclient.tests.functional.v2.legacy.test_consoles.TestConsolesNovaClient.test_vnc_console_get fails with neutron devstack, and you get a vnc console url back, which the test doesn't expect20:06
*** liverpooler has quit IRC20:07
*** TravT_ is now known as TravT20:08
*** su_zhang has joined #openstack-nova20:08
*** ankur-gupta-f has left #openstack-nova20:12
mriedemwhat i need is like a, oh idk, capabilities API or something20:13
alaskior a traits API20:13
edleafemriedem: such silly thoughts20:13
*** neophy has quit IRC20:14
mriedemdoffm: why do we check for CommandFailed twice here? https://review.openstack.org/#/c/230149/5/novaclient/tests/functional/v2/legacy/test_consoles.py@3720:15
mriedemi mean, it's ran twice, expected to fail both times, is the 2nd call just to parse the error string?20:15
mriedemb/c we could that in a single call20:15
*** whenry has joined #openstack-nova20:15
*** shaohe_feng has quit IRC20:16
*** shaohe_feng has joined #openstack-nova20:16
mriedemhuh, ok,20:17
mriedemso ENABLED_SERVICES in devstack defaults to include n-novnc20:17
mriedembut in the gate we don't set that20:17
*** Apoorva has joined #openstack-nova20:17
mriedemso these functional tests rely on how devstack-gate sets up the env it seems20:17
mriedemsdague: ^ any suggestion on how to handle that? tempest would make it configurable.20:18
*** cargonza has joined #openstack-nova20:20
sdaguemriedem: ok, so that's a bad test if it's expecting that to not work20:22
*** jichen has quit IRC20:22
sdagueI think we want to be careful about making this a thing that you have to do lots of manual config on20:23
mriedemyeah, me too20:23
mriedembut i don't think supported consoles are a thing i can discover20:23
mriedemfor a given instance, until we have a capabilities api20:23
*** tri2sing has quit IRC20:23
mriedemi mean, i can skip this locally for now and realize it's just going to fail20:23
mriedemor i can kill the novnc service on my devstack to 'workaround' it20:24
sdaguewhat's the actual failure?20:24
*** pwnall has quit IRC20:24
sdaguebecause if this is failing if consoles actually exist, the test is just wrong20:24
*** ijw has joined #openstack-nova20:25
mriedem testtools.matchers._impl.MismatchError: <bound method TestConsolesNovaClient.nova of <novaclient.tests.functional.v2.legacy.test_consoles.TestConsolesNovaClient.test_vnc_console_get id=0x7f50b588c790>> returned '+-------+----------------------------------------------------------------------------------+\n| Type  | Url                                                                              |\n+-------+-------------------------------20:25
mriedemi get a response20:25
mriedemthe test expects it to fail20:25
sdagueok, so that's just a wrong test20:25
sdaguehonestly, probably should just be deleted20:25
mriedemwell,20:26
sdagueor if you want to fix it, it should handle the success criteria20:26
mriedemwe do have it to make sure the client picks the correct API b/c there is a 2.5 boundary here20:26
*** shaohe_feng has quit IRC20:26
mriedem'this can pass or fail, let's just always consider it successful' :)20:26
sdaguenot in legacy20:26
mriedemsure20:26
sdaguewell there are specific outputs to expect20:26
*** shaohe_feng has joined #openstack-nova20:26
mriedemi'll work it as a separate bug20:27
sdaguethere is a range of legit behavior20:27
sdagueit either gets good output like X, or it fails with a specific failure20:27
*** tonytan4ever has quit IRC20:27
mriedemyup20:27
sdagueand, while that's not as good as there being only 1 correct response, it is success criteria20:28
sdagueand, blame doffm, he wrote it :)20:28
*** xyang1 has quit IRC20:29
*** marst has quit IRC20:29
*** xyang1 has joined #openstack-nova20:29
beaglesvladikr, for fun: https://bugs.launchpad.net/nova/+bug/161343420:30
openstackLaunchpad bug 1613434 in OpenStack Compute (nova) "Whitelisted PFs aren't being recognized " [Undecided,New]20:30
*** devkulkarni has quit IRC20:31
mriedemhttps://bugs.launchpad.net/python-novaclient/+bug/161343520:31
openstackLaunchpad bug 1613435 in python-novaclient "TestConsolesNovaClient.test_vnc_console_get fails if you're using default devstack" [Undecided,New]20:31
*** ociuhandu has quit IRC20:31
mriedemsdague: heh, look who +Wed that bad boy https://review.openstack.org/#/c/230149/20:32
*** sdake has quit IRC20:32
openstackgerritMatt Riedemann proposed openstack/python-novaclient: WIP: Skip nova-network-only tests if using Neutron  https://review.openstack.org/35521520:33
sdaguegah, I'm so annoyed that testtools assertRaises is not a context manager like in unittest20:35
mriedemtesttools has some expected exception context manager20:36
sdaguemriedem: link?20:36
*** shaohe_feng has quit IRC20:36
mriedemsdague: https://github.com/openstack/tempest/blob/master/tempest/api/compute/servers/test_virtual_interfaces.py#L5520:37
*** shaohe_feng has joined #openstack-nova20:37
*** fragatina has joined #openstack-nova20:41
*** fragatina has quit IRC20:42
*** fragatina has joined #openstack-nova20:43
sdagueyeh, got it now. It's still annoying that this diverges from stdlib20:44
sdagueok, I've got new tests20:44
*** tonytan4ever has joined #openstack-nova20:45
*** shaohe_feng has quit IRC20:47
*** shaohe_feng has joined #openstack-nova20:47
*** gouthamr has quit IRC20:51
*** marst has joined #openstack-nova20:51
mikalMorning20:51
mikalrcrit: you still around?20:52
rcritmikal, yup20:52
mikalrcrit: what's up?20:53
rcritso question about how auth is expected to work with the vendor_data2.json20:53
rcritthere is a bit of auth code currently in the driver, and it works, but only if the auth filter is enabled20:54
rcritif the request comes in from a guest, ala curl http://169.254.169.254/openstack/2016-10-06/vendor_data2.json20:54
rcritthere is no auth20:54
rcritso I'm not sure how paste-wise is the best way to configure a REST service20:54
mikalHuh, yeah. I can see that -- the client doesn't pass in a keystone auth token, so we don't either20:54
rcritand whether that service should get its own service user with which to obtain tokens to talk to other services, like glance20:54
rcritnot sure what best practice is here20:55
mikalI'm not either. Can we start an openstack-dev thread to talk that through? I think that might work better than asking people here.20:55
rcritsure, I can start that. What tag(s) would you recommend, [nova] good enough or something else?20:56
mikalPerhaps [nova][keystone] ?20:56
rcritworks for me, thanks.20:56
mikalThanks for all your testing by the way, I really appreciate it20:56
*** shaohe_feng has quit IRC20:57
openstackgerritSean Dague proposed openstack/python-novaclient: Use neutron for network name -> id resolution  https://review.openstack.org/35498120:57
rcritwe'll call it a team effort :-)20:57
*** shaohe_feng has joined #openstack-nova20:57
*** sdake has joined #openstack-nova20:57
sdaguemriedem: ok... I think that addresses your concerns20:57
jrolldoesn't metadata service auth by IP address?20:57
jrollmikal: ^ just out of curiousity20:57
mikaljroll: this is the auth to a new external service from the metadata service though20:58
mikalI naively thought I could just pass through the client keystone token, but that's not true20:58
jrollahh20:59
*** JoseMello has quit IRC21:00
*** lpetrut has joined #openstack-nova21:03
*** haplo37__ has quit IRC21:03
*** smatzek has quit IRC21:05
*** shaohe_feng has quit IRC21:07
cfriesen_anyone on here that knows something about PCIDevice class?21:07
*** ihrachys has quit IRC21:08
cfriesen_or PciDevice rather21:08
*** nic has joined #openstack-nova21:08
*** sdake has quit IRC21:08
mriedemsdague: cool got the console func tests passing locally now21:09
*** shaohe_feng has joined #openstack-nova21:10
*** lpetrut has quit IRC21:12
*** nic has quit IRC21:13
openstackgerritSivasathurappan Radhakrishnan proposed openstack/nova: Remove context object in oslo.log method  https://review.openstack.org/31710921:15
cfriesen_when serializing an object for RPC, how is 'nova_object.changes' supposed to handle a field which has been removed from 'nova_object.data'?  Should something be automatically removing it from 'nova_object.changes'?21:15
*** sdake has joined #openstack-nova21:17
*** shaohe_feng has quit IRC21:17
scottdamriedem: For new Cinder volume-attach API, we no longer need nor care about instance mountpoint, do we?21:17
*** shaohe_feng has joined #openstack-nova21:18
*** haplo37__ has joined #openstack-nova21:18
mriedemscottda: correct, since like liberty when using libvirt21:18
mriedemit picks one for you21:18
mriedemscottda: mountpoint was always optional in the rest api actually21:18
scottdamriedem: That's what I thought. We might as well get rid of all that in Cinder while we have the chance...21:18
openstackgerritMatt Riedemann proposed openstack/python-novaclient: Handle successful response in console functional tests  https://review.openstack.org/35564521:18
mriedemsdague: ^21:18
*** mvk has joined #openstack-nova21:19
*** pwnall has joined #openstack-nova21:20
*** lpetrut has joined #openstack-nova21:23
*** rstarmer_ has joined #openstack-nova21:24
rstarmer_hello, I'm trying to launch VMs on a shiny new Kolla installed environment, and I'm getting a new scheduler error: Require both a host and instance NUMA topology to fit instance on host. numa_fit_instance_to_host /usr/lib/python2.7/site-packages/nova/virt/hardware.py:121321:25
rstarmer_Anyone seen this before?21:25
*** pwnall has quit IRC21:26
*** pwnall has joined #openstack-nova21:27
*** shaohe_feng has quit IRC21:28
*** shaohe_feng has joined #openstack-nova21:28
*** ametts has quit IRC21:28
*** prateek has quit IRC21:29
*** ravikama_ has quit IRC21:35
openstackgerritSivasathurappan Radhakrishnan proposed openstack/nova: Check for volume size  https://review.openstack.org/34831721:37
*** shaohe_feng has quit IRC21:38
*** yamahata has quit IRC21:38
*** shaohe_feng has joined #openstack-nova21:39
*** sdake has quit IRC21:39
*** tbachman_ has joined #openstack-nova21:47
*** amotoki has quit IRC21:48
*** cfriesen_ has quit IRC21:48
*** shaohe_feng has quit IRC21:48
*** burgerk has quit IRC21:48
*** tbachman has quit IRC21:48
*** tbachman_ is now known as tbachman21:48
*** cfriesen_ has joined #openstack-nova21:49
*** shaohe_feng has joined #openstack-nova21:49
*** cfriesen_ is now known as cfriesen21:49
mriedemsdague: another fun one https://bugs.launchpad.net/python-novaclient/+bug/1613454 - 60s is too fast, tempest defaults the server build timeout to 300s21:51
openstackLaunchpad bug 1613454 in python-novaclient "novaclient.tests.functional.v2.test_trigger_crash_dump fails in default local devstack setup" [Undecided,New]21:51
mriedemi'm debugging it locally and seeing the guest os is booting, just not done in 60s21:51
mriedemi am testing with a smaller VM, 4 cpu and 8gb ram21:52
*** devkulkarni has joined #openstack-nova21:52
mriedemstill, i shouldn't need an 8VCPU VM to run novaclient functional tests21:53
*** sdake has joined #openstack-nova21:54
*** harlowja has quit IRC21:55
openstackgerritMatt Riedemann proposed openstack/python-novaclient: Make wait_for_server_os_boot wait longer  https://review.openstack.org/35565821:56
*** tonytan4ever has quit IRC21:57
*** burt has quit IRC21:58
*** shaohe_feng has quit IRC21:58
*** shaohe_feng has joined #openstack-nova21:59
openstackgerritDan Smith proposed openstack/nova: Make simple_cell_setup work when multiple nodes are present  https://review.openstack.org/35565921:59
*** amotoki has joined #openstack-nova22:00
*** matrohon has quit IRC22:00
*** amotoki has quit IRC22:00
mriedemand with that, i've got a clean local novaclient functional run22:01
mriedemand nova-net only tests are properly skipped22:01
openstackgerritMatt Riedemann proposed openstack/python-novaclient: Skip nova-network-only tests if using Neutron  https://review.openstack.org/35521522:01
*** yamahata has joined #openstack-nova22:01
*** mtanino has quit IRC22:03
cfriesenfor a nova object is it ever valid to have self.obj_what_changed() return a field that doesn't exist in that version of the object?22:04
mriedemwe probably should have had 355599 bumped to the head of the gate queu22:04
mriedemsince everything is backed up on22:04
*** thorst_ has quit IRC22:08
*** shaohe_feng has quit IRC22:09
*** mdrabe has quit IRC22:09
*** mriedem has quit IRC22:09
*** shaohe_feng has joined #openstack-nova22:09
*** fragatin_ has joined #openstack-nova22:10
*** jamesden_ has quit IRC22:10
*** kfarr has quit IRC22:10
*** beagles is now known as beagles_brb22:11
*** lpetrut has quit IRC22:11
*** vladikr has quit IRC22:13
*** thorst_ has joined #openstack-nova22:13
*** fragatina has quit IRC22:13
*** fragatin_ has quit IRC22:14
*** fragatina has joined #openstack-nova22:15
*** haplo37__ has quit IRC22:15
*** bswartz has quit IRC22:15
*** thorst_ has quit IRC22:18
*** jistr has quit IRC22:18
*** ijw has quit IRC22:19
*** shaohe_feng has quit IRC22:19
*** jistr has joined #openstack-nova22:19
*** shaohe_feng has joined #openstack-nova22:20
*** sdake has quit IRC22:20
*** ijw has joined #openstack-nova22:22
*** shaohe_feng has quit IRC22:29
*** Hosam has quit IRC22:29
*** shaohe_feng has joined #openstack-nova22:30
*** tblakes has quit IRC22:32
*** kevinz has joined #openstack-nova22:33
*** ijw has quit IRC22:34
*** sdake has joined #openstack-nova22:35
*** kevinz has quit IRC22:37
*** krtaylor has quit IRC22:38
*** shaohe_feng has quit IRC22:39
*** ijw has joined #openstack-nova22:39
*** ducttape_ has quit IRC22:40
*** beagles_brb is now known as beagles22:42
*** shaohe_feng has joined #openstack-nova22:42
*** ravikama_ has joined #openstack-nova22:43
*** whenry has quit IRC22:45
*** efried has quit IRC22:49
*** shaohe_feng has quit IRC22:50
*** shaohe_feng has joined #openstack-nova22:50
*** ravikama_ has quit IRC22:50
*** edmondsw has quit IRC22:51
*** sdake has quit IRC22:57
*** mriedem has joined #openstack-nova22:57
*** tonytan4ever has joined #openstack-nova22:58
*** shaohe_feng has quit IRC23:00
*** nic has joined #openstack-nova23:00
*** shaohe_feng has joined #openstack-nova23:01
*** tonytan4ever has quit IRC23:03
*** devkulkarni has quit IRC23:04
*** markvoelker has quit IRC23:06
*** xyang1 has quit IRC23:08
oomichimriedem: https://review.openstack.org/#/c/351960/ is easy for you again (I catch you now;)23:10
*** shaohe_feng has quit IRC23:10
*** shaohe_feng has joined #openstack-nova23:11
*** BjoernT has quit IRC23:13
*** baoli has joined #openstack-nova23:16
*** TravT has quit IRC23:18
*** shaohe_feng has quit IRC23:20
*** shaohe_feng has joined #openstack-nova23:21
*** devkulkarni has joined #openstack-nova23:29
*** shaohe_feng has quit IRC23:31
*** diogogmt has quit IRC23:31
*** shaohe_feng has joined #openstack-nova23:31
*** gjayavelu has joined #openstack-nova23:32
*** bwallis has quit IRC23:33
*** harlowja has joined #openstack-nova23:36
*** devkulkarni has quit IRC23:40
*** rama_y has quit IRC23:40
*** shaohe_feng has quit IRC23:41
*** rama_y has joined #openstack-nova23:41
*** shaohe_feng has joined #openstack-nova23:43
*** sdague has quit IRC23:44
*** rama_y has quit IRC23:46
*** shaohe_feng has quit IRC23:51
*** jaypipes has quit IRC23:51
*** shaohe_feng has joined #openstack-nova23:52
*** pwnall has quit IRC23:53
*** rrecio_ has quit IRC23:54
*** baoli has quit IRC23:54
*** bwallis has joined #openstack-nova23:55
*** takashin has joined #openstack-nova23:57
*** gjayavelu has quit IRC23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!