Thursday, 2016-08-25

*** mtanino has quit IRC00:00
*** praneshp has joined #openstack-nova00:00
*** shaohe_feng has quit IRC00:03
praneshpHello nova. I see that there is a  “x-openstack-request-id” header in responses that could be used to track status of calls across services. I was wondering if this can be created by the client/sent as part of the request instead of being generated in the server side.00:03
*** shaohe_feng has joined #openstack-nova00:04
harlowjaoh hi praneshp00:05
*** bwallis has quit IRC00:05
harlowjapraneshp  ummm, prob a oslo question i think, ha00:06
praneshpthanks harlowja00:06
*** david-lyle has quit IRC00:08
*** michchap_ has joined #openstack-nova00:11
*** michchap has quit IRC00:13
*** shaohe_feng has quit IRC00:13
*** gouthamr_ has joined #openstack-nova00:13
*** shaohe_feng has joined #openstack-nova00:14
*** qeelee has joined #openstack-nova00:14
*** gouthamr has quit IRC00:16
*** ducttape_ has quit IRC00:21
*** sdague has joined #openstack-nova00:22
stewie925hello guys I need some clarification on the "debug" conversation I had earlier in this chat room00:23
*** shaohe_feng has quit IRC00:23
stewie925I mean the "--debug" option when issuing a nova command00:24
stewie925I was expecting two00:24
*** liuyulong_zzzZ has quit IRC00:24
stewie925I was expecting two "curl POST" statements as the "nova boot" process creates 1) an entry for the instance table and 2) 1 or more entries for instance_system_metadata00:26
*** shaohe_feng has joined #openstack-nova00:26
stewie925I pointed out that only the "curl POST" for the instance row creation is shown in the --debug log.00:27
stewie925and the explanation given was "all curl calls should be displayed. but each curl call is one API request, and a single API request could result in multiple db writes."00:27
*** tbachman has joined #openstack-nova00:29
*** rmcall has quit IRC00:31
*** rmcall has joined #openstack-nova00:33
*** shaohe_feng has quit IRC00:34
*** shaohe_feng has joined #openstack-nova00:34
*** ducttape_ has joined #openstack-nova00:35
*** kylek3h has joined #openstack-nova00:37
sdaguestewie925: I think you have the wrong understanding of the nova API00:39
stewie925hi sdague - yeah I think I got a little confused00:39
*** ducttape_ has quit IRC00:40
sdaguehttps://github.com/openstack/nova/blob/eec3a2b9e8df358178eaea7069107fdd7df15ef3/nova/api/openstack/compute/servers.py#L449-L65600:40
sdaguethat is the nova function run on a server create00:40
stewie925thank you sdague!00:41
*** su_zhang has quit IRC00:42
stewie925and as for the instance_system_metadata00:42
*** su_zhang has joined #openstack-nova00:42
*** liuyulong_zzzZ has joined #openstack-nova00:42
*** raunak has quit IRC00:44
*** shaohe_feng has quit IRC00:44
openstackgerritJay Pipes proposed openstack/nova: rt: ensure resource provider records exist from RT  https://review.openstack.org/35879700:44
sdaguestewie925: that's down in compute.api.create00:44
*** shaohe_feng has joined #openstack-nova00:44
stewie925oh let me take a quick look00:45
*** su_zhang has quit IRC00:46
*** liuyulong_zzzZ has quit IRC00:47
*** ssurana has quit IRC00:47
*** ssurana has joined #openstack-nova00:47
stewie925compute.api.create =  nova/compute/api.py  under def create() ?00:50
*** ducttape_ has joined #openstack-nova00:50
stewie925am so sorry sdague, I see where the entries are being populated, but not where the actual row being created in the instance_system_metadata table.  sorry for being too detailed00:51
*** ducttape_ has quit IRC00:51
*** hoangcx has joined #openstack-nova00:52
*** ssurana has quit IRC00:52
*** shaohe_feng has quit IRC00:54
*** markvoelker has joined #openstack-nova00:55
*** shaohe_feng has joined #openstack-nova00:57
sdaguestewie925: sorry, it's kind of late here, and I need to crash out. I would suggest doing some git grepping through to see how the models are connected to the db, the objects to the models, and see how they fill out from there00:57
stewie925no problem sdague, really appreciate it00:58
stewie925sdague: THANK YOU00:58
stewie925have a restful night00:58
*** tuanla_ has joined #openstack-nova01:03
*** shaohe_feng has quit IRC01:04
*** shaohe_feng has joined #openstack-nova01:05
*** phuongnh has joined #openstack-nova01:06
*** sdake has quit IRC01:06
*** lixiaoy1 has quit IRC01:07
*** lixiaoy1 has joined #openstack-nova01:07
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/35952101:09
*** thorst has quit IRC01:09
*** thorst has joined #openstack-nova01:10
*** Sukhdev has quit IRC01:10
*** jamielennox is now known as jamielennox|away01:11
*** jamielennox|away is now known as jamielennox01:11
*** raunak has joined #openstack-nova01:13
*** shaohe_feng has quit IRC01:15
*** thorst has quit IRC01:19
*** shaohe_feng has joined #openstack-nova01:20
*** hoangcx has quit IRC01:23
*** kevinz has joined #openstack-nova01:24
*** shaohe_feng has quit IRC01:25
*** shaohe_feng has joined #openstack-nova01:27
*** Apoorva has quit IRC01:29
*** suresh12 has quit IRC01:30
*** suresh12 has joined #openstack-nova01:30
*** hoangcx has joined #openstack-nova01:31
*** baoli has joined #openstack-nova01:32
*** suresh12 has quit IRC01:34
*** raunak has quit IRC01:35
*** shaohe_feng has quit IRC01:35
*** annp has joined #openstack-nova01:36
*** markvoelker has quit IRC01:36
*** shaohe_feng has joined #openstack-nova01:36
*** sdake has joined #openstack-nova01:36
*** code-R has joined #openstack-nova01:36
openstackgerritDao Cong Tien proposed openstack/nova: Ironic Driver: override get_serial_console()  https://review.openstack.org/32815701:36
*** sdague has quit IRC01:38
*** sdake_ has joined #openstack-nova01:39
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/35952101:39
*** sdake has quit IRC01:42
*** unicell has quit IRC01:43
*** shaohe_feng has quit IRC01:45
*** stewie925 has quit IRC01:45
*** shaohe_feng has joined #openstack-nova01:46
*** wangqun has joined #openstack-nova01:47
*** code-R_ has joined #openstack-nova01:52
*** ducttape_ has joined #openstack-nova01:52
*** sdake_ has quit IRC01:54
*** code-R has quit IRC01:55
*** shaohe_feng has quit IRC01:56
*** ducttape_ has quit IRC01:57
*** mtanino has joined #openstack-nova01:58
*** shaohe_feng has joined #openstack-nova01:59
*** thorst has joined #openstack-nova01:59
openstackgerritZhenyu Zheng proposed openstack/nova: [WIP] Should not be able to sort instances based on joined tables  https://review.openstack.org/35913401:59
*** thorst has quit IRC01:59
*** thorst has joined #openstack-nova02:00
*** yamahata has quit IRC02:03
*** sdake has joined #openstack-nova02:04
*** gouthamr_ is now known as gouthamr02:05
*** shaohe_feng has quit IRC02:06
*** thorst has quit IRC02:08
*** shaohe_feng has joined #openstack-nova02:09
*** suresh12 has joined #openstack-nova02:10
*** bigdogstl has joined #openstack-nova02:12
*** suresh12 has quit IRC02:15
*** ducttape_ has joined #openstack-nova02:15
*** shaohe_feng has quit IRC02:16
*** shaohe_feng has joined #openstack-nova02:18
*** raunak has joined #openstack-nova02:20
*** jcook has quit IRC02:22
*** walharth has joined #openstack-nova02:22
*** jcook has joined #openstack-nova02:22
openstackgerritCao ShuFeng proposed openstack/nova-specs: Make API errors conform to API-WG schema  https://review.openstack.org/30767502:24
*** thorst has joined #openstack-nova02:25
*** shaohe_feng has quit IRC02:26
*** thorst has quit IRC02:28
*** shaohe_feng has joined #openstack-nova02:28
*** serverascode has quit IRC02:28
*** code-R_ has quit IRC02:29
*** code-R has joined #openstack-nova02:30
*** mtanino has quit IRC02:31
*** serverascode has joined #openstack-nova02:31
*** sdake has quit IRC02:34
*** sdake has joined #openstack-nova02:35
*** shaohe_feng has quit IRC02:37
*** shaohe_feng has joined #openstack-nova02:37
*** Yingxin_ has joined #openstack-nova02:38
*** bswartz has quit IRC02:38
*** rama_y has joined #openstack-nova02:39
openstackgerritZhenyu Zheng proposed openstack/nova: The server_group_members quota cannot work when bulk boot instances  https://review.openstack.org/36018702:40
*** Yingxin has quit IRC02:41
*** Yingxin_ is now known as Yingxin02:41
*** sdake has quit IRC02:45
*** ducttape_ has quit IRC02:46
*** sdake has joined #openstack-nova02:47
*** shaohe_feng has quit IRC02:47
*** dimtruck is now known as zz_dimtruck02:48
*** shaohe_feng has joined #openstack-nova02:49
*** raunak has quit IRC02:51
*** ducttape_ has joined #openstack-nova02:53
*** shaohe_feng has quit IRC02:57
*** shaohe_feng has joined #openstack-nova02:58
*** zhangjl has joined #openstack-nova03:00
*** code-R has quit IRC03:06
*** hoangcx has quit IRC03:07
*** shaohe_feng has quit IRC03:07
*** shaohe_feng has joined #openstack-nova03:09
*** raunak has joined #openstack-nova03:09
*** jamielennox is now known as jamielennox|away03:09
*** woodster_ has quit IRC03:09
*** sdake has quit IRC03:12
*** tonytan4ever has quit IRC03:13
openstackgerritCao Xuan Hoang proposed openstack/nova: TrivialFix: Remove cfg import unused  https://review.openstack.org/36020003:14
*** hoangcx has joined #openstack-nova03:15
*** gcb_ has joined #openstack-nova03:16
*** ducttape_ has quit IRC03:16
*** ljxiash has joined #openstack-nova03:17
*** salv-orlando has joined #openstack-nova03:17
*** shaohe_feng has quit IRC03:18
*** salv-orl_ has quit IRC03:20
*** shaohe_feng has joined #openstack-nova03:20
*** ducttape_ has joined #openstack-nova03:22
*** jamielennox|away is now known as jamielennox03:23
*** READ10 has quit IRC03:23
*** vishwanathj has joined #openstack-nova03:25
*** ducttape_ has quit IRC03:26
*** pwnall has quit IRC03:26
*** bigdogstl has quit IRC03:27
*** shaohe_feng has quit IRC03:28
*** xcGlQHdZGT has quit IRC03:28
*** thorst has joined #openstack-nova03:29
*** shaohe_feng has joined #openstack-nova03:29
*** vishwanathj is now known as vishwanathj_zzz03:31
*** bigdogstl has joined #openstack-nova03:31
*** ljxiash has quit IRC03:32
*** suresh12 has joined #openstack-nova03:33
*** rmcall has quit IRC03:33
*** rmcall has joined #openstack-nova03:33
*** bigdogstl has quit IRC03:35
*** ManishD has joined #openstack-nova03:36
*** thorst has quit IRC03:37
*** shaohe_feng has quit IRC03:38
*** gcb_ has quit IRC03:39
ManishDhello Guys, please can you review my patch: https://review.openstack.org/#/c/357131/03:39
*** shaohe_feng has joined #openstack-nova03:40
*** bigdogstl has joined #openstack-nova03:40
*** EinstCrazy has joined #openstack-nova03:41
*** raunak has quit IRC03:42
*** gongysh has joined #openstack-nova03:43
*** baoli has quit IRC03:44
*** raunak has joined #openstack-nova03:46
*** pwnall has joined #openstack-nova03:47
*** bigdogstl has quit IRC03:47
*** armax has quit IRC03:47
*** shaohe_feng has quit IRC03:48
*** bigdogstl has joined #openstack-nova03:49
*** coolsvap_ has joined #openstack-nova03:50
*** shaohe_feng has joined #openstack-nova03:50
*** ljxiash has joined #openstack-nova03:51
*** bigdogstl has quit IRC03:51
*** rama_y has quit IRC03:52
*** hoangcx has quit IRC03:53
*** bigdogstl has joined #openstack-nova03:54
*** ljxiash has quit IRC03:56
*** raunak has quit IRC03:57
*** prateek_ has quit IRC03:57
*** raunak has joined #openstack-nova03:58
*** shaohe_feng has quit IRC03:59
*** shaohe_feng has joined #openstack-nova04:00
*** hoangcx has joined #openstack-nova04:03
*** prateek has joined #openstack-nova04:03
*** dikonoor has joined #openstack-nova04:04
*** hqkLChMUKc has joined #openstack-nova04:05
*** jogo has quit IRC04:06
*** amotoki has joined #openstack-nova04:06
openstackgerritZhenyu Zheng proposed openstack/nova: Replace compute_req_id middlware by RequestId oslo middleware  https://review.openstack.org/35837504:07
*** mtanino has joined #openstack-nova04:08
*** shaohe_feng has quit IRC04:09
*** shaohe_feng has joined #openstack-nova04:10
*** raunak has quit IRC04:12
*** bswartz has joined #openstack-nova04:12
*** rmcall has quit IRC04:13
*** tonytan4ever has joined #openstack-nova04:13
*** tonytan4ever has quit IRC04:18
*** shaohe_feng has quit IRC04:19
*** shaohe_feng has joined #openstack-nova04:19
*** ducttape_ has joined #openstack-nova04:23
*** hoangcx has quit IRC04:24
*** EinstCrazy has quit IRC04:24
*** gongysh has quit IRC04:25
*** hoangcx has joined #openstack-nova04:26
*** ducttape_ has quit IRC04:28
*** raunak has joined #openstack-nova04:29
*** pwnall has quit IRC04:29
*** shaohe_feng has quit IRC04:29
*** shaohe_feng has joined #openstack-nova04:30
*** suresh12 has quit IRC04:30
*** bigdogstl has quit IRC04:30
*** hoangcx has quit IRC04:33
*** thorst has joined #openstack-nova04:35
*** walharth has quit IRC04:35
*** unicell has joined #openstack-nova04:37
*** hoangcx has joined #openstack-nova04:37
*** links has joined #openstack-nova04:37
*** gouthamr has quit IRC04:39
*** shaohe_feng has quit IRC04:40
*** shaohe_feng has joined #openstack-nova04:40
*** aswadr_ has joined #openstack-nova04:41
*** thorst has quit IRC04:42
*** unicell has quit IRC04:45
*** unicell1 has joined #openstack-nova04:45
*** shaohe_feng has quit IRC04:50
*** yamahata has joined #openstack-nova04:50
*** rama_y has joined #openstack-nova04:50
*** shaohe_feng has joined #openstack-nova04:50
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/35952104:52
*** ManishD has quit IRC04:52
*** ManishD has joined #openstack-nova04:52
*** mtanino has quit IRC04:53
*** raunak has quit IRC04:59
*** shaohe_feng has quit IRC05:00
*** raunak has joined #openstack-nova05:00
*** shaohe_feng has joined #openstack-nova05:01
*** ayoung has quit IRC05:03
openstackgerritOpenStack Proposal Bot proposed openstack/python-novaclient: Updated from global requirements  https://review.openstack.org/36023805:05
*** scottda has quit IRC05:06
*** ecelik has joined #openstack-nova05:07
*** EinstCrazy has joined #openstack-nova05:09
*** jaosorior has joined #openstack-nova05:10
*** praveen has joined #openstack-nova05:10
*** shaohe_feng has quit IRC05:10
*** shaohe_feng has joined #openstack-nova05:11
*** EinstCrazy has quit IRC05:11
*** ljxiash has joined #openstack-nova05:17
*** raunak has quit IRC05:17
*** Sukhdev has joined #openstack-nova05:20
*** shaohe_feng has quit IRC05:21
*** shaohe_feng has joined #openstack-nova05:21
*** baoli has joined #openstack-nova05:21
*** edand has joined #openstack-nova05:22
*** nkrinner_afk is now known as nkrinner05:22
*** lixiaoy1 has quit IRC05:23
*** ljxiash has quit IRC05:23
*** Prophidys has quit IRC05:23
*** ducttape_ has joined #openstack-nova05:25
*** harlowja_at_home has joined #openstack-nova05:25
*** ljxiash has joined #openstack-nova05:26
*** baoli has quit IRC05:27
*** lixiaoy1 has joined #openstack-nova05:27
*** Prophidys has joined #openstack-nova05:27
*** phuongnh has quit IRC05:27
openstackgerritGábor Antal proposed openstack/nova: Changed exception catching order  https://review.openstack.org/34945005:29
*** lpetrut has joined #openstack-nova05:29
*** ducttape_ has quit IRC05:29
*** shaohe_feng has quit IRC05:31
*** kaisers_ has joined #openstack-nova05:32
*** ratailor has joined #openstack-nova05:32
*** shaohe_feng has joined #openstack-nova05:33
*** sudipto has joined #openstack-nova05:33
*** thorst has joined #openstack-nova05:40
*** shaohe_feng has quit IRC05:41
*** shaohe_feng has joined #openstack-nova05:42
openstackgerritTina Kevin proposed openstack/nova-specs: Add allocation ratio to hypervisor-show  https://review.openstack.org/35034805:42
*** david-lyle has joined #openstack-nova05:43
*** harlowja_at_home has quit IRC05:45
*** praneshp_ has joined #openstack-nova05:46
*** praneshp has quit IRC05:47
*** praneshp_ is now known as praneshp05:47
*** thorst has quit IRC05:48
*** claudiub has joined #openstack-nova05:51
*** shaohe_feng has quit IRC05:51
*** pbandark has joined #openstack-nova05:52
*** shaohe_feng has joined #openstack-nova05:52
*** jogo has joined #openstack-nova05:52
*** jogo has quit IRC05:52
*** jogo has joined #openstack-nova05:52
*** ekuris has joined #openstack-nova05:58
*** Sukhdev has quit IRC05:59
*** tojuvone_ has joined #openstack-nova06:00
*** shaohe_feng has quit IRC06:02
*** roeyc has joined #openstack-nova06:02
*** shaohe_feng has joined #openstack-nova06:03
*** tojuvone has quit IRC06:04
*** david-lyle has quit IRC06:09
*** vishwanathj_zzz has quit IRC06:10
*** vishwanathj_zzz has joined #openstack-nova06:10
*** shaohe_feng has quit IRC06:12
*** shaohe_feng has joined #openstack-nova06:13
*** shaohe_feng has quit IRC06:22
*** baoli has joined #openstack-nova06:23
*** shaohe_feng has joined #openstack-nova06:23
ManishD@Alex Xu, please can you review my patch: https://review.openstack.org/#/c/357131/06:23
*** sridharg has joined #openstack-nova06:25
*** ducttape_ has joined #openstack-nova06:26
*** tojuvone_ is now known as tojuvone06:27
*** rama_y has quit IRC06:27
*** rama_y has joined #openstack-nova06:27
*** baoli has quit IRC06:28
*** rcernin has joined #openstack-nova06:28
*** ducttape_ has quit IRC06:30
*** VnrycepuxO has quit IRC06:31
*** suresh12 has joined #openstack-nova06:31
openstackgerritZhenyu Zheng proposed openstack/nova: [WIP] Should not be able to sort instances based on joined tables  https://review.openstack.org/35913406:31
*** lpetrut has quit IRC06:31
*** vishwanathj_zzz has quit IRC06:32
*** shaohe_feng has quit IRC06:32
*** vishwanathj_zzz has joined #openstack-nova06:32
*** lixiaoy1 has quit IRC06:33
*** claudiub has quit IRC06:33
*** shaohe_feng has joined #openstack-nova06:33
*** suresh12 has quit IRC06:35
*** nikhil has quit IRC06:36
*** lixiaoy1 has joined #openstack-nova06:38
*** roeyc has quit IRC06:38
*** nikhil has joined #openstack-nova06:38
*** hqkLChMUKc has quit IRC06:39
*** andreas_s has joined #openstack-nova06:40
*** shaohe_feng has quit IRC06:43
*** shaohe_feng has joined #openstack-nova06:44
*** praneshp has quit IRC06:44
*** keekz has quit IRC06:44
*** sneti has quit IRC06:44
*** thorst has joined #openstack-nova06:44
*** fragatina has quit IRC06:46
*** keekz has joined #openstack-nova06:46
*** lpetrut has joined #openstack-nova06:48
*** ihrachys has joined #openstack-nova06:50
*** salv-orlando has quit IRC06:51
*** thorst has quit IRC06:52
*** shaohe_feng has quit IRC06:53
*** ihrachys has quit IRC06:56
*** shaohe_feng has joined #openstack-nova06:57
*** hoangcx has quit IRC06:58
*** sameo has joined #openstack-nova07:02
*** hoangcx has joined #openstack-nova07:03
*** shaohe_feng has quit IRC07:03
*** shaohe_feng has joined #openstack-nova07:04
*** zenoway has joined #openstack-nova07:08
*** tesseract- has joined #openstack-nova07:08
*** omnipresent has joined #openstack-nova07:09
*** sameo has quit IRC07:12
*** zenoway has quit IRC07:12
*** shaohe_feng has quit IRC07:13
*** shaohe_feng has joined #openstack-nova07:14
*** tonytan4ever has joined #openstack-nova07:15
openstackgerritzhangyanxian proposed openstack/python-novaclient: Some minior code optimization in post_test_hook  https://review.openstack.org/36029207:16
*** vishwanathj_zzz has quit IRC07:19
*** lpetrut has quit IRC07:19
*** vishwanathj_zzz has joined #openstack-nova07:20
*** tonytan4ever has quit IRC07:20
openstackgerritZhenyu Zheng proposed openstack/nova: Replace compute_req_id middlware by RequestId oslo middleware  https://review.openstack.org/35837507:21
*** baoli has joined #openstack-nova07:23
*** shaohe_feng has quit IRC07:24
*** shaohe_feng has joined #openstack-nova07:25
*** ducttape_ has joined #openstack-nova07:26
*** baoli has quit IRC07:28
*** hoangcx has quit IRC07:29
*** hoangcx has joined #openstack-nova07:29
*** ducttape_ has quit IRC07:31
*** shaohe_feng has quit IRC07:34
*** shaohe_feng has joined #openstack-nova07:35
*** rama_y has quit IRC07:35
*** sheel has joined #openstack-nova07:37
openstackgerritChangBo Guo(gcb) proposed openstack/nova: Log warning when user set improper config option value  https://review.openstack.org/35453207:38
*** sneti has joined #openstack-nova07:38
*** omnipresent has quit IRC07:39
*** zenoway has joined #openstack-nova07:39
*** aunnam has quit IRC07:40
*** zenoway has quit IRC07:40
*** zenoway has joined #openstack-nova07:40
*** yarkot1 has quit IRC07:40
*** shaohe_feng has quit IRC07:44
*** shaohe_feng has joined #openstack-nova07:45
*** ratailor is now known as ratailor|Lunch07:47
*** kevinz has quit IRC07:49
*** markus_z has joined #openstack-nova07:49
*** kevinz has joined #openstack-nova07:49
*** thorst has joined #openstack-nova07:50
*** takashin has joined #openstack-nova07:52
*** shaohe_feng has quit IRC07:54
*** shaohe_feng has joined #openstack-nova07:55
*** moshele has joined #openstack-nova07:55
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata  https://review.openstack.org/35963507:57
*** thorst has quit IRC07:58
*** salv-orl_ has joined #openstack-nova07:59
*** salv-orl_ has quit IRC07:59
*** zzzeek has quit IRC08:00
*** salv-orl_ has joined #openstack-nova08:00
*** zzzeek has joined #openstack-nova08:00
*** Oku_OS-away is now known as Oku_OS08:02
*** mnestratov has joined #openstack-nova08:03
*** roeyc has joined #openstack-nova08:04
*** shaohe_feng has quit IRC08:05
*** shaohe_feng has joined #openstack-nova08:05
*** yassine has joined #openstack-nova08:10
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c  https://review.openstack.org/30334508:10
*** vishwanathj_zzz has quit IRC08:10
*** yassine is now known as Guest4531808:10
*** vishwanathj_zzz has joined #openstack-nova08:10
openstackgerritNam Nguyen Hoai proposed openstack/nova: Use cls in class method instead of self _delete_domain is a class method, so cls should be used instead of self.  https://review.openstack.org/36031808:13
*** cdent has joined #openstack-nova08:13
*** shaohe_feng has quit IRC08:15
*** takashin has left #openstack-nova08:17
*** shaohe_feng has joined #openstack-nova08:18
openstackgerritxhzhf proposed openstack/nova: Support-matrix of ironic for vlan should be updated  https://review.openstack.org/35515208:20
*** dikonoor has quit IRC08:21
*** dikonoor has joined #openstack-nova08:21
johnthetubaguyalaski: eek, thats hard than you would hope, but I think thats good now08:21
*** claudiub has joined #openstack-nova08:25
*** shaohe_feng has quit IRC08:25
markus_ztdurakov: Hey, I think I need help with the live-migration test for serial console. :(08:27
*** ducttape_ has joined #openstack-nova08:27
markus_ztdurakov: I also think I don't get it how "depends-on" works.08:27
johnthetubaguymarkus_z: depends-on only works for things we clone from git in the gate08:28
*** lucas-dinner is now known as lucasagomes08:28
tdurakovmarkus_z: hi, will take a look today08:28
markus_zjohnthetubaguy: So it doesn't pull the change I have for another project and that dependencies?08:28
openstackgerritZhenyu Zheng proposed openstack/nova: The server_group_members quota cannot work when bulk boot instances  https://review.openstack.org/36018708:28
markus_ztdurakov: thanks a lot in advance08:29
johnthetubaguymarkus_z: it depends on if its cloned by devstack already, I believe, whats your example?08:29
markus_zjohnthetubaguy: I have this tempest change https://review.openstack.org/#/c/346815/08:29
johnthetubaguymarkus_z: so thats the case that should work, AFAIK08:30
markus_zTo make this tempest test working it needs 2 fixes in nova starting with https://review.openstack.org/#/c/275801/08:30
markus_zThe logs make me think that only the very first change gets pulled, but not the one it depends on08:31
*** shaohe_feng has joined #openstack-nova08:31
markus_zhttp://logs.openstack.org/71/347471/26/check/gate-tempest-dsvm-multinode-live-migration/2859ad4/logs/subnode-2/screen-n-cpu.txt.gz?level=TRACE#_2016-08-23_13_58_17_54408:31
markus_z^ is fixed by https://review.openstack.org/#/c/335132/608:31
johnthetubaguymarkus_z: oh... that sounds a little crazy, but I guess it probably does a cherry pick or something08:31
johnthetubaguymarkus_z: did you try depends on for both matches?08:31
*** ducttape_ has quit IRC08:32
markus_zjohnthetubaguy: No, not yet. Until this morning I was *sure" I understood how "depends-on" works :)08:32
markus_zjohnthetubaguy: I'll add a second "depends-on" on that tempest test in the next minutes.08:33
johnthetubaguyyeah, me too, that one is news to me08:33
markus_zjohnthetubaguy: Thanks for the help, I'll let you know about the result.08:33
*** andymaier has joined #openstack-nova08:34
*** shaohe_feng has quit IRC08:35
*** shaohe_feng has joined #openstack-nova08:36
*** jichen has joined #openstack-nova08:38
*** gstepanov__ has joined #openstack-nova08:43
*** aarefiev_ has joined #openstack-nova08:43
*** andreykurilin has joined #openstack-nova08:44
*** shaohe_feng has quit IRC08:46
*** andreykurilin1 has quit IRC08:46
*** zul has joined #openstack-nova08:46
*** gstepanov_ has quit IRC08:46
*** shaohe_feng has joined #openstack-nova08:46
*** aarefiev has quit IRC08:47
*** openstackgerrit has quit IRC08:48
*** openstackgerrit has joined #openstack-nova08:48
*** aarefiev_ is now known as aarefiev08:50
*** ihrachys has joined #openstack-nova08:52
*** shaohe_feng has quit IRC08:56
*** thorst has joined #openstack-nova08:56
*** andreas_s has quit IRC08:57
*** shaohe_feng has joined #openstack-nova08:57
*** andreas_s has joined #openstack-nova08:57
openstackgerritChris Dent proposed openstack/nova: WIP Add support for allocations in placement API  https://review.openstack.org/33987408:58
openstackgerritDao Cong Tien proposed openstack/nova: Ironic Driver: override get_serial_console()  https://review.openstack.org/32815708:59
*** derekh has joined #openstack-nova09:00
*** ljxiash has quit IRC09:01
*** newcomer25 has joined #openstack-nova09:01
*** thorst has quit IRC09:03
*** ljxiash has joined #openstack-nova09:05
*** shaohe_feng has quit IRC09:06
*** lixiaoy1 has quit IRC09:08
*** shaohe_feng has joined #openstack-nova09:08
*** omnipresent has joined #openstack-nova09:08
*** Yingxin has quit IRC09:09
*** lixiaoy1 has joined #openstack-nova09:09
*** kylek3h has quit IRC09:10
*** newcomer25 has left #openstack-nova09:10
*** zenoway has quit IRC09:10
*** Yingxin has joined #openstack-nova09:12
*** tonytan4ever has joined #openstack-nova09:16
openstackgerritChris Dent proposed openstack/nova: Add {get_,set_}aggregates to objects.ResourceProvider  https://review.openstack.org/35526309:16
openstackgerritChris Dent proposed openstack/nova: Implement get and set aggregates in the placement API  https://review.openstack.org/35799309:16
*** shaohe_feng has quit IRC09:16
*** salv-orlando has joined #openstack-nova09:18
*** sayalilunkad has quit IRC09:18
*** lixiaoy1 has quit IRC09:18
*** shaohe_feng has joined #openstack-nova09:19
*** sayalilunkad has joined #openstack-nova09:20
*** salv-orl_ has quit IRC09:20
*** ababich has joined #openstack-nova09:20
*** tonytan4ever has quit IRC09:20
*** kaisers_ has quit IRC09:23
*** takashin has joined #openstack-nova09:25
*** Yingxin has quit IRC09:26
*** kylek3h has joined #openstack-nova09:26
*** shaohe_feng has quit IRC09:27
*** shaohe_feng has joined #openstack-nova09:27
*** ducttape_ has joined #openstack-nova09:28
*** ratailor|Lunch is now known as ratailor09:28
*** Yingxin has joined #openstack-nova09:30
*** suresh12 has joined #openstack-nova09:31
*** ducttape_ has quit IRC09:33
*** zul has quit IRC09:33
*** omnipresent has quit IRC09:34
*** annp has quit IRC09:36
*** suresh12 has quit IRC09:36
*** shaohe_feng has quit IRC09:37
*** ljxiash has quit IRC09:37
*** kaisers_ has joined #openstack-nova09:37
*** zul has joined #openstack-nova09:38
*** ljxiash has joined #openstack-nova09:39
*** shaohe_feng has joined #openstack-nova09:40
*** baoli has joined #openstack-nova09:40
*** pbandark has quit IRC09:41
*** ljxiash has quit IRC09:41
*** fragatina has joined #openstack-nova09:43
*** baoli has quit IRC09:44
*** claudiub|2 has joined #openstack-nova09:45
*** fragatina has quit IRC09:47
*** claudiub has quit IRC09:47
*** shaohe_feng has quit IRC09:47
*** mkoderer__ has joined #openstack-nova09:48
*** pbandark has joined #openstack-nova09:48
*** shaohe_feng has joined #openstack-nova09:48
*** vishwanathj_zzz has quit IRC09:52
*** vishwanathj_zzz has joined #openstack-nova09:53
ManishDhello Guys, please can you review my patch: https://review.openstack.org/#/c/357131/09:56
*** shaohe_feng has quit IRC09:57
*** shaohe_feng has joined #openstack-nova09:58
*** cdent has quit IRC09:59
*** claudiub|2 has quit IRC10:00
*** thorst has joined #openstack-nova10:00
*** ljxiash has joined #openstack-nova10:02
openstackgerritAtsushi SAKAI proposed openstack/python-novaclient: Replace Request-ID string in Error Message  https://review.openstack.org/36039310:03
*** hoangcx has quit IRC10:04
*** wangqun has quit IRC10:05
*** thorst has quit IRC10:07
*** shaohe_feng has quit IRC10:08
*** shaohe_feng has joined #openstack-nova10:08
*** roeyc has quit IRC10:09
openstackgerritAlex Szarka proposed openstack/nova: [WIP]Reduce code complexity - manager.py  https://review.openstack.org/35986810:16
*** lpetrut has joined #openstack-nova10:17
*** shaohe_feng has quit IRC10:18
*** shaohe_feng has joined #openstack-nova10:19
*** lucasagomes is now known as lucas-relocate10:25
*** cdent has joined #openstack-nova10:26
*** shaohe_feng has quit IRC10:28
*** ducttape_ has joined #openstack-nova10:29
*** shaohe_feng has joined #openstack-nova10:29
*** zhangjl has quit IRC10:30
*** ducttape_ has quit IRC10:34
*** jed56 has quit IRC10:35
*** gszasz has joined #openstack-nova10:37
*** shaohe_feng has quit IRC10:38
*** shaohe_feng has joined #openstack-nova10:40
*** abalutoiu has joined #openstack-nova10:42
*** zenoway has joined #openstack-nova10:45
*** shaohe_feng has quit IRC10:49
*** shaohe_feng has joined #openstack-nova10:50
*** sdague has joined #openstack-nova10:51
*** sudipto has quit IRC10:51
*** roeyc has joined #openstack-nova10:51
*** vishwanathj_zzz has quit IRC10:55
*** vishwanathj_zzz has joined #openstack-nova10:56
cdentjohnthetubaguy: I've had some additional concerns/comments from alaski on the set_aggregates stuff in https://review.openstack.org/#/c/355263/ With Jay away (he's somewhere in the UK) who else should we ping for some opinions?10:57
*** shaohe_feng has quit IRC10:59
*** shaohe_feng has joined #openstack-nova11:01
*** thorst has joined #openstack-nova11:05
*** shaohe_feng has quit IRC11:09
*** sdague has quit IRC11:10
*** tbachman has quit IRC11:11
*** shaohe_feng has joined #openstack-nova11:11
openstackgerritAlex Szarka proposed openstack/nova: Reduce code complexity - instance.py  https://review.openstack.org/35987811:12
*** thorst has quit IRC11:12
*** ekuris has quit IRC11:13
*** lucas-relocate is now known as lucas-hungry11:13
*** tonytan4ever has joined #openstack-nova11:17
*** shaohe_feng has quit IRC11:19
*** shaohe_feng has joined #openstack-nova11:20
*** rodrigods has quit IRC11:21
*** rodrigods has joined #openstack-nova11:21
*** kolesovdv has joined #openstack-nova11:21
*** tonytan4ever has quit IRC11:22
*** ljxiash has quit IRC11:23
*** bvanhav has joined #openstack-nova11:23
*** karthiks_afk is now known as karthiks11:23
*** sdague has joined #openstack-nova11:24
*** rtheis has joined #openstack-nova11:25
*** devkulkarni has joined #openstack-nova11:25
*** sheel has quit IRC11:26
*** devkulkarni1 has joined #openstack-nova11:27
*** ekuris has joined #openstack-nova11:28
*** devkulkarni has quit IRC11:29
*** devkulkarni1 has quit IRC11:29
*** shaohe_feng has quit IRC11:30
*** shaohe_feng has joined #openstack-nova11:30
*** sdague has quit IRC11:31
*** devkulkarni has joined #openstack-nova11:31
*** tbachman has joined #openstack-nova11:36
*** ManishD has quit IRC11:36
*** shaohe_feng has quit IRC11:40
*** shaohe_feng has joined #openstack-nova11:41
openstackgerritZhenyu Zheng proposed openstack/nova: The server_group_members quota cannot work when bulk boot instances  https://review.openstack.org/36018711:42
*** foexle has joined #openstack-nova11:43
*** zenoway has quit IRC11:43
*** thorst has joined #openstack-nova11:44
*** zenoway has joined #openstack-nova11:45
fricklermarkus_z: (or other bug watchers) could you please raise the importance of https://bugs.launchpad.net/nova/+bug/1608934 ? the patch at https://review.openstack.org/355415 looks ready to be merged and I would like to make sure that we still have enough time to backport it to Mitaka11:46
openstackLaunchpad bug 1608934 in OpenStack Compute (nova) "ephemeral disk creation fails for local storage with image type raw/lvm" [Undecided,In progress] - Assigned to Dr. Jens Rosenboom (j-rosenboom-j)11:46
*** rfolco has joined #openstack-nova11:47
*** ljxiash has joined #openstack-nova11:47
*** dansmith has quit IRC11:49
*** dansmith has joined #openstack-nova11:49
*** devkulkarni has quit IRC11:49
*** rfolco_ has joined #openstack-nova11:50
*** shaohe_feng has quit IRC11:50
*** rfolco has quit IRC11:51
*** jaosorior has quit IRC11:52
*** jaosorior has joined #openstack-nova11:52
*** shaohe_feng has joined #openstack-nova11:52
*** praveen has quit IRC11:53
openstackgerritAlex Szarka proposed openstack/nova: Reduce code complexity - libvirt/config.py  https://review.openstack.org/35987911:53
*** shaohe_feng has quit IRC12:00
*** shaohe_feng has joined #openstack-nova12:02
*** ekuris has quit IRC12:03
*** pradk has joined #openstack-nova12:09
*** tonytan4ever has joined #openstack-nova12:10
*** shaohe_feng has quit IRC12:11
*** ducttape_ has joined #openstack-nova12:11
*** gouthamr has joined #openstack-nova12:11
*** su_zhang has joined #openstack-nova12:14
*** zul has quit IRC12:15
*** lucas-hungry is now known as lucasagomes12:15
*** salv-orlando has quit IRC12:15
*** tonytan_brb has joined #openstack-nova12:17
*** ljxiash has quit IRC12:17
*** takashin has quit IRC12:17
*** vishwanathj_zzz has quit IRC12:18
*** csatari has quit IRC12:18
*** jcook has quit IRC12:18
*** baoli has joined #openstack-nova12:18
*** vishwanathj_zzz has joined #openstack-nova12:18
*** tonytan4ever has quit IRC12:19
*** baoli has quit IRC12:19
*** takashin has joined #openstack-nova12:19
tdurakovfrickler: I suspect this is duplicate for https://bugs.launchpad.net/nova/+bug/161451912:19
openstackLaunchpad bug 1614519 in OpenStack Compute (nova) "Error on booting instance with ephemeral while using Flat/Raw images" [High,In progress] - Assigned to Tomonobu Niwa (to-niwa)12:19
*** wendar_ has joined #openstack-nova12:19
*** rpodolyaka has quit IRC12:19
*** sc68cal has quit IRC12:20
*** wendar has quit IRC12:20
*** shaohe_feng has joined #openstack-nova12:20
*** Prophidys has quit IRC12:20
*** mfisch has quit IRC12:21
*** sc68cal has joined #openstack-nova12:21
*** shaohe_feng has quit IRC12:21
*** csatari has joined #openstack-nova12:21
openstackgerritAlex Szarka proposed openstack/nova: Reduce code complexity - instance.py  https://review.openstack.org/35987812:21
*** aunnam has joined #openstack-nova12:21
*** bradjones has quit IRC12:21
*** Cassowary_ has joined #openstack-nova12:22
*** Prophidys has joined #openstack-nova12:22
*** McNinja has quit IRC12:22
*** shaohe_feng has joined #openstack-nova12:23
tdurakovfrickler: I set priority to High, could you please update bug description, it's not about lvm only, and mostly depends on raw/flat, as they don't use backing files12:23
*** Cassowary has quit IRC12:23
*** Cassowary_ is now known as Cassowary12:23
*** briancurtin has quit IRC12:23
*** Kevin_Zheng has quit IRC12:23
*** McNinja has joined #openstack-nova12:24
*** rpodolyaka has joined #openstack-nova12:24
*** baoli has joined #openstack-nova12:24
*** baoli has quit IRC12:24
*** ekuris has joined #openstack-nova12:25
*** Kevin_Zheng has joined #openstack-nova12:25
*** mfisch has joined #openstack-nova12:25
*** mfisch has quit IRC12:25
*** mfisch has joined #openstack-nova12:25
*** jaosorior is now known as jaosorior_away12:25
*** briancurtin has joined #openstack-nova12:25
*** jcook has joined #openstack-nova12:26
*** bradjones has joined #openstack-nova12:27
*** bradjones has quit IRC12:27
*** bradjones has joined #openstack-nova12:27
*** mtreinish has quit IRC12:27
*** takashin_ has joined #openstack-nova12:27
tdurakovfrickler: I also wonder, what kind of cache we are trying to do here? need to spend more time on your fix12:27
*** ducttape_ has quit IRC12:28
*** takashin has quit IRC12:29
*** mtreinish has joined #openstack-nova12:30
*** shaohe_feng has quit IRC12:31
*** shaohe_feng has joined #openstack-nova12:33
*** edmondsw has joined #openstack-nova12:34
fricklertdurakov: when creating a root volume from an image, nova tries to cache the base image first and clone the root volume off of this cache12:35
*** JoseMello has joined #openstack-nova12:35
fricklertdurakov: the same code is used when creating ephemeral volumes, but fails in certain situations12:35
tdurakovfrickler: right, I mean what kind of cache could be for raw disks?12:36
*** scottda has joined #openstack-nova12:36
tdurakovfrickler: I expect this to be valid for cow images, for example12:36
tdurakovbut what we are caching for raw?12:37
fricklertdurakov: if you boot two instances off the same image, nova will only have to fetch it once and copy it locally twice12:37
tdurakovright, bbut this is not valid for additional ephemeral, makes less sense12:37
*** sbezverk_ has joined #openstack-nova12:37
fricklertdurakov: yes, it doesn't, but it may still make sense to use the same code if most of it is similar, instead of duplicating pretty much of it12:38
fricklertdurakov: but you are right that the naming is confusing, I think there is a patch up to change that12:39
*** sbezverk has quit IRC12:39
tdurakovfrickler: well, it's not so straightforward for imagebackend:)12:39
*** mdrabe has joined #openstack-nova12:39
tdurakovfrickler: mdbooth is working on refactoring for this area, but I'm ok to merge fix, so it could be backported for stable/branches either, which is almost impossible for bp, being implemented12:40
fricklertdurakov: yes, we found this in Mitaka originally and would like to see it fixed there12:41
*** shaohe_feng has quit IRC12:41
tdurakov++12:41
*** cdelatte has joined #openstack-nova12:42
*** ljxiash has joined #openstack-nova12:43
*** shaohe_feng has joined #openstack-nova12:43
*** derekh has quit IRC12:44
*** ababich has quit IRC12:44
sbezverk_johnthetubaguy: Since neither danpb nor jaypipes show up in the channel, is there an alternative contact for https://bugs.launchpad.net/nova/+bug/1616240. This issue is kind of a show stopper for our project.12:44
openstackLaunchpad bug 1616240 in OpenStack Compute (nova) "Traceback in vif.py execv() arg 2 must contain only strings" [High,New]12:44
johnthetubaguycdent: sorry, had to run away earlier, just taking a peak at that now12:44
*** sudipto has joined #openstack-nova12:44
johnthetubaguysbezverk_: the thing blocking me is I don't have a setup, and we need a bit more debug info from that os-vif failure, ideally at least12:45
fricklertdurakov: http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/imagebackend.py?h=14.0.0.0b2#n495 is the code path that skips generating the base image and directly creates the target for volumes that are not created from an image (e.g. ephemeral volumes)12:45
*** xyang1 has joined #openstack-nova12:45
johnthetubaguysbezverk_: one thing did come to me, check you are using the lastest version of os-vif12:45
*** cdelatte has quit IRC12:46
sbezverk_johnthetubaguy: I have setup ready, can add any extra debugs you need and get you output.12:46
tdurakovfrickler: debuging this part right now:)12:46
sbezverk_johnthetubaguy: I cloned master last night12:46
*** derekh has joined #openstack-nova12:47
*** ljxiash has quit IRC12:47
johnthetubaguysbezverk_: ah, so let me find the bit of code I think we need to add the logging in, one sec12:48
*** markvoelker has joined #openstack-nova12:48
cdentthanks johnthetubaguy, stepping away for a little while, will check back here and on the review later in the day12:49
*** cleong has joined #openstack-nova12:49
johnthetubaguysbezverk_: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L78312:49
*** kevinz has quit IRC12:49
sbezverk_johnthetubaguy: os-vif (1.1.0)12:50
johnthetubaguysbezverk_: basically, would be good to get the stacktrace logged in there, I would add a log.exception(msg) or something like that before line 78312:50
johnthetubaguysbezverk_: my bad LOG.exception(msg)12:50
*** sridharg has quit IRC12:51
sbezverk_johnthetubaguy: will do right away and let you know the result12:51
johnthetubaguysbezverk_: thanks, I am hoping that points to the line of code that is failing12:51
*** shaohe_feng has quit IRC12:52
*** code-R has joined #openstack-nova12:52
*** shaohe_feng has joined #openstack-nova12:52
johnthetubaguycdent: oh, I think get his point, its a good one, we should add the API to add aggregates first12:53
*** eharney has quit IRC12:53
*** mgagne_ is now known as mgagne12:54
cdentjohnthetubaguy: that ends up getting rather confusing though doesn't it? We've got these aggregates over "here" and these other aggregates over "here". The whole thing is mindbending and I'm not sure what the actual desired behavior is.12:55
*** sridharg has joined #openstack-nova12:57
*** woodster_ has joined #openstack-nova12:57
alaskiwho needs aggregate info besides the scheduler? my thinking was that aggregates would be in one location, the placement db12:57
alaskior where ever things are being tracked api/placement db12:58
*** salv-orlando has joined #openstack-nova12:58
*** ababich has joined #openstack-nova12:59
*** sridharg has quit IRC12:59
cdentmy understanding was that we were trying to avoid migrating the existing aggregates and that this new table (in the placment db) was some kind of stub13:00
*** vishwanathj_zzz is now known as vishwanathj13:00
*** rlrossit has joined #openstack-nova13:00
*** sridharg has joined #openstack-nova13:00
cdentif we do the side-check that johnthetubaguy suggests in his comments, are there any issues with managing two context managers at once, or, should the check of the nova db happen first in context a, and then switch to context b (in which case we've got a race, but not a big deal one)13:02
*** shaohe_feng has quit IRC13:02
*** shaohe_feng has joined #openstack-nova13:02
alaskiokay. if that's the direction then I see two options: have a process for syncing aggregate info between api/placement db, or create aggregate stubs in the placement db on demand and then find a good way to fail later if we schedule to an aggregate that doesn't actually exist13:02
*** yarkot1 has joined #openstack-nova13:03
cdentchoosing "the direction" is, I think, up to us. So, at this stage I don't know if that's the one, it's just an option. I personally think the auto-create isn't such a bad thing, but I'm _very_ aware that I don't know all the issues.13:04
*** foexle has quit IRC13:04
*** rtheis_ has joined #openstack-nova13:04
alaskicdent: I'm not sure two context managers have been attempted before, so *shrug*. I would say that's fine for the short term if the direction we're headed is having complete aggregate info in the placement db. if we're just going to have unverified stubs then we should just focus on dealing with failure13:05
cdentsince the aggregate info isn't actually going to be used any time soon, we can kick the problem into the future?13:05
*** ratailor has quit IRC13:05
*** Yingxin has quit IRC13:06
alaskiI don't see why not13:06
*** rtheis has quit IRC13:06
*** baoli has joined #openstack-nova13:07
cdentdoes that mean that's what's there is okay?13:07
*** takashin has joined #openstack-nova13:07
cdent(with some caveats and todos in the code)13:07
*** baoli_ has joined #openstack-nova13:07
alaskiwell, I would push it into the future by not adding aggregates yet. just my opinion13:08
*** pwnall has joined #openstack-nova13:08
*** ekuris has quit IRC13:08
*** takashin_ has quit IRC13:08
*** rtheis_ is now known as rtheis13:09
cdentalaski: you mean just not bother with any of this code yet?13:10
cdentwhat will that mean in terms of limiting our next steps?13:10
*** Yingxin has joined #openstack-nova13:11
alaskiyes, and I don't know. Is this the only front this effort is moving on now?13:11
*** baoli has quit IRC13:11
*** prateek has quit IRC13:11
*** Yingxin has quit IRC13:12
*** shaohe_feng has quit IRC13:12
*** su_zhang has quit IRC13:12
*** foexle has joined #openstack-nova13:12
cdenttwo main fronts: the api as described by the spec (aggregates and allocations left), and resource tracker changes: things in this stack: https://review.openstack.org/#/c/358797/13:13
*** tuanla_ has quit IRC13:13
alaskiif this is the direction that jaypipes/dansmith are comfortable with I'm not going to try to slow it down. but I feel like we could have a better idea of where we're headed to make some decisions13:13
*** Yingxin has joined #openstack-nova13:13
*** shaohe_feng has joined #openstack-nova13:14
cdentdansmith: you in the world today?13:15
*** vishwanathj has quit IRC13:15
cdentIf he's not I'll try to ping him later today and I'll also try to raise jaypipes via other media13:15
alaskito be clear, my primary concern is going down the path of auto creating aggs now and then later deciding to be strict. let's pick a strict/loose path first13:15
*** vishwanathj has joined #openstack-nova13:16
cdenti've linked to the logs of this to the review so there's some reference13:16
*** pwnall has quit IRC13:16
*** walharth has joined #openstack-nova13:20
johnthetubaguyalaski: I am +1 that concern (now you pointed it out), going back on the auto create is hard13:21
johnthetubaguyI kinda though we were moving all the aggregate info over there long term, so an aggregate can span multiple services, technically, at least13:22
*** ducttape_ has joined #openstack-nova13:22
*** links has quit IRC13:22
*** shaohe_feng has quit IRC13:22
johnthetubaguybut yeah, I don't want to slow this down for no reason either, just would feel better if I was confident around that end goal13:23
*** tblakes has joined #openstack-nova13:23
*** shaohe_feng has joined #openstack-nova13:24
alaskijust consensus on a loose/strict destination would be good, then small steps to get there.13:24
cdentloose is cheap. What are the potential problems with it? (for sake of discussion)13:25
openstackgerritLudovic Beliveau proposed openstack/nova: Fix drop_move_claim() on revert resize  https://review.openstack.org/34906013:27
*** claudiub|2 has joined #openstack-nova13:29
*** jichen has quit IRC13:31
*** zul has joined #openstack-nova13:31
*** jianghuaw has joined #openstack-nova13:31
*** mat128 is now known as mat128|away13:31
*** eharney has joined #openstack-nova13:31
*** suresh12 has joined #openstack-nova13:32
*** pwnall has joined #openstack-nova13:32
*** suresh12 has quit IRC13:32
*** suresh12 has joined #openstack-nova13:32
*** shaohe_feng has quit IRC13:33
*** ducttape_ has quit IRC13:33
sbezverk_johnthetubaguy: I think here is what you are looking for: http://paste.openstack.org/show/563380/13:33
*** shaohe_feng has joined #openstack-nova13:34
*** salv-orlando has quit IRC13:35
*** roeyc has quit IRC13:35
johnthetubaguysbezverk_: oh, that certainly helps I think13:39
sbezverk_johnthetubaguy: more complete log: http://paste.openstack.org/show/563382/13:39
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Fix wrong parameters in os-volumes.inc  https://review.openstack.org/34711213:40
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Fix 'id' (attachment_id) parameters  https://review.openstack.org/34986313:40
openstackgerritTakashi NATSUME proposed openstack/nova: Fix an error in archiving 'migrations' table  https://review.openstack.org/32368413:40
openstackgerritTakashi NATSUME proposed openstack/nova: Add a hacking rule for string interpolation at logging  https://review.openstack.org/33484413:40
openstackgerritTakashi NATSUME proposed openstack/nova: Fix unnecessary string interpolation  https://review.openstack.org/35757713:41
*** sdague has joined #openstack-nova13:41
*** shaohe_feng has quit IRC13:43
openstackgerritTakashi NATSUME proposed openstack/nova: Set 'serial' to new volume ID in swap volumes  https://review.openstack.org/25713513:43
*** tbachman has quit IRC13:44
*** shaohe_feng has joined #openstack-nova13:44
johnthetubaguysbezverk_: try replaying bridge with str(bridge) here: https://git.openstack.org/cgit/openstack/os-vif/tree/vif_plug_ovs/linux_net.py#n6413:44
alaskicdent: my concern would be being loose now and then dealing with how to clean up the data if we're strict later. maybe not a huge deal, I would just rather prevent bad data if we're going to be strict later13:45
*** mgoddard_ has joined #openstack-nova13:45
johnthetubaguysbezverk_: on ln64 and ln65 I guess13:46
*** eharney_ has joined #openstack-nova13:46
johnthetubaguysbezverk_: why its not a string is a different question, its possible something else bad is happening, I guess the gate must be testing linux bridge not ovs13:46
johnthetubaguysbezverk_: just checking, you are using ovs right? that seems to be what is happening at least13:47
sbezverk_johnthetubaguy: yes sir13:47
*** eharney has quit IRC13:47
*** takashin has left #openstack-nova13:47
*** jaosorior_away is now known as jaosorior13:48
cdentalaski: yeah, thus my question (to try to understand): if we do loose what would prompt us to change? it feels fairly resilient for them to be just cheap identifiers13:48
*** mgoddard has quit IRC13:48
*** code-R_ has joined #openstack-nova13:49
johnthetubaguycdent: at what point do we start storing all the metadata about the aggregates in the placement engine, maybe?13:49
alaskicdent: the main concern is typos. we have the same issue with tenant quotas as johnthetubaguy mentioned. someone adds an aggregate to a rp and then things don't work as expected due to a typo13:49
johnthetubaguyyeah, the usability sucks when its an unverified id13:49
*** tbachman has joined #openstack-nova13:50
*** code-R_ has quit IRC13:51
*** eharney_ is now known as eharney13:51
*** code-R has quit IRC13:51
*** melwitt_ has joined #openstack-nova13:51
cdentlong term do we even want the metadata? there was some discussion that what matters is the association, and nothing else. in which case, creating them at the time of associatation kinda makes sense.13:51
*** code-R_ has joined #openstack-nova13:52
cdentI don't really know.13:52
*** kaisers_ has quit IRC13:52
* cdent wants to page in the experts for relief, whoever they are13:52
*** takashin has joined #openstack-nova13:53
edleafecdent: not me, for sure, but I'm +1 on not relying on metadata13:53
*** shaohe_feng has quit IRC13:53
cdentedleafe: if you've got any opinions could you please add them to https://review.openstack.org/#/c/355263/413:54
cdentat some point we'll figure it out :)13:55
alaskicdent: yeah, the association is really all that matters. but do we verify that we're associating to a thing that actually exists? I think we should, without querying the api db for it, which means finding a way to add them to the placement db when they're created13:55
*** shaohe_feng has joined #openstack-nova13:55
edleafecdent: have it open already. Trying to digest the comments13:55
*** vishwanathj has quit IRC13:55
cdentedleafe++13:55
alaskiI'm totally fine with not verifying them though, as long as we have a good story for exposing scheduling events to non existent aggs13:55
dansmithnova meeting in 513:55
*** vishwanathj has joined #openstack-nova13:55
alaskidansmith: end of nova meeting in 7 minutes?13:56
cdentthe prodigal dansmith has arrived, we'll get him on this stuff, if we're lucky13:56
dansmithalaski: hah, yeah13:56
sbezverk_johnthetubaguy: vif_plug_ovs/linux_net.py I changed it delete .pyc but the same issue, it is either something else or by some reason it does not use changed file..13:57
*** ociuhandu has joined #openstack-nova13:57
qeeleeCould anyone help review https://review.openstack.org/#/c/358940/?13:58
*** su_zhang has joined #openstack-nova13:59
*** anush_ has joined #openstack-nova14:00
*** devananda|OSE is now known as devananda|OPS14:01
*** foexle has quit IRC14:03
*** ecelik has quit IRC14:03
*** hshiina has joined #openstack-nova14:03
*** shaohe_feng has quit IRC14:03
openstackgerritChris Dent proposed openstack/nova: In InventoryList.find() raise NotFound if invalid resource class  https://review.openstack.org/36057214:03
*** zul has quit IRC14:04
*** mgoddard_ has quit IRC14:04
*** tbachman has quit IRC14:04
*** mgoddard has joined #openstack-nova14:05
*** qeelee has quit IRC14:05
*** zul has joined #openstack-nova14:05
johnthetubaguysbezverk_: just checking, but did you restart the process, after calling setup.py again?14:06
*** markus_z has quit IRC14:07
*** jaosorior has quit IRC14:08
jianghuawhi johnthebubaguy: I think there is a bug for XenAPI at here: https://github.com/openstack/nova/blob/master//nova/image/glance.py#L65114:09
johnthetubaguyjianghuaw: heh, its adding qcow2, that seems wrong.14:10
*** shaohe_feng has joined #openstack-nova14:10
jianghuawyes, it hardcode disk_format as qcow2 which is not supported by xenapi.14:10
sbezverk_johnthetubaguy: no I just modified file and try to launch instance14:11
johnthetubaguysbezverk_: ah, it will need a restart at least14:11
jianghuawit will cause failure when create image from volume.14:11
jianghuawhttps://github.com/openstack/nova/blob/master/nova/compute/api.py#L247114:11
jianghuawat here it clean the original disk_format, so it definitely will running to qcow2.14:12
*** ducttape_ has joined #openstack-nova14:12
*** zz_dimtruck is now known as dimtruck14:12
johnthetubaguyjianghuaw: yeah, that sounds broken14:12
*** code-R has joined #openstack-nova14:12
jianghuawjohnthetubaguy: thinking how to fix it. could we add two new configure options in nova to specify a the disk_format and contain_format?14:13
*** shaohe_feng has quit IRC14:14
jianghuawor is there a better way to get value for this two parameters?14:14
*** shaohe_feng has joined #openstack-nova14:15
*** mtanino has joined #openstack-nova14:16
*** pwnall has quit IRC14:16
*** code-R_ has quit IRC14:16
sdaguealex_xu: that first patch is in merge conflict, can you respin?14:17
alex_xusdague: yea, will do now14:17
sdaguealex_xu: thanks14:17
alaskiI had some comments on simplifying that patch, but if others are happy with it as is just leave it14:18
alex_xusdague: but johnthetubaguy still have conern on the performance, and I didn't get chance to check the performance yet14:18
alex_xuand yes, alaski have comment also14:18
openstackgerritLee Yarwood proposed openstack/nova: block_device: Make refresh_conn_infos py3 compatible  https://review.openstack.org/34211114:19
sdaguealex_xu: well, lets get it out of merge conflict at least14:19
sdaguealex_xu: can you put together a devstack patch that shows it in action?14:19
*** praveen__ has joined #openstack-nova14:19
alex_xusdague: sorry, I didn't get what kind of devstack you expected14:19
alex_xusdague: do you have example?14:20
sdaguealex_xu: like create a policy file with some rules we know will trigger warnings14:20
*** tbachman has joined #openstack-nova14:21
sdagueto see it operating in a full stack environment14:21
alex_xusdague: emm...create a rule with user_id based enforcement?14:21
sdaguealex_xu: yeh, maybe half a dozen of them for policy points we don't enforce on for policy14:22
sdaguethen we'll see the warnings during a normal tempest run14:23
alex_xusdague: for now, the code won't allow add any policy which doesn't register14:23
*** marst has quit IRC14:24
*** shaohe_feng has quit IRC14:24
alex_xufor the policy which we don't enforce, that means doesn't register?14:24
*** shaohe_feng has joined #openstack-nova14:24
sdagueno, I mean, a policy point that we have registered14:25
sdaguebut that doesn't support user_id enforcement14:25
alex_xusdague: ok, I got it14:25
sdagueto simulate the expected situation that operators have old config files and don't realize we're no longer enforcing user_id for that point14:25
*** pwnall has joined #openstack-nova14:25
*** claudiub|2 has quit IRC14:26
alex_xusdague: ok, I see now, will try to write a patch for it14:26
dansmithalaski: getting back to your patch now14:28
johnthetubaguyjianghuaw: will need to have a deeper look at that, I suspect for xenapi it could be hardcoded to vhd?14:28
alaskidansmith: excellent14:29
sdaguealex_xu: thanks14:29
*** dikonoor has quit IRC14:29
*** suresh12 has quit IRC14:29
alex_xusdague: np14:29
bauzasalaski: so https://review.openstack.org/#/c/355091/ is the proposed fix for root_gb=0, right?14:29
jianghuawjohnthebubaguy: yes, should use vhd for xenapi.14:30
johnthetubaguybauzas: its more any instance that uses a volume for its boot disk, I think14:30
johnthetubaguybauzas: root/boot14:30
bauzasjohnthetubaguy: mmm, okay, so that's a pure temporary solution until the scheduler manages resource providers, right?14:32
cdentdansmith, bauzas, alaski, johnthetubaguy wanna talk about https://review.openstack.org/#/c/355263/ now, later, or on the review?14:32
jianghuawjohnthebubaguy: The hardcode exists in common place, it seems ugly if checking hypervisor there.14:32
alaskibauzas: yeah14:32
bauzasjohnthetubaguy: tbc, when I mention root_gb=0, I mean BFV instances but yeah :)14:33
jianghuawIf we can add configure fields, may specify it as vhd for xenapi, default use qcow2.14:33
alaskibauzas: I don't think the req_spec modification is temporary. the scheduler needs proper info to use, but the resource tracker thing is temporary I think14:33
bauzasalaski: good point14:34
*** lixiaoy1 has joined #openstack-nova14:34
alaskicdent: I'm fine for whatever. I've expressed my concern, mainly that I think we should pick a direction now and not veer later14:34
tdurakovjohnthetubaguy: hi, sorry was on meeting, little update for live-migration, I working researching locally nfs for live-migration job, lot's of folks on kvm forum, afair14:34
*** shaohe_feng has quit IRC14:34
johnthetubaguyjianghuaw: true, sorry, got too many other threads of conversations going right now, I would need to spend a good while digging in that code to give a more reasoned answer I am afraid14:34
*** TravT has quit IRC14:35
bauzasalaski: cdent: okay, hearing your concerns14:35
jianghuawjohnthetubaguy: fair enough. thanks very much.14:35
*** shaohe_feng has joined #openstack-nova14:35
johnthetubaguycdent: I am just not sure which direction is best, the current once is just opaque uuids that reference external things, I guess?14:36
jianghuawI've recorded it as this bug: https://bugs.launchpad.net/nova/+bug/161693814:36
openstackLaunchpad bug 1616938 in OpenStack Compute (nova) "XenAPI: failed to create image from volume" [Undecided,New]14:36
bauzasalaski: cdent: AFAIR, we agreed on having only API operations for managing the relationship between aggregate and RPs, the CRUD operations about an aggregate being kept in the compute endpoint14:36
*** mlavalle has joined #openstack-nova14:36
johnthetubaguybauzas: thats the problem I think, how do we validate the uuids for the aggregates in the placement API, or should we not bother14:37
*** hoangcx has joined #openstack-nova14:37
*** marst has joined #openstack-nova14:37
*** TravT has joined #openstack-nova14:37
johnthetubaguybauzas: could you remind me where Nova sends placement the aggregate uuids again? I forgot :(14:38
bauzasjohnthetubaguy: oh you mean the placement API should introspect the API DB14:38
*** walharth has quit IRC14:38
*** ociuhandu has quit IRC14:38
bauzasjohnthetubaguy: not sure I got your question ?14:38
bauzasjohnthetubaguy: you mean where we associate an aggregate and a resource provider?14:39
johnthetubaguybauzas: so Nova has to send the aggregates uuids to the placement API at some point, I think?14:39
*** sridharg has quit IRC14:39
*** melwitt_ has quit IRC14:40
johnthetubaguybauzas: or maybe who is reading though, ugh, I seem to have forgotten the model totally :(14:40
bauzasjohnthetubaguy: no, it's when you create the provider, you assign it to an aggregate14:40
bauzasjohnthetubaguy: sec, finding the spec14:41
bauzasjohnthetubaguy: http://specs.openstack.org/openstack/nova-specs/specs/newton/approved/generic-resource-pools.html#scenario-1-shared-disk-storage-used-for-vm-disk-images14:41
*** sdake has joined #openstack-nova14:42
johnthetubaguybauzas: so the host is reporting what aggregate uuids it is in, I assume?14:42
bauzasjohnthetubaguy: so I guess the open question is, should we conflict on a wrong aggregate uuid ?14:42
*** zul has quit IRC14:42
bauzasjohnthetubaguy: not really, AFAIK it was seen as an operator-defined call to setup their providers14:43
bauzassee scenario 114:43
johnthetubaguybauzas: so we add the hosts into the aggregate, why is that useful?14:43
*** moshele has quit IRC14:43
bauzasjohnthetubaguy: because we need to map a resource provider containing inventories (and later allocations) to a group of hosts14:44
johnthetubaguyI thought that is us saying, all these hosts share that specific storage14:44
bauzaszactly14:44
*** vishwanathj has quit IRC14:44
johnthetubaguyright, so how does that info get into the placement engine14:44
edleafejohnthetubaguy: so that we can see how much storage any of these hosts can access14:44
*** shaohe_feng has quit IRC14:44
*** vishwanathj has joined #openstack-nova14:44
bauzasjohnthetubaguy: by step #2 in the scenario 114:45
bauzashttp://specs.openstack.org/openstack/nova-specs/specs/newton/approved/generic-resource-pools.html#scenario-1-shared-disk-storage-used-for-vm-disk-images14:45
bauzas$RP_UUID=`openstack resource-provider create "/mnt/nfs/row1racks0610/" \     --aggregate-uuid=$AGG_UUID`14:45
johnthetubaguyI get why, I mean how, I am not getting the information flow here14:45
bauzasoh14:45
bauzassee above then14:45
*** shaohe_feng has joined #openstack-nova14:45
johnthetubaguyso lets turn the question around14:46
johnthetubaguywe do this:14:46
johnthetubaguyopenstack resource-provider create "/mnt/nfs/row1racks0610/" \     --aggregate-uuid=$BAD_AGG_UUID14:46
*** vishwanathj has quit IRC14:46
johnthetubaguynow what breaks14:46
*** vishwanathj has joined #openstack-nova14:46
edleafethat should fail if the agg_id doesn't exist14:47
johnthetubaguyit doesn't in the current code14:47
edleafeand should make a huge mess if the agg_id exists but it isn't the one they wanted.14:47
johnthetubaguybecause placement doesn't know what the aggregates are14:48
bauzasjohnthetubaguy: sure, that's the open question I mentioned above :)14:48
johnthetubaguynope14:48
johnthetubaguyI mean if you get the uuid wrong, what breaks?14:48
*** openstackgerrit has quit IRC14:48
bauzas(10:42:35) bauzas: johnthetubaguy: so I guess the open question is, should we conflict on a wrong aggregate uuid ?14:49
johnthetubaguyif we don't conflict14:49
johnthetubaguywhat breaks14:49
cdentkeep tryhing johnthetubaguy you've nearly brought them home14:49
*** openstackgerrit has joined #openstack-nova14:49
bauzasjohnthetubaguy: so, the problem is that we haven't yet implemented that relationship14:49
*** kevinz has joined #openstack-nova14:49
edleafeI was always assuming that it would conflict14:49
bauzasjohnthetubaguy: but I'd consider that the host would lookup its aggregate, then knowing its RP14:50
alaskijohnthetubaguy: the placement engine will at some point return that bad uuid for placement and Nova will say "what the heck is this, I guess I'll fail the build, or reschedule and hope for a different result"14:50
bauzasjohnthetubaguy: so say that the operator made a mistake in the mapping and we silently fail14:50
johnthetubaguyI think what breaks, might be, you return the aggregate uuid back to Nova, and Nova does't know what that means?14:50
cdentjohnthetubaguy: the answer is it depends on whether you continue to use the BADAGGUUID or not. If it was a typo and you do not use it again, then that shared disk is not available14:50
bauzasjohnthetubaguy: that would then mean that the host wouldn't find a RP attached to it14:50
johnthetubaguyalaski: yeah, +1 I think14:50
cdentif you continue to use the same agg again when you make host associations, it's okay14:50
*** kolesovdv has quit IRC14:51
edleafeSo it wasn't clear from the spec that these would be async calls, which is what this is sounding like14:51
cdentedleafe: how do you get that?14:51
johnthetubaguyso this call is sync:14:51
edleafeThe silent fail14:51
johnthetubaguy$RP_UUID=`openstack resource-provider create "/mnt/nfs/row1racks0610/" \14:52
johnthetubaguy    --aggregate-uuid=$AGG_UUID`14:52
johnthetubaguyits just a db operation14:52
edleafethe call is cast out, and we never listen to the response14:52
johnthetubaguywhich seems fine14:52
*** rama_y has joined #openstack-nova14:52
cdentedleafe: there is no cast14:52
johnthetubaguyright, its just recording the association in the model14:52
edleafecdent: then how does associating a rp with a bad id not fail explicitly?14:52
johnthetubaguynow that is the question I am asking14:53
johnthetubaguykinda14:53
cdentedleafe: we're talking about the code that is in progress, which creates any agg id that doesn't already exist14:53
cdent_nothing_ is yet using those agg ids14:53
*** david-lyle has joined #openstack-nova14:53
bauzashonestly, I'm not opiniated about whether we would enforce some kind of preventive mechanism for ensuring the aggregate exists14:54
edleafecdent: ah, that14:54
*** tbachman has quit IRC14:54
edleafethat's where I have a disconnect14:54
johnthetubaguyso we have this issue with quota and tenant id14:54
johnthetubaguyand we have never managed to fix it14:54
johnthetubaguywhich is sort of OK, and sort of terrible14:54
edleafeIf we're doing the (insane) multiple DB approach, we have to accept the burden of validating in more than one place14:54
johnthetubaguyreally, what I am thinking, is should placement own the aggregate or not, I guess14:55
*** shaohe_feng has quit IRC14:55
bauzasjohnthetubaguy: long-term yes14:55
johnthetubaguybut if it owns the aggregate, then we have host uuids that not validated, I guess, unless it owns the service stuff too, which it could14:56
cdentfrom the backend's standpoint if we have a placement db, then it needs to have some representation, in itself, of the agg uuid in order to do the joins it would like to do14:56
alaskijohnthetubaguy: I think that's the question. If so then let's validate, if not then let's accept errors and be good about exposing them when they happen in Nova14:56
johnthetubaguyalaski: yeah, +114:56
*** shaohe_feng has joined #openstack-nova14:56
cdentwhether those agg uuids need to be valid or not, or if they need to be the _actual_ aggregates is unclear14:56
alaskiI'm leaning towards let's accept bad aggs and deal with them in Nova. I do not want to be in the position of verifying data across two services14:57
cdentalaski +114:57
johnthetubaguyI think thats simpler, and we make progress quickly14:57
bauzasalaski: that's why I think I'm not opiniated14:57
*** praneshp has joined #openstack-nova14:57
johnthetubaguyit does mean its harder to move aggregates longer term, I feel14:57
edleafeas long as failure is an option, sure14:58
johnthetubaguyright now its auto adding14:58
johnthetubaguyi.e. accepts any valid uuid14:58
alaskijohnthetubaguy: yeah. but I'm getting the sense that aggs may never move to placement14:58
cdentI think alaski is right14:58
johnthetubaguyalaski: what wins it for me, is if we did move the aggregate, then the host-id would have the same issue14:59
cdentI think we'll have agg uuids in placement, but the info associated with aggregates will not14:59
alaskijohnthetubaguy: right14:59
*** ljxiash has joined #openstack-nova14:59
alaskicdent: yeah14:59
bauzasthat's what we basically agreed in the past :)14:59
cdentbecauses other services will have aggregates with different forms14:59
*** david-lyle has quit IRC14:59
johnthetubaguyOK is a group uuid, the group is owned by the service15:00
*** takashin has left #openstack-nova15:00
johnthetubaguythat works15:00
cdentcool, it sounds like we have aggreement, and aggrement with the past, and aggreement that we actually understand rather than fog.15:00
johnthetubaguycdent: I think we basically are now saying +2 (ish) your patch?15:00
*** pwnall has quit IRC15:00
cdentthat's a good win, thanks everyone for the help15:00
*** JoseMello has quit IRC15:00
cdentjohnthetubaguy: it does seem that way15:00
alaskiyeah. honestly it might help if we didn't call it aggregates in placement, but...15:00
johnthetubaguyalaski: yeah, I was just thinking that, but never mind15:00
cdentalaski: it's called that because when it is using the api database it _is_ using aggregates table15:01
cdentthe model is a mask over the Aggregates model15:01
edleafeHow about 'pools'? Oh, wait...15:01
edleafe:)15:01
cdent(this dual database thing is ... )15:01
alaskicdent: I figured15:01
*** zul has joined #openstack-nova15:01
johnthetubaguyI kinda assumed it was a parallel table15:01
johnthetubaguywould that not be easier?15:01
bauzashold on15:02
bauzasI'm seeing a PlacementAggregate object model15:02
bauzaswhich I think is not good for me15:02
cdent(next time let's write the api first moving backwards to the data implementation)15:02
bauzasin cdent's patch15:02
cdentbauzas: that's the mask I just mentioned15:02
alaskicdent: yeah, and the desired workflow15:03
*** tbachman has joined #openstack-nova15:03
bauzascdent: why do we reproduce that table ?15:03
* edleafe has contractors here - brb15:03
cdentlet me find the review bauzas15:03
*** sai has joined #openstack-nova15:03
*** tonytan4ever has joined #openstack-nova15:03
bauzascdent: couldn't we just have either a field on the ResourceProvider or just a mapping table?15:03
cdentbauzas: https://review.openstack.org/#/c/349021/15:04
johnthetubaguybut isn't the PlacementAggregate a separate table?15:04
cdentthe third database has already merged15:04
johnthetubaguyoh, sorry, I see it now15:04
johnthetubaguyoh, so maybe I don't...15:05
*** shaohe_feng has quit IRC15:05
*** shaohe_feng has joined #openstack-nova15:05
cdentIs there a question?15:06
*** tonytan_brb has quit IRC15:06
johnthetubaguyI guess I was expecting https://review.openstack.org/#/c/349021/13/nova/db/sqlalchemy/api_models.py@366 to have a different name15:06
bauzasjohnthetubaguy: I guess I was expecting to have a mapping table...15:07
*** pwnall has joined #openstack-nova15:08
*** bnemec has quit IRC15:08
johnthetubaguybauzas: you mean ResourceProviderAggregate?15:08
bauzaskinda yes15:08
cdentwhen that code was merged the idea was: if the api database is the one being used, then we continue using the existing aggregates table15:08
cdentif placement db is being used, we have our own aggregates table (in the placement db)15:09
bauzascdent: I really dislike the latter15:09
cdentthere is a ResourceProviderAggregate model/table15:09
johnthetubaguyyeah, I think we should probably just have our own separate table in both cases15:09
bauzascdent: so we could have 2 different tables in two separate DBs carrying the exact same information ? :(15:10
*** jamesden_ has joined #openstack-nova15:10
cdentthey don't have the same information15:10
cdentin the placement db it is just the uuids and primary key15:10
bauzascdent: lemme rephrase15:10
*** suresh12 has joined #openstack-nova15:11
bauzascdent: they carry the same abstraction15:11
cdentI argued (with jay) that all we really needing was a resourc provider -> agg uuid mapping but he wanted a secondary table15:11
*** zul has quit IRC15:11
cdentthat join resource provider ids to agg ids15:11
cdentwe've had a resource provider aggregates table for a few months now15:11
johnthetubaguyyeah, its a DB performance thing on the index I guess?15:11
*** praveen__ has quit IRC15:11
cdentyes15:11
johnthetubaguythat bits fine15:11
bauzasjohnthetubaguy: we can have an index on a mapping table15:12
*** salv-orlando has joined #openstack-nova15:12
bauzasnot sure I see the reasoning behind creating a new table that would redefine what an aggregate is, placement-wise15:12
cdentbauzas: we can do lots of things, but changing things now is complicated, what path do we have to do that?15:12
*** pbandark has quit IRC15:12
*** ociuhandu has joined #openstack-nova15:12
johnthetubaguyI think if the ProviderAggregate table just and id an uuid, (i.e. table_name = something different to aggregate) that would work OK?15:12
johnthetubaguycdent: can we just add a new ProviderAggregate table, then your code starts populating that?15:13
*** bnemec has joined #openstack-nova15:13
bauzascdent: we can revert this15:13
johnthetubaguycdent: that does mean changing the mapping table to point to the new DB as well, I guess, but its empty I assume?15:13
johnthetubaguybauzas: DB migrations, we can't revert15:13
bauzasoh snap yes15:13
cdentjohnthetubaguy: you mean change the table underneath ProviderAggregate, provide a migration to create it (in both api database and placement database)? that's probably doable15:13
johnthetubaguycdent: yeah, that15:14
cdents/Provider/Placement/15:14
bauzasjohnthetubaguy: but we can leave that table unfilled15:14
johnthetubaguyyeah, my brain did that switch it seems15:14
johnthetubaguybauzas: ??15:14
bauzasthe big thing to me is honestly https://review.openstack.org/#/c/349021/13/nova/db/sqlalchemy/api_models.py@36615:14
bauzasso, yeah, we could modify that to clarify this is *not* a new definition of what an aggregate is15:15
*** vishwanathj has quit IRC15:15
*** shaohe_feng has quit IRC15:15
johnthetubaguybauzas: yep, +115:15
bauzasbut I'd love to get jay's thoughts here15:15
bauzasbecause I don't get why he promoted that15:15
*** shaohe_feng has joined #openstack-nova15:15
*** vishwanathj has joined #openstack-nova15:16
bauzasso I'm potentially missing some key reasons why15:16
*** su_zhang has quit IRC15:16
*** mat128|away is now known as mat12815:16
johnthetubaguyso the downside of creating a new placementaggregate in both DBs is we have data duplication where it feels like you don't need it15:16
*** kevinz has quit IRC15:16
johnthetubaguybut the auto create, means the placement API would break the nova API in odd ways15:16
bauzasmmm, I see your point15:16
bauzasI was thinking that mapping table being as the exact same place than the ResourceProviders table15:17
bauzasthe aggregates being in another DB15:17
*** nkrinner is now known as nkrinner_afk15:17
*** salv-orl_ has joined #openstack-nova15:18
*** vishwanathj has quit IRC15:18
*** WJMUqqJZRD has joined #openstack-nova15:19
*** code-R has quit IRC15:19
*** vishwanathj has joined #openstack-nova15:19
johnthetubaguycdent: does that sound OK then, creating a new table, and changing that mapping table?15:19
cdentbauzas: if you could summarize your thoughts to the review that would be great. I'll try to get Jay to look at it soon (he's on pto but is supposed to be reading email).15:19
cdentI don't really understand the "changing that mapping table" part?15:19
*** tbachman has quit IRC15:20
cdentis that basically: what we have now, but with the right hand side table not being named "aggregages"?15:20
johnthetubaguycdent: I am very unclear, I am typing this up in the review in better words15:20
bauzascdent: tbc, I have concerns with https://review.openstack.org/#/c/349021/13 being a reality15:20
cdentjohnthetubaguy: awesome thank you15:20
johnthetubaguycdent: yeah, basically that15:20
bauzascdent: because we agreed during the midcycle to not do that15:20
*** salv-orlando has quit IRC15:20
cdentbauzas: no we agreed in the midcycle to do _exactly_ that15:20
*** links has joined #openstack-nova15:21
*** code-R has joined #openstack-nova15:21
cdent(this most recent one)15:21
dansmithwtf15:21
cdentdansmith?15:21
bauzasand rather make use of a connection string to play with15:21
dansmithcdent: how did placement migrations get merged? we agreed to NOT do that for newton15:21
*** suresh12 has quit IRC15:21
cdentdansmith: we clearly went to do different midcycles? we decided to allow optional placement database15:22
cdentsee: https://review.openstack.org/#/c/349021/13/releasenotes/notes/placement-database-5aa94ece29eab820.yaml15:22
dansmithcdent: connection string15:22
dansmithnot a new set of migrations15:22
dansmithspecifically discussed that with jay15:22
*** sdague has quit IRC15:22
cdentdansmith: if you have a different database it has to have some tables in it?15:23
dansmithcdent: that's exactly the point.. it was supposed to be the exact same schema as the api database until we move to split15:23
* cdent sighs15:24
cdentall I know is a) what I was told to do, apparently with incomplete info, b) people who were supposed to have more info merged that code15:25
*** shaohe_feng has quit IRC15:25
*** code-R has quit IRC15:26
johnthetubaguydansmith: hmm, I think I remember discussing that, now you mention it, to avoid the complexity of two streams for now15:26
cdentThink of me as the resource providers chinese room: instructions come in and I just do them. Any indication that I know what i'm doing beyond the wsgi app side of things is artifice.15:26
*** zul has joined #openstack-nova15:26
dansmithjohnthetubaguy: yeah, like.. ..yeah15:26
cdentthe code on that review is what rpodolyaka and I were told was the right thing to do. If it's not right, I guess we'll fix it.15:27
johnthetubaguycdent: bauzas: tried to summarise my DB change ideas here: https://review.openstack.org/#/c/355263/4/nova/objects/resource_provider.py@39915:27
dansmithjohnthetubaguy: I _specifically_ discussed this exact point with jaypipes so I'm really really confused as to how this happened15:27
dansmiththere definitely wasn't a lot of review representation on the patch that merged this enormous step15:27
*** shaohe_feng has joined #openstack-nova15:28
johnthetubaguydansmith: its about a week later that I would usually say we are safe to revert, but maybe we should revert that?15:28
dansmithjohnthetubaguy: I think we should15:28
cdentwe can probably revert the whole pile because it only gets used if people explicitly turn on a config setting _and_ run some specific commands15:28
dansmithwas going to look and see if we're doing this in devstack yet15:28
bauzaswe're in the same milestone at least15:28
alaskimy understanding was that the placement db would run the same migrations as the api db for now15:28
johnthetubaguycdent: true, its edge case actually, I got my wires the wrong way around15:28
dansmithright, exactly15:28
johnthetubaguycdent: I was thinking we changed the api db15:29
johnthetubaguydansmith: if you propose the revert, I am +W it?15:29
cdentdansmith: there's no placement devstack stuff yet, just unmerged things: https://review.openstack.org/#/c/342362/15:29
dansmithcdent: okay15:29
dansmithjohnthetubaguy: okay I'm at a conference this week so it will be hard, but I'll try15:29
johnthetubaguydansmith: ah, gotcha, let me try the button15:30
openstackgerritJohn Garbutt proposed openstack/nova: Revert "Optional separate database for placement API"  https://review.openstack.org/36063815:30
*** sdague has joined #openstack-nova15:30
dansmithjohnthetubaguy: oh I figured we'd have a few to do, but let me look15:30
cdentdansmith: I think that's the only one that actually does anything with it, yet15:31
dansmithokay15:31
*** derekh has quit IRC15:31
johnthetubaguyso the test would hopefully tell me off soonsih, if thats not true, I guess15:31
dansmithjohnthetubaguy: merge conflict15:31
alaskicdent: I think what was merged was correct except that it should just use the api db migrations/models.15:31
dansmithjohnthetubaguy: do you have time to try to resolve those? if not I'll take a go at it15:32
alaskiwhich would have the side effect of keeping behavior the same between the two dbs while we're in an optional split scenario15:32
dansmithalaski: yeah, probably right15:32
bauzasalaski: well, we shouldn't have shipped both the new PlacementAggregate table (which is part of a separate discussion, unrelated to the move) and the new model15:32
bauzas(and migrations)15:32
cdentI'm afraid I need to go. I'm pretty confused, so if someone could summarize what's going on, somewhere, that would be really useful.15:33
openstackgerritJohn Garbutt proposed openstack/nova: Revert "Optional separate database for placement API"  https://review.openstack.org/36063815:33
cdentOtherwise I'll be back later to dig at alaski or dansmith brains.15:34
johnthetubaguyah, boo, it doesn't merge, I guess thats to be expected15:34
alaskicdent: yeah, poke me later15:34
*** cdent has quit IRC15:34
johnthetubaguyalaski : it doesn't fix the above case sadly, but it would sure stop any possible drift in schema15:34
*** derekh has joined #openstack-nova15:34
*** andreas_s has quit IRC15:35
alaskiI looked away for a second so I don't know what the other case is15:35
johnthetubaguyah, sorry, this bit: https://review.openstack.org/#/c/355263/4/nova/objects/resource_provider.py@39915:35
*** shaohe_feng has quit IRC15:36
dansmithjohnthetubaguy: it's resource provider tests.. I'll fix it up15:36
johnthetubaguydansmith: oh, sweet, thanks15:36
openstackgerritPavel Kholkin proposed openstack/python-novaclient: Fixes TypeError on Client instantiation  https://review.openstack.org/24027715:36
johnthetubaguysbezverk_: did you have any more look after restarting the services?15:38
*** hoangcx has quit IRC15:38
*** gouthamr is now known as gouthamr|afk15:38
openstackgerritDan Smith proposed openstack/nova: Revert "Optional separate database for placement API"  https://review.openstack.org/36063815:38
openstackgerritPavel Kholkin proposed openstack/python-novaclient: Fixes TypeError on Client instantiation  https://review.openstack.org/24027715:38
*** Swami has joined #openstack-nova15:39
sdagueok, so as I apparently misunderstood direction here for the placement API and the db, can someone summarize what the expected path forward here is?15:39
dansmithalaski: bauzas sdague ^ should be good now, but we'll see how the tests go15:39
johnthetubaguysdague: basically the config just points to a DB with the same schema as the api db, for now, i.e. one stream of migrations for both DBs15:40
*** kaisers_ has joined #openstack-nova15:40
*** burt has joined #openstack-nova15:40
dansmithsdague: which provides an optional early optimization for big deploys if they want to avoid moving some records later when the service is moved out15:40
*** armax has joined #openstack-nova15:41
dansmithsdague: but entirely optional at this point15:41
dansmithsdague: otherwise people *have* to spawn the third database in newton before we can move on15:41
*** shaohe_feng has joined #openstack-nova15:41
sdaguejohnthetubaguy: ok, got it15:41
alaskisdague: that patch was correct in having an optional third database, but the plan was to essentially 'nova api_db sync' the placement db and reuse the models. so no drift between them15:41
sdaguealaski: ok, so the migrations are in the wrong stream there, all migrations will get taken on the placement db as in the api db15:41
alaskisdague: correct15:42
sdagueit will happen api -> placement, and placement will just noop if it's the same uri because of the migration counter15:42
dansmithwell, no15:42
*** praneshp has quit IRC15:42
dansmiththere should be no migrations for the placement db right now15:42
dansmiththere should be no placement sync command15:42
*** hshiina has quit IRC15:43
alaskiright, nova-manage api_db sync15:43
*** vishwanathj has quit IRC15:44
sdagueah, ok, the 314 migration covers what was in this patch15:44
*** hoangcx has joined #openstack-nova15:44
*** kaisers_ has quit IRC15:44
*** vishwanathj has joined #openstack-nova15:45
alaskijohnthetubaguy: okay, I see the PlacementAggregate issue you mean. I'll have to think on it a bit more before commenting on your alternative15:45
*** raj_singh_ has joined #openstack-nova15:45
*** raj_singh_ has left #openstack-nova15:46
*** raj_singh_ has joined #openstack-nova15:46
*** shaohe_feng has quit IRC15:46
*** andymaier has quit IRC15:46
openstackgerritAnusha Unnam proposed openstack/nova: Disassociate floating ip when fixed ip is removed  https://review.openstack.org/35029915:46
*** BjoernT has joined #openstack-nova15:46
johnthetubaguyalaski: np, sounds good15:46
*** shaohe_feng has joined #openstack-nova15:47
sdagueso... if the default placement db uri was the api uri, the old patch would have still done the right thing though. Other than an extra engine fascade?15:49
johnthetubaguyyeah, its more a maintenance thing on that stream15:51
johnthetubaguythe PlacementAggregate might need rework, but thats not a revert thing15:51
*** shaohe_feng has quit IRC15:56
dansmithsdague: there should be no separate migrations15:56
*** nic has joined #openstack-nova15:56
sdaguedansmith: sure, that is fine15:56
dansmithsdague: if not then it's mostly fine yes15:57
*** cdent has joined #openstack-nova15:58
*** shaohe_feng has joined #openstack-nova16:00
*** links has quit IRC16:00
*** sameo has joined #openstack-nova16:01
*** derekh has quit IRC16:02
*** hoangcx has quit IRC16:02
*** hoangcx has joined #openstack-nova16:03
openstackgerritSwaminathan Vasudevan proposed openstack/nova: Implement setup_networks_on_host for Neutron networks  https://review.openstack.org/27507316:04
*** dikonoor has joined #openstack-nova16:04
*** vishwanathj has quit IRC16:04
openstackgerritAndrew Laski proposed openstack/nova: Pull from cell0 and build_requests for instance list  https://review.openstack.org/35613816:04
openstackgerritAndrew Laski proposed openstack/nova: Add BuildRequestList object  https://review.openstack.org/35613716:05
*** vishwanathj has joined #openstack-nova16:05
openstackgerritAndrew Laski proposed openstack/nova: Clean up instance mappings, build requests on quota failure  https://review.openstack.org/35739616:05
alaskidansmith: melwitt ^16:05
dansmithalaski: frankly I'm sick of melwitt making me look bad16:05
*** jianghuaw-m has joined #openstack-nova16:05
alaskiI'm right there with you16:05
melwitt:(16:05
melwitt:)16:05
*** pwnall has quit IRC16:06
alaski:)16:06
dansmithalaski: I wish she was more of a team player16:06
*** tbachman has joined #openstack-nova16:06
dansmithlike "this is clearly wrong and you are both idiots, but for the sake of the team I will keep my complaints quiet"16:06
*** shaohe_feng has quit IRC16:06
dansmithbut nay.16:06
*** jvgrant has joined #openstack-nova16:06
dansmithselfishly points out bugs with no regard for egos16:07
dansmithle sigh.16:07
*** zul has quit IRC16:07
*** shaohe_feng has joined #openstack-nova16:07
melwitt... lol16:07
*** pwnall has joined #openstack-nova16:08
*** hoangcx has quit IRC16:08
*** marst has quit IRC16:10
*** marst has joined #openstack-nova16:10
*** zenoway has quit IRC16:10
*** praneshp has joined #openstack-nova16:13
openstackgerritPavel Kholkin proposed openstack/nova: test_keypairs_list_for_different_users for v2.10  https://review.openstack.org/34746216:13
*** tonytan_brb has joined #openstack-nova16:15
*** Vek has quit IRC16:15
*** Vek has joined #openstack-nova16:15
*** shaohe_feng has quit IRC16:17
*** raj_singh_ has quit IRC16:17
*** Guest45318 has quit IRC16:17
*** shaohe_feng has joined #openstack-nova16:17
*** tonytan4ever has quit IRC16:17
*** lixiaoy1 has quit IRC16:21
*** lixiaoy1 has joined #openstack-nova16:22
*** sdague has quit IRC16:23
*** raunak has joined #openstack-nova16:24
*** burt has quit IRC16:24
*** burt has joined #openstack-nova16:24
*** zul has joined #openstack-nova16:25
*** hoangcx has joined #openstack-nova16:25
*** tbachman has quit IRC16:25
*** abalutoiu has quit IRC16:26
*** shaohe_feng has quit IRC16:27
*** vishwanathj has quit IRC16:27
*** shaohe_feng has joined #openstack-nova16:27
*** vishwanathj has joined #openstack-nova16:28
*** tbachman has joined #openstack-nova16:28
*** dikonoor has quit IRC16:28
*** edand has quit IRC16:28
openstackgerritPushkar Umaranikar proposed openstack/nova: Remove internal_id attribute from instances table  https://review.openstack.org/36066616:29
openstackgerritAndrey Volkov proposed openstack/nova: Add test fixture for cell0.  https://review.openstack.org/30186416:29
openstackgerritAndrey Volkov proposed openstack/nova: Map instances to cell0 on failed schedule  https://review.openstack.org/26782716:29
*** rtheis_ has joined #openstack-nova16:29
*** lamt has quit IRC16:31
*** rtheis has quit IRC16:31
openstackgerritTimofey Durakov proposed openstack/nova: PCI devices should be in 'allocated' after resize  https://review.openstack.org/33402416:33
*** shaohe_feng has quit IRC16:37
*** shaohe_feng has joined #openstack-nova16:38
*** Apoorva has joined #openstack-nova16:40
*** Apoorva has quit IRC16:40
*** Apoorva has joined #openstack-nova16:42
*** dimtruck is now known as zz_dimtruck16:42
*** hoangcx has quit IRC16:45
*** rcernin has quit IRC16:45
*** gouthamr|afk is now known as gouthamr16:46
*** fragatina has joined #openstack-nova16:47
*** fragatina has quit IRC16:47
*** shaohe_feng has quit IRC16:47
*** jamesdenton has joined #openstack-nova16:48
*** fragatina has joined #openstack-nova16:48
*** shaohe_feng has joined #openstack-nova16:48
*** jamesden_ has quit IRC16:48
*** fragatina has quit IRC16:49
*** fragatina has joined #openstack-nova16:50
*** david-lyle has joined #openstack-nova16:50
*** rrecio has joined #openstack-nova16:50
*** jamesdenton has quit IRC16:53
*** jamesdenton has joined #openstack-nova16:54
*** suresh12 has joined #openstack-nova16:54
*** hoangcx has joined #openstack-nova16:55
*** tesseract- has quit IRC16:56
*** ssurana has joined #openstack-nova16:56
*** _ducttape_ has joined #openstack-nova16:57
*** tblakes has quit IRC16:57
*** shaohe_feng has quit IRC16:58
*** unicell1 has quit IRC16:58
*** su_zhang has joined #openstack-nova16:58
*** dikonoor has joined #openstack-nova16:59
*** shaohe_feng has joined #openstack-nova16:59
*** anush_ has quit IRC17:00
*** ducttape_ has quit IRC17:01
pkholkinalaski: hello Andrew, I've updated the patch and left my own comments there, please look, thanks! https://review.openstack.org/#/c/34746217:01
sbezverk_johnthetubaguy: ping17:01
*** rtheis_ is now known as rtheis17:01
*** edand has joined #openstack-nova17:01
*** suresh12 has quit IRC17:04
*** zul has quit IRC17:04
*** zz_dimtruck is now known as dimtruck17:07
*** suresh12 has joined #openstack-nova17:07
*** shaohe_feng has quit IRC17:08
*** tri2sing has joined #openstack-nova17:08
*** shaohe_feng has joined #openstack-nova17:11
*** lucasagomes is now known as lucas-dinner17:12
*** amotoki has quit IRC17:17
alaskipkholkin: responded17:18
*** shaohe_feng has quit IRC17:18
*** lpetrut has quit IRC17:19
*** bwallis has joined #openstack-nova17:19
*** tbachman has quit IRC17:20
*** shaohe_feng has joined #openstack-nova17:21
*** unicell has joined #openstack-nova17:22
*** zul has joined #openstack-nova17:24
*** _ducttape_ has quit IRC17:25
*** shaohe_feng has quit IRC17:28
*** shaohe_feng has joined #openstack-nova17:29
*** kaisers_ has joined #openstack-nova17:29
*** code-R has joined #openstack-nova17:29
*** zul has quit IRC17:32
*** code-R has quit IRC17:34
*** kaisers_ has quit IRC17:34
*** dikonoor has quit IRC17:36
*** edand has quit IRC17:38
*** suresh12 has quit IRC17:38
*** shaohe_feng has quit IRC17:39
*** shaohe_feng has joined #openstack-nova17:40
openstackgerritGábor Antal proposed openstack/nova: Changed exception catching order  https://review.openstack.org/34945017:40
*** Jeffrey4l__ has quit IRC17:41
*** StevenK has quit IRC17:41
*** StevenK has joined #openstack-nova17:42
*** cdent has quit IRC17:44
openstackgerritGábor Antal proposed openstack/nova: Changed exception catching order  https://review.openstack.org/34945017:47
*** gszasz has quit IRC17:47
*** eharney_ has joined #openstack-nova17:47
*** suresh12 has joined #openstack-nova17:48
*** sdague has joined #openstack-nova17:48
*** shaohe_feng has quit IRC17:49
*** eharney has quit IRC17:49
*** eharney_ is now known as eharney17:50
*** shaohe_feng has joined #openstack-nova17:50
*** ducttape_ has joined #openstack-nova17:51
pkholkinalaski: so the conclusion: add comment that post is not permitted and return pass ?17:52
*** tblakes has joined #openstack-nova17:53
alaskipkholkin: yeah, if you can't create a keypair to check the list operation then just comment and pass17:53
alaskibut I would think there would be a way to do that17:53
*** rcernin has joined #openstack-nova17:54
pkholkinalaski: I think for different users we can't17:54
pkholkinonly admin and it is tested17:55
alaskiyeah, not for different users. but can you create a keypair and then use a different user to try to list?17:55
alaskithe create could be done by an admin in the test if needed17:55
*** shaohe_feng has quit IRC17:59
*** shaohe_feng has joined #openstack-nova17:59
pkholkinalaski: do we want to create kps by admin and then list by non-admin18:00
*** david-lyle has quit IRC18:00
*** tbachman has joined #openstack-nova18:02
*** ihrachys has quit IRC18:02
*** sdake has quit IRC18:03
*** david-lyle has joined #openstack-nova18:04
pkholkinI am not sure how to switch between them during the test18:04
*** cleong has quit IRC18:04
*** corey_ has joined #openstack-nova18:04
*** sdake has joined #openstack-nova18:04
*** lamt has joined #openstack-nova18:05
*** sudipto has quit IRC18:05
alaskipkholkin: okay. It may not be possible, I'm not really sure how these api samples tests are setup. What I was thinking was have the first part of https://review.openstack.org/#/c/347462/4/nova/tests/functional/api_sample_tests/test_keypairs.py@204 up to line 215, and then check the _do_get calls. But if that first part fails then maybe just pass18:05
*** yamahata has quit IRC18:06
pkholkinalaski: my understanding was the same18:06
*** zenoway has joined #openstack-nova18:06
pkholkinalaski: I've updated the comment18:06
alaskiokay, cool18:07
pkholkinalaski: will also wait for mriedem to look18:07
pkholkingerrit is too slow (18:09
*** ociuhandu has quit IRC18:09
*** shaohe_feng has quit IRC18:09
*** david-lyle has quit IRC18:11
*** zenoway has quit IRC18:11
*** shaohe_feng has joined #openstack-nova18:11
alaskiyeah, lots of 502s when I was commenting earlier18:12
*** david-lyle has joined #openstack-nova18:12
*** lpetrut has joined #openstack-nova18:13
*** zul has joined #openstack-nova18:13
pkholkinyes18:14
pkholkingit review is very slooow, too18:14
*** david-lyle_ has joined #openstack-nova18:15
*** david-lyle_ has quit IRC18:15
*** hoangcx has quit IRC18:15
openstackgerritPavel Kholkin proposed openstack/nova: test_keypairs_list_for_different_users for v2.10  https://review.openstack.org/34746218:15
pkholkinalaski: ^18:15
*** WJMUqqJZRD has quit IRC18:16
*** fragatina has quit IRC18:17
*** shaohe_feng has quit IRC18:20
*** hoangcx has joined #openstack-nova18:20
*** aswadr_ has quit IRC18:21
*** ManishD has joined #openstack-nova18:21
ManishDHello Guys, please can you review the patch: https://review.openstack.org/#/c/357131/18:22
*** rlrossit has quit IRC18:22
*** shaohe_feng has joined #openstack-nova18:23
*** lpetrut has quit IRC18:24
*** NomNKDJIvx has joined #openstack-nova18:25
*** su_zhang has quit IRC18:25
*** su_zhang has joined #openstack-nova18:26
*** rlrossit_ has joined #openstack-nova18:26
*** jichen has joined #openstack-nova18:27
ManishD@Matt Riedemann, David Berrang, please can you help review the patch: https://review.openstack.org/#/c/357131/18:30
*** shaohe_feng has quit IRC18:30
*** shaohe_feng has joined #openstack-nova18:30
*** Sukhdev has joined #openstack-nova18:33
*** zul has quit IRC18:34
*** salv-orl_ has quit IRC18:37
*** shaohe_feng has quit IRC18:40
*** marcusvrn_ has joined #openstack-nova18:41
*** shaohe_feng has joined #openstack-nova18:42
*** kaisers_ has joined #openstack-nova18:43
*** yamahata has joined #openstack-nova18:44
*** vishwanathj has quit IRC18:47
melwittsomething is definitely afoot with gerrit right now18:47
*** vishwanathj has joined #openstack-nova18:48
*** kfarr has joined #openstack-nova18:49
*** shaohe_feng has quit IRC18:50
*** shaohe_feng has joined #openstack-nova18:51
*** salv-orlando has joined #openstack-nova18:51
*** su_zhang has quit IRC18:51
*** krotscheck has left #openstack-nova18:51
*** YqwHkAMaYX has joined #openstack-nova18:53
*** su_zhang has joined #openstack-nova18:53
*** hoangcx has quit IRC18:53
*** su_zhang has quit IRC18:53
*** hoangcx has joined #openstack-nova18:55
*** sdague has quit IRC18:58
*** praneshp has quit IRC18:59
*** shaohe_feng has quit IRC19:01
*** praneshp has joined #openstack-nova19:01
*** praneshp has quit IRC19:01
*** shaohe_feng has joined #openstack-nova19:01
*** praneshp has joined #openstack-nova19:02
*** fragatina has joined #openstack-nova19:02
*** ManishD has quit IRC19:03
*** cdent has joined #openstack-nova19:04
cdentalaski: if you have the time/energy I'm prepared to be illuminated. Or happy to wait until tomorrow if you prefer.19:07
alaskicdent: now is fine19:07
*** praneshp has quit IRC19:08
alaskithe short description is that there should be nothing specific to a new placement db except for an optional connection string19:08
cdentCool, so the gist is that different migrations is a no-no because that could cause drift, so the solution is to have all the api tables in the placement db, even though some of them wouldn't be used?19:08
alaskiyes19:08
alaskiunused tables can be dropped later when there's a full split19:09
cdentThere were comments like "no sync command for placement db". How, then, do you create a placement db?19:09
*** hshiina has joined #openstack-nova19:09
*** david-lyle has quit IRC19:10
*** zul has joined #openstack-nova19:11
*** shaohe_feng has quit IRC19:11
alaskimy best thought would be to have nova-manage api_db sync check for the placement db connection string and also do the migration there if it exists19:11
cdentso if connection string not none and not the same as the db api, do it all again, otherwise nothing?19:12
alaskiyeah19:12
*** shaohe_feng has joined #openstack-nova19:12
alaskieven if it's the same it should be fine, it'll just say the db is up to date19:13
cdentah, right19:13
dansmithyep, that19:13
dansmithalso: http://logs.openstack.org/38/360638/3/check/gate-nova-python27-db-ubuntu-xenial/cd5a0f5/console.html#_2016-08-25_17_58_41_27727719:13
dansmithit's failing hard19:13
dansmithI guess that just needs to change to api_manager or whatever19:14
cdentdamn, I wish we were aware of this when were writing the code originally because it was a huge pain in the ass to get right, we had three different commits we were working on concurrently, trying to decide which was the best way around the problems with testing (dealing with fixtures was _rough_)19:15
cdentdansmith I can take over the patch and fix the rough edges if you like. You're right that's what needs to change19:15
cdentand some bits of config here and there. I had forgotten that that stuff had merged too19:16
dansmithcdent: I'm taking a stab now, but if it gets hard I'll toss over to you :)19:16
cdentit ought to be fairly obvious. the only part that's not just a search and replace will be in the fixtures.py down near the gabbi stuff, and the functional/db/test_resource_provider.py asking for the placement fixture19:17
dansmithoh19:17
*** raunak has quit IRC19:18
dansmithcdent: I don't see any placement stuff in test_resource_provider19:18
*** jheroux has joined #openstack-nova19:18
cdentdansmith: in nova/tests/functional/db/test_resource_provider.py ?19:19
*** YqwHkAMaYX has quit IRC19:19
dansmithbrb19:20
*** Apoorva has quit IRC19:20
cdentthat's in my master19:20
*** salv-orlando has quit IRC19:21
*** shaohe_feng has quit IRC19:21
*** shaohe_feng has joined #openstack-nova19:21
*** praneshp has joined #openstack-nova19:22
bauzaswhat I don't get is why it's failing19:23
cdentalaski: so on the get and set aggregates stuff, was the decision that there should be a new table (in "both" databases) that is id/uuid representing an aggregate?19:23
cdentbauzas: because code that merged after it is using the placement context manager, which no longer exists19:24
bauzasdid we merged some other patch relying on it ?19:24
bauzasokay19:24
*** su_zhang has joined #openstack-nova19:24
bauzas(I literally killed my return key this morning so my productivity lowered a lot)19:25
dansmithcdent: right, I think that's reverted in the revert already19:25
*** sameo has quit IRC19:25
cdentdansmith: then may just be the context manager stuff19:25
alaskicdent: no real decision, but I think that has to be the case. We need to pretend that anything that won't be in the placement db isn't in the api db for these purposes I think19:25
*** sdague has joined #openstack-nova19:26
cdentthat's annoying duplication but it does make it simpler19:26
cdenttomorrow I'll try to write up a plan on what needs to happen to cover both of these things and share it around so we can be sure to get it right and done quickly19:27
alaskiand makes me even more not want it to be called aggregates, because I don't like a placement_aggregates table19:27
cdentI haven't got the mental capacity to think in a creative fashion tonight19:27
cdentyeah19:27
bauzascdent: I thought we already discussed about that... why needing to sort out a plan on something we agreed already ? :)19:27
alaskicool. just ping me when you've got it together19:27
bauzasit was clearly in my mind19:28
cdentbauzas: heh. well.19:28
*** su_zhang has quit IRC19:29
*** suresh12 has quit IRC19:30
*** code-R has joined #openstack-nova19:31
*** shaohe_feng has quit IRC19:31
*** shaohe_feng has joined #openstack-nova19:32
*** bwallis has quit IRC19:34
*** code-R has quit IRC19:36
*** bvanhav has quit IRC19:36
openstackgerritDan Smith proposed openstack/nova: Revert "Optional separate database for placement API"  https://review.openstack.org/36063819:36
*** jvgrant_ has joined #openstack-nova19:37
*** sdague has quit IRC19:39
*** sdague has joined #openstack-nova19:39
*** zul has quit IRC19:41
*** jvgrant has quit IRC19:41
*** shaohe_feng has quit IRC19:42
*** shaohe_feng has joined #openstack-nova19:44
*** ljxiash has quit IRC19:44
-openstackstatus- NOTICE: The Gerrit service on review.openstack.org is restarting to implement some performance tuning adjustments, and should return to working order momentarily.19:46
sdaguealaski: ok, so to make sure I'm not completely speaking out of turn, when do you expect multi cell cellv2 to be a thing?19:47
cdentare you happy with your changes dansmith? If so I'm going to leave IRC for the night and pretend openstack doesn't exist for a while. In the morning I'll check that patch and if it still unhappy, try to fix it, yeah?19:48
alaskisdague: I still think O is reasonable, at least for small numbers of cells19:48
*** jheroux has quit IRC19:48
alaskisdague: listing with sorting/filtering is the big unknown still19:48
sdagueok, good, that's what I said so far :)19:49
alaskiin terms of when we can get a solution integrated19:49
sdaguealso, any sketch forward for neutron being cells v2 aware?19:49
alaskithat mostly hinges on the resource provider work. neutron won't be directly cells aware it will be resource provider aware19:50
alaskiso you can aggregate hosts within a routed network, and those hosts may or may not fall within a cell boundary19:51
sdagueok19:51
*** jheroux has joined #openstack-nova19:51
*** shaohe_feng has quit IRC19:52
*** raunak has joined #openstack-nova19:54
*** zul has joined #openstack-nova19:54
*** shaohe_feng has joined #openstack-nova19:54
*** JasonF has joined #openstack-nova19:54
*** Apoorva has joined #openstack-nova19:56
dansmithcdent: I am if they pass yeah19:58
dansmithcdent: fine to come back to this tomorrow19:58
dansmithcdent: I'm traveling home tomorrow so will be less able to mess with it if you want to give it whatever care it needs, that would be good19:58
cdentdansmith: cool, will do19:59
dansmiththanks19:59
*** jheroux has quit IRC19:59
*** JayF has quit IRC20:00
bauzasalaski: just trying to see follow-ups on the cells v2 instance boot patches20:00
bauzasalaski: I guess https://review.openstack.org/#/c/356137/8 being the next one ?20:00
alaskiyep20:00
*** JasonF is now known as JayF20:00
bauzasalaski: are the 3 patches I can see needed for moving the instance.create() call within the conductor ?20:01
bauzasI mean the instance record creation20:02
*** suresh12 has joined #openstack-nova20:02
alaskiyes20:02
alaskiuntil the API can return results without an instance being present the creation can't move20:02
*** tonytan_brb is now known as tonytan4ever20:02
*** shaohe_feng has quit IRC20:02
bauzasokay, then...20:02
*** su_zhang has joined #openstack-nova20:03
*** sdake has quit IRC20:03
*** shaohe_feng has joined #openstack-nova20:03
bauzasalaski: I can't see the instance record creation move, is that something not yet implemented, I guess ?20:03
*** jheroux has joined #openstack-nova20:03
*** sdake has joined #openstack-nova20:04
alaskiit's an abandoned patch I need to restore. when I proposed it I realized I need to get all of this done first and it languished in that time20:04
alaskihttps://review.openstack.org/#/c/319379/20:05
*** cheran has joined #openstack-nova20:05
bauzasalaski: k, cool, just wanted to get the overall direction to make the same path in my mind too20:05
openstackgerritVu Tran proposed openstack/nova: libvirt: Enable instance resizing for LVM backed instances  https://review.openstack.org/36076420:08
alaskimelwitt: responded on https://review.openstack.org/#/c/35613720:09
melwittalaski: looking20:10
*** ducttape_ has quit IRC20:11
*** shaohe_feng has quit IRC20:12
*** shaohe_feng has joined #openstack-nova20:13
*** tbachman_ has joined #openstack-nova20:14
*** ducttape_ has joined #openstack-nova20:14
*** tbachman has quit IRC20:15
*** tbachman_ is now known as tbachman20:15
*** lamt has quit IRC20:15
*** vishwanathj has quit IRC20:19
*** vishwanathj has joined #openstack-nova20:20
*** lamt has joined #openstack-nova20:21
*** shaohe_feng has quit IRC20:23
*** shaohe_feng has joined #openstack-nova20:23
melwittalaski: I see it was my bad I lined up the wrong code. trying to wrap my head around this. do we really want it to behave exactly as it did? I wonder if the getattr was used simply to make it work being that it wants to do the same thing to each of ('metadata', 'system_metadata')20:24
*** vishwanathj has quit IRC20:28
*** vishwanathj has joined #openstack-nova20:29
*** su_zhang has quit IRC20:29
melwittalaski: let me spend a few more minutes. trying to trace what it means for get(..., None) to return None is confusing me20:29
*** sdake has quit IRC20:29
*** su_zhang has joined #openstack-nova20:29
openstackgerritDan Smith proposed openstack/nova: Revert "Optional separate database for placement API"  https://review.openstack.org/36063820:30
alaskimelwitt: my fear was that the old behavior allows matching None against an unset field. so a filter like {'migration_context': None}. I think that could potentially match something in the db query, but if we do 'if filter_key in instance...' would not match on the build_req side20:31
alaskiwhereas instance.get(..., None) would assume None for unset fields and could match20:32
melwittalaski: I see. I'm trying to work out the case of a None value, i.e. trying to match NULL in the db for the value, if this prevents that20:32
melwittor if there's a way it could mess it up20:33
*** shaohe_feng has quit IRC20:33
*** shaohe_feng has joined #openstack-nova20:33
melwittnon_existing_key=None, that would keep the instance20:35
*** sdake has joined #openstack-nova20:35
melwittbecause None == None20:35
melwittwhat is supposed to happen in that case?20:36
alaskigreat question20:36
alaskimy assumption was that in that case the db equivalent would be a default value of None20:36
alaskier, null20:37
alaskiwhich would also keep it20:37
melwittokay, let me re-look at the db api stuff real quick20:37
*** JoseMello has joined #openstack-nova20:38
*** zul has quit IRC20:38
*** gyee has joined #openstack-nova20:42
*** shaohe_feng has quit IRC20:43
*** shaohe_feng has joined #openstack-nova20:43
*** tbachman has quit IRC20:44
*** ljxiash has joined #openstack-nova20:45
*** tbachman has joined #openstack-nova20:46
*** salv-orlando has joined #openstack-nova20:46
openstackgerritDan Smith proposed openstack/nova: Revert "Optional separate database for placement API"  https://review.openstack.org/36063820:47
*** eharney has quit IRC20:49
*** ljxiash has quit IRC20:51
*** xinliang has quit IRC20:53
*** shaohe_feng has quit IRC20:53
*** kfarr has quit IRC20:54
*** shaohe_feng has joined #openstack-nova20:54
*** corey_ has quit IRC20:54
*** hoangcx has quit IRC20:55
*** sballe__ has joined #openstack-nova20:55
*** TravT has quit IRC20:55
*** sballe_ has quit IRC20:56
*** sballe__ is now known as sballe_20:56
*** eharney has joined #openstack-nova20:57
*** rlrossit_ has quit IRC20:57
*** rosmaita is now known as brianr-afk20:58
*** hoangcx has joined #openstack-nova20:59
*** rfolco_ has quit IRC21:02
*** rfolco_ has joined #openstack-nova21:03
*** rfolco_ has quit IRC21:03
*** shaohe_feng has quit IRC21:04
*** sdake_ has joined #openstack-nova21:05
*** shaohe_feng has joined #openstack-nova21:06
*** sdake has quit IRC21:08
*** thorst has quit IRC21:09
*** xinliang has joined #openstack-nova21:09
*** thorst has joined #openstack-nova21:12
*** kevinz has joined #openstack-nova21:12
*** shaohe_feng has quit IRC21:14
*** shaohe_feng has joined #openstack-nova21:15
*** vishwanathj has quit IRC21:16
*** thorst has quit IRC21:16
*** vishwanathj has joined #openstack-nova21:16
*** salv-orl_ has joined #openstack-nova21:17
*** kevinz has quit IRC21:17
*** sdague has quit IRC21:18
*** hoangcx has quit IRC21:19
*** salv-orlando has quit IRC21:19
*** sdake_ has quit IRC21:20
*** hoangcx has joined #openstack-nova21:21
*** sdake has joined #openstack-nova21:22
*** jichen has quit IRC21:24
*** shaohe_feng has quit IRC21:24
*** shaohe_feng has joined #openstack-nova21:25
*** brianr-afk is now known as rosmaita21:26
*** david-lyle has joined #openstack-nova21:26
*** vishwanathj has quit IRC21:26
*** vishwanathj has joined #openstack-nova21:27
*** david-lyle has quit IRC21:31
*** eharney has quit IRC21:32
*** shaohe_feng has quit IRC21:34
*** shaohe_feng has joined #openstack-nova21:35
*** jamesdenton has quit IRC21:40
*** pradk has quit IRC21:41
*** rtheis has quit IRC21:44
*** dimtruck is now known as zz_dimtruck21:44
*** shaohe_feng has quit IRC21:45
*** shaohe_feng has joined #openstack-nova21:45
*** tblakes has quit IRC21:47
*** shaohe_feng has quit IRC21:55
*** shaohe_feng has joined #openstack-nova21:57
*** gouthamr has quit IRC22:00
*** gouthamr has joined #openstack-nova22:00
*** gouthamr has quit IRC22:00
*** vishwanathj has quit IRC22:01
*** vishwanathj has joined #openstack-nova22:02
*** BjoernT has quit IRC22:03
*** burt has quit IRC22:04
*** shaohe_feng has quit IRC22:05
*** TravT has joined #openstack-nova22:05
*** shaohe_feng has joined #openstack-nova22:06
*** marst has quit IRC22:10
*** lpetrut has joined #openstack-nova22:12
*** tri2sing has quit IRC22:14
*** kaisers_ has quit IRC22:15
*** shaohe_feng has quit IRC22:15
*** lamt has quit IRC22:16
*** shaohe_feng has joined #openstack-nova22:16
*** vishwanathj has quit IRC22:17
*** vishwanathj has joined #openstack-nova22:18
*** vishwanathj has quit IRC22:23
*** sdake has quit IRC22:24
*** gouthamr has joined #openstack-nova22:25
*** ducttape_ has quit IRC22:25
*** jheroux has quit IRC22:26
*** shaohe_feng has quit IRC22:26
*** ducttape_ has joined #openstack-nova22:26
*** shaohe_feng has joined #openstack-nova22:26
*** ducttape_ has quit IRC22:30
*** tri2sing has joined #openstack-nova22:31
*** TravT has quit IRC22:33
*** salv-orl_ has quit IRC22:34
*** TravT has joined #openstack-nova22:35
*** shaohe_feng has quit IRC22:36
*** shaohe_feng has joined #openstack-nova22:37
*** sdake has joined #openstack-nova22:37
*** thorst has joined #openstack-nova22:42
*** shaohe_feng has quit IRC22:46
*** thorst has quit IRC22:47
*** cdent has quit IRC22:47
*** shaohe_feng has joined #openstack-nova22:47
*** thorst has joined #openstack-nova22:47
*** Apoorva has quit IRC22:50
*** shaohe_feng has quit IRC22:56
*** thorst has quit IRC22:56
*** shaohe_feng has joined #openstack-nova22:57
*** Apoorva has joined #openstack-nova22:59
*** gouthamr_ has joined #openstack-nova22:59
*** ducttape_ has joined #openstack-nova23:00
*** hemna is now known as hemnafk23:03
*** gouthamr has quit IRC23:03
*** suresh12 has quit IRC23:04
*** suresh12 has joined #openstack-nova23:05
*** suresh12 has quit IRC23:05
*** suresh12 has joined #openstack-nova23:06
*** shaohe_feng has quit IRC23:07
*** shaohe_feng has joined #openstack-nova23:08
*** ducttape_ has quit IRC23:08
*** lpetrut has quit IRC23:14
*** shaohe_feng has quit IRC23:17
*** hoangcx has quit IRC23:17
*** hoangcx has joined #openstack-nova23:18
*** shaohe_feng has joined #openstack-nova23:19
*** JoseMello has quit IRC23:20
*** ducttape_ has joined #openstack-nova23:23
*** nic has quit IRC23:25
*** yamahata has quit IRC23:25
*** TravT has quit IRC23:27
*** shaohe_feng has quit IRC23:27
*** shaohe_feng has joined #openstack-nova23:28
openstackgerritVincent Jardin proposed openstack/nova: libvirt: Fix hugepage support on PowerPC  https://review.openstack.org/36082223:33
*** ducttape_ has quit IRC23:33
*** whenry has joined #openstack-nova23:34
*** yamahata has joined #openstack-nova23:37
*** shaohe_feng has quit IRC23:37
*** shaohe_feng has joined #openstack-nova23:39
*** rrecio has quit IRC23:39
*** jianghuaw-m has quit IRC23:41
*** hoangcx2 has joined #openstack-nova23:42
*** hoangcx has quit IRC23:45
*** ducttape_ has joined #openstack-nova23:47
*** shaohe_feng has quit IRC23:48
*** shaohe_feng has joined #openstack-nova23:48
*** david-lyle has joined #openstack-nova23:52
*** xyang1 has quit IRC23:52
*** rcernin has quit IRC23:53
*** thorst has joined #openstack-nova23:54
*** shaohe_feng has quit IRC23:58
*** shaohe_feng has joined #openstack-nova23:59
*** woodster_ has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!