Wednesday, 2016-09-07

*** Swami has quit IRC00:01
*** mlavalle has quit IRC00:07
*** thorst has quit IRC00:08
*** thorst has joined #openstack-nova00:09
*** rrecio_ has quit IRC00:15
*** vladikr has quit IRC00:17
*** Apoorva has quit IRC00:17
*** thorst has quit IRC00:17
*** mmedvede has quit IRC00:19
*** yassou has quit IRC00:22
*** mingyu_ has joined #openstack-nova00:24
*** mriedem has quit IRC00:24
*** mriedem has joined #openstack-nova00:24
*** ducttape_ has joined #openstack-nova00:25
*** sdague has quit IRC00:26
*** mingyu has quit IRC00:26
*** hoangcx has joined #openstack-nova00:28
*** jamesdenton has joined #openstack-nova00:29
*** Apoorva has joined #openstack-nova00:30
*** Apoorva has quit IRC00:35
*** mingyu_ has quit IRC00:35
*** mingyu has joined #openstack-nova00:36
*** diogogmt has joined #openstack-nova00:37
*** mingyu has quit IRC00:37
*** kaisers has quit IRC00:42
*** kaisers has joined #openstack-nova00:43
*** jamesdenton has quit IRC00:43
*** Jeffrey4l has joined #openstack-nova00:47
*** rrecio has joined #openstack-nova00:49
*** felix23ma has joined #openstack-nova00:50
*** gjayavelu has quit IRC00:52
*** mmedvede has joined #openstack-nova00:54
*** Sukhdev has joined #openstack-nova00:56
*** rrecio has quit IRC00:56
*** hieulq has quit IRC01:00
*** hieulq has joined #openstack-nova01:00
*** annp has joined #openstack-nova01:01
*** Sukhdev has quit IRC01:01
*** annp has quit IRC01:01
*** pwnall1 has quit IRC01:03
*** ssurana has quit IRC01:03
*** rama_y has joined #openstack-nova01:08
*** gongysh has joined #openstack-nova01:12
*** phuongnh has joined #openstack-nova01:12
openstackgerritEli Qiao proposed openstack/nova: Libvirt: Correct PERF_EVENTS_CPU_FLAG_MAPPING  https://review.openstack.org/36584201:13
*** thorst has joined #openstack-nova01:14
*** thorst has quit IRC01:16
*** thorst has joined #openstack-nova01:16
*** wangqun has joined #openstack-nova01:19
*** kevinz has joined #openstack-nova01:22
*** annp has joined #openstack-nova01:22
*** felix23ma has quit IRC01:22
*** browne has quit IRC01:22
*** nic has quit IRC01:27
*** jamesdenton has joined #openstack-nova01:29
*** amotoki has joined #openstack-nova01:29
*** lixiaoy1 has joined #openstack-nova01:30
*** thorst has quit IRC01:32
*** amotoki has quit IRC01:33
*** raunak has joined #openstack-nova01:35
*** raunak has quit IRC01:40
*** felix23ma has joined #openstack-nova01:40
*** ljxiash has joined #openstack-nova01:41
*** baoli has joined #openstack-nova01:43
*** liuyulong|away is now known as liuyulong01:43
*** yamahata has quit IRC01:44
*** ljxiash has quit IRC01:45
*** amotoki has joined #openstack-nova01:46
openstackgerritJianghua Wang proposed openstack/nova: XenAPI: resolve the fetch_bandwidth failure  https://review.openstack.org/36583801:50
*** liangy has quit IRC01:54
*** EinstCrazy has joined #openstack-nova01:55
*** ducttape_ has quit IRC01:57
*** ijw has joined #openstack-nova01:58
*** EinstCrazy has quit IRC01:58
*** ijw has quit IRC01:58
*** ljxiash has joined #openstack-nova01:59
*** ijw has joined #openstack-nova01:59
*** ljxiash has quit IRC01:59
*** ducttape_ has joined #openstack-nova01:59
*** ljxiash has joined #openstack-nova01:59
*** EinstCrazy has joined #openstack-nova02:03
*** amotoki has quit IRC02:05
*** ijw has quit IRC02:09
*** unicell has quit IRC02:14
*** mriedem has quit IRC02:17
*** amotoki has joined #openstack-nova02:20
*** baoli has quit IRC02:21
*** priteau has joined #openstack-nova02:22
*** akshai has joined #openstack-nova02:23
*** thorst has joined #openstack-nova02:24
*** baoli has joined #openstack-nova02:26
*** felix23ma has quit IRC02:26
*** priteau has quit IRC02:27
*** felix23ma has joined #openstack-nova02:28
*** amotoki has quit IRC02:28
*** hoangcx has quit IRC02:29
*** thorst has quit IRC02:29
*** salv-orlando has joined #openstack-nova02:30
*** akshai has quit IRC02:30
*** felix23ma has quit IRC02:31
*** salv-orl_ has quit IRC02:33
*** felix23ma has joined #openstack-nova02:34
*** baoli has quit IRC02:35
*** amotoki has joined #openstack-nova02:41
*** akshai has joined #openstack-nova02:42
*** thorst has joined #openstack-nova02:48
*** thorst has quit IRC02:48
*** tjones has left #openstack-nova02:48
*** amotoki has quit IRC02:48
*** thorst has joined #openstack-nova02:48
*** dimtruck is now known as zz_dimtruck02:50
*** shangxdy has joined #openstack-nova02:53
*** hoangcx has joined #openstack-nova02:53
*** mingyu has joined #openstack-nova02:53
*** vishwanathj has quit IRC02:54
*** jamesdenton has quit IRC02:58
*** ljxiash has quit IRC03:02
*** mingyu has quit IRC03:02
*** jogo has joined #openstack-nova03:03
*** tongli has quit IRC03:03
*** ljxiash has joined #openstack-nova03:04
*** mingyu has joined #openstack-nova03:05
*** ducttape_ has quit IRC03:05
*** felix23ma has quit IRC03:06
*** felix23ma has joined #openstack-nova03:08
openstackgerritjaveme proposed openstack/nova: server_group_members quota exceeded silently  https://review.openstack.org/33725103:10
*** Guest42361 has joined #openstack-nova03:17
Guest42361hi03:17
*** Guest42361 has quit IRC03:19
*** Guest42361 has joined #openstack-nova03:19
*** tbachman has quit IRC03:22
*** felix23ma has quit IRC03:25
*** ducttape_ has joined #openstack-nova03:26
*** ljxiash_ has joined #openstack-nova03:26
*** ljxiash has quit IRC03:27
*** wuhg has joined #openstack-nova03:31
*** Apoorva has joined #openstack-nova03:32
*** sdake_ has joined #openstack-nova03:32
*** sdake has quit IRC03:35
*** gouthamr has quit IRC03:37
*** Apoorva has quit IRC03:37
openstackgerritZhenyu Zheng proposed openstack/nova-specs: Add support for tag instances when boot  https://review.openstack.org/36646903:38
*** ducttape_ has quit IRC03:39
*** fragatin_ has joined #openstack-nova03:44
*** gouthamr has joined #openstack-nova03:45
*** links has joined #openstack-nova03:45
*** fragatin_ has quit IRC03:46
*** fragatina has quit IRC03:46
*** ljxiash_ has quit IRC03:48
*** ljxiash has joined #openstack-nova03:49
*** coolsvap_ has joined #openstack-nova03:50
*** fragatina has joined #openstack-nova03:53
*** ljxiash has quit IRC03:53
*** markvoelker has quit IRC03:54
*** felix23ma has joined #openstack-nova03:56
*** fragatina has quit IRC03:57
*** shangxdy has quit IRC04:00
*** rdo_ has quit IRC04:07
*** mingyu has quit IRC04:09
*** ljxiash has joined #openstack-nova04:11
*** unicell has joined #openstack-nova04:11
*** rama_y has quit IRC04:12
*** ManishD has joined #openstack-nova04:18
*** unicell1 has joined #openstack-nova04:20
*** unicell has quit IRC04:20
*** amotoki has joined #openstack-nova04:20
*** gouthamr has quit IRC04:21
*** ljxiash has quit IRC04:23
*** ljxiash has joined #openstack-nova04:23
*** ManishD has quit IRC04:24
*** akshai has quit IRC04:27
*** ljxiash has quit IRC04:27
*** stevemar has quit IRC04:28
*** lixiaoy1 has quit IRC04:30
*** 17WAAKU0S has joined #openstack-nova04:37
*** 17WAAKU0S has quit IRC04:38
*** mingyu has joined #openstack-nova04:40
*** thorst has quit IRC04:43
*** thorst has joined #openstack-nova04:45
*** akshai has joined #openstack-nova04:48
*** thorst has quit IRC04:50
*** bkopilov_ has joined #openstack-nova04:50
*** prateek has joined #openstack-nova04:55
*** markvoelker has joined #openstack-nova04:55
*** thorst has joined #openstack-nova04:56
*** markvoelker has quit IRC04:59
*** thorst has quit IRC05:00
*** Jeffrey4l_ has joined #openstack-nova05:00
*** mingyu has quit IRC05:02
*** claudiub has joined #openstack-nova05:03
*** Jeffrey4l has quit IRC05:04
*** claudiub|2 has joined #openstack-nova05:05
*** mamandle has joined #openstack-nova05:05
*** claudiub has quit IRC05:09
*** moshele has joined #openstack-nova05:09
*** tonytan_brb has quit IRC05:09
*** ljxiash has joined #openstack-nova05:10
*** yamahata has joined #openstack-nova05:11
*** jaosorior has joined #openstack-nova05:12
openstackgerrithuan proposed openstack/nova: xenapi: support the hotplug of a neutron port  https://review.openstack.org/36550505:14
openstackgerritPrateek Arora proposed openstack/nova: Handle ConnectFailure from keystone when neutron is down  https://review.openstack.org/32770605:17
*** harlowja_at_home has joined #openstack-nova05:18
*** openstackgerrit has quit IRC05:18
*** mingyu has joined #openstack-nova05:18
*** openstackgerrit has joined #openstack-nova05:19
*** hoangcx has quit IRC05:20
*** akshai has quit IRC05:24
*** hoangcx has joined #openstack-nova05:25
*** thorst has joined #openstack-nova05:28
*** akshai has joined #openstack-nova05:29
*** Sukhdev has joined #openstack-nova05:29
*** thorst has quit IRC05:29
*** EinstCrazy has quit IRC05:30
*** EinstCrazy has joined #openstack-nova05:31
*** thorst has joined #openstack-nova05:32
*** ratailor has joined #openstack-nova05:34
*** mingyu has quit IRC05:36
*** unicell has joined #openstack-nova05:38
*** unicell1 has quit IRC05:38
*** akshai has quit IRC05:39
*** ducttape_ has joined #openstack-nova05:39
*** wuhg has quit IRC05:41
*** ducttape_ has quit IRC05:43
*** bhagyashri has joined #openstack-nova05:46
*** sdake_ is now known as sdake05:46
*** ekuris has joined #openstack-nova05:47
*** lixiaoy1 has joined #openstack-nova05:47
*** raunak has joined #openstack-nova05:49
*** Sukhdev has quit IRC05:51
*** Apoorva has joined #openstack-nova05:52
*** harlowja_at_home has quit IRC05:54
*** mingyu has joined #openstack-nova05:56
*** Apoorva has quit IRC05:56
*** mingyu has quit IRC05:58
*** mjura has joined #openstack-nova06:01
*** nkrinner_afk is now known as nkrinner06:03
*** ManishD has joined #openstack-nova06:03
*** paul-carlton2 has joined #openstack-nova06:04
*** stevemar has joined #openstack-nova06:06
*** EinstCrazy has quit IRC06:06
*** EinstCrazy has joined #openstack-nova06:10
*** tonytan4ever has joined #openstack-nova06:10
*** stevemar has quit IRC06:11
*** ttrumm has joined #openstack-nova06:12
*** tonytan4ever has quit IRC06:15
*** sahid has joined #openstack-nova06:15
*** kevinz has quit IRC06:16
*** sdake has quit IRC06:18
*** oanson has joined #openstack-nova06:18
*** shangxdy has joined #openstack-nova06:22
*** kevinz has joined #openstack-nova06:25
*** thorst has quit IRC06:26
slaweq__amotoki: hello06:27
slaweq__thx for Your fixes in https://review.openstack.org/#/c/358344/6/api-ref/source/v2/quotas.inc@4406:27
slaweq__should I change this order of parameters there also?06:27
slaweq__or it will be done in this "another patch" about what You wrote there?06:27
*** edand has joined #openstack-nova06:28
*** thorst has joined #openstack-nova06:28
*** thorst has quit IRC06:28
*** ttrumm_ has joined #openstack-nova06:30
*** praneshp has quit IRC06:30
amotokislaweq__: wrong channel? this is #-nova06:31
prateeksahid, can you please have a look at https://review.openstack.org/#/c/327706/, i have made the changes as per yesterday's comments06:31
*** ttrumm has quit IRC06:32
slaweq__amotoki: sorry06:32
*** zenoway has joined #openstack-nova06:33
slaweq__my fault :)06:33
amotokislaweq__: np. let's move to -neutron06:33
slaweq__amotoki: ok06:33
*** hussain_c has quit IRC06:33
*** raunak has quit IRC06:33
*** lixiaoy1 has quit IRC06:34
*** pcaruana has joined #openstack-nova06:34
*** edand has quit IRC06:35
*** lixiaoy1 has joined #openstack-nova06:39
*** ducttape_ has joined #openstack-nova06:40
*** sticker has quit IRC06:42
*** stevemar has joined #openstack-nova06:44
*** ducttape_ has quit IRC06:45
*** lpetrut has joined #openstack-nova06:48
*** andreas_s has joined #openstack-nova06:54
*** EinstCrazy has quit IRC06:54
*** mamandle_ has joined #openstack-nova06:55
*** markvoelker has joined #openstack-nova06:56
*** mamandle has quit IRC06:56
*** mamandle_ is now known as mamandle06:57
*** devananda|travel has quit IRC07:00
*** thorst has joined #openstack-nova07:00
*** markvoelker has quit IRC07:01
openstackgerritEli Qiao proposed openstack/nova: Libvirt: Correct PERF_EVENTS_CPU_FLAG_MAPPING  https://review.openstack.org/36584207:01
*** tesseract- has joined #openstack-nova07:02
*** EinstCrazy has joined #openstack-nova07:03
*** sdake has joined #openstack-nova07:03
*** thorst has quit IRC07:06
*** garyk1 has joined #openstack-nova07:07
openstackgerritHussain Chachuliya proposed openstack/nova: Log warning for negative config option value  https://review.openstack.org/36653507:08
*** markus_z has joined #openstack-nova07:08
garyk1with latest code when i spin up a instance with kvm i get message on the console 'atkbd serio0: Use 'setkeycodes'…' Any idea what may be causing this?07:12
garyk1mdbooth: ^07:14
*** matrohon has joined #openstack-nova07:16
*** avolkov has quit IRC07:18
*** mamandle_ has joined #openstack-nova07:21
*** hshiina has joined #openstack-nova07:22
*** trisq has joined #openstack-nova07:23
*** mamandle has quit IRC07:24
*** mamandle_ is now known as mamandle07:24
*** EinstCrazy has quit IRC07:27
*** slaweq__ has quit IRC07:31
*** armax has quit IRC07:31
*** paul-carlton2 has quit IRC07:34
*** abalutoiu has joined #openstack-nova07:35
*** thorst has joined #openstack-nova07:36
*** thorst has quit IRC07:36
*** EinstCrazy has joined #openstack-nova07:36
*** lpetrut has quit IRC07:38
*** woodster_ has quit IRC07:39
*** avolkov has joined #openstack-nova07:40
*** ducttape_ has joined #openstack-nova07:41
*** ducttape_ has quit IRC07:45
*** tonytan4ever has joined #openstack-nova07:47
*** mamandle has quit IRC07:49
*** tonytan4ever has quit IRC07:52
*** lpetrut has joined #openstack-nova07:52
*** ihrachys has joined #openstack-nova07:52
*** roeyc has joined #openstack-nova07:53
*** garyk1 has quit IRC07:58
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-nova08:00
*** moshele has quit IRC08:01
*** moshele has joined #openstack-nova08:01
*** thorst has joined #openstack-nova08:01
*** EinstCrazy has quit IRC08:03
*** lixiaoy1 has quit IRC08:04
*** lixiaoy1 has joined #openstack-nova08:04
*** mvk has quit IRC08:07
*** stevemar_ has joined #openstack-nova08:07
*** mvk has joined #openstack-nova08:08
*** yassine has joined #openstack-nova08:08
*** yassine is now known as Guest1037908:09
*** mamandle has joined #openstack-nova08:09
*** thorst_ has joined #openstack-nova08:10
*** thorst__ has joined #openstack-nova08:10
*** stevemar_ has quit IRC08:12
*** EinstCrazy has joined #openstack-nova08:12
*** thorst has quit IRC08:12
*** thorst_ has quit IRC08:14
*** lpetrut has quit IRC08:16
*** cdent has joined #openstack-nova08:16
*** hieulq has quit IRC08:19
*** annp has quit IRC08:19
*** annp has joined #openstack-nova08:19
*** hieulq has joined #openstack-nova08:19
*** lucas-dinner is now known as lucasagomes08:22
*** ttrumm_ has quit IRC08:22
*** rdo_ has joined #openstack-nova08:25
*** priteau has joined #openstack-nova08:27
*** liverpooler has joined #openstack-nova08:29
*** salv-orl_ has joined #openstack-nova08:29
*** thorst__ has quit IRC08:32
*** danpb has joined #openstack-nova08:32
*** salv-orlando has quit IRC08:32
*** claudiub has joined #openstack-nova08:32
*** Guest42361 has quit IRC08:33
*** openstackgerrit has quit IRC08:34
*** EinstCra_ has joined #openstack-nova08:34
*** openstackgerrit has joined #openstack-nova08:34
*** thorst has joined #openstack-nova08:34
*** thorst has quit IRC08:35
*** claudiub|2 has quit IRC08:35
*** ihrachys has quit IRC08:36
*** EinstCrazy has quit IRC08:37
*** derekh has joined #openstack-nova08:40
*** ttrumm has joined #openstack-nova08:44
*** lpetrut has joined #openstack-nova08:44
*** ftersin has quit IRC08:44
*** sudipto has joined #openstack-nova08:45
*** garyk1 has joined #openstack-nova08:45
*** sudipto_ has joined #openstack-nova08:45
*** thorst has joined #openstack-nova08:46
*** hshiina has quit IRC08:47
*** thorst has quit IRC08:49
*** paul-carlton2 has joined #openstack-nova08:51
*** diga has joined #openstack-nova08:52
*** karthiks has quit IRC08:53
*** ratailor has quit IRC08:53
*** links has quit IRC08:53
*** ratailor has joined #openstack-nova08:54
*** prateek has quit IRC08:54
*** priteau has quit IRC08:55
*** EinstCra_ has quit IRC08:55
*** links has joined #openstack-nova08:55
*** karthiks has joined #openstack-nova08:55
*** prateek has joined #openstack-nova08:55
*** EinstCrazy has joined #openstack-nova08:56
*** markvoelker has joined #openstack-nova08:57
*** lixiaoy1 has quit IRC08:58
openstackgerritChris Dent proposed openstack/nova: Add {get_,set_}aggregates to objects.ResourceProvider  https://review.openstack.org/35526308:58
openstackgerritChris Dent proposed openstack/nova: Implement get and set aggregates in the placement API  https://review.openstack.org/35799308:58
openstackgerritChris Dent proposed openstack/nova: [placement] add a placement_aggregates table to api_db  https://review.openstack.org/36286308:58
prateekcdent, can you please take a look at https://review.openstack.org/#/c/327706/ when you have some free time ?09:01
*** markvoelker has quit IRC09:01
cdentyup, will open up a tab with it now, just finishing up some placement api stuff first09:02
*** code-R has joined #openstack-nova09:02
*** mamandle has quit IRC09:02
prateekcdent, thanks09:02
*** mamandle has joined #openstack-nova09:03
*** code-R_ has joined #openstack-nova09:05
mdboothcdent: Hey, I was thinking about that bug from last night. I think that query is complex enough to have its own unit tests, which is probably the best way to get useful, deterministic tests.09:05
cdentmdbooth: I think we're all still wondering about that09:06
mdboothIncidentally, I haven't work on db stuff in nova for a bit. It's great to see we're finally freeing it from the db.sqlalchemy.api cage. Much easier to read in context.09:06
cdentnobody was able to replicate failure locally09:06
cdentyeah, a decision was made that new objects in the API db would not be tied to that old way, and the placement stuff is following that pattern09:07
*** code-R has quit IRC09:08
cdentI agree that a unit test would be useful, but I think people are working at two not necessarily collaborating goals: get something working and released; understanding what's going on and having proper tests09:08
*** stevemar_ has joined #openstack-nova09:08
cdentif you've followed some of the changes that happened since (our) yesterday evening, there were some tests added but I'm not sure they actually test anything other than confirming that local runs of tests don't show the problem (on the old code)09:09
cdentmdbooth: so, to sum: If you've got some ideas they are _very_ welcome09:09
mdboothLike I was saying last night, I think a problem that you're going to hit in writing a test of the whole method is that the failure is going to be non-deterministic09:10
mdboothBecause it depends on the returned row order09:10
mdboothBut if you test the query separately, you can isolate the failure09:11
mdboothDeterministically isolate it, that is09:11
mdboothBecause you can specifically check that the result is as expected for the input, including testing for duplicate rows09:11
*** mvk has quit IRC09:12
*** stevemar_ has quit IRC09:13
cdentyeah, agree, but what I'm saying is that locally we have been unable to generate the multiple rows: we've not figured out the correct inputs to do so. which means we don't actually understand the problem09:13
*** ihrachys has joined #openstack-nova09:19
*** yamahata has quit IRC09:21
*** moshele has quit IRC09:21
*** moshele has joined #openstack-nova09:21
cdentto some extent the fact that we've identified "oh, it didn't work because of an oversight in the creation of the sql" and we've fixed that is perhaps enough. It's just weird that we had had tests that got the right results with the wrong sql.09:21
cdentbut because we've been rushing around there hasn't been clear heads to really investigate it properly09:21
*** moshele has quit IRC09:23
*** moshele has joined #openstack-nova09:24
sfinucanmoshele: Say, are VFs managed by nova or neutron? I forget where the line is09:24
openstackgerritMatthew Booth proposed openstack/nova: imagecache: Hold shared storage registry lock while running  https://review.openstack.org/36623909:26
*** ihrachys has quit IRC09:26
moshelesfinucan: it depends nova (libvirt) put the mac and vlan  https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L304-L32109:26
sfinucanmoshele: So they both mess with it?09:27
moshelesfinucan: neutron side control the admin_state port_secuirty and qos09:27
moshelesfinucan: yes09:27
*** ManishD has quit IRC09:30
openstackgerritDao Cong Tien proposed openstack/nova: Stop using mox in unit/virt/xenapi/test_vmops.py (1)  https://review.openstack.org/34400009:33
sfinucanI ask because I'd like to know if this is possible https://review.openstack.org/#/c/342001/4/specs/newton/approved/nova-api-sriov-pcipt-stats.rst09:33
sfinucannamely, is it possible for nova to have an inventory of available vs. used PCI devices as things stand?09:33
sfinucanmoshele: ^09:33
*** wznoinsk has quit IRC09:35
prateekcdent, regarding your latest comment on the patch https://review.openstack.org/#/c/327706/09:35
cdentprateek: yes?09:35
prateeki didn't plan to write the test initially but asked in the community and someone told me that it would need an api test to be written like this09:36
*** tuanla_ has joined #openstack-nova09:36
prateekcdent, i can look around a bit to find out what exactly the test does09:36
*** EinstCrazy has quit IRC09:37
cdentprateek: Do you remember my original comment about it not actually testing anything?09:37
prateekcdent, yes :)09:37
prateekand i still think that the test and 4 test above that written exactly same way can be done away with09:38
cdentMaybe another review can come along and clarify the situation there. Maybe alex_xu or sdague will have an opinion. from my standpoint the test is useless.09:38
cdentyeah09:38
cdentweird :)09:38
prateek    def test_resource_not_authorized(self):09:38
prateek        class Controller(object):09:38
prateek            def index(self, req):09:38
prateek                raise exception.Unauthorized()09:38
prateek        req = webob.Request.blank('/tests')09:38
prateek        app = fakes.TestRouter(Controller())09:38
prateek        self.assertRaises(09:38
prateek            exception.Unauthorized, req.get_response, app)09:38
prateek    def test_connection_failed(self):09:39
prateek        class Controller(object):09:39
prateek            def index(self, req):09:39
prateek                raise exception.NeutronConnectionFailed()09:39
prateek        req = webob.Request.blank('/tests')09:39
prateek        app = fakes.TestRouter(Controller())09:39
prateek        self.assertRaises(09:39
prateek            exception.NeutronConnectionFailed, req.get_response, app)09:39
prateekone i have written and one is written by sahid09:39
*** EinstCrazy has joined #openstack-nova09:39
prateeksahid, can you please help me and cdent understand how this work ?09:39
openstackgerritZhenyu Zheng proposed openstack/nova-specs: Add support for tag instances when boot  https://review.openstack.org/36646909:39
*** roeyc has quit IRC09:41
*** mvk has joined #openstack-nova09:41
*** danpawlik1 has left #openstack-nova09:41
openstackgerritDao Cong Tien proposed openstack/nova: Stop using mox in compute/test_hypervisors.py  https://review.openstack.org/32681409:42
sahidprateek: I think what we wnat here is to ensure that the excpetion raised by controller is not going to be translated in error 50009:43
sahidlet me try to add comment in the review09:44
*** abalutoiu_ has joined #openstack-nova09:45
cdentprateek: for future ref: when you want to send that many lines you should use http://paste.openstack.org/09:45
prateeksahid, thanks for adding the comment, can you help me out a bit in understanding that, in the test_wsgi method, we pass app to req.get_response which has a controller which raises NeutronConnectionFailed , so how did we hit the API ?09:47
openstackgerritDao Cong Tien proposed openstack/nova: Stop using mox in virt/xenapi/image/test_glance.py  https://review.openstack.org/32745709:47
*** sdake has quit IRC09:47
prateekcdent, ok, would take care from next time09:47
*** abalutoiu has quit IRC09:48
*** wuhg has joined #openstack-nova09:49
prateeksahid, so i guess what i understand from your comment is we intentionally raise that exception and pass that to the API method we have given whether we are able to get back that exception from API09:50
prateeksahid, is that correct ?09:50
*** gszasz has joined #openstack-nova09:51
sahidyeah i'm not totally sure of your question, pehraps i can try to give to you some pointer into the code09:51
alex_xuprateek: sahid , the exception translation is for v2 API, which we should clear up. For v2.1 API, we have decorator expected_error, it will turn all the non HTTP* exception to 500. so I agree with cdent, that test is useless09:51
sahidbut what we want is juste to create a route which are going to be execute and so pass throught the api which normally translate any unreconzable exception to a 50009:52
openstackgerritDao Cong Tien proposed openstack/nova: Stop using mox in virt/libvirt/test_driver.py (1)  https://review.openstack.org/32807009:52
sahidbecause you have added a new catch for NeutronConnectionFailed, it shoud to pass there and return the 50409:52
sahids/shoud to/should09:52
prateeksahid, i get it now , thanks09:53
openstackgerritDao Cong Tien proposed openstack/nova: Stop using mox in api/openstack/fakes.py  https://review.openstack.org/32575909:54
*** gszasz has quit IRC09:56
alex_xuWe need clear up the code for v2 stuff. And we should have test ensure it will return 500. That will be another patch. And after that, I think we won't test all the exception, ensure they will be return as 50009:56
*** gszasz has joined #openstack-nova09:57
*** markvoelker has joined #openstack-nova09:57
* alex_xu leave an hour09:57
*** hoonetorg has quit IRC09:58
prateekalex_xu, so shall we keep the test in the current commit and do the cleanup for review later or cleaning up should start now itself ?09:58
*** gszasz has quit IRC09:59
*** thorst has joined #openstack-nova10:00
*** markvoelker has quit IRC10:02
*** thorst has quit IRC10:04
*** ihrachys has joined #openstack-nova10:05
*** ttrumm has quit IRC10:06
*** mamandle has quit IRC10:07
*** annp has quit IRC10:10
*** mamandle has joined #openstack-nova10:11
*** liuyulong is now known as liuyulong|away10:11
*** phuongnh has quit IRC10:11
*** hoangcx has quit IRC10:13
*** gszasz has joined #openstack-nova10:13
*** suxiang has joined #openstack-nova10:15
*** tbachman has joined #openstack-nova10:17
openstackgerritChris Dent proposed openstack/nova: [placement] don't write existing equivalent allocations  https://review.openstack.org/36506910:17
*** ftersin has joined #openstack-nova10:20
*** ttrumm has joined #openstack-nova10:22
*** zenoway has quit IRC10:23
openstackgerritMatthew Booth proposed openstack/nova: libvirt: Only check migration_flags for post-copy  https://review.openstack.org/36665910:24
bauzasouch, 12 newton-rc-potential bugs, that's probably too much10:25
*** akijak has joined #openstack-nova10:25
openstackgerritAlberto Planas proposed openstack/nova: Add migrate_uri for invoking the migration  https://review.openstack.org/35655810:27
*** roeyc has joined #openstack-nova10:27
akijakhi, I'd like to allow a normal user to do 'nova show' for any tenant. Is is possible for recent releases?10:28
openstackgerritChris Dent proposed openstack/nova: [placement] don't write existing equivalent allocations  https://review.openstack.org/36506910:28
openstackgerritChris Dent proposed openstack/nova: More conservative inventory updates  https://review.openstack.org/36507310:29
openstackgerritChris Dent proposed openstack/nova: [placement] Correct serialization of inventory collections  https://review.openstack.org/36563310:29
*** ttrumm has quit IRC10:30
sfinucanakijak: see the channel message. That's a question for #openstack10:30
openstackgerritChris Dent proposed openstack/nova: [placement] Correct serialization of inventory collections  https://review.openstack.org/36563310:31
akijaksfinucan: I'm sorry. Thanks10:31
openstackgerritChris Dent proposed openstack/nova: [placement] Clarify commentary around logging trap  https://review.openstack.org/36571910:32
*** akijak has left #openstack-nova10:32
openstackgerritChris Dent proposed openstack/nova: [placement] Add additional allocation tests  https://review.openstack.org/36614410:32
*** ljxiash has quit IRC10:34
*** ttrumm has joined #openstack-nova10:34
*** tbachman has quit IRC10:35
*** sdague has joined #openstack-nova10:37
*** bsv has joined #openstack-nova10:37
garyk1mdbooth: around?10:37
mdboothgaryk1: I am indeed! How's it going?10:38
*** akijak has joined #openstack-nova10:38
garyk1mdbooth: alls good thanks. maybe you can help here. i am running libvirt latest and greatest driver. when i spin up an instance each keystroke via vnc has the following error:  'atkbd serio0: Use 'setkeycodes'…' Any idea what may be causing this?10:38
openstackgerritChris Dent proposed openstack/nova: [placement] Add additional allocation tests  https://review.openstack.org/36614410:38
garyk1that is, each keystroke this happens. its with all of the cirros images10:39
mdboothgaryk1: Qemu/vnc is a complete mystery to me, I'm afraid. danpb ^^^ ?10:39
garyk1mdbooth: ok, thanks. danpb any idea?10:39
*** ljxiash has joined #openstack-nova10:40
*** akijak has left #openstack-nova10:40
*** sdague has quit IRC10:41
*** trisq has quit IRC10:44
*** ljxiash has quit IRC10:44
*** dgonzalez has quit IRC10:45
danpbmdbooth: garyk1 that's not going to be anything todo with qemu/vnc really -that simply looks like a guest OS setup issue10:46
*** sdague has joined #openstack-nova10:46
mdboothhttps://bugzilla.redhat.com/show_bug.cgi?id=86823710:46
openstackbugzilla.redhat.com bug 868237 in spice-gtk "spice-gtk sends 00 scancodes to inputs_scancode capable vms" [Unspecified,Closed: errata] - Assigned to marcandre.lureau10:46
mdbooth^^^ Has similar error messages10:47
mdboothLooks like it was a client issue in that case.10:47
mdboothSpice client in that case.10:47
mdboothIs it possible the vnc client is sending unexpected things?10:47
*** thorst has joined #openstack-nova10:48
*** thorst has quit IRC10:48
danpbdepends what the full error message is - garyk1 truncated it in the example above10:48
*** shangxdy has quit IRC10:48
mdboothgaryk1: Are you seeing 'atkbd serio0: Unknown key pressed...'?10:49
mdboothWould be just before the message above10:49
danpbthat spice bug is specifically about sending scancodes with value of 0, not unknown scancodes in general10:50
garyk1danpb: mdbooth: the message is Use 'setkeycodes 00 <keycode>' to make it known10:50
mdboothgaryk1: What comes before it?10:51
garyk1this is afetr Unkbown key pressed (translated set 2, code 0x0…)10:51
garyk1its for every key that is pressed10:51
*** PaulMurray has joined #openstack-nova10:51
mdboothdanpb: So that does look like the client is sending a 00 keycode, right?10:51
garyk1danpb: mdbooth: code 0x0 on isa0060/serio010:51
openstackgerritStephen Finucane proposed openstack/nova-specs: Proposal for standardizing hardware NIC capabilities  https://review.openstack.org/34134110:51
openstackgerritStephen Finucane proposed openstack/nova-specs: Standardize capabilities using Enums  https://review.openstack.org/30976210:51
mdboothgaryk1: I'm going to go out on a limb and guess it might be an issue in then vnc client.10:52
garyk1ok. thanks10:53
*** ttrumm_ has joined #openstack-nova10:54
*** dikonoor has joined #openstack-nova10:55
*** dgonzalez has joined #openstack-nova10:57
*** ttrumm has quit IRC10:57
*** rtheis has joined #openstack-nova10:57
*** ljxiash has joined #openstack-nova11:03
*** GB21 has joined #openstack-nova11:05
*** dikonoor has quit IRC11:05
*** slagle has joined #openstack-nova11:06
*** amotoki has quit IRC11:06
*** ljxiash has quit IRC11:07
*** wangqun has quit IRC11:08
*** stevemar_ has joined #openstack-nova11:09
*** zerda2 has quit IRC11:09
openstackgerritChris Dent proposed openstack/nova: [placement] Correct serialization of inventory collections  https://review.openstack.org/36563311:10
openstackgerritChris Dent proposed openstack/nova: [placement] Add additional allocation tests  https://review.openstack.org/36614411:10
openstackgerritChris Dent proposed openstack/nova: [placement] Allow inventory to violate allocations  https://review.openstack.org/36506811:10
openstackgerritChris Dent proposed openstack/nova: [placement] don't write existing equivalent allocations  https://review.openstack.org/36506911:10
openstackgerritChris Dent proposed openstack/nova: More conservative inventory updates  https://review.openstack.org/36507311:10
openstackgerritChris Dent proposed openstack/nova: [placement] Clarify commentary around logging trap  https://review.openstack.org/36571911:10
openstackgerritGhanshyam Mann proposed openstack/nova: Example & Parameter verification of os-security-group-default-rules.inc  https://review.openstack.org/36668111:10
*** tuanla_ has quit IRC11:11
*** gmann has quit IRC11:13
*** stevemar_ has quit IRC11:13
*** paul-carlton has joined #openstack-nova11:13
*** dikonoor has joined #openstack-nova11:15
*** sahid has quit IRC11:16
*** baoli has joined #openstack-nova11:17
*** lucasagomes is now known as lucas-hungry11:20
mdboothdanpb: In the live migration meeting yesterday, you mentioned that the libvirt driver is already handling events generated by libvirt. I see the loop in guest.get_job_info() which polls, but from your description I was expecting something asynchronous.11:20
mdboothHave I missed something?11:20
mdboothSorry, the loop is in _live_migration_monitor()11:21
mdboothIt polls guest.get_job_info()11:21
*** ttrumm_ has quit IRC11:23
mdboothdansmith: Are you awake, yet?11:24
*** mfedosin has joined #openstack-nova11:26
*** gongysh has quit IRC11:26
*** rtheis_ has joined #openstack-nova11:29
openstackgerritRikimaru Honjo proposed openstack/nova: Add checks for preventing unexpected detaching volume  https://review.openstack.org/35461711:30
*** rtheis has quit IRC11:30
*** ttrumm has joined #openstack-nova11:33
kashyapmdbooth: It's 04:30 AM in Portland :-)11:36
mdboothkashyap: Slackers.11:36
*** amotoki has joined #openstack-nova11:37
*** cdelatte has joined #openstack-nova11:38
*** ttrumm has quit IRC11:38
*** sudipto has quit IRC11:39
*** sudipto_ has quit IRC11:39
*** ttrumm has joined #openstack-nova11:40
*** cdent has quit IRC11:41
*** tonytan4ever has joined #openstack-nova11:49
*** amotoki has quit IRC11:50
*** salv-orl_ has quit IRC11:52
*** salv-orlando has joined #openstack-nova11:52
*** tonytan4ever has quit IRC11:53
*** baoli_ has joined #openstack-nova11:54
*** PaulMurray has quit IRC11:55
*** eandersson has joined #openstack-nova11:57
*** jaypipes has joined #openstack-nova11:57
*** baoli has quit IRC11:57
*** amotoki has joined #openstack-nova11:58
*** markvoelker has joined #openstack-nova11:58
*** coolsvap_ is now known as coolsvap12:01
*** markvoelker has quit IRC12:03
mdboothkashyap: Can you remind me how, when I'm logged in to a host, to jump onto a guest network?12:04
*** sean-k-mooney has quit IRC12:04
*** links has quit IRC12:04
mdboothSome invocation to change the network namespace of the shell, right?12:04
*** sahid has joined #openstack-nova12:05
* kashyap is parsing mdbooth's first sentence12:05
kashyapWhat do you mean "jump onto a guest network"?12:05
mdboothI want to ping an instance which is using neutron12:05
*** acabot has quit IRC12:05
kashyapAh, Neutron is involved here12:05
kashyapmdbooth: You're asking `ip netns exec` commands I guess12:06
mdboothAh!12:06
*** devananda has joined #openstack-nova12:06
kashyapThere should be two of them:12:06
mdboothThat should be enough :)12:06
*** praveen has joined #openstack-nova12:06
kashyap$ ip netns12:06
kashyapShould show12:06
mdboothI know which man pages to read now12:06
*** devananda is now known as devananda|travel12:06
* mdbooth was looking at 'net'12:06
*** amotoki has quit IRC12:07
*** acabot has joined #openstack-nova12:07
kashyapip netns exec qrouter-$UUID ping [...]12:07
mdboothkashyap: Thanks! My first attempt is failing, but I'll debug for a bit and maybe get back.12:09
kashyapSure12:09
*** stevemar_ has joined #openstack-nova12:10
*** cdent has joined #openstack-nova12:10
praveenHi can someone point me the timings for spec discussion? I wanted to propose a change into nova.. The change is very small not sure if that requires a spec/blueprint or Can directly fix as a defect..12:12
kashyapmdbooth: I'm sure you must've already checked, but if you're using DevStack, ensure you have the security group rules.  I run this silly script as part of my DevStack setup -- https://kashyapc.fedorapeople.org/virt/openstack/Neutron-setup-post-DevStack.bash12:14
mdboothkashyap: I have, of course, not done that12:14
kashyap:-)12:14
* mdbooth gets on it12:14
*** stevemar_ has quit IRC12:14
*** ducttape_ has joined #openstack-nova12:16
*** links has joined #openstack-nova12:16
openstackgerritAndrey Volkov proposed openstack/nova: WIP Move instance creation to conductor  https://review.openstack.org/31937912:17
*** ducttape_ has quit IRC12:18
*** pradk has joined #openstack-nova12:18
*** ducttape_ has joined #openstack-nova12:18
openstackgerritChris Dent proposed openstack/nova: Optional separate database for placement API  https://review.openstack.org/36276612:20
*** EinstCrazy has quit IRC12:21
*** tongli has joined #openstack-nova12:22
*** Hazelesque_ is now known as Hazelesque12:22
*** PaulMurray has joined #openstack-nova12:22
*** hoonetorg has joined #openstack-nova12:23
*** lucas-hungry is now known as lucasagomes12:23
markus_zdanpb: If time permits, would you take a look at this regression fix please? https://review.openstack.org/#/c/335132/12:23
*** gongysh has joined #openstack-nova12:24
openstackgerritAlexis Lee proposed openstack/nova: Reorder scheduler options  https://review.openstack.org/35008512:27
openstackgerritAlexis Lee proposed openstack/nova: Group scheduler options  https://review.openstack.org/34995912:27
mdboothIs there any reason I would not be able to connect to the vnc port of a local qemu process?12:27
mdboothdomain xml has port='5900' autoport='yes' listen='127.0.0.1'12:27
mdboothtelnet to localhost 5900 is refused12:27
*** liverpooler has quit IRC12:28
mdboothAh, nm. Was still in network namespace :)12:28
*** karthiks has quit IRC12:31
*** liangy has joined #openstack-nova12:31
*** mingyu has joined #openstack-nova12:31
* cdent misses the days of simple networking12:31
openstackgerritRoman Podoliaka proposed openstack/nova: block_device: fix propagation of instance AZ to Cinder  https://review.openstack.org/36672412:31
openstackgerritGhanshyam Mann proposed openstack/nova: Example & Parameter verification of os-security-group-default-rules.inc  https://review.openstack.org/36668112:31
*** edmondsw has joined #openstack-nova12:31
openstackgerritChangBo Guo(gcb) proposed openstack/nova: Remove deprecated configuration option network_device_mtu  https://review.openstack.org/31954312:31
*** markvoelker has joined #openstack-nova12:32
*** ducttape_ has quit IRC12:33
mdboothkashyap: Imagine for a second that I know little of neutron. It'll be a stretch, but try anyway.12:33
kashyapLet's try12:33
mdboothMy guest is failing to get an ip via dhcp. Where should I look first? Environment is devstack.12:33
*** amotoki has joined #openstack-nova12:33
*** trisq has joined #openstack-nova12:34
kashyapmdbooth: What do you in the guest serial console log?12:35
mdboothWhen I originally logged in there was no ip address on eth012:35
mdboothso I manually did 'ifup eth0'12:35
mdboothIt does 'Sending discover...' for a bit12:35
mdboothThen dies with 'No lease, failing'12:36
*** mmedvede has quit IRC12:36
mdboothAh... could this be because it's on the 'public' network?12:37
kashyapAh12:37
kashyap$ ip netns exec qdhcp-$UUID ip a12:37
kashyap^ What does that say?12:37
mdbooth10.1.0.2/2412:38
mdboothAnd the guest is on 172.x.x.x12:38
kashyapmdbooth: Can you run this https://raw.githubusercontent.com/larsks/neutron-diag/master/gather-network-info12:38
kashyapIt just collects Neutron networking info12:38
mdboothI trust you, man12:39
mdboothI'm just gonna run it :)12:39
*** diga has quit IRC12:40
*** praveen has left #openstack-nova12:42
*** woodster_ has joined #openstack-nova12:42
kashyapThere are actually two diagnostics scripts:12:43
kashyap https://github.com/larsks/neutron-diag12:43
mdboothkashyap: Sorted. The instance wasn't on the subnet with dhcp.12:43
kashyapAh-ha12:43
mdboothI now have networking :)12:43
mdboothkashyap: Thank you, sir!12:43
kashyapI didn't help much :-)12:43
mdboothWell I didn't have any idea what to poke until you told me :)12:44
mdboothwoot, I have 2 instances which can ping each other :) Revolutionary.12:45
kashyapExcellent12:45
mdboothI literally don't think I've ever done that before.12:45
*** karthiks has joined #openstack-nova12:45
kashyapIf I'm in a hurry w/o floating IP, I just SSH via the namespace $ sudo ip netns exec qdhcp-$UUID ssh cirros@10.1.0.812:46
* mdbooth is just connecting directly to the vnc port12:46
*** vladikr has joined #openstack-nova12:47
*** pradk has quit IRC12:47
paul-carlton2William18.,.12:47
cdentjaypipes: responded to your -2 on https://review.openstack.org/#/c/365069/12:47
*** MVenesio has joined #openstack-nova12:47
*** MVenesio has quit IRC12:47
*** mgoddard_ has joined #openstack-nova12:48
*** slaweq_ has joined #openstack-nova12:49
slaweq_hello, can I ask someone from Nova core reviewers to check https://review.openstack.org/#/c/363926/ ?12:49
slaweq_thx in advance12:49
*** jaosorior has quit IRC12:49
sdaguecdent / jaypipes with the placement job using the placement api optionally, I wonder if there is some way to figure out that it's working in the tempest test run besides looking at logs12:50
*** jaosorior has joined #openstack-nova12:50
alex_xunova api meeting is in 10 mins at #openstack-meeting-412:51
cdentsdague: does it make any sense to either: a) add a simple tempest test that gets a list of resource providers or something b) add a post test hook that does a curl doing the same thing?12:51
*** tblakes has joined #openstack-nova12:51
*** wuhg has quit IRC12:51
*** mgoddard has quit IRC12:52
*** GB21 has quit IRC12:56
rpodolyakahi all! would appreciate a second core review on https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1606496, if someone has a minute12:57
*** thorst has joined #openstack-nova12:57
edleafecdent: sdague: jaypipes: Sorry I wasn't available much yesterday; lots of non-OpenStack stuff to handle. Good work on identifying the SQL bug.12:58
edleafeWhere can I dive in today?12:58
*** gmann has joined #openstack-nova12:58
*** mdrabe has joined #openstack-nova12:59
*** syjulian_ has joined #openstack-nova13:00
cdentedleafe: I posted a bit of a status update to os-dev this morning which points to the main chunk of code under review. And then if you search for stuff owned by me there's a fair few minor fixups for buglets.13:00
cdentI suspec the most important thing to be doing now is making it go and seeing what happens13:00
*** roeyc has quit IRC13:00
*** claudiub|2 has joined #openstack-nova13:00
alex_xunova api meeting is running13:01
edleafecdent: ok, thanks. So is it multiple RPs or multiple consumers that are needed to see the problem?13:01
openstackgerritSean Dague proposed openstack/nova: Additional logging for placement API  https://review.openstack.org/36618613:01
*** jwcroppe has joined #openstack-nova13:01
*** mmedvede has joined #openstack-nova13:02
cdentedleafe: "problem" should be fixed, but we've never been too clear on the combination of inputs to make it go because we couldn't make it happen in local tests, only in "real" runs. but basically: multiple resource providers, each with multiple (three) classes of resources, with > 1 allocation13:03
*** claudiub has quit IRC13:03
edleafecdent: I see. That will be fun to set up locally.13:03
bauzascdent: tbh, the most important thing for now is to remember we're in a RC period13:04
bauzascdent: which means most of us should look at bugfixes and bug reports13:04
cdentbauzas: all the placement stuff is bugs and bugfixes13:05
bauzascdent: but they are not regressions13:05
*** garyk1 has quit IRC13:06
bauzasif I eat all my time to look at the placement changes, then I couldn't help others wanting to fix regressions13:06
sdaguecdent: for the reproduce it was 1 rp, > 1 resource classes, and > 1 consumer (so there can be allocations that won't be deleted when a new allocation comes in)13:06
cdentbauzas: it doesn't work well enough yet and we committed to making writing inventory and allocations work and be scrutable enough to make work. That's going to mean adding more code, now.13:06
bauzasand we also have 43 new bugs, and 14 rc possible changes13:06
*** pilgrimstack1 has joined #openstack-nova13:06
sdaguewhich also explains why it was only happening some times in tests13:07
*** gongysh has quit IRC13:07
*** pilgrimstack has quit IRC13:07
sdaguebecause you needed 2 vms up at once to expose it13:07
bauzascdent: okay, it's your opinion, I prefer to look at Launchpad13:07
*** PaulMurray has quit IRC13:07
cdentplease do bauzas13:08
*** roeyc has joined #openstack-nova13:08
edleafesdague: for tests can we add some dummy consumer records?13:08
sdagueedleafe: there is a test now13:08
edleafesdague: ah, good - still catching up13:08
cdentyeah, edleafe I think the problem is sorted mostly well enough now13:08
sdaguehttps://review.openstack.org/#/c/366245/8/nova/tests/functional/db/test_resource_provider.py13:09
edleafesdague: awesome13:09
bhagyashridansmith: Hi, could you please review https://review.openstack.org/#/c/345191/ ?13:10
*** stevemar_ has joined #openstack-nova13:10
*** andrey-mp has joined #openstack-nova13:11
*** vishwanathj has joined #openstack-nova13:11
*** links has quit IRC13:12
openstackgerritSam Betts proposed openstack/nova: [WIP] Support Ironic interface attach/detach in nova virt  https://review.openstack.org/36441313:13
*** xyang1 has joined #openstack-nova13:13
*** stevemar_ has quit IRC13:15
*** PaulMurray has joined #openstack-nova13:17
andrey-mpbauzas: what do you think - when you can finish this: https://review.openstack.org/#/c/365740/  development is stuck in EC2-API due to this. is it possible to fix it or maybe its simplier to revert something first?13:17
bauzasandrey-mp: on it13:17
*** mingyu has quit IRC13:17
bauzasandrey-mp: I did a bit of triage this morning, but I'm now full speed on writing a new PS for  the above13:18
*** ducttape_ has joined #openstack-nova13:18
*** mingyu has joined #openstack-nova13:18
*** hoangcx has joined #openstack-nova13:19
andrey-mpbauzas: ok, thank you!13:19
*** ratailor has quit IRC13:19
*** gmann_ has joined #openstack-nova13:19
*** gmann_ has quit IRC13:19
*** ducttape_ has quit IRC13:20
*** su_zhang has joined #openstack-nova13:21
*** oanson has quit IRC13:21
*** hemanthm|away is now known as hemanthm13:21
*** mingyu has quit IRC13:22
syjulian_gibi: hey gibi do you have a moment?13:25
*** SS-SP has joined #openstack-nova13:26
*** tonytan4ever has joined #openstack-nova13:26
*** SS-SP has quit IRC13:26
*** SS-SP has joined #openstack-nova13:28
*** jamesdenton has joined #openstack-nova13:28
SS-SPHi All,13:28
SS-SPwe have an issue13:28
*** karthiks has quit IRC13:28
SS-SPWhen we try to boot a VM, multiple Ip's are assigning to it and the VM is going to error state13:29
SS-SPcan anyone help us13:29
*** efried has quit IRC13:29
SS-SPwith the error message:13:29
SS-SP| {"message": "Exceeded maximum number of retries. Exceeded max scheduling attempts 3 for instance a8b953a3-85c4-46b2-a0bd-dd312c1d36fa. Last exception: 500 Internal Server Error: The server has either erred or is incapable of performing the requested operation. (HTTP 5", "code": 500, "details": "  File \"/usr/lib/python2.7/dist-packages/nova/conductor/manager.py\", line 393, in build_instances | |13:30
*** mgoddard_ has quit IRC13:30
*** mgoddard has joined #openstack-nova13:30
gibisyjulian_: on a meeting right now, I will ping you in about an hour13:30
*** kfarr has joined #openstack-nova13:31
*** wangqun has joined #openstack-nova13:31
*** adisky has quit IRC13:31
*** tbachman has joined #openstack-nova13:33
*** syjulian_ has quit IRC13:34
*** bsv has quit IRC13:34
*** hamzy has quit IRC13:34
openstackgerritPrateek Arora proposed openstack/nova: Handle ConnectFailure from keystone when neutron is down  https://review.openstack.org/32770613:35
*** sudipto_ has joined #openstack-nova13:35
*** sudipto has joined #openstack-nova13:35
*** ttrumm has quit IRC13:35
andrey-mpSS-SP: do you have a bigger stack?13:35
*** syjulian_ has joined #openstack-nova13:36
*** ttrumm has joined #openstack-nova13:36
prateekalex_xu, I have made the changes as per your comments on https://review.openstack.org/#/c/327706/, can you please take a look ?13:38
syjulian_gibi: ok cool13:38
*** tbachman has quit IRC13:39
*** tbachman has joined #openstack-nova13:39
SS-SP<andrey-mp> we used flavor with memory:512 disk:1 vcpu:113:40
*** mriedem has joined #openstack-nova13:40
prateekcdent, https://review.openstack.org/#/c/327706/ the test problem has been fixed , if you can just have a look now ?13:41
*** ttrumm has quit IRC13:41
prateekmriedem, sahid has reviewed and approved https://review.openstack.org/#/c/327706/, can you please take a look now ?13:41
andrey-mpSS-SP: i mean stack trace of an error13:41
*** annegentle has joined #openstack-nova13:42
*** hoangcx has quit IRC13:42
*** gmann has quit IRC13:42
*** krtaylor has joined #openstack-nova13:42
mdboothdanpb: Can you recommend a simple way to put memory stress on a guest running a cirros image?13:43
*** takedakn has joined #openstack-nova13:44
mdboothMy plan was to try to get 'stress' working on one13:44
mdboothBut if there's a simple hack I can use to dirty lots of memory continuously that would be awesome13:44
SS-SP<andrey-mp>We didnt get any error log in nova-api.log13:44
danpbmdbooth: imho just biuld your own initrd containing a custom init.c that does yuour stress13:44
dansmithcdent: are you working on addressing this? https://review.openstack.org/#/c/365068/713:44
SS-SPbut in nova show:13:45
mdboothdanpb: Yes, I was thinking less effort than that :)13:45
bhagyashrimikal: Hi, could you please review  https://review.openstack.org/#/c/346026/ ?13:45
*** hoangcx has joined #openstack-nova13:45
SS-SP{"message": "Exceeded maximum number of retries. Exceeded max scheduling attempts 3 for instance 91f31b5d-4e40-4dd4-853a-7bfc62e5789e. Last exception: 500 Internal Server Error: The server has either erred or is incapable of performing the requested operation. (HTTP 5", "code": 500, "details": "  File \"/usr/lib/python2.7/dist-packages/nova/conductor/manager.py\", line 393, in build_instances | |13:45
danpbmdbooth: you can steal my stress code if you want  http://git.qemu.org/?p=qemu.git;a=blob;f=tests/migration/stress.c;hb=HEAD13:45
*** karthiks has joined #openstack-nova13:45
mdboothdanpb: Awesome, thanks13:45
cdentdansmith: no I'm in the midst of writing GET /resource_providers/{uuid}/allocations because jaypipes says we need that13:45
*** ducttape_ has joined #openstack-nova13:45
dansmithcdent: sounds familiar :)13:45
danpbmdbooth: with that stress program migration will never complete unless using post-copy, or throttling by >=95%13:46
cdentdansmith: ikr13:46
mdboothdanpb: Does it work out how much ram the guest has?13:46
* cdent shrugs13:46
*** eharney has joined #openstack-nova13:46
dansmithcdent: okay, the log warning is probably too small to justify having to rebase your thing so can you just throw a warning into the bottom patch when you submit?13:46
mdboothdanpb: tbh, I just need to force post-copy to be used. My idle cirros instance doesn't touch it.13:46
dansmithjust needs to be a single line change I think13:46
danpbmdbooth: it takes ramsize=GB  on kernel command line13:47
sdaguedansmith: well, we need to bring back a chunk of the code right?13:47
fricklerSS-SP: getting multiple IPs is a known issue: https://bugs.launchpad.net/nova/+bug/1597596 but that doesn't explain why your instance gets rescheduled in the first place13:47
openstackLaunchpad bug 1597596 in OpenStack Compute (nova) "network not always cleaned up when spawning VMs" [Medium,In progress] - Assigned to Aihua Edward Li (aihuaedwardli)13:47
cdentyeah, dansmith sdague is right13:47
sdaguehttps://review.openstack.org/#/c/365068/7/nova/objects/resource_provider.py13:47
cdentwe removed the detector13:47
mdboothdanpb: I'll be compiling my own anyway, so I can hack that :)13:47
mdboothThanks13:47
sdaguewhich would also be needed for jay's wanted follow on notification13:47
sdaguecdent: if you are fine with that, I can respin that13:47
cdentdansmith: if you can do that, I can make your your GET13:47
dansmithcdent: sdague: ah, I'm squashing two things.. the notification and this, yah.. was thinking that part got done13:47
cdentor sdague13:47
dansmithsdague: I'm also happy to do it, but whatever you want13:48
*** prateek has quit IRC13:48
mdboothdansmith: Got a minute to talk about the post-copy networking thing and rpc?13:48
sdaguedansmith: if you want to run with it, it's all yours13:48
dansmithsdague: okay13:48
dansmithmdbooth: not really, but you can talk and I can smile-n-nod if you want :D13:48
andrey-mpSS-SP: ok, maybe it's another bug... I meant this - https://bugs.launchpad.net/nova/+bug/162024813:49
openstackLaunchpad bug 1620248 in OpenStack Compute (nova) "Can't rename instance right after creation (regression)" [High,In progress] - Assigned to Sylvain Bauza (sylvain-bauza)13:49
mdboothdansmith: Don't tell me that's what you normally do13:49
* mdbooth tries anyway13:49
dansmithheh13:49
*** ljxiash has joined #openstack-nova13:49
mdboothdansmith: So, looking at the stuff which needs to happen at the point the migration source decides to kick off post-copy, it's all remote calls already13:50
mdboothall done via network_api13:50
mdboothSo, there's code which currently runs on the source, and code which currently runs on the dest13:50
mdboothIIUC, we can just move all of that to the source, because it'll call out to the dest anyway, so we're good13:50
mdboothAnyway, there's still an issue13:51
mdboothcomputemanager.post_live_migration_at_destination() does a bunch of networky stuff, called via rpc13:51
SS-SP<andrey-mp>ok..But Why its trying to assign multiple ip's(from same ip Address range)13:51
mdboothWe need to tell it to not do that if we already did13:51
dansmithmdbooth: yeah13:52
mdboothThe existing arguments to it don't obviously allow that13:52
mdboothAnd as it's remote, we really need to know in advance if it can even be told not to do it13:52
mdboothOtherwise we basically don't support post-copy to that destination13:52
andrey-mpSS-SP: sorry, I don't know ) i thought that this is an issue with updating server right after creation13:53
mdboothdansmith: Not sure how to approach that.13:53
*** annegent_ has joined #openstack-nova13:53
*** pradk has joined #openstack-nova13:53
dansmithmdbooth: don't we have a pre-migration call that gets made to both the source and destination?13:54
danpbmdbooth: moving code from method on the source, to method on the dest is going to cause you pain with upgrades13:54
danpbmdbooth: because you'll have source running old code, and dest running new code, and so both will contain the same logic13:55
dansmithso the destination needs to say definitively if it supports it or not, and then we treat the absence of that as a no13:55
*** efried has joined #openstack-nova13:55
mdboothdanpb: Yeah, that's what I'm looking for guidance on.13:55
danpbmdbooth: i'd not touch that existing  logic at all13:55
danpbmdbooth: basically we just need hooks in the virt driver to trigger callback in the compute manager to run13:56
mdboothdansmith: Will look into that, thanks.13:56
danpb        self.network_api.setup_networks_on_host(context, instance, prev_host, teardown=True)13:56
danpb        self.network_api.setup_networks_on_host(context, instance, self.host)13:56
danpbon the source + dest, when post-copy switches over13:56
mdboothdanpb: Yeah, and migration_instance_Start() and migration_instance_finish()13:56
mdboothThat's all fine13:57
mdboothThe problem is that compute manager will still subsequently call post_live_migration_at_destination()13:57
danpbso you shouldn't need to change anything about RPC layer afaict13:57
*** rcernin has joined #openstack-nova13:57
*** annegentle has quit IRC13:57
mdboothAnd that method does all the networky things that we just did13:57
mdboothSo we need to be able to tell it that we already did it13:57
*** zenoway has joined #openstack-nova13:57
mdboothWe can't not call it, because it also does other stuff13:57
danpbis it not possible to make setup_networks_on_host() into a no-op if it detects the work is already done13:58
mdboothIt's already a no-op in neutron, no?13:59
mdboothMaybe not13:59
mdboothAnyway, I didn't want to go there, tbh13:59
mdboothI wanted to keep the same network calls with the same semantics13:59
mdboothJust call them at the right times13:59
mdboothdansmith: So, I don't think we can do that (info back from pre_live_migration)14:00
*** anush has joined #openstack-nova14:00
dansmithmdbooth: that's the point of that call, right?14:00
mdboothWell, maybe we can, but we'd still require an rpc change to post_live_migration_at_destination()14:00
mdboothbecause it doesn't take migrate_data as an argument14:01
dansmithsure14:01
mdboothIt really don't have an obviously fudgable argument14:01
*** wangqun has quit IRC14:01
mdboothdoesn't14:01
*** ducttape_ has quit IRC14:02
*** mlavalle has joined #openstack-nova14:02
mdboothdansmith: So, making an rpc change to post_live_migration_at_destination() is fine (albeit a pita)14:03
dansmithmdbooth: of course14:03
mdboothHowever, I'd need to know way before I called it what version it supports14:03
mdboothIs that achievable?14:03
dansmithmdbooth: rpcapi knows, and can either fail the call or adjust the call/return based on the version yes14:03
*** ayoung has quit IRC14:03
*** mamandle has quit IRC14:04
mdboothdansmith: Right, but I'd need to know that *before* the call14:04
dansmithmdbooth: so you could make it fail the call with some known exception and you retry it with something different14:04
dansmithmdbooth: how far before/14:04
danpbthe RPC version cap should be sufficient i'd think14:04
mdboothdansmith: Right at the start of the live migration14:04
*** liverpooler has joined #openstack-nova14:04
dansmithmdbooth: you could also use SERVICE_VERSION to do this detection, and just refuse to do these kinds of migrations unless everything is upgraded14:04
mdboothPerhaps14:04
mdbooth...14:05
danpbeg, check if the version cap >= the desired version14:05
mdboothdanpb: Can you do that against an arbitrary target nova compute?14:05
dansmithmdbooth: you could use the pre calls to signal to the caller very early, right?14:05
*** zul_ has joined #openstack-nova14:05
mdboothdansmith: Ok, so make 2 rpc changes? Assume that if pre_live_migration returns the data I need, then post also supports it14:06
bauzasalaski: not sure I got your comment on https://review.openstack.org/#/c/365740/3/nova/compute/api.py@242114:06
danpbmdbooth: the RPC version cap is cloud-wide14:06
dansmithmdbooth: right14:06
bauzasalaski: that instance update is done within a contextmanager, I can't really move that out from the conditional14:06
*** rodrigods has quit IRC14:06
*** rodrigods has joined #openstack-nova14:06
mdboothdanpb: That might be simpler. Is that the SERVICE_VERSION thing dansmith mentioned?14:06
bauzasalaski: unless you meant I should use a nested private helper I could call that would just do that14:07
dansmithmdbooth: no14:07
dansmithmdbooth: the rpc cap and the service version are somewhat related but different things14:08
*** marst has quit IRC14:08
dansmithmdbooth: but seriously, I think the right thing to do is have the pre calls return the sentinel about whether it's supported or not14:08
mdboothOk, thanks.14:08
* mdbooth still needs to cause post-copy migrate to occur in his test environment14:09
*** prateek has joined #openstack-nova14:09
* mdbooth compiles danpb's stress bomb14:09
dansmithsdague: so at one point, logging inside of db_api was a no-no because it can cause us to switch threads while we hold DB locks.. I'm not sure where that landed with the facade stuff, but it seems like that should still be off limits.. do you know?14:10
*** READ10 has joined #openstack-nova14:11
sdaguedansmith: I don't14:11
dansmithzzzeek: jaypipes ^ do you know? I thought any time we're in a writer and have touched stuff that we're holding a transaction open, right? logging that could hit syslog via socket would be bad, yes?14:12
dansmithI'm thinking back to neutron having a lot of deadlocks over this kind of thing14:12
sdaguedansmith: was that before we switched mysql drivers?14:12
*** ajo_ has joined #openstack-nova14:12
jaypipesdansmith: that was something to do with real threads IIRC, right?14:13
dansmithsdague: yes, but not sure that matters.14:13
dansmithjaypipes: no, not the logging thing14:13
jaypipeshmmm, /me thinks back...14:13
dansmithjaypipes: if I do a thing that grabs a lock on some table, then I switch out to do a log, which causes me to run another thread that goes to update the same table, it waits14:13
*** GB21 has joined #openstack-nova14:14
dansmithalthough maybe with the new backend and not real threads I would switch again when I go to wait and not deadlock? I dunno14:14
dansmithwe have LOG statements in our db api, but they're few and in places that used to be outside transactions before the facade work, AFAIK14:14
cdentdansmith: Isn't that concern just in eventlet situations? and there shouldn't be any eventlet in the placement api (although some may have leaked in)14:15
dansmithsdague: I was planning to return info about exceeded RPs up the stack until we're back out of all the writers and then log it there, but was just making sure I wasn't overcomplicating things14:15
jaypipesdansmith: those log statements are outside the transaction boundary. if you are referring to the log statements I had originally included in the _inventory_changed() method?14:15
dansmithcdent: that's a fair point, but this in the object code which can technically be called from anywhere14:15
dansmithjaypipes: no I'm talking about what sdague wants, which is a log deep in the inner methods, which are @db_writers14:16
*** BjoernT has joined #openstack-nova14:16
cdentdansmith: yeah, just putting it out there in case we want to change that lack-of-restriction14:16
dansmithjaypipes: same goes for your firing of a notification though14:16
jaypipesgotcha14:16
dansmithcdent: yeah, well, you can do that when you're separate and can't be called from eventlet code :)14:16
cdent:)14:16
dansmithregardless,14:16
dansmithwe probably don't want to fire a notification from inside a @db_writer anyway I think,14:17
cdentoh yeah, notifications will blow all that out14:17
dansmithso might as well do this the return method I think14:17
*** diogogmt has quit IRC14:17
*** hoangcx has quit IRC14:17
*** tri2sing has joined #openstack-nova14:18
sdaguedansmith: so how about do that check, set a var, return the exception at the end of the block if we exceeded it14:19
sdaguethen just handle the logging in the exception handler14:19
alaskibauzas: instance.update is essentially a dict update, it's not doing anything that requires the context manager.14:19
dansmithsdague: we need to handle the case where multiple RPs are over cap, so I'm just making a list of info and returning that14:19
bauzasalaski: oh I see, fair point14:19
dansmithsdague: we don't want to raise anywhere because we don't want to abort the transaction14:19
sdaguedansmith: oh, right any raise will roll us back14:20
dansmithyup14:20
*** hoangcx has joined #openstack-nova14:20
*** zul_ has quit IRC14:20
*** zenoway has quit IRC14:20
*** pradk has quit IRC14:20
*** eandersson has quit IRC14:20
*** salv-orlando has quit IRC14:20
*** gszasz has quit IRC14:20
*** andrey-mp has quit IRC14:20
*** danpb has quit IRC14:20
*** bkopilov has quit IRC14:20
*** mirrorbo1 has quit IRC14:20
*** jgrassler has quit IRC14:20
*** hehx has quit IRC14:20
*** dulek has quit IRC14:20
*** lennyb has quit IRC14:20
*** cfriesen has quit IRC14:20
*** kswiatek has quit IRC14:20
*** darrenc has quit IRC14:20
*** tpatzig_ has quit IRC14:20
*** gstepanov__ has quit IRC14:20
*** raj_singh has quit IRC14:20
*** anteaya has quit IRC14:20
*** niedbalski has quit IRC14:20
*** eliqiao has quit IRC14:20
*** ejat has quit IRC14:20
*** TravT has joined #openstack-nova14:20
markus_zPaulMurray: FYI: I checked the live-migration with serial console patches again locally, and they passed: https://review.openstack.org/#/c/275801/14:20
*** TravT has quit IRC14:20
markus_zPaulMurray: Would be cool to get the merged for RC14:20
*** su_zhang has quit IRC14:20
*** su_zhang has joined #openstack-nova14:21
*** TravT has joined #openstack-nova14:22
*** TravT has quit IRC14:22
*** TravT has joined #openstack-nova14:23
gibisyjulian_: now I'm available14:23
*** marst has joined #openstack-nova14:23
*** syjulian_ has quit IRC14:24
*** tblakes has quit IRC14:24
pumaranikarmriedem, can you please review this https://review.openstack.org/#/c/365181/14:25
*** pradk has joined #openstack-nova14:25
*** su_zhang has quit IRC14:26
*** yamahata has joined #openstack-nova14:27
*** felix23ma has quit IRC14:27
mriedempumaranikar: i don't think we want to make that change in newton at this point, with 1.5 weeks to RC114:28
openstackgerritMJWurtz proposed openstack/nova: Refresh info_cache after deleting floating IP  https://review.openstack.org/35749414:29
*** lucasagomes is now known as lucas-afk14:29
*** salv-orlando has joined #openstack-nova14:30
*** EinstCrazy has joined #openstack-nova14:30
*** mdrabe has quit IRC14:30
openstackgerritChris Dent proposed openstack/nova: [placement] add GET /resource_providers/{uuid}/allocations  https://review.openstack.org/36678914:31
cdentjaypipes, dansmith: that's ^ a first stab at getting allocations, needs some commentary on response format and any desired tweaks (presumably in some contexts the results could get very long?)14:31
*** syjulian_ has joined #openstack-nova14:32
cmartinCould I get somebody to review this possibly? https://review.openstack.org/#/c/364337/14:32
*** sudipto_ has quit IRC14:32
*** sudipto has quit IRC14:32
dansmithcdent: so, um, _set_inventory() doesn't seem to actually replace inventory for things we already have.. certainly I'm wrong about that right?14:33
cdentugh14:33
dansmithcdent: it seems to only look for new classes added or removed, but14:33
*** annegent_ has quit IRC14:33
dansmither, wait, maybe the & of the two sets is "things that are in both old and new, to be updated" ?14:34
cdentso what it is supposed to do is figure out add, delete, update14:34
cdentand then do each separately14:34
dansmithah, nm, I had a typo14:34
* cdent schwews14:34
*** dikonoor has quit IRC14:35
*** markus_z has quit IRC14:35
cdentdansmith: I need to take an air break, but if we can sync up when I get back so I can know where to put some energy that would be awesome.14:35
pumaranikarmriedem, agree. One query on your comment. Do I need to include schema change in the same patch ? I thought we do schema change in the release after model changes.14:35
mriedempumaranikar: they would go together14:35
cdenthaving us all in and out of the same stack has my brain going ow14:35
mriedemthere is no point in the model change w/o the schema change, that would just be confusing14:35
pumaranikarmriedem, ok i can add that to same patch the. thanks14:36
pumaranikar*then14:36
*** cdent has quit IRC14:37
openstackgerritDan Smith proposed openstack/nova: [placement] Allow inventory to violate allocations  https://review.openstack.org/36506814:38
dansmithsee if that looks good ^ ... brbr14:38
*** GB21 has quit IRC14:39
*** eandersson has joined #openstack-nova14:39
*** ducttape_ has joined #openstack-nova14:39
*** kfarr has quit IRC14:40
*** rfolco has joined #openstack-nova14:40
*** jdurgin1 has joined #openstack-nova14:40
*** zenoway has joined #openstack-nova14:40
*** salv-orlando has quit IRC14:40
*** tblakes has joined #openstack-nova14:41
*** zul_ has joined #openstack-nova14:42
*** andrey-mp has joined #openstack-nova14:42
*** danpb has joined #openstack-nova14:42
*** bkopilov has joined #openstack-nova14:42
*** mirrorbo1 has joined #openstack-nova14:42
*** hehx has joined #openstack-nova14:42
*** dulek has joined #openstack-nova14:42
*** lennyb has joined #openstack-nova14:42
*** cfriesen has joined #openstack-nova14:42
*** kswiatek has joined #openstack-nova14:42
*** darrenc has joined #openstack-nova14:42
*** tpatzig_ has joined #openstack-nova14:42
*** gstepanov__ has joined #openstack-nova14:42
*** raj_singh has joined #openstack-nova14:42
*** anteaya has joined #openstack-nova14:42
*** niedbalski has joined #openstack-nova14:42
*** eliqiao has joined #openstack-nova14:42
*** ejat has joined #openstack-nova14:42
edleafecdent: suggestion: use set1.intersection(set2) instead of set1 & set2 - it's much less confusing to readers14:42
*** zz_dimtruck is now known as dimtruck14:42
*** hoonetorg has quit IRC14:43
*** jgrassler has joined #openstack-nova14:44
*** zenoway has quit IRC14:45
*** Swami has joined #openstack-nova14:45
*** mdrabe has joined #openstack-nova14:46
*** hamzy has joined #openstack-nova14:46
*** Swami_ has joined #openstack-nova14:46
*** ekuris has quit IRC14:46
*** takedakn has quit IRC14:47
*** ayoung has joined #openstack-nova14:48
*** takedakn has joined #openstack-nova14:48
*** hoangcx has quit IRC14:48
*** gszasz has joined #openstack-nova14:49
jaypipesdansmith: just finishing up cdent review and will re-review your after.14:49
jaypipes(oh, and another meeting...)14:49
*** moshele has quit IRC14:49
*** takedakn has quit IRC14:50
*** Swami has quit IRC14:50
*** kevinz has quit IRC14:50
openstackgerritSwaminathan Vasudevan proposed openstack/nova: Implement setup_networks_on_host for Neutron networks  https://review.openstack.org/27507314:50
dansmithjaypipes: I can only assume you're banking up meetings in case of some apocalyptic scenario where suddenly meetings are in demand and you have a large supply14:52
openstackgerritAlexis Lee proposed openstack/nova: Group scheduler options  https://review.openstack.org/34995914:53
*** karthiks has quit IRC14:54
*** amotoki has quit IRC14:56
*** danpb has left #openstack-nova14:56
*** hoonetorg has joined #openstack-nova14:56
openstackgerritSean Dague proposed openstack/nova: Add tests for safe_connect decorator  https://review.openstack.org/36680014:57
*** hoangcx has joined #openstack-nova14:57
sdaguedansmith: lol14:57
*** rrecio has joined #openstack-nova14:57
openstackgerritStephen Finucane proposed openstack/nova: live-mig: Add claims and proper resource tracking  https://review.openstack.org/24448914:59
openstackgerritStephen Finucane proposed openstack/nova: libvirt: pass libvirt reference methods to migration  https://review.openstack.org/32899714:59
openstackgerritStephen Finucane proposed openstack/nova: libvirt: live-migrate updates NUMA and cpus in the XML  https://review.openstack.org/28674414:59
*** mjura has quit IRC14:59
*** gouthamr has joined #openstack-nova14:59
*** _ducttape_ has joined #openstack-nova15:00
*** gouthamr_ has joined #openstack-nova15:01
jaypipesdansmith: it's industry standard.15:01
alaskijohnthetubaguy: can you take a look at https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1606496 when you get some time15:01
*** EinstCrazy has quit IRC15:01
dansmithheh15:01
*** hoangcx has quit IRC15:01
*** gszasz has quit IRC15:02
*** matrohon has quit IRC15:03
*** sdake has joined #openstack-nova15:03
zzzeekdansmith: I have the vaguest recollection of talking to you about that at some point15:03
*** ducttape_ has quit IRC15:03
zzzeekdansmith: and i think it hinged on, "does eventlet context switch for file IO?"  which i know the answer is "no"15:04
*** gongysh has joined #openstack-nova15:04
*** diogogmt has joined #openstack-nova15:04
dansmithzzzeek: right, but log to syslog will because socket right?15:04
dansmithI remember the file io thing15:04
*** hoangcx has joined #openstack-nova15:04
zzzeekdansmith: if it is using the posix calls for the syslog then I might say no, because the "socket" part doesnt happen in python at all15:05
*** gouthamr has quit IRC15:05
dansmithah15:05
zzzeekdansmith: but, this is in the category of neither file IO or socket IO then, it's "system call magic"15:06
zzzeekdansmith: but im just conjecturing.15:06
zzzeekdansmith: how do we do syslog logging, w/ normal PYthon logging module ?15:06
dansmithzzzeek: well, the follow-on here will make a call to rabbit to send a notification, so I need to bring that out anyway, but I'd like to know for future15:06
dansmithzzzeek: oslo.log, but it wraps logging I think15:06
clarkbpython syslog is via socket and udp/tcp iirc15:06
zzzeekdansmith: ah OK syslog handler might do the TCP in python15:07
clarkboslo logging at one point proposed a change to use syslog syscall which would block15:07
zzzeekdansmith: OK python sysloghandler is using socket()15:07
*** sdake has quit IRC15:08
zzzeekdansmith: so yes, logging w/ that handler will incur eventlet context switch.  But i still don't see what that has to do with the DB transaction being interrupted.  it's just two io streams15:08
dansmithclarkb: there's not actually a syscall for syslog() messages, right? you mean the libc syscall I assume?15:08
clarkbdansmith: sorry yes15:08
*** andrey-mp has left #openstack-nova15:08
dansmithzzzeek: if the other thread goes to do something that locks the same table.. that was the justification given for previous issues..15:09
zzzeekdansmith: hmmmm15:09
zzzeekdansmith: but...another process could do that anyway.15:09
*** READ10 has quit IRC15:10
dansmithzzzeek: right, but the thing holding the lock isn't blocked on a thing that is blocked for the same lock15:10
dansmithzzzeek: I wasn't involved in the diagnosis or fixing, but the commandment came out to "not do that because of this"15:10
zzzeekdansmith: OK but we're on the pymysql driver which won't block on IO15:10
zzzeekdansmith: that was it, becasue ancient mysqldb driver would block15:10
zzzeekwhich breaks eventlet15:10
*** annegentle has joined #openstack-nova15:10
dansmithzzzeek: okay, I'll buy that.. but we can still be run with mysqldb if so configured right? what about postgres?15:11
zzzeekdansmith: in eventlet world, anything that blocks on IO needs to yield for things to do the right thing.15:11
dansmithyep15:11
zzzeekdansmith: the postgresql driver should get patched into the async version of it....der....need to see what eventlet does...15:12
dansmithI wonder if we should just log a warning if you use a backend like mysqldb and say "we know dragons lie here"15:12
dansmithor just outright refuse it15:12
dansmithclarkb: er, I meant "the libc call" above, heh :)15:13
bauzasalaski: I wonder if it shouldn't be better to raise an InstanceNotFound if we can't find the BuildRequest in https://review.openstack.org/#/c/365740/4/nova/compute/api.py15:13
clarkbI parsed :)15:13
dansmithclarkb: :)15:13
clarkbehatever os.syslog ot whatever the method is maps to15:13
bauzasalaski: that way, in case users would see a 404, they would ask again15:13
zzzeekdansmith: i stil need to remember this.  if using mysqldb, greenlet A starts mysqldb transaction that locks an object.   then it yields due to syslog IO.  then greenlet B tries to lock object.  this blocks waiting for lock.  w/ pymysql, lock wait would yield back to A so work continues, OK.  right this is greenlet BS :)15:13
bauzasalaski: that would mean we wouldn't need to work on a race condition15:14
*** mdrabe has quit IRC15:14
zzzeekdansmith: but!15:14
zzzeekdansmith: but but!   i think eventlet even throws mysqldb operations into a thread pool ! doesn't it ?15:14
*** mdrabe has joined #openstack-nova15:14
bauzasalaski: and it would help the code to be easier15:14
*** hieulq_ has joined #openstack-nova15:14
*** ljxiash has quit IRC15:14
dansmithzzzeek: so, apparently thread pooling with mysqldb breaks eventlet too in some other way, so we always recommended it be disabled.. it was way faster, but people like rax could run for a total of 7 minutes before it broke or something15:15
dansmithalaski: you remember that discussion with comstud?15:15
zzzeekOHHHh15:15
zzzeekwell15:15
*** gszasz has joined #openstack-nova15:15
zzzeekyeah you're flipping switches until this breaks, pretty much :)15:15
*** diogogmt has quit IRC15:15
dansmithheh15:15
zzzeekdansmith: well yes, the mysqldb threadpool thing performs terribly if you look how it works15:16
zzzeekdansmith: because every dinky little io call is like, put it in the queue, etc.15:16
dansmithzzzeek: well, if you're sure pymysql is good here, that's fine with me, but we might want to think about some warnings if people configure for the other ones, especially if we're opening the gates on things we know will break them15:16
cfriesensfinucan: got a sec?  I'm seeing an interesting HT packing issue.15:16
sfinucancfriesen: hit me15:16
zzzeekdansmith: if you're using syslog logging handler in python w/ eventlet, you definitely need eventlet-compliant DB workings, which means either pymysql or psycopg2-green or if non-green driver then it's in a thread pool15:17
*** artom has quit IRC15:17
dansmithzzzeek: yeah15:17
zzzeekdansmith: shoutout to "hey let's stop using eventlet at this level :) "15:17
* dansmith sprays the protesters with the firehose15:17
dansmithmriedem: you following this? might be good to either log a warning or at least put a reno in place to warn aboutthis15:18
cfriesenone of our testers tried a bunch of 2-numa-node instances with one cpu per node, with the 'prefer' policy.  It grabbed one sibling from a new core each time, leaving the remaining sibling.  this of course makes it harder to schedule 'require' instances since there are no empty cores left.15:18
zzzeekdansmith: I actually *like* eventlet / gevent, but the thing im doing w/ them, I dont do monkeypatching.   im using the APIs explicitly,and things with DBs are in threads15:18
cfriesenit seems like "prefer" should try to use siblings on cores that are already partially-allocated, preferring to leave unused cores for 'require' instances.15:19
*** diogogmt has joined #openstack-nova15:19
sfinucancfriesen: hmm, that depends :)15:20
sfinucanby definition, it will prefer free cores15:20
*** sahid has quit IRC15:20
sfinucanbut I see the advantages of modifying it to work as you say15:20
sfinucan*fully free15:20
*** ociuhandu has joined #openstack-nova15:21
mriedemdansmith: nope, been debugging some internal stuff all morning15:21
cfriesensfinucan: according to http://docs.openstack.org/admin-guide/compute-flavors.html "prefer" simply means that thread siblings are preferred.  it makes no statement about interactions between separate instances.15:22
*** _ducttape_ has quit IRC15:22
*** roeyc has quit IRC15:22
*** ducttape_ has joined #openstack-nova15:22
mriedemdansmith: warn if you're not using pymysql or psycopg2-green?15:22
mriedemdansmith: is that up to nova, or oslo.db?15:23
cfriesendefinitely, with multiple guests vcpus on a single guest numa node we would prefer to fill up host cores first...but any vcpus left over after filling up host cores could be preferentially placed on partially-allocated cores I think.15:23
*** praneshp has joined #openstack-nova15:23
*** sahid has joined #openstack-nova15:23
sfinucancfriesen: aye, and if you're booting a four core instance and there are two free cores, it will take that15:23
sfinucan*those15:23
*** kevinz has joined #openstack-nova15:23
sfinucanthus preferring the siblings15:23
*** beagles is now known as beagles_brb15:24
dansmithmriedem: we could warn in oslo.db, but the offenses that break those would be in nova, so I'd warn in nova15:24
*** lucas-afk is now known as lucasagomes15:24
*** sdake has joined #openstack-nova15:24
*** syjulian_ has quit IRC15:25
*** andreas_s has quit IRC15:25
mriedemok, i haven't been up to date on what's going on, so don't know what's new that will break those15:25
sfinucancfriesen: but, ignoring semantics, packing would definitely make sense for both other cases though15:26
cfriesensfinucan: okay....we'll open a bug so it doesn't get forgotten.  might even propose a fix depending on how it gets prioritized.15:26
dansmithmriedem: nothing particularly new, but we now wrap db_api calls that do logging with the facade stuff, which could end up getting us into trouble.. nothing really new in newton necessarily15:26
sfinucancfriesen: Sure. I could fix that now, but I don't know if it's a bug or a feature request (i.e. specless BP needed)15:26
dansmithmriedem: I was just about to add a log call deep in the db code, and started thinking about this and re-opened the conversation15:26
dansmithmriedem: we're not testing with mysqldb anyway AFAIK, so the warning is also just "good luck..."15:27
*** EinstCrazy has joined #openstack-nova15:27
*** burgerk has joined #openstack-nova15:27
cfriesensfinucan: you're thinking maybe feature request due to cross-instance interference?15:27
*** armax has joined #openstack-nova15:27
cfriesensfinucan: cause there's no other end-user-visible change other than you can better mix prefer with isolate/require15:28
sfinucancfriesen: exactly. As things stand, booting two four core instances on an eight-core host will result in optimal performance for both guests15:28
sfinucanactually, booting two three core instances might be a better example15:28
cfriesensfinucan: until you try to boot a "require" instance and it fails, even though you've got spare cpus15:29
mriedemdansmith: right we're not using mysqldb since quite awhile, because oslo.db needed to get to py3 compliance i think15:29
mriedemwhich was pymysql15:29
*** sahid has quit IRC15:29
sfinucancfriesen: aye, but it really does depend on your use case15:29
dansmithmriedem: but we can still configure it AFAIK, right?15:29
*** nkrinner is now known as nkrinner_afk15:29
cfriesensfinucan: agreed.  pick the tradeoff. :)15:30
sfinucanall I'm saying is this is going to affect people, and it's not "broken" per se15:30
*** kevinz has quit IRC15:30
cfriesenfair enough15:30
sfinucan...so it's probably a feature request like "make the require and isolate thread policies easier to schedule successfully"  :)15:31
*** kevinz has joined #openstack-nova15:31
mriedemdansmith: yeah, i think so, rax uses mysqldb15:31
dansmithright15:31
cfriesenare you thinking a tuning knob?  (tweak for performance vs packing)   Or a "blessing" from the core team as to which way to go?15:31
*** sahid has joined #openstack-nova15:31
*** stevemar_ has joined #openstack-nova15:33
sfinucancfriesen: the latter15:34
*** stevemar_ has quit IRC15:34
*** baoli_ has quit IRC15:34
sfinucanwe've already got too many tuning knobs :)15:34
*** rama_y has joined #openstack-nova15:35
cfriesensfinucan: I suppose an argument could be made that if they really care about performance they should use "isolate" since "prefer" can already result in sharing cores...this would just make it more likely.15:35
stevemarmriedem: o/15:35
*** krtaylor has quit IRC15:35
stevemarmriedem: is there a reason none of the contrib managers are defined in client.py https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/client.py ?15:36
stevemarmriedem: i wanted to implement action-list in OSC, but theres no way for me to call the manager https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/contrib/instance_action.py15:37
*** unicell1 has joined #openstack-nova15:38
*** david-lyle_ has joined #openstack-nova15:38
*** david-lyle_ has quit IRC15:38
*** hoonetorg has quit IRC15:38
*** Sukhdev has joined #openstack-nova15:38
*** su_zhang has joined #openstack-nova15:39
sfinucancfriesen: yup, but it still makes for (potentially) worse performance for these people15:39
sfinucanwho did nothing wrong and don't deserve this :P15:39
*** unicell has quit IRC15:40
sfinucanbut that's bikeshedding. Definitely file the bug and assign me. I'll take a look at it this evening15:40
sfinucancfriesen: It would probably involve a change beyond https://review.openstack.org/#/c/342709 (which still needs core review :'()15:40
*** paul-carlton has quit IRC15:41
*** salv-orlando has joined #openstack-nova15:41
*** moshele has joined #openstack-nova15:41
*** mingyu has joined #openstack-nova15:41
* sfinucan better bike home now before it gets too dark15:42
*** lpetrut has quit IRC15:42
*** hoonetorg has joined #openstack-nova15:42
*** syjulian_ has joined #openstack-nova15:43
*** praneshp has quit IRC15:43
mriedemstevemar: not sure, probably models the old v2 api behavior where extensions were put into a contrib dir15:44
openstackgerritJianghua Wang proposed openstack/nova: Failed to create image from volume backed instance  https://review.openstack.org/36682515:45
*** gongysh has quit IRC15:45
stevemarmriedem: if i toss up a patch to expose them, would it get -2'ed? :)15:45
mriedemnot necessarily15:45
openstackgerritDan Smith proposed openstack/nova: More conservative inventory updates  https://review.openstack.org/36507315:47
*** salv-orlando has quit IRC15:48
*** paul-carlton2 has quit IRC15:50
*** ociuhandu has quit IRC15:52
PaulMurraysfinucan, cfriesen just reading back over your discussion about core packing..... it looks exactly the same as spreading vs stacking in host resource usage. There are operators that prefer to do one or the other15:52
PaulMurrayso both options are interesting15:52
*** artom has joined #openstack-nova15:54
*** artom has quit IRC15:55
*** annegentle has quit IRC15:55
*** artom has joined #openstack-nova15:55
*** moshele has quit IRC15:55
sdaguemriedem / dansmith / jaypipes / bauzas - the missing unit tests for the safe_connect decorator - https://review.openstack.org/#/c/366800/15:56
sdagueshould be quick15:56
*** salv-orlando has joined #openstack-nova15:57
mriedemstevemar: so instance actions seems like it should be in the main client,15:58
mriedemstevemar: there are other things in contrib that shouldn't, like the host-evacuate things, those aren't resource managers, they are helper scripts15:59
jaypipessdague: on it.15:59
mriedemstevemar: we could move instance_actions up a level and provide an alias to the v2/contrib15:59
*** annegentle has joined #openstack-nova15:59
mriedemstevemar: why can't you just get the instance actions manager from the contrib directory though?15:59
mriedembecause you only have the Client object?16:00
stevemarmriedem: right, we only have access to the client16:00
mriedemhonestly i'm not even sure how those contrib entries are loaded16:00
stevemarmriedem: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/client.py#L69-L7916:00
stevemarmriedem: i'm trying to figure that out now16:01
mriedemthe discover_extensions method it looks like16:01
*** pcaruana has quit IRC16:01
sfinucanPaulMurray: but how do we do it without YAK (yet-another-knob)16:01
*** su_zhang has quit IRC16:02
cfriesenPaulMurray: agreed, both are interesting.  the downside of spreading is that it leaves the host in a state where only other 'prefer' instances can be scheduled on it.  'isolate' and 'require' instances are out of luck.16:02
*** cdent has joined #openstack-nova16:02
stevemarmriedem: yeah "_discover_via_contrib_path:16:02
*** su_zhang has joined #openstack-nova16:02
stevemarmriedem: well that is icky16:02
cdentdansmith, jaypipes: Where we at? Something I should do?16:03
cdentsdague: thanks for writing that description of allocations thing to mailing list: writingstuffdown++16:04
*** hieulq_ has quit IRC16:04
jaypipescdent: just wrapped up some meetings. still reviewing...16:04
cdentjaypipes: ✔16:04
*** EinstCrazy has quit IRC16:05
*** beagles_brb is now known as beagles16:05
*** mgoddard_ has joined #openstack-nova16:05
*** abalutoiu_ has quit IRC16:05
mriedemstevemar: looks like the shell discovers the extensions after creating the client, but you'd have to do something similar i guess16:06
mriedemor we just move the instance actions out of contrib and alias it16:06
mriedemseems like that should be in the mainline path anyway, i'm not sure why it's considered an 'extension'16:06
*** su_zhang_ has joined #openstack-nova16:06
stevemarmriedem: yeah, probably just do that16:06
mriedemagain, v2 wonkiness16:06
cdentedleafe: on [t 1V65], yeah, I think you're right. That's either jay-code or me cargoing jay code16:06
purplerbot<edleafe> cdent: suggestion: use set1.intersection(set2) instead of set1 & set2 - it's much less confusing to readers [2016-09-07 14:42:15] [n 1V65]16:06
stevemari know all about version api wonkiness16:06
mriedemsdague wants to kill extensions and at some point we need to do that in novaclient too probably16:06
stevemarmriedem: yeah, we did that in keystone 2 cycles ago16:06
*** su_zhang has quit IRC16:07
sdaguestevemar: there is just a lot of cruft that needs cleaning out16:07
*** rama_y has quit IRC16:07
sfinucancfriesen: looks like a definite spec, IMO16:07
sfinucanthe best way to get both sides of the argument16:07
stevemarsdague: worms in a garden and all that16:07
sdaguestevemar: so, I would honestly suggest we move stuff you care about out of contrib16:07
cdentedleafe: I can look into adjusting some of that stuff when I know if dansmith is holding any code out16:07
*** rama_y has joined #openstack-nova16:07
*** EinstCrazy has joined #openstack-nova16:07
sdagueinstead of trying to figure out loading all the stuff there16:07
*** su_zhang_ has quit IRC16:07
dansmithcdent: I have nothing unsubmitted right now16:08
*** su_zhang has joined #openstack-nova16:08
sfinucancfriesen: a la https://review.openstack.org/#/c/364468/16:08
*** su_zhang has quit IRC16:08
dansmithcdent: I just pushed an update to the conservative inventory updates patch16:08
dansmithcdent: and was going to start on doing the same for allocations on top of your GET patch when it looks like that is mostly set16:08
edleafecdent: yeah, it's not the end of the world or anything16:08
*** mgoddard has quit IRC16:08
*** su_zhang has joined #openstack-nova16:08
cdentdansmith: have you seen/investigated https://review.openstack.org/#/c/365633/516:09
cdentthat's the fix of the inventory serialization16:09
dansmithcdent: I also put the current list of things I think we need to land for newton in the etherpad16:09
*** paul-carlton2 has joined #openstack-nova16:09
*** su_zhang has quit IRC16:09
dansmithcdent: I think sdague wants release-blocking bugs for each16:09
*** tesseract- has quit IRC16:09
sdaguedansmith: or at least all patches we think we need to land associated to a bug16:09
*** su_zhang has joined #openstack-nova16:09
* cdent looks at etherpad16:09
dansmithsdague: yeah, two of the patches in that list are actually for one bug16:09
sdaguemostly, I'm not sure where our FFE stops16:10
dansmithcdent: I will let the api peeps decide on that serialization thing16:10
sdagueand it helps in priortizing16:10
dansmithsdague: these are all bugs in code that is landed now16:10
dansmithsdague: so not FFE related16:10
*** akshai has joined #openstack-nova16:10
*** su_zhang has quit IRC16:11
cdentdansmith: the thing I just linked (https://review.openstack.org/#/c/365633/ ) is the change that makes it so the inventory writing code can be less complex (by including the resource provider in an accessible) and includes the de-complexifying of the resource tracker16:11
*** su_zhang has joined #openstack-nova16:11
cdentthe allocation serialization question is in https://review.openstack.org/#/c/366789/16:12
dansmithcdent: yeah I know16:12
cdent(the de-complexifying may be wrong now, as a result of the changes you've recently made)16:12
cdentdansmith: ah, okay, it wasn't clear from your response if we were talking of the same stuff16:12
cdentdo you think we need that change or only want it?16:13
mriedemsdague: +216:13
mriedemthanks16:13
dansmithcdent: well, you're changing the API, so I think if we're going to do it, we better do it soon, yeah16:14
cdentwow, that was magic16:14
cfriesensfinucan: okay, can go that route16:14
cdentI went to etherpad tab and it started typing what I was going to type. amazeballs16:15
alaskidansmith: yeah, I remember the thread pooling/eventlet thing from way back. comstud had a fix proposed to eventlet which I don't think they ever merged. rax runs with a patched eventlet to avoid it16:15
*** wznoinsk has joined #openstack-nova16:15
*** ajo_ has quit IRC16:15
*** su_zhang has quit IRC16:16
dansmithalaski: right16:16
*** ajo_ has joined #openstack-nova16:16
*** EinstCrazy has quit IRC16:16
dansmithcdent: we should get anything else we have on the etherpad so we can discuss what is critical and not16:17
dansmithwhat is there is pretty much what is in my head at the moment16:17
cdentdansmith: I'll add what I know16:18
*** raunak has joined #openstack-nova16:18
*** gszasz has quit IRC16:18
*** raunak has quit IRC16:19
*** code-R_ has quit IRC16:19
*** syjulian_ has quit IRC16:20
alaskibauzas: I think you're misunderstanding the race16:20
*** raunak has joined #openstack-nova16:20
alaskibauzas: and we really shouldn't return a 404 if at all possible16:20
alaskiif the buildrequest is deleted things are fine, we know there's an instance in a cell at that point that can be updated16:20
openstackgerritSylvain Bauza proposed openstack/nova: WIP: Update BuildRequest if instance currently being scheduled  https://review.openstack.org/36574016:20
*** mgoddard has joined #openstack-nova16:21
alaskithe issue is that the buildrequest update may not be picked up by the process working on the instance boot. unless it looks up the buildrequest after the update it will not be aware that something changed16:21
*** akshai_ has joined #openstack-nova16:21
*** mgoddard_ has quit IRC16:21
*** akshai has quit IRC16:21
bauzasalaski: right, I see16:21
bauzasalaski: so the instance boots on proc A, then goes to conductor which destroys the buildrequest16:22
*** syjulian_ has joined #openstack-nova16:22
openstackgerritSean Dague proposed openstack/nova: Additional logging for placement API  https://review.openstack.org/36618616:22
bauzasalaski: in the meantime, another API worker could lookup the buildrequest, that's what you want to say?16:23
openstackgerritTom Patzig proposed openstack/nova: refresh instances_path in shared stor testfile chk  https://review.openstack.org/36685716:23
*** thorst has quit IRC16:24
alaskibauzas: yeah, and remember that the order in conductor will be create instance in cell, map instance to cell, remove buildrequest. so not finding the buildrequest is good, that means the instance is either in a cell or deleted16:24
*** kevinz has quit IRC16:24
*** thorst has joined #openstack-nova16:24
bauzasalaski: right, I wrote that in my last PS I just uploaded16:24
*** raunak has quit IRC16:25
bauzasalaski: the real problem I saw when trying to verify that (whether the instance is still there or not) means that I need to lookup the instance with all the needed attributes16:25
*** mingyu has quit IRC16:25
bauzasalaski: so, again, trying to look at the instance mapping, and if not, failback to the simple DB call16:25
alaskibauzas: my concern is this: compute/api creates a buildrequest for a future instance, it sends that to conductor which picks a cell and creates an instance based on the buildrequest, but the buildrequest was never refreshed so any updates will be missed16:25
*** krtaylor has joined #openstack-nova16:26
alaskibauzas: you mean the expected_attrs?16:27
alaskilet me looks at the latest PS. I think we're talking about two different things16:27
*** raunak has joined #openstack-nova16:28
bauzasalaski: sorry, it seems I'm very tired by that FF :/16:28
*** baoli has joined #openstack-nova16:29
bauzasalaski: so, trying to get your concern, I don't see a problem if we always verify first if the instance has a cell mapping16:29
bauzasbecause it's litterally the action made right after creating the instance record in the cell, and before deleting the buildrequest16:30
alaskiyeah, there's no problem doing that16:30
alaskieverything above line 2424 looks fine16:31
bauzasthe race I can see is when _get_server() returned a nested buildrequest.instance because at that time, the instance record in the cell wasn't done16:31
bauzasso, we could say "eh look, this instance doesn't have an id, so it's not yet created in the child cell"16:31
bauzasso, L2424 and below are for that case16:32
cdentdansmith: is this still relevant? https://review.openstack.org/#/c/364547/16:32
bauzaswhere we verify whether there is an instance mapping *now*16:32
*** thorst has quit IRC16:32
alaskibauzas: down to line 2437 things look good to me. it's below that where we're not on the same page16:32
dansmithcdent: yeah16:33
*** nic has joined #openstack-nova16:33
dansmithcdent: iddn16:33
bauzasalaski: I see, you disagree with my comment16:33
dansmithcdent: didn't realize that didn't merge16:33
*** jaosorior has quit IRC16:33
*** gus has quit IRC16:33
bauzasalaski: okay, then I'll update that, and do the instance mapping (and instance record) lookup16:33
alaskibauzas: right. I think doing the lookup is better. if instance is found then update it, if not then it was deleted so raise that16:34
*** ayoung has quit IRC16:35
alaskibauzas: but there's still another race, which I mentioned above. This update won't be picked up by the boot process if buildrequest is updated16:35
bauzasalaski: but I need to keep the else statement like in L2418 because we agreed to not have the cells migration done pre-Newton16:35
openstackgerritRoman Podoliaka proposed openstack/nova: block_device: fix propagation of instance AZ to Cinder  https://review.openstack.org/36672416:35
*** yamahata has quit IRC16:35
alaskibauzas: yep16:35
*** ayoung has joined #openstack-nova16:36
bauzasalaski: oh, because we pass down the BuildReq to the conductor without looking it up again ?16:36
alaskibauzas: yep16:36
bauzasif so, I think I understand your concern, lemme look at the code16:37
bauzasI thought we were fetching the buildrequest record, not passing it thru RPC16:37
alaskicool. I think we should have a second patch for fixing that, just wanted to raise the issue.16:38
alaskiwell, https://review.openstack.org/#/c/319379/ was planning to pass via RPC16:38
alaskiwhich I think is the right thing to do16:38
dansmithcdent: your get patch is RP-based, not consumer-based16:39
dansmithcdent: which means I have to pull the entire list of allocations for every consumer of my resources in order to check to see if my consumer is good16:39
dansmithcdent: which also means I can't generically compare allocations for all resource providers that have allocations for a given consumer16:40
dansmithcdent: I was expecting a GET /allocations/$consumer_uuid16:40
bauzasalaski: well, I now fully understand the race you mention16:40
bauzasalaski: I think I agree with you about passing it down thru RPC, I just wonder how we could prevent that race but having a synchronized section16:41
*** burt has joined #openstack-nova16:41
bauzas(and where...)16:41
*** gus has joined #openstack-nova16:42
cdentdansmith: I asked jaypipes what he wanted, that's what he said he wanted. I think you/we will need to consult with him on what he has in mind16:42
cdentdansmith: but a) we can change it pretty easily b) we can have both pretty easily16:42
mriedemalaski: check it out https://bugs.launchpad.net/nova/+bug/162113816:43
openstackLaunchpad bug 1621138 in OpenStack Compute (nova) "block_device_mappings column is not large enough in table build_requests" [Undecided,New] - Assigned to Kenneth Burger (burgerk)16:43
dansmithjaypipes: you're not okay with GET /allocations/$uuid  ?16:43
mriedemTest is apparently not big enough16:43
mriedemburgerk: how many volumes are you booting the instance with?16:43
*** akshai_ has quit IRC16:43
edleafecdent: maybe GET /allocations/$rp_id/$consumer_id as a refinement?16:43
bauzasmriedem: alaski: FWIW, I also saw that one https://bugs.launchpad.net/nova/+bug/1620684 but I struggled finding time to look further16:44
openstackLaunchpad bug 1620684 in OpenStack Compute (nova) "nova list --status soft_deleted is not showing soft deleted Instances" [Undecided,In progress] - Assigned to Anusha Unnam (anusha-unnam)16:44
cdentedleafe: that would violate the current grammar16:44
burgerkmriedem: broke at ~ 80 volumes, want to go up to 12816:44
cdentso we'd either need to change it a lot, or not do that16:44
alaskibauzas: a distributed lock would solve this :)  But I think what we'll need to do is lookup the buildrequest after we create the instance and then move any updates to the instance16:44
bauzasmriedem: half-related, we now have 14 rc-potential bugs16:44
alaskibauzas: sdague nacked that one16:44
mriedemburgerk: jesus, 128 volumes for an instance?16:44
sdaguealaski: was it needed for something?16:45
sdagueit seemed like a random API change16:45
bauzasalaski: mmm, I thought the reporter was mentioning some regression on the API qide16:45
alaskisdague: not really, just mentioning it because bauzas brought up the bug16:45
*** lucasagomes is now known as lucas-dinner16:45
bauzassdague: context is https://bugs.launchpad.net/nova/+bug/162068416:46
openstackLaunchpad bug 1620684 in OpenStack Compute (nova) "nova list --status soft_deleted is not showing soft deleted Instances" [Undecided,In progress] - Assigned to Anusha Unnam (anusha-unnam)16:46
bauzasI just made a brief pass on our open bugs, and saw that one16:46
bauzasso I actually wonder if that's a regression or not16:46
*** diogogmt has quit IRC16:46
bauzassdague: but if you say that's a new feature, then... :)16:46
alaskibauzas: I don't believe that's a regression16:46
mriedemburgerk: will MEDIUMTEXT work for you?16:47
alaskibauzas: or if it is it's a regression from adding a soft-delete state16:47
alaskimriedem: looking16:47
bauzasalaski: well, the bug description left me think that16:47
burgerkmreidem: yes, that was going to be my proposal16:47
edleafecdent: how would you represent a filter on both in the current grammar? Or is that not possible.16:47
bauzasalaski: the reporter was saying he was getting an empty list when asking for soft-deleted16:47
bauzaswhile the instance was still on soft-delete (of cours)e16:48
bauzasbut I should reproduce16:48
bauzasthat's #2 task I have :)16:48
sdaguebauzas: there is no indication that it's a regression in the bug16:48
bauzassdague: I agree16:48
mriedemheh, unrelated, why is hypervisor_type mediumtext?16:48
mriedemhypervisor_type = Column(MediumText(), nullable=False)16:48
alaskibauzas: buildrequest lookups won't affect soft-delete because only scheduling instances are buildrequests. I don't think it's related to cells changes16:48
*** rama_y has quit IRC16:48
bauzashence me needing to test whether we had that too in Mitaka16:49
cdentedleafe: the grammar issue is that, as currently written, good grammar is /allocations/{consumer_id} and /resource_providers/{rp_uuid} so we shouldn't mix those. filters, one could do lots of things but it depends on the use case. I'm not really sure what you're asking?16:49
bauzasalaski: okay, tbh, it wasn't an hard call, I just put the rc potential tag to make sure I wasn't forgetting it16:49
*** Apoorva has joined #openstack-nova16:49
bauzaseither way, like I said, I need to test on Mitaka and see whether it was a regression or not16:49
bauzasif not, then I'll remove the rc tag16:50
bauzasand if that's an API change, I'll even close the bug16:50
mriedemburgerk: ok ping me when you have a change up16:51
*** unicell1 has quit IRC16:51
edleafecdent: it's more efficient to only return the data that is relevant. If you want the allocations for a particular RP and consumer, shouldn't that be possible>16:51
edleafe?16:51
dansmithmriedem: a change for what? altering the column definition in BDMs?16:51
melwittthat soft-deleted bug isn't a regression and there's been a patch up for a long time that would enable --status soft_deleted to work https://review.openstack.org/#/c/258472/ but afaik it's never worked16:52
mriedemdansmith: making build_requsts.block_device_mappings MEDIUMTEXT rather than TEXT16:52
bauzasmelwitt: oh, thanks for helping !16:52
mriedemsince it's a serialized blob of all bdms in the build request16:52
bauzasmelwitt: so, that's just a looong story bug16:52
melwittbauzas: yeah, unfortunately16:52
dansmithmriedem: okay, technically that'd be a migration we'd want to not do, but it's a small table so maybe it's not so bad16:52
bauzasmelwitt: looking for duplicates then16:53
dansmithmriedem: i.e. a table rewrite16:53
mriedemdansmith: if we're going to do it we should probably do it in newton16:53
mriedemalthough build_requests was around since mitaka right?16:53
dansmithmriedem: yeah, but it's also just things that are waiting for scheduling anyway right?16:53
mriedemand those are supposed to be short-lived resources16:53
mriedemand hard-deleted16:54
dansmithyep16:54
alaskiokay, just caught up16:54
*** syjulian_ has quit IRC16:54
alaskiyeah, the table should have almost nothing in it at any given time16:54
*** GB21 has joined #openstack-nova16:54
mriedemjust looking at where we use mediumtext on other things, it's clob-y type things like this too16:54
mriedemi think i asked about this when that column was added actually, if it'd be big enough16:54
* dansmith looks up clob-y16:54
*** lpetrut has joined #openstack-nova16:54
mriedemclobish16:55
bauzasmelwitt: well https://bugs.launchpad.net/nova/+bug/1526715 is technically not a duplicate of https://bugs.launchpad.net/nova/+bug/1620684 but that's enough for me to close the bug and ask to create a spec because it will need a microversion as sdague stated correctly16:55
openstackLaunchpad bug 1526715 in OpenStack Compute (nova) "disallow non-admin search for soft-delete instance" [Low,In progress] - Assigned to jichenjc (jichenjc)16:55
openstackLaunchpad bug 1620684 in OpenStack Compute (nova) "nova list --status soft_deleted is not showing soft deleted Instances" [Undecided,In progress] - Assigned to Anusha Unnam (anusha-unnam)16:55
* dansmith look sup clobish16:55
bauzasmelwitt: thanks:16:55
alaskimriedem: 80 volumes should be enough for anyone :)16:55
dansmithalaski: seriously16:55
sdaguebauzas: works for me16:55
*** Swami_ has quit IRC16:55
melwittbauzas: hm, I guess I didn't think it would need a microversion16:55
mriedembtw, it's hilarious that compute_nodes.hypervisor_type is a mediumtext column16:56
cdentedleafe: if what I wanted was all the allocations by consumer_id against just one resource provider I'd probably leave it as it: get the allocaitons against all the resource providers cuz it's small. Where efficiency might come into place is when getting all or lots of the allocations against a particular resource provider (GET /resource_providers/{uuid}/allocations)16:56
cdentedleafe: in case I'd think some kind of filtering would be useful, ad query params16:57
melwittbauzas: the behavior is caused by inconsistent behavior between 'deleted' and 'soft-deleted' and the fix just makes it consistent. so I thought it would just be a bug fix16:57
*** zenoway has joined #openstack-nova16:57
cdentI do not, however, thing that the representation should change (such that only some fields are displayed in the output)16:57
bauzasmelwitt: not really :/16:57
cdentthat would be an early optimization16:57
bauzasmelwitt: because the experience would change16:57
bauzasconsistency is certainly a good concern, but changing what the API returns based on some arguments needs a microversion I guess16:58
cdentedleafe: if we eventually discovered that the movement of a small number of bytes around was having real drag on the system, we could explore what to do, but since at the moment we've not even worried about tcp connection overhead, I don't think it is something worth worrying about16:58
melwittbauzas: I can see how it would be debatable16:58
bauzas:)16:58
sdagueregardless, I don't think it's a post FF bug to address16:58
alaskiagreed. though I also agree with melwitt that it's more a bug fix than feature16:59
melwittyeah, we can sort that out later whether it's spec or not by a quick nova meeting discussion or something16:59
*** annegentle has quit IRC16:59
melwitter, microversion or not16:59
*** anush has quit IRC17:00
*** Sukhdev has quit IRC17:01
bauzasmelwitt: sdague: I marked it as opinion to leave the door open17:01
bauzaseither way, it's certainly not something we want to merge for Newton17:01
*** zenoway has quit IRC17:02
melwittyeah, definitely not17:02
mriedemif it worked in mitaka, then it's a bug fix imo17:02
* bauzas goes afk for dinner17:02
* mriedem sets up mitaka devstack to recreate17:03
sdaguemriedem: https://github.com/openstack/nova/commit/09f2c4729456443c4874a8cadc53299817d6371a17:03
sdaguemriedem: honestly, put that back on the bug reporter. I think we need them to indicate that this is a regression. The bug is just "I want to do this"17:04
sdaguemriedem: https://github.com/openstack/nova/commit/09f2c4729456443c4874a8cadc53299817d6371a  is where hypervisor_type becomes Text()17:04
sdagueMediumText() was part of model sanity later, as I think the type might have shifted slightly in the grizzly data compaction17:04
sdaguemriedem: note, that predates gerrit17:05
*** derekh is now known as derekh_ark17:05
*** derekh_ark is now known as derekh_afk17:05
*** annegentle has joined #openstack-nova17:05
mriedemand of course no real good info on why it was changed17:06
mriedemnice, merged with print statements in the runtime code17:07
*** tblakes has quit IRC17:07
sdagueit's pre gerrit17:08
sdaguethis was when it was all just on vishy's laptop :)17:08
*** fragatina has joined #openstack-nova17:08
jaypipesdansmith: hey, sorry, grabbed some lunch...17:09
dansmithjaypipes: dedicated people eat lunch at their desk and keep working17:09
mriedemi don't suppose making that column smaller would give any perf benefit?17:09
openstackgerritDan Smith proposed openstack/nova: More conservative allocation updates  https://review.openstack.org/36687217:09
dansmithjaypipes: cdent: ^17:09
jaypipesdansmith: so, yeah, the idea is that we need to get all the allocations for the resource provider and have the reporting client only send updated allocations when they are not known right?17:09
dansmithjaypipes: right, but the way the code is currently structured in the RT, we do that per instance, which means we have to fetch the entire set every time we do one instance, or try to do some caching that invalidates infrequently enough to not hide when things do need changing17:10
jaypipesdansmith: yes, I know, I should be more dedicated, but if I didn't walk up to get some lunch, you might never have seen this: https://twitter.com/jaypipes/status/77356809435893350417:11
*** Swami has joined #openstack-nova17:11
dansmithheh17:11
*** Sukhdev has joined #openstack-nova17:14
*** ajo_ has quit IRC17:14
*** ajo_ has joined #openstack-nova17:14
*** links has joined #openstack-nova17:14
*** PaulMurray has quit IRC17:15
openstackgerritChris Dent proposed openstack/nova: [placement] Correct serialization of inventory collections  https://review.openstack.org/36563317:15
cdentdansmith: that ^ is rebased onto your updated conservative updates17:15
*** krtaylor has quit IRC17:16
dansmithcdent: cool17:16
cdentis a smaller change than I remember17:16
*** jdurgin1 has quit IRC17:16
* cdent is blurring everything together17:16
*** krtaylor has joined #openstack-nova17:16
dansmithcdent: gotta keep up! rest is for after RC1 :)17:17
*** annegentle has quit IRC17:17
dansmith(rest as in sleep, not the other ten meanings we have for it)17:17
cdentdansmith: I think my error was that I wasn't resting after the last RC117:17
*** ducttape_ has quit IRC17:18
*** mvk has quit IRC17:21
*** unicell has joined #openstack-nova17:25
*** sahid has quit IRC17:26
*** sudipto_ has joined #openstack-nova17:27
*** sudipto has joined #openstack-nova17:27
*** ayoung has quit IRC17:27
sdaguemriedem: unlikely, it's not like we are selecting by it often17:28
sdagueor joining on it17:28
*** links has quit IRC17:29
*** gouthamr_ is now known as gouthamr17:29
*** thorst has joined #openstack-nova17:29
*** ihrachys has quit IRC17:30
mriedemsdague: yeah i guess the only thing that does filter on it is the ironic hash ring stuff17:30
* cdent cuts the grass17:30
*** ssurana has joined #openstack-nova17:31
*** zenoway has joined #openstack-nova17:32
*** kfarr has joined #openstack-nova17:33
*** trisq has quit IRC17:34
sdaguehttps://review.openstack.org/#/c/366186/ is the consolidated logging I found helpful in tracking down the other issue. Though the capacity logging may not actually be that interesting.17:36
*** zenoway has quit IRC17:36
*** Sukhdev has quit IRC17:36
sdagueso... on the allocations front17:36
sdaguewe're never allocating disk in the gate17:37
sdagueis the special handling of 0 for disk in the flavor accounted for?17:37
*** thorst has quit IRC17:38
*** yamahata has joined #openstack-nova17:38
*** ducttape_ has joined #openstack-nova17:38
cdentsdague: I added that logging review to https://etherpad.openstack.org/p/placement-next so it doesn't get lost17:38
sdaguecdent: cool17:38
cdentdansmith: ^^ (0 for disk)?17:38
* cdent cuts grass tomorrow instead, can't be assed17:39
sdaguecdent: 0 for disk in the flavor means "use the size of the disk from glance" for... hysterical raisins (honestly, no idea why that is there like that)17:39
cdentsdague: yeah, I recall, I was just pinging dan into the conversation in case he had slipped away and didn't see that17:40
openstackgerritSwaminathan Vasudevan proposed openstack/nova: Implement setup_networks_on_host for Neutron networks  https://review.openstack.org/27507317:40
* cdent wonders where he can buy some hysterical raisins for his next party17:40
mriedemdansmith: probably don't need to recheck https://review.openstack.org/#/c/364547/ since it's not merging b/c of the dependency17:40
Swamimriedem: ^^17:41
dansmithmriedem: oh sorry17:41
*** Sukhdev has joined #openstack-nova17:41
mriedemi'm not sure that the dependency is necessary?17:41
dansmithmriedem: it's not I just did that to test17:42
openstackgerritChris Dent proposed openstack/nova: [placement] Clarify commentary around logging trap  https://review.openstack.org/36571917:45
*** paul-carlton2 has quit IRC17:45
mriedemdansmith: i'll remove the depends-on and +W17:45
dansmithjsut removed17:45
dansmithmriedem: thanks17:46
openstackgerritMatt Riedemann proposed openstack/nova: Cleanup allocation todo items  https://review.openstack.org/36454717:46
dansmithsorry missed that and thought it was due to gerrit maintenance on friday17:46
*** harlowja has quit IRC17:46
dansmithoh ffs17:46
dansmithI did the wrong one hah17:46
mriedemha17:48
mriedemmaybe you need some rest :)17:48
dansmithheh17:48
dansmithon a call and distracted :D17:48
dansmithI definitely need fewer calls, no doubt17:49
*** gszasz has joined #openstack-nova17:49
openstackgerritJay Pipes proposed openstack/nova-specs: Amend placement API with correct GET inventory  https://review.openstack.org/36688817:49
*** harlowja has joined #openstack-nova17:49
jaypipescdent: https://review.openstack.org/36688817:49
jaypipescdent: I'll push a code fix for the placement API shortly.17:49
jaypipescdent: not your fault. was just a simple oversight.17:50
cdentjaypipes: argh, anonymous dicts in lists!17:51
*** su_zhang has joined #openstack-nova17:51
*** tblakes has joined #openstack-nova17:51
jaypipescdent: what is wrong with that? a dict is a record, simple as that.17:52
*** fragatina has quit IRC17:52
*** fragatina has joined #openstack-nova17:53
cdentnow pretty much any time I want to actually get a specific piece of information out of the response, I have to pivot the list of dicts to a dict of dicts based on some key of some element in the list17:53
*** ajo_ has quit IRC17:53
dansmithI definitely like the anonymous dict approach less, but as long as they're consistent I don't care as much17:53
jaypipescdent: or you use InventoryList.find() which is precisely why I wrote that method.17:53
dansmithcdent: right, that's why it sucks17:53
*** ajo_ has joined #openstack-nova17:53
*** gszasz has quit IRC17:53
dansmithbut consistency wins every time17:53
cdentif I have an api response, I don't want to have to make it into an InventoryList, especially not client side, to have to do any work with it17:54
jaypipesdansmith, cdent: so do you want me to change it to be consistently *not* anon dicts?17:54
*** hoangcx has quit IRC17:54
dansmithjaypipes: were you saying that bauzas had a problem with that on spec review?17:54
*** code-R has joined #openstack-nova17:55
*** zenoway has joined #openstack-nova17:55
cdentbrb17:56
*** code-R_ has joined #openstack-nova17:56
*** hoangcx has joined #openstack-nova17:57
*** Sukhdev has quit IRC17:59
jaypipesdansmith: yes, if I remember, bauzas wanted the anon dict format.17:59
*** diogogmt has joined #openstack-nova17:59
dansmithjaypipes: I wonder why17:59
dansmithbauzas: still around?18:00
*** zenoway has quit IRC18:00
*** code-R has quit IRC18:00
cdentsorry jaypipes, dansmith : dinner's on the table, will check for an update on this  a bit later18:00
*** cdent has quit IRC18:00
*** code-R_ has quit IRC18:02
*** fragatina has quit IRC18:03
*** fragatina has joined #openstack-nova18:04
sdaguemriedem: also, good news, in talking with mordred and bknudson, by our use of keystoneauth session object we don't have to work about token expiration18:09
mriedemcool18:10
* mordred helped18:10
bauzasdansmith: jaypipes: yup, wazup ?18:10
jaypipesbauzas: remember our discussions on the generic-resource-pools spec around the format of the returned JSON for the inventories collection?18:10
jaypipesbauzas: http://specs.openstack.org/openstack/nova-specs/specs/newton/approved/generic-resource-pools.html#get-resource-providers-uuid-inventories18:11
jaypipesbauzas: you had said you didn't like the use of a dict, keyed by resource class ID, and wanted to see anonymous dicts in a list, to be consistent with other OpenStack APIs.18:11
bauzasjaypipes: yup, it was a long time ago18:11
openstackgerritMatt Riedemann proposed openstack/nova: libvirt: improve logging for shared storage check  https://review.openstack.org/36514018:11
openstackgerritMatt Riedemann proposed openstack/nova: nfs fix for xenial images  https://review.openstack.org/32946618:11
jaypipesbauzas: :) well, 2-3 months, yes.18:11
bauzasjaypipes: yup, my main concern was about the consistency18:12
* bauzas needs to look at the review18:12
jaypipesbauzas: anyway, we changed the PUT and POST to use anon dicts, like here: http://specs.openstack.org/openstack/nova-specs/specs/newton/approved/generic-resource-pools.html#put-resource-providers-uuid-inventories18:12
jaypipesbauzas: but forgot to do the GET response.18:12
jaypipesbauzas: but now we're questioning which way to go.18:13
jaypipesbauzas: and I mentioned to Dan you preferred the list of anonymous dicts approach.18:13
*** ociuhandu has joined #openstack-nova18:13
*** akshai has joined #openstack-nova18:13
bauzasokay, so that's because I think it's preferrable to have a list of keyed values identical18:13
bauzasin the formet GET method, I wasn't liking having keys not being stable18:14
*** code-R has joined #openstack-nova18:14
bauzaseven if those keys were immutable, of course18:14
*** code-R has quit IRC18:14
bauzasby "stable",  I mean having dicts having a list of defined keys18:15
*** code-R has joined #openstack-nova18:15
bauzasjaypipes: FWIW, +1d https://review.openstack.org/#/c/366888/118:16
mordredjaypipes: cdent may have his happiness about anonymous dicts improved by http://jmespath.org/ perhaps?18:17
mordred>>> jmespath.search('[].name', [{'name': 'foo'}, {'name': 'bar'}])18:17
mordred['foo', 'bar']18:17
mordredworks great18:17
bauzasjaypipes: dansmith: btw. given I'll be mostly looking at bug reports for the next week (due to the RC period), please ping me any patch you want me to look at needed for Newton18:17
bauzasjaypipes: dansmith: I can see lots of efforts around the resource-providers which I like, so in case you want me to review them... :)18:18
*** sudipto_ has quit IRC18:19
*** sudipto has quit IRC18:19
*** hoangcx has quit IRC18:24
*** zul has quit IRC18:27
openstackgerritSean Dague proposed openstack/nova: Add tests for safe_connect decorator  https://review.openstack.org/36680018:28
sdaguemriedem: the only actual issue was my assert_called, right?18:29
mriedemsdague: i think so18:30
mriedemthe assert_not_called is in mock 2.0 and py3.518:30
mriedemi went over that with laski last week18:30
mriedembtw, why do we have both py 3.4 and 3.5 jobs? i'm sure someone has stated this at some point,18:31
mriedembut are we dropping the py3.4 half-baked stuff at some point?18:31
sdagueyes18:31
sdagueit's transitional18:32
*** code-R_ has joined #openstack-nova18:32
sdaguebecause xenial has 3.5, and so most of the nodes will end up over there18:32
clarkbwe only python3.4 on olderbranches now18:32
jaypipesbauzas: well, we are right now trying to achieve alignment on the format of the GET /r-p/{uuid}/inventories call. you read the above back and forth from cdent and dansmith yeah?18:34
mriedemclarkb: we're still running py34 jobs for nova on master https://review.openstack.org/#/c/357494/18:34
mriedemgate-nova-python34-db18:34
*** code-R has quit IRC18:35
clarkbhrm probably need more cleanup in zuul.then18:35
clarkbthe intent was to switch out I think since py34never really got aton of attention18:35
clarkbbasically roll forward ratherthan support all the python3s18:36
*** thorst has joined #openstack-nova18:39
*** ayoung has joined #openstack-nova18:39
*** su_zhang has quit IRC18:42
jaypipesmriedem: +2 from me on sdague's safe_connect latest revision18:43
*** thorst has quit IRC18:43
jaypipesmriedem: I wasn't aware of the policy change to encourage docstrings on test methods, though. that's news to me. have we publicized that anywhere?18:43
*** cdent has joined #openstack-nova18:45
cdentmordred: is jmespath the ne jsonpath or jsonpath the new jmespath. jsonpath already used in lots of openstacky places, and I'm a fan, but in it (or jmespath) dealing with anonymous dicts still more complex than dicts of dicts18:46
cdentdicts of dicts just make more sense when we have unique "records" anyway...18:46
mriedemjaypipes: it comes up in irc every few months18:46
cdentbut I'm agnostic at this stage18:47
mriedemjaypipes: otherwise no18:47
cdentjaypipes, dansmith: did you guys reach any conclusion?18:47
jaypipescdent: dansmith18:47
jaypipes's out for a bit.18:47
* mriedem would love to hook up with a big ol' bag of anonymous dicts sometime18:48
*** code-R_ has quit IRC18:48
* cdent calls a data structure matchmaker for mriedem 18:50
mriedemalso, we need a release steward to coordinate with the release CPL about the outgoing PTL18:50
*** Apoorva_ has joined #openstack-nova18:51
cdentmriedem: i'm pretty sure there's a czar for that18:51
mriedemgood point18:52
bauzasmriedem: so, given I liked to be the release liaison, maybe I could help ?18:54
mriedembauzas: you must take the title of czar now18:55
mriedemit's required18:55
*** Apoorva has quit IRC18:55
*** zul_ has quit IRC18:55
bauzasmriedem: well, I'm a French :po18:55
*** hoangcx has joined #openstack-nova18:55
mriedembauzas: i was just joking, and making light of the ML thread on release stewards18:56
bauzasyup, I read that18:56
*** tonytan4ever has quit IRC18:56
*** akshai has quit IRC18:59
cdent jaypipes however we resolve this dict list thing, if we are going to be changing stuff we may as well do a sincere audit of all the request and response bodies and make sure we have consistency across the board. Or if not now, soon.18:59
jaypipescdent: you mean just the placement API, right? :)19:00
cdentjaypipes: well, yes19:01
cdentbut you know maybe the api-wg can make a czar for doing it across the _whole_ board19:01
jaypipescdent: k, just making sure :)19:01
*** sdake has quit IRC19:02
*** salv-orlando has quit IRC19:02
mriedemdict usage czar?19:03
*** raunak has quit IRC19:03
*** prateek has quit IRC19:04
*** lpetrut has quit IRC19:04
*** abalutoiu has joined #openstack-nova19:05
*** abalutoiu has quit IRC19:05
mriedemarmax: kevinbenton: were you guys going to try and get a requirements freeze FFE for https://review.openstack.org/#/c/365165/ ?19:05
*** abalutoiu has joined #openstack-nova19:05
armaxno19:05
armaxmriedem: I mean19:06
armaxI’d love to get this in19:06
armaxmriedem: but I thought you were going to champion and lobby for it :)19:06
armaxmriedem: you need to be backed up?19:06
mriedemoh dear19:06
armaxtechnically speaking the bug is with os-vif19:07
armaxwe’re good on our side :)19:07
armaxdo we have a communication breakdown here?19:07
mriedemwe need a nova/neutron CPL for the PTL19:08
mriedemarmax: i'll request the FFE19:08
armaxmriedem: sorry19:08
armaxmriedem: I thought this was on your plate19:08
*** annegentle has joined #openstack-nova19:09
*** TravT has quit IRC19:09
mriedemdone19:10
mriedemnp19:10
*** clenimar has quit IRC19:10
*** sdake has joined #openstack-nova19:10
*** zul has joined #openstack-nova19:12
*** prateek has joined #openstack-nova19:12
*** salv-orlando has joined #openstack-nova19:13
*** derekh_afk is now known as derekh19:13
*** su_zhang has joined #openstack-nova19:13
*** lucas-dinner has quit IRC19:13
*** lucasagomes has joined #openstack-nova19:15
*** Apoorva_ has quit IRC19:16
*** Apoorva has joined #openstack-nova19:16
*** Sukhdev_ has joined #openstack-nova19:17
*** fragatin_ has joined #openstack-nova19:17
*** su_zhang has quit IRC19:18
*** fragatina has quit IRC19:21
*** rcernin has quit IRC19:21
*** ducttape_ has quit IRC19:23
auggybauzas: i like "release gaucho" myself19:26
auggybauzas: then you can wear a cool hat19:27
*** ducttape_ has joined #openstack-nova19:27
*** TravT has joined #openstack-nova19:27
*** TravT has quit IRC19:28
*** mvk has joined #openstack-nova19:29
*** jvgrant has quit IRC19:29
*** _ducttape_ has joined #openstack-nova19:30
*** zul_ has joined #openstack-nova19:31
mriedemwznoinsk: should intel nfv ci be running on stable/liberty patches at all?19:33
mriedemwznoinsk: i noticed intel nfv ci failed pretty hard here https://review.openstack.org/#/c/358152/19:33
*** ducttape_ has quit IRC19:34
mriedemBobBall: citrix xenserver ci is failing devstack setup here http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/52/358152/1/check/dsvm-tempest-nova-network/9c13c23/logs/devstacklog.txt.gz19:34
mriedem^ is stable/liberty19:34
*** moshele has joined #openstack-nova19:37
*** _ducttape_ has quit IRC19:39
*** thorst has joined #openstack-nova19:39
*** ducttape_ has joined #openstack-nova19:40
*** hoangcx has quit IRC19:43
*** rama_y has joined #openstack-nova19:43
sdaguedansmith: what's the general approach / policy on __repr__ for nova objects?19:43
*** lpetrut has joined #openstack-nova19:45
cdentsdague: I had that question very early in the process of making resource provider objects, never figured it out19:45
*** thorst has quit IRC19:48
dansmithsdague: there is a general handler that tries to do something sane, but otherwise do whatever you want for each case19:49
dansmithsdague: by default it tries to use self.uuid or self.id, which almost all of our objects have19:49
dansmithsdague: same thing I told cdent when he asked the first time :)19:50
sdaguedansmith: ok, the object lists seem to be a little odd19:50
*** lpetrut has quit IRC19:50
sdaguelet me propose a thing19:50
sdaguewhich makes some of the debug a bit simpler19:50
cdentI should clarify: I never understood clearly what should be done...19:51
dansmithsdague: I think object lists should be just a repr that does a list of reprs, but if not.. by all means19:51
sdaguedansmith: it doesn't seem to call the repr nested19:51
dansmithsdague: okay I'm looking19:51
*** annegentle has quit IRC19:51
dansmithsdague: hmm, yeah not set on o.vo.. we might've lost that in the transition or something19:52
dansmithor maybe I'm full of it19:52
sdaguedansmith: ok, so the behavior you suggest is the one I want19:52
sdagueglad I'm not crazy in thinking that it should be there19:52
*** tonytan4ever has joined #openstack-nova19:53
sdagueI'll do a thing in the morning, it's nearly end of day here, and I have a meeting soon19:53
*** fragatin_ has quit IRC19:53
dansmithsdague: not for this reason, no19:53
*** fragatina has joined #openstack-nova19:54
cdentDo we have an existing process for commenting on existing code and talking about it? Or is the general way to talk about alternative things, to commit something for review?19:54
cdentThe latter is often too heavyweight19:55
*** Apoorva_ has joined #openstack-nova19:58
*** _ducttape_ has joined #openstack-nova19:59
*** lpetrut has joined #openstack-nova20:00
*** raunak has joined #openstack-nova20:01
*** jaypipes has quit IRC20:01
*** Apoorva has quit IRC20:01
*** rama_y has quit IRC20:02
*** ducttape_ has quit IRC20:02
*** openstackgerrit has quit IRC20:04
*** BjoernT has quit IRC20:04
*** openstackgerrit has joined #openstack-nova20:04
*** abalutoiu_ has joined #openstack-nova20:09
*** cdent has quit IRC20:09
*** salv-orlando has quit IRC20:10
*** tri2sing has quit IRC20:12
*** abalutoiu has quit IRC20:12
*** rfolco has quit IRC20:15
mriedemSwami: i'm not understanding something in the new test in https://review.openstack.org/#/c/275073/4420:16
mriedemwith the assertRaises20:16
Swamiyes20:16
mriedemsdague: dansmith: we talked about repr on list objects a long time ago, workaround in nova was doing list(listobj) in the nova log calls, but we had talked about making that native in the object list base class in ovo20:17
Swamimriedem: what is your question20:17
dansmithmriedem: ack20:17
sdaguemriedem: yeh,20:17
mriedemSwami: it looks like you're asserting that the mock raises the exception from the side_effect, which is redundant20:17
sdaguethat seems about like I would expect20:17
mriedemthat's like saying mock.foo = 'bar'; self.assertEqual('bar', mock.foo)20:18
*** syjulian_ has joined #openstack-nova20:18
*** salv-orlando has joined #openstack-nova20:18
mriedemSwami: in other words, why isn't the assertRaises on _update_port_with_migration_profile in the test?20:18
mriedemsince _update_port_with_migration_profile should reraise the exception20:18
Swamimriedem: let me take look at it20:18
Swamisince update_port is the one that raises the exception I have captured it in that way.20:19
mriedemSwami: but your update_port mock raises the exception b/c you tell it to with the side_effect20:21
mriedemso asserting that calling your mock raises the exception isn't helpful for the test20:21
mriedemSwami: i've got some comments inline in the test20:21
Swamiok will check it out20:22
mriedemi will pull this down and tinker with it also20:23
Swamithanks20:23
*** su_zhang has joined #openstack-nova20:23
*** moshele has quit IRC20:23
openstackgerritKenneth Burger proposed openstack/nova: Increase BDM column in build_requests table  https://review.openstack.org/36695520:25
*** anush has joined #openstack-nova20:25
*** derekh has quit IRC20:25
burgerkmriedem: alaski:  https://review.openstack.org/#/c/36695520:26
dansmithsdague: so the most important thing we still have pending is this: https://review.openstack.org/#/c/365068/20:27
dansmithsdague: and you were +2 before, I added the warning you wanted20:27
dansmithsdague: we have other more important stuff, but that one is at the bottom of a stack and arguably the most important right now20:27
alaskiburgerk: you need to add a new migration rather than modifying an existing one. Some people have already deployed that migration and wouldn't get your change20:27
dansmithsdague: so now or tomorrow morning if you could hit that agin that'd be cool20:28
burgerkalaski: ok20:28
sdaguedansmith: ok, can we get that warning in there?20:28
dansmithsdague: I was just saying I did that20:28
mriedemalaski: better get your -1 credit :)20:29
dansmithsdague: https://review.openstack.org/#/c/365068/8/nova/objects/resource_provider.py L33520:29
*** lpetrut has quit IRC20:29
sdaguedansmith: oh, sorry, I didn't scroll down enough there20:29
alaskimriedem: heh. gotta rack up them points20:29
sdagueI was expecting it up further, my bad20:29
*** salv-orl_ has joined #openstack-nova20:29
dansmithsdague: yeah I had to plumb it down low so we can use the same thing for notifications and not be blocking transactions for rpc calls :)20:29
mriedemalaski: if you get enough, you can turn them in for googly eyes at the ticket counter20:30
dansmithor plumb it up high? I dunno.. plumbing was involved.20:30
mriedemor a switchblade comb20:30
dansmithmriedem: lol20:30
mriedemSwami: i've got the test cleanup, just verifying it locally and then will push up and +220:30
sdaguedansmith: ok, yeh, I'll probably tweak the message later with the actually capacity / usage20:30
Swamimriedem: thanks, great20:30
sdaguebut I think this is fine20:31
sdaguefor first go20:31
sdagueat least you get some indication that things are wrong20:31
dansmithsdague: okay, I guess we'll want that in the notification anyway20:31
dansmithsdague: so we can do that when we add the notification20:31
mriedemalaski: is there a cellsv2 meeting in 28 minutes?20:32
dansmithI sure hope not20:32
alaskimriedem: not today20:32
*** rama_y has joined #openstack-nova20:32
dansmithwoot20:32
dansmithif I have to be in a confined space with other people right now, I may bite.20:32
mriedemalaski: ok every other week now?20:32
mriedemi forgot20:32
alaskimriedem: yep. until we officially open O there's not much to discuss20:33
*** salv-orlando has quit IRC20:33
dansmithsdague: I wrote tests for the log thing.. you okay with me +Wing that? or should I find someone else?20:33
dansmithwell, and wrote the log thing itself, but...20:33
openstackgerritMatt Riedemann proposed openstack/nova: Implement setup_networks_on_host for Neutron networks  https://review.openstack.org/27507320:35
sdagueI'm fine with it20:35
sdaguejay was +2 earlier20:35
*** thorst has joined #openstack-nova20:35
mriedemSwami: now you just have to bribe all of the other nova cores for the next week20:36
*** BjoernT has joined #openstack-nova20:37
Swamimriedem: thanks, will you be able to ping others to add another +2.20:37
mriedemum20:37
mriedemwell,20:37
mriedemjohnthetubaguy would probably be the next best to look at it given he's been in the neutronv2 api code a lot recently20:37
mriedembut i'm not going to probably actively lobby him20:38
Swamimriedem: ok, I will look for him20:38
mriedemhe's sure to be out tubaing in the streets of england right about now20:38
mriedemdriving the neighbors crazy20:38
Swamimriedem: Let me check with him when he comes on line.20:39
*** roeyc has joined #openstack-nova20:40
*** _ducttape_ has quit IRC20:40
*** ducttape_ has joined #openstack-nova20:41
*** BjoernT has quit IRC20:41
*** thorst has quit IRC20:42
*** ociuhandu has quit IRC20:43
openstackgerritDoug Hellmann proposed openstack/python-novaclient: Update reno for stable/newton  https://review.openstack.org/36695920:43
openstackgerritDoug Hellmann proposed openstack/python-novaclient: Update reno for stable/newton  https://review.openstack.org/36695920:45
*** GB21 has quit IRC20:46
dansmithsdague: okay20:48
*** prateek_ has joined #openstack-nova20:49
*** Apoorva_ has quit IRC20:49
*** gongysh has joined #openstack-nova20:49
mriedemalaski: what are you thinking for a test on burgerk's db migration? just that the column type is changed? or also trying to insert >16Kb of data into it?20:49
*** Apoorva has joined #openstack-nova20:50
dansmiththe former20:50
alaskimriedem: yeah, just that the column type changed20:50
dansmithwe don't really test schema stuff20:50
*** rtheis has joined #openstack-nova20:50
*** rrecio has quit IRC20:50
dansmiththe migration walk tests were really for when we migrated data20:50
dansmithmaybe insert something in there and make sure it's still there post-migrate,20:50
dansmithbut otherwise that's all I think20:50
*** vishwana_ has joined #openstack-nova20:51
alaskimriedem: mostly it's that the tests will fail if a new migration is added and no check is added for it20:51
dansmithi.e. to make sure we didn't do a DROP;ADD20:51
*** liangy has quit IRC20:51
*** ociuhandu has joined #openstack-nova20:51
mriedemdansmith: yeah that would be a decent test20:52
*** vishwanathj has quit IRC20:52
*** prateek has quit IRC20:52
*** rtheis_ has quit IRC20:52
*** parora has joined #openstack-nova20:52
openstackgerritDoug Hellmann proposed openstack/os-vif: Update reno for stable/newton  https://review.openstack.org/36311520:53
*** prateek_ has quit IRC20:55
sdaguedansmith: you mean, we shouldn't test the schema stuff20:55
sdaguethe test infrastruction in oslo.db requires it20:55
dansmithsdague: was that a question?20:55
*** _ducttape_ has joined #openstack-nova20:55
sdagueit's just silly to test that sqla works :)20:56
dansmithsdague: should I fix this nit? https://review.openstack.org/#/c/366186/3/nova/api/openstack/placement/handlers/allocation.py20:57
sdaguedansmith: if you like, if you don't I was going to do the repr for the list instead20:57
sdagueand put that into there20:57
sdaguethat's part of what triggered my interest in list repr20:57
dansmithsdague: oh okay was just trying to clear the list20:57
dansmithgotcha20:57
sdaguedansmith: either way, I'll work on that patch when I wake up in the morning20:58
dansmithsdague: okay cool20:58
*** ducttape_ has quit IRC20:59
*** ssurana1 has joined #openstack-nova21:03
*** liangy has joined #openstack-nova21:03
*** ssurana has quit IRC21:06
*** _ducttape_ has quit IRC21:06
*** ociuhandu has quit IRC21:08
*** krtaylor has quit IRC21:11
*** roeyc has quit IRC21:11
*** ducttape_ has joined #openstack-nova21:12
openstackgerritDoug Hellmann proposed openstack/python-novaclient: Update reno for stable/newton  https://review.openstack.org/36495421:12
*** mdrabe has quit IRC21:14
*** mdrabe has joined #openstack-nova21:14
*** rtheis_ has joined #openstack-nova21:14
*** mmedvede has quit IRC21:15
*** rtheis has quit IRC21:16
openstackgerritDoug Hellmann proposed openstack/os-vif: Update reno for stable/newton  https://review.openstack.org/36311521:18
*** BjoernT has joined #openstack-nova21:19
*** edmondsw has quit IRC21:19
openstackgerritDoug Hellmann proposed openstack/os-vif: Update reno for stable/newton  https://review.openstack.org/36311521:19
*** jheroux has quit IRC21:27
*** lpetrut has joined #openstack-nova21:30
*** ducttape_ has quit IRC21:31
*** abalutoiu has joined #openstack-nova21:32
*** syjulian_ has quit IRC21:33
*** roeyc has joined #openstack-nova21:34
*** abalutoiu_ has quit IRC21:34
*** kfarr has quit IRC21:34
*** roeyc has quit IRC21:34
*** ducttape_ has joined #openstack-nova21:36
*** hemna is now known as hemnafk21:37
*** su_zhang has quit IRC21:37
*** rtheis_ has quit IRC21:37
*** syjulian_ has joined #openstack-nova21:37
*** su_zhang has joined #openstack-nova21:38
*** su_zhang has quit IRC21:38
*** su_zhang has joined #openstack-nova21:38
*** thorst has joined #openstack-nova21:40
*** mmedvede has joined #openstack-nova21:41
*** mriedem has quit IRC21:41
*** claudiub|2 has quit IRC21:42
*** ducttape_ has quit IRC21:43
*** thorst has quit IRC21:48
*** Swami has quit IRC21:48
*** krtaylor has joined #openstack-nova21:53
*** su_zhang has quit IRC22:01
*** BjoernT has quit IRC22:02
*** ducttape_ has joined #openstack-nova22:03
*** gongysh has quit IRC22:03
*** burt has quit IRC22:04
*** rama_y has quit IRC22:04
*** su_zhang has joined #openstack-nova22:05
*** mfedosin has quit IRC22:07
*** tonytan4ever has quit IRC22:10
*** rama_y has joined #openstack-nova22:10
*** ducttape_ has quit IRC22:12
*** jamesdenton has quit IRC22:13
*** nic has quit IRC22:14
*** nic has joined #openstack-nova22:15
openstackgerritSivasathurappan Radhakrishnan proposed openstack/nova: Using get() method to prevent KeyError  https://review.openstack.org/35942422:16
*** baoli_ has joined #openstack-nova22:17
*** baoli has quit IRC22:18
*** prateek_ has joined #openstack-nova22:18
*** ducttape_ has joined #openstack-nova22:19
*** tblakes has quit IRC22:19
*** burgerk_ has joined #openstack-nova22:19
*** lpetrut has quit IRC22:19
*** kevinz has joined #openstack-nova22:21
*** parora has quit IRC22:21
*** rama_y has quit IRC22:22
*** burgerk has quit IRC22:22
*** parora has joined #openstack-nova22:23
*** su_zhang has quit IRC22:23
*** burgerk_ has quit IRC22:24
*** sdake has quit IRC22:24
*** prateek_ has quit IRC22:25
*** kevinz has quit IRC22:26
*** BjoernT has joined #openstack-nova22:26
*** BjoernT has quit IRC22:26
*** dimtruck is now known as zz_dimtruck22:27
*** gongysh has joined #openstack-nova22:27
*** akshai has joined #openstack-nova22:30
*** fragatin_ has joined #openstack-nova22:34
*** abalutoiu has quit IRC22:36
*** fragatina has quit IRC22:37
*** mdrabe has quit IRC22:39
*** Guest10379 has quit IRC22:39
*** prateek_ has joined #openstack-nova22:39
*** mdrabe has joined #openstack-nova22:43
*** parora has quit IRC22:43
*** mlavalle has quit IRC22:46
*** ducttape_ has quit IRC22:48
*** thorst has joined #openstack-nova22:48
*** mdrabe has quit IRC22:51
*** thorst has quit IRC22:53
*** baoli_ has quit IRC22:54
*** zz_dimtruck is now known as dimtruck22:54
*** xyang1 has quit IRC22:55
*** ducttape_ has joined #openstack-nova22:55
*** pradk has quit IRC22:56
*** fragatin_ has quit IRC22:57
*** marst has quit IRC22:57
*** armax has quit IRC22:58
*** itlinux has joined #openstack-nova22:58
*** gouthamr has quit IRC22:58
*** harlowja has quit IRC23:03
*** gongysh has quit IRC23:08
*** syjulian_ has quit IRC23:09
*** itlinux has quit IRC23:10
*** tonytan4ever has joined #openstack-nova23:10
*** yamahata has quit IRC23:11
*** nic has quit IRC23:12
*** marst has joined #openstack-nova23:12
*** sdague has quit IRC23:12
*** tonytan4ever has quit IRC23:15
*** salv-orl_ has quit IRC23:16
*** salv-orlando has joined #openstack-nova23:17
*** ducttape_ has quit IRC23:17
*** beagles has left #openstack-nova23:18
*** salv-orlando has quit IRC23:21
*** akshai has quit IRC23:23
openstackgerritSivasathurappan Radhakrishnan proposed openstack/nova: Add image_meta when unshelving volume backend vm  https://review.openstack.org/34706323:23
*** akshai has joined #openstack-nova23:24
*** diogogmt has quit IRC23:24
*** akshai has quit IRC23:25
*** anush has quit IRC23:26
*** claudiub|2 has joined #openstack-nova23:28
*** gouthamr has joined #openstack-nova23:34
*** gouthamr_ has joined #openstack-nova23:34
*** yamahata has joined #openstack-nova23:38
*** gouthamr has quit IRC23:38
*** gmann has joined #openstack-nova23:38
*** Swami has joined #openstack-nova23:40
*** tonytan4ever has joined #openstack-nova23:45
*** edmondsw has joined #openstack-nova23:46
*** ducttape_ has joined #openstack-nova23:46
*** ducttape_ has quit IRC23:48
*** ducttape_ has joined #openstack-nova23:48
*** akshai has joined #openstack-nova23:49
*** edmondsw has quit IRC23:49
*** armax has joined #openstack-nova23:50
*** thorst has joined #openstack-nova23:50
*** rfolco has joined #openstack-nova23:57
*** prateek_ has quit IRC23:57
*** akshai has quit IRC23:57
*** rfolco has quit IRC23:58
*** thorst has quit IRC23:58
*** rfolco has joined #openstack-nova23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!