*** browne has quit IRC | 00:01 | |
*** gmann_ has joined #openstack-nova | 00:01 | |
*** gmann has quit IRC | 00:02 | |
*** thorst_ has joined #openstack-nova | 00:06 | |
*** ducttape_ has joined #openstack-nova | 00:07 | |
*** esberglu has joined #openstack-nova | 00:09 | |
*** ducttape_ has quit IRC | 00:11 | |
*** ducttape_ has joined #openstack-nova | 00:11 | |
*** thorst_ has quit IRC | 00:16 | |
*** thorst_ has joined #openstack-nova | 00:17 | |
*** esberglu has quit IRC | 00:19 | |
*** hongbin has quit IRC | 00:20 | |
*** nic has quit IRC | 00:21 | |
diana_clarke | oh man, two new poison warnings slipped in... | 00:22 |
---|---|---|
*** tbachman_ has joined #openstack-nova | 00:23 | |
*** tbachman has quit IRC | 00:23 | |
*** tbachman_ is now known as tbachman | 00:23 | |
*** diogogmt has quit IRC | 00:23 | |
*** ayoung has quit IRC | 00:24 | |
*** thorst_ has quit IRC | 00:25 | |
*** stewie925 has quit IRC | 00:29 | |
*** mnestratov has quit IRC | 00:34 | |
*** artom has quit IRC | 00:39 | |
*** artom has joined #openstack-nova | 00:40 | |
*** jwcroppe has joined #openstack-nova | 00:42 | |
openstackgerrit | zhongshengping proposed openstack/nova: Update method cfg.set_defaults https://review.openstack.org/395877 | 00:42 |
*** jerrygb has quit IRC | 00:48 | |
*** jerrygb has joined #openstack-nova | 00:49 | |
*** jerrygb has quit IRC | 00:49 | |
*** jerrygb has joined #openstack-nova | 00:49 | |
*** stewie925 has joined #openstack-nova | 00:58 | |
stewie925 | gibi: hi | 00:59 |
*** hoangcx has joined #openstack-nova | 01:01 | |
*** hoangcx_ has joined #openstack-nova | 01:02 | |
*** womygod has joined #openstack-nova | 01:02 | |
*** smatzek has joined #openstack-nova | 01:04 | |
*** xinliang has quit IRC | 01:07 | |
*** afazekas_ has quit IRC | 01:08 | |
*** xinliang has joined #openstack-nova | 01:08 | |
*** Sukhdev has quit IRC | 01:14 | |
*** ducttape_ has quit IRC | 01:14 | |
*** ducttape_ has joined #openstack-nova | 01:14 | |
*** mriedem has joined #openstack-nova | 01:15 | |
*** diogogmt has joined #openstack-nova | 01:17 | |
*** rfolco_ has quit IRC | 01:18 | |
*** ijw has quit IRC | 01:18 | |
*** jschlueter has quit IRC | 01:18 | |
*** Swami_ has quit IRC | 01:18 | |
*** ducttape_ has quit IRC | 01:19 | |
*** Swami_ has joined #openstack-nova | 01:21 | |
*** gouthamr has quit IRC | 01:21 | |
*** gouthamr has joined #openstack-nova | 01:22 | |
*** ircuser-1 has quit IRC | 01:22 | |
*** ducttape_ has joined #openstack-nova | 01:22 | |
*** thorst_ has joined #openstack-nova | 01:23 | |
*** ijw has joined #openstack-nova | 01:24 | |
*** thorst_ has quit IRC | 01:26 | |
*** thorst_ has joined #openstack-nova | 01:27 | |
mriedem | mdbooth: https://review.openstack.org/#/c/395887/ | 01:28 |
mriedem | that disables the volume snapshot/clone tests in the devstack-plugin-nfs job | 01:28 |
mriedem | eharney: ^ | 01:28 |
*** Zer0Byte__ has quit IRC | 01:28 | |
*** tuanluong has joined #openstack-nova | 01:30 | |
*** gouthamr has quit IRC | 01:34 | |
openstackgerrit | Dao Cong Tien proposed openstack/nova: Fix hypervisor-stats show invalid info of baremetal resource https://review.openstack.org/391415 | 01:38 |
*** yamahata has quit IRC | 01:40 | |
*** zhangyufei has joined #openstack-nova | 01:44 | |
*** yuntongjin has joined #openstack-nova | 01:45 | |
*** vilobhmm11 has joined #openstack-nova | 01:46 | |
*** tblakes has quit IRC | 01:49 | |
*** vilobhmm111 has joined #openstack-nova | 01:51 | |
*** vilobhmm11 has quit IRC | 01:52 | |
*** smatzek has quit IRC | 01:54 | |
*** stewie925 has quit IRC | 01:58 | |
*** Apoorva has quit IRC | 02:04 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: WIP: Transform requested secgroup names to uuids https://review.openstack.org/395747 | 02:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Rename security_group parameter in compute.API:create https://review.openstack.org/395746 | 02:15 |
*** sree has joined #openstack-nova | 02:16 | |
*** gcb has joined #openstack-nova | 02:16 | |
*** zhangyufei has quit IRC | 02:17 | |
*** zhangyufei has joined #openstack-nova | 02:18 | |
*** zhangyufei has quit IRC | 02:18 | |
*** sree has quit IRC | 02:20 | |
*** artom has quit IRC | 02:22 | |
*** Swami__ has joined #openstack-nova | 02:23 | |
*** artom has joined #openstack-nova | 02:23 | |
*** takashin has quit IRC | 02:24 | |
*** mriedem has quit IRC | 02:25 | |
*** takashin has joined #openstack-nova | 02:26 | |
*** zhangyufei has joined #openstack-nova | 02:26 | |
*** Swami has quit IRC | 02:26 | |
*** unicell has quit IRC | 02:31 | |
*** houming has joined #openstack-nova | 02:35 | |
*** amotoki has joined #openstack-nova | 02:35 | |
*** zhangyufei has quit IRC | 02:37 | |
*** zhangyufei has joined #openstack-nova | 02:38 | |
*** Swami__ has quit IRC | 02:45 | |
*** Swami_ has quit IRC | 02:45 | |
openstackgerrit | zhaolihui proposed openstack/nova: Fix to rebuild vm not with the specified image https://review.openstack.org/395908 | 02:45 |
*** gmann_ has quit IRC | 02:50 | |
*** jwcroppe has quit IRC | 02:55 | |
*** jwcroppe has joined #openstack-nova | 02:55 | |
*** tlian has quit IRC | 03:12 | |
*** amotoki has quit IRC | 03:12 | |
*** tlian has joined #openstack-nova | 03:28 | |
*** prashkre has joined #openstack-nova | 03:30 | |
*** siva has joined #openstack-nova | 03:30 | |
*** vilobhmm111 has quit IRC | 03:31 | |
*** fragatin_ has joined #openstack-nova | 03:32 | |
*** jerrygb has quit IRC | 03:33 | |
*** fragatina has quit IRC | 03:35 | |
*** siva_ has joined #openstack-nova | 03:35 | |
*** fragatina has joined #openstack-nova | 03:36 | |
*** fragatin_ has quit IRC | 03:37 | |
*** siva has quit IRC | 03:37 | |
*** siva_ is now known as siva | 03:37 | |
*** gmann has joined #openstack-nova | 03:38 | |
*** yuntongjin has quit IRC | 03:40 | |
*** fragatina has quit IRC | 03:40 | |
*** prashkre has quit IRC | 03:48 | |
*** yuntongjin has joined #openstack-nova | 03:49 | |
*** nicolasbock has quit IRC | 03:50 | |
*** yuntongjin has quit IRC | 03:51 | |
*** bks has joined #openstack-nova | 03:53 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add flavor extra_spec info link to api_ref https://review.openstack.org/395925 | 03:55 |
*** kumarb has joined #openstack-nova | 03:58 | |
*** bks has quit IRC | 03:59 | |
*** siva has quit IRC | 04:00 | |
*** siva has joined #openstack-nova | 04:02 | |
*** zhangyufei has quit IRC | 04:03 | |
*** kumarb has quit IRC | 04:03 | |
*** afazekas has joined #openstack-nova | 04:04 | |
*** manasm has joined #openstack-nova | 04:06 | |
*** dikonoor has joined #openstack-nova | 04:07 | |
*** thorst_ has quit IRC | 04:08 | |
*** thorst_ has joined #openstack-nova | 04:08 | |
*** prateek has joined #openstack-nova | 04:10 | |
*** GB21 has joined #openstack-nova | 04:13 | |
*** vilobhmm11 has joined #openstack-nova | 04:17 | |
*** sree has joined #openstack-nova | 04:17 | |
*** thorst_ has quit IRC | 04:17 | |
*** coolsvap has joined #openstack-nova | 04:18 | |
*** sree has quit IRC | 04:21 | |
*** rama_y has joined #openstack-nova | 04:21 | |
*** vilobhmm11 has quit IRC | 04:21 | |
*** vilobhmm11 has joined #openstack-nova | 04:22 | |
*** links has joined #openstack-nova | 04:23 | |
*** vilobhmm11 has quit IRC | 04:23 | |
*** manasm has quit IRC | 04:27 | |
*** jerrygb has joined #openstack-nova | 04:34 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add flavor extra_spec info link to api_ref https://review.openstack.org/395925 | 04:37 |
*** jerrygb has quit IRC | 04:39 | |
*** prashkre has joined #openstack-nova | 04:39 | |
*** ducttape_ has quit IRC | 04:39 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add flavor extra_spec info link to api_ref https://review.openstack.org/395925 | 04:41 |
*** hoangcx_ has quit IRC | 04:42 | |
*** cfriesen has quit IRC | 04:47 | |
*** garyk1 has joined #openstack-nova | 04:48 | |
*** yuntongjin has joined #openstack-nova | 04:49 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add flavor extra_spec info link to api_ref https://review.openstack.org/395925 | 04:50 |
*** rama_y has quit IRC | 04:55 | |
*** browne has joined #openstack-nova | 04:58 | |
*** ijw has quit IRC | 05:02 | |
*** zhangyufei has joined #openstack-nova | 05:02 | |
*** Sukhdev has joined #openstack-nova | 05:05 | |
*** gmann has quit IRC | 05:05 | |
*** dikonoor has quit IRC | 05:08 | |
*** GB21 has quit IRC | 05:10 | |
*** manasm has joined #openstack-nova | 05:14 | |
*** thorst_ has joined #openstack-nova | 05:15 | |
*** zhangyufei has quit IRC | 05:17 | |
*** unicell has joined #openstack-nova | 05:17 | |
*** siva has quit IRC | 05:19 | |
*** thorst_ has quit IRC | 05:22 | |
*** GB21 has joined #openstack-nova | 05:22 | |
*** noama has quit IRC | 05:24 | |
*** noama has joined #openstack-nova | 05:25 | |
*** gmann has joined #openstack-nova | 05:30 | |
*** Apoorva has joined #openstack-nova | 05:31 | |
*** browne has quit IRC | 05:33 | |
*** dave-mccowan has quit IRC | 05:35 | |
*** shaohe_feng has quit IRC | 05:35 | |
*** shaohe_feng has joined #openstack-nova | 05:36 | |
*** liverpooler has quit IRC | 05:36 | |
*** tlian has quit IRC | 05:40 | |
*** ljxiash has joined #openstack-nova | 05:40 | |
openstackgerrit | Michael Still proposed openstack/nova-specs: Spec for continued vendordata work in Ocata. https://review.openstack.org/395959 | 05:40 |
*** sahid has joined #openstack-nova | 05:43 | |
*** sandanar has joined #openstack-nova | 05:44 | |
*** amotoki has joined #openstack-nova | 05:45 | |
*** jaosorior has joined #openstack-nova | 05:51 | |
*** zhangyufei has joined #openstack-nova | 05:52 | |
*** Apoorva has quit IRC | 05:52 | |
*** sree has joined #openstack-nova | 05:56 | |
*** lpetrut has joined #openstack-nova | 06:04 | |
*** gmann_ has joined #openstack-nova | 06:05 | |
*** gmann has quit IRC | 06:06 | |
*** gmann has joined #openstack-nova | 06:07 | |
*** GB21 has quit IRC | 06:10 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add flavor extra_spec info link to api_ref https://review.openstack.org/395925 | 06:10 |
*** gmann_ has quit IRC | 06:10 | |
*** ducttape_ has joined #openstack-nova | 06:10 | |
*** gmann has quit IRC | 06:12 | |
*** sree has quit IRC | 06:15 | |
*** ducttape_ has quit IRC | 06:15 | |
*** sridharg has joined #openstack-nova | 06:15 | |
*** sree has joined #openstack-nova | 06:15 | |
*** ratailor has joined #openstack-nova | 06:16 | |
*** rcernin has joined #openstack-nova | 06:17 | |
*** gmann has joined #openstack-nova | 06:18 | |
*** sahid has quit IRC | 06:19 | |
*** sree has quit IRC | 06:20 | |
*** Dong_Zhi_ has joined #openstack-nova | 06:21 | |
*** thorst_ has joined #openstack-nova | 06:21 | |
*** Sukhdev has quit IRC | 06:23 | |
*** dikonoor has joined #openstack-nova | 06:23 | |
*** GB21 has joined #openstack-nova | 06:24 | |
*** sree has joined #openstack-nova | 06:27 | |
*** thorst_ has quit IRC | 06:27 | |
*** gb21_ has joined #openstack-nova | 06:30 | |
*** sree has quit IRC | 06:31 | |
*** harlowja_ has quit IRC | 06:33 | |
*** sree has joined #openstack-nova | 06:34 | |
*** GB21 has quit IRC | 06:34 | |
*** jaosorior has quit IRC | 06:34 | |
*** jaosorior has joined #openstack-nova | 06:34 | |
*** jerrygb has joined #openstack-nova | 06:35 | |
*** Dong_Zhi_ has quit IRC | 06:36 | |
*** Hosam has joined #openstack-nova | 06:39 | |
openstackgerrit | zhaolihui proposed openstack/nova: Fix failed to boot vm with pci_alias's name including space https://review.openstack.org/392077 | 06:39 |
*** Hosam_ has joined #openstack-nova | 06:41 | |
*** jerrygb has quit IRC | 06:42 | |
*** gmann has quit IRC | 06:42 | |
*** gmann has joined #openstack-nova | 06:42 | |
*** kamtamtun has joined #openstack-nova | 06:42 | |
openstackgerrit | Prateek Arora proposed openstack/nova: Correct wrong max_unit in placement inventory https://review.openstack.org/395971 | 06:44 |
*** madhaviy has joined #openstack-nova | 06:44 | |
*** Hosam has quit IRC | 06:45 | |
*** lpetrut has quit IRC | 06:45 | |
*** gb21_ has quit IRC | 06:47 | |
openstackgerrit | Prateek Arora proposed openstack/nova: Correct wrong max_unit in placement inventory https://review.openstack.org/395971 | 06:50 |
*** pcaruana has joined #openstack-nova | 06:51 | |
*** ekuris has joined #openstack-nova | 06:52 | |
*** rcernin has quit IRC | 06:56 | |
*** rcernin has joined #openstack-nova | 06:56 | |
*** lbrune has joined #openstack-nova | 07:01 | |
*** oanson has joined #openstack-nova | 07:03 | |
*** gmann_ has joined #openstack-nova | 07:03 | |
*** GB21 has joined #openstack-nova | 07:03 | |
*** gmann has quit IRC | 07:04 | |
*** ducnc has joined #openstack-nova | 07:04 | |
*** gmann has joined #openstack-nova | 07:09 | |
*** gmann_ has quit IRC | 07:09 | |
*** owalsh has quit IRC | 07:13 | |
*** GB21 has quit IRC | 07:16 | |
*** lpetrut has joined #openstack-nova | 07:17 | |
*** tesseract has joined #openstack-nova | 07:20 | |
*** tesseract is now known as Guest40216 | 07:20 | |
*** yamahata has joined #openstack-nova | 07:21 | |
*** belmoreira has joined #openstack-nova | 07:26 | |
*** esberglu has joined #openstack-nova | 07:27 | |
*** ihrachys has joined #openstack-nova | 07:28 | |
*** xinliang has quit IRC | 07:28 | |
*** prashkre has quit IRC | 07:29 | |
*** lpetrut has quit IRC | 07:30 | |
*** esberglu has quit IRC | 07:31 | |
*** ducttape_ has joined #openstack-nova | 07:41 | |
*** xinliang has joined #openstack-nova | 07:42 | |
*** ihrachys has quit IRC | 07:42 | |
*** ducttape_ has quit IRC | 07:45 | |
*** ihrachys has joined #openstack-nova | 07:47 | |
*** openstackgerrit has quit IRC | 07:48 | |
*** openstackgerrit has joined #openstack-nova | 07:48 | |
*** pbandark has joined #openstack-nova | 07:49 | |
*** gmann has quit IRC | 07:49 | |
*** lbrune has quit IRC | 07:50 | |
*** gmann has joined #openstack-nova | 07:50 | |
*** manasm has quit IRC | 07:52 | |
*** prashkre has joined #openstack-nova | 07:52 | |
*** andreas_s has joined #openstack-nova | 07:52 | |
*** RuiChen has joined #openstack-nova | 07:54 | |
*** ihrachys has quit IRC | 07:57 | |
*** abalutoiu has joined #openstack-nova | 07:57 | |
*** armax has quit IRC | 08:01 | |
*** markus_z has joined #openstack-nova | 08:04 | |
*** lbrune has joined #openstack-nova | 08:07 | |
*** yuntongjin has quit IRC | 08:11 | |
*** hoangcx has quit IRC | 08:13 | |
*** moshele has joined #openstack-nova | 08:16 | |
*** hoangcx has joined #openstack-nova | 08:17 | |
*** unicell has quit IRC | 08:21 | |
*** unicell has joined #openstack-nova | 08:21 | |
*** manasm has joined #openstack-nova | 08:21 | |
*** yuntongjin has joined #openstack-nova | 08:21 | |
*** gmann has quit IRC | 08:22 | |
*** ralonsoh has joined #openstack-nova | 08:26 | |
*** esberglu has joined #openstack-nova | 08:26 | |
*** thorst_ has joined #openstack-nova | 08:28 | |
*** alexchadin has joined #openstack-nova | 08:31 | |
*** esberglu has quit IRC | 08:31 | |
*** zenoway has joined #openstack-nova | 08:31 | |
*** preethipy has joined #openstack-nova | 08:31 | |
*** vladikr has quit IRC | 08:33 | |
*** vladikr has joined #openstack-nova | 08:33 | |
*** Hosam_ has quit IRC | 08:34 | |
*** mlakat has joined #openstack-nova | 08:34 | |
*** danpb has joined #openstack-nova | 08:35 | |
*** thorst_ has quit IRC | 08:37 | |
openstackgerrit | int32bit proposed openstack/nova: Raise exception when delete disabled terminate vm https://review.openstack.org/396017 | 08:37 |
*** brault_ has quit IRC | 08:38 | |
*** jerrygb has joined #openstack-nova | 08:38 | |
*** Hosam has joined #openstack-nova | 08:40 | |
*** ducttape_ has joined #openstack-nova | 08:42 | |
*** jerrygb has quit IRC | 08:44 | |
*** lpetrut has joined #openstack-nova | 08:45 | |
*** ducttape_ has quit IRC | 08:46 | |
*** portdirect_away has quit IRC | 08:50 | |
*** Hosam has quit IRC | 08:51 | |
*** rnoriega is now known as rnoriega|TEF | 08:51 | |
*** rnoriega|TEF is now known as rnoriega | 08:51 | |
*** Hosam_ has joined #openstack-nova | 08:51 | |
*** GB21 has joined #openstack-nova | 08:57 | |
*** mnestratov has joined #openstack-nova | 08:57 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs: Strict filter and sort_key query parameters for server list API https://review.openstack.org/393205 | 08:57 |
*** GB21 has quit IRC | 08:57 | |
*** GB21 has joined #openstack-nova | 08:57 | |
*** zzzeek has quit IRC | 09:00 | |
*** zzzeek has joined #openstack-nova | 09:01 | |
*** unicell1 has joined #openstack-nova | 09:19 | |
*** unicell has quit IRC | 09:21 | |
*** esberglu has joined #openstack-nova | 09:21 | |
openstackgerrit | Lee Yarwood proposed openstack/nova: encryptors: Introduce encryption provider constants https://review.openstack.org/393901 | 09:22 |
*** lucas-afk is now known as lucasagomes | 09:23 | |
*** Hosam_ has quit IRC | 09:25 | |
*** esberglu has quit IRC | 09:26 | |
*** Dong_Zhi_ has joined #openstack-nova | 09:28 | |
*** yamahata has quit IRC | 09:31 | |
*** Dong_Zhi_ has quit IRC | 09:31 | |
*** Dong_Zhi_ has joined #openstack-nova | 09:32 | |
lyarwood | johnthetubaguy: morning, if you have time this morning I'd appreciate a review of https://review.openstack.org/#/c/386670/ , already +2 from danpb, might need a releasenote but aside from that it should be good to go. | 09:33 |
*** lpetrut has quit IRC | 09:34 | |
*** thorst_ has joined #openstack-nova | 09:35 | |
*** manasm has quit IRC | 09:35 | |
*** shihanzhang has joined #openstack-nova | 09:35 | |
*** manasm has joined #openstack-nova | 09:37 | |
*** yassine has joined #openstack-nova | 09:37 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: [DO NOT MERGE] Test for devstack ceph bits https://review.openstack.org/389546 | 09:37 |
*** yassine is now known as Guest55156 | 09:37 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: Enable ceph-cinder bits for live-migration job https://review.openstack.org/389582 | 09:38 |
openstackgerrit | Timofey Durakov proposed openstack/nova: Ceph bits for live-migration job https://review.openstack.org/387836 | 09:38 |
openstackgerrit | Timofey Durakov proposed openstack/nova: Remove ceph install/config functions from l-m hook https://review.openstack.org/396041 | 09:38 |
*** Dong_Zhi_ has quit IRC | 09:39 | |
*** lpetrut has joined #openstack-nova | 09:41 | |
*** thorst_ has quit IRC | 09:42 | |
*** belmoreira has quit IRC | 09:46 | |
*** mlakat has quit IRC | 09:47 | |
*** amotoki_ has joined #openstack-nova | 09:47 | |
*** pcaruana has quit IRC | 09:49 | |
*** yuntongjin has quit IRC | 09:50 | |
*** amotoki has quit IRC | 09:51 | |
*** prateek has quit IRC | 09:52 | |
*** takashin has left #openstack-nova | 09:53 | |
*** brault has joined #openstack-nova | 09:59 | |
*** amotoki has joined #openstack-nova | 09:59 | |
*** takashin has joined #openstack-nova | 10:00 | |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: Refactor console checks in live migration process https://review.openstack.org/373264 | 10:00 |
*** sambetts|afk is now known as sambetts | 10:00 | |
*** pcaruana has joined #openstack-nova | 10:01 | |
*** amotoki_ has quit IRC | 10:03 | |
*** sudipto has joined #openstack-nova | 10:04 | |
*** sudipto_ has joined #openstack-nova | 10:04 | |
openstackgerrit | int32bit proposed openstack/nova: Raise exception when delete disabled terminate vm https://review.openstack.org/396017 | 10:05 |
*** prateek has joined #openstack-nova | 10:08 | |
johnthetubaguy | lyarwood: yeah, +1 the release note, probably in the fixes or upgrade section I guess? | 10:08 |
johnthetubaguy | lyarwood: could do that in a follow on patch, to keep the +2 | 10:09 |
*** jaosorior is now known as jaosorior_lunch | 10:10 | |
*** ihrachys has joined #openstack-nova | 10:10 | |
openstackgerrit | int32bit proposed openstack/nova: Raise exception when delete disabled terminate vm https://review.openstack.org/396017 | 10:12 |
takashin | johnthetubaguy: Could you review https://review.openstack.org/#/c/334725/ again? | 10:13 |
*** dikonoor has quit IRC | 10:16 | |
*** Hosam has joined #openstack-nova | 10:16 | |
johnthetubaguy | takashin: yes, I will try take a look at that for you today | 10:17 |
takashin | johnthetubaguy: Thank you in advance. | 10:17 |
johnthetubaguy | takashin: I had wanted to implement that spec myself about three years ago, I am glad someone is sorting that out now! | 10:17 |
*** portdirect has joined #openstack-nova | 10:19 | |
*** portdirect is now known as portdirect_away | 10:19 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/395862 | 10:19 |
openstackgerrit | Arvinder Singh proposed openstack/python-novaclient: Code Changes done so that nova list command with filters run smoothly when no instance is present. https://review.openstack.org/396074 | 10:20 |
*** portdirect_away is now known as portdirect | 10:20 | |
*** sahid has joined #openstack-nova | 10:21 | |
*** Hosam has quit IRC | 10:21 | |
lyarwood | johnthetubaguy: ack thanks, I was just thinking of adding it to fixes. Happy to do this in another commit if you think it's ready now to avoid another round of reviews. | 10:31 |
johnthetubaguy | need a closer look, just finishing off this Cinder API spec update | 10:31 |
lyarwood | kk thanks, I'll add it in if it does need a respin for anything. | 10:33 |
*** madhaviy has quit IRC | 10:37 | |
openstackgerrit | Lee Yarwood proposed openstack/nova: Add uuid column to BlockDeviceMapping https://review.openstack.org/242602 | 10:37 |
*** madhaviy has joined #openstack-nova | 10:38 | |
*** mvk has quit IRC | 10:40 | |
*** jerrygb has joined #openstack-nova | 10:40 | |
*** thorst_ has joined #openstack-nova | 10:40 | |
*** stvnoyes1 has joined #openstack-nova | 10:40 | |
*** matrohon has joined #openstack-nova | 10:41 | |
*** liusheng has quit IRC | 10:44 | |
*** stvnoyes has quit IRC | 10:44 | |
*** jerrygb has quit IRC | 10:45 | |
*** paul-carlton2 has joined #openstack-nova | 10:45 | |
*** rfolco has joined #openstack-nova | 10:45 | |
openstackgerrit | John Garbutt proposed openstack/nova-specs: Add spec to use Cinder's new attachment APIs https://review.openstack.org/373203 | 10:47 |
*** Zer0Byte__ has joined #openstack-nova | 10:47 | |
*** thorst_ has quit IRC | 10:47 | |
*** hoangcx has quit IRC | 10:48 | |
*** Zer0Byte__ has quit IRC | 10:48 | |
*** lpetrut has quit IRC | 10:50 | |
*** ducnc has quit IRC | 10:58 | |
*** khappone has joined #openstack-nova | 11:02 | |
*** owalsh has joined #openstack-nova | 11:03 | |
*** gongysh has joined #openstack-nova | 11:05 | |
*** esberglu has joined #openstack-nova | 11:06 | |
*** amotoki_ has joined #openstack-nova | 11:06 | |
*** gongysh has quit IRC | 11:07 | |
*** smatzek has joined #openstack-nova | 11:07 | |
*** siva has joined #openstack-nova | 11:08 | |
*** amotoki has quit IRC | 11:09 | |
khappone | Hello danpb, I had chat with john on the neutron channel (my bad), about https://bugs.launchpad.net/nova/+bug/1302080 and this review https://review.openstack.org/#/c/313070/ He said I should ping you. | 11:09 |
openstack | Launchpad bug 1302080 in OpenStack Compute (nova) "Host is accessible from instance using Linux bridge IPv6 address" [Medium,Fix released] - Assigned to Brian Haley (brian-haley) | 11:09 |
khappone | I think the bridges-having-ipv6 link local addresses is still open for us linuxbridge users | 11:10 |
*** esberglu has quit IRC | 11:10 | |
khappone | Which is something that would be nice to get fixes, since it has security implications | 11:10 |
siva | ammukukku | 11:11 |
danpb | khappone: so os-vif plugins for linux-bridge and openvswitch already disable ipv6 | 11:11 |
*** siva has left #openstack-nova | 11:12 | |
danpb | khappone: that function pointed to in the review is probably still used by some vifs that are not yet converted to os-vif plugins, so fixing that in nova is reasonable | 11:12 |
*** acabot has quit IRC | 11:12 | |
danpb | oh actually, no, that ensure_bridge method in nova is only used by nova-network | 11:13 |
khappone | Hmm, really? Then I'm in the wrong. | 11:14 |
*** houming has quit IRC | 11:17 | |
*** gongysh2 has joined #openstack-nova | 11:17 | |
*** dikonoor has joined #openstack-nova | 11:19 | |
khappone | danpb: Just verified this. It does seem that we manage to trigger this on Liberty with linuxbridges | 11:23 |
khappone | Liberty/Neutron-linuxbridges-ml2-vlan combo | 11:24 |
*** mvk has joined #openstack-nova | 11:24 | |
*** jerrygb has joined #openstack-nova | 11:25 | |
khappone | (CentOS/RDO) | 11:26 |
*** liusheng has joined #openstack-nova | 11:26 | |
*** cdent has joined #openstack-nova | 11:26 | |
*** edmondsw has joined #openstack-nova | 11:26 | |
*** GB21 has quit IRC | 11:27 | |
danpb | khappone: oh well liberty is ancient history from an upstream pov | 11:28 |
danpb | in liberty we didn't have os-vif being used, so that ensure_bridge method would be triggered by libvirt | 11:29 |
khappone | Yes, I know :) sorry, should have started with that | 11:29 |
danpb | but for git master that's no longer the case | 11:29 |
danpb | so if you want todo a change you need to submit it to stable/liberty branch, not git master | 11:29 |
danpb | and stable team can evaulate if its something they're will to take | 11:29 |
danpb | i don't think its a case of simply modifying ensure_bridge though, since that's called by nova-network too and iiuc you only want to address this for libvirt vifs | 11:30 |
khappone | Well I'm not the author of the review nor the bug, just an admin affected by it | 11:30 |
khappone | And the bug fix which should have fixed it, only fixed it for a part of the use cases | 11:31 |
*** amotoki_ has quit IRC | 11:31 | |
khappone | Just to confirm the os-vif change was in Newton? Just to confirm that this bug exists in Mitaka too? | 11:32 |
*** madhaviy has quit IRC | 11:33 | |
*** edmondsw has quit IRC | 11:34 | |
*** edmondsw has joined #openstack-nova | 11:35 | |
danpb | khappone: yes, we switched in Newton | 11:35 |
*** sridharg has quit IRC | 11:35 | |
khappone | tahnks | 11:35 |
*** lpetrut has joined #openstack-nova | 11:38 | |
*** sudipto has quit IRC | 11:38 | |
*** sudipto_ has quit IRC | 11:38 | |
*** gszasz has joined #openstack-nova | 11:39 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: pci: Validate behavior of empty devname https://review.openstack.org/396130 | 11:39 |
*** zhangyufei has quit IRC | 11:40 | |
*** GB21 has joined #openstack-nova | 11:40 | |
openstackgerrit | Arvinder Singh proposed openstack/python-novaclient: Code Changes done so that nova list command with filters run smoothly when no instance is present. https://review.openstack.org/396074 | 11:41 |
*** qwertyco has joined #openstack-nova | 11:42 | |
*** womygod has quit IRC | 11:44 | |
*** mlakat has joined #openstack-nova | 11:44 | |
*** Hosam has joined #openstack-nova | 11:45 | |
*** thorst_ has joined #openstack-nova | 11:45 | |
*** Hosam_ has joined #openstack-nova | 11:47 | |
*** edand has joined #openstack-nova | 11:47 | |
*** dikonoor has quit IRC | 11:49 | |
*** Hosam has quit IRC | 11:50 | |
*** amotoki has joined #openstack-nova | 11:52 | |
*** tbachman has quit IRC | 11:52 | |
*** thorst_ has quit IRC | 11:53 | |
openstackgerrit | int32bit proposed openstack/nova: Raise exception when delete disabled terminate vm https://review.openstack.org/396017 | 11:53 |
*** mkoderer has joined #openstack-nova | 11:54 | |
openstackgerrit | Lee Yarwood proposed openstack/nova: Make BlockDeviceMapping object support uuid https://review.openstack.org/242603 | 11:55 |
*** prateek has quit IRC | 11:55 | |
openstackgerrit | Lee Yarwood proposed openstack/nova: Add uuid column to BlockDeviceMapping https://review.openstack.org/242602 | 11:55 |
*** CristinaPauna has quit IRC | 11:55 | |
*** preethipy has quit IRC | 11:56 | |
*** amotoki has quit IRC | 12:00 | |
*** nicolasbock has joined #openstack-nova | 12:01 | |
*** CristinaPauna has joined #openstack-nova | 12:02 | |
*** haplo37 has quit IRC | 12:03 | |
*** haplo37_ is now known as haplo37 | 12:03 | |
*** prashkre has quit IRC | 12:04 | |
*** prashkre has joined #openstack-nova | 12:04 | |
*** dikonoor has joined #openstack-nova | 12:05 | |
*** haplo37_ has joined #openstack-nova | 12:06 | |
*** dave-mcnally has joined #openstack-nova | 12:06 | |
*** prateek has joined #openstack-nova | 12:07 | |
openstackgerrit | sahid proposed openstack/nova: libvirt: fix uncaugth exception during soft reboot https://review.openstack.org/376350 | 12:08 |
*** lbrune has quit IRC | 12:09 | |
*** lbrune has joined #openstack-nova | 12:11 | |
*** fragatina has joined #openstack-nova | 12:11 | |
*** fragatina has quit IRC | 12:11 | |
*** fragatina has joined #openstack-nova | 12:12 | |
*** bvanhav__ has joined #openstack-nova | 12:13 | |
*** sridharg has joined #openstack-nova | 12:13 | |
mdbooth | kashyap: Did you get anywhere with that nfs testing? | 12:13 |
kashyap | mdbooth: Was about to update you here that so far I ended up spending time fixing my test env :-( | 12:14 |
*** prashkre_ has joined #openstack-nova | 12:14 | |
mdbooth | kashyap: \o/ | 12:14 |
kashyap | mdbooth: DevStack on my F24, I couldn't figure out how to fix that Nova error http://paste.openstack.org/show/588705/ | 12:14 |
*** tyrola_ has joined #openstack-nova | 12:15 | |
mdbooth | You can borrow my spare yak shears | 12:15 |
*** prashkre has quit IRC | 12:15 | |
kashyap | mdbooth: Just an hour ago, I resigned to stop caring for this "pet", and thought of "spinning a cattle" (sheesh, that sounds bad; is there a better analogy?) | 12:15 |
mdbooth | prepping my bolt gun? | 12:16 |
mdbooth | kashyap: Random, I threw this up earlier https://github.com/mdbooth/mdbooth-utils | 12:16 |
mdbooth | I'm going to keep it as a repo of my useful bits of sticky tape and string as I write them | 12:17 |
mdbooth | They normally get thrown away | 12:17 |
*** shihanzhang has quit IRC | 12:17 | |
*** tyrola has quit IRC | 12:17 | |
mdbooth | Anyway, only 3 in there right now. Do you have any gems? | 12:17 |
kashyap | mdbooth: Oh, let me look | 12:18 |
mdbooth | I wrote mkcd :) | 12:18 |
mdbooth | I've been intending to do that for ages | 12:18 |
kashyap | mdbooth: I have random `virt-builder` scripts like - https://kashyapc.fedorapeople.org/virt/openstack/setup-devstack-vm.bash | 12:19 |
kashyap | Give me a few, need to quickly grab some lunch, I'll pay better attention here | 12:19 |
*** shihanzhang has joined #openstack-nova | 12:19 | |
*** brault has quit IRC | 12:19 | |
*** esberglu has joined #openstack-nova | 12:21 | |
openstackgerrit | Lee Yarwood proposed openstack/nova: Make BlockDeviceMapping object support uuid https://review.openstack.org/242603 | 12:23 |
openstackgerrit | Lee Yarwood proposed openstack/nova: Add uuid column to BlockDeviceMapping https://review.openstack.org/242602 | 12:23 |
*** prateek has quit IRC | 12:23 | |
*** prateek has joined #openstack-nova | 12:24 | |
*** esberglu has quit IRC | 12:25 | |
*** ratailor has quit IRC | 12:26 | |
*** brault has joined #openstack-nova | 12:27 | |
danpb | can someone remind what git repo i need to look at for the Nova Gate CI job definitions - ie the devstack config for each job ? | 12:28 |
*** prateek has quit IRC | 12:29 | |
kashyap | danpb: 'project-config', IIRC | 12:29 |
* kashyap double-checks | 12:29 | |
*** bkopilov has quit IRC | 12:31 | |
*** jaosorior_lunch is now known as jaosorior | 12:34 | |
*** manasm has quit IRC | 12:38 | |
tdurakov | kashyap: right | 12:39 |
tdurakov | danpb: https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/devstack-gate.yaml - that's mostly it | 12:39 |
kashyap | danpb: project-config/jenkins/jobs/nova.yaml | 12:39 |
*** lucasagomes is now known as lucas-hungry | 12:41 | |
danpb | ok thanks | 12:42 |
*** sree has quit IRC | 12:42 | |
*** sree has joined #openstack-nova | 12:43 | |
*** tuanluong has quit IRC | 12:43 | |
*** sree has quit IRC | 12:43 | |
*** sree has joined #openstack-nova | 12:44 | |
*** thorst_ has joined #openstack-nova | 12:47 | |
*** thorst_ has quit IRC | 12:47 | |
*** sandanar has quit IRC | 12:47 | |
*** thorst_ has joined #openstack-nova | 12:47 | |
*** sree_ has joined #openstack-nova | 12:48 | |
*** sree_ is now known as Guest81666 | 12:48 | |
*** sree has quit IRC | 12:48 | |
*** maticue has joined #openstack-nova | 12:50 | |
*** tbachman has joined #openstack-nova | 12:50 | |
*** kylek3h has quit IRC | 12:50 | |
*** Guest81666 has quit IRC | 12:52 | |
*** portdirect has quit IRC | 12:57 | |
*** GB21 has quit IRC | 12:58 | |
*** esberglu has joined #openstack-nova | 13:00 | |
*** hshiina has joined #openstack-nova | 13:02 | |
*** gcb has quit IRC | 13:02 | |
*** acabot has joined #openstack-nova | 13:03 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: Fix backwards compatibility for InstanceNUMACell https://review.openstack.org/396184 | 13:04 |
mdbooth | Our Dear Leader is mia today :( | 13:06 |
*** ducttape_ has joined #openstack-nova | 13:07 | |
*** catintheroof has joined #openstack-nova | 13:08 | |
openstackgerrit | Chris Dent proposed openstack/nova: placement: adds REST API for nested providers https://review.openstack.org/384807 | 13:08 |
openstackgerrit | Chris Dent proposed openstack/nova: placement: add get_all_by_root_provider_uuid() https://review.openstack.org/377215 | 13:08 |
openstackgerrit | Chris Dent proposed openstack/nova: placement: update client to set parent provider https://review.openstack.org/385693 | 13:08 |
openstackgerrit | Chris Dent proposed openstack/nova: placement: add nested resource providers https://review.openstack.org/377138 | 13:08 |
danpb | someone was supposedly working on a tempest change to test the noVNC console proxy could connect to the guest successfully - anyone recall who that was | 13:11 |
openstackgerrit | Daniel Berrange proposed openstack/nova: console: provide an RFB security proxy implementation https://review.openstack.org/345399 | 13:12 |
*** liverpooler has joined #openstack-nova | 13:13 | |
*** coolsvap has quit IRC | 13:13 | |
*** roeyc has joined #openstack-nova | 13:14 | |
*** lamt has joined #openstack-nova | 13:20 | |
*** alexchadin has quit IRC | 13:22 | |
markus_z | danpb: I'm doing that for serial console if you mean that. https://review.openstack.org/#/c/346815/ | 13:24 |
danpb | no, it was this one that i was looking for https://review.openstack.org/#/c/343078/5 | 13:25 |
markus_z | Interesting, thanks | 13:26 |
*** RuiChen has quit IRC | 13:26 | |
*** Kevin_Zheng has quit IRC | 13:26 | |
*** RuiChen has joined #openstack-nova | 13:26 | |
*** lucas-hungry is now known as lucasagomes | 13:27 | |
*** alexchadin has joined #openstack-nova | 13:27 | |
*** Kevin_Zheng has joined #openstack-nova | 13:28 | |
markus_z | tdurakov: I didn't find anything in the ML, but is the live-migration test job out-of-order right now? | 13:29 |
*** kylek3h has joined #openstack-nova | 13:29 | |
*** udesale_ has joined #openstack-nova | 13:30 | |
*** victorhe has joined #openstack-nova | 13:30 | |
*** raildo has joined #openstack-nova | 13:30 | |
*** fragatina has quit IRC | 13:33 | |
*** jerrygb has quit IRC | 13:35 | |
*** jerrygb has joined #openstack-nova | 13:36 | |
openstackgerrit | Alex Xu proposed openstack/nova-specs: Consistent query parameters validation https://review.openstack.org/388518 | 13:39 |
alex_xu | johnthetubaguy: dansmith ^ just updated | 13:39 |
*** jerrygb has quit IRC | 13:40 | |
johnthetubaguy | alex_xu: ah, I see your note, sounds like removing from that dict does the trick | 13:41 |
alex_xu | johnthetubaguy: emm...yea, another way is pass a new parameter into the api method | 13:42 |
*** Hosam_ has quit IRC | 13:42 | |
johnthetubaguy | alex_xu: yeah, I am not against that either | 13:42 |
*** Hosam has joined #openstack-nova | 13:43 | |
*** dave-mccowan has joined #openstack-nova | 13:43 | |
alex_xu | johnthetubaguy: ok, let me put that option in the comment, say if other people perfer one of them | 13:44 |
johnthetubaguy | alex_xu: honestly, I am fine with that being an implementation detail, the PoC should help make it clear which is best | 13:45 |
*** kamtamtun has quit IRC | 13:45 | |
*** roeyc has quit IRC | 13:45 | |
johnthetubaguy | alex_xu: I slightly prefer modifying that dict in place, just because folks keep doing the "normal" thing | 13:45 |
*** ducttape_ has quit IRC | 13:45 | |
*** scsnow has quit IRC | 13:46 | |
*** ljxiash has quit IRC | 13:47 | |
*** jerrygb has joined #openstack-nova | 13:47 | |
*** ljxiash has joined #openstack-nova | 13:47 | |
*** Hosam has quit IRC | 13:47 | |
alex_xu | johnthetubaguy: ok, let me remove the bit about 'req.GET', just say we will strip the additional properties out. Then I will update the poc to show that | 13:48 |
openstackgerrit | Chris Dent proposed openstack/nova: [placement] Enforce min_unit, max_unit and step_size https://review.openstack.org/392933 | 13:48 |
johnthetubaguy | alex_xu: cool | 13:48 |
*** jheroux has joined #openstack-nova | 13:48 | |
*** zenoway has quit IRC | 13:50 | |
*** baoli_ has joined #openstack-nova | 13:50 | |
*** zenoway has joined #openstack-nova | 13:50 | |
*** bvanhav_ has joined #openstack-nova | 13:51 | |
*** brault has quit IRC | 13:51 | |
*** bvanhav__ has quit IRC | 13:52 | |
*** ljxiash has quit IRC | 13:52 | |
*** takashin has left #openstack-nova | 13:53 | |
*** brault has joined #openstack-nova | 13:54 | |
*** zenoway has quit IRC | 13:54 | |
*** tlian has joined #openstack-nova | 13:55 | |
openstackgerrit | Diana Clarke proposed openstack/nova: Fix database poison warnings, part 25 https://review.openstack.org/396207 | 13:56 |
openstackgerrit | Alex Xu proposed openstack/nova-specs: Consistent query parameters validation https://review.openstack.org/388518 | 13:56 |
*** roeyc has joined #openstack-nova | 13:56 | |
openstackgerrit | Diana Clarke proposed openstack/nova: Fix database poison warnings, part 25 https://review.openstack.org/396207 | 13:57 |
*** ar1el has joined #openstack-nova | 13:57 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Transform aggregate.create notification https://review.openstack.org/394511 | 13:57 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Transform aggregate.delete notification https://review.openstack.org/394512 | 13:57 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Add aggregate notification related enum values https://review.openstack.org/396209 | 13:57 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Transform aggregate.add_host notification https://review.openstack.org/396210 | 13:57 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Transform aggregate.remove_host notification https://review.openstack.org/396211 | 13:57 |
openstackgerrit | Hans Lindgren proposed openstack/nova: WIP:remove ec2 metadata https://review.openstack.org/282872 | 13:57 |
openstackgerrit | Diana Clarke proposed openstack/nova: Change database poison warning to an exception https://review.openstack.org/349082 | 13:58 |
*** scsnow has joined #openstack-nova | 13:59 | |
*** garyk1 has quit IRC | 14:00 | |
*** manasm has joined #openstack-nova | 14:02 | |
openstackgerrit | Diana Clarke proposed openstack/nova: Change database poison warning to an exception https://review.openstack.org/349082 | 14:02 |
*** markvoelker has quit IRC | 14:05 | |
openstackgerrit | jichenjc proposed openstack/python-novaclient: Bump microversion to 2.38 https://review.openstack.org/396215 | 14:06 |
*** portdirect has joined #openstack-nova | 14:09 | |
edmondsw | dansmith, this looks like a clean cherrypick of what you merged yesterday: https://review.openstack.org/#/c/396151 | 14:09 |
openstackgerrit | Lee Yarwood proposed openstack/nova: Add a releasenote for bug#1633518 https://review.openstack.org/396217 | 14:09 |
*** claudiub has joined #openstack-nova | 14:10 | |
lyarwood | johnthetubaguy: https://review.openstack.org/#/c/386670/ should be good now, releasenote posted above and I've documented a manual test run in the bug. | 14:10 |
*** ralonsoh has quit IRC | 14:11 | |
*** tblakes has joined #openstack-nova | 14:11 | |
*** ralonsoh has joined #openstack-nova | 14:11 | |
openstackgerrit | John Garbutt proposed openstack/nova: Add a releasenote for bug#1633518 https://review.openstack.org/396217 | 14:12 |
openstackgerrit | Pavel Gluschak proposed openstack/nova: don't store vnc/spice listen addrs in migration data if disabled https://review.openstack.org/396218 | 14:13 |
*** portdirect_ has joined #openstack-nova | 14:13 | |
johnthetubaguy | lyarwood: cool, thank you | 14:14 |
johnthetubaguy | lyarwood: not sure about when we could assume the volumes have been rebuilt | 14:14 |
*** tbachman_ has joined #openstack-nova | 14:14 | |
johnthetubaguy | lyarwood: I know we have instances that have been around for 2 or 3 years, I guess thats not unique. | 14:15 |
lyarwood | johnthetubaguy: and up for that amount of time? | 14:15 |
lyarwood | johnthetubaguy: the workaround should kick in with a reboot etc | 14:15 |
lyarwood | johnthetubaguy: I'd say a few cycles but we'd have to ask ops first etc | 14:15 |
*** portdirect has quit IRC | 14:15 | |
lyarwood | johnthetubaguy: but by that time I'm hopefully that this code is going to be out of Nova anyway and only in os-brick | 14:16 |
johnthetubaguy | I mean since the last time we have to reboot/live-migrate things, but yeah | 14:16 |
lyarwood | hopeful* | 14:16 |
johnthetubaguy | yeah, thats true, it should be moving | 14:16 |
*** tbachman has quit IRC | 14:17 | |
*** tbachman_ is now known as tbachman | 14:17 | |
*** eharney has quit IRC | 14:19 | |
*** mpaolino has joined #openstack-nova | 14:19 | |
*** jerrygb has quit IRC | 14:19 | |
*** sudipto_ has joined #openstack-nova | 14:19 | |
*** sudipto has joined #openstack-nova | 14:19 | |
*** gongysh has joined #openstack-nova | 14:19 | |
*** mdrabe has joined #openstack-nova | 14:21 | |
moshele | join #openstack-acc | 14:22 |
*** smatzek has quit IRC | 14:23 | |
*** gongysh has quit IRC | 14:24 | |
*** mriedem has joined #openstack-nova | 14:24 | |
*** ducttape_ has joined #openstack-nova | 14:24 | |
openstackgerrit | Béla Vancsics proposed openstack/nova: Transform instance.trigger_crash_dump notification https://review.openstack.org/396225 | 14:24 |
*** esberglu has quit IRC | 14:25 | |
*** hshiina has quit IRC | 14:25 | |
diana_clarke | It's a miracle! If you merge this and its 2 dependencies, the poison warnings are finally all gone: https://review.openstack.org/#/c/349082/ | 14:27 |
diana_clarke | ^ that's green for the first time | 14:27 |
mriedem | shouldn't we save miracles for xmas time? | 14:27 |
diana_clarke | we do xmas a month earlier in canada, just like thanksgiving | 14:28 |
*** ducttape_ has quit IRC | 14:28 | |
*** udesale_ has left #openstack-nova | 14:29 | |
*** links has quit IRC | 14:31 | |
*** mkoderer has quit IRC | 14:33 | |
*** raildo has quit IRC | 14:33 | |
danpb | would love some reviews of the VNC TLS proxy stuff now https://review.openstack.org/#/q/topic:bp/websocket-proxy-to-host-security+status:open | 14:33 |
*** jaosorior has quit IRC | 14:34 | |
mriedem | diana_clarke: put some comments in the last change, but that can be a follow up | 14:34 |
*** jaosorior has joined #openstack-nova | 14:34 | |
*** rama_y has joined #openstack-nova | 14:35 | |
diana_clarke | mriedem: Good point. I'll come up with some verbage to add. | 14:36 |
mriedem | danpb: looks like a simple bashate failure on your devstack change there | 14:36 |
*** prateek has joined #openstack-nova | 14:36 | |
jroll | super easy feature matrix review, to correct some wrongness in ironic. marks resize unsupported: https://review.openstack.org/#/c/395144/1 | 14:36 |
*** sridharg has quit IRC | 14:38 | |
*** esberglu has joined #openstack-nova | 14:38 | |
mriedem | jroll: +2 | 14:39 |
jroll | thanks | 14:39 |
*** sree has joined #openstack-nova | 14:40 | |
*** jamesdenton has joined #openstack-nova | 14:40 | |
*** cleong has joined #openstack-nova | 14:41 | |
*** zenoway has joined #openstack-nova | 14:41 | |
*** erhudy has joined #openstack-nova | 14:44 | |
*** cfriesen has joined #openstack-nova | 14:44 | |
*** sree has quit IRC | 14:44 | |
*** zenoway has quit IRC | 14:45 | |
*** zenoway has joined #openstack-nova | 14:45 | |
mdbooth | mriedem: See comments on https://review.openstack.org/#/c/383859/. I also commented on the remaining failures in that gate job in your devstack patch. | 14:49 |
*** dikonoor has quit IRC | 14:49 | |
*** ratailor has joined #openstack-nova | 14:49 | |
mdbooth | mriedem: Oh, and Andreas wanted your blessing on this one: https://review.openstack.org/#/c/395711/ | 14:49 |
mriedem | mdbooth: the nfs job is failing on some busted tempest tests, i already wrote a bug for that, will fix today | 14:50 |
*** eharney has joined #openstack-nova | 14:50 | |
mdbooth | mriedem: Cool. There are 6 failures, btw, I checked them all. My patch has the same 6 failures. | 14:51 |
mdbooth | mriedem: Could you add me to your bugfix patch, btw? It's not an area of code I'm very familiar with. | 14:51 |
*** markvoelker has joined #openstack-nova | 14:52 | |
*** mlavalle has joined #openstack-nova | 14:53 | |
*** derekh has joined #openstack-nova | 14:53 | |
*** ducttape_ has joined #openstack-nova | 14:54 | |
*** tbachman has quit IRC | 14:55 | |
*** tbachman has joined #openstack-nova | 14:56 | |
*** d34dh0r53 is now known as d0nt-c0nfu53-m3- | 14:57 | |
*** gszasz has quit IRC | 14:57 | |
*** gabor_antal has joined #openstack-nova | 14:58 | |
openstackgerrit | Lee Yarwood proposed openstack/nova: compute: Do not create bdms before successfully reserving a volume https://review.openstack.org/290793 | 14:58 |
*** gszasz has joined #openstack-nova | 14:58 | |
*** oanson has quit IRC | 14:58 | |
*** d0nt-c0nfu53-m3- is now known as n0t-b3rn-n00dles | 14:59 | |
mriedem | mdbooth: yeah so you saw https://review.openstack.org/#/c/395887/ | 15:00 |
*** jaugustine has joined #openstack-nova | 15:00 | |
mriedem | some of those should be done now because i updated that to not run volume backup tests | 15:01 |
mdbooth | mriedem: Yup | 15:01 |
mriedem | the others are reported in tempest bug https://bugs.launchpad.net/tempest/+bug/1640646 | 15:01 |
openstack | Launchpad bug 1640646 in tempest "Tempest runs volume snapshot tests even when volume snapshots are disabled" [Undecided,New] | 15:01 |
mriedem | tempest is just missing some skip decorators on those tests | 15:01 |
mriedem | pretty easy fix | 15:01 |
*** mvk has quit IRC | 15:01 | |
*** mgoddard_ has joined #openstack-nova | 15:01 | |
mriedem | you can grab that if you want some tempest work | 15:01 |
mdbooth | There are some clone ones as well, I think | 15:01 |
*** kaisers_ has joined #openstack-nova | 15:01 | |
danpb | mriedem: so about testing for this vnc tls stuff | 15:03 |
tdurakov | mriedem: I've updated ceph bit, could you please review it again? | 15:03 |
diana_clarke | mdbooth: I can do those tempest test skips, if you're busy. | 15:03 |
danpb | mriedem: the tempest test to validate vnc console proxy will cover the tls stuff, if we just have a devstack that turns on tls | 15:03 |
mdbooth | diana_clarke: If you don't mind. As I said to mriedem, though, I'd appreciate being added to the reviews because this isn't an area I'm familiar with. | 15:04 |
danpb | mriedem: iirc you were suggesting a new job, but I think we could just as easily do it in an existing job too | 15:04 |
mriedem | danpb: fwiw i think we run devstack with tls on by default now in the gate | 15:04 |
mriedem | danpb: clarkb would know for sure, he did that work | 15:04 |
mriedem | danpb: the new job was for all of the image signing/verification stuff | 15:04 |
*** mgoddard has quit IRC | 15:04 | |
danpb | nb, we need to explicitly turn on tls for the vnc stuff separately from the public api tls stuff | 15:05 |
danpb | oh, i'm getting mixed up then :-) | 15:05 |
*** jaugustine has quit IRC | 15:05 | |
diana_clarke | mdbooth: okie dokie, will do. The canadians are off tomorrow, so I might not get to it until Monday. | 15:05 |
mdbooth | diana_clarke: Wall building party. | 15:05 |
diana_clarke | exactly | 15:06 |
mdbooth | :) | 15:06 |
mriedem | diana_clarke: if you don't have a patch up i'll probably just do it this week, i'd like to see that nfs job passing so i can add to nova's experimental queue | 15:06 |
mriedem | danpb: yeah so we run TLS today, and you're right we might just be able to run your stuff in the regular gate jobs, | 15:06 |
mdbooth | mriedem: Is this on the critical path to getting my nfs patches accepted, btw? If so, and if diana_clarke is off tomorrow, I'll just take it myself. | 15:06 |
mriedem | danpb: the security-specific job is really about image signing/verfication and running with barbican as an actual key manager | 15:06 |
danpb | the way i've written the devstack integration we merely need to set NOVA_CONSOLE_PROXY_COMPUTE_TLS=True | 15:07 |
*** alexchadin has quit IRC | 15:07 | |
*** diogogmt has quit IRC | 15:07 | |
mriedem | mdbooth: it's something i've been wanting to get done for months and other people told me they were going to do it, but never did | 15:07 |
mriedem | mdbooth: so doesn't really have anything to do with your bug fix | 15:07 |
*** roeyc has quit IRC | 15:07 | |
mdbooth | diana_clarke: What are the chances you'll get a patch up today? If not, I guess I'll take it anyway. | 15:08 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Fix notification doc generator https://review.openstack.org/396272 | 15:09 |
mriedem | danpb: left some comments / questions in https://review.openstack.org/#/c/396186/2 too | 15:09 |
*** ljxiash has joined #openstack-nova | 15:09 | |
diana_clarke | mdbooth: I'll do it after lunch today. If it really is just skips, it should be easy enough now that I now how to run the tempest tests locally. | 15:09 |
mdbooth | diana_clarke: Thank you! | 15:10 |
*** smatzek has joined #openstack-nova | 15:11 | |
mriedem | interesting, n-novnc is in the default list of enabled services | 15:11 |
danpb | damned if i understand where i should set that devstack config variable, such that it only applies to ci jobs run against ocata | 15:14 |
*** ljxiash has quit IRC | 15:14 | |
*** mvk has joined #openstack-nova | 15:14 | |
mriedem | danpb: well, | 15:14 |
mriedem | that gets tricky | 15:14 |
mriedem | project-config defines the jobs, | 15:14 |
mriedem | and uses devstack-gate, which sets up devstack's localrc | 15:14 |
mriedem | both of those are branchless | 15:14 |
mriedem | however, setting the variable in stable branch devstack won't harm anything, it'd just be ignored | 15:15 |
mriedem | so that should be fine | 15:15 |
mriedem | danpb: the other issue is going to be n-novnc isn't enabled in the gate jobs http://logs.openstack.org/86/396186/2/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/775f302/logs/localrc.txt.gz | 15:15 |
jroll | mriedem: landed our attach/detach spec, https://review.openstack.org/#/c/317636/ , if you want to approve the nova BP now: https://blueprints.launchpad.net/nova/+spec/ironic-plug-unplug-vifs-update | 15:15 |
mriedem | danpb: e.g. this the neutron job http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/jobs/devstack-gate.yaml#n321 | 15:16 |
danpb | mriedem: ok, so setting it in devstack-gate is best then ? | 15:16 |
mriedem | yeah we at least have to set it in devstack-gate | 15:16 |
mriedem | there is a passthrough devstack gate variable though for setting things in devstack's localrc | 15:17 |
mriedem | sec | 15:17 |
*** yamahata has joined #openstack-nova | 15:17 | |
*** mnestratov has quit IRC | 15:17 | |
openstackgerrit | Peter Hamilton proposed openstack/nova-specs: Add support for certificate validation https://review.openstack.org/357151 | 15:17 |
danpb | oh, so devstack-gate is overriding the default enabled services, and so missing n-novnc | 15:17 |
*** READ10 has joined #openstack-nova | 15:18 | |
mriedem | danpb: DEVSTACK_LOCAL_CONFIG is the variable you can set things into to populate localrc | 15:19 |
mriedem | danpb: right, devstack-gate is setting ENABLED_SERVICES somewhere | 15:19 |
mriedem | here is an example usage of DEVSTACK_LOCAL_CONFIG http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/jobs/lvm.yaml#n20 | 15:19 |
danpb | ah, so i modify project-config to set that var, so don't need to change devstack-gate itself | 15:20 |
mriedem | yeah that's an option | 15:20 |
mriedem | you'd have to pick a job to do it on | 15:20 |
mriedem | which, we have a special nova job | 15:20 |
*** jaosorior has quit IRC | 15:20 | |
mriedem | you could throw it in the tempest-dsvm-neutron-placement-full job | 15:21 |
danpb | nova.yaml has {pipeline}-tempest-dsvm-neutron-placement-full-{node}{job-suffix} | 15:21 |
mriedem | that runs the placement service and cells v2 | 15:21 |
danpb | snap | 15:21 |
mriedem | it's our dumping ground for experimental but still voting nova things | 15:21 |
mriedem | btw, i guess features.yaml in devstack-gate is what sets the ENABLED_SERVICES var | 15:23 |
danpb | ok | 15:23 |
mriedem | and that is per-branch | 15:23 |
mriedem | so in there you could also turn on n-novnc by default for ocata... | 15:24 |
danpb | yep | 15:24 |
mriedem | but you'd still need to set that new variable | 15:24 |
mriedem | which if you're going to do that, you might as well just add the n-novnc to ENABLED_SERVICES in project-config | 15:25 |
mriedem | we already do that for placement-api http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/jobs/nova.yaml#n67 | 15:25 |
*** jaugustine has joined #openstack-nova | 15:25 | |
mriedem | so you'd just add ",n-novnc" | 15:25 |
*** manasm has quit IRC | 15:26 | |
mriedem | and "\nNOVA_CONSOLE_PROXY_COMPUTE_TLS=True" to DEVSTACK_LOCAL_CONFIG | 15:26 |
*** mnestratov has joined #openstack-nova | 15:26 | |
danpb | i guess i have the depends on the wrong way around - i'd want the last nova change to depend on the devstack + project-config + devstack-gate changes | 15:27 |
*** jaugustine has quit IRC | 15:27 | |
mriedem | no, not really | 15:27 |
mriedem | i don't think we actually need any d-g changes | 15:27 |
mriedem | you can configure devstack via project-config variables passed to d-g | 15:27 |
mriedem | so project-config depends on devstack (for the new variable), and devstack depends on the top of the nova series | 15:27 |
danpb | still need to turn on n-novnc in d-g | 15:27 |
mriedem | danpb: you can do that via project-config | 15:28 |
mriedem | see http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/jobs/nova.yaml#n67 | 15:28 |
mriedem | just add ,n-novnc to that list | 15:28 |
mriedem | with placement-api | 15:28 |
danpb | ah ok | 15:28 |
mriedem | i'd have to check if that placement job is run in the devstack experiemental queue or not | 15:28 |
mriedem | if not we'd have to add that to see this running on your nova stack | 15:29 |
*** Dong_Zhi_ has joined #openstack-nova | 15:29 | |
mriedem | but basically when we see that all passing that job on your devstack change, we should know that it's happy | 15:29 |
*** jaugustine has joined #openstack-nova | 15:29 | |
mriedem | i've gotta run to a meeting, but add me to the project-config change when it's up | 15:29 |
*** moshele has quit IRC | 15:31 | |
*** jerrygb has joined #openstack-nova | 15:31 | |
*** jerrygb has quit IRC | 15:31 | |
*** tbachman_ has joined #openstack-nova | 15:31 | |
*** jerrygb has joined #openstack-nova | 15:32 | |
*** mriedem1 has joined #openstack-nova | 15:32 | |
*** tbachman has quit IRC | 15:32 | |
*** tbachman_ is now known as tbachman | 15:32 | |
*** kaisers_ has quit IRC | 15:32 | |
*** pbandark has quit IRC | 15:32 | |
*** portdirect_ is now known as portdirect | 15:33 | |
*** Dong_Zhi_ has quit IRC | 15:34 | |
*** mriedem has quit IRC | 15:34 | |
*** adreznec has quit IRC | 15:34 | |
*** Dong_Zhi_ has joined #openstack-nova | 15:36 | |
*** sudipto_ has quit IRC | 15:37 | |
*** sudipto has quit IRC | 15:37 | |
mriedem1 | jroll: what about the attach/detach thing? the spec merged but the api on the ironic side hasn't? | 15:37 |
*** adreznec has joined #openstack-nova | 15:37 | |
*** mriedem1 is now known as mriedem | 15:37 | |
jroll | mriedem: yes, we just landed the spec, last nova meeting we said once the spec is merged ironic side we can approve that | 15:38 |
*** jerrygb has quit IRC | 15:39 | |
*** edand has quit IRC | 15:42 | |
*** ayoung has joined #openstack-nova | 15:43 | |
openstackgerrit | int32bit proposed openstack/nova: Raise exception if delete disabled terminate server https://review.openstack.org/396017 | 15:44 |
*** ratailor has quit IRC | 15:47 | |
mriedem | bauzas: easy +W https://review.openstack.org/#/c/395144/ | 15:49 |
mriedem | jroll: i wasn't sure if it was the spec or code in ironic that we agreed on | 15:49 |
*** armax has joined #openstack-nova | 15:49 | |
mriedem | the nova code has to obviously depend on the ironic api changes and microversion bump anyway i guess | 15:49 |
*** jaugustine_ has joined #openstack-nova | 15:49 | |
*** hongbin has joined #openstack-nova | 15:50 | |
jroll | mriedem: believe it was spec, idk, there's no way code will be done by nov 17 | 15:50 |
*** ayoung has quit IRC | 15:50 | |
dansmith | mriedem: what's the plan here? https://review.openstack.org/#/c/395747 | 15:50 |
*** mgoddard_ has quit IRC | 15:50 | |
*** jaugustine has quit IRC | 15:50 | |
jroll | mriedem: so I guess the actual question is do we do this in ocata or pike | 15:50 |
*** mpaolino_ has joined #openstack-nova | 15:50 | |
mriedem | jroll: we said specless bp right? spec freeze is 11/17, not feature freeze | 15:50 |
jroll | mriedem: I assumed spec freeze == bp approval freeze, I guess that's wrong? | 15:51 |
mriedem | jroll: haven't thought about that, but probably | 15:51 |
*** sree has joined #openstack-nova | 15:51 | |
mriedem | jroll: i'll get it approved after dealing with mr smith | 15:51 |
jroll | mriedem: okay, thanks | 15:51 |
mriedem | dansmith: so are you ok with the general idea there? if so, i'll update with unit tests. | 15:51 |
dansmith | mriedem: yeah | 15:52 |
mriedem | dansmith: and then we need a change on top to add the uuid storing support to the SecurityGroup object | 15:52 |
openstackgerrit | Christopher Martin proposed openstack/nova: Fix for resize vm_state stopped rollback https://review.openstack.org/370861 | 15:52 |
mriedem | we either add a uuid field to the existing object that is only used for neutron, or we do like floating IPs and have a NeutronSecurityGroup object that changes the type on the id field to be string | 15:52 |
dansmith | mriedem: right, was going to do that, but don't want to start if you're going to be updating that a lot, so was just hoping you'd get it ready and out of wip state | 15:52 |
*** rrecio has joined #openstack-nova | 15:53 | |
*** mpaolino has quit IRC | 15:54 | |
*** armax has quit IRC | 15:54 | |
*** rrecio has quit IRC | 15:54 | |
*** zenoway has quit IRC | 15:54 | |
*** rrecio has joined #openstack-nova | 15:55 | |
*** zenoway has joined #openstack-nova | 15:55 | |
kashyap | For anyone looking for a simple +W :-) - https://review.openstack.org/#/c/379639/ | 15:55 |
*** Dong_Zhi_ has quit IRC | 15:56 | |
*** Guest40216 has quit IRC | 15:56 | |
*** Dong_Zhi_ has joined #openstack-nova | 15:57 | |
*** diogogmt has joined #openstack-nova | 15:58 | |
*** annegentle has joined #openstack-nova | 15:58 | |
mdbooth | kashyap: -1 I don't like the title, and the repetition in your list of changes shows a lack of imagination. | 15:59 |
*** mgoddard has joined #openstack-nova | 15:59 | |
*** rama_y has quit IRC | 15:59 | |
mdbooth | kashyap: Although seriously, lol@ sfinucan's comment :) | 15:59 |
*** zenoway has quit IRC | 16:00 | |
*** ekuris has quit IRC | 16:00 | |
mdbooth | sfinucan: In fairness, a double space from me normally just means I joined 2 lines and didn't noticed it resulted in 2 spaces :P | 16:00 |
*** Dong_Zhi_ has quit IRC | 16:01 | |
edleafe | cdent: is there an API WG meeting? | 16:02 |
*** zenoway has joined #openstack-nova | 16:03 | |
cdent | edleafe: yes, but I have calendar fail | 16:03 |
edleafe | UTC FTW! | 16:03 |
*** ayoung has joined #openstack-nova | 16:04 | |
*** baoli has joined #openstack-nova | 16:04 | |
*** dimtruck is now known as zz_dimtruck | 16:05 | |
mdbooth | kashyap: Is that description of rebase correct? | 16:05 |
*** zz_dimtruck is now known as dimtruck | 16:05 | |
mdbooth | kashyap: Sounds the same as commit to me. | 16:05 |
mriedem | dansmith: yeah when i'm out of this meeting i'll get those tests written | 16:06 |
dansmith | mriedem: cool thanks | 16:06 |
*** baoli_ has quit IRC | 16:07 | |
*** zenoway has quit IRC | 16:07 | |
mriedem | jroll: done https://blueprints.launchpad.net/nova/+spec/ironic-plug-unplug-vifs-update | 16:08 |
*** armax has joined #openstack-nova | 16:08 | |
mdbooth | mriedem: What's your preferred path for https://review.openstack.org/#/c/383859/, btw? | 16:08 |
*** stewie925 has joined #openstack-nova | 16:08 | |
*** links has joined #openstack-nova | 16:09 | |
*** armax has quit IRC | 16:10 | |
*** rcernin has quit IRC | 16:11 | |
*** prateek has quit IRC | 16:12 | |
mriedem | mdbooth: umm | 16:13 |
*** armax has joined #openstack-nova | 16:13 | |
mriedem | i need to get this other change updated for dan before i can move on to other things | 16:14 |
*** edand has joined #openstack-nova | 16:14 | |
mdbooth | mriedem: np, just wondering if there's anybody I should be hassling other than you ;) | 16:14 |
mriedem | attach/detach volume with the nfs job on that change is fine | 16:14 |
mriedem | mdbooth: not sure | 16:15 |
mriedem | ftersin maybe | 16:15 |
stewie925 | gibi: hi could you take a look at this unit test issue i'm encountering? http://paste.openstack.org/show/588638/ | 16:15 |
mdbooth | danpb has had a fair few rounds on it already, btw | 16:15 |
mdbooth | And the one prior | 16:15 |
stewie925 | error says the resize_confirm notification assertion is failing due to no actual calls made... maybe something we missed in the code | 16:16 |
edmondsw | mriedem, this looks like a clean cherrypick of what you merged yesterday: https://review.openstack.org/#/c/396151 | 16:17 |
*** lbrune has quit IRC | 16:17 | |
jroll | mriedem: thank you | 16:17 |
*** mriedem has quit IRC | 16:19 | |
*** mriedem has joined #openstack-nova | 16:20 | |
mriedem | mdbooth: tom patzig is also running an NFS shop i think | 16:20 |
mdbooth | mriedem: Incidentally, this is intended to be generic and apply to all the fs-based volume backends | 16:20 |
mriedem | mdbooth: that would affect the virtuozzo guys too then | 16:20 |
mriedem | so maybe talk to mnestratov too | 16:21 |
mdbooth | One of the objections to previous attempts was that it didn't do that | 16:21 |
mriedem | quobyte ci failed but not sure if that's related | 16:21 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Cleanup spawn tests https://review.openstack.org/344175 | 16:22 |
mriedem | dansmith: i thought about decoupling that series from https://review.openstack.org/#/c/395746/ | 16:23 |
mriedem | https://review.openstack.org/#/c/395746/ could break API extensions - as noted in my comment, we broke them in newton anyway so i'm not sure we care | 16:23 |
dansmith | mriedem: or we just merge that fast | 16:23 |
dansmith | mriedem: yeah I don't care | 16:23 |
mriedem | i'd feel more comfortable with sdague on that one but... | 16:23 |
dansmith | well, if you wish | 16:23 |
mriedem | i have a feeling sdague is really father xmas | 16:23 |
mriedem | and is building toys | 16:23 |
mdbooth | That failed on the prior change too. I'll check that out. | 16:23 |
mriedem | mdbooth: quobyte failed some ansible setup | 16:23 |
mriedem | alex_xu: oomichi: johnthetubaguy: are you ok with this? https://review.openstack.org/#/c/395746/ | 16:24 |
johnthetubaguy | mriedem: seems like a good idea | 16:26 |
*** ircuser-1 has joined #openstack-nova | 16:27 | |
dansmith | johnthetubaguy: the test fail seemed just infra fail | 16:27 |
*** raildo has joined #openstack-nova | 16:28 | |
johnthetubaguy | dansmith: oh, yeah, just checked result, totally was | 16:28 |
*** harlowja has joined #openstack-nova | 16:31 | |
*** READ10 has quit IRC | 16:31 | |
*** bvanhav__ has joined #openstack-nova | 16:31 | |
*** bvanhav_ has quit IRC | 16:31 | |
*** tbachman has quit IRC | 16:31 | |
*** harlowja has quit IRC | 16:32 | |
*** rcernin has joined #openstack-nova | 16:32 | |
*** mvk has quit IRC | 16:32 | |
*** ljxiash has joined #openstack-nova | 16:33 | |
mriedem | _validate_and_build_base_options takinga billion args that aren't optional sucks | 16:33 |
*** mpaolino_ has quit IRC | 16:33 | |
mriedem | even though several are optional | 16:33 |
mriedem | </rant> | 16:33 |
*** cmartin has joined #openstack-nova | 16:34 | |
*** harlowja has joined #openstack-nova | 16:34 | |
openstackgerrit | Jabbar Ali proposed openstack/python-novaclient: Removing version error from command nova keypair-add help https://review.openstack.org/396312 | 16:34 |
danpb | mriedem: hey, look on the bright side, at least it isn't a single dict arg with no documentation about permitted keys :-) | 16:34 |
mriedem | danpb: i guess that's true | 16:35 |
mriedem | always the optimist | 16:35 |
openstackgerrit | Jabbar Ali proposed openstack/python-novaclient: Removing version error from command nova keypair-add help https://review.openstack.org/396312 | 16:36 |
*** Apoorva has joined #openstack-nova | 16:37 | |
*** links has quit IRC | 16:37 | |
*** baoli has quit IRC | 16:37 | |
openstackgerrit | Dan Smith proposed openstack/nova: Return build_requests instead of instances https://review.openstack.org/374267 | 16:38 |
openstackgerrit | Dan Smith proposed openstack/nova: Add schedule_and_build_instances conductor method https://review.openstack.org/367557 | 16:38 |
openstackgerrit | Dan Smith proposed openstack/nova: Refactor two nearly useless secgroup tests https://review.openstack.org/393438 | 16:38 |
openstackgerrit | Dan Smith proposed openstack/nova: Add CellDatabase fixture https://review.openstack.org/392925 | 16:38 |
openstackgerrit | Dan Smith proposed openstack/nova: Store security groups in RequestSpec https://review.openstack.org/394656 | 16:38 |
openstackgerrit | Dan Smith proposed openstack/nova: WIP Move instance creation to conductor https://review.openstack.org/319379 | 16:38 |
dansmith | mriedem: yeah we need some real cleanup of this code path when we're done | 16:38 |
*** sree has quit IRC | 16:38 | |
dansmith | mriedem: the requestspec work left a lot of hanging threads I think, but bauzas has plans to clean that up | 16:38 |
dansmith | so I think that will address a bunch of it | 16:38 |
bauzas | yeah, lemme write that specless BP | 16:39 |
bauzas | dansmith: mriedem: https://blueprints.launchpad.net/nova/+spec/request-spec-use-by-compute | 16:44 |
bauzas | mriedem: do you want to me to put it for the nova meeting tonight? | 16:45 |
bauzas | asking if it's a specless one ? | 16:45 |
bauzas | or are you okay right now ? | 16:45 |
*** catinthe_ has joined #openstack-nova | 16:45 | |
*** dikonoor has joined #openstack-nova | 16:45 | |
*** catintheroof has quit IRC | 16:46 | |
dansmith | I don't need to discuss it in a meeting | 16:46 |
*** mgoddard_ has joined #openstack-nova | 16:51 | |
*** tongli has joined #openstack-nova | 16:51 | |
mriedem | bauzas: i'm good with it as is | 16:52 |
mriedem | approved | 16:53 |
*** whenry has joined #openstack-nova | 16:54 | |
*** mgoddard has quit IRC | 16:54 | |
*** TravT has quit IRC | 16:55 | |
bauzas | mriedem: <3 | 16:58 |
*** mdrabe has quit IRC | 17:00 | |
openstackgerrit | STEW TY proposed openstack/nova: Transform instance.rescue notifications https://review.openstack.org/385644 | 17:00 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Fix notification doc generator https://review.openstack.org/396272 | 17:00 |
*** andreas_s has quit IRC | 17:01 | |
*** jaugustine_ has quit IRC | 17:02 | |
*** prashkre_ has quit IRC | 17:03 | |
*** prashkre_ has joined #openstack-nova | 17:03 | |
mdbooth | Need second +2 for an old test cleanup: https://review.openstack.org/#/c/344175/ | 17:05 |
*** rama_y has joined #openstack-nova | 17:07 | |
*** browne has joined #openstack-nova | 17:07 | |
*** ljxiash_ has joined #openstack-nova | 17:07 | |
*** ljxiash has quit IRC | 17:08 | |
*** sahid has quit IRC | 17:09 | |
*** nic has joined #openstack-nova | 17:10 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Transform requested secgroup names to uuids https://review.openstack.org/395747 | 17:10 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Rename security_group parameter in compute.API:create https://review.openstack.org/395746 | 17:10 |
mriedem | dansmith: just in time for my lunch \o/ | 17:10 |
dansmith | mriedem: thanks | 17:10 |
mriedem | the test i added covers the neutron wrinkles, | 17:10 |
*** mdrabe has joined #openstack-nova | 17:10 | |
mriedem | existing tests cover the n-net part | 17:10 |
*** mgoddard has joined #openstack-nova | 17:11 | |
*** mgoddard_ has quit IRC | 17:11 | |
mriedem | crap well i should run all of the tests quick | 17:11 |
*** lbrune has joined #openstack-nova | 17:13 | |
mriedem | gotta run but i'll deal with any fallout when i get back | 17:13 |
mriedem | changing that test class to use neuron might wonk something up, i didn't run the whole bucket yet | 17:14 |
openstackgerrit | Christopher Martin proposed openstack/nova: Fix for resize vm_state stopped rollback https://review.openstack.org/370861 | 17:15 |
*** ljxiash has joined #openstack-nova | 17:17 | |
dansmith | mdbooth: can you queue up a change for the missing call assertion? can be out of the way of the rest of the patches I think | 17:18 |
mdbooth | dansmith: Sec | 17:19 |
dansmith | mdbooth: you're also not asserting anything about some of the things that are mocked out, | 17:19 |
*** kaisers_ has joined #openstack-nova | 17:20 | |
dansmith | like that we call create_domain_and_network with the disk info we have, etc | 17:20 |
dansmith | which the other one wasn't doing either, but you said in your commit message that you were skeptical of how much it was testing | 17:20 |
dansmith | at least not losing the one assertion you're dropping seems like parity though | 17:20 |
dansmith | oh, you know what | 17:21 |
dansmith | I'm confusing the get_info and the get_disk_info call | 17:21 |
*** ljxiash_ has quit IRC | 17:21 | |
dansmith | I mean, you're still dropping an assertion | 17:21 |
mdbooth | The get_info one is kinda still asserted in a roundabout way | 17:21 |
mdbooth | Although we don't assert its argument... | 17:22 |
*** Swami has joined #openstack-nova | 17:22 | |
dansmith | that's what I mean, assert that it's called in the way we expect | 17:22 |
mdbooth | I can add that, it's trivial | 17:22 |
dansmith | any time we mock something out with some return value, I kinda think you should assert that it was called, and probably how you think | 17:22 |
dansmith | otherwise you could be mocking things out that have no effect | 17:22 |
mdbooth | This... is very true | 17:23 |
mdbooth | dansmith: I was considering being a bit rude and doing a long dump of patches, btw. | 17:24 |
mdbooth | Just the one :) | 17:24 |
mdbooth | Then incremental thereafter. | 17:25 |
*** matrohon has quit IRC | 17:25 | |
dansmith | you mean just to get everything up to date? | 17:25 |
mdbooth | Yeah | 17:25 |
dansmith | you could push it over the weekend and probably not ruffle any feathers | 17:25 |
dansmith | the gate is largely quiet starting friday afternoon in the US | 17:26 |
mdbooth | Better idea, but I'm away next week | 17:26 |
mdbooth | I'll drop a small batch | 17:26 |
dansmith | sure, but you're just updating what does it matter? or you mean you won't be around this weekend? | 17:26 |
dansmith | atq that mofo :) | 17:26 |
mdbooth | I will be travelling to our northern wastelands from 7am Saturday morning :) | 17:27 |
dansmith | heh | 17:27 |
mdbooth | atq would work: | 17:27 |
mdbooth | git review; poweroff | 17:27 |
dansmith | yeah | 17:27 |
bauzas | FWIW, French people have a mandatory bank holiday tomorrow | 17:29 |
*** baoli has joined #openstack-nova | 17:29 | |
mdbooth | bauzas: What's the penalty for working anyway? | 17:29 |
bauzas | mdbooth: tarring and feathering | 17:30 |
mdbooth | Excellent | 17:30 |
bauzas | remember, we made a revolution | 17:30 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Cleanup spawn tests https://review.openstack.org/344175 | 17:32 |
*** gouthamr has joined #openstack-nova | 17:33 | |
*** unicell1 has quit IRC | 17:35 | |
*** baoli has quit IRC | 17:36 | |
*** n0t-b3rn-n00dles is now known as d34dh0r53 | 17:36 | |
*** bvanhav_ has joined #openstack-nova | 17:36 | |
dansmith | mdbooth: thanks | 17:36 |
*** paul-carlton2 has quit IRC | 17:37 | |
*** bvanhav__ has quit IRC | 17:38 | |
*** lpetrut has quit IRC | 17:40 | |
*** baoli has joined #openstack-nova | 17:40 | |
*** dikonoor has quit IRC | 17:41 | |
*** lucasagomes is now known as lucas-afk | 17:41 | |
openstackgerrit | STEW TY proposed openstack/nova: Transform instance.rescue notifications https://review.openstack.org/385644 | 17:42 |
*** browne has quit IRC | 17:43 | |
*** owalsh has quit IRC | 17:46 | |
*** nicolasbock has quit IRC | 17:51 | |
*** gouthamr has quit IRC | 17:51 | |
*** oomichi_afk has quit IRC | 17:52 | |
*** derekh has quit IRC | 17:55 | |
*** markus_z has quit IRC | 17:57 | |
*** mgoddard_ has joined #openstack-nova | 17:58 | |
*** _ducttape_ has joined #openstack-nova | 18:00 | |
*** baoli has quit IRC | 18:00 | |
*** ralonsoh has quit IRC | 18:00 | |
*** mgoddard has quit IRC | 18:02 | |
*** baoli has joined #openstack-nova | 18:02 | |
*** avolkov has quit IRC | 18:03 | |
*** claudiub has quit IRC | 18:04 | |
*** ducttape_ has quit IRC | 18:04 | |
*** walharthi has joined #openstack-nova | 18:05 | |
*** nicolasbock has joined #openstack-nova | 18:06 | |
*** edand has quit IRC | 18:07 | |
*** slaweq_ has joined #openstack-nova | 18:08 | |
*** stewie925 has quit IRC | 18:09 | |
*** walharthi has quit IRC | 18:09 | |
*** walharthi has joined #openstack-nova | 18:09 | |
*** unicell has joined #openstack-nova | 18:11 | |
*** _ducttape_ has quit IRC | 18:12 | |
*** ducttape_ has joined #openstack-nova | 18:12 | |
mriedem | mandatory bank holiday?! | 18:13 |
mriedem | i guess tomorrow is veterans day in the US | 18:13 |
mriedem | but i get no time off for that | 18:14 |
artom | Rememberance Day in Canada... | 18:14 |
artom | Ironically, I do not remember it being a no-work holiday | 18:14 |
mriedem | dansmith: huh | 18:14 |
mriedem | cfg.BoolOpt('use_neutron', | 18:14 |
mriedem | default=False, | 18:14 |
mriedem | we should flip that to True in ocata | 18:14 |
nic | +1 | 18:15 |
mriedem | probably after https://review.openstack.org/#/c/392934/ | 18:15 |
*** slaweq_ has quit IRC | 18:15 | |
dansmith | mriedem: sure | 18:15 |
mriedem | ffs https://review.openstack.org/#/admin/groups/267,members | 18:16 |
*** baoli_ has joined #openstack-nova | 18:16 | |
*** baoli has quit IRC | 18:16 | |
mriedem | need a clone | 18:16 |
artom | mriedem, isn't that saying that infra-core is also a member? | 18:17 |
mriedem | yes | 18:17 |
mriedem | but i don't want to push there | 18:17 |
mriedem | sean is d-g's real dad | 18:17 |
*** jaugustine has joined #openstack-nova | 18:18 | |
openstackgerrit | Simona Iuliana Toader proposed openstack/nova-specs: Adds Hyper-V Shielded VMs spec https://review.openstack.org/274709 | 18:19 |
*** rama_y has quit IRC | 18:22 | |
*** baoli_ has quit IRC | 18:23 | |
*** browne has joined #openstack-nova | 18:25 | |
oomichi | mriedem: https://review.openstack.org/#/c/395746 seems to change internal names only, good for me | 18:26 |
mriedem | cool | 18:27 |
*** baoli has joined #openstack-nova | 18:27 | |
*** danpb has quit IRC | 18:32 | |
*** rama_y has joined #openstack-nova | 18:34 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Transform requested secgroup names to uuids https://review.openstack.org/395747 | 18:34 |
*** bvanhav_ has quit IRC | 18:35 | |
mriedem | ok that fixes the test failures ^ | 18:36 |
*** jamielennox|away is now known as jamielennox | 18:37 | |
*** sambetts is now known as sambetts|afk | 18:37 | |
*** bvanhav_ has joined #openstack-nova | 18:39 | |
*** pilgrimstack has joined #openstack-nova | 18:39 | |
*** Sukhdev has joined #openstack-nova | 18:40 | |
mriedem | dansmith: zuul jobs are happy with https://review.openstack.org/#/c/395746/ - only thing not done yet is multinode | 18:41 |
mriedem | if you want to get that in | 18:41 |
dansmith | yes I do | 18:41 |
*** lpetrut has joined #openstack-nova | 18:43 | |
cfriesen | slightly odd question...what's the point of having "suspend" ? As I recall we don't actually free up the resources, so what makes it better than "pause"? | 18:43 |
mriedem | because variety is the spice of life | 18:43 |
mriedem | no idea | 18:43 |
mriedem | there is a lot of general confusion around both | 18:43 |
mriedem | and when you'd care to use them | 18:43 |
dansmith | cfriesen: not all drivers support pause, suspended vms would survive a host reboot | 18:44 |
dansmith | cfriesen: and of course "because it's a thing we can do so obviously it should be supported" | 18:44 |
kashyap | Speaking of "general confusion", how can we forget: "evacuate...not really...I'm just a rebuild with a different name to confuse the heck out of you" | 18:45 |
dansmith | that last one is a joke, but probably most of the reason :) | 18:45 |
mriedem | dansmith: that last one is actually what i was thinking | 18:45 |
mriedem | qemu makes it available, so we had to have it | 18:45 |
dansmith | mriedem: yeah, I'm sure that's why it's there | 18:45 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Transform requested secgroup names to uuids https://review.openstack.org/395747 | 18:45 |
cfriesen | kashyap: yep...should be "resuscitate" or "revive" | 18:45 |
*** abalutoiu has quit IRC | 18:45 | |
kashyap | cfriesen: danpb once suggested `nova euthanize`... | 18:46 |
*** krtaylor has quit IRC | 18:46 | |
mriedem | it's not euthanize though | 18:46 |
mriedem | it's resurrect | 18:46 |
*** pilgrimstack has quit IRC | 18:46 | |
mriedem | only available around easter | 18:46 |
kashyap | Hehe | 18:46 |
*** Guest55156 has quit IRC | 18:48 | |
kashyap | mriedem: or dansmith: Have you have ever seen this: "Egg-link does not match installed location of nova" w/ DevStack - http://paste.openstack.org/show/588705/ | 18:48 |
kashyap | Although I gave up fixing that & was spinning a new DevStack VM, would be nice to know the root cause of it | 18:48 |
kashyap | Was discussion on #openstack-qa w/ Markus this morning, he thought I was trying with Newton, but, no: | 18:49 |
kashyap | $ git describe | 18:49 |
kashyap | 14.0.0.0rc1-677-gc26e12e | 18:49 |
mriedem | that's newton isn't it? | 18:51 |
mriedem | ocata is 15.x | 18:52 |
kashyap | Hmm, strange, all I did was just apply Matthew Booth's NFS patch series to Nova with `git review -d $ID` | 18:53 |
kashyap | (master) $ git describe | 18:53 |
kashyap | 14.0.0.0rc1-690-g327d81d | 18:53 |
mriedem | did you pip install that? | 18:53 |
kashyap | No, no | 18:53 |
mriedem | if i git review a change into devstack i pip install it after that | 18:54 |
kashyap | mriedem: Why would you `pip install`? Why wouldn't simply applying the patch to the Git suffice? | 18:54 |
mriedem | b/c the services are running from site-packages aren't they? | 18:55 |
mriedem | so pip install the change to get it into site-packages and then restart the affected service | 18:55 |
mriedem | i do: cd /opt/stack/nova; git review -d foo; pip install .; restart whatever | 18:56 |
kashyap | Ah, I thought just applying to the branch suffices,s igh | 18:56 |
mriedem | depends on what you're going to do with it i guess | 18:56 |
kashyap | mriedem: I have the NFS plugin & do some BFV & migration related functional tests | 18:57 |
mriedem | ok, yeah, then pip install and restart nova-compute | 18:57 |
kashyap | mriedem: Oh, I did the `git review -d` _just_ before starting DevStack | 18:58 |
kashyap | Even then you'd want me to run `pip install`? I don't think so, unless I'm terribly clueless | 18:58 |
kashyap | (Not that I'm clueful) | 18:58 |
kashyap | By "starting DevStack" I mean ./stack.sh | 18:59 |
*** walharthi has quit IRC | 18:59 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: neutron: handle no_allocate in create_pci_requests_for_sriov_ports https://review.openstack.org/396359 | 18:59 |
mriedem | kashyap: idk, i'd expect devstack to blow those changes away | 18:59 |
mriedem | or fail trying to overwrite them | 18:59 |
mriedem | devstack is picky | 18:59 |
kashyap | No worries, I'll try a few things. | 18:59 |
*** gszasz has quit IRC | 19:00 | |
kashyap | If you a second, can you quickly post `git describe` output from your current Git master? | 19:01 |
kashyap | I did that on two seperate checkouts, after a `git pull`, my version is: '14.0.0.0rc1-726-g949b742'. But Matt says above it should 15.x | 19:02 |
openstackgerrit | Chris Dent proposed openstack/nova: [placement] increase gabbi coverage of handlers.allocation https://review.openstack.org/396363 | 19:04 |
openstackgerrit | Chris Dent proposed openstack/nova: [placement] increase gabbi coverage of handlers.inventory https://review.openstack.org/396364 | 19:04 |
openstackgerrit | Chris Dent proposed openstack/nova: [placement] increase gabbi coverage of handlers.resource_provider https://review.openstack.org/396365 | 19:04 |
melwitt | that's odd, I never pip install anything when working with patches in devstack. I just 'git review -d' under /opt/stack/nova and restart the screen session | 19:05 |
kashyap | Okay, the latest tag is 14.0.2. So what I see is correct | 19:05 |
kashyap | melwitt: _Exactly_. I don't ever recall doing that. | 19:05 |
kashyap | And I swear it worked for me in the past, just checkout the change, and DevStack doesn't try to be cute with me & overrite my change or anything | 19:06 |
*** ljxiash has quit IRC | 19:06 | |
kashyap | That's how I run manual functional tests from patches that are WIP | 19:06 |
melwitt | yeah, devstack shouldn't overwrite anything unless you're using RECLONE=yes in your local.conf | 19:06 |
kashyap | Yeah, RECLONE is a bane. I avoid it like the plague | 19:06 |
kashyap | It just completely screws up Git info (at least for me) | 19:07 |
kashyap | melwitt: My setup (quite pared down) - http://paste.openstack.org/show/588807/ | 19:08 |
*** fragatina has joined #openstack-nova | 19:08 | |
* kashyap afk for the night, getting late here, and still have to grab dinner | 19:08 | |
*** rfolco has quit IRC | 19:10 | |
melwitt | from your first paste, it looks like it is or did install nova via a package, which I didn't think is usual. it usually just git clones nova from a branch | 19:10 |
melwitt | I use pretty barebones local.conf like http://paste.openstack.org/show/588809/ for neutron | 19:12 |
*** walharthi has joined #openstack-nova | 19:13 | |
*** ihrachys has quit IRC | 19:14 | |
mriedem | melwitt: note neutron is the default in devstack since newton | 19:15 |
mriedem | so you can drop all of the enable/disable service stuff in your local.conf | 19:15 |
melwitt | that's what I thought but I did a new devstack yesterday and it set up n-net | 19:16 |
*** yamahata has quit IRC | 19:16 | |
mriedem | did you use your local.conf? | 19:17 |
*** cdent has quit IRC | 19:18 | |
melwitt | not that one, no. one without any enable/disable service | 19:18 |
mriedem | hmm | 19:19 |
*** scottda has quit IRC | 19:20 | |
*** xyang1 has joined #openstack-nova | 19:21 | |
melwitt | I'm trying to see how it defaults in the devstack code | 19:21 |
*** krtaylor has joined #openstack-nova | 19:23 | |
mriedem | dansmith: shit is about to get real https://review.openstack.org/#/c/392934/ | 19:24 |
*** tbachman has joined #openstack-nova | 19:25 | |
mriedem | and omfg changing use_neutron=True by default totally makes our tests go crazy | 19:25 |
dansmith | heh yeah | 19:26 |
cburgess | mriedem Right but um shouldn't we really be moving to that anyways? | 19:26 |
*** walharthi has quit IRC | 19:26 | |
dansmith | cburgess: that's why it's coming up | 19:27 |
cburgess | indeed | 19:27 |
dansmith | cburgess: he's just saying it's going to be a bunch of busywork | 19:28 |
dansmith | melwitt: so, um, I'm hitting an issue with cell rpc routing when we have mappings in place | 19:28 |
cburgess | Well... busywork-ish. It has benifit in that we will now be defaulting in the gate to neutron. So better coverage. | 19:28 |
*** dave-mccowan has quit IRC | 19:28 | |
dansmith | melwitt: I feel like I should be getting rpc calls going to topic "compute.$host" but I'm just getting "compute" | 19:28 |
dansmith | melwitt: and thus timeouts in the tests | 19:28 |
melwitt | dansmith: hmm, looking | 19:29 |
dansmith | melwitt: seems like the devstack tests are working okay, so it must be right but I can't make the functional tests work | 19:29 |
dansmith | melwitt: in a sec I will have a regenerated failure to show you | 19:29 |
dansmith | melwitt: http://pastebin.com/LH5ka5ES | 19:30 |
dansmith | melwitt: L112 is the first failure that causes a cascade upwards | 19:30 |
dansmith | melwitt: shouldn't that be "compute.$host" ? | 19:31 |
dansmith | in this case $host = compute, so "compute.compute" | 19:31 |
melwitt | I'm not sure, tbh. I don't recall doing anything to set the topic | 19:32 |
dansmith | well, right, it's in the prepare() call, where you pass server=something | 19:32 |
*** browne has quit IRC | 19:32 | |
dansmith | but you changed/wrapped all of that with the router stuff | 19:32 |
dansmith | so I'm just not sure if I'm getting a timeout because that stuff is wrong, or what | 19:32 |
dansmith | this is all using fake rpc, so I would think that the topic must be wrong if I'm getting that kind of timeout | 19:33 |
melwitt | yeah, that makes sense | 19:33 |
melwitt | dansmith: how did you get the environment? set up devstack and then run functional tests? | 19:36 |
dansmith | melwitt: no devstack, this is just functional | 19:37 |
dansmith | melwitt: with this patch: https://review.openstack.org/#/c/319379 | 19:37 |
melwitt | okay | 19:37 |
dansmith | melwitt: just run one though because it takes a couple hours with all the timeouts | 19:37 |
*** dave-mccowan has joined #openstack-nova | 19:37 | |
dansmith | like test_create_and_delete_server | 19:37 |
melwitt | thanks | 19:37 |
melwitt | I'll pull that down so I can see what's going on here | 19:38 |
*** oanson has joined #openstack-nova | 19:38 | |
dansmith | melwitt: thanks.. this should result in the build going from api to conductor to compute, where before it was api->compute | 19:39 |
dansmith | but conductor was running anyway, and it seems to be getting to the conductor code and then failing on the call to compute which is weird | 19:39 |
dansmith | melwitt: and in compute/rpcapi, I'm printing host=, which is $compute, so it's not like we selected some non-running host or something | 19:39 |
mriedem | nice, 582 unit test failures alone | 19:39 |
mriedem | not counting functional | 19:39 |
openstackgerrit | Maciej Szankin proposed openstack/nova: conf: fix formatting in wsgi https://review.openstack.org/396374 | 19:40 |
melwitt | dansmith: weird. that's what I was going to do, see what host is. because that should be what's setting the topic like you said | 19:40 |
dansmith | yeah | 19:40 |
dansmith | and it appears not to ever hit the first line of build_and_run_instances(), so it's not like it's really doing the RPC but hanging in there or something | 19:42 |
*** liverpooler has quit IRC | 19:43 | |
*** jerrygb has joined #openstack-nova | 19:43 | |
*** mgoddard__ has joined #openstack-nova | 19:44 | |
dansmith | melwitt: if I force the host to be something else, I still get timeout on topic "compute" | 19:45 |
openstackgerrit | Maciej Szankin proposed openstack/nova: conf: fix formatting in availability_zone https://review.openstack.org/396377 | 19:46 |
melwitt | dansmith: so far I don't get the same failure as you do. did you have to do something more than just have that patch? I'm not getting a trace | 19:47 |
*** rfolco has joined #openstack-nova | 19:47 | |
dansmith | melwitt: oh heh yeah, it fails because no mappings anywhere without some changes, just a sec | 19:48 |
*** mgoddard_ has quit IRC | 19:48 | |
melwitt | I don't have a host-to-cell mapping it says | 19:48 |
*** openstackgerrit has quit IRC | 19:48 | |
*** openstackgerrit has joined #openstack-nova | 19:48 | |
*** mgoddard__ has quit IRC | 19:49 | |
*** cleong has quit IRC | 19:49 | |
* dansmith curses at git-stash | 19:50 | |
*** corey_ has joined #openstack-nova | 19:50 | |
*** brault has quit IRC | 19:50 | |
dansmith | melwitt: http://pastebin.com/raw/187UWSrn | 19:51 |
dansmith | melwitt: I get the same error on mitaka if I use a non-existent host.. just "topic `compute`" | 19:52 |
melwitt | thanks! | 19:52 |
dansmith | so it must show the topic and not the base.$host in the exception I guess | 19:52 |
melwitt | ah, okay | 19:52 |
dansmith | so then the other question is if the fake driver is somehow noticing that I have a different target | 19:53 |
dansmith | because the default target for the tests is "None" but now it's "fake://something" with the cell mapping, | 19:53 |
dansmith | since I can't store None in the cellmapping object | 19:53 |
dansmith | I looked at the fake driver, but it didn't seem to care what the transport_url was, but it must somehow | 19:53 |
dansmith | but if it does, I'm not sure where to go from here | 19:54 |
melwitt | yeah ... this is sounding a bit familiar from back when I was trying to write a mq switch functional test | 19:54 |
dansmith | oh? was that for testing the switching? | 19:54 |
dansmith | maybe there are clues in there | 19:54 |
melwitt | in the end, I couldn't because of the rpc global variables, I couldn't set up more than one rpc service to show switching between them | 19:55 |
dansmith | maybe I need to set the transport url before I start the fake compute service | 19:55 |
dansmith | hrm :/ | 19:55 |
*** yamahata has joined #openstack-nova | 19:55 | |
*** owalsh has joined #openstack-nova | 19:58 | |
*** ijw has joined #openstack-nova | 20:00 | |
melwitt | dansmith: set the transport url in the self.flags you mean? for the config | 20:01 |
dansmith | melwitt: set it before starting the compute service where it initializes its connection to the fake rpc | 20:01 |
dansmith | doesn't help tho | 20:02 |
melwitt | yeah but you mean as in the config setting? oh | 20:02 |
*** krtaylor has quit IRC | 20:02 | |
* dansmith tries putting a 9mm hole in a specific spot | 20:02 | |
*** rfolco has quit IRC | 20:03 | |
openstackgerrit | Lee Yarwood proposed openstack/nova: encryptors: Introduce encryption provider constants https://review.openstack.org/393901 | 20:05 |
*** rfolco has joined #openstack-nova | 20:05 | |
*** rfolco has quit IRC | 20:05 | |
*** baoli_ has joined #openstack-nova | 20:06 | |
*** baoli has quit IRC | 20:07 | |
*** jamesdenton has quit IRC | 20:08 | |
dansmith | melwitt: can you tell me more about what you were trying to do and what didn't work? | 20:08 |
dansmith | melwitt: you should have been able to start multiple services with different configs, | 20:08 |
dansmith | the thing that I don't know is whether the fake rpc transport would distinguish between them or not | 20:09 |
dansmith | I kinda expected it is just one fake bus, but ... seems like maybe not | 20:09 |
melwitt | dansmith: it was several months ago so my memory is hazy, but it was that I couldn't have two separate instances of the RPCFIxture such that one's globals wouldn't overwrite the other | 20:09 |
melwitt | globals in nova/rpc.py that is | 20:09 |
*** johnthetubaguy has quit IRC | 20:10 | |
melwitt | when it does rpc.init() and it sets TRANSPORT | 20:11 |
dansmith | melwitt: globals like what? TRANSPORT= ? | 20:11 |
*** baoli_ has quit IRC | 20:11 | |
melwitt | yes | 20:11 |
*** johnthetubaguy has joined #openstack-nova | 20:11 | |
dansmith | melwitt: so, hrm.. why isn't that going to be a problem at runtime? | 20:12 |
*** baoli has joined #openstack-nova | 20:12 | |
melwitt | dansmith: because each service is a separate instance of rpc, separate processes | 20:12 |
dansmith | melwitt: you mean there were global issues for the receiving side, but not the sending side? | 20:13 |
dansmith | hrm, no TRANSPORT is a global used by get_client() | 20:15 |
melwitt | dansmith: I don't remember the details now, but the main point was each instance needed a separate config | 20:15 |
*** krtaylor has joined #openstack-nova | 20:15 | |
dansmith | melwitt: right, but I'm trying to figure out why this isn't going to be a problem for the client-side switching | 20:15 |
dansmith | like when api is talking to conductors in lots of different cells in a single process | 20:15 |
melwitt | dansmith: the global TRANSPORT is for talking to your own local queue and then the switching part can talk to another queue | 20:16 |
melwitt | and the problem was the local queue got overwritten with the other service's config, if that makes sense | 20:17 |
dansmith | melwitt: okay, but in that case, can't we have set the config, nulled out TRANSPORT, started the service, then tweak config, null out TRANSPORT, started another service ? | 20:17 |
*** eharney has quit IRC | 20:18 | |
dansmith | "can't we have" ? .. maybe "couldn't we have" | 20:19 |
melwitt | I thought that would with both services having TRANSPORT set to the same thing after the second one was started? | 20:20 |
melwitt | *end up with | 20:20 |
dansmith | not if we killed the global before starting the second one, AFAICT | 20:21 |
dansmith | melwitt: the reason I'm asking about that is just trying to figure out how this might be going right now, | 20:22 |
dansmith | because our rpcclient cals rpc.get_client() for the "base client" or something, and then supposedly overrides it with the switching later, | 20:22 |
melwitt | okay. I'm not sure. I don't know about nulling out globals allowing them to be set differently for two different objects | 20:22 |
dansmith | but maybe that doesn't happen somehow? | 20:22 |
dansmith | melwitt: the symbol is global, but if you set it to something, and a thing grabs a ref to that, then you set the global to something else and a second thing grabs a ref to the new one, they'll be separate | 20:23 |
melwitt | I see | 20:23 |
melwitt | I guess this smells of the same problem. because we want conductor to have one RPCFixture config and compute to have another | 20:25 |
*** tbachman has quit IRC | 20:25 | |
dansmith | melwitt: right | 20:25 |
openstackgerrit | STEW TY proposed openstack/nova: Transform instance.rescue notifications https://review.openstack.org/385644 | 20:26 |
*** hshiina has joined #openstack-nova | 20:27 | |
*** gyee has joined #openstack-nova | 20:27 | |
*** kylek3h has quit IRC | 20:28 | |
*** moshele has joined #openstack-nova | 20:29 | |
*** baoli has quit IRC | 20:30 | |
*** baoli has joined #openstack-nova | 20:30 | |
*** slaweq_ has joined #openstack-nova | 20:30 | |
mriedem | diana_clarke: i saw your reply in the ML about that flavors/ephemeral job thing wrt tempest - i can probably help you out a bit there if you want to push on it | 20:31 |
mriedem | diana_clarke: i think the first part is pretty simple - devstack creates special flavors for tempest, we'd just modify those flavors to have ephemeral and/or swap disk too | 20:32 |
diana_clarke | mriedem: Sure! I'll make a note to circle back on Monday. Much appreciated, BTW. | 20:32 |
mriedem | then modify your tempest patch to instead of create flavors, it uses the flavors from the config and checks to see if they have ephemeral or swap, or whatever you mean to test - if they don't, you skip the test | 20:32 |
mriedem | so out of tree people running tempest don't break by default, | 20:32 |
diana_clarke | mriedem: I just pushed a first pass at those skips. I'm not 100% it's correct b/c I still have some huge knowledge gaps. | 20:32 |
mriedem | but we can run the tests upstream | 20:33 |
mriedem | the first step is probably the devstack change | 20:33 |
mriedem | the tempest test then depends on the devstack change | 20:33 |
melwitt | dansmith: each test has only one RPCFixture presently (in TestCase setUp). so I need to figure out how to have a separate one per service for functional tests that are doing real mq switching, doing the nulling out you mentioned | 20:33 |
*** bvanhav_ has quit IRC | 20:33 | |
diana_clarke | mriedem: Add missing volume clone & snapshot skips - https://review.openstack.org/#/c/396393/ | 20:33 |
mriedem | diana_clarke: cool, will look at that | 20:33 |
*** eharney has joined #openstack-nova | 20:34 | |
*** rcernin has quit IRC | 20:36 | |
mriedem | diana_clarke: some comments / questions inline | 20:37 |
mriedem | i'll add that as a depends-on to my NFS plugin patch though to see what gets better | 20:37 |
*** cmartin has quit IRC | 20:39 | |
mriedem | btw, the d-g change to run neutron by default in CI has landed | 20:39 |
mriedem | prep for fireworks | 20:40 |
dansmith | melwitt: I might have a tiny handle on what is going on | 20:42 |
*** browne has joined #openstack-nova | 20:42 | |
melwitt | do tell | 20:43 |
dansmith | let me try to get it straight in my head first | 20:43 |
openstackgerrit | Hans Lindgren proposed openstack/nova: WIP:remove ec2 metadata https://review.openstack.org/282872 | 20:46 |
*** slaweq_ has quit IRC | 20:49 | |
*** thorst_ has quit IRC | 20:51 | |
*** slaweq_ has joined #openstack-nova | 20:51 | |
*** erhudy has quit IRC | 20:51 | |
*** thorst_ has joined #openstack-nova | 20:51 | |
mriedem | nova meeting in 6 minutes | 20:54 |
*** gyee has quit IRC | 20:54 | |
mriedem | it's sure to be a real hootenanny | 20:54 |
*** takashin has joined #openstack-nova | 20:54 | |
melwitt | in that case, I'll attend! | 20:55 |
*** thorst_ has quit IRC | 20:56 | |
dansmith | I think mriedem is setting us up for disappointment | 20:57 |
*** raildo has quit IRC | 20:57 | |
*** cdent has joined #openstack-nova | 20:57 | |
dims | mriedem : what are you serving during the meeting? | 20:57 |
mriedem | it's going to be phenomenal | 20:58 |
*** _ducttape_ has joined #openstack-nova | 20:58 | |
bauzas | ooooooh right | 20:58 |
bauzas | I forgot about the meeting :p | 20:58 |
mriedem | i see jroll has his requisite 5 ironic specless blueprints all lined up... | 20:58 |
* bauzas should be having his nick being "topic" | 20:59 | |
*** bauzas is now known as topic | 20:59 | |
topic | heh that works \o/ | 20:59 |
*** topic is now known as bauzas | 20:59 | |
jroll | mriedem: I didn't do nothin! | 21:00 |
jroll | ah hshiina added those | 21:00 |
mriedem | jk buddy | 21:00 |
jroll | :P | 21:00 |
*** ducttape_ has quit IRC | 21:02 | |
*** jdandrea has joined #openstack-nova | 21:05 | |
jdandrea | Can someone please point me to links around the upcoming placement API, if/how it ties in to nova-scheduler? Looking for blueprints and not finding them yet. | 21:06 |
*** baoli has quit IRC | 21:07 | |
*** baoli has joined #openstack-nova | 21:07 | |
*** ihrachys has joined #openstack-nova | 21:11 | |
dansmith | melwitt: yeah I dun lasso'd this here dogie | 21:11 |
*** moshele has quit IRC | 21:11 | |
melwitt | dansmith: good because I didn't find anything yet | 21:12 |
dansmith | melwitt: I shall clean up my mess and show you in code, which will be easiest I hink | 21:12 |
melwitt | k | 21:12 |
*** unicell has quit IRC | 21:13 | |
*** walharthi has joined #openstack-nova | 21:13 | |
*** ayoung has quit IRC | 21:15 | |
*** slaweq_ has quit IRC | 21:16 | |
*** unicell has joined #openstack-nova | 21:16 | |
*** slaweq_ has joined #openstack-nova | 21:17 | |
*** moshele has joined #openstack-nova | 21:17 | |
*** smatzek has quit IRC | 21:21 | |
*** portdirect is now known as portdirect_away | 21:23 | |
*** dave-mccowan has quit IRC | 21:24 | |
dansmith | melwitt: so I thought we had db switching in place already | 21:26 |
dansmith | but apparently we do not so much | 21:26 |
dansmith | we do at the low layers I guess, but need it in the api | 21:26 |
cdent | jdandrea: the terms you probably don't know you need are "resource pools", "resource providers", "resource classes" | 21:27 |
*** lbeliveau_ is now known as lbeliveau | 21:27 | |
cdent | jdandrea: that will lead you to things like: | 21:27 |
dansmith | so we'll have to cheat in our tests a little, to replicate the fact that even though we have mappings for real now, they're all in the same db | 21:27 |
jdandrea | cdent Ahh! | 21:27 |
jdandrea | Also looking at the etherpads. | 21:27 |
jdandrea | For Ocata. | 21:27 |
jdandrea | But I didn't see a Placement API specific link. | 21:27 |
cdent | http://specs.openstack.org/openstack/nova-specs/specs/newton/implemented/generic-resource-pools.html | 21:27 |
*** slaweq_ has quit IRC | 21:28 | |
cdent | jdandrea: ocata specs for placement stuff haven't merged yet, but some things under review are: | 21:28 |
*** slaweq_ has joined #openstack-nova | 21:28 | |
jdandrea | Yes please - under review is terrific too! | 21:28 |
cdent | https://review.openstack.org/#/c/300178/ and https://review.openstack.org/#/c/312696/ | 21:29 |
*** kylek3h has joined #openstack-nova | 21:29 | |
*** walharthi has quit IRC | 21:29 | |
cdent | there's a long list of cleanup work being done from the work already done in newton at: https://etherpad.openstack.org/p/placement-newton-leftovers | 21:29 |
melwitt | dansmith: hm, okay. was not expecting that to be related. the default behavior is not to switch dbs if there's no db_connection info in the request context | 21:30 |
cdent | jdandrea: and you'll find some other stuff in the scheduler section of https://etherpad.openstack.org/p/ocata-nova-priorities-tracking | 21:31 |
dansmith | melwitt: it's not, but once I had the mq switching working I realized that the db bit isn't complete | 21:31 |
cdent | jdandrea: that enough? | 21:31 |
melwitt | dansmith: oh, okay | 21:31 |
dansmith | melwitt: basically, in this test just here, I have a working multi cell environment, except that api doesn't do the db switching it needs to look up instances after they're created in a cell | 21:31 |
dansmith | melwitt: but, pretty cool :) | 21:31 |
melwitt | dansmith: very cool | 21:32 |
*** maticue has quit IRC | 21:32 | |
*** slaweq_ has quit IRC | 21:32 | |
*** _ducttape_ has quit IRC | 21:32 | |
*** gyee has joined #openstack-nova | 21:32 | |
*** ducttape_ has joined #openstack-nova | 21:32 | |
*** slaweq_ has joined #openstack-nova | 21:32 | |
*** Jeffrey4l has quit IRC | 21:33 | |
*** ihrachys has quit IRC | 21:33 | |
*** whenry has quit IRC | 21:36 | |
*** ijw has quit IRC | 21:37 | |
*** ihrachys has joined #openstack-nova | 21:37 | |
*** moshele has quit IRC | 21:37 | |
*** baoli has quit IRC | 21:39 | |
takashin | dansmith: Could you review https://review.openstack.org/#/c/334732/ again? | 21:39 |
dansmith | takashin: at some point, but I'm really busy at the momem | 21:39 |
dansmith | er, moment | 21:39 |
mriedem | jdandrea: also, at a high level http://lists.openstack.org/pipermail/openstack-dev/2016-November/106590.html | 21:39 |
mriedem | jdandrea: also look at the resource providers specs for newton https://specs.openstack.org/openstack/nova-specs/specs/newton/index.html | 21:40 |
mriedem | some of that has probably diverged a bit | 21:40 |
takashin | dansmith: How about next week? | 21:40 |
dansmith | takashin: yes, probably before then | 21:41 |
takashin | dansmith: Thank you. | 21:41 |
jdandrea | mriedem, cdent: You are super extra awesome. Thank you so much. | 21:41 |
jdandrea | That is plenty to read and digest. Very much appreciated. | 21:42 |
cdent | jdandrea: you have plans, or just preparing yourself? | 21:42 |
*** baoli has joined #openstack-nova | 21:42 | |
*** dave-mccowan has joined #openstack-nova | 21:42 | |
*** baoli_ has joined #openstack-nova | 21:43 | |
*** hshiina has quit IRC | 21:46 | |
*** thorst_ has joined #openstack-nova | 21:46 | |
*** baoli has quit IRC | 21:47 | |
*** owalsh has quit IRC | 21:53 | |
*** tbachman has joined #openstack-nova | 21:53 | |
*** baoli_ has quit IRC | 21:56 | |
*** baoli has joined #openstack-nova | 21:56 | |
*** annegentle has quit IRC | 21:56 | |
*** annegentle has joined #openstack-nova | 21:57 | |
openstackgerrit | sean mooney proposed openstack/nova: convert libvirt driver to use os-vif for vhost-user with ovs. https://review.openstack.org/334048 | 21:57 |
dansmith | melwitt: incoming | 21:57 |
openstackgerrit | Dan Smith proposed openstack/nova: Return build_requests instead of instances https://review.openstack.org/374267 | 21:57 |
openstackgerrit | Dan Smith proposed openstack/nova: Add schedule_and_build_instances conductor method https://review.openstack.org/367557 | 21:57 |
openstackgerrit | Dan Smith proposed openstack/nova: Refactor two nearly useless secgroup tests https://review.openstack.org/393438 | 21:57 |
openstackgerrit | Dan Smith proposed openstack/nova: Add CellDatabase fixture https://review.openstack.org/392925 | 21:57 |
*** annegentle has quit IRC | 21:57 | |
openstackgerrit | Dan Smith proposed openstack/nova: Store security groups in RequestSpec https://review.openstack.org/394656 | 21:58 |
openstackgerrit | Dan Smith proposed openstack/nova: WIP Move instance creation to conductor https://review.openstack.org/319379 | 21:58 |
openstackgerrit | Dan Smith proposed openstack/nova: Make RPCFixture support multiple connections https://review.openstack.org/396417 | 21:58 |
*** ijw has joined #openstack-nova | 21:58 | |
dansmith | melwitt: specifically this: https://review.openstack.org/#/c/396417/ | 21:58 |
dansmith | melwitt: now we need to implement the config switching at service start for those tests | 21:58 |
*** cdent has quit IRC | 21:58 | |
dansmith | melwitt: but with that in place, we can actually find the separate busses | 21:59 |
jdandrea | cdent: Preparing myself. | 21:59 |
dansmith | melwitt: in the next patch I have a hack in place to coerce them all to the same url, | 21:59 |
dansmith | which makes it work again | 21:59 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Stop using mox stubs in nova/tests/unit/cells https://review.openstack.org/323287 | 21:59 |
*** catinthe_ has quit IRC | 21:59 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Stop using mox stubs in nova/tests/unit/virt/disk https://review.openstack.org/322778 | 21:59 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix 'id' (attachment_id) parameters https://review.openstack.org/349863 | 21:59 |
*** smatzek has joined #openstack-nova | 22:01 | |
*** ijw has quit IRC | 22:01 | |
*** ijw has joined #openstack-nova | 22:02 | |
*** smatzek has quit IRC | 22:02 | |
*** eharney has quit IRC | 22:03 | |
openstackgerrit | melanie witt proposed openstack/nova: Detach volume after deleting instance with no host https://review.openstack.org/340614 | 22:03 |
*** prashkre_ has quit IRC | 22:04 | |
*** ijw has quit IRC | 22:05 | |
melwitt | dansmith: cool, looking at it now | 22:05 |
*** ijw has joined #openstack-nova | 22:05 | |
*** portdirect_away is now known as portdirect | 22:07 | |
*** dave-mccowan has quit IRC | 22:08 | |
*** lbrune has quit IRC | 22:14 | |
*** smatzek has joined #openstack-nova | 22:14 | |
*** nic has quit IRC | 22:15 | |
mriedem | lpetrut: i dumped some comments in https://review.openstack.org/#/c/273504/ - i'm a bit confused on the diff between PS15 and PS18 | 22:16 |
mriedem | lpetrut: but, i've got to head out pretty soon | 22:16 |
*** ijw has quit IRC | 22:16 | |
*** baoli has quit IRC | 22:17 | |
*** baoli has joined #openstack-nova | 22:17 | |
*** tongli has quit IRC | 22:17 | |
*** mriedem has quit IRC | 22:18 | |
*** ijw has joined #openstack-nova | 22:18 | |
openstackgerrit | Sujitha proposed openstack/nova: Change os-server-tags default policy https://review.openstack.org/396420 | 22:18 |
*** annegentle has joined #openstack-nova | 22:18 | |
lpetrut | mriedem: thanks, yeah, on a last minute call we've decided that those config options could still be useful in some cases and decided to leave them there and honor them (a bit differently than before) | 22:18 |
*** jerrygb_ has joined #openstack-nova | 22:21 | |
openstackgerrit | Sujitha proposed openstack/nova: Change os-server-tags default policy https://review.openstack.org/396420 | 22:21 |
*** jerrygb has quit IRC | 22:24 | |
*** jerrygb has joined #openstack-nova | 22:25 | |
*** jerrygb_ has quit IRC | 22:26 | |
*** jerrygb_ has joined #openstack-nova | 22:27 | |
*** jamesdenton has joined #openstack-nova | 22:28 | |
*** jheroux has quit IRC | 22:28 | |
*** jerrygb has quit IRC | 22:30 | |
*** jerrygb_ has quit IRC | 22:31 | |
openstackgerrit | Jin Li proposed openstack/nova: Transform instance.soft_delete notifications https://review.openstack.org/383970 | 22:33 |
*** fragatin_ has joined #openstack-nova | 22:34 | |
*** mvk has joined #openstack-nova | 22:34 | |
*** esberglu has quit IRC | 22:36 | |
*** esberglu has joined #openstack-nova | 22:37 | |
*** fragatina has quit IRC | 22:37 | |
*** baoli has quit IRC | 22:38 | |
openstackgerrit | Jin Li proposed openstack/nova: Transform instance.soft_delete notifications https://review.openstack.org/383970 | 22:38 |
*** baoli has joined #openstack-nova | 22:39 | |
*** esberglu has quit IRC | 22:41 | |
*** victorhe_ has joined #openstack-nova | 22:43 | |
*** lamt has quit IRC | 22:44 | |
*** Hosam_ has joined #openstack-nova | 22:44 | |
*** kylek3h has quit IRC | 22:46 | |
*** victorhe has quit IRC | 22:47 | |
*** victorhe_ has quit IRC | 22:48 | |
*** jamesdenton has quit IRC | 22:49 | |
*** oanson has quit IRC | 22:50 | |
*** jaugustine has quit IRC | 22:50 | |
*** jamesdenton has joined #openstack-nova | 22:50 | |
*** esberglu has joined #openstack-nova | 22:50 | |
*** jaugustine has joined #openstack-nova | 22:51 | |
*** jamesdenton has quit IRC | 22:51 | |
*** esberglu has quit IRC | 22:54 | |
*** jaugustine has quit IRC | 22:55 | |
*** Swami has quit IRC | 22:56 | |
dansmith | melwitt: also looks like server list is not including build requests or something like that | 22:57 |
dansmith | detail seems to be, but not list | 22:57 |
dansmith | which is supposed to be done, but must be a bug there | 22:57 |
*** rrecio_ has joined #openstack-nova | 22:57 | |
*** rrecio_ has quit IRC | 22:57 | |
*** mriedem has joined #openstack-nova | 22:58 | |
melwitt | dansmith: hm yeah, I thought it should be | 22:58 |
dansmith | melwitt: I'm going to run off for a bit, but will hit that tomorrow | 22:59 |
dansmith | however, dangerously close to working sheeyat, so that's cool | 22:59 |
*** cdent has joined #openstack-nova | 22:59 | |
*** baoli has quit IRC | 23:00 | |
*** baoli has joined #openstack-nova | 23:00 | |
*** rrecio has quit IRC | 23:00 | |
melwitt | dansmith: okay, cool. definitely exciting stuff :) | 23:01 |
*** cdent has quit IRC | 23:01 | |
*** rama_y has quit IRC | 23:02 | |
mriedem | do we have changes up for the security group uuid storing stuff yet? | 23:02 |
mriedem | if not i can get cracking on that | 23:03 |
melwitt | mriedem: is that this or something else? https://review.openstack.org/#/c/394656/ | 23:04 |
*** fragatin_ has quit IRC | 23:04 | |
*** catintheroof has joined #openstack-nova | 23:05 | |
mriedem | something else | 23:05 |
*** fragatina has joined #openstack-nova | 23:05 | |
*** lpetrut has quit IRC | 23:05 | |
mriedem | melwitt: but it comes before ^ | 23:06 |
mriedem | and after this https://review.openstack.org/#/c/395747/ | 23:07 |
*** smatzek has quit IRC | 23:07 | |
mriedem | we're going to store the security groups in the request spec, but need to store the uuids for the requested neutron security groups so we can look those up later in case the name changes | 23:07 |
mriedem | not sure if we're going to model that after the NeutronFloatingIP object or not | 23:07 |
mriedem | which extends the FloatingIP object but sets the id field to be a string type | 23:08 |
mriedem | for storing uuids | 23:08 |
mriedem | melwitt: if you want to work on that go ahead | 23:08 |
*** mdrabe has quit IRC | 23:08 | |
melwitt | oh, okay. I don't know of any changes doing that then but that doesn't mean a lot since I wasn't involved in those discussions | 23:09 |
*** catintheroof has quit IRC | 23:09 | |
melwitt | mriedem: no, I was just checking if that change was what you were asking about | 23:10 |
*** corey_ has quit IRC | 23:10 | |
mriedem | alright well if you don't want to spend your thursday night working on this....then i guess that's fine :) | 23:10 |
*** baoli has quit IRC | 23:11 | |
melwitt | heh. it's not as much that as, I really don't know what's going on there. kind of playing a bit of catch up | 23:11 |
*** tblakes has quit IRC | 23:11 | |
mriedem | very simple, we want this https://github.com/openstack/nova/blob/master/nova/objects/floating_ip.py#L236 | 23:11 |
mriedem | but for security groups | 23:11 |
mriedem | and just 'id': fields.UUIDField(), | 23:12 |
mriedem | there will be a riveting browns vs ravens NFL game tonight though so... | 23:12 |
mriedem | whoever can score 9 points wins! | 23:12 |
mriedem | i'll put up something quick and deal with tests later | 23:13 |
melwitt | oh, okay. I can take a crack at it then. it's still afternoon here | 23:13 |
mriedem | doh | 23:13 |
mriedem | alternatively, review this https://review.openstack.org/#/c/395747/ | 23:13 |
*** burt has quit IRC | 23:13 | |
mriedem | b/c it's going on top of that | 23:13 |
melwitt | sure | 23:14 |
*** rama_y has joined #openstack-nova | 23:15 | |
*** kylek3h has joined #openstack-nova | 23:15 | |
*** Sukhdev has quit IRC | 23:16 | |
*** catintheroof has joined #openstack-nova | 23:17 | |
*** xyang1 has quit IRC | 23:20 | |
*** ducttape_ has quit IRC | 23:20 | |
*** ayoung has joined #openstack-nova | 23:22 | |
*** hongbin has quit IRC | 23:24 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Transform requested secgroup names to uuids https://review.openstack.org/395747 | 23:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add NeutronSecurityGroup object https://review.openstack.org/396436 | 23:24 |
*** esberglu has joined #openstack-nova | 23:29 | |
*** esberglu has quit IRC | 23:29 | |
*** esberglu has joined #openstack-nova | 23:30 | |
*** ntpttr has quit IRC | 23:30 | |
*** ntpttr has joined #openstack-nova | 23:31 | |
*** Jeffrey4l has joined #openstack-nova | 23:31 | |
*** victorhe has joined #openstack-nova | 23:32 | |
*** hongbin has joined #openstack-nova | 23:32 | |
*** diogogmt has quit IRC | 23:33 | |
*** esberglu has quit IRC | 23:34 | |
*** victorhe has quit IRC | 23:36 | |
*** diogogmt has joined #openstack-nova | 23:43 | |
*** ijw has quit IRC | 23:44 | |
*** ijw has joined #openstack-nova | 23:44 | |
mriedem | hmm, damn. you can't store a NeutronSecurityGroup object in a SecurityGroupList | 23:45 |
mriedem | even though NeutronSecurityGroup extends SecurityGroup | 23:45 |
*** ijw has quit IRC | 23:46 | |
*** ijw has joined #openstack-nova | 23:46 | |
*** slaweq_ has quit IRC | 23:51 | |
*** slaweq_ has joined #openstack-nova | 23:52 | |
*** annegentle has quit IRC | 23:53 | |
artom | mriedem, you'd need subclasses=True for that (or something to that effect, from memory) | 23:53 |
*** krtaylor has quit IRC | 23:54 | |
mriedem | artom: yup i just found that | 23:54 |
mriedem | i'm still having a conundrum | 23:54 |
mriedem | about whether or not this neutron security group object will have a uuid field as an id, which depends on if we store the 'default' secgroup in there | 23:54 |
*** ihrachys has quit IRC | 23:55 | |
mriedem | even though if that's all you request, or didn't request anything, nova passes ['default'] down to the neutron api code which just ignores it | 23:55 |
*** amotoki has joined #openstack-nova | 23:58 | |
*** amotoki has quit IRC | 23:58 | |
*** amotoki has joined #openstack-nova | 23:58 | |
*** claudiub has joined #openstack-nova | 23:58 | |
*** annegentle has joined #openstack-nova | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!