| melwitt | relaxing, huh? | 00:00 |
|---|---|---|
| mriedem | for your morning crepe | 00:00 |
| bauzas | I never eat crepes at breakfast | 00:00 |
| bauzas | that's so US | 00:00 |
| mriedem | ha | 00:00 |
| melwitt | ouch | 00:00 |
| mriedem | well as long as you have a black and white striped shirt | 00:00 |
| mriedem | and possibly an ascot | 00:01 |
| bauzas | I definitely prefer eating those by dinner, with salted stuff on it :) | 00:01 |
| *** Swami_ has joined #openstack-nova | 00:01 | |
| bauzas | like ham and cheese | 00:01 |
| *** ducttape_ has quit IRC | 00:02 | |
| mriedem | speaking of which, i'm going to go home and eat something, probably unsatisfying | 00:02 |
| *** mriedem has quit IRC | 00:03 | |
| bauzas | mriedem: good catch for the relnotes, have you also looked at the HTML rendering ? | 00:03 |
| bauzas | oh snap | 00:03 |
| bauzas | sounds like I hurted him with a crepe | 00:03 |
| *** Swami has quit IRC | 00:05 | |
| *** baoli has quit IRC | 00:05 | |
| *** jamespage has quit IRC | 00:06 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Fix some release notes in preparation for the o-2 beta release https://review.openstack.org/411005 | 00:06 |
| *** asettle has joined #openstack-nova | 00:08 | |
| *** Swami__ has joined #openstack-nova | 00:08 | |
| *** asettle has quit IRC | 00:08 | |
| *** asettle has joined #openstack-nova | 00:08 | |
| *** asettle has quit IRC | 00:09 | |
| *** Swami_ has quit IRC | 00:11 | |
| *** jamespage has joined #openstack-nova | 00:13 | |
| *** diogogmt has quit IRC | 00:15 | |
| *** dtp has quit IRC | 00:16 | |
| *** esberglu has joined #openstack-nova | 00:17 | |
| *** jamespage has quit IRC | 00:17 | |
| *** esberglu has quit IRC | 00:18 | |
| *** esberglu has joined #openstack-nova | 00:19 | |
| *** asettle has joined #openstack-nova | 00:19 | |
| *** siva_krish has quit IRC | 00:20 | |
| *** ijw has quit IRC | 00:21 | |
| *** ijw has joined #openstack-nova | 00:21 | |
| *** esberglu has quit IRC | 00:23 | |
| *** asettle has quit IRC | 00:23 | |
| *** ijw has quit IRC | 00:26 | |
| *** yingjun has joined #openstack-nova | 00:29 | |
| *** claudiub has quit IRC | 00:31 | |
| *** lamt has quit IRC | 00:35 | |
| *** kfarr has quit IRC | 00:42 | |
| *** ijw has joined #openstack-nova | 00:42 | |
| openstackgerrit | melanie witt proposed openstack/nova: Add detail to cellsv2-related release notes https://review.openstack.org/410009 | 00:44 |
| *** gouthamr has quit IRC | 00:45 | |
| *** jamespage has joined #openstack-nova | 00:45 | |
| openstackgerrit | melanie witt proposed openstack/nova: Add detail to cellsv2-related release notes https://review.openstack.org/410009 | 00:46 |
| *** mriedem has joined #openstack-nova | 00:46 | |
| *** ijw has quit IRC | 00:48 | |
| *** hongbin has quit IRC | 00:52 | |
| *** nic has quit IRC | 00:52 | |
| *** ijw has joined #openstack-nova | 00:53 | |
| *** fragatina has joined #openstack-nova | 00:55 | |
| *** zhangyujun has quit IRC | 00:56 | |
| *** claudiub has joined #openstack-nova | 00:57 | |
| *** zhangyujun has joined #openstack-nova | 00:57 | |
| *** jamielennox is now known as jamielennox|away | 00:58 | |
| *** phuongnh has joined #openstack-nova | 00:59 | |
| *** jamielennox|away is now known as jamielennox | 01:00 | |
| mriedem | melwitt: i think i'm going to write up a spec, or start writing one, for the quota classes stuff so we at least don't lose that. especially given i spent some time refiguring that stuff out | 01:11 |
| mriedem | don't know i'll actually be working on it in pike but someone else could | 01:11 |
| melwitt | mriedem: okay, cool. I can review it with my half baked quota class knowledge | 01:12 |
| *** diogogmt has joined #openstack-nova | 01:13 | |
| mriedem | btw, i think you're getting dinged on the column width on https://review.openstack.org/#/c/410009/5/releasenotes/notes/ocata-requires-cellv2-96bd243be874d77f.yaml | 01:13 |
| melwitt | thank you. I was just looking at it and not realizing what's wrong | 01:14 |
| *** melwitt has left #openstack-nova | 01:14 | |
| *** melwitt has joined #openstack-nova | 01:14 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs: Expose BDM tags in REST API https://review.openstack.org/393930 | 01:17 |
| *** Jinxing has joined #openstack-nova | 01:18 | |
| *** Jinxing has quit IRC | 01:18 | |
| melwitt | tox -ereleasenotes passes locally. and I don't know how to tell what the width limit is | 01:19 |
| *** yamahata_ has joined #openstack-nova | 01:24 | |
| *** ijw has quit IRC | 01:24 | |
| *** ijw has joined #openstack-nova | 01:25 | |
| mriedem | melwitt: oh nvm you need to rebase | 01:25 |
| mriedem | to get that liberty-eol fix | 01:25 |
| melwitt | thanks | 01:25 |
| *** mtan_____ has joined #openstack-nova | 01:26 | |
| *** ducttape_ has joined #openstack-nova | 01:27 | |
| *** mtanino has quit IRC | 01:27 | |
| openstackgerrit | melanie witt proposed openstack/nova: Add detail to cellsv2-related release notes https://review.openstack.org/410009 | 01:28 |
| *** zhangjl has joined #openstack-nova | 01:28 | |
| *** ducttape_ has quit IRC | 01:28 | |
| *** Kevin_Zheng has joined #openstack-nova | 01:30 | |
| *** kevinz has joined #openstack-nova | 01:31 | |
| *** mtan_____ has quit IRC | 01:31 | |
| *** liusheng has quit IRC | 01:38 | |
| *** liusheng has joined #openstack-nova | 01:39 | |
| openstackgerrit | zhaolihui proposed openstack/nova: Fix keypair quota error https://review.openstack.org/403529 | 01:39 |
| *** yuntongjin has joined #openstack-nova | 01:49 | |
| melwitt | ah, recreating the venv made it fail locally. now I can look at an actual traceback | 01:51 |
| openstackgerrit | STEW TY proposed openstack/nova: Transform instance.resize_confirm notification https://review.openstack.org/390654 | 01:54 |
| melwitt | mriedem: it's weird that the command says it's looking for "liberty-eol-eol" with eol repeated | 01:55 |
| mriedem | hmm....so that must be a bug in the reno change | 01:56 |
| mriedem | it should only be slapping -eol on if it can't find the branch | 01:56 |
| mriedem | in this case, origin/stable/liberty | 01:56 |
| mriedem | dhellmann: ^ | 01:56 |
| melwitt | yeah but it's slapping it on liberty-eol as if it couldn't find liberty-eol | 01:56 |
| mriedem | sounds like a bug | 01:57 |
| melwitt | the tag I mean | 01:57 |
| melwitt | yeah | 01:57 |
| mriedem | twitter bomb doug | 01:57 |
| mriedem | melwitt: you shouldn't have a problem if you just rebase the change in gerrit | 01:57 |
| melwitt | when I run the command locally 'git log liberty-eol' it works but 'git log liberty-eol-eol' obviously doesn't | 01:57 |
| melwitt | I did | 01:57 |
| melwitt | it failed again | 01:57 |
| mriedem | it's failing up there now? | 01:57 |
| mriedem | hmm wtf | 01:57 |
| melwitt | it's tacking -eol to the already fixed branch liberty-eol right? | 01:58 |
| mriedem | s/branch/tag/ | 01:58 |
| mriedem | i'm trying to see if i can recreate locally | 01:58 |
| melwitt | this fixed it locally for me http://paste.openstack.org/show/592409/ | 01:59 |
| mriedem | melwitt: what's weird is this is fine https://review.openstack.org/#/c/411005/ | 01:59 |
| melwitt | hmm | 01:59 |
| mriedem | i wonder if i hit a pypi mirror before the reno change was out there? | 02:00 |
| *** raunak has quit IRC | 02:00 | |
| mriedem | fudge | 02:00 |
| mriedem | CalledProcessError: Command '(['git', 'log', '--simplify-by-decoration', '--pretty="%d"', u'liberty-eol-eol'],)' returned non-zero exit status 128 | 02:00 |
| *** masuberu has joined #openstack-nova | 02:00 | |
| mriedem | i hit it locally too | 02:01 |
| mriedem | gdi | 02:01 |
| openstackgerrit | STEW TY proposed openstack/nova: Transform instance.resize_confirm notification https://review.openstack.org/390654 | 02:01 |
| mriedem | aha | 02:01 |
| mriedem | https://review.openstack.org/#/c/410907/ | 02:01 |
| mriedem | merged at 6:35pm | 02:01 |
| mriedem | my change ran the reno job at 6:15pm | 02:01 |
| mriedem | so wasn't using the latest | 02:02 |
| diana_clarke | melwitt, mriedem: perhaps a false goose chase... but I've had trouble with reno notes locally. I've removed the build dir etc but they appear to be cached (or something, new changes not picked up) & I didn't look further. I was lazy & deferred to zuul. | 02:03 |
| melwitt | mriedem: mystery solved | 02:03 |
| mriedem | diana_clarke: i did a tox rebuild | 02:03 |
| mriedem | so that shouldn't be a problem | 02:03 |
| *** masber has quit IRC | 02:03 | |
| *** masber has joined #openstack-nova | 02:04 | |
| mriedem | i think the issue is reno is looking for branch named liberty-eol, not finding it, trying to strip on stable, and then just tacking -eol on the end | 02:04 |
| melwitt | well, it's broken locally right now | 02:04 |
| mriedem | blindling | 02:04 |
| mriedem | *blindly | 02:04 |
| mriedem | https://review.openstack.org/#/c/410839/ | 02:05 |
| mriedem | was the change | 02:05 |
| *** masuberu has quit IRC | 02:05 | |
| *** nicolasbock has quit IRC | 02:05 | |
| melwitt | oh, so it's erroneously not finding the tag? | 02:05 |
| diana_clarke | mriedem: I tried changing text, deleting the build dir, running tox -e releasenotes, and seeing if anything changed. Nada. But perhaps I needed to do more.... I never did look into it more. | 02:05 |
| *** nicolasbock has joined #openstack-nova | 02:06 | |
| melwitt | mriedem: it seems like it just wants the branch name to be "liberty" so it looks for a stable branch first then falls back to -eol. no? | 02:07 |
| melwitt | when I change s/liberty-eol/liberty/ in releasenotes/source/liberty.rst it works | 02:08 |
| mriedem | https://bugs.launchpad.net/reno/+bug/1650089 | 02:08 |
| openstack | Launchpad bug 1650089 in reno "reno doesn't handle branch as an eol tag" [Undecided,New] | 02:08 |
| mriedem | so i think we're just going to have to revert https://review.openstack.org/#/c/410851/ | 02:08 |
| melwitt | okay | 02:08 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Revert "Use liberty-eol tag for liberty release notes" https://review.openstack.org/411028 | 02:10 |
| mriedem | JayF: ^ | 02:10 |
| mriedem | since you might have followed what we did today | 02:10 |
| diana_clarke | mriedem: but is the gate going to be broken again then? Ignore me if you already have a plan... sorry | 02:11 |
| melwitt | the gate's broken right now also | 02:12 |
| diana_clarke | sad pandas | 02:12 |
| mriedem | gate schmate | 02:14 |
| mriedem | how many gd gate bugs can we have in a week? :P | 02:14 |
| mriedem | so i think that revert will fix things | 02:15 |
| mriedem | if so, i'll just fast approve the revert | 02:15 |
| alex_xu | sfinucan: the error message is coming from https://github.com/openstack/nova/blob/master/nova/api/validation/validators.py#L267 | 02:15 |
| mriedem | or we can trick alex_xu into approving it :) | 02:15 |
| melwitt | mriedem: will the releasenotes job run on it so we know it will fix it? | 02:17 |
| melwitt | I could also rebase on top of it to test it | 02:17 |
| melwitt | oh yeah, there it goes | 02:17 |
| * alex_xu is looking the log | 02:18 | |
| melwitt | alex_xu: releasenotes job is busted | 02:18 |
| melwitt | alex_xu: if you wouldn't mind reviewing the revert https://review.openstack.org/#/c/411028/ | 02:19 |
| alex_xu | melwitt: got it, let me check | 02:19 |
| *** browne has quit IRC | 02:19 | |
| *** ijw has quit IRC | 02:19 | |
| mriedem | melwitt: yeah | 02:20 |
| alex_xu | melwitt: mriedem done | 02:21 |
| mriedem | thanks | 02:21 |
| alex_xu | np | 02:21 |
| mriedem | high five for teamwork | 02:21 |
| alex_xu | \o/ | 02:21 |
| melwitt | \o\ | 02:22 |
| *** Sukhdev has quit IRC | 02:22 | |
| melwitt | time to eat some dinner | 02:23 |
| openstackgerrit | Wang Qing wu proposed openstack/nova: Introduce base PowerVM driver https://review.openstack.org/391288 | 02:30 |
| *** sapcc-bot has quit IRC | 02:30 | |
| alex_xu | sfinucan: that message is build from the jsonschema library, probably we can't change it | 02:31 |
| *** ijw has joined #openstack-nova | 02:31 | |
| *** jamielennox is now known as jamielennox|away | 02:36 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs: Deprecate the os-quota-class-sets API (spec) https://review.openstack.org/411035 | 02:40 |
| mriedem | melwitt: Vek: ^ | 02:40 |
| mriedem | dansmith: ^ | 02:40 |
| *** unicell has quit IRC | 02:41 | |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: pass the nodename to public methods https://review.openstack.org/398470 | 02:41 |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: remove fluff from test_resource_tracker https://review.openstack.org/398471 | 02:41 |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: pass nodename to internal methods https://review.openstack.org/398469 | 02:41 |
| openstackgerrit | Jay Pipes proposed openstack/nova: placement: create aggregate map in report client https://review.openstack.org/407309 | 02:41 |
| openstackgerrit | Jay Pipes proposed openstack/nova: placement: correct improper test case inheritance https://review.openstack.org/406363 | 02:41 |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: explicitly pass compute node to _update() https://review.openstack.org/398472 | 02:41 |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: use a single ResourceTracker object instance https://review.openstack.org/398473 | 02:41 |
| *** jamielennox|away is now known as jamielennox | 02:51 | |
| *** dave-mccowan has joined #openstack-nova | 02:53 | |
| *** tyrola has quit IRC | 02:54 | |
| *** tyrola has joined #openstack-nova | 02:55 | |
| *** tuanluong has joined #openstack-nova | 02:59 | |
| *** raunak has joined #openstack-nova | 03:03 | |
| *** harlowja has quit IRC | 03:03 | |
| *** nherciu_ has quit IRC | 03:03 | |
| *** nherciu has joined #openstack-nova | 03:04 | |
| *** wlhc has joined #openstack-nova | 03:05 | |
| *** bkopilov has quit IRC | 03:07 | |
| *** browne has joined #openstack-nova | 03:09 | |
| *** kuzko has quit IRC | 03:10 | |
| *** browne has quit IRC | 03:11 | |
| *** asettle has joined #openstack-nova | 03:13 | |
| *** zhangjl has left #openstack-nova | 03:13 | |
| *** asettle has quit IRC | 03:17 | |
| *** kuzko has joined #openstack-nova | 03:18 | |
| *** Zer0Byte__ has quit IRC | 03:19 | |
| *** ducttape_ has joined #openstack-nova | 03:22 | |
| *** hongbin has joined #openstack-nova | 03:22 | |
| *** dave-mccowan has quit IRC | 03:34 | |
| *** r-daneel has quit IRC | 03:38 | |
| *** yuntongjin has quit IRC | 03:39 | |
| *** thorst_ has joined #openstack-nova | 03:43 | |
| alaski | j/quit | 03:44 |
| *** ducttape_ has quit IRC | 03:45 | |
| *** ducttape_ has joined #openstack-nova | 03:47 | |
| *** markvoelker has quit IRC | 03:49 | |
| *** ducttape_ has quit IRC | 03:50 | |
| *** raunak has quit IRC | 03:50 | |
| *** ducttape_ has joined #openstack-nova | 03:50 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/411069 | 03:52 |
| *** raunak has joined #openstack-nova | 03:52 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient: Updated from global requirements https://review.openstack.org/411083 | 03:55 |
| *** psachin has joined #openstack-nova | 03:56 | |
| *** mdnadeem has joined #openstack-nova | 04:00 | |
| *** hfu has joined #openstack-nova | 04:02 | |
| *** esberglu has joined #openstack-nova | 04:05 | |
| *** links has joined #openstack-nova | 04:06 | |
| *** dimtruck is now known as zz_dimtruck | 04:06 | |
| *** esberglu has quit IRC | 04:07 | |
| *** esberglu has joined #openstack-nova | 04:07 | |
| *** esberglu has quit IRC | 04:12 | |
| *** dikonoor has joined #openstack-nova | 04:13 | |
| *** nicolasbock has quit IRC | 04:17 | |
| *** raunak has quit IRC | 04:18 | |
| *** praneshp has joined #openstack-nova | 04:20 | |
| *** wlhc has quit IRC | 04:24 | |
| *** wlhc has joined #openstack-nova | 04:24 | |
| *** bkopilov has joined #openstack-nova | 04:25 | |
| *** Sukhdev has joined #openstack-nova | 04:26 | |
| *** thorst_ has quit IRC | 04:31 | |
| *** thorst_ has joined #openstack-nova | 04:32 | |
| *** yingjun has quit IRC | 04:36 | |
| openstackgerrit | melanie witt proposed openstack/nova: Add detail to cellsv2-related release notes https://review.openstack.org/410009 | 04:40 |
| *** thorst_ has quit IRC | 04:40 | |
| *** sreeram_v has joined #openstack-nova | 04:41 | |
| *** sreeram_v has joined #openstack-nova | 04:41 | |
| *** pbandark has joined #openstack-nova | 04:42 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/411069 | 04:43 |
| *** ratailor has joined #openstack-nova | 04:44 | |
| *** zhangyujun has quit IRC | 04:47 | |
| *** raunak has joined #openstack-nova | 04:49 | |
| *** markvoelker has joined #openstack-nova | 04:51 | |
| *** ijw has quit IRC | 04:51 | |
| *** markvoelker has quit IRC | 04:55 | |
| *** yuntongjin has joined #openstack-nova | 04:56 | |
| *** tojuvone has joined #openstack-nova | 04:56 | |
| *** unicell has joined #openstack-nova | 05:01 | |
| *** raunak has quit IRC | 05:04 | |
| *** unicell has quit IRC | 05:05 | |
| *** unicell1 has joined #openstack-nova | 05:05 | |
| *** raunak has joined #openstack-nova | 05:07 | |
| *** hongbin has quit IRC | 05:10 | |
| *** thorst_ has joined #openstack-nova | 05:10 | |
| *** hfu has quit IRC | 05:14 | |
| *** zhangyujun has joined #openstack-nova | 05:16 | |
| *** Dinesh_B has joined #openstack-nova | 05:17 | |
| *** thorst_ has quit IRC | 05:18 | |
| *** raunak has quit IRC | 05:18 | |
| *** Dinesh_B has quit IRC | 05:20 | |
| *** raunak has joined #openstack-nova | 05:22 | |
| *** bks has joined #openstack-nova | 05:25 | |
| *** noama has quit IRC | 05:28 | |
| *** noama has joined #openstack-nova | 05:28 | |
| *** yingjun has joined #openstack-nova | 05:36 | |
| *** praneshp has quit IRC | 05:37 | |
| *** thingee has quit IRC | 05:38 | |
| *** ijw_ has joined #openstack-nova | 05:39 | |
| *** dhellmann has quit IRC | 05:39 | |
| *** Sukhdev has quit IRC | 05:39 | |
| *** dhellmann has joined #openstack-nova | 05:39 | |
| *** thingee has joined #openstack-nova | 05:40 | |
| *** ijw_ has quit IRC | 05:44 | |
| openstackgerrit | Huan Xie proposed openstack/nova: XenAPI Use os-xenapi lib for nova https://review.openstack.org/406059 | 05:44 |
| *** moshele has joined #openstack-nova | 05:45 | |
| *** moshele has quit IRC | 05:48 | |
| *** Jeffrey4l has joined #openstack-nova | 05:50 | |
| openstackgerrit | bailin.zhang proposed openstack/nova: Fix the file permissions of test_compute_mgr.py https://review.openstack.org/401109 | 05:52 |
| *** praneshp has joined #openstack-nova | 05:52 | |
| *** slaweq_ has joined #openstack-nova | 05:52 | |
| *** fragatina has quit IRC | 05:55 | |
| *** Swami__ has quit IRC | 06:00 | |
| *** ijw has joined #openstack-nova | 06:01 | |
| *** thorst_ has joined #openstack-nova | 06:06 | |
| *** trananhkma has joined #openstack-nova | 06:06 | |
| *** ijw has quit IRC | 06:06 | |
| *** claudiub has quit IRC | 06:06 | |
| *** praneshp has quit IRC | 06:12 | |
| *** thorst_ has quit IRC | 06:15 | |
| *** jaosorior has joined #openstack-nova | 06:16 | |
| *** unicell1 has quit IRC | 06:18 | |
| *** zul has quit IRC | 06:18 | |
| *** unicell has joined #openstack-nova | 06:21 | |
| *** zul has joined #openstack-nova | 06:22 | |
| *** unicell has quit IRC | 06:23 | |
| *** unicell has joined #openstack-nova | 06:23 | |
| *** lpetrut has joined #openstack-nova | 06:29 | |
| *** sridharg has joined #openstack-nova | 06:34 | |
| *** paw has joined #openstack-nova | 06:35 | |
| *** yuntongjin has quit IRC | 06:38 | |
| *** namnh has joined #openstack-nova | 06:43 | |
| *** nandal has joined #openstack-nova | 06:50 | |
| *** markvoelker has joined #openstack-nova | 06:51 | |
| *** preethipy has joined #openstack-nova | 06:53 | |
| preethipy | I have created a new review https://review.openstack.org/#/c/410713/ introducing PRSM to HVType which is needed for supporting nova-dpm out-of-tree driver https://github.com/openstack/nova-dpm (was discussed in the unconference session of the Ocata summit in Barcelona) | 06:55 |
| *** markvoelker has quit IRC | 06:56 | |
| *** thorst_ has joined #openstack-nova | 07:01 | |
| *** raunak has quit IRC | 07:02 | |
| *** yuntongjin has joined #openstack-nova | 07:02 | |
| *** ihrachys has joined #openstack-nova | 07:03 | |
| *** ihrachys has quit IRC | 07:06 | |
| *** mjura has joined #openstack-nova | 07:08 | |
| *** thorst_ has quit IRC | 07:09 | |
| *** Oku_OS-away is now known as Oku_OS | 07:09 | |
| *** rcernin has joined #openstack-nova | 07:13 | |
| *** markus_z has joined #openstack-nova | 07:14 | |
| *** mjura has quit IRC | 07:14 | |
| *** mjura has joined #openstack-nova | 07:15 | |
| *** yamahata_ has quit IRC | 07:19 | |
| openstackgerrit | Huan Xie proposed openstack/nova: XenAPI Use os-xenapi lib for nova https://review.openstack.org/406059 | 07:19 |
| *** lpetrut has quit IRC | 07:24 | |
| *** ekuris has joined #openstack-nova | 07:28 | |
| *** dinobot_ has joined #openstack-nova | 07:29 | |
| *** jamespage has quit IRC | 07:32 | |
| *** jamespag` has joined #openstack-nova | 07:32 | |
| *** ihrachys has joined #openstack-nova | 07:34 | |
| *** jaosorior has quit IRC | 07:37 | |
| *** jaosorior has joined #openstack-nova | 07:37 | |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: live-migration test hook for serial console https://review.openstack.org/347471 | 07:38 |
| *** claudiub has joined #openstack-nova | 07:39 | |
| *** lpetrut has joined #openstack-nova | 07:40 | |
| *** elynn has joined #openstack-nova | 07:40 | |
| *** thorst_ has joined #openstack-nova | 07:41 | |
| elynn | Hi, I have a question about anti-affinity policy. | 07:41 |
| elynn | If I use a anti-affinity group, is there any way to create more than one vm on the same hypervisor? | 07:42 |
| elynn | I have 4 nova-compute nodes, and when I create the 5th vm, I got 'No valid hosts' error. | 07:42 |
| *** esberglu has joined #openstack-nova | 07:43 | |
| *** esberglu has quit IRC | 07:48 | |
| *** thorst_ has quit IRC | 07:49 | |
| *** moshele has joined #openstack-nova | 07:51 | |
| *** ihrachys has quit IRC | 07:52 | |
| *** jamespag` is now known as jamespage | 07:53 | |
| *** avolkov has joined #openstack-nova | 07:54 | |
| *** jaosorior has quit IRC | 07:55 | |
| *** andreas_s has joined #openstack-nova | 07:55 | |
| tdurakov | johnthetubaguy: hi, are you around? | 07:56 |
| *** haypo has joined #openstack-nova | 07:58 | |
| *** haypo has joined #openstack-nova | 07:58 | |
| *** markus_z has quit IRC | 08:08 | |
| *** lpetrut has quit IRC | 08:09 | |
| *** matrohon has joined #openstack-nova | 08:12 | |
| alex_xu | johnthetubaguy: Kevin_Zheng, probably we can start from this etherpad https://etherpad.openstack.org/p/servers_filters, but let me know if there is better way. | 08:16 |
| *** ayogi has joined #openstack-nova | 08:21 | |
| *** oomichi has quit IRC | 08:23 | |
| *** oomichi has joined #openstack-nova | 08:23 | |
| *** mbirru has quit IRC | 08:24 | |
| *** aloga has quit IRC | 08:25 | |
| *** aloga has joined #openstack-nova | 08:25 | |
| *** mbirru has joined #openstack-nova | 08:26 | |
| openstackgerrit | Huan Xie proposed openstack/nova: XenAPI Use os-xenapi lib for nova https://review.openstack.org/406059 | 08:28 |
| *** jaosorior has joined #openstack-nova | 08:30 | |
| *** rmart04 has joined #openstack-nova | 08:32 | |
| *** fragatina has joined #openstack-nova | 08:33 | |
| *** thorst_ has joined #openstack-nova | 08:35 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Check destination_type when booting with bdm provided https://review.openstack.org/402372 | 08:37 |
| *** pcaruana has joined #openstack-nova | 08:37 | |
| *** fragatina has quit IRC | 08:37 | |
| *** ociuhandu has joined #openstack-nova | 08:40 | |
| *** ihrachys has joined #openstack-nova | 08:41 | |
| *** GB21 has joined #openstack-nova | 08:42 | |
| *** mbirru has quit IRC | 08:42 | |
| *** thorst_ has quit IRC | 08:43 | |
| *** markus_z has joined #openstack-nova | 08:44 | |
| *** mbirru has joined #openstack-nova | 08:46 | |
| *** ralonsoh has joined #openstack-nova | 08:48 | |
| *** ralonsoh has quit IRC | 08:50 | |
| *** amoralej|off is now known as amoralej | 08:51 | |
| gibi | jaypipes: I left a comment in https://review.openstack.org/#/c/367557/34/nova/conductor/manager.py you pinged me about. I dont see serious problems there regarding notifications | 08:51 |
| *** ralonsoh has joined #openstack-nova | 08:51 | |
| *** markvoelker has joined #openstack-nova | 08:52 | |
| *** ducttape_ has quit IRC | 08:53 | |
| *** markvoelker has quit IRC | 08:58 | |
| *** zzzeek has quit IRC | 09:00 | |
| *** ociuhandu has quit IRC | 09:00 | |
| *** zzzeek has joined #openstack-nova | 09:00 | |
| *** ociuhandu has joined #openstack-nova | 09:01 | |
| *** wlhc has quit IRC | 09:01 | |
| *** moshele has quit IRC | 09:03 | |
| *** markus_z has quit IRC | 09:03 | |
| *** dinobot_ has quit IRC | 09:07 | |
| *** masber has quit IRC | 09:07 | |
| *** yuntongjin has quit IRC | 09:08 | |
| *** masber has joined #openstack-nova | 09:08 | |
| *** ihrachys has quit IRC | 09:08 | |
| *** asettle has joined #openstack-nova | 09:14 | |
| *** roeyc has joined #openstack-nova | 09:15 | |
| *** yufei has joined #openstack-nova | 09:18 | |
| *** ducnc has quit IRC | 09:18 | |
| *** mbirru has quit IRC | 09:19 | |
| *** asettle has quit IRC | 09:19 | |
| *** mbirru has joined #openstack-nova | 09:20 | |
| yingjun | ping gibi | 09:22 |
| *** ociuhandu has quit IRC | 09:22 | |
| *** markus_z has joined #openstack-nova | 09:23 | |
| *** mbirru has quit IRC | 09:23 | |
| *** masuberu has joined #openstack-nova | 09:23 | |
| *** moshele has joined #openstack-nova | 09:24 | |
| *** mbirru has joined #openstack-nova | 09:24 | |
| *** nandal has quit IRC | 09:26 | |
| *** masber has quit IRC | 09:27 | |
| *** Guest89456 has joined #openstack-nova | 09:27 | |
| *** Guest89456 has quit IRC | 09:28 | |
| *** yassine has joined #openstack-nova | 09:28 | |
| *** yassine is now known as Guest50902 | 09:28 | |
| *** zenoway has joined #openstack-nova | 09:29 | |
| *** thorst_ has joined #openstack-nova | 09:30 | |
| *** masber has joined #openstack-nova | 09:33 | |
| *** elynn has quit IRC | 09:34 | |
| *** moshele has quit IRC | 09:35 | |
| gibi | yingjun: hi | 09:35 |
| *** moshele has joined #openstack-nova | 09:36 | |
| *** masuberu has quit IRC | 09:36 | |
| yingjun | gibi, i commented in https://review.openstack.org/#/c/398171/, could you check that if it's right? | 09:36 |
| yingjun | if you have time:) | 09:36 |
| yingjun | thanks | 09:36 |
| openstackgerrit | Li Yingjun proposed openstack/nova: libvirt: Enable custom video vgamem setting https://review.openstack.org/411191 | 09:37 |
| gibi | yingjun: will check it | 09:37 |
| *** thorst_ has quit IRC | 09:38 | |
| *** masuberu has joined #openstack-nova | 09:43 | |
| *** masber has quit IRC | 09:43 | |
| *** lpetrut has joined #openstack-nova | 09:45 | |
| *** yingjun has quit IRC | 09:46 | |
| *** masber has joined #openstack-nova | 09:46 | |
| *** lpetrut1 has joined #openstack-nova | 09:47 | |
| mdbooth | sfinucan: I was leaving just as you were posting the rados thing last night | 09:48 |
| mdbooth | Looks like the conversions prior to passing strings to the library are no longer required | 09:48 |
| *** masuberu has quit IRC | 09:49 | |
| *** lucas-afk is now known as lucasagomes | 09:49 | |
| *** lpetrut has quit IRC | 09:49 | |
| *** lpetrut1 is now known as lpetrut | 09:49 | |
| mdbooth | sfinucan: Given that there was no bug associated with this originally and it doesn't look like a special snowflake, I'd be inclined to remove it entirely. | 09:49 |
| mdbooth | We can address it if there ever is a bug associated with it, which seems unlikely. | 09:50 |
| *** nandal has joined #openstack-nova | 09:53 | |
| mdbooth | sfinucan: Ah, you already said that in the review :) | 09:54 |
| * mdbooth is going to update the change | 09:54 | |
| johnthetubaguy | tdurakov: sorry, distracted, but around, whats up? | 10:02 |
| *** kevinz has quit IRC | 10:03 | |
| openstackgerrit | Matthew Booth proposed openstack/nova: Port libvirt.storage.test_rbd to Python 3 https://review.openstack.org/403425 | 10:05 |
| openstackgerrit | Matthew Booth proposed openstack/nova: Port libvirt.test_firewall to Python 3 https://review.openstack.org/403423 | 10:05 |
| *** ralonsoh_ has joined #openstack-nova | 10:05 | |
| *** preethipy has quit IRC | 10:06 | |
| *** preethipy has joined #openstack-nova | 10:06 | |
| tdurakov | johnthetubaguy: got question on this one: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5742-L5745 | 10:07 |
| *** ralonsoh has quit IRC | 10:08 | |
| tdurakov | johnthetubaguy: what is the reason we do not send all bdms that are needed to be handled in a single rpc request? is it about timeouts? | 10:09 |
| johnthetubaguy | tdurakov: hmm, thats a funky way to do that, but it should be cleaning up the volume connections on the destination host that was added in pre-live-migrate I assume | 10:09 |
| johnthetubaguy | tdurakov: I don't know why its not just part of rollback_live_migration_at_destination, but timeouts could well be an issue | 10:09 |
| tdurakov | johnthetubaguy: right, but why is it done one in a time? the only reason i could see is a possibility of timeouts | 10:09 |
| tdurakov | ok | 10:10 |
| tdurakov | johnthetubaguy: going to refactor that right now, will add you to review | 10:10 |
| *** asettle has joined #openstack-nova | 10:10 | |
| *** asettle has quit IRC | 10:10 | |
| *** asettle has joined #openstack-nova | 10:11 | |
| johnthetubaguy | tdurakov: you might actually want to look at recording the BDMs in the migrate data, so its not out of sync, I remember some discussions relating to that already... at some point | 10:11 |
| tdurakov | johnthetubaguy: will check that too | 10:12 |
| johnthetubaguy | tdurakov: you are right to worry about timeouts though, I think the rollback probably just moved to a call, I don't 100% remember now | 10:12 |
| tdurakov | rollback is a call right now, yes | 10:13 |
| tdurakov | or not) | 10:14 |
| tdurakov | well, it's still cast:) | 10:14 |
| *** ihrachys has joined #openstack-nova | 10:15 | |
| johnthetubaguy | oh, cast, thats OK then | 10:15 |
| *** bks has quit IRC | 10:16 | |
| *** bks has joined #openstack-nova | 10:16 | |
| *** GB21 has quit IRC | 10:17 | |
| *** openstackgerrit has quit IRC | 10:18 | |
| *** asettle__ has joined #openstack-nova | 10:22 | |
| tdurakov | johnthetubaguy: fyi we changed rpc cast to call not for rollbacks, but for the successful post-live-migration step | 10:24 |
| johnthetubaguy | tdurakov: yeah, that sounds right, the rollback needs less monitoring | 10:24 |
| * tdurakov going for a lunch | 10:24 | |
| *** thorst_ has joined #openstack-nova | 10:25 | |
| *** asettle has quit IRC | 10:25 | |
| *** ftersin_ has joined #openstack-nova | 10:25 | |
| *** mnestratov has joined #openstack-nova | 10:26 | |
| *** ralonsoh__ has joined #openstack-nova | 10:27 | |
| *** ftersin has quit IRC | 10:27 | |
| *** ftersin_ is now known as ftersin | 10:27 | |
| *** mbirru has quit IRC | 10:28 | |
| *** ralonsoh__ is now known as ralonsoh | 10:28 | |
| *** ralonsoh_ has quit IRC | 10:30 | |
| *** openstackgerrit has joined #openstack-nova | 10:30 | |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.volume_attach notification https://review.openstack.org/401992 | 10:30 |
| *** lpetrut has quit IRC | 10:31 | |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.volume_detach notification https://review.openstack.org/408676 | 10:31 |
| *** lpetrut has joined #openstack-nova | 10:31 | |
| *** thorst_ has quit IRC | 10:32 | |
| *** sreeram_v has quit IRC | 10:33 | |
| *** sreeram_v has joined #openstack-nova | 10:33 | |
| *** mbirru has joined #openstack-nova | 10:35 | |
| *** derekh has joined #openstack-nova | 10:36 | |
| *** timello has quit IRC | 10:37 | |
| *** sreeram_v has quit IRC | 10:38 | |
| *** ociuhandu has joined #openstack-nova | 10:38 | |
| lyarwood | Odd, https://review.openstack.org/#/c/403256/ appears to be stuck with 2 x +2 and +W , should I just rebase or recheck it to get it moving again? | 10:42 |
| johnthetubaguy | lyarwood: its the change it depends on that still needs to be approved | 10:43 |
| johnthetubaguy | looks like mriedem was waiting for some test success, which has now happened | 10:44 |
| lyarwood | ah | 10:44 |
| *** timello has joined #openstack-nova | 10:45 | |
| lyarwood | johnthetubaguy: apologies, I didn't even think to check if it had a dep, would you mind acking the other change if it looks good to you? | 10:46 |
| johnthetubaguy | lyarwood: no worries, I am just taking a peak at it now | 10:47 |
| lyarwood | thanks | 10:47 |
| * lyarwood cleans up the rest of the queue | 10:47 | |
| *** rpodolyaka_afk is now known as rpodolyaka | 10:47 | |
| *** GB21 has joined #openstack-nova | 10:48 | |
| *** asettle__ is now known as asettle | 10:48 | |
| lyarwood | anyone from intel able to look into the stable/newton intel-nfv-ci failures? | 10:49 |
| lyarwood | http://intel-openstack-ci-logs.ovh/92/387292/2/check/tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial/5ee774c/ for example | 10:49 |
| * lyarwood wonders if that should even be voting | 10:50 | |
| *** armax_ has joined #openstack-nova | 10:54 | |
| *** markvoelker has joined #openstack-nova | 10:54 | |
| lyarwood | sfinucan: you wouldn't happen to know who I could talk to about the above intel-nfv-ci failures on stable/newton would you? | 10:55 |
| *** armax has quit IRC | 10:56 | |
| *** armax_ is now known as armax | 10:56 | |
| *** yufei has quit IRC | 10:56 | |
| *** amotoki has quit IRC | 10:56 | |
| moshele | lyarwood: try wznoinsk | 10:57 |
| lyarwood | moshele: thanks | 10:57 |
| lyarwood | wznoinsk: morning, just trying to get to the bottom of the tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial failures on stable/newton - http://intel-openstack-ci-logs.ovh/92/387292/2/check/tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial/5ee774c/ | 10:58 |
| lyarwood | wznoinsk: should that job even be voting on stable/newton now? iirc it wasn't until very recently. | 10:58 |
| *** markvoelker has quit IRC | 10:59 | |
| *** gszasz has joined #openstack-nova | 11:02 | |
| *** ducttape_ has joined #openstack-nova | 11:02 | |
| *** ociuhandu has quit IRC | 11:03 | |
| openstackgerrit | Gábor Antal proposed openstack/nova: Readibility enhancements in notification_sample_tests/ https://review.openstack.org/385884 | 11:03 |
| *** sdague has joined #openstack-nova | 11:11 | |
| mdbooth | Where's gcb? | 11:12 |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP: remove uses of network in _update_ports_for_instance https://review.openstack.org/405399 | 11:14 |
| *** mdnadeem has quit IRC | 11:15 | |
| openstackgerrit | Huan Xie proposed openstack/nova: XenAPI Remove useless files https://review.openstack.org/411241 | 11:16 |
| *** thorst_ has joined #openstack-nova | 11:19 | |
| openstackgerrit | Matthew Booth proposed openstack/nova: Port libvirt.test_vif to Python 3 https://review.openstack.org/403419 | 11:20 |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP: remove nets param from _update_ports_for_instance https://review.openstack.org/405400 | 11:20 |
| tdurakov | johnthetubaguy: could you also take a look at https://review.openstack.org/#/c/410216/ - what do you think about overall idea, if it ok, I'll add new unit-tests | 11:21 |
| *** mvk has quit IRC | 11:22 | |
| mdbooth | sfinucan: I've made a significant update to this py3 change: https://review.openstack.org/#/c/403419/ | 11:24 |
| * mdbooth hope he hasn't offended the author | 11:24 | |
| jaypipes | gibi: thx! | 11:25 |
| mdbooth | jaypipes: What manner of timezone are you currently in? | 11:25 |
| jaypipes | mdbooth: EST | 11:25 |
| mdbooth | jaypipes: So you're just up super early? | 11:25 |
| jaypipes | mdbooth: way too early :) | 11:25 |
| mdbooth | You were commenting on stuff a couple of hours ago! | 11:25 |
| jaypipes | mdbooth: I play 9 holes of golf on Thursday mornings. tee time is at 6:50am. :) | 11:26 |
| * mdbooth hates both golf and 6:50am | 11:26 | |
| sdague | jaypipes: that sound very florida | 11:26 |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP: remove nets param from _update_ports_for_instance https://review.openstack.org/405400 | 11:26 |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP: create fake ordered_nets for get_instance_nw_info https://review.openstack.org/405452 | 11:26 |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP extract _validate_req_and_create_ports https://review.openstack.org/405401 | 11:26 |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP: make _filter_hypervisor_macs use objects https://review.openstack.org/405451 | 11:26 |
| jaypipes | mdbooth: nah, I got a whole 6 hours of sleep! :) | 11:26 |
| jaypipes | sdague: :) | 11:26 |
| sdague | also, it's still not even light by then here this time of year :) | 11:26 |
| *** mbirru has quit IRC | 11:27 | |
| *** thorst_ has quit IRC | 11:27 | |
| jaypipes | sdague: yeah... the first tee shot is sometimes fun to go find ;) | 11:28 |
| jaypipes | anyway, I'm off... ttyl. | 11:28 |
| mdbooth | Daylight in my home town is currently 8:11am to 3:53pm | 11:28 |
| mdbooth | Yay, winter | 11:28 |
| openstackgerrit | jichenjc proposed openstack/nova: WIP: remove keypair server extension https://review.openstack.org/396611 | 11:29 |
| johnthetubaguy | tdurakov: you can actually check for the min-compute version to decide if you should create the migrate at the top and pass it down, and skip the migration creation further down if you get one passed in | 11:30 |
| johnthetubaguy | tdurakov: unless I am missing something | 11:30 |
| * johnthetubaguy goes to a meeting | 11:30 | |
| sdague | mdbooth: It's about 41.5N here, so we're 7:15 AM / 4:25 PM | 11:30 |
| tdurakov | johnthetubaguy: well, could be, but it couples rpc-api and manager's code | 11:30 |
| johnthetubaguy | tdurakov: it saves taking two releases, its a pattern we have used quite a bit | 11:31 |
| mdbooth | UK is deceptively north. I'm around 52°N. | 11:31 |
| johnthetubaguy | tdurakov: it shouldn't go in RPC API, it should be in the conductor code | 11:31 |
| tdurakov | johnthetubaguy: well, my point was to escape this, but if it suitable, I'd go this way | 11:32 |
| mdbooth | That's across from Halifax, Nova Scotia | 11:32 |
| tdurakov | johnthetubaguy: thanks for feedback, will update patch set then | 11:32 |
| *** ociuhandu has joined #openstack-nova | 11:36 | |
| *** namnh has quit IRC | 11:36 | |
| *** tuanluong has quit IRC | 11:36 | |
| *** juszczus has joined #openstack-nova | 11:45 | |
| *** vi01et_ has joined #openstack-nova | 11:47 | |
| *** ociuhandu has quit IRC | 11:47 | |
| *** bkopilov has quit IRC | 11:50 | |
| *** mvk has joined #openstack-nova | 11:50 | |
| *** kevinz has joined #openstack-nova | 11:51 | |
| *** ociuhandu has joined #openstack-nova | 11:52 | |
| *** pbandark has quit IRC | 11:52 | |
| *** pbandark has joined #openstack-nova | 11:54 | |
| *** tbachman has quit IRC | 11:55 | |
| *** rtheis has joined #openstack-nova | 11:55 | |
| *** psachin has quit IRC | 11:57 | |
| *** cdent has joined #openstack-nova | 11:58 | |
| *** amotoki has joined #openstack-nova | 11:59 | |
| *** phuongnh has quit IRC | 12:01 | |
| johnthetubaguy | mdbooth: yeah, I always get confused when I look at a globe | 12:01 |
| johnthetubaguy | mdbooth: that jet stream better stay where it is | 12:01 |
| *** Drankis has joined #openstack-nova | 12:03 | |
| *** kevinz has quit IRC | 12:04 | |
| alex_xu | sdague: johnthetubaguy we hope have same filters list for admin and non-admin user. Does mean we need to extend this list https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L1110? | 12:04 |
| *** nicolasbock has joined #openstack-nova | 12:04 | |
| alex_xu | that list is about the current filters for non-admin user | 12:04 |
| *** kevinz has joined #openstack-nova | 12:04 | |
| johnthetubaguy | alex_xu: I think so, need to add those project ones in from the admin list | 12:04 |
| *** masuberu has joined #openstack-nova | 12:05 | |
| *** juszczus has quit IRC | 12:05 | |
| *** masber has quit IRC | 12:05 | |
| *** ihrachys has quit IRC | 12:05 | |
| *** david-lyle has quit IRC | 12:05 | |
| *** ihrachys has joined #openstack-nova | 12:05 | |
| *** david-lyle has joined #openstack-nova | 12:05 | |
| alex_xu | johnthetubaguy: the confuse problem is we have some new filters without microversion | 12:05 |
| alex_xu | for non-admin user | 12:05 |
| alex_xu | so user have no way to discover those filters | 12:06 |
| Drankis | Hello all, I want to disable shelve action, in nova-api server in policy.json I changed to "compute:shelve": "!", but I am still able to shelve instance. Should I made any more steps to disable shelve? | 12:06 |
| Drankis | Maybe this changes should be done on each compute too? | 12:06 |
| *** dougwig_ has joined #openstack-nova | 12:07 | |
| *** BlackDex has quit IRC | 12:07 | |
| *** juszczus has joined #openstack-nova | 12:08 | |
| alex_xu | Drankis: do you run v2.1 API or legacy v2 API. IF it is v2.1 API, the policy rule is "os_compute_api:os-shelve:shelve" | 12:08 |
| *** aweeks has quit IRC | 12:08 | |
| *** dougwig has quit IRC | 12:08 | |
| *** dougwig_ is now known as dougwig | 12:08 | |
| *** mjura has quit IRC | 12:08 | |
| Drankis | alex_xu, yes, 2.1. Thanks, I will try with your suggestion. | 12:08 |
| alex_xu | Drankis: np | 12:08 |
| *** moshele has quit IRC | 12:08 | |
| *** moshele has joined #openstack-nova | 12:09 | |
| *** BlackDex has joined #openstack-nova | 12:09 | |
| Drankis | alex_xu, it works, thanks a lot! | 12:10 |
| alex_xu | Drankis: np :) | 12:10 |
| *** scottda has quit IRC | 12:11 | |
| alex_xu | johnthetubaguy: sdague, and we hope have a list filters which is mapping to the REST representation. The admin user have a huge list which far more than non-admin user. I list those filters in https://etherpad.openstack.org/p/servers_filters | 12:12 |
| alex_xu | I feel we shouldn't extend the non-admin user filters for now. | 12:13 |
| *** thorst_ has joined #openstack-nova | 12:14 | |
| sdague | alex_xu: ok | 12:14 |
| alex_xu | for the sort, it is pretty clear. due to there is same list for admin and non-admin user. | 12:14 |
| *** yankee has joined #openstack-nova | 12:14 | |
| *** moshele has quit IRC | 12:16 | |
| Kevin_Zheng | +1 on not extend non-admin | 12:17 |
| *** sreeram_v has joined #openstack-nova | 12:20 | |
| *** bvanhav has joined #openstack-nova | 12:21 | |
| *** mjura has joined #openstack-nova | 12:21 | |
| *** thorst_ has quit IRC | 12:21 | |
| *** esberglu has joined #openstack-nova | 12:22 | |
| alex_xu | sdague: you means you are good with not extend, or you are still thinking the problem? | 12:24 |
| *** sreeram_v has quit IRC | 12:25 | |
| *** lucasagomes is now known as lucas-hungry | 12:26 | |
| *** esberglu has quit IRC | 12:26 | |
| *** owalsh is now known as owalsh-afk | 12:28 | |
| *** sreeram_v has joined #openstack-nova | 12:28 | |
| sfinucan | mdbooth: Done. Looks much better now | 12:30 |
| *** yankee has quit IRC | 12:31 | |
| *** amotoki has quit IRC | 12:32 | |
| sdague | alex_xu: if you feel we need to keep the filters smaller for non-admin for discovery reasons, I can accept that | 12:32 |
| sdague | we can increase them later | 12:33 |
| alex_xu | sdague: ok, I prefer to increase them later. otherwise we will have API discovery problem. | 12:34 |
| sdague | alex_xu: yes, that sounds reasonable | 12:34 |
| alex_xu | johnthetubaguy: sdague: another question is the policy of 'os_compute_api:servers:index:get_all_tenants' which is for all_tenant. should we remove them? But due to the rule we should deprecate it first | 12:35 |
| alex_xu | wait, we didn't want to remove it, we just want to ignore the exception raise when policy enforce failed | 12:36 |
| sfinucan | mdbooth: One final cleanup for https://review.openstack.org/#/c/403425 and we're good to go | 12:38 |
| sdague | alex_xu: so... get_all_tenants shouldn't be a policy point, it really should be based on role | 12:38 |
| sdague | it's really odd that it's a policy point, because it's changing the role of a thing outside the role structure | 12:39 |
| *** GB21 has quit IRC | 12:40 | |
| *** GB21 has joined #openstack-nova | 12:41 | |
| alex_xu | sdague: emm...sorry, I'm not quite understand. | 12:41 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Transform missing delete notifications https://review.openstack.org/410297 | 12:43 |
| *** mnasiadka has joined #openstack-nova | 12:43 | |
| *** pradk has joined #openstack-nova | 12:44 | |
| *** bdeschenes has joined #openstack-nova | 12:44 | |
| *** pradk has quit IRC | 12:45 | |
| *** Raildo has joined #openstack-nova | 12:47 | |
| *** Raildo_ has joined #openstack-nova | 12:47 | |
| *** Raildo_ is now known as raildo_ | 12:48 | |
| tdurakov | johnthetubaguy: about checking rpc versions in conductor's manager, how do you propose to check that? by service object's versions? | 12:49 |
| *** juszczus has quit IRC | 12:50 | |
| *** amotoki has joined #openstack-nova | 12:50 | |
| openstackgerrit | garyk proposed openstack/nova: VMware: ensure that provider networks work for type 'portgroup' https://review.openstack.org/358425 | 12:50 |
| *** juszczus has joined #openstack-nova | 12:52 | |
| *** zhs_ has joined #openstack-nova | 12:53 | |
| *** Raildo has quit IRC | 12:53 | |
| openstackgerrit | garyk proposed openstack/nova: VMware: ensure volume is accessible by instance https://review.openstack.org/218639 | 12:54 |
| *** markvoelker has joined #openstack-nova | 12:55 | |
| *** amotoki has quit IRC | 12:55 | |
| *** zhs__ has quit IRC | 12:56 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova: libvirt: Stop misusing NovaException https://review.openstack.org/410288 | 12:57 |
| openstackgerrit | garyk proposed openstack/nova: VMware: retry network lookup if network not ready https://review.openstack.org/391778 | 12:59 |
| *** catintheroof has joined #openstack-nova | 13:00 | |
| *** markvoelker has quit IRC | 13:00 | |
| *** catintheroof has quit IRC | 13:01 | |
| *** catintheroof has joined #openstack-nova | 13:01 | |
| *** pbandark has quit IRC | 13:01 | |
| *** mdnadeem has joined #openstack-nova | 13:04 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Transform missing delete notifications https://review.openstack.org/410297 | 13:06 |
| *** dave-mccowan has joined #openstack-nova | 13:08 | |
| *** pbandark has joined #openstack-nova | 13:08 | |
| *** ociuhandu has quit IRC | 13:09 | |
| *** amoralej is now known as amoralej|lunch | 13:10 | |
| *** GB21 has quit IRC | 13:10 | |
| *** nandal has quit IRC | 13:11 | |
| *** ociuhandu has joined #openstack-nova | 13:11 | |
| *** esberglu has joined #openstack-nova | 13:12 | |
| *** vladikr has joined #openstack-nova | 13:14 | |
| *** esberglu has quit IRC | 13:16 | |
| *** pbandark has quit IRC | 13:17 | |
| *** GB21 has joined #openstack-nova | 13:17 | |
| *** pbandark has joined #openstack-nova | 13:18 | |
| *** thorst_ has joined #openstack-nova | 13:19 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova: WIP encryptors: Deprecate the CryptsetupEncryptor class ahead of removal in Q https://review.openstack.org/411312 | 13:20 |
| *** pbandark has quit IRC | 13:20 | |
| *** esberglu has joined #openstack-nova | 13:21 | |
| *** ratailor has quit IRC | 13:23 | |
| *** GB21 has quit IRC | 13:23 | |
| *** preethipy has quit IRC | 13:24 | |
| *** psachin has joined #openstack-nova | 13:25 | |
| johnthetubaguy | tdurakov: there is infrastructure for that already, fetches the min service version in the system for you | 13:25 |
| tdurakov | johnthetubaguy: could you please point me to? | 13:26 |
| johnthetubaguy | tdurakov: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1682 | 13:26 |
| johnthetubaguy | yeah, was busy looking for a good one | 13:26 |
| tdurakov | thx! | 13:27 |
| johnthetubaguy | np | 13:27 |
| johnthetubaguy | alex_xu: we don't really have a deprecate rule for all that stuff yet | 13:27 |
| johnthetubaguy | alex_xu: I would be tempted to just change the default this cycle, and remove it next cycle | 13:27 |
| johnthetubaguy | alex_xu: actually that policy is really, who can list more than their own token lets them view, so we should probably keep it to do just that | 13:28 |
| *** lucas-hungry is now known as lucasagomes | 13:29 | |
| johnthetubaguy | alex_xu: thats a bit different from what it means today, but it amounts to the same thing | 13:29 |
| sdague | alex_xu: it seems weird to me that we have a policy point of all_tenants, when that should be just a function of roles decided outside of nova | 13:31 |
| *** links has quit IRC | 13:31 | |
| alex_xu | johnthetubaguy: thanks, I just think about change the default | 13:32 |
| *** ayoung_dadmode is now known as ayoung | 13:32 | |
| alex_xu | sdague: thanks, I see now | 13:32 |
| *** jheroux has joined #openstack-nova | 13:32 | |
| alex_xu | johnthetubaguy: sdague so we should change the default to open for anyone, but have check only works for admin, for non-admin just ignore. is it correct for now? | 13:32 |
| sdague | alex_xu: it should be scoped by context, so yeh, role=admin gives you everything | 13:33 |
| sdague | otherwise, not | 13:33 |
| alex_xu | in next release, remove the policy. and in the future we have a function to decided the role | 13:33 |
| johnthetubaguy | so I saw it a bit differently myself, but its basically the same | 13:34 |
| johnthetubaguy | there is policy rule that says we check for role=admin, to allow you to see beyond the regular scope of your token | 13:34 |
| johnthetubaguy | that no longer means it stops seeing all-tenants=True, you see all the tenants you can see, unless you pass the above policy rule that says your token is allowed to see more tenants | 13:35 |
| johnthetubaguy | I know keystone wants to stop us checking for context.is_admin, basically, so keeping the rule makes that easier to do longer term | 13:35 |
| *** takashin has joined #openstack-nova | 13:35 | |
| johnthetubaguy | but it amounts to the same thing, I think | 13:36 |
| pkholkin | mriedem: alex_xu: andreykurilin: hello guys! your review wanted for novaclient 2.39 patch) thanks! https://review.openstack.org/#/c/408166/ | 13:36 |
| alex_xu | johnthetubaguy: is it new policy rule than the current one? | 13:36 |
| johnthetubaguy | I just complex-ified the hell out of that somehow | 13:36 |
| johnthetubaguy | alex_xu: thats a fair point, its probably a new rule | 13:36 |
| *** bkopilov has joined #openstack-nova | 13:36 | |
| johnthetubaguy | it has a different meaning | 13:36 |
| *** sudipto has joined #openstack-nova | 13:37 | |
| *** sudipto_ has joined #openstack-nova | 13:37 | |
| pkholkin | alex_xu: I looked through the code and tried to answer we you saw that strange situation, I think this is not about my patch, this behaviour was in the code before, I'm not an expert why it is so | 13:37 |
| pkholkin | why you saw* | 13:38 |
| *** erlon has joined #openstack-nova | 13:38 | |
| *** GB21 has joined #openstack-nova | 13:38 | |
| alex_xu | johnthetubaguy: sdague basically, I think I can update the spec, and I feel I figure out the plan now :) | 13:40 |
| alex_xu | pkholkin: have test your patch in your local, have you reproduce the same problem? | 13:40 |
| alex_xu | or it is only happened in my local? | 13:41 |
| *** moshele has joined #openstack-nova | 13:41 | |
| pkholkin | alex_xu: I've tested it, what do you think is a problem? | 13:42 |
| sdague | alex_xu: great! let me know once you get the new spec up | 13:43 |
| pkholkin | alex_xu: for 'list' command this decorator makes 2.39 to 2.35 and the command works https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/shell.py#L86 | 13:43 |
| alex_xu | johnthetubaguy: for the hierarchical multi tenancy, it should be a function which talk with keystone to check the token scope as sdague said. so that policy rule will be useless? | 13:43 |
| alex_xu | sdague: yea | 13:44 |
| pkholkin | alex_xu: sorry, for 'image-meta' | 13:44 |
| pkholkin | alex_xu: but for 'list' command we don't have this decorator, only exception inside | 13:44 |
| sdague | alex_xu: I assume that conceptually there will be some way to ask the question about which project_ids the user has access to | 13:44 |
| *** tbachman has joined #openstack-nova | 13:44 | |
| sdague | and we'd use that | 13:44 |
| johnthetubaguy | alex_xu: I still think you need a rule to decide "can this token see outside its scope" | 13:44 |
| johnthetubaguy | but thats a very different question | 13:45 |
| *** gouthamr has joined #openstack-nova | 13:45 | |
| sdague | yeh, lets not worry about that too much at this point | 13:45 |
| sdague | the thing is we won't have to change the way we talk about this parameter later | 13:46 |
| alex_xu | emm...ok, let me think about in background | 13:46 |
| sdague | even if the internals are a little complicated | 13:46 |
| alex_xu | sdague: yea | 13:46 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Added PRSM to HVType class for support PR/SM hypervisor https://review.openstack.org/410713 | 13:47 |
| sdague | yeh, I think the way to consider it is there is "visible scope" of projects for a user, and "default scope" | 13:47 |
| sdague | default scope is the project id of your token | 13:47 |
| sdague | visible scope is as broad as your permissions could be | 13:47 |
| sdague | all_tenants=True changes default scope to visible scope | 13:48 |
| sdague | but visible scope has limits based on role | 13:48 |
| lyarwood | I'm looking for reviews on https://review.openstack.org/#/c/398479/ a trivial libvirt detach volume fix with encrypted volumes if anyone has time. | 13:48 |
| sdague | for regular users visible scope == default scope | 13:48 |
| sdague | for admins it's everything | 13:48 |
| *** swamireddy has quit IRC | 13:48 | |
| sdague | and there might be a role where it's inbetween | 13:48 |
| alex_xu | sdague: ah, I see now | 13:49 |
| *** amotoki has joined #openstack-nova | 13:51 | |
| alex_xu | pkholkin: I didn't see we use 'deprecated_proxy' for image-meta | 13:53 |
| pkholkin | alex_xu: https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/shell.py#L1397 | 13:57 |
| pkholkin | some part of work was done in other patches, that makes some troubles to me | 13:58 |
| alex_xu | pkholkin: ah, i see now, thanks. that is already done by another patches | 13:59 |
| alex_xu | pkholkin: I will check it more | 13:59 |
| pkholkin | alex_xu: yeah, thanks | 13:59 |
| *** scottda has joined #openstack-nova | 13:59 | |
| pkholkin | that's why I needed review) | 13:59 |
| johnthetubaguy | sdague: +1 all you just said there | 13:59 |
| *** bks has quit IRC | 14:01 | |
| raj_singh | mriedem: nova meeting? | 14:02 |
| *** burt has joined #openstack-nova | 14:03 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: Remove check_attach https://review.openstack.org/335358 | 14:03 |
| *** bvanhav has quit IRC | 14:03 | |
| *** aweeks has joined #openstack-nova | 14:04 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: Allow multi-attach in compute api https://review.openstack.org/271047 | 14:05 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: libvirt: Allow multiple volume attachments https://review.openstack.org/267587 | 14:05 |
| *** bvanhav has joined #openstack-nova | 14:05 | |
| *** Cristina__ has joined #openstack-nova | 14:07 | |
| *** amoralej|lunch is now known as amoralej | 14:09 | |
| *** lamt has joined #openstack-nova | 14:10 | |
| *** lpetrut has quit IRC | 14:10 | |
| *** CristinaPauna has quit IRC | 14:10 | |
| *** baoli has joined #openstack-nova | 14:11 | |
| *** baoli has quit IRC | 14:12 | |
| johnthetubaguy | BobBall: did you see the CI issues mriedem just raised in the Nova meeting? | 14:12 |
| *** Cristina__ has quit IRC | 14:12 | |
| *** baoli has joined #openstack-nova | 14:12 | |
| *** mlavalle has joined #openstack-nova | 14:12 | |
| *** derekh is now known as derekh_brb | 14:12 | |
| *** GB21 has quit IRC | 14:14 | |
| *** oanson has quit IRC | 14:15 | |
| mmedvede | thorst_: I've noticed PowerVM CI is reporting under different names depending on failure/success. Can this be changed? I.e. use "IBM PowerVM CI" for both failure and success comments | 14:15 |
| thorst_ | mmedvede: yeah, esberglu is looking into that actually | 14:15 |
| thorst_ | esberglu: any movement on determining why that is happening? Or still investigating? | 14:16 |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif: vif_plug_ovs: Always set MTU when plugging devices https://review.openstack.org/408779 | 14:16 |
| *** tlian has joined #openstack-nova | 14:16 | |
| *** tbachman has quit IRC | 14:20 | |
| *** gouthamr has quit IRC | 14:20 | |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif: vif_plug_ovs: Always set MTU when plugging devices https://review.openstack.org/408779 | 14:21 |
| *** tbachman has joined #openstack-nova | 14:21 | |
| sfinucan | sean-k-mooney: Would you kindly take a gawk at https://review.openstack.org/#/c/408779 :) | 14:21 |
| * sfinucan really wants to play Bioshock again now... | 14:22 | |
| *** jamesdenton has joined #openstack-nova | 14:22 | |
| *** haypo has left #openstack-nova | 14:22 | |
| openstackgerrit | Roman Dobosz proposed openstack/nova: placement: adds REST API for nested providers https://review.openstack.org/384807 | 14:23 |
| openstackgerrit | Roman Dobosz proposed openstack/nova: placement: allow filter providers in tree https://review.openstack.org/377215 | 14:23 |
| openstackgerrit | Roman Dobosz proposed openstack/nova: placement: update client to set parent provider https://review.openstack.org/385693 | 14:23 |
| openstackgerrit | Roman Dobosz proposed openstack/nova: placement: add nested resource providers https://review.openstack.org/377138 | 14:23 |
| esberglu | thorst_: mmedvede: Sorry, stepped away for a second. On my list of things to do today | 14:24 |
| *** swamireddy has joined #openstack-nova | 14:25 | |
| *** lpetrut has joined #openstack-nova | 14:25 | |
| mmedvede | thorst_: esberglu: Your CI name appears to differ because your comment on one case includes "Build succeeded (check pipeline).", and it does not in the other. Ping me if you need help debugging | 14:25 |
| *** cdent has quit IRC | 14:27 | |
| *** gouthamr has joined #openstack-nova | 14:28 | |
| *** annegentle has joined #openstack-nova | 14:28 | |
| *** eharney has joined #openstack-nova | 14:30 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Always set MTU when plugging devices https://review.openstack.org/408781 | 14:30 |
| *** mriedem has quit IRC | 14:30 | |
| *** Jeffrey4l_ has joined #openstack-nova | 14:30 | |
| *** esberglu has quit IRC | 14:31 | |
| *** Jeffrey4l_ has quit IRC | 14:31 | |
| *** Jeffrey4l_ has joined #openstack-nova | 14:34 | |
| *** Jeffrey4l has quit IRC | 14:34 | |
| mdbooth | Can anybody reassure me that the intel nfv ci failure here isn't real: https://review.openstack.org/#/c/403419/ | 14:34 |
| sdague | mdbooth: the first link at least is it dying in devstack setup | 14:36 |
| sdague | I think nfv ci has been kind of hosed for a while | 14:36 |
| mdbooth | sdague: Thanks | 14:36 |
| mdbooth | I thought so, but I'm rarely 100% sure about these things | 14:37 |
| sfinucan | mdbooth: As is the third | 14:37 |
| sfinucan | Nothing there should affect that CI, which runs (a) standard Tempest tests with custom, NFV'y flavors (CPU pinning, NUMA topologies) and (b) custom tempest tests for validating those NFV features themselves | 14:38 |
| sfinucan | wznoinsk: Any chance you could have a look at ^ | 14:38 |
| sfinucan | ? | 14:38 |
| sdague | sfinucan: I don't think they've yet fixed the tempest setup parts of their cic | 14:40 |
| sdague | ci | 14:40 |
| sfinucan | I did some work on the tests themselves last week and figured they'd got it stable again. Oh well :( | 14:41 |
| *** marst has joined #openstack-nova | 14:43 | |
| *** derekh_brb is now known as derekh | 14:44 | |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.reboot notifications https://review.openstack.org/382959 | 14:45 |
| *** markvoelker has joined #openstack-nova | 14:45 | |
| gibi | johnthetubaguy: so I had the same view about the flavor.projects lazyness, but I failed to prove my view with a test | 14:45 |
| *** esberglu has joined #openstack-nova | 14:46 | |
| johnthetubaguy | gibi: hmm, you should see debug logs telling whats going on I guess | 14:46 |
| gibi | johnthetubaguy: but I will set up the test again and if I still fail to see the lazy load there then I will show it to you | 14:46 |
| *** esberglu has quit IRC | 14:46 | |
| johnthetubaguy | cool, functional db test seems like the right approach to prove things either way | 14:46 |
| *** esberglu has joined #openstack-nova | 14:46 | |
| johnthetubaguy | gibi: there is also the whole set context to None trick to make lazy loads fail | 14:47 |
| gibi | johnthetubaguy: do you have an example about that trick? | 14:47 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: tests: Validate huge pages https://review.openstack.org/399653 | 14:48 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: tests: Combine multiple NUMA-generation functions https://review.openstack.org/402561 | 14:48 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: tests: Don't reinvent __init__ https://review.openstack.org/402560 | 14:48 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: libvirt: create functional test base class https://review.openstack.org/407055 | 14:48 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: tests: Remove duplicate NumaHostInfo https://review.openstack.org/402562 | 14:48 |
| johnthetubaguy | gibi: https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L886 | 14:48 |
| gibi | johnthetubaguy: thanks | 14:48 |
| *** tblakes has joined #openstack-nova | 14:49 | |
| *** kevinz has quit IRC | 14:51 | |
| *** sreeram_v has quit IRC | 14:52 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova: hardware: Rework '_get_cpu_topology_constraints' https://review.openstack.org/407173 | 14:52 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: hardware: Rework get_number_of_serial_ports https://review.openstack.org/407174 | 14:52 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Log when conflicting image/flavor metadata found https://review.openstack.org/407175 | 14:52 |
| esberglu | mmedvede: thorst_: Our CI is now showing up as IBM PowerVM CI for both failures and successes | 14:52 |
| mmedvede | esberglu: thanks for fixing it | 14:55 |
| openstackgerrit | Pavel Kholkin proposed openstack/python-novaclient: [proxy-api] microversion 2.39 deprecates image-metadata proxy API https://review.openstack.org/408166 | 14:55 |
| esberglu | np | 14:55 |
| *** zz_dimtruck is now known as dimtruck | 14:58 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Forcing a configdrive in cfg should populate DB https://review.openstack.org/364814 | 14:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: tests: Validate huge pages https://review.openstack.org/399653 | 14:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: tests: Combine multiple NUMA-generation functions https://review.openstack.org/402561 | 14:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: libvirt: create functional test base class https://review.openstack.org/407055 | 14:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: tests: Remove duplicate NumaHostInfo https://review.openstack.org/402562 | 14:59 |
| *** takashin has left #openstack-nova | 15:00 | |
| *** links has joined #openstack-nova | 15:01 | |
| *** mriedem has joined #openstack-nova | 15:02 | |
| sean-k-mooney | sfinucan: just running to a meeting but ill review it when i get back :) | 15:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Extend nfv feature matrix with pinning/NUMA https://review.openstack.org/327126 | 15:03 |
| *** mriedem1 has joined #openstack-nova | 15:05 | |
| openstackgerrit | Julian proposed openstack/nova: Transform instance.add_fixed_ip notification https://review.openstack.org/332876 | 15:05 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Cleanup Newton Release Notes https://review.openstack.org/384341 | 15:05 |
| mriedem1 | can another core hit this https://review.openstack.org/#/c/410009/ so i can tag o-2? | 15:06 |
| *** pradk has joined #openstack-nova | 15:06 | |
| *** mriedem has quit IRC | 15:06 | |
| mriedem1 | johnthetubaguy: btw, the xenserver code has the neutron vif plugging callback code | 15:07 |
| mriedem1 | it's just that there are perf issues with the rootwrap daemon for the xen agent on the neutron side i guess, | 15:07 |
| johnthetubaguy | ah, we did get that in | 15:07 |
| johnthetubaguy | ah | 15:07 |
| mriedem1 | so the xenserver job hits the timeout | 15:07 |
| mriedem1 | there is a related patch up in neutron | 15:07 |
| *** mriedem1 is now known as mriedem | 15:07 | |
| *** CristinaPauna has joined #openstack-nova | 15:09 | |
| *** mnasiadka has quit IRC | 15:10 | |
| *** ayogi has quit IRC | 15:11 | |
| *** coreycb has quit IRC | 15:13 | |
| *** zenoway has quit IRC | 15:15 | |
| *** yingjun has joined #openstack-nova | 15:17 | |
| *** ekuris has quit IRC | 15:17 | |
| *** mdavidson has quit IRC | 15:18 | |
| edleafe | alex_xu: still around for a question? | 15:18 |
| *** armax has quit IRC | 15:19 | |
| *** siva_krish has joined #openstack-nova | 15:21 | |
| *** Cristina__ has joined #openstack-nova | 15:22 | |
| *** jaugustine has joined #openstack-nova | 15:24 | |
| *** jaugustine has quit IRC | 15:24 | |
| *** CristinaPauna has quit IRC | 15:25 | |
| openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: Ensure that periodic reclaim cleans DB deleted instances https://review.openstack.org/323250 | 15:26 |
| *** Cristina__ has quit IRC | 15:26 | |
| *** liverpooler has joined #openstack-nova | 15:28 | |
| JayF | mriedem: so the new reno release breaks the workaround fix? /o\ | 15:29 |
| *** ralonsoh has quit IRC | 15:29 | |
| dhellmann | mriedem , JayF: I just saw that comment. I'm looking at another fix. | 15:29 |
| dhellmann | it might be faster to switch back to using origin/stable/liberty instead of liberty-eol in the mean time | 15:30 |
| *** moshele has quit IRC | 15:30 | |
| JayF | dhellmann: is origin/stable/liberty the value I can put in there that, at this point, won't break further? Including in stable branches? | 15:30 |
| dhellmann | yeah, the intent was to support both I just botched the fix | 15:31 |
| *** burgerk has joined #openstack-nova | 15:31 | |
| dhellmann | all of this happened while I was in the middle of a major rewrite to fix an unrelated bug, so I rushed the fix | 15:32 |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP: remove nets param from _update_ports_for_instance https://review.openstack.org/405400 | 15:32 |
| mriedem | dhellmann: that's what we did last night | 15:32 |
| dhellmann | mriedem : ah, ok, and that's working for you now? | 15:32 |
| mriedem | yeah | 15:32 |
| *** markus_z has quit IRC | 15:32 | |
| dhellmann | ok, good | 15:33 |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.reboot notifications https://review.openstack.org/382959 | 15:34 |
| JayF | Apparently folks landed reverts for everything but stable overnight | 15:34 |
| JayF | and that's waiting on u-c | 15:34 |
| *** psachin has quit IRC | 15:34 | |
| JayF | so the royal we of ironic already took care of it | 15:34 |
| *** mdnadeem has quit IRC | 15:34 | |
| sfinucan | mdbooth: Sorry :) https://review.openstack.org/#/c/403425 | 15:35 |
| *** tbachman has quit IRC | 15:37 | |
| *** owalsh-afk is now known as owalsj | 15:38 | |
| *** owalsj is now known as owalsh | 15:38 | |
| *** tbachman has joined #openstack-nova | 15:38 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs: Deprecate the os-quota-class-sets API (spec) https://review.openstack.org/411035 | 15:40 |
| *** liverpooler has quit IRC | 15:41 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Change parent of diagnostics objects to NovaObject class https://review.openstack.org/394480 | 15:41 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Completed implementation of instance diagnostics for Xen https://review.openstack.org/399613 | 15:41 |
| mriedem | aloga: what release are you hitting that reclaim_queued_deletes bug on? | 15:41 |
| *** liverpooler has joined #openstack-nova | 15:41 | |
| mriedem | aloga: and do you have a better stacktrace from the nova-compute logs when that fails? | 15:41 |
| mriedem | i think it's trying to lazy-load a field and blowing up | 15:41 |
| aloga | mriedem: that is the stack trace from the compute node | 15:42 |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP: remove uses of network in _update_ports_for_instance https://review.openstack.org/405399 | 15:42 |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP: remove nets param from _update_ports_for_instance https://review.openstack.org/405400 | 15:42 |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP: create fake ordered_nets for get_instance_nw_info https://review.openstack.org/405452 | 15:42 |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP extract _validate_req_and_create_ports https://review.openstack.org/405401 | 15:42 |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP: make _filter_hypervisor_macs use objects https://review.openstack.org/405451 | 15:42 |
| aloga | mriedem: it happened to us until Liberty (that's the version we're running of Nova) | 15:42 |
| mriedem | there aren't any other traces in the compute logs? it doesn't show the line from which the failure started | 15:43 |
| *** GB21 has joined #openstack-nova | 15:43 | |
| aloga | mriedem: IIRC that was the full trace, but I can get another one quite easily | 15:47 |
| aloga | mriedem: give me a couple of minutes | 15:47 |
| mriedem | i can see that the notification lazy-loads the flavor | 15:47 |
| mriedem | instance.flavor | 15:47 |
| mriedem | so it could be that | 15:47 |
| mriedem | aloga: if you have debug logging on the compute node, you'd also see a message before it fails starting with "Lazy-loading" | 15:48 |
| *** tbachman has quit IRC | 15:51 | |
| *** tbachman has joined #openstack-nova | 15:52 | |
| *** lpetrut has quit IRC | 15:53 | |
| mriedem | aloga: actually it probably fails here https://github.com/openstack/nova/blob/liberty-eol/nova/compute/manager.py#L2393 | 15:54 |
| mriedem | which eventually gets here https://github.com/openstack/nova/blob/liberty-eol/nova/objects/instance.py#L671 | 15:54 |
| sfinucan | sdague: Dumb question, but are all the managers found in nova/network/manager.py part of nova-net? | 15:57 |
| sfinucan | i.e. they'll go away when nova-net goes away | 15:57 |
| openstackgerrit | int32bit proposed openstack/nova: [test]Change fake image info to fit instance xml https://review.openstack.org/399860 | 15:58 |
| *** thorst_ has quit IRC | 15:58 | |
| mriedem | ok, so i don't know why we'd be able to load a SOFT_DELETED instance from the database, but then when we go to save it later and mark it DELETED, it's gone | 15:58 |
| mriedem | you know what's really crazy, is the logic in the API for SOFT_DELETED is based on the CONF.reclaim_instance_interval | 15:59 |
| mriedem | which is a thing set in the compute nodes | 15:59 |
| mriedem | and you might not have it set on all compute nodes, if you screwed up | 15:59 |
| sdague | sfinucan: I think the answer is yes | 15:59 |
| mriedem | the API making decisions based on compute node config seems terrible | 15:59 |
| *** cdent has joined #openstack-nova | 16:00 | |
| *** sridharg has quit IRC | 16:01 | |
| mriedem | and our docs on server delete don't talk about soft deleted at all http://developer.openstack.org/api-ref/compute/?expanded=delete-server-detail#delete-server | 16:01 |
| mriedem | "With correct permissions, you can see the server status as DELETED through API calls." | 16:01 |
| mriedem | well, maybe... | 16:01 |
| mriedem | based on config... | 16:01 |
| aloga | mriedem: the trace in the compute node is as I pasted it, i.e. there is no further trace in the compute node | 16:02 |
| *** thorst_ has joined #openstack-nova | 16:02 | |
| aloga | only the one coming from the conductor | 16:02 |
| sdague | sfinucan: a ton of nova/network/ ends up going away, but I think we'll have to remove in layers, because unwinding things we might find things we assumed were network global constructs outside of backend | 16:02 |
| mriedem | aloga: ok, i guess i can't sort out why it's not deleted when we get the instance list from the db but then it's deleted when we go to update the vm_status in the db | 16:02 |
| aloga | mriedem: 2016-12-15 17:02:24.626 24712 WARNING nova.compute.manager [req-1c77ed26-5128-430f-b0a6-68b9d9f81685 - - - - -] [instance: 132cb021-6c02-4764-a83b-93bf3ce9423a] Periodic reclaim failed to delete instance: Instance 132cb021-6c02-4764-a83b-93bf3ce9423a could not be found. | 16:02 |
| sdague | mriedem: reclaim_instance_interval is just defering the deletes, right? | 16:02 |
| aloga | Traceback (most recent call last): | 16:02 |
| aloga | File "/usr/lib/python2.7/dist-packages/nova/conductor/manager.py", line 447, in _object_dispatch | 16:02 |
| aloga | return getattr(target, method)(*args, **kwargs) | 16:02 |
| sdague | so that people get an "oh crap, undo" window | 16:03 |
| mriedem | sdague: yeah, but you'd better be damn sure to have that configured in the api and all compute nodes the same | 16:03 |
| aloga | mriedem: but when I traced this down, I foudn that it was failing here: | 16:03 |
| *** mjura has quit IRC | 16:03 | |
| sdague | mriedem: yeh | 16:03 |
| mriedem | because we don't call from the api to the compute the instance is running on to figure out that value | 16:03 |
| aloga | 2016-05-30 13:23:03.335 30103 ERROR nova.compute.manager Traceback (most recent call last): | 16:03 |
| aloga | 2016-05-30 13:23:03.335 30103 ERROR nova.compute.manager File "/usr/lib/python2.7/dist-packages/nova/compute/manager.py", line 2358, in _delete_instance | 16:03 |
| aloga | 2016-05-30 13:23:03.335 30103 ERROR nova.compute.manager self._shutdown_instance(context, instance, bdms) | 16:03 |
| aloga | 2016-05-30 13:23:03.335 30103 ERROR nova.compute.manager File "/usr/lib/python2.7/dist-packages/nova/compute/manager.py", line 2278, in _shutdown_instance | 16:03 |
| aloga | 2016-05-30 13:23:03.335 30103 ERROR nova.compute.manager requested_networks) | 16:03 |
| mriedem | aloga: please use a paste bin for stacktraces in irc | 16:03 |
| *** links has quit IRC | 16:04 | |
| sdague | aloga: please use pastebin | 16:04 |
| sfinucan | sdague: Yup, that sounds fair. fwiw, I'm trying to figure out if various networking-related config options are deprecate'able or not | 16:04 |
| mriedem | so, do we see any value in adding an rpc call from api to compute to see if there is a reclaim instance interval set? | 16:04 |
| mriedem | before soft deleting that thing? | 16:04 |
| sfinucan | If only '/nova/network' was only nova-net related stuff... | 16:05 |
| dansmith | mriedem: wat? | 16:05 |
| dansmith | mriedem: api checks that config itself right? | 16:05 |
| mriedem | dansmith: yes, but the logic for that is all based on what's enabled on the compute | 16:05 |
| dansmith | mriedem: meaning if the api and compute don't agree there's a problem? | 16:06 |
| mriedem | i.e. if you have it set on the api node but not the compute, the instance won't get hard deleted, at least until you fix that up | 16:06 |
| aloga | mriedem, sdague: http://paste.openstack.org/show/592513/ | 16:06 |
| sdague | dansmith: yeh, you need to set it everywhere consistently otherwise... sad panda | 16:06 |
| sdague | so, honestly, reclaim on deleted instance doesn't feel like it should be stack trace and error | 16:07 |
| dansmith | sdague: mriedem: sure.. another call to check is not cool, IMHO, but maybe moving the bits the api does out to compute to make api not care what value is set could be a thing? | 16:07 |
| mriedem | aloga: have you sorted out why the instance is not deleted when the periodic task runs, but then it is deleted when that save() call happens to update the state? | 16:07 |
| aloga | mriedem: so, it did not fail here https://github.com/openstack/nova/blob/liberty-eol/nova/compute/manager.py#L2393 , but rather https://github.com/openstack/nova/blob/liberty-eol/nova/compute/manager.py#L2362 | 16:07 |
| aloga | mriedem: the instance is not deleted ever | 16:08 |
| aloga | it remains there for ages | 16:08 |
| aloga | the periodic task is not able to delete it | 16:08 |
| *** dikonoor has quit IRC | 16:08 | |
| mriedem | aloga: but you get an InstanceNotFound right? | 16:08 |
| aloga | mriedem: yes, I got this error | 16:08 |
| mriedem | so....it is deleted | 16:08 |
| aloga | yes, but the compute node still sees it | 16:08 |
| mriedem | this doesn't really make any sense | 16:08 |
| aloga | and tries to reclaim it | 16:08 |
| aloga | failing :-( | 16:09 |
| *** tbachman has quit IRC | 16:09 | |
| mriedem | aloga: if the instance was deleted, it shouldn't come back from this query | 16:09 |
| mriedem | https://github.com/openstack/nova/blob/liberty-eol/nova/compute/manager.py#L6239 | 16:09 |
| mriedem | so it shouldn't be processed | 16:09 |
| mriedem | but it is, and then it's failing on a later update, with InstanceNotFound | 16:09 |
| aloga | mriedem: exactly | 16:10 |
| *** armax has joined #openstack-nova | 16:10 | |
| mriedem | here https://github.com/openstack/nova/blob/liberty-eol/nova/db/sqlalchemy/api.py#L1733 | 16:10 |
| mriedem | but if it's deleted the whole time, then why is https://github.com/openstack/nova/blob/liberty-eol/nova/compute/manager.py#L6239 returning it? | 16:10 |
| aloga | that's why I am updating the context passed to https://github.com/openstack/nova/blob/liberty-eol/nova/compute/manager.py#L6239 so that it gets also the deleted instances | 16:10 |
| mriedem | aloga: but it obviously is already getting the deleted instances | 16:11 |
| mriedem | somehow | 16:11 |
| *** matrohon has quit IRC | 16:11 | |
| mriedem | and when it tries to update it later, it sees, oh crap this is already deleted, and raises InstanceNotFound | 16:11 |
| mriedem | can you get the actual instances record for aceb4514-915e-4687-ac99-20f6b7d5ed6d from the db? | 16:11 |
| *** diogogmt has quit IRC | 16:12 | |
| *** krtaylor has quit IRC | 16:13 | |
| aloga | mriedem: wait a second, I am refreshing my mind | 16:13 |
| *** dave-mccowan has quit IRC | 16:13 | |
| aloga | I did this in May | 16:13 |
| mriedem | aloga: i think this is the problem https://github.com/openstack/nova/blob/liberty-eol/nova/db/sqlalchemy/api.py#L1891 | 16:13 |
| aloga | mriedem: OK, this https://github.com/openstack/nova/blob/liberty-eol/nova/compute/manager.py#L6239 is getting the deleted instances because the filter says so | 16:13 |
| mriedem | instance_get_all_by_filters_sort returns deleted instances by default | 16:14 |
| aloga | (i.e. https://github.com/openstack/nova/blob/liberty-eol/nova/compute/manager.py#L6236 ) | 16:14 |
| *** roeyc has quit IRC | 16:14 | |
| mriedem | aloga: vm_states.SOFT_DELETED != instances.deleted column | 16:14 |
| mriedem | when i say it's deleted, i mean the instances.deleted value is != 0 | 16:14 |
| mriedem | which is what causes the eventual InstanceNotFound | 16:15 |
| *** matrohon has joined #openstack-nova | 16:16 | |
| mriedem | i've always disliked that the instance_get_all_by_filters_sort db api returns deleted instances by default, | 16:17 |
| *** ayoung has quit IRC | 16:17 | |
| mriedem | because the REST API has to account for that with the deleted and changes-since filter | 16:17 |
| mriedem | well, changes-since can return deleted instances | 16:17 |
| mriedem | anyway, i think that's why you're getting those back and then it fails later on the save() call | 16:17 |
| *** jwcroppe has joined #openstack-nova | 16:18 | |
| *** mtanino has joined #openstack-nova | 16:18 | |
| aloga | mriedem: I am a bit lost, to be honest | 16:21 |
| mriedem | aloga: ok, so i guess your fix is probably the best we can do | 16:21 |
| mriedem | :) | 16:21 |
| mriedem | i don't know how your instance(s) got into this state, probably some other bug | 16:21 |
| aloga | mriedem: IIRC when I traced the problem it was caused by instaces that were deleted + soft_deleted | 16:21 |
| mriedem | yes that's correct | 16:21 |
| mriedem | i don't know how that happens, that's the root cause, | 16:22 |
| mriedem | but *shrug* | 16:22 |
| aloga | mriedem: yes, I tried to see *why* this was happening, to no avail | 16:22 |
| mriedem | but using the read_deleted='yes' mutated context in here would eventually change the state and cleanup the resources, so they are no longer in the resource tracker | 16:22 |
| aloga | mriedem: it does not happen to all the instances, obviously, but it happens with a bunch of them | 16:22 |
| aloga | mriedem: yes, indeeed | 16:22 |
| mriedem | and on a 2nd pass the vm_state should be changed from SOFT_DELETED to DELETED and they should be gone from that initial query | 16:23 |
| aloga | on the 2nd pass, things should be consistent | 16:23 |
| *** thorst_ has quit IRC | 16:23 | |
| aloga | so, this is solving the symptom, not the illnes | 16:23 |
| aloga | unfortunately :-( | 16:23 |
| *** CristinaPauna has joined #openstack-nova | 16:23 | |
| gibi | johnthetubaguy: are you still around? | 16:24 |
| johnthetubaguy | gibi: I am | 16:24 |
| gibi | johnthetubaguy: I think I found why the instance action notification tests don't trigger the lazy-load of the project field | 16:25 |
| gibi | johnthetubaguy: https://github.com/openstack/nova/blob/master/nova/notifications/objects/base.py#L97 | 16:25 |
| *** Zer0Byte__ has joined #openstack-nova | 16:25 | |
| gibi | johnthetubaguy: this is the place where we populate the content of the Payload object | 16:25 |
| gibi | johnthetubaguy: from the normal nova ovos | 16:25 |
| gibi | johnthetubaguy: according to the SCHEMA of the Payload class | 16:26 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Deprecate more nova-net options https://review.openstack.org/411401 | 16:26 |
| gibi | johnthetubaguy: the obj_attr_is_set call will be false for a lazy-loaded field that hasn't been loaded yet | 16:26 |
| *** gszasz has quit IRC | 16:26 | |
| *** Zer0Byte__ has quit IRC | 16:26 | |
| *** rmart04 has quit IRC | 16:27 | |
| gibi | johnthetubaguy: so will never try to lazy-load a field during notification sending | 16:27 |
| gibi | johnthetubaguy: if I remove that check then the test on master blows up | 16:28 |
| gibi | johnthetubaguy: as not just the flavor.projects are lazy-loaded but for example the service.availability_zone as well. | 16:28 |
| gibi | johnthetubaguy: and that is already on the master for a long time | 16:28 |
| mriedem | you know what would probably be fun, a failed compute node with SOFT_DELETED instances, and then evacuating them - maybe they don't get evacuated | 16:29 |
| *** dave-mccowan has joined #openstack-nova | 16:29 | |
| gibi | johnthetubaguy: now I have to think that having the obj_attr_is_set check is a good thing or a bad thing | 16:30 |
| *** jaosorior has quit IRC | 16:30 | |
| *** jaosorior has joined #openstack-nova | 16:31 | |
| *** preethipy has joined #openstack-nova | 16:31 | |
| johnthetubaguy | gibi: oh... nasty | 16:33 |
| *** thorst_ has joined #openstack-nova | 16:33 | |
| johnthetubaguy | gibi: I guess we avoid lazy loading anything right now, which is probably the correct call | 16:34 |
| *** rcernin has quit IRC | 16:34 | |
| gibi | johnthetubaguy: from performance point of view I agree that this it the correct code now | 16:34 |
| gibi | johnthetubaguy: in the other hand from notification content point of view this can mean missing data | 16:35 |
| johnthetubaguy | gibi: yeah | 16:35 |
| gibi | johnthetubaguy: for example the flavor has a the projects field populated in the nova db but the notification we send about an instance using that flavor will have an empty projects list | 16:36 |
| *** baoli has quit IRC | 16:36 | |
| gibi | or might have an empty one | 16:37 |
| johnthetubaguy | gibi: unless you add projects into the expected fields thingy in the code where we send those notifications | 16:37 |
| gibi | depending on the instance object passed in to the notification generator calls | 16:37 |
| gibi | johnthetubaguy: exactly | 16:37 |
| johnthetubaguy | while a bit... "tricky" I think thats OK. We need to be very careful to make sure the testing is "real" | 16:38 |
| *** GB21 has quit IRC | 16:38 | |
| gibi | johnthetubaguy: yeah, if our test coverage is good then there is no problem | 16:38 |
| *** jaosorior has quit IRC | 16:39 | |
| *** Oku_OS is now known as Oku_OS-away | 16:39 | |
| gibi | johnthetubaguy: we might be able to create some test fixture that forces the lazy-load during the test execution | 16:39 |
| gibi | johnthetubaguy: and make the test fail | 16:39 |
| johnthetubaguy | gibi: do you see all this in the functional tests? | 16:40 |
| gibi | johnthetubaguy: yes | 16:40 |
| *** jaosorior has joined #openstack-nova | 16:40 | |
| johnthetubaguy | as in the one that generate the samples | 16:40 |
| gibi | johnthetubaguy: the notification sample tests blow up | 16:40 |
| johnthetubaguy | cool | 16:40 |
| gibi | johnthetubaguy: with ObjectActionError: Object action obj_load_attr failed because: attribute availability_zone not lazy-loadable | 16:40 |
| johnthetubaguy | thats what makes me happier, if its caught in those tests | 16:40 |
| johnthetubaguy | as in the missing attribute should get caught as well, I hope | 16:40 |
| gibi | johnthetubaguy: so if I remove the obj_attr_is_set check during the functional test execution then the test catches those code paths that calls the notification generator functions with a not well loaded object | 16:41 |
| *** pcaruana has quit IRC | 16:42 | |
| gibi | johnthetubaguy: this will be an ugly fixture I imagine | 16:43 |
| wznoinsk | sfinucan, mdbooth, hi, re intel nfv ci we believe we were affected by change of requirements - https://review.openstack.org/#/c/408987/ last night (a brand new problem), we will check why we're still affected while upstream not anymore, thanks | 16:45 |
| gibi | johnthetubaguy: but there is one catch. originally obj_attr_is_set check is added to avoid problems when the code tries to copy the content of a nullable, not filled field from and ovo to an Payload object | 16:47 |
| johnthetubaguy | I guess its for when we try to copy something that hasn't been set | 16:47 |
| gibi | johnthetubaguy: exaclty | 16:47 |
| gibi | johnthetubaguy: and that is a valid thing if the field is nullable | 16:48 |
| johnthetubaguy | true | 16:48 |
| gibi | so the code have to distinguish between the two cases | 16:48 |
| openstackgerrit | preethi proposed openstack/nova: Added PRSM to HVType class for support PR/SM hypervisor https://review.openstack.org/410713 | 16:48 |
| gibi | a) not loaded, lazy-loadable field b) nullable, not set field | 16:49 |
| gibi | a) should fail | 16:49 |
| gibi | b) should not fail | 16:49 |
| *** matrohon has quit IRC | 16:49 | |
| *** andreas_s has quit IRC | 16:49 | |
| gibi | I think I have to fill a bug on the notifications due to possible missing fields and then dig into ovo how to detect a) and b) | 16:50 |
| gibi | s/fill/file/ | 16:50 |
| melwitt | dansmith: I was just looking at the remote console stuff and from what I can tell, adding instance uuid to the url wouldn't help because the API takes just the token, not a url https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/console_auth_tokens.py#L42 | 16:51 |
| *** GB21 has joined #openstack-nova | 16:51 | |
| *** bvanhav has quit IRC | 16:52 | |
| *** bvanhav has joined #openstack-nova | 16:52 | |
| *** fragatina has joined #openstack-nova | 16:53 | |
| dansmith | melwitt: because the rpcapi only takes token you mean? | 16:53 |
| melwitt | dansmith: because the rest api only takes a token | 16:53 |
| melwitt | the api gives you the connection info given a token | 16:54 |
| dansmith | melwitt: the rest api is called with the url we return from get_console right? | 16:54 |
| melwitt | dansmith: it doesn't appear so | 16:54 |
| *** rcernin has joined #openstack-nova | 16:54 | |
| melwitt | I've never used it before so I could be not understanding it, but looking at this http://developer.openstack.org/api-ref/compute/?expanded=show-console-connection-information-detail#show-console-connection-information | 16:55 |
| gibi | johnthetubaguy: thanks for the help, I'm leaving now, the bug will have to wait until tomorrow | 16:55 |
| johnthetubaguy | gibi: happy to try and help | 16:55 |
| johnthetubaguy | gibi: hope you have a good evening | 16:55 |
| gibi | johnthetubaguy: same to you | 16:56 |
| dansmith | melwitt: okay I'm talking about what is returned from "show console details" | 16:56 |
| *** fragatina has quit IRC | 16:57 | |
| melwitt | dansmith: yeah, that one has server_id as a request param already | 16:59 |
| dansmith | melwitt: right, but the result of it is what I'm talking about | 17:00 |
| dansmith | melwitt: I guess maybe I don't know how the check-token part fits in | 17:00 |
| melwitt | check_token is a user-facing api that takes a token and consoleauth has to grab the token data out of memcached to get the rest of the info to return to the user | 17:01 |
| dansmith | user-facing.. | 17:02 |
| *** preethipy has quit IRC | 17:02 | |
| dansmith | I assume you mean that things like novnc hit it? | 17:02 |
| melwitt | and it's weird because all this consoleauth service does is wrap calls to memcached so I don't think it matters where we run it, really. like this could all be done through a client | 17:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Added PRSM to HVType class for support PR/SM hypervisor https://review.openstack.org/410713 | 17:02 |
| dansmith | if I do "nova get-vnc-console" on a server, I get back a novnc url, which has ?token=foo | 17:03 |
| melwitt | yeah, I know. I'm saying there appears to be an api where a user can call a rest endpoint with just the token | 17:03 |
| *** diogogmt has joined #openstack-nova | 17:04 | |
| dansmith | so presumably the novnc stuff just passes that token to our console check api to get back the rest of the details | 17:04 |
| dansmith | but I dunno why | 17:04 |
| *** browne has joined #openstack-nova | 17:05 | |
| wznoinsk | sfinucan, mdbooth, mriedem re intel nfv CI all red - it looks like the problem happens on cryptography 1.7 (it's fine on 1.7.1) which is currently capped in upper-constraints, upstream gate doesn't have that issues due to not using the master of requirements repo: http://logs.openstack.org/76/332876/16/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/d056f4e/logs/devstack-gate-setup-workspace-new.txt.gz#_2016-12-15_15_20_15_760 , | 17:05 |
| wznoinsk | currently checking with infra team | 17:05 |
| mriedem | wznoinsk: upstream should be using 1.7 also because of https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L97 | 17:06 |
| *** Swami has joined #openstack-nova | 17:07 | |
| mriedem | wznoinsk: i don't understand, this job passed http://logs.openstack.org/76/332876/16/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/d056f4e/console.html | 17:08 |
| *** jd__ has quit IRC | 17:08 | |
| melwitt | dansmith: did you look at this link? https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/console_auth_tokens.py#L42 | 17:09 |
| *** jd__ has joined #openstack-nova | 17:09 | |
| *** ducttape_ has quit IRC | 17:10 | |
| *** dtp has joined #openstack-nova | 17:10 | |
| mriedem | bombs away https://review.openstack.org/#/c/411421/ | 17:10 |
| *** ducttape_ has joined #openstack-nova | 17:10 | |
| *** raildo_ has quit IRC | 17:11 | |
| dansmith | melwitt: ...yeah | 17:11 |
| bauzas | mriedem: ohai | 17:11 |
| *** raunak has joined #openstack-nova | 17:11 | |
| dansmith | melwitt: that must be called from novnc | 17:11 |
| bauzas | mriedem: FWIW +1d | 17:11 |
| dansmith | melwitt: hangout? | 17:11 |
| melwitt | dansmith: okay | 17:12 |
| bauzas | mriedem: do you understand what alex_xu said https://review.openstack.org/#/c/407630/7/nova/api/openstack/placement/handlers/resource_provider.py@179 ? | 17:12 |
| dansmith | dtp: you want in on this action? | 17:12 |
| dtp | ok | 17:12 |
| bauzas | mriedem: he means that if we add a comma, then it won't work, right ? like you said | 17:12 |
| dansmith | melwitt: dtp https://hangouts.google.com/call/asqf5lydnjee3lrtqtdifshzj4e | 17:12 |
| mriedem | bauzas: filtering on multiple rp names with a comma won't work, correct | 17:12 |
| mriedem | bauzas: i think alex_xu is saying, we could tighten up the rp name schema | 17:13 |
| mriedem | and i'd agree with that | 17:13 |
| mriedem | probably at least the same rules as server display name | 17:13 |
| bauzas | mriedem: yeah that's what I thought | 17:13 |
| bauzas | mriedem: because calling a RP something like 'foo,bar' seems weird to me | 17:13 |
| bauzas | I could modify my change to use brackets or \ for helping calling a RP like 'foo,bar' by saying name=foo\,bar or name=foo%20bar but... | 17:14 |
| bauzas | mriedem: I tend to prefer to not do that and rather modify this https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handlers/resource_provider.py#L31 agreed | 17:15 |
| mriedem | bauzas: at this point i'm not sure how much we need to care | 17:15 |
| mriedem | i think making the name rules more strict would be better | 17:15 |
| bauzas | agreed | 17:15 |
| *** ducttape_ has quit IRC | 17:15 | |
| mriedem | i'm not sure if we want to allow whitespaces either, but i guess that wouldn't hurt | 17:16 |
| *** GB21 has quit IRC | 17:16 | |
| *** mdnadeem has joined #openstack-nova | 17:17 | |
| bauzas | yup | 17:18 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Expose a REST API for a specific list of RPs https://review.openstack.org/392569 | 17:18 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Support multiple uuids and names for RP list https://review.openstack.org/407630 | 17:18 |
| bauzas | in case people want to bite this ^ | 17:18 |
| *** Guest50902 has quit IRC | 17:18 | |
| bauzas | we're now ocata-3-ish, which means one month left for our priorities :) | 17:19 |
| *** portdirect_zzzzz has quit IRC | 17:19 | |
| *** unicell has quit IRC | 17:19 | |
| *** portdirect_zzzzz has joined #openstack-nova | 17:22 | |
| *** Zer0Byte__ has joined #openstack-nova | 17:22 | |
| *** portdirect_zzzzz is now known as portdirect | 17:22 | |
| mriedem | bauzas: ~6 weeks | 17:25 |
| bauzas | dansmith: jaypipes: sdague: FWIW, I'll need to write a devstack change in lib/nova for starting by default the placement-api | 17:25 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Add more detail to help text for reclaim_instance_interval option https://review.openstack.org/411425 | 17:25 |
| mriedem | assuming no one takes any holiday break | 17:25 |
| bauzas | mriedem: yeah, I wasn't clear | 17:26 |
| dansmith | melwitt: dtp: https://github.com/openstack/nova/blob/master/nova/console/api.py#L49 | 17:26 |
| sdague | bauzas: there is a d-g change up as well | 17:26 |
| mriedem | bauzas: https://review.openstack.org/#/c/409871/ | 17:26 |
| sdague | bauzas: if you fix that one unit test - https://review.openstack.org/#/c/409871/ | 17:26 |
| bauzas | sdague: already you mean ? | 17:26 |
| sdague | that is mergable | 17:27 |
| *** asettle has quit IRC | 17:27 | |
| bauzas | sdague: oh perfect | 17:27 |
| bauzas | d-g is fine by me | 17:27 |
| sdague | bauzas: it will be a stackrc change in devstack to make it default there as well | 17:27 |
| sdague | but probably do d-g first | 17:27 |
| bauzas | sdague: do you think we should just enable the placement api in d-g or we should modify devstack as well ? | 17:27 |
| sdague | bauzas: both | 17:27 |
| mriedem | sdague: i'm not sure we're there yet | 17:27 |
| bauzas | sdague: heh, jinxed | 17:27 |
| sdague | mriedem: not there why? | 17:28 |
| mriedem | sdague: http://logs.openstack.org/71/409871/1/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/52ca676/logs/ - the placement service isn't started in that grenade job | 17:28 |
| sdague | mriedem: ah | 17:28 |
| sdague | well, services are overridden in d-g anyway | 17:28 |
| sdague | the point of devstack default is developers will then live in that env | 17:28 |
| bauzas | I need to disappear for the end of the day, but I'll look at that d-g change | 17:28 |
| bauzas | and do the devstack change | 17:28 |
| bauzas | sdague: mriedem: ^ | 17:29 |
| *** tbachman has joined #openstack-nova | 17:29 | |
| mriedem | so see you in a few hours? ok. :) | 17:29 |
| *** raildo_ has joined #openstack-nova | 17:29 | |
| *** jdurgin has quit IRC | 17:29 | |
| mriedem | sdague: you already pointed this out right? http://logs.openstack.org/71/409871/1/check/gate-tempest-dsvm-multinode-full-ubuntu-xenial-nv/ad9a6ed/logs/apache/placement-api.txt.gz?level=TRACE | 17:30 |
| *** rwmjones is now known as rwmjones|hols | 17:30 | |
| sdague | mriedem: yes | 17:31 |
| *** jdurgin has joined #openstack-nova | 17:31 | |
| *** baoli has joined #openstack-nova | 17:31 | |
| *** thorst_ has quit IRC | 17:32 | |
| mriedem | sdague: that also doesn't seem to carry over to the subnode http://logs.openstack.org/71/409871/1/check/gate-tempest-dsvm-multinode-full-ubuntu-xenial-nv/ad9a6ed/logs/subnode-2/screen-n-cpu.txt.gz#_2016-12-12_17_51_12_636 | 17:32 |
| mriedem | in the non-grenade multinode job | 17:32 |
| *** Jeffrey4l_ has quit IRC | 17:33 | |
| *** derekh has quit IRC | 17:33 | |
| *** esberglu has quit IRC | 17:33 | |
| *** Jeffrey4l_ has joined #openstack-nova | 17:33 | |
| dansmith | melwitt: dtp: https://github.com/openstack/nova/blob/master/nova/consoleauth/manager.py#L77 | 17:33 |
| *** burgerk has quit IRC | 17:33 | |
| mriedem | that might actually not be a bad thing, | 17:33 |
| *** armax has quit IRC | 17:33 | |
| mriedem | as it would mean when we have the scheduler stuff in, we'd have one compute using the placement service, and one compute that doesn't, | 17:33 |
| mriedem | and the scheduler has to be able to handle scheduling to both | 17:33 |
| *** ducttape_ has joined #openstack-nova | 17:34 | |
| *** ftersin has quit IRC | 17:34 | |
| mriedem | dansmith: i think i want to hangout with you at some point today to talk about the 'ready-for-upgrade' thing | 17:34 |
| sdague | mriedem: I thought that was the whole point of getting in the parts we did in newton | 17:34 |
| wznoinsk | mriedem, yes it did pass because it doesn't use 'secretstorage' http://logs.openstack.org/76/332876/16/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/d056f4e/logs/pip2-freeze.txt.gz , ours do, I'm checking why is it installed in our setup | 17:35 |
| sdague | because we'd say, you can't do this until all computes are enabled to the placement api | 17:35 |
| sdague | so that we didn't have to do the "some are talking to it some aren't" | 17:35 |
| *** yamahata has joined #openstack-nova | 17:35 | |
| mriedem | honestly i need to look back over notes, | 17:35 |
| mriedem | because i was pretty sure in the scheduler spec for this, jaypipes and i talked about this case, | 17:36 |
| mriedem | and the scheduler gracefully falling back and handling it | 17:36 |
| mriedem | for at least one release | 17:36 |
| *** catinthe_ has joined #openstack-nova | 17:36 | |
| mriedem | sdague: https://specs.openstack.org/openstack/nova-specs/specs/ocata/approved/resource-providers-scheduler-db-filters.html#other-deployer-impact | 17:37 |
| *** yingjun has quit IRC | 17:38 | |
| *** catintheroof has quit IRC | 17:38 | |
| mriedem | this is part of what i wanted to talk to dan about the ready-for-upgrade idea | 17:38 |
| mriedem | i.e. are you running it from control or compute nodes, or both? because today only the computes are talking to the placement service, so we know they are not ready for uprade if we can't talk to the placement service from that compute node. in ocata the scheduler nodes will also need to talk to the placement service, so ready-for-upgrade is valid there too. but if you have api nodes and scheduler nodes separated, or conductor, then you d | 17:40 |
| jaypipes | mriedem: /me reads back... | 17:40 |
| *** mtanino has quit IRC | 17:42 | |
| mriedem | the nova-manage cmd could get the services from the db for CONF.host and if there is no compute or scheduler binary running on that host, it's a no-op for the placement service check.. | 17:43 |
| mriedem | anyway, i'll start an etherpad with some thoughts after i get some food | 17:43 |
| mriedem | https://etherpad.openstack.org/p/nova-ocata-ready-for-upgrade | 17:43 |
| *** jaosorior has quit IRC | 17:44 | |
| *** mdnadeem has quit IRC | 17:45 | |
| *** nic has joined #openstack-nova | 17:45 | |
| *** mvk has quit IRC | 17:45 | |
| *** esberglu has joined #openstack-nova | 17:47 | |
| dansmith | mriedem: okay | 17:48 |
| dansmith | mriedem: I have things to say about your 'i.e.' thing but I will save them for hangout | 17:49 |
| dansmith | mriedem: I'm free starting in 30 seconds post-pee | 17:49 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Create keystone session instance if not present https://review.openstack.org/304035 | 17:49 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Transmit all auth related vars from cli to inner methods https://review.openstack.org/408704 | 17:49 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Deprecate connection_pool variable https://review.openstack.org/408705 | 17:49 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Deprecate proxy_token and proxy_tenant_id args https://review.openstack.org/408703 | 17:49 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Introduce helper for checking args deprecation https://review.openstack.org/406295 | 17:49 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Sort arguments for client's methods https://review.openstack.org/406293 | 17:49 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Make SessionClient interface similar to HTTPClient https://review.openstack.org/350140 | 17:49 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Rename api_key to password https://review.openstack.org/406298 | 17:49 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Rename interface to endpoint_type https://review.openstack.org/406299 | 17:49 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Remove redundant args of _construct_http_client https://review.openstack.org/406296 | 17:49 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Rename bypass_url to endpoint_override https://review.openstack.org/406297 | 17:49 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Clarify meaning of project_id var https://review.openstack.org/350106 | 17:49 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Remove all code related to HTTPClient https://review.openstack.org/408728 | 17:49 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Deprecate volume_service_name argument https://review.openstack.org/408745 | 17:49 |
| *** asettle__ has joined #openstack-nova | 17:49 | |
| *** nic has quit IRC | 17:50 | |
| mriedem | dansmith: i need to get some food before the cafeteria kicks me out | 17:50 |
| dansmith | okay | 17:50 |
| mriedem | but i'm frantically jotting notes in that etherpad | 17:50 |
| *** unicell has joined #openstack-nova | 17:51 | |
| andreykurilin | sdague: hi! can you re-approve the chain? https://review.openstack.org/#/c/406293 it is just a rebase | 17:51 |
| *** esberglu has quit IRC | 17:52 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: [WIP] Add service_token for nova-neutron interaction https://review.openstack.org/410394 | 17:54 |
| *** lucasagomes is now known as lucas-afk | 17:54 | |
| *** esberglu has joined #openstack-nova | 17:55 | |
| *** asettle__ has quit IRC | 17:56 | |
| *** unicell has quit IRC | 17:56 | |
| *** unicell has joined #openstack-nova | 18:00 | |
| *** fragatina has joined #openstack-nova | 18:02 | |
| *** fragatina has quit IRC | 18:03 | |
| *** fragatina has joined #openstack-nova | 18:04 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: [WIP] Add service_token for nova-neutron interaction https://review.openstack.org/410394 | 18:05 |
| *** dikonoor has joined #openstack-nova | 18:06 | |
| sdague | andreykurilin: done | 18:06 |
| *** avolkov has quit IRC | 18:06 | |
| *** nic has joined #openstack-nova | 18:09 | |
| *** ihrachys has quit IRC | 18:10 | |
| *** acabot has quit IRC | 18:11 | |
| andreykurilin | sdague: thanks | 18:12 |
| *** asettle__ has joined #openstack-nova | 18:17 | |
| openstackgerrit | int32bit proposed openstack/nova: Add soft delete wrinkle to api-ref and config help https://review.openstack.org/411440 | 18:20 |
| openstackgerrit | Diana Clarke proposed openstack/nova: Add offset & limit docs & tests https://review.openstack.org/411441 | 18:21 |
| mriedem | dansmith: are you done peeing yet> | 18:26 |
| mriedem | ? | 18:26 |
| dansmith | mriedem: long ago | 18:27 |
| mriedem | oh good | 18:27 |
| mriedem | i'll start a hangout | 18:27 |
| mriedem | sdague: jaypipes: you want in on this? | 18:27 |
| mriedem | the hangout, not the pee play | 18:27 |
| *** amoralej is now known as amoralej|off | 18:27 | |
| *** asettle__ has quit IRC | 18:27 | |
| mriedem | dansmith: https://hangouts.google.com/call/f3uy7vrjlzakro6xmgzmpjkjd4e | 18:28 |
| *** rwmjones|hols has quit IRC | 18:28 | |
| openstackgerrit | Diana Clarke proposed openstack/nova: osapi_max_limit -> max_limit https://review.openstack.org/411444 | 18:29 |
| *** armax has joined #openstack-nova | 18:29 | |
| *** rwmjones has joined #openstack-nova | 18:30 | |
| sdague | mriedem: subject of hangout? | 18:30 |
| mriedem | sdague: https://etherpad.openstack.org/p/nova-ocata-ready-for-upgrade | 18:30 |
| *** harlowja has joined #openstack-nova | 18:31 | |
| diana_clarke | ^ that's a pretty col review id, wasted on a trivial patch | 18:32 |
| diana_clarke | col | 18:33 |
| diana_clarke | OMG, cool | 18:33 |
| * diana_clarke hangs head in shame | 18:33 | |
| *** bvanhav has quit IRC | 18:34 | |
| *** asettle__ has joined #openstack-nova | 18:36 | |
| openstackgerrit | Jay Pipes proposed openstack/nova: Make BlockDeviceMapping object support uuid https://review.openstack.org/242603 | 18:36 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Add uuid column to BlockDeviceMapping https://review.openstack.org/242602 | 18:37 |
| jaypipes | dansmith: ^^ rebased and added the index on block_device_mapping.uuid that mriedem requested. hope you don't mind. | 18:37 |
| edleafe | jaypipes: want to hop on the hangout? | 18:37 |
| mriedem | jaypipes: yeah you want to get on this call? | 18:37 |
| jaypipes | mriedem: yeah, coming. | 18:38 |
| *** eharney has quit IRC | 18:46 | |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP: create fake ordered_nets for get_instance_nw_info https://review.openstack.org/405452 | 18:49 |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP extract _validate_req_and_create_ports https://review.openstack.org/405401 | 18:49 |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP: make _filter_hypervisor_macs use objects https://review.openstack.org/405451 | 18:49 |
| *** avolkov has joined #openstack-nova | 18:50 | |
| *** unicell has quit IRC | 18:51 | |
| raj_singh | johnthetubaguy: Can you please look at https://review.openstack.org/#/c/409329/? Let me know if the approach is right. | 18:52 |
| *** bvanhav has joined #openstack-nova | 18:52 | |
| *** harlowja has quit IRC | 18:52 | |
| *** unicell has joined #openstack-nova | 18:53 | |
| *** Sukhdev has joined #openstack-nova | 18:54 | |
| *** ociuhandu has quit IRC | 18:56 | |
| *** thorst_ has joined #openstack-nova | 18:59 | |
| *** catintheroof has joined #openstack-nova | 19:02 | |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Race condition between audit and migrate/resize revert https://review.openstack.org/400995 | 19:04 |
| *** asettle__ has quit IRC | 19:04 | |
| openstackgerrit | jichenjc proposed openstack/nova: WIP: remove keypair server extension https://review.openstack.org/396611 | 19:05 |
| *** catinthe_ has quit IRC | 19:06 | |
| openstackgerrit | jichenjc proposed openstack/nova: move rest_api_version_history.rst to compute layer https://review.openstack.org/409741 | 19:07 |
| *** fragatina has quit IRC | 19:11 | |
| openstackgerrit | Diana Clarke proposed openstack/nova: Add offset & limit docs & tests https://review.openstack.org/411441 | 19:16 |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP: create fake ordered_nets for get_instance_nw_info https://review.openstack.org/405452 | 19:18 |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP: make _filter_hypervisor_macs use objects https://review.openstack.org/405451 | 19:18 |
| *** tbachman has quit IRC | 19:20 | |
| *** asettle has joined #openstack-nova | 19:20 | |
| *** portdirect is now known as portdirect_away | 19:21 | |
| *** tjones has joined #openstack-nova | 19:26 | |
| tjones | mriedem CI still blocked. having a neutron issue. getting the big guns to look at it | 19:27 |
| mriedem | ooo | 19:27 |
| mriedem | i think you guys employ a neutron core or two that knows something about nsx | 19:28 |
| mriedem | :) | 19:28 |
| tjones | :-D | 19:28 |
| *** kfarr has joined #openstack-nova | 19:28 | |
| *** portdirect_away is now known as portdirect | 19:34 | |
| mriedem | holy crap this is merged already?> https://review.openstack.org/#/c/386093 | 19:34 |
| mriedem | diana_clarke: nice work | 19:35 |
| *** claudiub has quit IRC | 19:35 | |
| diana_clarke | mriedem: yup, _so_ grateful & happy to see that get in before the holidays :) | 19:35 |
| *** Zer0Byte__ has quit IRC | 19:36 | |
| *** sudipto_ has quit IRC | 19:36 | |
| *** sudipto has quit IRC | 19:36 | |
| *** asettle has quit IRC | 19:36 | |
| *** nic has quit IRC | 19:36 | |
| *** nic has joined #openstack-nova | 19:37 | |
| *** asettle has joined #openstack-nova | 19:37 | |
| *** asettle has quit IRC | 19:41 | |
| *** sudipto has joined #openstack-nova | 19:41 | |
| diana_clarke | mriedem: I still want to do some more manual testing, but I keep running into cell0 and transport_url issues with devstack, but I'll try again tomorrow. | 19:42 |
| *** Sukhdev has quit IRC | 19:43 | |
| diana_clarke | this bug, I gather: https://bugs.launchpad.net/tripleo/+bug/1649341 | 19:43 |
| openstack | Launchpad bug 1649341 in puppet-nova "Undercloud upgrade fails with "Cell mappings are not created, but required for Ocata"" [Critical,In progress] - Assigned to Alex Schultz (alex-schultz) | 19:43 |
| *** eharney has joined #openstack-nova | 19:43 | |
| *** dikonoor has quit IRC | 19:43 | |
| mriedem | diana_clarke: how old is your devstack? | 19:44 |
| mriedem | diana_clarke: cellsv2 should be getting installed by default now | 19:45 |
| diana_clarke | mriedem: I think I was using stable/newton which also has issues with a missing policy file you have to add to get things working. | 19:45 |
| mriedem | hmm, well, you probably want a fresh devstack install since your change is merged | 19:45 |
| mriedem | then you can just mess with the novaclient stuff | 19:46 |
| *** sudipto has quit IRC | 19:49 | |
| diana_clarke | mriedem: master devstack was even more broken when I last tried, but I'll try again :) | 19:49 |
| mriedem | diana_clarke: what's your localrc? | 19:52 |
| *** Zer0Byte__ has joined #openstack-nova | 19:52 | |
| *** mtanino has joined #openstack-nova | 19:53 | |
| diana_clarke | mriedem: these are examples of what I typically do (but I'm not at the machine I use for devstack etc): http://paste.openstack.org/show/592539/ | 19:54 |
| diana_clarke | mriedem: Anyhoo, no need to troubleshoot, I'll give it another go tomorrow. I'm too lazy to walk downstairs, lol. | 19:56 |
| *** tbachman has joined #openstack-nova | 19:56 | |
| *** tbachman_ has joined #openstack-nova | 20:00 | |
| *** tbachman has quit IRC | 20:01 | |
| *** tbachman_ is now known as tbachman | 20:01 | |
| openstackgerrit | Diana Clarke proposed openstack/python-novaclient: Microversion 2.40 - Simple tenant usage pagination https://review.openstack.org/407825 | 20:02 |
| *** siva_krish has quit IRC | 20:04 | |
| mriedem | sdague: do you want nova-status written like nova/cmd/policy_check.py? because that's basically the same as nova-manage's structure | 20:07 |
| mriedem | it's just not in nova/cmd/manage.py | 20:07 |
| sdague | mriedem: yeh, in staring at code after the meeting, I think that's fine | 20:08 |
| mriedem | i think i'd rather just throw it in nova-manage then, i'm not sure why we wouldn't, else you'd have a thing like: nova-status status ready_for_upgrade, or i guess you could have an 'upgrade' subcommand, e.g. nova-status upgrade is-ready | 20:09 |
| mriedem | nvm i'll just go with something like policy_check | 20:11 |
| *** tjones has quit IRC | 20:13 | |
| *** moshele has joined #openstack-nova | 20:16 | |
| *** derekh has joined #openstack-nova | 20:17 | |
| *** catintheroof has quit IRC | 20:22 | |
| *** raunak_ has joined #openstack-nova | 20:23 | |
| *** raunak has quit IRC | 20:23 | |
| *** raunak_ is now known as raunak | 20:23 | |
| *** stvnoyes has quit IRC | 20:24 | |
| *** stvnoyes has joined #openstack-nova | 20:25 | |
| *** moshele has quit IRC | 20:25 | |
| *** jwcroppe has quit IRC | 20:27 | |
| sdague | I think it's easier to conceptualize as a seperate command. I also think it's really important that this *doesn't* use the db api, because of the model skew issue that we ran into | 20:27 |
| sdague | and nova manage does use db api, so that's going to be hard to handle if it's in the same command | 20:27 |
| *** ayoung has joined #openstack-nova | 20:27 | |
| *** jwcroppe has joined #openstack-nova | 20:28 | |
| mriedem | sure, i'm going rogue | 20:28 |
| mriedem | maverick | 20:28 |
| mriedem | as my favorite vp would say | 20:28 |
| mriedem | well, veep candidate | 20:28 |
| *** lamt has quit IRC | 20:29 | |
| mriedem | dansmith: we want the upgrade check to try and connect to the placement REST API right? | 20:31 |
| *** jwcroppe has quit IRC | 20:31 | |
| mriedem | to make sure it's running? | 20:32 |
| mriedem | or are we just going to be simple and check api db for RPs | 20:32 |
| mriedem | and if there are some, we assume it's going | 20:32 |
| dansmith | mriedem: yeah, I'm thinking just a simple get to make sureit's running, | 20:33 |
| dansmith | then check the hard stuff direct to the db where you can count stuff | 20:33 |
| mriedem | ok, my thinking was if we're doing a GET to the placement REST API, we can already just make that a list operation and do our count from that | 20:33 |
| dansmith | mriedem: it's just super inefficient to do that | 20:34 |
| sdague | mriedem: is any part of the placement API accessable without credentials? Like the root? | 20:34 |
| mriedem | sdague: not sure | 20:34 |
| dansmith | mriedem: with the direct to db, we can say "count me the number of RPs" and get back an integer, or we can ask the placement service to list everything and then count that in python once it flies over the network | 20:34 |
| sdague | I would honestly just make sure service catalog entry plus any HTTP returns | 20:34 |
| mriedem | cdent: jaypipes: ?^ | 20:34 |
| dansmith | sdague: agreed | 20:34 |
| mriedem | alright | 20:35 |
| *** catintheroof has joined #openstack-nova | 20:35 | |
| sdague | which is pretty much the keystone client connect code in the scheduler client that needs to be lifted | 20:35 |
| mriedem | well i was just going to import that | 20:36 |
| cdent | sdague, mriedem: everything at the moment requires credentials of some kind, but / will work for user role, everything else needs admin role | 20:36 |
| mriedem | ok | 20:36 |
| cdent | I wanted to make / wide open but it was non-obvious how to do that with keystone middleware so we left it for that special time called "later" | 20:37 |
| sdague | yeh, actually, we kind of need to know it's in the service catalog as well, and you can know that if you get a token today | 20:37 |
| sdague | so... I think that's fine | 20:37 |
| *** raunak_ has joined #openstack-nova | 20:38 | |
| *** raunak has quit IRC | 20:39 | |
| *** raunak_ is now known as raunak | 20:39 | |
| *** bvanhav has quit IRC | 20:41 | |
| *** derekh has quit IRC | 20:41 | |
| *** jwcroppe_ has joined #openstack-nova | 20:44 | |
| *** asettle has joined #openstack-nova | 20:46 | |
| *** weshay is now known as weshay_bbiab | 20:51 | |
| mriedem | sdague: i have something fun for you | 20:57 |
| mriedem | http://logs.openstack.org/25/411425/1/check/gate-nova-python27-db-ubuntu-xenial/bd30e9c/console.html#_2016-12-15_17_36_05_266505 | 20:57 |
| mriedem | something is leaking bad exception formatting in the tests | 20:57 |
| mriedem | might be test_create_instance_with_image_not_authorized | 20:59 |
| mriedem | that was it, i'll push a fix | 21:00 |
| melwitt | I was just wondering what the crazy output in the unit tests was | 21:01 |
| flwang | mriedem: sorry for the interruppt, a quick question. when boot instance, if i have two ceph clusters(SATA and SSD), can i specify which clusters i want to use? | 21:01 |
| sdague | yeh, it usually means something didn't setup the output capture fixtures correctly | 21:01 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Fix exception message formatting error in test https://review.openstack.org/411502 | 21:03 |
| *** rtheis has quit IRC | 21:03 | |
| mriedem | sdague: melwitt: ^ | 21:03 |
| mriedem | flwang: umm, maybe with host aggregates and extra specs or scheduler hints | 21:04 |
| *** siva_krish has joined #openstack-nova | 21:04 | |
| flwang | cinder can support multi backend, so based on my understanding, i can create a new volume based on an image with a particular volume_type, and then launch instance based on the volume | 21:06 |
| flwang | that should work | 21:06 |
| mriedem | yes | 21:07 |
| flwang | but i just want to figure out if nova can support that, because that would be handy | 21:07 |
| flwang | and easy for billing | 21:07 |
| mriedem | well nova doesn't care about the volume_type | 21:07 |
| mriedem | you create the volume in cinder with the given volume_type, which has it's own metadata/extra specs about which backend the volume lives in | 21:07 |
| flwang | yep, i know | 21:07 |
| mriedem | then you create the server in nova with that volume | 21:07 |
| smcginnis | Key being creating the volume in cinder first. Can't do that at instance creation time and specify a volume type. | 21:08 |
| flwang | yep, i just to confirm, that is no way to specify that in Nova when booting | 21:08 |
| mriedem | no, you can't specify volume type during boot from volume in nova | 21:08 |
| flwang | the bigger background is, glance is trying to support multi store | 21:09 |
| *** raunak has quit IRC | 21:09 | |
| *** raunak_ has joined #openstack-nova | 21:09 | |
| flwang | with that, cloud provider can support multi ceph clusters for one glance deployment | 21:09 |
| flwang | with that case, there is an opportunity that, nova can get different image locations which points to different clusters | 21:10 |
| *** bdeschenes has quit IRC | 21:10 | |
| flwang | then nova could be aware of the clusters | 21:10 |
| flwang | will nova be interested in this? | 21:10 |
| flwang | for example, if an image is saving in different ceph clusters, SATA and SSD, maybe user want to boot the instance based on SSD directly | 21:11 |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: WIP: create fake ordered_nets for get_instance_nw_info https://review.openstack.org/405452 | 21:12 |
| openstackgerrit | jichenjc proposed openstack/nova: WIP: remove keypair server extension https://review.openstack.org/396611 | 21:12 |
| sdague | mriedem: why do you think this should impact the subnode - https://review.openstack.org/#/c/409871/1/features.yaml ? | 21:20 |
| mriedem | sdague: i assumed that placement-api shows up in ENABLED_SERVICES in the localrc for both nodes in a multinode run, | 21:21 |
| sdague | it's grenade | 21:21 |
| mriedem | and devstack is checking ENABLED_SERVICES i believe to see if placement-api is in there and if so, sets up nova.conf for the placement auth creds | 21:22 |
| *** Drankis has quit IRC | 21:22 | |
| sdague | ENABLED_SERVICES is set to newton | 21:22 |
| mriedem | not even grenade | 21:22 |
| mriedem | http://logs.openstack.org/71/409871/1/check/gate-tempest-dsvm-multinode-full-ubuntu-xenial-nv/ad9a6ed/logs/subnode-2/screen-n-cpu.txt.gz#_2016-12-12_17_51_12_636 | 21:22 |
| mriedem | is not grenade ^ | 21:22 |
| sdague | oh | 21:22 |
| sdague | ah... right | 21:22 |
| mriedem | the bug we'd probably have in devstack, or d-g, or somewhere, is if it tries to run the placement-api service in apache on the subnode | 21:22 |
| sdague | no, it's just the devstack support is thing | 21:23 |
| sdague | thin | 21:23 |
| mriedem | when all we really want is it to configure nova.conf on the subnode compute | 21:23 |
| mriedem | diana_clarke: doesn't https://review.openstack.org/#/c/407825/ need to rebase on top of pkholkin's 2.39 patch? | 21:23 |
| mriedem | https://review.openstack.org/#/c/408166/ | 21:23 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/411069 | 21:26 |
| diana_clarke | mriedem: yup, I was just waiting in his to merge & then I was going to rebase. But I could just stack it on his, I guess. | 21:26 |
| diana_clarke | s/in/on | 21:26 |
| *** devkulkarni has quit IRC | 21:29 | |
| *** devkulkarni has joined #openstack-nova | 21:29 | |
| *** devkulkarni has quit IRC | 21:30 | |
| *** devkulkarni has joined #openstack-nova | 21:30 | |
| flwang | mriedem: so the answer is we don't really care? | 21:31 |
| mriedem | flwang: at this very moment i don't have an opinion | 21:32 |
| mriedem | and it's not something we could work on in ocata anyway | 21:32 |
| flwang | i don't say i want to get it in Ocata | 21:32 |
| flwang | i just want to collect if there is any interest from nova side so that i can cover the case | 21:33 |
| sdague | mriedem: https://review.openstack.org/#/c/411510/ probably is what's needed | 21:33 |
| *** cdent has quit IRC | 21:33 | |
| sdague | that should work as is, then allow adding placement-client for subnodes | 21:33 |
| *** Jeffrey4l_ has quit IRC | 21:35 | |
| mriedem | flwang: idk, it's probably a better question to cast into the dev or operators mailing list | 21:38 |
| flwang | mriedem: ok, thanks a lot ;) | 21:40 |
| *** jgriffith is now known as jgriffith_AutoAw | 21:40 | |
| flwang | sdague: hi, may i know what's the channel to reach most of the TC members? | 21:42 |
| *** fragatina has joined #openstack-nova | 21:46 | |
| *** Jeffrey4l_ has joined #openstack-nova | 21:48 | |
| *** jgriffith_AutoAw is now known as jgriffith | 21:52 | |
| *** eharney has quit IRC | 21:52 | |
| *** rtheis has joined #openstack-nova | 21:53 | |
| *** browne has quit IRC | 21:53 | |
| *** rtheis has quit IRC | 21:53 | |
| mriedem | i thought we had some kind of way to show actual help text with a nova-manage type command? | 21:54 |
| mriedem | i thought it was based on the docstrings from the command? | 21:54 |
| *** tblakes has quit IRC | 21:55 | |
| mriedem | oh i see | 21:55 |
| mriedem | magic | 21:55 |
| *** devkulkarni has quit IRC | 21:57 | |
| *** kfarr has quit IRC | 22:02 | |
| *** tjones has joined #openstack-nova | 22:02 | |
| *** browne has joined #openstack-nova | 22:03 | |
| *** asettle has quit IRC | 22:05 | |
| *** asettle has joined #openstack-nova | 22:06 | |
| *** ayoung has quit IRC | 22:10 | |
| *** bnemec has quit IRC | 22:10 | |
| *** asettle has quit IRC | 22:11 | |
| sdague | flwang: #openstack-dev? there is no tc channel. | 22:13 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Add nova-status upgrade check command framework https://review.openstack.org/411517 | 22:15 |
| mriedem | sdague: dansmith: jaypipes: edleafe: ^ the basic start of the framework for nova-status | 22:15 |
| flwang | sdague: cool, thanks | 22:16 |
| *** bnemec has joined #openstack-nova | 22:16 | |
| *** gouthamr has quit IRC | 22:16 | |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Resource tracker doesn't free resources on confirm resize https://review.openstack.org/405575 | 22:17 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: DO NOT MERGE: Check update of virtualenv https://review.openstack.org/411519 | 22:18 |
| *** _ducttape_ has joined #openstack-nova | 22:20 | |
| *** jheroux has quit IRC | 22:21 | |
| *** ducttape_ has quit IRC | 22:23 | |
| *** _ducttape_ has quit IRC | 22:24 | |
| *** liverpooler has quit IRC | 22:25 | |
| *** dtp has quit IRC | 22:26 | |
| mriedem | dansmith: in the api db blocker migration for cells v2 the first thing we check is if there are flavors in the api db, and if not we exit out assuming it's a clean install, | 22:28 |
| dansmith | mriedem: yep | 22:29 |
| mriedem | i'm assuming i do the same in the status upgrade check, since we don't create the flavors on db sync | 22:29 |
| dansmith | mriedem: sure, but that was because we couldn't talk to the cell database to check | 22:29 |
| dansmith | mriedem: and we also talked about counting the instance mapping records instead | 22:30 |
| dansmith | since the migration is a little more limited in what it can do, we just left it | 22:30 |
| dansmith | but checking flavors may not be the most reliable thing you could do there | 22:30 |
| dansmith | checking for non-zero number of instancemappings may be better for you | 22:30 |
| dansmith | I guess you can delete all your flavors just like you can delete all your instance mappings | 22:31 |
| dansmith | so maybe not much difference I guess | 22:31 |
| *** liverpooler has joined #openstack-nova | 22:31 | |
| mriedem | well, so this check is really wanting to make sure you have run simple_cell_setup first right? | 22:31 |
| mriedem | and synced the cell0 db | 22:32 |
| dansmith | yeah | 22:32 |
| mriedem | so it seems we'd really only care about the cell mappings and the host mappings | 22:32 |
| dansmith | which you could have done before you created flavors | 22:32 |
| dansmith | ..yeah, I'm not sure what your point is though | 22:33 |
| dansmith | you're going for a blank install not returning a problem right? | 22:33 |
| dansmith | even with a blank install if you don't have cell0 mapped, then upgrade or not, it's a problem | 22:33 |
| dansmith | so maybe you don't need a gate? | 22:33 |
| dansmith | the migration needed a sanity check because it couldn't fail to run on a legit-empty database | 22:34 |
| dansmith | but the upgrade check can say "yo dawg, empty database, don't expect things to work" and be fine | 22:34 |
| mriedem | but i don't need flavors for that, right? i can just say, 'yo dawg, no cells mappings in the api db, don't expect things to work' | 22:34 |
| dansmith | that's what I'm saying | 22:35 |
| dansmith | just report lack of cell mappings outright, don't stay quiet if there are no flavors | 22:35 |
| mriedem | yar | 22:37 |
| mriedem | btw, it's a good thing cell mappings and cell0 are setup for my by default in the db-backed tests :) | 22:37 |
| andreykurilin | sdague: sorry, can you remove +A and put it again for https://review.openstack.org/#/c/408703 ? it stuck :( | 22:42 |
| dansmith | effin' a | 22:42 |
| *** devkulkarni has joined #openstack-nova | 22:44 | |
| *** baoli has quit IRC | 22:45 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: WIP: nova-status: implement _check_cellsv2 https://review.openstack.org/411525 | 22:46 |
| mriedem | dansmith: ok there you go | 22:46 |
| mriedem | for a starter | 22:46 |
| mriedem | needs failure scenario tests | 22:46 |
| *** catintheroof has quit IRC | 22:46 | |
| dansmith | yeah cool | 22:47 |
| *** jgriffith is now known as jgriffith_AutoAw | 22:47 | |
| *** liverpooler has quit IRC | 22:47 | |
| *** jgriffith_AutoAw is now known as jgriffith | 22:47 | |
| *** vladikr has quit IRC | 22:48 | |
| mriedem | alright, well i'll probably fart around with the placement stuff tomorrow, replied to your comments on the bottom change | 22:51 |
| *** browne has quit IRC | 22:52 | |
| *** mriedem has quit IRC | 22:52 | |
| *** Swami has quit IRC | 22:54 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/411069 | 22:57 |
| *** jaypipes has quit IRC | 23:02 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Deprecate proxy_token and proxy_tenant_id args https://review.openstack.org/408703 | 23:02 |
| *** mvk has joined #openstack-nova | 23:03 | |
| *** jamesdenton has quit IRC | 23:03 | |
| *** dave-mccowan has quit IRC | 23:04 | |
| *** thorst_ has quit IRC | 23:05 | |
| *** asettle has joined #openstack-nova | 23:07 | |
| *** asettle has quit IRC | 23:11 | |
| *** markvoelker has quit IRC | 23:13 | |
| *** devkulkarni has quit IRC | 23:13 | |
| *** devkulkarni has joined #openstack-nova | 23:14 | |
| *** thorst_ has joined #openstack-nova | 23:15 | |
| *** thorst_ has quit IRC | 23:15 | |
| *** catintheroof has joined #openstack-nova | 23:17 | |
| *** raunak_ has quit IRC | 23:17 | |
| *** catintheroof has quit IRC | 23:17 | |
| *** catintheroof has joined #openstack-nova | 23:18 | |
| *** rwmjones has quit IRC | 23:18 | |
| *** esberglu has quit IRC | 23:21 | |
| *** rwmjones has joined #openstack-nova | 23:23 | |
| *** devkulkarni has quit IRC | 23:28 | |
| *** devkulkarni has joined #openstack-nova | 23:29 | |
| *** ayoung has joined #openstack-nova | 23:29 | |
| *** devkulkarni has quit IRC | 23:35 | |
| *** devkulkarni has joined #openstack-nova | 23:37 | |
| *** pradk has quit IRC | 23:38 | |
| *** devkulkarni has quit IRC | 23:38 | |
| *** devkulkarni has joined #openstack-nova | 23:40 | |
| *** devkulkarni1 has joined #openstack-nova | 23:43 | |
| *** jamielennox is now known as jamielennox|away | 23:46 | |
| *** devkulkarni has quit IRC | 23:46 | |
| *** jamielennox|away is now known as jamielennox | 23:50 | |
| *** cdelatte has quit IRC | 23:55 | |
| *** dave-mccowan has joined #openstack-nova | 23:55 | |
| *** harlowja has joined #openstack-nova | 23:58 | |
| *** raunak has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!