Tuesday, 2016-12-27

*** ducttape_ has joined #openstack-nova00:15
*** dave-mccowan has quit IRC00:17
*** Fdaisuke has quit IRC00:31
*** ducttape_ has quit IRC00:35
*** yingjun has joined #openstack-nova00:37
*** catintheroof has quit IRC00:42
*** catintheroof has joined #openstack-nova00:43
*** ducttape_ has joined #openstack-nova00:47
*** stvnoyes has joined #openstack-nova00:50
*** tuanluong has joined #openstack-nova00:53
*** hfu has joined #openstack-nova00:55
*** hoangcx has joined #openstack-nova00:57
*** zz_dimtruck is now known as dimtruck00:58
*** ducttape_ has quit IRC00:59
*** ducttape_ has joined #openstack-nova01:00
*** phuongnh has joined #openstack-nova01:01
*** ducttape_ has joined #openstack-nova01:01
*** mlavalle has quit IRC01:09
*** masayukig_ is now known as masayukig01:16
*** tyrola has quit IRC01:27
*** tyrola has joined #openstack-nova01:28
oomichimriedem: is it possible to get your review on https://review.openstack.org/#/c/413453/ ?01:33
oomichithat seems necessary to be backported to stable branches also for avoiding an internal error01:33
*** yingjun has quit IRC01:39
*** Jeffrey4l has quit IRC01:39
*** Jeffrey4l has joined #openstack-nova01:39
*** ducttape_ has quit IRC01:42
*** ducttape_ has joined #openstack-nova01:43
*** ducttape_ has quit IRC01:47
*** ducttape_ has joined #openstack-nova01:48
*** yufei has joined #openstack-nova01:50
oomichimikal: are you around here today?01:54
*** ducttape_ has quit IRC01:59
*** hongbin has quit IRC02:03
*** gongysh has joined #openstack-nova02:05
*** ducttape_ has joined #openstack-nova02:16
*** gongysh has quit IRC02:20
*** hfu_ has joined #openstack-nova02:22
*** hfu has quit IRC02:23
*** baoli has joined #openstack-nova02:24
*** baoli has quit IRC02:28
*** ducttape_ has quit IRC02:32
takashinoomichi: Could you review https://review.openstack.org/#/c/323287/, https://review.openstack.org/#/c/413075/, https://review.openstack.org/#/c/308746/ ?02:35
takashinoomichi: They got one +2. They need more +2 and W+1.02:35
*** hfu_ has quit IRC02:40
*** gcb has quit IRC02:52
*** gcb has joined #openstack-nova02:55
*** dave-mccowan has joined #openstack-nova02:55
*** dimtruck is now known as zz_dimtruck02:56
*** yingjun has joined #openstack-nova02:59
*** sacharya has joined #openstack-nova03:08
*** hfu has joined #openstack-nova03:09
openstackgerritZhenyu Zheng proposed openstack/nova: Add query parameters white list for server list/detail  https://review.openstack.org/40857103:12
*** hongbin has joined #openstack-nova03:13
*** mdnadeem has joined #openstack-nova03:13
*** yamahata has quit IRC03:14
*** sacharya_ has joined #openstack-nova03:24
*** sacharya has quit IRC03:24
*** baoli has joined #openstack-nova03:26
*** baoli has quit IRC03:26
*** mdnadeem has quit IRC03:30
*** baoli has joined #openstack-nova03:31
*** ducttape_ has joined #openstack-nova03:32
openstackgerritSpencer Yu proposed openstack/nova: [3/3]Replace six.iteritems() with .items()  https://review.openstack.org/41508003:34
*** ducttape_ has quit IRC03:37
*** links has joined #openstack-nova03:39
*** gongysh has joined #openstack-nova03:41
*** ducttape_ has joined #openstack-nova03:45
*** dave-mcc_ has joined #openstack-nova03:52
*** xinliang has quit IRC03:53
*** xinliang has joined #openstack-nova03:54
*** dave-mccowan has quit IRC03:55
*** ducttape_ has quit IRC03:55
*** tiantian has quit IRC03:55
*** zz_dimtruck is now known as dimtruck03:56
*** hieulq_ has quit IRC03:56
openstackgerritJay Pipes proposed openstack/nova: placement: RT now adds proper Ironic inventory  https://review.openstack.org/40447203:59
openstackgerritJay Pipes proposed openstack/nova: rt: explicitly pass compute node to _update()  https://review.openstack.org/39847203:59
openstackgerritJay Pipes proposed openstack/nova: rt: use a single ResourceTracker object instance  https://review.openstack.org/39847303:59
*** hieulq has joined #openstack-nova04:00
*** takedakn has joined #openstack-nova04:02
*** psachin has joined #openstack-nova04:10
*** dave-mcc_ has quit IRC04:10
*** yingjun has quit IRC04:13
*** zhs_ has joined #openstack-nova04:15
*** zhs__ has quit IRC04:18
*** hongbin_ has joined #openstack-nova04:25
*** baoli has quit IRC04:25
*** hongbin has quit IRC04:26
*** baoli has joined #openstack-nova04:26
*** hongbin_ has quit IRC04:29
*** ayogi has joined #openstack-nova04:34
*** nicolasbock has joined #openstack-nova04:35
*** yingjun has joined #openstack-nova04:36
*** baoli has quit IRC04:39
*** baoli has joined #openstack-nova04:40
*** baoli has quit IRC04:45
alex_xuvdrok: just done the review04:46
*** Jeffrey4l has quit IRC04:57
*** Jeffrey4l has joined #openstack-nova04:58
*** takedakn has quit IRC04:58
*** baoli has joined #openstack-nova05:00
*** pbandark has joined #openstack-nova05:01
*** ducttape_ has joined #openstack-nova05:03
openstackgerritAlex Xu proposed openstack/nova: Use JSON-Schema to validate query parameters for keypairs API  https://review.openstack.org/39875505:04
*** baoli has quit IRC05:04
*** prateek has joined #openstack-nova05:05
*** haplo37_ has quit IRC05:06
*** ducttape_ has quit IRC05:07
*** baoli has joined #openstack-nova05:09
*** baoli has quit IRC05:14
*** haplo37_ has joined #openstack-nova05:15
*** tbachman has joined #openstack-nova05:18
*** yingjun has quit IRC05:21
*** xinliang has quit IRC05:28
*** vtech has joined #openstack-nova05:37
*** tbachman has quit IRC05:42
*** vtech has quit IRC05:46
*** yingjun has joined #openstack-nova05:49
*** baoli has joined #openstack-nova05:50
*** mal66 has joined #openstack-nova05:50
*** ratailor has joined #openstack-nova05:52
*** baoli has quit IRC05:54
openstackgerritTakashi NATSUME proposed openstack/nova: Refactor a test method including 3 test cases  https://review.openstack.org/39473805:55
vdrokalex_xu: thanks!06:01
alex_xuvdrok: np06:01
openstackgerritAlex Xu proposed openstack/nova: Limit the min length of string for integer JSON-Schema  https://review.openstack.org/41510306:13
alex_xuoomichi: ^ a fix for our json-schema06:14
openstackgerritZhenyu Zheng proposed openstack/nova: Add query parameters white list for server list/detail  https://review.openstack.org/40857106:14
*** hfu has quit IRC06:22
*** gongysh has quit IRC06:23
*** adisky_ has joined #openstack-nova06:24
oomichitakashin: one question about https://review.openstack.org/#/c/323287/34/nova/tests/unit/cells/test_cells_scheduler.py06:25
oomichiself is added to _fake_instance_update_at_top(), but it is not to fake_build_request_spec() What is difference between them?06:26
oomichitakashin: both seem to be used for stub_out()06:27
oomichitakashin: ah, maybe it is because the difference of target methods.06:28
*** ircuser-1 has joined #openstack-nova06:30
*** moshele has joined #openstack-nova06:31
oomichitakashin: +W on the unit test one06:32
*** Satya__ has joined #openstack-nova06:32
oomichialex_xu: are you around?06:32
alex_xuoomichi: yea, i'm here06:33
takashinoomichi: fake_build_request_spec()  is not an instance mehod.06:33
oomichialex_xu: is it possible to remove your score on https://review.openstack.org/#/c/413075 ?06:33
*** nandal has joined #openstack-nova06:33
oomichialex_xu: the description doesn't seem good for users06:33
takashinThe fake mehods that is added 'self' argument are instance methods.06:33
*** ducttape_ has joined #openstack-nova06:34
takashinoomichi: The fake mehods that is added 'self' argument are instance methods.06:34
*** sacharya_ has quit IRC06:34
takashinoomichi: That is the difference.06:34
oomichitakashin: yeah I know. then I already +W on thhat06:34
alex_xuoomichi: basically we use 'the action' everywhere, maybe it is ok with later patch if someone have better words?06:35
takashinoomichi: Thank you so much.06:35
oomichialex_xu: Yeah I know that. OK, let discuss it later with another patch06:37
alex_xuoomichi: cool!06:37
oomichialex_xu: no problem, thanks for your quick response :)06:38
alex_xuoomichi: np06:38
*** ducttape_ has quit IRC06:38
*** sridharg has joined #openstack-nova06:43
oomichitakashin: btw all patches of bp/remove-mox-ocata are already up now?06:46
oomichihttps://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/remove-mox-ocata06:46
oomichiI just want to know when we can finish it06:47
takashinoomichi: Sorry. I don't know it.06:48
oomichitakashin: no problem, that is just a question06:49
oomichiI didn't want to review them *forever ;)06:49
oomichilike remove-mox-pike, remove-mox-q**, ...06:50
*** baoli has joined #openstack-nova06:50
oomichitakashin: one more question about https://review.openstack.org/#/c/308746/40/nova/tests/unit/api/openstack/compute/test_block_device_mapping_v1.py06:53
oomichitakashin: _validate_bdm() doesn't return any value like https://github.com/openstack/nova/blob/master/nova/compute/api.py#L133206:54
oomichitakashin: in test_create_instance_with_volumes_enabled_and_bdms_no_image(), the method is mocked with return_value, why?06:55
openstackgerritZhenyu Zheng proposed openstack/nova-specs: Trivial typo fix in spec  https://review.openstack.org/41511506:55
*** baoli has quit IRC06:55
oomichiin addition, in the test, the patch adds assert_called_once_with() for the method, but the other tests doesn't do that.06:55
*** tesseract has joined #openstack-nova06:56
*** dimtruck is now known as zz_dimtruck06:59
*** zz_dimtruck is now known as dimtruck06:59
takashinoomichi: I just replace mox with mock. So if '_validate_bdm' does not return any value in previous, it remains as it was.07:01
takashinoomichi:  if '_validate_bdm' returns a value int test methods in previous,  it remains as it was.07:03
takashinoomichi: assert statement is same.07:03
openstackgerritZhenyu Zheng proposed openstack/nova: Add query parameters white list for server list/detail  https://review.openstack.org/40857107:04
oomichitakashin: ok, that should be fixed for actual test in this patch I think07:08
*** dimtruck is now known as zz_dimtruck07:09
takashinoomichi: Old tests were not good?07:09
oomichitakashin: yeah, I think so because the private method doesn't return value at all07:09
takashinoomichi: Thank you for your comments. I will fix them.07:13
oomichitakashin: cool, I will check it after updating07:13
*** mjura has joined #openstack-nova07:14
*** mjura has quit IRC07:20
*** mjura has joined #openstack-nova07:20
openstackgerritTakashi NATSUME proposed openstack/nova: Refactor a test method including 7 test cases  https://review.openstack.org/39543607:27
*** pcaruana has joined #openstack-nova07:31
openstackgerritTakashi NATSUME proposed openstack/nova: Refactor a test method including 7 test cases  https://review.openstack.org/39543607:32
*** sam_nowitzki has joined #openstack-nova07:33
Kevin_Zhengoomichi: hi could you have a look on https://review.openstack.org/#/c/414529/ ? it failed heat and ceilometer gate, they have fixed in their own project already but we may still have fix it since we dont know who else is using "interface" to init novaclient07:36
*** sacharya has joined #openstack-nova07:36
*** gongysh has joined #openstack-nova07:37
oomichiKevin_Zheng: I cannot understand the patch purpose TBH07:39
oomichiKevin_Zheng: The patch way doesn't work for _LW() I think07:40
Kevin_ZhengHm, I will have a check again07:40
Kevin_ZhengThanks07:40
*** sacharya has quit IRC07:41
*** ekuris has joined #openstack-nova07:42
openstackgerritZhenyu Zheng proposed openstack/nova-specs: Trivial typo fix in spec  https://review.openstack.org/41511507:43
*** gcb has quit IRC07:46
*** pcaruana has quit IRC07:50
*** pcaruana has joined #openstack-nova07:51
*** hfu has joined #openstack-nova07:55
openstackgerritZhenyu Zheng proposed openstack/nova-specs: Trivial typo fix in spec  https://review.openstack.org/41511507:58
openstackgerritSpencer Yu proposed openstack/nova: [3/3]Replace six.iteritems() with .items()  https://review.openstack.org/41508008:02
*** ducttape_ has joined #openstack-nova08:04
*** sahid has joined #openstack-nova08:06
*** gcb has joined #openstack-nova08:08
*** ducttape_ has quit IRC08:09
vsaienk0Hello oomichi, could you please help to merge https://review.openstack.org/#/c/414214/ this patch fix issue that is a blocker for Ironic CI.08:10
oomichivsaienk0: ok, I am checking the code and bug report08:18
*** mal66 has quit IRC08:21
oomichivsaienk0: I cannot catch the point of the patch yet.08:22
oomichivsaienk0: in https://review.openstack.org/#/c/414214/4/nova/scheduler/client/report.py , the change seems to skip storing the data if vcpus(and other) is 0 instead of storing 008:22
oomichivsaienk0: according to the bug report, "request stuck at nova" is a problem. I cannot follow why this patch can solve the problem08:24
vsaienk0oomichi: when placement client reports 0 to API request takes a lot of time (more than 6 sec)08:26
vsaienk0Lock "compute_resources" released by "nova.compute.resource_tracker._update_available_resource" :: held 6.935s inner08:26
vsaienk0oomichi: please check http://logs.openstack.org/39/404239/14/check/gate-tempest-dsvm-ironic-ipa-wholedisk-pxe_snmp-tinyipa-ubuntu-xenial-nv/8f98498/logs/screen-n-cpu.txt.gz#_2016-12-21_13_24_24_30708:26
*** mdnadeem has joined #openstack-nova08:26
*** nicolasbock has quit IRC08:27
*** ekuris has quit IRC08:27
vsaienk0oomichi: client shouldn't report 0 to placement API as it is not valid value and will not accepted anyway, API returns 40008:27
openstackgerritZhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail  https://review.openstack.org/41514208:27
vsaienk0oomichi: whit patch proposed the task takes lock for less than a second (0.148s) http://logs.openstack.org/50/414650/2/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-tinyipa-ubuntu-xenial/9e223e7/logs/screen-n-cpu.txt.gz#_2016-12-24_08_22_59_77408:30
vsaienk0s/whit/with08:30
*** zhs_ has quit IRC08:31
*** zhs_ has joined #openstack-nova08:31
*** ekuris has joined #openstack-nova08:42
openstackgerritZhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail  https://review.openstack.org/41514208:44
*** palexster has quit IRC08:48
openstackgerritChangBo Guo(gcb) proposed openstack/nova: Update py35 functional tests blacklist  https://review.openstack.org/41514908:51
*** palexster has joined #openstack-nova08:54
*** gcb has quit IRC08:59
*** zzzeek has quit IRC09:00
*** prateek has quit IRC09:00
*** zzzeek has joined #openstack-nova09:00
*** hfu has quit IRC09:01
*** ralonsoh has joined #openstack-nova09:02
*** baoli has joined #openstack-nova09:05
openstackgerritTakashi NATSUME proposed openstack/nova: Remove mox in test_block_device_mapping_v1.py  https://review.openstack.org/30874609:07
*** baoli has quit IRC09:10
vsaienk0oomichi: I've replied in the bug https://bugs.launchpad.net/ironic/+bug/1651678/comments/1409:12
openstackLaunchpad bug 1651678 in OpenStack Compute (nova) "boot server request randomly hanging at n-cpu side, and didn't get to Ironic" [High,In progress] - Assigned to John L. Villalovos (happycamp)09:12
*** hfu has joined #openstack-nova09:12
*** prateek has joined #openstack-nova09:15
*** fragatina has joined #openstack-nova09:16
*** gcb has joined #openstack-nova09:17
*** bhagyashris has joined #openstack-nova09:19
oomichivsaienk0: I put a question about that09:21
vsaienk0oomichi: unfortunately I'm not familiar with placement API enough, I hope that jaypipes will check your comment. Thank you for your time!09:30
*** gongysh has quit IRC09:30
oomichivsaienk0: I also am not good at placement API so well ;) Yeah, it is nice to wait for jay's response09:31
*** ducttape_ has joined #openstack-nova09:35
*** zenoway has joined #openstack-nova09:38
*** irenab_ has joined #openstack-nova09:38
*** irenab_ has quit IRC09:38
*** sacharya has joined #openstack-nova09:39
*** ekuris has quit IRC09:39
*** prateek has quit IRC09:39
*** ducttape_ has quit IRC09:39
*** zenoway has quit IRC09:40
*** zenoway has joined #openstack-nova09:40
*** karthiks has joined #openstack-nova09:42
*** sacharya has quit IRC09:43
*** ekuris has joined #openstack-nova09:45
openstackgerritPawel Koniszewski proposed openstack/nova: live-mig: Add claims and proper resource tracking  https://review.openstack.org/24448909:47
*** nicolasbock has joined #openstack-nova09:47
*** karthiks has quit IRC09:49
*** karthiks has joined #openstack-nova09:50
*** yingjun has quit IRC09:51
*** ekuris has quit IRC09:51
*** baoli has joined #openstack-nova09:52
*** baoli has quit IRC09:56
*** liusheng has quit IRC09:59
*** liusheng has joined #openstack-nova10:00
*** prateek has joined #openstack-nova10:00
*** artom has joined #openstack-nova10:00
*** artom_ has quit IRC10:01
*** ekuris has joined #openstack-nova10:06
*** tuanluong has quit IRC10:08
*** sam_nowitzki has quit IRC10:16
*** sam_nowitzki has joined #openstack-nova10:16
*** Satya__ has quit IRC10:28
openstackgerritAlex Xu proposed openstack/nova: [POC][placement] Add Traits API to placement service  https://review.openstack.org/37620010:29
*** sam_nowitzki has quit IRC10:30
*** kristian__ has joined #openstack-nova10:46
*** ratailor has quit IRC10:55
*** yufei has quit IRC10:56
*** hoangcx has quit IRC10:57
*** ducttape_ has joined #openstack-nova11:05
*** takashin_ has joined #openstack-nova11:05
*** takashin has quit IRC11:07
*** ducttape_ has quit IRC11:10
*** slaweq has joined #openstack-nova11:21
pkoniszewskihey, can someone unabandon this change https://review.openstack.org/#/c/328997/ ? I'd like to push it forward11:22
*** ralonsoh has quit IRC11:24
*** ociuhandu has quit IRC11:25
*** slaweq has quit IRC11:30
tdurakovpkoniszewski: hi, won't it be enough to just resubmit a new version?11:34
*** phuongnh has quit IRC11:40
*** zenoway has quit IRC11:51
*** zenoway has joined #openstack-nova11:51
*** ociuhandu has joined #openstack-nova11:53
*** zenoway has quit IRC11:56
*** nandal has quit IRC12:00
*** kristian__ has quit IRC12:02
*** kristian__ has joined #openstack-nova12:02
pkoniszewskitdurakov: i'm getting an error from remote that the change is closed12:12
*** prateek has quit IRC12:13
*** rfolco has joined #openstack-nova12:17
*** rfolco has quit IRC12:17
*** rfolco has joined #openstack-nova12:18
*** hfu has quit IRC12:20
*** mdnadeem has quit IRC12:21
*** hfu has joined #openstack-nova12:23
*** baoli has joined #openstack-nova12:23
*** baoli has quit IRC12:27
*** sridharg has quit IRC12:33
openstackgerritsahid proposed openstack/nova: libvirt: update the active migrations ds to support migration result  https://review.openstack.org/40926012:33
openstackgerritsahid proposed openstack/nova: libvirt: pass to live migration monitor the API result  https://review.openstack.org/40926112:33
*** nicolasbock has quit IRC12:34
*** ducttape_ has joined #openstack-nova12:36
*** takashin_ has left #openstack-nova12:38
*** ducttape_ has quit IRC12:40
*** sahid has quit IRC12:46
*** BlackDex has quit IRC13:02
*** sridharg has joined #openstack-nova13:09
*** moshele has quit IRC13:23
*** sahid has joined #openstack-nova13:24
*** moshele has joined #openstack-nova13:25
*** blaisebo_ has joined #openstack-nova13:27
*** liverpooler has joined #openstack-nova13:33
*** ducttape_ has joined #openstack-nova13:33
*** yingjun has joined #openstack-nova13:36
*** BlackDex has joined #openstack-nova13:36
*** sacharya has joined #openstack-nova13:40
*** haplo37_ has quit IRC13:41
*** sacharya has quit IRC13:45
*** haplo37_ has joined #openstack-nova13:50
*** ducttape_ has quit IRC13:54
*** jaypipes has joined #openstack-nova13:55
jaypipesmriedem: mornin.13:56
jaypipesmriedem: you working today?13:56
*** nklenke has joined #openstack-nova14:00
*** dave-mccowan has joined #openstack-nova14:01
*** blaisebo_ has quit IRC14:14
openstackgerritsahid proposed openstack/nova: libvirt: update the active migrations ds to support migration result  https://review.openstack.org/40926014:14
openstackgerritsahid proposed openstack/nova: libvirt: pass to live migration monitor the API result  https://review.openstack.org/40926114:14
*** moshele has quit IRC14:15
jaypipessahid: hey, I'm fixing the unit test failures in https://review.openstack.org/#/c/400877/14:16
jaypipessahid: I rebased that patch series yesterday and accidentally introduced them.14:16
*** maestropandy has joined #openstack-nova14:18
*** maestropandy has left #openstack-nova14:18
sahidjaypipes: yes, no worries I have to address your comments anyways so14:19
*** dave-mccowan has quit IRC14:20
*** ducttape_ has joined #openstack-nova14:20
jaypipessahid: thx man, sorry about that14:20
*** yingjun has quit IRC14:20
jaypipessahid: all those pep8 failures, BTW, are unrelated. I kicked off rechecks on those ones.14:21
*** lamt has joined #openstack-nova14:22
*** mlavalle has joined #openstack-nova14:24
sahidjaypipes: ok i will check that :)14:29
*** moshele has joined #openstack-nova14:33
*** dave-mccowan has joined #openstack-nova14:35
pkoniszewskisahid: hey, can you unabandon this change https://review.openstack.org/#/c/328997/ ? I'd like to push it forward14:44
*** Jeffrey4l has quit IRC15:02
*** ociuhandu has quit IRC15:06
*** tjones has joined #openstack-nova15:07
*** ekuris has quit IRC15:07
*** Jeffrey4l has joined #openstack-nova15:09
*** tjones has quit IRC15:11
*** Jeffrey4l has quit IRC15:12
openstackgerritsahid proposed openstack/nova: objects: add new field cpu_emulator_threads_policy  https://review.openstack.org/38502215:14
openstackgerritsahid proposed openstack/nova: numa: add numa constraints for emulator threads policy  https://review.openstack.org/38502315:15
openstackgerritsahid proposed openstack/nova: libvirt: return a CPU overhead if isolate emulator threads requested  https://review.openstack.org/38536415:15
openstackgerritsahid proposed openstack/nova: objects: add new field cpus_overhead in NUMACell  https://review.openstack.org/40087415:15
openstackgerritsahid proposed openstack/nova: numa: fit instance toplogy with cpu overhead onto cores  https://review.openstack.org/40087515:15
openstackgerritsahid proposed openstack/nova: virt: update overhead to take into account vCPUs  https://review.openstack.org/38502415:15
openstackgerritsahid proposed openstack/nova: libvirt: make emulator threads to run on the reserved pCPU  https://review.openstack.org/40087815:15
openstackgerritsahid proposed openstack/nova: numa: take into account cpus overhead  https://review.openstack.org/40087615:15
openstackgerritsahid proposed openstack/nova: numa: update numa usage incording the cpu overhead  https://review.openstack.org/40087715:15
sahidpkoniszewski: yes sure I did not notice that it got abandonned15:15
*** ayogi has quit IRC15:16
sahidjaypipes: did you noce this weird thing with 'api_samples' https://review.openstack.org/#/c/38502315:17
sahidi never pushed that but it looks to be there since th beginning15:18
jaypipessahid: yeah, that's a weird one. hoping it was a blip...15:19
*** pbandark has quit IRC15:21
openstackgerritPawel Koniszewski proposed openstack/nova: live-mig: Add claims and proper resource tracking  https://review.openstack.org/24448915:24
openstackgerritPawel Koniszewski proposed openstack/nova: libvirt: pass libvirt reference methods to migration  https://review.openstack.org/32899715:24
openstackgerritPawel Koniszewski proposed openstack/nova: libvirt: live-migrate updates NUMA and cpus in the XML  https://review.openstack.org/28674415:24
pkoniszewskisahid: thanks!15:24
openstackgerritJay Pipes proposed openstack/nova: rt: explicitly pass compute node to _update()  https://review.openstack.org/39847215:27
openstackgerritJay Pipes proposed openstack/nova: rt: use a single ResourceTracker object instance  https://review.openstack.org/39847315:27
openstackgerritPawel Koniszewski proposed openstack/nova: live-mig: Add claims and proper resource tracking  https://review.openstack.org/24448915:27
openstackgerritPawel Koniszewski proposed openstack/nova: libvirt: pass libvirt reference methods to migration  https://review.openstack.org/32899715:27
openstackgerritPawel Koniszewski proposed openstack/nova: libvirt: live-migrate updates NUMA and cpus in the XML  https://review.openstack.org/28674415:27
openstackgerritJay Pipes proposed openstack/nova: placement: report client handle InventoryInUse  https://review.openstack.org/40499015:27
*** ociuhandu has joined #openstack-nova15:27
openstackgerritJay Pipes proposed openstack/nova: placement: minor refactor _allocate_for_instance()  https://review.openstack.org/40570515:27
openstackgerritJay Pipes proposed openstack/nova: placement: RT now adds proper Ironic inventory  https://review.openstack.org/40447215:27
*** sridharg has quit IRC15:30
*** baoli has joined #openstack-nova15:32
*** links has quit IRC15:33
*** psachin has quit IRC15:34
*** dave-mccowan has quit IRC15:34
*** zz_dimtruck is now known as dimtruck15:35
mriedemjaypipes: i am, had to take laura and maya to the airport this morning but now i'm home15:36
mriedemworking all week15:36
*** baoli has quit IRC15:36
*** baoli has joined #openstack-nova15:39
*** sacharya has joined #openstack-nova15:41
*** baoli has quit IRC15:44
mriedemjianghuaw: on https://review.openstack.org/#/c/365505/ - can the citrix xenserver ci have a run against that patch with the tempest.api.compute.servers.test_attach_interfaces.AttachInterfacesTestJSON.test_create_list_show_delete_interfaces test enabled?15:45
*** sacharya has quit IRC15:46
mriedemwhich you could maybe do with a check for the patch 365505 in the CI setup so the tempest blacklist is modified15:46
*** openstackgerrit_ has joined #openstack-nova15:56
*** openstackgerrit_ has quit IRC15:57
*** ducttape_ has quit IRC15:59
*** mjura has quit IRC16:03
*** sacharya has joined #openstack-nova16:04
*** dtp has joined #openstack-nova16:06
*** erlon has joined #openstack-nova16:16
*** tesseract has quit IRC16:22
*** brad[] has quit IRC16:29
*** brad[] has joined #openstack-nova16:31
*** sahid has quit IRC16:32
jaypipesmriedem: trying to figure out wtf this is... http://logs.openstack.org/76/400876/11/check/gate-nova-pep8-ubuntu-xenial/5484680/console.html16:34
mriedemhmm, just on this change or seeing on multiple? i'll logstash.16:35
jaypipesmriedem: it's also on an earlier one in the same series: http://logs.openstack.org/23/385023/13/check/gate-nova-pep8-ubuntu-xenial/786f6f0/console.html16:36
jaypipesmriedem: but those pep8 errors don't have anything to do with code in those patches.16:37
jaypipesmriedem: those patches don't touch api_samples.16:37
mriedemdoes it need to be rebased?16:37
jaypipesshittttttttt16:37
jaypipesthis is my fault.16:37
jaypipesmfer.16:37
jaypipeshttps://review.openstack.org/#/c/385023/16:37
mriedemheh, that would do it :)16:37
jaypipes^^ accidentally added some leftover api_samples crap :(16:38
jaypipesgah. I'm an idiot.16:38
mriedemaccidents happen16:38
*** moshele has quit IRC16:39
mriedemJayF: are there patches up anywhere for this yet? https://blueprints.launchpad.net/nova/+spec/ironic-rescue-mode16:40
*** toure has quit IRC16:41
mriedemlooks like there are patches up for Ironic but they are all in merge conflict16:41
openstackgerritJay Pipes proposed openstack/nova: numa: add numa constraints for emulator threads policy  https://review.openstack.org/38502316:42
openstackgerritJay Pipes proposed openstack/nova: libvirt: return a CPU overhead if isolate emulator threads requested  https://review.openstack.org/38536416:42
openstackgerritJay Pipes proposed openstack/nova: numa: fit instance toplogy with cpu overhead onto cores  https://review.openstack.org/40087516:42
openstackgerritJay Pipes proposed openstack/nova: virt: update overhead to take into account vCPUs  https://review.openstack.org/38502416:42
openstackgerritJay Pipes proposed openstack/nova: libvirt: make emulator threads to run on the reserved pCPU  https://review.openstack.org/40087816:42
openstackgerritJay Pipes proposed openstack/nova: numa: take into account cpus overhead  https://review.openstack.org/40087616:42
openstackgerritJay Pipes proposed openstack/nova: numa: update numa usage incording the cpu overhead  https://review.openstack.org/40087716:42
*** kfarr has joined #openstack-nova16:46
mriedemgibi: are the o.vo changes needed for https://blueprints.launchpad.net/nova/+spec/json-schema-for-versioned-notifications basically all in and released?16:47
mriedemi see 2 nova changes for that bp but they look stalled16:47
mriedemand a single o.vo change outstanding16:47
mriedemalso, do we need to raise the minimum required o.vo in global-requirements for the changes that have been released?16:50
artommriedem, thanks for the -W, as you guessed, it's still WIP :)16:51
mriedemartom: :)16:51
artomThough I'll have to do BDM in the same patch, as it's the same microversion, no?16:51
mriedemi'm doing my post-xmas bp status check16:51
artomAt least the API stuff16:51
mriedemartom: for the rest api yes,16:52
mriedembut the internal plumbing can be separate16:52
artommriedem, right16:52
vdrokjaypipes sorry to bother, but could you respond in https://review.openstack.org/414214, or update if needed based on oomichi cooments? mriedem could you look at that too? ironic gate is half dead because of that :(16:53
vdrokand good morning :)16:54
mriedemvdrok: jaypipes: do we know why that's happening?16:55
vdrokmriedem: yeah, ironic reports 0s, lemme find that place16:55
mriedemyeah but why16:55
vdrokironic driver rather16:55
vdrokmriedem: https://review.openstack.org/41460316:56
vdrokmriedem: I think that in case of "fake" nodes, we don't have any properties like cpus/memory populated. also when the node is not in a usable state, like in maintenance, the same thing happens16:57
vdrokso that in case of maintenance, node's resources are not reported as used, but as absent, for example16:58
mriedemor if the power state on the node is ERROR i guess16:58
vdrokyup16:59
mriedemhmm, so, what if we previously reported inventory for a given ironic node in the nova resource tracker, but then the node goes into error state, or maintenance mode, should nova delete the inventory for that resource provider so the scheduler doesn't think it has inventory available and try to schedule to it?17:00
mriedemi can ask that in the review17:00
vdrokyup, thanks. just wanted to ask to keep an eye on that if possible :) as we have like 5-6 big patches blocked on the gate because of that17:02
vdrokand I'm not sure I know enough things about resource proivders to respond17:03
mriedemjaypipes: ok question in https://review.openstack.org/#/c/414214/ for you17:03
jaypipesmriedem: k17:03
*** slaweq has joined #openstack-nova17:04
jaypipesmriedem: soon as I'm done rebasing one of my patch series for the tenth time this week, I'll hop on that ;)17:05
*** ducttape_ has joined #openstack-nova17:06
*** ducttape_ has quit IRC17:11
artomHas anyone ever noticed now block device code is a plate of spaghetti? With squid-based sauce :D17:13
mriedemartom: mdbooth had a ML thread on that awhile back17:14
jaypipesmriedem: good points. I'll update and throw a fresh one up.17:14
artommriedem, heh, I should have added an /s or something :)17:15
mriedemartom: http://lists.openstack.org/pipermail/openstack-dev/2016-June/097529.html17:15
artomIt's clearly a known problem, but the solution would be to... what, scrap everything and do block_device_v3?17:15
mriedemto be fair, there are only like 4 or 5 different "BDMs" in nova17:15
mriedemdropping bdm v1 might be a decent start to eliminate some legacy cruft17:16
jaypipesmriedem: yeah, we should totally add another type of BDM.17:16
jaypipesmriedem: call it BDSM.17:16
mriedembut bdm v1 is in the REST API17:16
mriedemjaypipes: i see what you did there17:16
*** Raildo has joined #openstack-nova17:16
jaypipesmriedem: you like that, don't you. naughty boy.17:17
mriedemplease. more.17:17
artomWhat I'm trying to figure out right now is why the device name (which is used to match the db objects to the instance xml stuff) in libvirt is different when attaching a volume, which means the tag doesn't show up in the metadata17:17
artomIt goes up and down through so many layers just to come up with a device name...17:17
artomI'm sure there were valid historical reasons for this to be like that, but... damn17:18
jaypipeswhere is mdbooth when you need him, eh?17:18
jaypipesartom: don't be so sure :)17:18
mriedemartom: you know the libvirt driver ignores the user-supplied device name from the REST API right?17:18
mriedemnot sure if that's part of your issue or not17:18
mriedemartom: would a uuid on the bdm help at all?17:19
*** Raildo is now known as raildo17:19
artommriedem, maybe... but it happens even if the API doesn't supply a name17:19
artommriedem, not unless it's also in the instance xml17:19
* artom keeps adding logs everywhere and continues digging17:20
mriedemartom: are you talking about this part? https://github.com/openstack/nova/blob/d442488ebe19a6b3ddea6ec8668f92c7e2a0a644/nova/virt/libvirt/driver.py#L766017:20
artommriedem, nah, I'm talking about what happens at attach time17:21
mriedemsure, but are you saying that tagged_bdms here https://github.com/openstack/nova/blob/d442488ebe19a6b3ddea6ec8668f92c7e2a0a644/nova/virt/libvirt/driver.py#L767117:22
mriedemis missing the bdm created at attach because the name doesn't match?17:22
mriedemor is bdm.device_name just not even set on attach?17:22
artommriedem, https://github.com/openstack/nova/blob/d442488ebe19a6b3ddea6ec8668f92c7e2a0a644/nova/virt/libvirt/driver.py#L7697 fails to get a bdm17:22
mriedemhave you added logging of tagged_bdms to make sure you are seeing the one from the REST API call?17:23
artomLast time I logged it, it was 'hda' in the instance xml (the dev.target_dev variable) and 'vdb' in the DB object17:23
artomHrmm, I'd have to double-check because you're sowing doubt in my mind, but I'm pretty sure there was only one volume to speak of17:24
mriedemi assume you've been through reserve_block_device_name in the compute manager already?17:24
artommriedem, down that rabbit hole now17:25
mriedemyeah, which calls the libvirt driver's get_device_name_for_instance method17:25
artomYep17:25
*** baoli has joined #openstack-nova17:25
mriedemwhich sets block_device_obj.device_name = None because it has to else blockinfo.get_info_from_bdm doesn't work correctly, because tight coupling is all the rage17:26
openstackgerritJay Pipes proposed openstack/nova: Return uuid attribute for aggregates  https://review.openstack.org/41503117:26
artomI've ran out of wtfs to give :)17:26
artomI just want it to work17:26
mriedemi would add some logging to see what get_info_from_bdm is returning17:27
artommriedem, yeah, doing that now, I'll figure it out eventually17:27
mriedemhaving said that,17:27
mriedemi think mdbooth has pointed out that if you reboot or recreate the domain xml in any way, the devices might change within the guest and it would probably screw this all up anyway17:28
mriedem*changed17:28
artomWhen you say within the guest, you mean in the instance xml?17:28
mriedemi.e. if i attach 3 volumes, they are vdb, vdc and vdd, then reboot the guest, those might have changed and my tags are now out of whack17:28
mriedemyeah17:29
artomBecause device name is all we have to match the DB objects (which contain tags) to the instance XML info (which contain everything else)17:29
artomIf that match isn't stable, we can scrap block device tagging altogether17:29
mriedemok, well, danpb or mdbooth or dansmith could probably elaborate on this more, but i thought that basically bdm device name can't be trusted in the xml vs the bdm db17:30
*** baoli has quit IRC17:30
*** gouthamr has joined #openstack-nova17:32
artommriedem, there should be a way to retroactively adjust the DB to match the XML, I'd think... I'll push a WIP that passes the new Tempest test and ask for feedback17:33
artomThis device name thing is all that's left before I can do that17:33
mriedemartom: looking at http://logs.openstack.org/03/414603/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/1d0aeb9/logs/screen-n-cpu.txt.gz#_2016-12-23_15_49_19_00917:38
mriedemthere is a vda bdm in that xml17:38
mriedemand the serial is the volume uuid17:38
mriedemseems you could map things that way, as the bdm.volume_id field in the db is that serial id17:38
mriedemin the xml17:38
*** baoli has joined #openstack-nova17:39
artommriedem, that seems to be much smarter than the current way17:39
mriedemwell assuming serial is always set, but i'm not sure when it wouldn't be17:40
mriedembut then again, there could be wrinkles for that in the bowels of the block_device_info code so who knows17:40
mriedemi see _volume_snapshot_delete in the libvirt driver relying on it though17:41
mriedemartom: this is what sets that in the disk config xml https://github.com/openstack/nova/blob/d442488ebe19a6b3ddea6ec8668f92c7e2a0a644/nova/virt/libvirt/volume/volume.py#L5717:42
mriedemand this is what sets it in bdm.connection_info on attach https://github.com/openstack/nova/blob/d442488ebe19a6b3ddea6ec8668f92c7e2a0a644/nova/virt/block_device.py#L26017:43
mriedemso seems like a safe fallback17:43
*** ijw has joined #openstack-nova17:43
*** slaweq has quit IRC17:44
*** raildo has quit IRC17:47
artommriedem, thanks, I'll try that :)17:47
artomYou've saved me from my rabbit hole17:47
artommriedem, wait, where is the volume uuid in the block device DB object? In connection_info somewhere?17:50
artomGrah, you've said it yourself, volume_id17:51
artomWhich is a string and not a uuid, which makes me weary, but it's the best I've got17:51
*** hfu has quit IRC17:52
*** baoli has quit IRC17:55
*** baoli has joined #openstack-nova17:57
*** mdnadeem has joined #openstack-nova17:57
mriedemyeah bdm.volume_id is the volume uuid from cinder17:58
*** links has joined #openstack-nova17:59
mriedemartom: the tricky part might be when the bdm.volume_id is set in the database during attach18:00
mriedemalthough for attach volume you should be ok, i was thinking of something like this https://github.com/openstack/nova/blob/d442488ebe19a6b3ddea6ec8668f92c7e2a0a644/nova/virt/block_device.py#L38118:00
mriedemwhich is boot from volume, where nova creates the volume from blank/image/snapshot18:00
mriedemthe connection_info passed into driver.attach_volume also has that 'serial' entry though18:01
*** ijw has quit IRC18:06
*** ociuhandu has quit IRC18:08
jaypipesmriedem: https://review.openstack.org/#/q/topic:bp/flavor-notifications+status:open looks pretty good to go to me.18:14
mriedemyowser https://review.openstack.org/#/c/398171/18:16
mriedemok i'll add to my list18:16
*** ociuhandu has joined #openstack-nova18:20
*** adisky_ has quit IRC18:29
*** ociuhandu has quit IRC18:31
*** ociuhandu has joined #openstack-nova18:33
*** hfu has joined #openstack-nova18:33
*** david-lyle has joined #openstack-nova18:34
openstackgerritJay Pipes proposed openstack/nova: placement: RT now adds proper Ironic inventory  https://review.openstack.org/40447218:35
artommriedem, well crap - I just tried it, and the serial wasn't set in the xml18:36
artomSo it looks like serial isn't 100% either18:36
artomBut maybe it's easier to fix than device_name18:37
*** ducttape_ has joined #openstack-nova18:37
*** links has quit IRC18:38
mriedemartom: at what point is _build_device_metadata called during the attach_volume flow?18:41
*** ducttape_ has quit IRC18:42
*** Zer0Byte__ has joined #openstack-nova18:44
*** Zer0Byte__ has quit IRC18:44
*** dtp has quit IRC18:44
mriedemartom: because at this point https://github.com/openstack/nova/blob/d442488ebe19a6b3ddea6ec8668f92c7e2a0a644/nova/virt/libvirt/driver.py#L1197 that conf object should have serial set due to https://github.com/openstack/nova/blob/d442488ebe19a6b3ddea6ec8668f92c7e2a0a644/nova/virt/libvirt/volume/volume.py#L5718:44
*** mdnadeem has quit IRC18:49
*** pcaruana has quit IRC18:52
*** Zer0Byte__ has joined #openstack-nova18:54
*** kristian__ has quit IRC19:04
*** kristian__ has joined #openstack-nova19:04
artommriedem, at the end of attach_volume in the compute api19:09
artomAnd at this point, it's 20:00 here and I have a beer in me, so see you tomorrow!19:09
mriedemartom: ttyl19:10
*** david-lyle has quit IRC19:12
*** david-lyle has joined #openstack-nova19:17
mriedemjaypipes: -1 on that base flavor notifications patch https://review.openstack.org/#/c/398171/ - comments inline19:21
*** kristian__ has quit IRC19:22
*** kristian__ has joined #openstack-nova19:22
openstackgerritAkshil Verma proposed openstack/python-novaclient: Remove HTTP error code when creating flavor  https://review.openstack.org/41528919:23
jaypipesmriedem: having a hell of a time understanding how to add api_sample_tests for a specific microversion. Would you mind checking out http://logs.openstack.org/31/415031/2/check/gate-nova-tox-db-functional-ubuntu-xenial/6655fc4/testr_results.html.gz and giving some advice if you have some spare time today?19:24
*** david-lyle has quit IRC19:26
jaypipeshave I mentioned today how much I dislike the api_sample_tests?19:26
*** kristian__ has quit IRC19:27
mriedemjaypipes: for one thing, your api response sample for v2.41 doesn't have the uuid field in it https://review.openstack.org/#/c/415031/2/doc/api_samples/os-aggregates/v2.41/aggregate-post-resp.json19:28
jaypipesffs19:29
mriedemi'm leaving some other comments19:30
*** rfolco has quit IRC19:31
mriedemjaypipes: we're going to want a bp and spec for that api change, which i think we can make an exception for and fast track it,19:33
mriedembut we wouldn't normally allow a bug fix in to add a microversion to the rest api w/o a spec19:33
jaypipesmriedem: that was the only tpl file that was missing the uuid field.19:34
openstackgerritJay Pipes proposed openstack/nova: Return uuid attribute for aggregates  https://review.openstack.org/41503119:34
jaypipesmriedem: so that's definitely not the issue, since all 5 tests are failing.19:34
mriedembut aren't all 5 creating an aggregate first?19:34
mriedemso it fails on that19:34
jaypipeshmm.19:34
jaypipesok, well we'll see if that works :)19:35
mriedemyeah they all have to create an aggregate first, then do things to it like add a host, or list aggregates from that created one19:36
jaypipesmriedem: after a while, your mind just kind of numbs to the copy/pasted JSON files :(19:36
mriedemyeah i had issues with that when i was doing get me a network, oomichi had to point out my issues19:36
jaypipesthis is partly why I greatly prefer the Gabbi way of testing specific microversion changes. it's a whole lot more explicit and obvious what you're verifying.19:36
*** ijw has joined #openstack-nova19:41
mriedemjaypipes: i imagine this wasn't a problem because we don't have a functional test for update? https://review.openstack.org/#/c/415031/2/doc/api_samples/os-aggregates/v2.41/aggregate-update-post-resp.json19:44
mriedemweird you do have test_update_aggregate19:46
*** kristian__ has joined #openstack-nova19:51
mriedemjianghuaw: the xenserver ci fails hard on this https://review.openstack.org/#/c/406059/ - the virt driver can't even load the xenapi session object19:55
*** kristian__ has quit IRC19:56
*** dtp has joined #openstack-nova20:00
*** ducttape_ has joined #openstack-nova20:07
*** yamahata has joined #openstack-nova20:08
*** ducttape_ has quit IRC20:12
*** moshele has joined #openstack-nova20:13
*** ijw has quit IRC20:14
mriedemcfriesen: fixed http://docs.openstack.org/releasenotes/nova/newton.html#id320:17
*** kristian__ has joined #openstack-nova20:29
*** yamahata has quit IRC20:31
*** dave-mccowan has joined #openstack-nova20:37
*** kristia__ has joined #openstack-nova20:43
*** kristian__ has quit IRC20:43
mriedemjroll: how are microversions handled in ironicclient? at least when nova is using it. i.e. https://review.openstack.org/#/c/247904/15/ironicclient/v1/node.py isn't passing 1.27 but that's the microversion in the ironic rest api for that change:20:51
mriedemhttps://review.openstack.org/#/c/216730/33/doc/source/dev/webapi-version-history.rst20:51
*** slaweq has joined #openstack-nova21:00
*** hogepodge has quit IRC21:02
*** mrhillsman has quit IRC21:02
*** hogepodge has joined #openstack-nova21:03
*** codebauss has joined #openstack-nova21:04
*** codebauss is now known as mrhillsman21:04
*** hogepodge has quit IRC21:08
*** ijw has joined #openstack-nova21:10
*** code4coffee has joined #openstack-nova21:12
openstackgerritSujitha proposed openstack/nova: Change tags to default field in Instance object.  https://review.openstack.org/41529821:14
*** yamahata has joined #openstack-nova21:14
code4coffeehey guys, I am trying to get console working with virt_type=lxc, I am starting to doubt if it's at all possible based on my limited python experience. Could someone elaborate on the matter?21:15
mriedemcode4coffee: there are no console APIs supported for LXC, see http://docs.openstack.org/developer/nova/support-matrix.html21:24
*** sacharya has quit IRC21:26
code4coffeemriedem: thanks for the link, serial seems to be unknown which would be most interesting for me. I've been using proxmox previously which supports novnc html5 client with lxc containers, I'm wondering if there is any technical reason why it can not be implemented in nova21:33
*** ducttape_ has joined #openstack-nova21:38
*** ijw has quit IRC21:39
*** david-lyle has joined #openstack-nova21:42
mriedemcode4coffee: i'm not sure, and that support matrix may very well be out of date21:43
mriedemwe had an lxc CI job in the nova experimental queue, it might be worth finding out if that job ever ran any of the serial console tests21:43
*** ducttape_ has quit IRC21:44
*** david-lyle has quit IRC21:48
*** ijw has joined #openstack-nova21:48
*** moshele has quit IRC21:54
*** dave-mcc_ has joined #openstack-nova21:54
*** Zer0Byte__ is now known as jose-phillips21:55
*** dave-mccowan has quit IRC21:56
*** sacharya has joined #openstack-nova21:57
mriedemjaypipes: if a tag in the tags table is Unicode(80) https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L146422:00
mriedemjaypipes: does that means it's really == String(4*80)?22:00
*** ducttape_ has joined #openstack-nova22:07
code4coffeemriedem: as far as I understand it's not supported, because in libvirt driver _create_consoles method, any non kvm or qemu virt_type will result in pty console, and later console retrieval code only supports console with type of tcp. Which means it shouldn't work.22:11
*** avolkov has quit IRC22:18
*** avolkov has joined #openstack-nova22:18
*** jose-phi_ has joined #openstack-nova22:19
*** jose-phillips has quit IRC22:19
mriedemKevin_Zheng: https://review.openstack.org/#/c/394321/ needs to be rebased and I think it can be substantially smaller22:24
mriedemjaypipes: was asking because of this https://review.openstack.org/#/c/394321/17/nova/db/sqlalchemy/api_migrations/migrate_repo/versions/031_build_requests_add_tags.py@2722:25
*** slaweq has quit IRC22:25
*** jose-phillips has joined #openstack-nova22:28
*** jose-phi_ has quit IRC22:29
*** jose-phillips has quit IRC22:30
*** jose-phillips has joined #openstack-nova22:31
*** dimtruck is now known as zz_dimtruck22:35
*** kristia__ has quit IRC22:36
*** code4coffee has quit IRC22:39
*** sacharya has quit IRC22:41
*** slaweq has joined #openstack-nova22:42
*** sacharya has joined #openstack-nova22:44
*** david-lyle has joined #openstack-nova22:44
*** sacharya has quit IRC22:48
*** sacharya has joined #openstack-nova22:49
*** david-lyle has quit IRC22:49
openstackgerritSujitha proposed openstack/nova: Change tags to default field in Instance object.  https://review.openstack.org/41529822:53
*** sacharya has quit IRC22:53
*** vtech has joined #openstack-nova22:57
mriedemjaypipes: so your aggregates uuid functional api samples tests are failing because the microversion in the request is 2.1 rather than 2.41 for some reason22:58
*** dave-mcc_ has quit IRC22:58
openstackgerritSujitha proposed openstack/nova: Add more field's in InstancePayload  https://review.openstack.org/40712823:00
openstackgerritSujitha proposed openstack/nova: Adding tags field to InstancePayload  https://review.openstack.org/40722823:00
Kevin_Zhengmriedem: thanks for the review, will do it when I got to the office23:04
openstackgerritSujitha proposed openstack/nova: Change tags to default field in Instance object.  https://review.openstack.org/41529823:04
mriedemjaypipes: ok two things, first you need to set the microversion on the self.api object in the functional test23:05
mriedemhttps://github.com/openstack/nova/blob/d442488ebe19a6b3ddea6ec8668f92c7e2a0a644/nova/tests/functional/api_sample_tests/test_hypervisors.py#L14223:05
mriedemlike that ^23:05
mriedemthat's a bug imo that the base class doesn't handle that setup for you23:05
mriedemjaypipes: this is your other issue: https://github.com/openstack/nova/blob/d442488ebe19a6b3ddea6ec8668f92c7e2a0a644/nova/objects/aggregate.py#L26023:05
mriedemwhen constructing the Aggregate object, we don't load the uuid field23:06
mriedemwell, later on we set a uuid if there isn't one in the db https://github.com/openstack/nova/blob/d442488ebe19a6b3ddea6ec8668f92c7e2a0a644/nova/objects/aggregate.py#L28723:07
*** ducttape_ has quit IRC23:12
*** efried1 has joined #openstack-nova23:14
*** efried has quit IRC23:15
*** vtech has quit IRC23:21
*** amotoki has quit IRC23:28
*** hongbin has joined #openstack-nova23:29
*** amotoki has joined #openstack-nova23:35
*** takashin has joined #openstack-nova23:35
*** lamt has quit IRC23:36
*** kristian__ has joined #openstack-nova23:36
*** sacharya has joined #openstack-nova23:36
*** zul has quit IRC23:40
*** kristian__ has quit IRC23:41
*** dtp has quit IRC23:43
*** zul has joined #openstack-nova23:43
mriedemjaypipes: ok so i see what's up - each test creates a new aggregate, which automatically sets the uuid to a new random value, so the response has a random uuid each time. the api samples have a static uuid, so the compare fails. other api samples tests that use a uuid stub out the DB API calls to return a fake with hard-coded uuids that match what's in the api samples docs.23:44
*** hogepodge has joined #openstack-nova23:44
*** david-lyle has joined #openstack-nova23:45
*** ijw has quit IRC23:45
*** zhs_ has quit IRC23:45
*** zhs_ has joined #openstack-nova23:46
*** zz_dimtruck is now known as dimtruck23:46
*** slaweq has quit IRC23:47
*** ducttape_ has joined #openstack-nova23:49
*** david-lyle has quit IRC23:49
*** sacharya has quit IRC23:50
*** sacharya has joined #openstack-nova23:50
*** avolkov has quit IRC23:51
*** amotoki has quit IRC23:54
*** sacharya has quit IRC23:55
*** hogepodge has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!