Monday, 2017-01-16

*** takashin has joined #openstack-nova00:03
*** jistr has quit IRC00:03
*** jistr has joined #openstack-nova00:07
*** dave-mcc_ has joined #openstack-nova00:08
*** dave-mccowan has quit IRC00:10
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Fix parameters and response in os-quota-sets.inc  https://review.openstack.org/41646100:12
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Fix path parameters in os-hypervisors.inc  https://review.openstack.org/41691100:12
*** dave-mcc_ has quit IRC00:13
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Fix deprecated proxy API parameters  https://review.openstack.org/41688200:13
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Fix a parameter in os-availability-zone.inc  https://review.openstack.org/41723300:14
openstackgerritTakashi NATSUME proposed openstack/nova: Refactor a test method including 3 test cases  https://review.openstack.org/39473800:15
openstackgerritTakashi NATSUME proposed openstack/nova: Refactor a test method including 7 test cases  https://review.openstack.org/39543600:15
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Fix parameters in os-hosts.inc  https://review.openstack.org/41644400:15
openstackgerritTakashi NATSUME proposed openstack/nova: Avoid forcing translation on logging calls  https://review.openstack.org/41387600:15
openstackgerritTakashi NATSUME proposed openstack/nova-specs: Amend cold-migration-with-target-ocata spec  https://review.openstack.org/39719300:17
*** hfu has joined #openstack-nova00:24
*** salv-orl_ has quit IRC00:27
*** dave-mccowan has joined #openstack-nova00:40
*** thorst has joined #openstack-nova00:41
*** tuanluong has joined #openstack-nova00:42
*** mingyu has joined #openstack-nova00:45
*** thorst has quit IRC00:45
*** thorst has joined #openstack-nova00:46
*** thorst has quit IRC00:46
*** mingyu has quit IRC00:48
*** hoangcx has joined #openstack-nova00:50
*** dimtruck is now known as zz_dimtruck00:50
*** zz_dimtruck is now known as dimtruck00:50
*** dave-mccowan has quit IRC00:51
*** hfu has quit IRC00:56
*** Apoorva has joined #openstack-nova00:57
*** dimtruck is now known as zz_dimtruck01:00
*** phuongnh has joined #openstack-nova01:03
*** claudiub|2 has quit IRC01:05
openstackgerritMatt Riedemann proposed openstack/nova: Add some cellsv2 setup docs  https://review.openstack.org/42019801:10
*** liusheng has quit IRC01:10
*** gouthamr has joined #openstack-nova01:14
*** Apoorva has quit IRC01:17
*** liusheng has joined #openstack-nova01:18
*** tovin07 has joined #openstack-nova01:27
*** salv-orlando has joined #openstack-nova01:28
*** kevinz has joined #openstack-nova01:30
*** sacharya has joined #openstack-nova01:31
*** hfu has joined #openstack-nova01:31
*** salv-orlando has quit IRC01:35
*** voelzmo has joined #openstack-nova01:35
*** voelzmo has quit IRC01:40
*** gouthamr has quit IRC01:41
*** amotoki has joined #openstack-nova01:42
*** ijw has joined #openstack-nova01:43
*** ijw has quit IRC01:47
*** gcb has joined #openstack-nova01:54
*** liusheng has quit IRC01:54
openstackgerritAlex Szarka proposed openstack/nova: Transform instance-live_migration_abort notification  https://review.openstack.org/42045301:55
*** yuntongjin has joined #openstack-nova01:56
*** yonglihe has joined #openstack-nova01:57
*** mrda is now known as mrda-lca02:00
*** mrda-lca is now known as mrda02:00
*** armax has joined #openstack-nova02:01
*** armax has quit IRC02:01
*** tiendc has joined #openstack-nova02:06
*** mingyu has joined #openstack-nova02:11
*** nkrinner_afk has quit IRC02:12
*** nkrinner_afk has joined #openstack-nova02:12
*** liusheng has joined #openstack-nova02:12
*** mingyu_ has joined #openstack-nova02:14
openstackgerritTakashi NATSUME proposed openstack/nova: Enable cold migration with target host(1/2)  https://review.openstack.org/40895502:14
*** mingyu has quit IRC02:15
openstackgerritTakashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/2)  https://review.openstack.org/40896402:15
*** hongbin has joined #openstack-nova02:17
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Add parameters in cold migrate action  https://review.openstack.org/41004202:17
*** qianli has joined #openstack-nova02:17
openstackgerritTakashi NATSUME proposed openstack/nova: Add functional tests for cold migration to same host  https://review.openstack.org/41492602:17
openstackgerritTakashi NATSUME proposed openstack/python-novaclient: Microversion 2.42 - Enable cold migration with target host  https://review.openstack.org/40670702:18
*** qianli has quit IRC02:18
*** stevemar has quit IRC02:21
*** zz_dimtruck is now known as dimtruck02:21
*** stevemar has joined #openstack-nova02:21
*** baoli has joined #openstack-nova02:24
*** links has joined #openstack-nova02:25
*** hfu has quit IRC02:28
*** salv-orlando has joined #openstack-nova02:31
*** mingyu_ has quit IRC02:34
*** salv-orlando has quit IRC02:36
*** yuntongjin has quit IRC02:36
*** hfu has joined #openstack-nova02:36
*** links has quit IRC02:38
*** hfu has quit IRC02:38
*** mingyu has joined #openstack-nova02:39
*** yuntongjin has joined #openstack-nova02:45
*** links has joined #openstack-nova02:46
*** thorst has joined #openstack-nova02:47
*** yuntongjin has quit IRC02:49
*** thorst has quit IRC02:52
openstackgerritJay Pipes proposed openstack/nova: placement: adds REST API for nested providers  https://review.openstack.org/38480702:53
openstackgerritJay Pipes proposed openstack/nova: placement: allow filter providers in tree  https://review.openstack.org/37721502:53
openstackgerritJay Pipes proposed openstack/nova: pci: add uuid field to PciDevice object  https://review.openstack.org/41476802:53
openstackgerritJay Pipes proposed openstack/nova: placement: integrate ProviderTree to report client  https://review.openstack.org/41592102:53
openstackgerritJay Pipes proposed openstack/nova: placement: SRIOV PF devices as child providers  https://review.openstack.org/41476902:53
openstackgerritJay Pipes proposed openstack/nova: placement: adds ProviderTree for nested resources  https://review.openstack.org/41592002:53
openstackgerritJay Pipes proposed openstack/nova: placement: update client to set parent provider  https://review.openstack.org/38569302:53
openstackgerritJay Pipes proposed openstack/nova: placement: add nested resource providers  https://review.openstack.org/37713802:53
*** dave-mccowan has joined #openstack-nova03:02
*** moshele has joined #openstack-nova03:03
*** dave-mccowan has quit IRC03:06
*** mingyu has quit IRC03:06
*** tlian has quit IRC03:13
*** thorst has joined #openstack-nova03:14
*** thorst has quit IRC03:14
*** mriedem has quit IRC03:15
*** yuntongjin has joined #openstack-nova03:16
*** Jeffrey4l_ has quit IRC03:21
*** Jeffrey4l has joined #openstack-nova03:21
*** yuntongjin has quit IRC03:31
*** pbandark has joined #openstack-nova03:32
*** dave-mccowan has joined #openstack-nova03:32
*** salv-orlando has joined #openstack-nova03:32
*** voelzmo has joined #openstack-nova03:36
*** salv-orlando has quit IRC03:36
*** voelzmo has quit IRC03:41
*** dave-mccowan has quit IRC03:45
openstackgerritTristan Cacqueray proposed openstack/nova: Mask the token used to allow access to consoles  https://review.openstack.org/22062203:47
*** sudipto_ has joined #openstack-nova03:50
*** sudipto has joined #openstack-nova03:50
*** ijw has joined #openstack-nova03:53
openstackgerritTuan Luong-Anh proposed openstack/os-vif: H803 hacking have been deprecated  https://review.openstack.org/42048903:56
*** psachin has joined #openstack-nova04:01
*** bswartz has quit IRC04:03
*** mdnadeem has joined #openstack-nova04:05
*** hongbin has quit IRC04:07
*** hongbin has joined #openstack-nova04:07
openstackgerritZhenyu Zheng proposed openstack/nova: Strict pattern match query parameters  https://review.openstack.org/42049404:10
*** moshele has quit IRC04:10
*** hongbin has quit IRC04:13
*** yuntongjin has joined #openstack-nova04:15
openstackgerritTuan Luong-Anh proposed openstack/os-vif: H803 hacking have been deprecated  https://review.openstack.org/42048904:17
*** ijw has quit IRC04:22
*** gouthamr has joined #openstack-nova04:24
*** diga has joined #openstack-nova04:30
*** bswartz has joined #openstack-nova04:31
*** bswartz has quit IRC04:32
*** salv-orlando has joined #openstack-nova04:33
*** udesale has joined #openstack-nova04:33
*** hfu has joined #openstack-nova04:35
*** bswartz has joined #openstack-nova04:36
*** baoli has quit IRC04:36
*** salv-orlando has quit IRC04:38
*** bswartz has quit IRC04:44
*** dimtruck is now known as zz_dimtruck04:49
*** ayogi has joined #openstack-nova04:50
*** moshele has joined #openstack-nova04:53
*** ratailor has joined #openstack-nova04:53
*** bswartz has joined #openstack-nova04:54
*** Sukhdev has joined #openstack-nova04:59
*** sudipto_ has quit IRC05:01
*** sudipto has quit IRC05:01
*** amotoki_ has joined #openstack-nova05:09
*** unicell has joined #openstack-nova05:11
*** amotoki has quit IRC05:12
*** thorst has joined #openstack-nova05:15
*** thorst has quit IRC05:20
*** tiendc_ has joined #openstack-nova05:27
*** prateek has joined #openstack-nova05:28
*** tiendc has quit IRC05:28
*** Apoorva has joined #openstack-nova05:29
*** ecelik has joined #openstack-nova05:30
*** ecelik has left #openstack-nova05:30
*** sgordon has quit IRC05:31
*** salv-orlando has joined #openstack-nova05:34
*** sudipto has joined #openstack-nova05:36
*** sudipto_ has joined #openstack-nova05:36
*** Apoorva has quit IRC05:37
*** sacharya has quit IRC05:38
*** salv-orlando has quit IRC05:38
*** sacharya has joined #openstack-nova05:39
*** sree has joined #openstack-nova05:39
*** sgordon has joined #openstack-nova05:39
openstackgerritTristan Cacqueray proposed openstack/nova: Mask the token used to allow access to consoles  https://review.openstack.org/22062205:45
*** fandi has joined #openstack-nova05:49
*** Sukhdev has quit IRC05:50
openstackgerritjichenjc proposed openstack/nova: Fix broken link of Doc  https://review.openstack.org/42050405:51
*** huanxie has joined #openstack-nova05:54
*** sridharg has joined #openstack-nova05:55
*** ljxiash has joined #openstack-nova06:02
*** Dinesh_Bhor has joined #openstack-nova06:05
*** bkopilov_ has joined #openstack-nova06:14
*** claudiub has joined #openstack-nova06:17
openstackgerritZhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants  https://review.openstack.org/41533006:18
*** unicell has quit IRC06:22
*** satyar has joined #openstack-nova06:23
satyarHi jeffrey4l06:25
Jeffrey4lhi satyar. ( nova channel ;) )06:26
satyaropps lets go to our challel :P06:26
satyarchannel06:26
*** voelzmo has joined #openstack-nova06:27
openstackgerritYoshihiko Atsumi proposed openstack/nova: Add resize server functional negative tests  https://review.openstack.org/42051406:28
*** moshele has quit IRC06:30
*** ekuris has joined #openstack-nova06:30
openstackgerritjichenjc proposed openstack/nova: Fix broken link of Doc  https://review.openstack.org/42050406:32
*** voelzmo has quit IRC06:32
*** ijw has joined #openstack-nova06:34
*** salv-orlando has joined #openstack-nova06:35
*** ijw has quit IRC06:39
*** salv-orlando has quit IRC06:39
*** lpetrut has joined #openstack-nova06:42
*** karthiks has joined #openstack-nova06:47
*** tyrola has quit IRC06:47
*** BobBall has quit IRC06:48
*** tyrola has joined #openstack-nova06:49
*** greghaynes has quit IRC06:52
*** mnaser has quit IRC06:53
*** afazekas has quit IRC06:53
*** mordred has quit IRC06:53
*** afazekas has joined #openstack-nova06:57
*** greghaynes has joined #openstack-nova06:58
*** mordred has joined #openstack-nova07:02
*** afazekas has quit IRC07:02
*** greghaynes has quit IRC07:04
openstackgerritChangBo Guo(gcb) proposed openstack/nova: Enable virt.test_virt_drivers.AbstractDriverTestCase on Python 3  https://review.openstack.org/41441907:12
openstackgerritChangBo Guo(gcb) proposed openstack/nova: Enable more virt.xenapi tests on Python 3  https://review.openstack.org/41442107:12
openstackgerritChangBo Guo(gcb) proposed openstack/nova: Enable virt.vmwareapi test cases on Python  https://review.openstack.org/41442007:12
*** Oku_OS-away is now known as Oku_OS07:12
*** afazekas has joined #openstack-nova07:13
*** mnaser has joined #openstack-nova07:14
*** moshele has joined #openstack-nova07:14
*** greghaynes has joined #openstack-nova07:15
*** thorst has joined #openstack-nova07:16
openstackgerrithuangtianhua proposed openstack/python-novaclient: Make _console() public  https://review.openstack.org/41436407:17
*** voelzmo has joined #openstack-nova07:21
*** thorst has quit IRC07:21
*** tesseract has joined #openstack-nova07:21
*** hogepodge_ has joined #openstack-nova07:24
*** nkrinner_afk is now known as nkrinner07:24
*** mnestratov|2 has joined #openstack-nova07:26
*** mdnadeem has quit IRC07:27
*** xinliang has joined #openstack-nova07:31
openstackgerritZhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants  https://review.openstack.org/41533007:31
*** gouthamr has quit IRC07:32
*** markus_z has joined #openstack-nova07:32
*** pcaruana has joined #openstack-nova07:34
*** fandi has quit IRC07:35
*** salv-orlando has joined #openstack-nova07:36
*** yuntongjin has quit IRC07:36
*** hogepodge_ has quit IRC07:37
*** marst has quit IRC07:40
*** marst has joined #openstack-nova07:40
*** salv-orlando has quit IRC07:40
*** andreas_s has joined #openstack-nova07:42
*** mdnadeem has joined #openstack-nova07:42
*** ralonsoh has joined #openstack-nova07:43
*** gcb has quit IRC07:44
*** gcb has joined #openstack-nova07:46
*** abalutoiu has quit IRC07:46
*** migi has joined #openstack-nova07:46
*** roeyc has joined #openstack-nova07:51
*** amotoki has joined #openstack-nova08:07
openstackgerritRoman Dobosz proposed openstack/nova-specs: Provide detailed error information for placement API  https://review.openstack.org/41839308:10
*** amotoki_ has quit IRC08:11
*** mjura has joined #openstack-nova08:12
snikitinalex_xu: Hi, Alex! I updated diagnostics patch to fix problem with upgrade. https://review.openstack.org/#/c/355540/ Can you look, please?08:16
*** jpena|off is now known as jpena08:21
*** ijw has joined #openstack-nova08:22
*** roeyc has quit IRC08:26
*** ijw has quit IRC08:27
*** trananhkma has joined #openstack-nova08:30
trananhkmahi nova core reviewers08:31
trananhkmaI have 2 patches which have +2 from Stephen Finucane in last week08:32
*** slaweq__ has joined #openstack-nova08:32
trananhkmawould you mind helping me review these patches: https://review.openstack.org/#/c/322003/ https://review.openstack.org/#/c/321326/08:32
*** obre has joined #openstack-nova08:33
*** Matias has quit IRC08:33
*** jpena is now known as jpena|off08:34
*** adisky_ has joined #openstack-nova08:35
*** salv-orlando has joined #openstack-nova08:37
*** amoralej|off is now known as amoralej08:37
*** Matias has joined #openstack-nova08:40
*** salv-orlando has quit IRC08:41
*** jpena|off is now known as jpena08:42
openstackgerritAndrey Volkov proposed openstack/nova: Add nova-manage cell_v2 create_cell command  https://review.openstack.org/33271308:43
openstackgerritBalazs Gibizer proposed openstack/nova: handle uninited fields in notification payload  https://review.openstack.org/41585708:47
*** mingyu has joined #openstack-nova08:48
openstackgerritwanghao proposed openstack/nova: Set min_disk in the image meta based on the root volume's size  https://review.openstack.org/40739708:52
openstackgerritAndrey Volkov proposed openstack/nova: Add nova-manage cell_v2 create_cell command  https://review.openstack.org/33271308:55
openstackgerritDao Cong Tien proposed openstack/nova: Stop using mox in virt/xenapi/image/test_glance.py  https://review.openstack.org/32745708:57
*** zzzeek has quit IRC09:00
*** zzzeek has joined #openstack-nova09:00
*** houming has joined #openstack-nova09:09
openstackgerritYoshihiko Atsumi proposed openstack/nova: Add resize server functional negative tests  https://review.openstack.org/42051409:11
bauzasp!spy09:12
*** ayogi has quit IRC09:13
openstackgerritZhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants  https://review.openstack.org/41533009:13
*** thorst has joined #openstack-nova09:17
*** thorst has quit IRC09:22
*** roeyc has joined #openstack-nova09:29
*** yassine has joined #openstack-nova09:32
*** yassine is now known as Guest701109:32
*** rha has joined #openstack-nova09:33
*** rha has quit IRC09:33
*** rha has joined #openstack-nova09:33
*** salv-orlando has joined #openstack-nova09:37
*** derekh has joined #openstack-nova09:40
*** sgordon has quit IRC09:41
*** salv-orlando has quit IRC09:42
openstackgerritDao Cong Tien proposed openstack/nova: Stop using mox in compute/test_hypervisors.py  https://review.openstack.org/32681409:43
*** mvk has quit IRC09:47
*** lucas-afk is now known as lucasagomes09:47
*** GnomeKing has joined #openstack-nova09:48
*** GnomeKing is now known as BobBall09:49
*** sgordon has joined #openstack-nova09:49
openstackgerritClaudiu Belu proposed openstack/nova: WIP: Hyper-V PCI Passthrough  https://review.openstack.org/42061409:54
*** sree has quit IRC09:55
*** sree has joined #openstack-nova09:56
*** roeyc has quit IRC09:59
*** sree has quit IRC10:00
*** roeyc has joined #openstack-nova10:01
*** amotoki has quit IRC10:01
*** mnestratov|2 has quit IRC10:02
*** hachi has joined #openstack-nova10:04
*** owalsh has joined #openstack-nova10:04
*** kevinz has quit IRC10:06
openstackgerritBéla Vancsics proposed openstack/nova: Reduced the complexity of the _init_instance method (3)  https://review.openstack.org/42061910:06
*** tuanluong has quit IRC10:07
*** yonglihe has quit IRC10:07
*** amotoki has joined #openstack-nova10:08
*** hfu has quit IRC10:08
*** phuongnh has quit IRC10:10
*** sree has joined #openstack-nova10:10
*** roeyc has quit IRC10:14
*** hoangcx has quit IRC10:14
*** sree has quit IRC10:14
openstackgerritLee Yarwood proposed openstack/nova: libvirt: workaround findmnt behaviour change  https://review.openstack.org/42014610:18
*** mvk has joined #openstack-nova10:20
openstackgerritLee Yarwood proposed openstack/nova: libvirt: workaround findmnt behaviour change  https://review.openstack.org/42014610:22
lyarwoodmdbooth: ^ that's the hackaround for the findmnt change we spoke about on Friday btw10:23
mdboothlyarwood: Did you report a bug against util-linux, btw?10:23
*** amotoki has quit IRC10:24
lyarwoodmdbooth: someone already had - https://bugzilla.redhat.com/show_bug.cgi?id=140523810:24
openstackbugzilla.redhat.com bug 1405238 in util-linux "findmnt --target behaviour changed in 7.3, shows all mount-points in chroot" [Unspecified,Post] - Assigned to kzak10:24
mdboothlyarwood: Reading. Might add REGRESSION to the bz title if it's not getting attention.10:25
lyarwoodmdbooth: seems to be POST'd for 7.4, I'll ask for 7.3.z now10:25
*** udesale has quit IRC10:28
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Fix keypair API parameters  https://review.openstack.org/42062610:28
mdboothlyarwood: Brilliant, thanks.10:31
* mdbooth reads the workaround.10:31
openstackgerritSpencer Yu proposed openstack/nova: Transform instance.live_migration_rollback_dest notification  https://review.openstack.org/42062910:34
*** satyar has quit IRC10:36
*** Guest7011 has quit IRC10:37
*** salv-orlando has joined #openstack-nova10:38
takashinbauzas: alex_xu: Are you around? Could you review https://review.openstack.org/#/c/408955/ again and check my comments?10:39
openstackgerritBéla Vancsics proposed openstack/nova: Reduced the complexity of the _init_instance method (4)  https://review.openstack.org/42063210:39
*** alineb has quit IRC10:40
*** salv-orlando has quit IRC10:43
*** voelzmo has quit IRC10:43
mdboothlyarwood: Reviewed. Would you like me to add the requested test case and resubmit? It'll only take a couple of minutes.10:44
mdboothAlso the os.stat() question.10:45
lyarwoodmdbooth: yup sure10:45
mdboothOk, will do.10:45
*** Guest7011 has joined #openstack-nova10:45
*** mingyu has quit IRC10:47
openstackgerritzhangyujun proposed openstack/nova: Query parameter validation for hosts API  https://review.openstack.org/41888010:48
lyarwoodmdbooth: thanks btw, I've answered the os.stat question in the review, https://github.com/openstack/nova/blob/ad1c7ac2b102112280a25927d731edb168f80998/nova/virt/libvirt/volume/quobyte.py#L120 is the reason.10:50
*** rmart04 has joined #openstack-nova10:50
openstackgerritChangBo Guo(gcb) proposed openstack/nova: Set access_policy for messaging's dispatcher  https://review.openstack.org/40849410:51
lyarwoodhmmmmm this might not work actually10:51
lyarwoodmdbooth: what do you make of L115 from the link above?10:53
*** moshele has quit IRC10:53
lyarwoodmdbooth: I don't think that was even valid with findmnt10:53
mdboothlyarwood: I was just reading it more carefully myself.10:53
mdboothSurely it previously returned false?10:53
mdboothI don't think it's mocked in the test.10:53
*** moshele has joined #openstack-nova10:54
*** cdent has joined #openstack-nova10:55
mdboothlyarwood: That depends how quobyte volumes are known to mount10:56
lyarwoodmdbooth: I think mounted was False previously in this test so os.stat was nnenver called10:56
mdboothlyarwood: Right. I suspect it was false because it wasn't mocked, and therefore was never going to work in a test environment10:56
mdboothI think this test needs it to be false, though.10:57
mdboothThat test is bizarre10:57
mdboothStill trying to wrap my head round what it's doing10:58
mdboothIt's raising an exception if validate_volume() is called with any arguments?10:59
mdboothWhy?10:59
lyarwoodvalidate_volume is calling command = ['getfattr', "-n", "quobyte.info", mnt_base]    so I guess it's just mocking a failure of that11:00
lyarwoodso it doesn't really matter what we do in connect_volume as long as the volume is mounted in the end11:00
lyarwoodurgh11:00
mdboothIt's a terrible test11:00
mdboothI wouldn't rathole on it. I'd change the is_mounted mock to return False, because that's the previous behaviour, and remove the os.stat mock.11:00
mdboothFixing it isn't what you're doing here.11:01
lyarwoodyeah true11:01
mdboothWould you like me to make that change, too?11:01
lyarwoodif you have everything open already11:01
mdboothYeah.11:01
lyarwoodcool thanks11:01
*** lpetrut has quit IRC11:03
*** rfolco has joined #openstack-nova11:05
openstackgerritTakashi NATSUME proposed openstack/nova-specs: Fix formatting errors and warnings  https://review.openstack.org/40736411:06
*** ljxiash has quit IRC11:09
*** sahid has joined #openstack-nova11:09
*** ljxiash has joined #openstack-nova11:10
*** JoseMello has joined #openstack-nova11:13
*** ljxiash has quit IRC11:14
*** erlon_pto has joined #openstack-nova11:15
*** sudipto has quit IRC11:17
*** sudipto_ has quit IRC11:17
mdboothlyarwood: Trying trying to work out what that quobyte test did before in case we're missing something.11:18
*** thorst has joined #openstack-nova11:18
mdboothI wonder if it wasn't doing what the author thought it was doing.11:18
openstackgerritChris Dent proposed openstack/nova: [placement] add api-ref for GET /resource_providers  https://review.openstack.org/41850311:19
lyarwoodmdbooth: meh, it might be an older test that tested something useful in the past that's just been left in tbh11:19
lyarwoodmdbooth: asserting that we raise the exception that's thrown by the final call in the method is just odd11:20
*** tiendc_ has quit IRC11:20
lyarwoodmdbooth: what else could we possibly do?11:20
mdboothYeah, I wonder if the exception was raise by something else11:20
mdboothChecking now, shouldn't take too long11:20
lyarwoodkk11:20
lyarwoodthanks again11:20
*** thorst has quit IRC11:23
mdboothlyarwood: The previous code returned True, and didn't handle the os.stat() error in the test11:25
mdboothIt returned true because of fake_execute11:25
lyarwoodahhhh11:26
*** lpetrut has joined #openstack-nova11:26
mdboothThe os.stat() error is handled by the surrounding code11:26
mdboothYup, the os.stat() mock can just be removed11:27
mdboothIt remains a terrible test11:27
mdboothlyarwood: You never did add anything to openstack-dev-hacks, btw11:30
*** lpetrut has quit IRC11:30
*** ekuris has quit IRC11:31
lyarwoodmdbooth: yeah sorry keep meaning to11:31
lyarwoodmdbooth: I'll try to get around to it this morning11:31
mdboothDon't both spending time cleaning it up, btw, just chuck it in there11:31
mdboothWe can cleanup later if required11:31
lyarwoodyeah I wanted to remove the grep foo | grep bar crap etc ;)11:32
mdboothMeh, just drop it in there ;)11:32
openstackgerritMatthew Booth proposed openstack/nova: libvirt: workaround findmnt behaviour change  https://review.openstack.org/42014611:32
*** sree has joined #openstack-nova11:34
*** amotoki has joined #openstack-nova11:37
*** salv-orlando has joined #openstack-nova11:39
*** alineb- has joined #openstack-nova11:41
*** voelzmo has joined #openstack-nova11:41
*** alineb- is now known as alineb11:42
*** salv-orlando has quit IRC11:43
*** ekuris has joined #openstack-nova11:45
lyarwoodmdbooth: pushed, also dumped my current crop of git aliases in there, not sure it's that useful so feel free to rm11:46
*** ratailor has quit IRC11:46
markus_zWould someone please review a tempest test for l-m: https://review.openstack.org/#/c/346815/22 ?11:47
*** roeyc has joined #openstack-nova11:49
markus_ztonyb: Would you have a look at the newton backports for bug 1455252 please? https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/newton+topic:%22bug+1455252%2211:51
openstackbug 1455252 in OpenStack Compute (nova) "enabling serial console breaks live migration" [High,Fix released] https://launchpad.net/bugs/1455252 - Assigned to Markus Zoeller (markus_z) (mzoeller)11:51
lyarwoodmarkus_z: I can take a look this afternoon11:52
markus_zlyarwood: Thanks, that would be awesome.11:52
*** voelzmo has quit IRC11:55
*** voelzmo has joined #openstack-nova11:56
mdboothlyarwood: Thanks!11:57
*** bkopilov_ has quit IRC11:57
*** bkopilov_ has joined #openstack-nova11:58
sahidjohnthetubaguy: hello11:59
sahidi remember that you were kind of interested about the feature emulator threads11:59
*** lpetrut has joined #openstack-nova11:59
sahidand unfortunatly even if the code has been pushed 2 months ago I did not had a lot of reviews11:59
sahidwould you be interested on helping jay pipes to review it ?12:00
*** jbernard has quit IRC12:05
*** ljxiash has joined #openstack-nova12:05
*** rtheis has joined #openstack-nova12:07
*** jbernard has joined #openstack-nova12:11
*** dikonoor has joined #openstack-nova12:13
openstackgerritChris Dent proposed openstack/nova: Add rudimentary CORS support to placement API  https://review.openstack.org/39289112:13
*** ociuhandu has quit IRC12:15
*** smatzek has joined #openstack-nova12:17
*** ociuhandu has joined #openstack-nova12:19
*** bvanhav_ has joined #openstack-nova12:19
*** kevinz has joined #openstack-nova12:20
*** kevinz has quit IRC12:21
*** ekuris has quit IRC12:21
*** sdague has joined #openstack-nova12:22
*** krtaylor has quit IRC12:29
*** sudipto has joined #openstack-nova12:31
*** sudipto_ has joined #openstack-nova12:31
*** dikonoor has quit IRC12:34
*** ekuris has joined #openstack-nova12:34
*** dikonoor has joined #openstack-nova12:34
*** sahid has quit IRC12:34
*** nicolasbock has joined #openstack-nova12:34
*** sudipto_ has quit IRC12:37
*** sudipto has quit IRC12:37
*** khushbu_ has joined #openstack-nova12:37
*** sudipto has joined #openstack-nova12:40
*** salv-orlando has joined #openstack-nova12:40
*** sudipto_ has joined #openstack-nova12:41
*** sahid has joined #openstack-nova12:41
*** takashin has left #openstack-nova12:42
*** jpena is now known as jpena|lunch12:44
*** salv-orlando has quit IRC12:44
*** thorst has joined #openstack-nova12:45
*** gszasz has joined #openstack-nova12:45
*** lucasagomes is now known as lucas-hungry12:45
*** salv-orlando has joined #openstack-nova12:46
*** sahid has quit IRC12:48
*** sahid has joined #openstack-nova12:49
*** houming has quit IRC12:49
*** sahid has quit IRC12:50
*** sahid has joined #openstack-nova12:51
lyarwoodsfinucan: would you mind taking a look at https://review.openstack.org/#/c/420146/ if you have a chance this afternoon12:57
*** sree has quit IRC12:57
*** sree has joined #openstack-nova12:58
*** gcb has quit IRC13:01
*** sree has quit IRC13:03
*** moshele has quit IRC13:03
*** moshele has joined #openstack-nova13:04
*** tblakes has joined #openstack-nova13:05
*** beagles_afk is now known as beagles13:08
*** weshay_mod is now known as weshay13:10
*** Cristina_ is now known as CristinaPauna13:12
*** Guest7011 has quit IRC13:13
*** khushbu_ has quit IRC13:16
*** jaypipes has joined #openstack-nova13:19
*** Guest7011 has joined #openstack-nova13:20
*** amoralej is now known as amoralej|lunch13:21
*** coreywright has quit IRC13:21
openstackgerritMikhail Feoktistov proposed openstack/nova: libvirt: ephemeral disk support for virtuozzo containers  https://review.openstack.org/31248813:21
openstackgerritMikhail Feoktistov proposed openstack/nova: libvirt: ephemeral disk support for virtuozzo containers  https://review.openstack.org/31248813:25
dimssdague : bauzas : Got some time for a review that enable *all* functional tests in py35 (except 1) https://review.openstack.org/#/c/419968/ ? please let me know13:26
*** coreywright has joined #openstack-nova13:26
dimscdent : the lone hold out is the snowman/gabbi test (unicode_get_a_raw_snowman_unicode.test_request) fails as the snowman char is not ascii, so never reaches the server side13:27
*** liverpooler has joined #openstack-nova13:28
dikonooralex_xu: sdague: Hi..I have some queries around quotas..who would be the right person to contact ?13:29
*** mnestratov has joined #openstack-nova13:29
*** krtaylor has joined #openstack-nova13:30
*** sahid_ has joined #openstack-nova13:30
cdentdims: odd. i wonder which part of the stack is messing with that, because python3 tests in gabbi itself are pretty okay with that sort of thing, can you link me to a failing trace?13:30
*** mdrabe has joined #openstack-nova13:31
*** mdrabe has quit IRC13:31
dimsone sec, digging up13:31
*** sahid has quit IRC13:32
dimscdent : http://logs.openstack.org/68/419968/9/check/gate-nova-tox-db-functional-py35-ubuntu-xenial/dd20ee5/testr_results.html.gz13:32
cdentthanks13:32
sdaguedims: lgtm, maybe once this is all done some of those conditional utf8 encode functions could get an oslo safe_encode wrapper or the like13:33
sdaguejust to get the if PY2 flags out of the code13:33
*** erlon_pto is now known as erlon13:33
cdentdims: that's bizarre, I need to compare with a similar test in gabbi itself13:33
dimscdent : ++13:34
*** mingyu has joined #openstack-nova13:34
*** psachin has quit IRC13:34
*** moshele has quit IRC13:39
cdentdims: actually that test is bogus on python3 and the error is essentially saying "yo, you've made a bad url"13:40
cdentgabbi is not responsible for url encoding and while python2 is okay with that badly formed url, python3 is not13:40
*** claudiub|2 has joined #openstack-nova13:40
cdentdims: so I would say: okay to remove that one test as it is bogus13:41
*** vladikr has joined #openstack-nova13:42
*** claudiub has quit IRC13:43
*** xyang1 has joined #openstack-nova13:44
*** baoli has joined #openstack-nova13:45
*** salv-orlando has quit IRC13:46
*** mdnadeem has quit IRC13:46
*** mdrabe has joined #openstack-nova13:47
dimscdent : ++13:47
*** moshele has joined #openstack-nova13:48
*** mingyu has quit IRC13:51
*** sacharya has quit IRC13:52
openstackgerritsahid proposed openstack/nova: numa: add numa constraints for emulator threads policy  https://review.openstack.org/38502313:55
openstackgerritsahid proposed openstack/nova: libvirt: return a CPU overhead if isolate emulator threads requested  https://review.openstack.org/38536413:55
openstackgerritsahid proposed openstack/nova: objects: add new field cpus_reserved in NUMACell  https://review.openstack.org/40087413:55
openstackgerritsahid proposed openstack/nova: numa: fit instance topology with cpus reserved onto cores  https://review.openstack.org/40087513:55
openstackgerritsahid proposed openstack/nova: virt: update overhead to take into account vCPUs  https://review.openstack.org/38502413:55
openstackgerritsahid proposed openstack/nova: libvirt: make emulator threads to run on the reserved pCPU  https://review.openstack.org/40087813:55
openstackgerritsahid proposed openstack/nova: numa: take into account cpus reserved  https://review.openstack.org/40087613:55
openstackgerritsahid proposed openstack/nova: numa: update numa usage incording the cpu reserved  https://review.openstack.org/40087713:55
*** lucas-hungry is now known as lucasagomes13:55
lyarwoodsdague: Morning, https://review.openstack.org/#/c/374373/ is +W but I'm still working on the Nova change it depends on, rechecking this isn't going to cause any issues correct?13:55
*** tlian has joined #openstack-nova13:55
openstackgerritVladyslav Drok proposed openstack/nova: Generate necessary network metadata for ironic port groups  https://review.openstack.org/38875613:57
*** bvanhav__ has joined #openstack-nova13:58
*** bvanhav__ is now known as bvanhav13:58
*** bvanhav_ has quit IRC13:59
*** baoli has quit IRC13:59
*** jpena|lunch is now known as jpena13:59
sahid_jaypipes: hello, btw i have addressed your comments here https://review.openstack.org/#/c/400875/18, not sure if you noticed that13:59
digajaypipes: Hi13:59
digaHi13:59
*** diga has quit IRC13:59
jaypipessahid_: no, I hadn't noticed (was in CA all last week and spent yesterday getting my own patch series rebased) :)14:00
*** jwcroppe_ has quit IRC14:00
*** diga has joined #openstack-nova14:00
jaypipessahid_: will review yours later today after scheduler meeting.14:00
jaypipesdiga: heya14:00
digajaypipes: Hi14:00
sahid_jaypipes: i see no problem, thanks a lot14:01
digajaypipes: ohh, meeting is started I guess14:01
sdaguelyarwood: correct14:04
*** baoli has joined #openstack-nova14:09
lyarwoodsdague: thanks, just wanted to check14:10
*** prateek has quit IRC14:11
*** jwcroppe has joined #openstack-nova14:13
*** paw has quit IRC14:13
*** dave-mccowan has joined #openstack-nova14:14
*** esberglu has joined #openstack-nova14:14
*** jheroux has joined #openstack-nova14:17
*** pradk has joined #openstack-nova14:18
*** mkoderer has joined #openstack-nova14:20
hachiHello14:26
hachiCan you please confirm whether the following nova blueprint works with Nova API 2.1:14:26
hachihttps://blueprints.launchpad.net/nova/+spec/user-id-based-policy-enforcement14:26
hachi?14:27
*** hongbin has joined #openstack-nova14:27
*** Guest7011 has quit IRC14:28
dimsjaypipes : can you please peek at this? https://review.openstack.org/#/c/419968/ (enables all the functional tests for py3, has +2 from sdague)14:29
*** links has quit IRC14:30
dimsjaypipes : welcome back :)14:30
jaypipesdims: thx :)14:30
jaypipesdims: reviewing shortly. just wrapping up scheduler meeting.14:31
dimsack thanks14:31
*** owalsh has quit IRC14:32
*** mingyu has joined #openstack-nova14:36
*** mriedem has joined #openstack-nova14:38
mriedemo/14:39
*** ekuris has quit IRC14:40
*** Guest7011 has joined #openstack-nova14:42
*** salv-orlando has joined #openstack-nova14:47
*** baoli has quit IRC14:47
*** pbandark has quit IRC14:47
*** baoli has joined #openstack-nova14:47
*** gcb has joined #openstack-nova14:50
*** salv-orlando has quit IRC14:51
*** pbandark has joined #openstack-nova14:51
*** mingyu has quit IRC14:51
*** dikonoor has quit IRC14:51
*** owalsh has joined #openstack-nova14:52
*** mingyu has joined #openstack-nova14:53
*** pbandark has quit IRC14:54
*** ekuris has joined #openstack-nova14:55
*** paw has joined #openstack-nova14:57
*** beagles is now known as beagles_brb14:57
*** mtanino has joined #openstack-nova15:01
jaypipesdims: done15:05
dimsthanks jaypipes !15:05
jaypipesany time! :)15:05
*** hongbin has quit IRC15:08
*** roeyc has quit IRC15:11
jaypipescdent: k, I have read your email about can_host.15:11
*** markus_z has quit IRC15:11
jaypipescdent: you want me to respond or should we discuss in hangout?15:11
jaypipescdent: or both? :)15:11
cdentboth would be awesome15:11
jaypipesk.15:11
cdentbecause in the hangout it will just be whoever is there15:11
cdentalthough, if your answer is sufficiently informative in writing I'm not sure we need the hangout. that was mriedem's idea15:12
bauzascdent: jaypipes: just a question, should we need to wait for edleafe since he's on PTO ?15:12
mriedemwe're not going to wait no15:12
mriedemjay and i are both out next week15:13
cdentmriedem: can you (re-)share the hangout link15:14
bauzasokay15:14
*** zz_dimtruck is now known as dimtruck15:14
bauzasI'm fine with that, just asking15:14
mriedemalaski: happy birthday :)15:14
mriedemMLK steals your thunder15:15
mriedemcdent: https://hangouts.google.com/hangouts/_/calendar/bWF0dHJpZWQyMkBnbWFpbC5jb20.uve66g1e93k1ooj42jr29g1bug?authuser=015:15
cdentthanks15:15
jaypipesbauzas: no rest for the weary I'm afraid.15:16
*** edmondsw has joined #openstack-nova15:20
*** jaosorior has joined #openstack-nova15:25
*** satyar has joined #openstack-nova15:25
*** beekneemech is now known as bnemec15:26
*** edmondsw has quit IRC15:30
*** cdent_ has joined #openstack-nova15:31
*** cdent has quit IRC15:31
*** marst has quit IRC15:31
*** cdent_ is now known as cdent15:31
*** yellow has joined #openstack-nova15:32
openstackgerritsahid proposed openstack/nova: libvirt: make coherent logs when reboot success  https://review.openstack.org/41699415:32
openstackgerritsahid proposed openstack/nova: libvirt: rework _destroy method  https://review.openstack.org/41699515:32
openstackgerritsahid proposed openstack/nova: libvirt: rework hard reboot  https://review.openstack.org/37635015:32
*** ijw has joined #openstack-nova15:34
*** nkrinner is now known as nkrinner_afk15:35
yellowping #openstack-nova: Looking for the best way to clean a nova db. I see alot of error messages where the domain UUID is not found ..15:35
ildikovmriedem: johnthetubaguy: hi. just a quick check, will you be able to make it to the Cinder-Nova meeting today?15:35
mriedemprobably15:36
yellowOn mitaka I see the addition of nova-manage db command but its not useful for my situation since the UUID is not null15:36
ildikovmriedem: cool, tnx15:36
*** cdent has quit IRC15:36
*** cdent_ has joined #openstack-nova15:37
*** amoralej|lunch is now known as amoralej15:37
*** ijw has quit IRC15:39
*** beagles_brb is now known as beagles15:41
*** cdent_ has quit IRC15:42
*** marst has joined #openstack-nova15:43
*** ekuris has quit IRC15:45
*** gouthamr has joined #openstack-nova15:48
*** salv-orlando has joined #openstack-nova15:48
*** hongbin has joined #openstack-nova15:49
*** dave-mccowan has quit IRC15:50
*** cdent has joined #openstack-nova15:50
*** mvk has quit IRC15:50
*** rtheis has quit IRC15:51
*** ducttape_ has joined #openstack-nova15:52
*** lpetrut has quit IRC15:52
*** salv-orlando has quit IRC15:52
mriedemjaypipes: this is what i was talking about https://github.com/openstack/nova/blob/7e0edc67108b3b9d23549a6d3c0d3106dfc2acec/nova/objects/resource_provider.py#L563 - but as noted on the call, it's not in allowed_filters (or the schema now)15:52
jaypipesmriedem: ah. well, yeah, it could never have been added via the API or exposed to it.15:53
mriedemjaypipes: you said you need to rebase this? https://review.openstack.org/#/c/407309/15:54
jaypipesmriedem: yeah.15:54
openstackgerritPawel Koniszewski proposed openstack/nova: live-mig: Add claims and proper resource tracking  https://review.openstack.org/24448915:55
openstackgerritPawel Koniszewski proposed openstack/nova: libvirt: pass libvirt reference methods to migration  https://review.openstack.org/32899715:55
openstackgerritPawel Koniszewski proposed openstack/nova: libvirt: live-migrate updates NUMA and cpus in the XML  https://review.openstack.org/28674415:55
*** ducttape_ has quit IRC15:55
*** ratailor has joined #openstack-nova15:56
*** abalutoiu has joined #openstack-nova15:56
*** amotoki has quit IRC15:57
*** eharney has joined #openstack-nova15:58
bauzasjaypipes: refrain your pencil, I'm litterally rebasing now15:58
bauzasjaypipes: that will still make Jenkins unhappy, but at least you'd get a fresh copy15:59
cdentI'm going to emboss "refrain your pencil" somewhere. Has a very nice ring to it.15:59
*** cdent has quit IRC16:00
openstackgerritSylvain Bauza proposed openstack/nova: Add ComputeNode.get_by_uuid method  https://review.openstack.org/41813416:04
openstackgerritSylvain Bauza proposed openstack/nova: WIP: Scheduler calling the Placement API  https://review.openstack.org/41796116:04
bauzasjaypipes: mriedem: there it is16:04
*** eharney has quit IRC16:05
*** dave-mccowan has joined #openstack-nova16:05
*** Oku_OS is now known as Oku_OS-away16:06
mriedembauzas: ok issue in the bottom change16:06
bauzassnap snap16:06
bauzasmriedem: roger, this.16:07
bauzasmriedem: on it16:07
*** dave-mcc_ has joined #openstack-nova16:08
*** cdent has joined #openstack-nova16:08
mriedemdo we have a migration that added a uuid to every existing compute_nodes record?16:08
*** moshele has quit IRC16:08
mriedemcdent: in honor of you calling out my haggard looks i've brewed another cup of coffee16:08
cdentI am your enabler?16:09
mriedemyes16:09
cdentIs that a paid position?16:09
mriedemnow when i get the caffeine shakes i know who to blame16:10
openstackgerritAndrey Volkov proposed openstack/nova: Add nova-manage cell_v2 create_cell command  https://review.openstack.org/33271316:10
*** dave-mccowan has quit IRC16:10
openstackgerritVasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt  https://review.openstack.org/36441316:11
openstackgerritVasyl Saienko proposed openstack/nova: Generate necessary network metadata for ironic port groups  https://review.openstack.org/38875616:11
mriedemah migration 33016:11
mriedemcool16:11
* cdent gets air16:12
bauzasmriedem: oh oops, sorry missed your question16:12
bauzasmriedem: yeah, it was done AFAIK16:12
*** burgerk has joined #openstack-nova16:12
*** rama_y has joined #openstack-nova16:13
openstackgerritAndrey Volkov proposed openstack/nova: Add nova-manage cell_v2 create_cell command  https://review.openstack.org/33271316:13
*** voelzmo has quit IRC16:13
melwittmriedem: I had thought the map_cell0 name/connection was intentionally based on the api db because they're expected to be co-located together16:15
*** voelzmo has joined #openstack-nova16:15
*** jose-phillips has joined #openstack-nova16:16
*** jose-phillips has quit IRC16:16
*** mingyu has quit IRC16:17
*** eharney has joined #openstack-nova16:18
openstackgerritSylvain Bauza proposed openstack/nova: Add ComputeNode.get_by_uuid method  https://review.openstack.org/41813416:19
openstackgerritSylvain Bauza proposed openstack/nova: WIP: Scheduler calling the Placement API  https://review.openstack.org/41796116:19
gibimriedem: hi! I managed finish the notification lazy load field bugfix. I didn't manage to split it up nicely. If you have time could you please check it? https://review.openstack.org/#/c/415857/16:20
*** bvanhav has quit IRC16:22
*** mingyu has joined #openstack-nova16:23
*** bvanhav has joined #openstack-nova16:23
openstackgerritMikhail Feoktistov proposed openstack/nova: libvirt: ephemeral disk support for virtuozzo containers  https://review.openstack.org/31248816:23
*** kfarr has joined #openstack-nova16:23
*** Apoorva has joined #openstack-nova16:24
*** armax has joined #openstack-nova16:26
*** mingyu has quit IRC16:27
*** mingyu has joined #openstack-nova16:27
openstackgerritVasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt  https://review.openstack.org/36441316:28
openstackgerritVasyl Saienko proposed openstack/nova: Generate necessary network metadata for ironic port groups  https://review.openstack.org/38875616:28
*** ratailor has quit IRC16:29
mriedemmelwitt: i'm not sure, we'd probably have to ask alaski if he remembers a specific reason for calling it nova_api_cell0 even though it's using the main db schema16:29
*** salv-orlando has joined #openstack-nova16:30
melwittthat was my understanding anyway16:31
openstackgerritVasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt  https://review.openstack.org/36441316:31
openstackgerritVasyl Saienko proposed openstack/nova: Generate necessary network metadata for ironic port groups  https://review.openstack.org/38875616:31
*** kiran-r has joined #openstack-nova16:32
*** slaweq_ has joined #openstack-nova16:33
*** ducttape_ has joined #openstack-nova16:34
mriedemmelwitt: still, co-locating the nova_api db and cell0 doesn't mean we should name it nova_api_cell0 right? unless it just meant something like, cell0 is only used at the api/controller level16:36
mriedemidk16:36
mriedemit's probably confusing either way16:36
*** slaweq_ has quit IRC16:37
mriedemwe should probably figure out what we want though before all of dansmith's changes for it go in16:37
*** slaweq_ has joined #openstack-nova16:37
*** mlavalle has joined #openstack-nova16:38
melwittmriedem: yeah, I could see the name being confusing. I'm trying to think if there's any caveat to making it default to the main db connection. I thought the idea was it's an api cell construct, so default to the connection of the other api cell db16:39
mriedemmelwitt: you want to comment on https://review.openstack.org/#/c/420439/ ?16:41
mriedemit's held up by dependencies right now16:41
melwittokay16:41
mriedemit would be nice if we didn't have to make the change because it's also in devstack and grenade, and potentially backports16:41
*** gcb has quit IRC16:42
mriedembut this comment in the code was wrong: "The cell0 database will use the same database scheme and netloc as the API database"16:42
mriedemwhich leads me to believe it was just a mistake from the beginning16:42
*** sahid has joined #openstack-nova16:44
*** sahid has quit IRC16:44
*** Apoorva has quit IRC16:44
*** sahid has joined #openstack-nova16:44
*** sahid_ has quit IRC16:45
*** andreas_s has quit IRC16:45
*** kfarr has quit IRC16:49
*** sridharg has quit IRC16:50
melwittmriedem: I was thinking about that and I think it meant scheme as in, url format. not database schema16:51
*** jose-phillips has joined #openstack-nova16:52
melwittI left a comment on the review, fwiw16:52
mriedemoh maybe16:52
*** voelzmo has quit IRC16:52
mdboothhttp://eventlet.net/doc/modules/greenthread.html#eventlet.greenthread.spawn16:53
mdboothIs there any way to deterministically get a GreenThread object before it starts running?16:53
*** jose-phi_ has joined #openstack-nova16:53
mdboothI want to do:16:54
mdboothx = GreenThread()16:54
mdbooth...register thread somewhere...16:54
mdboothx.run()16:54
*** jose-phillips has quit IRC16:54
mriedemmnaser: i'm assumed at your '99% of this volume multiattach stuff is done on the cinder side' comment in the ops list :)16:55
mnasermriedem hi16:55
mnaseryeah, i think cinder side has multiattachments already setup16:55
mnaserAPIs have all that stuff already wired up16:55
*** MarcF has joined #openstack-nova16:56
mnaseri think the part that never merged was the nova side that made the appropriate api calls and interacted with it16:56
*** MarcF has quit IRC16:56
mriedemmnaser: yes i'm fully aware of the history16:56
mriedembut it's not that simple16:56
mnasermriedem: of course it's not :) it's probably why it never got finished up, i'm very understanding of that16:56
*** weshay is now known as weshay_lunch16:56
mnasersorry if that came off as "nova team, finish your job" .. i understand there's complexities involved but i meant it more of "half of the battle is done"16:57
*** amotoki has joined #openstack-nova16:57
mriedemyeah i know, i've already replied to that thread with details16:57
mnasermriedem: awesome, thank you so much for following up and being always on top of things :)16:58
*** ducttape_ has quit IRC16:58
openstackgerritGábor Antal proposed openstack/nova: Transform instance.reboot notifications  https://review.openstack.org/38295917:00
*** rmart04_ has joined #openstack-nova17:00
*** hshiina has joined #openstack-nova17:00
*** markmcclain has quit IRC17:02
*** rmart04_ has quit IRC17:02
*** rmart04 has quit IRC17:02
*** kiran-r has quit IRC17:04
*** armax has quit IRC17:05
*** dave-mcc_ has quit IRC17:06
*** dave-johnston has joined #openstack-nova17:09
*** sahid has quit IRC17:10
*** sahid has joined #openstack-nova17:12
*** mingyu has quit IRC17:12
mriedemsdague: some fun 'what do you want in pike' big items in the operators list, which are cross-project fodder for the TC probably at the ptg/boston summit17:14
mriedemavolkov: i'm going to rebase my list and delete cells patches on top of your create_cell patch17:16
mriedemjust to avoid all of the eventual conflicts17:16
sdaguemriedem: ok, I'll take a look. I've been a little heads down today recoding the devstack ini / local.conf manipulation in python as the complexity of merging local.conf files in grenade exceeds the bash code we have17:16
sdagueand that's the hold up for d-g support of local.conf17:16
mriedemyeah i saw that in qa17:16
dansmithmriedem: so, it would be super awesome if we could merge the bottom three patches in my set today before I go, or at least get some real review on them17:16
dansmiththat would be here and down: https://review.openstack.org/#/c/410473/1017:16
mriedemyeah it's just the next 2 then17:16
mriedemdansmith: did you see the convo i was having with melwitt about about the cell0 naming thing?17:17
*** Apoorva has joined #openstack-nova17:17
dansmithmriedem: no, was on calls sorry17:17
mriedemshe also commented on the change, sec17:17
mriedemhttps://review.openstack.org/#/c/420439/5/nova/cmd/manage.py17:17
mriedemif she's right then we should sort that out before the grenade/devstack/series merges17:18
mriedemplus possible newton backports17:18
*** markmcclain has joined #openstack-nova17:19
dansmithif she's right about wht?17:19
*** mingyu has joined #openstack-nova17:19
dansmithI was just replying17:20
mriedemwell about the connection url and naming17:20
openstackgerritGábor Antal proposed openstack/nova: Transform instance.reboot notifications  https://review.openstack.org/38295917:20
dansmithI'm sure the intent was because the cell0 db may often be co-located, but it's far too confusing, IMHO17:20
openstackgerritMatt Riedemann proposed openstack/nova: Add InstanceMappingList.get_by_cell_id  https://review.openstack.org/42045017:21
openstackgerritMatt Riedemann proposed openstack/nova: Add nova-manage cell_v2 create_cell command  https://review.openstack.org/33271317:21
openstackgerritMatt Riedemann proposed openstack/nova: Add nova-manage cell_v2 delete_cell command  https://review.openstack.org/42045117:21
openstackgerritMatt Riedemann proposed openstack/nova: Create HostMappingList object  https://review.openstack.org/42044917:21
openstackgerritMatt Riedemann proposed openstack/nova: Add nova-manage cell_v2 list_cells command  https://review.openstack.org/42044017:21
melwittwhat's confusing about it? that is, did something specific happen to incite this change?17:22
mriedemwhile reviewing the docs patch,17:23
mriedemi pointed out that if --database_connection is not provided to map_cell0 the connection url comes from the CONF.api_database.connection, not CONF.database.connection as dan had originally written in the docs patch17:23
*** burgerk has quit IRC17:23
dansmithit's confusing because we're taking a url and database name that points to an api schema thing, mangling it, and putting main schema in it, and calling it something with "api" in the name17:23
mriedemwhich took us down this path17:23
*** acabot has quit IRC17:24
*** jose-phi_ has quit IRC17:24
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/42084417:24
*** sahid has quit IRC17:24
melwittokay. yeah, I can agree the name could be confusing, but I thought the connection, which is like host/user/password makes sense to be the same as the api db as a default. no?17:25
*** mdnadeem has joined #openstack-nova17:25
dansmithI don't see why it makes sense for those to be the same?17:25
melwittthat's what we wanted to encourage, that these are the two api dbs17:25
melwittand it makes sense to put them on the same hosts17:26
mriedemmaybe we should have just made the connection arg required17:26
mriedemso we didn't have to guess17:26
dansmithcell0 will grow indefinitely and need to be purged, api db will not.. that means different planning for those types of things17:26
dansmithmriedem: that's fine too17:26
melwittdansmith: hm, okay. I hadn't thought of that17:27
*** sudipto has quit IRC17:27
*** sudipto_ has quit IRC17:27
openstackgerritOpenStack Proposal Bot proposed openstack/python-novaclient: Updated from global requirements  https://review.openstack.org/42086117:28
*** tesseract has quit IRC17:29
*** hshiina has quit IRC17:30
*** jose-phillips has joined #openstack-nova17:30
*** johnsom has quit IRC17:30
*** johnsom has joined #openstack-nova17:30
*** moshele has joined #openstack-nova17:35
*** jose-phillips has quit IRC17:35
*** jose-phillips has joined #openstack-nova17:37
*** mingyu has quit IRC17:37
*** diga has quit IRC17:39
*** jose-phi_ has joined #openstack-nova17:40
*** armax has joined #openstack-nova17:42
*** jose-phillips has quit IRC17:43
*** lucasagomes is now known as lucas-afk17:43
openstackgerritDan Peschman proposed openstack/nova: nova-manage cell_v2 map_cell0 exit 0  https://review.openstack.org/42013217:44
openstackgerritGábor Antal proposed openstack/nova: Transform instance.reboot notifications  https://review.openstack.org/38295917:45
*** armax has quit IRC17:47
mriedemdansmith: melwitt: so i don't have super strong feelings either way, would be nice if alaski were around to break any ties17:47
mriedemi lean toward the name change trumping the chance of the cell0 and nova_api db connection creds being the same17:48
*** derekh has quit IRC17:48
mriedemi've already started working on backporting the fixes to stable/newton in case we want those17:48
mriedemi tend to think that with most deployments not even at newton yet those would be good to have fixed by the time they upgrade17:49
dansmithI think that we're leaning towards people not doing the simple thing, and thus not just arbitrarily using the same url/creds for everything, so I want us to be more sane17:49
*** roeyc has joined #openstack-nova17:49
mriedemyeah which making the db connection arg required would fix that, but i'm not sure i want to backport that change17:49
dansmithyeah17:50
mriedemwe could make db connection required in ocata, not backport anything, but put out a release note in newton saying you should be explicit when using map_cell017:50
melwittyeah, I don't think we should do that being that we know people don't want to be forced to pass connection strings on the command line17:50
*** CristinaPauna has quit IRC17:51
mriedemmelwitt: sure, but then we're also forcing them to handle it in config, i guess they can pass the --config-file option to nova-manage too17:52
melwittif there's reason to have api db and cell0 db not be co-located (which has been mentioned today) then that addresses my concern about it. I had been thinking co-locating them would be most common, but if it wouldn't be, then I think it's fine not to default it that way17:52
mriedemand by handle it in config, i mean if they want cell0 to use the same host/user/password as the nova_api db and not the main db17:52
melwittmriedem: yes, --config-file is key to setting up cells v1 anyway17:52
dansmithif they don't want to use the command line, then they need to have two separate places to define it anyway17:52
dansmithin the config I mean17:52
openstackgerritGábor Antal proposed openstack/nova: Added instance.reboot.error to the legacy notifications  https://review.openstack.org/41181617:53
dansmiththe re-use of the config elements to avoid using command line args is super confusing and annoying to me17:53
mdboothI have a test which uses threading (it's a concurrency test, this is unavoidable)17:53
openstackgerritGábor Antal proposed openstack/nova: Transform instance.reboot.error notification  https://review.openstack.org/41179117:53
dansmithit would be better, IMHO, if we had a yaml format for creds or something that we just had people create for each insertion they want to use,17:54
mdboothI'm explicitly using threading.Thread rather than eventlet.greenthread, because the latter doesn't do what I need17:54
dansmithinstead of "create a fake config, put just this section/keys in there, then we'll use that to create a db row instead of reading that config at runtime like it was intended"...17:54
mdboothI create a thread and start it, but when the thread does threading.current_thread() it gets the main thread17:54
mdboothIs this some evilness related to eventlet?17:55
melwittdansmith: yeah, I guess cell0 is a special case. for all the other things, it makes sense to say "base this cell upon my old cells v1 cell conf". cell0 might probably be a whole new host/user/pass17:55
mdbooththreading.current_thread() has the expected behaviour for me when not run in the test harness17:56
dansmithmelwitt: well, that case applies to like four operators.. the other billion will be creating fake configs when they want to configure or spin up new cells17:56
melwittdansmith: only if they don't want to pass on command line, yeah17:57
dansmithmelwitt: well, right, that's what I'm railing against :)17:57
mdbooth(Pdb) threading.current_thread.__module__17:57
mdbooth'eventlet.green.threading'17:57
mdbootheventlet: j'accuse!17:57
*** ducttape_ has joined #openstack-nova17:59
*** ljxiash has quit IRC17:59
melwittdansmith: yeah, it would be good to have a real way of doing that18:00
*** ljxiash has joined #openstack-nova18:00
* mdbooth constructs a hideous workaround18:00
*** CristinaPauna has joined #openstack-nova18:01
*** ralonsoh has quit IRC18:01
jaypipesgah, nested resource providers needs yet another rebase :)18:02
*** esberglu has quit IRC18:02
*** clenimar has joined #openstack-nova18:02
mriedemmelwitt: dansmith: sounds like a clouds.yaml kind of thing, but a bit different18:02
mriedemnova-db.yaml :)18:02
dansmithmriedem: yeah, like that18:02
*** esberglu has joined #openstack-nova18:03
*** slaweq_ has quit IRC18:03
*** mjura has quit IRC18:03
ildikovmriedem: I'm guessing if the version negotiation with the client can get sorted out then we can do the testing in the placement_api job as you seuggested earlier, right?18:03
*** ducttape_ has quit IRC18:03
mriedemildikov: yes, however, still need to solve the problem of how to configure nova to use cinder v3, which i think right now is going to be the job passing local.conf to d-g/devstack, and sdague is working on making that work18:04
mriedempost-config or whatever it's called18:04
ildikovyep, I remember that one too18:04
ildikovI think we can sync back on it the client part in Cinder is sorted out18:05
mriedemi can make scottda's patch work right now18:05
*** swamireddy has quit IRC18:05
ildikovmriedem: I won't say don't do it :)18:05
*** mvk has joined #openstack-nova18:06
*** esberglu has quit IRC18:07
*** owalsh has quit IRC18:08
*** jdurgin1 has quit IRC18:09
openstackgerritLee Yarwood proposed openstack/nova: libvirt: Use the mirror element to detect job completion  https://review.openstack.org/39973518:09
mriedemildikov: scottda: done ^18:12
*** bvanhav_ has joined #openstack-nova18:12
mriedemoops premature18:12
openstackgerritMatt Riedemann proposed openstack/nova: WIP Support cinder v3 API  https://review.openstack.org/42020118:12
mriedemthere18:12
*** bvanhav has quit IRC18:12
openstackgerritGábor Antal proposed openstack/nova: Transform instance.reboot.error notification  https://review.openstack.org/41179118:12
ildikovmriedem: thanks!!!18:13
* mriedem gets lunch18:14
openstackgerritMatt Riedemann proposed openstack/nova: WIP Support cinder v3 API  https://review.openstack.org/42020118:14
*** gszasz has quit IRC18:14
*** mdnadeem has quit IRC18:16
*** swamireddy has joined #openstack-nova18:17
*** weshay_lunch is now known as weshay18:19
*** jpena is now known as jpena|off18:20
openstackgerritLee Yarwood proposed openstack/nova: libvirt: Reconnect volumes and encryptors during a hard reboot  https://review.openstack.org/40038418:20
mriedemdansmith: so i'm kicking around ideas of how to make the multinode job run multiple cells,18:24
mriedemi think at least part of that is calling map_cell_and_hosts from the subnode18:25
dansmithmriedem: multiple cellsv2 cells you mean?18:25
mriedemyeah18:25
mriedemso host 1 is control + n-cpu,18:25
mriedemhost 2 (subnode) is just n-cpu18:25
mriedembut both hosts are going to be a cell18:25
*** esberglu has joined #openstack-nova18:26
mriedemor a combo of create_cell and discover_hosts18:26
mriedemon the subnode18:26
*** esberglu has quit IRC18:27
*** esberglu has joined #openstack-nova18:27
dansmithdoesn't have to be on the subnode specifically,18:27
dansmithbut yeah, create_cell will make it more explicit I think18:27
mriedemso currently we just create the dbs on the api node https://github.com/openstack-dev/devstack/blob/master/lib/nova#L68318:29
mriedemwhich is fine18:29
melwittI was thinkin once we have create_cell, we'd remove map_cell_and_hosts since that's really just create_cell + discover_hosts. to make things not overlap and be simpler18:29
dansmithyep18:30
mriedemthen we do the mappings later in https://github.com/openstack-dev/devstack/blob/master/lib/nova#L94818:30
mriedemwhich is called later here https://github.com/openstack-dev/devstack/blob/master/stack.sh#L136818:30
mriedemso we only do that stuff if on the api node18:30
mriedemso i think i can put an else in there for when n-api isn't running (subnode)18:31
*** satyar has quit IRC18:31
mriedemand n-cpu is enabled,18:31
mriedembut would probably want the subnode cell db on the api node, i'm not sure if it matters for CI?18:31
mriedemgiven we're hitting OOM errors in the gate right now,18:31
mriedemthe cell db on the subnode is probably better18:32
dansmithdoesn't need to actually be a different place18:32
mriedemyeah i know,18:32
mriedembut devstack isn't topology aware,18:32
mriedemand i'm not entirely sure how all of the subnode stuff gets setup by devstack-gate18:32
mriedemso i'm not sure that when setting up the api node, we know about the subnode yet18:32
mriedembut i guess maybe that doesn't matter?18:33
mriedemwe just have a db somewhere, and when we create the cell for the subnode we point that cell at that db connection18:33
dansmithwell,18:34
dansmiththe thing I ran into earlier trying to do something else was that the subnode didn't have all the stuff it needed to do certain things18:35
dansmithlike, not all the config18:35
dansmithdon't recall what exactly, but I couldn't start n-api on the subnode18:35
*** salv-orlando has quit IRC18:35
dansmithmight've been keystone and catalog related actually18:35
*** amoralej is now known as amoralej|off18:36
*** salv-orlando has joined #openstack-nova18:36
mriedemthis is what we have on the subnode http://logs.openstack.org/75/396775/39/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/f82fd9f/logs/subnode-2/etc/nova/nova.conf.txt.gz18:36
*** owalsh has joined #openstack-nova18:38
mriedemsomehow the subnode is getting the variables for the db host18:40
mriedemah d-18:41
mriedem*d-g my old friend18:41
*** dave-mccowan has joined #openstack-nova18:43
*** lpetrut has joined #openstack-nova18:44
mriedemalright time to hacky hacky18:44
jaosoriorgibi: you around?18:50
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/42084418:50
*** sacharya has joined #openstack-nova18:54
openstackgerritJay Pipes proposed openstack/nova: placement: RT now adds proper Ironic inventory  https://review.openstack.org/40447218:59
openstackgerritJay Pipes proposed openstack/nova: rt: use a single ResourceTracker object instance  https://review.openstack.org/39847318:59
jaypipesmriedem: ^^19:00
mriedemque bueno19:00
cdentgood timing jaypipes my to do list just rolled around to those19:01
jaypipescoolio.19:01
mriedemjaypipes: were you going to also update _setup_pci_tracker to pass the compute_node object in ther?19:01
mriedem*there19:01
jaypipesmriedem: ah, shitbuckets.19:01
jaypipesone sec.19:01
mriedemotherwise it looks super hot19:02
mriedemlike, omg19:02
*** voelzmo has joined #openstack-nova19:02
*** ijw has joined #openstack-nova19:05
*** ijw has quit IRC19:05
*** ijw has joined #openstack-nova19:05
*** moshele has quit IRC19:06
*** voelzmo has quit IRC19:06
mriedemmelwitt: good point on https://review.openstack.org/#/c/332713/14/nova/cmd/manage.py@143219:08
mriedemi obviously didn't think about that19:08
mriedemheh i even said that in PS9:19:09
mriedem"I think I'd like to see us first check to see if a cell mapping exists  with the given name (or combination of  name/transport_url/database_connection) and if we already have a match,  we just exit without doing anything (not a failure)."19:09
melwittmriedem: yeah, I've been admittedly confused about whether we return 0 for a no-op or not among all these commands. it seems like it hasn't been consistent19:10
melwittlike simple_cell_setup returns non-zero if it didn't create a cell mapping, but map_cell_and_hosts returns 0 in the same case I think19:11
mriedemyeah bauzas has a patch up to fix that actually19:11
mriedemanother thing with this create_cell command is you can't create 2 cells with different names but the same db/mq urls19:11
mriedemi'm not sure if we care about that right now, and it could be built in later if we did19:12
mriedemseems we should have had a unique constraint on the name/db/transport combo in the schema19:12
*** ijw_ has joined #openstack-nova19:12
melwittyeah, I thought about that and figured we shouldn't probably allow that case anyway (different name, same urls)19:12
dansmithwe should allow duplicate urls of each type at the very least19:13
dansmithnot sure it makes sense to allow complete dupes though, other than for testing19:14
*** ducttape_ has joined #openstack-nova19:15
mriedemdansmith: yeah the check in create_cell right now is db AND mq urls matching an existing cell19:15
mriedemthat's a failure19:15
mriedemwhich i had earlier said i thought should just be a noop (don't create a new cell), but guess i forgot that i asked for that before +2ing19:15
*** ijw has quit IRC19:15
openstackgerritJim Rollenhagen proposed openstack/nova: Move to tooz hash ring implementation  https://review.openstack.org/39902219:16
jaypipesmriedem: just re-running tests locally. should be pushed within 15minutes.19:16
mriedemok push it real good please19:16
dansmithmriedem: well, as melwitt said, returning zero for "I didn't do anything, but it's there like you asked" will be good for some people and bad for others that think they can test for existence by trying to re-create and check for error19:17
dansmithmriedem: so my opinion is that we not make a "create this thing" operation idempotent and instead do what you asked19:18
mriedemright, and since i'm frankly tired of trying to predict how all of this is going to be used, i'm going to give up19:18
*** voelzmo has joined #openstack-nova19:18
*** voelzmo has quit IRC19:19
*** ducttape_ has quit IRC19:19
*** oomichi_ has joined #openstack-nova19:20
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/42084419:20
mriedemdansmith: don't forget about this guy https://review.openstack.org/#/c/420440/19:21
dansmithmriedem: jenkins says that is shit19:21
mriedemit said that about the next in the series too which you +2ed19:22
dansmithI hand-checked that one19:22
* dansmith is bullshitting19:23
mriedemi know19:23
mriedemmy detector has been honed over years of bullshit19:23
*** ducttape_ has joined #openstack-nova19:25
*** ijw has joined #openstack-nova19:27
*** ducttape_ has quit IRC19:30
*** ijw__ has joined #openstack-nova19:30
*** ijw_ has quit IRC19:30
oomichi_mriedem: why not "nova-manage cell_v2 list" ?   The other resources' commands are just "list" without resource name in sub commands19:33
*** ijw has quit IRC19:34
mriedemoomichi_: because we could have things like list_host_mappings or something, idk19:34
mriedemoomichi_: and that's what we named it like for create_cell19:35
dansmithI commented to that effect19:35
oomichi_mriedem: ah, I see "create_cell". I got it.19:36
oomichi_dansmith: Thanks, I see. it is nice to keep current one for consistent command line19:36
openstackgerritJay Pipes proposed openstack/nova: placement: RT now adds proper Ironic inventory  https://review.openstack.org/40447219:37
openstackgerritJay Pipes proposed openstack/nova: rt: use a single ResourceTracker object instance  https://review.openstack.org/39847319:37
*** paw has quit IRC19:40
*** bvanhav_ has quit IRC19:40
melwittomg fixing unit tests is finding my bugs -_-19:40
*** moshele has joined #openstack-nova19:44
*** oomichi_ has quit IRC19:47
*** kfarr has joined #openstack-nova19:52
*** jerrygb has joined #openstack-nova19:57
melwittdansmith: are there any common mistakes/reasons why a lazy-load of flavor would try to occur even after specifying expected_attrs=['flavor']?19:57
dansmithmelwitt: hmm, not that I can think of19:58
slaweqmriedem: hello20:00
slaweqmriedem: I made small patch https://review.openstack.org/#/c/420176/ to fix https://bugs.launchpad.net/nova/+bug/164050220:00
openstackLaunchpad bug 1640502 in OpenStack Compute (nova) "Empty /etc/machine-id causes failure in unit tests" [Medium,In progress] - Assigned to Slawek Kaplonski (slaweq)20:00
slaweqmriedem: can You take a look on it if You will have a while? thx in advance20:01
melwittdansmith: thanks, will keep digging20:01
*** bvanhav_ has joined #openstack-nova20:04
*** voelzmo has joined #openstack-nova20:05
dansmithmriedem: I  bet we need to discover hosts somewhere after the subnode runs, which is why I'm getting this: http://logs.openstack.org/79/319379/58/check/gate-tempest-dsvm-multinode-live-migration-ubuntu-xenial/c25f7d1/logs/testr_results.html.gz20:10
melwittoh, duh. this unit test is creating instances that don't have flavors as part of the setup and the old code used to look at inst['vcpus'] apparently20:12
melwittso my instance get was getting some instances with None flavors20:13
*** moshele has quit IRC20:13
*** edmondsw has joined #openstack-nova20:18
*** adisky_ has quit IRC20:19
*** slaweq has quit IRC20:19
bauzasjaypipes: hey, about https://review.openstack.org/#/c/417961/5/nova/scheduler/host_manager.py@36220:20
bauzasjaypipes: sec to discuss ?20:20
jaypipesbauzas: just finishing on phone call. gimme 10.20:20
bauzasjaypipes: fair20:20
bauzasjaypipes: leaving notes meanwhile20:20
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/42084420:21
*** slaweq has joined #openstack-nova20:21
*** voelzmo has quit IRC20:22
*** salv-orlando has quit IRC20:23
*** edmondsw has quit IRC20:23
*** lpetrut has quit IRC20:27
jaypipesbauzas: k, done.20:30
*** kfarr_ has joined #openstack-nova20:30
bauzasjaypipes: see my comment for context in gerrit20:30
*** ijw has joined #openstack-nova20:31
*** woodster_ has joined #openstack-nova20:32
mriedemwhew20:33
*** jose-phi_ has quit IRC20:33
mriedemdansmith: yeah probably, which is actually what i started working on20:33
mriedembefore the call i just got off of happened20:33
*** dave-mccowan has quit IRC20:34
*** rtheis has joined #openstack-nova20:34
bauzasjaypipes: thoughts on that ?20:34
*** ijw__ has quit IRC20:34
dansmithmriedem: okay20:35
bauzasjaypipes: I honestly totally agree with you that using a reportclient is somehow sad20:35
*** kfarr__ has joined #openstack-nova20:35
bauzasjaypipes: but I wanted to be pragmatic20:35
*** kfarr__ has quit IRC20:35
*** jose-phillips has joined #openstack-nova20:36
*** kfarr__ has joined #openstack-nova20:38
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: DO NOT MERGE: check OSC  https://review.openstack.org/42094120:38
*** kfarr__ has quit IRC20:39
*** kfarr_ has quit IRC20:40
*** kfarr has quit IRC20:41
*** kfarr has joined #openstack-nova20:41
*** kfarr has quit IRC20:41
mriedemok on the api node i create nova_subnode_cell db, and then create subnode-cell cell with the db connection to the nova_subnode_cell db and transport_url to the primary node's same mq20:43
mriedemtransport-url is going to be the same for all of these20:43
mriedemthen on the subnode setup after n-cpu is running i need to run discover_hosts20:44
*** ducttape_ has joined #openstack-nova20:45
mriedemnow i need to remember how to awk stuff, damn20:45
*** Guest7011 has quit IRC20:46
*** rtheis has quit IRC20:48
*** ducttape_ has quit IRC20:49
*** bvanhav_ has quit IRC20:56
*** jamielennox|away is now known as jamielennox20:59
jaypipesbauzas: sorry, reading now. got pulled away21:01
bauzasnp21:01
comstudmriedem: well, there's your problem21:07
jaypipescomstud: blast from the past! howdy.21:08
comstudyo :)21:08
jaypipesbauzas: ok, fair point on the reporting client thing. I can go along with that.21:08
jaypipesbauzas: with a promise to clean up ex post facto.21:08
*** salv-orlando has joined #openstack-nova21:09
bauzasjaypipes: my change is still there21:09
jaypipesbauzas: I still would need to see a ComputeNodeList.get_all_by_uuids() though.21:09
bauzasjaypipes: I mean the placementclient one21:09
jaypipesbauzas: understood.21:09
bauzasjaypipes: sure, I'll redo it21:09
openstackgerritClaudiu Belu proposed openstack/nova: hyper-v: Adds support for VMs with nested virtualization  https://review.openstack.org/39850921:09
openstackgerritClaudiu Belu proposed openstack/nova: Adds CPUFeaturesField to ImageMetaProps  https://review.openstack.org/42096021:09
*** dimtruck is now known as zz_dimtruck21:10
bauzasjaypipes: the question I was wondering about the placementclient is that it would be reasonable to only provide CRUD ops in it21:10
bauzasjaypipes: or if I'd rather work on objectifying that client21:10
bauzascutting by just the CRUD ops could possible be merged sooner21:10
jaypipesbauzas: no, I think just pulling get/put/post/safe_connect into a class is correct.21:11
mriedemcomstud: it's ok, mrodden stopped by just at the right time and gave me the awk i needed21:11
bauzasbut I'd tend to prefer having a placementclient that would have resources in it21:11
bauzasjaypipes: okay, then I'll continue to keep my change up-to-date then21:11
bauzasit'll just be a top change, not a dependent one21:11
jaypipesbauzas: I'd prefer composition over inheritance as I mentioned before, and keep state in separate objects (i.e. not the PlacementClient class itself but the object that contains a PlacementClient object)21:12
*** jose-phillips has quit IRC21:12
bauzasjaypipes: composition is already in the last PS21:12
bauzasAFAIR21:12
bauzasunless I forgot to upload it21:12
*** jamesdenton has joined #openstack-nova21:13
*** jose-phillips has joined #openstack-nova21:14
bauzasjaypipes: state of what? it's mostly stateless if you except the disabled thing21:14
*** JoseMello has quit IRC21:15
jaypipesbauzas: I mean the _resource_providers dict.21:15
bauzasjaypipes: in that case, it's fine, I left that21:15
jaypipesbauzas: I would prefer that not be in the PlacementClient. That should be in the ReportingClient, yes?21:15
bauzascorrect21:15
jaypipescool21:15
*** rfolco has quit IRC21:15
bauzasjaypipes: https://review.openstack.org/#/c/417111/7/nova/scheduler/client/report.py is pretty seamless21:15
jaypipesbauzas: oui. absolument.21:16
jaypipesbauzas: though I'd change SafeConnectDecorator to @client.safe_connect :)21:16
bauzasjaypipes: but I need to keep a state, hence the deco object :)21:18
jaypipesbauzas: you could just look for a consistently-named attribute, no?21:19
bauzasjaypipes: I could use a global var21:20
jaypipesbauzas: or a consistently-named attr :)21:21
jaypipesbauzas: else you could require classes to implement a get_placement_client() method.21:22
*** cdent has quit IRC21:22
jaypipesbauzas: or something like that.21:22
mriedemdansmith: hmm, should create_cell sync the db schema for that cell?21:22
bauzasjaypipes: I thought of the latter21:23
bauzasjaypipes: anyway, I'll see21:23
*** jamesdenton has quit IRC21:24
openstackgerritDan Smith proposed openstack/nova: WIP Move instance creation to conductor  https://review.openstack.org/31937921:24
*** Matias has quit IRC21:24
dansmithmriedem: hmm, I dunno..21:24
dansmithmaybe optional? --sync-that-mofo-too?21:24
mriedemyeah because the problem is running nova-manage db sync on my subnode cell21:25
*** paw has joined #openstack-nova21:25
*** jamesdenton has joined #openstack-nova21:25
mriedemdansmith: fuck i've been doffm'ed https://github.com/openstack/nova/blob/7cb416546a2c6d8eb36cbf9acfde776d54a26811/nova/cmd/manage.py#L63021:27
dansmithmriedem: um, congrats?21:28
mriedemjust looks like we thought about this before21:28
mriedemso to sync this db i have to hack the nova.conf21:28
mriedemotherwise it's going to be pointing at the nova db connection on the primary node21:29
dansmithmriedem: you could make that work for other cells easily, right?21:29
dansmithjust list all the mappings and target them before sync like cell0 does21:29
mriedemyeah we just get all the cell mappings and sync them21:29
mriedemthe note here seems wrong https://github.com/openstack-dev/devstack/blob/master/lib/nova#L68721:31
mriedemnova-manage db sync is just going to sync the local main db, or whatever is in CONF.database.connection21:31
*** dave-mccowan has joined #openstack-nova21:32
*** zz_dimtruck is now known as dimtruck21:32
dansmithyeah21:32
mriedemtoday we're getting cell0 synced b/c of https://github.com/openstack-dev/devstack/blob/master/lib/nova#L95021:32
dansmithmriedem: could also make db sync take a cell uuid or osmeting21:32
*** smatzek has quit IRC21:33
mriedemso in the cells v1 case i don't see where we even sync the cell0 db21:33
dansmiththe cellsv1 case?21:33
mriedemthis https://github.com/openstack-dev/devstack/blob/master/lib/nova#L951-L95621:33
dansmithmap_cell0 does it21:34
mriedemumm,21:34
mriedemnope21:34
mriedemhttps://github.com/openstack/nova/blob/7cb416546a2c6d8eb36cbf9acfde776d54a26811/nova/cmd/manage.py#L115721:34
mriedemit creates the cell0 mapping21:34
mriedembut doesn't sync it21:34
dansmithoh hmm, yeah21:34
dansmithI thought it did21:34
*** Jeffrey4l has quit IRC21:34
mriedemsimple_cell_setup is the only one that does https://github.com/openstack/nova/blob/7cb416546a2c6d8eb36cbf9acfde776d54a26811/nova/cmd/manage.py#L110521:35
dansmithwait, no.. the db sync does it for cellsv1 right?21:35
*** Jeffrey4l has joined #openstack-nova21:35
*** ducttape_ has joined #openstack-nova21:35
mriedemas far as i can tell, db sync is going to just sync the 'main' db21:36
dansmithno, it does cell0 and the main one21:36
dansmithhttps://github.com/openstack/nova/blob/7cb416546a2c6d8eb36cbf9acfde776d54a26811/nova/cmd/manage.py#L63521:36
mriedemoh yeah21:36
dansmithit queries for cell0 and does it, it just doesn't list21:36
mriedemso,21:37
mriedemi think i'm just going to address https://github.com/openstack/nova/blob/7cb416546a2c6d8eb36cbf9acfde776d54a26811/nova/cmd/manage.py#L63021:37
mriedemand do the cell mapping list21:37
mriedemand sync those mofos21:37
mriedemi mean we could also do this in create_cell easily21:38
mriedembut it looks like we thought about a fanout sync in sync already21:38
*** edmondsw has joined #openstack-nova21:40
dansmithyeah, as long as you continue to honor --local-cell21:42
mriedemi am21:42
mriedemshould have a WIP up shortly21:43
melwitthm, I'm having a problem where I want to do a get of instances across all cells using target_cell and utils.spawn, but it doesn't keep the targeted cell context that way21:43
mriedemand then i'll depends-on that for this devstack patch21:43
melwittbecause of the utils.spawn. I wanted to do them all at the same time and wait on all of them to combine the results from each cell21:43
*** ducttape_ has quit IRC21:43
*** ducttape_ has joined #openstack-nova21:44
*** ducttape_ has quit IRC21:44
*** edmondsw has quit IRC21:44
dansmithmelwitt: isn't there some magic about storing the current context in eventlet TLS?21:46
dansmithI dunno why or what that is because we pass it everywhere, but... there's something21:46
melwittdansmith: I dunno but thanks for the hint. I'll see if I can find something related to that, because for now, I'm lost21:47
*** jamesdenton has quit IRC21:47
*** salv-orlando has quit IRC21:47
*** jamesdenton has joined #openstack-nova21:49
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/42084421:49
melwittit uses the get_current() context from TLS, so that implies my target_cell modified context isn't in get_current(). makes sense because I don't think anything about target_cell saves the new targeted context to TLS21:50
*** jamesdenton has quit IRC21:52
*** dave-mccowan has quit IRC21:54
*** thorst has quit IRC21:55
*** aojea has joined #openstack-nova21:59
openstackgerritMatt Riedemann proposed openstack/nova: Fanout the db sync to all cells if --local_cell is False  https://review.openstack.org/42097322:00
openstackgerritMatt Riedemann proposed openstack/nova: Add some cellsv2 setup docs  https://review.openstack.org/42019822:03
openstackgerritMatt Riedemann proposed openstack/nova: Fix the generated cell0 default database name  https://review.openstack.org/42043922:03
mriedemdansmith: had to remove the dependencies on that bottom change b/c the stable/newton backports for the devstack/grenade changes were keeping it from merging22:04
*** smatzek has joined #openstack-nova22:05
*** eharney has quit IRC22:08
dansmithmriedem: ack, thansk22:12
*** salv-orlando has joined #openstack-nova22:12
mriedemman the db sync stuff in devstack is getting a bit crazy22:12
dansmithsync, sync, sync again, sure one more why not22:12
mriedemand if we're counting, we'll have 4 dbs in the multinode job: nova_api, nova_cell0, nova (cell1), nova_subnode_cell (cell2)22:13
dansmithwell, four dbs for a multi-cell cloud.. not bad :)22:13
mriedemand in pike we'll have the placement db :)22:13
mriedembut at that point it's no longer nova so not our fault22:13
*** marst has quit IRC22:15
dansmithyeah22:15
*** dimtruck is now known as zz_dimtruck22:17
mriedemok here is the devstack change of doom https://review.openstack.org/42097622:17
mriedemi would be amazed if that worked on the first try22:17
dansmithmriedem: well, we need the late discover_hosts even without trying to create another cell22:18
*** zz_dimtruck is now known as dimtruck22:18
dansmithdon't you want to separate those/22:18
mriedemi could22:18
mriedemand get less cute with the list_cells awk22:18
*** smatzek has quit IRC22:19
mriedemyeah let me separate that quick, basically just if n-cpu; then discover_hosts22:19
dansmithyeah22:19
openstackgerritDan Smith proposed openstack/nova: WIP Move instance creation to conductor  https://review.openstack.org/31937922:21
*** jheroux has quit IRC22:22
*** salv-orl_ has joined #openstack-nova22:24
*** thorst has joined #openstack-nova22:24
*** salv-orlando has quit IRC22:26
*** thorst has quit IRC22:28
mriedemok done22:28
*** dimtruck is now known as zz_dimtruck22:28
mriedemdansmith: here is the change you'll need https://review.openstack.org/#/c/420981/122:28
dansmiththanks22:29
*** zz_dimtruck is now known as dimtruck22:29
*** jerrygb has quit IRC22:34
mriedemjaypipes: +2 on https://review.openstack.org/#/c/398473/ now22:36
mriedemthanks22:36
*** tblakes has quit IRC22:39
*** jdurgin has quit IRC22:39
*** jaosorior has quit IRC22:41
*** ducttape_ has joined #openstack-nova22:45
*** ducttape_ has quit IRC22:49
mriedemalright apparently i'm going to die in an ice storm and should head home, so doing that now, will be back online later22:50
*** mriedem has quit IRC22:51
*** jdurgin has joined #openstack-nova22:57
*** mdrabe has quit IRC22:58
*** medberry is now known as med_23:05
*** krtaylor has quit IRC23:06
openstackgerritDan Smith proposed openstack/nova: WIP Move instance creation to conductor  https://review.openstack.org/31937923:07
openstackgerritGage Hugo proposed openstack/nova: Fixed warning messages when building docs  https://review.openstack.org/42099023:10
*** jerrygb has joined #openstack-nova23:22
*** mriedem has joined #openstack-nova23:23
*** jose-phillips has quit IRC23:23
*** jwcroppe has quit IRC23:26
*** jerrygb has quit IRC23:26
*** jose-phillips has joined #openstack-nova23:30
*** jerrygb has joined #openstack-nova23:34
*** xyang1 has quit IRC23:34
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Fix deprecated proxy API parameters  https://review.openstack.org/41688223:35
*** ducttape_ has joined #openstack-nova23:35
*** dimtruck is now known as zz_dimtruck23:35
*** ircuser-1 has joined #openstack-nova23:43
openstackgerritDan Smith proposed openstack/nova: Multicell support for instance listing  https://review.openstack.org/39677523:44
openstackgerritDan Smith proposed openstack/nova: Make api_samples tests use simple cell environment  https://review.openstack.org/41047323:45
openstackgerritDan Smith proposed openstack/nova: WIP Move instance creation to conductor  https://review.openstack.org/31937923:45
*** knikolla has quit IRC23:47
*** knikolla has joined #openstack-nova23:47
*** knikolla has quit IRC23:47
*** knikolla has joined #openstack-nova23:48
*** salv-orl_ has quit IRC23:50
mriedemhmm, wtf is the difference between gate-tempest-dsvm-multinode-full-ubuntu-xenial-nv and gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv now that both are running neutron23:53
*** dave-johnston has quit IRC23:55
*** edmondsw has joined #openstack-nova23:55
mriedemheh, turns out, not a gd thing23:56
*** edmondsw has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!