*** thorst_ has joined #openstack-nova | 00:00 | |
*** raunak has quit IRC | 00:02 | |
*** tobasco has quit IRC | 00:02 | |
*** thorst_ has quit IRC | 00:04 | |
*** baoli has joined #openstack-nova | 00:05 | |
*** kaisers has quit IRC | 00:06 | |
*** Fdaisuke has quit IRC | 00:09 | |
*** thorst_ has joined #openstack-nova | 00:13 | |
*** thorst_ has quit IRC | 00:13 | |
*** acabot has quit IRC | 00:13 | |
*** tobasco has joined #openstack-nova | 00:14 | |
*** jogo has joined #openstack-nova | 00:31 | |
*** jogo has quit IRC | 00:32 | |
*** jogo has joined #openstack-nova | 00:35 | |
*** jogo has quit IRC | 00:36 | |
*** jog0 has quit IRC | 00:37 | |
*** jogo has joined #openstack-nova | 00:37 | |
*** armax has quit IRC | 00:51 | |
*** takashin has joined #openstack-nova | 00:52 | |
*** kaisers has joined #openstack-nova | 01:02 | |
*** ducttape_ has quit IRC | 01:09 | |
*** dimtruck is now known as zz_dimtruck | 01:14 | |
*** ducttape_ has joined #openstack-nova | 01:17 | |
*** liangy has quit IRC | 01:19 | |
*** raunak has joined #openstack-nova | 01:31 | |
*** foexle has quit IRC | 01:35 | |
*** ducttape_ has quit IRC | 01:39 | |
*** ducttape_ has joined #openstack-nova | 01:39 | |
*** tbachman has joined #openstack-nova | 01:42 | |
*** thorst_ has joined #openstack-nova | 01:44 | |
*** thorst_ has quit IRC | 01:49 | |
*** amotoki has joined #openstack-nova | 01:53 | |
*** ducttape_ has quit IRC | 02:02 | |
*** ducttape_ has joined #openstack-nova | 02:03 | |
*** ducttape_ has quit IRC | 02:06 | |
*** _ducttape_ has joined #openstack-nova | 02:06 | |
*** thorst_ has joined #openstack-nova | 02:09 | |
*** unicell has quit IRC | 02:10 | |
*** thorst_ has quit IRC | 02:12 | |
*** amotoki has quit IRC | 02:18 | |
*** yamahata has joined #openstack-nova | 02:23 | |
*** _ducttape_ has quit IRC | 02:24 | |
*** amotoki has joined #openstack-nova | 02:26 | |
*** tanee_away is now known as tanee | 02:31 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova-specs: Enable cold migration with target host https://review.openstack.org/426636 | 02:34 |
---|---|---|
*** kaisers has quit IRC | 02:35 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | 02:38 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | 02:39 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 02:40 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 02:40 |
openstackgerrit | Takashi NATSUME proposed openstack/nova-specs: Enable cold migration with target host https://review.openstack.org/426636 | 02:41 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | 02:44 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | 02:44 |
*** hongbin has joined #openstack-nova | 02:44 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Microversion 2.42 - Enable cold migration with target host https://review.openstack.org/406707 | 02:44 |
*** amotoki has quit IRC | 02:45 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Add functional tests for cold migration to same host https://review.openstack.org/414926 | 02:45 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Add functional tests for cold migration to same host https://review.openstack.org/414926 | 02:46 |
*** thorst_ has joined #openstack-nova | 02:57 | |
*** thorst_ has quit IRC | 02:57 | |
*** baoli has quit IRC | 02:58 | |
*** kaisers has joined #openstack-nova | 03:00 | |
*** Sukhdev has joined #openstack-nova | 03:01 | |
*** thorst_ has joined #openstack-nova | 03:07 | |
*** thorst_ has quit IRC | 03:07 | |
*** Oku_OS-away has quit IRC | 03:08 | |
*** Oku_OS-away has joined #openstack-nova | 03:08 | |
*** rcernin has joined #openstack-nova | 03:11 | |
*** kaisers has quit IRC | 03:13 | |
*** rcernin has quit IRC | 03:13 | |
*** rcernin has joined #openstack-nova | 03:14 | |
*** tbachman has quit IRC | 03:23 | |
*** rcernin has quit IRC | 03:25 | |
*** guchihiro has joined #openstack-nova | 03:27 | |
*** hfu has joined #openstack-nova | 03:31 | |
*** nicolasbock has quit IRC | 03:34 | |
*** tbachman has joined #openstack-nova | 03:40 | |
*** hoangcx has joined #openstack-nova | 03:41 | |
*** amotoki has joined #openstack-nova | 03:45 | |
*** hoangcx has quit IRC | 03:47 | |
openstackgerrit | David Medberry proposed openstack/nova: Explain how allow_resize_to_same_host is useful https://review.openstack.org/426531 | 03:54 |
*** links has joined #openstack-nova | 03:56 | |
*** links has quit IRC | 03:57 | |
*** baoli has joined #openstack-nova | 03:57 | |
*** hoangcx has joined #openstack-nova | 04:00 | |
*** hoangcx has quit IRC | 04:00 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix parameters in os-hosts.inc https://review.openstack.org/416444 | 04:03 |
*** baoli has quit IRC | 04:04 | |
*** raunak has quit IRC | 04:04 | |
*** gouthamr has quit IRC | 04:09 | |
*** baoli has joined #openstack-nova | 04:10 | |
*** kaisers has joined #openstack-nova | 04:11 | |
*** baoli has quit IRC | 04:12 | |
*** baoli has joined #openstack-nova | 04:18 | |
*** sree has joined #openstack-nova | 04:19 | |
*** ducttape_ has joined #openstack-nova | 04:25 | |
*** mdnadeem has joined #openstack-nova | 04:29 | |
*** ducttape_ has quit IRC | 04:30 | |
*** maestropandy has joined #openstack-nova | 04:31 | |
*** baoli has quit IRC | 04:32 | |
*** tbachman has quit IRC | 04:37 | |
*** kristian__ has joined #openstack-nova | 04:38 | |
*** kristian__ has quit IRC | 04:42 | |
*** kaisers has quit IRC | 04:46 | |
*** dikonoo has joined #openstack-nova | 04:51 | |
*** amotoki has quit IRC | 04:56 | |
*** ayogi has joined #openstack-nova | 04:58 | |
*** sudipto has joined #openstack-nova | 04:59 | |
*** sudipto_ has joined #openstack-nova | 04:59 | |
*** dikonoor has joined #openstack-nova | 05:05 | |
*** dikonoo has quit IRC | 05:05 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Fix doc generation warnings https://review.openstack.org/425549 | 05:07 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Use ListOfIntegersField in oslo.versionedobjects https://review.openstack.org/423912 | 05:07 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Refactor a test method including 3 test cases https://review.openstack.org/394738 | 05:07 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix deprecated proxy API parameters https://review.openstack.org/416882 | 05:08 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix keypair API parameters https://review.openstack.org/420626 | 05:08 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Refactor a test method including 7 test cases https://review.openstack.org/395436 | 05:08 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix parameters and examples in aggregate API https://review.openstack.org/425512 | 05:08 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Avoid forcing translation on logging calls https://review.openstack.org/413876 | 05:08 |
*** hongbin has quit IRC | 05:10 | |
*** ratailor has joined #openstack-nova | 05:10 | |
*** diga has joined #openstack-nova | 05:17 | |
*** mtanino has quit IRC | 05:19 | |
*** kaisers has joined #openstack-nova | 05:21 | |
*** amotoki has joined #openstack-nova | 05:25 | |
*** dikonoor has quit IRC | 05:27 | |
*** psachin has joined #openstack-nova | 05:28 | |
*** maestropandy has left #openstack-nova | 05:33 | |
*** dikonoor has joined #openstack-nova | 05:38 | |
*** prateek has joined #openstack-nova | 05:41 | |
*** swamireddy has joined #openstack-nova | 05:43 | |
*** unicell has joined #openstack-nova | 05:44 | |
*** Dinesh_Bhor has joined #openstack-nova | 05:47 | |
*** thorst_ has joined #openstack-nova | 05:49 | |
*** satyar has joined #openstack-nova | 05:50 | |
*** udesale has joined #openstack-nova | 05:51 | |
*** thorst_ has quit IRC | 05:55 | |
*** adisky_ has joined #openstack-nova | 05:59 | |
*** swamireddy has left #openstack-nova | 06:00 | |
*** swamireddy_ has joined #openstack-nova | 06:01 | |
*** kristian__ has joined #openstack-nova | 06:01 | |
*** unicell1 has joined #openstack-nova | 06:01 | |
*** unicell has quit IRC | 06:02 | |
*** Jack_I has joined #openstack-nova | 06:02 | |
*** ecelik has joined #openstack-nova | 06:04 | |
*** ecelik has left #openstack-nova | 06:04 | |
*** claudiub|2 has joined #openstack-nova | 06:05 | |
*** kristian__ has quit IRC | 06:05 | |
*** mtanino has joined #openstack-nova | 06:13 | |
*** lpetrut has joined #openstack-nova | 06:14 | |
*** lpetrut has quit IRC | 06:17 | |
*** nkrinner_afk is now known as nkrinner | 06:17 | |
*** lpetrut has joined #openstack-nova | 06:19 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova-specs: xAbort Cold Migration https://review.openstack.org/334732 | 06:19 |
*** mtanino has quit IRC | 06:19 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova-specs: Abort Cold Migration https://review.openstack.org/334732 | 06:19 |
*** ducttape_ has joined #openstack-nova | 06:26 | |
*** ducttape_ has quit IRC | 06:31 | |
*** bhagyashris has joined #openstack-nova | 06:35 | |
*** toabctl has joined #openstack-nova | 06:54 | |
*** kristian__ has joined #openstack-nova | 06:56 | |
*** lpetrut has quit IRC | 06:58 | |
*** sridharg has joined #openstack-nova | 07:04 | |
*** unicell has joined #openstack-nova | 07:07 | |
*** kristian__ has quit IRC | 07:08 | |
*** unicell1 has quit IRC | 07:08 | |
*** rcernin has joined #openstack-nova | 07:11 | |
*** rcernin has quit IRC | 07:12 | |
*** rcernin has joined #openstack-nova | 07:12 | |
*** Oku_OS-away is now known as Oku_OS | 07:18 | |
*** artom_ has joined #openstack-nova | 07:22 | |
*** andreas_s has joined #openstack-nova | 07:25 | |
*** mkoderer has joined #openstack-nova | 07:26 | |
*** artom has quit IRC | 07:27 | |
*** karthiks has joined #openstack-nova | 07:29 | |
*** markus_z has joined #openstack-nova | 07:33 | |
*** vsaienko has joined #openstack-nova | 07:35 | |
*** lennyb has joined #openstack-nova | 07:37 | |
*** lennyb_ has joined #openstack-nova | 07:37 | |
*** lennyb_ has quit IRC | 07:37 | |
openstackgerrit | Andrey Volkov proposed openstack/nova: Update pci device fields from deleted object https://review.openstack.org/426243 | 07:44 |
*** vsaienko has quit IRC | 07:49 | |
*** tesseract has joined #openstack-nova | 07:50 | |
*** thorst_ has joined #openstack-nova | 07:51 | |
*** abalutoiu has joined #openstack-nova | 07:51 | |
*** ekuris__ has joined #openstack-nova | 07:54 | |
*** thorst_ has quit IRC | 07:56 | |
*** edand has joined #openstack-nova | 07:58 | |
*** Sukhdev has quit IRC | 08:02 | |
*** vsaienko has joined #openstack-nova | 08:03 | |
*** avolkov has quit IRC | 08:13 | |
*** takashin has left #openstack-nova | 08:15 | |
*** pcaruana has joined #openstack-nova | 08:15 | |
*** haukebruno has quit IRC | 08:20 | |
*** zer0c00l has joined #openstack-nova | 08:24 | |
zer0c00l | I don't know if i have to get my eyes checked, but it looks like _heal_instance_info_cache just going to refresh cache only once for the instance on top of the list | 08:25 |
*** haukebruno has joined #openstack-nova | 08:25 | |
zer0c00l | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5881 | 08:25 |
zer0c00l | We are getting the first instance that is 'okay' to healed and breaking off that loop | 08:26 |
zer0c00l | am i missing something that is obvious ? | 08:26 |
*** avolkov has joined #openstack-nova | 08:26 | |
*** ducttape_ has joined #openstack-nova | 08:27 | |
*** ducttape_ has quit IRC | 08:32 | |
openstackgerrit | Oleg Bondarev proposed openstack/nova: Live migration: wait for vif-plugged event on pre live migration https://review.openstack.org/246910 | 08:33 |
*** jpena|off is now known as jpena | 08:35 | |
*** CristinaPauna has quit IRC | 08:38 | |
*** mnestratov has joined #openstack-nova | 08:41 | |
*** CristinaPauna has joined #openstack-nova | 08:47 | |
*** jpena is now known as jpena|off | 08:48 | |
*** lpetrut has joined #openstack-nova | 08:50 | |
*** jpena|off is now known as jpena | 08:55 | |
*** vsaienko has quit IRC | 08:57 | |
*** amotoki has quit IRC | 08:59 | |
*** ralonsoh has joined #openstack-nova | 09:00 | |
*** zzzeek has quit IRC | 09:00 | |
*** zzzeek has joined #openstack-nova | 09:00 | |
*** amotoki has joined #openstack-nova | 09:00 | |
*** claudiub has joined #openstack-nova | 09:02 | |
*** ayogi has quit IRC | 09:04 | |
*** claudiub|2 has quit IRC | 09:05 | |
*** ayogi has joined #openstack-nova | 09:06 | |
*** guchihiro has quit IRC | 09:09 | |
*** sudipto_ has quit IRC | 09:10 | |
*** sudipto has quit IRC | 09:11 | |
*** sudipto_ has joined #openstack-nova | 09:11 | |
*** yamahata has quit IRC | 09:11 | |
*** sudswas__ has joined #openstack-nova | 09:13 | |
*** ababich has quit IRC | 09:17 | |
*** slaweq has quit IRC | 09:21 | |
*** yassine has joined #openstack-nova | 09:27 | |
*** jschwarz is now known as jschwarz|lunch | 09:27 | |
*** yassine is now known as Guest48852 | 09:28 | |
*** JoseMello has joined #openstack-nova | 09:28 | |
*** lucas-afk is now known as lucasagomes | 09:28 | |
*** rcernin has quit IRC | 09:31 | |
*** rcernin has joined #openstack-nova | 09:33 | |
*** efoley__ has joined #openstack-nova | 09:33 | |
* johnthetubaguy makes monday morning noises | 09:34 | |
*** derekh has joined #openstack-nova | 09:40 | |
openstackgerrit | Feodor Tersin proposed openstack/nova: libvirt: Change condition of root disk snapshot handling https://review.openstack.org/382030 | 09:45 |
openstackgerrit | Feodor Tersin proposed openstack/nova: libvirt: Remove backward compatibility checks for disk snapshots https://review.openstack.org/382031 | 09:45 |
openstackgerrit | Feodor Tersin proposed openstack/nova: libvirt: Call snapshot operations for not file based backends only https://review.openstack.org/414710 | 09:45 |
openstackgerrit | Feodor Tersin proposed openstack/nova: libvirt: Correct ploop imagebackend attribute https://review.openstack.org/414709 | 09:46 |
*** jistr has quit IRC | 09:49 | |
*** jistr has joined #openstack-nova | 09:51 | |
*** thorst_ has joined #openstack-nova | 09:52 | |
*** maestropandy has joined #openstack-nova | 09:56 | |
*** thorst_ has quit IRC | 09:57 | |
openstackgerrit | Rikimaru Honjo proposed openstack/nova: Add checks for preventing unexpected detaching volume https://review.openstack.org/354617 | 09:59 |
*** maestropandy has quit IRC | 10:00 | |
*** maestropandy has joined #openstack-nova | 10:05 | |
*** maestropandy has left #openstack-nova | 10:05 | |
*** amotoki has quit IRC | 10:05 | |
sfinucan | lyarwood: Morning. Interesting question on https://review.openstack.org/#/c/425087 | 10:07 |
sfinucan | It appears the test I've added has highlighted a latent Python 3 issue, which has since been fixed on master | 10:07 |
sfinucan | Do I (a) modify the change to fix said Python issue, (b) backport the Python 3 issue fix first, or (c) remove the test from the patch? | 10:08 |
lyarwood | sfinucan: I'd go with a and document it as a conflict in the change | 10:10 |
sfinucan | lyarwood: and that is what I'll do. Cheers :) | 10:10 |
lyarwood | sfinucan: assuming the fix on master also fixes other py3 issues | 10:10 |
sfinucan | Yeah, a lot of them | 10:10 |
lyarwood | sfinucan: yeah cool, then just fix this test up and document, that should be enough IMHO | 10:11 |
*** amotoki has joined #openstack-nova | 10:15 | |
*** mkoderer has quit IRC | 10:16 | |
*** dikonoor has quit IRC | 10:18 | |
*** ayogi has quit IRC | 10:22 | |
*** ayogi has joined #openstack-nova | 10:22 | |
sfinucan | lyarwood: Think that's done now | 10:23 |
lyarwood | sfinucan: thanks, I'll take a look once CI comes backs. | 10:24 |
lyarwood | sfinucan: would you mind taking a look at https://review.openstack.org/#/c/399735/ this morning if you have time | 10:24 |
sfinucan | sure | 10:24 |
*** gszasz has joined #openstack-nova | 10:25 | |
*** ducttape_ has joined #openstack-nova | 10:28 | |
*** mvk has quit IRC | 10:28 | |
*** sambetts|afk is now known as sambetts | 10:28 | |
*** ducttape_ has quit IRC | 10:33 | |
*** dikonoor has joined #openstack-nova | 10:33 | |
*** amotoki has quit IRC | 10:34 | |
*** cdent has joined #openstack-nova | 10:35 | |
*** satyar has quit IRC | 10:36 | |
*** sree has quit IRC | 10:37 | |
mdbooth | Morning! Now we're out of feature crunch, looking for another +2 on this bugfix which has been sitting a while: https://review.openstack.org/#/c/383859/13 | 10:42 |
cdent | johnthetubaguy, bauzas : I'm a little lost on the state of things. Any salient updates to share? | 10:50 |
bauzas | cdent: waiting for +2 on the grenade fix | 10:50 |
johnthetubaguy | cdent: I think bauzas's change is waiting on grenade | 10:50 |
johnthetubaguy | yeah, that | 10:50 |
johnthetubaguy | the ironic one isn't read yet: https://review.openstack.org/#/c/404472 | 10:51 |
johnthetubaguy | I was thinking about tidying that up right now actually | 10:51 |
johnthetubaguy | but I suspect its a bit late to get that in now | 10:51 |
cdent | johnthetubaguy: cool, that was the one I was wondering about most. | 10:51 |
*** eglynn has joined #openstack-nova | 10:52 | |
bauzas | johnthetubaguy: cdent: well, that one seems at risk | 10:52 |
cdent | I guess jay will be back today and will have some input. It all remains a bit fuzzy about what the actual intent was. | 10:52 |
bauzas | cdent: question, how can we know it works with the ironic driver ? | 10:53 |
bauzas | I can only see one ironic job | 10:53 |
bauzas | which tells me it's green http://logs.openstack.org/72/404472/25/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-ubuntu-xenial-nv/0b27bd3/ | 10:53 |
bauzas | but I'm not sure we're covering the patch with that job | 10:53 |
cdent | bauzas: That's pretty much the source of my question. Without knowing the overall arc of intent, it is hard to discuss coverage. | 10:54 |
cdent | Too many people saying "I'm not sure". | 10:54 |
bauzas | cdent: I'm just trying to explain that I discovered most of the corner cases when I investigated the grenade issue | 10:54 |
bauzas | wrt the scheduler change | 10:54 |
johnthetubaguy | bauzas: the follow up patch was trying to get coverage | 10:55 |
bauzas | I'd be far less concerned if I was somehow seeing that some job is running an ironic cloud that does reporting to nova | 10:55 |
bauzas | I know the tripleo folks kinda use ironic for their undercloud | 10:55 |
bauzas | so we could perhaps see if their jobs are happy | 10:55 |
cdent | Personally, in a perfect universe, I don't think of grenade or tempest as coverage at all. They are smoke. If there aren't functional tests in tree, we're faking it and causing us the problems we encountered at the end of last week. So the _next_ time we come round to this, we should start from tests that do something (not unit tests). | 10:56 |
cdent | But, given that we are not in a perfect universe, and now is not the next time, it's good you did that digging, and it's what we've got... | 10:56 |
*** mvk has joined #openstack-nova | 10:57 | |
cdent | I do know that jroll created a dnm devstack change to exercise the ironic-related change. I'm not sure of the current state of that. | 10:57 |
johnthetubaguy | https://review.openstack.org/#/c/426296 | 10:58 |
jroll | cdent: https://review.openstack.org/#/c/426296/ | 10:58 |
cdent | thanks | 10:58 |
* jroll just walked in, assumes that needs a recheck on the latest PS | 10:58 | |
jroll | er, rebase | 10:58 |
bauzas | jroll: go to bed :p | 10:58 |
jroll | I did that once already | 10:59 |
bauzas | ah, nah, it's just early for you :) | 10:59 |
jroll | indeed :P | 10:59 |
*** rfolco has joined #openstack-nova | 10:59 | |
jroll | ok so my DNM patch looks happy on the latest code | 11:00 |
*** sree has joined #openstack-nova | 11:00 | |
jroll | er no, I can't read | 11:01 |
cdent | jroll: because you been readin' the wrong stuff | 11:01 |
jroll | http://logs.openstack.org/96/426296/3/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-ubuntu-xenial-nv/fd3d15e/logs/screen-n-cpu.txt.gz?level=WARNING | 11:01 |
bauzas | jroll: what does this job ? | 11:01 |
* jroll bets that's the same error as the pep8 job | 11:01 | |
jroll | bauzas: nova+ironic+boot a thing, mostly | 11:02 |
cdent | (this is a story from a friend's teacher who got upset in some depths of kentucky school: "You know why Johnny can't read? Because he's been reading the wrong stuff!" | 11:02 |
johnthetubaguy | yeah, I am fixing up that bug right now | 11:02 |
*** tbachman has joined #openstack-nova | 11:02 | |
cdent | Unless there's something I should be doing? I'm going to go back to evaluating the number of requests the placement api is receiving. | 11:03 |
jroll | "Created resource class record via placement API for resource class CUSTOM_LOL." <- so we're halfway there :P | 11:03 |
bauzas | cool | 11:03 |
bauzas | jroll: good to know, so it's non-voting on check ? | 11:03 |
jroll | bauzas: yes, we've had a job like this non-voting on check for years :) | 11:04 |
* bauzas just resuming his review backlog :) | 11:04 | |
bauzas | jroll: that I know | 11:04 |
bauzas | jroll: :) | 11:04 |
jroll | :P | 11:04 |
johnthetubaguy | FWIW, this is the failure: http://logs.openstack.org/96/426296/3/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-ubuntu-xenial-nv/fd3d15e/logs/screen-n-cpu.txt.gz#_2017-01-28_00_25_20_187 | 11:04 |
*** dikonoor has quit IRC | 11:08 | |
*** ayogi has quit IRC | 11:09 | |
jroll | bauzas: cdent: btw, we've an experimental job on nova/ironic that uses resource classes (triggering this code), I just have a bit of devstack plugin code left to make that work, should finish that early this week | 11:11 |
bauzas | cool | 11:12 |
*** ayogi has joined #openstack-nova | 11:13 | |
*** sree has quit IRC | 11:15 | |
*** sree has joined #openstack-nova | 11:17 | |
*** dikonoor has joined #openstack-nova | 11:21 | |
*** udesale has quit IRC | 11:25 | |
*** dims has joined #openstack-nova | 11:26 | |
*** sree has quit IRC | 11:29 | |
*** tbachman has quit IRC | 11:30 | |
*** psachin has quit IRC | 11:32 | |
*** ducttape_ has joined #openstack-nova | 11:35 | |
*** tbachman has joined #openstack-nova | 11:39 | |
*** tbachman has quit IRC | 11:44 | |
*** vsaienko has joined #openstack-nova | 11:50 | |
*** CristinaPauna has quit IRC | 11:52 | |
*** ducttape_ has quit IRC | 11:52 | |
*** nicolasbock has joined #openstack-nova | 11:52 | |
*** thorst_ has joined #openstack-nova | 11:53 | |
*** markmc has quit IRC | 11:54 | |
*** markmc has joined #openstack-nova | 11:54 | |
artom_ | johnthetubaguy, can I ask you to take a look at https://review.openstack.org/#/c/426030/7 when you have a moment? | 11:55 |
artom_ | It's the device tag 'tag' attribute disappearing issue - you mentioned it needs a microversion in https://review.openstack.org/#/c/423952/, so a spec has been whipped up :) | 11:55 |
*** thorst_ has quit IRC | 11:57 | |
*** diga has quit IRC | 11:59 | |
johnthetubaguy | artom_: ah, its that bug fix that needs a microversion, gotcha | 11:59 |
openstackgerrit | John Garbutt proposed openstack/nova: placement: RT now adds proper Ironic inventory https://review.openstack.org/404472 | 11:59 |
johnthetubaguy | artom_: I will try, honestly it feels like that should be in pike now | 11:59 |
johnthetubaguy | as RC1 us being cut on thursday | 12:00 |
johnthetubaguy | but not 100% sure | 12:00 |
artom_ | johnthetubaguy, I know we're short for time :( But if we can avoid a whole release cycle without device tagging... | 12:00 |
*** weshay is now known as weshay_errand | 12:01 | |
artom_ | (Yeah, I know the client can be version-pinned) | 12:01 |
artom_ | johnthetubaguy, anyways, much thanks in advance :) | 12:02 |
*** bkopilov has quit IRC | 12:02 | |
*** artom_ is now known as artom | 12:03 | |
artom | johnthetubaguy, and for what it's worth, the patch is already up and Alex and gmann have given it one look over each: https://review.openstack.org/#/c/424759/ | 12:04 |
tdurakov | hi folks | 12:07 |
tdurakov | do we have any issues with devstack and cells? | 12:07 |
tdurakov | fresh multinode env: {"message": "Host 'node2' is not mapped to any cell", "code": 400, "created": "2017-01-30T12:04:26Z"} | 12:08 |
sfinucan | johnthetubaguy: Could I get some eyes on https://review.openstack.org/#/c/392643/ - we're seeing the referenced bug pop up in the real world | 12:12 |
*** vsaienko has quit IRC | 12:13 | |
sfinucan | artom: Would appreciate it if you could take a look at ^ too, please :) | 12:13 |
*** hshiina has joined #openstack-nova | 12:15 | |
*** Guest48852 has quit IRC | 12:16 | |
*** ratailor has quit IRC | 12:17 | |
*** foexle has joined #openstack-nova | 12:19 | |
amrith | andreykurilin, thank you | 12:23 |
*** catintheroof has joined #openstack-nova | 12:25 | |
*** Guest48852 has joined #openstack-nova | 12:28 | |
*** alexpilotti has quit IRC | 12:30 | |
*** alexpilotti has joined #openstack-nova | 12:30 | |
*** CristinaPauna has joined #openstack-nova | 12:31 | |
artom | sfinucan, sure, I'll get to it this afternoon :) | 12:32 |
sfinucan | artom: Thanking you kindly, sir | 12:32 |
*** alexpilotti has quit IRC | 12:35 | |
*** bvanhav_ has joined #openstack-nova | 12:38 | |
*** sdague has joined #openstack-nova | 12:40 | |
*** thorst_ has joined #openstack-nova | 12:41 | |
*** bkopilov has joined #openstack-nova | 12:41 | |
*** lucasagomes is now known as lucas-hungry | 12:45 | |
*** tbachman has joined #openstack-nova | 12:46 | |
*** ayogi has quit IRC | 12:47 | |
*** tbachman has quit IRC | 12:51 | |
*** tbachman has joined #openstack-nova | 12:51 | |
*** ekuris__ has quit IRC | 12:57 | |
*** dave-mccowan has joined #openstack-nova | 13:00 | |
*** wasmum has quit IRC | 13:03 | |
*** ducttape_ has joined #openstack-nova | 13:04 | |
*** jaypipes has joined #openstack-nova | 13:04 | |
*** prateek has quit IRC | 13:06 | |
*** edmondsw has joined #openstack-nova | 13:07 | |
openstackgerrit | John Garbutt proposed openstack/nova: DNM: hack ironic with resource providers https://review.openstack.org/426296 | 13:09 |
*** eharney has quit IRC | 13:17 | |
*** mdnadeem has quit IRC | 13:21 | |
*** weshay_errand is now known as weshay | 13:25 | |
*** hshiina has quit IRC | 13:27 | |
*** cdent has quit IRC | 13:30 | |
*** tblakes has joined #openstack-nova | 13:31 | |
edleafe | johnthetubaguy: I see that bug and can fix it, but was waiting until after the scheduler meeting discussion for overall direction | 13:32 |
*** JoseMello has quit IRC | 13:35 | |
*** mdrabe has joined #openstack-nova | 13:36 | |
*** diga has joined #openstack-nova | 13:37 | |
*** mkoderer has joined #openstack-nova | 13:38 | |
*** ducttape_ has quit IRC | 13:41 | |
johnthetubaguy | edleafe: which bug? | 13:41 |
edleafe | johnthetubaguy: sorry, was reading scrollback | 13:42 |
edleafe | johnthetubaguy: AttributeError: 'SchedulerReportClient' object has no attribute '_compute_node_to_inventory_dict' | 13:42 |
*** lucas-hungry is now known as lucasagomes | 13:42 | |
johnthetubaguy | edleafe: ah, gotcha, pushed a fix for that, to see if the ironic tests will pass, just rebased that patch with those tests on | 13:43 |
edleafe | johnthetubaguy: ok, thanks. Still catching up | 13:43 |
johnthetubaguy | np | 13:44 |
johnthetubaguy | edleafe: I think what you have should work, although not 100% sure it gets us enough to push it into ocata | 13:45 |
edleafe | johnthetubaguy: me neither | 13:45 |
*** owalsh has joined #openstack-nova | 13:45 | |
johnthetubaguy | edleafe: if we claimed the new resources we are reporting, then I think that would be good to have | 13:45 |
edleafe | johnthetubaguy: was really hoping to discuss with jaypipes before we move forward | 13:45 |
edleafe | johnthetubaguy: I'm not sure that we claim all of them - just the VCPU-rleated ones | 13:46 |
johnthetubaguy | edleafe : yup, makes sense | 13:46 |
jaypipes | edleafe: heyo | 13:46 |
*** pradk has joined #openstack-nova | 13:47 | |
edleafe | hi yerself | 13:47 |
*** acabot has joined #openstack-nova | 13:49 | |
*** baoli has joined #openstack-nova | 13:50 | |
*** tlian has joined #openstack-nova | 13:52 | |
*** cleong has joined #openstack-nova | 13:53 | |
*** jdurgin has quit IRC | 13:54 | |
edleafe | Nova Scheduler subteam meeting in 5 minutes in #openstack-meeting-alt | 13:55 |
openstackgerrit | Jordan Pittier proposed openstack/nova: Fix unspecified bahavior on GET /servers/detail?tenant_id=X as admin https://review.openstack.org/426259 | 13:57 |
*** jpena is now known as jpena|lunch | 13:57 | |
*** bvanhav_ has quit IRC | 13:58 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: config options: remove libvirt imagecache https://review.openstack.org/378497 | 13:58 |
*** bvanhav_ has joined #openstack-nova | 13:58 | |
johnthetubaguy | edleafe: oh, I should clarify, we don't claim the new custom one right now, which seems problematic to me. | 13:58 |
edleafe | johnthetubaguy: agreed | 13:59 |
*** weshay is now known as weshay_mtg | 13:59 | |
*** karthiks has quit IRC | 13:59 | |
*** jschwarz|lunch is now known as jschwarz | 14:01 | |
*** cdent has joined #openstack-nova | 14:04 | |
*** xyang1 has joined #openstack-nova | 14:08 | |
*** jdurgin has joined #openstack-nova | 14:12 | |
*** clenimar has quit IRC | 14:12 | |
*** gcb has joined #openstack-nova | 14:13 | |
*** clenimar has joined #openstack-nova | 14:16 | |
*** alexpilotti has joined #openstack-nova | 14:16 | |
*** dikonoor has quit IRC | 14:17 | |
*** satyar has joined #openstack-nova | 14:18 | |
*** gouthamr has joined #openstack-nova | 14:19 | |
*** ducttape_ has joined #openstack-nova | 14:19 | |
*** jheroux has joined #openstack-nova | 14:19 | |
*** alexpilotti has quit IRC | 14:20 | |
*** jamesdenton has joined #openstack-nova | 14:21 | |
*** liverpooler has joined #openstack-nova | 14:22 | |
*** READ10 has joined #openstack-nova | 14:22 | |
*** alexpilotti has joined #openstack-nova | 14:26 | |
*** ducttape_ has quit IRC | 14:26 | |
*** alexpilotti has quit IRC | 14:37 | |
*** vladikr has joined #openstack-nova | 14:43 | |
*** hongbin has joined #openstack-nova | 14:45 | |
*** karthiks has joined #openstack-nova | 14:46 | |
*** rcernin has quit IRC | 14:48 | |
*** alexpilotti has joined #openstack-nova | 14:51 | |
*** ducttape_ has joined #openstack-nova | 14:52 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: conf: resolved TODOs in compute configuration https://review.openstack.org/426793 | 14:55 |
*** udesale has joined #openstack-nova | 14:57 | |
johnthetubaguy | sfinucan: mdbooth: is there always a disk.mirror attribute? re https://review.openstack.org/#/c/399735 | 14:58 |
mdbooth | kashyap lyarwood: ^^^ | 14:58 |
*** diga has quit IRC | 14:58 | |
mdbooth | johnthetubaguy: I don't recall the details now, but I do recall investigating that thoroughly and being satisfied at the time | 14:58 |
johnthetubaguy | oops, I meant to ask lyarwood as well | 14:59 |
mdbooth | johnthetubaguy: I suspect the answer is in the libvirt domain xml docs for that element | 14:59 |
kashyap | johnthetubaguy: mdbooth: Trying to remember... | 14:59 |
* mdbooth looks them up | 14:59 | |
sfinucan | johnthetubaguy: Would it matter? | 15:00 |
johnthetubaguy | sfinucan: if its not there, we will just assume every job hasn't ever finished | 15:00 |
johnthetubaguy | I think | 15:00 |
*** rmart04 has joined #openstack-nova | 15:00 | |
*** rcernin has joined #openstack-nova | 15:00 | |
sfinucan | johnthetubaguy: aha - I read that incorrectly https://review.openstack.org/#/c/399735/19/nova/virt/libvirt/guest.py | 15:00 |
mdbooth | johnthetubaguy: Since at least libvirt 0.9.12, possibly longer: http://libvirt.org/formatdomain.html | 15:01 |
mdbooth | Search for 'mirror' | 15:01 |
* sfinucan thought the mirror check was an alternative and it would fallback to the existing check if absent | 15:01 | |
mdbooth | sfinucan: Nah, it's required as a bug fix in fact | 15:01 |
mdbooth | johnthetubaguy: MIN_LIBVIRT_VERSION = (1, 2, 1) | 15:02 |
*** mvk has quit IRC | 15:02 | |
mdbooth | IOW, it's definitely always present | 15:02 |
* lyarwood reads | 15:03 | |
kashyap | mdbooth: Yes, it's been there for the duration at least Matt notes above | 15:03 |
kashyap | Err, johnthetubaguy ^ | 15:03 |
johnthetubaguy | cool, thanks folks | 15:03 |
*** jpena|lunch is now known as jpena | 15:03 | |
johnthetubaguy | "mirror" seemed odd to me, but the docs clear that up nicely, thanks | 15:03 |
lyarwood | johnthetubaguy, sfinucan ; I've not had time to improve the commit msg as yet btw so feel free to hold fire on this and I can make that point a little better there | 15:03 |
dansmith | sdague: did you see the activity on this? https://review.openstack.org/#/c/424730/ | 15:04 |
*** burt has joined #openstack-nova | 15:04 | |
johnthetubaguy | lyarwood: oh boy, I totally didn't see the notes in the commit message somehow, that seems good | 15:04 |
lyarwood | johnthetubaguy: sfinucan did ask for a little more in his review that I'm happy to add if it's still required | 15:05 |
johnthetubaguy | lyarwood: there good point, but the fix seems more important | 15:05 |
sfinucan | lyarwood, johnthetubaguy Yeah, I'm happy to let it in as is | 15:05 |
*** bkopilov has quit IRC | 15:05 | |
sfinucan | (hence +2 - more of a nice-to-have) | 15:06 |
kashyap | johnthetubaguy: Yeah, the word 'mirror' comes from the QEMU QMP primitive 'drive-mirror' (even _that_ is not really an accurate word, as it synchronizes as it sees fit, but not "mirrors" immediately). | 15:06 |
*** burgerk has joined #openstack-nova | 15:07 | |
*** nkrinner is now known as nkrinner_afk | 15:08 | |
*** bkopilov has joined #openstack-nova | 15:11 | |
*** bvanhav_ is now known as bvanhav | 15:12 | |
*** abalutoiu has quit IRC | 15:13 | |
sdague | dansmith: I hadn't yet | 15:13 |
dansmith | sdague: okay everything else is +A behind that | 15:13 |
sdague | what was the thing that failed when it was in a dedicated section? | 15:13 |
dansmith | sdague: we start a newton-based placement | 15:13 |
dansmith | because we do it before nova has upgraded | 15:13 |
sdague | oh... right | 15:14 |
dansmith | ...yeah :) | 15:14 |
*** owalsh is now known as owalsh-brb | 15:14 | |
sdague | ok, well, that's fine for now then. We can separate later and figure out about earlier installing code | 15:15 |
sdague | +A | 15:15 |
dansmith | yeah, thanks | 15:16 |
jaypipes | hmm, it's always unpleasantly surprising when you run tests expecting them to fail, but they pass... | 15:17 |
*** armax has joined #openstack-nova | 15:17 | |
*** mvk has joined #openstack-nova | 15:18 | |
*** baoli has quit IRC | 15:18 | |
*** owalsh-brb has quit IRC | 15:18 | |
*** baoli has joined #openstack-nova | 15:19 | |
*** mriedem has joined #openstack-nova | 15:19 | |
*** alexpilotti has quit IRC | 15:20 | |
*** kfarr has joined #openstack-nova | 15:21 | |
mriedem | blarg | 15:22 |
*** stvnoyes has quit IRC | 15:22 | |
*** jaosorior has joined #openstack-nova | 15:23 | |
*** stvnoyes has joined #openstack-nova | 15:23 | |
*** owalsh-brb has joined #openstack-nova | 15:23 | |
*** jdurgin has quit IRC | 15:23 | |
*** udesale has quit IRC | 15:24 | |
*** owalsh-brb is now known as owalsh | 15:24 | |
mriedem | oh sweet https://review.openstack.org/#/c/424730/ | 15:25 |
johnthetubaguy | mriedem: jaypipes is looking at something for the iroinc patch | 15:25 |
*** zz_dimtruck is now known as dimtruck | 15:26 | |
mriedem | johnthetubaguy: cool | 15:26 |
jaypipes | johnthetubaguy: yeah, I'm on it. | 15:26 |
jaypipes | mriedem: trying to get it done before dentist appt at 11am. | 15:26 |
mriedem | johnthetubaguy: did we want to try and get https://review.openstack.org/#/c/335358/ in before rc1? | 15:26 |
mriedem | hate to put it off all release and then say it's too risky at the end | 15:27 |
mriedem | but i'm kind of feeling like it's too risky at this point | 15:27 |
*** jaosorior has quit IRC | 15:27 | |
johnthetubaguy | mriedem: too risky might be right :( I should take another peak at that | 15:28 |
mriedem | i know a certain someone in hungary will be asking about it | 15:28 |
johnthetubaguy | mriedem: it will need rebasing on top of bauzas's change, due to service version bump | 15:28 |
mriedem | yeah | 15:28 |
johnthetubaguy | mriedem: dang, yeah, its the error handling that scares me in that patch | 15:29 |
johnthetubaguy | feels like we land it in master as soon as we open, to let it cook for the whole cycle | 15:29 |
mriedem | johnthetubaguy: i agree | 15:31 |
mriedem | i'll fall on ildikov's sword | 15:31 |
*** jaosorior has joined #openstack-nova | 15:32 | |
*** kfarr has quit IRC | 15:33 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova: reno for notification-transformation-ocata https://review.openstack.org/426810 | 15:33 |
mriedem | i need to go through the tag microversion bug fix thing, starting with the spec https://review.openstack.org/#/c/426030/ | 15:34 |
*** jordanP has joined #openstack-nova | 15:35 | |
jordanP | dims, mriedem here's a patch that would make the gate-tempest-dsvm-py35-ubuntu-xenial-nv job more reliable: https://review.openstack.org/#/c/426259 It only a one line change (excluding unit tests) | 15:36 |
johnthetubaguy | mriedem: yeah, I am curious on sdague' take on that, I could be over thinking it asking for the microversion | 15:37 |
mriedem | johnthetubaguy: this isn't the all_tenants policy thing | 15:37 |
dims | jordanP : yep. thanks for that! i had reviewed it earlier but forgot to +1 | 15:37 |
mriedem | johnthetubaguy: this is the bug where we broke device tags after 2.37 | 15:37 |
johnthetubaguy | mriedem: yeah, thats the one | 15:37 |
mriedem | johnthetubaguy: on the policy thing for all_tenants_visible, i think i'd like to discuss that one at the PTG | 15:37 |
johnthetubaguy | mriedem: yeah, I think that makes sense | 15:38 |
*** eharney has joined #openstack-nova | 15:38 | |
bauzas | sdague: mriedem: wooot https://review.openstack.org/#/c/424730/ | 15:39 |
*** mvk has quit IRC | 15:40 | |
mriedem | pkoniszewski: did you want to see if you could recreate your reported bug and fix with this patch? https://review.openstack.org/#/c/424428/ | 15:41 |
mriedem | it's huge for an rc1 blocker | 15:41 |
*** abalutoiu has joined #openstack-nova | 15:41 | |
*** avolkov has quit IRC | 15:44 | |
jordanP | mriedem, the patch I linked earlier is not related to "the policy thing for all_tenants_visible". It's just to enforce the same behavior on py27 and py35. Whether this behavior needs to change it another subject | 15:44 |
mriedem | BobBall: was this a regression in ocata? or a latent bug? https://bugs.launchpad.net/nova/+bug/1658877 | 15:45 |
openstack | Launchpad bug 1658877 in OpenStack Compute (nova) "live migration failed with XenServer as hypervisor" [High,In progress] - Assigned to huan (huan-xie) | 15:45 |
*** avolkov has joined #openstack-nova | 15:45 | |
mriedem | jordanP: i know | 15:46 |
jordanP | ok :) | 15:46 |
mriedem | bauzas: in https://etherpad.openstack.org/p/nova-ocata-rc1-todos for placement release notes i think we're covered unless you can think of something besides a prelude section mention | 15:47 |
*** abalutoiu has quit IRC | 15:48 | |
mriedem | bauzas: i.e. i think https://review.openstack.org/#/c/417961/41/releasenotes/notes/resource_providers_scheduler_db_filters-16b2ed3da00c51dd.yaml is pretty solid | 15:48 |
mriedem | we just need prelude | 15:48 |
mriedem | we might also want some things in the placement devref about the scheduler integration and config required for comptues in ocata? | 15:48 |
mriedem | cdent: ^ | 15:48 |
cdent | mriedem: you mean placement.rst or placement_dev.rst? | 15:49 |
cdent | (or both) | 15:49 |
bauzas | mriedem: yup, I was thinking of a prelude section | 15:49 |
mriedem | cdent: the former | 15:49 |
bauzas | mriedem: that's something I can write | 15:49 |
mriedem | cdent: more like notes for operators, i.e. nova-compute won't start with ocata code unless placement is configured in nova.conf, | 15:50 |
mriedem | and maybe just a general note that the filter scheduler will not use placement in ocata while there are <ocata computes, but that's going to be a hard fail in pike | 15:51 |
mdbooth | mriedem: I just sent this to the operators ML: http://lists.openstack.org/pipermail/openstack-operators/2017-January/012540.html | 15:52 |
mdbooth | Would that require a BP or similar? Or would a link to the ML post be sufficient? | 15:52 |
*** abalutoiu has joined #openstack-nova | 15:53 | |
*** mvk has joined #openstack-nova | 15:53 | |
mriedem | mdbooth: bp to remove a broken feature? | 15:54 |
mriedem | mdbooth: i think we can just bug fix it in pike | 15:54 |
mdbooth | mriedem: That's what I hoped you'd say :) | 15:55 |
mriedem | mdbooth: i think cfriesen and the windriver people are using lvm | 15:55 |
mriedem | so might want to ask them about it | 15:55 |
mdbooth | cfriesen: Sparse lvm? | 15:55 |
mdbooth | mriedem: Thanks | 15:55 |
mriedem | cdent: L17 here if you want to sign up https://etherpad.openstack.org/p/nova-ocata-rc1-todos | 15:56 |
cdent | I thought bauzas said he'd take it: [t 387] ? | 15:57 |
purplerbot | <bauzas> mriedem: that's something I can write [2017-01-30 15:49:49] [n 387] | 15:57 |
mdbooth | Incidentally, the issue with it seems to be that it relies on a thinpool being created implicitly, which is created as 64MB on a default setup. This means that as soon as you write more than 64MB of data to your instance you start getting io errors. Which is nice. | 15:57 |
mdbooth | So a cirros instance works on initial boot, but not if you leave it for a bit. | 15:57 |
cdent | (happy to do it, just don't want to duplicate the effort) | 15:57 |
ildikov | johnthetubaguy: mriedem TBH I don't think that patch is that risky | 15:57 |
mriedem | cdent: i thought bauzas was going to do the release note prelude section | 15:59 |
mriedem | but either way | 15:59 |
cdent | mriedem: if it's not clear when I finish what I'm doing right now, I'll take a stab | 16:00 |
*** _ducttape_ has joined #openstack-nova | 16:00 | |
*** ducttape_ has quit IRC | 16:01 | |
mdbooth | mriedem: Is this an rc1 potential bug as in your etherpad: https://review.openstack.org/#/c/383859/13 | 16:01 |
bauzas | mriedem: cdent: I can do both, I don't care that much | 16:01 |
bauzas | mriedem: cdent: I was mentioning the prelude section but anyway | 16:01 |
* cdent bows to bauzas | 16:01 | |
* mdbooth would really like to see it land. | 16:01 | |
mriedem | mdbooth: it's not a regression right? | 16:01 |
mdbooth | mriedem: Nope, but it's a bug. | 16:02 |
*** jdillaman has joined #openstack-nova | 16:02 | |
mriedem | mdbooth: sure, but we have lots of bugs | 16:02 |
mdbooth | mriedem: Right, but this one has a well-tested fix. | 16:02 |
mriedem | mdbooth: having said all of that, i was planning on trying to get that one in yet | 16:02 |
mdbooth | Thanks | 16:02 |
*** annegentle has joined #openstack-nova | 16:05 | |
*** liverpooler has quit IRC | 16:06 | |
*** liverpooler has joined #openstack-nova | 16:07 | |
ildikov | johnthetubaguy: mriedem: so just to ensure we're on the same page, the plan now is to get that remove check_attach patch landed, when master opens for Pike? | 16:07 |
mriedem | ildikov: that's what i would prefer | 16:08 |
mriedem | since we're 4 days from rc1 | 16:08 |
*** Oku_OS is now known as Oku_OS-away | 16:09 | |
ildikov | I guess as the new Cinder API changes will be tied to a version etc. we don't necessarily have to land it a cycle earlier | 16:09 |
ildikov | as it makes those changes easier to do and follow | 16:09 |
*** annegentle has quit IRC | 16:10 | |
ildikov | mriedem: so I can annoy you to hell with this, when master opens then? | 16:10 |
ildikov | mriedem: as it's been two cycles now... :/ | 16:10 |
ildikov | mriedem: and it's really just a bugfix on its own | 16:10 |
mriedem | yeah, but to be fair, it's also super latent behavior | 16:11 |
*** sridharg has quit IRC | 16:11 | |
ildikov | mriedem: I see this as one more reason to remove :) | 16:12 |
artom | mriedem, so I wrote the spec for the device role tagging bug: https://review.openstack.org/#/c/426030/ | 16:13 |
artom | I poked johnthetubaguy to review it, dunno how much bandwidth he has to spare - it'd be awesome if we can fix this for ocata to avoid a cycle without device tagging (yeah, the client the can version pinned, I know) | 16:13 |
artom | dansmith ^^ same to you :) | 16:13 |
artom | Many thanks in advance, gentlemen :) | 16:13 |
openstackgerrit | Dan Smith proposed openstack/nova: Allow scheduler to run cell host discovery periodically https://review.openstack.org/426826 | 16:14 |
*** esberglu has joined #openstack-nova | 16:14 | |
mriedem | artom: i know, i have it open in a tab | 16:14 |
dansmith | do we really have to add another microversion to bring that back in? | 16:16 |
*** armax_ has joined #openstack-nova | 16:16 | |
mriedem | jordanP: left a question in https://review.openstack.org/#/c/426259/ - i don't really see how that doesn't break the case where the admin is listing instances for a specific tenant | 16:16 |
*** armax has quit IRC | 16:17 | |
*** armax_ is now known as armax | 16:17 | |
mriedem | dansmith: i wrestled with that | 16:17 |
mriedem | it is an api change though | 16:18 |
*** unicell has quit IRC | 16:18 | |
mriedem | i.e. trying to tag bdms on server boot with 2.33 in newton wouldn't work but if we bug fix it in ocata, then it will work | 16:18 |
dansmith | it's pretty much the suck though | 16:19 |
*** baoli has quit IRC | 16:19 | |
*** rmart04 has quit IRC | 16:20 | |
jordanP | mriedem, I replied. Not sure I understood the question though. Sorry if I misunderstood | 16:20 |
mriedem | yes i know | 16:20 |
mriedem | http://lists.openstack.org/pipermail/openstack-dev/2017-January/110798.html | 16:20 |
mriedem | jordanP: before your change, an admin is listing instances for a specific tenant, right? | 16:20 |
jordanP | only if all_tenants=1 is passed | 16:20 |
jordanP | in addition to tenant_id=XXX | 16:20 |
mriedem | but in your patch, you're removing tenant_id from search_opts if all_tenants is False | 16:21 |
mriedem | so as an admin, i want to specifically list instances for a single tenant, not all tenants | 16:22 |
*** rmart04 has joined #openstack-nova | 16:22 | |
jordanP | yeah.. I know it sucks, but that's how the current api behaves | 16:22 |
*** yamahata has joined #openstack-nova | 16:23 | |
jordanP | it's "documented" here: https://bugs.launchpad.net/nova/+bug/1185290 | 16:23 |
openstack | Launchpad bug 1185290 in OpenStack Compute (nova) "nova list's --tenant flag also requires --all-tenants" [Undecided,Fix released] - Assigned to Ghanshyam Mann (ghanshyammann) | 16:23 |
*** annegentle has joined #openstack-nova | 16:24 | |
*** rcernin has quit IRC | 16:24 | |
mriedem | should be documented here http://developer.openstack.org/api-ref/compute/?expanded=list-servers-detail#id4 | 16:25 |
*** markus_z has quit IRC | 16:25 | |
mriedem | jordanP: your reply in the patch still doesn't make it clear to me *why* all_tenants has to be true | 16:26 |
*** rmart04 has quit IRC | 16:26 | |
mriedem | is it because the if all_tenants block elevates the context? | 16:26 |
mriedem | because if an admin is making the request, we shouldn't need to elevate the contexzt | 16:27 |
*** weshay_mtg is now known as weshay | 16:27 | |
mriedem | is it something in compute_api.get_all()? or something in the DB API? | 16:27 |
jordanP | I don't understand the question. All I am enforcing is that tenant_id option is dropped if all_tenants doesn"t evaluate to "true" | 16:29 |
jordanP | why, the API was designed this way, I don"t know | 16:30 |
mriedem | jordanP: i'd like to understand why filtering by tenant_id does not work unless all_tenants=1 | 16:31 |
*** bvanhav has quit IRC | 16:31 | |
jordanP | ah ok | 16:31 |
*** slaweq has joined #openstack-nova | 16:31 | |
jordanP | I think it should work but then in the get_all() method | 16:32 |
jordanP | we have this filter_mapping dict that maps tenant_id to project_id | 16:33 |
mriedem | right, which could overwrite project_id in filters to point at the tenant_id, rather than context.project_id | 16:33 |
jordanP | and if we pass both tenant_id and project_id (project_id is automatically added (search_opts['project_id'] = context.project_id), then it becomes unpredictable | 16:34 |
jordanP | yeah exactly | 16:34 |
jordanP | maybe there's a better fix for the issue | 16:35 |
*** rmart04 has joined #openstack-nova | 16:36 | |
mriedem | why not just sort search_opts.items() in get_all() if it's a random order issue? | 16:36 |
*** baoli has joined #openstack-nova | 16:36 | |
mriedem | i don't really enjoy hacking stuff in the REST API because of some behavior in the compute API code, | 16:36 |
mriedem | making it all totally tightly coupled | 16:36 |
*** armax has quit IRC | 16:36 | |
*** baoli has quit IRC | 16:37 | |
*** rmart04 has quit IRC | 16:37 | |
jordanP | so the get_all() method would have these search_opts : {'tenant_id': XX, 'project_id': YY}. This is conflicting | 16:38 |
*** abalutoiu has quit IRC | 16:38 | |
jordanP | sorting would work because we would be able to control, for sure, whether tenant_id takes precedence over project_id, but the overwritting would still be here and unexpected | 16:39 |
*** _ducttape_ has quit IRC | 16:40 | |
mriedem | so if tenant_id is handled first, it maps filters['project_id'] to XX | 16:40 |
mriedem | and then handles project_id and sets filters['project_id'] to YY | 16:40 |
*** ducttape_ has joined #openstack-nova | 16:40 | |
jordanP | something like this, the logic inside the "for opt, value in search_opts.items():" is not trivial to say the least | 16:41 |
mriedem | so if both tenant_id and project_id are in search_opts, you want to handle project_id first | 16:41 |
mriedem | so that the final value is whatever was specified for tenant_id in the request, XX in your example | 16:41 |
*** cdent has quit IRC | 16:42 | |
mriedem | sorting search_opts.items() would fix that right? | 16:42 |
jordanP | yes | 16:42 |
jordanP | but that's more than a hack to me, no one will understand that the order on which items are iterated upon is important | 16:43 |
*** jdurgin has joined #openstack-nova | 16:43 | |
jordanP | we shouldn't be able to call get_all() with both tenant_id and project_id to begin with | 16:43 |
*** mlavalle has joined #openstack-nova | 16:44 | |
BobBall | mriedem: Sorry for the delay - I believe it was a regression in ocata; see comment on the bug. | 16:44 |
*** andreas_s has quit IRC | 16:45 | |
BobBall | Speaking of which, I'm very confused - anyone got a thought why Gerrit shows https://review.openstack.org/#/c/424428/2..3/nova/tests/unit/virt/xenapi/test_driver.py as a change in the comment at the top of the file? | 16:45 |
*** rmart04 has joined #openstack-nova | 16:46 | |
jordanP | BobBall, did you edit this file on a Windows OS ? | 16:46 |
mriedem | jordanP: if filtering by tenant_id is only randomly not working when all_tenants=0, then your change would definitely make it never work | 16:47 |
jordanP | looks like a \n vs \r\n issue | 16:47 |
BobBall | oh dear... I hope that's not the casue... Let me check... (It wasn't me) | 16:47 |
*** baoli has joined #openstack-nova | 16:47 | |
jordanP | mriedem, that's the point, it should never work | 16:47 |
mriedem | jordanP: i don't see why | 16:47 |
mriedem | jordanP: we don't say anything about that in our api docs | 16:48 |
mriedem | jordanP: and if it randomly DOES work today, then breaking it is worse | 16:48 |
jordanP | it randomly work today only on Py35 and it never works on Py27 | 16:48 |
jordanP | the goal of this patch is to make it never work, also on Py35 | 16:48 |
*** bvanhav has joined #openstack-nova | 16:49 | |
jordanP | the doc doesn't say anything about it, I agree. So I can make it work on both py27 and py35 but that would require a Tempest change too. Because Tempest has a test to check that filtering by tenant when all_tenant is 0 doesn't work | 16:49 |
*** ekhugen- has joined #openstack-nova | 16:50 | |
*** abalutoiu has joined #openstack-nova | 16:51 | |
BobBall | jordanP: Indeed, you are right. | 16:51 |
openstackgerrit | Bob Ball proposed openstack/nova: Fix live migrate with XenServer https://review.openstack.org/424428 | 16:52 |
mriedem | jordanP: what's different about py27? | 16:53 |
mriedem | the dict ordering is random on py27 too isn't it? | 16:53 |
jordanP | the order on which the items in the search_opts dict are iterated upon | 16:53 |
BobBall | mriedem: There was a CRLF / LF issue causing https://review.openstack.org/424428 to look huge. I'm not arguing that it's small, but the diff is really 600 lines shorter than patchset 3... | 16:54 |
mriedem | BobBall: ha | 16:54 |
mriedem | jordanP: again, i thought dict.items() was random in py27 too isn't it? | 16:54 |
jordanP | I can't confirm. Maybe it is, maybe someone/something set PYTHONSEED (whatever its name) to ° | 16:55 |
jordanP | 0 | 16:55 |
*** hshiina has joined #openstack-nova | 16:56 | |
edleafe | mriedem: not random, but not guaranteed to stay in order after a change | 16:56 |
*** nic has joined #openstack-nova | 16:56 | |
*** abalutoiu has quit IRC | 16:56 | |
*** bnemec has quit IRC | 16:56 | |
*** chyka has joined #openstack-nova | 16:57 | |
mriedem | so dict.items() in py27 will return the tuples in the order that they were added? | 16:57 |
mriedem | because in the REST API code we're adding tenant_id first and then project_id | 16:57 |
edleafe | mriedem: no, not in the order they were added. But if you call items() once, and then call it again without changing the dict, the order will be the same | 16:58 |
*** tesseract has quit IRC | 16:58 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: conf: resolved TODOs in compute configuration https://review.openstack.org/426793 | 16:58 |
mriedem | edleafe: we only call items() once in this case | 16:58 |
mriedem | as far as i can tell | 16:58 |
edleafe | mriedem: yeah, so no guarantee of ordering | 16:58 |
jordanP | we need to distinguish guarantee and what actually happens | 16:59 |
mriedem | ok, so i'm not really buying the 'this never worked on py27' argument | 16:59 |
*** baoli has quit IRC | 16:59 | |
mriedem | jordanP: i agree we need consistency | 16:59 |
bauzas | shit, the bottom change for the scheduler upcall will be -2 | 16:59 |
bauzas | because of a cells job | 16:59 |
mriedem | bauzas: so recheck | 16:59 |
jordanP | this never works on py27 and the proof is that the Tempest job for that behavior passes on py27 but sometimes fails on py35 | 17:00 |
bauzas | mriedem: it will stop the gate jobs ? | 17:00 |
bauzas | I thought not | 17:00 |
bauzas | unless rebasing my change | 17:00 |
bauzas | I'll actually wait for the grenade change to land | 17:01 |
bauzas | and then recheck | 17:01 |
openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.trigger_crash_dump notification https://review.openstack.org/396225 | 17:01 |
*** bnemec has joined #openstack-nova | 17:01 | |
*** abalutoiu has joined #openstack-nova | 17:02 | |
*** rmart04 has quit IRC | 17:02 | |
bauzas | mriedem: FYI, I'll also write a bit of explanation about cellsv2 in the prelude section | 17:02 |
mriedem | bauzas: don't do the cells v2 prelude | 17:02 |
mriedem | bauzas: unless you plan on updating this https://review.openstack.org/#/c/424737/ | 17:03 |
mriedem | ^ will be the reno for any cells v2 stuff that's missing | 17:03 |
bauzas | mriedem: the prelude section works differently from the other sections | 17:03 |
bauzas | mriedem: so I'd like to only have one change for the prelude section | 17:03 |
bauzas | because that's not bullets | 17:04 |
bauzas | I mean bullet points | 17:04 |
*** kfarr has joined #openstack-nova | 17:04 | |
*** takedakn has joined #openstack-nova | 17:04 | |
bauzas | mriedem: but I can do the prelude change that would be a follow-up of https://review.openstack.org/#/c/424737/8/releasenotes/notes/ocata-cellsv2-support-4b3b5e70e76bc756.yaml | 17:04 |
*** takedakn has quit IRC | 17:05 | |
bauzas | so we would be sure that we don't miss them | 17:05 |
bauzas | mriedem: WFY ? | 17:05 |
mriedem | sure | 17:05 |
*** abalutoiu has quit IRC | 17:06 | |
*** Swami has joined #openstack-nova | 17:06 | |
*** vladikr has quit IRC | 17:06 | |
*** gcb has quit IRC | 17:07 | |
*** chyka has quit IRC | 17:12 | |
openstackgerrit | Jordan Pittier proposed openstack/nova: Fix unspecified bahavior on GET /servers/detail?tenant_id=X as admin https://review.openstack.org/426259 | 17:14 |
*** mtanino has joined #openstack-nova | 17:14 | |
*** baoli has joined #openstack-nova | 17:15 | |
*** oanson has quit IRC | 17:15 | |
jordanP | the question remains: why do we ignore tenant_id if all_tenants=0, I can't answer to this, it's probably unspecified, undefined but it's been like this for a long long time. | 17:16 |
jordanP | I have to go | 17:16 |
*** jordanP has quit IRC | 17:16 | |
*** Guest48852 has quit IRC | 17:17 | |
*** cdent has joined #openstack-nova | 17:17 | |
*** oanson has joined #openstack-nova | 17:17 | |
*** jose-phillips has joined #openstack-nova | 17:19 | |
mriedem | artom: comments inline https://review.openstack.org/#/c/426030/ | 17:19 |
*** yamahata has quit IRC | 17:20 | |
artom | mriedem, woot! | 17:20 |
mriedem | artom: mostly ok, just some nits | 17:20 |
artom | mriedem, sweet, lemme fix those and respin | 17:21 |
*** chyka has joined #openstack-nova | 17:23 | |
*** mvk has quit IRC | 17:24 | |
*** Apoorva has joined #openstack-nova | 17:24 | |
*** edand has quit IRC | 17:28 | |
*** hshiina has quit IRC | 17:30 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova-specs: Fix tag attribute disappearing https://review.openstack.org/426030 | 17:33 |
*** Guest48852 has joined #openstack-nova | 17:34 | |
*** crushil has joined #openstack-nova | 17:34 | |
mriedem | artom: +2 | 17:37 |
openstackgerrit | Stephen Finucane proposed openstack/nova: console: Move proxies to 'console/proxy' https://review.openstack.org/408192 | 17:38 |
artom | mriedem, phast | 17:38 |
*** vladikr has joined #openstack-nova | 17:39 | |
mdbooth | I didn't notice this one missed -3: https://review.openstack.org/#/c/423392/ | 17:40 |
mdbooth | It's trivial, but it needs to go in to Ocata because it's upgrade related. | 17:40 |
mdbooth | mriedem: Is there anywhere I can add stuff like ^^^ in your etherpad? | 17:41 |
mdbooth | mriedem: Or maybe somewhere else? | 17:41 |
*** crushil has quit IRC | 17:43 | |
*** kfarr has quit IRC | 17:43 | |
* mdbooth shoved it in a new section at the bottom just in case. | 17:44 | |
jaypipes | mriedem: k, doing final run of tests now for the Ironic inventory patch. | 17:45 |
jaypipes | mriedem: hopefully will be pushed in <30 minutes | 17:45 |
dansmith | artom: link me to the actual fix? | 17:45 |
*** rmart04 has joined #openstack-nova | 17:45 | |
artom | dansmith, https://review.openstack.org/#/c/424759/ | 17:45 |
*** lucasagomes is now known as lucas-afk | 17:46 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add prelude section for Ocata https://review.openstack.org/426864 | 17:51 |
bauzas | shit, forgot the dep | 17:51 |
openstackgerrit | David Medberry proposed openstack/nova: Explain how allow_resize_to_same_host is useful https://review.openstack.org/426531 | 17:52 |
*** liverpooler has quit IRC | 17:52 | |
*** liverpooler has joined #openstack-nova | 17:53 | |
dansmith | artom: okay, no +1s on that from the API folks | 17:54 |
mriedem | dansmith: api folks are pretty much all out right now | 17:54 |
mriedem | either holiday or tz | 17:54 |
artom | dansmith, Chinese new year I think | 17:54 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2 https://review.openstack.org/424737 | 17:54 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add prelude section for Ocata https://review.openstack.org/426864 | 17:54 |
mriedem | mdbooth: how would you feel about writing up something in the nova devref about the image cache? | 17:54 |
mriedem | mdbooth: b/c as far as i can tell, that's not really documented anywhere | 17:55 |
dansmith | mriedem: ugh, okay | 17:55 |
artom | dansmith, though gmann should be around, and he said he'd look at the new patchset | 17:55 |
dansmith | mriedem: are you gonna review/+2 that? I usually get those guys to look before I hit stuff like that | 17:55 |
dansmith | artom: okay | 17:55 |
mriedem | it should be pretty straightforward though, i just haven't gotten to it yet since i was reviewing the spec first | 17:55 |
dansmith | should we wait for him to +1? | 17:55 |
dansmith | okay | 17:55 |
mriedem | dansmith: yes it's on the list | 17:55 |
mriedem | gmann won't be around until tonight | 17:55 |
dansmith | mriedem: well, I'll wait for you, but I've gone through it | 17:56 |
artom | At least they weeded out the obvious stuff in a first pass, hopefully it's been adresses like they wanted :S | 17:56 |
artom | *addressed | 17:56 |
*** bvanhav has quit IRC | 17:57 | |
artom | And at this point, what's another microversion if we mess up again :D | 17:58 |
*** baoli has quit IRC | 17:58 | |
*** baoli has joined #openstack-nova | 17:59 | |
*** rmart04 has quit IRC | 17:59 | |
*** armax has joined #openstack-nova | 18:02 | |
*** harlowja has joined #openstack-nova | 18:02 | |
*** ralonsoh has quit IRC | 18:02 | |
*** derekh has quit IRC | 18:03 | |
*** efoley_ has joined #openstack-nova | 18:04 | |
*** mvk has joined #openstack-nova | 18:07 | |
ekhugen- | question on the cells patch that just went in https://review.openstack.org/#/c/319379/84 the test in api.py of cells.enable sounds like it's a check between cells v1 and cells v2, but isn't that option for cells enabled at all? If cells is disabled, it goes down the schedule_and_build_instances path and eventually gets caught in that there's no host-to-cell mapping, right? | 18:07 |
*** efoley__ has quit IRC | 18:08 | |
dansmith | ekhugen-: cells.enabled is cellsv1 only | 18:09 |
*** yamahata has joined #openstack-nova | 18:10 | |
dansmith | ekhugen-: cellsv2 has no "enable" flag as it's always "on" | 18:10 |
ekhugen- | dansmith so there's no choice for "no cells (v1 or v2) at all" anymore, right? | 18:11 |
dansmith | ekhugen-: it's complicated (tm) | 18:11 |
dansmith | ekhugen-: there is no turning cellsv2 on or off, and if you have cellsv1 you still have cellsv2 enabled, but inside your existing cellsv1 cells | 18:11 |
dansmith | for now | 18:11 |
dansmith | eventually there will be a migration path out for cellsv1 users to remove the extra layer | 18:11 |
mriedem | dansmith: reviewed https://review.openstack.org/#/c/426826/ | 18:12 |
*** rmart04 has joined #openstack-nova | 18:12 | |
*** efoley_ has quit IRC | 18:12 | |
*** rmart04 has quit IRC | 18:12 | |
mriedem | we only test n-1 computes but do we have anything anywhere that says we don't support n-2? | 18:13 |
mriedem | i.e. the assertion here https://review.openstack.org/#/c/423392/2/nova/virt/libvirt/imagecache.py@a137 | 18:13 |
*** bvanhav has joined #openstack-nova | 18:14 | |
*** jpena is now known as jpena|off | 18:15 | |
*** sudipto_ has quit IRC | 18:15 | |
*** sudswas__ has quit IRC | 18:15 | |
dansmith | mriedem: it's always been the rule | 18:15 |
*** unicell has joined #openstack-nova | 18:15 | |
mriedem | dansmith: is that documenteD? | 18:16 |
mriedem | sans the big D | 18:16 |
dansmith | probably in the upgrades devref somewhere, I can go look in a sec | 18:16 |
sdague | mriedem: the upgrades tag for the TC defines things that way | 18:17 |
*** ijw has joined #openstack-nova | 18:17 | |
sdague | that's probably the most definitive answer from an OpenStack wide perspective - https://governance.openstack.org/tc/reference/tags/assert_supports-upgrade.html | 18:17 |
ekhugen- | thanks dansmith | 18:17 |
*** alexpilotti has joined #openstack-nova | 18:18 | |
dansmith | mriedem: thanks for those notes, I'll hit it again in a sec | 18:18 |
openstackgerrit | Jay Pipes proposed openstack/nova: placement: RT now adds proper Ironic inventory https://review.openstack.org/404472 | 18:18 |
mriedem | http://docs.openstack.org/developer/nova/upgrade.html just mentions n and n+1, nothing about no n-2 | 18:18 |
dansmith | mriedem: I'm refreshing the cells reno now | 18:18 |
jaypipes | jroll, JayF, mriedem, bauzas, dansmith, edleafe, johnthetubaguy, cdent: pls see latest rev above on Ironic inventory. | 18:18 |
mriedem | sdague: yeah that says config from n-1 works in n | 18:19 |
cdent | jaypipes: noted | 18:19 |
jroll | jaypipes: thanks | 18:19 |
*** ijw has quit IRC | 18:19 | |
mriedem | sdague: not sure it's really the same as what i'm thinking, but maybe it implies the same restriction | 18:19 |
sdague | mriedem: so maybe https://governance.openstack.org/tc/reference/tags/assert_supports-rolling-upgrade.html should be explicit about n-1 | 18:19 |
*** ijw has joined #openstack-nova | 18:19 | |
mriedem | sdague: was mainly asking because of the assertion made here https://review.openstack.org/#/c/423392/2/nova/virt/libvirt/imagecache.py | 18:19 |
sdague | mriedem: well, I agree with service versions the code could probably enforce the n-1 instead of just hoping that's all that exists | 18:20 |
openstackgerrit | Dan Smith proposed openstack/nova: Collected release notes for Ocata CellsV2 https://review.openstack.org/424737 | 18:21 |
dansmith | sdague: no, we can't use service version for that | 18:21 |
sdague | dansmith: ok | 18:22 |
*** alexpilotti has quit IRC | 18:22 | |
dansmith | sdague: unless we start recording which version goes with which release and just do a static check that is always having to get updated or something | 18:22 |
dansmith | it doesn't make sense for CD people either | 18:22 |
*** htruta` is now known as htruta | 18:23 | |
mriedem | i'm not really following. https://review.openstack.org/#/c/423392/ mentions a commit in newton. couldn't the ocata change check the service version based on when that newton commit happened to know if it's in there or not? | 18:23 |
mriedem | i.e. if you're min compute is past https://review.openstack.org/#/c/320910/ | 18:23 |
dansmith | mriedem: you can use the service version to check for specific things, sure | 18:24 |
*** crushil has joined #openstack-nova | 18:24 | |
dansmith | mriedem: using it to tell that you're adding a mitaka compute to an ocata-only deployment isn't easy | 18:24 |
mriedem | adding? | 18:25 |
dansmith | checks in ocata to see if there are mitaka-level services could be done, but with a static version that would have to be updated over time | 18:25 |
dansmith | I haven't looked at the actual patch, I'm just commenting on using it to detect N-2 | 18:25 |
mriedem | ok my point was, at the time that 2c389ccc8c266175a71a29358bec7fe219e64fe0 (the newton change referenced in the commit message) was merged, the service version was 11. so in the ocata change that depends on that newton change, i'd think you could only do the ocata thing if the minimum nova-compute service version in the deployment was > 11 | 18:27 |
dansmith | sure, that's not N-2 though right? | 18:28 |
dansmith | that's what service_version is for | 18:28 |
mriedem | right | 18:28 |
openstackgerrit | Dan Smith proposed openstack/nova: Allow scheduler to run cell host discovery periodically https://review.openstack.org/426826 | 18:28 |
mriedem | i'm confusing things. the n-2 question was really about an assumption made in that code that if we land this ocata patch, it means nothing is running n-2 mitaka code, which i'm saying we can't assume, and can figure out using service versions | 18:29 |
*** owalsh is now known as owalsh-afk | 18:29 | |
*** kfarr has joined #openstack-nova | 18:29 | |
openstackgerrit | Chris Dent proposed openstack/nova: Add placement request id to log when GET aggregates https://review.openstack.org/426874 | 18:29 |
*** adisky_ has quit IRC | 18:29 | |
* mriedem makes lunch | 18:29 | |
dansmith | okay | 18:30 |
* cdent has dinner | 18:30 | |
*** cdent has quit IRC | 18:30 | |
*** crushil has quit IRC | 18:30 | |
*** crushil has joined #openstack-nova | 18:31 | |
*** owalsh has joined #openstack-nova | 18:32 | |
*** owalsh-afk has quit IRC | 18:33 | |
*** Sukhdev has joined #openstack-nova | 18:36 | |
*** crushil has quit IRC | 18:38 | |
mriedem | pkoniszewski: ignore the earlier ping about https://bugs.launchpad.net/nova/+bug/1658877 - you didn't report that | 18:40 |
openstack | Launchpad bug 1658877 in OpenStack Compute (nova) "live migration failed with XenServer as hypervisor" [High,In progress] - Assigned to Bob Ball (bob-ball) | 18:40 |
edleafe | jaypipes: reviewing now | 18:40 |
mriedem | BobBall: on ^ it's not a specific nova change that regressed this right? | 18:40 |
mriedem | BobBall: it's just that nova doesn't support xenserver 7? | 18:41 |
mriedem | i'm not sure what "1) the change in network name" means | 18:41 |
*** tyrola has quit IRC | 18:46 | |
*** lpetrut has quit IRC | 18:46 | |
*** foexle has quit IRC | 18:46 | |
*** tyrola has joined #openstack-nova | 18:47 | |
mriedem | diana_clarke: suggestion on wording in https://review.openstack.org/#/c/422171/ | 18:52 |
diana_clarke | mriedem: looking. I'm over here struggling with english wording too. | 18:53 |
*** browne has joined #openstack-nova | 18:54 | |
*** sree has joined #openstack-nova | 18:56 | |
diana_clarke | mriedem: oh that... yeah. I remember trying to come up with something better but was really mostly just concerned with not lying about return values. | 18:58 |
*** sree has quit IRC | 19:01 | |
openstackgerrit | Dan Smith proposed openstack/nova: Allow scheduler to run cell host discovery periodically https://review.openstack.org/426826 | 19:08 |
zer0c00l | The _heal_instance_info_cache is just going to heal the first instance on the list, https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5881 | 19:10 |
zer0c00l | Is that the right behaviour of this method? | 19:10 |
zer0c00l | It loops through instance_uuids, picks up the healable instance and breaks out of that loop | 19:11 |
zer0c00l | which means only first healable instance will get its info cache refreshed | 19:11 |
zer0c00l | Am i missing something? | 19:11 |
dansmith | zer0c00l: the next time it runs it uses the list it made, until the list is empty, then gets a new list | 19:12 |
dansmith | i.e. one heal per cycle | 19:12 |
zer0c00l | dansmith: i see, so one heal per cycle is by design | 19:12 |
dansmith | yes | 19:13 |
zer0c00l | dansmith: we have the interval set to 1800 in our production, so for us it takes forever | 19:13 |
zer0c00l | i guess i will have to reduce that number to something sane | 19:13 |
mriedem | zer0c00l: so change your interval | 19:13 |
zer0c00l | yes | 19:13 |
zer0c00l | thanks | 19:13 |
dansmith | zer0c00l: the healing really shouldn't need to happen anyway, but yeah | 19:13 |
mriedem | default is 60 seocnds | 19:13 |
dansmith | it's supposed to be slow | 19:13 |
mriedem | *seconds | 19:13 |
zer0c00l | okay | 19:14 |
mriedem | oh wait maybe it's different for that one | 19:14 |
mriedem | i guess it's 60 http://docs.openstack.org/newton/config-reference/compute/config-options.html | 19:14 |
*** stewie925 has joined #openstack-nova | 19:16 | |
*** liangy has joined #openstack-nova | 19:16 | |
*** Cristina_ has joined #openstack-nova | 19:17 | |
mriedem | artom: the fact that the DeviceTaggingTest test in tempest is setup with a max of 2.latest is really confusing | 19:18 |
mriedem | in that it still works | 19:18 |
artom | mriedem, indeed... | 19:19 |
artom | I can only assume Tempest doesn't use the max microversion when actually sending the request | 19:20 |
*** CristinaPauna has quit IRC | 19:20 | |
artom | (But does use to check what tests to run) | 19:20 |
mriedem | yeah it uses 2.32 http://logs.openstack.org/51/421251/13/check/gate-tempest-dsvm-neutron-full-ssh/60bb925/logs/tempest.txt.gz#_2017-01-30_15_19_16_672 | 19:20 |
mriedem | in newton, max_microversion is capped for compute to 2.38 http://logs.openstack.org/51/421251/13/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial-newton/7071652/logs/tempest_conf.txt.gz | 19:21 |
mriedem | but it still looks like tempest just uses the min | 19:22 |
mriedem | e.g. 2.37 here http://logs.openstack.org/51/421251/13/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial-newton/7071652/logs/tempest.txt.gz#_2017-01-30_15_29_23_670 | 19:22 |
artom | That can be something we propose to Tempest - to use the max instead of the min | 19:23 |
openstackgerrit | Dan Smith proposed openstack/nova: Allow scheduler to run cell host discovery periodically https://review.openstack.org/426826 | 19:26 |
mriedem | "which re-adds the tag in all the right places." heh | 19:27 |
mriedem | that makes me think dirty thoughts for some reason | 19:27 |
*** lpetrut has joined #openstack-nova | 19:28 | |
*** raunak has joined #openstack-nova | 19:28 | |
*** jaosorior is now known as jaosorior_lunch | 19:28 | |
artom | mriedem, gooood...? | 19:28 |
artom | At least I didn't word it about reinserting the missing (dict) member | 19:29 |
mriedem | actually it makes me think of this https://www.youtube.com/watch?v=FAyDmJvjxbg | 19:29 |
mriedem | is there anyway we can talk about a bag of dicts? | 19:30 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 map_cell_and_hosts https://review.openstack.org/421420 | 19:30 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 verify_instance https://review.openstack.org/421436 | 19:30 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 delete_cell https://review.openstack.org/421459 | 19:30 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 discover_hosts https://review.openstack.org/421442 | 19:30 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 list_cells https://review.openstack.org/421458 | 19:30 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 create_cell https://review.openstack.org/421444 | 19:30 |
*** burgerk has quit IRC | 19:30 | |
artom | We could conceivable describe the request body as a bad of dicts | 19:30 |
*** burgerk has joined #openstack-nova | 19:32 | |
*** owalsh is now known as owalsh-brb | 19:38 | |
mriedem | ooo i see abug | 19:42 |
mriedem | artom: comments in https://review.openstack.org/#/c/424759/ | 19:46 |
*** mkoderer has quit IRC | 19:46 | |
mriedem | artom: the -1 is for https://review.openstack.org/#/c/424759/9/nova/api/openstack/compute/schemas/servers.py@31 for sure | 19:46 |
artom | mriedem, "If we need further clarification we have this I guess..." oy with the sarcasm ;) | 19:47 |
mriedem | well, | 19:47 |
mriedem | not trying to be sarcastic, | 19:47 |
mriedem | if you look at the api-ref | 19:48 |
artom | Heh, you are right though | 19:48 |
mriedem | look at the description for networks.tag here http://developer.openstack.org/api-ref/compute/?expanded=create-server-detail#id7 | 19:48 |
artom | I think I was trying to be generic, because... reasons, I guess? | 19:48 |
mriedem | and block_device_mapping_v2.tag | 19:48 |
mriedem | generic is fine, and what you have in the api-ref is good | 19:48 |
mriedem | i'm on the fence about over documenting this to death | 19:49 |
artom | Surely more docs is better? | 19:49 |
mriedem | probably | 19:50 |
mriedem | you might want to make those specific parameter types then though | 19:50 |
artom | What would we gain by mentioning it less? Someone's bound to run into this, we might as well make the explanation of wtf happened as accessible as possible | 19:50 |
mriedem | so for device_network_tag you just make the comment about 2.32-2.36, and for device_bdm_tag you make the comment about 2.32 | 19:50 |
mriedem | know what i mean? | 19:51 |
artom | Aha, and then set the correct min and max version on each | 19:51 |
mriedem | yeah | 19:51 |
artom | Yep, I agree | 19:51 |
mriedem | since device_tag is used for both right now | 19:51 |
artom | Well | 19:51 |
artom | min, max, and min again | 19:51 |
artom | If I can manage that | 19:51 |
mriedem | fwiw i don't know if the sphinx plugin supports a max_version | 19:52 |
mriedem | sdague: do you know if there is a max_version for https://review.openstack.org/#/c/424759/9/api-ref/source/parameters.yaml@1506 ? | 19:52 |
*** owalsh-brb is now known as owalsh | 19:52 | |
mriedem | oh there is | 19:52 |
mriedem | nvm | 19:52 |
mriedem | artom: i don't think you can do min and max and then min again | 19:52 |
mriedem | so probably just min-version: 2.32, and then notes in the description about the snafu between 2.32 and 2.42 | 19:53 |
*** tbachman has quit IRC | 19:54 | |
artom | mriedem, maybe if I split it again into nic_tag_2.32-2.37 and another one... | 19:54 |
artom | Worth it? | 19:54 |
mriedem | then we have the same parameter listed in the table twice | 19:54 |
artom | Or will it just be more confusing then writing it in English words | 19:54 |
artom | *than | 19:54 |
mriedem | i think english be gooder | 19:54 |
mriedem | sorry, *me think* | 19:55 |
*** jheroux has quit IRC | 20:00 | |
*** haplo37 has quit IRC | 20:01 | |
artom | The schema deepcopy thing is a minefield :( | 20:04 |
artom | You caught the network uuid checking, presumably because you wrote 2.37 yourself | 20:04 |
mriedem | artom: exactly | 20:04 |
mriedem | artom: the tempest guys stopped doing the deepcopy i think | 20:05 |
mriedem | for this very reason | 20:05 |
mriedem | oomichi: right? ^ | 20:05 |
artom | Maybe I'll remove the network_type refactoring then and stick to copy-pasting | 20:06 |
*** crushil has joined #openstack-nova | 20:07 | |
oomichi | mriedem: yeah, you are right. gmann takes care of it on Tempest side | 20:08 |
oomichi | mriedem: that requrest came from sdague and mtreinish because the deepcopy of schema seems unreadable to know whole schema on each microversion | 20:09 |
*** READ10 has quit IRC | 20:09 | |
*** haplo37 has joined #openstack-nova | 20:10 | |
*** stewie925 has quit IRC | 20:11 | |
*** vsaienko has joined #openstack-nova | 20:14 | |
*** ijw has quit IRC | 20:16 | |
*** ijw has joined #openstack-nova | 20:16 | |
mriedem | hmm, what's a better place for the nova-status CLI in the release notes, features or upgrades? | 20:17 |
mriedem | i assume the upgrades section gets more reads | 20:17 |
dansmith | yeah, probably | 20:18 |
dansmith | hopefully anyway | 20:18 |
dansmith | the placement patches got reset so they're still in the running | 20:19 |
dansmith | I'm going to wander off for a bit and will come back to check on them | 20:19 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: Pass APIVersionRequest to extensions https://review.openstack.org/425876 | 20:20 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: Fix tag attribute disappearing in 2.33 and 2.37 https://review.openstack.org/424759 | 20:20 |
*** dtp has joined #openstack-nova | 20:21 | |
*** alexpilotti has joined #openstack-nova | 20:21 | |
*** AAR has joined #openstack-nova | 20:23 | |
*** AAR has left #openstack-nova | 20:23 | |
*** jose-phillips has quit IRC | 20:23 | |
edleafe | jaypipes: Found a test failure in https://review.openstack.org/#/c/404472/ due to an incomplete test I added. Do you want me to remove it, or are you working on anything else with that patch? | 20:24 |
*** baoli has quit IRC | 20:25 | |
*** sambetts is now known as sambetts|afk | 20:25 | |
*** sdague_ has joined #openstack-nova | 20:25 | |
*** alexpilotti has quit IRC | 20:26 | |
*** baoli has joined #openstack-nova | 20:26 | |
*** baoli has quit IRC | 20:27 | |
*** jose-phillips has joined #openstack-nova | 20:28 | |
bauzas | mriedem: I wrote about the nova-status in the prelude | 20:29 |
*** dimtruck is now known as zz_dimtruck | 20:29 | |
bauzas | mriedem: https://review.openstack.org/#/c/426864/ | 20:30 |
mriedem | was coincidentally reading that now | 20:30 |
jaypipes | edleafe: please go ahead! | 20:30 |
*** _ducttape_ has joined #openstack-nova | 20:31 | |
bauzas | mriedem: about the nova-status CLI, I think we should provide a 'feature' section | 20:31 |
bauzas | mriedem: "upgrade" section is just for discussing about what to need to modify before upgrading | 20:31 |
bauzas | mriedem: but you could still add a separate section if you want too | 20:32 |
mriedem | bauzas: i assume operators are more likely to read the upgrades release notes first, | 20:32 |
mriedem | and we want them using nova-status prior to upgrading | 20:32 |
*** xinli has joined #openstack-nova | 20:32 | |
mriedem | so seems best to just have it in the upgrade section | 20:32 |
bauzas | mriedem: sure, but the upgrades section will be huge | 20:32 |
mriedem | i didn't really want to mention the exact same thing in both ugprades and features | 20:32 |
bauzas | mriedem: so that's why I provided the prelude | 20:32 |
mriedem | it already is... | 20:32 |
bauzas | mriedem: so I think operators would see that by the prelude | 20:33 |
dtp | anyone need anything? cup of coffee, etc | 20:33 |
*** ducttape_ has quit IRC | 20:34 | |
mriedem | just had one thanks | 20:34 |
mriedem | bauzas: ok i guess i can rebase my reno on top of yours | 20:34 |
*** bvanhav has quit IRC | 20:34 | |
mriedem | bauzas: and your reno needs a rebase too because your change and dan's change below it are both adding something to the prelude about cells v2 | 20:34 |
bauzas | mriedem: fine by me, which rebase? | 20:35 |
mriedem | your change isn't on top of the latest version of https://review.openstack.org/#/c/424737/ | 20:35 |
*** baoli has joined #openstack-nova | 20:36 | |
bauzas | mriedem: okay | 20:36 |
dtp | ok. let me know if there's anything i can do | 20:38 |
*** pradk has left #openstack-nova | 20:38 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add release note for nova-status upgrade check CLI https://review.openstack.org/426911 | 20:38 |
*** kfarr_ has joined #openstack-nova | 20:39 | |
*** kfarr has quit IRC | 20:39 | |
*** kfarr_ has quit IRC | 20:40 | |
*** kfarr has joined #openstack-nova | 20:40 | |
*** diana_clarke has quit IRC | 20:42 | |
mriedem | bauzas: i suppose we still want to get something into nova-status for warning if CoreFilter/RamFilter/DiskFilter aren't in filter_scheduler.enabled_filters... | 20:43 |
*** marst has joined #openstack-nova | 20:44 | |
bauzas | mriedem: mmm, it could be nice, agreed | 20:44 |
bauzas | mriedem: I can write that if you want | 20:44 |
bauzas | mriedem: you mean, adverting to modify the ratios then ? | 20:45 |
mriedem | yeah something along those lines, | 20:45 |
mriedem | (1) is the filter_scheduler being used, | 20:45 |
mriedem | (2) are any of those things NOT in enabled_filters | 20:45 |
mriedem | (3) for each filter that's not enabled, check it's related allocation ratio and see if it's the default value and if so, issue a warning | 20:46 |
mriedem | something likethat | 20:46 |
*** owalsh_ has joined #openstack-nova | 20:46 | |
bauzas | yeah, like I wrote in the note | 20:46 |
*** owalsh has quit IRC | 20:46 | |
bauzas | very good point | 20:46 |
bauzas | mriedem: just one point, where operators are running the CLI ? | 20:46 |
mriedem | we don't know yet | 20:47 |
bauzas | mriedem: they need to do that in not in a computer, right? rather close to the other services, I guess | 20:47 |
mriedem | as we haven't integrated nova-status into the CI system yet | 20:47 |
mriedem | well, it's really, give me your full config | 20:47 |
*** owalsh_ is now known as owalsh | 20:47 | |
mriedem | so api db, main db, compute config, scheduler config, all of it | 20:47 |
mriedem | and probably run it in a venv or container | 20:48 |
mriedem | so you can install and run it in isolation from the newton deployment code (which doesn't have the CLI) | 20:48 |
bauzas | ok | 20:49 |
mriedem | i'm thinking about writing a wip patch to grenade to run nova-status in the from-netwon script, after we'd done our necessary setup for ocata | 20:49 |
dansmith | mriedem: did you abandon that devstack patch that sets the db host to the primary? | 20:50 |
mriedem | yeah | 20:50 |
mriedem | i can find it | 20:50 |
mriedem | dansmith: this? https://review.openstack.org/#/c/421399/ | 20:51 |
dansmith | mriedem: yeah, can you un-abandon? I'll need that to start up a second cell on the subnode | 20:51 |
*** eharney has quit IRC | 20:52 | |
mriedem | done | 20:52 |
dansmith | thanks | 20:53 |
mriedem | this was my patch for creating a 2nd cell https://review.openstack.org/#/c/420976/ | 20:53 |
mriedem | which is out of date now | 20:53 |
mriedem | which also needed https://review.openstack.org/#/c/420973/ | 20:53 |
openstackgerrit | Ed Leafe proposed openstack/nova: placement: RT now adds proper Ironic inventory https://review.openstack.org/404472 | 20:53 |
dansmith | ah, okay, I hadn't seen that one | 20:53 |
edleafe | jaypipes: cdent: johnthetubaguy: ^^ fixed the functional test | 20:54 |
jaypipes | edleafe: danke | 20:55 |
bauzas | mriedem: dansmith: FYI, merging notes with both prelude sections are most of the time very difficult because they could be misgenerated | 20:55 |
bauzas | that's why we add the ">" section header | 20:55 |
mriedem | bauzas: so i guess take the prelude out of dan's and move it into yours | 20:55 |
dansmith | bauzas: okay, I added prelude text at mriedem's request | 20:56 |
dansmith | but yeah, feel free to take it | 20:56 |
bauzas | okay, just wanted to ask you folks before | 20:56 |
bauzas | and explain why reno is giving you -1 on its job | 20:56 |
bauzas | (well, guessing why) | 20:56 |
bauzas | yeah that http://logs.openstack.org/37/424737/10/check/gate-nova-releasenotes/20a3d9a/console.html#_2017-01-30_18_28_37_031390 | 20:57 |
dansmith | ack | 20:57 |
bauzas | dansmith: I'll push a new rev by deleting your prelude section and putting it in my patch | 20:59 |
*** diana_clarke has joined #openstack-nova | 20:59 | |
*** owalsh_ has joined #openstack-nova | 20:59 | |
dansmith | bauzas: s/deleting/stealing/ | 20:59 |
dansmith | sure | 20:59 |
*** owalsh has quit IRC | 21:00 | |
dansmith | bauzas: you keep stealing american work and trump will put france on "the list" | 21:00 |
bauzas | dansmith: yeah, I'm stealing a job | 21:00 |
*** owalsh_ is now known as owalsh | 21:00 | |
bauzas | but | 21:00 |
bauzas | our French beauty queen won a Trump meetup, so... | 21:01 |
*** liverpooler has quit IRC | 21:01 | |
dansmith | and it's after 1700 in france, so you're a criminal too! | 21:01 |
bauzas | poor me | 21:01 |
*** _ducttape_ has quit IRC | 21:02 | |
cburgess | lol | 21:02 |
*** ducttape_ has joined #openstack-nova | 21:02 | |
*** eglynn has quit IRC | 21:05 | |
*** vsaienko has quit IRC | 21:05 | |
diana_clarke | mriedem: Sorry, I meant linking to http://docs.openstack.org/developer/nova/cells.html for more information. And my internet keeps dropping on me, so I may have missed your response. | 21:06 |
*** eharney has joined #openstack-nova | 21:06 | |
*** gouthamr has quit IRC | 21:07 | |
*** gszasz has quit IRC | 21:09 | |
*** vsaienko has joined #openstack-nova | 21:10 | |
*** zz_dimtruck is now known as dimtruck | 21:11 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Collected release notes for Ocata CellsV2 https://review.openstack.org/424737 | 21:11 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add prelude section for Ocata https://review.openstack.org/426864 | 21:11 |
bauzas | there | 21:12 |
mriedem | diana_clarke: sorry i'm not following | 21:12 |
bauzas | I added a Co-Authored-By tag, so I won't be in jail when I am in ATL | 21:12 |
*** crushil has quit IRC | 21:12 | |
* bauzas whispers | 21:12 | |
diana_clarke | mriedem: No doubt; that wasn't very clear of me ;) | 21:13 |
diana_clarke | mriedem: I'm wondering if I should add a few opening paragraphs to the cells v2 commands. Making it clearer which commands should be run when and in what order. | 21:15 |
*** slaweq has quit IRC | 21:15 | |
diana_clarke | mriedem: Perhaps adding a high level bucket overview: http://paste.openstack.org/show/596936/ | 21:16 |
diana_clarke | linking to http://docs.openstack.org/developer/nova/cells.html etc | 21:16 |
*** xinli has quit IRC | 21:16 | |
*** slaweq has joined #openstack-nova | 21:17 | |
*** jaosorior_lunch is now known as jaosorior | 21:21 | |
*** crushil has joined #openstack-nova | 21:21 | |
*** sdague_ has quit IRC | 21:22 | |
mriedem | diana_clarke: oh, | 21:25 |
mriedem | diana_clarke: from the man page or from http://docs.openstack.org/developer/nova/cells.html#setup-of-cells-v2 ? | 21:25 |
mriedem | i think we definitely want ^ pointing at the man pages | 21:26 |
*** xinli has joined #openstack-nova | 21:26 | |
*** kaisers has quit IRC | 21:27 | |
*** cleong has quit IRC | 21:27 | |
diana_clarke | mriedem: I was talking about a few overview paragraphs at the top of the cells v2 sections here: doc/source/man/nova-manage.rst | 21:28 |
diana_clarke | section | 21:28 |
*** dtp has quit IRC | 21:28 | |
mriedem | diana_clarke: i'm a bit torn on that, not wanting to duplicate something there with what we have in http://docs.openstack.org/developer/nova/cells.html | 21:28 |
mriedem | diana_clarke: i think i'd prefer the more detailed big picture stuff in http://docs.openstack.org/developer/nova/cells.html and then link to the man pages for details on the individual commands | 21:29 |
mriedem | i've noticed the see also in http://docs.openstack.org/developer/nova/man/nova-manage.html#see-also - that, or something like it, should probably refer to http://docs.openstack.org/developer/nova/cells.html | 21:30 |
diana_clarke | mriedem: Cool, perhaps I'll work on updates to developer/nova/cells.html instead. Thanks! | 21:30 |
mriedem | sure, np. i'm not docs writer so i won't claim to know the right answer | 21:31 |
mriedem | s/not/no/ | 21:31 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add release note for nova-status upgrade check CLI https://review.openstack.org/426911 | 21:31 |
*** slaweq has quit IRC | 21:32 | |
*** slaweq has joined #openstack-nova | 21:32 | |
openstackgerrit | Sarafraj Singh proposed openstack/nova-specs: Send service token along with user tokens https://review.openstack.org/426933 | 21:32 |
*** kfarr has quit IRC | 21:34 | |
*** Jeffrey4l__ has joined #openstack-nova | 21:34 | |
*** rhagarty has joined #openstack-nova | 21:34 | |
*** Jeffrey4l_ has quit IRC | 21:35 | |
*** gouthamr has joined #openstack-nova | 21:35 | |
bauzas | mriedem: dansmith: mmm, I had a thought related to cellsV2 | 21:36 |
bauzas | mriedem: dansmith: given we get the list of compute nodes in the scheduler when not having all the computes being Ocata, it could be a problem if we have more than 1 cell, right? | 21:37 |
bauzas | mriedem: dansmith: I mean, a general ComputeNodeList.get_all() | 21:38 |
*** sdague has quit IRC | 21:38 | |
*** catintheroof has quit IRC | 21:40 | |
*** jose-phillips has quit IRC | 21:41 | |
mriedem | first thing that comes to mind is we aren't supporting multiple cells really in ocata | 21:41 |
mriedem | we don't test it | 21:41 |
mriedem | the scheduler will pull from whichever main database is setup in the nova.conf for the scheduler node | 21:41 |
*** catintheroof has joined #openstack-nova | 21:42 | |
bauzas | mriedem: right, that I know | 21:42 |
mriedem | dansmith: scheduler is global in cells v2 right? | 21:42 |
bauzas | mriedem: I just wanted to explain that we could needing to work on that for Pike | 21:42 |
bauzas | mriedem: that's something we agreed | 21:43 |
*** rtheis has joined #openstack-nova | 21:43 | |
*** rtheis has quit IRC | 21:43 | |
bauzas | mriedem: but for example, I'm writing the nova-status patch, and I need to lookup at the compute nodes to see their ratios | 21:43 |
mriedem | having a list of cellsv2-related things to work on in pike would be good for the ptg etherpad | 21:43 |
bauzas | mriedem: so in a cellsV2 world, I need to lookup all cells | 21:44 |
mriedem | bauzas: then you do it via the cell mappings | 21:44 |
mriedem | there is already a check doing that same type of thing in nova-status | 21:44 |
mriedem | the RPs check | 21:44 |
bauzas | mriedem: yup, that's how we do currently for nova-status | 21:44 |
bauzas | mriedem: I saw that, hence my point above | 21:44 |
bauzas | mriedem: because the scheduler isn't doing that | 21:44 |
mriedem | yeah | 21:45 |
*** satyar has quit IRC | 21:45 | |
bauzas | I mean, we possibly have a lot of things that do ComputeNodeList.get_sth() | 21:45 |
bauzas | in the API at least | 21:45 |
bauzas | for hypervisors | 21:45 |
mriedem | well, this is why we have a caveat in the release notes about things just not working with multiple cells right now | 21:45 |
bauzas | okay, just wanted to make sure we keep that in mind for Pike | 21:45 |
mriedem | put it in the ptg etherpad | 21:45 |
bauzas | ack | 21:46 |
mriedem | https://etherpad.openstack.org/p/nova-ptg-pike | 21:46 |
bauzas | already in my tabs | 21:46 |
bauzas | 50+ | 21:46 |
*** baoli has quit IRC | 21:46 | |
mriedem | L55 and L57 are about cells v2 things - we should just throw those into their own cells v2 topics section | 21:46 |
dansmith | mriedem: yup | 21:46 |
*** timello has quit IRC | 21:46 | |
*** jose-phillips has joined #openstack-nova | 21:47 | |
mriedem | btw, kablammo http://logs.openstack.org/26/426926/1/check/gate-grenade-dsvm-neutron-ubuntu-xenial/04aad64/logs/grenade.sh.txt.gz#_2017-01-30_21_41_51_417 | 21:48 |
mriedem | ah crap | 21:48 |
mriedem | can we start placement before the nova services in grenade? | 21:49 |
mriedem | we should be able to right? | 21:49 |
*** samueldmq has joined #openstack-nova | 21:49 | |
mriedem | i.e. https://review.openstack.org/#/c/424730/18/projects/60_nova/upgrade.sh@86 before start_nova_api | 21:49 |
dansmith | should be able to | 21:49 |
* mriedem tinkers | 21:50 | |
bauzas | where is the gate for that change ? /me looking | 21:50 |
*** abalutoiu has joined #openstack-nova | 21:51 | |
bauzas | arf, still there after 6 hours, wow | 21:51 |
mriedem | ok https://review.openstack.org/#/c/426926/2/projects/60_nova/upgrade.sh | 21:52 |
*** catinthe_ has joined #openstack-nova | 21:52 | |
mriedem | should be fine since that's what the 55_placement was for | 21:52 |
*** tbachman has joined #openstack-nova | 21:52 | |
*** vsaienko has quit IRC | 21:53 | |
*** liangy has quit IRC | 21:53 | |
*** catintheroof has quit IRC | 21:53 | |
*** kaisers has joined #openstack-nova | 21:57 | |
*** armax has quit IRC | 21:57 | |
*** baoli has joined #openstack-nova | 21:58 | |
openstackgerrit | Eric Fried proposed openstack/nova: WIP(5): Introduce base PowerVM driver (ovs vif) https://review.openstack.org/422512 | 21:59 |
*** armax has joined #openstack-nova | 21:59 | |
*** lpetrut has quit IRC | 22:02 | |
*** breitz has quit IRC | 22:03 | |
*** breitz has joined #openstack-nova | 22:03 | |
*** catintheroof has joined #openstack-nova | 22:04 | |
openstackgerrit | Emilien Macchi proposed openstack/nova: DNM - tripleo CI test https://review.openstack.org/426949 | 22:05 |
mriedem | sean-k-mooney: do you know of anything that we need to get into os-vif before creating the stable/ocata branch? http://lists.openstack.org/pipermail/openstack-dev/2017-January/111135.html | 22:05 |
*** eharney has quit IRC | 22:05 | |
*** toure has quit IRC | 22:07 | |
*** catinthe_ has quit IRC | 22:07 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Collected release notes for Ocata CellsV2 https://review.openstack.org/424737 | 22:08 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add release note for nova-status upgrade check CLI https://review.openstack.org/426911 | 22:08 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add prelude section for Ocata https://review.openstack.org/426864 | 22:08 |
*** eglynn has joined #openstack-nova | 22:09 | |
*** foexle has joined #openstack-nova | 22:09 | |
bauzas | mriedem: so, I'm about to leave, but I'll provide the nova-status check tomorrow morning | 22:09 |
mriedem | ok | 22:09 |
bauzas | mriedem: just a quick question, do you think I should use the current _check_placement() method or write a new one? | 22:10 |
mriedem | dansmith: question in https://review.openstack.org/#/c/424737/12/releasenotes/notes/ocata-cellsv2-support-4b3b5e70e76bc756.yaml | 22:10 |
mriedem | bauzas: new one | 22:10 |
bauzas | k | 22:10 |
mriedem | _check_enabled_filters or something | 22:10 |
diana_clarke | "barber-pole sorting", that's new to me | 22:10 |
dansmith | mriedem: I guess it doesn't seem important to me, given that none of the cells stuff is relevant before the upgrade is finished, but I'll say something like "once fully upgraded" or something | 22:12 |
mriedem | wfm, just don't forget to pull the latest version since both myself and bauzas have sullied your original change | 22:13 |
openstackgerrit | Eric Fried proposed openstack/nova: WIP(5): Introduce base PowerVM driver (ovs vif) https://review.openstack.org/422512 | 22:14 |
*** toure has joined #openstack-nova | 22:15 | |
*** Guest48852 has quit IRC | 22:15 | |
*** jose-phillips has quit IRC | 22:17 | |
*** catinthe_ has joined #openstack-nova | 22:17 | |
*** eglynn has quit IRC | 22:18 | |
*** catinth__ has joined #openstack-nova | 22:18 | |
*** catintheroof has quit IRC | 22:18 | |
*** jose-phillips has joined #openstack-nova | 22:19 | |
*** crushil has quit IRC | 22:20 | |
*** catinthe_ has quit IRC | 22:22 | |
mriedem | melwitt: you might have thoughts on https://review.openstack.org/#/c/421420/7 | 22:22 |
melwitt | mriedem: thanks, will look through | 22:23 |
*** crushil has joined #openstack-nova | 22:24 | |
*** tblakes has quit IRC | 22:24 | |
*** tyrola has quit IRC | 22:24 | |
*** tyrola has joined #openstack-nova | 22:25 | |
*** unicell has quit IRC | 22:27 | |
*** foexle has quit IRC | 22:27 | |
*** catinth__ has quit IRC | 22:29 | |
*** Jack_I has quit IRC | 22:30 | |
openstackgerrit | Sarafraj Singh proposed openstack/nova-specs: Send service token along with user tokens https://review.openstack.org/426933 | 22:30 |
*** crushil has quit IRC | 22:31 | |
mriedem | diana_clarke: were you going to address these comments? https://review.openstack.org/#/c/421444/6/doc/source/man/nova-manage.rst | 22:33 |
mriedem | the rest of the series lgtm | 22:33 |
*** edmondsw has quit IRC | 22:34 | |
*** thorst_ has quit IRC | 22:36 | |
*** annegentle has quit IRC | 22:37 | |
*** unicell has joined #openstack-nova | 22:39 | |
*** baoli has quit IRC | 22:40 | |
diana_clarke | mriedem: sorry, I missed that one. I'll circle back tonight and address the feedback from melwitt too. | 22:41 |
mriedem | WHY GOD http://logs.openstack.org/26/426926/2/check/gate-grenade-dsvm-neutron-ubuntu-xenial/8b536f3/logs/grenade.sh.txt.gz#_2017-01-30_22_20_29_466 | 22:44 |
mriedem | oh sorry god, i know why | 22:45 |
*** armax has quit IRC | 22:49 | |
openstackgerrit | Eric Fried proposed openstack/nova: WIP(5): Introduce base PowerVM driver (ovs vif) https://review.openstack.org/422512 | 22:51 |
*** armax has joined #openstack-nova | 22:51 | |
*** jamesdenton has quit IRC | 22:51 | |
*** marst has quit IRC | 22:53 | |
mriedem | artom: you want to address the nits in https://review.openstack.org/#/c/424759/ or shall i? | 22:55 |
*** slaweq has quit IRC | 22:56 | |
*** Swami_ has joined #openstack-nova | 22:56 | |
*** Swami has quit IRC | 22:56 | |
*** slaweq has joined #openstack-nova | 22:58 | |
*** Swami_ has quit IRC | 23:00 | |
*** slaweq has quit IRC | 23:02 | |
*** slaweq has joined #openstack-nova | 23:04 | |
*** unicell has quit IRC | 23:05 | |
*** thorst_ has joined #openstack-nova | 23:06 | |
*** tbachman has quit IRC | 23:07 | |
*** ircuser-1 has quit IRC | 23:08 | |
*** mriedem has quit IRC | 23:10 | |
*** thorst_ has quit IRC | 23:10 | |
*** mdrabe has quit IRC | 23:11 | |
*** kuzko has quit IRC | 23:13 | |
*** kuzko has joined #openstack-nova | 23:14 | |
*** unicell has joined #openstack-nova | 23:14 | |
*** ircuser-1 has joined #openstack-nova | 23:20 | |
*** ircuser-1 has quit IRC | 23:21 | |
*** ducttape_ has quit IRC | 23:21 | |
*** dtp has joined #openstack-nova | 23:23 | |
*** armax has quit IRC | 23:29 | |
*** armax has joined #openstack-nova | 23:30 | |
*** armax has quit IRC | 23:31 | |
*** claudiub has quit IRC | 23:32 | |
*** Swami_ has joined #openstack-nova | 23:33 | |
*** Swami has joined #openstack-nova | 23:33 | |
*** Swami__ has joined #openstack-nova | 23:33 | |
*** jaypipes has quit IRC | 23:34 | |
*** sileht has quit IRC | 23:37 | |
*** armax has joined #openstack-nova | 23:39 | |
*** tbachman has joined #openstack-nova | 23:41 | |
*** sileht has joined #openstack-nova | 23:41 | |
*** xinli has quit IRC | 23:41 | |
openstackgerrit | melanie witt proposed openstack/nova: Detach volume after deleting instance with no host https://review.openstack.org/340614 | 23:42 |
*** kuzko has quit IRC | 23:44 | |
*** xyang1 has quit IRC | 23:44 | |
*** jamesdenton has joined #openstack-nova | 23:45 | |
*** kuzko has joined #openstack-nova | 23:45 | |
*** gouthamr has quit IRC | 23:49 | |
*** catintheroof has joined #openstack-nova | 23:50 | |
*** Swami_ has quit IRC | 23:52 | |
*** Swami has quit IRC | 23:52 | |
*** Swami has joined #openstack-nova | 23:53 | |
*** baoli has joined #openstack-nova | 23:55 | |
*** dimtruck is now known as zz_dimtruck | 23:57 | |
*** jamielennox is now known as jamielennox|away | 23:58 | |
*** jamielennox|away is now known as jamielennox | 23:59 | |
*** tbachman has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!