*** zz_dimtruck is now known as dimtruck | 00:00 | |
*** ducttape_ has quit IRC | 00:00 | |
*** ducttape_ has joined #openstack-nova | 00:01 | |
*** ducttape_ has joined #openstack-nova | 00:02 | |
*** ducttape_ has quit IRC | 00:02 | |
*** ducttape_ has joined #openstack-nova | 00:02 | |
*** owalsh_ has joined #openstack-nova | 00:02 | |
*** diga has joined #openstack-nova | 00:03 | |
*** owalsh_ has quit IRC | 00:04 | |
*** owalsh-afk has quit IRC | 00:04 | |
*** owalsh-afk has joined #openstack-nova | 00:05 | |
*** owalsh-afk has quit IRC | 00:05 | |
*** jaypipes has quit IRC | 00:14 | |
*** raunak has joined #openstack-nova | 00:16 | |
*** snikitin has joined #openstack-nova | 00:19 | |
*** gaoyuan has joined #openstack-nova | 00:19 | |
*** owalsh has quit IRC | 00:21 | |
*** owalsh has joined #openstack-nova | 00:22 | |
*** gaoyuan has quit IRC | 00:24 | |
*** salv-orlando has quit IRC | 00:31 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754 | 00:31 |
---|---|---|
openstackgerrit | Dan Smith proposed openstack/nova master: Make scheduler target cells to get compute node instance info https://review.openstack.org/439891 | 00:31 |
openstackgerrit | Dan Smith proposed openstack/nova master: Remove Mitaka-era service version check https://review.openstack.org/442861 | 00:31 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736 | 00:31 |
*** catintheroof has quit IRC | 00:31 | |
*** tovin07 has joined #openstack-nova | 00:33 | |
*** tovin07_ has joined #openstack-nova | 00:34 | |
*** lucas-afk has quit IRC | 00:34 | |
*** lucasagomes has joined #openstack-nova | 00:37 | |
*** iceyao has joined #openstack-nova | 00:38 | |
*** hongbin has quit IRC | 00:39 | |
*** jamielennox is now known as jamielennox|away | 00:41 | |
*** dimtruck is now known as zz_dimtruck | 00:41 | |
*** namnh has joined #openstack-nova | 00:43 | |
*** jamielennox|away is now known as jamielennox | 00:44 | |
*** edleafe- has joined #openstack-nova | 00:44 | |
*** edleafe has quit IRC | 00:46 | |
*** zsli has joined #openstack-nova | 00:47 | |
*** lucasagomes has quit IRC | 00:48 | |
*** lucasagomes has joined #openstack-nova | 00:50 | |
*** erhudy has quit IRC | 00:50 | |
openstackgerrit | Li Yingjun proposed openstack/nova-specs master: Spec for support set vgamem for video https://review.openstack.org/438787 | 00:59 |
*** tovin07_ has quit IRC | 00:59 | |
*** liangy has quit IRC | 01:00 | |
*** ssurana has joined #openstack-nova | 01:01 | |
*** salv-orlando has joined #openstack-nova | 01:01 | |
*** liverpooler has quit IRC | 01:04 | |
*** zz_dimtruck is now known as dimtruck | 01:05 | |
*** salv-orlando has quit IRC | 01:06 | |
*** esberglu has quit IRC | 01:07 | |
*** esberglu has joined #openstack-nova | 01:10 | |
*** esberglu has quit IRC | 01:10 | |
*** mtanino has quit IRC | 01:11 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged nic attachment https://review.openstack.org/415622 | 01:14 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete nic metadata when detaching interface https://review.openstack.org/435387 | 01:14 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Libvirt support for tagged volume attachment https://review.openstack.org/418100 | 01:14 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082 | 01:14 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged volume attachment https://review.openstack.org/391941 | 01:14 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021 | 01:14 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Libvirt support for tagged nic attachment https://review.openstack.org/415520 | 01:14 |
*** zhurong has joined #openstack-nova | 01:16 | |
*** zsli_ has joined #openstack-nova | 01:22 | |
*** zsli has quit IRC | 01:24 | |
*** Daisy has joined #openstack-nova | 01:28 | |
*** crushil has joined #openstack-nova | 01:28 | |
*** mlavalle has quit IRC | 01:30 | |
*** diga has quit IRC | 01:36 | |
*** markmcclain has quit IRC | 01:37 | |
*** gaoyuan has joined #openstack-nova | 01:38 | |
*** kevinz has joined #openstack-nova | 01:42 | |
*** yuntongjin has joined #openstack-nova | 01:42 | |
*** gcb has joined #openstack-nova | 01:45 | |
*** gongysh has joined #openstack-nova | 01:49 | |
*** owalsh has quit IRC | 01:50 | |
*** raunak has quit IRC | 01:56 | |
*** owalsh has joined #openstack-nova | 01:57 | |
*** thorst has quit IRC | 01:58 | |
*** dimtruck is now known as zz_dimtruck | 01:58 | |
*** owalsh has quit IRC | 02:00 | |
*** owalsh has joined #openstack-nova | 02:00 | |
*** ayogi has joined #openstack-nova | 02:02 | |
*** phuongnh has joined #openstack-nova | 02:02 | |
*** salv-orlando has joined #openstack-nova | 02:02 | |
*** ssurana has quit IRC | 02:04 | |
*** Daisy_ has joined #openstack-nova | 02:04 | |
*** salv-orlando has quit IRC | 02:07 | |
*** Daisy__ has joined #openstack-nova | 02:07 | |
*** Daisy has quit IRC | 02:08 | |
openstackgerrit | Maho Koshiya proposed openstack/nova master: Add interfaces functional negative tests https://review.openstack.org/442892 | 02:11 |
*** Daisy_ has quit IRC | 02:11 | |
*** ayogi has quit IRC | 02:11 | |
*** tuanluong has joined #openstack-nova | 02:13 | |
*** yuntongjin has quit IRC | 02:19 | |
*** zsli__ has joined #openstack-nova | 02:19 | |
*** thorst has joined #openstack-nova | 02:21 | |
*** zsli_ has quit IRC | 02:22 | |
*** thorst has quit IRC | 02:23 | |
alex_xu | dansmith: sort by 'uuid' is for stable sort result, since the 'project_id' isn't unique value. at least we should keep the sort result stable. | 02:24 |
alex_xu | dansmith: looks like CellMappingList.get_all have problem, it haven't any specific sort key | 02:24 |
alex_xu | so the result can be unstable | 02:24 |
*** zsli_ has joined #openstack-nova | 02:24 | |
dansmith | alex_xu: it'll be stable, but not guaranteed | 02:24 |
alex_xu | dansmith: yes, but better to have a specific sort key? | 02:25 |
dansmith | alex_xu: but sure we can make cellmapping sort explicitly | 02:25 |
alex_xu | dansmith: yea | 02:25 |
dansmith | alex_xu: we can.. cells don't get created and destroyed, so I don't think it's a problem, but it's a trivial amount of small data to sort, so we can do that too | 02:25 |
dansmith | alex_xu: will you say that on the review and I'll follow up tomorrow with a separate patch for that? | 02:26 |
alex_xu | dansmith: yea, I will comment on teh review | 02:26 |
*** Daisy__ has quit IRC | 02:27 | |
*** yuntongjin has joined #openstack-nova | 02:27 | |
*** erlon has joined #openstack-nova | 02:27 | |
*** zsli__ has quit IRC | 02:28 | |
*** Daisy has joined #openstack-nova | 02:28 | |
dansmith | alex_xu: cool thanks | 02:28 |
alex_xu | dansmith: np | 02:28 |
*** gaoyuan has quit IRC | 02:36 | |
*** Apoorva has quit IRC | 02:39 | |
*** Apoorva has joined #openstack-nova | 02:40 | |
*** Apoorva has quit IRC | 02:41 | |
*** owalsh has quit IRC | 02:45 | |
*** owalsh has joined #openstack-nova | 02:45 | |
*** diana_clarke has joined #openstack-nova | 02:52 | |
diana_clarke | dansmith: Do you know the history behind limit/offset vs limit/marker? | 02:54 |
*** haplo37 has quit IRC | 02:54 | |
*** amotoki has quit IRC | 02:54 | |
*** owalsh has quit IRC | 02:55 | |
*** liangy has joined #openstack-nova | 02:55 | |
*** amotoki has joined #openstack-nova | 02:56 | |
*** ijw has quit IRC | 02:57 | |
*** owalsh has joined #openstack-nova | 02:59 | |
*** amotoki has quit IRC | 03:01 | |
*** hongbin has joined #openstack-nova | 03:01 | |
*** haplo37 has joined #openstack-nova | 03:02 | |
*** raunak has joined #openstack-nova | 03:03 | |
*** salv-orlando has joined #openstack-nova | 03:03 | |
*** tovin07_ has joined #openstack-nova | 03:03 | |
*** tbachman has quit IRC | 03:04 | |
*** ducttape_ has quit IRC | 03:07 | |
openstackgerrit | Vladik Romanovsky proposed openstack/nova master: libvirt: add video config parse method https://review.openstack.org/442914 | 03:08 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova master: libvirt: a method to prepare SPICE console connection https://review.openstack.org/442915 | 03:08 |
*** salv-orlando has quit IRC | 03:08 | |
dansmith | diana_clarke: I don't even know that there's history there, so.. no? | 03:13 |
*** zz_dimtruck is now known as dimtruck | 03:17 | |
diana_clarke | dansmith: I'm curious why there was a switch at some point to marker vs. offset. That is, the problem that shift was trying to solve at the expense of an easier API. | 03:17 |
diana_clarke | (I just followed the pattern) | 03:17 |
diana_clarke | Off the top of my head, I can't think of another API that uses markers (over offsets). | 03:20 |
dansmith | diana_clarke: I'm not aware of any shift from offset to marker, so it may have been before my time (or at least before I started paying attention) | 03:20 |
*** liangy has quit IRC | 03:21 | |
diana_clarke | dansmith: Welp, recent code uses markers, older code uses markers (that's all I know). | 03:21 |
diana_clarke | typo: older code uses _offsets__ | 03:22 |
*** thorst has joined #openstack-nova | 03:24 | |
dansmith | really? what older code uses offsets? | 03:24 |
*** hongbin has quit IRC | 03:24 | |
*** hongbin has joined #openstack-nova | 03:25 | |
dansmith | I see mention of offsets in openstack/api/common, but that's pretty new code, AFAIK | 03:25 |
dansmith | unless it was just transplanted from somewhere, but I thought all the original pagination was done in db where I see no offsets | 03:27 |
dansmith | but anyway, I dunno :) | 03:28 |
*** thorst has quit IRC | 03:28 | |
*** liangy has joined #openstack-nova | 03:29 | |
*** oomichi has quit IRC | 03:30 | |
*** oomichi has joined #openstack-nova | 03:33 | |
alex_xu | dansmith: https://review.openstack.org/#/c/441388/7/nova/api/openstack/compute/simple_tenant_usage.py a comment about optimize the marker | 03:35 |
dansmith | alex_xu: responding now | 03:35 |
dansmith | alex_xu: were you going to comment on the sorting thing too | 03:35 |
dansmith | ? | 03:35 |
alex_xu | dansmith: yea, I added comment in the PS6 | 03:35 |
dansmith | alex_xu: ah I see now, thanks | 03:36 |
*** nic has quit IRC | 03:36 | |
alex_xu | dansmith: np | 03:36 |
dansmith | alex_xu: here is the other one of the pattern: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2548 | 03:37 |
alex_xu | dansmith: yes, i'm ok to optimize that in later patch. I just follow a -1 since Matt already -1, to earn a point :) | 03:38 |
dansmith | haha | 03:38 |
dansmith | alex_xu: you're a pro now :) | 03:38 |
alex_xu | yea \o/ | 03:38 |
dansmith | :) | 03:38 |
*** hongbin_ has joined #openstack-nova | 03:42 | |
*** diana_clarke has left #openstack-nova | 03:44 | |
*** hongbin has quit IRC | 03:44 | |
*** sdague has joined #openstack-nova | 03:46 | |
*** diga has joined #openstack-nova | 03:49 | |
*** Daisy has quit IRC | 03:51 | |
*** Daisy has joined #openstack-nova | 03:52 | |
*** diga_ has joined #openstack-nova | 03:54 | |
*** hongbin has joined #openstack-nova | 03:54 | |
*** hongbin_ has quit IRC | 03:55 | |
*** diga has quit IRC | 03:55 | |
*** amotoki has joined #openstack-nova | 03:56 | |
*** Daisy has quit IRC | 03:56 | |
*** haplo37 has quit IRC | 03:58 | |
*** haplo37 has joined #openstack-nova | 03:59 | |
*** thorst has joined #openstack-nova | 04:00 | |
*** gouthamr has quit IRC | 04:00 | |
*** amotoki has quit IRC | 04:01 | |
*** fragatin_ has joined #openstack-nova | 04:01 | |
*** namnh has quit IRC | 04:01 | |
*** zhurong has quit IRC | 04:01 | |
*** yamahata has quit IRC | 04:02 | |
*** thorst has quit IRC | 04:03 | |
*** fragatina has quit IRC | 04:04 | |
*** salv-orlando has joined #openstack-nova | 04:04 | |
*** zsli__ has joined #openstack-nova | 04:05 | |
*** fragatina has joined #openstack-nova | 04:05 | |
*** fragatin_ has quit IRC | 04:05 | |
*** sridharg has joined #openstack-nova | 04:07 | |
*** zsli_ has quit IRC | 04:07 | |
*** ducttape_ has joined #openstack-nova | 04:09 | |
*** mdnadeem has joined #openstack-nova | 04:09 | |
*** salv-orlando has quit IRC | 04:09 | |
*** fragatina has quit IRC | 04:09 | |
*** hongbin_ has joined #openstack-nova | 04:12 | |
*** ducttape_ has quit IRC | 04:13 | |
*** hongbin has quit IRC | 04:16 | |
*** psachin has joined #openstack-nova | 04:18 | |
*** nicolasbock has quit IRC | 04:19 | |
*** zsli_ has joined #openstack-nova | 04:24 | |
*** amotoki has joined #openstack-nova | 04:24 | |
*** sdague has quit IRC | 04:26 | |
*** zsli has joined #openstack-nova | 04:26 | |
*** zsli__ has quit IRC | 04:26 | |
*** zsli_ has quit IRC | 04:28 | |
*** hongbin_ has quit IRC | 04:30 | |
*** udesale has joined #openstack-nova | 04:31 | |
openstackgerrit | Akira KAMIO proposed openstack/nova master: Replace root volume during rebuild https://review.openstack.org/442295 | 04:39 |
*** youzp has joined #openstack-nova | 04:40 | |
*** links has joined #openstack-nova | 04:41 | |
*** zsli has quit IRC | 04:43 | |
*** zsli has joined #openstack-nova | 04:44 | |
*** mtanino has joined #openstack-nova | 04:45 | |
*** gcb has quit IRC | 04:47 | |
*** gcb has joined #openstack-nova | 04:48 | |
*** iceyao has quit IRC | 04:53 | |
*** zsli has quit IRC | 04:53 | |
*** zsli has joined #openstack-nova | 04:54 | |
*** zsli has quit IRC | 04:55 | |
*** guchihiro has joined #openstack-nova | 04:55 | |
*** crushil has quit IRC | 04:57 | |
*** adisky_ has joined #openstack-nova | 04:58 | |
*** prateek has joined #openstack-nova | 04:59 | |
*** zsli has joined #openstack-nova | 05:00 | |
*** trinaths has joined #openstack-nova | 05:00 | |
*** zsli has quit IRC | 05:02 | |
*** zsli has joined #openstack-nova | 05:03 | |
*** thorst has joined #openstack-nova | 05:04 | |
*** erlon has quit IRC | 05:05 | |
*** salv-orlando has joined #openstack-nova | 05:05 | |
*** zsli has quit IRC | 05:08 | |
*** ducttape_ has joined #openstack-nova | 05:09 | |
*** salv-orlando has quit IRC | 05:09 | |
*** unicell has joined #openstack-nova | 05:10 | |
*** liangy has quit IRC | 05:11 | |
*** ducttape_ has quit IRC | 05:14 | |
*** ayogi has joined #openstack-nova | 05:15 | |
*** iceyao has joined #openstack-nova | 05:18 | |
cfriesen | alex_xu: you on? | 05:18 |
*** youzp has quit IRC | 05:18 | |
*** thorst has quit IRC | 05:19 | |
*** edmondsw has joined #openstack-nova | 05:20 | |
*** iceyao has quit IRC | 05:23 | |
*** trinaths1 has joined #openstack-nova | 05:23 | |
*** trinaths has quit IRC | 05:23 | |
*** edmondsw has quit IRC | 05:25 | |
openstackgerrit | Chris Friesen proposed openstack/nova-specs master: add spec for instance flavor API https://review.openstack.org/265282 | 05:25 |
*** Shunli has joined #openstack-nova | 05:29 | |
openstackgerrit | Chris Friesen proposed openstack/nova-specs master: Support Instance Rebuild With Userdata https://review.openstack.org/431052 | 05:29 |
*** yamahata has joined #openstack-nova | 05:30 | |
*** gongysh has quit IRC | 05:31 | |
*** gongysh has joined #openstack-nova | 05:32 | |
*** tbachman has joined #openstack-nova | 05:38 | |
*** Shunli has quit IRC | 05:41 | |
*** Daisy has joined #openstack-nova | 05:43 | |
*** fragatina has joined #openstack-nova | 05:46 | |
*** fragatin_ has joined #openstack-nova | 05:48 | |
*** fragatina has quit IRC | 05:51 | |
*** unicell has quit IRC | 05:52 | |
*** mdnadeem has quit IRC | 05:52 | |
*** fragatin_ has quit IRC | 05:52 | |
*** ratailor has joined #openstack-nova | 05:54 | |
*** mdnadeem has joined #openstack-nova | 05:54 | |
*** yuntongjin has quit IRC | 05:56 | |
*** yuntongjin has joined #openstack-nova | 05:59 | |
*** claudiub|2 has joined #openstack-nova | 06:00 | |
*** yamamoto_ has joined #openstack-nova | 06:01 | |
openstackgerrit | kavitha h r proposed openstack/os-vif master: The Python 3.5 is added https://review.openstack.org/442955 | 06:01 |
*** salv-orlando has joined #openstack-nova | 06:06 | |
*** ducttape_ has joined #openstack-nova | 06:10 | |
*** salv-orlando has quit IRC | 06:11 | |
*** Shunli has joined #openstack-nova | 06:13 | |
*** zsli_ has joined #openstack-nova | 06:15 | |
*** ducttape_ has quit IRC | 06:15 | |
*** zsli__ has joined #openstack-nova | 06:16 | |
*** nkrinner_afk is now known as nkrinner | 06:16 | |
*** thorst has joined #openstack-nova | 06:16 | |
*** lpetrut has joined #openstack-nova | 06:17 | |
*** Shunli has quit IRC | 06:17 | |
*** zsli_ has quit IRC | 06:20 | |
*** thorst has quit IRC | 06:20 | |
*** zsli__ has quit IRC | 06:20 | |
*** Daisy has quit IRC | 06:21 | |
*** gcb has quit IRC | 06:21 | |
*** gcb has joined #openstack-nova | 06:22 | |
*** Shunli has joined #openstack-nova | 06:23 | |
*** ekuris has joined #openstack-nova | 06:24 | |
*** zsli_ has joined #openstack-nova | 06:25 | |
*** fengzhr has joined #openstack-nova | 06:28 | |
*** satyar has joined #openstack-nova | 06:31 | |
*** zsli__ has joined #openstack-nova | 06:34 | |
alex_xu | cfriesen: yes | 06:34 |
*** zsli__ has quit IRC | 06:34 | |
openstackgerrit | Akira KAMIO proposed openstack/nova master: Replace root volume during rebuild https://review.openstack.org/442295 | 06:35 |
*** zsli__ has joined #openstack-nova | 06:35 | |
*** zsli_ has quit IRC | 06:35 | |
*** yamamoto_ has quit IRC | 06:36 | |
*** salv-orlando has joined #openstack-nova | 06:37 | |
*** armax has quit IRC | 06:40 | |
*** zsli__ has quit IRC | 06:40 | |
*** armax has joined #openstack-nova | 06:40 | |
*** armax has quit IRC | 06:41 | |
*** zsli__ has joined #openstack-nova | 06:41 | |
*** pcaruana has joined #openstack-nova | 06:43 | |
*** zsli_ has joined #openstack-nova | 06:46 | |
*** zsli__ has quit IRC | 06:48 | |
*** zsli__ has joined #openstack-nova | 06:50 | |
*** zsli_ has quit IRC | 06:52 | |
*** Shunli has joined #openstack-nova | 06:52 | |
*** Shunli has quit IRC | 06:53 | |
cfriesen | alex_xu: if you're still here...I made some comments on https://review.openstack.org/#/c/265282 Also, it occurs to me that the "resize" command currently returns the flavorid. Should we keep that (since it shouldn't be stale)? | 06:54 |
*** markvoelker has quit IRC | 06:54 | |
*** zsli__ has quit IRC | 06:54 | |
*** raunak has quit IRC | 06:55 | |
*** Shunli has joined #openstack-nova | 06:55 | |
alex_xu | cfriesen: yea, i'm here. I'm good with your reply, but i guess you misse done https://review.openstack.org/#/c/265282/5/specs/pike/approved/instance-flavor-api.rst@131 | 06:55 |
alex_xu | s/done/one | 06:55 |
alex_xu | cfriesen: for resize, let me check | 06:55 |
cfriesen | whoops, right. will check the rxtx_factor | 06:57 |
alex_xu | cfriesen: currently we didn't have response from resize | 06:57 |
alex_xu | cfriesen: and...as I remember, you are in Canada...why you are still wakeup | 06:58 |
cfriesen | it's 1am and I'm still up. :) | 06:58 |
alex_xu | cfriesen: ok :) | 06:58 |
cfriesen | server-action-resize.json.tpl has "flavorRef" which is the Flavor.flavorid | 06:59 |
alex_xu | cfriesen: that is request | 06:59 |
alex_xu | the name of that sample file didn't clear about the request/response | 06:59 |
cfriesen | whoops, you are correct. | 06:59 |
cfriesen | good, less work | 06:59 |
*** zsli_ has joined #openstack-nova | 06:59 | |
*** Shunli has quit IRC | 06:59 | |
alex_xu | heh | 07:00 |
cfriesen | looks like there is some policy around rxtx_factor...checking deeper | 07:00 |
*** arne_r has joined #openstack-nova | 07:00 | |
alex_xu | cfriesen: https://github.com/openstack/nova/blob/master/nova/policies/flavor_rxtx.py#L21 | 07:01 |
*** markus_z has joined #openstack-nova | 07:01 | |
*** zsli_ has quit IRC | 07:02 | |
*** diga_ has quit IRC | 07:02 | |
*** zsli_ has joined #openstack-nova | 07:02 | |
cfriesen | alex_xu: looks like "os_compute_api:os-flavor-rxtx" applies to show/detail, so it should probably affect the flavor details embedded in the server too | 07:04 |
alex_xu | cfriesen: yea | 07:04 |
cfriesen | okay, I'll update the spec | 07:05 |
alex_xu | cfriesen: thanks | 07:05 |
*** zsli_ has quit IRC | 07:06 | |
*** Qiming has joined #openstack-nova | 07:10 | |
Qiming | alex_xu, there? | 07:11 |
alex_xu | Qiming: yea | 07:11 |
*** lpetrut has quit IRC | 07:11 | |
*** ducttape_ has joined #openstack-nova | 07:11 | |
Qiming | nova api is behaving strangely regarding micro-version | 07:11 |
*** Oku_OS-away is now known as Oku_OS | 07:12 | |
alex_xu | Qiming: which case you pointed to? | 07:12 |
Qiming | I'm trying to get the user_data I set to an instance | 07:12 |
Qiming | this is only available from 2.3 api | 07:12 |
Qiming | according to api-ref | 07:13 |
*** Shunli has joined #openstack-nova | 07:13 | |
alex_xu | yea | 07:13 |
Qiming | btw, in the doc, "OS-EXT-SERV-ATTR:user_data" should be "OS-EXT-SRV-ATTR:user_data", that is a typo | 07:13 |
Qiming | not the key issue I want to raise here | 07:13 |
alex_xu | Qiming: but thanks btw | 07:14 |
*** zsli_ has joined #openstack-nova | 07:14 | |
Qiming | when I tried 'curl -H 'openstack-api-version: compute 2.3' .... I can get the response with "OS-EXT-SRV-ATTR:user_data" returned | 07:14 |
openstackgerrit | Chris Friesen proposed openstack/nova-specs master: add spec for instance flavor API https://review.openstack.org/265282 | 07:14 |
alex_xu | yea | 07:15 |
Qiming | when I tried openstackclient with --os-compute-api 2.3 --debug, this field and other fields added since 2.3 are missing | 07:15 |
*** zsli_ has quit IRC | 07:15 | |
alex_xu | Qiming: i don't openstackclient support microvresion now | 07:15 |
alex_xu | s/i don't/i don't think/ | 07:16 |
*** ducttape_ has quit IRC | 07:16 | |
Qiming | em... nova responded this in the header: Content-Length: 1464 Content-Type: application/json Openstack-Api-Version: compute 2.3 X-Openstack-Nova-Api-Version: 2.3 Vary: OpenStack-API-Version, X-OpenStack-Nova-API-Version X-Compute-Request-Id: req-efc2a8c9-b37b-43e9-a170-73e1658b3177 Date: Wed, 08 Mar 2017 07:16:20 GMT Connection: keep-alive | 07:17 |
*** thorst has joined #openstack-nova | 07:17 | |
Qiming | this means ... it should work, right? | 07:17 |
*** Shunli has quit IRC | 07:17 | |
alex_xu | Qiming: yes...that means OSC request 2.3, and the server response with 2.3 | 07:18 |
alex_xu | Qiming: but I'm not sure OSC handle 2.3 in the CLI display | 07:18 |
Qiming | so I think nova-api understands the micro-version api request properly | 07:18 |
Qiming | I don't care about the CLI output, so I turned on --debug, I want to check the raw response body | 07:19 |
alex_xu | Qiming: there is talk about implement microversion OSC, so i think OSC didn't implement that | 07:19 |
alex_xu | Qiming: no new fields in the raw response body? | 07:19 |
Qiming | yup | 07:19 |
*** iceyao has joined #openstack-nova | 07:19 | |
alex_xu | strange, let me check | 07:19 |
*** andreas_s has joined #openstack-nova | 07:19 | |
Qiming | so I am here complaining to you, instead of complaining in another channel | 07:20 |
Qiming | I was suspecting that nova-api treats 'User-Agent' header in different (buggy) ways | 07:20 |
Qiming | but that is not true | 07:21 |
Qiming | I was doubting the 'X-Auth-Token' is causing some problems ... seems that is relevant | 07:21 |
*** thorst has quit IRC | 07:21 | |
Qiming | If I'm passing token in this format: -H "X-Auth-Token: {SHA1}e216eff934c3484e8bc2cf1642c736e215c8c369" | 07:22 |
alex_xu | Qiming: Openstack-API-Version header returned, that means nova-api already know the requested version | 07:22 |
Qiming | I can never get the fields from the response | 07:22 |
alex_xu | emm... | 07:22 |
alex_xu | Qiming: By curl | 07:22 |
alex_xu | ? | 07:22 |
Qiming | if I'm passing token in this way: 'X-Auth-Token: 6c9bce0e3a514ad7981fa03f990e5cfc' | 07:23 |
Qiming | I can get the correct result | 07:23 |
Qiming | see the difference? | 07:23 |
alex_xu | Qiming: I guess you can't pass taken with hash token by curl | 07:23 |
*** salv-orl_ has joined #openstack-nova | 07:23 | |
*** yamamoto_ has joined #openstack-nova | 07:23 | |
*** lpetrut has joined #openstack-nova | 07:23 | |
Qiming | that is what I'm seeing from the keystoneauth1 log | 07:23 |
*** iceyao has quit IRC | 07:24 | |
alex_xu | Qiming: the hash is done by the keystoneauth, for hide the secret thing. if you paste that into the curl, you can't pass the auth | 07:24 |
Qiming | yes, I realized that | 07:24 |
Qiming | I was comparing the ways requests are sent from OSC and from cURL | 07:25 |
Qiming | I believe you can reproduce this easily? | 07:25 |
alex_xu | Qiming: yea, i'm trying | 07:26 |
*** salv-orlando has quit IRC | 07:26 | |
Qiming | thanks! | 07:26 |
*** rmk has quit IRC | 07:27 | |
arne_r | If someone could help me get this change into newton, newton is broken on our system without it: https://review.openstack.org/#/c/436868/ | 07:28 |
openstackgerrit | jichenjc proposed openstack/nova master: Clean up metadata param in doc https://review.openstack.org/442981 | 07:28 |
*** eliqiao has quit IRC | 07:29 | |
*** tanee_away is now known as tanee | 07:29 | |
alex_xu | Qiming: your command like this "openstack --os-compute-api-version 2.3 --debug server show 940562c1-71c6-4dcf-83be-eeb2a22b5ca0"? | 07:29 |
Qiming | yep | 07:30 |
alex_xu | Qiming: I can see... the user_data field | 07:30 |
*** eliqiao has joined #openstack-nova | 07:30 | |
*** youzp has joined #openstack-nova | 07:30 | |
Qiming | oh? what's your magic? | 07:31 |
alex_xu | Qiming: both from the cli display and raw data | 07:31 |
* Qiming is feeling very unhappy | 07:32 | |
alex_xu | Qiming: can you sure you request is send to a v2.1 endpoint, not the legacy v2 endpoint | 07:32 |
*** ltomasbo|away is now known as ltomasbo | 07:32 | |
Qiming | from debug log, I can see the request sent (by OSC) this way: curl -g -i -X GET http://192.168.42.11:8774/v2.1/servers/59a17d5a-c27a-4301-b6f2-19dd128f24df -H "openstack-api-version: compute 2.3" -H "User-Agent: openstacksdk/0.9.14 keystoneauth1/2.18.0 python-requests/2.12.4 CPython/2.7.12" -H "X-Auth-Token: {SHA1}e216eff934c3484e8bc2cf1642c736e215c8c369" | 07:32 |
alex_xu | Qiming: looks like it is 2.1 endpoint | 07:33 |
alex_xu | my one is same "curl -g -i -X GET http://hp-pc:8774/v2.1/servers/940562c1-71c6-4dcf-83be-eeb2a22b5ca0 -H "User-Agent: python-novaclient" -H "Accept: application/json" -H "X-OpenStack-Nova-API-Version: 2.3" -H "X-Auth-Token: | 07:33 |
alex_xu | gAAAAABYv7cy3iWBliuTe8Htsg6-G8bMGJPYMAAW2H55dUBMOYuNzh-uP5o5p0DqxymiA6qqaBAdNPp1bRtJmN9Vv7q_cnDVAxk3nuSA4B_1d0v4opEl3EIWwMvT1SbDlFpwIVcAONtXfz5iV_pA86ZtKqgttDuCuzwb5CA1dQ7iKXpUCufTo0s"" | 07:33 |
alex_xu | Qiming: why my agent is python-novaclient? | 07:34 |
Qiming | em, you token is not hashed | 07:34 |
alex_xu | Qiming: i have a modified version of keystoneauth | 07:34 |
alex_xu | i hack the code directly... | 07:34 |
Qiming | your osc version? | 07:35 |
alex_xu | Qiming: 3.8.1 | 07:35 |
openstackgerrit | Alin Balutoiu proposed openstack/os-vif master: vif_plug_ovs: Skip setting MTU on Windows when plugging devices https://review.openstack.org/441855 | 07:36 |
Qiming | my command dump: curl -g -i -X GET http://192.168.42.11:8774/v2.1/servers/59a17d5a-c27a-4301-b6f2-19dd128f24df -H "User-Agent: python-novaclient" -H "Accept: application/json" -H "X-OpenStack-Nova-API-Version: 2.3" -H "X-Auth-Token: {SHA1}104a24f12ee85b77464fc36037dccbf5cf2beb45" | 07:37 |
alex_xu | Qiming: that looks same | 07:38 |
Qiming | so ... the responses differ if token is provided in different ways? | 07:38 |
alex_xu | Qiming: i don't think so, I just hack the code to not hide the real token in the log | 07:39 |
alex_xu | Qiming: the client pass the real token not the hash one. the hashed token is only for the log | 07:40 |
*** rcernin has joined #openstack-nova | 07:40 | |
Qiming | alright | 07:40 |
Qiming | alex_xu, keystoneauth version? | 07:40 |
alex_xu | Qiming: can you paste your raw response | 07:40 |
alex_xu | Qiming: 2.18.0 | 07:41 |
Qiming | alex_xu, http://paste.openstack.org/show/601879/ | 07:41 |
Qiming | alex_xu, keystoneauth version match | 07:43 |
*** tesseract has joined #openstack-nova | 07:43 | |
alex_xu | Qiming: do you have modified api-paste.ini for nova? | 07:43 |
Qiming | no | 07:43 |
Qiming | but my nova version is ... very old | 07:43 |
alex_xu | Qiming: paste your api-paste.ini to me? | 07:44 |
Qiming | alex_xu, http://paste.openstack.org/show/601881/ | 07:45 |
openstackgerrit | zhaolihui proposed openstack/nova master: Fix keypair quota error https://review.openstack.org/403529 | 07:46 |
openstackgerrit | jichenjc proposed openstack/nova master: remove a TODO as all set for tags https://review.openstack.org/442984 | 07:46 |
*** diga has joined #openstack-nova | 07:47 | |
*** youzp has quit IRC | 07:47 | |
alex_xu | Qiming: are you using admin user in OSC? | 07:47 |
openstackgerrit | Hidekazu Nakamura proposed openstack/nova master: Do not attempt volume swap when guest is stopped https://review.openstack.org/389798 | 07:48 |
Qiming | no, I have all kinds of admins | 07:48 |
Qiming | s/have/hate | 07:48 |
alex_xu | Qiming: looks like the fields added by 2.3 only can seeable for admin user | 07:49 |
Qiming | what?! | 07:49 |
*** tbachman has quit IRC | 07:49 | |
Qiming | lemme check | 07:49 |
alex_xu | Qiming: just ensure that, it only expose to admin user | 07:50 |
*** jaosorior has joined #openstack-nova | 07:50 | |
Qiming | nonono | 07:51 |
*** jlvillal has quit IRC | 07:51 | |
Qiming | a user with admin role suffice | 07:51 |
alex_xu | Qiming: yes | 07:52 |
alex_xu | but the admin role in the nova is equal to super admin, there is only one global admin | 07:52 |
Qiming | 1 min | 07:52 |
Qiming | you are right ... | 07:53 |
alex_xu | Qiming: :) | 07:53 |
Qiming | alex_xu, I have a pure shell script doing API calls -- sometimes I don't trust any software | 07:54 |
alex_xu | Qiming: ah, that is what i'm thinking, how you construct a curl with different user than osc | 07:54 |
Qiming | alex_xu, that script always generate the expected results, because .... I set USERNAME=admin | 07:54 |
alex_xu | heh | 07:54 |
Qiming | alex_xu, so ... I created an instance with user_data set to something, later on, I have to ask the admin guy to tell me what that user_data is ... | 07:56 |
Qiming | alex_xu, sounds like I was creating something I can never read back | 07:56 |
alex_xu | Qiming: yea, i agree that is a little strange. | 07:56 |
alex_xu | Qiming: the 2.3 is added for compatible ec2 API | 07:56 |
Qiming | alex_xu, it is not a requirement related to EC2 compatibility | 07:57 |
alex_xu | i guess compatible ec2 API only use that for admin user, i'm not sure why | 07:57 |
alex_xu | Qiming: yea, i agree | 07:58 |
Qiming | alex_xu, it is a requirement for portraying an existing server by describing its current attributes as closely as possible | 07:58 |
Qiming | alex_xu, then I can create another instance as its shadow | 07:58 |
alex_xu | Qiming: yes, i guess when we added that for admin, we didn't think about whether normal user need it | 07:59 |
alex_xu | Qiming: is there any requirement from senlin? | 07:59 |
Qiming | alex_xu, now you realize how badly I want the user_data back? it is MY instance, not the admin's, :D | 07:59 |
alex_xu | Qiming: or that is a requirement from senlin? | 07:59 |
*** salv-orl_ has quit IRC | 08:00 | |
bauzas | p!spy | 08:00 |
Qiming | alex_xu, em ... you can say that, senlin is a user of nova | 08:00 |
alex_xu | Qiming: ok | 08:00 |
alex_xu | Qiming: it isn't so hard to add that, just need a spec and a microversion... | 08:01 |
*** litao has joined #openstack-nova | 08:01 | |
Qiming | just tried, a user with admin role doesn't help | 08:01 |
Qiming | alex_xu, the user's full name has to be 'admin' | 08:01 |
alex_xu | Qiming: no, just admin role | 08:02 |
Qiming | alex_xu, service account doesn't work either | 08:02 |
alex_xu | Qiming: yes | 08:02 |
Qiming | alex_xu, a minute, I was concluding too fast | 08:05 |
alex_xu | Qiming: yea | 08:05 |
Qiming | alex_xu, trying admin role now, let me what happens if 'demo' is an 'admin' on 'demo' | 08:05 |
*** kevinz has quit IRC | 08:07 | |
Qiming | alex_xu, \o/, admin role does work | 08:07 |
alex_xu | Qiming: congrats :) | 08:08 |
Qiming | http://paste.openstack.org/show/601882/, it is there now | 08:09 |
* alex_xu hopes Qiming happy now | 08:10 | |
* Qiming feels happy when he knows the reason but he is still unhappy being forced to use 'admin' role | 08:11 | |
*** ducttape_ has joined #openstack-nova | 08:12 | |
*** markvoelker has joined #openstack-nova | 08:12 | |
*** jlvillal has joined #openstack-nova | 08:12 | |
*** swebster_ has quit IRC | 08:15 | |
*** ducttape_ has quit IRC | 08:17 | |
*** thorst has joined #openstack-nova | 08:18 | |
*** ralonsoh has joined #openstack-nova | 08:20 | |
*** thorst has quit IRC | 08:22 | |
*** swebster_ has joined #openstack-nova | 08:23 | |
*** guchihiro has quit IRC | 08:28 | |
*** Jack_I has joined #openstack-nova | 08:29 | |
*** amoralej|off is now known as amoralej | 08:31 | |
*** jpena|away is now known as jpena | 08:41 | |
openstackgerrit | Qiming Teng proposed openstack/nova master: Fix API doc about server attributes (2.3 API) https://review.openstack.org/443000 | 08:43 |
Qiming | alex_xu, for you ^ | 08:44 |
alex_xu | Qiming: thanks for that patch | 08:45 |
openstackgerrit | huangtianhua proposed openstack/nova master: Update quota usage when delete an instance without host https://review.openstack.org/443003 | 08:46 |
*** karimb has joined #openstack-nova | 08:46 | |
alex_xu | Qiming: just think we should clear that it is admin-only in the default policy configration, it is configurable thing https://review.openstack.org/#/c/443000/1/api-ref/source/parameters.yaml | 08:47 |
*** sudipto has joined #openstack-nova | 08:50 | |
*** sudipto_ has joined #openstack-nova | 08:50 | |
openstackgerrit | huangtianhua proposed openstack/nova master: [DNM] Update quota usage when delete an instance without host https://review.openstack.org/443003 | 08:53 |
*** moshele has joined #openstack-nova | 08:53 | |
Qiming | really? | 08:56 |
*** edmondsw has joined #openstack-nova | 08:57 | |
Qiming | alex_xu, trying tox -e genpolicy | 08:58 |
openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova-specs master: Live Migration of Rescued Instances https://review.openstack.org/347161 | 08:59 |
alex_xu | Qiming: yes, but that single rule contorl multiple fields. you may want to expose "userdata" to the normal user, but you won't want to expose other fields like hypervisor_hostname to the normal user | 08:59 |
*** zzzeek has quit IRC | 09:00 | |
Qiming | alex_xu, wrt those two I agree | 09:00 |
*** zzzeek has joined #openstack-nova | 09:00 | |
Qiming | alex_xu, how about others? | 09:00 |
*** salv-orlando has joined #openstack-nova | 09:00 | |
Qiming | alex_xu, filed a bug on this, https://bugs.launchpad.net/nova/+bug/1670978 | 09:01 |
openstack | Launchpad bug 1670978 in OpenStack Compute (nova) "most of extended server attributes returned in 2.3 api versions should not require admin role" [Undecided,New] | 09:01 |
alex_xu | Qiming: ah, wait, that hostname is the instance's hostname | 09:01 |
*** edmondsw has quit IRC | 09:01 | |
alex_xu | Qiming: I feel we can expose all of them to the normal user. | 09:02 |
*** openstackgerrit has quit IRC | 09:03 | |
Qiming | alex_xu, glad to know that | 09:04 |
*** salv-orlando has quit IRC | 09:05 | |
*** karimb has quit IRC | 09:05 | |
*** hieulq has quit IRC | 09:06 | |
*** claudiub|2 is now known as claudiub | 09:07 | |
*** hieulq has joined #openstack-nova | 09:08 | |
*** kaisers has quit IRC | 09:10 | |
*** ducttape_ has joined #openstack-nova | 09:13 | |
*** karimb has joined #openstack-nova | 09:16 | |
*** ducttape_ has quit IRC | 09:17 | |
*** thorst has joined #openstack-nova | 09:18 | |
*** jaosorior is now known as jaosorior_brb | 09:19 | |
*** mlakat has joined #openstack-nova | 09:22 | |
*** kaisers has joined #openstack-nova | 09:23 | |
*** thorst has quit IRC | 09:23 | |
*** youzp has joined #openstack-nova | 09:24 | |
*** yuntongjin has quit IRC | 09:24 | |
*** kaisers has quit IRC | 09:27 | |
*** salv-orlando has joined #openstack-nova | 09:31 | |
*** derekh has joined #openstack-nova | 09:32 | |
*** gszasz has joined #openstack-nova | 09:34 | |
*** salv-orlando has quit IRC | 09:35 | |
*** yamamoto_ has quit IRC | 09:35 | |
*** openstackgerrit has joined #openstack-nova | 09:37 | |
openstackgerrit | Li Yingjun proposed openstack/nova master: Error message should not include SQL command https://review.openstack.org/436773 | 09:37 |
johnthetubaguy | alex_xu: I thought hostname was the hypervisor hostname, is that a different one? | 09:39 |
alex_xu | johnthetubaguy: that is the different one, it comes from objects.Instance.hostname | 09:39 |
*** thorst has joined #openstack-nova | 09:40 | |
johnthetubaguy | oh, OK | 09:40 |
johnthetubaguy | thats the possibly truncated name I guess | 09:40 |
*** rmart04 has joined #openstack-nova | 09:40 | |
alex_xu | johnthetubaguy: yea, https://github.com/openstack/nova/blob/master/nova/compute/api.py#L590 | 09:41 |
alex_xu | johnthetubaguy: so we can change some admin fields to non-admin fields without microversion, right? | 09:41 |
johnthetubaguy | yeah, seems like the policy default is wrong then | 09:41 |
johnthetubaguy | alex_xu: yeah, just a release note about the upgrade impact | 09:41 |
* johnthetubaguy waves hands towards the capabilities API | 09:42 | |
alex_xu | johnthetubaguy: yes, capabilities API, remove all my confuse | 09:42 |
alex_xu | :) | 09:42 |
johnthetubaguy | :) | 09:42 |
alex_xu | johnthetubaguy: few thinking https://review.openstack.org/#/c/433037/12/specs/pike/approved/policy-remove-scope-checks.rst | 09:43 |
*** trinaths1 has quit IRC | 09:43 | |
johnthetubaguy | alex_xu: yeah, scope is a tricky one, if we do hierarchy too | 09:44 |
*** thorst has quit IRC | 09:44 | |
johnthetubaguy | alex_xu: probably "global visibility = TRUE/FALSE" might be worth adding in the extended list | 09:45 |
alex_xu | johnthetubaguy: do you have example what scope will looks like with hierarchy? i can't image that, maybe I should think about more hierarchy first | 09:45 |
johnthetubaguy | so project A is parent of B and C | 09:45 |
johnthetubaguy | you login as global read of project A | 09:46 |
johnthetubaguy | maybe you should be able to also read servers in B and C | 09:46 |
johnthetubaguy | maybe all_tenants=True gives you a list of all servers across A, B and C | 09:46 |
johnthetubaguy | alex_xu: does that make any sense? | 09:46 |
alex_xu | johnthetubaguy: yea, that make sense | 09:47 |
johnthetubaguy | oops, I said global read of project A | 09:47 |
johnthetubaguy | I meant read in project A | 09:47 |
alex_xu | i think i got that | 09:47 |
johnthetubaguy | now I am not 100% if we want to do that, but good to leave the door open to that | 09:47 |
alex_xu | try to think about how to match that into scope check | 09:47 |
johnthetubaguy | think of a server GET | 09:48 |
johnthetubaguy | you have a token for project A | 09:48 |
johnthetubaguy | but you GET an instance in project B | 09:48 |
johnthetubaguy | because A is parent of B, we could make the scope check pass, even though token.project_id != server.project_id and token is not global scoped | 09:48 |
alex_xu | at that time, we should depend on context.project_id anymore I guess | 09:49 |
alex_xu | s/should/shouldn't/ | 09:49 |
bauzas | alex_xu: objects.Instance.hostname ? OMG, what's this ? | 09:50 |
*** youzp has quit IRC | 09:51 | |
alex_xu | bauzas: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L590, the hostname of guest | 09:51 |
johnthetubaguy | alex_xu: right, the scope check checks the hierarchy and the project | 09:51 |
bauzas | alex_xu: ah the instance name, gotcha | 09:51 |
bauzas | oh wait, no | 09:51 |
*** karimb has quit IRC | 09:52 | |
bauzas | yeah, not the display name, some weird thing | 09:52 |
alex_xu | johnthetubaguy: ok, i guess scope parameter still be the {"project_id": project_id}, then context object have attribute about hierarchy projects. Then check_scope proably can do the hierarchy check | 09:54 |
alex_xu | bauzas: yea | 09:54 |
alex_xu | johnthetubaguy: bauzas have to leave now. back later | 09:55 |
johnthetubaguy | alex_xu: yeah, thats totally it | 09:55 |
johnthetubaguy | alex_xu: catch you later | 09:55 |
johnthetubaguy | bauzas: think windows VMs with hostname limits, and user passing in very long names | 09:55 |
bauzas | I see | 09:56 |
*** karimb has joined #openstack-nova | 09:56 | |
*** satyar has quit IRC | 09:57 | |
*** kaisers has joined #openstack-nova | 10:00 | |
*** yamahata has quit IRC | 10:02 | |
*** yingjun has quit IRC | 10:05 | |
*** gcb has quit IRC | 10:06 | |
*** youzp has joined #openstack-nova | 10:06 | |
*** gcb has joined #openstack-nova | 10:06 | |
*** sridharg has quit IRC | 10:09 | |
*** trinaths has joined #openstack-nova | 10:10 | |
*** youzp has quit IRC | 10:10 | |
openstackgerrit | Qiming Teng proposed openstack/nova master: Fix API doc about server attributes (2.3 API) https://review.openstack.org/443000 | 10:11 |
*** tovin07_ has quit IRC | 10:11 | |
*** ducttape_ has joined #openstack-nova | 10:14 | |
*** ltomasbo is now known as ltomasbo|away | 10:14 | |
*** sridharg has joined #openstack-nova | 10:15 | |
*** ducttape_ has quit IRC | 10:19 | |
*** sambetts|afk is now known as sambetts | 10:19 | |
*** salv-orlando has joined #openstack-nova | 10:20 | |
*** karthiks has quit IRC | 10:25 | |
mdbooth | johnthetubaguy: More swap_volume fun, btw: https://review.openstack.org/#/c/389798/ | 10:28 |
*** youzp has joined #openstack-nova | 10:28 | |
mdbooth | johnthetubaguy: In that change, the issue we have is that cinder is deferring the copy operation to Nova, but Nova isn't always able to do it | 10:28 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Optimize time during PCI alias parsing process https://review.openstack.org/427145 | 10:29 |
*** karimb has quit IRC | 10:29 | |
johnthetubaguy | mdbooth: yeah, isn't that the general problem with swap volume? I think thats why I couldn't use that in public cloud | 10:29 |
johnthetubaguy | neither side had the ability to do a "live" clone or copy | 10:29 |
mdbooth | kashyap: I also added you to https://review.openstack.org/#/c/389798/ btw, because I'm wondering about what the behaviour of rebase is in various domain states. | 10:29 |
* kashyap clicks | 10:30 | |
lyarwood | mdbooth: I've got a RHBZ downstream to enable offline swap_volume btw | 10:30 |
johnthetubaguy | lyarwood: "offline"? you mean pause the VM? | 10:30 |
kashyap | mdbooth: BTW, in the scrollback there was an interesting question. Was gathering the related IRC chatter: | 10:30 |
mdbooth | johnthetubaguy: I think you can do it, you'd just need to ensure Nova doesn't bring the instance up while cinder is doing the copy | 10:30 |
johnthetubaguy | mdbooth: but the instance is running during swap volume, I thought? | 10:31 |
kashyap | mdbooth: When you have a moment: http://paste.openstack.org/show/601900/ | 10:31 |
* kashyap is still parsing it | 10:31 | |
lyarwood | johnthetubaguy: yeah paused, shutoff, any state where qemu can't rebase | 10:31 |
mdbooth | johnthetubaguy: Yes, unless it's not. | 10:31 |
johnthetubaguy | mdbooth: lyarwood: OK, gotcha | 10:31 |
mdbooth | If it's not, we currently fail. | 10:31 |
johnthetubaguy | like live-migration really | 10:31 |
johnthetubaguy | (although that actually has some error handling) | 10:31 |
mdbooth | johnthetubaguy: Anyway, I was asking for a rethink of swap_volume in that cinderv3 spec, and this seemed relevant to that. | 10:32 |
johnthetubaguy | mdbooth: yeah, I need to read through your comments on there | 10:32 |
mdbooth | Although it's not directly related to attach/detach. | 10:32 |
johnthetubaguy | mdbooth: it feels like we have both volumes attached for some time, then tidy it up afterwards right? | 10:33 |
johnthetubaguy | attached, is the wrong word, I mean connected | 10:33 |
mdbooth | There's a really weird flow if cinder initiates the swap_volume | 10:33 |
johnthetubaguy | OK, I should read that more carefully then | 10:33 |
mdbooth | During a cinder retype, cinder creates a *new, blank volume*, and calls swap_volume(old, new_blank) | 10:34 |
mdbooth | new_blank obviously has its own volume_id | 10:34 |
*** udesale has quit IRC | 10:34 | |
mdbooth | Nova then does the copy, and calls back with completion | 10:34 |
mdbooth | Cinder then deletes old, and changes the volume_id of new_blank to be the same as old | 10:34 |
mdbooth | Which means that for part of the flow we've got an ephemeral volume_id | 10:35 |
mdbooth | And Nova currently needs to know that the volume_id of new_blank after the callback isn't the same as it was before. | 10:35 |
kashyap | mdbooth: That's an interesting question (rebase behavior in different domain states) you ask there on the review. I'll dig a bit & and comment on the review. | 10:35 |
mdbooth | johnthetubaguy: It's really quite horrible. | 10:35 |
*** mlakat has quit IRC | 10:36 | |
kashyap | s/interesting/not-easily-answerable/ | 10:36 |
mdbooth | kashyap: Thanks | 10:36 |
johnthetubaguy | mdbooth: oh, I forgot about that rename again, yeah, I remember looking at that now | 10:36 |
* johnthetubaguy bangs head against desk | 10:36 | |
mdbooth | johnthetubaguy: Anyway, that's why I was going on about attachment id instead. | 10:37 |
*** Haaibo has quit IRC | 10:37 | |
mdbooth | My theory is cinder can do unnatural things on the back end and Nova doesn't need to care as long as the attachment id doesn't change. | 10:37 |
johnthetubaguy | mdbooth: hmm, but don't we need to call os.brick.connect and disconnect during the swap? | 10:38 |
mdbooth | johnthetubaguy: yes, but the 2 attachments have different connection_info | 10:39 |
mdbooth | Because they're in different places | 10:39 |
johnthetubaguy | yeah, totally, I worry if thats the same attachment_id | 10:39 |
johnthetubaguy | I like a different attachment_id for the different targets | 10:39 |
mdbooth | We'd have 2 attachments: (vol, host, instance), and (vol', host, instance) | 10:40 |
johnthetubaguy | just nice to say, create new attachment, then connect, kill old attachment after disconnect | 10:40 |
johnthetubaguy | yeah | 10:40 |
mdbooth | Although vol and vol' are kinda the same volume, which might get a bit wierd | 10:40 |
mdbooth | But we don't need to care | 10:40 |
*** thorst has joined #openstack-nova | 10:40 | |
johnthetubaguy | oh, sorry, I think I get you now | 10:40 |
johnthetubaguy | we are maybe trying to say the same thing | 10:41 |
johnthetubaguy | so when cinder renames the volume uuid to something nuts, we don't notice because the attachment_id stays the same? | 10:41 |
mdbooth | Yeah | 10:41 |
johnthetubaguy | yeah, I am totally +1 that | 10:41 |
mdbooth | But the connect/disconnect flow remains basically the same | 10:41 |
johnthetubaguy | yeah | 10:42 |
kashyap | inc0: Hey there, saw the scrollback between you & MattR about libvirt 2.5 & running `nova-compute` process with a different user than QEMU causing you permission woes | 10:42 |
johnthetubaguy | mdbooth: I think thats what I was trying to say, but I guess it didn't come out like that | 10:42 |
johnthetubaguy | mdbooth: actually, what I mean is, its an assumption I had made but not really written down | 10:43 |
kashyap | inc0: I also see that your permissions problem 'goes away' when you run QEMU with 'nova' user. | 10:43 |
kashyap | It would be useful if you have a bug / specific test case. | 10:43 |
*** phuongnh has quit IRC | 10:43 | |
*** thorst has quit IRC | 10:45 | |
*** tuanluong has quit IRC | 10:45 | |
*** yamamoto has joined #openstack-nova | 10:45 | |
*** mlakat has joined #openstack-nova | 10:47 | |
*** yamamoto has quit IRC | 10:48 | |
*** yamamoto has joined #openstack-nova | 10:50 | |
*** yamamoto has quit IRC | 10:51 | |
*** ociuhandu has quit IRC | 10:51 | |
*** sdague has joined #openstack-nova | 10:53 | |
*** ltomasbo|away is now known as ltomasbo | 10:55 | |
*** gcb has quit IRC | 10:56 | |
*** youzp_ has joined #openstack-nova | 11:01 | |
*** fragatina has joined #openstack-nova | 11:01 | |
mdbooth | I'd like to nominate dansmith for best patch title: "Target cell in super conductor operations" | 11:01 |
*** youzp has quit IRC | 11:02 | |
mdbooth | Expect a movie by Michael Bay | 11:02 |
*** karthiks has joined #openstack-nova | 11:04 | |
*** nicolasbock has joined #openstack-nova | 11:04 | |
*** fragatina has quit IRC | 11:06 | |
*** zhurong has joined #openstack-nova | 11:08 | |
kashyap | Heh | 11:09 |
*** masber has quit IRC | 11:09 | |
*** masber has joined #openstack-nova | 11:10 | |
*** yamamoto has joined #openstack-nova | 11:15 | |
*** ducttape_ has joined #openstack-nova | 11:15 | |
*** yamamoto has quit IRC | 11:16 | |
*** gongysh has quit IRC | 11:16 | |
*** yamamoto has joined #openstack-nova | 11:18 | |
*** yamamoto has quit IRC | 11:19 | |
*** ducttape_ has quit IRC | 11:20 | |
*** catintheroof has joined #openstack-nova | 11:20 | |
*** cdent has joined #openstack-nova | 11:21 | |
*** iceyao has joined #openstack-nova | 11:22 | |
tonyb | lyarwood: I've been avoiding that s390x backport ... thanks for calling me out on it ;P | 11:23 |
tonyb | lyarwood: just 'cause it's complex | 11:25 |
*** karthiks has quit IRC | 11:26 | |
*** iceyao has quit IRC | 11:27 | |
*** kaisers has quit IRC | 11:28 | |
*** psachin has quit IRC | 11:28 | |
lyarwood | tonyb: you're welcome :D | 11:30 |
tonyb | :) | 11:30 |
lyarwood | tonyb: do we have any policy about stable only changes like this? | 11:30 |
tonyb | lyarwood: only the stable-policy which basically says if it isn't a backport then it isn't appropriate | 11:32 |
tonyb | but the tricks in the fine print. If we can convince ourselves it's as close to a backport as we can reasonably do then we can look at it | 11:33 |
*** satyar has joined #openstack-nova | 11:33 | |
tonyb | lyarwood: but we need to consider what our support for s390x is .... | 11:33 |
tonyb | lyarwood: I'm not certain it's a thing we have a firm statement on :( | 11:34 |
*** kaisers has joined #openstack-nova | 11:34 | |
lyarwood | tonyb: yeah agreed | 11:34 |
*** psachin has joined #openstack-nova | 11:36 | |
tonyb | lyarwood: I wish I could be more definative | 11:36 |
lyarwood | tonyb: https://docs.openstack.org/developer/nova/support-matrix.html does list s390x as `complete` | 11:37 |
lyarwood | ah sorry | 11:37 |
lyarwood | that's per feature | 11:37 |
tonyb | lyarwood: Yeah | 11:37 |
*** karthiks has joined #openstack-nova | 11:37 | |
*** thorst has joined #openstack-nova | 11:41 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: encryptors: Switch to os-brick encryptor classes https://review.openstack.org/391597 | 11:41 |
*** alexpilo_ has joined #openstack-nova | 11:43 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: encryptors: Switch to os-brick encryptor classes https://review.openstack.org/391597 | 11:43 |
*** karthiks has quit IRC | 11:43 | |
*** alexpilotti has quit IRC | 11:44 | |
*** thorst has quit IRC | 11:46 | |
*** rfolco has joined #openstack-nova | 11:50 | |
*** karthiks has joined #openstack-nova | 11:55 | |
*** smatzek_ has joined #openstack-nova | 11:55 | |
*** alexpilotti has joined #openstack-nova | 11:59 | |
*** alexpilo_ has quit IRC | 11:59 | |
*** amotoki has quit IRC | 12:00 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Fix formatting of network options https://review.openstack.org/443086 | 12:01 |
*** trinaths has quit IRC | 12:03 | |
*** jaosorior_brb is now known as jaosorior | 12:03 | |
*** youzp_ has quit IRC | 12:05 | |
openstackgerrit | Alex Szarka proposed openstack/nova master: Reduce code complexity - servers.py https://review.openstack.org/359861 | 12:05 |
openstackgerrit | Alex Szarka proposed openstack/nova master: Reduce code complexity - manager.py https://review.openstack.org/359868 | 12:06 |
openstackgerrit | Alex Szarka proposed openstack/nova master: Reduce code complexity - linux_net.py https://review.openstack.org/359871 | 12:06 |
openstackgerrit | Alex Szarka proposed openstack/nova master: Reduce code complexity - libvirt/config.py https://review.openstack.org/359879 | 12:06 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Resolve TODOs in 'database' https://review.openstack.org/393695 | 12:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Fix indentation of database options https://review.openstack.org/443097 | 12:07 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Short circuit notifiations when not enabled https://review.openstack.org/428260 | 12:12 |
*** kevinz has joined #openstack-nova | 12:13 | |
*** ducttape_ has joined #openstack-nova | 12:16 | |
*** ducttape_ has quit IRC | 12:21 | |
*** ayogi has quit IRC | 12:24 | |
*** lucasagomes is now known as lucas-hungry | 12:25 | |
*** carthaca_ has quit IRC | 12:28 | |
*** sapcc-bot has quit IRC | 12:28 | |
*** sapcc-bot has joined #openstack-nova | 12:28 | |
*** carthaca_ has joined #openstack-nova | 12:28 | |
*** david_1 has joined #openstack-nova | 12:28 | |
*** tpatzig_ has joined #openstack-nova | 12:28 | |
*** mkoderer_ has joined #openstack-nova | 12:28 | |
*** dgonzalez_ has joined #openstack-nova | 12:28 | |
*** databus23_ has joined #openstack-nova | 12:28 | |
*** catinthe_ has joined #openstack-nova | 12:29 | |
*** catintheroof has quit IRC | 12:29 | |
*** david-lyle has quit IRC | 12:30 | |
*** catintheroof has joined #openstack-nova | 12:30 | |
*** david_1 has quit IRC | 12:30 | |
*** mkoderer_ has quit IRC | 12:30 | |
*** tpatzig_ has quit IRC | 12:30 | |
*** dgonzalez_ has quit IRC | 12:30 | |
*** databus23_ has quit IRC | 12:30 | |
*** catinthe_ has quit IRC | 12:31 | |
*** david-lyle has joined #openstack-nova | 12:33 | |
*** thorst has joined #openstack-nova | 12:33 | |
*** zhurong has quit IRC | 12:35 | |
*** ratailor has quit IRC | 12:36 | |
*** erlon has joined #openstack-nova | 12:37 | |
*** karimb has joined #openstack-nova | 12:41 | |
*** salv-orlando has quit IRC | 12:48 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Enable SR-IOV NIC offload feature discovery https://review.openstack.org/435954 | 12:50 |
*** arne_r has quit IRC | 12:50 | |
*** salv-orlando has joined #openstack-nova | 12:54 | |
*** sdague has quit IRC | 12:55 | |
*** youzp has joined #openstack-nova | 12:55 | |
alex_xu | nova api meeting is in 5 mins | 12:55 |
*** youzp has quit IRC | 12:57 | |
*** iceyao has joined #openstack-nova | 12:57 | |
*** youzp has joined #openstack-nova | 12:57 | |
kaisers | Hi! Can i interested anyone to look into a smalish driver/systemd issue fix @ https://review.openstack.org/#/c/432344/ ? | 12:58 |
*** gongysh has joined #openstack-nova | 13:06 | |
*** efried has quit IRC | 13:08 | |
*** yingjun has joined #openstack-nova | 13:10 | |
*** psachin has quit IRC | 13:13 | |
*** youzp has quit IRC | 13:14 | |
*** edmondsw has joined #openstack-nova | 13:14 | |
*** kylek3h has quit IRC | 13:15 | |
*** ducttape_ has joined #openstack-nova | 13:17 | |
*** jaypipes has joined #openstack-nova | 13:18 | |
*** efried has joined #openstack-nova | 13:18 | |
*** mriedem has joined #openstack-nova | 13:21 | |
*** gouthamr has joined #openstack-nova | 13:21 | |
mriedem | o/ | 13:21 |
bhagyashri_s | johnthetubaguy: Hi, I have some doubt regarding patch: https://review.openstack.org/#/c/409644/ As we are decide to skip the image creation and delete the snapshot if rotation == 0. | 13:21 |
*** ducttape_ has quit IRC | 13:21 | |
bhagyashri_s | johnthetubaguy: But As per the API spec: https://developer.openstack.org/api-ref/compute/, if the API is successful, it should return url of the image in the location header. But we are proposing not to create image when rotation parameter passed as 0 then in that case the location header will not exist so it seems like API behavior is changing in that case. | 13:22 |
*** salv-orl_ has joined #openstack-nova | 13:23 | |
*** amoralej is now known as amoralej|lunch | 13:24 | |
*** links has quit IRC | 13:25 | |
*** ducttape_ has joined #openstack-nova | 13:25 | |
*** salv-orlando has quit IRC | 13:26 | |
*** gouthamr has quit IRC | 13:26 | |
*** lucas-hungry is now known as lucasagomes | 13:27 | |
*** diga has quit IRC | 13:28 | |
*** aysyd has joined #openstack-nova | 13:28 | |
*** psachin has joined #openstack-nova | 13:30 | |
*** prateek has quit IRC | 13:34 | |
*** hshiina has joined #openstack-nova | 13:36 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Improve assertJsonEqual error reporting https://review.openstack.org/428199 | 13:37 |
*** eharney has joined #openstack-nova | 13:39 | |
*** mvk has quit IRC | 13:40 | |
*** tongli has joined #openstack-nova | 13:41 | |
*** karimb has quit IRC | 13:43 | |
*** liverpooler has joined #openstack-nova | 13:44 | |
*** Matias has quit IRC | 13:44 | |
*** vladikr has joined #openstack-nova | 13:45 | |
*** psachin has quit IRC | 13:46 | |
*** psachin has joined #openstack-nova | 13:46 | |
*** karimb has joined #openstack-nova | 13:46 | |
*** gouthamr has joined #openstack-nova | 13:46 | |
*** mtanino has quit IRC | 13:49 | |
*** haplo37 has quit IRC | 13:50 | |
*** kevinz has quit IRC | 13:50 | |
*** cleong has joined #openstack-nova | 13:51 | |
*** sileht has quit IRC | 13:51 | |
*** kevinz has joined #openstack-nova | 13:51 | |
*** amotoki has joined #openstack-nova | 13:51 | |
*** hshiina has quit IRC | 13:52 | |
*** xyang1 has joined #openstack-nova | 13:54 | |
*** ducttape_ has quit IRC | 13:54 | |
openstackgerrit | John Garbutt proposed openstack/nova-specs master: Add policy-docs spec https://review.openstack.org/433010 | 13:55 |
*** sileht has joined #openstack-nova | 13:55 | |
*** KeithMnemonic has joined #openstack-nova | 13:57 | |
*** efoley has joined #openstack-nova | 13:57 | |
*** kevinz has quit IRC | 13:58 | |
*** kevinz has joined #openstack-nova | 13:58 | |
*** haplo37 has joined #openstack-nova | 13:59 | |
*** sileht has quit IRC | 13:59 | |
johnthetubaguy | bhagyashri_s: the current API never returns that header if rotation == 0 today, I believe | 14:01 |
*** zhurong has joined #openstack-nova | 14:01 | |
alex_xu | johnthetubaguy: why need a method to get the scope, the scope depend on different instance? | 14:01 |
*** kylek3h has joined #openstack-nova | 14:01 | |
alex_xu | johnthetubaguy: ah, i see now | 14:01 |
*** tblakes has joined #openstack-nova | 14:01 | |
*** jaosorior has quit IRC | 14:01 | |
alex_xu | still fill scope like {'project_id': instance.project} | 14:02 |
johnthetubaguy | alex_xu: yeah | 14:02 |
johnthetubaguy | alex_xu: maybe instance.get_scope() would do it, and keypair.get_scope() | 14:02 |
johnthetubaguy | alex_xu: its specific to the object passed, not the API | 14:02 |
alex_xu | johnthetubaguy: so you will have get_flavor_scope and get_global_scope | 14:02 |
alex_xu | yea, i see | 14:03 |
johnthetubaguy | alex_xu: well I think a constant for global scope, or something like that | 14:03 |
*** sileht has joined #openstack-nova | 14:04 | |
*** sileht has quit IRC | 14:04 | |
*** esberglu has joined #openstack-nova | 14:07 | |
*** sileht has joined #openstack-nova | 14:08 | |
*** sileht has quit IRC | 14:08 | |
*** ociuhandu has joined #openstack-nova | 14:09 | |
*** ayogi has joined #openstack-nova | 14:09 | |
*** mdrabe has joined #openstack-nova | 14:09 | |
*** sileht has joined #openstack-nova | 14:10 | |
*** sileht has quit IRC | 14:11 | |
*** felipemonteiro_ has joined #openstack-nova | 14:12 | |
*** sdague has joined #openstack-nova | 14:13 | |
*** karimb_ has joined #openstack-nova | 14:13 | |
*** sdague has quit IRC | 14:14 | |
*** sdague has joined #openstack-nova | 14:14 | |
*** karimb has quit IRC | 14:15 | |
*** salv-orl_ has quit IRC | 14:18 | |
*** karimb_ has quit IRC | 14:19 | |
*** yuntongjin has joined #openstack-nova | 14:19 | |
sean-k-mooney | hi everyone o/ | 14:20 |
*** baoli has joined #openstack-nova | 14:20 | |
*** dave-mccowan has joined #openstack-nova | 14:20 | |
sean-k-mooney | https://review.openstack.org/#/c/435575/ broke the intel NFV ci which is why it is currently red | 14:20 |
*** jamesdenton has joined #openstack-nova | 14:22 | |
*** arne_r has joined #openstack-nova | 14:22 | |
*** ar1el has joined #openstack-nova | 14:23 | |
*** ar1el has left #openstack-nova | 14:24 | |
*** sileht has joined #openstack-nova | 14:26 | |
*** amoralej|lunch is now known as amoralej | 14:26 | |
*** READ10 has joined #openstack-nova | 14:26 | |
*** ducttape_ has joined #openstack-nova | 14:27 | |
mriedem | sean-k-mooney: efried was talking about something similar | 14:27 |
mriedem | sounds like it broke powervm ci too | 14:27 |
*** sridharg has quit IRC | 14:27 | |
*** sridharg has joined #openstack-nova | 14:27 | |
mriedem | sean-k-mooney: how does it break the ci though? new package not in their mirror? | 14:28 |
*** karimb has joined #openstack-nova | 14:29 | |
*** baoli has quit IRC | 14:30 | |
*** tongli has quit IRC | 14:30 | |
*** erhudy has joined #openstack-nova | 14:31 | |
*** iceyao has quit IRC | 14:32 | |
*** tblakes has quit IRC | 14:32 | |
gibi | cdent, mriedem: Hi! Sorry that I was not here to help digging the notification code to figure out the topic and the event_type prefix. (I work in UTC+1 so it was a bit late already) Is there anything from the notification side that stil needs clarification? | 14:33 |
mriedem | gibi: nope, you confirmed everything | 14:34 |
mriedem | plus i just chided you in the list about not working 20 hours per day :) | 14:34 |
gibi | yeah, I still try to keep a life outside work ;) | 14:34 |
cdent | there's an outside work? | 14:35 |
kaisers | rather: work outside but how is this better? | 14:35 |
openstackgerrit | Roman Dobosz proposed openstack/nova-specs master: Provide detailed error information for placement API https://review.openstack.org/418393 | 14:35 |
*** smatzek_ has quit IRC | 14:36 | |
*** Jinxing has joined #openstack-nova | 14:36 | |
gibi | :) | 14:36 |
*** yuntongjin has quit IRC | 14:36 | |
*** swebster_ has quit IRC | 14:37 | |
*** mdrabe has quit IRC | 14:38 | |
*** swebster_ has joined #openstack-nova | 14:38 | |
*** penick has joined #openstack-nova | 14:38 | |
*** mdrabe has joined #openstack-nova | 14:38 | |
dansmith | alex_xu: mriedem: so you both still have -1s on that simple_tenant_usage patch, but I think we're good now, am I right? | 14:41 |
*** baoli has joined #openstack-nova | 14:41 | |
*** gongysh has quit IRC | 14:42 | |
tojuvone | gibi: Thanks for the good comments. | 14:42 |
mriedem | dansmith: haven't looked | 14:43 |
tojuvone | Meanwhile have to also do outside work soon; tons of snow coming | 14:43 |
dansmith | mriedem: okay, talked with alex_xu last night and he agreed that the sorting is only for stable pagination and that we could sort cellmappinglist to be even tighter (which I'm working on now), but otherwise okay | 14:43 |
dansmith | mriedem: cellmappings should change almost never, and they come out in repeatable order, but I'm going to sort them just to be sure | 14:44 |
*** Swami has joined #openstack-nova | 14:45 | |
*** gcb has joined #openstack-nova | 14:46 | |
*** sileht has quit IRC | 14:47 | |
jaypipes | man, I'm tired today :( | 14:47 |
*** dimtruck is now known as zz_dimtruck | 14:47 | |
gibi | tojuvone: I feel a bit bad to proposing that alternative | 14:47 |
jaypipes | just can't get going, mentally.. | 14:47 |
openstackgerrit | John Garbutt proposed openstack/nova-specs master: Add policy-remove-scope-checks spec https://review.openstack.org/433037 | 14:48 |
*** markmc` is now known as markmc | 14:48 | |
tojuvone | gibi, well if we take it Craton that I work for this would be the source of truth for everybody | 14:49 |
tojuvone | gibi, it would make a lot of sense what you say | 14:49 |
mriedem | dansmith: alex_xu: what does "I'm ok without sorted by 'project_id' with cells, since if we sort in the memory, that make the pagination meanless." mean? | 14:50 |
tojuvone | gibi, then again if somebody wants to anynthing else, I do nto know | 14:50 |
mriedem | oh without | 14:50 |
mriedem | i thought that said 'with' | 14:50 |
* cdent gives jaypipes a crunchie bar | 14:50 | |
*** mpaolino has joined #openstack-nova | 14:50 | |
dansmith | mriedem: I think he means makes the sorting meaningless, like in my example | 14:50 |
mriedem | jaypipes: shitloads of coffee | 14:50 |
*** abalutoiu has quit IRC | 14:50 | |
jaypipes | cdent: oh, I totally need one. as you might have guessed, they didn't last long in the Pipes household after ATL. | 14:50 |
jaypipes | mriedem: yeah, working on it. | 14:51 |
cdent | I was given a box of thing mints girl scouts cookies when I got to florida | 14:51 |
mriedem | i was up from 2-4 and then again at 6 when the neighbors dog was barking | 14:51 |
mriedem | for no reason | 14:51 |
cdent | I managed to take them home without opening them | 14:51 |
cdent | but once open | 14:51 |
mriedem | because that's just what it does, bark at nothing | 14:51 |
cdent | gone | 14:51 |
*** sdague has quit IRC | 14:51 | |
jaypipes | mriedem: I've got three of those. | 14:51 |
mriedem | jaypipes: yeah but i assume they sleep and snore most of the night? | 14:52 |
cdent | until the apnea hits | 14:52 |
mriedem | lack of oxygen makes one tired | 14:52 |
*** Swami_ has joined #openstack-nova | 14:52 | |
jaypipes | mriedem: indeed. | 14:52 |
mriedem | the neighbor dog has a cocaine supply i'm pretty sure | 14:52 |
*** lpetrut has quit IRC | 14:53 | |
*** edleafe- is now known as edleafe | 14:53 | |
mriedem | dansmith: so net is, you're going to (1) sort cellmapping.get_all separately and (2) do a more efficient marker lookup separately for https://review.openstack.org/#/c/441388/ ? | 14:53 |
mriedem | the marker is the instance uuid, so we could find the cell that's in and page from there, but then we still potentially have other cells to iterate on after that one | 14:54 |
cdent | jaypipes: https://www.amazon.com/Crunchie-Milk-Chocolate-Honeycomb-Center/dp/B0007U5J40 that price isn't _that_ bad | 14:54 |
*** sileht has joined #openstack-nova | 14:54 | |
*** sileht has quit IRC | 14:54 | |
*** efoley has quit IRC | 14:55 | |
dansmith | mriedem: yeah.. it's going to make that mess a little more complicated, but seems reasonable | 14:55 |
gibi | tojuvone: I think it would worth to mention Craton integration as an alternattive | 14:55 |
mriedem | i left a note with that question | 14:55 |
jaypipes | cdent: heh, indeed. which reminds me, I owe you money :) | 14:55 |
mriedem | dansmith: since i don't have it worked out in my head | 14:55 |
*** Swami has quit IRC | 14:56 | |
mriedem | alex_xu: i'm +2 on https://review.openstack.org/#/c/441388/ now | 14:56 |
*** awaugama has joined #openstack-nova | 14:56 | |
*** Swami__ has joined #openstack-nova | 14:56 | |
cdent | jaypipes: you do? if you're talking about for the ones I brought you, those are on the house | 14:56 |
*** mdnadeem has quit IRC | 14:57 | |
mriedem | johnthetubaguy: i know you love policy questions, | 14:57 |
jaypipes | cdent: well, that's mighty fine of you, kind sir. | 14:57 |
cdent | first one's free! | 14:58 |
johnthetubaguy | mriedem: you called? | 14:58 |
*** penick has quit IRC | 14:58 | |
mriedem | johnthetubaguy: for lock server, if i'm reading the code correctly, the owner of the instance that locks it is the user, not the project? so that users A and B in project X both have access to a server, but if user A locks the server, user B can't stop/restart it etc? | 14:58 |
mriedem | but can user B unlock it since they are in the same project? | 14:58 |
tojuvone | gibi: Craton holds information about any host in cloud, it should have the planned maintenance stuff, just that one should be aware of that somehow in Nova | 14:59 |
*** tblakes has joined #openstack-nova | 14:59 | |
*** smatzek_ has joined #openstack-nova | 14:59 | |
johnthetubaguy | mriedem: thats correct I believe, anyone in the project can do the unlcok | 14:59 |
johnthetubaguy | unlock | 14:59 |
tojuvone | gibi, And worked to have servers API to have always consistent state infromatino about host | 14:59 |
johnthetubaguy | mriedem: the user can't do any operations, unless they first unlock | 14:59 |
*** Swami_ has quit IRC | 14:59 | |
johnthetubaguy | mriedem: the admin can do any action without unlocking (I think...) | 15:00 |
*** sree has joined #openstack-nova | 15:00 | |
johnthetubaguy | mriedem: also admin can apply the lock, so no users can remove it | 15:00 |
gibi | tojuvone: do you mean nova needs information about planned maintenance or you mean that the user looking at the nova REST API needs info about the maintenance? | 15:00 |
arne_r | Once again, calling attention to get https://review.openstack.org/#/c/436868/ in, after Lee gave it his blessing | 15:00 |
johnthetubaguy | mriedem: that service level spec of mine builds on top of all that, and adds a third layer in there | 15:00 |
*** yamahata has joined #openstack-nova | 15:01 | |
tojuvone | gibi, user querying his servers from Nova should get consistent state information. Also know that maintenance is coming | 15:01 |
*** jahsis has joined #openstack-nova | 15:01 | |
mriedem | johnthetubaguy: yeah that's all consistent with what i thought, | 15:01 |
mriedem | i just wanted to make sure that like if user A locks it that user B can still unlock it | 15:01 |
*** jaosorior has joined #openstack-nova | 15:01 | |
mriedem | which seems a bit wrong, | 15:02 |
johnthetubaguy | mriedem: ah, cool, I believe thats true | 15:02 |
mriedem | even though user B is an owner too because they are in the same project | 15:02 |
mriedem | at that point, user A just goes over and smacks user B | 15:02 |
johnthetubaguy | mriedem: our model assumes you trust (totally) everyone in your project | 15:02 |
*** arne_r has quit IRC | 15:02 | |
mriedem | johnthetubaguy: trust falls?! | 15:02 |
johnthetubaguy | mriedem: we need hierarchical tenants to do better | 15:03 |
*** mvk has joined #openstack-nova | 15:03 | |
gibi | tojuvone: does a plannend maintenance part of a status of a server? on the same analogy does the status of a TOR switch part of the status of the server using that TOR switch? | 15:04 |
johnthetubaguy | mriedem: trust falls? | 15:04 |
lbragstad | mriedem you had some comments on one of johnthetubaguy's patches about using patrole (the RBAC testing project) | 15:04 |
johnthetubaguy | yeah, I prefer some in tree functional tests, regardless of what else is done | 15:04 |
lbragstad | mriedem turns out we will have some representation from that specific project in the policy meeting today to talk about it | 15:04 |
*** sdague has joined #openstack-nova | 15:04 | |
mriedem | johnthetubaguy: you don't know about trust falls? | 15:04 |
* johnthetubaguy is in the TC meeting VC right now, so struggling with multitasking right now | 15:05 | |
johnthetubaguy | mriedem: nope | 15:05 |
mriedem | https://en.wikipedia.org/wiki/Trust_fall | 15:05 |
johnthetubaguy | mriedem: oh... so I do | 15:05 |
lbragstad | mriedem so if you had any specific questions about patrole and are unable to make the meeting - i can proxy those for you | 15:05 |
johnthetubaguy | lbragstad: I should probably take a look at that | 15:05 |
*** zhurong has quit IRC | 15:05 | |
mriedem | lbragstad: i don't | 15:06 |
lbragstad | mriedem ok | 15:06 |
tojuvone | gibi, Craton has also switches, so there is relation. | 15:06 |
lbragstad | mriedem if you do between now and 10 - just add them here https://etherpad.openstack.org/p/keystone-policy-meeting | 15:06 |
*** prateek has joined #openstack-nova | 15:07 | |
lbragstad | otherwise - i'll update that topic with a summary if what patrole is after the meeting (because i'm pretty sure that's the big question every has about it) | 15:07 |
gibi | tojuvone: would Craton push back the TOR switch status to nova to force a change on the status of the server using that TOR? | 15:07 |
*** crushil has joined #openstack-nova | 15:08 | |
*** nkrinner is now known as nkrinner_afk | 15:09 | |
tojuvone | gibi, So I say that you would have the relation known which hosts should go to maintenance if switch goes | 15:09 |
tojuvone | gibi, so you might put those into maintenance in Craton | 15:10 |
tojuvone | gibi, planned maintenance | 15:10 |
mriedem | lyarwood: kashyap: remember that block_resize failure thing I was talking about a week ago? got the libvirtd logs and they are super helpful (not really) :) http://paste.openstack.org/show/601952/ | 15:10 |
*** sandanar has joined #openstack-nova | 15:11 | |
mriedem | "error": {"class": "GenericError", "desc": "Could not resize: Invalid argument"}} len=105 | 15:11 |
* kashyap clicks | 15:11 | |
kashyap | mriedem: Hey, BTW, was reading scrollback this morning, heh, it's not Bulgaria | 15:11 |
kashyap | Ghent, Belgium :-) | 15:11 |
* kashyap finds it amusing how confidently dansmith said "Netherlands" :-) | 15:11 | |
mriedem | ha | 15:12 |
dansmith | kashyap: damn | 15:12 |
*** hongbin has joined #openstack-nova | 15:12 | |
mriedem | dansmith was infinitely closer | 15:12 |
mriedem | i got the B right | 15:12 |
dansmith | yeah, I win by the horseshoes and hand grenades rule | 15:12 |
tojuvone | gibi, And one should see that also trough Nova servers API | 15:12 |
kashyap | Yep; maybe he confused it because I was learning Dutch (and last night was my class, so left early) | 15:12 |
kashyap | mriedem: Okay, we've got at least the complete command libvirt is sending QEMU | 15:12 |
kashyap | From line-3, qemuMonitorJSONCommandWithFd:296 | 15:13 |
tojuvone | gibi, Surely also working the get alarm to user trough Vitrage | 15:13 |
*** sileht has joined #openstack-nova | 15:13 | |
kashyap | Now to decipher this error message, let me look a bit more | 15:13 |
gibi | tojuvone: I don't know. Today the I don't get network status or block device backend status through the GET /servers API but I can accept that planned maintenance is different and that might have place in the nova API | 15:14 |
tojuvone | gibi, as it could receive notification | 15:14 |
sfinucan | mriedem, johnthetubaguy: Could I ask you to take a look at the PCI weigher spec again? Think I've resolved all your comments https://review.openstack.org/#/c/364468/ | 15:14 |
*** mlavalle has joined #openstack-nova | 15:15 | |
gibi | tojuvone: I agree that we need to notify the end user I just wondering if this notification should come from nova our from carlton | 15:15 |
*** yingjun has quit IRC | 15:15 | |
kashyap | mriedem: Yes, I remember the failure, let me check with QEMU folks on OFTC | 15:15 |
mriedem | kashyap: i found https://bugzilla.redhat.com/show_bug.cgi?id=1070531 | 15:16 |
openstack | bugzilla.redhat.com bug 1070531 in qemu-kvm "qmp can not give a reasonable hint when block_resize a scsi_debug disk with 10G" [Low,Assigned] - Assigned to armbru | 15:16 |
mriedem | i wonder if the size arg is too big? | 15:16 |
tojuvone | gibi, Craton would be building notifications soon. That is also something if not use Craton, then one might like to have the Nova notif | 15:16 |
kashyap | mriedem: Potentially; don't want to say something meaningless without digging a bit more :-) | 15:17 |
mriedem | if i'm looking at this correctly, it's a 15GB block resize | 15:17 |
gibi | tojuvone: does it mean there will be two alternative implementation of the same feature one in Nova and one in Craton? | 15:18 |
mriedem | umm, 15360GB? | 15:18 |
*** zz_dimtruck is now known as dimtruck | 15:18 | |
*** salv-orlando has joined #openstack-nova | 15:18 | |
mriedem | self._guest._domain.blockResize(self._disk, size_kb) | 15:19 |
mriedem | "size":16106127360 | 15:19 |
*** karimb has quit IRC | 15:19 | |
kashyap | Oh dear | 15:20 |
*** Swami_ has joined #openstack-nova | 15:20 | |
* lyarwood reads back | 15:20 | |
*** abalutoiu has joined #openstack-nova | 15:21 | |
*** karimb has joined #openstack-nova | 15:21 | |
*** liangy has joined #openstack-nova | 15:21 | |
tojuvone | gibi, For the notification? If you would use Craton, yes there would be 2 different then. | 15:21 |
*** sree has quit IRC | 15:22 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Sort CellMappingList.get_all() for safety https://review.openstack.org/443174 | 15:22 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add functools.wraps to rapper https://review.openstack.org/443175 | 15:22 |
*** sree has joined #openstack-nova | 15:22 | |
kashyap | mriedem: Isn't it 16GB? | 15:23 |
kashyap | It's the size in bytes | 15:23 |
kashyap | It is indeed 16GB. | 15:23 |
*** Swami__ has quit IRC | 15:24 | |
mriedem | the nova code says kb | 15:24 |
mriedem | dev.resize(resize_to * units.Gi / units.Ki) | 15:24 |
*** moshele has quit IRC | 15:24 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Final cleanups in conf/network https://review.openstack.org/431023 | 15:24 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Fix formatting of network options https://review.openstack.org/443086 | 15:24 |
*** salv-orlando has quit IRC | 15:24 | |
*** felipemonteiro_ has quit IRC | 15:25 | |
kashyap | mriedem: I just checked the QEMU QAPI schema docs; the size there definitely means bytes. | 15:25 |
kashyap | Note, the 'size' you see there is the QEMU argument to the QMP command 'block_resize' | 15:25 |
kashyap | mriedem: What type of storage is this, BTW? | 15:25 |
kashyap | QCOW2? | 15:26 |
*** sree has quit IRC | 15:26 | |
lyarwood | kashyap: are you sure that resize only takes Bytes? | 15:27 |
mriedem | kashyap: i'm not sure what the volume is that it's resizing to, but this is what it's resizing from (i think) | 15:27 |
mriedem | http://paste.openstack.org/show/601953/ | 15:28 |
kashyap | lyarwood: If you see the pastebin from mriedem, on line-4, the quoted size is the argument to the QMP command 'block_resize' | 15:28 |
kashyap | mriedem: The QEMU folks are asking about the details of the kind of storage | 15:28 |
mriedem | this is where the size is calculated https://review.openstack.org/#/c/433793/3/nova/virt/libvirt/driver.py@1396 | 15:29 |
gibi | tojuvone: thanks for the info. I still feel it would be nice to have a non nova impacting alternative mentioned in the spec. but I have no hard feelings is we go forward with the nova based solution | 15:29 |
kashyap | lyarwood: See line 996 there -- http://git.qemu-project.org/?p=qemu.git;a=blob;f=qapi/block-core.json;h=9bb7f4a17ba9765245616212542725c60ec361a1;hb=HEAD#l996 | 15:29 |
mriedem | ibm a9000 is what they are resizing to | 15:29 |
kashyap | And, from what? | 15:30 |
*** felipemonteiro_ has joined #openstack-nova | 15:30 | |
mriedem | HP 3PAR | 15:30 |
lyarwood | kashyap: thanks | 15:31 |
*** mpaolino has quit IRC | 15:31 | |
*** kevinz has quit IRC | 15:31 | |
*** Jinxing has quit IRC | 15:31 | |
tojuvone | gibi, Thanks, I will work on that | 15:31 |
*** Jinxing has joined #openstack-nova | 15:32 | |
*** Jinxing has quit IRC | 15:32 | |
kashyap | mriedem: I've conveyed this detail to the QEMU folks on IRC, let you know once one of the block layer guys in EST wakes up | 15:32 |
* kashyap notes to himself - but it's 10:33 in EST | 15:33 | |
mriedem | kashyap: thanks | 15:34 |
kashyap | mriedem: One more | 15:34 |
mriedem | even if it's 16GB, https://bugzilla.redhat.com/show_bug.cgi?id=1070531 seems to indicate it's still too large | 15:35 |
openstack | bugzilla.redhat.com bug 1070531 in qemu-kvm "qmp can not give a reasonable hint when block_resize a scsi_debug disk with 10G" [Low,Assigned] - Assigned to armbru | 15:35 |
kashyap | mriedem: What is the storage backend - is it a plain raw file, a qcow2 file, a SCSI block device, or something else? | 15:35 |
*** raunak has joined #openstack-nova | 15:35 | |
*** links has joined #openstack-nova | 15:36 | |
openstackgerrit | Maciej Szankin proposed openstack/nova master: conf: fix default values reporting infra worker https://review.openstack.org/441227 | 15:36 |
*** tbachman has joined #openstack-nova | 15:36 | |
mriedem | kashyap: i'll have to dig for that | 15:37 |
*** amotoki has quit IRC | 15:37 | |
mriedem | kashyap: fo the thing being swapped to or from? | 15:37 |
dansmith | jaypipes: did you see my comments here? https://review.openstack.org/#/c/441544/4 | 15:37 |
dansmith | jaypipes: I can fix them up if you don't have time | 15:37 |
kashyap | mriedem: The context for that question is, from danpb: | 15:37 |
kashyap | mriedem: To figure out where EINVAL comes from we need to understand what qemu block driver is getting used | 15:37 |
dansmith | jaypipes: specifically this: https://review.openstack.org/#/c/441544/4/nova/virt/ironic/driver.py | 15:38 |
*** mnestratov has joined #openstack-nova | 15:38 | |
kashyap | mriedem: Both. | 15:38 |
*** mtanino has joined #openstack-nova | 15:39 | |
*** sdague has quit IRC | 15:40 | |
kashyap | mriedem: One more (credit for the guess: Eric Blake), about potentially what's going on: | 15:40 |
mriedem | maybe i can find some details from the compute logs | 15:40 |
*** tanee is now known as tanee_away | 15:40 | |
jaypipes | dansmith: yeah, will get to that after meetings. | 15:41 |
kashyap | mriedem: | 15:41 |
kashyap | 16:39 < eblake> I know qcow2 prevents resizes that shrink the volume | 15:41 |
kashyap | 16:39 < eblake> could it be that the resize failed because of that? | 15:41 |
kashyap | 16:39 < kashyap> eblake: Could you see that from the pastebin, or are you guessing that there's a shrink going on? | 15:41 |
kashyap | 16:40 < eblake> I'm just guessing, as that would be one reason for calling the resize requested size invalid | 15:41 |
dansmith | jaypipes: okay, and then kinda next for this effort is the flavor override patch and the allocation side of this right? | 15:41 |
jaypipes | dansmith: yup. | 15:42 |
dansmith | jaypipes: okay cool | 15:42 |
*** abalutoiu has quit IRC | 15:42 | |
mriedem | kashyap: we only resize if the new volume that we're resizing to is bigger https://review.openstack.org/#/c/433793/3/nova/compute/manager.py@5006 | 15:43 |
*** mdrabe has quit IRC | 15:43 | |
mriedem | looking at the logs, the name on the A9000 volume implies it's an iscsi block device | 15:43 |
*** sdague has joined #openstack-nova | 15:43 | |
mriedem | however, it also says the size is 10GB, | 15:43 |
mriedem | but that's not what i'm seeing when we actually run the block_rebase command | 15:43 |
kashyap | mriedem: On the 16GB size comment, I'm being told it is "any size is valid as long as its below the max possible size; and 16G is trivially in range" | 15:43 |
mriedem | *block_resize | 15:43 |
kashyap | And the max possible size is at least a a TB of even EB, apparently | 15:44 |
*** felipemonteiro__ has joined #openstack-nova | 15:44 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Sort CellMappingList.get_all() for safety https://review.openstack.org/443174 | 15:44 |
*** abalutoiu has joined #openstack-nova | 15:44 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Add functools.wraps to rapper https://review.openstack.org/443175 | 15:44 |
kashyap | mriedem: Apart from implication, can you confirm that it's indeed an iSCSI block dev? | 15:45 |
*** adrian_otto has joined #openstack-nova | 15:46 | |
*** adrian_otto has quit IRC | 15:47 | |
mriedem | yeah it's iscsi | 15:47 |
efried | sean-k-mooney mriedem https://review.openstack.org/#/c/435575/ didn't break our CI; it just makes the jenkins pep8 job fail on our code where it didn't before. Still figuring out how to pull in that plugin so I can validate locally, but without having to fix the whole nova project (which presumably got done by somebody else before this change was merged). | 15:47 |
*** felipemonteiro_ has quit IRC | 15:47 | |
mriedem | another thing is they swap from the A9000 to the 3PAR successfully and then they try to swap from the 3PAR to the A9000 and that fails | 15:48 |
mriedem | and i think that's actually a thing that was recently fixed | 15:48 |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189 | 15:48 |
sean-k-mooney | mriedem: efried it broke our ci by what i consider to be a bug in devstack | 15:49 |
mriedem | i wonder if they are hitting https://review.openstack.org/#/c/431540/ | 15:49 |
mriedem | kashyap: lyarwood ^ | 15:49 |
sean-k-mooney | mriedem: when devstack does a pip install of the nova source it installs both the requirements.txt and test-requiremnts.txt gloablly | 15:50 |
lyarwood | mriedem: yeah that allows you to swap multiple times now | 15:50 |
kashyap | mriedem: Okay, danpb seems to have nailed it, with his QEMU POV: | 15:51 |
*** mkoderer has joined #openstack-nova | 15:51 | |
kashyap | Ok, so QEMU will be using a block device and you can't resize those. More specifically the 'block_resize' command when used against a block device, will just refresh qemu's view of the block device size, and if the requested resize size is larger than the block device size, it'l give EINVAL. IOW, you can use 'block_resize' on a SCSI device *if* you arrange for a resize to be done in the remote | 15:52 |
kashyap | iSCSI server first, and if you then tell the client host to rescan LUNs, and only then tell QEMU to apply the new size. | 15:52 |
*** sudipto has quit IRC | 15:52 | |
sean-k-mooney | mriedem: that means that anyting else that uses pep8 is now runnning the addtional ordering tests | 15:52 |
*** sudipto_ has quit IRC | 15:52 | |
*** raunak has quit IRC | 15:52 | |
*** mdrabe has joined #openstack-nova | 15:52 | |
sean-k-mooney | mriedem: as a result we cant build ovs-dpdk from sources as they dont enforcre the import ordering. | 15:52 |
sean-k-mooney | mriedem: devstack should not do https://github.com/openstack-dev/devstack/blob/6523d6e09789076d0a430bf7b608511fcb1c406a/inc/python#L336-L348 by default | 15:53 |
*** abalutoiu_ has joined #openstack-nova | 15:55 | |
dansmith | johnthetubaguy: see the questions pending on this quotas thing? https://review.openstack.org/#/c/416521 | 15:55 |
dansmith | johnthetubaguy: it doesn't call you out specifically, but it might as well :P | 15:55 |
*** tbachman has quit IRC | 15:55 | |
johnthetubaguy | dansmith: on the TC call, those should keep me amused while I am listening | 15:56 |
mriedem | kashyap: so i got the GET volume response info from the compute logs which has the size for each volume, and they both say 10 | 15:56 |
efried | sean-k-mooney Sounds reasonable to me. Launchpad bug? Propose a fix? | 15:56 |
mriedem | so i don't see why we're even attempting a resize | 15:56 |
sean-k-mooney | mriedem: the connect to ovs may not be apparent but there makefile enabled flake8 if its installed which it is tanks to devstack and the test defined by flake8-import-order seam to be enabled by default | 15:56 |
dansmith | johnthetubaguy: even quotas are better than TC stuff :) | 15:56 |
*** jahsis has quit IRC | 15:56 | |
*** tbachman has joined #openstack-nova | 15:56 | |
kashyap | mriedem: Heh, that's a good place to step back and see, if it's even needed. | 15:56 |
mriedem | kashyap: because resize_to should be 0 since this would be false https://review.openstack.org/#/c/433793/3/nova/compute/manager.py@5006 | 15:56 |
sean-k-mooney | efried: am yes i have asked our ci team to open one and submit a patch to make it optional | 15:57 |
mriedem | kashyap: multipath is also enabled on these things, which i'm just going to wildly make a guess could ruin everything | 15:58 |
sean-k-mooney | efried: if we are gong to run the unit tests in the ci we will just use tox and it will install the test-requriments in the virtual env itself so i dont know why devstack is installing them by default for every thing that is installed via pip | 15:58 |
*** rcernin has quit IRC | 15:58 | |
mriedem | b/c we sure as hell don't test swap volume with multipath backends | 15:58 |
openstackgerrit | Gábor Antal proposed openstack/nova-specs master: Show persisted scheduler hints in server details https://review.openstack.org/440580 | 15:58 |
*** abalutoiu has quit IRC | 15:59 | |
kashyap | mriedem: Yeah, 'multipath' -- never in my life I could grok that goddamend thing. Whenever I set out to focus on it to learn, I get distracted. | 15:59 |
*** adrian_otto has joined #openstack-nova | 15:59 | |
*** Jeffrey4l_ is now known as Jeffrey4l | 15:59 | |
sean-k-mooney | efried: mriedem looks like they have already opened the bug https://bugs.launchpad.net/devstack/+bug/1671144 | 16:01 |
openstack | Launchpad bug 1671144 in devstack "test-requirements are wrongly installed system-wide" [Undecided,New] | 16:01 |
openstackgerrit | John Garbutt proposed openstack/nova master: POC: add context.check_scope https://review.openstack.org/435485 | 16:01 |
*** fragatina has joined #openstack-nova | 16:02 | |
*** marst has joined #openstack-nova | 16:02 | |
lyarwood | mriedem: we don't appear to test this resize path during our swap_volume tempest tests btw, I'll follow up with that. | 16:03 |
*** ayogi has quit IRC | 16:03 | |
*** adrian_otto1 has joined #openstack-nova | 16:05 | |
*** fragatina has quit IRC | 16:06 | |
*** adrian_otto has quit IRC | 16:07 | |
mriedem | kashyap: ah there are 2 A9K volumes | 16:07 |
mriedem | 2 swap operations | 16:07 |
mriedem | 10GB A9K -> 10GB 3PAR, | 16:07 |
kashyap | And... | 16:07 |
mriedem | then 10GB 3PAR -> 15GB A9K | 16:07 |
mriedem | so that's the resize | 16:07 |
kashyap | Ah, okay, then we're talking about the the second one. | 16:08 |
*** lpetrut has joined #openstack-nova | 16:11 | |
openstackgerrit | Maciej Szankin proposed openstack/nova master: conf: fix netconf, my_ip and host are unclear https://review.openstack.org/441210 | 16:12 |
*** baoli has quit IRC | 16:12 | |
*** baoli has joined #openstack-nova | 16:14 | |
*** baoli has quit IRC | 16:14 | |
*** Jeffrey4l has quit IRC | 16:15 | |
cburgess | I know at least some of you are Lenovo ThinkPad users, what is the goto model these days? | 16:15 |
*** Jeffrey4l_ has joined #openstack-nova | 16:15 | |
mriedem | cburgess: dansmith and melwitt have T460 i think | 16:16 |
mriedem | cburgess: i'm getting a P50 | 16:16 |
dansmith | mriedem: I have a T460s | 16:16 |
dansmith | mriedem: but my choice is MBP 13" remember :) | 16:16 |
mriedem | lyarwood: for https://review.openstack.org/#/c/431540/ is that swap volume from A->B and B->A, or also A->B, B->C? | 16:16 |
mriedem | dansmith: yeah i know | 16:17 |
lyarwood | mriedem: both | 16:18 |
cburgess | dansmith mriedem Yeah I use MBP personally but asking for a friend (read parents). Thanks for the feedback | 16:18 |
dansmith | heh | 16:18 |
*** trinaths has joined #openstack-nova | 16:19 | |
mriedem | cburgess: get them a chromebook then | 16:19 |
openstackgerrit | Sarafraj Singh proposed openstack/nova-specs master: Spec to add per instance timeout for LM https://review.openstack.org/442809 | 16:19 |
mriedem | cheap and simple | 16:19 |
med_ | mfisch just bought an HP Spectre 360 15" -- nice gear cburgess | 16:20 |
*** salv-orlando has joined #openstack-nova | 16:20 | |
med_ | though probably overkill for anyone's parents | 16:20 |
cburgess | mriedem For reasons I won't even begin to get into it needs to be windows with execl, and word, and outlook, and IE. | 16:20 |
*** markus_z has quit IRC | 16:20 | |
med_ | unless they are Linus's kids | 16:20 |
mriedem | cburgess: probably just so they can move their stuff and re-use the same tools, rather than upload existing docs to google drive or something | 16:22 |
mriedem | idk | 16:22 |
mriedem | old people, including myself, do not like change | 16:23 |
*** Kevin_Zheng has quit IRC | 16:23 | |
*** trinaths1 has joined #openstack-nova | 16:23 | |
* med_ always assumed mriedem still gets carded at bars | 16:23 | |
mriedem | kashyap: yeah so i think the confirmation from danpb nails it, the first swap which is no resize is ok, but the 2nd which is the resize fails | 16:23 |
mriedem | med_: i can't remember the last time i've been carded since i don't drink | 16:23 |
mriedem | but maybe to get in | 16:23 |
med_ | good point. | 16:24 |
*** baoli has joined #openstack-nova | 16:24 | |
mriedem | lyarwood: yeah i think i thought about that test wrinkle at one point when talking with scottda about testing swap volume | 16:24 |
mriedem | it would be pretty simple, creating 2 volumes, where the 2nd is larger and we swap from small to big | 16:24 |
*** jaosorior has quit IRC | 16:24 | |
kashyap | mriedem: Ah, cool that you tied up that loose end with that analysis | 16:25 |
* kashyap hasn't come across 'carded' before, apparently special NA slang: "check the identity card of (someone), in particular as evidence of legal drinking age." | 16:25 | |
mriedem | edleafe: so i think the thing is all sorted out :L) | 16:25 |
mriedem | :) | 16:25 |
*** salv-orlando has quit IRC | 16:25 | |
edleafe | mriedem: See? Bring me in, problem gets solved! | 16:25 |
*** trinaths has quit IRC | 16:26 | |
mriedem | i do enjoy that the L3 guys from japan call me Matt-san | 16:26 |
*** crushil has quit IRC | 16:26 | |
edleafe | On IRC we'll call you mriedem-san from now on | 16:27 |
*** moshele has joined #openstack-nova | 16:27 | |
mriedem | in high school i got people to call me dave for a few weeks just because i liked the name | 16:27 |
mriedem | so call me dave | 16:28 |
*** dtp has joined #openstack-nova | 16:28 | |
edleafe | s/Matt/Dave/g | 16:28 |
dansmith | mriedem: weren't you a little old for such shenanigans in high school? | 16:28 |
dansmith | that's middle school stuff | 16:28 |
*** bwensley has joined #openstack-nova | 16:29 | |
*** crushil has joined #openstack-nova | 16:30 | |
artom | mriedem, so https://en.wikipedia.org/wiki/David_Readman is you then? | 16:30 |
*** markvoelker has quit IRC | 16:30 | |
*** felipemonteiro__ has quit IRC | 16:30 | |
*** lucasagomes is now known as lucas-afk | 16:30 | |
*** bwensley has quit IRC | 16:31 | |
*** karimb has quit IRC | 16:31 | |
*** bwensley has joined #openstack-nova | 16:31 | |
mriedem | dansmith: i think it was exactly the right time | 16:31 |
dansmith | heh | 16:32 |
*** moshele has quit IRC | 16:32 | |
mriedem | artom: ha, no i'm this guy http://www.swipco.org/contact-us/ | 16:32 |
mriedem | Dave Riedemann, Housing Programs Administrator | 16:32 |
mriedem | under armor for a professional photo, classy | 16:33 |
mriedem | that's dave riedemann classy | 16:33 |
* Dave adjusts irssi settings | 16:33 | |
mriedem | that's mfing SW iowa classy | 16:33 |
artom | And lip gloss as well | 16:33 |
mriedem | no gloss required | 16:34 |
artom | You're just naturally fabulous | 16:34 |
mriedem | that's probably leftover bacon grease since it's iowa | 16:34 |
mriedem | pork and corn for every meal boys | 16:34 |
*** tbachman has quit IRC | 16:34 | |
artom | Pork and Corn is the name of my Korn tribute band. | 16:34 |
*** gfhellma has joined #openstack-nova | 16:35 | |
*** rmart04 has quit IRC | 16:35 | |
johnthetubaguy | dansmith: melwitt: thinking about quota and resize | 16:37 |
johnthetubaguy | dansmith: melwitt: what if we only do a check when you request the resize, and actually not care about races for resize? | 16:37 |
dansmith | johnthetubaguy: well, that's what I meant by accept the leakiness | 16:37 |
johnthetubaguy | dansmith: melwitt: longer term I am tempted we just do it based on allocations in placement, so you end up needing double quota during the resize, as thats technically more accurate on the resource usage | 16:38 |
dansmith | johnthetubaguy: just depends on how concerned we are about people gaming that by the resize-all situation I mentioned | 16:38 |
dansmith | johnthetubaguy: yep | 16:38 |
johnthetubaguy | I was thinking about the folks that only had out enough quota for the given space they have | 16:38 |
*** tbachman has joined #openstack-nova | 16:38 | |
johnthetubaguy | dansmith: crazy, crazy, idea, limit the number of resizes you are allowed to do at once | 16:39 |
dansmith | johnthetubaguy: with a quota or a static value? | 16:39 |
dansmith | johnthetubaguy: resizes are heavy so that's probably not a bad idea regardless | 16:39 |
johnthetubaguy | dansmith: I could go either way, a static conf, with the option of -1 might be enough (to save any API change for now) | 16:40 |
dansmith | johnthetubaguy: yeah, it's pretty much exactly like the "max parallel builds" and "max parallel migrations" confs we have now, just tenant-scoped | 16:41 |
dansmith | johnthetubaguy: but yeah, I like it | 16:41 |
johnthetubaguy | dansmith: yeah, per project rather than per host | 16:41 |
dansmith | yeah | 16:41 |
dansmith | sounds good to me | 16:42 |
johnthetubaguy | yeah, so check just on the way in, but limit the number you are allowed in conf | 16:42 |
johnthetubaguy | thats quite simple really | 16:42 |
johnthetubaguy | I quite like the double allocation eventually, once we have the placement thing working like that | 16:42 |
*** ducttape_ has quit IRC | 16:43 | |
sfinucan | vladikr: little comment on https://review.openstack.org/#/c/430026. Happy to approve after | 16:43 |
vladikr | sfinucan, thanks | 16:43 |
*** ducttape_ has joined #openstack-nova | 16:43 | |
dansmith | johnthetubaguy: yeah placement makes all of this easier when it gains knowledge of the project | 16:43 |
dansmith | johnthetubaguy: so wanna dump the above into a comment on there? | 16:43 |
johnthetubaguy | yup yup | 16:44 |
dansmith | rock on | 16:44 |
*** ducttape_ has quit IRC | 16:44 | |
*** ducttape_ has joined #openstack-nova | 16:44 | |
sfinucan | mriedem: Could I get the -2 lifted from https://review.openstack.org/#/c/345396/, please? | 16:45 |
*** sridharg has quit IRC | 16:45 | |
*** moshele has joined #openstack-nova | 16:46 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce basic framework for security proxying https://review.openstack.org/345396 | 16:47 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce framework for RFB authentication https://review.openstack.org/345397 | 16:47 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce the VeNCrypt RFB authentication scheme https://review.openstack.org/345398 | 16:47 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: console: provide an RFB security proxy implementation https://review.openstack.org/345399 | 16:47 |
*** JoseMello has joined #openstack-nova | 16:47 | |
johnthetubaguy | dansmith: added a comment, double check that makes sense | 16:47 |
dansmith | johnthetubaguy: yep thanks | 16:49 |
openstackgerrit | Matthew Booth proposed openstack/nova master: fdatasync() downloaded images before use https://review.openstack.org/441246 | 16:49 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Ensure image conversion flushes output data to disk https://review.openstack.org/443230 | 16:49 |
mdbooth | sdague: You were +2 on https://review.openstack.org/#/c/441246/. I just changed the commit message to reflect that there's a second part to the puzzle. | 16:50 |
mdbooth | (Also, there's a second part to the puzzle ;)) | 16:51 |
*** sandanar has quit IRC | 16:52 | |
*** ducttape_ has quit IRC | 16:54 | |
*** liangy has quit IRC | 16:55 | |
*** links has quit IRC | 16:55 | |
*** bwensley has quit IRC | 16:55 | |
*** ociuhandu has quit IRC | 16:55 | |
*** bwensley has joined #openstack-nova | 16:56 | |
*** bwensley has left #openstack-nova | 16:57 | |
*** liangy has joined #openstack-nova | 16:57 | |
mriedem | sfinucan: nope | 16:59 |
mriedem | sfinucan: the blueprint isn't approved | 16:59 |
mriedem | and i don't see a re-proposed spec | 16:59 |
*** salv-orlando has joined #openstack-nova | 16:59 | |
sfinucan | mriedem: Ah, I only thought -2s only applied after spec approval deadline. I'll resub the spec now | 16:59 |
*** moshele has quit IRC | 17:00 | |
*** nic has joined #openstack-nova | 17:00 | |
*** cdent has quit IRC | 17:01 | |
*** andreas_s has quit IRC | 17:02 | |
*** abalutoiu_ has quit IRC | 17:02 | |
*** penick has joined #openstack-nova | 17:03 | |
mriedem | dansmith: something else i thought about yesterday with your simple tenant usage change | 17:03 |
mriedem | but in get_all in the compute API we have a check for cells v1 | 17:04 |
dansmith | mriedem: on a call, but let me think about that when I'm done | 17:04 |
dansmith | not sure it's as important here. the cells1 check is purely to avoid overwriting data in the replication, but here we're looking at history, so probably fine | 17:05 |
dansmith | anyway, biab | 17:05 |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Websockify security proxy framework https://review.openstack.org/443234 | 17:05 |
*** prateek_ has joined #openstack-nova | 17:05 | |
*** prateek has quit IRC | 17:08 | |
openstackgerrit | Sujitha proposed openstack/nova master: Reduce calls to load_tags() to 0 https://review.openstack.org/435146 | 17:09 |
*** mlakat has quit IRC | 17:10 | |
*** efried has quit IRC | 17:13 | |
*** markvoelker has joined #openstack-nova | 17:13 | |
*** KeithMnemonic has quit IRC | 17:15 | |
*** penick has quit IRC | 17:15 | |
*** armax has joined #openstack-nova | 17:16 | |
*** tesseract has quit IRC | 17:18 | |
*** coreywright has quit IRC | 17:19 | |
*** efried has joined #openstack-nova | 17:21 | |
*** penick has joined #openstack-nova | 17:21 | |
*** psachin has quit IRC | 17:22 | |
*** penick has quit IRC | 17:22 | |
*** marst has quit IRC | 17:23 | |
*** fragatina has joined #openstack-nova | 17:24 | |
*** fragatina has quit IRC | 17:24 | |
*** fragatina has joined #openstack-nova | 17:25 | |
*** swebster_ has quit IRC | 17:25 | |
*** marst has joined #openstack-nova | 17:28 | |
jroll | so openstackclient defaults to the latest microversion, do y'all pin that or send 'latest'? | 17:29 |
* jroll looking for code | 17:29 | |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/delete #1: no-ops https://review.openstack.org/438119 | 17:30 |
*** yamahata has quit IRC | 17:30 | |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #2: functional https://review.openstack.org/438598 | 17:30 |
*** coreywright has joined #openstack-nova | 17:31 | |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: power_on/off and reboot https://review.openstack.org/427380 | 17:31 |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #3: TaskFlow https://review.openstack.org/438729 | 17:32 |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #4: full flavor https://review.openstack.org/391288 | 17:32 |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: console https://review.openstack.org/409402 | 17:32 |
*** trinaths1 has quit IRC | 17:33 | |
*** trinaths has joined #openstack-nova | 17:34 | |
cfriesen | at the PTG a suggestion was made to add an option to the live migration request to specify "force live migration after X seconds". Was anyone planning on running with that? | 17:34 |
*** trinaths1 has joined #openstack-nova | 17:35 | |
jroll | never mind my question, I found it, the answer is that it's pinned | 17:35 |
mriedem | jaypipes: ComputeNode.stats is where all of the virt driver capabilities dict garbage lives right? | 17:36 |
*** prateek_ has quit IRC | 17:37 | |
raj_singh | cfriesen: yes | 17:37 |
raj_singh | cfriesen: I have a spec https://review.openstack.org/#/c/442809/ | 17:38 |
*** penick has joined #openstack-nova | 17:38 | |
mriedem | claudiub: jaypipes: can you both take a look at this? https://review.openstack.org/#/c/364468/ | 17:38 |
*** trinaths has quit IRC | 17:38 | |
mriedem | claudiub: guestions in there for you wrt the hyperv driver | 17:38 |
*** penick has quit IRC | 17:38 | |
mriedem | jaypipes: questions in there for you about nested resource providers and placement | 17:38 |
mriedem | sfinucan: ^ questions/comments inline | 17:38 |
mriedem | seems like the numa/pci information is something that would be fed into nested resource provider via the new get_inventory method on the virt driver | 17:39 |
raj_singh | cfriesen: and this https://review.openstack.org/#/c/438467/ | 17:39 |
mriedem | so the libvirt driver could say what it's inventory of available pci devices is | 17:39 |
mriedem | and then the scheduler you query placement for that info and place an instance that requires pci onto one of those hosts, and for instances that don't require pci, it weighs those away from those providers | 17:40 |
sean-k-mooney | mriedem: looking at stpehens spec i dont know if you need driver changes so much as compute agent changes | 17:42 |
mriedem | compute agent? | 17:42 |
mriedem | we don't have a compute agent | 17:42 |
sean-k-mooney | n-cpu? | 17:43 |
cfriesen | compute server | 17:43 |
sfinucan | mriedem, sean-k-mooney: Might be easier show you the code :) https://review.openstack.org/#/c/379625/10 | 17:43 |
cfriesen | make that compute service | 17:44 |
mriedem | sfinucan: ok that's not the compute driver | 17:44 |
sean-k-mooney | mriedem: right what sfinucan is proposing to change is how the pci device is selected when it lands on the compute node but i tink that should be driver independent | 17:45 |
mriedem | so the compute_nodes.numa_topology field has the data you need, which we get in the resource tracker | 17:45 |
mriedem | sean-k-mooney: i thought the point was to not land instances that don't require pci on hosts that have available pci inventory? | 17:45 |
mriedem | doing that calculation after we've picked the host is too late | 17:45 |
sean-k-mooney | mriedem: that is where the weigher comes in | 17:46 |
sean-k-mooney | mriedem: untill we have claims you need to do it twice | 17:46 |
sfinucan | mriedem: Yeah, it's two steps | 17:46 |
sfinucan | Step A: Don't use hosts with PCI devices if we don't need them (the weigher) | 17:47 |
sean-k-mooney | if you run out of server that dont have pci decices and you have to land on one that does then you should still prefer a numa node that does not have pci devices attached | 17:47 |
sfinucan | Step B: If we do get a host with PCI devices, avoid NUMA nodes with PCI devices if we don't need them | 17:47 |
sean-k-mooney | yep what sfinucan said :) | 17:47 |
*** marst_ has joined #openstack-nova | 17:48 | |
*** marst has quit IRC | 17:48 | |
*** felipemonteiro_ has joined #openstack-nova | 17:49 | |
mriedem | i'll be honest, my eyes glaze over once i see numa_fit_instance_to_host | 17:50 |
*** derekh has quit IRC | 17:52 | |
*** KeithMnemonic has joined #openstack-nova | 17:53 | |
sean-k-mooney | mriedem: that is fair. if i didnt have to know about numa effect for my job i would happy delete it form my mind | 17:53 |
*** ducttape_ has joined #openstack-nova | 17:55 | |
sean-k-mooney | sfinucan: so stepen to sergeys vis versa comment are you going to extend the weigher to also perfer numa nodes with pci devices available when they are requested or just update the comment ? | 17:55 |
*** Swami_ has quit IRC | 17:55 | |
sfinucan | sean-k-mooney: I think I'll just remove the comment and rely on balancing with CPUs | 17:56 |
sean-k-mooney | sfinucan: ok its a 30 second else clause with the same labmda but the order reversed to add if you wanted too | 17:57 |
sfinucan | sean-k-mooney: But it's another 10 minutes writing unit tests ;) | 17:58 |
sean-k-mooney | sfinucan: i havent thaugh however if it is desireable | 17:58 |
*** ltomasbo is now known as ltomasbo|away | 17:58 | |
*** smatzek_ has quit IRC | 17:59 | |
sean-k-mooney | haha ya i was impressed that the ratio of test lines to code was actull 29:11 | 17:59 |
*** ducttape_ has quit IRC | 17:59 | |
*** yamahata has joined #openstack-nova | 17:59 | |
sean-k-mooney | less then 4 time the amount of code in unit tests then busness logic is rare | 17:59 |
*** Apoorva has joined #openstack-nova | 18:02 | |
*** penick has joined #openstack-nova | 18:02 | |
*** ducttape_ has joined #openstack-nova | 18:02 | |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #2: functional https://review.openstack.org/438598 | 18:02 |
*** penick has quit IRC | 18:02 | |
inc0 | good morning people, http://lists.openstack.org/pipermail/openstack-dev/2017-March/113507.html <- this issue might interest you | 18:02 |
inc0 | pretty much libvirt 2.5 seems to be broken with current nova vm datafiles creation | 18:03 |
*** mnestratov has quit IRC | 18:04 | |
inc0 | I'm not sure if it's ubuntu-specific or it's libvirt 2.5 specific, but it is broken:) | 18:05 |
inc0 | and we have few alternatives to handle this | 18:05 |
*** browne has joined #openstack-nova | 18:05 | |
inc0 | one would be to allow nova to create these files with custom umask | 18:05 |
inc0 | today it's hard 722, if we could make it 772, that would do it | 18:06 |
inc0 | umask and ownership | 18:06 |
*** penick has joined #openstack-nova | 18:06 | |
*** jpena is now known as jpena|off | 18:07 | |
*** karimb has joined #openstack-nova | 18:07 | |
sean-k-mooney | inc0: the umask is the revers of what you think it is. where 777 is read write execute normally for umask its 000 | 18:07 |
inc0 | fair enough;) | 18:08 |
sean-k-mooney | inc0: you would need umask 002 | 18:08 |
inc0 | well, file mode | 18:08 |
*** avolkov has quit IRC | 18:09 | |
*** tbachman has quit IRC | 18:11 | |
sean-k-mooney | inc0: i have a vm using devstack with 2.5 currently and i can boot vms. i know on the kolla channel tere was an issue with the console file correct | 18:11 |
sean-k-mooney | is that what your refering too or is more then just the console | 18:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Reserve NUMA nodes with PCI devices attached https://review.openstack.org/364468 | 18:11 |
*** gszasz has quit IRC | 18:13 | |
sfinucan | mriedem: I've clarified the fact that there's no real changes to the driver (the location of the code confused me and I wrote that code a good while back) | 18:14 |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: power_on/off and reboot https://review.openstack.org/427380 | 18:14 |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #3: TaskFlow https://review.openstack.org/438729 | 18:14 |
sfinucan | As for the resource tracker stuff: I'd be inclined to suggest that the change is both helpful/small enough, and nested resource providers still fuzzy enough, to warrant taking the weigher route for now | 18:16 |
sfinucan | However, I'm not sure what the plan is for weighers and what the migration path is when we move to resource providers, so I'd definitely like jaypipes' input | 18:17 |
sfinucan | For now though, it's late and the Lego Batman movie isn't going to see itself :) | 18:17 |
sean-k-mooney | sfinucan: nice i must go see that soon. | 18:18 |
sean-k-mooney | sfinucan: let me know if its any good :) | 18:18 |
*** tbachman has joined #openstack-nova | 18:19 | |
*** smatzek_ has joined #openstack-nova | 18:20 | |
bauzas | mriedem: I +W'd https://review.openstack.org/#/c/442723/1 but I think we could possibly have follow-ups | 18:21 |
bauzas | see commentqs | 18:21 |
openstackgerrit | Dan Peschman proposed openstack/nova master: No API cell up-call to delete consoleauth tokens https://review.openstack.org/415922 | 18:21 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add functools.wraps to wrapper https://review.openstack.org/443175 | 18:21 |
mriedem | dansmith: no ice_t? | 18:22 |
dansmith | mriedem: if I can't have my fun you can't either | 18:22 |
mriedem | works for me | 18:22 |
bauzas | dansmith: wow, chilling at the series https://review.openstack.org/#/c/441461/8 | 18:22 |
dansmith | the first time it came up, I was going to rename it to gangsta_rapper | 18:23 |
sean-k-mooney | inc0: what is the actully error that ye are seeing with libvirt 2.5? | 18:23 |
*** unicell has joined #openstack-nova | 18:23 | |
dansmith | bauzas: all but one tempest test is passing with multiple cells with that series :) | 18:23 |
bauzas | \o/ | 18:23 |
bauzas | heh for https://review.openstack.org/#/c/443175/3/nova/conductor/manager.py | 18:23 |
dansmith | and I had that working before, but broke it in cleanup | 18:23 |
bauzas | that remembers me some comment I made :) | 18:23 |
bauzas | dansmith: any reason why you added https://review.openstack.org/#/c/443175/3/nova/conductor/manager.py as a top patch and not just modified https://review.openstack.org/#/c/438022/15 ? | 18:25 |
sean-k-mooney | inc0: oh appolgies my libvert is 1.3.1 for some reason i guess i dont have the cloud archive enabled | 18:25 |
dansmith | bauzas: yes, see the comments | 18:25 |
bauzas | oh ok | 18:25 |
openstackgerrit | Andreas Jaeger proposed openstack/nova master: Replace obsolete vanity openstack.org URLs https://review.openstack.org/443266 | 18:25 |
dansmith | bauzas: I would eat all infra re-pushing for that nit | 18:25 |
*** ralonsoh has quit IRC | 18:25 | |
*** fragatina has quit IRC | 18:25 | |
bauzas | dansmith: um ok | 18:26 |
mriedem | dansmith: comments inline https://review.openstack.org/#/c/438022/15 | 18:26 |
dansmith | mriedem: replies inline.. I'd tack the log fix into the rapper fix if it were me, but your call | 18:29 |
dansmith | if you want it fixed, I'll just squash that nit patch into this one | 18:30 |
dansmith | fixed pre-merge I mean | 18:30 |
mriedem | dansmith: question about the decorator on build_instances - that's not just cellsv1, it's also reschedules from the compute manager - but at that point we're already targeted right? | 18:31 |
dansmith | mriedem: right, and so we can't actually look up there, so the target would have to be graceful and fail, yet it'd be ugly | 18:31 |
dansmith | mriedem: that goes back to the cell conductor instead of super | 18:31 |
mriedem | oh yeah, need that diagram | 18:32 |
*** raunak has joined #openstack-nova | 18:32 | |
mriedem | so i'm ok with fixing the log thing in the rapper patch, but can you also put a comment in that patch for both the build_instances thing and mdbooth's question that had a long explanation? | 18:32 |
dansmith | yep | 18:32 |
mriedem | word homey | 18:33 |
mriedem | also, | 18:33 |
mriedem | no one mentioned your flock of seagulls reference | 18:33 |
mriedem | pick a genre | 18:33 |
dansmith | mriedem: I know, I thought that was amusing :) | 18:33 |
mriedem | i got it though | 18:34 |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #4: full flavor https://review.openstack.org/391288 | 18:34 |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: console https://review.openstack.org/409402 | 18:35 |
openstackgerrit | Dan Smith proposed openstack/nova master: Address minor feedback in superconductor targeting https://review.openstack.org/443175 | 18:35 |
dansmith | mriedem: at least I was decade consistent | 18:36 |
dansmith | afaik, nobody calls them "rappers" anymore | 18:36 |
mriedem | what are they called now? | 18:36 |
dansmith | but they did around the seagulls timeframe | 18:36 |
*** cdent has joined #openstack-nova | 18:36 | |
*** sambetts is now known as sambetts|afk | 18:36 | |
dansmith | um, I dunno, "Hip Hop Artists" ? | 18:36 |
mriedem | yeah maybe | 18:37 |
mriedem | gdi kids | 18:37 |
mriedem | *gd | 18:37 |
dansmith | I feel like if someone said "who's your favorite rapper" nowadays you'd get laughed at, but in the 80s that was a serious question | 18:37 |
mriedem | "umm, vanilla ice, duh!" | 18:37 |
dansmith | I'm sure that was the right answer in heartland america :) | 18:37 |
mriedem | oh psh | 18:38 |
mriedem | odb | 18:38 |
mriedem | snoop?! | 18:38 |
dansmith | snoop was on the trailing end of calling them rappers I think | 18:38 |
*** dharinic is now known as dharinic|lunch | 18:38 | |
dansmith | I'm thinking more like "sir mix a lot" or "ice cube" | 18:38 |
mriedem | oh yeah, too $short | 18:39 |
dansmith | definitely ice-t, he was an early mover | 18:39 |
mriedem | oops | 18:39 |
mriedem | Too $hort | 18:39 |
mriedem | filthy, filthy lyrics | 18:39 |
JayF | I think I found your favorite rapper: http://www.famousbirthdays.com/people/nova.html | 18:40 |
*** swebster has joined #openstack-nova | 18:41 | |
* artom loves that http://www.famousbirthdays.com/names/nova.html is a category | 18:41 | |
mriedem | heh | 18:41 |
artom | The shame of being the *fifth* most poplar person named Nova | 18:41 |
JayF | lol | 18:41 |
*** rcernin has joined #openstack-nova | 18:42 | |
artom | Being sixth and last isn't too bad, it means nobody knows or cares about you | 18:42 |
edleafe | This is more mriedem's style: https://www.youtube.com/watch?v=3yerCiByca4 | 18:42 |
artom | But second to last... Someone cares just enough to give you hope, and then it's all dashed when you find out it's meaningless | 18:42 |
mriedem | edleafe: need i remind you https://www.youtube.com/watch?v=w5Fgp-KihIA | 18:44 |
edleafe | mriedem: ARRRGGGH! Not twice in two days! | 18:45 |
mriedem | my wife accused me of being angry and dissatisfied with everything all the time last night, and i said, oh yeah, would an angry guy have this song within an arms reach?! https://www.youtube.com/watch?v=w5Fgp-KihIA | 18:45 |
dansmith | heh | 18:45 |
edleafe | mriedem: of course he would - to torture his victims with! | 18:46 |
*** ducttape_ has quit IRC | 18:47 | |
*** liangy has quit IRC | 18:47 | |
*** mvk has quit IRC | 18:48 | |
*** sdague has quit IRC | 18:49 | |
*** sdague has joined #openstack-nova | 18:50 | |
mriedem | alright back to work | 18:50 |
*** crushil has quit IRC | 18:59 | |
*** crushil has joined #openstack-nova | 18:59 | |
*** baoli has quit IRC | 19:00 | |
*** baoli has joined #openstack-nova | 19:00 | |
*** baoli has quit IRC | 19:01 | |
*** ijw has joined #openstack-nova | 19:02 | |
*** penick has quit IRC | 19:03 | |
*** cdent has quit IRC | 19:03 | |
*** penick has joined #openstack-nova | 19:05 | |
*** cdent has joined #openstack-nova | 19:08 | |
*** karimb has quit IRC | 19:08 | |
*** baoli has joined #openstack-nova | 19:11 | |
*** pcaruana has quit IRC | 19:13 | |
*** bkopilov_ has joined #openstack-nova | 19:14 | |
*** Matias_ has joined #openstack-nova | 19:14 | |
*** bkopilov has quit IRC | 19:14 | |
*** fragatina has joined #openstack-nova | 19:17 | |
*** dharinic|lunch is now known as dharinic | 19:18 | |
*** Jack_I has quit IRC | 19:18 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Sort CellMappingList.get_all() for safety https://review.openstack.org/443174 | 19:20 |
openstackgerrit | Dan Smith proposed openstack/nova master: Address minor feedback in superconductor targeting https://review.openstack.org/443175 | 19:20 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736 | 19:20 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add get_by_instance_uuids() to InstanceMappingList https://review.openstack.org/443292 | 19:20 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make server_groups determine deleted-ness from InstanceMappingList https://review.openstack.org/443293 | 19:20 |
*** salv-orl_ has joined #openstack-nova | 19:23 | |
*** READ10 has quit IRC | 19:23 | |
*** mvk has joined #openstack-nova | 19:24 | |
*** breitz has quit IRC | 19:25 | |
*** salv-orlando has quit IRC | 19:26 | |
*** breitz has joined #openstack-nova | 19:26 | |
*** mkoderer has quit IRC | 19:27 | |
*** penick has quit IRC | 19:29 | |
*** Apoorva_ has joined #openstack-nova | 19:34 | |
*** karthiks has quit IRC | 19:35 | |
*** Apoorva has quit IRC | 19:36 | |
*** salv-orl_ has quit IRC | 19:37 | |
*** amoralej is now known as amoralej|off | 19:39 | |
*** cdent has quit IRC | 19:40 | |
*** abalutoiu_ has joined #openstack-nova | 19:43 | |
*** karthiks has joined #openstack-nova | 19:47 | |
*** ducttape_ has joined #openstack-nova | 19:47 | |
*** lpetrut has quit IRC | 19:48 | |
*** mnestratov has joined #openstack-nova | 19:49 | |
*** penick has joined #openstack-nova | 19:51 | |
*** Jack_I has joined #openstack-nova | 19:51 | |
*** penick has quit IRC | 19:55 | |
*** mnestratov has quit IRC | 19:56 | |
*** tbachman has quit IRC | 19:59 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Sort CellMappingList.get_all() for safety https://review.openstack.org/443174 | 20:04 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add get_by_instance_uuids() to InstanceMappingList https://review.openstack.org/443292 | 20:04 |
openstackgerrit | Dan Smith proposed openstack/nova master: Address minor feedback in superconductor targeting https://review.openstack.org/443175 | 20:04 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make server_groups determine deleted-ness from InstanceMappingList https://review.openstack.org/443293 | 20:04 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736 | 20:04 |
*** baoli has quit IRC | 20:04 | |
*** baoli has joined #openstack-nova | 20:04 | |
*** karimb has joined #openstack-nova | 20:06 | |
*** gjayavelu has joined #openstack-nova | 20:07 | |
*** baoli has quit IRC | 20:09 | |
*** Apoorva_ has quit IRC | 20:13 | |
*** Apoorva has joined #openstack-nova | 20:14 | |
*** moshele has joined #openstack-nova | 20:17 | |
*** moshele has quit IRC | 20:22 | |
*** dimtruck is now known as zz_dimtruck | 20:23 | |
jaypipes | mriedem: sorry, been out for a few hours dealing with a couple things. yes, ComputeNode.stats is where that stuff lives, IIRC. | 20:24 |
mriedem | dansmith: this one is a bit hairy https://review.openstack.org/#/c/442162/ | 20:26 |
mriedem | but pretty sure _find_service is busted | 20:26 |
*** markvoelker has quit IRC | 20:27 | |
mriedem | jaypipes: np. want to get this in? https://review.openstack.org/#/c/415885 | 20:27 |
*** liangy has joined #openstack-nova | 20:29 | |
dansmith | mriedem: there's a reason I did it that way, give me a sec to remember | 20:30 |
dansmith | mriedem: but I commented on the others | 20:30 |
jaypipes | mriedem: sure, gimme a sec | 20:34 |
*** baoli has joined #openstack-nova | 20:35 | |
dansmith | mriedem: I'm not sure, it works locally and in the gate in the not-first cell looking for n-cpu | 20:35 |
dansmith | but I'm having trouble fetching the context from my brain | 20:35 |
*** rcernin has quit IRC | 20:36 | |
dansmith | oh, no, wait | 20:36 |
dansmith | I bet that is only in the path of service delete, | 20:36 |
dansmith | which might not be n-cpu | 20:37 |
dansmith | dangit | 20:37 |
*** usertm has joined #openstack-nova | 20:37 | |
*** marst_ has quit IRC | 20:37 | |
mriedem | yeah service delete calls service_get_by_id | 20:38 |
mriedem | and we never test service delete | 20:38 |
*** salv-orlando has joined #openstack-nova | 20:38 | |
mriedem | not in tempest anyway | 20:38 |
mriedem | could have a simple functional test with multiple nova-compute services in 2 cells and you delete one in the 2nd cell | 20:38 |
mriedem | that's also going to be jacked... | 20:38 |
mriedem | b/c 2 nova-computes in 2 cells are going to have ids 1 and 2 | 20:39 |
mriedem | so you'll delete the first one found in the first cell | 20:39 |
mriedem | shit | 20:39 |
mriedem | which might not be the one you wanted to delete | 20:39 |
mriedem | i want to delete nova-compute 2 in cell 2, but it depends the service with id=2 in cell1 | 20:39 |
dansmith | yeah, this api is fairly retarded | 20:40 |
mriedem | wasn't there a similar one for getting a compute node by id | 20:42 |
mriedem | yeah compute_node_get | 20:42 |
dansmith | the api does that by name though right? | 20:42 |
*** salv-orlando has quit IRC | 20:42 | |
mriedem | no | 20:43 |
mriedem | your comment even says "Unfortunately this API exposes database identifiers | 20:43 |
mriedem | # which means we really can't do something efficient here" | 20:43 |
mriedem | so the os-hypervisors uptime and show APIs pass in the compute node id | 20:43 |
*** adrian_otto1 has quit IRC | 20:43 | |
dansmith | mriedem: that comment is about service | 20:43 |
mriedem | so we'll be showing details and uptime info for the first match on that id in the first cell we hit | 20:43 |
*** zz_dimtruck is now known as dimtruck | 20:43 | |
mriedem | dansmith: it's in there twice | 20:43 |
mriedem | as i said, this is a hairy change :) | 20:43 |
mriedem | lots of moving parts | 20:44 |
dansmith | okay, I remember seeing name in os-hypervisors multiple times.. maybe there's a search or something? | 20:44 |
mriedem | https://developer.openstack.org/api-ref/compute/?expanded=show-hypervisor-details-detail#show-hypervisor-details | 20:44 |
mriedem | there is the search one | 20:44 |
dansmith | okay maybe that's what I'm thinking of | 20:44 |
mriedem | dansmith: that would be this one https://developer.openstack.org/api-ref/compute/?expanded=search-hypervisor-detail#search-hypervisor | 20:44 |
mriedem | yeah so service delete, and compute node show and uptime are going to be wrong | 20:45 |
mriedem | in multi-cell | 20:45 |
mriedem | there is also some pci device jackholery in _get_all_nodes_pci_devices but that's probably already cell-specific / context aware at that point | 20:45 |
mriedem | at least i hope so | 20:45 |
mriedem | oh no that's in the f'ing api too | 20:46 |
dansmith | come on, the internal DB ids leak out for PCI? | 20:46 |
mriedem | heh, of course we don't actually document the pci api | 20:46 |
mriedem | f yeah they do https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/pci.py#L105 | 20:47 |
mriedem | oh well | 20:47 |
mriedem | maybe not in that case | 20:47 |
dansmith | admins can see them? | 20:48 |
dansmith | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/pci.py#L28 | 20:48 |
mriedem | so for listing pci devices, we get all compute nodes in all cells, and then get all pci devices for all compute nodes in all cells | 20:48 |
dansmith | mriedem: okay so I squashed the revision patch from the top into the base patch, which needed a recheck in the gate anyway, | 20:50 |
dansmith | mriedem: and I guess I'll stack this one at the endish so we can proceed separate from the compute id problem | 20:50 |
mriedem | i thought you needed this hypervisor one to get tests passing? | 20:50 |
mriedem | also, cells meeting in 9 minutes | 20:51 |
dansmith | I surely do, but not any more than any of the rest of it | 20:51 |
dansmith | although this touches a lot of stuff, so it'll probably not be easy to move it.. fsck | 20:51 |
dansmith | or not.. it moved with no conflicts | 20:51 |
*** ducttape_ has quit IRC | 20:52 | |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #4: full flavor https://review.openstack.org/391288 | 20:55 |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: console https://review.openstack.org/409402 | 20:55 |
*** karimb has quit IRC | 20:55 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Target cell in super conductor operations https://review.openstack.org/438022 | 20:56 |
openstackgerrit | Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023 | 20:56 |
openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-migrations about cells https://review.openstack.org/442685 | 20:56 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024 | 20:56 |
openstackgerrit | Dan Smith proposed openstack/nova master: Teach simple_tenant_usage about cells https://review.openstack.org/441388 | 20:56 |
openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-aggregates about cells https://review.openstack.org/442200 | 20:56 |
dansmith | okay, that's ^ a partial stack of things you have not yet shat upon | 20:57 |
dansmith | that hopefully can go ahead of the things that have bigger questions | 20:57 |
mriedem | i've got an idea of the path forward, but we can talk about it during the cells meeting | 20:59 |
*** satyar has quit IRC | 20:59 | |
dansmith | when those are done in check I'll push up the rest, which has the edits to the HostAPI patch, minus anything about the id leakage | 20:59 |
mriedem | where i'm sure you'll sh*t upon it | 20:59 |
dansmith | ...says the major shitter in this convo | 20:59 |
*** spotz is now known as spotz_zzz | 20:59 | |
mriedem | hey, i know you appreciate it deep down | 20:59 |
*** spotz_zzz is now known as spotz | 21:00 | |
*** crushil has quit IRC | 21:05 | |
*** ducttape_ has joined #openstack-nova | 21:05 | |
jaypipes | sfinucan: https://review.openstack.org/#/c/385023/ | 21:09 |
*** adisky_ has quit IRC | 21:09 | |
*** yamamoto has joined #openstack-nova | 21:15 | |
*** tbachman has joined #openstack-nova | 21:15 | |
*** yamamoto has quit IRC | 21:18 | |
*** yamamoto has joined #openstack-nova | 21:20 | |
*** lpetrut has joined #openstack-nova | 21:23 | |
*** adrian_otto has joined #openstack-nova | 21:24 | |
*** JoseMello has quit IRC | 21:25 | |
*** markvoelker has joined #openstack-nova | 21:27 | |
*** thorst has quit IRC | 21:30 | |
*** thorst has joined #openstack-nova | 21:31 | |
*** smatzek_ has quit IRC | 21:31 | |
*** salv-orlando has joined #openstack-nova | 21:31 | |
*** markvoelker has quit IRC | 21:32 | |
*** Jeffrey4l_ has quit IRC | 21:34 | |
*** Jeffrey4l_ has joined #openstack-nova | 21:35 | |
*** thorst has quit IRC | 21:35 | |
*** gouthamr has quit IRC | 21:38 | |
*** crushil has joined #openstack-nova | 21:39 | |
*** dillaman has quit IRC | 21:43 | |
*** slaweq_ has joined #openstack-nova | 21:46 | |
*** yamamoto has quit IRC | 21:47 | |
*** thorst has joined #openstack-nova | 21:50 | |
*** adrian_otto has quit IRC | 21:50 | |
*** crushil has quit IRC | 21:53 | |
*** sdague has quit IRC | 21:55 | |
macsz | mriedem: want to talk now? | 21:56 |
mriedem | macsz: sure | 21:56 |
mriedem | let me find the link | 21:56 |
mriedem | macsz: this is what i had started for ci testing https://review.openstack.org/#/c/441696/ | 21:57 |
*** browne has quit IRC | 21:57 | |
mriedem | i use devstack-gate to test out changes that eventually go into project-config for job changes | 21:57 |
*** awaugama has quit IRC | 21:57 | |
mriedem | i'm trying to get a ci run with searchlight deployed, | 21:57 |
mriedem | and everything setup such that nova is sending notifications and searchlight is consuming them | 21:57 |
mriedem | since we'll need that in a ci job when nova-api starts using searchlight to list instances | 21:57 |
mriedem | it should be fairly mechanical, i'm just having a hard time finding the time to work on it | 21:58 |
mriedem | for example, the searchlight devstack plugin doesn't configure anything except searchlight, | 21:58 |
mriedem | but when reading the searchlight deploy docs, they talk about configuring nova | 21:58 |
mriedem | e.g. https://review.openstack.org/#/c/441711/ | 21:58 |
macsz | mriedem: hmm ok | 22:00 |
mriedem | macsz: it might also just be a matter of getting searchlight setup locally with devstack, including the horizon plugin, | 22:01 |
*** gouthamr has joined #openstack-nova | 22:01 | |
macsz | I will look through the docs and will try to deploy it locally | 22:01 |
mriedem | and then make sure when you create an instance in nova, does it show up in searchlight in horizon | 22:01 |
mriedem | and then note any deployment changes you need to make to devstack along the way, and that is the list of stuff we have to do for the CI job | 22:01 |
mriedem | the CI job won't need the searchlight ui plugin since we don't test horizon, but that would help you locally | 22:02 |
mriedem | i'm thinking it will be a pretty small set of changes we need, but i haven't had the time to do it locally - would be awesome if someone can go through that | 22:02 |
jaypipes | rfolco: https://review.openstack.org/#/c/416669/ ready for rebasing. | 22:02 |
mriedem | like, i already noticed some issues in the searchlight docs just reading it | 22:02 |
mriedem | and pushed fixes | 22:02 |
*** eharney_ has joined #openstack-nova | 22:03 | |
rfolco | jaypipes, I just saw. Would work on that firt hour tomorrow morning. Thanks for your help on that. | 22:03 |
rfolco | jaypipes, need a microversion bump also | 22:04 |
jaypipes | rfolco: np. I'll look for it and review tomorrow. should be able to merge that pretty quickly. | 22:04 |
jaypipes | rfolco: yup. | 22:04 |
macsz | mriedem: ok, I will try to push this further, will keep you posted on the progress and if anything pops up | 22:04 |
mriedem | macsz: awesome, thank you | 22:05 |
*** ducttape_ has quit IRC | 22:05 | |
*** ducttape_ has joined #openstack-nova | 22:05 | |
rfolco | jaypipes, and I would bother you for keeping active on some upstream work too, if any pointer on where you need some help, let me know pls. | 22:05 |
jaypipes | rfolco: what's your level of tolerance for NUMA? :) | 22:06 |
macsz | mriedem: np :) | 22:06 |
*** eharney has quit IRC | 22:07 | |
rfolco | jaypipes, very very interested. I found some bugs on ppc testing numa :) | 22:07 |
rfolco | jaypipes, like this one https://review.openstack.org/#/c/340599/ | 22:08 |
jaypipes | rfolco: k. read this spec and thoroughly understand the concepts in it: https://review.openstack.org/#/c/284094/10/specs/ocata/approved/libvirt-emulator-threads-policy.rst. Then come help sfinucan and I on the review series here: https://review.openstack.org/#/c/400875/. While reviewing, consider how such resources might be represented in the new placement API (once nested resource providers are mergerd) | 22:08 |
dansmith | jaypipes: I threw up a bit in my mouth just *reading* that | 22:08 |
jaypipes | dansmith: yup. | 22:09 |
*** eharney_ is now known as eharney | 22:09 | |
jaypipes | NUMA and I have a love-hate relationship. | 22:09 |
dansmith | like it loves you and you hate it? | 22:09 |
jaypipes | heh | 22:10 |
*** aysyd has quit IRC | 22:10 | |
mriedem | jaypipes: you forgot to tell him to understand wtf nested resource providers are | 22:10 |
*** cleong has quit IRC | 22:11 | |
jaypipes | mriedem: tru enough. rfolco we can discuss tomorrow what nested resource providers are :) but in case you're interested in some "light" reading. https://review.openstack.org/#/c/386710/1/specs/ocata/approved/nested-resource-providers.rst | 22:11 |
*** dave-mccowan has quit IRC | 22:13 | |
*** yassine has quit IRC | 22:13 | |
rfolco | jaypipes, cool. Thanks! | 22:14 |
jaypipes | rfolco: don't thank me until you read those ;P | 22:15 |
* rfolco hides | 22:15 | |
edleafe | rfolco: you can't hide :) | 22:16 |
rfolco | edleafe, :-/ | 22:19 |
*** edmondsw has quit IRC | 22:20 | |
*** artom has quit IRC | 22:21 | |
*** yassine has joined #openstack-nova | 22:21 | |
*** edmondsw has joined #openstack-nova | 22:23 | |
mriedem | pcidevice.address is a mac? | 22:25 |
mriedem | jaypipes: ^? | 22:25 |
dansmith | mriedem: no it's a pci address I think, like 1.34 | 22:25 |
mriedem | oh | 22:26 |
dansmith | or 0:1.34 or something like that | 22:26 |
mriedem | ok, was wondering why we needed the compute node id to uniquely identify a pcidevice by address | 22:26 |
mriedem | in pci_device_get_by_addr | 22:26 |
openstackgerrit | Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023 | 22:26 |
openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-migrations about cells https://review.openstack.org/442685 | 22:26 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024 | 22:26 |
openstackgerrit | Dan Smith proposed openstack/nova master: Teach simple_tenant_usage about cells https://review.openstack.org/441388 | 22:26 |
openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-aggregates about cells https://review.openstack.org/442200 | 22:26 |
openstackgerrit | Dan Smith proposed openstack/nova master: Refactor cell loading in compute/api https://review.openstack.org/443337 | 22:26 |
mriedem | if we don't want to expose the pcidevice.id in the rest api, and get them by that id, and we don't have a uuid, we need something else | 22:26 |
*** artom has joined #openstack-nova | 22:27 | |
mriedem | unless we add a uuid to the pcidevices table/object | 22:27 |
dansmith | *shudder* | 22:27 |
mriedem | yeah the only unique constraints are the id (primary key) and node_id/address | 22:27 |
mriedem | so, we'd have to add a uuid | 22:27 |
*** edmondsw has quit IRC | 22:28 | |
mriedem | heh, or we just deprecate that dumbass api and say you can't use it with multiple cells :) | 22:28 |
dansmith | heh | 22:28 |
mriedem | i feel like that was a half-baked api | 22:28 |
dansmith | s/api// | 22:28 |
mriedem | and if you want to know what pci devices are on a given compute node, you get them via the compute node resource provider | 22:29 |
mriedem | traits on the resource provider | 22:29 |
mriedem | jaypipes: will pcidevices be a trait on a compute node resource provider? | 22:29 |
*** armax has quit IRC | 22:29 | |
mriedem | will/can | 22:29 |
*** tbachman has quit IRC | 22:31 | |
*** yamamoto has joined #openstack-nova | 22:31 | |
jaypipes | mriedem: depends on what kind of PCI device. | 22:31 |
mriedem | dansmith: shart, services table doesn't have uuid either | 22:32 |
*** tbachman has joined #openstack-nova | 22:32 | |
jaypipes | mriedem: SRIOV physical functions will be either child providers of a compute node *or* child providers of a NUMA socket resource provider, depending on whether the SRIOV NIC is affined to a particular NUMA socket. | 22:32 |
efried | mikal - Any chance we can start getting some reviews on change sets under https://review.openstack.org/#/q/topic:bp/powervm-nova-compute-driver ? The ones with +1s from nova-powervm cores (e.g. thorst adreznec esberglu) are ready for your look. Conveniently numbered, too ;-) | 22:33 |
jaypipes | mriedem: but pcidevices will definitely not be a "trait". Rather, things like the physical network tag would be a trait on the SRIOV physical function resource provider. | 22:33 |
*** lpetrut has quit IRC | 22:33 | |
mriedem | jaypipes: ack | 22:33 |
mriedem | i was looking for a way to weasle out of the compute rest api needing to show pcidevice per node information | 22:34 |
openstackgerrit | Sarafraj Singh proposed openstack/nova-specs master: WIP: Replace live migration steps and delays with memory iteration logic https://review.openstack.org/443339 | 22:34 |
mriedem | it's all information in os-pci, like all pcidevices on a node, and all pcidevices for a server | 22:34 |
mriedem | *informational | 22:35 |
jaypipes | mriedem: right. | 22:35 |
mriedem | and if i could say, get that information elsewhere... | 22:35 |
mriedem | my life would be easier | 22:35 |
mriedem | seems to fall into the 'nova does not want to be a metrics gatherer' anymore stadium | 22:35 |
jaypipes | mriedem: eventually the placement API will be able to represent the tree of providers on a compute node, yes. But things like PCI address information will not be in the placement API. | 22:36 |
mriedem | sure | 22:36 |
mriedem | ok, well i'll just spec this up with the way things are today then | 22:36 |
jaypipes | kk | 22:36 |
jaypipes | mriedem: I'm still yet to get to that spec though... | 22:36 |
jaypipes | the pcidevices one you linked to earlier. | 22:36 |
jaypipes | have it on the list. | 22:36 |
jaypipes | currently working on a review of moshele's SRIOV port pair allocation one. | 22:37 |
jaypipes | https://review.openstack.org/#/c/182242/33/specs/pike/approved/user-controlled-sriov-ports-allocation.rst | 22:37 |
mriedem | jaypipes: yeah this is different actually | 22:37 |
mriedem | related to cells v2 | 22:37 |
mriedem | shenanigans | 22:37 |
jaypipes | ah, ok. | 22:37 |
jaypipes | sorry | 22:37 |
mriedem | don't be | 22:37 |
mriedem | i just use you as my encyclopedia of nova horrors | 22:38 |
*** browne has joined #openstack-nova | 22:40 | |
*** karthiks has quit IRC | 22:42 | |
*** haplo37 has quit IRC | 22:42 | |
*** catintheroof has quit IRC | 22:44 | |
openstackgerrit | Sujitha proposed openstack/nova master: Reduce calls to load_tags() to 0 https://review.openstack.org/435146 | 22:44 |
*** mlakat has joined #openstack-nova | 22:45 | |
*** mlakat has quit IRC | 22:45 | |
mriedem | jaypipes: dansmith: i'm going to head home, but wrote up the abstract for the spec i'm going to work on later https://blueprints.launchpad.net/nova/+spec/service-hyper-pci-uuid-in-api | 22:47 |
mriedem | let me know if i screwed anything up in there | 22:47 |
jaypipes | mriedem: will do. thx. | 22:47 |
*** tblakes has quit IRC | 22:47 | |
*** esberglu has quit IRC | 22:51 | |
*** felipemonteiro_ has quit IRC | 22:51 | |
*** haplo37 has joined #openstack-nova | 22:51 | |
*** esberglu has joined #openstack-nova | 22:52 | |
*** mriedem has quit IRC | 22:52 | |
openstackgerrit | Dan Peschman proposed openstack/nova master: No API cell up-call to delete consoleauth tokens https://review.openstack.org/415922 | 22:53 |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189 | 22:53 |
*** usertm has quit IRC | 22:53 | |
*** tbachman has quit IRC | 22:54 | |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189 | 22:54 |
*** karthiks has joined #openstack-nova | 22:54 | |
*** thorst has quit IRC | 22:54 | |
*** markvoelker has joined #openstack-nova | 22:54 | |
*** ducttape_ has quit IRC | 22:55 | |
*** thorst has joined #openstack-nova | 22:55 | |
*** ducttape_ has joined #openstack-nova | 22:55 | |
*** esberglu has quit IRC | 22:56 | |
*** mdrabe has quit IRC | 22:56 | |
*** edmondsw has joined #openstack-nova | 22:57 | |
*** xyang1 has quit IRC | 22:58 | |
*** tbachman has joined #openstack-nova | 22:58 | |
*** thorst has quit IRC | 22:59 | |
*** edmondsw has quit IRC | 23:01 | |
*** baoli has quit IRC | 23:02 | |
*** iceyao has joined #openstack-nova | 23:04 | |
*** raunak has quit IRC | 23:05 | |
*** Jack_I has quit IRC | 23:06 | |
*** marst has joined #openstack-nova | 23:06 | |
*** iceyao has quit IRC | 23:08 | |
*** jamesdenton has quit IRC | 23:08 | |
*** kylek3h has quit IRC | 23:11 | |
*** tblakes has joined #openstack-nova | 23:12 | |
*** eharney has quit IRC | 23:12 | |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189 | 23:13 |
*** raunak has joined #openstack-nova | 23:13 | |
*** adrian_otto has joined #openstack-nova | 23:14 | |
*** yassine has quit IRC | 23:16 | |
*** gaurangt has quit IRC | 23:19 | |
*** gaurangt has joined #openstack-nova | 23:19 | |
*** thorst has joined #openstack-nova | 23:20 | |
*** tblakes has quit IRC | 23:24 | |
*** thorst has quit IRC | 23:24 | |
*** catintheroof has joined #openstack-nova | 23:28 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/443357 | 23:28 |
*** adrian_otto has quit IRC | 23:29 | |
*** adrian_otto has joined #openstack-nova | 23:31 | |
*** gfhellma_ has joined #openstack-nova | 23:32 | |
openstackgerrit | Jay Pipes proposed openstack/nova master: virt: implement get_inventory() for Ironic https://review.openstack.org/441544 | 23:33 |
jaypipes | dansmith: ^^ | 23:33 |
dansmith | jaypipes: done thanks | 23:34 |
*** gfhellma has quit IRC | 23:35 | |
jaypipes | dansmith: danke | 23:35 |
*** ducttape_ has quit IRC | 23:35 | |
*** tbachman has quit IRC | 23:36 | |
*** mriedem has joined #openstack-nova | 23:37 | |
*** ducttape_ has joined #openstack-nova | 23:38 | |
*** dimtruck is now known as zz_dimtruck | 23:46 | |
*** liangy has quit IRC | 23:53 | |
*** david-lyle has quit IRC | 23:56 | |
*** nicolasbock has quit IRC | 23:57 | |
*** gfhellma_ has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!