*** hongbin has quit IRC | 00:00 | |
*** edmondsw has joined #openstack-nova | 00:03 | |
*** ZZelle has quit IRC | 00:04 | |
*** ijw has joined #openstack-nova | 00:05 | |
*** edmondsw has quit IRC | 00:08 | |
*** mtanino has joined #openstack-nova | 00:14 | |
*** baoli has joined #openstack-nova | 00:22 | |
*** kenperkins has quit IRC | 00:23 | |
*** kaisers_ has joined #openstack-nova | 00:24 | |
*** masber has joined #openstack-nova | 00:24 | |
*** baoli has quit IRC | 00:26 | |
*** armax has quit IRC | 00:26 | |
*** amotoki has joined #openstack-nova | 00:26 | |
*** kaisers_ has quit IRC | 00:28 | |
*** dikonoor has joined #openstack-nova | 00:28 | |
alex_xu | mriedem: for security-groups API, there is spec for it https://review.openstack.org/#/c/382414/2/specs/ocata/approved/api-secuirty-group-rework.rst | 00:34 |
---|---|---|
*** catintheroof has joined #openstack-nova | 00:35 | |
*** gcb_ has quit IRC | 00:35 | |
*** zul has quit IRC | 00:36 | |
alex_xu | mriedem: do we have job for live-migration with ceph in the ci? | 00:37 |
*** mtanino has quit IRC | 00:39 | |
*** gyee_ has quit IRC | 00:40 | |
*** zul has joined #openstack-nova | 00:41 | |
*** gongysh has quit IRC | 00:42 | |
*** Guest68764 has quit IRC | 00:43 | |
*** adrian_otto has quit IRC | 00:50 | |
*** Guest68764 has joined #openstack-nova | 00:50 | |
*** Shunli has joined #openstack-nova | 00:52 | |
*** zsli_ has joined #openstack-nova | 00:52 | |
*** zsli_ has quit IRC | 00:52 | |
*** Shunli has quit IRC | 00:52 | |
*** Shunli has joined #openstack-nova | 00:52 | |
*** diga has quit IRC | 00:56 | |
*** gszasz has quit IRC | 00:56 | |
*** kevinz has joined #openstack-nova | 00:58 | |
*** browne has quit IRC | 01:01 | |
*** dikonoor has quit IRC | 01:03 | |
*** mriedem has quit IRC | 01:03 | |
openstackgerrit | Claudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages https://review.openstack.org/447505 | 01:05 |
*** phuongnh has joined #openstack-nova | 01:05 | |
*** krtaylor has joined #openstack-nova | 01:06 | |
*** catintheroof has quit IRC | 01:08 | |
*** gjayavelu has quit IRC | 01:10 | |
*** mriedem has joined #openstack-nova | 01:12 | |
*** yamamoto has joined #openstack-nova | 01:12 | |
mriedem | alex_xu: https://review.openstack.org/#/c/389582/ | 01:13 |
*** jamielennox is now known as jamielennox|away | 01:16 | |
*** iceyao has joined #openstack-nova | 01:16 | |
*** jamielennox|away is now known as jamielennox | 01:28 | |
*** Apoorva has quit IRC | 01:28 | |
gmann | alex_xu: johnthetubaguy how about base class name to "create_documented_rule_default" in https://review.openstack.org/#/c/434842/13 | 01:29 |
*** nic has quit IRC | 01:30 | |
gmann | no strong opinion, current one also fine to me | 01:30 |
*** Sukhdev_ has quit IRC | 01:31 | |
*** iceyao has quit IRC | 01:33 | |
*** ducnc has quit IRC | 01:35 | |
*** dimtruck is now known as zz_dimtruck | 01:35 | |
*** kaisers1 has joined #openstack-nova | 01:35 | |
alex_xu | mriedem: thanks | 01:35 |
*** mriedem has left #openstack-nova | 01:36 | |
*** mriedem has joined #openstack-nova | 01:36 | |
alex_xu | gmann: i'm ok both. i thought in the future we only allowed to create default rule by that method, so i'm fine that name didn't expose too much detail | 01:36 |
*** rfolco has joined #openstack-nova | 01:36 | |
openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Spec for libvirt driver extension for Veritas HyperScale https://review.openstack.org/430488 | 01:37 |
*** kaisers has quit IRC | 01:37 | |
*** claudiub has quit IRC | 01:37 | |
*** ssurana has joined #openstack-nova | 01:37 | |
*** iceyao has joined #openstack-nova | 01:38 | |
gmann | alex_xu: ok. yea having doc string should be enough though | 01:39 |
*** ssurana has quit IRC | 01:42 | |
*** iceyao has quit IRC | 01:43 | |
*** JDub has joined #openstack-nova | 01:48 | |
*** gcb has joined #openstack-nova | 01:49 | |
*** alexpilotti has quit IRC | 01:50 | |
*** gongysh has joined #openstack-nova | 01:50 | |
*** crushil has joined #openstack-nova | 01:51 | |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Drop deprecated aggregate-update positional args https://review.openstack.org/447332 | 01:51 |
*** browne has joined #openstack-nova | 01:53 | |
*** JDub has quit IRC | 01:56 | |
*** zhurong has joined #openstack-nova | 01:57 | |
*** browne has quit IRC | 02:02 | |
*** kaisers has joined #openstack-nova | 02:03 | |
*** ijw has quit IRC | 02:06 | |
*** kaisers has quit IRC | 02:07 | |
*** jichen has joined #openstack-nova | 02:09 | |
*** mriedem has quit IRC | 02:14 | |
*** adrian_otto has joined #openstack-nova | 02:14 | |
*** wangqun has joined #openstack-nova | 02:15 | |
*** gouthamr has joined #openstack-nova | 02:16 | |
*** kenperkins has joined #openstack-nova | 02:19 | |
*** wally has quit IRC | 02:20 | |
*** ducnc has joined #openstack-nova | 02:25 | |
*** unicell1 has quit IRC | 02:31 | |
*** zz_dimtruck is now known as dimtruck | 02:32 | |
*** esberglu has joined #openstack-nova | 02:35 | |
*** esberglu has quit IRC | 02:39 | |
*** yamamoto has quit IRC | 02:41 | |
*** hongbin has joined #openstack-nova | 02:47 | |
openstackgerrit | Spencer Yu proposed openstack/python-novaclient master: Nova client should retry with Retry-After value https://review.openstack.org/447766 | 02:47 |
openstackgerrit | Maciej Szankin proposed openstack/nova-specs master: Add use-local-scheduler spec https://review.openstack.org/438936 | 02:47 |
*** yamamoto has joined #openstack-nova | 02:48 | |
*** alexpilotti has joined #openstack-nova | 02:50 | |
*** zsli_ has joined #openstack-nova | 02:52 | |
*** Shunli has quit IRC | 02:54 | |
*** masber has quit IRC | 02:54 | |
*** gcb has quit IRC | 02:58 | |
*** kaisers has joined #openstack-nova | 03:00 | |
*** nicolasbock has quit IRC | 03:02 | |
*** alexpilotti has quit IRC | 03:04 | |
*** kaisers has quit IRC | 03:04 | |
*** zhurong has quit IRC | 03:05 | |
*** adrian_otto has quit IRC | 03:06 | |
*** rfolco has quit IRC | 03:06 | |
*** leseb_ has quit IRC | 03:11 | |
*** leseb_ has joined #openstack-nova | 03:12 | |
*** rfolco has joined #openstack-nova | 03:13 | |
*** rfolco has quit IRC | 03:13 | |
*** gcb has joined #openstack-nova | 03:14 | |
*** bkopilov has quit IRC | 03:14 | |
*** gcb has quit IRC | 03:14 | |
*** masber has joined #openstack-nova | 03:15 | |
*** gcb has joined #openstack-nova | 03:15 | |
*** dimtruck is now known as zz_dimtruck | 03:21 | |
*** zhurong has joined #openstack-nova | 03:22 | |
*** namnh has joined #openstack-nova | 03:22 | |
*** armax has joined #openstack-nova | 03:24 | |
*** yamamoto has quit IRC | 03:25 | |
*** guchihiro has joined #openstack-nova | 03:26 | |
*** dave-mccowan has quit IRC | 03:29 | |
*** guchihiro has quit IRC | 03:30 | |
*** adrian_otto has joined #openstack-nova | 03:32 | |
*** fragatin_ has joined #openstack-nova | 03:34 | |
*** kenperkins has quit IRC | 03:38 | |
*** fragatina has quit IRC | 03:38 | |
*** fragatin_ has quit IRC | 03:39 | |
*** fragatina has joined #openstack-nova | 03:40 | |
*** DeathShow has joined #openstack-nova | 03:42 | |
*** fragatin_ has joined #openstack-nova | 03:43 | |
*** DeathShow has quit IRC | 03:43 | |
*** links has joined #openstack-nova | 03:44 | |
*** fragatina has quit IRC | 03:45 | |
*** MarkMielke has joined #openstack-nova | 03:45 | |
*** yamahata has quit IRC | 03:47 | |
*** fragatin_ has quit IRC | 03:47 | |
*** sree has joined #openstack-nova | 03:50 | |
*** crushil has quit IRC | 03:50 | |
*** namnh_ has joined #openstack-nova | 03:55 | |
*** namnh has quit IRC | 03:58 | |
*** tovin07_ has joined #openstack-nova | 04:00 | |
*** hongbin has quit IRC | 04:02 | |
*** fragatina has joined #openstack-nova | 04:03 | |
*** guchihiro has joined #openstack-nova | 04:03 | |
*** fragatina has quit IRC | 04:03 | |
*** fragatina has joined #openstack-nova | 04:04 | |
*** adrian_otto has quit IRC | 04:06 | |
*** adrian_otto has joined #openstack-nova | 04:07 | |
*** yamamoto has joined #openstack-nova | 04:09 | |
*** jamielennox is now known as jamielennox|away | 04:12 | |
*** zhurong has quit IRC | 04:12 | |
*** esberglu has joined #openstack-nova | 04:24 | |
*** psachin has joined #openstack-nova | 04:27 | |
*** esberglu has quit IRC | 04:29 | |
*** adrian_otto has quit IRC | 04:29 | |
*** adisky_ has joined #openstack-nova | 04:32 | |
*** bkopilov has joined #openstack-nova | 04:32 | |
*** kaisers has joined #openstack-nova | 04:39 | |
*** kaisers has quit IRC | 04:43 | |
*** unicell has joined #openstack-nova | 04:48 | |
*** udesale has joined #openstack-nova | 04:50 | |
*** jaypipes has quit IRC | 04:57 | |
*** jaypipes has joined #openstack-nova | 04:57 | |
*** yamahata has joined #openstack-nova | 04:59 | |
*** zhurong has joined #openstack-nova | 05:00 | |
*** alexpilotti has joined #openstack-nova | 05:01 | |
*** gouthamr has quit IRC | 05:03 | |
*** udesale has quit IRC | 05:03 | |
*** artom has quit IRC | 05:04 | |
*** ayogi has joined #openstack-nova | 05:05 | |
*** alexpilotti has quit IRC | 05:05 | |
*** udesale has joined #openstack-nova | 05:06 | |
*** udesale has quit IRC | 05:09 | |
*** udesale has joined #openstack-nova | 05:09 | |
*** ratailor has joined #openstack-nova | 05:13 | |
*** lpetrut has joined #openstack-nova | 05:19 | |
openstackgerrit | Shunli Zhou proposed openstack/nova master: Remove mox from cells/test_cells_rpc_driver.py https://review.openstack.org/447412 | 05:26 |
*** prateek has joined #openstack-nova | 05:27 | |
*** satyar has joined #openstack-nova | 05:29 | |
*** Jack_Iv has joined #openstack-nova | 05:34 | |
*** artom has joined #openstack-nova | 05:34 | |
*** Jack_Iv has quit IRC | 05:36 | |
*** mirrorbo1 is now known as mirrorbox | 05:37 | |
*** mirrorbox has joined #openstack-nova | 05:37 | |
*** zhurong has quit IRC | 05:40 | |
*** rcernin has joined #openstack-nova | 05:43 | |
*** abalutoiu has quit IRC | 05:44 | |
*** gjayavelu has joined #openstack-nova | 05:50 | |
*** markvoelker has quit IRC | 05:53 | |
*** claudiub has joined #openstack-nova | 05:57 | |
*** rcernin has quit IRC | 05:57 | |
*** iceyao has joined #openstack-nova | 05:58 | |
*** iceyao has quit IRC | 05:59 | |
*** Jack_Iv has joined #openstack-nova | 06:00 | |
*** alexpilotti has joined #openstack-nova | 06:02 | |
*** NikhilS has joined #openstack-nova | 06:03 | |
*** alexpilotti has quit IRC | 06:06 | |
*** udesale has quit IRC | 06:06 | |
*** udesale has joined #openstack-nova | 06:07 | |
openstackgerrit | Maho Koshiya proposed openstack/nova master: Add confirm resized server functional negative tests https://review.openstack.org/421074 | 06:09 |
*** lpetrut has quit IRC | 06:13 | |
*** esberglu has joined #openstack-nova | 06:13 | |
*** unicell1 has joined #openstack-nova | 06:15 | |
*** unicell has quit IRC | 06:15 | |
*** esberglu has quit IRC | 06:17 | |
openstackgerrit | lan proposed openstack/os-vif master: delete _LE https://review.openstack.org/447865 | 06:21 |
*** unicell1 has quit IRC | 06:22 | |
*** unicell has joined #openstack-nova | 06:22 | |
*** nkrinner_afk is now known as nkrinner | 06:28 | |
*** lpetrut has joined #openstack-nova | 06:30 | |
*** kornicameister has joined #openstack-nova | 06:31 | |
*** jaosorior has joined #openstack-nova | 06:31 | |
*** ekuris has joined #openstack-nova | 06:33 | |
*** lpetrut has quit IRC | 06:34 | |
*** kornicameister has quit IRC | 06:35 | |
*** ssurana has joined #openstack-nova | 06:36 | |
openstackgerrit | lan proposed openstack/os-vif master: Log messages are no longer being translated. so, removes all use of the _LE, _LI, and _LW translation markers to simplify logging and to avoid confusion with new contributions. https://review.openstack.org/447865 | 06:43 |
*** psachin_ has joined #openstack-nova | 06:44 | |
*** psachin has quit IRC | 06:46 | |
openstackgerrit | lan proposed openstack/os-vif master: 1.Log messages are no longer being translated. so, removes all use of the _LE, _LI, and _LW translation markers to simplify logging and to avoid confusion with new contributions. https://review.openstack.org/447865 | 06:53 |
*** sridharg has joined #openstack-nova | 06:53 | |
*** markvoelker has joined #openstack-nova | 06:54 | |
*** mnestratov has joined #openstack-nova | 06:56 | |
*** fragatina has quit IRC | 06:56 | |
*** markvoelker has quit IRC | 06:58 | |
*** amotoki_ has joined #openstack-nova | 07:00 | |
*** tuanluong has joined #openstack-nova | 07:00 | |
*** david-lyle has quit IRC | 07:02 | |
*** amotoki has quit IRC | 07:03 | |
*** alexpilotti has joined #openstack-nova | 07:03 | |
*** alexpilotti has quit IRC | 07:07 | |
*** andreas_s has joined #openstack-nova | 07:08 | |
*** unicell has quit IRC | 07:12 | |
*** unicell has joined #openstack-nova | 07:12 | |
openstackgerrit | lan proposed openstack/os-vif master: 1.Log messages are no longer being translated. so, removes all use of the _LE, _LI, and _LW translation markers to simplify logging and to avoid confusion with new contributions. https://review.openstack.org/447865 | 07:14 |
*** amotoki has joined #openstack-nova | 07:18 | |
*** seife_ has joined #openstack-nova | 07:19 | |
*** iceyao has joined #openstack-nova | 07:19 | |
*** iceyao has quit IRC | 07:20 | |
*** seife_ has quit IRC | 07:21 | |
*** amotoki_ has quit IRC | 07:21 | |
*** lpetrut has joined #openstack-nova | 07:27 | |
*** tesseract has joined #openstack-nova | 07:35 | |
openstackgerrit | Spencer Yu proposed openstack/python-novaclient master: Nova client should retry with Retry-After value https://review.openstack.org/447766 | 07:35 |
*** alexpilotti has joined #openstack-nova | 07:37 | |
*** alexpilotti has quit IRC | 07:42 | |
*** psachin_ has quit IRC | 07:47 | |
*** cdent has joined #openstack-nova | 07:47 | |
*** ralonsoh has joined #openstack-nova | 07:49 | |
*** moshele has joined #openstack-nova | 07:50 | |
*** markus_z has joined #openstack-nova | 07:52 | |
*** ssurana has quit IRC | 07:53 | |
openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Add live-migration-force-after-timeout https://review.openstack.org/430218 | 07:59 |
*** psachin_ has joined #openstack-nova | 07:59 | |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-nova | 08:00 | |
*** CristinaPauna has quit IRC | 08:01 | |
*** sree_ has joined #openstack-nova | 08:01 | |
*** sree_ is now known as Guest29284 | 08:01 | |
*** esberglu has joined #openstack-nova | 08:02 | |
*** alexpilotti has joined #openstack-nova | 08:02 | |
*** lpetrut has quit IRC | 08:03 | |
*** sree has quit IRC | 08:04 | |
*** gibi has joined #openstack-nova | 08:05 | |
*** venki has joined #openstack-nova | 08:05 | |
*** CristinaPauna has joined #openstack-nova | 08:06 | |
*** esberglu has quit IRC | 08:06 | |
*** alexpilotti has quit IRC | 08:06 | |
*** alexpilotti has joined #openstack-nova | 08:08 | |
*** voelzmo has joined #openstack-nova | 08:10 | |
*** pcaruana has joined #openstack-nova | 08:11 | |
venki | Hi Guys, | 08:12 |
venki | When i tried to run devstack using this config http://paste.openstack.org/show/603570/ . | 08:12 |
venki | I am getting the error : | 08:12 |
venki | 2017-03-21 08:07:27.650 | [ERROR] /opt/stack/ironic/devstack/lib/ironic:1412 Timed out waiting for Nova hypervisor-stats vcpus >= 3 | 08:12 |
venki | Anyone pls help... | 08:12 |
*** alexpilotti has quit IRC | 08:13 | |
*** snecklifter has quit IRC | 08:13 | |
*** ltomasbo|away is now known as ltomasbo | 08:14 | |
*** alexpilotti has joined #openstack-nova | 08:18 | |
*** alexpilotti has quit IRC | 08:23 | |
*** guchihiro has quit IRC | 08:24 | |
bauzas | good morning Nova | 08:26 |
bauzas | venki: in general, you should look at your devstack logs | 08:27 |
bauzas | venki: in particular n-api.log for beginning | 08:27 |
*** alexpilotti has joined #openstack-nova | 08:27 | |
bauzas | venki: AFAIK, Ironic waits until Nova finds 3 compute nodes | 08:27 |
bauzas | those 3 nodes are just 3 ironic nodes | 08:28 |
bauzas | fake ones | 08:28 |
*** crusio has quit IRC | 08:30 | |
*** abalutoiu has joined #openstack-nova | 08:30 | |
-openstackstatus- NOTICE: Wiki is broken with database problems, we are working to resolve it | 08:32 | |
*** alexpilotti has quit IRC | 08:32 | |
*** ChanServ changes topic to "Wiki is broken with database problems, we are working to resolve it" | 08:32 | |
*** zhurong has joined #openstack-nova | 08:35 | |
*** gjayavelu has quit IRC | 08:36 | |
*** lpetrut has joined #openstack-nova | 08:39 | |
-openstackstatus- NOTICE: Wiki problems have been fixed, it's up and running | 08:40 | |
*** ChanServ changes topic to "This channel is for Nova development. For support of Nova deployments, please use #openstack. Please see: https://wiki.openstack.org/wiki/Nova/Ocata_Release_Schedule" | 08:40 | |
*** amoralej|off is now known as amoralej | 08:41 | |
*** jpena|off is now known as jpena | 08:44 | |
venki | @bauzas : ok. but i can able to stack, when i use ironic_deploy_driver=pxe_ssh .... | 08:47 |
venki | @bauzas : getting issue when i use driver as agent_ipmitool or pxe_ipmitool | 08:47 |
bauzas | venki: looks like an ironic issue to me | 08:48 |
bauzas | lemme explain why | 08:48 |
bauzas | ironic creates three fake ironc nodes using the driver you select | 08:48 |
bauzas | then, n-cpu runs the RT that calls the ironic driver for knowing how many ironic nodes are present | 08:49 |
bauzas | oops RT = Nova ResourceTracker | 08:49 |
bauzas | then, Nova creates one hypervisor per ironic node found | 08:49 |
bauzas | last step, Ironic waits for nova to discover those nodes it created | 08:50 |
bauzas | once nova creates the according 3 hypervisors with the same UUID that match the ironic node UUID (behind a single n-cpu service), then ironic continues its deployment | 08:50 |
bauzas | but | 08:50 |
bauzas | if Ironic can't create those 3 nodes using a specific driver, then Nova doesn't find those nodes, hence the error you see | 08:51 |
bauzas | when you say the stack is created if using another ironic driver, that makes me think the real problem is that you don't end up having 3 ironic nodes, that's it | 08:52 |
venki | @bauzas : awww okey .... nice explanation :):):) | 08:53 |
*** markvoelker has joined #openstack-nova | 08:55 | |
*** jpena is now known as jpena|off | 08:57 | |
*** markvoelker has quit IRC | 09:00 | |
*** openstackgerrit has quit IRC | 09:03 | |
johnthetubaguy | gmann: I wasn't understanding your comments on the policy stuff totally, are you still around? | 09:03 |
*** jpena|off is now known as jpena | 09:04 | |
*** mvk has quit IRC | 09:17 | |
*** VAhl has quit IRC | 09:24 | |
lyarwood | johnthetubaguy: morning, https://review.openstack.org/#/c/439520/ could use a review if you have any time today. | 09:35 |
lyarwood | johnthetubaguy: it's now first up in the series given the -1 from mdbooth on landing the db changes before we know if we need the get_by_attachment_id lookups | 09:35 |
*** ociuhandu has joined #openstack-nova | 09:35 | |
johnthetubaguy | lyarwood ah, yeah, I need to hit that again, will try get to that today | 09:35 |
lyarwood | johnthetubaguy: cheers | 09:36 |
*** derekh has joined #openstack-nova | 09:36 | |
*** karimb has joined #openstack-nova | 09:37 | |
*** openstackgerrit has joined #openstack-nova | 09:42 | |
openstackgerrit | John Garbutt proposed openstack/nova master: Refactor: remove _items() in nova/api/openstack/compute/attach_interfaces.py https://review.openstack.org/447698 | 09:42 |
tojuvone | johnthetubaguy, bauzas , jaypipes, oomichi, gibi Would like to get this forward if you have time: https://review.openstack.org/310510 | 09:46 |
bauzas | tojuvone: either way, I need to make another pass on specs soon | 09:47 |
bauzas | tojuvone: but will do :) | 09:47 |
tojuvone | bauzas, thanks :) | 09:47 |
openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Proposed block accepting AZ renames https://review.openstack.org/446446 | 09:49 |
bauzas | johnthetubaguy: you could be interested in ^ | 09:49 |
bauzas | I still need to write a backlog spec for commenting out all the AZ issues | 09:50 |
* johnthetubaguy shakes head at the number of specs to review | 09:50 | |
*** esberglu has joined #openstack-nova | 09:51 | |
bauzas | heh :) | 09:51 |
bauzas | johnthetubaguy: you also have what? 8 open specs ? :p | 09:52 |
johnthetubaguy | yeah, mostly not being written by me right know though | 09:52 |
gibi | tojuvone: It is on my queue to look at it again | 09:52 |
tojuvone | gibi, thanks, tried to update with things we discussed | 09:53 |
*** esberglu has quit IRC | 09:56 | |
*** markvoelker has joined #openstack-nova | 09:56 | |
openstackgerrit | John Garbutt proposed openstack/nova master: Add description to policies in agents.py https://review.openstack.org/445208 | 09:56 |
*** udesale has quit IRC | 09:57 | |
*** mvk has joined #openstack-nova | 09:58 | |
*** tovin07_ has quit IRC | 09:58 | |
openstackgerrit | John Garbutt proposed openstack/nova master: Add descripiton to policies in virtual_interfaces.py https://review.openstack.org/445652 | 09:59 |
*** gszasz has joined #openstack-nova | 10:00 | |
*** markvoelker has quit IRC | 10:00 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Proposed block accepting AZ renames https://review.openstack.org/446446 | 10:00 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Add 'profiler' target https://review.openstack.org/437055 | 10:03 |
openstackgerrit | Claudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages https://review.openstack.org/447505 | 10:05 |
*** zhurong has quit IRC | 10:05 | |
*** jahsis has joined #openstack-nova | 10:08 | |
*** nicolasbock has joined #openstack-nova | 10:08 | |
*** namnh_ has quit IRC | 10:09 | |
openstackgerrit | sahid proposed openstack/nova master: libvirt: return a CPU overhead if isolate emulator threads requested https://review.openstack.org/385364 | 10:11 |
openstackgerrit | sahid proposed openstack/nova master: numa: fit instance NUMA node with cpus reserved onto host NUMA node https://review.openstack.org/400875 | 10:11 |
openstackgerrit | sahid proposed openstack/nova master: virt: update overhead to take into account vCPUs https://review.openstack.org/385024 | 10:11 |
openstackgerrit | sahid proposed openstack/nova master: libvirt: make emulator threads to run on the reserved pCPU https://review.openstack.org/400878 | 10:11 |
openstackgerrit | sahid proposed openstack/nova master: numa: take into account cpus reserved https://review.openstack.org/400876 | 10:11 |
openstackgerrit | sahid proposed openstack/nova master: numa: update numa usage incording the cpu reserved https://review.openstack.org/400877 | 10:11 |
sfinucan | johnthetubaguy: Couldn't we just add the docstrings to https://review.openstack.org/#/c/434842/ and keep everyone happy? | 10:13 |
sfinucan | I'm assuming the oslo.policy change/release will take a while to make it into nova | 10:14 |
johnthetubaguy | sfinucan: its a method thats about to be deleted, its already released yesterday | 10:14 |
sfinucan | Oh, it's been released already? | 10:14 |
sfinucan | In that case | 10:14 |
johnthetubaguy | yeah | 10:14 |
*** jaosorior is now known as jaosorior_brb | 10:14 | |
johnthetubaguy | just need the requirements bumps to flow through, then rework stuff to use the new method | 10:15 |
sfinucan | Gotcha. Does seem more sane to rework after the requirements bump, in that case? | 10:16 |
* sfinucan goes to find said requirements bump, if any | 10:16 | |
*** amotoki has quit IRC | 10:17 | |
johnthetubaguy | sfinucan: so that whole method will be deleted after the bump goes through | 10:21 |
*** udesale has joined #openstack-nova | 10:21 | |
johnthetubaguy | sfinucan: I don't think the bump has been put up for review yet | 10:21 |
sfinucan | johnthetubaguy: Right, but all the calls to that function will have to be rewritten? | 10:22 |
sfinucan | So could we replace that change with a requirement.txt bump change? | 10:22 |
sfinucan | ...and turn a two step process to one | 10:22 |
johnthetubaguy | sfinucan: yes, they will all have to get re-writen | 10:22 |
sfinucan | johnthetubaguy: Right. Any reason not to do that now? | 10:24 |
*** satyar has quit IRC | 10:24 | |
*** zhurong has joined #openstack-nova | 10:24 | |
sfinucan | Just making sure we're not creating work for ourselves :) | 10:24 |
johnthetubaguy | sfinucan: it delays getting the harder reviews out of our queue | 10:24 |
johnthetubaguy | the rename is a single simple patch really, once the requirements stuff is all lined up | 10:24 |
*** gcb has quit IRC | 10:26 | |
*** venki has quit IRC | 10:28 | |
*** gcb has joined #openstack-nova | 10:28 | |
*** venki has joined #openstack-nova | 10:28 | |
*** jamielennox|away is now known as jamielennox | 10:30 | |
*** phuongnh has quit IRC | 10:31 | |
*** yamahata has quit IRC | 10:32 | |
*** jichen has quit IRC | 10:35 | |
sfinucan | johnthetubaguy: OK, the method signatures are the same meaning the rename can be done en masse, as you say. +2/+W'd | 10:35 |
*** kevinz has quit IRC | 10:36 | |
*** gcb has quit IRC | 10:37 | |
*** kaisers1 has quit IRC | 10:38 | |
johnthetubaguy | sfinucan: cool, thanks | 10:38 |
johnthetubaguy | sfinucan: operators been asking for better docs on this stuff for a few years now, glad to be making progress on it | 10:38 |
sfinucan | johnthetubaguy: Yup, similar idea behind centralize-config-options | 10:38 |
sfinucan | One question though - why aren't the 'discoverable' policies documented? https://review.openstack.org/#/c/447722/1/nova/policies/suspend_server.py | 10:39 |
johnthetubaguy | sfinucan: we are about to delete them all | 10:39 |
sfinucan | Oh, that part of this spec or some other initiative? | 10:40 |
sfinucan | *is that | 10:40 |
johnthetubaguy | its the follow on spec | 10:40 |
johnthetubaguy | now all extensions are hard coded on by default, having policy to hide a few from the list seems pointless really | 10:40 |
sfinucan | makes sense | 10:42 |
*** mnestratov has quit IRC | 10:42 | |
*** mnestratov has joined #openstack-nova | 10:43 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Add description to policies in suspend_server.py https://review.openstack.org/447722 | 10:44 |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP/DNM: Destroy the ReqSpec object when deleting the instance https://review.openstack.org/391060 | 10:44 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Add description to policies in volumes.py https://review.openstack.org/445637 | 10:46 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Add description to policies in volumes_attachments.py https://review.openstack.org/445252 | 10:50 |
*** moshele has quit IRC | 10:51 | |
*** moshele has joined #openstack-nova | 10:52 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Read NIC features in libvirt https://review.openstack.org/444415 | 10:52 |
*** kaisers has joined #openstack-nova | 10:53 | |
*** udesale has quit IRC | 10:54 | |
*** gcb has joined #openstack-nova | 10:55 | |
*** faizy has joined #openstack-nova | 10:56 | |
*** gcb has quit IRC | 10:57 | |
*** gcb has joined #openstack-nova | 10:57 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Add description to policies in attach_interfaces.py https://review.openstack.org/447696 | 10:58 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Detach volumes on _rebuild_default_impl failure https://review.openstack.org/442105 | 10:59 |
*** faizy has quit IRC | 10:59 | |
*** faizy has joined #openstack-nova | 11:00 | |
cdent | alex_xu: can you do the same curl that you left in your comment, but with a -v so we can see the request headers too? | 11:00 |
cdent | alex_xu: I'm pretty sure your request is somehow getting a content-type header | 11:02 |
*** udesale has joined #openstack-nova | 11:02 | |
alex_xu | cdent: thanks, curl send a "Content-Type: application/x-www-form-urlencoded" | 11:04 |
alex_xu | I got that with -v | 11:04 |
*** jamielennox is now known as jamielennox|away | 11:05 | |
cdent | alex_xu: strange, I would expect the result to be a 415 then | 11:05 |
*** iceyao has joined #openstack-nova | 11:06 | |
*** gcb has quit IRC | 11:06 | |
alex_xu | cdent: yea, I got a 415 | 11:06 |
cdent | oh, so which code did you remove that allowed the 200? | 11:07 |
*** venki has quit IRC | 11:08 | |
*** venki has joined #openstack-nova | 11:08 | |
*** smatzek has joined #openstack-nova | 11:09 | |
alex_xu | cdent: sorry, I didn't get your quesion | 11:09 |
*** sdague__ is now known as sdague | 11:09 | |
alex_xu | I removed the check at here also https://review.openstack.org/#/c/447625/2/nova/api/openstack/placement/handler.py | 11:09 |
*** READ10 has quit IRC | 11:09 | |
sdague | alex_xu / johnthetubaguy / sfinucan anyone want to hit this easy one - https://review.openstack.org/#/c/447466/ - the docs change is on top | 11:09 |
sfinucan | sdague: Sure | 11:10 |
alex_xu | sdague: checking | 11:10 |
*** iceyao has quit IRC | 11:10 | |
cdent | alex_xu: the reason, in that case, that you didn't get 500 error that the original bug fixed is because when you use -d with curl, it automatically sends a content-type header and the error that was being protected against was when there was no content-type header. do you think there's something wrong with the new patch? | 11:11 |
sfinucan | sdague: Two small indentation things. Otherwise TrivialFix | 11:11 |
*** jamielennox|away is now known as jamielennox | 11:12 | |
*** mvk has quit IRC | 11:12 | |
openstackgerrit | Sean Dague proposed openstack/nova master: remove log translation from nova.api.metadata https://review.openstack.org/447466 | 11:16 |
openstackgerrit | Sean Dague proposed openstack/nova master: update i18n guide for nova https://review.openstack.org/447528 | 11:16 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Add description to policies in agents.py https://review.openstack.org/445208 | 11:16 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Add description to policies in aggregates.py https://review.openstack.org/445230 | 11:17 |
openstackgerrit | Andrey Volkov proposed openstack/nova master: PoC: Pick PCI devices with unique tags https://review.openstack.org/448008 | 11:17 |
*** manasm has joined #openstack-nova | 11:17 | |
*** udesale has quit IRC | 11:18 | |
*** udesale has joined #openstack-nova | 11:18 | |
alex_xu | sfinucan: nothing i found from me, you can +w directly as you mention it is trivialfix | 11:19 |
*** gcb has joined #openstack-nova | 11:20 | |
sfinucan | alex_xu, sdague: Sure. Done. | 11:20 |
alex_xu | cdent: i didn't finish the review yet, just want to figure why those code are there first | 11:20 |
Dinesh_Bhor | sfinucan: Hi, I just rebased the patch: https://review.openstack.org/#/c/445782/ could you please take a look at it? | 11:20 |
* alex_xu has to move the car first, the car is still in temporary parking area, back soon | 11:22 | |
*** faizy_ has joined #openstack-nova | 11:24 | |
*** mvk has joined #openstack-nova | 11:25 | |
*** faizy has quit IRC | 11:25 | |
*** fengzhr has quit IRC | 11:26 | |
EmilienM | dansmith, jaypipes: good morning! here are the new logs with more debug: http://logs.openstack.org/22/447522/1/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/7563947/logs/undercloud/var/log/ (using https://review.openstack.org/#/c/447520/) | 11:26 |
*** moshele has quit IRC | 11:26 | |
*** moshele has joined #openstack-nova | 11:29 | |
*** moshele has quit IRC | 11:30 | |
*** moshele has joined #openstack-nova | 11:31 | |
*** moshele has quit IRC | 11:31 | |
*** moshele has joined #openstack-nova | 11:32 | |
*** fengzhr has joined #openstack-nova | 11:32 | |
*** gongysh has quit IRC | 11:33 | |
*** amotoki has joined #openstack-nova | 11:36 | |
*** hshiina has joined #openstack-nova | 11:37 | |
openstackgerrit | Sean Dague proposed openstack/nova master: delete more i18n log markers https://review.openstack.org/448019 | 11:42 |
*** rmart04 has joined #openstack-nova | 11:45 | |
openstackgerrit | Shunli Zhou proposed openstack/nova master: Remove mox from unit/cells/test_cells_messaging.py https://review.openstack.org/448021 | 11:45 |
*** venki has quit IRC | 11:48 | |
*** wangqun has quit IRC | 11:48 | |
*** venki has joined #openstack-nova | 11:48 | |
*** faizy_ has quit IRC | 11:48 | |
*** rfolco has joined #openstack-nova | 11:49 | |
*** lucasagomes is now known as lucas-brb | 11:50 | |
*** manasm has quit IRC | 11:53 | |
*** aysyd has joined #openstack-nova | 11:57 | |
*** edmondsw has joined #openstack-nova | 12:00 | |
*** tuanluong has quit IRC | 12:03 | |
*** edmondsw has quit IRC | 12:05 | |
*** liverpooler has quit IRC | 12:05 | |
*** liverpooler has joined #openstack-nova | 12:05 | |
*** iceyao has joined #openstack-nova | 12:06 | |
*** bkopilov has quit IRC | 12:07 | |
openstackgerrit | Radoslav Gerganov proposed openstack/nova master: VMware: add support for different firmwares https://review.openstack.org/448034 | 12:10 |
*** awaugama has quit IRC | 12:13 | |
*** haplo37 has quit IRC | 12:15 | |
alex_xu | cdent: just done the review, more comments on https://review.openstack.org/#/c/447625/ | 12:19 |
cdent | thanks alex_xu will look in a second | 12:20 |
alex_xu | cdent: thanks | 12:20 |
*** gcb has quit IRC | 12:20 | |
*** gcb has joined #openstack-nova | 12:21 | |
*** iceyao has quit IRC | 12:21 | |
*** iceyao has joined #openstack-nova | 12:22 | |
*** haplo37 has joined #openstack-nova | 12:24 | |
*** iceyao has quit IRC | 12:25 | |
*** edmondsw has joined #openstack-nova | 12:26 | |
*** Guest29284 has quit IRC | 12:27 | |
*** iceyao has joined #openstack-nova | 12:27 | |
*** sree has joined #openstack-nova | 12:28 | |
*** leseb_ has quit IRC | 12:28 | |
*** venki has quit IRC | 12:28 | |
jaypipes | EmilienM: in meeting hell for 2.5 hours. will try to look into that ASAP. | 12:28 |
*** venki has joined #openstack-nova | 12:28 | |
*** sree_ has joined #openstack-nova | 12:30 | |
*** sree_ is now known as Guest76978 | 12:30 | |
*** Guest76978 has quit IRC | 12:31 | |
*** leseb_ has joined #openstack-nova | 12:31 | |
*** sree has quit IRC | 12:32 | |
*** sree has joined #openstack-nova | 12:32 | |
*** dave-mccowan has joined #openstack-nova | 12:37 | |
*** sree has quit IRC | 12:37 | |
*** manasm has joined #openstack-nova | 12:37 | |
*** kylek3h has joined #openstack-nova | 12:37 | |
*** alexpilotti has joined #openstack-nova | 12:37 | |
*** jaosorior_brb is now known as jaosorior | 12:38 | |
*** moshele has quit IRC | 12:38 | |
*** zhurong has quit IRC | 12:39 | |
*** moshele has joined #openstack-nova | 12:41 | |
*** ayogi has quit IRC | 12:45 | |
*** karimb has quit IRC | 12:46 | |
*** markvoelker has joined #openstack-nova | 12:48 | |
*** dave-mccowan has quit IRC | 12:49 | |
jroll | VCPU 'min_unit': 4 | 12:50 |
jroll | and the flavor does not have 4 | 12:50 |
jroll | that would exclude that RP, right? | 12:51 |
*** ratailor has quit IRC | 12:51 | |
*** efried has joined #openstack-nova | 12:52 | |
cdent | jroll: if flavor wants 2, it would not land on the rp with min_unit of 4 | 12:52 |
jroll | nod | 12:52 |
jroll | joy! | 12:52 |
jroll | so it seems we want to give baremetal resources a lower min_unit, but still create allocations for all of the resources on that baremetal machine | 12:53 |
jroll | (to get the old behavior) | 12:53 |
*** READ10 has joined #openstack-nova | 12:54 | |
* jroll can try to whip up a patch, assuming someone agrees | 12:54 | |
cdent | jroll: I thought you didn't want that kind of under subscription, but I guess that's not the case? | 12:56 |
*** mriedem has joined #openstack-nova | 12:56 | |
*** kencjohnston_ has quit IRC | 12:56 | |
jroll | cdent: we've always left the user a choice, with the "exact" scheduler filters | 12:57 |
*** dave-mccowan has joined #openstack-nova | 12:57 | |
jroll | I believe flavors should match exactly, others (tripleo, yahoo, ?) don't want that | 12:57 |
jroll | so I think the answer for now is undersubscribe, use the exact match filters as before if one wants the exact match, and then the resource class stuff will eliminate the discussion | 12:58 |
*** esberglu has joined #openstack-nova | 12:58 | |
cdent | ok, then yeah, the current min_unit setting in jay's new code isn't going to allow that | 12:59 |
jroll | making a note in the bug report, will write a patch shortly after | 13:01 |
*** gongysh has joined #openstack-nova | 13:02 | |
*** gouthamr has joined #openstack-nova | 13:02 | |
*** cleong has joined #openstack-nova | 13:04 | |
*** eharney has joined #openstack-nova | 13:05 | |
*** iceyao has quit IRC | 13:05 | |
*** baoli has joined #openstack-nova | 13:06 | |
*** baoli has quit IRC | 13:06 | |
* jroll bbiab | 13:06 | |
*** zsli_ has quit IRC | 13:06 | |
openstackgerrit | Sean Dague proposed openstack/nova master: remove i18n log markers from nova.api.* https://review.openstack.org/448082 | 13:07 |
*** gongysh has quit IRC | 13:07 | |
cdent | edleafe is an awkward test | 13:07 |
cdent | wave something near him, and awkwardness is measured | 13:07 |
*** bela_vancsics has joined #openstack-nova | 13:08 | |
edleafe | cdent: I'm not a test! | 13:08 |
*** baoli has joined #openstack-nova | 13:08 | |
cdent | how do you know? | 13:08 |
*** baoli has quit IRC | 13:09 | |
cdent | maybe you are but no one told you | 13:09 |
*** vks1 has joined #openstack-nova | 13:09 | |
*** baoli has joined #openstack-nova | 13:09 | |
edleafe | Sorry, that sounds too much like those late night "wow, man!" conversations from college | 13:09 |
cdent | dood | 13:10 |
*** voelzmo has quit IRC | 13:10 | |
cdent | maybe _everyone_ is a test (for different things) | 13:10 |
*** mdrabe has joined #openstack-nova | 13:11 | |
edleafe | and... and... maybe we're all tests in some giant alien CI... heavy | 13:11 |
cdent | wave something near jaypipes get back a report on which normal form you got going on | 13:11 |
*** iceyao has joined #openstack-nova | 13:11 | |
EmilienM | mriedem: fyi, I posted a link before you connected: http://logs.openstack.org/22/447522/1/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/7563947/logs/undercloud/var/log/ | 13:12 |
EmilienM | mriedem: new logs with the debug patch | 13:12 |
EmilienM | mriedem: (and good morning :-)) | 13:12 |
jaypipes | cdent: third. | 13:12 |
*** tblakes has joined #openstack-nova | 13:12 | |
*** gongysh has joined #openstack-nova | 13:12 | |
*** fengzhr has quit IRC | 13:14 | |
*** lucas-brb is now known as lucasagomes | 13:14 | |
jroll | mriedem: EmilienM: see my comment here: https://bugs.launchpad.net/nova/+bug/1674236 | 13:15 |
openstack | Launchpad bug 1674236 in tripleo "CI / promotion: Nova isn't aware of the nodes that were registered with Ironic" [Critical,Triaged] | 13:15 |
*** gongysh has quit IRC | 13:15 | |
*** fengzhr has joined #openstack-nova | 13:15 | |
EmilienM | jroll: thanks, well explained | 13:17 |
*** amoralej is now known as amoralej|lunch | 13:20 | |
edleafe | jaypipes: I was going to say 'ab' | 13:20 |
* cdent gives edleafe a cookie | 13:21 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Refactor: remove _items() in nova/api/openstack/compute/attach_interfaces.py https://review.openstack.org/447698 | 13:22 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Add description to policies in agents.py https://review.openstack.org/445208 | 13:22 |
sfinucan | sdague: Could you take a look at https://review.openstack.org/#/c/430909/ and successors when possible, please? | 13:24 |
*** karimb has joined #openstack-nova | 13:24 | |
*** links has quit IRC | 13:24 | |
sdague | sfinucan: why are you making a change like this - https://review.openstack.org/#/c/430717/6/nova/conf/netconf.py ? | 13:24 |
sfinucan | sdague: It makes the addition of deprecated lines easier for me | 13:25 |
*** jamesdenton has joined #openstack-nova | 13:25 | |
sdague | why? | 13:25 |
sfinucan | plus, there's precedent for making everything in '/conf' ultra-consistent | 13:25 |
*** venki has quit IRC | 13:25 | |
sfinucan | I can simply bulk copy-paste | 13:25 |
*** prateek has quit IRC | 13:25 | |
*** venki has joined #openstack-nova | 13:25 | |
*** voelzmo has joined #openstack-nova | 13:26 | |
sfinucan | but the "making everything in /conf ultra-consistent" is big enough. I've enough of those done that the little differences between each start to get annoying, heh | 13:27 |
*** smatzek has quit IRC | 13:27 | |
mriedem | jroll: yeah good catch, _compute_node_to_inventory_dict in the old flow hardcodes min_unit to 1 | 13:27 |
bauzas | EmilienM: mriedem: I'm around to help, could you please tell me the current situation ? | 13:27 |
*** crushil has joined #openstack-nova | 13:27 | |
mriedem | bauzas: jroll is working on the change | 13:27 |
jroll | bauzas: read bug 1674236 | 13:28 |
openstack | bug 1674236 in tripleo "CI / promotion: Nova isn't aware of the nodes that were registered with Ironic" [Critical,Triaged] https://launchpad.net/bugs/1674236 | 13:28 |
sdague | sfinucan: honestly, that's kind of exactly the whitespace over eagerness that we stopped doing a couple of years ago. We made E12* non enforcing for a reason. | 13:28 |
sfinucan | yup, I'd completely agree...outside of '/conf' | 13:29 |
sdague | no, anyway, we don't want different rules in different places | 13:29 |
sfinucan | I want to enforce the "consistency is key" mindset in there, in the hopes that it will deliver consistency in the end result | 13:29 |
sfinucan | which, for the most part, it has been doing | 13:29 |
sdague | well, I disagree that over prescribed code indentation really impacts useful end user docs :) | 13:30 |
*** voelzmo has quit IRC | 13:30 | |
sfinucan | but it does describe people's mindsets going in there | 13:31 |
*** faizy_ has joined #openstack-nova | 13:31 | |
*** jpena is now known as jpena|lunch | 13:31 | |
sfinucan | Also, I've done enough of work with that aspect of nova to surely justify the benefit of the doubt | 13:32 |
*** mnestratov|2 has joined #openstack-nova | 13:32 | |
bauzas | jroll: mriedem: okay, gaining context :) | 13:33 |
sdague | I fought really hard against the whitespace wars in the past of people being overly prescriptive, I'm not really interested in bringing that mindset back for any reason | 13:33 |
*** faizy__ has joined #openstack-nova | 13:33 | |
*** liangy has joined #openstack-nova | 13:35 | |
openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Ironic: hardcode min_unit for standard resources to 1 https://review.openstack.org/448098 | 13:35 |
*** mnestratov has quit IRC | 13:36 | |
jroll | EmilienM: cdent: bauzas: this should definitely fix the bug, trying to figure out now if I need to change allocations code as well so we don't schedule two (undersubscribed) instances to one node | 13:36 |
*** mdrabe has quit IRC | 13:36 | |
EmilienM | jroll: would you recommend us to change something in tripleo also? | 13:36 |
*** faizy_ has quit IRC | 13:36 | |
*** mdrabe has joined #openstack-nova | 13:37 | |
jroll | EmilienM: well, I believe flavors should always exactly match nodes, but tripleo not doing that is a "feature", so I'd leave it alone | 13:37 |
EmilienM | ok | 13:37 |
EmilienM | jroll: thank you! | 13:37 |
jroll | np :) | 13:37 |
EmilienM | jroll: I'm going to try this one | 13:37 |
jroll | EmilienM: thanks | 13:38 |
*** adrian_otto has joined #openstack-nova | 13:40 | |
EmilienM | jroll: https://review.openstack.org/#/c/447522/ - I'll let you know how it foes | 13:40 |
EmilienM | goes* | 13:40 |
jroll | thanks | 13:41 |
*** Szarka has joined #openstack-nova | 13:41 | |
bauzas | EmilienM: jroll: okay, beginning to review https://review.openstack.org/#/c/448098/ FWIW | 13:41 |
EmilienM | bauzas: thx | 13:43 |
bauzas | jroll: oh, excellent catch on https://review.openstack.org/#/c/448098/1/nova/virt/ironic/driver.py | 13:44 |
jroll | bauzas: yeah, was fun | 13:44 |
bauzas | I think it's a situation where the scheduler is still needed until we implement all the features per the placement engine | 13:44 |
jroll | we are going to have to change how we do allocations here though :( | 13:44 |
bauzas | jroll: why so ? you're telling placement to accept returning RPs that have more resources | 13:45 |
bauzas | jroll: ah I see | 13:45 |
jroll | :P | 13:45 |
bauzas | jroll: so you would create an allocation that would eat all the left resources ? | 13:45 |
jroll | yeah, we don't want to leave free resources there | 13:45 |
bauzas | yeah, I honestly thought it was already the case | 13:45 |
jroll | bauzas: maybe. or hack instance.flavor to eat everything | 13:46 |
bauzas | an ironic allocation is free-or-none | 13:46 |
cdent | so does this mean we need yet more special casing? | 13:46 |
mriedem | jroll: did you run functional tests? | 13:46 |
bauzas | jroll: well, operators defined flavors that weren't really meaning this or that number of resource usage | 13:46 |
mriedem | jroll: i think there is a functional RT test that will fail | 13:46 |
jroll | bauzas: right, we have code that does this in our virt driver, but the RT decides we're wrong | 13:46 |
jroll | mriedem: there probably is, I haven't looked at them | 13:47 |
jroll | nor ran | 13:47 |
bauzas | jroll: we could tho tell them to add an extra spec that would signal 'eat me all the cake' | 13:47 |
bauzas | I mean a trait | 13:47 |
mriedem | that's not a trait | 13:47 |
bauzas | a what then ? | 13:47 |
mriedem | that's like a config option | 13:47 |
jroll | 'indivisible' is a trait :P | 13:47 |
jroll | cdent: yes, somewhere. unclear (to me) where | 13:48 |
mriedem | i guess i need to read the traits spec on the definition | 13:48 |
bauzas | VCPU=5&MEM_GB=1&eat_me_all_thecake ? | 13:48 |
jroll | mriedem: I'm mostly joking :) | 13:48 |
*** diana_clarke has joined #openstack-nova | 13:48 | |
bauzas | jroll: that said I'm concerned we could merge https://review.openstack.org/#/c/448098/1/nova/virt/ironic/driver.py without modifying allocations that would allow to pick the same ironic node for two instances | 13:49 |
*** hoangcx has joined #openstack-nova | 13:49 | |
jroll | bauzas: I mean, I can WIP it, I just put it up for now so EmilienM could test and such | 13:49 |
bauzas | jroll: I do wonder if fixing ironic allocations shouldn't be merged first | 13:49 |
bauzas | jroll: well, it's a race | 13:50 |
bauzas | jroll: so the CI could be happy tho | 13:50 |
jroll | bauzas: let me be clear, I don't want this merged without fixing allocations as well | 13:50 |
bauzas | a-ah ok, then I agree | 13:50 |
*** artom has quit IRC | 13:50 | |
jroll | bauzas: and if tripleo can boot at least one instance, it's progress | 13:50 |
jroll | or rather proves that was the issue | 13:50 |
bauzas | jroll: AFAIK, the Exact* filters are not default in config right? | 13:51 |
*** felipemonteiro has joined #openstack-nova | 13:51 | |
bauzas | jroll: speaking of the IronicHostManager config | 13:51 |
bauzas | I can verify | 13:51 |
bauzas | but I'm pretty sure TripleO hasn't modified that | 13:51 |
*** faizy__ has quit IRC | 13:51 | |
jroll | bauzas: it is a default, I think, if CONF.filter_scheduler.use_baremetal_filters=true | 13:52 |
bauzas | jroll: I know we don't have the same enabled filters if that conf opt is in use, yep | 13:52 |
bauzas | jroll: I just don't remember if the Exact* filters are part of those | 13:52 |
jroll | yeah, confirmed, it isn't default but is part of the baremetal set | 13:52 |
jroll | conf/scheduler.py line 298 | 13:53 |
*** amoralej|lunch is now known as amoralej | 13:53 | |
bauzas | jroll: so then the scheduler should get the exact same number of nodes with or without that fix you wrote | 13:54 |
*** eglynn has joined #openstack-nova | 13:54 | |
bauzas | oops | 13:54 |
bauzas | the scheduler should *return* | 13:54 |
bauzas | but lemme see the 3O config | 13:55 |
jroll | bauzas: http://logs.openstack.org/22/447522/1/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/7563947/logs/etc/nova/nova.conf.txt.gz | 13:55 |
bauzas | yup | 13:55 |
jroll | use_baremetal_filters=False | 13:55 |
bauzas | EmilienM: is the above the undercloud nova.conf ? | 13:55 |
mriedem | bauzas: jroll's fix isn't any different from how it worked before get_inventory was added | 13:55 |
mriedem | unless i'm missing something | 13:55 |
mriedem | so if you're worried about an allocation bug, it's latent | 13:56 |
bauzas | mriedem: jroll's fix tries to address the fact that operators could ask the scheduler to return hosts that have more space than asked | 13:56 |
jroll | mriedem: hm, you might be right | 13:56 |
EmilienM | bauzas: yes | 13:56 |
bauzas | okay, so the problem is there | 13:57 |
bauzas | lemme restate | 13:57 |
*** catintheroof has joined #openstack-nova | 13:57 | |
mriedem | jaypipes: in case you haven't seen yet, jroll found the cause of the bug with the get_inventory stuff | 13:57 |
bauzas | Ironic pre-jroll's fix is only accepting the default config (ie. having Exact* filters) | 13:57 |
jaypipes | mriedem: sorry, meeting hell... | 13:57 |
jaypipes | mriedem: what was the cause, jroll? | 13:58 |
*** adrian_otto has quit IRC | 13:58 | |
mriedem | min_unit was equal to max_unit | 13:58 |
bauzas | but TripleO isn't using those specific filtrers | 13:58 |
mriedem | plus bm filters | 13:58 |
jroll | jaypipes: min_unit==max_unit, tripleo uses flavors smaller than the node | 13:58 |
EmilienM | scheduler_use_baremetal_filters is set to False by default in puppet-nova, I believe it's the default in Nova, but let me check | 13:58 |
jroll | mriedem: not related to baremetal filters | 13:58 |
jroll | EmilienM: that's correct | 13:58 |
jaypipes | jroll: ahhh. | 13:58 |
jaypipes | jroll: good. we can blame edleafe then. :P | 13:59 |
bauzas | so it hits the bug that jroll tries to fix, but which shouldn't be visible unless you modify the specific default values for the list of baremetal filters | 13:59 |
EmilienM | right https://git.openstack.org/cgit/openstack/nova/tree/nova/conf/scheduler.py#n333 | 13:59 |
*** smatzek has joined #openstack-nova | 13:59 | |
*** ZZelle_ has quit IRC | 13:59 | |
EmilienM | (i'm unavailable the next hour, tripleo meeting) | 13:59 |
*** bkopilov has joined #openstack-nova | 13:59 | |
*** mtanino has joined #openstack-nova | 13:59 | |
tdurakov | hi folks, live-migration meeting in a minute, on #openstack-meeting-3 | 13:59 |
*** ZZelle has joined #openstack-nova | 13:59 | |
bauzas | so, I would suggest at least for TripleO to set scheduler_use_baremetal_filters to True for the undercloud | 14:00 |
jroll | bauzas: or don't enable baremetal filters at all | 14:00 |
*** ZZelle is now known as Guest93672 | 14:00 | |
jroll | bauzas: well, AIUI, tripleo does this intentionally | 14:00 |
mriedem | i didn't even know baremetal_scheduler_enabled_filters was a thing | 14:00 |
jroll | bauzas: tripleo uses capabilities hacks to schedule whatever the hell it wants | 14:00 |
mriedem | or scheduler_use_baremetal_filters | 14:00 |
bauzas | jroll: well, if you don't enable those exact* filters, then you could end up picking a host that has free space | 14:01 |
jroll | mriedem: yeah, it's a shortcut to make deployers lives easier, I know that's usually not a goal | 14:01 |
*** Guest93672 is now known as ZZelle__ | 14:01 | |
jroll | bauzas: which is true before this change, as well | 14:01 |
jroll | bauzas: before the get_inventory change, I mean | 14:01 |
bauzas | jroll: having the placement returning those hosts wasn't a problem because the scheduler was only returning the right hosts if Exact* filters were present | 14:01 |
mriedem | jroll: just seems odd we need config options to say do this for bm scheduling, when we already know if we're doing ironic b/c of the host_manager | 14:02 |
jroll | bauzas: fundamentally I agree with you, but this is a change to tripleo's architecture :P | 14:02 |
bauzas | mriedem: it's a hack | 14:02 |
openstackgerrit | BĆ©la Vancsics proposed openstack/nova master: Using max api version in notificationt sample test https://review.openstack.org/443686 | 14:02 |
edleafe | jaypipes: you can always blame me | 14:02 |
*** moshele has quit IRC | 14:02 | |
bauzas | a very long-lived hack | 14:02 |
bauzas | I guess only a few of us were knowing that :/ | 14:02 |
jroll | mriedem: idk, tripleo and yahoo very much drive a "things don't need to be exact" use case :/ | 14:02 |
*** voelzmo has joined #openstack-nova | 14:02 | |
jroll | I'm told many deployments of ironic manage the compute graveyard where every machine is a different spec | 14:03 |
jroll | :| | 14:03 |
bauzas | jroll: here is the thing, eithezr tripleo switches their conf, or we need to both merge your fix *and* consume all the space when allocating | 14:03 |
bauzas | the former should be quick | 14:03 |
bauzas | the latter could take a while | 14:03 |
jroll | bauzas: slow down | 14:04 |
jroll | bauzas: tripleo was not using exact filters before the get_inventory change | 14:04 |
*** ZZelle__ is now known as ZZelle_ | 14:04 | |
jroll | bauzas: we also had broken allocations before that change | 14:05 |
jroll | bauzas: so with this fix only, we assume they won't be broken (and I believe their flavor uses all of the RAM, which is why) | 14:05 |
jroll | anyone else not using exact filters was already broken, and will continue to be broken | 14:05 |
bauzas | *tripleo* won't be broken | 14:05 |
*** voelzmo has quit IRC | 14:06 | |
bauzas | but people using ironic the normal way will be broken if we merge your fix without the allocation side | 14:06 |
*** awaugama has joined #openstack-nova | 14:06 | |
jroll | yes, the same way they were broken on ocata, newton, mitaka, etc | 14:06 |
*** voelzmo has joined #openstack-nova | 14:06 | |
openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Ironic: hardcode min_unit for standard resources to 1 https://review.openstack.org/448098 | 14:06 |
jroll | ^ with func test fixes | 14:06 |
bauzas | jroll: they were broken in what sense ? | 14:07 |
bauzas | the fact that we were underperformant with scheduling, leading to races ? | 14:07 |
jroll | bauzas: the same way. we weren't allocating all of the resources | 14:07 |
bauzas | wait | 14:07 |
bauzas | we weren't allocating all the resources ? I'm surprised | 14:08 |
jroll | we were not. because people didn't want ironic hacks in there. | 14:08 |
jroll | (AIUI, of course) | 14:08 |
jroll | and when people complained, we said "don't be dumb, use the exact filters" | 14:08 |
bauzas | sec, verifying the RT code and the claims | 14:08 |
jroll | please do, you know that code better than I do | 14:08 |
jroll | ironic reports everything used in get_available_resource, but the RT corrects it based on instance.flavor | 14:09 |
*** manasm has quit IRC | 14:09 | |
bauzas | jroll: self.driver.estimate_instance_overhead(instance) | 14:09 |
bauzas | mmm, nevermind | 14:10 |
bauzas | that one is not what I thought | 14:10 |
*** bela_vancsics has quit IRC | 14:10 | |
bauzas | looking at the limits now | 14:11 |
*** satyar has joined #openstack-nova | 14:12 | |
*** bela_vancsics has joined #openstack-nova | 14:12 | |
bauzas | yeah bingo | 14:13 |
* jroll listens | 14:13 | |
bauzas | jroll: https://github.com/openstack/nova/blob/master/nova/scheduler/filters/exact_ram_filter.py#L38-L41 | 14:13 |
bauzas | jroll: which ends up in https://github.com/openstack/nova/blob/master/nova/compute/claims.py#L247 | 14:15 |
bauzas | on the compute side | 14:15 |
*** sapcc-bot1 has quit IRC | 14:15 | |
jroll | bauzas: neat, but that means people not running exact filters were still broken before this change | 14:15 |
*** tpatzig_ has quit IRC | 14:15 | |
jroll | bauzas: and means people running exact filters are still not broken after this change | 14:15 |
bauzas | jroll: so the filter returns a limit that is passed down to the conductor and then the compute which is used there https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L155-L156 | 14:16 |
jroll | meaning, my change does not introduce more broken behavior, just gets us back to consistent with old behavior | 14:16 |
mriedem | rfolco: congratulations you are the first pike bp implemented https://blueprints.launchpad.net/nova/+spec/delete-inventories-placement-api | 14:16 |
mriedem | you get a root beer flavored scratch and sniff sticker | 14:16 |
bauzas | jroll: lemme consider the impact | 14:16 |
*** mlavalle has joined #openstack-nova | 14:16 | |
mriedem | jroll: that's what i said earlier right? | 14:16 |
mriedem | your patch makes get_inventory the same as it was working for everything before | 14:17 |
mriedem | the "consume all allocation" is a latent problem | 14:17 |
mriedem | not introduced by get_inventory | 14:17 |
bauzas | mriedem: post-placement use yeah | 14:17 |
cdent | mriedem: I am _so_ motivated now, now that I know there might be scratch and sniff stickers | 14:17 |
jroll | mriedem: yes, I agree with you | 14:17 |
bauzas | okay, jroll and mriedem, you're right | 14:18 |
edleafe | rfolco: w00t! | 14:18 |
jroll | zomg, that never happens | 14:18 |
bauzas | we just leave placement returning more hosts | 14:18 |
*** Szarka has quit IRC | 14:18 | |
bauzas | the allocation consumption problem is only there when you don't use the Exact | 14:19 |
bauzas | Exact* filters | 14:19 |
bauzas | okay, so... | 14:19 |
* bauzas reviewing again the bugfix | 14:19 | |
*** zz_dimtruck is now known as dimtruck | 14:20 | |
bauzas | jroll: EmilienM: +2, but holding my +W https://review.openstack.org/#/c/448098/2 | 14:23 |
bauzas | until we get more results, in particular with 3O job | 14:23 |
EmilienM | bauzas: ack, thx | 14:23 |
jroll | thanks bauzas | 14:25 |
bauzas | jroll: nah, you thanks for tackling that | 14:25 |
jroll | bauzas: welcome | 14:25 |
jroll | I promised I'd help with placement stuff, yay I did a thing | 14:26 |
bauzas | at least we discussed how scary was the IronicHostManager :) | 14:26 |
bauzas | now mriedem could just throw it under the bus too :p | 14:26 |
jroll | that's drilled into my head for years now | 14:26 |
bauzas | FWIW, I'm even not convinced by HostState objects | 14:27 |
sdague | sfinucan: on https://review.openstack.org/#/c/430912 ... if we put an idempotent id in the commit message, can we put the full one in there? If it's full gerrit makes it a link, the partial isn't | 14:27 |
bauzas | anyway, /me disappearing b/c paternal duties | 14:27 |
sfinucan | sdague: Weird. Partial commit refs _do_ work. I'll fix that now | 14:28 |
sdague | sfinucan: yeh, but not Idempotent ids | 14:28 |
sdague | I think it's gerrit being conservative | 14:28 |
sfinucan | sdague: It does in https://review.openstack.org/#/c/430911/5 though? | 14:28 |
*** sneti_ has joined #openstack-nova | 14:29 | |
mriedem | rpodolyaka: you've got to sort the projects.yaml file https://review.openstack.org/#/c/448115/1 | 14:29 |
sdague | sfinucan: only 7 in the unlinked one? | 14:29 |
sdague | it's still probably good form to do the whole thing though | 14:29 |
mriedem | rpodolyaka: let me know when we get to the point of needing to setup a launchpad project for bug tracking | 14:30 |
alex_xu | cdent: what is your expect when no content-length and content-type, 400 or 415? | 14:30 |
sfinucan | sdague: Aye, it does work with 8 chars | 14:30 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Ignore 'allow_same_net_traffic' for port filters https://review.openstack.org/430912 | 14:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate 'allow_same_net_traffic' https://review.openstack.org/430913 | 14:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Final cleanups in conf/network https://review.openstack.org/431023 | 14:32 |
sfinucan | sdague: Thanks for reviewing those :) | 14:32 |
cdent | alex_xu: 400 | 14:32 |
cdent | 415 is only for when the value of content-type is not the one desired | 14:32 |
alex_xu | cdent: but the https://review.openstack.org/447625 will return 415 | 14:33 |
rpodolyaka | mriedem: oops, will fix that now | 14:33 |
openstackgerrit | BĆ©la Vancsics proposed openstack/nova master: Transform instance.trigger_crash_dump notification https://review.openstack.org/396225 | 14:33 |
*** eharney has quit IRC | 14:33 | |
rpodolyaka | mriedem: hmm, I already created one - https://bugs.launchpad.net/placement-osc-plugin . Was that too early? | 14:34 |
*** xinliang has quit IRC | 14:34 | |
cdent | alex_xu: sorry I misunderstood what you meant: I thought you mean no content-type and no content-length. For no content-length but with a content-type then 415 (assuming the content-type is wrong) | 14:34 |
alex_xu | cdent: yes, I mean no content-type and no content-length | 14:35 |
cdent | alex_xu: okay, ideally that would be a 400, but I've allowed it to fall through to a 415 because we don't want to do either of the following: | 14:36 |
cdent | * check for the presence of a body (before actually reading it) | 14:36 |
*** vishwanathj has joined #openstack-nova | 14:36 | |
cdent | * limit things based on which method, since GET could send a body | 14:36 |
mriedem | rpodolyaka: less work for me | 14:36 |
rpodolyaka | :) | 14:36 |
*** fengzhr has quit IRC | 14:36 | |
mriedem | mdbooth: on https://review.openstack.org/#/c/441989/ i noticed there was no unit test, which, whatever, but if having a method defined is required to actually have things work, what are your thoughts on using ABCs in the imagebackend code? | 14:37 |
cdent | alex_xu: a thing to keep in mind is that is hard, without explicit intent, to not send a content-length header when you have a body | 14:37 |
mriedem | so if a method is required, like get_model, then define it as an abstractmethod | 14:38 |
cdent | alex_xu: we could change things back to check for the request method, but since we've had discussions about GET using bodies, I didn't want to build that in | 14:38 |
mriedem | i guess Image is an ABC | 14:38 |
*** fengzhr has joined #openstack-nova | 14:39 | |
mriedem | but get_model() isn't marked as an abstractmethod? that seems wrong | 14:39 |
cdent | alex_xu: we can change it like you suggest (all in the decorator) but that doesn't feel as robust to me | 14:39 |
mdbooth | mriedem: I vaguely recall considering that when I looked at it, but we don't use ABCs very consistently so I wasn't that bothered IIRC | 14:39 |
mriedem | mdbooth: i'll push a change quick | 14:39 |
alex_xu | cdent: sorry, I didn't get what relationship with GET using bodies | 14:39 |
mriedem | so when MyCoolImageEnterpriseBackend shows up, we don't have the same issue | 14:40 |
*** alexpilotti has quit IRC | 14:40 | |
jroll | EmilienM: I rechecked your test patch, btw | 14:40 |
EmilienM | thx | 14:40 |
EmilienM | I'm still in mtg | 14:40 |
jroll | no worries, just a heads up :) | 14:41 |
alex_xu | emm...actually, i didn't get why that two points related to my suggestion. I may miss something | 14:41 |
*** jpena|lunch is now known as jpena | 14:42 | |
*** marst has quit IRC | 14:43 | |
*** marst has joined #openstack-nova | 14:43 | |
edleafe | cdent: (reading scrollback) So no content-type with no content is not OK? | 14:43 |
cdent | alex_xu: there's two things going on in the patch: One is making sure that if there is no body (thus the content-length header is either 0 or not there) then a PUT or POST can work. Two is making sure that if there is a body (content-length header is present and has a value) then the content-type header is present, no matter what the request method is. | 14:43 |
cdent | edleafe: ^ | 14:44 |
*** NikhilS has quit IRC | 14:44 | |
*** ociuhandu has quit IRC | 14:44 | |
cdent | Item number two should be true for every request and should lead to a 400 if not the case. Thus having it as part of a decorator is not ideal. | 14:45 |
cdent | (unless it was part of the wsgify decorator, but that's essentially the same thing as where it is now) | 14:46 |
edleafe | cdent: I was reading alex_xu's comment at http://p.anticdent.org/1sVC and your reply | 14:46 |
cdent | edleafe: if there is a body, and there is either no content-type or no content-length, that's a 400 | 14:46 |
*** eharney has joined #openstack-nova | 14:47 | |
cdent | edleafe: but we only have the content-length header as a reasonable proxy for knowing if there is a body | 14:47 |
*** andreas_s has quit IRC | 14:47 | |
openstackgerrit | Sujitha proposed openstack/nova master: Change os-server-tags default policy https://review.openstack.org/396420 | 14:47 |
edleafe | cdent: a body with no content-length? | 14:47 |
* edleafe must be living in an ideal world | 14:47 | |
*** marst has quit IRC | 14:48 | |
cdent | edleafe: a healthy client would never do that, but if, for example, you telnet to port 80 and write a PUT it's easy to do | 14:48 |
cdent | also, if chunked encoding is being used, all bets are off | 14:48 |
cdent | but we don't use that, so that's a relief | 14:48 |
*** david-lyle has joined #openstack-nova | 14:49 | |
*** mdrabe has quit IRC | 14:50 | |
cdent | alex_xu, edleafe: does that help clear things up or just make it more muddy? sadly we can't protect against all cases of "telnet to port 80" but we can cover some. | 14:50 |
*** gszasz_ has joined #openstack-nova | 14:50 | |
*** hongbin has joined #openstack-nova | 14:50 | |
*** ratailor has joined #openstack-nova | 14:51 | |
cdent | on the other hand it is entirely possible I'm putting too much trust in the existing gabbi tests, but since they pass, I feel pretty okay | 14:51 |
alex_xu | I think i get your point now | 14:51 |
*** ratailor has quit IRC | 14:53 | |
*** gszasz has quit IRC | 14:53 | |
*** psachin_ has quit IRC | 14:53 | |
*** marst has joined #openstack-nova | 14:54 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Add description to policies in assisted_volume_snapshots.py https://review.openstack.org/445238 | 14:55 |
*** tblakes has quit IRC | 14:55 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Add description to policies in admin_password.py https://review.openstack.org/443957 | 14:55 |
edleafe | cdent: you mean there are other ways to use OpenStack other than telnet? | 14:55 |
*** belmoreira has joined #openstack-nova | 14:56 | |
rfolco | mriedem, edleafe: re: first pike bp implemented: nice! thanks to edleafe, cdent and jaypipes for great guidance :) | 14:56 |
cdent | edleafe: only if you pass the awkward test | 14:56 |
cdent | \o/ rfolco | 14:56 |
*** faizy has joined #openstack-nova | 14:57 | |
*** armax has quit IRC | 14:57 | |
*** artom has joined #openstack-nova | 14:57 | |
*** bela_vancsics has quit IRC | 14:58 | |
*** mdrabe has joined #openstack-nova | 14:58 | |
alex_xu | if we check the presence the body, that means we have to read the body first | 14:59 |
jaypipes | rfolco: and now you can submit a patch that changes the scheduler/report client to use DELETE /r-p/{uuid}/inventories :) | 14:59 |
alex_xu | that is waste, that is the reason cdent didn't want to check that | 14:59 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: mark some Image backend methods as abstract https://review.openstack.org/448142 | 14:59 |
mriedem | mdbooth: see how that suits you ^ | 14:59 |
*** karimb has quit IRC | 15:00 | |
cdent | alex_xu: yes, besides being a waste, it also limits some of the options for future handling | 15:00 |
alex_xu | cdent: what options? | 15:00 |
mdbooth | mriedem: WFM | 15:00 |
rfolco | jaypipes, noted | 15:00 |
jroll | cdent: edleafe: I'd love to start on this spec today, if you want to give it a quick skim before I do: https://etherpad.openstack.org/p/nova-ironic-flavor-transition-plan | 15:00 |
cdent | handling streams | 15:01 |
cdent | sorry phone | 15:01 |
edleafe | jroll: will get to it in a bit. Meeting Hell Morning and all... | 15:01 |
jroll | dansmith: mriedem: looks like most of the placement crew is happy with this flavor extra specs, spec, when you have a few: https://review.openstack.org/#/c/446570/ | 15:02 |
jroll | edleafe: no rush | 15:02 |
*** dave-mccowan has quit IRC | 15:02 | |
*** hoangcx has quit IRC | 15:04 | |
*** venki has quit IRC | 15:05 | |
*** venki has joined #openstack-nova | 15:06 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop using mox stubs in nova/tests/unit/cells/fakes.py https://review.openstack.org/342043 | 15:07 |
alex_xu | cdent: +2 on the patch, thanks for explain all of that to me patiently | 15:08 |
*** david-lyle has quit IRC | 15:09 | |
*** ociuhandu has joined #openstack-nova | 15:10 | |
*** faizy has quit IRC | 15:10 | |
*** faizy has joined #openstack-nova | 15:11 | |
bauzas | jroll: dansmith: FWIW, just reviewing https://review.openstack.org/#/c/446570/2/specs/pike/approved/custom-resource-classes-in-flavors.rst now | 15:12 |
*** hshiina has quit IRC | 15:12 | |
*** karimb has joined #openstack-nova | 15:12 | |
jroll | bauzas: woohoo | 15:12 |
cdent | alex_xu: thanks for asking so many questions and being so thourough. is great. | 15:13 |
*** claudiub|2 has joined #openstack-nova | 15:13 | |
mriedem | jroll: starred | 15:13 |
*** claudiub has quit IRC | 15:14 | |
*** faizy_ has joined #openstack-nova | 15:14 | |
*** david-lyle has joined #openstack-nova | 15:15 | |
mriedem | sdague: alex_xu: oomichi: i put this on the api subteam meeting agenda, but would be nice to get your feedback, or at least start thinking about this before then https://review.openstack.org/#/c/447149/1/specs/pike/approved/service-hyper-uuid-in-api.rst@148 | 15:16 |
*** raghav has joined #openstack-nova | 15:16 | |
*** baoli has quit IRC | 15:17 | |
mriedem | alex_xu: i know it's late for you so don't worry too much about it today | 15:17 |
*** faizy__ has joined #openstack-nova | 15:17 | |
cdent | jroll: I dunno, after telling you to change that 0 to a 1, I am _completely_ exhausted. | 15:17 |
mriedem | just lose a *little* bit of sleep :) | 15:17 |
*** faizy has quit IRC | 15:18 | |
*** dane-fichter has joined #openstack-nova | 15:18 | |
*** tbachman has quit IRC | 15:19 | |
*** tblakes has joined #openstack-nova | 15:19 | |
alex_xu | mriedem: got it, I will check it tomorrow morning | 15:19 |
*** faizy_ has quit IRC | 15:20 | |
*** faizy__ has quit IRC | 15:21 | |
*** karimb has quit IRC | 15:21 | |
*** faizy__ has joined #openstack-nova | 15:21 | |
*** dave-mccowan has joined #openstack-nova | 15:22 | |
*** sapcc-bot has joined #openstack-nova | 15:22 | |
*** dgonzalez_ has joined #openstack-nova | 15:23 | |
*** databus23_ has joined #openstack-nova | 15:23 | |
*** mkoderer_ has joined #openstack-nova | 15:23 | |
*** carthaca_ has joined #openstack-nova | 15:23 | |
*** faizy__ has quit IRC | 15:24 | |
*** david_1 has joined #openstack-nova | 15:24 | |
dane-fichter | johnthetubaguy: got a second to talk about the trusted flavors spec? | 15:24 |
*** raghav has quit IRC | 15:24 | |
*** faizy__ has joined #openstack-nova | 15:24 | |
*** carthaca_ has quit IRC | 15:24 | |
*** carthaca_ has joined #openstack-nova | 15:25 | |
*** dgonzalez_ has quit IRC | 15:25 | |
*** databus23_ has quit IRC | 15:25 | |
*** carthaca_ has quit IRC | 15:25 | |
*** mkoderer_ has quit IRC | 15:25 | |
*** david_1 has quit IRC | 15:26 | |
*** faizy__ has quit IRC | 15:26 | |
*** faizy__ has joined #openstack-nova | 15:27 | |
*** ekuris has quit IRC | 15:27 | |
*** jdurgin has joined #openstack-nova | 15:28 | |
*** faizy__ has quit IRC | 15:29 | |
*** faizy__ has joined #openstack-nova | 15:30 | |
openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in admin_actions. https://review.openstack.org/440829 | 15:31 |
bauzas | jroll: made a comment on https://review.openstack.org/#/c/446570/2 | 15:31 |
bauzas | jroll: not sure it could be a bug, but I would appreciate some brainstorm | 15:31 |
*** karimb has joined #openstack-nova | 15:32 | |
*** tbachman has joined #openstack-nova | 15:33 | |
*** hieulq_ has joined #openstack-nova | 15:33 | |
openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in admin_actions. https://review.openstack.org/440829 | 15:35 |
*** whenry has joined #openstack-nova | 15:36 | |
*** whenry has quit IRC | 15:37 | |
openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in admin_password.py https://review.openstack.org/443957 | 15:37 |
*** suresh12 has joined #openstack-nova | 15:38 | |
openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in agents.py https://review.openstack.org/445208 | 15:38 |
*** adrian_otto has joined #openstack-nova | 15:39 | |
*** annegentle has joined #openstack-nova | 15:39 | |
openstackgerrit | Sandeep Pawar proposed openstack/nova master: Libvirt volume driver for Veritas HyperScale https://review.openstack.org/443951 | 15:40 |
jroll | bauzas: resize depends on migrate being available, right? | 15:40 |
jroll | (which ironic can't do) | 15:40 |
bauzas | jroll: nova resize ? | 15:40 |
jroll | yes | 15:40 |
bauzas | I dunno, but good point, lemme verify | 15:40 |
openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in aggregates.py https://review.openstack.org/445230 | 15:41 |
jroll | I'm looking, I see lots of migration code in it | 15:41 |
bauzas | jroll: either way, this spec doesn't only target a specific virt driver | 15:41 |
bauzas | so I'm supposing it can be possible | 15:41 |
bauzas | eg. FPGA devices with libvirt | 15:41 |
jroll | bauzas: your resize concerns are around the upgrade thing we do in the ironic driver, though | 15:41 |
bauzas | although it would require libvirt to expose it | 15:41 |
jroll | (afaict) | 15:42 |
bauzas | jroll: well, basically I thought about resize because it's all about an existing instance taking an API flavor | 15:42 |
bauzas | here, that spec is focusing on changing the instance nested flavors, not the API-faced flavors AFAICS | 15:42 |
*** awaugama_ has joined #openstack-nova | 15:42 | |
bauzas | so we could end up mixing both old and new world, which could be a problem | 15:43 |
bauzas | jroll: tbc, my -1 is for signaling a potential problem | 15:43 |
jroll | I still don't get it, sorry :/ | 15:43 |
*** lpetrut has quit IRC | 15:43 | |
jroll | yeah I understand that much :) | 15:43 |
jroll | just trying to understand the concern | 15:43 |
bauzas | jroll: first, lemme verify if resize is available for ironic | 15:43 |
jroll | sure | 15:44 |
bauzas | mmm, it is not | 15:44 |
bauzas | https://docs.openstack.org/developer/nova/support-matrix.html#operation_resize | 15:44 |
*** jahsis has quit IRC | 15:44 | |
*** yamahata has joined #openstack-nova | 15:44 | |
bauzas | so perhaps it can be a nobrainer | 15:44 |
*** arne_r has joined #openstack-nova | 15:44 | |
mriedem | cfriesen: comments in https://review.openstack.org/#/c/265282/ | 15:45 |
*** whenry has joined #openstack-nova | 15:45 | |
mriedem | cfriesen: i'm +2 otherwise | 15:45 |
*** udesale has quit IRC | 15:46 | |
*** awaugama has quit IRC | 15:46 | |
*** annegentle has quit IRC | 15:46 | |
*** annegentle has joined #openstack-nova | 15:47 | |
jroll | bauzas: replied in gerrit | 15:47 |
*** manasm has joined #openstack-nova | 15:49 | |
*** armax has joined #openstack-nova | 15:49 | |
*** pbandark has joined #openstack-nova | 15:49 | |
*** karimb has quit IRC | 15:52 | |
*** adrian_otto has quit IRC | 15:52 | |
*** karimb has joined #openstack-nova | 15:52 | |
*** ratailor has joined #openstack-nova | 15:53 | |
*** hamzy has quit IRC | 15:53 | |
bauzas | jroll: I'm still struggling to evaluate the impacty | 15:53 |
bauzas | impact* | 15:53 |
*** pbandark has quit IRC | 15:53 | |
*** david-lyle has quit IRC | 15:54 | |
*** ssurana has joined #openstack-nova | 15:55 | |
jroll | bauzas: that instance.flavor migration thing only impacts allocations, afaict | 15:55 |
mriedem | cfriesen: nvm i'll just address the issues quick and approve | 15:55 |
*** nkrinner is now known as nkrinner_afk | 15:56 | |
*** karimb has quit IRC | 15:58 | |
bauzas | jroll: just to make sure I understand correctly | 15:59 |
bauzas | jroll: we migrate the existing instances in order to self-heal the allocations that would claim custom resource classes, right? | 15:59 |
*** abalutoiu has quit IRC | 16:00 | |
*** ratailor has quit IRC | 16:00 | |
*** david-lyle has joined #openstack-nova | 16:01 | |
jroll | bauzas: yep. we don't want a flavor to appear that suddenly can claim a node with an instance already on it | 16:01 |
jroll | though, thinking back to this morning | 16:01 |
*** adrian_otto has joined #openstack-nova | 16:01 | |
jroll | if we make a change that makes nova claim all resources for ironic nodes with an instance... we don't need this extra migration | 16:01 |
*** whenry has quit IRC | 16:02 | |
*** suresh12 has quit IRC | 16:02 | |
bauzas | jroll: graaah, just entering a team meeting, need to defer my thinkins for that :( | 16:03 |
bauzas | thinkings* | 16:03 |
jroll | bauzas: it's fine, no worries | 16:03 |
* jroll has meetings all afternoon and other things to work on | 16:03 | |
*** jamespage has joined #openstack-nova | 16:04 | |
jamespage | mriedem: hello | 16:05 |
jamespage | mriedem: would you have time to chat about https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1665698 | 16:05 |
openstack | Launchpad bug 1665698 in libvirt (Ubuntu Yakkety) "/etc/qemu-ifup not allowed by apparmor" [Medium,Triaged] | 16:05 |
mriedem | jamespage: ok, but i have no context on that. | 16:06 |
jamespage | mriedem: let me give you some :-) | 16:06 |
jamespage | mriedem: ok so... | 16:06 |
jamespage | mriedem: some history | 16:06 |
mriedem | this is the empty script path element thing? | 16:07 |
*** karimb has joined #openstack-nova | 16:07 | |
mriedem | i saw there was a revert proposed for that | 16:07 |
mriedem | sgordon: ^ | 16:07 |
jamespage | mriedem: that's the one | 16:07 |
jamespage | mriedem: the fix for bug 1649527 | 16:07 |
openstack | bug 1649527 in OpenStack Compute (nova) newton "nova creates an invalid ethernet/bridge interface definition in virsh xml" [Medium,Fix committed] https://launchpad.net/bugs/1649527 - Assigned to Roman Podoliaka (rpodolyaka) | 16:07 |
*** rmart04 has quit IRC | 16:08 | |
jamespage | appears to have broken baseline compatibility for libvirt so for certain vif types, xenial libvirt + newton stable is broken. | 16:08 |
bauzas | jroll: one other thinking while attending my meeting, if we rebuild an instance having a modified nested flavor, we could just put it to a Pike node then, right? | 16:08 |
openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: add spec for instance flavor API https://review.openstack.org/265282 | 16:08 |
bauzas | jroll: to make it clear, I'm not trying to punt your spec, just trying to think about all the possible move operations | 16:08 |
jroll | bauzas: yeah, I know what you're doing, I'm not upset about it | 16:09 |
bauzas | :) | 16:09 |
bauzas | I'm just an overthinking person :( | 16:10 |
jroll | bauzas: I would need to read rebuild code to answer that question, but I assume we use instance.flavor for that, which means the scheduling decision would be different. interesting. | 16:10 |
jroll | bauzas: "pike node" means a node with a resource class set, yes? | 16:10 |
mriedem | jamespage: ok it's confusing because of comments like this in the original bug report https://bugs.launchpad.net/nova/+bug/1649527/comments/19 | 16:10 |
openstack | Launchpad bug 1649527 in OpenStack Compute (nova) newton "nova creates an invalid ethernet/bridge interface definition in virsh xml" [Medium,Fix committed] - Assigned to Roman Podoliaka (rpodolyaka) | 16:10 |
bauzas | jroll: a node that supports that custom RC | 16:11 |
*** kaisers_ has joined #openstack-nova | 16:11 | |
mriedem | jamespage: also though libvirt 2.5.0 isn't base xenial | 16:11 |
mriedem | base xenial libvirt is 1.3.1 right? | 16:11 |
jroll | bauzas: right, yeah, it would be scheduled that way | 16:11 |
jamespage | mriedem: nope - its 1.3.1 | 16:11 |
jamespage | mriedem: that was a somewhat unhelpful comment | 16:11 |
jroll | bauzas: I'm thinking if we can do the "allocate all resources" thing outside of instance.flavor, we don't need to do this instance.flavor migration | 16:11 |
jamespage | mriedem: I found the bug history quite confusing as well | 16:11 |
bauzas | jroll: yeah I tend to agree with you although there could be some corner cases | 16:12 |
mriedem | jamespage: yeah they later clarified they were running in a container with debian so different versions :/ | 16:13 |
*** amotoki has quit IRC | 16:13 | |
bauzas | jroll: I'm just afraid of us possibly needing to do like we made for Ocata and just having the scheduler calling placement about custom RCs only if all the nodes are pike | 16:13 |
mriedem | jamespage: so i guess this didn't affect rhel 7.3 or centos because they are running with a newer libvirt which doesn't cause issues that 1.3.1 does | 16:13 |
mriedem | jamespage: this isn't just newton right? i mean it would also be broken in ocata wouldn't it? | 16:14 |
mriedem | i see the backport was merged to newton though https://review.openstack.org/#/c/425637/ | 16:14 |
*** gfhellma has joined #openstack-nova | 16:14 | |
mriedem | and we didn't raise the minimum required libvirt in nova in ocata | 16:14 |
jroll | bauzas: yeah, I see now, because we upgrade scheduler before compute, right? | 16:15 |
bauzas | jroll: yup | 16:15 |
jroll | bauzas: which means operators must wait until after the pike deploy to change their flavors. which isn't ideal but I think it's fine? | 16:16 |
bauzas | jroll: hum no | 16:16 |
bauzas | jroll: operators can modify their flavors in Ocata | 16:16 |
bauzas | given it's extra specs, it's just meaningless until Pike, that's it | 16:16 |
jroll | bauzas: pike scheduler + ocata compute means scheduling on new style flavors would be broken | 16:17 |
jroll | because we won't be reading resource class | 16:17 |
*** sridharg has quit IRC | 16:17 | |
bauzas | jroll: yeah the worst case scenario would be all but computes upgraded to Pike, and n-cpus still on Ocata | 16:18 |
bauzas | jroll: then, if flavors are upgraded, kaboom | 16:18 |
bauzas | NoValidHosts | 16:18 |
mriedem | jamespage: so if i'm understanding this correctly, between https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1665698/comments/50 and https://review.openstack.org/#/c/425637/1/releasenotes/notes/libvirt-script-with-empty-path-2b49caa68b05278d.yaml | 16:18 |
openstack | Launchpad bug 1665698 in libvirt (Ubuntu Yakkety) "/etc/qemu-ifup not allowed by apparmor" [Medium,Triaged] | 16:18 |
mriedem | jamespage: we want script path to be '' if libvirt < 1.3.3, and None if libvirt >= 1.3.3 yes? | 16:18 |
jroll | bauzas: right, which I guess is why I need reviews on this, too :) https://etherpad.openstack.org/p/nova-ironic-flavor-transition-plan | 16:18 |
bauzas | oh, never heard of that yet ^ | 16:19 |
jroll | bauzas: read more scheduler meeting :P | 16:19 |
jroll | bauzas: but yeah, I guess my spec kind of depends on this plan being solid | 16:19 |
bauzas | jroll: heh, not my fault, but my kid's one | 16:19 |
jroll | bauzas: we log for a reason! | 16:19 |
jroll | I'm mostly kidding | 16:20 |
jamespage | mriedem: correct | 16:20 |
bauzas | argh, no good fake reason to provide, I'm doomed | 16:20 |
*** hieulq_ has quit IRC | 16:20 | |
mriedem | jamespage: ok, i'll tinker with seeing how easy a fix that is | 16:21 |
jamespage | mriedem: thankyou much appreciated | 16:21 |
*** udesale has joined #openstack-nova | 16:21 | |
*** karimb has quit IRC | 16:22 | |
jroll | bauzas: line 39-42 there is me walking through rebuild in my head, I think it's okay | 16:22 |
*** whenry has joined #openstack-nova | 16:24 | |
*** gszasz_ has quit IRC | 16:25 | |
*** voelzmo has quit IRC | 16:25 | |
*** gszasz_ has joined #openstack-nova | 16:25 | |
*** belmoreira has quit IRC | 16:25 | |
*** nic has joined #openstack-nova | 16:26 | |
*** sneti_ has quit IRC | 16:26 | |
*** jdurgin has quit IRC | 16:27 | |
sgordon | mriedem, jamespage mmm yes | 16:27 |
sgordon | mriedem, jamespage revert of what specifically? | 16:27 |
sgordon | mriedem, jamespage libvirt has actually been fixed to handle the old xml more gracefully | 16:28 |
mriedem | sgordon: https://review.openstack.org/#/c/447169/ | 16:28 |
mriedem | sgordon: yes but according to https://bugs.launchpad.net/nova/+bug/1665698/comments/50 that's in libvirt 3.1 | 16:28 |
openstack | Launchpad bug 1665698 in libvirt (Ubuntu Yakkety) "/etc/qemu-ifup not allowed by apparmor" [Medium,Triaged] | 16:28 |
jamespage | sgordon: yeah we're all good on forward version compat I think | 16:28 |
mriedem | which is lightyears from where we'll be testing against in the gate | 16:28 |
*** jaosorior has quit IRC | 16:29 | |
jamespage | its backwards compat with 1.3.1 in Ubuntu Xenial | 16:29 |
sgordon | mriedem, yes so the distributor should backport it | 16:29 |
jamespage | backport what exactly? | 16:29 |
mriedem | the '' or None fix i guess | 16:29 |
mriedem | but what about someone not using a distro package? | 16:29 |
jamespage | nova has established min version compats | 16:29 |
sgordon | jamespage, the libvirt fix | 16:29 |
mriedem | or using not red hat or ubuntu distro package? | 16:29 |
mriedem | like suse | 16:29 |
mriedem | gentoo, etc | 16:30 |
sgordon | jamespage, yes but you obvs bumped the distro libvirt version at some point or you would not be hitting the issue | 16:30 |
mriedem | anyway, let me see how hard the conditional version check is in the code before we talk about making packagers handle this :) | 16:30 |
sgordon | jamespage, which is also why it only appeared on RHEL/CentOS 7.3 | 16:30 |
jamespage | sgordon: the libvirt version in xenial has been 1.3.1 since 16.04 release last year | 16:30 |
mriedem | ubuntu has libvirt 1.3.1 in stock 16.04 | 16:31 |
mriedem | that's what we test with in the gate | 16:31 |
mriedem | we just don't test with the same vif types that this hits | 16:31 |
sgordon | jamespage, the problem was only introduced in libvirt 1.3.2 | 16:31 |
sgordon | jamespage, so at some point it's been brought in via a backport | 16:31 |
*** CristinaPauna has quit IRC | 16:32 | |
mriedem | sgordon: why does the release note, that i think you wrote, say 1.3.3? https://review.openstack.org/#/c/411936/6/releasenotes/notes/libvirt-script-with-empty-path-2b49caa68b05278d.yaml | 16:33 |
jamespage | behaviour changed in 1.3.3 | 16:33 |
*** abalutoiu has joined #openstack-nova | 16:33 | |
*** karimb has joined #openstack-nova | 16:34 | |
*** arne_r has quit IRC | 16:34 | |
johnthetubaguy | dane-fichter: would be good to catch up on those | 16:34 |
cfriesen | mriedem: thanks for the updates and approval on the flavor API spec. you got to them before I even checked. :) | 16:34 |
mriedem | is there a way to see which tags are applied to a libvirt commit? i.e. https://libvirt.org/git/?p=libvirt.git;a=commit;h=9c17d665fdc5f0ab74500a14c30627014c11b2c0 | 16:35 |
*** fragatina has joined #openstack-nova | 16:35 | |
mriedem | nvm it's 1.3.3 | 16:36 |
mriedem | because 1.3.2 was https://libvirt.org/git/?p=libvirt.git;a=commit;h=dca504a1b977060b844393daedd0da4bdb21ee76 | 16:36 |
cfriesen | I don't see any tags applied to that commit. were you wondering what branch it was in? | 16:37 |
mriedem | no i sorted it out | 16:38 |
cfriesen | I usually use gitk to figure out branches/versions/etc. | 16:38 |
cfriesen | it shows "follows" and "preceeds" versions. | 16:38 |
*** vks1 has quit IRC | 16:39 | |
mriedem | now to see if os-vif is doing any of this | 16:39 |
*** markus_z has quit IRC | 16:39 | |
*** faizy__ has quit IRC | 16:40 | |
*** gszasz has joined #openstack-nova | 16:40 | |
mriedem | doesn't look like it, whew | 16:40 |
mriedem | so this affects ivs_ethernet, iovisor, midonet, tap and vrouter | 16:41 |
mriedem | sean-k-mooney: ^ we don't have os-vif support for those vif types yet right? | 16:41 |
*** gjayavelu has joined #openstack-nova | 16:41 | |
mriedem | doesn't look like it | 16:42 |
*** gszasz_ has quit IRC | 16:42 | |
*** manasm has quit IRC | 16:43 | |
*** Apoorva has joined #openstack-nova | 16:43 | |
*** Daviey_ is now known as Daviey | 16:49 | |
*** bmace has quit IRC | 16:49 | |
*** bmace has joined #openstack-nova | 16:49 | |
*** crushil has quit IRC | 16:51 | |
*** satyar has quit IRC | 16:51 | |
sgordon | mriedem, digging back through the commentary i think the right approach is the branch you suggest | 16:53 |
mriedem | should have a patch up shortly | 16:54 |
sgordon | mriedem, a straight revert is just going to switch back to the other group of upset operators yelling about it because the are on libvirt >= 1.3.3 | 16:54 |
mriedem | this is going to be a bit of a mess in newton i suspect | 16:54 |
sgordon | mriedem, yeapppp | 16:54 |
mriedem | in ocata we have access to the libvirt version in the vif code | 16:54 |
mriedem | but i don't think i have that access in newton | 16:54 |
mriedem | so will have to poke around | 16:54 |
sgordon | mriedem, the revert approach also removed the rel note but given the combinations involved here i still think we will want to add one | 16:54 |
sgordon | mriedem, "if you see this behavior then do we have a deal for you..." | 16:55 |
*** jaosorior has joined #openstack-nova | 16:55 | |
mriedem | buy one get one half off bug sale?! | 16:55 |
* mriedem runs tests and makes sandwich | 16:55 | |
*** udesale has quit IRC | 16:57 | |
*** ociuhandu has quit IRC | 16:59 | |
*** abalutoiu has quit IRC | 17:02 | |
*** abalutoiu has joined #openstack-nova | 17:02 | |
johnthetubaguy | #success First few patches adding real docs for policy have now merged in Nova. A much improved sample file: https://docs.openstack.org/developer/nova/sample_policy.html | 17:08 |
openstackstatus | johnthetubaguy: Added success to Success page | 17:08 |
*** kaisers_ has quit IRC | 17:09 | |
*** crushil has joined #openstack-nova | 17:10 | |
*** ociuhandu has joined #openstack-nova | 17:10 | |
*** claudiub|2 has quit IRC | 17:10 | |
*** unicell has quit IRC | 17:10 | |
*** baoli has joined #openstack-nova | 17:12 | |
*** ociuhandu has quit IRC | 17:14 | |
*** Qiming has quit IRC | 17:15 | |
*** Nisha_Agarwal has joined #openstack-nova | 17:18 | |
*** Qiming has joined #openstack-nova | 17:19 | |
*** baoli has quit IRC | 17:19 | |
*** artom has quit IRC | 17:19 | |
*** artom has joined #openstack-nova | 17:19 | |
openstackgerrit | John Garbutt proposed openstack/nova master: Remove unused policy rule in admin_actions.py https://review.openstack.org/447611 | 17:20 |
*** ltomasbo is now known as ltomasbo|away | 17:20 | |
*** baoli has joined #openstack-nova | 17:24 | |
*** ltomasbo|away is now known as ltomasbo | 17:25 | |
*** ociuhandu has joined #openstack-nova | 17:25 | |
*** awaugama has joined #openstack-nova | 17:26 | |
mriedem | sgordon: jamespage: actually the same fix i have should work on newton, we have the stuff i needed for the version check | 17:26 |
*** hamzy has joined #openstack-nova | 17:26 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: conditinally set script path for ethernet vif types https://review.openstack.org/448203 | 17:27 |
mriedem | sgordon: jamespage: review/test of ^ would be appreciated | 17:27 |
*** fragatina has quit IRC | 17:28 | |
sgordon | mriedem, thanks i'll add sfinucan as my proxy with a brain here ;) | 17:28 |
*** awaugama_ has quit IRC | 17:28 | |
* sgordon only plays someone with a clue on TV | 17:28 | |
dane-fichter | johnthetubaguy: hey I'm back, had to step out for a meeting | 17:29 |
sfinucan | I'm starting to get why sysadmins don't like upgrading package versions | 17:30 |
*** catintheroof has quit IRC | 17:30 | |
*** catintheroof has joined #openstack-nova | 17:30 | |
johnthetubaguy | dane-fichter: no worries | 17:30 |
dane-fichter | johnthetubaguy: did my comment answer questions you have? | 17:31 |
*** rfolco has quit IRC | 17:32 | |
dane-fichter | johnthetubaguy: it seems like the drivers have to support trusted flavors based on how the download() method gets called | 17:32 |
johnthetubaguy | dane-fichter: well I think you could hide that using driver capabilities | 17:33 |
*** annegentle has quit IRC | 17:33 | |
dane-fichter | johnthetubaguy: Can you explain a little more? where in the code does that happen? | 17:34 |
johnthetubaguy | dane-fichter: yeah, I will try find an example, one sec | 17:34 |
johnthetubaguy | dane-fichter: here is one example: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1730 | 17:35 |
johnthetubaguy | dane-fichter: its not perfect, but its a pattern I think you could re-use, that makes things consistent | 17:35 |
*** artom has quit IRC | 17:35 | |
dane-fichter | johnthetubaguy: so that seems useful to just prevent the wrong drivers from trying to boot a trusted flavor instance | 17:37 |
*** david-lyle_ has joined #openstack-nova | 17:37 | |
dane-fichter | johnthetubaguy: but there's no real reason other than the semantics of download() that all drivers can't support this | 17:37 |
*** artom has joined #openstack-nova | 17:37 | |
dane-fichter | johnthetubguy: seems like we should just modify download() to take the instance or flavor object as well | 17:38 |
johnthetubaguy | dane-fichter: oh, yes, agreed with you, well not all drivers use that download() method, the ones that do can support it | 17:38 |
*** david-lyle has quit IRC | 17:38 | |
dane-fichter | johnthetubaguy: ohh was not aware of that | 17:38 |
*** lucasagomes is now known as lucas-afk | 17:38 | |
sfinucan | sgordon: Done | 17:39 |
*** unicell has joined #openstack-nova | 17:39 | |
dane-fichter | johnthetubaguy: so we could probably do both things here; use driver capabilities to prevent unsupported drivers from booting trusted flavors | 17:39 |
johnthetubaguy | dane-fichter: xenapi has its own in hypervisor route, to avoid a double hop, because nova-compute doesn't run somewhere with access to the hypervisor disk | 17:39 |
johnthetubaguy | dane-fichter: yeah, sounds like we are talking slightly cross purposes in there, agreed with with doing both things | 17:40 |
*** cdent has quit IRC | 17:40 | |
*** yamahata has quit IRC | 17:40 | |
johnthetubaguy | dane-fichter: honestly, lots of that detail we can leave till code review, its just a saw detail in the spec that didn't look quite right to me, if that makes sense | 17:40 |
*** sneti_ has joined #openstack-nova | 17:41 | |
dane-fichter | johnthetubaguy: yeah. so maybe just tone down the detail in that implementation steps section? | 17:41 |
*** ltomasbo is now known as ltomasbo|away | 17:41 | |
dane-fichter | johnthetubaguy: i'll definitely specify the driver capabilities wrinkle | 17:42 |
*** jdurgin has joined #openstack-nova | 17:42 | |
johnthetubaguy | dane-fichter: yeah, I think we need to add how to deal with "strange" virt drivers, but yeah the method calls and where the code exactly lives probable best left till later | 17:42 |
* johnthetubaguy wonders about a spelling correction bot | 17:43 | |
johnthetubaguy | s/probable/probably/ | 17:43 |
dane-fichter | johnthetubaguy: yes, agreed. thanks john | 17:44 |
johnthetubaguy | dane-fichter: no worries | 17:45 |
*** lpetrut has joined #openstack-nova | 17:47 | |
*** beagles is now known as beagles_lunch | 17:48 | |
*** iceyao has quit IRC | 17:48 | |
*** derekh has quit IRC | 17:50 | |
*** crushil has quit IRC | 17:51 | |
*** satyar has joined #openstack-nova | 17:52 | |
*** ralonsoh has quit IRC | 17:52 | |
*** crushil has joined #openstack-nova | 17:53 | |
*** adreznec has quit IRC | 17:55 | |
*** fragatina has joined #openstack-nova | 17:55 | |
*** annegentle has joined #openstack-nova | 17:56 | |
*** adreznec has joined #openstack-nova | 17:57 | |
*** jaosorior has quit IRC | 17:57 | |
*** mtanino has quit IRC | 17:58 | |
*** sneti_ has quit IRC | 18:03 | |
*** suresh12 has joined #openstack-nova | 18:03 | |
*** markd_ has quit IRC | 18:04 | |
*** Drankis has joined #openstack-nova | 18:05 | |
*** artom_ has joined #openstack-nova | 18:06 | |
*** karimb has quit IRC | 18:06 | |
*** suresh12 has quit IRC | 18:07 | |
*** sneti_ has joined #openstack-nova | 18:07 | |
*** ircuser-1 has quit IRC | 18:07 | |
*** xyang1 has joined #openstack-nova | 18:08 | |
*** artom has quit IRC | 18:09 | |
*** dtp has joined #openstack-nova | 18:10 | |
*** jdurgin has quit IRC | 18:10 | |
mriedem | sfinucan: i've got to update that bug fix patch, missed a couple tests | 18:11 |
*** mtanino has joined #openstack-nova | 18:11 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: conditionally set script path for ethernet vif types https://review.openstack.org/448203 | 18:13 |
mriedem | sfinucan: here we go ^ | 18:13 |
*** ociuhandu has quit IRC | 18:14 | |
*** artom__ has joined #openstack-nova | 18:14 | |
*** artom_ has quit IRC | 18:17 | |
openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in cells.py https://review.openstack.org/448224 | 18:17 |
*** jdurgin has joined #openstack-nova | 18:18 | |
*** mvk has quit IRC | 18:18 | |
openstackgerrit | GƔbor Antal proposed openstack/nova master: Pre-add functional tests stub to notification testing https://review.openstack.org/448225 | 18:18 |
*** avolkov has quit IRC | 18:21 | |
*** vladikr has quit IRC | 18:21 | |
dane-fichter | mriedem: got a second to discuss the cursive change? | 18:22 |
dane-fichter | mriedem: this one https://review.openstack.org/#/c/351232/ | 18:22 |
*** weshay_sick is now known as weshay_brb | 18:25 | |
*** yamahata has joined #openstack-nova | 18:26 | |
mriedem | dane-fichter: yeah | 18:30 |
*** artom__ has quit IRC | 18:31 | |
*** yamahata has quit IRC | 18:31 | |
*** yamahata has joined #openstack-nova | 18:31 | |
*** tesseract has quit IRC | 18:31 | |
*** artom has joined #openstack-nova | 18:32 | |
*** beagles_lunch is now known as beagles | 18:33 | |
openstackgerrit | GƔbor Antal proposed openstack/nova master: Pre-add functional tests stub to notification testing https://review.openstack.org/448225 | 18:34 |
*** baoli has quit IRC | 18:35 | |
*** baoli has joined #openstack-nova | 18:36 | |
*** artom_ has joined #openstack-nova | 18:37 | |
*** Sukhdev has joined #openstack-nova | 18:38 | |
*** artom has quit IRC | 18:39 | |
*** pcaruana has quit IRC | 18:39 | |
*** jpena is now known as jpena|off | 18:39 | |
*** Tahvok has left #openstack-nova | 18:40 | |
*** weshay_brb is now known as weshay | 18:42 | |
*** vladikr has joined #openstack-nova | 18:43 | |
*** Jack_Iv has joined #openstack-nova | 18:44 | |
mriedem | sdague: do you have an opinion on how to handle these tests? https://review.openstack.org/#/c/351232/11/nova/tests/unit/objects/test_fields.py | 18:44 |
*** haplo37 has quit IRC | 18:44 | |
*** dtp has quit IRC | 18:45 | |
*** Jack_Iv has quit IRC | 18:46 | |
*** david-lyle_ has quit IRC | 18:46 | |
*** Jack_Iv has joined #openstack-nova | 18:46 | |
*** Jack_Iv has quit IRC | 18:47 | |
*** Jack_Iv has joined #openstack-nova | 18:47 | |
*** armax has quit IRC | 18:49 | |
*** haplo37 has joined #openstack-nova | 18:49 | |
*** Jack_Iv_ has joined #openstack-nova | 18:51 | |
*** mvk has joined #openstack-nova | 18:53 | |
*** Jack_Iv_ has quit IRC | 18:55 | |
*** Jack_Iv has quit IRC | 18:55 | |
*** karimb has joined #openstack-nova | 18:56 | |
*** alexpilotti has joined #openstack-nova | 18:57 | |
*** jdurgin has quit IRC | 18:58 | |
*** ociuhandu has joined #openstack-nova | 18:59 | |
*** kfarr has joined #openstack-nova | 19:00 | |
*** alexpilotti has quit IRC | 19:00 | |
*** alexpilotti has joined #openstack-nova | 19:01 | |
*** jdurgin has joined #openstack-nova | 19:02 | |
*** annegentle has quit IRC | 19:02 | |
*** READ10 has quit IRC | 19:03 | |
*** kfarr has quit IRC | 19:05 | |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: console https://review.openstack.org/409402 | 19:06 |
sdague | mriedem: I need a lot more context here | 19:08 |
*** dharinic is now known as dharinic|lunch | 19:09 | |
*** kfarr has joined #openstack-nova | 19:09 | |
mriedem | sdague: the signature_utils stuff is now in a library | 19:09 |
mriedem | used in nova and glance | 19:09 |
mriedem | we have versioned objects that use enum fields with values defined in that library now | 19:10 |
*** kaisers_ has joined #openstack-nova | 19:10 | |
mriedem | we have tests in nova that check to make sure if you update the constants in signature_utils (now the library), we bump the enum lists in the versioned object, | 19:10 |
mriedem | that was all fine and dandy while it was all within nova, | 19:10 |
*** satyar has quit IRC | 19:10 | |
mriedem | but with the constants defined in a library now, it means if the library adds new constants, our unit tests will fail and requires a dance to get things working to use the library in upper-constraints | 19:11 |
sdague | ok, so don't you want to invert the iteration? | 19:11 |
mriedem | i left a comment in there about what i think the dance is, | 19:11 |
mriedem | if we leave things as-is | 19:11 |
mriedem | and get the constants from the library now | 19:11 |
sdague | so just test that the enum in Nova are all in in the signature utils lib ? | 19:11 |
mriedem | other way around, | 19:11 |
mriedem | the test makes sure that the constants defined in the lib are reflected in our enums, | 19:12 |
mriedem | which feed into ImageMetaProps | 19:12 |
sdague | mriedem: ok, I'm not sure why that's actually important to couple here | 19:12 |
mriedem | so if a new constant is added and released, we can't use that version of the library in upper-constraints until nova makes a change, before g-r is bumped, which is a bit odd | 19:12 |
sdague | mriedem: yeh, so, that's fine | 19:12 |
mriedem | i'm not sure it is either | 19:12 |
mriedem | that's just the way it was when it was all in tree | 19:13 |
*** bswartz has quit IRC | 19:13 | |
sdague | the whole purpose of decoupling to a library is not to have lock step coupling with projects | 19:13 |
mriedem | i suppose to keep a reminder that if we support new hash methods and key types that our image meta properties object should also support those | 19:13 |
sdague | yep | 19:13 |
sdague | also, it's not like new hash methods just spring forth all the time | 19:13 |
mriedem | if the library adds new things now, and we don't keep our enums and versioned objects up to date, then i guess someone just has to do that when they actually want to use a new thing in the library | 19:14 |
sdague | they take years to a decade to proof out | 19:14 |
mriedem | yeah | 19:14 |
mriedem | so i'm also ok with just dropping the nova tests i think | 19:14 |
sdague | so the fact that you add to the lib, then add to the lib consumers, seems fine | 19:14 |
*** kaisers_ has quit IRC | 19:15 | |
mriedem | ok so pro-drop the tests and coupling | 19:15 |
mriedem | that works for me, i just didn't like thinking this through in a vacuum | 19:15 |
*** kfarr_ has joined #openstack-nova | 19:16 | |
*** kfarr has quit IRC | 19:16 | |
*** karimb has quit IRC | 19:16 | |
*** lpetrut has quit IRC | 19:17 | |
*** annegentle has joined #openstack-nova | 19:22 | |
mriedem | dane-fichter: ^ replied in the change too | 19:22 |
*** liangy has quit IRC | 19:24 | |
*** vladikr has quit IRC | 19:24 | |
*** sneti_ has quit IRC | 19:26 | |
*** gyee has joined #openstack-nova | 19:26 | |
*** kaisers_ has joined #openstack-nova | 19:27 | |
*** rfolco has joined #openstack-nova | 19:29 | |
dane-fichter | mriedem: I see. Just read the discussion w sdague too. sounds good. | 19:30 |
*** mlavalle has quit IRC | 19:33 | |
*** sneti_ has joined #openstack-nova | 19:34 | |
*** Nisha_ has joined #openstack-nova | 19:35 | |
*** Nisha_Agarwal has quit IRC | 19:38 | |
*** cdent has joined #openstack-nova | 19:39 | |
*** awaugama has quit IRC | 19:39 | |
*** gjayavelu has quit IRC | 19:40 | |
*** liangy has joined #openstack-nova | 19:41 | |
*** amoralej is now known as amoralej|off | 19:44 | |
*** tbachman has quit IRC | 19:44 | |
*** tbachman has joined #openstack-nova | 19:45 | |
mriedem | gcb: can't we do this now? https://github.com/openstack/nova/blob/master/tox.ini#L70 | 19:45 |
mriedem | the functional-py35 job is gating on nova | 19:46 |
mriedem | i'm not sure how basepython would work with that though, or if you just omit it | 19:46 |
mriedem | we would also have to change the job defintions in project-config if we combined those two jobs | 19:46 |
*** dharinic|lunch is now known as dharinic | 19:46 | |
*** dtp has joined #openstack-nova | 19:49 | |
*** dane-fichter has quit IRC | 19:53 | |
*** eglynn has quit IRC | 19:56 | |
*** Nisha_ has quit IRC | 19:57 | |
*** claudiub|2 has joined #openstack-nova | 19:59 | |
*** esberglu has quit IRC | 20:00 | |
*** lpetrut has joined #openstack-nova | 20:00 | |
*** esberglu has joined #openstack-nova | 20:00 | |
*** dave-mccowan has quit IRC | 20:02 | |
*** armax has joined #openstack-nova | 20:02 | |
*** artom__ has joined #openstack-nova | 20:04 | |
*** esberglu has quit IRC | 20:05 | |
openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in cells_scheduler.py https://review.openstack.org/448260 | 20:05 |
*** artom_ has quit IRC | 20:07 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Tests: remove .testrepository/times.dbm in tox.ini (functional) https://review.openstack.org/448266 | 20:08 |
*** kfarr_ has quit IRC | 20:10 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/446674 | 20:10 |
*** karimb has joined #openstack-nova | 20:11 | |
openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in certificates.py https://review.openstack.org/448267 | 20:11 |
openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in cells.py https://review.openstack.org/448224 | 20:13 |
*** mlavalle has joined #openstack-nova | 20:14 | |
*** browne has joined #openstack-nova | 20:16 | |
mriedem | sdague: are you going to be submitting a forum session proposal for limits in keystone? | 20:17 |
*** priteau has joined #openstack-nova | 20:18 | |
*** clenimar has joined #openstack-nova | 20:26 | |
*** crushil has quit IRC | 20:27 | |
openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in cloudpipe.py https://review.openstack.org/448271 | 20:30 |
*** esberglu has joined #openstack-nova | 20:32 | |
*** dave-mccowan has joined #openstack-nova | 20:32 | |
*** smatzek has quit IRC | 20:33 | |
sdague | mriedem: I suppose, I'm still a little confused on content for the forum | 20:33 |
mriedem | you and me both, | 20:33 |
mriedem | but it sounds like we start submitting abstracts and then the TC and UC vote on them | 20:33 |
mriedem | http://lists.openstack.org/pipermail/user-committee/2017-March/001856.html | 20:34 |
mriedem | sessions are proposed here http://forumtopics.openstack.org/ | 20:34 |
dansmith | I'm totally confused | 20:35 |
dansmith | I put some stuff in an etherpad which was originally requested | 20:35 |
mriedem | i think the brainstorming etherpads were for project teams to agree on what to submit to http://forumtopics.openstack.org/ | 20:35 |
mriedem | "Starting today, our submission tool is open for you to submit abstracts for the most popular sessions that came out of your brainstorming. *Please note that the etherpads are not being pulled into the submission tool and discussion around which sessions to submit are encouraged.*" | 20:36 |
dansmith | ah okay | 20:36 |
dansmith | confusing | 20:36 |
mriedem | so we'll have one for cells, one for placement and one for limits | 20:36 |
mriedem | at least | 20:36 |
*** tbachman has quit IRC | 20:36 | |
mriedem | "We are looking for a good mix of project-specific, cross-project or strategic/whole-of-community discussions, and *sessions that emphasize collaboration between users and developers are most welcome!*" | 20:36 |
*** cleong has quit IRC | 20:36 | |
dansmith | mriedem: are you going to do those to avoid overlap or should I put one in there? | 20:36 |
mriedem | i think those 3 fall into that category | 20:36 |
johnthetubaguy | I think brainstorming turned into formal submission | 20:36 |
johnthetubaguy | but I got confused too | 20:36 |
bauzas | not sure I understand how the Forum works, honestly | 20:36 |
mriedem | ha, it was so quiet in here for the last several hours | 20:37 |
mriedem | you were all just lurking | 20:37 |
bauzas | AFAICU, there are some sessions for newcomers too | 20:37 |
mriedem | dansmith: submit one for cells | 20:37 |
dansmith | okay | 20:37 |
mriedem | bauzas: that's separate | 20:37 |
mriedem | bauzas: i think anyway | 20:37 |
mriedem | diablo_rojo is coordinating that | 20:37 |
bauzas | okay | 20:37 |
mriedem | but she's not on irc so idk for sure | 20:37 |
dansmith | mriedem: and this is for user/op interaction, or review of the progress and planning for the rest of the cycle or what? | 20:37 |
*** gjayavelu has joined #openstack-nova | 20:38 | |
mriedem | EmilienM: do we need to submit to forumtopis.o.o for the newcomer sessions too? | 20:38 |
dansmith | so wait, the TC votes on these? | 20:38 |
* bauzas is looking at https://wiki.openstack.org/wiki/Forum | 20:38 | |
mriedem | "After submissions close, a team of representatives from the User Committee, the Technical Committee, and Foundation staff will take the sessions proposed by the community and fill out the schedule." | 20:38 |
EmilienM | mriedem: yes I think so | 20:38 |
dansmith | weird | 20:38 |
mriedem | dansmith: i think cells, placement and limits all fall into the criteria | 20:38 |
EmilienM | dansmith: some folks will vote yes, and 2 folks from TC, me and Doug AFIK | 20:38 |
mriedem | for "project-specific, cross-project or strategic/whole-of-community discussions" | 20:39 |
* johnthetubaguy was having food, is now in TC meeting, but wondered | 20:39 | |
mriedem | cells is project-specific, placement is cross-project, and limits are whole-of-community | 20:39 |
*** leseb_ has quit IRC | 20:41 | |
*** suresh12 has joined #openstack-nova | 20:42 | |
*** leseb_ has joined #openstack-nova | 20:44 | |
*** suresh12 has quit IRC | 20:46 | |
*** suresh12 has joined #openstack-nova | 20:49 | |
*** priteau_ has joined #openstack-nova | 20:55 | |
*** felipemonteiro has quit IRC | 20:56 | |
bauzas | mriedem: do you see the nova bits of https://etherpad.openstack.org/p/BOS-Nova-brainstorming do you think it would rather fit in the "real" Forum or the newcomers side rooms ? | 20:58 |
bauzas | I'm confused, I thought it was intended for the former | 20:59 |
*** priteau has quit IRC | 20:59 | |
mriedem | nova bits? | 21:01 |
mriedem | that's a nova-specific etherpad | 21:01 |
mriedem | there is nothing in there that's suitable for a newcomer probably | 21:01 |
bauzas | I agree | 21:01 |
*** gszasz has quit IRC | 21:01 | |
bauzas | mriedem: IIUC, we would put our items into forumtopics.o.o so the TC/UC/Foundation folks would vote on those | 21:02 |
bauzas | that doesn't necessarly mean all the items we want to discuss will be accepted then | 21:02 |
bauzas | and https://etherpad.openstack.org/p/BOS-TC-brainstorming is already having lots of proposed sessions | 21:03 |
*** kaisers_ has quit IRC | 21:03 | |
openstackgerrit | Vivek Agrawal proposed openstack/nova-specs master: Spec for libvirt driver extension for Veritas HyperScale https://review.openstack.org/430488 | 21:03 |
mriedem | bauzas: we have 3-4 sessions i think, | 21:03 |
mriedem | placement (all), cells (all), limits and johnthetubaguy's vm/bm thing | 21:04 |
*** kaisers_ has joined #openstack-nova | 21:04 | |
*** karimb has quit IRC | 21:04 | |
mriedem | anything that doesn't get accepted is table talk for the dev cave | 21:04 |
mriedem | at least that's my understanding | 21:04 |
bauzas | yeah, that's what I understand | 21:04 |
mriedem | now having said that, | 21:04 |
mriedem | dansmith and jaypipes have approved talks for cells and placement already, | 21:05 |
bauzas | my only concern is that I'm not sure we even have 3-4 slots | 21:05 |
mriedem | they aren't like design summit | 21:05 |
mriedem | they are presentations | 21:05 |
bauzas | I know | 21:05 |
mriedem | the forum topics are normal fishbowl sessions like before i think | 21:05 |
mriedem | get devs and ops people together and talk through things for the release | 21:05 |
bauzas | yeah, it's fishbowls | 21:05 |
mriedem | what do you mean about your concern that we don't have 3-4 slots? | 21:06 |
mriedem | we don't have 2 full days of back to back nova sessions anymore, no | 21:06 |
mriedem | that's the PTG now | 21:06 |
bauzas | the fact that we would not necessary have all the nova items be covered | 21:06 |
mriedem | which is why devs don't get funded to go to the summit anymore | 21:06 |
*** abalutoiu has quit IRC | 21:06 | |
mriedem | i'm not following you, anything that doesn't have a dedicated session, gets discussed by whoever is there in the dev lounge, or whatever | 21:07 |
*** abalutoiu has joined #openstack-nova | 21:07 | |
mriedem | http://lists.openstack.org/pipermail/openstack-dev/2017-March/113459.html | 21:07 |
mriedem | "3/ Free hacking/meetup space" | 21:07 |
mriedem | ^ is where the spill over stuff happens | 21:07 |
bauzas | it's basically tables in a free room | 21:07 |
mriedem | with just devs | 21:07 |
mriedem | yes | 21:07 |
mriedem | not scheduled | 21:07 |
mriedem | i think the entire point of the forum is to get the devs out of the cave, | 21:08 |
mriedem | and into gen pop | 21:08 |
bauzas | even if I wasn't expecting a lot of devs at the event, I was still thinking we could do some sprint there | 21:08 |
mriedem | so there won't be as much time to just sit around and talk through technical things that are going on in the release, | 21:08 |
mriedem | there will be time for some of that, but not nearly as much as the old design summit | 21:08 |
mriedem | johnthetubaguy: sdague: ttx: ^ is this all your understanding as well? | 21:09 |
*** crushil has joined #openstack-nova | 21:09 | |
*** aysyd has quit IRC | 21:09 | |
bauzas | well, I guess my concern is rather about the possibility to have an intermediate f2f meeting with folks to discuss about priorities updates | 21:10 |
bauzas | and possible tech discussions | 21:10 |
*** Apoorva has quit IRC | 21:10 | |
bauzas | but yeah, I got the message that Forum is not intented for devs just working in their cave | 21:10 |
cdent | oog like cave | 21:10 |
*** dimtruck is now known as zz_dimtruck | 21:10 | |
*** Apoorva has joined #openstack-nova | 21:10 | |
mriedem | bauzas: there will be that, when we're not in other sessions | 21:11 |
mriedem | the 'other' sessions that aren't just nova devs have to be fleshed out and scheduled first, | 21:11 |
mriedem | then with any free time, we do the priority talk stuff that we'd normally do at a midcycle | 21:11 |
mriedem | but with like 1/3 of the people | 21:11 |
jaypipes | sean-k-mooney, alex_xu, cdent, edleafe, sfinucan, mriedem: https://review.openstack.org/#/c/448282 | 21:17 |
cdent | jaypipes: is that for the future or for The Futureā¢? | 21:18 |
jaypipes | cdent: The FUTURE. | 21:18 |
* cdent falls over stunned | 21:18 | |
*** sneti_ has quit IRC | 21:22 | |
*** david-lyle has joined #openstack-nova | 21:23 | |
*** kaisers_ has quit IRC | 21:24 | |
cdent | jaypipes: responded with a while hair | 21:30 |
cdent | or even a wild hair | 21:31 |
*** zz_dimtruck is now known as dimtruck | 21:34 | |
*** sree has joined #openstack-nova | 21:34 | |
*** annegentle has quit IRC | 21:34 | |
*** Drankis has quit IRC | 21:34 | |
*** Jeffrey4l_ has quit IRC | 21:35 | |
*** crushil has quit IRC | 21:36 | |
*** annegentle has joined #openstack-nova | 21:37 | |
*** alex_xu has quit IRC | 21:37 | |
*** Yingxin has quit IRC | 21:37 | |
*** ijw has joined #openstack-nova | 21:38 | |
*** alex_xu has joined #openstack-nova | 21:38 | |
*** sree has quit IRC | 21:38 | |
*** ircuser-1 has joined #openstack-nova | 21:39 | |
*** Yingxin has joined #openstack-nova | 21:39 | |
*** adisky_ has quit IRC | 21:39 | |
*** tbachman has joined #openstack-nova | 21:40 | |
*** tbachman has quit IRC | 21:45 | |
*** tblakes has quit IRC | 21:46 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Warn on usage of _LI/_LW/_LE/_LC https://review.openstack.org/448293 | 21:47 |
mriedem | sdague: ^ is something worth doing? for the i18n marker stuff. your latest reply in that thread got me thinking about it. | 21:47 |
*** Jeffrey4l_ has joined #openstack-nova | 21:48 | |
*** gouthamr has quit IRC | 21:48 | |
dansmith | omg are we really doing that? | 21:49 |
jroll | mriedem: man, that's gonna blow up the logs | 21:49 |
jroll | lol | 21:49 |
mriedem | just an idea fellas | 21:49 |
*** lpetrut has quit IRC | 21:49 | |
jroll | I haven't read sean's email to be fair | 21:49 |
dansmith | we can thank IBM for: 1. PowerVM driver (removed), 2. DB2 (removed), 3. Lazy log translations (removed) | 21:49 |
mriedem | at first i just thought about doing _LW = _, etc | 21:49 |
mriedem | dansmith: this is different from lazy translation | 21:50 |
dansmith | fine, 3. whatever you call this | 21:50 |
jroll | it has been ___ days since we removed a bad IBM idea | 21:50 |
mriedem | that's better | 21:50 |
dansmith | jroll: lol | 21:50 |
mriedem | you can thank ibm for me | 21:51 |
mriedem | right?! | 21:51 |
mriedem | <3 | 21:51 |
dansmith | they don't take your calls anymore? | 21:51 |
jroll | meanwhile the ironic team has spent all day waffling on what to do with msg='foo'; log.error(msg); raise FooError(msg) | 21:51 |
*** marst has quit IRC | 21:51 | |
mriedem | dansmith: no, thank them the other way | 21:51 |
jroll | do we translate it? not? write extra code to only translate one? god forbid we interpolate twice | 21:51 |
dansmith | jroll: punt a decision to forum | 21:51 |
jroll | lol | 21:52 |
*** haplo37 has quit IRC | 21:52 | |
dansmith | that's always the answer | 21:52 |
jroll | that might be productive, I think there will only be 3-4 ironic devs | 21:52 |
dansmith | hah | 21:52 |
*** cdent has quit IRC | 21:56 | |
*** karimb has joined #openstack-nova | 21:56 | |
*** catintheroof has quit IRC | 21:57 | |
*** catintheroof has joined #openstack-nova | 21:58 | |
*** catintheroof has quit IRC | 21:58 | |
*** ijw has quit IRC | 21:58 | |
*** ijw has joined #openstack-nova | 21:59 | |
*** jdurgin has quit IRC | 21:59 | |
*** annegentle has quit IRC | 22:00 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add release note for CVE-2017-7214 https://review.openstack.org/448295 | 22:01 |
mriedem | dansmith: want to take a gander at ^? if ok, i'm going to backport to all branches and prep for releases. | 22:01 |
*** haplo37 has joined #openstack-nova | 22:01 | |
*** mdrabe has quit IRC | 22:04 | |
mriedem | jroll: btw, have you ever checked the py35 job run logs? | 22:08 |
mriedem | if you're worried about deprecationg warnings... | 22:08 |
mriedem | *deprecation | 22:08 |
*** ijw has quit IRC | 22:08 | |
dansmith | mriedem: not sure I saw a fix for that merge, but I assume it did? | 22:08 |
mriedem | dansmith: totes | 22:09 |
*** tbachman has joined #openstack-nova | 22:09 | |
mriedem | dansmith: https://review.openstack.org/#/q/I1d217620e52d45595a3e0e49ed57b4ab33cd1688,n,z | 22:09 |
*** Qiming has quit IRC | 22:09 | |
dansmith | cool | 22:09 |
dansmith | mriedem: fast approve? | 22:10 |
mriedem | dansmith: sure | 22:10 |
mriedem | i'm doing the stable backports for the reno now | 22:10 |
dansmith | cool | 22:11 |
mriedem | billy idol is telling me about how he doesn't have eyes in his face | 22:11 |
mriedem | or something like that | 22:11 |
dansmith | INXS is telling me about this One THing | 22:11 |
mriedem | it's called a belt | 22:11 |
mriedem | and a room to yourself | 22:11 |
mriedem | too soon? | 22:11 |
dansmith | um | 22:12 |
mriedem | dude | 22:12 |
mriedem | you don't get the reference? | 22:12 |
*** Qiming has joined #openstack-nova | 22:12 | |
dansmith | well, um... | 22:13 |
dansmith | oh, heh | 22:14 |
mriedem | there you go | 22:14 |
mriedem | geez | 22:14 |
mriedem | here are the reno backports https://review.openstack.org/#/q/I1f5b772bff8fa2dc508c4bdd3dd1f32838594786,n,z | 22:14 |
*** baoli has quit IRC | 22:18 | |
*** crushil has joined #openstack-nova | 22:18 | |
bauzas | mriedem: jroll: EmilienM: before going to bed, I was looking at https://review.openstack.org/#/c/448098/ | 22:18 |
EmilienM | bauzas: ok | 22:18 |
bauzas | EmilienM: I can't find a Depends-On for this one | 22:18 |
EmilienM | bauzas: yeah it's on the other way | 22:18 |
bauzas | EmilienM: how can I make sure it helps TripleO ? | 22:19 |
EmilienM | because Nova refused to run tripleo job, I had to propose a patch in tripleo to depends on this one | 22:19 |
*** browne has quit IRC | 22:19 | |
mriedem | https://review.openstack.org/#/c/447522 | 22:19 |
EmilienM | bauzas: https://review.openstack.org/#/c/447522/ | 22:19 |
*** jamesdenton has quit IRC | 22:19 | |
bauzas | hmpffff lots of red | 22:19 |
mriedem | which is queued | 22:19 |
EmilienM | bauzas: yes but unrelated | 22:19 |
mriedem | they are having timeouts in their jobs | 22:19 |
EmilienM | yeah it seems like everything broke for us today | 22:20 |
EmilienM | centos repos are down 30% of time | 22:20 |
EmilienM | etc etc | 22:20 |
mriedem | bauzas: we also have tripleo in the nova experimental queue if you just wanted to run it on the nova change itself | 22:20 |
EmilienM | no | 22:20 |
dansmith | we can go ahead and send that min_unit one though right? seems like a reasonable thing we can do for the moment, and it will self-heal if we change it later | 22:20 |
mriedem | not the same jobs? | 22:20 |
EmilienM | the experimental is not ovb IIRC | 22:20 |
bauzas | mriedem: I know that | 22:20 |
EmilienM | it's multinode, hence it doesn't test baremetal deployment | 22:20 |
mriedem | i'm fine with sending it in | 22:20 |
dansmith | actually, by the time we would want to change it we'll be scheduling on the custom class anyway | 22:20 |
bauzas | dansmith: yeah, I'm about to +W it anyway | 22:21 |
EmilienM | thanks for that ^ | 22:21 |
dansmith | I got it | 22:21 |
bauzas | heh | 22:21 |
EmilienM | I'll give you feedback as soon I I have one | 22:21 |
EmilienM | (as usual :)) | 22:21 |
bauzas | okay | 22:21 |
bauzas | then me disappears for the day | 22:21 |
EmilienM | bauzas: bonne nuit! | 22:22 |
*** jaypipes has quit IRC | 22:22 | |
mriedem | we should probably add a functional test in tree for the exact filters at some point | 22:24 |
mriedem | since the dsvm ironic job doesn't use those | 22:24 |
bauzas | mriedem: wait, what ? | 22:24 |
mriedem | bauzas: tripleo is using the exact filters right? | 22:25 |
bauzas | mriedem: nope | 22:25 |
*** kaisers_ has joined #openstack-nova | 22:25 | |
mriedem | oh it's the flavor size? | 22:25 |
mriedem | i guess i'm mixing those up | 22:25 |
bauzas | mriedem: sec, verifying an ironic job log | 22:25 |
mriedem | http://logs.openstack.org/98/448098/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/c0cc973/logs/etc/nova/nova.conf.txt.gz | 22:26 |
*** nic has quit IRC | 22:26 | |
mriedem | scheduler_default_filters = RetryFilter,AvailabilityZoneFilter,RamFilter,DiskFilter,ComputeFilter,ComputeCapabilitiesFilter,ImagePropertiesFilter,ServerGroupAntiAffinityFilter,ServerGroupAffinityFilter,SameHostFilter,DifferentHostFilter | 22:26 |
bauzas | http://logs.openstack.org/98/448098/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/c0cc973/logs/screen-n-sch.txt.gz#_2017-03-21_14_40_25_936 | 22:27 |
bauzas | mriedem: ^ | 22:27 |
bauzas | mriedem: you're getting confused by the opt | 22:27 |
bauzas | mriedem: if ironic, then it's not the right opt | 22:27 |
jroll | bauzas: but, filter_scheduler.use_baremetal_filters = False | 22:27 |
jroll | http://logs.openstack.org/98/448098/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/c0cc973/logs/screen-n-sch.txt.gz#_2017-03-21_14_40_25_941 | 22:27 |
mriedem | http://logs.openstack.org/22/447522/3/check/gate-tripleo-ci-centos-7-nonha-multinode-updates-nv/d7bf42b/logs/etc/nova/nova.conf.txt.gz | 22:27 |
jroll | mriedem is correct | 22:27 |
jroll | and this deserves a hearty "lolwtf" | 22:28 |
mriedem | enabled_filters=RetryFilter,TripleOCapabilitiesFilter,ComputeCapabilitiesFilter,AvailabilityZoneFilter,RamFilter,DiskFilter,ComputeFilter,ImagePropertiesFilter,ServerGroupAntiAffinityFilter,ServerGroupAffinityFilter | 22:28 |
bauzas | ooooh fuss http://logs.openstack.org/98/448098/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/c0cc973/logs/screen-n-sch.txt.gz#_2017-03-21_14_40_25_941 | 22:28 |
* bauzas facepalms | 22:28 | |
jroll | not that it would test anything, other than they run | 22:28 |
jroll | because all of our gate hosts are same size | 22:28 |
jroll | s/hosts/nodes/ | 22:29 |
mriedem | use_baremetal_filters=False is in the nova.conf for the tripleo job too | 22:29 |
bauzas | I have something in my pipe about working on functional tests for filtres | 22:29 |
jroll | ya | 22:29 |
mriedem | anyway, a regression functional test is needed here obviously | 22:29 |
bauzas | we could check thart | 22:29 |
bauzas | yeah | 22:29 |
*** dimtruck is now known as zz_dimtruck | 22:29 | |
*** kaisers_ has quit IRC | 22:30 | |
* bauzas sighes | 22:30 | |
bauzas | jroll: any reason why the ironic job isn't using the right opt values ? | 22:31 |
*** xyang1 has quit IRC | 22:31 | |
jroll | bauzas: idk, but it wouldn't make a difference | 22:31 |
jroll | bauzas: our "nodes" in the gate are all the same size | 22:31 |
jroll | so it doesn't test much, but I don't mind adding it | 22:31 |
bauzas | well | 22:31 |
bauzas | the main problem is that we tell our ops to opt-in that :) | 22:32 |
jroll | sure | 22:32 |
bauzas | if we don't use the same flags that the ones we ask for our operators, then... :p | 22:32 |
jroll | don't disagree we should add it | 22:32 |
jroll | but even so, I could make it a noop and it would still pass our jobs | 22:32 |
bauzas | doesn't devstack turn that flag on automatically ? | 22:33 |
bauzas | I mean for lib/ironic | 22:33 |
jroll | the baremetal filters? apparently not | 22:33 |
* bauzas reads https://docs.openstack.org/developer/ironic/dev/dev-quickstart.html | 22:34 | |
bauzas | I thought it was the case | 22:34 |
jroll | I thought so too | 22:35 |
jroll | but CI just proved us wrong :) | 22:35 |
bauzas | I only played a very few with devstack installing ironic | 22:35 |
bauzas | so I basically know the workflow but I thought it was done this way | 22:35 |
bauzas | mmmm, not the case in lib/ironic AFAICS | 22:37 |
jroll | bauzas: https://review.openstack.org/#/c/448303/ | 22:38 |
bauzas | jroll: tbh, can't find in the dev howto where to set that conf flag... | 22:40 |
bauzas | speaking of https://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack | 22:41 |
jroll | bauzas: it's in the install guide https://docs.openstack.org/project-install-guide/baremetal/draft/configure-integration.html#configure-compute-to-use-the-bare-metal-service | 22:41 |
bauzas | okay | 22:42 |
*** crushil has quit IRC | 22:42 | |
bauzas | anyway, time for calling it a day | 22:44 |
*** adrian_otto has quit IRC | 22:44 | |
jroll | indeed, night bauzas | 22:46 |
*** liangy has quit IRC | 22:48 | |
*** eharney has quit IRC | 22:54 | |
*** david-lyle has quit IRC | 22:57 | |
*** abalutoiu_ has joined #openstack-nova | 22:58 | |
*** _d34dh0r53_ has joined #openstack-nova | 23:00 | |
*** _d34dh0r53_ has quit IRC | 23:00 | |
*** Apoorva_ has joined #openstack-nova | 23:01 | |
*** abalutoiu has quit IRC | 23:03 | |
*** Apoorva has quit IRC | 23:03 | |
*** nic has joined #openstack-nova | 23:04 | |
*** _d34dh0r53_ has joined #openstack-nova | 23:04 | |
*** harlowja has quit IRC | 23:06 | |
*** _d34dh0r53_ has quit IRC | 23:07 | |
*** priteau_ has quit IRC | 23:15 | |
*** priteau has joined #openstack-nova | 23:15 | |
*** tbachman has quit IRC | 23:23 | |
*** tbachman has joined #openstack-nova | 23:24 | |
*** gfhellma has quit IRC | 23:26 | |
*** priteau has quit IRC | 23:34 | |
*** _d34dh0r53_ has joined #openstack-nova | 23:34 | |
*** jamielennox is now known as jamielennox|away | 23:35 | |
*** abalutoiu__ has joined #openstack-nova | 23:35 | |
*** gjayavelu has quit IRC | 23:37 | |
*** mlavalle has quit IRC | 23:38 | |
*** mtanino has quit IRC | 23:38 | |
*** abalutoiu_ has quit IRC | 23:38 | |
*** jamielennox|away is now known as jamielennox | 23:39 | |
*** vladikr has joined #openstack-nova | 23:40 | |
*** priteau has joined #openstack-nova | 23:41 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Remove the Allocation.create() method. https://review.openstack.org/416751 | 23:44 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add check for invalid inventory amounts https://review.openstack.org/428800 | 23:44 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add check for invalid allocation amounts https://review.openstack.org/416752 | 23:44 |
*** priteau has quit IRC | 23:46 | |
*** _d34dh0r53_ has quit IRC | 23:46 | |
*** _d34dh0r53_ has joined #openstack-nova | 23:47 | |
*** d34dh0r53 has quit IRC | 23:50 | |
*** bswartz has joined #openstack-nova | 23:52 | |
*** Guest68764 has quit IRC | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!