Tuesday, 2017-03-21

*** hongbin has quit IRC00:00
*** edmondsw has joined #openstack-nova00:03
*** ZZelle has quit IRC00:04
*** ijw has joined #openstack-nova00:05
*** edmondsw has quit IRC00:08
*** mtanino has joined #openstack-nova00:14
*** baoli has joined #openstack-nova00:22
*** kenperkins has quit IRC00:23
*** kaisers_ has joined #openstack-nova00:24
*** masber has joined #openstack-nova00:24
*** baoli has quit IRC00:26
*** armax has quit IRC00:26
*** amotoki has joined #openstack-nova00:26
*** kaisers_ has quit IRC00:28
*** dikonoor has joined #openstack-nova00:28
alex_xumriedem: for security-groups API, there is spec for it https://review.openstack.org/#/c/382414/2/specs/ocata/approved/api-secuirty-group-rework.rst00:34
*** catintheroof has joined #openstack-nova00:35
*** gcb_ has quit IRC00:35
*** zul has quit IRC00:36
alex_xumriedem: do we have job for live-migration with ceph in the ci?00:37
*** mtanino has quit IRC00:39
*** gyee_ has quit IRC00:40
*** zul has joined #openstack-nova00:41
*** gongysh has quit IRC00:42
*** Guest68764 has quit IRC00:43
*** adrian_otto has quit IRC00:50
*** Guest68764 has joined #openstack-nova00:50
*** Shunli has joined #openstack-nova00:52
*** zsli_ has joined #openstack-nova00:52
*** zsli_ has quit IRC00:52
*** Shunli has quit IRC00:52
*** Shunli has joined #openstack-nova00:52
*** diga has quit IRC00:56
*** gszasz has quit IRC00:56
*** kevinz has joined #openstack-nova00:58
*** browne has quit IRC01:01
*** dikonoor has quit IRC01:03
*** mriedem has quit IRC01:03
openstackgerritClaudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages  https://review.openstack.org/44750501:05
*** phuongnh has joined #openstack-nova01:05
*** krtaylor has joined #openstack-nova01:06
*** catintheroof has quit IRC01:08
*** gjayavelu has quit IRC01:10
*** mriedem has joined #openstack-nova01:12
*** yamamoto has joined #openstack-nova01:12
mriedemalex_xu: https://review.openstack.org/#/c/389582/01:13
*** jamielennox is now known as jamielennox|away01:16
*** iceyao has joined #openstack-nova01:16
*** jamielennox|away is now known as jamielennox01:28
*** Apoorva has quit IRC01:28
gmannalex_xu: johnthetubaguy  how about base class name to "create_documented_rule_default" in https://review.openstack.org/#/c/434842/1301:29
*** nic has quit IRC01:30
gmannno strong opinion, current one also fine to me01:30
*** Sukhdev_ has quit IRC01:31
*** iceyao has quit IRC01:33
*** ducnc has quit IRC01:35
*** dimtruck is now known as zz_dimtruck01:35
*** kaisers1 has joined #openstack-nova01:35
alex_xumriedem: thanks01:35
*** mriedem has left #openstack-nova01:36
*** mriedem has joined #openstack-nova01:36
alex_xugmann: i'm ok both. i thought in the future we only allowed to create default rule by that method, so i'm fine that name didn't expose too much detail01:36
*** rfolco has joined #openstack-nova01:36
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Spec for libvirt driver extension for Veritas HyperScale  https://review.openstack.org/43048801:37
*** kaisers has quit IRC01:37
*** claudiub has quit IRC01:37
*** ssurana has joined #openstack-nova01:37
*** iceyao has joined #openstack-nova01:38
gmannalex_xu: ok. yea having doc string should be enough though01:39
*** ssurana has quit IRC01:42
*** iceyao has quit IRC01:43
*** JDub has joined #openstack-nova01:48
*** gcb has joined #openstack-nova01:49
*** alexpilotti has quit IRC01:50
*** gongysh has joined #openstack-nova01:50
*** crushil has joined #openstack-nova01:51
openstackgerritMatt Riedemann proposed openstack/python-novaclient master: Drop deprecated aggregate-update positional args  https://review.openstack.org/44733201:51
*** browne has joined #openstack-nova01:53
*** JDub has quit IRC01:56
*** zhurong has joined #openstack-nova01:57
*** browne has quit IRC02:02
*** kaisers has joined #openstack-nova02:03
*** ijw has quit IRC02:06
*** kaisers has quit IRC02:07
*** jichen has joined #openstack-nova02:09
*** mriedem has quit IRC02:14
*** adrian_otto has joined #openstack-nova02:14
*** wangqun has joined #openstack-nova02:15
*** gouthamr has joined #openstack-nova02:16
*** kenperkins has joined #openstack-nova02:19
*** wally has quit IRC02:20
*** ducnc has joined #openstack-nova02:25
*** unicell1 has quit IRC02:31
*** zz_dimtruck is now known as dimtruck02:32
*** esberglu has joined #openstack-nova02:35
*** esberglu has quit IRC02:39
*** yamamoto has quit IRC02:41
*** hongbin has joined #openstack-nova02:47
openstackgerritSpencer Yu proposed openstack/python-novaclient master: Nova client should retry with Retry-After value  https://review.openstack.org/44776602:47
openstackgerritMaciej Szankin proposed openstack/nova-specs master: Add use-local-scheduler spec  https://review.openstack.org/43893602:47
*** yamamoto has joined #openstack-nova02:48
*** alexpilotti has joined #openstack-nova02:50
*** zsli_ has joined #openstack-nova02:52
*** Shunli has quit IRC02:54
*** masber has quit IRC02:54
*** gcb has quit IRC02:58
*** kaisers has joined #openstack-nova03:00
*** nicolasbock has quit IRC03:02
*** alexpilotti has quit IRC03:04
*** kaisers has quit IRC03:04
*** zhurong has quit IRC03:05
*** adrian_otto has quit IRC03:06
*** rfolco has quit IRC03:06
*** leseb_ has quit IRC03:11
*** leseb_ has joined #openstack-nova03:12
*** rfolco has joined #openstack-nova03:13
*** rfolco has quit IRC03:13
*** gcb has joined #openstack-nova03:14
*** bkopilov has quit IRC03:14
*** gcb has quit IRC03:14
*** masber has joined #openstack-nova03:15
*** gcb has joined #openstack-nova03:15
*** dimtruck is now known as zz_dimtruck03:21
*** zhurong has joined #openstack-nova03:22
*** namnh has joined #openstack-nova03:22
*** armax has joined #openstack-nova03:24
*** yamamoto has quit IRC03:25
*** guchihiro has joined #openstack-nova03:26
*** dave-mccowan has quit IRC03:29
*** guchihiro has quit IRC03:30
*** adrian_otto has joined #openstack-nova03:32
*** fragatin_ has joined #openstack-nova03:34
*** kenperkins has quit IRC03:38
*** fragatina has quit IRC03:38
*** fragatin_ has quit IRC03:39
*** fragatina has joined #openstack-nova03:40
*** DeathShow has joined #openstack-nova03:42
*** fragatin_ has joined #openstack-nova03:43
*** DeathShow has quit IRC03:43
*** links has joined #openstack-nova03:44
*** fragatina has quit IRC03:45
*** MarkMielke has joined #openstack-nova03:45
*** yamahata has quit IRC03:47
*** fragatin_ has quit IRC03:47
*** sree has joined #openstack-nova03:50
*** crushil has quit IRC03:50
*** namnh_ has joined #openstack-nova03:55
*** namnh has quit IRC03:58
*** tovin07_ has joined #openstack-nova04:00
*** hongbin has quit IRC04:02
*** fragatina has joined #openstack-nova04:03
*** guchihiro has joined #openstack-nova04:03
*** fragatina has quit IRC04:03
*** fragatina has joined #openstack-nova04:04
*** adrian_otto has quit IRC04:06
*** adrian_otto has joined #openstack-nova04:07
*** yamamoto has joined #openstack-nova04:09
*** jamielennox is now known as jamielennox|away04:12
*** zhurong has quit IRC04:12
*** esberglu has joined #openstack-nova04:24
*** psachin has joined #openstack-nova04:27
*** esberglu has quit IRC04:29
*** adrian_otto has quit IRC04:29
*** adisky_ has joined #openstack-nova04:32
*** bkopilov has joined #openstack-nova04:32
*** kaisers has joined #openstack-nova04:39
*** kaisers has quit IRC04:43
*** unicell has joined #openstack-nova04:48
*** udesale has joined #openstack-nova04:50
*** jaypipes has quit IRC04:57
*** jaypipes has joined #openstack-nova04:57
*** yamahata has joined #openstack-nova04:59
*** zhurong has joined #openstack-nova05:00
*** alexpilotti has joined #openstack-nova05:01
*** gouthamr has quit IRC05:03
*** udesale has quit IRC05:03
*** artom has quit IRC05:04
*** ayogi has joined #openstack-nova05:05
*** alexpilotti has quit IRC05:05
*** udesale has joined #openstack-nova05:06
*** udesale has quit IRC05:09
*** udesale has joined #openstack-nova05:09
*** ratailor has joined #openstack-nova05:13
*** lpetrut has joined #openstack-nova05:19
openstackgerritShunli Zhou proposed openstack/nova master: Remove mox from cells/test_cells_rpc_driver.py  https://review.openstack.org/44741205:26
*** prateek has joined #openstack-nova05:27
*** satyar has joined #openstack-nova05:29
*** Jack_Iv has joined #openstack-nova05:34
*** artom has joined #openstack-nova05:34
*** Jack_Iv has quit IRC05:36
*** mirrorbo1 is now known as mirrorbox05:37
*** mirrorbox has joined #openstack-nova05:37
*** zhurong has quit IRC05:40
*** rcernin has joined #openstack-nova05:43
*** abalutoiu has quit IRC05:44
*** gjayavelu has joined #openstack-nova05:50
*** markvoelker has quit IRC05:53
*** claudiub has joined #openstack-nova05:57
*** rcernin has quit IRC05:57
*** iceyao has joined #openstack-nova05:58
*** iceyao has quit IRC05:59
*** Jack_Iv has joined #openstack-nova06:00
*** alexpilotti has joined #openstack-nova06:02
*** NikhilS has joined #openstack-nova06:03
*** alexpilotti has quit IRC06:06
*** udesale has quit IRC06:06
*** udesale has joined #openstack-nova06:07
openstackgerritMaho Koshiya proposed openstack/nova master: Add confirm resized server functional negative tests  https://review.openstack.org/42107406:09
*** lpetrut has quit IRC06:13
*** esberglu has joined #openstack-nova06:13
*** unicell1 has joined #openstack-nova06:15
*** unicell has quit IRC06:15
*** esberglu has quit IRC06:17
openstackgerritlan proposed openstack/os-vif master: delete _LE  https://review.openstack.org/44786506:21
*** unicell1 has quit IRC06:22
*** unicell has joined #openstack-nova06:22
*** nkrinner_afk is now known as nkrinner06:28
*** lpetrut has joined #openstack-nova06:30
*** kornicameister has joined #openstack-nova06:31
*** jaosorior has joined #openstack-nova06:31
*** ekuris has joined #openstack-nova06:33
*** lpetrut has quit IRC06:34
*** kornicameister has quit IRC06:35
*** ssurana has joined #openstack-nova06:36
openstackgerritlan proposed openstack/os-vif master: Log messages are no longer being translated. so, removes all use of the _LE, _LI, and _LW translation markers to simplify logging and to avoid confusion with new contributions.  https://review.openstack.org/44786506:43
*** psachin_ has joined #openstack-nova06:44
*** psachin has quit IRC06:46
openstackgerritlan proposed openstack/os-vif master: 1.Log messages are no longer being translated. so, removes all use of the _LE, _LI, and _LW translation markers to simplify logging and to avoid confusion with new contributions.  https://review.openstack.org/44786506:53
*** sridharg has joined #openstack-nova06:53
*** markvoelker has joined #openstack-nova06:54
*** mnestratov has joined #openstack-nova06:56
*** fragatina has quit IRC06:56
*** markvoelker has quit IRC06:58
*** amotoki_ has joined #openstack-nova07:00
*** tuanluong has joined #openstack-nova07:00
*** david-lyle has quit IRC07:02
*** amotoki has quit IRC07:03
*** alexpilotti has joined #openstack-nova07:03
*** alexpilotti has quit IRC07:07
*** andreas_s has joined #openstack-nova07:08
*** unicell has quit IRC07:12
*** unicell has joined #openstack-nova07:12
openstackgerritlan proposed openstack/os-vif master: 1.Log messages are no longer being translated. so, removes all use of the _LE, _LI, and _LW translation markers to simplify logging and to avoid confusion with new contributions.  https://review.openstack.org/44786507:14
*** amotoki has joined #openstack-nova07:18
*** seife_ has joined #openstack-nova07:19
*** iceyao has joined #openstack-nova07:19
*** iceyao has quit IRC07:20
*** seife_ has quit IRC07:21
*** amotoki_ has quit IRC07:21
*** lpetrut has joined #openstack-nova07:27
*** tesseract has joined #openstack-nova07:35
openstackgerritSpencer Yu proposed openstack/python-novaclient master: Nova client should retry with Retry-After value  https://review.openstack.org/44776607:35
*** alexpilotti has joined #openstack-nova07:37
*** alexpilotti has quit IRC07:42
*** psachin_ has quit IRC07:47
*** cdent has joined #openstack-nova07:47
*** ralonsoh has joined #openstack-nova07:49
*** moshele has joined #openstack-nova07:50
*** markus_z has joined #openstack-nova07:52
*** ssurana has quit IRC07:53
openstackgerritSivasathurappan Radhakrishnan proposed openstack/nova master: Add live-migration-force-after-timeout  https://review.openstack.org/43021807:59
*** psachin_ has joined #openstack-nova07:59
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-nova08:00
*** CristinaPauna has quit IRC08:01
*** sree_ has joined #openstack-nova08:01
*** sree_ is now known as Guest2928408:01
*** esberglu has joined #openstack-nova08:02
*** alexpilotti has joined #openstack-nova08:02
*** lpetrut has quit IRC08:03
*** sree has quit IRC08:04
*** gibi has joined #openstack-nova08:05
*** venki has joined #openstack-nova08:05
*** CristinaPauna has joined #openstack-nova08:06
*** esberglu has quit IRC08:06
*** alexpilotti has quit IRC08:06
*** alexpilotti has joined #openstack-nova08:08
*** voelzmo has joined #openstack-nova08:10
*** pcaruana has joined #openstack-nova08:11
venkiHi Guys,08:12
venkiWhen i tried to run devstack using this config http://paste.openstack.org/show/603570/ .08:12
venkiI am getting the error :08:12
venki2017-03-21 08:07:27.650 | [ERROR] /opt/stack/ironic/devstack/lib/ironic:1412 Timed out waiting for Nova hypervisor-stats vcpus >= 308:12
venkiAnyone pls  help...08:12
*** alexpilotti has quit IRC08:13
*** snecklifter has quit IRC08:13
*** ltomasbo|away is now known as ltomasbo08:14
*** alexpilotti has joined #openstack-nova08:18
*** alexpilotti has quit IRC08:23
*** guchihiro has quit IRC08:24
bauzasgood morning Nova08:26
bauzasvenki: in general, you should look at your devstack logs08:27
bauzasvenki: in particular n-api.log for beginning08:27
*** alexpilotti has joined #openstack-nova08:27
bauzasvenki: AFAIK, Ironic waits until Nova finds 3 compute nodes08:27
bauzasthose 3 nodes are just 3 ironic nodes08:28
bauzasfake ones08:28
*** crusio has quit IRC08:30
*** abalutoiu has joined #openstack-nova08:30
-openstackstatus- NOTICE: Wiki is broken with database problems, we are working to resolve it08:32
*** alexpilotti has quit IRC08:32
*** ChanServ changes topic to "Wiki is broken with database problems, we are working to resolve it"08:32
*** zhurong has joined #openstack-nova08:35
*** gjayavelu has quit IRC08:36
*** lpetrut has joined #openstack-nova08:39
-openstackstatus- NOTICE: Wiki problems have been fixed, it's up and running08:40
*** ChanServ changes topic to "This channel is for Nova development. For support of Nova deployments, please use #openstack. Please see: https://wiki.openstack.org/wiki/Nova/Ocata_Release_Schedule"08:40
*** amoralej|off is now known as amoralej08:41
*** jpena|off is now known as jpena08:44
venki@bauzas : ok. but i can able to stack, when i use ironic_deploy_driver=pxe_ssh ....08:47
venki@bauzas : getting  issue when i use driver as agent_ipmitool or pxe_ipmitool08:47
bauzasvenki: looks like an ironic issue to me08:48
bauzaslemme explain why08:48
bauzasironic creates three fake ironc nodes using the driver you select08:48
bauzasthen, n-cpu runs the RT that calls the ironic driver for knowing how many ironic nodes are present08:49
bauzasoops RT = Nova ResourceTracker08:49
bauzasthen, Nova creates one hypervisor per ironic node found08:49
bauzaslast step, Ironic waits for nova to discover those nodes it created08:50
bauzasonce nova creates the according 3 hypervisors with the same UUID that match the ironic node UUID (behind a single n-cpu service), then ironic continues its deployment08:50
bauzasbut08:50
bauzasif Ironic can't create those 3 nodes using a specific driver, then Nova doesn't find those nodes, hence the error you see08:51
bauzaswhen you say the stack is created if using another ironic driver, that makes me think the real problem is that you don't end up having 3 ironic nodes, that's it08:52
venki@bauzas : awww okey .... nice explanation :):):)08:53
*** markvoelker has joined #openstack-nova08:55
*** jpena is now known as jpena|off08:57
*** markvoelker has quit IRC09:00
*** openstackgerrit has quit IRC09:03
johnthetubaguygmann: I wasn't understanding your comments on the policy stuff totally, are you still around?09:03
*** jpena|off is now known as jpena09:04
*** mvk has quit IRC09:17
*** VAhl has quit IRC09:24
lyarwoodjohnthetubaguy: morning, https://review.openstack.org/#/c/439520/ could use a review if you have any time today.09:35
lyarwoodjohnthetubaguy: it's now first up in the series given the -1 from mdbooth on landing the db changes before we know if we need the get_by_attachment_id lookups09:35
*** ociuhandu has joined #openstack-nova09:35
johnthetubaguylyarwood ah, yeah, I need to hit that again, will try get to that today09:35
lyarwoodjohnthetubaguy: cheers09:36
*** derekh has joined #openstack-nova09:36
*** karimb has joined #openstack-nova09:37
*** openstackgerrit has joined #openstack-nova09:42
openstackgerritJohn Garbutt proposed openstack/nova master: Refactor: remove _items() in nova/api/openstack/compute/attach_interfaces.py  https://review.openstack.org/44769809:42
tojuvonejohnthetubaguy, bauzas , jaypipes, oomichi, gibi Would like to get this forward if you have time: https://review.openstack.org/31051009:46
bauzastojuvone: either way, I need to make another pass on specs soon09:47
bauzastojuvone: but will do :)09:47
tojuvonebauzas, thanks :)09:47
openstackgerritSylvain Bauza proposed openstack/nova-specs master: Proposed block accepting AZ renames  https://review.openstack.org/44644609:49
bauzasjohnthetubaguy: you could be interested in ^09:49
bauzasI still need to write a backlog spec for commenting out all the AZ issues09:50
* johnthetubaguy shakes head at the number of specs to review09:50
*** esberglu has joined #openstack-nova09:51
bauzasheh :)09:51
bauzasjohnthetubaguy: you also have what? 8 open specs ? :p09:52
johnthetubaguyyeah, mostly not being written by me right know though09:52
gibitojuvone: It is on my queue to look at it again09:52
tojuvonegibi, thanks, tried to update with things we discussed09:53
*** esberglu has quit IRC09:56
*** markvoelker has joined #openstack-nova09:56
openstackgerritJohn Garbutt proposed openstack/nova master: Add description to policies in agents.py  https://review.openstack.org/44520809:56
*** udesale has quit IRC09:57
*** mvk has joined #openstack-nova09:58
*** tovin07_ has quit IRC09:58
openstackgerritJohn Garbutt proposed openstack/nova master: Add descripiton to policies in virtual_interfaces.py  https://review.openstack.org/44565209:59
*** gszasz has joined #openstack-nova10:00
*** markvoelker has quit IRC10:00
openstackgerritSylvain Bauza proposed openstack/nova-specs master: Proposed block accepting AZ renames  https://review.openstack.org/44644610:00
openstackgerritStephen Finucane proposed openstack/nova master: tox: Add 'profiler' target  https://review.openstack.org/43705510:03
openstackgerritClaudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages  https://review.openstack.org/44750510:05
*** zhurong has quit IRC10:05
*** jahsis has joined #openstack-nova10:08
*** nicolasbock has joined #openstack-nova10:08
*** namnh_ has quit IRC10:09
openstackgerritsahid proposed openstack/nova master: libvirt: return a CPU overhead if isolate emulator threads requested  https://review.openstack.org/38536410:11
openstackgerritsahid proposed openstack/nova master: numa: fit instance NUMA node with cpus reserved onto host NUMA node  https://review.openstack.org/40087510:11
openstackgerritsahid proposed openstack/nova master: virt: update overhead to take into account vCPUs  https://review.openstack.org/38502410:11
openstackgerritsahid proposed openstack/nova master: libvirt: make emulator threads to run on the reserved pCPU  https://review.openstack.org/40087810:11
openstackgerritsahid proposed openstack/nova master: numa: take into account cpus reserved  https://review.openstack.org/40087610:11
openstackgerritsahid proposed openstack/nova master: numa: update numa usage incording the cpu reserved  https://review.openstack.org/40087710:11
sfinucanjohnthetubaguy: Couldn't we just add the docstrings to https://review.openstack.org/#/c/434842/ and keep everyone happy?10:13
sfinucanI'm assuming the oslo.policy change/release will take a while to make it into nova10:14
johnthetubaguysfinucan: its a method thats about to be deleted, its already released yesterday10:14
sfinucanOh, it's been released already?10:14
sfinucanIn that case10:14
johnthetubaguyyeah10:14
*** jaosorior is now known as jaosorior_brb10:14
johnthetubaguyjust need the requirements bumps to flow through, then rework stuff to use the new method10:15
sfinucanGotcha. Does seem more sane to rework after the requirements bump, in that case?10:16
* sfinucan goes to find said requirements bump, if any10:16
*** amotoki has quit IRC10:17
johnthetubaguysfinucan: so that whole method will be deleted after the bump goes through10:21
*** udesale has joined #openstack-nova10:21
johnthetubaguysfinucan: I don't think the bump has been put up for review yet10:21
sfinucanjohnthetubaguy: Right, but all the calls to that function will have to be rewritten?10:22
sfinucanSo could we replace that change with a requirement.txt bump change?10:22
sfinucan...and turn a two step process to one10:22
johnthetubaguysfinucan: yes, they will all have to get re-writen10:22
sfinucanjohnthetubaguy: Right. Any reason not to do that now?10:24
*** satyar has quit IRC10:24
*** zhurong has joined #openstack-nova10:24
sfinucanJust making sure we're not creating work for ourselves :)10:24
johnthetubaguysfinucan: it delays getting the harder reviews out of our queue10:24
johnthetubaguythe rename is a single simple patch really, once the requirements stuff is all lined up10:24
*** gcb has quit IRC10:26
*** venki has quit IRC10:28
*** gcb has joined #openstack-nova10:28
*** venki has joined #openstack-nova10:28
*** jamielennox|away is now known as jamielennox10:30
*** phuongnh has quit IRC10:31
*** yamahata has quit IRC10:32
*** jichen has quit IRC10:35
sfinucanjohnthetubaguy: OK, the method signatures are the same meaning the rename can be done en masse, as you say. +2/+W'd10:35
*** kevinz has quit IRC10:36
*** gcb has quit IRC10:37
*** kaisers1 has quit IRC10:38
johnthetubaguysfinucan: cool, thanks10:38
johnthetubaguysfinucan: operators been asking for better docs on this stuff for a few years now, glad to be making progress on it10:38
sfinucanjohnthetubaguy: Yup, similar idea behind centralize-config-options10:38
sfinucanOne question though - why aren't the 'discoverable' policies documented? https://review.openstack.org/#/c/447722/1/nova/policies/suspend_server.py10:39
johnthetubaguysfinucan: we are about to delete them all10:39
sfinucanOh, that part of this spec or some other initiative?10:40
sfinucan*is that10:40
johnthetubaguyits the follow on spec10:40
johnthetubaguynow all extensions are hard coded on by default, having policy to hide a few from the list seems pointless really10:40
sfinucanmakes sense10:42
*** mnestratov has quit IRC10:42
*** mnestratov has joined #openstack-nova10:43
openstackgerritStephen Finucane proposed openstack/nova master: Add description to policies in suspend_server.py  https://review.openstack.org/44772210:44
openstackgerritSylvain Bauza proposed openstack/nova master: WIP/DNM: Destroy the ReqSpec object when deleting the instance  https://review.openstack.org/39106010:44
openstackgerritStephen Finucane proposed openstack/nova master: Add description to policies in volumes.py  https://review.openstack.org/44563710:46
openstackgerritStephen Finucane proposed openstack/nova master: Add description to policies in volumes_attachments.py  https://review.openstack.org/44525210:50
*** moshele has quit IRC10:51
*** moshele has joined #openstack-nova10:52
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova master: Read NIC features in libvirt  https://review.openstack.org/44441510:52
*** kaisers has joined #openstack-nova10:53
*** udesale has quit IRC10:54
*** gcb has joined #openstack-nova10:55
*** faizy has joined #openstack-nova10:56
*** gcb has quit IRC10:57
*** gcb has joined #openstack-nova10:57
openstackgerritStephen Finucane proposed openstack/nova master: Add description to policies in attach_interfaces.py  https://review.openstack.org/44769610:58
openstackgerritLee Yarwood proposed openstack/nova master: compute: Detach volumes on _rebuild_default_impl failure  https://review.openstack.org/44210510:59
*** faizy has quit IRC10:59
*** faizy has joined #openstack-nova11:00
cdentalex_xu: can you do the same curl that you left in your comment, but with a -v so we can see the request headers too?11:00
cdentalex_xu: I'm pretty sure your request is somehow getting a content-type header11:02
*** udesale has joined #openstack-nova11:02
alex_xucdent: thanks, curl send a "Content-Type: application/x-www-form-urlencoded"11:04
alex_xuI got that with -v11:04
*** jamielennox is now known as jamielennox|away11:05
cdentalex_xu: strange, I would expect the result to be a 415 then11:05
*** iceyao has joined #openstack-nova11:06
*** gcb has quit IRC11:06
alex_xucdent: yea, I got a 41511:06
cdentoh, so which code did you remove that allowed the 200?11:07
*** venki has quit IRC11:08
*** venki has joined #openstack-nova11:08
*** smatzek has joined #openstack-nova11:09
alex_xucdent: sorry, I didn't get your quesion11:09
*** sdague__ is now known as sdague11:09
alex_xuI removed the check at here also https://review.openstack.org/#/c/447625/2/nova/api/openstack/placement/handler.py11:09
*** READ10 has quit IRC11:09
sdaguealex_xu / johnthetubaguy / sfinucan anyone want to hit this easy one - https://review.openstack.org/#/c/447466/ - the docs change is on top11:09
sfinucansdague: Sure11:10
alex_xusdague: checking11:10
*** iceyao has quit IRC11:10
cdentalex_xu: the reason, in that case, that you didn't get 500 error that the original bug fixed is because when you use -d with curl, it automatically sends a content-type header and the error that was being protected against was when there was no content-type header. do you think there's something wrong with the new patch?11:11
sfinucansdague: Two small indentation things. Otherwise TrivialFix11:11
*** jamielennox|away is now known as jamielennox11:12
*** mvk has quit IRC11:12
openstackgerritSean Dague proposed openstack/nova master: remove log translation from nova.api.metadata  https://review.openstack.org/44746611:16
openstackgerritSean Dague proposed openstack/nova master: update i18n guide for nova  https://review.openstack.org/44752811:16
openstackgerritStephen Finucane proposed openstack/nova master: Add description to policies in agents.py  https://review.openstack.org/44520811:16
openstackgerritStephen Finucane proposed openstack/nova master: Add description to policies in aggregates.py  https://review.openstack.org/44523011:17
openstackgerritAndrey Volkov proposed openstack/nova master: PoC: Pick PCI devices with unique tags  https://review.openstack.org/44800811:17
*** manasm has joined #openstack-nova11:17
*** udesale has quit IRC11:18
*** udesale has joined #openstack-nova11:18
alex_xusfinucan: nothing i found from me, you can +w directly as you mention it is trivialfix11:19
*** gcb has joined #openstack-nova11:20
sfinucanalex_xu, sdague: Sure. Done.11:20
alex_xucdent: i didn't finish the review yet, just want to figure why those code are there first11:20
Dinesh_Bhorsfinucan: Hi, I just rebased the patch: https://review.openstack.org/#/c/445782/ could you please take a look at it?11:20
* alex_xu has to move the car first, the car is still in temporary parking area, back soon11:22
*** faizy_ has joined #openstack-nova11:24
*** mvk has joined #openstack-nova11:25
*** faizy has quit IRC11:25
*** fengzhr has quit IRC11:26
EmilienMdansmith, jaypipes: good morning! here are the new logs with more debug: http://logs.openstack.org/22/447522/1/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/7563947/logs/undercloud/var/log/ (using https://review.openstack.org/#/c/447520/)11:26
*** moshele has quit IRC11:26
*** moshele has joined #openstack-nova11:29
*** moshele has quit IRC11:30
*** moshele has joined #openstack-nova11:31
*** moshele has quit IRC11:31
*** moshele has joined #openstack-nova11:32
*** fengzhr has joined #openstack-nova11:32
*** gongysh has quit IRC11:33
*** amotoki has joined #openstack-nova11:36
*** hshiina has joined #openstack-nova11:37
openstackgerritSean Dague proposed openstack/nova master: delete more i18n log markers  https://review.openstack.org/44801911:42
*** rmart04 has joined #openstack-nova11:45
openstackgerritShunli Zhou proposed openstack/nova master: Remove mox from unit/cells/test_cells_messaging.py  https://review.openstack.org/44802111:45
*** venki has quit IRC11:48
*** wangqun has quit IRC11:48
*** venki has joined #openstack-nova11:48
*** faizy_ has quit IRC11:48
*** rfolco has joined #openstack-nova11:49
*** lucasagomes is now known as lucas-brb11:50
*** manasm has quit IRC11:53
*** aysyd has joined #openstack-nova11:57
*** edmondsw has joined #openstack-nova12:00
*** tuanluong has quit IRC12:03
*** edmondsw has quit IRC12:05
*** liverpooler has quit IRC12:05
*** liverpooler has joined #openstack-nova12:05
*** iceyao has joined #openstack-nova12:06
*** bkopilov has quit IRC12:07
openstackgerritRadoslav Gerganov proposed openstack/nova master: VMware: add support for different firmwares  https://review.openstack.org/44803412:10
*** awaugama has quit IRC12:13
*** haplo37 has quit IRC12:15
alex_xucdent: just done the review, more comments on https://review.openstack.org/#/c/447625/12:19
cdentthanks alex_xu will look in a second12:20
alex_xucdent: thanks12:20
*** gcb has quit IRC12:20
*** gcb has joined #openstack-nova12:21
*** iceyao has quit IRC12:21
*** iceyao has joined #openstack-nova12:22
*** haplo37 has joined #openstack-nova12:24
*** iceyao has quit IRC12:25
*** edmondsw has joined #openstack-nova12:26
*** Guest29284 has quit IRC12:27
*** iceyao has joined #openstack-nova12:27
*** sree has joined #openstack-nova12:28
*** leseb_ has quit IRC12:28
*** venki has quit IRC12:28
jaypipesEmilienM: in meeting hell for 2.5 hours. will try to look into that ASAP.12:28
*** venki has joined #openstack-nova12:28
*** sree_ has joined #openstack-nova12:30
*** sree_ is now known as Guest7697812:30
*** Guest76978 has quit IRC12:31
*** leseb_ has joined #openstack-nova12:31
*** sree has quit IRC12:32
*** sree has joined #openstack-nova12:32
*** dave-mccowan has joined #openstack-nova12:37
*** sree has quit IRC12:37
*** manasm has joined #openstack-nova12:37
*** kylek3h has joined #openstack-nova12:37
*** alexpilotti has joined #openstack-nova12:37
*** jaosorior_brb is now known as jaosorior12:38
*** moshele has quit IRC12:38
*** zhurong has quit IRC12:39
*** moshele has joined #openstack-nova12:41
*** ayogi has quit IRC12:45
*** karimb has quit IRC12:46
*** markvoelker has joined #openstack-nova12:48
*** dave-mccowan has quit IRC12:49
jrollVCPU 'min_unit': 412:50
jrolland the flavor does not have 412:50
jrollthat would exclude that RP, right?12:51
*** ratailor has quit IRC12:51
*** efried has joined #openstack-nova12:52
cdentjroll: if flavor wants 2, it would not land on the rp with min_unit of 412:52
jrollnod12:52
jrolljoy!12:52
jrollso it seems we want to give baremetal resources a lower min_unit, but still create allocations for all of the resources on that baremetal machine12:53
jroll(to get the old behavior)12:53
*** READ10 has joined #openstack-nova12:54
* jroll can try to whip up a patch, assuming someone agrees12:54
cdentjroll: I thought you didn't want that kind of under subscription, but I guess that's not the case?12:56
*** mriedem has joined #openstack-nova12:56
*** kencjohnston_ has quit IRC12:56
jrollcdent: we've always left the user a choice, with the "exact" scheduler filters12:57
*** dave-mccowan has joined #openstack-nova12:57
jrollI believe flavors should match exactly, others (tripleo, yahoo, ?) don't want that12:57
jrollso I think the answer for now is undersubscribe, use the exact match filters as before if one wants the exact match, and then the resource class stuff will eliminate the discussion12:58
*** esberglu has joined #openstack-nova12:58
cdentok, then yeah, the current min_unit setting in jay's new code isn't going to allow that12:59
jrollmaking a note in the bug report, will write a patch shortly after13:01
*** gongysh has joined #openstack-nova13:02
*** gouthamr has joined #openstack-nova13:02
*** cleong has joined #openstack-nova13:04
*** eharney has joined #openstack-nova13:05
*** iceyao has quit IRC13:05
*** baoli has joined #openstack-nova13:06
*** baoli has quit IRC13:06
* jroll bbiab13:06
*** zsli_ has quit IRC13:06
openstackgerritSean Dague proposed openstack/nova master: remove i18n log markers from nova.api.*  https://review.openstack.org/44808213:07
*** gongysh has quit IRC13:07
cdentedleafe is an awkward test13:07
cdentwave something near him, and awkwardness is measured13:07
*** bela_vancsics has joined #openstack-nova13:08
edleafecdent: I'm not a test!13:08
*** baoli has joined #openstack-nova13:08
cdenthow do you know?13:08
*** baoli has quit IRC13:09
cdentmaybe you are but no one told you13:09
*** vks1 has joined #openstack-nova13:09
*** baoli has joined #openstack-nova13:09
edleafeSorry, that sounds too much like those late night "wow, man!" conversations from college13:09
cdentdood13:10
*** voelzmo has quit IRC13:10
cdentmaybe _everyone_ is a test (for different things)13:10
*** mdrabe has joined #openstack-nova13:11
edleafeand... and... maybe we're all tests in some giant alien CI... heavy13:11
cdentwave something near jaypipes get back a report on which normal form you got going on13:11
*** iceyao has joined #openstack-nova13:11
EmilienMmriedem: fyi, I posted a link before you connected: http://logs.openstack.org/22/447522/1/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/7563947/logs/undercloud/var/log/13:12
EmilienMmriedem: new logs with the debug patch13:12
EmilienMmriedem: (and good morning :-))13:12
jaypipescdent: third.13:12
*** tblakes has joined #openstack-nova13:12
*** gongysh has joined #openstack-nova13:12
*** fengzhr has quit IRC13:14
*** lucas-brb is now known as lucasagomes13:14
jrollmriedem: EmilienM: see my comment here: https://bugs.launchpad.net/nova/+bug/167423613:15
openstackLaunchpad bug 1674236 in tripleo "CI / promotion: Nova isn't aware of the nodes that were registered with Ironic" [Critical,Triaged]13:15
*** gongysh has quit IRC13:15
*** fengzhr has joined #openstack-nova13:15
EmilienMjroll: thanks, well explained13:17
*** amoralej is now known as amoralej|lunch13:20
edleafejaypipes: I was going to say 'ab'13:20
* cdent gives edleafe a cookie13:21
openstackgerritStephen Finucane proposed openstack/nova master: Refactor: remove _items() in nova/api/openstack/compute/attach_interfaces.py  https://review.openstack.org/44769813:22
openstackgerritStephen Finucane proposed openstack/nova master: Add description to policies in agents.py  https://review.openstack.org/44520813:22
sfinucansdague: Could you take a look at https://review.openstack.org/#/c/430909/ and successors when possible, please?13:24
*** karimb has joined #openstack-nova13:24
*** links has quit IRC13:24
sdaguesfinucan: why are you making a change like this - https://review.openstack.org/#/c/430717/6/nova/conf/netconf.py ?13:24
sfinucansdague: It makes the addition of deprecated lines easier for me13:25
*** jamesdenton has joined #openstack-nova13:25
sdaguewhy?13:25
sfinucanplus, there's precedent for making everything in '/conf' ultra-consistent13:25
*** venki has quit IRC13:25
sfinucanI can simply bulk copy-paste13:25
*** prateek has quit IRC13:25
*** venki has joined #openstack-nova13:25
*** voelzmo has joined #openstack-nova13:26
sfinucanbut the "making everything in /conf ultra-consistent" is big enough. I've enough of those done that the little differences between each start to get annoying, heh13:27
*** smatzek has quit IRC13:27
mriedemjroll: yeah good catch, _compute_node_to_inventory_dict in the old flow hardcodes min_unit to 113:27
bauzasEmilienM: mriedem: I'm around to help, could you please tell me the current situation ?13:27
*** crushil has joined #openstack-nova13:27
mriedembauzas: jroll is working on the change13:27
jrollbauzas: read bug 167423613:28
openstackbug 1674236 in tripleo "CI / promotion: Nova isn't aware of the nodes that were registered with Ironic" [Critical,Triaged] https://launchpad.net/bugs/167423613:28
sdaguesfinucan: honestly, that's kind of exactly the whitespace over eagerness that we stopped doing a couple of years ago. We made E12* non enforcing for a reason.13:28
sfinucanyup, I'd completely agree...outside of '/conf'13:29
sdagueno, anyway, we don't want different rules in different places13:29
sfinucanI want to enforce the "consistency is key" mindset in there, in the hopes that it will deliver consistency in the end result13:29
sfinucanwhich, for the most part, it has been doing13:29
sdaguewell, I disagree that over prescribed code indentation really impacts useful end user docs :)13:30
*** voelzmo has quit IRC13:30
sfinucanbut it does describe people's mindsets going in there13:31
*** faizy_ has joined #openstack-nova13:31
*** jpena is now known as jpena|lunch13:31
sfinucanAlso, I've done enough of work with that aspect of nova to surely justify the benefit of the doubt13:32
*** mnestratov|2 has joined #openstack-nova13:32
bauzasjroll: mriedem: okay, gaining context :)13:33
sdagueI fought really hard against the whitespace wars in the past of people being overly prescriptive, I'm not really interested in bringing that mindset back for any reason13:33
*** faizy__ has joined #openstack-nova13:33
*** liangy has joined #openstack-nova13:35
openstackgerritJim Rollenhagen proposed openstack/nova master: Ironic: hardcode min_unit for standard resources to 1  https://review.openstack.org/44809813:35
*** mnestratov has quit IRC13:36
jrollEmilienM: cdent: bauzas: this should definitely fix the bug, trying to figure out now if I need to change allocations code as well so we don't schedule two (undersubscribed) instances to one node13:36
*** mdrabe has quit IRC13:36
EmilienMjroll: would you recommend us to change something in tripleo also?13:36
*** faizy_ has quit IRC13:36
*** mdrabe has joined #openstack-nova13:37
jrollEmilienM: well, I believe flavors should always exactly match nodes, but tripleo not doing that is a "feature", so I'd leave it alone13:37
EmilienMok13:37
EmilienMjroll: thank you!13:37
jrollnp :)13:37
EmilienMjroll: I'm going to try this one13:37
jrollEmilienM: thanks13:38
*** adrian_otto has joined #openstack-nova13:40
EmilienMjroll: https://review.openstack.org/#/c/447522/ - I'll let you know how it foes13:40
EmilienMgoes*13:40
jrollthanks13:41
*** Szarka has joined #openstack-nova13:41
bauzasEmilienM: jroll: okay, beginning to review https://review.openstack.org/#/c/448098/ FWIW13:41
EmilienMbauzas: thx13:43
bauzasjroll: oh, excellent catch on https://review.openstack.org/#/c/448098/1/nova/virt/ironic/driver.py13:44
jrollbauzas: yeah, was fun13:44
bauzasI think it's a situation where the scheduler is still needed until we implement all the features per the placement engine13:44
jrollwe are going to have to change how we do allocations here though :(13:44
bauzasjroll: why so ? you're telling placement to accept returning RPs that have more resources13:45
bauzasjroll: ah I see13:45
jroll:P13:45
bauzasjroll: so you would create an allocation that would eat all the left resources ?13:45
jrollyeah, we don't want to leave free resources there13:45
bauzasyeah, I honestly thought it was already the case13:45
jrollbauzas: maybe. or hack instance.flavor to eat everything13:46
bauzasan ironic allocation is free-or-none13:46
cdentso does this mean we need yet more special casing?13:46
mriedemjroll: did you run functional tests?13:46
bauzasjroll: well, operators defined flavors that weren't really meaning this or that number of resource usage13:46
mriedemjroll: i think there is a functional RT test that will fail13:46
jrollbauzas: right, we have code that does this in our virt driver, but the RT decides we're wrong13:46
jrollmriedem: there probably is, I haven't looked at them13:47
jrollnor ran13:47
bauzasjroll: we could tho tell them to add an extra spec that would signal 'eat me all the cake'13:47
bauzasI mean a trait13:47
mriedemthat's not a trait13:47
bauzasa what then ?13:47
mriedemthat's like a config option13:47
jroll'indivisible' is a trait :P13:47
jrollcdent: yes, somewhere. unclear (to me) where13:48
mriedemi guess i need to read the traits spec on the definition13:48
bauzasVCPU=5&MEM_GB=1&eat_me_all_thecake ?13:48
jrollmriedem: I'm mostly joking :)13:48
*** diana_clarke has joined #openstack-nova13:48
bauzasjroll: that said I'm concerned we could merge https://review.openstack.org/#/c/448098/1/nova/virt/ironic/driver.py without modifying allocations that would allow to pick the same ironic node for two instances13:49
*** hoangcx has joined #openstack-nova13:49
jrollbauzas: I mean, I can WIP it, I just put it up for now so EmilienM could test and such13:49
bauzasjroll: I do wonder if fixing ironic allocations shouldn't be merged first13:49
bauzasjroll: well, it's a race13:50
bauzasjroll: so the CI could be happy tho13:50
jrollbauzas: let me be clear, I don't want this merged without fixing allocations as well13:50
bauzasa-ah ok, then I agree13:50
*** artom has quit IRC13:50
jrollbauzas: and if tripleo can boot at least one instance, it's progress13:50
jrollor rather proves that was the issue13:50
bauzasjroll: AFAIK, the Exact* filters are not default in config right?13:51
*** felipemonteiro has joined #openstack-nova13:51
bauzasjroll: speaking of the IronicHostManager config13:51
bauzasI can verify13:51
bauzasbut I'm pretty sure TripleO hasn't modified that13:51
*** faizy__ has quit IRC13:51
jrollbauzas: it is a default, I think, if CONF.filter_scheduler.use_baremetal_filters=true13:52
bauzasjroll: I know we don't have the same enabled filters if that conf opt is in use, yep13:52
bauzasjroll: I just don't remember if the Exact* filters are part of those13:52
jrollyeah, confirmed, it isn't default but is part of the baremetal set13:52
jrollconf/scheduler.py line 29813:53
*** amoralej|lunch is now known as amoralej13:53
bauzasjroll: so then the scheduler should get the exact same number of nodes with or without that fix you wrote13:54
*** eglynn has joined #openstack-nova13:54
bauzasoops13:54
bauzasthe scheduler should *return*13:54
bauzasbut lemme see the 3O config13:55
jrollbauzas: http://logs.openstack.org/22/447522/1/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/7563947/logs/etc/nova/nova.conf.txt.gz13:55
bauzasyup13:55
jrolluse_baremetal_filters=False13:55
bauzasEmilienM: is the above the undercloud nova.conf ?13:55
mriedembauzas: jroll's fix isn't any different from how it worked before get_inventory was added13:55
mriedemunless i'm missing something13:55
mriedemso if you're worried about an allocation bug, it's latent13:56
bauzasmriedem: jroll's fix tries to address the fact that operators could ask the scheduler to return hosts that have more space than asked13:56
jrollmriedem: hm, you might be right13:56
EmilienMbauzas: yes13:56
bauzasokay, so the problem is there13:57
bauzaslemme restate13:57
*** catintheroof has joined #openstack-nova13:57
mriedemjaypipes: in case you haven't seen yet, jroll found the cause of the bug with the get_inventory stuff13:57
bauzasIronic pre-jroll's fix is only accepting the default config (ie. having Exact* filters)13:57
jaypipesmriedem: sorry, meeting hell...13:57
jaypipesmriedem: what was the cause, jroll?13:58
*** adrian_otto has quit IRC13:58
mriedemmin_unit was equal to max_unit13:58
bauzasbut TripleO isn't using those specific filtrers13:58
mriedemplus bm filters13:58
jrolljaypipes: min_unit==max_unit, tripleo uses flavors smaller than the node13:58
EmilienMscheduler_use_baremetal_filters is set to False by default in puppet-nova, I believe it's the default in Nova, but let me check13:58
jrollmriedem: not related to baremetal filters13:58
jrollEmilienM: that's correct13:58
jaypipesjroll: ahhh.13:58
jaypipesjroll: good. we can blame edleafe then. :P13:59
bauzasso it hits the bug that jroll tries to fix, but which shouldn't be visible unless you modify the specific default values for the list of baremetal filters13:59
EmilienMright https://git.openstack.org/cgit/openstack/nova/tree/nova/conf/scheduler.py#n33313:59
*** smatzek has joined #openstack-nova13:59
*** ZZelle_ has quit IRC13:59
EmilienM(i'm unavailable the next hour, tripleo meeting)13:59
*** bkopilov has joined #openstack-nova13:59
*** mtanino has joined #openstack-nova13:59
tdurakovhi folks, live-migration meeting in a minute, on #openstack-meeting-313:59
*** ZZelle has joined #openstack-nova13:59
bauzasso, I would suggest at least for TripleO to set scheduler_use_baremetal_filters to True for the undercloud14:00
jrollbauzas: or don't enable baremetal filters at all14:00
*** ZZelle is now known as Guest9367214:00
jrollbauzas: well, AIUI, tripleo does this intentionally14:00
mriedemi didn't even know baremetal_scheduler_enabled_filters was a thing14:00
jrollbauzas: tripleo uses capabilities hacks to schedule whatever the hell it wants14:00
mriedemor scheduler_use_baremetal_filters14:00
bauzasjroll: well, if you don't enable those exact* filters, then you could end up picking a host that has free space14:01
jrollmriedem: yeah, it's a shortcut to make deployers lives easier, I know that's usually not a goal14:01
*** Guest93672 is now known as ZZelle__14:01
jrollbauzas: which is true before this change, as well14:01
jrollbauzas: before the get_inventory change, I mean14:01
bauzasjroll: having the placement returning those hosts wasn't a problem because the scheduler was only returning the right hosts if Exact* filters were present14:01
mriedemjroll: just seems odd we need config options to say do this for bm scheduling, when we already know if we're doing ironic b/c of the host_manager14:02
jrollbauzas: fundamentally I agree with you, but this is a change to tripleo's architecture :P14:02
bauzasmriedem: it's a hack14:02
openstackgerritBĆ©la Vancsics proposed openstack/nova master: Using max api version in notificationt sample test  https://review.openstack.org/44368614:02
edleafejaypipes: you can always blame me14:02
*** moshele has quit IRC14:02
bauzasa very long-lived hack14:02
bauzasI guess only a few of us were knowing that :/14:02
jrollmriedem: idk, tripleo and yahoo very much drive a "things don't need to be exact" use case :/14:02
*** voelzmo has joined #openstack-nova14:02
jrollI'm told many deployments of ironic manage the compute graveyard where every machine is a different spec14:03
jroll:|14:03
bauzasjroll: here is the thing, eithezr tripleo switches their conf, or we need to both merge your fix *and* consume all the space when allocating14:03
bauzasthe former should be quick14:03
bauzasthe latter could take a while14:03
jrollbauzas: slow down14:04
jrollbauzas: tripleo was not using exact filters before the get_inventory change14:04
*** ZZelle__ is now known as ZZelle_14:04
jrollbauzas: we also had broken allocations before that change14:05
jrollbauzas: so with this fix only, we assume they won't be broken (and I believe their flavor uses all of the RAM, which is why)14:05
jrollanyone else not using exact filters was already broken, and will continue to be broken14:05
bauzas*tripleo* won't be broken14:05
*** voelzmo has quit IRC14:06
bauzasbut people using ironic the normal way will be broken if we merge your fix without the allocation side14:06
*** awaugama has joined #openstack-nova14:06
jrollyes, the same way they were broken on ocata, newton, mitaka, etc14:06
*** voelzmo has joined #openstack-nova14:06
openstackgerritJim Rollenhagen proposed openstack/nova master: Ironic: hardcode min_unit for standard resources to 1  https://review.openstack.org/44809814:06
jroll^ with func test fixes14:06
bauzasjroll: they were broken in what sense ?14:07
bauzasthe fact that we were underperformant with scheduling, leading to races ?14:07
jrollbauzas: the same way. we weren't allocating all of the resources14:07
bauzaswait14:07
bauzaswe weren't allocating all the resources ? I'm surprised14:08
jrollwe were not. because people didn't want ironic hacks in there.14:08
jroll(AIUI, of course)14:08
jrolland when people complained, we said "don't be dumb, use the exact filters"14:08
bauzassec, verifying the RT code and the claims14:08
jrollplease do, you know that code better than I do14:08
jrollironic reports everything used in get_available_resource, but the RT corrects it based on instance.flavor14:09
*** manasm has quit IRC14:09
bauzasjroll:  self.driver.estimate_instance_overhead(instance)14:09
bauzasmmm, nevermind14:10
bauzasthat one is not what I thought14:10
*** bela_vancsics has quit IRC14:10
bauzaslooking at the limits now14:11
*** satyar has joined #openstack-nova14:12
*** bela_vancsics has joined #openstack-nova14:12
bauzasyeah bingo14:13
* jroll listens14:13
bauzasjroll: https://github.com/openstack/nova/blob/master/nova/scheduler/filters/exact_ram_filter.py#L38-L4114:13
bauzasjroll: which ends up in https://github.com/openstack/nova/blob/master/nova/compute/claims.py#L24714:15
bauzason the compute side14:15
*** sapcc-bot1 has quit IRC14:15
jrollbauzas: neat, but that means people not running exact filters were still broken before this change14:15
*** tpatzig_ has quit IRC14:15
jrollbauzas: and means people running exact filters are still not broken after this change14:15
bauzasjroll: so the filter returns a limit that is passed down to the conductor and then the compute which is used there https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L155-L15614:16
jrollmeaning, my change does not introduce more broken behavior, just gets us back to consistent with old behavior14:16
mriedemrfolco: congratulations you are the first pike bp implemented https://blueprints.launchpad.net/nova/+spec/delete-inventories-placement-api14:16
mriedemyou get a root beer flavored scratch and sniff sticker14:16
bauzasjroll: lemme consider the impact14:16
*** mlavalle has joined #openstack-nova14:16
mriedemjroll: that's what i said earlier right?14:16
mriedemyour patch makes get_inventory the same as it was working for everything before14:17
mriedemthe "consume all allocation" is a latent problem14:17
mriedemnot introduced by get_inventory14:17
bauzasmriedem: post-placement use yeah14:17
cdentmriedem: I am _so_ motivated now, now that I know there might be scratch and sniff stickers14:17
jrollmriedem: yes, I agree with you14:17
bauzasokay, jroll and mriedem, you're right14:18
edleaferfolco: w00t!14:18
jrollzomg, that never happens14:18
bauzaswe just leave placement returning more hosts14:18
*** Szarka has quit IRC14:18
bauzasthe allocation consumption problem is only there when you don't use the Exact14:19
bauzas Exact* filters14:19
bauzasokay, so...14:19
* bauzas reviewing again the bugfix14:19
*** zz_dimtruck is now known as dimtruck14:20
bauzasjroll: EmilienM: +2, but holding my +W https://review.openstack.org/#/c/448098/214:23
bauzasuntil we get more results, in particular with 3O job14:23
EmilienMbauzas: ack, thx14:23
jrollthanks bauzas14:25
bauzasjroll: nah, you thanks for tackling that14:25
jrollbauzas: welcome14:25
jrollI promised I'd help with placement stuff, yay I did a thing14:26
bauzasat least we discussed how scary was the IronicHostManager :)14:26
bauzasnow mriedem could just throw it under the bus too :p14:26
jrollthat's drilled into my head for years now14:26
bauzasFWIW, I'm even not convinced by HostState objects14:27
sdaguesfinucan: on https://review.openstack.org/#/c/430912 ... if we put an idempotent id in the commit message, can we put the full one in there? If it's full gerrit makes it a link, the partial isn't14:27
bauzasanyway, /me disappearing b/c paternal duties14:27
sfinucansdague: Weird. Partial commit refs _do_ work. I'll fix that now14:28
sdaguesfinucan: yeh, but not Idempotent ids14:28
sdagueI think it's gerrit being conservative14:28
sfinucansdague: It does in https://review.openstack.org/#/c/430911/5 though?14:28
*** sneti_ has joined #openstack-nova14:29
mriedemrpodolyaka: you've got to sort the projects.yaml file https://review.openstack.org/#/c/448115/114:29
sdaguesfinucan: only 7 in the unlinked one?14:29
sdagueit's still probably good form to do the whole thing though14:29
mriedemrpodolyaka: let me know when we get to the point of needing to setup a launchpad project for bug tracking14:30
alex_xucdent: what is your expect when no content-length and content-type, 400 or 415?14:30
sfinucansdague: Aye, it does work with 8 chars14:30
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Ignore 'allow_same_net_traffic' for port filters  https://review.openstack.org/43091214:31
openstackgerritStephen Finucane proposed openstack/nova master: conf: Deprecate 'allow_same_net_traffic'  https://review.openstack.org/43091314:31
openstackgerritStephen Finucane proposed openstack/nova master: conf: Final cleanups in conf/network  https://review.openstack.org/43102314:32
sfinucansdague: Thanks for reviewing those :)14:32
cdentalex_xu: 40014:32
cdent415 is only for when the value of content-type is not the one desired14:32
alex_xucdent: but the https://review.openstack.org/447625 will return 41514:33
rpodolyakamriedem: oops, will fix that now14:33
openstackgerritBĆ©la Vancsics proposed openstack/nova master: Transform instance.trigger_crash_dump notification  https://review.openstack.org/39622514:33
*** eharney has quit IRC14:33
rpodolyakamriedem: hmm, I already created one - https://bugs.launchpad.net/placement-osc-plugin . Was that too early?14:34
*** xinliang has quit IRC14:34
cdentalex_xu: sorry I misunderstood what you meant: I thought you mean no content-type and no content-length. For no content-length but with a content-type then 415 (assuming the content-type is wrong)14:34
alex_xucdent: yes, I mean no content-type and no content-length14:35
cdentalex_xu: okay, ideally that would be a 400, but I've allowed it to fall through to a 415 because we don't want to do either of the following:14:36
cdent* check for the presence of a body (before actually reading it)14:36
*** vishwanathj has joined #openstack-nova14:36
cdent* limit things based on which method, since GET could send a body14:36
mriedemrpodolyaka: less work for me14:36
rpodolyaka:)14:36
*** fengzhr has quit IRC14:36
mriedemmdbooth: on https://review.openstack.org/#/c/441989/ i noticed there was no unit test, which, whatever, but if having a method defined is required to actually have things work, what are your thoughts on using ABCs in the imagebackend code?14:37
cdentalex_xu: a thing to keep in mind is that is hard, without explicit intent, to not send a content-length header when you have a body14:37
mriedemso if a method is required, like get_model, then define it as an abstractmethod14:38
cdentalex_xu: we could change things back to check for the request method, but since we've had discussions about GET using bodies, I didn't want to build that in14:38
mriedemi guess Image is an ABC14:38
*** fengzhr has joined #openstack-nova14:39
mriedembut get_model() isn't marked as an abstractmethod? that seems wrong14:39
cdentalex_xu: we can change it like you suggest (all in the decorator) but that doesn't feel as robust to me14:39
mdboothmriedem: I vaguely recall considering that when I looked at it, but we don't use ABCs very consistently so I wasn't that bothered IIRC14:39
mriedemmdbooth: i'll push a change quick14:39
alex_xucdent: sorry, I didn't get what relationship with GET using bodies14:39
mriedemso when MyCoolImageEnterpriseBackend shows up, we don't have the same issue14:40
*** alexpilotti has quit IRC14:40
jrollEmilienM: I rechecked your test patch, btw14:40
EmilienMthx14:40
EmilienMI'm still in mtg14:40
jrollno worries, just a heads up :)14:41
alex_xuemm...actually, i didn't get why that two points related to my suggestion. I may miss something14:41
*** jpena|lunch is now known as jpena14:42
*** marst has quit IRC14:43
*** marst has joined #openstack-nova14:43
edleafecdent: (reading scrollback) So no content-type with no content is not OK?14:43
cdentalex_xu: there's two things going on in the patch: One is making sure that if there is no body (thus the content-length header is either 0 or not there) then a PUT or POST can work. Two is making sure that if there is a body (content-length header is present and has a value) then the content-type header is present, no matter what the request method is.14:43
cdentedleafe: ^14:44
*** NikhilS has quit IRC14:44
*** ociuhandu has quit IRC14:44
cdentItem number two should be true for every request and should lead to a 400 if not the case. Thus having it as part of a decorator is not ideal.14:45
cdent(unless it was part of the wsgify decorator, but that's essentially the same thing as where it is now)14:46
edleafecdent: I was reading alex_xu's comment at http://p.anticdent.org/1sVC and your reply14:46
cdentedleafe: if there is a body, and there is either no content-type or no content-length, that's a 40014:46
*** eharney has joined #openstack-nova14:47
cdentedleafe: but we only have the content-length header as a reasonable proxy for knowing if there is a body14:47
*** andreas_s has quit IRC14:47
openstackgerritSujitha proposed openstack/nova master: Change os-server-tags default policy  https://review.openstack.org/39642014:47
edleafecdent: a body with no content-length?14:47
* edleafe must be living in an ideal world14:47
*** marst has quit IRC14:48
cdentedleafe: a healthy client would never do that, but if, for example, you telnet to port 80 and write a PUT it's easy to do14:48
cdentalso, if chunked encoding is being used, all bets are off14:48
cdentbut we don't use that, so that's a relief14:48
*** david-lyle has joined #openstack-nova14:49
*** mdrabe has quit IRC14:50
cdentalex_xu, edleafe: does that help clear things up or just make it more muddy? sadly we can't protect against all cases of "telnet to port 80" but we can cover some.14:50
*** gszasz_ has joined #openstack-nova14:50
*** hongbin has joined #openstack-nova14:50
*** ratailor has joined #openstack-nova14:51
cdenton the other hand it is entirely possible I'm putting too much trust in the existing gabbi tests, but since they pass, I feel pretty okay14:51
alex_xuI think i get your point now14:51
*** ratailor has quit IRC14:53
*** gszasz has quit IRC14:53
*** psachin_ has quit IRC14:53
*** marst has joined #openstack-nova14:54
openstackgerritStephen Finucane proposed openstack/nova master: Add description to policies in assisted_volume_snapshots.py  https://review.openstack.org/44523814:55
*** tblakes has quit IRC14:55
openstackgerritStephen Finucane proposed openstack/nova master: Add description to policies in admin_password.py  https://review.openstack.org/44395714:55
edleafecdent: you mean there are other ways to use OpenStack other than telnet?14:55
*** belmoreira has joined #openstack-nova14:56
rfolcomriedem, edleafe: re: first pike bp implemented: nice! thanks to edleafe, cdent and jaypipes for great guidance :)14:56
cdentedleafe: only if you pass the awkward test14:56
cdent\o/ rfolco14:56
*** faizy has joined #openstack-nova14:57
*** armax has quit IRC14:57
*** artom has joined #openstack-nova14:57
*** bela_vancsics has quit IRC14:58
*** mdrabe has joined #openstack-nova14:58
alex_xuif we check the presence the body, that means we have to read the body first14:59
jaypipesrfolco: and now you can submit a patch that changes the scheduler/report client to use DELETE /r-p/{uuid}/inventories :)14:59
alex_xuthat is waste, that is the reason cdent didn't want to check that14:59
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: mark some Image backend methods as abstract  https://review.openstack.org/44814214:59
mriedemmdbooth: see how that suits you ^14:59
*** karimb has quit IRC15:00
cdentalex_xu: yes, besides being a waste, it also limits some of the options for future handling15:00
alex_xucdent: what options?15:00
mdboothmriedem: WFM15:00
rfolcojaypipes, noted15:00
jrollcdent: edleafe: I'd love to start on this spec today, if you want to give it a quick skim before I do: https://etherpad.openstack.org/p/nova-ironic-flavor-transition-plan15:00
cdenthandling streams15:01
cdentsorry phone15:01
edleafejroll: will get to it in a bit. Meeting Hell Morning and all...15:01
jrolldansmith: mriedem: looks like most of the placement crew is happy with this flavor extra specs, spec, when you have a few: https://review.openstack.org/#/c/446570/15:02
jrolledleafe: no rush15:02
*** dave-mccowan has quit IRC15:02
*** hoangcx has quit IRC15:04
*** venki has quit IRC15:05
*** venki has joined #openstack-nova15:06
openstackgerritStephen Finucane proposed openstack/nova master: Stop using mox stubs in nova/tests/unit/cells/fakes.py  https://review.openstack.org/34204315:07
alex_xucdent: +2 on the patch, thanks for explain all of that to me patiently15:08
*** david-lyle has quit IRC15:09
*** ociuhandu has joined #openstack-nova15:10
*** faizy has quit IRC15:10
*** faizy has joined #openstack-nova15:11
bauzasjroll: dansmith: FWIW, just reviewing https://review.openstack.org/#/c/446570/2/specs/pike/approved/custom-resource-classes-in-flavors.rst now15:12
*** hshiina has quit IRC15:12
*** karimb has joined #openstack-nova15:12
jrollbauzas: woohoo15:12
cdentalex_xu: thanks for asking so many questions and being so thourough. is great.15:13
*** claudiub|2 has joined #openstack-nova15:13
mriedemjroll: starred15:13
*** claudiub has quit IRC15:14
*** faizy_ has joined #openstack-nova15:14
*** david-lyle has joined #openstack-nova15:15
mriedemsdague: alex_xu: oomichi: i put this on the api subteam meeting agenda, but would be nice to get your feedback, or at least start thinking about this before then https://review.openstack.org/#/c/447149/1/specs/pike/approved/service-hyper-uuid-in-api.rst@14815:16
*** raghav has joined #openstack-nova15:16
*** baoli has quit IRC15:17
mriedemalex_xu: i know it's late for you so don't worry too much about it today15:17
*** faizy__ has joined #openstack-nova15:17
cdentjroll: I dunno, after telling you to change that 0 to a 1, I am _completely_ exhausted.15:17
mriedemjust lose a *little* bit of sleep :)15:17
*** faizy has quit IRC15:18
*** dane-fichter has joined #openstack-nova15:18
*** tbachman has quit IRC15:19
*** tblakes has joined #openstack-nova15:19
alex_xumriedem: got it, I will check it tomorrow morning15:19
*** faizy_ has quit IRC15:20
*** faizy__ has quit IRC15:21
*** karimb has quit IRC15:21
*** faizy__ has joined #openstack-nova15:21
*** dave-mccowan has joined #openstack-nova15:22
*** sapcc-bot has joined #openstack-nova15:22
*** dgonzalez_ has joined #openstack-nova15:23
*** databus23_ has joined #openstack-nova15:23
*** mkoderer_ has joined #openstack-nova15:23
*** carthaca_ has joined #openstack-nova15:23
*** faizy__ has quit IRC15:24
*** david_1 has joined #openstack-nova15:24
dane-fichterjohnthetubaguy: got a second to talk about the trusted flavors spec?15:24
*** raghav has quit IRC15:24
*** faizy__ has joined #openstack-nova15:24
*** carthaca_ has quit IRC15:24
*** carthaca_ has joined #openstack-nova15:25
*** dgonzalez_ has quit IRC15:25
*** databus23_ has quit IRC15:25
*** carthaca_ has quit IRC15:25
*** mkoderer_ has quit IRC15:25
*** david_1 has quit IRC15:26
*** faizy__ has quit IRC15:26
*** faizy__ has joined #openstack-nova15:27
*** ekuris has quit IRC15:27
*** jdurgin has joined #openstack-nova15:28
*** faizy__ has quit IRC15:29
*** faizy__ has joined #openstack-nova15:30
openstackgerritSujitha proposed openstack/nova master: Add description to policies in admin_actions.  https://review.openstack.org/44082915:31
bauzasjroll: made a comment on https://review.openstack.org/#/c/446570/215:31
bauzasjroll: not sure it could be a bug, but I would appreciate some brainstorm15:31
*** karimb has joined #openstack-nova15:32
*** tbachman has joined #openstack-nova15:33
*** hieulq_ has joined #openstack-nova15:33
openstackgerritSujitha proposed openstack/nova master: Add description to policies in admin_actions.  https://review.openstack.org/44082915:35
*** whenry has joined #openstack-nova15:36
*** whenry has quit IRC15:37
openstackgerritSujitha proposed openstack/nova master: Add description to policies in admin_password.py  https://review.openstack.org/44395715:37
*** suresh12 has joined #openstack-nova15:38
openstackgerritSujitha proposed openstack/nova master: Add description to policies in agents.py  https://review.openstack.org/44520815:38
*** adrian_otto has joined #openstack-nova15:39
*** annegentle has joined #openstack-nova15:39
openstackgerritSandeep Pawar proposed openstack/nova master: Libvirt volume driver for Veritas HyperScale  https://review.openstack.org/44395115:40
jrollbauzas: resize depends on migrate being available, right?15:40
jroll(which ironic can't do)15:40
bauzasjroll: nova resize ?15:40
jrollyes15:40
bauzasI dunno, but good point, lemme verify15:40
openstackgerritSujitha proposed openstack/nova master: Add description to policies in aggregates.py  https://review.openstack.org/44523015:41
jrollI'm looking, I see lots of migration code in it15:41
bauzasjroll: either way, this spec doesn't only target a specific virt driver15:41
bauzasso I'm supposing it can be possible15:41
bauzaseg. FPGA devices with libvirt15:41
jrollbauzas: your resize concerns are around the upgrade thing we do in the ironic driver, though15:41
bauzasalthough it would require libvirt to expose it15:41
jroll(afaict)15:42
bauzasjroll: well, basically I thought about resize because it's all about an existing instance taking an API flavor15:42
bauzashere, that spec is focusing on changing the instance nested flavors, not the API-faced flavors AFAICS15:42
*** awaugama_ has joined #openstack-nova15:42
bauzasso we could end up mixing both old and new world, which could be a problem15:43
bauzasjroll: tbc, my -1 is for signaling a potential problem15:43
jrollI still don't get it, sorry :/15:43
*** lpetrut has quit IRC15:43
jrollyeah I understand that much :)15:43
jrolljust trying to understand the concern15:43
bauzasjroll: first, lemme verify if resize is available for ironic15:43
jrollsure15:44
bauzasmmm, it is not15:44
bauzashttps://docs.openstack.org/developer/nova/support-matrix.html#operation_resize15:44
*** jahsis has quit IRC15:44
*** yamahata has joined #openstack-nova15:44
bauzasso perhaps it can be a nobrainer15:44
*** arne_r has joined #openstack-nova15:44
mriedemcfriesen: comments in https://review.openstack.org/#/c/265282/15:45
*** whenry has joined #openstack-nova15:45
mriedemcfriesen: i'm +2 otherwise15:45
*** udesale has quit IRC15:46
*** awaugama has quit IRC15:46
*** annegentle has quit IRC15:46
*** annegentle has joined #openstack-nova15:47
jrollbauzas: replied in gerrit15:47
*** manasm has joined #openstack-nova15:49
*** armax has joined #openstack-nova15:49
*** pbandark has joined #openstack-nova15:49
*** karimb has quit IRC15:52
*** adrian_otto has quit IRC15:52
*** karimb has joined #openstack-nova15:52
*** ratailor has joined #openstack-nova15:53
*** hamzy has quit IRC15:53
bauzasjroll: I'm still struggling to evaluate the impacty15:53
bauzasimpact*15:53
*** pbandark has quit IRC15:53
*** david-lyle has quit IRC15:54
*** ssurana has joined #openstack-nova15:55
jrollbauzas: that instance.flavor migration thing only impacts allocations, afaict15:55
mriedemcfriesen: nvm i'll just address the issues quick and approve15:55
*** nkrinner is now known as nkrinner_afk15:56
*** karimb has quit IRC15:58
bauzasjroll: just to make sure I understand correctly15:59
bauzasjroll: we migrate the existing instances in order to self-heal the allocations that would claim custom resource classes, right?15:59
*** abalutoiu has quit IRC16:00
*** ratailor has quit IRC16:00
*** david-lyle has joined #openstack-nova16:01
jrollbauzas: yep. we don't want a flavor to appear that suddenly can claim a node with an instance already on it16:01
jrollthough, thinking back to this morning16:01
*** adrian_otto has joined #openstack-nova16:01
jrollif we make a change that makes nova claim all resources for ironic nodes with an instance... we don't need this extra migration16:01
*** whenry has quit IRC16:02
*** suresh12 has quit IRC16:02
bauzasjroll: graaah, just entering a team meeting, need to defer my thinkins for that :(16:03
bauzasthinkings*16:03
jrollbauzas: it's fine, no worries16:03
* jroll has meetings all afternoon and other things to work on16:03
*** jamespage has joined #openstack-nova16:04
jamespagemriedem: hello16:05
jamespagemriedem: would you have time to chat about https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/166569816:05
openstackLaunchpad bug 1665698 in libvirt (Ubuntu Yakkety) "/etc/qemu-ifup not allowed by apparmor" [Medium,Triaged]16:05
mriedemjamespage: ok, but i have no context on that.16:06
jamespagemriedem: let me give you some :-)16:06
jamespagemriedem: ok so...16:06
jamespagemriedem: some history16:06
mriedemthis is the empty script path element thing?16:07
*** karimb has joined #openstack-nova16:07
mriedemi saw there was a revert proposed for that16:07
mriedemsgordon: ^16:07
jamespagemriedem: that's the one16:07
jamespagemriedem: the fix for bug 164952716:07
openstackbug 1649527 in OpenStack Compute (nova) newton "nova creates an invalid ethernet/bridge interface definition in virsh xml" [Medium,Fix committed] https://launchpad.net/bugs/1649527 - Assigned to Roman Podoliaka (rpodolyaka)16:07
*** rmart04 has quit IRC16:08
jamespageappears to have broken baseline compatibility for libvirt so for certain vif types, xenial libvirt + newton stable is broken.16:08
bauzasjroll: one other thinking while attending my meeting, if we rebuild an instance having a modified nested flavor, we could just put it to a Pike node then, right?16:08
openstackgerritMatt Riedemann proposed openstack/nova-specs master: add spec for instance flavor API  https://review.openstack.org/26528216:08
bauzasjroll: to make it clear, I'm not trying to punt your spec, just trying to think about all the possible move operations16:08
jrollbauzas: yeah, I know what you're doing, I'm not upset about it16:09
bauzas:)16:09
bauzasI'm just an overthinking person :(16:10
jrollbauzas: I would need to read rebuild code to answer that question, but I assume we use instance.flavor for that, which means the scheduling decision would be different. interesting.16:10
jrollbauzas: "pike node" means a node with a resource class set, yes?16:10
mriedemjamespage: ok it's confusing because of comments like this in the original bug report https://bugs.launchpad.net/nova/+bug/1649527/comments/1916:10
openstackLaunchpad bug 1649527 in OpenStack Compute (nova) newton "nova creates an invalid ethernet/bridge interface definition in virsh xml" [Medium,Fix committed] - Assigned to Roman Podoliaka (rpodolyaka)16:10
bauzasjroll: a node that supports that custom RC16:11
*** kaisers_ has joined #openstack-nova16:11
mriedemjamespage: also though libvirt 2.5.0 isn't base xenial16:11
mriedembase xenial libvirt is 1.3.1 right?16:11
jrollbauzas: right, yeah, it would be scheduled that way16:11
jamespagemriedem: nope - its 1.3.116:11
jamespagemriedem: that was a somewhat unhelpful comment16:11
jrollbauzas: I'm thinking if we can do the "allocate all resources" thing outside of instance.flavor, we don't need to do this instance.flavor migration16:11
jamespagemriedem: I found the bug history quite confusing as well16:11
bauzasjroll: yeah I tend to agree with you although there could be some corner cases16:12
mriedemjamespage: yeah they later clarified they were running in a container with debian so different versions :/16:13
*** amotoki has quit IRC16:13
bauzasjroll: I'm just afraid of us possibly needing to do like we made for Ocata and just having the scheduler calling placement about custom RCs only if all the nodes are pike16:13
mriedemjamespage: so i guess this didn't affect rhel 7.3 or centos because they are running with a newer libvirt which doesn't cause issues that 1.3.1 does16:13
mriedemjamespage: this isn't just newton right? i mean it would also be broken in ocata wouldn't it?16:14
mriedemi see the backport was merged to newton though https://review.openstack.org/#/c/425637/16:14
*** gfhellma has joined #openstack-nova16:14
mriedemand we didn't raise the minimum required libvirt in nova in ocata16:14
jrollbauzas: yeah, I see now, because we upgrade scheduler before compute, right?16:15
bauzasjroll: yup16:15
jrollbauzas: which means operators must wait until after the pike deploy to change their flavors. which isn't ideal but I think it's fine?16:16
bauzasjroll: hum no16:16
bauzasjroll: operators can modify their flavors in Ocata16:16
bauzasgiven it's extra specs, it's just meaningless until Pike, that's it16:16
jrollbauzas: pike scheduler + ocata compute means scheduling on new style flavors would be broken16:17
jrollbecause we won't be reading resource class16:17
*** sridharg has quit IRC16:17
bauzasjroll: yeah the worst case scenario would be all but computes upgraded to Pike, and n-cpus still on Ocata16:18
bauzasjroll: then, if flavors are upgraded, kaboom16:18
bauzasNoValidHosts16:18
mriedemjamespage: so if i'm understanding this correctly, between https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1665698/comments/50 and https://review.openstack.org/#/c/425637/1/releasenotes/notes/libvirt-script-with-empty-path-2b49caa68b05278d.yaml16:18
openstackLaunchpad bug 1665698 in libvirt (Ubuntu Yakkety) "/etc/qemu-ifup not allowed by apparmor" [Medium,Triaged]16:18
mriedemjamespage: we want script path to be '' if libvirt < 1.3.3, and None if libvirt >= 1.3.3 yes?16:18
jrollbauzas: right, which I guess is why I need reviews on this, too :) https://etherpad.openstack.org/p/nova-ironic-flavor-transition-plan16:18
bauzasoh, never heard of that yet ^16:19
jrollbauzas: read more scheduler meeting :P16:19
jrollbauzas: but yeah, I guess my spec kind of depends on this plan being solid16:19
bauzasjroll: heh, not my fault, but my kid's one16:19
jrollbauzas: we log for a reason!16:19
jrollI'm mostly kidding16:20
jamespagemriedem: correct16:20
bauzasargh, no good fake reason to provide, I'm doomed16:20
*** hieulq_ has quit IRC16:20
mriedemjamespage: ok, i'll tinker with seeing how easy a fix that is16:21
jamespagemriedem: thankyou much appreciated16:21
*** udesale has joined #openstack-nova16:21
*** karimb has quit IRC16:22
jrollbauzas: line 39-42 there is me walking through rebuild in my head, I think it's okay16:22
*** whenry has joined #openstack-nova16:24
*** gszasz_ has quit IRC16:25
*** voelzmo has quit IRC16:25
*** gszasz_ has joined #openstack-nova16:25
*** belmoreira has quit IRC16:25
*** nic has joined #openstack-nova16:26
*** sneti_ has quit IRC16:26
*** jdurgin has quit IRC16:27
sgordonmriedem, jamespage mmm yes16:27
sgordonmriedem, jamespage revert of what specifically?16:27
sgordonmriedem, jamespage libvirt has actually been fixed to handle the old xml more gracefully16:28
mriedemsgordon: https://review.openstack.org/#/c/447169/16:28
mriedemsgordon: yes but according to https://bugs.launchpad.net/nova/+bug/1665698/comments/50 that's in libvirt 3.116:28
openstackLaunchpad bug 1665698 in libvirt (Ubuntu Yakkety) "/etc/qemu-ifup not allowed by apparmor" [Medium,Triaged]16:28
jamespagesgordon: yeah we're all good on forward version compat I think16:28
mriedemwhich is lightyears from where we'll be testing against in the gate16:28
*** jaosorior has quit IRC16:29
jamespageits backwards compat with 1.3.1 in Ubuntu Xenial16:29
sgordonmriedem, yes so the distributor should backport it16:29
jamespagebackport what exactly?16:29
mriedemthe '' or None fix i guess16:29
mriedembut what about someone not using a distro package?16:29
jamespagenova has established min version compats16:29
sgordonjamespage, the libvirt fix16:29
mriedemor using not red hat or ubuntu distro package?16:29
mriedemlike suse16:29
mriedemgentoo, etc16:30
sgordonjamespage, yes but you obvs bumped the distro libvirt version at some point or you would not be hitting the issue16:30
mriedemanyway, let me see how hard the conditional version check is in the code before we talk about making packagers handle this :)16:30
sgordonjamespage, which is also why it only appeared on RHEL/CentOS 7.316:30
jamespagesgordon: the libvirt version in xenial has been 1.3.1 since 16.04 release last year16:30
mriedemubuntu has libvirt 1.3.1 in stock 16.0416:31
mriedemthat's what we test with in the gate16:31
mriedemwe just don't test with the same vif types that this hits16:31
sgordonjamespage, the problem was only introduced in libvirt 1.3.216:31
sgordonjamespage, so at some point it's been brought in via a backport16:31
*** CristinaPauna has quit IRC16:32
mriedemsgordon: why does the release note, that i think you wrote, say 1.3.3? https://review.openstack.org/#/c/411936/6/releasenotes/notes/libvirt-script-with-empty-path-2b49caa68b05278d.yaml16:33
jamespagebehaviour changed in 1.3.316:33
*** abalutoiu has joined #openstack-nova16:33
*** karimb has joined #openstack-nova16:34
*** arne_r has quit IRC16:34
johnthetubaguydane-fichter: would be good to catch up on those16:34
cfriesenmriedem: thanks for the updates and approval on the flavor API spec.  you got to them before I even checked. :)16:34
mriedemis there a way to see which tags are applied to a libvirt commit? i.e. https://libvirt.org/git/?p=libvirt.git;a=commit;h=9c17d665fdc5f0ab74500a14c30627014c11b2c016:35
*** fragatina has joined #openstack-nova16:35
mriedemnvm it's 1.3.316:36
mriedembecause 1.3.2 was https://libvirt.org/git/?p=libvirt.git;a=commit;h=dca504a1b977060b844393daedd0da4bdb21ee7616:36
cfriesenI don't see any tags applied to that commit.  were you wondering what branch it was in?16:37
mriedemno i sorted it out16:38
cfriesenI usually use gitk to figure out branches/versions/etc.16:38
cfriesenit shows "follows" and "preceeds" versions.16:38
*** vks1 has quit IRC16:39
mriedemnow to see if os-vif is doing any of this16:39
*** markus_z has quit IRC16:39
*** faizy__ has quit IRC16:40
*** gszasz has joined #openstack-nova16:40
mriedemdoesn't look like it, whew16:40
mriedemso this affects ivs_ethernet, iovisor, midonet, tap and vrouter16:41
mriedemsean-k-mooney: ^ we don't have os-vif support for those vif types yet right?16:41
*** gjayavelu has joined #openstack-nova16:41
mriedemdoesn't look like it16:42
*** gszasz_ has quit IRC16:42
*** manasm has quit IRC16:43
*** Apoorva has joined #openstack-nova16:43
*** Daviey_ is now known as Daviey16:49
*** bmace has quit IRC16:49
*** bmace has joined #openstack-nova16:49
*** crushil has quit IRC16:51
*** satyar has quit IRC16:51
sgordonmriedem, digging back through the commentary i think the right approach is the branch you suggest16:53
mriedemshould have a patch up shortly16:54
sgordonmriedem, a straight revert is just going to switch back to the other group of upset operators yelling about it because the are on libvirt >= 1.3.316:54
mriedemthis is going to be a bit of a mess in newton i suspect16:54
sgordonmriedem, yeapppp16:54
mriedemin ocata we have access to the libvirt version in the vif code16:54
mriedembut i don't think i have that access in newton16:54
mriedemso will have to poke around16:54
sgordonmriedem, the revert approach also removed the rel note but given the combinations involved here i still think we will want to add one16:54
sgordonmriedem, "if you see this behavior then do we have a deal for you..."16:55
*** jaosorior has joined #openstack-nova16:55
mriedembuy one get one half off bug sale?!16:55
* mriedem runs tests and makes sandwich16:55
*** udesale has quit IRC16:57
*** ociuhandu has quit IRC16:59
*** abalutoiu has quit IRC17:02
*** abalutoiu has joined #openstack-nova17:02
johnthetubaguy#success First few patches adding real docs for policy have now merged in Nova. A much improved sample file: https://docs.openstack.org/developer/nova/sample_policy.html17:08
openstackstatusjohnthetubaguy: Added success to Success page17:08
*** kaisers_ has quit IRC17:09
*** crushil has joined #openstack-nova17:10
*** ociuhandu has joined #openstack-nova17:10
*** claudiub|2 has quit IRC17:10
*** unicell has quit IRC17:10
*** baoli has joined #openstack-nova17:12
*** ociuhandu has quit IRC17:14
*** Qiming has quit IRC17:15
*** Nisha_Agarwal has joined #openstack-nova17:18
*** Qiming has joined #openstack-nova17:19
*** baoli has quit IRC17:19
*** artom has quit IRC17:19
*** artom has joined #openstack-nova17:19
openstackgerritJohn Garbutt proposed openstack/nova master: Remove unused policy rule in admin_actions.py  https://review.openstack.org/44761117:20
*** ltomasbo is now known as ltomasbo|away17:20
*** baoli has joined #openstack-nova17:24
*** ltomasbo|away is now known as ltomasbo17:25
*** ociuhandu has joined #openstack-nova17:25
*** awaugama has joined #openstack-nova17:26
mriedemsgordon: jamespage: actually the same fix i have should work on newton, we have the stuff i needed for the version check17:26
*** hamzy has joined #openstack-nova17:26
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: conditinally set script path for ethernet vif types  https://review.openstack.org/44820317:27
mriedemsgordon: jamespage: review/test of ^ would be appreciated17:27
*** fragatina has quit IRC17:28
sgordonmriedem, thanks i'll add sfinucan as my proxy with a brain here ;)17:28
*** awaugama_ has quit IRC17:28
* sgordon only plays someone with a clue on TV17:28
dane-fichterjohnthetubaguy: hey I'm back, had to step out for a meeting17:29
sfinucanI'm starting to get why sysadmins don't like upgrading package versions17:30
*** catintheroof has quit IRC17:30
*** catintheroof has joined #openstack-nova17:30
johnthetubaguydane-fichter: no worries17:30
dane-fichterjohnthetubaguy: did my comment answer questions you have?17:31
*** rfolco has quit IRC17:32
dane-fichterjohnthetubaguy: it seems like the drivers have to support trusted flavors based on how the download() method gets called17:32
johnthetubaguydane-fichter: well I think you could hide that using driver capabilities17:33
*** annegentle has quit IRC17:33
dane-fichterjohnthetubaguy: Can you explain a little more? where in the code does that happen?17:34
johnthetubaguydane-fichter: yeah, I will try find an example, one sec17:34
johnthetubaguydane-fichter: here is one example: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L173017:35
johnthetubaguydane-fichter: its not perfect, but its a pattern I think you could re-use, that makes things consistent17:35
*** artom has quit IRC17:35
dane-fichterjohnthetubaguy: so that seems useful to just prevent the wrong drivers from trying to boot a trusted flavor instance17:37
*** david-lyle_ has joined #openstack-nova17:37
dane-fichterjohnthetubaguy: but there's no real reason other than the semantics of download() that all drivers can't support this17:37
*** artom has joined #openstack-nova17:37
dane-fichterjohnthetubguy: seems like we should just modify download() to take the instance or flavor object as well17:38
johnthetubaguydane-fichter: oh, yes, agreed with you, well not all drivers use that download() method, the ones that do can support it17:38
*** david-lyle has quit IRC17:38
dane-fichterjohnthetubaguy: ohh was not aware of that17:38
*** lucasagomes is now known as lucas-afk17:38
sfinucansgordon: Done17:39
*** unicell has joined #openstack-nova17:39
dane-fichterjohnthetubaguy: so we could probably do both things here; use driver capabilities to prevent unsupported drivers from booting trusted flavors17:39
johnthetubaguydane-fichter: xenapi has its own in hypervisor route, to avoid a double hop, because nova-compute doesn't run somewhere with access to the hypervisor disk17:39
johnthetubaguydane-fichter: yeah, sounds like we are talking slightly cross purposes in there, agreed with with doing both things17:40
*** cdent has quit IRC17:40
*** yamahata has quit IRC17:40
johnthetubaguydane-fichter: honestly, lots of that detail we can leave till code review, its just a saw detail in the spec that didn't look quite right to me, if that makes sense17:40
*** sneti_ has joined #openstack-nova17:41
dane-fichterjohnthetubaguy: yeah. so maybe just tone down the detail in that implementation steps section?17:41
*** ltomasbo is now known as ltomasbo|away17:41
dane-fichterjohnthetubaguy: i'll definitely specify the driver capabilities wrinkle17:42
*** jdurgin has joined #openstack-nova17:42
johnthetubaguydane-fichter: yeah, I think we need to add how to deal with "strange" virt drivers, but yeah the method calls and where the code exactly lives probable best left till later17:42
* johnthetubaguy wonders about a spelling correction bot17:43
johnthetubaguys/probable/probably/17:43
dane-fichterjohnthetubaguy: yes, agreed. thanks john17:44
johnthetubaguydane-fichter: no worries17:45
*** lpetrut has joined #openstack-nova17:47
*** beagles is now known as beagles_lunch17:48
*** iceyao has quit IRC17:48
*** derekh has quit IRC17:50
*** crushil has quit IRC17:51
*** satyar has joined #openstack-nova17:52
*** ralonsoh has quit IRC17:52
*** crushil has joined #openstack-nova17:53
*** adreznec has quit IRC17:55
*** fragatina has joined #openstack-nova17:55
*** annegentle has joined #openstack-nova17:56
*** adreznec has joined #openstack-nova17:57
*** jaosorior has quit IRC17:57
*** mtanino has quit IRC17:58
*** sneti_ has quit IRC18:03
*** suresh12 has joined #openstack-nova18:03
*** markd_ has quit IRC18:04
*** Drankis has joined #openstack-nova18:05
*** artom_ has joined #openstack-nova18:06
*** karimb has quit IRC18:06
*** suresh12 has quit IRC18:07
*** sneti_ has joined #openstack-nova18:07
*** ircuser-1 has quit IRC18:07
*** xyang1 has joined #openstack-nova18:08
*** artom has quit IRC18:09
*** dtp has joined #openstack-nova18:10
*** jdurgin has quit IRC18:10
mriedemsfinucan: i've got to update that bug fix patch, missed a couple tests18:11
*** mtanino has joined #openstack-nova18:11
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: conditionally set script path for ethernet vif types  https://review.openstack.org/44820318:13
mriedemsfinucan: here we go ^18:13
*** ociuhandu has quit IRC18:14
*** artom__ has joined #openstack-nova18:14
*** artom_ has quit IRC18:17
openstackgerritSujitha proposed openstack/nova master: Add description to policies in cells.py  https://review.openstack.org/44822418:17
*** jdurgin has joined #openstack-nova18:18
*** mvk has quit IRC18:18
openstackgerritGĆ”bor Antal proposed openstack/nova master: Pre-add functional tests stub to notification testing  https://review.openstack.org/44822518:18
*** avolkov has quit IRC18:21
*** vladikr has quit IRC18:21
dane-fichtermriedem: got a second to discuss the cursive change?18:22
dane-fichtermriedem: this one https://review.openstack.org/#/c/351232/18:22
*** weshay_sick is now known as weshay_brb18:25
*** yamahata has joined #openstack-nova18:26
mriedemdane-fichter: yeah18:30
*** artom__ has quit IRC18:31
*** yamahata has quit IRC18:31
*** yamahata has joined #openstack-nova18:31
*** tesseract has quit IRC18:31
*** artom has joined #openstack-nova18:32
*** beagles_lunch is now known as beagles18:33
openstackgerritGĆ”bor Antal proposed openstack/nova master: Pre-add functional tests stub to notification testing  https://review.openstack.org/44822518:34
*** baoli has quit IRC18:35
*** baoli has joined #openstack-nova18:36
*** artom_ has joined #openstack-nova18:37
*** Sukhdev has joined #openstack-nova18:38
*** artom has quit IRC18:39
*** pcaruana has quit IRC18:39
*** jpena is now known as jpena|off18:39
*** Tahvok has left #openstack-nova18:40
*** weshay_brb is now known as weshay18:42
*** vladikr has joined #openstack-nova18:43
*** Jack_Iv has joined #openstack-nova18:44
mriedemsdague: do you have an opinion on how to handle these tests? https://review.openstack.org/#/c/351232/11/nova/tests/unit/objects/test_fields.py18:44
*** haplo37 has quit IRC18:44
*** dtp has quit IRC18:45
*** Jack_Iv has quit IRC18:46
*** david-lyle_ has quit IRC18:46
*** Jack_Iv has joined #openstack-nova18:46
*** Jack_Iv has quit IRC18:47
*** Jack_Iv has joined #openstack-nova18:47
*** armax has quit IRC18:49
*** haplo37 has joined #openstack-nova18:49
*** Jack_Iv_ has joined #openstack-nova18:51
*** mvk has joined #openstack-nova18:53
*** Jack_Iv_ has quit IRC18:55
*** Jack_Iv has quit IRC18:55
*** karimb has joined #openstack-nova18:56
*** alexpilotti has joined #openstack-nova18:57
*** jdurgin has quit IRC18:58
*** ociuhandu has joined #openstack-nova18:59
*** kfarr has joined #openstack-nova19:00
*** alexpilotti has quit IRC19:00
*** alexpilotti has joined #openstack-nova19:01
*** jdurgin has joined #openstack-nova19:02
*** annegentle has quit IRC19:02
*** READ10 has quit IRC19:03
*** kfarr has quit IRC19:05
openstackgerritEric Fried proposed openstack/nova master: PowerVM Driver: console  https://review.openstack.org/40940219:06
sdaguemriedem: I need a lot more context here19:08
*** dharinic is now known as dharinic|lunch19:09
*** kfarr has joined #openstack-nova19:09
mriedemsdague: the signature_utils stuff is now in a library19:09
mriedemused in nova and glance19:09
mriedemwe have versioned objects that use enum fields with values defined in that library now19:10
*** kaisers_ has joined #openstack-nova19:10
mriedemwe have tests in nova that check to make sure if you update the constants in signature_utils (now the library), we bump the enum lists in the versioned object,19:10
mriedemthat was all fine and dandy while it was all within nova,19:10
*** satyar has quit IRC19:10
mriedembut with the constants defined in a library now, it means if the library adds new constants, our unit tests will fail and requires a dance to get things working to use the library in upper-constraints19:11
sdagueok, so don't you want to invert the iteration?19:11
mriedemi left a comment in there about what i think the dance is,19:11
mriedemif we leave things as-is19:11
mriedemand get the constants from the library now19:11
sdagueso just test that the enum in Nova are all in in the signature utils lib ?19:11
mriedemother way around,19:11
mriedemthe test makes sure that the constants defined in the lib are reflected in our enums,19:12
mriedemwhich feed into ImageMetaProps19:12
sdaguemriedem: ok, I'm not sure why that's actually important to couple here19:12
mriedemso if a new constant is added and released, we can't use that version of the library in upper-constraints until nova makes a change, before g-r is bumped, which is a bit odd19:12
sdaguemriedem: yeh, so, that's fine19:12
mriedemi'm not sure it is either19:12
mriedemthat's just the way it was when it was all in tree19:13
*** bswartz has quit IRC19:13
sdaguethe whole purpose of decoupling to a library is not to have lock step coupling with projects19:13
mriedemi suppose to keep a reminder that if we support new hash methods and key types that our image meta properties object should also support those19:13
sdagueyep19:13
sdaguealso, it's not like new hash methods just spring forth all the time19:13
mriedemif the library adds new things now, and we don't keep our enums and versioned objects up to date, then i guess someone just has to do that when they actually want to use a new thing in the library19:14
sdaguethey take years to a decade to proof out19:14
mriedemyeah19:14
mriedemso i'm also ok with just dropping the nova tests i think19:14
sdagueso the fact that you add to the lib, then add to the lib consumers, seems fine19:14
*** kaisers_ has quit IRC19:15
mriedemok so pro-drop the tests and coupling19:15
mriedemthat works for me, i just didn't like thinking this through in a vacuum19:15
*** kfarr_ has joined #openstack-nova19:16
*** kfarr has quit IRC19:16
*** karimb has quit IRC19:16
*** lpetrut has quit IRC19:17
*** annegentle has joined #openstack-nova19:22
mriedemdane-fichter: ^ replied in the change too19:22
*** liangy has quit IRC19:24
*** vladikr has quit IRC19:24
*** sneti_ has quit IRC19:26
*** gyee has joined #openstack-nova19:26
*** kaisers_ has joined #openstack-nova19:27
*** rfolco has joined #openstack-nova19:29
dane-fichtermriedem: I see. Just read the discussion w sdague too. sounds good.19:30
*** mlavalle has quit IRC19:33
*** sneti_ has joined #openstack-nova19:34
*** Nisha_ has joined #openstack-nova19:35
*** Nisha_Agarwal has quit IRC19:38
*** cdent has joined #openstack-nova19:39
*** awaugama has quit IRC19:39
*** gjayavelu has quit IRC19:40
*** liangy has joined #openstack-nova19:41
*** amoralej is now known as amoralej|off19:44
*** tbachman has quit IRC19:44
*** tbachman has joined #openstack-nova19:45
mriedemgcb: can't we do this now? https://github.com/openstack/nova/blob/master/tox.ini#L7019:45
mriedemthe functional-py35 job is gating on nova19:46
mriedemi'm not sure how basepython would work with that though, or if you just omit it19:46
mriedemwe would also have to change the job defintions in project-config if we combined those two jobs19:46
*** dharinic|lunch is now known as dharinic19:46
*** dtp has joined #openstack-nova19:49
*** dane-fichter has quit IRC19:53
*** eglynn has quit IRC19:56
*** Nisha_ has quit IRC19:57
*** claudiub|2 has joined #openstack-nova19:59
*** esberglu has quit IRC20:00
*** lpetrut has joined #openstack-nova20:00
*** esberglu has joined #openstack-nova20:00
*** dave-mccowan has quit IRC20:02
*** armax has joined #openstack-nova20:02
*** artom__ has joined #openstack-nova20:04
*** esberglu has quit IRC20:05
openstackgerritSujitha proposed openstack/nova master: Add description to policies in cells_scheduler.py  https://review.openstack.org/44826020:05
*** artom_ has quit IRC20:07
openstackgerritMatt Riedemann proposed openstack/nova master: Tests: remove .testrepository/times.dbm in tox.ini (functional)  https://review.openstack.org/44826620:08
*** kfarr_ has quit IRC20:10
openstackgerritOpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements  https://review.openstack.org/44667420:10
*** karimb has joined #openstack-nova20:11
openstackgerritSujitha proposed openstack/nova master: Add description to policies in certificates.py  https://review.openstack.org/44826720:11
openstackgerritSujitha proposed openstack/nova master: Add description to policies in cells.py  https://review.openstack.org/44822420:13
*** mlavalle has joined #openstack-nova20:14
*** browne has joined #openstack-nova20:16
mriedemsdague: are you going to be submitting a forum session proposal for limits in keystone?20:17
*** priteau has joined #openstack-nova20:18
*** clenimar has joined #openstack-nova20:26
*** crushil has quit IRC20:27
openstackgerritSujitha proposed openstack/nova master: Add description to policies in cloudpipe.py  https://review.openstack.org/44827120:30
*** esberglu has joined #openstack-nova20:32
*** dave-mccowan has joined #openstack-nova20:32
*** smatzek has quit IRC20:33
sdaguemriedem: I suppose, I'm still a little confused on content for the forum20:33
mriedemyou and me both,20:33
mriedembut it sounds like we start submitting abstracts and then the TC and UC vote on them20:33
mriedemhttp://lists.openstack.org/pipermail/user-committee/2017-March/001856.html20:34
mriedemsessions are proposed here http://forumtopics.openstack.org/20:34
dansmithI'm totally confused20:35
dansmithI put some stuff in an etherpad which was originally requested20:35
mriedemi think the brainstorming etherpads were for project teams to agree on what to submit to http://forumtopics.openstack.org/20:35
mriedem"Starting today, our submission tool is open for you to submit abstracts for the most popular sessions that came out of your brainstorming. *Please note that the etherpads are not being pulled into the submission tool and discussion around which sessions to submit are encouraged.*"20:36
dansmithah okay20:36
dansmithconfusing20:36
mriedemso we'll have one for cells, one for placement and one for limits20:36
mriedemat least20:36
*** tbachman has quit IRC20:36
mriedem"We are looking for a good mix of project-specific, cross-project or strategic/whole-of-community discussions, and *sessions that emphasize collaboration between users and developers are most welcome!*"20:36
*** cleong has quit IRC20:36
dansmithmriedem: are you going to do those to avoid overlap or should I put one in there?20:36
mriedemi think those 3 fall into that category20:36
johnthetubaguyI think brainstorming turned into formal submission20:36
johnthetubaguybut I got confused too20:36
bauzasnot sure I understand how the Forum works, honestly20:36
mriedemha, it was so quiet in here for the last several hours20:37
mriedemyou were all just lurking20:37
bauzasAFAICU, there are some sessions for newcomers too20:37
mriedemdansmith: submit one for cells20:37
dansmithokay20:37
mriedembauzas: that's separate20:37
mriedembauzas: i think anyway20:37
mriedemdiablo_rojo is coordinating that20:37
bauzasokay20:37
mriedembut she's not on irc so idk for sure20:37
dansmithmriedem: and this is for user/op interaction, or review of the progress and planning for the rest of the cycle or what?20:37
*** gjayavelu has joined #openstack-nova20:38
mriedemEmilienM: do we need to submit to forumtopis.o.o for the newcomer sessions too?20:38
dansmithso wait, the TC votes on these?20:38
* bauzas is looking at https://wiki.openstack.org/wiki/Forum20:38
mriedem"After submissions close, a team of representatives from the User Committee, the Technical Committee, and Foundation staff will take the sessions proposed by the community and fill out the schedule."20:38
EmilienMmriedem: yes I think so20:38
dansmithweird20:38
mriedemdansmith: i think cells, placement and limits all fall into the criteria20:38
EmilienMdansmith: some folks will vote yes, and 2 folks from TC, me and Doug AFIK20:38
mriedemfor "project-specific, cross-project or strategic/whole-of-community discussions"20:39
* johnthetubaguy was having food, is now in TC meeting, but wondered20:39
mriedemcells is project-specific, placement is cross-project, and limits are whole-of-community20:39
*** leseb_ has quit IRC20:41
*** suresh12 has joined #openstack-nova20:42
*** leseb_ has joined #openstack-nova20:44
*** suresh12 has quit IRC20:46
*** suresh12 has joined #openstack-nova20:49
*** priteau_ has joined #openstack-nova20:55
*** felipemonteiro has quit IRC20:56
bauzasmriedem: do you see the nova bits of https://etherpad.openstack.org/p/BOS-Nova-brainstorming do you think it would rather fit in the "real" Forum or the newcomers side rooms ?20:58
bauzasI'm confused, I thought it was intended for the former20:59
*** priteau has quit IRC20:59
mriedemnova bits?21:01
mriedemthat's a nova-specific etherpad21:01
mriedemthere is nothing in there that's suitable for a newcomer probably21:01
bauzasI agree21:01
*** gszasz has quit IRC21:01
bauzasmriedem: IIUC, we would put our items into forumtopics.o.o so the TC/UC/Foundation folks would vote on those21:02
bauzasthat doesn't necessarly mean all the items we want to discuss will be accepted then21:02
bauzasand https://etherpad.openstack.org/p/BOS-TC-brainstorming is already having lots of proposed sessions21:03
*** kaisers_ has quit IRC21:03
openstackgerritVivek Agrawal proposed openstack/nova-specs master: Spec for libvirt driver extension for Veritas HyperScale  https://review.openstack.org/43048821:03
mriedembauzas: we have 3-4 sessions i think,21:03
mriedemplacement (all), cells (all), limits and johnthetubaguy's vm/bm thing21:04
*** kaisers_ has joined #openstack-nova21:04
*** karimb has quit IRC21:04
mriedemanything that doesn't get accepted is table talk for the dev cave21:04
mriedemat least that's my understanding21:04
bauzasyeah, that's what I understand21:04
mriedemnow having said that,21:04
mriedemdansmith and jaypipes have approved talks for cells and placement already,21:05
bauzasmy only concern is that I'm not sure we even have 3-4 slots21:05
mriedemthey aren't like design summit21:05
mriedemthey are presentations21:05
bauzasI know21:05
mriedemthe forum topics are normal fishbowl sessions like before i think21:05
mriedemget devs and ops people together and talk through things for the release21:05
bauzasyeah, it's fishbowls21:05
mriedemwhat do you mean about your concern that we don't have 3-4 slots?21:06
mriedemwe don't have 2 full days of back to back nova sessions anymore, no21:06
mriedemthat's the PTG now21:06
bauzasthe fact that we would not necessary have all the nova items be covered21:06
mriedemwhich is why devs don't get funded to go to the summit anymore21:06
*** abalutoiu has quit IRC21:06
mriedemi'm not following you, anything that doesn't have a dedicated session, gets discussed by whoever is there in the dev lounge, or whatever21:07
*** abalutoiu has joined #openstack-nova21:07
mriedemhttp://lists.openstack.org/pipermail/openstack-dev/2017-March/113459.html21:07
mriedem"3/ Free hacking/meetup space"21:07
mriedem^ is where the spill over stuff happens21:07
bauzasit's basically tables in a free room21:07
mriedemwith just devs21:07
mriedemyes21:07
mriedemnot scheduled21:07
mriedemi think the entire point of the forum is to get the devs out of the cave,21:08
mriedemand into gen pop21:08
bauzaseven if I wasn't expecting a lot of devs at the event, I was still thinking we could do some sprint there21:08
mriedemso there won't be as much time to just sit around and talk through technical things that are going on in the release,21:08
mriedemthere will be time for some of that, but not nearly as much as the old design summit21:08
mriedemjohnthetubaguy: sdague: ttx: ^ is this all your understanding as well?21:09
*** crushil has joined #openstack-nova21:09
*** aysyd has quit IRC21:09
bauzaswell, I guess my concern is rather about the possibility to have an intermediate f2f meeting with folks to discuss about priorities updates21:10
bauzasand possible tech discussions21:10
*** Apoorva has quit IRC21:10
bauzasbut yeah, I got the message that Forum is not intented for devs just working in their cave21:10
cdentoog like cave21:10
*** dimtruck is now known as zz_dimtruck21:10
*** Apoorva has joined #openstack-nova21:10
mriedembauzas: there will be that, when we're not in other sessions21:11
mriedemthe 'other' sessions that aren't just nova devs have to be fleshed out and scheduled first,21:11
mriedemthen with any free time, we do the priority talk stuff that we'd normally do at a midcycle21:11
mriedembut with like 1/3 of the people21:11
jaypipessean-k-mooney, alex_xu, cdent, edleafe, sfinucan, mriedem: https://review.openstack.org/#/c/44828221:17
cdentjaypipes: is that for the future or for The Futureā„¢?21:18
jaypipescdent: The FUTURE.21:18
* cdent falls over stunned21:18
*** sneti_ has quit IRC21:22
*** david-lyle has joined #openstack-nova21:23
*** kaisers_ has quit IRC21:24
cdentjaypipes: responded with a while hair21:30
cdentor even a wild hair21:31
*** zz_dimtruck is now known as dimtruck21:34
*** sree has joined #openstack-nova21:34
*** annegentle has quit IRC21:34
*** Drankis has quit IRC21:34
*** Jeffrey4l_ has quit IRC21:35
*** crushil has quit IRC21:36
*** annegentle has joined #openstack-nova21:37
*** alex_xu has quit IRC21:37
*** Yingxin has quit IRC21:37
*** ijw has joined #openstack-nova21:38
*** alex_xu has joined #openstack-nova21:38
*** sree has quit IRC21:38
*** ircuser-1 has joined #openstack-nova21:39
*** Yingxin has joined #openstack-nova21:39
*** adisky_ has quit IRC21:39
*** tbachman has joined #openstack-nova21:40
*** tbachman has quit IRC21:45
*** tblakes has quit IRC21:46
openstackgerritMatt Riedemann proposed openstack/nova master: Warn on usage of _LI/_LW/_LE/_LC  https://review.openstack.org/44829321:47
mriedemsdague: ^ is something worth doing? for the i18n marker stuff. your latest reply in that thread got me thinking about it.21:47
*** Jeffrey4l_ has joined #openstack-nova21:48
*** gouthamr has quit IRC21:48
dansmithomg are we really doing that?21:49
jrollmriedem: man, that's gonna blow up the logs21:49
jrolllol21:49
mriedemjust an idea fellas21:49
*** lpetrut has quit IRC21:49
jrollI haven't read sean's email to be fair21:49
dansmithwe can thank IBM for: 1. PowerVM driver (removed), 2. DB2 (removed), 3. Lazy log translations (removed)21:49
mriedemat first i just thought about doing _LW = _, etc21:49
mriedemdansmith: this is different from lazy translation21:50
dansmithfine, 3. whatever you call this21:50
jrollit has been ___ days since we removed a bad IBM idea21:50
mriedemthat's better21:50
dansmithjroll: lol21:50
mriedemyou can thank ibm for me21:51
mriedemright?!21:51
mriedem<321:51
dansmiththey don't take your calls anymore?21:51
jrollmeanwhile the ironic team has spent all day waffling on what to do with msg='foo'; log.error(msg); raise FooError(msg)21:51
*** marst has quit IRC21:51
mriedemdansmith: no, thank them the other way21:51
jrolldo we translate it? not? write extra code to only translate one? god forbid we interpolate twice21:51
dansmithjroll: punt a decision to forum21:51
jrolllol21:52
*** haplo37 has quit IRC21:52
dansmiththat's always the answer21:52
jrollthat might be productive, I think there will only be 3-4 ironic devs21:52
dansmithhah21:52
*** cdent has quit IRC21:56
*** karimb has joined #openstack-nova21:56
*** catintheroof has quit IRC21:57
*** catintheroof has joined #openstack-nova21:58
*** catintheroof has quit IRC21:58
*** ijw has quit IRC21:58
*** ijw has joined #openstack-nova21:59
*** jdurgin has quit IRC21:59
*** annegentle has quit IRC22:00
openstackgerritMatt Riedemann proposed openstack/nova master: Add release note for CVE-2017-7214  https://review.openstack.org/44829522:01
mriedemdansmith: want to take a gander at ^? if ok, i'm going to backport to all branches and prep for releases.22:01
*** haplo37 has joined #openstack-nova22:01
*** mdrabe has quit IRC22:04
mriedemjroll: btw, have you ever checked the py35 job run logs?22:08
mriedemif you're worried about deprecationg warnings...22:08
mriedem*deprecation22:08
*** ijw has quit IRC22:08
dansmithmriedem: not sure I saw a fix for that merge, but I assume it did?22:08
mriedemdansmith: totes22:09
*** tbachman has joined #openstack-nova22:09
mriedemdansmith: https://review.openstack.org/#/q/I1d217620e52d45595a3e0e49ed57b4ab33cd1688,n,z22:09
*** Qiming has quit IRC22:09
dansmithcool22:09
dansmithmriedem: fast approve?22:10
mriedemdansmith: sure22:10
mriedemi'm doing the stable backports for the reno now22:10
dansmithcool22:11
mriedembilly idol is telling me about how he doesn't have eyes in his face22:11
mriedemor something like that22:11
dansmithINXS is telling me about this One THing22:11
mriedemit's called a belt22:11
mriedemand a room to yourself22:11
mriedemtoo soon?22:11
dansmithum22:12
mriedemdude22:12
mriedemyou don't get the reference?22:12
*** Qiming has joined #openstack-nova22:12
dansmithwell, um...22:13
dansmithoh, heh22:14
mriedemthere you go22:14
mriedemgeez22:14
mriedemhere are the reno backports https://review.openstack.org/#/q/I1f5b772bff8fa2dc508c4bdd3dd1f32838594786,n,z22:14
*** baoli has quit IRC22:18
*** crushil has joined #openstack-nova22:18
bauzasmriedem: jroll: EmilienM: before going to bed, I was looking at https://review.openstack.org/#/c/448098/22:18
EmilienMbauzas: ok22:18
bauzasEmilienM: I can't find a Depends-On for this one22:18
EmilienMbauzas: yeah it's on the other way22:18
bauzasEmilienM: how can I make sure it helps TripleO ?22:19
EmilienMbecause Nova refused to run tripleo job, I had to propose a patch in tripleo to depends on this one22:19
*** browne has quit IRC22:19
mriedemhttps://review.openstack.org/#/c/44752222:19
EmilienMbauzas: https://review.openstack.org/#/c/447522/22:19
*** jamesdenton has quit IRC22:19
bauzashmpffff lots of red22:19
mriedemwhich is queued22:19
EmilienMbauzas: yes but unrelated22:19
mriedemthey are having timeouts in their jobs22:19
EmilienMyeah it seems like everything broke for us today22:20
EmilienMcentos repos are down 30% of time22:20
EmilienMetc etc22:20
mriedembauzas: we also have tripleo in the nova experimental queue if you just wanted to run it on the nova change itself22:20
EmilienMno22:20
dansmithwe can go ahead and send that min_unit one though right? seems like a reasonable thing we can do for the moment, and it will self-heal if we change it later22:20
mriedemnot the same jobs?22:20
EmilienMthe experimental is not ovb IIRC22:20
bauzasmriedem: I know that22:20
EmilienMit's multinode, hence it doesn't test baremetal deployment22:20
mriedemi'm fine with sending it in22:20
dansmithactually, by the time we would want to change it we'll be scheduling on the custom class anyway22:20
bauzasdansmith: yeah, I'm about to +W it anyway22:21
EmilienMthanks for that ^22:21
dansmithI got it22:21
bauzasheh22:21
EmilienMI'll give you feedback as soon I I have one22:21
EmilienM(as usual :))22:21
bauzasokay22:21
bauzasthen me disappears for the day22:21
EmilienMbauzas: bonne nuit!22:22
*** jaypipes has quit IRC22:22
mriedemwe should probably add a functional test in tree for the exact filters at some point22:24
mriedemsince the dsvm ironic job doesn't use those22:24
bauzasmriedem: wait, what ?22:24
mriedembauzas: tripleo is using the exact filters right?22:25
bauzasmriedem: nope22:25
*** kaisers_ has joined #openstack-nova22:25
mriedemoh it's the flavor size?22:25
mriedemi guess i'm mixing those up22:25
bauzasmriedem: sec, verifying an ironic job log22:25
mriedemhttp://logs.openstack.org/98/448098/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/c0cc973/logs/etc/nova/nova.conf.txt.gz22:26
*** nic has quit IRC22:26
mriedemscheduler_default_filters = RetryFilter,AvailabilityZoneFilter,RamFilter,DiskFilter,ComputeFilter,ComputeCapabilitiesFilter,ImagePropertiesFilter,ServerGroupAntiAffinityFilter,ServerGroupAffinityFilter,SameHostFilter,DifferentHostFilter22:26
bauzashttp://logs.openstack.org/98/448098/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/c0cc973/logs/screen-n-sch.txt.gz#_2017-03-21_14_40_25_93622:27
bauzasmriedem: ^22:27
bauzasmriedem: you're getting confused by the opt22:27
bauzasmriedem: if ironic, then it's not the right opt22:27
jrollbauzas: but, filter_scheduler.use_baremetal_filters = False22:27
jrollhttp://logs.openstack.org/98/448098/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/c0cc973/logs/screen-n-sch.txt.gz#_2017-03-21_14_40_25_94122:27
mriedemhttp://logs.openstack.org/22/447522/3/check/gate-tripleo-ci-centos-7-nonha-multinode-updates-nv/d7bf42b/logs/etc/nova/nova.conf.txt.gz22:27
jrollmriedem is correct22:27
jrolland this deserves a hearty "lolwtf"22:28
mriedemenabled_filters=RetryFilter,TripleOCapabilitiesFilter,ComputeCapabilitiesFilter,AvailabilityZoneFilter,RamFilter,DiskFilter,ComputeFilter,ImagePropertiesFilter,ServerGroupAntiAffinityFilter,ServerGroupAffinityFilter22:28
bauzasooooh fuss http://logs.openstack.org/98/448098/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/c0cc973/logs/screen-n-sch.txt.gz#_2017-03-21_14_40_25_94122:28
* bauzas facepalms22:28
jrollnot that it would test anything, other than they run22:28
jrollbecause all of our gate hosts are same size22:28
jrolls/hosts/nodes/22:29
mriedemuse_baremetal_filters=False is in the nova.conf for the tripleo job too22:29
bauzasI have something in my pipe about working on functional tests for filtres22:29
jrollya22:29
mriedemanyway, a regression functional test is needed here obviously22:29
bauzaswe could check thart22:29
bauzasyeah22:29
*** dimtruck is now known as zz_dimtruck22:29
*** kaisers_ has quit IRC22:30
* bauzas sighes22:30
bauzasjroll: any reason why the ironic job isn't using the right opt values ?22:31
*** xyang1 has quit IRC22:31
jrollbauzas: idk, but it wouldn't make a difference22:31
jrollbauzas: our "nodes" in the gate are all the same size22:31
jrollso it doesn't test much, but I don't mind adding it22:31
bauzaswell22:31
bauzasthe main problem is that we tell our ops to opt-in that :)22:32
jrollsure22:32
bauzasif we don't use the same flags that the ones we ask for our operators, then... :p22:32
jrolldon't disagree we should add it22:32
jrollbut even so, I could make it a noop and it would still pass our jobs22:32
bauzasdoesn't devstack turn that flag on automatically ?22:33
bauzasI mean for lib/ironic22:33
jrollthe baremetal filters? apparently not22:33
* bauzas reads https://docs.openstack.org/developer/ironic/dev/dev-quickstart.html22:34
bauzasI thought it was the case22:34
jrollI thought so too22:35
jrollbut CI just proved us wrong :)22:35
bauzasI only played a very few with devstack installing ironic22:35
bauzasso I basically know the workflow but I thought it was done this way22:35
bauzasmmmm, not the case in lib/ironic AFAICS22:37
jrollbauzas: https://review.openstack.org/#/c/448303/22:38
bauzasjroll: tbh, can't find in the dev howto where to set that conf flag...22:40
bauzasspeaking of https://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack22:41
jrollbauzas: it's in the install guide https://docs.openstack.org/project-install-guide/baremetal/draft/configure-integration.html#configure-compute-to-use-the-bare-metal-service22:41
bauzasokay22:42
*** crushil has quit IRC22:42
bauzasanyway, time for calling it a day22:44
*** adrian_otto has quit IRC22:44
jrollindeed, night bauzas22:46
*** liangy has quit IRC22:48
*** eharney has quit IRC22:54
*** david-lyle has quit IRC22:57
*** abalutoiu_ has joined #openstack-nova22:58
*** _d34dh0r53_ has joined #openstack-nova23:00
*** _d34dh0r53_ has quit IRC23:00
*** Apoorva_ has joined #openstack-nova23:01
*** abalutoiu has quit IRC23:03
*** Apoorva has quit IRC23:03
*** nic has joined #openstack-nova23:04
*** _d34dh0r53_ has joined #openstack-nova23:04
*** harlowja has quit IRC23:06
*** _d34dh0r53_ has quit IRC23:07
*** priteau_ has quit IRC23:15
*** priteau has joined #openstack-nova23:15
*** tbachman has quit IRC23:23
*** tbachman has joined #openstack-nova23:24
*** gfhellma has quit IRC23:26
*** priteau has quit IRC23:34
*** _d34dh0r53_ has joined #openstack-nova23:34
*** jamielennox is now known as jamielennox|away23:35
*** abalutoiu__ has joined #openstack-nova23:35
*** gjayavelu has quit IRC23:37
*** mlavalle has quit IRC23:38
*** mtanino has quit IRC23:38
*** abalutoiu_ has quit IRC23:38
*** jamielennox|away is now known as jamielennox23:39
*** vladikr has joined #openstack-nova23:40
*** priteau has joined #openstack-nova23:41
openstackgerritDan Smith proposed openstack/nova master: Remove the Allocation.create() method.  https://review.openstack.org/41675123:44
openstackgerritDan Smith proposed openstack/nova master: Add check for invalid inventory amounts  https://review.openstack.org/42880023:44
openstackgerritDan Smith proposed openstack/nova master: Add check for invalid allocation amounts  https://review.openstack.org/41675223:44
*** priteau has quit IRC23:46
*** _d34dh0r53_ has quit IRC23:46
*** _d34dh0r53_ has joined #openstack-nova23:47
*** d34dh0r53 has quit IRC23:50
*** bswartz has joined #openstack-nova23:52
*** Guest68764 has quit IRC23:55

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!