*** baoli has joined #openstack-nova | 00:01 | |
*** suresh12 has joined #openstack-nova | 00:04 | |
*** suresh12 has quit IRC | 00:11 | |
*** jianghuaw has quit IRC | 00:13 | |
*** adrian_otto has quit IRC | 00:16 | |
*** baoli has quit IRC | 00:17 | |
*** baoli has joined #openstack-nova | 00:17 | |
*** ZZelle has quit IRC | 00:19 | |
*** dtp has quit IRC | 00:24 | |
*** kenperkins has quit IRC | 00:28 | |
*** dave-mccowan has quit IRC | 00:29 | |
*** armax has joined #openstack-nova | 00:30 | |
*** suresh12 has joined #openstack-nova | 00:35 | |
*** suresh12 has quit IRC | 00:35 | |
*** suresh12 has joined #openstack-nova | 00:35 | |
*** armax has quit IRC | 00:38 | |
*** vishwanathj has joined #openstack-nova | 00:39 | |
*** baoli has quit IRC | 00:44 | |
*** tobasco has quit IRC | 00:44 | |
*** Shunli has joined #openstack-nova | 00:44 | |
*** vishwanathj has quit IRC | 00:44 | |
*** tobasco has joined #openstack-nova | 00:44 | |
*** baoli has joined #openstack-nova | 00:45 | |
*** ssurana has quit IRC | 00:46 | |
*** ssurana has joined #openstack-nova | 00:46 | |
*** dave-mccowan has joined #openstack-nova | 00:48 | |
*** baoli has quit IRC | 00:49 | |
*** ssurana has quit IRC | 00:51 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Regression test for local delete with an attached volume https://review.openstack.org/449334 | 00:54 |
---|---|---|
*** dave-mcc_ has joined #openstack-nova | 00:55 | |
*** phuongnh has joined #openstack-nova | 00:55 | |
*** jichen has joined #openstack-nova | 00:56 | |
*** dave-mccowan has quit IRC | 00:57 | |
*** tovin07 has joined #openstack-nova | 00:58 | |
*** winston-2 has quit IRC | 00:59 | |
*** armax has joined #openstack-nova | 01:02 | |
*** dave-mccowan has joined #openstack-nova | 01:09 | |
*** dave-mcc_ has quit IRC | 01:11 | |
*** baoli has joined #openstack-nova | 01:11 | |
*** baoli has quit IRC | 01:15 | |
openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Re-propose nested resource providers spec https://review.openstack.org/449381 | 01:17 |
mriedem | jaypipes: ^ | 01:18 |
*** kevinz has joined #openstack-nova | 01:18 | |
*** armax has quit IRC | 01:22 | |
*** wagnqwsh has joined #openstack-nova | 01:25 | |
*** zhurong has joined #openstack-nova | 01:26 | |
*** hongbin_ has joined #openstack-nova | 01:28 | |
*** gjayavelu has quit IRC | 01:29 | |
*** kaisers has joined #openstack-nova | 01:31 | |
*** kaisers1 has quit IRC | 01:33 | |
*** sridharg has joined #openstack-nova | 01:34 | |
mriedem | god this is nice http://logs.openstack.org/62/449362/1/check/gate-tempest-dsvm-py35-ubuntu-xenial/ec959b4/logs/screen-n-cpu.txt.gz?level=TRACE#_2017-03-24_00_00_35_648 | 01:34 |
mriedem | thanks osinfo | 01:34 |
mriedem | i get it | 01:34 |
*** seungjin has joined #openstack-nova | 01:35 | |
*** jamielennox is now known as jamielennox|away | 01:39 | |
*** vishwanathj has joined #openstack-nova | 01:40 | |
*** gjayavelu has joined #openstack-nova | 01:42 | |
*** zul has quit IRC | 01:43 | |
*** zul has joined #openstack-nova | 01:44 | |
*** vishwanathj has quit IRC | 01:45 | |
openstackgerrit | Danfly proposed openstack/nova master: remove mox from unit/api/openstack/compute/test_disk_config.py https://review.openstack.org/449054 | 01:45 |
*** gjayavelu has quit IRC | 01:46 | |
openstackgerrit | Yoshihiko Atsumi proposed openstack/nova master: Add confirm resized server functional negative tests https://review.openstack.org/421074 | 01:47 |
*** Apoorva_ has quit IRC | 01:47 | |
gmann | Danfly: reviewed this, can you convert those as decorator or self.stub_out - https://review.openstack.org/#/c/445504 | 01:48 |
*** jamielennox|away is now known as jamielennox | 01:48 | |
*** gcb has joined #openstack-nova | 01:48 | |
*** gongysh has joined #openstack-nova | 01:49 | |
*** vishwanathj has joined #openstack-nova | 02:06 | |
*** vishwanathj has quit IRC | 02:07 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Do not attempt to load osinfo if we do not have os_distro https://review.openstack.org/449397 | 02:08 |
*** efried has quit IRC | 02:08 | |
*** vishwanathj has joined #openstack-nova | 02:09 | |
*** vishwanathj has quit IRC | 02:10 | |
*** vishwanathj has joined #openstack-nova | 02:11 | |
*** sree has joined #openstack-nova | 02:13 | |
*** sree has quit IRC | 02:17 | |
*** Sukhdev has quit IRC | 02:17 | |
*** suresh12 has quit IRC | 02:18 | |
*** kukacz has quit IRC | 02:20 | |
*** efried has joined #openstack-nova | 02:21 | |
*** tbachman_ has joined #openstack-nova | 02:29 | |
*** tbachman has quit IRC | 02:30 | |
*** tbachman_ is now known as tbachman | 02:30 | |
*** larainema has quit IRC | 02:32 | |
*** namnh has joined #openstack-nova | 02:33 | |
*** knikolla has quit IRC | 02:38 | |
*** aleph1 has quit IRC | 02:38 | |
*** suresh12 has joined #openstack-nova | 02:40 | |
*** ssurana has joined #openstack-nova | 02:42 | |
*** yamahata has quit IRC | 02:43 | |
*** suresh12 has quit IRC | 02:44 | |
*** unicell1 has quit IRC | 02:45 | |
*** aleph1 has joined #openstack-nova | 02:47 | |
*** raginbajin has quit IRC | 02:47 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova master: Fix wrong unit test about config option enabled_apis https://review.openstack.org/446898 | 02:48 |
*** knikolla has joined #openstack-nova | 02:50 | |
*** raginbajin has joined #openstack-nova | 02:52 | |
*** esberglu has joined #openstack-nova | 02:53 | |
*** tuanluong has joined #openstack-nova | 02:56 | |
*** ssurana has quit IRC | 02:57 | |
*** kaisers_ has joined #openstack-nova | 02:57 | |
*** esberglu has quit IRC | 02:58 | |
*** gcb has quit IRC | 02:58 | |
*** ssurana has joined #openstack-nova | 02:59 | |
*** gcb has joined #openstack-nova | 02:59 | |
*** ssurana has quit IRC | 02:59 | |
*** kaisers_ has quit IRC | 03:02 | |
*** takashin has left #openstack-nova | 03:07 | |
*** dave-mccowan has quit IRC | 03:08 | |
*** mrodden has quit IRC | 03:17 | |
*** mrodden has joined #openstack-nova | 03:19 | |
openstackgerrit | Zhou Jianming proposed openstack/nova master: code comments incorrectness https://review.openstack.org/449416 | 03:20 |
*** gongysh has quit IRC | 03:20 | |
*** IRCFrEAK has joined #openstack-nova | 03:21 | |
*** IRCFrEAK has left #openstack-nova | 03:22 | |
*** hongbin_ has quit IRC | 03:24 | |
*** edmondsw has quit IRC | 03:32 | |
*** Matias has quit IRC | 03:44 | |
*** Matias has joined #openstack-nova | 03:45 | |
*** yamahata has joined #openstack-nova | 03:47 | |
*** unicell has joined #openstack-nova | 03:53 | |
*** fandi has joined #openstack-nova | 03:53 | |
openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Raise general error message when volume attach fails https://review.openstack.org/320163 | 03:56 |
*** edmondsw has joined #openstack-nova | 03:59 | |
*** IRCFrEAK has joined #openstack-nova | 04:01 | |
*** IRCFrEAK has quit IRC | 04:01 | |
*** edmondsw has quit IRC | 04:04 | |
*** zhurong has quit IRC | 04:07 | |
*** htruta` has quit IRC | 04:11 | |
*** htruta has joined #openstack-nova | 04:12 | |
*** sree has joined #openstack-nova | 04:12 | |
*** vks1 has joined #openstack-nova | 04:16 | |
*** sree_ has joined #openstack-nova | 04:17 | |
*** sree_ is now known as Guest91910 | 04:18 | |
*** unicell1 has joined #openstack-nova | 04:18 | |
*** unicell has quit IRC | 04:18 | |
*** sree has quit IRC | 04:19 | |
*** suresh12 has joined #openstack-nova | 04:19 | |
*** links has joined #openstack-nova | 04:20 | |
*** unicell has joined #openstack-nova | 04:22 | |
*** unicell1 has quit IRC | 04:23 | |
*** amotoki has joined #openstack-nova | 04:31 | |
*** marst has joined #openstack-nova | 04:31 | |
*** amotoki has quit IRC | 04:35 | |
*** ratailor has joined #openstack-nova | 04:40 | |
*** kaisers_ has joined #openstack-nova | 04:42 | |
*** kaisers_ has quit IRC | 04:42 | |
*** kaisers_ has joined #openstack-nova | 04:42 | |
*** madhaviy has joined #openstack-nova | 04:42 | |
*** jdurgin has joined #openstack-nova | 04:44 | |
*** amotoki has joined #openstack-nova | 04:44 | |
*** namnh has quit IRC | 04:47 | |
*** ayogi has joined #openstack-nova | 04:53 | |
*** unicell1 has joined #openstack-nova | 04:53 | |
*** unicell has quit IRC | 04:54 | |
*** udesale has joined #openstack-nova | 04:57 | |
*** amotoki has quit IRC | 04:58 | |
*** kaisers_ has quit IRC | 04:59 | |
*** haplo37 has quit IRC | 04:59 | |
*** amotoki has joined #openstack-nova | 05:01 | |
*** fragatin_ has joined #openstack-nova | 05:01 | |
*** fragati__ has joined #openstack-nova | 05:03 | |
*** Sukhdev has joined #openstack-nova | 05:04 | |
*** fragatina has quit IRC | 05:05 | |
*** fragatin_ has quit IRC | 05:06 | |
*** fandi has quit IRC | 05:07 | |
*** fragati__ has quit IRC | 05:07 | |
*** psachin has joined #openstack-nova | 05:07 | |
*** haplo37 has joined #openstack-nova | 05:08 | |
*** sridharg has quit IRC | 05:08 | |
*** amotoki has quit IRC | 05:09 | |
*** kenperkins has joined #openstack-nova | 05:09 | |
*** jdurgin has quit IRC | 05:10 | |
*** udesale has quit IRC | 05:11 | |
*** udesale__ has joined #openstack-nova | 05:11 | |
*** armax has joined #openstack-nova | 05:11 | |
*** Kevin_Zheng has quit IRC | 05:13 | |
openstackgerrit | Gao Yuan proposed openstack/nova master: Remove mox from nova/tests/unit/api/openstack/compute/test_virtual_interfaces.py https://review.openstack.org/448377 | 05:15 |
*** zhurong has joined #openstack-nova | 05:16 | |
*** udesale__ has quit IRC | 05:20 | |
*** udesale has joined #openstack-nova | 05:20 | |
*** IRCFrEAK has joined #openstack-nova | 05:21 | |
*** udesale has quit IRC | 05:21 | |
*** fragatina has joined #openstack-nova | 05:21 | |
openstackgerrit | Gao Yuan proposed openstack/nova master: Remove mox from nova/tests/unit/api/openstack/compute/test_migrations.py https://review.openstack.org/448370 | 05:22 |
*** udesale has joined #openstack-nova | 05:22 | |
*** diga has joined #openstack-nova | 05:24 | |
*** fragatina has quit IRC | 05:25 | |
*** Sukhdev has quit IRC | 05:29 | |
*** lpetrut has joined #openstack-nova | 05:29 | |
*** gongysh has joined #openstack-nova | 05:29 | |
*** prateek has joined #openstack-nova | 05:31 | |
*** adisky_ has joined #openstack-nova | 05:32 | |
*** fragatina has joined #openstack-nova | 05:33 | |
*** fragatina has quit IRC | 05:33 | |
*** fragatina has joined #openstack-nova | 05:34 | |
openstackgerrit | Gao Yuan proposed openstack/nova master: Remove mox from nova/tests/unit/api/openstack/compute/test_quotas.py https://review.openstack.org/448393 | 05:37 |
openstackgerrit | Alex Xu proposed openstack/nova master: placement: Enable attach traits to ResourceProvider https://review.openstack.org/376201 | 05:46 |
openstackgerrit | Alex Xu proposed openstack/nova master: placement: Add Trait and TraitList objects https://review.openstack.org/376199 | 05:46 |
openstackgerrit | Gao Yuan proposed openstack/nova master: Remove mox from nova/tests/unit/api/openstack/compute/test_virtual_interfaces.py https://review.openstack.org/448377 | 05:47 |
*** avolkov has joined #openstack-nova | 05:47 | |
*** bmace has quit IRC | 05:48 | |
*** bmace has joined #openstack-nova | 05:48 | |
*** sridharg has joined #openstack-nova | 05:49 | |
*** Jack_Iv has joined #openstack-nova | 05:52 | |
*** mdnadeem has joined #openstack-nova | 05:53 | |
openstackgerrit | Gao Yuan proposed openstack/nova master: Remove mox from nova/tests/unit/api/openstack/compute/test_migrations.py https://review.openstack.org/448370 | 05:55 |
*** amotoki has joined #openstack-nova | 05:58 | |
openstackgerrit | lan proposed openstack/os-vif master: Remove log translations https://review.openstack.org/447865 | 06:00 |
*** Jack_Iv has quit IRC | 06:08 | |
*** kenperkins has quit IRC | 06:10 | |
*** suresh12 has quit IRC | 06:13 | |
openstackgerrit | Gao Yuan proposed openstack/nova master: Remove mox from nova/tests/unit/api/openstack/compute/test_migrations.py https://review.openstack.org/448370 | 06:16 |
*** tovin07_ has joined #openstack-nova | 06:18 | |
openstackgerrit | Gao Yuan proposed openstack/nova master: Remove mox from nova/tests/unit/api/openstack/compute/test_migrations.py https://review.openstack.org/448370 | 06:21 |
openstackgerrit | Gao Yuan proposed openstack/nova master: Remove mox from nova/tests/unit/consoleauth/test_consoleauth.py https://review.openstack.org/448386 | 06:25 |
*** gcb has quit IRC | 06:28 | |
*** suresh12 has joined #openstack-nova | 06:29 | |
*** armax has quit IRC | 06:29 | |
*** phuongnh has quit IRC | 06:29 | |
*** phuongnh has joined #openstack-nova | 06:30 | |
openstackgerrit | Hironori Shiina proposed openstack/nova-specs master: Fix rendering sub-directories in README https://review.openstack.org/449000 | 06:32 |
*** suresh12 has quit IRC | 06:33 | |
*** lpetrut has quit IRC | 06:34 | |
*** lpetrut has joined #openstack-nova | 06:35 | |
*** slaweq__ is now known as slaweq_ | 06:43 | |
openstackgerrit | Gao Yuan proposed openstack/nova master: Remove mox from nova/tests/unit/api/openstack/compute/test_quotas.py https://review.openstack.org/448393 | 06:43 |
*** lpetrut has quit IRC | 06:44 | |
*** IRCFrEAK has quit IRC | 06:44 | |
*** gouthamr has joined #openstack-nova | 06:45 | |
*** gcb has joined #openstack-nova | 06:45 | |
openstackgerrit | Huan Xie proposed openstack/nova master: Make xenapi driver compatible with assert_can_migrate https://review.openstack.org/439960 | 06:46 |
openstackgerrit | Gao Yuan proposed openstack/nova master: Remove mox from nova/tests/unit/api/openstack/compute/test_virtual_interfaces.py https://review.openstack.org/448377 | 06:47 |
*** mvk has quit IRC | 06:47 | |
*** Jack_Iv has joined #openstack-nova | 06:49 | |
*** karimb has joined #openstack-nova | 06:51 | |
*** gongysh has quit IRC | 06:51 | |
*** karimb has quit IRC | 06:51 | |
*** markus_z has joined #openstack-nova | 06:56 | |
*** Guest91910 has quit IRC | 06:56 | |
*** lpetrut has joined #openstack-nova | 06:57 | |
*** unicell has joined #openstack-nova | 06:57 | |
*** unicell1 has quit IRC | 06:57 | |
*** andreas_s has joined #openstack-nova | 06:58 | |
*** kaisers_ has joined #openstack-nova | 06:59 | |
*** edmondsw has joined #openstack-nova | 06:59 | |
*** nkorabli has joined #openstack-nova | 07:01 | |
*** gongysh has joined #openstack-nova | 07:02 | |
*** edmondsw has quit IRC | 07:04 | |
*** kaisers_ has quit IRC | 07:04 | |
*** lpetrut has quit IRC | 07:05 | |
*** gouthamr has quit IRC | 07:12 | |
*** nkrinner_afk is now known as nkrinner | 07:12 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix api-ref for adminPass behavior https://review.openstack.org/449450 | 07:17 |
nkorabli | Hi there, I've got a question related to multitenancy, I believe. I already asked it once, but have some new details.. | 07:17 |
*** psachin has quit IRC | 07:18 | |
nkorabli | login as demo user and create an instance . | 07:18 |
nkorabli | login as a admin user navigate to admin panel and shelve the instance (as admin user is able shelve any instance) | 07:18 |
nkorabli | login as demo user and try to unshelve the instance shelved by admin user | 07:18 |
nkorabli | expected : instance should be unshelved | 07:18 |
*** psachin has joined #openstack-nova | 07:18 | |
nkorabli | Actual : instance is not shelved but is went to error state. There are two conditions here 1.If this scenarios is not valid admin user should not have an option to shelve the instance , this option should be removed . | 07:18 |
nkorabli | 2.If this is a valid flow , instance should be unsheleved by the demo user. During the shelve process a snap shot will be created in the instance panel and it will be removed automatically when instance is unshelved. But when admin user is trying to shelve instance a snapshot is created under admin projects instead of demo project . This may be the reason for unshelve failure | 07:18 |
nkorabli | So, basically what is a valid workflow for this scenario? | 07:19 |
*** lpetrut has joined #openstack-nova | 07:21 | |
*** kylek3h_ has joined #openstack-nova | 07:22 | |
*** ralonsoh has joined #openstack-nova | 07:23 | |
*** kylek3h has quit IRC | 07:24 | |
*** phuongnh has quit IRC | 07:27 | |
*** mnestratov has quit IRC | 07:27 | |
*** phuongnh has joined #openstack-nova | 07:28 | |
*** tesseract has joined #openstack-nova | 07:31 | |
*** Jack_Iv has quit IRC | 07:31 | |
*** satyar has joined #openstack-nova | 07:33 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add description to policies in lock_server.py https://review.openstack.org/448468 | 07:34 |
openstackgerrit | Tomi Juvonen proposed openstack/nova-specs master: Planned host maintenance https://review.openstack.org/310510 | 07:34 |
*** fengzhr has quit IRC | 07:35 | |
*** lpetrut has quit IRC | 07:35 | |
*** Jack_Iv has joined #openstack-nova | 07:36 | |
*** fengzhr has joined #openstack-nova | 07:36 | |
*** ltomasbo|away is now known as ltomasbo | 07:38 | |
*** Jack_Iv has quit IRC | 07:40 | |
tojuvone | johnthetubaguy, updated the spec: https://review.openstack.org/310510 | 07:43 |
*** ekuris has quit IRC | 07:43 | |
openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Use mask_dict_password from oslo.utils https://review.openstack.org/388345 | 07:44 |
*** ekuris has joined #openstack-nova | 07:45 | |
openstackgerrit | jichenjc proposed openstack/nova master: refactory some code on get_password https://review.openstack.org/449458 | 07:45 |
openstackgerrit | jichenjc proposed openstack/nova master: check hw:mem_page_size when change extra_spec https://review.openstack.org/408610 | 07:46 |
openstackgerrit | jichenjc proposed openstack/nova master: remove keypair server extension https://review.openstack.org/396611 | 07:47 |
openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Use mask_dict_password from oslo.utils https://review.openstack.org/388345 | 07:48 |
openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Use mask_dict_password from oslo.utils https://review.openstack.org/388345 | 07:49 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add description to policies in keypairs.py https://review.openstack.org/448461 | 07:50 |
*** ekuris has quit IRC | 07:50 | |
*** madhaviy has quit IRC | 07:50 | |
*** Jack_Iv has joined #openstack-nova | 07:54 | |
*** jaosorior has joined #openstack-nova | 07:55 | |
*** belmoreira has joined #openstack-nova | 07:59 | |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-nova | 08:01 | |
*** tojuvone has quit IRC | 08:06 | |
*** yamahata has quit IRC | 08:07 | |
*** ralonsoh has quit IRC | 08:07 | |
*** mriedem has quit IRC | 08:16 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add description to policies in pause_server.py https://review.openstack.org/449478 | 08:17 |
*** tojuvone has joined #openstack-nova | 08:18 | |
*** mhenkel has quit IRC | 08:21 | |
*** fengzhr has quit IRC | 08:21 | |
*** _gryf_ has joined #openstack-nova | 08:21 | |
*** _gryf_ has quit IRC | 08:22 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova master: live-migration test hook for serial console https://review.openstack.org/347471 | 08:22 |
*** gongysh has quit IRC | 08:22 | |
*** Kevin_Zheng has joined #openstack-nova | 08:22 | |
*** fengzhr has joined #openstack-nova | 08:22 | |
*** mlakat has joined #openstack-nova | 08:23 | |
*** amoralej|off is now known as amoralej | 08:23 | |
*** mhenkel has joined #openstack-nova | 08:23 | |
*** abalutoiu has joined #openstack-nova | 08:24 | |
openstackgerrit | lan proposed openstack/os-vif master: Remove log translations https://review.openstack.org/447865 | 08:25 |
*** vks1 has quit IRC | 08:27 | |
*** sree has joined #openstack-nova | 08:28 | |
*** vks1 has joined #openstack-nova | 08:30 | |
*** sree has quit IRC | 08:32 | |
*** bauzas is now known as bauwser | 08:34 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add description to policies in server_groups.py https://review.openstack.org/449486 | 08:35 |
*** gongysh has joined #openstack-nova | 08:38 | |
*** sree has joined #openstack-nova | 08:40 | |
*** vks1 has quit IRC | 08:41 | |
*** aarefiev_pto is now known as aarefiev | 08:42 | |
*** gongysh has quit IRC | 08:43 | |
*** vks1 has joined #openstack-nova | 08:43 | |
*** jpena|off is now known as jpena | 08:44 | |
*** sean-k-mooney has quit IRC | 08:48 | |
*** ralonsoh has joined #openstack-nova | 08:52 | |
*** jpena is now known as jpena|off | 08:57 | |
*** alex_xu has quit IRC | 08:58 | |
*** Jack_Iv has quit IRC | 08:58 | |
*** alex_xu has joined #openstack-nova | 08:59 | |
*** alex_xu has quit IRC | 09:01 | |
*** alex_xu has joined #openstack-nova | 09:02 | |
*** Guest93689 has quit IRC | 09:03 | |
*** jpena|off is now known as jpena | 09:04 | |
*** ralonsoh_ has joined #openstack-nova | 09:05 | |
*** Guest93689 has joined #openstack-nova | 09:06 | |
*** alex_xu has quit IRC | 09:06 | |
*** alex_xu has joined #openstack-nova | 09:07 | |
*** claudiub|2 has joined #openstack-nova | 09:08 | |
*** ralonsoh has quit IRC | 09:09 | |
*** udesale has quit IRC | 09:15 | |
*** Jack_Iv has joined #openstack-nova | 09:16 | |
openstackgerrit | 龚肖 proposed openstack/nova master: Replaces uuid.uuid4 with uuidutils.generate_uuid() https://review.openstack.org/449515 | 09:17 |
*** gongysh has joined #openstack-nova | 09:20 | |
openstackgerrit | Jordan Pittier proposed openstack/nova master: Remove the Libvirt Scality volume driver https://review.openstack.org/449517 | 09:21 |
*** tuanluong has quit IRC | 09:23 | |
*** ralonsoh_ is now known as ralonsoh | 09:27 | |
*** lucas-afk is now known as lucasagomes | 09:29 | |
*** wagnqwsh has quit IRC | 09:29 | |
*** esberglu has joined #openstack-nova | 09:30 | |
alex_xu | jaypipes: are we ready to use standard traits that defined in os-traits when create neutron port https://review.openstack.org/#/c/435954/11/specs/pike/approved/enable-sriov-nic-features.rst@122 ? | 09:31 |
*** derekh has joined #openstack-nova | 09:33 | |
*** kevinz has quit IRC | 09:34 | |
*** esberglu has quit IRC | 09:35 | |
sfinucan | cfriesen: You were looking for me? | 09:38 |
johnthetubaguy | mdbooth: sfinucan: sounds like we missed a bit in this one (really worries about our testing now): https://review.openstack.org/#/c/438970/ | 09:39 |
openstackgerrit | Huan Xie proposed openstack/nova master: Fix race condition when neutron is using minimized poll https://review.openstack.org/444230 | 09:42 |
johnthetubaguy | tojuvone: hi, thanks for the update, just reading through that, lots of great context in there now | 09:42 |
johnthetubaguy | tojuvone: got a question, it says "in NFV there are automated action on host failure", what tool is that? | 09:43 |
bauwser | johnthetubaguy: yeah I was on the spec too :) | 09:44 |
tojuvone | johnthetubaguy, NFV wouldn't think yet opensource, but one could soon make this in places like craton, or currently by utilizing mistral | 09:45 |
bauwser | tojuvone: I thought it was Watcher ? | 09:45 |
*** lpetrut has joined #openstack-nova | 09:45 | |
johnthetubaguy | tojuvone: OK, just wondering if there is a specific opensource community we should be talking to about this spec, I was assuming the OpenNFV folks might have something cooking for this | 09:46 |
*** Shunli has quit IRC | 09:46 | |
johnthetubaguy | just if those folks exist, I would love their feedback on this one, I just don't know who to reach out to | 09:46 |
*** lpetrut has quit IRC | 09:46 | |
openstackgerrit | 龚肖 proposed openstack/nova master: Replaces uuid.uuid4 with uuidutils.generate_uuid() https://review.openstack.org/449537 | 09:47 |
tojuvone | bauwser, I need to look watcher better. I know its optimizing resources | 09:47 |
*** bmace has quit IRC | 09:48 | |
tojuvone | johnthetubaguy, I know there is some MANO projects, but haven't been dealing with those myself | 09:49 |
*** lpetrut has joined #openstack-nova | 09:49 | |
johnthetubaguy | tojuvone: is there any chance you could reach out to those folks, or someone who knows them, to ask if they are interested in reviewing your spec? | 09:50 |
*** yamamoto has quit IRC | 09:50 | |
frickler | is the format of network_data.json documented somewhere? my Google foo seems weak this morning | 09:53 |
johnthetubaguy | frickler: its a question that keeps coming up, I keep meaning to ask gmann and alex_xu about this one, we really need the metadata service (and config drive) documenting in our api-ref | 09:54 |
*** sean-k-mooney has joined #openstack-nova | 09:54 | |
frickler | the closest thing I can find is this, but it doesn't look up to date https://specs.openstack.org/openstack/nova-specs/specs/liberty/implemented/metadata-service-network-info.html | 09:54 |
johnthetubaguy | it has change some over time, I am just looking to see what we have in the code | 09:55 |
johnthetubaguy | ironic have done some recent tweaks | 09:55 |
frickler | johnthetubaguy: in particular it would be good to settle whether ipv6_dhcp can also mean ipv6_slaac or whether that should be distinguishable | 09:55 |
tojuvone | johnthetubaguy, I will take a look. Surely these are otherwise "traditional" Telco requirements. | 09:56 |
johnthetubaguy | tojuvone: not questioning that, just wanting to make sure we get wide feedback | 09:56 |
openstackgerrit | Zhou Jianming proposed openstack/nova master: 'uplug' word spelling mistake https://review.openstack.org/449543 | 09:56 |
*** mvk has joined #openstack-nova | 09:57 | |
tojuvone | johnthetubaguy, yes, understand that :) | 09:58 |
johnthetubaguy | tojuvone: I think there are some folks at intel curious about this one too, I need to get them to have a look | 09:59 |
*** kaisers_ has joined #openstack-nova | 10:00 | |
tojuvone | johnthetubaguy, great | 10:01 |
*** bmace has joined #openstack-nova | 10:01 | |
*** karthiks is now known as karthiks_afk | 10:02 | |
bauwser | tojuvone: johnthetubaguy: what's puzzling me is that I don't get the last piece of the puzzle for automatic redeployment | 10:02 |
bauwser | tojuvone: johnthetubaguy: so, Vitrage is defining alarms. ala CloudWatch, right? | 10:02 |
johnthetubaguy | frickler: this may not help, but this is the bit of code that is interesting: https://github.com/openstack/nova/blob/a4ee3ea563ccf6ad92e081e8fdd537c7d411142a/nova/virt/netutils.py#L166 | 10:03 |
bauwser | tojuvone: johnthetubaguy: so my question is, which project is triggering those alarms ? | 10:03 |
johnthetubaguy | frickler: we are currently talking with neutron how to get them to own this interface | 10:03 |
bauwser | tojuvone: hence my point, I was thinking it was Watcher | 10:03 |
johnthetubaguy | frickler: get the network experts doing the network stuff seems more... sound | 10:03 |
bauwser | tojuvone: actually, Watcher already subcribes to the notification bus so possibly there wouldn't be a need for Vitrage | 10:04 |
*** kaisers_ has quit IRC | 10:04 | |
gmann | johnthetubaguy: frickler yea we lack that documentation. this tempest tests fetch and check device tag in case that help - https://github.com/openstack/tempest/blob/master/tempest/api/compute/servers/test_device_tagging.py | 10:04 |
johnthetubaguy | gmann: can you get that onto the agenda for the next API meeting, we should fix that before we finish off that concept guide | 10:04 |
tojuvone | bauwser, Vitrage is used to monitor cloud, make RCA of events and raise alarms | 10:05 |
johnthetubaguy | gmann: generating some api samples would be awesome, I suspect that may be the way to start | 10:05 |
bauwser | tojuvone: what is the differenciator with AODH and Ceilometer ? | 10:05 |
*** pcaruana has joined #openstack-nova | 10:05 | |
tojuvone | bauwser, It uses AODH | 10:05 |
bauwser | mmmmm okay | 10:06 |
gmann | johnthetubaguy: yea, i can check on this but may not be not soon... | 10:06 |
bauwser | tojuvone: I guess I need to look at the Vitrage wiki then to understand their needs | 10:06 |
johnthetubaguy | gmann: understood | 10:06 |
tojuvone | bauwser, So we actually use it NFV | 10:07 |
johnthetubaguy | gmann: probably just need to get that on our list for this cycle | 10:07 |
bauwser | because I don't see the need of an abstraction over another abstraction :) | 10:07 |
bauwser | tojuvone: that, I got it | 10:07 |
mdbooth | johnthetubaguy: Whoa | 10:07 |
*** ociuhandu has joined #openstack-nova | 10:08 | |
mdbooth | johnthetubaguy: Well, there's only 1 thing for it: better merge the next patch quick :) | 10:08 |
gmann | johnthetubaguy: sure. | 10:09 |
*** jichen has quit IRC | 10:09 | |
johnthetubaguy | mdbooth: thats one way to do it, you want to line those back up, and we can take another look quickly | 10:09 |
tojuvone | Vitrage need to differentiate host fault from planned maintenance, to have proper alarms | 10:09 |
mdbooth | johnthetubaguy: I'm joking, if we need to revert lets do it. | 10:09 |
mdbooth | However, I really would like to get that merged | 10:09 |
johnthetubaguy | mdbooth: I think they did the revert already | 10:09 |
mdbooth | Ok, cool | 10:10 |
johnthetubaguy | yeah, I think the emergency bit is done already | 10:10 |
mdbooth | We don't run the NFS job by default, which is probably how that slipped through | 10:10 |
bauwser | tojuvone: so, to understand correctly the NFV usecase, Vitrage emits alarms, right? | 10:11 |
mdbooth | And, as you say, I only did the more thorough manual testing on the next patch in the series. | 10:11 |
*** tovin07_ has quit IRC | 10:11 | |
bauwser | tojuvone: for each "node" that is impacted by some notification | 10:11 |
mdbooth | I'll line that up today | 10:11 |
bauwser | tojuvone: now, once those deduced alarms are raised, which tool will trigger actions on those ? | 10:12 |
*** dixiaoli has joined #openstack-nova | 10:12 | |
tojuvone | bauwser, Its RCA raising alarms on each level where needed to | 10:12 |
bauwser | tojuvone: that I got it too | 10:12 |
bauwser | the output is basically a set of alarms | 10:12 |
bauwser | with linkages between thoses | 10:12 |
tojuvone | bauwser, so here planned mainteancne instead | 10:12 |
tojuvone | bauwser, at least in fault situation it could force down host or what else would be configured | 10:13 |
tojuvone | bauwser, but it is not intended to make workflows to migrate | 10:13 |
bauwser | *what* would do that ? | 10:13 |
bauwser | Vitrage? | 10:14 |
bauwser | ie. what executes the action plan ? | 10:14 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient master: Imported Translations from Zanata https://review.openstack.org/449041 | 10:14 |
bauwser | tojuvone: is this something which is already present today | 10:14 |
bauwser | ? | 10:14 |
bauwser | tojuvone: because my main concern on Nova is that we need to understand the missing gaps | 10:15 |
bauwser | tojuvone: ie. what is specifically lacking on our side so that a specific usecase could be fulfilled | 10:15 |
tojuvone | bauwser, I was planning to make poc with Craton upon planned mainteancne | 10:15 |
bauwser | tojuvone: the main problem I have with your spec is that I don't see yet a clear picture on the overall workflow, and what's missing in that workflow on the nova side | 10:16 |
tojuvone | bauwser, I am not sure somebody doing this in fully open source | 10:16 |
bauwser | well, I'm not exactly concerned by that | 10:16 |
bauwser | but I need to understand why we can't just disable services or force hosts down | 10:17 |
bauwser | because I don't have the clear workflow picture in my mind | 10:17 |
bauwser | for example, say the forced_down series you implemented | 10:17 |
tojuvone | bauwser, In Nova it is much to me to see it in servers API | 10:18 |
bauwser | it was clear to me that there was an usecase where 3rd-party tools (opensource or not) could be identifying before our SG API that a host is down and could accelerate the logic by having a specific bit to call | 10:18 |
tojuvone | that is fault management | 10:19 |
tojuvone | here you have planned maintenance | 10:19 |
bauwser | correct, I'm not saying your spec is that | 10:19 |
bauwser | sure, but what's missing in nova for that ? | 10:19 |
bauwser | you can disable a service | 10:19 |
*** sree has quit IRC | 10:19 | |
bauwser | you can migrate all the existing instances of that host out | 10:20 |
tojuvone | the planned window is missing | 10:20 |
bauwser | without having user-visible impacy | 10:20 |
*** sree has joined #openstack-nova | 10:20 | |
bauwser | you mean "disable me this service in 1 hour" ? | 10:20 |
tojuvone | yes | 10:20 |
tojuvone | and what you can do in that windwo | 10:21 |
bauwser | say you have a planned maintenance in one hour | 10:21 |
bauwser | what do you want to have on the nova side? | 10:21 |
*** sree has quit IRC | 10:21 | |
bauwser | ie. what do you want to do with the scheduler and your instances ? | 10:21 |
bauwser | not speaking of the proposed implementation | 10:21 |
tojuvone | and to have the rolling thing with that window | 10:21 |
bauwser | rather about what you wanna do as an operator during that period *before* the maintenance | 10:22 |
*** sree has joined #openstack-nova | 10:22 | |
tojuvone | yes, for now we can forget what is proposed currently as implementation | 10:22 |
bauwser | for example | 10:22 |
bauwser | let's speak ITIL for a spec | 10:22 |
bauwser | sec | 10:22 |
tojuvone | as a user, application, you want to do something | 10:23 |
bauwser | your change manager gave you a change window that will happen in 1 hour because you need to upgrade the kernel | 10:23 |
johnthetubaguy | bauwser: I think we just need to focus on the use cases in the spec | 10:23 |
bauwser | on a specific host | 10:23 |
johnthetubaguy | I am current adding a patch on top of tojuvone's spec to see if I understand them correctly | 10:23 |
johnthetubaguy | I think we should stay out of implementation detail right now | 10:23 |
bauwser | johnthetubaguy: those usecases are way too-high level for me | 10:23 |
bauwser | johnthetubaguy: I agree | 10:24 |
bauwser | johnthetubaguy: I want to understand the crux of the problem | 10:24 |
bauwser | without speaking code | 10:24 |
bauwser | ie. I want to discuss about what is a "planned maintenance" and what actions are needed to be done | 10:24 |
johnthetubaguy | yeah, I am trying to write that out now, to see if I understand what I think tojuvone is trying to say | 10:24 |
bauwser | for example | 10:24 |
johnthetubaguy | (this is based on how I know we wanted this to work for public cloud) | 10:24 |
bauwser | "* As an admin I want to have an external tool to handle hosts and their maintenance:" is mentioned in that spec, but waaaaays too much than just nova | 10:25 |
johnthetubaguy | well, we built this system using server metadata | 10:25 |
tojuvone | yes, that is used before ;) | 10:25 |
johnthetubaguy | it will be many, many different tools doing lots of this different operations, the key bit is the Nova interactions they all have in common, I am trying to write those down right now | 10:25 |
bauwser | okay, tojuvone could you please explain me what is a "planned maintenance" ? | 10:26 |
mdbooth | johnthetubaguy: https://review.openstack.org/#/c/439520/ | 10:26 |
mdbooth | I don't understand your comment about the rebase. What's the context there? | 10:26 |
openstackgerrit | John Garbutt proposed openstack/nova master: compute: Move detach logic from manager into driver BDM https://review.openstack.org/439520 | 10:26 |
*** sree has quit IRC | 10:26 | |
johnthetubaguy | mdbooth: so I expected rebase to fail once that patch I linked to lands on master | 10:27 |
johnthetubaguy | mdbooth: 437665 I think it was | 10:27 |
mdbooth | johnthetubaguy: IIRC there was no conflict between the 2 | 10:27 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/449257 | 10:27 |
johnthetubaguy | mdbooth: so there was on my system, which is kinda freaky | 10:27 |
johnthetubaguy | mdbooth: I must have fat fingered something | 10:27 |
mdbooth | Ok, probably means there was, then :) | 10:27 |
tojuvone | I have used "planned maitenance", to high light it does not happen because sudden fault | 10:28 |
johnthetubaguy | so its on master, and it just rebased cleanly, so maybe we are OK | 10:28 |
mdbooth | But when lyarwood separated them he didn't lose review votes | 10:28 |
mdbooth | Suggesting there was no difference | 10:28 |
johnthetubaguy | mdbooth: ah, good point, that usually means no difference | 10:28 |
johnthetubaguy | I may have tried to cherry pick ontop of an old version of its-self or something dumb | 10:28 |
johnthetubaguy | oh, well, seems fine now | 10:29 |
mdbooth | Meh, if the other one's already in the gate it's no problem | 10:29 |
bauwser | tojuvone: I'm just commenting your spec | 10:29 |
bauwser | tojuvone: I think I get a better picture | 10:29 |
tojuvone | bauwser, ok :) | 10:29 |
bauwser | tojuvone: #1 you wanna signal some hosts for a maintenance and prevent instances booting on them | 10:29 |
bauwser | #2 you wanna test those hosts during that maintenance | 10:29 |
bauwser | #3 you wanna only schedule instances to maintened hosts | 10:30 |
bauwser | that's BIG | 10:30 |
johnthetubaguy | funny, thats whats in my patch I am writing | 10:30 |
*** ZZelle_ is now known as ZZelle | 10:31 | |
tojuvone | bauwser, There is a lot since I have collected also operator input and put obvious possibilities this gives | 10:31 |
bauwser | tojuvone: I just think you're boiling the ocean with your spec | 10:31 |
bauwser | I'm not saying it's not valid concerns | 10:32 |
tojuvone | bauwser, It has not been a easy year since started to bring this to light :D | 10:32 |
johnthetubaguy | I kept meaning to write this us for Rackspace for the last few years, it just seems a bit different to what I expected | 10:33 |
johnthetubaguy | we have 80% of this already in tree | 10:34 |
tojuvone | bauwser, My own NFV requirement stared just the fact I need to know in application side | 10:34 |
*** nkorabli has quit IRC | 10:35 | |
*** edmondsw has joined #openstack-nova | 10:35 | |
*** gongysh has quit IRC | 10:37 | |
*** nicolasbock has joined #openstack-nova | 10:38 | |
*** zhurong has quit IRC | 10:40 | |
*** edmondsw has quit IRC | 10:40 | |
*** tbachman has quit IRC | 10:44 | |
bauwser | tojuvone: johnthetubaguy: FWIW, I just commented the above discussion in https://review.openstack.org/#/c/310510/19 | 10:47 |
bauwser | just one short comment, hope tojuvone would accept that | 10:47 |
bauwser | tojuvone: basically, I want to explain to you that you need to scope more your spec, and identify what you want to achieve by that spec - you could possibly mention other usecases or problems, but please be explicit that those are not intended to be resolved by the spec | 10:48 |
BobBall_ | johnthetubaguy: Any chance you could re-review https://review.openstack.org/#/c/353862/ at some point? | 10:48 |
bauwser | tojuvone: the idea of preventing instances to be scheduled on hosts that aren't maintained yet is an idea I already saw | 10:49 |
johnthetubaguy | BobBall_: opened it in a tab, hope to get back to that | 10:49 |
bauwser | tojuvone: I just think the abstraction model isn't rich enough | 10:49 |
*** yamamoto has joined #openstack-nova | 10:49 | |
BobBall_ | +1 thanks :) | 10:49 |
bauwser | tojuvone: ie. you wanna schedule instances on hosts that are >= some siognal | 10:49 |
bauwser | ie. having some "capability" or "trait" :p | 10:50 |
*** yamamoto_ has joined #openstack-nova | 10:50 | |
bauwser | like, I could want to schedule instances on hosts that ship latest libvirt | 10:50 |
tojuvone | bauwser, Thanks, patch 19 was to catch everything and did exactly that for the cases | 10:51 |
bauwser | yeah, I understand | 10:51 |
tojuvone | totally agree, separate specs otherwsie | 10:51 |
bauwser | that looks like more you trying to log all the possible usecases, so I'd rather say a backlog spec would fit that | 10:51 |
bauwser | it looks like an epic to me | 10:52 |
*** cdent has joined #openstack-nova | 10:52 | |
bauwser | either way, I need to move on :) | 10:52 |
tojuvone | bauwser, thanks :) | 10:52 |
tojuvone | so I felt really need to have each corner to tell where it might lead. While not to do the whole implementation in same | 10:53 |
mdbooth | http://stackoverflow.com/questions/25183424/can-a-python-abstract-base-class-enforce-function-signatures | 10:53 |
mdbooth | Abstractmethods will not save us :( | 10:54 |
*** yamamoto has quit IRC | 10:54 | |
mdbooth | A compiler would be awesome | 10:54 |
bauwser | tojuvone: hence me thinking a backlog spec could describe the end goal | 10:54 |
bauwser | tojuvone: and you iterating over a couple of specs for that | 10:54 |
cdent | mdbooth's epitath: "A compiler would be awesome" | 10:55 |
*** gcb has quit IRC | 10:56 | |
tojuvone | bauwser, Is there a good example of this kind of specs | 10:56 |
mdbooth | I recalled from a previous investigation that abstractmethods are pretty useless | 10:56 |
*** nkorabli has joined #openstack-nova | 10:59 | |
*** phuongnh has quit IRC | 10:59 | |
*** armax has joined #openstack-nova | 11:02 | |
*** dixiaoli has quit IRC | 11:03 | |
*** smatzek has joined #openstack-nova | 11:03 | |
*** yamamoto_ has quit IRC | 11:05 | |
*** yamamoto has joined #openstack-nova | 11:05 | |
nkorabli | Hi everyone! I’ve got a multitenancy related question: | 11:06 |
nkorabli | if you create a instance as demo user, shelve it as admin and then try to unshelve it as demo again - you won’t see any errors or warnings, but instance will end up with an ERROR state. | 11:06 |
nkorabli | So, what should be the right way for this scenario? What do you think? | 11:06 |
*** Dinesh_Bhor has quit IRC | 11:07 | |
nkorabli | Just reproduced it with stable/newton in a devstack environment | 11:08 |
*** armax has quit IRC | 11:16 | |
*** yamamoto has quit IRC | 11:17 | |
*** udesale has joined #openstack-nova | 11:19 | |
*** tovin07 is now known as tovin07_at_work | 11:20 | |
*** Dinesh_Bhor has joined #openstack-nova | 11:20 | |
*** tovin07_at_work has quit IRC | 11:20 | |
*** sdague has joined #openstack-nova | 11:21 | |
*** udesale has quit IRC | 11:21 | |
kashyap | mdbooth: This is ready for merge, no? -- https://review.openstack.org/#/c/383859/ ("libvirt: Fix races with nfs volume mount/umount ") | 11:25 |
kashyap | Needs another core reviewer to take a look at it | 11:26 |
mdbooth | kashyap: No, there was a bug in the parent commit | 11:26 |
*** Matias has quit IRC | 11:27 | |
* kashyap looks at the parent commit | 11:27 | |
mdbooth | kashyap: It was reverted :) | 11:27 |
* mdbooth is working on it now | 11:27 | |
kashyap | mdbooth: Mind throwing the URL? Gerrit's interface trips me up always | 11:28 |
mdbooth | Revert was change If1ee6d6e4004750f80424ec54d7dabc564ec9e06 | 11:28 |
*** gongysh has joined #openstack-nova | 11:28 | |
kashyap | Ah, thanks. | 11:29 |
*** rfolco has joined #openstack-nova | 11:32 | |
*** edmondsw has joined #openstack-nova | 11:32 | |
*** rfolco has quit IRC | 11:33 | |
*** rfolco has joined #openstack-nova | 11:33 | |
*** Matias has joined #openstack-nova | 11:39 | |
*** alexpilotti has quit IRC | 11:40 | |
*** alexpilotti has joined #openstack-nova | 11:41 | |
*** alexpilotti has quit IRC | 11:45 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Start using oslo.sphinxext https://review.openstack.org/449584 | 11:48 |
sfinucan | johnthetubaguy, macsz: I think you'll like that one ^ | 11:48 |
* sfinucan has been on a deep dive into Sphinx internals and now thinks he understands the meaning of life | 11:49 | |
*** rfolco has quit IRC | 11:51 | |
*** vladikr has quit IRC | 11:52 | |
cdent | sfinucan: I assume this meaning is something others can only grasp if they too go on the same journey and thus you cannot pass it on? | 11:52 |
nkorabli | Could you please comment my question - then I will create a bug | 11:52 |
nkorabli | if you create an instance as a demo user, shelve it as admin and then try to unshelve it as demo user again - you won’t see any errors or warnings, but instance will end up with an ERROR state. | 11:53 |
nkorabli | So, what should be the right way for this scenario? What do you think? | 11:53 |
cdent | nkorabli: I'd comment except for the fact that I don't know. | 11:53 |
sfinucan | cdent: I'm afraid so | 11:54 |
sfinucan | I intend to blog about some of it but if reading dhellman's musings [1] alone couldn't help me attain enlightenment, what hope has a mere mortal like myself of helping others? [1] https://doughellmann.com/blog/2010/05/09/defining-custom-roles-in-sphinx/ | 11:54 |
* cdent nods sadly and sagely | 11:54 | |
*** jpena is now known as jpena|lunch | 11:56 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/nova master: [Ironic] Do not hard fail when Ironic is not available https://review.openstack.org/449587 | 11:57 |
nkorabli | cdent: thanks, fair enough :) | 11:57 |
*** tbachman has joined #openstack-nova | 11:59 | |
sfinucan | nkorabli: I'd say just open a bug with your findings and let others come to their own conclusions about how to resolve it | 11:59 |
*** Matias has quit IRC | 12:00 | |
*** kaisers_ has joined #openstack-nova | 12:00 | |
sdague | johnthetubaguy: you about? | 12:01 |
johnthetubaguy | I am | 12:01 |
*** udesale has joined #openstack-nova | 12:01 | |
*** Matias has joined #openstack-nova | 12:01 | |
sdague | I was just going through the policy spec, and I'm with mriedem, it's super confusing | 12:01 |
sdague | even though I know where you are trying to go with it, I think | 12:01 |
sdague | I left some thoughts on how to rewrite bits for clarity | 12:01 |
*** links has quit IRC | 12:02 | |
johnthetubaguy | sdague: thats cool, it is confusing | 12:03 |
johnthetubaguy | I tried a few different rewords, I might be stuck in the middle of a few of them right now | 12:03 |
mdbooth | Bless it's cotton socks, pylint does try hard in the face of overwhelming adversity | 12:03 |
openstackgerrit | John Garbutt proposed openstack/nova-specs master: Alternative for warning users about maintenance https://review.openstack.org/449593 | 12:03 |
johnthetubaguy | tojuvone: (and bauwser) I typed up some ideas I had in there ^ | 12:04 |
johnthetubaguy | sdague: is that both of them, btw? | 12:04 |
jroll | lucasagomes: nice find, thanks for that | 12:04 |
sdague | johnthetubaguy: I just went through the bottom one | 12:04 |
*** kaisers_ has quit IRC | 12:05 | |
mdbooth | sdague: Actually, this sounds like something you might have tried. I'm looking for a test which checks function arguments and before writing something custom I thought I'd checkout pylint. Do you know if anybody's ever looked at a pylint job for Nova? | 12:05 |
*** links has joined #openstack-nova | 12:05 | |
johnthetubaguy | sdague: OK, thats the one I hoped was better to read, is it worth a quick hangout? | 12:05 |
*** yamamoto has joined #openstack-nova | 12:06 | |
johnthetubaguy | sdague: actually, I think I get your comment, let me try fix that | 12:07 |
*** aysyd has joined #openstack-nova | 12:08 | |
sdague | johnthetubaguy: I can do a quick hangout in a few minutes if you like | 12:09 |
johnthetubaguy | sdague: maybe I try a quick rev of that first section, and see how we look later on? | 12:10 |
sdague | sure | 12:10 |
lucasagomes | jroll, o/ np thanks for the review | 12:12 |
*** alexpilotti has joined #openstack-nova | 12:13 | |
nkorabli | sfinucan: thanks, I just thought if I would get a response, I could fix it now.. | 12:14 |
*** lucasagomes is now known as lucas-hungry | 12:14 | |
*** yamamoto has quit IRC | 12:15 | |
*** gongysh has quit IRC | 12:17 | |
*** ratailor has quit IRC | 12:17 | |
openstackgerrit | fengzhr proposed openstack/nova master: Make network:attach_external_network policy check outside nova-api https://review.openstack.org/449598 | 12:18 |
*** vks1 has quit IRC | 12:20 | |
openstackgerrit | Andrey Volkov proposed openstack/nova master: Structure for simply managing placement-api-ref https://review.openstack.org/409340 | 12:22 |
openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] add api-ref for GET /resource_providers https://review.openstack.org/418503 | 12:22 |
*** diga has quit IRC | 12:22 | |
*** liverpooler has quit IRC | 12:26 | |
*** liverpooler has joined #openstack-nova | 12:26 | |
*** rfolco has joined #openstack-nova | 12:27 | |
sdague | sfinucan: you reading the email on the ipv6 issue infra hit | 12:28 |
sfinucan | sdague: I am not. Link? | 12:29 |
sfinucan | Is this 'Config drive claims ipv6_dhcp, neutron api says slaac' | 12:29 |
*** nkorabli has quit IRC | 12:31 | |
*** ayogi has quit IRC | 12:31 | |
sdague | yeh | 12:33 |
*** nkorabli has joined #openstack-nova | 12:35 | |
*** Jack_Iv has quit IRC | 12:37 | |
sfinucan | Hmm, I've never even heard of slaac. It would appear I've not so much broken something as exposed existing broken behaviour. This is going to be fun to debug | 12:37 |
*** jaypipes is now known as leakypipes | 12:37 | |
* sfinucan has to run to a meeting, but will deep dive into that soon as he's back | 12:38 | |
leakypipes | alex_xu: well, I've been trying to get those traits in to os-traits here: https://review.openstack.org/#/c/448283/ | 12:39 |
leakypipes | alex_xu: but cdent and sean-k-mooney don't seem to care for the patch before it that splits out traits into different modules. | 12:39 |
leakypipes | alex_xu: I originally had the NIC traits added as a single patch but sean-k-mooney requested some refactoring before expanding the single const.py further. | 12:40 |
cdent | leakypipes: that's a bit strong, it's more like it's not what it says on the tin. what's in the tin is good enough if the label is changed. However the label does sound pretty nice. | 12:40 |
sean-k-mooney | leakypipes: im always causing trouble :) | 12:40 |
alex_xu | leakypipes: yea, i see, just thought we can begin to use those NIC traits in https://review.openstack.org/435954 | 12:40 |
*** mdrabe has joined #openstack-nova | 12:41 | |
leakypipes | alex_xu: you mean replace "tso" with "HW_NIC_OFFLOAD_TSO" in the spec? | 12:41 |
alex_xu | leakypipes: yea | 12:41 |
*** udesale has quit IRC | 12:42 | |
leakypipes | alex_xu: well, that's fine of course :) but I won't hold up the spec for that. we can always enforce that in the code. | 12:42 |
*** jdurgin has joined #openstack-nova | 12:42 | |
sean-k-mooney | alex_xu: we could definetly do that and assuming the network traits land before pike release we chan change the impentation to use them once they are merged | 12:43 |
alex_xu | leakypipes: yea, I also did ask the doc work to replace tso to 'HW_NIC_OFFLOAD_TSO', just thought when we put those NIC traits in the code, those should be standard trait. otherwise, we will let user transfer to the standard trait in the future | 12:43 |
sean-k-mooney | leakypipes: i dont thnik we nesicalliy have all the feature flag we would need in your initall patch but we can extend in follow up patches | 12:44 |
alex_xu | s/did ask/didn't ask/ | 12:44 |
alex_xu | oops | 12:44 |
alex_xu | sean-k-mooney: yea, in the internal implement that is totally ok. | 12:45 |
leakypipes | sean-k-mooney: sure, agreed. | 12:47 |
*** fengzhr has quit IRC | 12:48 | |
alex_xu | sean-k-mooney: +1 | 12:48 |
openstackgerrit | Silvan Kaiser proposed openstack/nova master: Switch Nova Quobyte volume driver to mount via systemd-run https://review.openstack.org/432344 | 12:48 |
sean-k-mooney | alex_xu: so do you want us to update the spec to reflect or just enforce it via the code review of the implentation of the feature? | 12:49 |
alex_xu | sean-k-mooney: i think we only update this line https://review.openstack.org/#/c/435954/11/specs/pike/approved/enable-sriov-nic-features.rst@222 | 12:50 |
*** david-lyle has quit IRC | 12:55 | |
*** Jack_Iv has joined #openstack-nova | 12:55 | |
*** esberglu has joined #openstack-nova | 12:55 | |
*** xyang1 has joined #openstack-nova | 12:56 | |
ralonsoh | alex_xu: hi | 12:59 |
ralonsoh | alex_xu: just for confirmation | 12:59 |
ralonsoh | alex_xu: when string values are read form libvirt, I need to normalize to os-traits values | 12:59 |
ralonsoh | alex_xu: these values will be stored in the DB | 12:59 |
alex_xu | ralonsoh: yea | 12:59 |
ralonsoh | alex_xu: and Neutron port will need to make the definition | 13:00 |
ralonsoh | alex_xu: https://review.openstack.org/#/c/435954/11/specs/pike/approved/enable-sriov-nic-features.rst@120 | 13:00 |
ralonsoh | alex_xu: using this normalized values | 13:00 |
ralonsoh | alex_xu: is that correct? | 13:00 |
alex_xu | ralonsoh: what does mean about neutron port will need to make the definition | 13:01 |
*** liangy has joined #openstack-nova | 13:02 | |
*** cdent has quit IRC | 13:02 | |
ralonsoh | alex_xu: I meant in https://review.openstack.org/#/c/435954/11/specs/pike/approved/enable-sriov-nic-features.rst@121, instead of writing low case value | 13:02 |
alex_xu | ralonsoh: yea | 13:02 |
ralonsoh | alex_xu: we need to write the normalized strings (defined in os-traits) | 13:02 |
ralonsoh | perfect! | 13:02 |
ralonsoh | alex_xu: I'll update the spec today | 13:02 |
alex_xu | ralonsoh: that is what i mean | 13:02 |
ralonsoh | and thanks! | 13:02 |
alex_xu | ralonsoh: thanks | 13:02 |
*** jpena|lunch is now known as jpena | 13:03 | |
*** mriedem has joined #openstack-nova | 13:06 | |
*** gouthamr has joined #openstack-nova | 13:08 | |
*** sree has joined #openstack-nova | 13:08 | |
mriedem | bauwser: you might want to take a look at this https://bugs.launchpad.net/nova/+bug/1675607 | 13:09 |
openstack | Launchpad bug 1675607 in OpenStack Compute (nova) "test_list_migrations_in_flavor_resize_situation fails with NoValidHost - AvailabilityZoneFilter returned 0 hosts" [Undecided,Confirmed] | 13:09 |
mriedem | ES is backed up so i'm not sure if it's a recent regression or not | 13:10 |
bauwser | mriedem: yup, saw you adding me | 13:10 |
bauwser | it's in my pipe | 13:10 |
*** tblakes has joined #openstack-nova | 13:10 | |
mriedem | well smoke'em if you got'em | 13:10 |
bauwser | :p | 13:11 |
*** edleafe is now known as figleaf | 13:12 | |
*** suresh12 has joined #openstack-nova | 13:14 | |
*** suresh12 has quit IRC | 13:18 | |
markus_z | trivial fix: https://review.openstack.org/#/c/449543/1 | 13:18 |
*** yamamoto has joined #openstack-nova | 13:19 | |
openstackgerrit | John Garbutt proposed openstack/nova-specs master: WIP: Add policy-remove-scope-checks spec https://review.openstack.org/433037 | 13:19 |
johnthetubaguy | sdague: attempt to apply the first few of your comments, and I am heading for lunch now, but I am curious if that looks better or worse ^ | 13:20 |
sdague | ok, I'll check post breakfast | 13:21 |
mriedem | johnthetubaguy: i think sdague summed up my issues nicely :) | 13:23 |
*** Jack_Iv has quit IRC | 13:24 | |
*** psachin has quit IRC | 13:25 | |
*** lucas-hungry is now known as lucasagomes | 13:27 | |
*** baoli has joined #openstack-nova | 13:28 | |
*** tblakes has quit IRC | 13:29 | |
*** gcb has joined #openstack-nova | 13:31 | |
*** lucasagomes is now known as lucas-brb | 13:35 | |
*** prateek has quit IRC | 13:36 | |
*** smatzek has quit IRC | 13:37 | |
*** cleong has joined #openstack-nova | 13:39 | |
*** Dinesh_Bhor has quit IRC | 13:39 | |
*** jamesdenton has joined #openstack-nova | 13:43 | |
*** andreas_s has quit IRC | 13:45 | |
*** kenperkins has joined #openstack-nova | 13:45 | |
*** awaugama has joined #openstack-nova | 13:46 | |
*** sree_ has joined #openstack-nova | 13:46 | |
*** sree_ is now known as Guest85728 | 13:46 | |
*** vladikr has joined #openstack-nova | 13:47 | |
*** sree has quit IRC | 13:48 | |
dansmith | mriedem: so that az bug | 13:49 |
mriedem | yes superdan | 13:49 |
dansmith | heh | 13:49 |
*** dansmith is now known as superdan | 13:49 | |
superdan | mriedem: after my change to persist the az properly in the instance, | 13:49 |
superdan | the scheduler will start keeping an instance in the same az it was booted in, | 13:49 |
*** mtanino has joined #openstack-nova | 13:49 | |
superdan | even if they didn't ask for one | 13:50 |
superdan | that's because of the cruft still left to cleanup with reqspec | 13:50 |
superdan | reqspec has what they requested, but instance stores what it was booted in, and we're not restoring the reqspec at the right place yet | 13:50 |
superdan | now, I think in practice this is fine, and we even discussed it prior to merging | 13:50 |
*** kenperkins has quit IRC | 13:50 | |
superdan | however, I think what is happening is, | 13:50 |
superdan | tempest creates a test az and adds the one compute to it in another test, | 13:51 |
superdan | and if that instance happens to land there while the az is in place, and is then removed, the instance won't schedule anywhere because we have now told nova that the az it wants doesn't exist anymore | 13:51 |
superdan | we == tempest | 13:51 |
superdan | if the tests run such that we don't get lucky there, then we're fine | 13:51 |
superdan | bauwser: ^ | 13:52 |
mriedem | let me see what the test does | 13:52 |
bauwser | sorry was distracted by some internal bug triaging :) | 13:52 |
mriedem | the az is random btw | 13:52 |
superdan | mriedem: right | 13:52 |
superdan | mriedem: the az comes from compute/admin/test_aggregates | 13:52 |
mriedem | http://git.openstack.org/cgit/openstack/tempest/tree/tempest/api/compute/admin/test_migrations.py#n42 | 13:53 |
*** links has quit IRC | 13:53 | |
superdan | right, no az stuff there | 13:53 |
*** dimtruck is now known as zz_dimtruck | 13:53 | |
*** zz_dimtruck is now known as dimtruck | 13:54 | |
mriedem | superdan: oh so the instance lands on the single compute which, because of a concurrently running test, is now in an AZ, so the instance in the test that fails is now in that temp AZ which on cleanup of the other unrelated test is removed | 13:54 |
bauwser | mriedem: superdan: so if there is no AZ asked when booting, the default is not set | 13:55 |
mriedem | so when we move the instance, it's in an AZ that is now gone b/c of the tempest cleanup? | 13:55 |
superdan | mriedem: that's what I'm thinking yeah | 13:55 |
bauwser | mriedem: that could be a reason yes | 13:55 |
mriedem | look here http://logs.openstack.org/62/449362/1/check/gate-tempest-dsvm-py35-ubuntu-xenial/ec959b4/console.html#_2017-03-24_00_00_55_563868 | 13:55 |
mriedem | there is an AZ test right at the same time | 13:55 |
*** awaugama has quit IRC | 13:56 | |
superdan | we need this cleanup to be done in order to ask for what they actually wanted: https://github.com/openstack/nova/blob/master/nova/conductor/tasks/migrate.py#L49-L55 | 13:56 |
bauwser | I was planning to do so next week | 13:56 |
bauwser | -ish | 13:57 |
bauwser | I could try to tackle that now | 13:57 |
superdan | hmm, | 13:58 |
superdan | looks like we got request_spec at init and we just overwrite it from_compontents? | 13:58 |
superdan | is that right? | 13:58 |
*** burt has joined #openstack-nova | 13:58 | |
sdague | mriedem or others, anyone want to merge in i18n deletes. I'm trying to keep no more than 2 open at a time just to not waste time on rebasing - https://review.openstack.org/#/c/448082/ | 13:58 |
*** awaugama has joined #openstack-nova | 13:58 | |
*** kenperkins has joined #openstack-nova | 13:58 | |
*** alexpilotti has quit IRC | 13:58 | |
mriedem | superdan: i tried to summarize in the bug | 13:59 |
*** alexpilotti has joined #openstack-nova | 13:59 | |
superdan | yeah, I think we should have that right there | 13:59 |
superdan | mriedem: okay I was going to, sorry | 13:59 |
bauwser | superdan: yup, I actually think we can directly use self.request_spec without needing to rehydrate | 13:59 |
superdan | I'll try | 14:00 |
bauwser | because it's useless to regeneate ity | 14:00 |
bauwser | lemme fire the drill | 14:00 |
bauwser | because some other move operations can have the same stuff | 14:00 |
bauwser | and here, it's resize | 14:00 |
bauwser | not live-mig | 14:00 |
bauwser | superdan: ^ | 14:00 |
bauwser | superdan: I'm cooking the patch | 14:01 |
superdan | we get it from the same place in both cases | 14:01 |
superdan | bauwser: about to submit | 14:01 |
*** lucas-brb is now known as lucasagomes | 14:01 | |
bauwser | superdan: okay, so if you cook, don't forget to add the resize case | 14:01 |
*** kaisers_ has joined #openstack-nova | 14:01 | |
*** smatzek has joined #openstack-nova | 14:01 | |
superdan | eh? | 14:01 |
superdan | it's in migratetask, same for both | 14:02 |
bauwser | oh snpa | 14:02 |
bauwser | I was thinking we were loooking at the *live* migrate Task | 14:03 |
bauwser | nvm then | 14:03 |
*** alexpilotti has quit IRC | 14:03 | |
bauwser | but I think we probably have the same for live-migration and rebuild | 14:03 |
*** felipemonteiro has joined #openstack-nova | 14:03 | |
*** dimtruck is now known as zz_dimtruck | 14:03 | |
bauwser | I'm just looking at that | 14:04 |
superdan | let me put this up to see if it breaks anything and/or appears to fix | 14:04 |
*** eharney has joined #openstack-nova | 14:04 | |
bauwser | okay | 14:05 |
bauwser | FWIW, live-migration is not having the same useless rehydratation | 14:05 |
bauwser | only if we have a not found spec | 14:05 |
*** kaisers_ has quit IRC | 14:05 | |
bauwser | but we can remove the conditional | 14:05 |
*** mdnadeem has quit IRC | 14:06 | |
superdan | yeah | 14:06 |
bauwser | so, I'm gonna fire a patch for that given we now have 100% of chances to have it | 14:06 |
superdan | alright | 14:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: remove i18n log markers from nova.api.* https://review.openstack.org/448082 | 14:06 |
mriedem | yay my sump pump is running every other minute | 14:07 |
mriedem | weeee | 14:07 |
superdan | mriedem: http://imgur.com/DWMGBJW | 14:07 |
*** dave-mccowan has joined #openstack-nova | 14:07 | |
mriedem | which is which? | 14:08 |
mriedem | blue is rain? | 14:08 |
superdan | seconds on the left, inches on the right | 14:08 |
superdan | runtime seconds per hour, that is | 14:08 |
superdan | oh and green is rain | 14:09 |
bauwser | interesting | 14:09 |
bauwser | we don't build houses this way | 14:09 |
bauwser | is that for collecting rain ? | 14:09 |
*** scottda has joined #openstack-nova | 14:09 | |
bauwser | because I have a drain running all around my house but the gravity does the rest :) | 14:10 |
bauwser | anyway | 14:10 |
* bauwser cooking a patch | 14:10 | |
superdan | bauwser: if you're below grade that doesn't work :) | 14:10 |
sdague | superdan: or that there is elevation changes | 14:10 |
bauwser | superdan: ah correct then | 14:11 |
sdague | the midwest water table being 1' below the surface and everything flat is quite a thing | 14:11 |
superdan | yeah | 14:11 |
bauwser | do you collect that into pipes, or do you spill the water in your garden ? | 14:12 |
openstackgerrit | Dan Smith proposed openstack/nova master: Remove legacy regeneration of RequestSpec in MigrationTask https://review.openstack.org/449640 | 14:12 |
mriedem | in my neighborhood, you wash it down the hill to the suckers at the bottom, | 14:12 |
superdan | bauwser: mine goes into the storm drain | 14:12 |
leakypipes | bauwser: spill. :) | 14:12 |
mriedem | which unfortunately is me and another guy after me | 14:12 |
bauwser | interesting | 14:12 |
bauwser | because yet another regulation here is to defend us spillinh | 14:13 |
mriedem | supposed to be graded to drain into catch baskets that pump it into a pond further down the way | 14:13 |
bauwser | but rather collecting all the rain into pipes that are transfered to a specific collecting tank | 14:13 |
bauwser | that's a rain network | 14:13 |
superdan | bauwser: == storm drain | 14:13 |
mriedem | sometimes i hear you get a drunken frenchman drown in one of those and then he clogs up the pipes | 14:14 |
superdan | hah | 14:14 |
mriedem | stories to scare your kids, | 14:14 |
mriedem | like ringing doorbells | 14:14 |
bauwser | hah | 14:14 |
bauwser | superdan: what will be the name of your branch for cleaning up the migration task ? I'd ideally put it on the same gerrit topic | 14:17 |
*** satyar_ has joined #openstack-nova | 14:17 | |
superdan | bauwser: the bug? see above ^ | 14:17 |
bauwser | superdan: cool | 14:18 |
*** satyar has quit IRC | 14:18 | |
*** alexpilotti has joined #openstack-nova | 14:20 | |
*** tuan_luong has joined #openstack-nova | 14:21 | |
*** zz_dimtruck is now known as dimtruck | 14:21 | |
*** nkrinner is now known as nkrinner_afk | 14:21 | |
*** tuanla_ has joined #openstack-nova | 14:21 | |
*** amoralej is now known as amoralej|lunch | 14:21 | |
mdbooth | mriedem: Thanks for sorting out the connect/disconnect thing | 14:22 |
mdbooth | ABCs don't do what we want though, unfortunately | 14:22 |
mdbooth | All an ABC does is ensure that subclasses implement abstract methods | 14:22 |
mdbooth | It doesn't actually do any checking of the signatures of those methods | 14:23 |
mdbooth | So... not all that useful tbh | 14:23 |
mriedem | mdbooth: why not? if you change the signature on an abstractmethod, and fail to adjust any classes that inherit from the ABC, they will blow up | 14:23 |
mriedem | mdbooth: i'm saying make the actual connect/disconnect_volume methods abstractmethods | 14:23 |
mdbooth | Case in point: RemoteFilesystemDriver is an ABC, and none of its subclasses have the correct signature for copy_file | 14:23 |
*** bnemec is now known as beekneemech | 14:23 | |
mdbooth | mriedem: Yeah, that's fine. But that will only assert that subclasses implement them | 14:24 |
mdbooth | There's no signature checking | 14:24 |
mdbooth | So it wouldn't catch this error | 14:24 |
mdbooth | Anyway, I agree that a test for this would be good, and probably useful in a few different places | 14:24 |
mdbooth | My first thought was to look for an existing tool, and I gave pylint a go | 14:25 |
mdbooth | However, pylint would be wildly impractical unfortunately. | 14:25 |
mdbooth | Getting a clean pylint job would be more work than getting python3 working, I think. | 14:25 |
*** david-lyle has joined #openstack-nova | 14:26 | |
mdbooth | So, I was considering writing some kind of introspection test for superclasses with abstract interfaces | 14:26 |
mdbooth | So you'd do something like: | 14:26 |
mdbooth | FSTest = SubclassCheckTest(SuperClassToTest) | 14:27 |
mdbooth | And it would generate you a test class | 14:27 |
mriedem | can't you scope pylint? | 14:27 |
mriedem | or whitelist? | 14:27 |
*** suresh12 has joined #openstack-nova | 14:27 | |
mdbooth | It all over the place | 14:27 |
*** vks1 has joined #openstack-nova | 14:27 | |
mdbooth | I disabled almost everything, and I still had 95% false positives | 14:28 |
*** Guest85728 has quit IRC | 14:29 | |
*** sree has joined #openstack-nova | 14:29 | |
mdbooth | It did find RemoteFilesystemDriver.copy_file for me | 14:30 |
mdbooth | Although in this case, somebody has clearly updated all the implementations and forgotten to update the superclass | 14:31 |
*** ralonsoh_ has joined #openstack-nova | 14:31 | |
nkorabli | Hi there! I noticed a multitenancy issue, here is a bug report: https://bugs.launchpad.net/nova/+bug/1675791 | 14:31 |
openstack | Launchpad bug 1675791 in OpenStack Compute (nova) "Instance created by demo user(non-admin), shelved by admin and unshelved by demo user --> ends up in error state " [Undecided,New] | 14:31 |
nkorabli | Need to know your opinions, to start fixing it! :) Thanks in advance! | 14:31 |
mriedem | ok i see what you mean about abstractmethod not checking the signature | 14:31 |
mriedem | that sucks | 14:31 |
mriedem | i just tested locally | 14:31 |
mdbooth | mriedem: Anyway, how about the testclass generator? | 14:31 |
mdbooth | Overkill? | 14:32 |
mriedem | nkorabli: we already talked about this the other day | 14:32 |
leakypipes | np | 14:32 |
mdbooth | I think we could use it in a few places | 14:32 |
nkorabli | mriedem: Hi there! | 14:32 |
mriedem | nkorabli: the error during unshelve wasn't due to the tenant | 14:32 |
mriedem | it was most likely due to a failure to spawn the instance during unshelve | 14:32 |
mriedem | which put the instance into ERROR state | 14:32 |
nkorabli | mriedem: right, we did I just tested it with pure openstack (stable/newton) in devstack environment - and I see this error as well. | 14:33 |
mriedem | nkorabli: i've invalidated the bug, | 14:33 |
mriedem | nkorabli: have you checked the logs for errors during unshelve? | 14:33 |
*** aunnam_ has joined #openstack-nova | 14:33 | |
mriedem | because there has to be an error in the logs if the instance is in error state | 14:34 |
*** ralonsoh has quit IRC | 14:34 | |
*** sree has quit IRC | 14:34 | |
*** amotoki has quit IRC | 14:35 | |
nkorabli | I actually haven't found anything useful in the logs, but let my check one more time. | 14:35 |
*** gszasz has quit IRC | 14:37 | |
*** alex_xu has quit IRC | 14:37 | |
*** hongbin has joined #openstack-nova | 14:37 | |
*** alex_xu has joined #openstack-nova | 14:38 | |
*** udesale has joined #openstack-nova | 14:38 | |
*** marst has quit IRC | 14:41 | |
*** vks1 has quit IRC | 14:42 | |
*** vladikr has quit IRC | 14:43 | |
*** amotoki has joined #openstack-nova | 14:45 | |
*** amotoki has quit IRC | 14:47 | |
*** fragatina has quit IRC | 14:47 | |
bauwser | superdan: mriedem: quick question | 14:49 |
*** marst has joined #openstack-nova | 14:49 | |
bauwser | superdan: mriedem: I'm about to clean up a bit of useless code in the conductor | 14:49 |
bauwser | superdan: mriedem: and I just notice that we do verify at every move operation if the affinity filters are present on the conductor side | 14:50 |
*** erhudy has quit IRC | 14:50 | |
*** vladikr has joined #openstack-nova | 14:50 | |
bauwser | superdan: mriedem: from my perspective, this is violating our policy to separate what's scheduler and what's conductor | 14:51 |
bauwser | if the operator disabled the affinity filters but had an instance that was previously booted by using an InstanceGroup, should we fail the move operation ? | 14:51 |
bauwser | my guts say no | 14:51 |
bauwser | johnthetubaguy: too ^ | 14:51 |
johnthetubaguy | maybe we shouldn't allow those filters to be disabled? | 14:52 |
*** tbachman has quit IRC | 14:52 | |
johnthetubaguy | its not 100% clear to me | 14:52 |
bauwser | well | 14:53 |
bauwser | disabling a filter is an operator thing | 14:53 |
bauwser | in case they use instance groups, then why they should disable that ? | 14:53 |
*** fragatina has joined #openstack-nova | 14:53 | |
bauwser | it's terrible for users | 14:53 |
johnthetubaguy | now you might want to disable instance groups, but that seems like it should be discoverable | 14:53 |
bauwser | because for example, say Bob created an instance and asked for this group A | 14:54 |
bauwser | then Max (operator) disabled the filters without asking Bob | 14:54 |
johnthetubaguy | as you can see, I am just a bit confused by the question really | 14:54 |
bauwser | then, the current situation is that if Bob wants to migrate its instance, it will be getting an exception | 14:54 |
bauwser | gibi: p | 14:54 |
johnthetubaguy | bob by default can't migrate his instance, so its a bit of an odd one for me | 14:55 |
johnthetubaguy | we should really just respect the filters, given the preferences | 14:55 |
bauwser | johnthetubaguy: https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L162-L163 | 14:55 |
*** haplo37 has quit IRC | 14:55 | |
johnthetubaguy | but seems like certain filters you shouldn't kill | 14:55 |
openstackgerrit | Vasyl Saienko proposed openstack/nova master: Implement interface attach/detach in ironic virt driver https://review.openstack.org/419975 | 14:56 |
johnthetubaguy | bauwser: thats just refreshing the list of instances in the group, at least I thought that was the intent there | 14:56 |
bauwser | johnthetubaguy: https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L311-L315 | 14:56 |
bauwser | johnthetubaguy: nope, not the instances | 14:56 |
johnthetubaguy | oh, I see | 14:56 |
johnthetubaguy | thats odd | 14:56 |
bauwser | johnthetubaguy: the InstanceGroup.hosts is set by the nodes having instances in there | 14:57 |
johnthetubaguy | do we fail to boot with the same things I guess? | 14:57 |
*** alexpilo_ has joined #openstack-nova | 14:57 | |
bauwser | johnthetubaguy: but it's a lazy-loadable field | 14:57 |
mriedem | bauwser: looks like you added that https://github.com/openstack/nova/commit/111a852e79f0d9e54228d8e2724dc4183f737397 | 14:57 |
*** cdent has joined #openstack-nova | 14:57 | |
*** jianghuaw-m has joined #openstack-nova | 14:57 | |
*** suresh12 has quit IRC | 14:57 | |
bauwser | mriedem: we did that in the past | 14:57 |
bauwser | mriedem: I just modified the callers | 14:58 |
*** vks1 has joined #openstack-nova | 14:58 | |
johnthetubaguy | bauwser: that does do what I said right? | 14:58 |
*** prateek has joined #openstack-nova | 14:58 | |
johnthetubaguy | bauwser: the bit we need in there is re-populating the up to date group https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L350 | 14:58 |
johnthetubaguy | bauwser: the other bits seem like nonsense for anything other than boot | 14:58 |
bauwser | johnthetubaguy: yup, we need to create those for boot | 14:58 |
*** alexpilotti has quit IRC | 14:58 | |
bauwser | johnthetubaguy: but when we move that instance, then we get the existing field from the Spec object | 14:59 |
johnthetubaguy | bauwser: I would split out the boot checks, and call them separately in the boot flow right? | 14:59 |
bauwser | johnthetubaguy: given group.hosts is the only mutable field, it's fine given it's a lazy-loadable | 14:59 |
*** tuanla_ has quit IRC | 14:59 | |
*** tuan_luong has quit IRC | 14:59 | |
johnthetubaguy | I have no idea what you mean | 14:59 |
*** lucasxu has joined #openstack-nova | 14:59 | |
johnthetubaguy | sorry, I got lost | 14:59 |
bauwser | johnthetubaguy: my question is more about having permission to remove that call https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L162-L163 | 14:59 |
*** tuan_luong has joined #openstack-nova | 14:59 | |
*** tuanla_ has joined #openstack-nova | 14:59 | |
johnthetubaguy | bauwser: I just said, thats really bad | 15:00 |
bauwser | johnthetubaguy: that's bad to what ? :) | 15:00 |
*** eharney has quit IRC | 15:00 | |
johnthetubaguy | bauwser: we need to update the group with the latest, but we don't want to do the boot time only checks | 15:00 |
*** tuanla_ has quit IRC | 15:00 | |
*** tuan_luong has quit IRC | 15:00 | |
*** eharney has joined #openstack-nova | 15:00 | |
bauwser | johnthetubaguy: we don't need to update the group info | 15:00 |
johnthetubaguy | bauwser: because of lazy loading? | 15:00 |
bauwser | johnthetubaguy: because the group info is made of 3 things | 15:00 |
bauwser | 2 can't be modified and the 3rd is lazy-loadable | 15:01 |
bauwser | right | 15:01 |
johnthetubaguy | but its saved into the json blob in the DB? | 15:01 |
bauwser | johnthetubaguy: if you see the code https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L162-L163 you will see that I don't update the Spec with that updated group already | 15:01 |
*** felipemonteiro has quit IRC | 15:01 | |
*** prateek has quit IRC | 15:01 | |
johnthetubaguy | I thought we had a bug where that list needed to be updated, because we persisted and out of date list | 15:01 |
*** prateek has joined #openstack-nova | 15:02 | |
johnthetubaguy | s/and/an/ | 15:02 |
*** alexpilo_ has quit IRC | 15:02 | |
bauwser | johnthetubaguy: that was fixed by https://github.com/openstack/nova/blob/master/nova/objects/instance_group.py#L282-L289 | 15:03 |
johnthetubaguy | I don't think we need the boot checks, I just through the filter params would need to be populated correctly, I guess I would have to go read more | 15:03 |
bauwser | I'm going to cut that call, and you could be reviewing it | 15:03 |
johnthetubaguy | bauwser: I am not convinced, but I guess you want some functional tests for that stuff really, then we can answer whats correct | 15:03 |
bauwser | johnthetubaguy: https://github.com/openstack/nova/commit/c48c1098cbcd7a9c7980d5fbe4668c38b16767f5 was missing a functional test but fixed the problem you mentioned | 15:04 |
mriedem | yeah seriously i'd write functional tests for anything we're removing | 15:05 |
*** haplo37 has joined #openstack-nova | 15:05 | |
mriedem | before removing it | 15:05 |
mriedem | because the unit tests just don't cut it for conductor <> scheduler interactions | 15:05 |
johnthetubaguy | what mriedem said, its safest | 15:05 |
*** jianghuaw-m has quit IRC | 15:05 | |
mriedem | as we've been seeing lately with a lot of regressions | 15:05 |
mriedem | i'm still working on one for another regression | 15:06 |
*** alexpilotti has joined #openstack-nova | 15:06 | |
mriedem | ooo and i think my regression test stumbled on another bug | 15:07 |
*** jianghuaw has joined #openstack-nova | 15:07 | |
mriedem | ha, the fake virt driver doesn't set the image size on snapshot | 15:08 |
mriedem | something like that | 15:08 |
bauwser | mriedem: okay fair enough | 15:09 |
mriedem | oh it's the api code, not the fake virt driver | 15:10 |
mriedem | wtf | 15:10 |
mriedem | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3355 | 15:10 |
mriedem | we don't set the size attribute when creating the image for a shelving operation? | 15:11 |
bauwser | mriedem: johnthetubaguy: which specific functional tests would you like to see covered ? | 15:11 |
bauwser | mriedem: johnthetubaguy: the fact that we get a fresh list of hosts every time? | 15:11 |
mriedem | bauwser: anything related to whatever you're removing, | 15:11 |
mriedem | which i guess is a resize/migrate with an instance in a server group? | 15:11 |
johnthetubaguy | yeah, that ^ | 15:11 |
cdent | leakypipes: I responded on your os-traits stuff. I hope that new comment makes what I mean a bit clear. Your response suggests that my initial comment missed you by a mile. | 15:11 |
bauwser | mriedem: that test is already in tree | 15:11 |
mriedem | bauwser: where? | 15:11 |
bauwser | functional/test_server_group out of mind | 15:12 |
*** jahsis has joined #openstack-nova | 15:12 | |
*** ssurana has joined #openstack-nova | 15:12 | |
bauwser | mriedem: but it's not covering the situation that I want to remove, ie. the fact that live-migration can fail if the filter is now disabled | 15:12 |
bauwser | mriedem: johnthetubaguy: https://github.com/openstack/nova/blob/master/nova/tests/functional/test_server_group.py#L367 | 15:13 |
*** sridharg has quit IRC | 15:14 | |
bauwser | mriedem: johnthetubaguy: I could be writing a test basically identical to https://github.com/openstack/nova/blob/master/nova/tests/functional/test_server_group.py#L367 that would disable the anti-affinity filter and show that the the move would fail ugly | 15:14 |
bauwser | mriedem: johnthetubaguy: so that I could remove that specific test in the cleanup patch I'm doing | 15:14 |
bauwser | wfy ? | 15:14 |
*** david-lyle has quit IRC | 15:15 | |
johnthetubaguy | just want something to prove the migrate works, and picks the correct host, or fails correctly, with and without your patch | 15:15 |
johnthetubaguy | maybe we have it already, thats cool | 15:16 |
johnthetubaguy | I guess we should have a test that fails with your bug, and we see it being fixed, ideally | 15:16 |
bauwser | johnthetubaguy: that's covering the migrate action, not the live-migrate action | 15:16 |
johnthetubaguy | bauwser: so we should have coverage for both right? | 15:16 |
bauwser | johnthetubaguy: yeah | 15:17 |
bauwser | okay, lemme see what I can do | 15:17 |
*** gjayavelu has joined #openstack-nova | 15:19 | |
*** ssurana has quit IRC | 15:19 | |
*** tuanla_ has joined #openstack-nova | 15:21 | |
*** tuan_luong has joined #openstack-nova | 15:21 | |
*** suresh12 has joined #openstack-nova | 15:23 | |
mriedem | hrm, what sets image size when we create a snapshot? does glance do it? | 15:25 |
mriedem | i can't see during a snapshot flow where we actually pass the size value to glacne | 15:26 |
mriedem | *glance | 15:26 |
*** aunnam_ has quit IRC | 15:26 | |
*** kaisers_ has joined #openstack-nova | 15:26 | |
*** udesale has quit IRC | 15:27 | |
*** jahsis has quit IRC | 15:27 | |
mriedem | ah it is glance https://developer.openstack.org/api-ref/image/v2/index.html?expanded=create-an-image-detail#images | 15:27 |
andreykurilin | mriedem: sorry, it looks like my IRC bouncer had crashed and stopped sending me any messages, so I missed your messages yesterday. | 15:28 |
mriedem | andreykurilin: that's ok, we just disabled the trigger crash dump functional tests in novaclient, | 15:28 |
mriedem | because they were timing out and causing the jobs to hang | 15:28 |
mriedem | andreykurilin: i feel like you had found or fixed something in those tests like that not too long ago, but can't recall | 15:28 |
*** READ10 has joined #openstack-nova | 15:29 | |
andreykurilin | mriedem: I remember that we had similar problems before, but I can recall what was done to fix it | 15:29 |
*** jaosorior has quit IRC | 15:30 | |
*** kaisers_ has quit IRC | 15:31 | |
*** slaweq_ has quit IRC | 15:32 | |
openstackgerrit | Anthony PERARD proposed openstack/nova master: Add exclusion list for tempest for a libvirt+xen job https://review.openstack.org/449687 | 15:33 |
*** eglynn has joined #openstack-nova | 15:33 | |
*** sneti has joined #openstack-nova | 15:34 | |
*** mlavalle has joined #openstack-nova | 15:35 | |
*** jdurgin has quit IRC | 15:37 | |
mriedem | anthonyper: some of that is old news | 15:38 |
mriedem | anthonyper: see d571e03b5b67a401e7774988a84df3bef16273ad | 15:38 |
mriedem | https://github.com/openstack/tempest/commit/d571e03b5b67a401e7774988a84df3bef16273ad | 15:38 |
mriedem | tempest doesn't hardcode vda anymore in test_volume_boot_pattern | 15:38 |
anthonyper | mriedem: Thanks, I'll tests that and change the patch. | 15:39 |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: Fix live-migrate usage of RequestSpec https://review.openstack.org/449690 | 15:40 |
openstackgerrit | Anthony PERARD proposed openstack/nova master: Add exclusion list for tempest for a libvirt+xen job https://review.openstack.org/449687 | 15:41 |
*** prateek has quit IRC | 15:42 | |
mriedem | johnthetubaguy: just fyi i added L137 in here https://etherpad.openstack.org/p/BOS-TC-vm-baremetal-platform | 15:43 |
johnthetubaguy | mriedem: ah, cool | 15:43 |
*** gyee has joined #openstack-nova | 15:45 | |
*** READ10 has quit IRC | 15:47 | |
*** yamahata has joined #openstack-nova | 15:48 | |
*** vladikr has quit IRC | 15:52 | |
*** amoralej|lunch is now known as amoralej | 15:52 | |
cdent | alex_xu: I assume you're not around anymore today, but wanted to check before I do some rebasing of our combined stacks of code | 15:52 |
*** suresh12 has quit IRC | 15:52 | |
*** aunnam_ has joined #openstack-nova | 15:53 | |
mriedem | johnthetubaguy: leakypipes: http://forumtopics.openstack.org/cfp/details/28 | 15:54 |
*** annegentle has joined #openstack-nova | 15:55 | |
mriedem | that might need to be two separate sessions | 15:55 |
mriedem | jgriffith: ildikov: Kevin_Zheng: ^ | 15:55 |
*** amotoki has joined #openstack-nova | 15:56 | |
sdague | johnthetubaguy: ok, I looked again at the new spec, I still thing you want to take it back even one step further. Let me throw a patch on top of it with an idea of tone. | 15:56 |
*** markus_z has quit IRC | 15:56 | |
ildikov | mriedem: thanks | 15:56 |
mriedem | johnthetubaguy: sdague: since you guys are going to be decided forum sessions, let me know if i should split http://forumtopics.openstack.org/cfp/details/28 into 2 sessions | 15:57 |
mriedem | *deciding | 15:57 |
mriedem | if they are 40 minute blocks, 20 minutes per topic is not enough | 15:57 |
ildikov | mriedem: the plan is 40 minutes long sessions | 15:57 |
*** ssurana has joined #openstack-nova | 15:57 | |
ildikov | mriedem: I would say let's split that to two | 15:57 |
sdague | mriedem: yeh, I'd suggest splitting | 15:58 |
mriedem | ok | 15:58 |
*** vishwanathj has quit IRC | 15:58 | |
ildikov | mriedem: johnthetubaguy: jgriffith: I got pointed to a multi-attach related forum session proposal: http://forumtopics.openstack.org/cfp/details/17 | 15:58 |
*** vishwanathj has joined #openstack-nova | 15:58 | |
mriedem | ildikov: yeah i already commented on it | 15:58 |
johnthetubaguy | mriedem: I don't get a vote in that, its some other sub team of the TC looking at that, I believe | 15:59 |
ildikov | mriedem: thanks | 15:59 |
*** krtaylor has joined #openstack-nova | 15:59 | |
johnthetubaguy | but yeah, better to split to start, and combine later if needed, I guess | 16:00 |
leakypipes | mriedem: agreed. | 16:00 |
mriedem | ok done http://forumtopics.openstack.org/ | 16:00 |
mriedem | huh, apparently if you rename it's a new topic | 16:02 |
mriedem | and you can't delete a topic | 16:02 |
mriedem | because now i have 3 | 16:02 |
mriedem | EmilienM: ttx: do you know how to delete http://forumtopics.openstack.org/cfp/details/28 ? | 16:02 |
EmilienM | mriedem: Edit and Delete | 16:02 |
mriedem | ah nice | 16:03 |
mriedem | thanks | 16:03 |
*** pcaruana has quit IRC | 16:03 | |
mriedem | leakypipes: ah i see you created http://forumtopics.openstack.org/cfp/details/26 so that probably covers what i was going to submit | 16:03 |
leakypipes | cdent: I'm sorry, I still don't understand what you're asking for. | 16:03 |
leakypipes | mriedem: ya | 16:04 |
*** udesale has joined #openstack-nova | 16:04 | |
mriedem | we probably need a separate topic for claims in the scheduler though, i'm not sure yet | 16:04 |
mriedem | but we didn't talk about it at the ptg | 16:04 |
leakypipes | mriedem: ++ | 16:04 |
cdent | leakypipes: maybe sean-k-mooney can take a stab at describing it? otherwise, if you're still curious I'll try a very quick spike at it after I rebase some stuff to fix merge conflicts after that float fix | 16:05 |
leakypipes | cdent: well, lemme try one more thing and push it. | 16:05 |
cdent | k | 16:06 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/449257 | 16:07 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Regression test for local delete with an attached volume https://review.openstack.org/449334 | 16:09 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Set 'size' during image create with FakeImageService https://review.openstack.org/449702 | 16:09 |
*** udesale has quit IRC | 16:09 | |
mriedem | sdague: ^ you'd probably appreciate that bottom change | 16:09 |
*** udesale has joined #openstack-nova | 16:09 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Regression test for local delete with an attached volume https://review.openstack.org/449334 | 16:11 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Set 'size' during image create with FakeImageService https://review.openstack.org/449702 | 16:11 |
mriedem | superdan: pep8 https://review.openstack.org/#/c/449640/ | 16:13 |
superdan | mriedem: yeah I have it fixed, as waiting for the run to finish before I pushed it up again | 16:13 |
superdan | and was on a call | 16:13 |
mriedem | ok | 16:13 |
sdague | johnthetubaguy: while I'm doing that, you want to hit this easy thing - https://review.openstack.org/#/c/448019/ | 16:13 |
superdan | here | 16:13 |
openstackgerrit | Dan Smith proposed openstack/nova master: Remove legacy regeneration of RequestSpec in MigrationTask https://review.openstack.org/449640 | 16:13 |
*** tjones has joined #openstack-nova | 16:14 | |
johnthetubaguy | sdague: got my head in the policy spec still, adding that to the queue | 16:15 |
*** Oku_OS is now known as Oku_OS-away | 16:15 | |
openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Allow PUT and POST without bodies https://review.openstack.org/447625 | 16:17 |
openstackgerrit | Chris Dent proposed openstack/nova master: placement: Enable attach traits to ResourceProvider https://review.openstack.org/376201 | 16:17 |
openstackgerrit | Chris Dent proposed openstack/nova master: placement: Add Traits API to placement service https://review.openstack.org/376200 | 16:17 |
openstackgerrit | Chris Dent proposed openstack/nova master: placement: Add Trait and TraitList objects https://review.openstack.org/376199 | 16:18 |
*** READ10 has joined #openstack-nova | 16:18 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove dead code https://review.openstack.org/449708 | 16:19 |
*** sneti has quit IRC | 16:20 | |
*** belmoreira has quit IRC | 16:21 | |
*** gouthamr has quit IRC | 16:23 | |
*** kaisers_ has joined #openstack-nova | 16:24 | |
*** tjones1 has joined #openstack-nova | 16:27 | |
*** tjones has quit IRC | 16:27 | |
*** kaisers_ has quit IRC | 16:29 | |
*** lpetrut has quit IRC | 16:30 | |
openstackgerrit | Anusha Unnam proposed openstack/nova master: Add description to policies in tenant_networks.py https://review.openstack.org/449714 | 16:30 |
*** aunnam_ has quit IRC | 16:31 | |
*** gouthamr has joined #openstack-nova | 16:32 | |
*** david-lyle has joined #openstack-nova | 16:33 | |
cdent | leakypipes: while waiting for some tests to run I made a hack to do demo what I was thinking of. it can probably cleaned up monstrously, but shows the idea: https://github.com/cdent/pony | 16:34 |
*** tbachman has joined #openstack-nova | 16:35 | |
leakypipes | cdent: lol, very similar to what I put together locally. | 16:35 |
cdent | leakypipes: ah, good, so we are understanding one another then? | 16:35 |
leakypipes | cdent: would seem so.\ | 16:36 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/446674 | 16:36 |
cdent | praise be or something | 16:36 |
*** aunnam_ has joined #openstack-nova | 16:37 | |
*** Jack_Iv has joined #openstack-nova | 16:38 | |
openstackgerrit | Sean Dague proposed openstack/nova-specs master: New intro https://review.openstack.org/449722 | 16:40 |
sdague | johnthetubaguy: what about something like that? | 16:40 |
*** aunnam_ has quit IRC | 16:42 | |
openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Idempotent PUT /resource_classes/{name} https://review.openstack.org/448791 | 16:42 |
*** Apoorva has joined #openstack-nova | 16:42 | |
*** Apoorva has quit IRC | 16:42 | |
*** felipemonteiro has joined #openstack-nova | 16:42 | |
*** Apoorva has joined #openstack-nova | 16:42 | |
*** felipemonteiro_ has quit IRC | 16:43 | |
*** vladikr has joined #openstack-nova | 16:43 | |
johnthetubaguy | sdague: looking | 16:46 |
*** fragatina has quit IRC | 16:46 | |
*** mlakat has quit IRC | 16:47 | |
johnthetubaguy | sdague: thanks I will roll that into the patch I have cooking at the moment | 16:48 |
*** aarefiev is now known as aarefiev_afk | 16:49 | |
*** kaisers_ has joined #openstack-nova | 16:52 | |
*** kaisers_ has quit IRC | 16:52 | |
*** kaisers_ has joined #openstack-nova | 16:52 | |
*** psachin has joined #openstack-nova | 16:56 | |
*** sridharg has joined #openstack-nova | 16:57 | |
*** yamahata has quit IRC | 17:00 | |
*** gouthamr has quit IRC | 17:01 | |
tojuvone | johnthetubaguy, Hi I had other things going like floorball. Looks that somehow I did not receive your comments in the patch. | 17:02 |
johnthetubaguy | tojuvone: added a follow on patch, but I don't really like my ideas in there now, after catch up with sdague on the direction he was suggesting before | 17:04 |
*** gouthamr has joined #openstack-nova | 17:05 | |
tojuvone | johnthetubaguy, ok, thanks | 17:05 |
*** udesale has quit IRC | 17:06 | |
openstackgerrit | Anthony PERARD proposed openstack/nova master: Add exclusion list for tempest for a libvirt+xen job https://review.openstack.org/449687 | 17:06 |
*** kaisers_ has quit IRC | 17:07 | |
*** tjones has joined #openstack-nova | 17:09 | |
*** tjones1 has quit IRC | 17:10 | |
*** Jack_Iv has quit IRC | 17:14 | |
*** catintheroof has joined #openstack-nova | 17:14 | |
*** catintheroof has quit IRC | 17:15 | |
*** Jack_Iv has joined #openstack-nova | 17:15 | |
*** nkorabli has quit IRC | 17:15 | |
*** catintheroof has joined #openstack-nova | 17:15 | |
*** nkorabli has joined #openstack-nova | 17:16 | |
*** nkorabli_ has joined #openstack-nova | 17:17 | |
*** nkorabli has quit IRC | 17:17 | |
*** ralonsoh_ has quit IRC | 17:17 | |
*** nkorabli_ has quit IRC | 17:18 | |
*** yamamoto has quit IRC | 17:19 | |
*** unicell has quit IRC | 17:19 | |
openstackgerrit | Anusha Unnam proposed openstack/nova master: Add description to policies in simple_tenant_usage.py https://review.openstack.org/449742 | 17:22 |
*** aunnam_ has joined #openstack-nova | 17:22 | |
*** nkorabli has joined #openstack-nova | 17:26 | |
EmilienM | can we nova ephemeral disk using rbd backend be encrypted with key manager like Barbican? I know it's doable with LVM but not sure about rbd | 17:27 |
cdent | BobBall_: is this still a thing: https://review.openstack.org/#/c/394857/ | 17:29 |
*** vks1 has quit IRC | 17:32 | |
*** lucasxu has quit IRC | 17:36 | |
*** annegentle has quit IRC | 17:36 | |
*** yamahata has joined #openstack-nova | 17:36 | |
*** vks1 has joined #openstack-nova | 17:36 | |
*** marst has quit IRC | 17:37 | |
*** dimtruck is now known as zz_dimtruck | 17:38 | |
tojuvone | johnthetubaguy, sdague, bauwser Thanks and sorry if wasted your time around the host maintenance. | 17:39 |
*** derekh has quit IRC | 17:40 | |
cfriesen | when running "openstack server migrate" will that do a cold migration? If so, is there any way to do a live migration without specifying the destination compute node? | 17:41 |
leakypipes | cdent, figleaf, alex_xu, sean-k-mooney: OK, try this on for size: https://review.openstack.org/448282 and https://review.openstack.org/448283 | 17:41 |
sdague | tojuvone: I mostly don't want to waste your time iterating here if we're not going to do it | 17:41 |
sdague | and I feel like we said we weren't going to do this a while ago | 17:41 |
*** mtanino has quit IRC | 17:43 | |
tojuvone | sdague, Yes, agree | 17:43 |
*** lucasagomes is now known as lucas-afk | 17:44 | |
johnthetubaguy | cfriesen: do you try passing host=None or null? it might be an openstack client limitation (https://developer.openstack.org/api-ref/compute/?expanded=live-migrate-server-os-migratelive-action-detail#live-migrate-server-os-migratelive-action) | 17:44 |
*** unicell has joined #openstack-nova | 17:45 | |
*** ltomasbo is now known as ltomasbo|away | 17:45 | |
*** suresh12 has joined #openstack-nova | 17:45 | |
johnthetubaguy | tojuvone: sdague: I agree it probably makes sense for OpenStack to support that use case, its just the preferred implementation/architecture has 99% or 100% of the code changes outside of Nova. | 17:46 |
*** suresh12 has quit IRC | 17:46 | |
tojuvone | sdague, good you stop it there again and can focus doing just what talked already back in Austin without wasting anybody time on something more | 17:46 |
*** suresh12 has joined #openstack-nova | 17:46 | |
johnthetubaguy | what we said in austin was? | 17:47 |
*** vks1 has quit IRC | 17:47 | |
*** rebase has joined #openstack-nova | 17:47 | |
tojuvone | Well, if I recall was around to have something as simple as linking | 17:48 |
openstackgerrit | Anusha Unnam proposed openstack/nova master: Add description to nova/policies/shelve.py https://review.openstack.org/449763 | 17:48 |
sean-k-mooney | leakypipes: that looks really good to me. | 17:49 |
tojuvone | Everytim I just touched the review it went bigger and bigger | 17:49 |
*** unicell has quit IRC | 17:49 | |
leakypipes | sean-k-mooney: that's more in-line to what you were envisioning? | 17:49 |
sean-k-mooney | leakypipes: ya it is | 17:49 |
*** tesseract has quit IRC | 17:50 | |
johnthetubaguy | tojuvone: right, I am not sure the link is useful enough by its-self, disabled host probably is enough for the state in Nova. | 17:50 |
*** unicell has joined #openstack-nova | 17:50 | |
openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Split api-ref topics per file https://review.openstack.org/449764 | 17:51 |
openstackgerrit | Andrey Volkov proposed openstack/nova master: [WIP] Add inventories https://review.openstack.org/449765 | 17:51 |
sean-k-mooney | leakypipes: i still need to fully read trough the register and symbolize function implementations but while its a little more complicated then just a single files with hand coded constances i think is a nicer approch | 17:51 |
*** alexpilotti has quit IRC | 17:52 | |
sean-k-mooney | leakypipes: hum they are even simpler then i taught | 17:52 |
leakypipes | sean-k-mooney: yeah, definitely not rocket science :) | 17:52 |
tojuvone | johnthetubaguy, if link is set, you know you should read it, if not system is up-to-date | 17:52 |
*** alexpilotti has joined #openstack-nova | 17:52 | |
cfriesen | johnthetubaguy: looks like openstackclient is fubar'd. there's no way to do a live migration without specifying the dest, and the help text says the default is shared but it's actually defaulting to block. | 17:53 |
cdent | leakypipes: I've left comments on both. acceptable as is, but still a bit noisy ;) | 17:53 |
tojuvone | but yes if it is always set, it doesn't help much, but know where to look more detailed info | 17:53 |
leakypipes | cdent: responded. | 17:53 |
figleaf | leakypipes: heading out soon, so only a quick perusal so far. I think this is a step closer to what I envisioned, but it still requires more hardcoding than I imagined | 17:53 |
*** felipemonteiro_ has joined #openstack-nova | 17:54 | |
figleaf | IOW, auto-discovery of the modules and packages, vs. spelling them out | 17:54 |
*** zz_dimtruck is now known as dimtruck | 17:54 | |
leakypipes | figleaf: k. well, I'm happy to check out alternative approaches if you want to hack together something this weekend? | 17:54 |
cdent | leakypipes: I think a list (without the register) woud make things a lot easier to read: the focus would be on the info (and the associated comments) rather than the code | 17:54 |
leakypipes | cdent: meh, maybe? :) | 17:55 |
cdent | it would be more pythonic :) | 17:55 |
*** jpena is now known as jpena|off | 17:55 | |
*** yamamoto has joined #openstack-nova | 17:56 | |
*** ltomasbo|away is now known as ltomasbo | 17:56 | |
figleaf | leakypipes: ok, don't know if I'll have time, but by Monday fo sho | 17:56 |
*** baoli has quit IRC | 17:56 | |
sdague | tojuvone: so... I'm not sure if this helps you at all. But I did a quick exercise this morning of how I was imaging doing these flows outside of nova - https://etherpad.openstack.org/p/host-maintenance-not-in-nova | 17:58 |
*** huanxie has quit IRC | 17:58 | |
*** rebase has quit IRC | 17:59 | |
sdague | it really feels like there is a need for a maintenance/status system which users can poll / subscribe to, but I think it lives on it's own | 17:59 |
*** rebase has joined #openstack-nova | 18:00 | |
*** huanxie has joined #openstack-nova | 18:00 | |
*** suresh12 has quit IRC | 18:00 | |
*** felipemonteiro_ has quit IRC | 18:00 | |
*** jianghuaw has quit IRC | 18:01 | |
*** marst has joined #openstack-nova | 18:01 | |
sean-k-mooney | leakypipes: im just heading home but ill take a look at it again and play with it over the weekend. | 18:01 |
*** annegentle has joined #openstack-nova | 18:01 | |
leakypipes | sean-k-mooney: cool, thanks! | 18:02 |
johnthetubaguy | cfriesen: we need to get osc onto the latest microversion, where we default to auto detecting if we need to do block migration or not | 18:02 |
johnthetubaguy | cfriesen: among other things! | 18:02 |
*** Jack_Iv_ has joined #openstack-nova | 18:02 | |
*** suresh12 has joined #openstack-nova | 18:02 | |
sean-k-mooney | leakypipes: cdent on the array vs register i really dont know which i prefer honestly, the register feels a bit like macrocs in c so it make complete sense to me but it may not be the most pythonic approch not sure if an array would be better though. as register could be extended to allow inline documentation | 18:03 |
cfriesen | johnthetubaguy: yeah, for sure. | 18:04 |
*** Jack_Iv has quit IRC | 18:04 | |
sean-k-mooney | i think i would be fine with either though as long as we dont have a single file that defines everything | 18:04 |
cdent | sean-k-mooney: yeah, I think if you're C-oriented it makes good sense, but from a python standpoint it looks like a whole lot of boilerplate. A list (with comments on each item as now) would read well. | 18:05 |
cdent | mostly I don't want to type register when I come along to add some traits ;) | 18:05 |
cdent | but yeah, it's reasonably fine as is | 18:05 |
*** sridharg has quit IRC | 18:06 | |
*** Guest93689 has quit IRC | 18:06 | |
*** ltomasbo is now known as ltomasbo|away | 18:07 | |
*** baoli has joined #openstack-nova | 18:07 | |
*** kaisers_ has joined #openstack-nova | 18:07 | |
tojuvone | sdague, thanks, I will take a look. Just home alone with 3 kids, Friday evening at 8 :) | 18:10 |
sdague | yep, enjoy :) | 18:10 |
*** alexpilotti has quit IRC | 18:10 | |
*** kaisers_ has quit IRC | 18:12 | |
*** ssurana has quit IRC | 18:12 | |
*** figleaf is now known as edleafe | 18:12 | |
*** mtanino has joined #openstack-nova | 18:13 | |
cdent | see everyone in a week, gonna take a few days | 18:15 |
* cdent waves | 18:15 | |
*** cdent has quit IRC | 18:15 | |
* johnthetubaguy waves back | 18:17 | |
*** yamamoto has quit IRC | 18:19 | |
superdan | mriedem: do you want to recheck this a few times or slam it in? https://review.openstack.org/#/c/449640/ | 18:20 |
*** mvk has quit IRC | 18:23 | |
mriedem | looking | 18:23 |
mriedem | let's do it...meow | 18:23 |
superdan | heh, okay | 18:24 |
mriedem | got my landscaping buddy on the way over to triage the mini washout | 18:24 |
mriedem | stopped by ace, the helpful hardware place, on the way home from lunch to stop up on gutter extenders | 18:24 |
mriedem | booya! | 18:24 |
mriedem | *stock up | 18:25 |
superdan | haha | 18:25 |
*** sneti has joined #openstack-nova | 18:25 | |
mriedem | just trying to keep this dump afloat | 18:27 |
*** tbachman has quit IRC | 18:28 | |
*** ociuhandu has quit IRC | 18:29 | |
sdague | are you collecting animals 2 by 2 yet? | 18:29 |
mriedem | close | 18:29 |
mriedem | i'll send you a picture | 18:29 |
melwitt | ace is the place with the helpful hardware folks | 18:30 |
mriedem | right | 18:30 |
mriedem | exactly | 18:30 |
mriedem | the guy that helped me, his name tag said "Lon" and he was missing some teeth | 18:30 |
mriedem | but god damn did he know a thing or two about downspouts | 18:30 |
melwitt | perfect | 18:31 |
mriedem | and the legality of pumping water into the city line | 18:31 |
mriedem | wink wink thanks lon | 18:31 |
sdague | heh | 18:33 |
*** kaisers_ has joined #openstack-nova | 18:33 | |
*** kaisers_ has quit IRC | 18:34 | |
*** kaisers_ has joined #openstack-nova | 18:35 | |
openstackgerrit | Anusha Unnam proposed openstack/nova master: Add keypairs field to InstancePayload https://review.openstack.org/419730 | 18:37 |
mriedem | nkorabli: in https://bugs.launchpad.net/nova/+bug/1675791 the error in the conductor log shows that the image used to unshelve the instance can't be found | 18:37 |
openstack | Launchpad bug 1675791 in OpenStack Compute (nova) "Instance created by demo user(non-admin), shelved by admin and unshelved by demo user --> ends up in error state " [Undecided,Invalid] | 18:37 |
mriedem | so was the image deleted? | 18:38 |
nkorabli | mriedem: it's just got an error state | 18:38 |
mriedem | nkorabli: you're hitting htis https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L665 | 18:38 |
nkorabli | so is it a bug? | 18:39 |
mriedem | no | 18:39 |
mriedem | nkorabli: not if you deleted the snapshot image | 18:39 |
*** kaisers_ has quit IRC | 18:39 | |
mriedem | when you shelve an instance, the compute API creates a snapshot of the instance: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3355 | 18:39 |
nkorabli | look into the second screenshot I attached, you can see all the command I run and status of the instance | 18:40 |
mriedem | that gets stored in the instance metadata when shelving on the compute https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4326 | 18:40 |
nkorabli | I don't think I deleted any snapshot | 18:40 |
mriedem | when you unshelve, conductor looks up the snapshot image from that metadata https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L656 | 18:40 |
mriedem | and would use that image to recreate the instance on another compute | 18:41 |
*** tbachman has joined #openstack-nova | 18:41 | |
*** lpetrut has joined #openstack-nova | 18:41 | |
mriedem | you're hitting a problem where the snapshot image ID can't be found | 18:41 |
mriedem | for the shelved instance | 18:41 |
openstackgerrit | Anusha Unnam proposed openstack/nova master: Add keypairs field to InstancePayload https://review.openstack.org/419730 | 18:41 |
mriedem | nkorabli: do you have access to the database? | 18:41 |
mriedem | i would check the glance database (or api i guess) for the snapshot image with that id in the error | 18:42 |
mriedem | the 52d95c... id | 18:42 |
nkorabli | I can check, I tested that it all with devstack | 18:42 |
mriedem | did you unshelve before the instance was completely marked as 'shelved_offloaded'? | 18:42 |
mriedem | these are async operations | 18:43 |
nkorabli | nope | 18:43 |
mriedem | your command screenshot doesn't show the unshelve command you ran | 18:43 |
nkorabli | take a look at the second screenshot I attached, I do a check after every action - to see what is the state of instance | 18:44 |
mriedem | oh wait a minute, | 18:44 |
nkorabli | hmmm | 18:44 |
mriedem | i bet i know the issue, | 18:44 |
mriedem | you shelved as one user, | 18:44 |
mriedem | so the snapshot image only has access from that user, | 18:44 |
mriedem | so when you go to unshelve, the unshelve user context doesn't have access to the private snapshot image | 18:44 |
mriedem | and you get a 404 | 18:44 |
*** lpetrut has quit IRC | 18:44 | |
nkorabli | Yeah, I described this in the bug description | 18:45 |
nkorabli | I mean, that snapshot is stored under admin | 18:45 |
mriedem | yeah sorry i missed that | 18:45 |
mriedem | just connected those dots :) | 18:45 |
nkorabli | no problems :) it's always good to ask questions and double check :) | 18:45 |
nkorabli | So, I suppose it's a bug | 18:46 |
mriedem | i believe the admin user can give membership access to the demo user so they can use the image | 18:46 |
mriedem | it may be a bug in nova that we aren't using the instance owner for the image | 18:46 |
nkorabli | I just want to find the right workflow - like if it's shelved by admin, than demo user shoudn't be able to unshelve it? or not? | 18:47 |
mriedem | i'd need to see what we do for snapshot, since it's a similar case, | 18:49 |
mriedem | if the admin snapshots a demo user's instance, can the demo user access that snapshot image | 18:49 |
mriedem | it's slightly different though because the demo user doesn't need to really care about that snapshot image, they may never need it, | 18:49 |
mriedem | but for unshelve, the instance is tied to it | 18:50 |
*** lucasxu has joined #openstack-nova | 18:50 | |
*** burt has quit IRC | 18:50 | |
nkorabli | yeaaah :) it's confusing a bit | 18:51 |
jroll | mriedem: I've got $20 on that behavior coming from some forensics use case | 18:54 |
mriedem | jroll: like, murder? | 18:55 |
*** gjayavelu has quit IRC | 18:55 | |
jroll | maybe! | 18:55 |
jroll | all sorts of crime, really | 18:55 |
*** Jack_Iv_ has quit IRC | 18:55 | |
*** Jack_Iv has joined #openstack-nova | 18:56 | |
*** Jack_Iv has quit IRC | 18:57 | |
*** Jack_Iv has joined #openstack-nova | 18:57 | |
*** rebase has quit IRC | 18:58 | |
*** psachin has quit IRC | 18:58 | |
*** adisky_ has quit IRC | 18:59 | |
*** crushil has joined #openstack-nova | 18:59 | |
*** mvk has joined #openstack-nova | 19:00 | |
*** felipemonteiro_ has joined #openstack-nova | 19:01 | |
mriedem | i've got to say i'm not following the CIS angle to this | 19:02 |
mriedem | is that some kind of michigander joke? | 19:02 |
*** Jack_Iv has quit IRC | 19:02 | |
*** lpetrut has joined #openstack-nova | 19:03 | |
nkorabli | mriedem: I also realized, that I have not attached the whole list of commands I ran. Updated it | 19:03 |
*** READ10 has quit IRC | 19:04 | |
*** avolkov has quit IRC | 19:07 | |
openstackgerrit | Sujitha proposed openstack/nova master: [WIP] Add BDM to InstancePayload https://review.openstack.org/448779 | 19:07 |
openstackgerrit | Anusha Unnam proposed openstack/nova master: Add description to policies in services.py https://review.openstack.org/449782 | 19:10 |
*** tuan_luong has quit IRC | 19:10 | |
*** tuanla_ has quit IRC | 19:10 | |
openstackgerrit | Sujitha proposed openstack/nova master: [WIP] Add BDM to InstancePayload https://review.openstack.org/448779 | 19:11 |
*** crushil has quit IRC | 19:11 | |
*** abalutoiu_ has joined #openstack-nova | 19:13 | |
mriedem | it looks like when we create a snapshot image, we set is_public=False, which for glance v2 is visibility=private | 19:14 |
mriedem | looking at the image api docs, the default visibility is shared | 19:14 |
mriedem | which means we could add the instance owner to the snapshot as a member | 19:14 |
mriedem | i start to get totally lost when talking about image membership, and the image.owner value | 19:15 |
mriedem | because i believe it's all configurable in glance to behave differently | 19:15 |
mriedem | mordred: ^ i'm sure you've experienced this? | 19:15 |
*** abalutoiu has quit IRC | 19:15 | |
mriedem | and the image member has to 'accept' membership before they can see the image | 19:16 |
nkorabli | but maybe demo user just shouldn't have permission to unshelve it once admin shelved it? I guess it make sense | 19:17 |
*** smatzek has quit IRC | 19:17 | |
*** yamamoto has joined #openstack-nova | 19:17 | |
mriedem | the default policy on shelve and unshelve is admin or owner | 19:17 |
mriedem | so if the admin shelves my instance, i as the owner should still be able to unshelve it | 19:17 |
nkorabli | when demo user is an operator, for example and admin is aware of the resources and stuff.. | 19:18 |
mriedem | then idk, i guess restrict the policy on unshelve to be admin-only | 19:18 |
mriedem | but then why shelve at all? | 19:18 |
nkorabli | well, shelving is a mystery thing for me. As I would say it's kind of a rudiment.. I maybe wrong here :) | 19:20 |
*** erhudy has joined #openstack-nova | 19:20 | |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: config drive https://review.openstack.org/409404 | 19:22 |
nkorabli | but basically, it is maybe useful when you need to save resources.. Like - this VM won't be used for next week/month, but then you will need it, so you shelve and unshelve it... But I am not sure about it either. | 19:22 |
mriedem | well that's the idea yeah | 19:23 |
mriedem | why the admin would do it though, i'm not sure | 19:24 |
*** smatzek has joined #openstack-nova | 19:24 | |
mordred | mriedem: looking | 19:25 |
*** yamamoto has quit IRC | 19:25 | |
*** felipemonteiro_ has quit IRC | 19:25 | |
mordred | mriedem: I have not played with shared images yet, no - although I'm starting to feel like maybe I shoud ... | 19:26 |
*** sneti has quit IRC | 19:26 | |
mriedem | nkorabli: see if this makes sense https://bugs.launchpad.net/nova/+bug/1675791/comments/10 | 19:26 |
openstack | Launchpad bug 1675791 in OpenStack Compute (nova) "Instance created by demo user(non-admin), shelved by admin and unshelved by demo user --> ends up in error state " [Undecided,Invalid] | 19:26 |
mriedem | but i think image membership is what we need | 19:26 |
mriedem | basically, if the admin shelves a user's instance, the admin owns the image, but the instance user owner needs to be a member on the share dimage, | 19:26 |
mriedem | *shared image | 19:26 |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #3: TaskFlow https://review.openstack.org/438729 | 19:26 |
mriedem | so the instance user can later unshelve the instance, | 19:26 |
*** abalutoiu has joined #openstack-nova | 19:27 | |
mriedem | the docs say an image member can't see the image when listing images until they accept the membership, | 19:27 |
mriedem | but they can GET the image if they know the specific ID | 19:27 |
mriedem | which we do in the unshelve case | 19:27 |
mriedem | nkorabli: i think that's the fix | 19:27 |
*** Jack_Iv has joined #openstack-nova | 19:27 | |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #4: full flavor https://review.openstack.org/391288 | 19:28 |
*** nic has joined #openstack-nova | 19:28 | |
*** sivak has joined #openstack-nova | 19:28 | |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: console https://review.openstack.org/409402 | 19:28 |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189 | 19:29 |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: config drive https://review.openstack.org/409404 | 19:29 |
efried | adreznec esberglu The whole pile is ready for subteam +1s again. | 19:30 |
*** abalutoiu_ has quit IRC | 19:30 | |
efried | Got up to cfg_drv this time. | 19:30 |
efried | Will update the etherpad accordingly. | 19:30 |
*** crushil has joined #openstack-nova | 19:30 | |
esberglu | efried: ack | 19:30 |
efried | (mriedem I'm gonna keep the bottom one in "ready for your review" section - changes trivial since last subteam +1) | 19:30 |
*** cleong has quit IRC | 19:37 | |
*** crushil has quit IRC | 19:38 | |
*** sneti has joined #openstack-nova | 19:44 | |
*** aunnam_ has quit IRC | 19:46 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021 | 19:46 |
nkorabli | mriedem: alright! I see. Still think that if it's shelved by admin - user shouldn't be able to unshelve it, though :) But it's kind of a bikeshed probablu | 19:46 |
nkorabli | *probably | 19:46 |
nkorabli | so should I change the ticket status? | 19:47 |
mriedem | nkorabli: in that case, i'd ask in the dev and operators mailing list since this is a latent issue | 19:47 |
mriedem | nkorabli: i'm genuinely curious what operators think about this | 19:47 |
melwitt | if the instance is owned by the user, I don't see why they shouldn't be able to unshelve it, no matter who shelved it | 19:48 |
*** vladikr has quit IRC | 19:48 | |
mriedem | melwitt: i agree | 19:48 |
mriedem | nkorabli: do you want to send that email or should i? | 19:48 |
nkorabli | mriedem: Agree, it make sense | 19:48 |
*** gcb has quit IRC | 19:49 | |
nkorabli | mriedem: I can do this, just may need your help if someone won't get the idea.. | 19:49 |
*** kaisers_ has joined #openstack-nova | 19:50 | |
nkorabli | just don't have any experience with mailing lists.. Is there any requirements of how I have to ask questions there? | 19:51 |
*** slaweq has quit IRC | 19:52 | |
*** annegentle has quit IRC | 19:53 | |
*** slaweq has joined #openstack-nova | 19:53 | |
mriedem | no, just state the problem and proposed solution, and see if anyone has a problem with that | 19:53 |
mriedem | ask in the openstack-dev and openstack-operators mailing lists, and prefix the subject with [nova] so it filters properly | 19:53 |
*** liverpooler has quit IRC | 19:55 | |
melwitt | a use case I can invent for why an admin would shelve something is if they need to free up some resources to do something temporarily and might leave it up to the instance owners to unshelve their stuff later | 19:55 |
*** kaisers_ has quit IRC | 19:57 | |
openstackgerrit | John Garbutt proposed openstack/nova-specs master: WIP: Add policy-remove-scope-checks spec https://review.openstack.org/433037 | 19:58 |
melwitt | or maybe if admin notices X instances have been idle for Y days, shelve those instances and users have a grace period to unshelve, else their instances will be deleted by admin. I dunno | 19:58 |
*** slaweq has quit IRC | 19:58 | |
mriedem | we used to have an auto shutdown thing in our internal dev cloud | 19:58 |
mriedem | where after 2 weeks your vm was shutdown | 19:58 |
mriedem | some of that was tied to licenses on the os i think | 19:59 |
*** kaisers_ has joined #openstack-nova | 19:59 | |
mriedem | if you were using a vm for longer than 2 weeks we had to register it for internal compliance audits and such | 19:59 |
nkorabli | I guess there is some shelve offload time option? Like it will be automatically destroyed after some period of time, or not? | 19:59 |
mriedem | nkorabli: yes, by default it offloads immediately | 19:59 |
mriedem | offload == delete the guest from the hypervisor | 19:59 |
mriedem | so when you unshelve, we have to build the guest again on another compute | 20:00 |
nkorabli | Ohh... I see! I wasn't sure what the difference between 'shelved' and 'shelved_offloaded'. | 20:00 |
nkorabli | Cool | 20:01 |
melwitt | yeah, but shelved instances still take up quota. so deleting them while they're offloaded would free up quota for others in the tenant | 20:01 |
melwitt | which reminds me, I need to keep an eye on that for how it works with counting | 20:03 |
*** mlavalle has quit IRC | 20:03 | |
nkorabli | mriedem: Thanks a lot for your attention! :) Will send an e-mail today or tomorrow morning. | 20:03 |
mriedem | nkorabli: np, thanks for persisting on this one | 20:04 |
*** Jack_Iv has quit IRC | 20:05 | |
*** slaweq has joined #openstack-nova | 20:06 | |
*** eglynn has quit IRC | 20:07 | |
*** eharney has quit IRC | 20:12 | |
jroll | mriedem: sorry, I was being half serious about the forensics thing - i.e. that behavior being a feature for an admin taking a snapshot for purposes of criminal investigation or whatever | 20:13 |
*** kaisers_ has quit IRC | 20:14 | |
*** annegentle has joined #openstack-nova | 20:15 | |
mriedem | jroll: ack | 20:18 |
mriedem | sdague: on a server update, i see we call the server view builder show() method and return that in the response body, | 20:19 |
*** annegent_ has joined #openstack-nova | 20:19 | |
mriedem | what i'm unclear of, is does that trigger the server show extensions to add their special bits to the response? | 20:19 |
mriedem | for example, when i look at https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/extended_volumes.py | 20:22 |
*** annegentle has quit IRC | 20:22 | |
mriedem | that extends the show and detail methods for the servers resource | 20:22 |
mriedem | but that will only be called on a GET for servers, right? | 20:22 |
mriedem | it would have nothing to do with the response for a POST or PUT | 20:23 |
*** gouthamr has quit IRC | 20:23 | |
mriedem | the server view builder just does it's own thing | 20:23 |
*** yamamoto has joined #openstack-nova | 20:23 | |
mriedem | reason i ask is we currently list os-extended-volumes:volumes_attached in the response for server create and update, and i think those are wrong | 20:25 |
*** amoralej is now known as amoralej|off | 20:25 | |
*** armax has joined #openstack-nova | 20:29 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: fix os-extended-volumes:volumes_attached in servers responses https://review.openstack.org/449809 | 20:29 |
*** smatzek has quit IRC | 20:31 | |
*** yamamoto has quit IRC | 20:33 | |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/delete #1: no-ops https://review.openstack.org/438119 | 20:37 |
*** sivak has quit IRC | 20:37 | |
*** sivak has joined #openstack-nova | 20:38 | |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #2: functional https://review.openstack.org/438598 | 20:39 |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: power_on/off and reboot https://review.openstack.org/427380 | 20:40 |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #3: TaskFlow https://review.openstack.org/438729 | 20:40 |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #4: full flavor https://review.openstack.org/391288 | 20:40 |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: console https://review.openstack.org/409402 | 20:41 |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189 | 20:42 |
openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: config drive https://review.openstack.org/409404 | 20:42 |
efried | adreznec esberglu mriedem ^^ Trivial rebases all the way up, because of a change to exception.py (In case you were in the middle of reviewing previous patch set.) | 20:43 |
mriedem | i was not | 20:43 |
efried | But, you know, just in case. | 20:44 |
mriedem | you seem unable to sit still on that bottom change | 20:44 |
mriedem | are you addressing feedback from within the powervm team or other? | 20:44 |
efried | No. It's only rebases. The tip of the master branch is a moving target. | 20:44 |
efried | Only real change since 3/16 (PS6) has been requirements update for new pypowervm release. | 20:45 |
*** kaisers_ has joined #openstack-nova | 20:45 | |
*** mlavalle has joined #openstack-nova | 20:46 | |
efried | ...and flake8-import-order, which seems to have come in waves of increasing strictness. | 20:47 |
*** mlavalle has quit IRC | 20:47 | |
efried | Bottom two are the only ones that touch common files so far; so after those are in, we can expect a lot less no-op churn. | 20:49 |
*** kaisers_ has quit IRC | 20:49 | |
*** rfolco has quit IRC | 20:51 | |
*** kaisers_ has joined #openstack-nova | 20:54 | |
*** mlavalle has joined #openstack-nova | 20:55 | |
*** baoli has quit IRC | 20:55 | |
mriedem | has this kind of spec come up before besides the spec around kilo/liberty to allow adding more servers to an existing group? https://review.openstack.org/#/c/389216/2 | 20:57 |
mriedem | ^ is basically, add config that reserves 'slots' in a server group for additional later servers in the same group for affinity to the same host | 20:58 |
*** baoli has joined #openstack-nova | 20:58 | |
*** gjayavelu has joined #openstack-nova | 20:59 | |
*** dave-mccowan has quit IRC | 21:01 | |
*** jamesdenton has quit IRC | 21:01 | |
*** dimtruck is now known as zz_dimtruck | 21:03 | |
*** links has joined #openstack-nova | 21:05 | |
*** mnestratov has joined #openstack-nova | 21:06 | |
*** rebase has joined #openstack-nova | 21:07 | |
*** suresh12 has quit IRC | 21:09 | |
*** suresh12 has joined #openstack-nova | 21:10 | |
mriedem | jroll: is this still an issue? https://review.openstack.org/#/c/321014/ | 21:10 |
mriedem | because that patch is really old | 21:11 |
openstackgerrit | Maxim Nestratov proposed openstack/nova master: libvirt: Virtuozzo containers config drive support https://review.openstack.org/449818 | 21:13 |
*** baoli has quit IRC | 21:17 | |
*** lpetrut has quit IRC | 21:19 | |
*** rfolco has joined #openstack-nova | 21:19 | |
*** rfolco has quit IRC | 21:19 | |
*** sneti_ has quit IRC | 21:21 | |
*** pumaranikar has quit IRC | 21:21 | |
*** vgadiraj has quit IRC | 21:21 | |
*** dharinic- has quit IRC | 21:21 | |
*** aunnam has quit IRC | 21:21 | |
*** suresh12 has quit IRC | 21:21 | |
*** aysyd has quit IRC | 21:21 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Empty machine_id file causes get_sysinfo_serial_auto to fail. https://review.openstack.org/343943 | 21:22 |
*** crushil has joined #openstack-nova | 21:23 | |
mriedem | tjones: someone from the vmware subteam might want to pick this up if it's still valid https://review.openstack.org/#/c/402256/ | 21:25 |
*** suresh12 has joined #openstack-nova | 21:28 | |
*** fragatina has joined #openstack-nova | 21:29 | |
tjones | sure. looking | 21:30 |
*** zz_dimtruck is now known as dimtruck | 21:30 | |
tjones | yes we will. i'll ping yang to pick it back up | 21:31 |
*** satyar_ has quit IRC | 21:42 | |
*** mnestratov has quit IRC | 21:49 | |
tjones | this one too https://review.openstack.org/#/c/270116/ | 21:52 |
*** suresh12 has quit IRC | 21:54 | |
*** annegent_ has quit IRC | 21:56 | |
efried | mdbooth Anyone reporting [[os.fsync(data.fileno()) OSError: [Errno 22] Invalid argument]] since https://review.openstack.org/#/c/443583/ ? | 21:56 |
*** knikolla has left #openstack-nova | 22:03 | |
*** suresh12 has joined #openstack-nova | 22:03 | |
*** mdrabe has quit IRC | 22:03 | |
efried | (Thing is, I don't know how that call can get EINVAL. Different errors occur if, e.g., the fileno is bogus, or the file is closed, or anything else I can come up with.) | 22:03 |
*** eandersson_ has joined #openstack-nova | 22:08 | |
*** rebase has quit IRC | 22:11 | |
*** rebase has joined #openstack-nova | 22:12 | |
*** nkorabli has quit IRC | 22:16 | |
eandersson_ | Anyone experienced an issue with large images causing nova to try to fail to set up the network, and ends up creating two neutron ports (since it fails with a neutron timeout)? | 22:16 |
*** nkorabli has joined #openstack-nova | 22:16 | |
eandersson_ | > nova.compute.manager ConnectTimeout: Request to http://netutron:9696/v2.0/ports.json timed out | 22:17 |
*** nkorabli has quit IRC | 22:20 | |
*** baoli has joined #openstack-nova | 22:21 | |
*** dimtruck is now known as zz_dimtruck | 22:25 | |
*** emerson has joined #openstack-nova | 22:26 | |
*** awaugama has quit IRC | 22:27 | |
*** lucasxu has quit IRC | 22:27 | |
*** yamahata has quit IRC | 22:36 | |
*** liangy has quit IRC | 22:36 | |
*** xyang1 has quit IRC | 22:38 | |
*** mtanino has quit IRC | 22:57 | |
*** erhudy has quit IRC | 23:00 | |
*** pumaranikar has joined #openstack-nova | 23:06 | |
*** kenperkins has quit IRC | 23:18 | |
*** gjayavelu has quit IRC | 23:18 | |
*** baoli_ has joined #openstack-nova | 23:20 | |
*** gjayavelu has joined #openstack-nova | 23:21 | |
*** sneti has quit IRC | 23:22 | |
*** ijw has joined #openstack-nova | 23:23 | |
*** markvoelker has quit IRC | 23:24 | |
*** baoli has quit IRC | 23:24 | |
*** links has quit IRC | 23:24 | |
*** hongbin has quit IRC | 23:28 | |
*** kaisers_ has quit IRC | 23:29 | |
*** jamesden_ has joined #openstack-nova | 23:35 | |
*** sdague has quit IRC | 23:43 | |
*** lucasxu has joined #openstack-nova | 23:45 | |
*** baoli_ has quit IRC | 23:51 | |
*** jamesden_ has quit IRC | 23:53 | |
*** ssurana has joined #openstack-nova | 23:53 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Regression test for local delete with an attached volume https://review.openstack.org/449334 | 23:56 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Set size/status during image create with FakeImageService https://review.openstack.org/449702 | 23:56 |
*** gjayavelu has quit IRC | 23:56 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Regression test for local delete with an attached volume https://review.openstack.org/449334 | 23:58 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Set size/status during image create with FakeImageService https://review.openstack.org/449702 | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!