Friday, 2017-03-31

*** jwcroppe has joined #openstack-nova00:02
*** jwcroppe has quit IRC00:02
*** jwcroppe has joined #openstack-nova00:02
openstackgerritTakashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2)  https://review.openstack.org/40895500:05
openstackgerritTakashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2)  https://review.openstack.org/40896400:06
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Microversion 2.42 - Fix tag attribute disappearing  https://review.openstack.org/42951200:06
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Microversion 2.43 - Enable cold migration with target host  https://review.openstack.org/40670700:06
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Microversion 2.43: List/Show all server migration types  https://review.openstack.org/43083900:06
openstackgerritTakashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host  https://review.openstack.org/41492600:07
openstackgerritTakashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action  https://review.openstack.org/41004200:07
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types  https://review.openstack.org/43060800:08
openstackgerritTakashi NATSUME proposed openstack/nova-specs master: Specify keymap on server boot  https://review.openstack.org/44883000:08
openstackgerritTakashi NATSUME proposed openstack/nova-specs master: Abort Cold Migration  https://review.openstack.org/33473200:08
openstackgerritTakashi NATSUME proposed openstack/nova-specs master: List/show all server migration types  https://review.openstack.org/40723700:09
*** rfolco has joined #openstack-nova00:11
*** suresh12 has quit IRC00:12
*** baoli has quit IRC00:16
*** baoli has joined #openstack-nova00:17
*** suresh12 has joined #openstack-nova00:17
*** baoli has quit IRC00:21
*** suresh12 has quit IRC00:22
*** jamielennox is now known as jamielennox|away00:25
*** adrian_otto has quit IRC00:26
*** dikonoo has joined #openstack-nova00:26
*** dikonoor has joined #openstack-nova00:26
*** ducttape_ has quit IRC00:27
*** jamielennox|away is now known as jamielennox00:31
*** zhurong has joined #openstack-nova00:32
*** tuanluong has joined #openstack-nova00:35
*** thorst has joined #openstack-nova00:38
*** thorst has quit IRC00:39
*** vladikr has quit IRC00:41
*** tovin07_ has joined #openstack-nova00:44
*** abalutoiu has quit IRC00:46
*** tbachman_ has joined #openstack-nova00:46
*** gongysh has joined #openstack-nova00:47
*** raunak has quit IRC00:48
*** zz_dimtruck is now known as dimtruck00:48
*** tbachman has quit IRC00:48
*** tbachman_ is now known as tbachman00:48
*** dharinic has joined #openstack-nova00:51
*** Shunli has joined #openstack-nova00:52
*** armax has quit IRC00:54
*** Dave has quit IRC00:54
*** yingjun has joined #openstack-nova00:55
*** zsli_ has joined #openstack-nova00:58
*** zsli_ has quit IRC01:01
*** Shunli has quit IRC01:01
*** vladikr has joined #openstack-nova01:01
*** Shunli has joined #openstack-nova01:01
*** suresh12 has joined #openstack-nova01:02
*** Dave has joined #openstack-nova01:02
*** ljjjustin has joined #openstack-nova01:06
*** suresh12 has quit IRC01:06
*** ljjjusti_ has joined #openstack-nova01:07
*** phuongnh has joined #openstack-nova01:07
*** thorst has joined #openstack-nova01:10
*** ducttape_ has joined #openstack-nova01:10
*** ljjjustin has quit IRC01:10
*** kevinz has joined #openstack-nova01:12
*** gongysh has quit IRC01:16
*** liusheng has joined #openstack-nova01:21
*** ijw has joined #openstack-nova01:23
*** browne has quit IRC01:27
*** thorst has quit IRC01:28
*** dikonoo has quit IRC01:29
*** dikonoor has quit IRC01:29
*** seungjin has quit IRC01:33
*** thorst has joined #openstack-nova01:37
*** READ10 has quit IRC01:38
*** thorst has quit IRC01:38
*** liangy has joined #openstack-nova01:44
*** lucasxu has joined #openstack-nova01:45
*** brault|away has joined #openstack-nova01:48
*** raunak has joined #openstack-nova01:49
*** Apoorva has quit IRC01:50
*** brault|away has quit IRC01:53
*** oanson has quit IRC01:55
*** oanson has joined #openstack-nova01:56
*** kenperkins has quit IRC01:56
*** dixiaoli has joined #openstack-nova01:58
*** rfolco has quit IRC02:00
*** ducttape_ has quit IRC02:04
*** yamahata has quit IRC02:08
*** ijw has quit IRC02:08
*** lucasxu has quit IRC02:10
*** lucasxu has joined #openstack-nova02:11
*** xinliang has quit IRC02:17
openstackgerritAlex Xu proposed openstack/nova master: Rename the model object ResourceProviderTraits to ResourceProviderTrait  https://review.openstack.org/45163502:19
openstackgerritAlex Xu proposed openstack/nova master: [placement] Allow PUT and POST without bodies  https://review.openstack.org/44762502:19
openstackgerritAlex Xu proposed openstack/nova master: placement: Enable attach traits to ResourceProvider  https://review.openstack.org/37620102:19
openstackgerritAlex Xu proposed openstack/nova master: placement: Add Traits API to placement service  https://review.openstack.org/37620002:19
*** lucasxu has quit IRC02:19
*** hongbin has joined #openstack-nova02:20
*** smcginnis is now known as smcginnis_vacati02:27
*** liangy has quit IRC02:30
*** xinliang has joined #openstack-nova02:30
openstackgerritAlex Xu proposed openstack/nova master: Remove the stevedore extension point for server create  https://review.openstack.org/45119502:34
openstackgerritAlex Xu proposed openstack/nova master: Remove the json-schema extension point of server create  https://review.openstack.org/45119402:34
openstackgerritAlex Xu proposed openstack/nova master: Use plain routes list for '/servers' endpoint instead of stevedore  https://review.openstack.org/44586402:34
openstackgerritAlex Xu proposed openstack/nova master: Remove the usage of extension black/white list opts in BDM tests  https://review.openstack.org/45083002:34
openstackgerritAlex Xu proposed openstack/nova master: Remove the usage of extension black/white list opts in multi-create  https://review.openstack.org/45083102:34
openstackgerritAlex Xu proposed openstack/nova master: Remove the usage of extension black/white list opt in scheduler hints  https://review.openstack.org/45083502:34
openstackgerritAlex Xu proposed openstack/nova master: Remove the usage of extension black/white list opt in user data  https://review.openstack.org/45083402:34
openstackgerritAlex Xu proposed openstack/nova master: Remove the usage of extension black/white list opt in AZ  https://review.openstack.org/45083302:34
openstackgerritAlex Xu proposed openstack/nova master: Remove the usage of extension black/white list opt in config drive  https://review.openstack.org/45083202:34
openstackgerritAlex Xu proposed openstack/nova master: Remove the extension check for os-networks in servers API  https://review.openstack.org/45083702:34
openstackgerritAlex Xu proposed openstack/nova master: Remove config opts for extension black/white list  https://review.openstack.org/45083602:34
*** rfolco has joined #openstack-nova02:36
*** rfolco has quit IRC02:37
*** thorst has joined #openstack-nova02:39
*** kevinz has quit IRC02:40
*** kevinz has joined #openstack-nova02:40
*** rfolco has joined #openstack-nova02:45
*** rfolco has quit IRC02:45
gmannalex_xu: johnthetubaguy oomichi can you check this (many API change patches keep appending the field in POST server response)  -https://review.openstack.org/#/c/451673/02:46
*** tommylikehu has joined #openstack-nova02:51
*** ducttape_ has joined #openstack-nova02:53
*** thorst has quit IRC02:56
*** thorst has joined #openstack-nova02:57
*** hamzy has joined #openstack-nova02:58
openstackgerritZhenyu Zheng proposed openstack/nova master: Rework descriptions in os-hypervisors  https://review.openstack.org/45203003:00
*** thorst has quit IRC03:01
*** namnh has joined #openstack-nova03:01
*** dimtruck is now known as zz_dimtruck03:03
*** baoli has joined #openstack-nova03:07
namnhdansmith, Hi Mr.Smith, are you free? could I confirm with you a point03:11
*** baoli has quit IRC03:15
openstackgerritZhenyu Zheng proposed openstack/nova master: Add description to policies in admin_password.py  https://review.openstack.org/45127103:17
*** ducttape_ has quit IRC03:20
*** amotoki has quit IRC03:22
openstackgerritDanfly proposed openstack/nova master: Completely remove mox from unit/network/test_linux_net.py  https://review.openstack.org/44550403:25
*** hongbin has quit IRC03:31
*** ducttape_ has joined #openstack-nova03:31
*** Shunli has quit IRC03:32
*** armax has joined #openstack-nova03:33
*** vladikr has quit IRC03:34
*** ducttape_ has quit IRC03:34
*** diga has joined #openstack-nova03:35
*** armax has quit IRC03:36
*** _ducttape_ has joined #openstack-nova03:39
*** ducnc has quit IRC03:44
*** ljjjusti_ has quit IRC03:48
*** ljjjustin has joined #openstack-nova03:48
*** _ducttape_ has quit IRC03:48
*** dixiaoli has quit IRC03:48
*** amotoki has joined #openstack-nova03:50
*** ducttape_ has joined #openstack-nova03:51
*** dixiaoli has joined #openstack-nova03:52
*** mdnadeem has joined #openstack-nova03:52
*** amotoki has quit IRC03:56
*** amotoki has joined #openstack-nova04:00
*** dixiaoli has quit IRC04:00
*** yamamoto has joined #openstack-nova04:01
*** thorst has joined #openstack-nova04:01
openstackgerritHuan Xie proposed openstack/nova master: WIP: Fix race condition when neutron is using minimized poll  https://review.openstack.org/44423004:02
*** ijw has joined #openstack-nova04:02
*** Qiming has quit IRC04:04
openstackgerritTakashi NATSUME proposed openstack/nova master: Refactor a test method including 3 test cases  https://review.openstack.org/39473804:05
*** ducttape_ has quit IRC04:05
*** Qiming has joined #openstack-nova04:06
*** thorst has quit IRC04:06
*** edmondsw has joined #openstack-nova04:08
*** zhurong has quit IRC04:09
*** edmondsw has quit IRC04:12
*** masayukig has quit IRC04:14
*** gouthamr has quit IRC04:14
*** ducttape_ has joined #openstack-nova04:19
*** amotoki has quit IRC04:22
*** dixiaoli has joined #openstack-nova04:24
*** dixiaoli has quit IRC04:25
*** armax has joined #openstack-nova04:26
*** ducttape_ has quit IRC04:27
*** ducttape_ has joined #openstack-nova04:28
*** zhurong has joined #openstack-nova04:30
*** vks1 has joined #openstack-nova04:30
*** ducttape_ has quit IRC04:33
*** ayogi has joined #openstack-nova04:34
*** psachin has joined #openstack-nova04:42
*** yamamoto has quit IRC04:42
*** bmace has quit IRC04:44
*** yamamoto has joined #openstack-nova04:44
*** bmace has joined #openstack-nova04:44
*** dikonoo has joined #openstack-nova04:48
*** dikonoor has joined #openstack-nova04:48
*** avolkov has quit IRC04:54
*** avolkov has joined #openstack-nova04:54
*** adisky_ has joined #openstack-nova04:54
*** thorst has joined #openstack-nova05:02
*** thorst has quit IRC05:07
*** ratailor has joined #openstack-nova05:07
*** yamamoto has quit IRC05:09
*** udesale has joined #openstack-nova05:10
*** frickler has quit IRC05:11
*** frickler has joined #openstack-nova05:12
*** wagnqwsh has joined #openstack-nova05:12
*** suresh12 has joined #openstack-nova05:12
*** fragatin_ has joined #openstack-nova05:14
*** ijw has quit IRC05:15
*** nkrinner_afk is now known as nkrinner05:16
*** suresh12 has quit IRC05:17
*** fragatina has quit IRC05:17
*** fragatin_ has quit IRC05:18
*** trinaths has joined #openstack-nova05:19
*** dharinic has quit IRC05:22
*** prateek has joined #openstack-nova05:23
*** yamamoto has joined #openstack-nova05:28
*** ducttape_ has joined #openstack-nova05:29
*** brault|away has joined #openstack-nova05:30
*** fragatina has joined #openstack-nova05:31
*** fragatina has quit IRC05:31
*** fragatina has joined #openstack-nova05:31
*** fragatina has quit IRC05:34
*** fragatina has joined #openstack-nova05:34
*** nkorabli has joined #openstack-nova05:35
*** dixiaoli has joined #openstack-nova05:35
*** ducttape_ has quit IRC05:35
*** zhurong has quit IRC05:41
*** takashin has left #openstack-nova05:41
*** yamamoto has quit IRC05:41
*** dixiaoli has quit IRC05:43
*** rcernin has joined #openstack-nova05:44
*** raunak has quit IRC05:46
*** adrian_otto has joined #openstack-nova05:52
*** suresh12 has joined #openstack-nova05:52
*** belmoreira has joined #openstack-nova05:55
*** jaosorior has joined #openstack-nova05:56
*** dixiaoli has joined #openstack-nova05:59
*** dixiaoli has quit IRC06:00
*** thorst has joined #openstack-nova06:03
*** andreas_s has joined #openstack-nova06:04
*** amotoki has joined #openstack-nova06:05
*** zhurong has joined #openstack-nova06:05
*** amotoki_ has joined #openstack-nova06:08
*** thorst has quit IRC06:08
openstackgerritZhenyu Zheng proposed openstack/nova master: Rework descriptions in os-hypervisors  https://review.openstack.org/45203006:10
*** amotoki has quit IRC06:10
*** dixiaoli has joined #openstack-nova06:14
openstackgerritZhenyu Zheng proposed openstack/nova-specs master: Add os-traits reference  https://review.openstack.org/44740106:17
openstackgerritZhenyu Zheng proposed openstack/nova master: Make metadata doc more readable  https://review.openstack.org/45055106:19
gibixgerman: hi! I saw you are trying to use soft-anti-affinity06:19
*** voelzmo has joined #openstack-nova06:19
*** dikonoo has quit IRC06:19
*** dikonoor has quit IRC06:19
*** suresh12 has quit IRC06:20
gibixgerman: The error you linked here https://www.irccloud.com/pastebin/zfgU1sJu/ seems to come from something outside of nova. Do you have more details about what you try to do with nova and how that action fails on nova side?06:20
*** slaweq has quit IRC06:21
*** claudiub has joined #openstack-nova06:21
*** slaweq has joined #openstack-nova06:22
*** slaweq has quit IRC06:22
openstackgerritDinesh Bhor proposed openstack/nova master: Trivial: Remove unused method  https://review.openstack.org/45205406:22
openstackgerritGhanshyam Mann proposed openstack/nova master: Add api sample tests for security group rules  https://review.openstack.org/45205506:22
*** voelzmo has quit IRC06:23
*** slaweq has joined #openstack-nova06:24
*** voelzmo has joined #openstack-nova06:29
*** udesale__ has joined #openstack-nova06:29
*** udesale has quit IRC06:31
*** udesale has joined #openstack-nova06:33
*** udesale__ has quit IRC06:34
*** mnestratov has joined #openstack-nova06:35
*** yamamoto has joined #openstack-nova06:42
*** satyar has joined #openstack-nova06:45
*** ltomasbo|away is now known as ltomasbo06:46
*** markus_z has joined #openstack-nova06:48
*** yamamoto has quit IRC06:49
*** armax has quit IRC06:56
*** ducttape_ has joined #openstack-nova07:00
openstackgerritGergely Csatari proposed openstack/nova master: api-ref: adminPass is optional in Create Server  https://review.openstack.org/45149707:00
*** abalutoiu has joined #openstack-nova07:00
*** thorst has joined #openstack-nova07:04
*** ducttape_ has quit IRC07:05
*** nkorabli has quit IRC07:06
openstackgerritBalazs Gibizer proposed openstack/nova master: remove ugly local import  https://review.openstack.org/45078707:06
openstackgerritBalazs Gibizer proposed openstack/nova master: remove get_nw_info_for_instance from compute.utils  https://review.openstack.org/45138707:06
*** karthiks has joined #openstack-nova07:07
*** nkorabli has joined #openstack-nova07:07
*** tesseract has joined #openstack-nova07:08
*** thorst has quit IRC07:09
*** nkorabli has quit IRC07:11
openstackgerritGergely Csatari proposed openstack/nova master: api-ref: networks is mandatory in Create Server  https://review.openstack.org/45206907:14
*** dharinic has joined #openstack-nova07:16
openstackgerritBalazs Gibizer proposed openstack/nova master: remove get_nw_info_for_instance from compute.utils  https://review.openstack.org/45138707:16
openstackgerritHuan Xie proposed openstack/nova master: XenAPI: Create linux bridge in dest host during live migration  https://review.openstack.org/45165707:17
*** yingjun has quit IRC07:18
*** dharinic has quit IRC07:23
*** sridharg has joined #openstack-nova07:25
*** Qiming has quit IRC07:26
*** pcaruana has joined #openstack-nova07:27
*** slaweq_ has joined #openstack-nova07:28
*** slaweq_ has quit IRC07:28
*** dixiaoli has quit IRC07:29
*** udesale has quit IRC07:30
*** udesale has joined #openstack-nova07:30
*** dixiaoli has joined #openstack-nova07:32
*** Qiming has joined #openstack-nova07:32
*** ralonsoh has joined #openstack-nova07:34
*** Nisha_Agarwal has joined #openstack-nova07:34
*** ralonsoh_ has joined #openstack-nova07:35
*** jpena|off is now known as jpena07:36
openstackgerritGhanshyam Mann proposed openstack/nova master: Add empty flavor object info in server api-ref  https://review.openstack.org/45207807:36
*** fragatina has quit IRC07:37
openstackgerritBéla Vancsics proposed openstack/nova master: Reduced the complexity of the _init_instance method (4)  https://review.openstack.org/42063207:38
*** ralonsoh has quit IRC07:39
-openstackstatus- NOTICE: Jobs in gate are failing with POST_FAILURE. Infra roots are investigating07:43
*** ChanServ changes topic to "Jobs in gate are failing with POST_FAILURE. Infra roots are investigating"07:43
*** ralonsoh_ is now known as ralonsoh07:44
*** slaweq_ has joined #openstack-nova07:53
*** slaweq_ has quit IRC07:53
*** slaweq_ has joined #openstack-nova07:53
*** rcernin has quit IRC07:54
*** tesseract has quit IRC07:54
*** tesseract has joined #openstack-nova07:55
*** rcernin has joined #openstack-nova07:55
openstackgerritJianghua Wang proposed openstack/nova-specs master: Support VGPU  https://review.openstack.org/45012207:58
*** zzzeek has quit IRC08:00
*** gszasz has joined #openstack-nova08:01
*** zzzeek has joined #openstack-nova08:04
*** dixiaoli has quit IRC08:05
*** thorst has joined #openstack-nova08:05
*** dixiaoli has joined #openstack-nova08:05
*** slaweq_ has quit IRC08:05
*** slaweq_ has joined #openstack-nova08:06
*** slaweq has quit IRC08:06
openstackgerritJianghua Wang proposed openstack/nova-specs master: Support VGPU  https://review.openstack.org/45012208:06
*** slaweq_ has quit IRC08:07
*** mlakat has joined #openstack-nova08:07
*** mlakat has quit IRC08:08
*** slaweq has joined #openstack-nova08:12
*** karimb has joined #openstack-nova08:13
*** jogo has quit IRC08:13
*** jogo has joined #openstack-nova08:15
*** karimb has quit IRC08:17
*** lpetrut has joined #openstack-nova08:18
*** suresh12 has joined #openstack-nova08:20
*** karimb has joined #openstack-nova08:23
-openstackstatus- NOTICE: logs.openstack.org has corrupted disks, it's being repaired. Please avoid rechecking until this is fixed08:24
*** ChanServ changes topic to "logs.openstack.org has corrupted disks, it's being repaired. Please avoid rechecking until this is fixed"08:24
*** suresh12 has quit IRC08:24
*** thorst has quit IRC08:24
*** lucas-afk is now known as lucasagomes08:26
*** derekh has joined #openstack-nova08:32
*** mlakat has joined #openstack-nova08:33
*** abalutoiu_ has joined #openstack-nova08:35
*** abalutoiu has quit IRC08:37
*** avolkov has quit IRC08:37
*** zyun has joined #openstack-nova08:38
zyunHi all08:38
zyunMay I ask a question here?08:38
zyunwhen running the "nova image-create" in vmware env, could I specify this created template stored into specificy datastore?08:39
zyunMany thanks for any clue :)08:39
*** dixiaoli has quit IRC08:45
*** jahsis has joined #openstack-nova08:46
openstackgerritGábor Antal proposed openstack/nova master: Transform instance.volume_attach notification  https://review.openstack.org/40199208:47
*** gszasz has quit IRC08:58
*** dixiaoli has joined #openstack-nova09:05
*** baoli has joined #openstack-nova09:07
*** baoli has quit IRC09:12
lyarwoodjohnthetubaguy / mdbooth ; Matt is +2 on this now but I'd be happy to respin with the nits corrected this morning if you think it's worthwhile09:12
lyarwoodsfinucan: https://review.openstack.org/#/c/451870/ - if you have time, just a silly docs lift and shift to make it easier to find the releasenote guide in dev-ref09:13
johnthetubaguylyarwood: I think I was +2 before, minus the conf nit, will take a peak09:16
*** avolkov has joined #openstack-nova09:17
*** annegentle has quit IRC09:18
*** mlakat has quit IRC09:19
*** cdent has joined #openstack-nova09:20
*** gcb has quit IRC09:21
*** rmart04 has joined #openstack-nova09:21
*** Nisha_Agarwal has quit IRC09:21
lyarwoodwe are removing _L*?! I missed that memo.09:24
*** zyun has quit IRC09:24
lyarwoodah found the thread, sorry.09:24
sfinucanlyarwood: Yup, that's an easy win09:25
* sfinucan is *always* happy to review anything that improves documentation09:25
johnthetubaguylyarwood: yeah, its kinda new, I am just upset we added that logging nonsense it in the first place09:25
*** wagnqwsh has quit IRC09:26
lyarwoodsfinucan: :D good to know thanks, I'll follow up with the nits when I get time09:26
*** ekuris has quit IRC09:28
johnthetubaguylyarwood: did you see the detach patch, I think we might need another refactor in between09:29
lyarwoodsfinucan: btw this only came up thanks to my inability to find the releasenote docs while looking into writing one for https://review.openstack.org/#/c/391597/ (encryptor class removal from nova), still can't decide if one is really needed here, any thoughts?09:29
* sfinucan looking09:29
lyarwoodjohnthetubaguy: yeah I did, what did you have in mind?09:31
lyarwoodjohnthetubaguy: I don't understand the need for the connection_info['attachment_id'] stuff in the driver bdm tbh09:31
johnthetubaguylyarwood: FWIW, I always consider my self an operator, and try work out if I want to know anything about the change when I upgrade the system (under the assumption I the operator depend on that thing that just got tweaked)09:31
johnthetubaguylyarwood: you got a link to file you see that attachement_id stuff being done?09:32
*** edmondsw has joined #openstack-nova09:32
johnthetubaguyoh, I see it now09:32
lyarwoodjohnthetubaguy: https://review.openstack.org/#/c/438750/4/nova/virt/block_device.py09:33
lyarwoodurgh my vps is lagging09:33
johnthetubaguylyarwood: honestly, that might just be a poor rebase thing09:34
*** ekuris has joined #openstack-nova09:34
*** udesale__ has joined #openstack-nova09:35
lyarwoodjohnthetubaguy: true, what did you have in mind for the additional refactor before the detach changes?09:36
*** psachin has quit IRC09:36
*** kevinz has quit IRC09:36
*** edmondsw has quit IRC09:37
johnthetubaguylyarwood: I was expecting all this to happen inside the bdm if you call "detach" or something like that: https://review.openstack.org/#/c/438750/4/nova/compute/api.py09:37
*** kevinz has joined #openstack-nova09:37
*** udesale has quit IRC09:37
lyarwoodjohnthetubaguy: understood, volume_api or just another method in the driver bdm?09:39
johnthetubaguylyarwood: good point, probably bdm I guess09:40
johnthetubaguyI could go either way09:40
jaosoriorowalsh: alright, oh, so from what I can see in that LP. It seems that there is still a need for the URI there09:40
lyarwoodkk, I'll take a look at that and the attach stuff today09:40
jaosoriorowalsh: so, why is was that URI being deprecated in the first place?09:40
owalshjaosorior: not sure09:41
johnthetubaguylyarwood: actually how do BDMs fit in the non-libvirt drivers these days?09:41
jaosoriorseems like it was quite useful and would save a lot of configuration hassles, as opposed to needing to split the config to several options09:41
johnthetubaguyowalsh: jaosorior: I am curious, which URI?09:42
owalshjohnthetubaguy: live_migration_uri09:42
johnthetubaguyowalsh: oh, so bits of that URL are best defaulted by the driver, based on what sort of live-migration you are doing, if I remember correctly, pkoniszewski has more context on that09:42
owalshjohnthetubaguy: https://bugs.launchpad.net/nova/+bug/167128809:43
openstackLaunchpad bug 1671288 in OpenStack Compute (nova) "live_migration_uri to live_migration_scheme SSH settings" [Undecided,Confirmed]09:43
lyarwoodjohnthetubaguy: they should all use bdms and driver bdms now AFAIK09:43
johnthetubaguylyarwood: OK, fingers crossed09:43
owalshjohnthetubaguy: i need to set the ssh user and key09:43
johnthetubaguyowalsh: I see "live_migration_scheme = None" in that configuration reference09:44
*** sdague has joined #openstack-nova09:44
jaosoriorjohnthetubaguy: so, the main issue is not the scheme or the IP. But the extra configurations one can give as query parameters in the URI09:45
jaosoriorjohnthetubaguy: which vary depending on the scheme used.09:45
johnthetubaguyjaosorior: owalsh: so the aim was to make it easier to use, so the defaults are correct for all the different hypervisors, if thats not going to work out, totally up for reversing the deprecation09:47
johnthetubaguyjaosorior: owalsh: could you just write out like a before and after, to see how bad it looks?09:47
pkoniszewskiso live_migration_uri is mostly used to hack QEMU rather than for "extra configuration"09:48
*** rmart04 has quit IRC09:48
pkoniszewskiI understand your problem but I'd like to know your use case for this ssh key09:49
jaosoriorpkoniszewski: I wouldn't say that specifying the known hosts, key locations or ssh keys are "hacking qemu"09:49
pkoniszewskidoes QEMU use root's ssh key? not sure i remember that correctly09:49
owalshpkoniszewski: it's libvirt, running as root ,so yes09:50
pkoniszewskijaosorior: so mostly operators used this URI to force QEMU to use different link for live migrations09:50
pkoniszewskinot to specify keys etc.09:50
owalshpkoniszewski: I'm adding SSH key setup for the nova user for cold-migration, want to resuse this for live migration to DRY09:51
pkoniszewskigot it09:51
johnthetubaguyah, that makes sense09:51
johnthetubaguysounds like we should do that out of the box09:52
owalshpkoniszewski: so qemu+ssh://nova@%s/system?keyfile=/var/lib/nova/.ssh/id_rsa09:52
*** adrian_otto has quit IRC09:53
johnthetubaguypkoniszewski: whats the best way to do that QEMU?09:53
pkoniszewskiwell, adding conf option to specify username for SSH makes sense to me09:53
pkoniszewskiby default it uses root, this might be a security issue for ome09:54
johnthetubaguyfeels like we are adding lots of options at that point... but that might be easiest.09:54
*** psachin has joined #openstack-nova09:54
johnthetubaguyowalsh: I guess migration just uses that key because of the user you are running Nova with, its not a config as such?09:55
pkoniszewskiwe can do any, teach people (or let them google it) how to configure URI by themselves, or break it into few options09:55
johnthetubaguyyeah, I am just curious what folks would prefer09:55
owalshjohnthetubaguy: yea, /var/lib/nova is the nova home dir09:56
pkoniszewskiby default LM uses TCP, SSH is just an option09:56
owalshpkoniszewski, johnthetubaguy: there is also this https://bugs.launchpad.net/nova/+bug/167791309:56
openstackLaunchpad bug 1677913 in OpenStack Compute (nova) "percent must be escaped in live_migration_uri" [Undecided,New]09:56
johnthetubaguypkoniszewski: ssh just gives you the secure transport here?09:56
pkoniszewskiyes09:56
owalshjohnthetubaguy: ssh + nc is used to tunnel the libvirt unix socket09:57
*** abalutoiu_ has quit IRC09:57
johnthetubaguyowalsh: that bug about the % needing to be escaped really makes we want us to addd extra config options for the ssl config (and we keep the URL for an extra cycle while that is added)09:58
johnthetubaguyowalsh: would that work for you all?09:58
*** BlackDex has joined #openstack-nova09:58
openstackgerritRoman Podoliaka proposed openstack/osc-placement master: WIP: implement API version 1.0  https://review.openstack.org/45187709:59
openstackgerritRoman Podoliaka proposed openstack/osc-placement master: tests: add a hook for functional testing in the gate  https://review.openstack.org/45212209:59
owalshjohnthetubaguy: yea, might end up with a lot of params though10:00
johnthetubaguyowalsh: but most folks don't need to tweak any of them, and at least it much more discoverable what you can do10:00
johnthetubaguythe alternative seems to involve string substitutions, etc, which is just a bit funky.10:01
*** udesale__ has quit IRC10:03
*** kevinz has quit IRC10:05
johnthetubaguypkoniszewski: I am curious on the URL substitution, is there a reason why its not the destination host that just provides its whole URL?10:05
owalshjohnthetubaguy: you suggesting we could set it to user@host:port?10:06
johnthetubaguyowalsh: you probably could set that as the host... I guess10:07
johnthetubaguyowalsh: not sure I like that though10:07
*** abalutoiu has joined #openstack-nova10:07
owalshor user@host:port/system?key=foo10:07
*** cdent has quit IRC10:07
johnthetubaguynot sure10:07
johnthetubaguyit might work10:07
owalshdon't think the latter would work as nova will append /system10:08
johnthetubaguyyeah, that sounds right10:08
openstackgerritDanfly proposed openstack/nova master: remove mox from unit/virt/vmwareapi/test_driver_api.py  https://review.openstack.org/45212810:08
johnthetubaguyowalsh: really I am suggesting we add a new configuration option, and you keep using the URI for now, and we extend the deprecation period of the URI while we get more feedback10:09
*** lpetrut has quit IRC10:09
owalshjohnthetubaguy: ack, jaosorior ^^10:10
jaosoriorsounds good to me10:10
johnthetubaguyowalsh: jaosorior: would you fancy doing that patch?10:11
johnthetubaguyhappy to put it near the top of my review pile once its up10:11
owalshjohnthetubaguy: sure10:13
johnthetubaguycool, thanks for that info, thats a really interesting use case I had not thought about before10:14
* johnthetubaguy learns something new about live-migrate most months this year!10:14
*** amotoki_ has quit IRC10:15
*** lpetrut has joined #openstack-nova10:16
*** diga has quit IRC10:17
owalshjohnthetubaguy: just thinking...probably need an option for user (ssh only), port (all), and extraparams (all)10:17
owalshjohnthetubaguy: but if user@host:port works with for live_migration_inbound_addr we would just need an extraparams optoin10:18
*** ratailor has quit IRC10:18
*** zhurong has quit IRC10:18
*** ljjjustin has quit IRC10:19
*** tuanluong has quit IRC10:20
jaosoriorowalsh: I don't see why adding that in live_migration_inbound_addr10:20
jaosoriorwouldn't work10:20
*** lpetrut has quit IRC10:20
jaosoriorseems like it's just some substitution10:20
owalshjaosorior: I was just about to peek at the code :-)10:21
*** thorst has joined #openstack-nova10:21
*** tovin07_ has quit IRC10:22
*** GnomeKing has joined #openstack-nova10:23
*** namnh has quit IRC10:24
*** nkrinner is now known as nkrinner_afk10:24
*** sambetts|afk is now known as sambetts10:25
*** thorst has quit IRC10:26
*** satyar has quit IRC10:28
*** lpetrut has joined #openstack-nova10:29
*** lpetrut has quit IRC10:29
*** trinaths has left #openstack-nova10:30
*** ralonsoh_ has joined #openstack-nova10:30
*** lpetrut has joined #openstack-nova10:31
*** lpetrut has quit IRC10:31
*** abalutoiu has quit IRC10:31
*** lpetrut has joined #openstack-nova10:32
*** ratailor has joined #openstack-nova10:33
*** ralonsoh has quit IRC10:34
*** tpatzig_ has joined #openstack-nova10:36
*** carthaca_ has joined #openstack-nova10:36
*** david_1 has joined #openstack-nova10:36
johnthetubaguyjaosorior: owalsh: as long as we clearly document what you tweak to change those things in the comments, we could entertain that10:38
johnthetubaguyjohnthetubaguy: owalsh: by we, I mean I10:38
*** tpatzig_ has quit IRC10:38
*** carthaca_ has quit IRC10:38
*** david_1 has quit IRC10:38
*** cdent has joined #openstack-nova10:38
owalshjohnthetubaguy: you're royalty, yea?10:39
johnthetubaguyheh10:39
johnthetubaguyone does ones best to talk like ones queen10:40
cdentone does10:40
*** zhurong has joined #openstack-nova10:41
*** gszasz has joined #openstack-nova10:42
*** abalutoiu has joined #openstack-nova10:46
*** phuongnh has quit IRC10:46
*** dixiaoli has quit IRC10:49
*** psachin has quit IRC10:50
*** dixiaoli has joined #openstack-nova10:51
cdentIs logs.o.o back to working?10:51
*** gcb has joined #openstack-nova10:51
*** psachin has joined #openstack-nova10:52
openstackgerritJianghua Wang proposed openstack/nova-specs master: Support VGPU  https://review.openstack.org/45012211:00
openstackgerritSylvain Bauza proposed openstack/nova master: Destroy the ReqSpec object when deleting the instance  https://review.openstack.org/39106011:00
*** ratailor has quit IRC11:00
*** ratailor has joined #openstack-nova11:01
*** lpetrut has quit IRC11:02
*** dikonoo has joined #openstack-nova11:03
*** dikonoor has joined #openstack-nova11:03
*** slaweq has quit IRC11:05
*** slaweq has joined #openstack-nova11:06
lyarwoodjohnthetubaguy: mdbooth is +1 on https://review.openstack.org/439520 btw if you're happy to +W11:06
johnthetubaguylyarwood: sweet11:07
*** gcb has quit IRC11:20
*** suresh12 has joined #openstack-nova11:20
*** thorst has joined #openstack-nova11:22
fricklercdent: recovery of old logs is ongoing, new jobs should be fine11:24
cdentthanks frickler11:24
*** lpetrut has joined #openstack-nova11:24
*** suresh12 has quit IRC11:24
*** lpetrut has quit IRC11:25
*** thorst has quit IRC11:27
*** lucasagomes is now known as lucas-hungry11:28
*** zz_dimtruck is now known as dimtruck11:30
*** thorst has joined #openstack-nova11:32
*** amotoki has joined #openstack-nova11:32
*** gcb has joined #openstack-nova11:33
*** lpetrut has joined #openstack-nova11:37
oomichigmann: -1 on https://review.openstack.org/#/c/451673   we need to check tempest jsonschema as qa team ;)11:44
*** dimtruck is now known as zz_dimtruck11:46
*** zz_dimtruck is now known as dimtruck11:46
*** nkrinner_afk is now known as nkrinner11:47
*** vladikr has joined #openstack-nova11:47
*** dixiaoli has quit IRC11:54
*** dimtruck is now known as zz_dimtruck11:56
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova master: Read NIC features in libvirt  https://review.openstack.org/44441511:58
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova master: Modify PciPassthroughFilter to accept lists  https://review.openstack.org/44494611:58
*** zhurong has quit IRC11:59
*** liverpooler has quit IRC12:00
*** liverpooler has joined #openstack-nova12:00
*** prateek has quit IRC12:01
*** prateek has joined #openstack-nova12:01
*** jjung has joined #openstack-nova12:03
*** ekuris has quit IRC12:06
*** cdent has quit IRC12:08
*** ekuris has joined #openstack-nova12:09
*** edleafe is now known as figleaf12:10
*** aysyd has joined #openstack-nova12:11
*** ekuris has quit IRC12:14
*** adreznec has quit IRC12:14
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot  https://review.openstack.org/44925712:14
*** adreznec has joined #openstack-nova12:17
*** ducttape_ has joined #openstack-nova12:17
openstackgerritLee Yarwood proposed openstack/nova master: WIP compute: Centralise terminate and detach volume api calls in bdm  https://review.openstack.org/45218112:22
*** lucas-hungry is now known as lucasagomes12:22
*** ducttape_ has quit IRC12:30
*** ekuris has joined #openstack-nova12:30
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Add api-ref for POST RP inventories  https://review.openstack.org/45185512:30
*** edmondsw has joined #openstack-nova12:33
ildikovjohnthetubaguy: hi, around?12:33
johnthetubaguyI am12:33
ildikovjust wanted to ask about the meeting slot12:33
ildikovI guess we should look into either trying to move it back with an hour or to another day, right?12:33
johnthetubaguyideally, but I am OK reading the logs and the ML to keep track12:34
ildikovcan you make it to the let's say first 15-20 minutes if we keep it where it is now?12:35
johnthetubaguygood question, it slightly depends on who is cooking dinner, and thats usually me12:35
*** catintheroof has joined #openstack-nova12:36
*** ayogi has quit IRC12:36
*** lpetrut has quit IRC12:36
ildikovhmm ok, then maybe it would worth looking into other options12:36
johnthetubaguyildikov: moving it one hour back, to what it was a few weeks ago would work12:36
johnthetubaguyI know thats not the norm, but it could work here12:37
ildikovI will ask around12:38
ildikovand/or create a Doodle poll with the current slot and the one hour earlier for every weekdays and see what's the best option12:38
*** vks1 has quit IRC12:38
ildikovif moving it back with an hour seems to work for the most, I'll leave the poll12:39
johnthetubaguyildikov: just thinking that was Ok for us all a few weeks back, but I know some have UTC fixed meetings12:39
ildikovit's always tricky with these changes12:39
ildikovalthough I don't recall any US folks complaining about the change and they switched before us12:40
ildikovso it should be ok in theory12:40
johnthetubaguyyeah, its never easy12:41
johnthetubaguymdbooth: I just remembered, are you free for a quick hangout this afternoon?12:41
mdboothjohnthetubaguy: Yep12:41
johnthetubaguymdbooth: does now ish work? link in 5 mins?12:41
mdboothjohnthetubaguy: I should be finished eating by then, sure :)12:42
johnthetubaguyperfect12:42
*** awaugama has joined #openstack-nova12:44
*** HW-Peter has joined #openstack-nova12:45
openstackgerritSilvan Kaiser proposed openstack/nova master: Switch Nova Quobyte volume driver to mount via systemd-run  https://review.openstack.org/43234412:51
kaisersmdbooth: ping ^^^^ (back to systemd-run but with working exit codes)12:51
*** andreas_s has quit IRC12:52
openstackgerritSamantha Blanco proposed openstack/nova master: Make flavor-rxtx policy more granular  https://review.openstack.org/44403612:53
*** kylek3h has quit IRC12:54
*** HW-Peter has quit IRC12:55
*** HW-Peter has joined #openstack-nova12:55
*** HW-Peter has quit IRC12:56
*** HW-Peter has joined #openstack-nova12:56
*** zz_dimtruck is now known as dimtruck12:58
*** arne_r has joined #openstack-nova13:00
*** gouthamr has joined #openstack-nova13:01
*** jjung has quit IRC13:04
*** cdent has joined #openstack-nova13:05
jaosoriorHey guys, is live-migration already supported by the openstack CLI? Or do I have to use the nova CLI?13:06
*** lpetrut has joined #openstack-nova13:06
*** jianghuaw has joined #openstack-nova13:09
*** xyang1 has joined #openstack-nova13:09
*** jamesdenton has joined #openstack-nova13:09
*** cleong has joined #openstack-nova13:10
*** lpetrut has quit IRC13:11
*** jamesden_ has joined #openstack-nova13:13
*** esberglu has joined #openstack-nova13:14
*** baoli has joined #openstack-nova13:14
*** jamesdenton has quit IRC13:14
*** baoli has quit IRC13:14
*** baoli has joined #openstack-nova13:15
*** liangy has joined #openstack-nova13:16
*** dave-mccowan has joined #openstack-nova13:19
*** ratailor has quit IRC13:19
*** mdrabe has joined #openstack-nova13:20
*** kylek3h has joined #openstack-nova13:22
*** tuan_luong has joined #openstack-nova13:23
*** tuanla_ has joined #openstack-nova13:24
*** kylek3h has quit IRC13:25
*** Guest16838 has quit IRC13:25
*** baoli has quit IRC13:28
*** ducttape_ has joined #openstack-nova13:30
*** mdnadeem has quit IRC13:31
*** lpetrut has joined #openstack-nova13:33
*** kylek3h has joined #openstack-nova13:33
*** mariusv_ has quit IRC13:34
*** mariusv has quit IRC13:34
xgermangibi: we figured it out - was using the wrong micro version in the client13:34
*** mariusv has joined #openstack-nova13:35
*** mariusv has quit IRC13:35
*** mariusv has joined #openstack-nova13:35
*** ducttape_ has quit IRC13:35
*** aunnam_ has joined #openstack-nova13:35
*** Guest16838 has joined #openstack-nova13:37
*** ducttape_ has joined #openstack-nova13:38
*** ekuris has quit IRC13:38
gibixgerman: I'm glad that it works for you too13:39
xgermanthanks - sorry, for the confusion13:39
*** ralonsoh__ has joined #openstack-nova13:41
*** ekuris has joined #openstack-nova13:43
*** ralonsoh_ has quit IRC13:43
gibino problem13:44
*** artom_ has quit IRC13:46
*** artom_ has joined #openstack-nova13:47
*** baoli has joined #openstack-nova13:47
*** artom_ has quit IRC13:48
*** artom_ has joined #openstack-nova13:48
*** ZZelle has quit IRC13:49
*** ZZelle has joined #openstack-nova13:50
*** ZZelle is now known as Guest1118213:50
*** marst has quit IRC13:52
*** efried has joined #openstack-nova13:52
*** mriedem has joined #openstack-nova13:53
*** amoralej is now known as amoralej|lunch13:54
*** Dinesh_Bhor has quit IRC13:55
*** dimtruck is now known as zz_dimtruck13:55
*** zz_dimtruck is now known as dimtruck13:55
*** marst has joined #openstack-nova13:58
*** eharney has joined #openstack-nova13:58
*** burt has joined #openstack-nova13:58
*** amotoki has quit IRC13:59
*** ekuris has quit IRC14:00
openstackgerritSteve Noyes proposed openstack/nova master: Do not attempt volume swap when guest is stopped/suspended  https://review.openstack.org/38979814:02
*** lucasxu has joined #openstack-nova14:03
*** artom_ is now known as artom14:04
*** gcb has quit IRC14:05
*** ratailor has joined #openstack-nova14:05
*** fragatina has joined #openstack-nova14:06
mordredsdague: in the nova api docs, the reboot action and the resize action each show examples of payloads that have more keys and values than are documented14:07
openstackgerritArtom Lifshitz proposed openstack/nova master: Plumbing for tagged nic attachment  https://review.openstack.org/41562214:08
openstackgerritArtom Lifshitz proposed openstack/nova master: Delete nic metadata when detaching interface  https://review.openstack.org/43538714:08
openstackgerritArtom Lifshitz proposed openstack/nova master: Libvirt support for tagged volume attachment  https://review.openstack.org/41810014:08
sdaguemordred: pointer?14:08
openstackgerritArtom Lifshitz proposed openstack/nova master: Delete disk metadata when detaching volume  https://review.openstack.org/43508214:08
openstackgerritArtom Lifshitz proposed openstack/nova master: Plumbing for tagged volume attachment  https://review.openstack.org/39194114:08
openstackgerritArtom Lifshitz proposed openstack/nova master: API support for tagged device attachment  https://review.openstack.org/37602114:08
openstackgerritArtom Lifshitz proposed openstack/nova master: Libvirt support for tagged nic attachment  https://review.openstack.org/41552014:08
sdaguemordred: I totally believe this could be the case14:08
*** gcb has joined #openstack-nova14:09
mordredsdague: https://developer.openstack.org/api-ref/compute/?expanded=reboot-server-reboot-action-detail,resize-server-resize-action-detail14:09
mordredsdague: reboot has 'type': 'HARD' in the example (is soft maybe another option?)14:09
mordredand resize has flavorRef and OS-DCF:diskConfig - I'm assuming flavorRef takes a flavor id - not sure what values other than AUTO are good for OS-DCF:diskConfig14:10
sdagueyeh, so I have an unsatisfying answer for you14:10
mordredyay!14:10
sdaguewhich is we've just not finished that scrube14:10
sdaguelet me see if there are some outstanding patches14:10
mordredokie. no worries if it's ongoing - I mostly wanted to report if it was an oversight14:10
*** vks1 has joined #openstack-nova14:11
openstackgerritSean Dague proposed openstack/nova master: Add server-action-removefloatingip.json file and update servers-actions.inc  https://review.openstack.org/44647114:12
*** nic has joined #openstack-nova14:12
*** Guest11182 is now known as ZZelle_14:12
sdagueyeh, the file still has the .. needs:parameter_verification14:13
sdague.. needs:example_verification14:13
sdague.. needs:body_verification14:13
sdagueat the top of it14:13
mordredcool14:13
*** dikonoo has quit IRC14:15
sdaguemordred: if you had to pick one action to be right, which one would you want? I'll write on api-ref patch today on it14:15
*** dikonoor has quit IRC14:15
ZZelle_Hi everyone14:15
*** ekuris has joined #openstack-nova14:15
mriedemmordred: HARD and SOFT are options https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L23914:16
ZZelle_It seems there is two different ways to add a new interface to a VM: using the action AddFixedIp and using os-interface resource ... which one should we prefer?14:16
*** nkrinner is now known as nkrinner_afk14:16
mordredsdague: neither is super urgent - but mriedem just answered reboot for me, so I'll vote for resize :)14:16
*** jamielennox is now known as jamielennox|away14:16
*** tuanla_ has quit IRC14:17
*** tuan_luong has quit IRC14:17
sdagueok14:17
mriedemhere is the resize request schema https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L19214:17
mriedemflavorRef is the only thing that's required14:17
mriedemi believe the diskConfig stuff is all xen14:18
mriedemall xen, all the time14:18
mordreddo we expect reboot will ever get a type other than hard or soft?14:18
mordredyay xen!14:18
mriedemZZelle_: we're going to deprecate addFixedIP14:18
mriedemmordred: such as?/14:18
ZZelle_mriedem, ok so i will use os-interface instead of AddFixedIp in OSC14:18
mordredmriedem: dunno. I was thinking of making the python paramter "hard=True" rather than type="HARD"|"SOFT"14:19
mordredmriedem: but making it a bool flag would get weird if in the future we made a "SQUISHY" or something14:19
*** tuan_luong has joined #openstack-nova14:20
mriedemlimp?14:20
*** tuanla_ has joined #openstack-nova14:20
mordredyah. please do a limp reboot on that server14:21
mriedemlimp == reboot the guest, but make sure my network and volumes are no longer connected14:21
mriedembecause i like to be dumb14:21
mordredhahahaha14:21
*** nic has quit IRC14:21
mordredthat seems like a good patch for tomorrow14:21
*** yamamoto has joined #openstack-nova14:21
mriedemZZelle_: fyi https://review.openstack.org/#/c/384261/14:22
ZZelle_mriedem, thx14:22
mriedemZZelle_: also, this is old https://review.openstack.org/#/c/350277/ but i'm not totally sure yet what the long-term plan for os-interface is14:23
mriedemZZelle_: but for now i think using that for adding an interface is what you want14:23
*** satyar has joined #openstack-nova14:24
mriedemthat was proposing to deprecate the GET methods, but i think we said we didn't want that, and we should deprecate os-virtual-interfaces, and make os-interfaces work like os-volume_attachments14:25
mriedembut that's probably all queens work at this point14:25
ZZelle_mriedem, if we deprecate os-interface how do we attach a new interface to a VM :s?14:25
ZZelle_mriedem, ok14:25
mriedemthe spec was for deprecating the GET methods,14:25
mriedemnot POST or DELETE14:25
ZZelle_mriedem, ok14:25
mriedemit's a bit confusing, sorry about that14:25
mriedemanyway, https://developer.openstack.org/api-ref/compute/#port-interfaces-servers-os-interface is what you want14:26
*** jjung has joined #openstack-nova14:29
*** suresh12 has joined #openstack-nova14:31
*** nkorabli has joined #openstack-nova14:32
*** jroll has quit IRC14:32
*** jroll has joined #openstack-nova14:34
*** nkorabli has quit IRC14:34
*** nkorabli has joined #openstack-nova14:35
*** amoralej|lunch is now known as amoralej14:36
*** nkorabli_ has joined #openstack-nova14:39
*** nkorabli has quit IRC14:39
*** prateek has quit IRC14:39
*** adisky_ has quit IRC14:39
*** sneti_ has joined #openstack-nova14:41
*** dillaman has joined #openstack-nova14:41
*** jaypipes has joined #openstack-nova14:43
*** jaypipes is now known as leakypipes14:44
*** ducttape_ has quit IRC14:44
*** ducttape_ has joined #openstack-nova14:44
mriedemlyarwood: if you haven't started on it yet, i was going to push the changes to cleanup my nits in the detach refactor patch14:44
*** dimtruck is now known as zz_dimtruck14:45
*** zz_dimtruck is now known as dimtruck14:45
*** ducttape_ has quit IRC14:45
*** ducttape_ has joined #openstack-nova14:45
lyarwoodmriedem: if you already have a commit feel free to push it14:46
*** ducttape_ has quit IRC14:46
*** ducttape_ has joined #openstack-nova14:46
*** ducttape_ has quit IRC14:47
*** jahsis has quit IRC14:49
*** ratailor has quit IRC14:49
mdboothkaisers: I looked at --scope. I didn't actually test it, but from reading the docs it was my understanding that a --scope group will be terminated automatically with its parent14:50
mdboothkaisers: I wouldn't bet my house on that, though.14:50
*** stvnoyes has left #openstack-nova14:50
*** dimtruck is now known as zz_dimtruck14:54
dimsdulek : posted a day early? https://review.openstack.org/#/c/452219/14:54
dims:)14:55
*** voelzmo has quit IRC14:57
cdentoh no, not that time of year :(14:57
lyarwoodmelwitt: btw https://review.openstack.org/#/c/451870/ is another trivial docs change if you have time today14:57
mriedemheh14:58
mriedemtweetmq?14:58
mriedemisn't there a forum session about dropping all other MQ backends except rabbit?14:58
*** ducttape_ has joined #openstack-nova14:58
mriedemhttp://forumtopics.openstack.org/cfp/details/814:58
melwittlyarwood: looking14:58
melwittlol "I would love to see an USPS as a possibility here"15:00
mdboothkaisers: Hmm, kinda find the reason I thought that now. Could be I was imagining it. Have you tested this manually, btw?15:00
mdboothkinda? can't15:01
*** ijw has joined #openstack-nova15:01
openstackgerritSujitha proposed openstack/nova master: Adding tags field to InstancePayload  https://review.openstack.org/40722815:01
leakypipessfinucan: quick review on this please? https://review.openstack.org/#/c/451635/215:02
*** joanna__ has joined #openstack-nova15:02
*** arne_r has quit IRC15:05
*** rcernin has quit IRC15:08
openstackgerritSujitha proposed openstack/nova master: Change tags to default field in Instance object.  https://review.openstack.org/41529815:10
openstackgerritSujitha proposed openstack/nova master: Adding auto_disk_config field to InstancePayload  https://review.openstack.org/41918515:10
openstackgerritSujitha proposed openstack/nova master: Reduce calls to load_tags() to 0  https://review.openstack.org/43514615:10
*** belmoreira has quit IRC15:10
openstackgerritSujitha proposed openstack/nova master: Add keypairs field to InstancePayload  https://review.openstack.org/41973015:12
*** psachin has quit IRC15:13
cfriesenare there any qemu-knowledgable folks around?  When using qcow2 instance storage I'm wondering why we convert backing file images to raw rather than just leaving them in whatever format they were in (raw, qcow2).15:14
*** kaisers_ has joined #openstack-nova15:16
kaisers_mdbooth: Hi! Yep, i tested this manually. --scope works for me. I actually hacked it into the driver in a test instance and killed the n-cpu process hard, mount point remained active15:18
mdboothkashyap: That's not quite the same thing15:18
kashyapcfriesen: Good question, I once recall digging it, and now lost it from memory15:18
mdboothEurgh15:18
mdboothkaisers: ^^^15:18
kaisers_mdbooth: :)15:18
mdboothkaisers_: Did you try stopping the nova-compute service?15:19
*** ducttape_ has quit IRC15:19
*** nic has joined #openstack-nova15:19
kaisers_mdbooth: systemd produces a slice unit who becomes parent of the process15:19
kaisers_hmm15:19
kaisers_mdbooth: i can revisit that15:19
*** READ10 has joined #openstack-nova15:19
kaisers_mdbooth: but that should behave similarily15:19
mdboothkaisers_: Having read it again, I suspect it should work15:20
kaisers_mdbooth: as the bug comes up as soon as the cgroup is closed15:20
mdboothAnd frankly this is in your driver, so I'd personally be inclined to take your word for it as a functional test would be logistically difficult15:20
kashyapcfriesen: Are you hitting this? -- "Converting image from qcow2 to raw is slow for images with large virtual size" -- https://bugs.launchpad.net/nova/+bug/148499215:20
openstackLaunchpad bug 1484992 in OpenStack Compute (nova) "Converting image from qcow2 to raw is slow for images with large virtual size" [Wishlist,Confirmed]15:20
*** zz_dimtruck is now known as dimtruck15:20
kaisers_mdbooth: ack15:20
mdboothkaisers_: However, given the bug you're trying to fix, if it were me I'd want to test this15:20
kaisers_yep, i'll do that15:21
*** yamamoto has quit IRC15:21
*** armax has joined #openstack-nova15:22
*** hongbin has joined #openstack-nova15:23
sfinucanleakypipes: Done15:24
leakypipessfinucan: thanks!15:24
leakypipessfinucan:  or however you say thanks in Irish :P15:24
* leakypipes gets sfinucan a Guiness.15:24
sfinucanleakypipes: Go raibh maith agat ;)15:25
leakypipesah, well, that too! :)15:25
*** yamamoto has joined #openstack-nova15:25
sfinucanleakypipes: This is one to stick in your review queue for today :) https://review.openstack.org/#/c/361140/15:25
*** trinaths has joined #openstack-nova15:25
sfinucan...or for next weeks spec review drive15:26
*** adrian_otto has joined #openstack-nova15:26
cfriesenkashyap: yep.  and in our case it's made worse by the fact that we do the conversion with ionice and no output caching (necessary to minimize impact of the conversion IO load on the instances using the same disk)15:26
kashyapcfriesen: I'm looking at this function _disk_qcow2_to_raw()15:26
kashyapAnd it's not being used anywhere from my current `grep`ing15:26
kashyapIt was introduced as a helper to be used in nova/virt/libvirt -> finish_migration()15:27
cfriesenkashyap: in our case we're hitting it when downloading the backing image file during a block live migration for a qcow2-based instance15:27
*** jjung has quit IRC15:28
kashyapcfriesen: Do you have a full test case?15:28
*** jaosorior has quit IRC15:28
*** trinaths1 has joined #openstack-nova15:29
cfriesenkashyap:  boot instance with qcow2 storage, live-migrate it to a compute node that doesn't have the image cached yet.15:29
kashyapcfriesen: I _think_ I know why we do the conversion:15:29
mriedemdansmith: weird the logs are not found for https://review.openstack.org/#/c/452006/15:30
mriedemon the failed jobs15:30
*** nic has quit IRC15:30
mriedemanyway i left some comments15:30
kashyapThere's an epic comment from mdbooth in the function finish_migration()15:30
*** trinaths has quit IRC15:30
kashyapcfriesen: It's to avoid CVEs from format probing15:30
mriedemdansmith: i'm be wary of using the IntegratedHelperMixin15:30
dansmithmriedem: known issue apparently15:30
leakypipessfinucan: yeah, will try to get to that once I complete a review of jianghuaw's VGPU stuff.15:30
mriedemand I'd use USES_DB_SELF = True with the NoDbTestCase i think so you can setup the db yourself15:30
dansmithmriedem: I was copying the server groups test15:30
mriedemavoiding default cells or something15:30
kashyapcfriesen: Hmm, but wait -- format probing is not the only rationale, because to avoid that, the solution is to explicitly specify the format of the backing file15:31
*** lucasxu has quit IRC15:31
leakypipessfinucan: plus, I'm technically snikitin_'s boss so if I don't get to that review today, he can bitch at me all he wants to over the weekend or Monday ;P15:31
mriedemdansmith: fwiw this is how i've been doing them lately https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1671648.py15:31
mriedemcompletely self-contained15:31
mdboothkashyap: IIRC that code is only applicable when the source and destination hosts have different storage configurations15:31
kashyapcfriesen: Can you reproduce it with Git Master?15:31
sfinucanleakypipes: :D15:32
mdboothAs you say, it stops a security bug in that case15:32
mdboothWe really shouldn't be doing it, thoug15:32
* kashyap nods15:32
dansmithmriedem: ack15:32
mdboothh15:32
cfriesenkashyap: I think that's different.  in our case the conversion is done under pre_live_migration(), wheich eventually calls down to libvirt.utils.fetch_image(), which calls fetch_to_raw()15:32
cfriesenkashyap: let me check master15:32
kashyapmdbooth: But cfriesen seems to imply that we unconditionally convert any raw to qcow2 -- do we do that at all?15:32
mdboothcfriesen: What's the issue?15:32
kashyapcfriesen: Oh right, fetch_to_raw(), it's from utils.py15:32
mdboothcfriesen: Are you getting different backing file formats on source and destination?15:32
kashyapmdbooth: See the bug in the scrollback15:33
kashyapmdbooth: https://bugs.launchpad.net/nova/+bug/148499215:33
openstackLaunchpad bug 1484992 in OpenStack Compute (nova) "Converting image from qcow2 to raw is slow for images with large virtual size" [Wishlist,Confirmed]15:33
kashyapChris is hitting the above15:33
cfriesenmdbooth: no, we're hitting a performance issue when converting a downloaded qcow2 image to raw for use as a backing file, as part of pre_live_migration()15:33
mdboothcfriesen: Ah15:33
mdboothSo, you don't actually have to convert those15:33
mdboothThat's a config option15:34
mdboothHowever, it's an ongoing issue that changing storage config after deployment is a minefield15:34
kashyapAh, right, I thought I saw one15:34
*** suresh12 has quit IRC15:34
cfriesenmdbooth: force_raw_images ?15:35
kashyap'force_raw_images = True'15:35
mdboothcfriesen: Sounds about right, yeah15:35
kashyapYep, that seems to be it - (BoolOpt) Force backing images to raw format15:35
*** wagnqwsh has joined #openstack-nova15:35
mdboothcfriesen: You're using LVM?15:35
cfriesenmdbooth: no, qcow2 in this case.15:35
cfriesenmdbooth: lvm in other cases though15:35
mdboothOk, because I didn't think live migration worked on lvm... does it?15:36
mdboothOr is that only cold migration?15:36
* mdbooth is quite sure cold migration doesn't work15:36
*** lpetrut has quit IRC15:36
cfriesenmdbooth: cold works in our environment, we patched it in. :)15:36
mdboothHehe, ok15:36
mdboothcfriesen: Yeah, if you want to avoid the conversion step, force_raw_images = False is what you want15:38
mdboothIt should probably be the default, tbh15:38
openstackgerritSivasathurappan Radhakrishnan proposed openstack/nova master: Return 400 when compute host is not found  https://review.openstack.org/44735515:38
openstackgerritSivasathurappan Radhakrishnan proposed openstack/nova master: Reset instance status on invalid host  https://review.openstack.org/40100915:38
mriedemlyarwood: ah i realize now we don't have any unit test coverage on detach or driver_detach in nova.virt.block_device now15:39
mriedemyou had the TODOs in test_compute_mgr15:39
kashyapmdbooth: There should surely be some rationale documented as to why it was chosen to be 'True' by default?15:39
mdboothsurely15:39
cfriesenmdbooth: do you know if that has any impact on guest performance?  I guess it'd be another level of indirection.15:39
mdboothcfriesen: You'd have to measure it. My guess would be that it wouldn't be significant, though, over what you've already got.15:40
kashyapcfriesen: If it's a qcow2, "it depends", isn't it -- whether you've fully `fallocate`d it (at that point, it is equivalent to raw), or you've only preallocated the qcow2 metadata, etc15:40
*** chyka has joined #openstack-nova15:41
*** sridharg has quit IRC15:42
*** artom has quit IRC15:42
cfriesenmdbooth: hashyap: looks like it was defaulted to False back in "essex", because that was the then-current behaviour.  Was added by Vishvananda Ishaya.15:42
*** artom has joined #openstack-nova15:42
mdboothkashyap: All allocation delay would be on the top layer, regardless of the backing file format. My guess is that for read-only a qcow2 backing file would be very low overhead.15:43
lyarwoodmriedem: right, I can follow up with that early next week and move things across I just didn't want the original change to grow out of control tbh15:43
kashyapmdbooth: You are correct.  Because the backing file, by definition is read-only15:43
kashyap(Although upstream QEMU seems to be mulling over 'writable' backing files at one point.)15:44
mdboothkashyap: Multi-writer qcow2 would be awesome, btw15:44
*** jjung has joined #openstack-nova15:45
mdboothqemu has a copy-on-read feature, don't know if you've seen that. You can use it to cache a remote disk image locally as it's read from a remote source.15:45
mdboothSo, e.g. you can boot using the curl backend directly from an iso hosted on a remote webserver15:45
*** kaisers_ has quit IRC15:46
kashyapmdbooth: Yes, I've seen COR15:46
mdboothYou create a local qcow2 with COR and a remote backing file15:46
mdboothAnd you can boot it immediately, without waiting for it to finish downloading at all15:46
*** pcaruana has quit IRC15:46
*** kaisers_ has joined #openstack-nova15:46
mdboothThis would be fantastic for this case. Problem is that because the backing file is in the image cache, it has multiple writers15:47
mdboothAnd we can't support that :(15:47
kashyapmdbooth: Oh right, probably you should write up an RFE bug on LP before this goes into the void of scrollback15:47
*** yamamoto has quit IRC15:47
cfriesenmdbooth: kashyap: thanks guys, I've got options to try out now. :)15:47
*** artom has quit IRC15:48
*** artom has joined #openstack-nova15:48
mdboothcfriesen: Sadly, I don't think this change will cause existing downloads to break15:48
*** yamamoto has joined #openstack-nova15:48
mdboothI say sadly, because we do format inspection on backing files :(15:48
dansmithmriedem: you use cast-as-call in your test, for a reason I assume.. do you know why I'm getting NotFound and need that poll loop?15:49
kashyapmdbooth: BTW, do you really mean two users trying to simultaneously to a qcow2 file?15:49
mdboothI don't know of any current security issues relating to this, but it's still a danger15:49
*** armax has quit IRC15:49
kashyaps/users/processes/15:49
*** armax has joined #openstack-nova15:50
*** yamamoto has quit IRC15:50
*** yamamoto has joined #openstack-nova15:50
mdboothkashyap: So, you create a qcow2 file with a remote backing file and COR, lets call this cache.qcow15:50
*** yamamoto has quit IRC15:50
mdboothkashyap: You then create instance_a.qcow2 which has cache.qcow2 as a backing file15:50
openstackgerritMatt Riedemann proposed openstack/nova master: Address comments when moving volume detach to block_device.py  https://review.openstack.org/45225215:51
mriedemlyarwood: ^15:51
mriedemdansmith: i used cast as call because that's what the test did that i copied from :)15:51
dansmithheh, yeah okay15:51
mriedemdansmith: as for the 404 while it's building...15:51
mdboothWhen you read a block from instance_a.qcow2, it'll be looked up in cache.qcow2, miss, be downloaded, and stored in cache.qcow before being returned to instance_a.qcow215:51
*** kaisers_ has quit IRC15:51
mdboothSo basically, the qemu process writing to instance_a.qcow2 is also writing to cache.qcow215:51
mriedemdansmith: could be hitting some window between when the build request and instance exist for the get() method in the compute API?15:51
mriedemdansmith: i thought we closed that in ocata thoguh15:52
mriedem*though15:52
mdboothNow simultaneously do the same thing with instance_b.qcow215:52
*** raunak has joined #openstack-nova15:52
lyarwoodmriedem: ack thanks, LGTM15:52
dansmithmriedem: well, that's my point.. we shouldn15:52
dansmithmriedem: shouldn't have that problem15:52
mdboothYou've now got 2 separate qemu processes writing to cache.qcow2 without coordination15:52
mdboothI don't believe this will end well15:52
kashyapmdbooth: Hmm.  It's not security issues (about multiple processes trying to write to a qcow2 file live), but image being corrupted -- as we speak, there are patches using POSIX / Linux file-locking to prevent that at QEMU-level15:52
mdboothkashyap: The security issue is image format detection15:53
mdboothWe shouldn't rely on it, but we do15:53
kashyapmdbooth: Oh, you were talking to Chris there, duh :-)15:53
mdboothBut in this case it's convenient that we do, because it won't break anything if you change force_raw15:53
dansmithmriedem: ah, I know why15:53
kashyapmdbooth: But I agree with your design of speeding up remote boots with COR15:53
*** ralonsoh__ is now known as ralonsoh15:54
mriedemdansmith: what i'd do, is temporarily hack your test change to change https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L1144 and do LOG.exception so you get the traceback15:54
*** mlavalle has joined #openstack-nova15:54
dansmithmriedem: I done already figger'd it15:54
mriedemdo tell15:54
mriedemno instance mapping?15:54
dansmithno, because that's not a bug15:55
*** Swami has joined #openstack-nova15:55
openstackgerritSivasathurappan Radhakrishnan proposed openstack/nova master: Raise general error message when volume attach fails  https://review.openstack.org/32016315:55
dansmithit's service_version15:55
dansmithbecause of all the switchin' during service setup15:55
dansmithapi thinks api is old15:55
*** lucasxu has joined #openstack-nova15:55
*** trinaths1 has quit IRC15:55
dansmithwhich is why we have fixtures.AllServicesCurrent()15:55
mriedemhttps://github.com/openstack/nova/blob/master/nova/compute/api.py#L2386 ?15:56
*** fragatina has quit IRC15:56
dansmithmriedem: yar15:56
*** Guest16838 has quit IRC15:56
mriedemis service_version 0 or soething?15:56
mriedemsomething15:56
mriedemthis reminds me of something i've been meaning to talk to you about,15:56
dansmithit is in the db that is getting consulted15:56
mriedemhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L43715:57
dansmithHAH15:57
mriedemin the api we check the minimum compute service version for things like get-me-a-network and device tags15:57
*** armax has quit IRC15:57
*** cjvolzka has joined #openstack-nova15:57
mriedemthat's not going to work anymore with multicell15:57
*** cjvolzka has quit IRC15:57
kashyapmdbooth: One last on that -- in your scenario of speeding up a remote boot while provisioning, it is still a single QEMU process that is handling COR, and live commit, isn't it...15:57
mriedemhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L58315:57
dansmithmriedem: well (a) we need to remove those now anyway, but (b) there's an all_cells worker to get that15:58
mdboothkashyap: Not if you've got 2 instances using the same image backing file15:58
kashyapmdbooth: Ah, right!15:58
*** armax has joined #openstack-nova15:58
mdboothBoth before the backing file download has finished15:58
kashyapmdbooth: But yes, as it stands, upstream doesn't support multiple writers15:58
mriedemdansmith: yeah https://github.com/openstack/nova/blob/master/nova/cmd/api_os_compute.py#L4315:59
kashyapProbably you want to write an RFE to qemu-{devel, block} lists :-)15:59
mdboothCOR == implicitly writeable backing file15:59
mriedemdevice tagging was newton too right?15:59
mriedemyeah, i know it wasn't ocat15:59
mriedem*ocata15:59
*** armax has quit IRC15:59
dansmithmriedem: well, it was fixed in ocata api, but yeah15:59
mriedemhowever15:59
mriedemwe have something else using that now in nova.compute.api16:00
mriedemhttps://github.com/openstack/nova/blob/master/nova/compute/api.py#L140416:00
mriedem^ was added in pike16:00
dansmithack16:00
mriedemwe could remove the checks for get me a network and device tags though probably16:00
mriedemi can't find your nova-status patch16:01
mriedemah https://review.openstack.org/#/c/442787/16:01
*** ltomasbo is now known as ltomasbo|away16:02
openstackgerritDan Smith proposed openstack/nova master: Add functional test for two-cell scheduler behaviors  https://review.openstack.org/45200616:03
*** ekuris has quit IRC16:04
*** ducttape_ has joined #openstack-nova16:05
*** ekuris has joined #openstack-nova16:05
*** ducttape_ has quit IRC16:05
*** ssurana has joined #openstack-nova16:06
*** gcb has quit IRC16:07
mriedemdansmith: that looks much better16:09
*** gcb has joined #openstack-nova16:09
*** dtp has joined #openstack-nova16:09
dansmithI'm thrilled16:09
*** Guest16838 has joined #openstack-nova16:11
leakypipes_gryf: lol at Michal's April Fool's spec :)16:11
leakypipesdulek: :)16:12
*** ducttape_ has joined #openstack-nova16:12
*** artom has quit IRC16:14
*** artom has joined #openstack-nova16:14
*** dillaman has quit IRC16:14
* mriedem goes to lunch16:15
*** artom has quit IRC16:16
*** artom has joined #openstack-nova16:16
*** jjung has quit IRC16:16
*** derekh has quit IRC16:18
*** voelzmo has joined #openstack-nova16:20
*** markus_z has quit IRC16:22
*** cdent has quit IRC16:25
*** voelzmo has quit IRC16:25
*** voelzmo has joined #openstack-nova16:26
*** esberglu has quit IRC16:27
*** sneti_ has quit IRC16:27
*** esberglu has joined #openstack-nova16:27
*** lucasagomes is now known as lucas-afk16:28
*** jimbaker has joined #openstack-nova16:29
*** nkorabli_ has quit IRC16:29
*** lucasxu has quit IRC16:29
*** karimb has quit IRC16:30
*** voelzmo has quit IRC16:31
*** satyar has quit IRC16:32
*** karimb has joined #openstack-nova16:32
*** edmondsw has quit IRC16:32
*** esberglu has quit IRC16:32
*** ekuris has quit IRC16:33
ildikovmriedem: lyarwood: would the Cinder-Nova meeting work for you an hour earlier (1600 UTC) on Thursdays?16:33
openstackgerritAnusha Unnam proposed openstack/nova master: Add description to policies in server_password.py  https://review.openstack.org/45225916:33
*** nkorabli has joined #openstack-nova16:35
*** edmondsw has joined #openstack-nova16:35
lyarwoodildikov: yes16:35
*** ducttape_ has quit IRC16:36
*** ZZelle has joined #openstack-nova16:36
*** karimb has quit IRC16:36
ildikovlyarwood: cool, tnx16:36
*** cdent has joined #openstack-nova16:38
*** artom has left #openstack-nova16:39
*** edmondsw has quit IRC16:39
*** ducttape_ has joined #openstack-nova16:39
*** artom has joined #openstack-nova16:39
*** tuan_luong has quit IRC16:40
*** tuanla_ has quit IRC16:40
*** marst has quit IRC16:41
*** Apoorva has joined #openstack-nova16:42
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova master: [WIP] Add Neutron port capabilities to devspec in request  https://review.openstack.org/45177716:43
*** ralonsoh has quit IRC16:44
*** marst has joined #openstack-nova16:44
*** fragatina has joined #openstack-nova16:45
*** karimb has joined #openstack-nova16:45
*** ekuris has joined #openstack-nova16:48
*** ducttape_ has quit IRC16:50
*** yamamoto has joined #openstack-nova16:51
*** ekuris has quit IRC16:53
*** abalutoiu has quit IRC16:53
*** ducttape_ has joined #openstack-nova16:53
*** lucasxu has joined #openstack-nova16:54
*** lpetrut has joined #openstack-nova16:54
*** efried has quit IRC16:54
*** jpena is now known as jpena|off16:55
*** sneti_ has joined #openstack-nova16:55
*** yamamoto has quit IRC16:57
*** suresh12 has joined #openstack-nova16:59
*** gyee has joined #openstack-nova16:59
*** ducttape_ has quit IRC17:03
openstackgerritAnusha Unnam proposed openstack/nova master: Add description to policies in server_external_events.py  https://review.openstack.org/45226317:05
*** yonglihe has quit IRC17:09
*** armax has joined #openstack-nova17:10
*** sambetts is now known as sambetts|afk17:12
*** armax has quit IRC17:16
*** MVenesio has joined #openstack-nova17:18
*** yamahata has joined #openstack-nova17:19
*** browne has joined #openstack-nova17:21
*** mnestratov has quit IRC17:24
openstackgerritAnusha Unnam proposed openstack/nova master: Add description to policies in server_diagnostics.py  https://review.openstack.org/45226717:26
JayFmriedem: https://review.openstack.org/#/c/416487/ mind dropping your procedural -2 from last cycle?17:26
JayFmriedem: we're tying all the patches together now to get it all tested up in tempest and ready to merge (in ironic, then nova)17:26
*** awaugama has quit IRC17:28
*** lpetrut has quit IRC17:31
*** lpetrut has joined #openstack-nova17:32
*** swamireddy has quit IRC17:36
*** vks1 has quit IRC17:36
*** mdrabe has quit IRC17:38
jrolloh we should approve that blueprint17:49
*** gszasz has quit IRC17:51
*** armax has joined #openstack-nova17:51
openstackgerritMario Villaplana proposed openstack/nova master: virt/ironic: Implement rescue and unrescue  https://review.openstack.org/41648717:51
JayFmriedem: \o/ thanks17:52
mriedemyw17:53
mriedemildikov: works for me17:53
sdaguemriedem: so... clarkb has an interesting though on the libvirt malloc crashes, which is that we start doing UCA by default17:55
sdaguewhich would mean jumping up to libvirt 2.5 in master17:55
sdagueit has a lot of other implications, he's going to write the whole thing up to share on the ML17:55
mriedemok17:55
sdaguebut, I wanted to get that seed out there for everyone to ponder17:55
sdagueit would mean we'd start testing some of the pathways that aren't otherwise tested17:56
mriedemwell, some of those are things like numa/pci right?17:56
*** suresh12 has quit IRC17:56
mriedemwhich i don't think we'd be testing regardless17:56
clarkbI think there are newer live migration things too17:57
clarkbat least my tests tripped over that with bad wheel builds against old libvirt17:57
*** kaisers_ has joined #openstack-nova17:57
sdagueyeh, postcopy17:58
*** unicell has joined #openstack-nova17:58
sdagueand virtlogd17:58
mriedemwhat are we right now? 1.3.1?17:58
sdagueyep17:58
sdagueand perf_events?17:59
mriedemyeah, so the only thing of those that would get tested by tempest are probably postcopy17:59
mriedemunless virtlogd ties in with any console-related tests17:59
sdaguethat seems like everything with higher versions bring in17:59
*** Guest16838 has quit IRC17:59
*** baoli has quit IRC18:00
mriedemyeah the perf events stuff won't be tested by tempest directly18:00
sdagueyeh, I think there might be console tests there18:00
sdagueanyway, a thing to ponder, details comming.18:00
*** baoli has joined #openstack-nova18:01
mriedemhttps://www.youtube.com/watch?v=09kuOAr_wkc18:02
mriedemi'll ponder it on the tree of woe18:02
*** kaisers_ has quit IRC18:02
*** suresh12 has joined #openstack-nova18:02
openstackgerritDavid Moreau Simard proposed openstack/nova master: Be honest with users when no valid host was found  https://review.openstack.org/45227918:02
*** Apoorva_ has joined #openstack-nova18:03
sdagueheh18:03
*** Apoorva has quit IRC18:05
*** baoli has quit IRC18:10
leakypipessdague, sfinucan: another easy one: https://review.openstack.org/#/c/447401/518:11
*** baoli has joined #openstack-nova18:11
sdaguebam18:11
leakypipesheh18:11
*** lucasxu has quit IRC18:12
*** sneti_ has quit IRC18:12
*** baoli has quit IRC18:12
*** baoli has joined #openstack-nova18:13
*** abalutoiu has joined #openstack-nova18:13
*** baoli has quit IRC18:19
mriedemi need another specs core on https://review.openstack.org/#/c/441692/18:20
mriedemi think i addressed all of johnthetubaguy's comments18:20
mriedemi'm not sure if there is something i need to update in there, so i haven't18:20
openstackgerritPeter Hamilton proposed openstack/nova-specs master: Add support for certificate validation  https://review.openstack.org/35715118:21
*** tesseract has quit IRC18:21
*** sneti_ has joined #openstack-nova18:21
*** nic has joined #openstack-nova18:23
*** fragatina has quit IRC18:24
sdaguemriedem: have you tried to POC any of that yet?18:24
mriedemsdague: no18:24
mriedemi started by just trying to get devstack setup with searchlight in a ci job18:24
mriedemhttps://review.openstack.org/#/c/441696/18:25
sdaguehow did that go?18:25
mriedemnot well18:25
mriedemi didn't spend much time on it18:25
mriedemi was hoping the searchlight devstack plugin would configure nova, but it doesn't18:25
mriedemand now the logs are gone so i don't remember what was failing, i'll recheck it18:26
mriedemalso, searchlight doesn't have a dsvm job, so they didn't have something i could copy really18:26
sdagueso, it feels like one of those things were could define a direction here as we're going to try, but there should be a bit more POC before we commit (and especially punt on doing any of this in nova)18:26
sdaguemriedem: ah, bummer18:26
mriedemsdague: the spec is about the general plan18:26
mriedemjust like the original resource providers spec was about the general plan, and changed a lot over time18:27
sdagueok18:27
mriedemi also have http://forumtopics.openstack.org/cfp/details/31 proposed18:28
mriedemi agree poc would be ideal18:28
mriedemchances are this won't happen in nova in pike anyway, since there are dependencies on changes in searchlight first18:29
mriedemwhich don't have owners18:29
mriedembut it's The Plan (tm)18:29
*** thomasem has joined #openstack-nova18:30
*** cdent has quit IRC18:30
sdagueyeh, I guess I'd just soften it further from the recommended mode, given we have no idea if it's going to work. Just say, we think this is going to be a better search approach, and we want to implement an optional backend to get it into the field.18:32
sdagueI don't think this is nearly as straight forward an aggressive cut over as placement18:32
*** cdent has joined #openstack-nova18:32
openstackgerritKen'ichi Ohmichi proposed openstack/nova master: WIP: Add the specified microversion into error msg  https://review.openstack.org/45198618:32
openstackgerritKen'ichi Ohmichi proposed openstack/nova master: Remove unnecessary duplicated NOTE  https://review.openstack.org/45228418:32
mriedemi wouldn't say integrating placement has been straightforward18:33
*** sneti_ has quit IRC18:36
*** swamireddy has joined #openstack-nova18:38
*** crushil has joined #openstack-nova18:39
*** sridharg has joined #openstack-nova18:39
*** sridharg has quit IRC18:40
*** baoli has joined #openstack-nova18:40
mriedemmelwitt: so, i hate to talk about this, but before i fix the bug that's shown in https://review.openstack.org/#/c/449334/ - i'm thinking about what you said where were are committing the quota usage decrement in the api before we delete the instance, and on failure we try to rollback, but that doesn't work18:40
*** baoli has quit IRC18:40
*** baoli has joined #openstack-nova18:40
mriedemi noticed something funny in the quota object18:40
melwittokay18:41
mriedemon commit and rollback, if the reservation is not set, it's a noop18:41
mriedemhttps://github.com/openstack/nova/blob/master/nova/objects/quotas.py#L10018:41
mriedemhttps://github.com/openstack/nova/blob/master/nova/objects/quotas.py#L11118:41
mriedemi was wondering why we didn't fail18:41
mriedembut those are really invalid operations, if you're trying to commit or rollback reservations before you made the reservation, it's a bug18:41
mriedemright?18:41
melwittfwiw, I think it's a no-op at the db/api level too, so I don't think it matters18:41
mriedemi'm not sure that's a good reason though18:42
*** aunnam_ has quit IRC18:42
melwittsure18:42
mriedembut yeah, in the db api methods, if they don't find a reservation, they don't do anything18:42
mriedemi was wondering why we didn't get a NotFound error on delete18:42
melwittyeah, it's not valid to do a commit/rollback without a reserve first18:42
mriedemhttps://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L393418:42
mriedemhttps://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L392218:43
melwittI'm not sure what the reasoning is to do a no-op, if there's some case where that would be a thing18:43
mriedemreservations are just uuids right?18:43
melwittreservations are records in the reservations tables18:43
melwitt*table18:43
mriedemwith a uuid18:43
mriedemyeah18:43
mriedemfilter(models.Reservation.uuid.in_(reservations)).\18:43
mriedemhttps://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L386618:44
mriedemis on reserve18:44
mriedemwe get the list of uuids back18:44
mriedemand store that in the Quota object18:44
artomCan an instance have multiple fixed IPs?18:44
mriedemso maybe i'll tinker with making commit/rollback w/o a reservation in the object a failure18:44
melwittartom: I think so, if it's on multiple networks18:44
mriedemand see what falls out18:44
artommelwitt, thanks :)18:44
mriedemartom: yeah definitely18:44
clarkbmriedem: artom also ipv4 + ipv618:44
mriedemmultinic18:44
clarkber melwitt artom ^18:45
mriedemand ipv818:45
mriedemit's secret18:45
mriedemand new18:45
mriedemfull of tomatoe18:45
artomAre we running out of quarks to give IPv6s to?18:45
artomIoSAP?18:45
artomInternet of SubAtomic Particles...18:45
artomEesh, one bad joke and everyone shuts up?18:47
* mriedem changes shirts from the vomit18:47
artomWear a bib next time ;)18:47
mriedemyou'd have to warn me18:48
mriedemunless i start wearing one full time18:48
melwittmriedem: yeah, might be worth it to do an experiment. I can't imagine why no-op would be valid other than some sort of race where commit could possibly hit before the reserve and that leaving an orphan reservation is okay18:48
melwittI can't think of such a race, but I have heard of having a lot of orphaned reservations in the db. so that implies it happens somehow18:49
mriedemmaybe comstud is lurking18:49
*** suresh12 has quit IRC18:50
mriedeminteresting https://github.com/openstack/nova/blob/master/nova/quota.py#L140118:51
mriedemsame with rollback https://github.com/openstack/nova/blob/master/nova/quota.py#L142518:52
mriedemwe just ignore exceptions18:52
mriedemany exceptions18:52
mriedemno matter how much Vek says that's safe, it seems unsafe18:52
melwittheh18:52
mriedem" because the usage resynchronization will resolve the issue"18:52
mriedemwe don't re-sync by default do we?18:52
melwittwe do. on every reserve18:53
melwittit will do a sync for that project/user combo18:53
melwittit doesn't help if some other user in your project is out of sync though18:53
*** amoralej is now known as amoralej|off18:54
mriedemhttps://github.com/openstack/nova/blob/master/nova/conf/quota.py#L27818:54
mriedemi was thinking of ^18:54
melwittalso a reminder that quota counting will remove reservations and usages18:54
melwittoh, hm18:54
mriedemand https://github.com/openstack/nova/blob/master/nova/conf/quota.py#L26718:54
mriedemso i think by default, we don't refresh any of that stuff18:55
mriedemor resync18:55
mriedemso maybe the comment from Vek was more about, it will fix it, because we at rackspace turn those on...18:55
melwittyeah, okay. I didn't realize that defaulted to off18:55
melwittif it's on, then on every reserve it does a refresh if needed18:55
mriedemhttps://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L364718:55
mriedemyeah if needed18:55
mriedembased on age and until_refresh count18:56
melwittI think most operators turn it on, since going out of sync happens a fair bit18:56
mriedemso if blindly handling all exceptions https://github.com/openstack/nova/blob/master/nova/quota.py#L1425 and assuming we're ok is dependent on those config options, which default to not doing the thing that comment says we do automatically,18:56
mriedemit seems we should reraise the exception if those options aren't set18:56
mriedemat least one of them18:56
mriedemotherwise we're just silently failing18:57
melwittI guess I mean if usage != resource count if refreshes. not that that saves a lot I guess18:57
melwittmaybe. it's going to be moot soon, we hope18:57
*** baoli has quit IRC18:59
*** dtp has quit IRC18:59
*** kaisers_ has joined #openstack-nova18:59
*** lucasxu has joined #openstack-nova19:00
*** baoli has joined #openstack-nova19:00
*** baoli has quit IRC19:00
mriedemwhat kind of state is that series in now?19:01
*** lucasxu has quit IRC19:02
*** suresh12 has joined #openstack-nova19:02
melwittI'm working on it and plan to push the series up today and see what tempest thinks of it19:03
melwittthere is light at the end of the tunnel finally19:04
*** baoli has joined #openstack-nova19:05
*** HW-Peter has quit IRC19:06
*** marst has quit IRC19:07
*** MVenesio has quit IRC19:10
mriedemok so by default, reservations expire after 24 hours,19:12
mriedemand there is a periodic task in the scheduler manager that triggers the expire routine19:12
openstackgerritdane-fichter proposed openstack/nova-specs master: Trusted flavors  https://review.openstack.org/31222519:12
*** cleong has quit IRC19:12
*** gcb has quit IRC19:12
*** gcb has joined #openstack-nova19:13
JayFIs there a standard username expected for login when an instance is rescued via `nova rescue`?19:15
JayFThere is not one documented in the client docs, afaict19:15
*** cdent has quit IRC19:17
mriedemhttps://espaces.edu.au/vwrangler/nectar-topics/nectar-how-tos/using-nova-rescue-to-repair-a-nectar-instance19:21
JayFthat one says "admin"19:21
mriedemi'm not totally sure, but i think the username depends on the image used19:21
JayFRackspace uses root19:21
JayFYeah, that's what I was afraid of19:21
JayFsince ironic provides the image we have to just decide19:21
*** ducttape_ has joined #openstack-nova19:22
clarkbfwiw if it were me, I would expect root19:22
JayFWe have it written today for "rescue@"19:22
JayFI think root is more reasonable... but it's unfortunate that it's not dictated19:23
JayFsomeone, just tell me what to do :P19:23
*** sdague_ has joined #openstack-nova19:23
mriedemdictated by the user making the rescue request?19:24
JayFdictated by a document, or something like that19:24
mriedembecause the admin on a windows rescue image is going to be Administrator, right?19:24
JayFI just want to be told what right is, because there being no "right answer" means I have to document the hell out of it19:24
JayFwe don't support arbitrary rescue images in ironic's implementatino19:24
JayFnot really possible since we're implementing rescue as booting a ramdisk and configuring it19:24
clarkbalso you should be able to rescue windows with linux but the other direction is much harder19:25
clarkb(there are even distros out there purpose built for this)19:25
mriedemJayF: what are you going to do in the nova driver impl then? ignore the image ref passed in, or put the instance into error state?19:25
JayFmriedem: ignore the one passed in, I think is how it's written19:25
JayFmariojv: ^ you just looked at that patch, do you know?19:25
sdague_mriedem: ok, going through https://review.openstack.org/#/c/441692 with a deeper comb. While I realize that it probably isn't going to get done in Pike anyway, it does feel better on an expectation front to say that Pike is about getting an optional facility there for people to play around with instead of jumping all the way to recommended operating mode19:25
*** baoli has quit IRC19:26
JayFmriedem: I think we're happy doing whatever you think is right in that case, but imo ignoring the image request seems the sanest.19:26
mriedemsdague_: isn't that what i said in there? i said a config option, disabled by default19:26
mriedemJayF: that's not honoring the API...19:26
JayFso you think we should put instance into error and raise an instance fault/19:26
mriedemso i'm not sure if it's better to fault and say you can't do that, or just ignore it19:26
JayF?19:26
*** baoli has joined #openstack-nova19:26
JayFI mean, technically, it's borderline impossible for us to respect the api with bare metal19:27
mriedemputting the instance into error state is maybe something we shouldn't do19:27
mriedemso it's a question of ignore, or fault19:27
sdague_https://review.openstack.org/#/c/441692/3/specs/pike/approved/list-instances-using-searchlight.rst@15 ... definitely leans in a different direction19:27
*** jwcroppe has quit IRC19:27
mriedemhttps://review.openstack.org/#/c/441692/3/specs/pike/approved/list-instances-using-searchlight.rst@4819:28
mriedem"By default this path will be disabled."19:28
JayFmriedem: I'll put a note on the nova patch for us to think about that case more explicitly -- right now we're trying to get the patches lined up to prove rescue working in tempest19:28
*** jwcroppe has joined #openstack-nova19:28
mriedemJayF: fwiw, when you do boot from volume or attach a volume and provide a device name in the api, the libvirt driver totally ignores that device name and has since liberty19:29
mriedemso we have some precedence for drivers ignoring the api19:29
clarkbJayF: couldn't you publish a rescue image in glance that would be used if specified, and its up to use to figure it out if they specify something different?19:29
JayFmriedem: prior are for ignoring the user, I'll take it :P19:29
JayFclarkb: we're treating it similar to a provisioning ramdisk, configurable by operator/deployer only19:29
JayFclarkb: and I would have to think hard about the security implications of letting an api end-user dictate an image to pxe boot19:30
JayFclarkb: plus it's sorta ... setting up a user for failure. I'd rather ignore their image request than provide support for it, but have building an image that works be borderline impossible without special knowledge.19:30
clarkbJayF: as a user of your APIs I really disagree on that last point19:31
clarkbI'm really tired of clouds making bad decisions for me and forcing me to abide by them when there is no reason to19:31
*** ducttape_ has quit IRC19:31
*** baoli has quit IRC19:31
clarkbimage upload is/was that same general problem. So what did people do they ran their own pxe servers and dd'd over ubuntu images with image that then booted pxe19:31
clarkb(it may make sense here but as a general rule I'm not a fan of it)19:32
JayFThere /is/ a reason for it here: rescue is not some arbitrary image booted on a hypervisor, it's a ramdisk, that has to have proper hardware support, as well as a properly configured ironic-python-agent. As someone who has operated ironic clouds, I'm not sure I'd want any of my api users being able to pxe boot an arbitrary ramdisk on hardware19:32
clarkbJayF: also fwiw I think your users likely can already pxe boot arbitrary ramdisks on hardware19:33
clarkb(its a really common workaround for the I can't upload my own images problem)19:33
JayFclarkb: not in an ironic configured for localboot only19:34
JayFclarkb: they can localboot anything they want, but not pxe boot it directly from ironic's setup19:34
clarkbJayF: you local boot the image that speaks pxe19:34
JayFoh, I forgot the #1 reason why that likely shouldn't be allowed:19:34
JayFwe pxe boot the rescue ramdisk from an internal-use-only rescue network19:35
JayFto flip it over to tenant networks before the rescue is complete19:35
JayFso allowing arbitrary ramdisks to boot in rescue would be enabling a tenant to run arbitrary code inside your rescue network19:35
JayFwhich would be a major security concern19:35
*** karimb has quit IRC19:36
*** kylek3h has quit IRC19:38
*** abalutoiu has quit IRC19:41
openstackgerritMatt Riedemann proposed openstack/nova master: Ensure reservation_expire actually expires reservations  https://review.openstack.org/45230019:45
openstackgerritMatt Riedemann proposed openstack/nova master: Ensure reservation_expire actually expires reservations  https://review.openstack.org/45230019:50
*** kaisers_ has quit IRC19:50
*** sdague_ has quit IRC19:51
*** sdague_ has joined #openstack-nova19:56
-openstackstatus- NOTICE: lists.openstack.org will be offline from 20:00 to 23:00 UTC for planned upgrade maintenance19:58
openstackgerritAnusha Unnam proposed openstack/nova master: Add description to policies in security_groups.py  https://review.openstack.org/45230920:01
*** liangy has quit IRC20:02
*** liangy has joined #openstack-nova20:04
*** ducttape_ has joined #openstack-nova20:11
*** Qiming has quit IRC20:12
*** tbachman_ has joined #openstack-nova20:14
*** tbachman has quit IRC20:15
*** tbachman_ is now known as tbachman20:15
leakypipesdansmith: is there such a thing as a cells.json file?20:15
dansmithleakypipes: um, what?20:16
leakypipescan you pop into #openstack-helm right quick?20:16
leakypipesdansmith: ^^20:16
leakypipesas superdan :)20:16
*** Qiming has joined #openstack-nova20:16
*** suresh12 has quit IRC20:20
*** suresh12_ has joined #openstack-nova20:20
*** dtp has joined #openstack-nova20:21
*** gouthamr has quit IRC20:22
*** MikeG451 has quit IRC20:22
*** liangy has quit IRC20:23
*** liangy has joined #openstack-nova20:28
*** READ10 has quit IRC20:34
*** lyan_ has joined #openstack-nova20:35
*** marst has joined #openstack-nova20:36
*** sdague has quit IRC20:36
*** liangy has quit IRC20:37
*** sdague_ has quit IRC20:41
*** Apoorva_ has quit IRC20:43
*** Apoorva has joined #openstack-nova20:44
openstackgerritMatt Riedemann proposed openstack/nova master: Reraise reservation commit/rollback errors if not self-healing  https://review.openstack.org/45231920:44
*** crushil has quit IRC20:45
*** eharney has quit IRC20:45
*** gouthamr has joined #openstack-nova20:46
*** bnemec is now known as beekneemech20:49
mriedemwow there was a whole lot of nothing going on in there20:51
*** MikeG451 has joined #openstack-nova20:54
*** Qiming has quit IRC21:01
*** Qiming has joined #openstack-nova21:02
openstackgerritScott Moser proposed openstack/nova master: Limit exposure of network device types to the guest.  https://review.openstack.org/40088321:04
*** fragatina has joined #openstack-nova21:05
*** kaisers has quit IRC21:07
*** fragatin_ has joined #openstack-nova21:08
*** ijw has quit IRC21:10
*** fragatin_ has quit IRC21:10
*** fragatin_ has joined #openstack-nova21:11
*** fragatina has quit IRC21:12
*** dimtruck is now known as zz_dimtruck21:13
*** xinliang has quit IRC21:13
*** pramodrj07 has joined #openstack-nova21:15
pramodrj07Hey All,21:15
*** sdague has joined #openstack-nova21:16
*** mvk has quit IRC21:18
pramodrj07Can anyone help me in understanding the differnece between security groups in nova and sg in neutron?21:21
*** aysyd has quit IRC21:22
mriedempramodrj07: security groups in nova are tied to nova-network, which has been deprecated since the newton release21:22
pramodrj07Oh cool! Thanks for clarification21:23
mriedemthe security group resource APIs were deprecated in the 2.36 microversion21:23
mriedemyou can provide security groups when creating a server, and nova will associate the security groups with ports that are attached to the server when creating it21:24
mriedemassuming the network that the port is on enables port security21:24
*** tbachman has quit IRC21:24
pramodrj07Oh ok! So the latest cli client will call neutron security group API when we try to create a sg!?21:25
mriedemwhich cli? nova boot or openstack server create?21:26
pramodrj07openstack security group create21:26
pramodrj07yes Openstack one21:26
mriedemthat is openstackclient and will use neutron if there is a network service type in the service catalog21:27
*** xinliang has joined #openstack-nova21:27
*** xinliang has joined #openstack-nova21:27
pramodrj07Oh ok! Gotcha!21:28
pramodrj07i am extending a plugin for rally to create sgs along with sg rules for neutron. I saw a similar scenario developed for nova. So wanted a clarification!21:30
pramodrj07Thanks a lot mriedem21:30
mriedemyw21:31
*** suresh12_ has quit IRC21:33
*** sdague has quit IRC21:33
*** xinliang has quit IRC21:44
*** nkorabli has quit IRC21:44
*** zz_dimtruck is now known as dimtruck21:44
*** burt has quit IRC21:45
-openstackstatus- NOTICE: The upgrade maintenance for lists.openstack.org has been completed and it is back online.21:50
*** tbachman has joined #openstack-nova21:51
*** ijw has joined #openstack-nova21:53
*** xyang1 has quit IRC21:56
*** xinliang has joined #openstack-nova21:57
*** xinliang has joined #openstack-nova21:57
*** ijw has quit IRC21:58
*** Swami has quit IRC21:59
*** leakypipes has quit IRC21:59
*** snikitin_ has quit IRC22:06
*** snikitin_ has joined #openstack-nova22:06
*** thorst has quit IRC22:10
*** raunak has quit IRC22:12
*** wagnqwsh has quit IRC22:13
*** wagnqwsh has joined #openstack-nova22:14
*** ijw has joined #openstack-nova22:17
*** figleaf is now known as edleafe22:18
*** tbachman has quit IRC22:19
*** artom has quit IRC22:26
*** artom has joined #openstack-nova22:26
*** jamesden_ has quit IRC22:27
*** artom has quit IRC22:30
*** artom has joined #openstack-nova22:30
*** dimtruck is now known as zz_dimtruck22:32
*** gouthamr has quit IRC22:34
*** catintheroof has quit IRC22:36
mriedemmelwitt: here is the bug for the quota commit/rollback thing in the api https://bugs.launchpad.net/nova/+bug/167832622:40
openstackLaunchpad bug 1678326 in OpenStack Compute (nova) "Quota is decremented during instance delete in cell0 even if the instance destroy fails" [High,Triaged] - Assigned to Matt Riedemann (mriedem)22:40
mriedemlong-time coming on writing that22:40
mriedemi don't have a good way of writing a regression test for that one really, unless i stub out instance.destroy() to raise InstanceNotFound to simulate concurrent deletes22:41
melwittmriedem: thanks for writing that up22:41
melwittI'm trying to remember how does the instance destroy fail22:42
*** crushil has joined #openstack-nova22:42
*** ducttape_ has quit IRC22:42
*** adrian_otto has quit IRC22:43
*** ducttape_ has joined #openstack-nova22:43
mriedemit could happen with concurrent delete requests couldn't it?22:43
*** ducttape_ has quit IRC22:43
melwittI just can't remember what happened to where we figured this out22:43
mriedemidk, it was copied from _delete_while_booting22:46
mriedemwhich was copied from _delete22:46
mriedemwhich checks for that here https://github.com/openstack/nova/blob/88bc8dc5ce32748452c9d3acda9f35e77fedb6ce/nova/compute/api.py#L180622:46
*** ducttape_ has joined #openstack-nova22:47
mriedemsorry wrong link there22:47
melwittlooks like int32bit described it in a comment on https://bugs.launchpad.net/nova/+bug/1670627 but didn't say how delete failed22:48
openstackLaunchpad bug 1670627 in OpenStack Compute (nova) ocata "quota is always in-use after delete the ERROR instances " [Critical,In progress] - Assigned to Matt Riedemann (mriedem)22:48
mriedemhttps://github.com/openstack/nova/blob/88bc8dc5ce32748452c9d3acda9f35e77fedb6ce/nova/compute/api.py#L202522:48
melwittsorry, krims0n32 is the lp name22:48
mriedemyeah i was wondering about that22:49
mriedemanyway, the old old code just says # NOTE(comstud): Race condition. Instance already gone.22:49
mriedemagain, this is all comstud's fault22:49
melwitthttps://bugs.launchpad.net/nova/+bug/1670627/comments/2722:49
openstackLaunchpad bug 1670627 in OpenStack Compute (nova) ocata "quota is always in-use after delete the ERROR instances " [Critical,In progress] - Assigned to Matt Riedemann (mriedem)22:49
*** zz_dimtruck is now known as dimtruck22:49
melwittheh22:50
mriedem2012 so who knows https://github.com/openstack/nova/commit/c729ba8c0aa4d283e84d139bc98e0e89fd933c4a22:50
mriedemseemed like a good idea at the time22:50
*** crushil has quit IRC22:51
mriedemhave you ever noticed this? https://github.com/openstack/nova/blob/88bc8dc5ce32748452c9d3acda9f35e77fedb6ce/nova/compute/api.py#L201022:51
*** ducttape_ has quit IRC22:51
mriedemi bet ^ is wrong now with the cellsv2 local delete case too22:51
melwittyeah, I was just curious how it happened, mostly to make sure that's the only problem and there isn't some additional problem22:51
melwittyeah, I have seen that before but it gets glossed over bc soft-delete22:52
*** adrian_otto has joined #openstack-nova22:52
melwittit gets removed in my series (all reserve/commit/rollback removed)22:53
mriedemi noticed it because of this https://github.com/openstack/nova/blob/88bc8dc5ce32748452c9d3acda9f35e77fedb6ce/nova/compute/manager.py#L233422:53
mriedemthe dumb thing is that we create the reservation in the api then just roll it back right away22:53
mriedemwe'd be smarter to just not create the reservations in the first place if it's soft delete22:54
mriedembut i'm sure that was fixed as a bolt-on bug fix to the already 30 bolt-ons to the local delete code22:54
melwittyeah, for real22:54
mriedemok so maybe rather than me spending time making quotas.commit/rollback fail instead of noop if there are no reservations, because of counting quotas removing all of that in master, i can just work on the functional regression test recreate and the fix since those have to be backported to ocata22:56
mriedemi wanted to fix this before https://bugs.launchpad.net/nova/+bug/167557022:56
openstackLaunchpad bug 1675570 in OpenStack Compute (nova) "Volumes are not detached when deleting shelved offloaded servers" [High,In progress] - Assigned to Zhenyu Zheng (zhengzhenyu)22:56
melwittyeah. I wonder if some of that will get consolidated bc of the need to call _local_delete in some cases22:58
mriedemthat's my plan22:58
mriedemrather than duplicate/triplicate everything, just re-use _local_delete22:58
mriedemfor the latter bug22:58
melwitt_local_delete is needed if the instance had ever been scheduled. which you can't tell from only instance.host bc of shelved offloaded I guess22:59
melwittthe other case (the 5-time-reverted patch I have up) is an instance in error state. it could have volumes attached even though it has instance.host = None23:00
melwittbecause there's code in compute that resets instance.host to None when setting to ERROR state23:00
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Make quotas.commit/rollback strict  https://review.openstack.org/45234623:00
*** ijw has quit IRC23:04
*** Sukhdev has joined #openstack-nova23:07
*** dimtruck is now known as zz_dimtruck23:08
*** edmondsw has joined #openstack-nova23:09
*** thorst has joined #openstack-nova23:11
*** edmondsw has quit IRC23:14
*** unicell has quit IRC23:14
*** adrian_otto has quit IRC23:15
*** thorst has quit IRC23:15
*** crushil has joined #openstack-nova23:15
*** adrian_otto has joined #openstack-nova23:18
*** zz_dimtruck is now known as dimtruck23:20
*** nrezinorn has joined #openstack-nova23:22
nrezinornHow new is the server.create_image snapshot function in nova client/api?  I am seeing a problem where randomly the snapshot fails, and the VM stays powered off.23:25
*** adrian_otto has quit IRC23:25
*** browne has quit IRC23:25
*** ducttape_ has joined #openstack-nova23:26
mriedemnrezinorn: probably extremely old23:28
mriedemgit blame will tell you23:28
*** ducttape_ has quit IRC23:28
mriedemthe client side code shouldn't be causing random issues, you're likely hitting something on the server side23:28
nrezinornits definately stuff server side, as you can see the errors here23:28
*** ducttape_ has joined #openstack-nova23:28
nrezinornhttps://gist.github.com/Nrezinorn/decc29d0f142eee34c693e7220090ad923:28
*** ducttape_ has quit IRC23:29
mriedemqemu is blowing up23:29
nrezinorn^in that i took a snapshot fine on that VM ~ 20-30 prior and it worked fine23:29
nrezinornit doesnt always blow up.23:29
*** ducttape_ has joined #openstack-nova23:30
nrezinorni will look through more RH bugreports for qemu , is there anything i can enable on the hupervisor to get more info than the error message from nova-compute?23:31
mriedemlibvirt debug logging23:31
mriedemsec23:31
mriedemthis is how we setup libvirt debug logging for our CI runs https://github.com/openstack-dev/devstack/blob/master/lib/nova_plugins/functions-libvirt#L10423:31
mriedemwhat version of qemu/libvirt?23:32
*** wagnqwsh has quit IRC23:32
nrezinornlibvirt-2.0.0-10.el7_3.4.x86_64  qemu-kvm-1.5.3-126.el7_3.3.x86_6423:33
*** chyka has quit IRC23:34
mriedemhmm, idk then, we're using what's in ubuntu 16.04 right now which is libvirt 1.3.123:34
nrezinornsorry this is on centos ;)23:34
nrezinornand i already looked to see if there were updated packages for both qemu and libvirt23:34
mriedemthat qemu looks pretty old actually23:35
nrezinorni will attempt the debug stuff you link on monday to see what is really going on.23:35
mriedemhttps://wiki.openstack.org/wiki/LibvirtDistroSupportMatrix23:35
nrezinornpretty old == CentOS7 pretty old ;)23:35
mriedem7.3   2016-11-03   2.0.0   2.6.023:35
mriedemis it centos 7.3?23:35
nrezinornyes23:35
mriedemoh 7.023:35
mriedemif it's 7.3, ^ says you should have qemu 2.6.023:35
mriedemnot 1.5.323:35
nrezinornhmmm23:36
nrezinornok thanks23:36
mriedemnp23:36
nrezinorni will look into why the packages are not lining up :)23:36
*** dimtruck is now known as zz_dimtruck23:38
nrezinornhmm, wonder where that 2.6.0 rpm lives...on my machine im on now its 7.3 and i only see 1.5.3 like above23:38
*** fragatina has joined #openstack-nova23:41
*** thorst has joined #openstack-nova23:42
*** ZZelle has quit IRC23:42
*** lyan_ has quit IRC23:42
mriedemmelwitt: ah writing a regression test for this commit/rollback thing shows me yet another problem :)23:44
mriedemit's a bountiful harvest of bugs23:44
melwitt:(23:44
*** fragatin_ has quit IRC23:44
mriedemnrezinorn: i'm not sure which service channels are used to build that list, or if it's just stock (i assume it's supposed to be stock)23:45
mriedemyou could ask sgordon but i think it's too late in the day for his tz23:45
mriedemmelwitt: right here https://github.com/openstack/nova/blob/88bc8dc5ce32748452c9d3acda9f35e77fedb6ce/nova/compute/api.py#L189123:46
mriedemwe don't return23:46
mriedembut we have an instance, and continue going down the old path23:46
melwittwah wah23:47
mriedemmaybe that's ok, idk23:47
mriedemhttps://github.com/openstack/nova/blob/88bc8dc5ce32748452c9d3acda9f35e77fedb6ce/nova/compute/api.py#L1836-L1906 was all really supposed to be for transition i think23:48
mriedemstill have the cell0 case though23:48
melwittit looks like it should return in that case23:49
mriedemwhere the quotas are in the main db and the instance is in the cell0 db23:49
*** gouthamr has joined #openstack-nova23:49
mriedemyeah i'm adding that23:49
dtpmriedem is the task of adding a uuid to service model still mine?23:51
nrezinornmriedem: im going to updgrade to those 2.6.0 RPMs Monday in our testing env - hoping this doesnt bite me though: https://www.redhat.com/archives/rdo-list/2016-December/msg00028.html23:51
mriedemdtp: it is23:52
*** unicell has joined #openstack-nova23:52
dtpcool, planning to start it monday23:52
nrezinorni'll know more next week, and will come back if i need another drink from the well of knowledge ;)23:52
mriedemnrezinorn: you could ask dmisard in #openstack-operators23:52
mriedemit's a shallow well with me23:52
mriedembut dmisard is around other channels23:52
nrezinornill do so monday!  5pm on a friday for me  :)23:53
mriedemdmsimard i mean23:53
mriedem7pm for me23:53
mriedemgood luck23:53
*** kaisers has joined #openstack-nova23:57
openstackgerritMatt Riedemann proposed openstack/nova master: Add regression test for quota decrement bug 1678326  https://review.openstack.org/45235123:59
openstackbug 1678326 in OpenStack Compute (nova) "Quota is decremented during instance delete in cell0 even if the instance destroy fails" [High,Triaged] https://launchpad.net/bugs/1678326 - Assigned to Matt Riedemann (mriedem)23:59
mriedemmelwitt: here is the regression test ^ i haven't run unit tests on the bug fix in nova.compute.api23:59
mriedemwill do that later23:59
mriedemi'm in trouble for being late to dinner23:59
melwittk, I'll check it out23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!