| *** rfolco has joined #openstack-nova | 00:00 | |
| *** adrian_otto has quit IRC | 00:00 | |
| *** rfolco has quit IRC | 00:00 | |
| *** rfolco has joined #openstack-nova | 00:02 | |
| *** rfolco has quit IRC | 00:02 | |
| *** dtp has quit IRC | 00:04 | |
| *** ssurana has joined #openstack-nova | 00:04 | |
| *** nkorabli_ has quit IRC | 00:09 | |
| *** yingjun has joined #openstack-nova | 00:10 | |
| *** adrian_otto has joined #openstack-nova | 00:15 | |
| *** sean-k-mooney has quit IRC | 00:17 | |
| *** hshiina has quit IRC | 00:18 | |
| *** ijw has quit IRC | 00:19 | |
| *** ijw has joined #openstack-nova | 00:19 | |
| *** sbezverk has joined #openstack-nova | 00:21 | |
| *** sean-k-mooney has joined #openstack-nova | 00:22 | |
| *** thorst_afk has joined #openstack-nova | 00:22 | |
| *** yassine has joined #openstack-nova | 00:25 | |
| *** ijw has quit IRC | 00:26 | |
| *** yassine is now known as Guest96685 | 00:26 | |
| *** armax has quit IRC | 00:29 | |
| *** nkorabli has joined #openstack-nova | 00:31 | |
| *** slaweq has joined #openstack-nova | 00:32 | |
| *** dikonoor has joined #openstack-nova | 00:32 | |
| *** hongbin has quit IRC | 00:33 | |
| *** gjayavelu has quit IRC | 00:33 | |
| *** Sukhdev has quit IRC | 00:35 | |
| *** annegentle has joined #openstack-nova | 00:36 | |
| *** Apoorva has quit IRC | 00:37 | |
| *** slaweq has quit IRC | 00:37 | |
| mriedem | dansmith: i just got thinking that maybe we shouldn't have removed the online data migration hook in https://review.openstack.org/#/c/448579/ but then again that was added in mitaka, and the blocker migration was added in newton. the thing that makes me 2nd guess it is people skipping releases for upgrades. | 00:39 |
|---|---|---|
| mriedem | which we don't support, but people do it | 00:39 |
| mriedem | skipping from newton to pike though, would be nuts | 00:40 |
| mriedem | the online flavor migration was added in newton, the blocker migration was added in ocata, so theoretically we could remove all of that in pike, but if people skip ocata, and we removed the online data migration CLI for flavors, they'd be screwed | 00:41 |
| *** tovin07_ has joined #openstack-nova | 00:43 | |
| *** gouthamr has joined #openstack-nova | 00:46 | |
| mordred | mriedem: skip-upgrades seem like a completely crazy thing if they're not actually supported and planned for | 00:47 |
| *** nkorabli has quit IRC | 00:47 | |
| efried | mordred Yes, mañana. Want to make sure I'm on the right track with https://review.openstack.org/#/c/460337/ and ask some questions about same. | 00:48 |
| mordred | cool- looking forward to it | 00:49 |
| mordred | efried: oh great - I missed that you'd pushed that up - I'll read it first thing | 00:51 |
| *** nkorabli has joined #openstack-nova | 00:51 | |
| *** adrian_otto has quit IRC | 00:51 | |
| *** adrian_otto has joined #openstack-nova | 00:52 | |
| *** tbachman has quit IRC | 00:52 | |
| *** adrian_otto has quit IRC | 00:52 | |
| *** Shunli has joined #openstack-nova | 00:55 | |
| *** gyee has quit IRC | 00:57 | |
| mriedem | mordred: yeah, except ops are always talking about doing it | 00:58 |
| *** sdague has quit IRC | 00:58 | |
| mriedem | because we don't have LTS or whatever | 00:58 |
| *** imacdonn_ has joined #openstack-nova | 00:59 | |
| *** phuongnh has joined #openstack-nova | 01:01 | |
| *** dixiaoli has joined #openstack-nova | 01:01 | |
| *** esberglu has joined #openstack-nova | 01:07 | |
| *** baoli has joined #openstack-nova | 01:09 | |
| *** trinaths has joined #openstack-nova | 01:09 | |
| *** cNilesh has joined #openstack-nova | 01:11 | |
| *** esberglu has quit IRC | 01:12 | |
| *** yolkfull has joined #openstack-nova | 01:13 | |
| *** baoli has quit IRC | 01:14 | |
| *** annegentle has quit IRC | 01:14 | |
| mriedem | dansmith: oh fun, uncovered a bug removing all of this flavor object compat code for the main cell db, | 01:16 |
| mriedem | when sending a flavor delete notification, we lazy-load the projects which results in a FlavorNotFound b/c we just deleted that flavor | 01:17 |
| *** yangyapeng has joined #openstack-nova | 01:18 | |
| *** zhenguo has joined #openstack-nova | 01:19 | |
| *** Apoorva has joined #openstack-nova | 01:19 | |
| *** annegentle has joined #openstack-nova | 01:19 | |
| *** yangyapeng has quit IRC | 01:20 | |
| *** yangyape_ has joined #openstack-nova | 01:20 | |
| *** Apoorva has quit IRC | 01:20 | |
| mriedem | looks like that's due to https://review.openstack.org/#/c/445697/ | 01:23 |
| *** prateek has quit IRC | 01:26 | |
| *** READ10 has quit IRC | 01:27 | |
| *** yangyape_ has quit IRC | 01:30 | |
| *** yangyapeng has joined #openstack-nova | 01:31 | |
| *** baoli has joined #openstack-nova | 01:32 | |
| *** yamahata_ has quit IRC | 01:33 | |
| *** Sukhdev has joined #openstack-nova | 01:34 | |
| *** yangyapeng has quit IRC | 01:35 | |
| *** thorst_afk has quit IRC | 01:36 | |
| *** lyan has quit IRC | 01:37 | |
| *** kaisers has quit IRC | 01:37 | |
| *** yangyapeng has joined #openstack-nova | 01:37 | |
| *** esberglu has joined #openstack-nova | 01:38 | |
| *** baoli has quit IRC | 01:38 | |
| *** esberglu has quit IRC | 01:38 | |
| *** gcb has joined #openstack-nova | 01:38 | |
| *** gouthamr has quit IRC | 01:42 | |
| *** dikonoor has quit IRC | 01:42 | |
| *** MasterOfBugs has quit IRC | 01:43 | |
| *** litao has joined #openstack-nova | 01:48 | |
| *** trinaths has quit IRC | 01:48 | |
| *** chenying__ has joined #openstack-nova | 01:55 | |
| *** chenying_ has quit IRC | 01:55 | |
| *** smatzek has quit IRC | 01:55 | |
| *** smatzek has joined #openstack-nova | 01:55 | |
| *** gjayavelu has joined #openstack-nova | 02:01 | |
| *** zhurong has joined #openstack-nova | 02:02 | |
| *** prateek has joined #openstack-nova | 02:04 | |
| *** ijw has joined #openstack-nova | 02:05 | |
| *** gjayavelu has quit IRC | 02:06 | |
| *** annegentle has quit IRC | 02:06 | |
| *** ijw has quit IRC | 02:10 | |
| *** prateek has quit IRC | 02:11 | |
| *** wxy has joined #openstack-nova | 02:14 | |
| *** zhurong has quit IRC | 02:18 | |
| *** baoli has joined #openstack-nova | 02:18 | |
| *** zul has quit IRC | 02:19 | |
| *** baoli has quit IRC | 02:23 | |
| *** cNilesh has quit IRC | 02:25 | |
| *** iceyao has joined #openstack-nova | 02:26 | |
| *** esberglu has joined #openstack-nova | 02:31 | |
| *** hongbin has joined #openstack-nova | 02:33 | |
| *** mriedem has quit IRC | 02:34 | |
| *** esberglu has quit IRC | 02:36 | |
| *** dave-mccowan has quit IRC | 02:36 | |
| *** thorst_afk has joined #openstack-nova | 02:37 | |
| *** dave-mccowan has joined #openstack-nova | 02:37 | |
| *** dave-mccowan has quit IRC | 02:37 | |
| *** thorst_afk has quit IRC | 02:41 | |
| *** dave-mccowan has joined #openstack-nova | 02:42 | |
| *** dave-mcc_ has joined #openstack-nova | 02:44 | |
| *** zhurong has joined #openstack-nova | 02:44 | |
| *** cheran has quit IRC | 02:46 | |
| *** dave-mccowan has quit IRC | 02:47 | |
| *** fragatin_ has joined #openstack-nova | 02:48 | |
| *** liverpooler has quit IRC | 02:50 | |
| *** awaugama has joined #openstack-nova | 02:51 | |
| *** gouthamr has joined #openstack-nova | 02:51 | |
| *** fragatina has quit IRC | 02:52 | |
| *** fragatin_ has quit IRC | 02:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Remove compatibility code for flavors https://review.openstack.org/460377 | 02:53 |
| morgan | huh I saw my name here | 02:55 |
| morgan | what did I miss? | 02:55 |
| morgan | can't find it in the backlog ATM. | 02:56 |
| *** smatzek has quit IRC | 03:02 | |
| *** thorst_afk has joined #openstack-nova | 03:08 | |
| *** baoli has joined #openstack-nova | 03:19 | |
| *** sree has joined #openstack-nova | 03:20 | |
| *** baoli has quit IRC | 03:24 | |
| *** dave-mcc_ has quit IRC | 03:24 | |
| *** thorst_afk has quit IRC | 03:25 | |
| *** nicolasbock has quit IRC | 03:27 | |
| *** armax has joined #openstack-nova | 03:27 | |
| *** awaugama has quit IRC | 03:28 | |
| *** psachin has joined #openstack-nova | 03:32 | |
| *** tuanluong has joined #openstack-nova | 03:36 | |
| *** dimtruck is now known as zz_dimtruck | 03:37 | |
| *** ssurana has quit IRC | 03:37 | |
| *** ijw has joined #openstack-nova | 03:39 | |
| *** ratailor has joined #openstack-nova | 03:39 | |
| *** ratailor_ has joined #openstack-nova | 03:41 | |
| *** ratailor_ has quit IRC | 03:42 | |
| *** zhurong has quit IRC | 03:42 | |
| *** ratailor has quit IRC | 03:45 | |
| *** RiteshPaiboina has joined #openstack-nova | 03:46 | |
| *** armax has quit IRC | 03:47 | |
| RiteshPaiboina | who jaypipes | 03:48 |
| *** dikonoor has joined #openstack-nova | 03:57 | |
| *** ijw has quit IRC | 03:58 | |
| *** sree has quit IRC | 03:59 | |
| *** sree has joined #openstack-nova | 04:00 | |
| *** vks1 has joined #openstack-nova | 04:01 | |
| *** gouthamr has quit IRC | 04:01 | |
| *** kaisers has joined #openstack-nova | 04:01 | |
| *** sree has quit IRC | 04:04 | |
| *** syjulian has quit IRC | 04:06 | |
| *** diga has joined #openstack-nova | 04:06 | |
| *** MikeG451 has quit IRC | 04:07 | |
| *** dikonoor has quit IRC | 04:08 | |
| *** abhi89 has joined #openstack-nova | 04:09 | |
| *** fragatina has joined #openstack-nova | 04:13 | |
| *** nmathew has joined #openstack-nova | 04:15 | |
| openstackgerrit | falseuser proposed openstack/nova master: [BugFix] Check the instance task status to release the memory quota for vram https://review.openstack.org/456050 | 04:18 |
| openstackgerrit | falseuser proposed openstack/nova master: [BugFix]Include the video ram when comparing the difference of two flavors https://review.openstack.org/460388 | 04:18 |
| *** baoli has joined #openstack-nova | 04:20 | |
| *** MikeG451 has joined #openstack-nova | 04:20 | |
| *** fragatina has quit IRC | 04:21 | |
| *** udesale has joined #openstack-nova | 04:21 | |
| *** fragatina has joined #openstack-nova | 04:21 | |
| *** ratailor has joined #openstack-nova | 04:24 | |
| *** baoli has quit IRC | 04:25 | |
| *** abhi89 has quit IRC | 04:25 | |
| *** abhi89 has joined #openstack-nova | 04:30 | |
| *** Sukhdev has quit IRC | 04:32 | |
| *** vladikr has quit IRC | 04:34 | |
| *** hongbin has quit IRC | 04:37 | |
| *** kaisers has quit IRC | 04:39 | |
| *** abhi89 has quit IRC | 04:41 | |
| *** trinaths has joined #openstack-nova | 04:41 | |
| *** sree has joined #openstack-nova | 04:42 | |
| *** yamahata_ has joined #openstack-nova | 04:45 | |
| *** Sukhdev has joined #openstack-nova | 04:48 | |
| *** Sukhdev has quit IRC | 04:49 | |
| *** salv-orlando has joined #openstack-nova | 04:51 | |
| *** Sukhdev has joined #openstack-nova | 04:53 | |
| *** adisky_ has joined #openstack-nova | 04:56 | |
| *** armax has joined #openstack-nova | 04:57 | |
| *** ijw has joined #openstack-nova | 04:58 | |
| *** ijw has quit IRC | 05:04 | |
| *** iceyao has quit IRC | 05:05 | |
| *** dikonoor has joined #openstack-nova | 05:05 | |
| *** kaisers has joined #openstack-nova | 05:09 | |
| *** syjulian has joined #openstack-nova | 05:11 | |
| *** kaisers_ has joined #openstack-nova | 05:14 | |
| *** iceyao has joined #openstack-nova | 05:14 | |
| *** ratailor_ has joined #openstack-nova | 05:14 | |
| *** kaisers has quit IRC | 05:15 | |
| openstackgerrit | Kiseok Kim proposed openstack/nova master: Fixed a broken link in API Plugins document https://review.openstack.org/460398 | 05:15 |
| *** esberglu has joined #openstack-nova | 05:16 | |
| *** esberglu has quit IRC | 05:16 | |
| *** esberglu has joined #openstack-nova | 05:17 | |
| *** ayogi has joined #openstack-nova | 05:17 | |
| *** ratailor has quit IRC | 05:18 | |
| *** slaweq has joined #openstack-nova | 05:20 | |
| *** baoli has joined #openstack-nova | 05:21 | |
| *** esberglu has quit IRC | 05:21 | |
| *** dikonoor has quit IRC | 05:21 | |
| *** iceyao has quit IRC | 05:21 | |
| *** thorst_afk has joined #openstack-nova | 05:22 | |
| *** claudiub|3 has joined #openstack-nova | 05:24 | |
| *** baoli has quit IRC | 05:25 | |
| *** slaweq has quit IRC | 05:26 | |
| *** ratailor_ has quit IRC | 05:31 | |
| *** ratailor has joined #openstack-nova | 05:31 | |
| *** thorst_afk has quit IRC | 05:32 | |
| *** sree has quit IRC | 05:34 | |
| *** iceyao has joined #openstack-nova | 05:34 | |
| *** sree has joined #openstack-nova | 05:35 | |
| *** ekuris has joined #openstack-nova | 05:36 | |
| *** yingjun has quit IRC | 05:40 | |
| *** sree has quit IRC | 05:41 | |
| *** mdnadeem has joined #openstack-nova | 05:41 | |
| *** sree has joined #openstack-nova | 05:41 | |
| *** mdnadeem has quit IRC | 05:42 | |
| *** mdnadeem has joined #openstack-nova | 05:42 | |
| *** mdnadeem has quit IRC | 05:42 | |
| *** mdnadeem has joined #openstack-nova | 05:42 | |
| *** sree has quit IRC | 05:46 | |
| *** arunman has joined #openstack-nova | 05:48 | |
| *** bkopilov has quit IRC | 05:52 | |
| *** bkopilov has joined #openstack-nova | 05:52 | |
| openstackgerrit | falseuser proposed openstack/nova master: [BugFix] Release the memory quota for video ram when deleting an instance. https://review.openstack.org/456050 | 05:58 |
| *** prateek has joined #openstack-nova | 05:59 | |
| *** abhi89 has joined #openstack-nova | 05:59 | |
| *** ijw has joined #openstack-nova | 06:00 | |
| *** ltomasbo|away is now known as ltomasbo | 06:04 | |
| *** dikonoor has joined #openstack-nova | 06:05 | |
| *** ijw has quit IRC | 06:06 | |
| *** sree has joined #openstack-nova | 06:07 | |
| *** tjones has quit IRC | 06:09 | |
| *** fandi has joined #openstack-nova | 06:12 | |
| *** zhurong has joined #openstack-nova | 06:13 | |
| *** mdnadeem has quit IRC | 06:14 | |
| *** mdnadeem has joined #openstack-nova | 06:15 | |
| *** arunman has quit IRC | 06:15 | |
| *** dikonoo has joined #openstack-nova | 06:16 | |
| *** dikonoor has quit IRC | 06:16 | |
| *** sridharg has joined #openstack-nova | 06:18 | |
| *** amotoki has quit IRC | 06:19 | |
| *** andreas_s has joined #openstack-nova | 06:19 | |
| *** amotoki has joined #openstack-nova | 06:20 | |
| openstackgerrit | 龚肖 proposed openstack/nova master: Add mock check and fix uuid's use in test. https://review.openstack.org/459501 | 06:20 |
| *** baoli has joined #openstack-nova | 06:22 | |
| *** mkoderer_ has joined #openstack-nova | 06:25 | |
| *** tpatzig_ has joined #openstack-nova | 06:25 | |
| *** baoli has quit IRC | 06:26 | |
| *** mkoderer_ has quit IRC | 06:27 | |
| *** tpatzig_ has quit IRC | 06:27 | |
| *** slaweq has joined #openstack-nova | 06:27 | |
| *** artom has quit IRC | 06:30 | |
| *** artom has joined #openstack-nova | 06:30 | |
| *** slaweq has quit IRC | 06:32 | |
| *** artom has quit IRC | 06:32 | |
| *** artom has joined #openstack-nova | 06:32 | |
| *** Sukhdev has quit IRC | 06:39 | |
| *** pcaruana has joined #openstack-nova | 06:44 | |
| openstackgerrit | falseuser proposed openstack/nova master: [BugFix] Check the instance task status to release the memory quota for vram https://review.openstack.org/456050 | 06:44 |
| openstackgerrit | falseuser proposed openstack/nova master: [BugFix] Include the video ram when comparing the difference of two flavors https://review.openstack.org/460388 | 06:44 |
| *** ratailor has quit IRC | 06:45 | |
| *** salv-orlando has quit IRC | 06:48 | |
| *** jaosorior_away is now known as jaosorior | 06:51 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(2/4) https://review.openstack.org/459569 | 06:58 |
| *** arne_r has joined #openstack-nova | 06:59 | |
| openstackgerrit | 龚肖 proposed openstack/nova master: Add mock check and fix uuid's use in test. https://review.openstack.org/459501 | 07:00 |
| *** zhurong has quit IRC | 07:02 | |
| *** ijw has joined #openstack-nova | 07:02 | |
| openstackgerrit | falseuser proposed openstack/nova master: [BugFix] Release the memory quota for video ram when deleting an instance. https://review.openstack.org/456050 | 07:04 |
| *** zhurong has joined #openstack-nova | 07:06 | |
| *** stackempty has quit IRC | 07:06 | |
| *** salv-orlando has joined #openstack-nova | 07:07 | |
| *** ijw has quit IRC | 07:08 | |
| *** Nakato has quit IRC | 07:08 | |
| *** Nakato has joined #openstack-nova | 07:08 | |
| *** tesseract has joined #openstack-nova | 07:09 | |
| *** voelzmo has joined #openstack-nova | 07:09 | |
| openstackgerrit | falseuser proposed openstack/nova master: [BugFix] Release the memory quota for video ram when deleting an instance. https://review.openstack.org/456050 | 07:13 |
| *** ltomasbo is now known as ltomasbo|away | 07:18 | |
| *** beagles has quit IRC | 07:19 | |
| *** MasterOfBugs has joined #openstack-nova | 07:20 | |
| *** b3nt_pin has joined #openstack-nova | 07:21 | |
| *** armax has quit IRC | 07:21 | |
| *** abalutoiu__ has quit IRC | 07:21 | |
| *** baoli has joined #openstack-nova | 07:22 | |
| *** Drankis has joined #openstack-nova | 07:24 | |
| *** baoli has quit IRC | 07:27 | |
| *** thorst_afk has joined #openstack-nova | 07:28 | |
| *** Nakato has quit IRC | 07:30 | |
| *** Nakato has joined #openstack-nova | 07:31 | |
| *** ecelik has joined #openstack-nova | 07:32 | |
| *** dikonoo has quit IRC | 07:32 | |
| *** ecelik has left #openstack-nova | 07:32 | |
| *** ralonsoh has joined #openstack-nova | 07:34 | |
| *** brault has joined #openstack-nova | 07:37 | |
| *** zhurong has quit IRC | 07:37 | |
| *** rmart04 has joined #openstack-nova | 07:39 | |
| openstackgerrit | jichenjc proposed openstack/python-novaclient master: Remove 1.1 extension comment https://review.openstack.org/459503 | 07:40 |
| *** karthiks has joined #openstack-nova | 07:41 | |
| *** abalutoiu has joined #openstack-nova | 07:42 | |
| *** damien_r has joined #openstack-nova | 07:45 | |
| *** mlakat_ has joined #openstack-nova | 07:47 | |
| *** mlakat has quit IRC | 07:47 | |
| *** mlakat_ is now known as mlakat | 07:47 | |
| *** thorst_afk has quit IRC | 07:48 | |
| *** jpena|off is now known as jpena | 07:50 | |
| *** tuanluong has quit IRC | 07:51 | |
| *** abalutoiu has quit IRC | 07:51 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for limits endpoint instead of stevedore https://review.openstack.org/458805 | 07:54 |
| openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for hosts endpoint instead of stevedore https://review.openstack.org/459231 | 07:54 |
| openstackgerrit | jichenjc proposed openstack/nova master: use plain routes list for hypervisor endpoint instead of stevedore https://review.openstack.org/459235 | 07:54 |
| *** kuzko has quit IRC | 07:55 | |
| *** kuzko has joined #openstack-nova | 07:57 | |
| *** VAhl has quit IRC | 07:58 | |
| *** zzzeek has quit IRC | 08:00 | |
| openstackgerrit | Mikhail Feoktistov proposed openstack/nova master: Add is_vz_container function https://review.openstack.org/445947 | 08:00 |
| *** zzzeek has joined #openstack-nova | 08:00 | |
| *** MasterofJOKers has quit IRC | 08:02 | |
| *** MasterofJOKers has joined #openstack-nova | 08:03 | |
| *** ijw has joined #openstack-nova | 08:04 | |
| *** abalutoiu has joined #openstack-nova | 08:07 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Delete existing allocations for move operations or retries https://review.openstack.org/460433 | 08:08 |
| openstackgerrit | falseuser proposed openstack/nova master: [BugFix] Include the video ram when comparing the difference of two flavors https://review.openstack.org/460388 | 08:08 |
| *** ijw has quit IRC | 08:09 | |
| *** arunman has joined #openstack-nova | 08:12 | |
| *** tuanluong has joined #openstack-nova | 08:12 | |
| *** nkorabli has quit IRC | 08:14 | |
| *** nkorabli has joined #openstack-nova | 08:15 | |
| openstackgerrit | Shunli Zhou proposed openstack/nova master: Periodically load nova.conf https://review.openstack.org/460437 | 08:16 |
| *** lucas-afk is now known as lucasagomes | 08:17 | |
| *** zhurong has joined #openstack-nova | 08:19 | |
| *** nkorabli has quit IRC | 08:19 | |
| *** markus_z has joined #openstack-nova | 08:20 | |
| *** amotoki has quit IRC | 08:22 | |
| *** bkopilov has quit IRC | 08:23 | |
| *** baoli has joined #openstack-nova | 08:23 | |
| *** sree has quit IRC | 08:25 | |
| *** baoli has quit IRC | 08:28 | |
| *** moshele has joined #openstack-nova | 08:29 | |
| *** andreas_s has quit IRC | 08:30 | |
| *** amotoki has joined #openstack-nova | 08:32 | |
| *** hieulq has quit IRC | 08:40 | |
| *** tovin07_ has quit IRC | 08:42 | |
| *** tuanluong has quit IRC | 08:42 | |
| *** phuongnh has quit IRC | 08:42 | |
| *** sree has joined #openstack-nova | 08:42 | |
| *** mkrai_ has quit IRC | 08:43 | |
| *** ltomasbo|away is now known as ltomasbo | 08:43 | |
| *** andreas_s has joined #openstack-nova | 08:46 | |
| *** lpetrut has joined #openstack-nova | 08:50 | |
| *** bkopilov has joined #openstack-nova | 08:52 | |
| *** esberglu has joined #openstack-nova | 08:54 | |
| *** esberglu has quit IRC | 08:54 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Allocate instance by the conductor https://review.openstack.org/460455 | 08:55 |
| *** derekh has joined #openstack-nova | 08:59 | |
| *** ijw has joined #openstack-nova | 09:06 | |
| *** ijw has quit IRC | 09:11 | |
| *** aarefiev_afk is now known as aarefiev | 09:16 | |
| *** syjulian has quit IRC | 09:17 | |
| *** ratailor has joined #openstack-nova | 09:18 | |
| *** MikeG451 has quit IRC | 09:19 | |
| *** amotoki has quit IRC | 09:21 | |
| *** sambetts|afk is now known as sambetts | 09:21 | |
| openstackgerrit | Gábor Antal proposed openstack/nova master: [WIP] Transform instance.live_migration_rollback notification https://review.openstack.org/402124 | 09:22 |
| *** ratailor has quit IRC | 09:22 | |
| *** ratailor has joined #openstack-nova | 09:22 | |
| *** amotoki has joined #openstack-nova | 09:22 | |
| *** amotoki has quit IRC | 09:23 | |
| *** baoli has joined #openstack-nova | 09:24 | |
| openstackgerrit | Abhishek Sharma M proposed openstack/nova master: Catching OverQuota Exception https://review.openstack.org/460305 | 09:26 |
| *** baoli has quit IRC | 09:29 | |
| *** MikeG451 has joined #openstack-nova | 09:33 | |
| *** amotoki has joined #openstack-nova | 09:41 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779 | 09:42 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add keypairs field to InstancePayload https://review.openstack.org/419730 | 09:42 |
| *** cdent has joined #openstack-nova | 09:43 | |
| *** thorst_afk has joined #openstack-nova | 09:45 | |
| *** andreas_s has quit IRC | 09:46 | |
| openstackgerrit | NidhiMittalHada proposed openstack/python-novaclient master: Nova volume-attach doesn't care for device name https://review.openstack.org/454048 | 09:47 |
| *** esberglu has joined #openstack-nova | 09:48 | |
| *** salv-orl_ has joined #openstack-nova | 09:49 | |
| *** thorst_afk has quit IRC | 09:50 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: Add description to policies in migrations.py https://review.openstack.org/459727 | 09:50 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Don't check for file type in _find_base_file https://review.openstack.org/334958 | 09:51 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add context comments to _handle_base_image https://review.openstack.org/334956 | 09:51 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Rename _handle_base_image to _mark_in_use https://review.openstack.org/334957 | 09:51 |
| *** esberglu has quit IRC | 09:52 | |
| *** salv-orlando has quit IRC | 09:52 | |
| *** dixiaoli has quit IRC | 09:57 | |
| *** lpetrut_ has joined #openstack-nova | 09:58 | |
| *** ociuhandu has quit IRC | 09:59 | |
| *** lpetrut has quit IRC | 10:00 | |
| *** nicolasbock has joined #openstack-nova | 10:03 | |
| johnthetubaguy | sfinucan: did you look to see if someone has got the change to bump the oslo.policy minimum up yet? | 10:03 |
| *** mvk has quit IRC | 10:04 | |
| *** iceyao has quit IRC | 10:05 | |
| *** Shunli has quit IRC | 10:05 | |
| *** tbachman has joined #openstack-nova | 10:06 | |
| *** ijw has joined #openstack-nova | 10:07 | |
| *** zul has joined #openstack-nova | 10:09 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: Sensibly wrap policy help messages https://review.openstack.org/460097 | 10:09 |
| *** iceyao has joined #openstack-nova | 10:10 | |
| *** trinaths has left #openstack-nova | 10:11 | |
| *** nkorabli has joined #openstack-nova | 10:12 | |
| *** ijw has quit IRC | 10:12 | |
| *** iceyao has quit IRC | 10:13 | |
| *** syjulian has joined #openstack-nova | 10:13 | |
| *** andreas_s has joined #openstack-nova | 10:13 | |
| *** hieulq has joined #openstack-nova | 10:15 | |
| *** hieulq has quit IRC | 10:18 | |
| *** kevinz has quit IRC | 10:19 | |
| *** zhurong has quit IRC | 10:20 | |
| *** sree has quit IRC | 10:22 | |
| *** vladikr has joined #openstack-nova | 10:24 | |
| *** fandi has quit IRC | 10:24 | |
| *** baoli has joined #openstack-nova | 10:25 | |
| *** mlakat has quit IRC | 10:26 | |
| cdent | johnthetubaguy, alex_xu: if you have spare brain this improvement to placement and resource tracker wants eyes: https://review.openstack.org/#/c/448791/ (and above) | 10:27 |
| johnthetubaguy | I have my head in policy right now, but I should do something different soon | 10:27 |
| cdent | if you've been in policy I would be very surprised if you have spare brain | 10:28 |
| *** zhurong has joined #openstack-nova | 10:28 | |
| *** amotoki has quit IRC | 10:28 | |
| *** baoli has quit IRC | 10:30 | |
| *** nmathew has quit IRC | 10:30 | |
| *** psachin has quit IRC | 10:30 | |
| *** iceyao has joined #openstack-nova | 10:30 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: Ensure sample policy help text correctly wrapped https://review.openstack.org/460097 | 10:31 |
| *** nkorabli has quit IRC | 10:32 | |
| *** nkorabli has joined #openstack-nova | 10:32 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: Ensure sample policy help text correctly wrapped https://review.openstack.org/460097 | 10:33 |
| *** hieulq has joined #openstack-nova | 10:33 | |
| *** mvk has joined #openstack-nova | 10:34 | |
| *** psachin has joined #openstack-nova | 10:34 | |
| *** fandi has joined #openstack-nova | 10:34 | |
| *** iceyao has quit IRC | 10:35 | |
| *** smatzek has joined #openstack-nova | 10:37 | |
| *** nkorabli has quit IRC | 10:37 | |
| sfinucan | johnthetubaguy: I did not, but I figure we can | 10:38 |
| *** tojuvone_ has joined #openstack-nova | 10:38 | |
| *** tojuvone has quit IRC | 10:38 | |
| *** salv-orl_ has quit IRC | 10:38 | |
| * sfinucan forgot to start HexChat this morning | 10:38 | |
| johnthetubaguy | sfinucan: I tried a few things out, and pushed a new version of your patch | 10:38 |
| sfinucan | johnthetubaguy: Yup. +1d it. Works fine for me locally now | 10:38 |
| sfinucan | Thanks :) | 10:38 |
| *** yangyapeng has quit IRC | 10:38 | |
| johnthetubaguy | https://review.openstack.org/460097 that is | 10:38 |
| *** yangyapeng has joined #openstack-nova | 10:39 | |
| johnthetubaguy | sfinucan: cool, yeah, did a rebase to drop all that observable messy, whoop | 10:39 |
| sfinucan | johnthetubaguy: admin_or_owner, admin_api, and network:attach_external_network are the only ones left. Two of those are being deprecated, right? | 10:40 |
| johnthetubaguy | sfinucan: there are loads left still, full list is in the BP: https://blueprints.launchpad.net/nova/+spec/policy-docs | 10:40 |
| sfinucan | Oh, there's a couple more, actually, but I've seen patches around a few | 10:40 |
| sfinucan | Yup - my bad | 10:40 |
| *** fragatina has quit IRC | 10:40 | |
| *** fragatina has joined #openstack-nova | 10:41 | |
| johnthetubaguy | sfinucan: I don't believe any are deprecated as such, the API may be deprecated, but the policy doesn't die till we remove the API (after a theoretical version bump, etc) | 10:41 |
| sfinucan | johnthetubaguy: Sound fair. What was your call on the patches that split some policies, btw? 'os_compute_api:os-flavor-rxtx' was one, iirc | 10:42 |
| sfinucan | Can we do that (split a policy into multiple policies) | 10:42 |
| *** yolkfull has quit IRC | 10:43 | |
| *** yangyapeng has quit IRC | 10:43 | |
| johnthetubaguy | sfinucan: I think I added comments on most of that patches now, most of they don't look like they need splitting, the problem is the rules they remove with no deprecation cycle or warning | 10:43 |
| johnthetubaguy | sfinucan: I basically asked them to talk to the nova-api subteam somehow, to describe what their intent is, I suspect I just don't understand it as its not described in their bug | 10:45 |
| sfinucan | Yeah, I was more focussed on the latter. So basically we need to follow the same migration policy as config opts, right? | 10:45 |
| sfinucan | i.e. deprecate one cycle, remove the next | 10:45 |
| johnthetubaguy | sfinucan: Ideally, its just a config file, so the same rules apply, but the bad bit is we have non of the infrastructure, well almost non | 10:45 |
| johnthetubaguy | s/non/none/ | 10:46 |
| sfinucan | Looks like oslo.policy rules need 'deprecated_X' options so | 10:46 |
| *** thorst_afk has joined #openstack-nova | 10:46 | |
| johnthetubaguy | sfinucan: yeah, something like that, its just not been done yet, its a bit tricky | 10:47 |
| *** diga has quit IRC | 10:48 | |
| johnthetubaguy | you can use rule alias and a manual log message though, to get 90% there | 10:48 |
| *** tbachman has quit IRC | 10:48 | |
| johnthetubaguy | but a whole load of the slits were not protecting APIs, there were only protecting API extensions, so its a bit odd | 10:49 |
| *** thorst_afk has quit IRC | 10:51 | |
| *** edmondsw has joined #openstack-nova | 10:53 | |
| mdbooth | sfinucan: Keen eyes :) Thanks for restoring that +2 | 10:58 |
| *** jpena is now known as jpena|lunch | 10:59 | |
| * sfinucan reads his Gerrit emails every morning. If you want a change reviewed, rebase it ;) | 10:59 | |
| sfinucan | *re-reviewed, even | 10:59 |
| *** sdague has joined #openstack-nova | 11:04 | |
| *** MasterOfBugs has quit IRC | 11:06 | |
| *** udesale has quit IRC | 11:06 | |
| *** ijw has joined #openstack-nova | 11:09 | |
| *** dave-mccowan has joined #openstack-nova | 11:09 | |
| *** markvoelker_ has joined #openstack-nova | 11:11 | |
| *** markvoelker has quit IRC | 11:12 | |
| *** ijw has quit IRC | 11:14 | |
| *** damien_r has quit IRC | 11:14 | |
| *** mnestratov has quit IRC | 11:15 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Attach and detach encryptors during swap_volume https://review.openstack.org/460244 | 11:21 |
| *** abhi89 has quit IRC | 11:21 | |
| alex_xu | cdent: already added that to my review list | 11:24 |
| cdent | alex_xu: thanks! | 11:24 |
| alex_xu | np! | 11:25 |
| *** lucasagomes is now known as lucas-hungry | 11:27 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: Update description to policies in remaining flavor APIs https://review.openstack.org/460509 | 11:28 |
| *** kaisers_ has quit IRC | 11:29 | |
| *** cdent has quit IRC | 11:30 | |
| *** kaisers has joined #openstack-nova | 11:30 | |
| *** iceyao has joined #openstack-nova | 11:30 | |
| *** prateek has quit IRC | 11:30 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: Update description to policies in remaining flavor APIs https://review.openstack.org/460509 | 11:31 |
| *** kaisers has quit IRC | 11:34 | |
| *** yangyapeng has joined #openstack-nova | 11:36 | |
| *** damien_r has joined #openstack-nova | 11:36 | |
| *** markvoelker_ has quit IRC | 11:38 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova master: Replace diagnostics objects with Nova diagnostics objects https://review.openstack.org/394480 | 11:40 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova master: Added nova objects for intance diagnostics https://review.openstack.org/434745 | 11:40 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova master: Standardization of VM diagnostics info API. https://review.openstack.org/355540 | 11:40 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova master: Completed implementation of instance diagnostics for Xen https://review.openstack.org/399613 | 11:40 |
| *** arunman has quit IRC | 11:41 | |
| *** prateek has joined #openstack-nova | 11:41 | |
| *** kaisers has joined #openstack-nova | 11:41 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/460515 | 11:44 |
| *** amotoki has joined #openstack-nova | 11:45 | |
| *** prateek_ has joined #openstack-nova | 11:48 | |
| *** thorst_afk has joined #openstack-nova | 11:51 | |
| *** andreas_s has quit IRC | 11:51 | |
| *** prateek has quit IRC | 11:51 | |
| *** tbachman has joined #openstack-nova | 11:53 | |
| *** amotoki has quit IRC | 11:58 | |
| *** amotoki has joined #openstack-nova | 12:01 | |
| *** pchavva has joined #openstack-nova | 12:01 | |
| *** dgonzalez has quit IRC | 12:02 | |
| *** abhi89 has joined #openstack-nova | 12:02 | |
| *** abhi89 has quit IRC | 12:03 | |
| *** abhi89 has joined #openstack-nova | 12:04 | |
| *** abhishek has joined #openstack-nova | 12:04 | |
| *** ratailor_ has joined #openstack-nova | 12:06 | |
| *** dgonzalez has joined #openstack-nova | 12:07 | |
| *** gszasz has joined #openstack-nova | 12:07 | |
| *** rfolco has joined #openstack-nova | 12:08 | |
| *** abhi89 has quit IRC | 12:08 | |
| *** jpena|lunch is now known as jpena | 12:08 | |
| *** ratailor has quit IRC | 12:09 | |
| *** ijw has joined #openstack-nova | 12:10 | |
| *** abhi89 has joined #openstack-nova | 12:12 | |
| *** annegentle has joined #openstack-nova | 12:13 | |
| openstackgerrit | Gábor Antal proposed openstack/nova master: [WIP] Transform instance.live_migration_rollback notification https://review.openstack.org/402124 | 12:15 |
| *** abhishek has quit IRC | 12:15 | |
| *** takedakn has joined #openstack-nova | 12:15 | |
| *** ijw has quit IRC | 12:16 | |
| *** thorst_a_ has joined #openstack-nova | 12:17 | |
| *** thorst_afk has quit IRC | 12:19 | |
| *** amotoki has quit IRC | 12:19 | |
| *** vks1 has quit IRC | 12:22 | |
| *** jaypipes has joined #openstack-nova | 12:23 | |
| *** zhurong has quit IRC | 12:25 | |
| *** ociuhandu has joined #openstack-nova | 12:25 | |
| *** amotoki has joined #openstack-nova | 12:25 | |
| openstackgerrit | Shunli Zhou proposed openstack/nova master: Periodically load nova.conf https://review.openstack.org/460437 | 12:29 |
| *** dillaman has quit IRC | 12:29 | |
| *** fandi has quit IRC | 12:30 | |
| *** ratailor_ has quit IRC | 12:30 | |
| *** tuan_luong has joined #openstack-nova | 12:32 | |
| *** slaweq has joined #openstack-nova | 12:32 | |
| *** esberglu has joined #openstack-nova | 12:32 | |
| *** esberglu has quit IRC | 12:32 | |
| *** amotoki has quit IRC | 12:34 | |
| *** markvoelker has joined #openstack-nova | 12:35 | |
| *** slaweq has quit IRC | 12:37 | |
| mdbooth | jaypipes: Could I convince you to turn a -1 into a +2? https://review.openstack.org/#/c/334956/ | 12:37 |
| *** liverpooler has joined #openstack-nova | 12:38 | |
| *** crushil has joined #openstack-nova | 12:38 | |
| jaypipes | mdbooth: looking now. | 12:39 |
| *** annegentle has quit IRC | 12:41 | |
| *** dillaman has joined #openstack-nova | 12:42 | |
| *** mlakat has joined #openstack-nova | 12:42 | |
| *** sree has joined #openstack-nova | 12:43 | |
| edleafe | /win 13 | 12:47 |
| edleafe | doh! | 12:47 |
| *** tuan_luong has quit IRC | 12:48 | |
| *** dillaman has quit IRC | 12:49 | |
| *** jdillaman has quit IRC | 12:50 | |
| jaypipes | mdbooth: if you're so confident about all of the always-True or always-False conditionals, why not just remove all the code that can never be reached, and flatten down all the conditionals? | 12:50 |
| *** arunman has joined #openstack-nova | 12:50 | |
| mdbooth | jaypipes: That's the next patch | 12:50 |
| jaypipes | oh, duh :) | 12:51 |
| mdbooth | I could squash them, but it seemed a bit hard to follow | 12:51 |
| *** arne_r has quit IRC | 12:52 | |
| mdbooth | jaypipes: https://review.openstack.org/#/c/334957/ | 12:52 |
| jaypipes | mdbooth: already on it. :) | 12:52 |
| mdbooth | Thanks | 12:52 |
| *** lucas-hungry is now known as lucasagomes | 12:53 | |
| *** amotoki has joined #openstack-nova | 12:55 | |
| *** cdent has joined #openstack-nova | 12:57 | |
| *** zhurong has joined #openstack-nova | 12:58 | |
| jaypipes | mdbooth: whole series +Wallaby'd. | 12:58 |
| *** nkorabli has joined #openstack-nova | 12:58 | |
| *** ayogi has quit IRC | 12:59 | |
| *** jdillaman has joined #openstack-nova | 13:02 | |
| *** dillaman has joined #openstack-nova | 13:02 | |
| *** trinaths has joined #openstack-nova | 13:02 | |
| mdbooth | jaypipes: Sweet, thanks | 13:02 |
| jaypipes | mdbooth: for you? any time :) | 13:03 |
| *** trinaths has quit IRC | 13:04 | |
| *** lyan has joined #openstack-nova | 13:05 | |
| *** nkorabli has quit IRC | 13:05 | |
| *** nkorabli has joined #openstack-nova | 13:06 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Add Neutron port capabilities to devspec in request https://review.openstack.org/451777 | 13:06 |
| *** prateek_ has quit IRC | 13:06 | |
| *** mriedem has joined #openstack-nova | 13:06 | |
| mriedem | o/ | 13:07 |
| jaypipes | mriedem: holy red slide, Batman. | 13:07 |
| mriedem | jaypipes: i don't control the red scare template | 13:07 |
| jaypipes | my eyes... they burn! | 13:07 |
| *** mdrabe has joined #openstack-nova | 13:08 | |
| jaypipes | mriedem: so how many wisecrack jokes am I allowed to put into these slides? ;P | 13:08 |
| mriedem | like how many k8s things can you slip in for the R release focus? | 13:08 |
| mriedem | i.e. nova as a proxy to k8s or something | 13:09 |
| mriedem | or, nova-compute in a cable box | 13:09 |
| jaypipes | ya. or something to do with NFV.. :) | 13:09 |
| jaypipes | jinx | 13:09 |
| *** nkorabli has quit IRC | 13:10 | |
| mriedem | there could be a slide of all the things jay wants to do but i won't let happen because i'm a bad guy, however, | 13:10 |
| mriedem | something like that is bound to be taken seroiusly and blow up in our faces | 13:10 |
| mriedem | *seriously | 13:10 |
| mriedem | or offend someone that actually wants said things | 13:11 |
| mdbooth | dansmith: You up and about, yet? I'm currently working on https://bugs.launchpad.net/nova/+bug/1686703 and I keep bouncing off dead ends like a Roomba. | 13:11 |
| openstack | Launchpad bug 1686703 in OpenStack Compute (nova) "Error in finish_migration results in image deletion on source with no copy" [Undecided,New] | 13:11 |
| jaypipes | RiteshPaiboina: hi! | 13:11 |
| jaypipes | RiteshPaiboina: I'm actually in EDT timezone, not PDT :) | 13:11 |
| mdbooth | dansmith: Looking for any relevant insight into migration records you may have. | 13:11 |
| *** prateek has joined #openstack-nova | 13:12 | |
| *** ijw has joined #openstack-nova | 13:12 | |
| *** salv-orlando has joined #openstack-nova | 13:12 | |
| *** damien_r has quit IRC | 13:14 | |
| jaypipes | RiteshPaiboina: basically, you will want to add a unit test to here: https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/test_imagebackend.py#L1257 that ensures that on calling the RbD imagebackend's clone() method, that the code ends up calling the Rbd image driver's flatten() method. | 13:15 |
| *** hshiina has joined #openstack-nova | 13:17 | |
| *** ijw has quit IRC | 13:17 | |
| *** catintheroof has joined #openstack-nova | 13:17 | |
| *** burt has joined #openstack-nova | 13:17 | |
| *** bswartz has joined #openstack-nova | 13:19 | |
| *** thorst_a_ is now known as thorst | 13:19 | |
| *** damien_r has joined #openstack-nova | 13:21 | |
| *** baoli has joined #openstack-nova | 13:22 | |
| *** baoli has quit IRC | 13:23 | |
| *** baoli has joined #openstack-nova | 13:26 | |
| *** moshele has quit IRC | 13:29 | |
| *** iceyao has quit IRC | 13:30 | |
| *** sree has quit IRC | 13:30 | |
| *** iceyao has joined #openstack-nova | 13:31 | |
| *** iceyao has quit IRC | 13:31 | |
| dansmith | mdbooth: yeah, I dunno if it's reliable enough to block cache manager expiration, but I don't know what else to do | 13:31 |
| *** esberglu has joined #openstack-nova | 13:32 | |
| *** esberglu has quit IRC | 13:32 | |
| mdbooth | dansmith: At least I feel better knowing it's not just me :) | 13:33 |
| *** esberglu has joined #openstack-nova | 13:33 | |
| zioproto | I have a user that has a instance booting from volume. And there are two cinder volumes attached. He opened a ticket that he cannot start this vm anymore. I confirm he cant.. this is my nova-compute log file. WTF ! http://paste.openstack.org/show/608202/ | 13:34 |
| zioproto | What is this Duplicate ID 'drive-ide0-0-0' for drive ?? | 13:34 |
| *** nkorabli has joined #openstack-nova | 13:34 | |
| *** tjones has joined #openstack-nova | 13:35 | |
| mriedem | zioproto: might be helpful to get the block_device_mappings table rows for that instance | 13:38 |
| *** eharney has joined #openstack-nova | 13:38 | |
| mriedem | zioproto: does the domain xml get logged during _create_domain? | 13:41 |
| mriedem | _get_guest_xml should log it actually | 13:42 |
| mriedem | so i'd check the dumped guest xml against the bdms in the db, specifically the connection_info values in the bdms entries | 13:44 |
| mriedem | see if there is some duplicate id in there | 13:44 |
| *** nkorabli has quit IRC | 13:48 | |
| edleafe | Any cores want to take a look at https://review.openstack.org/#/c/453862/ and push it through? Already has a +2 from jaypipes | 13:48 |
| *** dillaman has quit IRC | 13:49 | |
| *** adisky_ has quit IRC | 13:49 | |
| dansmith | mriedem: so some ironic people just brought up an issue with me around host mappings and aggregates | 13:51 |
| *** takedakn has quit IRC | 13:51 | |
| dansmith | mriedem: if you recall, as of like newton I think, the ironic driver uses this hash ring to choose which ironic nodes get owned by each compute service | 13:51 |
| dansmith | mriedem: if you have more compute services than nodes in ironic (like during setup), then you have some compute services that don't have any ComputeNode records | 13:52 |
| mriedem | i recall that but never was involved in it | 13:52 |
| dansmith | so the problem is, if you're bootstrapping an environment, you can't add those nova-compute services to an aggregate because they don't have ComputeNode records and thus don't have HostMappings | 13:53 |
| *** kevinz has joined #openstack-nova | 13:53 | |
| dansmith | you can't add the ones that don't "own" any ironic nodes yet I mean | 13:53 |
| dansmith | since you could before we cell-ified the aggregate api, they see it as a regression, which I kindof understand, | 13:54 |
| mriedem | i guess i don't know about the ironic setup issue where we have more compute services than nodes, unless i'm missing something obvious | 13:54 |
| mriedem | or is this, | 13:54 |
| dansmith | mriedem: during bootstrapping.. like you're setting up nova with ironic, but you haven't enrolled any nodes | 13:54 |
| mriedem | you start nova-compute, | 13:54 |
| mriedem | that asks ironic for available resources (nodes) which don't exist yet in ironic, | 13:55 |
| mriedem | so that compute service record is mapped to 0 nodes? | 13:55 |
| mriedem | ok | 13:55 |
| mriedem | unlike libvirt where we have 1x1 | 13:55 |
| dansmith | yep | 13:55 |
| dansmith | right | 13:55 |
| *** psachin has quit IRC | 13:56 | |
| dansmith | so before we cellified that api, we just looked up the service in the one database, and if it was there, then we add it to the aggregate and move on | 13:56 |
| dansmith | now, we also verify that there is a hostmapping, | 13:56 |
| *** ekuris has quit IRC | 13:56 | |
| mriedem | i'll have to look up the aggregates api code | 13:56 |
| dansmith | but we use that hostmapping to know which cell db to look for the service | 13:56 |
| dansmith | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L4734-L4760 | 13:56 |
| dansmith | damn, well, a few lines off | 13:56 |
| dansmith | add_host_to_aggregate() is what you want in there | 13:57 |
| dansmith | anyway, there are a couple of things we can do: | 13:57 |
| dansmith | 1. Just say you can't do this, mock ironic for being weird, and move on | 13:57 |
| mriedem | so this is https://developer.openstack.org/api-ref/compute/#add-host | 13:57 |
| dansmith | 2. If we don't find a hostmapping, we scan each cell for a matching service as a fallback, and if we find it, proceed | 13:58 |
| dansmith | it would be a single get-by-hostname per cell, so not *too* bad | 13:58 |
| dansmith | yeah that | 13:58 |
| *** kevinz has quit IRC | 13:59 | |
| mriedem | ok i see this guy https://github.com/openstack/nova/blob/master/nova/compute/api.py#L4748 | 13:59 |
| mriedem | yeah | 13:59 |
| mriedem | ugh | 13:59 |
| mriedem | so this is kind of like the same issue we have that prompted the need for using uuids in the services and hypervisors APIs | 13:59 |
| dansmith | it's fairly dumb because this only affects ironic and only in that kindof silly case, but.. | 14:00 |
| mriedem | and you had to workaround in the HostAPI code for now | 14:00 |
| *** kevinz has joined #openstack-nova | 14:00 | |
| mriedem | so i think we do the same thing you already did in the HostAPI to find a service/host | 14:00 |
| dansmith | why is it the same? | 14:00 |
| mriedem | iterate the cells until we find a match, if we don't find one, 404, if we find multiple, 409 | 14:00 |
| dansmith | just that we don't know the cell by the uuid you mean I guess | 14:00 |
| dansmith | well, I don't know that we need to handle the multiple case necessarily | 14:01 |
| dansmith | if you have multiple compute services with the same hostname you have already messed up your mappings anyway | 14:01 |
| dansmith | we did the 409 because we were deleting something, | 14:01 |
| mriedem | i'm talking about this https://github.com/openstack/nova/blob/master/nova/compute/api.py#L4413 | 14:01 |
| dansmith | but I think in this case it's okay to take the first and stop looping | 14:01 |
| dansmith | yeah I know | 14:01 |
| zioproto | mriedem: I am looking at the database, select connection_info from block_device_mapping where instance_uuid= ... | 14:02 |
| zioproto | mriedem: what exactly should I check ? | 14:02 |
| *** dillaman has joined #openstack-nova | 14:02 | |
| zioproto | everything looks exactly the same | 14:02 |
| zioproto | except the volume uuid | 14:02 |
| *** coreywright has quit IRC | 14:03 | |
| *** annegentle has joined #openstack-nova | 14:03 | |
| *** mlavalle has joined #openstack-nova | 14:04 | |
| mriedem | dansmith: not sure what you mean by "but I think in this case it's okay to take the first and stop looping" | 14:05 |
| mriedem | your #2 is start looping the cells looking for the service by hostname right? | 14:05 |
| mriedem | if we find a match we use that cell context | 14:05 |
| dansmith | mriedem: you *will* have duplicate service ids by no fault of your own because it's autoincrement.. you only have duplicate service hostnames if you're doing it wrong | 14:05 |
| dansmith | mriedem: so I think it's okay to not do the full scan dupe check if you're looking up by hostname | 14:05 |
| mriedem | this came up in the spec and i think johnthetubaguy said duplicate hostnames is a thing | 14:06 |
| zioproto | mriedem: in the xml file both disks have this same line | 14:06 |
| zioproto | <address type='drive' controller='0' bus='0' target='0' unit='0'/> | 14:06 |
| mriedem | zioproto: that seems like the cause then | 14:06 |
| dansmith | mriedem: can't be, otherwise our HostMapping doesn't work :) | 14:06 |
| zioproto | but this xml file is generated by nova, correct ? | 14:06 |
| mriedem | zioproto: yes, would have to lookup the code | 14:06 |
| mriedem | dansmith: let me check the spec | 14:07 |
| mriedem | because one of these APIs takes hostname and i remember talking about htis | 14:07 |
| mriedem | *this | 14:07 |
| *** voelzmo has quit IRC | 14:07 | |
| *** karthiks has quit IRC | 14:07 | |
| dansmith | mriedem: we do all our rpc routing by hostname, have a unique constraint there, etc | 14:08 |
| *** tbachman has quit IRC | 14:08 | |
| dansmith | mriedem: if we had dupes, we'd be sending rpc messages to the wrong hosts all over the place | 14:08 |
| *** voelzmo has joined #openstack-nova | 14:08 | |
| mriedem | dansmith: but in a cells v1 world your unique constraint is only scoped to the cell | 14:08 |
| mriedem | right? | 14:08 |
| zioproto | mriedem: most likely this machine booted in Liberty and not in Mitaka it cannot boot anymore :( | 14:08 |
| dansmith | mriedem: it's all mirrored up to the top level db, where there is a constraint | 14:09 |
| zioproto | mriedem: should I open a bug | 14:09 |
| zioproto | ? | 14:09 |
| mriedem | zioproto: i'm not sure what liberty vs mitaka has to do with this | 14:09 |
| dansmith | mriedem: i.e. all the services are in the cell dbs and in the main unified one at the top | 14:09 |
| mriedem | dansmith: ok, well, i'm just telling you what i was told | 14:09 |
| mriedem | you'll have to get the details from johnthetubaguy's horses mouth | 14:09 |
| dansmith | mriedem: anyway, finish your convo with zioproto, we can argue about this detail in the review | 14:09 |
| *** ratailor has joined #openstack-nova | 14:11 | |
| mriedem | dansmith: ok i think i remember now | 14:12 |
| mriedem | it's the PUT /os-services APIs | 14:12 |
| mriedem | https://developer.openstack.org/api-ref/compute/?expanded=add-host-detail,enable-scheduling-for-a-compute-service-detail#enable-scheduling-for-a-compute-service | 14:12 |
| mriedem | they don't take an id | 14:12 |
| mriedem | the body contains a host | 14:12 |
| mriedem | *hostname | 14:12 |
| *** voelzmo has quit IRC | 14:12 | |
| mriedem | that's when i started asking about if we could have collisions there and john said we could | 14:12 |
| *** hongbin has joined #openstack-nova | 14:13 | |
| mriedem | don't ask me how | 14:13 |
| dansmith | mriedem: okay I totally don't understand how, but I'll put this up and hopefully he'll show up | 14:13 |
| mriedem | anywho, as part of the spec we're collapsing those garbage PUT APIs into a single PUT with a service uuid in the path | 14:13 |
| *** zz_dimtruck is now known as dimtruck | 14:13 | |
| *** ijw has joined #openstack-nova | 14:13 | |
| mriedem | so | 14:13 |
| mriedem | PUT /os-services/disable { "host": "host1", "binary": "nova-compute" } | 14:13 |
| mriedem | becomes | 14:14 |
| mriedem | PUT /os-services/{service_id} { "status": "disabled" } | 14:14 |
| mriedem | where service_id is a uuid | 14:14 |
| mriedem | having said all that, i think we're fine with what you're proposing :) | 14:14 |
| mriedem | we == me and the turd in my pocket | 14:14 |
| *** yushb has joined #openstack-nova | 14:14 | |
| *** dillaman has quit IRC | 14:14 | |
| dansmith | ack, yep | 14:15 |
| *** coreywright has joined #openstack-nova | 14:16 | |
| *** ijw has quit IRC | 14:19 | |
| *** claudiub|3 has quit IRC | 14:19 | |
| *** iceyao has joined #openstack-nova | 14:19 | |
| *** yingjun has joined #openstack-nova | 14:20 | |
| *** felipemonteiro__ has joined #openstack-nova | 14:21 | |
| *** felipemonteiro_ has joined #openstack-nova | 14:23 | |
| *** salv-orlando has quit IRC | 14:23 | |
| *** karthiks has joined #openstack-nova | 14:25 | |
| *** prateek has quit IRC | 14:26 | |
| *** felipemonteiro__ has quit IRC | 14:27 | |
| *** yangyape_ has joined #openstack-nova | 14:27 | |
| *** ratailor has quit IRC | 14:29 | |
| *** dillaman has joined #openstack-nova | 14:30 | |
| *** yangyapeng has quit IRC | 14:30 | |
| *** gouthamr has joined #openstack-nova | 14:31 | |
| *** felipemonteiro has joined #openstack-nova | 14:33 | |
| *** slaweq has joined #openstack-nova | 14:33 | |
| *** felipemonteiro_ has quit IRC | 14:35 | |
| *** vks1 has joined #openstack-nova | 14:36 | |
| *** salv-orlando has joined #openstack-nova | 14:38 | |
| *** moshele has joined #openstack-nova | 14:38 | |
| *** slaweq has quit IRC | 14:38 | |
| *** zhurong has quit IRC | 14:39 | |
| *** lpetrut_ has quit IRC | 14:40 | |
| *** awaugama has joined #openstack-nova | 14:42 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: re-Allow adding computes with no ComputeNodes to aggregates https://review.openstack.org/460616 | 14:42 |
| *** ltomasbo is now known as ltomasbo|away | 14:42 | |
| *** darrenc has quit IRC | 14:43 | |
| *** markus_z has quit IRC | 14:44 | |
| *** jamesdenton has joined #openstack-nova | 14:51 | |
| *** armax has joined #openstack-nova | 14:52 | |
| mriedem | hmm, isn't it possible to override a mock? | 14:54 |
| mriedem | like if the test class does a global mock of something but a test case wants to override it | 14:54 |
| mriedem | i thought just decorating the test case would override the mock from the test class... | 14:54 |
| mriedem | but apparently not | 14:54 |
| *** ralonsoh_ has joined #openstack-nova | 14:55 | |
| *** ralonsoh has quit IRC | 14:57 | |
| *** sridharg has quit IRC | 14:58 | |
| artom | mriedem, maybe explicit assignment will work? | 14:58 |
| artom | nova.stuff.moar = mock.Mock() | 14:58 |
| zioproto | mriedem: in the table block_device_mapping what is the column no_device for ? for one attachment I have value 0 and for the other NULL | 14:59 |
| *** Kevin_Zheng has joined #openstack-nova | 14:59 | |
| *** nle5223__ has joined #openstack-nova | 15:02 | |
| *** ralonsoh has joined #openstack-nova | 15:02 | |
| *** ralonsoh_ has quit IRC | 15:02 | |
| openstackgerrit | Béla Vancsics proposed openstack/nova master: [WIP] Transform aggregate.update_metadata notification https://review.openstack.org/460625 | 15:03 |
| mriedem | zioproto: good question | 15:03 |
| mriedem | zioproto: let me consult my tome of bdm fields | 15:03 |
| * mriedem is gonna need more chicken blood | 15:04 | |
| *** iceyao has quit IRC | 15:05 | |
| *** pcaruana has quit IRC | 15:05 | |
| *** vks1 has quit IRC | 15:05 | |
| *** READ10 has joined #openstack-nova | 15:06 | |
| *** claudiub has joined #openstack-nova | 15:07 | |
| *** kevinz has quit IRC | 15:07 | |
| mriedem | not doc'ed in the api | 15:08 |
| mriedem | schema says it could be a dict in the api? | 15:08 |
| mriedem | but it's treated like a boolean, | 15:08 |
| mriedem | it's definitely some legacy bdmv1 thing | 15:08 |
| *** adrian_otto has joined #openstack-nova | 15:09 | |
| mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/block_device_mapping_v1.py#L34 | 15:09 |
| *** nle5223__ is now known as Aqsa | 15:09 | |
| mriedem | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2969 | 15:10 |
| *** yingjun has quit IRC | 15:10 | |
| *** mlakat has quit IRC | 15:11 | |
| *** jaosorior is now known as jaosorior_away | 15:13 | |
| *** yingjun has joined #openstack-nova | 15:14 | |
| mriedem | boolean in the object model https://github.com/openstack/nova/blob/master/nova/objects/block_device.py#L85 | 15:14 |
| *** yingjun has quit IRC | 15:14 | |
| mriedem | boolean in the data model https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L622 | 15:14 |
| mriedem | zioproto: i'm not really sure what the hell it means, | 15:16 |
| mriedem | but it looks like maybe your customer did a swap volume operation on that instance? | 15:16 |
| mriedem | because that sets 'no_device': None | 15:16 |
| mriedem | in the bdm | 15:16 |
| *** zigo has quit IRC | 15:17 | |
| zioproto | possible | 15:18 |
| zioproto | also | 15:18 |
| zioproto | I dont understand | 15:18 |
| zioproto | why when I attach this volume | 15:18 |
| zioproto | the device is /dev/hda | 15:18 |
| *** ltomasbo|away is now known as ltomasbo | 15:18 | |
| zioproto | this is the attachment | 15:18 |
| zioproto | where this /dev/hda is generated from ? | 15:18 |
| mriedem | zioproto: should be from nova/virt/libvirt/blockinfo.py i think | 15:19 |
| mriedem | see find_disk_dev_for_disk_bus | 15:19 |
| *** vks1 has joined #openstack-nova | 15:20 | |
| *** Aqsa has quit IRC | 15:20 | |
| *** armax has quit IRC | 15:23 | |
| mriedem | mdbooth: god i'd love to remove all of this bdm v1 code | 15:23 |
| mdbooth | mriedem: Hehe | 15:23 |
| zioproto | I try with command line to force /dev/sdb | 15:24 |
| zioproto | but it ignores me | 15:24 |
| mriedem | zioproto: the libvirt driver ignores the device name you pass in | 15:24 |
| mriedem | when attaching a volume, or booting from volume | 15:24 |
| mdbooth | mriedem: How would we deprecate it? | 15:24 |
| lyarwood | with fire? | 15:24 |
| zioproto | but there must be a bug that assigned this /dev/hda name | 15:24 |
| mriedem | mdbooth: i think we'd start by deprecating the legacy bdm v1 fields in the api | 15:24 |
| zioproto | cant be both /dev/sda and /dev/hda | 15:24 |
| *** abhi89 has quit IRC | 15:25 | |
| mdbooth | lyarwood: Well the mechanism would be to take off and nuke it from orbit, of course. I meant the prior communication. | 15:25 |
| mriedem | mdbooth: but that's like microversion 2.50 at this point, and unless we raise minimum microversions in the api that never goes away, | 15:25 |
| mriedem | and even if we did, it would probably take a long time before we could remove it | 15:25 |
| *** iceyao has joined #openstack-nova | 15:25 | |
| *** chyka has joined #openstack-nova | 15:26 | |
| mriedem | zioproto: so the guest xml says it's /dev/sda? | 15:26 |
| mriedem | but the bdm attachment table shows it as hda? | 15:26 |
| *** mdrabe has quit IRC | 15:26 | |
| sfinucan | sdague: If I want to capture logging, which fixture do I need to use? | 15:26 |
| mriedem | zioproto: can you tell if they performed a swap volume on the instance? there should be an instance action recorded for it | 15:26 |
| sfinucan | I saw a comment on one of mriedem's patches to not mock oslo.log, but I can't find said patch | 15:26 |
| mdbooth | sfinucan: Interesting. I was about to say I've just mocked the log object before. | 15:27 |
| mriedem | zioproto: actually it looks like we don't record an instance action event for swap volume | 15:27 |
| mriedem | damn | 15:27 |
| * mdbooth is also now interested in the answer. | 15:27 | |
| zioproto | I know that this volume was imported, not created with openstack | 15:28 |
| mriedem | sfinucan: mdbooth: OutputStreamCapture i htink | 15:28 |
| mriedem | *think | 15:28 |
| mriedem | zioproto: imported? | 15:28 |
| mriedem | via cinder? | 15:28 |
| zioproto | it is some machine converted from vmware or something | 15:28 |
| sfinucan | mriedem: ta | 15:28 |
| mdbooth | mriedem: volume-only image? | 15:29 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove compatibility code for flavors https://review.openstack.org/460377 | 15:29 |
| sdague | sfinucan: actually, I think we buried the hook for that | 15:30 |
| *** iceyao has quit IRC | 15:30 | |
| *** mdrabe has joined #openstack-nova | 15:30 | |
| *** markvoelker has quit IRC | 15:30 | |
| mriedem | sfinucan: i was actually curious too which fixture sdague was talking about | 15:31 |
| mriedem | since we have a few that seem related | 15:31 |
| sdague | nova_fixtures.StandardLogging() would give us a fixture with self.logger that we can pull on | 15:31 |
| *** markvoelker has joined #openstack-nova | 15:31 | |
| sdague | but we didn't assign a reference to get back to it | 15:31 |
| mriedem | so the base test case needs to store self.logger = self.useFixture(nova_fixtures.StandardLogging()).logger? | 15:31 |
| mriedem | right? | 15:31 |
| mriedem | and then i can do self.assertIn('foo', self.logger.info)? | 15:32 |
| johnthetubaguy | mriedem: dansmith: was the ping I missed about the duplicate hostnames thing in os-services? I think I was really asking about FQDN vs hostname. There wouldn't be duplicate FQDNs. | 15:32 |
| mriedem | oh self.logger.output | 15:32 |
| dansmith | johnthetubaguy: okay, when do we use hostnames that aren't fqdns? | 15:32 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Expose StandardLogging fixture for use https://review.openstack.org/460642 | 15:32 |
| dansmith | johnthetubaguy: not for service registration, AFAIK | 15:32 |
| sdague | mriedem: or that ^^^ | 15:33 |
| johnthetubaguy | dansmith: oh, I thought we default to hostname rather than fqdn, that might just be me getting all mixed up | 15:33 |
| dansmith | johnthetubaguy: not that I've ver seen | 15:33 |
| sdague | mriedem: I thought it had gotten exposed | 15:33 |
| *** ijw has joined #openstack-nova | 15:33 | |
| sdague | but apparently not, but there is a whole mechanism for it being captured, so we should us that instead of mocks | 15:34 |
| zioproto | mriedem: so it was two disks from vmware. We converted this disks to glance images, and then to cinder volumes. | 15:34 |
| johnthetubaguy | dansmith: ok, thats probably just my confusion then, seems fine to assume no duplicate fqdn's | 15:34 |
| openstackgerrit | Samantha Blanco proposed openstack/nova master: Remove flavor-rxtx policy https://review.openstack.org/444036 | 15:34 |
| dansmith | johnthetubaguy: ack | 15:34 |
| *** aarefiev is now known as aarefiev_afk | 15:35 | |
| mriedem | zioproto: ok, the device name won't be stored in the cinder volumes anyway, only the mountpoint meta in cinder, but that's set by nova when the volume is attached | 15:35 |
| mriedem | on a complete tangent, it seems like we should be recording instance actions for swap volume, since that's a thing that happens mostly out of band from a nova api pov | 15:36 |
| mriedem | since cinder initiates it via retype | 15:36 |
| *** karthiks has quit IRC | 15:37 | |
| mriedem | dansmith: btw, https://review.openstack.org/460377 turned out to be kind of a beast | 15:38 |
| dansmith | sweet | 15:38 |
| johnthetubaguy | dansmith: so we don't really use the fqdn in here: https://github.com/openstack/nova/blob/master/nova/conf/netconf.py#L55 although I could be reading the docs wrongly: https://docs.python.org/2/library/socket.html#socket.gethostname | 15:38 |
| dansmith | johnthetubaguy: but that's for things like telling other computes how to contact us | 15:39 |
| dansmith | johnthetubaguy: not related to service identity, AFAIK | 15:39 |
| johnthetubaguy | dansmith: we use the conf to register the service though, I thought | 15:39 |
| dansmith | oh, host | 15:39 |
| dansmith | sorry, I was reading the lines wrong, and thought you were talking about the storage_ip | 15:39 |
| johnthetubaguy | dansmith: ah, doh | 15:39 |
| dansmith | johnthetubaguy: so, yeah I guess they could configure it to be wrong | 15:40 |
| mdbooth | zioproto: Assuming that the instance in question was created (from Nova's pov) from an image, does if have hw_architecture defined? | 15:40 |
| mdbooth | zioproto: Is it a 32bit arch by any chance? | 15:40 |
| dansmith | johnthetubaguy: but again, if they have dupes, we'll fail consistency checks AFAIK | 15:40 |
| johnthetubaguy | dansmith: well, not in cells v1, its a different DB, I think | 15:40 |
| dansmith | johnthetubaguy: but it's all merged at the top | 15:41 |
| dansmith | johnthetubaguy: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L81-L84 | 15:41 |
| dansmith | johnthetubaguy: you'll still end up with all the services up there, right? else none of those APIs will work | 15:41 |
| johnthetubaguy | dansmith: good point, it must be like that today | 15:41 |
| zioproto | mdbooth: <type arch='x86_64' machine='pc-i440fx-xenial'>hvm</type> | 15:41 |
| johnthetubaguy | dansmith: seems we are covered either way then, cool | 15:41 |
| mdbooth | zioproto: I mean does the glance image have a hw_architecture image property? | 15:42 |
| dansmith | johnthetubaguy: just like getting rid of these ambiguous id-using apis, if we have people with dupes here, we might as well flush them out :) | 15:42 |
| zioproto | So I tried booting with only 1 volume attached, and the attach the second volume later. But I get libvirtError: Operation not supported: disk bus 'ide' cannot be hotplugged. | 15:42 |
| johnthetubaguy | dansmith: seems a good opportunity, it can only be creating strange subtable bugs in other places | 15:42 |
| dansmith | johnthetubaguy: if even possible, yeah | 15:43 |
| zioproto | mdbooth: no, but now I see it has hw_disk_bus='ide' | 15:43 |
| zioproto | so maybe hda comes from there | 15:43 |
| mdbooth | boom! | 15:43 |
| zioproto | but the volume created from that image does not have this property | 15:44 |
| zioproto | at least I cant find it | 15:44 |
| openstackgerrit | Rick Bartra proposed openstack/nova master: Add policy granularity to the Flavors API https://review.openstack.org/449288 | 15:44 |
| mdbooth | zioproto: It's looking at the glance image | 15:45 |
| zioproto | can I remove the property from the glance image ? | 15:45 |
| mdbooth | Actually, no. It's looking at the glance image metadata, which will have been stored invisibly with the volume. | 15:45 |
| *** tbachman has joined #openstack-nova | 15:46 | |
| zioproto | mdbooth: in the cinder database ? | 15:46 |
| mdbooth | Yes | 15:46 |
| mdbooth | I don't think anything exposes it, though | 15:46 |
| mdbooth | But I could be wrong | 15:46 |
| mriedem | yeah the glance image meta is stored all over the place... | 15:47 |
| mdbooth | So that's why it's ide | 15:48 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove **kwargs passing in payload __init__ https://review.openstack.org/418489 | 15:48 |
| mdbooth | Why does it fail to boot? | 15:48 |
| mriedem | and when you snapshot a server with volumes attached, the bdm meta goes into the image snapshot meta | 15:48 |
| *** yamahata_ has quit IRC | 15:48 | |
| zioproto | cant find this ide metadata doing select * from volume_glance_metadata where volume_id=uuid | 15:49 |
| *** kevinz has joined #openstack-nova | 15:49 | |
| *** nkorabli has joined #openstack-nova | 15:49 | |
| *** salv-orl_ has joined #openstack-nova | 15:50 | |
| zioproto | I give up for today | 15:51 |
| zioproto | thanks for the help | 15:51 |
| zioproto | I will give feedback once this is fixed | 15:51 |
| zioproto | it is probably a corner case because this VM with this cinder volume was created in a weird way | 15:51 |
| zioproto | what is sure is that it booted once in the past | 15:51 |
| zioproto | thank you | 15:52 |
| mriedem | zioproto: i also wouldn't be surprised if swap volume or something was involved | 15:52 |
| mriedem | maybe cinder has a record of volume retype/migrations you can find? | 15:52 |
| zioproto | I have no idea | 15:52 |
| zioproto | in the action log of nova I can find only the start and stop | 15:52 |
| *** salv-orlando has quit IRC | 15:52 | |
| *** imacdonn_ is now known as imacdonn | 15:52 | |
| mriedem | right we don't record instance actions for swap volume apparently | 15:53 |
| mriedem | which seems like a gap to me | 15:53 |
| *** kevinz has quit IRC | 15:54 | |
| *** Apoorva has joined #openstack-nova | 15:54 | |
| johnthetubaguy | mriedem: there was a spec up at one point to add instance actions into all the missing APIs, I think that had a list of them missing ones | 15:57 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged nic attachment https://review.openstack.org/415622 | 15:57 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete nic metadata when detaching interface https://review.openstack.org/435387 | 15:57 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Libvirt support for tagged volume attachment https://review.openstack.org/418100 | 15:57 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082 | 15:57 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged volume attachment https://review.openstack.org/391941 | 15:57 |
| mriedem | johnthetubaguy: ok so just an oversight and not intentional | 15:57 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021 | 15:57 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Libvirt support for tagged nic attachment https://review.openstack.org/415520 | 15:57 |
| johnthetubaguy | mriedem: yeah, its just a not finished thing, I believe | 15:57 |
| johnthetubaguy | mriedem: as volume operations don't change the server state, generally, they are in a slight bit of limbo in our error handling, honestly | 15:58 |
| *** prometheanfire has joined #openstack-nova | 15:59 | |
| mriedem | the task state changes | 16:00 |
| imacdonn | mdbooth: still around ? | 16:00 |
| prometheanfire | mriedem: you know about the novaclient issues (8.0.0 not in UC because it looks like it breaks things) https://review.openstack.org/454164 | 16:00 |
| mriedem | nova/cinder meeting in #openstack-meeting-cp | 16:00 |
| mriedem | prometheanfire: i know osc and horizon had issues | 16:00 |
| mriedem | b/c of nova-network | 16:00 |
| *** gszasz has quit IRC | 16:01 | |
| prometheanfire | k, just making sure you were aware | 16:01 |
| mriedem | prometheanfire: it came up in the mailing list about a month ago i think | 16:01 |
| mriedem | but yeah | 16:01 |
| mriedem | thanks | 16:01 |
| prometheanfire | ya, it's a older review now | 16:01 |
| *** rmart04 has quit IRC | 16:01 | |
| sdague | prometheanfire: horizon said they were dropping it | 16:02 |
| mdbooth | zioproto: That metadata will only be set on the root volume, btw | 16:02 |
| *** ayogi has joined #openstack-nova | 16:02 | |
| mdbooth | imacdonn: Yep | 16:02 |
| imacdonn | mdbooth: hi ... just checking if you're still following https://bugs.launchpad.net/nova/+bug/1683972 ? | 16:02 |
| openstack | Launchpad bug 1683972 in os-brick "Overlapping iSCSI volume detach/attach can leave behind broken SCSI devices and multipath maps." [Undecided,New] | 16:02 |
| mriedem | johnthetubaguy: also related to cinder telling nova to do things https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/nova-support-attached-volume-extend.html | 16:02 |
| mriedem | ^ i brought up the error handling and instance actions stuff in that too | 16:03 |
| mriedem | b/c if/when it fails we need a way to report it | 16:03 |
| imacdonn | mdbooth: I added os-brick and geguileo to it, but haven't heard anything from that side either | 16:03 |
| mdbooth | imacdonn: Just reading your comments | 16:03 |
| imacdonn | mdbooth: k, tnx | 16:04 |
| mdbooth | imacdonn: Did you get the chance to try with the very latest os-brick? | 16:04 |
| mdbooth | Ignore me, I see you did | 16:05 |
| imacdonn | mdbooth: I applied the patch for that specific fix... I suppose it's possible that something else changed in another commit, but I doubt it | 16:05 |
| *** eharney has quit IRC | 16:05 | |
| *** jogo has quit IRC | 16:07 | |
| *** prometheanfire has left #openstack-nova | 16:08 | |
| *** slaweq has joined #openstack-nova | 16:10 | |
| sfinucan | johnthetubaguy: This patch hit a merge conflict. Fancy reviewing it again to get it in? https://review.openstack.org/#/c/418489 | 16:10 |
| sfinucan | (previously +w'd, but very prone to merge conflict) | 16:10 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Replace reserved_host_disk_mb with reserved_host_disk_gb https://review.openstack.org/460661 | 16:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove dead code https://review.openstack.org/460662 | 16:11 |
| mdbooth | imacdonn: So you're referring to _disconnect_volume_iscsi in os-brick, right? | 16:11 |
| sfinucan | ^ edleafe, jaypipes: You might like the first of those | 16:11 |
| mdbooth | imacdonn: The block starting: | 16:11 |
| mdbooth | # NOTE(vish): Only disconnect from the target if no luns from the | 16:11 |
| mdbooth | # target are in use. | 16:11 |
| sfinucan | or you might not. It's kind of hacky, but oslo.config doesn't give me anything more powerful :( | 16:11 |
| mdbooth | imacdonn: That's definitely looks racy | 16:12 |
| edleafe | sfinucan: thx - will review | 16:12 |
| jaypipes | sfinucan: cool, added to my queue. :) | 16:12 |
| *** slaweq has quit IRC | 16:12 | |
| *** moshele has quit IRC | 16:12 | |
| *** nic1 has joined #openstack-nova | 16:12 | |
| imacdonn | mdbooth: yes .. I understand why they want to clean up the session if it's not needed any more, but it reopens that window where another attachment cause zombie devices to appear | 16:12 |
| *** mdnadeem has quit IRC | 16:14 | |
| *** moshele has joined #openstack-nova | 16:16 | |
| *** nic1 is now known as nic | 16:16 | |
| *** yushb has quit IRC | 16:16 | |
| *** dtp has joined #openstack-nova | 16:16 | |
| mdbooth | imacdonn: So again the issue here is that we drop and then re-establish the connection to the target before terminate_connection has completed | 16:16 |
| *** tonygunk has quit IRC | 16:17 | |
| *** dtp has quit IRC | 16:17 | |
| mdbooth | And on re-establishing the connection, we rescan and get the lun on the host | 16:17 |
| mdbooth | And then terminate_connection does its thing and it goes stale | 16:17 |
| mdbooth | Have I got the sequence right? | 16:17 |
| imacdonn | mdbooth: there's no explicit rescan, but I suppose there is an effective one ... i.e. on new session establishment, *all* LUNs offered by the target are discovered | 16:18 |
| mdbooth | Right | 16:18 |
| *** eharney has joined #openstack-nova | 16:18 | |
| mdbooth | So again we want a per-target lock which covers attach, detach, and terminate connection | 16:19 |
| *** dtp has joined #openstack-nova | 16:19 | |
| imacdonn | mdbooth: That seems to be the only way to really cover it | 16:19 |
| imacdonn | mdbooth: I'm also a little bit wary of the os-brick patch .. it seems a bit sketchy, they way he's doing it now | 16:20 |
| mdbooth | The problem being that at the scope where we could currently put that lock we have no knowledge of targets | 16:20 |
| *** adrian_otto has quit IRC | 16:22 | |
| mdbooth | imacdonn mriedem johnthetubaguy: How many iscsi targets would typically exist in a deployment? | 16:23 |
| mdbooth | I personally baulk at the idea of a Global ISCSI Lock | 16:23 |
| *** damien_r has quit IRC | 16:24 | |
| mdbooth | But if a typical deployment would only have a single iscsi target anyway, then getting exercised about it is a bit pointless | 16:24 |
| mriedem | mdbooth: 0 idea | 16:24 |
| mriedem | mdbooth: you'd have to ask jgriffith or hemna probably | 16:24 |
| imacdonn | in my deployments, I have two per AZ ... they are the two halves of a ZFSSA cluster | 16:24 |
| mdbooth | Are there deployments out there doing lots of connect/disconnect which would be knobbled if you just serialised all iscsi operations regardless? | 16:25 |
| dansmith | you have at least one target per cinder-volume worker I think, | 16:25 |
| hemna | mdbooth, what do you mean? | 16:25 |
| dansmith | so if you're running a bunch of cinder-volumes with local LVM type stuff, you could have lots of targets right? | 16:25 |
| hemna | yes | 16:25 |
| hemna | and you'd have lots of targets if you used a storage array behind cinder too | 16:26 |
| dansmith | yeah | 16:26 |
| hemna | a target per exported volume | 16:26 |
| mdbooth | Ok, so a global iscsi lock would be a significant difference in practise to a per-target lock | 16:26 |
| *** bmace has quit IRC | 16:26 | |
| *** abalutoiu has quit IRC | 16:26 | |
| *** Drankis has quit IRC | 16:26 | |
| mdbooth | It would still be per-host though, I guess | 16:26 |
| *** bmace has joined #openstack-nova | 16:26 | |
| mdbooth | Perhaps it's not that bad | 16:27 |
| imacdonn | depends on the type of storage array perhaps .. the ZFSSA has one target per control-head, and lots of volumes on that target with different LUN numbers | 16:27 |
| hemna | but that's one target portal | 16:27 |
| hemna | with multiple targets (one per lun) | 16:28 |
| hemna | either way, yes, you can have multiple targets per storage backend going to the same initiator | 16:28 |
| hemna | so there is a potential race between calling os-brick's disconnect_volume and calling cinder's terminate_connection. | 16:28 |
| hemna | where a new attach comes in on the same backend and an scsi bus rescan can happen. | 16:29 |
| mdbooth | Hmm, no. Even scoped to just iscsi is problematic because we need the lock to cover terminate_connection | 16:29 |
| imacdonn | hemna: that's exactly what I've been experiencing (since the icehouse days) | 16:29 |
| hemna | not surprising | 16:29 |
| hemna | this can happen for FC based volumes too | 16:29 |
| mdbooth | terminate_connection really needs to live with disconnect. Soon... | 16:30 |
| *** lucasagomes is now known as lucas-afk | 16:31 | |
| *** jimbaker has left #openstack-nova | 16:31 | |
| hemna | not sure what you mean by that | 16:31 |
| *** armax has joined #openstack-nova | 16:31 | |
| hemna | os-brick calling cinder's terminate_connection ? | 16:31 |
| *** gouthamr has quit IRC | 16:31 | |
| mdbooth | hemna: I haven't thought that far down, but maybe | 16:31 |
| hemna | or just do a lock around disconnect_volume() and terminate_connection() | 16:31 |
| hemna | os-brick has no business calling cinder | 16:32 |
| mdbooth | That's the issue. Those things are all over the place. | 16:32 |
| mdbooth | I'm not sure I agree with that assertion. | 16:32 |
| imacdonn | it's not that easy .. terminate_connection() is not called from disconnect_volume() | 16:32 |
| imacdonn | maybe it could be, though | 16:32 |
| hemna | os-brick is not going to call cinder. | 16:33 |
| hemna | I'll -2 that immediately | 16:33 |
| smcginnis | +1! os-brick is a utiltiy library. | 16:33 |
| mdbooth | If terminate_connection is relevant to the correct operation of the driver (to be determined, but if...) then we would at the very least need to establish a way to make it happen | 16:33 |
| imacdonn | is there some way that os-brick could do a call back into some part of nova that then calls cinder ? | 16:33 |
| hemna | besides, we are changing the entire attachment API process between nova and cinder | 16:33 |
| hemna | I don't want os-brick knowing anything about who's calling it | 16:34 |
| hemna | it's a library used outside of openstack too. | 16:34 |
| mdbooth | hemna: I was also thinking the other day that locking requirements are driver-specific | 16:34 |
| imacdonn | so it'd be a generic "do what you need to do to make this LUN to way on whatever your backend is" interface | 16:34 |
| imacdonn | go away* | 16:34 |
| mdbooth | hemna: So if we don't want os-brick to do any locking, I get that | 16:35 |
| mdbooth | However, we still need a way for os-brick to tell us what locks we need to hold | 16:35 |
| mdbooth | Take this case, for eg, the lock we want is per-target | 16:35 |
| mdbooth | The caller has no idea what a target is, only os-brick knows that | 16:35 |
| hemna | just lock around the process of disconnecting a volume from the host | 16:36 |
| *** salv-orl_ has quit IRC | 16:36 | |
| hemna | which is the workflow of disconnect_volume(), then terminate_connection() | 16:36 |
| mdbooth | lock *what* around the process of disconnecting a volume | 16:36 |
| imacdonn | hemna: it's not, though | 16:36 |
| mdbooth | And now all drivers are going to have the same serialisation requirements | 16:36 |
| mdbooth | For some drivers, concurrent attach/detach is fine | 16:36 |
| mdbooth | Others not | 16:36 |
| imacdonn | hemna: terminate_connection() is called from a bunch of different places in compute.manager | 16:36 |
| mdbooth | For some, async terminate_connection is fine, no locking required | 16:37 |
| mdbooth | Others not | 16:37 |
| mdbooth | This is a hard interface | 16:37 |
| *** ayogi has quit IRC | 16:38 | |
| mdbooth | hemna: On the terminate_connection front, it could reasonably be a callback for eg | 16:39 |
| mdbooth | Then os-brick wouldn't have to know anything about cinder | 16:40 |
| *** gouthamr has joined #openstack-nova | 16:40 | |
| mdbooth | But 'tell the target to kill this lun now' is a generic concept | 16:40 |
| imacdonn | yeah, that's what I'm envisaging | 16:41 |
| *** Aqsa has joined #openstack-nova | 16:46 | |
| *** abhi89 has joined #openstack-nova | 16:47 | |
| *** ltomasbo is now known as ltomasbo|away | 16:48 | |
| *** voelzmo has joined #openstack-nova | 16:48 | |
| *** ociuhandu has quit IRC | 16:48 | |
| *** shangxdy has joined #openstack-nova | 16:51 | |
| *** ralonsoh has quit IRC | 16:51 | |
| *** derekh has quit IRC | 16:52 | |
| *** shangxdy has quit IRC | 16:54 | |
| *** browne has joined #openstack-nova | 16:55 | |
| *** voelzmo has quit IRC | 16:58 | |
| *** voelzmo has joined #openstack-nova | 16:58 | |
| *** baoli has quit IRC | 16:58 | |
| *** trinaths has joined #openstack-nova | 16:59 | |
| hemna | ok so why does this guy not call brick's disconnect_volume ? | 16:59 |
| hemna | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L3616 | 16:59 |
| *** litao has quit IRC | 16:59 | |
| hemna | This is what a proper disconnect workflow should look like in nova https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2264-L2268 | 17:00 |
| hemna | err | 17:00 |
| hemna | wait...lol | 17:01 |
| hemna | that doesn't call brick either. | 17:01 |
| *** salv-orlando has joined #openstack-nova | 17:01 | |
| * hemna needs more coffee | 17:01 | |
| imacdonn | right ... brick gets called from within driver.destroy .. that's the problem | 17:01 |
| imacdonn | as the comment right there says ;) | 17:01 |
| hemna | boo! | 17:02 |
| *** trinaths has quit IRC | 17:03 | |
| *** voelzmo has quit IRC | 17:03 | |
| imacdonn | the hack that's gotten me by since icehouse is to put a lock on _shutdown_instance() (and a few similar places in manager) and the same lock on connect_volume() in virt.libvirt.volume.iscsi | 17:04 |
| openstackgerrit | Abhishek Sharma M proposed openstack/nova master: Catching OverQuota Exception https://review.openstack.org/460305 | 17:05 |
| *** MasterOfBugs has joined #openstack-nova | 17:05 | |
| *** yangyape_ has quit IRC | 17:05 | |
| johnthetubaguy | mdbooth: that iSCSI question, isn't that backend specific? I thought it was one iSCSI target per volume for some? | 17:05 |
| *** ijw has quit IRC | 17:06 | |
| *** harlowja has quit IRC | 17:08 | |
| *** sumedhdegaonkar has quit IRC | 17:09 | |
| *** baoli has joined #openstack-nova | 17:09 | |
| *** pchavva1 has joined #openstack-nova | 17:10 | |
| *** pchavva1 has quit IRC | 17:10 | |
| openstackgerrit | Samantha Blanco proposed openstack/nova master: Remove flavor-rxtx policy https://review.openstack.org/444036 | 17:11 |
| *** abhi89 has quit IRC | 17:12 | |
| *** slaweq has joined #openstack-nova | 17:13 | |
| *** trinaths has joined #openstack-nova | 17:14 | |
| *** abalutoiu has joined #openstack-nova | 17:16 | |
| *** mnestratov has joined #openstack-nova | 17:17 | |
| *** slaweq has quit IRC | 17:18 | |
| *** vks1 has quit IRC | 17:23 | |
| *** cdent has quit IRC | 17:24 | |
| *** trinaths has left #openstack-nova | 17:27 | |
| *** jpena is now known as jpena|off | 17:28 | |
| *** tbachman has quit IRC | 17:29 | |
| *** iceyao has joined #openstack-nova | 17:31 | |
| *** baoli_ has joined #openstack-nova | 17:31 | |
| *** amotoki has quit IRC | 17:32 | |
| *** baoli has quit IRC | 17:33 | |
| *** jogo has joined #openstack-nova | 17:34 | |
| *** iceyao has quit IRC | 17:35 | |
| openstackgerrit | Steve Noyes proposed openstack/nova master: Add Cinder v3 detach to local_cleanup https://review.openstack.org/456851 | 17:37 |
| *** ijw has joined #openstack-nova | 17:39 | |
| *** hshiina has quit IRC | 17:40 | |
| *** arunman has quit IRC | 17:40 | |
| *** fragatina has quit IRC | 17:40 | |
| *** fragatina has joined #openstack-nova | 17:41 | |
| *** tongli has joined #openstack-nova | 17:41 | |
| *** baoli_ has quit IRC | 17:42 | |
| *** gyee has joined #openstack-nova | 17:43 | |
| efried | mordred Have a chance to skim https://review.openstack.org/#/c/460337/ yet? | 17:43 |
| efried | mordred I'm working on the nova changes to accomodate. | 17:44 |
| *** arunman has joined #openstack-nova | 17:44 | |
| *** baoli has joined #openstack-nova | 17:45 | |
| *** moshele has quit IRC | 17:45 | |
| mordred | oh good - they're fixed now | 17:46 |
| efried | trivial pep8 stuff. Still haven't done live testing, just wanting to make sure I'm heading down the right path here. | 17:47 |
| *** slaweq has joined #openstack-nova | 17:47 | |
| *** moshele has joined #openstack-nova | 17:47 | |
| *** arunman has quit IRC | 17:48 | |
| *** tbachman has joined #openstack-nova | 17:50 | |
| *** harlowja has joined #openstack-nova | 17:51 | |
| *** pewp has joined #openstack-nova | 17:52 | |
| *** arunman has joined #openstack-nova | 17:52 | |
| *** arunman has quit IRC | 17:52 | |
| *** mvk has quit IRC | 17:53 | |
| *** Kevin_Zheng has quit IRC | 17:57 | |
| *** erlon has joined #openstack-nova | 17:57 | |
| *** moshele has quit IRC | 18:00 | |
| *** jdurgin has joined #openstack-nova | 18:03 | |
| *** Matias has joined #openstack-nova | 18:05 | |
| *** yangyapeng has joined #openstack-nova | 18:06 | |
| *** tongli has quit IRC | 18:06 | |
| *** voelzmo has joined #openstack-nova | 18:07 | |
| mriedem | johnthetubaguy: i thought we had a policy check for showing fault details? | 18:08 |
| *** phuongnh has joined #openstack-nova | 18:08 | |
| mriedem | but i don't see that here https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/views/servers.py#L280 | 18:09 |
| *** satyar has joined #openstack-nova | 18:09 | |
| mriedem | except the is_admin check | 18:09 |
| *** yangyapeng has quit IRC | 18:10 | |
| *** phuongnh has quit IRC | 18:13 | |
| *** djohnsto has joined #openstack-nova | 18:17 | |
| *** claudiub has quit IRC | 18:18 | |
| *** adrian_otto has joined #openstack-nova | 18:19 | |
| *** slaweq has quit IRC | 18:26 | |
| *** Sukhdev has joined #openstack-nova | 18:26 | |
| *** Sukhdev has quit IRC | 18:27 | |
| *** salv-orlando has quit IRC | 18:27 | |
| efried | sdague Got a sec to talk about [glance]api_server*s* ? | 18:28 |
| *** linuxman has joined #openstack-nova | 18:28 | |
| *** john51_ has quit IRC | 18:34 | |
| *** john51 has joined #openstack-nova | 18:34 | |
| *** carthaca_ has quit IRC | 18:36 | |
| *** david_4 has quit IRC | 18:36 | |
| *** sapcc-bot has quit IRC | 18:36 | |
| *** david_5 has joined #openstack-nova | 18:36 | |
| *** sapcc-bot2 has joined #openstack-nova | 18:36 | |
| *** carthaca_2 has joined #openstack-nova | 18:36 | |
| *** claudiub has joined #openstack-nova | 18:36 | |
| linuxman | openstack-nova-scheduler service unable to start how to fix this issue | 18:37 |
| *** Daviey_ has joined #openstack-nova | 18:38 | |
| *** fnordahl_ has joined #openstack-nova | 18:38 | |
| *** igordcar1 has joined #openstack-nova | 18:38 | |
| *** Daviey has quit IRC | 18:38 | |
| *** annegentle has quit IRC | 18:38 | |
| *** fnordahl has quit IRC | 18:38 | |
| *** igordcard has quit IRC | 18:38 | |
| openstackgerrit | Steve Noyes proposed openstack/nova master: Add Cinder v3 detach to shutdown_instance https://review.openstack.org/456877 | 18:39 |
| efried | linuxman I think you want to ask that in #openstack? | 18:40 |
| linuxman | but i hava a problem with nova service | 18:41 |
| efried | Counts as "support of Nova deployments", nah? | 18:42 |
| mriedem | linuxman: see the channel topic please, this is generally not a support channel, especially without any sort of context on the specific issue | 18:42 |
| mriedem | "does not start" is not very helpful for debugging | 18:42 |
| mriedem | thorst: it's snowing here, just fyi | 18:44 |
| linuxman | you have any idea about proper rdo openstack channel | 18:44 |
| *** voelzmo has quit IRC | 18:45 | |
| mriedem | linuxman: i don't see one on https://wiki.openstack.org/wiki/IRC | 18:45 |
| mriedem | but i'd try #openstack-rdo? | 18:45 |
| mriedem | doesn't look like that's it | 18:45 |
| mriedem | linuxman: https://www.rdoproject.org/community/#discuss | 18:46 |
| imacdonn | just #rdo I think | 18:46 |
| mriedem | yes | 18:46 |
| linuxman | just #rdo i tried but know one is there | 18:46 |
| mriedem | i count 291 people | 18:47 |
| mriedem | make sure you're on freenode | 18:47 |
| imacdonn | I'm there .. I'm not just paying attention ;) | 18:47 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Do not log live migration success when it actually failed https://review.openstack.org/458958 | 18:48 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Expose StandardLogging fixture for use https://review.openstack.org/460642 | 18:48 |
| *** openstackgerrit has quit IRC | 18:48 | |
| mriedem | sdague: i made all of your log fixture dreams come true | 18:48 |
| *** fragatina has quit IRC | 18:50 | |
| *** slaweq has joined #openstack-nova | 18:50 | |
| mriedem | dansmith: you want to tickle this little ocata fix in https://review.openstack.org/#/c/459840/ ? | 18:51 |
| *** Sukhdev has joined #openstack-nova | 18:51 | |
| mriedem | dansmith: should i be reviewing https://review.openstack.org/#/c/460616/ ? | 18:52 |
| mriedem | is ironic/tripleo testing that out? | 18:52 |
| *** crushil has quit IRC | 18:52 | |
| thorst | mriedem: lol. It's 80 in RTP | 18:52 |
| *** crushil has joined #openstack-nova | 18:53 | |
| mriedem | oh now that i look out the window again the snow stopped | 18:53 |
| mriedem | that's like the 3rd time today | 18:53 |
| mriedem | i could just be hallucinating | 18:53 |
| dansmith | mriedem: working with them now and on functional tests | 18:53 |
| mriedem | ok | 18:53 |
| *** annegentle has joined #openstack-nova | 18:57 | |
| mriedem | EmilienM: "Postgresql support (or call it how you want) is also removed upstream in OpenStack." where was that decided? | 18:59 |
| mriedem | the governance change was abandoned i thought? | 18:59 |
| EmilienM | yeah probably | 18:59 |
| EmilienM | mriedem: AFIK there is a session in Boston about that | 18:59 |
| cfriesen | is it possible to run individual functional tests? | 18:59 |
| mriedem | right, but your email says it was removed | 18:59 |
| mriedem | cfriesen: yes | 18:59 |
| EmilienM | mriedem: we're got some feedback from our users who use postgres, I don't think we'll remove the code in our side. | 19:00 |
| EmilienM | mriedem: I was wrong | 19:00 |
| *** damien_r has joined #openstack-nova | 19:00 | |
| *** slaweq has quit IRC | 19:00 | |
| mriedem | cfriesen: tox -e functional -- nova.tests.functional..... | 19:00 |
| cfriesen | mriedem: thanks, I didn't have the double dash and it didn't like me | 19:00 |
| *** cdent has joined #openstack-nova | 19:01 | |
| mriedem | -- is key | 19:01 |
| *** adrian_otto has quit IRC | 19:01 | |
| *** READ10 has quit IRC | 19:03 | |
| *** crushil has quit IRC | 19:03 | |
| *** kfarr has joined #openstack-nova | 19:03 | |
| *** nkorabli has quit IRC | 19:03 | |
| *** abhi89 has joined #openstack-nova | 19:03 | |
| *** voelzmo has joined #openstack-nova | 19:04 | |
| *** timello has joined #openstack-nova | 19:05 | |
| *** damien_r1 has joined #openstack-nova | 19:06 | |
| *** damien_r has quit IRC | 19:06 | |
| sdague | mriedem: nice | 19:06 |
| *** yangyapeng has joined #openstack-nova | 19:07 | |
| *** mvk has joined #openstack-nova | 19:08 | |
| *** felipemonteiro has quit IRC | 19:08 | |
| *** openstackgerrit has joined #openstack-nova | 19:11 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove legacy v2.0 code from test_flavor_access https://review.openstack.org/460719 | 19:11 |
| *** yangyapeng has quit IRC | 19:11 | |
| *** linuxman has left #openstack-nova | 19:13 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: re-Allow adding computes with no ComputeNodes to aggregates https://review.openstack.org/460616 | 19:13 |
| dansmith | mriedem: you can look at this now ^ | 19:16 |
| dansmith | pretty sure that'll do it for them but they're testing now | 19:16 |
| mriedem | will do after jaybird's get_inventory libvirt change | 19:17 |
| abhi89 | johnthetubaguy: Hi.. can you please review https://review.openstack.org/460305.. you had suggested to change the exception message while translating the cinder exception.. | 19:17 |
| *** satyar has quit IRC | 19:18 | |
| *** ijw has quit IRC | 19:21 | |
| *** nkorabli has joined #openstack-nova | 19:22 | |
| *** kfarr has quit IRC | 19:25 | |
| *** slaweq has joined #openstack-nova | 19:25 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add a note to *_allocation_ratio options about Ironic hardcode https://review.openstack.org/460722 | 19:26 |
| mriedem | jaypipes: your patch made me think of this ^ | 19:26 |
| *** voelzmo has quit IRC | 19:29 | |
| *** salv-orlando has joined #openstack-nova | 19:30 | |
| *** voelzmo has joined #openstack-nova | 19:30 | |
| *** awaugama has quit IRC | 19:34 | |
| abhi89 | melwitt: Hi Melanie.. | 19:41 |
| melwitt | abhi89: hi | 19:41 |
| abhi89 | melwitt: regarding https://review.openstack.org/#/c/460305/ | 19:41 |
| *** kaisers has quit IRC | 19:41 | |
| *** kaisers has joined #openstack-nova | 19:42 | |
| abhi89 | in that fix, previously, everytime we had a volume related quota exception ('gigabytes', 'volumes', 'per_volume_gigabytes'), we used to raise VolumeLimitExceeded exception | 19:43 |
| abhi89 | now with my change, we give appropriate exception message for each of those 3 exceptions | 19:44 |
| abhi89 | the bug is not related to "Failure prepping block device". its related to always raising og VolumeLimitExceeded exception in those 3 cases | 19:45 |
| melwitt | abhi89: right. and by appropriate, do you mean saying "volume related" instead of "volume resource" or is there more to it that I missed? | 19:45 |
| melwitt | abhi89: okay, I'm curious why the bug calls out getting the message of "Failure prepping block device" then. because the change doesn't seem related to that | 19:46 |
| abhi89 | there is more to it.. | 19:46 |
| *** kaisers has quit IRC | 19:46 | |
| abhi89 | "VolumeLimitExceeded: Maximum number of volumes allowed (5) exceeded for quota 'volumes'." this message will be generated in case of "volumes" quota exceed | 19:46 |
| abhi89 | number there is just an example | 19:47 |
| *** crushil has joined #openstack-nova | 19:47 | |
| abhi89 | "VolumeSizeExceedsLimit: Requested volume size 5G is larger than maximum allowed limit 4G." message will be there when 'per_volume_gigabyte' quota is exceeded | 19:48 |
| *** kaisers has joined #openstack-nova | 19:48 | |
| abhi89 | "VolumeSizeExceedsAvailableQuota: Requested volume or snapshot exceeds allowed gigabytes quota. Requested 5G, quota is 25G and 21G has been consumed." message will be generated when 'gigabyte' quota exceeds | 19:48 |
| melwitt | abhi89: okay, so what you are doing is letting the original overquota exception bubble up which will contain the correct message | 19:49 |
| abhi89 | so these are the 3 specific messages which come as part of OverLimit exception. This OverLimit exception get translated to OverQuota exception. After translation, I embed the appropriate message from OverLImit to OverQuota, so that we have the exact reason why the VM deploy failed | 19:50 |
| abhi89 | original OverLimit message | 19:50 |
| melwitt | abhi89: okay. so I think the main thing your patch needs is a bit of test coverage that shows those scenarios and verifies we get the message we expect in each case. similar to the regression test that I think should be kept | 19:52 |
| *** crushil has quit IRC | 19:52 | |
| abhi89 | I removed the regression test because it was very specific to just 'VolumeLimitExceeded' for all 3 cases | 19:52 |
| abhi89 | we already have a test case to check whehter we have OverQuota exception or not.. for all 3 specific cases, as we have replaced the OverQuota message to OverLimit message, we wont be knowing which of the 3 quota exceeded | 19:55 |
| mriedem | dansmith: jaypipes: comments in https://review.openstack.org/#/c/457782 - overall i don't have anything to block it, but i don't like the tight coupling and assumptions being made in the virt driver about what the RT is going to fil lin for it | 20:00 |
| mriedem | *fill | 20:00 |
| *** pchavva has quit IRC | 20:02 | |
| abhi89 | melwitt: was i able to put I point clearly! can you please suggest what can I improve upon if you are not satisfied with this change.. | 20:03 |
| *** felipemonteiro has joined #openstack-nova | 20:03 | |
| melwitt | abhi89: yes, was looking at it some more. basically, I want to see test coverage that verifies that we preserve and pass through the error message from cinder. because that's what we're relying on for the correct message. I don't think I see coverage of that yet unless I've missed something | 20:04 |
| melwitt | abhi89: I had been thinking you could adapt the regression test (instead of removing it) to put in an example message from cinder in the OverLimit exception, then assert the message is as expected in our response text | 20:06 |
| cdent | macsz: :( | 20:06 |
| *** yangyapeng has joined #openstack-nova | 20:08 | |
| *** felipemonteiro_ has joined #openstack-nova | 20:08 | |
| abhi89 | melwitt: we can put have one of the example messages to assert with.. but we should know which of the 3 occured i.e., which of the 3 have we replaced OverQuota's message with OverLimit's. That info is not with us. | 20:08 |
| *** abhi89 has quit IRC | 20:09 | |
| *** abhi89 has joined #openstack-nova | 20:10 | |
| melwitt | abhi89: what do you mean? if we use an example message of "VolumeSizeExceedsAvailableQuota: Requested volume or snapshot exceeds allowed gigabytes quota. Requested 5G, quota is 25G and 21G has been consumed." and we assertIn('VolumeSizeExceedsAvailableQuota', e.response.text) that will simulate it, no? | 20:10 |
| macsz | cdent: and i was just getting comfortable with nova | 20:11 |
| *** felipemonteiro has quit IRC | 20:11 | |
| edleafe | macsz: that was quick - I'm still not comfortable :) | 20:11 |
| cdent | yeah, me neither. very impressive | 20:12 |
| mriedem | edleafe: try a larger pant size | 20:12 |
| cdent | :) | 20:12 |
| mriedem | edleafe: you and your skinny jeans | 20:12 |
| mriedem | always the fashionista | 20:12 |
| cdent | mordred has some writing pants that he sometimes shares | 20:12 |
| edleafe | mriedem: Not fair. I was into hating on hipsters before it was cool | 20:12 |
| abhi89 | melwitt: we can assertIn('VolumeSizeExceedsAvailableQuota', e.response.text).. but how will we know which exception message is coming in? | 20:12 |
| *** yangyapeng has quit IRC | 20:12 | |
| mriedem | i for one wear my fat pants as often as possible now that i'm working from home | 20:12 |
| mordred | efried: yah - I believe that's spot-on. I also poked morgan to look at it as well | 20:13 |
| edleafe | mriedem: you wfh and you still wear pants? | 20:13 |
| mordred | edleafe: sorry- I wrote that a few hours ago - I just forgot to hit enter | 20:13 |
| abhi89 | in the previous case we could, as it was always the VolumeLimitExceeded coming in | 20:13 |
| *** adrian_otto has joined #openstack-nova | 20:13 | |
| mriedem | edleafe: i'm still learning | 20:13 |
| mordred | cdent: it's important to note that it's a single shared pair of pants | 20:13 |
| smcginnis | edleafe: The question is whether he's showered or not. | 20:13 |
| mriedem | oh i shower | 20:13 |
| cdent | mordred: that may explain my current discomfort | 20:13 |
| abhi89 | melwitt: in the previous case we could, as it was always the VolumeLimitExceeded coming in | 20:13 |
| cdent | mriedem: have you stopped shaving yet? | 20:13 |
| edleafe | mriedem showers every month whether he needs it or not | 20:13 |
| macsz | edleafe: i was just getting there, which would then require getting there a little further and further :D | 20:13 |
| mriedem | cdent: i actually shave more surprisingly | 20:14 |
| mriedem | b/c i have more time in the morning | 20:14 |
| *** sambetts is now known as sambetts|afk | 20:14 | |
| cdent | ah the halcyon days of early work-at-home: "time in the morning" | 20:14 |
| *** smatzek has quit IRC | 20:15 | |
| melwitt | abhi89: in the test if you provide an example message when constructing the OverLimit exception, to simulate the cinder client raising that, then you can assert it in our response text | 20:15 |
| *** crushil has joined #openstack-nova | 20:15 | |
| *** eharney has quit IRC | 20:17 | |
| *** liusheng has quit IRC | 20:17 | |
| *** liusheng has joined #openstack-nova | 20:18 | |
| *** iceyao has joined #openstack-nova | 20:18 | |
| *** ijw has joined #openstack-nova | 20:18 | |
| abhi89 | melwitt: when constructing the OverQuota exception(copying OverLimit exception's message to OverQuota exception), i should do what! I didnot understand | 20:19 |
| cdent | 'night all | 20:19 |
| *** cdent has quit IRC | 20:19 | |
| melwitt | abhi89: in the test "test_over_limit_volumes" in nova/tests/functional/regressions/test_bug_1554631.py you could provide an example exception message when constructing the cinder_exceptions.OverLimit() object. and then you assert part of the message in the response text. that would verify that we're passing through the error message from cinder. does that make sense? | 20:21 |
| *** tbachman has quit IRC | 20:22 | |
| *** iceyao has quit IRC | 20:23 | |
| *** tbachman has joined #openstack-nova | 20:25 | |
| *** liverpooler has quit IRC | 20:26 | |
| bauzas | mriedem: dansmith: others, have you seen https://review.openstack.org/#/c/460455/1 ? | 20:27 |
| dansmith | bauzas: hadn't yet but cool | 20:27 |
| efried | mordred Thanks for looking. Will proceed with UT. | 20:28 |
| efried | mordred Having pored over os-client-config code a bit, I think I may be ready to start asking leading questions, whenever you have a mo. | 20:28 |
| bauzas | dansmith: mriedem: the main problem with the scheduler is that we don't have the instance UUIDs there | 20:28 |
| mordred | efried: awesome - I'm on (very fun) phone call at the moment- hopefully off soon | 20:29 |
| abhi89 | melwitt: so the example exception message when constructing cinder_exceptions.OverLimit() should have common text from all 3 types of exception messages, so that we can check with assertIn whether this example message is part of all 3 exception messages.. this is what you meant? | 20:29 |
| erhudy | hdecejhbhdednddujvregvebfhcjhjngbrjhrekfikgf | 20:29 |
| erhudy | oops! | 20:29 |
| erhudy | treacherously betrayed by a hairtrigger yubikey | 20:29 |
| *** Aqsa has quit IRC | 20:30 | |
| mriedem | bauzas: we don't? i thought the host manager pulled the instance uuids per host on startup? | 20:31 |
| melwitt | abhi89: no, I was suggesting we can just pick one specific one and use it as the example in the test. because what we really want to know is if we are preserving the message from cinder and propagating that to the end user | 20:31 |
| mriedem | via update_instance_info? | 20:31 |
| mriedem | which is configurable though | 20:31 |
| bauzas | mriedem: because we only provide the first instance into the RequestSpec object to the scheduler | 20:32 |
| *** nkorabli has quit IRC | 20:32 | |
| *** Sukhdev has quit IRC | 20:32 | |
| *** voelzmo has quit IRC | 20:32 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/460515 | 20:32 |
| *** dtp has quit IRC | 20:34 | |
| abhi89 | melwitt: but how can we pick one specific message & test it against the 3 exception messages.. the UT will fail in the other 2 cases.. i agree with you that we need to know whether we are preservinfg the message from cinder or not.. | 20:34 |
| *** damien_r1 has quit IRC | 20:34 | |
| melwitt | abhi89: we pick one specific message and test against the one specific message. I think that would be good enough. earlier I mentioned all scenarios but since we've been talking about it, the main idea is verifying we preserve the message from cinder, and we can use just one specific example to do that | 20:36 |
| mriedem | dansmith: comments in https://review.openstack.org/#/c/460616/ | 20:37 |
| *** dimtruck is now known as zz_dimtruck | 20:37 | |
| *** kaisers has quit IRC | 20:38 | |
| *** anupn has joined #openstack-nova | 20:38 | |
| *** salv-orlando has quit IRC | 20:39 | |
| *** anupn has left #openstack-nova | 20:39 | |
| *** salv-orlando has joined #openstack-nova | 20:39 | |
| *** nkorabli has joined #openstack-nova | 20:39 | |
| openstackgerrit | Chris Friesen proposed openstack/nova master: show flavor info in server details https://review.openstack.org/434514 | 20:42 |
| cfriesen | ^ hopefully this passes all the tests now | 20:42 |
| *** hferenc_ has joined #openstack-nova | 20:45 | |
| *** fragatina has joined #openstack-nova | 20:45 | |
| *** fragatina has quit IRC | 20:45 | |
| *** fragatina has joined #openstack-nova | 20:46 | |
| mriedem | sdague: if you can get https://review.openstack.org/#/c/457008/ at some point we can close out the 2.45 blueprint | 20:46 |
| sdague | mriedem: looking | 20:46 |
| *** rfolco has quit IRC | 20:46 | |
| sdague | mriedem: bam! | 20:47 |
| mriedem | thanks | 20:48 |
| mriedem | did you see the easter egg i put in there for you? | 20:48 |
| *** dfisher has joined #openstack-nova | 20:49 | |
| *** awaugama has joined #openstack-nova | 20:50 | |
| *** takashin has joined #openstack-nova | 20:53 | |
| mriedem | nova meeting in #openstack-meeting in 5 minutes | 20:55 |
| *** ijw has quit IRC | 20:55 | |
| *** ijw has joined #openstack-nova | 20:55 | |
| *** smatzek has joined #openstack-nova | 20:56 | |
| dansmith | mriedem: I'm going to skip the nova meeting today.. feeling crappy and doing a few other things | 20:56 |
| *** thorst has quit IRC | 20:56 | |
| dansmith | mriedem: I think you can fill everyone in on the extensive discussions at the cells meeting, right? | 20:57 |
| mriedem | god i hope so | 20:57 |
| abhi89 | melwitt: I will trying doing what you have told. Thanks for your input.. | 20:58 |
| *** burt has quit IRC | 20:58 | |
| *** Sukhdev has joined #openstack-nova | 20:58 | |
| *** tongli has joined #openstack-nova | 20:59 | |
| *** tbachman_ has joined #openstack-nova | 20:59 | |
| *** ijw has quit IRC | 20:59 | |
| *** ijw has joined #openstack-nova | 21:00 | |
| *** tbachman has quit IRC | 21:00 | |
| *** tbachman_ is now known as tbachman | 21:00 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/460515 | 21:00 |
| *** ijw has quit IRC | 21:00 | |
| openstackgerrit | Steve Noyes proposed openstack/nova master: Add Cinder v3 detach to shutdown_instance https://review.openstack.org/456877 | 21:03 |
| *** jamesdenton has quit IRC | 21:04 | |
| *** crushil has quit IRC | 21:04 | |
| *** timello has quit IRC | 21:06 | |
| *** yangyapeng has joined #openstack-nova | 21:08 | |
| *** edmondsw has quit IRC | 21:14 | |
| *** yangyapeng has quit IRC | 21:15 | |
| *** burt has joined #openstack-nova | 21:19 | |
| *** iceyao has joined #openstack-nova | 21:19 | |
| *** zz_dimtruck is now known as dimtruck | 21:20 | |
| *** thorst has joined #openstack-nova | 21:21 | |
| *** tongli has quit IRC | 21:22 | |
| *** iceyao has quit IRC | 21:24 | |
| *** thorst has quit IRC | 21:25 | |
| *** abhi89 has quit IRC | 21:28 | |
| *** zigo has joined #openstack-nova | 21:32 | |
| *** READ10 has joined #openstack-nova | 21:34 | |
| *** yamahata_ has joined #openstack-nova | 21:37 | |
| *** tbachman_ has joined #openstack-nova | 21:40 | |
| *** hferenc_ has quit IRC | 21:40 | |
| *** tbachman has quit IRC | 21:42 | |
| *** tbachman_ is now known as tbachman | 21:42 | |
| *** iceyao has joined #openstack-nova | 21:47 | |
| *** salv-orl_ has joined #openstack-nova | 21:50 | |
| *** Nakato has quit IRC | 21:52 | |
| *** iceyao has quit IRC | 21:52 | |
| *** salv-orlando has quit IRC | 21:52 | |
| *** Nakato has joined #openstack-nova | 21:53 | |
| *** ijw has joined #openstack-nova | 21:56 | |
| mriedem | hferenc: gibi: blasted the ML :) | 21:56 |
| *** ijw has quit IRC | 21:56 | |
| *** ijw has joined #openstack-nova | 21:56 | |
| *** dfisher has quit IRC | 21:59 | |
| *** catintheroof has quit IRC | 22:00 | |
| *** annegentle has quit IRC | 22:00 | |
| *** jose-phillips has joined #openstack-nova | 22:01 | |
| *** salv-orl_ has quit IRC | 22:01 | |
| *** annegentle has joined #openstack-nova | 22:01 | |
| *** Apoorva_ has joined #openstack-nova | 22:01 | |
| *** smatzek has quit IRC | 22:01 | |
| *** Apoorva has quit IRC | 22:04 | |
| *** Sukhdev_ has joined #openstack-nova | 22:05 | |
| *** annegentle has quit IRC | 22:06 | |
| *** lyan has quit IRC | 22:07 | |
| *** mdrabe has quit IRC | 22:10 | |
| *** adrian_otto has quit IRC | 22:11 | |
| *** yangyapeng has joined #openstack-nova | 22:12 | |
| *** ijw has quit IRC | 22:12 | |
| *** nkorabli has quit IRC | 22:12 | |
| *** rloo has joined #openstack-nova | 22:12 | |
| *** cburgess has quit IRC | 22:12 | |
| *** rloo has left #openstack-nova | 22:12 | |
| *** nkorabli has joined #openstack-nova | 22:12 | |
| *** ijw has joined #openstack-nova | 22:13 | |
| *** erlon has quit IRC | 22:13 | |
| *** abramley has quit IRC | 22:13 | |
| *** ianw has quit IRC | 22:13 | |
| *** raj_sing- has joined #openstack-nova | 22:14 | |
| *** rnoriega has quit IRC | 22:14 | |
| *** test222 has quit IRC | 22:14 | |
| *** harlowja has quit IRC | 22:14 | |
| *** raj_singh has quit IRC | 22:14 | |
| *** rha has quit IRC | 22:15 | |
| *** ijw has quit IRC | 22:15 | |
| *** ijw has joined #openstack-nova | 22:15 | |
| *** rnoriega has joined #openstack-nova | 22:15 | |
| *** mnaser has quit IRC | 22:16 | |
| *** cburgess has joined #openstack-nova | 22:16 | |
| *** nikhil has quit IRC | 22:17 | |
| *** rushiagr has quit IRC | 22:17 | |
| *** xgerman has quit IRC | 22:17 | |
| *** tdurakov has quit IRC | 22:17 | |
| *** tlbr has quit IRC | 22:17 | |
| *** yangyapeng has quit IRC | 22:17 | |
| *** nkorabli has quit IRC | 22:17 | |
| *** ianw has joined #openstack-nova | 22:18 | |
| *** izaakk has quit IRC | 22:18 | |
| *** purplerbot has quit IRC | 22:19 | |
| *** rha has joined #openstack-nova | 22:19 | |
| *** tlbr has joined #openstack-nova | 22:20 | |
| *** Dave___ has joined #openstack-nova | 22:20 | |
| *** heyongli has quit IRC | 22:20 | |
| *** izaakk has joined #openstack-nova | 22:21 | |
| *** heyongli has joined #openstack-nova | 22:21 | |
| *** Dave has quit IRC | 22:22 | |
| *** nikhil has joined #openstack-nova | 22:26 | |
| *** baoli has quit IRC | 22:26 | |
| *** mnaser has joined #openstack-nova | 22:26 | |
| *** tdurakov has joined #openstack-nova | 22:27 | |
| *** ijw has quit IRC | 22:27 | |
| *** awaugama has quit IRC | 22:27 | |
| *** ijw has joined #openstack-nova | 22:28 | |
| *** felipemonteiro_ has quit IRC | 22:28 | |
| *** adrian_otto has joined #openstack-nova | 22:31 | |
| *** rushiagr has joined #openstack-nova | 22:32 | |
| *** iceyao has joined #openstack-nova | 22:32 | |
| *** ijw has quit IRC | 22:32 | |
| *** ijw has joined #openstack-nova | 22:33 | |
| *** abramley has joined #openstack-nova | 22:36 | |
| *** ijw has quit IRC | 22:36 | |
| *** iceyao has quit IRC | 22:37 | |
| *** edmondsw has joined #openstack-nova | 22:37 | |
| *** salv-orlando has joined #openstack-nova | 22:37 | |
| *** kaisers has joined #openstack-nova | 22:38 | |
| *** ijw has joined #openstack-nova | 22:39 | |
| *** ijw has quit IRC | 22:39 | |
| *** ijw has joined #openstack-nova | 22:39 | |
| *** edmondsw has quit IRC | 22:42 | |
| *** kaisers has quit IRC | 22:42 | |
| mriedem | mtreinish: some easy stuff to fix up in https://review.openstack.org/#/c/459460 | 22:43 |
| *** liverpooler has joined #openstack-nova | 22:44 | |
| *** hamzy has quit IRC | 22:59 | |
| *** dimtruck is now known as zz_dimtruck | 23:00 | |
| *** zz_dimtruck is now known as dimtruck | 23:04 | |
| *** Sukhdev has quit IRC | 23:06 | |
| *** slaweq has quit IRC | 23:06 | |
| *** slaweq has joined #openstack-nova | 23:07 | |
| *** lyan has joined #openstack-nova | 23:08 | |
| *** salv-orlando has quit IRC | 23:08 | |
| *** sdague has quit IRC | 23:08 | |
| *** adrian_otto has quit IRC | 23:08 | |
| *** slaweq has quit IRC | 23:11 | |
| *** Kevin_Zheng has joined #openstack-nova | 23:13 | |
| Kevin_Zheng | mriedem: hi, for https://review.openstack.org/#/c/459569 , the assertion fails now, I think it is not what we expected? | 23:15 |
| mtreinish | mriedem: so on the pokicy bits, I tried to delete them before but a bunch of testing started complaining there was no policy for the endpoint | 23:16 |
| mtreinish | s/pokicy/policy/ | 23:17 |
| *** tesseract has quit IRC | 23:20 | |
| *** ijw has quit IRC | 23:21 | |
| *** ijw has joined #openstack-nova | 23:22 | |
| *** dimtruck is now known as zz_dimtruck | 23:22 | |
| openstackgerrit | Matthew Treinish proposed openstack/nova master: Remove nova-cert https://review.openstack.org/459460 | 23:23 |
| mtreinish | mriedem: ^^^ | 23:23 |
| *** harlowja has joined #openstack-nova | 23:23 | |
| *** ijw has quit IRC | 23:26 | |
| *** chyka has quit IRC | 23:26 | |
| *** chyka has joined #openstack-nova | 23:27 | |
| *** liusheng has quit IRC | 23:27 | |
| *** liusheng has joined #openstack-nova | 23:27 | |
| *** hongbin has quit IRC | 23:29 | |
| *** mriedem has quit IRC | 23:30 | |
| *** mriedem has joined #openstack-nova | 23:30 | |
| mriedem | mtreinish: probably some policy test to see that all apis have policy registered, | 23:31 |
| mriedem | but i'd think we could remove that for os-certificates as we don't actually use the policy | 23:32 |
| *** liusheng has quit IRC | 23:32 | |
| *** liusheng has joined #openstack-nova | 23:32 | |
| mriedem | Kevin_Zheng: you mean this right? http://logs.openstack.org/69/459569/6/check/gate-nova-python27-ubuntu-xenial/3f13311/console.html#_2017-04-27_07_11_57_717635 | 23:33 |
| *** chyka has quit IRC | 23:33 | |
| *** chyka has joined #openstack-nova | 23:34 | |
| mriedem | Kevin_Zheng: maybe rather than assert equality, which might not be implemented for ObjectListBase.__eq__, assert the length is the same, is 1, and the single tag between both is the same | 23:35 |
| Kevin_Zheng | yeah | 23:35 |
| mtreinish | mriedem: ok, I'll look at that tomorrow, or later tonight | 23:35 |
| Kevin_Zheng | mriedem: ok, got it | 23:35 |
| mriedem | Kevin_Zheng: yeah it doesn't implement __eq__ https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L778 | 23:36 |
| mriedem | mtreinish: you must be getting soft in your old age | 23:36 |
| *** yangyapeng has joined #openstack-nova | 23:37 | |
| *** slaweq has joined #openstack-nova | 23:38 | |
| mtreinish | mriedem: heh, that must be it | 23:38 |
| *** chyka has quit IRC | 23:38 | |
| *** Apoorva_ has quit IRC | 23:38 | |
| *** Apoorva has joined #openstack-nova | 23:39 | |
| *** markvoelker has quit IRC | 23:40 | |
| *** yangyapeng has quit IRC | 23:42 | |
| *** slaweq has quit IRC | 23:42 | |
| *** mlavalle has quit IRC | 23:42 | |
| openstackgerrit | Chris Friesen proposed openstack/python-novaclient master: 2.46: Show flavor info in server details https://review.openstack.org/435141 | 23:43 |
| cfriesen | mriedem: what's the story on needing functional tests for this ^ ? I noticed that the last couple of changes you made in novaclient had no function tests. | 23:43 |
| mriedem | cfriesen: do as i say, not as i do | 23:45 |
| mriedem | cfriesen: we'll likely want functional tests for those since it's a new microversion that changes the output | 23:46 |
| mriedem | cfriesen: 2.43 and 2.44 were just deprecations, so i think unit tests were sufficient | 23:46 |
| mriedem | and 2.45 wasn't changing output really, it was handling the response differently | 23:46 |
| mriedem | when you have to mess with the fixture stuff too much it gets weird https://review.openstack.org/#/c/435141/5/novaclient/tests/unit/fixture_data/servers.py | 23:47 |
| mriedem | cfriesen: but it looks like you did a lot of work with the fixture stuff already, and i'm probably not going to dig through all of that code tonight | 23:49 |
| mriedem | i've got a mother in law en route | 23:49 |
| *** thorst has joined #openstack-nova | 23:54 | |
| cfriesen | mriedem: kay, I'll give it a shot | 23:54 |
| *** ijw has joined #openstack-nova | 23:56 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Make discover_hosts only query for unmapped ComputeNode records https://review.openstack.org/427903 | 23:56 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add ability to query for ComputeNodes by their mapped value https://review.openstack.org/427902 | 23:56 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add ComputeNode.mapped field https://review.openstack.org/427901 | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!