Tuesday, 2017-05-16

*** mriedem has quit IRC00:05
*** huanxie has quit IRC00:08
*** hoonetorg has joined #openstack-nova00:08
*** oanson has quit IRC00:10
*** oanson has joined #openstack-nova00:10
*** thorst_afk has joined #openstack-nova00:10
*** annegentle has quit IRC00:15
*** liverpooler has quit IRC00:16
*** ijw has quit IRC00:17
*** suresh12 has joined #openstack-nova00:17
*** ijw has joined #openstack-nova00:19
*** gjayavelu has quit IRC00:20
*** gyee has quit IRC00:22
*** ijw has quit IRC00:25
*** gomarivera has quit IRC00:25
*** marst has joined #openstack-nova00:27
*** slaweq has joined #openstack-nova00:28
*** kaisers has quit IRC00:30
*** mdrabe has quit IRC00:31
openstackgerritTakashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2)  https://review.openstack.org/40895500:33
openstackgerritTakashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2)  https://review.openstack.org/40896400:33
*** slaweq has quit IRC00:33
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2)  https://review.openstack.org/43060800:34
*** huanxie has joined #openstack-nova00:34
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2)  https://review.openstack.org/45948300:34
*** ijw has joined #openstack-nova00:37
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Microversion 2.46 - List/Show all server migration types  https://review.openstack.org/43083900:39
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Microversion 2.46 - Enable cold migration with target host  https://review.openstack.org/40670700:40
openstackgerritTakashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host  https://review.openstack.org/41492600:41
*** annegentle has joined #openstack-nova00:41
openstackgerritTakashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action  https://review.openstack.org/41004200:41
openstackgerritTakashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action  https://review.openstack.org/41004200:41
*** annegentle has quit IRC00:41
*** suresh12 has quit IRC00:42
*** ijw has quit IRC00:42
*** suresh12 has joined #openstack-nova00:42
*** Apoorva_ has joined #openstack-nova00:43
*** dikonoor has joined #openstack-nova00:45
*** Apoorva has quit IRC00:45
*** Sukhdev_ has quit IRC00:46
*** Apoorva_ has quit IRC00:47
*** nic has quit IRC00:47
*** sdague has quit IRC00:49
*** harlowja has joined #openstack-nova00:49
*** liverpooler has joined #openstack-nova00:52
*** chyka has joined #openstack-nova00:53
*** dixiaoli has joined #openstack-nova00:54
*** dixiaoli has quit IRC00:55
*** dixiaoli has joined #openstack-nova00:55
*** Shunli has joined #openstack-nova00:56
*** chyka has quit IRC00:59
*** ijw has joined #openstack-nova01:01
*** jmlowe has joined #openstack-nova01:02
*** zzzeek has quit IRC01:03
*** Swami has quit IRC01:04
*** zzzeek has joined #openstack-nova01:05
*** mdbooth has quit IRC01:06
*** ansiwen has quit IRC01:06
*** gongysh has joined #openstack-nova01:07
*** ansiwen has joined #openstack-nova01:07
*** mdbooth has joined #openstack-nova01:07
*** zsli_ has joined #openstack-nova01:08
*** kevinz has joined #openstack-nova01:09
*** Shunli has quit IRC01:11
*** gianpietro has quit IRC01:15
*** masuberu has joined #openstack-nova01:17
*** kaisers has joined #openstack-nova01:17
*** thorst_afk has quit IRC01:19
*** cNilesh has joined #openstack-nova01:19
*** suresh12 has quit IRC01:27
*** thorst_afk has joined #openstack-nova01:28
*** zsli__ has joined #openstack-nova01:29
*** ijw has quit IRC01:31
*** hongbin has joined #openstack-nova01:32
*** zsli_ has quit IRC01:33
*** thorst_afk has quit IRC01:35
*** esberglu has quit IRC01:38
*** harlowja has quit IRC01:42
*** fragatina has quit IRC01:44
*** gianpietro has joined #openstack-nova01:47
*** Shunli has joined #openstack-nova01:50
*** zsli__ has quit IRC01:50
*** gianpietro has quit IRC01:52
*** harlowja has joined #openstack-nova01:56
*** coreywright has quit IRC01:59
*** thorst_afk has joined #openstack-nova02:03
*** thorst_afk has quit IRC02:04
*** slaweq has joined #openstack-nova02:06
*** slaweq has quit IRC02:10
*** Daisy has joined #openstack-nova02:13
*** coreywright has joined #openstack-nova02:16
*** harlowja has quit IRC02:20
*** suresh12 has joined #openstack-nova02:29
*** esberglu has joined #openstack-nova02:31
*** suresh12 has quit IRC02:33
*** liverpooler has quit IRC02:34
*** esberglu has quit IRC02:35
*** gomarivera has joined #openstack-nova02:37
*** yamahata has quit IRC02:38
*** gongysh has quit IRC02:39
openstackgerritZhaokun Fu proposed openstack/nova-specs master: fix typos  https://review.openstack.org/46490602:41
*** gomarivera has quit IRC02:42
*** yingjun has joined #openstack-nova02:43
*** itlinux has joined #openstack-nova02:49
*** gouthamr has joined #openstack-nova02:50
*** rfolco has quit IRC02:51
*** abhishekk has joined #openstack-nova02:55
*** krtaylor has joined #openstack-nova02:56
*** abhishekk has left #openstack-nova02:57
*** Daisy has quit IRC03:02
*** Daisy has joined #openstack-nova03:03
*** kevinz has quit IRC03:04
*** thorst_afk has joined #openstack-nova03:04
*** zsli_ has joined #openstack-nova03:17
*** itlinux has quit IRC03:18
*** Shunli has quit IRC03:18
*** Daisy_ has joined #openstack-nova03:19
*** tjones has joined #openstack-nova03:20
openstackgerritjichenjc proposed openstack/nova-specs master: WIP: add z/VM Driver  https://review.openstack.org/46491503:21
*** itlinux has joined #openstack-nova03:22
*** Daisy has quit IRC03:22
*** abhishek has joined #openstack-nova03:23
*** thorst_afk has quit IRC03:25
*** kaisers has quit IRC03:28
*** zsli_ has quit IRC03:29
*** dikonoor has quit IRC03:30
*** links has joined #openstack-nova03:30
*** Shunli has joined #openstack-nova03:33
openstackgerritjichenjc proposed openstack/nova-specs master: WIP: add z/VM Driver  https://review.openstack.org/46491503:33
*** Shunli has quit IRC03:34
*** nicolasbock has quit IRC03:35
*** Shunli has joined #openstack-nova03:35
*** gianpietro has joined #openstack-nova03:35
*** gianpietro has quit IRC03:35
*** Sukhdev has joined #openstack-nova03:38
*** salv-orlando has joined #openstack-nova03:38
*** Shunli has quit IRC03:42
*** Shunli has joined #openstack-nova03:43
*** slaweq has joined #openstack-nova03:46
*** Daisy_ has quit IRC03:50
*** slaweq has quit IRC03:56
*** Daisy has joined #openstack-nova03:57
*** Daisy has quit IRC03:57
*** Daisy has joined #openstack-nova03:58
*** suresh12 has joined #openstack-nova04:02
*** Shunli has quit IRC04:02
*** Daisy has quit IRC04:02
*** Daisy has joined #openstack-nova04:04
*** ijw has joined #openstack-nova04:04
*** gouthamr has quit IRC04:05
*** Daisy has quit IRC04:08
*** Daisy has joined #openstack-nova04:10
*** hongbin has quit IRC04:12
*** Daisy has quit IRC04:14
*** dikonoor has joined #openstack-nova04:16
*** crushil has quit IRC04:17
*** mdnadeem has joined #openstack-nova04:18
*** ratailor has joined #openstack-nova04:19
*** faizy_ has joined #openstack-nova04:22
*** faizy has quit IRC04:26
*** kaisers has joined #openstack-nova04:26
*** suresh12 has quit IRC04:34
*** fragatina has joined #openstack-nova04:41
*** huanxie has quit IRC04:41
*** huanxie has joined #openstack-nova04:43
*** fragatina has quit IRC04:45
*** Daisy has joined #openstack-nova04:46
*** ayogi has joined #openstack-nova04:46
*** Daisy has quit IRC04:47
*** adisky_ has joined #openstack-nova04:47
*** Daisy has joined #openstack-nova04:47
*** strigazi_ has joined #openstack-nova04:51
*** Daisy has quit IRC04:52
*** Sukhdev has quit IRC04:53
*** strigazi has quit IRC04:54
*** armax has quit IRC04:56
*** strigazi has joined #openstack-nova04:56
*** prateek has joined #openstack-nova04:58
*** strigazi_ has quit IRC04:58
*** larainema has joined #openstack-nova04:58
*** huanxie has quit IRC05:04
*** suresh12 has joined #openstack-nova05:05
*** Daisy has joined #openstack-nova05:05
*** Daisy has quit IRC05:06
*** Daisy has joined #openstack-nova05:07
*** Daisy has quit IRC05:10
*** Daisy has joined #openstack-nova05:10
*** jamielennox is now known as jamielennox|away05:10
*** esberglu has joined #openstack-nova05:15
*** kaisers has quit IRC05:15
*** bnemec has quit IRC05:16
*** ijw has quit IRC05:17
*** slaweq has joined #openstack-nova05:18
*** esberglu has quit IRC05:19
*** sree has joined #openstack-nova05:19
*** slaweq has quit IRC05:20
*** slaweq has joined #openstack-nova05:20
*** yolkfull has joined #openstack-nova05:21
*** thorst_afk has joined #openstack-nova05:22
*** kaisers has joined #openstack-nova05:25
*** strigazi_ has joined #openstack-nova05:25
*** thorst_afk has quit IRC05:26
*** strigazi has quit IRC05:27
*** slaweq has quit IRC05:28
openstackgerritTakashi NATSUME proposed openstack/nova master: api-ref: Example verification for servers-actions.inc  https://review.openstack.org/45456505:28
*** slaweq has joined #openstack-nova05:28
*** abhishek has quit IRC05:29
*** jamielennox|away is now known as jamielennox05:30
*** strigazi has joined #openstack-nova05:30
*** strigazi_ has quit IRC05:32
*** links has quit IRC05:33
*** suresh12 has quit IRC05:33
*** slaweq has quit IRC05:33
*** csuttles has joined #openstack-nova05:38
*** links has joined #openstack-nova05:41
*** Shunli has joined #openstack-nova05:43
*** harlowja has joined #openstack-nova05:47
*** Daisy has quit IRC05:48
*** Daisy has joined #openstack-nova05:49
*** Daisy has joined #openstack-nova05:49
*** Daisy has quit IRC05:53
*** Daisy has joined #openstack-nova05:54
*** itlinux has quit IRC05:56
*** Daisy has quit IRC05:58
*** ijw has joined #openstack-nova06:00
*** itlinux has joined #openstack-nova06:01
*** ecelik has joined #openstack-nova06:01
*** ecelik has left #openstack-nova06:02
*** andreas_s has joined #openstack-nova06:05
*** yolkfull has quit IRC06:06
*** yolkfull has joined #openstack-nova06:07
*** tjones has quit IRC06:09
*** itlinux has quit IRC06:12
*** abhi89 has joined #openstack-nova06:13
*** Oku_OS-away is now known as Oku_OS06:15
*** tovin07_ has joined #openstack-nova06:17
*** pcaruana has joined #openstack-nova06:22
*** gongysh has joined #openstack-nova06:27
*** trinaths has joined #openstack-nova06:27
*** kaisers has quit IRC06:30
*** kaisers has joined #openstack-nova06:30
*** ltomasbo|away is now known as ltomasbo06:32
*** rcernin has joined #openstack-nova06:32
*** bhagyashris has joined #openstack-nova06:32
*** zsli_ has joined #openstack-nova06:34
*** gongysh has quit IRC06:35
*** zsli_ has quit IRC06:36
*** Shunli has quit IRC06:37
*** markus_z has joined #openstack-nova06:39
*** Daisy has joined #openstack-nova06:43
*** ralonsoh has joined #openstack-nova06:45
*** harlowja has quit IRC06:50
*** edmondsw has joined #openstack-nova06:53
*** jaosorior has quit IRC06:53
openstackgerritBéla Vancsics proposed openstack/nova master: Transform instance.trigger_crash_dump notification  https://review.openstack.org/39622506:54
*** edmondsw has quit IRC06:57
*** belmoreira has joined #openstack-nova07:00
*** ircuser-1 has joined #openstack-nova07:05
*** jamielennox is now known as jamielennox|away07:07
*** sridharg has joined #openstack-nova07:08
*** avolkov has joined #openstack-nova07:08
*** slaweq has joined #openstack-nova07:10
*** slaweq has quit IRC07:16
*** Daisy has quit IRC07:17
*** jpena|off is now known as jpena07:18
*** Daisy has joined #openstack-nova07:18
*** vks1 has joined #openstack-nova07:21
*** suresh12 has joined #openstack-nova07:34
*** jamielennox|away is now known as jamielennox07:34
*** suresh12 has quit IRC07:38
*** jaosorior has joined #openstack-nova07:43
*** mlakat has joined #openstack-nova07:45
*** aarefiev_afk is now known as aarefiev07:48
*** kaisers2 has quit IRC07:51
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-nova08:00
*** salv-orlando has quit IRC08:00
bauzasp!spy08:03
*** dixiaoli has quit IRC08:04
*** kaisers1 has joined #openstack-nova08:06
*** mlakat has quit IRC08:07
*** Daisy has quit IRC08:07
*** Daisy has joined #openstack-nova08:07
*** faizy_ has quit IRC08:11
*** lucas-afk is now known as lucasagomes08:15
*** gjayavelu has joined #openstack-nova08:16
*** mlakat has joined #openstack-nova08:18
*** mvk has quit IRC08:19
*** jaosorior is now known as jaosorior_lunch08:20
*** derekh has joined #openstack-nova08:22
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Refactor encryptor attach and detach calls  https://review.openstack.org/46024308:23
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Attach and detach encryptors during swap_volume  https://review.openstack.org/46024408:23
lyarwoodmdbooth: ^ if you have any review time today your thoughts on these would be appreciated08:23
*** thorst_afk has joined #openstack-nova08:24
*** dixiaoli has joined #openstack-nova08:28
*** thorst_afk has quit IRC08:29
*** moshele has joined #openstack-nova08:32
*** Daisy has quit IRC08:43
*** Daisy has joined #openstack-nova08:43
*** gszasz has joined #openstack-nova08:45
*** priteau has joined #openstack-nova08:51
*** mvk has joined #openstack-nova08:51
openstackgerritfalseuser proposed openstack/nova master: Clear instance root_device_name in rebuild operation  https://review.openstack.org/46499108:51
*** gjayavelu has quit IRC08:52
*** karimb has joined #openstack-nova08:53
*** Daisy has quit IRC08:57
*** belmoreira has quit IRC09:01
*** Daisy has joined #openstack-nova09:04
*** Daisy has quit IRC09:04
*** Daisy has joined #openstack-nova09:05
*** Daisy has quit IRC09:07
*** Daisy has joined #openstack-nova09:07
*** Daisy has quit IRC09:13
*** Daisy has joined #openstack-nova09:14
*** jaosorior_lunch is now known as jaosorior09:15
*** dixiaoli has quit IRC09:15
*** dixiaoli has joined #openstack-nova09:16
*** ejat has quit IRC09:25
*** thorst_afk has joined #openstack-nova09:25
*** ejat has joined #openstack-nova09:26
*** ejat has quit IRC09:26
*** ejat has joined #openstack-nova09:26
*** Daisy has quit IRC09:30
*** lpetrut has joined #openstack-nova09:36
openstackgerritjichenjc proposed openstack/nova master: Use plain routes list for os-certificates endpoint instead of stevedore  https://review.openstack.org/46081309:37
*** yingjun has quit IRC09:39
*** ratailor has quit IRC09:39
openstackgerritjichenjc proposed openstack/nova master: Add missing rootwrap filter for cryptsetup  https://review.openstack.org/46234809:40
*** thorst_afk has quit IRC09:44
*** priteau has quit IRC09:45
openstackgerritTakashi NATSUME proposed openstack/nova-specs master: Amend the "list-show-all-server-migration-types" spec  https://review.openstack.org/46084709:45
openstackgerritTakashi NATSUME proposed openstack/nova-specs master: Abort Cold Migration  https://review.openstack.org/33473209:47
openstackgerritTakashi NATSUME proposed openstack/nova-specs master: Specify keymap on server boot  https://review.openstack.org/44883009:47
openstackgerritjichenjc proposed openstack/nova master: [placement] Add api-ref for /resource_classes/{name}  https://review.openstack.org/46283709:49
*** yingjun has joined #openstack-nova09:49
*** yingjun has quit IRC09:50
*** tovin07_ has quit IRC09:56
*** sambetts|afk is now known as sambetts09:58
*** takashin has left #openstack-nova10:00
*** nicolasbock has joined #openstack-nova10:03
*** cNilesh has quit IRC10:05
*** sdague has joined #openstack-nova10:05
*** mvk has quit IRC10:06
*** mvk has joined #openstack-nova10:12
*** dixiaoli has quit IRC10:14
*** trungnv has quit IRC10:16
*** trinaths has left #openstack-nova10:31
*** abhi89 has quit IRC10:33
*** abhi89 has joined #openstack-nova10:33
*** suresh12 has joined #openstack-nova10:34
openstackgerritMatthew Booth proposed openstack/nova master: libvirt: Use SubclassSignatureTestCase on all volume drivers  https://review.openstack.org/46502210:36
*** suresh12 has quit IRC10:39
*** thorst_afk has joined #openstack-nova10:41
*** sfinucan has quit IRC10:42
*** sfinucan has joined #openstack-nova10:43
*** thorst_afk has quit IRC10:45
*** peter-hamilton has quit IRC10:53
*** sree has quit IRC10:55
*** cdent has joined #openstack-nova11:06
*** thorst_afk has joined #openstack-nova11:12
*** asettle_ is now known as asettle11:13
*** smatzek has joined #openstack-nova11:20
openstackgerritmelanie witt proposed openstack/nova master: WIP Cache database and message queue connection objects  https://review.openstack.org/46504211:20
*** ratailor has joined #openstack-nova11:20
*** abhi89 has quit IRC11:28
*** belmoreira has joined #openstack-nova11:33
*** jhesketh has quit IRC11:39
*** jhesketh has joined #openstack-nova11:41
*** rfolco has joined #openstack-nova11:48
*** lucasagomes is now known as lucas-hungry11:52
*** gianpietro has joined #openstack-nova11:53
openstackgerritMonty Taylor proposed openstack/nova master: WIP Add description of server addresses objects  https://review.openstack.org/46433111:56
*** gianpietro has quit IRC11:57
*** nicolasbock has quit IRC11:58
*** nicolasbock has joined #openstack-nova11:58
*** derekh has quit IRC11:59
*** eliqiao has joined #openstack-nova12:00
*** moshele has quit IRC12:01
*** vancsics has joined #openstack-nova12:01
*** yingjun has joined #openstack-nova12:03
*** thorst_afk is now known as thorst12:05
*** liverpooler has joined #openstack-nova12:06
*** abhi89 has joined #openstack-nova12:16
alex_xugmann: thanks!12:18
*** awaugama has joined #openstack-nova12:21
*** dave-mccowan has joined #openstack-nova12:21
*** gcb has joined #openstack-nova12:25
*** Daisy has joined #openstack-nova12:26
*** eliqiao has quit IRC12:27
*** eliqiao has joined #openstack-nova12:28
*** Daisy has quit IRC12:30
*** pchavva has joined #openstack-nova12:30
*** eliqiao has quit IRC12:30
*** sree has joined #openstack-nova12:30
*** gcb_ has joined #openstack-nova12:32
*** jpena is now known as jpena|lunch12:32
*** gcb has quit IRC12:34
*** eliqiao has joined #openstack-nova12:34
*** moshele has joined #openstack-nova12:34
*** edmondsw has joined #openstack-nova12:35
*** sree_ has joined #openstack-nova12:36
*** sree_ is now known as Guest877412:37
*** sree has quit IRC12:38
*** kylek3h has joined #openstack-nova12:42
*** eliqiao has quit IRC12:45
*** eliqiao has joined #openstack-nova12:47
*** eliqiao has quit IRC12:47
*** vks1 has quit IRC12:48
*** eliqiao has joined #openstack-nova12:48
*** salv-orlando has joined #openstack-nova12:49
*** morgan_ is now known as morgan12:49
*** esberglu has joined #openstack-nova12:50
*** lucas-hungry is now known as lucasagomes12:54
*** artom_ has joined #openstack-nova12:54
*** artom_ has quit IRC12:55
*** artom_ has joined #openstack-nova12:55
*** artom has quit IRC12:57
*** lyan has joined #openstack-nova12:58
*** andreas_s has quit IRC13:04
*** edmondsw_ has joined #openstack-nova13:08
*** karthiks has quit IRC13:08
*** mdrabe has joined #openstack-nova13:09
*** edmondsw has quit IRC13:09
*** edmondsw_ has quit IRC13:09
*** edmondsw has joined #openstack-nova13:09
*** xyang1 has joined #openstack-nova13:10
*** liverpooler has quit IRC13:11
*** sree has joined #openstack-nova13:11
*** liverpooler has joined #openstack-nova13:13
*** Guest8774 has quit IRC13:13
*** baoli has joined #openstack-nova13:16
*** liusheng has quit IRC13:16
*** liusheng has joined #openstack-nova13:17
alex_xusdague: johnthetubaguy are we real going to fix something like change status from 202 to 204? like this bug https://bugs.launchpad.net/nova/+bug/1579876. I'm think whether I should mark it as 'won't fix'13:19
openstackLaunchpad bug 1579876 in OpenStack Compute (nova) "os-resetState should return a 204 rather than a 202" [Low,Triaged]13:19
*** jamesden_ has joined #openstack-nova13:19
sdaguealex_xu: right now it seems really low priority to fix13:19
alex_xusdague: yea, agree that it is super low. and I actually think about we are never going to fix it.13:20
sdagueyeh13:20
sdaguehonestly, Opinion / Wishlist is how I would file the bug13:20
*** changboguo__ has joined #openstack-nova13:21
*** ayogi has quit IRC13:21
*** karthiks has joined #openstack-nova13:21
alex_xusdague: ok, got it13:21
*** gcb_ has quit IRC13:21
*** ratailor has quit IRC13:22
*** salv-orlando has quit IRC13:25
*** pchavva has quit IRC13:27
*** gouthamr has joined #openstack-nova13:29
bauzasdansmith: edleafe: sorry for not yet uploading my series, but I discovered some possible issues that I'm not wanting13:31
dansmith...alright13:32
*** yingjun has quit IRC13:32
*** smatzek has quit IRC13:33
*** yingjun has joined #openstack-nova13:33
*** jpena|lunch is now known as jpena13:39
*** sree_ has joined #openstack-nova13:40
*** sree_ is now known as Guest3655613:41
dansmithsdague: so, setting ulimit so mysql can actually use the number of connections we have configured seems to have made the test pass13:41
dansmithsdague: I'm running again to get another sample13:41
*** sree has quit IRC13:42
*** abhi89 has quit IRC13:42
*** abhi89 has joined #openstack-nova13:43
*** mlavalle has joined #openstack-nova13:43
*** dimtruck is now known as zz_dimtruck13:44
*** pchavva has joined #openstack-nova13:45
bauzasdansmith: for example, now that we will pass N nodes back to the conductor for rescheduling, we still want to only consume the first one in the scheduler13:46
*** shaohe_feng has quit IRC13:47
dansmithokay13:47
*** rcernin has quit IRC13:48
*** rcernin has joined #openstack-nova13:49
*** shaohe_feng has joined #openstack-nova13:51
*** kfarr has joined #openstack-nova13:52
*** vks1 has joined #openstack-nova13:55
*** smatzek has joined #openstack-nova13:57
*** coreywright has quit IRC13:58
*** jaosorior is now known as jaosorior_away14:00
*** Guest36556 is now known as sree14:00
*** zz_dimtruck is now known as dimtruck14:03
*** slaweq has joined #openstack-nova14:09
*** gomarivera_ has joined #openstack-nova14:10
*** bnemec has joined #openstack-nova14:10
*** prateek has quit IRC14:10
*** moshele has quit IRC14:11
*** armax has joined #openstack-nova14:11
*** coreywright has joined #openstack-nova14:11
openstackgerritdane-fichter proposed openstack/nova master: Add trusted certificates to InstanceExtras  https://review.openstack.org/45771114:15
*** slaweq has quit IRC14:15
*** marst has quit IRC14:17
*** cNilesh has joined #openstack-nova14:23
*** marst has joined #openstack-nova14:24
*** marst has quit IRC14:26
*** usertm has joined #openstack-nova14:26
openstackgerritGábor Antal proposed openstack/nova master: Transform instance.resize_prep notification  https://review.openstack.org/46508114:27
*** mriedem has joined #openstack-nova14:28
mriedemo/14:28
*** dixiaoli has joined #openstack-nova14:28
*** dixiaoli has quit IRC14:28
mriedemsomeone want to put this veritas libvirt volume driver through so we can close the blueprint? https://review.openstack.org/#/c/443951/14:29
*** dixiaoli has joined #openstack-nova14:29
*** crushil has joined #openstack-nova14:30
mdboothmriedem: The connection_info munging in there is evil and undocumented, btw14:33
mriedemmdbooth: i realize the connection_info dict from cinder is a vendor-specific wild west14:34
mriedemi flirted with the idea of trying to formalize that into a versioned object in cinder/os-brick years ago, but never had enough energy to really work on that14:34
mdboothRight, but in general we erect a 'wild west fence' around it with os-brick, right?14:34
mriedemmdbooth: the same can be said for port binding details in neutron14:34
*** suresh12 has joined #openstack-nova14:34
*** mdrabe has quit IRC14:35
*** yingjun has quit IRC14:35
* mdbooth looks at the os-brick driver to try to work out what that stuff is for14:35
*** dixiaoli has quit IRC14:36
openstackgerritAlvaro Lopez Garcia proposed openstack/nova master: Ensure that periodic reclaim cleans DB deleted instances  https://review.openstack.org/32325014:36
*** yingjun has joined #openstack-nova14:37
*** cNilesh has quit IRC14:37
*** changboguo__ has quit IRC14:37
*** cNilesh has joined #openstack-nova14:38
*** suresh12 has quit IRC14:39
mriedemmdbooth: i don't think os-brick is really actually involved much here for connection_info,14:39
*** kfarr has quit IRC14:39
lyarwoodmriedem: we did bring that up again with walter during summit btw, agreed we should do it, just need people as with every other bug, feature, focus area within OpenStack atm.14:39
mriedemnova calls os-initialize_connection in the cinder api which calls down to the volume driver and return the dict back to nova14:39
mriedemthe connector dict is created in os-brick and is something else i toyed with formalizing14:40
mriedembut abandoned14:40
mdboothmriedem: What else would the extra info in connection_info be for?14:40
mdboothFor terminate_connection?14:40
lyarwoodmdbooth: it's for libvirt most of the time14:40
lyarwoodmdbooth: source_path etc14:40
mriedemlyarwood: mdbooth: https://review.openstack.org/#/c/269867/14:40
mdboothlyarwood: Right, there's device_path14:41
mdboothThat's become kinda standardised14:41
mriedemthere are definitely some 'standard' things we can usually expect in connection_info,14:41
mriedemand then vendor-specific extras14:41
*** mdrabe has joined #openstack-nova14:41
mdboothlyarwood mriedem: So I'm looking specifically here: https://review.openstack.org/#/c/443951/15/nova/virt/libvirt/volume/vrtshyperscale.py14:41
mriedemsort of like what is being attempted with cleaning up the instance diagnostics stuff in nova14:41
mdboothWe're getting device_info back from os-brick, and stuffing some of it into connection_info14:42
mdboothThat's unusual, and there's no comment explaining why we do it14:42
mdboothTake 'vsa_ip'14:42
mdboothI don't see where that information would be subsequently used. It's not used by os-brick's disconnect_volume for that driver.14:43
mdboothThe only place I can think off the top of my head would be terminate_connection14:43
lyarwoodmdbooth: yeah agreed, unless get_config is going to use it I can't see why would stash it, unless they have plans to use it in the future?14:43
mdboothlyarwood: Does that make more sense to you?14:43
mriedemwe don't pass the connection_info over to terminate_connection14:43
mriedemjust the connector14:44
mdboothmriedem: Ah, not even there, then14:44
*** cNilesh has quit IRC14:44
mdboothI thought we did pass it back to cinder in that case14:44
*** djohnsto is now known as DT14:44
mriedemso yeah good point on stashing stuff in connection_info after calling os-brick, i'm not sure why that's there14:44
*** eharney has joined #openstack-nova14:45
mriedemmdbooth: i dropped my +2 if you want to ask why they are doing that14:45
*** DT is now known as DonT14:45
*** DonT is now known as CrazyDT14:45
*** gomarivera_ has quit IRC14:45
mdboothmriedem: Done. You notice I also wrote your prior patch btw? ;)14:46
mriedemmdbooth: i didn't14:47
*** sree has quit IRC14:47
mriedemsorry i was hoping the irc pings notified you that i wrote a patch14:48
*** sree has joined #openstack-nova14:48
*** hongbin has joined #openstack-nova14:48
mdboothmriedem: NP, it only took a couple of minutes anyway :) Pretty obvious and can't remember why I didn't do it like that originally.14:49
*** gjayavelu has joined #openstack-nova14:49
*** suresh12 has joined #openstack-nova14:52
*** sree has quit IRC14:53
mriedemstill looking for core reviews on this upgrade issue for cells v2 https://review.openstack.org/#/c/464088/14:53
mriedem^ needs to go back through newton14:53
*** gomarivera_ has joined #openstack-nova14:53
*** aarefiev is now known as aarefiev_afk14:53
*** kfarr has joined #openstack-nova14:54
*** links has quit IRC14:58
*** eharney has quit IRC15:00
*** suresh12 has quit IRC15:00
*** CrazyDT has quit IRC15:03
*** djohnsto has joined #openstack-nova15:04
*** tjones has joined #openstack-nova15:04
*** eharney has joined #openstack-nova15:04
*** shewless has joined #openstack-nova15:05
*** djohnsto is now known as CrazyDT15:05
*** CrazyDT is now known as djohnsto15:06
cfriesenkashyap, you on?15:06
*** prateek has joined #openstack-nova15:08
*** yingjun has quit IRC15:08
*** itlinux has joined #openstack-nova15:09
*** vladikr has joined #openstack-nova15:09
sdaguedansmith / melwitt was anything figured out about db connection leaks yesterday?15:10
cfriesenthere's someone on the openstack-dev mailing list asking about whether the cpu-throttle-initial and cpu-throttle-increment options in libvirt auto-converge are stable enough to use....anyone have any thoughts?  The Newton spec said not, but that was a while ago now.15:10
dansmithsdague: earlier this morning I said that raising ulimit to actually allow the number of connections we have configured seems to resolve my problem15:11
sdagueoh, I see it now15:11
dansmithsdague: I'm about finished with a second run to get another sample, which appears to also have worked15:11
*** jdurgin1 has joined #openstack-nova15:11
*** jdurgin1 has quit IRC15:11
mriedemshouldn't ulimit be 64k in deployment now?15:11
sdagueok, cool, because our ulimit is 1024 by default or something15:11
mriedemdeployment == devstack?15:11
dansmithsdague: this bit: https://review.openstack.org/#/c/436094/28/lib/databases/mysql15:12
*** vladikr has quit IRC15:12
*** vladikr has joined #openstack-nova15:12
*** Oku_OS is now known as Oku_OS-away15:13
sdagueok cool15:13
dansmithsdague: so, I dunno whether to just (ask you to allow) that into devstack or what15:14
openstackgerritStephen Finucane proposed openstack/nova master: Use plain routes list for os-services endpoint instead of stevedore  https://review.openstack.org/46081815:14
dansmithsdague: 1024 still seems high, but we do have a bunch of databases, tables, and connections going on...15:14
sdaguedansmith: yeh, if we've got 1024 db connections it feels like ulimit should at least be double that15:15
dansmithokay, I'll split that out and make it 204815:15
sdagueotherwise it's just shooting ourselves in the foot15:15
dansmithright15:15
sdaguedansmith: so... here is what I think we should do15:16
*** vladikr has quit IRC15:16
sdagueadd a new stackrc variable so that's tunable15:16
sdaguedefault to 204815:16
dansmithokay15:16
*** vladikr has joined #openstack-nova15:16
sdaguedo the change early in stack.sh for the system15:16
sdaguethen if people want to play around with other values for constraints, it's easy15:17
dansmithokay15:17
dansmithby early does that mean in stack.sh or in functions somewhere?15:17
*** itlinux has quit IRC15:18
dansmithand by "for the system" you mean in limits.conf?15:18
dansmithand hope that systemd just inherits that properly when we start mysql?15:19
openstackgerritStephen Finucane proposed openstack/nova master: rbd: Remove unnecessary 'encode' calls  https://review.openstack.org/41235615:19
sdaguedansmith: well probably build a function for it, but call it before we start any services in stack.sh directly15:21
sdagueyeh, limits.conf15:21
dansmithokay15:21
sdagueand if set, I'm hoping it inherits through for the world15:21
*** suresh12 has joined #openstack-nova15:22
dansmithyeah, limits.conf is read by pam, so I'm not sure15:22
*** yingjun has joined #openstack-nova15:23
*** dikonoor has quit IRC15:23
dansmithsdague: just tested, doesn't seem to have any effect15:24
dansmithsystem limits on  the service Imean15:24
dansmitheven with a daemon-reload15:24
mdboothhttps://access.redhat.com/solutions/125795315:25
mdboothAlthough I think that's paywalled15:25
dansmithmdbooth: I already set it with systemd and it works15:25
dansmithwe were hoping we could do it generically with limits.conf15:25
mdboothBut yeah, systemd doesn't read limits.conf15:25
dansmithsdague: ^15:25
dansmithsdague: so I'm guessing I just make that stackrc var mysql-specific15:26
dansmithor I can just comment over it that it's only enforced for things that look at it (like mysql)15:27
cfriesendansmith: would something like this be okay, or is there some reason it would be terrible?  http://paste.openstack.org/show/609690/     We're seeing the cache update be somewhat expensive and wondering if we can just batch the cache updates when there are multiple network-changed events in a batch.15:29
*** gianpietro has joined #openstack-nova15:29
*** chyka has joined #openstack-nova15:30
dansmithcfriesen: terrible? you'd never notice cache changes past the first one15:30
*** suresh12 has quit IRC15:31
mdboothcfriesen: Another problem with this kind of cache is that they grow unbounded. Possibly not a practical issue with instance uuids, but still icky.15:31
*** salv-orlando has joined #openstack-nova15:32
*** gianpietro has quit IRC15:34
cfriesendansmith: could we remove all network-changed events for this instance from the "events" list, then call self.network_api.get_instance_nw_info()?15:34
*** LeoZhang has joined #openstack-nova15:34
sfinucanmriedem: Could you look at the 'reserve-numa-with-pci' patches at some point this week or next? https://review.openstack.org/#/q/status:open+project:openstack/nova+topic:bp/reserve-numa-with-pci15:35
*** mdnadeem has quit IRC15:35
mriedemmaybe, artom is in front of you15:35
cfriesendansmith: it seems pointless to call it multiple times if it's going to give us the same answer each time15:35
dansmithcfriesen: eh? the events list is transient.. things get removed from there when processed15:35
sdaguehmmmm15:35
dansmithcfriesen: that's the nature of a cache refresh15:35
sdaguedansmith: well, what's the set with systemd option? Build that unit file?15:36
dansmithcfriesen: maybe I can't see enough of your change.. are you saying you see a single request to refresh an instance multiple times in the same go?15:36
dansmithsdague: yeah15:36
sdaguedansmith: I'm fine fixing it just for the systemd case15:36
*** markus_z has quit IRC15:36
sdaguewe're default there everywhere15:36
dansmithsdague: okay, but it'll only be for mysql15:37
sdagueoh ... let me go look again15:37
cfriesendansmith: we are coming into this code and there are multiple network-changed events for the same instance, so we end up calling self.network_api.get_instance_nw_info() multiple times15:37
dansmithcfriesen: ah, okay I assumed this was in the periodic15:37
dansmithcfriesen: why is that happening?15:37
*** prateek has quit IRC15:38
*** dpawlik is now known as _danpawlik15:38
*** dimtruck is now known as zz_dimtruck15:39
*** prateek has joined #openstack-nova15:39
*** _danpawlik is now known as danpawlik_absent15:39
cfriesendansmith: let me get more context, this was proposed by one of our other guys.15:39
dansmith*facepalm*15:39
sdaguedansmith: what about DefaultLimitNOFILE= in /etc/systemd/system.conf15:39
sdaguethen a daemon restart15:39
dansmithsdague: will that get picked up by a daemon restart?15:40
dansmithI mean reload15:40
dansmithrestart is a full re-exec right?15:40
bauzasdansmith: quick question, should you think we would need a new RPC version for adding a "alternatives" key to the returned dict when calling the scheduler API method select_destinations() ?15:40
sdaguedansmith: I don't know15:40
sdaguebut that's where the google's are leading me to15:40
*** lpetrut has quit IRC15:40
dansmithsdague: okay will try that15:40
bauzasdansmith: my own opinion is that given we say to first upgrading the conductor, then the conductor is anyway newer that the scheduler, so it would know the new key15:41
sdaguedansmith: daemon-reload probably should be tried first15:41
dansmithsdague: yeah15:41
openstackgerritdane-fichter proposed openstack/nova master: Add trusted certificates to InstanceExtras  https://review.openstack.org/45771115:41
dansmithbauzas: of course, if you're changing the rpc api... you should version that change :)15:41
bauzasdansmith: but I could just add a new RPC API version for not returning the new key in case the asked version is not cool15:41
bauzasdansmith: I'm not modifying the interface15:42
bauzasdansmith: so it's not needing a version15:42
bauzasdansmith: I'm just adding some new key for what we return15:42
bauzasbut lemme just upload the change15:42
bauzasand you'll see15:43
dansmithchanging the return is changing the api, period.15:43
bauzasokay15:44
*** hamzy has quit IRC15:47
*** prateek has quit IRC15:49
*** LeoZhang has quit IRC15:50
cfriesendansmith: with regards to the multiple network-changed events for the same instance, this is in the context of a live-migration on a busy system.  Adding to the pain is that the "with lockutils.lock" took a long time to be acquired (which seems to be due to the lack of a "fair" lock in oslo).15:50
*** prateek has joined #openstack-nova15:51
*** gszasz has quit IRC15:52
dansmithcfriesen: not sure I get it, but if that is just avoiding processing the same instance in a single go, then I guess it makes sense15:54
dansmith(but should use a set() of course)15:54
*** sree has joined #openstack-nova15:57
*** sridharg has quit IRC15:57
*** suresh12 has joined #openstack-nova15:59
*** sree has quit IRC16:01
*** prateek has quit IRC16:02
cfriesendansmith: yes, it's just to try to process each instance once. I guess neutron must be batching multiple events in a single call.16:02
dansmithI'm pretty sure they don't16:02
cfriesendansmith: then why is the code written to handle multiple events per call?16:03
dansmithtbh, I think I'd want an analysis of that first.. like "neutron started batching things in commit <foo> therefore we need this"16:03
dansmithotherwise I'd be highly suspect that something else is going on16:03
dansmithcfriesen: because the whole thing was written to be high bandwidth, but AFAIK, they never used it that way16:04
*** suresh12 has quit IRC16:04
dansmithand multiple events of the same instance in a single batch hardly makes sense16:04
dansmithif they're doing that, then there needs to be a fix on both sides, but if you just paper over it here, we'll never find that16:04
*** Apoorva has joined #openstack-nova16:05
melwittdansmith, sdague: I did some tests where I ran a subset of tempest locally with concurrency of 4 with and without caching oslo.db transaction context managers and with, it topped out around 90 Threads_connected in mysql and without it was around 140. so it did seem to make a difference. this is the patch I tried https://review.openstack.org/#/c/46504216:08
openstackgerritGage Hugo proposed openstack/nova master: Admin API Policy contingent on is_admin_project  https://review.openstack.org/38414816:09
sdaguemelwitt: ok, cool, so that's definitely helpful16:10
dansmithsdague: melwitt: I'm not sure I'm surprised by that, up to the limit of the connection pool16:10
sdaguemelwitt: it feels like we should do that in addition to the raise of the open fds, right?16:11
dansmiththe question would be if that continues to grow forever16:11
melwittthe subset I ran was like 'ostestr run --regex tempest.api.compute.servers --concurrency 4' which is about 206 tests16:11
dansmithsdague: melwitt: we also need to keep in mind that we need to be able to flush this cache on SIGHUP if/when we implement that for the list-of-cells cache, else we'll never notice a connection change16:11
*** nic has joined #openstack-nova16:11
*** sdatko has joined #openstack-nova16:12
cfriesendansmith: I think on the neutron side they're using BatchNotifier, calling send_events() (https://git.openstack.org/cgit/openstack/neutron/tree/neutron/notifiers/nova.py#n242) which just blindly fires the events over to nova.16:14
*** yamahata has joined #openstack-nova16:14
*** sileht has quit IRC16:14
dansmithcfriesen: sure, but what does that have to do with anything?16:15
openstackgerritBalazs Gibizer proposed openstack/nova master: use context mgr in instance.delete  https://review.openstack.org/44376416:15
cfriesendansmith: neutron has multiple network changes over live migration, queues up multiple events for the same instance, and fires them off in a single API call to nova16:15
cfriesendansmith: nova then updates the cache multiple times for the same instance16:15
dansmithcfriesen: it has multiple plug events, but it should not send multiple refresh-cache events16:16
cfriesendansmith: it's just a "network-changed" event16:16
dansmithyeah, that16:17
*** kfarr has quit IRC16:18
melwittdansmith: okay, just looked through the code and I see what you mean. so that one does a load-all-cells once, so it would need to be flushed itself if a new cell is added, right?16:19
cfriesendansmith: looks like it might send a network-changed event each time a port is updated or a floating ip is updated.16:19
dansmithcfriesen: ...right16:19
cfriesendansmith: so if you've got 16 ports on an instance...16:20
*** sileht has joined #openstack-nova16:20
dansmithmelwitt: we've built multiple lists of cells that will have to be flushed, and this is another, is my only point16:20
melwittack16:21
dansmithcfriesen: I understand, but that still doesn't mean that neutron should send a single request with 16 identical events for the same instance16:21
*** slaweq has joined #openstack-nova16:21
*** yingjun has quit IRC16:21
cfriesendansmith: oh, I agree.  was just trying to show how we could end up in this scenario since earlier you said you were pretty sure neutron didn't do that.16:23
*** zz_dimtruck is now known as dimtruck16:23
*** mlavalle has quit IRC16:23
dansmithcfriesen: I meant for multiple instances16:24
*** mlakat has quit IRC16:25
cfriesendansmith: with the neutron BatchNotifier code I think neutron just sends all queued notifications every couple seconds16:25
cfriesendansmith: so I think it could include events for multiple instances16:26
*** djohnsto has quit IRC16:26
*** slaweq has quit IRC16:26
dansmithcfriesen: that would be a change from how it originally behaved, and would delay instance booting unnecessarily16:27
dansmithI don't see any timing in that code16:27
cfriesenlook at neutron/notifiers/batch_notifier.py16:27
*** ralonsoh has quit IRC16:28
*** salv-orlando has quit IRC16:28
dansmithyeah, that's unfortunate16:28
*** jwcroppe has quit IRC16:29
cfriesenwe'll try pushing a neutron change to remove duplicate network-changed events for the same instance from the batch16:30
*** belmoreira has quit IRC16:30
*** gomarivera_ has quit IRC16:30
dansmithin your nova dupe check, you should log a warning or something so we can see if this ever regresses once you fix the sending side16:31
cfriesenwas just going to ask if we wanted a nova dupe check as well16:31
*** abhi89 has quit IRC16:31
*** salv-orlando has joined #openstack-nova16:37
*** jwcroppe has joined #openstack-nova16:37
*** vks1 has quit IRC16:38
*** lucasagomes is now known as lucas-hungry16:39
*** lucas-hungry is now known as lucas-afk16:39
sean-k-mooneysfinucan: https://bugs.launchpad.net/nova/+bug/1691178 this is the bug for the qemu cpu affinity  ill upload the patch WIP patch in a few minutes but if you have in put on the scheduler question feel free to advise.16:41
openstackLaunchpad bug 1691178 in OpenStack Compute (nova) "virt_type=qemu does not support cpu affinity." [Undecided,New] - Assigned to sean mooney (sean-k-mooney)16:41
* sfinucan looking16:42
*** salv-orlando has quit IRC16:42
sean-k-mooneysfinucan: there isnt much in the bug but i will add you to the review of the code change when i split it out of my other changes.16:43
*** abhi89 has joined #openstack-nova16:43
*** ltomasbo is now known as ltomasbo|away16:45
cfriesensean-k-mooney: would we maybe want to make this configurable?  otherwise you're going to need nested kvm to test any of the "dedicated" cpu policy stuff16:47
cfriesen(or real hardware)16:47
*** salv-orlando has joined #openstack-nova16:47
*** ijw has quit IRC16:48
sean-k-mooneycfriesen: i was going to make it condtional based on the config value of virt_type16:48
*** gianpietro has joined #openstack-nova16:48
sean-k-mooneycfriesen: cpu pinning is currently only tested in intels nfv ci16:49
sean-k-mooneycfriesen: i basically looks like this https://pastebin.com/afp0M4Rm16:50
sean-k-mooneyim currently rebasing to master16:50
sean-k-mooneycfriesen: sfinucan  basically just adding if(CONF.libvirt.virt_type != "qemu"): in 2 places in the libvirt dirver and then i need to check unit tests and update if needed16:51
*** ociuhandu has joined #openstack-nova16:51
*** burt has joined #openstack-nova16:52
*** rfolco has quit IRC16:52
dansmithmelwitt: your comment about stale objects is about conf change? or are you worried that seldom-used ones will actually become stale in some un-usable way?16:53
*** pcaruana has quit IRC16:53
*** rcernin has quit IRC16:53
sean-k-mooneycfriesen: sfinucan  that change should be in /nova/virt/libvirt/driver.py not /nova/virt/libvirt/config.py ... this is why i never edit diffs/patches16:54
efriedI just discovered this (apologies if everyone else knew it already): Add `-a` to journalctl and you get COLORS!16:55
*** abhi89 has quit IRC16:55
*** abalutoiu has joined #openstack-nova16:55
melwittdansmith: I was thinking more of the latter, though I can't imagine it being much of a problem in practice. it would be things like, removing cells from the fleet or if a cell went temporarily offline16:56
dansmithhmm16:56
melwittconf change is important but I wasn't thinking of that yet16:56
cfriesensean-k-mooney: I know at least some of our devs are testing with virtualbox which doesn't do nested KVM.  You'd basically require nested KVM or real hardware to exercise the cpu pinning logic.   I think a "permissive_qemu_affinity" config option might make sense, though I know we're trying to get rid of config options in general.16:56
*** fragatina has joined #openstack-nova16:56
dansmithwe don't have to do something if we restart the db today, right?16:56
dansmithit reconnects for us I think, so I'm not sure we need to actually worry about things going stale16:56
dansmithand by conf change, I mean changing a cell record or something16:57
melwittI don't think so, no. good point16:57
melwittyeah, understood. like changing a connection string16:57
sean-k-mooneycfriesen: you dont need nested virt you just need the kvm module loaded in the vm16:57
*** lpetrut has joined #openstack-nova16:57
dansmithright16:57
*** baoli has quit IRC16:57
cfriesensean-k-mooney: the kvm module won't load without nested KVM16:57
sean-k-mooneyif they are using virt_type=qemu they cannont use any form of cpu pinning becasue TSG does not support it16:58
*** felipemonteiro has joined #openstack-nova16:58
*** baoli has joined #openstack-nova16:58
cfriesensean-k-mooney: it accepts the commands, it just doesn't work properly. :)16:58
sean-k-mooneylibvirt throws an error though whne you try to spawn the vm from nova16:58
cfriesensean-k-mooney: not ours...wonder what version that was added in16:59
sean-k-mooneycfriesen: i am testing with qemu 2.816:59
sean-k-mooneyi also have libvirt 3.3 form master currently but this happens on older version too17:00
*** fragatina has quit IRC17:00
cfriesensean-k-mooney: I'm on qemu 2.6 and libvirt 2.017:00
*** fragatina has joined #openstack-nova17:01
sean-k-mooneycfriesen: im a litlle unfortable adding a new conf option just for this as well if we do they are almost impossible to get rid of17:01
cfriesensean-k-mooney: we can work around it if necessary17:01
sean-k-mooneycfriesen: do you know is there any way to query this from qemu/libvirt so we could decet at runtime?17:02
*** deepak has quit IRC17:02
cfriesensean-k-mooney: no clue. :)   I'm a bit surprised that your libvirt complains since for the most part (especially for single-vcpu guests) it seems to work okay.17:03
sean-k-mooneycfriesen: i think it is actully qemu that is complaining rather then libvirt it just passes along the message17:06
*** rfolco has joined #openstack-nova17:07
*** Apoorva_ has joined #openstack-nova17:07
*** gomarivera_ has joined #openstack-nova17:07
sean-k-mooneycfriesen: libvirt happilly accpts the xml as it is vailid but TCG then complaines when qemu is starting the instance17:07
*** Apoorva has quit IRC17:10
*** gomarivera_ has quit IRC17:11
*** Daisy has joined #openstack-nova17:14
*** baoli has quit IRC17:14
*** deepak has joined #openstack-nova17:14
*** baoli has joined #openstack-nova17:14
*** jpena is now known as jpena|off17:18
*** Daisy has quit IRC17:18
*** sileht has quit IRC17:19
*** sileht has joined #openstack-nova17:19
*** kfarr has joined #openstack-nova17:21
*** moshele has joined #openstack-nova17:24
*** karimb has quit IRC17:25
*** gomarivera_ has joined #openstack-nova17:25
*** Swami has joined #openstack-nova17:27
*** tjones has quit IRC17:30
*** fragatina has quit IRC17:31
*** fragatina has joined #openstack-nova17:31
*** kaisers has quit IRC17:33
*** kaisers has joined #openstack-nova17:33
*** mlavalle has joined #openstack-nova17:33
*** moshele has quit IRC17:34
openstackgerritGage Hugo proposed openstack/nova master: Admin API Policy contingent on is_admin_project  https://review.openstack.org/38414817:35
*** fragatina has quit IRC17:36
*** tjones has joined #openstack-nova17:37
*** tjones has quit IRC17:37
*** ociuhandu has quit IRC17:37
*** mriedem has quit IRC17:37
*** tjones has joined #openstack-nova17:37
*** kaisers has quit IRC17:40
*** djohnsto has joined #openstack-nova17:40
*** hamzy has joined #openstack-nova17:41
*** annegentle has joined #openstack-nova17:41
*** kfarr has quit IRC17:43
*** slaweq has joined #openstack-nova17:45
*** Apoorva_ has quit IRC17:46
*** Apoorva has joined #openstack-nova17:47
*** harlowja has joined #openstack-nova17:50
*** annegentle has quit IRC17:51
*** burt has quit IRC17:53
*** burt has joined #openstack-nova17:54
*** gianpietro has quit IRC17:54
*** salv-orlando has quit IRC17:54
*** salv-orlando has joined #openstack-nova17:54
*** gianpietro has joined #openstack-nova17:57
*** baoli has quit IRC18:00
*** slaweq has quit IRC18:01
*** mvk has quit IRC18:01
*** lpetrut has quit IRC18:02
shewlessHi. I have an openstack installation that has a working spice console (I can connect to the console via horizon).  I'm trying to connect to the console using "virt-viewer" or some other local client instead of from the web. Any hints on how to do this?18:04
openstackgerritGábor Antal proposed openstack/nova master: Transform keypair.delete notification  https://review.openstack.org/46394618:04
*** kaisers has joined #openstack-nova18:04
shewlessBasically I think that nova is serving spice via the html viewer over a proxy .. but I want to access the spice server directly using a spice client (to get audio, etc).18:05
*** gyee has joined #openstack-nova18:06
*** karimb has joined #openstack-nova18:08
*** karimb has quit IRC18:08
*** zul has quit IRC18:09
*** baoli has joined #openstack-nova18:10
*** karimb has joined #openstack-nova18:14
sean-k-mooneyshewless: i belive 'nova help get-spice-console' will provide the info you are looking for18:15
*** annegentle has joined #openstack-nova18:17
*** openstackgerrit has quit IRC18:17
sean-k-mooneyshewless: for my setup at least i dont see a way to connect directly to the spice console though18:18
sean-k-mooneyshewless: the different console types available are  ['novnc', 'xvpvnc', 'rdp-html5', 'spice-html5', 'serial', 'webmks'] but not just spice18:18
*** moshele has joined #openstack-nova18:24
*** fragatina has joined #openstack-nova18:26
*** fragatina has quit IRC18:26
*** gianpietro has quit IRC18:27
*** fragatina has joined #openstack-nova18:27
*** jose-phillips has quit IRC18:27
shewlesssean-k-mooney: yeah that command gives me the spice url.. but I haven't been able to use my spice client to connect to that url18:27
shewlessI think because it's "http" and not "spice" protocol18:27
*** jose-phillips has joined #openstack-nova18:27
sean-k-mooneyshewless: ya im not sure that nova support direct connection as the client would have to connect directly to spice port on the vm via the compute node18:28
*** gianpietro has joined #openstack-nova18:29
shewlesssean-k-mooney: fair enough. Is there a way to get sound to work through the spice html proxy?18:29
*** Sukhdev has joined #openstack-nova18:29
jose-phillipshey18:30
sean-k-mooneynot that i have found though usally i just use x11 forwarding over ssh or install vnc in the guest and connect to it over its public ip so i have never tried18:30
*** kaisers has quit IRC18:32
*** kaisers has joined #openstack-nova18:32
*** moshele has quit IRC18:33
*** djohnsto is now known as CrazyDT18:34
*** zul has joined #openstack-nova18:37
*** annegentle has quit IRC18:41
*** tbachman_ has joined #openstack-nova18:41
*** tbachman has quit IRC18:42
*** tbachman_ is now known as tbachman18:42
*** danpawlik_absent has quit IRC18:42
*** CrazyDT has quit IRC18:43
*** sdatko has quit IRC18:43
*** baoli has quit IRC18:44
*** baoli has joined #openstack-nova18:45
*** lpetrut has joined #openstack-nova18:48
*** baoli has quit IRC18:49
*** baoli has joined #openstack-nova18:50
*** sree has joined #openstack-nova18:54
*** moshele has joined #openstack-nova18:55
*** mriedem has joined #openstack-nova18:56
*** annegentle has joined #openstack-nova18:58
*** sree has quit IRC18:58
*** Apoorva has quit IRC19:09
*** Apoorva has joined #openstack-nova19:10
*** Apoorva has quit IRC19:11
*** Daisy has joined #openstack-nova19:12
mriedemsmcginnis: https://github.com/openstack/nova/commit/564f14f4bc67463d1ef185909e12ab090f10495b ?19:12
mriedemsmcginnis: policy is defined in code here https://github.com/openstack/nova/blob/master/nova/policies/assisted_volume_snapshots.py19:13
smcginnismriedem: Seeing this: http://logs.openstack.org/51/418451/12/check/gate-tempest-dsvm-full-devstack-plugin-nfs-nv/0f06284/logs/screen-c-vol.txt.gz?level=ERROR#_May_16_08_29_46_64781519:13
smcginnismriedem: And http://logs.openstack.org/51/418451/12/check/gate-tempest-dsvm-full-devstack-plugin-nfs-nv/0f06284/logs/screen-n-api.txt.gz#_May_16_08_29_46_64216819:15
mriedemsmcginnis: https://github.com/openstack/tempest/commit/529eefabc937b6dc6f7b3fae11b5942cc6ee452e19:16
mriedemnew tempest change19:16
*** sdatko has joined #openstack-nova19:16
mriedemtempest doesn't gate on FS-style volume backends19:16
mriedemso that's probably it19:16
mriedemhttp://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Forbidden%3A%20Policy%20doesn't%20allow%20os_compute_api%3Aos-assisted-volume-snapshots%3Acreate%20to%20be%20performed.%20(HTTP%20403)%5C%22&from=7d19:16
mriedemso yeah that's it19:16
*** harlowja has quit IRC19:17
armaxmriedem: we have a winner19:18
armaxhttp://logs.openstack.org/25/465125/1/experimental/gate-tempest-dsvm-neutron-pg-full-ubuntu-xenial/2a7a080/19:18
mriedemarmax: sweet19:18
*** danpawlik_absent has joined #openstack-nova19:18
armaxmriedem: nice one19:19
*** Daisy has quit IRC19:19
armaxmriedem: you need to add a test now ;)19:19
mriedemarmax: yup, working on it19:19
armaxmriedem: you rock19:19
mriedemsmcginnis distracted me with all of his NFS love19:19
*** Sukhdev has quit IRC19:22
armaxmriedem: do you want to rerun the job to confirm if there’s another race lurking?19:22
*** annegentle has quit IRC19:22
armaxmriedem: I thought you learned the craft of multitasking when you became PTL19:22
mriedemarmax: i can run it again yeah while i work on tests19:23
*** ericyoung has joined #openstack-nova19:24
armaxmriedem: does Zuul listens to one whilst there’s still another ongoing run?19:24
armaxoh19:24
armaxnever mind19:24
mriedemarmax: i didn't see that you checked experimental before i did19:24
mriedemso i'll have to do it again once that run is done i think19:24
armaxdidn’t notice that jenkins came back, we’re good19:24
mriedemartom_: let me know if i'm off base here https://review.openstack.org/#/c/415520/19:24
*** moshele has quit IRC19:26
*** salv-orlando has quit IRC19:28
*** jamesdenton has joined #openstack-nova19:32
*** jamesden_ has quit IRC19:33
mriedemarmax: do we need to worry about the subnet being gone too?19:34
mriedemL45019:34
*** openstackgerrit has joined #openstack-nova19:35
openstackgerritsean mooney proposed openstack/nova master: do not set vcpu_pin elements when virt_type=qemu  https://review.openstack.org/46516019:35
*** usertm has quit IRC19:37
artom_mriedem, will do, thanks for the comments!19:38
*** artom_ is now known as artom19:38
*** marst has joined #openstack-nova19:39
*** gianpietro has quit IRC19:39
mriedemartom: i think we should just get the device metadata first, then attach to the guest, and then if that's fine, do instance.save() to update the db19:39
mriedemthen we don't have to worry about rolling back the detach in the guest19:39
*** gianpietro has joined #openstack-nova19:41
armaxmriedem: I’ll reply on the review19:43
*** tbachman_ has joined #openstack-nova19:50
*** tbachman has quit IRC19:50
*** tbachman_ is now known as tbachman19:50
*** kaisers has quit IRC19:50
*** gianpietro has quit IRC19:51
artommriedem, do we have what we need to build the metadata if we do so before attaching?19:51
artomI'm thinking of PCI and/or MAC addresses19:51
mriedemartom: oh i guess i didn't dig into _build_device_metadata, but that reads from the guest xml doesn't it?19:52
mriedemto correlate the tag with the device or something19:52
artommriedem, yeah19:52
mriedem:(19:52
artommriedem, you're basically trying to answer the question "what happens if _build_device_metadata fails?" right?19:53
artomBecause the try block it's in only handles libvirtError...19:54
mriedemyeah19:54
mriedemas noted, the compute manager will handle any NovaException that comes out of the driver.attach_interface method19:54
mriedembut that only deallocates the port, which if it's a pre-existing port is an unbind of the host on the port, if nova created the port then nova deletes the port,19:55
mriedemwhich would trigger a network-vif-deleted event, and nova would get that and detach the interface from the guest,19:55
mriedembut i'm worried about the case the the port was provided to nova to attach to the instance, and we just unbind it,19:55
mriedemi don't think we'll get a network-vif-deleted event from neutron in that case, because it wasn't deleted19:55
mriedemand we wouldn't detach the interface from the guest19:55
artomThat raises a question about the semantics of tagged attach, namely, do we fail the whole thing if only the tagging part fails19:57
*** armax has quit IRC19:58
artomIn situations like this I really miss Java's stricter exception system19:59
*** vladikr has quit IRC20:00
*** mlavalle has quit IRC20:01
*** mlavalle has joined #openstack-nova20:02
*** harlowja has joined #openstack-nova20:04
*** suresh12 has joined #openstack-nova20:05
*** suresh12 has quit IRC20:05
*** suresh12 has joined #openstack-nova20:06
*** Apoorva has joined #openstack-nova20:07
*** Apoorva has quit IRC20:08
*** Apoorva has joined #openstack-nova20:09
*** dave-mccowan has quit IRC20:10
*** markvoelker has joined #openstack-nova20:11
*** gomarivera_ has quit IRC20:12
*** suresh12 has quit IRC20:12
*** jamesdenton has quit IRC20:18
*** suresh12 has joined #openstack-nova20:20
*** gianpietro has joined #openstack-nova20:20
mriedemartom: well,20:21
mriedemif i'm attaching an interface with a tag and the interface shows up in my guest but the tag doesn't, i'm going to wonder wtf happened and create a support ticket,20:21
mriedemso i'm thinking if any of the operation fails, it all needs to fail20:21
mriedemand rollback the attach20:21
*** suresh12 has quit IRC20:23
*** suresh12 has joined #openstack-nova20:23
*** jamesdenton has joined #openstack-nova20:23
*** ijw has joined #openstack-nova20:25
*** gianpietro has quit IRC20:25
*** adisky_ has quit IRC20:27
*** slaweq has joined #openstack-nova20:28
*** gianpietro has joined #openstack-nova20:29
*** kfarr has joined #openstack-nova20:29
*** thorst has quit IRC20:31
*** ujjain has quit IRC20:32
artommriedem, yeah. If we had a way to communicate partial failure to the user it might have been different, but we don't20:32
openstackgerritEd Leafe proposed openstack/nova master: Have scheduler claim resources  https://review.openstack.org/46399320:32
openstackgerritEd Leafe proposed openstack/nova master: Make the method to put allocations public  https://review.openstack.org/46408620:32
openstackgerritEd Leafe proposed openstack/nova master: Pass a list of instance UUIDs to scheduler  https://review.openstack.org/46517120:32
artommriedem, I feel like the cleanest would be to catch _build_device_metadata failures in attach_interface and unplug the vif, like we currently do upon libvirtError20:33
mriedemartom: yeah probably,20:34
mriedemthen we'll get the network-vif-unplugged event from neutron20:34
mriedembut, i don't think we handle that20:35
*** gomarivera_ has joined #openstack-nova20:35
mriedemLOG.warning(_LW('Received unexpected event %(event)s for '20:35
mriedem                            'instance'),20:35
mriedemhttp://logs.openstack.org/25/465125/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/65c553c/logs/screen-n-cpu.txt.gz?level=WARNING#_May_16_18_05_12_03541820:35
mriedemwe get a lot of those20:36
*** Sukhdev has joined #openstack-nova20:36
mriedemand we don't actually detach from the guest20:36
mriedemartom: really, i don't know why attach_interface just doesn't call detach_interface on failure20:37
mriedemsince that handles the things we care about20:37
*** ijw has quit IRC20:37
mriedemunplugs the vif and detaches the device from the guest20:37
*** Sukhdev has quit IRC20:37
artommriedem, for real, vif_driver.unplug ends up going to Neutron?20:38
mriedemartom: it doesn't call neutron directly20:38
*** Sukhdev has joined #openstack-nova20:38
mriedembut the neutron agent is polling for changes, which are introduced via the os-vif unplug20:38
mriedemand the neutron agent notifies the neutron server which sends an event back to nova20:38
*** smatzek has quit IRC20:38
mriedembut as noted, we don't handle network-vif-unplugged20:38
artomAh... Well, by default I assume code that's there is there for a reason, and works well enough20:38
artomAnd it was apparently decided by past powers that be that vif_driver.unplug was enough cleanup, so... ;)20:39
mriedemheh yeah idk20:39
mriedemwell,20:39
mriedemi guess the thinking was,20:39
mriedemyou'd only get that libvirtError if failing to attach the device in the guest failed20:39
mriedemso there would be nothing to detach from the guest,20:39
mriedemthat's no longer the case with your change20:39
mriedemb/c we have a new failure domain after the interface is attached into the guest20:40
*** pchavva has quit IRC20:40
artomAha, smart.20:40
artomAnd that actually clarified the plug vs attach distinction in my head20:40
artomplug = to the network20:40
artomattach = to the guest20:40
mriedemyeah20:41
mriedemstepping back, what could _build_device_metadata actually fail on besides db/rpc traffic stuff20:41
*** salv-orlando has joined #openstack-nova20:41
mriedemor coding errors20:41
artomI looked through it, I didn't see anything besides what you mentioned.20:41
cfriesenmriedem: do you think there's any point in further pursuing the live migration resource-tracking-numa-xml patches to try and get them merged, or should we give up and wait for jaypipes to fix it with the new placement/allocation code in queens?20:42
mriedemcfriesen: i haven't dug into those,20:42
mriedembut in general i wouldn't count on anything20:43
artommriedem, I need to run to fetch offsprings from daycare. I'll try to submit a new patchset tonight that detach_interface'es if _build_device_metadata fails20:43
mriedemartom: ok20:43
*** ujjain has joined #openstack-nova20:44
*** ujjain has quit IRC20:44
*** ujjain has joined #openstack-nova20:44
*** sree has joined #openstack-nova20:47
kashyapcfriesen: Hey, was travelling today.  Just opened IRC & saw your ping (it's late here).20:48
kashyapcfriesen: Is it about the stability of 'cpu-throttle-initial' and 'cpu-throttle-increment'?20:49
kashyapIf so, I can't say yet without digging myself, which I could only do tomorrow :-)20:49
kashyap(Unless DanPB has already saw the email thread and responded there)20:49
*** sree has quit IRC20:51
*** thorst has joined #openstack-nova20:51
cfriesenkashyap: no worries.  yeah, that's it.  tomorrow's fine, and nobody has responded. :)20:52
bauzasedleafe: not sure I understand why you're still working on my branch ?20:55
openstackgerritHongbin Lu proposed openstack/nova master: [WIP] Handle exception on adding secgroup  https://review.openstack.org/46517320:55
openstackgerritEd Leafe proposed openstack/nova master: Remove selecting host based on host_subset_size  https://review.openstack.org/46517420:55
*** thorst has quit IRC20:55
bauzasedleafe: please stop doing that !20:55
*** ijw has joined #openstack-nova20:55
bauzasI'm just uploading my series, and I'm working on it since yesterday !20:56
bauzasedleafe: is it because you want your name on the BP ?20:56
*** ijw has quit IRC20:56
edleafeThere was still some interest in my approach. dansmith asked that I change the way that instance UUIDs are passed.20:56
edleafebauzas: dpm20:57
edleafeugh20:57
edleafedon't be silly. I don't care about names on BPs20:57
bauzasI'm seriously nerved, because you're duplicating my series20:57
dansmithedleafe: no, I'm not interested in the scheduler approach, I was just saying that if we need to pass the uuids, we should do them as a param20:57
dansmithedleafe: I said if you wanted to re-open the discussion about conductor vs. scheduler you could20:57
*** gomarivera_ has quit IRC20:58
edleafedansmith: ok, and yes, I do want to re-open, because I think this is much cleaner20:58
* bauzas stops discussing and rather trying to upload20:58
*** jamesdenton has quit IRC20:58
*** lpetrut has quit IRC20:58
dansmithbauzas: have you replied to any of the feedback on your series? because I don't think I've seen that and so it looks like nothing has happened on that set for quite a while20:58
edleafedansmith: the code is there and working OMM.20:58
dansmithsince before summit or so20:58
bauzassorry to have a family life, folks20:58
*** gomarivera_ has joined #openstack-nova20:59
*** rfolco has quit IRC20:59
bauzasif you want to see code, then...20:59
*** thorst has joined #openstack-nova20:59
*** gjayavelu has quit IRC20:59
*** diablo_rojo has joined #openstack-nova21:00
cdentI reallly think we can do more to move code along in a collaborative fashion21:01
cdentI generally think that if feedback has not had a response for a couple days that code is up for grabs to be fixed. I know that's not a standard that we have formalized, but I wonder if we should.21:02
*** thorst has quit IRC21:02
cdentThis stuff needs to move a lot faster than it is21:02
dansmithagree21:02
*** salv-orlando has quit IRC21:02
edleafethat's more of a free-for-all than collaboration, though21:02
openstackgerritHongbin Lu proposed openstack/nova master: [WIP] Handle exception on adding secgroup  https://review.openstack.org/46517321:02
bauzascdent: sure, but when you're working on something since 2 days, and then seeing a concurrent patch, do you think your former 2 days were just done ?21:02
cdentbauzas: the way to get around that is to respond to feedback first21:02
*** delete has joined #openstack-nova21:03
dansmithbauzas: right, it's hard to know someone is working on feedback when there is no response :)21:03
cdentedleafe: I agree there are ways to make it more clean, but in general principle...21:03
bauzasfor example, I said to edleafe that I was working on removing host_subset_size and then I see  https://review.openstack.org/46517421:03
deletehi, I am getting this error21:03
deleteGlanceConnectionFailed: Connection to glance host 198.23.82.11:9292 failed: Error finding address for https://198.23.82.11:9292/v1/images/detail?is_public=none&limit=20: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:579)21:03
deleteglance is using a self-signd certificate21:03
edleafebauzas: and I told you that I had done it in a subsequent patch21:03
bauzasdansmith: well, I pinged you and edleafe this morning explaining why I wasn't yet uploading my series21:03
*** gomarivera_ has quit IRC21:04
dansmithbauzas: yeah, but I hadn't seen any updates since then.. I guess I missed them21:05
deletenevermind21:05
*** delete has left #openstack-nova21:05
* edleafe runs out to pick up daughter21:06
*** mriedem has quit IRC21:06
*** dimtruck is now known as zz_dimtruck21:06
openstackgerritSylvain Bauza proposed openstack/nova master: Delete existing allocations when retrying  https://review.openstack.org/46043321:07
openstackgerritSylvain Bauza proposed openstack/nova master: Don't delete allocation if instance being scheduled  https://review.openstack.org/46017721:07
openstackgerritSylvain Bauza proposed openstack/nova master: WIP: Allocate instance by the conductor  https://review.openstack.org/46045521:07
openstackgerritSylvain Bauza proposed openstack/nova master: WIP: Scheduler returning more than 1 host  https://review.openstack.org/46517521:07
bauzasdansmith: so ^21:07
dansmithbauzas: cool, thanks.. I'm assuming edleafe pushed up something that caused a merge conflict?21:09
bauzasFWIW, I'm just adding the RPC API version21:10
*** thorst has joined #openstack-nova21:11
*** slaweq has quit IRC21:11
*** awaugama has quit IRC21:11
*** ijw has joined #openstack-nova21:12
*** ijw has quit IRC21:13
*** ijw has joined #openstack-nova21:13
*** Daisy has joined #openstack-nova21:15
efrieddansmith Is there a generic, forward- and backward-compatible way I can tell (in my CI) whether cellsv2 is enabled?21:16
efriedBasically, I need to know whether to run that nova-manage command.21:16
dansmithum21:16
dansmithas of ocata it's always enabled21:16
dansmithso, yes? :)21:16
efriedBut would like to code it in such a way that my CI will work today on pre-ocata, but also into the future.21:16
dansmithyour CI doesn't know what release you're on?21:18
efrieddansmith Well, yeah, but it's kinda tough to say "greater than or equal to ocata"21:18
efriedI mean, that'll work (cause 'master' is >= 'ocata')... until we roll over from z back to a ;-)21:19
dansmithwelp... I dunno, maybe pick something you know is in ocata but not in newton that you can key off of? like the presence of cmd/nova-status or something?21:19
*** Daisy has quit IRC21:19
efriedOkay.  I think we're going to go dumber than that.  We're not CIing before newton, so we'll just say "if not newton".  Thanks dansmith.21:20
dansmithseems reasonable :)21:20
*** ijw has quit IRC21:23
*** ijw has joined #openstack-nova21:24
*** karimb has quit IRC21:27
*** karimb has joined #openstack-nova21:27
*** gjayavelu has joined #openstack-nova21:29
*** mvk has joined #openstack-nova21:29
edleafebauzas: dansmith: I have another patch that adds returning multiple hosts to the conductor, but wasn't sure if there was an agreement on a) how to do it and b) how many21:32
dansmithedleafe: should be num_retries or whatever21:33
dansmithwell, num_instances * num_retries21:33
dansmithedleafe: there's another wrinkle21:33
edleafe"whatever" :)21:33
*** diablo_rojo has quit IRC21:34
dansmiththe hosts we slap into a reqspec to pass down to the cell all have to be ... in that cell21:34
dansmithso I was thinking as a first go, we might just get the normal candidate hosts, and then for each one, ask for n-1 more that are in the same cell, since we can ask the scheduler that already21:34
dansmith(for the same cell I mean)21:34
edleafeso... the scheduler picks a host, and then only returns other hosts that are in the same cell?21:35
edleafeIOW, a post-filter?21:35
dansmithwell, we pick num_instances hosts like normal,21:37
dansmithbut then for each instance we re-ask for num_retries host in the same cell21:37
*** zz_dimtruck is now known as dimtruck21:39
edleafeok, so check the cell_uuid for each selected host, and only return more hosts with that same cell_uuid21:39
dansmithyeah, we can already ask to limit hosts to a given cell_uuid,21:40
dansmithso I guess we have to look up the host_mapping for that host so we know what cell_uuid to ask for,21:40
dansmithbut we have to do that somewhere in that code so we should be able to collapse those (eventually, if nothing else)21:40
edleafeyeah, the order of events was not clear to me21:41
dansmithbut clear now?21:41
openstackgerritSylvain Bauza proposed openstack/nova master: Scheduler returning more than 1 host  https://review.openstack.org/46517521:41
openstackgerritSylvain Bauza proposed openstack/nova master: WIP: Allocate instance by the conductor  https://review.openstack.org/46045521:41
dansmithI haven't looked at bauzas' code from just now, it's possible he's doing some of that21:41
bauzasjust updated my change21:41
bauzasedleafe: did that in https://review.openstack.org/465175 given the consensus we had21:42
edleafedansmith: clear except for the request for a particular cell21:42
*** tbachman has quit IRC21:42
bauzasone of the reasons why it took me a while to upload the series21:42
dansmithedleafe: there's code in the migrate path that demonstrates that, but reqspec.destination.cell can be set, which limits it to that cel21:43
dansmithbauzas: okay cool21:43
edleafebauzas: ok, thanks. I was looking for getting the cell uuid from the reqspec21:43
dansmithI need to run off for a bit, but I will look over bauzas' patches when I get back21:44
edleafeAnd was it agreed to return a 2-tuple of (chosen_host, alternative_hosts), or simply a list of hosts, with the first one the chosen one?21:44
bauzasedleafe: don't forget that the scheduler can return more than 121:45
dansmithedleafe: we can't really do it all in one query because of the cell restriction I think21:45
bauzashint : num_instances21:45
dansmithanyway, biab21:46
edleafebauzas: yeah, of course I get that. We were originally returning a list of single hosts; we could now return a list of lists of hosts21:46
dansmithdon't kill each other while I'm gone21:46
edleafedansmith: you're no fun21:47
bauzasit's 23:4721:47
bauzasnothing good happens after midnight21:47
dansmithokay fine, do and I'll congratulate the winner when I return21:47
melwittwhat bauzas has at https://review.openstack.org/#/c/465175/2/nova/scheduler/filter_scheduler.py@142 is what I was thinking, without doing a second query21:47
melwittthat is, parse the list we get back the first time to pick alternatives in the same cell21:47
dansmithoh because we're getting back more than subset size now21:48
melwittwe always get the whole list I thought (all that pass all filters)21:48
edleafemelwitt: that's correct21:48
melwittand then the first is picked unless subset size is bigger than 121:48
dansmithwe return 10k hosts from scheduler to conductor?21:48
edleafedansmith: no21:48
openstackgerritSylvain Bauza proposed openstack/nova master: Scheduler returning alternatives per destination  https://review.openstack.org/46517521:49
openstackgerritSylvain Bauza proposed openstack/nova master: WIP: Allocate instance by the conductor  https://review.openstack.org/46045521:49
edleafewe return 10K hosts from placement to scheduler (potentially)21:49
bauzasI stop iterating over the list once we have enough alternatives21:49
bauzasbut please see $code21:49
dansmithoh, I see that's happening in scheduler, yeah, okay21:49
melwittyeah21:49
bauzasseriously, the big problem is not there21:49
dansmithyeah I didn't think about doing that, but that's good21:49
bauzaslike I said yesterday in that channel, we stop using iterators21:49
melwittbauzas: yeah, that's exactly what I hoped to see, stop when have enough instead of doing a list comprehension over all21:50
dansmithI guess I thought we weighted  a subset of the hosts,21:50
bauzasso in case we have 10K nodes, then we have a 10K list for filters and a 10K list for weighers21:50
dansmithbecause on early scheduler runs, we'll be weighing 10k nodes just to pick one21:50
bauzasinstead of having iterators21:50
bauzasso it took me 3 hours to see if I was able to quickly fix that21:50
bauzasie. using iterators for filters and weighers21:50
bauzaslooks to me it's possible, but I need more time21:51
*** gomarivera_ has joined #openstack-nova21:51
*** thorst has quit IRC21:51
dansmithnot sure how you can pick the highest score host without iterating all of them...21:51
dansmithif that's what you mean21:51
*** yassine has joined #openstack-nova21:52
*** yassine is now known as Guest266121:52
bauzasdansmith: I was thinking of adding a reservoir sampling method for that21:52
edleafefilters have to iterate through all returned hosts. Weighers have to iterate through all filtered hosts21:52
dansmithedleafe: right21:53
bauzaswe need to iterate for sure, but we don't need to put it all in memory21:53
*** esberglu has quit IRC21:53
dansmithsure21:53
dansmithanyway, I'll look more at this when I get back21:53
bauzasso, for example, to-be-weighting hosts could be like having an index and a weight so we could just sort based on that21:54
bauzasinstead of sorting based on a full memory21:54
bauzasand once we have filtered hosts, we don't really need to keep that in memory21:54
bauzassince for the moment the scheduler can hardly support more than 400 nodes, I think it's not a problem bubbling up21:55
bauzasbut if we say for cells v2 that all the nodes will be verified, then I think we should fix that21:55
bauzasand please, don't coufound iterators and lists21:56
bauzasedleafe: oh, and FWIW, the 2-tuple (host, alts) is just for a priv method21:57
bauzasedleafe: select_dests is returning a keyed dict21:57
*** mdrabe has quit IRC21:57
bauzaswell, a list of keyed dicts rather21:57
*** felipemonteiro has quit IRC21:59
*** edmondsw has quit IRC21:59
*** edmondsw has joined #openstack-nova22:00
edleafebauzas: yes, I do believe I've seen that code once or twice :)22:03
*** salv-orlando has joined #openstack-nova22:03
*** edmondsw has quit IRC22:04
edleafeI was just asking if that implementation was agreed upon at the summit22:04
bauzaswe didn't discussed on the interface22:05
bauzasso you could be bikeshedding it :p22:05
bauzastbc, I think that since _schedule() is private, we shouldn't really care of what we return22:06
edleafenope, just trying to catch up beyond the etherpad https://etherpad.openstack.org/p/BOS-forum-move-claims-from-compute-to-scheduler22:06
bauzasthe crux should be around select_dests()22:06
*** tbachman has joined #openstack-nova22:09
*** Sukhdev has quit IRC22:11
*** karimb has quit IRC22:18
*** itlinux has joined #openstack-nova22:19
*** xyang1 has quit IRC22:20
*** armax has joined #openstack-nova22:21
*** baoli has quit IRC22:24
*** eharney has quit IRC22:25
*** tbachman has quit IRC22:34
*** dave-mccowan has joined #openstack-nova22:37
*** tbachman has joined #openstack-nova22:40
*** gomarivera_ has quit IRC22:42
*** ijw has quit IRC22:42
*** ijw has joined #openstack-nova22:43
*** salv-orlando has quit IRC22:44
*** ijw has quit IRC22:44
*** Sukhdev has joined #openstack-nova22:45
melwittanyone else interested in preventing KeyErrors in exceptions in unit test (creates garbled text to stdout), please review dis: https://review.openstack.org/#/c/41161522:46
*** lyan has quit IRC22:47
*** tjones has quit IRC22:48
*** marst has quit IRC22:50
*** salv-orlando has joined #openstack-nova22:50
*** sree has joined #openstack-nova22:51
*** abalutoiu has quit IRC22:53
*** abalutoiu has joined #openstack-nova22:54
*** sree has quit IRC22:55
*** suresh12 has quit IRC22:59
melwittwoot, thanks23:00
*** gouthamr has quit IRC23:00
*** suresh12 has joined #openstack-nova23:03
*** suresh12 has quit IRC23:03
*** Fdaisuke has joined #openstack-nova23:03
*** suresh12_ has joined #openstack-nova23:03
*** baoli has joined #openstack-nova23:04
openstackgerritmelanie witt proposed openstack/nova master: WIP Cache database and message queue connection objects  https://review.openstack.org/46504223:07
*** marst has joined #openstack-nova23:08
*** gianpietro has quit IRC23:11
*** suresh12_ has quit IRC23:13
*** cdent has quit IRC23:17
*** chyka has quit IRC23:18
*** gianpietro has joined #openstack-nova23:20
*** sdague has quit IRC23:21
*** suresh12 has joined #openstack-nova23:22
*** gouthamr has joined #openstack-nova23:26
*** suresh12 has quit IRC23:26
*** Swami has quit IRC23:28
*** bkopilov has quit IRC23:28
*** bkopilov has joined #openstack-nova23:29
*** gianpietro has quit IRC23:29
*** gianpietro has joined #openstack-nova23:29
*** mriedem has joined #openstack-nova23:34
*** Sukhdev has quit IRC23:40
*** mlavalle has quit IRC23:42
*** suresh12 has joined #openstack-nova23:44
*** ijw has joined #openstack-nova23:45
*** thorst has joined #openstack-nova23:51
*** yingjun has joined #openstack-nova23:56
*** thorst has quit IRC23:56
*** takashin has joined #openstack-nova23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!