| *** ijw has quit IRC | 00:00 | |
| *** ijw has joined #openstack-nova | 00:01 | |
| *** MVenesio has joined #openstack-nova | 00:03 | |
| *** thorst_afk has joined #openstack-nova | 00:03 | |
| *** ijw has quit IRC | 00:03 | |
| *** ijw has joined #openstack-nova | 00:05 | |
| *** MVenesio has quit IRC | 00:05 | |
| *** ijw has quit IRC | 00:06 | |
| *** ijw has joined #openstack-nova | 00:06 | |
| *** jmlowe has quit IRC | 00:07 | |
| *** marst has quit IRC | 00:10 | |
| *** ijw has quit IRC | 00:15 | |
| melwitt | dansmith: is it ever possible to change the return type of a remotable method? like is there a way for new code to know old code is calling so the return type can be formatted to what the old code expects? | 00:15 |
|---|---|---|
| dansmith | melwitt: nope | 00:15 |
| dansmith | pass a flag or create a new method | 00:16 |
| dansmith | ideally the latter | 00:16 |
| melwitt | okay. so to change all count() to return a dict instead of an int, I have to do something like that | 00:16 |
| dansmith | yeah | 00:16 |
| melwitt | I'm trying to think if it's even possible for old code to call new code count(). it's only called in nova-api | 00:17 |
| melwitt | Quotas.count() | 00:17 |
| dansmith | if you change it you should make a new method | 00:17 |
| dansmith | don't cheat :) | 00:17 |
| melwitt | :( | 00:18 |
| melwitt | the hard part is thinking of a name that isn't dumb | 00:18 |
| dansmith | count_less_sucky_than_the_first_attempt() | 00:18 |
| melwitt | lol, I wish | 00:18 |
| melwitt | maybe count_as_dict since probably peeps will expect an integer | 00:19 |
| dansmith | oh please please call it count_dicts() | 00:19 |
| melwitt | I don't get it | 00:21 |
| *** yamamoto_ has joined #openstack-nova | 00:22 | |
| *** jmlowe has joined #openstack-nova | 00:22 | |
| *** thorst_afk has quit IRC | 00:23 | |
| cfriesen | I think that's cause you're too mature | 00:24 |
| melwitt | I shall use that excuse :) | 00:24 |
| *** crushil has quit IRC | 00:24 | |
| dansmith | I shall remain immature and unashamed | 00:26 |
| *** yamamoto_ has quit IRC | 00:28 | |
| *** tbachman has quit IRC | 00:28 | |
| *** Yangyapeng has quit IRC | 00:30 | |
| *** fishbone_ has joined #openstack-nova | 00:32 | |
| fishbone_ | Hello all, I am having a serious problem. I am performing an upgrade from Newton to Ocata and every time I run the upgrade for nova-compute I receive "ERROR: could not access cell mapping database - has api db been created?" | 00:33 |
| *** salv-orlando has joined #openstack-nova | 00:33 | |
| *** salv-orlando has quit IRC | 00:34 | |
| *** salv-orlando has joined #openstack-nova | 00:34 | |
| cfriesen | fishbone: have you read the nova upgrade notes in the release notes? | 00:35 |
| fishbone_ | cfriesen: yes I believe so, it only seemed to mention designate changes | 00:35 |
| *** ijw has joined #openstack-nova | 00:36 | |
| fishbone_ | I see all of my nova services except for the compute services are up | 00:37 |
| fishbone_ | I have tried creating the cells database manually and also by using the simple_cells command | 00:37 |
| cfriesen | fishbone: I think the section you want begins with "A new nova-manage command has been added which will upgrade a deployment to cells v2..." at https://docs.openstack.org/releasenotes/nova/ocata.html | 00:38 |
| cfriesen | dansmith: is this correct? ^ | 00:39 |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: cached images should be cleaned up by time https://review.openstack.org/465954 | 00:39 |
| fishbone_ | cfriesen: Thanks for the link, although I tried that method as well. I have my system backed up and was able to retry using that command from scratch. Also the issue only seems to lie with the compute hosts, my controller node can access the api database fine | 00:42 |
| *** winston-d_ has joined #openstack-nova | 00:42 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: cached images should be cleaned up by time https://review.openstack.org/465954 | 00:42 |
| *** thorst_afk has joined #openstack-nova | 00:44 | |
| *** ijw has quit IRC | 00:46 | |
| *** hongbin has quit IRC | 00:46 | |
| *** thorst_afk has quit IRC | 00:48 | |
| *** takashin has joined #openstack-nova | 00:49 | |
| *** ijw has joined #openstack-nova | 00:49 | |
| *** ericyoung has quit IRC | 00:50 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: cached images should be cleaned up by time https://review.openstack.org/465954 | 00:53 |
| *** dikonoor has joined #openstack-nova | 00:54 | |
| *** rfolco has joined #openstack-nova | 00:56 | |
| *** salv-orlando has quit IRC | 00:59 | |
| *** databus23_1 has joined #openstack-nova | 01:00 | |
| *** phuongnh has joined #openstack-nova | 01:01 | |
| *** tovin07_ has joined #openstack-nova | 01:02 | |
| *** armax has quit IRC | 01:03 | |
| *** tbachman has joined #openstack-nova | 01:03 | |
| *** markmc` has quit IRC | 01:03 | |
| *** ansiwen has quit IRC | 01:04 | |
| *** ltomasbo|away has quit IRC | 01:04 | |
| *** kashyap has quit IRC | 01:04 | |
| *** databus23_ has quit IRC | 01:04 | |
| *** weshay has quit IRC | 01:04 | |
| *** lucas-afk has quit IRC | 01:04 | |
| *** jpena|off has quit IRC | 01:04 | |
| *** mdbooth has quit IRC | 01:04 | |
| *** migi has quit IRC | 01:04 | |
| *** dmellado has quit IRC | 01:04 | |
| *** dave-mccowan has quit IRC | 01:06 | |
| *** kashyap has joined #openstack-nova | 01:07 | |
| *** migi has joined #openstack-nova | 01:07 | |
| *** lucasagomes has joined #openstack-nova | 01:10 | |
| *** dikonoor has quit IRC | 01:10 | |
| *** weshay has joined #openstack-nova | 01:10 | |
| *** seungjin has joined #openstack-nova | 01:10 | |
| *** ansiwen has joined #openstack-nova | 01:11 | |
| *** mdbooth has joined #openstack-nova | 01:11 | |
| *** Sukhdev has quit IRC | 01:12 | |
| *** kaisers has quit IRC | 01:12 | |
| *** jpena|off has joined #openstack-nova | 01:13 | |
| *** ltomasbo|away has joined #openstack-nova | 01:13 | |
| *** seungjin is now known as johnhaan | 01:14 | |
| *** gjayavelu has quit IRC | 01:14 | |
| *** markmc has joined #openstack-nova | 01:14 | |
| *** ijw has quit IRC | 01:15 | |
| *** Shunli has joined #openstack-nova | 01:16 | |
| mriedem | fishbone_: "could not access cell mapping database" has nothing to do with the computes | 01:20 |
| mriedem | you're getting that from running nova-manage db sync right? | 01:20 |
| mriedem | nova.conf on the compute node doesn't need access to the API database (or any database for that matter) | 01:20 |
| fishbone_ | mriedem: I didn't think so either, however; I don't get the error when syncing the database, that seems to work with no errors. I get it when upgrading nova-compute on the compute nodes | 01:22 |
| *** dmellado has joined #openstack-nova | 01:22 | |
| *** Sukhdev has joined #openstack-nova | 01:22 | |
| *** Sukhdev has quit IRC | 01:22 | |
| mriedem | why are you running nova-manage db sync on the compute nodes? | 01:22 |
| *** esberglu has joined #openstack-nova | 01:22 | |
| *** esberglu has quit IRC | 01:23 | |
| *** ijw has joined #openstack-nova | 01:23 | |
| mriedem | also fyi https://docs.openstack.org/developer/nova/cells.html#upgrade-minimal | 01:23 |
| *** ijw has quit IRC | 01:23 | |
| mriedem | what you're hitting is this https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L649 | 01:24 |
| mriedem | when it's trying to automatically sync the nova_cell0 database | 01:24 |
| *** yamamoto_ has joined #openstack-nova | 01:24 | |
| mriedem | anyway, you shouldn't need to sync the db from the compute nodes | 01:25 |
| *** Yangyapeng has joined #openstack-nova | 01:27 | |
| *** rmk has quit IRC | 01:27 | |
| fishbone_ | mriedem, are you saying the error can be ignored, I don't think I am able to compete the nova-compute installation because of this error | 01:28 |
| fishbone_ | mriedem: Is there a way to suppress that sync process? | 01:29 |
| mriedem | i'm saying you don't need to sync the database from a compute node | 01:29 |
| mriedem | the compute node doesn't have direct access to the database | 01:29 |
| mriedem | or shouldn't | 01:29 |
| *** yamamoto_ has quit IRC | 01:29 | |
| *** rmk has joined #openstack-nova | 01:32 | |
| *** rmk has quit IRC | 01:32 | |
| *** rmk has joined #openstack-nova | 01:32 | |
| fishbone_ | mriedem: Do you know why I may be getting that error on a compute host then? | 01:33 |
| fishbone_ | mriedem: I get the error even if I do a fresh install of nova-compute after removing old cofig files | 01:34 |
| fishbone_ | config* | 01:34 |
| *** gcb has joined #openstack-nova | 01:34 | |
| mriedem | i assume because the compute host doesn't have direct access to the cell0 database | 01:34 |
| *** gianpietro has quit IRC | 01:34 | |
| mriedem | but it's weird that the sync on the nova (cell) database would not fail in that case | 01:35 |
| mriedem | https://docs.openstack.org/ocata/install-guide-ubuntu/nova-compute-install.html doesn't say anything about running db sync from the compute host though | 01:35 |
| mriedem | that's all done on the controller https://docs.openstack.org/ocata/install-guide-ubuntu/nova-controller-install.html | 01:35 |
| fishbone_ | mriedem: Yes it is strange, I get the error at the apt install nova-compute" step | 01:37 |
| mriedem | hmm, so that's something baked into the package then? | 01:37 |
| mriedem | like a post-install script as part of the package? | 01:37 |
| mriedem | are you using ubuntu packages? | 01:38 |
| fishbone_ | mriedem: yes, I am using the ubuntu repositories | 01:38 |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: Skip policy rules on attach_network for none network allocation https://review.openstack.org/465903 | 01:39 |
| mriedem | fishbone_: ok well those seem wrong, i'd probably report a bug against the ubuntu nova package LP site | 01:40 |
| *** litao__ has joined #openstack-nova | 01:40 | |
| mriedem | fishbone_: on your control node, if you run "nova-manage cell_v2 list_cells" do you see 2 listed? | 01:41 |
| mriedem | https://launchpad.net/ubuntu/+source/nova for reporting bugs against ubuntu nova packages btw | 01:41 |
| mriedem | if list_cells shows 2 cells then i think you're good to go | 01:42 |
| *** baoli has joined #openstack-nova | 01:43 | |
| *** tbachman has quit IRC | 01:45 | |
| fishbone_ | mriedem: Yes it shows properly, however; the compute nodes are unable to install the appropriate packages | 01:46 |
| mriedem | mdbooth: lyarwood: btw, hooray for completely differnt code paths for attaching a volume during boot and after boot https://review.openstack.org/#/c/443951/18/nova/virt/libvirt/volume/vrtshyperscale.py@44 | 01:47 |
| fishbone_ | mriedem: they fail with the error | 01:47 |
| mriedem | fishbone_: is there a way to ignore post-install scripts, or force the install? sorry but i haven't heard of this one, definitely sounds like a bug in the assumptions the packages are making | 01:47 |
| mriedem | fishbone_: also https://ask.openstack.org/en/question/103660/ocata-install-nova-error/ | 01:48 |
| *** thorst_afk has joined #openstack-nova | 01:48 | |
| fishbone_ | mriedem: I haven't tried that, I will, and thanks for all your help, I'll update soon | 01:49 |
| mriedem | fishbone_: see if you have a nova_api_cell0 or nova_cell0 db | 01:50 |
| mriedem | you can also see that via nova-manage cell_v2 list_cells --verbose | 01:50 |
| mriedem | sounds like some people in that forum thread hit some issues with mismatched db names and the connection URL in the api db | 01:50 |
| mriedem | for cell0 | 01:50 |
| fishbone_ | mriedem: I saw that article, it didn't seem to work for me, I have the nova_cell0 database | 01:50 |
| mriedem | is that what's in the database_connection for the cell0 cell_mapping in the nova_api database though? | 01:51 |
| fishbone_ | mriedem: I followed the docs, which say that it should be named as nova_cell0 | 01:51 |
| mriedem | i'd check your db :) | 01:51 |
| fishbone_ | mriedem: I cross referenced that in those 2 databases and they do match | 01:51 |
| mriedem | ok | 01:51 |
| *** thorst_afk has quit IRC | 01:53 | |
| openstackgerrit | guang-yee proposed openstack/nova master: make sure to rebuild claim on recreate https://review.openstack.org/466143 | 01:56 |
| *** thorst_afk has joined #openstack-nova | 01:58 | |
| *** thorst_afk has quit IRC | 01:58 | |
| *** smatzek_ has joined #openstack-nova | 02:02 | |
| *** gjayavelu has joined #openstack-nova | 02:02 | |
| *** gjayavelu has quit IRC | 02:02 | |
| *** coreywright has quit IRC | 02:02 | |
| openstackgerrit | Wang Shilong proposed openstack/nova master: Lustre support https://review.openstack.org/446288 | 02:03 |
| *** gianpietro has joined #openstack-nova | 02:04 | |
| *** fragatina has quit IRC | 02:07 | |
| *** fragatina has joined #openstack-nova | 02:08 | |
| *** gianpietro has quit IRC | 02:10 | |
| openstackgerrit | Yongfeng Du proposed openstack/nova master: Update the file for IPv4-only or IPv6-only network https://review.openstack.org/465891 | 02:15 |
| *** markvoelker has joined #openstack-nova | 02:15 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add tags fields for server list detail/show api-ref https://review.openstack.org/465842 | 02:16 |
| *** baoli has quit IRC | 02:16 | |
| *** yamahata has quit IRC | 02:18 | |
| fishbone_ | mriedem: it seems to be an issue with the compute hosts themselves, I tried a fresh install with a host that was not already in the nova database and received no errors duing installation | 02:22 |
| *** coreywright has joined #openstack-nova | 02:22 | |
| fishbone_ | mriedem: It must be specific to upgrading a pre-integrated hypervisor | 02:22 |
| *** smatzek_ has quit IRC | 02:24 | |
| *** Apoorva_ has joined #openstack-nova | 02:25 | |
| *** crushil has joined #openstack-nova | 02:25 | |
| *** yamamoto_ has joined #openstack-nova | 02:26 | |
| *** Apoorva_ has quit IRC | 02:26 | |
| *** Apoorva_ has joined #openstack-nova | 02:27 | |
| *** Apoorva_ has quit IRC | 02:27 | |
| *** smatzek has joined #openstack-nova | 02:28 | |
| *** Apoorva has quit IRC | 02:28 | |
| *** gyee has quit IRC | 02:30 | |
| *** yamamoto_ has quit IRC | 02:31 | |
| *** gcb has quit IRC | 02:33 | |
| *** fragatin_ has joined #openstack-nova | 02:36 | |
| *** Sukhdev has joined #openstack-nova | 02:36 | |
| *** fragatina has quit IRC | 02:39 | |
| *** karthiks has quit IRC | 02:40 | |
| *** fragatin_ has quit IRC | 02:40 | |
| fishbone_ | mriedem: it seems simply adding the database directives in the config files allowed the install to go through, perhaps due to the hypervisors being from prior to the cell creation | 02:44 |
| *** karthiks has joined #openstack-nova | 02:45 | |
| *** tuanluong has joined #openstack-nova | 02:46 | |
| *** xinliang has quit IRC | 02:49 | |
| *** armax has joined #openstack-nova | 02:52 | |
| *** crushil_ has joined #openstack-nova | 02:53 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: cached images should be cleaned up by time https://review.openstack.org/465954 | 02:54 |
| *** mvk has quit IRC | 02:54 | |
| mriedem | fishbone_: hmm, not sure | 02:55 |
| mriedem | but cool that you found a workaround | 02:55 |
| mriedem | still, i'd open a bug against the ubuntu packagers, | 02:55 |
| mriedem | the nova-compute package shouldn't be running nova-manage db sync | 02:55 |
| *** mriedem has quit IRC | 02:56 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Should not allow security group from other project pass API layer check when booting https://review.openstack.org/466160 | 02:57 |
| *** gianpietro has joined #openstack-nova | 02:57 | |
| *** crushil_ has quit IRC | 02:59 | |
| *** thorst_afk has joined #openstack-nova | 02:59 | |
| *** crushil_ has joined #openstack-nova | 02:59 | |
| *** xinliang has joined #openstack-nova | 03:01 | |
| *** rfolco has quit IRC | 03:02 | |
| *** baoli has joined #openstack-nova | 03:03 | |
| *** hongbin has joined #openstack-nova | 03:03 | |
| *** Fdaisuke_ has quit IRC | 03:05 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add tags fields for server list detail/show api-ref https://review.openstack.org/465842 | 03:08 |
| fishbone_ | mriedem: yep, it worked after that. I agree with you, I will go and open a bug for this | 03:09 |
| *** rushiagr has quit IRC | 03:09 | |
| *** nicolasbock has quit IRC | 03:10 | |
| *** markvoelker has quit IRC | 03:10 | |
| *** markvoelker has joined #openstack-nova | 03:11 | |
| openstackgerrit | falseuser proposed openstack/nova master: [BugFix] Include the video ram when comparing the difference of two flavors https://review.openstack.org/460388 | 03:12 |
| *** Kevin_Zheng has joined #openstack-nova | 03:15 | |
| *** smatzek has quit IRC | 03:15 | |
| *** markvoelker has quit IRC | 03:15 | |
| *** fishbone_ has quit IRC | 03:17 | |
| *** thorst_afk has quit IRC | 03:19 | |
| *** owalsh_ has joined #openstack-nova | 03:19 | |
| *** mdrabe has joined #openstack-nova | 03:22 | |
| *** owalsh has quit IRC | 03:23 | |
| *** Daisy has joined #openstack-nova | 03:25 | |
| *** baoli has quit IRC | 03:26 | |
| *** mdrabe_ has joined #openstack-nova | 03:27 | |
| *** yamamoto_ has joined #openstack-nova | 03:27 | |
| *** rushiagr has joined #openstack-nova | 03:30 | |
| openstackgerrit | Tao Li proposed openstack/nova master: Fix the display of updated_at time when using memcache driver. https://review.openstack.org/414463 | 03:30 |
| *** gianpietro has quit IRC | 03:30 | |
| *** mdrabe has quit IRC | 03:31 | |
| *** fragatina has joined #openstack-nova | 03:32 | |
| *** yamamoto_ has quit IRC | 03:33 | |
| openstackgerrit | Tao Li proposed openstack/nova master: Change log level from ERROR to DEBUG for NotImplemented https://review.openstack.org/465797 | 03:36 |
| *** fragatina has quit IRC | 03:38 | |
| *** Daisy has quit IRC | 03:38 | |
| *** fragatina has joined #openstack-nova | 03:38 | |
| *** fragatina has quit IRC | 03:38 | |
| *** Daisy has joined #openstack-nova | 03:38 | |
| *** Sukhdev has quit IRC | 03:40 | |
| *** Daisy has quit IRC | 03:42 | |
| *** gianpietro has joined #openstack-nova | 03:45 | |
| *** jamielennox is now known as jamielennox|away | 03:46 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add tags fields for server list detail/show api-ref https://review.openstack.org/465842 | 03:48 |
| *** gianpietro has quit IRC | 03:49 | |
| *** jamielennox|away is now known as jamielennox | 03:53 | |
| *** hongbin has quit IRC | 03:53 | |
| *** vks1 has joined #openstack-nova | 03:56 | |
| openstackgerrit | Tao Li proposed openstack/nova master: Fix the display of updated_at time when using memcache driver. https://review.openstack.org/414463 | 03:59 |
| *** Shunli has quit IRC | 04:02 | |
| *** yamamoto_ has joined #openstack-nova | 04:02 | |
| *** crushil_ has quit IRC | 04:07 | |
| *** mamandle has joined #openstack-nova | 04:09 | |
| *** kaisers has joined #openstack-nova | 04:12 | |
| *** fragatina has joined #openstack-nova | 04:13 | |
| *** jamesdenton has joined #openstack-nova | 04:14 | |
| *** fragatina has quit IRC | 04:15 | |
| *** thorst_afk has joined #openstack-nova | 04:15 | |
| *** fragatina has joined #openstack-nova | 04:15 | |
| *** jamesden_ has joined #openstack-nova | 04:18 | |
| *** prateek has joined #openstack-nova | 04:19 | |
| *** jamesdenton has quit IRC | 04:19 | |
| *** thorst_afk has quit IRC | 04:20 | |
| *** dikonoor has joined #openstack-nova | 04:22 | |
| *** mdrabe_ has quit IRC | 04:25 | |
| *** jamesden_ has quit IRC | 04:27 | |
| *** jamesdenton has joined #openstack-nova | 04:28 | |
| *** jamesdenton has quit IRC | 04:33 | |
| *** crushil_ has joined #openstack-nova | 04:35 | |
| *** crushil has quit IRC | 04:36 | |
| *** Daisy has joined #openstack-nova | 04:41 | |
| *** Daisy has quit IRC | 04:49 | |
| *** salv-orlando has joined #openstack-nova | 04:50 | |
| *** Apoorva has joined #openstack-nova | 04:53 | |
| *** Daisy has joined #openstack-nova | 05:01 | |
| *** salv-orlando has quit IRC | 05:07 | |
| *** adisky_ has joined #openstack-nova | 05:08 | |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: xenapi: cached images should be cleaned up by time https://review.openstack.org/465954 | 05:14 |
| *** gjayavelu has joined #openstack-nova | 05:16 | |
| *** thorst_afk has joined #openstack-nova | 05:16 | |
| *** Apoorva has quit IRC | 05:17 | |
| *** thorst_afk has quit IRC | 05:20 | |
| *** udesale has joined #openstack-nova | 05:24 | |
| *** claudiub has joined #openstack-nova | 05:25 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add tags fields for server list detail/show api-ref https://review.openstack.org/465842 | 05:26 |
| *** slaweq has joined #openstack-nova | 05:27 | |
| *** slaweq has quit IRC | 05:28 | |
| *** ltomasbo|away is now known as ltomasbo | 05:37 | |
| *** jaosorior_away has quit IRC | 05:44 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021 | 05:47 |
| *** coreywright has quit IRC | 05:47 | |
| *** mkoderer has quit IRC | 05:47 | |
| *** ratailor has joined #openstack-nova | 05:49 | |
| *** armax has quit IRC | 05:52 | |
| *** crushil_ has quit IRC | 05:54 | |
| *** mdnadeem has joined #openstack-nova | 06:00 | |
| *** trungnv has quit IRC | 06:03 | |
| *** coreywright has joined #openstack-nova | 06:04 | |
| *** mamandle has quit IRC | 06:04 | |
| *** Oku_OS-away is now known as Oku_OS | 06:04 | |
| *** mamandle has joined #openstack-nova | 06:07 | |
| *** salv-orlando has joined #openstack-nova | 06:08 | |
| *** psachin has quit IRC | 06:09 | |
| *** dimtruck is now known as zz_dimtruck | 06:09 | |
| *** sree has joined #openstack-nova | 06:09 | |
| *** markus_z has joined #openstack-nova | 06:11 | |
| *** salv-orlando has quit IRC | 06:13 | |
| *** rcernin has joined #openstack-nova | 06:13 | |
| *** diablo_rojo has joined #openstack-nova | 06:16 | |
| *** thorst_afk has joined #openstack-nova | 06:17 | |
| *** thorst_afk has quit IRC | 06:21 | |
| *** psachin has joined #openstack-nova | 06:24 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Use PCIAddressField in oslo.versionedobjects https://review.openstack.org/466201 | 06:29 |
| *** phuongnh has quit IRC | 06:30 | |
| *** phuongnh has joined #openstack-nova | 06:30 | |
| *** diablo_rojo has quit IRC | 06:31 | |
| *** diablo_rojo has joined #openstack-nova | 06:32 | |
| *** pcaruana has joined #openstack-nova | 06:39 | |
| *** pcaruana is now known as pcaruana|tve| | 06:44 | |
| *** pcaruana|tve| is now known as pcaruana|rtve| | 06:44 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: WIP: XenAPI use os-xenapi v2 in nova https://review.openstack.org/453493 | 06:46 |
| openstackgerrit | Wang Shilong proposed openstack/nova master: Lustre support https://review.openstack.org/446288 | 06:50 |
| *** belmoreira has joined #openstack-nova | 07:01 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: XenAPI: remove hardcode dom0 plugin function mock https://review.openstack.org/466207 | 07:04 |
| *** mnestratov has joined #openstack-nova | 07:08 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: XenAPI: remove hardcode dom0 plugin version in unit test https://review.openstack.org/466207 | 07:08 |
| *** salv-orlando has joined #openstack-nova | 07:09 | |
| *** salv-orlando has quit IRC | 07:13 | |
| *** phuongnh has quit IRC | 07:13 | |
| *** mlakat has joined #openstack-nova | 07:14 | |
| *** phuongnh has joined #openstack-nova | 07:14 | |
| *** thorst_afk has joined #openstack-nova | 07:17 | |
| *** johnhaan has quit IRC | 07:19 | |
| *** thorst_afk has quit IRC | 07:22 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483 | 07:24 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483 | 07:32 |
| *** jpena|off is now known as jpena | 07:38 | |
| *** _dpawlik is now known as dpawlik | 07:48 | |
| *** ralonsoh has joined #openstack-nova | 07:49 | |
| openstackgerrit | Daniel Pawlik proposed openstack/nova master: Added kvm_hidden feature https://review.openstack.org/459753 | 07:51 |
| dpawlik | Morning | 07:51 |
| *** diablo_rojo has quit IRC | 07:56 | |
| *** gszasz has joined #openstack-nova | 07:59 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** takashin has left #openstack-nova | 08:00 | |
| *** zzzeek has joined #openstack-nova | 08:02 | |
| *** Daisy has quit IRC | 08:05 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/449257 | 08:06 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Add Neutron port capabilities to devspec in request https://review.openstack.org/451777 | 08:08 |
| *** salv-orlando has joined #openstack-nova | 08:10 | |
| *** Kevin_Zheng has quit IRC | 08:15 | |
| *** salv-orlando has quit IRC | 08:16 | |
| *** derekh has joined #openstack-nova | 08:16 | |
| *** Alex____ has joined #openstack-nova | 08:18 | |
| *** thorst_afk has joined #openstack-nova | 08:18 | |
| *** litao__ has quit IRC | 08:19 | |
| *** djohnsto has joined #openstack-nova | 08:20 | |
| *** thorst_afk has quit IRC | 08:23 | |
| *** knikolla has joined #openstack-nova | 08:24 | |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | 08:24 |
| *** swamireddy has joined #openstack-nova | 08:24 | |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | 08:26 |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | 08:26 |
| *** jaosorior has joined #openstack-nova | 08:29 | |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Refactor init_instance:resume_guests_state https://review.openstack.org/349582 | 08:32 |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | 08:38 |
| *** lpetrut has joined #openstack-nova | 08:39 | |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Refactor instance-exists comment and test https://review.openstack.org/462738 | 08:43 |
| *** Yangyapeng has quit IRC | 08:45 | |
| sfinucan | mdbooth: Seeing as you reviewed the original patch, does this patch follow-up make sense? https://review.openstack.org/#/c/466088/ | 08:47 |
| *** hferenc has quit IRC | 08:49 | |
| *** hferenc has joined #openstack-nova | 08:54 | |
| *** salv-orlando has joined #openstack-nova | 09:00 | |
| *** xinliang has quit IRC | 09:00 | |
| sfinucan | ralonsoh: You about? | 09:03 |
| ralonsoh | sfinucan: hi! | 09:04 |
| sfinucan | ralonsoh: On https://review.openstack.org/#/c/449257/ - that usually happens when you accidentally re-upload an old revision | 09:04 |
| sfinucan | I would imagine you've reuploaded PS18 when you reuploaded the following patch | 09:05 |
| ralonsoh | sfinucan: hmmm, I'll check that, but I'm pretty sure I didn't do this | 09:05 |
| ralonsoh | sfinucan: but thank you for your explanation! | 09:05 |
| *** salv-orlando has quit IRC | 09:06 | |
| sfinucan | fwiw, you can fix it by downloading the last correct PS from the first patch (probably 20, so 'git review -d 449257,20') | 09:06 |
| ralonsoh | sfinucan: thanks! | 09:06 |
| sfinucan | ralonsoh: np ;) | 09:06 |
| *** gjayavelu has quit IRC | 09:07 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/449257 | 09:07 |
| *** rwmjones has quit IRC | 09:10 | |
| *** xinliang has joined #openstack-nova | 09:11 | |
| *** vks1 has quit IRC | 09:17 | |
| *** gszasz has quit IRC | 09:19 | |
| *** thorst_afk has joined #openstack-nova | 09:19 | |
| *** rwmjones has joined #openstack-nova | 09:21 | |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: update the logic to configure volume with scsi controller https://review.openstack.org/459741 | 09:25 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: update logic to configure device for scsi controller https://review.openstack.org/459740 | 09:25 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: update LibvirtConfigGuestDeviceAddress to provide XML https://review.openstack.org/459737 | 09:25 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: rearange how scsi controller is defined https://review.openstack.org/459739 | 09:25 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: set full description of the controller used by disk https://review.openstack.org/459738 | 09:25 |
| *** vks1 has joined #openstack-nova | 09:31 | |
| mdbooth | sfinucan: Eurgh, that whole situation is a complete pita | 09:33 |
| sfinucan | mdbooth: Yup | 09:33 |
| *** hshiina has joined #openstack-nova | 09:33 | |
| sfinucan | But it's a rabbit hole I really don't fancy diving down | 09:34 |
| mdbooth | It's a rabbit hole which shouldn't exist | 09:34 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: configure trust mode for vfs https://review.openstack.org/458514 | 09:36 |
| openstackgerrit | sahid proposed openstack/nova master: network: update pci request spec to handle trusted tags https://review.openstack.org/458820 | 09:36 |
| openstackgerrit | sahid proposed openstack/nova master: network: add command to configure trusted mode for VFs https://review.openstack.org/458513 | 09:36 |
| *** thorst_afk has quit IRC | 09:38 | |
| *** sambetts|afk is now known as sambetts | 09:46 | |
| mdbooth | sfinucan: It should have been obvious from the previous bug that EPERM was wrong. I wonder why we didn't pick that up last time. | 09:53 |
| * mdbooth puts it down to stupid naming | 09:53 | |
| mdbooth | [Errno 13] Permission denied | 09:53 |
| mdbooth | 13 == EACCES | 09:53 |
| sfinucan | mdbooth: I know :( | 09:53 |
| sfinucan | Isn't EPERM a superset of EACCES though? | 09:54 |
| mdbooth | They're discrete | 09:54 |
| mdbooth | This is the return from a syscall | 09:54 |
| mdbooth | It's an integer | 09:54 |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | 09:55 |
| *** openstack has joined #openstack-nova | 09:58 | |
| mdbooth | melwitt: KABOOM! | 09:59 |
| melwitt | heh, sorry bout that folks | 09:59 |
| *** owalsh_ is now known as owalsh | 09:59 | |
| *** pjm6 has joined #openstack-nova | 09:59 | |
| *** salv-orlando has joined #openstack-nova | 10:02 | |
| *** salv-orlando has quit IRC | 10:06 | |
| *** tbachman has joined #openstack-nova | 10:06 | |
| *** nicolasbock has joined #openstack-nova | 10:09 | |
| *** yamamoto_ has quit IRC | 10:10 | |
| *** p01nt3r75 has joined #openstack-nova | 10:13 | |
| *** psachin has quit IRC | 10:20 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: remove cpuset_reserved from __init__ of InstanceNUMATopology https://review.openstack.org/466030 | 10:29 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: remove related pinning from __init__ of InstanceNUMATopology https://review.openstack.org/408242 | 10:29 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: remove pagesize from __init__ of InstanceNUMATopology https://review.openstack.org/408241 | 10:29 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Use plain routes list for os-interface endpoint instead of stevedore https://review.openstack.org/459979 | 10:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Use plain routes list for server-tags instead of stevedore https://review.openstack.org/461645 | 10:31 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Use plain routes list for server-migrations endpoint instead of stevedore https://review.openstack.org/461646 | 10:31 |
| *** mkoderer has joined #openstack-nova | 10:31 | |
| *** aarefiev_afk is now known as aarefiev | 10:34 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove useless API tests https://review.openstack.org/461011 | 10:35 |
| *** yamamoto has joined #openstack-nova | 10:38 | |
| *** sdague has joined #openstack-nova | 10:41 | |
| *** tbachman has quit IRC | 10:44 | |
| *** lucasagomes is now known as lucas-brb | 10:46 | |
| *** gszasz has joined #openstack-nova | 10:50 | |
| *** cdent has joined #openstack-nova | 10:52 | |
| *** avolkov has joined #openstack-nova | 10:55 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Scheduler returning alternatives per destination https://review.openstack.org/465175 | 10:56 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Delete existing allocations when retrying https://review.openstack.org/460433 | 10:56 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Allocate instance by the conductor https://review.openstack.org/460455 | 10:56 |
| *** tuanluong has quit IRC | 10:59 | |
| cdent | bauzas: thanks for expanding the commit message on the retrying change. Can you confirm my understanding: the goal is to delete transient allocations (which aren't currently using physical resources) as soon as we know they are going to be eventually deleted, so that something else can try to consume them sooner. | 11:00 |
| cdent | Is that right? | 11:00 |
| bauzas | cdent: the goal is to propose hosts that can be acceptable per filters/weighers in case the original host is not being accepted when the conductor posts the allocations | 11:01 |
| bauzas | cdent: given we have placement that verifies allocations, it's fine to propose hosts that are not fulling matching with the *new* situation, but at least have been verified as matching with the other requests | 11:02 |
| cdent | I'm speaking specifically about the allocations that could have been cleared up later at the time NoValidHost happens | 11:02 |
| *** salv-orlando has joined #openstack-nova | 11:02 | |
| bauzas | cdent: so, there are 2 cases | 11:02 |
| bauzas | cdent: 1/ if the conductor posts an allocation but gets a "sorry" from placement | 11:03 |
| *** psachin has joined #openstack-nova | 11:03 | |
| *** tovin07_ has quit IRC | 11:03 | |
| bauzas | cdent: 2/ if the allocation is done correctly, but then the compute exceptionnally has an exception (because of libvirt-ish so else) and then reschedules the instance to the conductor | 11:03 |
| bauzas | cdent: if scheduler gives back a NoValidHosts to conductor, then the conductor will behave like the existing | 11:04 |
| bauzas | (unless I misunderstood your problem, which is definitely something possible :D ) | 11:05 |
| bauzas | cdent: oh , you mean about the need for https://review.openstack.org/#/c/460433/10 ? | 11:07 |
| bauzas | (sorry my bad) | 11:07 |
| bauzas | I thought you were talking of the need for alternatives | 11:07 |
| cdent | I'm talking about my question on ps 8 on https://review.openstack.org/#/c/460433 about why we are deleting allocations early (instead of waiting to handle them on NoValidHost) and trying to confirm my understanding of your adjustments to the commit message there | 11:07 |
| *** salv-orlando has quit IRC | 11:07 | |
| bauzas | ok, my bad | 11:07 |
| bauzas | so | 11:07 |
| bauzas | the problem is with transient allocations like I said | 11:07 |
| bauzas | imagine the scenario | 11:07 |
| cdent | basically if you can confirm "so that something else can try to consume them sooner" is correct, I'm satisfied | 11:08 |
| bauzas | Ironic and 2 concurrent instances | 11:08 |
| bauzas | instance 1 is scheduled to hostA | 11:08 |
| bauzas | then the allocation will be made against hostA | 11:08 |
| bauzas | but then it's rescheduled | 11:08 |
| bauzas | concurrently, instance2 is scheduled | 11:08 |
| bauzas | given allocation is posted against hostA, placement won't provide hostA as a valid target | 11:09 |
| bauzas | which is a sad panda, because we know it's being rescheduled | 11:09 |
| bauzas | cdent: does that fit with your concerns ? | 11:09 |
| bauzas | tbh, I'm not super attached to that patch, I just think it helps some possible race condition | 11:10 |
| *** jichen has joined #openstack-nova | 11:10 | |
| cdent | when instance1 tries to go to hostA but then is rescheduled, what does that mean about the current state of hostA as a good target for any allocations? | 11:11 |
| bauzas | cdent: FWIW, I'm not trying to focus my efforts on updating https://review.openstack.org/#/c/460455/ now that we have alternatives | 11:11 |
| bauzas | cdent: instance being rescheduler doesn't necessarly imply that the host where the instance was set to is necessary bad | 11:12 |
| bauzas | cdent: we discussed that at Summit, and we identified (ops too) that most of the time, it's uncorrelated with resource constraints | 11:12 |
| cdent | but it could be, right? | 11:12 |
| cdent | I guess I take a relatively conservative position on this stuff: I think we can avoid inaccuracies and confusion by holding allocations a bit longer, at the cost of less packing. But it seems that people are more interested in packing? | 11:14 |
| bauzas | cdent: that's a good point | 11:14 |
| bauzas | cdent: from what I recall from the summit, people wanted to make sure we were not removing some host because of a resource constraint, because they said most of the time it's because of X or Y | 11:15 |
| bauzas | cdent: were you at the cells 2 forum session where most of the crux was discussed there ? | 11:16 |
| *** edmondsw has joined #openstack-nova | 11:16 | |
| bauzas | cdent: as dan asked whether they were interested in stopping to reschedules | 11:16 |
| bauzas | cdent: most of the present folks were horrified by that | 11:16 |
| bauzas | anyway, I need to disappear for a bit | 11:16 |
| cdent | i had to be somewhere else for that one, but i heard a summary later | 11:17 |
| cdent | me too, I'll keep thinking about it. thanks for the info. | 11:17 |
| *** mamandle has quit IRC | 11:18 | |
| *** jpena is now known as jpena|lunch | 11:18 | |
| *** udesale has quit IRC | 11:19 | |
| bauzas | np | 11:19 |
| *** phuongnh has quit IRC | 11:23 | |
| *** smatzek has joined #openstack-nova | 11:24 | |
| *** yamamoto has quit IRC | 11:26 | |
| openstackgerrit | Hironori Shiina proposed openstack/nova master: Ironic: Support boot from Cinder volume https://review.openstack.org/215385 | 11:29 |
| *** yamamoto has joined #openstack-nova | 11:29 | |
| *** brault has joined #openstack-nova | 11:31 | |
| *** hamzy has joined #openstack-nova | 11:32 | |
| *** thorst_afk has joined #openstack-nova | 11:35 | |
| *** pchavva has joined #openstack-nova | 11:42 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Document 'nova-manage db online_data_migrations' https://review.openstack.org/464634 | 11:44 |
| *** gianpietro has joined #openstack-nova | 11:48 | |
| *** tbachman has joined #openstack-nova | 11:52 | |
| *** pchavva has quit IRC | 11:53 | |
| *** gianpietro has quit IRC | 11:56 | |
| *** ratailor has quit IRC | 11:59 | |
| *** pchavva has joined #openstack-nova | 12:01 | |
| *** Alex____ has quit IRC | 12:02 | |
| *** salv-orlando has joined #openstack-nova | 12:03 | |
| *** faizy has quit IRC | 12:04 | |
| *** tbachman_ has joined #openstack-nova | 12:05 | |
| *** tbachman has quit IRC | 12:05 | |
| *** tbachman_ is now known as tbachman | 12:05 | |
| *** abalutoiu_ has quit IRC | 12:07 | |
| *** abalutoiu has joined #openstack-nova | 12:07 | |
| *** salv-orlando has quit IRC | 12:08 | |
| *** liverpooler has joined #openstack-nova | 12:11 | |
| *** vks1 has quit IRC | 12:14 | |
| *** lucas-brb is now known as lucasagomes | 12:15 | |
| *** jistr is now known as jistr|mtg | 12:16 | |
| *** jpena|lunch is now known as jpena | 12:17 | |
| *** sean-k-mooney has quit IRC | 12:18 | |
| *** dave-mccowan has joined #openstack-nova | 12:27 | |
| *** gianpietro has joined #openstack-nova | 12:29 | |
| *** winston-d_ has quit IRC | 12:33 | |
| *** tbachman has quit IRC | 12:44 | |
| *** catintheroof has joined #openstack-nova | 12:45 | |
| *** psachin has quit IRC | 12:45 | |
| *** gianpietro has quit IRC | 12:46 | |
| *** Guest6334 has quit IRC | 12:46 | |
| *** rfolco has joined #openstack-nova | 12:47 | |
| *** tbachman has joined #openstack-nova | 12:47 | |
| *** zz_dimtruck is now known as dimtruck | 12:48 | |
| *** kylek3h has joined #openstack-nova | 12:50 | |
| *** sree has quit IRC | 12:52 | |
| *** sree has joined #openstack-nova | 12:52 | |
| *** Guest6334 has joined #openstack-nova | 12:53 | |
| *** mdrabe_ has joined #openstack-nova | 12:56 | |
| *** jichen has quit IRC | 12:56 | |
| *** sree_ has joined #openstack-nova | 12:56 | |
| *** sree_ is now known as Guest48386 | 12:56 | |
| *** sree has quit IRC | 12:57 | |
| *** mriedem has joined #openstack-nova | 12:57 | |
| mriedem | o/ | 12:58 |
| *** gianpietro has joined #openstack-nova | 12:58 | |
| *** salv-orlando has joined #openstack-nova | 12:59 | |
| *** jistr|mtg is now known as jistr | 12:59 | |
| mriedem | sdague: this gets the grenade live migration job going again (limited) https://review.openstack.org/#/c/466097/ and this gets the live migration back and forth testing going in that job https://review.openstack.org/#/c/466033/ | 12:59 |
| *** Guest48386 has quit IRC | 13:01 | |
| sdague | mriedem: +A | 13:01 |
| mriedem | thanks | 13:01 |
| *** gianpietro has quit IRC | 13:03 | |
| dpawlik | mriedem: Hi. I changed as you suggest in PS https://review.openstack.org/#/c/459753 | 13:06 |
| bauzas | mriedem: I replied on your status email about the claims discussion | 13:06 |
| bauzas | mriedem: AFAIUI, we already had a consensus :) | 13:06 |
| *** yamamoto has quit IRC | 13:07 | |
| *** jamesdenton has joined #openstack-nova | 13:07 | |
| mriedem | bauzas: i see that | 13:09 |
| *** sree has joined #openstack-nova | 13:10 | |
| mriedem | dpawlik: ok, it's not a bug though, it's a feature, so it should have a blueprint | 13:10 |
| *** tbachman has quit IRC | 13:13 | |
| *** edmondsw has quit IRC | 13:13 | |
| *** edmondsw has joined #openstack-nova | 13:14 | |
| *** MVenesio has joined #openstack-nova | 13:14 | |
| *** sree has quit IRC | 13:15 | |
| *** ralonsoh_ has joined #openstack-nova | 13:15 | |
| *** yamahata has joined #openstack-nova | 13:16 | |
| *** salv-orlando has quit IRC | 13:16 | |
| dpawlik | mriedem: ack | 13:16 |
| *** salv-orlando has joined #openstack-nova | 13:16 | |
| *** zzzeek has quit IRC | 13:17 | |
| *** yamamoto has joined #openstack-nova | 13:17 | |
| cdent | bauzas, mriedem: I threw my own crazy talk 2c into the mix too because I'm lonely and want to make friends. | 13:17 |
| *** zzzeek has joined #openstack-nova | 13:17 | |
| *** ralonsoh has quit IRC | 13:18 | |
| *** edmondsw has quit IRC | 13:18 | |
| *** salv-orlando has quit IRC | 13:21 | |
| *** tbachman has joined #openstack-nova | 13:21 | |
| *** yamamoto has quit IRC | 13:22 | |
| *** mdrabe__ has joined #openstack-nova | 13:22 | |
| *** yamamoto has joined #openstack-nova | 13:23 | |
| *** ralonsoh_ is now known as ralonsoh | 13:23 | |
| mdbooth | mriedem: Do we have a pattern for internal code assertions other than assert() ? We don't seem to have too many assert()s in our code. | 13:24 |
| *** aarefiev is now known as aarefiev_afk | 13:24 | |
| mdbooth | mriedem: I ask in the context of https://review.openstack.org/#/c/443951/ where I've recommended he use assert() rather than raise an exception | 13:24 |
| mriedem | mdbooth: not really | 13:25 |
| *** mdrabe_ has quit IRC | 13:25 | |
| mdbooth | mriedem: Ok, cool. Was just wary of asking him to fix that, only to have him respin yet again because we do something else. | 13:26 |
| cdent | mdbooth++ for assert in programming error case | 13:26 |
| dpawlik | mriedem: https://blueprints.launchpad.net/nova/+spec/add-kvm-hidden-feature | 13:27 |
| mriedem | mdbooth: did you see my beautiful code dive through attaching a volume during bfv and attach_volume? what a mess. | 13:27 |
| dpawlik | I will change PS commit message soon | 13:27 |
| mriedem | kashyap: are you aware of this kvm hidden feature thing? | 13:28 |
| mriedem | ^ | 13:28 |
| mdbooth | mriedem: I did :) I took a short cut to convincing myself that was correct. | 13:28 |
| * kashyap reads the scrollback | 13:28 | |
| mriedem | mdbooth: at some point i should probably write that up in the devref, but... | 13:28 |
| kashyap | I think I know what it means from the title | 13:28 |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Add method for verify multiple notifications https://review.openstack.org/465526 | 13:28 |
| *** vks1 has joined #openstack-nova | 13:29 | |
| mdbooth | mriedem: Logically, that method makes no sense unless the volume is connected | 13:29 |
| mriedem | dpawlik: kashyap: I don't know what "It allows to hide the KVM hypervisor signature on the guest. | 13:29 |
| mriedem | This enables disabling of some paravirualization features in the | 13:29 |
| mriedem | guest as well as allowing certain drivers which test for the | 13:29 |
| mriedem | hypervisor to load." means | 13:29 |
| mriedem | mdbooth: which one? get_config? | 13:29 |
| mdbooth | Yeah | 13:29 |
| mriedem | mdbooth: yeah it's super tightly coupled, | 13:29 |
| mdbooth | If the connector hasn't connected it, we can't tell libvirt where it's connected | 13:29 |
| kashyap | mriedem: Okay, I'm aware of what it is, it means: | 13:29 |
| mriedem | we should almost just refactor to have connect_volume always return get_config... | 13:29 |
| mriedem | but we have that live migration case | 13:29 |
| kashyap | mriedem: It just lets one _hide_ the fact that it is a KVM guest | 13:30 |
| kashyap | But removing the CPUID signature for guest that is running w/ KVM acceleration | 13:30 |
| kashyap | dpawlik: Are you referring to the "-no-kvm" QEMU command-line option, right? | 13:31 |
| mriedem | hide it from what? | 13:31 |
| *** krtaylor has joined #openstack-nova | 13:31 | |
| kashyap | mriedem: Hide it from whatever programs that depend on that output to identify: "Yes, this is a KVM guest" | 13:31 |
| *** tbachman has quit IRC | 13:31 | |
| mriedem | alright | 13:31 |
| *** mnestratov has quit IRC | 13:32 | |
| kashyap | It is possible via the confusingly-named, QEMU command-line option '-cpu,kvm=off' | 13:33 |
| kashyap | Which doesn't turn off KVM acceleration itself, merely the *signature* of it | 13:34 |
| kashyap | You might wonder what exactly the **** is this "signature"? | 13:34 |
| bauzas | cdent: FWIW, I'm not disagreeing with you on the long-term direction to see claims closer | 13:34 |
| mriedem | cdent: so reading https://review.openstack.org/#/c/465171/3//COMMIT_MSG@30 i didn't realize that what ed is trying to do is make the nova-scheduler something that other projects are going to use | 13:34 |
| mriedem | i.e. gantt 2.0 | 13:34 |
| bauzas | cdent: I just think it needs to wait scheduler to be a library | 13:34 |
| mriedem | we all agree that placement is generic and will be used by other projects | 13:34 |
| cdent | bauzas: I've not felt like anyone is disagreeing, merely discussing | 13:35 |
| kashyap | mriedem: The thing that exactly hides is this output that you normally see from the command `cpuid`: | 13:35 |
| kashyap | $ cpuid | grep -i hypervisor_id | 13:35 |
| kashyap | hypervisor_id = "KVMKVMKVM " | 13:35 |
| mriedem | kashyap: that's within the guest? | 13:35 |
| bauzas | cdent: but I do recall Jay and us being pretty clear on the fact that the scheduler code is not intended mid-term to be generic | 13:35 |
| kashyap | mriedem: Yes | 13:35 |
| *** esberglu has joined #openstack-nova | 13:35 | |
| cdent | mriedem: it's something ed said to me at some point in the conversation about "i don't think of the scheduler as 'nova'" and tickled my brain enough to write down explicitly | 13:35 |
| bauzas | cdent: the idea is that placement is cross-project but scheduler is a nova-ism | 13:35 |
| bauzas | (to reuse ed's wording) | 13:36 |
| dpawlik | kashyap: yes (answer for your first question) | 13:36 |
| cdent | bauzas: that may be the idea, but it may be that we don't want to build in things that make it hard to change our minds | 13:36 |
| bauzas | so we could ship the scheduler code into a python module only used by conductors like I said in my reply | 13:36 |
| kashyap | dpawlik: Are you depending exactly on the precise "-no-kvm" option? | 13:36 |
| kashyap | dpawlik: If so, that is being considered for deprecation (in favor of "-cpu,kvm=off") | 13:37 |
| bauzas | cdent: but for me, that sounds premature to discuss on your point, at least until we're fully down the path | 13:37 |
| mriedem | bauzas: cdent: oh boy, ok, well, splitting nova-scheduler out or making it separate for other services to consume is not something i think most anyone besides maybe ed is thinking about | 13:37 |
| bauzas | mriedem: yup, what I told to ed | 13:37 |
| cdent | mriedem: not splitting out _now_, just ensuring it is not hard to do later | 13:37 |
| bauzas | I think ed had that point | 13:38 |
| bauzas | but I'm not seeing it strong enough to justify us to have scheduler doing allocations calls | 13:38 |
| cdent | which means making the interface generic and not very nova-ish | 13:38 |
| mriedem | has any other project even expressed interest in re-using nova-scheduler? | 13:38 |
| *** tbachman has joined #openstack-nova | 13:38 | |
| bauzas | mriedem: in YVR, we had a session about gantt | 13:38 |
| cdent | mriedem: I don't know, that's why I made my comment in the form of a question | 13:39 |
| bauzas | mriedem: litterally nobody expressed interest in it | 13:39 |
| bauzas | hence why we stepped back from that idea | 13:39 |
| *** smatzek has quit IRC | 13:39 | |
| mriedem | well, and gantt was completely premature | 13:39 |
| openstackgerrit | Pavel Gluschak (scsnow) proposed openstack/nova master: VStorage: changed default log path https://review.openstack.org/458557 | 13:39 |
| bauzas | also, the BM/VM session told about that possible scope | 13:39 |
| cdent | but also I think a lot of the lack of interest was based on a misunderstanding of what placement is going to be capable of | 13:39 |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | 13:39 |
| cdent | what placement can do it actually quite limited | 13:39 |
| cdent | and any client of it is going to need to pick (somehow) from the results | 13:40 |
| bauzas | and tbc, most of the people expressed usecases in multi-projects affinity, but noone stated the need for placing things other than instances (yet) | 13:40 |
| bauzas | I made that question very explicit | 13:40 |
| bauzas | and I all heard about affinity, not generic placement engine | 13:40 |
| *** prateek has quit IRC | 13:41 | |
| kashyap | mriedem: Will look the change, I see it is https://review.openstack.org/#/c/459753 | 13:41 |
| bauzas | so, if you consider the approach step-wise, I think having the conductor workers responsible for doing the allocations is cool if we eventually end up with filter/weigher code owned by them | 13:41 |
| mriedem | kashyap: yeah | 13:41 |
| mriedem | kashyap: we're past any sort of spec freeze, but this doesn't require a spec, and is basic passthrough feature functionality via image meta | 13:42 |
| *** felipemonteiro has joined #openstack-nova | 13:42 | |
| mriedem | the description of the feature was just not clear to me | 13:42 |
| kashyap | Yeah, libvirt has a simple XML mapping: | 13:42 |
| kashyap | <kvm> | 13:42 |
| kashyap | <hidden state='on'/> | 13:42 |
| kashyap | </kvm> | 13:42 |
| kashyap | mriedem: Yeah, hope the CPU ID example shows it | 13:42 |
| mriedem | i see part of it was pulled from the original patch to add this to qemu | 13:42 |
| mriedem | which was also confusing to me | 13:42 |
| mriedem | so is the idea that someone won't know if they're talking to a vm or not? | 13:43 |
| kashyap | mriedem: Yeah, it should be reworded and explained in context of Nova | 13:43 |
| mriedem | b/c that's hidden? | 13:43 |
| *** felipemonteiro_ has joined #openstack-nova | 13:43 | |
| kashyap | mriedem: Yeah, I also wonderered, like you, first when I came across this: "What is the use case of this?" | 13:43 |
| *** tbachman has quit IRC | 13:44 | |
| kashyap | Apparently, some proprietary nVIDIA drivers can be installed _if_ they don't see this 'hypervisor_id' option under `cpuid` | 13:44 |
| *** tbachman has joined #openstack-nova | 13:44 | |
| kashyap | mriedem: This commit message that actually added the option in upstream QEMU will tell you the reason: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=f522d2a | 13:45 |
| dpawlik | kashyap: exactly | 13:45 |
| kashyap | "The latest Nvidia driver (337.88) specifically checks for KVM as the | 13:45 |
| kashyap | hypervisor and reports Code 43 for the driver in a Windows guest when | 13:45 |
| kashyap | found. Removing or changing the KVM signature is sufficient for the | 13:45 |
| kashyap | driver to load and work." | 13:45 |
| dpawlik | kashyap: ack | 13:45 |
| *** esberglu has quit IRC | 13:45 | |
| *** eharney has joined #openstack-nova | 13:46 | |
| dpawlik | kashyap: should I also add the url for qemu git or its not necessary? | 13:46 |
| kashyap | dpawlik: I'll respond on the review | 13:46 |
| *** felipemonteiro has quit IRC | 13:47 | |
| *** esberglu has joined #openstack-nova | 13:47 | |
| *** edmondsw has joined #openstack-nova | 13:47 | |
| *** dimtruck is now known as zz_dimtruck | 13:47 | |
| mriedem | why does the nvidia driver fail to load in that case? | 13:48 |
| *** mdnadeem has quit IRC | 13:48 | |
| mriedem | isn't that a huge workaround? | 13:48 |
| mriedem | so, you can get vgpus on this guest if you hide the fact that it's a guest? | 13:49 |
| mriedem | but why does that nvidia driver care in the first place? | 13:49 |
| *** ratailor has joined #openstack-nova | 13:50 | |
| dpawlik | mriedem: its a good question for nvidia developers. Maybe one of the reason is bitcoin mining | 13:50 |
| dansmith | mriedem: lots of software people have tried to limit running their stuff in a VM, supposedly for licensing reasons | 13:50 |
| dansmith | it's not usually a very fruitful endeavor given that the hypervisor software is easy to change and the whole point of it is to _emulate_ something :) | 13:51 |
| dpawlik | dansmith: +1 | 13:51 |
| dansmith | kinda like most DRM.. annoying for everyone, but only buys you like 6 months of copy protection until people bust it up | 13:51 |
| *** burt has joined #openstack-nova | 13:52 | |
| *** salv-orlando has joined #openstack-nova | 13:54 | |
| kashyap | mriedem: Let me ask Alex, the QEMU developer who wrote that commit | 13:55 |
| *** jmlowe has quit IRC | 13:56 | |
| mriedem | dpawlik: dansmith: kashyap: ok that makes more sense then, and was kind of what i'm looking for - the commit message and release note were just a bit cryptic | 13:56 |
| mriedem | i wanted something in there about why we'd want to enable this feature, rather than that we just can so let's do it | 13:57 |
| kashyap | mriedem: Yes, the commit message and the rel-note should definitely be improved | 13:57 |
| dpawlik | kashyap, mriedem: working on it | 13:58 |
| *** smatzek has joined #openstack-nova | 14:00 | |
| kashyap | Also, this should be called, 'kvm_hypervisor_id_hidden' -- maybe a tad too lengthy, but damn clear than "kvm_hidden", which will make people think: "Oh, this will disable KVM completely!" | 14:00 |
| dansmith | I think it should not say kvm at all | 14:00 |
| *** crushil has joined #openstack-nova | 14:01 | |
| mriedem | hide_hypervisor_id | 14:01 |
| mriedem | maybe | 14:01 |
| kashyap | dansmith: It is hiding the KVM signature -- "KVMKVMKVM\0\0\0" | 14:02 |
| dansmith | kashyap: sure but we don't want to end up with a xen_hide_id flag separate | 14:02 |
| kashyap | I also say mentioning it useful because, there's upstream QEMU work to also add "TCG" disabling, too | 14:02 |
| *** eharney has quit IRC | 14:03 | |
| kashyap | dansmith: Yeah, I see what you mean, at Nova-level, you want a generic conf, that can handle different hypervisors (let they be KVM, TCG, Xen, etc) | 14:04 |
| dansmith | yes | 14:04 |
| kashyap | You're correct, mriedem's 'hide_hypervisor_id' sounds best to me | 14:05 |
| *** jmlowe has joined #openstack-nova | 14:07 | |
| *** eharney has joined #openstack-nova | 14:07 | |
| sdague | or secret_agent_mode :) | 14:07 |
| * cdent sings | 14:08 | |
| kashyap | sdague: Heh | 14:08 |
| kashyap | sdague: You mean, enable_backdoor | 14:09 |
| *** zz_dimtruck is now known as dimtruck | 14:09 | |
| * cdent sings a different song | 14:09 | |
| sfinucan | Morning, mriedem. Could you take a shot at [1] again today? https://review.openstack.org/#/q/status:open+project:openstack/nova+topic:bp/move-nova-cmds-to-cliff | 14:10 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged nic attachment https://review.openstack.org/415622 | 14:11 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete nic metadata when detaching interface https://review.openstack.org/435387 | 14:11 |
| mriedem | maybe | 14:11 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082 | 14:11 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged volume attachment https://review.openstack.org/391941 | 14:12 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021 | 14:12 |
| mriedem | sdague: oomichi: mtreinish: i just noticed this bug again https://bugs.launchpad.net/nova/+bug/1634668 | 14:12 |
| openstack | Launchpad bug 1634668 in OpenStack Compute (nova) "Compute API Reference - version response doesn't require 'updated'" [Medium,Confirmed] | 14:12 |
| sfinucan | maybe will do | 14:12 |
| mriedem | about how tempest checks that 'updated' is in the version response, and that test is part of defcore | 14:12 |
| mriedem | would it be wrong to remove that from the tempest schema response validation? | 14:12 |
| kashyap | mdbooth: mriedem: An unrelated question: When trying to migrate 50+ guests, will Nova attempt to do them all in parallel? | 14:13 |
| mdbooth | kashyap: I know my script explicitly pipelined them. Don't recall any limiting in Nova. | 14:15 |
| kashyap | mdbooth: Which script is this? | 14:15 |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Refactor create_delete_server_with_instance_update https://review.openstack.org/466296 | 14:16 |
| mriedem | kashyap: live migration or cold migration, because for live migration https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L526 | 14:16 |
| kashyap | Live migration | 14:17 |
| mriedem | kashyap: by default live migrations are restricted to one at a time on a given compute | 14:17 |
| * kashyap looks at the code | 14:17 | |
| mriedem | see the max_concurrent_live_migrations option | 14:17 |
| mriedem | sdague: johnthetubaguy: dansmith: oh seers of nova lore, do you remember if boot from volume came before volume attach or after? | 14:18 |
| dansmith | after I'm sure | 14:18 |
| mriedem | that's what i assumed | 14:18 |
| *** baoli has joined #openstack-nova | 14:19 | |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Refactor create_delete_server_with_instance_update https://review.openstack.org/466296 | 14:21 |
| *** ralonsoh has quit IRC | 14:21 | |
| *** ralonsoh has joined #openstack-nova | 14:21 | |
| kashyap | mriedem: Thanks; that's useful | 14:22 |
| kashyap | "(Integer) Maximum number of live migrations to run concurrently. This limit is enforced to avoid outbound live migrations overwhelming the host/network and causing failures. It is not recommended that you change this unless you are very sure that doing so is safe and stable in your environment." | 14:22 |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Add method for verify multiple notifications https://review.openstack.org/465526 | 14:22 |
| *** mlavalle has joined #openstack-nova | 14:29 | |
| *** cdent has quit IRC | 14:34 | |
| *** lpetrut has quit IRC | 14:36 | |
| *** karthiks has quit IRC | 14:38 | |
| dansmith | woot | 14:40 |
| dansmith | live migration job is passing with multicell too | 14:40 |
| *** mnestratov has joined #openstack-nova | 14:41 | |
| *** karthiks has joined #openstack-nova | 14:41 | |
| mriedem | that's unpossible | 14:42 |
| dansmith | it's definitely unexpected | 14:42 |
| *** MVenesio_ has joined #openstack-nova | 14:44 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Deprecate scheduler trusted filter https://review.openstack.org/463065 | 14:45 |
| *** yamamoto_ has joined #openstack-nova | 14:47 | |
| *** MVenesio has quit IRC | 14:47 | |
| *** MVenesi__ has joined #openstack-nova | 14:48 | |
| *** dpawlik is now known as _dpawlik | 14:48 | |
| *** gszasz has quit IRC | 14:48 | |
| mriedem | if people are happy with this caching thing we should get it in and start backports https://review.openstack.org/#/c/465042/ | 14:48 |
| *** gianpietro has joined #openstack-nova | 14:49 | |
| openstackgerrit | Daniel Pawlik proposed openstack/nova master: Add hide hypervisor id on guest host https://review.openstack.org/459753 | 14:50 |
| _dpawlik | mriedem, dansmith, kashyap: I made some changes in PS https://review.openstack.org/#/c/459753/ . I must go. If something is bad, I try to fix it later. Thanks for reviewing | 14:50 |
| *** MVenesio has joined #openstack-nova | 14:50 | |
| _dpawlik | have a nice weekend | 14:51 |
| *** MVenesio_ has quit IRC | 14:51 | |
| *** yamamoto has quit IRC | 14:51 | |
| *** mriedem is now known as mriedem_afk | 14:52 | |
| *** gianpietro has quit IRC | 14:53 | |
| *** MVenesi__ has quit IRC | 14:54 | |
| *** gouthamr has joined #openstack-nova | 14:56 | |
| *** ratailor has quit IRC | 14:59 | |
| *** dikonoor has quit IRC | 14:59 | |
| *** trungnv has joined #openstack-nova | 15:00 | |
| *** markus_z has quit IRC | 15:01 | |
| *** hongbin has joined #openstack-nova | 15:01 | |
| *** armax has joined #openstack-nova | 15:02 | |
| *** tbachman has quit IRC | 15:02 | |
| *** alezil has quit IRC | 15:05 | |
| *** gmann has quit IRC | 15:05 | |
| *** ekhugen has quit IRC | 15:05 | |
| *** alezil has joined #openstack-nova | 15:05 | |
| *** gmann has joined #openstack-nova | 15:05 | |
| *** Guest26195 has quit IRC | 15:06 | |
| *** patriciadomin_ has quit IRC | 15:06 | |
| *** patriciadomin has joined #openstack-nova | 15:07 | |
| *** ekhugen has joined #openstack-nova | 15:08 | |
| *** egarbade has joined #openstack-nova | 15:08 | |
| *** egarbade is now known as Guest16122 | 15:08 | |
| *** salv-orlando has quit IRC | 15:09 | |
| *** salv-orlando has joined #openstack-nova | 15:10 | |
| *** rcernin has quit IRC | 15:13 | |
| *** jaosorior has quit IRC | 15:13 | |
| *** eharney_ has joined #openstack-nova | 15:13 | |
| *** salv-orlando has quit IRC | 15:14 | |
| *** eharney has quit IRC | 15:15 | |
| *** karimb has joined #openstack-nova | 15:17 | |
| *** gouthamr has quit IRC | 15:19 | |
| *** marst_ has joined #openstack-nova | 15:19 | |
| *** eharney_ is now known as eharney | 15:23 | |
| *** gianpietro has joined #openstack-nova | 15:27 | |
| *** gouthamr has joined #openstack-nova | 15:28 | |
| *** tbachman has joined #openstack-nova | 15:30 | |
| *** tbachman_ has joined #openstack-nova | 15:34 | |
| *** tbachman has quit IRC | 15:34 | |
| *** tbachman_ is now known as tbachman | 15:34 | |
| *** salv-orlando has joined #openstack-nova | 15:36 | |
| cfriesen | are there any plans to remove the glance proxy in the nova API? | 15:38 |
| artom | cfriesen, it's not already gone? | 15:40 |
| *** mlakat has quit IRC | 15:40 | |
| *** salv-orlando has quit IRC | 15:41 | |
| artom | cfriesen, deprecated, I should say, as of https://docs.openstack.org/developer/nova/api_microversion_history.html#id33 | 15:41 |
| artom | cfriesen, but it has to remain in the code for older microversions to work | 15:41 |
| johnthetubaguy | mriedem_afk I would have bet on it being after too, I kinda remember alaski attempting to tidy up a bunch of it some time after it landed | 15:45 |
| alaski | tidy up what now? | 15:47 |
| *** coreywright has quit IRC | 15:47 | |
| *** Oku_OS is now known as Oku_OS-away | 15:48 | |
| *** dikonoor has joined #openstack-nova | 15:50 | |
| cfriesen | artom: whoops, missed that. | 15:51 |
| *** felipemonteiro_ has quit IRC | 15:52 | |
| *** baoli_ has joined #openstack-nova | 15:53 | |
| *** gyee has joined #openstack-nova | 15:55 | |
| *** baoli has quit IRC | 15:55 | |
| *** felipemonteiro has joined #openstack-nova | 15:56 | |
| *** lucasagomes is now known as lucas-afk | 15:57 | |
| *** esberglu has quit IRC | 15:57 | |
| *** esberglu has joined #openstack-nova | 15:58 | |
| dansmith | alaski: boot from volume I think | 15:59 |
| *** coreywright has joined #openstack-nova | 15:59 | |
| *** gianpietro has quit IRC | 16:00 | |
| alaski | ahh. Tidy up is being generous. I just made it actually functional for xenserver, and a little more reliable. | 16:01 |
| *** ralonsoh has quit IRC | 16:01 | |
| *** felipemonteiro_ has joined #openstack-nova | 16:02 | |
| alaski | you know what would really help, uuids for bdms :) | 16:02 |
| *** esberglu has quit IRC | 16:03 | |
| *** p01nt3r75 has quit IRC | 16:03 | |
| *** vks1 has quit IRC | 16:03 | |
| *** belmoreira has quit IRC | 16:04 | |
| cfriesen | boot from volume definitely came after volume attach/detach | 16:04 |
| cfriesen | (looking at git history) | 16:04 |
| *** felipemonteiro has quit IRC | 16:05 | |
| *** nic has joined #openstack-nova | 16:08 | |
| *** ericyoung has joined #openstack-nova | 16:09 | |
| *** Apoorva has joined #openstack-nova | 16:16 | |
| *** nicolasbock has quit IRC | 16:17 | |
| *** vks1 has joined #openstack-nova | 16:17 | |
| *** yamamoto_ has quit IRC | 16:19 | |
| *** yamamoto has joined #openstack-nova | 16:19 | |
| *** hshiina has quit IRC | 16:20 | |
| *** ltomasbo is now known as ltomasbo|away | 16:20 | |
| *** gianpietro has joined #openstack-nova | 16:25 | |
| *** ericyoung has quit IRC | 16:35 | |
| *** gouthamr_ has joined #openstack-nova | 16:35 | |
| *** trungnv has quit IRC | 16:36 | |
| *** crushil has quit IRC | 16:38 | |
| *** gouthamr has quit IRC | 16:38 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: De-complicate some of the instance delete path https://review.openstack.org/458636 | 16:39 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Fix live migration devstack hook for multicell environment https://review.openstack.org/458537 | 16:39 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Target cell on local delete https://review.openstack.org/464059 | 16:39 |
| *** pcaruana|rtve| has quit IRC | 16:42 | |
| *** brault has quit IRC | 16:42 | |
| *** trungnv has joined #openstack-nova | 16:43 | |
| *** derekh has quit IRC | 16:44 | |
| *** sambetts is now known as sambetts|afk | 16:47 | |
| *** jwcroppe has quit IRC | 16:48 | |
| *** esberglu has joined #openstack-nova | 16:49 | |
| *** jwcroppe has joined #openstack-nova | 16:50 | |
| *** markvoelker has joined #openstack-nova | 16:52 | |
| *** crushil has joined #openstack-nova | 16:53 | |
| *** salv-orlando has joined #openstack-nova | 16:57 | |
| *** psachin has joined #openstack-nova | 16:59 | |
| *** salv-orlando has quit IRC | 17:03 | |
| *** vks1 has quit IRC | 17:04 | |
| *** tbachman has quit IRC | 17:07 | |
| *** jpena is now known as jpena|off | 17:09 | |
| *** gianpietro has quit IRC | 17:12 | |
| *** mnestratov has quit IRC | 17:13 | |
| *** swebster has quit IRC | 17:16 | |
| *** mkoderer has quit IRC | 17:24 | |
| *** salv-orlando has joined #openstack-nova | 17:25 | |
| *** takedakn has joined #openstack-nova | 17:27 | |
| *** salv-orlando has quit IRC | 17:28 | |
| *** takedakn has quit IRC | 17:28 | |
| *** Apoorva_ has joined #openstack-nova | 17:31 | |
| *** Apoorva has quit IRC | 17:35 | |
| *** vks1 has joined #openstack-nova | 17:40 | |
| *** Swami has joined #openstack-nova | 17:40 | |
| *** vks1 has quit IRC | 17:41 | |
| *** karimb has quit IRC | 17:43 | |
| *** lbragstad has quit IRC | 17:47 | |
| *** lbragstad has joined #openstack-nova | 17:47 | |
| *** lbragstad has quit IRC | 17:47 | |
| *** Sukhdev has joined #openstack-nova | 17:47 | |
| *** gjayavelu has joined #openstack-nova | 17:47 | |
| *** eharney has quit IRC | 17:51 | |
| *** Apoorva_ has quit IRC | 17:51 | |
| *** Apoorva has joined #openstack-nova | 17:51 | |
| *** rfolco has quit IRC | 17:53 | |
| *** gouthamr_ has quit IRC | 17:55 | |
| *** brault has joined #openstack-nova | 17:59 | |
| *** psachin has quit IRC | 18:03 | |
| *** brault has quit IRC | 18:03 | |
| *** eharney has joined #openstack-nova | 18:05 | |
| cfriesen | dansmith: you around? | 18:09 |
| *** harlowja has joined #openstack-nova | 18:13 | |
| *** salv-orlando has joined #openstack-nova | 18:13 | |
| dansmith | kinda | 18:13 |
| *** Jeffrey4l has quit IRC | 18:14 | |
| *** gouthamr has joined #openstack-nova | 18:20 | |
| *** Jeffrey4l has joined #openstack-nova | 18:20 | |
| cfriesen | dansmith: if you remember we were talking about the cost of processing network-changed events. it turns out the neutron work to process those events during a migration doubled in Newton when commit 5de902a went in. That was submitted to fix evacuate bugs, but it meant both source and dest compute nodes got the "network-changed" events. | 18:21 |
| cfriesen | I'm writing up a post, but even after mriedem's optimization at https://review.openstack.org/#/c/465787 I'm seeing 4 simultaneous live migrations push neutron up to using 1300% cpu on the controller, with the spike lasting ~45sec | 18:22 |
| *** JoseMello has joined #openstack-nova | 18:29 | |
| *** tbachman has joined #openstack-nova | 18:34 | |
| dansmith | 128 neutron api calls peg 13 cores for almost a minute? | 18:34 |
| *** Jeffrey4l has quit IRC | 18:36 | |
| cfriesen | no, more like a few thousand neutron API calls | 18:37 |
| cfriesen | for each port nova queries the fixed IPs, floating IPs, subnets, etc | 18:37 |
| dansmith | oh I see | 18:37 |
| *** mriedem_afk is now known as mriedem | 18:39 | |
| *** lbragstad has joined #openstack-nova | 18:39 | |
| mriedem | cfriesen: so https://review.openstack.org/#/c/465787 does help? | 18:40 |
| cfriesen | mriedem: yes, hugely. for one migration it cut down on the number of neutron API calls by a factor of 6 or so | 18:41 |
| mriedem | wow nice | 18:41 |
| mriedem | ok so i suppose i need to tidy that up | 18:42 |
| mriedem | i can make it smaller by splitting the refactor part into a separate change | 18:42 |
| cfriesen | mriedem: dansmith: I just posted to the openstack-dev list: "massive overhead processing "network-changed" events during live migration". Some hard data in there. | 18:42 |
| cfriesen | mriedem: I also included the change I proposed to query just the one port rather than listing all of them. | 18:43 |
| *** Jeffrey4l has joined #openstack-nova | 18:43 | |
| mriedem | ok i'm post-alient and post-burrito so i need to get my bearings here | 18:47 |
| cfriesen | mridem: (I'm talking about the optimization I proposed in https://review.openstack.org/#/c/465787....I applied it for my testing) | 18:50 |
| mriedem | oh i haven't seen comments | 18:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: remove glusterfs volume driver https://review.openstack.org/463992 | 18:51 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: remove scality volume driver https://review.openstack.org/449364 | 18:52 |
| cfriesen | mriedem: my one comment about the number of neutron API calls isn't quite accurate, that's actually the number of lines in the neutron API log...but most API calls resulted in one log line so it should be in the ballpark. | 18:52 |
| *** xyang1 has joined #openstack-nova | 18:56 | |
| *** pchavva has quit IRC | 18:56 | |
| *** smatzek has quit IRC | 18:58 | |
| mriedem | cfriesen: does the list_ports thing really change much? | 19:00 |
| mriedem | replied to your comments | 19:00 |
| mriedem | either way it's a single API call to neutron | 19:00 |
| mriedem | but if we don't have a nw info cache for the instance, for whatever reason - that shouldn't actually happen, we'd need to go back and pull the entire list of ports to rebuild the entire nw info cache | 19:00 |
| cfriesen | mriedem: that list-ports is getting all the ports in the cloud, right? or is it scoped to the project? | 19:01 |
| mriedem | see the search opts | 19:01 |
| mriedem | it's scoped to the ports owned by that tenant associated with that specific instance | 19:01 |
| mriedem | if we just did show_port w/o those filter parameters, it'd be a possible bug | 19:01 |
| *** fragatina has quit IRC | 19:02 | |
| mriedem | because the port might no longer be associated with that instance | 19:02 |
| mriedem | which messes up the logic that comes later | 19:02 |
| cfriesen | mriedem: okay, fair enough. givien that it's associated with the instance it's probably fine. I missed that part. | 19:02 |
| mriedem | ok | 19:02 |
| mriedem | _build_network_info_model is really used for 3 different cases, so it gets really hairy logic-wise | 19:03 |
| mriedem | at some point i think we could split it apart, so we didn't have kwarg soup | 19:03 |
| mriedem | everything in here is pretty fragile though, so it get scared touching most of it, especially since it's related to async event handling | 19:03 |
| cfriesen | the real pain is that we end up getting multiple network-changed events for each port during the live migration. The fact that until Newton we didn't even get the events on the dest compute node makes me think it's not actually needed there. | 19:04 |
| *** marst_ has quit IRC | 19:09 | |
| *** itlinux has joined #openstack-nova | 19:09 | |
| *** nic has quit IRC | 19:09 | |
| *** nic has joined #openstack-nova | 19:10 | |
| *** marst_ has joined #openstack-nova | 19:10 | |
| artom | cfriesen, there was https://review.openstack.org/#/c/246910/14 that wanted to send events to both source and dest during live-migration | 19:10 |
| artom | That ended up being re-worked when we merged the other patch | 19:11 |
| artom | But it shows the need was apparently there | 19:11 |
| artom | I suspect a lot of deployments ran with vif_plugging_fatal = false, which masks the whole thing | 19:11 |
| *** pchavva has joined #openstack-nova | 19:11 | |
| *** marst_ has quit IRC | 19:13 | |
| *** marst_ has joined #openstack-nova | 19:13 | |
| *** yamahata has quit IRC | 19:14 | |
| mriedem | replied in the ML | 19:16 |
| mriedem | i'm not sure how sending events to the source compute during an evacuation makes any sense, | 19:17 |
| mriedem | isn't the source compute down? | 19:17 |
| dansmith | it might be, but the point is, any move/migrate should be sending them to both sides | 19:18 |
| mriedem | looking at what artom linked it looked like what was really needed there was the vif plugged/unplugged events, which makes sense | 19:19 |
| mriedem | network-changed is triggered anytime a port is updated - which for us is when it's bound/unbound to a host | 19:20 |
| mriedem | which makes sense, but as noted we shotgun our way to refresh the cache b/c we don't know which specific port was updated in that case | 19:20 |
| mriedem | which is my series of changes | 19:20 |
| mriedem | also, | 19:20 |
| mriedem | i'm loathe to decide in the API based on migration type and event type which we should send and which we shouldn't based on how we expect the computes to behave | 19:21 |
| artom | Also, I thought events the compute didn't specifically set up to listen for got ignored? | 19:21 |
| mriedem | no | 19:22 |
| artom | Is network-changes always processed? | 19:22 |
| cfriesen | sure...but can we in nova selectively ignore the events if we know we don't need to care about them? | 19:22 |
| mriedem | artom: yes | 19:22 |
| mriedem | https://review.openstack.org/#/c/465792/ | 19:22 |
| mriedem | oops | 19:22 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6854 | 19:22 |
| mriedem | is a flat out, rebuild the entire nw info cache | 19:22 |
| *** prometheanfire has joined #openstack-nova | 19:23 | |
| mriedem | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6862 for network-vif-deleted is targeted to at least just deallocate the port and remove it from the nw info cache w/o a full rebuild | 19:23 |
| prometheanfire | looks like the oslo-cache test may be overly specific http://logs.openstack.org/87/465887/4/check/gate-cross-nova-python27-ubuntu-xenial/19a9161/testr_results.html.gz | 19:23 |
| mriedem | artom: else we fall into https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6800 | 19:23 |
| mriedem | _event = self.instance_events.pop_instance_event(instance, event) are the things the specific compute is listening for, | 19:23 |
| mriedem | like vif plugged | 19:23 |
| artom | mriedem, OK, I was thinking of https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L302 | 19:23 |
| dansmith | mriedem: yes I think the API making that call is bad news.. it's bad news for even compute manager to do it because the virt driver is running the migration | 19:23 |
| mriedem | ^ triggers the callback into the virt driver to finish spawn() | 19:24 |
| artom | mriedem, oh ok, yeah, your first link shows that network-changed is always processed | 19:24 |
| mriedem | but that's the network-vif-plugged and network-vif-unplugged events | 19:24 |
| artom | Regardless of what the compute prepared for | 19:24 |
| mriedem | right | 19:24 |
| dansmith | also, when we support cross-cell migrations we'll want network-changed processed on both sides since they're separate databases | 19:24 |
| dansmith | if we don't we'll end up with stupid bugs like info cache is as provided by the source compute until the next periodic refresh | 19:25 |
| mriedem | dansmith: during a cross cell migration, wouldn't we get an InstanceNotFound on the source cell when trying to update it's nw info cache? | 19:25 |
| cfriesen | okay, so can we add more info from neutron to reduce the number of queries nova has to do? | 19:25 |
| dansmith | mriedem: no, if we do cross-cell migrations we'll have to create the instance in the target database before any of the migration stuff starts | 19:25 |
| mriedem | ew yeah | 19:26 |
| artom | Also, am I the only one who finds it completely mental that https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6856 is on the *compute*? | 19:26 |
| artom | I'd put that somewhere more central, conductor I guess | 19:26 |
| dansmith | artom: why? | 19:26 |
| prometheanfire | mriedem: need a bug for http://logs.openstack.org/87/465887/4/check/gate-cross-nova-python27-ubuntu-xenial/19a9161/testr_results.html.gz ? | 19:26 |
| dansmith | artom: you have more computes than conductors, and instance events don't come to conductor, they come to the compute(s) that are associated with the instances | 19:26 |
| cfriesen | dansmith: it's a bit silly that both computes are simultaneously querying the same data from neutron | 19:27 |
| dansmith | anything we can obviously do at the edges (computes) is better | 19:27 |
| mriedem | prometheanfire: probably - without me looking into the actual tests | 19:27 |
| dansmith | cfriesen: not in a cross-cell migration | 19:27 |
| artom | dansmith, I guess I was thinking in the context of this overloading Neutron discussion | 19:27 |
| *** slaweq has joined #openstack-nova | 19:27 | |
| cfriesen | dansmith: wouldn't you have separate conductors there too? | 19:27 |
| artom | dansmith, but yeah, I'll shut up now ;) | 19:27 |
| prometheanfire | mriedem: k, fyi, I think this will be blocking reqs updates on dogpile.cache | 19:27 |
| dansmith | cfriesen: sure? but it's still twice the calls | 19:28 |
| cfriesen | dansmith: for migrations in a single cell you could have the conductor get the data from neutron and then pass just the changed bits to both compute nodes | 19:28 |
| mriedem | network-changed doesn't really have anything to do with the compute | 19:29 |
| mriedem | so that one could be centralized | 19:29 |
| dansmith | cfriesen: yes, you could have the api guess on all that and make those events different | 19:29 |
| mriedem | network-vif-deleted and the vif plug/unplug ones call the driver so that's why they are on the compute | 19:29 |
| *** pchavva has quit IRC | 19:29 | |
| *** Apoorva has quit IRC | 19:30 | |
| *** breton has quit IRC | 19:30 | |
| mriedem | handling network-changed is an optimization that could be made at the top probably | 19:30 |
| mriedem | but baby steps probably | 19:30 |
| dansmith | mriedem: all events are handled by the computes now, so if you change that, you need to know which conductor (super or cell) to send events to, and then adding new things becomes a little less clear about where each is handled | 19:31 |
| dansmith | making the operations that are happening less insanely heavy will yield much more benefit than cutting a big number in half in some situations | 19:32 |
| mriedem | the former is what i'm trying to start with now yeah | 19:32 |
| mriedem | by targeting the network-changed event to a single port | 19:32 |
| mriedem | so we don't do the full nw info cache rebuild | 19:32 |
| dansmith | yeah | 19:32 |
| dansmith | I thought at one point we had a partial update thing like that | 19:33 |
| dansmith | did we lose that or was it different? | 19:33 |
| mriedem | not sure what you're referring to | 19:33 |
| cfriesen | would it be reasonable for neutron to add more info about what exactly changed? (subnet, fixedip, floatingip, etc.) | 19:33 |
| mriedem | cfriesen: maybe | 19:33 |
| dansmith | we used to rebuild the whole cache every time and arosen did something to try to merge our networkinfo with just one change | 19:33 |
| dansmith | cfriesen: you only get a tag in the event, but you could use that to signal what to refresh, yes, or have a different event like "floatingip-changed" | 19:34 |
| cfriesen | even something like that could cut the number of neutron GETs down dramatically | 19:35 |
| mriedem | https://review.openstack.org/#/q/owner:aaronorosen%2540gmail.com+status:abandoned+project:openstack/nova | 19:35 |
| melwitt | dansmith: I put a lock around the cache access in https://review.openstack.org/465042 to address your comment | 19:35 |
| dansmith | mriedem: no, this thing merged and caused a bunch of bugs, but I thought they all got squashed out | 19:35 |
| dansmith | mriedem: anyway, not worth going to find it, it was 2013ish so just move on optimizing what we have now | 19:35 |
| mriedem | dansmith: oh idk then, that would be like 3+ years ago now | 19:35 |
| dansmith | yes | 19:36 |
| dansmith | melwitt: I know, sorry | 19:36 |
| melwitt | k, just in case you hadn't seen | 19:36 |
| mriedem | anywho, i've got some patches to review which i promised (well didn't promise, but said maybe) i'd review, so going to do those first and then can cleanup this patch | 19:37 |
| *** breton has joined #openstack-nova | 19:37 | |
| *** Sukhdev has quit IRC | 19:37 | |
| *** salv-orlando has quit IRC | 19:38 | |
| cfriesen | mriedem: dansmith: oh, and it turns out that once you have mriedem's "update the specific port" change, we don't really have any duplicate events for the same instance anymore | 19:39 |
| mriedem | because they never were duplicates, | 19:40 |
| mriedem | but nova just didn't know | 19:40 |
| cfriesen | yeah | 19:40 |
| mriedem | right? | 19:40 |
| cfriesen | which actually means that the "vanilla" numbers for the neutron utilization would be much worse, since I had duplicate event removal in there. | 19:42 |
| mriedem | do i get a large beer in denver for this? | 19:42 |
| mriedem | s/beer/ginger ale/ | 19:42 |
| cfriesen | oh, definitely | 19:42 |
| melwitt | I don't understand why I would get "This change depends on a change that failed to merge." on a set where when I rebase it locally, I don't see any merge conflicts or auto-merging | 19:43 |
| dansmith | melwitt: depends-on? | 19:43 |
| melwitt | I don't think I have any but I'm checking again | 19:44 |
| mriedem | melwitt: there used to be a thing with zuul where if you rebased a large series, it couldn't keep up with the stream of events, | 19:44 |
| melwitt | yeah, I don't have any Depends-On. ugh, wtf | 19:44 |
| mriedem | and you'd get a merge conflict, even though there wasn't one | 19:44 |
| mriedem | i saw that happening on artom's series the otherday | 19:44 |
| mriedem | it was fixed for months, but might be back | 19:45 |
| mriedem | in black | 19:45 |
| melwitt | okay, I think it's still a thing then. there's 18 patches | 19:45 |
| *** fragatina has joined #openstack-nova | 19:45 | |
| artom | mriedem, you mean the tagged attach series? | 19:45 |
| mriedem | artom: is there any other? | 19:45 |
| artom | Yeah, anything but the bottom patch gives merge conflict | 19:45 |
| artom | mriedem, it's a secret that I'll reveal when I'm ready | 19:46 |
| melwitt | haha | 19:46 |
| mriedem | artom "tagged attach" lifshitz | 19:46 |
| mriedem | is your new name when i give credits in my album | 19:46 |
| artom | Yey credits! | 19:46 |
| mriedem | right next to seymour duncan pickups | 19:47 |
| artom | So I'll be in the 'Tools' section, gotcha | 19:47 |
| cfriesen | mriedem: you play guitar? | 19:47 |
| mriedem | cfriesen: in the long ago | 19:49 |
| *** kylek3h has quit IRC | 19:49 | |
| mriedem | they sit in cases in a closet in the basement next to a box of books and yankee candles | 19:49 |
| cfriesen | this guy makes fan-fret basses in my city...I've visited his shop: http://www.dingwallguitars.com/ | 19:49 |
| mriedem | like a true suburbanite | 19:50 |
| *** kylek3h has joined #openstack-nova | 19:50 | |
| * melwitt begins the recheck extravaganza | 19:51 | |
| nic | Are there party hats? | 19:51 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Fix live migration devstack hook for multicell environment https://review.openstack.org/458537 | 19:51 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Target cell on local delete https://review.openstack.org/464059 | 19:51 |
| *** yamahata has joined #openstack-nova | 19:52 | |
| melwitt | haha, yup | 19:52 |
| artom | Speaking of party, we're not doing Hawaiian-nick Friday? | 19:53 |
| artom | Not that I ever did it, personally | 19:54 |
| *** mriedem is now known as mriderman | 19:54 | |
| *** mriderman is now known as mriedem | 19:55 | |
| *** artom is now known as sanwonkwonsimotr | 19:56 | |
| *** sanwonkwonsimotr is now known as artom | 19:57 | |
| artom | Dammit, length limit cut off the last letter | 19:57 |
| * artom was going for a palindrome :( | 19:57 | |
| *** fragatina has quit IRC | 20:00 | |
| *** fragatina has joined #openstack-nova | 20:00 | |
| *** felipemonteiro_ has quit IRC | 20:01 | |
| melwitt | wear a hawaiian shirt | 20:01 |
| melwitt | and jeans | 20:01 |
| melwitt | if you want to | 20:01 |
| mriedem | except peter | 20:01 |
| mriedem | he has to come in on saturday | 20:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: nova-manage: Deprecate 'log' commands https://review.openstack.org/453176 | 20:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: nova-manage: Deprecate 'host' commands https://review.openstack.org/453175 | 20:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: nova-manage: Deprecate 'project', 'account' commands https://review.openstack.org/453174 | 20:02 |
| melwitt | hah | 20:02 |
| *** crushil has quit IRC | 20:04 | |
| *** ijw_ has joined #openstack-nova | 20:05 | |
| *** fragatina has quit IRC | 20:06 | |
| *** ijw__ has joined #openstack-nova | 20:06 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: nova-manage: Deprecate 'log' commands https://review.openstack.org/453176 | 20:07 |
| mriedem | https://review.openstack.org/#/c/453174/ and up are easy +Ws | 20:08 |
| *** ijw_ has quit IRC | 20:10 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Adopts keystoneauth with glance client. https://review.openstack.org/412634 | 20:11 |
| *** ijw has joined #openstack-nova | 20:11 | |
| *** ijw__ has quit IRC | 20:13 | |
| *** itlinux has quit IRC | 20:14 | |
| melwitt | mriedem: on the first and last of those, the bp isn't mentioned in the commit message. point being, I wondered if they are part of a bp that explains what's going on and why | 20:15 |
| melwitt | the second one links to a non existing bp | 20:16 |
| mriedem | the 2nd one's bp is completed | 20:16 |
| mriedem | the os-hosts removal thing, | 20:16 |
| mriedem | i noted it after that bp was completed | 20:16 |
| mriedem | the series itself is a precursor to move-nova-cmds-to-cliff in queens | 20:16 |
| mriedem | sfinucan wants to deprecate as much as possible from nova-manage before moving the infra for it over to cliff | 20:16 |
| mriedem | making the work he needs to do in queens smaller | 20:17 |
| mriedem | i asked him to remove the bp links for that though since it's not approved for pike, so would have been confusing | 20:17 |
| *** gianpietro has joined #openstack-nova | 20:17 | |
| melwitt | oh, I see. thanks | 20:19 |
| *** eharney has quit IRC | 20:21 | |
| mriedem | another easy one https://review.openstack.org/#/c/463065/ | 20:22 |
| mriedem | and https://review.openstack.org/#/c/391060/ | 20:23 |
| mriedem | ^ is less easy i guess | 20:23 |
| *** Apoorva has joined #openstack-nova | 20:24 | |
| *** mikal has quit IRC | 20:25 | |
| *** jamesdenton has quit IRC | 20:25 | |
| efried | johnthetubaguy mriedem Can I get a sense of the scope of remaining work for bp/use-service-tokens-pike? | 20:26 |
| *** salv-orlando has joined #openstack-nova | 20:26 | |
| efried | It appears to be at least driving https://review.openstack.org/412634 to completion - but... is that it? | 20:26 |
| mriedem | efried: i haven't looked | 20:26 |
| mriedem | i think using it for glance is the big one | 20:27 |
| efried | Okay, cause it looks like neutron & cinder are done. | 20:27 |
| *** mikal has joined #openstack-nova | 20:27 | |
| mriedem | yes those were done in ocata | 20:27 |
| mriedem | efried: or just look at the spec :) https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/use-service-tokens.html | 20:27 |
| mriedem | https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/use-service-tokens.html#work-items | 20:28 |
| efried | mriedem Well, yeah, I did that | 20:28 |
| mriedem | everything in there is done except for the glance one | 20:28 |
| efried | Okay, just making sure I understood correctly. Thanks. | 20:28 |
| *** Guest6334 has quit IRC | 20:30 | |
| *** dave-mccowan has quit IRC | 20:31 | |
| melwitt | mriedem: hm, that reqspec delete one, the commit message points out that it's okay to delete it even if instance destroy fails. I'm thinking of a case where destroy fails, the user decides to just keep the instance around and then things will fail if they do a resize or something that will invoke the scheduler, right? | 20:32 |
| melwitt | bc that reqspec will be gone | 20:33 |
| mriedem | melwitt: did you see the comment i just put in there? | 20:33 |
| melwitt | I just read it a few seconds after I typed in here heh | 20:34 |
| mriedem | b/c i thought about that yesterday or something | 20:34 |
| mriedem | but just remembered to point it out | 20:34 |
| *** slaweq has quit IRC | 20:34 | |
| mriedem | we can be sure it's gone if we do a local delete, | 20:34 |
| mriedem | we're less sure if we cast to the compute to delete it | 20:34 |
| melwitt | yeah, it feels like a bit more thought should be put into it | 20:34 |
| *** slaweq has joined #openstack-nova | 20:34 | |
| mriedem | removed my +2 | 20:35 |
| mriedem | we could delete the reqspec if we are doing a local delete in the api, | 20:35 |
| mriedem | we're going to need a periodic or nova-manage CLI to cleanup orphans from the api db for req spec and instance mappings, | 20:36 |
| *** gianpietro has quit IRC | 20:36 | |
| mriedem | so we could leave that to cleanup the req spec in the case of soft delete or when we cast to the compute to delete the req spec | 20:36 |
| mriedem | i don't know where a periodic would run, we don't have periodics in the api or conductor, only scheduler | 20:36 |
| mriedem | reqspecs are for scheduling so cleaning up orphans in a periodic task in the scheduler might be ok, but instance mappings don't fit that as nicely | 20:37 |
| *** gianpietro has joined #openstack-nova | 20:37 | |
| *** ijw has quit IRC | 20:37 | |
| melwitt | I was just thinking, as long as the instance has disappeared from the user's perspective (deleted=1) then it's okay to delete the reqspec, since at that point they aren't able to do requests with it anyway (other than listing deleted instance I think) | 20:38 |
| *** slaweq has quit IRC | 20:39 | |
| mriedem | but we don't deleted=1 until we're in the compute in most cases, | 20:40 |
| mriedem | and deleted the reqspec there is an upcall, | 20:40 |
| melwitt | I just can't remember where that happens, if it's in compute/api in the case of a cast to compute, or if it's in compute. I guess for the cast it's in compute, which sucks | 20:40 |
| mriedem | which we want to avoid | 20:40 |
| melwitt | yeah | 20:40 |
| *** dikonoor has quit IRC | 20:41 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add service_token for nova-glance interaction https://review.openstack.org/419662 | 20:44 |
| *** slaweq has joined #openstack-nova | 20:45 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: DNM: Test service token in Glance https://review.openstack.org/419666 | 20:45 |
| *** salv-orlando has quit IRC | 20:49 | |
| *** itlinux has joined #openstack-nova | 20:58 | |
| *** lbragstad has quit IRC | 20:59 | |
| *** ssurana has joined #openstack-nova | 21:00 | |
| *** marst_ has quit IRC | 21:02 | |
| *** dimtruck is now known as zz_dimtruck | 21:03 | |
| *** salv-orlando has joined #openstack-nova | 21:03 | |
| *** salv-orlando has quit IRC | 21:04 | |
| *** ssurana has quit IRC | 21:07 | |
| mriedem | mordred: what is flavor extra_info? do you mean extra_specs? | 21:08 |
| *** JoseMello has quit IRC | 21:08 | |
| *** gianpietro has quit IRC | 21:12 | |
| *** edmondsw has quit IRC | 21:12 | |
| *** rcernin has joined #openstack-nova | 21:13 | |
| *** edmondsw has joined #openstack-nova | 21:13 | |
| *** gianpietro has joined #openstack-nova | 21:13 | |
| *** Sukhdev has joined #openstack-nova | 21:14 | |
| *** smatzek has joined #openstack-nova | 21:14 | |
| mordred | mriedem: yes. sorry - was typing from memory | 21:14 |
| mordred | mriedem: some clouds have hundreds of flavors - so it gets expensive :) | 21:15 |
| mriedem | ok, not totally sure why you'd need extra specs, we don't expose those to non-admins by default | 21:15 |
| mordred | I mean- the call works on all of the clouds ... but I was told it was important to have them at some point | 21:16 |
| * mordred goes to investigate | 21:16 | |
| mriedem | hold the phone | 21:16 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/policies/flavor_extra_specs.py#L25 | 21:17 |
| mriedem | create, update, delete are admin, | 21:17 |
| mriedem | show is admin or owner | 21:17 |
| mriedem | but...the admin is the owner of the flavor... | 21:17 |
| *** edmondsw has quit IRC | 21:17 | |
| mordred | yah - it quite happily returns a {} everywhereI run it | 21:18 |
| mordred | mriedem: ah - I think we default to fetching them because they used to come in from OS-FLV-WITH-EXT-SPECS:extra_specs | 21:20 |
| *** esberglu has quit IRC | 21:20 | |
| mriedem | hmm, johnthetubaguy or cfriesen might know more, | 21:21 |
| mriedem | cfriesen has been looking at this for embedding the instance flavor in the server GET response body, | 21:21 |
| mriedem | which has to hide the flavor extra specs if not an admin i think | 21:21 |
| mriedem | johnthetubaguy would know why policy could be wonky here | 21:22 |
| mordred | neat. I look forward to learning more! | 21:23 |
| *** edmondsw has joined #openstack-nova | 21:23 | |
| mordred | mriedem: so extra_specs are not intended to be useful to end-users | 21:24 |
| *** itlinux has quit IRC | 21:25 | |
| mriedem | that's a question or statement? | 21:25 |
| *** salv-orlando has joined #openstack-nova | 21:25 | |
| *** smatzek has quit IRC | 21:25 | |
| mordred | questoin... just confirming me learning things | 21:26 |
| dansmith | some people expose them to users | 21:26 |
| mordred | I have never gotten an error fetching them anywhere, fwiw | 21:27 |
| dansmith | mordred: not once? like not one single time? | 21:27 |
| mriedem | flavor extra specs are usually duplicated with image meta | 21:27 |
| melwitt | by default, defining flavors and extra_specs on flavors and matching metadata keys on host aggregates is an admin thing | 21:27 |
| mriedem | and users can see image meta | 21:27 |
| mriedem | and assign image meta in horizon | 21:27 |
| *** zz_dimtruck is now known as dimtruck | 21:27 | |
| mriedem | i think anyway | 21:27 |
| *** edmondsw has quit IRC | 21:27 | |
| dansmith | mriedem: pretty sure that cburgess lets his user _see_ the extra specs because it matters for special types of instances | 21:28 |
| *** slaweq has quit IRC | 21:28 | |
| mordred | dansmith: not one single time | 21:28 |
| mriedem | like, i want the guest watchdog action to do x for this vm | 21:28 |
| dansmith | mordred: daaayum. | 21:28 |
| mordred | dansmith: yah. it's a pretty successful api | 21:28 |
| *** slaweq has joined #openstack-nova | 21:28 | |
| mordred | dansmith: I mean, it's also pretty much always just empty | 21:28 |
| mordred | oh. you know what - I might be TOTALLY lying | 21:29 |
| melwitt | mriedem: yeah, I think that's right that image meta is the user controllable way to express things to the scheduler (other than hints) | 21:29 |
| *** dave-mccowan has joined #openstack-nova | 21:30 | |
| mriedem | dansmith: remember that cburgess encourages his users to do live migrations once a minute too :) | 21:31 |
| mordred | nope. not lying. works fine at least with a quick check on vexxhost and citycloud | 21:31 |
| dansmith | mriedem: not saying cburgess makes good decisions, I'm just saying he lets them see extra_specs :P | 21:31 |
| mordred | I was thinking I just hadnt noticed because we also won't fail if the call fails and will return an empty {} | 21:31 |
| *** slaweq has quit IRC | 21:32 | |
| mriedem | mgagne: do you expose flavor extra specs to non-admin users? | 21:33 |
| mordred | also - fwiw, it works in devstack too: http://logs.openstack.org/72/464772/1/check/gate-shade-dsvm-functional-neutron/f9ee1f6/console.html#_2017-05-15_23_26_48_151366 | 21:34 |
| *** dave-mccowan has quit IRC | 21:34 | |
| mordred | that's operating as the demo user | 21:34 |
| mordred | I'm mostly following up on this because if you think it's supposed to be not exposed and it is it might point to some sort of deeper problem | 21:35 |
| mriedem | so, | 21:36 |
| mriedem | i think it's because we don't target the flavor in the policy check | 21:36 |
| mriedem | i remember something about this when reviewing johnthetubaguy spec on fixing policy scope checks | 21:36 |
| mriedem | i.e. we're not scoping the admin or owner check to the flavor, | 21:36 |
| mriedem | we're scoping it to the user's request context, and since they are the owner of the request, they have access | 21:36 |
| mriedem | we don't have a project_id on flavors though to check against... | 21:37 |
| mriedem | so yeah, the policy basically doesn't mean anything :) | 21:38 |
| mriedem | unless you changed it to admin only | 21:38 |
| *** salv-orlando has quit IRC | 21:39 | |
| *** salv-orlando has joined #openstack-nova | 21:41 | |
| openstackgerrit | Alex Szarka proposed openstack/nova master: [WIP] Transform instance.live_migration_rollback notification https://review.openstack.org/402124 | 21:41 |
| *** lbragstad has joined #openstack-nova | 21:42 | |
| *** salv-orlando has quit IRC | 21:45 | |
| melwitt | mriedem: I'm working on the backports for the caching thing | 21:45 |
| mriedem | melwitt: cool | 21:46 |
| *** swebster has joined #openstack-nova | 21:48 | |
| *** ssurana has joined #openstack-nova | 21:52 | |
| *** esberglu has joined #openstack-nova | 21:53 | |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance-live_migration_abort notification https://review.openstack.org/420453 | 21:53 |
| *** karthiks has quit IRC | 21:55 | |
| *** esberglu has quit IRC | 21:55 | |
| *** ijw has joined #openstack-nova | 21:57 | |
| *** ijw_ has joined #openstack-nova | 21:57 | |
| *** baoli_ has quit IRC | 21:59 | |
| *** slaweq has joined #openstack-nova | 21:59 | |
| *** avolkov has quit IRC | 21:59 | |
| *** ijw has quit IRC | 22:01 | |
| *** MVenesio has quit IRC | 22:02 | |
| *** catintheroof has quit IRC | 22:02 | |
| *** slaweq has quit IRC | 22:02 | |
| *** burt has quit IRC | 22:04 | |
| *** salv-orlando has joined #openstack-nova | 22:04 | |
| *** thorst_afk has quit IRC | 22:06 | |
| *** sambetts|afk has quit IRC | 22:06 | |
| *** sambetts_ has joined #openstack-nova | 22:10 | |
| *** harlowja has quit IRC | 22:12 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Don't warn on expected network-vif-unplugged events https://review.openstack.org/465794 | 22:16 |
| mordred | mriedem: ok. neat! so - I won't worry about it too much then | 22:17 |
| *** sdague has quit IRC | 22:18 | |
| *** lbragstad has quit IRC | 22:19 | |
| *** thorst_afk has joined #openstack-nova | 22:19 | |
| mriedem | i might worry about it | 22:21 |
| mriedem | well, i'll proxy that worry through johnthetubaguy | 22:21 |
| *** edmondsw has joined #openstack-nova | 22:22 | |
| mriedem | melwitt: did you also want to give a heads up to the ops/dev list about that caching patch? | 22:23 |
| mriedem | and backport to newton | 22:23 |
| *** thorst_afk has quit IRC | 22:23 | |
| melwitt | mriedem: yes to both. working on the newton backport right now and will compose an email for the MLs | 22:23 |
| *** thorst_afk has joined #openstack-nova | 22:23 | |
| mriedem | thanks | 22:23 |
| *** thorst_afk has quit IRC | 22:24 | |
| mordred | mriedem: I believe in johnthetubaguy's ability to worry about it | 22:24 |
| *** xyang1 has quit IRC | 22:25 | |
| *** edmondsw has quit IRC | 22:26 | |
| *** salv-orlando has quit IRC | 22:29 | |
| *** Apoorva_ has joined #openstack-nova | 22:32 | |
| *** Apoorva has quit IRC | 22:35 | |
| cfriesen | mordred: mriedem: missed the earlier discussion about extra specs. I think the "admin_or_owner" policy for indexing extra specs means that a regular user is allowed to look at them, just not modify them. (at least that's the behaviour I see. | 22:36 |
| openstackgerrit | Mike Perez proposed openstack/nova master: Remove cells topic configuration option https://review.openstack.org/463218 | 22:36 |
| *** mtanino has joined #openstack-nova | 22:36 | |
| mriedem | cfriesen: yeah we sorted it out | 22:36 |
| mriedem | it's actually a semi-busted/fake policy check | 22:37 |
| cfriesen | I kind of like the behaviour, since it lets the user see the details of the flavors | 22:37 |
| cfriesen | but our users tend to be pretty advanced and closely tied to the admins | 22:37 |
| *** djohnsto has quit IRC | 22:42 | |
| melwitt | mriedem: I assume we're going to be looking at releasing newton and ocata asap after the backports merge? (for the email) | 22:46 |
| *** lbragstad has joined #openstack-nova | 22:49 | |
| mriedem | melwitt: yeah | 22:51 |
| mriedem | which is why i also wanted to get https://review.openstack.org/#/c/464088/ backported | 22:51 |
| melwitt | mriedem: k. looks like you have a comment to address on that one? | 22:53 |
| mriedem | i guess | 22:53 |
| mriedem | sfinucan! | 22:53 |
| mriedem | i don't really understand it though | 22:55 |
| mriedem | if that's true about rstrip, how is the test not failing? | 22:55 |
| *** harlowja has joined #openstack-nova | 22:57 | |
| *** jamielennox is now known as jamielennox|away | 23:00 | |
| mriedem | doing what is suggested doesn't work, | 23:03 |
| mriedem | tests fail because stringifying the url encodes the special characters | 23:03 |
| melwitt | I don't yet understand it either | 23:03 |
| *** dimtruck is now known as zz_dimtruck | 23:04 | |
| mriedem | https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/engine/url.py#L66 | 23:05 |
| mriedem | does linking to zzzeek code summon the zzzeek?! | 23:05 |
| openstackgerrit | christopher.uhler proposed openstack/nova master: Libvirt volume driver for Veritas HyperScale https://review.openstack.org/443951 | 23:07 |
| *** Sukhdev has quit IRC | 23:22 | |
| *** thorst_afk has joined #openstack-nova | 23:24 | |
| *** thorst_afk has quit IRC | 23:29 | |
| *** harlowja has quit IRC | 23:34 | |
| *** Swami has quit IRC | 23:38 | |
| *** jamielennox|away is now known as jamielennox | 23:40 | |
| *** mdrabe__ is now known as mdrabe | 23:41 | |
| *** Apoorva_ has quit IRC | 23:47 | |
| *** Apoorva has joined #openstack-nova | 23:47 | |
| *** crushil has joined #openstack-nova | 23:53 | |
| *** lbragstad has quit IRC | 23:54 | |
| *** esberglu has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!