| gmann | mriedem: yea. nice. we will use resp.obj['server']['id'] to fetch instance right ? | 00:00 |
|---|---|---|
| *** claudiub has quit IRC | 00:00 | |
| *** pchavva has quit IRC | 00:00 | |
| gmann | mriedem: also we would not need instance there once we deprecate and remove the CONF.api.hide_server_address_states | 00:01 |
| gmann | but thats long term things may be next release as it need spec | 00:01 |
| *** ijw has joined #openstack-nova | 00:01 | |
| mriedem | gmann: yes that's the fix | 00:01 |
| *** ijw has quit IRC | 00:01 | |
| mriedem | so the plan is to just remove the config option and always hide 'addresses' when the vm_state is 'building'? | 00:02 |
| *** ijw has joined #openstack-nova | 00:02 | |
| gmann | mriedem: yea, but on spec we can discuss more VM states if addresses is not ready during those | 00:03 |
| melwitt | apologies in advance | 00:07 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add FixedIP.get_count_by_project() https://review.openstack.org/446246 | 00:07 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add FloatingIP.get_count_by_project() https://review.openstack.org/446247 | 00:07 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add get_count_by_vm_state() to Instance object https://review.openstack.org/446244 | 00:07 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add SecurityGroup.get_counts() https://review.openstack.org/446245 | 00:07 |
| openstackgerrit | melanie witt proposed openstack/nova master: Remove 'reserved' count from used limits https://review.openstack.org/446242 | 00:08 |
| openstackgerrit | melanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage https://review.openstack.org/446243 | 00:08 |
| openstackgerrit | melanie witt proposed openstack/nova master: Count server groups to check quota https://review.openstack.org/446240 | 00:08 |
| openstackgerrit | melanie witt proposed openstack/nova master: Count networks to check quota https://review.openstack.org/446241 | 00:08 |
| openstackgerrit | melanie witt proposed openstack/nova master: Count instances to check quota https://review.openstack.org/416521 | 00:08 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add InstanceGroup.get_counts() https://review.openstack.org/457857 | 00:08 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add check_deltas() and limit_check_project_and_user() to Quotas https://review.openstack.org/446239 | 00:08 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add InstanceGroup._remove_members_in_db https://review.openstack.org/457858 | 00:08 |
| openstackgerrit | melanie witt proposed openstack/nova master: Count server group members to check quota https://review.openstack.org/457859 | 00:08 |
| openstackgerrit | melanie witt proposed openstack/nova master: Count security groups to check quota https://review.openstack.org/457860 | 00:08 |
| openstackgerrit | melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945 | 00:08 |
| openstackgerrit | melanie witt proposed openstack/nova master: Count fixed ips to check quota https://review.openstack.org/457861 | 00:08 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946 | 00:08 |
| openstackgerrit | melanie witt proposed openstack/nova master: Count floating ips to check quota https://review.openstack.org/457862 | 00:08 |
| dtp | goodness gracious | 00:08 |
| *** hongbin has quit IRC | 00:10 | |
| *** yamahata has quit IRC | 00:11 | |
| *** mingyu has quit IRC | 00:11 | |
| *** nic has quit IRC | 00:11 | |
| *** Sukhdev_ has quit IRC | 00:16 | |
| *** r-daneel has quit IRC | 00:20 | |
| openstackgerrit | Dan Peschman proposed openstack/nova master: WIP: Use uuid for id in Services API https://review.openstack.org/464280 | 00:29 |
| *** shaner has quit IRC | 00:31 | |
| *** litao__ has joined #openstack-nova | 00:31 | |
| *** dtp has quit IRC | 00:32 | |
| litao__ | alex_xu: pls review my patch https://review.openstack.org/#/c/414463/ if you have free time, thanks. | 00:33 |
| *** shaner has joined #openstack-nova | 00:34 | |
| *** tuanluong has joined #openstack-nova | 00:36 | |
| *** dimtruck is now known as zz_dimtruck | 00:37 | |
| *** gianpiet_ has quit IRC | 00:38 | |
| *** gianpietro has joined #openstack-nova | 00:38 | |
| *** shaner has quit IRC | 00:39 | |
| *** gomarivera has joined #openstack-nova | 00:39 | |
| *** ijw has quit IRC | 00:39 | |
| *** shaner has joined #openstack-nova | 00:40 | |
| *** gomarivera has quit IRC | 00:45 | |
| *** gomarivera has joined #openstack-nova | 00:45 | |
| mriedem | zzzeek: well good news, i sorted out how to get the main and api db's setup, so i've made quite a bit of progress | 00:46 |
| mriedem | it's all hackaroo, but it's a start | 00:46 |
| mriedem | oh nice, just recreated the 500 error | 00:47 |
| *** yamahata has joined #openstack-nova | 00:47 | |
| *** gomarivera has quit IRC | 00:50 | |
| *** fragatina has joined #openstack-nova | 00:54 | |
| *** gomarivera has joined #openstack-nova | 00:55 | |
| *** yamahata has quit IRC | 00:55 | |
| *** gomarivera has quit IRC | 00:59 | |
| *** phuongnh has joined #openstack-nova | 01:02 | |
| *** kaisers__ has joined #openstack-nova | 01:02 | |
| *** zz_dimtruck is now known as dimtruck | 01:03 | |
| *** kaisers_ has quit IRC | 01:06 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Fix instance lookup in hide_server_addresses extension https://review.openstack.org/467772 | 01:07 |
| *** gianpietro has quit IRC | 01:08 | |
| *** gianpietro has joined #openstack-nova | 01:09 | |
| *** smatzek has joined #openstack-nova | 01:10 | |
| *** gianpietro has quit IRC | 01:13 | |
| *** Yangyapeng has joined #openstack-nova | 01:13 | |
| *** shaner has quit IRC | 01:19 | |
| *** owalsh_ has joined #openstack-nova | 01:19 | |
| *** shaner has joined #openstack-nova | 01:19 | |
| *** edmondsw has joined #openstack-nova | 01:20 | |
| *** yolkfull has joined #openstack-nova | 01:21 | |
| *** owalsh has quit IRC | 01:22 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Log traceback when bdm validation fails for unknown reason https://review.openstack.org/467809 | 01:23 |
| *** owalsh_ is now known as owalsh | 01:23 | |
| *** s1061123 has quit IRC | 01:24 | |
| *** fragatina has quit IRC | 01:24 | |
| *** crushil has quit IRC | 01:24 | |
| *** edmondsw has quit IRC | 01:25 | |
| *** crushil has joined #openstack-nova | 01:27 | |
| *** links has joined #openstack-nova | 01:30 | |
| *** s1061123 has joined #openstack-nova | 01:34 | |
| *** sree has joined #openstack-nova | 01:36 | |
| *** sree has quit IRC | 01:41 | |
| *** sofie_ has joined #openstack-nova | 01:41 | |
| openstackgerrit | John Griffith proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285 | 01:43 |
| *** mtanino__ has joined #openstack-nova | 01:44 | |
| *** thorst has joined #openstack-nova | 01:46 | |
| *** ihrachys has quit IRC | 01:48 | |
| *** acormier has quit IRC | 01:49 | |
| *** annp has joined #openstack-nova | 01:49 | |
| *** acormier has joined #openstack-nova | 01:49 | |
| *** tovin07_ has joined #openstack-nova | 01:51 | |
| *** Shunli has joined #openstack-nova | 01:52 | |
| *** acormier has quit IRC | 01:54 | |
| *** cNilesh has joined #openstack-nova | 01:56 | |
| *** gianpietro has joined #openstack-nova | 01:57 | |
| *** mtanino__ has quit IRC | 01:59 | |
| *** gianpietro has quit IRC | 02:01 | |
| *** thorst has quit IRC | 02:02 | |
| *** zhurong has joined #openstack-nova | 02:05 | |
| *** hongbin has joined #openstack-nova | 02:09 | |
| *** gjayavelu has joined #openstack-nova | 02:10 | |
| *** coreywright has quit IRC | 02:10 | |
| *** smatzek has quit IRC | 02:11 | |
| *** thorst has joined #openstack-nova | 02:14 | |
| *** ijw has joined #openstack-nova | 02:15 | |
| *** masayukig has joined #openstack-nova | 02:18 | |
| *** ijw has quit IRC | 02:18 | |
| *** ijw_ has joined #openstack-nova | 02:19 | |
| *** ijw__ has joined #openstack-nova | 02:20 | |
| *** ijw_ has quit IRC | 02:24 | |
| *** coreywright has joined #openstack-nova | 02:29 | |
| *** lucasxu has joined #openstack-nova | 02:33 | |
| *** xinliang has quit IRC | 02:34 | |
| *** thorst has quit IRC | 02:37 | |
| *** mtanino_ has joined #openstack-nova | 02:37 | |
| *** itlinux has joined #openstack-nova | 02:37 | |
| *** dikonoor has joined #openstack-nova | 02:45 | |
| *** xinliang has joined #openstack-nova | 02:47 | |
| *** dikonoo has quit IRC | 02:49 | |
| *** ihrachys has joined #openstack-nova | 02:49 | |
| *** ihrachys has quit IRC | 02:50 | |
| *** tuanluong has quit IRC | 02:50 | |
| *** rfolco has quit IRC | 02:52 | |
| *** mtanino_ has quit IRC | 02:56 | |
| *** gianpietro has joined #openstack-nova | 02:59 | |
| *** itlinux has quit IRC | 03:03 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Send out notifications when instance tags changed https://review.openstack.org/459923 | 03:03 |
| *** gianpietro has quit IRC | 03:03 | |
| *** armax has quit IRC | 03:06 | |
| *** lucasxu has quit IRC | 03:06 | |
| *** lucasxu has joined #openstack-nova | 03:08 | |
| *** edmondsw has joined #openstack-nova | 03:08 | |
| *** dikonoor has quit IRC | 03:13 | |
| *** edmondsw has quit IRC | 03:13 | |
| mriedem | Kevin_Zheng: looking better but no release note yet :) | 03:15 |
| Kevin_Zheng | ...ah...god, what was I thinking | 03:15 |
| *** lucasxu has quit IRC | 03:18 | |
| gmann | mriedem: re-thinking on quota class fix, as we are going to move quota/limit thing to keystone (as discussed in PTG) , is it worth to fix this API in microversion when there is a work around of getting default quotas from os-quota-set | 03:20 |
| gmann | mriedem: but yes that's per projects not global default | 03:20 |
| *** sree has joined #openstack-nova | 03:22 | |
| mriedem | gmann: it seems trivial to fix, | 03:26 |
| mriedem | and i'd rather not assume we're going to have nova using limits from keystone in queens | 03:26 |
| *** jichen has joined #openstack-nova | 03:26 | |
| mriedem | anyway, i have to call it a day | 03:27 |
| mriedem | ttyl | 03:27 |
| *** mriedem has quit IRC | 03:27 | |
| gmann | mriedem: ok, yea trivial but it increase microversion numbers :) anyways yea keystone limits might be far. | 03:27 |
| *** hamzy has joined #openstack-nova | 03:31 | |
| *** Sukhdev has joined #openstack-nova | 03:32 | |
| *** hongbin has quit IRC | 03:32 | |
| openstackgerrit | falseuser proposed openstack/nova master: Fix the problems that occur during rebuild operations https://review.openstack.org/467588 | 03:34 |
| *** crushil has quit IRC | 03:36 | |
| *** gjayavelu has quit IRC | 03:44 | |
| *** tuanluong has joined #openstack-nova | 03:47 | |
| *** dikonoor has joined #openstack-nova | 03:48 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: XenAPI use os-xenapi v2 in nova https://review.openstack.org/453493 | 03:48 |
| *** vks1 has joined #openstack-nova | 03:51 | |
| *** crushil has joined #openstack-nova | 03:54 | |
| *** gouthamr has quit IRC | 03:57 | |
| *** sayantan_ has joined #openstack-nova | 03:58 | |
| *** tuanluong has quit IRC | 03:59 | |
| sayantan_ | Hi. I am a little stuck. While creating an instance, I get the following error "no valid hosts found. There are no enough hosts available" | 04:00 |
| sayantan_ | When I check the nova-compute.log I see the error "nova.virt.libvirt.driver [-] Error defining a domain with XML: <domain type="kvm">" | 04:00 |
| sayantan_ | Any idea what is going wrong here? | 04:00 |
| *** sofie_ has quit IRC | 04:01 | |
| *** psachin has joined #openstack-nova | 04:05 | |
| *** tbachman has quit IRC | 04:07 | |
| *** zhurong has quit IRC | 04:08 | |
| *** Sukhdev has quit IRC | 04:11 | |
| *** markvoelker has joined #openstack-nova | 04:13 | |
| *** yamamoto has quit IRC | 04:13 | |
| *** yamamoto has joined #openstack-nova | 04:13 | |
| *** thorst has joined #openstack-nova | 04:16 | |
| *** zhurong has joined #openstack-nova | 04:16 | |
| *** yamamoto has quit IRC | 04:17 | |
| *** thorst has quit IRC | 04:18 | |
| *** dikonoor has quit IRC | 04:19 | |
| *** vks1 has quit IRC | 04:22 | |
| *** thorst has joined #openstack-nova | 04:26 | |
| *** yingjun has joined #openstack-nova | 04:30 | |
| *** diga has joined #openstack-nova | 04:31 | |
| *** thorst has quit IRC | 04:38 | |
| *** crushil has quit IRC | 04:38 | |
| *** vks1 has joined #openstack-nova | 04:38 | |
| *** xyang1 has quit IRC | 04:45 | |
| *** crushil has joined #openstack-nova | 04:50 | |
| *** ayogi has joined #openstack-nova | 04:52 | |
| *** edmondsw has joined #openstack-nova | 04:56 | |
| *** ltomasbo|away is now known as ltomasbo | 04:57 | |
| *** karthiks has joined #openstack-nova | 05:00 | |
| *** yamamoto has joined #openstack-nova | 05:01 | |
| *** edmondsw has quit IRC | 05:01 | |
| *** gyee has quit IRC | 05:03 | |
| *** mikal_ is now known as mikal | 05:06 | |
| *** markvoelker_ has joined #openstack-nova | 05:11 | |
| *** trinaths has joined #openstack-nova | 05:11 | |
| *** crushil has quit IRC | 05:13 | |
| *** markvoelker has quit IRC | 05:14 | |
| *** claudiub has joined #openstack-nova | 05:17 | |
| *** markvoelker has joined #openstack-nova | 05:17 | |
| *** dikonoor has joined #openstack-nova | 05:17 | |
| *** udesale has joined #openstack-nova | 05:17 | |
| *** markvoel_ has joined #openstack-nova | 05:19 | |
| *** markvoelker has quit IRC | 05:19 | |
| *** markvoelker_ has quit IRC | 05:21 | |
| *** slaweq has joined #openstack-nova | 05:23 | |
| *** ratailor has joined #openstack-nova | 05:24 | |
| *** sree has quit IRC | 05:28 | |
| *** lyan has quit IRC | 05:29 | |
| *** slaweq has quit IRC | 05:29 | |
| *** dikonoor has quit IRC | 05:29 | |
| *** kaisers__ has quit IRC | 05:30 | |
| *** thorst has joined #openstack-nova | 05:38 | |
| *** prateek has joined #openstack-nova | 05:40 | |
| *** thorst has quit IRC | 05:42 | |
| *** sree has joined #openstack-nova | 05:45 | |
| *** arunman has joined #openstack-nova | 05:49 | |
| *** diga has quit IRC | 05:51 | |
| *** markvoel_ has quit IRC | 05:53 | |
| *** markvoelker has joined #openstack-nova | 05:53 | |
| *** avolkov has joined #openstack-nova | 05:53 | |
| *** markvoelker has quit IRC | 05:54 | |
| *** kaisers_ has joined #openstack-nova | 06:00 | |
| *** sayantan_ has quit IRC | 06:02 | |
| *** vks1 has quit IRC | 06:06 | |
| *** Dinesh_Bhor has quit IRC | 06:06 | |
| *** thorst has joined #openstack-nova | 06:09 | |
| *** Dinesh_Bhor has joined #openstack-nova | 06:11 | |
| *** yolkfull_ has joined #openstack-nova | 06:15 | |
| openstackgerrit | suzhengwei proposed openstack/nova master: compute_model problem https://review.openstack.org/462897 | 06:17 |
| *** yolkfull has quit IRC | 06:17 | |
| *** Oku_OS-away is now known as Oku_OS | 06:18 | |
| *** rcernin has joined #openstack-nova | 06:18 | |
| *** kaisers_ has quit IRC | 06:19 | |
| *** sridharg has joined #openstack-nova | 06:19 | |
| *** kaisers_ has joined #openstack-nova | 06:19 | |
| *** sridharg has quit IRC | 06:19 | |
| *** sridharg has joined #openstack-nova | 06:20 | |
| *** sridharg has quit IRC | 06:20 | |
| *** sree has quit IRC | 06:20 | |
| *** sridharg has joined #openstack-nova | 06:20 | |
| *** pcaruana has joined #openstack-nova | 06:20 | |
| *** sree has joined #openstack-nova | 06:22 | |
| *** sree has quit IRC | 06:23 | |
| *** markvoelker has joined #openstack-nova | 06:27 | |
| *** mdnadeem has joined #openstack-nova | 06:27 | |
| *** thorst has quit IRC | 06:27 | |
| *** vks1 has joined #openstack-nova | 06:27 | |
| *** sree has joined #openstack-nova | 06:28 | |
| *** markvoelker has quit IRC | 06:32 | |
| *** avolkov has quit IRC | 06:32 | |
| *** diga has joined #openstack-nova | 06:35 | |
| *** yolkfull_ has quit IRC | 06:42 | |
| *** mnestratov has joined #openstack-nova | 06:42 | |
| *** edmondsw has joined #openstack-nova | 06:45 | |
| *** edmondsw has quit IRC | 06:49 | |
| *** adisky_ has joined #openstack-nova | 06:50 | |
| *** sree_ has joined #openstack-nova | 06:51 | |
| *** kaisers_ has quit IRC | 06:52 | |
| *** sree_ is now known as Guest52217 | 06:52 | |
| *** sree has quit IRC | 06:52 | |
| *** ralonsoh has joined #openstack-nova | 06:55 | |
| *** markvoelker has joined #openstack-nova | 06:59 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Send out notifications when instance tags changed https://review.openstack.org/459923 | 07:02 |
| *** markvoelker has quit IRC | 07:03 | |
| openstackgerrit | Ngo Quoc Cuong proposed openstack/nova master: Remove translation of log messages https://review.openstack.org/466995 | 07:06 |
| *** markvoelker has joined #openstack-nova | 07:09 | |
| *** gcb has quit IRC | 07:10 | |
| *** dixiaoli has joined #openstack-nova | 07:13 | |
| *** gcb has joined #openstack-nova | 07:14 | |
| *** markvoelker has quit IRC | 07:14 | |
| *** Guest52217 has quit IRC | 07:21 | |
| *** sree has joined #openstack-nova | 07:21 | |
| *** kaisers_ has joined #openstack-nova | 07:22 | |
| *** sree has quit IRC | 07:22 | |
| *** thorst has joined #openstack-nova | 07:24 | |
| *** sree has joined #openstack-nova | 07:24 | |
| *** markvoelker has joined #openstack-nova | 07:29 | |
| *** thorst has quit IRC | 07:29 | |
| *** zhurong has quit IRC | 07:30 | |
| *** dikonoor has joined #openstack-nova | 07:31 | |
| *** markvoelker has quit IRC | 07:37 | |
| *** fragatina has joined #openstack-nova | 07:38 | |
| *** karimb has joined #openstack-nova | 07:41 | |
| *** markvoelker has joined #openstack-nova | 07:42 | |
| *** fragatina has quit IRC | 07:44 | |
| *** zhurong has joined #openstack-nova | 07:45 | |
| *** markvoelker has quit IRC | 07:49 | |
| *** kaisers_ has quit IRC | 07:51 | |
| *** kaisers_ has joined #openstack-nova | 07:51 | |
| *** moshele has joined #openstack-nova | 07:52 | |
| *** jpena|off is now known as jpena | 07:58 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-nova | 08:02 | |
| *** fragatina has joined #openstack-nova | 08:05 | |
| *** lucas-pto is now known as lucasagomes | 08:08 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Exclude deleted service records when calling hyperrvisor statistics https://review.openstack.org/467220 | 08:12 |
| *** kaisers_ has quit IRC | 08:13 | |
| *** sheel has joined #openstack-nova | 08:13 | |
| *** yolkfull_ has joined #openstack-nova | 08:14 | |
| *** yolkfull_ has quit IRC | 08:16 | |
| *** yolkfull_ has joined #openstack-nova | 08:17 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(2/4) https://review.openstack.org/459569 | 08:22 |
| *** markvoelker has joined #openstack-nova | 08:24 | |
| *** thorst has joined #openstack-nova | 08:25 | |
| *** efoley__ has joined #openstack-nova | 08:26 | |
| *** efoley_ has joined #openstack-nova | 08:28 | |
| *** avolkov has joined #openstack-nova | 08:28 | |
| *** thorst has quit IRC | 08:29 | |
| *** markvoelker has quit IRC | 08:30 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: XenAPI: Fix vif plug problem https://review.openstack.org/467926 | 08:30 |
| *** trinaths has left #openstack-nova | 08:31 | |
| *** efoley__ has quit IRC | 08:31 | |
| *** markvoelker has joined #openstack-nova | 08:32 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: XenAPI: nova-compute cannot restart after manually delete VM https://review.openstack.org/467926 | 08:36 |
| *** lpetrut has joined #openstack-nova | 08:37 | |
| *** phuongnh has quit IRC | 08:38 | |
| *** phuongnh has joined #openstack-nova | 08:39 | |
| *** markvoelker has quit IRC | 08:40 | |
| *** sree has quit IRC | 08:42 | |
| *** sree has joined #openstack-nova | 08:42 | |
| *** kaisers_ has joined #openstack-nova | 08:43 | |
| *** gszasz has joined #openstack-nova | 08:44 | |
| *** sree has quit IRC | 08:44 | |
| *** sree has joined #openstack-nova | 08:45 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: XenAPI use os-xenapi v2 in nova https://review.openstack.org/453493 | 08:48 |
| *** zhurong has quit IRC | 08:54 | |
| *** baoli has joined #openstack-nova | 09:02 | |
| *** vks1 has quit IRC | 09:02 | |
| *** sree_ has joined #openstack-nova | 09:02 | |
| *** sree_ is now known as Guest88807 | 09:03 | |
| *** zhurong has joined #openstack-nova | 09:04 | |
| *** sree has quit IRC | 09:04 | |
| *** baoli has quit IRC | 09:06 | |
| *** Guest88807 has quit IRC | 09:07 | |
| *** derekh has joined #openstack-nova | 09:09 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Send out notifications when instance tags changed https://review.openstack.org/459923 | 09:11 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add api-ref for os-quota-class-set APIs https://review.openstack.org/467938 | 09:16 |
| *** markvoelker has joined #openstack-nova | 09:16 | |
| *** diga has quit IRC | 09:17 | |
| *** priteau has joined #openstack-nova | 09:17 | |
| *** markvoelker has quit IRC | 09:21 | |
| *** phuongnh has quit IRC | 09:25 | |
| *** Shunli has quit IRC | 09:26 | |
| *** phuongnh has joined #openstack-nova | 09:26 | |
| *** thorst has joined #openstack-nova | 09:26 | |
| openstackgerrit | Ngo Quoc Cuong proposed openstack/nova master: Remove translation of log messages https://review.openstack.org/466995 | 09:26 |
| openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for os-services endpoint instead of stevedore https://review.openstack.org/460818 | 09:28 |
| *** thorst has quit IRC | 09:30 | |
| openstackgerrit | Ngo Quoc Cuong proposed openstack/nova master: Remove translation of log messages https://review.openstack.org/466995 | 09:32 |
| alex_xu | sfinucan: appreciate if you can approve this one https://review.openstack.org/#/c/461628/ | 09:32 |
| alex_xu | litao__: yea, it is on my review list | 09:32 |
| openstackgerrit | Ngo Quoc Cuong proposed openstack/nova master: Remove translation of log messages https://review.openstack.org/467948 | 09:33 |
| litao__ | alex_xu: thanks | 09:33 |
| openstackgerrit | Bin Zhou proposed openstack/nova master: Insert the description of the change. https://review.openstack.org/467952 | 09:34 |
| *** udesale has quit IRC | 09:34 | |
| *** zhurong has quit IRC | 09:35 | |
| *** yingjun has quit IRC | 09:37 | |
| *** udesale has joined #openstack-nova | 09:39 | |
| alex_xu | litao__: np | 09:40 |
| *** mvk_ has quit IRC | 09:41 | |
| *** takashin has left #openstack-nova | 09:44 | |
| *** cdent has joined #openstack-nova | 09:46 | |
| *** sambetts|afk is now known as sambetts | 09:46 | |
| *** sdague has joined #openstack-nova | 09:46 | |
| *** gomarivera has joined #openstack-nova | 09:47 | |
| *** jichen has quit IRC | 09:47 | |
| *** udesale has quit IRC | 09:48 | |
| *** gomarivera has quit IRC | 09:51 | |
| *** udesale has joined #openstack-nova | 09:53 | |
| *** markvoelker has joined #openstack-nova | 09:54 | |
| *** rmart04 has joined #openstack-nova | 09:58 | |
| *** markvoelker has quit IRC | 09:58 | |
| *** tovin07_ has quit IRC | 10:00 | |
| *** cNilesh has quit IRC | 10:02 | |
| *** cNilesh has joined #openstack-nova | 10:03 | |
| *** tbachman has joined #openstack-nova | 10:04 | |
| *** mvk has joined #openstack-nova | 10:09 | |
| *** yamamoto has quit IRC | 10:11 | |
| *** cNilesh has quit IRC | 10:12 | |
| *** sfinucan has quit IRC | 10:19 | |
| *** sfinucan has joined #openstack-nova | 10:19 | |
| *** edmondsw has joined #openstack-nova | 10:21 | |
| *** sheel has quit IRC | 10:22 | |
| *** vks1 has joined #openstack-nova | 10:23 | |
| *** kaisers_ has quit IRC | 10:23 | |
| *** udesale has quit IRC | 10:23 | |
| *** udesale has joined #openstack-nova | 10:23 | |
| *** edmondsw has quit IRC | 10:25 | |
| openstackgerrit | Lucian Petrut proposed openstack/nova master: [Trivial] Hyper-V: accept Glance vhdx images https://review.openstack.org/467369 | 10:27 |
| *** thorst has joined #openstack-nova | 10:27 | |
| *** annp has quit IRC | 10:27 | |
| *** Yangyapeng has quit IRC | 10:30 | |
| *** tbachman has quit IRC | 10:31 | |
| *** thorst has quit IRC | 10:31 | |
| *** dixiaoli has quit IRC | 10:39 | |
| *** dikonoor has quit IRC | 10:43 | |
| *** tbachman has joined #openstack-nova | 10:47 | |
| *** markvoelker has joined #openstack-nova | 10:47 | |
| *** lucasagomes is now known as lucas-hungry | 10:48 | |
| *** mingyu has joined #openstack-nova | 10:48 | |
| *** tbachman has quit IRC | 10:52 | |
| *** markvoelker has quit IRC | 10:52 | |
| *** mingyu has quit IRC | 10:53 | |
| *** markvoelker has joined #openstack-nova | 10:55 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: remove oslo.context exact key tests https://review.openstack.org/467995 | 10:58 |
| *** yamamoto has joined #openstack-nova | 10:58 | |
| *** dikonoor has joined #openstack-nova | 10:59 | |
| *** markvoelker has quit IRC | 10:59 | |
| sdague | sfinucan / bauzas ^^^ | 11:00 |
| sdague | we have unit tests that break on the new oslo.context because legacy | 11:00 |
| sdague | we should just delete them | 11:00 |
| *** Yangyapeng has joined #openstack-nova | 11:02 | |
| *** Yangyapeng has quit IRC | 11:02 | |
| *** mtanino_ has joined #openstack-nova | 11:07 | |
| *** acormier has joined #openstack-nova | 11:09 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: Migrate to oslo request_id middleware https://review.openstack.org/467998 | 11:10 |
| *** markvoelker has joined #openstack-nova | 11:14 | |
| *** smatzek has joined #openstack-nova | 11:15 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Send out notifications when instance tags changed https://review.openstack.org/459923 | 11:17 |
| *** markvoelker has quit IRC | 11:19 | |
| *** phuongnh has quit IRC | 11:20 | |
| *** yolkfull_ has quit IRC | 11:21 | |
| *** dimtruck is now known as zz_dimtruck | 11:24 | |
| *** jpena is now known as jpena|lunch | 11:26 | |
| *** yingjun has joined #openstack-nova | 11:27 | |
| *** prateek has quit IRC | 11:28 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix to return server groups quota in quota class set https://review.openstack.org/467999 | 11:28 |
| *** acormier has quit IRC | 11:29 | |
| *** acormier has joined #openstack-nova | 11:29 | |
| *** markvoelker has joined #openstack-nova | 11:29 | |
| gmann | alex_xu: ^^ fix for quota class set bug, i put this as WIP till you push the spec for this | 11:30 |
| *** acormier has quit IRC | 11:34 | |
| *** markvoelker has quit IRC | 11:34 | |
| *** gianpietro has joined #openstack-nova | 11:35 | |
| *** gianpietro has quit IRC | 11:40 | |
| sdague | alex_xu: oh, if you are still up https://review.openstack.org/467995 | 11:43 |
| *** arunman has quit IRC | 11:43 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add api-ref for os-quota-class-set APIs https://review.openstack.org/467938 | 11:44 |
| *** dikonoor has quit IRC | 11:45 | |
| *** amrith has left #openstack-nova | 11:48 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Exclude deleted service records when calling hyperrvisor statistics https://review.openstack.org/467220 | 11:48 |
| *** rfolco has joined #openstack-nova | 11:50 | |
| *** gianpietro has joined #openstack-nova | 11:52 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Handle new hosts for updating instance info in scheduler https://review.openstack.org/454426 | 11:52 |
| *** gianpietro has quit IRC | 11:53 | |
| *** lucas-hungry is now known as lucasagomes | 11:55 | |
| *** thorst has joined #openstack-nova | 11:58 | |
| *** edmondsw has joined #openstack-nova | 11:58 | |
| *** ekuris has quit IRC | 11:58 | |
| *** udesale has quit IRC | 11:59 | |
| *** udesale has joined #openstack-nova | 11:59 | |
| *** udesale has quit IRC | 11:59 | |
| gmann | sdague: alex_xu: added api-ref for quota class set and documented the bug there. check if it looks fine. https://review.openstack.org/467938 | 11:59 |
| *** markvoelker has joined #openstack-nova | 12:00 | |
| *** kylek3h has quit IRC | 12:00 | |
| gmann | adding this API mystery&magic as warning :) | 12:00 |
| *** ratailor has quit IRC | 12:04 | |
| *** markvoelker has quit IRC | 12:04 | |
| sdague | cool, I'll take a look in a bit | 12:04 |
| *** dikonoor has joined #openstack-nova | 12:08 | |
| *** lyan has joined #openstack-nova | 12:09 | |
| *** vks1 has quit IRC | 12:10 | |
| *** markvoelker has joined #openstack-nova | 12:11 | |
| *** acormier has joined #openstack-nova | 12:11 | |
| *** zz_dimtruck is now known as dimtruck | 12:11 | |
| *** acormier has joined #openstack-nova | 12:12 | |
| *** ekuris has joined #openstack-nova | 12:14 | |
| *** tbachman has joined #openstack-nova | 12:14 | |
| *** mtanino_ has quit IRC | 12:14 | |
| *** kylek3h has joined #openstack-nova | 12:15 | |
| *** markvoelker has quit IRC | 12:15 | |
| *** bhagyashris has quit IRC | 12:16 | |
| *** markvoelker has joined #openstack-nova | 12:17 | |
| mdbooth | After tearing my hair out for most of the morning it transpires that os-client-config, rather than just reading environment variables, actually pops them. I mean, why would anybody want to look an an environment variable again? | 12:19 |
| *** ayogi has quit IRC | 12:19 | |
| *** pchavva has joined #openstack-nova | 12:19 | |
| mdbooth | Of course, this breaks anything which gets a config more than once | 12:19 |
| mdbooth | Like OVB deploy, for eg | 12:20 |
| *** prateek has joined #openstack-nova | 12:21 | |
| *** markvoelker has quit IRC | 12:22 | |
| *** gianpietro has joined #openstack-nova | 12:24 | |
| *** karthiks has quit IRC | 12:24 | |
| *** roeyc has joined #openstack-nova | 12:25 | |
| *** roeyc has quit IRC | 12:25 | |
| *** acormier has quit IRC | 12:25 | |
| *** roeyc has joined #openstack-nova | 12:25 | |
| *** acormier has joined #openstack-nova | 12:25 | |
| *** gomarivera has joined #openstack-nova | 12:26 | |
| *** gianpietro has quit IRC | 12:26 | |
| *** tbachman has quit IRC | 12:28 | |
| *** tbachman has joined #openstack-nova | 12:28 | |
| openstackgerrit | Lars Kellogg-Stedman proposed openstack/nova master: provide interface-scoped nameserver information https://review.openstack.org/467699 | 12:30 |
| *** acormier has quit IRC | 12:30 | |
| *** bhagyashris has joined #openstack-nova | 12:31 | |
| *** gianpietro has joined #openstack-nova | 12:32 | |
| *** gianpietro has quit IRC | 12:32 | |
| *** gomarivera has quit IRC | 12:35 | |
| *** efoley__ has joined #openstack-nova | 12:35 | |
| *** gomarivera has joined #openstack-nova | 12:35 | |
| *** yingjun has quit IRC | 12:37 | |
| *** efoley_ has quit IRC | 12:39 | |
| *** pewp has quit IRC | 12:39 | |
| *** pewp has joined #openstack-nova | 12:40 | |
| *** gomarivera has quit IRC | 12:40 | |
| *** kylek3h has quit IRC | 12:41 | |
| *** efried has joined #openstack-nova | 12:46 | |
| *** lyan has quit IRC | 12:49 | |
| *** arunman has joined #openstack-nova | 12:49 | |
| cdent | mdbooth: the universe does not want you to have hair | 12:49 |
| *** jpena|lunch is now known as jpena | 12:51 | |
| *** acormier has joined #openstack-nova | 12:52 | |
| *** acormier has quit IRC | 12:52 | |
| *** acormier has joined #openstack-nova | 12:53 | |
| *** links has quit IRC | 12:54 | |
| *** markvoelker has joined #openstack-nova | 12:56 | |
| *** yamamoto has quit IRC | 12:56 | |
| *** liverpooler has joined #openstack-nova | 12:56 | |
| *** moshele has quit IRC | 12:57 | |
| *** acormier has quit IRC | 12:58 | |
| *** acormier has joined #openstack-nova | 12:59 | |
| *** Yangyapeng has joined #openstack-nova | 12:59 | |
| *** gouthamr has joined #openstack-nova | 13:01 | |
| *** yamamoto has joined #openstack-nova | 13:02 | |
| *** acormier has quit IRC | 13:04 | |
| *** baoli has joined #openstack-nova | 13:05 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: Migrate to oslo request_id middleware https://review.openstack.org/467998 | 13:09 |
| *** gianpietro has joined #openstack-nova | 13:11 | |
| *** psachin has quit IRC | 13:13 | |
| *** baoli has quit IRC | 13:13 | |
| *** baoli has joined #openstack-nova | 13:13 | |
| *** ctrath has joined #openstack-nova | 13:15 | |
| *** mdrabe has joined #openstack-nova | 13:16 | |
| *** lucasxu has joined #openstack-nova | 13:16 | |
| *** efoley_ has joined #openstack-nova | 13:19 | |
| *** lyan has joined #openstack-nova | 13:21 | |
| savvas | smcginnis: good morning! Were you by any chance able to reproduce that issue I reported yesterday regarding the Any Availability zone selection when creating an instance? Which resulted in cinder failing to create a volume | 13:22 |
| *** efoley__ has quit IRC | 13:23 | |
| *** mriedem has joined #openstack-nova | 13:23 | |
| mriedem | o/ | 13:23 |
| *** sridharg has quit IRC | 13:23 | |
| smcginnis | savvas: Unfortunately no, having some issues getting it set up at the moment. | 13:24 |
| smcginnis | savvas: I was wondering if you could open a bug to make sure we track this? | 13:24 |
| mriedem | dansmith: i've got super special early morning news, the stable/newton backport of the db creds special characters fix and all changes below it are passing https://review.openstack.org/#/c/466808/ https://review.openstack.org/#/c/420750/ https://review.openstack.org/#/c/420876/ | 13:24 |
| mriedem | including the change for the cell0 db name | 13:24 |
| smcginnis | savvas: I looked through the code quick and it does look like we should be handling None correctly. | 13:24 |
| savvas | I'd be happy to. Where should I report this? | 13:25 |
| *** fragatina has quit IRC | 13:25 | |
| *** dixiaoli has joined #openstack-nova | 13:26 | |
| sdague | mriedem: did you get my email on the db test case debug? | 13:26 |
| mriedem | sdague: reading now | 13:26 |
| smcginnis | savvas: In the top right corner here: https://bugs.launchpad.net/cinder/+bugs | 13:26 |
| sdague | cell1 is still sqlite | 13:26 |
| sdague | is the tldr | 13:26 |
| *** lucasxu has quit IRC | 13:27 | |
| *** roeyc has quit IRC | 13:27 | |
| *** lucasxu has joined #openstack-nova | 13:27 | |
| mriedem | hmm | 13:27 |
| mriedem | that's got to all be done in a fixture, | 13:28 |
| *** roeyc has joined #openstack-nova | 13:28 | |
| mriedem | and i'd think we could sub the db engine | 13:28 |
| *** dixiaoli has quit IRC | 13:28 | |
| sdague | yeh, the cell magic switchero fixture is pretty complicated, but it's in there | 13:29 |
| sdague | the real challenge is that because we're running this all in a single process, there was something about the context manager that was "interesting" that melwitt and dansmith worked through | 13:29 |
| mriedem | fwiw i didn't think i was using the main cell database fixture | 13:30 |
| mriedem | that did all the switching stuff | 13:30 |
| mriedem | i was using the SimpleCellFixture, which i'm not sure is right to use, but i thought would be simpler to start | 13:31 |
| sdague | mriedem: no this - https://github.com/openstack/nova/blob/76c2453682a7afa26ff2a7eb825e900af53a61d6/nova/tests/fixtures.py#L363-L532 | 13:31 |
| mriedem | right i didn't tihnk i was using that | 13:31 |
| sdague | right, you aren't | 13:31 |
| sdague | and because of that, it doesn't work | 13:31 |
| sdague | because engine facade is global | 13:32 |
| mriedem | huh, i thought SimpleCellFixture would take care of things | 13:32 |
| danpawlik | Morning | 13:32 |
| mriedem | this one https://github.com/openstack/nova/blob/76c2453682a7afa26ff2a7eb825e900af53a61d6/nova/tests/fixtures.py#L257 | 13:32 |
| sdague | I'm pretty sure that stopped working once there was the context manager calls | 13:32 |
| *** esberglu has joined #openstack-nova | 13:32 | |
| *** markvoelker has quit IRC | 13:33 | |
| *** pwiltsey has joined #openstack-nova | 13:33 | |
| mriedem | https://github.com/openstack/nova/blob/76c2453682a7afa26ff2a7eb825e900af53a61d6/nova/tests/fixtures.py#L328 ? | 13:33 |
| sdague | https://github.com/openstack/nova/blob/76c2453682a7afa26ff2a7eb825e900af53a61d6/nova/compute/api.py#L2401 is basically where it goes off the rails | 13:33 |
| *** prateek has quit IRC | 13:33 | |
| *** lucasxu has quit IRC | 13:33 | |
| *** sree has joined #openstack-nova | 13:33 | |
| mriedem | that shouldn't actually do anything https://github.com/openstack/nova/blob/76c2453682a7afa26ff2a7eb825e900af53a61d6/nova/tests/fixtures.py#L296 | 13:33 |
| sdague | the inst_map.cell_mapping is | 13:34 |
| sdague | CellMapping(created_at=None,database_connection='sqlite:///',id=1,name='onlycell',transport_url='fake://nowhere/',updated_at=None,uuid=1d5950cd-863a-4eb6-a3ec-3583fc93fbfc) | 13:34 |
| mriedem | sdague: yeah i think because of this https://github.com/openstack/nova/blob/76c2453682a7afa26ff2a7eb825e900af53a61d6/nova/tests/fixtures.py#L328 | 13:34 |
| mriedem | i think SingleCellSimple is too simple here | 13:34 |
| mriedem | and why i wasn't sure it would work | 13:34 |
| mriedem | so that confirms it | 13:34 |
| sdague | yeh | 13:34 |
| *** lucasxu has joined #openstack-nova | 13:34 | |
| mriedem | well, i think i can add the cell1 mapping manually | 13:35 |
| mriedem | we have the api db setup | 13:35 |
| sdague | so, I guess the question is if you can pull that from your config | 13:35 |
| sdague | yeh | 13:35 |
| danpawlik | mriedem: Please check my PS https://review.openstack.org/#/c/459753/ . Thanks! | 13:35 |
| mriedem | i think i just create the main cell db, and use that url for the cell1 mapping db connection | 13:35 |
| sdague | mriedem: ok, but before you dive in there | 13:35 |
| sdague | we need to delete some overly agressive context unit tests - https://review.openstack.org/#/c/467995/ | 13:36 |
| sdague | to get a version of oslo.context out there that lets us do global request id | 13:36 |
| mriedem | danpawlik: if that doesn't work for windows guests then you should probably point that out as a limitation in the release note | 13:37 |
| *** jwcroppe has quit IRC | 13:38 | |
| *** yamahata has joined #openstack-nova | 13:39 | |
| danpawlik | mriedem: it works on Windows | 13:39 |
| danpawlik | I checked it on my infra and it works without any problem | 13:40 |
| *** baoli_ has joined #openstack-nova | 13:40 | |
| danpawlik | mriedem: this functionality with vendor_id and fake hyperv id is additional. It normally works on new nvidia drivers | 13:41 |
| *** sree has quit IRC | 13:42 | |
| *** sree has joined #openstack-nova | 13:43 | |
| *** baoli has quit IRC | 13:43 | |
| *** lucasxu has quit IRC | 13:43 | |
| *** lucasxu has joined #openstack-nova | 13:43 | |
| *** gomarivera has joined #openstack-nova | 13:44 | |
| *** eharney has joined #openstack-nova | 13:46 | |
| *** mtanino_ has joined #openstack-nova | 13:48 | |
| mriedem | sdague: questions inline | 13:48 |
| sdague | mriedem: looking | 13:48 |
| *** sree has quit IRC | 13:49 | |
| *** Yangyapeng has quit IRC | 13:50 | |
| sdague | mriedem: I can add a really small test that just looks for our key adds | 13:50 |
| mriedem | we should have something | 13:50 |
| mriedem | i'm also having a hard time seeing what's different in here http://logs.openstack.org/12/467812/1/check/gate-cross-nova-python27-ubuntu-xenial/1aa9e05/console.html#_2017-05-25_03_56_24_617422 | 13:50 |
| *** gianpietro has quit IRC | 13:51 | |
| mriedem | global_request_id ? | 13:51 |
| sdague | yes | 13:52 |
| *** Yangyapeng has joined #openstack-nova | 13:53 | |
| *** jwcroppe has joined #openstack-nova | 13:53 | |
| mriedem | sdague: is there a reason we don't call super from_dict? like is_admin_project is in the parent class from_dict but not the nova one | 13:55 |
| mriedem | was just looking at https://github.com/openstack/nova/commit/80738df83f4cdd7a3143b157b73d1a9e6b3b2c40 | 13:55 |
| sdague | mriedem: only because legacy, which is totally going to screw us other places | 13:55 |
| mriedem | was just looking at this https://github.com/openstack/nova/blob/master/nova/context.py#L196 | 13:55 |
| sdague | yeh | 13:55 |
| *** crushil has joined #openstack-nova | 13:57 | |
| *** tbachman has quit IRC | 13:57 | |
| *** pchavva has quit IRC | 13:57 | |
| *** tidwellr has joined #openstack-nova | 13:58 | |
| *** pchavva has joined #openstack-nova | 13:58 | |
| sdague | our context on the other side of the RPC bus actually diverges a lot | 13:59 |
| sdague | ok, let me see about an additional fix here | 13:59 |
| *** dhiaeddine has joined #openstack-nova | 14:01 | |
| *** dimtruck is now known as zz_dimtruck | 14:02 | |
| *** yamahata has quit IRC | 14:02 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Send out notifications when instance tags changed https://review.openstack.org/459923 | 14:07 |
| *** moshele has joined #openstack-nova | 14:08 | |
| *** jaypipes has joined #openstack-nova | 14:09 | |
| *** awaugama has joined #openstack-nova | 14:09 | |
| efried | jaypipes (hopefully) quick question... | 14:11 |
| efried | jaypipes https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L443-L446 <== does this have a sync issue? | 14:12 |
| *** coreywright has quit IRC | 14:12 | |
| efried | jaypipes If multiple clients are doing this at the same time for the same resource provider, that is? | 14:12 |
| efried | jaypipes I guess in this context, since it's in the scheduler, and there's only one of those (right?) that's not possible...? | 14:13 |
| jaypipes | efried: that isn't the scheduler :) | 14:13 |
| jaypipes | efried: common mistake... | 14:13 |
| efried | bah, ignorance | 14:13 |
| jaypipes | efried: that's in the compute resource tracker. | 14:13 |
| jaypipes | efried: which holds the COMPUTE_NODE_SEMAPHORE when that is called. | 14:13 |
| *** pwiltsey has quit IRC | 14:13 | |
| efried | jaypipes Ah, the COMPUTE_NODE_SEMAPHORE. | 14:14 |
| *** moshele has quit IRC | 14:14 | |
| *** pwiltsey has joined #openstack-nova | 14:14 | |
| jaypipes | efried: we might consider adding some thread-level locking, though, if that routine would get hit outside of the compute node resource tracker (if, for example, _ensure_resource_provider() were called by some of the new claims routines, but I don't think that's going to be the case) | 14:14 |
| efried | jaypipes Uhm, not finding that. Am I spelling it right? | 14:14 |
| *** markvoelker has joined #openstack-nova | 14:15 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: Have nova.context use super from_context https://review.openstack.org/467995 | 14:15 |
| efried | jaypipes Well, next question would be whether it's kosher for me to take that (big-sounding) semaphore from my compute driver at init. | 14:15 |
| sdague | mriedem: ok, hopefully that's better there | 14:15 |
| jaypipes | efried: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L645 | 14:15 |
| *** ijw__ has quit IRC | 14:15 | |
| jaypipes | efried: COMPUTE_RESOURCE_SEMAPHORE, sorry | 14:15 |
| *** kaisers_ has joined #openstack-nova | 14:15 | |
| efried | jaypipes I guess what I was hoping was that the placement API itself would have internal sync, and some kind of deterministic response if I POST a resource that's already there... | 14:16 |
| efried | Like a 412 response, mebbe | 14:16 |
| jaypipes | efried: it does. | 14:17 |
| mriedem | sdague: ok going to also want dansmith to review this | 14:17 |
| sdague | mriedem: sure | 14:17 |
| jaypipes | efried: there is a unique constraint on resource provider name which will throw a 409. | 14:17 |
| *** sree has joined #openstack-nova | 14:17 | |
| efried | jaypipes Ah, good deal. So I don't have to use that semaphore; I can just catch-and-ignore the 409. | 14:17 |
| jaypipes | efried: and then there is a generation field on the resource provider that is used to catch concurrent updates. | 14:17 |
| jaypipes | efried: look for ConcurrentUpdateDetected in the placement code. | 14:18 |
| *** pwiltsey has quit IRC | 14:18 | |
| efried | jaypipes But of course I don't have to read the placement code to find this out, cause it's documented in the placement API ref, right? | 14:18 |
| jaypipes | efried: you mean like this does already? :) https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L388-L400 | 14:18 |
| openstackgerrit | Dan Smith proposed openstack/nova master: re-Allow adding computes with no ComputeNodes to aggregates https://review.openstack.org/460616 | 14:18 |
| jaypipes | efried: placement api-ref is ongoing. avolkov is working on that. | 14:19 |
| efried | jaypipes Perfect, thanks. Missed that on my first couple read-throughs ;-) | 14:19 |
| jaypipes | avolkov: can you link efried your api-ref patch series so he can review please? | 14:19 |
| efried | (course I didn't know I was looking for 409, so I forgive myself) | 14:19 |
| jaypipes | efried: I live to serve. | 14:19 |
| efried | (though the comment is eminently helpful) | 14:19 |
| dansmith | mriedem: had to rebase again ^ | 14:20 |
| efried | jaypipes I'm still gonna have to come back atcha when it comes to identifying the shared-ness of my resource; but baby steps. | 14:20 |
| avolkov | efried: jaypipes: https://review.openstack.org/#/c/449765/ | 14:20 |
| *** vks1 has joined #openstack-nova | 14:20 | |
| *** kaisers_ has quit IRC | 14:20 | |
| mriedem | dansmith: i bet you can do some horse trading with sdague on his context patch | 14:21 |
| jaypipes | efried: resources aren't shared :) resource providers are decorated with the MISC_SHARES_VIA_AGGREGATE trait. | 14:21 |
| avolkov | efried: jaypipes: and built version http://docs-draft.openstack.org/96/467596/2/check/gate-placement-api-ref-nv/7cd3495//placement-api-ref/build/html/ | 14:21 |
| *** acormier has joined #openstack-nova | 14:21 | |
| jaypipes | efried: https://review.openstack.org/#/q/topic:cd/placement-api-ref+status:open | 14:22 |
| mriedem | dansmith: the rebase is gone | 14:22 |
| mriedem | *wrong | 14:22 |
| *** sree has quit IRC | 14:22 | |
| jaypipes | efried: you'll notice we use a similar strategy for most resource creation in the placement client: https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L784-L789 | 14:22 |
| mriedem | but thanks for the stat padding | 14:22 |
| mriedem | oh wait | 14:22 |
| *** READ10 has joined #openstack-nova | 14:23 | |
| mriedem | yeah, | 14:23 |
| mriedem | wrong again | 14:23 |
| *** markvoelker has quit IRC | 14:23 | |
| *** udesale has joined #openstack-nova | 14:23 | |
| efried | avolkov jaypipes Thanks y'all. | 14:23 |
| *** udesale has quit IRC | 14:23 | |
| dansmith | mriedem: okay, I'm doing like six things at once, so I'll look again in a sec | 14:24 |
| *** yamamoto has quit IRC | 14:24 | |
| *** udesale has joined #openstack-nova | 14:24 | |
| *** ekuris has quit IRC | 14:25 | |
| *** r-daneel has joined #openstack-nova | 14:25 | |
| danpawlik | mriedem: http://imgur.com/g5Mo9KT | 14:25 |
| *** coreywright has joined #openstack-nova | 14:26 | |
| jaypipes | dansmith: only six? | 14:26 |
| *** jamesdenton has joined #openstack-nova | 14:27 | |
| dansmith | jaypipes: I can only count that high | 14:27 |
| *** armax has joined #openstack-nova | 14:27 | |
| danpawlik | mriedem: I don't have ant problems to install new nvidia drivers if vendor is not set | 14:28 |
| danpawlik | mriedem: I try to install the newest drivers | 14:28 |
| dansmith | mriedem: oh, I don't get why git keeps dropping that removal | 14:29 |
| mriedem | danpawlik: ok | 14:29 |
| *** zz_dimtruck is now known as dimtruck | 14:29 | |
| mriedem | dansmith: you can blame it on the rain, but you can't blame it on git | 14:29 |
| mriedem | sdague: question/comment in https://review.openstack.org/#/c/467995/ | 14:29 |
| *** felipemonteiro has joined #openstack-nova | 14:30 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: Migrate to oslo request_id middleware https://review.openstack.org/467998 | 14:30 |
| sdague | mriedem: looking | 14:30 |
| *** Swami has joined #openstack-nova | 14:30 | |
| *** Dave has quit IRC | 14:30 | |
| *** Swami has quit IRC | 14:31 | |
| dansmith | mriedem: well, it just drops that hunk without calling it a conflict, so I'll blame it anyway | 14:32 |
| *** ctrath1 has joined #openstack-nova | 14:32 | |
| *** kfarr has quit IRC | 14:32 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: re-Allow adding computes with no ComputeNodes to aggregates https://review.openstack.org/460616 | 14:32 |
| dansmith | maybe we could merge this and avoid me chasing rebases | 14:32 |
| sdague | mriedem: answered | 14:32 |
| sdague | the constructor for oslo.context in the from_ methods use the original class | 14:33 |
| mriedem | https://s-media-cache-ak0.pinimg.com/236x/75/c1/dc/75c1dcb4c3ab545deeb1f192eef3c0af.jpg?noindex=1 | 14:33 |
| mriedem | just a bunch of hunks | 14:33 |
| *** claudiub has quit IRC | 14:33 | |
| sdague | so that's how we still end up with nova context | 14:33 |
| sdague | after the super call | 14:33 |
| sdague | links in review | 14:33 |
| mriedem | # TODO(sdague): also context has show_deleted, we should | 14:34 |
| mriedem | also or oslo? | 14:34 |
| *** ctrath has quit IRC | 14:35 | |
| mriedem | dansmith: i've been your huckleberry for weeks on this one | 14:35 |
| *** dimtruck is now known as zz_dimtruck | 14:35 | |
| sdague | mriedem: heh, yeh | 14:36 |
| sdague | I can fix the typo | 14:36 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Have nova.context use super from_context https://review.openstack.org/467995 | 14:37 |
| mriedem | alex_xu: jaypipes: re-confirming, but when deleting a service we don't actually delete the compute_nodes record, | 14:37 |
| mriedem | nothing actually deletes the compute_nodes record | 14:37 |
| mriedem | https://review.openstack.org/#/c/467220/4//COMMIT_MSG | 14:37 |
| *** zz_dimtruck is now known as dimtruck | 14:37 | |
| *** lucasxu has quit IRC | 14:39 | |
| *** yamamoto has joined #openstack-nova | 14:39 | |
| openstackgerrit | Matt Rabe proposed openstack/nova master: Query deleted instance records during _destroy_evacuated_instances https://review.openstack.org/467774 | 14:40 |
| danpawlik | mriedem: new drivers install correctly. I will add mention about windows and vendor_id | 14:41 |
| danpawlik | in release notes soon | 14:41 |
| *** sree has joined #openstack-nova | 14:41 | |
| edleafe | jaypipes: got a minute (or 10) to talk about https://review.openstack.org/#/c/465171/ ? | 14:43 |
| jaypipes | edleafe: on call for 15, then free. | 14:43 |
| edleafe | jaypipes: okee dokee | 14:44 |
| *** yamamoto has quit IRC | 14:44 | |
| *** vks1 has quit IRC | 14:45 | |
| *** hongbin has joined #openstack-nova | 14:45 | |
| *** ctrath1 has quit IRC | 14:45 | |
| *** sree has quit IRC | 14:46 | |
| cdent | edleafe: ping me when you start, I'd like to ride along please | 14:46 |
| edleafe | cdent: roger that | 14:46 |
| sdague | mriedem: the context bits look good to you now? | 14:47 |
| sdague | given that we're blocking a constraint update on that | 14:47 |
| *** udesale has quit IRC | 14:48 | |
| mriedem | sdague: +1 until dansmith can take a look | 14:48 |
| sdague | ok, cool | 14:48 |
| dansmith | mriedem: sdague: I got a call starting in a few and then I'll look | 14:48 |
| sdague | dansmith: sounds good | 14:48 |
| sdague | thank you | 14:48 |
| sdague | mriedem: I have an orthoginal (but related question) | 14:49 |
| sdague | for nova to be a good player in global request id, and accept them, we need https://review.openstack.org/#/c/467998/ | 14:49 |
| *** thorst_ has joined #openstack-nova | 14:49 | |
| alex_xu | mriedem: yea, i think so. and interesting bug, add it into review list | 14:49 |
| sdague | which is going to cause an extra http header to emit | 14:49 |
| *** karthiks has joined #openstack-nova | 14:49 | |
| sdague | microversion? | 14:49 |
| mriedem | alex_xu: i'm fixing the test in that one | 14:49 |
| sdague | alex_xu might also want to weigh in there | 14:50 |
| *** gyee has joined #openstack-nova | 14:50 | |
| mriedem | sdague: i tend to say yes, otherwise how do you know if the cloud has the header or not? | 14:50 |
| mriedem | however, | 14:50 |
| *** Dave has joined #openstack-nova | 14:50 | |
| mriedem | do we hook in something that removes the header for requests < new microversion? | 14:51 |
| sdague | nope | 14:51 |
| mriedem | otherwise the new microversion is only signaling | 14:51 |
| sdague | correct | 14:51 |
| sdague | also, it depends on code version on the server and if they follow our upper constraints | 14:51 |
| *** thorst has quit IRC | 14:51 | |
| sdague | it's definitely a little messy, and mostly annoying we didn't do this a long time ago | 14:52 |
| mriedem | sdague: we can't require a new minimum version of oslo.middleware? | 14:52 |
| sdague | maybe, I can look at the force on the requirements side | 14:52 |
| sdague | we could land it with the requirements force | 14:52 |
| *** mdrabe has quit IRC | 14:54 | |
| mriedem | you want oslo.middleware>=3.27.0 it looks like | 14:55 |
| mriedem | for https://github.com/openstack/oslo.middleware/commit/0e3dbba0d9d373fbfa9e28897cd33377e2491d32 | 14:55 |
| *** lucasxu has joined #openstack-nova | 14:56 | |
| sdague | yep | 14:56 |
| alex_xu | emm...any special reason for not having a microversion? | 14:56 |
| *** ctrath has joined #openstack-nova | 14:56 | |
| sdague | https://review.openstack.org/#/c/468057/ | 14:56 |
| sdague | mriedem: ok, I'll build on top of that in my spider of crazy depends on | 14:57 |
| *** ijw has joined #openstack-nova | 15:00 | |
| *** dave-mccowan has joined #openstack-nova | 15:00 | |
| *** claudiub has joined #openstack-nova | 15:01 | |
| *** markvoelker has joined #openstack-nova | 15:01 | |
| *** mdrabe has joined #openstack-nova | 15:01 | |
| *** ctrath has quit IRC | 15:01 | |
| edleafe | jaypipes: free? | 15:01 |
| jaypipes | edleafe: sorry, still on call. | 15:01 |
| jaypipes | edleafe: will ping you asap. | 15:01 |
| edleafe | jaypipes: kewl | 15:02 |
| *** ctrath has joined #openstack-nova | 15:02 | |
| *** ltomasbo is now known as ltomasbo|away | 15:04 | |
| *** pabelanger has left #openstack-nova | 15:04 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: Migrate to oslo request_id middleware - mv 2.46 https://review.openstack.org/467998 | 15:05 |
| *** marst_ has joined #openstack-nova | 15:05 | |
| *** ijw has quit IRC | 15:05 | |
| *** fragatina has joined #openstack-nova | 15:06 | |
| mriedem | sdague: you'll throw a shoe, but we should have a bp and spec for that microversion | 15:06 |
| mriedem | i imagine it will be small | 15:06 |
| * cdent throws shoe for sdague | 15:07 | |
| *** gianpietro has joined #openstack-nova | 15:07 | |
| * mriedem catches shoe, tries it on | 15:07 | |
| * mriedem hobbles in circle | 15:07 | |
| sdague | mriedem: specless blueprint? | 15:07 |
| cdent | I should warn you, I do no the other one, so if you like that one, you're gonna hobble for a long time | 15:07 |
| *** jamiec_ has quit IRC | 15:07 | |
| mriedem | sdague: all api changes need a spec | 15:07 |
| mriedem | thems the rules | 15:07 |
| *** jamiec has joined #openstack-nova | 15:08 | |
| mriedem | smcginnis: so what kind of fun dual maintenance path is it going to be for os-brick in both python and go? | 15:09 |
| sdague | mriedem: ok, let me throw together something quick | 15:09 |
| *** derekh has quit IRC | 15:10 | |
| mriedem | jaypipes: isn't this vestigial now? https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L800 | 15:10 |
| mriedem | added in https://github.com/openstack/nova/commit/8941b45bc58a833261bb09fc7eb8fb5c765e154a | 15:11 |
| mriedem | wondering b/c of https://github.com/openstack/nova/commit/ea4754ba21ea08eb367d62bc46b5eba3777c119c | 15:12 |
| jaypipes | mriedem: yeah. the comment can be removed. | 15:12 |
| *** felipemonteiro has quit IRC | 15:14 | |
| *** penick has joined #openstack-nova | 15:18 | |
| *** roeyc has joined #openstack-nova | 15:19 | |
| smcginnis | mriedem: Eh, it's inevitable. | 15:20 |
| *** yamamoto has joined #openstack-nova | 15:20 | |
| *** yamamoto has quit IRC | 15:20 | |
| *** yingjun has joined #openstack-nova | 15:22 | |
| mriedem | hmm, i've got questions about compute nodes and services records | 15:24 |
| mriedem | b/c something isn't adding up | 15:24 |
| *** sree has joined #openstack-nova | 15:25 | |
| mriedem | deleting a nova-compute service record doesn't delete the compute_nodes record, | 15:25 |
| mriedem | but if you restart the nova-compute process, it's going to create a new services table record for the same host/binary/topic | 15:26 |
| mriedem | the compute_nodes table entry has a service_id record in it | 15:26 |
| mriedem | the resource tracker isn't going to create a new compute_nodes record because one already exists for the given host and nodename | 15:26 |
| mriedem | but, do we ever update the compute_nodes.service_id record anywhere? | 15:26 |
| *** sree has quit IRC | 15:27 | |
| openstackgerrit | Sean Dague proposed openstack/nova-specs master: oslo.middleware request_id spec https://review.openstack.org/468066 | 15:27 |
| sdague | mriedem: ok, spec ^^^ | 15:27 |
| *** sree has joined #openstack-nova | 15:28 | |
| mriedem | ok | 15:28 |
| *** yingjun has quit IRC | 15:29 | |
| *** Oku_OS is now known as Oku_OS-away | 15:29 | |
| mriedem | jaypipes: do we actually not tie the compute nodes record to the nova-compute service anywhere? | 15:30 |
| mriedem | ah looks like it's not, by design | 15:31 |
| mriedem | since it's all deprecated | 15:31 |
| *** sree has quit IRC | 15:32 | |
| *** ctrath has quit IRC | 15:35 | |
| mriedem | oh snap | 15:35 |
| *** ctrath has joined #openstack-nova | 15:35 | |
| mriedem | alex_xu: we do soft delete the compute node record when the service is deleted, | 15:36 |
| mriedem | if they are tied together, | 15:36 |
| mriedem | which happens for very old compute nodes records | 15:36 |
| mriedem | https://github.com/openstack/nova/blob/65402e1aeb770d077620f2935a0cb305474aa7a1/nova/db/sqlalchemy/api.py#L461 | 15:36 |
| jaypipes | mriedem: we removed the direct linkage between the two on purpose | 15:37 |
| mriedem | https://github.com/openstack/nova/blob/65402e1aeb770d077620f2935a0cb305474aa7a1/nova/db/sqlalchemy/api.py#L461 | 15:37 |
| mriedem | yeah | 15:37 |
| mriedem | the db api tests are still doing the very old style linkage | 15:37 |
| mriedem | so testing using those for a modern setup is really confusing | 15:37 |
| *** pcaruana has quit IRC | 15:38 | |
| *** awaugama has quit IRC | 15:38 | |
| *** yingjun has joined #openstack-nova | 15:38 | |
| *** pcaruana has joined #openstack-nova | 15:39 | |
| *** ltomasbo|away is now known as ltomasbo | 15:39 | |
| *** thorst_ has quit IRC | 15:39 | |
| *** jmlowe has quit IRC | 15:42 | |
| *** Yangyapeng has quit IRC | 15:43 | |
| *** yingjun has quit IRC | 15:43 | |
| jaypipes | edleafe: k, sorry about that. ready now. | 15:46 |
| jaypipes | hangout? | 15:46 |
| *** gianpietro has quit IRC | 15:46 | |
| *** lucasagomes is now known as lucas-afk | 15:47 | |
| *** danpawlik is now known as _danpawlik | 15:48 | |
| *** hshiina has joined #openstack-nova | 15:48 | |
| *** tbachman has joined #openstack-nova | 15:48 | |
| *** crushil has quit IRC | 15:50 | |
| mriedem | sdague: -1 is specifically for expanding on this https://review.openstack.org/#/c/468066/1/specs/pike/approved/oslo-middleware-request-id.rst@48 | 15:51 |
| mriedem | otherwise +2 | 15:51 |
| sdague | mriedem: so, it's not sufficient that the patch already has that in it? | 15:52 |
| mriedem | the spec is a doc | 15:52 |
| sdague | sure | 15:52 |
| mriedem | published as a doc, people reading those later shouldn't have to dig through lp to find the patch | 15:52 |
| *** efoley_ has quit IRC | 15:52 | |
| edleafe | jaypipes: cdent: so you suggested passing the instance UUIDs in the reqspec | 15:52 |
| edleafe | That was my original approach, but dansmith preferred the RPC parameter approach, so I changed it | 15:53 |
| edleafe | jaypipes: see https://review.openstack.org/#/c/463623/ | 15:53 |
| jaypipes | edleafe: right. | 15:53 |
| jaypipes | edleafe: lemme walk through in my head whether the recent "continuing the automatic reschedule behaviour" thing affects my decision on that... | 15:54 |
| cdent | edleafe: I don't really have a strong opinion. my natural inclination is parameters, but that's not been seasoned by years of nova-based RPC | 15:54 |
| *** shaner has quit IRC | 15:55 | |
| edleafe | jaypipes: cdent: my preference was reqspec (which is why I did it that way first), since it already had the pretty much useless 'instance_uuid' attribute | 15:55 |
| openstackgerrit | Sean Dague proposed openstack/nova-specs master: oslo.middleware request_id spec https://review.openstack.org/468066 | 15:55 |
| jaypipes | dansmith: can you, in one sentence, explain your preference to change the RPC interface vs. add a field to the reqspec object? | 15:55 |
| sdague | mriedem: done | 15:55 |
| jaypipes | dansmith: I want to make sure I understand you completely. | 15:55 |
| dansmith | jaypipes: we don't need to store the uuids in the database, right? | 15:56 |
| *** phuongnh has joined #openstack-nova | 15:56 | |
| *** shaner has joined #openstack-nova | 15:56 | |
| dansmith | we've had this conversation a couple times | 15:56 |
| edleafe | dansmith: but there is already the 'instance_uuid', which we don't store either | 15:56 |
| dansmith | edleafe: um, what? | 15:57 |
| dansmith | already instance_uuid in the reqspec? | 15:57 |
| edleafe | yup | 15:58 |
| edleafe | dansmith: https://review.openstack.org/#/c/463623/5/nova/objects/request_spec.py@77 | 15:58 |
| dansmith | what do you mean we don't store it | 15:58 |
| dansmith | ? | 15:58 |
| dansmith | ...right, I know it's in there | 15:58 |
| edleafe | well, we don't *need* to store it | 15:58 |
| edleafe | it's useless if num_instances > 1 | 15:59 |
| dansmith | okay not sure what that has to do with not adding another thing we don't need to store, which could be a hundred uuids :) | 15:59 |
| *** penick has quit IRC | 15:59 | |
| mriedem | fuel on the fire makes it better right? | 15:59 |
| *** mdnadeem has quit IRC | 15:59 | |
| mriedem | at what point do we add kitchen_sink to request spec? | 15:59 |
| *** penick has joined #openstack-nova | 15:59 | |
| *** thorst has joined #openstack-nova | 16:00 | |
| edleafe | I understand the reqspec to be the vehicle for passing the requested info to the scheduler | 16:00 |
| edleafe | the scheduler needs this info | 16:00 |
| jaypipes | dansmith: so the reason I was advocating passing in all the instance uuids in the reqspec was because I wanted to get rid of the retry stuff and do all of that in the scheduler (and thus we'd need all those UUIDs). But now that that is off the table, I'm not sure it makes sense any more. | 16:01 |
| dansmith | aye | 16:01 |
| edleafe | jaypipes: it definitely does | 16:01 |
| *** thorst has quit IRC | 16:02 | |
| edleafe | if num_instances > 1, how will the scheduler claim the resources if it doesn't know the consumer_id? | 16:02 |
| dansmith | the uuid list is only something that makes sense for a single call to the scheduler, AFAIK, so it shouldn't be stuffed into the database, just something we pass like anything else, IMHO | 16:02 |
| *** lucasxu has quit IRC | 16:03 | |
| jaypipes | edleafe: a fair point. | 16:03 |
| *** lucasxu has joined #openstack-nova | 16:03 | |
| jaypipes | edleafe: if we moved the handling of num_instances > 1 to the conductor, though... | 16:03 |
| *** thorst has joined #openstack-nova | 16:04 | |
| jaypipes | edleafe: we'd need more robust concurrent update handling in the conductor, then. | 16:04 |
| edleafe | jaypipes: sp the conductor would make num_instances calls to the scheduler, instead of 1? | 16:04 |
| jaypipes | edleafe: I'm spitballing. | 16:04 |
| *** penick has quit IRC | 16:04 | |
| edleafe | We'd also have to run the host queries num_instances times instead of once | 16:04 |
| jaypipes | edleafe: right. | 16:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Exclude deleted service records when calling hypervisor statistics https://review.openstack.org/467220 | 16:05 |
| *** Yangyapeng has joined #openstack-nova | 16:05 | |
| edleafe | you're spitballing; I'm poking holes | 16:05 |
| edleafe | :) | 16:05 |
| mriedem | Kevin_Zheng: ^ i updated the commit message and re-wrote the test a bit | 16:05 |
| jaypipes | edleafe: I'm thinking out loud. | 16:05 |
| mriedem | with a bunch of comments to explain it | 16:05 |
| edleafe | me too | 16:05 |
| edleafe | I've thought about these a lot already, though :) | 16:05 |
| sdague | mriedem: I'm confused about your comment on https://review.openstack.org/#/c/467995/ about implications for versioned objects | 16:06 |
| sdague | maybe that's where we need dansmith poking | 16:06 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Pass the number of hosts to return explicitly https://review.openstack.org/465767 | 16:07 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Remove selecting host based on host_subset_size https://review.openstack.org/465174 | 16:07 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Return multiple hosts from select_destinations https://review.openstack.org/465768 | 16:07 |
| *** Apoorva has joined #openstack-nova | 16:07 | |
| edleafe | jaypipes: ^^ The series is ready for review. I can switch the passing of UUIDs if needed | 16:08 |
| jaypipes | edleafe, dansmith: for retries, do we ever retry the entire list of instances (in a num_instances > 1 case) or do we just retry the launch of one of them? | 16:08 |
| edleafe | jaypipes: if we retry the whole list, that would be very dumb | 16:08 |
| edleafe | since some could have already been successful | 16:08 |
| jaypipes | edleafe: well, it all depends on how "atomic" we view the num_instances > 1 case, right? | 16:09 |
| *** roeyc has quit IRC | 16:09 | |
| dansmith | jaypipes: we've lost scope of the others by the time we're retrying any of them | 16:10 |
| dansmith | jaypipes: and they might've scattered across cells | 16:10 |
| dansmith | jaypipes: as you've pointed out, the api implies atomicity, and we guarantee almost none | 16:10 |
| mriedem | sdague: yes, that's my call for dan | 16:10 |
| *** roeyc has joined #openstack-nova | 16:10 | |
| *** nic has joined #openstack-nova | 16:10 | |
| edleafe | the min_count and max_count were supposed to provide a go/no-go atomicity | 16:11 |
| *** roeyc has quit IRC | 16:11 | |
| *** Apoorva_ has joined #openstack-nova | 16:11 | |
| sdague | mriedem: ok, cool. Jenkins is currently a happy camper, so there is at least that | 16:12 |
| jaypipes | dansmith, edleafe: ok, random idea here... what if we triggered claims in the scheduler only if num_instances == 1? at least for right now... and let the num_instances > 1 case be handled in the same wonky claim-on-compute way it is now? | 16:13 |
| dansmith | oh please god no | 16:13 |
| cdent | what would that gain? | 16:14 |
| dansmith | jaypipes: nobody wants to claim on compute right? | 16:14 |
| jaypipes | it would mean we would solve the 80% case now. and come up with a solution for the 20% case later. | 16:14 |
| edleafe | jaypipes: yeah, that sounds terrible | 16:14 |
| *** Apoorva has quit IRC | 16:15 | |
| edleafe | the only thing missing to solve 100% of the claims is the instance UUIDs. | 16:15 |
| edleafe | As long as we pass those in some form to the scheduler, we are good | 16:15 |
| * cdent agrees with edleafe | 16:15 | |
| edleafe | the only question is what is the best way to pass them | 16:15 |
| jaypipes | edleafe: right, but what I'm saying is we solve that later and for the first patch(es), we bite off what we can chew for right now. | 16:15 |
| jaypipes | instead of trying to solve everything at once. | 16:16 |
| edleafe | IMO the patches are bite-sized | 16:16 |
| jaypipes | edleafe: the patches might be. the debate isn't. :) | 16:16 |
| mriedem | pass them over rpc | 16:16 |
| mriedem | don't store them in the db | 16:16 |
| mriedem | i thought that was clear? | 16:16 |
| dansmith | mriedem: me too | 16:17 |
| jaypipes | mriedem: nobody has suggested storing them in the DB. | 16:17 |
| *** Apoorva_ has quit IRC | 16:17 | |
| edleafe | mriedem: well, if that's the decision, then everything is ready for review | 16:17 |
| dansmith | jaypipes: perhaps we can nail this down quicker in a hangout? | 16:17 |
| dansmith | jaypipes: edleafe did :) | 16:17 |
| jaypipes | he did? | 16:17 |
| mriedem | if you put them in the reqspec they go in the db unless you monkey the object to not persist | 16:17 |
| mriedem | but that seems wrong | 16:17 |
| edleafe | I suggested putting them in the reqspec | 16:17 |
| *** Apoorva has joined #openstack-nova | 16:17 | |
| jaypipes | ok. | 16:17 |
| edleafe | so I guess DB storage is inevitable :) | 16:17 |
| mriedem | i mean sure you can throw any attribute on an object and it won't persist | 16:17 |
| mriedem | if it's not in the model | 16:18 |
| jaypipes | right | 16:18 |
| edleafe | jaypipes: to be fair, you suggested the same thing :) | 16:18 |
| jaypipes | that's what I thought we were going to do.. | 16:18 |
| edleafe | me too | 16:18 |
| jaypipes | edleafe: not store in the DB. I suggested just tacking instance_uuids as a field on the object, since that would avoid an RPC API change. | 16:18 |
| mriedem | it seems very not intuitive | 16:18 |
| dansmith | jaypipes: it doesn't avoid an rpc change | 16:18 |
| mriedem | 2 years from now someone is going to ask, wtf, why are these on this object but not in the db? | 16:18 |
| dansmith | yeah | 16:18 |
| dansmith | it's silly to do that | 16:19 |
| *** savvas has quit IRC | 16:19 | |
| cdent | there's nothing wrong with an rpc api change, and it is semantically clean. let's just do that. | 16:19 |
| jaypipes | fine. call me silly. I don't care. | 16:19 |
| edleafe | I've done it both ways, so I don't care either :) | 16:19 |
| cdent | "that" == add a param | 16:19 |
| dansmith | jaypipes: you know you're just generally silly anyway :) | 16:19 |
| jaypipes | indeed. | 16:19 |
| jaypipes | ok, follow on question... | 16:19 |
| *** awaugama has joined #openstack-nova | 16:20 | |
| jaypipes | let's say we pass an instance_uuids param to the scheduler. cool, fine by me. But what about the whole "alternate destinations" thing that is designed to solve the no-cell-upcall issue? | 16:20 |
| jaypipes | are we still going for that? | 16:20 |
| dansmith | ... | 16:21 |
| dansmith | have there been other suggestions on how to resolve that other than doing the alternates thing? | 16:21 |
| *** yamamoto has joined #openstack-nova | 16:21 | |
| *** Apoorva has quit IRC | 16:22 | |
| edleafe | jaypipes: have you seen https://review.openstack.org/#/c/465767/ ? | 16:22 |
| cdent | I gotta run, if there's a summary of this, can someone let me know somehow later this evening? | 16:22 |
| edleafe | cdent: will do | 16:22 |
| cdent | thanks | 16:22 |
| *** cdent has quit IRC | 16:22 | |
| jaypipes | dansmith: not that I'm aware of. was just trying to catch up my thoughts on this series. | 16:23 |
| dansmith | okay | 16:23 |
| edleafe | Adding alternates changes the result of select_destinations() from a list of hosts to a list of a list of hosts | 16:23 |
| jaypipes | edleafe: and you/we are OK with that, yes?> | 16:24 |
| *** Apoorva has joined #openstack-nova | 16:24 | |
| *** pchavva has quit IRC | 16:24 | |
| edleafe | It wasn't my preference, no | 16:24 |
| edleafe | But it was a big request from operators, so... | 16:24 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/468089 | 16:25 |
| mriedem | alex_xu: oomichi: we're kind of at an impass with some of the new cinder attachment reviews - john and i are the only reviewers on these but i'm also working on the patches too, so we need a 3rd core to help move some stuff along, can you help review the 3 bottom changes in this series which already have a +2 from john? https://review.openstack.org/#/c/456896/ | 16:25 |
| mriedem | *impasse | 16:25 |
| *** crushil has joined #openstack-nova | 16:25 | |
| jaypipes | edleafe: is there a reason you undid Sylvain's changes from patch 10 on https://review.openstack.org/#/c/460177/10..11/nova/compute/resource_tracker.py? | 16:29 |
| jaypipes | edleafe: I'd asked him to change the dict comprehension into a simple tracked_keys = set(self.tracked_instances.keys()) | 16:29 |
| jaypipes | edleafe: and you undid that. | 16:30 |
| jaypipes | edleafe: and changed instance_uuid -> allocation_uuid. | 16:30 |
| edleafe | jaypipes: probably a rebase screw-up | 16:30 |
| *** pcaruana has quit IRC | 16:30 | |
| jaypipes | edleafe: just a case of rebase screw up? | 16:30 |
| jaypipes | edleafe: jinx :) | 16:30 |
| edleafe | I rebased my series on master, and his is in the series | 16:30 |
| jaypipes | edleafe: could you please push quick update on that? | 16:30 |
| *** pcaruana has joined #openstack-nova | 16:30 | |
| jaypipes | edleafe: and I will quick approve. | 16:30 |
| edleafe | I'll fix that in a bit | 16:30 |
| jaypipes | since dansmith is already +2 on that | 16:31 |
| edleafe | gimme a few | 16:31 |
| *** yamamoto has quit IRC | 16:32 | |
| dansmith | mriedem: what ovo impact do you think that context change has? | 16:33 |
| mriedem | dansmith: don't know, but i've thought in the past when we talk about changes to context it can have implications for rpc | 16:34 |
| mriedem | so i was waiting for you | 16:34 |
| dansmith | mriedem: you might also want to get a read from tonyb or jamie on it.. there was some upgrade issue when we bumped oslo.context the last time | 16:34 |
| dansmith | mriedem: yeah, rpc, but not ovo specifically that I know of | 16:34 |
| mriedem | waiting for tony isn't going to be an option | 16:34 |
| dansmith | tonyb was the one handling the upgrade issue last time | 16:34 |
| openstackgerrit | Sean Dague proposed openstack/nova-specs master: oslo.middleware request_id spec https://review.openstack.org/468066 | 16:35 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Migrate to oslo request_id middleware - mv 2.46 https://review.openstack.org/467998 | 16:36 |
| sdague | mriedem ok all the cross links and blueprint bits filed | 16:36 |
| sdague | dansmith: how do you imagine it would have an impact? | 16:37 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Have scheduler claim resources https://review.openstack.org/463993 | 16:38 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Pass the number of hosts to return explicitly https://review.openstack.org/465767 | 16:38 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Remove selecting host based on host_subset_size https://review.openstack.org/465174 | 16:38 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Make the method to put allocations public https://review.openstack.org/464086 | 16:38 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Pass a list of instance UUIDs to scheduler https://review.openstack.org/465171 | 16:38 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Return multiple hosts from select_destinations https://review.openstack.org/465768 | 16:38 |
| dansmith | sdague: i don't recall the details, which is why I said, but I think that during one of the bumps, we could end up with say a new compute sending a context to an old compute that it couldn't parse or something.. like maybe it wasn't defensive enough in the original version maybe? | 16:38 |
| edleafe | jaypipes: ^^ should be fixed | 16:38 |
| sdague | dansmith: maybe, the from_dict is pretty defensive | 16:39 |
| dansmith | sdague: if the super'd method is defensive with gets like ours is there, then I guess we're okay for this change, I just don't know | 16:39 |
| sdague | it's all .get() calls | 16:39 |
| *** udesale has joined #openstack-nova | 16:39 | |
| mriedem | hmm, | 16:39 |
| dansmith | sdague: yeah, either it wasn't before or there was some really subtle detail | 16:39 |
| mriedem | we do have tests for this | 16:39 |
| sdague | https://github.com/openstack/oslo.context/blob/cce83ad5e12baf2edc0e12c2944c587224e71148/oslo_context/context.py#L358-L382 | 16:39 |
| mriedem | in the grenade live migration job we have the back and forth live migration thing | 16:39 |
| sdague | mriedem: right | 16:39 |
| mriedem | let me see if that's happening | 16:39 |
| mriedem | it was dependent on a devstack backport to ocata | 16:39 |
| sdague | dansmith: it may not have been a long time ago | 16:40 |
| sdague | jamielennox definitely did a bunch of work on this | 16:40 |
| dansmith | sdague: yeah, that came out of tonyb highlighting the issue I think | 16:40 |
| dansmith | I recall, | 16:40 |
| jaypipes | edleafe: you didn't push the right patch. | 16:40 |
| dansmith | I just don't know the deets | 16:40 |
| mriedem | it was blown up the last midcycle at intel | 16:40 |
| mriedem | which was newton | 16:40 |
| dansmith | right | 16:40 |
| jaypipes | edleafe: https://review.openstack.org/#/c/460177/ was the patch in question. | 16:40 |
| sdague | the worst thing I think that could happen is if we API (new) create context -> cpu (old) | 16:40 |
| *** rcernin has quit IRC | 16:40 | |
| jaypipes | edleafe: you pushed all the ones above that. | 16:40 |
| sdague | then pass it back to something new | 16:40 |
| dansmith | yeah | 16:41 |
| sdague | which means some bits would be lost and fall back to defaults | 16:41 |
| sdague | like global_request_id will end up zeroed out | 16:41 |
| mriedem | sdague: ah you merged it https://review.openstack.org/#/c/466033/ | 16:41 |
| mriedem | so yeah it should be running | 16:41 |
| dansmith | anyway, if we can't want, then I guess we just do it assuming the tests pass, I'm just saying.. there were dragons here last time and I don't know what they all were | 16:41 |
| dansmith | *wait | 16:41 |
| edleafe | Hmmm... I thought when I changed it back it would push that | 16:41 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Have scheduler claim resources https://review.openstack.org/463993 | 16:43 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Pass the number of hosts to return explicitly https://review.openstack.org/465767 | 16:43 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Remove selecting host based on host_subset_size https://review.openstack.org/465174 | 16:43 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Make the method to put allocations public https://review.openstack.org/464086 | 16:43 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Don't delete allocation if instance being scheduled https://review.openstack.org/460177 | 16:43 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Pass a list of instance UUIDs to scheduler https://review.openstack.org/465171 | 16:43 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Return multiple hosts from select_destinations https://review.openstack.org/465768 | 16:43 |
| sdague | mriedem: yeh, that passed, was there something you were looking for specifically? | 16:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189 | 16:43 |
| edleafe | jaypipes: ^^ ok, I made a small whitespace change to make sure it got pushed | 16:43 |
| *** jheroux has joined #openstack-nova | 16:44 | |
| sdague | mriedem / dansmith if there is an old bug here I could figure out if that could happen again | 16:44 |
| mriedem | looking | 16:45 |
| jaypipes | edleafe: approved. | 16:46 |
| jaypipes | dansmith: https://review.openstack.org/#/c/464086 is ready for your blessing. | 16:46 |
| sdague | mriedem: I think this was the relevant fix https://review.openstack.org/#/c/341895/ | 16:46 |
| *** ltomasbo is now known as ltomasbo|away | 16:48 | |
| *** prateek has joined #openstack-nova | 16:49 | |
| sdague | https://bugs.launchpad.net/nova/+bug/1603979 is this the bug? | 16:50 |
| openstack | Launchpad bug 1603979 in OpenStack Compute (nova) "gate: context tests failed because missing parameter "is_admin_project" (oslo.context 2.6.0)" [Critical,Fix released] - Assigned to Tang Chen (tangchen) | 16:50 |
| sdague | so tonyb's fix is just unit test fixes | 16:51 |
| sdague | it's nothing actually functional | 16:51 |
| sdague | https://review.openstack.org/#/c/342604/ | 16:51 |
| dansmith | the thing I'm talking about was identified before we bumped the version in u-c | 16:51 |
| dansmith | so probably not that bug | 16:51 |
| mriedem | http://logs.openstack.org/95/467995/3/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/46deb21/logs/new/tempest_conf.txt.gz | 16:52 |
| mriedem | live_migrate_back_and_forth = True | 16:52 |
| dansmith | anyway, if you guys are confident and see tests, then just do it | 16:52 |
| sdague | dansmith: ok, I'm having a hard time finding any reference to what that was | 16:52 |
| dansmith | sdague: my major involvement was a hallway conversation and shared laptop screen with tonyb | 16:52 |
| *** dtp has joined #openstack-nova | 16:52 | |
| sdague | this would have been midcycle? http://lists.openstack.org/pipermail/openstack-dev/2016-July/099467.html | 16:53 |
| mriedem | it might have also been some capped requirement crap | 16:54 |
| mriedem | in stable | 16:54 |
| sdague | because the dates for the unit test break are all around this | 16:54 |
| mriedem | yes newton midcycle | 16:54 |
| sdague | right, so that was entirely about unit tests | 16:54 |
| mriedem | confirmed that we're doing the back and forth live migration in that grenade job http://logs.openstack.org/95/467995/3/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/46deb21/logs/tempest.txt.gz#_2017-05-25_15_16_25_895 | 16:54 |
| mriedem | so we should be happy | 16:54 |
| sdague | actually these same unit tests blocking the the current oslo.context uc bump | 16:54 |
| edleafe | jaypipes: running out for a bit. I'll answer any other questions when I get back. | 16:55 |
| sdague | mriedem: cool | 16:55 |
| mriedem | +2 | 16:55 |
| *** vks1 has joined #openstack-nova | 16:56 | |
| *** mvk has quit IRC | 16:57 | |
| sdague | mriedem: great | 16:57 |
| *** felipemonteiro has joined #openstack-nova | 16:58 | |
| sdague | ok, need another +2 to unblock uc | 16:58 |
| *** Swami has joined #openstack-nova | 16:58 | |
| *** baoli_ has quit IRC | 16:59 | |
| mriedem | i need a plate of food to unblock my hunger | 17:00 |
| *** ralonsoh has quit IRC | 17:01 | |
| *** ijw has joined #openstack-nova | 17:01 | |
| *** cuhler has joined #openstack-nova | 17:01 | |
| mriedem | +2 on the spec also | 17:01 |
| *** baoli has joined #openstack-nova | 17:04 | |
| *** dikonoor has quit IRC | 17:04 | |
| *** yamamoto has joined #openstack-nova | 17:06 | |
| cfriesen | for upgrading from newton (without any cells) to ocata, what nova-manage commands are needed prior to the migration? I think it's "nova-manage cell_v2 simple_cell_setup", "nova-manage db sync", "nova-manage api-db sync", and "nova-manage db online_data_migrations". Am I missing anything? (And when would you use "nova-manage cell_v2 map_cell0" instead?) | 17:06 |
| cfriesen | I'm looking at the upgrade notes and some of the cellsv2 stuff is a bit ambiguous | 17:07 |
| *** dhiaeddine has quit IRC | 17:09 | |
| cuhler | Hi mriedem, os-brick version has been bumped (incl global-requirements here: https://review.openstack.org/#/c/467757/). Can you please remove the workflow -1 and review Veritas nova volume driver at https://review.openstack.org/#/c/443951/? Thx. | 17:09 |
| *** yamamoto has quit IRC | 17:10 | |
| *** gianpietro has joined #openstack-nova | 17:11 | |
| mriedem | cfriesen: https://docs.openstack.org/developer/nova/cells.html#upgrade-minimal | 17:11 |
| mriedem | https://docs.openstack.org/developer/nova/man/nova-manage.html#nova-cells-v2 | 17:11 |
| mriedem | https://docs.openstack.org/developer/nova/cells.html#faqs | 17:11 |
| mriedem | cuhler: sure | 17:12 |
| cfriesen | mriedem: thanks | 17:12 |
| sdague | mriedem: great | 17:12 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Libvirt volume driver for Veritas HyperScale https://review.openstack.org/443951 | 17:15 |
| mriedem | cuhler: +2 | 17:15 |
| mriedem | now you must fish for another core | 17:15 |
| *** jmlowe has joined #openstack-nova | 17:16 | |
| *** jmlowe has quit IRC | 17:16 | |
| *** rmart04 has quit IRC | 17:16 | |
| cfriesen | mriedem: re the point about newton expecting a different name for the cell0 database...does that cause problems when later upgrading to ocata? | 17:16 |
| mriedem | cfriesen: have you created a cell0 db yet? | 17:17 |
| mriedem | and if so, what did you name it? | 17:17 |
| *** jmlowe has joined #openstack-nova | 17:17 | |
| cfriesen | nope...planning on holding off till the ocata upgrade if I can | 17:17 |
| cfriesen | I'm just trying to figure out what I should do after upgrading to newton | 17:17 |
| mriedem | ok, if you're running the nova-manage commands from ocata code you'll be fine | 17:17 |
| cfriesen | cool, will hold off then | 17:18 |
| mriedem | need to get https://review.openstack.org/#/c/420461/ into newton, along with it's dependencies | 17:18 |
| mriedem | sdague: ^ could you poke through those? | 17:18 |
| mriedem | there is a dependent grenade and devstack backport in there | 17:18 |
| *** sambetts is now known as sambetts|afk | 17:18 | |
| *** udesale has quit IRC | 17:20 | |
| *** lucasxu has quit IRC | 17:20 | |
| sdague | looking | 17:20 |
| *** penick has joined #openstack-nova | 17:21 | |
| *** phuongnh has quit IRC | 17:21 | |
| cuhler | mriedem: thanks | 17:23 |
| sdague | mriedem: lgtm | 17:24 |
| *** gianpietro has quit IRC | 17:24 | |
| *** gianpietro has joined #openstack-nova | 17:25 | |
| *** jpena is now known as jpena|off | 17:26 | |
| mriedem | thanks | 17:28 |
| mriedem | dansmith: this is going to need your loving care https://review.openstack.org/#/c/420461/ - that's the newton backport to fix the default cell0 db name connection string we talked about yesterday | 17:28 |
| *** gianpietro has quit IRC | 17:29 | |
| mriedem | melwitt: do you want me to hold off on https://review.openstack.org/#/c/446239/ for now? | 17:30 |
| *** arunman has quit IRC | 17:30 | |
| *** acormier has quit IRC | 17:31 | |
| *** cuhler has quit IRC | 17:31 | |
| mriedem | melwitt: we could probably do facade thing for count() in the object code in a separate cleanup if we want to move forward | 17:31 |
| *** acormier has joined #openstack-nova | 17:31 | |
| melwitt | mriedem: I was gonna wait until you were done with the tests to update anything to get them all at once. but, if I remove count() from nova/quota then I need to add a test for the facade thing in nova/objects/quotas. so it's up to you, want me to update it first and then you look again? | 17:32 |
| mriedem | let me skim the tests first | 17:32 |
| *** gszasz has quit IRC | 17:32 | |
| melwitt | k. I'm just running through the facade change locally to make sure things don't break | 17:33 |
| *** acormier has quit IRC | 17:35 | |
| mriedem | melwitt: why is test_reservation_expire removed? | 17:39 |
| melwitt | mriedem: gah, I meant to put that back. accidental removal | 17:40 |
| mriedem | ok, i'll leave a reminder | 17:40 |
| melwitt | thanks | 17:40 |
| *** acormier has joined #openstack-nova | 17:42 | |
| *** savvas has joined #openstack-nova | 17:42 | |
| *** acormier has quit IRC | 17:43 | |
| *** acormier has joined #openstack-nova | 17:44 | |
| *** crushil has quit IRC | 17:45 | |
| *** fragatina has quit IRC | 17:47 | |
| savvas | mriedem: I noticed your fingerprints on https://blueprints.launchpad.net/nova/+spec/flavor-root-disk-none . Is there a best practice suggestion to secure this? For example I am bypassing the quota limitation on my local disks by removing the DiskFilter filter from nova (which is far from ideal..) but I have no way to enforce instances being created with use of cinder volumes instead of local block devices. | 17:47 |
| *** acormier has quit IRC | 17:48 | |
| *** acormier has joined #openstack-nova | 17:49 | |
| savvas | I found this in nova.conf: max_local_block_devices but again this would not be ideal as reading the comments suggests that it won't pick alternative storage instead. | 17:51 |
| mriedem | savvas: max_local_block_devices isn't what you think it is | 17:53 |
| mriedem | savvas: otherwise i don't think there is a way to force users to boot from volume | 17:53 |
| mriedem | let me find something for you to read | 17:53 |
| mriedem | savvas: http://lists.openstack.org/pipermail/openstack-dev/2017-May/117012.html | 17:54 |
| *** rmart04 has joined #openstack-nova | 17:54 | |
| *** lpetrut has quit IRC | 17:54 | |
| *** claudiub has quit IRC | 17:56 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: re-Allow adding computes with no ComputeNodes to aggregates https://review.openstack.org/460616 | 17:56 |
| *** eharney has quit IRC | 17:57 | |
| mriedem | melwitt: ok comments posted | 17:59 |
| *** ctrath has quit IRC | 18:00 | |
| melwitt | mriedem: thanks, looking | 18:00 |
| *** vks1 has quit IRC | 18:00 | |
| *** ctrath has joined #openstack-nova | 18:00 | |
| *** crushil has joined #openstack-nova | 18:03 | |
| savvas | mriedem: interesting. So at this time there is no way to bypass/secure this limitation in the software? | 18:03 |
| mriedem | savvas: i'm not aware of one outside of patches people have put into their systems | 18:05 |
| mriedem | savvas: the outcome of that session was to write a spec for the short-term solution to auto-create block device mappings based on the flavor (which the operator controls) if bdms aren't requested by the user | 18:06 |
| mriedem | not using extra specs | 18:06 |
| savvas | ye the short term solution sounds acceptable though | 18:06 |
| mriedem | says the guy that wants *anything* | 18:06 |
| mriedem | :) | 18:07 |
| mriedem | that's all queens release at this point | 18:07 |
| jaypipes | mriedem, dansmith: if you have time. https://review.openstack.org/#/c/461574/ | 18:07 |
| savvas | hehe, ye ;> | 18:07 |
| *** baoli has quit IRC | 18:08 | |
| mriedem | jaypipes: didn't you need an os-traits release and g-r bump for something in this series? | 18:08 |
| savvas | basically it menas if we end up selling a project based solution, at this point having api or heat available to the tenant could lead to resource exhaustion | 18:08 |
| *** prometheanfire has joined #openstack-nova | 18:09 | |
| mriedem | savvas: there is the reserved_host_disk_mb config option | 18:09 |
| prometheanfire | mriedem: hi | 18:09 |
| prometheanfire | http://logs.openstack.org/76/466476/9/check/gate-cross-nova-python27-ubuntu-xenial/89a6a52/testr_results.html.gz | 18:09 |
| *** gjayavelu has joined #openstack-nova | 18:09 | |
| mriedem | prometheanfire: was this the same thing as last week? | 18:10 |
| prometheanfire | think the new dogpile.cache makes nova sad | 18:10 |
| prometheanfire | probably | 18:10 |
| mriedem | or 2 weeks ago | 18:10 |
| mriedem | did you open a bug for that? | 18:10 |
| jaypipes | mriedem: no, that was this series: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/resource-provider-traits | 18:10 |
| mriedem | jaypipes: ah ok | 18:10 |
| mriedem | prometheanfire: please report a bug | 18:10 |
| mriedem | i'm doing 4 things at once atm | 18:10 |
| prometheanfire | ya | 18:11 |
| prometheanfire | though I don't see a commit that'd do that | 18:11 |
| jaypipes | mriedem: also, global requiremnts is already at os-traits >= 0.3, so we're cool. | 18:11 |
| jaypipes | mriedem: just need to rebase that fix conflicts | 18:11 |
| dansmith | jaypipes: so you still feel it's important/useful to have that giant sql query in comments inline there? | 18:11 |
| *** david-lyle has joined #openstack-nova | 18:12 | |
| dansmith | I commented on that, but don't think I saw a reply | 18:12 |
| jaypipes | dansmith: you asked me to remove it from the commit message, which I did. | 18:12 |
| jaypipes | dansmith: some (cdent, edleafe I think) have said the SQL in the code comment is useful. | 18:12 |
| mriedem | dansmith: the example or the whole thing? | 18:13 |
| melwitt | are they dreaming in SQL now too? | 18:13 |
| mriedem | we do need a book describing what the massive sql build up is doing | 18:13 |
| mriedem | the example starting at L829 could get outdated over time | 18:13 |
| dansmith | jaypipes: you're right, I never committed that comment | 18:13 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: integrate trait cache with TraitList and Trait https://review.openstack.org/462770 | 18:14 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: add cache which keeps DB and os_traits in sync https://review.openstack.org/462769 | 18:14 |
| dansmith | anyway, 200 lines of sql comment before any code is really distracting for me and I'd rather that be in devref if it's really useful to keep, | 18:14 |
| dansmith | but I'm clearly in the minority | 18:14 |
| jaypipes | dansmith: the comment is explaining how the SQLAlchemy joins are being built up. | 18:14 |
| *** baoli has joined #openstack-nova | 18:14 | |
| jaypipes | but again, whatevs, I'm happy to move it. just let me know. | 18:15 |
| dansmith | I know | 18:15 |
| *** baoli has quit IRC | 18:15 | |
| dansmith | anyway, I don't think I can really review the sqla and find anything wrong with it, but I'm okay with just going based on the tests if that doesn't scare anyone else | 18:15 |
| mriedem | we should have med_ look at it to spot the bug in the query like during the talk at the summit :) | 18:15 |
| med_ | heh | 18:15 |
| jaypipes | heh, reminds me I need to fix those slides... | 18:16 |
| med_ | only if you are giving away t-shirts for my son. | 18:16 |
| *** eharney has joined #openstack-nova | 18:16 | |
| melwitt | I had assumed those were copied from the code, so it made me wonder if the code had the bugs too | 18:17 |
| *** david-lyle has quit IRC | 18:19 | |
| mriedem | dansmith: i'm in the same boat, i'm going to have to review mostly based on tests | 18:19 |
| *** hshiina has quit IRC | 18:19 | |
| dansmith | mriedem: okay | 18:19 |
| *** lyan has quit IRC | 18:19 | |
| *** slaweq has joined #openstack-nova | 18:19 | |
| mriedem | also, with shit like this, we're going to have to jump in at some point and work out the bugs afterward | 18:20 |
| mriedem | while jay is still working with us :) | 18:20 |
| jaypipes | thanks for all your votes of confidence guys. | 18:20 |
| mriedem | ha | 18:20 |
| melwitt | mriedem: thanks for catching the gaps in the tests. I've changed things so many times I've lost track of some of them | 18:21 |
| mriedem | jaypipes: you realize i'm not commenting on your technical ability but the fact this is a complicated new system being built, and therefore has to have bugs creep out over time | 18:21 |
| *** dgonzalez has quit IRC | 18:22 | |
| *** dgonzalez has joined #openstack-nova | 18:22 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Nix redundant dict in set_inventory_for_provider https://review.openstack.org/468123 | 18:24 |
| *** lucasxu has joined #openstack-nova | 18:25 | |
| *** slaweq has quit IRC | 18:26 | |
| *** baoli has joined #openstack-nova | 18:27 | |
| *** fragatina has joined #openstack-nova | 18:28 | |
| *** jmlowe has quit IRC | 18:28 | |
| *** fragatina has quit IRC | 18:30 | |
| *** fragatina has joined #openstack-nova | 18:30 | |
| *** baoli has quit IRC | 18:30 | |
| *** kaisers_ has joined #openstack-nova | 18:31 | |
| *** baoli has joined #openstack-nova | 18:32 | |
| openstackgerrit | Sean Dague proposed openstack/python-novaclient master: Have python-novaclient support global_request_id https://review.openstack.org/468126 | 18:32 |
| sdague | mriedem: someone broke stable/newton and turned on a trusty upgrade job - https://review.openstack.org/#/c/420750/ | 18:34 |
| sdague | last time that happened it was related to a bad exclude rule by cinder | 18:34 |
| mriedem | i'm having a hard time parsing that | 18:35 |
| mriedem | failing in the gate? | 18:35 |
| mriedem | and exclude rule on a job in project-config? | 18:35 |
| smcginnis | sdague: I had made changes there, but that was a few weeks back now. | 18:35 |
| *** jmlowe has joined #openstack-nova | 18:35 | |
| smcginnis | sdague: AFAIK, all grenade jobs should have been blocked on stable/newton. | 18:35 |
| *** fragatina has quit IRC | 18:36 | |
| sdague | smcginnis: I have no idea the last time someone tried to get grenade changes on stable/newton through, it's not very often | 18:36 |
| sdague | mriedem: yes, it's running a job it definitely should not be | 18:36 |
| *** kaisers_ has quit IRC | 18:36 | |
| smcginnis | sdague: Now that mitaka is EOL, it shouldn't ever be done. | 18:36 |
| sdague | smcginnis: agreed | 18:37 |
| sdague | mriedem: anyway, the backport fixes for the cell naming change jobs aren't going to work until the jobs are cleaned up on the gate | 18:37 |
| *** danpawlik has joined #openstack-nova | 18:38 | |
| mriedem | sigh, ok | 18:38 |
| mriedem | let me coffee up first | 18:38 |
| sdague | mriedem: https://www.youtube.com/watch?v=yysnM407rjE - power up | 18:39 |
| *** gomarivera has quit IRC | 18:39 | |
| savvas | mriedem: your suggested host space reservation doesn't do much for me. If I enable that, instance creation fails if I select boot from image in new volume. If I set my root disk size to 0 to bypass that, the whole point is gone as heat for example deploys a simple instance with block device again and ignores the reserved host space | 18:39 |
| savvas | any other thoughts? | 18:39 |
| *** gjayavelu has quit IRC | 18:41 | |
| *** rwmjones has left #openstack-nova | 18:41 | |
| *** rmart04 has quit IRC | 18:42 | |
| *** Sukhdev has joined #openstack-nova | 18:42 | |
| mriedem | savvas: no immediate thoughts, you could try the #openstack-operators channel to see if others are dealing with this, | 18:44 |
| mriedem | or ask med_, cburgess or mgagne, our resident nova channel friendly ops, about their opinions | 18:44 |
| cburgess | Do what now? | 18:44 |
| mriedem | help someone | 18:44 |
| mriedem | c'mon chet | 18:44 |
| cburgess | Oh OK.. I gues I can try... | 18:45 |
| savvas | :--) | 18:45 |
| cburgess | Whats the question/issue/suggestion? | 18:45 |
| savvas | Right | 18:45 |
| savvas | well I am trying to avoid instances being created on local storage | 18:45 |
| cburgess | Oh that one... | 18:46 |
| savvas | our nodes have a 20G root partition and that should be utilized for system processes only. So apart from the fact that nova doesn't seem to recognize cinder storage as usable space | 18:46 |
| savvas | it also simply refuses not to try and make local block devices | 18:46 |
| cburgess | Define refuse? If you launch an instance with boot from volume you shouldn't see a local device. | 18:46 |
| *** jmlowe has quit IRC | 18:48 | |
| mriedem | cburgess: the problem is the same as usual, in that you can't force the user to do boot from volume | 18:49 |
| mriedem | unless you automagic something in the api code to do that, as some have done | 18:49 |
| cburgess | Correct | 18:50 |
| cburgess | Hence the point of that whole sessions in bonston. I still need to write that spec... | 18:50 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/468089 | 18:50 |
| cburgess | You simply can't block an local instance launch in nova unless you write a custom patch. | 18:50 |
| savvas | cburgess: for creating a new instance it works just fine via horizon but for example if I launch a simple stack it doesn't force me to select a boot volume or anything | 18:51 |
| savvas | and it creates a local block device | 18:51 |
| *** jmlowe has joined #openstack-nova | 18:51 | |
| cburgess | savvas Yup.. its a limitation in openstack. Its something thats been of ongoing discussion for the past few cycles and we are working on a spec for.. queens (mriedem??) to try and address this limitation. | 18:52 |
| mriedem | queens yes | 18:52 |
| savvas | ye I read about that | 18:52 |
| savvas | was hoping people may have found a workaround to deal with this problem though | 18:53 |
| savvas | but seems like there aren't any (yet) | 18:53 |
| mriedem | not outside of patching the api | 18:53 |
| mriedem | which i'd advise against | 18:54 |
| cburgess | Even I advise against patching the API now, even though I've been known to do it. | 18:54 |
| cburgess | But yes... its a known issue and hopefully we can have a good discussion about it at the upcoming PTG and agree on a spec for the queens cycle to address this issue. | 18:54 |
| *** READ10 has quit IRC | 18:55 | |
| mriedem | chet is in nova-patchers-anonymous | 18:55 |
| cburgess | mriedem Meh.. I got tired of dansmith accusing me of doing awful things with his code. :P | 18:56 |
| mriedem | i know i don't get tired of that | 18:56 |
| dansmith | mriedem kinda likes the pain you know | 18:56 |
| mriedem | i meant you hurting chet | 18:56 |
| mriedem | not me | 18:56 |
| dansmith | heh | 18:56 |
| *** jobewan has joined #openstack-nova | 18:58 | |
| *** claudiub has joined #openstack-nova | 18:59 | |
| *** tbachman has quit IRC | 19:01 | |
| cfriesen | would there be value in having "nova-manage db online_data_migrations" return a value indicating whether or not it needs to be called again? (when specifying --max-count) | 19:02 |
| *** gomarivera has joined #openstack-nova | 19:02 | |
| cfriesen | seems like currently a calling script needs to parse the output | 19:02 |
| melwitt | I thought it already returns 1 if there's more to do and 0 when there's no more to do. or are you saying it returns 0 when you use --max-count and there is still more to do? | 19:03 |
| *** kaisers_ has joined #openstack-nova | 19:04 | |
| cfriesen | melwitt: it currently has "return ran and 1 or 0" and I think an exception in one of the migration routines will give a 0 | 19:05 |
| cfriesen | I want success/partial-success/error return codes | 19:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle conflict from neutron when addFloatingIP fails https://review.openstack.org/468136 | 19:05 |
| mriedem | cfriesen: sounds like a bug | 19:05 |
| *** penick has quit IRC | 19:06 | |
| *** gomarivera has quit IRC | 19:06 | |
| cfriesen | mriedem: what should it return in the error case? 127 like we have if you specify a nonpositive integer for max-count? or something else | 19:06 |
| mriedem | idk, sometimes we return 2 for things | 19:06 |
| mriedem | it's not really defined | 19:07 |
| *** gomarivera has joined #openstack-nova | 19:07 | |
| sdague | cfriesen: so the problem with that is it means you have to turn off set -e in scripts | 19:07 |
| mriedem | sdague: that's what we do in grenade for the nova-status upgrade check | 19:07 |
| sdague | mriedem: yeh, which is a little suck | 19:08 |
| *** yamamoto has joined #openstack-nova | 19:08 | |
| mriedem | well maybe we don't https://github.com/openstack-dev/grenade/blob/master/projects/60_nova/upgrade.sh#L97 | 19:08 |
| mriedem | i must be thinking of something in d-g | 19:08 |
| *** kaisers_ has quit IRC | 19:08 | |
| mriedem | ah we use || | 19:08 |
| sdague | yeh | 19:08 |
| sdague | which is just mask the world | 19:09 |
| *** pcaruana has quit IRC | 19:09 | |
| cfriesen | sdague: you mean distinguishing between success-and-done vs success-and-need-to-call-again? | 19:09 |
| sdague | yeh, but more importantly best practice for shell scripts is set -e, and things are only supposed to be non zero on failure | 19:10 |
| cfriesen | sdague: so you're saying the caller must always parse the output to determine if it's actually done? | 19:11 |
| *** gomarivera has quit IRC | 19:11 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle conflict from neutron when addFloatingIP fails https://review.openstack.org/468136 | 19:11 |
| cfriesen | because that seems kind of lame | 19:11 |
| *** mvk has joined #openstack-nova | 19:11 | |
| sdague | cfriesen: you're just calling this in a loop from another program right? | 19:11 |
| cfriesen | sdague: no guarantee it'll be in a loop...what if someone wanted to process X migrations each maintenance window | 19:12 |
| sdague | ok | 19:12 |
| *** yamamoto has quit IRC | 19:13 | |
| mriedem | sdague: i think that grenade-dsvm-neutron-multinode-ubuntu-trusty failure in stable/newton wasn't what you thought it was | 19:13 |
| mriedem | stable/mitaka isn't deleted yet | 19:13 |
| mriedem | plus this job passed yesterday | 19:13 |
| mriedem | it's an ssh issue with ansible | 19:13 |
| mriedem | http://logs.openstack.org/50/420750/2/gate/gate-grenade-dsvm-neutron-multinode-ubuntu-trusty/7fd8a27/logs/devstack-gate-setup-host.txt | 19:13 |
| sdague | mriedem: how is stable/mitaka still a thing? | 19:14 |
| mriedem | sdague: rax laid off tonyb | 19:14 |
| mriedem | if i had twitter, i'd tweet it, that if you want LTS in openstack, don't hire tonyb | 19:14 |
| sdague | heh | 19:14 |
| mriedem | huh, this is weird http://logs.openstack.org/74/467674/2/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/414bb96/logs/screen-n-api.txt.gz?level=TRACE#_May_25_02_46_02_139728 | 19:19 |
| mriedem | if you run tempest with cinder.cross_az_attach=False, | 19:20 |
| mriedem | 2 bfv tests fail, | 19:20 |
| mriedem | but they are failing on some weird instance.host lazy load issue in the api | 19:20 |
| mriedem | which i wouldn't expect | 19:20 |
| mriedem | host wouldn't be set at this point | 19:20 |
| mriedem | but i'd think it's None | 19:20 |
| mriedem | hmm, or is it the BuildRequest object? | 19:22 |
| mriedem | dansmith: ^ methinks that's what is blowing up | 19:23 |
| mriedem | we create an Instance object w/o a host field set, and serialize that into the BuildRequest | 19:23 |
| *** baoli has quit IRC | 19:23 | |
| dansmith | well, no host at that point | 19:23 |
| mriedem | right, | 19:23 |
| mriedem | but this az check is looking for the host on the instance, which isn't set | 19:24 |
| mriedem | and kablamo | 19:24 |
| dansmith | they're doing a .get o it which doesn't really make sense | 19:24 |
| mriedem | that code is super old, | 19:24 |
| mriedem | probably when it was a dict | 19:24 |
| dansmith | from dict era? | 19:24 |
| dansmith | okay | 19:24 |
| dansmith | so maybe just needs updating for using 'in' ? | 19:24 |
| mriedem | savvas: i'm surprised you didn't hit this when you set cross_az_attach=False ^ | 19:24 |
| mriedem | dansmith: yeah | 19:24 |
| *** baoli has joined #openstack-nova | 19:25 | |
| mriedem | dansmith: and/or set instance.host = None for the temp instance that goes into the BuildRequest | 19:25 |
| *** xyang1 has joined #openstack-nova | 19:25 | |
| *** tbachman has joined #openstack-nova | 19:26 | |
| dansmith | well, we wouldn't want to write it into the database that way unintentionally.. I dunno, .get() was clearly looking for "if set or not" | 19:26 |
| mriedem | i just worry about other places that could hit this, | 19:26 |
| dansmith | and today that's done with in | 19:26 |
| mriedem | but i'd think those would have been found by now | 19:26 |
| dansmith | I'd just hate to have a situation where we've scheduled but something pulled the instance out of buildrequest and does a save() which overwrites the real host | 19:27 |
| mriedem | sure i can be a cautious cat for now | 19:28 |
| dansmith | call me nervous nellie | 19:28 |
| savvas | mriedem: well most of the testing I've done was by creating an instance via horizon. Horizon asks you to create a volume when spawning an instance | 19:28 |
| savvas | so I didn't realize that was happening until I started messing with the system, trying to break it basically | 19:29 |
| melwitt | mriedem: tonyb got hired, so stable/mitaka's days are probably numbered | 19:29 |
| mriedem | melwitt: i heard | 19:29 |
| mriedem | i'll let stable/mitaka know | 19:29 |
| melwitt | cool, thanks | 19:29 |
| dansmith | well, just go announcing his news for him why don'tcha? | 19:29 |
| melwitt | he announced it on twitter, get with the program! | 19:29 |
| dansmith | oh, yeah I see, okay :) | 19:30 |
| *** tbachman has quit IRC | 19:30 | |
| dansmith | guns lowered | 19:30 |
| melwitt | lol | 19:30 |
| melwitt | can't believe you're not up-to-speed with the twittersphere, SIGH | 19:30 |
| mriedem | well someone better make an LTS reference in there | 19:30 |
| mriedem | for me | 19:31 |
| mriedem | by proxy | 19:31 |
| melwitt | @mriedem_proxy | 19:31 |
| dansmith | I don't follow him so I didn't notice | 19:31 |
| *** cdent has joined #openstack-nova | 19:32 | |
| *** tbachman has joined #openstack-nova | 19:36 | |
| *** avolkov has quit IRC | 19:41 | |
| cfriesen | mriedem: in commit ab05b902 you introduced an online migration to fix an issue....shouldn't that have been ported back to stable/mitaka to fix the issue before the Newton code would ever see it? | 19:46 |
| *** gomarivera has joined #openstack-nova | 19:47 | |
| cfriesen | or are we really saying that online data migrations should be run ASAP after an upgrade is done rather than at the operator's leisure? | 19:47 |
| cdent | edleafe: is a list of list of hosts being returned the only option? Would a single dimension longer list work? | 19:50 |
| cdent | that is: can the grouping happen on the conductor side? | 19:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Avoid lazy-load error when getting instance AZ https://review.openstack.org/468147 | 19:51 |
| mriedem | dansmith: easy stat pad ^ | 19:51 |
| *** annegentle has joined #openstack-nova | 19:53 | |
| *** kaisers_ has joined #openstack-nova | 19:53 | |
| mriedem | cfriesen: that one was really odd | 19:54 |
| cfriesen | mriedem: never mind, I see we introduced the change in Newton so no way to backport the migration | 19:54 |
| mriedem | correct | 19:54 |
| cfriesen | mriedem: I'm assuming it'd be okay if we deleted those entries separately prior to the upgrade | 19:55 |
| *** priteau has quit IRC | 19:55 | |
| mriedem | the old busted build requests? | 19:55 |
| cfriesen | the failed BuildRequest I mean | 19:55 |
| mriedem | i think so | 19:55 |
| *** jamielennox is now known as jamielennox|away | 19:56 | |
| *** Sukhdev has quit IRC | 19:57 | |
| cfriesen | mriedem: what would have happened to successful old build requests? | 19:57 |
| *** kaisers_ has quit IRC | 19:57 | |
| *** amotoki is now known as amotoki_away | 19:58 | |
| *** amotoki_away is now known as amotoki | 19:59 | |
| *** amotoki is now known as amotoki_away | 19:59 | |
| mriedem | happened where? when? | 20:00 |
| mriedem | successful build requests are cleaned up when the instance is created | 20:01 |
| mriedem | failed ones weren't getting cleaned up at some point, which i think was part of the issue | 20:01 |
| cfriesen | ah, okay. so at steady-state there would only be failed ones left in the DB | 20:01 |
| mriedem | so you'd have these old busted build requests with the old data format, | 20:01 |
| mriedem | and they'd revive somehow and blow up | 20:01 |
| *** acormier_ has joined #openstack-nova | 20:01 | |
| *** acormier has quit IRC | 20:01 | |
| mriedem | i believe they'd be pulled back when listing instances | 20:01 |
| *** Apoorva has quit IRC | 20:01 | |
| mriedem | because they weren't deleted | 20:01 |
| *** cdent has quit IRC | 20:02 | |
| mriedem | and the from_db_object or whatever assumed the new data model format | 20:02 |
| mriedem | as i said, it was a weird one | 20:02 |
| *** Apoorva has joined #openstack-nova | 20:02 | |
| mriedem | dansmith: +2 on https://review.openstack.org/#/c/460616/ - time to get someone to pay you back | 20:02 |
| *** Apoorva has quit IRC | 20:06 | |
| edleafe | cd | 20:08 |
| edleafe | ugh | 20:08 |
| *** felipemonteiro has quit IRC | 20:10 | |
| *** yamahata has joined #openstack-nova | 20:10 | |
| mriedem | dansmith: on this cells rpcapi thing https://review.openstack.org/#/c/461532/6/nova/cells/rpcapi.py - i'm not sure what type of exception should be raised here | 20:11 |
| mriedem | just anything? | 20:11 |
| dansmith | mriedem: yeah, we've done it a couple other places | 20:11 |
| mriedem | ServiceTooOld ? | 20:11 |
| dansmith | mriedem: since that would be an upgrade concern, and it's cellsv1, I'd just raise anything to call attention | 20:11 |
| dansmith | sure, sounds fine tome | 20:11 |
| *** david-lyle has joined #openstack-nova | 20:12 | |
| *** eharney has quit IRC | 20:12 | |
| *** smatzek has quit IRC | 20:12 | |
| *** jamesdenton has quit IRC | 20:13 | |
| gyee | mriedem, jaypipes, can you guys please take a look? https://review.hpcloud.net/135895 | 20:13 |
| gyee | I am trying to get a resolution on this one | 20:13 |
| mriedem | gyee: i don't have access to your internal gerrit :) | 20:13 |
| mriedem | i can request access of course | 20:14 |
| gyee | oh shit, wrong link | 20:14 |
| gyee | my bad | 20:14 |
| gyee | https://review.openstack.org/#/c/466143/ | 20:15 |
| gyee | my brain is fried trying to context switch upstream/downstream | 20:16 |
| openstackgerrit | Steve Noyes proposed openstack/nova master: WIP: update live migration to use v3 cinder api https://review.openstack.org/463987 | 20:17 |
| *** david-lyle has quit IRC | 20:17 | |
| *** Apoorva has joined #openstack-nova | 20:17 | |
| *** jmlowe has quit IRC | 20:18 | |
| openstackgerrit | Steve Noyes proposed openstack/nova master: WIP: update live migration to use v3 cinder api https://review.openstack.org/463987 | 20:19 |
| *** lucasxu has quit IRC | 20:21 | |
| *** lucasxu has joined #openstack-nova | 20:22 | |
| mriedem | gyee: looking | 20:22 |
| *** moshele has joined #openstack-nova | 20:23 | |
| *** gjayavelu has joined #openstack-nova | 20:27 | |
| *** karimb has quit IRC | 20:32 | |
| *** lyan has joined #openstack-nova | 20:33 | |
| *** edmondsw has quit IRC | 20:37 | |
| *** Yangyapeng has quit IRC | 20:38 | |
| *** danpawlik has quit IRC | 20:38 | |
| *** crushil has quit IRC | 20:39 | |
| *** markvoelker has quit IRC | 20:42 | |
| *** slaweq has joined #openstack-nova | 20:44 | |
| *** edmondsw has joined #openstack-nova | 20:44 | |
| mriedem | gyee: comments inline | 20:45 |
| *** yamahata has quit IRC | 20:45 | |
| *** READ10 has joined #openstack-nova | 20:45 | |
| gyee | mriedem: thanks! | 20:46 |
| mriedem | nova meeting in #openstack-meeting in 10 minutes | 20:50 |
| *** dillaman has quit IRC | 20:50 | |
| *** yamahata has joined #openstack-nova | 20:50 | |
| *** gomarivera has quit IRC | 20:52 | |
| *** gomarivera has joined #openstack-nova | 20:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle uuid in HostAPI.compute_node_get https://review.openstack.org/461532 | 20:53 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Use uuid for id in Services API https://review.openstack.org/464280 | 20:53 |
| *** gomarivera has quit IRC | 20:53 | |
| *** gomarivera has joined #openstack-nova | 20:53 | |
| *** takashin has joined #openstack-nova | 20:55 | |
| *** dillaman has joined #openstack-nova | 20:55 | |
| *** gjayavelu has quit IRC | 20:56 | |
| *** markvoelker has joined #openstack-nova | 20:56 | |
| *** gianpietro has joined #openstack-nova | 20:57 | |
| *** fragatina has joined #openstack-nova | 21:00 | |
| *** markvoelker has quit IRC | 21:00 | |
| *** smatzek has joined #openstack-nova | 21:00 | |
| *** rfolco has quit IRC | 21:01 | |
| openstackgerrit | Matt Rabe proposed openstack/nova master: Query deleted instance records during _destroy_evacuated_instances https://review.openstack.org/467774 | 21:02 |
| *** ctrath has quit IRC | 21:04 | |
| openstackgerrit | Matt Rabe proposed openstack/nova master: Query deleted instance records during _destroy_evacuated_instances https://review.openstack.org/467774 | 21:04 |
| *** prateek has quit IRC | 21:05 | |
| *** itlinux has joined #openstack-nova | 21:05 | |
| *** jwcroppe has quit IRC | 21:07 | |
| *** jwcroppe has joined #openstack-nova | 21:08 | |
| *** smatzek has quit IRC | 21:11 | |
| *** tidwellr has quit IRC | 21:11 | |
| *** tidwellr has joined #openstack-nova | 21:12 | |
| *** moshele has quit IRC | 21:12 | |
| *** jwcroppe has quit IRC | 21:12 | |
| *** ayogi has joined #openstack-nova | 21:14 | |
| *** gianpietro has quit IRC | 21:14 | |
| *** takashin has quit IRC | 21:15 | |
| *** dimtruck is now known as zz_dimtruck | 21:16 | |
| *** takashin has joined #openstack-nova | 21:16 | |
| *** tidwellr has quit IRC | 21:16 | |
| *** yamahata has quit IRC | 21:18 | |
| *** jwcroppe has joined #openstack-nova | 21:20 | |
| oomichi | mriedem: thanks, lgtm on https://review.openstack.org/#/c/456896 | 21:20 |
| openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189 | 21:21 |
| *** thorst has quit IRC | 21:22 | |
| *** lyan has quit IRC | 21:22 | |
| *** lyan has joined #openstack-nova | 21:24 | |
| *** sdague has quit IRC | 21:24 | |
| *** jheroux has quit IRC | 21:25 | |
| *** jwcroppe has quit IRC | 21:25 | |
| *** awaugama has quit IRC | 21:26 | |
| mriedem | oomichi: thanks. there are 2 more on top of that one with +2s if you can take a look at those also. | 21:27 |
| *** marst_ has quit IRC | 21:30 | |
| *** crushil has joined #openstack-nova | 21:30 | |
| *** dave-mccowan has quit IRC | 21:33 | |
| *** crushil has quit IRC | 21:37 | |
| *** imacdonn has quit IRC | 21:39 | |
| *** lucasxu has quit IRC | 21:39 | |
| *** imacdonn has joined #openstack-nova | 21:40 | |
| *** itlinux has quit IRC | 21:42 | |
| mriedem | melwitt: jaypipes: dansmith: we talked about spot instances in one of the forum sessions, do you remember which one by chance? | 21:42 |
| *** jwcroppe has joined #openstack-nova | 21:43 | |
| dansmith | reservations or something I think | 21:43 |
| mriedem | ah yes | 21:43 |
| mriedem | https://etherpad.openstack.org/p/BOS-forum-advanced-instance-scheduling | 21:43 |
| *** burt has quit IRC | 21:46 | |
| *** fragatina has quit IRC | 21:48 | |
| *** zz_dimtruck is now known as dimtruck | 21:54 | |
| *** gianpietro has joined #openstack-nova | 21:54 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Nix redundant dict in set_inventory_for_provider https://review.openstack.org/468123 | 21:56 |
| *** gianpietro has quit IRC | 21:59 | |
| *** jwcroppe has quit IRC | 21:59 | |
| *** jwcroppe has joined #openstack-nova | 21:59 | |
| *** tbachman has quit IRC | 22:02 | |
| *** mdrabe has quit IRC | 22:03 | |
| *** wolsen has joined #openstack-nova | 22:03 | |
| *** Apoorva_ has joined #openstack-nova | 22:04 | |
| *** slaweq has quit IRC | 22:05 | |
| *** markvoelker has joined #openstack-nova | 22:05 | |
| *** annegentle has quit IRC | 22:06 | |
| *** gjayavelu has joined #openstack-nova | 22:06 | |
| *** slaweq has joined #openstack-nova | 22:07 | |
| *** Apoorva has quit IRC | 22:08 | |
| *** slaweq has quit IRC | 22:08 | |
| mriedem | is it just me, | 22:08 |
| mriedem | or are the examples in here missing some things https://docs.openstack.org/ocata/config-reference/compute/schedulers.html#aggregateimagepropertiesisolation | 22:08 |
| *** slaweq has joined #openstack-nova | 22:08 | |
| *** slaweq has quit IRC | 22:13 | |
| *** markvoelker has quit IRC | 22:15 | |
| *** markvoelker has joined #openstack-nova | 22:16 | |
| *** kaisers_ has joined #openstack-nova | 22:19 | |
| *** thorst has joined #openstack-nova | 22:20 | |
| *** gianpietro has joined #openstack-nova | 22:21 | |
| *** itlinux has joined #openstack-nova | 22:22 | |
| *** esberglu has quit IRC | 22:22 | |
| *** thorst has quit IRC | 22:23 | |
| *** esberglu has joined #openstack-nova | 22:23 | |
| *** kaisers_ has quit IRC | 22:24 | |
| *** tbachman has joined #openstack-nova | 22:26 | |
| *** esberglu has quit IRC | 22:28 | |
| *** baoli has quit IRC | 22:29 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/468089 | 22:29 |
| *** gouthamr has quit IRC | 22:29 | |
| *** gianpietro has quit IRC | 22:30 | |
| *** edmondsw has quit IRC | 22:34 | |
| *** edmondsw has joined #openstack-nova | 22:34 | |
| *** Apoorva_ has quit IRC | 22:35 | |
| *** Apoorva has joined #openstack-nova | 22:35 | |
| *** tbachman has quit IRC | 22:36 | |
| *** jamielennox|away is now known as jamielennox | 22:36 | |
| *** gianpietro has joined #openstack-nova | 22:39 | |
| *** edmondsw has quit IRC | 22:39 | |
| *** gianpietro has quit IRC | 22:40 | |
| *** tbachman has joined #openstack-nova | 22:41 | |
| *** gianpietro has joined #openstack-nova | 22:42 | |
| *** gomarivera has quit IRC | 22:42 | |
| *** gianpietro has quit IRC | 22:44 | |
| *** lyan has quit IRC | 22:44 | |
| *** claudiub has quit IRC | 22:49 | |
| *** jamespd has left #openstack-nova | 22:52 | |
| *** thorst has joined #openstack-nova | 22:53 | |
| *** jobewan has quit IRC | 22:55 | |
| *** takashin has quit IRC | 23:02 | |
| *** takashin has joined #openstack-nova | 23:03 | |
| jaypipes | mriedem: "Deleting instance files /var/lib/nova/instances/c929d839-a55d-4834-b044-cd70e9f6d79a_del" | 23:03 |
| jaypipes | mriedem: seeing the above in a customer log file. Does the _del at the end of the file mean the instance was soft-deleted? | 23:03 |
| mriedem | nope | 23:03 |
| jaypipes | ah, ok | 23:03 |
| mriedem | the libvirt driver renames the file i think | 23:04 |
| mriedem | so it can delete it | 23:04 |
| jaypipes | oh... before shutting down the instance? | 23:04 |
| mriedem | in here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7839 | 23:04 |
| jaypipes | mriedem: trying to figure out why this sequence of events is occurring in the order it is... http://paste.openstack.org/show/610689/ | 23:05 |
| jaypipes | mriedem: this is a Liberty installation. | 23:05 |
| *** gouthamr has joined #openstack-nova | 23:05 | |
| mriedem | that's called from cleanup() which is called from destroy() which is called during shutdown_instance in the compute manager | 23:05 |
| jaypipes | mriedem: from that paste, it almost looks like we're deleting the instance before successfully detaching the vNIC. | 23:06 |
| mriedem | "Neutron deleted interface" is via an event from neutron | 23:06 |
| mriedem | for network-vif-deleted | 23:06 |
| mriedem | concurrent | 23:06 |
| mriedem | we deallocate the network, which deletes the port, | 23:06 |
| mriedem | neutron sends an event saying the port was deleted, | 23:06 |
| mriedem | we log that and refresh the cache | 23:06 |
| mriedem | nw info cache that is | 23:06 |
| mriedem | assuming this was a port that nova created when the server was created | 23:06 |
| *** takashin_ has joined #openstack-nova | 23:07 | |
| mriedem | note req-cbfbe2ef-3403-42a9-aef2-9a0e9babe9ed is a separate request | 23:07 |
| mriedem | that's the instance request | 23:07 |
| mriedem | that InstanceNotFound is ignorable | 23:07 |
| mriedem | b/c we already refreshed the nw info cache when we deleted the port | 23:07 |
| mriedem | during deallocate_for_instance | 23:07 |
| *** itlinux has quit IRC | 23:07 | |
| mriedem | https://github.com/openstack/nova/blob/liberty-eol/nova/compute/manager.py#L6500 | 23:08 |
| mriedem | ^ is what you hit | 23:08 |
| jaypipes | mriedem: well, it's leaving qvo devices on the host... | 23:08 |
| *** takashin has quit IRC | 23:08 | |
| *** thorst has quit IRC | 23:08 | |
| *** takashin_ has left #openstack-nova | 23:09 | |
| openstackgerrit | guang-yee proposed openstack/nova master: make sure to rebuild claim on recreate https://review.openstack.org/466143 | 23:09 |
| mriedem | https://github.com/openstack/nova/blob/liberty-eol/nova/compute/manager.py#L2265 | 23:10 |
| mriedem | should unplug the vif | 23:10 |
| mriedem | we deallocate the port here https://github.com/openstack/nova/blob/liberty-eol/nova/compute/manager.py#L2280 | 23:10 |
| mriedem | vif unplug should clean things up on the host shoudln't it? | 23:10 |
| mriedem | driver.destroy calls cleanup which calls unplug_vifs | 23:11 |
| *** markvoelker has quit IRC | 23:11 | |
| mriedem | gyee: i was just updating that :) | 23:12 |
| jaypipes | mriedem: I've asked eugene to get more log information. he says there's lots of stale qvo devices from deleted instances on the customer's hosts... | 23:13 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: make sure to rebuild claim on recreate https://review.openstack.org/466143 | 23:15 |
| *** lyan has joined #openstack-nova | 23:16 | |
| *** jmlowe has joined #openstack-nova | 23:16 | |
| mriedem | jaypipes: i think dansmith fixed a bug in the libvirt driver where failed spawns weren't cleaning up properly | 23:18 |
| mriedem | leaving a bunch of garbage around | 23:18 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Add validation for cpu_realtime_mask https://review.openstack.org/468203 | 23:19 |
| *** dimtruck is now known as zz_dimtruck | 23:19 | |
| cfriesen | sahid: ^ | 23:20 |
| *** gjayavelu has quit IRC | 23:20 | |
| gyee | mriedem: all good :-) | 23:21 |
| mriedem | jaypipes: https://review.openstack.org/#/c/409706/ and https://review.openstack.org/#/c/428671/ | 23:22 |
| *** takashin has joined #openstack-nova | 23:26 | |
| jaypipes | mriedem: thx | 23:27 |
| gyee | jaypipes: nice comment :-) | 23:28 |
| jaypipes | gyee: you disagree? | 23:28 |
| gyee | I'll take the 5th | 23:28 |
| jaypipes | omfg the gate is killing me today. | 23:30 |
| *** jamesdenton has joined #openstack-nova | 23:32 | |
| *** edmondsw has joined #openstack-nova | 23:35 | |
| *** jamesdenton has quit IRC | 23:36 | |
| *** Apoorva_ has joined #openstack-nova | 23:36 | |
| *** vladikr has quit IRC | 23:38 | |
| cfriesen | is it possible to run a subset of tox functional tests? | 23:39 |
| mriedem | cfriesen: yes | 23:39 |
| *** vladikr has joined #openstack-nova | 23:39 | |
| mriedem | tox -e functional -- nova.tests.functional.test_servers | 23:40 |
| *** edmondsw has quit IRC | 23:40 | |
| mriedem | or whateever | 23:40 |
| mriedem | same as unit tests | 23:40 |
| *** Apoorva has quit IRC | 23:40 | |
| cfriesen | ah, okay. with unit tests it seems to accept wildcards anywhere in the test path and it doesn't need the "--" | 23:41 |
| *** Apoorva_ has quit IRC | 23:41 | |
| * cfriesen needs to not be lazy | 23:42 | |
| melwitt | I thought it worked the same. I don't use "--" but I also might not be wildcarding the way you are | 23:42 |
| cfriesen | hmm...it doesn't even like the format you suggested. but it works if I just run "tox -e functional" | 23:43 |
| cfriesen | ah well | 23:43 |
| melwitt | tox -efunctional test_blah | 23:44 |
| *** markvoelker has joined #openstack-nova | 23:44 | |
| *** markvoelker has quit IRC | 23:45 | |
| cfriesen | hmm....probably helps if I point to actual tests and not template directories. | 23:46 |
| *** lyan has quit IRC | 23:46 | |
| openstackgerrit | John Griffith proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285 | 23:49 |
| *** Swami has quit IRC | 23:49 | |
| *** yingjun has joined #openstack-nova | 23:49 | |
| *** acormier_ has quit IRC | 23:51 | |
| *** lyan has joined #openstack-nova | 23:52 | |
| *** zz_dimtruck is now known as dimtruck | 23:58 | |
| *** hongbin has quit IRC | 23:58 | |
| *** lyan has quit IRC | 23:59 | |
| *** READ10 has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
