openstackgerrit | John Griffith proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285 | 00:03 |
---|---|---|
*** pramodrj07 has quit IRC | 00:06 | |
*** yamamoto_ has joined #openstack-nova | 00:14 | |
openstackgerrit | Artom Lifshitz proposed openstack/python-novaclient master: Error out if nic auto or none are not alone https://review.openstack.org/470000 | 00:17 |
*** Yangyapeng has quit IRC | 00:17 | |
mriedem | melwitt: yeah i wanted cfriesen_ to review that first | 00:25 |
*** acormier has joined #openstack-nova | 00:25 | |
mriedem | i guess i can gander while i'm on a call tonight | 00:27 |
mriedem | a welcome distraction | 00:27 |
openstackgerrit | guang-yee proposed openstack/nova master: libvirt: Reconnect volumes and encryptors during a hard reboot https://review.openstack.org/400384 | 00:29 |
*** gyee has quit IRC | 00:30 | |
*** Shunli has joined #openstack-nova | 00:30 | |
melwitt | heh | 00:33 |
*** dikonoor has joined #openstack-nova | 00:37 | |
*** zsli_ has joined #openstack-nova | 00:37 | |
*** zsli__ has joined #openstack-nova | 00:39 | |
*** Shunli has quit IRC | 00:41 | |
openstackgerrit | Artom Lifshitz proposed openstack/python-novaclient master: Better handle key=value pair not being key=value https://review.openstack.org/469988 | 00:41 |
*** Shunli has joined #openstack-nova | 00:41 | |
*** zsli_ has quit IRC | 00:43 | |
*** zsli__ has quit IRC | 00:43 | |
*** jamielennox is now known as jamielennox|away | 00:44 | |
*** salv-orlando has joined #openstack-nova | 00:45 | |
*** tovin07_ has joined #openstack-nova | 00:48 | |
*** Hosam has quit IRC | 00:52 | |
*** tbachman has quit IRC | 00:53 | |
*** Hosam has joined #openstack-nova | 00:53 | |
*** salv-orlando has quit IRC | 00:54 | |
*** awaugama has quit IRC | 00:56 | |
*** Hosam has quit IRC | 00:57 | |
*** Hosam has joined #openstack-nova | 00:57 | |
mriedem | melwitt: reviewed https://review.openstack.org/#/c/379524/ but i clearly don't understand how this works, or weighers for that matter | 00:59 |
melwitt | mriedem: oh, sorry about that :( | 01:00 |
*** takashin has joined #openstack-nova | 01:01 | |
*** tbachman has joined #openstack-nova | 01:01 | |
melwitt | you're right that the weigher wants to favor hosts with fewer free PCI devices, packing like you said. it intends to leave room for possible future requests that actually need several devices at the same time | 01:02 |
*** shaner has quit IRC | 01:02 | |
melwitt | *several devices on the same host | 01:02 |
cfriesen_ | mriedem: you had suggested a functional test with non-empty extra-specs. I think that means adding extra-specs to one of the flavors used in the functional tests, no? | 01:05 |
*** nic has quit IRC | 01:05 | |
*** Hosam has quit IRC | 01:06 | |
*** Hosam has joined #openstack-nova | 01:07 | |
*** shaner has joined #openstack-nova | 01:07 | |
*** phuongnh has joined #openstack-nova | 01:07 | |
mriedem | cfriesen_: or just create a new flavor for the test | 01:11 |
openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/470037 | 01:11 |
cfriesen_ | mriedem: yeah, was just looking at that | 01:11 |
*** thorst has joined #openstack-nova | 01:11 | |
*** shaner has quit IRC | 01:11 | |
*** shaner has joined #openstack-nova | 01:12 | |
cfriesen_ | mriedem: is there a way to make a new flavor without needing to add new template files? | 01:17 |
mriedem | cfriesen_: yeah there is an api client used in the non-api sample functional tests | 01:17 |
mriedem | cfriesen_: something like this https://github.com/openstack/nova/blob/master/nova/tests/functional/integrated_helpers.py#L171 ? | 01:18 |
melwitt | you can checkout this badass functional test I wrote for an example https://review.openstack.org/#/c/355091/8/nova/tests/functional/test_boot_from_volume.py@54 | 01:18 |
mriedem | cfriesen_: the api sample tests use that mixin i think https://github.com/openstack/nova/blob/master/nova/tests/functional/api_samples_test_base.py#L69 | 01:19 |
mriedem | yeah, so you can re-use that method | 01:19 |
mriedem | to create a new flavor with what you need in it | 01:19 |
mriedem | even extra specs | 01:19 |
*** Yangyapeng has joined #openstack-nova | 01:20 | |
mriedem | although...the flavor ref is in the api sample request, | 01:20 |
mriedem | so things might get weird with subs | 01:20 |
*** rajathagasthya has quit IRC | 01:20 | |
cfriesen_ | I'll play with it, I guess | 01:20 |
*** Hosam has quit IRC | 01:21 | |
*** rajathagasthya has joined #openstack-nova | 01:21 | |
mriedem | or modify that helper method to allow passing in a flavorid you define, which is some hard-coded uuid in your tests | 01:21 |
mriedem | and put that flavorid in the request samples | 01:21 |
mriedem | something like that | 01:21 |
cfriesen_ | realistically it would probably make sense for one of the default flavors to have extra specs just to test other code paths | 01:22 |
mriedem | thing is you'd have to delete the flavor between test cases, or add a check to make sure you don't try to create it if it already exists | 01:22 |
mriedem | yeah maybe, there is a flavor fixture | 01:22 |
mriedem | https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L619 | 01:23 |
mriedem | throw a new default flavor in that fixture maybe | 01:23 |
cfriesen_ | but I'm sure changing the fixtures would have wide ranging effects | 01:23 |
mriedem | note that could throw off other tests though | 01:23 |
mriedem | maybe | 01:23 |
mriedem | maybe do that in a separate change to see how big the change is | 01:23 |
mriedem | and then if it's not that bad, you do that separately, and then rebase your change on top of it to use that new flavor | 01:24 |
cfriesen_ | yeah, that'd be cleanest if it's not crazy | 01:24 |
*** Hosam has joined #openstack-nova | 01:25 | |
*** Apoorva_ has joined #openstack-nova | 01:27 | |
*** Yangyapeng has quit IRC | 01:30 | |
openstackgerrit | Chris Friesen proposed openstack/nova master: add extra_specs to one flavor in test fixtures https://review.openstack.org/470076 | 01:30 |
*** Apoorva has quit IRC | 01:30 | |
*** vladik has joined #openstack-nova | 01:31 | |
*** Apoorva_ has quit IRC | 01:31 | |
*** tuanluong has joined #openstack-nova | 01:31 | |
*** vladik has quit IRC | 01:31 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Blacklist sphinx 1.6.1 and later https://review.openstack.org/470077 | 01:32 |
*** johnhaan has joined #openstack-nova | 01:34 | |
*** Hosam has quit IRC | 01:35 | |
*** Hosam has joined #openstack-nova | 01:35 | |
*** Yangyapeng has joined #openstack-nova | 01:35 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Blacklist sphinx 1.6.1 and later https://review.openstack.org/470077 | 01:38 |
*** hongbin has joined #openstack-nova | 01:40 | |
*** Hosam has quit IRC | 01:49 | |
*** Hosam has joined #openstack-nova | 01:50 | |
*** huanxie has joined #openstack-nova | 01:50 | |
*** gomarivera has joined #openstack-nova | 01:51 | |
*** kaisers_ has joined #openstack-nova | 01:51 | |
*** kaisers has quit IRC | 01:55 | |
cfriesen_ | I tried creating some extra-specs in api_sample_tests/test_servers.py and got a 403 response. I'm guessing the tests are not run as an admin user? | 01:56 |
cfriesen_ | looks like it, I added "ADMIN_API = True" and now I can do it | 01:57 |
melwitt | yeah, you need something like "self.admin_api = self.api_fixture.admin_api" in setUp() | 01:58 |
*** arunmani_ has joined #openstack-nova | 01:58 | |
melwitt | cfriesen_: I dunno if you saw my earlier link to a test that creates flavors, to use as an example. it might help https://review.openstack.org/#/c/355091/8/nova/tests/functional/test_boot_from_volume.py | 02:00 |
*** jamielennox|away is now known as jamielennox | 02:00 | |
*** jwnx has joined #openstack-nova | 02:01 | |
*** thorst has quit IRC | 02:02 | |
*** Hosam has quit IRC | 02:03 | |
*** Hosam has joined #openstack-nova | 02:04 | |
cfriesen_ | melwitt: can you mix the integrated_helpers stuff with the api samples tests though? | 02:05 |
cfriesen_ | melwitt: I've got the flavor extra spec creation working, now just trying to fix up the template matching | 02:05 |
melwitt | cfriesen_: oh, I didn't realize you were working on a api sample test. maybe not, I'm not sure | 02:09 |
melwitt | sounds like you're through the woods already anyway | 02:09 |
*** rajathagasthya has quit IRC | 02:10 | |
cfriesen_ | melwitt: I think so. it'd be nicer if the template/result comparison gave an error messsage better than "Failed to match Template to Response: Values do not match:" | 02:10 |
melwitt | yeah. I've worked on api samples a few times and it was frustrating | 02:11 |
mriedem | cfriesen_: if you're creating a new flavor with a dynamic id/name each time then i think the api samples are going to be hard | 02:12 |
mriedem | b/c the nova/doc/api_samples have to have something hard-coded for the actual api-ref docs | 02:12 |
mriedem | they can't have like %(uuid)s | 02:12 |
cfriesen_ | mriedem: I'm just adding extra-specs to flavor 1 | 02:12 |
melwitt | if he's doing a new test he'll have new json that he can add the {uuid} matcher thing to, right? | 02:12 |
*** tbachman has quit IRC | 02:13 | |
melwitt | oh | 02:13 |
cfriesen_ | or is that going to mess up other tests? | 02:13 |
cfriesen_ | If I have to make a new flavor I can do that, I think we can hardcode the flavor id | 02:14 |
cfriesen_ | all this just to put some extra-specs in the api sample | 02:15 |
*** hieulq_ has joined #openstack-nova | 02:15 | |
*** xinliang has quit IRC | 02:15 | |
melwitt | api samples, you just don't touch em | 02:15 |
melwitt | back away slowly | 02:16 |
cfriesen_ | it's all mriedem's fault | 02:16 |
melwitt | heh | 02:16 |
cfriesen_ | hmm...adding extra-specs to one of the default flavors really didn't break much at all: https://review.openstack.org/#/c/470076/1 | 02:17 |
*** Hosam has quit IRC | 02:17 | |
cfriesen_ | wonder if that's actually enough to use in functional tests | 02:18 |
*** Hosam has joined #openstack-nova | 02:18 | |
mriedem | cfriesen_: i think that's your easiest bet | 02:19 |
mriedem | is modify an existing default flavor or add a new one with extra spec | 02:19 |
mriedem | then you can hard-code that flavor id into your samples | 02:19 |
cfriesen_ | I think that'll actually work | 02:20 |
* mriedem goes back to learning about constellations https://review.openstack.org/#/c/453262/ | 02:21 | |
melwitt | first I've heard of that | 02:22 |
*** links has joined #openstack-nova | 02:22 | |
melwitt | "constellations" | 02:22 |
mriedem | buckle up | 02:23 |
melwitt | heh | 02:24 |
melwitt | yeah, reading some of the comments. got sucked in | 02:24 |
mriedem | your boss is in there | 02:25 |
mriedem | bossing it up | 02:25 |
melwitt | I see that :) | 02:25 |
*** hieulq_ has quit IRC | 02:25 | |
*** xinliang has joined #openstack-nova | 02:27 | |
*** thorst has joined #openstack-nova | 02:29 | |
*** gomarivera has quit IRC | 02:29 | |
*** thorst has quit IRC | 02:30 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/470119 | 02:32 |
*** faizy has quit IRC | 02:33 | |
*** faizy has joined #openstack-nova | 02:34 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/467173 | 02:34 |
*** tbachman has joined #openstack-nova | 02:36 | |
*** Hosam has quit IRC | 02:36 | |
*** Hosam has joined #openstack-nova | 02:37 | |
*** jichen has joined #openstack-nova | 02:39 | |
*** mriedem has quit IRC | 02:40 | |
*** thorst has joined #openstack-nova | 02:41 | |
*** thorst has quit IRC | 02:41 | |
*** jichen_ has joined #openstack-nova | 02:44 | |
openstackgerrit | Chris Friesen proposed openstack/nova master: add new test fixture flavor with extra_specs https://review.openstack.org/470076 | 02:44 |
*** jichen has quit IRC | 02:46 | |
*** jichen_ is now known as jichen | 02:46 | |
*** salv-orlando has joined #openstack-nova | 02:50 | |
*** thorst has joined #openstack-nova | 02:51 | |
*** thorst has quit IRC | 02:51 | |
cfriesen_ | when running functional tests is it possible to get debug logs emitted to somewhere? I'm getting a 400 status when I try to create a new server and I can't tell why | 02:58 |
*** Hosam has quit IRC | 03:00 | |
*** edmondsw has joined #openstack-nova | 03:00 | |
*** Hosam has joined #openstack-nova | 03:00 | |
*** arunmani_ has quit IRC | 03:01 | |
*** salv-orlando has quit IRC | 03:02 | |
*** edmondsw has quit IRC | 03:04 | |
*** fragatina has quit IRC | 03:05 | |
*** fragatina has joined #openstack-nova | 03:05 | |
*** karthiks has joined #openstack-nova | 03:09 | |
*** winston-d_ has joined #openstack-nova | 03:12 | |
*** cNilesh has joined #openstack-nova | 03:15 | |
*** vks1 has joined #openstack-nova | 03:16 | |
*** acormier has quit IRC | 03:18 | |
*** Hosam has quit IRC | 03:19 | |
*** Hosam has joined #openstack-nova | 03:19 | |
*** vladikr has quit IRC | 03:22 | |
*** thorst has joined #openstack-nova | 03:22 | |
*** penick has quit IRC | 03:23 | |
*** jamielennox is now known as jamielennox|away | 03:30 | |
*** hongbin has quit IRC | 03:39 | |
*** thorst has quit IRC | 03:40 | |
*** armax has quit IRC | 03:41 | |
*** armax has joined #openstack-nova | 03:45 | |
*** psachin has joined #openstack-nova | 03:45 | |
*** faizy_ has joined #openstack-nova | 03:47 | |
*** Hosam has quit IRC | 03:47 | |
openstackgerrit | Merged openstack/nova master: Add test ensure all the microversions are sequential in placement API https://review.openstack.org/458049 | 03:47 |
*** nicolasbock has quit IRC | 03:48 | |
*** Hosam has joined #openstack-nova | 03:48 | |
*** arunmani_ has joined #openstack-nova | 03:50 | |
*** arunmani_ has quit IRC | 03:50 | |
*** faizy has quit IRC | 03:51 | |
*** sree has joined #openstack-nova | 03:55 | |
*** armax has quit IRC | 04:00 | |
melwitt | cfriesen_: run with OS_DEBUG = 1 tox ... | 04:01 |
melwitt | OS_DEBUG=1 tox ... | 04:05 |
*** faizy_ has quit IRC | 04:06 | |
*** faizy has joined #openstack-nova | 04:07 | |
*** tbachman has quit IRC | 04:09 | |
*** hieulq_ has joined #openstack-nova | 04:09 | |
*** hieulq_ has quit IRC | 04:09 | |
*** jowisz_ has quit IRC | 04:09 | |
cfriesen_ | melwitt: thanks, that's helpful | 04:12 |
*** Hosam has quit IRC | 04:15 | |
*** Hosam has joined #openstack-nova | 04:16 | |
*** jowisz has joined #openstack-nova | 04:22 | |
*** salv-orlando has joined #openstack-nova | 04:25 | |
*** Hosam has quit IRC | 04:30 | |
*** Hosam has joined #openstack-nova | 04:30 | |
*** mlakat has quit IRC | 04:31 | |
*** salv-orlando has quit IRC | 04:37 | |
*** thorst has joined #openstack-nova | 04:37 | |
*** mlakat has joined #openstack-nova | 04:38 | |
*** Hosam has quit IRC | 04:39 | |
*** Hosam has joined #openstack-nova | 04:40 | |
*** mdnadeem has joined #openstack-nova | 04:40 | |
*** jaosorior has joined #openstack-nova | 04:41 | |
*** thorst has quit IRC | 04:42 | |
*** slaweq has joined #openstack-nova | 04:42 | |
*** slaweq has quit IRC | 04:43 | |
openstackgerrit | Chris Friesen proposed openstack/nova master: add new test fixture flavor with extra_specs https://review.openstack.org/470076 | 04:43 |
*** yamamoto_ has quit IRC | 04:46 | |
*** kornicameister has joined #openstack-nova | 04:50 | |
openstackgerrit | melanie witt proposed openstack/nova master: Add database migration and model for consumers https://review.openstack.org/469633 | 04:51 |
openstackgerrit | melanie witt proposed openstack/nova master: Add project_id and user_id to PUT /allocations https://review.openstack.org/469634 | 04:51 |
openstackgerrit | melanie witt proposed openstack/nova master: Add GET /usages to placement API https://review.openstack.org/469635 | 04:51 |
*** ltomasbo|away is now known as ltomasbo | 04:53 | |
*** Hosam has quit IRC | 04:53 | |
*** Hosam has joined #openstack-nova | 04:54 | |
*** claudiub has joined #openstack-nova | 05:09 | |
*** trinaths has joined #openstack-nova | 05:11 | |
*** tovin07_ has quit IRC | 05:11 | |
*** gouthamr has quit IRC | 05:15 | |
*** udesale has joined #openstack-nova | 05:17 | |
*** Hosam has quit IRC | 05:17 | |
*** Hosam has joined #openstack-nova | 05:17 | |
*** arahal_ has joined #openstack-nova | 05:21 | |
*** prateek has joined #openstack-nova | 05:23 | |
*** rcernin has joined #openstack-nova | 05:26 | |
*** arahal_ has quit IRC | 05:27 | |
*** markvoelker_ has joined #openstack-nova | 05:27 | |
*** trinaths has left #openstack-nova | 05:27 | |
*** markvoelker has quit IRC | 05:28 | |
*** mmedvede has quit IRC | 05:28 | |
*** mmedvede has joined #openstack-nova | 05:31 | |
*** arunman has joined #openstack-nova | 05:32 | |
*** yamamoto_ has joined #openstack-nova | 05:32 | |
*** salv-orlando has joined #openstack-nova | 05:33 | |
*** sridharg has joined #openstack-nova | 05:34 | |
*** fandi has joined #openstack-nova | 05:37 | |
*** fandi has quit IRC | 05:37 | |
*** fandi has joined #openstack-nova | 05:37 | |
*** thorst has joined #openstack-nova | 05:38 | |
*** Hosam has quit IRC | 05:41 | |
*** Hosam has joined #openstack-nova | 05:41 | |
*** thorst has quit IRC | 05:43 | |
*** ratailor has joined #openstack-nova | 05:48 | |
*** litao__ has joined #openstack-nova | 05:50 | |
openstackgerrit | Hironori Shiina proposed openstack/nova master: Ironic: Support boot from Cinder volume https://review.openstack.org/215385 | 05:54 |
openstackgerrit | Huan Xie proposed openstack/nova master: XenAPI: use os-xenapi 0.2.0 in nova https://review.openstack.org/453493 | 05:57 |
*** Hosam has quit IRC | 06:00 | |
*** jwnx has quit IRC | 06:00 | |
*** Hosam has joined #openstack-nova | 06:00 | |
*** takashin has left #openstack-nova | 06:00 | |
*** Hosam has quit IRC | 06:04 | |
*** Hosam has joined #openstack-nova | 06:05 | |
*** markus_z has joined #openstack-nova | 06:10 | |
openstackgerrit | Chris Friesen proposed openstack/nova master: show flavor info in server details https://review.openstack.org/434514 | 06:10 |
*** Oku_OS-away is now known as Oku_OS | 06:11 | |
openstackgerrit | Chris Friesen proposed openstack/nova master: show flavor info in server details https://review.openstack.org/434514 | 06:12 |
*** kaisers_ has quit IRC | 06:13 | |
*** kaisers has joined #openstack-nova | 06:13 | |
*** Swami has joined #openstack-nova | 06:15 | |
*** gjayavelu has joined #openstack-nova | 06:15 | |
openstackgerrit | jichenjc proposed openstack/nova master: propagate OSError to MigrationPreCheckError https://review.openstack.org/469779 | 06:19 |
*** trinaths1 has joined #openstack-nova | 06:21 | |
*** Hosam has quit IRC | 06:23 | |
*** Hosam has joined #openstack-nova | 06:24 | |
*** dikonoor has quit IRC | 06:25 | |
*** dikonoor has joined #openstack-nova | 06:25 | |
*** phuongnh has quit IRC | 06:27 | |
*** phuongnh has joined #openstack-nova | 06:28 | |
*** Swami has quit IRC | 06:32 | |
*** udesale__ has joined #openstack-nova | 06:32 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800 | 06:33 |
*** crushil has quit IRC | 06:34 | |
*** udesale has quit IRC | 06:34 | |
*** salv-orlando has quit IRC | 06:35 | |
*** edmondsw has joined #openstack-nova | 06:36 | |
*** edmondsw has quit IRC | 06:41 | |
*** Hosam has quit IRC | 06:42 | |
*** Hosam has joined #openstack-nova | 06:43 | |
*** cfriesen_ has quit IRC | 06:44 | |
*** ralonsoh has joined #openstack-nova | 06:45 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Use plain routes list for os-consoles, os-console-auth-tokens endpoint instead of stevedore https://review.openstack.org/462175 | 06:53 |
*** mnestratov|2 has joined #openstack-nova | 06:53 | |
*** Hosam has quit IRC | 06:56 | |
*** Hosam has joined #openstack-nova | 06:57 | |
*** fandi has quit IRC | 07:01 | |
*** murugesh has joined #openstack-nova | 07:03 | |
*** tesseract has joined #openstack-nova | 07:04 | |
*** Hosam has quit IRC | 07:10 | |
*** Hosam has joined #openstack-nova | 07:11 | |
*** sridharg has quit IRC | 07:12 | |
*** udesale has joined #openstack-nova | 07:20 | |
*** gszasz has joined #openstack-nova | 07:21 | |
*** udesale__ has quit IRC | 07:21 | |
*** sridharg has joined #openstack-nova | 07:25 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Use plain routes list for block_device_mapping instead of stevedore https://review.openstack.org/462180 | 07:26 |
*** sridhargaddam has joined #openstack-nova | 07:27 | |
*** dikonoor has quit IRC | 07:28 | |
*** hferenc has joined #openstack-nova | 07:29 | |
*** sridharg has quit IRC | 07:30 | |
*** sridhargaddam has quit IRC | 07:33 | |
*** sridharg has joined #openstack-nova | 07:33 | |
*** jpena|off is now known as jpena | 07:34 | |
*** Hosam has quit IRC | 07:39 | |
*** thorst has joined #openstack-nova | 07:39 | |
*** Hosam has joined #openstack-nova | 07:40 | |
openstackgerrit | Felix Ma proposed openstack/nova master: Handle bdm save failure in attach https://review.openstack.org/470181 | 07:40 |
*** thorst has quit IRC | 07:44 | |
*** lpetrut has joined #openstack-nova | 07:48 | |
*** Hosam has quit IRC | 07:48 | |
*** Hosam has joined #openstack-nova | 07:49 | |
openstackgerrit | Michael Henkel proposed openstack/nova master: contrail: add vrouter VIF plugin type support https://review.openstack.org/441183 | 07:50 |
openstackgerrit | Michael Henkel proposed openstack/nova master: contrail: add vrouter VIF plugin type support https://review.openstack.org/441183 | 07:51 |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-nova | 08:01 | |
*** Hosam has quit IRC | 08:03 | |
*** Hosam has joined #openstack-nova | 08:03 | |
*** phuongnh has quit IRC | 08:07 | |
*** phuongnh has joined #openstack-nova | 08:07 | |
*** faizy has quit IRC | 08:08 | |
*** sree has quit IRC | 08:08 | |
*** sree has joined #openstack-nova | 08:09 | |
*** faizy has joined #openstack-nova | 08:10 | |
*** sridharg has quit IRC | 08:12 | |
*** faizy has quit IRC | 08:12 | |
*** sridharg has joined #openstack-nova | 08:12 | |
*** faizy has joined #openstack-nova | 08:13 | |
*** sree has quit IRC | 08:13 | |
*** liuqing has quit IRC | 08:14 | |
*** liuqing has joined #openstack-nova | 08:15 | |
*** tiendc has joined #openstack-nova | 08:17 | |
*** sree has joined #openstack-nova | 08:17 | |
*** Hosam has quit IRC | 08:17 | |
*** hshiina has joined #openstack-nova | 08:17 | |
*** Hosam has joined #openstack-nova | 08:17 | |
*** lucas-afk is now known as lucasagomes | 08:18 | |
*** jamielennox|away is now known as jamielennox | 08:21 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Use plain routes list for user_data instead of stevedore https://review.openstack.org/462183 | 08:27 |
*** dikonoor has joined #openstack-nova | 08:29 | |
*** derekh has joined #openstack-nova | 08:35 | |
*** thorst has joined #openstack-nova | 08:40 | |
*** gjayavelu has quit IRC | 08:40 | |
*** brault has joined #openstack-nova | 08:42 | |
*** alexchadin has joined #openstack-nova | 08:46 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4) https://review.openstack.org/459593 | 08:47 |
*** jamielennox is now known as jamielennox|away | 08:49 | |
*** cdent has joined #openstack-nova | 08:50 | |
*** brault has quit IRC | 08:58 | |
*** thorst has quit IRC | 08:59 | |
*** hferenc has quit IRC | 09:01 | |
*** brault has joined #openstack-nova | 09:02 | |
*** hferenc has joined #openstack-nova | 09:02 | |
*** Hosam has quit IRC | 09:04 | |
*** gjayavelu has joined #openstack-nova | 09:05 | |
*** Hosam has joined #openstack-nova | 09:05 | |
*** dikonoor has quit IRC | 09:05 | |
*** fragatina has quit IRC | 09:06 | |
*** sambetts|afk is now known as sambetts | 09:06 | |
*** fragatina has joined #openstack-nova | 09:06 | |
*** gjayavelu has quit IRC | 09:08 | |
cdent | alex_xu: if you're still around, can you add a bit more detail on the scenario that would cause the duplicate problems in https://review.openstack.org/#/c/469578/ ? I had though that the combination of the local process lock, and the writer transaction would handle it? Are you concerned about the situation where there are different versions of the os-traits library on different machines? | 09:16 |
*** udesale__ has joined #openstack-nova | 09:19 | |
*** faizy has quit IRC | 09:21 | |
*** udesale has quit IRC | 09:22 | |
*** sree has quit IRC | 09:30 | |
*** sree has joined #openstack-nova | 09:31 | |
*** Hosam has quit IRC | 09:32 | |
*** Hosam has joined #openstack-nova | 09:33 | |
*** jichen has quit IRC | 09:34 | |
*** Shunli has quit IRC | 09:34 | |
*** murugesh has quit IRC | 09:35 | |
*** sree has quit IRC | 09:35 | |
*** dikonoor has joined #openstack-nova | 09:36 | |
openstackgerrit | sean mooney proposed openstack/os-vif master: set mtu on all code paths https://review.openstack.org/469951 | 09:38 |
alex_xu | cdent: I mean when multiple placement-api deployed on multiple nodes. When two users request to list traits, both of them will trigger the sync | 09:39 |
alex_xu | only one of them can sync successfully | 09:39 |
alex_xu | the transaction doesn't help that case I think | 09:39 |
cdent | that's the part i don't understand, why not? | 09:40 |
cdent | I had thought the transaction would? | 09:40 |
cdent | but then I'm often confused by what actually happens with transactions | 09:40 |
alex_xu | the transcation only ensure the consistent view of the data, except you set the transaction isolation level to serializable | 09:42 |
cdent | alex_xu: so, is the simplest solution to catch the duplicate error, log it, and move on? | 09:46 |
alex_xu | cdent: yea, I think so | 09:47 |
*** Hosam has quit IRC | 09:51 | |
*** Hosam has joined #openstack-nova | 09:52 | |
*** cNilesh has quit IRC | 09:54 | |
*** cNilesh has joined #openstack-nova | 09:55 | |
*** Hosam has quit IRC | 09:56 | |
*** thorst has joined #openstack-nova | 09:56 | |
*** tbachman has joined #openstack-nova | 09:58 | |
*** aarefiev_afk is now known as aarefiev | 10:00 | |
*** udesale has joined #openstack-nova | 10:00 | |
*** Hosam has joined #openstack-nova | 10:01 | |
*** thorst has quit IRC | 10:01 | |
*** jaosorior is now known as jaosorior_lunch | 10:01 | |
*** udesale__ has quit IRC | 10:02 | |
*** cNilesh has quit IRC | 10:03 | |
*** nicolasbock has joined #openstack-nova | 10:03 | |
*** sree has joined #openstack-nova | 10:04 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Add PCIWeigher https://review.openstack.org/379524 | 10:04 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Prefer non-PCI host nodes for non-PCI instances https://review.openstack.org/379625 | 10:04 |
*** ericyoung has joined #openstack-nova | 10:07 | |
*** lunarlamp has quit IRC | 10:08 | |
*** sree has quit IRC | 10:08 | |
*** Hosam has quit IRC | 10:10 | |
*** Hosam has joined #openstack-nova | 10:11 | |
*** mariusv has joined #openstack-nova | 10:11 | |
openstackgerrit | Claudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages https://review.openstack.org/447505 | 10:12 |
*** lucasagomes has quit IRC | 10:13 | |
*** salv-orlando has joined #openstack-nova | 10:20 | |
*** litao__ has quit IRC | 10:21 | |
*** yamamoto_ has quit IRC | 10:22 | |
*** tbachman has quit IRC | 10:26 | |
openstackgerrit | NidhiMittalHada proposed openstack/python-novaclient master: Reset-state's default parameter needs correction https://review.openstack.org/463477 | 10:27 |
*** Hosam has quit IRC | 10:29 | |
*** Hosam has joined #openstack-nova | 10:30 | |
*** tuanluong has quit IRC | 10:35 | |
*** tbachman has joined #openstack-nova | 10:36 | |
*** karthiks has quit IRC | 10:37 | |
*** tiendc has quit IRC | 10:39 | |
kashyap | mriedem: When you're about, as someone who dabbles with libvirt / block layers sometimes, might want to look at this - https://review.openstack.org/#/c/465205/ | 10:41 |
kashyap | It is ready to merge | 10:41 |
kashyap | And, fairly straight-forward | 10:41 |
*** alexchadin has quit IRC | 10:41 | |
*** ltomasbo is now known as ltomasbo|away | 10:42 | |
*** Yangyapeng has quit IRC | 10:42 | |
*** diga has joined #openstack-nova | 10:43 | |
*** Hosam has quit IRC | 10:43 | |
*** Hosam has joined #openstack-nova | 10:44 | |
*** mariusv has quit IRC | 10:44 | |
*** mariusv has joined #openstack-nova | 10:46 | |
*** mingyu has joined #openstack-nova | 10:46 | |
*** lucasagomes has joined #openstack-nova | 10:47 | |
*** phuongnh has quit IRC | 10:49 | |
openstackgerrit | NidhiMittalHada proposed openstack/python-novaclient master: client.logger.warning wrongly used in migrations https://review.openstack.org/463508 | 10:49 |
*** cdent has quit IRC | 10:49 | |
*** tbachman has quit IRC | 10:51 | |
*** cdent has joined #openstack-nova | 10:55 | |
*** mingyu has quit IRC | 10:57 | |
*** thorst has joined #openstack-nova | 10:57 | |
*** mingyu_ has joined #openstack-nova | 10:58 | |
*** mlakat has quit IRC | 11:01 | |
openstackgerrit | NidhiMittalHada proposed openstack/python-novaclient master: Help message for aggregate-update is ambiguous https://review.openstack.org/469753 | 11:01 |
*** thorst has quit IRC | 11:02 | |
*** dave-mccowan has joined #openstack-nova | 11:03 | |
*** mingyu_ has quit IRC | 11:03 | |
openstackgerrit | Michael Still proposed openstack/nova master: First attempt at adding a privsep user to nova. https://review.openstack.org/459166 | 11:03 |
*** lucasagomes is now known as lucas-hungry | 11:06 | |
*** Hosam has quit IRC | 11:07 | |
*** mingyu_ has joined #openstack-nova | 11:08 | |
*** brault has quit IRC | 11:08 | |
*** Hosam has joined #openstack-nova | 11:08 | |
*** brault has joined #openstack-nova | 11:08 | |
*** brault has quit IRC | 11:12 | |
*** vladikr has joined #openstack-nova | 11:13 | |
*** dikonoo has joined #openstack-nova | 11:13 | |
*** mlakat has joined #openstack-nova | 11:14 | |
*** coreywright has quit IRC | 11:14 | |
openstackgerrit | Dirk Mueller proposed openstack/nova-specs master: Fix citation references (Sphinx 1.6.x compatibility) https://review.openstack.org/470252 | 11:15 |
*** dikonoor has quit IRC | 11:16 | |
*** edmondsw has joined #openstack-nova | 11:19 | |
*** coreywright has joined #openstack-nova | 11:22 | |
*** dklyle has quit IRC | 11:25 | |
*** mingyu_ has quit IRC | 11:25 | |
openstackgerrit | Chris Dent proposed openstack/nova master: Fix ChanceScheduler returning a wrong node https://review.openstack.org/466725 | 11:27 |
*** fandi has joined #openstack-nova | 11:28 | |
*** salv-orlando has quit IRC | 11:29 | |
openstackgerrit | Dirk Mueller proposed openstack/nova-specs master: Fix citation references (Sphinx 1.6.x compatibility) https://review.openstack.org/470252 | 11:31 |
*** david-lyle has joined #openstack-nova | 11:31 | |
*** gcb has quit IRC | 11:34 | |
*** brault has joined #openstack-nova | 11:34 | |
*** gcb has joined #openstack-nova | 11:38 | |
*** diga has quit IRC | 11:41 | |
*** thorst has joined #openstack-nova | 11:41 | |
*** gcb has quit IRC | 11:43 | |
*** slaweq has joined #openstack-nova | 11:44 | |
*** thorst has quit IRC | 11:45 | |
*** nicolasbock has quit IRC | 11:46 | |
*** jpena is now known as jpena|lunch | 11:47 | |
*** yamamoto has joined #openstack-nova | 11:47 | |
*** slaweq has quit IRC | 11:48 | |
*** gcb has joined #openstack-nova | 11:52 | |
bauzas | cdent: thanks for rebasing https://review.openstack.org/#/c/466725/ | 11:53 |
*** tbachman has joined #openstack-nova | 11:54 | |
*** udesale has quit IRC | 11:55 | |
openstackgerrit | Dirk Mueller proposed openstack/nova-specs master: Fix citation references (Sphinx 1.6.x compatibility) https://review.openstack.org/470252 | 11:56 |
*** Hosam_ has joined #openstack-nova | 11:56 | |
*** nicolasbock has joined #openstack-nova | 11:56 | |
*** Hosam has quit IRC | 11:59 | |
*** rfolco has joined #openstack-nova | 12:01 | |
*** thorst has joined #openstack-nova | 12:01 | |
*** sree has joined #openstack-nova | 12:05 | |
*** arunman has quit IRC | 12:05 | |
*** liverpooler has joined #openstack-nova | 12:07 | |
*** gszasz has quit IRC | 12:07 | |
*** vks1 has quit IRC | 12:07 | |
*** catintheroof has joined #openstack-nova | 12:08 | |
openstackgerrit | Dirk Mueller proposed openstack/nova-specs master: Fix citation references (Sphinx 1.6.x compatibility) https://review.openstack.org/470252 | 12:09 |
*** sree has quit IRC | 12:09 | |
*** kfarr has joined #openstack-nova | 12:13 | |
*** lucas-hungry is now known as lucasagomes | 12:23 | |
*** Hosam_ has quit IRC | 12:23 | |
*** mdnadeem has quit IRC | 12:25 | |
openstackgerrit | Claudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages https://review.openstack.org/447505 | 12:28 |
*** baoli has joined #openstack-nova | 12:28 | |
*** ratailor has quit IRC | 12:31 | |
*** baoli has quit IRC | 12:31 | |
*** baoli has joined #openstack-nova | 12:31 | |
*** hferenc has quit IRC | 12:32 | |
*** nicolasbock has quit IRC | 12:33 | |
*** hferenc has joined #openstack-nova | 12:33 | |
*** jwcroppe has quit IRC | 12:36 | |
*** dpawlik has quit IRC | 12:39 | |
*** annegentle has joined #openstack-nova | 12:41 | |
*** mriedem has joined #openstack-nova | 12:43 | |
*** yamamoto has quit IRC | 12:43 | |
*** READ10 has joined #openstack-nova | 12:44 | |
*** lyan has joined #openstack-nova | 12:47 | |
mriedem | sfinucan: kashyap: someone from your team (sahid?) should probably take a look at this libvirt realtime feature bug v | 12:47 |
mriedem | https://bugs.launchpad.net/nova/+bug/1695056 | 12:47 |
openstack | Launchpad bug 1695056 in OpenStack Compute (nova) "libvirt realtime feature mlockall: Cannot allocate memory" [Undecided,New] | 12:47 |
*** jpena|lunch is now known as jpena | 12:47 | |
* kashyap clicks | 12:48 | |
*** liangy has joined #openstack-nova | 12:49 | |
*** liangy has quit IRC | 12:49 | |
*** yamamoto has joined #openstack-nova | 12:50 | |
* kashyap nods; yeah, sounds like this should be looked at | 12:50 | |
openstackgerrit | Alex Szarka proposed openstack/nova master: Add method for verify multiple versioned notifications https://review.openstack.org/465526 | 12:50 |
openstackgerrit | Alex Szarka proposed openstack/nova master: Add method for verify multiple versioned notifications https://review.openstack.org/465526 | 12:51 |
*** NostawRm has joined #openstack-nova | 12:51 | |
*** crushil has joined #openstack-nova | 12:51 | |
*** dillaman has quit IRC | 12:52 | |
*** kylek3h has joined #openstack-nova | 12:52 | |
*** jwcroppe has joined #openstack-nova | 12:54 | |
*** tdurakov has quit IRC | 12:54 | |
*** annegentle has quit IRC | 12:56 | |
openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | 12:58 |
*** yamamoto has quit IRC | 13:00 | |
*** jaosorior_lunch is now known as jaosorior | 13:03 | |
*** hshiina has quit IRC | 13:03 | |
*** gcb has quit IRC | 13:04 | |
*** dillaman has joined #openstack-nova | 13:05 | |
*** edleafe is now known as figleaf | 13:06 | |
openstackgerrit | Alex Szarka proposed openstack/nova master: Refactor instance-exists docstring and unit test https://review.openstack.org/462738 | 13:07 |
*** salv-orlando has joined #openstack-nova | 13:07 | |
*** mdrabe has joined #openstack-nova | 13:10 | |
*** trinaths1 has left #openstack-nova | 13:11 | |
*** cfriesen_ has joined #openstack-nova | 13:12 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Bump python-glanceclient minimum to 2.7.0 https://review.openstack.org/470281 | 13:13 |
*** kaisers has quit IRC | 13:13 | |
*** nicolasbock has joined #openstack-nova | 13:13 | |
*** hferenc has quit IRC | 13:14 | |
*** pchavva has joined #openstack-nova | 13:17 | |
*** lucasxu has joined #openstack-nova | 13:20 | |
openstackgerrit | Mihail proposed openstack/nova master: proposed fix for bug 1646896 - System hangs when using NFS storage backend with loopback mounts, Closes-Bug: #1646896 https://review.openstack.org/422041 | 13:21 |
openstack | bug 1646896 in OpenStack Compute (nova) "System hangs when using NFS storage backend with loopback mounts" [Low,Confirmed] https://launchpad.net/bugs/1646896 | 13:21 |
*** tbachman has quit IRC | 13:21 | |
openstackgerrit | Chris Friesen proposed openstack/nova master: show flavor info in server details https://review.openstack.org/434514 | 13:23 |
*** dillaman has quit IRC | 13:23 | |
*** Dinesh_Bhor has quit IRC | 13:24 | |
*** sridharg has quit IRC | 13:25 | |
*** psachin has quit IRC | 13:26 | |
*** Hosam has joined #openstack-nova | 13:26 | |
*** tbachman has joined #openstack-nova | 13:27 | |
*** prateek has quit IRC | 13:27 | |
*** salv-orl_ has joined #openstack-nova | 13:27 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Replace messaging.get_transport with get_rpc_transport https://review.openstack.org/469659 | 13:28 |
*** salv-orlando has quit IRC | 13:30 | |
*** jwnx has joined #openstack-nova | 13:31 | |
*** fandi has quit IRC | 13:34 | |
*** links has quit IRC | 13:35 | |
mriedem | sfinucan: bauzas: one of you want to pull the +W on this libvirt volume driver change? https://review.openstack.org/#/c/256292/ it's pretty trivial | 13:38 |
*** arahal_ has joined #openstack-nova | 13:39 | |
*** coreywright has quit IRC | 13:40 | |
bauzas | mriedem: ack, looking | 13:40 |
*** dillaman has joined #openstack-nova | 13:41 | |
rfolco | mriedem, would you please look at https://review.openstack.org/#/c/460231/ and https://review.openstack.org/#/c/460147/, both with one +2. | 13:41 |
mriedem | rfolco: yeah i can in a bit | 13:42 |
rfolco | mriedem, thx++ | 13:42 |
*** hferenc has joined #openstack-nova | 13:43 | |
mriedem | lyarwood: for when you're off sabbatical, this is right up your encrypted volume alley https://bugs.launchpad.net/nova/+bug/1439855 | 13:43 |
openstack | Launchpad bug 1439855 in OpenStack Compute (nova) "encrypted iSCSI volume fails to attach, name too long" [Medium,Confirmed] | 13:43 |
openstackgerrit | Mihail proposed openstack/nova master: proposed fix for bug 1646896 - System hangs when using NFS storage backend with loopback mounts, Closes-Bug: #1646896 https://review.openstack.org/422041 | 13:44 |
openstack | bug 1646896 in OpenStack Compute (nova) "System hangs when using NFS storage backend with loopback mounts" [Low,Confirmed] https://launchpad.net/bugs/1646896 | 13:44 |
*** felipemonteiro has joined #openstack-nova | 13:46 | |
*** coreywright has joined #openstack-nova | 13:46 | |
*** burt has joined #openstack-nova | 13:47 | |
*** awaugama has joined #openstack-nova | 13:49 | |
*** gomarivera has joined #openstack-nova | 13:50 | |
*** gouthamr has joined #openstack-nova | 13:51 | |
*** MVenesio has joined #openstack-nova | 13:51 | |
*** felipemonteiro__ has joined #openstack-nova | 13:51 | |
*** felipemonteiro has quit IRC | 13:55 | |
*** kwathore has quit IRC | 13:57 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: placement: Specific error for inventory in use https://review.openstack.org/460231 | 13:58 |
openstackgerrit | Mihail proposed openstack/nova master: proposed fix for bug 1646896 - System hangs when using NFS storage backend with loopback mounts, Closes-Bug: #1646896 https://review.openstack.org/422041 | 13:58 |
openstack | bug 1646896 in OpenStack Compute (nova) "System hangs when using NFS storage backend with loopback mounts" [Low,Confirmed] https://launchpad.net/bugs/1646896 | 13:58 |
*** tidwellr has joined #openstack-nova | 14:00 | |
bauzas | mriedem: had a comment on https://review.openstack.org/#/c/256292/6 | 14:00 |
*** yamamoto has joined #openstack-nova | 14:01 | |
bauzas | mriedem: out of curiosity, do you know if Tooz driver is still a thing for our SG API or whether we should consider etcd ? | 14:02 |
*** arunman has joined #openstack-nova | 14:03 | |
openstackgerrit | Claudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages https://review.openstack.org/447505 | 14:04 |
*** tbachman has quit IRC | 14:04 | |
*** eharney has joined #openstack-nova | 14:05 | |
*** yamamoto has quit IRC | 14:06 | |
*** mlavalle has joined #openstack-nova | 14:07 | |
mlavalle | mriedem: hey. I am looking at https://bugs.launchpad.net/nova/+bug/1694417 | 14:07 |
openstack | Launchpad bug 1694417 in OpenStack Compute (nova) "dhcp_domain used when use_neutron is not set" [Undecided,Incomplete] | 14:07 |
*** yamamoto has joined #openstack-nova | 14:07 | |
claudiub | mriedem: hi. i've found a nice pretty little bug. :) https://review.openstack.org/#/c/447505/13/nova/virt/libvirt/driver.py | 14:07 |
mlavalle | mriedem: seems that for the time being, we should wait for reply from the submitter | 14:08 |
sfinucan | mriedem, melwitt: All ze comments in https://review.openstack.org/#/c/379524/ _should_ be addressed now, if you fancy taking a gander today | 14:09 |
sfinucan | bauzas: RE: comments in https://review.openstack.org/#/c/256292/6/nova/virt/libvirt/volume/drbd.py | 14:09 |
sfinucan | instance is automatically exposed by oslo.log | 14:09 |
sfinucan | by way of the default formatter | 14:10 |
bauzas | mmmm okay | 14:10 |
*** ratailor has joined #openstack-nova | 14:10 | |
melwitt | yeah, you can do that on any log message | 14:10 |
sfinucan | at least, iirc. mriedem has suggested I do something similar a few times previously | 14:10 |
sfinucan | *prior? | 14:10 |
*** tbachman has joined #openstack-nova | 14:12 | |
claudiub | mriedem: also, one question: the cinder 3rd party ci requirements state that "CI's do not need to kick off tests until Jenkin's has given a +1", is there a similar policy for nova as well? ( https://wiki.openstack.org/wiki/Cinder/tested-3rdParty-drivers#Third_Party_CI_Requirements ) | 14:13 |
*** dikonoo has quit IRC | 14:14 | |
*** mingyu has joined #openstack-nova | 14:14 | |
*** baoli_ has joined #openstack-nova | 14:15 | |
*** bhagyashris has left #openstack-nova | 14:15 | |
*** READ10 has quit IRC | 14:15 | |
*** sridharg has joined #openstack-nova | 14:15 | |
*** sridharg has quit IRC | 14:16 | |
*** smatzek has joined #openstack-nova | 14:16 | |
*** smatzek_ has joined #openstack-nova | 14:17 | |
*** rdo_ has quit IRC | 14:18 | |
*** rdo_ has joined #openstack-nova | 14:18 | |
*** baoli has quit IRC | 14:18 | |
*** smatzek__ has joined #openstack-nova | 14:18 | |
efried | claudiub I have that same thought every couple months ;-) Problem is that it would make overall completion take longer. Which is the lesser evil? | 14:20 |
*** markus_z has quit IRC | 14:21 | |
*** smatzek has quit IRC | 14:21 | |
*** aarefiev is now known as aarefiev_afk | 14:22 | |
*** smatzek_ has quit IRC | 14:22 | |
claudiub | efried: i guess it depends on the size of the ci. at some point, all the ci resources could be allocated / in use. anyways, even though a ci can be configured to wait for jenkins to vote +1, it can still be triggered manually via "check some-ci" if needed. | 14:23 |
mriedem | bauzas: we should probably deprecate/remove tooz service group api driver | 14:23 |
mriedem | bauzas: it's not tested, | 14:23 |
mriedem | and i don't know if anyone outside of yahoo was using it | 14:23 |
mriedem | might be worth asking harlowja | 14:23 |
mriedem | bauzas: etcd is probably a better idea, and is something we can test in the gate | 14:24 |
mriedem | like i the multinode job or nova-next job | 14:24 |
mriedem | *in | 14:24 |
efried | claudiub Looks like mriedem missed that one in https://review.openstack.org/#/c/452958/ -- you going to propose the fix? | 14:24 |
mriedem | bauzas: instance=instance is common in all of our logging :) | 14:25 |
claudiub | ah, sure. will do. | 14:25 |
mriedem | efried: claudiub: missed what? | 14:25 |
mriedem | claudiub: i already have a patch for that | 14:25 |
claudiub | ah, ok. | 14:26 |
mriedem | claudiub: efried: https://review.openstack.org/#/c/469958/ | 14:26 |
mriedem | bauzas: sfinucan: melwitt: dansmith: jaypipes: ^ | 14:26 |
mriedem | and https://review.openstack.org/#/c/469740/ | 14:26 |
mriedem | live migration rollback is borked w/o those two | 14:26 |
bauzas | mriedem: about instance=instance, sorry for my ignorance | 14:26 |
*** peter-hamilton has joined #openstack-nova | 14:27 | |
sfinucan | mriedem: In a meeting, but I'll look at them soon as I'm done | 14:27 |
efried | claudiub Perhaps you can suggest how to use autospec for https://review.openstack.org/#/c/469958/1/nova/tests/unit/virt/libvirt/test_driver.py ? | 14:27 |
*** jmlowe has quit IRC | 14:29 | |
*** mlakat has quit IRC | 14:30 | |
efried | claudiub And https://review.openstack.org/#/c/469740/2/nova/tests/unit/compute/test_compute_mgr.py | 14:30 |
*** bnemec is now known as beekneemech | 14:30 | |
claudiub | efried: well, mock.patch does accept an "autospec" argument, but it doesn't work properly under the current release of mock. I have sent a bug report and bug fix for it: https://github.com/testing-cabal/mock/issues/396 | 14:32 |
claudiub | that should be the cleanest way; but it didn't get much attention unfortunately. | 14:32 |
efried | claudiub Riiight, I've been (sorta) following that. | 14:32 |
*** mingyu has quit IRC | 14:34 | |
*** lucasxu has quit IRC | 14:34 | |
claudiub | actually, it seems the mock library hasn't been updated in 6 months. | 14:35 |
*** gomarivera has quit IRC | 14:35 | |
*** lucasxu has joined #openstack-nova | 14:36 | |
*** smatzek__ has quit IRC | 14:37 | |
*** marst has joined #openstack-nova | 14:39 | |
*** felipemonteiro__ has quit IRC | 14:41 | |
*** felipemonteiro__ has joined #openstack-nova | 14:41 | |
*** catintheroof has quit IRC | 14:45 | |
*** Hosam has quit IRC | 14:48 | |
*** Hosam has joined #openstack-nova | 14:48 | |
*** jmlowe has joined #openstack-nova | 14:51 | |
*** Hosam has quit IRC | 14:52 | |
mriedem | rfolco: questions/issues in https://review.openstack.org/#/c/460147/ | 14:56 |
mriedem | cdent: ^ | 14:56 |
* cdent stirs | 14:56 | |
rfolco | mriedem, will address asap | 14:56 |
mriedem | i could be wrong | 14:57 |
cdent | mriedem: on which particular part? | 14:58 |
mriedem | any? | 14:59 |
mriedem | we used to check for 200 in the response from the 1.0 call | 15:00 |
mriedem | now we're checking a range, which is different and scary | 15:00 |
mriedem | and we're not handling 404 in case the RP is already gone | 15:00 |
cdent | the range thing is the generic version of "success" that is a mode of being a tolerant client. trendy | 15:00 |
cdent | the missing 404 is a good point, not sure if that's caught somewhere else or not, but very good of you to point it out | 15:01 |
cdent | probably means a missing gabbi test | 15:01 |
mriedem | i expect the fallback code to be the same as before, and the range thing is different, which is why i flagged it | 15:01 |
rfolco | I thought that was covered, would confirm | 15:01 |
cdent | s/gabbi/functional resource tracker/ | 15:01 |
mriedem | hard to review stuff like this if refactored parts are changed | 15:02 |
mriedem | if you want the range, do it in a preceeding change | 15:02 |
cdent | mriedem: i think an earlier review caused that change, opportunistic | 15:02 |
*** ratailor has quit IRC | 15:02 | |
cdent | s/caused/ask for/ | 15:02 |
mriedem | *preceding | 15:02 |
*** egonzalez has joined #openstack-nova | 15:02 | |
mriedem | let's separate it | 15:02 |
cdent | sure | 15:02 |
*** penick has joined #openstack-nova | 15:02 | |
cdent | rfolco: you on it? | 15:03 |
* cdent is writing this weeks rp update | 15:03 | |
* rfolco watching | 15:03 | |
cdent | anybody have anything I don't already know about (he said tautologically) | 15:03 |
*** rcernin has quit IRC | 15:05 | |
*** fragatina has quit IRC | 15:06 | |
rfolco | mmedvede, cdent: thanks for reviewing. | 15:07 |
rfolco | oops mriedem | 15:07 |
*** fragatina has joined #openstack-nova | 15:07 | |
rfolco | sorry mmedvede, used to call you on irc :) | 15:07 |
mmedvede | :) | 15:08 |
openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/470119 | 15:09 |
sfinucan | artom: Comments left on https://review.openstack.org/#/c/465205/. Happy to +2 if you can address em? | 15:09 |
artom | sfinucan, no, I shall sit here and pout until you +2 | 15:10 |
artom | sfinucan, in all serious, thanks for taking the time to review :) | 15:10 |
artom | Let me respin | 15:10 |
sfinucan | damn, pouting always gets me | 15:10 |
artom | Um, I... | 15:10 |
artom | I think you need to tell your bf/gf/wife/SO/whoever? | 15:11 |
artom | (I'm not taking any chances) | 15:11 |
*** cdent has left #openstack-nova | 15:11 | |
*** cdent has joined #openstack-nova | 15:11 | |
*** arahal_ has quit IRC | 15:13 | |
*** arahal_ has joined #openstack-nova | 15:13 | |
sfinucan | mriedem: Never show mdbooth those two patches - you'll surely set him off on one of his days long Python type system rants | 15:13 |
sfinucan | And, reviewed. All g with me | 15:13 |
mriedem | sfinucan: the live migration ones? he already saw one of them the other night | 15:14 |
mriedem | lee invoked his name | 15:14 |
sfinucan | dammit, lee | 15:14 |
mriedem | the inability to autospec those tests is frustrating, i could just be missing something trivial, | 15:14 |
mriedem | but i spent an hour one night trying to get it working on the driver_detach one and gave up | 15:14 |
*** armax has joined #openstack-nova | 15:15 | |
efried | claudiub Doesn't mock.patch autospec work in the decorator form? | 15:15 |
*** nic has joined #openstack-nova | 15:16 | |
*** nic has quit IRC | 15:16 | |
*** jaypipes is now known as leakypipes | 15:16 | |
sfinucan | I think pylint would catch those issues (too many args/invalid kwargs for function) | 15:16 |
sfinucan | but it'd introduce so many false positives as to make it not worth effort | 15:17 |
sfinucan | mriedem: Ever seen mypy? | 15:17 |
mriedem | no | 15:17 |
*** zz_dimtruck is now known as dimtruck | 15:17 | |
sfinucan | worth checking it out. I'm thinking of integrating it into some of the virt/libvirt code | 15:18 |
cdent | do you like it sfinucan ? | 15:18 |
sfinucan | The Sphinx source uses it pretty much everywhere | 15:18 |
cdent | it seems simultaneously really useful but also noisy | 15:18 |
sfinucan | cdent: I like it in it's Python 3 form | 15:18 |
sfinucan | with proper annotations rather than comments | 15:19 |
cdent | and lack of noise was one of the things that keeps me loyal to python | 15:19 |
sfinucan | the opt-in nature of the whole thing is pretty attractive to | 15:19 |
cdent | yes | 15:19 |
sfinucan | *too, even | 15:19 |
sfinucan | But the Python 2 variant is better than nothing, for some of the more complex stuff (like nearly everything in virt/libvirt) | 15:21 |
* cdent nods | 15:22 | |
mriedem | cfriesen_: pep8 on your chnage | 15:25 |
mriedem | *change | 15:25 |
*** cdent has quit IRC | 15:25 | |
*** felipemonteiro__ has quit IRC | 15:27 | |
*** gyee has joined #openstack-nova | 15:27 | |
*** dims has quit IRC | 15:28 | |
*** sambetts is now known as sambetts|afk | 15:29 | |
*** Oku_OS is now known as Oku_OS-away | 15:31 | |
openstackgerrit | Jay Pipes proposed openstack/nova master: Sync os-traits to Traits database https://review.openstack.org/469578 | 15:33 |
*** hongbin has joined #openstack-nova | 15:37 | |
*** lucasxu has quit IRC | 15:38 | |
mriedem | dansmith: heh i guess this is a duplicate https://review.openstack.org/#/c/460377/ of https://review.openstack.org/#/c/431722/ | 15:38 |
mriedem | drats | 15:38 |
dansmith | mriedem: it's all yours :) | 15:39 |
*** cNilesh has joined #openstack-nova | 15:39 | |
mriedem | looks like the only difference is you dropped the online data migrations, and in mine i think i was asking myself about that | 15:40 |
mriedem | b/c of skip level upgrading people | 15:40 |
mriedem | https://review.openstack.org/#/c/460377/6/nova/objects/flavor.py@648 | 15:41 |
*** tbachman has quit IRC | 15:41 | |
dansmith | mriedem: as I've said before, I don't think leaving migrations in the tree for that reason makes sense | 15:41 |
mriedem | i tend to agree | 15:41 |
mriedem | well i reckon i better sort out if there are any other differences here and drop mine - although i am of course partial to my commit message | 15:44 |
*** slaweq has joined #openstack-nova | 15:44 | |
dansmith | mriedem: I just abandoned mine so you can't do that :P | 15:48 |
*** slaweq has quit IRC | 15:49 | |
mriedem | hells bells | 15:49 |
*** cdent has joined #openstack-nova | 15:49 | |
mriedem | i figured i'd just rebase yours | 15:49 |
*** tbachman has joined #openstack-nova | 15:49 | |
*** Apoorva has joined #openstack-nova | 15:51 | |
*** ralonsoh has quit IRC | 15:54 | |
openstackgerrit | Merged openstack/nova master: Connecting Nova to DRBD storage nodes directly https://review.openstack.org/256292 | 15:55 |
*** salv-orl_ has quit IRC | 15:57 | |
*** tbachman has quit IRC | 15:58 | |
leakypipes | mriedem, melwitt, dansmith, bauzas: easy wins (placement-api-ref) starting here: https://review.openstack.org/#/c/452707/ | 16:00 |
*** tesseract has quit IRC | 16:00 | |
dansmith | dibs | 16:00 |
mriedem | i'm gonna clean up cfriesen_'s change and +2 before it lunch | 16:01 |
mriedem | so maybe post-lunch | 16:01 |
*** jwcroppe has quit IRC | 16:01 | |
*** arahal__ has joined #openstack-nova | 16:02 | |
*** jwcroppe has joined #openstack-nova | 16:02 | |
*** lpetrut has quit IRC | 16:03 | |
dansmith | leakypipes: are those not rendered in the docs job anywhere? | 16:03 |
*** ababich has quit IRC | 16:03 | |
*** nic has joined #openstack-nova | 16:03 | |
cdent | dansmith: different doc job, let me find link | 16:04 |
leakypipes | cdent: thx | 16:04 |
dansmith | found it | 16:04 |
cdent | gate-placement-api-ref-nv | 16:04 |
*** slaweq has joined #openstack-nova | 16:04 | |
*** aarefiev_afk has quit IRC | 16:05 | |
*** tbachman has joined #openstack-nova | 16:05 | |
*** arahal_ has quit IRC | 16:05 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Convert instance to primitive for metadata cache https://review.openstack.org/469978 | 16:06 |
*** nic1 has joined #openstack-nova | 16:07 | |
dansmith | we're really spoiling our users with this api_ref nonsense | 16:07 |
*** nic has quit IRC | 16:08 | |
*** cNilesh has quit IRC | 16:08 | |
*** gaurangt_ has quit IRC | 16:08 | |
*** cNilesh has joined #openstack-nova | 16:09 | |
leakypipes | dansmith: lol | 16:09 |
mriedem | dansmith: don't worry, we still have plenty of config options that change the behavior of the API in ways not communicated, | 16:09 |
mriedem | so we can still screw them | 16:09 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: show flavor info in server details https://review.openstack.org/434514 | 16:10 |
mriedem | ^ and below are +2'ed | 16:10 |
mriedem | looks big but it's mostly api-ref and api samples | 16:10 |
*** gaurangt has joined #openstack-nova | 16:11 | |
mriedem | now it's burger time | 16:11 |
*** mriedem is now known as mriedem_burgerti | 16:11 | |
mriedem_burgerti | damn | 16:11 |
*** mriedem_burgerti is now known as mriedem | 16:11 | |
artom | The little known Bugatti knock-off, Burgerti | 16:12 |
*** felipemonteiro has joined #openstack-nova | 16:12 | |
*** READ10 has joined #openstack-nova | 16:12 | |
leakypipes | "It's Burger! It's Burger time!". | 16:12 |
*** felipemonteiro__ has joined #openstack-nova | 16:13 | |
dansmith | leakypipes: we're allowing renaming of resource classes? | 16:13 |
*** yamamoto has quit IRC | 16:14 | |
leakypipes | dansmith: yes. | 16:15 |
leakypipes | dansmith: only custom ones of course. | 16:15 |
dansmith | isn't that going to confuse things? | 16:15 |
*** yamamoto has joined #openstack-nova | 16:15 | |
figleaf | to make them even more customer | 16:15 |
*** nic1 is now known as nic | 16:15 | |
dansmith | like, we have requests in flight that refer to the old name | 16:15 |
leakypipes | dansmith: no. internally custom ones are just an integer code. the name can be whatever the user wants. | 16:15 |
dansmith | and/or someone creates two and swaps them | 16:16 |
dansmith | don't we communicate between services using the symbolic names? | 16:16 |
figleaf | leakypipes: they will have to match whatever's in the flavor, though, no? | 16:16 |
leakypipes | dansmith: we leave that as an exercise for the readeer? :) | 16:16 |
dansmith | yeah what figleaf said | 16:16 |
*** pcaruana has quit IRC | 16:16 | |
*** liuqing has quit IRC | 16:16 | |
*** felipemonteiro has quit IRC | 16:16 | |
dansmith | I just see no reason to allow that.. might as well just delete and re-create so you get a new integer id and no confusion | 16:17 |
figleaf | dansmith: not feeling super today? | 16:17 |
dansmith | figleaf: definitely am not | 16:17 |
*** liuqing has joined #openstack-nova | 16:17 | |
leakypipes | dansmith: you and figleaf make a good point. cdent is our API master so I defer to him. | 16:17 |
* dansmith allocates a third cup of coffee against his resource provider to try to feel closer to super | 16:17 | |
figleaf | dunno if it has much to do with the API | 16:18 |
* leakypipes adjusts dansmith's coffee allocation ratio higher | 16:18 | |
cdent | I already fixed that in microversion 1.7 | 16:18 |
dansmith | cdent: fixed what? https://review.openstack.org/#/c/467596/4 says we can rename them | 16:18 |
leakypipes | cdent: so we don't allow changing resource class names in 1.7 and beyond? | 16:18 |
cdent | because it was not only a bad flow, but also an issue with the external issue | 16:18 |
cdent | leakypipes: if you are using a high microversion, correct, you cannot not rename a resource class | 16:19 |
cdent | you can delete and create another | 16:19 |
cdent | or rather | 16:19 |
cdent | create another | 16:19 |
cdent | everything external is using the name | 16:19 |
cdent | we can't allow changing it | 16:19 |
*** yamamoto has quit IRC | 16:19 | |
dansmith | ++ | 16:19 |
figleaf | cdent: ah, good | 16:20 |
cdent | I kind of feel like we should de-document the old way | 16:20 |
cdent | but that would lead to problems | 16:20 |
cdent | so perhaps a warning on the 1.2-1.6 microversion? | 16:21 |
dansmith | cdent: I think we should drop it from the docs, TBH | 16:21 |
cdent | I mean the doc for put /resource_classes/{name} | 16:21 |
dansmith | nobody is using this but us yet, so no reason to document something that is already obsolete | 16:21 |
claudiub | efried: not as it should. it doesn't consume the self / cls argument. if you are patching a function or a static method, it works fine though. | 16:21 |
dansmith | also, is PUT the right verb for "create or verify existence" ? | 16:21 |
dansmith | I would expect POST and return 409 if exists, no? | 16:22 |
cdent | PUT is the standard for idempotency when you know the url of the resoruce | 16:22 |
cdent | the idea here is that you can PUT /resource_classes/{name} all day long | 16:22 |
dansmith | hrm, okay | 16:23 |
cdent | and it will always return some form of success | 16:23 |
dansmith | seems wrong, but I guess I don't have time to convince the rest of the world today | 16:23 |
claudiub | mriedem: you didn't answer my one question :D : the cinder 3rd party ci requirements state that "CI's do not need to kick off tests until Jenkin's has given a +1", is there a similar policy for nova as well? ( https://wiki.openstack.org/wiki/Cinder/tested-3rdParty-drivers#Third_Party_CI_Requirements ) | 16:23 |
cdent | dansmith: the decision was driven by code in the resource tracker which was doing to "get_or_create_resource_class" | 16:23 |
cdent | I wanted to change it to "do one call to do both" | 16:23 |
cdent | which is PUT | 16:23 |
*** jwnx has quit IRC | 16:23 | |
artom | I think with PUT you're supposed to send the entire resource, and PATCH is for when you just send the changes? | 16:24 |
leakypipes | dansmith, cdent: added a note on 467596 to add a big fat warning in the UPDATE t1.2 through 1.6 section. | 16:24 |
dansmith | that way we can't log whether we created it, which means we can't highlight with a warning "I just created CUSTOM_GUP, hope you didn't typo that" | 16:24 |
cdent | artom: yes, but this is a different issue. a resource class PUT has no body | 16:24 |
cdent | dansmith: different resposne code on create or existence: | 16:25 |
artom | cdent, then we should only allow HEAD on it :D | 16:25 |
cdent | artom: :P | 16:25 |
* leakypipes goes back to work... this has the potential to be a lifeblood-depleting conversation | 16:25 | |
*** slaweq has quit IRC | 16:26 | |
artom | Bikeshedding about HTTP verbs? You don't say ;) | 16:26 |
dansmith | cdent: I see. less obvious, IMHO, but doesn't matter | 16:26 |
dansmith | I/we aren't bikeshedding | 16:26 |
dansmith | just chatting | 16:26 |
*** slaweq has joined #openstack-nova | 16:26 | |
* artom goes back to his corner and lets the serious people talk | 16:27 | |
cdent | dansmith: of course that's not what the code is doing now, it doesn't log on success, and I'm pretty sure it didn't before? | 16:27 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Use VIR_DOMAIN_BLOCK_REBASE_COPY_DEV when rebasing https://review.openstack.org/465205 | 16:27 |
dansmith | cdent: I haven't even looked, and I assume we won't know we need to log such a thing until the flood of bugs complaining about it | 16:28 |
dansmith | cdent: but if we have a way to tell so we can add that in the future then that's fine | 16:28 |
dansmith | that == that log line | 16:28 |
cdent | (just check, it isn't, at least not on the RT side, but yeah, there's a way to distinguish) | 16:28 |
cdent | s/check/checked/ | 16:28 |
artom | sfinucan ^^ addressed your feedback, except in one case where I don't agree :P | 16:28 |
*** ericyoung has quit IRC | 16:29 | |
*** cNilesh has quit IRC | 16:29 | |
*** hongbin has quit IRC | 16:29 | |
* cdent is extremely happy to experience chatting today/this week | 16:30 | |
*** mdrabe has quit IRC | 16:30 | |
*** jaosorior has quit IRC | 16:30 | |
sfinucan | artom: That's all g with me | 16:31 |
harlowja | mriedem whats up | 16:31 |
harlowja | `we should probably deprecate/remove tooz service group api driver` | 16:31 |
*** cNilesh has joined #openstack-nova | 16:31 | |
harlowja | i'd say that'd be ok, though its really up to u guys if u want to do that, and just go direct to etcd | 16:32 |
*** gomarivera has joined #openstack-nova | 16:32 | |
*** slaweq has quit IRC | 16:32 | |
harlowja | both imho are the same level of effort of undoing/redoing the stuff in nova that is specific to a database (for service groups) | 16:32 |
harlowja | that was the main problem that was hit i think when trying to refactor that stuff, is there are a bunch of places in nova that are tied to a database for that stuff (because calling serivice group stuff a driver interface is somewhat of a lie) | 16:33 |
*** slaweq has joined #openstack-nova | 16:33 | |
leakypipes | harlowja: yup. | 16:33 |
harlowja | refactoring to etcd (and a database for daatabase driver users), will likely be the same effort as refactoring to tooz in the end | 16:34 |
harlowja | so ya, meh, do as u want :-P | 16:34 |
harlowja | penick yahoo never continued down the path of that after vilobh left right? | 16:35 |
harlowja | (ie continuing the service group refactor to tooz and/or whatever else) | 16:35 |
artom | sfinucan, thanks g | 16:36 |
artom | (We so gangsta) | 16:36 |
*** cNilesh has quit IRC | 16:36 | |
*** cNilesh has joined #openstack-nova | 16:37 | |
*** Swami has joined #openstack-nova | 16:37 | |
harlowja | leakypipes mriedem what are your plans for that thing? | 16:39 |
harlowja | just go directly to etcd3? | 16:39 |
harlowja | or try again to have 2 drivers (one for database, one for etcd3 or ???) | 16:39 |
*** mdrabe has joined #openstack-nova | 16:44 | |
openstackgerrit | Merged openstack/python-novaclient master: Help message for aggregate-update is ambiguous https://review.openstack.org/469753 | 16:45 |
*** liverpooler has quit IRC | 16:46 | |
*** tidwellr has quit IRC | 16:46 | |
*** liverpooler has joined #openstack-nova | 16:46 | |
openstackgerrit | Merged openstack/nova master: libvirt: fix call args to destroy() during live migration rollback https://review.openstack.org/469958 | 16:48 |
*** tidwellr has joined #openstack-nova | 16:48 | |
*** eharney has quit IRC | 16:48 | |
*** mingyu has joined #openstack-nova | 16:50 | |
*** derekh has quit IRC | 16:51 | |
leakypipes | harlowja: my long term wishes are to get rid of the services from the REST API entirely. | 16:52 |
leakypipes | harlowja: and detach the servicegroup API entirely from the database. | 16:52 |
leakypipes | harlowja: and use something like os-lively for servicegroup liveness and maintenance API. | 16:52 |
harlowja | wfm | 16:52 |
*** claudiub has quit IRC | 16:52 | |
*** tidwellr has quit IRC | 16:53 | |
harlowja | remove all the thigns, lol | 16:53 |
*** mingyu has quit IRC | 16:54 | |
harlowja | leakypipes if u do it right, be nice to make something that other projects can use | 16:54 |
* harlowja see to many of the same type of crap in various projects | 16:54 | |
*** brault has quit IRC | 16:55 | |
harlowja | (as u know i think) | 16:55 |
*** brault has joined #openstack-nova | 16:55 | |
*** cNilesh has quit IRC | 16:55 | |
*** jwcroppe has quit IRC | 16:58 | |
*** brault has quit IRC | 17:00 | |
*** lucasxu has joined #openstack-nova | 17:00 | |
*** fragatina has quit IRC | 17:00 | |
*** pjm6 has quit IRC | 17:00 | |
*** pjm6 has joined #openstack-nova | 17:01 | |
*** jwcroppe has joined #openstack-nova | 17:02 | |
*** huanxie has quit IRC | 17:03 | |
*** huanxie has joined #openstack-nova | 17:03 | |
*** eharney has joined #openstack-nova | 17:03 | |
*** ckopper has joined #openstack-nova | 17:08 | |
openstackgerrit | Jay Pipes proposed openstack/nova master: Delete all inventory has its own method DELETE https://review.openstack.org/460147 | 17:08 |
leakypipes | mriedem: addressed your comments on ^^ | 17:08 |
*** dims has joined #openstack-nova | 17:10 | |
*** slaweq has quit IRC | 17:10 | |
*** tidwellr has joined #openstack-nova | 17:13 | |
leakypipes | rfolco: hope you don't mind, I just pushed some quick fixes and a new unit test on your patch 460147 | 17:15 |
*** yamamoto has joined #openstack-nova | 17:16 | |
*** xyang1 has joined #openstack-nova | 17:17 | |
*** penick has quit IRC | 17:18 | |
*** tbachman has quit IRC | 17:19 | |
*** swebster has quit IRC | 17:19 | |
rfolco | leakypipes, Thanks a lot. Appreciate your help. | 17:19 |
leakypipes | np | 17:19 |
*** yamamoto has quit IRC | 17:21 | |
*** READ10 has quit IRC | 17:23 | |
*** esberglu has quit IRC | 17:24 | |
*** dims has quit IRC | 17:24 | |
*** esberglu has joined #openstack-nova | 17:24 | |
*** raunak has joined #openstack-nova | 17:25 | |
*** sudipto has joined #openstack-nova | 17:25 | |
*** sudipto_ has joined #openstack-nova | 17:25 | |
*** jdillaman has quit IRC | 17:25 | |
*** dims has joined #openstack-nova | 17:26 | |
*** jdillaman has joined #openstack-nova | 17:27 | |
*** harlowja has quit IRC | 17:28 | |
*** READ10 has joined #openstack-nova | 17:28 | |
*** esberglu has quit IRC | 17:29 | |
*** lucasagomes is now known as lucas-afk | 17:30 | |
*** jwnx has joined #openstack-nova | 17:31 | |
*** tbachman has joined #openstack-nova | 17:34 | |
*** mingyu has joined #openstack-nova | 17:36 | |
*** esberglu has joined #openstack-nova | 17:37 | |
*** mingyu has quit IRC | 17:40 | |
*** gomarivera has quit IRC | 17:41 | |
melwitt | mriedem: before I go looking around, do you know if this bug is still a bug, by chance? https://bugs.launchpad.net/nova/+bug/1679750 | 17:41 |
openstack | Launchpad bug 1679750 in OpenStack Compute (nova) "Allocations are not cleaned up in placement for instance 'local delete' case" [Medium,Confirmed] - Assigned to Sylvain Bauza (sylvain-bauza) | 17:41 |
*** mnestratov|2 has quit IRC | 17:42 | |
*** penick has joined #openstack-nova | 17:44 | |
cfriesen_ | mriedem: thanks for the update...was AFK this morning. | 17:45 |
melwitt | mriedem: nevermind, looks like it is. I'll start writing the functional test you described in the bug | 17:47 |
*** penick has quit IRC | 17:48 | |
melwitt | cdent: what did you mean by "Did you want this file in the parent?" I was trying to guess what to do with the new microversion based on resource_classes*.yaml gabbits | 17:49 |
melwitt | cdent: oh wait, nevermind. yes, I put it in the wrong commit by accident | 17:50 |
cdent | melwitt: as far as I could tell that file was only testing /allocations not /usages so I thought perhaps it was meant for the earlier commit | 17:50 |
cdent | jinxish | 17:50 |
melwitt | yeah, I messed that up. thanks | 17:51 |
cdent | leakypipes: since we've been trading on the traits sync patch, just a heads up: it's failling some functional tests, I'll fix it | 17:51 |
*** sudipto has quit IRC | 17:53 | |
*** sudipto_ has quit IRC | 17:53 | |
leakypipes | cdent: cheers | 17:55 |
*** dtp has joined #openstack-nova | 17:57 | |
*** jwcroppe has quit IRC | 17:58 | |
*** Apoorva_ has joined #openstack-nova | 18:00 | |
*** arunman has quit IRC | 18:01 | |
mriedem | melwitt: i don't think so, unless it's part of bauzas' series on claims in the scheduler | 18:02 |
melwitt | mriedem: ah, good point, I'll skim through those to see | 18:02 |
openstackgerrit | Chris Dent proposed openstack/nova master: Sync os-traits to Traits database https://review.openstack.org/469578 | 18:03 |
*** Apoorva has quit IRC | 18:03 | |
cdent | that's it for me | 18:04 |
cdent | have a good weekend everyone | 18:04 |
*** cdent has quit IRC | 18:04 | |
*** jpena is now known as jpena|off | 18:05 | |
mriedem | leakypipes: dansmith: renaming custom resource classes? why? isn't that like renaming a flavor (which we don't allow)? | 18:05 |
mriedem | just because we can do a thing doesn't mean we should | 18:05 |
dansmith | mriedem: or renaming an enum yeah | 18:05 |
*** tbachman has quit IRC | 18:07 | |
mriedem | or is that pre-1.7 behavior? | 18:07 |
*** lbragstad has quit IRC | 18:08 | |
mriedem | i guess so https://review.openstack.org/#/c/467596/4/placement-api-ref/source/resource_class.inc@75 | 18:08 |
dansmith | yeah | 18:08 |
*** yamahata has joined #openstack-nova | 18:08 | |
*** sudipto_ has joined #openstack-nova | 18:09 | |
*** sudipto has joined #openstack-nova | 18:09 | |
mriedem | ok i thought this was something someone wanted to do | 18:09 |
mriedem | so with 1.7 you can't rename customer resource classes anymore? | 18:10 |
mriedem | PUT is now either a 201 or 204 | 18:10 |
*** rajathagasthya has joined #openstack-nova | 18:10 | |
mriedem | for create or ack it exists | 18:10 |
*** jwcroppe has joined #openstack-nova | 18:11 | |
*** tbachman has joined #openstack-nova | 18:12 | |
mriedem | oomichi: can you also go through this one? https://review.openstack.org/#/c/434514/ | 18:12 |
*** READ10 has quit IRC | 18:13 | |
dansmith | given leakypipes' recent tendency to have long lines in his commit messages, I feel like we should, as a project, adopt the max6 linter: https://github.com/petersn/six-char-max | 18:15 |
*** dims has quit IRC | 18:16 | |
leakypipes | dansmith: I've started to ensure tw=71 in commit messages now. | 18:16 |
dansmith | leakypipes: thank you | 18:16 |
*** dims has joined #openstack-nova | 18:17 | |
*** yamamoto has joined #openstack-nova | 18:17 | |
mriedem | dansmith: that would be great if you're coding in an AS400 terminal | 18:20 |
mriedem | but i think even they allow 8 | 18:20 |
mriedem | they're not nazis | 18:20 |
mriedem | only sold to them... | 18:20 |
dansmith | heh | 18:21 |
mriedem | QSECOFR 4VR | 18:21 |
dansmith | max6 would help me get back to writing all my code on a TRS-80 Model 100 | 18:22 |
*** yamamoto has quit IRC | 18:23 | |
*** sudipto has quit IRC | 18:25 | |
*** sudipto_ has quit IRC | 18:25 | |
mriedem | sfinucan: i feel vindicated https://review.openstack.org/#/c/379524/ | 18:27 |
mriedem | sfinucan: for totally not knowing wtf was going on | 18:27 |
mriedem | :) | 18:27 |
openstackgerrit | Merged openstack/nova master: [placement] Add api-ref for PUT RP inventories https://review.openstack.org/452707 | 18:28 |
openstackgerrit | Merged openstack/nova master: [placement] Add api-ref for DELETE RP inventories https://review.openstack.org/452708 | 18:29 |
openstackgerrit | Merged openstack/nova master: [placement] Add api-ref for GET RP inventory https://review.openstack.org/455213 | 18:30 |
openstackgerrit | Merged openstack/nova master: Use plain routes list for os-interface endpoint instead of stevedore https://review.openstack.org/459979 | 18:31 |
openstackgerrit | Merged openstack/nova master: Use plain routes list for server-tags instead of stevedore https://review.openstack.org/461645 | 18:32 |
openstackgerrit | Merged openstack/nova master: Use plain routes list for server-migrations endpoint instead of stevedore https://review.openstack.org/461646 | 18:32 |
openstackgerrit | Merged openstack/nova master: Use plain routes list for os-server-external-events endpoint https://review.openstack.org/468324 | 18:33 |
openstackgerrit | Merged openstack/nova master: Use plain routes list for server diagnostics endpoint https://review.openstack.org/468331 | 18:34 |
openstackgerrit | Merged openstack/nova master: [placement] Add api-ref for PUT RP inventory https://review.openstack.org/455214 | 18:35 |
openstackgerrit | Merged openstack/nova master: [placement] Add api-ref for DELETE RP inventory https://review.openstack.org/455215 | 18:36 |
melwitt | mriedem: is there already a way to talk to the placement API in our functional regression tests? like, to query for allocations? | 18:36 |
*** gomarivera has joined #openstack-nova | 18:36 | |
mriedem | there is a PlacementFixture | 18:36 |
openstackgerrit | Merged openstack/nova master: [placement] Add api-ref for POST resource provider https://review.openstack.org/456176 | 18:36 |
mriedem | which bypasses keystone i believe | 18:36 |
mriedem | it's used in some scheduler tests for 1.4 | 18:37 |
melwitt | okay, thanks. I'll look for that for examples | 18:37 |
openstackgerrit | Merged openstack/nova master: [placement] Add api-ref for GET resource provider https://review.openstack.org/467541 | 18:37 |
*** lbragstad has joined #openstack-nova | 18:38 | |
openstackgerrit | Merged openstack/nova master: [placement] Add api-ref for PUT resource provider https://review.openstack.org/467542 | 18:38 |
*** catintheroof has joined #openstack-nova | 18:38 | |
*** lbragstad has quit IRC | 18:39 | |
oomichi | mriedem: is that 2.47? some parameters contains it as 2.46 | 18:39 |
oomichi | on https://review.openstack.org/#/c/463263/ | 18:39 |
oomichi | oops wrong: https://review.openstack.org/#/c/434514/16/api-ref/source/parameters.yaml | 18:40 |
*** gjayavelu has joined #openstack-nova | 18:40 | |
openstackgerrit | Merged openstack/nova master: placement: Specific error for inventory in use https://review.openstack.org/460231 | 18:40 |
mriedem | oomichi: those are max_version for 2.46 | 18:40 |
*** lbragstad has joined #openstack-nova | 18:40 | |
mriedem | it's just a naming convention meaning those parameters are capped at 2.36 | 18:40 |
mriedem | *2.46 | 18:40 |
*** mingyu has joined #openstack-nova | 18:41 | |
oomichi | mriedem: ah, I got it. I cannot find the other points. It would be nice to merge | 18:41 |
*** lbragstad has quit IRC | 18:42 | |
mriedem | oomichi: the was/were is because they are describing a flavor in an existing instance, | 18:43 |
mriedem | e.g. the CPUs were already allocated | 18:43 |
*** tidwellr has quit IRC | 18:44 | |
*** lbragstad has joined #openstack-nova | 18:44 | |
*** lbragstad_ has joined #openstack-nova | 18:46 | |
*** lbragstad has quit IRC | 18:46 | |
*** gjayavelu has quit IRC | 18:46 | |
cfriesen_ | mriedem: just commented on that...we could remove the tense entirely | 18:47 |
*** gjayavelu has joined #openstack-nova | 18:47 | |
cfriesen_ | "The number of virtual CPUs allocated to the server" | 18:47 |
*** lbragstad_ has quit IRC | 18:47 | |
*** lbragstad has joined #openstack-nova | 18:48 | |
*** egonzalez has quit IRC | 18:49 | |
*** lbragstad has quit IRC | 18:49 | |
*** lbragstad__ has joined #openstack-nova | 18:49 | |
*** lbragstad__ has quit IRC | 18:49 | |
*** lbragstad__ has joined #openstack-nova | 18:49 | |
melwitt | do we really need to clean up servers created during functional tests? I thought the DatabaseFixture provides a fresh database for each test and gets thrown away per test | 18:49 |
mriedem | cfriesen_: good point, that could be cleaned up in a follow up change | 18:51 |
*** lbragstad__ has quit IRC | 18:51 | |
mriedem | cfriesen_: you've also got to get the novaclient change refreshed | 18:51 |
cfriesen_ | yeah | 18:51 |
*** lbragstad__ has joined #openstack-nova | 18:51 | |
mriedem | melwitt: maybe we do'nt need to no | 18:51 |
mriedem | i probably tend to do those b/c i think of them more like tempest | 18:52 |
*** lucasxu has quit IRC | 18:52 | |
mriedem | also nice to see if delete blows up or something | 18:52 |
melwitt | yeah. seeing it made me second guess it. yeah, I didn't think of that | 18:52 |
*** MasterOfBugs has joined #openstack-nova | 18:53 | |
*** lbragstad__ has quit IRC | 18:54 | |
*** lbragstad__ has joined #openstack-nova | 18:54 | |
*** raunak has quit IRC | 18:58 | |
*** lbragstad__ has quit IRC | 18:59 | |
*** gomarivera has quit IRC | 19:00 | |
cfriesen_ | mriedem: is someone working on a novaclient patch for 2.46? | 19:01 |
*** catintheroof has quit IRC | 19:02 | |
mriedem | isn't that already merged? | 19:02 |
cfriesen_ | mriedem: API_MAX_VERSION = api_versions.APIVersion("2.45") on master | 19:02 |
mriedem | oh i was thinking of this https://github.com/openstack/python-novaclient/commit/d25502cbe2749ed7042e427fe8d4a3678acf4550 | 19:02 |
mriedem | ^ should have probably been 2.46 | 19:02 |
mriedem | no test changes needed, just bump the version | 19:02 |
mriedem | i don't know if there is a patch for it yet | 19:03 |
cfriesen_ | I can bump directly to 2.47 if there's nothing needed for 2.46 | 19:03 |
mriedem | just do a patch for 2.46 and then do 2.47 on top of it | 19:03 |
cfriesen_ | kay | 19:03 |
*** lucasxu has joined #openstack-nova | 19:04 | |
*** eharney has quit IRC | 19:07 | |
cfriesen_ | mriedem: is a release note needed? | 19:09 |
cfriesen_ | or just skip it like was done for 2.42 | 19:09 |
*** rajathagasthya has quit IRC | 19:10 | |
mriedem | we do'nt need a release note in novaclient for 2.46 | 19:10 |
melwitt | gdi I'm getting that my compute node has 0GB disk available in my functional test so it fails to build a server with NoValidHost | 19:10 |
melwitt | I don't recall ever seeing that before | 19:11 |
clarkb | melwitt: in the gate? | 19:11 |
melwitt | no, locally | 19:11 |
*** kylek3h has quit IRC | 19:11 | |
*** rajathagasthya has joined #openstack-nova | 19:11 | |
mriedem | melwitt: should be using the fake virt driver already | 19:12 |
mriedem | via the conf fixture | 19:12 |
*** jwcroppe has quit IRC | 19:12 | |
*** lbragstad__ has joined #openstack-nova | 19:13 | |
melwitt | thanks, I'm copying a test that did everything manually and didn't realize I needed the set_nodes() etc stuff. my bad | 19:13 |
*** lbragstad__ is now known as lbragstad | 19:13 | |
*** gyee has quit IRC | 19:14 | |
*** rajathagasthya has quit IRC | 19:16 | |
openstackgerrit | Dirk Mueller proposed openstack/nova-specs master: Fix citation references (Sphinx 1.6.x compatibility) https://review.openstack.org/470252 | 19:16 |
cfriesen_ | mriedem: do we need cleanup in the novaclient functional tests? (I'm looking at jichenjc's comment in https://review.openstack.org/#/c/435141/7/novaclient/tests/functional/v2/test_servers.py) | 19:17 |
cfriesen_ | I'm happy to delete the server if desired. | 19:17 |
openstackgerrit | Dirk Mueller proposed openstack/nova-specs master: Fix citation references (Sphinx 1.6.x compatibility) https://review.openstack.org/470252 | 19:17 |
*** gyee has joined #openstack-nova | 19:17 | |
mriedem | cfriesen_: as in self.addCleanup(server.delete)? | 19:18 |
mriedem | yes we need that in novaclient functional tests, | 19:18 |
mriedem | they are backed by a single node dsvm env | 19:18 |
cfriesen_ | mriedem: was looking at _cleanup_server() actually | 19:18 |
mriedem | so if you don't cleanup, we can eventually hit resource / quota issues | 19:18 |
mriedem | we should always cleanup resources in integration tests | 19:18 |
mriedem | leaking leads to weird test failures later | 19:19 |
cfriesen_ | addCleanup is probably better? | 19:19 |
mriedem | i don't know what _cleanup_server() is | 19:19 |
mriedem | i don't care where we clean up | 19:19 |
mriedem | we just need to cleanup on teardown of each test | 19:19 |
*** yamamoto has joined #openstack-nova | 19:19 | |
mriedem | if we created something | 19:19 |
cfriesen_ | kay | 19:19 |
*** mingyu has quit IRC | 19:19 | |
*** mingyu has joined #openstack-nova | 19:20 | |
mriedem | just like the gd markers and coloring books all over my living room floor | 19:20 |
mriedem | i don't care how they got there, | 19:20 |
mriedem | i just want them cleaned up | 19:20 |
melwitt | hah | 19:20 |
*** eharney has joined #openstack-nova | 19:20 | |
*** pwiltsey has joined #openstack-nova | 19:21 | |
cfriesen_ | looks like it's already done for me actually...the helper function I used to create the server adds the cleanup | 19:22 |
openstackgerrit | Merged openstack/nova master: add new test fixture flavor with extra_specs https://review.openstack.org/470076 | 19:22 |
*** yamamoto has quit IRC | 19:24 | |
melwitt | hm, I think maybe this never works to use the DiskFilter in func tests. all the tests that derive from the integrated_helpers base use the chance scheduler and ones I see using filter scheduler aren't using the DiskFilter | 19:24 |
melwitt | I dumbly tried to just let it use default filters even though I don't care about the filters. changing to the chance scheduler | 19:25 |
mriedem | there are only like 2 filters you can use if you're doing filter scheduler, | 19:25 |
mriedem | allhostsfilter and retryfilter i think | 19:25 |
mriedem | maybe computefilter | 19:25 |
mriedem | something like that | 19:25 |
melwitt | yeah. guh, my fault for not knowing how this works until now I guess | 19:26 |
mriedem | the integrated_helpers stuff hides a lot of this | 19:26 |
melwitt | I always had just inherited from the integrated_helpers base test case and didn't think about it | 19:26 |
melwitt | yeah | 19:26 |
mriedem | once you start not relying on that, | 19:26 |
mriedem | you find out we use a buttload of fixtures :) | 19:26 |
melwitt | yeah, for reals | 19:27 |
openstackgerrit | Chris Friesen proposed openstack/python-novaclient master: 2.47: Show flavor info in server details https://review.openstack.org/435141 | 19:28 |
openstackgerrit | Chris Friesen proposed openstack/python-novaclient master: 2.46: match nova API version https://review.openstack.org/470413 | 19:28 |
*** kbaegis has joined #openstack-nova | 19:28 | |
mriedem | cfriesen_: you're going to need a unit test change on that bottom one, sec | 19:28 |
cfriesen_ | oh yeah, | 19:29 |
cfriesen_ | will update | 19:29 |
mriedem | cfriesen_: | 19:29 |
mriedem | https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/unit/v2/test_shell.py#L2907 | 19:29 |
*** mlo has joined #openstack-nova | 19:31 | |
*** mlo has left #openstack-nova | 19:32 | |
openstackgerrit | Chris Friesen proposed openstack/python-novaclient master: 2.47: Show flavor info in server details https://review.openstack.org/435141 | 19:33 |
openstackgerrit | Chris Friesen proposed openstack/python-novaclient master: 2.46: match nova API version https://review.openstack.org/470413 | 19:33 |
*** dimtruck is now known as zz_dimtruck | 19:34 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/469581 | 19:34 |
cfriesen_ | now I need to go make "online_data_migrations" work with our customizations to Newton | 19:34 |
*** brault has joined #openstack-nova | 19:36 | |
cfriesen_ | and I resolve to stay away from api_sample_tests as much as possible | 19:37 |
*** brault has quit IRC | 19:40 | |
mriedem | huh i thought we were going to start running nova-api under uwsgi in the gate | 19:41 |
mriedem | aha https://review.openstack.org/#/c/457715/ | 19:41 |
*** hongbin has joined #openstack-nova | 19:43 | |
*** pwiltsey has left #openstack-nova | 19:44 | |
openstackgerrit | Kaitlin Farr proposed openstack/nova master: Remove deprecated keymgr code https://review.openstack.org/439855 | 19:48 |
*** vladikr has quit IRC | 19:50 | |
*** mingyu has quit IRC | 19:52 | |
*** mingyu has joined #openstack-nova | 19:53 | |
openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Document Pike release review priorities https://review.openstack.org/470420 | 19:54 |
*** zz_dimtruck is now known as dimtruck | 19:54 | |
mriedem | dansmith: leakypipes: ^ | 19:54 |
mriedem | long time coming but finally got the review priorities for pike documented | 19:54 |
*** wasmum has joined #openstack-nova | 19:55 | |
*** eharney has quit IRC | 19:56 | |
*** mingyu has quit IRC | 19:57 | |
*** NostawRm has quit IRC | 19:59 | |
*** raunak has joined #openstack-nova | 19:59 | |
*** wasmum has quit IRC | 20:03 | |
*** harlowja has joined #openstack-nova | 20:04 | |
leakypipes | mriedem: reviewed. | 20:04 |
mriedem | oh right | 20:07 |
openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Document Pike release review priorities https://review.openstack.org/470420 | 20:09 |
*** marst has quit IRC | 20:10 | |
*** marst has joined #openstack-nova | 20:10 | |
*** eharney has joined #openstack-nova | 20:11 | |
*** rcernin has joined #openstack-nova | 20:12 | |
*** wasmum has joined #openstack-nova | 20:14 | |
*** artom has quit IRC | 20:18 | |
*** artom has joined #openstack-nova | 20:18 | |
*** yamamoto has joined #openstack-nova | 20:20 | |
*** mvensky has joined #openstack-nova | 20:23 | |
*** dtp has quit IRC | 20:25 | |
*** yamamoto has quit IRC | 20:26 | |
*** Apoorva_ has quit IRC | 20:26 | |
*** Apoorva has joined #openstack-nova | 20:27 | |
openstackgerrit | Merged openstack/nova master: show flavor info in server details https://review.openstack.org/434514 | 20:28 |
openstackgerrit | Merged openstack/nova master: Add database migration and model for consumers https://review.openstack.org/469633 | 20:29 |
*** claudiub has joined #openstack-nova | 20:34 | |
*** slaweq has joined #openstack-nova | 20:35 | |
*** tidwellr has joined #openstack-nova | 20:35 | |
*** raunak has quit IRC | 20:37 | |
openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Cap sphinx<1.6.1 https://review.openstack.org/470434 | 20:39 |
*** fragatina has joined #openstack-nova | 20:39 | |
*** pchavva has quit IRC | 20:39 | |
*** gouthamr has quit IRC | 20:41 | |
*** slaweq has quit IRC | 20:42 | |
*** nicolasbock has quit IRC | 20:43 | |
*** lucasxu has quit IRC | 20:45 | |
*** fragatina has quit IRC | 20:45 | |
*** jwnx has quit IRC | 20:45 | |
*** egonzalez has joined #openstack-nova | 20:45 | |
*** awaugama has quit IRC | 20:46 | |
*** lucasxu has joined #openstack-nova | 20:47 | |
*** lucasxu has quit IRC | 20:48 | |
*** lucasxu has joined #openstack-nova | 20:48 | |
*** READ10 has joined #openstack-nova | 20:48 | |
*** lucasxu has quit IRC | 20:49 | |
*** burt has quit IRC | 20:50 | |
*** burt has joined #openstack-nova | 20:51 | |
*** dimtruck is now known as zz_dimtruck | 20:54 | |
*** zz_dimtruck is now known as dimtruck | 20:55 | |
*** winston-d_ has quit IRC | 20:55 | |
*** jmlowe has quit IRC | 20:57 | |
*** salv-orlando has joined #openstack-nova | 20:58 | |
*** karimb has joined #openstack-nova | 20:59 | |
*** gouthamr has joined #openstack-nova | 20:59 | |
*** kaisers1 has quit IRC | 21:07 | |
*** thorst has quit IRC | 21:11 | |
*** thorst has joined #openstack-nova | 21:15 | |
*** eharney has quit IRC | 21:15 | |
*** slaweq has joined #openstack-nova | 21:18 | |
cfriesen_ | can someone suggest why gate-python-novaclient-releasenotes is failing for https://review.openstack.org/#/c/435141 ? | 21:18 |
*** thorst has quit IRC | 21:19 | |
openstackgerrit | Kaitlin Farr proposed openstack/nova master: Remove deprecated keymgr code https://review.openstack.org/439855 | 21:20 |
*** felipemonteiro__ has quit IRC | 21:21 | |
*** yamamoto has joined #openstack-nova | 21:22 | |
openstackgerrit | Merged openstack/nova-specs master: Cap sphinx<1.6.1 https://review.openstack.org/470434 | 21:22 |
*** lbragstad has quit IRC | 21:22 | |
*** slaweq has quit IRC | 21:23 | |
openstackgerrit | Chris Friesen proposed openstack/python-novaclient master: 2.47: Show flavor info in server details https://review.openstack.org/435141 | 21:24 |
*** mtanino has joined #openstack-nova | 21:25 | |
clarkb | cfriesen_: https://review.openstack.org/#/c/469881/ something like that needed in novaclient? | 21:26 |
*** mnestratov|2 has joined #openstack-nova | 21:27 | |
cfriesen_ | clarkb: already had that formatting style | 21:27 |
*** yamamoto has quit IRC | 21:27 | |
clarkb | cfriesen_: in your chnge yes, but I think new relaese of releasenotes is more strict so old things elsewhere may be unhappy | 21:28 |
cfriesen_ | I'm wondering if maybe it was related to the sphinx change above | 21:28 |
*** kfarr has quit IRC | 21:28 | |
clarkb | notes/remove-deprecated-option-in-3.3.0-82a413157838570d.yaml is the file it is mad about | 21:28 |
clarkb | which doesn't use > or | | 21:28 |
cfriesen_ | ah, right | 21:29 |
clarkb | I think the problem is that that file is treated as entirely yaml rather than being yaml with rst strings in it and reno is emitting a warning which is treated as an error | 21:30 |
clarkb | also update doesn't appear to be a valid directive which may be the underlying issue | 21:31 |
clarkb | https://docs.openstack.org/developer/reno/usage.html | 21:32 |
cfriesen_ | yeah, was just looking at that | 21:32 |
cfriesen_ | maybe it was supposed to be upgrade? | 21:32 |
*** tidwellr has quit IRC | 21:32 | |
clarkb | that would be my guess | 21:33 |
clarkb | beacuse in upgrade you can list things | 21:33 |
cfriesen_ | I can try fixing it up | 21:33 |
*** MVenesio has quit IRC | 21:39 | |
*** thorst has joined #openstack-nova | 21:39 | |
*** mvensky has quit IRC | 21:40 | |
*** dimtruck is now known as zz_dimtruck | 21:41 | |
*** ckopper has quit IRC | 21:45 | |
openstackgerrit | Chris Friesen proposed openstack/python-novaclient master: Fix up release note https://review.openstack.org/470446 | 21:45 |
*** mdrabe has quit IRC | 21:47 | |
*** zz_dimtruck is now known as dimtruck | 21:50 | |
*** salv-orlando has quit IRC | 21:52 | |
*** thorst has quit IRC | 21:58 | |
*** fragatina has joined #openstack-nova | 21:59 | |
*** pwiltsey_ has joined #openstack-nova | 22:01 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/470474 | 22:02 |
*** READ10 has quit IRC | 22:02 | |
*** edmondsw has quit IRC | 22:03 | |
*** pwiltsey_ has quit IRC | 22:03 | |
*** kaisers has joined #openstack-nova | 22:04 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/467173 | 22:04 |
*** burt has quit IRC | 22:05 | |
clarkb | cfriesen_: that got the error to change :) I think you need to do something like upgrade:\n - |\n notes there | 22:06 |
*** pwiltsey has joined #openstack-nova | 22:06 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/469581 | 22:07 |
*** rfolco has quit IRC | 22:09 | |
*** pwiltsey has quit IRC | 22:11 | |
*** fragatina has quit IRC | 22:11 | |
cfriesen_ | clarkb: respinning | 22:12 |
openstackgerrit | Chris Friesen proposed openstack/python-novaclient master: Fix up release note https://review.openstack.org/470446 | 22:13 |
*** nic has quit IRC | 22:15 | |
*** arahal__ has quit IRC | 22:15 | |
*** dimtruck is now known as zz_dimtruck | 22:16 | |
*** nic has joined #openstack-nova | 22:17 | |
*** lbragstad has joined #openstack-nova | 22:18 | |
*** zz_dimtruck is now known as dimtruck | 22:22 | |
*** yamamoto has joined #openstack-nova | 22:24 | |
*** Swami has quit IRC | 22:24 | |
*** nic has quit IRC | 22:28 | |
*** yamamoto has quit IRC | 22:29 | |
*** belliott_ has joined #openstack-nova | 22:31 | |
*** lyarwood_ has joined #openstack-nova | 22:31 | |
*** raorn_ has joined #openstack-nova | 22:32 | |
*** toan has joined #openstack-nova | 22:33 | |
*** tbachman has quit IRC | 22:34 | |
*** andreaf has quit IRC | 22:35 | |
*** rcernin has quit IRC | 22:39 | |
*** ejat is now known as fenris | 22:39 | |
*** fenris is now known as ejat | 22:39 | |
*** belliott has quit IRC | 22:40 | |
*** raorn has quit IRC | 22:40 | |
*** andreaf has joined #openstack-nova | 22:40 | |
*** hwoarang has quit IRC | 22:40 | |
*** Hazelesque has quit IRC | 22:40 | |
*** gouthamr has quit IRC | 22:40 | |
*** saneax has quit IRC | 22:40 | |
*** Hazelesque_ has joined #openstack-nova | 22:40 | |
*** melwitt_ has joined #openstack-nova | 22:40 | |
*** hwoarang has joined #openstack-nova | 22:40 | |
*** toanster has quit IRC | 22:40 | |
*** melwitt has quit IRC | 22:40 | |
*** lyarwood has quit IRC | 22:40 | |
*** saneax has joined #openstack-nova | 22:41 | |
*** ckopper has joined #openstack-nova | 22:42 | |
*** gouthamr has joined #openstack-nova | 22:42 | |
*** mtreinish has quit IRC | 22:42 | |
*** alextricity25 has quit IRC | 22:42 | |
*** figleaf is now known as edleafe | 22:43 | |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 22:43 |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215 | 22:43 |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: integrate ProviderTree to report client https://review.openstack.org/415921 | 22:43 |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: adds ProviderTree for nested resources https://review.openstack.org/415920 | 22:43 |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 22:43 |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138 | 22:43 |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: set/check if inventory change in tree https://review.openstack.org/470575 | 22:43 |
*** sfinucan has quit IRC | 22:43 | |
*** ckopper has quit IRC | 22:45 | |
*** alextricity25 has joined #openstack-nova | 22:45 | |
*** Hazelesque_ is now known as Hazelesque | 22:45 | |
*** sfinucan has joined #openstack-nova | 22:46 | |
*** mvk has quit IRC | 22:47 | |
*** mtreinish has joined #openstack-nova | 22:47 | |
*** jwcroppe has joined #openstack-nova | 22:47 | |
*** thorst has joined #openstack-nova | 22:49 | |
*** thorst has quit IRC | 22:49 | |
*** melwitt_ is now known as melwitt | 22:49 | |
*** MasterOfBugs has quit IRC | 22:50 | |
*** ckopper has joined #openstack-nova | 22:52 | |
*** marst_ has joined #openstack-nova | 22:52 | |
*** mingyu has joined #openstack-nova | 22:54 | |
*** thorst has joined #openstack-nova | 22:55 | |
*** marst has quit IRC | 22:56 | |
*** mingyu has quit IRC | 22:57 | |
*** esberglu has quit IRC | 22:59 | |
*** mvk has joined #openstack-nova | 22:59 | |
*** esberglu has joined #openstack-nova | 23:00 | |
*** marst_ has quit IRC | 23:00 | |
*** kbaegis has quit IRC | 23:01 | |
*** esberglu has quit IRC | 23:04 | |
*** lyan has quit IRC | 23:10 | |
*** leakypipes has quit IRC | 23:10 | |
*** edmondsw has joined #openstack-nova | 23:11 | |
*** thorst has quit IRC | 23:14 | |
*** xyang1 has quit IRC | 23:14 | |
openstackgerrit | melanie witt proposed openstack/nova master: Add functional test for local delete allocations https://review.openstack.org/470578 | 23:15 |
*** vladikr has joined #openstack-nova | 23:16 | |
*** edmondsw has quit IRC | 23:16 | |
*** kbaegis has joined #openstack-nova | 23:21 | |
*** dimtruck is now known as zz_dimtruck | 23:23 | |
*** mnestratov|2 has quit IRC | 23:24 | |
*** yamamoto has joined #openstack-nova | 23:26 | |
openstackgerrit | guang-yee proposed openstack/nova master: libvirt: Reconnect volumes and encryptors during a hard reboot https://review.openstack.org/400384 | 23:29 |
*** yamamoto has quit IRC | 23:31 | |
*** claudiub has quit IRC | 23:49 | |
lbragstad | mriedem: thanks for the reviews on https://review.openstack.org/#/c/469954/5 | 23:49 |
lbragstad | mriedem: let me know if i've made the wording better or worse | 23:50 |
*** brault has joined #openstack-nova | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!