Friday, 2017-06-02

openstackgerritJohn Griffith proposed openstack/nova master: WIP/POC Implement new attach Cinder flow  https://review.openstack.org/33028500:03
*** pramodrj07 has quit IRC00:06
*** yamamoto_ has joined #openstack-nova00:14
openstackgerritArtom Lifshitz proposed openstack/python-novaclient master: Error out if nic auto or none are not alone  https://review.openstack.org/47000000:17
*** Yangyapeng has quit IRC00:17
mriedemmelwitt: yeah i wanted cfriesen_ to review that first00:25
*** acormier has joined #openstack-nova00:25
mriedemi guess i can gander while i'm on a call tonight00:27
mriedema welcome distraction00:27
openstackgerritguang-yee proposed openstack/nova master: libvirt: Reconnect volumes and encryptors during a hard reboot  https://review.openstack.org/40038400:29
*** gyee has quit IRC00:30
*** Shunli has joined #openstack-nova00:30
melwittheh00:33
*** dikonoor has joined #openstack-nova00:37
*** zsli_ has joined #openstack-nova00:37
*** zsli__ has joined #openstack-nova00:39
*** Shunli has quit IRC00:41
openstackgerritArtom Lifshitz proposed openstack/python-novaclient master: Better handle key=value pair not being key=value  https://review.openstack.org/46998800:41
*** Shunli has joined #openstack-nova00:41
*** zsli_ has quit IRC00:43
*** zsli__ has quit IRC00:43
*** jamielennox is now known as jamielennox|away00:44
*** salv-orlando has joined #openstack-nova00:45
*** tovin07_ has joined #openstack-nova00:48
*** Hosam has quit IRC00:52
*** tbachman has quit IRC00:53
*** Hosam has joined #openstack-nova00:53
*** salv-orlando has quit IRC00:54
*** awaugama has quit IRC00:56
*** Hosam has quit IRC00:57
*** Hosam has joined #openstack-nova00:57
mriedemmelwitt: reviewed https://review.openstack.org/#/c/379524/ but i clearly don't understand how this works, or weighers for that matter00:59
melwittmriedem: oh, sorry about that :(01:00
*** takashin has joined #openstack-nova01:01
*** tbachman has joined #openstack-nova01:01
melwittyou're right that the weigher wants to favor hosts with fewer free PCI devices, packing like you said. it intends to leave room for possible future requests that actually need several devices at the same time01:02
*** shaner has quit IRC01:02
melwitt*several devices on the same host01:02
cfriesen_mriedem: you had suggested a functional test with non-empty extra-specs.  I think that means adding extra-specs to one of the flavors used in the functional tests, no?01:05
*** nic has quit IRC01:05
*** Hosam has quit IRC01:06
*** Hosam has joined #openstack-nova01:07
*** shaner has joined #openstack-nova01:07
*** phuongnh has joined #openstack-nova01:07
mriedemcfriesen_: or just create a new flavor for the test01:11
openstackgerritMerged openstack/nova master: Updated from global requirements  https://review.openstack.org/47003701:11
cfriesen_mriedem: yeah, was just looking at that01:11
*** thorst has joined #openstack-nova01:11
*** shaner has quit IRC01:11
*** shaner has joined #openstack-nova01:12
cfriesen_mriedem: is there a way to make a new flavor without needing to add new template files?01:17
mriedemcfriesen_: yeah there is an api client used in the non-api sample functional tests01:17
mriedemcfriesen_: something like this https://github.com/openstack/nova/blob/master/nova/tests/functional/integrated_helpers.py#L171 ?01:18
melwittyou can checkout this badass functional test I wrote for an example https://review.openstack.org/#/c/355091/8/nova/tests/functional/test_boot_from_volume.py@5401:18
mriedemcfriesen_: the api sample tests use that mixin i think https://github.com/openstack/nova/blob/master/nova/tests/functional/api_samples_test_base.py#L6901:19
mriedemyeah, so you can re-use that method01:19
mriedemto create a new flavor with what you need in it01:19
mriedemeven extra specs01:19
*** Yangyapeng has joined #openstack-nova01:20
mriedemalthough...the flavor ref is in the api sample request,01:20
mriedemso things might get weird with subs01:20
*** rajathagasthya has quit IRC01:20
cfriesen_I'll play with it, I guess01:20
*** Hosam has quit IRC01:21
*** rajathagasthya has joined #openstack-nova01:21
mriedemor modify that helper method to allow passing in a flavorid you define, which is some hard-coded uuid in your tests01:21
mriedemand put that flavorid in the request samples01:21
mriedemsomething like that01:21
cfriesen_realistically it would probably make sense for one of the default flavors to have extra specs just to test other code paths01:22
mriedemthing is you'd have to delete the flavor between test cases, or add a check to make sure you don't try to create it if it already exists01:22
mriedemyeah maybe, there is a flavor fixture01:22
mriedemhttps://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L61901:23
mriedemthrow a new default flavor in that fixture maybe01:23
cfriesen_but I'm sure changing the fixtures would have wide ranging effects01:23
mriedemnote that could throw off other tests though01:23
mriedemmaybe01:23
mriedemmaybe do that in a separate change to see how big the change is01:23
mriedemand then if it's not that bad, you do that separately, and then rebase your change on top of it to use that new flavor01:24
cfriesen_yeah, that'd be cleanest if it's not crazy01:24
*** Hosam has joined #openstack-nova01:25
*** Apoorva_ has joined #openstack-nova01:27
*** Yangyapeng has quit IRC01:30
openstackgerritChris Friesen proposed openstack/nova master: add extra_specs to one flavor in test fixtures  https://review.openstack.org/47007601:30
*** Apoorva has quit IRC01:30
*** vladik has joined #openstack-nova01:31
*** Apoorva_ has quit IRC01:31
*** tuanluong has joined #openstack-nova01:31
*** vladik has quit IRC01:31
openstackgerritTakashi NATSUME proposed openstack/nova-specs master: Blacklist sphinx 1.6.1 and later  https://review.openstack.org/47007701:32
*** johnhaan has joined #openstack-nova01:34
*** Hosam has quit IRC01:35
*** Hosam has joined #openstack-nova01:35
*** Yangyapeng has joined #openstack-nova01:35
openstackgerritTakashi NATSUME proposed openstack/nova-specs master: Blacklist sphinx 1.6.1 and later  https://review.openstack.org/47007701:38
*** hongbin has joined #openstack-nova01:40
*** Hosam has quit IRC01:49
*** Hosam has joined #openstack-nova01:50
*** huanxie has joined #openstack-nova01:50
*** gomarivera has joined #openstack-nova01:51
*** kaisers_ has joined #openstack-nova01:51
*** kaisers has quit IRC01:55
cfriesen_I tried creating some extra-specs in api_sample_tests/test_servers.py and got a 403 response.  I'm guessing the tests are not run as an admin user?01:56
cfriesen_looks like it, I added "ADMIN_API = True" and now I can do it01:57
melwittyeah, you need something like "self.admin_api = self.api_fixture.admin_api" in setUp()01:58
*** arunmani_ has joined #openstack-nova01:58
melwittcfriesen_: I dunno if you saw my earlier link to a test that creates flavors, to use as an example. it might help https://review.openstack.org/#/c/355091/8/nova/tests/functional/test_boot_from_volume.py02:00
*** jamielennox|away is now known as jamielennox02:00
*** jwnx has joined #openstack-nova02:01
*** thorst has quit IRC02:02
*** Hosam has quit IRC02:03
*** Hosam has joined #openstack-nova02:04
cfriesen_melwitt: can you mix the integrated_helpers stuff with the api samples tests though?02:05
cfriesen_melwitt: I've got the flavor extra spec creation working, now just trying to fix up the template matching02:05
melwittcfriesen_: oh, I didn't realize you were working on a api sample test. maybe not, I'm not sure02:09
melwittsounds like you're through the woods already anyway02:09
*** rajathagasthya has quit IRC02:10
cfriesen_melwitt: I think so.  it'd be nicer if the template/result comparison gave an error messsage better than "Failed to match Template to Response: Values do not match:"02:10
melwittyeah. I've worked on api samples a few times and it was frustrating02:11
mriedemcfriesen_: if you're creating a new flavor with a dynamic id/name each time then i think the api samples are going to be hard02:12
mriedemb/c the nova/doc/api_samples have to have something hard-coded for the actual api-ref docs02:12
mriedemthey can't have like %(uuid)s02:12
cfriesen_mriedem: I'm just adding extra-specs to flavor 102:12
melwittif he's doing a new test he'll have new json that he can add the {uuid} matcher thing to, right?02:12
*** tbachman has quit IRC02:13
melwittoh02:13
cfriesen_or is that going to mess up other tests?02:13
cfriesen_If I have to make a new flavor I can do that, I think we can hardcode the flavor id02:14
cfriesen_all this just to put some extra-specs in the api sample02:15
*** hieulq_ has joined #openstack-nova02:15
*** xinliang has quit IRC02:15
melwittapi samples, you just don't touch em02:15
melwittback away slowly02:16
cfriesen_it's all mriedem's fault02:16
melwittheh02:16
cfriesen_hmm...adding extra-specs to one of the default flavors really didn't break much at all: https://review.openstack.org/#/c/470076/102:17
*** Hosam has quit IRC02:17
cfriesen_wonder if that's actually enough to use in functional tests02:18
*** Hosam has joined #openstack-nova02:18
mriedemcfriesen_: i think that's your easiest bet02:19
mriedemis modify an existing default flavor or add a new one with extra spec02:19
mriedemthen you can hard-code that flavor id into your samples02:19
cfriesen_I think that'll actually work02:20
* mriedem goes back to learning about constellations https://review.openstack.org/#/c/453262/02:21
melwittfirst I've heard of that02:22
*** links has joined #openstack-nova02:22
melwitt"constellations"02:22
mriedembuckle up02:23
melwittheh02:24
melwittyeah, reading some of the comments. got sucked in02:24
mriedemyour boss is in there02:25
mriedembossing it up02:25
melwittI see that :)02:25
*** hieulq_ has quit IRC02:25
*** xinliang has joined #openstack-nova02:27
*** thorst has joined #openstack-nova02:29
*** gomarivera has quit IRC02:29
*** thorst has quit IRC02:30
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements  https://review.openstack.org/47011902:32
*** faizy has quit IRC02:33
*** faizy has joined #openstack-nova02:34
openstackgerritOpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements  https://review.openstack.org/46717302:34
*** tbachman has joined #openstack-nova02:36
*** Hosam has quit IRC02:36
*** Hosam has joined #openstack-nova02:37
*** jichen has joined #openstack-nova02:39
*** mriedem has quit IRC02:40
*** thorst has joined #openstack-nova02:41
*** thorst has quit IRC02:41
*** jichen_ has joined #openstack-nova02:44
openstackgerritChris Friesen proposed openstack/nova master: add new test fixture flavor with extra_specs  https://review.openstack.org/47007602:44
*** jichen has quit IRC02:46
*** jichen_ is now known as jichen02:46
*** salv-orlando has joined #openstack-nova02:50
*** thorst has joined #openstack-nova02:51
*** thorst has quit IRC02:51
cfriesen_when running functional tests is it possible to get debug logs emitted to somewhere?  I'm getting a 400 status when I try to create a new server and I can't tell why02:58
*** Hosam has quit IRC03:00
*** edmondsw has joined #openstack-nova03:00
*** Hosam has joined #openstack-nova03:00
*** arunmani_ has quit IRC03:01
*** salv-orlando has quit IRC03:02
*** edmondsw has quit IRC03:04
*** fragatina has quit IRC03:05
*** fragatina has joined #openstack-nova03:05
*** karthiks has joined #openstack-nova03:09
*** winston-d_ has joined #openstack-nova03:12
*** cNilesh has joined #openstack-nova03:15
*** vks1 has joined #openstack-nova03:16
*** acormier has quit IRC03:18
*** Hosam has quit IRC03:19
*** Hosam has joined #openstack-nova03:19
*** vladikr has quit IRC03:22
*** thorst has joined #openstack-nova03:22
*** penick has quit IRC03:23
*** jamielennox is now known as jamielennox|away03:30
*** hongbin has quit IRC03:39
*** thorst has quit IRC03:40
*** armax has quit IRC03:41
*** armax has joined #openstack-nova03:45
*** psachin has joined #openstack-nova03:45
*** faizy_ has joined #openstack-nova03:47
*** Hosam has quit IRC03:47
openstackgerritMerged openstack/nova master: Add test ensure all the microversions are sequential in placement API  https://review.openstack.org/45804903:47
*** nicolasbock has quit IRC03:48
*** Hosam has joined #openstack-nova03:48
*** arunmani_ has joined #openstack-nova03:50
*** arunmani_ has quit IRC03:50
*** faizy has quit IRC03:51
*** sree has joined #openstack-nova03:55
*** armax has quit IRC04:00
melwittcfriesen_: run with OS_DEBUG = 1 tox ...04:01
melwittOS_DEBUG=1 tox ...04:05
*** faizy_ has quit IRC04:06
*** faizy has joined #openstack-nova04:07
*** tbachman has quit IRC04:09
*** hieulq_ has joined #openstack-nova04:09
*** hieulq_ has quit IRC04:09
*** jowisz_ has quit IRC04:09
cfriesen_melwitt: thanks, that's helpful04:12
*** Hosam has quit IRC04:15
*** Hosam has joined #openstack-nova04:16
*** jowisz has joined #openstack-nova04:22
*** salv-orlando has joined #openstack-nova04:25
*** Hosam has quit IRC04:30
*** Hosam has joined #openstack-nova04:30
*** mlakat has quit IRC04:31
*** salv-orlando has quit IRC04:37
*** thorst has joined #openstack-nova04:37
*** mlakat has joined #openstack-nova04:38
*** Hosam has quit IRC04:39
*** Hosam has joined #openstack-nova04:40
*** mdnadeem has joined #openstack-nova04:40
*** jaosorior has joined #openstack-nova04:41
*** thorst has quit IRC04:42
*** slaweq has joined #openstack-nova04:42
*** slaweq has quit IRC04:43
openstackgerritChris Friesen proposed openstack/nova master: add new test fixture flavor with extra_specs  https://review.openstack.org/47007604:43
*** yamamoto_ has quit IRC04:46
*** kornicameister has joined #openstack-nova04:50
openstackgerritmelanie witt proposed openstack/nova master: Add database migration and model for consumers  https://review.openstack.org/46963304:51
openstackgerritmelanie witt proposed openstack/nova master: Add project_id and user_id to PUT /allocations  https://review.openstack.org/46963404:51
openstackgerritmelanie witt proposed openstack/nova master: Add GET /usages to placement API  https://review.openstack.org/46963504:51
*** ltomasbo|away is now known as ltomasbo04:53
*** Hosam has quit IRC04:53
*** Hosam has joined #openstack-nova04:54
*** claudiub has joined #openstack-nova05:09
*** trinaths has joined #openstack-nova05:11
*** tovin07_ has quit IRC05:11
*** gouthamr has quit IRC05:15
*** udesale has joined #openstack-nova05:17
*** Hosam has quit IRC05:17
*** Hosam has joined #openstack-nova05:17
*** arahal_ has joined #openstack-nova05:21
*** prateek has joined #openstack-nova05:23
*** rcernin has joined #openstack-nova05:26
*** arahal_ has quit IRC05:27
*** markvoelker_ has joined #openstack-nova05:27
*** trinaths has left #openstack-nova05:27
*** markvoelker has quit IRC05:28
*** mmedvede has quit IRC05:28
*** mmedvede has joined #openstack-nova05:31
*** arunman has joined #openstack-nova05:32
*** yamamoto_ has joined #openstack-nova05:32
*** salv-orlando has joined #openstack-nova05:33
*** sridharg has joined #openstack-nova05:34
*** fandi has joined #openstack-nova05:37
*** fandi has quit IRC05:37
*** fandi has joined #openstack-nova05:37
*** thorst has joined #openstack-nova05:38
*** Hosam has quit IRC05:41
*** Hosam has joined #openstack-nova05:41
*** thorst has quit IRC05:43
*** ratailor has joined #openstack-nova05:48
*** litao__ has joined #openstack-nova05:50
openstackgerritHironori Shiina proposed openstack/nova master: Ironic: Support boot from Cinder volume  https://review.openstack.org/21538505:54
openstackgerritHuan Xie proposed openstack/nova master: XenAPI: use os-xenapi 0.2.0 in nova  https://review.openstack.org/45349305:57
*** Hosam has quit IRC06:00
*** jwnx has quit IRC06:00
*** Hosam has joined #openstack-nova06:00
*** takashin has left #openstack-nova06:00
*** Hosam has quit IRC06:04
*** Hosam has joined #openstack-nova06:05
*** markus_z has joined #openstack-nova06:10
openstackgerritChris Friesen proposed openstack/nova master: show flavor info in server details  https://review.openstack.org/43451406:10
*** Oku_OS-away is now known as Oku_OS06:11
openstackgerritChris Friesen proposed openstack/nova master: show flavor info in server details  https://review.openstack.org/43451406:12
*** kaisers_ has quit IRC06:13
*** kaisers has joined #openstack-nova06:13
*** Swami has joined #openstack-nova06:15
*** gjayavelu has joined #openstack-nova06:15
openstackgerritjichenjc proposed openstack/nova master: propagate OSError to MigrationPreCheckError  https://review.openstack.org/46977906:19
*** trinaths1 has joined #openstack-nova06:21
*** Hosam has quit IRC06:23
*** Hosam has joined #openstack-nova06:24
*** dikonoor has quit IRC06:25
*** dikonoor has joined #openstack-nova06:25
*** phuongnh has quit IRC06:27
*** phuongnh has joined #openstack-nova06:28
*** Swami has quit IRC06:32
*** udesale__ has joined #openstack-nova06:32
openstackgerritZhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4)  https://review.openstack.org/46980006:33
*** crushil has quit IRC06:34
*** udesale has quit IRC06:34
*** salv-orlando has quit IRC06:35
*** edmondsw has joined #openstack-nova06:36
*** edmondsw has quit IRC06:41
*** Hosam has quit IRC06:42
*** Hosam has joined #openstack-nova06:43
*** cfriesen_ has quit IRC06:44
*** ralonsoh has joined #openstack-nova06:45
openstackgerritZhenyu Zheng proposed openstack/nova master: Use plain routes list for os-consoles, os-console-auth-tokens endpoint instead of stevedore  https://review.openstack.org/46217506:53
*** mnestratov|2 has joined #openstack-nova06:53
*** Hosam has quit IRC06:56
*** Hosam has joined #openstack-nova06:57
*** fandi has quit IRC07:01
*** murugesh has joined #openstack-nova07:03
*** tesseract has joined #openstack-nova07:04
*** Hosam has quit IRC07:10
*** Hosam has joined #openstack-nova07:11
*** sridharg has quit IRC07:12
*** udesale has joined #openstack-nova07:20
*** gszasz has joined #openstack-nova07:21
*** udesale__ has quit IRC07:21
*** sridharg has joined #openstack-nova07:25
openstackgerritZhenyu Zheng proposed openstack/nova master: Use plain routes list for block_device_mapping instead of stevedore  https://review.openstack.org/46218007:26
*** sridhargaddam has joined #openstack-nova07:27
*** dikonoor has quit IRC07:28
*** hferenc has joined #openstack-nova07:29
*** sridharg has quit IRC07:30
*** sridhargaddam has quit IRC07:33
*** sridharg has joined #openstack-nova07:33
*** jpena|off is now known as jpena07:34
*** Hosam has quit IRC07:39
*** thorst has joined #openstack-nova07:39
*** Hosam has joined #openstack-nova07:40
openstackgerritFelix Ma proposed openstack/nova master: Handle bdm save failure in attach  https://review.openstack.org/47018107:40
*** thorst has quit IRC07:44
*** lpetrut has joined #openstack-nova07:48
*** Hosam has quit IRC07:48
*** Hosam has joined #openstack-nova07:49
openstackgerritMichael  Henkel proposed openstack/nova master: contrail: add vrouter VIF plugin type support  https://review.openstack.org/44118307:50
openstackgerritMichael  Henkel proposed openstack/nova master: contrail: add vrouter VIF plugin type support  https://review.openstack.org/44118307:51
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-nova08:01
*** Hosam has quit IRC08:03
*** Hosam has joined #openstack-nova08:03
*** phuongnh has quit IRC08:07
*** phuongnh has joined #openstack-nova08:07
*** faizy has quit IRC08:08
*** sree has quit IRC08:08
*** sree has joined #openstack-nova08:09
*** faizy has joined #openstack-nova08:10
*** sridharg has quit IRC08:12
*** faizy has quit IRC08:12
*** sridharg has joined #openstack-nova08:12
*** faizy has joined #openstack-nova08:13
*** sree has quit IRC08:13
*** liuqing has quit IRC08:14
*** liuqing has joined #openstack-nova08:15
*** tiendc has joined #openstack-nova08:17
*** sree has joined #openstack-nova08:17
*** Hosam has quit IRC08:17
*** hshiina has joined #openstack-nova08:17
*** Hosam has joined #openstack-nova08:17
*** lucas-afk is now known as lucasagomes08:18
*** jamielennox|away is now known as jamielennox08:21
openstackgerritZhenyu Zheng proposed openstack/nova master: Use plain routes list for user_data instead of stevedore  https://review.openstack.org/46218308:27
*** dikonoor has joined #openstack-nova08:29
*** derekh has joined #openstack-nova08:35
*** thorst has joined #openstack-nova08:40
*** gjayavelu has quit IRC08:40
*** brault has joined #openstack-nova08:42
*** alexchadin has joined #openstack-nova08:46
openstackgerritZhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4)  https://review.openstack.org/45959308:47
*** jamielennox is now known as jamielennox|away08:49
*** cdent has joined #openstack-nova08:50
*** brault has quit IRC08:58
*** thorst has quit IRC08:59
*** hferenc has quit IRC09:01
*** brault has joined #openstack-nova09:02
*** hferenc has joined #openstack-nova09:02
*** Hosam has quit IRC09:04
*** gjayavelu has joined #openstack-nova09:05
*** Hosam has joined #openstack-nova09:05
*** dikonoor has quit IRC09:05
*** fragatina has quit IRC09:06
*** sambetts|afk is now known as sambetts09:06
*** fragatina has joined #openstack-nova09:06
*** gjayavelu has quit IRC09:08
cdentalex_xu: if you're still around, can you add a bit more detail on the scenario that would cause the duplicate problems in https://review.openstack.org/#/c/469578/ ? I had though that the combination of the local process lock, and the writer transaction would handle it? Are you concerned about the situation where there are different versions of the os-traits library on different machines?09:16
*** udesale__ has joined #openstack-nova09:19
*** faizy has quit IRC09:21
*** udesale has quit IRC09:22
*** sree has quit IRC09:30
*** sree has joined #openstack-nova09:31
*** Hosam has quit IRC09:32
*** Hosam has joined #openstack-nova09:33
*** jichen has quit IRC09:34
*** Shunli has quit IRC09:34
*** murugesh has quit IRC09:35
*** sree has quit IRC09:35
*** dikonoor has joined #openstack-nova09:36
openstackgerritsean mooney proposed openstack/os-vif master: set mtu on all code paths  https://review.openstack.org/46995109:38
alex_xucdent: I mean when multiple placement-api deployed on multiple nodes. When two users request to list traits, both of them will trigger the sync09:39
alex_xuonly one of them can sync successfully09:39
alex_xuthe transaction doesn't help that case I think09:39
cdentthat's the part i don't understand, why not?09:40
cdentI had thought the transaction would?09:40
cdentbut then I'm often confused by what actually happens with transactions09:40
alex_xuthe transcation only ensure the consistent view of the data, except you set the transaction isolation level to serializable09:42
cdentalex_xu: so, is the simplest solution to catch the duplicate error, log it, and move on?09:46
alex_xucdent: yea, I think so09:47
*** Hosam has quit IRC09:51
*** Hosam has joined #openstack-nova09:52
*** cNilesh has quit IRC09:54
*** cNilesh has joined #openstack-nova09:55
*** Hosam has quit IRC09:56
*** thorst has joined #openstack-nova09:56
*** tbachman has joined #openstack-nova09:58
*** aarefiev_afk is now known as aarefiev10:00
*** udesale has joined #openstack-nova10:00
*** Hosam has joined #openstack-nova10:01
*** thorst has quit IRC10:01
*** jaosorior is now known as jaosorior_lunch10:01
*** udesale__ has quit IRC10:02
*** cNilesh has quit IRC10:03
*** nicolasbock has joined #openstack-nova10:03
*** sree has joined #openstack-nova10:04
openstackgerritStephen Finucane proposed openstack/nova master: Add PCIWeigher  https://review.openstack.org/37952410:04
openstackgerritStephen Finucane proposed openstack/nova master: Prefer non-PCI host nodes for non-PCI instances  https://review.openstack.org/37962510:04
*** ericyoung has joined #openstack-nova10:07
*** lunarlamp has quit IRC10:08
*** sree has quit IRC10:08
*** Hosam has quit IRC10:10
*** Hosam has joined #openstack-nova10:11
*** mariusv has joined #openstack-nova10:11
openstackgerritClaudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages  https://review.openstack.org/44750510:12
*** lucasagomes has quit IRC10:13
*** salv-orlando has joined #openstack-nova10:20
*** litao__ has quit IRC10:21
*** yamamoto_ has quit IRC10:22
*** tbachman has quit IRC10:26
openstackgerritNidhiMittalHada proposed openstack/python-novaclient master: Reset-state's default parameter needs correction  https://review.openstack.org/46347710:27
*** Hosam has quit IRC10:29
*** Hosam has joined #openstack-nova10:30
*** tuanluong has quit IRC10:35
*** tbachman has joined #openstack-nova10:36
*** karthiks has quit IRC10:37
*** tiendc has quit IRC10:39
kashyapmriedem: When you're about, as someone who dabbles with libvirt / block layers sometimes, might want to look at this - https://review.openstack.org/#/c/465205/10:41
kashyapIt is ready to merge10:41
kashyapAnd, fairly straight-forward10:41
*** alexchadin has quit IRC10:41
*** ltomasbo is now known as ltomasbo|away10:42
*** Yangyapeng has quit IRC10:42
*** diga has joined #openstack-nova10:43
*** Hosam has quit IRC10:43
*** Hosam has joined #openstack-nova10:44
*** mariusv has quit IRC10:44
*** mariusv has joined #openstack-nova10:46
*** mingyu has joined #openstack-nova10:46
*** lucasagomes has joined #openstack-nova10:47
*** phuongnh has quit IRC10:49
openstackgerritNidhiMittalHada proposed openstack/python-novaclient master: client.logger.warning wrongly used in migrations  https://review.openstack.org/46350810:49
*** cdent has quit IRC10:49
*** tbachman has quit IRC10:51
*** cdent has joined #openstack-nova10:55
*** mingyu has quit IRC10:57
*** thorst has joined #openstack-nova10:57
*** mingyu_ has joined #openstack-nova10:58
*** mlakat has quit IRC11:01
openstackgerritNidhiMittalHada proposed openstack/python-novaclient master: Help message for aggregate-update is ambiguous  https://review.openstack.org/46975311:01
*** thorst has quit IRC11:02
*** dave-mccowan has joined #openstack-nova11:03
*** mingyu_ has quit IRC11:03
openstackgerritMichael Still proposed openstack/nova master: First attempt at adding a privsep user to nova.  https://review.openstack.org/45916611:03
*** lucasagomes is now known as lucas-hungry11:06
*** Hosam has quit IRC11:07
*** mingyu_ has joined #openstack-nova11:08
*** brault has quit IRC11:08
*** Hosam has joined #openstack-nova11:08
*** brault has joined #openstack-nova11:08
*** brault has quit IRC11:12
*** vladikr has joined #openstack-nova11:13
*** dikonoo has joined #openstack-nova11:13
*** mlakat has joined #openstack-nova11:14
*** coreywright has quit IRC11:14
openstackgerritDirk Mueller proposed openstack/nova-specs master: Fix citation references (Sphinx 1.6.x compatibility)  https://review.openstack.org/47025211:15
*** dikonoor has quit IRC11:16
*** edmondsw has joined #openstack-nova11:19
*** coreywright has joined #openstack-nova11:22
*** dklyle has quit IRC11:25
*** mingyu_ has quit IRC11:25
openstackgerritChris Dent proposed openstack/nova master: Fix ChanceScheduler returning a wrong node  https://review.openstack.org/46672511:27
*** fandi has joined #openstack-nova11:28
*** salv-orlando has quit IRC11:29
openstackgerritDirk Mueller proposed openstack/nova-specs master: Fix citation references (Sphinx 1.6.x compatibility)  https://review.openstack.org/47025211:31
*** david-lyle has joined #openstack-nova11:31
*** gcb has quit IRC11:34
*** brault has joined #openstack-nova11:34
*** gcb has joined #openstack-nova11:38
*** diga has quit IRC11:41
*** thorst has joined #openstack-nova11:41
*** gcb has quit IRC11:43
*** slaweq has joined #openstack-nova11:44
*** thorst has quit IRC11:45
*** nicolasbock has quit IRC11:46
*** jpena is now known as jpena|lunch11:47
*** yamamoto has joined #openstack-nova11:47
*** slaweq has quit IRC11:48
*** gcb has joined #openstack-nova11:52
bauzascdent: thanks for rebasing https://review.openstack.org/#/c/466725/11:53
*** tbachman has joined #openstack-nova11:54
*** udesale has quit IRC11:55
openstackgerritDirk Mueller proposed openstack/nova-specs master: Fix citation references (Sphinx 1.6.x compatibility)  https://review.openstack.org/47025211:56
*** Hosam_ has joined #openstack-nova11:56
*** nicolasbock has joined #openstack-nova11:56
*** Hosam has quit IRC11:59
*** rfolco has joined #openstack-nova12:01
*** thorst has joined #openstack-nova12:01
*** sree has joined #openstack-nova12:05
*** arunman has quit IRC12:05
*** liverpooler has joined #openstack-nova12:07
*** gszasz has quit IRC12:07
*** vks1 has quit IRC12:07
*** catintheroof has joined #openstack-nova12:08
openstackgerritDirk Mueller proposed openstack/nova-specs master: Fix citation references (Sphinx 1.6.x compatibility)  https://review.openstack.org/47025212:09
*** sree has quit IRC12:09
*** kfarr has joined #openstack-nova12:13
*** lucas-hungry is now known as lucasagomes12:23
*** Hosam_ has quit IRC12:23
*** mdnadeem has quit IRC12:25
openstackgerritClaudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages  https://review.openstack.org/44750512:28
*** baoli has joined #openstack-nova12:28
*** ratailor has quit IRC12:31
*** baoli has quit IRC12:31
*** baoli has joined #openstack-nova12:31
*** hferenc has quit IRC12:32
*** nicolasbock has quit IRC12:33
*** hferenc has joined #openstack-nova12:33
*** jwcroppe has quit IRC12:36
*** dpawlik has quit IRC12:39
*** annegentle has joined #openstack-nova12:41
*** mriedem has joined #openstack-nova12:43
*** yamamoto has quit IRC12:43
*** READ10 has joined #openstack-nova12:44
*** lyan has joined #openstack-nova12:47
mriedemsfinucan: kashyap: someone from your team (sahid?) should probably take a look at this libvirt realtime feature bug v12:47
mriedemhttps://bugs.launchpad.net/nova/+bug/169505612:47
openstackLaunchpad bug 1695056 in OpenStack Compute (nova) "libvirt realtime feature mlockall: Cannot allocate memory" [Undecided,New]12:47
*** jpena|lunch is now known as jpena12:47
* kashyap clicks12:48
*** liangy has joined #openstack-nova12:49
*** liangy has quit IRC12:49
*** yamamoto has joined #openstack-nova12:50
* kashyap nods; yeah, sounds like this should be looked at12:50
openstackgerritAlex Szarka proposed openstack/nova master: Add method for verify multiple versioned notifications  https://review.openstack.org/46552612:50
openstackgerritAlex Szarka proposed openstack/nova master: Add method for verify multiple versioned notifications  https://review.openstack.org/46552612:51
*** NostawRm has joined #openstack-nova12:51
*** crushil has joined #openstack-nova12:51
*** dillaman has quit IRC12:52
*** kylek3h has joined #openstack-nova12:52
*** jwcroppe has joined #openstack-nova12:54
*** tdurakov has quit IRC12:54
*** annegentle has quit IRC12:56
openstackgerritAlex Szarka proposed openstack/nova master: Transform instance.exists notification  https://review.openstack.org/40366012:58
*** yamamoto has quit IRC13:00
*** jaosorior_lunch is now known as jaosorior13:03
*** hshiina has quit IRC13:03
*** gcb has quit IRC13:04
*** dillaman has joined #openstack-nova13:05
*** edleafe is now known as figleaf13:06
openstackgerritAlex Szarka proposed openstack/nova master: Refactor instance-exists docstring and unit test  https://review.openstack.org/46273813:07
*** salv-orlando has joined #openstack-nova13:07
*** mdrabe has joined #openstack-nova13:10
*** trinaths1 has left #openstack-nova13:11
*** cfriesen_ has joined #openstack-nova13:12
openstackgerritEric Fried proposed openstack/nova master: Bump python-glanceclient minimum to 2.7.0  https://review.openstack.org/47028113:13
*** kaisers has quit IRC13:13
*** nicolasbock has joined #openstack-nova13:13
*** hferenc has quit IRC13:14
*** pchavva has joined #openstack-nova13:17
*** lucasxu has joined #openstack-nova13:20
openstackgerritMihail proposed openstack/nova master: proposed fix for bug 1646896 - System hangs when using NFS storage backend with loopback mounts, Closes-Bug: #1646896  https://review.openstack.org/42204113:21
openstackbug 1646896 in OpenStack Compute (nova) "System hangs when using NFS storage backend with loopback mounts" [Low,Confirmed] https://launchpad.net/bugs/164689613:21
*** tbachman has quit IRC13:21
openstackgerritChris Friesen proposed openstack/nova master: show flavor info in server details  https://review.openstack.org/43451413:23
*** dillaman has quit IRC13:23
*** Dinesh_Bhor has quit IRC13:24
*** sridharg has quit IRC13:25
*** psachin has quit IRC13:26
*** Hosam has joined #openstack-nova13:26
*** tbachman has joined #openstack-nova13:27
*** prateek has quit IRC13:27
*** salv-orl_ has joined #openstack-nova13:27
openstackgerritMatt Riedemann proposed openstack/nova master: Replace messaging.get_transport with get_rpc_transport  https://review.openstack.org/46965913:28
*** salv-orlando has quit IRC13:30
*** jwnx has joined #openstack-nova13:31
*** fandi has quit IRC13:34
*** links has quit IRC13:35
mriedemsfinucan: bauzas: one of you want to pull the +W on this libvirt volume driver change? https://review.openstack.org/#/c/256292/ it's pretty trivial13:38
*** arahal_ has joined #openstack-nova13:39
*** coreywright has quit IRC13:40
bauzasmriedem: ack, looking13:40
*** dillaman has joined #openstack-nova13:41
rfolcomriedem, would you please look at https://review.openstack.org/#/c/460231/ and https://review.openstack.org/#/c/460147/, both with one +2.13:41
mriedemrfolco: yeah i can in a bit13:42
rfolcomriedem, thx++13:42
*** hferenc has joined #openstack-nova13:43
mriedemlyarwood: for when you're off sabbatical, this is right up your encrypted volume alley https://bugs.launchpad.net/nova/+bug/143985513:43
openstackLaunchpad bug 1439855 in OpenStack Compute (nova) "encrypted iSCSI volume fails to attach, name too long" [Medium,Confirmed]13:43
openstackgerritMihail proposed openstack/nova master: proposed fix for bug 1646896 - System hangs when using NFS storage backend with loopback mounts, Closes-Bug: #1646896  https://review.openstack.org/42204113:44
openstackbug 1646896 in OpenStack Compute (nova) "System hangs when using NFS storage backend with loopback mounts" [Low,Confirmed] https://launchpad.net/bugs/164689613:44
*** felipemonteiro has joined #openstack-nova13:46
*** coreywright has joined #openstack-nova13:46
*** burt has joined #openstack-nova13:47
*** awaugama has joined #openstack-nova13:49
*** gomarivera has joined #openstack-nova13:50
*** gouthamr has joined #openstack-nova13:51
*** MVenesio has joined #openstack-nova13:51
*** felipemonteiro__ has joined #openstack-nova13:51
*** felipemonteiro has quit IRC13:55
*** kwathore has quit IRC13:57
openstackgerritMatt Riedemann proposed openstack/nova master: placement: Specific error for inventory in use  https://review.openstack.org/46023113:58
openstackgerritMihail proposed openstack/nova master: proposed fix for bug 1646896 - System hangs when using NFS storage backend with loopback mounts, Closes-Bug: #1646896  https://review.openstack.org/42204113:58
openstackbug 1646896 in OpenStack Compute (nova) "System hangs when using NFS storage backend with loopback mounts" [Low,Confirmed] https://launchpad.net/bugs/164689613:58
*** tidwellr has joined #openstack-nova14:00
bauzasmriedem: had a comment on https://review.openstack.org/#/c/256292/614:00
*** yamamoto has joined #openstack-nova14:01
bauzasmriedem: out of curiosity, do you know if Tooz driver is still a thing for our SG API or whether we should consider etcd ?14:02
*** arunman has joined #openstack-nova14:03
openstackgerritClaudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages  https://review.openstack.org/44750514:04
*** tbachman has quit IRC14:04
*** eharney has joined #openstack-nova14:05
*** yamamoto has quit IRC14:06
*** mlavalle has joined #openstack-nova14:07
mlavallemriedem: hey. I am looking at https://bugs.launchpad.net/nova/+bug/169441714:07
openstackLaunchpad bug 1694417 in OpenStack Compute (nova) "dhcp_domain used when use_neutron is not set" [Undecided,Incomplete]14:07
*** yamamoto has joined #openstack-nova14:07
claudiubmriedem: hi. i've found a nice pretty little bug. :) https://review.openstack.org/#/c/447505/13/nova/virt/libvirt/driver.py14:07
mlavallemriedem: seems that for the time being, we should wait for reply from the submitter14:08
sfinucanmriedem, melwitt: All ze comments in https://review.openstack.org/#/c/379524/ _should_ be addressed now, if you fancy taking a gander today14:09
sfinucanbauzas: RE: comments in https://review.openstack.org/#/c/256292/6/nova/virt/libvirt/volume/drbd.py14:09
sfinucaninstance is automatically exposed by oslo.log14:09
sfinucanby way of the default formatter14:10
bauzasmmmm okay14:10
*** ratailor has joined #openstack-nova14:10
melwittyeah, you can do that on any log message14:10
sfinucanat least, iirc. mriedem has suggested I do something similar a few times previously14:10
sfinucan*prior?14:10
*** tbachman has joined #openstack-nova14:12
claudiubmriedem: also, one question: the cinder 3rd party ci requirements state that "CI's do not need to kick off tests until Jenkin's has given a +1", is there a similar policy for nova as well? ( https://wiki.openstack.org/wiki/Cinder/tested-3rdParty-drivers#Third_Party_CI_Requirements )14:13
*** dikonoo has quit IRC14:14
*** mingyu has joined #openstack-nova14:14
*** baoli_ has joined #openstack-nova14:15
*** bhagyashris has left #openstack-nova14:15
*** READ10 has quit IRC14:15
*** sridharg has joined #openstack-nova14:15
*** sridharg has quit IRC14:16
*** smatzek has joined #openstack-nova14:16
*** smatzek_ has joined #openstack-nova14:17
*** rdo_ has quit IRC14:18
*** rdo_ has joined #openstack-nova14:18
*** baoli has quit IRC14:18
*** smatzek__ has joined #openstack-nova14:18
efriedclaudiub I have that same thought every couple months ;-)  Problem is that it would make overall completion take longer.  Which is the lesser evil?14:20
*** markus_z has quit IRC14:21
*** smatzek has quit IRC14:21
*** aarefiev is now known as aarefiev_afk14:22
*** smatzek_ has quit IRC14:22
claudiubefried: i guess it depends on the size of the ci. at some point, all the ci resources could be allocated / in use. anyways, even though a ci can be configured to wait for jenkins to vote +1, it can still be triggered manually via "check some-ci" if needed.14:23
mriedembauzas: we should probably deprecate/remove tooz service group api driver14:23
mriedembauzas: it's not tested,14:23
mriedemand i don't know if anyone outside of yahoo was using it14:23
mriedemmight be worth asking harlowja14:23
mriedembauzas: etcd is probably a better idea, and is something we can test in the gate14:24
mriedemlike i the multinode job or nova-next job14:24
mriedem*in14:24
efriedclaudiub Looks like mriedem missed that one in https://review.openstack.org/#/c/452958/ -- you going to propose the fix?14:24
mriedembauzas: instance=instance is common in all of our logging :)14:25
claudiubah, sure. will do.14:25
mriedemefried: claudiub: missed what?14:25
mriedemclaudiub: i already have a patch for that14:25
claudiubah, ok.14:26
mriedemclaudiub: efried: https://review.openstack.org/#/c/469958/14:26
mriedembauzas: sfinucan: melwitt: dansmith: jaypipes: ^14:26
mriedemand https://review.openstack.org/#/c/469740/14:26
mriedemlive migration rollback is borked w/o those two14:26
bauzasmriedem: about instance=instance, sorry for my ignorance14:26
*** peter-hamilton has joined #openstack-nova14:27
sfinucanmriedem: In a meeting, but I'll look at them soon as I'm done14:27
efriedclaudiub Perhaps you can suggest how to use autospec for https://review.openstack.org/#/c/469958/1/nova/tests/unit/virt/libvirt/test_driver.py ?14:27
*** jmlowe has quit IRC14:29
*** mlakat has quit IRC14:30
efriedclaudiub And https://review.openstack.org/#/c/469740/2/nova/tests/unit/compute/test_compute_mgr.py14:30
*** bnemec is now known as beekneemech14:30
claudiubefried:  well, mock.patch does accept an "autospec" argument, but it doesn't work properly under the current release of mock. I have sent a bug report and bug fix for it: https://github.com/testing-cabal/mock/issues/39614:32
claudiubthat should be the cleanest way; but it didn't get much attention unfortunately.14:32
efriedclaudiub Riiight, I've been (sorta) following that.14:32
*** mingyu has quit IRC14:34
*** lucasxu has quit IRC14:34
claudiubactually, it seems the mock library hasn't been updated in 6 months.14:35
*** gomarivera has quit IRC14:35
*** lucasxu has joined #openstack-nova14:36
*** smatzek__ has quit IRC14:37
*** marst has joined #openstack-nova14:39
*** felipemonteiro__ has quit IRC14:41
*** felipemonteiro__ has joined #openstack-nova14:41
*** catintheroof has quit IRC14:45
*** Hosam has quit IRC14:48
*** Hosam has joined #openstack-nova14:48
*** jmlowe has joined #openstack-nova14:51
*** Hosam has quit IRC14:52
mriedemrfolco: questions/issues in https://review.openstack.org/#/c/460147/14:56
mriedemcdent: ^14:56
* cdent stirs14:56
rfolcomriedem, will address asap14:56
mriedemi could be wrong14:57
cdentmriedem: on which particular part?14:58
mriedemany?14:59
mriedemwe used to check for 200 in the response from the 1.0 call15:00
mriedemnow we're checking a range, which is different and scary15:00
mriedemand we're not handling 404 in case the RP is already gone15:00
cdentthe range thing is the generic version of "success" that is a mode of being a tolerant client. trendy15:00
cdentthe missing 404 is a good point, not sure if that's caught somewhere else or not, but very good of you to point it out15:01
cdentprobably means a missing gabbi test15:01
mriedemi expect the fallback code to be the same as before, and the range thing is different, which is why i flagged it15:01
rfolcoI thought that was covered, would confirm15:01
cdents/gabbi/functional resource tracker/15:01
mriedemhard to review stuff like this if refactored parts are changed15:02
mriedemif you want the range, do it in a preceeding change15:02
cdentmriedem: i think an earlier review caused that change, opportunistic15:02
*** ratailor has quit IRC15:02
cdents/caused/ask for/15:02
mriedem*preceding15:02
*** egonzalez has joined #openstack-nova15:02
mriedemlet's separate it15:02
cdentsure15:02
*** penick has joined #openstack-nova15:02
cdentrfolco: you on it?15:03
* cdent is writing this weeks rp update15:03
* rfolco watching15:03
cdentanybody have anything I don't already know about (he said tautologically)15:03
*** rcernin has quit IRC15:05
*** fragatina has quit IRC15:06
rfolcommedvede, cdent: thanks for reviewing.15:07
rfolcooops mriedem15:07
*** fragatina has joined #openstack-nova15:07
rfolcosorry mmedvede, used to call you on irc :)15:07
mmedvede:)15:08
openstackgerritMerged openstack/nova master: Updated from global requirements  https://review.openstack.org/47011915:09
sfinucanartom: Comments left on https://review.openstack.org/#/c/465205/. Happy to +2 if you can address em?15:09
artomsfinucan, no, I shall sit here and pout until you +215:10
artomsfinucan, in all serious, thanks for taking the time to review :)15:10
artomLet me respin15:10
sfinucandamn, pouting always gets me15:10
artomUm, I...15:10
artomI think you need to tell your bf/gf/wife/SO/whoever?15:11
artom(I'm not taking any chances)15:11
*** cdent has left #openstack-nova15:11
*** cdent has joined #openstack-nova15:11
*** arahal_ has quit IRC15:13
*** arahal_ has joined #openstack-nova15:13
sfinucanmriedem: Never show mdbooth those two patches - you'll surely set him off on one of his days long Python type system rants15:13
sfinucanAnd, reviewed. All g with me15:13
mriedemsfinucan: the live migration ones? he already saw one of them the other night15:14
mriedemlee invoked his name15:14
sfinucandammit, lee15:14
mriedemthe inability to autospec those tests is frustrating, i could just be missing something trivial,15:14
mriedembut i spent an hour one night trying to get it working on the driver_detach one and gave up15:14
*** armax has joined #openstack-nova15:15
efriedclaudiub Doesn't mock.patch autospec work in the decorator form?15:15
*** nic has joined #openstack-nova15:16
*** nic has quit IRC15:16
*** jaypipes is now known as leakypipes15:16
sfinucanI think pylint would catch those issues (too many args/invalid kwargs for function)15:16
sfinucanbut it'd introduce so many false positives as to make it not worth effort15:17
sfinucanmriedem: Ever seen mypy?15:17
mriedemno15:17
*** zz_dimtruck is now known as dimtruck15:17
sfinucanworth checking it out. I'm thinking of integrating it into some of the virt/libvirt code15:18
cdentdo you like it sfinucan ?15:18
sfinucanThe Sphinx source uses it pretty much everywhere15:18
cdentit seems simultaneously really useful but also noisy15:18
sfinucancdent: I like it in it's Python 3 form15:18
sfinucanwith proper annotations rather than comments15:19
cdentand lack of noise was one of the things that keeps me loyal to python15:19
sfinucanthe opt-in nature of the whole thing is pretty attractive to15:19
cdentyes15:19
sfinucan*too, even15:19
sfinucanBut the Python 2 variant is better than nothing, for some of the more complex stuff (like nearly everything in virt/libvirt)15:21
* cdent nods15:22
mriedemcfriesen_: pep8 on your chnage15:25
mriedem*change15:25
*** cdent has quit IRC15:25
*** felipemonteiro__ has quit IRC15:27
*** gyee has joined #openstack-nova15:27
*** dims has quit IRC15:28
*** sambetts is now known as sambetts|afk15:29
*** Oku_OS is now known as Oku_OS-away15:31
openstackgerritJay Pipes proposed openstack/nova master: Sync os-traits to Traits database  https://review.openstack.org/46957815:33
*** hongbin has joined #openstack-nova15:37
*** lucasxu has quit IRC15:38
mriedemdansmith: heh i guess this is a duplicate https://review.openstack.org/#/c/460377/ of https://review.openstack.org/#/c/431722/15:38
mriedemdrats15:38
dansmithmriedem: it's all yours :)15:39
*** cNilesh has joined #openstack-nova15:39
mriedemlooks like the only difference is you dropped the online data migrations, and in mine i think i was asking myself about that15:40
mriedemb/c of skip level upgrading people15:40
mriedemhttps://review.openstack.org/#/c/460377/6/nova/objects/flavor.py@64815:41
*** tbachman has quit IRC15:41
dansmithmriedem: as I've said before, I don't think leaving migrations in the tree for that reason makes sense15:41
mriedemi tend to agree15:41
mriedemwell i reckon i better sort out if there are any other differences here and drop mine - although i am of course partial to my commit message15:44
*** slaweq has joined #openstack-nova15:44
dansmithmriedem: I just abandoned mine so you can't do that :P15:48
*** slaweq has quit IRC15:49
mriedemhells bells15:49
*** cdent has joined #openstack-nova15:49
mriedemi figured i'd just rebase yours15:49
*** tbachman has joined #openstack-nova15:49
*** Apoorva has joined #openstack-nova15:51
*** ralonsoh has quit IRC15:54
openstackgerritMerged openstack/nova master: Connecting Nova to DRBD storage nodes directly  https://review.openstack.org/25629215:55
*** salv-orl_ has quit IRC15:57
*** tbachman has quit IRC15:58
leakypipesmriedem, melwitt, dansmith, bauzas: easy wins (placement-api-ref) starting here: https://review.openstack.org/#/c/452707/16:00
*** tesseract has quit IRC16:00
dansmithdibs16:00
mriedemi'm gonna clean up cfriesen_'s change and +2 before it lunch16:01
mriedemso maybe post-lunch16:01
*** jwcroppe has quit IRC16:01
*** arahal__ has joined #openstack-nova16:02
*** jwcroppe has joined #openstack-nova16:02
*** lpetrut has quit IRC16:03
dansmithleakypipes: are those not rendered in the docs job anywhere?16:03
*** ababich has quit IRC16:03
*** nic has joined #openstack-nova16:03
cdentdansmith: different doc job, let me find link16:04
leakypipescdent: thx16:04
dansmithfound it16:04
cdentgate-placement-api-ref-nv16:04
*** slaweq has joined #openstack-nova16:04
*** aarefiev_afk has quit IRC16:05
*** tbachman has joined #openstack-nova16:05
*** arahal_ has quit IRC16:05
openstackgerritArtom Lifshitz proposed openstack/nova master: Convert instance to primitive for metadata cache  https://review.openstack.org/46997816:06
*** nic1 has joined #openstack-nova16:07
dansmithwe're really spoiling our users with this api_ref nonsense16:07
*** nic has quit IRC16:08
*** cNilesh has quit IRC16:08
*** gaurangt_ has quit IRC16:08
*** cNilesh has joined #openstack-nova16:09
leakypipesdansmith: lol16:09
mriedemdansmith: don't worry, we still have plenty of config options that change the behavior of the API in ways not communicated,16:09
mriedemso we can still screw them16:09
openstackgerritMatt Riedemann proposed openstack/nova master: show flavor info in server details  https://review.openstack.org/43451416:10
mriedem^ and below are +2'ed16:10
mriedemlooks big but it's mostly api-ref and api samples16:10
*** gaurangt has joined #openstack-nova16:11
mriedemnow it's burger time16:11
*** mriedem is now known as mriedem_burgerti16:11
mriedem_burgertidamn16:11
*** mriedem_burgerti is now known as mriedem16:11
artomThe little known Bugatti knock-off, Burgerti16:12
*** felipemonteiro has joined #openstack-nova16:12
*** READ10 has joined #openstack-nova16:12
leakypipes"It's Burger! It's Burger time!".16:12
*** felipemonteiro__ has joined #openstack-nova16:13
dansmithleakypipes: we're allowing renaming of resource classes?16:13
*** yamamoto has quit IRC16:14
leakypipesdansmith: yes.16:15
leakypipesdansmith: only custom ones of course.16:15
dansmithisn't that going to confuse things?16:15
*** yamamoto has joined #openstack-nova16:15
figleafto make them even more customer16:15
*** nic1 is now known as nic16:15
dansmithlike, we have requests in flight that refer to the old name16:15
leakypipesdansmith: no. internally custom ones are just an integer code. the name can be whatever the user wants.16:15
dansmithand/or someone creates two and swaps them16:16
dansmithdon't we communicate between services using the symbolic names?16:16
figleafleakypipes: they will have to match whatever's in the flavor, though, no?16:16
leakypipesdansmith: we leave that as an exercise for the readeer? :)16:16
dansmithyeah what figleaf said16:16
*** pcaruana has quit IRC16:16
*** liuqing has quit IRC16:16
*** felipemonteiro has quit IRC16:16
dansmithI just see no reason to allow that.. might as well just delete and re-create so you get a new integer id and no confusion16:17
figleafdansmith: not feeling super today?16:17
dansmithfigleaf: definitely am not16:17
*** liuqing has joined #openstack-nova16:17
leakypipesdansmith: you and figleaf make a good point. cdent is our API master so I defer to him.16:17
* dansmith allocates a third cup of coffee against his resource provider to try to feel closer to super16:17
figleafdunno if it has much to do with the API16:18
* leakypipes adjusts dansmith's coffee allocation ratio higher16:18
cdentI already fixed that in microversion 1.716:18
dansmithcdent: fixed what? https://review.openstack.org/#/c/467596/4 says we can rename them16:18
leakypipescdent: so we don't allow changing resource class names in 1.7 and beyond?16:18
cdentbecause it was not only a bad flow, but also an issue with the external issue16:18
cdentleakypipes: if you are using a high microversion, correct, you cannot not rename a resource class16:19
cdentyou can delete and create another16:19
cdentor rather16:19
cdentcreate another16:19
cdenteverything external is using the name16:19
cdentwe can't allow changing it16:19
*** yamamoto has quit IRC16:19
dansmith++16:19
figleafcdent: ah, good16:20
cdentI kind of feel like we should de-document the old way16:20
cdentbut that would lead to problems16:20
cdentso perhaps a warning on the 1.2-1.6 microversion?16:21
dansmithcdent: I think we should drop it from the docs, TBH16:21
cdentI mean the doc for put /resource_classes/{name}16:21
dansmithnobody is using this but us yet, so no reason to document something that is already obsolete16:21
claudiubefried: not as it should. it doesn't consume the self / cls argument. if you are patching a function or a static method, it works fine though.16:21
dansmithalso, is PUT the right verb for "create or verify existence" ?16:21
dansmithI would expect POST and return 409 if exists, no?16:22
cdentPUT is the standard for idempotency when you know the url of the resoruce16:22
cdentthe idea here is that you can PUT /resource_classes/{name} all day long16:22
dansmithhrm, okay16:23
cdentand it will always return some form of success16:23
dansmithseems wrong, but I guess I don't have time to convince the rest of the world today16:23
claudiubmriedem: you didn't answer my one question :D : the cinder 3rd party ci requirements state that "CI's do not need to kick off tests until Jenkin's has given a +1", is there a similar policy for nova as well? ( https://wiki.openstack.org/wiki/Cinder/tested-3rdParty-drivers#Third_Party_CI_Requirements )16:23
cdentdansmith: the decision was driven by code in the resource tracker which was doing to "get_or_create_resource_class"16:23
cdentI wanted to change it to "do one call to do both"16:23
cdentwhich is PUT16:23
*** jwnx has quit IRC16:23
artomI think with PUT you're supposed to send the entire resource, and PATCH is for when you just send the changes?16:24
leakypipesdansmith, cdent: added a note on 467596 to add a big fat warning in the UPDATE t1.2 through 1.6 section.16:24
dansmiththat way we can't log whether we created it, which means we can't highlight with a warning "I just created CUSTOM_GUP, hope you didn't typo that"16:24
cdentartom: yes, but this is a different issue. a resource class PUT has no body16:24
cdentdansmith: different resposne code on create or existence:16:25
artomcdent, then we should only allow HEAD on it :D16:25
cdentartom: :P16:25
* leakypipes goes back to work... this has the potential to be a lifeblood-depleting conversation16:25
*** slaweq has quit IRC16:26
artomBikeshedding about HTTP verbs? You don't say ;)16:26
dansmithcdent: I see. less obvious, IMHO, but doesn't matter16:26
dansmithI/we aren't bikeshedding16:26
dansmithjust chatting16:26
*** slaweq has joined #openstack-nova16:26
* artom goes back to his corner and lets the serious people talk16:27
cdentdansmith: of course that's not what the code is doing now, it doesn't log on success, and I'm pretty sure it didn't before?16:27
openstackgerritArtom Lifshitz proposed openstack/nova master: Use VIR_DOMAIN_BLOCK_REBASE_COPY_DEV when rebasing  https://review.openstack.org/46520516:27
dansmithcdent: I haven't even looked, and I assume we won't know we need to log such a thing until the flood of bugs complaining about it16:28
dansmithcdent: but if we have a way to tell so we can add that in the future then that's fine16:28
dansmiththat == that log line16:28
cdent(just check, it isn't, at least not on the RT side, but yeah, there's a way to distinguish)16:28
cdents/check/checked/16:28
artomsfinucan ^^ addressed your feedback, except in one case where I don't agree :P16:28
*** ericyoung has quit IRC16:29
*** cNilesh has quit IRC16:29
*** hongbin has quit IRC16:29
* cdent is extremely happy to experience chatting today/this week16:30
*** mdrabe has quit IRC16:30
*** jaosorior has quit IRC16:30
sfinucanartom: That's all g with me16:31
harlowjamriedem whats up16:31
harlowja`we should probably deprecate/remove tooz service group api driver`16:31
*** cNilesh has joined #openstack-nova16:31
harlowjai'd say that'd be ok, though its really up to u guys if u want to do that, and just go direct to etcd16:32
*** gomarivera has joined #openstack-nova16:32
*** slaweq has quit IRC16:32
harlowjaboth imho are the same level of effort of undoing/redoing the stuff in nova that is specific to a database (for service groups)16:32
harlowjathat was the main problem that was hit i think when trying to refactor that stuff, is there are a bunch of places in nova that are tied to a database for that stuff (because calling serivice group stuff a driver interface is somewhat of a lie)16:33
*** slaweq has joined #openstack-nova16:33
leakypipesharlowja: yup.16:33
harlowjarefactoring to etcd (and a database for daatabase driver users), will likely be the same effort as refactoring to tooz in the end16:34
harlowjaso ya, meh, do as u want :-P16:34
harlowjapenick yahoo never continued down the path of that after vilobh left right?16:35
harlowja(ie continuing the service group refactor to tooz and/or whatever else)16:35
artomsfinucan, thanks g16:36
artom(We so gangsta)16:36
*** cNilesh has quit IRC16:36
*** cNilesh has joined #openstack-nova16:37
*** Swami has joined #openstack-nova16:37
harlowjaleakypipes mriedem what are your plans for that thing?16:39
harlowjajust go directly to etcd3?16:39
harlowjaor try again to have 2 drivers (one for database, one for etcd3 or ???)16:39
*** mdrabe has joined #openstack-nova16:44
openstackgerritMerged openstack/python-novaclient master: Help message for aggregate-update is ambiguous  https://review.openstack.org/46975316:45
*** liverpooler has quit IRC16:46
*** tidwellr has quit IRC16:46
*** liverpooler has joined #openstack-nova16:46
openstackgerritMerged openstack/nova master: libvirt: fix call args to destroy() during live migration rollback  https://review.openstack.org/46995816:48
*** tidwellr has joined #openstack-nova16:48
*** eharney has quit IRC16:48
*** mingyu has joined #openstack-nova16:50
*** derekh has quit IRC16:51
leakypipesharlowja: my long term wishes are to get rid of the services from the REST API entirely.16:52
leakypipesharlowja: and detach the servicegroup API entirely from the database.16:52
leakypipesharlowja: and use something like os-lively for servicegroup liveness and maintenance API.16:52
harlowjawfm16:52
*** claudiub has quit IRC16:52
*** tidwellr has quit IRC16:53
harlowjaremove all the thigns, lol16:53
*** mingyu has quit IRC16:54
harlowjaleakypipes if u do it right, be nice to make something that other projects can use16:54
* harlowja see to many of the same type of crap in various projects16:54
*** brault has quit IRC16:55
harlowja(as u know i think)16:55
*** brault has joined #openstack-nova16:55
*** cNilesh has quit IRC16:55
*** jwcroppe has quit IRC16:58
*** brault has quit IRC17:00
*** lucasxu has joined #openstack-nova17:00
*** fragatina has quit IRC17:00
*** pjm6 has quit IRC17:00
*** pjm6 has joined #openstack-nova17:01
*** jwcroppe has joined #openstack-nova17:02
*** huanxie has quit IRC17:03
*** huanxie has joined #openstack-nova17:03
*** eharney has joined #openstack-nova17:03
*** ckopper has joined #openstack-nova17:08
openstackgerritJay Pipes proposed openstack/nova master: Delete all inventory has its own method DELETE  https://review.openstack.org/46014717:08
leakypipesmriedem: addressed your comments on ^^17:08
*** dims has joined #openstack-nova17:10
*** slaweq has quit IRC17:10
*** tidwellr has joined #openstack-nova17:13
leakypipesrfolco: hope you don't mind, I just pushed some quick fixes and a new unit test on your patch 46014717:15
*** yamamoto has joined #openstack-nova17:16
*** xyang1 has joined #openstack-nova17:17
*** penick has quit IRC17:18
*** tbachman has quit IRC17:19
*** swebster has quit IRC17:19
rfolcoleakypipes, Thanks a lot. Appreciate your help.17:19
leakypipesnp17:19
*** yamamoto has quit IRC17:21
*** READ10 has quit IRC17:23
*** esberglu has quit IRC17:24
*** dims has quit IRC17:24
*** esberglu has joined #openstack-nova17:24
*** raunak has joined #openstack-nova17:25
*** sudipto has joined #openstack-nova17:25
*** sudipto_ has joined #openstack-nova17:25
*** jdillaman has quit IRC17:25
*** dims has joined #openstack-nova17:26
*** jdillaman has joined #openstack-nova17:27
*** harlowja has quit IRC17:28
*** READ10 has joined #openstack-nova17:28
*** esberglu has quit IRC17:29
*** lucasagomes is now known as lucas-afk17:30
*** jwnx has joined #openstack-nova17:31
*** tbachman has joined #openstack-nova17:34
*** mingyu has joined #openstack-nova17:36
*** esberglu has joined #openstack-nova17:37
*** mingyu has quit IRC17:40
*** gomarivera has quit IRC17:41
melwittmriedem: before I go looking around, do you know if this bug is still a bug, by chance? https://bugs.launchpad.net/nova/+bug/167975017:41
openstackLaunchpad bug 1679750 in OpenStack Compute (nova) "Allocations are not cleaned up in placement for instance 'local delete' case" [Medium,Confirmed] - Assigned to Sylvain Bauza (sylvain-bauza)17:41
*** mnestratov|2 has quit IRC17:42
*** penick has joined #openstack-nova17:44
cfriesen_mriedem: thanks for the update...was AFK this morning.17:45
melwittmriedem: nevermind, looks like it is. I'll start writing the functional test you described in the bug17:47
*** penick has quit IRC17:48
melwittcdent: what did you mean by "Did you want this file in the parent?" I was trying to guess what to do with the new microversion based on resource_classes*.yaml gabbits17:49
melwittcdent: oh wait, nevermind. yes, I put it in the wrong commit by accident17:50
cdentmelwitt: as far as I could tell that file was only testing /allocations not /usages so I thought perhaps it was meant for the earlier commit17:50
cdentjinxish17:50
melwittyeah, I messed that up. thanks17:51
cdentleakypipes: since we've been trading on the traits sync patch, just a heads up: it's failling some functional tests, I'll fix it17:51
*** sudipto has quit IRC17:53
*** sudipto_ has quit IRC17:53
leakypipescdent: cheers17:55
*** dtp has joined #openstack-nova17:57
*** jwcroppe has quit IRC17:58
*** Apoorva_ has joined #openstack-nova18:00
*** arunman has quit IRC18:01
mriedemmelwitt: i don't think so, unless it's part of bauzas' series on claims in the scheduler18:02
melwittmriedem: ah, good point, I'll skim through those to see18:02
openstackgerritChris Dent proposed openstack/nova master: Sync os-traits to Traits database  https://review.openstack.org/46957818:03
*** Apoorva has quit IRC18:03
cdentthat's it for me18:04
cdenthave a good weekend everyone18:04
*** cdent has quit IRC18:04
*** jpena is now known as jpena|off18:05
mriedemleakypipes: dansmith: renaming custom resource classes? why? isn't that like renaming a flavor (which we don't allow)?18:05
mriedemjust because we can do a thing doesn't mean we should18:05
dansmithmriedem: or renaming an enum yeah18:05
*** tbachman has quit IRC18:07
mriedemor is that pre-1.7 behavior?18:07
*** lbragstad has quit IRC18:08
mriedemi guess so https://review.openstack.org/#/c/467596/4/placement-api-ref/source/resource_class.inc@7518:08
dansmithyeah18:08
*** yamahata has joined #openstack-nova18:08
*** sudipto_ has joined #openstack-nova18:09
*** sudipto has joined #openstack-nova18:09
mriedemok i thought this was something someone wanted to do18:09
mriedemso with 1.7 you can't rename customer resource classes anymore?18:10
mriedemPUT is now either a 201 or 20418:10
*** rajathagasthya has joined #openstack-nova18:10
mriedemfor create or ack it exists18:10
*** jwcroppe has joined #openstack-nova18:11
*** tbachman has joined #openstack-nova18:12
mriedemoomichi: can you also go through this one? https://review.openstack.org/#/c/434514/18:12
*** READ10 has quit IRC18:13
dansmithgiven leakypipes' recent tendency to have long lines in his commit messages, I feel like we should, as a project, adopt the max6 linter: https://github.com/petersn/six-char-max18:15
*** dims has quit IRC18:16
leakypipesdansmith: I've started to ensure tw=71 in commit messages now.18:16
dansmithleakypipes: thank you18:16
*** dims has joined #openstack-nova18:17
*** yamamoto has joined #openstack-nova18:17
mriedemdansmith: that would be great if you're coding in an AS400 terminal18:20
mriedembut i think even they allow 818:20
mriedemthey're not nazis18:20
mriedemonly sold to them...18:20
dansmithheh18:21
mriedemQSECOFR 4VR18:21
dansmithmax6 would help me get back to writing all my code on a TRS-80 Model 10018:22
*** yamamoto has quit IRC18:23
*** sudipto has quit IRC18:25
*** sudipto_ has quit IRC18:25
mriedemsfinucan: i feel vindicated https://review.openstack.org/#/c/379524/18:27
mriedemsfinucan: for totally not knowing wtf was going on18:27
mriedem:)18:27
openstackgerritMerged openstack/nova master: [placement] Add api-ref for PUT RP inventories  https://review.openstack.org/45270718:28
openstackgerritMerged openstack/nova master: [placement] Add api-ref for DELETE RP inventories  https://review.openstack.org/45270818:29
openstackgerritMerged openstack/nova master: [placement] Add api-ref for GET RP inventory  https://review.openstack.org/45521318:30
openstackgerritMerged openstack/nova master: Use plain routes list for os-interface endpoint instead of stevedore  https://review.openstack.org/45997918:31
openstackgerritMerged openstack/nova master: Use plain routes list for server-tags instead of stevedore  https://review.openstack.org/46164518:32
openstackgerritMerged openstack/nova master: Use plain routes list for server-migrations endpoint instead of stevedore  https://review.openstack.org/46164618:32
openstackgerritMerged openstack/nova master: Use plain routes list for os-server-external-events endpoint  https://review.openstack.org/46832418:33
openstackgerritMerged openstack/nova master: Use plain routes list for server diagnostics endpoint  https://review.openstack.org/46833118:34
openstackgerritMerged openstack/nova master: [placement] Add api-ref for PUT RP inventory  https://review.openstack.org/45521418:35
openstackgerritMerged openstack/nova master: [placement] Add api-ref for DELETE RP inventory  https://review.openstack.org/45521518:36
melwittmriedem: is there already a way to talk to the placement API in our functional regression tests? like, to query for allocations?18:36
*** gomarivera has joined #openstack-nova18:36
mriedemthere is a PlacementFixture18:36
openstackgerritMerged openstack/nova master: [placement] Add api-ref for POST resource provider  https://review.openstack.org/45617618:36
mriedemwhich bypasses keystone i believe18:36
mriedemit's used in some scheduler tests for 1.418:37
melwittokay, thanks. I'll look for that for examples18:37
openstackgerritMerged openstack/nova master: [placement] Add api-ref for GET resource provider  https://review.openstack.org/46754118:37
*** lbragstad has joined #openstack-nova18:38
openstackgerritMerged openstack/nova master: [placement] Add api-ref for PUT resource provider  https://review.openstack.org/46754218:38
*** catintheroof has joined #openstack-nova18:38
*** lbragstad has quit IRC18:39
oomichimriedem: is that 2.47? some parameters contains it as 2.4618:39
oomichion https://review.openstack.org/#/c/463263/18:39
oomichioops wrong: https://review.openstack.org/#/c/434514/16/api-ref/source/parameters.yaml18:40
*** gjayavelu has joined #openstack-nova18:40
openstackgerritMerged openstack/nova master: placement: Specific error for inventory in use  https://review.openstack.org/46023118:40
mriedemoomichi: those are max_version for 2.4618:40
*** lbragstad has joined #openstack-nova18:40
mriedemit's just a naming convention meaning those parameters are capped at 2.3618:40
mriedem*2.4618:40
*** mingyu has joined #openstack-nova18:41
oomichimriedem: ah, I got it. I cannot find the other points. It would be nice to merge18:41
*** lbragstad has quit IRC18:42
mriedemoomichi: the was/were is because they are describing a flavor in an existing instance,18:43
mriedeme.g. the CPUs were already allocated18:43
*** tidwellr has quit IRC18:44
*** lbragstad has joined #openstack-nova18:44
*** lbragstad_ has joined #openstack-nova18:46
*** lbragstad has quit IRC18:46
*** gjayavelu has quit IRC18:46
cfriesen_mriedem: just commented on that...we could remove the tense entirely18:47
*** gjayavelu has joined #openstack-nova18:47
cfriesen_"The number of virtual CPUs allocated to the server"18:47
*** lbragstad_ has quit IRC18:47
*** lbragstad has joined #openstack-nova18:48
*** egonzalez has quit IRC18:49
*** lbragstad has quit IRC18:49
*** lbragstad__ has joined #openstack-nova18:49
*** lbragstad__ has quit IRC18:49
*** lbragstad__ has joined #openstack-nova18:49
melwittdo we really need to clean up servers created during functional tests? I thought the DatabaseFixture provides a fresh database for each test and gets thrown away per test18:49
mriedemcfriesen_: good point, that could be cleaned up in a follow up change18:51
*** lbragstad__ has quit IRC18:51
mriedemcfriesen_: you've also got to get the novaclient change refreshed18:51
cfriesen_yeah18:51
*** lbragstad__ has joined #openstack-nova18:51
mriedemmelwitt: maybe we do'nt need to no18:51
mriedemi probably tend to do those b/c i think of them more like tempest18:52
*** lucasxu has quit IRC18:52
mriedemalso nice to see if delete blows up or something18:52
melwittyeah. seeing it made me second guess it. yeah, I didn't think of that18:52
*** MasterOfBugs has joined #openstack-nova18:53
*** lbragstad__ has quit IRC18:54
*** lbragstad__ has joined #openstack-nova18:54
*** raunak has quit IRC18:58
*** lbragstad__ has quit IRC18:59
*** gomarivera has quit IRC19:00
cfriesen_mriedem: is someone working on a novaclient patch for 2.46?19:01
*** catintheroof has quit IRC19:02
mriedemisn't that already merged?19:02
cfriesen_mriedem: API_MAX_VERSION = api_versions.APIVersion("2.45")  on master19:02
mriedemoh i was thinking of this https://github.com/openstack/python-novaclient/commit/d25502cbe2749ed7042e427fe8d4a3678acf455019:02
mriedem^ should have probably been 2.4619:02
mriedemno test changes needed, just bump the version19:02
mriedemi don't know if there is a patch for it yet19:03
cfriesen_I can bump directly to 2.47 if there's nothing needed for 2.4619:03
mriedemjust do a patch for 2.46 and then do 2.47 on top of it19:03
cfriesen_kay19:03
*** lucasxu has joined #openstack-nova19:04
*** eharney has quit IRC19:07
cfriesen_mriedem: is a release note needed?19:09
cfriesen_or just skip it like was done for 2.4219:09
*** rajathagasthya has quit IRC19:10
mriedemwe do'nt need a release note in novaclient for 2.4619:10
melwittgdi I'm getting that my compute node has 0GB disk available in my functional test so it fails to build a server with NoValidHost19:10
melwittI don't recall ever seeing that before19:11
clarkbmelwitt: in the gate?19:11
melwittno, locally19:11
*** kylek3h has quit IRC19:11
*** rajathagasthya has joined #openstack-nova19:11
mriedemmelwitt: should be using the fake virt driver already19:12
mriedemvia the conf fixture19:12
*** jwcroppe has quit IRC19:12
*** lbragstad__ has joined #openstack-nova19:13
melwittthanks, I'm copying a test that did everything manually and didn't realize I needed the set_nodes() etc stuff. my bad19:13
*** lbragstad__ is now known as lbragstad19:13
*** gyee has quit IRC19:14
*** rajathagasthya has quit IRC19:16
openstackgerritDirk Mueller proposed openstack/nova-specs master: Fix citation references (Sphinx 1.6.x compatibility)  https://review.openstack.org/47025219:16
cfriesen_mriedem: do we need cleanup in the novaclient functional tests?  (I'm looking at jichenjc's comment in https://review.openstack.org/#/c/435141/7/novaclient/tests/functional/v2/test_servers.py)19:17
cfriesen_I'm happy to delete the server if desired.19:17
openstackgerritDirk Mueller proposed openstack/nova-specs master: Fix citation references (Sphinx 1.6.x compatibility)  https://review.openstack.org/47025219:17
*** gyee has joined #openstack-nova19:17
mriedemcfriesen_: as in self.addCleanup(server.delete)?19:18
mriedemyes we need that in novaclient functional tests,19:18
mriedemthey are backed by a single node dsvm env19:18
cfriesen_mriedem: was looking at _cleanup_server() actually19:18
mriedemso if you don't cleanup, we can eventually hit resource / quota issues19:18
mriedemwe should always cleanup resources in integration tests19:18
mriedemleaking leads to weird test failures later19:19
cfriesen_addCleanup is probably better?19:19
mriedemi don't know what _cleanup_server() is19:19
mriedemi don't care where we clean up19:19
mriedemwe just need to cleanup on teardown of each test19:19
*** yamamoto has joined #openstack-nova19:19
mriedemif we created something19:19
cfriesen_kay19:19
*** mingyu has quit IRC19:19
*** mingyu has joined #openstack-nova19:20
mriedemjust like the gd markers and coloring books all over my living room floor19:20
mriedemi don't care how they got there,19:20
mriedemi just want them cleaned up19:20
melwitthah19:20
*** eharney has joined #openstack-nova19:20
*** pwiltsey has joined #openstack-nova19:21
cfriesen_looks like it's already done for me actually...the helper function I used to create the server adds the cleanup19:22
openstackgerritMerged openstack/nova master: add new test fixture flavor with extra_specs  https://review.openstack.org/47007619:22
*** yamamoto has quit IRC19:24
melwitthm, I think maybe this never works to use the DiskFilter in func tests. all the tests that derive from the integrated_helpers base use the chance scheduler and ones I see using filter scheduler aren't using the DiskFilter19:24
melwittI dumbly tried to just let it use default filters even though I don't care about the filters. changing to the chance scheduler19:25
mriedemthere are only like 2 filters you can use if you're doing filter scheduler,19:25
mriedemallhostsfilter and retryfilter i think19:25
mriedemmaybe computefilter19:25
mriedemsomething like that19:25
melwittyeah. guh, my fault for not knowing how this works until now I guess19:26
mriedemthe integrated_helpers stuff hides a lot of this19:26
melwittI always had just inherited from the integrated_helpers base test case and didn't think about it19:26
melwittyeah19:26
mriedemonce you start not relying on that,19:26
mriedemyou find out we use a buttload of fixtures :)19:26
melwittyeah, for reals19:27
openstackgerritChris Friesen proposed openstack/python-novaclient master: 2.47: Show flavor info in server details  https://review.openstack.org/43514119:28
openstackgerritChris Friesen proposed openstack/python-novaclient master: 2.46: match nova API version  https://review.openstack.org/47041319:28
*** kbaegis has joined #openstack-nova19:28
mriedemcfriesen_: you're going to need a unit test change on that bottom one, sec19:28
cfriesen_oh yeah,19:29
cfriesen_will update19:29
mriedemcfriesen_:19:29
mriedemhttps://github.com/openstack/python-novaclient/blob/master/novaclient/tests/unit/v2/test_shell.py#L290719:29
*** mlo has joined #openstack-nova19:31
*** mlo has left #openstack-nova19:32
openstackgerritChris Friesen proposed openstack/python-novaclient master: 2.47: Show flavor info in server details  https://review.openstack.org/43514119:33
openstackgerritChris Friesen proposed openstack/python-novaclient master: 2.46: match nova API version  https://review.openstack.org/47041319:33
*** dimtruck is now known as zz_dimtruck19:34
openstackgerritOpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements  https://review.openstack.org/46958119:34
cfriesen_now I need to go make "online_data_migrations" work with our customizations to Newton19:34
*** brault has joined #openstack-nova19:36
cfriesen_and I resolve to stay away from api_sample_tests as much as possible19:37
*** brault has quit IRC19:40
mriedemhuh i thought we were going to start running nova-api under uwsgi in the gate19:41
mriedemaha https://review.openstack.org/#/c/457715/19:41
*** hongbin has joined #openstack-nova19:43
*** pwiltsey has left #openstack-nova19:44
openstackgerritKaitlin Farr proposed openstack/nova master: Remove deprecated keymgr code  https://review.openstack.org/43985519:48
*** vladikr has quit IRC19:50
*** mingyu has quit IRC19:52
*** mingyu has joined #openstack-nova19:53
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Document Pike release review priorities  https://review.openstack.org/47042019:54
*** zz_dimtruck is now known as dimtruck19:54
mriedemdansmith: leakypipes: ^19:54
mriedemlong time coming but finally got the review priorities for pike documented19:54
*** wasmum has joined #openstack-nova19:55
*** eharney has quit IRC19:56
*** mingyu has quit IRC19:57
*** NostawRm has quit IRC19:59
*** raunak has joined #openstack-nova19:59
*** wasmum has quit IRC20:03
*** harlowja has joined #openstack-nova20:04
leakypipesmriedem: reviewed.20:04
mriedemoh right20:07
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Document Pike release review priorities  https://review.openstack.org/47042020:09
*** marst has quit IRC20:10
*** marst has joined #openstack-nova20:10
*** eharney has joined #openstack-nova20:11
*** rcernin has joined #openstack-nova20:12
*** wasmum has joined #openstack-nova20:14
*** artom has quit IRC20:18
*** artom has joined #openstack-nova20:18
*** yamamoto has joined #openstack-nova20:20
*** mvensky has joined #openstack-nova20:23
*** dtp has quit IRC20:25
*** yamamoto has quit IRC20:26
*** Apoorva_ has quit IRC20:26
*** Apoorva has joined #openstack-nova20:27
openstackgerritMerged openstack/nova master: show flavor info in server details  https://review.openstack.org/43451420:28
openstackgerritMerged openstack/nova master: Add database migration and model for consumers  https://review.openstack.org/46963320:29
*** claudiub has joined #openstack-nova20:34
*** slaweq has joined #openstack-nova20:35
*** tidwellr has joined #openstack-nova20:35
*** raunak has quit IRC20:37
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Cap sphinx<1.6.1  https://review.openstack.org/47043420:39
*** fragatina has joined #openstack-nova20:39
*** pchavva has quit IRC20:39
*** gouthamr has quit IRC20:41
*** slaweq has quit IRC20:42
*** nicolasbock has quit IRC20:43
*** lucasxu has quit IRC20:45
*** fragatina has quit IRC20:45
*** jwnx has quit IRC20:45
*** egonzalez has joined #openstack-nova20:45
*** awaugama has quit IRC20:46
*** lucasxu has joined #openstack-nova20:47
*** lucasxu has quit IRC20:48
*** lucasxu has joined #openstack-nova20:48
*** READ10 has joined #openstack-nova20:48
*** lucasxu has quit IRC20:49
*** burt has quit IRC20:50
*** burt has joined #openstack-nova20:51
*** dimtruck is now known as zz_dimtruck20:54
*** zz_dimtruck is now known as dimtruck20:55
*** winston-d_ has quit IRC20:55
*** jmlowe has quit IRC20:57
*** salv-orlando has joined #openstack-nova20:58
*** karimb has joined #openstack-nova20:59
*** gouthamr has joined #openstack-nova20:59
*** kaisers1 has quit IRC21:07
*** thorst has quit IRC21:11
*** thorst has joined #openstack-nova21:15
*** eharney has quit IRC21:15
*** slaweq has joined #openstack-nova21:18
cfriesen_can someone suggest why gate-python-novaclient-releasenotes is failing for https://review.openstack.org/#/c/435141 ?21:18
*** thorst has quit IRC21:19
openstackgerritKaitlin Farr proposed openstack/nova master: Remove deprecated keymgr code  https://review.openstack.org/43985521:20
*** felipemonteiro__ has quit IRC21:21
*** yamamoto has joined #openstack-nova21:22
openstackgerritMerged openstack/nova-specs master: Cap sphinx<1.6.1  https://review.openstack.org/47043421:22
*** lbragstad has quit IRC21:22
*** slaweq has quit IRC21:23
openstackgerritChris Friesen proposed openstack/python-novaclient master: 2.47: Show flavor info in server details  https://review.openstack.org/43514121:24
*** mtanino has joined #openstack-nova21:25
clarkbcfriesen_: https://review.openstack.org/#/c/469881/ something like that needed in novaclient?21:26
*** mnestratov|2 has joined #openstack-nova21:27
cfriesen_clarkb: already had that formatting style21:27
*** yamamoto has quit IRC21:27
clarkbcfriesen_: in your chnge yes, but I think new relaese of releasenotes is more strict so old things elsewhere may be unhappy21:28
cfriesen_I'm wondering if maybe it was related to the sphinx change above21:28
*** kfarr has quit IRC21:28
clarkbnotes/remove-deprecated-option-in-3.3.0-82a413157838570d.yaml is the file it is mad about21:28
clarkbwhich doesn't use > or |21:28
cfriesen_ah, right21:29
clarkbI think the problem is that that file is treated as entirely yaml rather than being yaml with rst strings in it and reno is emitting a warning which is treated as an error21:30
clarkbalso update doesn't appear to be a valid directive which may be the underlying issue21:31
clarkbhttps://docs.openstack.org/developer/reno/usage.html21:32
cfriesen_yeah, was just looking at that21:32
cfriesen_maybe it was supposed to be upgrade?21:32
*** tidwellr has quit IRC21:32
clarkbthat would be my guess21:33
clarkbbeacuse in upgrade you can list things21:33
cfriesen_I can try fixing it up21:33
*** MVenesio has quit IRC21:39
*** thorst has joined #openstack-nova21:39
*** mvensky has quit IRC21:40
*** dimtruck is now known as zz_dimtruck21:41
*** ckopper has quit IRC21:45
openstackgerritChris Friesen proposed openstack/python-novaclient master: Fix up release note  https://review.openstack.org/47044621:45
*** mdrabe has quit IRC21:47
*** zz_dimtruck is now known as dimtruck21:50
*** salv-orlando has quit IRC21:52
*** thorst has quit IRC21:58
*** fragatina has joined #openstack-nova21:59
*** pwiltsey_ has joined #openstack-nova22:01
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements  https://review.openstack.org/47047422:02
*** READ10 has quit IRC22:02
*** edmondsw has quit IRC22:03
*** pwiltsey_ has quit IRC22:03
*** kaisers has joined #openstack-nova22:04
openstackgerritOpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements  https://review.openstack.org/46717322:04
*** burt has quit IRC22:05
clarkbcfriesen_: that got the error to change :) I think you need to do something like upgrade:\n  - |\n    notes there22:06
*** pwiltsey has joined #openstack-nova22:06
openstackgerritOpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements  https://review.openstack.org/46958122:07
*** rfolco has quit IRC22:09
*** pwiltsey has quit IRC22:11
*** fragatina has quit IRC22:11
cfriesen_clarkb: respinning22:12
openstackgerritChris Friesen proposed openstack/python-novaclient master: Fix up release note  https://review.openstack.org/47044622:13
*** nic has quit IRC22:15
*** arahal__ has quit IRC22:15
*** dimtruck is now known as zz_dimtruck22:16
*** nic has joined #openstack-nova22:17
*** lbragstad has joined #openstack-nova22:18
*** zz_dimtruck is now known as dimtruck22:22
*** yamamoto has joined #openstack-nova22:24
*** Swami has quit IRC22:24
*** nic has quit IRC22:28
*** yamamoto has quit IRC22:29
*** belliott_ has joined #openstack-nova22:31
*** lyarwood_ has joined #openstack-nova22:31
*** raorn_ has joined #openstack-nova22:32
*** toan has joined #openstack-nova22:33
*** tbachman has quit IRC22:34
*** andreaf has quit IRC22:35
*** rcernin has quit IRC22:39
*** ejat is now known as fenris22:39
*** fenris is now known as ejat22:39
*** belliott has quit IRC22:40
*** raorn has quit IRC22:40
*** andreaf has joined #openstack-nova22:40
*** hwoarang has quit IRC22:40
*** Hazelesque has quit IRC22:40
*** gouthamr has quit IRC22:40
*** saneax has quit IRC22:40
*** Hazelesque_ has joined #openstack-nova22:40
*** melwitt_ has joined #openstack-nova22:40
*** hwoarang has joined #openstack-nova22:40
*** toanster has quit IRC22:40
*** melwitt has quit IRC22:40
*** lyarwood has quit IRC22:40
*** saneax has joined #openstack-nova22:41
*** ckopper has joined #openstack-nova22:42
*** gouthamr has joined #openstack-nova22:42
*** mtreinish has quit IRC22:42
*** alextricity25 has quit IRC22:42
*** figleaf is now known as edleafe22:43
openstackgerritJay Pipes proposed openstack/nova master: placement: adds REST API for nested providers  https://review.openstack.org/38480722:43
openstackgerritJay Pipes proposed openstack/nova master: placement: allow filter providers in tree  https://review.openstack.org/37721522:43
openstackgerritJay Pipes proposed openstack/nova master: placement: integrate ProviderTree to report client  https://review.openstack.org/41592122:43
openstackgerritJay Pipes proposed openstack/nova master: placement: adds ProviderTree for nested resources  https://review.openstack.org/41592022:43
openstackgerritJay Pipes proposed openstack/nova master: placement: update client to set parent provider  https://review.openstack.org/38569322:43
openstackgerritJay Pipes proposed openstack/nova master: placement: add nested resource providers  https://review.openstack.org/37713822:43
openstackgerritJay Pipes proposed openstack/nova master: placement: set/check if inventory change in tree  https://review.openstack.org/47057522:43
*** sfinucan has quit IRC22:43
*** ckopper has quit IRC22:45
*** alextricity25 has joined #openstack-nova22:45
*** Hazelesque_ is now known as Hazelesque22:45
*** sfinucan has joined #openstack-nova22:46
*** mvk has quit IRC22:47
*** mtreinish has joined #openstack-nova22:47
*** jwcroppe has joined #openstack-nova22:47
*** thorst has joined #openstack-nova22:49
*** thorst has quit IRC22:49
*** melwitt_ is now known as melwitt22:49
*** MasterOfBugs has quit IRC22:50
*** ckopper has joined #openstack-nova22:52
*** marst_ has joined #openstack-nova22:52
*** mingyu has joined #openstack-nova22:54
*** thorst has joined #openstack-nova22:55
*** marst has quit IRC22:56
*** mingyu has quit IRC22:57
*** esberglu has quit IRC22:59
*** mvk has joined #openstack-nova22:59
*** esberglu has joined #openstack-nova23:00
*** marst_ has quit IRC23:00
*** kbaegis has quit IRC23:01
*** esberglu has quit IRC23:04
*** lyan has quit IRC23:10
*** leakypipes has quit IRC23:10
*** edmondsw has joined #openstack-nova23:11
*** thorst has quit IRC23:14
*** xyang1 has quit IRC23:14
openstackgerritmelanie witt proposed openstack/nova master: Add functional test for local delete allocations  https://review.openstack.org/47057823:15
*** vladikr has joined #openstack-nova23:16
*** edmondsw has quit IRC23:16
*** kbaegis has joined #openstack-nova23:21
*** dimtruck is now known as zz_dimtruck23:23
*** mnestratov|2 has quit IRC23:24
*** yamamoto has joined #openstack-nova23:26
openstackgerritguang-yee proposed openstack/nova master: libvirt: Reconnect volumes and encryptors during a hard reboot  https://review.openstack.org/40038423:29
*** yamamoto has quit IRC23:31
*** claudiub has quit IRC23:49
lbragstadmriedem: thanks for the reviews on https://review.openstack.org/#/c/469954/523:49
lbragstadmriedem: let me know if i've made the wording better or worse23:50
*** brault has joined #openstack-nova23:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!