mriedem | with the microversion, we could get non-compute things again, or just close that weird gap | 00:00 |
---|---|---|
mriedem | probably better to restrict to nova-compute services for things like enable/disable/forced_down | 00:00 |
*** crushil has quit IRC | 00:00 | |
*** crushil has joined #openstack-nova | 00:01 | |
*** gomarivera has joined #openstack-nova | 00:03 | |
*** catintheroof has quit IRC | 00:03 | |
*** crushil has quit IRC | 00:07 | |
*** crushil has joined #openstack-nova | 00:07 | |
dansmith | mriedem: you mean after we made the change it's 404 now instead of 200 right? | 00:08 |
*** catintheroof has joined #openstack-nova | 00:11 | |
*** markvoelker has quit IRC | 00:11 | |
mriedem | yes | 00:12 |
mriedem | we could get it back to a 200, but it seems better to just fix the weird behavior we used to allow | 00:12 |
mriedem | this would be good to remember for when someone shows up in a year asking why their weird script no longer disables nova-scheduler services... | 00:13 |
dansmith | agreed | 00:13 |
dansmith | not sure 404 is the right thing though | 00:13 |
dansmith | since we expose the service, they did a PUT on it.. probably needs to be 499: Dumbass or something | 00:13 |
*** acormier has joined #openstack-nova | 00:14 | |
mriedem | or a 400 | 00:14 |
mriedem | but yeah | 00:14 |
mriedem | anyway have to run for a bit | 00:14 |
*** mriedem has quit IRC | 00:14 | |
*** claudiub|2 has quit IRC | 00:16 | |
*** dtp has quit IRC | 00:19 | |
*** catintheroof has quit IRC | 00:25 | |
*** crushil has quit IRC | 00:25 | |
*** jwcroppe has joined #openstack-nova | 00:33 | |
*** ijw has joined #openstack-nova | 00:33 | |
*** Guest77651 has quit IRC | 00:34 | |
*** mdnadeem has joined #openstack-nova | 00:38 | |
*** huanxie has joined #openstack-nova | 00:39 | |
*** jwcroppe has quit IRC | 00:43 | |
*** jwcroppe has joined #openstack-nova | 00:43 | |
*** zhurong has joined #openstack-nova | 00:44 | |
*** tovin07_ has joined #openstack-nova | 00:48 | |
*** Guest77651 has joined #openstack-nova | 00:48 | |
*** baoli has joined #openstack-nova | 00:49 | |
*** huanxie has quit IRC | 00:49 | |
*** lucasxu has joined #openstack-nova | 00:49 | |
*** armax has quit IRC | 00:50 | |
*** tbachman has quit IRC | 00:52 | |
*** armax has joined #openstack-nova | 00:53 | |
*** hongbin has quit IRC | 00:54 | |
*** boris-42_ has quit IRC | 00:59 | |
*** salv-orlando has joined #openstack-nova | 01:02 | |
*** phuongnh has joined #openstack-nova | 01:03 | |
*** esberglu has quit IRC | 01:04 | |
*** esberglu has joined #openstack-nova | 01:04 | |
*** dimtruck is now known as zz_dimtruck | 01:05 | |
*** ijw has quit IRC | 01:05 | |
*** salv-orlando has quit IRC | 01:06 | |
*** esberglu has quit IRC | 01:09 | |
*** rajathagasthya has quit IRC | 01:13 | |
*** cNilesh has joined #openstack-nova | 01:13 | |
*** rajathagasthya has joined #openstack-nova | 01:13 | |
*** litao__ has joined #openstack-nova | 01:15 | |
*** salv-orlando has joined #openstack-nova | 01:16 | |
*** dave-mccowan has joined #openstack-nova | 01:17 | |
*** salv-orlando has quit IRC | 01:20 | |
Kevin_Zheng | mriedem: assigned | 01:22 |
*** ijw has joined #openstack-nova | 01:23 | |
*** ijw has quit IRC | 01:23 | |
*** gjayavelu has quit IRC | 01:23 | |
*** owalsh-pto has quit IRC | 01:26 | |
*** owalsh has joined #openstack-nova | 01:28 | |
*** Yangyapeng has joined #openstack-nova | 01:33 | |
*** coreywright has quit IRC | 01:33 | |
*** thorst_afk has joined #openstack-nova | 01:33 | |
*** huanxie has joined #openstack-nova | 01:35 | |
*** markvoelker has joined #openstack-nova | 01:36 | |
*** yamahata has quit IRC | 01:36 | |
*** lucasxu has quit IRC | 01:37 | |
*** acormier has quit IRC | 01:38 | |
*** acormier has joined #openstack-nova | 01:38 | |
*** acormier has quit IRC | 01:39 | |
*** acormier has joined #openstack-nova | 01:39 | |
*** kenperkins has joined #openstack-nova | 01:40 | |
*** acormier has quit IRC | 01:41 | |
*** acormier has joined #openstack-nova | 01:41 | |
*** gouthamr has quit IRC | 01:42 | |
*** thorst_afk has quit IRC | 01:43 | |
*** mdrabe has quit IRC | 01:46 | |
*** mdrabe has joined #openstack-nova | 01:46 | |
openstackgerrit | Ngo Quoc Cuong proposed openstack/nova master: Remove translation of log messages https://review.openstack.org/466995 | 01:46 |
*** coreywright has joined #openstack-nova | 01:52 | |
*** jichen has joined #openstack-nova | 01:54 | |
*** mingyu has joined #openstack-nova | 01:55 | |
*** Apoorva_ has joined #openstack-nova | 01:55 | |
*** Apoorva has quit IRC | 01:59 | |
*** Apoorva_ has quit IRC | 01:59 | |
*** mingyu has quit IRC | 02:04 | |
*** bkopilov has quit IRC | 02:06 | |
*** zhurong has quit IRC | 02:07 | |
*** dikonoo has joined #openstack-nova | 02:07 | |
*** tuanluong has joined #openstack-nova | 02:13 | |
*** thorst_afk has joined #openstack-nova | 02:13 | |
*** nicolasbock has joined #openstack-nova | 02:17 | |
*** thorst_afk has quit IRC | 02:23 | |
*** thorst_afk has joined #openstack-nova | 02:24 | |
*** thorst_afk has quit IRC | 02:24 | |
*** yamamoto has joined #openstack-nova | 02:25 | |
*** baoli has quit IRC | 02:26 | |
*** baoli has joined #openstack-nova | 02:27 | |
*** Shunli has joined #openstack-nova | 02:28 | |
*** baoli has quit IRC | 02:28 | |
*** winston-d_ has joined #openstack-nova | 02:30 | |
*** kenperkins has quit IRC | 02:42 | |
*** itlinux_ has joined #openstack-nova | 02:43 | |
*** gomarivera has quit IRC | 02:50 | |
*** gomarivera has joined #openstack-nova | 02:51 | |
*** itlinux_ has quit IRC | 02:51 | |
*** gouthamr has joined #openstack-nova | 02:53 | |
*** rajathagasthya has quit IRC | 02:54 | |
*** thorst_afk has joined #openstack-nova | 02:54 | |
*** hongbin has joined #openstack-nova | 02:55 | |
*** gomarivera has quit IRC | 02:55 | |
*** zz_dimtruck is now known as dimtruck | 02:56 | |
*** baoli has joined #openstack-nova | 02:57 | |
*** baoli has quit IRC | 02:58 | |
*** baoli has joined #openstack-nova | 02:59 | |
*** vladikr has quit IRC | 03:00 | |
*** ssurana has joined #openstack-nova | 03:00 | |
*** ssurana has quit IRC | 03:00 | |
*** mingyu has joined #openstack-nova | 03:01 | |
*** baoli has quit IRC | 03:03 | |
*** ijw has joined #openstack-nova | 03:03 | |
*** ijw has quit IRC | 03:07 | |
*** sridharg has joined #openstack-nova | 03:09 | |
*** thorst_afk has quit IRC | 03:14 | |
*** salv-orlando has joined #openstack-nova | 03:17 | |
*** mdrabe_ has joined #openstack-nova | 03:17 | |
*** dimtruck is now known as zz_dimtruck | 03:17 | |
openstackgerrit | falseuser proposed openstack/nova master: Delete the instance files after revert a resize task https://review.openstack.org/469814 | 03:18 |
*** mdrabe has quit IRC | 03:20 | |
*** salv-orlando has quit IRC | 03:21 | |
*** dave-mccowan has quit IRC | 03:26 | |
*** mdrabe_ has quit IRC | 03:27 | |
*** coreywright has quit IRC | 03:31 | |
*** mingyu has quit IRC | 03:38 | |
*** mingyu has joined #openstack-nova | 03:38 | |
*** mingyu has quit IRC | 03:38 | |
*** kenperkins has joined #openstack-nova | 03:41 | |
*** mingyu has joined #openstack-nova | 03:44 | |
*** rfolco has quit IRC | 03:47 | |
*** hongbin has quit IRC | 03:48 | |
*** itlinux_ has joined #openstack-nova | 03:48 | |
*** coreywright has joined #openstack-nova | 03:48 | |
*** itlinux_ has quit IRC | 03:49 | |
*** zhurong has joined #openstack-nova | 03:49 | |
*** armax has quit IRC | 03:50 | |
*** itlinux_ has joined #openstack-nova | 03:54 | |
melwitt | git status | 03:55 |
melwitt | dangit. | 03:55 |
openstackgerrit | melanie witt proposed openstack/nova master: Add FixedIPList.get_count_by_project() https://review.openstack.org/446246 | 03:58 |
openstackgerrit | melanie witt proposed openstack/nova master: Add FloatingIPList.get_count_by_project() https://review.openstack.org/446247 | 03:58 |
openstackgerrit | melanie witt proposed openstack/nova master: Add get_count_by_vm_state() to InstanceList object https://review.openstack.org/446244 | 03:58 |
openstackgerrit | melanie witt proposed openstack/nova master: Add SecurityGroupList.get_counts() https://review.openstack.org/446245 | 03:58 |
openstackgerrit | melanie witt proposed openstack/nova master: Remove 'reserved' count from used limits https://review.openstack.org/446242 | 03:58 |
openstackgerrit | melanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage https://review.openstack.org/446243 | 03:58 |
openstackgerrit | melanie witt proposed openstack/nova master: Count networks to check quota https://review.openstack.org/446241 | 03:58 |
openstackgerrit | melanie witt proposed openstack/nova master: Count instances to check quota https://review.openstack.org/416521 | 03:58 |
openstackgerrit | melanie witt proposed openstack/nova master: Count server group members to check quota https://review.openstack.org/457859 | 03:58 |
openstackgerrit | melanie witt proposed openstack/nova master: Count security groups to check quota https://review.openstack.org/457860 | 03:58 |
openstackgerrit | melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945 | 03:58 |
openstackgerrit | melanie witt proposed openstack/nova master: Count fixed ips to check quota https://review.openstack.org/457861 | 03:58 |
openstackgerrit | melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946 | 03:58 |
openstackgerrit | melanie witt proposed openstack/nova master: Count floating ips to check quota https://review.openstack.org/457862 | 03:58 |
*** diga has joined #openstack-nova | 03:58 | |
*** gcb has quit IRC | 03:58 | |
*** itlinux_ has quit IRC | 03:59 | |
*** baoli has joined #openstack-nova | 04:00 | |
*** bkopilov has joined #openstack-nova | 04:00 | |
openstackgerrit | falseuser proposed openstack/nova master: Clear instance root_device_name in rebuild operation https://review.openstack.org/464991 | 04:04 |
*** esberglu has joined #openstack-nova | 04:04 | |
*** mingyu has quit IRC | 04:05 | |
*** baoli has quit IRC | 04:06 | |
*** itlinux has joined #openstack-nova | 04:06 | |
*** zz_dimtruck is now known as dimtruck | 04:08 | |
*** esberglu has quit IRC | 04:09 | |
*** psachin has joined #openstack-nova | 04:09 | |
*** mingyu has joined #openstack-nova | 04:10 | |
*** ratailor has joined #openstack-nova | 04:10 | |
*** thorst_afk has joined #openstack-nova | 04:11 | |
openstackgerrit | falseuser proposed openstack/nova master: Add img_linked_clone support in libvirt https://review.openstack.org/473362 | 04:14 |
*** mingyu has quit IRC | 04:15 | |
*** zerda3 has joined #openstack-nova | 04:16 | |
*** yamahata has joined #openstack-nova | 04:20 | |
*** dimtruck is now known as zz_dimtruck | 04:21 | |
*** mdrabe has joined #openstack-nova | 04:23 | |
openstackgerrit | melanie witt proposed openstack/nova master: placement project_id, user_id in PUT /allocations https://review.openstack.org/469634 | 04:25 |
openstackgerrit | melanie witt proposed openstack/nova master: placement: Add GET /usages to placement API https://review.openstack.org/469635 | 04:25 |
*** zhurong has quit IRC | 04:27 | |
*** thorst_afk has quit IRC | 04:30 | |
*** links has joined #openstack-nova | 04:32 | |
*** zhurong has joined #openstack-nova | 04:33 | |
*** mdrabe has quit IRC | 04:35 | |
*** zerda3 has quit IRC | 04:40 | |
*** kenperkins has quit IRC | 04:41 | |
*** adisky__ has joined #openstack-nova | 04:42 | |
*** bkopilov has quit IRC | 04:43 | |
*** salv-orlando has joined #openstack-nova | 04:43 | |
openstackgerrit | Ngo Quoc Cuong proposed openstack/nova master: Remove translation of log messages https://review.openstack.org/467948 | 04:46 |
*** gyee has quit IRC | 04:47 | |
openstackgerrit | falseuser proposed openstack/nova master: [BugFix] Include the video ram when comparing the difference of two flavors https://review.openstack.org/460388 | 04:49 |
*** mvpnitesh has joined #openstack-nova | 04:50 | |
*** udesale has joined #openstack-nova | 04:52 | |
*** itlinux has quit IRC | 04:54 | |
*** dikonoor has joined #openstack-nova | 04:56 | |
openstackgerrit | Huan Xie proposed openstack/nova master: XenAPI: Create linux bridge in dest host during live migration https://review.openstack.org/462017 | 04:56 |
*** oanson has quit IRC | 04:59 | |
*** oanson_ has joined #openstack-nova | 04:59 | |
*** dikonoo has quit IRC | 04:59 | |
*** dikonoo has joined #openstack-nova | 04:59 | |
*** oanson_ is now known as oanson | 04:59 | |
*** dikonoor has quit IRC | 05:01 | |
*** salv-orl_ has joined #openstack-nova | 05:03 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: cached images should be cleaned up by time https://review.openstack.org/465954 | 05:03 |
*** salv-orlando has quit IRC | 05:05 | |
*** cfriesen has quit IRC | 05:05 | |
*** acormier has quit IRC | 05:06 | |
*** acormier has joined #openstack-nova | 05:06 | |
*** slaweq has joined #openstack-nova | 05:08 | |
*** slaweq has quit IRC | 05:08 | |
openstackgerrit | falseuser proposed openstack/nova master: [BugFix] Change the condition to delete a resizing instance https://review.openstack.org/463466 | 05:10 |
*** acormier has quit IRC | 05:10 | |
*** bkopilov has joined #openstack-nova | 05:10 | |
*** sree has joined #openstack-nova | 05:11 | |
*** dikonoor has joined #openstack-nova | 05:12 | |
*** dikonoo has quit IRC | 05:14 | |
*** kornicameister has quit IRC | 05:17 | |
*** vks1 has joined #openstack-nova | 05:19 | |
*** bkopilov has quit IRC | 05:23 | |
*** gouthamr has quit IRC | 05:23 | |
*** amotoki_away is now known as amotoki | 05:27 | |
*** gcb has joined #openstack-nova | 05:30 | |
*** jwcroppe_ has joined #openstack-nova | 05:31 | |
*** jwcroppe has quit IRC | 05:32 | |
*** krtaylor has quit IRC | 05:33 | |
*** ekuris has joined #openstack-nova | 05:34 | |
*** efried has quit IRC | 05:34 | |
*** esberglu has joined #openstack-nova | 05:34 | |
*** gszasz has joined #openstack-nova | 05:36 | |
*** slaweq has joined #openstack-nova | 05:36 | |
*** bkopilov has joined #openstack-nova | 05:36 | |
*** esberglu has quit IRC | 05:38 | |
melwitt | alex_xu: hey, just saw your review comment about the status code 406. I thought because of the trace you showed earlier, it would be 400? http://logs.openstack.org/34/469634/12/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/56d8abe/logs/screen-n-cpu.txt.gz#_Jun_12_22_00_17_707953 | 05:41 |
openstackgerrit | Naichuan Sun proposed openstack/nova master: XenAPI: device tagging https://review.openstack.org/333781 | 05:41 |
*** slaweq has quit IRC | 05:41 | |
alex_xu | melwitt: that 400 is for user_id and project_id doesn't know by the old API. If we request a microversion, the api server doesn't know, the 406 will returned | 05:42 |
melwitt | alex_xu: ah, gotcha. thanks | 05:43 |
alex_xu | melwitt: np | 05:43 |
alex_xu | melwitt: an example https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L718 | 05:44 |
melwitt | cool, thank you | 05:45 |
alex_xu | yw | 05:45 |
*** gcb has quit IRC | 05:46 | |
*** gcb has joined #openstack-nova | 05:46 | |
*** efried has joined #openstack-nova | 05:50 | |
*** krtaylor has joined #openstack-nova | 05:51 | |
*** mamandle has joined #openstack-nova | 05:54 | |
*** zz_dimtruck is now known as dimtruck | 05:56 | |
*** edmondsw has joined #openstack-nova | 05:56 | |
*** mingyu has joined #openstack-nova | 05:56 | |
openstackgerrit | Ngo Quoc Cuong proposed openstack/nova master: Remove translation of log messages https://review.openstack.org/466637 | 06:01 |
*** edmondsw has quit IRC | 06:01 | |
*** baoli has joined #openstack-nova | 06:03 | |
*** rcernin has joined #openstack-nova | 06:05 | |
*** dimtruck is now known as zz_dimtruck | 06:05 | |
*** pcaruana has joined #openstack-nova | 06:06 | |
*** mingyu has quit IRC | 06:07 | |
*** baoli has quit IRC | 06:08 | |
*** hferenc has joined #openstack-nova | 06:09 | |
*** mingyu has joined #openstack-nova | 06:09 | |
*** andreas_s has joined #openstack-nova | 06:12 | |
*** CristinaPauna has quit IRC | 06:13 | |
*** Oku_OS-away is now known as Oku_OS | 06:13 | |
openstackgerrit | melanie witt proposed openstack/nova master: placement project_id, user_id in PUT /allocations https://review.openstack.org/469634 | 06:13 |
openstackgerrit | melanie witt proposed openstack/nova master: placement: Add GET /usages to placement API https://review.openstack.org/469635 | 06:13 |
*** kornicameister has joined #openstack-nova | 06:15 | |
*** ltomasbo|away is now known as ltomasbo | 06:17 | |
*** mvpnitesh has quit IRC | 06:20 | |
*** mvpnitesh has joined #openstack-nova | 06:20 | |
*** mingyu has quit IRC | 06:23 | |
*** markvoelker has quit IRC | 06:25 | |
*** thorst_afk has joined #openstack-nova | 06:27 | |
*** mingyu has joined #openstack-nova | 06:28 | |
*** thorst_afk has quit IRC | 06:32 | |
*** sree has quit IRC | 06:34 | |
*** sree has joined #openstack-nova | 06:35 | |
*** roeyc has joined #openstack-nova | 06:36 | |
*** slaweq has joined #openstack-nova | 06:37 | |
*** sree has quit IRC | 06:38 | |
*** sree has joined #openstack-nova | 06:38 | |
*** tesseract has joined #openstack-nova | 06:41 | |
*** slaweq has quit IRC | 06:42 | |
*** salv-orl_ has quit IRC | 06:45 | |
*** salv-orlando has joined #openstack-nova | 06:46 | |
*** markus_z has joined #openstack-nova | 06:49 | |
*** roeyc has quit IRC | 06:51 | |
*** zz_dimtruck is now known as dimtruck | 06:56 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | 06:57 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483 | 07:01 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add host/binary request query filter parameters for GET /os-services API https://review.openstack.org/473708 | 07:02 |
*** baoli has joined #openstack-nova | 07:04 | |
*** salv-orlando has quit IRC | 07:05 | |
*** salv-orlando has joined #openstack-nova | 07:05 | |
*** dimtruck is now known as zz_dimtruck | 07:06 | |
*** rmart04 has joined #openstack-nova | 07:07 | |
*** baoli has quit IRC | 07:08 | |
*** damien_r has joined #openstack-nova | 07:13 | |
*** rmart04 has quit IRC | 07:17 | |
*** jaosorior_away is now known as jaosorior | 07:18 | |
*** esberglu has joined #openstack-nova | 07:22 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add host/binary request query filter parameters for GET /os-services API https://review.openstack.org/473708 | 07:25 |
*** esberglu has quit IRC | 07:26 | |
*** thorst_afk has joined #openstack-nova | 07:28 | |
*** qwertyco has joined #openstack-nova | 07:30 | |
*** roeyc has joined #openstack-nova | 07:31 | |
*** jpena|off is now known as jpena | 07:31 | |
*** thorst_afk has quit IRC | 07:32 | |
*** yamahata has quit IRC | 07:33 | |
*** pewp has quit IRC | 07:34 | |
*** pewp has joined #openstack-nova | 07:37 | |
*** fragatina has joined #openstack-nova | 07:37 | |
*** priteau has joined #openstack-nova | 07:38 | |
*** sridharg has quit IRC | 07:39 | |
*** tojuvone has quit IRC | 07:41 | |
*** tojuvone has joined #openstack-nova | 07:41 | |
*** mingyu has quit IRC | 07:41 | |
*** qwertyco has quit IRC | 07:43 | |
*** CristinaPauna has joined #openstack-nova | 07:45 | |
*** ralonsoh has joined #openstack-nova | 07:45 | |
*** gomarivera has joined #openstack-nova | 07:51 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: cached images should be cleaned up by time https://review.openstack.org/465954 | 07:52 |
*** sridharg has joined #openstack-nova | 07:52 | |
*** zhurong has quit IRC | 07:55 | |
*** gomarivera has quit IRC | 07:56 | |
*** sridharg has quit IRC | 07:56 | |
*** zz_dimtruck is now known as dimtruck | 07:57 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800 | 07:57 |
*** qwertyco has joined #openstack-nova | 07:58 | |
*** sridharg has joined #openstack-nova | 07:58 | |
*** karimb has joined #openstack-nova | 07:58 | |
*** zzzeek has quit IRC | 08:00 | |
*** ltomasbo is now known as ltomasbo|away | 08:00 | |
*** zzzeek has joined #openstack-nova | 08:00 | |
openstackgerrit | falseuser proposed openstack/nova master: Ensure the root device will be replaced in rebuild operation https://review.openstack.org/467588 | 08:03 |
*** alexchadin has joined #openstack-nova | 08:06 | |
*** mingyu has joined #openstack-nova | 08:07 | |
*** aarefiev_afk is now known as aarefiev | 08:07 | |
*** dimtruck is now known as zz_dimtruck | 08:09 | |
*** kornicameister has quit IRC | 08:10 | |
*** mvpnitesh has quit IRC | 08:12 | |
*** yingjun_1 has joined #openstack-nova | 08:12 | |
*** lucas-afk is now known as lucasagomes | 08:17 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add missing query filter params for GET /os-services API https://review.openstack.org/473708 | 08:19 |
*** ltomasbo|away is now known as ltomasbo | 08:23 | |
*** markvoelker has joined #openstack-nova | 08:26 | |
*** mingyu has quit IRC | 08:26 | |
*** f10d4 has joined #openstack-nova | 08:27 | |
f10d4 | hi | 08:27 |
f10d4 | gibi: szia | 08:27 |
bauzas | p!spy | 08:27 |
*** mingyu has joined #openstack-nova | 08:28 | |
*** thorst_afk has joined #openstack-nova | 08:29 | |
*** yamamoto has quit IRC | 08:30 | |
*** karimb has quit IRC | 08:31 | |
*** thorst_afk has quit IRC | 08:33 | |
*** kwathore has quit IRC | 08:35 | |
*** yamamoto has joined #openstack-nova | 08:35 | |
*** mingyu has quit IRC | 08:40 | |
*** dtantsur|afk is now known as dtantsur | 08:40 | |
*** kwathore has joined #openstack-nova | 08:43 | |
*** derekh has joined #openstack-nova | 08:47 | |
gibi | f10d4: szia | 08:48 |
*** mingyu has joined #openstack-nova | 08:50 | |
*** claudiub|2 has joined #openstack-nova | 08:52 | |
*** ltomasbo is now known as ltomasbo|away | 08:52 | |
*** sambetts|afk is now known as sambetts | 08:54 | |
*** karimb has joined #openstack-nova | 08:59 | |
*** markvoelker has quit IRC | 08:59 | |
*** zz_dimtruck is now known as dimtruck | 09:00 | |
*** mingyu has quit IRC | 09:01 | |
*** rmart04 has joined #openstack-nova | 09:03 | |
*** vks1 has quit IRC | 09:05 | |
*** zhurong has joined #openstack-nova | 09:06 | |
*** dimtruck is now known as zz_dimtruck | 09:10 | |
*** esberglu has joined #openstack-nova | 09:10 | |
*** efoley has joined #openstack-nova | 09:12 | |
*** esberglu has quit IRC | 09:14 | |
openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.resize_prep notification https://review.openstack.org/465081 | 09:15 |
*** priteau has quit IRC | 09:16 | |
*** yamamoto has quit IRC | 09:19 | |
*** dgonzalez_ has joined #openstack-nova | 09:21 | |
*** david_ has joined #openstack-nova | 09:21 | |
*** tpatzig_ has joined #openstack-nova | 09:21 | |
*** david_ has quit IRC | 09:23 | |
*** dgonzalez_ has quit IRC | 09:23 | |
*** tpatzig_ has quit IRC | 09:23 | |
*** karimb has quit IRC | 09:25 | |
*** thorst_afk has joined #openstack-nova | 09:29 | |
*** Shunli has quit IRC | 09:30 | |
*** edmondsw has joined #openstack-nova | 09:32 | |
*** mvk has joined #openstack-nova | 09:33 | |
*** alexchadin has quit IRC | 09:36 | |
*** yamamoto has joined #openstack-nova | 09:36 | |
*** edmondsw has quit IRC | 09:37 | |
*** yamamoto has quit IRC | 09:37 | |
*** mvpnitesh has joined #openstack-nova | 09:38 | |
*** karimb has joined #openstack-nova | 09:39 | |
*** yingjun_1 has quit IRC | 09:40 | |
*** takashin has left #openstack-nova | 09:41 | |
*** sridharg has quit IRC | 09:43 | |
*** sridharg has joined #openstack-nova | 09:43 | |
*** jichen has quit IRC | 09:46 | |
*** mvpnitesh has quit IRC | 09:46 | |
*** mvpnitesh has joined #openstack-nova | 09:46 | |
*** kornicameister has joined #openstack-nova | 09:47 | |
*** thorst_afk has quit IRC | 09:49 | |
*** mdnadeem has quit IRC | 09:51 | |
*** yamamoto has joined #openstack-nova | 09:54 | |
*** damien_r has quit IRC | 09:55 | |
*** ayogi has joined #openstack-nova | 09:56 | |
*** markvoelker has joined #openstack-nova | 09:57 | |
*** alexchadin has joined #openstack-nova | 09:57 | |
*** dtantsur is now known as dtantsur|brb | 09:58 | |
*** tovin07_ has quit IRC | 09:59 | |
*** cdent has joined #openstack-nova | 09:59 | |
*** zz_dimtruck is now known as dimtruck | 10:00 | |
*** mingyu has joined #openstack-nova | 10:01 | |
*** lpetrut has joined #openstack-nova | 10:01 | |
*** mvpnitesh has quit IRC | 10:04 | |
*** mvpnitesh has joined #openstack-nova | 10:04 | |
*** mingyu has quit IRC | 10:06 | |
*** baoli has joined #openstack-nova | 10:07 | |
*** cNilesh has quit IRC | 10:08 | |
*** liujiong has quit IRC | 10:09 | |
*** dimtruck is now known as zz_dimtruck | 10:10 | |
*** baoli has quit IRC | 10:12 | |
*** Alex_____ has joined #openstack-nova | 10:12 | |
*** ratailor has quit IRC | 10:14 | |
*** zhurong has quit IRC | 10:20 | |
*** kwathore_ has joined #openstack-nova | 10:21 | |
*** kwathore has quit IRC | 10:21 | |
*** oanson has quit IRC | 10:21 | |
*** phuongnh has quit IRC | 10:22 | |
*** yamamoto has quit IRC | 10:23 | |
*** oanson has joined #openstack-nova | 10:24 | |
*** ratailor has joined #openstack-nova | 10:27 | |
*** markvoelker has quit IRC | 10:30 | |
*** smatzek has joined #openstack-nova | 10:30 | |
openstackgerrit | Pooja Jadhav proposed openstack/nova master: Nova flavor-list swap should be 0 when no value is specified https://review.openstack.org/471715 | 10:31 |
*** huanxie has quit IRC | 10:31 | |
openstackgerrit | falseuser proposed openstack/nova master: Ensure the root device will be replaced in rebuild operation https://review.openstack.org/467588 | 10:37 |
*** smatzek has quit IRC | 10:42 | |
*** zhurong has joined #openstack-nova | 10:43 | |
*** slaweq has joined #openstack-nova | 10:43 | |
*** thorst_afk has joined #openstack-nova | 10:46 | |
johnthetubaguy | bauzas: did you ever take a look at this cold migrate patches? https://review.openstack.org/#/c/408955 | 10:47 |
johnthetubaguy | bauzas: super related to the live-migrate work you did | 10:47 |
*** slaweq has quit IRC | 10:48 | |
*** sdague has joined #openstack-nova | 10:49 | |
*** thorst_afk has quit IRC | 10:50 | |
*** cdent has quit IRC | 10:51 | |
*** bkopilov has quit IRC | 10:52 | |
*** dtantsur|brb is now known as dtantsur | 10:53 | |
*** yamamoto has joined #openstack-nova | 10:57 | |
*** esberglu has joined #openstack-nova | 10:58 | |
mdbooth | Very quickly, before I knock up a quick script to create some default flavors, network, and cirros glance image, does this already exist in a re-usable form? | 11:01 |
*** zz_dimtruck is now known as dimtruck | 11:01 | |
*** esberglu has quit IRC | 11:03 | |
*** salv-orl_ has joined #openstack-nova | 11:03 | |
*** ltomasbo|away is now known as ltomasbo | 11:05 | |
*** salv-orlando has quit IRC | 11:06 | |
*** lucasagomes is now known as lucas-hungry | 11:08 | |
*** vladikr has joined #openstack-nova | 11:10 | |
*** dimtruck is now known as zz_dimtruck | 11:11 | |
*** sree has quit IRC | 11:13 | |
*** sree has joined #openstack-nova | 11:13 | |
*** sree has quit IRC | 11:18 | |
*** ijw has joined #openstack-nova | 11:19 | |
kashyap | mdbooth: In a DevStack env? | 11:21 |
mdbooth | kashyap: In an openstack cloud | 11:21 |
* kashyap nods | 11:22 | |
mdbooth | Might be devstack, but isn't in my particular case | 11:22 |
kashyap | Hmm, not that I know of; but probably you might want to ask in #tripleo? | 11:23 |
*** ijw has quit IRC | 11:23 | |
kashyap | As they do this stuff fairly often, and may have the adhoc scripts to do such tasks | 11:23 |
*** BlackDex has quit IRC | 11:26 | |
*** udesale has quit IRC | 11:27 | |
*** markvoelker has joined #openstack-nova | 11:27 | |
*** BlackDex has joined #openstack-nova | 11:28 | |
*** dave-mccowan has joined #openstack-nova | 11:28 | |
*** gabor_antal has joined #openstack-nova | 11:28 | |
kashyap | mdbooth Oh, forgot, I normally use this to setup networking post DevStack install - https://kashyapc.fedorapeople.org/virt/openstack/Neutron-setup-post-DevStack.bash | 11:29 |
kashyap | It simply does the following: associates the router to the gateway; adds security group rules; and sets up floating IP | 11:30 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: remove ugly local import https://review.openstack.org/450787 | 11:30 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: remove get_nw_info_for_instance from compute.utils https://review.openstack.org/451387 | 11:30 |
*** Yangyapeng has quit IRC | 11:31 | |
*** yamamoto has quit IRC | 11:31 | |
*** sridharg has quit IRC | 11:33 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779 | 11:37 |
*** cdent has joined #openstack-nova | 11:38 | |
*** smatzek has joined #openstack-nova | 11:38 | |
*** alexchadin has quit IRC | 11:39 | |
*** alexchadin has joined #openstack-nova | 11:40 | |
*** alexchadin has quit IRC | 11:40 | |
*** alexchadin has joined #openstack-nova | 11:41 | |
*** alexchadin has quit IRC | 11:41 | |
*** alexchadin has joined #openstack-nova | 11:42 | |
*** alexchadin has quit IRC | 11:42 | |
*** alexchadin has joined #openstack-nova | 11:42 | |
*** alexchadin has quit IRC | 11:43 | |
*** alexchadin has joined #openstack-nova | 11:43 | |
*** alexchadin has quit IRC | 11:43 | |
*** gszasz has quit IRC | 11:44 | |
*** alexchadin has joined #openstack-nova | 11:44 | |
*** alexchadin has quit IRC | 11:44 | |
*** slaweq has joined #openstack-nova | 11:44 | |
*** diga has quit IRC | 11:44 | |
*** alexchadin has joined #openstack-nova | 11:45 | |
*** yamamoto has joined #openstack-nova | 11:46 | |
*** slaweq has quit IRC | 11:49 | |
*** alexchadin has quit IRC | 11:49 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/472814 | 11:50 |
*** yamamoto has quit IRC | 11:50 | |
*** zz_dimtruck is now known as dimtruck | 11:50 | |
*** pchavva has joined #openstack-nova | 11:51 | |
*** sridharg has joined #openstack-nova | 11:51 | |
*** d9k has quit IRC | 11:51 | |
*** thorst_afk has joined #openstack-nova | 11:52 | |
*** d9k has joined #openstack-nova | 11:53 | |
*** litao__ has quit IRC | 11:55 | |
*** jpena is now known as jpena|lunch | 11:55 | |
*** ratailor has quit IRC | 11:58 | |
*** karimb has quit IRC | 11:59 | |
*** markvoelker has quit IRC | 11:59 | |
*** Yangyapeng has joined #openstack-nova | 11:59 | |
*** jheroux has joined #openstack-nova | 12:00 | |
*** roeyc has quit IRC | 12:02 | |
*** damien_r has joined #openstack-nova | 12:03 | |
*** tuanluong has quit IRC | 12:04 | |
*** mamandle has quit IRC | 12:04 | |
*** ekuris has quit IRC | 12:05 | |
*** liverpooler has joined #openstack-nova | 12:06 | |
*** baoli has joined #openstack-nova | 12:08 | |
*** baoli has quit IRC | 12:13 | |
*** ratailor has joined #openstack-nova | 12:16 | |
*** jamesdenton has joined #openstack-nova | 12:16 | |
*** yamamoto has joined #openstack-nova | 12:16 | |
*** sridharg has quit IRC | 12:16 | |
*** pewp has quit IRC | 12:17 | |
*** openstackgerrit has quit IRC | 12:18 | |
*** lucas-hungry is now known as lucasagomes | 12:19 | |
*** pewp has joined #openstack-nova | 12:19 | |
*** Oku_OS is now known as Oku_OS-away | 12:19 | |
*** zhurong has quit IRC | 12:19 | |
*** yamamoto has quit IRC | 12:20 | |
*** cdent has quit IRC | 12:22 | |
*** ltomasbo is now known as ltomasbo|away | 12:22 | |
*** d9k has quit IRC | 12:23 | |
*** d9k has joined #openstack-nova | 12:24 | |
*** sridharg has joined #openstack-nova | 12:24 | |
*** markvoelker has joined #openstack-nova | 12:25 | |
*** Oku_OS-away is now known as Oku_OS | 12:26 | |
*** edmondsw has joined #openstack-nova | 12:26 | |
*** CristinaPauna has quit IRC | 12:30 | |
*** bkopilov has joined #openstack-nova | 12:31 | |
*** kwathore_ has quit IRC | 12:31 | |
bauzas | johnthetubaguy: sure, will look | 12:33 |
*** kwathore has joined #openstack-nova | 12:33 | |
*** catintheroof has joined #openstack-nova | 12:33 | |
*** karimb has joined #openstack-nova | 12:33 | |
*** cdent has joined #openstack-nova | 12:34 | |
*** gszasz has joined #openstack-nova | 12:45 | |
*** awaugama has joined #openstack-nova | 12:45 | |
*** slaweq has joined #openstack-nova | 12:45 | |
*** alexchadin has joined #openstack-nova | 12:45 | |
*** baoli has joined #openstack-nova | 12:46 | |
*** esberglu has joined #openstack-nova | 12:46 | |
*** baoli has quit IRC | 12:47 | |
*** baoli has joined #openstack-nova | 12:48 | |
*** alexchadin has quit IRC | 12:50 | |
*** rfolco has joined #openstack-nova | 12:50 | |
*** slaweq has quit IRC | 12:50 | |
*** lyan has joined #openstack-nova | 12:50 | |
*** Yangyapeng has quit IRC | 12:50 | |
*** esberglu has quit IRC | 12:51 | |
*** jdurgin has joined #openstack-nova | 12:53 | |
*** gomarivera has joined #openstack-nova | 12:54 | |
*** pkoniszewski has quit IRC | 12:54 | |
cdent | edleafe: are you planning to push to https://review.openstack.org/#/c/473627/ soon? if so I'll wait to review. your responses to dtantsur suggest yes-ish | 12:57 |
*** alexchadin has joined #openstack-nova | 12:57 | |
*** jpena|lunch is now known as jpena | 12:58 | |
*** gomarivera has quit IRC | 12:58 | |
*** esberglu has joined #openstack-nova | 13:00 | |
*** slaweq has joined #openstack-nova | 13:01 | |
*** yamamoto has joined #openstack-nova | 13:01 | |
*** openstackgerrit has joined #openstack-nova | 13:02 | |
openstackgerrit | Merged openstack/nova master: Add bool_from_string for force-down action https://review.openstack.org/473564 | 13:02 |
*** roeyc has joined #openstack-nova | 13:02 | |
mordred | cdent: I have found two new and interesting tidbits that don't seem to be reflected in nova's api docs | 13:03 |
cdent | mordred: I'd expect nothing less from you | 13:03 |
mordred | cdent: the first is that if you're booting from volume, you apparently need to POST to /os-volumes_boot instead of /servers (at least, that's what novaclient does) | 13:03 |
*** huanxie has joined #openstack-nova | 13:03 | |
sdague | mordred: that doesn't seem right | 13:04 |
mordred | cdent: the second is that if you are booting from an image but attaching volumes at boot via block_device_mapping, you need to pass the image in the block_device_mapping wiht a destination_type of local: | 13:04 |
mordred | https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L737-L745 | 13:04 |
cdent | mordred: you've used the two red flag terms: "boot from volume" and "bdm" | 13:04 |
mordred | sdague: https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L1424-L1431 | 13:05 |
mordred | sdague: if that's not needed, I'll happily change it in shade and send a patch for novaclient | 13:05 |
sdague | mordred: https://github.com/openstack/nova/blob/d3de541784b094e32cf66e1759fc73781f031607/nova/api/openstack/compute/routes.py#L303-L304 | 13:05 |
sdague | yeh, it looks like it's a route that was merged a long time ago | 13:05 |
mordred | awesome | 13:05 |
mordred | I'll send a novaclient patch | 13:05 |
*** slaweq has quit IRC | 13:06 | |
*** yamamoto has quit IRC | 13:06 | |
sdague | that warrents a pickaxe journey | 13:06 |
edleafe | cdent: yeah, just running tests before pushing | 13:07 |
cdent | don't forget your headlamp | 13:07 |
cdent | edleafe: ✔ | 13:07 |
*** gbarros has joined #openstack-nova | 13:07 | |
cdent | mordred: so the concern on the second point is that there's some magical fiddling that's being done in novaclient (and is required to get proper behavior) but the docs don't say so? | 13:08 |
openstackgerrit | Monty Taylor proposed openstack/python-novaclient master: Stop posting to os-volumes_boot https://review.openstack.org/473833 | 13:08 |
mordred | cdent: yes. it's not bad behavior - in fact, it makes total sense | 13:09 |
*** dimtruck is now known as zz_dimtruck | 13:09 | |
mordred | but it was surprising to me | 13:09 |
*** mdrabe has joined #openstack-nova | 13:09 | |
mordred | I'm not sure the BEST way to document that though | 13:09 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Extract custom resource classes from flavors https://review.openstack.org/473627 | 13:09 |
edleafe | cdent: dtantsur: ^^ | 13:10 |
*** eharney has joined #openstack-nova | 13:10 | |
dtantsur | thanks! will get back to it after the meeting(s) | 13:10 |
cdent | mordred: start with BETTER and then maybe BEST will reveal itself? | 13:10 |
*** xyang1 has joined #openstack-nova | 13:10 | |
*** huanxie has quit IRC | 13:11 | |
mordred | cdent: you're trying to entice me to document block_device_mapping comprehensively, I can feel it | 13:11 |
*** awaugama has quit IRC | 13:11 | |
* edleafe eggs mordred on too | 13:11 | |
cdent | I wouldn't want to get in the way of your feelings | 13:11 |
sdague | mordred: it definitely started off as a whole different extension - https://github.com/openstack/nova/commit/97503418bea47ca38d2181e5dc5fa710d6e15df3 | 13:11 |
sdague | I'm still having trouble figuring out where it merged | 13:12 |
*** ekuris has joined #openstack-nova | 13:12 | |
openstackgerrit | Feodor Tersin proposed openstack/nova master: POC: Imagebackend - on cold migration https://review.openstack.org/473835 | 13:12 |
ftersin | mdbooth: hi. i tried to refactor that code partially. ^^^^ | 13:13 |
ftersin | mdbooth: but... this is still inconsistent, does not look correct, and requires much more refactoring | 13:15 |
ftersin | mdbooth: so... i have to admit that i've gave up. i do not know how to do there 'not a big one' refactoring | 13:16 |
ftersin | mdbooth: if you have other idea, pls, suggest me smth | 13:17 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/472814 | 13:17 |
mdbooth | ftersin: In a meeting, will try to look today. | 13:17 |
*** lucasxu has joined #openstack-nova | 13:18 | |
*** CristinaPauna has joined #openstack-nova | 13:18 | |
*** dikonoo has joined #openstack-nova | 13:18 | |
*** mdrabe has quit IRC | 13:19 | |
ftersin | mdbooth: ok, thx | 13:19 |
*** dikonoo has quit IRC | 13:20 | |
*** mdrabe has joined #openstack-nova | 13:20 | |
*** cleong has joined #openstack-nova | 13:21 | |
openstackgerrit | Feodor Tersin proposed openstack/nova master: Implement ScaleIO image backend https://review.openstack.org/407440 | 13:21 |
*** mvpnitesh has quit IRC | 13:22 | |
*** dikonoor has quit IRC | 13:22 | |
*** mriedem has joined #openstack-nova | 13:23 | |
*** jwcroppe_ has quit IRC | 13:23 | |
*** Apoorva has joined #openstack-nova | 13:24 | |
*** ratailor has quit IRC | 13:25 | |
mriedem | efried: is this done now, the services tokens series https://review.openstack.org/#/q/topic:bp/use-service-tokens | 13:27 |
mriedem | all that's left is dnm testing patches | 13:27 |
efried | mriedem I believe it is, but was hoping someone else could verify | 13:27 |
efried | Put another way, you beat me to the question ;-) | 13:28 |
mriedem | based on the work items in the spec https://review.openstack.org/#/c/426933/5/specs/pike/approved/use-service-tokens.rst@166 i'd say it's done | 13:29 |
mriedem | actually | 13:30 |
mriedem | do we actually send the service user tokens with glance requestes? | 13:30 |
mriedem | *requests | 13:30 |
efried | mriedem I believe by virtue of https://review.openstack.org/#/c/419662/ | 13:31 |
mriedem | ah, the topic was different so i missed that one | 13:32 |
efried | Yeah. | 13:32 |
*** jaosorior has quit IRC | 13:32 | |
*** jaosorior has joined #openstack-nova | 13:32 | |
efried | mriedem I'm not going to be able to abandon the DNMs, cause I don't own 'em. Is that something you have the power to do? | 13:32 |
mriedem | i can do that | 13:32 |
efried | Cool cool. | 13:33 |
*** links has quit IRC | 13:33 | |
*** jianghuaw_ has joined #openstack-nova | 13:33 | |
mriedem | sdague: want to abandon this? https://review.openstack.org/#/c/416733/ | 13:34 |
sdague | mriedem: looking | 13:35 |
*** clayton has quit IRC | 13:35 | |
sdague | sure | 13:35 |
sdague | did we run a test to make sure this was all working as expected? | 13:35 |
*** psachin has quit IRC | 13:35 | |
mriedem | sdague: it's enabled in the nova-next job | 13:36 |
sdague | mriedem: right, but unless you tune down the timeouts | 13:36 |
sdague | you aren't going to hit it in a gate job | 13:36 |
mriedem | that's what the abandoned nova dnm patches were for | 13:36 |
*** gouthamr has joined #openstack-nova | 13:36 | |
sdague | ok, sure | 13:36 |
mriedem | they enabled it and did a long sleep during something like live migration | 13:36 |
sdague | ok, sounds good | 13:36 |
*** clayton has joined #openstack-nova | 13:37 | |
*** jwcroppe has joined #openstack-nova | 13:37 | |
*** jaypipes has joined #openstack-nova | 13:38 | |
*** gomarivera has joined #openstack-nova | 13:39 | |
*** fragatina has quit IRC | 13:39 | |
*** fragatina has joined #openstack-nova | 13:40 | |
*** jianghuaw_ has quit IRC | 13:43 | |
*** jamesden_ has joined #openstack-nova | 13:44 | |
*** jamesdenton has quit IRC | 13:45 | |
*** jianghuaw_ has joined #openstack-nova | 13:46 | |
*** roeyc has quit IRC | 13:46 | |
openstackgerrit | Béla Vancsics proposed openstack/nova master: Reduced the complexity of the _init_instance method https://review.openstack.org/374661 | 13:47 |
*** Apoorva has quit IRC | 13:48 | |
*** cdent has quit IRC | 13:51 | |
*** abalutoiu has joined #openstack-nova | 13:52 | |
*** eharney has quit IRC | 13:52 | |
*** vks1 has joined #openstack-nova | 13:56 | |
*** sree has joined #openstack-nova | 13:56 | |
*** karimb has quit IRC | 13:56 | |
*** eharney has joined #openstack-nova | 13:56 | |
*** karimb has joined #openstack-nova | 13:57 | |
*** roeyc has joined #openstack-nova | 14:00 | |
*** tbachman has joined #openstack-nova | 14:01 | |
*** tidwellr has joined #openstack-nova | 14:01 | |
*** slaweq has joined #openstack-nova | 14:02 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Use plain routes list for user_data instead of stevedore https://review.openstack.org/462183 | 14:04 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Use plain routes list for os-server-groups endpoint instead of stevedore https://review.openstack.org/462169 | 14:04 |
*** zz_dimtruck is now known as dimtruck | 14:05 | |
openstackgerrit | Mathieu Gagné proposed openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322 | 14:06 |
*** slaweq has quit IRC | 14:06 | |
*** armax has joined #openstack-nova | 14:08 | |
mriedem | bauzas: the change on master is merged for https://review.openstack.org/#/c/472687/ if you want to get that in, then we can do an ocata release | 14:10 |
bauzas | mriedem: easy peasy | 14:10 |
*** roeyc has quit IRC | 14:10 | |
*** felipemonteiro_ has joined #openstack-nova | 14:15 | |
*** felipemonteiro__ has joined #openstack-nova | 14:17 | |
*** awaugama has joined #openstack-nova | 14:18 | |
*** jamesden_ has quit IRC | 14:18 | |
*** felipemonteiro_ has quit IRC | 14:21 | |
*** jamesdenton has joined #openstack-nova | 14:21 | |
*** itlinux_ has joined #openstack-nova | 14:22 | |
*** kenperkins has joined #openstack-nova | 14:26 | |
*** acormier has joined #openstack-nova | 14:26 | |
*** yamamoto has joined #openstack-nova | 14:26 | |
*** cfriesen has joined #openstack-nova | 14:26 | |
*** ekuris has quit IRC | 14:27 | |
*** roeyc has joined #openstack-nova | 14:28 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Glance download: only fsync files https://review.openstack.org/451094 | 14:28 |
*** kwathore has quit IRC | 14:28 | |
dansmith | sdague: so this is passing a canary from the nova side: https://review.openstack.org/#/c/436094/ | 14:29 |
*** qwertyco has quit IRC | 14:29 | |
dansmith | sdague: would appreciate it if you'd take another pass through that to see if we can get that landed soonlyish | 14:29 |
*** ericyoung has joined #openstack-nova | 14:30 | |
*** kenperkins has quit IRC | 14:30 | |
*** roeyc has quit IRC | 14:31 | |
*** sree_ has joined #openstack-nova | 14:31 | |
*** roeyc has joined #openstack-nova | 14:32 | |
*** sree_ is now known as Guest86005 | 14:32 | |
*** yamamoto has quit IRC | 14:32 | |
*** sree has quit IRC | 14:32 | |
*** Guest6511 is now known as med_ | 14:32 | |
*** med_ has quit IRC | 14:32 | |
*** med_ has joined #openstack-nova | 14:32 | |
*** mdrabe has quit IRC | 14:35 | |
*** felipemonteiro__ has quit IRC | 14:35 | |
*** alexchadin has quit IRC | 14:35 | |
edmondsw | mriedem sdague I think one of you had reminded us about adding powervm to the support matrix... we've got that change up for review: https://review.openstack.org/#/c/470999/ | 14:38 |
mriedem | yeah i did, just need to get some free time | 14:39 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle uuid in HostAPI.compute_node_get https://review.openstack.org/461532 | 14:39 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Handle uuids in os-hypervisors API https://review.openstack.org/471899 | 14:39 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Use uuid for id in Services API https://review.openstack.org/464280 | 14:39 |
*** hongbin has joined #openstack-nova | 14:39 | |
*** jdurgin has quit IRC | 14:39 | |
sdague | dansmith: the grenade bit is already in? (i can't remember) | 14:40 |
dansmith | sdague: yar | 14:40 |
dansmith | sdague: no depends-on for that patch, and just a canary that depends-on it for testing | 14:40 |
dansmith | sdague: https://review.openstack.org/#/c/473565/ | 14:40 |
dansmith | canary ^ | 14:40 |
*** mdrabe has joined #openstack-nova | 14:41 | |
dansmith | sdague: if you think we need a canary against any other project let me know.. I don't really know what other sorts of complicated jobs we have in other places that might be affected | 14:41 |
sdague | I think it's probably fine | 14:41 |
*** itlinux_ has quit IRC | 14:41 | |
dansmith | cool | 14:42 |
openstackgerrit | Béla Vancsics proposed openstack/nova master: Reduced the complexity of the _init_instance method (2) https://review.openstack.org/420619 | 14:42 |
mriedem | dansmith: i see an issue in the ironic tinyipa job in there http://logs.openstack.org/94/436094/35/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/1df37be/logs/devstacklog.txt.gz#_2017-06-12_20_26_29_362 | 14:42 |
mriedem | but that might just already be busted | 14:43 |
mriedem | actually, | 14:44 |
mriedem | it only fails that way on that devstack change and the canary patch | 14:44 |
mriedem | so it's likely an issue from that setup | 14:44 |
mriedem | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Timed%20out%20waiting%20for%20Nova%20hypervisor-stats%20count%20%3E%3D%201%5C%22%20AND%20tags%3A%5C%22console%5C%22&from=7d | 14:45 |
*** jdurgin has joined #openstack-nova | 14:45 | |
dansmith | ah, yeah, hmm | 14:45 |
dansmith | host discovery maybe? | 14:45 |
mriedem | that'd be my guess | 14:46 |
mriedem | dtantsur: are you around? | 14:46 |
dtantsur | mriedem: hi, I am | 14:46 |
mriedem | dtantsur: we're trying to sort out http://logs.openstack.org/94/436094/35/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/1df37be/logs/devstacklog.txt.gz#_2017-06-12_20_26_29_362 | 14:46 |
mriedem | that job is timing out waiting for hypervisor stats to show up, | 14:47 |
dtantsur | I'm on a meeting, but will try to look | 14:47 |
mriedem | and are wondering if it's not doing proper host discovery | 14:47 |
mriedem | thanks | 14:47 |
dtantsur | what's the patch? | 14:47 |
mriedem | https://review.openstack.org/#/c/436094/35 | 14:47 |
mriedem | it's a devstack patch that gets us to multiple cells testing | 14:47 |
mriedem | with 2 levels of nova conductor | 14:47 |
mriedem | one in the top level controller node, and one in each cell | 14:47 |
mriedem | dansmith: ^ is that accurate? | 14:48 |
dtantsur | hmm, I wonder how this all works with ironic | 14:48 |
dansmith | mriedem: the two levels thing doesn't really matter to him, but yeah | 14:48 |
dansmith | mriedem: dtantsur I'm poking through lib/ironic now | 14:49 |
mriedem | i see cell1 created here http://logs.openstack.org/94/436094/35/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/1df37be/logs/devstacklog.txt.gz#_2017-06-12_20_10_32_098 | 14:49 |
dtantsur | I think what we do, or at least what we used to do, is to restart nova-compute for some reason | 14:50 |
mriedem | this isn't a multinode job, so it should just be a single cell right? | 14:50 |
dtantsur | not sure if it's related | 14:50 |
mriedem | i'm not seeing simple_cell_setup or discover_hosts run anywhere in the devstack log | 14:50 |
*** jianghuaw_ has quit IRC | 14:51 | |
dtantsur | we don't seem to run it indeed.. | 14:51 |
dtantsur | but then we would break long ago, no? | 14:51 |
mriedem | dansmith: keep in mind they have an ironic devstack plugin https://github.com/openstack/ironic/tree/master/devstack | 14:52 |
dansmith | mriedem: right | 14:52 |
dansmith | mriedem: just pushed a change | 14:52 |
dansmith | https://review.openstack.org/473868 | 14:52 |
dtantsur | thanks dansmith, let's try this | 14:52 |
mriedem | s/.///? in there? | 14:53 |
dtantsur | to be honest, I have hard time understanding the recent changes around cells, etc.. | 14:53 |
dansmith | gah yes | 14:53 |
*** claudiub|2 has quit IRC | 14:53 | |
dansmith | mriedem: fixed | 14:53 |
dtantsur | dansmith: shouldn't the dependency be the other way around? i.e. the devstack patch to depend on the ironic change? | 14:54 |
mriedem | yes | 14:54 |
mriedem | i'm also not sure how any of the ironic jobs have worked w/o discovering the hosts by now | 14:55 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: use context mgr in instance.delete https://review.openstack.org/443764 | 14:55 |
mriedem | since ocata | 14:55 |
dtantsur | this is what I wonder as well | 14:55 |
dtantsur | we had to do it in tripleo | 14:55 |
*** karimb has quit IRC | 14:55 | |
dansmith | dtantsur: not for testing | 14:56 |
*** roeyc has quit IRC | 14:56 | |
dansmith | dtantsur: I'll swap the order when this shows the job working on this patch | 14:56 |
dtantsur | ack | 14:57 |
*** armax has quit IRC | 14:57 | |
*** karimb has joined #openstack-nova | 14:57 | |
*** armax has joined #openstack-nova | 14:59 | |
*** danpawlik is now known as _danpawlik | 15:02 | |
*** claudiub|2 has joined #openstack-nova | 15:02 | |
*** slaweq has joined #openstack-nova | 15:03 | |
*** huanxie has joined #openstack-nova | 15:03 | |
*** Alex_____ has quit IRC | 15:04 | |
*** cdent has joined #openstack-nova | 15:04 | |
mriedem | this is what normally runs discover_hosts https://github.com/openstack-dev/devstack/blob/master/stack.sh#L1412 | 15:05 |
mriedem | maybe the ironic thing happens before that? | 15:05 |
openstackgerrit | Vladyslav Drok proposed openstack/nova master: Remove only compute ports in deallocate_for_instance https://review.openstack.org/473873 | 15:05 |
dansmith | right | 15:05 |
dansmith | right | 15:05 |
dansmith | that is the late run to pick up stragglers I think, | 15:05 |
dansmith | and this is earlier | 15:05 |
dansmith | I don't think the devstack change makes anything like db init happen in any different order, | 15:06 |
dansmith | so I'm kinda suspecting that we're using the wrong config file somewhere and never installing the maps at the top | 15:06 |
*** gbarros has quit IRC | 15:06 | |
dansmith | but I can chase that down.. just want to do this as the easy first stab and see where we are | 15:06 |
dansmith | if this doesn't work, it's definitely a config file thing I think | 15:06 |
dansmith | definitely I think | 15:06 |
*** slaweq has quit IRC | 15:07 | |
huanxie | Hi jaypipes, for VM lost connection issue during live migration with XenServer, I saw your comments with this patch https://review.openstack.org/#/c/451657/ and I think it's reasonable to hide detailed bridge operation, so I made another patch https://review.openstack.org/#/c/462017/ for this issue. Could you help have a look at https://review.open | 15:09 |
huanxie | stack.org/#/c/462017/ ? And TBH, I'm not quit sure which one is better now, so could you help give some suggestions? Thanks a lot:) | 15:09 |
*** tesseract has quit IRC | 15:10 | |
cfriesen | mriedem: dansmith: If you have a few minutes, I addressed some of mriedem's comments on https://review.openstack.org/#/c/435141/ but I'm stuck on how to mock the unit tests to do the api version. | 15:10 |
dansmith | cfriesen: that's not a thing I'm going to be helpful with. ask sdague or alex_xu | 15:11 |
*** gbarros has joined #openstack-nova | 15:12 | |
jaypipes | huanxie: yup, it's on my queue :) sorry, in three hour meeting right now :( | 15:12 |
mriedem | cfriesen: andreykurilin might be able to help, otherwise i can look later | 15:13 |
*** clayton has quit IRC | 15:13 | |
*** acormier has quit IRC | 15:13 | |
andreykurilin | hi | 15:13 |
cfriesen | hey | 15:13 |
*** acormier has joined #openstack-nova | 15:13 | |
andreykurilin | cfriesen: what had happend? need help?) | 15:13 |
huanxie | That's fine, please leave your comments and concern and I will address your comments my next Monday:) | 15:13 |
cfriesen | andreykurilin: see https://review.openstack.org/#/c/435141/ | 15:14 |
andreykurilin | looking | 15:14 |
*** gbarros has quit IRC | 15:14 | |
cfriesen | andreykurilin: I added a microversion such that the "nova list" command now needs to check microversions to determine how to format the output, and it's breaking a bunch of novaclient tests. | 15:14 |
*** gbarros has joined #openstack-nova | 15:14 | |
huanxie | Hi jaypipes, sorry for my mistack, I mean I will fix your comments my next morning :) | 15:15 |
jaypipes | huanxie: no problem! | 15:15 |
*** clayton has joined #openstack-nova | 15:15 | |
cfriesen | andreykurilin: the tests in question use mock.MagickMock for novaclient.client.Client, and then later on some of the tests do @mock.patch('novaclient.client.Client'), and I can't figure out how to get them to report api_version properly | 15:16 |
huanxie | Thanks a lot jaypipes | 15:16 |
andreykurilin | cfriesen: are you talking about unit or functional tests? | 15:16 |
cfriesen | andreykurilin: unit. novaclient/tests/unit/test_shell.py | 15:17 |
mriedem | cfriesen: wouldn't you just put an api_version attribute on the mock? | 15:17 |
*** Oku_OS is now known as Oku_OS-away | 15:19 | |
cfriesen | mriedem: the code in question does this in setUp(): self.useFixture(fixtures.MonkeyPatch('novaclient.client.Client', mock.MagicMock())) | 15:19 |
cfriesen | mriedem: I can't figure out how to put an api_version attribute on that | 15:20 |
andreykurilin | cfriesen: it looks like just that module requires some cleanup | 15:20 |
mriedem | cfriesen: mock.MagicMock(api_version=api_versions.APIVersion('2.1')) | 15:20 |
mriedem | or something | 15:20 |
andreykurilin | if setUp method uses fixtures, no @mock.patch is required | 15:20 |
*** huanxie has quit IRC | 15:21 | |
andreykurilin | cfriesen: I suppose, we need to same mock.MagicMock() object as self.mock_client before transmitting to MonkeyPatch, and than you will able to do `self.mock_client.api_version = api_versions.APIVersion("2.22")` in your test | 15:22 |
*** slaweq has joined #openstack-nova | 15:24 | |
cfriesen | andreykurilin: if you don't @mock.patch on the test itself, how do you do stuff like "client_kwargs = mock_client.call_args_list[0][1]" ? | 15:24 |
andreykurilin | cfriesen: as I mentioned previously, we need to store object transmitted to MockPatch in setUp method | 15:25 |
cfriesen | andreykurilin: I think I see. will try that | 15:25 |
*** slaweq has quit IRC | 15:26 | |
*** chyka has joined #openstack-nova | 15:26 | |
cfriesen | andreykurilin: you are a genius. Looks like that'll work. let me respin a new version for review. | 15:29 |
*** jianghuaw_ has joined #openstack-nova | 15:29 | |
*** mikal has quit IRC | 15:29 | |
*** mamandle has joined #openstack-nova | 15:29 | |
andreykurilin | cfriesen: If you have time, please submit a patch with removing all redundant @mock.patch there | 15:29 |
cfriesen | andreykurilin: whoops, spoke too soon. TypeError: '<MagicMock name='mock().api_version' id='69241360'>' should be an instance of '<class 'novaclient.api_versions.APIVersion'>' | 15:30 |
*** tidwellr has quit IRC | 15:30 | |
andreykurilin | cfriesen: in your test, you should do something like `self.mock_client.api_version = api_versions.APIVersion("2.22")`` where api_versions is a module novaclient.api_versions | 15:30 |
*** mikal has joined #openstack-nova | 15:31 | |
*** tidwellr has joined #openstack-nova | 15:31 | |
cfriesen | andreykurilin: this is what I have now: http://paste.openstack.org/show/612435/ | 15:31 |
mriedem | _CellProxy | 15:31 |
mriedem | oh _CellProxy | 15:31 |
mriedem | why oh why | 15:31 |
cfriesen | andreykurilin: and this is what I get when running it: http://paste.openstack.org/show/612437/ | 15:33 |
mriedem | cfriesen: needs to be an object, | 15:33 |
mriedem | not a string | 15:33 |
mriedem | cfriesen: https://github.com/openstack/python-novaclient/blob/master/novaclient/client.py#L59 | 15:34 |
mriedem | ^ is what you're mocking out ultimately | 15:34 |
cfriesen | mriedem: what needs to be an object? | 15:34 |
mriedem | so it needs to be of type novaclient.api_versions.APIVersion | 15:34 |
mriedem | cfriesen: self.mock_client.api_version = novaclient.API_MAX_VERSION | 15:35 |
mriedem | that's a string | 15:35 |
mriedem | needs to be an object | 15:35 |
mriedem | an APIVersion object | 15:35 |
mriedem | which is constructed with a string value | 15:35 |
*** chyka has quit IRC | 15:35 | |
mriedem | i would probably also use API_MIN_VERSION as the default | 15:36 |
mriedem | for existing tests | 15:36 |
cfriesen | yeah, that was my intent. copy/paste error just now | 15:36 |
mriedem | bauzas: i've got a fun cells v1 question for you | 15:37 |
mriedem | bauzas: i need to implement __contains__ for the _CellProxy | 15:37 |
bauzas | mriedem: kaboom | 15:37 |
mriedem | like https://github.com/openstack/nova/blob/master/nova/cells/utils.py#L64 | 15:37 |
mriedem | i see that id and host are special cased | 15:37 |
mriedem | i was just doing this: | 15:37 |
mriedem | def __contains__(self, key): | 15:37 |
mriedem | return key in self._obj | 15:37 |
mriedem | but do i need to special case id and host? | 15:37 |
mriedem | i don't think so, but wanted to ask | 15:38 |
bauzas | mriedem: I need to reload the context in mind because it's a 2-yr blame :p | 15:38 |
mriedem | i think we special case id and host because they are namespaced | 15:39 |
mriedem | to the cell | 15:39 |
mriedem | whether they are IN the proxied object is the same either way i think | 15:39 |
bauzas | mriedem: oh right I remember | 15:41 |
bauzas | mriedem: now | 15:41 |
bauzas | AFAIR, we're amending the host value by the cell path | 15:41 |
bauzas | the same goes with the ID | 15:41 |
bauzas | something like 'foo' becomes cell1!foo AFAIR | 15:41 |
bauzas | which was a problem for our object layers | 15:42 |
bauzas | at least the id | 15:42 |
*** yamahata has joined #openstack-nova | 15:42 | |
bauzas | so, we wrote those ugly patterns to make sure we can just modify both the ID and the host fields without touching the object | 15:42 |
mriedem | yeah, so i think the answer is my simple __contains__ impl is fine | 15:43 |
*** clayton has quit IRC | 15:43 | |
mriedem | for what i need | 15:43 |
mriedem | which is just checking if a field is set in the wrapped object | 15:43 |
mriedem | it's a proxy to the ovo base __contains__ | 15:44 |
bauzas | I'm thinking of your question | 15:44 |
bauzas | whether we should special case id and host | 15:44 |
bauzas | I think no | 15:44 |
bauzas | because we have the properties | 15:44 |
*** mamandle has quit IRC | 15:45 | |
*** rmart04 has quit IRC | 15:46 | |
*** tbachman has quit IRC | 15:46 | |
bauzas | mriedem: ^ | 15:46 |
*** slaweq has joined #openstack-nova | 15:47 | |
*** clayton has joined #openstack-nova | 15:48 | |
*** dtp has joined #openstack-nova | 15:49 | |
bauzas | mriedem: the thing is, I'm thiking of the precedence between __getitem__ and __contains__ | 15:49 |
bauzas | mriedem: but if you ask : 'id' in mycellproxy | 15:50 |
mriedem | bauzas: __contains__ is used before __getitem__ | 15:50 |
bauzas | it should provide True anyway | 15:50 |
mriedem | which is why i needed to add it | 15:50 |
mriedem | see http://logs.openstack.org/99/471899/5/check/gate-nova-python27-ubuntu-xenial/7be94a3/testr_results.html.gz | 15:50 |
mriedem | that was calling __getitem__ with key=0 | 15:51 |
bauzas | FWIW, the doc is https://docs.python.org/3/reference/datamodel.html | 15:51 |
mriedem | treating it as a list rather than a map (dict) | 15:51 |
mriedem | and getattr blows up with TypeError if you're passing a non-string | 15:51 |
mriedem | __contains__ fixes it | 15:51 |
*** Apoorva has joined #openstack-nova | 15:52 | |
*** andreas_s has quit IRC | 15:52 | |
bauzas | mriedem: not sure I get why you land with key=0 but okay | 15:53 |
mriedem | me neither | 15:53 |
mriedem | anyway, i think it's resolved, | 15:53 |
mriedem | forget i ever asked about this | 15:53 |
bauzas | well, okay :) | 15:54 |
* bauzas loves cells v1 | 15:54 | |
sfinucan | sdague: Could you take a look at this and see if it makes sense? https://review.openstack.org/#/c/473224/ | 15:55 |
sdague | sfinucan: with the version bump it should be fine | 15:55 |
*** slaweq has quit IRC | 15:55 | |
*** markus_z has quit IRC | 15:56 | |
sfinucan | sdague: so they should go in together? | 15:56 |
sfinucan | *in the same patch | 15:57 |
sdague | yeh | 15:57 |
*** Guest86005 has quit IRC | 15:57 | |
*** lpetrut has quit IRC | 15:57 | |
sdague | I think there is going to need to be a unit test change at the same time | 15:57 |
sdague | I can pull them together if you like | 15:57 |
cfriesen | mriedem: andreykurilin: Still hitting the problem. http://paste.openstack.org/show/612439/ has my setUp() code, the test itself, and the pdb output while running the test. | 15:57 |
*** jaosorior has quit IRC | 15:57 | |
*** jaosorior has joined #openstack-nova | 15:58 | |
*** clayton has quit IRC | 15:58 | |
*** jaosorior is now known as jaosorior_away | 15:58 | |
cfriesen | mriedem: andreykurilin: for some reason I can't do pdb in novaclient/v2/shell.py, it just hangs. wonder if that's related to the issue | 15:58 |
*** nic has joined #openstack-nova | 15:58 | |
*** clayton has joined #openstack-nova | 15:59 | |
andreykurilin | it is strange, because I fetched your patch, applied changes in setUp method and everything works for me(at least test_default_endpoint_type passes) | 15:59 |
*** jamesden_ has joined #openstack-nova | 15:59 | |
*** jamesdenton has quit IRC | 15:59 | |
cfriesen | andreykurilin:did you change it from "flavor-list" to "list"? | 15:59 |
*** vks1 has quit IRC | 16:00 | |
andreykurilin | ok, let me try | 16:00 |
cfriesen | in test_default_endpoint_type9) | 16:00 |
*** gyee has joined #openstack-nova | 16:00 | |
*** cdent has quit IRC | 16:01 | |
mriedem | alex_xu: sdague: remember how we wanted to do the os-services and os-hypervisors id->uuid API changes in the same microversion, plus a bunch of other cleanups for weird PUT and GET APIs? | 16:02 |
mriedem | this one https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/service-hyper-uuid-in-api.html | 16:02 |
openstackgerrit | Sean Dague proposed openstack/python-novaclient master: Fix setting 'global_request_id' in SessionClient https://review.openstack.org/473224 | 16:02 |
*** sree has joined #openstack-nova | 16:02 | |
mriedem | turns out that might be a monster change if we're doing it on the same microversion, like the os-services one is pushing 1000 LOC | 16:03 |
andreykurilin | cfriesen: `self.mock_client.return_value.api_version = api_versions.APIVersion("2.1")` | 16:03 |
andreykurilin | you need to setup api_version like this | 16:03 |
andreykurilin | cfriesen: because self.mock_client is just a mock of novaclient.client.Client method and CLI obtains api_version property from the object which that novaclient.client.Client returns | 16:04 |
sdague | mriedem: because of the tests and friends? | 16:04 |
mriedem | sdague: and docs yeah | 16:04 |
mriedem | plus, | 16:04 |
*** hamzy has quit IRC | 16:04 | |
mriedem | os-hypervisors is going to require changes for paging across cells, | 16:04 |
mriedem | which i didn't originally anticipate in the spec | 16:04 |
sdague | ok | 16:04 |
sdague | is there any way to structure that code for land better? | 16:05 |
mriedem | i've tried to split out some of it by layers, e.g. https://review.openstack.org/#/c/461532/ | 16:05 |
mriedem | is the compute API stuff, before the REST API controller pieces | 16:05 |
mriedem | can't really do that once i get to https://review.openstack.org/#/c/464280/ though | 16:05 |
sfinucan | sdague: Yeah, go for it | 16:05 |
mriedem | granted that one is mostly tests and docs | 16:05 |
sfinucan | (pulling them together) | 16:06 |
sdague | honestly, I have wondered if we should stack our API changes a little differently so the functional is in one patch, samples tests in next patch, api-ref in 3rd? Then just -2 the bottom and do a flush | 16:06 |
sdague | because I do agree they get complicated to mentally context switch in the reviews | 16:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Handle uuids in os-hypervisors API https://review.openstack.org/471899 | 16:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Use uuid for id in Services API https://review.openstack.org/464280 | 16:06 |
mriedem | ^ is the latest before i have the api-ref working | 16:06 |
mriedem | per my os_api_ref problem this morning | 16:06 |
mriedem | my plan here was to get reviews on each separately, -2 on os-services until +2 on os-hypervisors, then squash them | 16:07 |
mriedem | there is going to be db api/object layer paging changes for the hypervisors one that will be separate | 16:07 |
mriedem | but things still get pretty big | 16:07 |
cfriesen | andreykurilin: you're my hero. :) | 16:07 |
mriedem | https://review.openstack.org/#/c/464280/11/nova/api/openstack/compute/services.py is the main functional piece in the os-services change, and isn't too bad | 16:07 |
mriedem | i chose not to try and re-using the weird little private methods for the service action apis | 16:08 |
mriedem | like _enable and _disable | 16:08 |
*** rajathagasthya has joined #openstack-nova | 16:08 | |
mriedem | so it's a single update() method for the new microversion that handles all of the things in the request | 16:08 |
*** sree has quit IRC | 16:09 | |
openstackgerrit | Sean Dague proposed openstack/python-novaclient master: Fix setting 'global_request_id' in SessionClient https://review.openstack.org/473224 | 16:12 |
sdague | sfinucan: it can actualy be a little smaller | 16:12 |
*** damien_r has quit IRC | 16:13 | |
sfinucan | sdague: And even smaller? REQ_ID_HEADER looks unused | 16:13 |
*** jdurgin has quit IRC | 16:13 | |
sdague | sfinucan: oh, it might be now | 16:14 |
bauzas | mriedem: I did remember how cutting the relationship between services and hypervisors was a big thing, so I trust you when you say it's becoming a monster change | 16:14 |
sdague | I can swing around in a sec | 16:14 |
sfinucan | no rush | 16:15 |
bauzas | touching services and hypervisor seems like the most impactful things to do, because we have a shit ton of tests asserting things, plus a lot of logic around those | 16:15 |
openstackgerrit | Sean Dague proposed openstack/python-novaclient master: Fix setting 'global_request_id' in SessionClient https://review.openstack.org/473224 | 16:15 |
mriedem | it's definitely not fun | 16:15 |
*** karimb has quit IRC | 16:15 | |
bauzas | mriedem: any series I can start to review, so I could help ? | 16:15 |
mriedem | the os-services thing is pretty straight-forward though, after working on it for a couple of days | 16:16 |
bauzas | don't be afraid of WIPs | 16:16 |
mriedem | bauzas: https://review.openstack.org/#/c/464280/11 and below | 16:16 |
bauzas | mriedem: okay, I'll review those | 16:16 |
mriedem | bauzas: ^ is really basically done, except one todo in the code and i need to get the api-ref working | 16:16 |
mriedem | sdague: i wonder if my comments in the parameters.yaml is what's making os_api_ref puke? | 16:16 |
bauzas | mriedem: I can see the code | 16:17 |
mriedem | oh i guess not, there are already comments in there | 16:17 |
sdague | mriedem: you have the patch? | 16:18 |
mriedem | https://review.openstack.org/#/c/464280/ | 16:18 |
*** dtantsur is now known as dtantsur|afk | 16:19 | |
sdague | ok, let me poke | 16:21 |
*** suresh12 has joined #openstack-nova | 16:21 | |
*** jaosorior_away has quit IRC | 16:23 | |
*** sridharg has quit IRC | 16:24 | |
sdague | mriedem: ok, it's a warning that's trying to trigger | 16:25 |
*** itlinux_ has joined #openstack-nova | 16:26 | |
sdague | oh, i see what's going on, let me figure out the right fix | 16:26 |
*** suresh12_ has joined #openstack-nova | 16:27 | |
*** tbachman has joined #openstack-nova | 16:29 | |
*** suresh1__ has joined #openstack-nova | 16:30 | |
*** suresh12 has quit IRC | 16:30 | |
*** armax has quit IRC | 16:31 | |
*** suresh12_ has quit IRC | 16:32 | |
sdague | oh, it looks like sphinx changed a call interface | 16:33 |
*** armax has joined #openstack-nova | 16:33 | |
mriedem | ok but this would be the warning https://github.com/openstack/os-api-ref/blob/master/os_api_ref/__init__.py#L349 | 16:34 |
mriedem | i'm missing some path parameter | 16:34 |
*** raorn_ is now known as raorn | 16:35 | |
*** suresh12 has joined #openstack-nova | 16:35 | |
*** suresh1__ has quit IRC | 16:35 | |
openstackgerrit | Alex Szarka proposed openstack/nova master: Refactor create_delete_server_with_instance_update https://review.openstack.org/466296 | 16:37 |
openstackgerrit | Chris Friesen proposed openstack/python-novaclient master: 2.47: Show flavor info in server details https://review.openstack.org/435141 | 16:38 |
openstackgerrit | Chris Friesen proposed openstack/python-novaclient master: Clean up ShellTest unit tests https://review.openstack.org/473910 | 16:38 |
cfriesen | mriedem: andreykurilin: ^ | 16:38 |
mriedem | sdague: yeah if i restrict Sphinx<1.6.1 i get this | 16:40 |
mriedem | /home/user/git/nova/api-ref/source/api-ref/source/os-services.inc:250 .rst:: WARNING: No path parameter ``service_id`` found in rest_parameter stanza. | 16:40 |
*** suresh12 has quit IRC | 16:40 | |
sdague | yeh | 16:40 |
*** sambetts is now known as sambetts|afk | 16:40 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | 16:40 |
sdague | so they seem to have changed the warn parameters on env | 16:40 |
*** rcernin has quit IRC | 16:41 | |
mriedem | i'll open a bug quick to track it against os-api-ref | 16:43 |
*** derekh has quit IRC | 16:43 | |
cfriesen | mriedem: for https://review.openstack.org/#/c/465787/ we have some indication that it's not properly handling neutron floatingip-associate events | 16:43 |
openstackgerrit | Merged openstack/nova master: Fix the race condition with novnc https://review.openstack.org/470798 | 16:44 |
*** suresh12 has joined #openstack-nova | 16:46 | |
*** Swami has joined #openstack-nova | 16:48 | |
*** rajathagasthya has quit IRC | 16:49 | |
*** lucasagomes is now known as lucas-afk | 16:50 | |
*** suresh12 has quit IRC | 16:51 | |
openstackgerrit | Merged openstack/nova master: Add missing query filter params for GET /os-services API https://review.openstack.org/473708 | 16:53 |
*** yamahata has quit IRC | 16:54 | |
mriedem | dansmith: about that service not found thing last night, where it's not a compute service to do things like enable/disable, | 16:55 |
mriedem | we talked about returning a more useful error message in that case, | 16:55 |
mriedem | however, it's a chicken and egg problem, | 16:56 |
*** slaweq has joined #openstack-nova | 16:56 | |
mriedem | well, maybe not - if it's not a compute service it won't have a host mapping and we'll get HostMappingNotFound, | 16:57 |
mriedem | if it is a compute service and really just doesn't exist, we'll get ServiceNotFound | 16:57 |
*** gmann has quit IRC | 16:57 | |
mriedem | anyway, now i'm having a hard time recalling what we talked about doing here | 16:59 |
*** tuanla_fujitsu has joined #openstack-nova | 16:59 | |
*** felipemonteiro has joined #openstack-nova | 16:59 | |
dansmith | not 404ing if they try to disable a scheduler for example | 16:59 |
mriedem | oh right, so it is kind of a chicken and egg then | 17:00 |
mriedem | we don't know it's a scheduler or not | 17:00 |
mriedem | if there is no host mapping, that could be b/c it's not mapped yet | 17:00 |
*** fragatina has quit IRC | 17:00 | |
mriedem | or because it's not a compute service | 17:00 |
*** tuanla__ has joined #openstack-nova | 17:00 | |
*** amotoki is now known as amotoki_away | 17:01 | |
*** slaweq has quit IRC | 17:01 | |
*** Apoorva_ has joined #openstack-nova | 17:01 | |
mriedem | anyway, i think i'm going to write something up to the ML about this just to make people aware and see if anyone had any weird uses for disabling non-compute services, | 17:01 |
mriedem | to help answer what i should do in the new api | 17:02 |
dansmith | if we don't find a mapping, we can lookin cell0 for the service, and if we find, it we can assume it's not an unmapped compute, but a non-compute control service | 17:02 |
dansmith | there is no use for disabling a non-compute service, | 17:02 |
dansmith | all it does is set disabled=True, and that's only checked in the scheduler | 17:02 |
dansmith | I went through this with someone internal a few months ago | 17:02 |
*** salv-orlando has joined #openstack-nova | 17:03 | |
mriedem | i know, but you never know what people are doing - which is why i just want to ask or let people be aware of this, | 17:03 |
*** ralonsoh has quit IRC | 17:03 | |
mriedem | i think we still go forward with restricting updating to only compute services | 17:03 |
mriedem | i.e. i could totally see someone using service.update notifications to trigger some backend system to kill their nova-scheduler or something, so they can control things via the api | 17:03 |
*** Apoorva has quit IRC | 17:04 | |
dansmith | and your point is you just want to alert those people that we're killing that? .... RIGHT? | 17:05 |
mriedem | the point is i'm going to add a flurry of config options to call out to external hooks which change the behavior of this api | 17:05 |
mriedem | is that ok? | 17:05 |
dansmith | oh that? yeah, that's fine... reaaaal nice. | 17:06 |
*** salv-orl_ has quit IRC | 17:06 | |
*** fragatina has joined #openstack-nova | 17:06 | |
mriedem | yes this is an alert | 17:06 |
mriedem | brown alert | 17:06 |
dansmith | heh | 17:06 |
*** fragatina has quit IRC | 17:08 | |
*** jdurgin has joined #openstack-nova | 17:09 | |
*** fragatina has joined #openstack-nova | 17:09 | |
*** baoli has quit IRC | 17:17 | |
*** rajathagasthya has joined #openstack-nova | 17:17 | |
*** Apoorva_ has quit IRC | 17:17 | |
*** Apoorva has joined #openstack-nova | 17:18 | |
mriedem | here she be http://lists.openstack.org/pipermail/openstack-operators/2017-June/013761.html | 17:21 |
*** gjayavelu has joined #openstack-nova | 17:23 | |
*** hamzy has joined #openstack-nova | 17:23 | |
*** jpena is now known as jpena|away | 17:25 | |
edmondsw | dansmith mriedem sfinucan before I invest a bunch of time in UTs, what do y'all think of the course I'm on with https://review.openstack.org/#/c/472794/ ? | 17:25 |
*** mingyu has joined #openstack-nova | 17:27 | |
*** efoley has quit IRC | 17:30 | |
*** yamahata has joined #openstack-nova | 17:34 | |
*** krtaylor has quit IRC | 17:35 | |
*** tuanla__ has quit IRC | 17:37 | |
*** tuanla_fujitsu has quit IRC | 17:37 | |
*** vladikr has quit IRC | 17:42 | |
*** suresh12 has joined #openstack-nova | 17:49 | |
*** baoli has joined #openstack-nova | 17:49 | |
*** vladikr has joined #openstack-nova | 17:50 | |
*** jamesden_ has quit IRC | 17:55 | |
*** itlinux_ has quit IRC | 17:56 | |
dansmith | mriedem: the ironic driver is waiting for this to report some resources: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L4627 | 17:56 |
dansmith | which will never happen | 17:56 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Handle uuids in os-hypervisors API https://review.openstack.org/471899 | 17:56 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Use uuid for id in os-services API https://review.openstack.org/464280 | 17:56 |
dansmith | my discover change in that loop did find unmapped nodes though, so we definitely need that | 17:56 |
mriedem | dtp: ok os-services is done and ready for review ^ i'm going to -2 it until the os-hypervisors change is done | 17:56 |
*** itlinux_ has joined #openstack-nova | 17:56 | |
dtp | ok | 17:56 |
mriedem | sdague: just squeeked in under 1000LOC :) | 17:56 |
*** fragatina has quit IRC | 17:57 | |
*** slaweq has joined #openstack-nova | 17:57 | |
mriedem | dansmith: hmm, how is it we never had to update GET /os-hypervisors/statistics for multi-cells? | 17:57 |
mriedem | no tempest test? | 17:57 |
dansmith | I think very few things hit that, | 17:58 |
dansmith | so yeah | 17:58 |
mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/hypervisors.py#L277 | 17:58 |
mriedem | yeah, so i guess we need to address that under your cells-aware bp | 17:59 |
dansmith | yeah | 17:59 |
mriedem | i worry a bit about what we haven't made cells aware due to lack of tempest api test coverage | 17:59 |
mriedem | but not so worried that i'm going to do a thorough audit right now :) | 17:59 |
*** jamesdenton has joined #openstack-nova | 18:00 | |
dansmith | well, lack of test coverage is lack of test coverage | 18:00 |
dansmith | we're hitting one thing right here before real people do, so... | 18:01 |
mriedem | so kudos to us | 18:01 |
openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.rebuild-scheduled notification https://review.openstack.org/473929 | 18:01 |
*** slaweq has quit IRC | 18:01 | |
*** suresh12 has quit IRC | 18:02 | |
*** crushil has joined #openstack-nova | 18:04 | |
*** suresh12 has joined #openstack-nova | 18:06 | |
mriedem | cfriesen: something still failing here https://review.openstack.org/#/c/435141/ | 18:06 |
*** jamesdenton has quit IRC | 18:08 | |
dansmith | mriedem: there aren't even unit tests for that bit of HostAPI | 18:11 |
mriedem | nice | 18:12 |
mriedem | i've noticed we test the rest api but not the host api so well | 18:12 |
*** suresh12 has quit IRC | 18:13 | |
dansmith | I don't see rest tests for this either | 18:15 |
*** krtaylor has joined #openstack-nova | 18:20 | |
*** suresh12 has joined #openstack-nova | 18:20 | |
*** applec4rt has joined #openstack-nova | 18:22 | |
*** itlinux_ has quit IRC | 18:23 | |
sdague | mriedem: oh, it's just a flat out broken sphinx thing | 18:24 |
sdague | gdi | 18:24 |
cfriesen | mriedem: we found the bug in https://review.openstack.org/#/c/465787 and I updated the review | 18:24 |
*** cdent has joined #openstack-nova | 18:25 | |
*** rcernin has joined #openstack-nova | 18:26 | |
cfriesen | mriedem: I think that's new after rebasing...I only reran the test_shell unit tests after changing stuff | 18:26 |
*** jamesdenton has joined #openstack-nova | 18:28 | |
openstackgerrit | Dan Smith proposed openstack/nova master: DNM: Canary https://review.openstack.org/473565 | 18:28 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make compute_node_statistics() work across cells https://review.openstack.org/473931 | 18:28 |
*** sudipto has joined #openstack-nova | 18:29 | |
*** kenperkins has joined #openstack-nova | 18:29 | |
*** sudipto has quit IRC | 18:29 | |
cfriesen | mriedem: this is weird...novaclient.tests.unit.test_client.SessionClientTest.test_global_id passes locally | 18:29 |
*** sudipto has joined #openstack-nova | 18:29 | |
*** sudipto has quit IRC | 18:29 | |
*** sudipto has joined #openstack-nova | 18:30 | |
*** sudipto_ has joined #openstack-nova | 18:30 | |
cfriesen | mriedem: and I didn't change anything related to that code, that I can see at least | 18:30 |
*** itlinux_ has joined #openstack-nova | 18:31 | |
*** dtp has quit IRC | 18:32 | |
*** ijw has joined #openstack-nova | 18:32 | |
*** egonzalez has joined #openstack-nova | 18:36 | |
cfriesen | mriedem: locally it looks fine. what's with the key.lower() in the traceback of the failing test at http://logs.openstack.org/41/435141/13/check/gate-python-novaclient-python27-ubuntu-xenial/df4a44b/testr_results.html.gz ? | 18:37 |
cfriesen | andreykurilin: can you see any reason why https://review.openstack.org/#/c/473910 would cause the failure in test_global_id at http://logs.openstack.org/10/473910/1/check/gate-python-novaclient-python27-ubuntu-xenial/76e7e46/testr_results.html.gz ? | 18:42 |
mriedem | cfriesen: the global id thing is being fixed | 18:44 |
mriedem | sdague has a patch for it | 18:44 |
mriedem | cfriesen: good catch on https://review.openstack.org/#/c/465787/3/nova/network/neutronv2/api.py@2322 | 18:45 |
*** nicolasbock has quit IRC | 18:51 | |
*** nicolasbock has joined #openstack-nova | 18:51 | |
*** sudipto has quit IRC | 18:53 | |
*** sudipto_ has quit IRC | 18:53 | |
cfriesen | mriedem: can't take credit personally...we ran into it during testing and one of the guys tracked it down | 18:56 |
cfriesen | mriedem: you okay with https://review.openstack.org/#/c/435141/ otherwise, or did you still have issues with the json blob output? | 18:57 |
mriedem | haven't looked at it yet | 18:58 |
mriedem | getting https://review.openstack.org/#/c/473224/ sorted out | 18:58 |
cfriesen | kay, no worries | 18:58 |
*** slaweq has joined #openstack-nova | 18:58 | |
mriedem | cfriesen: i definitely don't like dumping a json blob in a table cell, | 18:59 |
mriedem | but as you replied, we do it elsewhere | 18:59 |
mriedem | the alternative is we dump the flavor name | 19:00 |
mriedem | with the server details | 19:00 |
mriedem | and then if you want details on the flavor, you do nova flavor-show <flavor name> | 19:01 |
*** baoli has quit IRC | 19:01 | |
*** slaweq has quit IRC | 19:03 | |
bauzas | mriedem: dansmith: just a note that I'll be on PTO tomorrow | 19:03 |
mriedem | ok | 19:04 |
* bauzas hitted by paperwork rules for French folks | 19:04 | |
bauzas | that, next week and the other week | 19:04 |
cfriesen | mriedem: that doesn't work if the flavor is deleted or modified though | 19:05 |
mriedem | cfriesen: true | 19:05 |
mriedem | cfriesen: would be nice at least to dump key-value pairs in a table cell rather than a json blob | 19:06 |
mriedem | but i don't know how easy that is | 19:06 |
mriedem | with prettytable | 19:06 |
*** mnestratov|2 has quit IRC | 19:06 | |
mriedem | we might have done something like that with nova-status, checking | 19:06 |
*** gszasz has quit IRC | 19:07 | |
cfriesen | mriedem: the output currently looks like this: http://paste.openstack.org/show/612457/ | 19:07 |
sdague | mriedem: fyi - https://review.openstack.org/473941 is what was needed to get your api-ref warnings emitted | 19:07 |
*** awaugama has quit IRC | 19:07 | |
mriedem | cfriesen: yikes | 19:07 |
*** jdurgin has quit IRC | 19:07 | |
mriedem | sdague: any idea if that works with sphinx 1.5.1? https://github.com/openstack/requirements/blob/master/global-requirements.txt#L412 | 19:08 |
mriedem | sdague: also curious for your opinion on embedding the nested flavor in the server show ouput as a json blob http://paste.openstack.org/show/612457/ | 19:08 |
mriedem | i personally think that's ugly, but we also do it for volume attachments and extra specs in the flavor-show output | 19:08 |
cfriesen | I'm not wedded to it, happy to do something better | 19:09 |
cfriesen | just don't know what other options we have | 19:09 |
*** NostawRm has joined #openstack-nova | 19:10 | |
*** mvk has quit IRC | 19:10 | |
*** slaweq has joined #openstack-nova | 19:11 | |
mriedem | cfriesen: i'd prefer to see it like this somehow http://paste.openstack.org/show/612458/ | 19:11 |
mriedem | but not sure how easy that is | 19:11 |
sdague | mriedem: I don't yet, still puttering through this | 19:13 |
sdague | mriedem: I agree, I think it should be unrolled | 19:13 |
cfriesen | mriedem: that'd make functional tests a bit of a mess, trying to correlate that against the output of "flavor show" | 19:13 |
cfriesen | I guess we could take the "flavor show" output and mangle it into that format and then compare | 19:14 |
sdague | um, why isn't this just flavor_ ephemeral | 19:14 |
sdague | flavor_ram | 19:14 |
sdague | etc | 19:14 |
mriedem | could be namespaced | 19:14 |
mriedem | that's an option | 19:14 |
sdague | if you are putting the output in the tables, it should be table friendly data | 19:15 |
sdague | or flavor:ram | 19:15 |
cfriesen | sdague: I was just following the existing pattern where the "flavor" entry had the name and the id on one line | 19:15 |
sdague | cfriesen: right, but that was a key | 19:16 |
mriedem | sure, but now it's more than id | 19:16 |
sdague | mriedem: ++ | 19:16 |
mriedem | cfriesen: i'd think it would be pretty easy to transform that to flavor_ namespaced keys in the server resp body object before sending it to the table output formatter | 19:16 |
mriedem | there might even be a callback function available with the output formatter | 19:17 |
cfriesen | agreed. you want "flavor_" or "flavor:"? | 19:17 |
mriedem | hmm | 19:17 |
sdague | I think flavor: | 19:17 |
mriedem | you're treading on OS-SRV-EXT territory :) | 19:17 |
sdague | mriedem: sure | 19:17 |
mriedem | i'm cool with flavor: | 19:17 |
mriedem | makes it more namespacey | 19:17 |
sdague | yep | 19:17 |
cfriesen | okay, will give that a try | 19:18 |
*** krtaylor has quit IRC | 19:20 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Pull out code that builds VIF in _build_network_info_model https://review.openstack.org/466449 | 19:22 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Handle network-changed event for a specific port https://review.openstack.org/465787 | 19:22 |
*** suresh12 has quit IRC | 19:23 | |
*** mingyu has quit IRC | 19:24 | |
*** suresh12 has joined #openstack-nova | 19:25 | |
*** adisky__ has quit IRC | 19:26 | |
*** jdurgin has joined #openstack-nova | 19:27 | |
*** ijw has quit IRC | 19:28 | |
*** nicolasbock has quit IRC | 19:30 | |
*** baoli has joined #openstack-nova | 19:33 | |
*** dtp has joined #openstack-nova | 19:40 | |
*** armax has quit IRC | 19:40 | |
mriedem | no artom?! | 19:41 |
mriedem | kashyap: i assume if i see this in the libvirtd logs, it means it's a persistent domain: "Writing domain status to disk" | 19:41 |
mriedem | well i already know it's a persistent domain, so nm | 19:41 |
*** awaugama has joined #openstack-nova | 19:43 | |
*** gomarivera has quit IRC | 19:43 | |
*** gomarivera has joined #openstack-nova | 19:47 | |
*** gszasz has joined #openstack-nova | 19:47 | |
*** Apoorva has quit IRC | 19:52 | |
*** suresh12 has quit IRC | 19:53 | |
*** eharney has quit IRC | 19:53 | |
*** MasterOfBugs has joined #openstack-nova | 19:54 | |
*** cdent has quit IRC | 19:56 | |
*** gomarivera has quit IRC | 19:58 | |
*** krtaylor has joined #openstack-nova | 20:00 | |
openstackgerrit | Merged openstack/nova master: Remove old service version check for mitaka https://review.openstack.org/472395 | 20:02 |
*** Apoorva has joined #openstack-nova | 20:03 | |
*** Apoorva has quit IRC | 20:03 | |
*** Apoorva has joined #openstack-nova | 20:04 | |
*** MasterOfBugs has quit IRC | 20:04 | |
*** MasterOfBugs has joined #openstack-nova | 20:05 | |
*** gomarivera has joined #openstack-nova | 20:05 | |
*** priteau has joined #openstack-nova | 20:06 | |
*** dimtruck is now known as zz_dimtruck | 20:09 | |
*** suresh12 has joined #openstack-nova | 20:13 | |
*** zz_dimtruck is now known as dimtruck | 20:14 | |
*** rmart04 has joined #openstack-nova | 20:14 | |
*** baoli has quit IRC | 20:18 | |
mriedem | sgordon: you might like this https://bugs.launchpad.net/nova/+bug/1696125/comments/16 - we have a bug where detaching an ethernet tap device takes ~5 minutes to be gone from the guest | 20:18 |
openstack | Launchpad bug 1696125 in OpenStack Compute (nova) "Detach interface failed - Unable to detach from guest transient domain (pike)" [High,Confirmed] - Assigned to Matt Riedemann (mriedem) | 20:18 |
mriedem | using linuxbridge | 20:18 |
mriedem | nova waits ~1-2 minutes for the device to be gone before giving up | 20:18 |
* sgordon braces | 20:18 | |
mriedem | i've done the libvirtd log digging | 20:18 |
mriedem | not sure if this is a problem in libvirt/qemu or if it's expected to take this long | 20:19 |
mriedem | not a problem for ovs | 20:19 |
*** rmart04 has quit IRC | 20:19 | |
sgordon | mmm, and if i am perfectly honest most of the testing on our end focuses on ovs these days | 20:19 |
*** dimtruck is now known as zz_dimtruck | 20:19 | |
*** itlinux_ has quit IRC | 20:20 | |
*** mnestratov|2 has joined #openstack-nova | 20:21 | |
mriedem | we could bump this timeout for tap devices, but that's just a workaround, and i believe the tempest tests would actually timeout before that | 20:22 |
mriedem | tempest times out just at 5 minutes | 20:23 |
mriedem | so it'd be a craptacular race to the bottom | 20:23 |
*** baoli has joined #openstack-nova | 20:23 | |
*** jpena|away is now known as jpena|off | 20:23 | |
sgordon | mriedem, i would like to think it should not in fact take > 1 minute but i will track down someone who is actually intelligent to look at it | 20:24 |
sgordon | :) | 20:24 |
mriedem | sgordon: fwiw the neutron side reverted the change to use vif_type='tap' with linuxbridge https://review.openstack.org/#/c/472365/ | 20:25 |
mriedem | interested to know why that would make a difference | 20:25 |
mriedem | the vif_type is now using 'bridge' again | 20:25 |
*** pchavva has quit IRC | 20:25 | |
mriedem | which goes through os-vif | 20:26 |
mriedem | tap does not yet | 20:26 |
*** crushil has quit IRC | 20:27 | |
*** ayogi has quit IRC | 20:29 | |
*** itlinux_ has joined #openstack-nova | 20:32 | |
*** baoli has quit IRC | 20:33 | |
*** suresh12 has quit IRC | 20:33 | |
*** cleong has quit IRC | 20:34 | |
*** gbarros has quit IRC | 20:38 | |
*** zz_dimtruck is now known as dimtruck | 20:41 | |
*** slaweq has quit IRC | 20:41 | |
*** slaweq has joined #openstack-nova | 20:42 | |
openstackgerrit | Matthew Edmonds proposed openstack/nova master: Use CONF.host for powervm nodename https://review.openstack.org/473975 | 20:43 |
*** suresh12 has joined #openstack-nova | 20:44 | |
*** rajathagasthya has quit IRC | 20:45 | |
*** slaweq has quit IRC | 20:46 | |
openstackgerrit | Matthew Edmonds proposed openstack/nova master: [WIP] Deactivate powervm compute until ready https://review.openstack.org/471773 | 20:48 |
*** smatzek has quit IRC | 20:48 | |
*** suresh12 has quit IRC | 20:49 | |
*** suresh12 has joined #openstack-nova | 20:52 | |
*** lucasxu has quit IRC | 20:54 | |
*** rajathagasthya has joined #openstack-nova | 20:54 | |
*** alex_xu has quit IRC | 20:56 | |
*** alex_xu has joined #openstack-nova | 20:57 | |
*** Apoorva has quit IRC | 21:01 | |
*** Apoorva has joined #openstack-nova | 21:01 | |
*** jheroux has quit IRC | 21:02 | |
*** gouthamr has quit IRC | 21:03 | |
mriedem | claudiub|2: i thought hyper-v supported fibrechannel? https://docs.openstack.org/developer/nova/support-matrix.html#storage_block_backend_fibrechannel | 21:07 |
mriedem | https://github.com/openstack/nova/blob/master/nova/virt/hyperv/volumeops.py#L364 | 21:08 |
*** edmondsw has quit IRC | 21:09 | |
mriedem | efried: questions in the powervm support matrix change https://review.openstack.org/#/c/470999/ | 21:09 |
*** edmondsw has joined #openstack-nova | 21:09 | |
efried | esberglu ^^ | 21:10 |
efried | Thanks mriedem, looking. | 21:10 |
*** baoli has joined #openstack-nova | 21:10 | |
*** ayogi has joined #openstack-nova | 21:11 | |
*** edmondsw_ has joined #openstack-nova | 21:12 | |
openstackgerrit | Merged openstack/nova master: remove ugly local import https://review.openstack.org/450787 | 21:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Indicate Hyper-v supports fibre channel in support matrix https://review.openstack.org/473986 | 21:12 |
*** krtaylor has quit IRC | 21:13 | |
*** edmondsw has quit IRC | 21:13 | |
*** gbarros has joined #openstack-nova | 21:15 | |
claudiub|2 | mriedem: yep, it does. | 21:15 |
mriedem | claudiub|2: ok patched above | 21:15 |
claudiub|2 | i guess we have to update the matrix. | 21:15 |
*** thorst_afk has quit IRC | 21:16 | |
*** edmondsw_ has quit IRC | 21:16 | |
*** vladikr has quit IRC | 21:16 | |
*** shaner has quit IRC | 21:17 | |
mriedem | already did ^ | 21:17 |
*** suresh12 has quit IRC | 21:17 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove service control from feature support matrix https://review.openstack.org/473989 | 21:19 |
*** thorst_afk has joined #openstack-nova | 21:19 | |
mriedem | sdague: dansmith: do you happen to remember what "service control" meant? ^ | 21:20 |
*** slaweq has joined #openstack-nova | 21:20 | |
mriedem | maybe it meant QoS? | 21:20 |
dansmith | mriedem: literally bringing up and down services, I think. not sure if that meant nova-compute itself, or things like turning xen on and off for a given node | 21:20 |
dansmith | before my time I think, but never widely supported AFAIK | 21:21 |
mriedem | oh like the libvirt driver auto-disabling nova-compute... | 21:21 |
dansmith | well, I think it was more that that | 21:21 |
mriedem | either way, | 21:21 |
dansmith | like if libvirt supported it, it might be system("service libvirt-bin stop") kind of thing | 21:21 |
mriedem | if we don't know wtf it means, probably best to not doc it and if we care about documenting specifics we do that separately | 21:22 |
dansmith | yeah | 21:22 |
dansmith | here's a good description: | 21:22 |
dansmith | "not a thing we do" | 21:22 |
mriedem | heh, reminds me of https://developer.openstack.org/api-ref/compute/?expanded=start-host-detail#start-host | 21:23 |
mriedem | "This is not implemented by any in-tree compute drivers and therefore will always fail with a 501 NotImplemented error. Needless to say, it is not recommended to use this API and it is deprecated as of the 2.43 microversion." | 21:23 |
*** thorst_afk has quit IRC | 21:23 | |
mriedem | "here is our middle finger, have a nice day" | 21:23 |
*** slaweq has quit IRC | 21:24 | |
dansmith | heh | 21:25 |
dansmith | maybe: | 21:25 |
*** suresh12 has joined #openstack-nova | 21:25 | |
*** mvk has joined #openstack-nova | 21:25 | |
*** erlon has quit IRC | 21:28 | |
*** gouthamr has joined #openstack-nova | 21:28 | |
mriedem | efried: OS-DCF:diskConfig is the auto disk configstuff | 21:32 |
mriedem | old xen thing that predated cloud-init i think | 21:32 |
mriedem | johnthetubaguy could probably explain it | 21:32 |
mriedem | i'd love to remove it from our api code since it's messy | 21:33 |
*** felipemonteiro has quit IRC | 21:34 | |
*** suresh12 has quit IRC | 21:34 | |
efried | hyperv seems to think it has it also. | 21:35 |
mriedem | well, i don't think it means anything to other drivers | 21:36 |
mriedem | tempest tests against that request parameter in our gate, with libvirt | 21:36 |
mriedem | but i don't think it does anything | 21:36 |
mriedem | yeah grep auto_disk_config | 21:37 |
mriedem | it's an image property only used by the xen driver | 21:37 |
efried | Looks like sdague might've been on the road to removing it. | 21:37 |
efried | https://review.openstack.org/#/c/327188/ | 21:37 |
efried | Tomorrow will be the 1y anniversary of that change ;-) | 21:37 |
mriedem | efried: that's not removing it from the api, | 21:38 |
mriedem | that's just folding the extension controller code in | 21:38 |
mriedem | https://specs.openstack.org/openstack/nova-specs/specs/newton/implemented/api-no-more-extensions.html | 21:38 |
efried | Είναι όλα ελληνικά για μένα | 21:41 |
*** fragatina has joined #openstack-nova | 21:41 | |
*** shaner has joined #openstack-nova | 21:41 | |
*** suresh12 has joined #openstack-nova | 21:42 | |
*** thorst_afk has joined #openstack-nova | 21:43 | |
*** suresh12 has quit IRC | 21:46 | |
mriedem | efried: btw this is where the auto_configure_disk magic happens https://github.com/openstack/nova/blob/master/nova/virt/xenapi/vm_utils.py#L929 | 21:47 |
mriedem | btw, setting independent_compute=True apparently is a super fun NoValidHost :) | 21:47 |
*** thorst_afk has quit IRC | 21:48 | |
*** fragatina has quit IRC | 21:48 | |
mriedem | so i assume any xen operator using that is setting up host aggregates with metadata to tie images with that property to them | 21:48 |
*** rfolco has quit IRC | 21:49 | |
*** edmondsw has joined #openstack-nova | 21:50 | |
*** oanson_ has joined #openstack-nova | 21:50 | |
*** fragatina has joined #openstack-nova | 21:51 | |
*** gbarros has quit IRC | 21:51 | |
*** gjayavelu has quit IRC | 21:52 | |
*** MasterOfBugs has quit IRC | 21:53 | |
*** krtaylor has joined #openstack-nova | 21:53 | |
*** oanson has quit IRC | 21:53 | |
*** oanson_ is now known as oanson | 21:53 | |
*** gjayavelu has joined #openstack-nova | 21:53 | |
*** rcernin has quit IRC | 21:54 | |
mriedem | http://git.openstack.org/cgit/openstack/glance/tree/etc/metadefs/compute-xenapi.json#n24 is actually a nice description | 21:54 |
*** edmondsw has quit IRC | 21:55 | |
*** rajathagasthya has quit IRC | 21:55 | |
*** fragatina has quit IRC | 21:55 | |
*** gomarivera has quit IRC | 21:56 | |
*** xyang1 has quit IRC | 21:56 | |
*** gomarivera has joined #openstack-nova | 21:56 | |
*** MasterOfBugs has joined #openstack-nova | 21:56 | |
*** jianghuaw__ has joined #openstack-nova | 21:57 | |
*** gomarivera_ has joined #openstack-nova | 21:58 | |
*** gomarivera has quit IRC | 21:58 | |
*** burt has quit IRC | 21:59 | |
*** tidwellr has quit IRC | 21:59 | |
*** jianghuaw_ has quit IRC | 22:00 | |
*** gomarivera_ has quit IRC | 22:03 | |
*** mdrabe has quit IRC | 22:03 | |
*** priteau has quit IRC | 22:05 | |
*** esberglu has quit IRC | 22:07 | |
*** esberglu has joined #openstack-nova | 22:08 | |
*** shaner has quit IRC | 22:10 | |
*** jdurgin has quit IRC | 22:11 | |
*** esberglu has quit IRC | 22:12 | |
*** claudiub|2 has quit IRC | 22:13 | |
*** suresh12 has joined #openstack-nova | 22:15 | |
*** rajathagasthya has joined #openstack-nova | 22:16 | |
*** ijw has joined #openstack-nova | 22:20 | |
*** MasterOfBugs has quit IRC | 22:23 | |
*** shaner has joined #openstack-nova | 22:23 | |
*** shaner has quit IRC | 22:23 | |
*** shaner has joined #openstack-nova | 22:25 | |
dansmith | mriedem: dtantsur|afk: ironic job passes with that change, so I'll fix it up and hopefully we're good after that | 22:26 |
*** thorst_afk has joined #openstack-nova | 22:27 | |
*** thorst_afk has quit IRC | 22:28 | |
openstackgerrit | Dan Smith proposed openstack/nova master: DNM: Canary https://review.openstack.org/473565 | 22:30 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make compute_node_statistics() work across cells https://review.openstack.org/473931 | 22:30 |
*** esberglu has joined #openstack-nova | 22:31 | |
mriedem | dansmith: cool | 22:31 |
mriedem | i hope the commit message is super verbose and explanatory about all of the weirdness | 22:32 |
mriedem | dansmith: also, i think you'd agree with this, but need to check https://review.openstack.org/#/c/459593/26/nova/conductor/manager.py@532 | 22:32 |
*** salv-orlando has quit IRC | 22:32 | |
*** salv-orlando has joined #openstack-nova | 22:33 | |
dansmith | mriedem: yeah makes sense I think | 22:33 |
mriedem | awesome | 22:33 |
*** slaweq has joined #openstack-nova | 22:33 | |
*** esberglu has quit IRC | 22:36 | |
*** salv-orlando has quit IRC | 22:37 | |
*** slaweq has quit IRC | 22:38 | |
*** ayogi has quit IRC | 22:39 | |
*** egonzalez has quit IRC | 22:41 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: fix misleading description in PUT /os-services/disable https://review.openstack.org/473997 | 22:43 |
*** mnestratov|2 has quit IRC | 22:44 | |
*** trinaths has joined #openstack-nova | 22:45 | |
*** catintheroof has quit IRC | 22:47 | |
*** gszasz has quit IRC | 22:48 | |
*** awaugama has quit IRC | 22:48 | |
*** thorst_afk has joined #openstack-nova | 22:50 | |
*** MasterOfBugs has joined #openstack-nova | 22:50 | |
*** sdague has quit IRC | 22:51 | |
*** fragatina has joined #openstack-nova | 22:52 | |
mikal | . | 22:53 |
*** lyan has quit IRC | 22:55 | |
mriedem | .O. | 22:57 |
*** tyrefors has quit IRC | 22:58 | |
*** itlinux_ has quit IRC | 22:59 | |
*** acormier has quit IRC | 22:59 | |
*** thorst_afk has quit IRC | 22:59 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/472814 | 22:59 |
*** thorst_afk has joined #openstack-nova | 23:00 | |
*** tyrefors has joined #openstack-nova | 23:01 | |
*** fragatina has quit IRC | 23:01 | |
*** thorst_afk has quit IRC | 23:04 | |
*** rajathagasthya has quit IRC | 23:04 | |
openstackgerrit | Merged openstack/nova master: libvirt: dump debug info when interface detach times out https://review.openstack.org/472377 | 23:06 |
*** ijw has quit IRC | 23:07 | |
*** vladikr has joined #openstack-nova | 23:08 | |
*** winston-d_ has quit IRC | 23:13 | |
mikal | mriedem: you peek over the wall more than me | 23:17 |
*** gomarivera has joined #openstack-nova | 23:19 | |
*** jwcroppe has quit IRC | 23:20 | |
*** baoli has quit IRC | 23:20 | |
*** gomarivera has quit IRC | 23:24 | |
*** thorst_afk has joined #openstack-nova | 23:31 | |
*** jwcroppe has joined #openstack-nova | 23:33 | |
*** slaweq has joined #openstack-nova | 23:34 | |
*** takashin has joined #openstack-nova | 23:35 | |
*** jianghuaw__ has quit IRC | 23:36 | |
*** thorst_afk has quit IRC | 23:37 | |
*** jwcroppe has quit IRC | 23:38 | |
*** slaweq has quit IRC | 23:38 | |
*** gomarivera has joined #openstack-nova | 23:40 | |
*** suresh12 has quit IRC | 23:41 | |
*** jwcroppe has joined #openstack-nova | 23:42 | |
*** MasterOfBugs has quit IRC | 23:45 | |
*** suresh12 has joined #openstack-nova | 23:47 | |
openstackgerrit | sean mooney proposed openstack/nova master: WIP set ethernet script to /bin/ture https://review.openstack.org/474006 | 23:52 |
*** gjayavelu has quit IRC | 23:52 | |
*** kenperkins has quit IRC | 23:52 | |
*** suresh12 has quit IRC | 23:53 | |
*** suresh12 has joined #openstack-nova | 23:55 | |
*** dtp has quit IRC | 23:57 | |
*** fragatina has joined #openstack-nova | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!