Tuesday, 2017-06-13

mriedemwith the microversion, we could get non-compute things again, or just close that weird gap00:00
mriedemprobably better to restrict to nova-compute services for things like enable/disable/forced_down00:00
*** crushil has quit IRC00:00
*** crushil has joined #openstack-nova00:01
*** gomarivera has joined #openstack-nova00:03
*** catintheroof has quit IRC00:03
*** crushil has quit IRC00:07
*** crushil has joined #openstack-nova00:07
dansmithmriedem: you mean after we made the change it's 404 now instead of 200 right?00:08
*** catintheroof has joined #openstack-nova00:11
*** markvoelker has quit IRC00:11
mriedemyes00:12
mriedemwe could get it back to a 200, but it seems better to just fix the weird behavior we used to allow00:12
mriedemthis would be good to remember for when someone shows up in a year asking why their weird script no longer disables nova-scheduler services...00:13
dansmithagreed00:13
dansmithnot sure 404 is the right thing though00:13
dansmithsince we expose the service, they did a PUT on it.. probably needs to be 499: Dumbass or something00:13
*** acormier has joined #openstack-nova00:14
mriedemor a 40000:14
mriedembut yeah00:14
mriedemanyway have to run for a bit00:14
*** mriedem has quit IRC00:14
*** claudiub|2 has quit IRC00:16
*** dtp has quit IRC00:19
*** catintheroof has quit IRC00:25
*** crushil has quit IRC00:25
*** jwcroppe has joined #openstack-nova00:33
*** ijw has joined #openstack-nova00:33
*** Guest77651 has quit IRC00:34
*** mdnadeem has joined #openstack-nova00:38
*** huanxie has joined #openstack-nova00:39
*** jwcroppe has quit IRC00:43
*** jwcroppe has joined #openstack-nova00:43
*** zhurong has joined #openstack-nova00:44
*** tovin07_ has joined #openstack-nova00:48
*** Guest77651 has joined #openstack-nova00:48
*** baoli has joined #openstack-nova00:49
*** huanxie has quit IRC00:49
*** lucasxu has joined #openstack-nova00:49
*** armax has quit IRC00:50
*** tbachman has quit IRC00:52
*** armax has joined #openstack-nova00:53
*** hongbin has quit IRC00:54
*** boris-42_ has quit IRC00:59
*** salv-orlando has joined #openstack-nova01:02
*** phuongnh has joined #openstack-nova01:03
*** esberglu has quit IRC01:04
*** esberglu has joined #openstack-nova01:04
*** dimtruck is now known as zz_dimtruck01:05
*** ijw has quit IRC01:05
*** salv-orlando has quit IRC01:06
*** esberglu has quit IRC01:09
*** rajathagasthya has quit IRC01:13
*** cNilesh has joined #openstack-nova01:13
*** rajathagasthya has joined #openstack-nova01:13
*** litao__ has joined #openstack-nova01:15
*** salv-orlando has joined #openstack-nova01:16
*** dave-mccowan has joined #openstack-nova01:17
*** salv-orlando has quit IRC01:20
Kevin_Zhengmriedem: assigned01:22
*** ijw has joined #openstack-nova01:23
*** ijw has quit IRC01:23
*** gjayavelu has quit IRC01:23
*** owalsh-pto has quit IRC01:26
*** owalsh has joined #openstack-nova01:28
*** Yangyapeng has joined #openstack-nova01:33
*** coreywright has quit IRC01:33
*** thorst_afk has joined #openstack-nova01:33
*** huanxie has joined #openstack-nova01:35
*** markvoelker has joined #openstack-nova01:36
*** yamahata has quit IRC01:36
*** lucasxu has quit IRC01:37
*** acormier has quit IRC01:38
*** acormier has joined #openstack-nova01:38
*** acormier has quit IRC01:39
*** acormier has joined #openstack-nova01:39
*** kenperkins has joined #openstack-nova01:40
*** acormier has quit IRC01:41
*** acormier has joined #openstack-nova01:41
*** gouthamr has quit IRC01:42
*** thorst_afk has quit IRC01:43
*** mdrabe has quit IRC01:46
*** mdrabe has joined #openstack-nova01:46
openstackgerritNgo Quoc Cuong proposed openstack/nova master: Remove translation of log messages  https://review.openstack.org/46699501:46
*** coreywright has joined #openstack-nova01:52
*** jichen has joined #openstack-nova01:54
*** mingyu has joined #openstack-nova01:55
*** Apoorva_ has joined #openstack-nova01:55
*** Apoorva has quit IRC01:59
*** Apoorva_ has quit IRC01:59
*** mingyu has quit IRC02:04
*** bkopilov has quit IRC02:06
*** zhurong has quit IRC02:07
*** dikonoo has joined #openstack-nova02:07
*** tuanluong has joined #openstack-nova02:13
*** thorst_afk has joined #openstack-nova02:13
*** nicolasbock has joined #openstack-nova02:17
*** thorst_afk has quit IRC02:23
*** thorst_afk has joined #openstack-nova02:24
*** thorst_afk has quit IRC02:24
*** yamamoto has joined #openstack-nova02:25
*** baoli has quit IRC02:26
*** baoli has joined #openstack-nova02:27
*** Shunli has joined #openstack-nova02:28
*** baoli has quit IRC02:28
*** winston-d_ has joined #openstack-nova02:30
*** kenperkins has quit IRC02:42
*** itlinux_ has joined #openstack-nova02:43
*** gomarivera has quit IRC02:50
*** gomarivera has joined #openstack-nova02:51
*** itlinux_ has quit IRC02:51
*** gouthamr has joined #openstack-nova02:53
*** rajathagasthya has quit IRC02:54
*** thorst_afk has joined #openstack-nova02:54
*** hongbin has joined #openstack-nova02:55
*** gomarivera has quit IRC02:55
*** zz_dimtruck is now known as dimtruck02:56
*** baoli has joined #openstack-nova02:57
*** baoli has quit IRC02:58
*** baoli has joined #openstack-nova02:59
*** vladikr has quit IRC03:00
*** ssurana has joined #openstack-nova03:00
*** ssurana has quit IRC03:00
*** mingyu has joined #openstack-nova03:01
*** baoli has quit IRC03:03
*** ijw has joined #openstack-nova03:03
*** ijw has quit IRC03:07
*** sridharg has joined #openstack-nova03:09
*** thorst_afk has quit IRC03:14
*** salv-orlando has joined #openstack-nova03:17
*** mdrabe_ has joined #openstack-nova03:17
*** dimtruck is now known as zz_dimtruck03:17
openstackgerritfalseuser proposed openstack/nova master: Delete the instance files after revert a resize task  https://review.openstack.org/46981403:18
*** mdrabe has quit IRC03:20
*** salv-orlando has quit IRC03:21
*** dave-mccowan has quit IRC03:26
*** mdrabe_ has quit IRC03:27
*** coreywright has quit IRC03:31
*** mingyu has quit IRC03:38
*** mingyu has joined #openstack-nova03:38
*** mingyu has quit IRC03:38
*** kenperkins has joined #openstack-nova03:41
*** mingyu has joined #openstack-nova03:44
*** rfolco has quit IRC03:47
*** hongbin has quit IRC03:48
*** itlinux_ has joined #openstack-nova03:48
*** coreywright has joined #openstack-nova03:48
*** itlinux_ has quit IRC03:49
*** zhurong has joined #openstack-nova03:49
*** armax has quit IRC03:50
*** itlinux_ has joined #openstack-nova03:54
melwittgit status03:55
melwittdangit.03:55
openstackgerritmelanie witt proposed openstack/nova master: Add FixedIPList.get_count_by_project()  https://review.openstack.org/44624603:58
openstackgerritmelanie witt proposed openstack/nova master: Add FloatingIPList.get_count_by_project()  https://review.openstack.org/44624703:58
openstackgerritmelanie witt proposed openstack/nova master: Add get_count_by_vm_state() to InstanceList object  https://review.openstack.org/44624403:58
openstackgerritmelanie witt proposed openstack/nova master: Add SecurityGroupList.get_counts()  https://review.openstack.org/44624503:58
openstackgerritmelanie witt proposed openstack/nova master: Remove 'reserved' count from used limits  https://review.openstack.org/44624203:58
openstackgerritmelanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage  https://review.openstack.org/44624303:58
openstackgerritmelanie witt proposed openstack/nova master: Count networks to check quota  https://review.openstack.org/44624103:58
openstackgerritmelanie witt proposed openstack/nova master: Count instances to check quota  https://review.openstack.org/41652103:58
openstackgerritmelanie witt proposed openstack/nova master: Count server group members to check quota  https://review.openstack.org/45785903:58
openstackgerritmelanie witt proposed openstack/nova master: Count security groups to check quota  https://review.openstack.org/45786003:58
openstackgerritmelanie witt proposed openstack/nova master: Make Quotas object favor the API database  https://review.openstack.org/41094503:58
openstackgerritmelanie witt proposed openstack/nova master: Count fixed ips to check quota  https://review.openstack.org/45786103:58
openstackgerritmelanie witt proposed openstack/nova master: Add online migration to move quotas to API database  https://review.openstack.org/41094603:58
openstackgerritmelanie witt proposed openstack/nova master: Count floating ips to check quota  https://review.openstack.org/45786203:58
*** diga has joined #openstack-nova03:58
*** gcb has quit IRC03:58
*** itlinux_ has quit IRC03:59
*** baoli has joined #openstack-nova04:00
*** bkopilov has joined #openstack-nova04:00
openstackgerritfalseuser proposed openstack/nova master: Clear instance root_device_name in rebuild operation  https://review.openstack.org/46499104:04
*** esberglu has joined #openstack-nova04:04
*** mingyu has quit IRC04:05
*** baoli has quit IRC04:06
*** itlinux has joined #openstack-nova04:06
*** zz_dimtruck is now known as dimtruck04:08
*** esberglu has quit IRC04:09
*** psachin has joined #openstack-nova04:09
*** mingyu has joined #openstack-nova04:10
*** ratailor has joined #openstack-nova04:10
*** thorst_afk has joined #openstack-nova04:11
openstackgerritfalseuser proposed openstack/nova master: Add img_linked_clone support in libvirt  https://review.openstack.org/47336204:14
*** mingyu has quit IRC04:15
*** zerda3 has joined #openstack-nova04:16
*** yamahata has joined #openstack-nova04:20
*** dimtruck is now known as zz_dimtruck04:21
*** mdrabe has joined #openstack-nova04:23
openstackgerritmelanie witt proposed openstack/nova master: placement project_id, user_id in PUT /allocations  https://review.openstack.org/46963404:25
openstackgerritmelanie witt proposed openstack/nova master: placement: Add GET /usages to placement API  https://review.openstack.org/46963504:25
*** zhurong has quit IRC04:27
*** thorst_afk has quit IRC04:30
*** links has joined #openstack-nova04:32
*** zhurong has joined #openstack-nova04:33
*** mdrabe has quit IRC04:35
*** zerda3 has quit IRC04:40
*** kenperkins has quit IRC04:41
*** adisky__ has joined #openstack-nova04:42
*** bkopilov has quit IRC04:43
*** salv-orlando has joined #openstack-nova04:43
openstackgerritNgo Quoc Cuong proposed openstack/nova master: Remove translation of log messages  https://review.openstack.org/46794804:46
*** gyee has quit IRC04:47
openstackgerritfalseuser proposed openstack/nova master: [BugFix] Include the video ram when comparing the difference of two flavors  https://review.openstack.org/46038804:49
*** mvpnitesh has joined #openstack-nova04:50
*** udesale has joined #openstack-nova04:52
*** itlinux has quit IRC04:54
*** dikonoor has joined #openstack-nova04:56
openstackgerritHuan Xie proposed openstack/nova master: XenAPI: Create linux bridge in dest host during live migration  https://review.openstack.org/46201704:56
*** oanson has quit IRC04:59
*** oanson_ has joined #openstack-nova04:59
*** dikonoo has quit IRC04:59
*** dikonoo has joined #openstack-nova04:59
*** oanson_ is now known as oanson04:59
*** dikonoor has quit IRC05:01
*** salv-orl_ has joined #openstack-nova05:03
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi: cached images should be cleaned up by time  https://review.openstack.org/46595405:03
*** salv-orlando has quit IRC05:05
*** cfriesen has quit IRC05:05
*** acormier has quit IRC05:06
*** acormier has joined #openstack-nova05:06
*** slaweq has joined #openstack-nova05:08
*** slaweq has quit IRC05:08
openstackgerritfalseuser proposed openstack/nova master: [BugFix] Change the condition to delete a resizing instance  https://review.openstack.org/46346605:10
*** acormier has quit IRC05:10
*** bkopilov has joined #openstack-nova05:10
*** sree has joined #openstack-nova05:11
*** dikonoor has joined #openstack-nova05:12
*** dikonoo has quit IRC05:14
*** kornicameister has quit IRC05:17
*** vks1 has joined #openstack-nova05:19
*** bkopilov has quit IRC05:23
*** gouthamr has quit IRC05:23
*** amotoki_away is now known as amotoki05:27
*** gcb has joined #openstack-nova05:30
*** jwcroppe_ has joined #openstack-nova05:31
*** jwcroppe has quit IRC05:32
*** krtaylor has quit IRC05:33
*** ekuris has joined #openstack-nova05:34
*** efried has quit IRC05:34
*** esberglu has joined #openstack-nova05:34
*** gszasz has joined #openstack-nova05:36
*** slaweq has joined #openstack-nova05:36
*** bkopilov has joined #openstack-nova05:36
*** esberglu has quit IRC05:38
melwittalex_xu: hey, just saw your review comment about the status code 406. I thought because of the trace you showed earlier, it would be 400? http://logs.openstack.org/34/469634/12/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/56d8abe/logs/screen-n-cpu.txt.gz#_Jun_12_22_00_17_70795305:41
openstackgerritNaichuan Sun proposed openstack/nova master: XenAPI: device tagging  https://review.openstack.org/33378105:41
*** slaweq has quit IRC05:41
alex_xumelwitt: that 400 is for user_id and project_id doesn't know by the old API. If we request a microversion, the api server doesn't know, the 406 will returned05:42
melwittalex_xu: ah, gotcha. thanks05:43
alex_xumelwitt: np05:43
alex_xumelwitt: an example https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L71805:44
melwittcool, thank you05:45
alex_xuyw05:45
*** gcb has quit IRC05:46
*** gcb has joined #openstack-nova05:46
*** efried has joined #openstack-nova05:50
*** krtaylor has joined #openstack-nova05:51
*** mamandle has joined #openstack-nova05:54
*** zz_dimtruck is now known as dimtruck05:56
*** edmondsw has joined #openstack-nova05:56
*** mingyu has joined #openstack-nova05:56
openstackgerritNgo Quoc Cuong proposed openstack/nova master: Remove translation of log messages  https://review.openstack.org/46663706:01
*** edmondsw has quit IRC06:01
*** baoli has joined #openstack-nova06:03
*** rcernin has joined #openstack-nova06:05
*** dimtruck is now known as zz_dimtruck06:05
*** pcaruana has joined #openstack-nova06:06
*** mingyu has quit IRC06:07
*** baoli has quit IRC06:08
*** hferenc has joined #openstack-nova06:09
*** mingyu has joined #openstack-nova06:09
*** andreas_s has joined #openstack-nova06:12
*** CristinaPauna has quit IRC06:13
*** Oku_OS-away is now known as Oku_OS06:13
openstackgerritmelanie witt proposed openstack/nova master: placement project_id, user_id in PUT /allocations  https://review.openstack.org/46963406:13
openstackgerritmelanie witt proposed openstack/nova master: placement: Add GET /usages to placement API  https://review.openstack.org/46963506:13
*** kornicameister has joined #openstack-nova06:15
*** ltomasbo|away is now known as ltomasbo06:17
*** mvpnitesh has quit IRC06:20
*** mvpnitesh has joined #openstack-nova06:20
*** mingyu has quit IRC06:23
*** markvoelker has quit IRC06:25
*** thorst_afk has joined #openstack-nova06:27
*** mingyu has joined #openstack-nova06:28
*** thorst_afk has quit IRC06:32
*** sree has quit IRC06:34
*** sree has joined #openstack-nova06:35
*** roeyc has joined #openstack-nova06:36
*** slaweq has joined #openstack-nova06:37
*** sree has quit IRC06:38
*** sree has joined #openstack-nova06:38
*** tesseract has joined #openstack-nova06:41
*** slaweq has quit IRC06:42
*** salv-orl_ has quit IRC06:45
*** salv-orlando has joined #openstack-nova06:46
*** markus_z has joined #openstack-nova06:49
*** roeyc has quit IRC06:51
*** zz_dimtruck is now known as dimtruck06:56
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2)  https://review.openstack.org/43060806:57
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2)  https://review.openstack.org/45948307:01
openstackgerritZhenyu Zheng proposed openstack/nova master: Add host/binary request query filter parameters for GET /os-services API  https://review.openstack.org/47370807:02
*** baoli has joined #openstack-nova07:04
*** salv-orlando has quit IRC07:05
*** salv-orlando has joined #openstack-nova07:05
*** dimtruck is now known as zz_dimtruck07:06
*** rmart04 has joined #openstack-nova07:07
*** baoli has quit IRC07:08
*** damien_r has joined #openstack-nova07:13
*** rmart04 has quit IRC07:17
*** jaosorior_away is now known as jaosorior07:18
*** esberglu has joined #openstack-nova07:22
openstackgerritZhenyu Zheng proposed openstack/nova master: Add host/binary request query filter parameters for GET /os-services API  https://review.openstack.org/47370807:25
*** esberglu has quit IRC07:26
*** thorst_afk has joined #openstack-nova07:28
*** qwertyco has joined #openstack-nova07:30
*** roeyc has joined #openstack-nova07:31
*** jpena|off is now known as jpena07:31
*** thorst_afk has quit IRC07:32
*** yamahata has quit IRC07:33
*** pewp has quit IRC07:34
*** pewp has joined #openstack-nova07:37
*** fragatina has joined #openstack-nova07:37
*** priteau has joined #openstack-nova07:38
*** sridharg has quit IRC07:39
*** tojuvone has quit IRC07:41
*** tojuvone has joined #openstack-nova07:41
*** mingyu has quit IRC07:41
*** qwertyco has quit IRC07:43
*** CristinaPauna has joined #openstack-nova07:45
*** ralonsoh has joined #openstack-nova07:45
*** gomarivera has joined #openstack-nova07:51
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi: cached images should be cleaned up by time  https://review.openstack.org/46595407:52
*** sridharg has joined #openstack-nova07:52
*** zhurong has quit IRC07:55
*** gomarivera has quit IRC07:56
*** sridharg has quit IRC07:56
*** zz_dimtruck is now known as dimtruck07:57
openstackgerritZhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4)  https://review.openstack.org/46980007:57
*** qwertyco has joined #openstack-nova07:58
*** sridharg has joined #openstack-nova07:58
*** karimb has joined #openstack-nova07:58
*** zzzeek has quit IRC08:00
*** ltomasbo is now known as ltomasbo|away08:00
*** zzzeek has joined #openstack-nova08:00
openstackgerritfalseuser proposed openstack/nova master: Ensure the root device will be replaced in rebuild operation  https://review.openstack.org/46758808:03
*** alexchadin has joined #openstack-nova08:06
*** mingyu has joined #openstack-nova08:07
*** aarefiev_afk is now known as aarefiev08:07
*** dimtruck is now known as zz_dimtruck08:09
*** kornicameister has quit IRC08:10
*** mvpnitesh has quit IRC08:12
*** yingjun_1 has joined #openstack-nova08:12
*** lucas-afk is now known as lucasagomes08:17
openstackgerritZhenyu Zheng proposed openstack/nova master: Add missing query filter params for GET /os-services API  https://review.openstack.org/47370808:19
*** ltomasbo|away is now known as ltomasbo08:23
*** markvoelker has joined #openstack-nova08:26
*** mingyu has quit IRC08:26
*** f10d4 has joined #openstack-nova08:27
f10d4hi08:27
f10d4gibi: szia08:27
bauzasp!spy08:27
*** mingyu has joined #openstack-nova08:28
*** thorst_afk has joined #openstack-nova08:29
*** yamamoto has quit IRC08:30
*** karimb has quit IRC08:31
*** thorst_afk has quit IRC08:33
*** kwathore has quit IRC08:35
*** yamamoto has joined #openstack-nova08:35
*** mingyu has quit IRC08:40
*** dtantsur|afk is now known as dtantsur08:40
*** kwathore has joined #openstack-nova08:43
*** derekh has joined #openstack-nova08:47
gibif10d4: szia08:48
*** mingyu has joined #openstack-nova08:50
*** claudiub|2 has joined #openstack-nova08:52
*** ltomasbo is now known as ltomasbo|away08:52
*** sambetts|afk is now known as sambetts08:54
*** karimb has joined #openstack-nova08:59
*** markvoelker has quit IRC08:59
*** zz_dimtruck is now known as dimtruck09:00
*** mingyu has quit IRC09:01
*** rmart04 has joined #openstack-nova09:03
*** vks1 has quit IRC09:05
*** zhurong has joined #openstack-nova09:06
*** dimtruck is now known as zz_dimtruck09:10
*** esberglu has joined #openstack-nova09:10
*** efoley has joined #openstack-nova09:12
*** esberglu has quit IRC09:14
openstackgerritGábor Antal proposed openstack/nova master: Transform instance.resize_prep notification  https://review.openstack.org/46508109:15
*** priteau has quit IRC09:16
*** yamamoto has quit IRC09:19
*** dgonzalez_ has joined #openstack-nova09:21
*** david_ has joined #openstack-nova09:21
*** tpatzig_ has joined #openstack-nova09:21
*** david_ has quit IRC09:23
*** dgonzalez_ has quit IRC09:23
*** tpatzig_ has quit IRC09:23
*** karimb has quit IRC09:25
*** thorst_afk has joined #openstack-nova09:29
*** Shunli has quit IRC09:30
*** edmondsw has joined #openstack-nova09:32
*** mvk has joined #openstack-nova09:33
*** alexchadin has quit IRC09:36
*** yamamoto has joined #openstack-nova09:36
*** edmondsw has quit IRC09:37
*** yamamoto has quit IRC09:37
*** mvpnitesh has joined #openstack-nova09:38
*** karimb has joined #openstack-nova09:39
*** yingjun_1 has quit IRC09:40
*** takashin has left #openstack-nova09:41
*** sridharg has quit IRC09:43
*** sridharg has joined #openstack-nova09:43
*** jichen has quit IRC09:46
*** mvpnitesh has quit IRC09:46
*** mvpnitesh has joined #openstack-nova09:46
*** kornicameister has joined #openstack-nova09:47
*** thorst_afk has quit IRC09:49
*** mdnadeem has quit IRC09:51
*** yamamoto has joined #openstack-nova09:54
*** damien_r has quit IRC09:55
*** ayogi has joined #openstack-nova09:56
*** markvoelker has joined #openstack-nova09:57
*** alexchadin has joined #openstack-nova09:57
*** dtantsur is now known as dtantsur|brb09:58
*** tovin07_ has quit IRC09:59
*** cdent has joined #openstack-nova09:59
*** zz_dimtruck is now known as dimtruck10:00
*** mingyu has joined #openstack-nova10:01
*** lpetrut has joined #openstack-nova10:01
*** mvpnitesh has quit IRC10:04
*** mvpnitesh has joined #openstack-nova10:04
*** mingyu has quit IRC10:06
*** baoli has joined #openstack-nova10:07
*** cNilesh has quit IRC10:08
*** liujiong has quit IRC10:09
*** dimtruck is now known as zz_dimtruck10:10
*** baoli has quit IRC10:12
*** Alex_____ has joined #openstack-nova10:12
*** ratailor has quit IRC10:14
*** zhurong has quit IRC10:20
*** kwathore_ has joined #openstack-nova10:21
*** kwathore has quit IRC10:21
*** oanson has quit IRC10:21
*** phuongnh has quit IRC10:22
*** yamamoto has quit IRC10:23
*** oanson has joined #openstack-nova10:24
*** ratailor has joined #openstack-nova10:27
*** markvoelker has quit IRC10:30
*** smatzek has joined #openstack-nova10:30
openstackgerritPooja Jadhav proposed openstack/nova master: Nova flavor-list swap should be 0 when no value is specified  https://review.openstack.org/47171510:31
*** huanxie has quit IRC10:31
openstackgerritfalseuser proposed openstack/nova master: Ensure the root device will be replaced in rebuild operation  https://review.openstack.org/46758810:37
*** smatzek has quit IRC10:42
*** zhurong has joined #openstack-nova10:43
*** slaweq has joined #openstack-nova10:43
*** thorst_afk has joined #openstack-nova10:46
johnthetubaguybauzas: did you ever take a look at this cold migrate patches? https://review.openstack.org/#/c/40895510:47
johnthetubaguybauzas: super related to the live-migrate work you did10:47
*** slaweq has quit IRC10:48
*** sdague has joined #openstack-nova10:49
*** thorst_afk has quit IRC10:50
*** cdent has quit IRC10:51
*** bkopilov has quit IRC10:52
*** dtantsur|brb is now known as dtantsur10:53
*** yamamoto has joined #openstack-nova10:57
*** esberglu has joined #openstack-nova10:58
mdboothVery quickly, before I knock up a quick script to create some default flavors, network, and cirros glance image, does this already exist in a re-usable form?11:01
*** zz_dimtruck is now known as dimtruck11:01
*** esberglu has quit IRC11:03
*** salv-orl_ has joined #openstack-nova11:03
*** ltomasbo|away is now known as ltomasbo11:05
*** salv-orlando has quit IRC11:06
*** lucasagomes is now known as lucas-hungry11:08
*** vladikr has joined #openstack-nova11:10
*** dimtruck is now known as zz_dimtruck11:11
*** sree has quit IRC11:13
*** sree has joined #openstack-nova11:13
*** sree has quit IRC11:18
*** ijw has joined #openstack-nova11:19
kashyapmdbooth: In a DevStack env?11:21
mdboothkashyap: In an openstack cloud11:21
* kashyap nods11:22
mdboothMight be devstack, but isn't in my particular case11:22
kashyapHmm, not that I know of; but probably you might want to ask in #tripleo?11:23
*** ijw has quit IRC11:23
kashyapAs they do this stuff fairly often, and may have the adhoc scripts to do such tasks11:23
*** BlackDex has quit IRC11:26
*** udesale has quit IRC11:27
*** markvoelker has joined #openstack-nova11:27
*** BlackDex has joined #openstack-nova11:28
*** dave-mccowan has joined #openstack-nova11:28
*** gabor_antal has joined #openstack-nova11:28
kashyap mdbooth Oh, forgot, I normally use this to setup networking post DevStack install - https://kashyapc.fedorapeople.org/virt/openstack/Neutron-setup-post-DevStack.bash11:29
kashyapIt simply does the following: associates the router to the gateway; adds security group rules; and sets up floating IP11:30
openstackgerritBalazs Gibizer proposed openstack/nova master: remove ugly local import  https://review.openstack.org/45078711:30
openstackgerritBalazs Gibizer proposed openstack/nova master: remove get_nw_info_for_instance from compute.utils  https://review.openstack.org/45138711:30
*** Yangyapeng has quit IRC11:31
*** yamamoto has quit IRC11:31
*** sridharg has quit IRC11:33
openstackgerritBalazs Gibizer proposed openstack/nova master: Add BDM to InstancePayload  https://review.openstack.org/44877911:37
*** cdent has joined #openstack-nova11:38
*** smatzek has joined #openstack-nova11:38
*** alexchadin has quit IRC11:39
*** alexchadin has joined #openstack-nova11:40
*** alexchadin has quit IRC11:40
*** alexchadin has joined #openstack-nova11:41
*** alexchadin has quit IRC11:41
*** alexchadin has joined #openstack-nova11:42
*** alexchadin has quit IRC11:42
*** alexchadin has joined #openstack-nova11:42
*** alexchadin has quit IRC11:43
*** alexchadin has joined #openstack-nova11:43
*** alexchadin has quit IRC11:43
*** gszasz has quit IRC11:44
*** alexchadin has joined #openstack-nova11:44
*** alexchadin has quit IRC11:44
*** slaweq has joined #openstack-nova11:44
*** diga has quit IRC11:44
*** alexchadin has joined #openstack-nova11:45
*** yamamoto has joined #openstack-nova11:46
*** slaweq has quit IRC11:49
*** alexchadin has quit IRC11:49
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements  https://review.openstack.org/47281411:50
*** yamamoto has quit IRC11:50
*** zz_dimtruck is now known as dimtruck11:50
*** pchavva has joined #openstack-nova11:51
*** sridharg has joined #openstack-nova11:51
*** d9k has quit IRC11:51
*** thorst_afk has joined #openstack-nova11:52
*** d9k has joined #openstack-nova11:53
*** litao__ has quit IRC11:55
*** jpena is now known as jpena|lunch11:55
*** ratailor has quit IRC11:58
*** karimb has quit IRC11:59
*** markvoelker has quit IRC11:59
*** Yangyapeng has joined #openstack-nova11:59
*** jheroux has joined #openstack-nova12:00
*** roeyc has quit IRC12:02
*** damien_r has joined #openstack-nova12:03
*** tuanluong has quit IRC12:04
*** mamandle has quit IRC12:04
*** ekuris has quit IRC12:05
*** liverpooler has joined #openstack-nova12:06
*** baoli has joined #openstack-nova12:08
*** baoli has quit IRC12:13
*** ratailor has joined #openstack-nova12:16
*** jamesdenton has joined #openstack-nova12:16
*** yamamoto has joined #openstack-nova12:16
*** sridharg has quit IRC12:16
*** pewp has quit IRC12:17
*** openstackgerrit has quit IRC12:18
*** lucas-hungry is now known as lucasagomes12:19
*** pewp has joined #openstack-nova12:19
*** Oku_OS is now known as Oku_OS-away12:19
*** zhurong has quit IRC12:19
*** yamamoto has quit IRC12:20
*** cdent has quit IRC12:22
*** ltomasbo is now known as ltomasbo|away12:22
*** d9k has quit IRC12:23
*** d9k has joined #openstack-nova12:24
*** sridharg has joined #openstack-nova12:24
*** markvoelker has joined #openstack-nova12:25
*** Oku_OS-away is now known as Oku_OS12:26
*** edmondsw has joined #openstack-nova12:26
*** CristinaPauna has quit IRC12:30
*** bkopilov has joined #openstack-nova12:31
*** kwathore_ has quit IRC12:31
bauzasjohnthetubaguy: sure, will look12:33
*** kwathore has joined #openstack-nova12:33
*** catintheroof has joined #openstack-nova12:33
*** karimb has joined #openstack-nova12:33
*** cdent has joined #openstack-nova12:34
*** gszasz has joined #openstack-nova12:45
*** awaugama has joined #openstack-nova12:45
*** slaweq has joined #openstack-nova12:45
*** alexchadin has joined #openstack-nova12:45
*** baoli has joined #openstack-nova12:46
*** esberglu has joined #openstack-nova12:46
*** baoli has quit IRC12:47
*** baoli has joined #openstack-nova12:48
*** alexchadin has quit IRC12:50
*** rfolco has joined #openstack-nova12:50
*** slaweq has quit IRC12:50
*** lyan has joined #openstack-nova12:50
*** Yangyapeng has quit IRC12:50
*** esberglu has quit IRC12:51
*** jdurgin has joined #openstack-nova12:53
*** gomarivera has joined #openstack-nova12:54
*** pkoniszewski has quit IRC12:54
cdentedleafe: are you planning to push to https://review.openstack.org/#/c/473627/ soon? if so I'll wait to review. your responses to dtantsur suggest yes-ish12:57
*** alexchadin has joined #openstack-nova12:57
*** jpena|lunch is now known as jpena12:58
*** gomarivera has quit IRC12:58
*** esberglu has joined #openstack-nova13:00
*** slaweq has joined #openstack-nova13:01
*** yamamoto has joined #openstack-nova13:01
*** openstackgerrit has joined #openstack-nova13:02
openstackgerritMerged openstack/nova master: Add bool_from_string for force-down action  https://review.openstack.org/47356413:02
*** roeyc has joined #openstack-nova13:02
mordredcdent: I have found two new and interesting tidbits that don't seem to be reflected in nova's api docs13:03
cdentmordred: I'd expect nothing less from you13:03
mordredcdent: the first is that if you're booting from volume, you apparently need to POST to /os-volumes_boot instead of /servers (at least, that's what novaclient does)13:03
*** huanxie has joined #openstack-nova13:03
sdaguemordred: that doesn't seem right13:04
mordredcdent: the second is that if you are booting from an image but attaching volumes at boot via block_device_mapping, you need to pass the image in the block_device_mapping wiht a destination_type of local:13:04
mordredhttps://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L737-L74513:04
cdentmordred: you've used the two red flag terms: "boot from volume" and "bdm"13:04
mordredsdague: https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L1424-L143113:05
mordredsdague: if that's not needed, I'll happily change it in shade and send a patch for novaclient13:05
sdaguemordred: https://github.com/openstack/nova/blob/d3de541784b094e32cf66e1759fc73781f031607/nova/api/openstack/compute/routes.py#L303-L30413:05
sdagueyeh, it looks like it's a route that was merged a long time ago13:05
mordredawesome13:05
mordredI'll send a novaclient patch13:05
*** slaweq has quit IRC13:06
*** yamamoto has quit IRC13:06
sdaguethat warrents a pickaxe journey13:06
edleafecdent: yeah, just running tests before pushing13:07
cdentdon't forget your headlamp13:07
cdentedleafe: ✔13:07
*** gbarros has joined #openstack-nova13:07
cdentmordred: so the concern on the second point is that there's some magical fiddling that's being done in novaclient (and is required to get proper behavior) but the docs don't say so?13:08
openstackgerritMonty Taylor proposed openstack/python-novaclient master: Stop posting to os-volumes_boot  https://review.openstack.org/47383313:08
mordredcdent: yes. it's not bad behavior - in fact, it makes total sense13:09
*** dimtruck is now known as zz_dimtruck13:09
mordredbut it was surprising to me13:09
*** mdrabe has joined #openstack-nova13:09
mordredI'm not sure the BEST way to document that though13:09
openstackgerritEd Leafe proposed openstack/nova master: Extract custom resource classes from flavors  https://review.openstack.org/47362713:09
edleafecdent: dtantsur: ^^13:10
*** eharney has joined #openstack-nova13:10
dtantsurthanks! will get back to it after the meeting(s)13:10
cdentmordred: start with BETTER and then maybe BEST will reveal itself?13:10
*** xyang1 has joined #openstack-nova13:10
*** huanxie has quit IRC13:11
mordredcdent: you're trying to entice me to document block_device_mapping comprehensively, I can feel it13:11
*** awaugama has quit IRC13:11
* edleafe eggs mordred on too13:11
cdentI wouldn't want to get in the way of your feelings13:11
sdaguemordred: it definitely started off as a whole different extension - https://github.com/openstack/nova/commit/97503418bea47ca38d2181e5dc5fa710d6e15df313:11
sdagueI'm still having trouble figuring out where it merged13:12
*** ekuris has joined #openstack-nova13:12
openstackgerritFeodor Tersin proposed openstack/nova master: POC: Imagebackend - on cold migration  https://review.openstack.org/47383513:12
ftersinmdbooth: hi. i tried to refactor that code partially. ^^^^13:13
ftersinmdbooth: but... this is still inconsistent, does not look correct, and requires much more refactoring13:15
ftersinmdbooth: so... i have to admit that i've gave up. i do not know how to do there 'not a big one' refactoring13:16
ftersinmdbooth: if you have other idea, pls, suggest me smth13:17
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements  https://review.openstack.org/47281413:17
mdboothftersin: In a meeting, will try to look today.13:17
*** lucasxu has joined #openstack-nova13:18
*** CristinaPauna has joined #openstack-nova13:18
*** dikonoo has joined #openstack-nova13:18
*** mdrabe has quit IRC13:19
ftersinmdbooth: ok, thx13:19
*** dikonoo has quit IRC13:20
*** mdrabe has joined #openstack-nova13:20
*** cleong has joined #openstack-nova13:21
openstackgerritFeodor Tersin proposed openstack/nova master: Implement ScaleIO image backend  https://review.openstack.org/40744013:21
*** mvpnitesh has quit IRC13:22
*** dikonoor has quit IRC13:22
*** mriedem has joined #openstack-nova13:23
*** jwcroppe_ has quit IRC13:23
*** Apoorva has joined #openstack-nova13:24
*** ratailor has quit IRC13:25
mriedemefried: is this done now, the services tokens series https://review.openstack.org/#/q/topic:bp/use-service-tokens13:27
mriedemall that's left is dnm testing patches13:27
efriedmriedem I believe it is, but was hoping someone else could verify13:27
efriedPut another way, you beat me to the question ;-)13:28
mriedembased on the work items in the spec https://review.openstack.org/#/c/426933/5/specs/pike/approved/use-service-tokens.rst@166 i'd say it's done13:29
mriedemactually13:30
mriedemdo we actually send the service user tokens with glance requestes?13:30
mriedem*requests13:30
efriedmriedem I believe by virtue of https://review.openstack.org/#/c/419662/13:31
mriedemah, the topic was different so i missed that one13:32
efriedYeah.13:32
*** jaosorior has quit IRC13:32
*** jaosorior has joined #openstack-nova13:32
efriedmriedem I'm not going to be able to abandon the DNMs, cause I don't own 'em.  Is that something you have the power to do?13:32
mriedemi can do that13:32
efriedCool cool.13:33
*** links has quit IRC13:33
*** jianghuaw_ has joined #openstack-nova13:33
mriedemsdague: want to abandon this? https://review.openstack.org/#/c/416733/13:34
sdaguemriedem: looking13:35
*** clayton has quit IRC13:35
sdaguesure13:35
sdaguedid we run a test to make sure this was all working as expected?13:35
*** psachin has quit IRC13:35
mriedemsdague: it's enabled in the nova-next job13:36
sdaguemriedem: right, but unless you tune down the timeouts13:36
sdagueyou aren't going to hit it in a gate job13:36
mriedemthat's what the abandoned nova dnm patches were for13:36
*** gouthamr has joined #openstack-nova13:36
sdagueok, sure13:36
mriedemthey enabled it and did a long sleep during something like live migration13:36
sdagueok, sounds good13:36
*** clayton has joined #openstack-nova13:37
*** jwcroppe has joined #openstack-nova13:37
*** jaypipes has joined #openstack-nova13:38
*** gomarivera has joined #openstack-nova13:39
*** fragatina has quit IRC13:39
*** fragatina has joined #openstack-nova13:40
*** jianghuaw_ has quit IRC13:43
*** jamesden_ has joined #openstack-nova13:44
*** jamesdenton has quit IRC13:45
*** jianghuaw_ has joined #openstack-nova13:46
*** roeyc has quit IRC13:46
openstackgerritBéla Vancsics proposed openstack/nova master: Reduced the complexity of the _init_instance method  https://review.openstack.org/37466113:47
*** Apoorva has quit IRC13:48
*** cdent has quit IRC13:51
*** abalutoiu has joined #openstack-nova13:52
*** eharney has quit IRC13:52
*** vks1 has joined #openstack-nova13:56
*** sree has joined #openstack-nova13:56
*** karimb has quit IRC13:56
*** eharney has joined #openstack-nova13:56
*** karimb has joined #openstack-nova13:57
*** roeyc has joined #openstack-nova14:00
*** tbachman has joined #openstack-nova14:01
*** tidwellr has joined #openstack-nova14:01
*** slaweq has joined #openstack-nova14:02
openstackgerritStephen Finucane proposed openstack/nova master: Use plain routes list for user_data instead of stevedore  https://review.openstack.org/46218314:04
openstackgerritStephen Finucane proposed openstack/nova master: Use plain routes list for os-server-groups endpoint instead of stevedore  https://review.openstack.org/46216914:04
*** zz_dimtruck is now known as dimtruck14:05
openstackgerritMathieu Gagné proposed openstack/nova master: Add ability to signal and perform online volume size change  https://review.openstack.org/45432214:06
*** slaweq has quit IRC14:06
*** armax has joined #openstack-nova14:08
mriedembauzas: the change on master is merged for https://review.openstack.org/#/c/472687/ if you want to get that in, then we can do an ocata release14:10
bauzasmriedem: easy peasy14:10
*** roeyc has quit IRC14:10
*** felipemonteiro_ has joined #openstack-nova14:15
*** felipemonteiro__ has joined #openstack-nova14:17
*** awaugama has joined #openstack-nova14:18
*** jamesden_ has quit IRC14:18
*** felipemonteiro_ has quit IRC14:21
*** jamesdenton has joined #openstack-nova14:21
*** itlinux_ has joined #openstack-nova14:22
*** kenperkins has joined #openstack-nova14:26
*** acormier has joined #openstack-nova14:26
*** yamamoto has joined #openstack-nova14:26
*** cfriesen has joined #openstack-nova14:26
*** ekuris has quit IRC14:27
*** roeyc has joined #openstack-nova14:28
openstackgerritEric Fried proposed openstack/nova master: Glance download: only fsync files  https://review.openstack.org/45109414:28
*** kwathore has quit IRC14:28
dansmithsdague: so this is passing a canary from the nova side: https://review.openstack.org/#/c/436094/14:29
*** qwertyco has quit IRC14:29
dansmithsdague: would appreciate it if you'd take another pass through that to see if we can get that landed soonlyish14:29
*** ericyoung has joined #openstack-nova14:30
*** kenperkins has quit IRC14:30
*** roeyc has quit IRC14:31
*** sree_ has joined #openstack-nova14:31
*** roeyc has joined #openstack-nova14:32
*** sree_ is now known as Guest8600514:32
*** yamamoto has quit IRC14:32
*** sree has quit IRC14:32
*** Guest6511 is now known as med_14:32
*** med_ has quit IRC14:32
*** med_ has joined #openstack-nova14:32
*** mdrabe has quit IRC14:35
*** felipemonteiro__ has quit IRC14:35
*** alexchadin has quit IRC14:35
edmondswmriedem sdague I think one of you had reminded us about adding powervm to the support matrix... we've got that change up for review: https://review.openstack.org/#/c/470999/14:38
mriedemyeah i did, just need to get some free time14:39
openstackgerritMatt Riedemann proposed openstack/nova master: Handle uuid in HostAPI.compute_node_get  https://review.openstack.org/46153214:39
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Handle uuids in os-hypervisors API  https://review.openstack.org/47189914:39
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Use uuid for id in Services API  https://review.openstack.org/46428014:39
*** hongbin has joined #openstack-nova14:39
*** jdurgin has quit IRC14:39
sdaguedansmith: the grenade bit is already in? (i can't remember)14:40
dansmithsdague: yar14:40
dansmithsdague: no depends-on for that patch, and just a canary that depends-on it for testing14:40
dansmithsdague: https://review.openstack.org/#/c/473565/14:40
dansmithcanary ^14:40
*** mdrabe has joined #openstack-nova14:41
dansmithsdague: if you think we need a canary against any other project let me know.. I don't really know what other sorts of complicated jobs we have in other places that might be affected14:41
sdagueI think it's probably fine14:41
*** itlinux_ has quit IRC14:41
dansmithcool14:42
openstackgerritBéla Vancsics proposed openstack/nova master: Reduced the complexity of the _init_instance method (2)  https://review.openstack.org/42061914:42
mriedemdansmith: i see an issue in the ironic tinyipa job in there http://logs.openstack.org/94/436094/35/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/1df37be/logs/devstacklog.txt.gz#_2017-06-12_20_26_29_36214:42
mriedembut that might just already be busted14:43
mriedemactually,14:44
mriedemit only fails that way on that devstack change and the canary patch14:44
mriedemso it's likely an issue from that setup14:44
mriedemhttp://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Timed%20out%20waiting%20for%20Nova%20hypervisor-stats%20count%20%3E%3D%201%5C%22%20AND%20tags%3A%5C%22console%5C%22&from=7d14:45
*** jdurgin has joined #openstack-nova14:45
dansmithah, yeah, hmm14:45
dansmithhost discovery maybe?14:45
mriedemthat'd be my guess14:46
mriedemdtantsur: are you around?14:46
dtantsurmriedem: hi, I am14:46
mriedemdtantsur: we're trying to sort out http://logs.openstack.org/94/436094/35/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/1df37be/logs/devstacklog.txt.gz#_2017-06-12_20_26_29_36214:46
mriedemthat job is timing out waiting for hypervisor stats to show up,14:47
dtantsurI'm on a meeting, but will try to look14:47
mriedemand are wondering if it's not doing proper host discovery14:47
mriedemthanks14:47
dtantsurwhat's the patch?14:47
mriedemhttps://review.openstack.org/#/c/436094/3514:47
mriedemit's a devstack patch that gets us to multiple cells testing14:47
mriedemwith 2 levels of nova conductor14:47
mriedemone in the top level controller node, and one in each cell14:47
mriedemdansmith: ^ is that accurate?14:48
dtantsurhmm, I wonder how this all works with ironic14:48
dansmithmriedem: the two levels thing doesn't really matter to him, but yeah14:48
dansmithmriedem: dtantsur I'm poking through lib/ironic now14:49
mriedemi see cell1 created here http://logs.openstack.org/94/436094/35/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/1df37be/logs/devstacklog.txt.gz#_2017-06-12_20_10_32_09814:49
dtantsurI think what we do, or at least what we used to do, is to restart nova-compute for some reason14:50
mriedemthis isn't a multinode job, so it should just be a single cell right?14:50
dtantsurnot sure if it's related14:50
mriedemi'm not seeing simple_cell_setup or discover_hosts run anywhere in the devstack log14:50
*** jianghuaw_ has quit IRC14:51
dtantsurwe don't seem to run it indeed..14:51
dtantsurbut then we would break long ago, no?14:51
mriedemdansmith: keep in mind they have an ironic devstack plugin https://github.com/openstack/ironic/tree/master/devstack14:52
dansmithmriedem: right14:52
dansmithmriedem: just pushed a change14:52
dansmithhttps://review.openstack.org/47386814:52
dtantsurthanks dansmith, let's try this14:52
mriedems/.///? in there?14:53
dtantsurto be honest, I have hard time understanding the recent changes around cells, etc..14:53
dansmithgah yes14:53
*** claudiub|2 has quit IRC14:53
dansmithmriedem: fixed14:53
dtantsurdansmith: shouldn't the dependency be the other way around? i.e. the devstack patch to depend on the ironic change?14:54
mriedemyes14:54
mriedemi'm also not sure how any of the ironic jobs have worked w/o discovering the hosts by now14:55
openstackgerritBalazs Gibizer proposed openstack/nova master: use context mgr in instance.delete  https://review.openstack.org/44376414:55
mriedemsince ocata14:55
dtantsurthis is what I wonder as well14:55
dtantsurwe had to do it in tripleo14:55
*** karimb has quit IRC14:55
dansmithdtantsur: not for testing14:56
*** roeyc has quit IRC14:56
dansmithdtantsur: I'll swap the order when this shows the job working on this patch14:56
dtantsurack14:57
*** armax has quit IRC14:57
*** karimb has joined #openstack-nova14:57
*** armax has joined #openstack-nova14:59
*** danpawlik is now known as _danpawlik15:02
*** claudiub|2 has joined #openstack-nova15:02
*** slaweq has joined #openstack-nova15:03
*** huanxie has joined #openstack-nova15:03
*** Alex_____ has quit IRC15:04
*** cdent has joined #openstack-nova15:04
mriedemthis is what normally runs discover_hosts https://github.com/openstack-dev/devstack/blob/master/stack.sh#L141215:05
mriedemmaybe the ironic thing happens before that?15:05
openstackgerritVladyslav Drok proposed openstack/nova master: Remove only compute ports in deallocate_for_instance  https://review.openstack.org/47387315:05
dansmithright15:05
dansmithright15:05
dansmiththat is the late run to pick up stragglers I think,15:05
dansmithand this is earlier15:05
dansmithI don't think the devstack change makes anything like db init happen in any different order,15:06
dansmithso I'm kinda suspecting that we're using the wrong config file somewhere and never installing the maps at the top15:06
*** gbarros has quit IRC15:06
dansmithbut I can chase that down.. just want to do this as the easy first stab and see where we are15:06
dansmithif this doesn't work, it's definitely a config file thing I think15:06
dansmithdefinitely I think15:06
*** slaweq has quit IRC15:07
huanxieHi jaypipes, for VM lost connection issue during live migration with XenServer, I saw your comments with this patch https://review.openstack.org/#/c/451657/ and I think it's reasonable to hide detailed bridge operation, so I made another patch https://review.openstack.org/#/c/462017/ for this issue. Could you help have a look at https://review.open15:09
huanxiestack.org/#/c/462017/ ? And TBH, I'm not quit sure which one is better now, so could you help give some suggestions? Thanks a lot:)15:09
*** tesseract has quit IRC15:10
cfriesenmriedem: dansmith: If you have a few minutes, I addressed some of mriedem's comments on https://review.openstack.org/#/c/435141/    but I'm stuck on how to mock the unit tests to do the api version.15:10
dansmithcfriesen: that's not a thing I'm going to be helpful with. ask sdague or alex_xu15:11
*** gbarros has joined #openstack-nova15:12
jaypipeshuanxie: yup, it's on my queue :) sorry, in three hour meeting right now :(15:12
mriedemcfriesen: andreykurilin might be able to help, otherwise i can look later15:13
*** clayton has quit IRC15:13
*** acormier has quit IRC15:13
andreykurilinhi15:13
cfriesenhey15:13
*** acormier has joined #openstack-nova15:13
andreykurilincfriesen: what had happend? need help?)15:13
huanxieThat's fine, please leave your comments and concern and I will address your comments my next Monday:)15:13
cfriesenandreykurilin: see https://review.openstack.org/#/c/435141/15:14
andreykurilinlooking15:14
*** gbarros has quit IRC15:14
cfriesenandreykurilin: I added a microversion such that the "nova list" command now needs to check microversions to determine how to format the output, and it's breaking a bunch of novaclient tests.15:14
*** gbarros has joined #openstack-nova15:14
huanxieHi jaypipes, sorry for my mistack, I mean I will fix your comments my next morning :)15:15
jaypipeshuanxie: no problem!15:15
*** clayton has joined #openstack-nova15:15
cfriesenandreykurilin: the tests in question use mock.MagickMock for novaclient.client.Client, and then later on some of the tests do @mock.patch('novaclient.client.Client'), and I can't figure out how to get them to report api_version properly15:16
huanxieThanks a lot jaypipes15:16
andreykurilincfriesen: are you talking about unit or functional tests?15:16
cfriesenandreykurilin: unit.   novaclient/tests/unit/test_shell.py15:17
mriedemcfriesen: wouldn't you just put an api_version attribute on the mock?15:17
*** Oku_OS is now known as Oku_OS-away15:19
cfriesenmriedem: the code in question does this in setUp():   self.useFixture(fixtures.MonkeyPatch('novaclient.client.Client', mock.MagicMock()))15:19
cfriesenmriedem: I can't figure out how to put an api_version attribute on that15:20
andreykurilincfriesen: it looks like just that module requires some cleanup15:20
mriedemcfriesen: mock.MagicMock(api_version=api_versions.APIVersion('2.1'))15:20
mriedemor something15:20
andreykurilinif setUp method uses fixtures, no @mock.patch is required15:20
*** huanxie has quit IRC15:21
andreykurilincfriesen: I suppose, we need to same mock.MagicMock() object as self.mock_client before transmitting to MonkeyPatch, and than you will able to do `self.mock_client.api_version = api_versions.APIVersion("2.22")` in your test15:22
*** slaweq has joined #openstack-nova15:24
cfriesenandreykurilin: if you don't @mock.patch on the test itself, how do you do stuff like "client_kwargs = mock_client.call_args_list[0][1]" ?15:24
andreykurilincfriesen: as I mentioned previously, we need to store object transmitted to MockPatch in setUp method15:25
cfriesenandreykurilin: I think I see.  will try that15:25
*** slaweq has quit IRC15:26
*** chyka has joined #openstack-nova15:26
cfriesenandreykurilin: you are a genius.  Looks like that'll work.  let me respin a new version for review.15:29
*** jianghuaw_ has joined #openstack-nova15:29
*** mikal has quit IRC15:29
*** mamandle has joined #openstack-nova15:29
andreykurilincfriesen: If you have time, please submit a patch with removing all redundant @mock.patch there15:29
cfriesenandreykurilin: whoops, spoke too soon.   TypeError: '<MagicMock name='mock().api_version' id='69241360'>' should be an instance of '<class 'novaclient.api_versions.APIVersion'>'15:30
*** tidwellr has quit IRC15:30
andreykurilincfriesen: in your test, you should do something like `self.mock_client.api_version = api_versions.APIVersion("2.22")`` where api_versions is a module novaclient.api_versions15:30
*** mikal has joined #openstack-nova15:31
*** tidwellr has joined #openstack-nova15:31
cfriesenandreykurilin: this is what I have now: http://paste.openstack.org/show/612435/15:31
mriedem_CellProxy15:31
mriedemoh _CellProxy15:31
mriedemwhy oh why15:31
cfriesenandreykurilin: and this is what I get when running it: http://paste.openstack.org/show/612437/15:33
mriedemcfriesen: needs to be an object,15:33
mriedemnot a string15:33
mriedemcfriesen: https://github.com/openstack/python-novaclient/blob/master/novaclient/client.py#L5915:34
mriedem^ is what you're mocking out ultimately15:34
cfriesenmriedem: what needs to be an object?15:34
mriedemso it needs to be of type novaclient.api_versions.APIVersion15:34
mriedemcfriesen: self.mock_client.api_version = novaclient.API_MAX_VERSION15:35
mriedemthat's a string15:35
mriedemneeds to be an object15:35
mriedeman APIVersion object15:35
mriedemwhich is constructed with a string value15:35
*** chyka has quit IRC15:35
mriedemi would probably also use API_MIN_VERSION as the default15:36
mriedemfor existing tests15:36
cfriesenyeah, that was my intent.  copy/paste error just now15:36
mriedembauzas: i've got a fun cells v1 question for you15:37
mriedembauzas: i need to implement __contains__ for the _CellProxy15:37
bauzasmriedem: kaboom15:37
mriedemlike https://github.com/openstack/nova/blob/master/nova/cells/utils.py#L6415:37
mriedemi see that id and host are special cased15:37
mriedemi was just doing this:15:37
mriedemdef __contains__(self, key):15:37
mriedem        return key in self._obj15:37
mriedembut do i need to special case id and host?15:37
mriedemi don't think so, but wanted to ask15:38
bauzasmriedem: I need to reload the context in mind because it's a 2-yr blame :p15:38
mriedemi think we special case id and host because they are namespaced15:39
mriedemto the cell15:39
mriedemwhether they are IN the proxied object is the same either way i think15:39
bauzasmriedem: oh right I remember15:41
bauzasmriedem: now15:41
bauzasAFAIR, we're amending the host value by the cell path15:41
bauzasthe same goes with the ID15:41
bauzassomething like 'foo' becomes cell1!foo AFAIR15:41
bauzaswhich was a problem for our object layers15:42
bauzasat least the id15:42
*** yamahata has joined #openstack-nova15:42
bauzasso, we wrote those ugly patterns to make sure we can just modify both the ID and the host fields without touching the object15:42
mriedemyeah, so i think the answer is my simple __contains__ impl is fine15:43
*** clayton has quit IRC15:43
mriedemfor what i need15:43
mriedemwhich is just checking if a field is set in the wrapped object15:43
mriedemit's a proxy to the ovo base __contains__15:44
bauzasI'm thinking of your question15:44
bauzaswhether we should special case id and host15:44
bauzasI think no15:44
bauzasbecause we have the properties15:44
*** mamandle has quit IRC15:45
*** rmart04 has quit IRC15:46
*** tbachman has quit IRC15:46
bauzasmriedem: ^15:46
*** slaweq has joined #openstack-nova15:47
*** clayton has joined #openstack-nova15:48
*** dtp has joined #openstack-nova15:49
bauzasmriedem: the thing is, I'm thiking of the precedence between __getitem__ and __contains__15:49
bauzasmriedem: but if you ask : 'id' in mycellproxy15:50
mriedembauzas: __contains__ is used before __getitem__15:50
bauzasit should provide True anyway15:50
mriedemwhich is why i needed to add it15:50
mriedemsee http://logs.openstack.org/99/471899/5/check/gate-nova-python27-ubuntu-xenial/7be94a3/testr_results.html.gz15:50
mriedemthat was calling __getitem__ with key=015:51
bauzasFWIW, the doc is https://docs.python.org/3/reference/datamodel.html15:51
mriedemtreating it as a list rather than a map (dict)15:51
mriedemand getattr blows up with TypeError if you're passing a non-string15:51
mriedem__contains__ fixes it15:51
*** Apoorva has joined #openstack-nova15:52
*** andreas_s has quit IRC15:52
bauzasmriedem: not sure I get why you land with key=0 but okay15:53
mriedemme neither15:53
mriedemanyway, i think it's resolved,15:53
mriedemforget i ever asked about this15:53
bauzaswell, okay :)15:54
* bauzas loves cells v115:54
sfinucansdague: Could you take a look at this and see if it makes sense? https://review.openstack.org/#/c/473224/15:55
sdaguesfinucan: with the version bump it should be fine15:55
*** slaweq has quit IRC15:55
*** markus_z has quit IRC15:56
sfinucansdague: so they should go in together?15:56
sfinucan*in the same patch15:57
sdagueyeh15:57
*** Guest86005 has quit IRC15:57
*** lpetrut has quit IRC15:57
sdagueI think there is going to need to be a unit test change at the same time15:57
sdagueI can pull them together if you like15:57
cfriesenmriedem: andreykurilin:  Still hitting the problem.  http://paste.openstack.org/show/612439/  has my setUp() code, the test itself, and the pdb output while running the test.15:57
*** jaosorior has quit IRC15:57
*** jaosorior has joined #openstack-nova15:58
*** clayton has quit IRC15:58
*** jaosorior is now known as jaosorior_away15:58
cfriesenmriedem: andreykurilin:  for some reason I can't do pdb in novaclient/v2/shell.py, it just hangs.  wonder if that's related to the issue15:58
*** nic has joined #openstack-nova15:58
*** clayton has joined #openstack-nova15:59
andreykurilinit is strange, because I fetched your patch, applied changes in setUp method and everything works for me(at least test_default_endpoint_type passes)15:59
*** jamesden_ has joined #openstack-nova15:59
*** jamesdenton has quit IRC15:59
cfriesenandreykurilin:did you change it from "flavor-list" to "list"?15:59
*** vks1 has quit IRC16:00
andreykurilinok, let me try16:00
cfriesenin test_default_endpoint_type9)16:00
*** gyee has joined #openstack-nova16:00
*** cdent has quit IRC16:01
mriedemalex_xu: sdague: remember how we wanted to do the os-services and os-hypervisors id->uuid API changes in the same microversion, plus a bunch of other cleanups for weird PUT and GET APIs?16:02
mriedemthis one https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/service-hyper-uuid-in-api.html16:02
openstackgerritSean Dague proposed openstack/python-novaclient master: Fix setting 'global_request_id' in SessionClient  https://review.openstack.org/47322416:02
*** sree has joined #openstack-nova16:02
mriedemturns out that might be a monster change if we're doing it on the same microversion, like the os-services one is pushing 1000 LOC16:03
andreykurilincfriesen: `self.mock_client.return_value.api_version = api_versions.APIVersion("2.1")`16:03
andreykurilinyou need to setup api_version like this16:03
andreykurilincfriesen: because self.mock_client is just a mock of novaclient.client.Client method and CLI obtains api_version property from the object which that novaclient.client.Client  returns16:04
sdaguemriedem: because of the tests and friends?16:04
mriedemsdague: and docs yeah16:04
mriedemplus,16:04
*** hamzy has quit IRC16:04
mriedemos-hypervisors is going to require changes for paging across cells,16:04
mriedemwhich i didn't originally anticipate in the spec16:04
sdagueok16:04
sdagueis there any way to structure that code for land better?16:05
mriedemi've tried to split out some of it by layers, e.g. https://review.openstack.org/#/c/461532/16:05
mriedemis the compute API stuff, before the  REST API controller pieces16:05
mriedemcan't really do that once i get to https://review.openstack.org/#/c/464280/ though16:05
sfinucansdague: Yeah, go for it16:05
mriedemgranted that one is mostly tests and docs16:05
sfinucan(pulling them together)16:06
sdaguehonestly, I have wondered if we should stack our API changes a little differently so the functional is in one patch, samples tests in next patch, api-ref in 3rd? Then just -2 the bottom and do a flush16:06
sdaguebecause I do agree they get complicated to mentally context switch in the reviews16:06
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Handle uuids in os-hypervisors API  https://review.openstack.org/47189916:06
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Use uuid for id in Services API  https://review.openstack.org/46428016:06
mriedem^ is the latest before i have the api-ref working16:06
mriedemper my os_api_ref problem this morning16:06
mriedemmy plan here was to get reviews on each separately, -2 on os-services until +2 on os-hypervisors, then squash them16:07
mriedemthere is going to be db api/object layer paging changes for the hypervisors one that will be separate16:07
mriedembut things still get pretty big16:07
cfriesenandreykurilin: you're my hero. :)16:07
mriedemhttps://review.openstack.org/#/c/464280/11/nova/api/openstack/compute/services.py is the main functional piece in the os-services change, and isn't too bad16:07
mriedemi chose not to try and re-using the weird little private methods for the service action apis16:08
mriedemlike _enable and _disable16:08
*** rajathagasthya has joined #openstack-nova16:08
mriedemso it's a single update() method for the new microversion that handles all of the things in the request16:08
*** sree has quit IRC16:09
openstackgerritSean Dague proposed openstack/python-novaclient master: Fix setting 'global_request_id' in SessionClient  https://review.openstack.org/47322416:12
sdaguesfinucan: it can actualy be a little smaller16:12
*** damien_r has quit IRC16:13
sfinucansdague: And even smaller? REQ_ID_HEADER looks unused16:13
*** jdurgin has quit IRC16:13
sdaguesfinucan: oh, it might be now16:14
bauzasmriedem: I did remember how cutting the relationship between services and hypervisors was a big thing, so I trust you when you say it's becoming a monster change16:14
sdagueI can swing around in a sec16:14
sfinucanno rush16:15
bauzastouching services and hypervisor seems like the most impactful things to do, because we have a shit ton of tests asserting things, plus a lot of logic around those16:15
openstackgerritSean Dague proposed openstack/python-novaclient master: Fix setting 'global_request_id' in SessionClient  https://review.openstack.org/47322416:15
mriedemit's definitely not fun16:15
*** karimb has quit IRC16:15
bauzasmriedem: any series I can start to review, so I could help ?16:15
mriedemthe os-services thing is pretty straight-forward though, after working on it for a couple of days16:16
bauzasdon't be afraid of WIPs16:16
mriedembauzas: https://review.openstack.org/#/c/464280/11 and below16:16
bauzasmriedem: okay, I'll review those16:16
mriedembauzas: ^ is really basically done, except one todo in the code and i need to get the api-ref working16:16
mriedemsdague: i wonder if my comments in the parameters.yaml is what's making os_api_ref puke?16:16
bauzasmriedem: I can see the code16:17
mriedemoh i guess not, there are already comments in there16:17
sdaguemriedem: you have the patch?16:18
mriedemhttps://review.openstack.org/#/c/464280/16:18
*** dtantsur is now known as dtantsur|afk16:19
sdagueok, let me poke16:21
*** suresh12 has joined #openstack-nova16:21
*** jaosorior_away has quit IRC16:23
*** sridharg has quit IRC16:24
sdaguemriedem: ok, it's a warning that's trying to trigger16:25
*** itlinux_ has joined #openstack-nova16:26
sdagueoh, i see what's going on, let me figure out the right fix16:26
*** suresh12_ has joined #openstack-nova16:27
*** tbachman has joined #openstack-nova16:29
*** suresh1__ has joined #openstack-nova16:30
*** suresh12 has quit IRC16:30
*** armax has quit IRC16:31
*** suresh12_ has quit IRC16:32
sdagueoh, it looks like sphinx changed a call interface16:33
*** armax has joined #openstack-nova16:33
mriedemok but this would be the warning https://github.com/openstack/os-api-ref/blob/master/os_api_ref/__init__.py#L34916:34
mriedemi'm missing some path parameter16:34
*** raorn_ is now known as raorn16:35
*** suresh12 has joined #openstack-nova16:35
*** suresh1__ has quit IRC16:35
openstackgerritAlex Szarka proposed openstack/nova master: Refactor create_delete_server_with_instance_update  https://review.openstack.org/46629616:37
openstackgerritChris Friesen proposed openstack/python-novaclient master: 2.47: Show flavor info in server details  https://review.openstack.org/43514116:38
openstackgerritChris Friesen proposed openstack/python-novaclient master: Clean up ShellTest unit tests  https://review.openstack.org/47391016:38
cfriesenmriedem: andreykurilin: ^16:38
mriedemsdague: yeah if i restrict Sphinx<1.6.1 i get this16:40
mriedem/home/user/git/nova/api-ref/source/api-ref/source/os-services.inc:250 .rst:: WARNING: No path parameter ``service_id`` found in rest_parameter stanza.16:40
*** suresh12 has quit IRC16:40
sdagueyeh16:40
*** sambetts is now known as sambetts|afk16:40
openstackgerritBalazs Gibizer proposed openstack/nova master: Transform missing delete notifications  https://review.openstack.org/41029716:40
sdagueso they seem to have changed the warn parameters on env16:40
*** rcernin has quit IRC16:41
mriedemi'll open a bug quick to track it against os-api-ref16:43
*** derekh has quit IRC16:43
cfriesenmriedem: for https://review.openstack.org/#/c/465787/  we have some indication that it's not properly handling neutron floatingip-associate events16:43
openstackgerritMerged openstack/nova master: Fix the race condition with novnc  https://review.openstack.org/47079816:44
*** suresh12 has joined #openstack-nova16:46
*** Swami has joined #openstack-nova16:48
*** rajathagasthya has quit IRC16:49
*** lucasagomes is now known as lucas-afk16:50
*** suresh12 has quit IRC16:51
openstackgerritMerged openstack/nova master: Add missing query filter params for GET /os-services API  https://review.openstack.org/47370816:53
*** yamahata has quit IRC16:54
mriedemdansmith: about that service not found thing last night, where it's not a compute service to do things like enable/disable,16:55
mriedemwe talked about returning a more useful error message in that case,16:55
mriedemhowever, it's a chicken and egg problem,16:56
*** slaweq has joined #openstack-nova16:56
mriedemwell, maybe not - if it's not a compute service it won't have a host mapping and we'll get HostMappingNotFound,16:57
mriedemif it is a compute service and really just doesn't exist, we'll get ServiceNotFound16:57
*** gmann has quit IRC16:57
mriedemanyway, now i'm having a hard time recalling what we talked about doing here16:59
*** tuanla_fujitsu has joined #openstack-nova16:59
*** felipemonteiro has joined #openstack-nova16:59
dansmithnot 404ing if they try to disable a scheduler for example16:59
mriedemoh right, so it is kind of a chicken and egg then17:00
mriedemwe don't know it's a scheduler or not17:00
mriedemif there is no host mapping, that could be b/c it's not mapped yet17:00
*** fragatina has quit IRC17:00
mriedemor because it's not a compute service17:00
*** tuanla__ has joined #openstack-nova17:00
*** amotoki is now known as amotoki_away17:01
*** slaweq has quit IRC17:01
*** Apoorva_ has joined #openstack-nova17:01
mriedemanyway, i think i'm going to write something up to the ML about this just to make people aware and see if anyone had any weird uses for disabling non-compute services,17:01
mriedemto help answer what i should do in the new api17:02
dansmithif we don't find a mapping, we can lookin cell0 for the service, and if we find, it we can assume it's not an unmapped compute, but a non-compute control service17:02
dansmiththere is no use for disabling a non-compute service,17:02
dansmithall it does is set disabled=True, and that's only checked in the scheduler17:02
dansmithI went through this with someone internal a few months ago17:02
*** salv-orlando has joined #openstack-nova17:03
mriedemi know, but you never know what people are doing - which is why i just want to ask or let people be aware of this,17:03
*** ralonsoh has quit IRC17:03
mriedemi think we still go forward with restricting updating to only compute services17:03
mriedemi.e. i could totally see someone using service.update notifications to trigger some backend system to kill their nova-scheduler or something, so they can control things via the api17:03
*** Apoorva has quit IRC17:04
dansmithand your point is you just want to alert those people that we're killing that? .... RIGHT?17:05
mriedemthe point is i'm going to add a flurry of config options to call out to external hooks which change the behavior of this api17:05
mriedemis that ok?17:05
dansmithoh that? yeah, that's fine... reaaaal nice.17:06
*** salv-orl_ has quit IRC17:06
*** fragatina has joined #openstack-nova17:06
mriedemyes this is an alert17:06
mriedembrown alert17:06
dansmithheh17:06
*** fragatina has quit IRC17:08
*** jdurgin has joined #openstack-nova17:09
*** fragatina has joined #openstack-nova17:09
*** baoli has quit IRC17:17
*** rajathagasthya has joined #openstack-nova17:17
*** Apoorva_ has quit IRC17:17
*** Apoorva has joined #openstack-nova17:18
mriedemhere she be http://lists.openstack.org/pipermail/openstack-operators/2017-June/013761.html17:21
*** gjayavelu has joined #openstack-nova17:23
*** hamzy has joined #openstack-nova17:23
*** jpena is now known as jpena|away17:25
edmondswdansmith mriedem sfinucan before I invest a bunch of time in UTs, what do y'all think of the course I'm on with https://review.openstack.org/#/c/472794/ ?17:25
*** mingyu has joined #openstack-nova17:27
*** efoley has quit IRC17:30
*** yamahata has joined #openstack-nova17:34
*** krtaylor has quit IRC17:35
*** tuanla__ has quit IRC17:37
*** tuanla_fujitsu has quit IRC17:37
*** vladikr has quit IRC17:42
*** suresh12 has joined #openstack-nova17:49
*** baoli has joined #openstack-nova17:49
*** vladikr has joined #openstack-nova17:50
*** jamesden_ has quit IRC17:55
*** itlinux_ has quit IRC17:56
dansmithmriedem: the ironic driver is waiting for this to report some resources: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L462717:56
dansmithwhich will never happen17:56
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Handle uuids in os-hypervisors API  https://review.openstack.org/47189917:56
openstackgerritMatt Riedemann proposed openstack/nova master: Use uuid for id in os-services API  https://review.openstack.org/46428017:56
dansmithmy discover change in that loop did find unmapped nodes though, so we definitely need that17:56
mriedemdtp: ok os-services is done and ready for review ^ i'm going to -2 it until the os-hypervisors change is done17:56
*** itlinux_ has joined #openstack-nova17:56
dtpok17:56
mriedemsdague: just squeeked in under 1000LOC :)17:56
*** fragatina has quit IRC17:57
*** slaweq has joined #openstack-nova17:57
mriedemdansmith: hmm, how is it we never had to update GET /os-hypervisors/statistics for multi-cells?17:57
mriedemno tempest test?17:57
dansmithI think very few things hit that,17:58
dansmithso yeah17:58
mriedemhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/hypervisors.py#L27717:58
mriedemyeah, so i guess we need to address that under your cells-aware bp17:59
dansmithyeah17:59
mriedemi worry a bit about what we haven't made cells aware due to lack of tempest api test coverage17:59
mriedembut not so worried that i'm going to do a thorough audit right now :)17:59
*** jamesdenton has joined #openstack-nova18:00
dansmithwell, lack of test coverage is lack of test coverage18:00
dansmithwe're hitting one thing right here before real people do, so...18:01
mriedemso kudos to us18:01
openstackgerritGábor Antal proposed openstack/nova master: Transform instance.rebuild-scheduled notification  https://review.openstack.org/47392918:01
*** slaweq has quit IRC18:01
*** suresh12 has quit IRC18:02
*** crushil has joined #openstack-nova18:04
*** suresh12 has joined #openstack-nova18:06
mriedemcfriesen: something still failing here https://review.openstack.org/#/c/435141/18:06
*** jamesdenton has quit IRC18:08
dansmithmriedem: there aren't even unit tests for that bit of HostAPI18:11
mriedemnice18:12
mriedemi've noticed we test the rest api but not the host api so well18:12
*** suresh12 has quit IRC18:13
dansmithI don't see rest tests for this either18:15
*** krtaylor has joined #openstack-nova18:20
*** suresh12 has joined #openstack-nova18:20
*** applec4rt has joined #openstack-nova18:22
*** itlinux_ has quit IRC18:23
sdaguemriedem: oh, it's just a flat out broken sphinx thing18:24
sdaguegdi18:24
cfriesenmriedem: we found the bug in https://review.openstack.org/#/c/465787 and I updated the review18:24
*** cdent has joined #openstack-nova18:25
*** rcernin has joined #openstack-nova18:26
cfriesenmriedem: I think that's new after rebasing...I only reran the test_shell unit tests after changing stuff18:26
*** jamesdenton has joined #openstack-nova18:28
openstackgerritDan Smith proposed openstack/nova master: DNM: Canary  https://review.openstack.org/47356518:28
openstackgerritDan Smith proposed openstack/nova master: Make compute_node_statistics() work across cells  https://review.openstack.org/47393118:28
*** sudipto has joined #openstack-nova18:29
*** kenperkins has joined #openstack-nova18:29
*** sudipto has quit IRC18:29
cfriesenmriedem: this is weird...novaclient.tests.unit.test_client.SessionClientTest.test_global_id passes locally18:29
*** sudipto has joined #openstack-nova18:29
*** sudipto has quit IRC18:29
*** sudipto has joined #openstack-nova18:30
*** sudipto_ has joined #openstack-nova18:30
cfriesenmriedem: and I didn't change anything related to that code, that I can see at least18:30
*** itlinux_ has joined #openstack-nova18:31
*** dtp has quit IRC18:32
*** ijw has joined #openstack-nova18:32
*** egonzalez has joined #openstack-nova18:36
cfriesenmriedem: locally it looks fine.  what's with the key.lower() in the traceback of the failing test at http://logs.openstack.org/41/435141/13/check/gate-python-novaclient-python27-ubuntu-xenial/df4a44b/testr_results.html.gz ?18:37
cfriesenandreykurilin: can you see any reason why https://review.openstack.org/#/c/473910 would cause the failure in test_global_id at http://logs.openstack.org/10/473910/1/check/gate-python-novaclient-python27-ubuntu-xenial/76e7e46/testr_results.html.gz ?18:42
mriedemcfriesen: the global id thing is being fixed18:44
mriedemsdague has a patch for it18:44
mriedemcfriesen: good catch on https://review.openstack.org/#/c/465787/3/nova/network/neutronv2/api.py@232218:45
*** nicolasbock has quit IRC18:51
*** nicolasbock has joined #openstack-nova18:51
*** sudipto has quit IRC18:53
*** sudipto_ has quit IRC18:53
cfriesenmriedem: can't take credit personally...we ran into it during testing and one of the guys tracked it down18:56
cfriesenmriedem: you okay with https://review.openstack.org/#/c/435141/ otherwise, or did you still have issues with the json blob output?18:57
mriedemhaven't looked at it yet18:58
mriedemgetting https://review.openstack.org/#/c/473224/ sorted out18:58
cfriesenkay, no worries18:58
*** slaweq has joined #openstack-nova18:58
mriedemcfriesen: i definitely don't like dumping a json blob in a table cell,18:59
mriedembut as you replied, we do it elsewhere18:59
mriedemthe alternative is we dump the flavor name19:00
mriedemwith the server details19:00
mriedemand then if you want details on the flavor, you do nova flavor-show <flavor name>19:01
*** baoli has quit IRC19:01
*** slaweq has quit IRC19:03
bauzasmriedem: dansmith: just a note that I'll be on PTO tomorrow19:03
mriedemok19:04
* bauzas hitted by paperwork rules for French folks19:04
bauzasthat, next week and the other week19:04
cfriesenmriedem: that doesn't work if the flavor is deleted or modified though19:05
mriedemcfriesen: true19:05
mriedemcfriesen: would be nice at least to dump key-value pairs in a table cell rather than a json blob19:06
mriedembut i don't know how easy that is19:06
mriedemwith prettytable19:06
*** mnestratov|2 has quit IRC19:06
mriedemwe might have done something like that with nova-status, checking19:06
*** gszasz has quit IRC19:07
cfriesenmriedem: the output currently looks like this: http://paste.openstack.org/show/612457/19:07
sdaguemriedem: fyi - https://review.openstack.org/473941 is what was needed to get your api-ref warnings emitted19:07
*** awaugama has quit IRC19:07
mriedemcfriesen: yikes19:07
*** jdurgin has quit IRC19:07
mriedemsdague: any idea if that works with sphinx 1.5.1? https://github.com/openstack/requirements/blob/master/global-requirements.txt#L41219:08
mriedemsdague: also curious for your opinion on embedding the nested flavor in the server show ouput as a json blob http://paste.openstack.org/show/612457/19:08
mriedemi personally think that's ugly, but we also do it for volume attachments and extra specs in the flavor-show output19:08
cfriesenI'm not wedded to it, happy to do something better19:09
cfriesenjust don't know what other options we have19:09
*** NostawRm has joined #openstack-nova19:10
*** mvk has quit IRC19:10
*** slaweq has joined #openstack-nova19:11
mriedemcfriesen: i'd prefer to see it like this somehow http://paste.openstack.org/show/612458/19:11
mriedembut not sure how easy that is19:11
sdaguemriedem: I don't yet, still puttering through this19:13
sdaguemriedem: I agree, I think it should be unrolled19:13
cfriesenmriedem: that'd make functional tests a bit of a mess, trying to correlate that against the output of "flavor show"19:13
cfriesenI guess we could take the "flavor show" output and mangle it into that format and then compare19:14
sdagueum, why isn't this just flavor_ ephemeral19:14
sdagueflavor_ram19:14
sdagueetc19:14
mriedemcould be namespaced19:14
mriedemthat's an option19:14
sdagueif you are putting the output in the tables, it should be table friendly data19:15
sdagueor flavor:ram19:15
cfriesensdague: I was just following the existing pattern where the "flavor" entry had the name and the id on one line19:15
sdaguecfriesen: right, but that was a key19:16
mriedemsure, but now it's more than id19:16
sdaguemriedem: ++19:16
mriedemcfriesen: i'd think it would be pretty easy to transform that to flavor_ namespaced keys in the server resp body object before sending it to the table output formatter19:16
mriedemthere might even be a callback function available with the output formatter19:17
cfriesenagreed.  you want "flavor_" or "flavor:"?19:17
mriedemhmm19:17
sdagueI think flavor:19:17
mriedemyou're treading on OS-SRV-EXT territory :)19:17
sdaguemriedem: sure19:17
mriedemi'm cool with flavor:19:17
mriedemmakes it more namespacey19:17
sdagueyep19:17
cfriesenokay, will give that a try19:18
*** krtaylor has quit IRC19:20
openstackgerritMatt Riedemann proposed openstack/nova master: Pull out code that builds VIF in _build_network_info_model  https://review.openstack.org/46644919:22
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Handle network-changed event for a specific port  https://review.openstack.org/46578719:22
*** suresh12 has quit IRC19:23
*** mingyu has quit IRC19:24
*** suresh12 has joined #openstack-nova19:25
*** adisky__ has quit IRC19:26
*** jdurgin has joined #openstack-nova19:27
*** ijw has quit IRC19:28
*** nicolasbock has quit IRC19:30
*** baoli has joined #openstack-nova19:33
*** dtp has joined #openstack-nova19:40
*** armax has quit IRC19:40
mriedemno artom?!19:41
mriedemkashyap: i assume if i see this in the libvirtd logs, it means it's a persistent domain: "Writing domain status to disk"19:41
mriedemwell i already know it's a persistent domain, so nm19:41
*** awaugama has joined #openstack-nova19:43
*** gomarivera has quit IRC19:43
*** gomarivera has joined #openstack-nova19:47
*** gszasz has joined #openstack-nova19:47
*** Apoorva has quit IRC19:52
*** suresh12 has quit IRC19:53
*** eharney has quit IRC19:53
*** MasterOfBugs has joined #openstack-nova19:54
*** cdent has quit IRC19:56
*** gomarivera has quit IRC19:58
*** krtaylor has joined #openstack-nova20:00
openstackgerritMerged openstack/nova master: Remove old service version check for mitaka  https://review.openstack.org/47239520:02
*** Apoorva has joined #openstack-nova20:03
*** Apoorva has quit IRC20:03
*** Apoorva has joined #openstack-nova20:04
*** MasterOfBugs has quit IRC20:04
*** MasterOfBugs has joined #openstack-nova20:05
*** gomarivera has joined #openstack-nova20:05
*** priteau has joined #openstack-nova20:06
*** dimtruck is now known as zz_dimtruck20:09
*** suresh12 has joined #openstack-nova20:13
*** zz_dimtruck is now known as dimtruck20:14
*** rmart04 has joined #openstack-nova20:14
*** baoli has quit IRC20:18
mriedemsgordon: you might like this https://bugs.launchpad.net/nova/+bug/1696125/comments/16 - we have a bug where detaching an ethernet tap device takes ~5 minutes to be gone from the guest20:18
openstackLaunchpad bug 1696125 in OpenStack Compute (nova) "Detach interface failed - Unable to detach from guest transient domain (pike)" [High,Confirmed] - Assigned to Matt Riedemann (mriedem)20:18
mriedemusing linuxbridge20:18
mriedemnova waits ~1-2 minutes for the device to be gone before giving up20:18
* sgordon braces20:18
mriedemi've done the libvirtd log digging20:18
mriedemnot sure if this is a problem in libvirt/qemu or if it's expected to take this long20:19
mriedemnot a problem for ovs20:19
*** rmart04 has quit IRC20:19
sgordonmmm, and if i am perfectly honest most of the testing on our end focuses on ovs these days20:19
*** dimtruck is now known as zz_dimtruck20:19
*** itlinux_ has quit IRC20:20
*** mnestratov|2 has joined #openstack-nova20:21
mriedemwe could bump this timeout for tap devices, but that's just a workaround, and i believe the tempest tests would actually timeout before that20:22
mriedemtempest times out just at 5 minutes20:23
mriedemso it'd be a craptacular race to the bottom20:23
*** baoli has joined #openstack-nova20:23
*** jpena|away is now known as jpena|off20:23
sgordonmriedem, i would like to think it should not in fact take > 1 minute but i will track down someone who is actually intelligent to look at it20:24
sgordon:)20:24
mriedemsgordon: fwiw the neutron side reverted the change to use vif_type='tap' with linuxbridge https://review.openstack.org/#/c/472365/20:25
mriedeminterested to know why that would make a difference20:25
mriedemthe vif_type is now using 'bridge' again20:25
*** pchavva has quit IRC20:25
mriedemwhich goes through os-vif20:26
mriedemtap does not yet20:26
*** crushil has quit IRC20:27
*** ayogi has quit IRC20:29
*** itlinux_ has joined #openstack-nova20:32
*** baoli has quit IRC20:33
*** suresh12 has quit IRC20:33
*** cleong has quit IRC20:34
*** gbarros has quit IRC20:38
*** zz_dimtruck is now known as dimtruck20:41
*** slaweq has quit IRC20:41
*** slaweq has joined #openstack-nova20:42
openstackgerritMatthew Edmonds proposed openstack/nova master: Use CONF.host for powervm nodename  https://review.openstack.org/47397520:43
*** suresh12 has joined #openstack-nova20:44
*** rajathagasthya has quit IRC20:45
*** slaweq has quit IRC20:46
openstackgerritMatthew Edmonds proposed openstack/nova master: [WIP] Deactivate powervm compute until ready  https://review.openstack.org/47177320:48
*** smatzek has quit IRC20:48
*** suresh12 has quit IRC20:49
*** suresh12 has joined #openstack-nova20:52
*** lucasxu has quit IRC20:54
*** rajathagasthya has joined #openstack-nova20:54
*** alex_xu has quit IRC20:56
*** alex_xu has joined #openstack-nova20:57
*** Apoorva has quit IRC21:01
*** Apoorva has joined #openstack-nova21:01
*** jheroux has quit IRC21:02
*** gouthamr has quit IRC21:03
mriedemclaudiub|2: i thought hyper-v supported fibrechannel? https://docs.openstack.org/developer/nova/support-matrix.html#storage_block_backend_fibrechannel21:07
mriedemhttps://github.com/openstack/nova/blob/master/nova/virt/hyperv/volumeops.py#L36421:08
*** edmondsw has quit IRC21:09
mriedemefried: questions in the powervm support matrix change https://review.openstack.org/#/c/470999/21:09
*** edmondsw has joined #openstack-nova21:09
efriedesberglu ^^21:10
efriedThanks mriedem, looking.21:10
*** baoli has joined #openstack-nova21:10
*** ayogi has joined #openstack-nova21:11
*** edmondsw_ has joined #openstack-nova21:12
openstackgerritMerged openstack/nova master: remove ugly local import  https://review.openstack.org/45078721:12
openstackgerritMatt Riedemann proposed openstack/nova master: Indicate Hyper-v supports fibre channel in support matrix  https://review.openstack.org/47398621:12
*** krtaylor has quit IRC21:13
*** edmondsw has quit IRC21:13
*** gbarros has joined #openstack-nova21:15
claudiub|2mriedem: yep, it does.21:15
mriedemclaudiub|2: ok patched above21:15
claudiub|2i guess we have to update the matrix.21:15
*** thorst_afk has quit IRC21:16
*** edmondsw_ has quit IRC21:16
*** vladikr has quit IRC21:16
*** shaner has quit IRC21:17
mriedemalready did ^21:17
*** suresh12 has quit IRC21:17
openstackgerritMatt Riedemann proposed openstack/nova master: Remove service control from feature support matrix  https://review.openstack.org/47398921:19
*** thorst_afk has joined #openstack-nova21:19
mriedemsdague: dansmith: do you happen to remember what "service control" meant? ^21:20
*** slaweq has joined #openstack-nova21:20
mriedemmaybe it meant QoS?21:20
dansmithmriedem: literally bringing up and down services, I think. not sure if that meant nova-compute itself, or things like turning xen on and off for a given node21:20
dansmithbefore my time I think, but never widely supported AFAIK21:21
mriedemoh like the libvirt driver auto-disabling nova-compute...21:21
dansmithwell, I think it was more that that21:21
mriedemeither way,21:21
dansmithlike if libvirt supported it, it might be system("service libvirt-bin stop") kind of thing21:21
mriedemif we don't know wtf it means, probably best to not doc it and if we care about documenting specifics we do that separately21:22
dansmithyeah21:22
dansmithhere's a good description:21:22
dansmith"not a thing we do"21:22
mriedemheh, reminds me of https://developer.openstack.org/api-ref/compute/?expanded=start-host-detail#start-host21:23
mriedem"This is not implemented by any in-tree compute drivers and therefore will always fail with a 501 NotImplemented error. Needless to say, it is not recommended to use this API and it is deprecated as of the 2.43 microversion."21:23
*** thorst_afk has quit IRC21:23
mriedem"here is our middle finger, have a nice day"21:23
*** slaweq has quit IRC21:24
dansmithheh21:25
dansmithmaybe:21:25
*** suresh12 has joined #openstack-nova21:25
*** mvk has joined #openstack-nova21:25
*** erlon has quit IRC21:28
*** gouthamr has joined #openstack-nova21:28
mriedemefried: OS-DCF:diskConfig is the auto disk configstuff21:32
mriedemold xen thing that predated cloud-init i think21:32
mriedemjohnthetubaguy could probably explain it21:32
mriedemi'd love to remove it from our api code since it's messy21:33
*** felipemonteiro has quit IRC21:34
*** suresh12 has quit IRC21:34
efriedhyperv seems to think it has it also.21:35
mriedemwell, i don't think it means anything to other drivers21:36
mriedemtempest tests against that request parameter in our gate, with libvirt21:36
mriedembut i don't think it does anything21:36
mriedemyeah grep auto_disk_config21:37
mriedemit's an image property only used by the xen driver21:37
efriedLooks like sdague might've been on the road to removing it.21:37
efriedhttps://review.openstack.org/#/c/327188/21:37
efriedTomorrow will be the 1y anniversary of that change ;-)21:37
mriedemefried: that's not removing it from the api,21:38
mriedemthat's just folding the extension controller code in21:38
mriedemhttps://specs.openstack.org/openstack/nova-specs/specs/newton/implemented/api-no-more-extensions.html21:38
efriedΕίναι όλα ελληνικά για μένα21:41
*** fragatina has joined #openstack-nova21:41
*** shaner has joined #openstack-nova21:41
*** suresh12 has joined #openstack-nova21:42
*** thorst_afk has joined #openstack-nova21:43
*** suresh12 has quit IRC21:46
mriedemefried: btw this is where the auto_configure_disk magic happens https://github.com/openstack/nova/blob/master/nova/virt/xenapi/vm_utils.py#L92921:47
mriedembtw, setting independent_compute=True apparently is a super fun NoValidHost :)21:47
*** thorst_afk has quit IRC21:48
*** fragatina has quit IRC21:48
mriedemso i assume any xen operator using that is setting up host aggregates with metadata to tie images with that property to them21:48
*** rfolco has quit IRC21:49
*** edmondsw has joined #openstack-nova21:50
*** oanson_ has joined #openstack-nova21:50
*** fragatina has joined #openstack-nova21:51
*** gbarros has quit IRC21:51
*** gjayavelu has quit IRC21:52
*** MasterOfBugs has quit IRC21:53
*** krtaylor has joined #openstack-nova21:53
*** oanson has quit IRC21:53
*** oanson_ is now known as oanson21:53
*** gjayavelu has joined #openstack-nova21:53
*** rcernin has quit IRC21:54
mriedemhttp://git.openstack.org/cgit/openstack/glance/tree/etc/metadefs/compute-xenapi.json#n24 is actually a nice description21:54
*** edmondsw has quit IRC21:55
*** rajathagasthya has quit IRC21:55
*** fragatina has quit IRC21:55
*** gomarivera has quit IRC21:56
*** xyang1 has quit IRC21:56
*** gomarivera has joined #openstack-nova21:56
*** MasterOfBugs has joined #openstack-nova21:56
*** jianghuaw__ has joined #openstack-nova21:57
*** gomarivera_ has joined #openstack-nova21:58
*** gomarivera has quit IRC21:58
*** burt has quit IRC21:59
*** tidwellr has quit IRC21:59
*** jianghuaw_ has quit IRC22:00
*** gomarivera_ has quit IRC22:03
*** mdrabe has quit IRC22:03
*** priteau has quit IRC22:05
*** esberglu has quit IRC22:07
*** esberglu has joined #openstack-nova22:08
*** shaner has quit IRC22:10
*** jdurgin has quit IRC22:11
*** esberglu has quit IRC22:12
*** claudiub|2 has quit IRC22:13
*** suresh12 has joined #openstack-nova22:15
*** rajathagasthya has joined #openstack-nova22:16
*** ijw has joined #openstack-nova22:20
*** MasterOfBugs has quit IRC22:23
*** shaner has joined #openstack-nova22:23
*** shaner has quit IRC22:23
*** shaner has joined #openstack-nova22:25
dansmithmriedem: dtantsur|afk: ironic job passes with that change, so I'll fix it up and hopefully we're good after that22:26
*** thorst_afk has joined #openstack-nova22:27
*** thorst_afk has quit IRC22:28
openstackgerritDan Smith proposed openstack/nova master: DNM: Canary  https://review.openstack.org/47356522:30
openstackgerritDan Smith proposed openstack/nova master: Make compute_node_statistics() work across cells  https://review.openstack.org/47393122:30
*** esberglu has joined #openstack-nova22:31
mriedemdansmith: cool22:31
mriedemi hope the commit message is super verbose and explanatory about all of the weirdness22:32
mriedemdansmith: also, i think you'd agree with this, but need to check https://review.openstack.org/#/c/459593/26/nova/conductor/manager.py@53222:32
*** salv-orlando has quit IRC22:32
*** salv-orlando has joined #openstack-nova22:33
dansmithmriedem: yeah makes sense I think22:33
mriedemawesome22:33
*** slaweq has joined #openstack-nova22:33
*** esberglu has quit IRC22:36
*** salv-orlando has quit IRC22:37
*** slaweq has quit IRC22:38
*** ayogi has quit IRC22:39
*** egonzalez has quit IRC22:41
openstackgerritMatt Riedemann proposed openstack/nova master: api-ref: fix misleading description in PUT /os-services/disable  https://review.openstack.org/47399722:43
*** mnestratov|2 has quit IRC22:44
*** trinaths has joined #openstack-nova22:45
*** catintheroof has quit IRC22:47
*** gszasz has quit IRC22:48
*** awaugama has quit IRC22:48
*** thorst_afk has joined #openstack-nova22:50
*** MasterOfBugs has joined #openstack-nova22:50
*** sdague has quit IRC22:51
*** fragatina has joined #openstack-nova22:52
mikal.22:53
*** lyan has quit IRC22:55
mriedem.O.22:57
*** tyrefors has quit IRC22:58
*** itlinux_ has quit IRC22:59
*** acormier has quit IRC22:59
*** thorst_afk has quit IRC22:59
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements  https://review.openstack.org/47281422:59
*** thorst_afk has joined #openstack-nova23:00
*** tyrefors has joined #openstack-nova23:01
*** fragatina has quit IRC23:01
*** thorst_afk has quit IRC23:04
*** rajathagasthya has quit IRC23:04
openstackgerritMerged openstack/nova master: libvirt: dump debug info when interface detach times out  https://review.openstack.org/47237723:06
*** ijw has quit IRC23:07
*** vladikr has joined #openstack-nova23:08
*** winston-d_ has quit IRC23:13
mikalmriedem: you peek over the wall more than me23:17
*** gomarivera has joined #openstack-nova23:19
*** jwcroppe has quit IRC23:20
*** baoli has quit IRC23:20
*** gomarivera has quit IRC23:24
*** thorst_afk has joined #openstack-nova23:31
*** jwcroppe has joined #openstack-nova23:33
*** slaweq has joined #openstack-nova23:34
*** takashin has joined #openstack-nova23:35
*** jianghuaw__ has quit IRC23:36
*** thorst_afk has quit IRC23:37
*** jwcroppe has quit IRC23:38
*** slaweq has quit IRC23:38
*** gomarivera has joined #openstack-nova23:40
*** suresh12 has quit IRC23:41
*** jwcroppe has joined #openstack-nova23:42
*** MasterOfBugs has quit IRC23:45
*** suresh12 has joined #openstack-nova23:47
openstackgerritsean mooney proposed openstack/nova master: WIP set ethernet script to /bin/ture  https://review.openstack.org/47400623:52
*** gjayavelu has quit IRC23:52
*** kenperkins has quit IRC23:52
*** suresh12 has quit IRC23:53
*** suresh12 has joined #openstack-nova23:55
*** dtp has quit IRC23:57
*** fragatina has joined #openstack-nova23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!