mriedem | yup | 00:00 |
---|---|---|
melwitt | k. | 00:00 |
melwitt | think I gonna try to go outdoors now | 00:00 |
*** jamesdenton has joined #openstack-nova | 00:00 | |
mriedem | i'm going to go berate my family for awhile | 00:01 |
melwitt | heh | 00:02 |
*** thorst has joined #openstack-nova | 00:02 | |
*** xyang1 has quit IRC | 00:05 | |
*** penick has quit IRC | 00:06 | |
mriedem | alex_xu: when you're around, i've got the novaclient change up for the 2.50 microversion but a todo question in there about how we want to handle the python api if at all https://review.openstack.org/#/c/483060/3/novaclient/v2/quota_classes.py | 00:06 |
mriedem | otherwise the functional tests i added for the cli are all passing, so i'd just need to remove the WIP from the commit message | 00:06 |
*** thorst has quit IRC | 00:07 | |
*** dave-mccowan has joined #openstack-nova | 00:09 | |
*** gmann has quit IRC | 00:11 | |
*** gmann has joined #openstack-nova | 00:11 | |
*** acormier has joined #openstack-nova | 00:17 | |
*** acormier has quit IRC | 00:17 | |
*** Apoorva has quit IRC | 00:17 | |
*** acormier has joined #openstack-nova | 00:18 | |
*** Apoorva has joined #openstack-nova | 00:21 | |
*** yingjun has joined #openstack-nova | 00:21 | |
*** acormier has quit IRC | 00:22 | |
*** acormier has joined #openstack-nova | 00:23 | |
*** jamesdenton has quit IRC | 00:24 | |
*** slaweq_ has joined #openstack-nova | 00:26 | |
*** acormier has quit IRC | 00:27 | |
*** jamesdenton has joined #openstack-nova | 00:27 | |
*** acormier has joined #openstack-nova | 00:29 | |
*** slaweq_ has quit IRC | 00:30 | |
*** acormier has quit IRC | 00:31 | |
*** moshele has quit IRC | 00:31 | |
*** markvoelker has quit IRC | 00:35 | |
*** rajathagasthya has quit IRC | 00:36 | |
*** jamesdenton has quit IRC | 00:37 | |
*** zhurong has joined #openstack-nova | 00:38 | |
*** acormier has joined #openstack-nova | 00:41 | |
*** huanxie has joined #openstack-nova | 00:42 | |
*** acormier has quit IRC | 00:45 | |
*** acormier has joined #openstack-nova | 00:46 | |
*** baoli has joined #openstack-nova | 00:46 | |
*** kiennt has joined #openstack-nova | 00:47 | |
*** markvoelker has joined #openstack-nova | 00:47 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | 00:48 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 00:49 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | 00:49 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926 | 00:50 |
*** baoli has quit IRC | 00:51 | |
*** litao__ has joined #openstack-nova | 00:53 | |
openstackgerrit | Merged openstack/nova master: Trivial: Remove unnecessary format specifier https://review.openstack.org/481574 | 00:54 |
openstackgerrit | Merged openstack/nova master: api-ref: Fix parameters in server-security-groups https://review.openstack.org/476434 | 00:58 |
openstackgerrit | Merged openstack/nova master: api-ref: Add X-Openstack-Request-Id description https://review.openstack.org/474847 | 00:59 |
*** Shunli has joined #openstack-nova | 01:01 | |
*** raunak has quit IRC | 01:02 | |
*** chyka has joined #openstack-nova | 01:03 | |
*** phuongnh has joined #openstack-nova | 01:04 | |
*** chyka has quit IRC | 01:04 | |
*** gouthamr has quit IRC | 01:05 | |
*** liangy has quit IRC | 01:06 | |
*** chyka has joined #openstack-nova | 01:07 | |
*** gjayavelu has quit IRC | 01:08 | |
openstackgerrit | Merged openstack/nova master: Remove nova.api.extensions.server.extensions usage https://review.openstack.org/481494 | 01:11 |
openstackgerrit | Merged openstack/nova master: Stop using deprecated 'message' attribute in Exception https://review.openstack.org/482014 | 01:11 |
openstackgerrit | Merged openstack/nova master: Fix a missing classifier https://review.openstack.org/478733 | 01:12 |
openstackgerrit | Merged openstack/nova master: Query deleted instance records during _destroy_evacuated_instances https://review.openstack.org/467774 | 01:12 |
openstackgerrit | Merged openstack/nova master: Fix parameters and description for os-volume_attachments https://review.openstack.org/480832 | 01:13 |
openstackgerrit | Merged openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322 | 01:14 |
openstackgerrit | Merged openstack/nova master: Use PCIAddressField in oslo.versionedobjects https://review.openstack.org/466201 | 01:14 |
*** prateek has quit IRC | 01:19 | |
*** amotoki_away is now known as amotoki | 01:19 | |
*** fragatina has quit IRC | 01:22 | |
*** owalsh has quit IRC | 01:22 | |
openstackgerrit | Merged openstack/os-vif master: fix read the representor phys_port_name https://review.openstack.org/480213 | 01:22 |
*** fragatina has joined #openstack-nova | 01:22 | |
*** rajathagasthya has joined #openstack-nova | 01:22 | |
*** fragatin_ has joined #openstack-nova | 01:26 | |
*** kristian__ has joined #openstack-nova | 01:26 | |
*** fragatin_ has quit IRC | 01:26 | |
*** slaweq_ has joined #openstack-nova | 01:26 | |
*** liujiong has joined #openstack-nova | 01:26 | |
*** fragatina has quit IRC | 01:27 | |
*** fragatina has joined #openstack-nova | 01:27 | |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Add support for the 2.51 microversion https://review.openstack.org/483149 | 01:31 |
*** slaweq_ has quit IRC | 01:31 | |
*** kristian__ has quit IRC | 01:31 | |
*** rajathagasthya has quit IRC | 01:33 | |
*** yufei has joined #openstack-nova | 01:36 | |
*** kaisers_ has quit IRC | 01:37 | |
*** Apoorva_ has joined #openstack-nova | 01:40 | |
*** baoli has joined #openstack-nova | 01:40 | |
*** zsli_ has joined #openstack-nova | 01:41 | |
*** yufei has quit IRC | 01:43 | |
*** Apoorva has quit IRC | 01:44 | |
*** Shunli has quit IRC | 01:44 | |
*** Apoorva_ has quit IRC | 01:44 | |
*** gcb has joined #openstack-nova | 01:44 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800 | 01:46 |
*** yushb has joined #openstack-nova | 01:48 | |
*** yufei has joined #openstack-nova | 01:50 | |
*** raunak has joined #openstack-nova | 01:51 | |
*** raunak has quit IRC | 01:51 | |
*** acormier_ has joined #openstack-nova | 01:51 | |
*** raunak has joined #openstack-nova | 01:52 | |
*** raunak has quit IRC | 01:52 | |
*** jwcroppe has joined #openstack-nova | 01:54 | |
mriedem | melwitt: i hope the outdoors was enjoyable. i've finished all of the non-test parts of https://review.openstack.org/#/c/416521/ now - found another thing in the compute manager | 01:54 |
mriedem | easy thing | 01:55 |
*** acormier has quit IRC | 01:55 | |
mriedem | i also found 2 more places in the compute manager code that was cleaning up deleted instances but wasn't accounting for that video ram thing with adjust ram quota :) | 01:55 |
*** hongbin has joined #openstack-nova | 01:59 | |
*** weshay is now known as weshay_pto | 02:01 | |
*** gyee has quit IRC | 02:02 | |
*** amotoki is now known as amotoki_away | 02:08 | |
*** thorst has joined #openstack-nova | 02:08 | |
*** itlinux has joined #openstack-nova | 02:10 | |
alex_xu | mriedem: I guess your concern about strict parameters is that it may break the backward-compatible? | 02:10 |
openstackgerrit | Debo Zhang proposed openstack/nova master: Fix typo. https://review.openstack.org/483159 | 02:11 |
alex_xu | it sounds ok we strict parameters in the new microversion. So when the developer upgrade their client code to new microversion, they should check whether there is any interface change in the sdk interface | 02:11 |
*** bkopilov has quit IRC | 02:12 | |
*** thorst has quit IRC | 02:13 | |
alex_xu | mriedem: and we have parameter change in the some microversion https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L76 | 02:13 |
mriedem | alex_xu: yeah we'd leave **kwargs for microversion 2.0 to 2.49 and then have strict kwargs for 2.51 | 02:13 |
mriedem | *2.50 | 02:13 |
alex_xu | gmann: fyi, mriedem already have a patch for the 2.50 in python-novaclient | 02:13 |
mriedem | i also identified some issues in the 2.50 api change | 02:14 |
mriedem | mostly docs | 02:14 |
mriedem | https://review.openstack.org/#/c/467999/ | 02:14 |
alex_xu | mriedem: thanks, I can fix that | 02:15 |
*** fragatin_ has joined #openstack-nova | 02:15 | |
*** fragatin_ has quit IRC | 02:16 | |
*** fragatin_ has joined #openstack-nova | 02:16 | |
*** fragatin_ has quit IRC | 02:16 | |
*** baoli has quit IRC | 02:18 | |
*** fragatina has quit IRC | 02:19 | |
gmann | alex_xu, mriedem thanks for client patch | 02:22 |
*** baoli has joined #openstack-nova | 02:22 | |
gmann | alex_xu, you are fixing api comments? or should i | 02:22 |
mriedem | my eyes are going to dry up and fall out so i'm going to be afk | 02:22 |
*** mriedem is now known as mriedem_away | 02:23 | |
alex_xu | gmann: I can handle that | 02:23 |
gmann | alex_xu, thanks | 02:23 |
*** acormier_ has quit IRC | 02:25 | |
*** slaweq_ has joined #openstack-nova | 02:27 | |
*** tjones has left #openstack-nova | 02:28 | |
openstackgerrit | Debo Zhang proposed openstack/nova master: Fix typo. https://review.openstack.org/483162 | 02:32 |
*** slaweq_ has quit IRC | 02:33 | |
*** tuanluong has joined #openstack-nova | 02:35 | |
*** hongbin_ has joined #openstack-nova | 02:37 | |
*** iceyao has joined #openstack-nova | 02:38 | |
*** hongbin has quit IRC | 02:39 | |
*** fragatina has joined #openstack-nova | 02:40 | |
*** fragatina has quit IRC | 02:44 | |
*** baoli has quit IRC | 02:46 | |
*** mriedem_away has quit IRC | 02:47 | |
*** baoli has joined #openstack-nova | 02:49 | |
*** rajathagasthya has joined #openstack-nova | 02:51 | |
*** yamahata has quit IRC | 02:52 | |
*** baoli has quit IRC | 02:52 | |
*** liangy has joined #openstack-nova | 02:53 | |
*** fragatina has joined #openstack-nova | 02:57 | |
*** esberglu has joined #openstack-nova | 03:00 | |
*** esberglu has quit IRC | 03:00 | |
*** fragatina has quit IRC | 03:01 | |
*** gjayavelu has joined #openstack-nova | 03:05 | |
openstackgerrit | Debo Zhang proposed openstack/nova master: Fix typo https://review.openstack.org/483159 | 03:10 |
*** hongbin_ has quit IRC | 03:16 | |
*** yamahata has joined #openstack-nova | 03:17 | |
*** fragatina has joined #openstack-nova | 03:19 | |
*** liangy has quit IRC | 03:20 | |
*** yushb has quit IRC | 03:21 | |
openstackgerrit | Debo Zhang proposed openstack/nova master: Fix typo https://review.openstack.org/483162 | 03:21 |
*** dave-mccowan has quit IRC | 03:24 | |
*** amotoki_away is now known as amotoki | 03:25 | |
*** slaweq_ has joined #openstack-nova | 03:29 | |
*** rajathagasthya has quit IRC | 03:32 | |
*** hongbin has joined #openstack-nova | 03:32 | |
*** slaweq_ has quit IRC | 03:33 | |
openstackgerrit | Alex Xu proposed openstack/nova master: Fix the releasenote and api-ref for quota-class API https://review.openstack.org/483170 | 03:34 |
alex_xu | gmann: mriedem ^ | 03:34 |
*** udesale has joined #openstack-nova | 03:35 | |
*** prateek has joined #openstack-nova | 03:35 | |
*** bkopilov has joined #openstack-nova | 03:37 | |
*** mdnadeem has joined #openstack-nova | 03:39 | |
*** hongbin has quit IRC | 03:41 | |
*** gjayavelu has quit IRC | 03:45 | |
*** gbarros has quit IRC | 03:49 | |
*** esberglu has joined #openstack-nova | 03:53 | |
openstackgerrit | Debo Zhang proposed openstack/nova master: Fix typo https://review.openstack.org/483159 | 03:54 |
*** esberglu has quit IRC | 03:58 | |
*** rajathagasthya has joined #openstack-nova | 03:59 | |
*** links has joined #openstack-nova | 04:02 | |
*** yufei has quit IRC | 04:02 | |
*** fragatina has quit IRC | 04:03 | |
*** yufei has joined #openstack-nova | 04:03 | |
*** fragatina has joined #openstack-nova | 04:04 | |
openstackgerrit | Merged openstack/nova master: improve notification short-circuit https://review.openstack.org/482497 | 04:09 |
*** fragatina has quit IRC | 04:11 | |
*** iceyao has quit IRC | 04:17 | |
*** zsli__ has joined #openstack-nova | 04:19 | |
*** zsli_ has quit IRC | 04:22 | |
*** fragatina has joined #openstack-nova | 04:26 | |
*** zsli_ has joined #openstack-nova | 04:26 | |
*** felipemonteiro has joined #openstack-nova | 04:27 | |
*** rajathagasthya has quit IRC | 04:28 | |
*** yushb has joined #openstack-nova | 04:29 | |
*** zsli__ has quit IRC | 04:29 | |
*** slaweq_ has joined #openstack-nova | 04:29 | |
*** huanxie has quit IRC | 04:31 | |
*** psachin has joined #openstack-nova | 04:31 | |
*** slaweq_ has quit IRC | 04:35 | |
*** claudiub has joined #openstack-nova | 04:36 | |
*** sree has joined #openstack-nova | 04:36 | |
*** hoonetorg has quit IRC | 04:40 | |
*** mdnadeem has quit IRC | 04:42 | |
*** iceyao has joined #openstack-nova | 04:42 | |
*** baoli has joined #openstack-nova | 04:53 | |
*** mdnadeem has joined #openstack-nova | 04:54 | |
*** hoonetorg has joined #openstack-nova | 04:54 | |
*** baoli has quit IRC | 04:58 | |
*** yufei has quit IRC | 04:59 | |
*** yufei has joined #openstack-nova | 04:59 | |
*** felipemonteiro has quit IRC | 05:01 | |
*** armax has quit IRC | 05:01 | |
*** armax has joined #openstack-nova | 05:01 | |
*** armax has quit IRC | 05:02 | |
*** huanxie has joined #openstack-nova | 05:02 | |
*** fragatina has quit IRC | 05:02 | |
*** armax has joined #openstack-nova | 05:02 | |
*** armax has quit IRC | 05:03 | |
*** fragatina has joined #openstack-nova | 05:03 | |
*** armax has joined #openstack-nova | 05:03 | |
*** armax has quit IRC | 05:03 | |
*** armax has joined #openstack-nova | 05:04 | |
*** armax has quit IRC | 05:04 | |
*** trinaths has joined #openstack-nova | 05:07 | |
*** fragatina has quit IRC | 05:08 | |
*** trinaths1 has joined #openstack-nova | 05:08 | |
*** slaweq_ has joined #openstack-nova | 05:09 | |
*** slaweq_ has quit IRC | 05:11 | |
*** trinaths has quit IRC | 05:12 | |
*** psachin has quit IRC | 05:12 | |
*** psachin has joined #openstack-nova | 05:15 | |
*** ratailor has joined #openstack-nova | 05:17 | |
*** gouthamr has joined #openstack-nova | 05:34 | |
*** rajathagasthya has joined #openstack-nova | 05:35 | |
*** marst has joined #openstack-nova | 05:36 | |
*** rcernin has joined #openstack-nova | 05:40 | |
*** ekuris_ has joined #openstack-nova | 05:42 | |
*** kristian__ has joined #openstack-nova | 05:43 | |
*** hieulq has quit IRC | 05:45 | |
*** tuanluong has quit IRC | 05:45 | |
*** tuanluong has joined #openstack-nova | 05:46 | |
*** hieulq has joined #openstack-nova | 05:46 | |
*** kristian__ has quit IRC | 05:47 | |
*** kiennt has quit IRC | 05:50 | |
*** yufei has quit IRC | 05:56 | |
*** thorst has joined #openstack-nova | 05:57 | |
*** kiennt has joined #openstack-nova | 05:58 | |
openstackgerrit | jichenjc proposed openstack/nova master: add description for supports_migrate_to_same_host https://review.openstack.org/481483 | 06:00 |
*** thorst has quit IRC | 06:03 | |
*** sridharg has joined #openstack-nova | 06:03 | |
*** lpetrut has joined #openstack-nova | 06:06 | |
*** zsli_ has quit IRC | 06:09 | |
*** yufei has joined #openstack-nova | 06:09 | |
*** zsli_ has joined #openstack-nova | 06:10 | |
*** Oku_OS-away is now known as Oku_OS | 06:10 | |
*** slaweq_ has joined #openstack-nova | 06:11 | |
*** vvargaszte has joined #openstack-nova | 06:14 | |
*** slaweq_ has quit IRC | 06:16 | |
*** slaweq_ has joined #openstack-nova | 06:19 | |
*** tylerderosagrund has joined #openstack-nova | 06:19 | |
*** slaweq_ has quit IRC | 06:24 | |
*** tylerderosagrund has quit IRC | 06:24 | |
*** yushb has quit IRC | 06:27 | |
*** huanxie has quit IRC | 06:31 | |
*** zsli__ has joined #openstack-nova | 06:32 | |
*** huanxie has joined #openstack-nova | 06:34 | |
*** zsli_ has quit IRC | 06:35 | |
*** esberglu has joined #openstack-nova | 06:37 | |
*** esberglu has quit IRC | 06:38 | |
*** esberglu has joined #openstack-nova | 06:38 | |
*** esberglu has quit IRC | 06:38 | |
*** chyka has quit IRC | 06:44 | |
*** gjayavelu has joined #openstack-nova | 06:46 | |
*** crushil has joined #openstack-nova | 06:51 | |
*** pcaruana has joined #openstack-nova | 06:52 | |
*** kristian__ has joined #openstack-nova | 06:53 | |
*** yufei has quit IRC | 06:53 | |
*** FL1SK has quit IRC | 06:53 | |
*** crushil has quit IRC | 06:55 | |
*** tesseract has joined #openstack-nova | 06:56 | |
*** yufei has joined #openstack-nova | 06:57 | |
*** sshwarts has joined #openstack-nova | 07:01 | |
*** sree_ has joined #openstack-nova | 07:01 | |
*** sree_ is now known as Guest93990 | 07:02 | |
openstackgerrit | Alex Xu proposed openstack/nova master: Fix the releasenote and api-ref for quota-class API https://review.openstack.org/483170 | 07:05 |
*** sree has quit IRC | 07:05 | |
*** lpetrut has quit IRC | 07:07 | |
*** rajathagasthya has quit IRC | 07:08 | |
*** roeyc has joined #openstack-nova | 07:12 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800 | 07:19 |
*** slaweq_ has joined #openstack-nova | 07:20 | |
*** gouthamr has quit IRC | 07:22 | |
*** nicolasbock has joined #openstack-nova | 07:24 | |
*** slaweq_ has quit IRC | 07:24 | |
*** moshele has joined #openstack-nova | 07:25 | |
*** alexchadin has joined #openstack-nova | 07:25 | |
*** yufei has quit IRC | 07:32 | |
*** yufei has joined #openstack-nova | 07:32 | |
*** lpetrut has joined #openstack-nova | 07:34 | |
*** andreas_s has joined #openstack-nova | 07:36 | |
*** iceyao has quit IRC | 07:36 | |
*** tuanluong has quit IRC | 07:37 | |
*** phuongnh has quit IRC | 07:39 | |
*** vvargaszte1 has joined #openstack-nova | 07:41 | |
*** lpetrut has quit IRC | 07:43 | |
*** vvargaszte has quit IRC | 07:45 | |
*** vvargaszte1 is now known as vvargaszte | 07:45 | |
*** mirrorbox has left #openstack-nova | 07:46 | |
*** ralonsoh has joined #openstack-nova | 07:46 | |
*** damien_r has joined #openstack-nova | 07:47 | |
*** damien_r has quit IRC | 07:47 | |
*** damien_r has joined #openstack-nova | 07:47 | |
*** itlinux has quit IRC | 07:47 | |
openstackgerrit | Alex Szarka proposed openstack/nova master: Raise a real Exception instead of direct Exception call https://review.openstack.org/482200 | 07:48 |
*** damien_r has left #openstack-nova | 07:50 | |
*** nicolasbock has quit IRC | 07:50 | |
*** kristian__ has quit IRC | 07:54 | |
*** kristian__ has joined #openstack-nova | 07:55 | |
*** yushb has joined #openstack-nova | 07:56 | |
*** thorst has joined #openstack-nova | 07:59 | |
*** thorst has quit IRC | 08:03 | |
jangutter | sean-k-mooney: would you have an example handy on that alternate way to set the bridge name in a VIF? (something about trunk ports, I think...) | 08:07 |
*** markvoelker has quit IRC | 08:08 | |
*** ralonsoh has quit IRC | 08:09 | |
*** ralonsoh_ has joined #openstack-nova | 08:09 | |
*** gjayavelu has quit IRC | 08:10 | |
*** lucas-afk is now known as lucasagomes | 08:15 | |
*** slaweq_ has joined #openstack-nova | 08:21 | |
*** slaweq_ has quit IRC | 08:25 | |
*** alexchadin has quit IRC | 08:29 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/449257 | 08:30 |
*** belmoreira has joined #openstack-nova | 08:31 | |
*** slaweq_ has joined #openstack-nova | 08:34 | |
*** slaweq_ has quit IRC | 08:34 | |
*** ralonsoh_ is now known as ralonsoh | 08:37 | |
*** sbezverk has quit IRC | 08:39 | |
openstackgerrit | LiChunlin proposed openstack/nova master: update the description of hypervisor statistics response https://review.openstack.org/462355 | 08:40 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Add Neutron port capabilities to devspec in request https://review.openstack.org/451777 | 08:49 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add memoize function using oslo.cache https://review.openstack.org/472773 | 08:50 |
*** dtantsur|afk is now known as dtantsur | 08:52 | |
*** FL1SK has joined #openstack-nova | 08:53 | |
*** karimb has joined #openstack-nova | 08:56 | |
*** alexchadin has joined #openstack-nova | 08:58 | |
*** efoley has joined #openstack-nova | 09:05 | |
openstackgerrit | Merged openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779 | 09:05 |
*** efoley has quit IRC | 09:05 | |
*** efoley has joined #openstack-nova | 09:05 | |
*** edmondsw has joined #openstack-nova | 09:16 | |
*** kristia__ has joined #openstack-nova | 09:18 | |
*** edmondsw has quit IRC | 09:20 | |
*** kristian__ has quit IRC | 09:21 | |
*** sambetts_ is now known as sambetts | 09:23 | |
*** owalsh has joined #openstack-nova | 09:28 | |
*** mvk has quit IRC | 09:28 | |
*** chenying_ has quit IRC | 09:29 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova master: rbd: Remove unnecessary 'encode' calls https://review.openstack.org/412356 | 09:30 |
*** zsli__ has quit IRC | 09:31 | |
bauzas | stephenfin: hola | 09:32 |
stephenfin | bauzas: Morning | 09:32 |
bauzas | stephenfin: could you please remember me if we need to add a _LW() for any warning log ? | 09:32 |
bauzas | I think so | 09:32 |
bauzas | only debug logs are not needed | 09:32 |
*** tuanluong has joined #openstack-nova | 09:32 | |
openstackgerrit | yuanyue proposed openstack/nova master: Remove ports on create_port timeout during instance build https://review.openstack.org/483280 | 09:33 |
stephenfin | bauzas: No, IIRC we don't need any _L* translations. We only translate exceptions now | 09:33 |
bauzas | okay | 09:33 |
stephenfin | ...which use the '_' symbol | 09:33 |
bauzas | yeah that I know | 09:33 |
bauzas | I thought we said to only translate logs having no debug level | 09:34 |
bauzas | but I didn't remember we said to stop translating any level log | 09:34 |
stephenfin | Hmm, lemme go check | 09:35 |
*** slaweq_ has joined #openstack-nova | 09:35 | |
*** yingjun has quit IRC | 09:35 | |
stephenfin | gcb: Can you say, do we still need to translate LOG.warning logs? | 09:35 |
stephenfin | bauzas: https://docs.openstack.org/nova/latest/i18n.html | 09:36 |
stephenfin | Log messages should not be translated. Any use of _LI(), _LW(), _LE(), _LC() are vestigial and will be removed over time. | 09:36 |
stephenfin | gcb: It's good - we figured it out :) | 09:37 |
bauzas | stephenfin: cool thanks | 09:37 |
gcb | stephenfin: yes, look at https://docs.openstack.org/oslo.i18n/latest/user/usage.html | 09:37 |
openstackgerrit | Alex Szarka proposed openstack/nova master: Add method for verify multiple versioned notifications https://review.openstack.org/465526 | 09:37 |
gcb | Starting with the Pike series, OpenStack no longer supports log translation. It is not necessary to add translation instructions to new code, and the instructions can be removed from old code. Refer to the email thread understanding log domain change on the openstack-dev mailing list for more details. | 09:37 |
gcb | stephenfin^^ | 09:38 |
stephenfin | gcb: Excellent. Thank you :) | 09:38 |
*** cdent has joined #openstack-nova | 09:39 | |
*** slaweq_ has quit IRC | 09:40 | |
cdent | stephenfin: I'm not wise in the ways of policy, does this change (or the linked bug) make sense: https://review.openstack.org/#/c/481443/ | 09:40 |
stephenfin | cdent: I was purposefully leaving that until if/when johnthetubaguy was back. Apparently we were removing all default rules, so I'd imagine that will have some bearing on that | 09:42 |
cdent | stephenfin: ah okay, so the burden of setting the default is on the deployment? | 09:43 |
*** liusheng has quit IRC | 09:43 | |
stephenfin | cdent: Wait, no - that was _discoverable_ policies (because they no longer make sense) | 09:44 |
*** karimb has quit IRC | 09:44 | |
*** liusheng has joined #openstack-nova | 09:44 | |
*** liusheng has quit IRC | 09:44 | |
stephenfin | Looks like claudiub added a load of those default rules. Maybe he can review https://review.openstack.org/#/c/481443/ and see if it makes sense? | 09:44 |
*** liusheng has joined #openstack-nova | 09:45 | |
*** karimb has joined #openstack-nova | 09:46 | |
*** mvk has joined #openstack-nova | 09:55 | |
*** tylerderosagrund has joined #openstack-nova | 09:56 | |
openstackgerrit | Rikimaru Honjo proposed openstack/nova master: compute: Do not create bdms before successfully reserving a volume https://review.openstack.org/290793 | 09:56 |
*** tylerderosagrund has quit IRC | 10:00 | |
*** thorst has joined #openstack-nova | 10:00 | |
*** thorst has quit IRC | 10:04 | |
*** alexchadin has quit IRC | 10:06 | |
*** yufei has quit IRC | 10:06 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Always set MTU when plugging devices https://review.openstack.org/408781 | 10:07 |
*** markvoelker has joined #openstack-nova | 10:09 | |
*** kiennt has quit IRC | 10:09 | |
*** amotoki is now known as amotoki_away | 10:10 | |
*** pallavi_ has joined #openstack-nova | 10:10 | |
pallavi_ | Hi , I have done ubuntu manual installation for ocata release. I have launched instance. But accessing to the instance is not happening.?? Can anyone please help me out to figure it out | 10:12 |
*** Guest93990 has quit IRC | 10:16 | |
*** esberglu has joined #openstack-nova | 10:16 | |
*** esberglu has quit IRC | 10:16 | |
claudiub | stephenfin: replied. that patch LGTM. | 10:17 |
stephenfin | claudiub: Thanks :) If you're happy, so am I | 10:18 |
*** owalsh has quit IRC | 10:19 | |
*** owalsh has joined #openstack-nova | 10:21 | |
*** liujiong has quit IRC | 10:22 | |
*** yushb has quit IRC | 10:22 | |
*** owalsh has quit IRC | 10:22 | |
claudiub | stephenfin: if you're happy and you know it, clap your hands! *clap* *clap*. :D | 10:23 |
cdent | thanks claudiub | 10:23 |
*** nicolasbock has joined #openstack-nova | 10:25 | |
gibi | bauzas: hi! There is a small test and doc only patch that needs a second +2. Could you check it please? https://review.openstack.org/#/c/480469/ | 10:28 |
bauzas | gibi: roger this. | 10:28 |
gibi | bauzas: thanks! | 10:28 |
*** yamamoto has quit IRC | 10:31 | |
*** amotoki_away is now known as amotoki | 10:32 | |
*** mvk has quit IRC | 10:34 | |
sean-k-mooney | jangutter: hi the bridge name is currently set here https://github.com/openstack/neutron/blob/8326a65a5e3c70c66a5297c618d0202c9395cc3f/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#L94-L105 | 10:35 |
*** slaweq_ has joined #openstack-nova | 10:36 | |
*** udesale has quit IRC | 10:36 | |
*** karimb_ has joined #openstack-nova | 10:36 | |
sean-k-mooney | jangutter: so in you mech driver if you just overrided that fuction you can pass the bridge name via the vif binding details. | 10:37 |
*** owalsh has joined #openstack-nova | 10:38 | |
*** tbachman has quit IRC | 10:38 | |
*** amotoki is now known as amotoki_away | 10:38 | |
sean-k-mooney | jangutter: this then get populated into the os-vif network object here https://github.com/openstack/nova/blob/d955eb1db753f191acb02eb9758080329da5b866/nova/network/os_vif_util.py#L225-L226 | 10:38 |
*** karimb has quit IRC | 10:38 | |
*** tbachman has joined #openstack-nova | 10:39 | |
sean-k-mooney | jangutter: and its used in os-vif here: https://github.com/openstack/os-vif/blob/4a8e07f6c502e5e3b99db9ba543a501fbb138596/vif_plug_ovs/ovs.py#L97 and anywayer else we need the bridge name | 10:40 |
*** owalsh has quit IRC | 10:41 | |
*** slaweq_ has quit IRC | 10:41 | |
*** yamahata has quit IRC | 10:41 | |
*** owalsh has joined #openstack-nova | 10:43 | |
*** markvoelker has quit IRC | 10:43 | |
*** zhurong has quit IRC | 10:43 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove plug_ovs_hybrid, unplug_ovs_hybrid https://review.openstack.org/483030 | 10:43 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Remove useless test https://review.openstack.org/483031 | 10:43 |
bauzas | stephenfin: gibi: something got messed up with our man pages | 10:44 |
stephenfin | ? | 10:44 |
bauzas | eg. <http://docs.openstack.org/developer/nova/man/nova-manage.html#nova-cells-v2 is pointing nowhere | 10:44 |
stephenfin | Yeah, that's a pbr bug | 10:44 |
stephenfin | *Oh, that's like that pbr bug | 10:44 |
stephenfin | *likely | 10:44 |
stephenfin | dammit | 10:44 |
stephenfin | bauzas: https://bugs.launchpad.net/pbr/+bug/1702872 | 10:45 |
openstack | Launchpad bug 1702872 in PBR "pbr + Sphinx 1.6+ ignores the '[sphinx_build] builders' setuptools option" [Undecided,In progress] - Assigned to Stephen Finucane (stephenfinucane) | 10:45 |
*** lpetrut has joined #openstack-nova | 10:45 | |
stephenfin | I'll tack a fix onto the end of the https://review.openstack.org/#/q/topic:doc-migration+project:openstack/nova series, once pep8 fix patch goes in (it needs a rebase again) | 10:46 |
bauzas | stephenfin: I just +2d https://review.openstack.org/#/c/478472/7 because it workarounds the issue | 10:46 |
bauzas | stephenfin: I'm not sure it should be a cli/ section, but meh | 10:46 |
bauzas | at least it's understandable that nova-manage and nova-status are CLI tools | 10:47 |
stephenfin | Yeah, sdague said the same thing. However, we've no where else to put those man pages | 10:47 |
stephenfin | I wanted that section called 'man' instead, but didn't make my case strongly enough :( | 10:48 |
* gibi is glad stephenfin knew the answer | 10:48 | |
*** amotoki_away is now known as amotoki | 10:49 | |
*** mvk has joined #openstack-nova | 10:50 | |
*** gcb has quit IRC | 10:52 | |
*** acormier has joined #openstack-nova | 10:53 | |
*** acormier has quit IRC | 10:55 | |
openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | 10:55 |
*** acormier has joined #openstack-nova | 10:55 | |
*** amotoki is now known as amotoki_away | 10:57 | |
*** bkopilov has quit IRC | 10:57 | |
*** jamesdenton has joined #openstack-nova | 10:59 | |
*** thorst has joined #openstack-nova | 11:01 | |
*** thorst has quit IRC | 11:05 | |
*** esberglu has joined #openstack-nova | 11:10 | |
*** jamesdenton has quit IRC | 11:12 | |
*** yamamoto has joined #openstack-nova | 11:13 | |
*** mvk has quit IRC | 11:13 | |
*** jamesdenton has joined #openstack-nova | 11:13 | |
openstackgerrit | Chris Dent proposed openstack/nova master: Add functional test for two-cell scheduler behaviors https://review.openstack.org/452006 | 11:13 |
*** tbachman has quit IRC | 11:14 | |
*** esberglu has quit IRC | 11:14 | |
*** tbachman has joined #openstack-nova | 11:15 | |
*** thorst has joined #openstack-nova | 11:17 | |
*** yamamoto has quit IRC | 11:18 | |
*** amotoki_away is now known as amotoki | 11:21 | |
*** yamamoto has joined #openstack-nova | 11:21 | |
*** smatzek has joined #openstack-nova | 11:24 | |
*** liangy has joined #openstack-nova | 11:26 | |
*** mvk has joined #openstack-nova | 11:26 | |
*** yamamoto has quit IRC | 11:26 | |
*** jamesden_ has joined #openstack-nova | 11:34 | |
*** ekuris_ has quit IRC | 11:35 | |
*** trinaths1 has left #openstack-nova | 11:36 | |
*** yamamoto has joined #openstack-nova | 11:36 | |
*** moshele has quit IRC | 11:37 | |
*** slaweq_ has joined #openstack-nova | 11:37 | |
*** jamesdenton has quit IRC | 11:37 | |
*** damien_r has joined #openstack-nova | 11:37 | |
*** lpetrut_ has joined #openstack-nova | 11:38 | |
*** tbachman_ has joined #openstack-nova | 11:39 | |
*** tbachman has quit IRC | 11:39 | |
*** tbachman_ is now known as tbachman | 11:39 | |
*** yamamoto has quit IRC | 11:40 | |
*** markvoelker has joined #openstack-nova | 11:41 | |
*** lpetrut has quit IRC | 11:41 | |
*** slaweq_ has quit IRC | 11:42 | |
*** gszasz has joined #openstack-nova | 11:44 | |
*** acormier has quit IRC | 11:46 | |
*** acormier has joined #openstack-nova | 11:47 | |
*** gbarros has joined #openstack-nova | 11:49 | |
*** ekuris_ has joined #openstack-nova | 11:49 | |
*** yamamoto has joined #openstack-nova | 11:50 | |
*** acormier has quit IRC | 11:51 | |
*** huanxie has quit IRC | 11:54 | |
gibi | cdent: thank you for your detailed answer on my placement question on the ML. It helps a lot | 11:54 |
*** yamamoto has quit IRC | 11:54 | |
*** tylerderosagrund has joined #openstack-nova | 11:56 | |
openstackgerrit | Claudiu Belu proposed openstack/nova master: hyperv: Cleans up live migration Planned VM https://review.openstack.org/478943 | 11:57 |
jangutter | sean-k-mooney: hmmm, I still get: ERROR os_vif NotImplementedError: Cannot load 'bridge' in the base class | 11:57 |
*** ratailor has quit IRC | 11:57 | |
*** tbachman has quit IRC | 11:57 | |
*** Oku_OS has quit IRC | 11:58 | |
sean-k-mooney | jangutter: how are you accessing the bridge? via the network object? | 11:58 |
*** owalsh has quit IRC | 11:59 | |
jangutter | sean-k-mooney: vif.network.bridge -> I think that might not be populated for vhostuser | 11:59 |
*** litao__ has quit IRC | 11:59 | |
sean-k-mooney | jangutter: if you do a neutron port show or openstack port show do you see the bridge correctly set in the vif_binding_details | 11:59 |
sean-k-mooney | jangutter: it should be populated or it means that vlan aware vms dose not work for vhost-user and this is a nova bug we need to fix | 12:00 |
*** tbachman has joined #openstack-nova | 12:00 | |
*** dave-mccowan has joined #openstack-nova | 12:01 | |
*** udesale has joined #openstack-nova | 12:01 | |
sean-k-mooney | jangutter: yep you are right.... https://github.com/openstack/nova/blob/d955eb1db753f191acb02eb9758080329da5b866/nova/network/neutronv2/api.py#L2157-L2179 | 12:01 |
sean-k-mooney | jangutter: do you want to submit the patch or will i | 12:02 |
jangutter | sean-k-mooney: binding_vif_details -> ovs_hybrid_plug='False', port_filter='True' | 12:02 |
sean-k-mooney | actully no i misread that https://github.com/openstack/nova/blob/d955eb1db753f191acb02eb9758080329da5b866/nova/network/neutronv2/api.py#L2172-L2173 it is saved for vhost-user | 12:03 |
jangutter | sean-k-mooney: depends on what will get it merged faster :-) | 12:03 |
sean-k-mooney | jangutter: so ya the bug is in the neutron ml2 driver yuou are missing the bridge key in the vif_binding_details | 12:04 |
jangutter | sean-k-mooney: Aah, and the workaround is to add: elif vif_type == network_model.VIF_TYPE_AGILIO_OVS to that list. | 12:05 |
sean-k-mooney | jangutter: you really should not have a new vif_type | 12:05 |
*** pallavi_ has quit IRC | 12:06 | |
sean-k-mooney | there will not be a new vif object in os-vif and you should not need one for nova or neutron | 12:06 |
*** thorst has quit IRC | 12:06 | |
sean-k-mooney | the vif type shoud just be VIF_TYPE_VHOSTUSER | 12:06 |
*** owalsh has joined #openstack-nova | 12:07 | |
*** owalsh has quit IRC | 12:07 | |
jangutter | sean-k-mooney: I am using VIF_TYPE_VHOSTUSER for the actual plugging. | 12:07 |
sean-k-mooney | jangutter: you should also be using it for port binding | 12:07 |
*** owalsh has joined #openstack-nova | 12:07 | |
sean-k-mooney | we are trying to stop using vif types as a flag for how to plug interfaces and retrun them to being a statemant about what type if interface you want | 12:08 |
*** fragatina has joined #openstack-nova | 12:08 | |
sean-k-mooney | or in otherwords the vif_type is an abstion for the hyperviser interface type and is not related to how that interface is pluged to the network backend at all | 12:09 |
jangutter | sean-k-mooney: yeah. so one thing that kinda breaks the abstraction is that the "forwarder" is actually a kind of translation layer on top of the hypervisor. | 12:10 |
sean-k-mooney | jangutter: that is captured by the vnic_type | 12:10 |
jangutter | sean-k-mooney: and introducing another layer just leads to madness. | 12:10 |
jangutter | sean-k-mooney: yep. let me see if I can figure out if I'm doing the wrong thing in my ML2 driver. | 12:11 |
*** thorst has joined #openstack-nova | 12:11 | |
jangutter | sean-k-mooney: (facepalm) network_model.VIF_DETAILS_VHOSTUSER_OVS_PLUG | 12:12 |
*** markvoelker has quit IRC | 12:13 | |
sean-k-mooney | jangutter: ya you might need to set that | 12:13 |
*** sudhirag0987 has joined #openstack-nova | 12:13 | |
sean-k-mooney | that is a legacy thing that should go away when we can specify the plugin to use in the vif details | 12:14 |
*** tbachman_ has joined #openstack-nova | 12:14 | |
*** tbachman has quit IRC | 12:14 | |
*** tbachman_ is now known as tbachman | 12:14 | |
*** foutatoro has joined #openstack-nova | 12:15 | |
*** tuanluong has quit IRC | 12:16 | |
foutatoro | hi all, I would like to know how to deploy hypervisors VMware vSphere and Hyper-V on compute nodes ? | 12:17 |
*** yamamoto has joined #openstack-nova | 12:17 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091 | 12:18 |
openstackgerrit | Béla Vancsics proposed openstack/nova master: Transform aggregate.update_metadata notification https://review.openstack.org/460625 | 12:18 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: use already loaded BDM in instance.<action> https://review.openstack.org/483324 | 12:19 |
*** baoli has joined #openstack-nova | 12:23 | |
*** bkopilov has joined #openstack-nova | 12:24 | |
*** pchavva has joined #openstack-nova | 12:26 | |
*** baoli has quit IRC | 12:28 | |
*** baoli has joined #openstack-nova | 12:29 | |
cdent | gibi: glad it was of some use, looking forward to seeing more of what you're doing | 12:30 |
*** cdent has quit IRC | 12:31 | |
stephenfin | sean-k-mooney, jaypipes: Fancy taking a look at this? Easy +1/2, imo https://review.openstack.org/#/c/483030/ | 12:32 |
*** markvoelker has joined #openstack-nova | 12:32 | |
toabctl | is there a way to list hosts which are not attached to a cell (v2) ? | 12:34 |
*** vvargaszte has quit IRC | 12:34 | |
*** sridharg has quit IRC | 12:34 | |
*** deep-book-gk_ has joined #openstack-nova | 12:35 | |
*** tbachman has quit IRC | 12:36 | |
*** sridharg has joined #openstack-nova | 12:37 | |
*** deep-book-gk_ has left #openstack-nova | 12:37 | |
*** sridharg has quit IRC | 12:38 | |
*** slaweq_ has joined #openstack-nova | 12:38 | |
sean-k-mooney | stephenfin: sure, looking at it now | 12:38 |
*** gcb has joined #openstack-nova | 12:39 | |
*** sridharg has joined #openstack-nova | 12:39 | |
*** prateek has quit IRC | 12:41 | |
*** liverpooler has joined #openstack-nova | 12:41 | |
stephenfin | sean-k-mooney: Cheers. Out of curiosity, is the expectation that all the old, non-os-vif plugging/unplugging code would eventually be replaced by code that harnesses vendor-developed os-vif plugins? | 12:42 |
*** slaweq_ has quit IRC | 12:43 | |
stephenfin | e.g. All of these https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L599-L764 would be replaced by these https://github.com/openstack/nova/blob/master/nova/network/os_vif_util.py#L346-L403 | 12:43 |
openstackgerrit | Merged openstack/nova master: doc: Enable pep8 on doc generation code https://review.openstack.org/480469 | 12:44 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/483337 | 12:44 |
sean-k-mooney | stephenfin: yes that was the original intention was to add an os-vif pluging for all the old types. modify neutron ml2 driver to pass plugin name in vif details and then eventurlly remove os_vif_util when we finally have neutron retrunin serialised os-vif objects from its api | 12:47 |
*** jmlowe has joined #openstack-nova | 12:47 | |
*** alexchadin has joined #openstack-nova | 12:48 | |
stephenfin | sean-k-mooney: OK, so regarding the comment here https://review.openstack.org/#/c/483030/2/nova/virt/libvirt/vif.py ... | 12:50 |
stephenfin | would we be submitting a bug against os-vif, or would that be a separate plugin maintained in its own repo by the floodlight team? | 12:52 |
sean-k-mooney | stephenfin: yep i was suggesting opening a bug against https://github.com/openstack/networking-bigswitch | 12:52 |
stephenfin | ahhh | 12:52 |
*** jwcroppe has quit IRC | 12:53 | |
sean-k-mooney | stephenfin: IVS is a bigswitch networks competitor to ovs . it is the only thing that uses the IVS vif type https://github.com/openstack/networking-bigswitch/blob/master/networking_bigswitch/plugins/ml2/drivers/mech_bigswitch/driver.py#L422-L431 | 12:54 |
stephenfin | sean-k-mooney: Yeah, so they'd "own" the repo. It would be merged into 'openstack/os-vif'? | 12:54 |
*** kristia__ has quit IRC | 12:55 | |
sean-k-mooney | stephenfin: no its an non reference backend so im proposing that we wright an os-vif plugin for them and proposes it to there repo then deprecate the nova code and remove it once it is merged | 12:56 |
*** kristian__ has joined #openstack-nova | 12:56 | |
*** catintheroof has joined #openstack-nova | 12:56 | |
*** kristian__ has quit IRC | 12:56 | |
sean-k-mooney | stephenfin: alternitively we can create our only os-vif-ivs repo and that we own for this backend | 12:56 |
*** kristian__ has joined #openstack-nova | 12:56 | |
*** links has quit IRC | 12:57 | |
sean-k-mooney | it depend on whetere you want to tie the packaging of the plugin to the packaging of the ml2 driver which arguably you might want to keep seprate | 12:57 |
stephenfin | We'll let them make that decision, I guess | 13:00 |
stephenfin | sean-k-mooney: ...though IMO they're separate products so they should be. We'll see | 13:00 |
stephenfin | I'll file that bug now | 13:01 |
sean-k-mooney | am well if we have a seperate repo we dont need a bug on networking-bigswtich though we could use that bug to disucss this with them i guess? | 13:02 |
*** sbezverk has joined #openstack-nova | 13:02 | |
*** mdnadeem has quit IRC | 13:03 | |
stephenfin | sean-k-mooney: Yeah, that's what I think. They will probably have their own ideas too | 13:05 |
stephenfin | If nothing else, they'll need to give us a repo to populate | 13:05 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/483337 | 13:06 |
*** MVenesio has joined #openstack-nova | 13:06 | |
*** kylek3h has joined #openstack-nova | 13:07 | |
*** yassine has joined #openstack-nova | 13:07 | |
*** alexchadin has quit IRC | 13:09 | |
*** mriedem has joined #openstack-nova | 13:09 | |
*** gmann_ has joined #openstack-nova | 13:12 | |
stephenfin | sean-k-mooney: https://bugs.launchpad.net/networking-bigswitch/+bug/1704129 | 13:16 |
openstack | Launchpad bug 1704129 in networking-bigswitch "Add an IVS os-vif plugin" [Undecided,New] | 13:16 |
*** ekuris_ has quit IRC | 13:18 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: use already loaded BDM in instance.<action> https://review.openstack.org/483324 | 13:19 |
sean-k-mooney | stephenfin: cool i have subscribed to the bug so i should get pinged if they respond | 13:22 |
sean-k-mooney | stephenfin: the only thing i hate about the contrail plugin is that they do not use the setup.cfg to declare there entrypoitns and instead to it all in setup.py https://github.com/Juniper/contrail-nova-vif-driver/blob/master/setup.py | 13:24 |
stephenfin | sean-k-mooney: That's because they're not using pbr | 13:25 |
sean-k-mooney | stephenfin: but its a good example of how to do in correctly otherwise | 13:25 |
stephenfin | pbr had setuptools plugins that allow reading of things like that from 'setup.cfg'. By default though, setuptools doesn't support that | 13:25 |
stephenfin | *has | 13:25 |
*** acormier has joined #openstack-nova | 13:25 | |
stephenfin | sean-k-mooney: We could always draft a cookiecutter template if it would help people? | 13:25 |
sean-k-mooney | stephenfin: oh really . there is one | 13:26 |
sean-k-mooney | oh you mean for os-vif plugins? | 13:26 |
*** jwcroppe has joined #openstack-nova | 13:26 | |
sean-k-mooney | stephenfin: the cookicutter template for new openstack project i think has not been updated for pbr yet | 13:26 |
stephenfin | Yup, a cookiecutter template for plugins | 13:26 |
sean-k-mooney | stephenfin: unless you did it | 13:26 |
stephenfin | I think I did | 13:26 |
*** acormier has quit IRC | 13:26 | |
*** eharney has joined #openstack-nova | 13:27 | |
sean-k-mooney | oh i have been meaning to aks you how to fix one of our repos to use pbr correctly | 13:27 |
*** acormier has joined #openstack-nova | 13:27 | |
stephenfin | sean-k-mooney: link? | 13:28 |
*** esberglu has joined #openstack-nova | 13:28 | |
sean-k-mooney | stephenfin: https://github.com/openstack/devstack-plugin-libvirt-qemu | 13:28 |
gmann_ | mriedem: i replied on https://review.openstack.org/#/c/482994/1 | 13:28 |
*** gabor_antal_ is now known as gabor_antal | 13:28 | |
openstackgerrit | Hironori Shiina proposed openstack/nova master: Ironic: Support boot from Cinder volume https://review.openstack.org/215385 | 13:28 |
sean-k-mooney | stephenfin: hum need to fix the readme too... | 13:29 |
gmann_ | mriedem: 'events' can be empty fro coding we have on controller side :) but very rare to rare timing things | 13:29 |
gmann_ | *from | 13:29 |
sean-k-mooney | stephenfin: we can gret rid of all the mail map stuff correct and there is some other boiler plate stuff that pbr will do for us too i think | 13:29 |
gmann_ | https://github.com/openstack/nova/blob/d955eb1db753f191acb02eb9758080329da5b866/nova/api/openstack/compute/instance_actions.py#L106 | 13:29 |
mriedem | gmann_: ok, but an empty events list is different from an event with no 'event.start_time' key | 13:31 |
*** sudhirag0987 has quit IRC | 13:31 | |
stephenfin | sean-k-mooney: What's wrong with that project exactly? Looks a-ok to me? | 13:33 |
gmann_ | mriedem: is it. 'events' has direct 'start_time' so 'events' will be with no sub key | 13:33 |
*** thorst has quit IRC | 13:33 | |
*** Oku_OS-away has joined #openstack-nova | 13:34 | |
*** Oku_OS-away is now known as Oku_OS | 13:34 | |
gmann_ | mriedem: i commented the event record on compute service side and then we will have like this - http://paste.openstack.org/show/615266/ | 13:34 |
sean-k-mooney | stephenfin: it may be fine now. i know orginally after teh cookie cotter template it had the old change log and a few other things but rodolfo may have allready cleaned up everythin | 13:35 |
mriedem | gmann_: consider it like the os-extended-volumes:volumes_attached field in the server details response | 13:35 |
mriedem | that can be an empty list, which doesn't mean os-extended-volumes:volumes_attached.id is marked optional in the api ref | 13:35 |
mriedem | it means os-extended-volumes:volumes_attached will be in the response, but can be an empty list | 13:36 |
mriedem | And the description reflects that, " The attached volumes, if any." | 13:36 |
mriedem | now if you have volumes attached, the os-extended-volumes:volumes_attached.id and os-extended-volumes:volumes_attached.delete_on_termination keys will be in there, | 13:36 |
mriedem | and they are required | 13:36 |
mriedem | i'm saying it's the same thing for instance action events and the start_time field per event | 13:37 |
mriedem | *Except* the 'events' list is optional | 13:37 |
mriedem | which was what i changed in my patch | 13:37 |
mriedem | https://review.openstack.org/#/c/480792/ | 13:37 |
*** slaweq_ has joined #openstack-nova | 13:39 | |
gibi | mriedem: hi! I proposed the first patch to use already in scope BDM for the notification payload as you suggested yesterday. Could take a brief look to see if it is a good directions? https://review.openstack.org/#/c/483324/ | 13:41 |
gmann_ | mriedem: i see your point. and from api-ref yes your point makes more sense to understand the api response. but from tempest response schema those should not be marked required | 13:42 |
mriedem | gibi: yeah maybe later | 13:42 |
mriedem | gmann_: but why? if there are events, and there is an event within the list of events, tempest should care that start_time is there | 13:43 |
*** smatzek has quit IRC | 13:44 | |
mriedem | the keys for the event will be in the response, the values may be null if the event is not done, like finish_time and traceback | 13:44 |
mriedem | and result | 13:44 |
*** slaweq_ has quit IRC | 13:44 | |
mriedem | required == you expect a key in the body dict, right? | 13:44 |
mriedem | required != that key must map to a non-None value | 13:44 |
*** awaugama has joined #openstack-nova | 13:44 | |
gmann_ | mriedem: i am saying it can eb emtpy list means no start_time inside 'events' key | 13:45 |
*** takashin has joined #openstack-nova | 13:45 | |
gmann_ | mriedem: if api controller always insert those subkey even as null then i agree but that is not case | 13:46 |
gmann_ | because we insert 'events' key in response based on policy and insterts its subkey based on event we have in db or not | 13:46 |
gmann_ | so if later is not there we end up with 'events' with no sub key | 13:47 |
mriedem | gmann_: is jsonschema going to validate against an entry that isn't in the response? | 13:48 |
mriedem | we should have 2 schemas, | 13:48 |
mriedem | 1 for the instanceAction response, which has the 'events' key which is optional and is an array | 13:49 |
stephenfin | sean-k-mooney, ralonsoh: https://review.openstack.org/483398 | 13:49 |
mriedem | and 1 for the instanceAction.events, which is an object type, which has fields like start_time, finish_time, traceback, etc - those are required | 13:49 |
stephenfin | Ye silly gooses :) | 13:49 |
stephenfin | gmann_: Can you take a second look at my replies here when you have a chance? https://review.openstack.org/#/c/478484/ | 13:50 |
ralonsoh | stephenfin: thanks! I'll review the patch now | 13:51 |
gmann_ | mriedem: current schema will check 'events' as optional as it is policy based. as on some cloud it can be present and on other it cannot be | 13:51 |
*** acormier has quit IRC | 13:52 | |
gmann_ | mriedem: and my point is to have 'events' array schema also same way which validate start_time etc if those are present in response otherwise skip | 13:53 |
gmann_ | mriedem: but if we say those as mandatory in api-ref i am ok to validate those strictly by not looking at the code. | 13:53 |
gmann_ | which i should not when i work from tempest perspective :) | 13:53 |
*** acormier has joined #openstack-nova | 13:53 | |
*** acormier has quit IRC | 13:54 | |
gmann_ | stephenfin: sure, ll check tomorrow morning. may be i still argue on those doc in reference but let me rethink on those | 13:54 |
*** acormier has joined #openstack-nova | 13:54 | |
*** amotoki is now known as amotoki_away | 13:54 | |
stephenfin | gmann_: Sounds good to me | 13:55 |
*** roeyc has quit IRC | 13:56 | |
*** sree has joined #openstack-nova | 13:59 | |
mriedem | nova meeting in 1 minute | 13:59 |
* bauzas fastens the belt | 14:00 | |
*** gmann_ has quit IRC | 14:00 | |
*** gmann_ has joined #openstack-nova | 14:00 | |
sean-k-mooney | stephenfin: hehe thanks for taking a look at openstack/devstack-plugin-libvirt-qemu most of the crft can be removed but we shoudl keep the docs/release note stuff | 14:02 |
*** belmoreira has quit IRC | 14:02 | |
*** cdent has joined #openstack-nova | 14:03 | |
stephenfin | sean-k-mooney: Yeah, you can rework it to add that | 14:03 |
stephenfin | fine by me :) | 14:03 |
sean-k-mooney | stephenfin: yep ill be happy too. i didnt actully expect a patch. i was just hopeing for some pointers to make sure we were uptodate with the new ways to handel pbr and the other project config stuff | 14:05 |
*** yushb has joined #openstack-nova | 14:05 | |
stephenfin | Ah, it's all good. Easy fix | 14:05 |
openstackgerrit | Hironori Shiina proposed openstack/nova master: Ironic: Get IP address for volume connector https://review.openstack.org/468353 | 14:05 |
*** hongbin has joined #openstack-nova | 14:06 | |
*** smatzek has joined #openstack-nova | 14:06 | |
*** acormier_ has joined #openstack-nova | 14:07 | |
*** acormier_ has quit IRC | 14:07 | |
*** acormier_ has joined #openstack-nova | 14:07 | |
*** yushb has quit IRC | 14:09 | |
*** acormier has quit IRC | 14:10 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Populate the 'configuration' section https://review.openstack.org/478473 | 14:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Populate the 'cli' section https://review.openstack.org/478472 | 14:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Populate the 'user' section https://review.openstack.org/478475 | 14:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Switch to openstackdocstheme https://review.openstack.org/477751 | 14:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Populate the 'contributor' section https://review.openstack.org/478474 | 14:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Start using oslo_config.sphinxext https://review.openstack.org/482961 | 14:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Rework README to reflect new doc URLs https://review.openstack.org/480074 | 14:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Start using oslo_policy.sphinxext https://review.openstack.org/479358 | 14:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: policies: Fix Sphinx issues https://review.openstack.org/480516 | 14:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Populate the 'reference' section https://review.openstack.org/478484 | 14:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Rework index page per new sections https://review.openstack.org/478485 | 14:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Remove dead files https://review.openstack.org/478470 | 14:11 |
jangutter | sean-k-mooney: so how would I write an external plugin _without_ creating a new VIF type? | 14:19 |
*** fragatina has quit IRC | 14:21 | |
*** aarefiev is now known as aarefiev_afk | 14:21 | |
*** acormier has joined #openstack-nova | 14:22 | |
*** psachin has quit IRC | 14:22 | |
*** acormier has quit IRC | 14:23 | |
*** itlinux_ has joined #openstack-nova | 14:23 | |
*** acormier has joined #openstack-nova | 14:23 | |
*** acormier_ has quit IRC | 14:25 | |
*** burt has joined #openstack-nova | 14:26 | |
*** thorst has joined #openstack-nova | 14:29 | |
bauzas | jaypipes: I saw your rant yesterday about the scheduler, could you please clarify your concerns ? | 14:31 |
bauzas | jaypipes: the fact that we're amending the ReqSpec by adding the found host ? | 14:31 |
jaypipes | bauzas: hmm? no, nothing to do with amending reqspec | 14:31 |
bauzas | it's just because of the affinity filter, but not sure I understand your problem honestly | 14:32 |
bauzas | jaypipes: you were telling dan you had a problem with that yesterday night :) | 14:32 |
jaypipes | bauzas: oh, yeah, sorry, that was a different rant :) | 14:32 |
bauzas | anway, if I can help you... | 14:33 |
bauzas | at least by sharing thoughts | 14:33 |
jaypipes | bauzas: my general annoyance with the scheduler is its tight coupling of state with decision-making. | 14:33 |
jaypipes | bauzas: And I'd much prefer to deal with things like num_instances > 0 outside of the filter scheduler. | 14:34 |
*** gmann_ has quit IRC | 14:34 | |
bauzas | jaypipes: the real problem is that since we really only supported FilterScheduler (ChanceScheduler being only for tests or crazy operators), we really didn't had a clear interface | 14:34 |
bauzas | so we built a pile of dependencies between the driver, the host manager and the filters | 14:35 |
jaypipes | bauzas: that and the unit tests are a pile of spaghetti that test way too much surface area and therefore if you change any little thing, a million tests crash and burn. | 14:35 |
bauzas | the code itself isn't very large, that's just the fact that we're poorly defining our internal interfaces | 14:35 |
jaypipes | that, and there's no reason for the WeighedHost class to begin with. | 14:35 |
bauzas | I just feel we need to be pragmatic for Pike and do the nice stuff later | 14:36 |
jaypipes | but whatever, I'm back off the cliff edge and making slow progress. | 14:36 |
jaypipes | bauzas: not sure what you mean by "nice stuff"./ | 14:36 |
bauzas | honestly, our internal interfaces are... internal, so I don't care with us changing those a couple of times | 14:36 |
*** acormier_ has joined #openstack-nova | 14:37 | |
bauzas | jaypipes: I'm talking of getting results first, and then clean up our model later | 14:37 |
*** gouthamr has joined #openstack-nova | 14:37 | |
*** marst has quit IRC | 14:37 | |
jaypipes | bauzas: yeah... that's what has caused all of the issues in the first place :) shoot first, ask questions later. | 14:37 |
*** acormier_ has quit IRC | 14:37 | |
bauzas | I know | 14:38 |
*** acormier_ has joined #openstack-nova | 14:38 | |
bauzas | do you remember I started changing those interfaces in 2014 ? | 14:38 |
bauzas | that's just a funny story | 14:38 |
*** slaweq_ has joined #openstack-nova | 14:40 | |
*** acormier has quit IRC | 14:40 | |
*** itlinux_ has quit IRC | 14:42 | |
*** slaweq_ has quit IRC | 14:45 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | 14:46 |
*** lucasxu has joined #openstack-nova | 14:46 | |
jaypipes | bauzas: I know you know. And I know you know that I know you know. | 14:47 |
*** marst has joined #openstack-nova | 14:47 | |
bauzas | jaypipes: wake me before you know-know | 14:48 |
bauzas | aaaaaah | 14:48 |
bauzas | wake me *up before you know-know | 14:48 |
* bauzas totally crashed his joke | 14:48 | |
*** coreywright has quit IRC | 14:48 | |
cdent | good effort though | 14:48 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove unnecessary function https://review.openstack.org/483433 | 14:49 |
jaypipes | bauzas: hehe | 14:51 |
*** tylerderosagrund has quit IRC | 14:52 | |
*** tylerderosagrund has joined #openstack-nova | 14:52 | |
mriedem | so we're making wham! jokes now? | 14:52 |
dansmith | oh jeez, you'll get mriedem all worked up | 14:53 |
mriedem | well look who it is | 14:53 |
mriedem | someone has a 'wham!' keyword listener | 14:53 |
*** felipemonteiro has joined #openstack-nova | 14:53 | |
dansmith | heh | 14:53 |
bauzas | :) | 14:54 |
efried | mordred mriedem Now a good time to talk about ksa/sta/os-service-types releases in support of use-service-catalog-for-endpoints ? | 14:55 |
*** felipemonteiro_ has joined #openstack-nova | 14:55 | |
*** andreas_s has quit IRC | 14:55 | |
mriedem | i need some time | 14:56 |
edleafe | jaypipes: I've bookmarked that quote | 14:56 |
jaypipes | edleafe: ha! it was paraphrasing White Goodman from "Dodgeball: A True Underdog Story" (http://www.imdb.com/title/tt0364725/quotes) | 14:58 |
jaypipes | "I know you. You know you. And I know you know that I know you." | 14:58 |
edleafe | oh, not that quote. http://p.anticdent.org/38I | 14:58 |
jaypipes | edleafe: ooohhhhh, that one. | 14:59 |
*** felipemonteiro has quit IRC | 14:59 | |
edleafe | jaypipes: :) | 14:59 |
*** efried is now known as efried_bbiab | 15:00 | |
*** Swami has joined #openstack-nova | 15:01 | |
*** coreywright has joined #openstack-nova | 15:01 | |
mriedem | stvnoyes: i've gone through the compute manager changes on https://review.openstack.org/#/c/463987/ - there is a definite bug in the way that _detach_volume is called | 15:02 |
mriedem | stvnoyes: beyond that, i'm concerned that since we don't always call rollback_live_migration_at_destination, we might not cleanup properly | 15:03 |
*** jmlowe has quit IRC | 15:03 | |
mordred | efried_bbiab, mriedem: ping me when you're ready | 15:04 |
*** lucasxu has quit IRC | 15:09 | |
*** armax has joined #openstack-nova | 15:11 | |
*** yingjun has joined #openstack-nova | 15:20 | |
*** Oku_OS is now known as Oku_OS-away | 15:20 | |
*** acormier has joined #openstack-nova | 15:22 | |
*** acormier has quit IRC | 15:22 | |
*** acormier has joined #openstack-nova | 15:23 | |
*** gcb has quit IRC | 15:23 | |
edleafe | jaypipes: let me check my understanding of compute-land with you | 15:25 |
edleafe | jaypipes: There is a compute service. It has a single resource tracker. That RT can have 1 or more compute nodes | 15:25 |
edleafe | jaypipes: Normally it's one (VMs), but for Ironic it can be (and usually is) >1 | 15:25 |
edleafe | jaypipes: is that correct? | 15:25 |
jaypipes | yup | 15:25 |
edleafe | jaypipes: ok thx | 15:25 |
*** acormier_ has quit IRC | 15:25 | |
dansmith | correct in the technical sense | 15:25 |
jaypipes | edleafe: always a single resource tracker. that resource tracker tracks >1 compute node objects in case of ironic. | 15:26 |
dansmith | not correct in the moral should-this-be-done sense | 15:26 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | 15:26 |
edleafe | dansmith: my soul is already unclean | 15:26 |
*** isantosp has joined #openstack-nova | 15:26 | |
bauzas | edleafe: because jaypipes fixed that :) | 15:26 |
bauzas | edleafe: we previously had 1 RT per compute "node" | 15:27 |
bauzas | <3 jaypipes | 15:27 |
*** rcernin has quit IRC | 15:27 | |
edleafe | bauzas: get a room, you two | 15:28 |
jaypipes | lol | 15:28 |
*** damien_r has quit IRC | 15:28 | |
isantosp | Hi, I have an issue on nova newton, im trying to set ipv6 taking it from the port creation in neutron newton, apparently neutron is doing his job perfectly, the problem is when nova try to call port_crete_minimal, I have the following: ``` | 15:29 |
bauzas | edleafe: you mean #openstack-loves-jaypipes IRC room ? :p | 15:29 |
isantosp | subnet_id_v4 = host_subnets['host']['available_random_subnet_v4'] | 15:29 |
isantosp | port_req_body['port']['fixed_ips'] = [ | 15:29 |
isantosp | {'subnet_id': str(subnet_id_v4)}] | 15:29 |
isantosp | yes | 15:29 |
edleafe | bauzas: there are several such rooms, I imagine | 15:29 |
isantosp | In the creation of the instance, i see this error: {"message": "'subnets'", "code": 500} | 15:30 |
dansmith | melwitt: I think you should roll on with the update to that patch. I'm to the tests, and my will to live is waning | 15:31 |
*** udesale has quit IRC | 15:31 | |
isantosp | and this one in the logs | 15:31 |
isantosp | File "/usr/lib/python2.7/site-packages/nova/network/neutronv2/api.py", line 392, in _create_port_minimal | 15:31 |
isantosp | host_subnets = port_client.show_host(instance.host) | 15:31 |
isantosp | KeyError: 'subnets' | 15:31 |
*** foutatoro has quit IRC | 15:31 | |
isantosp | any ideas? the line 392 that is pointed there, it has nothing to solve | 15:32 |
*** acormier_ has joined #openstack-nova | 15:35 | |
openstackgerrit | Alex Szarka proposed openstack/nova master: Transform the transformed notifications functional tests https://review.openstack.org/483448 | 15:36 |
*** jwcroppe has quit IRC | 15:36 | |
*** pcaruana has quit IRC | 15:38 | |
*** efried_bbiab is now known as efried | 15:38 | |
*** MVenesio has quit IRC | 15:38 | |
*** MVenesio has joined #openstack-nova | 15:39 | |
*** acormier has quit IRC | 15:39 | |
sean-k-mooney | jangutter: well what specifically is the gap. you can use https://github.com/Juniper/contrail-nova-vif-driver/blob/master/vif_plug_vrouter/vrouter.py as an example of an external plugin | 15:40 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 15:40 |
*** slaweq_ has joined #openstack-nova | 15:41 | |
sean-k-mooney | jangutter: for the sriov type you should call your plugins plug method with a VIFHostDevice and for the virtio forworder case you should use VIFVHostUser with a costom port profile if you need to pass vendor specific info. | 15:43 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | 15:43 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | 15:44 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926 | 15:45 |
*** thorst has quit IRC | 15:45 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926 | 15:45 |
*** thorst has joined #openstack-nova | 15:46 | |
*** slaweq_ has quit IRC | 15:46 | |
openstackgerrit | Alex Szarka proposed openstack/nova master: Transform the transformed notifications functional tests https://review.openstack.org/483448 | 15:48 |
sean-k-mooney | jangutter: was your question more how do i tell nova to allocate the vf and call the plugin? | 15:48 |
sean-k-mooney | jangutter: without a review too look at its a little hard to advise what do next | 15:49 |
*** lucasxu has joined #openstack-nova | 15:49 | |
*** thorst has quit IRC | 15:50 | |
openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | 15:52 |
openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance.resize.error notifications https://review.openstack.org/417882 | 15:52 |
mriedem | jaypipes: dansmith: can one of you put the priority reviews docs patch through https://review.openstack.org/#/c/470420/ | 15:53 |
dansmith | sure | 15:53 |
jangutter | sean-k-mooney: your wish is my command, just as we speak the clearance came through. | 15:53 |
*** karimb_ has quit IRC | 15:54 | |
jangutter | So my next newbie question to the room is: should I throw away the old reviews and create new ones, or replace them? what's the status quo? | 15:54 |
mriedem | dansmith: https://review.openstack.org/#/c/445142/ also needs a rebase | 15:55 |
*** hshiina has joined #openstack-nova | 15:56 | |
dansmith | mriedem: ac | 15:56 |
dansmith | k | 15:56 |
sean-k-mooney | jangutter: cool. am it really up to you. you can keep the change ids if the new code is a nautal evolution of the previous patches or abandon the old patchs and leave a link to the new patchset if its substially different | 15:56 |
jaypipes | jangutter: just Abandon the old patches. | 15:57 |
jaypipes | jangutter: patches are cheap :) | 15:57 |
jangutter | *sniff* they're going to data heaven now. | 15:58 |
*** Apoorva has joined #openstack-nova | 15:58 | |
*** acormier_ has quit IRC | 15:58 | |
sean-k-mooney | jangutter: openstack never delete the review so they will live forever in bit rot land | 15:59 |
*** acormier has joined #openstack-nova | 15:59 | |
jangutter | *sniff* they're going to data purgatory now. | 15:59 |
openstackgerrit | Merged openstack/nova-specs master: Document Pike release review priorities https://review.openstack.org/470420 | 16:01 |
*** mriedem has left #openstack-nova | 16:01 | |
*** mriedem has joined #openstack-nova | 16:01 | |
sean-k-mooney | jangutter: jaypipes apparently this is the oldest review still visable https://review.openstack.org/#/c/131 jay you were a core on keystone once? | 16:01 |
*** dtantsur is now known as dtantsur|afk | 16:02 | |
*** jwcroppe has joined #openstack-nova | 16:02 | |
breton | lol. Even Dolph was not a core. | 16:03 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Add datapath type information to OVS vif objects https://review.openstack.org/474892 | 16:03 |
*** acormier has quit IRC | 16:03 | |
jaypipes | sean-k-mooney: lol | 16:03 |
*** kristia__ has joined #openstack-nova | 16:04 | |
*** lucasxu has quit IRC | 16:04 | |
*** kristian__ has quit IRC | 16:07 | |
sean-k-mooney | jangutter: am when you push the new patches add me to them and ill take a look at what you have end to end | 16:07 |
*** gyee has joined #openstack-nova | 16:09 | |
*** jwcroppe_ has joined #openstack-nova | 16:09 | |
*** sridharg has quit IRC | 16:11 | |
jaypipes | jangutter: yes, purgatory is more appropriate for the patches that I personally abandon (there have been many, many of them) | 16:12 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483 | 16:13 |
*** jwcroppe has quit IRC | 16:13 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.52 - List/Show all server migration types https://review.openstack.org/430839 | 16:15 |
openstackgerrit | Jan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement https://review.openstack.org/483459 | 16:16 |
*** jwcroppe_ has quit IRC | 16:16 | |
jangutter | Warning: these patches have been ripped from the Netronomicon. | 16:17 |
openstackgerrit | Alex Szarka proposed openstack/nova master: Refactor create_delete_server_with_instance_update https://review.openstack.org/466296 | 16:17 |
*** saneax has quit IRC | 16:18 | |
*** tesseract has quit IRC | 16:19 | |
*** rajathagasthya has joined #openstack-nova | 16:19 | |
*** jamielennox has quit IRC | 16:19 | |
*** slaweq has quit IRC | 16:20 | |
jangutter | jaypipes, sean-k-mooney: thanks very much for the infinite patience. The ML2/OS-VIF external plugin's on github, and I'll upload the neutron bits in an hour or so. | 16:20 |
*** lucasxu has joined #openstack-nova | 16:21 | |
*** lucasagomes is now known as lucas-afk | 16:22 | |
*** eharney has quit IRC | 16:23 | |
jaypipes | jangutter: no problem at all. | 16:23 |
*** eharney has joined #openstack-nova | 16:26 | |
*** jwcroppe has joined #openstack-nova | 16:27 | |
*** gbarros has quit IRC | 16:27 | |
*** kfarr has joined #openstack-nova | 16:30 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.52 - Enable cold migration with target host https://review.openstack.org/406707 | 16:33 |
*** takashin has left #openstack-nova | 16:34 | |
*** tbachman has joined #openstack-nova | 16:34 | |
*** jwcroppe_ has joined #openstack-nova | 16:34 | |
mriedem | bauzas: ok email to the ML sent about bps close to done | 16:35 |
openstackgerrit | zhang zhenzhong proposed openstack/nova master: fix resource-provider regist failed in db while placement endpoint created after nova-compute start https://review.openstack.org/483460 | 16:36 |
*** jwcroppe has quit IRC | 16:37 | |
openstackgerrit | zhang zhenzhong proposed openstack/nova master: fix resource-provider regist failed in db while placement endpoint created after nova-compute start https://review.openstack.org/483460 | 16:38 |
*** hshiina has quit IRC | 16:38 | |
*** gouthamr has quit IRC | 16:41 | |
*** zzzeek_ has quit IRC | 16:41 | |
*** dtp has joined #openstack-nova | 16:41 | |
*** gouthamr has joined #openstack-nova | 16:42 | |
*** lpetrut_ has quit IRC | 16:42 | |
*** slaweq has joined #openstack-nova | 16:42 | |
*** zzzeek has joined #openstack-nova | 16:43 | |
*** itlinux has joined #openstack-nova | 16:45 | |
mriedem | jaypipes: https://review.openstack.org/#/c/482383/ is the current focus right now right? | 16:45 |
mriedem | it's not https://review.openstack.org/#/c/482381/ | 16:45 |
mriedem | the dep tree is confusing me | 16:46 |
*** thorst has joined #openstack-nova | 16:46 | |
jaypipes | mriedem: I needed to go in a different direction on those. I will abandon both. | 16:47 |
mriedem | ok | 16:47 |
mriedem | well claim_resources() is +W so yay | 16:47 |
jaypipes | yeah, that's fine. | 16:47 |
jaypipes | self contained. | 16:47 |
jaypipes | should have new series pushed today. | 16:47 |
mriedem | ack | 16:47 |
*** slaweq has quit IRC | 16:47 | |
*** sree has quit IRC | 16:50 | |
*** sree has joined #openstack-nova | 16:51 | |
*** felipemonteiro_ has quit IRC | 16:51 | |
*** sree has quit IRC | 16:55 | |
*** Apoorva_ has joined #openstack-nova | 16:56 | |
*** dtp has quit IRC | 16:57 | |
* cdent sends jaypipes some beer, pizza, coffee, a pillow, two bottle of jack, some crunchie bars and spare pug | 16:59 | |
cdent | use as you see fit | 16:59 |
*** ralonsoh has quit IRC | 16:59 | |
*** Apoorva has quit IRC | 17:00 | |
jaypipes | cdent: you can keep the spare pug. just double the jack. | 17:00 |
*** fragatina has joined #openstack-nova | 17:00 | |
cdent | noted | 17:00 |
cdent | I’ve kinda sorta always wanted a pug of my very own | 17:00 |
openstackgerrit | zhang zhenzhong proposed openstack/nova master: fix rp regist failed while placement endpoint created after nova-compute start https://review.openstack.org/483460 | 17:01 |
jaypipes | cdent: they are great, in moderation. | 17:03 |
jaypipes | cdent: three is my limit. | 17:03 |
*** damien_r has joined #openstack-nova | 17:03 | |
openstackgerrit | zhang zhenzhong proposed openstack/nova master: fix rp registration failed while placement endpoint created after compute start https://review.openstack.org/483460 | 17:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Use oslo.polcy DocumentedRuleDefault https://review.openstack.org/472634 | 17:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Update policy descriptions for base. https://review.openstack.org/472622 | 17:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Consistent policies https://review.openstack.org/479774 | 17:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove 'create_rule_default' https://review.openstack.org/479773 | 17:06 |
mriedem | easy +W here https://review.openstack.org/#/c/479773/ | 17:07 |
jaypipes | 143gg | 17:08 |
jaypipes | guh | 17:08 |
*** yamahata has joined #openstack-nova | 17:08 | |
*** fragatina has quit IRC | 17:11 | |
*** sambetts is now known as sambetts|afk | 17:14 | |
*** tylerderosagrund has quit IRC | 17:15 | |
*** tylerderosagrund has joined #openstack-nova | 17:16 | |
*** jwcroppe has joined #openstack-nova | 17:20 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Update policy descriptions for base. https://review.openstack.org/472622 | 17:20 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Consistent policies https://review.openstack.org/479774 | 17:20 |
*** damien_r has quit IRC | 17:21 | |
*** jwcroppe_ has quit IRC | 17:22 | |
*** liusheng has quit IRC | 17:25 | |
cdent | mriedem: if you’re in a policy kind of way, does this make sense: https://review.openstack.org/#/c/481443/ | 17:25 |
*** liusheng has joined #openstack-nova | 17:26 | |
*** harlowja has quit IRC | 17:27 | |
*** kristia__ has quit IRC | 17:28 | |
*** kristian__ has joined #openstack-nova | 17:28 | |
*** yingjun has quit IRC | 17:29 | |
*** sshwarts has quit IRC | 17:30 | |
*** kristian__ has quit IRC | 17:32 | |
*** slaweq has joined #openstack-nova | 17:35 | |
*** slaweq has quit IRC | 17:35 | |
*** slaweq has joined #openstack-nova | 17:36 | |
melwitt | internet is on the fritz again. comcast ... | 17:37 |
melwitt | dansmith: roger that. will update | 17:37 |
mriedem | cdent: oh boy | 17:38 |
mriedem | so, it usually takes me about 3 days to figure out where the rules are defined | 17:39 |
melwitt | dansmith, mriedem I have been wondering about the behavior change for resize confirm/revert. currently, it's possible to fail confirm/revert with OverQuota. during earlier discussions on the quota patch review (the monolith) we were thinking we should change the behavior and not block confirm/revert and instead limit max pending resizes | 17:39 |
melwitt | should we keep with that change or should we maintain the current behavior? | 17:39 |
cdent | this is part of why I’m asking because me<->policies, not friends | 17:39 |
mriedem | melwitt: i'm generally not in favor of behavior changes slipping in with major refactors | 17:40 |
mriedem | because it adds all the extra complication | 17:40 |
mriedem | but i don't know why the original decision was made | 17:40 |
mriedem | you said that was from johnthetubaguy | 17:40 |
mriedem | ? | 17:40 |
melwitt | I thought it was johnthetubaguy who suggested it but I might be remembering that wrong. it was months ago | 17:41 |
melwitt | yeah, I feel like I'm not too into the idea of changing the behavior either. I was thinking about it and I don't think you can get stuck in a limbo state with a pending resize | 17:41 |
mriedem | cdent: so i think the answer is it comes from somewhere in the bowels of keystone | 17:42 |
melwitt | if you get blocked on confirm, you can revert. if you get blocked on revert, you confirm. unless I'm missing something | 17:42 |
mriedem | so you'd get blocked on confirm if you are resizing up, yes? | 17:42 |
*** tbachman has quit IRC | 17:42 | |
melwitt | yes | 17:43 |
mriedem | how do you get blocked on revert? resizing down? | 17:43 |
mriedem | so the revert goes up | 17:43 |
melwitt | yes | 17:43 |
melwitt | resize down generally isn't a thing but I think it's allowed for BFV | 17:43 |
mriedem | since we don't have reservations for resize now, | 17:43 |
*** slaweq_ has joined #openstack-nova | 17:43 | |
mriedem | well, | 17:43 |
*** feefifofum has joined #openstack-nova | 17:43 | |
mriedem | nvm | 17:43 |
mriedem | i was thinking somehow reservations in the old way helped this here | 17:43 |
mriedem | but that would only help when you're resizing up | 17:44 |
*** gjayavelu has joined #openstack-nova | 17:44 | |
mriedem | well either way i guess, | 17:44 |
mriedem | but yeah if this was a way you could fail over quota before, i don't know why we wouldn't just continue to count quota on confirm/revert | 17:44 |
mriedem | and fail if the current state of the world has changed and you're screwd | 17:44 |
mriedem | *screwed even | 17:44 |
openstackgerrit | Merged openstack/nova master: api-ref: Add missing parameters in limits.inc https://review.openstack.org/475640 | 17:45 |
feefifofum | hi, i'm working on upgrading from liberty to ocata and noticed a difference in how hypervisor memory usage is reported | 17:45 |
feefifofum | in liberty, memory_mb - memory_mb_used = free_ram_mb | 17:46 |
feefifofum | however in ocata, there is a different quantity now | 17:46 |
melwitt | yeah | 17:46 |
feefifofum | memory_mb - mb_used - x = free_ram_mb | 17:47 |
feefifofum | i don't know what x is though | 17:47 |
mriedem | feefifofum: you know that skipping from L to O isn't supported upstream right? and you'd need to check the release notes for M, N and O first | 17:47 |
*** slaweq_ has quit IRC | 17:48 | |
mriedem | lbragstad: where is the default policy rule defined in keystone again? | 17:48 |
mriedem | i can never find it | 17:48 |
mriedem | it's not this https://github.com/openstack/keystone/blob/master/etc/policy.v3cloudsample.json#L11 | 17:48 |
*** fragatina has joined #openstack-nova | 17:48 | |
feefifofum | mriedem: yes i'm aware of the release notes | 17:50 |
sean-k-mooney | jangutter: i think this is legacy code that you dont need https://github.com/Netronome/agilio-ovs-openstack-plugin/blob/90c38378b772c8f82d5bc1752df60ec5055dca23/vif_plug_agilio_ovs/objects/vif.py#L24-L30 also multiple inheritence for multiple oslo_versioned objects will likely not work out well for you | 17:50 |
mriedem | feefifofum: are you looking in code? | 17:50 |
mriedem | it could be an overhead value | 17:50 |
sean-k-mooney | jangutter: on the plus side https://github.com/Netronome/agilio-ovs-openstack-plugin/search?utf8=%E2%9C%93&q=VIFAgilioOpenVSwitch&type= its not used anyware in the code | 17:50 |
mriedem | calculated from the virt driver | 17:50 |
*** jwcroppe_ has joined #openstack-nova | 17:51 | |
mriedem | https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L192 | 17:51 |
*** liangy has quit IRC | 17:51 | |
feefifofum | hmmm, this looks interesting. i'll take a closer look | 17:51 |
feefifofum | thanks mriedem | 17:51 |
mriedem | https://github.com/openstack/nova/blob/master/nova/compute/claims.py#L105 | 17:51 |
*** jwcroppe has quit IRC | 17:52 | |
*** krtaylor has quit IRC | 17:55 | |
*** feefifofum has quit IRC | 17:55 | |
lbragstad | mriedem: we removed it | 17:57 |
lbragstad | mriedem: all of our policy bits are here - https://github.com/openstack/keystone/tree/b3fc06c9ef6a0a3d317f414962bab3d309c2e6c0/keystone/common/policies | 17:58 |
lbragstad | the basic rules are in base.py - https://github.com/openstack/keystone/blob/b3fc06c9ef6a0a3d317f414962bab3d309c2e6c0/keystone/common/policies/base.py#L15-L31 | 17:58 |
*** Swami has quit IRC | 17:59 | |
lbragstad | mriedem: edmondsw has proposed the removal of the default rule - https://review.openstack.org/#/c/482164/ | 17:59 |
*** rajathag_ has joined #openstack-nova | 18:00 | |
*** rajathagasthya has quit IRC | 18:01 | |
*** mvk has quit IRC | 18:01 | |
*** tbachman has joined #openstack-nova | 18:01 | |
*** felipemonteiro has joined #openstack-nova | 18:03 | |
*** pchavva has quit IRC | 18:03 | |
*** eharney has quit IRC | 18:03 | |
*** felipemonteiro_ has joined #openstack-nova | 18:04 | |
*** FL1SK has quit IRC | 18:04 | |
*** slaweq has quit IRC | 18:06 | |
*** roeyc has joined #openstack-nova | 18:06 | |
*** Apoorva_ has quit IRC | 18:06 | |
*** Apoorva has joined #openstack-nova | 18:07 | |
mriedem | hmm | 18:07 |
mriedem | https://github.com/openstack/keystone/blob/b3fc06c9ef6a0a3d317f414962bab3d309c2e6c0/keystone/common/policies/base.py#L61 ok | 18:07 |
mriedem | well that's what i was looking for anyway | 18:07 |
mriedem | cdent: ^ | 18:08 |
*** felipemonteiro has quit IRC | 18:08 | |
lbragstad | mriedem: yeah - we're going to be removing that since every operation will be required to have a default | 18:08 |
cdent | what does it mean? | 18:08 |
mriedem | lbragstad: so does that mean if nova didn't defined a default rule, we wouldn't have a default at all then? | 18:09 |
mriedem | if keystone didn't define it? | 18:09 |
mriedem | or something else | 18:09 |
mriedem | https://review.openstack.org/#/c/481443/4/nova/policies/base.py | 18:09 |
lbragstad | that default is specific to keystone APIs | 18:09 |
mriedem | ok that's what i was wondering | 18:09 |
lbragstad | so if you made a request to keystone that we didn't have a policy entry for - we would normally apply that default | 18:09 |
mriedem | and these are the nova-api specific defaults https://review.openstack.org/#/c/481443/4/nova/policies/base.py | 18:09 |
lbragstad | but since each policy is formally moved into code and documented - a default of defaults doesn't really make sense | 18:09 |
*** efoley has quit IRC | 18:10 | |
lbragstad | aha - sure | 18:10 |
lbragstad | yeah - removing the keystone-specific defaults shouldn't impact that for nova | 18:10 |
*** roeyc has quit IRC | 18:10 | |
mriedem | nova's default is different anyway | 18:10 |
lbragstad | right - and that makes sense | 18:11 |
lbragstad | i wouldn't expect each service's default rule to be the same | 18:11 |
cdent | (I think the issue in the review is more that policy file generation was leaving the default out? https://review.openstack.org/#/c/481443/ and if you try to use that file elsewhere, things go awry?) | 18:12 |
mriedem | cdent: i left a question in there | 18:12 |
cdent | thanks | 18:12 |
mriedem | compute:get_all is an old legacy v2 API rule i think | 18:12 |
mriedem | seems like a horizon bug actually | 18:13 |
lbragstad | speaking of policy - i was thinking about organizing a session in Denver focused on next steps (much like what we did in atlanta) | 18:13 |
lbragstad | is anyone here interested in that? | 18:13 |
cdent | could very welll be | 18:13 |
mriedem | i'm not interested in thinking about denver at all right now | 18:14 |
lbragstad | :) that's fair | 18:15 |
robcresswell | Ah, we still have references to the old style policy rules | 18:15 |
robcresswell | I can fix that. | 18:15 |
*** kristian__ has joined #openstack-nova | 18:15 | |
mriedem | robcresswell: someone already did https://github.com/openstack/horizon/blob/master/openstack_dashboard/conf/nova_policy.json | 18:16 |
mriedem | compute:get_all isn't in there | 18:16 |
*** slaweq has joined #openstack-nova | 18:16 | |
mriedem | unless it's hard-coded | 18:16 |
robcresswell | mriedem: I co-authored on that. We've left a check on the rule in our admin > instances panel | 18:16 |
robcresswell | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/instances/panel.py#L29 | 18:17 |
robcresswell | Is there a relevant bug open in Nova I can link to? | 18:17 |
mriedem | https://bugs.launchpad.net/horizon/+bug/1703066 | 18:17 |
openstack | Launchpad bug 1703066 in OpenStack Compute (nova) " Add "default" rule when generate policy.yaml.sample" [Undecided,Incomplete] - Assigned to KaiLi (damonl1) | 18:17 |
mriedem | just added horizon to it | 18:17 |
robcresswell | Thanks | 18:17 |
*** slaweq has quit IRC | 18:17 | |
mriedem | np | 18:17 |
mriedem | cdent: -1 on the nova change then | 18:17 |
cdent | thanks to all three of you | 18:18 |
cdent | yeah, totes | 18:18 |
*** kristian__ has quit IRC | 18:18 | |
*** lyan has joined #openstack-nova | 18:20 | |
robcresswell | Whats the equivalent of "get_all"? "os_compute_api:servers:index"? | 18:21 |
mriedem | yeah | 18:21 |
mriedem | well, | 18:21 |
mriedem | depends, do you need details? | 18:21 |
mriedem | because then it would be os_compute_api:servers:detail | 18:21 |
mriedem | "os_compute_api:servers:detail" | 18:21 |
mriedem | blast | 18:21 |
robcresswell | That particular check is just saying "can I list all instances" I believe. | 18:22 |
robcresswell | on the horizon side, I mean | 18:22 |
mriedem | i'll check some old nova code | 18:22 |
*** rajathag_ has quit IRC | 18:23 | |
robcresswell | It looks like that last patch replaced get_all with "os_compute_api:servers:index:get_all_tenants" in a couple of places | 18:23 |
mriedem | that would be wrong | 18:23 |
mriedem | the old version of that was compute:get_all_tenants | 18:23 |
*** acormier has joined #openstack-nova | 18:23 | |
robcresswell | gotcha | 18:23 |
robcresswell | thanks | 18:23 |
mriedem | the all tenants stuff is admin only by default | 18:23 |
mriedem | since tenant A shouldn't be able to list instances from tenant B | 18:24 |
mriedem | compute:get_all was used for both index and detail in the v2 API | 18:24 |
mriedem | so you can use the index or detail one, either is fine | 18:24 |
mriedem | well, i mean it really depends on what you're going to be doing - if you're going to be getting servers with details to show details, then you want the details one | 18:25 |
robcresswell | Is that the same as viewing the details of a specific server? | 18:25 |
mriedem | nope | 18:25 |
mriedem | :) | 18:25 |
robcresswell | Whats the policy for that? | 18:26 |
* robcresswell looks | 18:26 | |
mriedem | i think that's "os_compute_api:servers:show" | 18:26 |
robcresswell | Ah! Yes | 18:26 |
robcresswell | Very good | 18:26 |
robcresswell | mriedem: https://review.openstack.org/#/c/483501/ | 18:28 |
openstackgerrit | zhang zhenzhong proposed openstack/nova master: fix rp registration failed while placement endpoint created after compute start https://review.openstack.org/483460 | 18:29 |
dansmith | melwitt: agree that less behavioral change is better | 18:29 |
melwitt | cool. I think we all agree, so I'll nix the pending resizes stuff | 18:30 |
robcresswell | mriedem: Right, I'll get that merged ASAP and backport it. Thanks for the help. | 18:30 |
melwitt | and put back the current behavior | 18:30 |
mriedem | +1 | 18:30 |
*** krtaylor has joined #openstack-nova | 18:31 | |
mriedem | melwitt: cool, that means you can also drop the 2nd change in the series too right? | 18:31 |
dansmith | I think so | 18:31 |
mriedem | f yes | 18:31 |
mriedem | that's like 15% better | 18:31 |
dansmith | hehe | 18:31 |
melwitt | /fistpump | 18:32 |
dansmith | if we round to 20% less (code to merge) we could all take tomorrow off | 18:32 |
*** Swami has joined #openstack-nova | 18:32 | |
melwitt | haha | 18:32 |
*** mvk has joined #openstack-nova | 18:35 | |
*** rajathagasthya has joined #openstack-nova | 18:35 | |
*** tbachman_ has joined #openstack-nova | 18:35 | |
mriedem | i have to work on my pbc tomorrow | 18:36 |
mriedem | so no dice | 18:36 |
*** shaohe_feng has quit IRC | 18:36 | |
*** jamielennox has joined #openstack-nova | 18:37 | |
*** shaohe_feng has joined #openstack-nova | 18:37 | |
*** tbachman has quit IRC | 18:38 | |
*** tbachman_ is now known as tbachman | 18:38 | |
*** pcaruana has joined #openstack-nova | 18:38 | |
dansmith | mriedem: oh horrors of horror | 18:39 |
dansmith | er, horror of horrors? | 18:39 |
dansmith | whatever. horror-ible. | 18:39 |
mriedem | ha | 18:39 |
mriedem | don't make me get out ralph wiggum again | 18:39 |
dansmith | hehe | 18:39 |
melwitt | what's pbc | 18:40 |
mriedem | personal business commitments | 18:40 |
mriedem | goals | 18:41 |
mriedem | like, "i'm going to synergize for cloud enterprise adoption 2.0" | 18:41 |
*** kristian__ has joined #openstack-nova | 18:41 | |
melwitt | hah | 18:42 |
*** lyan has quit IRC | 18:43 | |
edleafe | mriedem: don't forget the cover page for the TPS report | 18:44 |
edleafe | mriedem: you did get the memo, right? | 18:44 |
*** thorst has quit IRC | 18:44 | |
jaypipes | mriedem: don't forget to unprison your think rhino. | 18:44 |
mriedem | i did put a cover page on my expense claim and throw that in the mail today | 18:44 |
openstackgerrit | zhang zhenzhong proposed openstack/nova master: fix rp registration failed while placement endpoint created after compute start https://review.openstack.org/483460 | 18:45 |
* cdent visualizes his think rhino, free at last | 18:46 | |
melwitt | lol think rhino? unprison? | 18:46 |
cdent | jaypipes: you may have some opinions on that ^^ | 18:46 |
jaypipes | melwitt: https://twitter.com/e_monty/status/852540106317627392 | 18:50 |
melwitt | lol | 18:51 |
edleafe | jaypipes: ah, that totally clears everything up | 18:51 |
jaypipes | hehe | 18:51 |
openstackgerrit | zhang zhenzhong proposed openstack/nova master: remove un-necessary update() in _init_compute_node of rt https://review.openstack.org/483506 | 18:53 |
*** harlowja has joined #openstack-nova | 18:54 | |
* melwitt opens the tome of review comments to address | 18:56 | |
*** cdent has quit IRC | 19:00 | |
dansmith | mriedem: this event rebase is taking a long time because of your silly volume extend nonsense, but I'm about done | 19:04 |
openstackgerrit | Dan Smith proposed openstack/nova master: Fix and optimize external_events for multiple cells https://review.openstack.org/445142 | 19:04 |
*** nicolasbock has quit IRC | 19:04 | |
mriedem | boohoo | 19:07 |
melwitt | hehehe | 19:07 |
dansmith | mriedem: you guys are only on cloud 2.0? | 19:08 |
dansmith | I think we're on 4.0 now | 19:09 |
*** gbarros has joined #openstack-nova | 19:10 | |
*** kristian__ has quit IRC | 19:14 | |
*** kristian__ has joined #openstack-nova | 19:15 | |
*** kfarr has quit IRC | 19:17 | |
*** slaweq has joined #openstack-nova | 19:18 | |
*** sbezverk has quit IRC | 19:21 | |
*** sbezverk has joined #openstack-nova | 19:22 | |
*** slaweq has quit IRC | 19:23 | |
*** acormier_ has joined #openstack-nova | 19:24 | |
*** acormier_ has joined #openstack-nova | 19:24 | |
melwitt | comcast is here to replace a line outside so I might drop off while they're working | 19:25 |
*** acormier has quit IRC | 19:26 | |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Microversion 2.50 - fix quota class sets resource usage https://review.openstack.org/483060 | 19:27 |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Add support for the 2.51 microversion https://review.openstack.org/483149 | 19:27 |
*** kristian__ has quit IRC | 19:32 | |
mriedem | dansmith: melwitt: so we talked about some testing we can do against the quotas change, | 19:35 |
mriedem | novaclient functional runs in serial with a single tenant | 19:35 |
mriedem | normal tempest jobs are a unique tenant per test so if we're leaking quotas we won't find it in the normal runs | 19:35 |
mriedem | so i was thinking about doing something in novaclient as a DNM change and point it at the quotas patch | 19:36 |
mriedem | like run something 20 times | 19:36 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/483337 | 19:36 |
mriedem | thoughts on what we'd want to cover there? i think normal server create/delete is already covered by the existing novaclient functional tests | 19:36 |
mriedem | so was thinking about adding a novaclient functional test for resize that we could then run like 20 times in a loop | 19:36 |
mriedem | *we talked about this in the nova meeting i mean | 19:37 |
mriedem | thoughts on what to test there? like resize up/confirm, resize down/confirm * 20, and resize up/revert, resize down/revert * 20 | 19:38 |
*** slaweq has joined #openstack-nova | 19:38 | |
*** kristian__ has joined #openstack-nova | 19:39 | |
*** tbachman has quit IRC | 19:39 | |
*** tbachman has joined #openstack-nova | 19:39 | |
melwitt | soft delete/restore | 19:41 |
mriedem | ok | 19:41 |
melwitt | multi create | 19:41 |
mriedem | hmm, actually, i suppose this is why tempest doesn't test soft delete, | 19:42 |
mriedem | is that the soft delete behavior is based on config... | 19:42 |
mriedem | and by default it doesn't soft delete | 19:42 |
melwitt | yeah | 19:42 |
mriedem | so would have to test that one manually | 19:42 |
*** kristian__ has quit IRC | 19:43 | |
*** kristian__ has joined #openstack-nova | 19:45 | |
*** slaweq has quit IRC | 19:49 | |
*** slaweq has joined #openstack-nova | 19:50 | |
*** lucasxu has quit IRC | 19:50 | |
*** pcaruana has quit IRC | 19:52 | |
*** Apoorva_ has joined #openstack-nova | 19:54 | |
*** Apoorva has quit IRC | 19:57 | |
*** pchavva has joined #openstack-nova | 19:57 | |
openstackgerrit | Jackie Truong proposed openstack/nova master: [WIP] Implement certificate_utils https://review.openstack.org/479949 | 19:58 |
*** tbachman_ has joined #openstack-nova | 20:02 | |
*** liverpooler has quit IRC | 20:03 | |
*** FL1SK has joined #openstack-nova | 20:03 | |
*** armax has quit IRC | 20:03 | |
openstackgerrit | Jackie Truong proposed openstack/nova master: [WIP] Add trusted certificates to InstanceExtras https://review.openstack.org/457711 | 20:05 |
*** tbachman has quit IRC | 20:05 | |
*** tbachman_ is now known as tbachman | 20:05 | |
*** mtanino__ has joined #openstack-nova | 20:08 | |
dansmith | mriedem: do you recall anyone saying they actually use soft delete? | 20:08 |
mriedem | dansmith: no | 20:09 |
dansmith | given it's not user-visible (control anyway) we might want to seriously consider yanking it out, IMHO | 20:10 |
cburgess | dansmith: +1 | 20:10 |
mriedem | i'm asking in ops | 20:10 |
mriedem | so will get back to you in 3 days | 20:10 |
dansmith | maybe do some targeted data gathering on the idea | 20:10 |
cburgess | dansmith Its mostly useless in its current form. | 20:10 |
dansmith | hah | 20:10 |
dansmith | cburgess: agreed, and it's constantly broken, untested, etc | 20:10 |
mriedem | sdague and i have kicked around ideas on data mining api usage | 20:10 |
mriedem | b/c we've asked this about shelve too | 20:11 |
mriedem | this would also be a good user survey question | 20:11 |
cburgess | mriedem Our product team keeps asking for that. So maybe its something of value to add in optionally for people to turn on/off | 20:11 |
dansmith | I know people that use shelve | 20:11 |
cburgess | dansmith I'm sorry | 20:11 |
mriedem | cburgess: keeps asking for what? | 20:11 |
mriedem | cburgess: api usage data mining? | 20:11 |
cburgess | mriedem Our product team wants to be able to data mine the API calls to figure out which clients use which features etc. | 20:11 |
mriedem | ah | 20:11 |
mriedem | yeah, i don't think we'd need to turn it on/off, | 20:12 |
mriedem | it'd be nova-manage | 20:12 |
mriedem | mine the instance actions table | 20:12 |
dansmith | cburgess: that's a script of processing the log right? | 20:12 |
mriedem | pretty simple actually | 20:12 |
mriedem | this data is all in instance actions already | 20:12 |
cburgess | Which one can do by scraping the logs but.. they want want something a bit more sophsiticated | 20:12 |
cburgess | dansmith Yeah we have been trying to get the data team to do something with it... mixed results. | 20:12 |
mriedem | select * from instance_actions where action == 'shelve' | 20:12 |
cburgess | mriedem I don't think instance_action is enough for all the stuff product has in mind. You have to look at args at times to figure out whats being done in the call. For instannce boot from volume etc. | 20:13 |
dansmith | for client versions it does nothing | 20:13 |
melwitt | notifications would be a good way to mine | 20:13 |
cburgess | Type of security groups rules (nested vs not) etc. | 20:13 |
cburgess | melwitt yeah true... | 20:13 |
mriedem | i'm just looking at basic things right now | 20:13 |
cburgess | mriedem Fair enough... | 20:14 |
mriedem | "of all instance actions in this cloud, what % is shelve?" | 20:14 |
mriedem | basically first iteration is a report of the count of instance actions in a cloud | 20:14 |
mriedem | which is pretty simple | 20:14 |
dansmith | hmm, not sure what use that is unless you're comparing to another | 20:14 |
mriedem | ? | 20:15 |
mriedem | if we know there are 100 instance actions in the db, and 5 are shelve, then we know 5% is shelve | 20:15 |
dansmith | on an active cloud, 10% shelve would be huge. on a static "we just moved our workloads to cloud", 10% wouldn't mean as much | 20:15 |
mriedem | yeah, again, baby steps | 20:15 |
mriedem | you have to be able to mine the data in a single install, and then start aggregating that probably in the user survey, or some other tool, idk | 20:15 |
mriedem | based on the size of the cloud, which is probably based on # of vms and/or # of computes | 20:16 |
dansmith | that's what I'm saying, it only really means something in comparison | 20:16 |
mriedem | if i'm asking a binary yes/no question, | 20:16 |
mriedem | it means something | 20:16 |
mriedem | ala user survey, does your cloud use shelve | 20:16 |
mriedem | or, | 20:16 |
mriedem | do users of your cloud use shelve | 20:16 |
mriedem | yes/no | 20:16 |
melwitt | I think the user survey is out right now | 20:17 |
mriedem | yeah this would be 2018 at this point | 20:17 |
mriedem | for the user survey | 20:17 |
melwitt | yeah | 20:17 |
mriedem | but, | 20:17 |
dansmith | mriedem: but you don't want someone with one shelve ever to answer yes | 20:17 |
dansmith | anyway, not arguing with data of course, I'm just not sure what I'd make of "10% shelve" as an answer | 20:17 |
mriedem | if we provided a thing in nova-manage, we could also ask people to run that in the ops list and report back their findings | 20:17 |
melwitt | do you use shelve A Lot(tm)? | 20:17 |
mriedem | which is skewed i know, but so is the user survey | 20:17 |
dansmith | I mostly care about "would you freak if we removed feature X?" | 20:18 |
mriedem | yes you'd have to account for outliers like 1 usage of 1000 | 20:18 |
mriedem | gdi you bastards | 20:18 |
mriedem | i'm going home | 20:18 |
melwitt | lol | 20:18 |
mriedem | getting something like this fed into the interop wg could also be a possibility | 20:19 |
mriedem | as they are feeding their interop results in there regularly | 20:19 |
mriedem | but, | 20:19 |
dansmith | 1/1000 is probably a typo, 10/10000 is probably one user that loves shelve | 20:19 |
mriedem | interop is also like products like distros, not necessarily active clouds | 20:19 |
*** harlowja has quit IRC | 20:19 | |
mriedem | so that doesn't work as well | 20:19 |
mriedem | if we can get the data, we can give it to sdague who can give it to watson | 20:20 |
mriedem | who will then turn it into trivia | 20:20 |
dansmith | hah | 20:20 |
dansmith | What is "kill soft delete" alex/ | 20:20 |
mriedem | for 500 | 20:20 |
mriedem | ooo that's the mothertruckin daily double! | 20:20 |
*** smatzek has quit IRC | 20:21 | |
*** lpetrut_ has joined #openstack-nova | 20:21 | |
* melwitt cues sound effect | 20:21 | |
*** harlowja has joined #openstack-nova | 20:22 | |
dansmith | https://i.ytimg.com/vi/3J2PlJmkvog/maxresdefault.jpg | 20:22 |
melwitt | lol | 20:22 |
mriedem | so, | 20:23 |
mriedem | if i'm writing this resize test that gets the quota usage before the resize, | 20:23 |
mriedem | and then gets the reserved quota usage after the resize, | 20:23 |
mriedem | before counting quotas they are going to be the same, | 20:23 |
mriedem | but after counting quotas they are going to be different b/c we don't reserve, right? | 20:23 |
mriedem | looking at this https://github.com/openstack/nova/blob/ac20980702030424ce4bb3ddf2610d31716a8bd7/nova/api/openstack/compute/used_limits.py#L65 | 20:24 |
melwitt | well, with counting quotas we won't be touching the usages table, so neither usage nor reservation will be changed. so they should be the same (unchanged) | 20:24 |
mriedem | that tells the limits API whether or not to include 'reserved' quota in the response for usage | 20:24 |
melwitt | oh, you mean get usage as in, from the used limits API? | 20:24 |
melwitt | that will show you the new counted usage | 20:25 |
mriedem | yes | 20:25 |
melwitt | okay | 20:25 |
mriedem | so once the server is in verify_resize state, it's going to count against quota? | 20:25 |
melwitt | in the change it always sets reserved to show 0 | 20:25 |
mriedem | for the new size, if i'm resizing up for example? | 20:25 |
melwitt | it's not pulling it from the usages table, it's just hard-coded to be 0 | 20:25 |
dansmith | is reserved for resizing instances? | 20:26 |
mriedem | reserved is just the placeholder for quota usage until the operation is complete | 20:26 |
melwitt | it's for everything. yeah | 20:26 |
mriedem | usually committed or rolled back later | 20:26 |
melwitt | ot | 20:26 |
dansmith | oh I guess reserved is reservations that haven't been committted | 20:26 |
dansmith | gotcha | 20:26 |
melwitt | it's for all ReservableResource | 20:26 |
mriedem | like, that's why the reservations are passed from api to compute | 20:26 |
mriedem | yeah, so i'm trying to figure out how i should write the functional test, | 20:26 |
*** slaweq has quit IRC | 20:26 | |
mriedem | because that's what i was goign to do, check usage before the resize, and compare to usage after the resize is in verify_resize state | 20:27 |
mriedem | and today they will be different if you include the reserved value in the results | 20:27 |
mriedem | https://developer.openstack.org/api-ref/compute/?expanded=show-a-quota-detail,show-rate-and-absolute-limits-detail#id225 | 20:27 |
mriedem | 1 | 20:27 |
mriedem | "Specify whether the result of resource total includes reserved resources or not." | 20:27 |
melwitt | well, I see that resize reservation is committed in compute after the resize request. so that happens before confirm/revert | 20:29 |
melwitt | so when it's in verify_resize it should have reserved == usage currently, right? | 20:29 |
melwitt | sorry | 20:30 |
melwitt | reserved will be 0 | 20:30 |
mriedem | but in_use would be incremented | 20:30 |
melwitt | right | 20:30 |
mriedem | ok | 20:30 |
mriedem | so what will happen with counting quotas? | 20:30 |
melwitt | usage should be incremented and reserved will be 0 (reserved is hard-coded to 0 always) | 20:30 |
mriedem | because instance.memory_mb is taken from new_instance_type['memory_mb'] somewhere? | 20:31 |
mriedem | b/c the count is now taken from instance.memory_mb right? | 20:31 |
melwitt | lemme see ... | 20:31 |
melwitt | yeah, as long as the new flavor has been saved to the instance | 20:31 |
melwitt | I'm looking where that happens. pretty sure it's regardless of confirm/revert | 20:32 |
melwitt | yeah, in finish_resize() (before confirm/revert) it sets the new flavor. so at that time the new usage should be counted | 20:32 |
melwitt | if an instance is sitting in verify_resize it's consuming more resources (if a resize up) | 20:33 |
mriedem | ah Specify whether the result of resource total includes reserved resources or not. | 20:33 |
mriedem | oops | 20:33 |
mriedem | _set_instance_info | 20:33 |
mriedem | in the compute manager | 20:33 |
melwitt | yeah | 20:34 |
mriedem | we should probably remove this comment then :) https://github.com/openstack/nova/blob/ac20980702030424ce4bb3ddf2610d31716a8bd7/nova/compute/manager.py#L4006 | 20:34 |
mriedem | since the quota count is goign to be completely based on these now | 20:34 |
*** tbachman_ has joined #openstack-nova | 20:34 | |
melwitt | yeah, true | 20:35 |
mriedem | i've noted it in your change | 20:35 |
mriedem | ok on with the test | 20:35 |
melwitt | I'm trying to think how a confirm could ever fail quota check. I think it couldn't because all confirm does is remove the stuff from the source host and other cleanup. it wouldn't do anything to change the usage | 20:35 |
melwitt | just thinking out loud | 20:36 |
mriedem | that sounds right | 20:36 |
mriedem | so i'll get this test up and it will test the existing behavior, and then put a change on top to depend on your patch to test the new behavior | 20:36 |
melwitt | so just makes me wonder why it checks quota on a confirm at all right now | 20:36 |
melwitt | k, cool. | 20:37 |
mriedem | shrug | 20:37 |
*** tbachman has quit IRC | 20:37 | |
*** tbachman_ is now known as tbachman | 20:37 | |
melwitt | in a code comment says it does it only for a decrease in usage. ah, because on resize it only makes a reservation for an upsize. never for a downsize | 20:38 |
*** gszasz has quit IRC | 20:39 | |
melwitt | so this is adjusting usage for a downsize only on confirm. guh, how confusing | 20:39 |
melwitt | so for our new counting stuff, we shouldn't need to check quota on confirm. only on revert | 20:39 |
*** krtaylor has quit IRC | 20:41 | |
mriedem | and only on revert when upsizing? | 20:44 |
mriedem | or we just won't make a distinction? | 20:44 |
melwitt | yeah. it could save wasted query to only do it on a revert of a downsize | 20:44 |
melwitt | so I think that's a good idea | 20:45 |
*** armax has joined #openstack-nova | 20:45 | |
*** MVenesio has quit IRC | 20:51 | |
*** lyan has joined #openstack-nova | 20:53 | |
*** tylerder_ has joined #openstack-nova | 21:01 | |
*** awaugama has quit IRC | 21:02 | |
*** tylerderosagrund has quit IRC | 21:04 | |
*** tylerder_ has quit IRC | 21:06 | |
*** esberglu has quit IRC | 21:12 | |
*** smatzek has joined #openstack-nova | 21:15 | |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Add functional test for resize-confirm plus quota validation https://review.openstack.org/483559 | 21:16 |
*** smatzek has quit IRC | 21:20 | |
*** kylek3h has quit IRC | 21:20 | |
*** jmlowe has joined #openstack-nova | 21:21 | |
*** zzzeek has quit IRC | 21:22 | |
*** zzzeek has joined #openstack-nova | 21:24 | |
*** esberglu has joined #openstack-nova | 21:26 | |
*** krtaylor has joined #openstack-nova | 21:26 | |
*** pchavva has quit IRC | 21:27 | |
*** Apoorva_ has quit IRC | 21:29 | |
*** Apoorva has joined #openstack-nova | 21:30 | |
mriedem | https://bugs.launchpad.net/cinder/+bug/1694509 | 21:31 |
openstack | Launchpad bug 1694509 in Cinder "eventlet errors and cannot switch to a different thread" [Undecided,Confirmed] | 21:31 |
mriedem | oops | 21:31 |
openstackgerrit | Jay Pipes proposed openstack/nova master: scheduler: isolate _get_sorted_hosts() https://review.openstack.org/483564 | 21:33 |
openstackgerrit | Jay Pipes proposed openstack/nova master: add dict of allocation requests to select_dests() https://review.openstack.org/483565 | 21:33 |
openstackgerrit | Jay Pipes proposed openstack/nova master: claim resources in placement API during schedule() https://review.openstack.org/483566 | 21:33 |
jaypipes | cdent, mriedem, dansmith, edleafe, bauzas: ok, I know it's late in the day, but I got it pushed ^^ | 21:33 |
*** thorst has joined #openstack-nova | 21:42 | |
*** jaypipes has quit IRC | 21:42 | |
*** gouthamr has quit IRC | 21:47 | |
*** thorst has quit IRC | 21:48 | |
*** gouthamr has joined #openstack-nova | 21:49 | |
*** tylerderosagrund has joined #openstack-nova | 21:50 | |
*** sree has joined #openstack-nova | 21:51 | |
*** jdandrea has quit IRC | 21:51 | |
*** tylerderosagrund has quit IRC | 21:54 | |
*** tylerderosagrund has joined #openstack-nova | 21:54 | |
*** claudiub has quit IRC | 21:55 | |
*** sree has quit IRC | 21:56 | |
*** tylerderosagrund has quit IRC | 21:56 | |
*** tylerderosagrund has joined #openstack-nova | 21:57 | |
*** saneax has joined #openstack-nova | 22:01 | |
*** tylerderosagrund has quit IRC | 22:04 | |
*** tylerderosagrund has joined #openstack-nova | 22:06 | |
*** lpetrut_ has quit IRC | 22:06 | |
*** burt has quit IRC | 22:09 | |
*** gouthamr has quit IRC | 22:10 | |
*** slaweq has joined #openstack-nova | 22:10 | |
*** tylerderosagrund has quit IRC | 22:11 | |
*** tylerderosagrund has joined #openstack-nova | 22:19 | |
*** tylerder_ has joined #openstack-nova | 22:22 | |
*** tylerderosagrund has quit IRC | 22:22 | |
*** tylerder_ has quit IRC | 22:23 | |
*** tylerderosagrund has joined #openstack-nova | 22:23 | |
*** tylerderosagrund has quit IRC | 22:24 | |
*** tylerderosagrund has joined #openstack-nova | 22:24 | |
*** slaweq has quit IRC | 22:25 | |
*** tylerderosagrund has quit IRC | 22:25 | |
*** tylerderosagrund has joined #openstack-nova | 22:25 | |
*** felipemonteiro_ has quit IRC | 22:27 | |
*** slaweq has joined #openstack-nova | 22:42 | |
*** baoli has quit IRC | 22:45 | |
*** slaweq has quit IRC | 22:46 | |
*** kristian__ has quit IRC | 22:47 | |
*** raunak has joined #openstack-nova | 22:47 | |
*** lyan has quit IRC | 22:48 | |
*** baoli has joined #openstack-nova | 22:52 | |
*** jmlowe has quit IRC | 22:57 | |
*** itlinux has quit IRC | 22:58 | |
openstackgerrit | Merged openstack/nova master: Fix wrong log parm. https://review.openstack.org/482832 | 23:01 |
*** catintheroof has quit IRC | 23:03 | |
*** feefifofum has joined #openstack-nova | 23:04 | |
*** mtanino__ has quit IRC | 23:05 | |
*** slaweq has joined #openstack-nova | 23:08 | |
*** jwcroppe_ has quit IRC | 23:09 | |
*** jwcroppe has joined #openstack-nova | 23:09 | |
*** kristian__ has joined #openstack-nova | 23:12 | |
*** slaweq has quit IRC | 23:12 | |
*** tylerderosagrund has quit IRC | 23:12 | |
*** jwcroppe has quit IRC | 23:13 | |
*** rajathagasthya has quit IRC | 23:14 | |
*** kristian__ has quit IRC | 23:17 | |
*** Swami has quit IRC | 23:30 | |
*** jamesden_ has quit IRC | 23:33 | |
*** hongbin has quit IRC | 23:34 | |
*** jamesdenton has joined #openstack-nova | 23:34 | |
openstackgerrit | Merged openstack/nova master: Remove mox from nova.tests.unit.virt.xenapi.test_vm_utils.py https://review.openstack.org/478749 | 23:36 |
*** slaweq has joined #openstack-nova | 23:37 | |
*** slaweq has quit IRC | 23:41 | |
*** jwcroppe has joined #openstack-nova | 23:44 | |
*** thorst has joined #openstack-nova | 23:48 | |
*** vishwanathj has quit IRC | 23:53 | |
*** vishwanathj has joined #openstack-nova | 23:54 | |
*** thorst has quit IRC | 23:55 | |
*** itlinux has joined #openstack-nova | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!