Tuesday, 2017-08-01

*** yamamoto has quit IRC00:01
*** smatzek has quit IRC00:04
jaypipesdansmith: the reason it's failing is because you're forgetting to run that _run_perioidics() after calling delete on the server.00:04
jaypipesdansmith: on the revert one.00:05
*** yamamoto has joined #openstack-nova00:05
dansmithjaypipes: the reason what is failing?00:05
dansmithtests pass locally for me, and delete should clean up all the allocations without a periodic run, no?00:06
jaypipesnope.00:06
dansmithum why?00:06
jaypipesdansmith: delete doesn't clean up placement at all.00:06
dansmithdelete doesn't call self.update() or whatever in compute manager?00:06
jaypipesupdate is only inventory.00:06
dansmiththat would mean you can't boot instances on a compute node until after the periodic runs to clean up00:06
jaypipesdansmith: welcome to my hell.00:07
dansmithno, I'm serious00:08
dansmiththat makes zero sense to me.. surely we'd have people beating down our door if deleting an instance didn't free up space for another one00:08
dansmithjaypipes: but again, the tests pass for me, so what are you saying is failing?00:08
jaypipesdansmith: nm, I'm wrong.00:09
jaypipesI think...00:09
dansmithself._update_resource_tracker() is in _complete_deletion()00:09
dansmithsurely that updates things00:09
dansmithyeah, calls update_usage()00:09
jaypipesonly if the uuid is in self.tracked_instances.00:09
dansmithwhich it will be if it was just running00:10
*** xyang1 has quit IRC00:11
*** acormier has joined #openstack-nova00:11
*** chyka has quit IRC00:13
*** acormier has quit IRC00:15
*** dtp has quit IRC00:15
*** gmann has quit IRC00:16
*** gmann has joined #openstack-nova00:16
*** vishwana_ has joined #openstack-nova00:18
*** edmondsw has joined #openstack-nova00:21
*** vishwanathj has quit IRC00:22
*** edmondsw has quit IRC00:25
*** acormier has joined #openstack-nova00:26
*** mdnadeem has joined #openstack-nova00:28
*** rdo_ has joined #openstack-nova00:28
*** rdo has quit IRC00:28
*** mtanino_ has quit IRC00:30
*** mriedem has quit IRC00:30
*** kiennt has joined #openstack-nova00:32
*** armax has quit IRC00:34
*** slaweq has joined #openstack-nova00:36
*** mdnadeem has quit IRC00:37
*** mriedem has joined #openstack-nova00:38
*** harlowja has quit IRC00:38
mriedemdansmith: jaypipes: did you guys sort out the delete allocations on delete thing? b/c i'm pretty sure melwitt has a functional test up for that.00:41
jaypipesmriedem: yeah, I was wrong.00:41
mriedemoh https://review.openstack.org/#/c/470578/ is for local delete00:42
*** slaweq has quit IRC00:42
*** zhurong has joined #openstack-nova00:42
mriedemalright well someone just ping me when the pep8 thing is fixed and i'll +200:43
jaypipesmriedem: I'm working on it.00:45
*** thorst_afk has joined #openstack-nova00:46
*** kiennt has quit IRC00:47
*** mdnadeem has joined #openstack-nova00:47
openstackgerritMichael Still proposed openstack/nova master: Move execs of tee to privsep.  https://review.openstack.org/48943800:48
*** haukebruno has joined #openstack-nova00:50
*** Shunli has joined #openstack-nova00:51
*** kiennt has joined #openstack-nova00:51
mikalmelwitt / sdague: the +W fell off https://review.openstack.org/#/c/486831 if you're feeling charitable00:53
*** rajathagasthya has quit IRC00:53
mikalIt would make tonyb's day00:53
tonybit would at that00:53
*** thorst_afk has quit IRC00:54
mriedemthere was no +W on that00:54
*** _pewp_ has quit IRC00:54
mriedemnice try aussies00:55
jaypipesdansmith: why are we setting the availability zone on the build request in these tests?00:55
mriedemjaypipes: to force the host00:55
mriedemat boot time00:55
jaypipesugh00:55
mriedemit uses the forced_host thing in the api00:55
mriedemyeah00:55
mikalmriedem: curse you meddling kids00:55
mriedembut it makes the order deterministic00:55
mriedemjaypipes: plus we lost all the docs on that forced_host thing with the docs migration i think00:56
*** jichen has joined #openstack-nova00:56
*** _pewp_ has joined #openstack-nova00:57
tonybZOMG I was lied to!00:58
mriedemhttps://github.com/openstack/openstack-manuals/commit/c21f7bb13ccec63ecf96f5d9d0a9d30f1057e4d5#diff-320133d1ccbd2ba417cd580760c1860600:58
mriedemstephenfin: ^ do we have plans to import that into the nova docs?00:59
mriedembecause this forced_host thing isn't in the compute API reference00:59
jaypipesreally wish we used the names source and destination instead of "host" and "other"01:00
mikaljaypipes: that's defeatist01:01
mikaljaypipes: next you'll be complaining that we convey "hairpin enable failed" with a ProcessException01:01
jaypipesheh01:01
mriedemjaypipes: agree on the naming there, we could rename / refactor later too01:02
mriedemplus there is a lot of redundant code in there before we get to the confirm/revert action which could be put into a private common method01:02
jaypipesmriedem: honestly, I just don't understand why there's a need for the whole "do this test in the opposite order" thing.01:02
dansmithjaypipes: because you fail it differently in each case01:04
dansmithjaypipes: keep it on master and disable the skips and you'll see01:05
jaypipesdansmith: but if the whole "availability_zone": "nova:" + initial thing is so deterministic, why the need?01:05
dansmithbecause going from one compute node to the other, and running their periodics in that order end up with an updated allocation01:05
dansmithin the reverse order, one of them deletes it last01:05
dansmithi.e. one updates, then the other deletes01:06
dansmithvs one deletes then the other updates (creates)01:06
jaypipeswith all the stuff we discussed today about ocata computes, there's going to need to be so many friggin conditionals in these code paths that we're introducing more risk than anything else :(01:06
dansmithyou mean in order to pass the tests?01:07
dansmiththat's exactly why we must have it tested both ways01:07
dansmithocata to pike _has_ to work, and pike to pike _has_ to work, with no leaks01:07
jaypipeswell these tests don't test ocata to pike, only pike to pike01:07
dansmithpike to ocata I can kind of get on board with allowing to be leaky, but it's still not awesome01:07
dansmithjaypipes: exactly, we must have _at least_ this much coverage,01:07
dansmithand we really need one that simulates the pike/ocata split01:07
dansmithwe have the grenade multinode case, which helps, but it's not deterministic01:08
dansmithand I think we've shown thus far, that if we don't lay down a test-driven approach to what we expect,01:08
*** sdague has quit IRC01:08
jaypipesI'm in a fix one thing, break ten others place right now :(01:08
dansmithwe're going to keep bouncing around between partial solutions01:08
*** iceyao has joined #openstack-nova01:09
dansmithjaypipes: I'm not sure what the alternative is.. if I can write a test that shows that the code is broken if we end up running things in a particular sequence, that's a problem right?01:10
mriedemwe can possibly build on this to make one of the computes' service version be ocata01:11
mriedemto test that code path in the change that checks the min service version01:11
jaypipesdansmith: I'm not disagreeing with you that shit is broken. I just don't know how to fix this without breaking the happy path01:11
dansmithmriedem: we have to simulate the ocata way of managing allocations too01:11
mriedemplus we can do the single node resize to same host testing building on this01:11
dansmithmriedem: i.e. the "always blow away everything without looking first" way01:12
mriedemhappy path is all computes are pike isn't it?01:12
dansmithyes01:12
mriedemwhich this tests01:12
dansmithright01:12
jaypipesno. happy path is non-move operations.01:12
dansmithhah01:12
dansmiththat's the beer path01:12
mriedemso,01:13
mriedemwhat about bfv with shared storage resize to another az?01:13
mriedemwill THAT work?!01:13
jaypipesnot funny01:13
mriedemuh mixed compute too01:13
mriedemfine fine fine01:14
mriedems/resize/evacuate/01:14
mriedemhappy?01:14
mriedemso i think the tests as written are a same-version compute good representation of what we expect for confirm and revert, and before dan moved them from the top of the series of fixes, they were passing01:15
mriedemso i think we get that baseline going, and then starting adding in test wrinkles01:15
mriedemi think this is all easier once we have the tests written01:16
dansmithmriedem: meaning they worked on top of the series, which means the series can work atop the tests, right?01:16
mriedemyeah01:16
dansmiththat was my reason for doing that before rebasing, to make sure they could work with jay's set01:16
mriedemjust like how we do the functional regression bug testaroos01:16
dansmithagreed, we *have* to get this baseline working, and then we can expand the base a bit01:17
dansmithfor things like single compute at least01:17
*** randomhack has joined #openstack-nova01:17
jaypipesI don't disagree with you.01:17
jaypipesjust raging that's all.01:17
jaypipesI'll figure it out eventually.01:17
mriedemi'll go back to commenting up dan's cells docs patch :)01:18
* dansmith puts on his muck boots01:19
*** randomhack has quit IRC01:21
*** yamamoto has quit IRC01:25
jaypipesdansmith: still here?01:27
dansmithjaypipes: yeah01:27
jaypipesdansmith: so this:01:27
jaypipes1136         compute_version = objects.Service.get_minimum_version(01:27
jaypipes1137             context, 'nova-compute')01:27
jaypipes1138         heal_allocations = False01:27
jaypipes1139         if compute_version < 22:01:27
jaypipes1140             heal_allocations = True01:27
jaypipesis not working01:27
jaypipesor at least, it's returning heal_allocations = True in the functional tests01:28
dansmithjaypipes: are you using the allservicescurrent fixture?01:28
jaypipeswhich is triggering the healing of allocations improperly.01:28
dansmithotherwise you probably have a min ver of zero01:28
jaypipesdansmith: sigh01:28
dansmithjaypipes: mriedem pointed that out earlier01:28
jaypipesyou even told me about that earlier.01:28
jaypipesyeah.. :(01:28
dansmithyeah, sorry01:28
*** thorst_afk has joined #openstack-nova01:29
*** yamamoto has joined #openstack-nova01:29
*** gcb has joined #openstack-nova01:30
*** litao__ has joined #openstack-nova01:33
*** gcb has quit IRC01:37
*** thorst_afk has quit IRC01:38
*** thorst_afk has joined #openstack-nova01:38
*** gcb has joined #openstack-nova01:39
mriedemdansmith: ok comments in https://review.openstack.org/#/c/487183/ for the cells docs - looks real purdy01:39
mriedemyou can tell me you'll look in the morning and i won't be hurt01:40
*** xinliang has joined #openstack-nova01:40
*** xinliang has quit IRC01:40
*** xinliang has joined #openstack-nova01:40
dansmithmriedem: I'll look in the morning01:40
* mriedem is broken hearted01:41
dansmithbut.. you said...01:41
*** https_GK1wmSU has joined #openstack-nova01:42
*** thorst_afk has quit IRC01:43
*** https_GK1wmSU has left #openstack-nova01:44
jaypipesdansmith: other_provider_uuid is the source host right?01:46
dansmithjaypipes: it depends on which direction you're going01:46
dansmithjaypipes: actually, it should always be target the way it's written I think01:47
dansmithprovider_uuid is instance[host] and other is the target right/01:47
jaypipesdansmith: ? if "host" is always the one you were originally scheduled to, then other is the one you're going *to*, right?01:47
jaypipesyeah, ok01:47
jaypipesdansmith: the only thing the "other direction" refers to isn't the direction but rather the order in which the hosts' update_available_resource() is called.01:48
jaypipesI think?01:48
dansmithno01:48
dansmithwe always call host1 first and host2 second01:48
*** Apoorva has quit IRC01:48
dansmithfor the periodic01:49
mriedemother_provider_uuid is the target01:50
dansmithright01:50
dansmiththe destination host01:51
mriedemwe could rename to target or dest or whatever01:51
dansmithyep01:51
*** yamamoto has quit IRC01:51
*** tuanluong has joined #openstack-nova01:51
jaypipesI gotta look at this in the morning. I'm fried right now :(01:51
dansmithjaypipes: you want me to convert it to source/dest so it's like that for you in the morning?01:52
jaypipesdansmith: no.01:52
jaypipesdansmith: I'll do it in the morning. will probably need to start from scratch with this last patch :(01:52
*** armax has joined #openstack-nova01:52
dansmithokay01:52
jaypipestoo many friggin conditionals to keep in my head.01:52
jaypipesare we in the update loop? are we on an ocata? are we removing? are we migrating to same host?01:53
jaypipesall with the same fucking code paths. :(01:53
dansmithwell, this is why in hindsight, I think bolting this onto the RT was a bad move01:53
dansmithtoo much baggage01:53
dansmithjaypipes: anyway, go get your pug cuddles01:54
*** itlinux has joined #openstack-nova01:55
*** thorst_afk has joined #openstack-nova01:55
*** thorst_afk has quit IRC01:55
*** yamamoto has joined #openstack-nova01:56
*** tbachman has quit IRC01:58
*** slaweq has joined #openstack-nova01:59
jaypipesdansmith: I would have been happy to write all of this outside of the resource tracker, but you know... upgrades.02:00
openstackgerritSpencer Yu proposed openstack/python-novaclient master: Nova client should retry with Retry-After value  https://review.openstack.org/44776602:00
*** itlinux has quit IRC02:01
*** owalsh_ has joined #openstack-nova02:04
*** slaweq has quit IRC02:04
*** yamamoto has quit IRC02:07
*** owalsh has quit IRC02:08
*** yamahata has quit IRC02:08
*** slaweq has joined #openstack-nova02:09
*** mriedem has quit IRC02:10
*** thorst_afk has joined #openstack-nova02:11
*** bkopilov_ has quit IRC02:11
*** slaweq has quit IRC02:15
*** rajathagasthya has joined #openstack-nova02:17
*** acormier has quit IRC02:19
*** acormier has joined #openstack-nova02:19
*** yamamoto has joined #openstack-nova02:19
*** hongbin has joined #openstack-nova02:21
*** harlowja has joined #openstack-nova02:22
*** acormier has quit IRC02:24
*** thorst_afk has quit IRC02:25
*** itlinux has joined #openstack-nova02:27
*** rajathagasthya has quit IRC02:34
*** saphi has joined #openstack-nova02:37
*** esberglu has joined #openstack-nova02:39
*** kiennt has quit IRC02:41
*** kiennt has joined #openstack-nova02:42
*** harlowja has quit IRC02:44
*** esberglu has quit IRC02:44
*** esberglu has joined #openstack-nova02:49
*** baoli_ has quit IRC02:50
*** hongbin_ has joined #openstack-nova02:55
*** hongbin has quit IRC02:57
*** hongbin has joined #openstack-nova02:59
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi: Live migration failed in xapi pool  https://review.openstack.org/48945103:00
*** hongbin_ has quit IRC03:00
*** itlinux has quit IRC03:01
*** yamamoto has quit IRC03:01
*** yamamoto has joined #openstack-nova03:06
*** lbragstad_ has joined #openstack-nova03:14
*** lbragstad has quit IRC03:14
*** yamamoto has quit IRC03:21
*** sree_ has joined #openstack-nova03:23
*** sree_ is now known as Guest3515903:23
*** yamamoto has joined #openstack-nova03:24
*** gouthamr has quit IRC03:28
*** bkopilov_ has joined #openstack-nova03:29
*** yamamoto has quit IRC03:36
*** marst has joined #openstack-nova03:36
*** slaweq has joined #openstack-nova03:37
*** harlowja has joined #openstack-nova03:38
*** slaweq has quit IRC03:42
*** udesale has joined #openstack-nova03:43
*** yamamoto has joined #openstack-nova03:44
*** nicolasbock has joined #openstack-nova03:45
*** dave-mcc_ has quit IRC03:48
*** mamandle has joined #openstack-nova03:50
*** iceyao has quit IRC03:56
*** ijw has quit IRC03:57
*** mvensky has quit IRC03:58
*** kbaegis has quit IRC03:59
*** mvensky has joined #openstack-nova04:04
*** mtanino has quit IRC04:04
*** yamamoto has quit IRC04:04
*** hongbin has quit IRC04:05
*** links has joined #openstack-nova04:07
*** yamamoto has joined #openstack-nova04:09
*** hshiina has joined #openstack-nova04:09
*** takashin has joined #openstack-nova04:09
*** psachin has joined #openstack-nova04:10
*** iceyao has joined #openstack-nova04:21
*** takashin_ has joined #openstack-nova04:21
*** takashin has quit IRC04:23
*** iceyao has quit IRC04:26
*** thorst_afk has joined #openstack-nova04:26
*** ijw has joined #openstack-nova04:27
*** thorst_afk has quit IRC04:31
*** ijw has quit IRC04:31
*** udesale__ has joined #openstack-nova04:32
*** adisky__ has joined #openstack-nova04:33
*** udesale has quit IRC04:34
*** iceyao has joined #openstack-nova04:39
*** jhesketh__ has joined #openstack-nova04:44
*** iceyao has quit IRC04:44
*** jhesketh__ has quit IRC04:44
*** jhesketh_ has joined #openstack-nova04:44
*** jhesketh_ has quit IRC04:45
*** iceyao has joined #openstack-nova04:45
*** mamandle_ has joined #openstack-nova04:49
*** mamandle has quit IRC04:49
*** mamandle_ is now known as mamandle04:49
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix test_get_volume_config method  https://review.openstack.org/48946704:53
*** ratailor has joined #openstack-nova04:56
*** chyka has joined #openstack-nova04:58
*** slaweq has joined #openstack-nova04:59
*** chyka has quit IRC05:02
*** slaweq has quit IRC05:04
*** itlinux has joined #openstack-nova05:05
*** prateek has joined #openstack-nova05:06
*** iceyao has quit IRC05:08
*** harlowja has quit IRC05:10
*** Alex_____ has quit IRC05:12
*** vvargaszte has quit IRC05:13
*** gabor_antal has quit IRC05:13
*** hferenc has quit IRC05:14
*** mamandle has quit IRC05:17
*** https___GK1wmSU has joined #openstack-nova05:17
*** https__GK1wmSU has joined #openstack-nova05:17
*** randomhack has joined #openstack-nova05:17
*** https___GK1wmSU has left #openstack-nova05:20
*** https__GK1wmSU has left #openstack-nova05:20
*** ekuris has joined #openstack-nova05:21
*** randomhack has quit IRC05:22
*** moshele has joined #openstack-nova05:26
*** hoonetorg has quit IRC05:27
*** tetsuro has joined #openstack-nova05:28
*** gcb has quit IRC05:29
*** gcb_ has joined #openstack-nova05:29
*** moshele has quit IRC05:29
*** chyka has joined #openstack-nova05:29
*** lpetrut has joined #openstack-nova05:32
*** chyka has quit IRC05:34
*** moshele has joined #openstack-nova05:34
*** sridharg has joined #openstack-nova05:35
*** itlinux has quit IRC05:35
*** iceyao has joined #openstack-nova05:35
*** hferenc has joined #openstack-nova05:36
*** iceyao has quit IRC05:40
*** hferenc has quit IRC05:41
*** hferenc has joined #openstack-nova05:42
*** hoonetorg has joined #openstack-nova05:44
*** vladikr has quit IRC05:48
*** harlowja has joined #openstack-nova05:51
*** kiennt has quit IRC05:57
*** moshele has quit IRC05:58
*** moshele has joined #openstack-nova06:01
*** yamahata has joined #openstack-nova06:01
*** kiennt has joined #openstack-nova06:01
*** iceyao has joined #openstack-nova06:03
openstackgerritZhaokun Fu proposed openstack/nova master: Smaller disk flavor check  https://review.openstack.org/48948406:04
*** jaosorior has quit IRC06:05
*** esberglu has quit IRC06:06
*** esberglu has joined #openstack-nova06:06
*** iceyao has quit IRC06:08
*** trinaths has joined #openstack-nova06:09
openstackgerritMichael Still proposed openstack/nova master: Avoid chowning console logs in libvirt  https://review.openstack.org/47222906:10
openstackgerritMichael Still proposed openstack/nova master: First attempt at adding a privsep user to nova itself.  https://review.openstack.org/45916606:10
openstackgerritMichael Still proposed openstack/nova master: Move execs of touch to privsep.  https://review.openstack.org/48919006:10
openstackgerritMichael Still proposed openstack/nova master: Move execs of tee to privsep.  https://review.openstack.org/48943806:10
openstackgerritMichael Still proposed openstack/nova master: Move libvirt usages of chown to privsep.  https://review.openstack.org/47197206:10
openstackgerritMichael Still proposed openstack/nova master: rootwrap.d cleanup mislabeled files  https://review.openstack.org/48683106:10
openstackgerritMichael Still proposed openstack/nova master: Read from console ptys using privsep.  https://review.openstack.org/48948606:10
*** iceyao has joined #openstack-nova06:12
*** slaweq has joined #openstack-nova06:13
*** amuresan has joined #openstack-nova06:13
openstackgerritZhaokun Fu proposed openstack/nova master: Smaller disk flavor check  https://review.openstack.org/48948406:14
*** esberglu has quit IRC06:15
*** mvensky has quit IRC06:15
openstackgerritjichenjc proposed openstack/nova master: Move common definition into common.py  https://review.openstack.org/48949106:17
openstackgerritjichenjc proposed openstack/nova master: WIP:check query param for service's index function  https://review.openstack.org/48949206:17
*** yushb has joined #openstack-nova06:18
*** jaosorior has joined #openstack-nova06:24
*** thorst_afk has joined #openstack-nova06:28
*** thorst_afk has quit IRC06:32
*** mamandle has joined #openstack-nova06:34
*** mvensky has joined #openstack-nova06:35
*** lpetrut has quit IRC06:42
*** karthiks has joined #openstack-nova06:42
*** gabor_antal has joined #openstack-nova06:45
*** harlowja has quit IRC06:51
*** ralonsoh has joined #openstack-nova06:52
*** vvargaszte has joined #openstack-nova06:53
openstackgerritjichenjc proposed openstack/nova master: WIP:check query param for service's index function  https://review.openstack.org/48949206:53
*** sshwarts has joined #openstack-nova06:54
*** lpetrut has joined #openstack-nova06:54
*** rcernin has joined #openstack-nova06:55
*** alexchadin has joined #openstack-nova06:56
*** dtantsur|afk is now known as dtantsur07:01
*** cfriesen_ has quit IRC07:02
*** Shunli has quit IRC07:03
*** Shunli has joined #openstack-nova07:03
*** pcaruana has joined #openstack-nova07:06
*** markus_z has joined #openstack-nova07:10
* gibi_ reads back07:10
*** gibi_ is now known as gibi07:11
openstackgerritjichenjc proposed openstack/nova master: WIP: allow null to be input for key_name  https://review.openstack.org/48950507:13
*** ygl has joined #openstack-nova07:15
*** vladikr has joined #openstack-nova07:22
bhagyashrisjaypipes: Hi, Found one bug reported on launchpad https://bugs.launchpad.net/nova/+bug/1707256 so is this will solve the issue that we have discussed yesterday.07:22
openstackLaunchpad bug 1707256 in OpenStack Compute (nova) "Scheduler report client does not account for shared resource providers" [High,Confirmed] - Assigned to Jay Pipes (jaypipes)07:22
*** sshwarts has quit IRC07:26
*** aarefiev_afk is now known as aarefiev07:28
*** Oku_OS-away is now known as Oku_OS07:28
*** mdnadeem has quit IRC07:32
*** mdnadeem has joined #openstack-nova07:37
*** kukacz has joined #openstack-nova07:39
*** kukacz has quit IRC07:41
*** moshele has quit IRC07:41
*** kukacz has joined #openstack-nova07:41
*** slaweq_ has joined #openstack-nova07:41
*** lpetrut has quit IRC07:43
*** moshele has joined #openstack-nova07:43
*** tiendc has joined #openstack-nova07:43
*** elod has joined #openstack-nova07:45
*** igordcard has quit IRC07:47
*** slaweq_ has quit IRC07:47
*** dtantsur is now known as dtantsur|bbl07:47
*** igordcard has joined #openstack-nova07:48
*** rcernin has quit IRC07:48
*** rcernin has joined #openstack-nova07:50
openstackgerritjichenjc proposed openstack/nova master: enhance error message for input field  https://review.openstack.org/48951907:53
openstackgerritjichenjc proposed openstack/nova master: WIP:enhance error message for input field  https://review.openstack.org/48951908:03
*** vladikr has quit IRC08:04
*** clarkb has quit IRC08:04
* gibi tries to contribute some way to the resize testing, maybe renaming variables to make it more understandable08:09
*** vladikr has joined #openstack-nova08:14
*** aloga has quit IRC08:17
*** randomhack has joined #openstack-nova08:17
*** aloga has joined #openstack-nova08:17
*** efoley has joined #openstack-nova08:17
*** clarkb has joined #openstack-nova08:17
*** efoley has quit IRC08:18
*** efoley has joined #openstack-nova08:18
openstackgerritjichenjc proposed openstack/nova master: add description about key_name  https://review.openstack.org/48952508:18
*** moshele has quit IRC08:19
*** rgerganov has quit IRC08:20
*** randomhack has quit IRC08:21
*** vladikr has quit IRC08:24
*** lucas-afk is now known as lucasagomes08:26
*** gmann_ has joined #openstack-nova08:26
openstackgerritjichenjc proposed openstack/nova master: Move common definition into common.py  https://review.openstack.org/48949108:26
openstackgerritjichenjc proposed openstack/nova master: WIP:check query param for service's index function  https://review.openstack.org/48949208:26
*** thorst_afk has joined #openstack-nova08:27
*** zenoway has joined #openstack-nova08:30
*** markvoelker has quit IRC08:30
*** markvoelker has joined #openstack-nova08:31
*** ygl has quit IRC08:31
*** vladikr has joined #openstack-nova08:31
*** thorst_afk has quit IRC08:32
mamandlebauzas: sfinucan: mriedem https://review.openstack.org/#/c/483911/ is awaiting another +2, can you please take a look, Thanks.08:32
*** markvoelker has quit IRC08:35
bhagyashrisHi all I am facing one issue to boot instance in multinode setup. Error ""Host 'host-name' is not mapped to any cell". because of this instance is going to error state Can any one have any idea about this to resolve.08:39
bhagyashrisOn controller + compute node the n-cond-cell1 is configure08:40
*** moshele has joined #openstack-nova08:42
*** priteau has joined #openstack-nova08:48
*** sapcc-bot2 has joined #openstack-nova08:49
*** zenoway has quit IRC08:50
*** zenoway has joined #openstack-nova08:50
*** Guest35159 has quit IRC08:50
*** sree_ has joined #openstack-nova08:51
*** sree_ is now known as Guest3597008:51
saphibhagyashris Did you discover new compute node? Run `nova-manage cell_v2 discover_hosts`  on controller node08:53
*** sapcc-bot has quit IRC08:53
*** alexchadin has quit IRC08:53
*** Guest35970 has quit IRC08:55
*** alexchadin has joined #openstack-nova08:56
*** zenoway has quit IRC08:58
*** zenoway has joined #openstack-nova08:58
*** yangyapeng has joined #openstack-nova09:00
*** cdent has joined #openstack-nova09:02
openstackgerritJacek Tomasiak proposed openstack/nova master: ironic: Use internal API endpoint  https://review.openstack.org/48953709:03
*** mdbooth[m] has left #openstack-nova09:09
trinathshi, when I installed compute node using devstack ocata, I see that nova-compute is running with nova-cpu.conf. but actually it must run with nova.conf and nova-compute.conf. is there any localrc changes I need to make for this?09:09
*** ralonsoh has quit IRC09:10
*** ralonsoh has joined #openstack-nova09:11
openstackgerritTakashi NATSUME proposed openstack/nova-specs master: Abort Cold Migration  https://review.openstack.org/33473209:13
*** yamahata has quit IRC09:17
*** moshele has quit IRC09:19
*** slaweq_ has joined #openstack-nova09:20
bhagyashrissaphi: Hi, I have done this too, but still getting same error.09:20
*** sdague has joined #openstack-nova09:20
trinathsI get this error when I run nova-compute, IncompatibleObjectVersion: Version 2.4 of InstanceList is not supported09:23
*** slaweq_ has quit IRC09:24
saphiCan you post your nova-compute.log?09:25
saphibhagyashris09:25
*** Oku_OS is now known as Oku_OS-away09:25
*** sambetts|afk is now known as sambetts09:27
openstackgerritZhaokun Fu proposed openstack/nova master: Smaller disk flavor check  https://review.openstack.org/48948409:28
openstackgerritAlexandru Muresan proposed openstack/nova master: Pass config object to oslo_reports  https://review.openstack.org/48557509:28
*** moshele has joined #openstack-nova09:29
*** Shunli has quit IRC09:30
trinathsCannot update service status on host "compute" due to an unexpected exception09:30
*** owalsh_ is now known as owalsh09:33
*** prateek has quit IRC09:33
*** mkucia has joined #openstack-nova09:34
bauzasjohnthetubaguy: not sure you're around, but I'm wondering if other drivers but libvirt and vmware can support shrinking root disks when resizing09:36
bauzasI tend to think so for ironic at least09:36
bauzasthe context being https://bugs.launchpad.net/nova/+bug/170783009:37
openstackLaunchpad bug 1707830 in OpenStack Compute (nova) "resize to smaller flavor failed, but has not error message on dashboard" [Medium,In progress] - Assigned to Zhaokun Fu (fuzhaokun)09:37
*** yamamoto has quit IRC09:37
bauzasI don't want to make it something verified by the API09:37
*** Oku_OS-away is now known as Oku_OS09:37
*** marst_ has joined #openstack-nova09:38
*** marst has quit IRC09:38
trinathsoslo_messaging.rpc.server IncompatibleObjectVersion: Version 2.4 of InstanceList is not supported09:42
*** ygl has joined #openstack-nova09:47
*** takashin_ has left #openstack-nova09:48
*** esberglu has joined #openstack-nova09:48
openstackgerritSylvain Bauza proposed openstack/nova master: Accept any scheduler driver entrypoint  https://review.openstack.org/48482809:49
*** lpetrut has joined #openstack-nova09:51
*** esberglu has quit IRC09:53
cdentsdague++ on the mass abandonment09:54
openstackgerritSylvain Bauza proposed openstack/nova master: Destroy the ReqSpec object when deleting the instance  https://review.openstack.org/39106009:54
sdaguecdent: yeh, the in progress list is a lot less accurate than we think09:55
*** jichen has quit IRC09:55
sdagueI trimmed back the criteria, this is just stuff that's been in merge conflict for 4 weeks09:55
*** moshele has quit IRC09:55
sdaguecdent: what comms channel did you notice this on?09:56
cdenti’m getting a lot of email for reviews that I’m watching09:56
*** udesale__ has quit IRC09:56
cdentor otherwise participating in09:56
cdentso: from gerrit09:56
*** yamamoto has joined #openstack-nova09:57
sdaguegotcha09:57
*** lpetrut_ has joined #openstack-nova09:59
*** lpetrut has quit IRC10:01
openstackgerritGábor Antal proposed openstack/nova master: Transform instance.resize_prep notification  https://review.openstack.org/46508110:02
*** gmann_ has quit IRC10:06
*** yamamoto has quit IRC10:08
*** moshele has joined #openstack-nova10:11
*** dtantsur|bbl is now known as dtantsur10:11
*** kiennt has quit IRC10:12
*** zenoway has quit IRC10:13
*** zenoway has joined #openstack-nova10:14
*** yushb has quit IRC10:17
*** zenoway has quit IRC10:18
openstackgerritChris Dent proposed openstack/nova master: Test resize with placement api  https://review.openstack.org/48795810:18
*** prateek has joined #openstack-nova10:19
*** prateek has quit IRC10:20
*** prateek has joined #openstack-nova10:21
*** yangyapeng has quit IRC10:22
gibicdent: I will push an update to ^^ soon with some refactoring10:22
gibicdent: removing duplicated code and better naming variables10:22
cdentgibi: are you up to date on the plan there? make it pass on current master, with expectations commented out, and then adjust it based on all the code jay’s been working.10:23
openstackgerritBalazs Gibizer proposed openstack/nova master: Test resize with placement api  https://review.openstack.org/48795810:23
gibicdent: yes, I read back10:23
cdentgo you10:23
gibicdent: what I did is that I update ps 14 on master with some refactoring10:24
gibicdent: also locally I moved top of the bugfix to see that confirm works with the uncommented asserts as well10:24
cdentthere was a hangout between dan and jay last night that went on for quite some time, I was only able to particpate for a short while. it was complicated.10:24
bauzascdent: I still need to understand the consensus now10:24
cdentbauzas: as far as I can tell there isn’t yet a consensus on a fix10:24
*** kristian__ has joined #openstack-nova10:25
bauzasokay10:25
bauzaslet's wait for the others10:25
cdentwe are aware of the problem and want to make it as visible as possible, thus the functional test going in first10:25
gibiexactly this is why I only did refactoring that does not impact whatwhever will be the fix for the bug10:25
*** chyka has joined #openstack-nova10:25
*** yamamoto has joined #openstack-nova10:25
cdentbauzas: in the conversations last night, each time a potential solution was discussed another problem was revealed10:27
bauzasheh10:27
*** slaweq_ has joined #openstack-nova10:27
cdentone idea that was well liked was that a migration/resize would have a second allocation with a different consumer id, instead of the doubling10:28
*** thorst_afk has joined #openstack-nova10:28
cdentbut that discussion exposed problems with migrations happening between ocata computes and pike computes10:28
bauzasshouldn't we buy https://www.amazon.com/Hasbro-40509-Whac-A-Mole-Game/dp/B0001GDP00 ?10:28
cdentprobably yes10:28
bauzasI see10:29
bauzasabout the 2nd consumer discussion10:29
cdentsdague: and now the launchpad emails are starting10:29
bauzashonestly, looks like a doubling allocation seems difficult10:29
bauzaswhen I provided my comment, I was just thinking of getting the original allocation and just passing it back in case of an exception10:29
*** chyka has quit IRC10:30
bauzasI didn't thought about all the other problems we could have :(10:30
sdaguecdent: yeh, I'm flushing the in progress bugs, it moves at least 25 out of in progress10:31
bauzassdague: I did that too10:31
*** markvoelker has joined #openstack-nova10:31
cdentbauzas: It’s good that we are talking this stuff out, because we don’t really have sufficient testing to find the bugs that we are creating (we need more gibi ) so applying brains is necessary. Each question, though annoying, is revealing something, and that’s better in the long run.10:32
*** thorst_afk has quit IRC10:32
bauzassdague: do we have jobs for resizing to a 2nd host ? I know that for live-migration, but I do wonder if we only verify resizes for the same host10:33
*** slaweq_ has quit IRC10:34
*** zenoway has joined #openstack-nova10:34
*** alexchadin has quit IRC10:35
*** sree has joined #openstack-nova10:35
*** alexchadin has joined #openstack-nova10:36
*** mdnadeem has quit IRC10:37
johnthetubaguybauzas: I think XenAPI already shrinks the disks when resizing down10:39
bauzasjohnthetubaguy: ack10:40
bauzasjohnthetubaguy: anyway, stopping to accept at the API level a resize down would probably need a microversion10:40
johnthetubaguycdent: when we chatted about this before, I remember we kinda liked the doubling up, are folks finding thats bad?10:40
johnthetubaguybauzas: I guess it should, although that's kinda removing a feature some folks use10:40
cdentjohnthetubaguy: we need the doubling up, the problem is that it is hard to manage the cleaning up afterwards10:41
bauzasjohnthetubaguy: exactly my point I wrote in the review10:41
johnthetubaguycdent: oh, I see what you mean now10:41
johnthetubaguycdent: would the migration uuid holding an allocation work, or mess things up totally for sync logic?10:41
bauzasjohnthetubaguy: either we say nova will stop supporting that for all drivers and then it requires a microversion, or we say it's per-driver and then we don't want to have the API verifying it10:41
johnthetubaguybauzas: I would rather the API new if the compute host could do it10:42
johnthetubaguyknew10:42
bauzasjohnthetubaguy: yeah, agreed, a capability10:43
cdentjohnthetubaguy: if there were a migration uuid, that would help, but there’s not, and getting access to it in the confirm_resize is weird (not sure I have all the details of this right, was very tired while listening to dan and jay last night)10:43
*** zenoway has quit IRC10:43
bauzascdent: we have a migration object, couldn't that help ? (well, for all migrations except live-mig :D)10:43
johnthetubaguycdent: oh, damm, did we never add that10:43
*** zenoway has joined #openstack-nova10:43
cdentjohnthetubaguy: that’s what dan and jay said :)10:43
cdent(the “oh damn”)10:43
johnthetubaguycdent: oh, thats correct, migration is completed before the confirm/revert phase I think10:43
bauzascdent: and FWIW we expose those migration objects to the API10:44
bauzass/FWIW/AFAIK10:44
johnthetubaguybauzas: in my head that was getting added as part of the cancel resize/migrate work10:45
*** trinaths has quit IRC10:45
openstackgerritSean Dague proposed openstack/nova master: Show quota detail when inject file quota exceeds  https://review.openstack.org/45304010:45
* johnthetubaguy shakes fist at pesky technical debt10:46
*** trinaths has joined #openstack-nova10:46
bauzasjohnthetubaguy: you mean os-migrations ?10:46
johnthetubaguybauzas: I think so10:46
* bauzas just opening the api-ref :)10:46
bauzasbut whatever, we haven't yet a migration object for live migrations :)10:46
johnthetubaguybauzas: can't remember if the additions merged now, I thought it was shared for both now10:47
bauzasmaybe we could just split nikola's patch in two and just at least add the migration object at first, before trying to claim10:47
johnthetubaguyanyways, not sure any of that helps10:47
sdaguebauzas: we run the resize tests in multihost I think10:47
bauzassdague: cool then10:48
sdaguebauzas: but I haven't looked that hard to verify10:48
bauzassdague: I can check10:48
* johnthetubaguy runs off for some lunch10:48
*** ygl has quit IRC10:49
cdentsdague, bauzas: we talked about that last night, and dan confirmed there are some, but the issue with them is that they don’t run in a constrained environment nor concurrent placements and don’t validate the allocations, so the fact that there isn’t yet doubling of allocations isn’t an issue because there’s spare capacity10:51
sdaguecdent: yeh, that makes sense10:52
*** iceyao has quit IRC10:52
sdaguehonestly, that's one of those things where doing the in tree functional testing with a couple of fake computes is probably the best way to flush it out10:52
cdentsdague: that’s what gibi’s new test does10:52
cdentso is very good to have10:52
sdaguecdent: does that still need review?10:52
bauzascdent: dan confirmed there are some what ?10:53
* bauzas is lost10:53
cdentbut I suspect that there are lots of edges that won’t get covered and in about 18 months we’ll see a lot of bugs from big deployments10:53
cdentbauzas: there are some resize tests10:53
cdentsdague: yes, it needs review, but I’m not sure how “done” it is: https://review.openstack.org/#/c/487958/10:54
bauzascdent: ah10:54
bauzascdent: yeah, I know that but I do wonder if we test those multihost10:54
cdentyes, multihost10:54
bauzasok10:54
*** saphi has quit IRC10:54
*** iceyao has joined #openstack-nova10:55
bauzascdent: I see your comment now, you mean those test exist but aren't really stress-testing at limits so we can't really verify capacity issues10:55
bauzastests*10:55
bauzasso, not a big deal for functional testing, but not for placement-specific concerns10:56
bauzasgotcha10:56
gibicdent, sdague: I'm still intended to understand and remove the last time.sleep(1) left in the setUp() of that tests as that is ugly and might not be necessary10:58
*** bkopilov_ has quit IRC10:58
*** iceyao has quit IRC11:00
*** prateek_ has joined #openstack-nova11:03
*** smatzek has joined #openstack-nova11:04
*** markvoelker has quit IRC11:05
openstackgerritMerged openstack/nova master: fix test_rebuild_server_exc instability  https://review.openstack.org/48738211:05
*** prateek has quit IRC11:05
*** alexchadin has quit IRC11:08
*** slagle has quit IRC11:08
gibiOK I think that sleep was only needed before the fake virt driver was updated to keep a local nodes copy and the periodic tasks was running every second11:08
gibithat two things together caused a race on setting the nodes of the fake virt driver11:09
*** edmondsw has joined #openstack-nova11:09
sdaguegibi: yeh, I just went through with a fine toothed comb there and provided some import11:09
sdagueinput11:09
gibisdague: thanks. checking...11:09
sdaguegibi: mostly also bringing fresh eyes of not being familiar with some of this, so some code restructure for clarity that might help as well11:10
gibisdague: sure, fresh eyes helps a lot11:11
*** alexchadin has joined #openstack-nova11:12
openstackgerritMerged openstack/nova master: Fix example in _serialize_allocations_for_consumer  https://review.openstack.org/48761411:12
*** edmondsw has quit IRC11:14
openstackgerritMerged openstack/nova master: rootwrap.d cleanup mislabeled files  https://review.openstack.org/48683111:16
*** yamamoto has quit IRC11:17
*** mamandle has quit IRC11:17
*** acormier has joined #openstack-nova11:20
*** alexchadin has quit IRC11:22
*** yangyapeng has joined #openstack-nova11:23
*** acormier has quit IRC11:25
*** sree has quit IRC11:28
*** tpatzig_ has joined #openstack-nova11:29
*** seife_ has joined #openstack-nova11:29
*** carthaca_ has joined #openstack-nova11:29
*** mkoderer_ has joined #openstack-nova11:29
*** sree has joined #openstack-nova11:30
sdaguegibi / cdent - https://review.openstack.org/#/c/48732711:30
*** gszasz has joined #openstack-nova11:30
*** markvoelker has joined #openstack-nova11:30
sdaguecan we fix wsgi_intercept instead?11:30
sdaguebecause if we don't pass those vars, people can't build their venvs11:31
*** seife_ has quit IRC11:31
*** tpatzig_ has quit IRC11:31
*** mkoderer_ has quit IRC11:31
*** carthaca_ has quit IRC11:31
*** yamamoto has joined #openstack-nova11:32
*** mamandle has joined #openstack-nova11:33
*** trinaths has quit IRC11:33
openstackgerritGábor Antal proposed openstack/nova master: Transform instance.rebuild_scheduled notification  https://review.openstack.org/47392911:34
gibisdague: I have an env that is behind proxy and I can build the env there without passing the PROXY wars11:35
gibisdague: But if this can be fixed in wsgi_intercept then I'm happy with that solution11:35
openstackgerritMerged openstack/nova master: Instance remains in migrating state forever  https://review.openstack.org/48391111:36
sdaguegibi: not everyone can - https://review.openstack.org/#/c/189569/11:36
sdagueit was added because without it people were blocked from running tests11:36
openstackgerritGábor Antal proposed openstack/nova master: Transform instance.rebuild_scheduled notification  https://review.openstack.org/47392911:37
sdagueunless tox itself changed since then11:37
jaypipescdent: morning.11:37
cdentsdague: I think tox has changed11:37
*** esberglu has joined #openstack-nova11:37
cdentit’s difficult to fix in the wsgi_intercept because of the way urllib3 manages proxy variables very early in its handling11:38
cdent(at least last time I checked)11:38
cdentjaypipes: morning11:38
jaypipescdent: unfortunately, trying to fix bug #1707071 has been excruciating. Looks like I'm going to need to go back to the drawing board and rewrite my patch pretty much from scratch.11:38
openstackbug 1707071 in OpenStack Compute (nova) "Compute nodes will fight over allocations during migration" [Medium,In progress] https://launchpad.net/bugs/1707071 - Assigned to Jay Pipes (jaypipes)11:38
cdentjaypipes: oh noes!11:38
sdagueok, so we need to figure out when it changed, because our minimum is 2.011:38
cdentsdague: i’ll look in the changelogs11:38
sdaguegibi: if you can confirm when tox changed, and bump the minimum at the same time, I'm +211:38
gibicdent: thanks for taking that11:39
gibisdague: good point11:39
sdagueI just don't want to break folks11:39
*** tetsuro has quit IRC11:39
cdentjaypipes: is there a crucial bit, or is it many things combined?11:39
*** thorst_afk has joined #openstack-nova11:40
*** efried has quit IRC11:40
cdentsdague, gibi: 2.1.0: http://tox.readthedocs.io/en/latest/changelog.html#id1211:41
*** prateek_ has quit IRC11:41
gibicdent: thanks! I will update the patch with the mimimum bump soon11:42
*** acormier has joined #openstack-nova11:42
*** esberglu has quit IRC11:42
*** pchavva has joined #openstack-nova11:42
jaypipescdent: the latter11:43
jaypipescdent: and the fact that we need to deal with Ocata computes migrating to Pike computes.11:43
cdentjaypipes: do you have an idea/plan or still cogitating? anything I can do to help?11:43
sdaguegibi: I can actually bump it if you like, you are working on more important patches11:43
jaypipescdent: not on this bug, no. but in debugging, I did notice that the aggregate refresh rate in the resource tracker/report client was super high. I know you'd submitted a bug on that (or related) some time ago. might be nice to look at reducing the number of those calls.11:44
openstackgerritSean Dague proposed openstack/nova master: do not pass proxy env variables by tox  https://review.openstack.org/48732711:44
sdaguegibi: fixed + approved11:45
openstackgerritMerged openstack/python-novaclient master: Remove run_tests.sh  https://review.openstack.org/48827611:46
cdentjaypipes: it’s on the cycle of the periodic job isn’t it? Or is it happening even more than that?11:46
jaypipescdent: it happens every time reportclient._ensure_resource_provider() runs11:47
jaypipescdent: so.. a lot.11:47
gibisdague: thanks a lot!11:47
cdentjaypipes: ah, okay, yeah. these days we do that even more. will poke.11:47
*** yamamoto has quit IRC11:49
openstackgerritMerged openstack/python-novaclient master: Update URLs in docs, comments and setup.cfg  https://review.openstack.org/48827111:51
*** litao__ has quit IRC11:51
*** lucasagomes is now known as lucas-hungry11:52
*** efried has joined #openstack-nova11:52
*** slagle has joined #openstack-nova11:53
*** hoonetorg has quit IRC11:54
openstackgerritMichael Still proposed openstack/nova master: Move execs of tee to privsep.  https://review.openstack.org/48943812:00
openstackgerritMichael Still proposed openstack/nova master: Read from console ptys using privsep.  https://review.openstack.org/48948612:00
*** _pewp_ has quit IRC12:02
*** kukacz has quit IRC12:02
*** kukacz has joined #openstack-nova12:03
*** _pewp_ has joined #openstack-nova12:05
*** claudiub has joined #openstack-nova12:06
*** hoonetorg has joined #openstack-nova12:06
*** tuanluong has quit IRC12:08
*** chyka has joined #openstack-nova12:11
*** acormier has quit IRC12:13
*** acormier has joined #openstack-nova12:14
*** chyka has quit IRC12:15
*** slagle has quit IRC12:17
*** acormier has quit IRC12:18
*** catintheroof has joined #openstack-nova12:20
*** thorst_afk has quit IRC12:22
*** udesale has joined #openstack-nova12:23
*** esberglu has joined #openstack-nova12:24
*** slagle has joined #openstack-nova12:25
openstackgerritBalazs Gibizer proposed openstack/nova master: Test resize with placement api  https://review.openstack.org/48795812:26
gibisdague: I've fixed your comments in https://review.openstack.org/48795812:27
*** mriedem has joined #openstack-nova12:27
*** lyan has joined #openstack-nova12:27
*** moshele has quit IRC12:29
*** mamandle has quit IRC12:29
*** slaweq_ has joined #openstack-nova12:31
*** liuyulong has joined #openstack-nova12:31
*** lyan_ has joined #openstack-nova12:31
*** cdent has quit IRC12:32
mriedemgibi: want to skip the notification meeting today?12:32
gibimriedem: I can chair it but I don't see any pressing issue to discuss12:33
gibimriedem: therefore I suggested to skip12:33
mriedemseconded12:34
gibimriedem: Should I send a second mail to the ML about the skip?12:34
*** lyan has quit IRC12:34
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata  https://review.openstack.org/47709112:34
mriedemgibi: up to you12:35
gibimriedem: then I won't. I don't think anybody besides you and me could be interested12:35
*** rmart04 has joined #openstack-nova12:36
*** slaweq_ has quit IRC12:36
*** edmondsw has joined #openstack-nova12:38
*** baoli has joined #openstack-nova12:39
*** esberglu has quit IRC12:39
*** links has quit IRC12:40
jaypipesgibi: gah. I was just in the process of reworking that resize tests...12:42
*** moshele has joined #openstack-nova12:42
*** moshele has quit IRC12:44
sdaguemriedem: ... http://logs.openstack.org/81/488381/3/experimental/gate-tempest-dsvm-cells-ubuntu-xenial/b5f4fa1/logs/devstacklog.txt.gz#_2017-08-01_10_56_05_959 ... oh cells munging hostnames12:45
sdaguecells v1 that is12:46
*** rmart04 has quit IRC12:46
sdaguewe should rename cells v1 to apoptosis12:47
*** mamandle has joined #openstack-nova12:47
*** amuresan has quit IRC12:47
*** slagle has quit IRC12:47
mriedemit's not deprecated yet12:47
mriedemcells v1 is alive and well12:47
sdaguealive... sure12:48
sdaguemriedem: we really haven't deprecated it yet?12:48
sdaguebecause it's definitely in freeze for everything bug critical fixes, it seems like deprecation should be a thing12:48
sdagueeven if we don't have a remove date12:48
*** lyan_ has quit IRC12:49
*** yamamoto has joined #openstack-nova12:49
*** ratailor has quit IRC12:50
*** lucas-hungry is now known as lucasagomes12:50
gibijaypipes: sorry for that. I read back and only see an opportunity to refactor but not that somebody already started that12:51
mriedemi'm +2 on gibi's test change12:52
mriedemsdague: yes i've been thinking about deprecating cells v1 before we release pike, in case we want to drop it in queens12:52
mriedemb/c we can't drop nova-network until we drop cells v1 and i don't want to lose another cycle on that12:53
*** lyan has joined #openstack-nova12:53
*** dave-mccowan has joined #openstack-nova12:54
jaypipesmriedem: hold up. I'm fixing up a couple more things.12:54
*** esberglu has joined #openstack-nova12:55
*** mriedem has quit IRC12:57
openstackgerritMerged openstack/nova master: provide interface-scoped nameserver information  https://review.openstack.org/46769912:57
*** thorst_afk has joined #openstack-nova12:57
*** yamamoto has quit IRC12:59
*** kylek3h has joined #openstack-nova13:01
*** kbaegis has joined #openstack-nova13:01
bauzasjaypipes: gibi: I'm confused by the current situation for reviewing, how can I help by looking at first?13:02
*** lyan has quit IRC13:02
jaypipesbauzas: please give me 15 mins to push up another patch on top of gibi's latest test resize patch13:03
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Read datapath_type from VIF object  https://review.openstack.org/47491413:03
*** gouthamr has joined #openstack-nova13:03
*** lyan has joined #openstack-nova13:04
bauzasjaypipes: okay13:04
bauzasjaypipes: I missed your convo yesterday with dan, hoping to understand more the issues13:04
*** mriedem has joined #openstack-nova13:06
*** kukacz has quit IRC13:06
mriedemhooray for neighborhood construction taking out all the power13:06
*** kukacz has joined #openstack-nova13:06
dimsmriedem : yikes13:07
*** acormier has joined #openstack-nova13:07
*** eharney has joined #openstack-nova13:08
openstackgerritMatt Riedemann proposed openstack/nova master: Don't warn on expected network-vif-unplugged events  https://review.openstack.org/46579413:09
*** iceyao has joined #openstack-nova13:09
jaypipesbauzas: you didn't miss much other than me getting super raging.13:10
*** mamandle has quit IRC13:11
*** acormier has quit IRC13:11
sdaguemriedem: https://review.openstack.org/#/c/487860/ that nova manage change, most of the urls you suggested in the test aren't valid urls13:13
*** yushb has joined #openstack-nova13:14
openstackgerritIldiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow  https://review.openstack.org/33028513:15
mriedemsdague: it's on the list13:15
sdaguemriedem: I also put a procedural hold on the privsep series once it started changing real things - https://review.openstack.org/#/c/459166/13:16
sdagueI assume that's about right for this point in the release13:16
mriedemyes13:16
*** sridharg has quit IRC13:17
*** sridharg has joined #openstack-nova13:18
*** sridharg has quit IRC13:18
*** yushb has quit IRC13:18
*** cjvolzka has joined #openstack-nova13:19
*** sridharg has joined #openstack-nova13:19
*** sridharg has quit IRC13:19
*** lucasxu has joined #openstack-nova13:20
*** sridharg has joined #openstack-nova13:20
*** bkopilov_ has joined #openstack-nova13:21
mriedemsdague: want to push this through? https://review.openstack.org/#/c/487932/ - i think what i'm hearing in there is we have to test it in prod13:22
mriedembut if it works, we have other redirects to add, like for the api microversion history stuff13:22
mriedemand those are just 2 that i know are broken, i don't know what else i don't know about13:23
openstackgerritMerged openstack/nova master: [placement] Add api-ref for RP traits  https://review.openstack.org/47455013:23
openstackgerritMerged openstack/nova master: doc: add FAQ entry for cells v1 config options  https://review.openstack.org/48793813:23
sdaguemriedem: looking13:24
openstackgerritMerged openstack/nova master: do not pass proxy env variables by tox  https://review.openstack.org/48732713:24
sdaguemriedem: yeh, +A13:24
sdaguewe can test those redirects out in production and get them fixed there13:24
mriedemstephenfin: are you going to update this? https://review.openstack.org/#/c/477497/13:25
mriedemstephenfin: i've identified some missing nova CLI guides from the admin guide that are missing in there13:25
*** mamandle has joined #openstack-nova13:25
openstackgerritJay Pipes proposed openstack/nova master: Test resize with placement api  https://review.openstack.org/48795813:25
openstackgerritJay Pipes proposed openstack/nova master: placement: remove existing allocs when set allocs  https://review.openstack.org/48927313:25
openstackgerritJay Pipes proposed openstack/nova master: remove source provider allocs in confirm_resize()  https://review.openstack.org/48851013:25
*** claudiub has quit IRC13:25
jaypipesmriedem, bauzas, gibi: I think you'll want to take a look at the changes I made to the test above. The tests now fail -- with no code changes -- indicating that the faulty assertions that supposedly were verifying the existing bad behaviour were incorrect.13:27
*** yangyapeng has quit IRC13:27
jaypipesmriedem, bauzas, gibi: specifically, after the changes to the test I made, the following fails:13:28
mriedemif you didn't change any function then why would they start failing?13:28
jaypipes1250         # NOTE(danms): This is bug 1707071 where we've lost the entire13:29
openstackbug 1707071 in OpenStack Compute (nova) "Compute nodes will fight over allocations during migration" [Medium,In progress] https://launchpad.net/bugs/1707071 - Assigned to Jay Pipes (jaypipes)13:29
jaypipes1251         # allocation because one of the computes deleted it13:29
jaypipes1252         self.assertEqual(0, dest_usages['VCPU'])13:29
jaypipesmriedem: because the test assertion was wrong.13:29
mriedemthen why wasn't it failing before?13:29
jaypipesmriedem: I believe because the test was incorrectly passing the source rp UUID when it was supposed to pass the dest rp UUID13:30
* gibi is looking13:31
mriedemjaypipes: so you did change something functional13:32
mriedemon which line?13:32
*** slaweq_ has joined #openstack-nova13:32
gibijaypipes: could you point out the faulty line in the test in the previous patchset, in 1252 seems worked the same way before than now13:32
*** cdent has joined #openstack-nova13:32
*** sridharg has quit IRC13:32
*** sridharg has joined #openstack-nova13:33
openstackgerritMerged openstack/nova master: add a redirect for the old cells landing page  https://review.openstack.org/48793213:33
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements  https://review.openstack.org/48960413:33
*** tiendc has quit IRC13:34
*** pchavva has quit IRC13:35
*** sridharg has quit IRC13:35
*** pchavva has joined #openstack-nova13:35
*** sridharg has joined #openstack-nova13:35
*** slaweq_ has quit IRC13:37
jaypipesgibi: your guess is as good as mine. :(13:37
jaypipesmriedem: I did not make any functional changes... :(13:38
*** hongbin has joined #openstack-nova13:38
* gibi is diggin13:38
cdentjaypipes, gibi : you two didn’t collide on your rebasing/patching of the test did you?13:38
jaypipesgibi, mriedem: the only thing I changes was not using this:13:38
jaypipesserver['OS-EXT-SRV-ATTR:host']13:38
mriedemjaypipes: ok, i don't know what you're saying then. you didn't make any changes, but things are failing, but they weren't before13:38
jaypipescdent: no, I rebased on a clean version from gibi13:39
jaypipesmriedem, gibi: I believe the problem is the original test was relying on server['OS-EXT-SRV-ATTR:host'] to get the server's host and determine what was the "source" or "target". That's incorrect though because that value changes over the course of the migration13:40
jaypipesso when I remove that and just use constants for the source and destination hostname (and rp UUIDs), the tests fails.13:40
mriedemsdague: did you see my comments in here about versioning https://review.openstack.org/#/c/467699/ ?13:41
jaypipesthis is also why I think dansmith was seeing non-deterministic issues with ordering.13:41
jaypipesbecause the server['OS-EXT-SRV-ATTR:host'] would change at different times in the migration sequence.13:41
*** jmlowe has joined #openstack-nova13:41
dansmithjaypipes: we got the host once at the beginning though13:42
*** kristian__ has quit IRC13:43
jaypipesdansmith: no... it was grabbed again on previous line 1215 in gibi's new _resize_and_check_allocations()13:43
*** kristian__ has joined #openstack-nova13:43
*** sridharg has quit IRC13:44
*** sridharg has joined #openstack-nova13:44
*** liuyulong has quit IRC13:45
jaypipesdansmith: well, it wasn't "grabbed again"... just read again from the server dict. but the server dict is passed to the _wait_for_status() thing. perhaps that dict is modified?13:45
dansmithjaypipes: that function wasn't there when Ilast pushed13:45
jaypipesdansmith: I know, it was gibi's overnight refactor.13:45
jaypipesbut the basic premise remains.13:45
dansmithjaypipes: I don't think it does,13:46
dansmithbecause we pulled host, even saved it in original_host,13:46
dansmithand used the provider uuids once13:46
dansmiththat was mriedem's early comment13:46
jaypipesdansmith: no, I'm right. bingo. The server parameter to _wait_for_state_change() is modified **in-place** and replaced with the returned value from the GET call.13:46
jaypipesdansmith: and that is why server['OS-EXT-SRV-ATTR:host'] changes value.13:47
jaypipes        while True:13:47
jaypipes225             server = admin_api.get_server(server['id'])13:47
dansmithoh you're right, so I should just stop looking then eh?13:47
gibijaypipes: can it be that your refactring changed what host order we skip and what host order we test now?13:47
jaypipeswell, I need food and more caffeine. will tackle this further when returning.13:47
mriedemdan's point was with the way the test was written about 16 hours ago,13:48
mriedemeverything was monolithic,13:48
mriedemand we stored the source host right up front13:48
jaypipesgibi: no, my refactoring removed the use of server['OS-EXT-SRV-ATTR:host'] to get the resource provider UUIDs. that server['OS-EXT-SRV-ATTR:host'] changes over the course of the migration resulting in the wrong compute host being returned13:48
dansmithjaypipes: right and that change is wrong13:49
dansmithassuming that the rp uuid of the host we asked for is where it actually is is assuming too much, IMHO13:49
mriedemhttps://review.openstack.org/#/c/487958/14/nova/tests/functional/test_servers.py13:49
jaypipesdansmith: huh?13:49
gibiinterestingly if I set dest_hostname to host1 in the confirm test it passes13:49
jaypipesgibi: and that is incorrect.13:49
mriedemhttps://review.openstack.org/#/c/487958/14/nova/tests/functional/test_servers.py@116813:49
openstackgerritJacek Tomasiak proposed openstack/nova master: ironic: Use internal API endpoint  https://review.openstack.org/48953713:50
mriedemas of last night (me and dan time), we got the source host once at the beginning13:50
dansmithjaypipes: I left a comment. However, I'm wrong and you're right, so I'm getting coffee and a bagel13:50
*** liverpooler has joined #openstack-nova13:50
jaypipesdansmith: ditto.13:50
mriedemdon't make me quote rodney king13:51
*** cleong has joined #openstack-nova13:51
sdaguemriedem: apparently not, I didn't see any -1s on it.13:52
cdentI often, in cases like this, wish we had to write new commits each time we pushed to gerrit13:52
*** sridharg has quit IRC13:53
*** sridharg has joined #openstack-nova13:53
*** gbarros has quit IRC13:53
*** ijw has joined #openstack-nova13:54
mriedembauzas: i'm not sure why this is pike-rc-potential https://bugs.launchpad.net/nova/+bug/170245413:54
openstackLaunchpad bug 1702454 in OpenStack Compute (nova) "Transforming the RequestSpec object into legacy dicts doesn't support the requested_destination field" [High,In progress] - Assigned to Sylvain Bauza (sylvain-bauza)13:54
mriedemit's not a regression in master, it's a latent issue in stable right?13:55
bauzasmriedem: yup, like I said "As a consequence, the feature to pass a destination for evacuation is not working in Newton and Ocata. "13:55
bauzasmriedem: I'd love to see it merged for Pike so we could backport it 'til Newton13:55
bauzasif not, it would be a bit difficult to backport it13:56
mriedemwhy?13:56
mriedempike GA != newton phase 313:56
mriedembauzas: so how about writing a functional regression test for https://review.openstack.org/#/c/481116/ then ?13:56
mriedembecause anything involving the request spec getting passed around 3 different services should have a functional test13:57
*** sridharg has quit IRC13:57
bauzasmriedem: for evacuating ?13:57
bauzasmriedem: not sure it would work for a functional test13:57
mriedemi've been wanting to write a functional test for evacuate for a long time,13:58
mriedemi don't think it would be that hard13:58
*** gszasz has quit IRC13:58
bauzasmriedem: about why Pike, because https://docs.openstack.org/project-team-guide/stable-branches.html#support-phases13:58
*** sridharg has joined #openstack-nova13:58
mriedemyou start 2 services, create server on one, force it down and evacuate13:58
bauzasmriedem: I can try13:58
mriedemhttps://releases.openstack.org/13:59
*** chyka has joined #openstack-nova13:59
mriedemPhase III – Legacy release on 2017-10-0913:59
mriedemyou have 5 weeks to make it happen :)13:59
bauzasokay okay :)13:59
*** yushb has joined #openstack-nova13:59
bauzasmriedem: just remove the pike-potential tag and I'll try to provide a functional test14:00
*** kukacz_ has joined #openstack-nova14:00
bauzasmriedem: but then, I'll harass you :p14:00
* bauzas jk :p14:00
mriedemexcept !jk14:00
gibibauzas: there is example evacuate test in the server_group functional test I think14:00
*** gbarros has joined #openstack-nova14:00
bauzasgibi: maybe, I'll look :)14:01
*** kukacz__ has joined #openstack-nova14:01
mriedembauzas: keep in mind, the way we do the functional regression tests is a 2 patch process,14:01
gibibauzas: https://github.com/openstack/nova/blob/master/nova/tests/functional/test_server_group.py#L41214:01
mriedemthe first writes the test recreating the bug,14:01
mriedemasserting the failure,14:01
mriedemthe 2nd patch fixes the bug14:01
mriedemand adjusts the test14:01
bauzasthe functional server groups tests just do a lot so I'm not remembering if it's also calling evacuate :p14:01
*** kukacz has quit IRC14:01
bauzasmriedem: yup, I know, no worries14:01
bauzasI did reviewed a few of you :p14:01
gibibauzas: also a notification sample test with evacuate is up on review https://review.openstack.org/#/c/482148/3/nova/tests/functional/notification_sample_tests/test_instance.py14:02
mriedemi know, quotas things14:02
gibibauzas: this one is better as it uses force_down14:02
bauzasthanks gibi :)14:03
mriedembauzas: i also don't think https://bugs.launchpad.net/nova/+bug/1678056 is pike-rc-potential14:03
openstackLaunchpad bug 1678056 in OpenStack Compute (nova) "RequestSpec records are never deleted when destroying an instance" [High,In progress] - Assigned to Sylvain Bauza (sylvain-bauza)14:03
mriedemrequest specs not getting deleted is a latent issue14:03
bauzassame problem14:03
bauzassame situation14:03
*** chyka has quit IRC14:03
*** sridharg has quit IRC14:03
bauzaswe have that since we persisted the Requestspec records14:03
mriedemsure, but it's not a pike blocker14:04
bauzasso that's not really a regression14:04
mriedemit's latent14:04
bauzasbut AFAIK I thought RC1 was not only for regressions :)14:04
*** sridharg has joined #openstack-nova14:04
bauzasRC2 and others yup so14:04
*** lbragstad_ is now known as lbragstad14:04
*** crushil has joined #openstack-nova14:04
mriedempike-rc-potential is not your personal wishlist of bugs for review :)14:04
*** kukacz_ has quit IRC14:05
bauzasanyway, seems I agreed to remove pike-rc-potential for the former, I'm okay to remove that tag for the latter :)14:05
mriedemyup, done14:05
*** kristia__ has joined #openstack-nova14:05
mriedemi'm just working on my etherpad of stuff to do for rc114:05
mriedemso that's why i'm being harsh on these tagged bugs14:05
bauzasno worries14:05
mriedemand as a result i'm taking it out on you14:05
*** slaweq has quit IRC14:05
bauzasyup, I understand14:05
bauzasno worries again14:05
bauzasI just want to make sure we don't forget them14:06
mriedemi could never forget the wasteland that is request spec bugs :)14:06
bauzasand since we were working on features during last milestones, I'll ping a few of us during those weeks14:06
mriedem^ not sure what you mean there14:06
mriedemyou mean you held off on pinging people for bug reviews b/c of working on closing out features?14:07
bauzasexacrlt14:07
mriedemok14:07
bauzasexactly14:07
bauzasnow, it's time for asking to review bugs14:07
bauzasof course, regressions first, totally agreed14:07
mriedemgmann: alex_xu: do you know if patches were put up for modifying the api plugins and stable api docs pages for the new routes stuff?14:08
*** kukacz__ has quit IRC14:08
*** kristian__ has quit IRC14:08
*** mamandle has quit IRC14:09
*** awaugama has joined #openstack-nova14:09
*** markus_z has quit IRC14:13
*** sridharg has quit IRC14:15
*** jamesden_ has joined #openstack-nova14:15
*** sridharg has joined #openstack-nova14:16
*** jamesdenton has quit IRC14:18
openstackgerritSpencer Yu proposed openstack/python-novaclient master: Nova client should retry with Retry-After value  https://review.openstack.org/44776614:20
*** sridharg has quit IRC14:20
*** dfisher has joined #openstack-nova14:20
*** sridharg has joined #openstack-nova14:22
*** sridharg has quit IRC14:23
openstackgerritJackie Truong proposed openstack/nova master: Add trusted_certs to instance_extra  https://review.openstack.org/45771114:23
*** sridharg has joined #openstack-nova14:24
mriedemmelwitt: we should update this doc for counting quotas https://docs.openstack.org/nova/latest/user/quotas.html14:25
*** udesale has quit IRC14:26
*** hshiina has quit IRC14:27
*** lucasxu has quit IRC14:27
*** marst_ has quit IRC14:28
*** sridharg has quit IRC14:30
*** sridharg has joined #openstack-nova14:31
*** eharney has quit IRC14:33
gibijaypipes, dansmith: sorry for being stubborn but I still not get it. The only difference I see in the logs between ps17 and ps18 is that in ps17 server booted on host2 and then moved to host1 while in ps18 it is booted on host1 and moved to host214:33
*** slaweq has joined #openstack-nova14:33
*** trinaths has joined #openstack-nova14:33
openstackgerritMatt Riedemann proposed openstack/nova master: Add release note for PUT /os-services/* for non-compute services  https://review.openstack.org/48962114:33
*** slaweq has quit IRC14:33
*** trinaths has left #openstack-nova14:33
gibijaypipes, dansmith: and as the periodic tasks runs in the same order in both patch sets the two patch sets test two different scenari14:34
*** marst has joined #openstack-nova14:35
dansmithgibi: tbh I haven't looked at the later ones in detail.. as I said on the review, I think we should revert back to PS14 and roll on, but I'm not sure if there was a reason for the refactor14:35
*** slaweq has joined #openstack-nova14:35
*** slaweq_ has joined #openstack-nova14:36
gibidansmith: the refactor was only for reduce duplication and increase readability by better naming14:37
*** sridharg has quit IRC14:37
gibidansmith: I think 14 and 17 executes the same scenario but 18 executes a different one (different move direction)14:37
dansmithgibi: well, like I said, the duplication in the test makes it _more_ readable IMHO, even if a bit wasteful14:38
dansmithgibi: agree we could have improved the naming a bit though14:38
*** sridharg has joined #openstack-nova14:38
*** slagle has joined #openstack-nova14:39
*** tbachman has joined #openstack-nova14:39
*** trinaths has joined #openstack-nova14:39
jaypipesgibi: yeah, as I walked to get breakfast I realized you are correct14:39
*** slaweq_ has quit IRC14:40
* mriedem imagines jay walking down a cavernous hallways for his lucky charms14:40
* cdent never wants to see that image again14:41
openstackgerritJay Pipes proposed openstack/nova master: Test resize with placement api  https://review.openstack.org/48795814:42
openstackgerritJay Pipes proposed openstack/nova master: placement: remove existing allocs when set allocs  https://review.openstack.org/48927314:42
openstackgerritJay Pipes proposed openstack/nova master: remove source provider allocs in confirm_resize()  https://review.openstack.org/48851014:42
jaypipesdansmith, gibi, mriedem: ok, good to go now ^^14:42
jaypipesfor the test resize patch at least14:42
*** psachin has quit IRC14:42
*** cfriesen_ has joined #openstack-nova14:42
jaypipesdansmith, gibi, mriedem: now I go back to trying to actually fix the bug 170707114:43
openstackbug 1707071 in OpenStack Compute (nova) "Compute nodes will fight over allocations during migration" [Medium,In progress] https://launchpad.net/bugs/1707071 - Assigned to Jay Pipes (jaypipes)14:43
gibidansmith, jaypipes: then I guess we are not bringing back the duplications by inlining  util functions I introduced14:44
jaypipesgibi: I think what you did made the test easier to read and consume.14:46
jaypipesgibi: I know dansmith disagrees a bit, though14:46
*** sridharg has quit IRC14:46
jaypipesbut dansmith is a disagreeable man.14:47
*** ekuris has quit IRC14:47
jaypipeswho requires a constant IV drop of caffeine to agree with anything.14:47
jaypipesis it Friday yet?14:47
*** sridharg has joined #openstack-nova14:48
cdentsoon, jaypipes. soon14:48
jaypipeshehe14:48
mriedemhttps://images-na.ssl-images-amazon.com/images/I/51S%2BpPtReeL._AC_UL320_SR228,320_.jpg14:48
*** eharney has joined #openstack-nova14:48
mriedemor https://s-media-cache-ak0.pinimg.com/originals/49/d7/a0/49d7a0676e7945b3fb7bcf4c4533fd99.jpg14:49
sdaguegibi: honestly, on the test front, duplication is not a bad thing. You are trying to understand individual test functions in their own context, and if you have to chase a bunch of common code, it's a lot harder to put the state in your head14:49
*** gszasz has joined #openstack-nova14:50
gibisdague: I have no firm oppinion I think for me the usefullness of deduplication depends on how well I can trust the utility function to do what it promise14:52
*** chyka has joined #openstack-nova14:53
*** annegentle has joined #openstack-nova14:53
dansmithsdague: exactly14:53
gibisdague: to build that trust during review I guess I inline the utils in my head at the first usage but then later I just trust them14:53
*** annegentle has quit IRC14:54
*** annegentle has joined #openstack-nova14:55
openstackgerritJay Pipes proposed openstack/nova master: Test resize with placement api  https://review.openstack.org/48795814:57
openstackgerritJay Pipes proposed openstack/nova master: placement: remove existing allocs when set allocs  https://review.openstack.org/48927314:57
openstackgerritJay Pipes proposed openstack/nova master: remove source provider allocs in confirm_resize()  https://review.openstack.org/48851014:57
jaypipesdansmith: made those changes you pointed out in the review ^^14:57
*** chyka has quit IRC14:57
*** vladikr has quit IRC14:58
openstackgerritkhushbu parakh proposed openstack/nova master: Closes-Bug: #1454515  https://review.openstack.org/48894114:58
openstackbug 1454515 in OpenStack Compute (nova) "Property "instance.disable_terminate" is always "False" and never actually used." [Low,In progress] https://launchpad.net/bugs/1454515 - Assigned to Khushbuparakh (khushbuparakh)14:58
sdaguegibi: right, but that's because you are familiar with them. People reading tests will not be, so it takes longer to understand what is going on if they also need to digest utils14:59
*** acormier has joined #openstack-nova15:01
*** sridharg has quit IRC15:02
*** jamesden_ has quit IRC15:02
*** felipemonteiro has joined #openstack-nova15:02
*** sridharg has joined #openstack-nova15:02
*** acormier_ has joined #openstack-nova15:03
*** Oku_OS is now known as Oku_OS-away15:04
*** sridharg has quit IRC15:04
*** acormier has quit IRC15:05
*** jamesdenton has joined #openstack-nova15:05
*** sridharg has joined #openstack-nova15:05
dfisherok, i'm still struggling trying to get a compute node talking to a devstack rig.  What services need to be running on the compute node?  Obviously nova-compute but what else?15:05
dfisherthis is all with beta315:06
dfishernova service-list sees my compute node, but cell_v2 discover_hosts can't find it15:06
gibisdague: sure, there is an overhead due to the extra indirection until the reader gets familiar with the utils but after that it is a lot easier to read the deduplicated code (not to mention chaging it)15:07
*** sridharg has quit IRC15:07
jaypipesgibi, dansmith, mriedem, cdent: for the record, I was wrong, dansmith and gibi were right. sorry that I jumped the gun.15:07
mriedemdfisher: what does nova-manage cell_v2 list_cells show?15:07
mriedemdo you have a cell0 and cell1?15:07
*** josecastroleon has joined #openstack-nova15:07
*** mkucia has quit IRC15:07
* cdent bows to jaypipes 15:07
jaypipesgibi, dansmith, mriedem, cdent: and I did not mean to shut anyone down. I just thought I'd figured out the issue15:07
dfishermriedem: yes.  I have both cell0 and cell115:07
*** sridharg has joined #openstack-nova15:08
cdentjaypipes: I’ll have a aggregate map WIP up shortly15:08
jaypipescdent: cool, thanks.15:08
openstackgerritMatt Riedemann proposed openstack/nova master: Deprecate cells v1  https://review.openstack.org/48963215:08
gibijaypipes: you made me think for a while, but I like these mental challenges so no worries15:08
sdaguedfisher: what versions of devstack code do you have?15:08
dansmithdfisher: and cell1 points to the same transport and db url as the config for the conductor and the compute?15:08
mriedemdfisher: and does the transport_url for cell1 match the transport_url in nova.conf on the compute node?15:08
dfishersdague: git pull'd as of yesterday15:08
*** felipemonteiro has quit IRC15:08
mriedemdfisher: you can see the transport_url for cell1 by using --verbose with the list_cells command15:08
dfisherdansmith/mriedem: hang on, checking...15:09
*** vladikr has joined #openstack-nova15:09
mriedemdansmith: sdague: here is the cellsv1 deprecation https://review.openstack.org/48963215:09
dansmithdfisher: this is what I asked you yesterday fwiw :)15:09
dfisherI know.  I'm thick :(15:09
jaypipesgibi: no, I feel bad because I didn't see dansmith's comment above "oh you're right, so I should just stop looking then eh?". I didn't mean to shut him down.15:09
sdaguemriedem: ++15:10
dfisherdansmith: i apologize but I didn't understand you meant the transport_url15:11
dfisherdansmith: you said, "dfisher: make sure your conductor's config is pointed at the cell1 db, matching the cell1 cell_mapping record"15:12
dansmithdfisher: yesterday or now?15:12
dfisherdansmith: and I thought you meant the database connection string :(15:12
dfisheryesterday15:12
dfisherok, so with the transport_url set right, i'm in business15:12
dansmithdfisher: well, it's a little of both15:12
dfisherthank you all.15:12
dansmithdfisher: cool15:12
mriedemlittle bit country? little bit rock&roll?15:12
mriedemdfisher: we could put something in https://docs.openstack.org/nova/latest/user/cells.html#faqs for your ase15:13
mriedem*case15:13
*** sridharg has quit IRC15:14
*** rcernin has quit IRC15:14
*** sridharg has joined #openstack-nova15:14
mriedemby we i think i mean you15:14
*** chyka has joined #openstack-nova15:16
*** sridharg has quit IRC15:16
*** sridharg has joined #openstack-nova15:17
openstackgerritChris Dent proposed openstack/nova master: WIP Update RT aggregate map less frequently  https://review.openstack.org/48963315:18
*** sridharg has quit IRC15:18
sdaguedfisher: ok, it would be good to figure out where that went wrong15:19
sdaguebecause devstack should be setting it up correctly on both controller and compute15:19
*** sridharg has joined #openstack-nova15:19
sdagueand if something is falling through, would be good to fix15:19
mriedemsdague: i assume dfisher is doign multinode15:19
mriedemw/o devstack-gate15:19
sdaguemriedem: sure15:19
sdaguebut the only thing in d-g is the discover_hosts15:20
openstackgerritJay Pipes proposed openstack/nova master: Test resize with placement api  https://review.openstack.org/48795815:20
openstackgerritJay Pipes proposed openstack/nova master: placement: remove existing allocs when set allocs  https://review.openstack.org/48927315:20
openstackgerritJay Pipes proposed openstack/nova master: remove source provider allocs in confirm_resize()  https://review.openstack.org/48851015:20
cdentjaypipes: that patch above does what I think we’re after ^ but needs some reactions and tweaks. gonna get lunch and then will check back15:20
jaypipescdent: cheers15:20
mriedemsdague: d-g also sets up the local.conf for the subnodes doesn't it?15:20
mriedemotherwise you'd have n-api in enabled_services15:20
cdentbbs15:20
*** sridharg has quit IRC15:20
sdaguemriedem: yeh, but I didn't think we had cells specific logic there15:20
*** vladikr_ has joined #openstack-nova15:20
sdagueI'd like devstack multinode without d-g to work for folks15:21
*** vladikr has quit IRC15:21
*** cdent has quit IRC15:21
*** iceyao has quit IRC15:21
mriedemsdague: there is conditional logic in devstack to know if it's a subnode or not based on n-api running15:21
mriedemis my point15:21
*** sridharg has joined #openstack-nova15:21
*** pcaruana has quit IRC15:22
sdaguemriedem: yeh15:22
*** sridharg has quit IRC15:22
sdaguedfisher: anyway, if you have suggestions on how to make this more clear and straightforward to setup on the devstack side, let me know15:23
dfishersdague: just mention that the transport_url on the compute node needs to match the cell1 transport_url15:23
dfisherthat's all you need.15:23
*** sridharg has joined #openstack-nova15:23
dfisherand, again, thank you sdague, mriedem, and dansmith for putting up with dumb questions from the peanut gallery15:24
*** kbaegis has quit IRC15:24
*** kbaegis has joined #openstack-nova15:24
gibijaypipes, dansmith: I have one more question at https://review.openstack.org/#/c/487958/21/nova/tests/functional/test_servers.py@137015:24
sdaguedfisher: any idea where that should be mentioned that it would be more obvious?15:25
*** damien_r has left #openstack-nova15:25
*** sridharg has quit IRC15:25
dfishersdague:15:25
dfisher1.Configure and start your compute hosts. Before step 7, make sure you have compute hosts in the database by running nova service-list --binary nova-compute.15:25
dfishergah.  that should be #615:25
*** sridharg has joined #openstack-nova15:26
dfishermaybe something like:  'Configure your compute node's transport_url to point to the cell1 transport_url (visible with nova-manage cell_v2 list_cells —verbose) and start the nova-compute service'15:27
jaypipesgibi: that's concerning to me. I can't explain why that would be. :(15:27
*** kbaegis1 has joined #openstack-nova15:28
*** sridharg has quit IRC15:28
*** sridharg has joined #openstack-nova15:29
gibijaypipes: sorry I pointed to the wrong assert it fails the assert 'self.assertEqual(0, len(allocations))'15:29
mriedemdfisher: step 5 says, "The transport url is taken from the [DEFAULT]/transport_url setting in the Nova configuration file if not specified on the command line." - which would assume that if you created cell1 with a transport_url from the config file, you'd be using that same config file on the compute service if you have a single MQ15:29
*** claudiub has joined #openstack-nova15:29
mriedemdfisher: devstack is a bit different now in that by default there are 2 conductors15:30
mriedemwhat you suggest isn't a bad reminder though15:30
* dfisher nods15:31
*** kbaegis has quit IRC15:31
*** sridharg has quit IRC15:31
mriedemdfisher: did you want to push a change to adjust that part of the docs?15:32
bauzasoh man, my computer crashed15:32
mriedembauzas: it didn't crash, it's on french government mandated PTO15:32
*** sridharg has joined #openstack-nova15:32
bauzas(says the one who uses AndChat)15:32
mriedemhence the smoke15:32
jaypipesgibi: I believe there should be a *separate* assertion above line 1370 that shows we have the correct allocation after CONFIRM_RESIZE but after the periodics run, that allocation is messed up. I think that's what dansmith was going for there.15:32
dfisherI can.  Not sure how, however.  That and me no word good.15:32
bauzasmriedem: it's a trap15:33
mriedemdfisher: have you ever pushed a change to review.openstack.org?15:33
dfisheryep.15:33
dansmithisn't dfisher from oracle?15:33
*** kbaegis1 has quit IRC15:33
dfisherthat's me15:33
* dfisher ducks15:33
dansmithhe might burst into flame if he pushes a patch15:33
dansmithso we should probably do it for him15:33
dfisher:(15:33
*** kbaegis has joined #openstack-nova15:33
*** zz_dimtruck has quit IRC15:33
mriedemdfisher: http://git.openstack.org/cgit/openstack/nova/tree/doc/source/user/cells.rst#n391 is the line you want15:33
* dfisher nods15:34
dfisheron it.15:34
gibijaypipes: make sense15:34
jaypipesgibi: I'll add that assertion.15:34
gibijaypipes: thanks15:34
*** crushil has quit IRC15:35
dfisherdansmith: i'll let you know if you if any parts of me (fleshy or ethereal) start to smoke as I work on this15:35
*** sree has quit IRC15:35
*** lpetrut_ has quit IRC15:36
dansmithdfisher: I'll stand by with a fire extinguisher15:36
*** armax has quit IRC15:36
*** lpetrut has joined #openstack-nova15:36
*** sree has joined #openstack-nova15:36
dfishereven though I'm an Oracle employee? :)15:36
mriedemsdague: redirect works https://docs.openstack.org/nova/latest/cells.html15:36
dansmithdfisher: you're still a human...15:36
dansmithdfisher: um, right?15:36
* dfisher hisses15:36
gibijaypipes: would it make sense if I start building some more funcitonal tests top of the your bug fix to see further ahead?15:36
dansmithheh15:37
mriedemgibi: yes we want a single node functional set of tests for resize confirm/revert15:37
mriedemresize to same host15:37
openstackgerritMatthew Booth proposed openstack/nova master: fake_notifier: allow waiting on either notification type  https://review.openstack.org/48963715:37
dfisheras a Denver resident I can suggest places to eat (and not to eat) for the PTG15:37
mriedemgibi: that's going to be needed for this bug https://bugs.launchpad.net/nova/+bug/170725215:37
jaypipesgibi: not at this time, I don't think so.15:37
openstackLaunchpad bug 1707252 in OpenStack Compute (nova) "Claims in the scheduler does not account for doubling allocations on resize to same host" [Medium,Confirmed]15:37
dfisheri can trade that for fire-putting-outting, maybe15:37
*** kbaegis has quit IRC15:38
mdboothmriedem: Incidentally, I now have a patch on top of gibi's patch, but because it also has another dependency I can't push it15:38
mdboothAny chance we could keep the scope of gibi's patch small so it can merge soon?15:38
mdboothAnd add more later.15:39
gibimdbooth: If you are refering to https://review.openstack.org/#/c/487958/ then I think that patch is pretty close to land15:39
mriedemmdbooth: i was assuming any new tests would be built on top15:39
mdboothgibi: Yep, that's the one.15:40
*** sridharg has quit IRC15:40
*** pcaruana has joined #openstack-nova15:40
mdboothmriedem: Excellent, just checking.15:40
mriedemmdbooth: believe me, i'd like to see that test patch land asap15:40
gibimdbooth: I think that patch will not grow further15:40
*** kbaegis has joined #openstack-nova15:40
mdboothgibi: Now could you land it in the next 10 minutes? ;)15:40
gibimdbooth: I have no power over it ;)15:40
*** armax has joined #openstack-nova15:40
*** sree has quit IRC15:40
*** sridharg has joined #openstack-nova15:41
mdboothI have your patch stashed in the middle of my own series, so I need to be really careful not to submit it!15:41
*** andreas_s has quit IRC15:41
*** sridharg has quit IRC15:42
gibimdbooth: to be clear it is not my patch, it is shared at least between jaypipes, dansmith, cdent and myself. Just to make it easy ;)15:43
*** eharney_ has joined #openstack-nova15:43
gibimriedem: so I'm not committing myself to start the resize to same host today, but if nobody starts that until I wake up tomorrow then I will stat15:43
gibimriedem: s/stat/start/15:44
mriedemgibi: ok i might start that today15:44
openstackgerritMatt Riedemann proposed openstack/nova master: Add redirect for api-microversion-history doc  https://review.openstack.org/48964115:44
gibimriedem: ping me when you start to avoid double work15:45
mriedemaye aye15:45
* gibi now sees the power of distributed development timezones15:46
*** annegentle has quit IRC15:46
mriedemfyi, also sent to the ML https://etherpad.openstack.org/p/nova-pike-release-candidate-todo15:46
*** eharney has quit IRC15:46
*** kbaegis has quit IRC15:47
*** eharney_ is now known as eharney15:48
openstackgerritDrew Fisher proposed openstack/nova master: Add language for compute node configuration  https://review.openstack.org/48964315:48
* dfisher combusts15:48
*** annegentle has joined #openstack-nova15:49
*** rcernin has joined #openstack-nova15:49
openstackgerritJay Pipes proposed openstack/nova master: Test resize with placement api  https://review.openstack.org/48795815:49
openstackgerritJay Pipes proposed openstack/nova master: placement: remove existing allocs when set allocs  https://review.openstack.org/48927315:49
openstackgerritJay Pipes proposed openstack/nova master: remove source provider allocs in confirm_resize()  https://review.openstack.org/48851015:49
*** hamzy has quit IRC15:49
jaypipesgibi: done.15:50
gibijaypipes: looking15:51
*** zenoway has quit IRC15:51
*** yushb has quit IRC15:53
*** cdent has joined #openstack-nova15:53
*** iceyao has joined #openstack-nova15:54
dansmithdfisher-cinder: sorry, I was distracted while you were exploding15:54
sdaguemriedem: woot, now we just need to figure out what other redirects are needed15:55
*** crushil has joined #openstack-nova15:55
mriedemsdague: basically everything15:55
mriedemplacement, vendordata, everything has changed15:55
mriedemapi microversion history15:55
mriedemi'm in -doc15:55
*** iceyao has quit IRC15:58
*** Apoorva has joined #openstack-nova16:00
gibijaypipes: looks good to me16:00
*** lpetrut has quit IRC16:03
*** lucasxu has joined #openstack-nova16:04
* gibi is signing off for today16:06
bauzasmriedem: have time for a quick question about https://bugs.launchpad.net/nova/+bug/1702454 ?16:06
openstackLaunchpad bug 1702454 in OpenStack Compute (nova) "Transforming the RequestSpec object into legacy dicts doesn't support the requested_destination field" [High,In progress] - Assigned to Sylvain Bauza (sylvain-bauza)16:06
bauzasmriedem: given it works for Pike but not Newton and Ocata, the regression test would be different between stable changes and the master change16:07
bauzasmriedem: doesn't that look a bit weird ?16:07
bauzasmriedem: tbc, I'll be testing that if you have 2 hosts (A, B) with A as a target for the instance, it would provide a NoValidHost if A is not accepting it16:08
*** claudiub has quit IRC16:08
bauzasmriedem: that would be for the fix16:09
bauzasmriedem: and without the fix (in Ocata and N) it would just provide B as instance.host16:09
bauzasor at least accepting to evacuate16:09
bauzassee my problem ?16:09
bauzasthe cherry-pick change would be different16:10
openstackgerritDan Smith proposed openstack/nova master: Add some more cellsv2 doc goodness  https://review.openstack.org/48718316:10
mriedembauzas: do we have a fix to make in pike at all?16:10
bauzasmriedem: so, only a stable change ?16:10
bauzasI'm confused16:11
bauzaslike I said in the bug report, the bug was fixed implicitly by https://review.openstack.org/#/c/469037/ but we can't just backport it16:11
mriedembauzas: if it's fixed on master, then yes it's a stable only change16:12
bauzasokay, lemme upload then and we'll discuss16:12
*** links has joined #openstack-nova16:12
mriedemunless you just write the regression test for master but no fix16:12
mriedemas you said, the backport of the test would be weird16:13
*** lyan has quit IRC16:14
bauzasanyway, looks difficult to discuss unless I'm uploading it16:15
bauzasso I'll do16:15
* bauzas just needs to bailout because $wife + $ikea 16:15
*** mvensky has quit IRC16:16
mriedemdoes that mean sylvain's wife is variable?16:18
openstackgerritSean Dague proposed openstack/nova master: add redirects for existing broken docs urls  https://review.openstack.org/48965016:18
sdaguemriedem: ^^^16:18
sdaguemriedem: also, here are real 404s from today, which include stuff going way back - http://paste.openstack.org/show/617142/16:18
bauzasmriedem: oh oops, WIFE + $idea16:18
bauzas$ikea even16:18
mdboothmriedem: *potentially* variable. In practise it may not actually be modified after assignment.16:18
*** vishwana_ has quit IRC16:18
*** vishwanathj has joined #openstack-nova16:19
mriedemsdague: can those tabs be fixed?16:19
sdaguemriedem: sure16:19
openstackgerritDan Smith proposed openstack/nova master: Add some more cellsv2 doc goodness  https://review.openstack.org/48718316:20
openstackgerritSean Dague proposed openstack/nova master: add redirects for existing broken docs urls  https://review.openstack.org/48965016:20
mdboothSo I can rebase 7 patches on top of the revert function tests16:21
sdaguemriedem: I'm going to walk away for a bit, but I can rebase sfinucan's patches later today probably, and add any more redirects if we need them16:22
sdaguealthough I think most of the moves already happened16:22
*** lucasagomes is now known as lucas-afk16:23
*** aarefiev is now known as aarefiev_afk16:23
openstackgerritMatthew Booth proposed openstack/nova master: Fix scope of errors_out_migration in resize_instance  https://review.openstack.org/48749516:24
openstackgerritMatthew Booth proposed openstack/nova master: Split Compute.errors_out_migration into a separate contextmanager  https://review.openstack.org/48573416:24
openstackgerritMatthew Booth proposed openstack/nova master: Automatically revert resize which fails on destination  https://review.openstack.org/46252116:24
openstackgerritMatthew Booth proposed openstack/nova master: fake_notifier: allow waiting on either notification type  https://review.openstack.org/48963716:24
openstackgerritMatthew Booth proposed openstack/nova master: Fix scope of errors_out_migration in finish_resize  https://review.openstack.org/48751516:24
openstackgerritMatthew Booth proposed openstack/nova master: Ensure errors_out_migration errors out migration  https://review.openstack.org/47980216:24
openstackgerritMatthew Booth proposed openstack/nova master: Functional test for auto revert resize  https://review.openstack.org/48965416:24
mdboothMeh, at least now I have something to point people at16:24
*** itlinux has joined #openstack-nova16:25
*** rajathagasthya has joined #openstack-nova16:30
*** crushil has quit IRC16:30
*** stewie925_ has joined #openstack-nova16:31
*** yamahata has joined #openstack-nova16:31
*** stewie925_ is now known as stewie92516:32
openstackgerritMerged openstack/python-novaclient master: Remove custom autodoc implementation  https://review.openstack.org/48026216:33
*** ragasthya has joined #openstack-nova16:33
*** rajathagasthya has quit IRC16:35
openstackgerritMerged openstack/nova master: Updated from global requirements  https://review.openstack.org/48960416:39
mriedemdansmith: jaypipes: i'm +2 on gibi's test now https://review.openstack.org/#/c/487958/ - should i just push that through?16:39
*** penick has joined #openstack-nova16:39
mriedemsince you both worked on it and sean is afk16:39
dansmithmriedem: I'm not likely to +W it in its current form, so probably16:39
mriedemok16:39
jaypipesmriedem: actually I'd like to add one more assertion in there.16:40
mriedemjaypipes: can it go on top?16:40
jaypipesmriedem: sure I suppose16:40
mriedemi just want to stop iterating on this one16:40
jaypipesok with me16:40
mriedembut if you're ready like now then i can wait16:40
jaypipesmriedem: please proceed.16:41
mriedemdone16:41
*** lpetrut has joined #openstack-nova16:42
cdentjaypipes: has a plan (for migrations) distilled out of today’s conversations yet, or is that still pending?16:43
* cdent is trying hard to keep abreast16:43
jaypipescdent: 1707071 is the primary bug I'm tracking right now.16:43
*** ijw has quit IRC16:44
cdentjaypipes: yes, but I thought any potential solutions to that impinge on the wider migration picture?16:44
jaypipescdent: not quite following you on that...16:45
cdentjaypipes: maybe I misunderstood your answer to my question. Are you saying “yes, that’s what 1707071 is about” or “no, I’m focused on the details of making sure that we create the right allocations”? Looks like the former?16:47
*** abalutoiu has joined #openstack-nova16:47
jaypipescdent: I'm focused on trying to not have Pike compute node RTs fight each other writing and overwriting allocation records.16:48
cdentEarlier today you said that overnight you fought with the code enough to think that you had to rejigger everything again.16:48
jaypipescdent: what I said earlier we mostly referring to needing to essentially put a bunch of conditionals in to keep being broken for Ocata compute hosts migrating to Pike compute hosts.16:48
cdentSo sounds like you have some kind of plan. That’s great. As before, if there’s something I can do, let me know.16:49
openstackgerritMatt Riedemann proposed openstack/nova master: Accept any scheduler driver entrypoint  https://review.openstack.org/48482816:50
openstackgerritEric Fried proposed openstack/nova master: DNM: Refactor get_endpoint_data to accept service_type  https://review.openstack.org/48966616:50
*** randomhack has joined #openstack-nova16:50
jaypipescdent: will do.16:50
*** bks has joined #openstack-nova16:56
bksHi all, i wanted to run a clou-init script in centos 6.6 os to change the root password, can someone please pass me the cloud-init to do it. Thanks16:56
*** slaweq has quit IRC16:56
cfriesen_in Newton would we expect a deleted instance (which is in the "instances" table) to always have an entry in instance_extra?16:56
bksand is used_data option is used in the nova create server api to pass the cloud-init?16:56
bkscan someone please help me here16:57
cfriesen_bks: your question should probably be asked on #openstack16:58
*** cfriesen_ is now known as cfriesen16:58
*** pcaruana has quit IRC16:58
*** randomhack has quit IRC16:58
*** lpetrut has quit IRC16:59
*** jistr is now known as jistr|afk17:00
bks@cfriesen_ i asked there too, no response17:00
*** baoli has quit IRC17:00
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Add ``HostPortProfileInfo`` class  https://review.openstack.org/44159017:00
*** lyan has joined #openstack-nova17:01
mriedemyes user_data is passed through to cloud-init17:02
cfriesenbks: many of the nova folks are busy with release-critical stuff.   have you looked at: http://blog.scottlowe.org/2015/11/09/changing-passwords-cloud-init/17:02
*** ralonsoh has quit IRC17:02
*** crushil has joined #openstack-nova17:03
*** hamzy has joined #openstack-nova17:03
bks@cfriesen ohh sorry, iam trying the same script but couldnot get it worked17:05
*** baoli has joined #openstack-nova17:05
bks@cfriesen the userdata option in createserver is used to pass the cloud-init?17:05
bksas mentioned in the https://developer.openstack.org/api-ref/compute/#create-server17:06
mriedemhttps://github.com/openstack/openstack-manuals/blob/stable/ocata/doc/user-guide/source/cli-config-drive.rst17:06
*** slaweq has joined #openstack-nova17:07
*** efoley has quit IRC17:07
* dansmith wonders if he should change the /topic in this channel17:08
cburgessBecause.....?17:08
openstackgerritEric Fried proposed openstack/nova master: Adopt new pypowervm power_off APIs  https://review.openstack.org/47694517:10
*** baoli has quit IRC17:11
*** lpetrut has joined #openstack-nova17:11
*** stewie925 has left #openstack-nova17:13
*** dtantsur is now known as dtantsur|afk17:13
*** baoli has joined #openstack-nova17:15
*** kbaegis has joined #openstack-nova17:17
openstackgerritJackie Truong proposed openstack/nova master: Add trusted_certs to instance_extra  https://review.openstack.org/45771117:20
*** randomhack has joined #openstack-nova17:21
*** bks has left #openstack-nova17:22
*** sambetts is now known as sambetts|afk17:24
*** randomhack has quit IRC17:26
*** ragasthya has quit IRC17:34
*** kristia__ has quit IRC17:38
*** kristian__ has joined #openstack-nova17:39
*** lucasxu has quit IRC17:41
*** gyee has joined #openstack-nova17:41
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: See if we can squash ComputeHostNotFound_Remote on startup  https://review.openstack.org/48968317:42
mriedemdansmith: ^ destroys unit tests for the objects b/c of the fake indirection api, but is that something that's even possible? ^17:42
mriedemi want to get rid of these http://logs.openstack.org/54/487954/5/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/4412f5d/logs/screen-n-cpu.txt.gz?level=TRACE#_Jul_28_19_41_38_46697217:43
*** yamahata has quit IRC17:43
*** liverpooler has quit IRC17:43
dansmithmriedem: no because those aren't actually the rpc calls17:43
*** kristian__ has quit IRC17:43
cdentIs stephenfin around this week, I sense his absence17:43
dansmithwell, I'm guessing that won't work because ^17:43
mriedemcdent: i'm told he's back tomorrow17:43
cdentthanks mriedem17:44
dansmithmriedem: that line you quote is intentional log.warning in the libvirt driver17:45
dansmithmriedem: and it looks like we're getting a stack trace automagically from the logging layer (?)17:46
mriedemi know, but the trace is coming from oslo.messaging isn't it?17:46
dansmithno I don't think so17:46
dansmithmriedem: see the line below.. you need exc_info=False maybe ?17:47
dansmithmaybe a default changed somehow?17:47
dansmithoh17:47
dansmithooooh17:47
dansmithyou're hitting the lower one17:47
dansmithwith exc_info=True17:47
dansmithbecause it is _Remote17:47
mriedemdansmith: yeah there is that,17:47
dansmithso maybe in that handler, check the exception name and if it looks remoteish then you can not pass the exc_info flag?17:47
mriedembut that doesn't explain this one http://logs.openstack.org/54/487954/5/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/4412f5d/logs/screen-n-cpu.txt.gz?level=TRACE#_Jul_28_19_41_40_92788117:47
dansmithit's a little icky17:47
mriedemhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L662417:48
mriedemoh well,17:48
mriedemmaybe we don't hit that code b/c of the same thing?17:48
*** rajathagasthya has joined #openstack-nova17:48
dansmithwell, you log that message, so it seems like you are17:49
dansmithnot sure why you get a trace there then17:49
mriedembut where does the traceback come from?17:49
mriedemright17:49
dansmithunless a default has changed and oslo now logs a trace if you're in exception context17:50
dansmithboy that sure is ugly17:51
mriedembeen this way since ocata17:51
trinathshi, I'm hitting this error, when i start nova-compute, http://paste.openstack.org/show/617156/17:52
openstackgerritSumedh Degaonkar proposed openstack/nova master: Adds 'sata' as a valid disk bus for qemu and kvm hypervisors  https://review.openstack.org/45979417:52
trinathsplease help me resolve the same.17:52
*** slaweq has quit IRC17:56
*** slaweq has joined #openstack-nova17:57
*** gszasz has quit IRC17:57
*** crushil has quit IRC17:57
*** links has quit IRC17:57
*** crushil has joined #openstack-nova17:58
sdaguemriedem: actually, looking at sfinucan's split up of docs, I'm really not convinced that https://review.openstack.org/#/c/478485/ is a good move17:58
*** baoli has quit IRC17:59
*** Apoorva_ has joined #openstack-nova17:59
*** penick has quit IRC17:59
*** baoli has joined #openstack-nova18:00
mriedemsdague: ... i said it was a massive change18:00
mriedemhttp://docs-draft.openstack.org/85/478485/16/check/gate-nova-docs-ubuntu-xenial/481415d//doc/build/html/18:00
*** baoli has quit IRC18:00
mriedemcompared to how things used to be https://docs.openstack.org/nova/ocata/18:00
sdaguemriedem: yeh18:00
mriedemi can't even really review it18:00
*** Apoorva_ has quit IRC18:00
mriedemasettle is also working on that patch18:00
sdaguehonestly, I mostly want to light docs like that on fire18:00
*** baoli has joined #openstack-nova18:01
*** Apoorva has quit IRC18:01
*** Apoorva_ has joined #openstack-nova18:01
sdaguebecause you have to know what you are looking for before you can find what you are looking for18:01
*** slaweq has quit IRC18:01
*** slaweq has joined #openstack-nova18:01
mriedemwait which thing do you want to light on fire?18:01
*** markvoelker has quit IRC18:02
*** penick has joined #openstack-nova18:02
sdaguespliting up the process doc into 6 process docs18:02
*** markvoelker has joined #openstack-nova18:02
sdaguehttp://docs-draft.openstack.org/85/478485/16/check/gate-nova-docs-ubuntu-xenial/481415d//doc/build/html/contributor/process.html18:02
*** lucasxu has joined #openstack-nova18:02
*** lucasxu has quit IRC18:02
mriedemcompared to https://docs.openstack.org/nova/ocata/process.html ?18:03
sdagueyes18:03
mriedemidk if this is meant to be consistent with other projects, but it's not consistent with cinder's home page now18:06
mriedemhttps://docs.openstack.org/cinder/latest/18:06
mriedemor glance https://docs.openstack.org/glance/latest/18:06
*** itlinux has quit IRC18:06
*** ijw has joined #openstack-nova18:07
*** ijw has quit IRC18:07
*** ijw has joined #openstack-nova18:07
*** kristian__ has joined #openstack-nova18:09
*** slagle has quit IRC18:09
*** kristian__ has quit IRC18:09
*** kristian__ has joined #openstack-nova18:09
*** slagle has joined #openstack-nova18:11
sdagueit would be nice to figure out how we get in page toc into the sidebar instead of top of page18:13
mriedemyes that's also been annoying me18:13
*** EmilienM is now known as emacchi18:14
sdaguedhellman might know18:14
*** emacchi is now known as EmilienM18:14
sdaguelooks like glance does it18:14
*** trinaths has left #openstack-nova18:16
mriedemsdague: any idea how we figure out which log formatter/handler we're using in a devstack run?18:16
mriedemlike, are those configurable somewhere?18:17
sdaguemriedem: ??18:18
mriedemwell there is a json formatter, and a context formatter18:18
sdagueyes, we're using the context formatter18:18
mriedemand a color handler, and journal and syslog handler18:18
mriedembut how would someone know?18:18
mriedemconfig?18:18
sdagueit's config, but I think those are the defaults18:19
*** yamahata has joined #openstack-nova18:20
sdagueoh, you know what it is, it's actually python logging config18:20
sdagueoutside of our config18:20
sdagueso use_syslog / use_journal will tweak those things18:21
sdaguehttps://docs.openstack.org/oslo.log/latest/configuration/index.html18:21
sdaguebut on the formatter side it's all done as python logger setup18:21
*** dtp has joined #openstack-nova18:22
mriedemok, because what i think we're seeing with a bunch of these random stacktraces related to ComputeHostNotFound_Remote is that we're logging with an exception context,18:23
mriedemand oslo.log is logging the traceback18:23
mriedemautomagically18:23
mriedemhttps://www.youtube.com/watch?v=iExgnVXSAuE18:24
mriedemthanks oslo.log18:24
*** slaweq has quit IRC18:25
mriedemgonna push a patch to test that theory18:26
*** slaweq has joined #openstack-nova18:26
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: See if we can squash ComputeHostNotFound_Remote on startup  https://review.openstack.org/48968318:27
mriedemsdague: dansmith: ^ is the canary18:27
mriedemi think it's something to do with this: https://github.com/openstack/oslo.log/blob/3.30.0/oslo_log/formatters.py#L14418:29
*** slaweq has quit IRC18:29
*** slaweq has joined #openstack-nova18:30
*** egonzalez has joined #openstack-nova18:30
*** slaweq has quit IRC18:31
*** annegentle has quit IRC18:33
*** itlinux has joined #openstack-nova18:34
*** jistr|afk is now known as jistr18:34
*** slaweq has joined #openstack-nova18:35
*** itlinux has quit IRC18:36
openstackgerritMerged openstack/nova master: Test resize with placement api  https://review.openstack.org/48795818:36
mriedemyay ^18:36
openstackgerritJackie Truong proposed openstack/nova master: Add trusted_certs to instance_extra  https://review.openstack.org/45771118:37
*** ijw has quit IRC18:39
*** slaweq has quit IRC18:40
*** ijw has joined #openstack-nova18:46
*** dtp is now known as dtp-afk18:49
*** yushb has joined #openstack-nova18:50
jaypipesgibi: where do I change the notification sample test JSON files?18:54
*** yushb has quit IRC18:54
jaypipesgibi: nm, found it.18:54
*** pchavva has quit IRC18:55
*** kristian__ has quit IRC18:57
*** adisky__ has quit IRC18:58
openstackgerritJay Pipes proposed openstack/nova master: placement: remove existing allocs when set allocs  https://review.openstack.org/48927319:02
openstackgerritJay Pipes proposed openstack/nova master: remove provider allocs in confirm/revert resize  https://review.openstack.org/48851019:02
openstackgerritJay Pipes proposed openstack/nova master: Additional assertions to resize tests  https://review.openstack.org/48971419:02
*** randomhack has joined #openstack-nova19:02
*** penick has quit IRC19:02
melwittthis is a bug fix (data corruption possible) I think we'll need for rc1, if anyone can review please https://review.openstack.org/#/c/488545/19:05
openstackgerritIldiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow  https://review.openstack.org/33028519:07
*** kbaegis has quit IRC19:08
*** _pewp_ has quit IRC19:09
*** _pewp_ has joined #openstack-nova19:12
*** ijw has quit IRC19:12
*** penick has joined #openstack-nova19:13
*** annegentle has joined #openstack-nova19:17
openstackgerritEric Fried proposed openstack/nova master: nova.utils.get_endpoint_data()  https://review.openstack.org/48813719:22
mriedemmelwitt: question in there19:23
mriedemthe persistent vs live stuff always confuses me19:23
* melwitt looks19:23
openstackgerritMatt Riedemann proposed openstack/nova master: Cleanup unnecessary logic in os-volume_attachments controller code  https://review.openstack.org/48582319:25
cfriesenmriedem: isn't "persisten" whether there is a persistent domain (unrelated to the device)?19:25
melwittmriedem: I'm not sure I understand the question. in my comment I tried to say "if DeviceNotFound was raised when we passed persistent=True, that means it wasn't found, so we should continue on to try a live detach". though I do notice I should have used "if persistent and live"19:26
melwittbecause if live isn't True then there's no need to continue19:26
mriedemwell there you go19:26
melwittis that what you were pointing out? sorry :)19:27
mriedemno19:27
mriedemi just wanted to ask a question to sound like i know 2 sh*ts about this code before +2ing it19:27
mriedem<- professional19:27
melwittcfriesen: yeah, from what I understand there's effectively two copies of the VM config. one is "persistent" to affect upon next boot and the other is "live" which affects only the live VM19:28
openstackgerritIldiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow  https://review.openstack.org/33028519:28
cdentjmlowe: I’m going to break the bourbon pattern to give you some early for the good advice of the day award19:28
mriedemmelwitt: the comment makes more sense now19:28
melwittso if the VM even has a persistent config, you have to detach the device from both configs to make sure the device is detached live and also won't show up again after a reboot19:29
melwittit's confusing19:29
mriedemmelwitt: that would be good doc to put in that code19:29
melwittwill do19:29
cfriesenmelwitt: so we try first calling detach_device() with both persistant and live but libvirt raises an exception since it doesn't find it in the persistent config?19:31
*** baoli has quit IRC19:31
*** acormier_ has quit IRC19:31
mriedemso the bug is we tried to detach from persistent config and it wasn't there, so we gave up, but it was in the live config, and then the user reboots the guest and now the volume is attached to both?19:31
cfriesenmelwitt: so we have to retry just the live detach without the persistant19:32
jmlowecdent: what advise was that? "never shit in your hat"  "money talks and bullshit walks" "shit in one hand wish in the other and see which one fills up first"19:32
*** acormier has joined #openstack-nova19:32
melwittcfriesen: right. this can happen in the scenario where the guest is busy (e.g. file open) and the guest ignores the ACPI request to detach from live. so what happens there is the detach from the persistent config succeeds but the live fails and so the overall detach fails19:32
mriedemcan qemu / libvirt just add a "seriously_please_detach_this_thing_at_some_point" API?19:32
jmlowecdent: it appears that most of my advise is scatological in nature19:33
cdentjmlowe: ceph your glance and your disk19:33
cfriesenmelwitt: I take it libvirt chokes if you specify both VIR_DOMAIN_AFFECT_CONFIG and VIR_DOMAIN_AFFECT_LIVE and it's not in the persistant?19:33
melwittcfriesen: later on, if the guest is all done and the file is closed, the user wants to detach the volume again, they will issue the detach command and we'll need to detach it from only the live config bc it's already gone from the persistent config19:33
cdentwhich may be scat19:33
melwittcfriesen: tes19:33
*** peter-hamilton has joined #openstack-nova19:33
melwitt*yes19:33
*** peter-hamilton has quit IRC19:33
melwittlibvirt will raise a "no device found" type error due to the AFFECT_CONFIG flag19:33
*** acormier has quit IRC19:33
*** acormier has joined #openstack-nova19:34
*** acormier has quit IRC19:34
*** kbaegis has joined #openstack-nova19:34
*** peter-hamilton has joined #openstack-nova19:34
cfriesenmelwitt: almost seems safer to just handle persistent and live separately rather than trying to do them both and have to clean up if it fails19:34
*** acormier has joined #openstack-nova19:34
*** acormier has quit IRC19:34
cfriesenbut I suppose it's probably more efficient to do them both at the same time19:34
jmlowecdent: I do what I can, I was practically frothing at the mouth to go from Liberty to Mitaka just for the ceph glance nova stuff19:34
*** itlinux has joined #openstack-nova19:35
*** acormier has joined #openstack-nova19:35
melwittcfriesen: yeah, I have wondered similar. in a normal scenario you'd only need one call to do the whole thing19:35
*** rcernin has quit IRC19:36
*** slaweq has joined #openstack-nova19:36
cfriesenmelwitt: looks okay to me with the caveat of adding that check for "live"19:37
melwittcfriesen: cool, thanks. I'm working on adding that and beefing up the test to match19:37
melwittand adding more code comments19:37
*** baoli has joined #openstack-nova19:38
cfriesenseems like we could have run into problems with the second call currently if live was false19:38
melwittyeah, possibly. I'm not sure what it does if you pass no flags, maybe a no-op one would hope19:39
*** acormier has quit IRC19:39
* melwitt looks19:39
*** slaweq has quit IRC19:41
melwittokay, 0 is VIR_DOMAIN_AFFECT_CURRENT=019:42
melwittAffect current domain state. so it would do something, hopefully raising one of the "not found" we handle and then it would bubble up to compute which would ignore it19:42
mriedemjaypipes: want to -2 this so someone doesn't get confused it's not for pike? https://review.openstack.org/#/c/488595/19:43
openstackgerritMatthew Edmonds proposed openstack/nova master: update policy UT fixtures  https://review.openstack.org/39861019:44
*** nicolasbock has quit IRC19:45
*** dtp-afk is now known as dtp19:46
*** randomhack has quit IRC19:47
cfriesenmelwitt: looks like libvirt virDomainDetachDeviceFlags() will error if "flags" is not set.19:47
cfriesenbased on a quick check of the code19:47
mriedemdims: i'm beating my head against some weird traceback logging we're seeing but don't know where the traceback is actually coming from https://review.openstack.org/#/c/489683/219:47
mriedemdims: i assume it's something in oslo19:48
melwittcfriesen: okay. well, we'd pass 0 for flags if neither persistent nor live, and I thought 0 was a valid flag19:48
*** penick has quit IRC19:49
cfriesenmelwitt: wait, I think I misread.19:49
cfriesenoops19:50
cfriesenwas looking at the function pointer, not the variable19:50
*** penick has joined #openstack-nova19:50
*** acormier has joined #openstack-nova19:51
*** acormier has quit IRC19:52
*** acormier has joined #openstack-nova19:53
cfriesenmelwitt: the common code does not check for empty flags, but passes it on down to the specific sub-driver (ie the qemu one).19:54
*** itlinux has quit IRC19:54
*** eharney has quit IRC19:56
*** acormier has quit IRC19:57
*** priteau has quit IRC20:01
*** penick has quit IRC20:01
cfriesenmelwitt: based on virDomainObjUpdateModificationImpact() it looks like if flags is empty it will set either VIR_DOMAIN_AFFECT_LIVE or VIR_DOMAIN_AFFECT_CONFIG based on whether or not the domain is currently active20:01
melwittcfriesen: ah, cool. so that's what they mean by VIR_DOMAIN_AFFECT_CURRENT (which is 0)20:02
cfriesenyes20:02
*** eharney has joined #openstack-nova20:11
*** awaugama has quit IRC20:12
*** kbaegis has quit IRC20:14
openstackgerritmelanie witt proposed openstack/nova master: Detach device from live domain even if not found on persistent  https://review.openstack.org/48854520:18
cdentmriedem: if you’re in a docs way here’s a bit of placement docs: https://review.openstack.org/#/c/469048/20:20
*** mtanino has joined #openstack-nova20:22
*** karthiks has quit IRC20:23
*** karthiks has joined #openstack-nova20:23
mriedemack20:23
mriedemdansmith: whilst reviewing your cells v2 topology docaroo, i realized we could/should disable CONF.filter_scheduler.track_instance_changes in the superconductor mode for devstack,20:24
mriedemsince the computes are basically rpc casting into the ether20:24
dansmithah yeah20:24
sdaguespeaking of docs, if anyone wants to fix a whole lot of our 404s... https://review.openstack.org/#/c/489650/ one more +220:25
mriedemso i'm +2 on the doc https://review.openstack.org/#/c/487183/ but what did you have in mind for documenting the upcall limitations?20:25
*** jackie-truong has joined #openstack-nova20:25
dansmithmriedem: I can throw those into the bottom set of things if you want20:26
mriedemok, i mentioned them in ps5 to go in there, but you didn't add them so i didn't know what you had planned20:27
*** slaweq has joined #openstack-nova20:27
dansmithunintentional20:29
*** baoli has quit IRC20:29
*** crushil has quit IRC20:29
jackie-truongdansmith: Do you have a few minutes? I have another question related to https://review.openstack.org/#/c/45771120:30
dansmithjackie-truong: okay, since that's not release-related it's not very high priority, but.. go ahead and ask20:31
jackie-truongdansmith: Got it. We want the trusted_certs column to store lists of UUIDs20:32
jackie-truongdansmith: On L31 of 363_add_trusted_certs.py, we're trying to store an sqlalchemy ARRAY of Strings20:32
jackie-truongdansmith: I don't think that that's the best way to go about that, but unsure if you all of seen a similar need?20:33
dansmithjackie-truong: yeah I have no idea what that would look like in the sql20:33
dansmithhuh arrays in sql20:34
*** lpetrut has quit IRC20:35
dansmiththat's new to me, but I'm fairly certain that that's not the way to do this20:35
*** itlinux has joined #openstack-nova20:35
*** gbarros has quit IRC20:35
dansmithjackie-truong: everywhere else that we store multiples of things, they're either as rows, related to the instance table, if we need to be able to query them (and if there will be lots)20:35
dansmiththe instance_extra table is specifically 1:1 to instances, and is just TEXT columns, where we store json blobs20:36
dansmithcan't query on the contents (easily), but if you just need to store a list of a few strings, then that's the place,20:36
dansmithbut ideally you'd store an object in there so it's versioned instead of just some complex unversioned wild-west structure of stuff20:36
*** sree_ has joined #openstack-nova20:37
*** sree_ is now known as Guest1699120:37
*** crushil has joined #openstack-nova20:37
*** baoli has joined #openstack-nova20:38
*** cleong has quit IRC20:39
jackie-truongdansmith: Hmm we just need to be able to store and access the list of strings. If the trusted_certs column is a TEXT column, then the Instance object should be able to retrieve the list with something like L412 in https://review.openstack.org/#/c/489408/1/nova/objects/instance.py ?20:39
dansmithjackie-truong: no, because the field is a list and the column (if TEXT) is a string20:41
*** Guest16991 has quit IRC20:41
dansmithyou have to serialize and deserialize the contents there somehow20:41
jackie-truongOkay, that's where I was having the disconnect20:41
mriedemmore like https://review.openstack.org/#/c/489408/1/nova/objects/instance.py@98220:41
*** jmlowe has quit IRC20:42
mriedemdansmith: ok here is the track_instance_changes thing for devstack https://review.openstack.org/48974220:42
mriedemi need to dig a bit into how the scheduler keeps up to date with what's in the compute node for the affinity filters if that's disabled20:42
jackie-truongThanks, @mriedem20:43
*** ijw has joined #openstack-nova20:43
jackie-truongIt would probably make most sense to go ahead and create a TrustedCerts object and corresponding TrustedCertsList20:44
jackie-truongs/TrustedCerts object and corresponding TrustedCertsList/TrustedCert object and corresponding TrustedCertList20:44
dansmithno need for the list object20:44
dansmiththe list objects we have are mostly syntactic sugar for remotable query methods20:45
jackie-truongSo a single TrustedCerts object that stores the list of strings20:45
jackie-truonggot it20:45
jackie-truongCool, that gives me some better direction. Thanks!20:45
*** jackie-truong has quit IRC20:48
openstackgerritChris Dent proposed openstack/nova master: Optional separate database for placement API  https://review.openstack.org/36276620:52
mriedemhilarious20:52
mriedempolicies body array A list of exactly one policy name to associate with the server group. The current valid policy names are:20:52
mriedema list of exactly one20:52
openstackgerritJackie Truong proposed openstack/nova master: Add trusted_certs to instance_extra  https://review.openstack.org/45771120:53
dfisherok, so, to continue the adventure of the flammable Oracle engineer … http://paste.openstack.org/show/617175/  … Something is clearly not implemented but I don't know what it is :(20:53
mriedemget_inventory() method in your compute driver?20:54
dfisherE486: Pattern not found: get_inventory20:54
dfisherwell!20:54
dfisherthank you20:54
mriedemwhere that shows up is very wonky20:55
mriedemin the logs in that paste i mean20:55
mriedemget_inventory is optional20:55
dfisherok.20:56
dfisherhmm.20:56
dfisherlet me see if I can implement it real quick and see what happens.20:57
*** abalutoiu has quit IRC21:02
*** imacdonn has quit IRC21:08
*** imacdonn has joined #openstack-nova21:08
*** marst has quit IRC21:09
*** penick has joined #openstack-nova21:10
*** baoli has quit IRC21:13
*** baoli has joined #openstack-nova21:13
*** vladikr_ has quit IRC21:15
*** awaugama has joined #openstack-nova21:16
*** yamamoto has joined #openstack-nova21:17
*** baoli has quit IRC21:19
*** yamamoto has quit IRC21:21
*** yamamoto has joined #openstack-nova21:21
mriedemdansmith: jaypipes: looks like tempest wasn't testing anti-affinity before https://review.openstack.org/48975421:22
mriedemit was testing the different_hosts stuff21:23
dansmithso that'll fail in our current multinode setup right?21:24
mriedemthat's what i'm trying to test21:24
dansmithwell, it'll be flaky I think21:24
mriedemb/c we don't have the upcall?21:25
dansmithyeah21:25
dansmithwell,21:25
dansmithhmm21:25
mriedemdoes that scenario rely on rebuilds?21:25
dansmithno21:25
dansmithit requires scheduler races21:26
*** yamamoto has quit IRC21:26
mriedemi think it should just say server 1 is going on host A and when the filter scheduler processes server 2, it should put it on host B because we're tracking server1 on A in the HostState21:26
mriedemi'm really just trying to make sure the HostState stuff doesn't explode w/o the upcalls21:26
*** eharney has quit IRC21:27
dansmithright, but your test may validate that without enough parallelism the right thing happens early on21:27
dansmithwhich I guess is what you're going for,21:27
*** dave-mccowan has quit IRC21:27
dansmithbut it doesn't prove that the upcall is working (especially since it won't even be done currently)21:28
mriedemyeah not trying to prove the upcall21:28
mriedemjust trying to make sure the basic scenario through the filter works properly21:28
mriedemi think people have tried to add a test for this in tempest in the past and it's been shot down because it could be done in nova functional tests, but i worry about how much we actually stub out in the functional stuff21:29
dansmithI guess I'm not sure how the filter really works so I can't say if it'll be likely to fail21:29
dansmithyeah21:29
mikalMorning21:29
*** cjvolzka has quit IRC21:29
cfriesenwas there an official notification email that the Sydney presentation voting was open?  I don't remember seeing one.21:29
*** acormier has joined #openstack-nova21:30
mriedemi don't remember seeing one, but i don't vote either21:30
mriedemi'm only one person,21:30
mriedemmy vote doesn't count21:30
*** cjvolzka has joined #openstack-nova21:30
*** cjvolzka has quit IRC21:31
cdentcfriesen: I’ve seen a few different announcements, but I’m not sure on which lists21:32
cdentand there were some “we’ve extended voiting” announcements too21:33
openstackgerritEd Leafe proposed openstack/nova master: Handle addition of new nodes/instances in ironic flavor migration  https://review.openstack.org/48795421:33
melwittI can't find a link to the voting other than the one that cisco person sent out21:36
melwitt(can't find in email I mean)21:36
*** egonzalez has quit IRC21:37
mriedemedleafe: i think i'm going to make us run E128 just for you https://review.openstack.org/#/c/487925/2/nova/virt/ironic/driver.py21:38
*** smatzek has quit IRC21:42
cdentmelwitt, cfriesen: I’m on a _lot_ of lists, so may not have been os-dev21:43
melwittI found one email to os-dev but it had no link to voting :P21:44
melwittvote ... somewhere ... that you should find by googling21:44
edleafemriedem: I'm consistent :)21:45
*** crushil has quit IRC21:48
*** crushil has joined #openstack-nova21:49
*** ijw has quit IRC21:52
*** kbaegis has joined #openstack-nova21:53
cfriesenmriedem: for https://review.openstack.org/#/c/339715 would you be okay with me updating the "stale" migration to a "failed" or "error" state when we detect it?  Or just check for them at nova-compute startup and assume they can't happen during "normal" running?21:54
openstackgerritJackie Truong proposed openstack/nova master: Add trusted_certs to Instance object  https://review.openstack.org/48940821:57
jaypipesmriedem: marked that one patch -2.21:58
*** esberglu has quit IRC21:58
cdentmriedem: does https://bugs.launchpad.net/nova/+bug/1708031 need an owner? If so, I can take it. Do we need the report client to be happy with both the old and new messages? Or just new? I’m guessing both.22:00
openstackLaunchpad bug 1708031 in OpenStack Compute (nova) ""Failed to delete inventory for resource provider" error messages for predictable 409 cases" [Medium,Triaged] - Assigned to Matt Riedemann (mriedem)22:00
*** burt has quit IRC22:00
cdentmriedem: nm, you assigned it to yourself while I was reading it22:01
*** burt has joined #openstack-nova22:01
*** smatzek has joined #openstack-nova22:01
*** burt has quit IRC22:01
openstackgerritMatt Riedemann proposed openstack/nova master: Fix 409 handling in report client when deleting inventory  https://review.openstack.org/48976322:01
mriedemcdent: ^22:01
*** kbaegis has quit IRC22:01
* cdent looks22:01
*** smatzek_ has joined #openstack-nova22:02
*** slaweq has quit IRC22:03
*** slaweq has joined #openstack-nova22:03
*** penick has quit IRC22:03
*** mikal has quit IRC22:04
*** thorst_afk has quit IRC22:05
*** mikal has joined #openstack-nova22:06
*** annegentle has quit IRC22:06
*** smatzek has quit IRC22:06
*** penick has joined #openstack-nova22:07
cdentmriedem: has ironic been spewing these errors since early june?22:07
openstackgerritMichael Still proposed openstack/nova master: Move execs of tee to privsep.  https://review.openstack.org/48943822:08
openstackgerritMichael Still proposed openstack/nova master: Read from console ptys using privsep.  https://review.openstack.org/48948622:08
*** slaweq has quit IRC22:08
zzzeekjaypipes: there?22:08
mriedemcdent: probably22:08
mriedemcdent: i only check the ironic ci job logs for ironic related chagnes22:08
cdentmriedem: my real question: how come this didn’t break stuff ?22:08
mriedem*changes22:08
* cdent makes a related reminder bug22:09
zzzeekmriedem: does nova get DB connection URLs from anywhere other than /etc/nova/nova.conf ?22:09
mriedemzzzeek: yes22:10
mriedemfrom the db for the cell mappings22:10
zzzeekmriedem: in the DB !22:10
mriedemnova_api.cell_mappings table22:10
zzzeekmriedem: omg.22:10
zzzeekmriedem: so.   once you deploy nova, you can never change the ip number of the database ??22:10
zzzeekip number gets written into the DB itself ?22:10
mriedemit's whatever is put in when creating the cell mapping22:11
melwittyou can update the cell mapping22:11
melwittvia nova-manage22:11
melwittif you need to change it22:11
zzzeekmelwitt: you can!  did anyone consider maybe looking in the nova.conf file and seeing, oh hey they moved their DB server22:11
zzzeekwow.22:12
zzzeeknova.   heh.22:12
zzzeekOK22:12
*** kylek3h has quit IRC22:12
*** esberglu has joined #openstack-nova22:12
mriedemyour volume connection info to a ceph server is also stored in a json blob in the db, so if your ceph server ip changes you have similar problems22:12
mriedemper instance22:12
mriedemso you have to migrate or reboot the instance22:12
*** colby_ has joined #openstack-nova22:13
zzzeekWOW.  OK wait, this actually destroys waht I want to do.   wow22:13
*** kylek3h has joined #openstack-nova22:13
*** kylek3h has quit IRC22:13
*** acormier has quit IRC22:13
mriedemhttp://lists.openstack.org/pipermail/openstack-operators/2017-June/013700.html22:13
*** acormier has joined #openstack-nova22:14
zzzeekmriedem: im just looking at mysql urls22:14
colby_Hey Everyone I asked in the support channel but no one seemed to have an answer. We upgraded to newton and the flavor and aggregate migration scripts fail to cpoy the data to the nova_api tables. It appears that sqlalchecmy is adding the timezone offset to the DATETIME field and its complaining about incorrect format. Here is an example of the error:22:15
colby_Incorrect datetime value: '2015-02-17 22:37:06+00:00' for column 'created_at'22:15
zzzeekmriedem: so confirm, it is completely impossible to have a scenario where a nova server on a particular controller had its own MySQL URL distinct from that of other contrlers, because they are pulled from the database and do not distinguish between the source22:15
colby_we use Mariadb 10.0.2122:16
dansmithzzzeek: I don't know what you mean by "between the source" but yes, all the control services find the cell databases by looking in the api database22:17
zzzeekdansmith: OK22:17
*** esberglu has quit IRC22:17
melwitteach controller has to know how to connect to each of N cell databases, that's why they're in the database, there are multiple DB URLs we need to be able to connect to22:18
*** acormier has quit IRC22:18
*** thorst_afk has joined #openstack-nova22:19
*** smatzek_ has quit IRC22:20
mriedemmelwitt: +2 on your detach shenanigans22:22
*** yamamoto has joined #openstack-nova22:23
*** esberglu has joined #openstack-nova22:23
melwitt\o/22:23
*** ijw has joined #openstack-nova22:23
*** catintheroof has quit IRC22:23
*** thorst_afk has quit IRC22:24
*** yamamoto has quit IRC22:25
*** yamamoto has joined #openstack-nova22:25
melwittmriedem: do you want me to move the comment inside the conditional? I can do that quick if you want to re +222:25
mriedemmeh22:25
melwitthaha, okay22:25
mriedemmy ability to make any sort of decision right now is very low22:26
* melwitt nods22:26
efriedmorgan mordred sdague https://review.openstack.org/#/c/488137/ is passing tests with temporary patches to twiddle glance & ironic confs.22:27
mordredefried: woot!22:27
efriedmorgan mordred sdague And FYI, PS5 has the swizzle where you pass the service_type (rather than the conf_group/project_name) to the util.22:27
efried(which both sdague and morgan asked for)22:27
morgannice22:27
efriedNext stop: cinder!22:28
mriedemhuh, we're actually failing grenade at a decent clip http://logs.openstack.org/54/489754/3/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/7e19ce3/logs/old/screen-n-cond.txt.gz#_2017-08-01_21_57_19_55922:29
mriedemon the ocata side22:29
openstackgerritJackie Truong proposed openstack/nova master: Implement certificate_utils  https://review.openstack.org/47994922:33
cdentmriedem: in muiltinode does one node stay ocata? is this before or after that?22:35
*** sdague has quit IRC22:35
mordredefried: a few suggestions inline22:36
*** edmondsw has quit IRC22:36
*** smatzek_ has joined #openstack-nova22:36
mriedemcdent: depends on the job config22:37
mriedemsome keep n-cpu behind22:37
mriedembut yeah i think multinode grenade always keeps n-cpu behind as n-122:38
mriedemand upgrades everything else22:38
mriedemthere used to be a single node grenade partial which upgraded everything except n-cpu22:38
mriedemmultinode grenade has 1 upgraded n-cpu and one n-1 n-cpu22:38
*** penick has quit IRC22:39
mriedemso we can do things like live migrate between versions22:39
zzzeekmriedem: crisis averted thanks for the help22:39
*** kbaegis has joined #openstack-nova22:40
openstackgerritChris Dent proposed openstack/nova master: WIP Always use application/json accept header in report client  https://review.openstack.org/48977222:41
mriedemzzzeek: can you shed some light on what the crisis was?22:41
zzzeekmriedem: customer wants each controller accessing from its own source IP which is tied to a distinct password on the mysql server.  because we use haproxy, that means each contorller must connect to a local haproxy, which means each controller has distinct database url22:43
*** dave-mccowan has joined #openstack-nova22:43
*** annegentle has joined #openstack-nova22:45
*** itlinux has quit IRC22:49
*** smatzek_ has quit IRC22:49
openstackgerritJackie Truong proposed openstack/nova master: Add trusted_certs to Instance object  https://review.openstack.org/48940822:51
*** lyan has quit IRC22:51
openstackgerritJackie Truong proposed openstack/nova master: Implement certificate_utils  https://review.openstack.org/47994922:51
*** https_GK1wmSU has joined #openstack-nova22:54
*** https_GK1wmSU has left #openstack-nova22:56
*** ijw has quit IRC22:58
dansmithmriedem: people like that can just put the url in the database using an alias hostname, that they map per node in /etc/hosts22:58
dansmithmriedem: easy stuff22:58
dansmithmriedem: and it appears that they can also configure the creds in a mysql client config file that gets honored, so they can have separate creds too22:59
dansmithwhich is way better than us trying to pattern-format the url we get out of the db or something silly like that22:59
*** dfisher has quit IRC23:00
mriedembut can postgresql do that?!23:01
* cdent slaps mriedem 23:01
*** jmlowe has joined #openstack-nova23:02
*** jmlowe has quit IRC23:03
*** annegentle has quit IRC23:04
*** esberglu has quit IRC23:06
*** slaweq has joined #openstack-nova23:07
*** slaweq has quit IRC23:11
*** kbaegis has quit IRC23:12
*** esberglu has joined #openstack-nova23:12
*** kbaegis has joined #openstack-nova23:13
*** jmlowe has joined #openstack-nova23:16
*** chyka has quit IRC23:19
*** mtanino has quit IRC23:26
gmannmriedem, re: API doc patches. not yet. i will push those today23:29
*** hongbin has quit IRC23:30
*** jaypipes has quit IRC23:31
*** jamesden_ has joined #openstack-nova23:35
*** jamesdenton has quit IRC23:35
*** cjvolzka has joined #openstack-nova23:38
*** jamesden_ has quit IRC23:39
gmannmriedem, can you restore this - https://review.openstack.org/#/c/489641/123:40
gmannapi-microversion-history redirect is not done in https://review.openstack.org/#/c/489650/23:40
*** jamesdenton has joined #openstack-nova23:41
mriedemgmann: that's weird23:42
mriedemdone23:42
*** chyka has joined #openstack-nova23:42
*** gouthamr has quit IRC23:43
gmannmriedem, thanks, it might need rebase once 489650 is in. i will do after main patch is merged23:44
*** kbaegis has quit IRC23:45
-openstackstatus- NOTICE: osic nodes have been removed from nodepool due to a problem with the mirror host beginning around 22:20 UTC. please recheck any jobs with failures installing packages.23:47
*** chyka has quit IRC23:49
openstackgerritGhanshyam Mann proposed openstack/nova master: Add redirect for api-microversion-history doc  https://review.openstack.org/48964123:49
*** ijw has joined #openstack-nova23:52
*** markvoelker has quit IRC23:53
openstackgerritMatt Riedemann proposed openstack/nova master: Add redirect for api-microversion-history doc  https://review.openstack.org/48964123:54
*** acormier has joined #openstack-nova23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!