*** artom has quit IRC | 00:02 | |
*** markvoelker has quit IRC | 00:05 | |
*** yangyape_ has quit IRC | 00:09 | |
*** dpawlik has quit IRC | 00:11 | |
*** sterdnotshaken has quit IRC | 00:16 | |
mriedem | i had my fill of waffle house in ATL for about a decade | 00:19 |
---|---|---|
mriedem | 3 mornings in a row, milked that single page menu | 00:19 |
*** dpawlik has joined #openstack-nova | 00:24 | |
*** gyee has quit IRC | 00:26 | |
*** masber has joined #openstack-nova | 00:27 | |
openstackgerrit | Merged openstack/nova master: Cleanup allocations in failed prep_resize https://review.openstack.org/497592 | 00:27 |
*** esberglu has joined #openstack-nova | 00:32 | |
*** yingjun has joined #openstack-nova | 00:38 | |
*** kiennt has joined #openstack-nova | 00:47 | |
*** markvoelker has joined #openstack-nova | 00:48 | |
*** tuanluong has joined #openstack-nova | 00:49 | |
*** yamamoto has joined #openstack-nova | 00:51 | |
*** yamamoto has quit IRC | 00:57 | |
*** itlinux has joined #openstack-nova | 00:57 | |
*** dixiaoli has joined #openstack-nova | 00:57 | |
*** gmann has quit IRC | 01:01 | |
*** gmann has joined #openstack-nova | 01:01 | |
*** itlinux has quit IRC | 01:02 | |
*** itlinux has joined #openstack-nova | 01:03 | |
*** phuongnh has joined #openstack-nova | 01:04 | |
*** iceyao has joined #openstack-nova | 01:12 | |
openstackgerrit | liusheng proposed openstack/nova master: Trivial: remove unused instance_group_member_delete method https://review.openstack.org/497115 | 01:13 |
*** yangyapeng has joined #openstack-nova | 01:16 | |
*** litao__ has joined #openstack-nova | 01:20 | |
*** yamahata has quit IRC | 01:21 | |
*** hamzy has joined #openstack-nova | 01:23 | |
*** Shunli has joined #openstack-nova | 01:28 | |
*** Apoorva_ has quit IRC | 01:31 | |
*** Apoorva has joined #openstack-nova | 01:31 | |
*** hongbin has joined #openstack-nova | 01:38 | |
*** esberglu has quit IRC | 01:42 | |
*** Apoorva_ has joined #openstack-nova | 01:48 | |
*** Apoorva has quit IRC | 01:51 | |
*** yamamoto has joined #openstack-nova | 01:53 | |
*** Apoorva_ has quit IRC | 01:53 | |
*** _pewp_ has quit IRC | 01:57 | |
*** yamamoto has quit IRC | 01:58 | |
*** _pewp_ has joined #openstack-nova | 01:59 | |
*** tpatil has joined #openstack-nova | 02:04 | |
*** links has joined #openstack-nova | 02:06 | |
*** links has quit IRC | 02:06 | |
*** sdake has quit IRC | 02:22 | |
*** hughsaunders has quit IRC | 02:23 | |
*** leifz has quit IRC | 02:25 | |
openstackgerrit | Alex Xu proposed openstack/nova-specs master: Add trait support in the allocation candidates API https://review.openstack.org/497713 | 02:27 |
*** sdake has joined #openstack-nova | 02:29 | |
*** sdake is now known as Guest20192 | 02:29 | |
*** leifz has joined #openstack-nova | 02:30 | |
*** hughsaunders has joined #openstack-nova | 02:31 | |
*** mvk has quit IRC | 02:31 | |
openstackgerrit | Alex Xu proposed openstack/nova master: placement: add traits support in the AllocationCandidates object https://review.openstack.org/479766 | 02:33 |
openstackgerrit | Alex Xu proposed openstack/nova master: placement: add traits to the 'GET /allocation_candidates' endpoint https://review.openstack.org/479776 | 02:33 |
openstackgerrit | Alex Xu proposed openstack/nova master: placement: the common method to filter resource providers by traits https://review.openstack.org/489206 | 02:33 |
openstackgerrit | Alex Xu proposed openstack/nova master: placement: add traits support to get resource_providers with shared https://review.openstack.org/478464 | 02:33 |
alex_xu | edleafe: hi, I added spec for traits in allcoation candidates API https://review.openstack.org/#/c/497713, do you want to add 'GET /resource_providers' in the spec also | 02:42 |
*** xinliang has quit IRC | 02:43 | |
*** sterdnotshaken has joined #openstack-nova | 02:54 | |
*** sterdnotshaken has quit IRC | 02:54 | |
*** yamamoto has joined #openstack-nova | 02:55 | |
*** edmondsw has quit IRC | 02:55 | |
*** xinliang has joined #openstack-nova | 02:55 | |
*** oomichi has quit IRC | 02:58 | |
*** oomichi has joined #openstack-nova | 02:58 | |
*** yamamoto has quit IRC | 03:00 | |
*** awaugama has joined #openstack-nova | 03:02 | |
*** _pewp_ has quit IRC | 03:03 | |
*** tpatil has quit IRC | 03:04 | |
*** sridharg has joined #openstack-nova | 03:04 | |
*** awaugama has quit IRC | 03:05 | |
*** nicolasbock has quit IRC | 03:06 | |
*** _pewp_ has joined #openstack-nova | 03:06 | |
openstackgerrit | melanie witt proposed openstack/nova master: Claim and report zero root disk for boot-from-volume instances https://review.openstack.org/428505 | 03:07 |
*** teddy__ has joined #openstack-nova | 03:08 | |
*** sridharg has quit IRC | 03:09 | |
*** teddy__ is now known as teddy24 | 03:12 | |
openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: define a new image handler to use vdi streaming https://review.openstack.org/486475 | 03:14 |
*** armax has quit IRC | 03:39 | |
*** teddy24 has quit IRC | 03:42 | |
*** kiennt has quit IRC | 03:45 | |
*** takedakn has joined #openstack-nova | 03:46 | |
mriedem | rc2 tag is merged https://review.openstack.org/#/c/497610/ | 03:49 |
*** takedakn has quit IRC | 03:50 | |
*** mriedem has quit IRC | 03:51 | |
*** mdnadeem has joined #openstack-nova | 03:51 | |
*** yamamoto has joined #openstack-nova | 03:56 | |
*** hongbin has quit IRC | 04:01 | |
openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: define a new image handler to use vdi streaming https://review.openstack.org/486475 | 04:01 |
*** yamamoto has quit IRC | 04:02 | |
*** lbragstad has quit IRC | 04:08 | |
*** marst has joined #openstack-nova | 04:11 | |
*** marst has quit IRC | 04:16 | |
*** tuanluong has quit IRC | 04:16 | |
*** gyee has joined #openstack-nova | 04:18 | |
*** armax has joined #openstack-nova | 04:26 | |
*** claudiub has joined #openstack-nova | 04:27 | |
*** gouthamr has quit IRC | 04:40 | |
*** edmondsw has joined #openstack-nova | 04:40 | |
*** mdnadeem has quit IRC | 04:44 | |
*** edmondsw has quit IRC | 04:45 | |
*** gyee has quit IRC | 04:57 | |
*** yamamoto has joined #openstack-nova | 04:58 | |
*** hoonetorg has quit IRC | 05:02 | |
*** yamamoto has quit IRC | 05:03 | |
*** links has joined #openstack-nova | 05:12 | |
*** gbarros has quit IRC | 05:12 | |
*** hoonetorg has joined #openstack-nova | 05:15 | |
*** udesale has joined #openstack-nova | 05:16 | |
*** damonl has joined #openstack-nova | 05:20 | |
damonl | cf | 05:23 |
*** markvoelker has quit IRC | 05:25 | |
*** armax has quit IRC | 05:30 | |
openstackgerrit | Alex Xu proposed openstack/nova-specs master: Report CPU features to placement service by traits API https://review.openstack.org/497733 | 05:37 |
*** mdnadeem has joined #openstack-nova | 05:39 | |
*** dikonoo has joined #openstack-nova | 05:45 | |
*** udesale has quit IRC | 05:50 | |
*** lpetrut has joined #openstack-nova | 05:52 | |
*** yamamoto has joined #openstack-nova | 05:54 | |
*** lajoskatona has joined #openstack-nova | 05:56 | |
*** tuanluong has joined #openstack-nova | 06:02 | |
*** TH3J0K3R has joined #openstack-nova | 06:08 | |
TH3J0K3R | I can't Ping/SSH the instances. Tried many things, still no luck. Need help | 06:09 |
*** kiennt has joined #openstack-nova | 06:09 | |
*** Oku_OS-away is now known as Oku_OS | 06:11 | |
*** rcernin has joined #openstack-nova | 06:14 | |
*** abalutoiu_ has joined #openstack-nova | 06:16 | |
*** belmoreira has joined #openstack-nova | 06:16 | |
*** abalutoiu_ has quit IRC | 06:20 | |
*** lpetrut has quit IRC | 06:24 | |
*** psachin has joined #openstack-nova | 06:26 | |
*** edmondsw has joined #openstack-nova | 06:29 | |
*** alex_xu has quit IRC | 06:30 | |
*** alex_xu has joined #openstack-nova | 06:33 | |
*** edmondsw has quit IRC | 06:33 | |
*** pcaruana has joined #openstack-nova | 06:40 | |
openstackgerrit | Kevin Zhao proposed openstack/nova master: Add video type virtio for AArch64 https://review.openstack.org/493822 | 06:44 |
openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: stubbing socket.gethostbyname https://review.openstack.org/497748 | 06:48 |
*** tesseract has joined #openstack-nova | 06:53 | |
openstackgerrit | Kevin Zhao proposed openstack/nova master: Modify the test case of get_disk_mapping_rescue_with_config https://review.openstack.org/494156 | 06:55 |
*** TH3J0K3R has quit IRC | 06:56 | |
openstackgerrit | liuxiuli proposed openstack/nova master: fix a typo in format_cpu_spec doc https://review.openstack.org/497750 | 06:57 |
*** TH3J0K3R has joined #openstack-nova | 06:58 | |
*** gcb has quit IRC | 07:05 | |
*** gcb has joined #openstack-nova | 07:07 | |
*** psachin has quit IRC | 07:07 | |
*** yamamoto has quit IRC | 07:08 | |
*** jpena|off is now known as jpena | 07:13 | |
openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: define a new image handler to use vdi streaming https://review.openstack.org/486475 | 07:15 |
*** trungnv has quit IRC | 07:18 | |
*** trungnv has joined #openstack-nova | 07:19 | |
openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: define a new image handler to use vdi streaming https://review.openstack.org/486475 | 07:21 |
*** sahid has joined #openstack-nova | 07:22 | |
*** alexchadin has joined #openstack-nova | 07:24 | |
*** markvoelker has joined #openstack-nova | 07:25 | |
*** jianghuaw has joined #openstack-nova | 07:26 | |
*** phuongnh has quit IRC | 07:29 | |
*** phuongnh has joined #openstack-nova | 07:30 | |
*** psachin has joined #openstack-nova | 07:30 | |
*** psachin has quit IRC | 07:30 | |
*** psachin has joined #openstack-nova | 07:30 | |
*** abalutoiu_ has joined #openstack-nova | 07:31 | |
*** tuanluong has quit IRC | 07:32 | |
*** dklyle has joined #openstack-nova | 07:32 | |
*** david-lyle has quit IRC | 07:34 | |
VAhl | openstack server create [...] ==> Failed to retrieve resource provider record from placement API. Inspite that there is more than enought resources in the system for the created virtual server. See paste with start command and log http://paste.openstack.org/show/619397/ | 07:34 |
*** mnestratov|2 has joined #openstack-nova | 07:42 | |
*** psachin has quit IRC | 07:46 | |
*** psachin has joined #openstack-nova | 07:48 | |
*** dikonoo has quit IRC | 07:49 | |
*** yamamoto has joined #openstack-nova | 07:50 | |
*** abalutoiu_ has quit IRC | 07:51 | |
openstackgerrit | Damon Li proposed openstack/nova master: Fix bug on vmware driver attach volume failed https://review.openstack.org/496140 | 07:52 |
openstackgerrit | Damon Li proposed openstack/nova master: Fix bug on vmware driver attach volume failed https://review.openstack.org/496140 | 07:53 |
*** vipul has quit IRC | 07:54 | |
*** alexchadin has quit IRC | 07:54 | |
*** slaweq has joined #openstack-nova | 07:56 | |
*** vipul has joined #openstack-nova | 07:57 | |
*** lpetrut has joined #openstack-nova | 07:57 | |
*** markus_z has joined #openstack-nova | 07:58 | |
*** markvoelker has quit IRC | 08:00 | |
*** dtantsur|afk is now known as dtantsur | 08:04 | |
*** alexchadin has joined #openstack-nova | 08:06 | |
*** yamamoto has quit IRC | 08:06 | |
*** yamamoto has joined #openstack-nova | 08:07 | |
*** derekh has joined #openstack-nova | 08:16 | |
*** edmondsw has joined #openstack-nova | 08:17 | |
*** edmondsw has quit IRC | 08:21 | |
*** vipul has quit IRC | 08:23 | |
*** lucas-afk is now known as lucasagomes | 08:24 | |
*** vipul has joined #openstack-nova | 08:25 | |
*** dklyle has quit IRC | 08:25 | |
openstackgerrit | jichenjc proposed openstack/nova master: propagate OSError to MigrationPreCheckError https://review.openstack.org/469779 | 08:25 |
*** efoley has joined #openstack-nova | 08:29 | |
*** abalutoiu_ has joined #openstack-nova | 08:30 | |
*** mnestratov|2 is now known as mnestratov | 08:35 | |
openstackgerrit | jichenjc proposed openstack/nova master: WIP: use conf for keystone session creation https://review.openstack.org/485121 | 08:36 |
*** carthaca_ has quit IRC | 08:37 | |
*** carthaca_ has joined #openstack-nova | 08:37 | |
*** rmart04 has joined #openstack-nova | 08:39 | |
*** mvk has joined #openstack-nova | 08:40 | |
*** cdent has joined #openstack-nova | 08:49 | |
*** dtantsur is now known as dtantsur|sick | 08:50 | |
*** phuongnh has quit IRC | 08:53 | |
*** phuongnh has joined #openstack-nova | 08:54 | |
*** rabel has joined #openstack-nova | 08:55 | |
rabel | so, vmware ci insists to fail on https://review.openstack.org/#/c/494169/ but imho the error has nothing to do with the patch set. it should be ready for final review / merging than, i guess. | 08:57 |
*** markvoelker has joined #openstack-nova | 08:57 | |
*** hferenc has quit IRC | 08:57 | |
cdent | rabel: vmware ci is borked, you can’t trust it at the moment, unfortunately | 08:59 |
cdent | rabel: as long as your unit tests are fairly complete, should be okay | 09:00 |
rabel | cdent: should be, yes. | 09:02 |
*** hferenc has joined #openstack-nova | 09:05 | |
cdent | gabor_antal: thanks for commenting on the complexity thing and including those references, especially to the test results, great to see | 09:08 |
gabor_antal | cdent: you're welcome. Hope the community finds it interesting too | 09:09 |
cdent | gabor_antal: I think there are plenty of people who find it interesting. The challenge is often finding the review bandwidth to get the stuff merged (as you’ve experienced). | 09:11 |
gabor_antal | cdent: that is true, but we have also lots of patches, which are stuck, and just reopened now, maybe someone has an idea to move on. | 09:12 |
*** abalutoiu_ has quit IRC | 09:13 | |
*** abalutoiu_ has joined #openstack-nova | 09:18 | |
*** phuongnh has quit IRC | 09:21 | |
*** jistr is now known as jistr|trng | 09:21 | |
*** hferenc has quit IRC | 09:26 | |
*** dikonoo has joined #openstack-nova | 09:27 | |
*** rmart04 has quit IRC | 09:29 | |
*** rmart04 has joined #openstack-nova | 09:29 | |
*** markvoelker has quit IRC | 09:30 | |
*** Shunli has quit IRC | 09:30 | |
openstackgerrit | Lei Zhang proposed openstack/nova master: placement: add traits to the 'GET /allocation_candidates' endpoint https://review.openstack.org/479776 | 09:31 |
*** sambetts|afk is now known as sambetts | 09:34 | |
*** ababich has quit IRC | 09:34 | |
*** yingjun has quit IRC | 09:42 | |
openstackgerrit | Radoslav Gerganov proposed openstack/nova master: Update all instances when their AZ is renamed https://review.openstack.org/419502 | 09:48 |
*** chenying has joined #openstack-nova | 09:54 | |
*** jaypipes has joined #openstack-nova | 09:54 | |
*** gixxer1k has joined #openstack-nova | 09:56 | |
*** abalutoiu_ has quit IRC | 09:56 | |
*** dixiaoli has quit IRC | 09:57 | |
*** dixiaoli has joined #openstack-nova | 09:58 | |
*** kiennt has quit IRC | 10:00 | |
*** dixiaoli has quit IRC | 10:00 | |
*** s-dean has quit IRC | 10:02 | |
*** openstackgerrit has quit IRC | 10:02 | |
*** trungnv has quit IRC | 10:02 | |
*** edmondsw has joined #openstack-nova | 10:05 | |
*** nicolasbock has joined #openstack-nova | 10:05 | |
*** edmondsw has quit IRC | 10:09 | |
*** alexchadin has quit IRC | 10:11 | |
*** belmoreira has quit IRC | 10:13 | |
*** damonl has quit IRC | 10:16 | |
*** nicolasbock has quit IRC | 10:23 | |
*** trinaths has joined #openstack-nova | 10:26 | |
*** markvoelker has joined #openstack-nova | 10:26 | |
*** nicolasbock has joined #openstack-nova | 10:29 | |
*** sahid has quit IRC | 10:31 | |
*** abalutoiu_ has joined #openstack-nova | 10:34 | |
*** rcernin is now known as rcernin|lunch | 10:34 | |
*** openstackgerrit has joined #openstack-nova | 10:37 | |
openstackgerrit | Maciej Kucia proposed openstack/nova master: SR-IOV passthrough: Check PF only if VF is enabled https://review.openstack.org/476642 | 10:37 |
*** sahid has joined #openstack-nova | 10:46 | |
*** mdbooth[m] has joined #openstack-nova | 10:55 | |
*** yangyapeng has quit IRC | 10:55 | |
*** mdbooth has quit IRC | 10:58 | |
*** mdbooth[m] is now known as mdbooth | 10:59 | |
*** swamireddy has quit IRC | 10:59 | |
*** markvoelker has quit IRC | 11:00 | |
*** cdent has quit IRC | 11:02 | |
*** _pewp_ has quit IRC | 11:10 | |
*** _pewp_ has joined #openstack-nova | 11:13 | |
*** smatzek has joined #openstack-nova | 11:19 | |
*** frickler has quit IRC | 11:26 | |
*** gcb has quit IRC | 11:28 | |
*** gcb has joined #openstack-nova | 11:29 | |
*** kuzko has quit IRC | 11:41 | |
*** andreaf has quit IRC | 11:41 | |
*** lucasagomes has quit IRC | 11:41 | |
*** hwoarang has quit IRC | 11:41 | |
*** markmc has quit IRC | 11:41 | |
*** thomasem has quit IRC | 11:41 | |
*** tobasco has quit IRC | 11:41 | |
*** mmedvede has quit IRC | 11:41 | |
*** andreykurilin has quit IRC | 11:41 | |
*** Guest45420 has quit IRC | 11:41 | |
*** zerda3 has quit IRC | 11:41 | |
*** cburgess has quit IRC | 11:41 | |
*** dansmith has quit IRC | 11:41 | |
*** tojuvone has quit IRC | 11:41 | |
*** EmilienM has quit IRC | 11:41 | |
*** keekz has quit IRC | 11:41 | |
*** johnthetubaguy has quit IRC | 11:41 | |
*** ttx has quit IRC | 11:41 | |
*** zeroDivisible has quit IRC | 11:41 | |
*** sambetts has quit IRC | 11:41 | |
*** ioni has quit IRC | 11:41 | |
*** jamiec has quit IRC | 11:41 | |
*** mdrabe has quit IRC | 11:41 | |
*** yankcrime has quit IRC | 11:41 | |
*** slunkad has quit IRC | 11:41 | |
*** NostawRm has quit IRC | 11:41 | |
*** efoley has quit IRC | 11:41 | |
*** alex_xu has quit IRC | 11:41 | |
*** hughsaunders has quit IRC | 11:41 | |
*** gabor_antal has quit IRC | 11:41 | |
*** zul has quit IRC | 11:41 | |
*** ircuser-1 has quit IRC | 11:41 | |
*** betherly has quit IRC | 11:41 | |
*** TheJulia has quit IRC | 11:41 | |
*** serverascode has quit IRC | 11:41 | |
*** robcresswell has quit IRC | 11:41 | |
*** scottda has quit IRC | 11:41 | |
*** carl_baldwin has quit IRC | 11:41 | |
*** patrickeast has quit IRC | 11:41 | |
*** ameade has quit IRC | 11:41 | |
*** samueldmq has quit IRC | 11:41 | |
*** cargonza has quit IRC | 11:41 | |
*** icey has quit IRC | 11:41 | |
*** mgagne has quit IRC | 11:41 | |
*** fungi has quit IRC | 11:41 | |
*** tomhambleton_ has quit IRC | 11:41 | |
*** rushiagr has quit IRC | 11:41 | |
*** johnsom has quit IRC | 11:41 | |
*** vdrok has quit IRC | 11:41 | |
*** fyxim has quit IRC | 11:41 | |
*** toan has quit IRC | 11:41 | |
*** raorn has quit IRC | 11:41 | |
*** karlamrhein has quit IRC | 11:41 | |
*** NobodyCam has quit IRC | 11:41 | |
*** wolsen has quit IRC | 11:41 | |
*** aweeks has quit IRC | 11:41 | |
*** trinaths has quit IRC | 11:41 | |
*** dikonoo has quit IRC | 11:41 | |
*** mvk has quit IRC | 11:41 | |
*** TH3J0K3R has quit IRC | 11:41 | |
*** tesseract has quit IRC | 11:41 | |
*** pcaruana has quit IRC | 11:41 | |
*** links has quit IRC | 11:41 | |
*** claudiub has quit IRC | 11:41 | |
*** hamzy has quit IRC | 11:41 | |
*** masber has quit IRC | 11:41 | |
*** dpawlik has quit IRC | 11:41 | |
*** ps_jadhav has quit IRC | 11:41 | |
*** pooja_jadhav has quit IRC | 11:41 | |
*** bhagyashris_ has quit IRC | 11:41 | |
*** tbachman has quit IRC | 11:41 | |
*** imacdonn has quit IRC | 11:41 | |
*** zz9pzza has quit IRC | 11:41 | |
*** yassine has quit IRC | 11:41 | |
*** liusheng has quit IRC | 11:41 | |
*** jbernard has quit IRC | 11:41 | |
*** redondo-mk has quit IRC | 11:41 | |
*** sergek_ has quit IRC | 11:41 | |
*** mrhillsman has quit IRC | 11:41 | |
*** jbryce has quit IRC | 11:41 | |
*** amotoki__away has quit IRC | 11:41 | |
*** shravani has quit IRC | 11:41 | |
*** ChanServ has quit IRC | 11:41 | |
*** abalutoiu_ has quit IRC | 11:41 | |
*** gixxer1k has quit IRC | 11:41 | |
*** derekh has quit IRC | 11:41 | |
*** yamamoto has quit IRC | 11:41 | |
*** markus_z has quit IRC | 11:41 | |
*** lpetrut has quit IRC | 11:41 | |
*** lajoskatona has quit IRC | 11:41 | |
*** iceyao has quit IRC | 11:41 | |
*** lennyb has quit IRC | 11:41 | |
*** kencjohnston has quit IRC | 11:41 | |
*** jlvillal has quit IRC | 11:41 | |
*** jcook has quit IRC | 11:41 | |
*** jpena has quit IRC | 11:41 | |
*** jogo has quit IRC | 11:41 | |
*** jdurgin has quit IRC | 11:41 | |
*** Qiming has quit IRC | 11:41 | |
*** mlakat has quit IRC | 11:41 | |
*** jaosorior has quit IRC | 11:41 | |
*** bauzas has quit IRC | 11:41 | |
*** diegows has quit IRC | 11:41 | |
*** lyarwood has quit IRC | 11:41 | |
*** zzzeek has quit IRC | 11:41 | |
*** purplerbot has quit IRC | 11:41 | |
*** aloga has quit IRC | 11:41 | |
*** gibi has quit IRC | 11:41 | |
*** syjulian has quit IRC | 11:41 | |
*** kornicameister has quit IRC | 11:41 | |
*** igordc has quit IRC | 11:41 | |
*** stephenfin has quit IRC | 11:41 | |
*** StevenK has quit IRC | 11:41 | |
*** htruta has quit IRC | 11:41 | |
*** wasmum has quit IRC | 11:41 | |
*** simondodsley has quit IRC | 11:41 | |
*** rhagarty has quit IRC | 11:41 | |
*** john5223 has quit IRC | 11:41 | |
*** kmalloc has quit IRC | 11:41 | |
*** gus has quit IRC | 11:41 | |
*** alezil has quit IRC | 11:41 | |
*** csatari has quit IRC | 11:41 | |
*** knikolla has quit IRC | 11:41 | |
*** McNinja has quit IRC | 11:41 | |
*** Dinesh_Bhor has quit IRC | 11:41 | |
*** toabctl has quit IRC | 11:41 | |
*** junbo has quit IRC | 11:41 | |
*** dtantsur|sick has quit IRC | 11:41 | |
*** alaski has quit IRC | 11:41 | |
*** seba has quit IRC | 11:41 | |
*** jamielennox has quit IRC | 11:41 | |
*** BlackDex has quit IRC | 11:41 | |
*** test222 has quit IRC | 11:41 | |
*** auggy has quit IRC | 11:41 | |
*** DuncanT has quit IRC | 11:41 | |
*** zioproto has quit IRC | 11:41 | |
*** khappone has quit IRC | 11:41 | |
*** litao__ has quit IRC | 11:41 | |
*** sulo has quit IRC | 11:41 | |
*** stvnoyes has quit IRC | 11:41 | |
*** aarefiev has quit IRC | 11:41 | |
*** Dave has quit IRC | 11:41 | |
*** bswartz has quit IRC | 11:41 | |
*** ansiwen has quit IRC | 11:41 | |
*** thingee has quit IRC | 11:41 | |
*** gcb has quit IRC | 11:41 | |
*** itlinux has quit IRC | 11:41 | |
*** tinwood has quit IRC | 11:41 | |
*** comstud has quit IRC | 11:41 | |
*** afazekas has quit IRC | 11:41 | |
*** Hazelesque has quit IRC | 11:41 | |
*** guimaluf has quit IRC | 11:41 | |
*** d9k has quit IRC | 11:41 | |
*** MasterofJOKers has quit IRC | 11:41 | |
*** andymccr has quit IRC | 11:41 | |
*** clarkb has quit IRC | 11:41 | |
*** dr_gogeta86 has quit IRC | 11:41 | |
*** asettle has quit IRC | 11:41 | |
*** _pewp_ has quit IRC | 11:41 | |
*** nicolasbock has quit IRC | 11:41 | |
*** jaypipes has quit IRC | 11:41 | |
*** oomichi has quit IRC | 11:41 | |
*** oanson has quit IRC | 11:41 | |
*** vishwana_ has quit IRC | 11:41 | |
*** hieulq has quit IRC | 11:41 | |
*** mrodden has quit IRC | 11:41 | |
*** mikal has quit IRC | 11:41 | |
*** kylek3h has quit IRC | 11:41 | |
*** vvargaszte has quit IRC | 11:41 | |
*** owalsh has quit IRC | 11:41 | |
*** rtjure has quit IRC | 11:41 | |
*** edleafe has quit IRC | 11:41 | |
*** brad[] has quit IRC | 11:41 | |
*** john5223_ has quit IRC | 11:41 | |
*** aries has quit IRC | 11:41 | |
*** csuttles has quit IRC | 11:41 | |
*** Anticimex has quit IRC | 11:41 | |
*** MikeG451 has quit IRC | 11:41 | |
*** szaher has quit IRC | 11:41 | |
*** sahid has quit IRC | 11:41 | |
*** xinliang has quit IRC | 11:41 | |
*** Jeffrey4l has quit IRC | 11:41 | |
*** DinaBelova has quit IRC | 11:41 | |
*** lifeless has quit IRC | 11:41 | |
*** sapd has quit IRC | 11:41 | |
*** ejat has quit IRC | 11:41 | |
*** logan- has quit IRC | 11:41 | |
*** jeblair has quit IRC | 11:41 | |
*** dgonzalez has quit IRC | 11:41 | |
*** mdbooth has quit IRC | 11:41 | |
*** rcernin|lunch has quit IRC | 11:41 | |
*** sbezverk has quit IRC | 11:41 | |
*** ebbex has quit IRC | 11:41 | |
*** rha has quit IRC | 11:41 | |
*** dims has quit IRC | 11:41 | |
*** raginbajin has quit IRC | 11:41 | |
*** med_ has quit IRC | 11:41 | |
*** ericyoung has quit IRC | 11:41 | |
*** larsks has quit IRC | 11:41 | |
*** jgriffith has quit IRC | 11:41 | |
*** sgordon has quit IRC | 11:41 | |
*** inara has quit IRC | 11:41 | |
*** rfolco has quit IRC | 11:41 | |
*** mnaser has quit IRC | 11:41 | |
*** devananda has quit IRC | 11:41 | |
*** zigo has quit IRC | 11:41 | |
*** antonym has quit IRC | 11:41 | |
*** egarbade has quit IRC | 11:41 | |
*** s1061123 has quit IRC | 11:41 | |
*** ekhugen has quit IRC | 11:41 | |
*** mfisch has quit IRC | 11:41 | |
*** VAhl has quit IRC | 11:41 | |
*** Nil_ has quit IRC | 11:41 | |
*** rnoriega has quit IRC | 11:41 | |
*** tanee has quit IRC | 11:41 | |
*** smatzek has quit IRC | 11:41 | |
*** FL1SK has quit IRC | 11:41 | |
*** Tahvok has quit IRC | 11:41 | |
*** ianw has quit IRC | 11:41 | |
*** clayton has quit IRC | 11:41 | |
*** maciejjozefczyk has quit IRC | 11:41 | |
*** Gorian has quit IRC | 11:41 | |
*** mtreinish has quit IRC | 11:41 | |
*** mhenkel has quit IRC | 11:41 | |
*** kaisers has quit IRC | 11:41 | |
*** openstackgerrit has quit IRC | 11:41 | |
*** rabel has quit IRC | 11:41 | |
*** slaweq has quit IRC | 11:41 | |
*** psachin has quit IRC | 11:41 | |
*** leifz has quit IRC | 11:41 | |
*** Guest20192 has quit IRC | 11:41 | |
*** thorst_afk has quit IRC | 11:41 | |
*** ildikov has quit IRC | 11:41 | |
*** kukacz has quit IRC | 11:41 | |
*** aignatov has quit IRC | 11:41 | |
*** d34dh0r53 has quit IRC | 11:41 | |
*** mordred has quit IRC | 11:41 | |
*** geekinutah has quit IRC | 11:41 | |
*** andrewbogott has quit IRC | 11:41 | |
*** tommylikehu has quit IRC | 11:41 | |
*** efried has quit IRC | 11:41 | |
*** larainema has quit IRC | 11:41 | |
*** ying_zuo has quit IRC | 11:41 | |
*** rm_work has quit IRC | 11:41 | |
*** markmcclain has quit IRC | 11:41 | |
*** anthonyper has quit IRC | 11:41 | |
*** zhenguo has quit IRC | 11:41 | |
*** jamespage has quit IRC | 11:41 | |
*** fmccrthy has quit IRC | 11:41 | |
*** harlowja has quit IRC | 11:41 | |
*** fnordahl has quit IRC | 11:41 | |
*** rmk has quit IRC | 11:41 | |
*** mwhahaha has quit IRC | 11:41 | |
*** Kevin_Zheng has quit IRC | 11:41 | |
*** Oku_OS has quit IRC | 11:41 | |
*** melwitt has quit IRC | 11:41 | |
*** sballe_ has quit IRC | 11:41 | |
*** rajinir has quit IRC | 11:41 | |
*** rmart04 has quit IRC | 11:41 | |
*** jianghuaw has quit IRC | 11:41 | |
*** gmann has quit IRC | 11:41 | |
*** coreywright has quit IRC | 11:41 | |
*** sapcc-bot has quit IRC | 11:41 | |
*** spotz has quit IRC | 11:41 | |
*** wxy has quit IRC | 11:41 | |
*** Yingxin has quit IRC | 11:41 | |
*** shaohe_feng has quit IRC | 11:41 | |
*** tristanC has quit IRC | 11:41 | |
*** migi has quit IRC | 11:41 | |
*** smcginnis has quit IRC | 11:41 | |
*** jistr|trng has quit IRC | 11:41 | |
*** rybridges1 has quit IRC | 11:41 | |
*** hemna has quit IRC | 11:41 | |
*** weshay has quit IRC | 11:41 | |
*** chenying has quit IRC | 11:41 | |
*** carthaca_ has quit IRC | 11:41 | |
*** mnestratov has quit IRC | 11:41 | |
*** mdnadeem has quit IRC | 11:41 | |
*** cfriesen_ has quit IRC | 11:41 | |
*** bkopilov has quit IRC | 11:41 | |
*** bnemec has quit IRC | 11:41 | |
*** dosaboy has quit IRC | 11:41 | |
*** gaurangt- has quit IRC | 11:41 | |
*** adreznec has quit IRC | 11:41 | |
*** ujjain has quit IRC | 11:41 | |
*** obre has quit IRC | 11:41 | |
*** rodrigods has quit IRC | 11:41 | |
*** jotr has quit IRC | 11:41 | |
*** jhesketh has quit IRC | 11:41 | |
*** vipul has quit IRC | 11:41 | |
*** hoonetorg has quit IRC | 11:41 | |
*** mgariepy has quit IRC | 11:41 | |
*** zhurong has quit IRC | 11:41 | |
*** sean-k-mooney has quit IRC | 11:41 | |
*** kashyap has quit IRC | 11:41 | |
*** kevinbenton has quit IRC | 11:41 | |
*** ltomasbo has quit IRC | 11:41 | |
*** tonyb has quit IRC | 11:41 | |
*** masayukig has quit IRC | 11:41 | |
*** mwynne has quit IRC | 11:41 | |
*** eandersson has quit IRC | 11:41 | |
*** tyrefors has quit IRC | 11:41 | |
*** gryf has quit IRC | 11:41 | |
*** openstack has joined #openstack-nova | 12:58 | |
*** iceyao has quit IRC | 12:58 | |
*** openstackstatus has joined #openstack-nova | 12:58 | |
*** ChanServ sets mode: +v openstackstatus | 12:58 | |
*** Wair1978 has joined #openstack-nova | 13:00 | |
*** lyan has joined #openstack-nova | 13:06 | |
*** markvoelker has joined #openstack-nova | 13:06 | |
*** Wair1978 has left #openstack-nova | 13:10 | |
*** pchavva has joined #openstack-nova | 13:11 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: bandwidth param should be set in guest migrate https://review.openstack.org/497455 | 13:18 |
*** gouthamr has joined #openstack-nova | 13:18 | |
*** vikrant has joined #openstack-nova | 13:21 | |
openstackgerrit | Merged openstack/nova master: Fix bug on vmware driver attach volume failed https://review.openstack.org/496140 | 13:22 |
*** artom has joined #openstack-nova | 13:27 | |
*** hieulq has quit IRC | 13:29 | |
*** josecastroleon has joined #openstack-nova | 13:32 | |
*** jmlowe has joined #openstack-nova | 13:33 | |
*** sbezverk has quit IRC | 13:35 | |
*** links has quit IRC | 13:37 | |
*** esberglu has joined #openstack-nova | 13:37 | |
*** aloga has quit IRC | 13:37 | |
*** gyee has joined #openstack-nova | 13:38 | |
*** burt has joined #openstack-nova | 13:43 | |
*** gbarros has joined #openstack-nova | 13:43 | |
*** awaugama has joined #openstack-nova | 13:43 | |
*** sbezverk has joined #openstack-nova | 13:47 | |
*** iceyao has joined #openstack-nova | 13:48 | |
*** mriedem has joined #openstack-nova | 13:49 | |
*** lbragstad has joined #openstack-nova | 13:49 | |
*** eharney has joined #openstack-nova | 13:51 | |
*** hongbin has joined #openstack-nova | 13:57 | |
*** guimaluf has quit IRC | 13:57 | |
efried | Who's an expert on PCI passthrough in nova? (The internals, not the ux) | 13:58 |
stephenfin | efried: Nice work on https://review.openstack.org/#/c/493701/ | 13:58 |
efried | stephenfin Thanks :) | 13:58 |
stephenfin | efried: I have a rough idea on it, but I'm not expert. moshele and sean-k-mooney know their stuff though | 13:58 |
stephenfin | *no | 13:59 |
efried | stephenfin Okay, at least for the sake of having a sounding board, here's what I'm trying to work with: | 14:00 |
efried | On Power, our PCI devices don't have 32-bit domain:bus:slot.func PCI addresses. | 14:00 |
*** saphi has joined #openstack-nova | 14:01 | |
efried | The nova PCI code around whitelisting, passthrough devices, and aliases is *all* set up to assume domain:bus:slot.func | 14:01 |
* cdent sits and listens to efried and stephenfin | 14:01 | |
*** lucasxu has joined #openstack-nova | 14:01 | |
efried | At the moment, if I want to make PCI passthrough work in PowerVM, I have to very carefully leave out any reference to addresses in the whitelist & alias specs. | 14:02 |
openstackgerrit | sahid proposed openstack/nova master: libvirt: slowly live-migration to ensure network is ready https://review.openstack.org/497457 | 14:02 |
openstackgerrit | sahid proposed openstack/nova master: libvirt: add method to configure migration speed https://review.openstack.org/497456 | 14:02 |
openstackgerrit | sahid proposed openstack/nova master: libvirt: bandwidth param should be set in guest migrate https://review.openstack.org/497455 | 14:02 |
efried | And when I create my pci_passthrough_devices list (from get_available_resource), I have to spoof a domain:bus:slot.func PCI address for each dev. | 14:02 |
efried | Cause each dev has to have a distinct address, or it won't get recognized at all. | 14:02 |
efried | So this leads to a couple of problems. | 14:03 |
efried | One is that I have to hack these addresses horribly. (And from a 64-bit source, so possibility of collisions, etc.) | 14:03 |
*** hferenc has joined #openstack-nova | 14:03 | |
efried | The other is that I've given my op the ability to whitelist device *classes* (vendor x prod ID) but not specific devices. | 14:04 |
efried | Because as soon as I try to specify a device in the whitelist, nova tries to get at /sys/bus/.../<PCI address>/... | 14:04 |
efried | ...which isn't a thing in PowerVM. | 14:04 |
efried | btw, I have reason to believe HyperV and VMWare (and maybe xen) suffer from a similar class of problem (the devs not being owned by the node running the compute process). | 14:05 |
efried | So | 14:05 |
* stephenfin is pretty sure there's something funky about how PCI addresses are handled with Xen alright | 14:06 | |
stephenfin | HyperV too, for that matter. I don't know the specifics though | 14:06 |
efried | One possible inroads may be the new resource provider stuff. | 14:07 |
cdent | I was just going to say that nest providers will help with this, but it is a long road before it completely resolves it | 14:08 |
efried | If my compute node registers a rp that provides the PCI devs as generic resources, they could conceivably have arbitrary names/identifiers. | 14:08 |
efried | But we would have to replumb the whole whitelist concept if we wanted to support whitelist filtering. | 14:09 |
efried | I would be happy to reimplement whitelisting in a way that works for PowerVM, but would have to have some way to bypass the whitelisting that nova's doing. | 14:10 |
cdent | the long term goal (jaypipes can you confirm this?) would be to get rid of the on-node whitelist stuff | 14:10 |
efried | [pci]whitelist_by_compute_driver = True | 14:10 |
stephenfin | Yeah, the plan was to move most of the PCI device management code to resource providers | 14:11 |
stephenfin | Any vGPU stuff would also be done this way | 14:11 |
efried | Yeah, jaypipes and I talked briefly about that in Boston. | 14:11 |
stephenfin | Hmm, so how do you define what devices can/can't be used if you don't have unique identifiers like that? | 14:11 |
efried | oh, I have unique identifiers. | 14:12 |
efried | They just don't look like domain:bus:slot.func | 14:12 |
cdent | bigger better unique identifiers! | 14:12 |
cdent | bbuid | 14:12 |
stephenfin | Ah | 14:12 |
efried | My IDs look like U78CB.001.WZS0JZB-P1-C14 or 2105001F | 14:13 |
stephenfin | So I guess you'd do your whitelisting using those identifiers. If so , would that be done inside nova? | 14:13 |
edmondsw | (those are 2 different formats... not different values of the same format... either should work) | 14:14 |
* edmondsw would prefer the first format | 14:14 | |
stephenfin | i.e. 'if driver = powervm: do special whitelisting; else: do normal domain:bus:slot.func whitelist' | 14:14 |
efried | Yeah, in nova right now all the Whitelist and PciDeviceStats and PciAlias stuff is hardwired to expect domain:bus:slot.func format, down to the point of being able to wildcard any of those components. | 14:15 |
efried | So if you whitelisted *:12:ab.*, you would match a device with address abcd:12:ab.7 but not abcd:13:ab.7 | 14:15 |
efried | And then there are some code paths that actually try to look up attributes of the device under /sys/bus - which is a total nonstarter on Power (and, I assume, HyperV and VMWare, where the devices also aren't on the compute node) | 14:16 |
efried | ...like when it's trying to figure out if a dev is a physical function. | 14:16 |
efried | ...or if the whitelist specifies a dev by name | 14:16 |
stephenfin | claudiub is hardly about, is he? I'm pretty sure the Hyper-V driver does have some PCI device support now | 14:17 |
cdent | I was just looking at some of that code and wondered if perhaps that it ought to be in the virt drivers: https://review.openstack.org/#/c/476642/ | 14:17 |
jaypipes | cdent, efried: yeah, I remember chatting with you about it in Boston, though I think I said I would be happy to just stop using the whitelist for two purposes (filtering stuff that guests can use vs. inventory management of devices) | 14:17 |
*** viaggarw has joined #openstack-nova | 14:17 | |
cdent | it’s rather limiting that it is doing /sys file stuff ... | 14:17 |
*** marst has joined #openstack-nova | 14:18 | |
efried | Yeah, those are two examples where I would like to be able to have e.g. "is_physical_function" be a compute driver override whose default impl could be the /sys/bus business, but in the powervm driver I can do it my way. | 14:18 |
*** dklyle has joined #openstack-nova | 14:19 | |
efried | jaypipes Right, so the inventory is actually being done by get_available_resource (which will eventually become get_inventory when all the plumbing is ready). | 14:19 |
efried | The whitelist is how you limit which devices are allowed to be assigned. | 14:19 |
efried | And then the alias list is how you nickname devices or device classes so you can specify them easily in a flavor. | 14:20 |
jaypipes | ya | 14:20 |
efried | So really, the conf stuff isn't doing inventorying. | 14:20 |
jaypipes | if we can just have the whitelist do the former thing and not the latter, I'd be happy | 14:20 |
*** vikrant has quit IRC | 14:20 | |
jaypipes | efried: zactly. | 14:20 |
efried | which former/latter? | 14:21 |
jaypipes | efried: my only question is why haven't you gotten it all done yet? WAITING! | 14:21 |
mriedem | (filtering stuff that guests can use vs. inventory management of devices) | 14:21 |
mriedem | "(filtering stuff that guests can use vs. inventory management of devices)" | 14:21 |
mriedem | you turkeys | 14:21 |
jaypipes | efried: former == filtering for guests. | 14:21 |
efried | hm, how is the current impl of the whitelist doing inventory management? | 14:21 |
jaypipes | would be nice if IBM would just hop on the "newfangled" PCI bus. | 14:22 |
efried | Hah! | 14:22 |
claudiub | stephenfin: o/ | 14:22 |
jaypipes | efried: :P | 14:22 |
*** armax has joined #openstack-nova | 14:22 | |
claudiub | stephenfin: yeah, we do support pci passthrough since ocata. | 14:22 |
efried | and jaypipes, I actually have a prototype/PoC that works for PowerVM. But I very carefully have to bypass PCI address handling in some interesting ways. | 14:23 |
stephenfin | claudiub: Cool. How do you manage whitelisting of those devices? I assume you're not indexing devices in domain:bus:slot.func format | 14:23 |
jaypipes | efried: yes, I can imagine. | 14:23 |
efried | https://review.openstack.org/#/c/496434/ | 14:23 |
* jaypipes gets out red pen | 14:24 | |
claudiub | stephenfin: we are. | 14:24 |
*** markus_z has quit IRC | 14:24 | |
claudiub | stephenfin: we're currently only reporting devices which have the domain:bus:slot.func format | 14:24 |
efried | ...with e.g. [pci]alias = {"name": "USB", "product_id": "8241", "vendor_id": "104c", "device_type": "type-PCI"} and [pci]passthrough_whitelist = {"product_id": "8241", "vendor_id": "104c"} | 14:25 |
efried | claudiub Those devices show up on the compute node? | 14:26 |
claudiub | stephenfin: but I've mainly whitelisted devices using product_id / vendor_id | 14:26 |
claudiub | efried: if they're are passthrough-able, yes. | 14:26 |
claudiub | efried: they have to be prepared for passthrough first | 14:26 |
efried | claudiub How? | 14:27 |
*** ijw has joined #openstack-nova | 14:27 | |
claudiub | efried: https://github.com/openstack/nova/blob/master/releasenotes/notes/hyper-v-pci-passthrough-babf104d6bc2baa6.yaml | 14:27 |
jaypipes | efried: reviewed. | 14:28 |
efried | Oh, thanks jaypipes :) | 14:29 |
* jaypipes tests efried's infamous sense of humour. | 14:29 | |
claudiub | stephenfin: anyways. it would be nice to be also be able to whitelist devices using other ways than product_id / vendor_id, or domain:bus:slot.func. | 14:29 |
efried | jaypipes Nice. None of that was worthy of a -1? Really? | 14:29 |
stephenfin | claudiub: What kind of IDs would you expect, e.g. how else can devices be identified in Hyper-V? | 14:30 |
jaypipes | efried: :) | 14:30 |
jaypipes | stephenfin: by green card. | 14:30 |
efried | jaypipes I really didn't expect you to review it, but I would like to point out the spoof_pci_address method (https://review.openstack.org/#/c/496434/3/nova_powervm/virt/powervm/vm.py@884) | 14:31 |
claudiub | stephenfin: for example, I've had this issue when working on the sr-iov support. apparenty, different NIC vendors have different PCI device ID formats. for example, Intel NICs contain the vendor_id and product_id, which can be extracted and reported. But other NICs, like Mellanox or Chelsio, do not. | 14:31 |
claudiub | stephenfin: a simple device_id would do, IMO. | 14:31 |
jaypipes | efried: oh, trust me, I saw it :) | 14:31 |
efried | claudiub Right, so I would like my [pci]passthrough_whitelist entry to identify devices in whatever way my compute deems appropriate, and have the logic for doing that whitelist filtering live in my compute driver. | 14:33 |
*** felipemonteiro has joined #openstack-nova | 14:35 | |
claudiub | efried: well, the compute driver is already reporting "all" the PCI devices it sees, right? after which the PCI resource tracker filters those compute driver reported PCI devices according to the configured whitelist. is there anything that doesn't fit your usecase? | 14:36 |
efried | claudiub Yeah: the ability to specify individual devices in the whitelist (vs. just vendor/prod ID classes) | 14:37 |
efried | Because as soon as I start chucking addresses around, nova tries to get at them under /sys/bus/... | 14:37 |
stephenfin | efried, jaypipes: Would we still have per-compute-node filtering in the resource provider world? | 14:38 |
*** cali_boxer has joined #openstack-nova | 14:38 | |
claudiub | efried: ah yes, i see. that would make sense, IMO. the pci resource tracker should be updated to allow other filters to be configured, imo. | 14:38 |
* stephenfin assumes we probably would, seeing as nearly everything presents itself over a PCI bus nowadays | 14:38 | |
*** cali_boxer has quit IRC | 14:38 | |
*** cali_boxer has joined #openstack-nova | 14:38 | |
efried | stephenfin So the way I would think it would work in a RP world is... | 14:39 |
*** gyee_ has joined #openstack-nova | 14:39 | |
efried | Your RP (in this case the compute node) inventories the devices it has available, *already* filtered by whitelist. | 14:39 |
cdent | meaning filtering as a descendant of get_inventory? | 14:40 |
*** slaweq has quit IRC | 14:40 | |
jaypipes | stephenfin: are you asking whether there'd be a need for a whitelist conf option when we manage PCI devices in placement? | 14:40 |
stephenfin | jaypipes: Yup | 14:40 |
efried | cdent Within get_inventory, yeah. | 14:41 |
cdent | cool, good | 14:41 |
*** gyee has quit IRC | 14:41 | |
jaypipes | stephenfin: yes, there would still be a need for a way to filter out host devices that should not be allocatable to a consumer. | 14:41 |
*** gyee_ has quit IRC | 14:41 | |
*** gyee has joined #openstack-nova | 14:41 | |
jaypipes | stephenfin: I just want the pci_passthrough_whitelist CONF option to do a single thing. I'd like to see a separate CONF option (or YAML file even) that contains device inventory information that cannot be auto-discovered. | 14:42 |
claudiub | jaypipes: isn't that already done at the api level? | 14:42 |
*** jistr|trng is now known as jistr | 14:42 | |
jaypipes | claudiub: hmm? | 14:42 |
jaypipes | claudiub: not sure I understand you | 14:42 |
claudiub | with pci device alias config opion | 14:42 |
claudiub | afaik, you request a pci device through an alias. if a pci device is not aliased, i don't think it's allocatable | 14:42 |
efried | Correct. passthrough_whitelist is intersected with alias to get the list of claimable devs. | 14:43 |
jaypipes | claudiub: well, that's yet another thing that the pci_passthrough_whitelist CONF option does :( alias things... | 14:43 |
efried | jaypipes Well, [pci]alias aliases things. | 14:43 |
efried | AFAICT that's in place to make it easier to specify them in the flavor | 14:43 |
efried | extra_specs pci_passthrough:alias=<alias>:<count> | 14:43 |
*** smatzek has quit IRC | 14:44 | |
jaypipes | there's still alias stuff in the whitelist option. | 14:44 |
efried | ? | 14:44 |
efried | no lo veo | 14:44 |
claudiub | so, then, you can still request PCI devices through other means, like vendor_id / product_id, or other fields like this? i didn't see this documented. | 14:44 |
claudiub | not counting sr-iov. | 14:44 |
claudiub | that's requested whenever a port is vnic_type direct or something similar | 14:45 |
efried | oh, that. | 14:45 |
claudiub | that's requested automatically * | 14:45 |
efried | That's done based on the physical_network tag in the passthrough_whitelist, I believe. Aliases are not involved at all in that flow. | 14:45 |
claudiub | efried: yeah | 14:46 |
efried | which is... goofy. | 14:46 |
efried | Hey, it's Friday. | 14:46 |
*** efried is now known as fried_rice | 14:46 | |
* cdent is now hungry | 14:47 | |
fried_rice | Yeah, handling SR-IOV is a separate can of worms. | 14:47 |
fried_rice | And btw, I think SR-IOV is where a lot of the /sys/bus business comes into play. Or rather, why it's there in the first place. | 14:47 |
claudiub | oh yeah. which reminds me. i didn't find a proper way to "associate" different SR-IOV NICs to different "physical_networks" | 14:47 |
fried_rice | claudiub How so? | 14:48 |
fried_rice | oh, the thing where you can only actually have one physical network | 14:48 |
fried_rice | Yeah, there's a limitation in the binding metadata in neutron. We tried to "fix" it in I think ocata, but armax shot us down. | 14:49 |
armax | fried_rice: what did I do? | 14:49 |
fried_rice | armax :) Hold on, let me see if I can dig it up. | 14:49 |
fried_rice | armax I think it was this one: https://review.openstack.org/#/c/358125/ | 14:50 |
armax | I don’t typically shoot people down without proper justification :) | 14:50 |
*** saphi has quit IRC | 14:50 | |
fried_rice | https://bugs.launchpad.net/neutron/+bug/1615128 | 14:50 |
openstack | Launchpad bug 1615128 in neutron "Custom binding:profile values not coming through" [Undecided,Invalid] - Assigned to Eric Fried (efried) | 14:50 |
fried_rice | Oh, you provided justification | 14:51 |
fried_rice | And we backed off accordingly. | 14:51 |
jaypipes | fried_rice: apologies, I was wrong on the pci_passthrough + alias thing. :( | 14:51 |
armax | fried_rice: right, I remember this now…I suppose the next step from the -2 was to follow up with an RFE that never came | 14:51 |
armax | iirc | 14:52 |
fried_rice | armax That sounds right. | 14:52 |
fried_rice | armax Wasn't trying to bust your chops :) | 14:52 |
armax | fried_rice: so I only injured you, not shot you down mortally :) | 14:52 |
*** TH3J0K3R has quit IRC | 14:53 | |
armax | fried_rice: not a problem, I make mistakes of judment all the time, I was just trying to figure out the context | 14:53 |
claudiub | fried_rice: hm, simply because the limitation of the passthrough_whitelist config option. I can't reliably get a vendor_id / product_id for the NICs I have, and I can't use the address field either. IMO, if device_id would be allowed, it would work. | 14:53 |
*** sterdnotshaken has joined #openstack-nova | 14:53 | |
fried_rice | claudiub Well | 14:53 |
claudiub | hm, haven't tried devname though. | 14:53 |
fried_rice | claudiub I haven't actually found any reason you can't spoof the vendor/product ID. | 14:54 |
fried_rice | I don't *think* those are actually checked against anything real, ever. | 14:54 |
fried_rice | They're just correlated among the passthrough_whitelist (compute conf), the pci_passthrough_devices (compute-provided get_available_resource), and the alias list (api conf). | 14:54 |
claudiub | the PCI devices reported by the compute drivers have to have those vendor_id / product_ids | 14:54 |
*** saphi has joined #openstack-nova | 14:54 | |
fried_rice | Yes, have to have them, but I don't think anything cares that those values are really what the dev reports. | 14:55 |
claudiub | true. | 14:55 |
fried_rice | I'm... sort of counting on it, actually. Cause I have a vendor ID, but I'm not sure if the thing I'm using as a product ID is really a product ID. | 14:56 |
fried_rice | https://review.openstack.org/#/c/496434/3/nova_powervm/virt/powervm/host.py@111 | 14:56 |
claudiub | for sr-iov devices, i'm currently doing an md5, if i can't get the actual vendor_id, product_id, which feels wrong. :) | 14:56 |
fried_rice | Course, if you do that (or really, whatever you do), you have to document how your user needs to glean the right value to put in those spots in the whitelist/alias. | 14:57 |
fried_rice | claudiub Totally | 14:57 |
fried_rice | I feel your pain. | 14:57 |
fried_rice | claudiub I'm doing something similar with PCI addresses: https://review.openstack.org/#/c/496434/3/nova_powervm/virt/powervm/vm.py@884 | 14:57 |
claudiub | *ahem*, if only we could also whitelist via device_id, that would work for me. would it work for you as well? | 14:58 |
fried_rice | claudiub Where device_id can be an arbitrary string, yes, totally. | 14:58 |
*** mdrabe_ has joined #openstack-nova | 14:58 | |
fried_rice | claudiub In order to do wildcarding, though, you would need to outsource the validation/filtering to the compute driver. | 14:59 |
*** rcernin has quit IRC | 14:59 | |
fried_rice | Cause he's the only guy who knows how to interpret that "arbitrary" format. | 14:59 |
*** ekhugen has quit IRC | 14:59 | |
fried_rice | Otherwise you would just get a straight string match, which means you have to enumerate every device (or continue to use classes via vendor/prod IDs) | 15:00 |
*** egarbade has quit IRC | 15:01 | |
*** josecastroleon has quit IRC | 15:01 | |
*** mdrabe has quit IRC | 15:01 | |
fried_rice | claudiub What does the flavor side look like in that case? | 15:02 |
claudiub | fried_rice: for sr-iov you mean? | 15:02 |
*** ekhugen has joined #openstack-nova | 15:02 | |
fried_rice | I don't like the idea of having a flavor that specifies individual devices | 15:02 |
claudiub | fried_rice: or normal pci devices | 15:02 |
*** egarbade has joined #openstack-nova | 15:02 | |
fried_rice | Let's go normal PCI for now. | 15:02 |
*** mdrabe has joined #openstack-nova | 15:03 | |
claudiub | fried_rice: it should still look the same: pci_passthrough:alias=<alias>:<count> | 15:03 |
fried_rice | so you're adding "device_id" as an alternative to vendor_id/product_id in the alias? | 15:04 |
*** psachin has quit IRC | 15:04 | |
claudiub | fried_rice: for sr-iov, the flavor doesn't change, only the neutron port's vnic_type has to bbe direct or something similar, and your ML2 mechanism_driver must be able to support it. | 15:04 |
fried_rice | Gobackgoback | 15:04 |
fried_rice | What does that alias look like? | 15:04 |
claudiub | for sr-iov, you don't need an alias | 15:05 |
claudiub | you only alias normal pci devices. | 15:05 |
fried_rice | Yeah, regular PCI devices. Cause if it's just [pci]alias = {"device_id": "1234"} - then you're effectively specifying one device per alias. | 15:05 |
fried_rice | and you might as well use extra_specs pci_passthrough:device_id:1234 rather than bothering with an alias entry. | 15:06 |
*** pcaruana has quit IRC | 15:06 | |
*** ekhugen has quit IRC | 15:06 | |
*** mdrabe_ has quit IRC | 15:07 | |
stephenfin | dansmith: Any chance you could take a look at https://review.openstack.org/#/c/496605/? Think it might be a good backport candidate | 15:07 |
*** egarbade has quit IRC | 15:07 | |
*** psachin has joined #openstack-nova | 15:07 | |
stephenfin | the follow-up patch probably needs a little more discussion yet | 15:07 |
claudiub | fried_rice: well, tbh, for normal PCI devices, vendor_id / product_ids are always there on hyper-v. so, that can be used for aliasing. but IMO, a device_id should also be supported. | 15:07 |
fried_rice | So how would you do that? Perhaps something like [pci]alias = {"name": "foo", "devices": [{"device_id": "abc"}, {"device_id": "123"}, {"vendor_id": "1f2e", "product_id": "a9b8"}]} ? | 15:08 |
claudiub | fried_rice: yeah, you're right | 15:08 |
*** egarbade has joined #openstack-nova | 15:08 | |
fried_rice | I.e. you can specify a list of stuff to an alias, that allows you to enumerate several devices by ID and/or clasess by prod/vendor? | 15:08 |
fried_rice | That would be... kinda cool. | 15:08 |
*** ekhugen has joined #openstack-nova | 15:08 | |
*** rmart04 has quit IRC | 15:08 | |
fried_rice | Even without the ability to specify device IDs in there, if I want to be able to group different prod/vendor types together under a single alias... | 15:09 |
*** rajathagasthya has joined #openstack-nova | 15:09 | |
fried_rice | Like maybe I only care if I get a GPU. Any GPU will do. So make an alias grouping with these vendor/product IDs that all represent GPUs. | 15:09 |
*** iceyao has quit IRC | 15:10 | |
*** rabel has quit IRC | 15:10 | |
dansmith | stephenfin: why are you not just doing the conf deprecation now? | 15:12 |
*** cdent has quit IRC | 15:12 | |
stephenfin | dansmith: I want to backport the change. Backporting a deprecation seems wrong | 15:13 |
stephenfin | Same reason I've kept the deprecation timeline so generic | 15:13 |
dansmith | stephenfin: ah right okay | 15:13 |
dansmith | stephenfin: why no tests? | 15:13 |
*** iceyao has joined #openstack-nova | 15:14 | |
dansmith | should be pretty easy to write one to make sure we skip that bit... | 15:14 |
stephenfin | Damn. Because I was cheating :( | 15:14 |
* stephenfin shuffles off to write tests | 15:14 | |
*** jaypipes has quit IRC | 15:14 | |
kashyap | stephenfin: :P | 15:14 |
*** catintheroof has joined #openstack-nova | 15:14 | |
kashyap | stephenfin: I noticed the "no tests" thing, but thought you intentionally skipped them with good reason | 15:15 |
*** iceyao has quit IRC | 15:15 | |
*** abalutoiu_ has quit IRC | 15:15 | |
dansmith | stephenfin: I missed the deprecation patch after this, which makes sense.. | 15:15 |
*** Oku_OS is now known as Oku_OS-away | 15:16 | |
fried_rice | claudiub Would you be interested in co-authoring/sponsoring a bp to allow whitelisting & aliasing by device ID? | 15:16 |
stephenfin | dansmith: Yup, that one apparently needs a little more discussion. Key mappings are a minefield | 15:16 |
claudiub | fried_rice: well, tbh, a device_id would work in sr-iov usecase. that device_id would represent the NIC to which the VFs belong to. thus, I'd have N VFs grouped under the same device_id, which can be aliased as well. | 15:16 |
stephenfin | fried_rice, claudiub: Stick me on the review if you do author such a bp/spec | 15:16 |
fried_rice | stephenfin ack | 15:17 |
claudiub | ould work in my sr-iov usecase * | 15:17 |
fried_rice | claudiub "under the same device_id" ?? | 15:17 |
dansmith | stephenfin: doesn't that have an impact on whether or not just unsetting it is the right path in the bottom patch? | 15:17 |
fried_rice | claudiub oh, what the concept of parent_addr handles today. | 15:18 |
dansmith | stephenfin: your bottom patch says it's only for curses-based interaction or whatever, but that reviewer onthe deprecation patch seems to think it matters? | 15:18 |
stephenfin | Not really. We're not actually unsetting it in the bottom patch. Only allowing it to be unset | 15:18 |
dansmith | sure, but.. | 15:18 |
claudiub | fried_rice: oh yeah, something like that. | 15:18 |
stephenfin | ...and that entire first paragraph is essentially taken from danpb's comments on the bug | 15:19 |
claudiub | fried_rice: then, adding that parent_addr making the pci device whitelist support that parent_addr would work for me | 15:19 |
dansmith | stephenfin: maybe the reno on the bottom patch should drop the "we'll be deprecating it soon" part and just say "you can unset it if you want now" | 15:19 |
fried_rice | claudiub Yeah, today you can whitelist the parent... PF, I think. And then the claim matches any VF whose parent_addr is in the whitelist. | 15:19 |
stephenfin | dansmith: Not a bad call. I'll do that instead | 15:19 |
fried_rice | claudiub Course, like I said, SR-IOV is a whole different can of worms on Power. Cause we create our "VFs" on the fly, but the thing that gets assigned to the VM is really a virtual-virtual-function | 15:20 |
dansmith | stephenfin: actually it's the warning log that needs to go I think. I dropped some comments ont here | 15:21 |
claudiub | fried_rice: according to the docs, the only valid keys in the passthrough_whitelist config option are: vendor_id, product_id, address, devname, physical_network | 15:21 |
claudiub | fried_rice: well, that sounds the same as hyper-v. | 15:22 |
fried_rice | claudiub Right, the parent_addr is produced by the pci_passthrough_devices list (get_available_resource) | 15:22 |
claudiub | fried_rice: i wonder if we can't report the parent_addr, and whitelist the devices using the parent_addr | 15:23 |
fried_rice | This is where, if the claim is asking for a VF, it matches whitelist entries to pci_passthrough_devices entries based on their parent_addr in the latter, not their actual addr. | 15:23 |
fried_rice | claudiub Yeah, ^^ that's effectively what already happens. | 15:23 |
fried_rice | IIUC | 15:23 |
*** psachin has quit IRC | 15:24 | |
fried_rice | But... getting the virtual-virtual-function thing to work is a whole different ball of wax. We have a delicate dance between our compute driver and our mech driver. | 15:24 |
*** egonzalez has joined #openstack-nova | 15:24 | |
fried_rice | We had to have our compute driver spoof the list of VFs in passthrough_devices (because they don't exist yet; and if they did, they still wouldn't be available/visible/accessible on the compute node) | 15:25 |
claudiub | fried_rice: same here. | 15:27 |
fried_rice | So the claim just arbitrarily picks one off, and we kinda ignore that bit; and then it binds the port based on the physnet and the mech driver kinda passes it back and then our compute driver does the virtual-virtual-function (which we call an SR-IOV VNIC, confusingly) construction and assignment to the VM. | 15:27 |
fried_rice | claudiub Here's where I would really want generic and/or nested resource providers to help me out. | 15:28 |
claudiub | fried_rice: same here. :) | 15:28 |
fried_rice | I want the RP to be able to say "I can supply this many VFs" (or VNICs, or whatever) - just like it says "I can supply this many VCPUs". | 15:28 |
*** sahid has quit IRC | 15:28 | |
fried_rice | And when I do a claim, it decrements by one and lets my compute driver do the rest. | 15:29 |
claudiub | fried_rice: that sounds ideal, IMO. | 15:29 |
fried_rice | claudiub Okay, so same question about blueprint collaboration there. | 15:29 |
*** mdnadeem has quit IRC | 15:30 | |
claudiub | fried_rice: I'd help in any shape / form I could, but I am a bit swamped at the moment, so I can't make any promises. :) | 15:30 |
*** itlinux has quit IRC | 15:31 | |
*** psachin has joined #openstack-nova | 15:31 | |
fried_rice | claudiub Really all I'm asking for is a hearty "me too" if I propose this stuff. If this is just for PowerVM, it's a tough sell. But if there's more than one driver that cares, it carries a lot more weight. | 15:32 |
*** dklyle is now known as david-lyle | 15:32 | |
claudiub | fried_rice: then yes, that would help me as well. :) | 15:33 |
fried_rice | claudiub You going to the PTG? | 15:33 |
*** yangyape_ has joined #openstack-nova | 15:34 | |
claudiub | fried_rice: unfortunately, no | 15:35 |
fried_rice | Okay. There's a topic queued up (see https://etherpad.openstack.org/p/nova-ptg-queens ~L66). If you want to add a note in there, at least, that'll help when I take the floor with it. | 15:36 |
*** yangyapeng has quit IRC | 15:37 | |
fried_rice | I would like to have this same discussion with someone from VMWare - see if this direction is also of interest there. Any idea who would be a good touchpoint there? stephenfin | 15:37 |
stephenfin | dansmith: I've no idea, unfortunately. mriedem might know though? | 15:38 |
stephenfin | Oops - fried_rice ^ | 15:38 |
mriedem | cdent is vmware | 15:38 |
fried_rice | oh, okay, cool. | 15:38 |
stephenfin | dansmith: Should I remove that deprecation warning entirely or simply soften the language? | 15:38 |
dansmith | stephenfin: I think you should remove the log statement entirely | 15:38 |
stephenfin | There's still some issues. A debug-level warning and pointer to the bug might be helpful | 15:39 |
stephenfin | K. I'll do that so | 15:39 |
mriedem | WOOT http://logs.openstack.org/44/497944/1/check/gate-tempest-dsvm-py35-ubuntu-xenial/ba85bc2/logs/etc/nova/nova_cell1.conf.txt.gz | 15:40 |
mriedem | log formatting ftw | 15:40 |
mriedem | clarkb: ^ | 15:40 |
mriedem | now to find a devstack core | 15:40 |
kashyap | dansmith: Reading your comment on the unset 'keymap' patch, where you refer to the feedback on this - https://review.openstack.org/#/c/483994/4 | 15:41 |
kashyap | dansmith: Did you also read my comment? Also, we don't know what version of noVNC did the tester try it with | 15:41 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Allow users to unset 'keymap' options https://review.openstack.org/496605 | 15:41 |
*** ijw has quit IRC | 15:41 | |
stephenfin | dansmith: ^ | 15:41 |
kashyap | But I agree, we shouldn't hurry to deprecate it | 15:41 |
*** ijw has joined #openstack-nova | 15:41 | |
stephenfin | kashyap: Yeah, this is a good interim (and backportable) step. We can look into the issue in more detail over Queens | 15:42 |
dansmith | kashyap: I'm not sure what your comment has to do with my comment | 15:42 |
kashyap | "We probably should drop the warning here given the feedback on the following deprecation patch." | 15:42 |
kashyap | I think you were referring to the feedback by Tushar Patil? | 15:43 |
kashyap | Ah, I missed to note in _what_ scenario one can unset the '-k' option | 15:44 |
kashyap | *If* the noVNC client supports (from 0.6.1 & above it seems) the "QEMU RFB extension" (https://github.com/novnc/noVNC/pull/596), then the '-k' is not needed at all. | 15:44 |
edmondsw | claudiub: fried_rice: problem with spoofing vendor/product id would be that if they're not real how does the operator figure them out to put in the conf? Same issue as address | 15:45 |
edmondsw | sorry, finally got off my calls and catching up | 15:45 |
kashyap | Anyway, for now, stephenfin's allowing to unset the option is good. | 15:45 |
dansmith | stephenfin: see my comment just now.. I might be missing something | 15:46 |
fried_rice | edmondsw Yeah, I think that's why we want to be able to support alternative mechanisms for identifying the devices. | 15:46 |
edmondsw | +1 | 15:47 |
claudiub | edmondsw: yep, that's what i'm thinking about. although, there is a way, at least for my scenario. since i'm doing an md5 of the NIC's PCI device_id, a small script can be provided to "figure out" the vendor_id and product_id | 15:47 |
fried_rice | edmondsw See :08:13 | 15:47 |
clarkb | mriedem: is that content not the default out of nova/etc in the nova repo? | 15:47 |
claudiub | but ideally, we wouldn't have to rely on something like this | 15:47 |
fried_rice | claudiub You're only doing that for SR-IOV, so the user never sees it, right? | 15:47 |
claudiub | fried_rice: yep | 15:47 |
edmondsw | claudiub yeah... but it's a lot nicer to operators if they can just plug in something that makes sense, not have to go figure out how to turn what they know into something nova can understand | 15:48 |
fried_rice | I.e. the user doesn't have to figure out that MD5 spoofing and set up an alias with it. | 15:48 |
claudiub | fried_rice: it only has to be whitelisted | 15:48 |
fried_rice | claudiub And your setup allows you to whitelist by address :) | 15:48 |
clarkb | mriedem: I guess not reading the change it is an explicit step taken in devstack. Interesting | 15:48 |
fried_rice | After you've done all the mounting & dismounting gorp per https://blogs.technet.microsoft.com/heyscriptingguy/2016/07/14/passing-through-devices-to-hyper-v-vms-by-using-discrete-device-assignment/ | 15:48 |
claudiub | fried_rice: that link is only for full PCI passthrough, not for SR-IOV. :) | 15:50 |
fried_rice | claudiub So how do you whitelist SR-IOV? | 15:50 |
*** lpetrut has quit IRC | 15:52 | |
claudiub | fried_rice: for hyper-v SR-IOV configuration, there are other steps to check if it's supported and enable it. For example, running the powershell command Get-VMHost, will also include SR-IOV support details: if it's supported or not on the host (must be enabled in BIOS). Afterwards, the NICs have to be checked if they support SR-IOV, which can be checked by Get-NetAdapterSriov, if i'm not mistaken | 15:53 |
fried_rice | claudiub But what do you put in the nova-cpu.conf's [pci]passthrough_whitelist ? | 15:53 |
fried_rice | Do the above commands produce some kind of output that the user can translate to the whitelist entry? | 15:53 |
mriedem | clarkb: yeah | 15:54 |
mriedem | devstack sets that up | 15:54 |
claudiub | fried_rice: at this moment, those spoofed vendor_id, product_id | 15:54 |
fried_rice | claudiub Oh, so your user *does* see the spoofed vendor/prod IDs. | 15:54 |
claudiub | but ideally I'd have a better option. | 15:54 |
fried_rice | okay, cool, that's a pretty good story. | 15:54 |
claudiub | fried_rice: only on the compute node's nova.conf file. | 15:55 |
fried_rice | claudiub Right, operator-facing. | 15:55 |
claudiub | fried_rice: yep | 15:55 |
fried_rice | Which is ick. | 15:55 |
claudiub | yep | 15:55 |
*** psachin has quit IRC | 15:56 | |
*** derekh has quit IRC | 15:57 | |
*** lucasxu has quit IRC | 15:58 | |
*** yamamoto has quit IRC | 15:59 | |
*** catintheroof has quit IRC | 15:59 | |
*** psachin has joined #openstack-nova | 16:01 | |
*** lucasxu has joined #openstack-nova | 16:03 | |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: WIP: SPEC: PCI passthrough by device ID https://review.openstack.org/497965 | 16:03 |
openstackgerrit | Dan Smith proposed openstack/nova master: Move hash ring initialization to init_host() for ironic https://review.openstack.org/497966 | 16:03 |
*** lucasxu has quit IRC | 16:03 | |
dansmith | edleafe: ^ | 16:04 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Allow users to unset 'keymap' options https://review.openstack.org/496605 | 16:04 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: De-duplicate some graphics tests https://review.openstack.org/497969 | 16:04 |
stephenfin | dansmith: ^ | 16:05 |
dansmith | aye | 16:05 |
stephenfin | ta | 16:05 |
*** lucasxu has joined #openstack-nova | 16:05 | |
dansmith | stephenfin: you're still not setting keymap to None... is there a reason? | 16:06 |
dansmith | in the test I mean | 16:06 |
*** lucasagomes is now known as lucas-afk | 16:06 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: De-duplicate two delete_allocation_for_* methods https://review.openstack.org/496936 | 16:08 |
*** cdent has joined #openstack-nova | 16:09 | |
cdent | thanks for making that fix mrhillsman | 16:09 |
cdent | whoops mriedem | 16:09 |
mriedem | np | 16:10 |
fried_rice | cdent Rumor has it you're the VMWare guy. (mriedem threw you under the bus) | 16:10 |
mriedem | dansmith: first, superdan | 16:11 |
fried_rice | cdent Can you (refer me to someone who can) speak to how PCI is handled in VMWare? | 16:11 |
mriedem | second, notice the todo i added in here yesterday? https://review.openstack.org/#/c/497606/1/nova/compute/manager.py@3798 | 16:11 |
mriedem | superdan: am i just blind or does that error handling not make any sense? | 16:11 |
mriedem | it was added long ago https://review.openstack.org/#/c/73387/ and had quite a bit of review from different people, but i don't see how it made sense back then either | 16:12 |
cdent | fried_rice: if you mean being employed by vware makes me the vmware guy, then yes. I’ve pointed out the conversation from earlier to some people who were interested. | 16:12 |
mriedem | cdent: would that be radu? | 16:12 |
*** dansmith is now known as superdan | 16:12 | |
mriedem | radu is the only other person i know that was working on nova in recent times | 16:12 |
fried_rice | cdent Cool beans. And FYI for passing along to those folks: https://blueprints.launchpad.net/nova/+spec/pci-by-device-id (cc stephenfin claudiub) | 16:13 |
cdent | rgerganov and gjayavelu . I’ll let them know to look (and to come back to irc one in a while) | 16:13 |
*** sterdnotshaken has quit IRC | 16:13 | |
*** sterdnotshaken has joined #openstack-nova | 16:14 | |
cdent | there are a lot of people who apparently used to | 16:14 |
cdent | but not so much now | 16:14 |
mriedem | there was also of course no test for the compute manager piece of that | 16:14 |
mriedem | i think i'm just going to remove it | 16:14 |
superdan | mriedem: I bet that was intending to catch migrationerror, which can be raised by _prep_resize | 16:14 |
superdan | mriedem: well, the comment definitely talks about the call though | 16:14 |
superdan | mriedem: like I said yesterday I thought that was a call, so that person did too | 16:15 |
*** felipemonteiro_ has joined #openstack-nova | 16:15 | |
mriedem | ok, i was going to say, from the change itself, it's raising that here https://review.openstack.org/#/c/73387/13/nova/virt/libvirt/driver.py | 16:15 |
mriedem | which on the source after the rpc cast | 16:15 |
mriedem | the rpc all you mentioned yesterday i thought was about something in conductor, but maybe i'm confused | 16:15 |
*** felipemonteiro has quit IRC | 16:15 | |
mriedem | anyway, i'm going to remove this handling from prep_resize as it can't happen | 16:16 |
*** felipemonteiro__ has joined #openstack-nova | 16:16 | |
superdan | hang on | 16:16 |
superdan | I'm confused | 16:16 |
mriedem | the libvirt driver raises that error from migrate_disk_and_power_off which is called from ComputeManager.resize_instance, | 16:17 |
mriedem | _prep_resize does an rpc cast to resize_instance on the source host | 16:17 |
superdan | mriedem: so you see that we can raise a MigrationError in there, right? | 16:17 |
mriedem | since it's a cast, the error raised from migrate_disk_and_power_off on the source can't come back | 16:17 |
*** mvk has quit IRC | 16:17 | |
mriedem | in _prep_resize? | 16:17 |
superdan | yeah | 16:17 |
mriedem | yes | 16:17 |
superdan | also, | 16:17 |
mriedem | MigrationError != MigrationPreCheckError | 16:18 |
superdan | we're doing the resize claim in a context manager and then the rpc call inside | 16:18 |
superdan | mriedem: I know, but precheck is a subclass of migration error | 16:18 |
superdan | mriedem: thought maybe it should be catching migrationerror instead | 16:18 |
mriedem | no i assume he added MigrationPreCheckError specifically b/c that's what was added to the driver to raise in tha same change | 16:18 |
*** mvk has joined #openstack-nova | 16:19 | |
superdan | I guess it doesn't matter regardless since we're not going to return the exception we let through to anything anyway | 16:19 |
mriedem | i'm not sure what the resize_claim has to do with anything, | 16:19 |
mriedem | that just aborts the claim on failure | 16:19 |
mriedem | like if the rpc cast blows up or something i guess | 16:19 |
superdan | mriedem: right, I'm saying there seems to be no reason to do that if we're not going to make a call | 16:20 |
*** felipemonteiro_ has quit IRC | 16:20 | |
superdan | let me take a step back | 16:20 |
superdan | all I'm saying is a lot of this path looks very confused about what is a blocking call vs. cas | 16:20 |
superdan | *cast | 16:20 |
superdan | that's all | 16:20 |
mriedem | agree | 16:21 |
mriedem | which is why i did this the other day https://review.openstack.org/#/c/496861/ | 16:21 |
mriedem | because following this stupid back and forth shit is confusing | 16:21 |
mriedem | i've been meaning to do something like ^ for the live migration craziness for awhile too | 16:21 |
mriedem | like, "in this method, which is the 5th part of the live migration crazy, which fucking host am i actually on right now?!" | 16:22 |
mriedem | sorry for the salty language | 16:22 |
*** shan has joined #openstack-nova | 16:25 | |
kashyap | mriedem: Salty language is welcome. [/me has a TODO item to write down live migration flow for Nova, too] | 16:26 |
* kashyap still catching up on the e-mails from last 22 days of being away | 16:26 | |
*** tidwellr has joined #openstack-nova | 16:26 | |
*** aarefiev is now known as aarefiev_afk | 16:31 | |
*** sambetts is now known as sambetts|afk | 16:32 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove useless error handling in prep_resize https://review.openstack.org/497976 | 16:32 |
*** dave-mccowan has quit IRC | 16:33 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Add uuid to migration object and migrate-on-load https://review.openstack.org/496934 | 16:34 |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: WIP: SPEC: Treat devices as generic resources https://review.openstack.org/497978 | 16:39 |
*** esberglu has quit IRC | 16:43 | |
*** esberglu has joined #openstack-nova | 16:43 | |
*** esberglu has quit IRC | 16:44 | |
*** lpetrut has joined #openstack-nova | 16:45 | |
*** catintheroof has joined #openstack-nova | 16:52 | |
*** jpena is now known as jpena|off | 16:54 | |
*** efoley has quit IRC | 16:59 | |
*** yamamoto has joined #openstack-nova | 17:00 | |
*** gixxer1k has quit IRC | 17:03 | |
*** gixxer1k has joined #openstack-nova | 17:03 | |
*** lpetrut has quit IRC | 17:05 | |
*** yamamoto has quit IRC | 17:06 | |
*** tesseract has quit IRC | 17:07 | |
*** psachin has quit IRC | 17:10 | |
*** catintheroof has quit IRC | 17:11 | |
*** esberglu has joined #openstack-nova | 17:11 | |
*** itlinux has joined #openstack-nova | 17:12 | |
*** viaggarw has quit IRC | 17:19 | |
*** yufei has joined #openstack-nova | 17:19 | |
*** lpetrut has joined #openstack-nova | 17:21 | |
*** sterdnotshaken1 has joined #openstack-nova | 17:24 | |
*** sterdnotshaken has quit IRC | 17:27 | |
*** yufei has quit IRC | 17:27 | |
*** lbragstad has quit IRC | 17:31 | |
*** rajathagasthya has quit IRC | 17:36 | |
*** dikonoo has joined #openstack-nova | 17:40 | |
*** gbarros has quit IRC | 17:40 | |
openstackgerrit | Chris Dent proposed openstack/nova master: Prevent blank line at start of migration placeholders https://review.openstack.org/498004 | 17:44 |
cdent | dansmith: your wish, my command ^ | 17:44 |
*** sterdnotshaken has joined #openstack-nova | 17:45 | |
*** dikonoo has quit IRC | 17:45 | |
*** lbragstad has joined #openstack-nova | 17:45 | |
*** sterdnotshaken1 has quit IRC | 17:47 | |
*** bnemec is now known as beekneemech | 17:51 | |
*** rajathagasthya has joined #openstack-nova | 17:51 | |
*** catintheroof has joined #openstack-nova | 17:56 | |
*** sterdnotshaken1 has joined #openstack-nova | 17:58 | |
*** sterdnotshaken has quit IRC | 17:58 | |
*** yamamoto has joined #openstack-nova | 18:02 | |
*** pchavva has quit IRC | 18:07 | |
*** yamamoto has quit IRC | 18:07 | |
*** lyan has quit IRC | 18:14 | |
*** alexchadin has joined #openstack-nova | 18:15 | |
*** psachin has joined #openstack-nova | 18:20 | |
*** lyan has joined #openstack-nova | 18:21 | |
*** dixiaoli has joined #openstack-nova | 18:29 | |
*** masber has quit IRC | 18:31 | |
*** lyan has quit IRC | 18:31 | |
*** lyan has joined #openstack-nova | 18:33 | |
*** dixiaoli has quit IRC | 18:33 | |
*** lucasxu has quit IRC | 18:35 | |
*** saphi has quit IRC | 18:37 | |
*** alexchadin has quit IRC | 18:40 | |
*** alexchadin has joined #openstack-nova | 18:40 | |
*** alexchadin has quit IRC | 18:45 | |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: WIP: SPEC: Treat devices as generic resources https://review.openstack.org/497978 | 18:45 |
*** imacdonn has quit IRC | 18:47 | |
*** imacdonn has joined #openstack-nova | 18:47 | |
*** mnestratov has quit IRC | 18:52 | |
*** sterdnotshaken has joined #openstack-nova | 18:58 | |
*** sterdnotshaken has quit IRC | 18:58 | |
*** sterdnotshaken1 has quit IRC | 18:59 | |
*** dave-mccowan has joined #openstack-nova | 19:02 | |
*** yamamoto has joined #openstack-nova | 19:04 | |
*** yamamoto has quit IRC | 19:09 | |
*** itlinux has quit IRC | 19:21 | |
*** itlinux has joined #openstack-nova | 19:22 | |
*** sterdnotshaken has joined #openstack-nova | 19:22 | |
*** sterdnotshaken1 has joined #openstack-nova | 19:24 | |
*** sterdnotshaken has quit IRC | 19:26 | |
*** tidwellr_ has joined #openstack-nova | 19:28 | |
*** tidwellr has quit IRC | 19:28 | |
*** alexchadin has joined #openstack-nova | 19:29 | |
*** alexchadin has quit IRC | 19:32 | |
*** itlinux has quit IRC | 19:37 | |
*** cdent has quit IRC | 19:38 | |
*** tidwellr has joined #openstack-nova | 19:39 | |
*** tidwellr_ has quit IRC | 19:39 | |
*** itlinux has joined #openstack-nova | 19:41 | |
*** awaugama has quit IRC | 19:41 | |
*** awaugama has joined #openstack-nova | 19:41 | |
*** sterdnotshaken has joined #openstack-nova | 19:46 | |
*** sterdnotshaken1 has quit IRC | 19:46 | |
*** sterdnotshaken has quit IRC | 19:51 | |
*** felipemonteiro__ has quit IRC | 19:54 | |
*** psachin has quit IRC | 19:54 | |
*** ijw_ has joined #openstack-nova | 19:58 | |
*** sterdnotshaken has joined #openstack-nova | 19:58 | |
*** ijw has quit IRC | 20:01 | |
mriedem | artom: did you ever propose a change to the feature support matrix to doc the tagged attach stuff? | 20:02 |
artom | mriedem, I thought someone else did? | 20:02 |
mriedem | jichen? | 20:03 |
* mriedem looks | 20:03 | |
mriedem | ah yes https://review.openstack.org/#/c/481478/ | 20:03 |
artom | https://review.openstack.org/#/c/481478/ | 20:03 |
artom | Yeah, you're even a reviewer on it ;) | 20:03 |
mriedem | whatever artomous maximus | 20:03 |
mriedem | are you happy with it? | 20:03 |
artom | Lemme check the latest version quickly | 20:04 |
mriedem | stephenfin: can you drop the -2 from this https://review.openstack.org/#/c/482216/ ? | 20:04 |
artom | Err, nits on wording | 20:04 |
*** rcernin has joined #openstack-nova | 20:04 | |
artom | But since this is a pure doc patch, I figure they're -1 worthy, no? | 20:04 |
mriedem | yes, i'm also going through it, i'll update after you | 20:05 |
*** yamamoto has joined #openstack-nova | 20:05 | |
mriedem | er i just -1ed | 20:07 |
*** shan has quit IRC | 20:10 | |
*** yamamoto has quit IRC | 20:11 | |
mriedem | thanks | 20:12 |
*** sterdnotshaken1 has joined #openstack-nova | 20:15 | |
*** sterdnotshaken has quit IRC | 20:15 | |
*** jmlowe has quit IRC | 20:19 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add device tag support info in support matrix https://review.openstack.org/481478 | 20:19 |
mriedem | updated ^ | 20:19 |
*** shan has joined #openstack-nova | 20:22 | |
artom | mriedem, couple more nits | 20:24 |
mriedem | my god | 20:24 |
artom | bikeshed all the things! | 20:24 |
artom | If it improves your morale, it's genuinely nice to see you push patches through their final stretch like this, when there's just nits remaining | 20:25 |
mriedem | if there is one thing i'm all about, it's high morale | 20:25 |
artom | A high state in general | 20:26 |
*** shan has quit IRC | 20:27 | |
*** esberglu has quit IRC | 20:29 | |
mriedem | oh i guess we don't format that page with rst anyway | 20:30 |
mriedem | so ``nic1`` doesn't help | 20:30 |
artom | Maybe the . thing was legit? | 20:31 |
mriedem | no it wasn't | 20:32 |
mriedem | it was just .nic1. | 20:32 |
mriedem | i'll use quotes | 20:32 |
*** admin0 has joined #openstack-nova | 20:32 | |
admin0 | hi all .. i wanted to check if I hit a nova bug .. https://bugs.launchpad.net/nova/+bug/1713144 .. | 20:33 |
openstack | Launchpad bug 1713144 in OpenStack Compute (nova) "nova metadata service breaks on hostname" [Undecided,New] | 20:33 |
artom | If you hit it it'll probably defend itself and hit back | 20:33 |
mriedem | <rimshot> | 20:33 |
admin0 | :D | 20:34 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add device tag support info in support matrix https://review.openstack.org/481478 | 20:35 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Document tagged attach in the feature support matrix https://review.openstack.org/498086 | 20:35 |
admin0 | i will wait for it to hit back :) | 20:35 |
artom | nova-network? Didn't we deprecate that? | 20:35 |
mriedem | admin0: which release? please provide release version information in the bug report | 20:35 |
mriedem | if something changed we need to be able to look for when | 20:35 |
admin0 | sorry .. i updated | 20:36 |
mriedem | looks like that code hasn't changed in a long time | 20:41 |
mriedem | netaddr.IPAddress(ip) | 20:41 |
mriedem | so it's probably something in the netaddr library | 20:41 |
mriedem | compare the versions where it works and where it doesn't and check the change log for netaddr between them i suppose | 20:41 |
mriedem | https://github.com/drkjam/netaddr/blob/netaddr-0.7.19/netaddr/ip/__init__.py#L244 | 20:44 |
mriedem | looks like netaddr.IPAddress has always expected an ip rather than fqdn | 20:44 |
admin0 | i will take it back to ansible | 20:45 |
mriedem | ah, also, metadata_host defaults to $my_ip, | 20:47 |
mriedem | which is an IP address, not a hostname | 20:47 |
mriedem | these StrOpts should really probably be IPOpts | 20:47 |
*** lyan has quit IRC | 20:53 | |
*** thorst_afk has quit IRC | 20:53 | |
*** yassine has quit IRC | 20:54 | |
*** catintheroof has quit IRC | 20:55 | |
*** catintheroof has joined #openstack-nova | 20:56 | |
*** lyan has joined #openstack-nova | 20:58 | |
*** yassine has joined #openstack-nova | 21:01 | |
*** gouthamr has quit IRC | 21:04 | |
*** tidwellr has quit IRC | 21:06 | |
*** tidwellr has joined #openstack-nova | 21:07 | |
*** yamamoto has joined #openstack-nova | 21:07 | |
*** thorst_afk has joined #openstack-nova | 21:10 | |
*** slaweq has joined #openstack-nova | 21:10 | |
*** tidwellr has quit IRC | 21:12 | |
*** yamamoto has quit IRC | 21:13 | |
*** tidwellr has joined #openstack-nova | 21:14 | |
*** thorst_afk has quit IRC | 21:15 | |
*** yamamoto has joined #openstack-nova | 21:18 | |
*** itlinux has quit IRC | 21:18 | |
*** mnestratov has joined #openstack-nova | 21:18 | |
*** gouthamr has joined #openstack-nova | 21:21 | |
*** yamamoto has quit IRC | 21:22 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Change default for [notifications]/default_publisher_id to $host https://review.openstack.org/498094 | 21:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Change CONF.my_ip to be IPOpt https://review.openstack.org/498095 | 21:24 |
*** edmondsw has quit IRC | 21:25 | |
*** masber has joined #openstack-nova | 21:27 | |
*** masber has quit IRC | 21:32 | |
*** marst_ has joined #openstack-nova | 21:35 | |
*** marst has quit IRC | 21:35 | |
*** yamahata has joined #openstack-nova | 21:38 | |
*** dave-mccowan has quit IRC | 21:39 | |
mriedem | what the hell is monkey_patch_modules? | 21:41 |
mriedem | can we remove that? | 21:42 |
*** lyan has quit IRC | 21:45 | |
*** slaweq has quit IRC | 21:49 | |
clarkb | config docs seem to imply it is for testing | 21:55 |
openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_certs to Instance object https://review.openstack.org/489408 | 21:55 |
openstackgerrit | Brianna Poulos proposed openstack/nova master: WIP Add trusted_certificates to REST API https://review.openstack.org/486204 | 21:56 |
openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/457711 | 21:56 |
clarkb | is that how fake virt loading worked for the stress job? | 21:56 |
mriedem | clarkb: no we literally have a fake virt driver in tree | 21:56 |
mriedem | we use it in the in tree functional tests, and the stress job did too | 21:56 |
mriedem | or large ops or whatever it was called | 21:56 |
clarkb | ya large ops that was the name (I couldn't remember it) | 21:56 |
*** gbarros has joined #openstack-nova | 21:57 | |
openstackgerrit | Brianna Poulos proposed openstack/nova master: WIP Add trusted_certificates to REST API https://review.openstack.org/486204 | 21:58 |
*** burt has quit IRC | 22:07 | |
*** gbarros has quit IRC | 22:08 | |
*** felipemonteiro has joined #openstack-nova | 22:08 | |
*** lpetrut has quit IRC | 22:09 | |
*** felipemonteiro_ has joined #openstack-nova | 22:10 | |
*** rajathagasthya has quit IRC | 22:10 | |
*** thorst_afk has joined #openstack-nova | 22:11 | |
*** felipemonteiro has quit IRC | 22:13 | |
*** yassine has quit IRC | 22:15 | |
*** thorst_afk has quit IRC | 22:15 | |
*** marst_ has quit IRC | 22:17 | |
*** abalutoiu_ has joined #openstack-nova | 22:17 | |
*** jmlowe has joined #openstack-nova | 22:18 | |
*** yamamoto has joined #openstack-nova | 22:22 | |
*** thorst_afk has joined #openstack-nova | 22:27 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Deprecate CONF.monkey_patch https://review.openstack.org/498113 | 22:29 |
mriedem | huzzah ^ | 22:29 |
*** thorst_afk has quit IRC | 22:31 | |
*** thorst_afk has joined #openstack-nova | 22:31 | |
*** slaweq has joined #openstack-nova | 22:32 | |
*** felipemonteiro_ has quit IRC | 22:32 | |
cfriesen_ | yay for removing code | 22:35 |
*** thorst_afk has quit IRC | 22:36 | |
mriedem | the one bright spot of every new release is removing some mistakes from the old releases | 22:36 |
cfriesen_ | what's with the removal of the line with ec2? | 22:37 |
*** slaweq has quit IRC | 22:38 | |
mriedem | oh yeah, was going to mention that in the release note - that code isn't in nova so doesn't really need to be in here | 22:38 |
cfriesen_ | figured it was something like that | 22:38 |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: RFC: SPEC: PCI passthrough by device ID https://review.openstack.org/497965 | 22:38 |
fried_rice | claudiub ^ ! | 22:41 |
*** Nil_ has quit IRC | 22:41 | |
fried_rice | claudiub I would welcome more examples and/or specifics of how HyperV has to hack the world today to make PCI passthrough work. | 22:41 |
*** fried_rice is now known as efried | 22:46 | |
*** yamamoto has quit IRC | 22:48 | |
*** egonzalez has quit IRC | 22:51 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Deprecate CONF.monkey_patch https://review.openstack.org/498113 | 22:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Change CONF.my_ip to be IPOpt https://review.openstack.org/498095 | 22:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Change default for [notifications]/default_publisher_id to $host https://review.openstack.org/498094 | 22:51 |
*** rajathagasthya has joined #openstack-nova | 22:54 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Change CONF.my_ip to be IPOpt https://review.openstack.org/498095 | 22:54 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Change default for [notifications]/default_publisher_id to $host https://review.openstack.org/498094 | 22:54 |
*** hongbin has quit IRC | 23:13 | |
*** sterdnotshaken1 has quit IRC | 23:14 | |
*** catintheroof has quit IRC | 23:17 | |
*** yamamoto has joined #openstack-nova | 23:17 | |
*** rajathagasthya has quit IRC | 23:23 | |
*** rcernin has quit IRC | 23:23 | |
*** yamahata has quit IRC | 23:24 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!