*** yangyapeng has quit IRC | 00:04 | |
*** yangyapeng has joined #openstack-nova | 00:05 | |
*** tbachman has quit IRC | 00:06 | |
*** yamahata has quit IRC | 00:06 | |
*** vladikr has joined #openstack-nova | 00:06 | |
*** kevi9132_ has joined #openstack-nova | 00:08 | |
*** kevi9132 has quit IRC | 00:08 | |
*** yangyapeng has quit IRC | 00:09 | |
*** slaweq has joined #openstack-nova | 00:09 | |
*** chyka has quit IRC | 00:16 | |
*** slaweq has quit IRC | 00:16 | |
*** kevi9132 has joined #openstack-nova | 00:17 | |
*** mriedem has joined #openstack-nova | 00:17 | |
*** tbachman has joined #openstack-nova | 00:17 | |
*** kevi9132_ has quit IRC | 00:18 | |
mriedem | melwitt pulling out the zingers on the sorted instances list series tonight | 00:19 |
---|---|---|
melwitt | trying to be a cool cat | 00:21 |
openstackgerrit | Merged openstack/nova master: Add base implementation for efficient cross-cell instance listing https://review.openstack.org/504983 | 00:24 |
dansmith | woot | 00:25 |
*** esberglu has quit IRC | 00:26 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Move allocation manipulation out of drop_move_claim() https://review.openstack.org/498947 | 00:26 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make allocation cleanup honor new by-migration rules https://review.openstack.org/498948 | 00:26 |
openstackgerrit | Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949 | 00:26 |
openstackgerrit | Dan Smith proposed openstack/nova master: Pre-create migration object https://review.openstack.org/498950 | 00:26 |
openstackgerrit | Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419 | 00:26 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420 | 00:26 |
dansmith | this is still super WIP except for the first patch ^ | 00:26 |
dansmith | and a giant mess to boot | 00:26 |
*** esberglu has joined #openstack-nova | 00:26 | |
dansmith | but, it's getting there | 00:26 |
*** esberglu has quit IRC | 00:30 | |
dansmith | melwitt: replied to your [0] question, and I can slap a comment into the fixes patch at the end if you want | 00:31 |
dansmith | if you are otherwise likely to be okay with the rest | 00:31 |
dansmith | same for your docstring mriedem | 00:31 |
melwitt | okay, yeah a comment would be nice for the fixes patch. the rest looked fine to me | 00:34 |
*** tetsuro has joined #openstack-nova | 00:34 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416 | 00:37 |
dansmith | voilla ^ | 00:37 |
openstackgerrit | Merged openstack/nova master: Make instance_list honor global query limit https://review.openstack.org/504984 | 00:38 |
*** zhurong has joined #openstack-nova | 00:39 | |
dansmith | aww yeah | 00:39 |
dansmith | melwitt: mriedem: the gate phoned and said it was lonely. just sayin'. | 00:39 |
melwitt | the gate calls you on the phone? I'm jell | 00:42 |
dansmith | don't be, it's rarely good news | 00:43 |
melwitt | heh | 00:44 |
mriedem | what the f are you two talking about | 00:44 |
*** coreywright has quit IRC | 00:44 | |
melwitt | cool cat stuff | 00:45 |
*** itlinux has joined #openstack-nova | 00:45 | |
mriedem | dansmith: this is kind of a "add an assertion check here?" question https://review.openstack.org/#/c/504985/8/nova/tests/unit/db/test_db_api.py@10793 | 00:47 |
dansmith | mriedem: assert what? | 00:47 |
*** ijw has joined #openstack-nova | 00:47 | |
dansmith | oh, I see | 00:47 |
mriedem | yeah | 00:48 |
mriedem | that | 00:48 |
dansmith | make sure the first one did the thing I want? | 00:48 |
mriedem | yes | 00:48 |
dansmith | but at the end we know we've gotten them all ... | 00:48 |
mriedem | yeah ok | 00:49 |
mriedem | fair enough | 00:49 |
*** markvoelker has joined #openstack-nova | 00:49 | |
dansmith | I can slap more checking into the fixes patch if you want | 00:49 |
melwitt | slap chop | 00:50 |
mriedem | it's just kind of hard to grok what this is doing | 00:50 |
dansmith | the first call is using the existing db method, | 00:51 |
*** litao__ has joined #openstack-nova | 00:51 | |
mriedem | it starts with the 256 memory_mb instance | 00:51 |
dansmith | so if it wasn't sorting properly, we'd have a big problem and other tests would fail (hopefully?) | 00:51 |
mriedem | and then i guess it pages through each time, and should hit those other instances in order | 00:51 |
*** itlinux has quit IRC | 00:51 | |
mriedem | so next after 256+1 would be the 512 instance | 00:51 |
dansmith | mriedem: it does, and I just put things in the db in a weird order to make sure we don't rely on the ordering in the db but the sorting | 00:51 |
mriedem | yeah noted that | 00:52 |
*** bigdogstl has joined #openstack-nova | 00:52 | |
mriedem | which is nice | 00:52 |
*** ijw has quit IRC | 00:52 | |
mriedem | and the key_name in the values is just there for? | 00:52 |
mriedem | just to show we aren't sorting on key_name? | 00:53 |
*** slaweq has joined #openstack-nova | 00:53 | |
dansmith | I think I was copying my other unit test examples from the other patches, but yeah I can remove that if you think it's confusing | 00:53 |
*** thorst has joined #openstack-nova | 00:54 | |
*** markvoelker has quit IRC | 00:54 | |
mriedem | ok left some comments inline, you can add docs to it in the end if you want | 00:55 |
openstackgerrit | Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416 | 00:55 |
dansmith | mriedem: ^ | 00:55 |
*** bigdogstl has quit IRC | 00:56 | |
dansmith | mriedem: does that help at all? or is it still too obscure because I'm not comparing against a static obvious list? | 00:57 |
*** thorst has quit IRC | 00:57 | |
mriedem | you only updated the commit message | 00:58 |
dansmith | gah | 00:59 |
openstackgerrit | Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416 | 00:59 |
dansmith | sorry | 00:59 |
*** slaweq has quit IRC | 00:59 | |
*** thorst has joined #openstack-nova | 01:00 | |
*** thorst has quit IRC | 01:00 | |
mriedem | ok, left a comment about the key_name thing in the last change | 01:01 |
openstackgerrit | Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416 | 01:02 |
dansmith | got it | 01:02 |
* dansmith dinners | 01:02 | |
mriedem | i think i'm getting the global marker patch now | 01:03 |
mriedem | understanding the patch before it is key | 01:03 |
*** coreywright has joined #openstack-nova | 01:04 | |
*** Guest13446 is now known as mfisch | 01:05 | |
*** Apoorva_ has joined #openstack-nova | 01:05 | |
*** mfisch is now known as Guest12749 | 01:05 | |
*** Apoorva has quit IRC | 01:08 | |
*** tetsuro has quit IRC | 01:09 | |
*** Shunli has joined #openstack-nova | 01:09 | |
*** Apoorva has joined #openstack-nova | 01:09 | |
*** Apoorva_ has quit IRC | 01:09 | |
mriedem | so for the ip filtering we do in python in the compute api, does the end of this result in us returning a sorted/filtered list to the code that then processes the ip filter regex? | 01:10 |
*** bigdogstl has joined #openstack-nova | 01:11 | |
*** yangyapeng has joined #openstack-nova | 01:13 | |
*** yangyapeng has quit IRC | 01:14 | |
*** yangyapeng has joined #openstack-nova | 01:14 | |
dansmith | mriedem: I'm not sure I understand.. that filtering code is in the api, right? we shouldn't be changing what it sees | 01:15 |
mriedem | yeah i just haven't gotten there yet | 01:15 |
dansmith | okay | 01:15 |
mriedem | this is all basically a shim in between the db api and that code that processes the result and filters by ip regex | 01:15 |
mriedem | ok | 01:15 |
dansmith | right | 01:15 |
*** takashin has quit IRC | 01:15 | |
dansmith | a multiplexing layer that doesn't eff up the sort order like what we had before | 01:15 |
*** trungnv_ has joined #openstack-nova | 01:16 | |
*** trungnv has joined #openstack-nova | 01:16 | |
*** takashin has joined #openstack-nova | 01:16 | |
*** sapd has quit IRC | 01:18 | |
*** smatzek has joined #openstack-nova | 01:18 | |
mriedem | ok just some nits in the mega marker paging patch, which can go at the end, otherwise +2 | 01:20 |
mriedem | my work here is done | 01:20 |
*** sapd has joined #openstack-nova | 01:20 | |
*** bigdogstl has quit IRC | 01:20 | |
dansmith | cool thanks I'll take a look in a sec | 01:20 |
*** trungnv has left #openstack-nova | 01:21 | |
*** trungnv_ has left #openstack-nova | 01:21 | |
*** hongbin has joined #openstack-nova | 01:22 | |
*** markvoelker has joined #openstack-nova | 01:22 | |
*** kenperkins has quit IRC | 01:26 | |
*** baoli has joined #openstack-nova | 01:29 | |
*** baoli has quit IRC | 01:30 | |
*** baoli has joined #openstack-nova | 01:31 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416 | 01:33 |
*** gouthamr has quit IRC | 01:35 | |
*** gouthamr has joined #openstack-nova | 01:36 | |
*** Apoorva has quit IRC | 01:37 | |
*** thorst has joined #openstack-nova | 01:38 | |
*** thorst has quit IRC | 01:38 | |
*** yangyapeng has quit IRC | 01:38 | |
*** yangyapeng has joined #openstack-nova | 01:39 | |
*** chyka has joined #openstack-nova | 01:39 | |
*** suresh12 has quit IRC | 01:41 | |
*** yangyapeng has quit IRC | 01:42 | |
*** yangyapeng has joined #openstack-nova | 01:43 | |
*** chyka has quit IRC | 01:43 | |
*** smatzek has quit IRC | 01:44 | |
*** yangyape_ has joined #openstack-nova | 01:45 | |
*** hongbin_ has joined #openstack-nova | 01:45 | |
*** hongbin has quit IRC | 01:47 | |
*** yangyapeng has quit IRC | 01:47 | |
*** crushil has joined #openstack-nova | 01:48 | |
dansmith | melwitt: they work with desc too, will push a test variant at the end | 01:49 |
mriedem | hey, don't forget to read the ML before bed | 01:49 |
mriedem | there is a surprise | 01:49 |
openstackgerrit | Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416 | 01:50 |
dansmith | mriedem: the mogan stuff? | 01:50 |
dansmith | melwitt: ^ | 01:50 |
mriedem | no | 01:50 |
mriedem | better | 01:50 |
mriedem | an old set of friends | 01:50 |
mriedem | coming together at last | 01:50 |
melwitt | dansmith: cool, thanks | 01:51 |
melwitt | I was thinking between the tests earlier in the series to now, everything stitches together, but wasn't totally sure | 01:52 |
dansmith | melwitt: yeah, I think it's all the same enough that it wouldn't matter, but good to have them in there | 01:52 |
melwitt | lol mriedem | 01:54 |
dansmith | oh, the shelve and file injection thing? | 01:55 |
mriedem | yeah | 01:55 |
* dansmith is disappointed | 01:55 | |
mriedem | oh come on | 01:55 |
melwitt | I chuckled | 01:55 |
mriedem | shelve is one of my most favorite things to shit on in the ML on a semi-monthly basis | 01:55 |
mriedem | melwitt: you said you "lol"ed | 01:56 |
melwitt | I chuckled out loud | 01:56 |
mriedem | ok | 01:56 |
melwitt | a chuckle is a laugh right? | 01:56 |
dansmith | issubclass('chuckle', 'laugh') == True | 01:56 |
mriedem | ok | 01:56 |
mriedem | didn't know the rules | 01:56 |
melwitt | haha yeeeah | 01:56 |
dansmith | rules ^ | 01:56 |
mriedem | you know, | 01:56 |
mriedem | if we allowed you to just specify personality files on unshelve... | 01:57 |
mriedem | basically, | 01:57 |
dansmith | you know, if we took shelve and file injection out back and set them on fire... | 01:57 |
mriedem | if we just allowed you to specify everything you can specify on initial create, but on rebuild and unshelve, we'd be good | 01:57 |
melwitt | well yeah, that's what everyone wants | 01:57 |
mriedem | well we're doing that with file injection this release, i just need to spec that up | 01:57 |
mriedem | maybe shelve/unshelve should be a topic at the forum | 01:58 |
mriedem | "can we please just remove this? please?" | 01:58 |
dansmith | getting input on who actually uses it and for what seems fairly legit to me, fwiw | 01:58 |
dansmith | like if nobody cares if it keeps working, I care a lot less than I already do | 01:58 |
dansmith | and I care very little | 01:58 |
mriedem | yeah we still kick that idea around on figuring out who is using the APIs | 01:59 |
*** phuongnh has joined #openstack-nova | 01:59 | |
mriedem | maybe that's a brainstormer | 01:59 |
* mriedem adds | 01:59 | |
*** slaweq has joined #openstack-nova | 01:59 | |
melwitt | based on the amount of bugs I see with it, I will guess a fair number of people use it | 01:59 |
*** mingyu has joined #openstack-nova | 01:59 | |
melwitt | *bug reports | 01:59 |
dansmith | I want to know how many people use it for real, vs. use tempest to verify their cloud and continually find it broken and think it's worth reporting | 02:00 |
dansmith | but, also getting 'why do you want to use this' answered is useful I think | 02:00 |
dansmith | because if they're using it instead of snapshot for dumb reasons... | 02:00 |
melwitt | yeah. just musing | 02:00 |
melwitt | talkin it up | 02:01 |
melwitt | talkin bout topics | 02:01 |
*** crushil has quit IRC | 02:02 | |
mriedem | the tempest tests are super simple too | 02:03 |
*** slaweq has quit IRC | 02:03 | |
openstackgerrit | wanghongtaozz proposed openstack/nova master: Fix typos https://review.openstack.org/506437 | 02:04 |
dansmith | oooh, typos | 02:04 |
* dansmith clicks with fury | 02:04 | |
dansmith | fix _all_ the typos | 02:05 |
mriedem | -1'ed with fury | 02:06 |
*** vladikr has quit IRC | 02:06 | |
*** vladikr has joined #openstack-nova | 02:07 | |
mriedem | https://review.openstack.org/#/q/owner:wanghongtaozz+status:open | 02:07 |
mriedem | a nice pattern | 02:07 |
*** thorst has joined #openstack-nova | 02:07 | |
*** thorst has quit IRC | 02:07 | |
melwitt | ... yeah | 02:08 |
*** sapd has quit IRC | 02:13 | |
*** kevi9132_ has joined #openstack-nova | 02:16 | |
*** vladikr has quit IRC | 02:16 | |
*** kevi9132 has quit IRC | 02:16 | |
*** bigdogstl has joined #openstack-nova | 02:16 | |
*** dave-mccowan has quit IRC | 02:17 | |
openstackgerrit | Merged openstack/nova master: Add db.instance_get_by_sort_filters() https://review.openstack.org/504985 | 02:17 |
*** slaweq has joined #openstack-nova | 02:20 | |
*** bigdogstl has quit IRC | 02:21 | |
*** TuanLA has joined #openstack-nova | 02:23 | |
*** slaweq has quit IRC | 02:26 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Remove allocations when unshelve fails on host https://review.openstack.org/506458 | 02:27 |
*** tbachman has quit IRC | 02:32 | |
*** vladikr has joined #openstack-nova | 02:33 | |
*** zhouyaguo has joined #openstack-nova | 02:37 | |
*** mdnadeem has joined #openstack-nova | 02:37 | |
*** mriedem has quit IRC | 02:39 | |
*** kenperkins has joined #openstack-nova | 02:40 | |
*** jobewan has joined #openstack-nova | 02:43 | |
*** jobewan has quit IRC | 02:49 | |
*** sapd has joined #openstack-nova | 02:53 | |
*** tidwellr has quit IRC | 02:53 | |
*** baoli has quit IRC | 02:56 | |
*** kenperkins has quit IRC | 02:58 | |
*** kevi9132_ has quit IRC | 02:58 | |
*** kevi9132 has joined #openstack-nova | 02:58 | |
*** Tom has joined #openstack-nova | 02:59 | |
*** vladikr has quit IRC | 03:02 | |
*** kevi9132 has quit IRC | 03:03 | |
*** vladikr has joined #openstack-nova | 03:03 | |
*** trungnv has joined #openstack-nova | 03:04 | |
*** sbezverk has quit IRC | 03:06 | |
*** thorst has joined #openstack-nova | 03:08 | |
*** gouthamr has quit IRC | 03:10 | |
*** vladikr has quit IRC | 03:10 | |
*** vladikr has joined #openstack-nova | 03:10 | |
*** trungnv has quit IRC | 03:16 | |
*** vladikr has quit IRC | 03:16 | |
*** vladikr has joined #openstack-nova | 03:16 | |
alex_xu | dansmith: just found the default dir is 'desc', not the 'asc', the confusing thing is we pass a different different_dir to process_sort_params...https://review.openstack.org/#/c/504983/8/nova/compute/instance_list.py@87 | 03:17 |
*** sapd_ has joined #openstack-nova | 03:18 | |
*** sapd has quit IRC | 03:18 | |
dansmith | alex_xu: I don't think it matters anyway, right? | 03:19 |
dansmith | some default sort order helps for consistency, but if the user didn't ask for something specific I don't think we have any requirement to give them something specific | 03:20 |
alex_xu | dansmith: yes, the only thing is the default order changed, the API behaviour should be stable? | 03:22 |
dansmith | alex_xu: if you think it's important we can change it to desc by default, but I don't think it matters | 03:24 |
dansmith | if you don't ask for a sort order, I don't think you can complain about which way we sort it :) | 03:24 |
dansmith | sorting desc by default also seems weird to me, but.. | 03:24 |
alex_xu | dansmith: emm...only can complain is the api-ref talk about default order https://developer.openstack.org/api-ref/compute/#id4 :) | 03:26 |
dansmith | alex_xu: where? I don't see "sort" or "order" on that page | 03:27 |
dansmith | the default sort includes db id, so I hope we're not saying that in our api ref :) | 03:27 |
alex_xu | dansmith: the description of sort_key, "Sorts by a server attribute. Default attribute is created.", but yea, there is mistake, it is created_at, not created | 03:28 |
alex_xu | dansmith: yea, good luck, we didn't mention that :) | 03:28 |
dansmith | alex_xu: I don't see where you see that in that doc | 03:29 |
alex_xu | dansmith: the request parameters of https://developer.openstack.org/api-ref/compute/#list-servers | 03:29 |
dansmith | okay I see it | 03:30 |
alex_xu | no anchor to specific parameter :( | 03:30 |
dansmith | still, it says desc by created (at) | 03:30 |
dansmith | I wish we hadn't codified that :/ | 03:30 |
dansmith | anyway, I'll change it back to desc in the fixes patch at the end of that series | 03:30 |
*** udesale has joined #openstack-nova | 03:33 | |
alex_xu | dansmith: ok, thanks, it cure my OCD | 03:34 |
dansmith | heh | 03:34 |
*** bigdogstl has joined #openstack-nova | 03:35 | |
*** bigdogstl has quit IRC | 03:42 | |
*** slaweq has joined #openstack-nova | 03:47 | |
*** psachin has joined #openstack-nova | 03:47 | |
*** sapd_ has quit IRC | 03:52 | |
*** slaweq has quit IRC | 03:53 | |
*** mdnadeem has quit IRC | 03:56 | |
*** links has joined #openstack-nova | 03:57 | |
*** sapd_ has joined #openstack-nova | 03:57 | |
*** hongbin_ has quit IRC | 03:58 | |
*** john5223_ has joined #openstack-nova | 04:00 | |
*** vladikr has quit IRC | 04:00 | |
openstackgerrit | Michael Still proposed openstack/nova master: Use privsep.path in create_ploop_image https://review.openstack.org/504429 | 04:11 |
*** sridharg has joined #openstack-nova | 04:13 | |
*** claudiub has joined #openstack-nova | 04:14 | |
*** Sree has joined #openstack-nova | 04:15 | |
*** hshiina has joined #openstack-nova | 04:17 | |
*** sapd__ has joined #openstack-nova | 04:21 | |
*** sapd_ has quit IRC | 04:21 | |
*** Sukhdev has joined #openstack-nova | 04:22 | |
*** yangyape_ has quit IRC | 04:29 | |
*** yangyapeng has joined #openstack-nova | 04:30 | |
*** markvoelker has quit IRC | 04:30 | |
*** slaweq has joined #openstack-nova | 04:30 | |
*** yangyapeng has quit IRC | 04:34 | |
*** slaweq has quit IRC | 04:36 | |
*** thorst has quit IRC | 04:36 | |
*** _pewp_ has quit IRC | 04:42 | |
*** _pewp_ has joined #openstack-nova | 04:43 | |
*** crushil has joined #openstack-nova | 04:43 | |
*** itlinux has joined #openstack-nova | 04:46 | |
*** vvargaszte has joined #openstack-nova | 04:48 | |
*** ratailor has joined #openstack-nova | 04:48 | |
*** psachin has quit IRC | 04:48 | |
*** itlinux has quit IRC | 04:49 | |
*** hferenc has quit IRC | 04:50 | |
*** esberglu has joined #openstack-nova | 04:51 | |
*** itlinux has joined #openstack-nova | 04:51 | |
*** mdnadeem has joined #openstack-nova | 04:52 | |
*** hferenc has joined #openstack-nova | 04:52 | |
*** gyee has quit IRC | 04:55 | |
*** esberglu has quit IRC | 04:56 | |
*** hshiina has quit IRC | 04:58 | |
*** chyka has joined #openstack-nova | 05:00 | |
*** psachin has joined #openstack-nova | 05:03 | |
*** chyka has quit IRC | 05:05 | |
*** vvargaszte has quit IRC | 05:06 | |
openstackgerrit | Rajesh Tailor proposed openstack/nova master: Host addition host-aggregate should be case-sensitive https://review.openstack.org/498334 | 05:09 |
*** itlinux has quit IRC | 05:12 | |
*** vks1 has joined #openstack-nova | 05:12 | |
*** yamahata has joined #openstack-nova | 05:12 | |
*** slaweq has joined #openstack-nova | 05:14 | |
*** slaweq has quit IRC | 05:20 | |
*** yangyapeng has joined #openstack-nova | 05:20 | |
*** Tom has quit IRC | 05:23 | |
*** Sukhdev has quit IRC | 05:27 | |
*** shaner has quit IRC | 05:29 | |
*** shaner has joined #openstack-nova | 05:30 | |
*** psachin has quit IRC | 05:32 | |
*** thorst has joined #openstack-nova | 05:33 | |
*** psachin has joined #openstack-nova | 05:37 | |
*** crushil has quit IRC | 05:37 | |
*** bigdogstl has joined #openstack-nova | 05:39 | |
*** crushil has joined #openstack-nova | 05:43 | |
*** bigdogstl has quit IRC | 05:43 | |
*** crushil has quit IRC | 05:58 | |
*** lajoskatona has joined #openstack-nova | 06:00 | |
*** Oku_OS-away is now known as Oku_OS | 06:03 | |
*** sridharg has quit IRC | 06:04 | |
*** shaner has quit IRC | 06:06 | |
*** trungnv has joined #openstack-nova | 06:09 | |
*** shaner has joined #openstack-nova | 06:11 | |
*** liverpooler has joined #openstack-nova | 06:15 | |
*** Tom has joined #openstack-nova | 06:18 | |
openstackgerrit | Merged openstack/nova master: Support pagination in instance_list https://review.openstack.org/504986 | 06:20 |
*** andreas_s has joined #openstack-nova | 06:21 | |
*** vvargaszte has joined #openstack-nova | 06:22 | |
*** markvoelker has joined #openstack-nova | 06:31 | |
*** zhurong has quit IRC | 06:32 | |
*** esberglu has joined #openstack-nova | 06:39 | |
*** yamamoto has quit IRC | 06:41 | |
*** lajoskatona has quit IRC | 06:41 | |
*** esberglu has quit IRC | 06:44 | |
*** sahid has joined #openstack-nova | 06:44 | |
*** yamamoto has joined #openstack-nova | 06:45 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Mention API behavior change when over quota limit https://review.openstack.org/506544 | 06:46 |
*** lajoskatona has joined #openstack-nova | 06:46 | |
*** Sree has quit IRC | 06:46 | |
*** Sree has joined #openstack-nova | 06:47 | |
*** Sree has quit IRC | 06:47 | |
*** Sree has joined #openstack-nova | 06:47 | |
*** slaweq has joined #openstack-nova | 06:50 | |
*** thorst has quit IRC | 06:53 | |
*** slaweq has quit IRC | 06:55 | |
*** rcernin has joined #openstack-nova | 06:56 | |
*** kevi9132 has joined #openstack-nova | 07:00 | |
*** bigdogstl has joined #openstack-nova | 07:00 | |
*** gszasz has joined #openstack-nova | 07:00 | |
*** slaweq has joined #openstack-nova | 07:01 | |
*** _pewp_ has quit IRC | 07:02 | |
*** _pewp_ has joined #openstack-nova | 07:02 | |
*** bigdogstl has quit IRC | 07:02 | |
*** kevi9132 has quit IRC | 07:04 | |
*** markvoelker has quit IRC | 07:05 | |
*** abhishekk has joined #openstack-nova | 07:05 | |
*** slaweq_ has joined #openstack-nova | 07:07 | |
*** slaweq has quit IRC | 07:07 | |
*** tesseract has joined #openstack-nova | 07:11 | |
*** zhurong has joined #openstack-nova | 07:12 | |
*** bigdogstl has joined #openstack-nova | 07:12 | |
*** slaweq has joined #openstack-nova | 07:13 | |
*** ioggstream has joined #openstack-nova | 07:14 | |
*** bigdogstl has quit IRC | 07:16 | |
*** armax has quit IRC | 07:16 | |
*** slaweq has quit IRC | 07:17 | |
*** slaweq has joined #openstack-nova | 07:23 | |
openstackgerrit | Rajesh Tailor proposed openstack/nova master: Host addition host-aggregate should be case-sensitive https://review.openstack.org/498334 | 07:26 |
*** slaweq has quit IRC | 07:27 | |
*** slaweq has joined #openstack-nova | 07:33 | |
*** pcaruana has joined #openstack-nova | 07:34 | |
*** alexchadin has joined #openstack-nova | 07:37 | |
*** slaweq has quit IRC | 07:39 | |
*** jpena|off is now known as jpena | 07:44 | |
*** ianw is now known as ianw|pto | 07:46 | |
*** tejaswi has joined #openstack-nova | 07:48 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Add API to allow update keypair for instance https://review.openstack.org/506552 | 07:49 |
*** cshen has quit IRC | 07:49 | |
*** kornicameister has joined #openstack-nova | 07:49 | |
*** thorst has joined #openstack-nova | 07:50 | |
*** cshen has joined #openstack-nova | 07:51 | |
*** hieulq has quit IRC | 07:51 | |
*** TuanLA has quit IRC | 07:51 | |
*** TuanLA has joined #openstack-nova | 07:52 | |
*** hieulq has joined #openstack-nova | 07:52 | |
*** tssurya has joined #openstack-nova | 07:53 | |
*** ralonsoh has joined #openstack-nova | 07:55 | |
*** takashin has left #openstack-nova | 07:56 | |
openstackgerrit | Elod Illes proposed openstack/nova master: Add instance.interface_detach notification https://review.openstack.org/506284 | 07:57 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Add API to allow update keypair for instance https://review.openstack.org/506552 | 07:59 |
*** liusheng has quit IRC | 08:01 | |
*** liusheng has joined #openstack-nova | 08:02 | |
*** markvoelker has joined #openstack-nova | 08:02 | |
*** slaweq has joined #openstack-nova | 08:03 | |
*** mlakat has quit IRC | 08:03 | |
*** xinliang has quit IRC | 08:04 | |
*** iogg has joined #openstack-nova | 08:04 | |
*** spotz has quit IRC | 08:05 | |
*** gszasz has quit IRC | 08:05 | |
*** slaweq_ has quit IRC | 08:05 | |
*** hferenc has quit IRC | 08:05 | |
*** ioggstream has quit IRC | 08:05 | |
*** krtaylor has quit IRC | 08:05 | |
*** weshay_bbiab has quit IRC | 08:05 | |
*** yangzhenyu has quit IRC | 08:05 | |
*** harlowja has quit IRC | 08:06 | |
*** mrodden has quit IRC | 08:06 | |
*** Mr_Smurf has quit IRC | 08:06 | |
*** Mr_Smurf has joined #openstack-nova | 08:06 | |
*** jogo has quit IRC | 08:06 | |
*** sgordon has quit IRC | 08:06 | |
*** tanee has quit IRC | 08:07 | |
*** stvnoyes has quit IRC | 08:07 | |
*** hferenc has joined #openstack-nova | 08:07 | |
*** spotz has joined #openstack-nova | 08:10 | |
*** sgordon has joined #openstack-nova | 08:10 | |
*** weshay has joined #openstack-nova | 08:11 | |
*** slaweq has quit IRC | 08:11 | |
*** mrodden has joined #openstack-nova | 08:11 | |
*** slaweq has joined #openstack-nova | 08:12 | |
*** zhouyaguo has quit IRC | 08:12 | |
*** tanee has joined #openstack-nova | 08:14 | |
*** ralonsoh_ has joined #openstack-nova | 08:14 | |
*** ralonsoh has quit IRC | 08:14 | |
*** zsli_ has joined #openstack-nova | 08:17 | |
*** slaweq_ has joined #openstack-nova | 08:17 | |
*** krtaylor has joined #openstack-nova | 08:17 | |
*** yangzhenyu has joined #openstack-nova | 08:17 | |
*** xinliang has joined #openstack-nova | 08:18 | |
*** jogo has joined #openstack-nova | 08:18 | |
*** iogg is now known as ioggstream | 08:18 | |
ioggstream | hi@all | 08:19 |
*** Shunli has quit IRC | 08:19 | |
*** gszasz has joined #openstack-nova | 08:20 | |
*** mnestratov has joined #openstack-nova | 08:20 | |
*** gszasz has quit IRC | 08:22 | |
*** zhouyaguo has joined #openstack-nova | 08:22 | |
*** slaweq_ has quit IRC | 08:22 | |
*** stvnoyes has joined #openstack-nova | 08:22 | |
*** gszasz has joined #openstack-nova | 08:23 | |
*** esberglu has joined #openstack-nova | 08:27 | |
*** slaweq_ has joined #openstack-nova | 08:27 | |
*** esberglu has quit IRC | 08:32 | |
*** slaweq_ has quit IRC | 08:32 | |
*** cdent has joined #openstack-nova | 08:34 | |
*** markvoelker has quit IRC | 08:36 | |
*** chyka has joined #openstack-nova | 08:37 | |
*** slaweq_ has joined #openstack-nova | 08:37 | |
*** iogg has joined #openstack-nova | 08:39 | |
*** ioggstream has quit IRC | 08:39 | |
*** lajoskatona has quit IRC | 08:40 | |
*** chyka has quit IRC | 08:41 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Add datapath type information to OVS vif objects https://review.openstack.org/474892 | 08:41 |
*** mlakat has joined #openstack-nova | 08:41 | |
*** lajoskatona has joined #openstack-nova | 08:41 | |
*** slaweq_ has quit IRC | 08:44 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/449257 | 08:51 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Add Neutron port capabilities to devspec in request https://review.openstack.org/451777 | 08:51 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Format NIC features using os-traits definitions https://review.openstack.org/466051 | 08:51 |
ratailor | alex_xu, Can you pl review https://review.openstack.org/#/c/504885/ | 08:52 |
*** bigdogstl has joined #openstack-nova | 08:53 | |
alex_xu | ratailor: can we do collate change online? | 08:54 |
ratailor | alex_xu, I am not sure about that whether it would work online or not. | 08:55 |
*** bigdogstl has quit IRC | 08:58 | |
*** slaweq_ has joined #openstack-nova | 08:59 | |
alex_xu | I remember that will lead to temorary table copy | 09:00 |
alex_xu | ratailor: maybe jaypipes is right person to answer that | 09:00 |
ratailor | alex_xu, Thanks, will try to contact him. | 09:01 |
*** gszasz has quit IRC | 09:03 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add memoize function using oslo.cache https://review.openstack.org/472773 | 09:04 |
*** mingyu has quit IRC | 09:04 | |
*** slaweq_ has quit IRC | 09:04 | |
*** trungnv has quit IRC | 09:05 | |
*** slaweq_ has joined #openstack-nova | 09:10 | |
*** zsli__ has joined #openstack-nova | 09:10 | |
*** Tom has quit IRC | 09:12 | |
*** zsli_ has quit IRC | 09:12 | |
*** Tom has joined #openstack-nova | 09:15 | |
*** slaweq_ has quit IRC | 09:16 | |
*** Sree has quit IRC | 09:19 | |
*** yufei has joined #openstack-nova | 09:20 | |
*** Sree has joined #openstack-nova | 09:20 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Support live migration in pooled multi-nodes environment https://review.openstack.org/489451 | 09:24 |
*** Sree has quit IRC | 09:24 | |
*** zsli__ has quit IRC | 09:29 | |
*** slaweq_ has joined #openstack-nova | 09:32 | |
*** markvoelker has joined #openstack-nova | 09:33 | |
tssurya | dansmith: mriedem: I was able to reproduce this bug - https://bugs.launchpad.net/nova/+bug/1687362 ; so will start my contributions with this. | 09:33 |
openstack | Launchpad bug 1687362 in OpenStack Compute (nova) "Instance not mapped after running command "nova-manage cell_v2 map_instances --cell_uuid <cell_uuid>"." [Undecided,Incomplete] - Assigned to Surya Seetharaman (tssurya) | 09:33 |
*** slaweq_ has quit IRC | 09:37 | |
*** yamamoto has quit IRC | 09:41 | |
*** yamamoto has joined #openstack-nova | 09:42 | |
*** slaweq_ has joined #openstack-nova | 09:42 | |
*** Tom has quit IRC | 09:48 | |
*** slaweq_ has quit IRC | 09:48 | |
*** yamamoto has quit IRC | 09:50 | |
*** inara has quit IRC | 09:53 | |
*** alexchadin has quit IRC | 09:53 | |
*** alexchadin has joined #openstack-nova | 09:53 | |
*** ioggstream has joined #openstack-nova | 09:54 | |
*** alexchadin has quit IRC | 09:54 | |
*** iogg has quit IRC | 09:55 | |
*** inara has joined #openstack-nova | 09:55 | |
*** alexchadin has joined #openstack-nova | 09:55 | |
*** alexchadin has quit IRC | 10:00 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API https://review.openstack.org/476612 | 10:00 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226 | 10:01 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migration from ``ip`` commands to ``pyroute2`` https://review.openstack.org/484386 | 10:04 |
*** psachin has quit IRC | 10:04 | |
*** mingyu has joined #openstack-nova | 10:04 | |
*** bigdogstl has joined #openstack-nova | 10:05 | |
*** markvoelker has quit IRC | 10:06 | |
*** yufei has quit IRC | 10:06 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add Virtual Ethernet device pair https://review.openstack.org/484726 | 10:08 |
*** yangyapeng has quit IRC | 10:09 | |
*** mingyu has quit IRC | 10:09 | |
*** yangyapeng has joined #openstack-nova | 10:09 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Support live migration in pooled multi-nodes environment https://review.openstack.org/489451 | 10:09 |
*** bigdogstl has quit IRC | 10:09 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add Open vSwitch patch port https://review.openstack.org/485228 | 10:13 |
*** udesale has quit IRC | 10:14 | |
*** slaweq_ has joined #openstack-nova | 10:14 | |
*** sdague has joined #openstack-nova | 10:14 | |
*** yangyapeng has quit IRC | 10:14 | |
*** sambetts|afk is now known as sambets | 10:15 | |
*** sambets is now known as bamsetts | 10:15 | |
*** esberglu has joined #openstack-nova | 10:15 | |
*** artom has joined #openstack-nova | 10:17 | |
*** dtantsur|afk is now known as dtantsur | 10:17 | |
*** hieulq has quit IRC | 10:18 | |
artom | lyarwood, heya, now that https://review.openstack.org/#/c/468514/ has merged I think the -1 can come off https://review.openstack.org/#/c/468514/ | 10:19 |
*** esberglu has quit IRC | 10:20 | |
*** slaweq_ has quit IRC | 10:20 | |
*** phuongnh has quit IRC | 10:23 | |
*** psachin has joined #openstack-nova | 10:23 | |
openstackgerrit | Dinesh Bhor proposed openstack/nova master: Fix 500 if list servers called with empty regex pattern https://review.openstack.org/506585 | 10:28 |
*** Sree has joined #openstack-nova | 10:28 | |
*** Sara_ has joined #openstack-nova | 10:28 | |
Sara_ | Hello.. | 10:28 |
Sara_ | Whiel adding a node to cluster one of VM went to ERROR state..Could someone help me out ? | 10:29 |
openstackgerrit | Artom Lifshitz proposed openstack/nova stable/newton: Catch InstanceNotFound exception https://review.openstack.org/467321 | 10:29 |
Sara_ | Error:2017-09-22 08:36:40.046 18679 ERROR oslo_messaging.rpc.dispatcher [req-63c7b5d2-83a4-4531-b120-afbab733fb5a a31283a931844c4a88309b0a6d1ece85 26cc9b81f0b14ae0856eac6d635da676 - - -] Exception during message handling: Instance <instance_id> in power_state 1. Cannot get_diagnostics while the instance is in this state. | 10:30 |
*** ralonsoh__ has joined #openstack-nova | 10:31 | |
*** Sree has quit IRC | 10:32 | |
*** sapd__ has quit IRC | 10:33 | |
*** sapd__ has joined #openstack-nova | 10:33 | |
*** ralonsoh_ has quit IRC | 10:35 | |
*** TuanLA has quit IRC | 10:35 | |
*** yangzhenyu has quit IRC | 10:35 | |
*** sahid has quit IRC | 10:35 | |
*** sahid has joined #openstack-nova | 10:36 | |
*** artom has quit IRC | 10:37 | |
*** artom has joined #openstack-nova | 10:38 | |
*** zhurong has quit IRC | 10:39 | |
*** tejaswi has quit IRC | 10:39 | |
*** yamamoto has joined #openstack-nova | 10:50 | |
*** yangzhenyu has joined #openstack-nova | 10:54 | |
*** yamamoto has quit IRC | 10:57 | |
*** Sree has joined #openstack-nova | 10:59 | |
*** iogg has joined #openstack-nova | 11:00 | |
*** ioggstream has quit IRC | 11:01 | |
*** kevi9132 has joined #openstack-nova | 11:01 | |
*** Sree has quit IRC | 11:03 | |
*** links has quit IRC | 11:03 | |
*** markvoelker has joined #openstack-nova | 11:03 | |
*** bigdogstl has joined #openstack-nova | 11:06 | |
*** kevi9132 has quit IRC | 11:06 | |
*** dave-mccowan has joined #openstack-nova | 11:06 | |
*** slaweq_ has joined #openstack-nova | 11:09 | |
*** alexchadin has joined #openstack-nova | 11:10 | |
*** esberglu has joined #openstack-nova | 11:10 | |
*** bigdogstl has quit IRC | 11:10 | |
*** Yikun has joined #openstack-nova | 11:10 | |
*** zhouyaguo has quit IRC | 11:11 | |
*** Yikun has quit IRC | 11:12 | |
*** machinist has joined #openstack-nova | 11:12 | |
*** machinist has left #openstack-nova | 11:12 | |
*** yikun has joined #openstack-nova | 11:13 | |
*** slaweq_ has quit IRC | 11:13 | |
*** esberglu has quit IRC | 11:14 | |
*** mingyu has joined #openstack-nova | 11:15 | |
*** alexchadin has quit IRC | 11:17 | |
*** slaweq_ has joined #openstack-nova | 11:19 | |
*** alexchadin has joined #openstack-nova | 11:19 | |
*** links has joined #openstack-nova | 11:22 | |
*** slaweq_ has quit IRC | 11:25 | |
*** links has quit IRC | 11:29 | |
*** sapd__ has quit IRC | 11:30 | |
*** alexchadin has quit IRC | 11:33 | |
*** alexchadin has joined #openstack-nova | 11:35 | |
openstackgerrit | Jesse Pretorius (odyssey4me) proposed openstack/nova master: Add default configuration files to data_files https://review.openstack.org/506188 | 11:37 |
*** markvoelker has quit IRC | 11:37 | |
*** avolkov has joined #openstack-nova | 11:37 | |
*** links has joined #openstack-nova | 11:42 | |
*** sapd__ has joined #openstack-nova | 11:43 | |
*** gcb has quit IRC | 11:45 | |
*** alexchadin has quit IRC | 11:45 | |
*** ioggstream has joined #openstack-nova | 11:46 | |
*** alexchadin has joined #openstack-nova | 11:46 | |
*** iogg has quit IRC | 11:46 | |
*** thorst has quit IRC | 11:47 | |
*** thorst has joined #openstack-nova | 11:47 | |
*** liuyulong has joined #openstack-nova | 11:47 | |
*** yangyapeng has joined #openstack-nova | 11:47 | |
*** andreas_s has quit IRC | 11:49 | |
*** sapd__ has quit IRC | 11:49 | |
*** lajoskatona has quit IRC | 11:50 | |
*** MVenesio has joined #openstack-nova | 11:51 | |
*** lajoskatona has joined #openstack-nova | 11:51 | |
openstackgerrit | Sean Dague proposed openstack/nova master: Change livesnapshot to true by default https://review.openstack.org/454323 | 11:52 |
*** vvargaszte has quit IRC | 11:53 | |
*** vks1 has quit IRC | 11:53 | |
liuyulong | 1 | 11:56 |
*** yamamoto has joined #openstack-nova | 11:56 | |
liuyulong | ping sdague | 11:57 |
*** alexchadin has quit IRC | 11:58 | |
sdague | liuyulong: what's up? | 11:58 |
liuyulong | sdague, hello, https://review.openstack.org/#/c/375221/, can we move this spec forward? | 12:00 |
*** alexchadin has joined #openstack-nova | 12:00 | |
liuyulong | sdague, you've one given a +2. | 12:01 |
sdague | at the PTG it was discussed, let me get notes up | 12:02 |
*** avolkov has quit IRC | 12:02 | |
liuyulong | sdague, nice, so what's the next step? | 12:02 |
*** jpena is now known as jpena|lunch | 12:03 | |
sdague | https://etherpad.openstack.org/p/nova-ptg-queens L498 | 12:03 |
liuyulong | sdague, I am now an individual contributor, : ) | 12:04 |
sdague | so, I think the concensus was that Kevin_Zheng was going to help on the spec, and that we'd actually just add it as one of the mutable fields on the server object | 12:04 |
sdague | so that it applies to reboot as well as rebuild | 12:04 |
*** gszasz has joined #openstack-nova | 12:05 | |
Kevin_Zheng | sdague: yeah, I pinged tiling | 12:05 |
liuyulong | looking... | 12:05 |
sdague | Kevin_Zheng: ok, great | 12:06 |
Kevin_Zheng | I pinged yulong today and I think we can work together if he wish | 12:06 |
*** bigdogstl has joined #openstack-nova | 12:06 | |
*** alexchadin has quit IRC | 12:07 | |
sdague | Kevin_Zheng: great | 12:08 |
*** alexchadin has joined #openstack-nova | 12:08 | |
liuyulong | sdague, Kevin_Zheng, I'm glad to. so here is the patch for that spec, https://review.openstack.org/#/c/379128/. I don't think there has any conflicts. | 12:08 |
liuyulong | correct me, if i missing something. | 12:09 |
*** markvoelker has joined #openstack-nova | 12:10 | |
liuyulong | Idividual contributor has a small chance to attend ptgs. haha | 12:10 |
*** bigdogstl has quit IRC | 12:11 | |
*** avolkov has joined #openstack-nova | 12:12 | |
liuyulong | Kevin_Zheng, feel free to directly update the spec: https://review.openstack.org/#/c/375221/, since the PTG etherpad linked this. | 12:12 |
*** READ10 has joined #openstack-nova | 12:14 | |
*** alexchadin has quit IRC | 12:14 | |
*** alexchadin has joined #openstack-nova | 12:15 | |
Kevin_Zheng | I already had one up, but sure I can do that | 12:15 |
liuyulong | https://review.openstack.org/#/c/506552/, this one? nice work. | 12:17 |
*** artom has quit IRC | 12:18 | |
Kevin_Zheng | Yeah I can merge these two | 12:19 |
*** jmlowe has quit IRC | 12:19 | |
*** litao__ has quit IRC | 12:22 | |
liuyulong | I don't think this two spec can be merged. Your spec is going to add a new API, mine updating rebuild API. Basically they don't affect each other. | 12:24 |
Kevin_Zheng | Ok | 12:24 |
*** sapd has joined #openstack-nova | 12:26 | |
*** kylek3h has joined #openstack-nova | 12:29 | |
*** erlon has joined #openstack-nova | 12:36 | |
*** edmondsw has joined #openstack-nova | 12:36 | |
openstackgerrit | Dinesh Bhor proposed openstack/nova master: Fix 500 if list servers called with empty regex pattern https://review.openstack.org/506585 | 12:38 |
*** jaosorior has quit IRC | 12:40 | |
*** slaweq_ has joined #openstack-nova | 12:41 | |
*** sapd has quit IRC | 12:41 | |
*** sapd has joined #openstack-nova | 12:42 | |
*** Tom___ has joined #openstack-nova | 12:42 | |
*** dave-mccowan has quit IRC | 12:43 | |
*** lyan has joined #openstack-nova | 12:43 | |
*** dave-mccowan has joined #openstack-nova | 12:44 | |
*** ratailor has quit IRC | 12:45 | |
liuyulong | mriedem | 12:46 |
*** Tom___ has quit IRC | 12:46 | |
openstackgerrit | Elod Illes proposed openstack/nova master: Add instance.interface_detach notification https://review.openstack.org/506284 | 12:47 |
*** slaweq_ has quit IRC | 12:47 | |
*** mriedem has joined #openstack-nova | 12:48 | |
*** kevi9132 has joined #openstack-nova | 12:49 | |
*** catintheroof has joined #openstack-nova | 12:50 | |
*** slaweq has quit IRC | 12:50 | |
*** slaweq has joined #openstack-nova | 12:51 | |
*** edleafe is now known as figleaf | 12:52 | |
*** kevi9132_ has joined #openstack-nova | 12:52 | |
*** slaweq_ has joined #openstack-nova | 12:52 | |
*** lajoskatona has quit IRC | 12:53 | |
*** kevi9132 has quit IRC | 12:54 | |
*** sapd has quit IRC | 12:55 | |
*** sapd_ has joined #openstack-nova | 12:55 | |
*** slaweq_ has quit IRC | 12:57 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/506640 | 12:57 |
*** lajoskatona has joined #openstack-nova | 12:57 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-traits master: Updated from global requirements https://review.openstack.org/503646 | 12:59 |
*** jmlowe has joined #openstack-nova | 13:00 | |
*** jmlowe has quit IRC | 13:01 | |
*** jpena|lunch is now known as jpena | 13:01 | |
*** jmlowe has joined #openstack-nova | 13:01 | |
openstackgerrit | Elod Illes proposed openstack/nova master: Add error notification for instance.interface_attach https://review.openstack.org/506643 | 13:02 |
*** artom has joined #openstack-nova | 13:03 | |
*** jmlowe_ has joined #openstack-nova | 13:03 | |
*** nicolasbock has joined #openstack-nova | 13:04 | |
*** jmlowe_ has quit IRC | 13:05 | |
*** jmlowe has quit IRC | 13:06 | |
*** jmlowe has joined #openstack-nova | 13:07 | |
*** bigdogstl has joined #openstack-nova | 13:07 | |
*** esberglu has joined #openstack-nova | 13:08 | |
*** alexchadin has quit IRC | 13:08 | |
*** sbezverk has joined #openstack-nova | 13:08 | |
*** bigdogstl has quit IRC | 13:12 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove allocations when unshelve fails on host https://review.openstack.org/506458 | 13:13 |
*** slaweq_ has joined #openstack-nova | 13:14 | |
*** purplerbot has quit IRC | 13:17 | |
*** alexchadin has joined #openstack-nova | 13:18 | |
*** slaweq_ has quit IRC | 13:19 | |
openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 13:23 |
*** gouthamr has joined #openstack-nova | 13:24 | |
*** jmlowe has quit IRC | 13:26 | |
*** baoli has joined #openstack-nova | 13:27 | |
*** links has quit IRC | 13:28 | |
*** jmlowe has joined #openstack-nova | 13:35 | |
*** Dinesh_Bhor has quit IRC | 13:36 | |
*** lbragstad has joined #openstack-nova | 13:38 | |
*** cleong has joined #openstack-nova | 13:38 | |
*** alexchadin has quit IRC | 13:40 | |
*** felipemonteiro__ has joined #openstack-nova | 13:40 | |
*** derekh has joined #openstack-nova | 13:41 | |
*** felipemonteiro_ has joined #openstack-nova | 13:41 | |
*** vladikr has joined #openstack-nova | 13:41 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API https://review.openstack.org/476612 | 13:42 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226 | 13:42 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add _wait_for_action_fail_completion to InstanceHelperMixin https://review.openstack.org/506660 | 13:43 |
mriedem | gibi: ^ is where i was going with the refactor | 13:43 |
*** slaweq_ has joined #openstack-nova | 13:45 | |
*** felipemonteiro__ has quit IRC | 13:45 | |
*** awaugama has joined #openstack-nova | 13:48 | |
*** slaweq_ has quit IRC | 13:51 | |
mriedem | bauzas: you've got a race in the test here https://review.openstack.org/#/c/506093/ | 13:54 |
mriedem | need to wait for the migration to be done | 13:54 |
bauzas | mriedem: yeah I know | 13:54 |
bauzas | mriedem: I saw that this morning | 13:55 |
bauzas | mriedem: I have a f*** agenda today | 13:55 |
mriedem | agenda?! | 13:55 |
bauzas | but I'll try to look at it soon | 13:55 |
bauzas | schedule | 13:55 |
mriedem | oh right, red hat friday meetings and bug smash day | 13:55 |
bauzas | meetings day | 13:55 |
mriedem | i love how you guys load all of the worst stuff to the end of the week | 13:55 |
bauzas | even more than that - spoiling some very specific French stuff | 13:55 |
mriedem | very specific french stuff? like a smoking mime eating a croissant? | 13:56 |
*** dtantsur is now known as creepy_owlet | 13:57 | |
stephenfin | mriedem, bauzas: Can one of you merge this so it stops flooding my inbox with Gerrit mails? https://review.openstack.org/#/c/503646/ | 13:58 |
bauzas | stephenfin: Wipped | 13:59 |
openstackgerrit | Evgeny Antyshev proposed openstack/nova master: Vzstorage: synchronize volume connect https://review.openstack.org/505708 | 13:59 |
mriedem | alex_xu: you might like to see this one https://review.openstack.org/#/c/506585/ | 14:00 |
mriedem | stephenfin: your gerrit emails go to your inbox? | 14:01 |
mriedem | that's your mistake | 14:01 |
mriedem | gotta setup a filter rule, especially for the CI emails | 14:01 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix 500 if list servers called with empty regex pattern https://review.openstack.org/506585 | 14:02 |
openstackgerrit | Chris Dent proposed openstack/nova master: DNM: Don't monkey patch eventlet in functional tests https://review.openstack.org/506668 | 14:02 |
*** cdent has quit IRC | 14:04 | |
*** creepy_owlet is now known as creepy_owlet|brb | 14:04 | |
liuyulong | hi mriedem, https://review.openstack.org/#/c/375221/, I've updated the spec, could you please review it again? | 14:05 |
openstackgerrit | Merged openstack/os-traits master: Updated from global requirements https://review.openstack.org/503646 | 14:05 |
*** NobodyCam is now known as BlartVersenwald | 14:06 | |
mriedem | liuyulong: Kevin_Zheng was going to update that spec since we thought it was abandoned, | 14:07 |
*** slaweq_ has joined #openstack-nova | 14:07 | |
liuyulong | mriedem, there are some things that need to be clarified is that this spec can be under parallel development with Kenvin_zheng's os-keypair API. | 14:07 |
mriedem | liuyulong: we discussed this at the PTG last week, and want a different direction | 14:07 |
mriedem | right | 14:07 |
*** ratailor has joined #openstack-nova | 14:07 | |
mriedem | we said we'd provide a way to update the keypair for a specific server, and then the user can reboot or rebuild the instance | 14:07 |
liuyulong | it's not the same. One adding API, one updating rebuild API. | 14:08 |
mriedem | because they might not need to rebuild the guest depending on how cloud-init is configured | 14:08 |
*** MVenesio has quit IRC | 14:08 | |
mriedem | the goal is the same | 14:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate 'keymap' options https://review.openstack.org/483994 | 14:08 |
*** jaypipes has joined #openstack-nova | 14:08 | |
liuyulong | One API can done for updating keypair. But the new API may need two steps. It's waste. | 14:10 |
liuyulong | but the new API can be used for a running injection. | 14:10 |
*** jaypipes is now known as leakypipes | 14:11 | |
liuyulong | So I'd like to say, both can be added to nova. | 14:11 |
*** slaweq_ has quit IRC | 14:11 | |
mriedem | liuyulong: by that logic, why don't we also add keypair to the reboot API so you can specify a new keypair on reboot? | 14:12 |
mriedem | it starts to become a slippery slope | 14:12 |
liuyulong | New API can result an inconsistent situtation when the vm is not reboot. | 14:12 |
mriedem | does Kevin_Zheng have a spec up for review yet? | 14:12 |
liuyulong | yes | 14:12 |
mriedem | inconsistent how? | 14:13 |
liuyulong | https://review.openstack.org/#/c/506552 | 14:13 |
mriedem | yes the keypair is different, because the user changed it | 14:13 |
mriedem | and it's different from the guest until the guest is rebooted or rebuilt | 14:13 |
mriedem | mikal: cburgess: keypair update API spec https://review.openstack.org/#/c/506552 | 14:14 |
mriedem | since you wanted to review | 14:14 |
*** tbachman has joined #openstack-nova | 14:14 | |
liuyulong | That makes could user confused. But rebuild API naturally with a restart. | 14:14 |
*** crushil has joined #openstack-nova | 14:17 | |
mriedem | well, we'd be documenting this API | 14:17 |
mriedem | if you update the keypair on the instance, you have to reboot or rebuild after that | 14:17 |
*** slaweq_ has joined #openstack-nova | 14:17 | |
liuyulong | IMHO, both specs are OK for now. One step for rebuild API make more reasonable. | 14:17 |
mriedem | for it to take effect | 14:17 |
mriedem | sorry but we don't really need 3 ways to do this same thing | 14:17 |
leakypipes | mriedem: +3 | 14:18 |
*** hongbin has joined #openstack-nova | 14:18 | |
mriedem | 3 = keypair update + user reboot/rebuild, keypair during rebuild, keypair during reboot | 14:18 |
mriedem | because then people will also say, "why can't i update the keypair when i unshelve my offloaded instance too?!" | 14:18 |
mriedem | or migrate it | 14:18 |
*** takashin has joined #openstack-nova | 14:20 | |
*** dansmith is now known as superdan | 14:20 | |
leakypipes | superdan: morning. | 14:20 |
superdan | leakypipes: I can confirm that it is indeed morning. | 14:21 |
liuyulong | reboot API can also update the keypair? | 14:21 |
leakypipes | superdan: has Jax attempted homocide yet? | 14:21 |
superdan | leakypipes: I think you mean homicide, and not yet this morning | 14:22 |
superdan | but. it's early. | 14:22 |
mriedem | ha | 14:22 |
leakypipes | superdan: ha, indeed. | 14:22 |
mriedem | liuyulong: no, but that's my point, | 14:22 |
mriedem | if we have one api to update the keypair just on the instance, and one api to rebuild with a new keypair, then people would also want the reboot api to take a keypair, and possibly other APIs, like migrate and unshelve | 14:23 |
mriedem | and we don't want an explosion of API changes to provide a new keypair for every operation | 14:23 |
*** slaweq_ has quit IRC | 14:23 | |
*** stephenfin is now known as finucannot | 14:24 | |
*** cdent has joined #openstack-nova | 14:25 | |
finucannot | leakypipes: Finally settled on a Friday nick that doubles as a learning opportunity (how to pronounce my last name) | 14:25 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: placement: add ProviderTree.is_inventory_empty https://review.openstack.org/480957 | 14:26 |
leakypipes | finucannot: well played, sir. | 14:26 |
Kevin_Zheng | https://blueprints.launchpad.net/nova/+spec/use-constrain-for-microversion-values does anyone find this useful? | 14:26 |
*** lbragstad has quit IRC | 14:27 | |
liuyulong | `rebuild` means recreate a instance, so for custom data, they should have ways to change it. Like name, adminPass, image etc. | 14:27 |
liuyulong | Its not a explosion. | 14:27 |
liuyulong | Just a expanding of rebuilding API | 14:27 |
mriedem | liuyulong: so do you think we should also allow passing in new volumes and ports when rebuilding an instance? | 14:27 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Make 'get_domain' private https://review.openstack.org/417378 | 14:28 |
artom | finucannot, I guess apostrophes aren't allowed in IRC nicks, eh? | 14:29 |
finucannot | leakypipes, sahid: That patch has been open for a long time as is a pretty trivial TODO resolution. Could ye take a look at some point | 14:29 |
*** vladikr has quit IRC | 14:29 | |
*** vks1 has joined #openstack-nova | 14:29 | |
finucannot | artom: I didn't try, just in case :) | 14:29 |
artom | 'cuz finucan't keeps the same number of syllable | 14:29 |
artom | syllables | 14:29 |
*** armax has joined #openstack-nova | 14:29 | |
leakypipes | finucannot: yuppers. just finishing up a review on ralonsoh__'s patch | 14:29 |
finucannot | leakypipes: (y) | 14:30 |
finucannot | artom: Hexchat rejects it anyway, so I assume not | 14:30 |
liuyulong | No. But it is a key data, if rebuilt instance or cloud-platform does not support password. Then the key pair is the only one way to login. | 14:30 |
artom | finucannot, yeah, I'm pretty sure it's not allowed | 14:30 |
ralonsoh__ | leakypipes: thanks for the review | 14:31 |
liuyulong | instance can be running without volume and port. | 14:31 |
mriedem | liuyulong: Kevin_Zheng's spec provides a way to update the keypair which would still be used when rebuilding | 14:31 |
liuyulong | but instance can be useless without a way to login. | 14:31 |
mriedem | and rebooting | 14:31 |
mriedem | and migrating | 14:31 |
mriedem | and unshelving | 14:31 |
*** psachin has quit IRC | 14:32 | |
Kevin_Zheng | Yeah, the new way will be more generic | 14:32 |
leakypipes | finucannot: k, on to your patch. swap with you... https://review.openstack.org/#/c/474892/ | 14:32 |
figleaf | superdan: working on your comments about the Selection object. | 14:32 |
bauzas | damn Friday gods | 14:32 |
*** bauzas is now known as bauwser | 14:32 | |
leakypipes | ralonsoh__: no problemo :) | 14:32 |
figleaf | superdan: is there a general way of handling the "Cannot load 'node_name' in the base class" type of errors when not every value is passed at creation time? | 14:33 |
liuyulong | again, its totally two different ways. One API make sense while rebuild. That also make consistent with instance name, image, admin pass. | 14:33 |
finucannot | leakypipes: I feel this is an unworthy trade, but I like ralonsoh__ so deal ;) | 14:33 |
superdan | figleaf: everything should be passed at create time for this I would think | 14:33 |
leakypipes | finucannot: +2 from me on that | 14:33 |
ralonsoh__ | finucannot: me too hehehe | 14:34 |
leakypipes | now on to figleaf's patches... | 14:34 |
*** mdnadeem has quit IRC | 14:34 | |
figleaf | leakypipes: be aware that I have updates to post soon | 14:34 |
figleaf | you might want to wait | 14:34 |
Kevin_Zheng | liuyulong: I think the Matts point is, we don't need two ways, if we open this door, people may ask to add it too to reboot API, etc | 14:35 |
liuyulong | If new API does not supporting running injection, the DB keypair and guest keypair are not consistent without a rebuiding, reboot, unshelving... This looks not good. | 14:36 |
*** vks1 has quit IRC | 14:36 | |
leakypipes | figleaf: k. just reading superdan | 14:36 |
leakypipes | s review of the Selection patch now. | 14:36 |
leakypipes | figleaf: will hold off on commenting. | 14:36 |
liuyulong | Kevin_Zheng, no, I'll not agree that. If its not a `recreating` API. | 14:37 |
Kevin_Zheng | liuyulong: yeah, we will document it well | 14:37 |
liuyulong | Kevin_Zheng, document can not avoid that inconsistent. Cloud user may not remember what they have done, : ) | 14:38 |
*** slaweq_ has joined #openstack-nova | 14:39 | |
liuyulong | So, again, IMHO, both specs are OK for now. One step for rebuild API make more reasonable. | 14:39 |
*** catintheroof has quit IRC | 14:42 | |
*** vladikr has joined #openstack-nova | 14:42 | |
mriedem | Kevin_Zheng: comments in your spec https://review.openstack.org/#/c/506552/ plus mikal needs to review that | 14:43 |
takashin | oomichi: Are you around? | 14:43 |
*** slaweq_ has quit IRC | 14:44 | |
mriedem | liuyulong: if the user doesn't know what they are doing, they shouldn't be doing it | 14:44 |
mriedem | one could add layers of orchestration on top of this if needed for simple users, | 14:44 |
mriedem | like horizon could have a window where you update the keypair on the instance and it asks you to reboot or rebuild the instance | 14:44 |
mriedem | you select one and horizon does the work of updating the keypair and rebuilding the instance | 14:45 |
Kevin_Zheng | mriedem: thanks I will check tomorrow, still have to work tomorrow T_T 4th Saturday every month | 14:45 |
mriedem | Kevin_Zheng: enjoy your time in the salt mines | 14:45 |
mriedem | i have to go to my daughter's gymnastics class in the morning, | 14:46 |
mriedem | we all have our burdens | 14:46 |
Kevin_Zheng | We will have a 8 day holiday though, starting from 1st Oct, nation day | 14:47 |
finucannot | ralonsoh__: One comment left on https://review.openstack.org/#/c/474892/ | 14:47 |
mriedem | Kevin_Zheng: you've got me beat there | 14:47 |
liuyulong | mriedem, your review comments also reminded me. If cloud-init does not running in every boot, the inconsistent can not be removed. To provent that, the entire cloud platform images need updating. | 14:49 |
*** slaweq_ has joined #openstack-nova | 14:49 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Add datapath type information to OVS vif objects https://review.openstack.org/474892 | 14:49 |
ralonsoh__ | finucannot: done! | 14:49 |
*** vks1 has joined #openstack-nova | 14:50 | |
finucannot | ralonsoh__: ...and done | 14:51 |
*** p01nt3r75 has joined #openstack-nova | 14:52 | |
*** penick has joined #openstack-nova | 14:53 | |
*** takashin has left #openstack-nova | 14:53 | |
mriedem | liuyulong: then you rebuild the instance | 14:54 |
liuyulong | And for the running instance. If user does not change the cloud-init config. They create image and then boot a new VM. New API can not avoid inconsistent in such situation ether. | 14:54 |
liuyulong | s/ether/either | 14:55 |
mriedem | liuyulong: if you boot a new vm, you're providing a new keypair anyway | 14:55 |
*** tidwellr has joined #openstack-nova | 14:55 | |
mriedem | the user does'nt change the cloud-init config, that's up to the deployer | 14:55 |
*** slaweq_ has quit IRC | 14:56 | |
liuyulong | ha, we are talking back to rebuild API again. | 14:56 |
mriedem | its very simple, if all you want to do is rebuild and have a new keypair, (1) update the keypair on the instance, (2) rebuild the instance | 14:57 |
*** creepy_owlet|brb is now known as creepy_owlet | 14:57 | |
mriedem | if (2) is something else, like cold migrate, unshelve, resize, reboot, then you can do that because of (1) | 14:57 |
liuyulong | What if cloud-init does not running in every boot ? | 14:57 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rename cellsv2_layout -> cellsv2-layout https://review.openstack.org/498821 | 14:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Cleanup of existing index pages https://review.openstack.org/498819 | 14:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP! doc: Add contents page https://review.openstack.org/498820 | 14:58 |
liuyulong | rebuild is something like `recreate`, the new VM disk cloud-init may not cache the old instance id. So it can be running. | 14:59 |
liuyulong | But booting actions like reboot, resize, unshelve do not have such situation. | 14:59 |
*** zzzeek has quit IRC | 15:00 | |
sdague | mriedem: https://review.openstack.org/#/c/454323/ has seen a lot of rechecks / rebases and the full stack testing is looking pretty solid | 15:00 |
sdague | that's the live snapshot by default | 15:00 |
*** cshen has quit IRC | 15:03 | |
*** zzzeek has joined #openstack-nova | 15:03 | |
mriedem | sdague: there is something new in there | 15:05 |
mriedem | unless i'm blind | 15:05 |
*** yamamoto has quit IRC | 15:06 | |
*** Apoorva has joined #openstack-nova | 15:06 | |
*** yamamoto has joined #openstack-nova | 15:06 | |
*** yamamoto has quit IRC | 15:07 | |
*** slaweq has quit IRC | 15:07 | |
*** yamamoto has joined #openstack-nova | 15:07 | |
liuyulong | Allow me to rephrase: And for the running instance. If user does not change the cloud-init config. They create image and then boot a new VM. Even the entire cloud platform images have been updated, new API can not avoid inconsistent for this new VM. | 15:08 |
*** Oku_OS is now known as Oku_OS-away | 15:09 | |
*** bigdogstl has joined #openstack-nova | 15:09 | |
*** tssurya has quit IRC | 15:11 | |
*** slaweq has joined #openstack-nova | 15:11 | |
openstackgerrit | konstantin proposed openstack/nova master: don't add device address if there is no any units https://review.openstack.org/506686 | 15:13 |
openstackgerrit | konstantin proposed openstack/nova master: switch from filesystem to disk for parallels containers https://review.openstack.org/506687 | 15:13 |
sdague | mriedem: there are test changes | 15:13 |
sdague | and there is the bit you changed in patch #2 | 15:13 |
mriedem | no, the PAUSED thing | 15:13 |
sdague | so PS #2 are your changes | 15:13 |
mriedem | i don't remember that | 15:14 |
*** bigdogstl has quit IRC | 15:14 | |
mriedem | you hacked my account back in april | 15:14 |
sdague | I can slice them out again | 15:14 |
mriedem | https://review.openstack.org/#/c/454323/1..2/nova/virt/libvirt/driver.py | 15:14 |
mriedem | wtf | 15:14 |
mriedem | it was probably needed for something | 15:14 |
*** slaweq has quit IRC | 15:16 | |
sdague | here is a version with that deleted back out | 15:16 |
openstackgerrit | Sean Dague proposed openstack/nova master: Change livesnapshot to true by default https://review.openstack.org/454323 | 15:16 |
mriedem | suspend does a managedSave | 15:16 |
mriedem | but pause doesn't | 15:17 |
sdague | I do think there is a state transition which is wrong in a tempest test | 15:17 |
sdague | ok | 15:17 |
sdague | well, I have to go do a preschool pickup, so ponder what's needed there, as you made that slice of changes :) | 15:17 |
*** ratailor has quit IRC | 15:18 | |
mriedem | yeah idk, don't get it, would probably have to see if tests fail, or ask kashyap | 15:19 |
mriedem | i think we have a tempest test that will snapshot a paused instance and it will fail, but we'll see | 15:20 |
mriedem | https://wiki.openstack.org/wiki/Kvm-Pause-Suspend | 15:20 |
mriedem | oops | 15:20 |
mriedem | test_create_image_from_paused_server | 15:20 |
mriedem | that's the one | 15:20 |
liuyulong | mriedem, sdague, Kevin_Zheng, so I hope that both spec can landed in queens cycle. I will continue to focus on these developments. Thank you guys. | 15:21 |
*** slaweq has joined #openstack-nova | 15:22 | |
*** yamamoto has quit IRC | 15:23 | |
*** artom has quit IRC | 15:25 | |
*** slaweq has quit IRC | 15:28 | |
*** liuyulong has quit IRC | 15:28 | |
*** chyka_ has joined #openstack-nova | 15:33 | |
*** coreywright has quit IRC | 15:34 | |
*** gyee has joined #openstack-nova | 15:36 | |
*** links has joined #openstack-nova | 15:36 | |
*** p01nt3r75 has quit IRC | 15:38 | |
*** vvargaszte has joined #openstack-nova | 15:39 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Remove 'vendordata_driver' opt https://review.openstack.org/397835 | 15:40 |
*** slaweq has joined #openstack-nova | 15:41 | |
mriedem | finucannot: drop the 'enough' in the release note there and i'm +2 | 15:43 |
*** cdent has quit IRC | 15:43 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Remove 'vendordata_driver' opt https://review.openstack.org/397835 | 15:44 |
finucannot | mriedem: done | 15:44 |
*** slaweq has quit IRC | 15:45 | |
mriedem | i take that back :) | 15:47 |
mriedem | comments inline | 15:47 |
mriedem | we need to talk to mikal | 15:47 |
mriedem | fine with the removal, but looks like we can remove that vddriver stuff and just default vendordata_providers to StaticJSON | 15:48 |
*** coreywright has joined #openstack-nova | 15:48 | |
*** yamahata has quit IRC | 15:50 | |
*** kenperkins has joined #openstack-nova | 15:52 | |
*** vvargaszte has quit IRC | 15:53 | |
*** slaweq has joined #openstack-nova | 15:55 | |
*** slaweq has quit IRC | 15:56 | |
*** slaweq has joined #openstack-nova | 15:56 | |
*** MikeW has joined #openstack-nova | 15:58 | |
finucannot | mriedem: That's fair. Let's wait and see what mikal comes back with | 15:59 |
*** jmlowe has quit IRC | 15:59 | |
* finucannot goes to find a pub. It's actually sunny | 16:00 | |
MikeW | Hey can you guys help me figure out where this nova error is coming from? It only happens when I use an ephemeral based flavor (ceph is my backend): https://pastebin.com/C5Ra74Wi | 16:00 |
MikeW | I'm not an amazing programmer and dug into those python files and couldn't see what was really going on | 16:01 |
*** ralonsoh__ has quit IRC | 16:02 | |
*** bnemec is now known as beekneemech | 16:03 | |
*** sbezverk has quit IRC | 16:03 | |
*** slaweq has quit IRC | 16:13 | |
openstackgerrit | Ed Leafe proposed openstack/nova master: Add alternate hosts https://review.openstack.org/486215 | 16:13 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | 16:13 |
figleaf | superdan: leakypipes: ^^ updated | 16:13 |
*** slaweq has joined #openstack-nova | 16:14 | |
leakypipes | kk | 16:14 |
figleaf | note that tests will fail; didn't update them pending further changes | 16:14 |
openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Spec for flavor description https://review.openstack.org/501017 | 16:14 |
*** armax has quit IRC | 16:16 | |
*** Tom___ has joined #openstack-nova | 16:19 | |
*** igordc has quit IRC | 16:19 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Move allocation manipulation out of drop_move_claim() https://review.openstack.org/498947 | 16:21 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make allocation cleanup honor new by-migration rules https://review.openstack.org/498948 | 16:21 |
openstackgerrit | Dan Smith proposed openstack/nova master: Pre-create migration object https://review.openstack.org/498950 | 16:21 |
openstackgerrit | Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949 | 16:21 |
openstackgerrit | Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419 | 16:21 |
openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420 | 16:21 |
*** links has quit IRC | 16:21 | |
superdan | leakypipes: I think these earlier patches are starting to converge on decent ^.. I won't mind if we pin the first one until the later one is done, but would appreciate an early spin through the set to make sure it makes sense to you | 16:21 |
leakypipes | superdan: will do :) | 16:22 |
*** psachin has joined #openstack-nova | 16:23 | |
*** yamamoto has joined #openstack-nova | 16:23 | |
*** yamahata has joined #openstack-nova | 16:23 | |
openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/506640 | 16:24 |
*** Tom___ has quit IRC | 16:24 | |
*** vks1 has quit IRC | 16:26 | |
openstackgerrit | Merged openstack/nova master: docs: Rename cellsv2_layout -> cellsv2-layout https://review.openstack.org/498821 | 16:28 |
*** yamamoto has quit IRC | 16:30 | |
*** bigdogstl has joined #openstack-nova | 16:31 | |
mriedem | superdan: on that note, i've got the unshelve fail allocation test and fix lined up here https://review.openstack.org/#/c/506458/ | 16:35 |
mriedem | which will get backported | 16:35 |
mriedem | still need to do one for bug 1715182 | 16:35 |
openstack | bug 1715182 in OpenStack Compute (nova) pike "_rollback_live_migration does not remove allocations from destination node" [High,Triaged] https://launchpad.net/bugs/1715182 | 16:35 |
*** bigdogstl has quit IRC | 16:35 | |
openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | 16:35 |
superdan | mriedem: okay | 16:37 |
sdague | mriedem: ok, fixing the release notes. I suppose I should probably take your fix in as a dedicated fix up front? | 16:37 |
mriedem | sdague: idk, did that tempest test fail? | 16:38 |
sdague | mriedem: I guess it didn't | 16:39 |
sdague | I'll let the current round of tests pass, then push the reno fix | 16:39 |
sdague | then we've got more passing tests on things | 16:39 |
superdan | figleaf: does the late call of _get_sorted_hosts() give us a new set of hosts that haven't been claimed in the first loop? | 16:41 |
superdan | that must be right | 16:44 |
mriedem | leakypipes: i think this is fine, but wanted you to take a look since i know you fixed a bug with bad performance on loading instance faults at one point https://review.openstack.org/#/c/505391/ | 16:45 |
mriedem | in the instance_fault_get_by_instance_uuids method that is | 16:45 |
*** jpena is now known as jpena|off | 16:46 | |
*** Yikun__ has joined #openstack-nova | 16:47 | |
*** slaweq has quit IRC | 16:47 | |
*** slaweq has joined #openstack-nova | 16:47 | |
superdan | mriedem: I use the thing leakypipes added which gets just the latest fault | 16:48 |
mriedem | yeah i know | 16:48 |
superdan | for each instance in a list | 16:48 |
superdan | okay | 16:48 |
mriedem | just remembered it being a thing once | 16:48 |
leakypipes | looking now. | 16:51 |
*** kenperkins has quit IRC | 16:51 | |
superdan | mriedem: leakypipes: note that right now we're getting instance faults either one by one, or later from the api if it does a fill_faults on the InstanceList | 16:52 |
superdan | this is really just doing the latter from the lower layer if it was requested | 16:53 |
superdan | fill_faults from the api the way it is today won't work because it doesn't know about things in different cells | 16:53 |
superdan | which is a bug in pike I guess, but fixing it would not be super easy | 16:53 |
mriedem | hmm, probably worth at least reporting that so we know about it | 16:54 |
mriedem | could also doc as a known issue if nothing else | 16:54 |
mriedem | *always | 16:54 |
mriedem | shite, lunch tie | 16:54 |
mriedem | *time | 16:54 |
superdan | lemme see if I can write a test to poke that | 16:54 |
*** zzzeek has quit IRC | 16:59 | |
figleaf | superdan: the claimed hosts will still be in the list unless a filter tosses them. Since we aren't using resource filters, it's not likely that it would be removed from the list of hosts, but the sorting for alternates will certainly change | 17:00 |
*** zzzeek has joined #openstack-nova | 17:00 | |
superdan | figleaf: okay, but would it remove hosts that no longer fit after the primary consume operation was made? | 17:01 |
superdan | figleaf: meaning if we choose an almost-full host as a primary for one instance and consume_from_instance it or whatever, is it no longer a candidate for the last loop at the bottom to look for alternates? | 17:02 |
figleaf | superdan: depends on the weighers used, right? E.g., pack-vs-spread | 17:02 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: [WIP] Add ability for OVMF Secure Boot https://review.openstack.org/506720 | 17:03 |
figleaf | superdan: it won't get removed, since resource constraints are handled in the placement call | 17:03 |
superdan | figleaf: well I meant if we consumed some resource, but I guess we don't have things like RamFilter in there by default anymore, so this just randomizes the result (if configured) and could hit all the same ones | 17:03 |
superdan | yeah | 17:03 |
*** armax has joined #openstack-nova | 17:04 | |
*** bigdogstl has joined #openstack-nova | 17:04 | |
superdan | hrm. seems like we're asking for trouble there | 17:04 |
*** penick_ has joined #openstack-nova | 17:04 | |
figleaf | superdan: well, none of the claimed hosts will be added as alternates | 17:04 |
leakypipes | superdan: did you catch my request on the previous revision of your drop_allocation_for_move() patch about not using the internal RT compute_nodes dict data? | 17:05 |
superdan | figleaf: that's what I was just asking.. what prevents that? | 17:05 |
superdan | leakypipes: apparently not | 17:05 |
*** slaweq has quit IRC | 17:05 | |
*** penick has quit IRC | 17:05 | |
figleaf | superdan: Line 285: if host.cell_uuid == cell_uuid and host not in claimed_hosts: | 17:05 |
*** slaweq has joined #openstack-nova | 17:05 | |
superdan | figleaf: heh, oh.. THAT | 17:06 |
superdan | I just saw the cell check and short-circuited the rest of the line | 17:06 |
figleaf | superdan: I can switch the order of that line if it helps :) | 17:06 |
superdan | no | 17:06 |
*** cfriesen has quit IRC | 17:07 | |
*** edmondsw has quit IRC | 17:08 | |
leakypipes | superdan: added some more info to the latest rev | 17:09 |
superdan | leakypipes: okay | 17:09 |
superdan | thanks | 17:09 |
*** edmondsw has joined #openstack-nova | 17:11 | |
*** slaweq has quit IRC | 17:11 | |
*** Swami has joined #openstack-nova | 17:14 | |
jose-phillips | d | 17:15 |
*** bigdogstl has quit IRC | 17:15 | |
*** edmondsw has quit IRC | 17:16 | |
*** bigdogstl has joined #openstack-nova | 17:16 | |
*** cfriesen has joined #openstack-nova | 17:18 | |
*** esberglu has quit IRC | 17:20 | |
*** Sukhdev_ has joined #openstack-nova | 17:20 | |
*** esberglu has joined #openstack-nova | 17:20 | |
superdan | mriedem: oh, no it'll work because if we fail to fill, we go one by one and grab the fault, targeted to the cell | 17:21 |
superdan | which is terribad, but it'll work | 17:21 |
*** avolkov has quit IRC | 17:21 | |
*** hoonetorg has quit IRC | 17:22 | |
*** itlinux has joined #openstack-nova | 17:22 | |
*** cfriesen_ has joined #openstack-nova | 17:23 | |
*** cfriesen has quit IRC | 17:23 | |
*** esberglu has quit IRC | 17:25 | |
*** creepy_owlet is now known as dtantsur|afk | 17:25 | |
*** mvk has quit IRC | 17:25 | |
openstackgerrit | Sean Dague proposed openstack/nova master: Change livesnapshot to true by default https://review.openstack.org/454323 | 17:25 |
*** cfriesen_ is now known as cfriesen | 17:29 | |
*** bigdogstl has quit IRC | 17:30 | |
*** rtjure has quit IRC | 17:31 | |
*** slaweq has joined #openstack-nova | 17:32 | |
figleaf | leakypipes: it's not just tests that use dicts from _schedule_instances: https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L572-L573 | 17:33 |
* figleaf sighs | 17:33 | |
*** bigdogstl has joined #openstack-nova | 17:33 | |
*** esberglu has joined #openstack-nova | 17:33 | |
leakypipes | figleaf: removing that code block successfully identifies the culprits though, no? :) | 17:34 |
*** rtjure has joined #openstack-nova | 17:34 | |
*** esberglu has quit IRC | 17:34 | |
*** mingyu has quit IRC | 17:34 | |
figleaf | leakypipes: yeah, but it means changing it here, and then in a later patch, changing it again to use Selection objects. | 17:35 |
openstackgerrit | Dan Smith proposed openstack/nova master: Move allocation manipulation out of drop_move_claim() https://review.openstack.org/498947 | 17:35 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make allocation cleanup honor new by-migration rules https://review.openstack.org/498948 | 17:35 |
openstackgerrit | Dan Smith proposed openstack/nova master: Pre-create migration object https://review.openstack.org/498950 | 17:35 |
openstackgerrit | Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949 | 17:35 |
openstackgerrit | Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419 | 17:35 |
openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420 | 17:35 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add get_node_uuid() helper to ResourceTracker https://review.openstack.org/506730 | 17:35 |
figleaf | leakypipes: So what if we leave this, knowing that it will be removed in a later patch? | 17:35 |
figleaf | this == host state dicts | 17:35 |
leakypipes | figleaf: that's cool with me. just make a note to address in a later patch is fine. | 17:35 |
*** felipemonteiro_ has quit IRC | 17:35 | |
*** hoonetorg has joined #openstack-nova | 17:35 | |
*** felipemonteiro__ has joined #openstack-nova | 17:36 | |
openstackgerrit | Merged openstack/nova master: Fix 500 if list servers called with empty regex pattern https://review.openstack.org/506585 | 17:36 |
figleaf | leakypipes: okie dokie | 17:36 |
*** slaweq has quit IRC | 17:37 | |
*** felipemonteiro_ has joined #openstack-nova | 17:37 | |
*** esberglu has joined #openstack-nova | 17:37 | |
superdan | figleaf: leakypipes: best way to do that is throw a patch up with the removal at the end | 17:38 |
superdan | clearly broken, but a tombstone reminder :) | 17:38 |
*** bamsetts is now known as sambetts|afk | 17:38 | |
leakypipes | superdan: yep | 17:38 |
*** bigdogstl has quit IRC | 17:38 | |
superdan | otherwise I doubt we'll come back to it | 17:38 |
*** esberglu has quit IRC | 17:39 | |
*** esberglu has joined #openstack-nova | 17:40 | |
*** itlinux has quit IRC | 17:40 | |
*** ioggstream has quit IRC | 17:41 | |
*** felipemonteiro__ has quit IRC | 17:41 | |
figleaf | superdan: not sure that's necessary, since we'll be changing the return value from a host (dict or HostState) to a Selection object. All the code that touches select_destinations() will be affected | 17:43 |
*** bigdogstl has joined #openstack-nova | 17:43 | |
*** edmondsw has joined #openstack-nova | 17:44 | |
superdan | figleaf: okay I guess I thought this was in the middle before the point at which we'd be forming out Selection objects | 17:45 |
superdan | I misread your "knowing it will be removed in a later patch" as "I'll clean it up later" | 17:45 |
sdague | mriedem: ok, the qemu patch, who else should take a look at it - https://review.openstack.org/#/c/505673/ ? | 17:46 |
figleaf | superdan: this was a small change to accomodate a list of objects instead of a single, because alternates | 17:46 |
sdague | as it would be good to unblock new qemu | 17:46 |
figleaf | later will be a list of Selection | 17:46 |
*** edmondsw has quit IRC | 17:47 | |
*** edmondsw has joined #openstack-nova | 17:47 | |
*** slaweq has joined #openstack-nova | 17:53 | |
superdan | leakypipes: just a +W needed on a test add: https://review.openstack.org/#/c/505392/7 | 17:57 |
*** slaweq has quit IRC | 17:57 | |
openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/457711 | 17:57 |
*** ijw has joined #openstack-nova | 17:58 | |
*** tesseract has quit IRC | 17:59 | |
*** bigdogstl has quit IRC | 17:59 | |
*** felipemonteiro_ has quit IRC | 18:02 | |
*** felipemonteiro_ has joined #openstack-nova | 18:02 | |
*** ijw has quit IRC | 18:03 | |
*** gbarros has joined #openstack-nova | 18:10 | |
*** hongbin has quit IRC | 18:11 | |
*** tidwellr has quit IRC | 18:16 | |
*** ijw has joined #openstack-nova | 18:16 | |
*** gszasz has quit IRC | 18:17 | |
*** jmlowe has joined #openstack-nova | 18:18 | |
*** ijw has quit IRC | 18:21 | |
*** Sree has joined #openstack-nova | 18:21 | |
*** jmlowe has quit IRC | 18:22 | |
sdague | cburgess: responded on https://review.openstack.org/#/c/505673 | 18:22 |
*** felipemonteiro__ has joined #openstack-nova | 18:22 | |
leakypipes | superdan: done | 18:22 |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: set/check if inventory change in tree https://review.openstack.org/470575 | 18:23 |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: integrate ProviderTree to report client https://review.openstack.org/415921 | 18:23 |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138 | 18:23 |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215 | 18:23 |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 18:23 |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 18:23 |
*** felipemonteiro_ has quit IRC | 18:25 | |
*** Sree has quit IRC | 18:25 | |
*** jmlowe has joined #openstack-nova | 18:26 | |
*** mvk has joined #openstack-nova | 18:33 | |
*** mnestratov has quit IRC | 18:35 | |
*** mingyu has joined #openstack-nova | 18:35 | |
cburgess | sdague Re-responded | 18:36 |
sdague | cburgess: you all really mix / match qemu runtime and tooling versions? | 18:37 |
sdague | Because that kind of seems dangerous | 18:37 |
cburgess | In the past yes. | 18:37 |
cburgess | sdague Used to be required to support qemu upgrades and live migration cross versions. In theory we now claim its simply Red Hat's problem. | 18:37 |
cburgess | sdague I'm not saying its even a reasonable thing to do anymore. I'm simply pointing out that we are assuming something there that might not be obvious to some folks. | 18:38 |
sdague | cburgess: what was the sequence of changing things you would do there? | 18:38 |
cburgess | sdague Test the version directly.. not just ask libvirt the emulate version (assuming there is some kind of --version arguement to qemu-img). | 18:39 |
sdague | cburgess: there is, but then you are text parsing vs. getting a binary number, which is a lot less robust | 18:40 |
*** ijw has joined #openstack-nova | 18:40 | |
cburgess | sdague Maybe we should need a comment above that block of code that outlines our assumption. | 18:40 |
*** mingyu has quit IRC | 18:40 | |
sdague | cburgess: I don't mean for this fix, I mean, lets pretend you had a 2.8 based environment, and you wanted to live migrate to a 2.10 one | 18:40 |
sdague | what was the series of steps metacloud would do to dot hat | 18:40 |
cburgess | sdague Oh you mean how did we handle this in the past? | 18:40 |
sdague | yes | 18:40 |
openstackgerrit | Merged openstack/nova master: Add fault-filling into instance_get_all_by_filters_sort() https://review.openstack.org/505391 | 18:41 |
*** ivve has quit IRC | 18:42 | |
*** lbragstad has joined #openstack-nova | 18:42 | |
openstackgerrit | Merged openstack/nova master: Add a regression test for bug 1718455 https://review.openstack.org/506092 | 18:43 |
openstack | bug 1718455 in OpenStack Compute (nova) "[pike] Nova host disable and Live Migrate all instances fail." [Medium,In progress] https://launchpad.net/bugs/1718455 - Assigned to Matt Riedemann (mriedem) | 18:43 |
cburgess | sdague QEMU was installed in /opt/qemu/version_numer, We had a wrapper script that lived at /usr/sbin that libvirt would find. When libvirt propped it, it would report its latest version. When it was used to launch a VM it would look at various CLI flags to determine the original version that was used to launch that VM (in the case of an incoming live migration) and launch the original version of the emulator to ensure compat. | 18:44 |
*** tbachman has quit IRC | 18:45 | |
sdague | cburgess: and qemu-img was at what version? | 18:45 |
sdague | because that's in the $PATH so you do only get one there | 18:46 |
cburgess | sdague qemu-img was always the latest. along with the proped version from libvirt. In our case this assumption is fine. I'm not saying we (Metacloud) need this. I'm just pointing out that there is an implied assumption here. | 18:46 |
sdague | assuming you had 2.6, 2.8, 2.10 installed | 18:46 |
sdague | qemu-img was 2.10 | 18:46 |
cburgess | Correct | 18:47 |
sdague | and if you queried libvirt it generically it told you 2.10 | 18:47 |
sdague | ? | 18:47 |
sdague | but it would do magic for guests that had been booted with old versions? | 18:47 |
cburgess | Correct | 18:47 |
cburgess | To all of the above. | 18:47 |
sdague | ok, in which case, this code would totally work for you | 18:47 |
mriedem | i think it's a pretty safe assumption. i think most of the code assumes that anything we do with qemu on the host is the same version that libvirt is using. | 18:47 |
sdague | and, honestly, anything more esoteric than what you are doing I would expect people to have to hack the code | 18:48 |
sdague | s/are/were/ | 18:48 |
sdague | I want to be careful here making the main path potentially more fragile for an edge world that we aren't really sure exists anywhere | 18:49 |
cburgess | OK | 18:49 |
*** kukacz_ is now known as kukacz | 18:49 | |
cburgess | Just felt... wrong. | 18:49 |
sdague | cburgess: I did have a pause until I looked up that qemu-img and qemu come from the same source tarball | 18:50 |
sdague | in which case I'm not going to assume you can mix / match | 18:50 |
cburgess | You can.. | 18:50 |
cburgess | Its perfectly legal to do so. | 18:50 |
cburgess | It just happens to come in the same source build. | 18:51 |
sdague | the qemu team tells you you can? | 18:51 |
cburgess | Well legal-ish. | 18:51 |
sdague | and that they'll support it? | 18:51 |
sdague | like "it didn't blow up for us" | 18:51 |
cburgess | This is the first time I'm aware of a flag like this that requires synced version. | 18:51 |
sdague | is not the same as upstream supported | 18:51 |
sdague | cburgess: sure, that caught us off guard for sure | 18:51 |
cburgess | sdague I don't know what the "official" support policy is from upstream. | 18:52 |
cburgess | sdague I only know what the "make it work" policy is. :P | 18:52 |
sdague | if you find a piece of evidence that the qemu team says "+1 we support mix and match" I'd change my tune :) | 18:52 |
openstackgerrit | Merged openstack/nova master: Remove method "_get_host_ref_from_name" https://review.openstack.org/504796 | 18:52 |
sdague | but until then, this is pretty robust version detection, a lot more than parsing strings of stderr | 18:52 |
openstackgerrit | Merged openstack/nova master: enhance api-ref for os-server-external-events https://review.openstack.org/504263 | 18:53 |
sdague | and we could always change it later if people really needed the mix & match | 18:53 |
sdague | and came forward | 18:53 |
cburgess | sdague I removed my objection. | 18:54 |
sdague | cburgess: while you are at terminal - https://review.openstack.org/#/c/454323/ - live snapshot by default | 18:54 |
sdague | cburgess: cool | 18:54 |
mriedem | we could parse the error and retry the command with the new flag, but... | 18:54 |
mriedem | error message parsing isn't fun either | 18:54 |
sdague | mriedem: yeh | 18:54 |
cburgess | I agree... its ugly. | 18:54 |
sdague | and given that we got a new required flag we were not expecting, I'm really wary of considering error messages or even version string dumps contract | 18:55 |
cburgess | sdague Yeah so to be clear.. we never deployed libvirt 1.2.2 because it was bad. We just skipped that version which is why we never hit that live snapshot bug. But yeah we have run with it since we merged the code upstream. | 18:55 |
sdague | cburgess: ok, cool | 18:56 |
*** hongbin has joined #openstack-nova | 18:56 | |
cburgess | sdague rmk added that code... umm... 4 or 5 years ago and we have been running with it enabled ever since. | 18:56 |
*** pcaruana has quit IRC | 18:56 | |
sdague | cburgess: yeh, I knew you all had been using that for a long time, I just realized at PTG we hadn't come around and flipped that back since getting past 1.2.2 | 18:57 |
cburgess | sdague cool.. its +1 from me. | 18:58 |
mriedem | leakypipes: superdan: https://review.openstack.org/#/c/505417/6 | 19:00 |
sdague | for the land of fun... qemu-img --version | head -1 on centos7, ubuntu 16.04, ubuntu 17.04 | 19:00 |
sdague | qemu-img version 1.5.3, Copyright (c) 2004-2008 Fabrice Bellard | 19:00 |
*** bigdogstl has joined #openstack-nova | 19:00 | |
sdague | qemu-img version 2.5.0 (Debian 1:2.5+dfsg-5ubuntu10.16), Copyright (c) 2004-2008 Fabrice Bellard | 19:00 |
sdague | qemu-img version 2.8.0(Debian 1:2.8+dfsg-3ubuntu2.4) | 19:00 |
cburgess | Yeah you will break RHEL with that change. | 19:00 |
*** READ10 has quit IRC | 19:00 | |
cburgess | Forgot to mention that. | 19:00 |
sdague | cburgess: why? | 19:00 |
cburgess | sdague Opps yeah just realized I was wrong. We don't block on 2.10 now.. we just change the args. My bad. | 19:01 |
sdague | cburgess: right | 19:01 |
cburgess | sdague Ignore me. | 19:01 |
sdague | with 2.10 right now you just explode in a ball of fire | 19:01 |
sdague | which is what the gate did | 19:01 |
cburgess | sdague LOL | 19:01 |
sdague | because the ppa for pike has 2.10 | 19:01 |
cburgess | sdague qemu-img barfs back an error at you I assume? | 19:01 |
sdague | yeh | 19:01 |
sdague | which is a stack trace | 19:02 |
cburgess | Yeah... cute. | 19:02 |
mriedem | so uh, no group rates in sydney huh? | 19:02 |
sdague | cburgess: qemu actually just gives a clean exit, but it's definitely not expected by nova code, so nova code stack traces | 19:03 |
superdan | mriedem: ack on all thanks | 19:03 |
mriedem | \o/ | 19:03 |
cburgess | sdague Also depends on which version of RHEL 7 you are on. I believe later versions of RHEL, or the OSP repos include newer versions of QEMU. On 7.4 for instance we have 2.6 | 19:03 |
superdan | mriedem: I wonder if we don't have a thing that actually tests server['fault'] from the api? | 19:03 |
sdague | cburgess: ah, yeh with OSP it might be different. I just have a centos 7 vanilla install | 19:03 |
mriedem | superdan: i'd expect a functional test somewhere, | 19:04 |
superdan | I would have thought | 19:04 |
mriedem | superdan: fault testing is weird since the instance has to be deleted or in error state | 19:04 |
mriedem | always trips me up | 19:04 |
cburgess | sdague yeah there are various additional repos you get access to with OSP. | 19:04 |
superdan | mriedem: um, what? | 19:04 |
superdan | oh for the api to show it? | 19:04 |
superdan | I see | 19:04 |
mriedem | yeah, | 19:04 |
mriedem | like these failure recreate tests we do, | 19:04 |
superdan | like your cell0 test, you could just boot things what will never schedule | 19:04 |
mriedem | i'm always wanting to just poll until the fault shows up, but most of the time that won't work | 19:04 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Fix 500 if list servers called with empty regex pattern https://review.openstack.org/506754 | 19:05 |
superdan | mriedem: gotcha | 19:05 |
mriedem | so i've become astute and the instance actions api | 19:05 |
*** Yikun__ has quit IRC | 19:06 | |
*** bigdogstl has quit IRC | 19:07 | |
superdan | mriedem: the args to that function aren't kwargs | 19:08 |
superdan | I can call them that way for reference, but it's wrong | 19:08 |
mriedem | i know they aren't kwargs | 19:08 |
superdan | can I comment? | 19:08 |
mriedem | but you could have some variables in the test instead or something, like you did elsewhere | 19:08 |
mriedem | i just hate having to remember what None, None, {}, None, [], [], None means | 19:09 |
superdan | yep, I can do that | 19:09 |
superdan | mriedem: I'm not seeing a functional test that actually checks fault | 19:10 |
superdan | you know we have one somewhere? | 19:10 |
*** gbarros has quit IRC | 19:10 | |
mriedem | superdan: i don't | 19:10 |
mriedem | w/o searching | 19:10 |
superdan | okay | 19:10 |
mriedem | gd these sydney hotel rates | 19:10 |
*** weshay is now known as weshay_bbiab | 19:15 | |
stvnoyes | mriedem: going thru your review ccomments on live migrate/v3 - https://review.openstack.org/#/c/463987/18/nova/virt/libvirt/driver.py line 7077. | 19:15 |
stvnoyes | init connection should be done for the new flow so that is a problem that needs to be fixed | 19:16 |
stvnoyes | 2 ways to do it, leave libvirt driver as it was and it will get done for both new and old flows or | 19:17 |
stvnoyes | init_connection is already being done during pre_live_migrate but the updated bdm is not saved. If we make a change to save it during pre, it will be updated. | 19:18 |
stvnoyes | then it will be available on the source node | 19:18 |
stvnoyes | i like that better as then we can remove code from libvirt driver and I noticed that the xen driver doesn't do an init connection so this would fix that too. | 19:19 |
mriedem | so post_live_migration is on the source node, and init_connection is called to get the connection_info to disconnect from the source host | 19:22 |
stvnoyes | yes | 19:22 |
mriedem | pre_live_migration runs on the dest node, let me see what you're doing there | 19:23 |
stvnoyes | the bdm update is buried - _get_instance_block_device_info > driver_block_device.refresh_conn_infos > device.refresh_connection_info | 19:24 |
mriedem | hmm, the driver.pre_live_migration is what connects the volume on the dest host, but where do we call attachment_update? | 19:24 |
mriedem | oh right i commented on that too | 19:24 |
stvnoyes | very not crazy about all this stuff happening down under a get method | 19:25 |
mriedem | yeah | 19:25 |
mriedem | me neither | 19:25 |
mriedem | ok so https://review.openstack.org/#/c/463987/18/nova/compute/manager.py@5431 is what would eventually update the attachment with the host connector on the dest host | 19:25 |
mriedem | and then we call self.driver.pre_live_migration to connect the volume on the dest host | 19:25 |
mriedem | and then volume_api.attachment_complete to finalize on the dest | 19:26 |
*** crushil has quit IRC | 19:27 | |
mriedem | so this is where we have the updated bdm on the dest during pre_live_migration right? https://review.openstack.org/#/c/463987/18/nova/virt/libvirt/driver.py@6908 | 19:27 |
stvnoyes | I think the issue is that init_connection on the dest does not persist the new info to the db. so the source still has the stale info | 19:27 |
*** crushil has joined #openstack-nova | 19:27 | |
*** lbragstad has quit IRC | 19:27 | |
mriedem | stvnoyes: not in the nova db, but i think that's the idea, | 19:27 |
mriedem | attachment_update for the new attachment on the dest host passes the dest host connector, | 19:27 |
mriedem | and cinder stores the connection info in the cinder db | 19:27 |
stvnoyes | right. I was thinking that if we did a bdm.save() on the destination after getting the update, when the source later pulls the bdm from the db, the connector info would be up to date | 19:28 |
mriedem | that's why i said in https://review.openstack.org/#/c/463987/18/nova/virt/libvirt/driver.py@7077 can't we just get the attachment record from cinder? | 19:28 |
mriedem | if we update the bdm connection_info during pre_live_migration, it's pointing at the dest host, so anything that relies on that on the source host could get mixed up | 19:28 |
mriedem | although i'm not sure we use the bdm connection_info on the source host after pre_live_migration do we? | 19:29 |
mriedem | maybe on rollback | 19:29 |
openstackgerrit | Elod Illes proposed openstack/nova master: Add error notification for instance.interface_attach https://review.openstack.org/506643 | 19:29 |
mriedem | stvnoyes: i think the best thing for us to do is let cinder store the connection_info per attachment | 19:30 |
mriedem | and for the new flow, we just pull that from cinder when we need it | 19:30 |
mriedem | using the attachment_id | 19:30 |
mriedem | let's keep the nova bdm out of it | 19:31 |
stvnoyes | ok, I like that. | 19:31 |
mriedem | that was one of the main things jgriffith was shooting for anyway | 19:31 |
stvnoyes | thanks | 19:31 |
mriedem | when we started this like a year ago :) | 19:31 |
melwitt | superdan, mriedem: there's some instance fault testing stuff in nova/tests/functional/test_server_group.py | 19:31 |
mriedem | stvnoyes: so for your patch, i think that post_live_migration thing in the driver was my main hangup, otherwise there were just a couple of other small things | 19:31 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Fix 500 if list servers called with empty regex pattern https://review.openstack.org/506760 | 19:32 |
stvnoyes | I've fixed most of them. After this part goes in, then just lots of testing before I update | 19:32 |
superdan | melwitt: okay that might not have found this because it was a show not a list | 19:34 |
stvnoyes | mriedem: btw, I don't see an init connection in xen driver's post_live_migrate. Is that a problem? (not for this rv) | 19:34 |
*** Sukhdev has joined #openstack-nova | 19:35 | |
mriedem | stvnoyes: not sure, i'm not even sure how this is not failing.. | 19:35 |
jgriffith | mriedem you just made my week!!! "mriedem:that was one of the main things jgriffith was shooting for anyway" | 19:35 |
mriedem | <3 | 19:36 |
*** slaweq has joined #openstack-nova | 19:36 | |
*** tidwellr has joined #openstack-nova | 19:39 | |
*** slaweq has quit IRC | 19:40 | |
*** Sukhdev has quit IRC | 19:40 | |
mriedem | stvnoyes: re the xen driver, it doesn't do the volume connect/disconnect like the libvirt driver, so i can't really say | 19:40 |
mriedem | we would need the xen driver team to take a look at it again and test things out | 19:40 |
stvnoyes | ok | 19:41 |
mriedem | that would be jianghua wang | 19:41 |
*** crushil has quit IRC | 19:41 | |
mriedem | heh, actually, they said in july: | 19:42 |
mriedem | "The connection_info from bdm works well for XenAPI both in v2 and v3.27. It'd be good if someone can help us to understand why libvirt needs initialize_connection." | 19:42 |
mriedem | :) | 19:42 |
mriedem | ah that's why this works | 19:42 |
mriedem | "Per the commit message from the following commit, the connection_info from DBM is for destination. So if the connection info for source side is different from destination, it will have problem. That's why libvirt changed to use initialize_connection. https://github.com/openstack/nova/commit/8b649aa86fb26e998d66e75e5cebfd19c396942d" | 19:42 |
mriedem | so apparently the bdm.connection_info is already getting updated with the dest host connection_info | 19:43 |
mriedem | nvm, that doesn't explain why your change isn't failing when we disconnect on the source host | 19:44 |
mriedem | let's just be safe and pull that thing out of cinder if we're new flow, we know it's there, and we have the attachment_id to get it via the migrate_data object | 19:44 |
stvnoyes | kk | 19:47 |
*** chyka_ has quit IRC | 19:48 | |
*** chyka has joined #openstack-nova | 19:49 | |
*** hongbin_ has joined #openstack-nova | 19:55 | |
*** hongbin has quit IRC | 19:56 | |
openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs to Instance object https://review.openstack.org/489408 | 20:00 |
openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certificates to REST API https://review.openstack.org/486204 | 20:00 |
*** annegentle has joined #openstack-nova | 20:02 | |
*** sahid has quit IRC | 20:07 | |
openstackgerrit | Merged openstack/nova master: Add tests to validate instance_list handles faults correctly https://review.openstack.org/505392 | 20:09 |
*** slaweq has joined #openstack-nova | 20:12 | |
*** armax has quit IRC | 20:12 | |
*** jpena|off has quit IRC | 20:14 | |
*** slaweq has quit IRC | 20:16 | |
*** ltomasbo has quit IRC | 20:18 | |
*** ltomasbo has joined #openstack-nova | 20:19 | |
*** jpena|off has joined #openstack-nova | 20:19 | |
*** artom has joined #openstack-nova | 20:28 | |
*** artom has quit IRC | 20:28 | |
*** artom has joined #openstack-nova | 20:29 | |
*** Sukhdev_ has quit IRC | 20:30 | |
mriedem | sdague: one sort of weird thing in the live snapshot patch https://review.openstack.org/#/c/454323/ | 20:30 |
mriedem | the config option help talks about libvirt 1.2.2, | 20:31 |
mriedem | but we've required at least 1.2.9 since pike | 20:31 |
sdague | mriedem: right, which is under our minimum | 20:31 |
sdague | yeh, honestly, I don't know if other libvirt versions will experience the same issue | 20:31 |
*** hongbin_ has quit IRC | 20:31 | |
mriedem | right we test against 2.5.0 right now | 20:31 |
sdague | yeh | 20:31 |
sdague | so we could also deprecate the option, I would honestly do that as a follow on from the default change under the assumption that we don't see the issue show up again | 20:32 |
*** dave-mccowan has quit IRC | 20:32 | |
sdague | it would be nice to have a month of burn in data on that | 20:32 |
*** hongbin has joined #openstack-nova | 20:32 | |
mriedem | we'll be using 3.6.0 if/when we switch to pike uca | 20:32 |
cburgess | Or a release. | 20:33 |
mriedem | ok so that was my question, if we also deprecate | 20:33 |
mriedem | i'm ok with doing it in a separate change | 20:33 |
*** Tom has joined #openstack-nova | 20:36 | |
*** hongbin_ has joined #openstack-nova | 20:36 | |
*** hongbin has quit IRC | 20:38 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: fix nova accepting invalid availability zone name with ':' https://review.openstack.org/490722 | 20:39 |
*** Tom has quit IRC | 20:40 | |
sdague | yeh, that would make me more comfortable to know that all this was going to work for reals for a while | 20:42 |
*** bigdogstl has joined #openstack-nova | 20:42 | |
sdague | it took us a while to see the fail pattern before | 20:42 |
sdague | and while the 10 rechecks seem fine, stuff emerges | 20:42 |
*** annegentle has quit IRC | 20:44 | |
*** mnestratov has joined #openstack-nova | 20:46 | |
*** mnestratov has quit IRC | 20:47 | |
*** bigdogstl has quit IRC | 20:47 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional migrate force_complete test https://review.openstack.org/496202 | 20:48 |
*** tidwellr has quit IRC | 20:49 | |
*** alezil has quit IRC | 20:51 | |
mriedem | anyone noticed an annoying quirk with new gerrit where commenting lower in a file jumps you back up to a previous comment or something higher up? | 20:52 |
mriedem | i swear i had to fix this somehow 2 years ago with the last major upgrade | 20:53 |
*** vvargaszte has joined #openstack-nova | 20:54 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Add get_instance_objects_sorted() https://review.openstack.org/505417 | 20:56 |
openstackgerrit | Dan Smith proposed openstack/nova master: Copy some tests to a cellsv1 mixin https://review.openstack.org/505442 | 20:56 |
openstackgerrit | Dan Smith proposed openstack/nova master: Fix a pagination logic bug in test_bug_1689692 https://review.openstack.org/505661 | 20:56 |
openstackgerrit | Dan Smith proposed openstack/nova master: Use improved instance_list module in compute API https://review.openstack.org/505418 | 20:56 |
openstackgerrit | Dan Smith proposed openstack/nova master: Remove legacy fault-loading routines https://review.openstack.org/505456 | 20:56 |
openstackgerrit | Dan Smith proposed openstack/nova master: Fix CellDatabases fixture swallowing exceptions https://review.openstack.org/506312 | 20:56 |
openstackgerrit | Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416 | 20:56 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make 'fault' a valid joined query field for Instance https://review.openstack.org/506774 | 20:56 |
*** gouthamr has quit IRC | 20:58 | |
*** vvargaszte has quit IRC | 20:59 | |
openstackgerrit | Ed Leafe proposed openstack/nova master: Add alternate hosts https://review.openstack.org/486215 | 21:00 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | 21:00 |
*** mtreinish_ has joined #openstack-nova | 21:01 | |
*** jmlowe has quit IRC | 21:02 | |
*** hongbin_ has quit IRC | 21:02 | |
*** hongbin has joined #openstack-nova | 21:02 | |
*** mtreinish has quit IRC | 21:03 | |
*** mtreinish_ is now known as mtreinish | 21:03 | |
*** awaugama has quit IRC | 21:04 | |
*** esberglu has quit IRC | 21:04 | |
*** leakypipes has quit IRC | 21:07 | |
*** Sree has joined #openstack-nova | 21:14 | |
*** jjahns has quit IRC | 21:15 | |
*** edmondsw has quit IRC | 21:16 | |
*** cleong has quit IRC | 21:17 | |
*** Sree has quit IRC | 21:18 | |
mriedem | huh, placement randomly crashed in my devstack at some point in the last week | 21:21 |
*** harlowja has joined #openstack-nova | 21:23 | |
*** thorst has quit IRC | 21:27 | |
*** hoonetorg has quit IRC | 21:30 | |
*** felipemonteiro__ has quit IRC | 21:45 | |
*** liverpooler has quit IRC | 21:46 | |
mriedem | ooo yeah, bursting 20 instances at once with no quota and the fake virt driver | 21:52 |
mriedem | now i understand why this nfv thing is so fun! | 21:52 |
*** bigdogstl has joined #openstack-nova | 21:53 | |
*** rcernin has quit IRC | 21:54 | |
cburgess | lol | 21:54 |
mriedem | oh yeah, port quota | 21:55 |
mriedem | need to keep that in mind | 21:55 |
mriedem | superdan: i was going to create like 100 instances using the fake driver in devstack env and just compare listing instances before and after your changes, have you tried something like that yet? | 21:57 |
*** esberglu has joined #openstack-nova | 21:57 | |
*** bigdogstl has quit IRC | 21:58 | |
mriedem | i only have 1 cell though so it's not as fun | 21:59 |
superdan | mriedem: I've been scheming on some tests :) | 22:00 |
superdan | but I don't have any real numbers or anything no | 22:00 |
*** esberglu has quit IRC | 22:02 | |
*** baoli has quit IRC | 22:09 | |
*** tbachman has joined #openstack-nova | 22:09 | |
*** larainema has quit IRC | 22:16 | |
*** gouthamr has joined #openstack-nova | 22:16 | |
*** artom has quit IRC | 22:18 | |
*** alexpilotti has quit IRC | 22:23 | |
*** figleaf is now known as edleafe | 22:25 | |
* mikal lands in Sydney | 22:25 | |
mikal | I'd appreciate a quick review of https://review.openstack.org/#/c/504429/ if anyone is bored, its a fix for a privsep snafu with ploop stuff | 22:27 |
mikal | Not superdan though, he's already given it a +2 | 22:27 |
superdan | \o/ | 22:27 |
*** thorst has joined #openstack-nova | 22:28 | |
mikal | Yeah, that guy is an overachiever | 22:28 |
melwitt | I'll review it cause it's named "ploop" | 22:28 |
*** hongbin_ has joined #openstack-nova | 22:32 | |
*** penick has joined #openstack-nova | 22:32 | |
mikal | LOL | 22:33 |
mikal | melwitt: thanks, I appreciate it | 22:34 |
*** hongbin has quit IRC | 22:34 | |
*** penick_ has quit IRC | 22:35 | |
*** edmondsw has joined #openstack-nova | 22:35 | |
*** penick has quit IRC | 22:37 | |
*** edmondsw has quit IRC | 22:40 | |
*** penick has joined #openstack-nova | 22:40 | |
cburgess | OMG speaking of overachiver.. mikal from the airport on a Saturday. | 22:44 |
*** lyan has quit IRC | 22:46 | |
*** esberglu has joined #openstack-nova | 22:52 | |
*** esberglu has quit IRC | 22:56 | |
*** penick has quit IRC | 22:59 | |
mikal | cburgess: sorry, I'm just bored waiting four hours for my flight | 23:00 |
*** erlon has quit IRC | 23:04 | |
*** jmlowe has joined #openstack-nova | 23:05 | |
*** gouthamr has quit IRC | 23:05 | |
*** catintheroof has joined #openstack-nova | 23:07 | |
*** armax has joined #openstack-nova | 23:09 | |
*** sdague has quit IRC | 23:11 | |
*** hongbin_ has quit IRC | 23:12 | |
*** hongbin has joined #openstack-nova | 23:12 | |
*** esberglu has joined #openstack-nova | 23:13 | |
*** hongbin has quit IRC | 23:16 | |
*** esberglu has quit IRC | 23:17 | |
*** jmlowe has quit IRC | 23:19 | |
*** tidwellr has joined #openstack-nova | 23:20 | |
*** tidwellr has quit IRC | 23:21 | |
*** Sukhdev has joined #openstack-nova | 23:26 | |
openstackgerrit | Steve Noyes proposed openstack/nova master: Add attachment_get call to volume/cinder_api https://review.openstack.org/506805 | 23:33 |
cburgess | mikal Lame. Didn't catch the earlier flight? | 23:35 |
*** chyka has quit IRC | 23:35 | |
*** yamahata has quit IRC | 23:45 | |
*** jmlowe has joined #openstack-nova | 23:47 | |
openstackgerrit | Steve Noyes proposed openstack/nova master: Add attachment_get call to volume/cinder_api https://review.openstack.org/506805 | 23:47 |
*** catintheroof has quit IRC | 23:55 | |
*** Apoorva has quit IRC | 23:56 | |
*** Apoorva has joined #openstack-nova | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!