| openstackgerrit | Merged openstack/nova master: Fix policy check performance in 2.47+ https://review.openstack.org/507948 | 00:04 |
|---|---|---|
| *** baoli_ has quit IRC | 00:05 | |
| *** thorst has joined #openstack-nova | 00:07 | |
| *** thorst has quit IRC | 00:08 | |
| *** gjayavelu has joined #openstack-nova | 00:09 | |
| *** yangyapeng has quit IRC | 00:13 | |
| *** yangyapeng has joined #openstack-nova | 00:14 | |
| *** itlinux has quit IRC | 00:15 | |
| *** yangyapeng has quit IRC | 00:18 | |
| *** baoli has joined #openstack-nova | 00:20 | |
| *** tbachman has quit IRC | 00:23 | |
| *** tbachman_ has joined #openstack-nova | 00:24 | |
| *** slaweq_ has quit IRC | 00:27 | |
| *** slaweq_ has joined #openstack-nova | 00:32 | |
| *** coreywright has quit IRC | 00:32 | |
| *** tbachman_ has quit IRC | 00:34 | |
| *** tbachman has joined #openstack-nova | 00:34 | |
| *** sree has joined #openstack-nova | 00:36 | |
| *** Shunli has joined #openstack-nova | 00:37 | |
| *** tbachman has quit IRC | 00:39 | |
| *** mingyu has quit IRC | 00:40 | |
| *** mingyu has joined #openstack-nova | 00:40 | |
| *** sree has quit IRC | 00:41 | |
| *** sree has joined #openstack-nova | 00:41 | |
| *** mingyu has quit IRC | 00:42 | |
| *** sree has quit IRC | 00:42 | |
| *** sree has joined #openstack-nova | 00:42 | |
| *** mingyu has joined #openstack-nova | 00:42 | |
| *** tbachman has joined #openstack-nova | 00:44 | |
| *** jichen has joined #openstack-nova | 00:44 | |
| *** nikhil has joined #openstack-nova | 00:46 | |
| *** dave-mccowan has joined #openstack-nova | 00:46 | |
| *** zhurong has joined #openstack-nova | 00:47 | |
| *** coreywright has joined #openstack-nova | 00:49 | |
| *** litao__ has joined #openstack-nova | 00:49 | |
| *** Swami has quit IRC | 00:50 | |
| *** mriedem has quit IRC | 00:59 | |
| *** phuongnh has joined #openstack-nova | 01:02 | |
| *** liusheng has quit IRC | 01:04 | |
| *** slaweq_ has quit IRC | 01:05 | |
| *** thorst has joined #openstack-nova | 01:09 | |
| *** lennyb has quit IRC | 01:11 | |
| *** lennyb has joined #openstack-nova | 01:11 | |
| *** slaweq_ has joined #openstack-nova | 01:13 | |
| *** yikun_jiang is now known as yikun | 01:13 | |
| *** sree has quit IRC | 01:15 | |
| *** sree has joined #openstack-nova | 01:15 | |
| *** liusheng has joined #openstack-nova | 01:16 | |
| *** sree has quit IRC | 01:20 | |
| *** yangyapeng has joined #openstack-nova | 01:20 | |
| yikun | hi, I submit Queue bp about pagination for migrations and instance-actions. | 01:20 |
| yikun | These bps have approved previously in newton, but didn't implemented yet, | 01:20 |
| yikun | now I move these to queens, could anyone have a look? thanks : ) | 01:20 |
| yikun | https://review.openstack.org/#/c/506030/ | 01:20 |
| yikun | https://review.openstack.org/#/c/507762/ | 01:21 |
| yikun | thanks for your review. | 01:21 |
| *** gjayavelu has quit IRC | 01:21 | |
| *** mikal_ has joined #openstack-nova | 01:22 | |
| *** hongbin has joined #openstack-nova | 01:22 | |
| *** Yikun__ has joined #openstack-nova | 01:22 | |
| *** eharney has quit IRC | 01:22 | |
| *** thorst has quit IRC | 01:23 | |
| *** thorst has joined #openstack-nova | 01:23 | |
| *** yangyape_ has joined #openstack-nova | 01:25 | |
| *** yangyapeng has quit IRC | 01:25 | |
| *** mikal has quit IRC | 01:25 | |
| *** thorst has quit IRC | 01:26 | |
| *** mikal_ has quit IRC | 01:28 | |
| *** edmondsw has joined #openstack-nova | 01:28 | |
| *** masayukig has quit IRC | 01:28 | |
| *** masayukig has joined #openstack-nova | 01:29 | |
| *** gcb has joined #openstack-nova | 01:31 | |
| *** edmondsw has quit IRC | 01:32 | |
| *** mingyu_ has joined #openstack-nova | 01:33 | |
| *** bnemec has quit IRC | 01:34 | |
| *** mingyu has quit IRC | 01:35 | |
| *** eharney has joined #openstack-nova | 01:36 | |
| *** bnemec has joined #openstack-nova | 01:39 | |
| *** dave-mccowan has quit IRC | 01:41 | |
| *** esberglu has quit IRC | 01:43 | |
| *** slaweq_ has quit IRC | 01:43 | |
| *** dave-mccowan has joined #openstack-nova | 01:45 | |
| *** tidwellr has quit IRC | 01:48 | |
| *** slaweq_ has joined #openstack-nova | 01:50 | |
| *** itlinux has joined #openstack-nova | 01:51 | |
| *** sree has joined #openstack-nova | 01:52 | |
| *** mikal has joined #openstack-nova | 01:56 | |
| *** mingyu_ has quit IRC | 01:57 | |
| *** dave-mcc_ has joined #openstack-nova | 02:05 | |
| *** sdague has quit IRC | 02:05 | |
| *** dave-mccowan has quit IRC | 02:07 | |
| *** itlinux has quit IRC | 02:07 | |
| *** sree has quit IRC | 02:08 | |
| *** Apoorva_ has quit IRC | 02:10 | |
| *** itlinux has joined #openstack-nova | 02:14 | |
| *** liuyulong has joined #openstack-nova | 02:15 | |
| *** itlinux has quit IRC | 02:15 | |
| *** huanxie has joined #openstack-nova | 02:15 | |
| *** krtaylor has joined #openstack-nova | 02:20 | |
| *** yamamoto has joined #openstack-nova | 02:22 | |
| *** yamamoto has quit IRC | 02:22 | |
| *** slaweq_ has quit IRC | 02:22 | |
| *** yamamoto has joined #openstack-nova | 02:22 | |
| *** baoli has quit IRC | 02:24 | |
| *** thorst has joined #openstack-nova | 02:26 | |
| *** slaweq_ has joined #openstack-nova | 02:27 | |
| *** esberglu has joined #openstack-nova | 02:32 | |
| *** itlinux has joined #openstack-nova | 02:33 | |
| *** baoli has joined #openstack-nova | 02:34 | |
| *** mingyu has joined #openstack-nova | 02:34 | |
| *** esberglu has quit IRC | 02:36 | |
| *** dave-mcc_ has quit IRC | 02:38 | |
| *** baoli has quit IRC | 02:42 | |
| *** baoli has joined #openstack-nova | 02:44 | |
| *** itlinux has quit IRC | 02:52 | |
| *** nikhil has quit IRC | 02:55 | |
| *** slaweq_ has quit IRC | 03:00 | |
| *** slaweq_ has joined #openstack-nova | 03:09 | |
| *** moshele has quit IRC | 03:14 | |
| *** Sukhdev has quit IRC | 03:15 | |
| *** edmondsw has joined #openstack-nova | 03:16 | |
| *** edmondsw has quit IRC | 03:21 | |
| *** baoli has quit IRC | 03:21 | |
| *** baoli has joined #openstack-nova | 03:22 | |
| *** Sukhdev has joined #openstack-nova | 03:25 | |
| *** bnemec has quit IRC | 03:26 | |
| *** crushil has joined #openstack-nova | 03:26 | |
| openstackgerrit | Merged openstack/nova master: doc: make host aggregates examples more discoverable https://review.openstack.org/507950 | 03:28 |
| *** Yikun__ has quit IRC | 03:32 | |
| *** Tengu has quit IRC | 03:33 | |
| *** ujjain has quit IRC | 03:34 | |
| *** MasterofJOKers has quit IRC | 03:34 | |
| *** baoli has quit IRC | 03:34 | |
| *** Tengu has joined #openstack-nova | 03:39 | |
| *** MasterofJOKers has joined #openstack-nova | 03:39 | |
| *** ujjain has joined #openstack-nova | 03:39 | |
| *** ujjain has quit IRC | 03:39 | |
| *** ujjain has joined #openstack-nova | 03:39 | |
| *** slaweq_ has quit IRC | 03:41 | |
| *** udesale has joined #openstack-nova | 03:42 | |
| *** links has joined #openstack-nova | 03:44 | |
| *** slaweq_ has joined #openstack-nova | 03:45 | |
| *** ujjain has quit IRC | 03:46 | |
| *** ujjain has joined #openstack-nova | 03:48 | |
| *** ujjain has quit IRC | 03:48 | |
| *** ujjain has joined #openstack-nova | 03:48 | |
| *** cfriesen_ has quit IRC | 03:50 | |
| *** sridharg has joined #openstack-nova | 03:52 | |
| *** rha has quit IRC | 03:52 | |
| *** avolkov` has joined #openstack-nova | 03:57 | |
| *** avolkov has quit IRC | 03:59 | |
| *** rha has joined #openstack-nova | 03:59 | |
| *** zhurong has quit IRC | 04:07 | |
| *** crushil_ has joined #openstack-nova | 04:10 | |
| *** shaner has quit IRC | 04:12 | |
| *** shaner has joined #openstack-nova | 04:15 | |
| *** slaweq_ has quit IRC | 04:18 | |
| *** yangyape_ has quit IRC | 04:22 | |
| *** yangyapeng has joined #openstack-nova | 04:23 | |
| *** kornicameister has quit IRC | 04:24 | |
| *** slaweq_ has joined #openstack-nova | 04:24 | |
| *** itlinux has joined #openstack-nova | 04:28 | |
| *** takedakn has joined #openstack-nova | 04:31 | |
| *** hongbin has quit IRC | 04:31 | |
| *** sree has joined #openstack-nova | 04:38 | |
| *** huanxie has quit IRC | 04:40 | |
| *** ratailor has joined #openstack-nova | 04:45 | |
| *** lpetrut has joined #openstack-nova | 04:46 | |
| mikal | I think I found a bug in unittest.mock | 04:47 |
| *** itlinux has quit IRC | 04:48 | |
| *** psachin has joined #openstack-nova | 04:52 | |
| *** slaweq_ has quit IRC | 04:56 | |
| *** mdnadeem has joined #openstack-nova | 04:58 | |
| *** slaweq_ has joined #openstack-nova | 05:03 | |
| *** edmondsw has joined #openstack-nova | 05:04 | |
| *** huanxie has joined #openstack-nova | 05:07 | |
| *** gjayavelu has joined #openstack-nova | 05:08 | |
| *** lpetrut has quit IRC | 05:08 | |
| *** edmondsw has quit IRC | 05:09 | |
| *** vladikr has quit IRC | 05:15 | |
| *** takedakn has quit IRC | 05:18 | |
| *** avolkov` has quit IRC | 05:20 | |
| *** avolkov` has joined #openstack-nova | 05:20 | |
| *** lpetrut has joined #openstack-nova | 05:23 | |
| *** Sukhdev has quit IRC | 05:29 | |
| *** yangyape_ has joined #openstack-nova | 05:29 | |
| *** yangyapeng has quit IRC | 05:29 | |
| *** trinaths has joined #openstack-nova | 05:31 | |
| *** chyka has quit IRC | 05:31 | |
| *** yangyape_ has quit IRC | 05:31 | |
| *** yangyapeng has joined #openstack-nova | 05:32 | |
| *** manasm has joined #openstack-nova | 05:32 | |
| *** slaweq_ has quit IRC | 05:33 | |
| *** claudiub|3 has joined #openstack-nova | 05:37 | |
| *** slaweq_ has joined #openstack-nova | 05:43 | |
| *** gjayavelu has quit IRC | 05:45 | |
| *** lpetrut has quit IRC | 05:47 | |
| openstackgerrit | jichenjc proposed openstack/nova master: remove CONF.vendordata_driver https://review.openstack.org/501510 | 05:47 |
| *** dgonzalez has joined #openstack-nova | 05:50 | |
| *** yangyapeng has quit IRC | 05:50 | |
| *** edand has joined #openstack-nova | 05:50 | |
| *** yangyape_ has joined #openstack-nova | 05:50 | |
| *** cfriesen_ has joined #openstack-nova | 05:55 | |
| *** trinaths2 has joined #openstack-nova | 05:57 | |
| *** trinaths has quit IRC | 05:57 | |
| *** cfriesen_ has quit IRC | 06:00 | |
| *** cfriesen__ has joined #openstack-nova | 06:00 | |
| *** Oku_OS-away is now known as Oku_OS | 06:08 | |
| *** crushil_ has quit IRC | 06:10 | |
| *** crushil has quit IRC | 06:11 | |
| *** josecastroleon has joined #openstack-nova | 06:11 | |
| *** esberglu has joined #openstack-nova | 06:11 | |
| *** erlon has quit IRC | 06:14 | |
| *** esberglu has quit IRC | 06:15 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif stable/pike: Updated from global requirements https://review.openstack.org/493146 | 06:17 |
| *** liuyulong has quit IRC | 06:17 | |
| *** yangyape_ has quit IRC | 06:18 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient stable/pike: Updated from global requirements https://review.openstack.org/493187 | 06:18 |
| *** yangyapeng has joined #openstack-nova | 06:19 | |
| *** pcaruana has joined #openstack-nova | 06:19 | |
| openstackgerrit | Merged openstack/nova stable/pike: Handle deleted instances when refreshing the info_cache https://review.openstack.org/506183 | 06:22 |
| *** yangyapeng has quit IRC | 06:23 | |
| *** yangyapeng has joined #openstack-nova | 06:29 | |
| *** markvoelker has quit IRC | 06:30 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif stable/pike: Updated from global requirements https://review.openstack.org/493146 | 06:34 |
| *** yangyapeng has quit IRC | 06:34 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient stable/pike: Updated from global requirements https://review.openstack.org/493187 | 06:36 |
| *** cfriesen__ has quit IRC | 06:37 | |
| *** zhurong has joined #openstack-nova | 06:38 | |
| *** mnestratov has joined #openstack-nova | 06:39 | |
| openstackgerrit | jichenjc proposed openstack/nova master: check query param for server groups function https://review.openstack.org/500347 | 06:40 |
| *** moshele has joined #openstack-nova | 06:46 | |
| *** slaweq_ has quit IRC | 06:46 | |
| *** Tom has joined #openstack-nova | 06:50 | |
| *** andreas_s has joined #openstack-nova | 06:50 | |
| *** edmondsw has joined #openstack-nova | 06:52 | |
| *** slaweq_ has joined #openstack-nova | 06:53 | |
| openstackgerrit | jichenjc proposed openstack/nova master: check query param for used_limits function https://review.openstack.org/499091 | 06:56 |
| *** edmondsw has quit IRC | 06:57 | |
| openstackgerrit | jichenjc proposed openstack/nova master: check query param for used_limits function https://review.openstack.org/499091 | 06:58 |
| *** rcernin has joined #openstack-nova | 07:00 | |
| *** sshwarts has joined #openstack-nova | 07:01 | |
| openstackgerrit | jichenjc proposed openstack/nova master: fix race condition of instance host https://review.openstack.org/494458 | 07:02 |
| openstackgerrit | jichenjc proposed openstack/nova master: propagate OSError to MigrationPreCheckError https://review.openstack.org/469779 | 07:02 |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP: only allow TLS v1.2 in nova servers https://review.openstack.org/459504 | 07:02 |
| *** yangyapeng has joined #openstack-nova | 07:03 | |
| *** andymccr has quit IRC | 07:07 | |
| *** yangyapeng has quit IRC | 07:07 | |
| *** armax has joined #openstack-nova | 07:08 | |
| *** asettle has quit IRC | 07:08 | |
| *** zsli_ has joined #openstack-nova | 07:09 | |
| *** andymccr has joined #openstack-nova | 07:09 | |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP: conf: remove deprecated 'project_id_regex' opt https://review.openstack.org/501057 | 07:10 |
| *** asettle has joined #openstack-nova | 07:10 | |
| *** asettle is now known as Guest3828 | 07:10 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Check root disk size when doing resize in API https://review.openstack.org/484664 | 07:10 |
| *** avolkov` has quit IRC | 07:10 | |
| *** Shunli has quit IRC | 07:12 | |
| *** armax has quit IRC | 07:14 | |
| *** avolkov` has joined #openstack-nova | 07:15 | |
| *** yangyapeng has joined #openstack-nova | 07:17 | |
| *** yangyapeng has quit IRC | 07:18 | |
| *** yangyapeng has joined #openstack-nova | 07:18 | |
| *** ralonsoh has joined #openstack-nova | 07:19 | |
| *** andreas_s_ has joined #openstack-nova | 07:21 | |
| *** andreas_s has quit IRC | 07:21 | |
| *** ragiman has joined #openstack-nova | 07:25 | |
| *** sahid has joined #openstack-nova | 07:26 | |
| *** slaweq_ has quit IRC | 07:27 | |
| *** yangyapeng has quit IRC | 07:29 | |
| *** yangyape_ has joined #openstack-nova | 07:29 | |
| *** burt has quit IRC | 07:29 | |
| *** slaweq_ has joined #openstack-nova | 07:30 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix inconsistency of 'NOTE:' description https://review.openstack.org/508074 | 07:30 |
| *** yangyape_ has quit IRC | 07:30 | |
| *** yangyapeng has joined #openstack-nova | 07:30 | |
| openstackgerrit | Merged openstack/nova stable/pike: Fix 500 if list servers called with empty regex pattern https://review.openstack.org/506754 | 07:31 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: List/show all server migration types https://review.openstack.org/489029 | 07:33 |
| *** huanxie has quit IRC | 07:34 | |
| *** jpena|off is now known as jpena | 07:34 | |
| *** hferenc has joined #openstack-nova | 07:34 | |
| *** ragiman has quit IRC | 07:35 | |
| *** armax has joined #openstack-nova | 07:36 | |
| *** burt has joined #openstack-nova | 07:38 | |
| *** huanxie has joined #openstack-nova | 07:41 | |
| *** zhouyaguo has joined #openstack-nova | 07:42 | |
| *** armax has quit IRC | 07:42 | |
| openstackgerrit | Merged openstack/nova stable/pike: Fix --max-count handling for nova-manage cell_v2 map_instances https://review.openstack.org/507552 | 07:44 |
| *** xinliang has quit IRC | 07:51 | |
| *** ragiman has joined #openstack-nova | 07:52 | |
| *** yamamoto has quit IRC | 07:56 | |
| *** manasm has quit IRC | 07:58 | |
| *** esberglu has joined #openstack-nova | 07:59 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Add 400 as error code for resource class delete https://review.openstack.org/508080 | 07:59 |
| *** slaweq_ has quit IRC | 08:02 | |
| *** avolkov` has quit IRC | 08:02 | |
| *** avolkov` has joined #openstack-nova | 08:03 | |
| *** yamamoto has joined #openstack-nova | 08:03 | |
| *** esberglu has quit IRC | 08:03 | |
| *** manasm has joined #openstack-nova | 08:04 | |
| *** avolkov` has left #openstack-nova | 08:04 | |
| *** xinliang has joined #openstack-nova | 08:05 | |
| *** avolkov has joined #openstack-nova | 08:05 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Add description for reousrce class creation https://review.openstack.org/508083 | 08:07 |
| *** slaweq_ has joined #openstack-nova | 08:09 | |
| *** takedakn has joined #openstack-nova | 08:11 | |
| *** moshele has quit IRC | 08:11 | |
| *** lpetrut has joined #openstack-nova | 08:16 | |
| *** alexchadin has joined #openstack-nova | 08:22 | |
| openstackgerrit | jichenjc proposed openstack/nova master: remove CONF.vendordata_driver https://review.openstack.org/501510 | 08:23 |
| *** trinaths2 has quit IRC | 08:23 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Add description for reousrce class creation https://review.openstack.org/508083 | 08:25 |
| *** yamamoto has quit IRC | 08:25 | |
| *** rmart04 has joined #openstack-nova | 08:25 | |
| *** ragiman has quit IRC | 08:26 | |
| *** derekh has joined #openstack-nova | 08:26 | |
| johnthetubaguy | alex_xu are you working with lei-zh on https://review.openstack.org/#/c/468797? | 08:27 |
| *** yamamoto has joined #openstack-nova | 08:30 | |
| *** rmart04 has quit IRC | 08:30 | |
| *** markvoelker has joined #openstack-nova | 08:31 | |
| *** huanxie has quit IRC | 08:32 | |
| *** yamamoto_ has joined #openstack-nova | 08:32 | |
| *** rmart04 has joined #openstack-nova | 08:33 | |
| *** rmart04 has quit IRC | 08:33 | |
| *** yamamoto_ has quit IRC | 08:34 | |
| *** yamamoto has quit IRC | 08:35 | |
| *** yamahata has joined #openstack-nova | 08:36 | |
| *** ragiman has joined #openstack-nova | 08:38 | |
| *** zhouyaguo has quit IRC | 08:39 | |
| *** Guest3828 is now known as asettle | 08:39 | |
| *** zhouyaguo has joined #openstack-nova | 08:39 | |
| *** edmondsw has joined #openstack-nova | 08:41 | |
| *** slaweq_ has quit IRC | 08:43 | |
| *** edmondsw has quit IRC | 08:45 | |
| *** yamahata has quit IRC | 08:46 | |
| *** manasm has quit IRC | 08:47 | |
| *** yamahata has joined #openstack-nova | 08:47 | |
| *** rmart04 has joined #openstack-nova | 08:48 | |
| *** alexchadin has quit IRC | 08:50 | |
| *** alexchadin has joined #openstack-nova | 08:51 | |
| *** alexchadin has quit IRC | 08:51 | |
| *** alexchadin has joined #openstack-nova | 08:51 | |
| *** slaweq_ has joined #openstack-nova | 08:54 | |
| openstackgerrit | Merged openstack/nova stable/pike: Refactor ServerMovingTests for non-move tests https://review.openstack.org/507195 | 09:00 |
| *** ralonsoh_ has joined #openstack-nova | 09:00 | |
| *** alexchadin has quit IRC | 09:01 | |
| *** alexchadin has joined #openstack-nova | 09:03 | |
| *** manasm has joined #openstack-nova | 09:03 | |
| *** ralonsoh has quit IRC | 09:03 | |
| *** yangyapeng has quit IRC | 09:04 | |
| *** markvoelker has quit IRC | 09:05 | |
| *** yangyapeng has joined #openstack-nova | 09:08 | |
| *** Tom has quit IRC | 09:09 | |
| *** rmart04 has quit IRC | 09:12 | |
| gmann | oomichi: are you ok with create_or_update_* in this https://review.openstack.org/#/c/504439/11 ? | 09:14 |
| *** yamamoto has joined #openstack-nova | 09:14 | |
| *** huanxie has joined #openstack-nova | 09:16 | |
| *** yamamoto has quit IRC | 09:17 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Make etree.tostring() emit unicode everywhere https://review.openstack.org/507488 | 09:18 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: libvirt: Don't VIR_MIGRATE_NON_SHARED_INC without migrate_disks https://review.openstack.org/507202 | 09:18 |
| bhagyashris | avolkov: Hi, | 09:18 |
| avolkov | bhagyashris: hi | 09:18 |
| mdbooth | stephenfin: I wrote the test you asked for on https://review.openstack.org/#/c/507488/ | 09:18 |
| mdbooth | Then I unwrote it :) | 09:19 |
| mdbooth | Can you have a quick look at my reply in case I misunderstood? | 09:19 |
| bhagyashris | avolkov: I just want to discuss regarding the patch: https://review.openstack.org/#/c/409644/ I have respond to your comment can you please take some in sights | 09:20 |
| * mdbooth is aware that the gate is being a bit glacial right now, and has plenty of time to fix it before Jenkins votes | 09:20 | |
| *** sambetts|afk is now known as sambetts | 09:24 | |
| *** artom has joined #openstack-nova | 09:24 | |
| *** slaweq_ has quit IRC | 09:26 | |
| *** zsli_ has quit IRC | 09:27 | |
| *** alexchad_ has joined #openstack-nova | 09:28 | |
| *** alexchadin has quit IRC | 09:30 | |
| *** alexchad_ has quit IRC | 09:32 | |
| *** alexchadin has joined #openstack-nova | 09:33 | |
| avolkov | bhagyashris: left a comment there | 09:35 |
| bhagyashris | avolkov: Thank you :) | 09:35 |
| *** slaweq_ has joined #openstack-nova | 09:36 | |
| *** armax has joined #openstack-nova | 09:38 | |
| *** yamahata has quit IRC | 09:40 | |
| *** jichen has quit IRC | 09:40 | |
| bhagyashris | avolkov: I will fix the review comment thank you for review :) | 09:42 |
| *** armax has quit IRC | 09:42 | |
| *** sdague has joined #openstack-nova | 09:44 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for API extensions policy removal https://review.openstack.org/508101 | 09:45 |
| *** takashin has left #openstack-nova | 09:46 | |
| *** ijw has quit IRC | 09:47 | |
| *** huanxie has quit IRC | 09:47 | |
| *** esberglu has joined #openstack-nova | 09:47 | |
| artom | lyarwood, around? | 09:48 |
| artom | The -W can come off https://review.openstack.org/#/c/499208/ I think, right? | 09:48 |
| artom | Since https://review.openstack.org/#/c/468514/ landed | 09:48 |
| artom | Same for https://review.openstack.org/#/c/468319/ | 09:49 |
| *** esberglu has quit IRC | 09:51 | |
| *** trinaths has joined #openstack-nova | 09:52 | |
| *** yassine has quit IRC | 09:54 | |
| *** ratailor is now known as rtailor | 09:56 | |
| *** sree has quit IRC | 09:57 | |
| *** jpena has quit IRC | 09:59 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for API extensions policy removal https://review.openstack.org/508101 | 09:59 |
| *** ltomasbo has quit IRC | 09:59 | |
| *** huanxie has joined #openstack-nova | 10:00 | |
| lyarwood | artom: hey yeah | 10:01 |
| lyarwood | artom: ack looking | 10:01 |
| *** artom has quit IRC | 10:02 | |
| *** markvoelker has joined #openstack-nova | 10:02 | |
| *** yangyapeng has quit IRC | 10:02 | |
| *** yamamoto has joined #openstack-nova | 10:03 | |
| *** ralonsoh__ has joined #openstack-nova | 10:03 | |
| *** yangyapeng has joined #openstack-nova | 10:03 | |
| *** ltomasbo has joined #openstack-nova | 10:04 | |
| *** yangyapeng has quit IRC | 10:04 | |
| *** jpena has joined #openstack-nova | 10:05 | |
| *** yamamoto has quit IRC | 10:05 | |
| *** ralonsoh_ has quit IRC | 10:06 | |
| *** masber has quit IRC | 10:06 | |
| *** masber has joined #openstack-nova | 10:07 | |
| *** slaweq_ has quit IRC | 10:09 | |
| *** jmlowe has quit IRC | 10:10 | |
| *** chyka has joined #openstack-nova | 10:16 | |
| *** slaweq_ has joined #openstack-nova | 10:17 | |
| *** cdent has joined #openstack-nova | 10:19 | |
| *** chyka has quit IRC | 10:21 | |
| *** ralonsoh__ is now known as ralonsoh | 10:24 | |
| *** zhurong has quit IRC | 10:27 | |
| *** edmondsw has joined #openstack-nova | 10:29 | |
| *** yamamoto has joined #openstack-nova | 10:29 | |
| *** yamamoto has quit IRC | 10:31 | |
| *** alexchadin has quit IRC | 10:32 | |
| *** edmondsw has quit IRC | 10:33 | |
| *** obre has quit IRC | 10:34 | |
| *** obre has joined #openstack-nova | 10:34 | |
| *** markvoelker has quit IRC | 10:35 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486 | 10:35 |
| *** yamamoto has joined #openstack-nova | 10:37 | |
| *** yamamoto has quit IRC | 10:38 | |
| *** udesale has quit IRC | 10:39 | |
| *** yamamoto has joined #openstack-nova | 10:40 | |
| *** phuongnh has quit IRC | 10:40 | |
| *** yamamoto has quit IRC | 10:43 | |
| *** andreas_s has joined #openstack-nova | 10:45 | |
| *** yamamoto has joined #openstack-nova | 10:46 | |
| *** ijw has joined #openstack-nova | 10:47 | |
| *** zhouyaguo has quit IRC | 10:48 | |
| *** andreas_s_ has quit IRC | 10:48 | |
| *** yamamoto has quit IRC | 10:49 | |
| *** gcb has quit IRC | 10:50 | |
| *** Tom__ has joined #openstack-nova | 10:51 | |
| *** ijw has quit IRC | 10:52 | |
| *** tbachman has quit IRC | 10:53 | |
| *** slaweq_ has quit IRC | 10:53 | |
| *** Tom__ has quit IRC | 10:55 | |
| *** smatzek has joined #openstack-nova | 11:01 | |
| *** trinaths1 has joined #openstack-nova | 11:02 | |
| *** trinaths has quit IRC | 11:02 | |
| *** MVenesio has joined #openstack-nova | 11:03 | |
| *** takedakn has quit IRC | 11:05 | |
| *** gcb has joined #openstack-nova | 11:07 | |
| *** huanxie has quit IRC | 11:07 | |
| *** thorst has quit IRC | 11:16 | |
| *** MVenesio has quit IRC | 11:17 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Send traits to ironic on server boot https://review.openstack.org/508116 | 11:17 |
| *** MVenesio has joined #openstack-nova | 11:18 | |
| *** slaweq_ has joined #openstack-nova | 11:23 | |
| *** yassine has joined #openstack-nova | 11:24 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Do not monkey patch eventlet in unit tests https://review.openstack.org/507923 | 11:25 |
| openstackgerrit | Chris Dent proposed openstack/nova master: DNM: Don't monkey patch eventlet in functional https://review.openstack.org/506668 | 11:25 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Do not setup conductor in BaseAPITestCase https://review.openstack.org/508120 | 11:25 |
| *** bhagyashris has quit IRC | 11:28 | |
| *** yamamoto has joined #openstack-nova | 11:28 | |
| *** bhagyashris has joined #openstack-nova | 11:28 | |
| *** markvoelker has joined #openstack-nova | 11:32 | |
| *** MVenesio has quit IRC | 11:32 | |
| mdbooth | cdent: Remind me, were you proposing removing eventlet from tests? | 11:33 |
| cdent | I was yes | 11:33 |
| cdent | there are monkey_patch calls at the top of the unit and functional trees | 11:34 |
| cdent | removing the one at the top of unit is no problem | 11:34 |
| cdent | the one at the top of functional is a problem, but limited | 11:34 |
| mdbooth | cdent: Data point: I've used eventlet in tests explicitly a couple of times because its locking primitives can be killed with Ctrl-C, whereas the regular python ones can't. | 11:34 |
| cdent | used explicitly: great | 11:35 |
| *** esberglu has joined #openstack-nova | 11:35 | |
| mdbooth | This has no impact on the test usually, but is really useful when you're debugging it | 11:35 |
| cdent | it’s the global monkey patching that i think is bad news | 11:35 |
| mdbooth | Cool, just thought I'd bring it up | 11:36 |
| cdent | yeah, thanks. | 11:36 |
| cdent | In my digging around it looks like there’s still a fair amount of tests under unit that ought to be under functional, but I’m pretty sure I don’t want to fall in that hole (yet) | 11:37 |
| * mdbooth feels the functional boundary lies at 'starts a service' | 11:38 | |
| * mdbooth would like to see more functional unit tests in general | 11:38 | |
| *** esberglu has quit IRC | 11:39 | |
| cdent | yeah, I grepped for ‘start_service’ as sort of an initial feel around and the boundary has been permeated | 11:40 |
| *** jaosorior_sick is now known as jaosorior | 11:41 | |
| cdent | johnthetubaguy, stephenfin : can you guys weigh in on https://review.openstack.org/#/c/469048/ it’s some placement docs that have been languishing for a long time | 11:45 |
| cdent | and this is a test that’s also been languishing, adds a bit more coverage: https://review.openstack.org/#/c/485209/ | 11:46 |
| *** huanxie has joined #openstack-nova | 11:46 | |
| cdent | gibi: you too on both of those | 11:46 |
| *** andreas_s_ has joined #openstack-nova | 11:47 | |
| *** andreas_s has quit IRC | 11:51 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Send traits to ironic on server boot https://review.openstack.org/508116 | 11:51 |
| *** slaweq_ has quit IRC | 11:57 | |
| *** slaweq_ has joined #openstack-nova | 12:01 | |
| *** yamamoto has quit IRC | 12:03 | |
| *** thorst has joined #openstack-nova | 12:03 | |
| sdague | ok, the qemu >= 2.10 patch should really really be ready this time - https://review.openstack.org/#/c/505673/ - stephenfin, bauzas, johnthetubaguy if anyone wants to take a quick look | 12:05 |
| *** vladikr has joined #openstack-nova | 12:05 | |
| *** markvoelker has quit IRC | 12:06 | |
| *** eharney has quit IRC | 12:06 | |
| *** trinaths1 has quit IRC | 12:09 | |
| mdbooth | Any chance of some eyes on this: https://review.openstack.org/#/c/507202/ | 12:10 |
| mdbooth | It's a data corruptor with no current mitigation other than "don't do that" | 12:10 |
| mdbooth | The dependent patch is an annoying python 3-ism | 12:10 |
| mdbooth | That's unfair, it's a bug in the libvirt python bindings, and a questionable default choice in the lxml python bindings | 12:11 |
| *** gcb has quit IRC | 12:12 | |
| *** gcb has joined #openstack-nova | 12:12 | |
| *** trinaths has joined #openstack-nova | 12:15 | |
| *** markvoelker has joined #openstack-nova | 12:18 | |
| *** manasm has quit IRC | 12:19 | |
| cdent | mdbooth: that etree default stuff has bit me so many times | 12:20 |
| cdent | (not in an openstack context, but elsewhere) | 12:20 |
| *** mvk has quit IRC | 12:20 | |
| cdent | sdague: no one will believe you until you use a 3rd “really” | 12:21 |
| mdbooth | cdent: It bit me, so I did my usual trick of fixing the whole problem rather than just my bit. Ironically, that decision usually bites me. | 12:21 |
| *** cdent has quit IRC | 12:21 | |
| *** litao__ has quit IRC | 12:26 | |
| *** tbachman has joined #openstack-nova | 12:27 | |
| *** jmlowe has joined #openstack-nova | 12:28 | |
| *** tbachman_ has joined #openstack-nova | 12:29 | |
| *** pcaruana has quit IRC | 12:31 | |
| *** edmondsw has joined #openstack-nova | 12:31 | |
| *** tbachman has quit IRC | 12:32 | |
| *** tbachman_ is now known as tbachman | 12:32 | |
| *** slaweq_ has quit IRC | 12:34 | |
| *** slunkad has quit IRC | 12:37 | |
| stephenfin | mdbooth: Comments left. One of us is missing something :) | 12:39 |
| *** ygl has joined #openstack-nova | 12:39 | |
| mdbooth | stephenfin: Thanks. Look in a bit. | 12:39 |
| *** slunkad has joined #openstack-nova | 12:42 | |
| *** mlakat has quit IRC | 12:43 | |
| *** kfarr has joined #openstack-nova | 12:43 | |
| *** slaweq_ has joined #openstack-nova | 12:44 | |
| *** liverpooler has joined #openstack-nova | 12:44 | |
| *** jaypipes has joined #openstack-nova | 12:45 | |
| *** jpena is now known as jpena|lunch | 12:46 | |
| *** huanxie has quit IRC | 12:47 | |
| openstackgerrit | konstantin proposed openstack/nova master: switch from filesystem to disk for parallels containers https://review.openstack.org/506687 | 12:48 |
| openstackgerrit | konstantin proposed openstack/nova master: don't add device address if there is no any units https://review.openstack.org/506686 | 12:48 |
| *** kenperkins has joined #openstack-nova | 12:49 | |
| *** takedakn has joined #openstack-nova | 12:50 | |
| *** cdent has joined #openstack-nova | 12:51 | |
| *** hemna_ has joined #openstack-nova | 12:51 | |
| *** erlon has joined #openstack-nova | 12:53 | |
| *** ygl has quit IRC | 12:54 | |
| *** dave-mccowan has joined #openstack-nova | 12:54 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif stable/ocata: Updated from global requirements https://review.openstack.org/490256 | 12:54 |
| *** eharney has joined #openstack-nova | 12:55 | |
| *** artom has joined #openstack-nova | 12:55 | |
| *** lyan has joined #openstack-nova | 12:55 | |
| *** artom has quit IRC | 12:56 | |
| *** artom has joined #openstack-nova | 12:56 | |
| cdent | thanks stephenfin for the robust review | 12:57 |
| *** artom has quit IRC | 12:57 | |
| *** artom has joined #openstack-nova | 12:57 | |
| *** slunkad has quit IRC | 12:57 | |
| *** artom has quit IRC | 12:58 | |
| *** gcb has quit IRC | 12:58 | |
| *** artom has joined #openstack-nova | 12:58 | |
| *** artom has quit IRC | 12:59 | |
| *** artom has joined #openstack-nova | 12:59 | |
| *** sean-k-mooney has joined #openstack-nova | 12:59 | |
| *** gbarros has joined #openstack-nova | 12:59 | |
| *** artom has quit IRC | 13:00 | |
| *** mlakat has joined #openstack-nova | 13:00 | |
| *** artom has joined #openstack-nova | 13:00 | |
| *** pcaruana has joined #openstack-nova | 13:00 | |
| *** artom has quit IRC | 13:01 | |
| *** belmoreira has joined #openstack-nova | 13:01 | |
| *** artom has joined #openstack-nova | 13:01 | |
| *** artom has quit IRC | 13:02 | |
| *** artom has joined #openstack-nova | 13:02 | |
| *** gcb has joined #openstack-nova | 13:02 | |
| *** yamamoto has joined #openstack-nova | 13:03 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova stable/ocata: Test InstanceNotFound handling in 'nova usage' https://review.openstack.org/482219 | 13:04 |
| *** sree has joined #openstack-nova | 13:04 | |
| *** belmoreira has quit IRC | 13:06 | |
| *** belmorei_ has joined #openstack-nova | 13:06 | |
| *** belmorei_ has quit IRC | 13:07 | |
| *** belmoreira has joined #openstack-nova | 13:07 | |
| *** cleong has joined #openstack-nova | 13:08 | |
| *** sree has quit IRC | 13:09 | |
| *** yamamoto has quit IRC | 13:09 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova stable/pike: Test InstanceNotFound handling in 'nova usage' https://review.openstack.org/499208 | 13:09 |
| *** huanxie has joined #openstack-nova | 13:11 | |
| *** esberglu has joined #openstack-nova | 13:11 | |
| *** pchavva has joined #openstack-nova | 13:11 | |
| *** ijw has joined #openstack-nova | 13:12 | |
| *** rtailor has quit IRC | 13:12 | |
| alex_xu | johnthetubaguy: yea, we are work on that together | 13:14 |
| *** catintheroof has joined #openstack-nova | 13:15 | |
| *** yangyapeng has joined #openstack-nova | 13:15 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Update the placement deployment instructions https://review.openstack.org/469048 | 13:15 |
| *** baoli has joined #openstack-nova | 13:16 | |
| *** moshele has joined #openstack-nova | 13:17 | |
| *** slaweq_ has quit IRC | 13:17 | |
| *** coreywright has quit IRC | 13:18 | |
| *** ijw has quit IRC | 13:18 | |
| *** lyan has quit IRC | 13:20 | |
| johnthetubaguy | alex_xu: cool, I was just thinking that spec didn't use the flavor extra specs mapping dansmith was talking about at the PTG | 13:22 |
| johnthetubaguy | alex_xu: I added comments on the spec anyways | 13:22 |
| *** sree has joined #openstack-nova | 13:23 | |
| *** slaweq_ has joined #openstack-nova | 13:24 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif stable/ocata: Updated from global requirements https://review.openstack.org/490256 | 13:25 |
| alex_xu | johnthetubaguy: yea, I just read that, thanks | 13:25 |
| *** mriedem has joined #openstack-nova | 13:26 | |
| *** alexchadin has joined #openstack-nova | 13:28 | |
| *** MVenesio has joined #openstack-nova | 13:28 | |
| stephenfin | cdent: Some more comments left on that patch from stuff I missed first go round. After those are addressed, I'm +2 | 13:29 |
| cdent | stephenfin: ✔ | 13:29 |
| *** coreywright has joined #openstack-nova | 13:32 | |
| *** yamahata has joined #openstack-nova | 13:32 | |
| *** trinaths1 has joined #openstack-nova | 13:33 | |
| *** jaosorior has quit IRC | 13:34 | |
| *** trinaths has quit IRC | 13:34 | |
| openstackgerrit | Alex Xu proposed openstack/nova-specs master: Add trait support in the allocation candidates API https://review.openstack.org/497713 | 13:35 |
| mdbooth | stephenfin: https://review.openstack.org/#/c/507488/2/nova/tests/unit/virt/libvirt/test_guest.py | 13:35 |
| *** gouthamr has joined #openstack-nova | 13:35 | |
| mdbooth | stephenfin: They won't be converted to byte strings? | 13:35 |
| mdbooth | I don't understand. | 13:35 |
| mdbooth | We don't need to convert anything to bytestring. | 13:35 |
| stephenfin | mdbooth: Isn't that what this is doing? https://review.openstack.org/#/c/507488/2/nova/virt/libvirt/guest.py | 13:36 |
| stephenfin | if they're unicode values, convert to bytestrings (str in Python 2.7) | 13:36 |
| openstackgerrit | Bhagyashri Shewale proposed openstack/nova master: Don't create instance backup image if rotation is 0 https://review.openstack.org/409644 | 13:36 |
| mdbooth | Not bytestrings, regular strings | 13:36 |
| mdbooth | But only for python2 | 13:36 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif stable/newton: Updated from global requirements https://review.openstack.org/373293 | 13:36 |
| mdbooth | We're not interested in what happens to bytestrings, because we don't expect to receive them | 13:37 |
| mdbooth | Just a sec, lemme dig out the libvirt python bindings again... | 13:37 |
| stephenfin | mdbooth: I'm using the wrong terminology so | 13:38 |
| *** edand has quit IRC | 13:38 | |
| alex_xu | johnthetubaguy: ^ try to address your comment | 13:38 |
| stephenfin | Whatever the default string type in Python3 is | 13:38 |
| stephenfin | *Python 2 | 13:38 |
| stephenfin | i.e. six.binary_type | 13:38 |
| mdbooth | stephenfin: The default string type in Python3 is unicode | 13:39 |
| mdbooth | Oh, python2 | 13:39 |
| mdbooth | It's not binary type | 13:39 |
| mdbooth | b'foo' != 'foo' | 13:39 |
| * mdbooth isn't sure what the difference actually is, though | 13:40 | |
| stephenfin | mdbooth: Yeah it is, in Python 3 | 13:40 |
| stephenfin | *Python 2 | 13:40 |
| stephenfin | dammit | 13:40 |
| mdbooth | Hehe | 13:40 |
| stephenfin | >>> b'test' == 'test' | 13:40 |
| stephenfin | True | 13:40 |
| mdbooth | Ah, so it is | 13:40 |
| mdbooth | In that case, we're already testing that, no? | 13:40 |
| stephenfin | In Python 2, 'str' == binary strings. In Python 3, 'str' == unicode strings | 13:40 |
| mdbooth | Because we're testing a bare string | 13:40 |
| *** smatzek has quit IRC | 13:41 | |
| alex_xu | johnthetubaguy: in the allocation_candidate API, we said the parameter named as 'requires', so I guess the extra spec should be "HW_CPU_X86_AVX=require", not the `required`? | 13:41 |
| stephenfin | mdbooth: Yeah, but you're not testing what passing a unicode string into 'migrate' does in Python 3 | 13:41 |
| stephenfin | *Python 2 | 13:41 |
| *** gbarros has quit IRC | 13:41 | |
| stephenfin | (I'm working on my laptop keyboard and keep missing 2) | 13:41 |
| johnthetubaguy | alex_xu: yeah, keeping those consistent would be a good idea | 13:41 |
| mdbooth | stephenfin: Yes we do, because the other test already does that | 13:41 |
| mdbooth | because in python 3 u'foo' == 'foo' | 13:41 |
| mdbooth | And we test 'foo' | 13:41 |
| openstackgerrit | Bhagyashri Shewale proposed openstack/nova master: Don't create instance backup image if rotation is 0 https://review.openstack.org/409644 | 13:41 |
| alex_xu | johnthetubaguy: cool, got it | 13:42 |
| *** huanxie has quit IRC | 13:42 | |
| mdbooth | stephenfin: So I actually wrote the test, and I changed 'v1' to be u'v1' | 13:42 |
| mdbooth | And asserted that's what we ended up with | 13:42 |
| mdbooth | Then I realised that they're the same thing | 13:42 |
| mdbooth | So actually I hadn't changed anything | 13:43 |
| stephenfin | mdbooth: But what about the other way round | 13:43 |
| stephenfin | If you called 'self.guest.migrate' with a "u'test'" param value | 13:43 |
| mdbooth | test_migrate_v3 already tests that | 13:43 |
| stephenfin | I'd expect the call to 'self.domain.migrateToURI3' to be called with "b'test'" | 13:44 |
| stephenfin | But only for Python 2 | 13:44 |
| mdbooth | test_migrate_v3_unicode tests that | 13:44 |
| * stephenfin celebrates his new-found ability to hit the 2 key | 13:44 | |
| mdbooth | Because it passes u'v1' and asserts 'v1' | 13:44 |
| stephenfin | Oh FFS | 13:44 |
| stephenfin | I read 'not six.PY2' as 'not six.PY3' | 13:44 |
| stephenfin | and thought that test was only for Python 3. Sorry! | 13:44 |
| mdbooth | HAHA, sorry! | 13:44 |
| mdbooth | -ESTUPIDNEGATIONS | 13:45 |
| stephenfin | :D | 13:45 |
| stephenfin | mdbooth: OK, let me give that one more spin through so. Sorry for the confusion :) | 13:45 |
| mdbooth | NP, thanks again | 13:46 |
| *** mlakat has quit IRC | 13:46 | |
| *** jpena|lunch is now known as jpena | 13:46 | |
| mdbooth | FWIW I wrote it that way because I way being anal. | 13:47 |
| mriedem | https://review.openstack.org/#/c/507938/ needs final +2, regression in pike | 13:47 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif stable/newton: Updated from global requirements https://review.openstack.org/373293 | 13:48 |
| mdbooth | mriedem: https://review.openstack.org/#/c/507202/ libvirt data corruptor since forever | 13:48 |
| * mdbooth got this as a customer bug, their migrations were being unexpectedly slow. After working it out we advised them to stop doing that... | 13:49 | |
| *** kfarr has quit IRC | 13:51 | |
| *** edand has joined #openstack-nova | 13:51 | |
| mriedem | mdbooth: ok i'm going to put a patch on top of that to test live block migration with something like this https://review.openstack.org/#/c/481290/ | 13:52 |
| mdbooth | mriedem: kk | 13:53 |
| *** bnemec has joined #openstack-nova | 13:53 | |
| kashyap | mriedem: Oh cool. Funnily enough, I was just checking an hour ago if we do (non-shared) live block migration in the Gate | 13:54 |
| mdbooth | Although the bug itself is really confined to the calling conventions of migrateToURI3 () | 13:54 |
| *** alex_xu has quit IRC | 13:54 | |
| *** gcb has quit IRC | 13:54 | |
| *** alex_xu has joined #openstack-nova | 13:54 | |
| mdbooth | We're going to have to backport it a long way, btw. | 13:54 |
| *** slaweq_ has quit IRC | 13:56 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: Run test_volume_backed_live_migration and iscsi test https://review.openstack.org/508163 | 13:56 |
| mriedem | ^ | 13:56 |
| *** belmoreira has quit IRC | 13:57 | |
| kashyap | Hmm, as an aside, seems like Nova cgit is out of sync with GitHub: | 13:57 |
| kashyap | https://github.com/openstack/nova/blob/master/nova/tests/live_migration/hooks/run_tests.sh | 13:57 |
| kashyap | http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/live_migration/hooks/run_tests.sh?id=068d851 | 13:57 |
| kashyap | Maybe /me should check w/ -infra | 13:58 |
| mriedem | mdbooth: if you plan on backporting this to essex, do we really need https://review.openstack.org/#/c/507488/ in the mix for the backports? | 13:58 |
| mriedem | you can't isolate that for your fix and backport, and then do ^ on top? | 13:58 |
| *** nikhil has joined #openstack-nova | 13:58 | |
| mdbooth | mriedem: I'll do that during the backport. IIRC it just poked a bug in a unit test. | 13:58 |
| dansmith | bauzas: wanna re-+W this after fixes were applied? | 13:58 |
| dansmith | https://review.openstack.org/#/c/498947/10 | 13:58 |
| mriedem | mdbooth: why not do it now? | 13:59 |
| mriedem | otherwise the stable reviewers have to figure out why there is a diff | 13:59 |
| mdbooth | Because it makes it messier upstream, and it's like a 1 line diff. | 13:59 |
| mdbooth | In a unit test. | 13:59 |
| mriedem | mdbooth: so when you say backport, you only mean internal backports? | 13:59 |
| mdbooth | I'll be doing both. | 14:00 |
| *** hemna_ has quit IRC | 14:00 | |
| mriedem | ok. so as a stable reviewer, why do i need to sort out this diff? just isolate the py3 thing into the fix patch for migrateToURI and do the more general thing on top | 14:00 |
| *** Yingxin has quit IRC | 14:01 | |
| mdbooth | You should read my backport commit messages :) They're immaculate. | 14:01 |
| *** awaugama has joined #openstack-nova | 14:01 | |
| *** yamahata has quit IRC | 14:01 | |
| dansmith | -1 | 14:02 |
| *** alex_xu has quit IRC | 14:02 | |
| *** gcb has joined #openstack-nova | 14:02 | |
| *** links has quit IRC | 14:02 | |
| openstackgerrit | Chris Dent proposed openstack/nova-specs master: Add spec for symmetric GET and PUT of allocations https://review.openstack.org/508164 | 14:03 |
| *** ijw has joined #openstack-nova | 14:03 | |
| *** belmoreira has joined #openstack-nova | 14:03 | |
| *** Yingxin has joined #openstack-nova | 14:03 | |
| *** slaweq_ has joined #openstack-nova | 14:03 | |
| mdbooth | mriedem: Incidentally, ever seen this bash-hackery: https://github.com/mdbooth/openstack-dev-hacks/blob/master/openstack.bash#L1-L4 | 14:04 |
| * mdbooth uses diffdiff a lot | 14:04 | |
| *** gbarros has joined #openstack-nova | 14:04 | |
| mriedem | bauzas: do you think you'll be able to get to https://review.openstack.org/#/c/507488/ today? if not, i can help clean it up | 14:05 |
| bauzas | dans | 14:06 |
| bauzas | dansmith: done | 14:06 |
| bauzas | mriedem: not sure I understand you, you mean me reviewing https://review.openstack.org/#/c/507488/ ? | 14:06 |
| *** slunkad has joined #openstack-nova | 14:06 | |
| dansmith | bauzas: thanks | 14:06 |
| mriedem | bauzas: oops, wrong patch | 14:06 |
| mriedem | bauzas: this one https://review.openstack.org/#/c/506093/ | 14:07 |
| bauzas | mriedem: FWIW, I'll have to bail out in 20 mins because I have to attend a Lyon OpenStack meetup (and btw. I'll miss today's nova meeting) | 14:07 |
| openstackgerrit | Alex Xu proposed openstack/nova-specs master: Request traits in Nova https://review.openstack.org/468797 | 14:07 |
| bauzas | mriedem: yeah I can fix that | 14:07 |
| bauzas | 20 mins is enough | 14:07 |
| *** artom has quit IRC | 14:07 | |
| *** jaosorior has joined #openstack-nova | 14:08 | |
| *** ijw has quit IRC | 14:08 | |
| *** crushil has joined #openstack-nova | 14:09 | |
| *** tidwellr has joined #openstack-nova | 14:09 | |
| mriedem | dansmith: what would be the best way to go about renaming the 'recreate' parameter in the rebuild_instance method in the compute manager, given rpc | 14:10 |
| *** Eran_Kuris has quit IRC | 14:11 | |
| mriedem | add an 'evacuate' kwarg? so we could eventually drop the recreate parameter in a major rpc versoin bump? | 14:11 |
| dansmith | mriedem: check the min version and send it the right way depending on what we're pinned to, | 14:11 |
| *** NostawRm has quit IRC | 14:11 | |
| dansmith | but you have to do the "if recreate or evacuate" logic in the top of the manager function, | 14:11 |
| dansmith | which will probably not improve confusion | 14:11 |
| dansmith | or, reduce | 14:12 |
| dansmith | you could just do this at the top of the manager: | 14:12 |
| mriedem | ok, alternatively i was just going to do: | 14:12 |
| mriedem | evacuate = recreate | 14:12 |
| dansmith | evacuate = recreate | 14:12 |
| dansmith | yeah | 14:12 |
| mriedem | and replace all usage of the variable | 14:12 |
| mriedem | ok | 14:12 |
| openstackgerrit | Ed Leafe proposed openstack/nova-specs master: Return Alternate Hosts https://review.openstack.org/504275 | 14:12 |
| edleafe | johnthetubaguy: ^^ hope this addresses your comments | 14:12 |
| *** smatzek has joined #openstack-nova | 14:13 | |
| *** sree has quit IRC | 14:13 | |
| bauzas | mriedem: not sure I get your comment on https://review.openstack.org/#/c/506093/4/nova/tests/functional/regressions/test_bug_1718455.py@135 | 14:15 |
| bauzas | mriedem: if the migration isn't done yet, we should fail the test right? | 14:15 |
| *** smatzek_ has joined #openstack-nova | 14:16 | |
| mriedem | bauzas: that code is waiting for the migration status to be 'running' | 14:16 |
| mriedem | which is not waiting for it to be done | 14:16 |
| bauzas | mriedem: so, s/running/done ? | 14:16 |
| mriedem | you'd have to see whatever status we set the migration to when it's done | 14:16 |
| *** alex_xu_ has joined #openstack-nova | 14:17 | |
| mriedem | completed | 14:17 |
| mriedem | is what is in _post_live_migrate in the compute manager | 14:17 |
| mriedem | *_post_live_migration | 14:17 |
| bauzas | ah, I understand | 14:17 |
| bauzas | so, when it's running, that means the migration is in progress | 14:17 |
| bauzas | my bad | 14:17 |
| mriedem | correcto | 14:18 |
| mriedem | hence the race | 14:18 |
| bauzas | okay, uploading | 14:18 |
| *** smatzek has quit IRC | 14:19 | |
| alex_xu_ | mriedem: gmann, jaypipes , next week is holiday in china, I will begin the vacation from tomorrow, so I won't active next week, probably just update spec when online since those two traits spec are very close. | 14:19 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Ensure instance can migrate when launched concurrently https://review.openstack.org/506093 | 14:20 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Update the placement deployment instructions https://review.openstack.org/469048 | 14:20 |
| mriedem | alex_xu_: ok | 14:20 |
| bauzas | alex_xu_: I was planning a spec review week, I could help you by providing new updates if you agree | 14:20 |
| cdent | stephenfin: good comments, but I decided to deny you the “that” because why not | 14:20 |
| alex_xu_ | bauzas: yea, sure, please free to update, appreciate the help! | 14:21 |
| bauzas | k | 14:22 |
| * bauzas runs off now | 14:22 | |
| jaypipes | alex_xu_: cool. you ok with me or bauzas updating? | 14:25 |
| jaypipes | alex_xu_: enjoy your vacation! :) | 14:26 |
| alex_xu_ | jaypipes: yes, sure, thanks! | 14:26 |
| *** moshele has quit IRC | 14:26 | |
| mdbooth | lyarwood: Just reviewing stable rescue spec for resubmission. Given that it seems we need to touch the api anyway, if you did it again would you make 'stable' an argument to the rescue rest api? | 14:27 |
| lyarwood | mdbooth: no, iirc the only api changes were a new microversion for the new behaviour right? | 14:27 |
| * mdbooth is just thinking it's a better user experience to do rescue --stable with your existing rescue image, rather than uploading a new one with some different image parameters | 14:28 | |
| mdbooth | The different image parameters would still be required if you wanted to change the bus though, I guess... | 14:29 |
| lyarwood | mdbooth: yeah I was about to say that they provide more than just turning it on and off, I'd keep that as the interface tbh and just add in the microversion | 14:29 |
| mdbooth | But in the main, I'd expect that 'add this regular root disk at the end and boot from it' would work, so the only user change would be --stable | 14:29 |
| mdbooth | And in fact, given that by default we use the original boot image as the rescue image... | 14:30 |
| mdbooth | We would enable the use case of no additional changes, just rescue --stable | 14:30 |
| *** cfriesen__ has joined #openstack-nova | 14:31 | |
| lyarwood | mdbooth: yeah, I still wouldn't but it's your baby now ;) | 14:32 |
| mdbooth | Hehe. It would be slightly simpler to leave it alone, of course. I just wonder if it wouldn't be easier for users. | 14:33 |
| *** rtjure has joined #openstack-nova | 14:35 | |
| johnthetubaguy | edleafe: great updates for the alternate hosts spec, just have a question on the follow up to gibi around things other than build | 14:35 |
| *** hongbin has joined #openstack-nova | 14:35 | |
| johnthetubaguy | edleafe: there are quite a few users of select_destinations, its worth having at least a note about the approach there | 14:36 |
| *** ijw has joined #openstack-nova | 14:36 | |
| openstackgerrit | sahid proposed openstack/nova master: pci: update PciDevice object field 'address' to accept NULL https://review.openstack.org/508175 | 14:36 |
| openstackgerrit | sahid proposed openstack/nova master: pci: add for PciDevice object new field mdev https://review.openstack.org/508176 | 14:36 |
| openstackgerrit | sahid proposed openstack/nova master: pci: generalize object unit-tests for different framework https://review.openstack.org/508177 | 14:36 |
| openstackgerrit | sahid proposed openstack/nova master: pci: add support for mdev device type request https://review.openstack.org/508178 | 14:36 |
| openstackgerrit | sahid proposed openstack/nova master: pci: generalize stats unit-tests for different framework https://review.openstack.org/508179 | 14:36 |
| openstackgerrit | sahid proposed openstack/nova master: pci: add support for mdev devices type devspec https://review.openstack.org/508180 | 14:36 |
| openstackgerrit | sahid proposed openstack/nova master: pci: add support for resource pool stats of mdev devices https://review.openstack.org/508181 | 14:36 |
| openstackgerrit | sahid proposed openstack/nova master: pci: make manager to accept handling mdev devices https://review.openstack.org/508182 | 14:36 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: update PCI node device to report mdev devices https://review.openstack.org/508183 | 14:36 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: report mdev resources https://review.openstack.org/508184 | 14:36 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: add support to start vm with using mdev (vGPU) https://review.openstack.org/508185 | 14:36 |
| openstackgerrit | sahid proposed openstack/nova master: functional: rework fakelibvirt host pci devices https://review.openstack.org/508186 | 14:36 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: resuse SRIOV funtional tests for MDEV devices https://review.openstack.org/508187 | 14:36 |
| *** slaweq_ has quit IRC | 14:37 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: What is the meaning of....recreate? https://review.openstack.org/508190 | 14:38 |
| mriedem | johnthetubaguy: edleafe: good point - note that the only other place we do reschedules is cold migrate/resize | 14:39 |
| *** dave-mccowan has quit IRC | 14:39 | |
| mriedem | evacuate, unshelve, live migration don't do the reschedule dance between compute and conductor, | 14:39 |
| mriedem | live migration does a reschedule dance of it's own, but that happens in super conductor | 14:39 |
| edleafe | johnthetubaguy: ok, but I'm not sure as to the depth you would like, beyond stating that the return from select_destinations will change | 14:39 |
| mriedem | edleafe: it's probably worth calling out (1) where we rely on reschedules and (2) that those paths will need to be aware of this change | 14:40 |
| mriedem | so build, resize/migrate, live migrate | 14:40 |
| *** spotz_ is now known as spotz | 14:40 | |
| mriedem | and we should probably be sure to have functional tests for hitting those reschedule flows | 14:40 |
| edleafe | mriedem: yeah - they'll need to adapt to handle the different return value, but they don't need to change what they do with it | 14:40 |
| mriedem | the good news is i think we already do have functional tests for reschedules with those 3 flows now | 14:41 |
| edleafe | they *can* change, but that's out of scope for this | 14:41 |
| mriedem | cdent: i thought you might like the philosophical tone of https://review.openstack.org/#/c/508190/ | 14:41 |
| cdent | heh | 14:41 |
| *** ijw has quit IRC | 14:42 | |
| cdent | “The meaning is, don't ask.” is my new bumper sticker, t-shirt, tattoo | 14:42 |
| -openstackstatus- NOTICE: The infra team is now taking Zuul v2 offline and bringing Zuul v3 online. Please see https://docs.openstack.org/infra/manual/zuulv3.html for more information, and ask us in #openstack-infra if you have any questions. | 14:42 | |
| cdent | this ^ is very exciting | 14:43 |
| *** mdnadeem has quit IRC | 14:44 | |
| *** dave-mccowan has joined #openstack-nova | 14:44 | |
| *** slaweq_ has joined #openstack-nova | 14:45 | |
| johnthetubaguy | edleafe: so saying its out of scope, and only minimal changes required to make the new interface work is OK I guess, but my concern is what mriedem said | 14:47 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Update the placement deployment instructions https://review.openstack.org/469048 | 14:47 |
| *** slunkad has quit IRC | 14:47 | |
| *** alexchadin has quit IRC | 14:48 | |
| mriedem | i don't know what 'can change' and 'out of scope' means here | 14:49 |
| mriedem | alternative hosts means, reschedules should work, yes? | 14:50 |
| *** vladikr has quit IRC | 14:50 | |
| johnthetubaguy | mriedem: well that way my initial take, I guess you could do builds first and other stuff second | 14:50 |
| mriedem | are we saying, we'll make build reschedules work, but resize reschedules won't? | 14:50 |
| mriedem | live migration reschedules are ok since they happen in super conductor | 14:51 |
| *** slunkad has joined #openstack-nova | 14:51 | |
| johnthetubaguy | well I was assuming that would be some follow up spec, but that does seem a bit silly to me | 14:51 |
| mriedem | it's the compute<>conductor action that is the problem i think | 14:51 |
| johnthetubaguy | yeah, live-migrate ones seem fine | 14:51 |
| edleafe | mriedem: I was concerned with the boiling the ocean type of spec | 14:52 |
| edleafe | mriedem: if you think it's wise, I can expand it to cover every use of select_destinations() | 14:52 |
| mriedem | edleafe: ok, but we also got into a lot of hot water late in pike because the claims in the scheduler stuff didn't take into account move operations | 14:52 |
| mriedem | so the main issue we're trying to solve is that the cell conductor can't reach the scheduler | 14:53 |
| mriedem | there are only 2 times that happens, | 14:53 |
| mriedem | build and resize | 14:53 |
| mriedem | live migrate reschedules happen in super condcutor which can reach the scheduler, so that's fine - you could make a note of it as something we know about and don't need to change | 14:53 |
| edleafe | mriedem: ok, I'll dig into resize, and add some stuff about that | 14:53 |
| johnthetubaguy | evacuate or shelve? not sure if they retry at all? | 14:53 |
| *** andreas_s_ has quit IRC | 14:53 | |
| *** Swami has joined #openstack-nova | 14:53 | |
| mriedem | johnthetubaguy: they don't | 14:53 |
| johnthetubaguy | OK | 14:53 |
| *** smatzek_ has quit IRC | 14:54 | |
| mriedem | prep_resize on the compute will call back to resize_instance in the conductor, which calls migrate_server, which calls the scheduler for a new destination | 14:54 |
| mriedem | so that is the flow, besides build, that has to also be fixed | 14:54 |
| johnthetubaguy | OK, so if its only two, we should do them together I think | 14:54 |
| mriedem | after 5 years working in nova, i think i finally have these conductor flows memorized | 14:54 |
| johnthetubaguy | they changed after I last did that | 14:55 |
| johnthetubaguy | and I slept since then | 14:55 |
| cdent | you sleep? | 14:55 |
| johnthetubaguy | yeah, I know, old school | 14:55 |
| *** tidwellr has quit IRC | 14:55 | |
| edleafe | mriedem: I don't know conductor flows that clearly, but that sounds like a very different problem than retries | 14:56 |
| johnthetubaguy | its the same compute -> wrong conductor right? | 14:56 |
| edleafe | mriedem: that sounds like the entire flow needs to change, and alternate hosts won't address that | 14:56 |
| *** slunkad has quit IRC | 14:56 | |
| johnthetubaguy | you replace a call to select_destinations to a claim the next candidate host right? | 14:57 |
| *** tbachman has quit IRC | 14:57 | |
| johnthetubaguy | (wibble passing the data through) | 14:57 |
| edleafe | johnthetubaguy: the call up happens before select_destinations, at least in mriedem's flow | 14:57 |
| mriedem | edleafe: it's essentially the same as the build flow | 14:57 |
| mriedem | just different methods | 14:57 |
| mriedem | compute:build_and_run_instances calls up to conductor:build_and_run_instances | 14:58 |
| mriedem | compute:prep_resize calls up to conductor:resize_instance | 14:58 |
| mriedem | both of those methods in the cell conductor eventually ask the scheduler for a new dest | 14:58 |
| edleafe | oh, you're talking about API-level compute, not cell compute | 14:58 |
| *** gyee has joined #openstack-nova | 14:58 | |
| dansmith | what is api-level compute? | 14:58 |
| *** hemna_ has joined #openstack-nova | 14:58 | |
| mriedem | edleafe: there is no such thing | 14:58 |
| *** MVenesio has quit IRC | 14:58 | |
| edleafe | mriedem: I didn't think so, but it sounded like you were | 14:59 |
| mriedem | https://docs.openstack.org/nova/pike/user/cellsv2_layout.html#multiple-cells | 14:59 |
| edleafe | the call up from compute isn't after select_destinations; it's before in a resize | 14:59 |
| mriedem | in ^ the compute only has access to the cell conductor | 14:59 |
| *** belmorei_ has joined #openstack-nova | 14:59 | |
| mriedem | i think we're talking about different things | 14:59 |
| edleafe | yes, we are - that's what I've been trying to say | 15:00 |
| *** belmoreira has quit IRC | 15:00 | |
| edleafe | alternate hosts just removes the need for a retry to have to call up from the cell | 15:00 |
| mriedem | resize flow is, summarized: api -> superconductor -> scheduler -> superconductor -> compute (reschedule) -> cell conductor -> compute (with alternate hosts) | 15:00 |
| mriedem | yes, in ^ we can't upcall from the cell conductor to the scheduler | 15:00 |
| edleafe | in your resize flow, the problem is that the call from the cell already is happening, and needs to change | 15:00 |
| mriedem | hence the need to pass the alternate hosts through | 15:00 |
| mriedem | for both build and resize | 15:00 |
| johnthetubaguy | https://github.com/openstack/nova/blob/8a386b055c82df67092a1abc683e7225ef80671e/nova/compute/manager.py#L3847 | 15:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Move allocation manipulation out of drop_move_claim() https://review.openstack.org/498947 | 15:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make allocation cleanup honor new by-migration rules https://review.openstack.org/498948 | 15:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Pre-create migration object https://review.openstack.org/498950 | 15:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949 | 15:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419 | 15:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420 | 15:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation https://review.openstack.org/507638 | 15:01 |
| *** hferenc has quit IRC | 15:01 | |
| johnthetubaguy | vs https://github.com/openstack/nova/blob/8a386b055c82df67092a1abc683e7225ef80671e/nova/compute/manager.py#L1880 | 15:02 |
| johnthetubaguy | seems the same flow | 15:02 |
| johnthetubaguy | i.e. +1 mriedem | 15:02 |
| *** vladikr has joined #openstack-nova | 15:03 | |
| johnthetubaguy | I guess its the second visit here that should not call the scheduler again: https://github.com/openstack/nova/blob/7cd9e3b8bb7fc0601786847f19cdf3f706ec079f/nova/conductor/tasks/migrate.py#L67 | 15:03 |
| mriedem | correct | 15:03 |
| mriedem | just like this one https://github.com/openstack/nova/blob/7cd9e3b8bb7fc0601786847f19cdf3f706ec079f/nova/conductor/manager.py#L552 | 15:04 |
| johnthetubaguy | ++ | 15:04 |
| mriedem | ^ is the build reschedule within the cell conductor | 15:04 |
| *** hemna_ has quit IRC | 15:05 | |
| edleafe | well, you've succeeded in completely confusing me as to what you want in the spec | 15:06 |
| *** smatzek_ has joined #openstack-nova | 15:07 | |
| *** dave-mcc_ has joined #openstack-nova | 15:07 | |
| *** sdague has quit IRC | 15:07 | |
| edleafe | Will it be enough to add that resize can also make use of the alternates? Or are there some other logical flows that need to be changed? | 15:08 |
| mriedem | i think that is enough | 15:08 |
| mriedem | and point out that live migration does reschedules, but within superconductor so we don't need to worry about those | 15:08 |
| *** dave-mccowan has quit IRC | 15:09 | |
| johnthetubaguy | edleafe: given the bits I just found out that doesn't do retries, I am +1 what mriedem just said | 15:09 |
| *** xyang1 has joined #openstack-nova | 15:11 | |
| edleafe | ok, I'll push another revision soon | 15:11 |
| *** MVenesio has joined #openstack-nova | 15:12 | |
| *** jaosorior has quit IRC | 15:12 | |
| *** Oku_OS is now known as Oku_OS-away | 15:13 | |
| *** huanxie has joined #openstack-nova | 15:15 | |
| *** tbachman has joined #openstack-nova | 15:18 | |
| *** slaweq_ has quit IRC | 15:18 | |
| *** gbarros has quit IRC | 15:19 | |
| *** gbarros has joined #openstack-nova | 15:21 | |
| *** psachin has quit IRC | 15:21 | |
| *** smatzek_ has quit IRC | 15:22 | |
| *** penick has joined #openstack-nova | 15:25 | |
| *** tbachman has quit IRC | 15:27 | |
| *** penick has quit IRC | 15:29 | |
| *** trinaths has joined #openstack-nova | 15:29 | |
| *** penick has joined #openstack-nova | 15:29 | |
| *** smatzek has joined #openstack-nova | 15:30 | |
| *** slaweq_ has joined #openstack-nova | 15:30 | |
| *** sridharg has quit IRC | 15:31 | |
| *** trinaths1 has quit IRC | 15:31 | |
| *** tbachman has joined #openstack-nova | 15:32 | |
| *** crushil has quit IRC | 15:34 | |
| *** crushil has joined #openstack-nova | 15:35 | |
| *** tssurya has quit IRC | 15:35 | |
| *** tbachman has quit IRC | 15:37 | |
| *** NostawRm has joined #openstack-nova | 15:37 | |
| *** trinaths has quit IRC | 15:37 | |
| *** READ10 has joined #openstack-nova | 15:38 | |
| *** hemna_ has joined #openstack-nova | 15:38 | |
| efried | jaypipes Any plan to include a "friendly name" or "description" field on resource provider? | 15:39 |
| jaypipes | efried: there already is. | 15:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce basic framework for security proxying https://review.openstack.org/345396 | 15:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce framework for RFB authentication https://review.openstack.org/345397 | 15:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce the VeNCrypt RFB authentication scheme https://review.openstack.org/345398 | 15:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: provide an RFB security proxy implementation https://review.openstack.org/345399 | 15:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Document TLS security setup for noVNC proxy https://review.openstack.org/500544 | 15:39 |
| * efried looks at the doc again... | 15:39 | |
| jaypipes | efried: https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handlers/resource_provider.py#L33 | 15:40 |
| efried | woot. | 15:40 |
| efried | I see it in the API doc now. Not sure how I missed it. | 15:40 |
| efried | Thanks. | 15:40 |
| *** trinaths has joined #openstack-nova | 15:40 | |
| jaypipes | efried: that's why the ProviderTree allows finding a provider by name or UUID... | 15:40 |
| efried | oh yeah. I should really get back to reviewing that series. | 15:40 |
| *** gjayavelu has joined #openstack-nova | 15:40 | |
| cdent | jaypipes, efried: we currently uniq on that name field, if I remember right, and that’s caused problems for some situations, should we change it? | 15:41 |
| * cdent locates bugh | 15:41 | |
| jaypipes | efried: hold off. pushing a new series of revisions after fixing up comments from gibi | 15:41 |
| efried | jaypipes rgr wilco | 15:41 |
| cdent | https://bugs.launchpad.net/nova/+bug/1714248 | 15:41 |
| openstack | Launchpad bug 1714248 in OpenStack Compute (nova) "Compute node HA for ironic doesn't work due to the name duplication of Resource Provider " [High,Confirmed] | 15:41 |
| *** tbachman has joined #openstack-nova | 15:41 | |
| jaypipes | cdent: you mean we're *not* unique? | 15:41 |
| *** ragiman has quit IRC | 15:42 | |
| * jaypipes doesn't see how uniqueness is a problem... | 15:42 | |
| * efried doesn't see how non-uniqueness would be a problem... | 15:42 | |
| efried | but no skin in the game. Reading bugh... | 15:42 |
| cdent | jaypipes: we enforce uniqueness on the name column | 15:42 |
| *** cfriesen__ is now known as cfriesen | 15:42 | |
| jaypipes | cdent: ah, great. that's good then. | 15:43 |
| cdent | jaypipes: which people are saying is bad | 15:43 |
| cdent | because they want to blue green a compute node or something | 15:43 |
| cdent | and names get in the way | 15:43 |
| efried | cdent Skimming this bug, it seems to me like the problem is that the compute service that's taking over should *not* be attempting to create a new RP. | 15:45 |
| *** yangyapeng has left #openstack-nova | 15:45 | |
| efried | It should be looking up and using the old one. | 15:45 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Ensure instance can migrate when launched concurrently https://review.openstack.org/506093 | 15:45 |
| mriedem | bauzas: ^ is all cleaned up now | 15:45 |
| cdent | efried: that would be one way to solve that particular problem | 15:45 |
| efried | Is the RP somehow associated with the compute process rather than the node(s) it's managing? | 15:45 |
| cfriesen | efried: do we ensure hypervisor host name uniqueness? | 15:46 |
| *** edmondsw has quit IRC | 15:46 | |
| *** huanxie has quit IRC | 15:46 | |
| *** rcernin has quit IRC | 15:46 | |
| cfriesen | efried: actually, I guess this is for ironic, so it's not even hypervisor, just host | 15:46 |
| cfriesen | or is there some other way to uniquely identify a host in ironic (I know nothing) | 15:46 |
| efried | Yeah, I don't know from ironic. Is it like, compute runs on the hypervisor and that represents a single possible instance? | 15:47 |
| *** crushil has quit IRC | 15:47 | |
| efried | (johnthetubaguy this conversation may interest you) | 15:47 |
| cfriesen | efried: I believe nova-compute represents a bunch of baremetal machines | 15:48 |
| efried | And that nova-compute could run on any one of several possible "hypervisors" that all "manage" that bunch of baremetal machines? | 15:49 |
| cfriesen | efried: so then the node where nova-compute is running crashes, and they want a different nova-compute process to take over managing those baremetal machines. | 15:49 |
| efried | Cool. So my question (cdent, johnthetubaguy): Why is there a RP associated with the nova-compute at all?? Seems like there should just be a RP per baremetal machine. | 15:49 |
| *** MVenesio has quit IRC | 15:50 | |
| *** gjayavelu has quit IRC | 15:50 | |
| cdent | efried: you’d think so, but no | 15:50 |
| cdent | a node has inventory of classes of baremetal | 15:50 |
| cdent | (last I recall, it’s hard to remember/keep straight) | 15:51 |
| cfriesen | efried: I think the idea is that each baremetal machine is a resource | 15:51 |
| cfriesen | or is several types of resource | 15:51 |
| *** belmorei_ has quit IRC | 15:51 | |
| cfriesen | since you always claim a whole machine at a time | 15:51 |
| efried | But but but... that would mean that every baremetal node in that nova-compute's purview is "identical". | 15:52 |
| *** chyka has joined #openstack-nova | 15:53 | |
| mriedem | johnthetubaguy: while you're awake, this is holding up the live migration new style volume attach change, and is simple https://review.openstack.org/#/c/506805/ | 15:53 |
| *** sahid has quit IRC | 15:53 | |
| cdent | efried: ironic’s virtdriver’s get_inventory may explain things a bit: https://github.com/openstack/nova/blob/ae4b5d0147cb3e345bf57034221e9c8fedf3cad2/nova/virt/ironic/driver.py#L751 | 15:56 |
| efried | cdent Was just looking at that. | 15:57 |
| efried | And was looking for the change jaypipes was going TODO. | 15:57 |
| cdent | i’m not sure, but I think you can different classes of baremental node, resprsented by multiple custom resource classes | 15:57 |
| efried | And was going to look for where the RP is set up, but not sure where to start looking for that. | 15:57 |
| openstackgerrit | Ed Leafe proposed openstack/nova-specs master: Return Alternate Hosts https://review.openstack.org/504275 | 15:58 |
| edleafe | mriedem: johnthetubaguy: ^^ | 15:58 |
| efried | cdent Yeah, sounds like that's where they're going, but haven't yet. | 15:58 |
| cdent | efried: edleafe did some further work on that chunk of code | 15:59 |
| johnthetubaguy | I am keen to help in the ironic scheduling side of things btw, trying to write up all the traits discussions | 15:59 |
| cfriesen | cdent: why wouldn't you follow efried's suggestion and have an RP per baremetal machine that reports resources for memory/disk/cpu? Then when you want to allocate a baremetal node you look for the smallest machine that can provide what you're looking for. | 16:00 |
| *** sbezverk has quit IRC | 16:01 | |
| *** armax has joined #openstack-nova | 16:01 | |
| *** sshwarts has quit IRC | 16:02 | |
| cfriesen | I suspect this has been discussed already, so if anyone has links to the discussion.... | 16:02 |
| *** slaweq_ has quit IRC | 16:02 | |
| efried | johnthetubaguy Yeah, I was just poring over your https://review.openstack.org/#/c/507052/2/specs/queens/approved/ironic-traits.rst | 16:02 |
| *** yassine has quit IRC | 16:02 | |
| efried | which is actually what led me down the rabbit hole and ultimately prompted this discussion :) | 16:03 |
| efried | Though the name conflict bug thing is a tangent-to-a-tangent... | 16:03 |
| johnthetubaguy | so for ironic, resource class matching, and requesting no VCPU,MEM, etc, is the current way forward I thought? | 16:03 |
| *** itlinux has joined #openstack-nova | 16:04 | |
| cfriesen | johnthetubaguy: this spec? https://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/node-resource-class.html | 16:04 |
| cfriesen | or maybe this one is more accurate: https://blueprints.launchpad.net/nova/+spec/custom-resource-classes-pike | 16:05 |
| johnthetubaguy | the later might be closer, but yeah, that support has all merged | 16:05 |
| cdent | cfriesen: sorry, in yet another meeting, so lost track of the discussion, will come back soon | 16:05 |
| *** slaweq_ has joined #openstack-nova | 16:06 | |
| cfriesen | cdent: no worries, just idly curious | 16:06 |
| johnthetubaguy | cfriesen: both actually are done I think | 16:06 |
| dansmith | cdent: either your new job comes with lots of extra meetings, or you enjoy and announce them more often | 16:07 |
| cdent | dansmith: these are all upstream meetings, I guess I’m just conscious lately of the extent to which they are distracting me from chatting with you | 16:08 |
| *** lyan has joined #openstack-nova | 16:08 | |
| dansmith | cdent: ah :) | 16:08 |
| *** takedakn has quit IRC | 16:08 | |
| efried | johnthetubaguy iiuc, you want to get rid of tracking CPU, memory, etc.; tag each of your nodes with some identifier; and then have your flavor just use that identifier? | 16:08 |
| johnthetubaguy | efried: so I thought the CPU memory, etc tracking was all going in queens, regardless? | 16:09 |
| efried | "going into queens" or "going away in queens" ? | 16:09 |
| johnthetubaguy | going away in queens | 16:09 |
| johnthetubaguy | oops, missed the important word there | 16:09 |
| cfriesen | efried: there's an interesting short email chain here: https://openstack.nimeyo.com/91493/openstack-dev-ironic-nova-indivisible-resource-providers | 16:09 |
| *** trinaths has quit IRC | 16:10 | |
| efried | johnthetubaguy I assume that's just an ironic statement | 16:10 |
| efried | I honestly know nothing about ironic, learning as I go in the context of this chat. | 16:10 |
| johnthetubaguy | that's what the comment in the Nova code was saying, based on plan A for Nova I believe? | 16:10 |
| * johnthetubaguy finds code... | 16:11 | |
| johnthetubaguy | https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L758 | 16:11 |
| johnthetubaguy | ironic resources are indivisable | 16:11 |
| johnthetubaguy | custom resource classes model that nicely | 16:12 |
| efried | Right, so the point will be to have a custom resource class representing a "kind" of node, such that any node associated with that resource class is effectively "identical" to any other. | 16:12 |
| johnthetubaguy | well, "identical" from the point of view of the flavor | 16:13 |
| johnthetubaguy | you might have several generations mapped to a single resource class, if you want | 16:13 |
| efried | Right. And you're modeling the compute process as the resource *provider* of the resources of the various classes it can see. | 16:13 |
| *** gbarros has quit IRC | 16:13 | |
| efried | (What do we call the thing the compute process runs on? The "hypervisor"?) | 16:13 |
| johnthetubaguy | no, the resource provider is the ironic node uuid in Ironic | 16:14 |
| efried | Where "node" isn't the baremetal machine, it's the thing that manages 'em, right? | 16:14 |
| johnthetubaguy | nova-compute process manages multiple ironic nodes (that list varies depending on the hash ring, hence the bug) | 16:14 |
| johnthetubaguy | so the host is nova-compute | 16:14 |
| efried | ayee | 16:14 |
| efried | Terminology fail. | 16:15 |
| johnthetubaguy | the node is the ironic node | 16:15 |
| johnthetubaguy | the node is the resource provider | 16:15 |
| *** itlinux has quit IRC | 16:15 | |
| cdent | nova-compute hosts multiple ironic nodes, each of which have an inventory of customr resource class with count of 1 | 16:15 |
| cdent | (my memory is starting to refresh) | 16:15 |
| johnthetubaguy | +1 cdent | 16:15 |
| efried | But some of those ironic nodes can be using the same resource class, if they're functionally "identical" | 16:16 |
| efried | ? | 16:16 |
| cdent | yes | 16:16 |
| efried | So it would seem like, as part of the failover process, the host that's taking over ought to delete the RP for the failed host. | 16:17 |
| *** armax has quit IRC | 16:17 | |
| johnthetubaguy | yeah, each is offering 1: CUSTOM_GOLD | 16:17 |
| efried | Seems like that ought to happen regardless, otherwise the scheduler will think it's still there and may try to schedule stuff to it. | 16:17 |
| *** gbarros has joined #openstack-nova | 16:17 | |
| johnthetubaguy | so for that bug | 16:17 |
| efried | yeah, for that bug | 16:17 |
| *** Apoorva has joined #openstack-nova | 16:17 | |
| *** Apoorva has quit IRC | 16:17 | |
| johnthetubaguy | the dead thing would normally be responsible for the delete of it | 16:17 |
| efried | That... doesn't make sense. It's dead. It can't call the placement API. | 16:17 |
| johnthetubaguy | right, that's the problem | 16:18 |
| *** Apoorva has joined #openstack-nova | 16:18 | |
| efried | At some level, the new guy must know he's taking over for the old guy. | 16:18 |
| efried | So why can't he delete the old guy's RP? | 16:18 |
| johnthetubaguy | not sure if it sees that edge | 16:18 |
| johnthetubaguy | it just sees a new node right now | 16:18 |
| johnthetubaguy | but not 100% sure on that | 16:19 |
| efried | Well. | 16:19 |
| *** corey_ has joined #openstack-nova | 16:19 | |
| efried | Is there a split-brain possibility here? | 16:19 |
| cfriesen | johnthetubaguy: for virtual machines (like with a vmware backend) nova-compute runs on the "node", and the hypervisor runs on the "host", right? why did ironic reverse the naming? | 16:19 |
| *** cleong has quit IRC | 16:20 | |
| dansmith | cfriesen: no, the reverse | 16:21 |
| dansmith | cfriesen: but vmware doesn't actually run like that | 16:21 |
| dansmith | (anymore) | 16:21 |
| dansmith | well, | 16:21 |
| dansmith | it doesn't expose a 1:N host:node structure I mean | 16:22 |
| dansmith | it still runs external I think, but... | 16:22 |
| dansmith | cfriesen: nova-compute always runs on the "host" which is where the service record is (nova-compute being a service) and the "node" is the actual hypervisor | 16:23 |
| dansmith | ironic runs one nova-compute for multiple "hypervisor" nodes, which can't by definition run the service on them | 16:23 |
| dansmith | ironic is the _reason_ we have that (blasted) model so it's setting the standard, not doing something reverse of what the model was designed for | 16:24 |
| cfriesen | dansmith: got it, thanks. wonder where I got flipped around. | 16:27 |
| dansmith | cfriesen: it's unfortunately very convoluted for little gain :( | 16:28 |
| *** itlinux has joined #openstack-nova | 16:29 | |
| *** lpetrut has quit IRC | 16:30 | |
| cfriesen | so how does "compute_node = self._get_compute_info(context, self.host)" make any sense then, if there could be multiple compute nodes per host? | 16:30 |
| dansmith | cfriesen: is that in the resource tracker? | 16:30 |
| cfriesen | nova/compute/manager.py | 16:31 |
| dansmith | cfriesen: oh, look at the function | 16:31 |
| dansmith | cfriesen: it returns the first | 16:31 |
| dansmith | "for old compat" | 16:32 |
| dansmith | and since ironic doesn't support live migration...YET | 16:32 |
| *** ralonsoh has quit IRC | 16:33 | |
| *** manasm has joined #openstack-nova | 16:35 | |
| *** Swami has quit IRC | 16:36 | |
| *** edand has quit IRC | 16:37 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: set/check if inventory change in tree https://review.openstack.org/470575 | 16:38 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: integrate ProviderTree to report client https://review.openstack.org/415921 | 16:38 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138 | 16:38 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215 | 16:38 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 16:38 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 16:38 |
| *** slunkad has joined #openstack-nova | 16:40 | |
| *** slaweq_ has quit IRC | 16:42 | |
| mriedem | stvnoyes: the multinode live migration grenade job failed on your live migration new style attach patch, but it failed here http://logs.openstack.org/87/463987/20/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/ae8875f/logs/subnode-2/screen-n-cpu.txt.gz?level=TRACE#_Sep_26_14_28_11_637958 | 16:43 |
| mriedem | and looking at logstash, that happens on a ton of patches, so it's probably just a 100% failure in that job right now | 16:43 |
| dansmith | jaypipes: I'm missing the reasoning for the complicated "compare two dicts" method in that first patch | 16:43 |
| *** penick has quit IRC | 16:44 | |
| *** karts has joined #openstack-nova | 16:44 | |
| jaypipes | dansmith: yeah, it's a long conversation on previous revisions... I'm going to change it to only compare the total field value and ignore the other things like reserved/min_unit/allocation_ratio, etc | 16:44 |
| dansmith | jaypipes: oh, sorry I can re-read.. but, is this not to be used for "know when I need to report new inventory" sort of thing? | 16:45 |
| jaypipes | dansmith: the reason it's like that is because we still don't have any consistency and agreement on who (virt driver or resource tracker) owns various fields about the inventory like alloc ratio etc | 16:45 |
| *** alex_xu_ has quit IRC | 16:45 | |
| efried | dansmith The history is here: https://review.openstack.org/#/c/470575/2/nova/compute/provider_tree.py@98 | 16:45 |
| dansmith | jaypipes: ah, to avoid us reporting new just because the virt driver thinks the allocation_ratio should be different? | 16:46 |
| jaypipes | yup | 16:46 |
| dansmith | hmm | 16:47 |
| dansmith | the virt driver needs to report total and reserved | 16:47 |
| *** karthiks has quit IRC | 16:47 | |
| dansmith | but allocation_ratio is clearly the purview of the compute manager | 16:47 |
| dansmith | min_unit is probably virt driver I guess | 16:47 |
| dansmith | taking the scaleio example of 8GB minimum slice or whatever | 16:48 |
| *** penick has joined #openstack-nova | 16:48 | |
| *** cdent has quit IRC | 16:49 | |
| mriedem | stvnoyes: yeah the grenade live migration job is just totally busted http://tinyurl.com/y9ca6zox | 16:51 |
| mriedem | something changed in august http://tinyurl.com/yby7m5p8 | 16:51 |
| stvnoyes | that's pretty bad | 16:52 |
| efried | johnthetubaguy jaypipes Where does ironic (or ftm any virt driver) set up its resource providers today? | 16:53 |
| jaypipes | efried: it doesn't. the RT does. | 16:53 |
| jaypipes | efried: because there's only one RP. | 16:54 |
| mriedem | stvnoyes: looking at http://logs.openstack.org/87/463987/20/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/ae8875f/console.html#_2017-09-26_14_28_03_894125 | 16:54 |
| efried | jaypipes In ironic, only one RP per compute host? Not one RP per ironic node? | 16:54 |
| mriedem | tempest.api.compute.admin.test_live_migration.LiveAutoBlockMigrationV225Test.test_live_block_migration [22.911966s] ... ok | 16:54 |
| mriedem | tempest.api.compute.admin.test_live_migration.LiveAutoBlockMigrationV225Test.test_live_block_migration [22.911966s] ... ok | 16:54 |
| mriedem | oops | 16:54 |
| jaypipes | efried: we want to get to where there is a sort of mediation/negotiation between the RT and the virt driver and the generic device manager as each of them "processes" the ProviderTree and sets inventory records and traits based on their own information. | 16:55 |
| mriedem | tempest.api.compute.admin.test_live_migration.LiveMigrationTest.test_live_block_migration [10.052345s] ... FAILED | 16:55 |
| mriedem | so it works with the 2.25 microversion, where we pass block_migration=auto | 16:55 |
| mriedem | but fails before that | 16:55 |
| jaypipes | efried: in ironic, each baremetal Ironic node is its own RP in placementy. | 16:55 |
| mriedem | so i bet something with the auto changes broke how we do live block migration between n-1 hosts | 16:55 |
| *** kenperkins has quit IRC | 16:56 | |
| *** derekh has quit IRC | 16:56 | |
| stvnoyes | what were the auto changes? | 16:56 |
| efried | jaypipes Aha. Then bug 1714248 exists because... the compute host is creating its own separate RP for some reason? | 16:56 |
| openstack | bug 1714248 in OpenStack Compute (nova) "Compute node HA for ironic doesn't work due to the name duplication of Resource Provider " [High,Confirmed] https://launchpad.net/bugs/1714248 | 16:56 |
| jaypipes | efried: not sure, lemme read | 16:56 |
| *** crushil has joined #openstack-nova | 16:56 | |
| efried | oh, or because the RT is trying to create a new RP for the node it's taking over... | 16:57 |
| jaypipes | efried: note that nova-compute was *never* intended for "HA setups"... | 16:57 |
| mriedem | stvnoyes: https://docs.openstack.org/nova/pike/reference/api-microversion-history.html#maximum-in-mitaka | 16:57 |
| *** vks1 has joined #openstack-nova | 16:57 | |
| mriedem | ^ predates the spike in failures though, which started around 8/18 | 16:57 |
| efried | ...And that's out of the control of ironic-specific code... | 16:57 |
| efried | which is why my comment #5 is a non-starter | 16:58 |
| efried | until, as you say, there's some coordination between RT and virt to manage the RPs. | 16:58 |
| stvnoyes | mriedem: brb- grabbing lunch | 16:59 |
| *** baoli has quit IRC | 17:00 | |
| mriedem | stvnoyes: ok. it also fails on the pike compute... | 17:00 |
| *** baoli has joined #openstack-nova | 17:01 | |
| *** MVenesio has joined #openstack-nova | 17:02 | |
| johnthetubaguy | efried: I have to head out now and cook my dinner, but I think this maps nicely to how we setup traits, I am leaning towards ironic doing things in placement | 17:04 |
| efried | johnthetubaguy Okay. I've got a passel of draft comments on your spec, which should be ready for your perusal next time you're on. | 17:05 |
| johnthetubaguy | cool, thanks | 17:05 |
| dansmith | jaypipes: in the db migration, why aren't we referencing the parent provider by id instead of uuid? | 17:06 |
| dansmith | jaypipes: and, isn't recording the root just going to limit us later when we need to restructure a tree? | 17:06 |
| efried | johnthetubaguy (Looking back over 'em, removing the ones we've talked about in here, the only things left are typos ): | 17:06 |
| jaypipes | dansmith: a good question on the parent provider UUID thing. not entirely sure why I did that. | 17:07 |
| *** Swami has joined #openstack-nova | 17:09 | |
| dansmith | jaypipes: I can't tell you how elated I feel -1ing a db schema change of yours for performance reasons | 17:09 |
| jaypipes | dansmith: recording the root is an optimization to avoid needing to do hierarchical queries. and we don't restructure the root, only potentially children within the tree (in other words, root_provider_id won't change. | 17:09 |
| jaypipes | dansmith: :) | 17:09 |
| dansmith | jaypipes: right, it won't for compute nodes, but it could for other types of resources | 17:10 |
| dansmith | jaypipes: like you move a disk shelf from one NAS device to another | 17:10 |
| jaypipes | dansmith: possibly, sure, but those kinds of moves are few and far between in comparison to the 10 or 100 times as many read requests for tree data | 17:11 |
| *** claudiub|3 has quit IRC | 17:11 | |
| dansmith | hmm | 17:11 |
| dansmith | jaypipes: well, I commented for later | 17:13 |
| jaypipes | okey dokey | 17:13 |
| dansmith | jaypipes: I haven't gotten to how we tell placement about our parent, but presumably we're forbidden from trying to reparent a first-level provider? | 17:14 |
| jaypipes | dansmith: haven't gotten to that either. | 17:15 |
| dansmith | jaypipes: also, in case you're wondering | 17:15 |
| dansmith | jaypipes: yes, it's amazingly beautiful out here on the deck... 71F and clear skies | 17:16 |
| *** baoli has quit IRC | 17:16 | |
| jaypipes | dansmith: lol | 17:16 |
| *** gjayavelu has joined #openstack-nova | 17:17 | |
| *** sambetts is now known as sambetts|afk | 17:17 | |
| *** nikhil has quit IRC | 17:18 | |
| *** baoli has joined #openstack-nova | 17:24 | |
| *** karts has quit IRC | 17:25 | |
| openstackgerrit | Ed Leafe proposed openstack/nova-specs master: Return Alternate Hosts https://review.openstack.org/504275 | 17:26 |
| *** Guest93 has joined #openstack-nova | 17:27 | |
| *** Apoorva_ has joined #openstack-nova | 17:30 | |
| *** esberglu has quit IRC | 17:31 | |
| *** baoli has quit IRC | 17:32 | |
| *** huanxie has joined #openstack-nova | 17:32 | |
| *** baoli has joined #openstack-nova | 17:32 | |
| mriedem | stvnoyes: aha | 17:32 |
| mriedem | it's a ci job configuration issue | 17:32 |
| mriedem | the nodes are configured differently for block migration | 17:33 |
| *** Apoorva has quit IRC | 17:33 | |
| *** manasm has quit IRC | 17:36 | |
| stvnoyes | mriedem: that's good to hear. much better than a code/upgrade issue. | 17:36 |
| mriedem | i'm pretty sure i've had to fix this before... | 17:36 |
| *** karts has joined #openstack-nova | 17:38 | |
| *** vks1 has quit IRC | 17:42 | |
| *** eandersson has joined #openstack-nova | 17:44 | |
| eandersson | Is versioned notifications properly implemented in Mitaka? We don't see any versioned notifications being sent. | 17:44 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Use improved instance_list module in compute API https://review.openstack.org/505418 | 17:44 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Fix CellDatabases fixture swallowing exceptions https://review.openstack.org/506312 | 17:44 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416 | 17:44 |
| *** esberglu has joined #openstack-nova | 17:45 | |
| *** lpetrut has joined #openstack-nova | 17:46 | |
| *** jpena is now known as jpena|off | 17:47 | |
| *** manasm has joined #openstack-nova | 17:50 | |
| *** itlinux has quit IRC | 17:51 | |
| *** itlinux has joined #openstack-nova | 17:53 | |
| *** baoli has quit IRC | 17:56 | |
| mriedem | eandersson: probably not at that point | 17:56 |
| *** baoli has joined #openstack-nova | 17:57 | |
| mriedem | introduced in newton https://specs.openstack.org/openstack/nova-specs/specs/newton/implemented/versioned-notification-transformation-newton.html | 17:57 |
| mriedem | the framework code was in mitaka | 17:57 |
| eandersson | I see - thanks mriedem | 17:58 |
| *** Guest93 has quit IRC | 18:01 | |
| *** edmondsw has joined #openstack-nova | 18:01 | |
| *** huanxie has quit IRC | 18:02 | |
| *** edmondsw has quit IRC | 18:04 | |
| *** edmondsw has joined #openstack-nova | 18:04 | |
| *** manasm has quit IRC | 18:04 | |
| *** baoli has quit IRC | 18:07 | |
| *** Apoorva_ has quit IRC | 18:09 | |
| *** Apoorva has joined #openstack-nova | 18:10 | |
| *** baoli has joined #openstack-nova | 18:10 | |
| *** tssurya has joined #openstack-nova | 18:10 | |
| mriedem | mtreinish: do you know anything about how tempest is upgraded in grenade? | 18:11 |
| mtreinish | mriedem: it's not, the code and config should be the same between versions | 18:12 |
| sean-k-mooney | mriedem: i taught tempest was not upgreaed in grenade because it was not ment to be version specific | 18:12 |
| mtreinish | everything should be master for tempest | 18:12 |
| mriedem | mtreinish: the config is different between pike and queens | 18:12 |
| mtreinish | mriedem: links? | 18:12 |
| mriedem | at least in this multinode grenade job | 18:12 |
| mriedem | http://logs.openstack.org/87/463987/20/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/ae8875f/logs/old/tempest_conf.txt.gz | 18:12 |
| mriedem | ^ pike | 18:12 |
| mriedem | note: block_migration_for_live_migration = True | 18:12 |
| mriedem | http://logs.openstack.org/87/463987/20/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/ae8875f/logs/new/tempest_conf.txt.gz | 18:13 |
| mriedem | queens ^ | 18:13 |
| sean-k-mooney | mriedem: the config is likely different yes but it should be useing the same tempest version | 18:13 |
| mriedem | block_migration_for_live_migration = False | 18:13 |
| mriedem | the config is supposed to be copied from old to new https://github.com/openstack-dev/grenade/blob/master/upgrade-tempest#L82 | 18:13 |
| mriedem | looks like that is happening here http://logs.openstack.org/87/463987/20/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/ae8875f/logs/grenade.sh.txt.gz#_2017-09-26_14_23_46_489 | 18:14 |
| mtreinish | mriedem: yeah I don't know why that's being switched or where that's happening | 18:14 |
| sean-k-mooney | is devstack regenerating the config on the second run and overriting it? | 18:15 |
| mriedem | old tempest.conf gets it set here http://logs.openstack.org/87/463987/20/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/ae8875f/logs/grenade.sh.txt.gz#_2017-09-26_13_58_48_782 | 18:15 |
| mtreinish | sean-k-mooney: config should just be copied from old devstack | 18:16 |
| mtreinish | that's how grenade is supposed to work | 18:16 |
| mtreinish | unless it's explicitly changed in the upgrade script | 18:16 |
| mtreinish | which is not something we approve lightly because that means a manual upgrade step | 18:16 |
| sean-k-mooney | mtreinish: yes but devstack generate a new tempest config by default when run so if grenage is reusing that logic it may be chagining it just a guess. you know more about this then i | 18:17 |
| mtreinish | sean-k-mooney: we don't run new devstack | 18:17 |
| sean-k-mooney | ah ok cool | 18:17 |
| *** mnestratov has quit IRC | 18:18 | |
| mriedem | mtreinish: note this is multinode | 18:18 |
| mriedem | so devstack does run on the subnode | 18:18 |
| mriedem | but the subnode is just | 18:18 |
| mriedem | ENABLED_SERVICES=c-bak,c-vol,ceilometer-acompute,dstat,g-api,n-cpu,peakmem_tracker,placement-client,q-agt | 18:18 |
| mtreinish | mriedem: right and we don't run tempest on the subnode | 18:18 |
| dansmith | mriedem: is there some reason tonyb didn't +W this? https://review.openstack.org/#/c/506760/ | 18:19 |
| dansmith | if not, I'll do it | 18:19 |
| mriedem | dansmith: i assume b/c the change wasn't merged yet on master | 18:19 |
| mtreinish | so even if it was generating a config that shouldn't be coming into play | 18:19 |
| mriedem | er pike | 18:19 |
| dansmith | mriedem: okay but it is now, so good I think? | 18:19 |
| mriedem | yes it's merged on pike | 18:19 |
| openstackgerrit | Jan Zerebecki proposed openstack/nova master: Fix wording of debug message for future releases https://review.openstack.org/508261 | 18:19 |
| openstackgerrit | Jan Zerebecki proposed openstack/nova master: Only log not correcting allocation once per period https://review.openstack.org/508262 | 18:19 |
| *** itlinux has quit IRC | 18:20 | |
| mriedem | mtreinish: found it | 18:22 |
| mriedem | shite | 18:22 |
| mriedem | http://logs.openstack.org/87/463987/20/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/ae8875f/logs/devstack-gate-post_test_hook.txt.gz#_2017-09-26_14_26_36_364 | 18:23 |
| mriedem | it's the gd post-test hook for the live migration job setup in nova | 18:23 |
| mtreinish | mriedem: hah, ok I was looking for plugins and there weren't any. But that makes more sense | 18:23 |
| mriedem | https://github.com/openstack/nova/blob/ae4b5d0147cb3e345bf57034221e9c8fedf3cad2/nova/tests/live_migration/hooks/run_tests.sh#L33 | 18:24 |
| mriedem | aha https://github.com/openstack/nova/blob/ae4b5d0147cb3e345bf57034221e9c8fedf3cad2/nova/tests/live_migration/hooks/run_tests.sh#L52 | 18:24 |
| mriedem | gdi | 18:24 |
| mriedem | oh f me | 18:24 |
| mriedem | # TODO(mriedem): Remove this in Queens if we haven't fixed the bug yet. | 18:24 |
| mtreinish | haha, nice | 18:25 |
| mriedem | well i think that's for live migration with ceph shared storage, so probably not the actual thing i'm trying to fix, but still | 18:27 |
| mtreinish | mriedem: do you want that block_migration flag to be true or false? | 18:28 |
| mriedem | it needs to be true | 18:28 |
| mriedem | but hold up | 18:28 |
| mriedem | i'm confused as to where the post-test-hook is called | 18:29 |
| mtreinish | mriedem: it's called in devstack gate | 18:29 |
| mtreinish | the second tempest run is done by devstack gate instead of grenade | 18:30 |
| *** baoli has quit IRC | 18:30 | |
| mtreinish | and looking at that post test hook code you're telling devstack gate to not run tempest, so the hook can modify the tempest config and run it itself | 18:30 |
| mriedem | the reason the hook is setting block_migration=False is because the tests that come after that are for shared storage (nfs and ceph) | 18:31 |
| *** Guest93 has joined #openstack-nova | 18:31 | |
| mriedem | so i'm confused as to why that's configuring tempest before the tests are run | 18:31 |
| mriedem | because i can see from the failed tempest log, that tempest is passing block_migration=False b/c that's what's in the config | 18:32 |
| mriedem | starts running here http://logs.openstack.org/87/463987/20/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/ae8875f/console.html#_2017-09-26_14_25_30_596259 | 18:32 |
| mriedem | at that point, things pass | 18:33 |
| mriedem | http://logs.openstack.org/87/463987/20/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/ae8875f/console.html#_2017-09-26_14_26_36_296539 | 18:34 |
| mriedem | oh ffs | 18:34 |
| *** tbachman has quit IRC | 18:34 | |
| mriedem | it is the branch thing | 18:34 |
| *** baoli has joined #openstack-nova | 18:34 | |
| mriedem | it passes the first run with live block migration, and then fails the ceph one | 18:34 |
| mriedem | presumably because we just suck with ceph still | 18:35 |
| *** itlinux has joined #openstack-nova | 18:36 | |
| sean-k-mooney | mriedem: right so it failing later here http://logs.openstack.org/87/463987/20/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/ae8875f/console.html#_2017-09-26_14_28_50_096937 | 18:36 |
| mriedem | well, so bug 1691769 isn't a problem anymore | 18:39 |
| openstack | bug 1691769 in OpenStack Compute (nova) "gate-grenade-dsvm-neutron-multinode-live-migration-nv fails in pike: "Failed to restart <email address hidden>: Unit <email address hidden> not found."" [Medium,Triaged] https://launchpad.net/bugs/1691769 | 18:39 |
| *** avolkov has quit IRC | 18:39 | |
| *** smatzek has quit IRC | 18:41 | |
| mtreinish | email address hidden? | 18:42 |
| *** crushil_ has joined #openstack-nova | 18:42 | |
| mtreinish | hah systemd units | 18:42 |
| *** smatzek has joined #openstack-nova | 18:42 | |
| mriedem | aha | 18:43 |
| mriedem | another discovery | 18:43 |
| mriedem | which dansmith might remember | 18:43 |
| mriedem | grenade runs in singleconductor more | 18:43 |
| mriedem | *mode | 18:43 |
| mriedem | but, | 18:43 |
| mriedem | this live migration test hook is configuring /etc/nova/nova-cpu.conf | 18:44 |
| mriedem | http://logs.openstack.org/87/463987/20/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/ae8875f/logs/subnode-2/etc/nova/nova-cpu.conf.txt.gz | 18:44 |
| mriedem | and it's not running with that one | 18:44 |
| mriedem | ['--config-file', '/etc/nova/nova.conf'] | 18:44 |
| mriedem | Ibc4b21089ef86ab2430874c39d63174528c9a83e | 18:46 |
| *** smatzek has quit IRC | 18:46 | |
| sean-k-mooney | right its doing that here http://logs.openstack.org/87/463987/20/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/ae8875f/console.html#_2017-09-26_14_27_39_368886 and running and here its using /etc/nova/nova.conf http://logs.openstack.org/87/463987/20/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/ae8875f/console.html#_2017-09-26_14_27_56_301409 | 18:47 |
| mriedem | yup, the issue is that https://review.openstack.org/#/c/458537/ isn't aware of grenade being singleconductor | 18:48 |
| mriedem | because, jesus, live migration + grenade + superconductor...crazy | 18:48 |
| *** smatzek has joined #openstack-nova | 18:48 | |
| sean-k-mooney | so the fix is the run nova-compute with /etc/nova/nova-cpu.conf ? | 18:52 |
| mriedem | no | 18:52 |
| *** smatzek has quit IRC | 18:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix live migration grenade ceph setup https://review.openstack.org/508271 | 18:55 |
| mriedem | i think this is the fix ^ | 18:55 |
| sean-k-mooney | hum that should work however it may be better to always use a seperate config for nova compute so that it does not chage regardless of the config. | 18:58 |
| mriedem | i don't think zuul is running any jobs right now though so, i guess we'll find out later | 18:58 |
| mriedem | sean-k-mooney: oh i'm sure this is air tight and will never require changes again :) | 18:58 |
| *** moshele has joined #openstack-nova | 18:58 | |
| sean-k-mooney | :) | 18:58 |
| *** MVenesio has quit IRC | 18:59 | |
| sean-k-mooney | by the way https://github.com/openstack/nova/search?utf8=%E2%9C%93&q=TODO%28+Queens&type= that was not the only todo with remove in queens ... | 18:59 |
| *** mvk has joined #openstack-nova | 18:59 | |
| sean-k-mooney | stephenfin: i belive this one is all yours https://github.com/openstack/nova/blob/762c89f85a4aeceb7bed5e80edc70a239872b757/nova/cmd/manage.py#L141 | 19:00 |
| tssurya | mriedem, dansmith, melwitt : random off-topic : saw the nova cellv2 meeting logs from yesterday, so sorry I could not attend (was afk due to bad time zone timings) it and for wasting some precious seconds during the meeting; but thanks for the ping. Also from next time I will keep you posted earlier on if I am not attending. | 19:01 |
| sean-k-mooney | wait i just confused myself queens comes after pike... | 19:01 |
| dansmith | tssurya: not a problem and no need to keep us notified of your schedule, I just made a point of pinging you because we had fooled you with our hangout the week prior | 19:01 |
| melwitt | no worries tssurya. yep, what dansmith said | 19:02 |
| *** itlinux has quit IRC | 19:02 | |
| tssurya | dansmith, melwitt : cool :) thanks! | 19:02 |
| *** gbarros has quit IRC | 19:03 | |
| mriedem | tssurya: i got to thinking, | 19:05 |
| *** slaweq_ has joined #openstack-nova | 19:05 | |
| mriedem | cern is upgrading to pike right now right? | 19:05 |
| mriedem | and cells v2 was required in ocata, | 19:05 |
| *** huanxie has joined #openstack-nova | 19:05 | |
| mriedem | so it would be nice if you could give us some info on how cern upgraded to ocata and rolled out cellsv2 even though they are using cells v1 | 19:05 |
| mriedem | like, was cern in ocata just a single giant cells v2 cell? | 19:05 |
| tssurya | mriedem : no cern is still on newton, it is going to upgrade to ocata | 19:06 |
| mriedem | or, is cern actually migrating to cells v2 | 19:06 |
| mriedem | i saw something the other day saying they were upgrading glance to pike | 19:06 |
| mriedem | maybe that's just glance> | 19:06 |
| mriedem | ? | 19:06 |
| tssurya | mriedem : yes its just glance | 19:06 |
| mriedem | gah! | 19:06 |
| tssurya | mriedem : nova is still on newton | 19:06 |
| mriedem | is that because of the complications with migrating nova to ocata? | 19:06 |
| sean-k-mooney | tssurya: so cern is migrating to cellsv2 now also | 19:07 |
| tssurya | mriedem : however we will soon upgrade to cells v2 :) | 19:07 |
| mriedem | tssurya: ok, i hope there will be copious amounts of blog posts and such on what the plan was and how it goes | 19:07 |
| tssurya | mriedem , sean-k-mooney : yes belmiro is about to come up with a plan for doing this soon | 19:07 |
| *** bnemec has quit IRC | 19:07 | |
| sean-k-mooney | mriedem: we are waiting for cern to fully migrate to cellsv2 before removing cellsv1 and nova networks correct | 19:08 |
| dansmith | not just cern | 19:08 |
| *** moshele has quit IRC | 19:08 | |
| dansmith | until pike it wasn't even a possibility for multiple cells, | 19:08 |
| mriedem | sean-k-mooney: at the ptg we said if we have dan's efficient instance list stuff in queens, we remove cells v1 and nova-net in rocky | 19:09 |
| dansmith | and many will have issues with multiple cells until queens | 19:09 |
| sean-k-mooney | well yes but as the bigest user of cells they are a good litmus test that such a migration works at scale | 19:09 |
| mriedem | and we're on a good path to doing that | 19:09 |
| sean-k-mooney | mriedem: ah ok. part of my interest is there is some legacy nova network datamodels in os-vif | 19:10 |
| sean-k-mooney | https://bugs.launchpad.net/os-vif/+bug/1720175 | 19:10 |
| openstack | Launchpad bug 1720175 in os-vif "Move "ips" field from Subnet object to VIF object" [High,Triaged] | 19:10 |
| dansmith | sean-k-mooney: get in line :) | 19:10 |
| sean-k-mooney | currently nothing uses it but its from when we imported the network models for nova | 19:10 |
| *** bnemec has joined #openstack-nova | 19:13 | |
| sean-k-mooney | dansmith: gladly, i just have to keep remining people that os-vif is used with nova net too so we cant break it eventhough we dont gate on it for the os-vif repo :) | 19:13 |
| dansmith | sean-k-mooney: I'm just saying there's a lot of stuff we get to remove when we drop n-net, and you're late to that party :P | 19:14 |
| efried | mriedem I have reason to believe that it is impossible to use anything other than the public interface for cinderclient in Nova. | 19:15 |
| sean-k-mooney | haha yes though not that late i have wanted to kill nova-net since neutron was still quantum but in fairness to nova net it proably was a better choice for large deployment back then. | 19:15 |
| efried | (mriedem or point me to someone else who would have the inclination to walk through this with me) | 19:16 |
| *** bnemec has quit IRC | 19:16 | |
| mriedem | efried: ok? | 19:17 |
| efried | mriedem D'oh, nope, buried in the bowels, the 'interface' kwarg overrides 'endpoint_type'. | 19:17 |
| efried | It's just way non-obvious from the first four layers of calls. | 19:18 |
| efried | Carry on. | 19:18 |
| mriedem | sean-k-mooney: dansmith: don't forget that if we wait long enough, edge will require nova-net again | 19:18 |
| sean-k-mooney | edge? | 19:18 |
| sean-k-mooney | as in cloud edge computing | 19:18 |
| mriedem | yes | 19:19 |
| *** READ10 has quit IRC | 19:19 | |
| sean-k-mooney | ah well it might actullly work well in that model in multihost mode untill a telco trys to add sfc to nova net | 19:20 |
| * sean-k-mooney shudders at the taught | 19:20 | |
| *** Sukhdev has joined #openstack-nova | 19:21 | |
| *** hemna_ has quit IRC | 19:21 | |
| *** crushil_ has quit IRC | 19:23 | |
| *** gbarros has joined #openstack-nova | 19:24 | |
| *** itlinux has joined #openstack-nova | 19:25 | |
| *** smatzek has joined #openstack-nova | 19:26 | |
| *** nikhil has joined #openstack-nova | 19:27 | |
| *** penick_ has joined #openstack-nova | 19:31 | |
| *** pcaruana has quit IRC | 19:31 | |
| *** smatzek_ has joined #openstack-nova | 19:33 | |
| *** penick has quit IRC | 19:33 | |
| *** bnemec has joined #openstack-nova | 19:35 | |
| *** smatzek has quit IRC | 19:35 | |
| *** huanxie has quit IRC | 19:35 | |
| mriedem | stvnoyes: ok comments inline https://review.openstack.org/#/c/463987/ | 19:36 |
| mriedem | once those test things are cleaned up i'm +2 | 19:36 |
| *** awaugama has quit IRC | 19:41 | |
| *** ceryx has joined #openstack-nova | 19:56 | |
| *** huanxie has joined #openstack-nova | 19:58 | |
| *** smatzek_ has quit IRC | 19:59 | |
| stvnoyes | cool. thx | 20:00 |
| *** smatzek has joined #openstack-nova | 20:00 | |
| *** smatzek has quit IRC | 20:00 | |
| *** ijw has joined #openstack-nova | 20:01 | |
| *** smatzek has joined #openstack-nova | 20:01 | |
| *** cdent has joined #openstack-nova | 20:03 | |
| catintheroof | hi guys, quick question, when CoreFilter is enabled on the scheduler nodes, is cpu_allocation_ratio allowed per compute node ? | 20:05 |
| *** liverpooler has quit IRC | 20:07 | |
| *** catintheroof has quit IRC | 20:09 | |
| mriedem | catintheroof: i believe that means you can configure the cpu_allocation_ratio per compute service or just take the default in the scheduler filter for all nodes | 20:09 |
| mriedem | the help text for the config option says the same | 20:09 |
| dansmith | speaking of that, did we deprecate those filters in pike such that we can remove them now? | 20:10 |
| *** smatzek has quit IRC | 20:10 | |
| *** weshay has quit IRC | 20:10 | |
| *** weshay has joined #openstack-nova | 20:11 | |
| mriedem | i think only the exact ones | 20:11 |
| dansmith | I thought we were going to deprecate the regular ones too | 20:11 |
| mriedem | caching scheduler | 20:11 |
| mriedem | we removed ram and disk filters from the default enabled_filters list, | 20:11 |
| dansmith | oh | 20:12 |
| mriedem | but didn't deprecate them b/c of caching scheduler, which doesn't use placement | 20:12 |
| dansmith | we could make them only loadable if the driver is set to caching maybe? | 20:12 |
| mriedem | at least that's what i'm reading in the release notes | 20:12 |
| mriedem | anything is possible, | 20:12 |
| mriedem | although any out of tree scheduler drivers might break on that | 20:12 |
| *** slaweq_ has quit IRC | 20:12 | |
| mriedem | and we allow those | 20:12 |
| dansmith | an out-of-tree driver that uses our filters? | 20:13 |
| mriedem | sure | 20:13 |
| *** slaweq_ has joined #openstack-nova | 20:13 | |
| mriedem | like, | 20:13 |
| *** mnestratov has joined #openstack-nova | 20:13 | |
| mriedem | maybe i extend CachingScheduler | 20:13 |
| mriedem | because i like to have fun | 20:13 |
| dansmith | out of tree filters and weighers I can see, but.. whole drivers? | 20:13 |
| *** slaweq_ has quit IRC | 20:13 | |
| mriedem | it's a thing i guess, and we broke it in ocata, | 20:13 |
| mriedem | and had to fix that in pike and backport | 20:14 |
| mriedem | since we never deprecated that ability formally | 20:14 |
| dansmith | with an out of tree driver you're going to end up with fubar'd placement and such | 20:14 |
| *** slaweq_ has joined #openstack-nova | 20:14 | |
| mriedem | do we default to use placement or not... | 20:14 |
| mriedem | USES_ALLOCATION_CANDIDATES = True | 20:14 |
| mriedem | we default to use placement | 20:14 |
| mriedem | btw, | 20:15 |
| dansmith | I guess I'm not sure where the seam is, are you saying that we do the claim late enough that it's run for every driver? | 20:15 |
| mriedem | it seems a bit nutty that we join on system_metadata when listing all instances with details | 20:15 |
| dansmith | we used to have to have that join for flavor info | 20:16 |
| mriedem | yeah, i figured, | 20:16 |
| mriedem | but that's long gone | 20:16 |
| mriedem | do you still have your perf box env setup? | 20:16 |
| dansmith | I think it will come back up ready, lemme see | 20:16 |
| dansmith | I was also thinking of another thing I could do: | 20:16 |
| mriedem | for the scheduling thing, if the driver says USES_ALLOCATION_CANDIDATES=False, we don't ask placement for anything | 20:16 |
| dansmith | put duplicate cell entries in for the same cell to cause us to list across more cells for free | 20:16 |
| mriedem | and we don't attempt to claim in the scheduler | 20:17 |
| dansmith | we could make those filters refuse to load if driver is set to the filter scheduler, just flip the logic | 20:17 |
| dansmith | I mean log deprecation now, and fail in rocky | 20:17 |
| mriedem | that seems ok | 20:17 |
| dansmith | we really need to be removing the honoring of the limits provided by those filters from compute anyway I think | 20:18 |
| dansmith | we've not really done any culling of stuff that is now handled by placement from compute/rt | 20:18 |
| mriedem | speaking of culling | 20:20 |
| mriedem | _get_all_instance_metadata | 20:20 |
| mriedem | in compute api | 20:20 |
| mriedem | apparently the only things that use that, aren't used by anything else | 20:20 |
| mriedem | i'm going through https://review.openstack.org/#/c/505418/ btw | 20:22 |
| mriedem | hence asking random questions | 20:22 |
| dansmith | thank you | 20:23 |
| dansmith | my devstack setup came back so I'll poke at sysmeta | 20:23 |
| *** thorst has quit IRC | 20:26 | |
| mriedem | ok comments inline | 20:27 |
| dansmith | mriedem: is that one of the tests I pulled out to the cells class in an earlier patch? | 20:27 |
| mriedem | nope | 20:27 |
| mriedem | just looked | 20:27 |
| dansmith | okay | 20:27 |
| mriedem | checking to see if anything else covers that | 20:27 |
| mriedem | we tend to duplicate a lot of our unit tests | 20:28 |
| *** eharney has quit IRC | 20:28 | |
| *** huanxie has quit IRC | 20:29 | |
| *** itlinux has quit IRC | 20:30 | |
| mriedem | _get_all_instance_metadata is only used by methods that were for the ec2 api | 20:30 |
| mriedem | ec2api repo doesn't call them though | 20:31 |
| *** itlinux has joined #openstack-nova | 20:33 | |
| dansmith | hmm, got worried for a sec | 20:34 |
| dansmith | baseline was taking 10s instead of 6s from yesterday | 20:34 |
| dansmith | but after the reboot the devstack@dstat.service was consuming two cores for some reason | 20:34 |
| dansmith | hopefully that's why | 20:34 |
| mriedem | ok we return metadata during GET /servers/{server_id} which makes sense, so still need to join on that | 20:39 |
| mriedem | and flavor for flavor, and info_cache for IPs, | 20:39 |
| mriedem | but system_metadata should be able to be nuked from the join in the API | 20:39 |
| mriedem | oh | 20:41 |
| mriedem | geez | 20:41 |
| mriedem | we join on security_groups... | 20:41 |
| mriedem | for no good reason | 20:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove unused get_all_instance_*metadata methods https://review.openstack.org/508299 | 20:41 |
| mriedem | gmann: Kevin_Zheng: shouldn't JOINED_TABLE_QUERY_PARAMS_SERVERS include 'tags'? | 20:42 |
| *** rcernin has joined #openstack-nova | 20:42 | |
| dansmith | hrm, still running slow | 20:43 |
| *** thorst has joined #openstack-nova | 20:43 | |
| mriedem | if we removed system_metadata from the default join list in the API, if it was used somewhere, we'd see the "lazy-loading ..." message in the API logs though right? | 20:44 |
| *** gregwork has joined #openstack-nova | 20:44 | |
| dansmith | yes | 20:44 |
| *** gbarros has quit IRC | 20:47 | |
| mriedem | gmann: Kevin_Zheng: oh nvm it can't because "tags" is an actual query parameter | 20:50 |
| dansmith | for a single list operation via curl I really shouldn't be hitting keystone more than once right? | 20:50 |
| mriedem | hmmm | 20:50 |
| mriedem | going to neutron? | 20:51 |
| mriedem | we pass the token to neutron and it has to auth? | 20:51 |
| dansmith | for a list? | 20:51 |
| mriedem | we proxy the security group information during list to neutron | 20:51 |
| dansmith | I'm just trying to figure out why this is taking double what it was yesterday | 20:51 |
| mriedem | i think anyway, this has come up before b/c we don't cache security groups | 20:51 |
| *** corey_ has quit IRC | 20:54 | |
| *** tbachman has joined #openstack-nova | 20:54 | |
| *** takashin has joined #openstack-nova | 20:56 | |
| mriedem | nova meeting in 3 minutes | 20:57 |
| *** yamahata has joined #openstack-nova | 20:57 | |
| mriedem | jaypipes: even if the instance_security_groups table is empty, i'm assuming that listing 1000 instances and joining on that table is not insignificant? | 20:58 |
| mriedem | sorry the security_group_instance_association table | 20:59 |
| *** tbachman has quit IRC | 20:59 | |
| jaypipes | mriedem: well, if i_s_g is empty, it's an insignificant thing. | 20:59 |
| *** thorst has quit IRC | 21:00 | |
| jaypipes | mriedem: if there's no records, the join is optimized out by the DB. that said, as soon as it starts to get many records in it, boom. | 21:00 |
| *** thorst has joined #openstack-nova | 21:00 | |
| mriedem | if using neutron it shouldn't ever have records in it | 21:00 |
| mriedem | system_metadata totally will though | 21:00 |
| mriedem | anyway, meeting time | 21:01 |
| dansmith | mriedem: I'm restacking to make sure I'm clean and measuring what I expect, because things are taking twice what they should be | 21:01 |
| *** tbachman has joined #openstack-nova | 21:02 | |
| mriedem | ok | 21:02 |
| *** thorst has quit IRC | 21:11 | |
| jaypipes | efried: care to update https://review.openstack.org/#/c/497713/ to say required= and let's ship it? | 21:12 |
| tonyb | dansmith: I should've added a comment but I'd only just +wd the pike version so I was waiting for that to merge | 21:12 |
| dansmith | tonyb: okay, well I hit it anyway | 21:13 |
| efried | jaypipes Sure, I can do that. | 21:13 |
| jaypipes | efried: ty | 21:13 |
| *** lpetrut has quit IRC | 21:14 | |
| *** tssurya has quit IRC | 21:14 | |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Add trait support in the allocation candidates API https://review.openstack.org/497713 | 21:16 |
| efried | jaypipes hecho ^ | 21:16 |
| jaypipes | efried: danke | 21:16 |
| *** smatzek has joined #openstack-nova | 21:17 | |
| cdent | i guess I better actually read that one | 21:18 |
| *** tssurya has joined #openstack-nova | 21:18 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Use improved instance_list module in compute API https://review.openstack.org/505418 | 21:19 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Fix CellDatabases fixture swallowing exceptions https://review.openstack.org/506312 | 21:19 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416 | 21:19 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Move cell marker tests to Cellsv1DeprecatedTestMixIn https://review.openstack.org/508314 | 21:19 |
| *** smatzek has quit IRC | 21:23 | |
| efried | jaypipes Oh, did you mean https://review.openstack.org/#/c/468797/ ? I can update that one too... | 21:25 |
| jaypipes | efried: that would be great, too. | 21:25 |
| jaypipes | efried: that's the flavor changes, right? | 21:25 |
| efried | They're different, mind you: one's in flavor and the other's in API. But with the current proposals I don't see any reason they shouldn't both be required= | 21:25 |
| jaypipes | efried: agreed completely. they should match. | 21:26 |
| *** itlinux has quit IRC | 21:26 | |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Request traits in Nova https://review.openstack.org/468797 | 21:27 |
| efried | jaypipes ^ | 21:27 |
| jaypipes | efried: danke | 21:27 |
| efried | bitte | 21:27 |
| *** pchavva has quit IRC | 21:28 | |
| *** slaweq_ has quit IRC | 21:28 | |
| *** slaweq_ has joined #openstack-nova | 21:29 | |
| efried | jaypipes of Nederland als je wil | 21:30 |
| jaypipes | efried: no. I speak only English. and badly at that. | 21:30 |
| *** thorst has joined #openstack-nova | 21:32 | |
| cdent | efried: I’m sensing a good deal of polylingualism in your direction | 21:32 |
| efried | jaypipes Oh, I thought you had some Dutch, or Afrikaans. | 21:33 |
| efried | cdent You could say I'm a cunning linguist. | 21:33 |
| * cdent sings | 21:33 | |
| efried | If only I could learn python | 21:33 |
| *** eharney has joined #openstack-nova | 21:34 | |
| takashin | oomichi: Are you around? | 21:34 |
| *** itlinux has joined #openstack-nova | 21:35 | |
| *** tbachman has quit IRC | 21:35 | |
| *** nikhil has quit IRC | 21:36 | |
| *** thorst has quit IRC | 21:36 | |
| efried | cdent "The traits don't belong to the children do they, they just happen to be present because the parent is present. You can't have the trait without the parent, right?" <== talk to me | 21:37 |
| *** itlinux has quit IRC | 21:37 | |
| *** smatzek has joined #openstack-nova | 21:38 | |
| * cdent thinks about a translation | 21:38 | |
| efried | Any RP can have traits. The paragraph in question is talking about how traits inherit in a NRP tree and (not) in aggregates. | 21:38 |
| efried | The paragraph is saying that a parent RP's traits implicitly also belong to its descendants, but not the other way around. | 21:39 |
| cdent | a) how traits behave in rps is not relevant to that spec is it. That spec is merely saying “I require this trait”, so the paragraph is not required and merely confuses (it did me) | 21:39 |
| *** tssurya has quit IRC | 21:39 | |
| *** smatzek has quit IRC | 21:39 | |
| efried | cdent Mm, I think it's relevant to understanding what you're expecting to get back when you specify those required traits. | 21:39 |
| efried | And also how the implementor of the RPs should model them in order for that to be effective. | 21:40 |
| cdent | it means you’ll get back some resource providers, one of which will have that trait, that’s all | 21:40 |
| cdent | s/one/at least one/ | 21:40 |
| efried | I believe that paragraph indicates that that is not completely true. | 21:40 |
| cdent | explain? | 21:40 |
| efried | Because I could get back a leaf RP that doesn't actually have the trait explicitly itself, but got returned because its parent/ancestor had that trait. | 21:41 |
| cdent | and that’s my question: you’ll only see that leaf in the results if you are _also_ seeing the ancestor in the results | 21:41 |
| efried | It's unclear (but needs to be clarified) whether the API is gonna populate the leaf RP's traits with all the ancestors' traits as it returns it. | 21:41 |
| efried | Yeah, that's another good question: are you going to get back the parent RP in the response? If so, it's likely not to have any inventory allocated out of it. | 21:42 |
| efried | is that kosher? | 21:42 |
| cdent | that’s indeed a tricky question, because we’ve where a VCPU lives in a NUMA world ambiguous in our questions | 21:43 |
| cdent | the early assumptions were it would be on the compute node instance (the ultimate parent of any tree returned in allocation_candidates) | 21:44 |
| cdent | so there would always be inventory consumed at the top | 21:44 |
| cdent | but even if inventory is not consume at the top we must have the resource provider uuid of the compute node so we know what the destination is | 21:45 |
| edleafe | we are always returning root RPs, right? | 21:45 |
| cdent | so even if the allocation part of the allocation candiate doesn’t consumer, there will be a record in the other half of the tuple which has the roots | 21:45 |
| edleafe | IOW, we'd never return a NIC by itself | 21:45 |
| cdent | edleafe: i think so, yes, at least in the resource providers half of the tuple | 21:46 |
| efried | More recently we've talked about modeling NUMA by making the NUMA nodes child RPs and having them provide the CPU/MEM(/possibly-other-things-like-PFs) resources. | 21:46 |
| cdent | efried: right, but they are still a child | 21:46 |
| efried | Well, okay, but if the tree is three deep, the root RP may still not have the traits the leaf is inheriting. | 21:46 |
| cdent | so you could alloc against them, but still _place_ on the parent | 21:46 |
| *** mnestratov has quit IRC | 21:46 | |
| cdent | I think inheritance is a very bad way of thinking of this | 21:46 |
| cdent | and that’s what my comment was inspired by | 21:46 |
| cdent | (on the review) | 21:47 |
| * cdent locates something to look at | 21:47 | |
| *** armax has joined #openstack-nova | 21:47 | |
| cdent | which spec has allocation candidates? | 21:48 |
| edleafe | cdent: yeah, this is more like composition than inheritance | 21:48 |
| cdent | ah, it’s got the wrong name: http://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/placement-allocation-requests.html | 21:49 |
| dansmith | gah | 21:49 |
| dansmith | does anyone else get stopped in devstack doing this? | 21:49 |
| dansmith | 403 Forbidden: You are not authorized to complete publicize_image action. (HTTP 403) | 21:49 |
| dansmith | must be residue leftover from my previous install, but I don't know what it is | 21:49 |
| *** takashin has left #openstack-nova | 21:50 | |
| cdent | efried: in there, provider_summaries is the second half of the tuple, contains the rp info. in there will be represented the info to construct a nested provider hierarchy, I don’t know if that’s defined yet | 21:50 |
| cdent | efried: but in that a trait will be on the thing to which the trait was associated, not its children | 21:50 |
| efried | cdent You could totally return *just* the RPs that are being claimed against, and the scheduler would have to use the root RP UUID to pull the whole tree from placement at that point. | 21:51 |
| *** takashin has joined #openstack-nova | 21:52 | |
| efried | Or you could return the whole tree, and the scheduler would not have to do that, but there would be empty "allocations". | 21:52 |
| cdent | you could, yes, but I don’t think that was the plan. I suggested at one point we should just return uuids and require the client to go back for more info if it wanted | 21:52 |
| efried | Or you could return just the claimed RPs in the allocations, but return the whole RP trees in the provider summaries. | 21:52 |
| cdent | why would there be empty allocations? | 21:52 |
| cdent | the structure in provider_summaries is not directly mapped to what is in allocations | 21:52 |
| mriedem | dansmith: making an image public? | 21:52 |
| mriedem | but devstack uploads the image... | 21:53 |
| dansmith | mriedem: that's just during stack | 21:53 |
| efried | dansmith Could be perms in your configured temp dir, which glance uses to store a copy of the image while it's uploading it. | 21:53 |
| dansmith | efried: I dunno what would have changed from one stack run to another | 21:54 |
| cdent | efried: so I’m still confused about how/why you want inheritance to be a thing | 21:54 |
| efried | cdent Lemme find that conversation. It's in the same spec, same area, earlier rev... | 21:54 |
| dansmith | mriedem: efried: this is a centos box and my best guess is that clean.sh doesn't clean something for redhat systems like it does for ubuntu or something | 21:54 |
| dansmith | guess what I'm doing right now? | 21:54 |
| mriedem | umm | 21:55 |
| efried | cdent PS6 | 21:55 |
| * cdent looks | 21:55 | |
| efried | cdent There's an example there | 21:55 |
| *** gouthamr has quit IRC | 21:56 | |
| efried | cdent And more background in PS4 | 21:56 |
| efried | ...which is where jaypipes actually provided the example | 21:56 |
| cdent | that’s no inherited, the trait still matched on the compute rp, we _also_ got numa node 1 because we required magic cache thingy | 21:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove old compat code from servers ViewBuilder._get_metadata https://review.openstack.org/508326 | 21:58 |
| cdent | the compute rp is a member of the results | 21:58 |
| efried | cdent But with no inventory. | 21:59 |
| efried | no inventory consumed* that is | 21:59 |
| cdent | if it were not a member of the results, then that would be inheritance | 21:59 |
| efried | But we need to be crisp about this because when we start doing the "grouping" thing, it's going to be important to be able to say that you *don't* get results that *don't* have your traits for a given group. | 22:00 |
| efried | I said that horribly. | 22:00 |
| *** esberglu has quit IRC | 22:00 | |
| efried | In this example, the NUMA node and the compute node are *different* RPs. | 22:01 |
| cdent | I agree that we need to be crisp, which is why I’m disputing the use of the term “inherited” it’s misleading | 22:02 |
| efried | If I ask for inventory on a resource class, I should only get a RP that has inventory in that resource class. If I ask for a required trait, I should only get a RP that has that trait. | 22:02 |
| efried | In this case, I'm asking for e.g. CPU inventory, which belongs to the NUMA node (not the compute host). And I'm asking for trait HW_CPU_MAGIC_CACHE_THINGY, which belongs to the NUMA node (not the compute host). So far so good. | 22:03 |
| efried | But then I'm *also* asking for trait HW_CPU_X86_SSE2. | 22:03 |
| efried | That trait belongs to the compute RP but *not* the NUMA node RP. | 22:03 |
| efried | So by the rules, with no "inheritance" (or whatever you wanna call it), that request would kick out the NUMA node RP because the NUMA node RP doesn't have the HW_CPU_X86_SSE2 trait. | 22:04 |
| *** gouthamr has joined #openstack-nova | 22:04 | |
| efried | If we want to do it that way, it's possible, but it means the implementor who models the RPs would have to *duplicate* the HW_CPU_X86_SSE2 trait (and all those other CPUey traits) onto each NUMA node RP. | 22:04 |
| *** bnemec has quit IRC | 22:05 | |
| efried | jaypipes put a stake in the ground and said we could inherit downward, which is why we needed to make this statement in the spec. | 22:05 |
| *** baoli has quit IRC | 22:06 | |
| efried | Based on your confusion, though, it seems like we would have done well to include the example, as well as listing the no-inheritance-but-duplication thing in Alternatives. | 22:06 |
| *** burt has quit IRC | 22:06 | |
| cdent | I guess maybe I’m too embedded but the statement is a) obvious, b) not inheritance. It is simply that you “got” the compute node, because you asked for that trait | 22:07 |
| cdent | it’s not that the numa node has that trait by inheritance | 22:07 |
| efried | But I don't want the compute nod. | 22:07 |
| efried | node | 22:07 |
| cdent | you do | 22:07 |
| cdent | you _have_ to have the compute node | 22:07 |
| efried | I'm not claiming any inventory off of it. | 22:07 |
| cdent | it is your destination | 22:07 |
| cdent | it is the place where your inventory is | 22:08 |
| efried | Meh, that's kind of an artifact of the root RP happening to be a compute node. | 22:08 |
| efried | cdent Ah, so wait, that's where we're disagreeing I think. | 22:08 |
| efried | The compute node RP is *not* where your inventory is. | 22:08 |
| efried | The NUMA node RP is where your inventory is. | 22:08 |
| efried | Unless you're saying the compute node inherits (accumulates? composes?) the inventory from its descendants. | 22:09 |
| cdent | which is “within” the copute node, by representation (even if it happens to be only logically so) | 22:09 |
| cdent | nested providers are nested | 22:10 |
| *** tbachman has joined #openstack-nova | 22:10 | |
| cdent | and they are generally created when a compute node does get_inventory | 22:10 |
| efried | Right. So inventory is implicitly crossing RP boundaries (you don't like the word "inheritance"; fine; pick another word). The disputed statement is saying traits do the same. | 22:10 |
| efried | Also trying to think not totally compute-node-is-the-root-RP-centric | 22:11 |
| cdent | I’m saying it’s not relevant when requesting allocation_candidates to know that | 22:11 |
| cdent | (that being “traits compose”) | 22:11 |
| *** tbachman_ has joined #openstack-nova | 22:12 | |
| efried | I'm coming from, "it is relevant, both from the perspective of the requestor and the perspective of the implementor of the RP models being looked at by the allocation_candidates API." Let me think through it again... | 22:13 |
| *** thorst has joined #openstack-nova | 22:13 | |
| cdent | If we’re trying to be crispy, then the crispiness I’m trying to go for in the example is that we shouldn’t say “the numa node is HW_CPU_X86_SSE2” when it is the parent that has that trait | 22:14 |
| *** tbachman has quit IRC | 22:15 | |
| *** tbachman_ is now known as tbachman | 22:15 | |
| efried | Then we would have to duplicate the trait on each NUMA node. | 22:15 |
| cdent | that’s what I’m not understanding. How are you reaching that conclusion? | 22:15 |
| efried | In this case I'm assuming the resources themselves are owned by the NUMA node RPs. Not by the compute node RP. | 22:16 |
| efried | GET /allocation_candidates?resources=VCPU:1,required=HW_CPU_X86_SSE2,HW_CPU_MAGIC_CACHE_THINGY | 22:16 |
| *** slaweq_ has quit IRC | 22:17 | |
| *** thorst has quit IRC | 22:17 | |
| efried | I haven't gotten the impression that we're supposed to return allocations that satisfy any permutation of that request. I've gotten the impression we're supposed to return allocations that satisfy *all* of those criteria. | 22:17 |
| cdent | well, not to draw us off into the weeds too far, but if you’re going to put the VCPU inventory on a numa node, then presumably you put the hw traits of cpus on the numa node too? | 22:18 |
| cdent | ignore that | 22:18 |
| efried | Ah, that's the point of contention. jaypipes said (in PS4)... okay. | 22:18 |
| *** gouthamr has quit IRC | 22:18 | |
| *** r-daneel has joined #openstack-nova | 22:18 | |
| cdent | I agree that we should only satisfy all those criteria | 22:19 |
| efried | Okay. Then as modeled, without "inheritance", we would get nada back from that request. | 22:19 |
| efried | because there isn't a single resource provider that satisfies all of it. | 22:20 |
| cdent | so perhaps you are using the term “inheritance” to mean something like “which direction in the resource provider tree should would look to see if a trait is available”? | 22:20 |
| *** gouthamr has joined #openstack-nova | 22:20 | |
| cdent | up, down, both | 22:20 |
| jaypipes | efried: I also said in PS4 that I disagreed with you calling it inheritance. :) | 22:20 |
| cdent | and you’re saying only up | 22:20 |
| cdent | if “only up” then cool, but don’t use the term inheritiance :) | 22:20 |
| efried | bah, let's come up with a word for it that isn't "inheritance" so we can stop getting distracted by that. What do we call it. | 22:20 |
| jaypipes | propagation. | 22:21 |
| efried | cool. | 22:21 |
| cdent | is my description of “only up” what you mean? | 22:21 |
| efried | Traits propagate down. | 22:21 |
| efried | "only down". | 22:21 |
| efried | If parents are "up" and children are "down". | 22:21 |
| cdent | “looking from the thing with inventory, we only look up for missing traits" | 22:21 |
| efried | yes | 22:21 |
| efried | or | 22:21 |
| efried | "traits propagate down" | 22:22 |
| cdent | that means too much | 22:22 |
| cdent | because that means the same thing I was disagreeing with before: the children “get” the traits, they don’t | 22:22 |
| efried | What about, "traits defined on a parent RP are assumed to | 22:22 |
| efried | belong to all its child (descendant) RPs. However, traits defined on a child | 22:22 |
| efried | RP do not apply to the parent (ancestor) RPs." | 22:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Stop joining on system_metadata when listing instances https://review.openstack.org/508335 | 22:22 |
| mriedem | dansmith: when you get numbers ^ | 22:23 |
| *** thorst has joined #openstack-nova | 22:23 | |
| dansmith | mriedem: sorry I'm still fighting devstack | 22:23 |
| jaypipes | efried: isn't that essentially what I said ++ to on the patch? | 22:23 |
| cdent | “required traits which are not present on child can be satisfied by a parent” is much closer to the truth, I think? jaypipes ? | 22:23 |
| jaypipes | efried: that wording... | 22:23 |
| efried | jaypipes It's *exactly" that :) | 22:23 |
| mikal | Sorry I missed the meeting, I was at the doctor complaining that one of my ears has stopped working. | 22:23 |
| efried | Copied and pasted :) | 22:23 |
| jaypipes | right. | 22:23 |
| *** gouthamr has quit IRC | 22:23 | |
| mriedem | dansmith: that's fine, i'm also going to check the n-api logs to see if anything gets lazy-loaded incidentally | 22:23 |
| efried | cdent I think saying "can be satisfied by a parent" implies more than what's happening. | 22:24 |
| cdent | jaypipes, efried : it’s the belonging thing that’s really botherin gme | 22:24 |
| *** catintheroof has joined #openstack-nova | 22:24 | |
| *** tbachman has quit IRC | 22:24 | |
| cdent | but again, I’m not sure it is relevant in the immediate sense | 22:25 |
| cdent | (of the spec) | 22:25 |
| efried | okay, so back to that. | 22:25 |
| mikal | mriedem: does "Michael runs with this" mean you'd like me to propose the session? | 22:26 |
| efried | I assume the target audience of this spec is 1) developers who will be a) implementing the /allocation_candidates API changes, and b) coding the modeling and registration of the RPs that it'll talk to; as well as 2) (eventually, as it gets "propagated" into docs) the operator who's gonna populate the flavor with the resource classes and traits. | 22:27 |
| cdent | efried: If you want we can probably just revisit this later, as I’m +1. I’m conscious however that we will stumble on this stuff again later when trying to document stuff and consider implications. | 22:27 |
| *** r-daneel has quit IRC | 22:29 | |
| efried | 1a definitely needs to understand it for NRP to construct the query right. 1b needs to understand it for NRP to model the RPs right. And 2 needs to understand it because he's gonna look at the RPs as real things with meaningful traits and know that he can ask for HW_CPU_X86_SSE2. | 22:29 |
| efried | cdent Okay, sure. I don't necessarily disagree that the propagation discussion could have happened in a different spec as well (like maybe the NRP spec). But I still can't see how it's misplaced here. | 22:30 |
| efried | cdent Slightly less controversial (hopefully) response to your other comment inline :) | 22:32 |
| cdent | I don’t think it is misplaced, if it were clear, but it isn’t it, and clarifying it it is too hard especially when not in the context of the nrp spec/code, so as it is stands is distracting | 22:32 |
| mriedem | mikal: yes | 22:33 |
| efried | cdent Gotcha. | 22:34 |
| *** thorst has quit IRC | 22:35 | |
| *** thorst has joined #openstack-nova | 22:36 | |
| *** penick_ has quit IRC | 22:36 | |
| *** eharney has quit IRC | 22:37 | |
| *** lbragstad has quit IRC | 22:37 | |
| *** penick has joined #openstack-nova | 22:38 | |
| cdent | efried: yeah, I didn’t mention the resource3,required3 thing there because of wanting to keep the immediate scope narrow, but yes, both of those could also do the repeat treatment if we wanted. not necessary or anything | 22:38 |
| efried | cdent But don't we already have an API that does resources= with commas? | 22:39 |
| cdent | yes, but that doesn’t prevent also allowing repeats | 22:39 |
| cdent | that’s what I was saying, we can do both if we like | 22:39 |
| efried | Mm. | 22:39 |
| efried | That's a big test matrix | 22:40 |
| cdent | sure, but repeats is _normal_ for web-based query parameters, and we might like that | 22:40 |
| efried | I mean, I dig the idea of using the repeats. But seems like that's something that should have been done from the start. | 22:40 |
| cdent | oh sure | 22:40 |
| efried | Yeah, normal for web-based query params ++ | 22:40 |
| cdent | so should many things :) | 22:40 |
| *** esberglu has joined #openstack-nova | 22:40 | |
| efried | But given that we did the comma thing, IMO the lesser evil is consistency and KISS. | 22:41 |
| *** thorst has quit IRC | 22:42 | |
| cdent | On 2) above, I’m less worried about people creating flavors than I am about inventory creating tooling getting the traits on the righ resource. Because in a flavor when you express a trait or quantity of resource, initially, it’s just that you require it, not the structure thereof | 22:42 |
| cdent | the comma thing will remain the primary thing I expect | 22:43 |
| mikal | mriedem: ok, I will do that thing | 22:43 |
| cdent | and we may never do the repeat thing, unless the framework already supports it (which it may, which is why I mentioned it) | 22:43 |
| mriedem | mikal: thanks | 22:43 |
| *** smatzek has joined #openstack-nova | 22:45 | |
| cdent | is extra_specs a dict, or is it a string that looks vaguely like a dict? | 22:45 |
| *** esberglu has quit IRC | 22:45 | |
| *** thorst has joined #openstack-nova | 22:45 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use ksa adapter for cinder client (OPTION 1) https://review.openstack.org/508345 | 22:48 |
| *** xyang1 has quit IRC | 22:50 | |
| *** lyan has quit IRC | 22:51 | |
| mriedem | johnthetubaguy: if you're going to be at the forum: http://forumtopics.openstack.org/cfp/details/12 | 22:53 |
| *** thorst has quit IRC | 22:58 | |
| *** thorst has joined #openstack-nova | 22:58 | |
| mriedem | i've seen at least 3 forum topics on here about ETSI/NFV | 23:00 |
| mriedem | all sound like duplicates | 23:00 |
| mikal | You're welcome? | 23:00 |
| mriedem | "HOT topic: Heat-ing up Telco VNFs in the ETSI way" | 23:01 |
| mriedem | this guy knows how to get a talk accepted | 23:01 |
| *** masber has quit IRC | 23:02 | |
| mikal | As a man who recently learned those acronymns, isn't that just a session on how to use heat to start instances? | 23:02 |
| mriedem | ha | 23:05 |
| mriedem | maybe? | 23:05 |
| mriedem | but in the etsi way | 23:05 |
| cdent | MANO your VIM with TOSCA | 23:06 |
| *** hongbin has quit IRC | 23:07 | |
| jaypipes | dansmith: so after 4 hours fucking around with this, I remember why I made it parent_provider_uuid and root_provider_uuid instead of using internal integer fields. | 23:07 |
| dansmith | jaypipes: lay it on e | 23:07 |
| mikal | cdent: OMG, that sentence even parsed | 23:07 |
| mikal | Why do these people love stupid acronyms so much? | 23:07 |
| jaypipes | dansmith: having to deal with all the friggin relationship stuff in the ORM results in a boatload of code and errors everywhere about lazy-loading and Sessions being inactive.. | 23:08 |
| cdent | Don’t acronyms mean importance? I’m sure I read a white paper on that. | 23:08 |
| dansmith | jaypipes: that makes no sense to me | 23:09 |
| * jaypipes wishes he could rip all the use of the ORM out of placement. :( | 23:09 | |
| dansmith | um, so do it? | 23:09 |
| jaypipes | dansmith: the resource_provider.py module is a mess of mixed up ORM and non-ORM code. drives me nuts. | 23:10 |
| dansmith | mriedem: smackin' the patch now | 23:11 |
| *** crushil has quit IRC | 23:13 | |
| *** jmlowe has quit IRC | 23:19 | |
| *** tbachman has joined #openstack-nova | 23:20 | |
| dansmith | mriedem: I got bad news about your sysmeta patch | 23:23 |
| *** huanxie has joined #openstack-nova | 23:24 | |
| *** itlinux has joined #openstack-nova | 23:25 | |
| cdent | Goodnight you princes of Maine, you kings of New England. | 23:27 |
| *** cdent has quit IRC | 23:27 | |
| dansmith | mriedem: it _only_ makes our API about 16% faster on average: https://imgur.com/a/ovFq2 | 23:28 |
| mriedem | is that bad news? | 23:28 |
| dansmith | terrible | 23:28 |
| mriedem | do i, | 23:28 |
| mriedem | or do i not, | 23:28 |
| *** mingyu has quit IRC | 23:28 | |
| mriedem | need a special comb | 23:28 |
| *** yassine has joined #openstack-nova | 23:29 | |
| *** mingyu has joined #openstack-nova | 23:29 | |
| * dansmith frantically tries to google for that reference to look cool | 23:30 | |
| mriedem | crabs | 23:30 |
| mriedem | it's a crabs joke | 23:30 |
| mriedem | you know, bad news | 23:30 |
| mriedem | you've got crabs | 23:30 |
| dansmith | hah, okay | 23:30 |
| *** itlinux has quit IRC | 23:31 | |
| *** thorst has quit IRC | 23:31 | |
| gmann | mriedem: yea, tags(all type of query like tag_any, not_tag etc) are in query itself | 23:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove system_metadata loading in Instance._load_flavor https://review.openstack.org/508357 | 23:32 |
| gmann | mriedem: api extension policy removal spec is ready - https://review.openstack.org/#/c/508101/2 | 23:33 |
| gmann | i listed 11 policies to remove | 23:33 |
| mriedem | gmann: ok, i'm not going to be able to get to that tonight | 23:35 |
| mriedem | we're going to do a spec review sprint early next week | 23:36 |
| gmann | mriedem: sure, btw when is spec freeze date ? | 23:36 |
| mriedem | oct 19 | 23:36 |
| *** markvoelker has quit IRC | 23:37 | |
| gmann | ok. thanks. | 23:37 |
| dansmith | your patch will conflict with my cutover patch, btw | 23:38 |
| *** thorst has joined #openstack-nova | 23:39 | |
| mriedem | dansmith: i know, i'll wip | 23:40 |
| dansmith | mriedem: don't have to, just pointing it out | 23:40 |
| mriedem | was just about to go through 505418 and underneath it | 23:41 |
| mriedem | laura is going to have my hide if she comes home at 7 and i don't have dinner started | 23:41 |
| dansmith | I didn't change the cutover one, just put a patch underneath to save the tests | 23:42 |
| *** jmlowe has joined #openstack-nova | 23:42 | |
| *** jaypipes has quit IRC | 23:42 | |
| dansmith | was going to do your refactoring in the top patch but I haven't yet | 23:42 |
| *** jpena|off has quit IRC | 23:43 | |
| *** ltomasbo has quit IRC | 23:44 | |
| mriedem | yeah noticed | 23:45 |
| mriedem | the comment i mean | 23:45 |
| openstackgerrit | Steve Noyes proposed openstack/nova master: update live migration to use v3 cinder api https://review.openstack.org/463987 | 23:45 |
| *** ltomasbo has joined #openstack-nova | 23:45 | |
| *** jpena|off has joined #openstack-nova | 23:46 | |
| dansmith | mriedem: so, I was wondering if maybe doing the cells in parallel would hide this benefit some and it does: https://imgur.com/a/YMxPQ | 23:47 |
| dansmith | that doesn't mean the gain isn't there, it means there's two gains and we're bumping up against just cpu performance processing the results from the DB I think | 23:47 |
| mriedem | the sysmeta benefit? | 23:47 |
| dansmith | which is good | 23:47 |
| dansmith | yeah | 23:47 |
| mriedem | ah | 23:47 |
| dansmith | that's the instance_list patch plus the sysmeta one vs. master | 23:47 |
| mriedem | cool | 23:48 |
| dansmith | I wish we could spawn a real thread instead of a greenthread to do the cells scatter | 23:49 |
| mriedem | https://review.openstack.org/#/c/505418/12 | 23:50 |
| dansmith | because we're just pegging one core when we're doing all this | 23:50 |
| mriedem | you know who likes to talk threading? | 23:50 |
| mriedem | that works on your team | 23:50 |
| * dansmith runs | 23:51 | |
| mriedem | me too | 23:51 |
| *** mriedem is now known as mriedem_dinner | 23:51 | |
| dansmith | mriedem_dinner: thanks for the +W | 23:51 |
| dansmith | melwitt: you wanna +W the test refactor underneath that? | 23:51 |
| dansmith | melwitt: it's just copying some tests to the cells deprecated morgue-of-tests so we keep running them in that path | 23:51 |
| melwitt | sure, lemme look | 23:52 |
| dansmith | it would make me the happiest boy in happy valley | 23:52 |
| melwitt | lol | 23:52 |
| *** huanxie has quit IRC | 23:54 | |
| *** thorst has quit IRC | 23:54 | |
| *** thorst has joined #openstack-nova | 23:55 | |
| *** yamahata has quit IRC | 23:56 | |
| melwitt | dansmith: done | 23:57 |
| cfriesen | has anyone else run into problems with devstack when changing branches? I tried going from stable/newton to stable/pike and a bunch of requirements are not properly handled, requiring me to do manual pip stuff. | 23:57 |
| dansmith | melwitt: tanks | 23:58 |
| *** chyka has quit IRC | 23:58 | |
| *** baoli has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!