Tuesday, 2017-10-17

*** dave-mccowan has quit IRC00:00
*** catintheroof has quit IRC00:00
*** catintheroof has joined #openstack-nova00:00
*** dave-mccowan has joined #openstack-nova00:01
*** chyka has quit IRC00:04
*** catintheroof has quit IRC00:04
*** yangyapeng has quit IRC00:07
*** yangyapeng has joined #openstack-nova00:07
*** baoli has quit IRC00:08
*** yangyapeng has quit IRC00:08
*** yangyapeng has joined #openstack-nova00:08
*** yangyapeng has quit IRC00:13
*** edmondsw has joined #openstack-nova00:13
openstackgerritEd Leafe proposed openstack/nova master: Add alternate hosts  https://review.openstack.org/48621500:14
openstackgerritEd Leafe proposed openstack/nova master: Add Selection objects  https://review.openstack.org/49923900:14
openstackgerritEd Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver  https://review.openstack.org/49585400:14
openstackgerritEd Leafe proposed openstack/nova master: Change RPC for select_destinations()  https://review.openstack.org/51015900:14
openstackgerritEd Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils  https://review.openstack.org/51135700:14
openstackgerritEd Leafe proposed openstack/nova master: WIP - Make conductor pass and use host_lists  https://review.openstack.org/51135800:14
*** salv-orlando has joined #openstack-nova00:17
*** markvoelker_ has quit IRC00:17
*** edmondsw has quit IRC00:18
*** wasmum has quit IRC00:19
*** salv-orlando has quit IRC00:22
*** yamamoto has joined #openstack-nova00:24
*** markvoelker has joined #openstack-nova00:25
*** yingjun has joined #openstack-nova00:26
*** yamamoto has quit IRC00:29
*** markvoelker has quit IRC00:29
*** vladikr has quit IRC00:29
*** esberglu has joined #openstack-nova00:30
*** markvoelker has joined #openstack-nova00:34
*** psachin has joined #openstack-nova00:38
*** markvoelker has quit IRC00:39
openstackgerritMerged openstack/nova master: Regenerate context during targeting  https://review.openstack.org/51165100:42
*** markvoelker has joined #openstack-nova00:43
*** Swami has quit IRC00:43
*** Apoorva_ has joined #openstack-nova00:44
*** esberglu has quit IRC00:45
*** markvoelker has quit IRC00:48
*** Apoorva has quit IRC00:48
*** huanxie has joined #openstack-nova00:48
*** AlexeyAbashkin has joined #openstack-nova00:48
*** Apoorva_ has quit IRC00:48
*** jichen has joined #openstack-nova00:51
*** AlexeyAbashkin has quit IRC00:52
*** markvoelker has joined #openstack-nova00:52
*** jichen_ has joined #openstack-nova00:53
*** mriedem1 has joined #openstack-nova00:54
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Regenerate context during targeting  https://review.openstack.org/51245600:55
mriedem1dansmith: ^00:55
*** mriedem has quit IRC00:55
*** mriedem1 is now known as mriedem00:55
*** jichen has quit IRC00:56
*** jichen_ is now known as jichen00:56
*** markvoelker has quit IRC00:57
jichenmriedem: hi, could you please let us know whether we need additional work for https://review.openstack.org/#/c/464915/? almost deadline for spec now..... thanks00:59
*** edmondsw has joined #openstack-nova01:00
*** markvoelker has joined #openstack-nova01:01
*** Shunli has joined #openstack-nova01:03
*** sree has joined #openstack-nova01:04
*** phuongnh has joined #openstack-nova01:04
*** tbachman has joined #openstack-nova01:05
*** markvoelker has quit IRC01:06
*** jwcroppe has quit IRC01:08
*** sree has quit IRC01:08
mriedemjichen: comments inline01:08
jichenmriedem: ok, thanks, I will update it right now01:09
*** markvoelker has joined #openstack-nova01:11
*** jwcroppe has joined #openstack-nova01:11
*** markvoelker has quit IRC01:15
*** yangyapeng has joined #openstack-nova01:17
*** salv-orlando has joined #openstack-nova01:18
*** catintheroof has joined #openstack-nova01:19
*** markvoelker has joined #openstack-nova01:20
openstackgerritjichenjc proposed openstack/nova-specs master: add z/VM Driver  https://review.openstack.org/46491501:20
*** catintheroof has quit IRC01:21
jichenmriedem: hi, thanks for the review, I just uploaded another version01:22
*** salv-orlando has quit IRC01:22
mriedemjichen: is there anything weird about the zvm driver like does it have a 1:M host:node mapping like baremetal?01:23
*** yamahata has quit IRC01:23
mriedemin other words, will get_available_nodes() only return 1 entry?01:23
jichenmriedem: no, every compute node has 1:1 relation to one hypervisor , I think powerVM used to have this problem and they modify the arch and now they have 1:1 relation?01:23
*** yamamoto has joined #openstack-nova01:24
mriedemi think neo / novalink was always 1:101:24
jichenok, maybe I remember wrong thing about powerVM01:24
jichenwe request one compute service running to represent a hypervisor , so if you have 5 z/VM to be managed , you have to create 5 compute service and each service running with nova.conf point to the z/VM to be managed01:25
*** ijw has joined #openstack-nova01:25
*** ijw has quit IRC01:25
*** ijw has joined #openstack-nova01:27
*** AlexeyAbashkin has joined #openstack-nova01:28
*** AlexeyAbashkin has quit IRC01:32
openstackgerritMerged openstack/nova-specs master: add z/VM Driver  https://review.openstack.org/46491501:33
openstackgerritEric Fried proposed openstack/nova master: Send Allocations to spawn  https://review.openstack.org/51187901:38
mriedemjichen: is there a blueprint in launchpad?01:38
jichenmriedem: I will create a new one right now, thanks for the reminder01:38
*** suresh12 has quit IRC01:40
*** bjolo has joined #openstack-nova01:41
*** zsli_ has joined #openstack-nova01:41
*** links has joined #openstack-nova01:44
*** Shunli has quit IRC01:45
*** mriedem has quit IRC01:45
*** links is now known as Jaison|away01:45
*** hongbin has joined #openstack-nova01:49
*** deikiyoch has joined #openstack-nova01:52
*** deikiyoch has left #openstack-nova01:52
*** markvoelker has quit IRC01:53
openstackgerritMerged openstack/nova master: doc: Fix command output in scheduler document  https://review.openstack.org/51183901:56
*** markvoelker has joined #openstack-nova01:59
openstackgerritYikun Jiang proposed openstack/nova-specs master: Add pagination and timestamp filtering support for os-migrations API  https://review.openstack.org/50603001:59
*** markvoelker has quit IRC02:03
*** hongbin_ has joined #openstack-nova02:04
*** masber has quit IRC02:07
*** markvoelker has joined #openstack-nova02:08
*** markvoelker has quit IRC02:12
*** bkopilov_ has quit IRC02:12
*** bkopilov has quit IRC02:13
*** markvoelker has joined #openstack-nova02:17
*** trungnv has quit IRC02:18
*** salv-orlando has joined #openstack-nova02:18
*** markvoelker has quit IRC02:21
*** salv-orlando has quit IRC02:23
*** markvoelker has joined #openstack-nova02:26
*** AlexeyAbashkin has joined #openstack-nova02:27
*** markvoelker has quit IRC02:30
*** ijw has quit IRC02:31
*** AlexeyAbashkin has quit IRC02:31
*** sree has joined #openstack-nova02:34
*** sean-k-mooney has quit IRC02:34
*** avolkov has quit IRC02:35
*** sean-k-mooney has joined #openstack-nova02:35
*** markvoelker has joined #openstack-nova02:35
*** jhesketh has quit IRC02:35
*** suresh12 has joined #openstack-nova02:35
*** tonyb has quit IRC02:36
*** avolkov has joined #openstack-nova02:37
*** tonyb has joined #openstack-nova02:37
*** jhesketh has joined #openstack-nova02:38
*** Lehtu has quit IRC02:38
*** Lehtu has joined #openstack-nova02:38
*** suresh12 has quit IRC02:40
*** markvoelker has quit IRC02:40
*** liuyulong has joined #openstack-nova02:41
*** TuanLA has joined #openstack-nova02:44
*** markvoelker has joined #openstack-nova02:44
*** TuanLA has quit IRC02:44
*** lbragstad has joined #openstack-nova02:45
*** Bryan__ has quit IRC02:46
*** masber has joined #openstack-nova02:49
*** coreywright has quit IRC02:49
*** markvoelker has quit IRC02:49
*** hongbin_ has quit IRC02:51
*** TuanLA has joined #openstack-nova02:52
*** markvoelker has joined #openstack-nova02:53
*** Tom_ has joined #openstack-nova02:55
*** zsli_ is now known as Shunli03:03
*** coreywright has joined #openstack-nova03:07
*** udesale has joined #openstack-nova03:08
*** trungnv has joined #openstack-nova03:17
*** jmlowe has joined #openstack-nova03:17
openstackgerritZhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach interface  https://review.openstack.org/51219003:18
*** salv-orlando has joined #openstack-nova03:19
*** Jaison|away is now known as links03:23
*** salv-orlando has quit IRC03:24
*** dave-mccowan has quit IRC03:24
*** AlexeyAbashkin has joined #openstack-nova03:26
*** markvoelker has quit IRC03:27
*** AlexeyAbashkin has quit IRC03:31
openstackgerritMerged openstack/nova master: Fix nova-manage commands that do not exist  https://review.openstack.org/51232403:33
*** hongbin has quit IRC03:37
*** sridharg has joined #openstack-nova03:38
*** bkopilov has joined #openstack-nova03:39
*** bkopilov_ has joined #openstack-nova03:40
*** nicolasbock has quit IRC03:41
*** mtreinish has quit IRC03:42
*** mtreinish has joined #openstack-nova03:42
*** TuanLA has quit IRC03:45
*** hieulq has quit IRC03:45
*** phuongnh has quit IRC03:45
*** yamahata has joined #openstack-nova03:45
*** TuanLA has joined #openstack-nova03:46
*** phuongnh has joined #openstack-nova03:46
*** masber has quit IRC03:46
*** hieulq has joined #openstack-nova03:46
openstackgerritYikun Jiang proposed openstack/nova-specs master: Add pagination and changes since filter support for os-instance-action API  https://review.openstack.org/50776203:46
*** udesale has quit IRC03:47
*** yangyapeng has quit IRC03:49
*** udesale has joined #openstack-nova03:50
*** mdnadeem has joined #openstack-nova03:50
*** yangyapeng has joined #openstack-nova03:50
*** jmlowe has quit IRC03:52
*** udesale has quit IRC03:52
*** udesale has joined #openstack-nova03:53
*** lbragstad has quit IRC03:58
*** Hazelesque has quit IRC03:59
*** gouthamr has quit IRC03:59
*** BenderRodriguez has joined #openstack-nova04:00
BenderRodriguezHelp!04:00
BenderRodriguezI'm getting http 500 errors when attempting to run "openstack hypervisor list"04:00
BenderRodriguezThe error is shown to be this: EmptyCatalog: The service catalog is empty.04:00
BenderRodriguezhttp://controller:8774/v2.1/os-hypervisors/detail returned with HTTP 50004:00
*** jmlowe has joined #openstack-nova04:01
BenderRodrigueznova is listed as a compute service in "openstack service list"04:01
BenderRodriguezso I'm not sure what's going wrong04:01
BenderRodriguezany ideas?04:01
*** phuongnh has quit IRC04:05
*** phuongnh has joined #openstack-nova04:05
*** Hazelesque has joined #openstack-nova04:05
*** sbezverk has quit IRC04:06
*** sridharg has quit IRC04:06
*** trungnv has quit IRC04:10
*** claudiub has joined #openstack-nova04:11
*** suresh12 has joined #openstack-nova04:15
*** huanxie has quit IRC04:15
*** markvoelker has joined #openstack-nova04:17
*** salv-orlando has joined #openstack-nova04:20
*** markvoelker has quit IRC04:22
*** salv-orlando has quit IRC04:25
*** AlexeyAbashkin has joined #openstack-nova04:26
*** markvoelker has joined #openstack-nova04:27
*** sridharg has joined #openstack-nova04:28
*** AlexeyAbashkin has quit IRC04:31
*** sridharg has quit IRC04:32
*** markvoelker has quit IRC04:33
*** markvoelker has joined #openstack-nova04:34
*** jwcroppe has quit IRC04:35
*** sridharg has joined #openstack-nova04:38
*** jmlowe has quit IRC04:48
*** crushil has quit IRC04:52
*** huanxie has joined #openstack-nova04:59
*** claudiub has quit IRC05:05
priya_BenderRodriguez - check openstack --debug hypervisor list05:06
*** esberglu has joined #openstack-nova05:09
*** esberglu has quit IRC05:09
*** avolkov` has joined #openstack-nova05:10
*** cfriesen has quit IRC05:10
*** avolkov has quit IRC05:11
*** priya_ has quit IRC05:14
*** edmondsw has quit IRC05:17
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Fix missing metavar in aggregate-update  https://review.openstack.org/51248505:19
*** salv-orlando has joined #openstack-nova05:21
*** salv-orlando has quit IRC05:25
*** suresh12 has quit IRC05:32
*** salv-orlando has joined #openstack-nova05:34
*** slaweq has joined #openstack-nova05:35
*** slaweq has quit IRC05:47
*** yangyapeng has quit IRC05:49
*** liusheng has quit IRC05:49
*** edand has joined #openstack-nova05:50
*** Tom__ has joined #openstack-nova05:52
*** slaweq has joined #openstack-nova05:52
*** slaweq has quit IRC05:54
*** trinaths has joined #openstack-nova05:54
*** markvoelker has quit IRC05:54
*** jwcroppe has joined #openstack-nova05:55
*** Tom_ has quit IRC05:56
alex_xuefried: I think the case you talk about can be supported by non-numbered request05:56
alex_xuefried: but the current code doesn't work for that case, that isn't the trait implementation problem, it is the current code implementation problem05:57
*** yangyapeng has joined #openstack-nova05:59
*** jwcroppe has quit IRC05:59
*** karthiks has joined #openstack-nova06:02
*** josecastroleon has joined #openstack-nova06:07
*** Oku_OS-away is now known as Oku_OS06:08
*** gabor_antal has quit IRC06:17
*** hferenc has quit IRC06:17
*** gcb has joined #openstack-nova06:18
*** sahid has joined #openstack-nova06:18
*** sahid has quit IRC06:19
*** sahid has joined #openstack-nova06:19
*** chyka has joined #openstack-nova06:20
*** liusheng has joined #openstack-nova06:21
*** masber has joined #openstack-nova06:21
*** yikun has joined #openstack-nova06:24
*** yikun_ has joined #openstack-nova06:25
*** armax has quit IRC06:25
*** chyka has quit IRC06:25
*** yikun_ has quit IRC06:25
*** armax has joined #openstack-nova06:25
*** armax has quit IRC06:25
*** abhi89 has joined #openstack-nova06:27
*** slaweq has joined #openstack-nova06:37
*** slaweq_ has joined #openstack-nova06:38
*** psachin has quit IRC06:38
openstackgerritjichenjc proposed openstack/nova master: Refactor placement version check  https://review.openstack.org/51249706:40
*** slaweq has quit IRC06:41
*** andreas_s has joined #openstack-nova06:42
*** markus_z has joined #openstack-nova06:44
*** pcaruana has joined #openstack-nova06:44
*** andreas_s has quit IRC06:45
*** vks1 has joined #openstack-nova06:45
*** claudiub has joined #openstack-nova06:46
*** Oku_OS is now known as Oku_OS-away06:46
*** andreas_s has joined #openstack-nova06:47
*** Oku_OS-away is now known as Oku_OS06:50
*** andreas_s has quit IRC06:50
*** markvoelker has joined #openstack-nova06:50
*** psachin has joined #openstack-nova06:51
openstackgerritZhenyu Zheng proposed openstack/nova-specs master: Improve the performance of filtering instances by IP.  https://review.openstack.org/50932606:52
*** andreas__ has joined #openstack-nova06:52
*** gabor_antal has joined #openstack-nova06:57
*** hferenc has joined #openstack-nova06:58
*** edmondsw has joined #openstack-nova07:01
*** andreas_s has joined #openstack-nova07:02
*** bkopilov_ has quit IRC07:02
*** diga has joined #openstack-nova07:04
openstackgerritDai Dang Van proposed openstack/python-novaclient master: Use generic user for both zuul v2 and v3  https://review.openstack.org/51251507:04
*** andreas__ has quit IRC07:05
*** lajoskatona has joined #openstack-nova07:05
*** edmondsw has quit IRC07:06
*** avolkov` has quit IRC07:07
*** avolkov` has joined #openstack-nova07:07
*** sshwarts has joined #openstack-nova07:08
*** slaweq has joined #openstack-nova07:11
*** gjayavelu has joined #openstack-nova07:11
openstackgerritDai Dang Van proposed openstack/python-novaclient master: Use generic user for both zuul v2 and v3  https://review.openstack.org/51251507:13
*** slaweq has quit IRC07:15
*** tesseract has joined #openstack-nova07:16
openstackgerritZhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach interface  https://review.openstack.org/51219007:19
*** acormier has joined #openstack-nova07:22
*** acormier has quit IRC07:27
*** ragiman has joined #openstack-nova07:29
*** ttsiouts has joined #openstack-nova07:31
*** AlexeyAbashkin has joined #openstack-nova07:34
*** ygl has joined #openstack-nova07:36
*** ygl has left #openstack-nova07:36
*** josecastroleon has quit IRC07:37
*** jpena|off is now known as jpena07:43
*** trungnv has joined #openstack-nova07:43
*** mhenkel has quit IRC07:47
*** fragatina has joined #openstack-nova07:48
*** fragatina has quit IRC07:49
*** ralonsoh has joined #openstack-nova07:49
*** fragatina has joined #openstack-nova07:49
*** ralonsoh_ has joined #openstack-nova07:50
*** mhenkel has joined #openstack-nova07:53
*** ralonsoh has quit IRC07:54
*** ralonsoh_ is now known as ralonsoh07:55
*** acormier has joined #openstack-nova07:57
*** acormier has quit IRC07:58
*** acormier has joined #openstack-nova07:58
*** acormier_ has joined #openstack-nova08:02
openstackgerritGhanshyam Mann proposed openstack/nova-specs master: Spec for API extensions policy removal  https://review.openstack.org/50810108:02
*** gjayavelu has quit IRC08:03
*** salv-orlando has quit IRC08:05
*** salv-orlando has joined #openstack-nova08:05
*** takashin has left #openstack-nova08:05
*** acormier has quit IRC08:06
gmannalex_xu: ^^ updated the spec for policy things08:06
*** chyka has joined #openstack-nova08:10
*** chyka has quit IRC08:14
alex_xugmann: thanks, will reach to it before the end of day08:19
*** acormier_ has quit IRC08:20
gmannalex_xu: thanks. also  BPs are separated out with policy change and other extensions merge things. mriedem has approved the specless BP for extensions merge things08:21
alex_xugmann: cool!08:24
openstackgerritAndrey Volkov proposed openstack/osc-placement master: CLI for inventories  https://review.openstack.org/45753308:25
openstackgerritAndrey Volkov proposed openstack/osc-placement master: CLI for allocations  https://review.openstack.org/45753408:25
openstackgerritAndrey Volkov proposed openstack/osc-placement master: CLI for usages  https://review.openstack.org/45753508:25
openstackgerritAndrey Volkov proposed openstack/osc-placement master: CLI for aggregates  https://review.openstack.org/50564308:25
openstackgerritAndrey Volkov proposed openstack/osc-placement master: [WIP] CLI for resource classes  https://review.openstack.org/51118208:25
openstackgerritAndrey Volkov proposed openstack/osc-placement master: [WIP] RP list: member_of and resources parameters  https://review.openstack.org/51118308:25
*** yamahata has quit IRC08:26
*** lucas-afk is now known as lucasagomes08:33
*** derekh has joined #openstack-nova08:34
*** rabel has joined #openstack-nova08:38
rabelhi there, can we finally merge https://review.openstack.org/#/c/494169/ ?08:38
rabeland could someone help me with https://review.openstack.org/#/c/402632/ ? zuul does not seem to be rechecking for a week08:39
*** priteau has joined #openstack-nova08:43
*** dtantsur|afk is now known as dtantsur08:43
openstackgerritAndrey Volkov proposed openstack/osc-placement master: CLI for inventories  https://review.openstack.org/45753308:45
openstackgerritAndrey Volkov proposed openstack/osc-placement master: CLI for allocations  https://review.openstack.org/45753408:45
openstackgerritAndrey Volkov proposed openstack/osc-placement master: CLI for usages  https://review.openstack.org/45753508:45
openstackgerritAndrey Volkov proposed openstack/osc-placement master: CLI for aggregates  https://review.openstack.org/50564308:45
openstackgerritAndrey Volkov proposed openstack/osc-placement master: [WIP] CLI for resource classes  https://review.openstack.org/51118208:45
openstackgerritAndrey Volkov proposed openstack/osc-placement master: [WIP] RP list: member_of and resources parameters  https://review.openstack.org/51118308:45
gibirabel: as http://zuulv3.openstack.org/ does not show that your patch is handled by zuul right now you can simply recheck https://review.openstack.org/#/c/402632/ again08:45
*** sridharg has quit IRC08:45
rabelgibi: thanks for the hint. i did so a week ago, but nothing has happened. do you know why?08:46
*** zen369 has joined #openstack-nova08:46
*** yamamoto has quit IRC08:47
gibirabel: in the past weeks infra tried to migrate from zuul v2 to zuul v3 and that resulted several restart of zuul. I guess your patch was affected by such a restart08:47
rabelgibi: ah ok. thank you!08:48
*** edmondsw has joined #openstack-nova08:50
*** edmondsw has quit IRC08:54
*** yamamoto has joined #openstack-nova08:55
*** yamamoto has quit IRC08:55
*** cdent has joined #openstack-nova08:55
*** rodolof has joined #openstack-nova08:57
*** yikun_jiang has joined #openstack-nova09:01
*** rodolof has quit IRC09:03
*** markvoelker has quit IRC09:03
*** rodolof has joined #openstack-nova09:03
*** yikun has quit IRC09:03
*** yikun_jiang is now known as yikun09:04
*** markvoelker has joined #openstack-nova09:04
jichencdent: hi ,may I ask a placement rest api question?09:04
*** esberglu has joined #openstack-nova09:04
openstackgerritZhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach interface  https://review.openstack.org/51219009:05
cdentjichen: yes, sure. what’s up?09:05
jichencdent: we have some code like : req.response.location = util.resource_class_url(req.environ, rc)09:06
jichenbut I didn't see any response in the output09:06
jichenI think nova compute api has something like Location: xxxx ?09:06
jichenDate: Tue, 17 Oct 2017 08:49:01 GMT09:06
jichenServer: Apache/2.4.18 (Ubuntu)09:06
jichenContent-Length: 6209:06
jichenContent-Type: application/json09:06
jichenOpenStack-API-Version: placement 1.1009:06
jichenvary: OpenStack-API-Version09:06
jichenx-openstack-request-id: req-d638ece0-f12d-4d06-8f04-1f68c8a2165009:06
jichenConnection: close09:06
jichenthis is what I got from a 'curl xxx' to placement09:06
jichenI mean, in the response header, do we plan to have a header about Location or not?09:07
cdentjichen: what request were you making?09:07
*** josecastroleon has joined #openstack-nova09:08
jichencurl -g -i -X PUT "http://192.168.122.243/placement/resource_providers/929b0597-e4e0-47f7-b4af-9a8c2c8f61d0/traits?nameith:CUSTOM" -H "OpenStack-API-Version: compute 2.53" -H "Content-Type: application/json" -H "OpenStack-API-Version: placement 1.10" -H "X-Auth-Token: gAAAAABZ5cPl6wpCFyQIbl2-JLuKEEOiUSNaeu7OGtcqoBRz-mDwP8bGS6IfdA139oVqv4AGKSGHpCBklbx6seqrsNPwUB_yZY5kmUAXxg5B_FB7V99RJV_Db3ovJu2xHlk09:08
jichenYJ5sn9mo3di0kzJtl5AT0dxaL_iCR8GVp1rEEajIwvg0DSk3E8Eo" -d '{"resource_provider_generation": 17, "traits": ["CUSTOM_ABC"]}'09:08
*** esberglu has quit IRC09:09
cdentlocation will show up in response to only some requests: post to create one inventory, post to create a resource class, put to create a resource class, post to create a resource provider, put to create a trait09:09
cdentso in that example you’ve done a PUT to a resource provider, which does not support location header09:09
cdentas written at least09:09
openstackgerritBalazs Gibizer proposed openstack/nova master: Move restart_compute_service to a common place  https://review.openstack.org/51255109:09
openstackgerritBalazs Gibizer proposed openstack/nova master: Enhance service restart in functional env  https://review.openstack.org/51255209:09
openstackgerritBalazs Gibizer proposed openstack/nova master: Reproduce bug 1724172 in the functional test env  https://review.openstack.org/51255309:09
openstackbug 1724172 in OpenStack Compute (nova) "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Undecided,New] https://launchpad.net/bugs/172417209:09
jichenstack@ubuntu1:~$ curl -g -i -X PUT "http://192.168.122.243/placement/resource_providers/929b0597-e4e0-47f7-b4af-9a8c2c8f61d0/traits" -H ack-API-Version: compute 2.53" -H "Content-Type: application/json" -H "OpenStack-API-Version: placement 1.10" -H "X-Auth-Token: gAAAAABZ5cPl6wpCFyQIbl2-JLuKEEOiUSNaeu7OGtcqoBRz-mDwP8bGS6IfdA139oVqv4AGKSGHpCBklbx6seqrsNPwUB_yZY5kmUAXxg5B_FB7V99RJV_Db3ovJu2xHlkYJ5sn09:10
jichen9mo3di0kzJtl5AT0dxaL_iCR8GVp1rEEajIwvg0DSk3E8Eo" -d '{"resource_provider_generation": 18, "traits": ["CUSTOM_ABC"]}'09:10
jichenHTTP/1.1 200 OK09:10
jichenDate: Tue, 17 Oct 2017 09:09:54 GMT09:10
jichenServer: Apache/2.4.18 (Ubuntu)09:10
jichenContent-Length: 6209:10
jichenContent-Type: application/json09:10
jichenOpenStack-API-Version: placement 1.1009:10
jichenvary: OpenStack-API-Version09:10
jichenx-openstack-request-id: req-4ce20136-afb8-405e-86ff-2397a21cc1c209:10
cdentjichen: you’re right that we should probably be consistent about it, but it looks like we weren’t. I think the logic that was used is that a location header is a good idea if the response is empty09:10
jichenConnection: close09:10
jichen{"traits": ["CUSTOM_ABC"], "resource_provider_generation": 19}09:10
jichensorry, wrong lURL09:10
jichen2nd URL I used is to PUT traits09:11
cdentjichen: for long pastes like that it is better to use a pastebin like http://paste.openstack.org/09:11
jichenok, right now09:11
cdentthat’s put to add traits to a resource provider, not to create a trait09:11
*** sahid has quit IRC09:11
jichencdent: http://paste.openstack.org/show/623800/09:11
*** sahid has joined #openstack-nova09:12
*** priya__ has joined #openstack-nova09:13
priya__hi ..could somebody review the commit - https://review.openstack.org/#/c/508533/09:14
cdentjichen: right, so that request corresponds with this handler: https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handlers/trait.py#L217-L248 which does not set the header09:14
cdentjichen: do you think it should?09:14
*** yamamoto has joined #openstack-nova09:15
jichencdent: I guess I used wrong URL ... I think we should not add a header as this is a just 'associate'09:16
*** sree has quit IRC09:16
jichenso I will update the document of placement api ref.. it doesn't have the info about this header09:16
*** sdague has joined #openstack-nova09:17
masbergood afternoon all, I am having an issue resizing nodes. My hardware runs NUMA and I pin my vcpus for better performance. I could not resize the instance because it could not fit any NUMA node so what I did was to shutdown the vms on that node so the kvm could relocate them and make more space for the extra resources09:18
cdentI think we didn’t end up adding the info about headers because there’s no clear use case for them. When I wrote the first bits of the code that did add a location header, I did it because it is standard form: create something? then put a location header in the response. We don’t necessarily need to cloud the documentation with that except perhaps in the case of POST /resource_providers  (because that tells you wha09:18
cdentwas created)09:18
cdentjichen: in everything else there are other ways09:19
masberI resized the node while it was shutdown, and then I tried to confirm the resize but confirmation failed saying "cannot resize instance while it is in vm_state resized"09:19
*** mdnadeem has quit IRC09:19
*** udesale__ has joined #openstack-nova09:19
*** sree has joined #openstack-nova09:19
masbersince then I can even start resizing the node as state stays as active09:19
masber*can't09:19
*** udesale has quit IRC09:19
masberis this a bug or am I doing something stupid?09:20
*** sambetts|afk is now known as sambetts09:20
*** andreas_s has quit IRC09:21
jichencdent: ok, I can live with that, I thought we return location for every thing we created like you mentioned; and you are right, seems no clear use case for that, thanks for your guide09:21
cdentjichen: you’re welcome, and thank you for trying to make sure we are consistent, we can probalby do better on that.09:21
*** udesale__ has quit IRC09:22
jichencdent: yes, I will make more analysis on that :), thanks09:22
*** udesale has joined #openstack-nova09:22
openstackgerritAndrey Volkov proposed openstack/osc-placement master: CLI for allocations  https://review.openstack.org/45753409:22
openstackgerritAndrey Volkov proposed openstack/osc-placement master: CLI for usages  https://review.openstack.org/45753509:22
openstackgerritAndrey Volkov proposed openstack/osc-placement master: CLI for aggregates  https://review.openstack.org/50564309:22
openstackgerritAndrey Volkov proposed openstack/osc-placement master: [WIP] CLI for resource classes  https://review.openstack.org/51118209:22
openstackgerritAndrey Volkov proposed openstack/osc-placement master: [WIP] RP list: member_of and resources parameters  https://review.openstack.org/51118309:22
*** liusheng has quit IRC09:22
*** liusheng has joined #openstack-nova09:23
*** sree has quit IRC09:23
*** yikun has quit IRC09:25
*** Tom__ has quit IRC09:28
*** liusheng has quit IRC09:28
*** liusheng has joined #openstack-nova09:28
*** Shunli has quit IRC09:29
*** andreas_s has joined #openstack-nova09:30
*** slaweq has joined #openstack-nova09:30
*** yingjun has quit IRC09:30
priya__cdent : Could you please review  https://review.openstack.org/#/c/508533/09:31
cdentpriya__: yes, will put it on my list for today09:32
priya__thank you !09:33
*** mdnadeem has joined #openstack-nova09:34
*** slaweq has quit IRC09:35
*** yikun has joined #openstack-nova09:35
*** mdnadeem has quit IRC09:44
*** salv-orlando has quit IRC09:50
*** ociuhandu has quit IRC09:50
*** salv-orlando has joined #openstack-nova09:50
*** yassine has quit IRC09:52
*** priya__ has quit IRC09:55
*** salv-orlando has quit IRC09:55
*** jichen has quit IRC09:59
*** esberglu has joined #openstack-nova09:59
*** esberglu has quit IRC09:59
*** mdnadeem has joined #openstack-nova10:00
*** sree has joined #openstack-nova10:02
*** andreas_s has quit IRC10:02
*** TuanLA has quit IRC10:05
*** trungnv has quit IRC10:05
*** sree has quit IRC10:06
*** kuzko has quit IRC10:06
*** gmann is now known as gmann_afk10:09
*** kuzko has joined #openstack-nova10:14
*** yamamoto has quit IRC10:18
*** mvk has quit IRC10:19
*** priteau has quit IRC10:19
*** acormier has joined #openstack-nova10:21
*** priteau has joined #openstack-nova10:21
*** gszasz has joined #openstack-nova10:21
*** cdent has quit IRC10:22
*** Jeffrey4l has quit IRC10:24
*** Jeffrey4l has joined #openstack-nova10:24
*** acormier has quit IRC10:25
*** zqfan has joined #openstack-nova10:25
*** yamamoto has joined #openstack-nova10:25
*** cdent has joined #openstack-nova10:26
*** zqfan has quit IRC10:27
*** ociuhandu has joined #openstack-nova10:27
*** vvargaszte has joined #openstack-nova10:28
*** cdent has quit IRC10:29
*** yamamoto has quit IRC10:30
*** liusheng has quit IRC10:32
*** salv-orlando has joined #openstack-nova10:32
*** liusheng has joined #openstack-nova10:32
*** slaweq has joined #openstack-nova10:32
*** Jeffrey4l has quit IRC10:33
*** openstackgerrit has quit IRC10:33
*** Jeffrey4l has joined #openstack-nova10:33
*** andreas_s has joined #openstack-nova10:35
*** slaweq has quit IRC10:37
*** edmondsw has joined #openstack-nova10:38
*** edmondsw has quit IRC10:42
*** tesseract has quit IRC10:43
*** tesseract has joined #openstack-nova10:43
*** openstackgerrit has joined #openstack-nova10:45
openstackgerritNaichuan Sun proposed openstack/nova master: VGPU_support: add enabled white list  https://review.openstack.org/51258010:45
*** tbachman has quit IRC10:45
*** bkopilov has quit IRC10:46
*** mvk has joined #openstack-nova10:50
*** priteau has quit IRC10:52
*** esberglu has joined #openstack-nova10:52
*** vvargaszte has quit IRC10:55
*** sree has joined #openstack-nova10:55
*** yangyapeng has quit IRC10:55
*** esberglu has quit IRC10:57
*** nicolasbock has joined #openstack-nova11:02
*** zhuli has joined #openstack-nova11:08
*** zhuli has left #openstack-nova11:10
*** yassine has joined #openstack-nova11:11
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova master: Change 'InstancePCIRequest' spec field  https://review.openstack.org/44925711:11
*** sridharg has joined #openstack-nova11:12
*** lucasagomes is now known as lucas-hungry11:13
ralonsohalex_xu: hi, if you have time, can you take a look at https://review.openstack.org/#/c/502306/?11:16
ralonsohalex_xu: BTW, this one was approved last cycle. Half of the code is already merged. I would like to have it approved this cycle to continue the work: https://review.openstack.org/#/c/504895/11:17
*** huanxie has quit IRC11:20
*** nicolasbock has quit IRC11:23
openstackgerritedan david proposed openstack/nova master: Don't overwrite binding-profile  https://review.openstack.org/50561311:24
*** yamamoto has joined #openstack-nova11:26
*** dtantsur is now known as dtantsur|brb11:28
*** yamamoto has quit IRC11:32
*** cdent has joined #openstack-nova11:34
*** Tom_ has joined #openstack-nova11:34
*** nicolasbock has joined #openstack-nova11:35
*** udesale has quit IRC11:38
*** smatzek has joined #openstack-nova11:39
*** Tom_ has quit IRC11:39
*** yamamoto has joined #openstack-nova11:41
*** yamamoto_ has joined #openstack-nova11:42
*** udesale has joined #openstack-nova11:44
*** yamamoto has quit IRC11:46
*** chyka has joined #openstack-nova11:46
*** chyka has quit IRC11:51
*** salv-orlando has quit IRC11:54
*** markus_zz has joined #openstack-nova11:54
*** yamamoto_ has quit IRC11:56
*** vks1 has quit IRC11:56
*** markus_z has quit IRC11:57
*** phuongnh has quit IRC12:01
*** udesale has quit IRC12:01
*** liusheng has quit IRC12:02
*** liusheng has joined #openstack-nova12:03
*** jpena is now known as jpena|lunch12:04
*** Tom__ has joined #openstack-nova12:08
*** edmondsw has joined #openstack-nova12:09
*** jmlowe has joined #openstack-nova12:09
*** liverpooler has joined #openstack-nova12:10
*** vladikr has joined #openstack-nova12:13
*** READ10 has joined #openstack-nova12:14
*** pchavva has joined #openstack-nova12:15
*** liverpooler has quit IRC12:16
*** liverpooler has joined #openstack-nova12:17
*** yamamoto has joined #openstack-nova12:19
*** lucas-hungry is now known as lucasagomes12:19
*** bkopilov has joined #openstack-nova12:20
cdentalex_xu: if you didn’t see this bit of irc chat yesterday, it covers some of the issues with shared providers and traits: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2017-10-16.log.html#t2017-10-16T18:37:1812:21
cdentit took quite a while to figure out what efried was talking about but we finally figured it out in that chat12:21
*** dave-mccowan has joined #openstack-nova12:21
* efried rolls eyes12:24
efriedThat's me.  It can take a while to figure out wtf I'm talking about.12:25
efriedI'd like to think it's because they're such advanced concepts, I have to explain them carefully to lesser mortals.12:25
efried(In case you're just joining us, naw, that ain't it.)12:25
cdentthat ^^ was driven by alex’s latest comment on your spec, on the principle of more context is better12:26
efriedcdent I know, and I appreciate it.  I'm just ribbin ya.12:27
*** diga has quit IRC12:29
cdentI know, I’m giving you context on the context giving, for sake of contextualizing the people in our context, contextually12:29
alex_xuralonsoh: yea, add it to my review list12:29
cdentsoon the ai which is learning human behavior from the log of this channel will achieve consciousness, and presumably wipe us from the face of the earth12:30
alex_xucdent: efried yea, I read that today12:30
alex_xucdent: efried, the current trait implement supports that case12:30
alex_xuthe current trait implement will try to collect the traits from the RP and sharing RP which in the same aggregates12:31
efriedalex_xu The case where RAID5 and SSD are split across the compute RP and the shared storage RP?12:31
alex_xuthe problem is the current implementation of https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L2453 doesn't return the correct PRs12:32
alex_xu_get_all_with_shared only return that root RP once.12:33
cdentalex_xu: root is a bad term in this context :)12:33
efriedalex_xu My contention is that it *can't* return the correct RPs for this scenario under the current semantics.12:33
cdentefried: your forthcoming test will make it all clear :D12:33
alex_xufor that case, actually we expect return that root RP twoice, and then we should generate two combinations: #1 root RP with local disk, #2 root RP with shared disk12:34
alex_xucdent: forgive me, let me use root rp first :) that pain for me also12:34
efriedalex_xu Actually, it won't return the compute+localdisk combination, because that wouldn't satisfy the RAID5 trait.12:34
alex_xuand then, the trait implementation will find out #1 and #2 which have enough trait12:34
efriedBut it *will* return the compute+shared combination, even though it *shouldn't*.12:35
efriedIt shouldn't because the shared storage doesn't satisfy the SSD trait.  But placement has no way of knowing that RAID & SSD were both supposed to apply to the storage, whereas the HW_CPU... trait wasn't.12:36
*** gabor_antal_ has joined #openstack-nova12:37
*** peter-hamilton has joined #openstack-nova12:37
alex_xuefried: I didn't have test it, but I think the current code will return compute+local12:37
alex_xuand it never return the compute+shared combination12:38
efriedalex_xu Because of that bug?  Maybe.12:38
*** gabor_antal has quit IRC12:38
alex_xubecause the implement of _get_all_with_shared12:38
alex_xubut that still doesn't correct, you are expecting _get_all_with_shared return two combinations12:39
efried_get_all_with_shared is the piece that doesn't yet take traits into account?12:39
*** salv-orlando has joined #openstack-nova12:40
alex_xuand then the trait implement will filter out the correct one12:40
alex_xuefried: yes12:40
efriedRight, gotcha.  So you're right: _get_all_with_shared *should* return *both* combinations.  (If it's not, that's a bug.)12:40
efriedAnd then the code you're writing *should* filter *both* of them out and yield zero candidates.12:40
alex_xuefried: because this https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L89512:40
efriedBut there's no way to write your code to do that.12:41
alex_xuthat condition assumes that there only have the one case in (local and shared)12:41
alex_xuefried: but the first thing we should figure out is that whether we want to support that case12:41
efriedohh, you're missing a LEFT JOIN12:41
efriedWell, I contend we can't *not* support that case.12:42
efriedAt least not long term.12:42
cdentI’m going to save [t 3Vz8] because it is probably useful to whip out just about any time12:42
purplerbot<efried> ohh, you're missing a LEFT JOIN [2017-10-17 12:41:57.325623] [n 3Vz8]12:42
efried(c) 201712:43
efriedSo alex_xu, if we were going to say we don't support that scenario, how would that be worded?12:44
alex_xuat least, currently the nova doesn't support the case we have local disk and shared disk12:44
alex_xuactually nova doesn't know about the disk is local or shared, it just create the instance image in a directory12:45
alex_xuunder that directory, it maybe local or a NFS...12:45
efriedalex_xu What about local ephemeral (boot) plus volumes?12:45
alex_xuand I didn't have any real world case similar to that in my mind12:46
alex_xuefried: the resource class DISK_GB is only about local ephemeral disk12:46
alex_xus/local ephemeral disk/ephemeral disk/12:46
openstackgerritEric Fried proposed openstack/nova master: placement: set/check if inventory change in tree  https://review.openstack.org/47057512:47
efriedalex_xu fixed nit ^12:48
*** mriedem has joined #openstack-nova12:49
efriedcdent Did you want me to rename that 'p' var ^ ?12:49
efriedcdent I don't think we can afford to sweep this under the rug now and just hope it doesn't rear its head later.12:50
efriedSorry, that was meant for alex_xu12:50
efried(I *totally* think we can sweep a terse variable name under the rug)12:50
*** jpena|lunch is now known as jpena12:51
efried('p' for 'precedent'.)12:51
efriedSo let's try this again.12:51
efriedalex_xu I don't think we can afford to sweep this under the rug now and just hope it doesn't rear its head later.12:51
efriedalex_xu At the moment, the scope of where this code is used is very contained, and possibly never even makes its way to where the user can see it.12:52
*** esberglu has joined #openstack-nova12:52
*** vvargaszte has joined #openstack-nova12:52
alex_xuefried: sorry, I still didn't get you :), maybe...not use the 'rug', I didn't get what rug is reference to after search the dictionary..12:52
efriedalex_xu But once we start allowing drivers to model their RPs and operators to specify their resources generically, this will wind up being a nontrivial bug we'll have to scramble to fix.12:53
*** yangyapeng has joined #openstack-nova12:53
cdentefried: I’ve lost the fight on terse variable names, and surrender graciously to fight other battles another day.12:53
efriedalex_xu Sorry, idiom.  "Sweep under the rug" means "ignore it for now and hope nobody notices"12:53
mriedemjohnthetubaguy: can i get you to take a look at this file injection deprecation spec? has a +2 from sdague, looking for another +2 https://review.openstack.org/#/c/509013/12:53
*** vvargaszte has quit IRC12:54
*** yamamoto has quit IRC12:54
alex_xuefried: ok, you mean the shared RP case, right? we can file a bug for it12:55
openstackgerritEric Fried proposed openstack/nova master: placement: set/check if inventory change in tree  https://review.openstack.org/47057512:57
alex_xuI should read the 'sweep this under the rug', not just panic on the single 'rug'.12:57
*** trinaths has left #openstack-nova12:59
*** vivsoni has quit IRC12:59
efriedalex_xu I can't find an equivalent Chinese idiom, but perhaps 掩饰 gets close.13:00
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Rename add-zvm-driver spec  https://review.openstack.org/51260613:00
*** mdnadeem has quit IRC13:02
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Add memoize function using oslo.cache  https://review.openstack.org/47277313:02
alex_xuefried: hehe, i get that13:03
*** jmlowe has quit IRC13:04
efriedalex_xu Fixed that other docstring; cdent renamed the variable, just for you :)13:05
alex_xuefried: cool, thanks13:06
*** andreas_s has quit IRC13:07
*** andreas_s has joined #openstack-nova13:07
alex_xuefried: also leaved a question in https://review.openstack.org/#/c/510244/13:07
*** jmlowe has joined #openstack-nova13:09
*** lyan has joined #openstack-nova13:09
alex_xuralonsoh: fyi first, I don't have +2 for the nova-spec :)13:10
ralonsohalex_xu: no problem! thanks for your time13:10
cdentefried: the setUp in these compute manager related tests are … wow. Not the stuff you’ve added, but what was already there.13:12
*** liuyulong has quit IRC13:12
efriedcdent I don't disagree.13:13
efriedI've got two more UTs to fix, btw.13:13
efriedBut thanks for looking.13:13
*** vivsoni has joined #openstack-nova13:13
*** thorst has joined #openstack-nova13:14
cdentefried: yeah, I know it’s not complete, I just went by because I wanted to understand the point of it all13:14
efriedcdent Hopefully the latest commit message makes it clear why we need this; let me know if not.13:15
cdentyeah, it does13:17
*** baoli has joined #openstack-nova13:20
*** dtantsur|brb is now known as dtantsur13:21
*** andreas_s has quit IRC13:21
*** jmlowe has quit IRC13:21
*** lbragstad has joined #openstack-nova13:22
efriedalex_xu Responded to that comment - let me know if you want to discuss.13:25
*** sree has quit IRC13:25
efriedalex_xu The code for looking stuff up in nested RPs - I'm not sure if that's part of Jay's series yet.13:25
*** sree has joined #openstack-nova13:26
*** andreas_s has joined #openstack-nova13:26
alex_xuefried: yea, I also want to ask the nested RP support for non-numbered request is implemented by which BP13:27
alex_xuefried: I check the Jay's spec about nested RP, looks like that isn't included in the spec13:27
efriedalex_xu I remember talking about it - specifically about trait propagation - in some spec or other.13:28
efriedalex_xu Oh!  It was *your* spec :)13:28
alex_xuefried: for the question in your spec, is there any way we can try to find SRIOV_NET_VF and NET_EGRESS_BYTES_SEC from the same RPs for the non-numbered request?13:28
alex_xuok...13:28
alex_xusounds like we are missing one more spec?13:29
efriedalex_xu I don't see how that would work.  Because then you would be ignoring the relationship between RPs in a tree.13:29
bauzassahid: there could be some regression in Pike for CPU pinning when you evacuate https://bugs.launchpad.net/nova/+bug/172300513:29
openstackLaunchpad bug 1723005 in OpenStack Compute (nova) "CPUPinningInvalid exception occurred when evacuate one instance repeatedly." [High,Confirmed]13:29
*** sree has quit IRC13:30
efriedalex_xu In other words, if you made it work that way, there would be all the "normal" cases that wouldn't yield any results.13:30
openstackgerritedan david proposed openstack/nova master: Don't overwrite binding-profile  https://review.openstack.org/50561313:30
alex_xuefried: why13:31
openstackgerritMerged openstack/nova-specs master: Rename add-zvm-driver spec  https://review.openstack.org/51260613:31
sahidbauzas: not sure we have supported that at some point13:31
*** smatzek has quit IRC13:31
efriedalex_xu Okay, can we agree that we would *not* want to get a candidate like { RP1: { SRIOV_NET_VF: 1 }, RP2: { NET_EGRESS_BW: 10000 } } ?13:32
bauzassahid: you mean evacuating an instance that was pinning a CPU ?13:32
bauzassahid: or any move ops ?13:33
alex_xuefried: yes13:33
efriedalex_xu Then in order for that to work, you have to do your selection to make sure those inventories come from the *same* RP.13:34
efriedalex_xu So let's extend the model to include VCPU and MEMORY_MB.  Those would be in the root RP.  But the VF resources are still in the child RPs.13:35
alex_xuefried: or to say try the best, if the RP doesn't have all resources, then looking for the child or shared13:35
*** vks1 has joined #openstack-nova13:35
*** andreas_s has quit IRC13:36
sahidbauzas: pinned instances... there were a patch serie pushed by nikola long time ago but never get merged unfortunatly13:36
bauzassahid: if you speak of live-migration claims, it's unrelated13:36
sahidi think it never get merged because the work on-going with resource providers and placement :)13:36
efriedalex_xu Mm... that *could* work.13:37
bauzassahid: because we already claim on rebuilds13:37
openstackgerritMerged openstack/nova-specs master: Deprecate file injection  https://review.openstack.org/50901313:37
alex_xuefried: and how the request with CPU and MEMORY_MB and SRIOV_NET_VF works? it try to the best? get CPU and MEMORY_MB from the root RP, and then try the child?13:38
sahidbauzas: yes but that need to be checked whether we buil a new domain xml based on that new claim or not13:38
sahidif it not so we o not support that13:38
alex_xuthat I feel no-one is talking about how the non-numbered request works for the nested RP...13:39
efriedalex_xu But if e.g. RP1 is exhausted of VFs and RP2 is exhausted of bandwidth, I think you would wind up giving me a candidate with { COMPUTE_RP: { VCPU, MEMORY_MB }, RP1 { NET_EGRESS_BW }, RP2 { SRIOV_NET_VF } }13:39
alex_xuefried: for that case, we shouldn't return any condidates13:39
efriedalex_xu Shouldn't, I agree.  But that's going to be tricky to code.13:40
alex_xuso the logic is try the best on the same node or child node or shared node13:40
alex_xus/node/RP/13:40
bauzassahid: so technically, we can't move or rebuild a pinned instance, I see13:40
*** xyang1 has joined #openstack-nova13:40
*** andreas_s has joined #openstack-nova13:41
efriedalex_xu If you think that through, though, I don't think you can get it to work in the general case.13:41
*** andreas_s has quit IRC13:41
*** andreas_s has joined #openstack-nova13:41
sahidyes, but only if the pinning of domain xml is updated which was addressed in one of the patch from nikola13:41
openstackgerritIldiko Vancsa proposed openstack/nova-specs master: Add multiattach support to Nova  https://review.openstack.org/49977713:41
*** sree has joined #openstack-nova13:41
*** cdent has quit IRC13:41
alex_xuefried: sorry, try the best on the same node, then child, then shared, I should use 'then'13:42
ildikovjohnthetubaguy: mriedem: new version of the multi-attach spec ^^13:42
sahidfor cold you might have right, if we do build a new domain from scratch so we are OK13:42
*** tbachman has joined #openstack-nova13:42
efriedalex_xu Let's look at another scenario: the compute RP is empty (or let's say it has just the local DISK_GB resource).  Then we have two NUMA nodes which each contain VCPU & MEMORY_MB resources.  Then we also have two PF RPs which each contain VF and EGRESS_BW resources.13:42
ildikovjohnthetubaguy: mriedem: a question there is about delete_on_termination as there is one case where an exception gets raised when the volume couldn't be deleted13:42
*** gouthamr has joined #openstack-nova13:43
*** tbachman_ has joined #openstack-nova13:43
ildikovjohnthetubaguy: mriedem: discussion about it is here: https://review.openstack.org/#/c/499777/4/specs/queens/approved/cinder-volume-multi-attach.rst13:43
*** felipemonteiro_ has joined #openstack-nova13:43
bauzassahid: in other words, any move operation that is not regenerating the domain XML is not working if you have pinned instances, I see13:43
ildikovjohnthetubaguy: mriedem: please let me know what would be the preference on keeping this as an allowed action or disable it13:43
efriedalex_xu We've agreed you can't just look for everything in the same RP.  So *either* [you're looking for all the resources in the same "branch"] *or* [you're allowing them to be spread out across all RPs in the tree].13:44
*** felipemonteiro__ has joined #openstack-nova13:44
ildikovjohnthetubaguy: mriedem: I would say keep what we agreed on earlier, but open to new suggestions13:44
sahidyes, or you need to have on the destination node the same CPU topology and more of that have the pCPUs free13:44
efriedalex_xu In this scenario, I want to make sure my VCPU & MEMORY_MB come from the same RP; and my VF & BW come from the same RP.13:44
efried(I'm assuming the PF doesn't belong to a NUMA node)13:45
*** gcb has quit IRC13:45
mriedemmelwitt: jbernard: assuming this works https://review.openstack.org/512622 we'll need that to unblock nova changes in stable < pike13:45
dansmithmriedem: melwitt: Is this known? http://logs.openstack.org/56/512456/1/check/legacy-tempest-dsvm-multinode-live-migration/5c3869e/job-output.txt.gz#_2017-10-17_01_30_14_50919613:45
dansmithpy3 rados packages missing on pike13:46
openstackgerritYushiro FURUKAWA proposed openstack/nova master: virt/ironic: Implement rescue and unrescue  https://review.openstack.org/41648713:46
openstackgerritBalazs Gibizer proposed openstack/nova master: Enhance service restart in functional env  https://review.openstack.org/51255213:46
openstackgerritBalazs Gibizer proposed openstack/nova master: Reproduce bug 1724172 in the functional test env  https://review.openstack.org/51255313:46
openstackbug 1724172 in OpenStack Compute (nova) "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Undecided,New] https://launchpad.net/bugs/1724172 - Assigned to Balazs Gibizer (balazs-gibizer)13:46
openstackgerritBalazs Gibizer proposed openstack/nova master: cleanup evacuated instances not on hypervisor  https://review.openstack.org/51262313:46
mriedemdansmith: see ^13:46
mriedem:)13:46
*** sree has quit IRC13:46
dansmithmriedem: you said < pike13:46
*** tbachman has quit IRC13:46
*** tbachman_ is now known as tbachman13:46
mriedemi was told python3 packages were in the pike UCA13:46
mriedemmaybe they arent13:46
mriedemdansmith: same problem though13:46
dansmithokay13:47
*** gcb has joined #openstack-nova13:47
mriedemhttps://review.openstack.org/#/c/512622/ should fix it13:47
*** felipemonteiro_ has quit IRC13:48
alex_xuefried: yes, for that case, we defintely need the numbered request. I think the case we only request VCPU & MEMORY_MB and VF, this case whether can work for non-numbered request13:48
openstackgerritsean mooney proposed openstack/nova-specs master: Use neutron's new port binding API  https://review.openstack.org/37558013:51
efriedalex_xu But you're right - it sounds like we need to write up some scenarios for the non-numbered group.  Not sure where it would be appropriate to do that.  Perhaps a delta to your traits-in-allocations spec?13:51
*** psachin has quit IRC13:52
openstackgerritIldiko Vancsa proposed openstack/nova master: Add attachment_get to refresh_connection_info  https://review.openstack.org/51262613:53
*** catintheroof has joined #openstack-nova13:53
*** esberglu has quit IRC13:54
*** acormier has joined #openstack-nova13:54
openstackgerritIldiko Vancsa proposed openstack/nova master: update live migration to use v3 cinder api  https://review.openstack.org/46398713:54
*** esberglu has joined #openstack-nova13:54
alex_xuefried: yea, i'm not sure it should be in the trait spec, but I feel it should be at somewhere13:54
*** yamamoto has joined #openstack-nova13:55
efriedalex_xu I covered some of it in passing in the granular request syntax spec, but dansmith will eviscerate me if I put more words in that one.13:56
dansmithefried: not only that,13:56
dansmithefried: but I'm reserving my +2 until you remove some :)13:56
*** Jeffrey4l has quit IRC13:56
efriedvay, really?  Sigh, okay.13:56
efriedI read "just a tip" as "do better next time"13:57
dansmithefried: the two use cases you call out and then say are out of scope really need to go, IMHO13:57
dansmiththe just a tip bit was a suggestion, and I think you should13:58
alex_xulearned a new word 'eviscerate', that is terrible13:58
dansmithlol13:58
dansmithalex_xu: his word not mine :)13:58
*** armax has joined #openstack-nova13:58
alex_xuokay..13:58
*** awaugama has joined #openstack-nova13:58
*** acormier has quit IRC13:58
mriedemdansmith: if you're looking at stuff for pike, we need to get this fix in and backported to pike https://review.openstack.org/#/c/510938/13:59
*** Jeffrey4l has joined #openstack-nova13:59
*** smatzek has joined #openstack-nova13:59
mriedemotherwise restart after evacuate blows up13:59
openstackgerritEric Fried proposed openstack/nova master: Send Allocations to spawn  https://review.openstack.org/51187913:59
*** esberglu has quit IRC13:59
dansmithmriedem: I was just looking at your backport of my context fix when I saw that13:59
efrieddansmith This ^ oughtta be passing now, I believe.13:59
dansmithefried: I was just getting ready to respond to cdent on that13:59
*** smatzek has quit IRC14:00
mriedembauzas: you want to look at this then? https://review.openstack.org/#/c/510938/14:00
mriedemneed to wrangle our pike fixes for a release14:00
mriedemsince we have several high severity ones that are unreleased14:01
*** smatzek has joined #openstack-nova14:01
*** cfriesen has joined #openstack-nova14:01
efrieddansmith I'll wait to respond until I see what you have to say, then.14:01
*** sbezverk has joined #openstack-nova14:01
*** cleong has joined #openstack-nova14:02
bauzasmriedem: sure, will look14:02
gibimriedem: there is another bug 1724172 with fix top of https://review.openstack.org/#/c/510938/14:03
openstackbug 1724172 in OpenStack Compute (nova) "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Undecided,In progress] https://launchpad.net/bugs/1724172 - Assigned to Balazs Gibizer (balazs-gibizer)14:03
bauzasedmondsw: sdague: does that https://bugs.launchpad.net/nova/+bug/1716344 ring a bell to you ? (tl;dr: the fact that we only lookup the public endpoint when querying the SC)14:03
openstackLaunchpad bug 1716344 in OpenStack Compute (nova) "Nova-API uses Keystone's public endpoint for project id verification" [Undecided,New]14:03
johnthetubaguyedmondsw: very late but I found that patch you were asking me about that the PTG, at least I think you asked me: https://review.openstack.org/#/c/43487014:04
*** yamamoto has quit IRC14:05
*** jwcroppe has joined #openstack-nova14:06
*** slaweq has joined #openstack-nova14:06
mriedemildikov: reading14:07
sdaguebauzas: so, we might be missing an option there14:07
*** thingee has quit IRC14:07
sdaguethat being said, this is definitely never called in vm crate14:07
sdaguecreate14:07
sdaguethe only places this path is called is quota updates and flavor access calls14:08
dansmithefried: left you a suggestion about the actual method, and one about cdent's retry14:09
dansmithefried: the retry could be a follow-on since it really isn't related to this if you use the common method14:09
*** esberglu has joined #openstack-nova14:09
ildikovmriedem: tnx14:09
efrieddansmith Roger wilco, and thanks.14:09
ildikovmriedem: as the spec deadline is coming up I'm trying to clean this one up so we can merge it and update later on specifics if needed14:10
efrieddansmith Did you mean report.SchedulerReportClient.get_allocations_for_instance?14:10
dansmithefried: rebase14:11
efrieddansmith ah, beaut.14:11
*** slaweq has quit IRC14:11
dansmithefried: https://review.openstack.org/#/c/511306/14:11
mriedembauzas: replied in that bug14:11
bauzassdague: you mean, calling verify_project_id is just made by quota updates and flavor calls?14:11
mriedemefried: your new ksa adapter stuff defaults to the internal interface right?14:11
mriedemit goes internal and then public?14:11
*** catintheroof has quit IRC14:11
mriedembauzas: correct14:11
mriedemit wouldn't make vm create fail14:11
efriedmriedem Yes14:12
*** Nil_ has joined #openstack-nova14:12
efriedmriedem nova.conf.utils.py L4714:12
mriedemok, just checking. we can't rely on that for fixing this anyway.14:12
mriedemsince the fix here would have to be backported14:12
bauzasmriedem: okay, so I'll triage it as Wontfix if that bug is punted by efried's KSA rework14:13
mriedembauzas: i don't think that's the right way to handle this14:13
bauzasopen to ideas :)14:13
mriedemyou can't backport the ksa fixes14:13
bauzasso we at least need to idenfify the impact14:14
mriedemand we effectively made a backward incompatible change in pike to those apis14:14
mriedemyou can't update quota or flavor access if nova can't access keystone's public endpoint14:14
bauzasso it was a design decision to use the public endpoint for such calls ?14:14
bauzasI'm having trouble understanding your sentence about ^14:15
mriedemyes, but the same design decision was made with placement and we later changed that when someone said it broke their deployment14:15
bauzasI mean "There was a conscious decision to hard-code the public endpoint as the  interface when this change was made, but we changed that hard-coding for  nova talking to the placement endpoint so I don't see why we wouldn't  also allow different endpoints for talking to keystone. "14:15
bauzasah gotcha14:15
bauzasmriedem: there are 2 possibilities honestly14:15
mriedemhttps://review.openstack.org/#/c/435010/6/nova/identity.py@3414:16
bauzasmriedem: either we say it's a bug that is backportable, and I'm tagging the bug as Confirmed14:16
edmondswjohnthetubaguy thanks! Looking at it now14:16
sdaguemriedem: what is your concern here?14:17
bauzasmriedem: or we just consider it's more a new design rearchitecture, and in that case, that would make the changes very difficult to backport14:17
*** edand has quit IRC14:17
mriedem"Keystone's public endpoint should only visible to external clients. All  internal OpenStack services should use the internalURL for  authentication purposes. I think my configuration is correct. The  "auth_url" point to Keystone's internal URL, whereas "auth_uri" points  to Keystone's public endpoint. I want to avoid https based communication  for my internal cloud services."14:17
*** burt has joined #openstack-nova14:18
sdaguemriedem: yes, I've read the bug. I don't understand the backwards incompatibility concern14:19
*** yamahata has joined #openstack-nova14:19
mriedemasking for clarification in the bug14:20
mriedemit's not clear to me if the apis fail, or if they just dump errors14:20
sdagueI think it's a real fail14:20
sdaguebut not on the API call they stated14:20
mriedemyes it's not instance create14:21
*** dave-mccowan has quit IRC14:21
mriedemthey later said it was the flavor access project id verification14:21
mriedem"It took some time to narrow down the problem. The issue was introduced  with the Pike release, where project id verification for flavor access  and quota modification got added."14:21
*** gongysh has joined #openstack-nova14:22
gongyshhi14:22
mriedemi don't think the api actually fails, they hit this: https://github.com/openstack/nova/blob/master/nova/api/openstack/identity.py#L5714:22
gongyshit seems the nested-quota is not implemented yet. right?14:22
mriedemwhich dumps a stacktrace and returns True14:22
mriedemgongysh: correct14:22
gongyshmriedem, do you if there is alter option?14:23
sdaguemriedem: it might b14:23
mriedemgongysh: not in nova no14:23
*** crushil has joined #openstack-nova14:23
mriedemgongysh: see the unified limits effort in keystone14:23
mriedemgongysh: https://specs.openstack.org/openstack/keystone-specs/specs/keystone/ongoing/unified-limits.html14:23
*** lajoskatona has left #openstack-nova14:26
*** zen369 has quit IRC14:26
mriedemildikov: johnthetubaguy: replied in https://review.openstack.org/#/c/499777/4 about delete_on_termination14:29
mriedemtl;dr is that if we fail to delete a volume we handle the error and log a warning, everywhere14:30
johnthetubaguymriedem: so you think we just allow delete_on_termination for multi-attach volumes?14:30
openstackgerritIldiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow  https://review.openstack.org/33028514:30
mriedemso if you boot from volume with a multi-attach volume and specify delete_on_termination=True, and that volume is attached to another instance when the first is deleted, it won't prevent the deletion on the first instance, it will just log a warning in the logs about being unable to delete the volume14:30
*** gongysh has quit IRC14:31
johnthetubaguyI guess it would just be deleted by the last detach, probably14:31
mriedemjohnthetubaguy: i'm not sure there is a great reason to not allow it14:31
mriedemjohnthetubaguy: well, not necessarily14:31
mriedemif instance A and B are attached to volume X, and A.delete_on_termination=True and B.delete_on_termination=False, then deleting A won't delete X and deleting B won't either14:32
johnthetubaguyI think its a race for the delete, like it could delete it14:32
johnthetubaguyyeah14:32
*** slaweq_ has quit IRC14:32
johnthetubaguyI should have defined my "probably" bit better14:32
mriedemif B is deleted before A, then yes X would be deleted14:32
mriedemultimately the lock is supposed to be on the cinder side14:33
johnthetubaguy++14:33
*** edand has joined #openstack-nova14:33
mriedemand i think it's just something a user would have to understand if they are attaching a multi-attach volume to an instance with delete_on_termination, that nova can't actually delete that volume if it's attached to another instance14:33
johnthetubaguyOK, my thinking was, seems odd to delete a multi-attach volume on delete, gonna be racey, lets just not allow that flag to be set.14:33
ildikovso the conclusion is to allow it, right?14:33
ildikovmriedem: +114:34
mriedemildikov: i don't see a reason not to14:34
ildikovmriedem: cool, my thinking as well14:34
johnthetubaguyOK, so you are both thinking that way, willing to go with that14:34
ildikovjohnthetubaguy: thank you :)14:34
*** hongbin has joined #openstack-nova14:34
openstackgerritEric Fried proposed openstack/nova master: Send Allocations to spawn  https://review.openstack.org/51187914:35
openstackgerritDan Smith proposed openstack/nova master: Make migration uuid hold allocations for migrating instances  https://review.openstack.org/50642014:35
openstackgerritDan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation  https://review.openstack.org/50763814:35
*** yangyapeng has quit IRC14:35
*** yangyapeng has joined #openstack-nova14:36
*** dave-mccowan has joined #openstack-nova14:37
*** shaner has quit IRC14:37
*** artom has quit IRC14:38
*** pwiltsey has joined #openstack-nova14:38
*** namnh has joined #openstack-nova14:40
*** josecastroleon has quit IRC14:40
*** links has quit IRC14:41
*** tonygunk has joined #openstack-nova14:41
*** josecastroleon has joined #openstack-nova14:42
*** sree has joined #openstack-nova14:44
*** shaner has joined #openstack-nova14:47
*** karthiks has quit IRC14:47
*** yamamoto has joined #openstack-nova14:47
*** yamamoto has quit IRC14:47
*** tbachman has quit IRC14:50
*** catintheroof has joined #openstack-nova14:51
johnthetubaguymriedem: if you get a moment, I attempted pseudo code for the shared connection locking, that feels like the last bit of detail we need in there:  https://review.openstack.org/#/c/499777/5/specs/queens/approved/cinder-volume-multi-attach.rst@5314:56
sean-k-mooneyjohnthetubaguy: cfriesen am i remebering correctly that ye were both interested in bandwidth based scheduling at the ptg14:58
johnthetubaguysean-k-mooney: I was probably incorrectly interested, snowed up with other things honestly14:58
sean-k-mooneyjohnthetubaguy: ack ok i was just going to flag https://review.openstack.org/#/c/502306/12 to you if you cared to review14:59
*** sdague has quit IRC14:59
*** cdent has joined #openstack-nova14:59
johnthetubaguysean-k-mooney: cool, can't promise I will get to that I am afraid, chasing a few other things15:00
sean-k-mooneyjohnthetubaguy: no worries15:00
*** rabel has quit IRC15:01
mriedemsean-k-mooney: i know huawei is interested in that15:01
mriedembut i haven't had a chance to review the spec yet15:01
*** sahid has quit IRC15:02
*** sahid has joined #openstack-nova15:02
sean-k-mooneymriedem: ralonsoh is getting a little concerned that it may get caught by the spec approval deadline on thrusday?15:02
*** catintheroof has quit IRC15:03
mriedemeveryone is getting concerned about that for their specs15:03
melwittmriedem: the py3 packages are definitely in the pike uca. how does checking for the py3 env protect against packages missing < pike?15:03
mriedemmelwitt: because the jobs that this is breaking aren't running with py315:03
mriedemthat check is based on a localrc flag set by devstack-gate which is set by the job config15:03
mriedemour live migration job which uses ceph does not run under py315:04
sean-k-mooneyefried: bauzas ye both previously reviewed https://review.openstack.org/#/c/502306/12 is it on your backlog to re review in the next few days?15:04
melwittmriedem: ack15:04
bauzassean-k-mooney: thanks for the ping, sure I'll do15:04
*** aloga has quit IRC15:04
mriedemjohnthetubaguy: reading - not sure how the lock fixes things when the instances attached to the volume are on different compute hosts and we're not using a DLM15:04
*** aloga has joined #openstack-nova15:04
mriedembut i know we've been over that15:04
openstackgerritEd Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver  https://review.openstack.org/49585415:05
openstackgerritEd Leafe proposed openstack/nova master: Change RPC for select_destinations()  https://review.openstack.org/51015915:05
openstackgerritEd Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils  https://review.openstack.org/51135715:05
sean-k-mooneymriedem: ack, that is fair i just said i would flag it again incase anyone was interested.15:05
johnthetubaguymriedem: there is no conflict there, AFAIK, I thought it was just on the operations os-brick does on the hypervisor (and the operations cinder does on delete_attachment and update_attachment)15:06
*** ragiman has quit IRC15:06
efriedsean-k-mooney Can do; though I'm not sure I'm qualified to +1 it.15:06
johnthetubaguymriedem: although I think I see what you mean now15:07
openstackgerritBalazs Gibizer proposed openstack/nova master: Enhance service restart in functional env  https://review.openstack.org/51255215:07
openstackgerritBalazs Gibizer proposed openstack/nova master: Reproduce bug 1724172 in the functional test env  https://review.openstack.org/51255315:07
openstackbug 1724172 in OpenStack Compute (nova) "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Undecided,In progress] https://launchpad.net/bugs/1724172 - Assigned to Balazs Gibizer (balazs-gibizer)15:07
openstackgerritBalazs Gibizer proposed openstack/nova master: cleanup evacuated instances not on hypervisor  https://review.openstack.org/51262315:07
johnthetubaguymriedem: I guess we must have assumed a separate connection from each hypervisor, which doesn't seem quite correct15:08
sean-k-mooneyefried: well if you have concers about the proposal or the wording others probably do too so adressing those in the spec makes it better in general15:08
efriedsean-k-mooney Agree.  I'll give it a full pass later today.15:08
ericyoungthe scaleio imagebackend patch has been updated and gotten through CI if anyone wants to take a look15:08
ericyounghttps://review.openstack.org/#/c/407440/15:08
*** artom has joined #openstack-nova15:10
cdentedleafe-: I don’t understand you caffeine comment. So I tried to clarify.15:11
*** penick has joined #openstack-nova15:13
*** edleafe- is now known as edleafe15:14
edleafecdent: "Is this a candidate for on the Selection object?"15:15
edleafe"for on" was the confusing bit15:15
*** tssurya has quit IRC15:15
cdent“Is this method a candidate for on the selection object?”15:16
cdentbut yes, the caffeine is broken today15:16
cdentbad vintage or something15:16
edleafeTo answer your clarification, there was pushback on adding too much stuff to the Selection object. It could easily be there instead of the scheduler manager. The only preference is that it would never be used outside of the scheduler manager.15:16
*** tbachman has joined #openstack-nova15:17
*** markvoelker has quit IRC15:17
*** markvoelker has joined #openstack-nova15:18
*** Oku_OS is now known as Oku_OS-away15:18
*** josecastroleon has quit IRC15:19
*** gongysh has joined #openstack-nova15:20
*** gongysh has quit IRC15:20
openstackgerritEric Fried proposed openstack/nova-specs master: Granular Resource Request Syntax  https://review.openstack.org/51024415:21
cdentedleafe: if it’s only ever used the scheduler manager then yeah, there seems fine.15:22
efrieddansmith -10% ^15:22
* cdent is not down with OOP15:22
*** markvoelker has quit IRC15:22
*** sshwarts has quit IRC15:23
*** chyka has joined #openstack-nova15:23
dansmithefried: standard negotiation tactic is expect being able to knock 10% off, so that seems substantial15:23
*** josecastroleon has joined #openstack-nova15:23
dansmithefried: on a call now but I'll look in a bit15:23
efriednod, thx15:23
*** tbachman has quit IRC15:27
*** tssurya has joined #openstack-nova15:27
mriedemildikov: johnthetubaguy: ok my comments inline https://review.openstack.org/#/c/499777/15:28
bauzasmriedem: gibi: I have some concerns by seeing duplicate code in https://review.openstack.org/#/c/510938/5/nova/compute/manager.py15:29
mriedembauzas: duplicate with what?15:29
mriedemthe RT?15:29
bauzasmriedem: yup15:29
mriedemthat's intentional15:29
bauzasdelete_alloc_for_moved()15:29
bauzasI know15:29
bauzasbut that's still duplicate15:29
*** psachin has joined #openstack-nova15:29
bauzaseven if intentional :p15:30
mriedembauzas: see PS215:30
*** AlexeyAbashkin has quit IRC15:30
bauzasmriedem: I agree with your point to not call the RT method15:30
*** AlexeyAbashkin has joined #openstack-nova15:30
bauzasmriedem: but we have a compute.utils helper module AFAIK15:30
bauzasmy main concern is that a modification would require two places15:31
mriedemthe only duplication is L698-L706 https://review.openstack.org/#/c/510938/5/nova/compute/manager.py15:32
bauzasI agree15:32
mriedemwhch is also in _delete_allocation_after_move now15:32
mriedem:)15:32
mriedemand _rollback_live_migration15:33
bauzasmriedem: but what if someone wants to add another call ?15:33
mriedemso how about we do the consolidation into a util in a follow up?15:33
bauzasI'm fine with that15:33
mriedemhell, we could just do a private method inthe compute manager itself15:33
bauzasI haven't reviewed the change15:33
mriedemif you don't want to touch the RT15:33
bauzasI just wanted to open a discussion15:34
mriedemi'm cool with refactoring out the duplication, but not in this change since it has to be backported15:34
bauzasbut yeah, if we were doing the consolidation, would be worth doing all of it in a single patch15:34
*** jobewan has joined #openstack-nova15:34
bauzasthat's a good point15:34
bauzasok, I'll leave a comment and +W15:34
*** tbachman has joined #openstack-nova15:35
*** sree has quit IRC15:37
*** tbachman_ has joined #openstack-nova15:37
*** sree has joined #openstack-nova15:37
*** markus_zz has quit IRC15:37
*** sree has quit IRC15:38
*** sree has joined #openstack-nova15:38
*** sree has quit IRC15:39
*** sree has joined #openstack-nova15:39
*** tbachman has quit IRC15:40
*** tbachman_ is now known as tbachman15:40
*** AlexeyAbashkin has quit IRC15:41
*** sree has quit IRC15:43
*** sdague has joined #openstack-nova15:44
mriedembauzas: if you've got the time, we also need these stable/pike backports https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/pike+topic:bug/171518215:45
*** chyka_ has joined #openstack-nova15:45
mriedemlyarwood: ^15:45
bauzasmriedem: lyarwood is off sick15:45
mriedemtoo much volume encryption will do that15:45
bauzasI have an internal meeting until 4pm UTC, so I guess I have 13 mins of free time now :)15:47
*** chyka has quit IRC15:47
*** jwcroppe_ has joined #openstack-nova15:47
*** yamamoto has joined #openstack-nova15:48
*** sdague has quit IRC15:48
*** sridharg has quit IRC15:49
*** jwcroppe has quit IRC15:49
*** andreas_s has quit IRC15:52
*** gouthamr has quit IRC15:54
*** yamamoto has quit IRC15:55
*** gouthamr_ has joined #openstack-nova15:55
*** owalsh_ is now known as owalsh15:59
*** slaweq has joined #openstack-nova15:59
*** yassine has quit IRC15:59
*** abhi89 has quit IRC15:59
melwittmriedem: I'm okay with this libvirt driver change now, to detach and reattach volumes during reboot. apparently there have been summit and PTG discussions about doing that in hard reboot for some time, so if that's the plan anyway, it seems fine to me https://review.openstack.org/#/c/40038416:00
mriedemi don't remember those discussions16:00
*** pcaruana has quit IRC16:01
*** namnh has quit IRC16:02
dansmithI do, it was around the need to re-fresh the connection info for monitor ip changes, IIRC16:02
mriedemthat's not this though16:02
*** josecastroleon has quit IRC16:03
dansmithI haven't looked at the patch, but okay16:04
dansmithwe did talk about re-building the storage connections on reboot for that reason though16:04
*** namnh has joined #openstack-nova16:04
*** vladikr has quit IRC16:04
*** vladikr has joined #openstack-nova16:05
mriedemyeah i remember that, and have the todo for it still16:05
*** sdague has joined #openstack-nova16:05
*** josecastroleon has joined #openstack-nova16:07
mriedemok so we have an encrypted volume test in tempest, i could just modify that to hard reboot the instance after an ecrypted volume is attached and it should blow up the instance right?16:08
dansmithefried: did alex_xu get everything resolved that he was concerned about on that spec? I saw a bunch of discussion here16:08
melwittmriedem: I think so, yes16:08
mriedemmelwitt: ok in that case i'm going to tweak tempest to recreate the failure and then make it depend on the nova fix16:09
mriedemmelwitt: jbernard: https://review.openstack.org/#/c/512622/ is passing16:09
mriedemwe need to get that in asap to unblock nova stable16:09
mriedemjdurgin: ^16:09
melwittmriedem: sounds like a good idea16:09
*** lucasagomes is now known as lucas-afk16:10
melwittmriedem: you did a Depends-On to see it pass on stable?16:10
mriedemmelwitt: i can quick16:10
melwittokay, just wanted to make sure that's going to work for you16:11
*** Apoorva has joined #openstack-nova16:11
efrieddansmith Not really.  We need another writeup.  OTP, give me a few mins.16:11
openstackgerritMatt Riedemann proposed openstack/nova stable/ocata: libvirt: add check for VIR_DOMAIN_BLOCK_REBASE_COPY_DEV  https://review.openstack.org/51240616:11
mriedemmelwitt: ^16:11
dansmithefried: more in this spec? i thought he was suggesting another spec.. but sure, np16:12
efrieddansmith Which spec are we talking about?16:13
dansmithefried: your granular request word-a-palooza16:14
efrieddansmith Oh, no, that should be solid as is.  Whatever else needs to come out of that will have to go... somewhere else.16:16
dansmithefried: okay that's what I thought, but wanted to clarify16:16
dansmithso I was going to drop my +2 on there, but didn't want to if alex_xu had more things implied from his +0 earlier16:17
*** namnh has quit IRC16:19
*** namnh has joined #openstack-nova16:20
*** sambetts is now known as sambetts|afk16:26
*** psachin has quit IRC16:27
*** josecastroleon has quit IRC16:29
*** salv-orl_ has joined #openstack-nova16:29
*** tbachman has quit IRC16:30
*** salv-orlando has quit IRC16:32
*** josecastroleon has joined #openstack-nova16:32
jbernardmriedem, melwitt: +A'd, thanks ya'll16:33
*** ralonsoh has quit IRC16:33
melwittjbernard: awesome, thanks16:33
mriedemsean-k-mooney: comments inline https://review.openstack.org/#/c/502306/16:33
*** yamahata has quit IRC16:34
mriedemsean-k-mooney: honestly i think that's going to be a very tough mountain to climb at this point given all of the dependencies16:34
mriedemsean-k-mooney: there seems to be a fundamental mistaken assertion in there that nova creates ports before a host is chosen16:34
mriedemwhich is not the case16:34
mriedemjbernard: thanks16:34
sean-k-mooneymriedem: i taught nova called the create_or_get port api before calling placement?16:35
*** gszasz has quit IRC16:35
sean-k-mooneymriedem: but thank for reviewing. yes this does have a lot of dependncies16:35
mriedemsean-k-mooney: no, ports are created during allocate_for_instance in the compute service16:35
mriedemafter a host is chosen by the scheduler16:35
mriedemjohnthetubaguy has an older spec to move port creation to conductor, which might be another dependency for this16:36
mriedemsean-k-mooney: isn't the qos policy applied to the port?16:36
sean-k-mooneymriedem: but how will it know if it should be creating a sriov port or normal port if it only did it at the compute node16:36
mriedemsean-k-mooney: nova doesn't create sriov ports16:36
mriedemnova creates regular old boring ports16:36
mriedemif you need a fancy nfv port, you create it in neutron and provide it when creating the server16:37
mriedemif the qos policy is applied to the port, and nova creates the port, then i think we assert that nova-created ports don't have minimum bandwidth guarantees16:37
mriedemeasy peasy16:37
sean-k-mooneymriedem: yes the qos policy is  on the port but it can also be on the network which adds it to the port automatically16:37
mriedemif you want the fancy, you precreate the port16:37
mriedemok then that gets complicated,16:37
sean-k-mooneymriedem: yes you are right sriov or qos implies you precreate the port16:38
mriedembecause you can create a server with a nic uuid and nova will create the port in that network16:38
*** penick_ has joined #openstack-nova16:38
johnthetubaguythat sounds a lot like the routed network case that triggered the move to conductor thingy16:38
mriedemand if the qos policy on the network doesn't match the compute host i guess you have problems16:38
mriedemjohnthetubaguy: yes16:38
*** mvk has quit IRC16:38
*** suresh12 has joined #openstack-nova16:39
johnthetubaguysean-k-mooney: if you want to take on the refactor it is now I think just a case of moving the code, we create missing ports (the conductor bit), then update all the ports (the compute bit)16:40
mriedemthe spec also doesn't really mention any details about move operations, which we know are the hairiest thing to deal with16:40
*** tonygunk has quit IRC16:40
*** penick has quit IRC16:40
mriedembecause during a move the allocations have to be made on the target host and eventually removed from the source host - is the neutron agent going to screwed up by that?16:41
mriedem*to get16:41
sean-k-mooneymriedem: it should not as neutron will not be doing allocations from placement iteself16:41
sean-k-mooneymriedem: but that said we have not gone into details of the move operations in the spec16:42
melwittstephenfin: I refactored the unit tests to address your comment https://review.openstack.org/#/c/49898316:42
mriedemsean-k-mooney: that was another thing, the spec loosely talked about modifying the nova resource tracker, i think to create allocations for these bandwidth things, but we want the scheduler to create allocations, not the compute (RT)16:43
mriedembecause when you move the instance, the source host RT might overwrite the allocations for the instance which are meant for the dest host16:44
mriedembecause of periodic task race window wackiness16:44
*** abalutoiu has joined #openstack-nova16:44
sean-k-mooneymriedem: yes in the future we defiently want to move the allocation out of the compute node the sepc was assuming the workflow we have today where the compute node does the allocation but i dont think it would break if the allocation was done earlier16:45
*** hieulq_ has joined #openstack-nova16:46
mriedemsean-k-mooney: if today is >= pike, we don't create allocatoins in the computes anymore16:46
mriedemallocations in the computes is soooooo 2 months ago :)16:46
sean-k-mooneymriedem: oh did that land in pike cool16:46
mriedemyeah i linked to the change in the spec16:46
mriedemas a result of that change we've been doing a lot of cleanup of places where we dont cleanup allocations16:47
sean-k-mooneymriedem: so is that now done in the conductor/scheduler16:47
mriedemstill working on getting those fixes into stable/pike16:47
mriedemthe scheduler claims yes16:47
mriedemfor VCPUS/MEMORY_MB/DISK_GB16:47
mriedemif you have NUMATopologyLimits, those get claimed in the compute still,16:47
mriedemsince we don't model NUMA via nested RPs in placement yet16:47
sean-k-mooneypci device im guessing are still on compute node too for same reason16:48
mriedemyeah16:48
sean-k-mooneyto do the claim for the bandwidth in the scheduler we would also have to bind the port in the scheduler16:49
mriedempci request claims are handled differently from numa limits somehow, i can't remember the details16:49
mriedemsean-k-mooney: why?16:49
mriedemscheduler picks a host, makes the bandwidth allocation against that host, and the port is later bound to the host in the compute16:50
sean-k-mooneyto know which network backend to claim the bandwitdh form16:50
mriedemif we fail on the compute, we deallocate16:50
sean-k-mooneye.g. sriov and ovs on same host16:50
mriedemso we don't know the network backend until we bind the host and get a binding:profile from neutron?16:50
sean-k-mooneycorrect.16:51
mriedemwell shit balls16:51
mriedemthat's what i call a catch-216:51
mriedem*catch-2216:51
sean-k-mooneythat is why we assumed the current workflow in the spec16:51
mriedemyeah...16:52
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Reproduce bug 1721652 in the functional test env  https://review.openstack.org/51175916:53
openstackbug 1721652 in OpenStack Compute (nova) "Evacuate cleanup fails at _delete_allocation_for_moved_instance" [High,In progress] https://launchpad.net/bugs/1721652 - Assigned to Balazs Gibizer (balazs-gibizer)16:53
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: fix cleaning up evacuated instances  https://review.openstack.org/51271616:53
sean-k-mooneybefore ovs offload we could have used the vnic type to differenciate sriov and ovs/linuxbirdge/vpp... but now we cant since vnic type direct is valid for both16:53
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: fix cleaning up evacuated instances  https://review.openstack.org/51271616:53
gibimriedem, bauzas: sorry I was away from the computer. I can do the suggested refactor of https://review.openstack.org/#/c/510938/ in a follow up16:54
*** edand has quit IRC16:55
*** vvargaszte has joined #openstack-nova16:57
*** suresh12 has quit IRC16:58
sean-k-mooneymriedem: anyway thanks for reviewing it. one spec that is hopefully less contoversial since it was approved last cycle is https://review.openstack.org/#/c/504895/ i think all the code for that has been up for a few months also16:58
sean-k-mooneymriedem: johnthetubaguy oh by the way was this https://review.openstack.org/#/c/499777/5 the cinder attach work you were suggesting emultating for the multiple port binding in relation to how upgrades should work17:00
mriedemsean-k-mooney: no17:00
mriedemsec17:00
mriedemsean-k-mooney: https://specs.openstack.org/openstack/nova-specs/specs/queens/approved/cinder-new-attach-apis.html17:00
*** vks1 has quit IRC17:00
sean-k-mooneymriedem: ah ok i have basically added johnthetubaguy suggestions to the latest version but ill go read that now17:01
sean-k-mooneymriedem: thanks17:01
*** tesseract has quit IRC17:02
mriedemi need to read the updates on the portbinding spec too17:02
edleafedansmith: Here's the scenario: cell conductor gets a list of alternates after the initial build attempt fails. Assume that all of these alternates are stale, and no longer have enough resources. Should the cell conductor just log it and do nothing, or should it raise an exception?17:02
edleafeAnd if an exception, what kind?17:02
mriedemNoValidHost?17:03
mriedemcell conductor raising NoValidHost is something that can already happen today when you run out of alternatives17:03
mriedemit will log a fault17:03
mriedeminstance goes to ERROR state17:03
mriedemeasy peasy17:03
dansmithedleafe: it should do whatever would happen if we had no retries left in the current path17:03
dansmithyeah17:03
dansmiththat17:03
edleafemriedem: that was my assumption, but I wanted to be sure there wasn't some other action17:03
openstackgerritJan Zerebecki proposed openstack/nova master: Fix wording of debug message for future releases  https://review.openstack.org/50826117:04
*** slaweq has quit IRC17:04
edleafeah, so that should be the same as what happens in compute when there are no retries left.17:04
dansmithright17:04
*** penick_ has quit IRC17:05
*** tbachman has joined #openstack-nova17:06
*** penick has joined #openstack-nova17:07
openstackgerritElod Illes proposed openstack/nova master: WIP: Transform scheduler.select_destinations notification  https://review.openstack.org/50850617:08
*** hieulq_ has quit IRC17:09
*** derekh has quit IRC17:09
*** yamahata has joined #openstack-nova17:11
*** ociuhandu has quit IRC17:11
dansmithedleafe: so, looking at your third patch,17:12
dansmithedleafe: we have limits in the reqspec,17:12
dansmithoh,17:13
*** jwcroppe_ has quit IRC17:13
dansmiththe selection limits are really just for the return value from the rpc call to continue to include them is that right?17:13
dansmithI was thinking we had to have them for communicating to the compute, but that is in reqspec17:13
dansmithis that right?17:13
edleafedansmith: the caching scheduler needs them17:13
dansmiththe caching scheduler _sets_ them17:14
dansmiththe compute _needs_ them17:14
*** weshay|ruck is now known as weshay|afk_see_r17:14
edleafeok, I thought it was needed in the filters17:14
dansmithmy point is, we really just need them in Selection so that the return from select_destinations(), which is now a bunch of Selections, can include the limits back to conductor,17:15
edleafebut yeah, the compute will need them too17:15
dansmithwhich will populate the reqspec17:15
dansmiththe filters don't need them, the filters are what put things into limits17:15
edleafeok, I guess I misunderstood mriedem's concerns17:15
dansmithcompute can get them from the reqspec17:15
mriedemthe limits are stored in the reqspec?17:18
mriedemtbc, we pass a reqspec down to build_and_run_instance in compute and it's *totally* ignored17:19
mriedemwe pass the limits dict separately17:19
*** dtantsur is now known as dtantsur|afk17:19
*** jpena is now known as jpena|off17:19
mriedemok i see the SchedulerLimits field in the request spec17:19
mriedemi just don't think compute is using that today17:20
dansmithmriedem: right, so this will be passing limits N more times than we currently pass it17:20
dansmithI'm thinking maybe we just have select_destinations return (reqspec, alternates) with reqspec updated with limits,17:20
dansmithand then we can avoid putting them into the selection17:20
dansmithaside from numa, they'll be the same for num_instances, right?17:21
mriedemneed to see what actually populates RequestSpec.limits today17:21
dansmithI think it's populate_filter_properties17:21
*** AlexeyAbashkin has joined #openstack-nova17:22
dansmithhttps://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L36717:23
mriedemyeah looking at what calls that17:24
dansmithconductor17:24
*** AlexeyAbashkin has quit IRC17:24
dansmithhttps://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L1110-L111017:24
mriedemgod what a weird mess17:25
dansmithyeah17:25
dansmithit's also still in the half-uncleaned-up reqspec object17:25
dansmiththe only problem is,17:25
dansmithI think numa limits will be per-host,17:25
dansmithalthough,hmm17:25
dansmithmaybe the regular limits won't because of the allocation ratios or something?17:26
*** mvk has joined #openstack-nova17:26
dansmithyeah, toast17:26
mriedemwe also aren't doing this trick for evacuate17:26
dansmithgdi17:26
mriedemnot really sure why we have RequestSpec.limits at all since it's not used anywhere, i guess because RequestSpec was supposed to replace filter_properties17:27
dansmiththe thing that goes into limits for things like ramfilter varies per host17:27
dansmithmriedem: yeah, all that is unfinished17:27
*** penick_ has joined #openstack-nova17:27
dansmithmriedem: so we pass it in reqspec, and as an arg, and now in N alternates17:28
dansmithoh and we pass filter_properties too17:28
*** salv-orlando has joined #openstack-nova17:28
mriedemto build_and_run_instance17:28
dansmithso reqspec, filter_properties, limits, and N*selection17:28
mriedemyeah heh17:28
dansmithI wonder if that's enough redundancy17:28
mriedemRAID-4?17:28
mriedemfor limits17:29
*** bastimalo has joined #openstack-nova17:29
dansmiththis is like raid 5017:29
mriedemok yeah so the allocation ratios are per host,17:29
mriedemso the limits are per host17:29
mriedemso they go into the selection object yeah?17:29
*** bastimalo has left #openstack-nova17:30
dansmithyeah, have to17:30
*** penick has quit IRC17:30
mriedemand RequestSpec.limits is i guess just the same as the first host chosen17:30
dansmithand filter properties17:30
dansmithand limits17:30
*** salv-orl_ has quit IRC17:32
*** salv-orlando has quit IRC17:32
mriedemmaybe this is an appropriate time to drop this in here https://review.openstack.org/#/c/499799/17:33
mriedemremoves 5% of the request spec TODOs17:33
*** penick_ has quit IRC17:36
*** ociuhandu has joined #openstack-nova17:39
*** vvargaszte has quit IRC17:41
*** ijw has joined #openstack-nova17:41
openstackgerritJackie Truong proposed openstack/nova master: Implement certificate_utils  https://review.openstack.org/47994917:43
*** ijw has quit IRC17:45
openstackgerritEric Fried proposed openstack/nova master: Send Allocations to spawn  https://review.openstack.org/51187917:46
efrieddansmith gibi I think I hit your concerns ^17:46
*** gjayavelu has joined #openstack-nova17:47
*** ijw has joined #openstack-nova17:48
*** mvk has quit IRC17:48
*** josecastroleon has quit IRC17:49
*** mvk has joined #openstack-nova17:49
*** ijw has quit IRC17:50
*** ijw has joined #openstack-nova17:50
*** shaner has quit IRC17:50
*** josecastroleon has joined #openstack-nova17:52
*** gouthamr_ is now known as gouthamr17:52
*** gabor_antal_km has joined #openstack-nova17:53
*** gabor_antal_ has quit IRC17:53
*** fragatina has quit IRC17:53
*** slaweq has joined #openstack-nova17:57
openstackgerritJackie Truong proposed openstack/python-novaclient master: Microversion 2.54 - Add trusted_image_certificates  https://review.openstack.org/50039617:59
*** penick has joined #openstack-nova18:00
*** abhi89 has joined #openstack-nova18:00
*** baoli has quit IRC18:00
*** baoli has joined #openstack-nova18:01
*** slaweq has quit IRC18:02
*** Apoorva_ has joined #openstack-nova18:02
*** Apoorva has quit IRC18:05
*** suresh12 has joined #openstack-nova18:06
*** yassine has joined #openstack-nova18:07
openstackgerritMerged openstack/nova master: fix cleaning up evacuated instances  https://review.openstack.org/51093818:08
dansmithefried: sorry if I wasn't clear, but I don't think adding a whole new fixture just to mock that one thing makes sense,18:09
dansmithI just wanted you to use MonkeyPatch in there instead of mock.start() and addCleanup()18:10
*** MVenesio has joined #openstack-nova18:11
dansmithefried: like this for example: https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/test_virt_drivers.py#L9618:11
*** Tom__ has quit IRC18:12
*** suresh12 has quit IRC18:13
*** namnh has quit IRC18:15
*** abalutoiu_ has joined #openstack-nova18:15
*** suresh12 has joined #openstack-nova18:17
*** abalutoiu has quit IRC18:19
*** shaner has joined #openstack-nova18:19
gregworkis there a way to pass custom options to qemu via nova ?18:22
gregworksuch that when a guest starts up it starts with those extra options18:22
*** suresh12 has quit IRC18:27
*** shaner has quit IRC18:27
*** baoli has quit IRC18:27
*** shaner has joined #openstack-nova18:28
artomgregwork, like literally custom qemu command line options? No.18:28
mriedemartom: do you care about updating this newton change? https://review.openstack.org/#/c/467321/18:28
mriedemartom: looks like it would need to cherry pick from https://review.openstack.org/#/c/482219/ in ocata18:29
mriedemnewton eol is tomorrow18:29
artommriedem, aha, thanks for the heads up18:29
artomYeah, lemme do that now18:29
*** penick has quit IRC18:30
*** suresh12 has joined #openstack-nova18:31
*** suresh12 has quit IRC18:31
efrieddansmith okay.18:31
*** suresh12_ has joined #openstack-nova18:31
mriedemdansmith: want to put this in? https://review.openstack.org/#/c/507557/ - the change on stable/ocata is merged, which is what i think tony was waiting for18:33
melwittmriedem, dansmith: I've got a change up to remove a lot of old quotas code. the only thing I'm not 100% about is the Quotas object methods, I assume they can't be removed until a major version bump. https://review.openstack.org/#/c/51168918:34
*** hemna_ has quit IRC18:34
mriedemi've got that one starred, hadn't been through it yet though18:34
dansmithmriedem: ack18:34
gregworkartom: im trying to get qemu to spawn the guest with -mem-path /dev/hugetlbfs and -mem-prealloc as per my mellanox dpdk guide18:35
mriedemand yeah i suppose you can't remove the versioned object methods w/o a major bump18:35
dansmithyup18:35
melwittyeah, I wasn't sure if that's true only for remotables or all18:35
dansmithif they're remotable, that is18:35
gregworkartom: not sure how to pull this off18:35
dansmithmelwitt: non-remotables can be removed18:35
dansmithmelwitt: you'll know because the hash won't change18:35
*** josecastroleon has quit IRC18:35
*** baoli has joined #openstack-nova18:36
mriedemwhat if the quota engine code behind the remotable object method is removed?18:36
melwittdansmith: ah, cool. I put TODO remove in 2.0 on all of them but I could straight up remove the non-remotables18:36
mriedemthus breaking it?18:36
melwittI put pass in18:36
artomgregwork, not really my area of expertise, but what's this mellanox dpdk guide you speak of?18:36
*** ttsiouts has quit IRC18:36
mriedemmelwitt: ok18:36
dansmithmelwitt: which is only one of them, AFAICT18:36
melwittbut yeah, I guess that would be bad if the other side expected a returned thing so nevermind18:36
*** ttsiouts has joined #openstack-nova18:37
dansmithmriedem: yeah, can't break a remotable method, so you can't just gut it, unless gutting it is the proper new behavior or something18:37
openstackgerritMatt Riedemann proposed openstack/nova stable/ocata: libvirt: add check for VIR_DOMAIN_BLOCK_REBASE_COPY_DEV  https://review.openstack.org/51240618:37
mriedemartom: we're going to need ^ if you want to get https://review.openstack.org/#/c/471356/ into newton18:37
melwittdansmith: hm, so I wondered that, and I thought that's why we might have to keep all of the old quotas code until version 2.0 of the object?18:37
dansmithefried: idk about monkey vs. mock.. I had never seen mockpatch before until you used it18:38
artommriedem, you mean the thing I said "lemme do that now"? ;)18:38
dansmithmelwitt: it just depends on what you're removing18:38
mriedemartom: no, this is different18:38
mriedemartom: another one of your waylaid newton backports18:38
*** josecastroleon has joined #openstack-nova18:38
artomBut I have so many18:38
melwittdansmith: for example, the reserve() method passes straight through to the quota engine code and then onto the DB API code. so to prevent breaking the contract, we have to keep all of that no?18:39
melwittI had thought I could just put "pass" in them. maybe we can since reserve() didn't return anything IIRC18:39
dansmithmelwitt: well it depends.. if the side effects of the code are no longer desired, and the older remote can't tell a difference, then it doesn't matter18:40
dansmiththat's the point of the isolation18:40
dansmithyou're not breaking the contract by changing the behavior of the remotable, only if you change the remotely-visible behavior18:40
dansmithjust like we make save() do new things like generate uuids even though older clients don't expect that18:40
melwittyeah. I'm trying to think if the other side can or can't tell the difference. reserve() currently sets the 'reservations' attribute18:40
dansmiththat's the new behavior, we just have to make sure we honor what they're expecting18:40
dansmithbut not if NoOp is used right?18:41
melwittyeah not if NoOp is used18:41
artommriedem, ah, OK, the rebase thing. So your fix should merge before we merge the backport, which would squash your fix18:41
*** vishwanathj has joined #openstack-nova18:41
melwittso it should already be resilient to that18:41
mriedemartom: yes18:41
dansmithso presumably we can keep the interface stable but neuter the new-side code so it's not doing anything right?18:41
artomHonestly, we can do internal backport to newton, so no massive rush18:41
gregworkartom: http://www.mellanox.com/related-docs/prod_software/MLNX_DPDK_Quick_Start_Guide_v16.11_1.5.pdf18:41
artomBut upstream would obviously be appreciated :)18:42
gregworkartom: section 3.2 is the recommended settings for starting a kvm guest18:42
melwittdansmith: yeah. looks like we can safely do that for any method overloaded by NoOp since NoOp does a pass for those18:42
openstackgerritArtom Lifshitz proposed openstack/nova stable/newton: Catch InstanceNotFound exception  https://review.openstack.org/46732118:42
*** cleong has quit IRC18:42
dansmithmelwitt: you'd think yeah18:42
artommriedem, ^^ that's the tenant usage instancenotfound thing18:42
artommriedem, I guess I can give you the +1 on your fix, but that's about the extent of my helping to push it through18:42
*** Apoorva_ has quit IRC18:43
melwittdansmith: yeah, not guaranteed. some code out there might be assuming only the default driver and thus assume something like 'reservations' attribute would be set. I'm not sure if we need to account for that18:43
mriedemi need a stable hero to review these: https://review.openstack.org/#/c/493206/ https://review.openstack.org/#/c/506323/  https://review.openstack.org/#/c/509441/ https://review.openstack.org/#/c/508902/18:43
artomWith great power comes great responsibility, with no power you just sorta chill18:43
*** Apoorva has joined #openstack-nova18:43
dansmithmelwitt: you can probably just make sure reservations is set to something that will make it not choke right?18:44
*** suresh12_ has quit IRC18:44
melwittdansmith: yeah, maybe empty list would be good enough. hopefully no one could assume non-empty list18:44
artomgregwork, ah, OK. So they're not saying "in your openstack instance, make sure this command line is present"18:45
*** suresh12 has joined #openstack-nova18:45
dansmithmelwitt: I don't have the usage of that field in my head so I'd have to look, but AFAIR, it's just passed back to commit or something18:45
artomgregwork, you just happen to be using openstack, whereas the doc is written for bare kvm/qemu18:45
gregworkartom: right18:45
melwittcommit() used to set reservations = None too, so that's a thing that's considered valid18:45
artomgregwork, nova does do hugepages and CPU pinning18:45
melwittdansmith: yeah, I think only the object itself uses it. or at least that's the intention. but ppl could access it if they wanted, I don't know why they would tho18:46
gregworkartom: i am getting a qemu error trying to initialize the network with dpdk, i am trying to troubleshoot by making sure qemu-kvm is being invoked correctly18:46
artomgregwork, I dunno what version you're on, for for pike the docs are https://docs.openstack.org/nova/pike/admin/huge-pages.html and https://docs.openstack.org/nova/pike/admin/cpu-topologies.html18:46
dansmithmelwitt: fwiw, I think you're overthinking this.. just set it to something and grep around for the uses of .reservations and make sure it'll be happy.. should be easy I think :)18:47
mriedemartom: +218:47
melwittdansmith: I was getting confused by the idea of accounting for code that isn't in nova18:47
dansmithmelwitt: eh? no need to do that, like always18:47
dansmithmelwitt: what are you thinking of specifically?18:48
artommriedem, woothanks18:48
gregworkartom: working with ocata atm18:48
artomgregwork, wait, you're getting a qemu error while spawning a VM through nova?18:48
artomThat's... bad18:48
gregworkartom: yeah :/18:48
melwittdansmith: I thought that was what you were getting at. nothing calls these methods anymore as of queens, so I thought it didn't matter what they return or not. but I knew I couldn't remove them if they were remotable18:48
artomgregwork, and is most likely a nova and/or libvirt bug18:49
artomBecause that should never happen18:49
*** tbachman has quit IRC18:49
dansmithmelwitt: no, I'm saying we should keep the contract until we bump, but not for out-of-nova uses, just in case someone has an ocata compute running by accident or something so we do our best to not just cause it to break in weird ways18:49
artomWell, assuming the hardware actually supports what you're trying to do, and you've configured nova correctly18:49
*** suresh12 has quit IRC18:49
gregworkartom: i dont think so, i believe this is related to ovs being configured to use mellanox dpdk poll mode driver, and kvm is not setting up the guest correctly to plumb the networking18:49
*** suresh12 has joined #openstack-nova18:50
artomBut even a misconfiguration shouldn't go all the way down to a qemu error18:50
dansmithmelwitt: since it's all conductor-side for those actions, just attempt to fake the result that won't cause any of our code in the last few cycles to choke and call it good18:50
mriedemsdague: can i get you to poke through these stable/newton changes? https://review.openstack.org/#/c/493206/ https://review.openstack.org/#/c/506323/  https://review.openstack.org/#/c/509441/ https://review.openstack.org/#/c/508902/18:50
mriedemtomorrow is newton-eol18:50
gregworkartom: eg. https://paste.fedoraproject.org/paste/GWEv1HyVo1y9sekJbZFBeQ18:50
melwittdansmith: oh, gotcha. I understand now. I'll go over it again and look for those possibilities and update it. thanks18:51
*** cdent has quit IRC18:51
melwittI at least can remove the non-remotable one in a new PS18:51
artomgregwork, you're very rapidly bringing my out of my (admittedly limited) comfort zone :/18:52
gregworkartom: so i am testing vnf's on my openstack, where the compute nodes are running ovs in dpdk mode, with a poll mode driver (the nic is not managed by the kernel)18:52
artomgregwork, sorry I can't be of more help, but I'm out of my league here18:54
mriedemgregwork: sean-k-mooney might be able to help with dpdk questions18:55
artomWe have some folks from mellanox who hang out here, but they're (I think) on Israel time18:55
mriedemmoshe is yeah18:55
sean-k-mooneymriedem: gregwork sure let me read back18:55
*** suresh12 has quit IRC18:56
sean-k-mooneygregwork: so yes you have a coumpute node with ovs-dpdk. what is the question?18:56
sean-k-mooneygregwork: ah you dont have hugepages requested for the vm18:57
*** peter-hamilton has quit IRC18:58
sdaguemriedem: done. I was a little surprised you wanted some of those back to newton, but that's fine18:58
gregworksean-k-mooney: have you seen that error before ?18:58
gregworkthe one i posted in the pastebin18:58
mriedemsdague: the bfv one was needed for another thing someone was reporting in newton but w/o better debug couldn't be determined18:58
sdaguemriedem: ok18:59
gregworksean-k-mooney: im using the mellanox rhosp11 plugin which has configured ofed on my nodes and we are pushing a nutron dpdk config18:59
gregworksean-k-mooney: the deploy works great, but when i spawn instances i get that error in qemu-kvm on the compute node18:59
gregworksean-k-mooney: networking doesnt appear to be working (most likely due to that error)19:00
gregworkvm boots and all but is an island19:00
sean-k-mooneygregwork: the one you posted is indicating that the guest memory is not backed by file descriptor backed memory that is mapped shared19:00
gregworksean-k-mooney: yar19:00
sean-k-mooneyvhost user requires file decriptor backed shared memeory that is preallocated and locked to work19:01
sean-k-mooneyin ocata that means the guest must use hugepage backed memory or it will boot but have no networking19:01
*** slaweq has joined #openstack-nova19:02
gregworkwhat am i missing from a flavor pov? im reading about some keys i need to set19:02
*** suresh12 has joined #openstack-nova19:02
sean-k-mooneyyes you need to add hw:mem_page_size=large19:02
mriedemgregwork: https://docs.openstack.org/nova/pike/admin/huge-pages.html19:03
dansmithefried: I assume you're good with this since you pushed the latest edit? https://review.openstack.org/#/c/47057519:04
*** dave-mccowan has quit IRC19:04
dansmithefried: no +1 so just wanted to make sure before I sent it to oblivio19:04
dansmith*oblivion19:04
efrieddansmith oblivio away19:04
dansmithefried: are you going to rebase the rest?19:04
efriedI could, if they need it.  Do they need it?19:05
sean-k-mooneymriedem: sfinucan wrote a section about vhost-user/dpdk also in the docs im trying to find that19:05
dansmithI think so19:05
efriedight.19:05
dansmithefried: I think your edit(s) orphaned them19:05
openstackgerritEric Fried proposed openstack/nova master: Send Allocations to spawn  https://review.openstack.org/51187919:05
efrieddansmith On it.  Meanwhile ^19:05
dansmithefried: no, meanwhile lunch19:06
mriedemsean-k-mooney: probably in the networking guide19:06
efrieddansmith Enjoy19:06
*** cjvolzka has joined #openstack-nova19:06
mriedemhttps://docs.openstack.org/ocata/networking-guide/config-ovs-dpdk.html19:06
openstackgerritEric Fried proposed openstack/nova master: placement: integrate ProviderTree to report client  https://review.openstack.org/41592119:07
openstackgerritEric Fried proposed openstack/nova master: placement: add nested resource providers  https://review.openstack.org/37713819:07
openstackgerritEric Fried proposed openstack/nova master: placement: allow filter providers in tree  https://review.openstack.org/37721519:07
openstackgerritEric Fried proposed openstack/nova master: placement: adds REST API for nested providers  https://review.openstack.org/38480719:07
openstackgerritEric Fried proposed openstack/nova master: placement: update client to set parent provider  https://review.openstack.org/38569319:07
efrieddansmith Done ^19:08
sean-k-mooneymriedem: gregwork yep https://docs.openstack.org/ocata/networking-guide/config-ovs-dpdk.html was what i was looking for19:08
*** hemna_ has joined #openstack-nova19:10
gregworkreading now19:10
sean-k-mooneygregwork: that rather crypti libvirt warning + the complete lack of networking are the only signs that this requirement was not met19:10
sean-k-mooneygregwork: by the way if you are on ubuntu you might need to aslo need to run sudo apparmor_parser -R /etc/apparmor.d/usr.sbin.libvirtd and restart libvirtd19:12
*** suresh12 has quit IRC19:12
sean-k-mooneythe reason for this is apparmor may block acess to /var/run/openvswitch when qemu tries to create/connect to the vhost user socket19:12
*** jamesdenton has quit IRC19:13
sean-k-mooneyif you request hugepages and it fails to boot check dmesg to see if app armor blocked it and remove teh libvirt prfile and restart the libvirt service if it did19:14
*** suresh12 has joined #openstack-nova19:14
*** namnh has joined #openstack-nova19:16
openstackgerritEric Fried proposed openstack/nova master: placement: allow filter providers in tree  https://review.openstack.org/37721519:20
openstackgerritEric Fried proposed openstack/nova master: placement: adds REST API for nested providers  https://review.openstack.org/38480719:20
openstackgerritEric Fried proposed openstack/nova master: placement: update client to set parent provider  https://review.openstack.org/38569319:20
openstackgerritEric Fried proposed openstack/nova master: Reformat _get_all_with_shared  https://review.openstack.org/51279919:20
*** namnh has quit IRC19:20
*** jwcroppe has joined #openstack-nova19:21
gregworksean-k-mooney: on rhel7 with rhosp1119:21
sean-k-mooneygregwork: ah ok. selinux might complain in a similar way but i think that issue only happens on ubuntu19:22
openstackgerritEric Fried proposed openstack/nova master: placement: Reformat _get_all_with_shared  https://review.openstack.org/51279919:22
sean-k-mooneyyou can set selinux to permmissive if it dose as a workaround19:22
gregworksean-k-mooney: what hardware are you using19:22
gregworksean-k-mooney: we are testing connect x-5 100gbe dual qsfp cards19:23
dansmithefried: thanks19:23
efriedyahyoubetcha.19:23
efriedAlso addressed cdent -1 in the middle of that series19:23
dansmithgregwork: sean-k-mooney: your discussion seems unrelated to nova dev (see topic), maybe you could take it to #openstack?19:23
dansmithefried: cool19:24
sean-k-mooneygregwork: i have tested i350,e1000,x520 and xl70(both 4*10 and 2*40G)19:24
gregworkdansmith: sure19:24
sean-k-mooneydansmith: sure :)19:24
efrieddansmith You should eat slower.  Gonna give yourself indigestion.19:24
*** slaweq has quit IRC19:24
gregworkactually ill just msg you directly if you dont mind19:24
dansmithefried: I'm parallelizing19:24
efriedefficient19:24
*** markvoelker has joined #openstack-nova19:26
*** sahid has quit IRC19:29
*** dave-mccowan has joined #openstack-nova19:29
*** mlavalle has joined #openstack-nova19:30
mlavallejohnthetubaguy, mriedem: any chance you could take a look again on https://review.openstack.org/#/c/375580/?19:31
mriedem0 chance miguel19:31
mriedemi've had the tab open all morning :)19:31
mriedemshould be able to get to it before parent / teacher conferences this afternoon, which are not going to go well19:33
mriedemdansmith: ^ you know why19:33
dansmithlol19:33
dansmithwish I could go19:33
mlavallemriedem: thanks. good luck with the parent / teacher conference :-) I remember those days19:34
*** awaugama has quit IRC19:35
* melwitt wonders what thing happened this time19:36
efriedsean-k-mooney Took another swing at the bandwidth spec19:37
*** slaweq has joined #openstack-nova19:38
*** AlexeyAbashkin has joined #openstack-nova19:40
*** slaweq has quit IRC19:40
*** READ10 has quit IRC19:40
*** slaweq has joined #openstack-nova19:41
*** weshay|afk_see_r is now known as weshay|ruck19:42
*** tbachman has joined #openstack-nova19:43
melwittmriedem: I wonder if the problem is with cryptsetup and not luks (in your recreate patch). in the bug report lisali mentioned dmcrypt which would imply cryptsetup IIUC19:43
melwittthe hard reboot is only in the luks test19:43
sean-k-mooneyefried: cool thanks ill review it with rodolfo tomorow when im back in the office19:43
*** AlexeyAbashkin has quit IRC19:44
melwittmriedem: ah but I see in the bug summary he uses LUKS in the repro steps. nvm19:44
mriedemmelwitt: i'll check the logs when they are available to make sure it's not something like reboot failed but the instance wasn't put into ERROR state19:44
* melwitt nods19:44
*** jwcroppe has quit IRC19:45
*** penick has joined #openstack-nova19:45
mriedemmlavalle: before you scamper off,19:47
*** MasterOfBugs has joined #openstack-nova19:47
mriedemi have a question for you19:47
*** pramodrj07 has joined #openstack-nova19:47
mriedemhttps://bugs.launchpad.net/neutron/+bug/171860519:48
openstackLaunchpad bug 1718605 in neutron "[RFE] Support regex matching when filtering port with IP address" [Wishlist,Triaged] - Assigned to Zhenyu Zheng (zhengzhenyu)19:48
mriedemmlavalle: would ^ be exposed via a new networking API extension?19:48
mriedemi want to assert that it would be19:48
mriedemso nova can tell if neutron is new enough to filter ports by an ip regex19:48
*** catintheroof has joined #openstack-nova19:49
mlavallemriedem: yes, that makes sense19:49
mriedemok cool19:49
mlavalleotherwise you don't know who you are talking about19:50
mlavalletalking to^^^^19:50
mlavallegood thing you left a comment in the RFE19:50
mriedem\o/19:50
mlavalleI'll make sure we talk about it in the drivers meeting19:50
mriedemok19:51
* mlavalle scampering off19:51
*** gregwork has quit IRC19:54
*** suresh12 has quit IRC19:54
*** gregwork has joined #openstack-nova19:54
*** fragatina has joined #openstack-nova19:55
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Improve the performance of filtering instances by IP.  https://review.openstack.org/50932619:59
melwittmriedem: looks like reboot succeeded, weird http://logs.openstack.org/60/512760/1/check/legacy-tempest-dsvm-neutron-scenario-multinode-lvm-multibackend/b6880f6/logs/screen-n-cpu.txt.gz#_Oct_17_19_08_20_97247420:00
*** armax has quit IRC20:01
mriedemare you sure that's the right request?20:02
melwittnot totally sure but it's the only hard reboot in nova-api20:02
*** jwcroppe has joined #openstack-nova20:02
melwittI'm missing how to tie these to specific tests20:03
melwittnot seeing any test ids or names20:03
*** slaweq has quit IRC20:04
mriedemi think cbdc84d2-2f34-4868-8058-4c5503f5d815 is the volume id20:05
*** fragatina has quit IRC20:08
openstackgerritMerged openstack/nova stable/newton: Fix --max-count handling for nova-manage cell_v2 map_instances  https://review.openstack.org/50755720:09
mriedemStderr: u'Device /dev/sda is not a valid LUKS device.\nCommand failed with code 22: Device /dev/sda is not a valid LUKS device.\n'20:09
*** suresh12 has joined #openstack-nova20:09
mriedemoh i guess that's maybe normal20:09
mriedem"/dev/sda is not a valid LUKS device; formatting device for first use"20:09
*** suresh12 has quit IRC20:10
*** suresh12_ has joined #openstack-nova20:10
melwittI saw those errors too but they're not part of the reboot request (assuming the reboot request I found was the one you added)20:10
melwittthere was only one so I assumed it had to be it20:10
mriedemthey aren't, they are part of the attach volume operation20:11
mriedemreq-b88ac35a-19f9-4aaa-8186-75028e85d14f is the reboot request20:11
melwittyeah, that's the one I found20:11
mriedemew why do we process all of the cpu/numa topology stuff again on reboot?20:12
mriedemis that necessary?20:12
melwittit might be part of mdbooth's "redo all the things in reboot". I dunno20:12
*** smatzek has quit IRC20:13
mriedemit's part of building the guest config after we destroyed it i guess20:13
*** smatzek has joined #openstack-nova20:14
*** markvoelker_ has joined #openstack-nova20:15
*** pwiltsey has quit IRC20:16
*** tbachman has quit IRC20:18
*** markvoelker has quit IRC20:18
*** smatzek has quit IRC20:19
openstackgerritMarco Chiappero proposed openstack/nova master: [WIP] Add a communication channel for power management support  https://review.openstack.org/51281520:20
mriedemmelwitt: yeah i came to the same conclusion http://logs.openstack.org/60/512760/1/check/legacy-tempest-dsvm-neutron-scenario-multinode-lvm-multibackend/b6880f6/logs/screen-n-cpu.txt.gz#_Oct_17_19_08_20_97247420:21
*** acormier has joined #openstack-nova20:21
*** AlexeyAbashkin has joined #openstack-nova20:22
*** pwiltsey has joined #openstack-nova20:22
*** ijw has quit IRC20:24
mriedem+2 on Kevin_Zheng's spec to proxy IP filtering to neutron as a way forward https://review.openstack.org/#/c/509326/20:24
mriedemfor that perf thing20:25
*** tbachman has joined #openstack-nova20:25
*** pchavva has quit IRC20:25
*** acormier has quit IRC20:26
*** abalutoiu_ has quit IRC20:26
*** AlexeyAbashkin has quit IRC20:27
*** pwiltsey has quit IRC20:27
*** tonygunk has joined #openstack-nova20:27
*** vvargaszte has joined #openstack-nova20:29
*** vvargaszte has quit IRC20:30
*** suresh12_ has quit IRC20:31
openstackgerritMerged openstack/nova stable/newton: neutron: handle binding:profile=None during migration  https://review.openstack.org/50632320:33
*** suresh12 has joined #openstack-nova20:34
*** crushil has quit IRC20:35
*** jwcroppe has quit IRC20:35
*** catintheroof has quit IRC20:35
*** crushil has joined #openstack-nova20:36
*** catintheroof has joined #openstack-nova20:36
*** armax has joined #openstack-nova20:36
*** catintheroof has quit IRC20:36
openstackgerritMerged openstack/nova stable/pike: neutron: handle binding:profile=None during migration  https://review.openstack.org/50631920:39
openstackgerritMerged openstack/nova stable/ocata: neutron: handle binding:profile=None during migration  https://review.openstack.org/50632020:39
openstackgerritMerged openstack/nova stable/ocata: Provide original fault message when BFV fails  https://review.openstack.org/49314120:39
openstackgerritmelanie witt proposed openstack/nova stable/newton: DNM: Test hard reboot with encrypted volumes attached  https://review.openstack.org/51285220:40
openstackgerritmelanie witt proposed openstack/nova stable/newton: DNM: Test hard reboot with encrypted volumes attached  https://review.openstack.org/51285220:42
*** namnh has joined #openstack-nova20:43
*** artom has quit IRC20:46
*** namnh has quit IRC20:47
*** dave-mccowan has quit IRC20:48
*** ijw has joined #openstack-nova20:52
*** sapd__ has joined #openstack-nova20:53
*** sapd_ has quit IRC20:53
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Add pagination and timestamp filtering support for os-migrations API  https://review.openstack.org/50603020:54
mriedemdansmith: i think this migrations paging spec is ready to go ^20:55
mriedemhas the multi-cell stuff in it20:55
*** xyang1 has quit IRC20:56
*** david-lyle has quit IRC20:57
*** MVenesio has quit IRC20:57
*** tonygunk has quit IRC21:00
*** ijw has quit IRC21:01
openstackgerritMerged openstack/nova stable/newton: Provide original fault message when BFV fails  https://review.openstack.org/49320621:01
dansmithmriedem: why descending order?21:03
dansmithI mean, I know we do that in instance list but I don't know why that's good21:04
dansmithit just means that pages are in the reverse order of display in a text screen, which annoys me21:04
mriedemwas just being consistent with the instance list21:04
mriedemdefaults21:04
*** shaner has quit IRC21:05
mriedemin some earlier patch sets we were talking about what to do and just settled on following what instance list does by default,21:05
dansmithugh21:05
mriedemand that's only with the new microversion. the spec doesn't call it out, but if the request is < new microversion, we don't enforce any sort key/direction21:05
mriedemso leave it to the natural order that we get today21:05
openstackgerritMoshe Levi proposed openstack/nova master: Don't overwrite binding-profile  https://review.openstack.org/50561321:06
dansmithmriedem: which file in the api is this? not compute/migration.py right?21:06
mriedemwhere the default order is?21:06
mriedemhttps://github.com/openstack/nova/blob/master/nova/api/openstack/common.py#L14221:07
dansmither, hmm, maybe it is21:07
mriedemis what i was basing it on21:07
*** sdague has quit IRC21:08
*** crushil has quit IRC21:08
*** gouthamr has quit IRC21:08
*** vladikr has quit IRC21:11
dansmithmriedem: so, this changes id from an int to a uuid string21:12
dansmithmriedem: which seems like unnecessary breakage for people21:12
dansmithis that what we did on services, et al as well?21:12
mriedemsame as 2.5321:12
mriedemyes21:12
dansmithbummer21:12
mriedemit was either that, or return a new uuid key in the response like we did for aggregates21:13
mriedemin 2.4121:13
*** david-lyle has joined #openstack-nova21:13
mriedemdoesn't matter too much to me either way we go, as long as it's one of those two options21:13
mriedemhe originally was going to drop the id key and only return a uuid key21:13
dansmithright, returning a new uuid seems better to me,21:13
mriedemwhich would be a new 3rd way of doing that21:13
dansmithalthough you do end up with duplicate id fields, which is likely to be confusing if people assume that's an identifier21:14
mriedemi told him i preferred what we did in 2.5321:14
mriedemwhich was more consistent with instances just have a single id key21:14
mriedemalso because then when you do GET /services/{service_id} do you pass the id or the uuid?21:14
dansmithyeah but that's been a uuid forever (or almost)21:15
mriedemyeah i know - i was really leaning more the direction of the 2.53 changes21:15
mriedemwe don't have a GET /os-migrations/{migration_id} so it's less of an issue21:15
mriedemwe do, however, have GET /servers/{server_id}/migrations/{migration_id} :)21:16
mriedemwhich is the int id21:16
dansmithyeah21:16
mriedemand DELETE /servers/{server_id}/migrations/{migration_id}21:16
*** edmondsw has quit IRC21:16
mriedemso i'd be fine with adding a new uuid key to the response for os-migrations like we did in 2.4121:16
dansmithbut presumably you're doing /servers/id/migrations/ to get that id21:16
mriedemyeah, presumably21:16
mriedembut...21:16
dansmithwell, I already +Wd but lodged by discontent21:16
dansmith*my21:17
mriedemlike i said, i'd be fine with just returning a new uuid key if yo'ure worried about breaking people, or making it confusing21:17
*** edmondsw_ has joined #openstack-nova21:18
dansmithit's just unnecessary breakage which I think we should try to avoid unless we need to21:18
openstackgerritEric Fried proposed openstack/nova master: placement: add nested resource providers  https://review.openstack.org/37713821:19
openstackgerritEric Fried proposed openstack/nova master: placement: allow filter providers in tree  https://review.openstack.org/37721521:19
openstackgerritEric Fried proposed openstack/nova master: placement: adds REST API for nested providers  https://review.openstack.org/38480721:19
dansmithbut it's +Wd21:19
openstackgerritEric Fried proposed openstack/nova master: placement: update client to set parent provider  https://review.openstack.org/38569321:19
openstackgerritEric Fried proposed openstack/nova master: Reformat _get_all_with_shared  https://review.openstack.org/51279921:19
mriedemdansmith: we can amend21:20
dansmithI leave it to you, your highness21:20
mriedemgdi21:20
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Add pagination and timestamp filtering support for os-migrations API  https://review.openstack.org/50603021:21
*** tssurya has quit IRC21:21
dansmithmriedem: I meant leave the decision to you21:22
*** edmondsw_ has quit IRC21:22
mriedemyeah i agree with your point,21:22
mriedemi hadn't thought about the lack of GET /os-migratoins/{migration_id} or PUT etc21:23
mriedemi will say, the api-ref docs changes for communicating the id->uuid thing in 2.53 sucked21:23
mriedemso i'd like to avoid that again21:23
dansmithso, another way to decide would be:21:23
dansmithassuming we update the instance-scoped one to be the same,21:23
dansmithwould you prefer that one to just be id:$uuid because of the GET/ ?21:24
dansmithif so, then maybe they should both be the same and just put the uuid in the id21:24
mriedemwe don't need to return the uuid out of the instance-scoped one, because when we lookup the instance we know which cell the migration record is in21:24
dansmithI don't know tbh21:24
mriedem^ is why i didn't have to handle returning a uuid for the instance-scoped migrations in 2.5321:24
dansmiththe least amount of total breakage would be just a new uuid field on the global one21:24
*** thorst has quit IRC21:25
*** thorst has joined #openstack-nova21:26
dansmithmriedem: well, I have to run off and do something else in a few21:26
dansmithmriedem: so you choose and either proxy my +2 on there or I'll hit it later on when I'm back21:26
mriedemi -1ed, yikun can update tonight, we'll +W tomorrow21:27
mriedemi have to see ms engle soon21:27
dansmithokay21:27
dansmithhaha21:27
mriedemlaura will dress up of course and i'll look the slob21:27
dansmithsame old story every time I leave the house21:27
*** thorst has quit IRC21:30
*** fragatina has joined #openstack-nova21:30
mriedemmtreinish: can you hit these 3 newton changes that have a +2 in them? https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/newton trying to flush these out before eol21:31
*** flanders_ has joined #openstack-nova21:31
*** josecastroleon has quit IRC21:34
*** josecastroleon has joined #openstack-nova21:37
mtreinishmriedem: sure, I'll look in a sec21:39
melwittmriedem: tempest.scenario.test_encrypted_cinder_volumes.TestEncryptedCinderVolumes.test_encrypted_cinder_volumes_luks [234.382405s] ... FAILED on the newton DNM patch21:40
melwittwill dig in once logs are available21:41
*** burt has quit IRC21:41
*** salv-orlando has joined #openstack-nova21:42
mriedemmelwitt: aha21:44
*** salv-orlando has quit IRC21:44
*** salv-orlando has joined #openstack-nova21:44
melwittI guess the question will still be something like, did os-brick fix the problem as a side effect and we should still do the nova change or did os-brick legit fix something21:44
mriedemidk, would have to figure out what the actual root failure was and what was changed in os-brick that makes it no longer a problem21:45
mriedemin that case the fix might be backporting something in os-brick21:45
melwittyeah. if os-brick did something to legit fix it, we would backport that instead21:46
melwittbut if it's a side effect, we may still want the nova change to not rely on a side effect, if that makes sense21:46
mriedemsean-k-mooney: mlavalle: comments inline https://review.openstack.org/#/c/375580/21:46
mriedemgotta run21:47
mlavallemriedem: thanks21:47
*** fragatina has quit IRC21:48
openstackgerritmelanie witt proposed openstack/nova master: Remove old-style quotas code  https://review.openstack.org/51168921:49
*** erlon has quit IRC21:50
*** thorst has joined #openstack-nova21:50
*** edmondsw has joined #openstack-nova21:51
*** shaner has joined #openstack-nova21:51
*** thorst has quit IRC21:54
*** edmondsw has quit IRC21:55
*** esberglu has quit IRC21:55
*** esberglu has joined #openstack-nova21:56
*** Apoorva_ has joined #openstack-nova21:59
*** esberglu has quit IRC22:00
*** Apoorva has quit IRC22:03
*** shaner has quit IRC22:08
*** baoli has quit IRC22:10
*** shaner has joined #openstack-nova22:12
*** ijw has joined #openstack-nova22:16
*** felipemonteiro__ has quit IRC22:17
*** ijw has quit IRC22:20
*** penick has quit IRC22:22
*** rodolof has quit IRC22:24
*** lyan has quit IRC22:25
*** suresh12 has quit IRC22:33
*** suresh12 has joined #openstack-nova22:34
*** suresh12 has quit IRC22:35
*** suresh12 has joined #openstack-nova22:35
openstackgerritEd Leafe proposed openstack/nova master: Change RPC for select_destinations()  https://review.openstack.org/51015922:36
openstackgerritEd Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils  https://review.openstack.org/51135722:36
openstackgerritEd Leafe proposed openstack/nova master: Make conductor pass and use host_lists  https://review.openstack.org/51135822:36
*** dave-mccowan has joined #openstack-nova22:36
*** lbragstad has quit IRC22:36
openstackgerritmelanie witt proposed openstack/nova stable/newton: DNM: libvirt: Fully destroy instances during a hard reboot  https://review.openstack.org/51289622:42
*** catintheroof has joined #openstack-nova22:43
*** salv-orlando has quit IRC22:45
*** salv-orlando has joined #openstack-nova22:46
*** suresh12 has quit IRC22:46
*** oanson has quit IRC22:50
*** salv-orlando has quit IRC22:51
*** oanson has joined #openstack-nova22:52
*** suresh12 has joined #openstack-nova22:58
*** suresh12 has quit IRC22:58
*** suresh12 has joined #openstack-nova22:59
*** gjayavelu has quit IRC23:01
*** gjayavelu has joined #openstack-nova23:01
*** mlavalle has quit IRC23:10
*** chyka_ has quit IRC23:11
*** Apoorva_ has quit IRC23:11
*** Apoorva has joined #openstack-nova23:11
*** ijw has joined #openstack-nova23:17
*** catintheroof has quit IRC23:17
*** jobewan has quit IRC23:20
*** ijw has quit IRC23:22
*** gmann_afk is now known as gmann23:24
*** esberglu has joined #openstack-nova23:31
*** hongbin has quit IRC23:32
*** yikun_ has joined #openstack-nova23:35
*** crushil has joined #openstack-nova23:36
*** claudiub has quit IRC23:36
*** salv-orlando has joined #openstack-nova23:46
*** takashin has joined #openstack-nova23:47
*** jmlowe has joined #openstack-nova23:47
*** artom has joined #openstack-nova23:49
*** salv-orlando has quit IRC23:52
openstackgerritMerged openstack/nova stable/pike: Enable custom certificates for keystone communication  https://review.openstack.org/50554623:57
openstackgerritMerged openstack/nova stable/newton: Add live.migration.force.complete to the legacy notification whitelist  https://review.openstack.org/50890223:57
openstackgerritMerged openstack/nova stable/newton: Account for compute.metrics.update in legacy notification whitelist  https://review.openstack.org/50944123:58
openstackgerritMerged openstack/nova stable/newton: Catch InstanceNotFound exception  https://review.openstack.org/46732123:58
*** ijw has joined #openstack-nova23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!