*** salv-orlando has quit IRC | 00:00 | |
*** suresh12 has quit IRC | 00:04 | |
*** takashin has left #openstack-nova | 00:04 | |
*** derekh has joined #openstack-nova | 00:06 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix functional tests for USE_NEUTRON https://review.openstack.org/529456 | 00:06 |
---|---|---|
*** suresh12 has joined #openstack-nova | 00:06 | |
*** penick_ has quit IRC | 00:08 | |
*** penick has joined #openstack-nova | 00:08 | |
*** penick has quit IRC | 00:08 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix functional tests for USE_NEUTRON https://review.openstack.org/529456 | 00:12 |
*** david-lyle has quit IRC | 00:12 | |
*** david-lyle has joined #openstack-nova | 00:12 | |
*** huanxie has quit IRC | 00:19 | |
*** huanxie has joined #openstack-nova | 00:19 | |
*** harlowja has quit IRC | 00:23 | |
*** chyka has quit IRC | 00:25 | |
*** jobewan has quit IRC | 00:27 | |
*** tuanla____ has joined #openstack-nova | 00:27 | |
*** derekh has quit IRC | 00:27 | |
*** yangyapeng has quit IRC | 00:28 | |
*** hiro-kobayashi has joined #openstack-nova | 00:30 | |
*** derekh has joined #openstack-nova | 00:32 | |
*** AlexeyAbashkin has joined #openstack-nova | 00:33 | |
*** mlavalle has quit IRC | 00:37 | |
*** AlexeyAbashkin has quit IRC | 00:37 | |
*** gongysh has joined #openstack-nova | 00:49 | |
*** huanxie has quit IRC | 00:50 | |
*** huanxie has joined #openstack-nova | 00:51 | |
*** edmondsw has joined #openstack-nova | 00:52 | |
*** gongysh has quit IRC | 00:55 | |
*** kumarmn has quit IRC | 00:56 | |
*** salv-orlando has joined #openstack-nova | 00:56 | |
*** edmondsw has quit IRC | 00:57 | |
*** phuongnh has joined #openstack-nova | 00:58 | |
*** markvoelker has quit IRC | 00:58 | |
yikun | https://launchpad.net/bugs/1739571 and https://review.openstack.org/#/c/529519/ | 00:59 |
openstack | Launchpad bug 1739571 in OpenStack Compute (nova) "Can't delete root resource provider because of the self foreign key" [Undecided,In progress] - Assigned to Yikun Jiang (yikunkero) | 01:00 |
yikun | hello, morning or evening, ^^^ I found a bug, but this bug only reproduced in MySQL environment. | 01:00 |
yikun | but seems our testcases only run in SQLite, so, is there some apporach to test it? | 01:00 |
*** chyka has joined #openstack-nova | 01:01 | |
*** salv-orlando has quit IRC | 01:02 | |
*** claudiub has quit IRC | 01:02 | |
*** chyka has quit IRC | 01:06 | |
*** derekh has quit IRC | 01:07 | |
*** markvoelker has joined #openstack-nova | 01:10 | |
*** daidv has quit IRC | 01:25 | |
*** tuanla____ has quit IRC | 01:25 | |
*** hieulq has quit IRC | 01:25 | |
*** daidv has joined #openstack-nova | 01:25 | |
*** hieulq has joined #openstack-nova | 01:25 | |
*** tuanla____ has joined #openstack-nova | 01:25 | |
*** Tom-Tom has quit IRC | 01:25 | |
*** Apoorva has quit IRC | 01:29 | |
*** psachin has joined #openstack-nova | 01:32 | |
*** yangyapeng has joined #openstack-nova | 01:32 | |
*** AlexeyAbashkin has joined #openstack-nova | 01:34 | |
*** marst has quit IRC | 01:38 | |
*** AlexeyAbashkin has quit IRC | 01:38 | |
*** Tom-Tom has joined #openstack-nova | 01:40 | |
openstackgerrit | Minho Ban proposed openstack/nova master: prevent removing numa_topology usage info from DB https://review.openstack.org/529236 | 01:44 |
*** lei-zh has joined #openstack-nova | 01:45 | |
*** gyee has quit IRC | 01:48 | |
*** liverpooler has joined #openstack-nova | 01:54 | |
*** salv-orlando has joined #openstack-nova | 01:58 | |
*** salv-orlando has quit IRC | 02:03 | |
alex_xu | mriedem: oomichi do you like using the 'controller' instead of 'extension'? | 02:06 |
*** gongysh has joined #openstack-nova | 02:09 | |
*** zhenguo has joined #openstack-nova | 02:13 | |
*** linkmark has quit IRC | 02:19 | |
*** liverpooler has quit IRC | 02:20 | |
*** yikun_ has quit IRC | 02:22 | |
*** suresh12 has quit IRC | 02:26 | |
*** huanxie has quit IRC | 02:27 | |
*** Apoorva has joined #openstack-nova | 02:30 | |
mriedem | alex_xu: i'll do either | 02:31 |
mriedem | yikun: there is a trick to make foreign keys work with sqlite, | 02:32 |
*** itlinux has quit IRC | 02:32 | |
mriedem | sec | 02:32 |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Fix error when deleting any root resource provider https://review.openstack.org/529519 | 02:33 |
mriedem | sqlite 3.7+ should work with foreign keys | 02:33 |
mriedem | see TestDatabaseArchive | 02:33 |
*** suresh12 has joined #openstack-nova | 02:33 | |
mriedem | engine.connect().execute("PRAGMA foreign_keys = ON") | 02:33 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Test allocation candidates: multiple aggregates https://review.openstack.org/518633 | 02:33 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Test helper: validate provider summaries https://review.openstack.org/518982 | 02:33 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Fix accumulated nits in refactor series https://review.openstack.org/521189 | 02:33 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add aggregates check in allocation candidates https://review.openstack.org/522407 | 02:33 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Fix missing rps in allocation candidates https://review.openstack.org/522409 | 02:33 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: placement: func tests for multiple shared RPs https://review.openstack.org/498737 | 02:33 |
*** AlexeyAbashkin has joined #openstack-nova | 02:34 | |
yikun | o? I will take a look, and try it in my local env, thanks. : ) | 02:34 |
yikun | mriedem, | 02:34 |
mriedem | yw | 02:34 |
*** Apoorva has quit IRC | 02:35 | |
*** suresh12 has quit IRC | 02:38 | |
*** AlexeyAbashkin has quit IRC | 02:38 | |
mriedem | yikun: fyi https://review.openstack.org/#/c/529672/ | 02:38 |
mriedem | turns out we needed that after all | 02:38 |
*** psachin has quit IRC | 02:40 | |
*** mriedem has quit IRC | 02:40 | |
yikun | mriedem, emm, yes, +1, the deadlock on action event start is possible, | 02:42 |
yikun | because action and event doesn't have some relation ship, so sqlalchemy session mechanism can't ensure the update order. | 02:42 |
yikun | some ref: http://www.aosabook.org/en/sqlalchemy.html # 20.9. Unit of Work | 02:43 |
Kevin_Zheng | consider add relationship? | 02:45 |
openstackgerrit | Merged openstack/nova master: Fix unit test failures when direct IO not supported https://review.openstack.org/529568 | 02:45 |
Kevin_Zheng | mriedem we were thinking about a full scan about these kind of things in Nova | 02:46 |
Kevin_Zheng | https://review.openstack.org/#/c/527362/ | 02:46 |
*** yikun_ has joined #openstack-nova | 02:47 | |
Kevin_Zheng | ^ the deadlock retry method is not perfect, so we might be able to improve performance here | 02:47 |
*** yamahata has quit IRC | 02:53 | |
*** psachin has joined #openstack-nova | 02:55 | |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Test allocation candidates: multiple aggregates https://review.openstack.org/518633 | 02:58 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Test helper: validate provider summaries https://review.openstack.org/518982 | 02:58 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Fix accumulated nits in refactor series https://review.openstack.org/521189 | 02:58 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add aggregates check in allocation candidates https://review.openstack.org/522407 | 02:58 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Fix missing rps in allocation candidates https://review.openstack.org/522409 | 02:58 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: placement: func tests for multiple shared RPs https://review.openstack.org/498737 | 02:58 |
*** salv-orlando has joined #openstack-nova | 02:59 | |
*** salv-orlando has quit IRC | 03:03 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/529783 | 03:04 |
*** zhurong has joined #openstack-nova | 03:09 | |
*** xinliang has quit IRC | 03:19 | |
*** Guest98938 has quit IRC | 03:20 | |
*** itlinux has joined #openstack-nova | 03:22 | |
*** crushil has joined #openstack-nova | 03:29 | |
*** yamahata has joined #openstack-nova | 03:33 | |
*** crushil has quit IRC | 03:33 | |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: trivial: use cn instead of rp https://review.openstack.org/529786 | 03:37 |
*** Tom-Tom has quit IRC | 03:47 | |
*** Tom-Tom has joined #openstack-nova | 03:48 | |
*** Tom-Tom has quit IRC | 04:00 | |
*** salv-orlando has joined #openstack-nova | 04:00 | |
*** Tom-Tom has joined #openstack-nova | 04:01 | |
*** salv-orlando has quit IRC | 04:04 | |
*** Tom-Tom has quit IRC | 04:05 | |
*** archit is now known as amodi | 04:09 | |
*** markvoelker has quit IRC | 04:13 | |
*** lei-zh has quit IRC | 04:20 | |
*** rcernin has quit IRC | 04:26 | |
*** rcernin has joined #openstack-nova | 04:27 | |
*** edmondsw has joined #openstack-nova | 04:28 | |
*** threestrands_ has quit IRC | 04:29 | |
*** zhurong has quit IRC | 04:32 | |
*** edmondsw has quit IRC | 04:33 | |
*** yamamoto has joined #openstack-nova | 04:39 | |
*** udesale has joined #openstack-nova | 04:39 | |
*** amodi has quit IRC | 04:43 | |
*** links has joined #openstack-nova | 04:43 | |
*** gmann has joined #openstack-nova | 04:46 | |
*** rcernin has quit IRC | 04:47 | |
*** gongysh has quit IRC | 04:48 | |
*** rcernin has joined #openstack-nova | 04:49 | |
*** hshiina has joined #openstack-nova | 04:51 | |
*** Apoorva has joined #openstack-nova | 04:56 | |
*** sridharg has joined #openstack-nova | 04:56 | |
*** salv-orlando has joined #openstack-nova | 04:58 | |
*** lbragstad has quit IRC | 04:59 | |
openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: provide VGPU_DISPLAY_HEAD inventory in compute node https://review.openstack.org/523342 | 05:03 |
*** yangyapeng has quit IRC | 05:17 | |
*** yangyapeng has joined #openstack-nova | 05:17 | |
*** daidv has quit IRC | 05:26 | |
*** tuanla____ has quit IRC | 05:26 | |
*** daidv has joined #openstack-nova | 05:26 | |
*** tuanla____ has joined #openstack-nova | 05:26 | |
*** sridharg has quit IRC | 05:32 | |
*** janki has joined #openstack-nova | 05:34 | |
*** yangyapeng has quit IRC | 05:36 | |
*** yangyapeng has joined #openstack-nova | 05:37 | |
*** yangyapeng has quit IRC | 05:41 | |
*** Apoorva has quit IRC | 05:43 | |
*** gcb has quit IRC | 05:44 | |
*** ejat has quit IRC | 05:52 | |
*** armax has quit IRC | 05:54 | |
*** vivsoni has joined #openstack-nova | 05:56 | |
*** gongysh has joined #openstack-nova | 05:57 | |
*** sridharg has joined #openstack-nova | 05:59 | |
*** ejat has joined #openstack-nova | 06:00 | |
*** ejat has joined #openstack-nova | 06:00 | |
*** ejat has quit IRC | 06:00 | |
*** ejat has joined #openstack-nova | 06:01 | |
*** ejat has quit IRC | 06:01 | |
*** ejat has joined #openstack-nova | 06:01 | |
*** gouthamr has quit IRC | 06:07 | |
*** yangyapeng has joined #openstack-nova | 06:07 | |
*** ratailor has joined #openstack-nova | 06:07 | |
*** markvoelker has joined #openstack-nova | 06:14 | |
*** edmondsw has joined #openstack-nova | 06:16 | |
*** Tom-Tom has joined #openstack-nova | 06:19 | |
*** edmondsw has quit IRC | 06:20 | |
*** yikun_ has quit IRC | 06:22 | |
*** tetsuro_ has quit IRC | 06:29 | |
*** alexchadin has joined #openstack-nova | 06:31 | |
*** Tom-Tom_ has joined #openstack-nova | 06:32 | |
*** felipemonteiro__ has joined #openstack-nova | 06:35 | |
*** Tom-Tom has quit IRC | 06:35 | |
-openstackstatus- NOTICE: Zuul.openstack.org is currently under heavy load and not starting new jobs. We're waiting for an admin to restart Zuul. | 06:44 | |
*** sridharg has quit IRC | 06:44 | |
*** heyongli has joined #openstack-nova | 06:48 | |
*** markvoelker has quit IRC | 06:49 | |
*** sridharg has joined #openstack-nova | 06:52 | |
*** heyongli has quit IRC | 06:53 | |
*** heyongli has joined #openstack-nova | 06:54 | |
*** hemna_ has quit IRC | 06:56 | |
*** heyongli has quit IRC | 07:04 | |
*** heyongli has joined #openstack-nova | 07:04 | |
*** rcernin has quit IRC | 07:04 | |
*** hiro-kobayashi has quit IRC | 07:10 | |
*** jdurgin has quit IRC | 07:11 | |
*** heyongli has quit IRC | 07:14 | |
*** heyongli has joined #openstack-nova | 07:14 | |
*** heyongli has quit IRC | 07:24 | |
*** heyongli has joined #openstack-nova | 07:24 | |
*** heyongli has quit IRC | 07:34 | |
*** heyongli has joined #openstack-nova | 07:35 | |
*** claudiub has joined #openstack-nova | 07:40 | |
*** hui has quit IRC | 07:44 | |
*** heyongli has quit IRC | 07:45 | |
*** heyongli has joined #openstack-nova | 07:45 | |
*** AlexeyAbashkin has joined #openstack-nova | 07:53 | |
*** heyongli has quit IRC | 07:55 | |
*** heyongli has joined #openstack-nova | 07:55 | |
*** sahid has joined #openstack-nova | 07:57 | |
*** edmondsw has joined #openstack-nova | 08:04 | |
*** heyongli has quit IRC | 08:05 | |
*** heyongli has joined #openstack-nova | 08:05 | |
*** edmondsw has quit IRC | 08:09 | |
*** AlexeyAbashkin has quit IRC | 08:15 | |
*** heyongli has quit IRC | 08:15 | |
*** heyongli has joined #openstack-nova | 08:16 | |
*** AlexeyAbashkin has joined #openstack-nova | 08:21 | |
*** tuanla____ has quit IRC | 08:22 | |
*** daidv has quit IRC | 08:22 | |
*** hieulq has quit IRC | 08:22 | |
*** daidv has joined #openstack-nova | 08:22 | |
*** tuanla____ has joined #openstack-nova | 08:22 | |
*** hieulq has joined #openstack-nova | 08:22 | |
*** pcaruana has joined #openstack-nova | 08:24 | |
*** AlexeyAbashkin has quit IRC | 08:25 | |
*** heyongli has quit IRC | 08:26 | |
*** AlexeyAbashkin has joined #openstack-nova | 08:26 | |
*** phuongnh has quit IRC | 08:26 | |
*** hoangcx has quit IRC | 08:26 | |
*** heyongli has joined #openstack-nova | 08:26 | |
*** phuongnh has joined #openstack-nova | 08:26 | |
*** hoangcx has joined #openstack-nova | 08:26 | |
*** abhishekk has joined #openstack-nova | 08:27 | |
*** damien_r has joined #openstack-nova | 08:32 | |
*** heyongli has quit IRC | 08:36 | |
*** heyongli has joined #openstack-nova | 08:36 | |
*** yamamoto has quit IRC | 08:36 | |
*** kholkina has joined #openstack-nova | 08:44 | |
*** jpena|off is now known as jpena | 08:45 | |
*** fragatina has joined #openstack-nova | 08:45 | |
*** markvoelker has joined #openstack-nova | 08:46 | |
*** heyongli has quit IRC | 08:46 | |
*** heyongli has joined #openstack-nova | 08:46 | |
*** yamamoto has joined #openstack-nova | 08:47 | |
*** yamamoto has quit IRC | 08:48 | |
*** yamamoto has joined #openstack-nova | 08:49 | |
*** zhurong has joined #openstack-nova | 08:55 | |
*** nore__ has quit IRC | 08:56 | |
*** heyongli has quit IRC | 08:56 | |
*** heyongli has joined #openstack-nova | 08:57 | |
*** Tom-Tom_ has quit IRC | 09:04 | |
*** Tom-Tom has joined #openstack-nova | 09:04 | |
*** heyongli has quit IRC | 09:07 | |
*** heyongli has joined #openstack-nova | 09:07 | |
*** Tom-Tom has quit IRC | 09:07 | |
*** Tom-Tom has joined #openstack-nova | 09:08 | |
*** karthiks has joined #openstack-nova | 09:09 | |
*** heyongli has quit IRC | 09:17 | |
*** heyongli has joined #openstack-nova | 09:17 | |
*** derekh has joined #openstack-nova | 09:18 | |
*** markvoelker has quit IRC | 09:19 | |
*** Tom-Tom has quit IRC | 09:19 | |
*** felipemonteiro__ has quit IRC | 09:21 | |
*** heyongli has quit IRC | 09:27 | |
*** heyongli has joined #openstack-nova | 09:27 | |
*** lucas-afk is now known as lucasagomes | 09:31 | |
openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: Update resources once in update_available_resource https://review.openstack.org/520024 | 09:33 |
openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: Update resources once in update_available_resource https://review.openstack.org/520024 | 09:37 |
*** heyongli has quit IRC | 09:37 | |
*** heyongli has joined #openstack-nova | 09:38 | |
*** Jack_Iv has joined #openstack-nova | 09:43 | |
*** Jack_Iv has quit IRC | 09:45 | |
*** Jack_Iv has joined #openstack-nova | 09:45 | |
*** ralonsoh has joined #openstack-nova | 09:45 | |
*** heyongli has quit IRC | 09:48 | |
*** heyongli has joined #openstack-nova | 09:48 | |
*** edmondsw has joined #openstack-nova | 09:52 | |
*** chyka has joined #openstack-nova | 09:56 | |
*** hshiina has quit IRC | 09:56 | |
*** edmondsw has quit IRC | 09:57 | |
*** heyongli has quit IRC | 09:58 | |
*** heyongli has joined #openstack-nova | 09:58 | |
*** owalsh_ is now known as owalsh | 10:00 | |
*** chyka has quit IRC | 10:01 | |
*** zhurong has quit IRC | 10:04 | |
*** heyongli has quit IRC | 10:08 | |
*** heyongli has joined #openstack-nova | 10:08 | |
*** gongysh has quit IRC | 10:10 | |
*** daidv has quit IRC | 10:10 | |
*** psachin has quit IRC | 10:12 | |
ralonsoh | stephenfin: hi, about https://review.openstack.org/#/c/449257/52/nova/pci/request.py@93 | 10:14 |
*** markvoelker has joined #openstack-nova | 10:16 | |
*** tuanla____ has quit IRC | 10:17 | |
-openstackstatus- NOTICE: zuul has been restarted, all queues have been reset. please recheck your patches when appropriate | 10:17 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Change 'InstancePCIRequest' spec field https://review.openstack.org/449257 | 10:18 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/507481 | 10:18 |
*** heyongli has quit IRC | 10:18 | |
*** heyongli has joined #openstack-nova | 10:19 | |
*** heyongli has quit IRC | 10:29 | |
*** heyongli has joined #openstack-nova | 10:29 | |
*** hoangcx has quit IRC | 10:35 | |
*** heyongli has quit IRC | 10:39 | |
*** heyongli has joined #openstack-nova | 10:39 | |
*** cdent has joined #openstack-nova | 10:46 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: create vGPU for instance https://review.openstack.org/528832 | 10:49 |
*** heyongli has quit IRC | 10:49 | |
*** heyongli has joined #openstack-nova | 10:49 | |
*** markvoelker has quit IRC | 10:50 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API https://review.openstack.org/476612 | 10:55 |
*** abhishekk has quit IRC | 10:57 | |
*** heyongli has quit IRC | 10:59 | |
*** heyongli has joined #openstack-nova | 11:00 | |
*** udesale has quit IRC | 11:00 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API https://review.openstack.org/476612 | 11:01 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226 | 11:05 |
*** heyongli has quit IRC | 11:10 | |
*** heyongli has joined #openstack-nova | 11:10 | |
*** AlexeyAbashkin has quit IRC | 11:13 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migrate from 'ip' commands to 'pyroute2' https://review.openstack.org/484386 | 11:16 |
*** itlinux has quit IRC | 11:16 | |
*** heyongli has quit IRC | 11:20 | |
*** heyongli has joined #openstack-nova | 11:20 | |
*** phuongnh has quit IRC | 11:20 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add memoize function using oslo.cache https://review.openstack.org/472773 | 11:22 |
*** heyongli has quit IRC | 11:30 | |
*** heyongli has joined #openstack-nova | 11:30 | |
*** AlexeyAbashkin has joined #openstack-nova | 11:31 | |
openstackgerrit | rahul bardia proposed openstack/python-novaclient master: nova limits ERROR (Exception): Field names must be unique https://review.openstack.org/527922 | 11:33 |
*** xinliang has joined #openstack-nova | 11:33 | |
*** xinliang has quit IRC | 11:33 | |
*** xinliang has joined #openstack-nova | 11:33 | |
*** heyongli has quit IRC | 11:40 | |
*** edmondsw has joined #openstack-nova | 11:41 | |
*** heyongli has joined #openstack-nova | 11:41 | |
*** janki has quit IRC | 11:41 | |
*** edmondsw has quit IRC | 11:45 | |
*** markvoelker has joined #openstack-nova | 11:47 | |
*** heyongli has quit IRC | 11:51 | |
*** heyongli has joined #openstack-nova | 11:51 | |
*** vladikr has quit IRC | 11:54 | |
*** vladikr has joined #openstack-nova | 11:56 | |
*** alexchadin has quit IRC | 11:58 | |
*** ratailor has quit IRC | 12:00 | |
*** karthiks has quit IRC | 12:01 | |
*** heyongli has quit IRC | 12:01 | |
*** ratailor has joined #openstack-nova | 12:01 | |
*** heyongli has joined #openstack-nova | 12:01 | |
*** alexchad_ has joined #openstack-nova | 12:02 | |
*** alexchad_ has quit IRC | 12:06 | |
*** alexchadin has joined #openstack-nova | 12:08 | |
*** smatzek has joined #openstack-nova | 12:10 | |
*** heyongli has quit IRC | 12:11 | |
*** yamamoto has quit IRC | 12:11 | |
*** heyongli has joined #openstack-nova | 12:11 | |
*** alexchadin has quit IRC | 12:13 | |
*** yamamoto has joined #openstack-nova | 12:19 | |
*** markvoelker has quit IRC | 12:20 | |
*** heyongli has quit IRC | 12:21 | |
*** heyongli has joined #openstack-nova | 12:22 | |
*** chyka has joined #openstack-nova | 12:22 | |
*** tbachman has quit IRC | 12:26 | |
*** chyka has quit IRC | 12:27 | |
*** Lingwu has quit IRC | 12:29 | |
*** Lingwu has joined #openstack-nova | 12:31 | |
*** heyongli has quit IRC | 12:32 | |
*** heyongli has joined #openstack-nova | 12:32 | |
*** gmann has quit IRC | 12:33 | |
*** lucasagomes is now known as lucas-hungry | 12:38 | |
*** heyongli has quit IRC | 12:42 | |
*** heyongli has joined #openstack-nova | 12:42 | |
*** takedakn has joined #openstack-nova | 12:43 | |
*** Jack_Iv has quit IRC | 12:46 | |
*** linkmark has joined #openstack-nova | 12:47 | |
*** Jack_Iv has joined #openstack-nova | 12:47 | |
*** Jack_Iv has quit IRC | 12:52 | |
*** heyongli has quit IRC | 12:52 | |
*** heyongli has joined #openstack-nova | 12:52 | |
*** jpena is now known as jpena|lunch | 12:53 | |
jaypipes | good morning nova comrades. | 12:55 |
*** dave-mccowan has joined #openstack-nova | 12:56 | |
cdent | morning jaypipes | 12:57 |
cdent | get your dishwasher and dinner sorted? | 12:58 |
jaypipes | no and yes. | 12:58 |
jaypipes | cdent: friggin electricians hooked up the dishwasher's electric but said they could touch the plumbing. so I hooked up the plumbing and there's a leak. so my wife's uncle is out grabbing plumber's tape and we're going to pull it out and have a look at where the leak is. the saga continues. | 12:59 |
cdent | argh | 12:59 |
jaypipes | cdent: cost me almost as much for the 1.25 hours of electrician as for the new dishwasher :( | 12:59 |
jaypipes | $400... | 12:59 |
cdent | jeebus | 12:59 |
jaypipes | ya. | 13:00 |
*** ratailor has quit IRC | 13:00 | |
jaypipes | so after dinner, the eleven of us just made a Hobbit-dwarf-esque factory line and polished off the dish cleanup team-style. | 13:00 |
cdent | well if it makes you feel any better, one christmas at my parents, where they had no dishwasher, I was responsible for peeling the potatoes and somehow managed to completely screwn up the garbage disposal such that the sink wouldn't drain | 13:00 |
cdent | we did the dishes in the bathtub | 13:01 |
cdent | did you sing? | 13:01 |
*** heyongli has quit IRC | 13:02 | |
*** heyongli has joined #openstack-nova | 13:03 | |
*** vladikr has quit IRC | 13:06 | |
jaypipes | cdent: heh, that's... awesome. :) and no, I did not sign. | 13:06 |
jaypipes | sing | 13:06 |
*** Jack_Iv has joined #openstack-nova | 13:08 | |
*** Jack_Iv has quit IRC | 13:10 | |
*** Jack_Iv has joined #openstack-nova | 13:11 | |
maciejjozefczyk | jaypipes: good morning | 13:12 |
jaypipes | maciejjozefczyk: mornin! | 13:12 |
jaypipes | maciejjozefczyk: or afternoon for you I suppose :) | 13:12 |
*** jaypipes is now known as leakypipes | 13:13 | |
*** heyongli has quit IRC | 13:13 | |
leakypipes | cdent: my nick actually reflects current status today. | 13:13 |
*** ygl has joined #openstack-nova | 13:13 | |
*** heyongli has joined #openstack-nova | 13:13 | |
cdent | woot | 13:13 |
maciejjozefczyk | jaypipes: here in PL - yes, afternoon, but also good ;) | 13:13 |
leakypipes | maciejjozefczyk: are you in Poznan or Gdansk? | 13:14 |
maciejjozefczyk | leakypipes: sorry for saying that but this change https://review.openstack.org/#/c/520024 breaks resource tracking in placement :) I need to dig more | 13:14 |
maciejjozefczyk | leakypipes: Wroclaw | 13:14 |
leakypipes | ah | 13:14 |
*** Jack_Iv has quit IRC | 13:15 | |
leakypipes | maciejjozefczyk: k, I'll take a look at that patch again (on the resource provider issue) shortly. | 13:15 |
*** dave-mcc_ has joined #openstack-nova | 13:16 | |
leakypipes | maciejjozefczyk: what you can try in the meantime is just replacing each of those calls to self._update() one by one and see which specific one causes the invalid inventory exception to go away... | 13:17 |
openstackgerrit | rahul bardia proposed openstack/python-novaclient master: nova limits ERROR (Exception): Field names must be unique https://review.openstack.org/527922 | 13:17 |
maciejjozefczyk | leakypipes: I found that its in _update_inventory_for_provider /opt/stack/nova/nova/objects/resource_provider.py(232 | 13:17 |
*** markvoelker has joined #openstack-nova | 13:17 | |
leakypipes | maciejjozefczyk: yes, I see that. but I'm wondering which of the locations in https://review.openstack.org/#/c/520024/8/nova/compute/resource_tracker.py where you removed the call to self._update() causes that exception to be hit. | 13:18 |
leakypipes | maciejjozefczyk: so you might try replacing (one by one) those call locations of self._update() in the resource tracker and determining which of those calls fixes the reserved inventory invalid exception. | 13:19 |
leakypipes | that's all I was saying :) | 13:19 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migrate from 'ip' commands to 'pyroute2' https://review.openstack.org/484386 | 13:19 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add support for Windows network commands https://review.openstack.org/487405 | 13:19 |
*** dave-mccowan has quit IRC | 13:19 | |
*** tetsuro has joined #openstack-nova | 13:20 | |
*** owalsh is now known as owalsh_afk | 13:23 | |
*** Jack_Iv has joined #openstack-nova | 13:23 | |
*** heyongli has quit IRC | 13:23 | |
maciejjozefczyk | leakypipes: I found that because I've removed duplications the self._resource_change(compute_node) always says false (yeah, thats right) so the ComputeNode object is not updated directly (I mean with cn.save()), and without this call the exceptions is raised by placement | 13:23 |
maciejjozefczyk | https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L854 | 13:23 |
*** heyongli has joined #openstack-nova | 13:23 | |
maciejjozefczyk | leakypipes: anyway, need to switch context because of other tasks... We'll dig it later ;) | 13:23 |
maciejjozefczyk | s/we/I/ :) | 13:24 |
leakypipes | k, no prob | 13:24 |
bauzas | hola, folks | 13:24 |
bauzas | (yeah, it seems weird that I'm looking to be in an US TZ, but no worries, I was not looking at the IRC this morning :p) | 13:24 |
leakypipes | bauzas: where are ya? | 13:26 |
bauzas | just still in Le Versoud, FR :p | 13:26 |
bauzas | wed, I was off because $skiing | 13:27 |
bauzas | so, I needed to work off the IRC by this morning for other things :( | 13:27 |
bauzas | oh, and Friday, right | 13:28 |
*** bauzas is now known as bauwser | 13:28 | |
*** Jack_Iv has quit IRC | 13:30 | |
*** ralonsoh has quit IRC | 13:30 | |
*** Jack_Iv has joined #openstack-nova | 13:31 | |
openstackgerrit | Merged openstack/nova master: Don't try to delete build request during a reschedule https://review.openstack.org/528835 | 13:33 |
*** heyongli has quit IRC | 13:33 | |
*** heyongli has joined #openstack-nova | 13:33 | |
*** edleafe is now known as figleaf | 13:36 | |
*** yangyapeng has quit IRC | 13:36 | |
*** yangyapeng has joined #openstack-nova | 13:37 | |
*** Jack_Iv has quit IRC | 13:37 | |
*** Jack_Iv has joined #openstack-nova | 13:38 | |
*** mriedem has joined #openstack-nova | 13:38 | |
*** tetsuro has quit IRC | 13:38 | |
*** markvoelker has quit IRC | 13:40 | |
*** markvoelker has joined #openstack-nova | 13:40 | |
*** yangyapeng has quit IRC | 13:42 | |
*** stephenfin is now known as finucannot | 13:42 | |
mriedem | mdbooth: ping me once https://review.openstack.org/#/c/242602/ is fixed up and i'll +2 | 13:42 |
mdbooth | mriedem: Thanks, will do. | 13:43 |
bauwser | mriedem: today is my last day for 2017, how can I help for today ? | 13:43 |
*** heyongli has quit IRC | 13:43 | |
*** heyongli has joined #openstack-nova | 13:44 | |
bauwser | mriedem: I worked most of the time off IRC because *VGPU, but in case you need stable reviews or anything else | 13:44 |
*** links has quit IRC | 13:45 | |
mriedem | bauwser: we have these ocata and newton backports yet https://review.openstack.org/#/q/I214a44f0eee7d90be5cd89f32f6e0017b19a3fd6 | 13:45 |
bauwser | ah right, I saw the email | 13:46 |
bauwser | mriedem: thanks for helping on that bug, btw. | 13:46 |
*** jpena|lunch is now known as jpena | 13:46 | |
mriedem | bauwser: and these https://review.openstack.org/#/q/I0b3ec6bb098ca32ffd32a61d4f9dcf426c3faf46 | 13:46 |
mriedem | this is my last day for 2017 also | 13:46 |
*** dtantsur|afk is now known as dtantsur | 13:47 | |
*** kumarmn has joined #openstack-nova | 13:47 | |
finucannot | bauwser: Polite reminder to take a second look at https://review.openstack.org/#/q/topic:bp/share-pci-between-numa-nodes+status:open too, please :) | 13:49 |
bauwser | mriedem: also, note I'll be off until Jan 8th | 13:49 |
finucannot | I'm hoping leakypipes will come around on the middle one. I'm almost certain I'm correct in what I'm saying | 13:49 |
* finucannot is around Wed-Fri of next week, fwiw | 13:50 | |
* bauwser trying to give more visibility on his agenda :) | 13:50 | |
bauwser | finucannot: I did, and I saw you answered to leakypipes | 13:50 |
bauwser | I need a bit more time to think about the concern | 13:50 |
leakypipes | finucannot: currently trying to diagnose https://bugs.launchpad.net/nova/+bug/1739517 | 13:50 |
openstack | Launchpad bug 1739517 in OpenStack Compute (nova) "TestNovaMigrationsMySQL randomly fails with "sqlalchemy.exc.ResourceClosedError: This result object does not return rows. It has been closed automatically."" [High,Confirmed] | 13:50 |
*** lucas-hungry is now known as lucasagomes | 13:51 | |
finucannot | Oh, that beauty | 13:51 |
figleaf | leakypipes: it would have been cheaper to fly me to FLA and install your dishwasher for you | 13:51 |
leakypipes | figleaf: yeah, no shit.. | 13:51 |
*** mlavalle has joined #openstack-nova | 13:51 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Document testing guide for new API contributions https://review.openstack.org/529618 | 13:52 |
* mriedem goes to fight with a 6 year old about getting out of bed | 13:53 | |
*** sridharg has quit IRC | 13:53 | |
*** heyongli has quit IRC | 13:54 | |
*** heyongli has joined #openstack-nova | 13:54 | |
bauwser | mriedem: tell him some children in the world are still awake for already like 9 hours and that's his time | 13:55 |
mriedem | i just run in screaming that the house is on fire and we have to get out | 13:56 |
bauwser | looks like it's an universal NP-problem then | 13:58 |
*** takedakn has quit IRC | 13:59 | |
openstackgerrit | Ryota MIBU proposed openstack/nova master: vif: look up 'ovs_interfaceid' in vif_details https://review.openstack.org/529831 | 14:00 |
bauwser | finucannot: leakypipes: remember me, what happens if we want to add a new item for an o.vo Enum field type, do we need to bump the object version using that field type ? | 14:02 |
bauwser | finucannot: leakypipes: context being https://review.openstack.org/#/c/527470/4/nova/objects/instance_pci_requests.py | 14:02 |
finucannot | bauwser: You mean if we change 'numa_policy' at a future date? | 14:02 |
bauwser | if we change the Enum field type, yes | 14:03 |
bauwser | not the field itself | 14:03 |
bauwser | like, removing the 'legacy' choice from the enum | 14:03 |
bauwser | (because I guess that's the direction we want) | 14:03 |
*** heyongli has quit IRC | 14:04 | |
*** heyongli has joined #openstack-nova | 14:04 | |
*** lyan has joined #openstack-nova | 14:09 | |
Roamer` | hm, no response in #openstack, so let me butt in here :) Does anybody know of a tool that reads devstacklog.txt, splits it into phases, and lets me know how long each phase took? Trying to figure out why my latest stack.sh runs take about twice as long as before | 14:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Use volume shared_targets to lock during attach/detach https://review.openstack.org/529695 | 14:12 |
finucannot | bauwser: tbh, I've no idea. We haven't done that yet (that I know of), so it depends | 14:12 |
Roamer` | of course it would be trivial to write such a tool once I know what phases there are, but I haven't looked so deeply into stack.sh yet... has anybody else? | 14:13 |
mriedem | Roamer`: i'd ask in #openstack-qa | 14:13 |
Roamer` | mriedem, thanks, that might work | 14:13 |
*** stvnoyes has joined #openstack-nova | 14:13 | |
mriedem | sdague is the person to ask but he's out for the year, so maybe mtreinish | 14:13 |
leakypipes | finucannot: we've done that with the ResourceClassField enum. | 14:13 |
bauwser | finucannot: I guess the problem is more about removing the legacy option | 14:13 |
leakypipes | finucannot: and I don't believe we've incremented the version for objects that use it... | 14:13 |
bauwser | say we could just deprecate that option, that's it | 14:14 |
leakypipes | finucannot: then again, we don't use objects over RPC for placement.. | 14:14 |
*** heyongli has quit IRC | 14:14 | |
bauwser | leakypipes: well, the ResourceClassFieldType is specific because indeed we don't pass it thru RPC | 14:14 |
*** heyongli has joined #openstack-nova | 14:14 | |
bauwser | we just use o.vo to have a coercing | 14:15 |
bauwser | finucannot: leakypipes: FWIW, I just +W'd that change because I think it's not a problem | 14:17 |
*** jobewan has joined #openstack-nova | 14:18 | |
cdent | leakypipes: have you seen this and the associated bug: https://review.openstack.org/#/c/529397/ | 14:21 |
cdent | there was a lot of associated irc discussion about other options, but that was the simplest | 14:21 |
cdent | wanted to be sure you saw it before I leave to do some dreaded shopping | 14:21 |
*** cdent has quit IRC | 14:24 | |
*** heyongli has quit IRC | 14:24 | |
*** heyongli has joined #openstack-nova | 14:25 | |
leakypipes | finucannot: it's not that I don't like your code. I'm just having a hard time with the whole cascading policy loop thing... I agree with you that pools != filtered_pools and that my original complaint about coupling is not valid. however it still feels a bit clever for my taste. I'll remove my -1 and leave it to bauzas and gibi to +W | 14:25 |
*** ygl has quit IRC | 14:25 | |
*** yangyapeng has joined #openstack-nova | 14:25 | |
*** yangyapeng has quit IRC | 14:26 | |
*** yangyapeng has joined #openstack-nova | 14:26 | |
*** smatzek has quit IRC | 14:29 | |
*** smatzek has joined #openstack-nova | 14:30 | |
*** smatzek has quit IRC | 14:30 | |
leakypipes | mriedem: morning. | 14:33 |
*** heyongli has quit IRC | 14:35 | |
*** heyongli has joined #openstack-nova | 14:35 | |
openstackgerrit | Matthew Booth proposed openstack/nova master: Add uuid column to BlockDeviceMapping https://review.openstack.org/242602 | 14:39 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Make BlockDeviceMapping object support uuid https://review.openstack.org/242603 | 14:39 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Add an online migration for BDM.uuid https://review.openstack.org/525599 | 14:39 |
openstackgerrit | Matthew Booth proposed openstack/nova master: DriverBlockDevice: make subclasses inherit _proxy_as_attr https://review.openstack.org/524167 | 14:39 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Expose BDM uuid to drivers https://review.openstack.org/529037 | 14:39 |
*** kholkina has quit IRC | 14:41 | |
mdbooth | mriedem: Updated ^^^ I haven't completely re-run all tests locally, though. Just the obvious ones. Been bitten by that a couple of times recently, but I'm being optimistic anyway. | 14:42 |
*** heyongli has quit IRC | 14:45 | |
*** heyongli has joined #openstack-nova | 14:45 | |
*** fragatina has quit IRC | 14:45 | |
*** fragatina has joined #openstack-nova | 14:46 | |
*** heyongli has quit IRC | 14:55 | |
*** heyongli has joined #openstack-nova | 14:55 | |
*** edmondsw has joined #openstack-nova | 14:56 | |
*** edmondsw has quit IRC | 14:57 | |
*** sridharg has joined #openstack-nova | 14:59 | |
*** smatzek has joined #openstack-nova | 15:00 | |
cfriesen | what do we expect to happen if you do a resize/migrate, and after completion but before confirmation the dest node dies and we do an evacuate? Should the resize/migrate revert, should the evacuation pass without error, or something else? | 15:01 |
*** bjolo has joined #openstack-nova | 15:05 | |
*** heyongli has quit IRC | 15:05 | |
*** heyongli has joined #openstack-nova | 15:06 | |
*** Jack_Iv has quit IRC | 15:08 | |
*** burt has joined #openstack-nova | 15:12 | |
*** heyongli has quit IRC | 15:16 | |
*** heyongli has joined #openstack-nova | 15:16 | |
*** marst has joined #openstack-nova | 15:17 | |
*** armax has joined #openstack-nova | 15:18 | |
*** tbachman has joined #openstack-nova | 15:19 | |
*** sambetts|afk is now known as sambetts | 15:20 | |
*** mriedem has quit IRC | 15:21 | |
finucannot | leakypipes: Let me take a second shot at it. If it's too clever for you, it's going to be too clever for others too | 15:23 |
leakypipes | finucannot: maybe. I'm pretty dumb, though. | 15:23 |
*** kumarmn has quit IRC | 15:23 | |
finucannot | Ah, so am I. All the more reason | 15:23 |
finucannot | leakypipes: I assume you're gone next week? | 15:23 |
leakypipes | finucannot: nope, I'm working all next week. I got no vacation this year when i joined Verizon... | 15:24 |
finucannot | Ouch :( | 15:24 |
* finucannot volunteered to work so he wouldn't have to spend a whole week at home :D | 15:25 | |
finucannot | four days is _more_ than enough for all involved | 15:25 |
leakypipes | heh | 15:25 |
*** heyongli has quit IRC | 15:26 | |
finucannot | I had a look at that bug you mentioned too. Totally out of my area of expertise, I'm afraid, so best of luck with that, heh | 15:26 |
*** heyongli has joined #openstack-nova | 15:26 | |
leakypipes | finucannot: yeah, it's a weird one alright... | 15:27 |
finucannot | and intermittent too. The worst kind of bug :( | 15:28 |
*** kumarmn has joined #openstack-nova | 15:30 | |
*** itlinux has joined #openstack-nova | 15:36 | |
*** heyongli has quit IRC | 15:36 | |
*** heyongli has joined #openstack-nova | 15:36 | |
*** mriedem has joined #openstack-nova | 15:38 | |
mriedem | cfriesen: you can't evacuate an instance in VERIFY_RESIZE state can you? | 15:38 |
mriedem | leakypipes: hi | 15:38 |
mriedem | leakypipes: did your xmas dinner party turn out ok? | 15:38 |
mriedem | cfriesen: @check_instance_state(vm_state=[vm_states.ACTIVE, vm_states.STOPPED, | 15:39 |
mriedem | vm_states.ERROR]) | 15:39 |
mriedem | def evacuate(self, context, instance, host, on_shared_storage, | 15:39 |
mriedem | cfriesen: you'd likely want to revert the resize to get the instance back to the source host | 15:39 |
mriedem | mdbooth: +2 on https://review.openstack.org/#/c/242602/ | 15:41 |
mriedem | despite that terrible blank space | 15:41 |
mdbooth | mriedem: Thank you, Sir! | 15:42 |
*** tbachman has quit IRC | 15:42 | |
mdbooth | Hah! I do that when I want to comment branches separately. Hadn't really thought about it too hard, tbh. | 15:43 |
mdbooth | I guess the comments can also live inside the block | 15:43 |
mdbooth | artom: So, that concurrency test | 15:46 |
mriedem | efried_cya_jan: how does one recheck the powervm CI? it's not on the wiki https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI | 15:46 |
artom | mdbooth, right | 15:46 |
*** heyongli has quit IRC | 15:46 | |
*** heyongli has joined #openstack-nova | 15:47 | |
mriedem | "recheck powervm" i guess | 15:47 |
mdbooth | It sounded like I hadn't convinced you, yet. I could be persuaded to simplify it, but I'm still thinking about that. | 15:47 |
artom | mdbooth, so, I grok the Python threads stuff - they don't run concurrently, one will run when another yields to do IO or whatever | 15:47 |
artom | mdbooth, it's not so much convincing, as explaining :) | 15:48 |
artom | mdbooth, what's not clear to me, and it may be ignorance of Python's internals on my part, is how your code makes sure there are two threads | 15:48 |
mdbooth | artom: Well your point is around whether the complexity is worth it, right? | 15:48 |
mdbooth | I'm confident it's a valid test. I could be persuaded that a simpler test might be better, though. | 15:48 |
mdbooth | There aren't 2 threads. | 15:49 |
mdbooth | There's only 1 thread, but it acts like 2 threads. | 15:49 |
mdbooth | We use mock to intercept a function call in the 'main' thread. | 15:49 |
mdbooth | When the main thread executes that function call, we interrupt it and do something else first, before continuing. | 15:50 |
*** damien_r has quit IRC | 15:50 | |
mdbooth | Does that make more sense? | 15:50 |
mriedem | seems pretty paranoid for something that we've already established a pattern of in several other objects | 15:50 |
mriedem | or are you actually seeing this race happening with something like the cellsv1 job? | 15:51 |
artom | mdbooth, let me look at the code again | 15:51 |
artom | I still can't wrap my head around how purely sequential execution can test a race | 15:51 |
mdbooth | mriedem: It's more that I can see the bug and I fixed it, and it's not *that* complicated. | 15:51 |
mdbooth | mriedem: artom is trying to get his head round the test, and I've never yet managed to write a unit test for a race which was easy to read. | 15:52 |
artom | If it's just about calling _create_uuid twice, surely can do that without the whole flip/race thing | 15:52 |
mdbooth | artom: That's where I could be persuaded. Except that my test is 1 step up from that. | 15:53 |
mdbooth | My test asserts that if the race happens whilst reading the bdm object, it will work fine. | 15:54 |
mdbooth | Your test would be much simpler, and we could possibly agree it's sufficient. | 15:54 |
artom | But... the race can only happen when writing | 15:54 |
artom | I guess if you go up one stop from that, it two reads happen at the same time on the same uuid-less BDM, both will attempt to write a UUID | 15:54 |
artom | *if two | 15:54 |
mdbooth | No, this is weird. If we *read* a bdm object with no uuid we create one before returning it. | 15:55 |
mdbooth | So it's a read operation, but we might have to migrate a legacy object during it. | 15:55 |
artom | Right, but the actual race is the writing part | 15:55 |
mdbooth | Yes | 15:55 |
artom | That's what the code, does, right? Read, if there's no UUID, create one and save it, then return | 15:56 |
mdbooth | My test is at the level of the read operation | 15:56 |
mdbooth | Your test would just be on the write bit | 15:56 |
*** gouthamr has joined #openstack-nova | 15:56 | |
*** tojuvone has quit IRC | 15:56 | |
mdbooth | artom: Yep. Notice there's a compare-and-swap in there, which avoids a race. | 15:56 |
*** tojuvone has joined #openstack-nova | 15:56 | |
*** heyongli has quit IRC | 15:57 | |
mdbooth | I guess the most important thing is to test the compare-and-swap, which simply executing _create_uuid manually twice would do. | 15:57 |
*** heyongli has joined #openstack-nova | 15:57 | |
mdbooth | The test would also be easier to read. | 15:57 |
artom | Ah, right, compare and swap is atomic at the DB level, right? | 15:57 |
mdbooth | Yes | 15:57 |
mdbooth | There are a couple of db-related hoops in that function which ensure it's atomic. | 15:58 |
*** suresh12 has joined #openstack-nova | 15:58 | |
openstackgerrit | Merged openstack/nova stable/ocata: Use instance.project_id when creating request specs for old instances https://review.openstack.org/529387 | 15:58 |
artom | So if there are two of more getting compare_and_swaps getting to the DB at the same time, only the first one will succeed | 15:58 |
artom | So, the DB-write race is handled for us | 15:58 |
artom | I may have been thinking about this wrong | 15:58 |
mdbooth | Correct. | 15:58 |
artom | So is there actually a race then? If we try a compare_and_swap and it fails, if we read after that, we're guaranteed to get the correct UUID | 15:59 |
artom | A read race, I should say | 15:59 |
mdbooth | There is no read race. | 15:59 |
mdbooth | Not in this patch, anyway. | 15:59 |
artom | ... | 16:00 |
artom | So what are we testing then? | 16:00 |
mdbooth | However, I think the original one just wrote the uuid to the db. | 16:00 |
mdbooth | That is a race, and if you executed my test against that version, it would fail. | 16:00 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Add PCI NUMA policies https://review.openstack.org/527472 | 16:00 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Modify signature of _filter_non_requested_pfs https://review.openstack.org/527473 | 16:00 |
*** tbachman has joined #openstack-nova | 16:01 | |
finucannot | leakypipes, bauwser: Voilà ^^ | 16:01 |
mdbooth | In fact, I think the original version didn't write it immediately at all, just generated it. | 16:01 |
leakypipes | mriedem: yeah, dinner was great. dishwasher is leaking, though... | 16:01 |
mdbooth | So there was a delay of unknown size between generation of the value and writing it to the db without a compare-and-swap. | 16:01 |
mriedem | leakypipes: "dishwasher" isn't code for one of the pugs is it? | 16:01 |
leakypipes | mriedem: so after $400 electrician bill I now have another $200 bill for the installers from Lowe's to come day after christmas to fix it. | 16:01 |
finucannot | leakypipes: I assume the irony of that has already been pointed out multiple times | 16:01 |
leakypipes | finucannot: yes sir. | 16:01 |
leakypipes | mriedem: no. | 16:02 |
artom | mdbooth, oh, so you're not testing that your code in the latest patchset handles a race properly | 16:02 |
mdbooth | artom: Yes. | 16:02 |
mdbooth | Erm... | 16:02 |
artom | Yes you're not? | 16:02 |
mriedem | leakypipes: oh lowes installers huh? i had to have lowes guys come back to fix our washing machine install which sprayed water all over the (thankfully unfinished) storage room in our basement | 16:02 |
mdbooth | No, that's exactly what I'm testing. | 16:02 |
mriedem | turns out zip ties are important for the drain hose | 16:02 |
artom | But you said there's no race in this patch | 16:02 |
mdbooth | The test asserts that the code correctly handles the situation where 2 threads both read a NULL uuid from the db, and both then try to populate it. | 16:03 |
mdbooth | The test passes. | 16:03 |
mdbooth | That doesn't mean there's no reason for the test, though. | 16:03 |
mdbooth | As it happens, the code will also work if the race happens during the db transaction, or on commit because both transactions occurred on different masters of a multi-master galera cluster. | 16:04 |
artom | SO I guess step one would be to remove all mentions of race from that test | 16:05 |
mdbooth | I didn't write tests for those, though, because.... | 16:05 |
mdbooth | I would only understand them very briefly myself. | 16:05 |
mdbooth | artom: No, because it's a race ;) | 16:05 |
mdbooth | It simulates a race | 16:05 |
* finucannot disappears for 20 minutes to catch a bus | 16:05 | |
mdbooth | It simulates 2 threads with 1 thread. | 16:06 |
artom | I'm going to look up the definition of race, I swear to God ;) | 16:06 |
mdbooth | A race is a bug caused by execution timing. | 16:06 |
mdbooth | It doesn't require real concurrency. | 16:07 |
*** heyongli has quit IRC | 16:07 | |
artom | Right, when the outcome is determined by the order in which things are executed | 16:07 |
*** heyongli has joined #openstack-nova | 16:07 | |
artom | The code is written so as to *not have that* | 16:07 |
*** fragatina has quit IRC | 16:08 | |
artom | Because 1. compare_and_swap 2. if it fails, we handle it gracefully and read the correct value | 16:08 |
mdbooth | Yes, although order may be A->B, B->A, or A(a bit)->B(all of it)->A(the rest) | 16:08 |
*** fragatina has joined #openstack-nova | 16:08 | |
figleaf | mriedem: not zip ties. Use these: https://images-na.ssl-images-amazon.com/images/I/71%2BzOxf-hBL._SX425_.jpg | 16:08 |
artom | So given two reads A and B, we need a test that makes sure that, regardless of the sequence in which they're (partially) executed, the UUID read at the end is the same for both | 16:09 |
mdbooth | However, I could be convinced to test only the simpler consecutives calls to _create_uuid() | 16:09 |
mdbooth | With a note that this simulates a race in the calling code, as this will only ever happen if there was a race. | 16:09 |
mdbooth | Rather than creating the race itself with fancy mocks. | 16:10 |
mriedem | figleaf: i used this https://s7d1.scene7.com/is/image/BedBathandBeyond/45894242895794p?$478$ to call lowes and tell them to get their guys out to fix the shit | 16:10 |
mriedem | ooo btw, where is my xmas list? | 16:10 |
mriedem | https://www.saksfifthavenue.com/main/ProductDetail.jsp?PRODUCT%3C%3Eprd_id=845524447125273&site_refer=CSE_GGLPRADS001&gclid=Cj0KCQiA9_LRBRDZARIsAAcLXjfz8bCutBnNrpZ-bKlG_1RRPKyVGX4G1WC1vjzOtoO6K81rPpJXYrgaAuXkEALw_wcB&gclsrc=aw.ds | 16:10 |
mdbooth | artom: Think of it like this. We've got code that does: if uuid is not populated: populate_uuid() | 16:11 |
mriedem | if i were a corporation with some sweet tax cuts i could buy that phone | 16:11 |
mriedem | oh it's not an actual phone | 16:11 |
mriedem | it's a makeup thingy | 16:11 |
mdbooth | artom: We're simulating the case where the above code is interrupted mid flow, so by the time populate_uuid is called, it's actually already populated. | 16:11 |
mdbooth | Even though we just checked that it wasn't. | 16:11 |
artom | mdbooth, ok, point me to the "interrupted mid flow" bit - how does it happen in the test? | 16:12 |
*** itlinux has quit IRC | 16:12 | |
*** tbachman has quit IRC | 16:13 | |
mdbooth | artom: The first time we call _create_uuid() (populate_uuid in my example above), we interrupt the flow by calling race(). race() reads the bdm itself, which populates the uuid, then continues execution of the main thread by calling orig_create_uuid(). | 16:14 |
mdbooth | So we have a main thread of execution, which is interrupted by another thread of execution. | 16:15 |
*** armax has quit IRC | 16:16 | |
mdbooth | artom: You have absolutely convinced me to simplify that test ;) | 16:17 |
artom | mdbooth, I really am just trying to understand, honest :) | 16:17 |
mdbooth | The most important aspect of it was to test that the compare-and-swap works. I can do that without the mocking. | 16:17 |
*** heyongli has quit IRC | 16:17 | |
*** heyongli has joined #openstack-nova | 16:17 | |
artom | mdbooth, think of it as teaching me :) | 16:17 |
*** Jack_Iv has joined #openstack-nova | 16:18 | |
*** fragatina has quit IRC | 16:18 | |
figleaf | mriedem: you can't remove a zip tie without cutting it (and usually the hose) | 16:19 |
artom | mdbooth, a mock side_effect... | 16:20 |
artom | Maybe that's the part I'm not getting | 16:20 |
artom | Does it still call the original function? | 16:20 |
artom | And call the side_effect before/after/at the same time? | 16:20 |
mdbooth | It calls the side effect both times | 16:20 |
mdbooth | That's why flip is required | 16:20 |
artom | mdbooth, no, in general I mean | 16:20 |
mdbooth | flip makes it call the race first time only | 16:21 |
mdbooth | That prevents infinite recursion by the race functino | 16:21 |
artom | Like, if I mock foo() and mock.side_effect = bar, and I call foo(), does the real foo() still get called, or only bar()? | 16:21 |
mdbooth | No, only the side effect is called | 16:21 |
mdbooth | It's a bad name | 16:21 |
mriedem | figleaf: found a problem in our devstack setup for the alternate hosts stuff :) | 16:21 |
artom | mdbooth, So it's effectively replacing the mocked object | 16:21 |
figleaf | oh joy! | 16:21 |
mdbooth | It's replacing the mocked function in this case | 16:22 |
mdbooth | That's why we explicitly store a reference to the original | 16:22 |
artom | mdbooth, gotcha. Back to looking at the code | 16:22 |
mdbooth | So we can still call it. | 16:22 |
mdbooth | artom: I'm really going to simplify it. | 16:22 |
mdbooth | I no longer think it's worth it myself ;) | 16:22 |
artom | mdbooth, sure, but I still want to understand this | 16:22 |
mriedem | figleaf: pretty simple | 16:22 |
mriedem | http://logs.openstack.org/89/527289/1/check/ironic-tempest-dsvm-ipa-wholedisk-agent_ipmitool-tinyipa-multinode/570a3c9/logs/screen-n-cond-cell1.txt.gz#_Dec_21_23_49_28_813934 | 16:22 |
*** Jack_Iv has quit IRC | 16:23 | |
mriedem | figleaf: the ironic job failed the first node and was rescheduling, but the cell conductor couldn't talk to placement b/c placement isn't configured in nova_cell1.conf in devstack | 16:23 |
artom | mdbooth, I shall wear your down with the stubbornness of my ignorance ;) | 16:23 |
mriedem | figleaf: working on a devstack patch | 16:23 |
figleaf | mriedem: yeah, that would hose things | 16:24 |
*** derekh has quit IRC | 16:25 | |
*** heyongli has quit IRC | 16:27 | |
artom | mdbooth, maybe it'd be easier if you point out the error in http://paste.openstack.org/show/629605/ ? | 16:27 |
*** heyongli has joined #openstack-nova | 16:28 | |
mdbooth | artom: The error is that the invocations of get_by_instance_uuid overlap | 16:29 |
mdbooth | The one top left goes all the way to top right | 16:29 |
mdbooth | There's another invocation of get_by_instance_uuid in the middle of it | 16:30 |
mdbooth | IOW, they are executing 'concurrently' | 16:30 |
artom | Heh, maybe discussing ASCII art pseudo sequence diagrams on IRC wasn't the best idea | 16:31 |
artom | A debugger then... | 16:31 |
artom | Confessions: I have never used a Python debugger | 16:32 |
mdbooth | So we've got a big call to get_by_instance_uuid() | 16:32 |
mdbooth | We stick a mock somewhere in the middle of it which interrupts the flow to call get_by_instance_uuid() again, before continuing with the original call, which still hasn't finished. | 16:32 |
artom | So far so good. | 16:34 |
*** heyongli has quit IRC | 16:38 | |
*** heyongli has joined #openstack-nova | 16:38 | |
*** AlexeyAbashkin has quit IRC | 16:39 | |
openstackgerrit | Merged openstack/nova master: objects: Add PCI NUMA policy fields https://review.openstack.org/527470 | 16:40 |
mriedem | figleaf: i think this should do the trick https://review.openstack.org/529857 | 16:42 |
*** sambetts is now known as sambetts|afk | 16:42 | |
*** Apoorva has joined #openstack-nova | 16:44 | |
artom | mdbooth, is that all we're testing? That if one get_by_uuid starts up, but while it's running another get_by_uuid is called, they're get the same value in the end? | 16:47 |
mdbooth | artom: Yep | 16:47 |
artom | mdbooth, christ | 16:47 |
artom | mdbooth, ok no, please get rid of it :) | 16:47 |
openstackgerrit | Merged openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358 | 16:47 |
mriedem | woot ^ | 16:47 |
mriedem | #success nova merged alternate hosts support for server build | 16:48 |
openstackstatus | mriedem: Added success to Success page | 16:48 |
artom | mdbooth, I'd see the point if we let them both run to completion in different processes | 16:48 |
*** heyongli has quit IRC | 16:48 | |
artom | mdbooth, but in the end, all your test does it call _create_uuid twice in successions | 16:48 |
mdbooth | artom: They do both run to completion! | 16:48 |
mdbooth | In effectively different processes. | 16:48 |
*** heyongli has joined #openstack-nova | 16:48 | |
artom | ... | 16:48 |
*** bpoulos has joined #openstack-nova | 16:48 | |
artom | mdbooth, but when the second one is called via the mock, the first's flow is interreupted | 16:49 |
artom | Until the second one returns | 16:49 |
artom | No? | 16:49 |
mdbooth | By mocking _create_uuid specifically, it triggers an execution order which causes a race | 16:49 |
figleaf | mriedem: It's a xmas miracle! | 16:49 |
openstackgerrit | Merged openstack/nova master: doc: update supported drivers for cpu topology https://review.openstack.org/529294 | 16:49 |
*** chyka has joined #openstack-nova | 16:49 | |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Add support for the 2.57 microversion https://review.openstack.org/528128 | 16:49 |
mdbooth | artom: Yes. That's an execution order which would cause incorrect behaviour if we didn't handle it. | 16:50 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Make BlockDeviceMapping object support uuid https://review.openstack.org/242603 | 16:50 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Add an online migration for BDM.uuid https://review.openstack.org/525599 | 16:50 |
openstackgerrit | Matthew Booth proposed openstack/nova master: DriverBlockDevice: make subclasses inherit _proxy_as_attr https://review.openstack.org/524167 | 16:50 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Expose BDM uuid to drivers https://review.openstack.org/529037 | 16:50 |
mdbooth | artom: However, it's gone ^^^ ;) | 16:50 |
artom | mdbooth, dammit | 16:50 |
artom | mdbooth, I still want to understand you | 16:51 |
mdbooth | artom: It's a good test, but a totally agree that it's more complicated that it needs to be | 16:51 |
mdbooth | Anyway, I'm going to run for the hills! | 16:52 |
mdbooth | Merry Christmas, all! See you in the New Year. | 16:52 |
* mdbooth -> hills | 16:52 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: create vGPU for instance https://review.openstack.org/528832 | 16:55 |
artom | mdbooth, enjoy your ugly sweaters ;) | 16:57 |
*** heyongli has quit IRC | 16:58 | |
*** heyongli has joined #openstack-nova | 16:58 | |
*** itlinux has joined #openstack-nova | 17:00 | |
*** dtantsur is now known as dtantsur|afk | 17:02 | |
*** itlinux has quit IRC | 17:05 | |
*** itlinux has joined #openstack-nova | 17:05 | |
*** sahid has quit IRC | 17:05 | |
*** sahid has joined #openstack-nova | 17:06 | |
*** heyongli has quit IRC | 17:08 | |
*** heyongli has joined #openstack-nova | 17:09 | |
*** imacdonn has quit IRC | 17:12 | |
*** imacdonn has joined #openstack-nova | 17:12 | |
mriedem | figleaf: heh my bash fu always fails the first few times | 17:12 |
*** yamamoto has quit IRC | 17:13 | |
*** trinaths has joined #openstack-nova | 17:14 | |
*** trinaths has left #openstack-nova | 17:14 | |
figleaf | mriedem: don't feel bad - I felt uneasy +1'ing that because my bash-fu is so weak | 17:14 |
figleaf | it looked logical, thougn | 17:14 |
figleaf | though | 17:14 |
mriedem | it does do the correct thing for nova_cell1.conf | 17:15 |
mriedem | so that's good | 17:15 |
*** heyongli has quit IRC | 17:19 | |
mriedem | someone was mentioning issues with the NumInstances filter yesterday, and i got thinking about that one, if you ran multiple filter scheduler processes, that filter would be totally racey | 17:19 |
*** heyongli has joined #openstack-nova | 17:19 | |
mriedem | depending on which process gets a request, or if both are processing requests at the same time for the same host | 17:19 |
*** yamamoto has joined #openstack-nova | 17:20 | |
mriedem | if the limit is 10 and you've got 9 on a host already, and both workers get a request at the same time, they'd both think there is room for one more and could choose it | 17:20 |
mriedem | placement doesn't fix that | 17:20 |
mriedem | only reschedules would fix that | 17:20 |
mriedem | seems like a totally useless filter anyway assuming you have any non-trivial number of flavors | 17:21 |
kashyap | mriedem: Hey, when you have a moment, you know why this is failing? (I know it's coming from my change) -- http://logs.openstack.org/11/529611/3/check/openstack-tox-py27/f611b46/job-output.txt.gz#_2017-12-21_17_29_32_011876 | 17:21 |
kashyap | ( https://review.openstack.org/#/c/529611/ ) | 17:21 |
kashyap | It's just doing something super simple; adding a config class & test that XML element | 17:22 |
kashyap | Ah, I see it | 17:22 |
kashyap | My test is trying to do it as: | 17:22 |
kashyap | 2017-12-21 17:29:32.012197 | ubuntu-xenial | <smm> | 17:22 |
kashyap | 2017-12-21 17:29:32.012215 | ubuntu-xenial | <smm state="on"/> | 17:22 |
kashyap | 2017-12-21 17:29:32.012231 | ubuntu-xenial | </smm> | 17:22 |
kashyap | However, it should be: | 17:22 |
kashyap | ... | 17:23 |
kashyap | <features> | 17:23 |
kashyap | <acpi/> | 17:23 |
kashyap | <apic/> | 17:23 |
kashyap | <smm state='on'/> | 17:23 |
kashyap | </features> | 17:23 |
kashyap | ... | 17:23 |
kashyap | mriedem: Disregard me. I'll rework the tests | 17:23 |
mriedem | looks like it doesn't like <smm state="on"/> | 17:24 |
*** lucasagomes is now known as lucas-afk | 17:24 | |
mriedem | http://logs.openstack.org/11/529611/3/check/openstack-tox-py27/f611b46/job-output.txt.gz#_2017-12-21_17_29_32_012165 | 17:24 |
kashyap | mriedem: But if you see, the test is trying to do: | 17:24 |
kashyap | <smm> | 17:24 |
kashyap | <smm state="on"> | 17:24 |
kashyap | </smm> | 17:24 |
kashyap | But there's no top-level 'smm' attribute | 17:24 |
kashyap | It is _one_ of the sub elements of the 'features' attribute | 17:24 |
*** yamamoto has quit IRC | 17:25 | |
* kashyap clicks the links from Matt | 17:25 | |
*** Apoorva has quit IRC | 17:26 | |
mriedem | commented in the patch | 17:28 |
*** heyongli has quit IRC | 17:29 | |
kashyap | That's fast. /me clicks | 17:29 |
*** heyongli has joined #openstack-nova | 17:29 | |
kashyap | mriedem: Thanks. You could actually -1 it, don't be so polite. | 17:30 |
kashyap | :P | 17:30 |
mriedem | there you go | 17:31 |
kashyap | Heh, you (-)one-upped it :-) | 17:34 |
*** heyongli has quit IRC | 17:39 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Sanity check for NumInstancesFilter https://review.openstack.org/529866 | 17:39 |
*** heyongli has joined #openstack-nova | 17:39 | |
bauwser | folks, bailing out for vacations | 17:40 |
bauwser | see you in 2018 \o | 17:40 |
* bauwser back on Jan 8th | 17:40 | |
*** bauwser is now known as bauzas | 17:40 | |
*** bauzas is now known as bauzas|pto | 17:40 | |
*** mriedem is now known as bauzas | 17:40 | |
bauzas | haha | 17:40 |
bauzas | i'm back! | 17:40 |
kashyap | mriedem: Hmm, I actually modelled it just like other features, the class -- LibvirtConfigGuestFeatureAPIC() or LibvirtConfigGuestFeaturePAE() | 17:41 |
bauzas | donne moi du fromage savoureux | 17:41 |
kashyap | More appropriate one is - LibvirtConfigGuestFeatureKvmHidden(). Because it also as sub-element | 17:41 |
* kashyap looks closer | 17:41 | |
*** bauzas is now known as mriedem | 17:42 | |
kashyap | No, I'm wrong, the KvmHidden() thing has its own element. | 17:44 |
*** sridharg has quit IRC | 17:44 | |
*** sahid has quit IRC | 17:45 | |
mriedem | kashyap: more inline | 17:47 |
mriedem | for your subelement woes | 17:47 |
* kashyap goes to read | 17:47 | |
mriedem | your root element is the smm element, | 17:47 |
mriedem | you are adding a sub-element to that, which is wrong, | 17:48 |
mriedem | you need to set an attribute on the smm element | 17:48 |
mriedem | which is your root | 17:48 |
mriedem | xml is f'ing awesome | 17:48 |
kashyap | Yeah, I should model it something like LibvirtConfigGuestSMBIOS() | 17:48 |
kashyap | I know, XML... | 17:48 |
kashyap | From what I recall about why libvirt chose XML was... | 17:49 |
*** heyongli has quit IRC | 17:49 | |
kashyap | The initial author of libvirt Daniel Veillard was on W3C standards, and 'libxml' maintainer... | 17:50 |
*** heyongli has joined #openstack-nova | 17:50 | |
kashyap | Not sure JSON was there at that time yet | 17:50 |
kashyap | So now they're (we) stuck with it... | 17:50 |
mriedem | i worked on a project for 6 years dealing with https://www.oasis-open.org/committees/sdd/ | 17:51 |
mriedem | so i'm familiar | 17:51 |
* kashyap clicks | 17:51 | |
mriedem | you'd think i'd actually know something about tosca and heat and nfv stuff, but... | 17:52 |
kashyap | Wauw. Yeah, I knnow OSAIS standards; the 'virtio' documentation also is hosted there | 17:52 |
kashyap | But at the recent KVM Forum in Prague, I saw users of virtio, who want to implement devices complaining of the super dense documentation / standards. | 17:52 |
mriedem | maybe they would prefer CIM | 17:52 |
*** artom has quit IRC | 17:52 | |
kashyap | Heh | 17:52 |
* mriedem lunches | 17:53 | |
kashyap | mriedem: When you're back, I have a small future spec topic, for design discussion | 17:53 |
kashyap | If you're busy after lunch, and can't get to it; it's fine. This can wait | 17:54 |
* kashyap also needs to cook dinner | 17:54 | |
*** bpoulos has quit IRC | 17:58 | |
*** AlexeyAbashkin has joined #openstack-nova | 17:59 | |
*** heyongli has quit IRC | 18:00 | |
*** heyongli has joined #openstack-nova | 18:00 | |
*** burt has quit IRC | 18:01 | |
*** artom has joined #openstack-nova | 18:02 | |
*** AlexeyAbashkin has quit IRC | 18:03 | |
*** heyongli has quit IRC | 18:10 | |
*** heyongli has joined #openstack-nova | 18:10 | |
*** suresh12 has quit IRC | 18:15 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Introduce SMM (System Management Mode) config class https://review.openstack.org/529611 | 18:16 |
*** claudiub has quit IRC | 18:19 | |
*** heyongli has quit IRC | 18:20 | |
*** heyongli has joined #openstack-nova | 18:20 | |
*** tbachman has joined #openstack-nova | 18:23 | |
*** jpena is now known as jpena|off | 18:28 | |
*** heyongli has quit IRC | 18:30 | |
*** heyongli has joined #openstack-nova | 18:31 | |
*** jgriffith is now known as jgriffith-merryC | 18:34 | |
*** jgriffith-merryC is now known as jgriffith | 18:34 | |
*** gyee has joined #openstack-nova | 18:37 | |
f10d4 | re | 18:39 |
*** chyka has quit IRC | 18:40 | |
*** chyka has joined #openstack-nova | 18:41 | |
*** heyongli has quit IRC | 18:41 | |
openstackgerrit | Merged openstack/nova master: Add retry_on_deadlock decorator to action_event_start https://review.openstack.org/529672 | 18:41 |
*** armax has joined #openstack-nova | 18:41 | |
*** heyongli has joined #openstack-nova | 18:41 | |
*** dave-mcc_ has quit IRC | 18:41 | |
*** chyka_ has joined #openstack-nova | 18:44 | |
*** suresh12 has joined #openstack-nova | 18:46 | |
*** chyka has quit IRC | 18:46 | |
*** suresh12 has quit IRC | 18:47 | |
*** suresh12 has joined #openstack-nova | 18:48 | |
*** felipemonteiro__ has joined #openstack-nova | 18:48 | |
*** heyongli has quit IRC | 18:51 | |
*** heyongli has joined #openstack-nova | 18:51 | |
*** harlowja has joined #openstack-nova | 19:01 | |
*** heyongli has quit IRC | 19:01 | |
*** heyongli has joined #openstack-nova | 19:01 | |
*** harlowja has quit IRC | 19:04 | |
openstackgerrit | Merged openstack/nova master: Remove extensions module https://review.openstack.org/529206 | 19:09 |
openstackgerrit | Merged openstack/nova master: Remove the LoadedExtensionInfo object https://review.openstack.org/529207 | 19:09 |
*** heyongli has quit IRC | 19:11 | |
*** heyongli has joined #openstack-nova | 19:12 | |
*** suresh12 has quit IRC | 19:15 | |
*** suresh12 has joined #openstack-nova | 19:15 | |
*** gouthamr has quit IRC | 19:20 | |
*** heyongli has quit IRC | 19:22 | |
*** heyongli has joined #openstack-nova | 19:22 | |
*** yamamoto has joined #openstack-nova | 19:24 | |
*** felipemonteiro__ has quit IRC | 19:27 | |
*** chyka_ has quit IRC | 19:28 | |
*** chyka has joined #openstack-nova | 19:28 | |
*** heyongli has quit IRC | 19:32 | |
*** heyongli has joined #openstack-nova | 19:32 | |
*** armax has quit IRC | 19:32 | |
*** READ10 has joined #openstack-nova | 19:32 | |
*** AlexeyAbashkin has joined #openstack-nova | 19:33 | |
*** mgariepy has quit IRC | 19:33 | |
*** yamamoto has quit IRC | 19:35 | |
*** AlexeyAbashkin has quit IRC | 19:37 | |
*** mgariepy has joined #openstack-nova | 19:38 | |
*** dave-mccowan has joined #openstack-nova | 19:40 | |
*** gouthamr has joined #openstack-nova | 19:40 | |
*** heyongli has quit IRC | 19:42 | |
*** heyongli has joined #openstack-nova | 19:42 | |
openstackgerrit | Merged openstack/nova stable/newton: Use instance.project_id when creating request specs for old instances https://review.openstack.org/529389 | 19:48 |
*** heyongli has quit IRC | 19:52 | |
*** heyongli has joined #openstack-nova | 19:53 | |
*** salv-orlando has quit IRC | 19:54 | |
*** salv-orlando has joined #openstack-nova | 19:55 | |
*** vivsoni has quit IRC | 19:56 | |
*** salv-orlando has quit IRC | 19:59 | |
*** gouthamr has quit IRC | 20:00 | |
*** suresh12 has quit IRC | 20:02 | |
*** heyongli has quit IRC | 20:03 | |
*** suresh12 has joined #openstack-nova | 20:03 | |
*** heyongli has joined #openstack-nova | 20:03 | |
*** gaurangt has quit IRC | 20:13 | |
*** heyongli has quit IRC | 20:13 | |
*** heyongli has joined #openstack-nova | 20:13 | |
*** pcaruana has quit IRC | 20:13 | |
*** fragatina has joined #openstack-nova | 20:13 | |
*** mvk has quit IRC | 20:17 | |
*** gaurangt has joined #openstack-nova | 20:19 | |
*** fanzhang has quit IRC | 20:21 | |
*** fanzhang has joined #openstack-nova | 20:21 | |
*** heyongli has quit IRC | 20:23 | |
*** heyongli has joined #openstack-nova | 20:23 | |
*** edmondsw has joined #openstack-nova | 20:25 | |
*** fragatina has quit IRC | 20:25 | |
*** fragatina has joined #openstack-nova | 20:29 | |
*** heyongli has quit IRC | 20:33 | |
*** heyongli has joined #openstack-nova | 20:34 | |
*** suresh12 has quit IRC | 20:37 | |
*** suresh12 has joined #openstack-nova | 20:38 | |
*** heyongli has quit IRC | 20:44 | |
*** heyongli has joined #openstack-nova | 20:44 | |
*** heyongli has quit IRC | 20:54 | |
*** heyongli has joined #openstack-nova | 20:54 | |
*** salv-orlando has joined #openstack-nova | 20:55 | |
*** suresh12 has quit IRC | 20:56 | |
*** edmondsw has quit IRC | 20:58 | |
*** fragatina has quit IRC | 20:59 | |
*** salv-orlando has quit IRC | 21:00 | |
*** heyongli has quit IRC | 21:04 | |
*** heyongli has joined #openstack-nova | 21:04 | |
*** suresh12 has joined #openstack-nova | 21:10 | |
*** tbachman has quit IRC | 21:12 | |
*** tbachman has joined #openstack-nova | 21:14 | |
*** heyongli has quit IRC | 21:14 | |
*** heyongli has joined #openstack-nova | 21:15 | |
*** markvoelker has quit IRC | 21:20 | |
*** jobewan has quit IRC | 21:22 | |
*** READ10 has quit IRC | 21:22 | |
*** smatzek has quit IRC | 21:23 | |
*** smatzek has joined #openstack-nova | 21:24 | |
*** heyongli has quit IRC | 21:25 | |
*** heyongli has joined #openstack-nova | 21:25 | |
*** gyee has quit IRC | 21:25 | |
*** suresh12 has quit IRC | 21:26 | |
*** suresh12 has joined #openstack-nova | 21:28 | |
mriedem | melwitt: in https://review.openstack.org/#/c/334614/ the commit message says, "We cannot store the entire access_url in the database because it contains the token, but we can keep the base part of the url and generate the full access_url on demand." | 21:28 |
mriedem | but the spec talks quite a bit about storing a token in the db | 21:28 |
mriedem | "Because the new tokens will go in the database we need to consider cells v2." | 21:28 |
*** smatzek has quit IRC | 21:29 | |
mriedem | maybe that's in a later change, the one that adds the ConsoleConnection object and db model? | 21:31 |
*** heyongli has quit IRC | 21:35 | |
*** heyongli has joined #openstack-nova | 21:35 | |
mriedem | maybe this just means we don't store the token in the url in the db because the token would make the url too long? | 21:37 |
mriedem | or it's not hashed? | 21:37 |
*** heyongli has quit IRC | 21:45 | |
*** heyongli has joined #openstack-nova | 21:45 | |
*** salv-orlando has joined #openstack-nova | 21:50 | |
*** heyongli has quit IRC | 21:55 | |
*** heyongli has joined #openstack-nova | 21:56 | |
*** lyan has quit IRC | 22:01 | |
*** heyongli has quit IRC | 22:06 | |
*** heyongli has joined #openstack-nova | 22:06 | |
*** edmondsw has joined #openstack-nova | 22:12 | |
efried_cya_jan | mriedem It's 'powervm: recheck'. I'll send a note to esberglu to add it to the wiki | 22:12 |
mriedem | efried_cya_jan: already did | 22:13 |
mriedem | now get back to pantsless friday | 22:13 |
efried_cya_jan | mriedem As in, you sent the email? | 22:13 |
mriedem | i updated the wiki | 22:13 |
efried_cya_jan | oh, okay. Thanks :) | 22:13 |
efried_cya_jan | mriedem If you run 'recheck powervm' it'll recheck *everything*. It needs to be 'powervm:recheck' (with or without a space) to recheck just powervm. | 22:14 |
*** heyongli has quit IRC | 22:16 | |
efried_cya_jan | mriedem I updated it. | 22:16 |
*** heyongli has joined #openstack-nova | 22:16 | |
*** edmondsw has quit IRC | 22:17 | |
*** efried_cya_jan has quit IRC | 22:19 | |
*** heyongli has quit IRC | 22:26 | |
*** heyongli has joined #openstack-nova | 22:26 | |
*** tbachman has quit IRC | 22:30 | |
mriedem | melwitt: this will need a follow up https://review.openstack.org/#/c/320063/ but won't block on the stuff i mentioned in ther | 22:30 |
mriedem | *there | 22:30 |
*** suresh12 has quit IRC | 22:32 | |
*** itlinux has quit IRC | 22:35 | |
*** dave-mccowan has quit IRC | 22:35 | |
*** heyongli has quit IRC | 22:36 | |
*** heyongli has joined #openstack-nova | 22:37 | |
*** salv-orlando has quit IRC | 22:40 | |
*** stvnoyes has quit IRC | 22:40 | |
mriedem | https://review.openstack.org/#/c/325381/ -1 on that one, and that's where i stop for the year | 22:44 |
mriedem | toodle-oo | 22:44 |
*** heyongli has quit IRC | 22:47 | |
*** heyongli has joined #openstack-nova | 22:47 | |
*** figleaf is now known as edleafe | 22:48 | |
*** heyongli has quit IRC | 22:57 | |
*** heyongli has joined #openstack-nova | 22:57 | |
*** heyongli has quit IRC | 23:07 | |
*** heyongli has joined #openstack-nova | 23:07 | |
*** artom has quit IRC | 23:15 | |
*** jeblair is now known as corvus | 23:15 | |
*** heyongli has quit IRC | 23:17 | |
*** heyongli has joined #openstack-nova | 23:18 | |
*** claudiub has joined #openstack-nova | 23:21 | |
*** markvoelker has joined #openstack-nova | 23:21 | |
*** heyongli has quit IRC | 23:28 | |
*** heyongli has joined #openstack-nova | 23:28 | |
*** david_9 has quit IRC | 23:35 | |
*** carthaca_ has quit IRC | 23:35 | |
*** david_ has joined #openstack-nova | 23:35 | |
*** carthaca_ has joined #openstack-nova | 23:35 | |
*** heyongli has quit IRC | 23:38 | |
*** heyongli has joined #openstack-nova | 23:38 | |
*** salv-orlando has joined #openstack-nova | 23:41 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | 23:42 |
*** salv-orlando has quit IRC | 23:46 | |
*** suresh12 has joined #openstack-nova | 23:46 | |
*** tbachman has joined #openstack-nova | 23:47 | |
*** marst has quit IRC | 23:48 | |
*** heyongli has quit IRC | 23:48 | |
*** heyongli has joined #openstack-nova | 23:48 | |
*** suresh12 has quit IRC | 23:50 | |
*** tbachman has quit IRC | 23:51 | |
*** tbachman has joined #openstack-nova | 23:52 | |
*** markvoelker has quit IRC | 23:55 | |
*** heyongli has quit IRC | 23:58 | |
*** heyongli has joined #openstack-nova | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!