| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (2) https://review.openstack.org/531266 | 00:00 |
|---|---|---|
| *** esberglu has quit IRC | 00:04 | |
| *** yassine has joined #openstack-nova | 00:05 | |
| *** yassine is now known as Guest13421 | 00:05 | |
| *** yangyapeng has joined #openstack-nova | 00:09 | |
| *** jose-phillips has quit IRC | 00:09 | |
| *** jistr has quit IRC | 00:11 | |
| *** jaypipes has quit IRC | 00:14 | |
| *** yangyapeng has quit IRC | 00:14 | |
| *** jose-phillips has joined #openstack-nova | 00:14 | |
| *** jistr has joined #openstack-nova | 00:16 | |
| *** zhurong has joined #openstack-nova | 00:16 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Microversion 2.58 - Instance actions list pagination https://review.openstack.org/528601 | 00:17 |
| *** yangyapeng has joined #openstack-nova | 00:20 | |
| *** sdague has quit IRC | 00:22 | |
| *** xnox has quit IRC | 00:23 | |
| *** xnox has joined #openstack-nova | 00:24 | |
| *** xnox has joined #openstack-nova | 00:24 | |
| *** yangyapeng has quit IRC | 00:25 | |
| *** esberglu has joined #openstack-nova | 00:28 | |
| *** esberglu has quit IRC | 00:29 | |
| mriedem | alex_xu: takashin: important question in https://review.openstack.org/#/c/330406/78/api-ref/source/parameters.yaml@4148 | 00:29 |
| mriedem | this microversion adds a uuid field to the response for GET /os-migrations, | 00:29 |
| mriedem | i suggested we could also take this opportunity to add uuid to the response for GET /servers/{uuid}/migrations as well | 00:29 |
| mriedem | thoughts on that? | 00:29 |
| *** EmilienM has quit IRC | 00:30 | |
| *** markmcclain has quit IRC | 00:30 | |
| mriedem | comment on the review if you like, i have to make dinner | 00:30 |
| *** markmcclain has joined #openstack-nova | 00:32 | |
| *** edmondsw has joined #openstack-nova | 00:36 | |
| *** edmondsw has quit IRC | 00:41 | |
| *** jobewan has quit IRC | 00:44 | |
| *** liuzz has joined #openstack-nova | 00:44 | |
| *** chyka has quit IRC | 00:46 | |
| *** dave-mccowan has joined #openstack-nova | 00:48 | |
| *** gyee has quit IRC | 00:49 | |
| *** liangy has quit IRC | 00:56 | |
| *** jose-phillips has quit IRC | 01:00 | |
| *** jose-phillips has joined #openstack-nova | 01:03 | |
| *** markmcclain has quit IRC | 01:05 | |
| *** purplerbot has joined #openstack-nova | 01:08 | |
| *** hshiina has joined #openstack-nova | 01:09 | |
| *** markmcclain has joined #openstack-nova | 01:13 | |
| *** nicolasbock has joined #openstack-nova | 01:17 | |
| *** tuanla____ has joined #openstack-nova | 01:22 | |
| openstackgerrit | Merged openstack/nova master: Imported Translations from Zanata https://review.openstack.org/524795 | 01:29 |
| *** dansmith has joined #openstack-nova | 01:30 | |
| *** Apoorva_ has joined #openstack-nova | 01:33 | |
| *** Apoorva has quit IRC | 01:37 | |
| *** Apoorva_ has quit IRC | 01:38 | |
| *** hemna_ has quit IRC | 01:39 | |
| *** hui has joined #openstack-nova | 01:41 | |
| *** jroll has quit IRC | 01:46 | |
| *** jroll has joined #openstack-nova | 01:51 | |
| *** hieulq has quit IRC | 01:55 | |
| *** hoangcx has quit IRC | 01:55 | |
| *** hieulq has joined #openstack-nova | 01:55 | |
| *** hoangcx has joined #openstack-nova | 01:55 | |
| *** tuanla____ has quit IRC | 01:57 | |
| *** tuanla____ has joined #openstack-nova | 01:57 | |
| *** hui is now known as tianhui | 02:01 | |
| *** ljjjustin has joined #openstack-nova | 02:04 | |
| *** tuanla____ has quit IRC | 02:08 | |
| *** tuanla____ has joined #openstack-nova | 02:08 | |
| *** yangyapeng has joined #openstack-nova | 02:11 | |
| *** threestrands_ has joined #openstack-nova | 02:14 | |
| *** threestrands_ has quit IRC | 02:14 | |
| *** threestrands_ has joined #openstack-nova | 02:14 | |
| *** eharney has quit IRC | 02:16 | |
| *** threestrands has quit IRC | 02:16 | |
| *** zzzeek has quit IRC | 02:19 | |
| *** zzzeek has joined #openstack-nova | 02:20 | |
| *** namnh has joined #openstack-nova | 02:20 | |
| *** zzzeek has quit IRC | 02:20 | |
| *** zzzeek has joined #openstack-nova | 02:21 | |
| *** smatzek has joined #openstack-nova | 02:24 | |
| *** edmondsw has joined #openstack-nova | 02:24 | |
| *** edmondsw has quit IRC | 02:28 | |
| *** markmcclain has quit IRC | 02:29 | |
| *** eharney has joined #openstack-nova | 02:30 | |
| *** mriedem has quit IRC | 02:31 | |
| *** markmcclain has joined #openstack-nova | 02:34 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (3) https://review.openstack.org/531280 | 02:34 |
| *** harlowja has quit IRC | 02:36 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:36 | |
| *** smatzek has quit IRC | 02:38 | |
| *** markmcclain has quit IRC | 02:43 | |
| *** markmcclain has joined #openstack-nova | 02:45 | |
| *** Tom-Tom has joined #openstack-nova | 02:51 | |
| *** xinliang has quit IRC | 02:52 | |
| *** markmcclain has quit IRC | 02:53 | |
| *** markmcclain has joined #openstack-nova | 02:55 | |
| *** xinliang has joined #openstack-nova | 03:05 | |
| *** Dinesh_Bhor has quit IRC | 03:12 | |
| *** tetsuro has quit IRC | 03:14 | |
| *** nicolasbock has quit IRC | 03:14 | |
| *** yamamoto has joined #openstack-nova | 03:28 | |
| *** links has joined #openstack-nova | 03:29 | |
| *** Apoorva has joined #openstack-nova | 03:30 | |
| *** Dinesh_Bhor has joined #openstack-nova | 03:32 | |
| *** links has quit IRC | 03:34 | |
| *** zhurong has quit IRC | 03:34 | |
| *** eharney has quit IRC | 03:38 | |
| *** eharney has joined #openstack-nova | 03:39 | |
| *** moshele has joined #openstack-nova | 03:39 | |
| *** jobewan has joined #openstack-nova | 03:44 | |
| *** markmcclain has quit IRC | 03:45 | |
| *** markmcclain has joined #openstack-nova | 03:47 | |
| openstackgerrit | Hironori Shiina proposed openstack/nova master: virt/ironic: Implement rescue and unrescue https://review.openstack.org/416487 | 03:51 |
| *** abhishekk has joined #openstack-nova | 03:51 | |
| *** annp has joined #openstack-nova | 03:56 | |
| *** links has joined #openstack-nova | 03:56 | |
| *** liuzz has quit IRC | 04:01 | |
| *** udesale has joined #openstack-nova | 04:08 | |
| *** liuzz has joined #openstack-nova | 04:10 | |
| *** moshele has quit IRC | 04:12 | |
| *** edmondsw has joined #openstack-nova | 04:13 | |
| *** Dinesh_Bhor has quit IRC | 04:14 | |
| *** mdnadeem has joined #openstack-nova | 04:15 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:17 | |
| *** edmondsw has quit IRC | 04:17 | |
| *** jobewan has quit IRC | 04:20 | |
| *** Tom-Tom has quit IRC | 04:21 | |
| *** Tom-Tom has joined #openstack-nova | 04:22 | |
| *** Eran_Kuris has quit IRC | 04:23 | |
| *** jobewan has joined #openstack-nova | 04:23 | |
| *** Tom-Tom has quit IRC | 04:26 | |
| *** sree has joined #openstack-nova | 04:27 | |
| *** psachin has joined #openstack-nova | 04:33 | |
| *** eharney has quit IRC | 04:34 | |
| *** Eran_Kuris has joined #openstack-nova | 04:36 | |
| *** chyka has joined #openstack-nova | 04:57 | |
| *** sree_ has joined #openstack-nova | 04:59 | |
| *** sree_ is now known as Guest45790 | 04:59 | |
| *** sree has quit IRC | 05:02 | |
| *** chyka has quit IRC | 05:02 | |
| *** sridharg has joined #openstack-nova | 05:03 | |
| *** dave-mccowan has quit IRC | 05:06 | |
| *** liuzz has quit IRC | 05:10 | |
| *** markmcclain has quit IRC | 05:12 | |
| *** markmcclain has joined #openstack-nova | 05:15 | |
| *** ratailor has joined #openstack-nova | 05:17 | |
| *** janki has joined #openstack-nova | 05:24 | |
| *** liuzz has joined #openstack-nova | 05:24 | |
| *** Tom-Tom has joined #openstack-nova | 05:34 | |
| *** jobewan has quit IRC | 05:35 | |
| *** hongbin has joined #openstack-nova | 05:37 | |
| *** Tom-Tom has quit IRC | 05:38 | |
| *** Tom-Tom has joined #openstack-nova | 05:39 | |
| *** Brin has joined #openstack-nova | 05:45 | |
| openstackgerrit | Andreas Jaeger proposed openstack/os-vif master: zuul: Enable functional tests in gate https://review.openstack.org/530961 | 05:46 |
| *** Dinesh_Bhor has quit IRC | 05:49 | |
| *** Apoorva has quit IRC | 05:55 | |
| *** Dinesh_Bhor has joined #openstack-nova | 06:03 | |
| *** Dinesh_Bhor has quit IRC | 06:04 | |
| *** liuzz has quit IRC | 06:07 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in get https://review.openstack.org/531299 | 06:10 |
| *** threestrands_ has quit IRC | 06:13 | |
| *** tetsuro_ has joined #openstack-nova | 06:44 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove a duplicate line in a unit test https://review.openstack.org/531317 | 06:53 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Fix 500 in test_resize_server_negative_invalid_state https://review.openstack.org/531117 | 07:04 |
| *** claudiub has joined #openstack-nova | 07:14 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Fix 500 in test_resize_server_negative_invalid_state https://review.openstack.org/531117 | 07:24 |
| *** armax has quit IRC | 07:29 | |
| *** Dinesh_Bhor has joined #openstack-nova | 07:32 | |
| *** zer0c00l has quit IRC | 07:35 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add ComputeNode.virt_type field https://review.openstack.org/531327 | 07:37 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Use virt_type in /os-hypervisors/details API https://review.openstack.org/531328 | 07:37 |
| openstackgerrit | Chen Hanxiao proposed openstack/nova master: conf: hyperv: fix a comment typo https://review.openstack.org/531329 | 07:37 |
| *** zer0c00l has joined #openstack-nova | 07:41 | |
| *** Dinesh_Bhor has quit IRC | 07:47 | |
| *** zer0c00l has quit IRC | 07:48 | |
| *** zhurong has joined #openstack-nova | 07:48 | |
| openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: libvirt: use 'host-passthrough' as default on AArch64 https://review.openstack.org/530965 | 07:48 |
| hrw | stephenfin: added test for ^^ - can you take a look? | 07:49 |
| *** edmondsw has joined #openstack-nova | 07:49 | |
| *** zer0c00l has joined #openstack-nova | 07:50 | |
| *** Dinesh_Bhor has joined #openstack-nova | 07:52 | |
| *** edmondsw has quit IRC | 07:53 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add index(instance_uuid, updated_at) on instance_actions table https://review.openstack.org/530429 | 08:09 |
| *** markvoelker has joined #openstack-nova | 08:09 | |
| *** fragatina has joined #openstack-nova | 08:09 | |
| *** migi has quit IRC | 08:11 | |
| *** tesseract has joined #openstack-nova | 08:12 | |
| *** fragatina has quit IRC | 08:12 | |
| *** fragatina has joined #openstack-nova | 08:13 | |
| *** gouthamr has quit IRC | 08:13 | |
| kashyap | hrw: Oh, yes, I thought of the test in your change, but forgot to mention it. Cool that you've worked it out. | 08:14 |
| hrw | kashyap: I was aware that test is needed. Just had no idea how to write it. Kevin wrote it for me. | 08:14 |
| *** yangyapeng has quit IRC | 08:15 | |
| *** yangyapeng has joined #openstack-nova | 08:15 | |
| kashyap | I see, ah, missed the co-author bit. | 08:15 |
| kashyap | hrw: I myself struggle with the unit tests as I don't look at it terribly often | 08:15 |
| hrw | kashyap: Kevin knows Nova code. I don't | 08:15 |
| * kashyap nods | 08:16 | |
| *** zhurong has quit IRC | 08:16 | |
| *** sahid has joined #openstack-nova | 08:21 | |
| *** zhurong has joined #openstack-nova | 08:27 | |
| *** rcernin has quit IRC | 08:28 | |
| hrw | mailed ML | 08:28 |
| *** fragatin_ has joined #openstack-nova | 08:29 | |
| *** fragatina has quit IRC | 08:31 | |
| *** fragatin_ has quit IRC | 08:33 | |
| *** chyka has joined #openstack-nova | 08:33 | |
| *** fragatina has joined #openstack-nova | 08:33 | |
| *** Dinesh_Bhor has quit IRC | 08:36 | |
| *** fragatina has quit IRC | 08:37 | |
| *** chyka has quit IRC | 08:38 | |
| *** fragatina has joined #openstack-nova | 08:42 | |
| *** Brin has quit IRC | 08:43 | |
| *** markvoelker has quit IRC | 08:44 | |
| *** Dinesh_Bhor has joined #openstack-nova | 08:47 | |
| *** migi has joined #openstack-nova | 08:51 | |
| *** moshele has joined #openstack-nova | 08:52 | |
| *** armax has joined #openstack-nova | 08:55 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | 08:57 |
| *** Tom-Tom has quit IRC | 08:59 | |
| *** Tom-Tom has joined #openstack-nova | 09:00 | |
| *** moshele has quit IRC | 09:12 | |
| *** armax has quit IRC | 09:14 | |
| *** johnthetubaguy has quit IRC | 09:17 | |
| *** johnthetubaguy has joined #openstack-nova | 09:18 | |
| stephenfin | hrw: Sure | 09:18 |
| hrw | stephenfin: thanks. | 09:19 |
| hrw | stephenfin: hope that someone will take a look too. Not adding reviewers as I do not know who to add | 09:19 |
| * hrw back in ~40 | 09:21 | |
| *** fragatina has quit IRC | 09:21 | |
| *** fragatina has joined #openstack-nova | 09:22 | |
| *** derekh has joined #openstack-nova | 09:23 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova master: Use method validate_integer from oslo.utils https://review.openstack.org/528620 | 09:29 |
| *** takashin has left #openstack-nova | 09:30 | |
| *** lpetrut has joined #openstack-nova | 09:31 | |
| *** lucas-afk is now known as lucasagomes | 09:33 | |
| *** udesale__ has joined #openstack-nova | 09:33 | |
| *** cristicalin has joined #openstack-nova | 09:34 | |
| *** udesale has quit IRC | 09:35 | |
| *** edmondsw has joined #openstack-nova | 09:37 | |
| *** cristicalin has quit IRC | 09:39 | |
| *** markvoelker has joined #openstack-nova | 09:41 | |
| *** edmondsw has quit IRC | 09:42 | |
| *** liuyulong has joined #openstack-nova | 09:44 | |
| hrw | stephenfin: by 'link to your blog' you mean https://marcin.juszkiewicz.com.pl/2018/01/04/today-i-was-fighting-with-nova-no-idea-who-won/ link? | 09:50 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Fix hypervisor_type in /os-hypervisors/details https://review.openstack.org/531328 | 09:50 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: [libvirt] Filter hypervisor_type by virt_type https://review.openstack.org/531347 | 09:50 |
| stephenfin | hrw: Yup | 09:51 |
| hrw | ok | 09:51 |
| *** claudiub|2 has joined #openstack-nova | 09:51 | |
| *** hongbin has quit IRC | 09:52 | |
| openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: libvirt: use 'host-passthrough' as default on AArch64 https://review.openstack.org/530965 | 09:53 |
| hrw | reno updated, link added | 09:53 |
| *** claudiub has quit IRC | 09:54 | |
| kashyap | hrw: Thanks for the quick feedback | 09:54 |
| *** fragatina has quit IRC | 09:54 | |
| kashyap | s/feedback/response/ | 09:54 |
| hrw | kashyap: it's my job ;D | 09:55 |
| hrw | kashyap: and I prefer to have patches quickly updated to keep reviewers attention | 09:55 |
| kashyap | hrw: Is this pressing? If so you have to state it, so reviewers calibrate their queue accordingly :-) | 09:56 |
| kashyap | Those who can +2, i.e. | 09:56 |
| hrw | kashyap: it would be lovely to get both my patches into Queens. That level of priority. | 09:56 |
| kashyap | Yeah, it should. Upstream is not _that_ terribly slow for self-contained stuff like this. | 09:57 |
| kashyap | This is a straight-forward one. No delay should be done in merging this. | 09:57 |
| hrw | We have workaround for cpu_mode already merged into Kolla and I know that it is present in some other ways of deploying too. | 09:57 |
| hrw | UEFI one can not be workarounded | 09:59 |
| * kashyap nods | 10:00 | |
| hrw | added some random core reviewers to both patches | 10:01 |
| *** sean-k-mooney has joined #openstack-nova | 10:03 | |
| sean-k-mooney | stephenfin: o/ happy new year | 10:03 |
| stephenfin | sean-k-mooney: o/ ditto | 10:03 |
| sean-k-mooney | see my comment on https://review.openstack.org/#/c/530961/2 | 10:04 |
| stephenfin | sean-k-mooney: Hahaha | 10:04 |
| stephenfin | This is what I'm currently reading | 10:04 |
| stephenfin | https://docs.python.org/2/library/subprocess.html#subprocess.Popen.communicate | 10:04 |
| stephenfin | I was trying to capture stderr/stdout to see if that was indeed the issue (I suspected it was) | 10:05 |
| stephenfin | sean-k-mooney: I'm thinking we just configure that to 'python -m privsep.[path_to_module]' | 10:06 |
| *** Guest45790 has quit IRC | 10:06 | |
| *** sree has joined #openstack-nova | 10:07 | |
| sean-k-mooney | stephenfin: the test rodoflo is adding will need at least cap_net_admin to run so it will need to launch privesp with sudo to get that | 10:07 |
| *** sgordon has quit IRC | 10:08 | |
| *** Dinesh_Bhor has quit IRC | 10:09 | |
| stephenfin | Right, I meant 'sudo python -m' as I thought we'd keep the virtualenv-configured Python, but we obviously won't actually | 10:09 |
| sean-k-mooney | stephenfin: i think we can alter the config fuction here https://review.openstack.org/#/c/484386/30/os_vif/tests/functional/base.py | 10:09 |
| *** sree has quit IRC | 10:09 | |
| *** sree has joined #openstack-nova | 10:09 | |
| sean-k-mooney | stephenfin: if we addin the a override for the oslo privsep helper_command form sudo privsep-helper to sudo -EH privsep-helper its shoudl resolve the issue | 10:10 |
| * stephenfin checks | 10:11 | |
| sean-k-mooney | technicall i theink just the -E is need to keep the virtual env intact but i always use -EH just to be safe | 10:11 |
| sean-k-mooney | my spelling is on point as always... | 10:12 |
| *** tetsuro_ has left #openstack-nova | 10:12 | |
| *** markvoelker has quit IRC | 10:15 | |
| *** hoangcx has quit IRC | 10:15 | |
| *** jafeha has quit IRC | 10:17 | |
| stephenfin | sean-k-mooney: Turns out PATH isn't passed through via '-E'. Something about secure_path. Who knew! | 10:21 |
| *** damien_r has joined #openstack-nova | 10:26 | |
| *** ljjjustin has quit IRC | 10:27 | |
| *** udesale has joined #openstack-nova | 10:28 | |
| *** cdent has joined #openstack-nova | 10:29 | |
| *** gcb has quit IRC | 10:29 | |
| *** udesale__ has quit IRC | 10:29 | |
| *** gszasz has joined #openstack-nova | 10:30 | |
| sean-k-mooney | stephenfin: really ok... im pulling down the patch in a clean vm and ill see if i can reporduce the gate issue | 10:32 |
| *** namnh_ has joined #openstack-nova | 10:33 | |
| *** namnh_ has quit IRC | 10:34 | |
| sean-k-mooney | yep same issue | 10:35 |
| *** tuanla____ has quit IRC | 10:35 | |
| *** sree has quit IRC | 10:35 | |
| sean-k-mooney | and the privsep-helper is in .tox/functional/bin/privsep-helper as i taught but not in /bin | 10:36 |
| *** sree has joined #openstack-nova | 10:36 | |
| *** namnh has quit IRC | 10:37 | |
| *** sambetts|afk is now known as sambetts | 10:37 | |
| stephenfin | sean-k-mooney: This is as far as I've got http://paste.openstack.org/show/638995/ | 10:38 |
| stephenfin | sean-k-mooney: But that's yielding this, ostensibly because we're using absolute paths to a package that is only installed in the virtualenv http://paste.openstack.org/show/638997/ | 10:40 |
| sean-k-mooney | that worked for me | 10:40 |
| stephenfin | It did? | 10:40 |
| stephenfin | Failing for me on CentOS :( | 10:40 |
| sean-k-mooney | well it passed all the tests | 10:40 |
| sean-k-mooney | http://paste.openstack.org/show/638998/ | 10:41 |
| *** moshele has joined #openstack-nova | 10:42 | |
| *** dtantsur|afk is now known as dtantsur | 10:42 | |
| stephenfin | How weird | 10:42 |
| *** sree has quit IRC | 10:42 | |
| *** sdague has joined #openstack-nova | 10:43 | |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: disconnect volume from host during detach https://review.openstack.org/515008 | 10:43 |
| stephenfin | You've other modifications though, to say that you have logging | 10:43 |
| sean-k-mooney | no i just applied what you gave | 10:43 |
| *** sree has joined #openstack-nova | 10:43 | |
| sean-k-mooney | http://paste.openstack.org/show/638999/ | 10:43 |
| sean-k-mooney | that was applied directly on top of your zuul patch | 10:44 |
| *** moshele has quit IRC | 10:44 | |
| sean-k-mooney | 15264957c475a6ecc1648a9ca2f04c9beb95f98d | 10:44 |
| sean-k-mooney | i can spin up a centos vm and test it there again if that helps | 10:45 |
| stephenfin | If you wouldn't mind | 10:45 |
| stephenfin | I'll push this now for review/rework | 10:45 |
| stephenfin | See what the gate thinks too | 10:45 |
| *** nore_rabel has joined #openstack-nova | 10:46 | |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif master: zuul: Enable functional tests in gate https://review.openstack.org/530961 | 10:47 |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif master: Configure privsep binary https://review.openstack.org/531358 | 10:47 |
| sean-k-mooney | no prob it will only take like 5min to get the env setup i mainly the proxies...# | 10:47 |
| *** sree has quit IRC | 10:48 | |
| *** abhishekk has quit IRC | 10:49 | |
| *** sree has joined #openstack-nova | 10:52 | |
| *** szaher has joined #openstack-nova | 10:54 | |
| *** nore_rabel is now known as rabel | 10:55 | |
| *** zhurong has quit IRC | 10:57 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Remove redundant swap_volume tests https://review.openstack.org/531179 | 10:57 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Don't generate fake disk_info in swap_volume https://review.openstack.org/530787 | 10:57 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Local disk serial numbers for the libvirt driver https://review.openstack.org/529380 | 10:57 |
| *** pcaruana has joined #openstack-nova | 11:01 | |
| *** udesale__ has joined #openstack-nova | 11:02 | |
| *** sgordon has joined #openstack-nova | 11:03 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Refactor encryptor attach and detach calls https://review.openstack.org/460243 | 11:04 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Attach and detach encryptors during swap_volume https://review.openstack.org/531233 | 11:04 |
| *** udesale has quit IRC | 11:05 | |
| sean-k-mooney | stephenfin: v2 fails v3 gives me the No module named internal.command.ip.test_impl_pyroute2 issue but only on centos. on ubunutu v3 works | 11:05 |
| stephenfin | Try this on Ubuntu -> sudo -E su -c 'echo $PATH' | 11:06 |
| *** rabel has quit IRC | 11:06 | |
| *** Tom-Tom_ has joined #openstack-nova | 11:07 | |
| stephenfin | CentOS has 'Defaults secure_path = /sbin:/bin:/usr/sbin:/usr/bin'. I imagine Ubuntu might not | 11:07 |
| sean-k-mooney | /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games vs /sbin:/bin:/usr/sbin:/usr/bin on centos | 11:07 |
| stephenfin | Hmm, still doesn't pass through the virtualenv directory. I'd expected it would | 11:08 |
| sean-k-mooney | well i was not in a venves ill try that instead | 11:08 |
| stephenfin | Oh, yeah :D source .tox/functional/bin/activate first :) | 11:09 |
| *** Tom-Tom has quit IRC | 11:09 | |
| sean-k-mooney | i think " tox -e venv -- sudo -E su -c 'echo $PATH'" will also work | 11:09 |
| *** Tom-Tom has joined #openstack-nova | 11:10 | |
| *** sree has quit IRC | 11:10 | |
| *** purplerbot has quit IRC | 11:11 | |
| sean-k-mooney | stephenfin: not much is jumping out at me http://paste.openstack.org/show/639010/ | 11:11 |
| *** markvoelker has joined #openstack-nova | 11:11 | |
| *** purplerbot has joined #openstack-nova | 11:12 | |
| *** Tom-Tom_ has quit IRC | 11:13 | |
| *** sree has joined #openstack-nova | 11:14 | |
| stephenfin | sean-k-mooney: Is that any help to us though? | 11:16 |
| *** jafeha has joined #openstack-nova | 11:17 | |
| *** Tom-Tom has quit IRC | 11:18 | |
| *** sree has quit IRC | 11:18 | |
| *** rabel has joined #openstack-nova | 11:20 | |
| *** sridharg has quit IRC | 11:21 | |
| *** sree has joined #openstack-nova | 11:22 | |
| sean-k-mooney | i dont think its related to the system path. | 11:23 |
| *** udesale has joined #openstack-nova | 11:27 | |
| *** sridharg has joined #openstack-nova | 11:28 | |
| *** udesale__ has quit IRC | 11:29 | |
| *** khappone has quit IRC | 11:29 | |
| *** fragatina has joined #openstack-nova | 11:32 | |
| *** fragatina has quit IRC | 11:32 | |
| *** fragatina has joined #openstack-nova | 11:33 | |
| *** Drankis has joined #openstack-nova | 11:33 | |
| sean-k-mooney | stephenfin: i think this has someithing to do with the python path. specifically i do not think the privsep deamon spawnded via sudo -E on cetos is using the python path that with the virtual_env | 11:34 |
| *** nicolasbock has joined #openstack-nova | 11:35 | |
| stephenfin | Yeah, I've tried setting 'PYTHONPATH' but haven't had any luck so far | 11:35 |
| stephenfin | I wonder if it's using a different Python interpreter too? | 11:35 |
| sean-k-mooney | slightly 2.7.12 on ubuntu and 2.7.5 on centos | 11:35 |
| stephenfin | No, I meant the one in the virtualenv vs the system one | 11:36 |
| *** sree has quit IRC | 11:36 | |
| sean-k-mooney | oh you can force that but no not by default | 11:36 |
| stephenfin | I'm not actually sure how virtualenv configures PYTHONPATH. I was assuming it was done by way of the environment variable but apparently not | 11:37 |
| sean-k-mooney | if i activeate teh virutal enve and run python i can run "from os_vif.internal.command.ip import impl_pyroute2" but it dose not work if i do sudo -E python | 11:37 |
| stephenfin | Yeah, I tried 'sudo PYTHONPATH=.tox/functional/lib/python2.7/site-packages' too, but to no avail | 11:38 |
| sean-k-mooney | hum that is the same on ubuntho though | 11:38 |
| *** Tom-Tom has joined #openstack-nova | 11:40 | |
| *** sree has joined #openstack-nova | 11:40 | |
| *** Tom-Tom_ has joined #openstack-nova | 11:42 | |
| sean-k-mooney | stephenfin: well python -c "import sys; print('\n'.join(sys.path))" is pretty clear. with sudo -E teh venv disapears | 11:43 |
| *** udesale has quit IRC | 11:44 | |
| *** Tom-Tom has quit IRC | 11:44 | |
| *** markvoelker has quit IRC | 11:45 | |
| stephenfin | cdent: Finished https://review.openstack.org/#/c/513526/. One potential follow-up in there | 11:46 |
| cdent | stephenfin: roger that. I think that block being where it is is a holdover from an earlier version where the logic was somewhat different and a rebase required shifting the logic a bit | 11:48 |
| cdent | actually... | 11:48 |
| * cdent re-learns to read | 11:48 | |
| cdent | no, that statement's right | 11:50 |
| *** tbachman has quit IRC | 11:50 | |
| *** Tom-Tom_ has quit IRC | 11:53 | |
| *** sree has quit IRC | 11:53 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Attach and detach encryptors during swap_volume https://review.openstack.org/531233 | 11:54 |
| *** Tom-Tom has joined #openstack-nova | 11:55 | |
| *** purplerbot has quit IRC | 11:56 | |
| *** purplerbot has joined #openstack-nova | 11:56 | |
| *** sree has joined #openstack-nova | 11:56 | |
| *** annp has quit IRC | 12:00 | |
| *** chyka has joined #openstack-nova | 12:09 | |
| *** purplerbot has quit IRC | 12:11 | |
| *** purplerbot has joined #openstack-nova | 12:11 | |
| *** liuyulong has quit IRC | 12:13 | |
| *** Tom-Tom has quit IRC | 12:14 | |
| *** chyka has quit IRC | 12:14 | |
| *** Tom-Tom has joined #openstack-nova | 12:14 | |
| *** sree has quit IRC | 12:16 | |
| *** Tom-Tom has quit IRC | 12:19 | |
| *** Tom-Tom has joined #openstack-nova | 12:21 | |
| *** sree has joined #openstack-nova | 12:22 | |
| *** smatzek has joined #openstack-nova | 12:23 | |
| *** jamesdenton has quit IRC | 12:25 | |
| *** Tom-Tom has quit IRC | 12:26 | |
| *** fragatina has quit IRC | 12:30 | |
| *** sree has quit IRC | 12:30 | |
| *** sree has joined #openstack-nova | 12:34 | |
| sean-k-mooney | efried: o/ | 12:35 |
| sean-k-mooney | efried: is https://review.openstack.org/#/c/531260/ the top patch on the nested resouce provides series? | 12:39 |
| *** sree has quit IRC | 12:39 | |
| *** moshele has joined #openstack-nova | 12:42 | |
| *** markvoelker has joined #openstack-nova | 12:42 | |
| *** sree has joined #openstack-nova | 12:42 | |
| *** damien_r1 has joined #openstack-nova | 12:43 | |
| *** lucasagomes is now known as lucas-hungry | 12:46 | |
| *** damien_r has quit IRC | 12:46 | |
| *** sree has quit IRC | 12:47 | |
| *** janki has quit IRC | 12:50 | |
| *** moshele has quit IRC | 12:51 | |
| *** ratailor has quit IRC | 12:52 | |
| *** tbachman has joined #openstack-nova | 12:53 | |
| *** tbachman_ has joined #openstack-nova | 12:56 | |
| *** sree has joined #openstack-nova | 12:56 | |
| *** mdnadeem has quit IRC | 12:57 | |
| *** pooja_jadhav has quit IRC | 12:57 | |
| *** hoonetorg has quit IRC | 12:57 | |
| *** tbachman has quit IRC | 12:58 | |
| *** tbachman_ is now known as tbachman | 12:58 | |
| *** hshiina has quit IRC | 12:59 | |
| *** dillaman has joined #openstack-nova | 13:03 | |
| *** sree has quit IRC | 13:05 | |
| * mdbooth wishes there was a way to mark a -1 review as "I looked at that, and it was idiotic" | 13:08 | |
| *** psachin has quit IRC | 13:09 | |
| * mdbooth curses drive-by low-energy reviews | 13:09 | |
| *** sree has joined #openstack-nova | 13:11 | |
| *** edmondsw has joined #openstack-nova | 13:13 | |
| *** markvoelker has quit IRC | 13:15 | |
| *** edmondsw has quit IRC | 13:17 | |
| *** fragatina has joined #openstack-nova | 13:19 | |
| *** sree has quit IRC | 13:20 | |
| *** dave-mccowan has joined #openstack-nova | 13:22 | |
| *** sree has joined #openstack-nova | 13:23 | |
| *** eharney has joined #openstack-nova | 13:24 | |
| *** fragatina has quit IRC | 13:25 | |
| *** sree has quit IRC | 13:27 | |
| *** sree has joined #openstack-nova | 13:28 | |
| *** slunkad has joined #openstack-nova | 13:32 | |
| *** markvoelker has joined #openstack-nova | 13:36 | |
| mhenkel | hi All | 13:40 |
| mhenkel | I am trying to use the haproxy template similar to this one: https://review.openstack.org/#/c/474107/8/puppet/services/keystone.yaml | 13:41 |
| mhenkel | however, when I define server_names: "%{hiera('contrail_config_node_names')}" haproxy puppet fails with: | 13:42 |
| mhenkel | "Error: /Stage[main]/Haproxy/Haproxy::Instance[haproxy]/Haproxy::Config[haproxy]/Concat[/etc/haproxy/haproxy.cfg]/File[/etc/haproxy/haproxy.cfg]/content: change from {md5}1f337186b0e1ba5ee82760cb437fb810 to {md5}d12e9a54e85e6bb63391d61cf9eb1da6 failed: Execution of '/usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg20180105-12-13t72r6 -c' returned 1: [ALERT] 004/024209 (275) : parsing [/etc/haproxy/haproxy.cfg20180105-12-13t72r6:53] : | 13:42 |
| mhenkel | character '[' is not permitted in server name '[\"overcloud-contrailcontroller-0.internalapi.localdomain\"]'." | 13:42 |
| *** david_10 has joined #openstack-nova | 13:46 | |
| *** tpatzig_3 has joined #openstack-nova | 13:46 | |
| *** carthaca_2 has joined #openstack-nova | 13:46 | |
| *** tpatzig_8 has joined #openstack-nova | 13:46 | |
| *** mkoderer_ has joined #openstack-nova | 13:46 | |
| mhenkel | any idea why %{hiera('contrail_config_node_names')} returns [\"overcloud-contrailcontroller-0.internalapi.localdomain\"] instead of overcloud-contrailcontroller-0.internalapi.localdomain ? | 13:46 |
| *** bhagyashri_s has joined #openstack-nova | 13:47 | |
| *** links has quit IRC | 13:47 | |
| stephenfin | mhenkel: Sounds like something for #tripleo or #puppet | 13:48 |
| *** sean-k-mooney has quit IRC | 13:49 | |
| *** sean-k-mooney has joined #openstack-nova | 13:49 | |
| *** bhagyashris has quit IRC | 13:49 | |
| *** tonyb has quit IRC | 13:49 | |
| *** tonyb has joined #openstack-nova | 13:50 | |
| *** mkoderer_3 has quit IRC | 13:51 | |
| *** tpatzig_2 has quit IRC | 13:51 | |
| *** david_ has quit IRC | 13:51 | |
| *** carthaca_ has quit IRC | 13:51 | |
| *** tpatzig_ has quit IRC | 13:51 | |
| *** jistr is now known as jistr|biab | 13:51 | |
| artom | mdbooth, I did have an idea of "meta-reviews" a while ago | 13:53 |
| artom | The (very legitimate) response was "make it happen" | 13:53 |
| *** edmondsw has joined #openstack-nova | 13:53 | |
| artom | To which my also very legitimate reaction was "ugh" | 13:53 |
| artom | And nothing came of it :/ | 13:53 |
| mdbooth | artom: My concern's more that I suspect people have review lists like 'open reviews with +1 from Zuul and no -1s' | 13:54 |
| mdbooth | And my patch would now fall foul of that for a completely dumb reason | 13:54 |
| *** sridharg has quit IRC | 13:54 | |
| mdbooth | An alternate idea would be the ability to mark a -1 as 'I looked at that, and have no intention of addressing it'. | 13:55 |
| *** mlavalle has joined #openstack-nova | 13:55 | |
| mdbooth | Then people might filter on unaddressed -1s instead. | 13:55 |
| mhenkel | stephenfin: sorry, wrong channel | 13:56 |
| mdbooth | artom: Meta reviews would be good, though. | 13:57 |
| artom | mdbooth, also, I suspect just showing who the -1 is from would help that | 13:58 |
| mdbooth | Although, who would do them? | 13:58 |
| *** READ10 has quit IRC | 13:59 | |
| *** lyan has joined #openstack-nova | 13:59 | |
| stephenfin | mdbooth, artom: If you're using the dashboards from gerrit-dash-creator, they shouldn't matter. The only -1s used to filter stuff there are core ones https://github.com/openstack/gerrit-dash-creator/tree/master/dashboards | 14:00 |
| stephenfin | Just as an aside | 14:00 |
| mdbooth | stephenfin: Ah, that's awesome | 14:00 |
| *** sree has quit IRC | 14:00 | |
| mdbooth | Well, somewhat elitist, but better that than exclude based on drive-bys | 14:00 |
| mdbooth | ;) | 14:01 |
| *** sree has joined #openstack-nova | 14:01 | |
| stephenfin | Elitist, but the best we've got ;) | 14:01 |
| openstackgerrit | Lajos Katona proposed openstack/nova master: Deduplicate aggregate notification samples https://review.openstack.org/531162 | 14:03 |
| *** sree has quit IRC | 14:05 | |
| hrw | speaking of reviews... anyone with free time to take a look at two simple aarch64 related patches? https://review.openstack.org/#/c/530965/ takes care of cpu_mode and https://review.openstack.org/#/c/489951/ makes aarch64 bootable out-of-the-box | 14:06 |
| *** claudiub|2 is now known as claudiub | 14:08 | |
| *** edleafe is now known as figleaf | 14:11 | |
| *** mriedem has joined #openstack-nova | 14:12 | |
| mriedem | kashyap: bad news, the shareable disk flag doesn't work when using raw images either http://paste.openstack.org/show/639185/ | 14:16 |
| efried | sean-k-mooney Howdy. That's the top patch in *one* of the nrp series, yes. | 14:21 |
| *** efried is now known as fried_rice | 14:23 | |
| ildikov | mriedem: kashyap: :( | 14:25 |
| openstackgerrit | Lajos Katona proposed openstack/nova master: Deduplicate service status notification samples https://review.openstack.org/531381 | 14:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add debug output for selected page size https://review.openstack.org/530662 | 14:25 |
| ildikov | mriedem: which versions gave you that error? | 14:26 |
| ildikov | mriedem: I also saw this 'qcow2 would suffer metadata corruption in such case' in the latest comment of this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1415250 | 14:28 |
| openstack | bugzilla.redhat.com bug 1415250 in openstack-nova "QEMU image file locking (RHOS)" [High,Post] - Assigned to lyarwood | 14:28 |
| *** smatzek has quit IRC | 14:31 | |
| stephenfin | mdbooth: What's the name of the pattern where you create an instance of object() and use that as a unique identifier? | 14:32 |
| *** ljjjustin has joined #openstack-nova | 14:32 | |
| *** smatzek has joined #openstack-nova | 14:32 | |
| mdbooth | stephenfin: I don't know. I stole it from zzzeek | 14:33 |
| mdbooth | It's a sentinel, though, so that might be what it's called? | 14:33 |
| stephenfin | Yup, sentinel is the word I was looking for | 14:34 |
| * zzzeek wouldnt have thought of that | 14:35 | |
| *** smatzek has quit IRC | 14:37 | |
| mriedem | ildikov: this is still qemu 2.10 and libvirt 3.6 | 14:38 |
| *** esberglu has joined #openstack-nova | 14:39 | |
| mriedem | kashyap was saying the libvirt devs were saying that qcow2 wouldn't work before libvirt 3.10 for shareable disks but raw should work, so this test run is setting CONF.libvirt.images_type=raw and CONF.use_cow_images=False | 14:39 |
| mriedem | but still doesn't work | 14:39 |
| mnaser | did i hit a really weird race condition possibly...? "Conflict updating instance e8cc3ace-2441-413e-bee7-d3a667e3298f. Expected: {'task_state': [u'migrating']}. Actual: {'task_state': None}" | 14:40 |
| mriedem | possibly, might depend on what it's trying to change the task_state to | 14:41 |
| mnaser | reset-state --active and doing a live-migration again triggers it.. let me check | 14:41 |
| Roamer` | okay, so I'll try to also reach johnthetubaguy through a couple of other channels, but maybe I should also try to start a conversation here... What do people think about adding a pretty much trivial StorPool volume attachment driver as in https://review.openstack.org/140733/ ? I know that milestone 1 has passed and we're actually getting pretty close to milestone 2, but the Cinder and os-brick dri | 14:41 |
| Roamer` | vers made it in last week, so right now we're in a funny situation where the main use case for the StorPool driver still needs manual patching. There's actually a major downstream OpenStack distributor with a client that wants to use StorPool, and the distributor would strongly prefer if all three StorPool drivers made it into OpenStack... so is there a chance for that? :) | 14:42 |
| mdbooth | mriedem: I don't think those config params would affect volumes anyway fwiw. | 14:42 |
| *** esberglu_ has joined #openstack-nova | 14:42 | |
| mriedem | was wondering that, | 14:43 |
| mriedem | i guess those are only used for ephemeral imagebackend devices | 14:43 |
| mdbooth | Yep | 14:43 |
| mriedem | gah | 14:43 |
| mriedem | ok | 14:43 |
| *** jmlowe has quit IRC | 14:43 | |
| mriedem | alright, trying again w/o pike uca so we use qemu 2.5 | 14:43 |
| mriedem | yikun: i think we should probably just add uuid to the response for the server migrations API in this change as well https://review.openstack.org/#/c/330406/ - is that something you think you'll have time for? if not, i can add that part of the change | 14:45 |
| *** esberglu has quit IRC | 14:45 | |
| *** jmlowe has joined #openstack-nova | 14:45 | |
| *** esberglu_ is now known as esberglu | 14:45 | |
| *** jmlowe has quit IRC | 14:48 | |
| *** hongbin has joined #openstack-nova | 14:48 | |
| *** jaypipes has joined #openstack-nova | 14:48 | |
| *** burt has joined #openstack-nova | 14:50 | |
| mlavalle | mriedem, hongbin: https://bugs.launchpad.net/neutron/+bug/1718605 is approved | 14:50 |
| openstack | Launchpad bug 1718605 in neutron "[RFE] Support sub-string matching when filtering port with IP address" [Wishlist,Triaged] - Assigned to hongbin (hongbin034) | 14:50 |
| *** jaypipes is now known as leakypipes | 14:51 | |
| hongbin | mlavalle: great. thanks | 14:51 |
| *** nicolasbock has quit IRC | 14:51 | |
| *** lucas-hungry is now known as lucasagomes | 14:52 | |
| ildikov | mriedem: got it, sadness, I guess it means we're falling back to play with the versions in Devstack then | 14:55 |
| mriedem | ildikov: yeah | 14:56 |
| mriedem | mlavalle: nice | 14:56 |
| fried_rice | figleaf What's the status of the alternate hosts series (for purposes of the sched mtg agenda)? | 14:57 |
| fried_rice | figleaf Are there open patches? | 14:58 |
| fried_rice | figleaf Or just that bug? | 14:58 |
| * fried_rice bonks self, goes to look at the bug... | 14:58 | |
| mriedem | fried_rice: i can tell you | 15:01 |
| fried_rice | Tell me, tell me. | 15:01 |
| mriedem | resize is the last piece https://review.openstack.org/#/c/526436/ | 15:01 |
| mriedem | but while figleaf was testing that, he found a race | 15:01 |
| mriedem | so he's working on fixing that race | 15:01 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1741125 | 15:01 |
| openstack | Launchpad bug 1741125 in OpenStack Compute (nova) "Instance resize always fails when rescheduling" [High,Confirmed] - Assigned to Ed Leafe (ed-leafe) | 15:01 |
| *** smatzek has joined #openstack-nova | 15:02 | |
| fried_rice | mriedem Thanks. Is the forked bug https://bugs.launchpad.net/nova/+bug/1741307 also related to alt hosts? | 15:03 |
| openstack | Launchpad bug 1741307 in OpenStack Compute (nova) "Resize always fails when using the CachingScheduler" [High,In progress] - Assigned to Matt Riedemann (mriedem) | 15:03 |
| mriedem | fried_rice: not to alternate hosts, just something i noticed when he pointed out the reschedule issue with resize | 15:03 |
| fried_rice | cool, thanks mriedem | 15:03 |
| mriedem | resize just doesn't work with the caching scheduler, period | 15:04 |
| melwitt | mriedem: do you think this libvirt patch has had enough bake time to propose backports now? https://review.openstack.org/#/c/400384/ | 15:04 |
| mriedem | because of the migration allocation swap stuff | 15:04 |
| mriedem | melwitt: heh, can you give it about another 18 months for us to know? | 15:04 |
| mriedem | :) | 15:04 |
| *** ljjjustin has quit IRC | 15:04 | |
| *** jistr|biab is now known as jistr | 15:04 | |
| melwitt | D: | 15:04 |
| mriedem | melwitt: honestly we probably won't know until people actually upgrade to start using that, and mnaser will probably be the first one once queens is released | 15:05 |
| mriedem | melwitt: i'm fine with doing backports though | 15:05 |
| mriedem | just not to newton | 15:05 |
| mriedem | ildikov: the devstack patch is now just enablement https://review.openstack.org/#/c/266633/ | 15:06 |
| mnaser | i'll gladly take release notes for us :D | 15:06 |
| mriedem | the patch on top of that turns on multiattach and disables the pike uca | 15:06 |
| melwitt | mriedem: okay, cool. I shall propose them then. thanks | 15:07 |
| *** sree has joined #openstack-nova | 15:07 | |
| *** hoonetorg has joined #openstack-nova | 15:10 | |
| mnaser | if there's any stable cores that can have a look at this backport: https://review.openstack.org/#/c/529385 | 15:13 |
| *** ljjjustin has joined #openstack-nova | 15:17 | |
| openstackgerrit | Lajos Katona proposed openstack/nova master: Deduplicate service status notification samples https://review.openstack.org/531381 | 15:17 |
| mriedem | dansmith: ^ | 15:17 |
| dansmith | mriedem: dun already got it | 15:17 |
| mriedem | the stable thing, not the notificatoins thing | 15:17 |
| mriedem | sympatico | 15:17 |
| dansmith | bottom one needs a recheck? | 15:17 |
| lyarwood | it already has | 15:18 |
| dansmith | ah nm, | 15:18 |
| dansmith | yeah | 15:18 |
| lyarwood | should be in the gate by now | 15:18 |
| dansmith | not quite | 15:18 |
| mriedem | still check queue, but going | 15:18 |
| lyarwood | urgh | 15:18 |
| mriedem | dansmith: btw, i had to fix a test in https://review.openstack.org/#/c/530982/ | 15:18 |
| mriedem | lyarwood: since you're around https://review.openstack.org/#/q/I1aa3ca6cc70cef65d24dec1e7db9491c9b73f7ab | 15:19 |
| mriedem | that should be the final thing for newton | 15:19 |
| mriedem | melwitt: this is a simple bp driver feature parity change https://review.openstack.org/#/c/448034/ | 15:20 |
| mriedem | needs final +2 | 15:20 |
| lyarwood | mriedem: ack | 15:20 |
| melwitt | mriedem: ack, will review | 15:20 |
| mriedem | thanks | 15:20 |
| *** sree has quit IRC | 15:21 | |
| mriedem | i see the allocation candidates limit change is also approved https://review.openstack.org/#/c/513526/ - nice, might get at least 2 bps merged today | 15:21 |
| openstackgerrit | Lajos Katona proposed openstack/nova master: Deduplicate service status notification samples https://review.openstack.org/531381 | 15:21 |
| *** gouthamr has joined #openstack-nova | 15:22 | |
| mriedem | andreykurilin: can you take a look at https://review.openstack.org/#/c/528128/ ? it will close out that bp and it's holding up other microversion changes in novaclient | 15:22 |
| ildikov | mriedem: ok, tnx | 15:27 |
| openstackgerrit | Lajos Katona proposed openstack/nova master: Deduplicate aggregate notification samples https://review.openstack.org/531162 | 15:27 |
| *** weshay is now known as weshay_interview | 15:28 | |
| mriedem | stephenfin: http://logs.openstack.org/50/530950/1/check/legacy-tempest-dsvm-py35/f814425/logs/screen-n-novnc.txt.gz?level=TRACE#_Jan_04_17_19_48_242679 | 15:30 |
| mriedem | stephenfin: maybe try using encodeutils.safe_encode here? https://review.openstack.org/#/c/345399/37/nova/console/securityproxy/rfb.py | 15:30 |
| stephenfin | mriedem: I can't catch a break with that thing :D That's a good idea though | 15:31 |
| * stephenfin is currently deploying devstack for the third time today because he forgot to enable Python 3 | 15:31 | |
| stephenfin | silly stephenfin | 15:31 |
| *** jmlowe has joined #openstack-nova | 15:32 | |
| sean-k-mooney | fried_rice: thanks. ya i noticed that there seemed to be multiple nrp patch series interwoven. i think https://review.openstack.org/#/c/384807/ is the patch i need to start using nrp to model hw acclerated vhost-vfio interfaces. | 15:37 |
| *** jafeha has quit IRC | 15:37 | |
| *** jafeha has joined #openstack-nova | 15:39 | |
| fried_rice | sean-k-mooney "hw accelerated vhost-vfio interfaces". Sure. | 15:41 |
| mriedem | i can't wait until sean-k-mooney stabs one of you guys | 15:42 |
| sean-k-mooney | fried_rice: they are hardware offloaded port that use vfio-mdev instead of sriov to offload the dataplane and vhost to offload the control plane | 15:42 |
| *** liverpooler has joined #openstack-nova | 15:43 | |
| fried_rice | sean-k-mooney Okay, cool. So how are you planning to represent that from libvirt without using update_provider_tree? | 15:43 |
| hrw | melwitt: thanks for +2 +W :) | 15:43 |
| sean-k-mooney | fried_rice: step too is the libvirt xml generation but effectivly i am planning on having neutorn create teh resouce providers in placement and using a new vnic type to generate a request to placement for an allocation of the custom resouce class. | 15:45 |
| mriedem | johnthetubaguy: is there some known thing with using the cachingscheduler where the compute services don't check in on time? or you have to adjust the compute service heartbeat? | 15:45 |
| johnthetubaguy | mriedem: yeah, that is a thing | 15:46 |
| melwitt | hrw: thanks for enhancing the commit message and the bug, makes it a lot easier to review | 15:46 |
| fried_rice | sean-k-mooney This in Queens?? | 15:46 |
| mriedem | johnthetubaguy: orly | 15:46 |
| mriedem | yeah because i'm seeing this in the scheduler logs | 15:46 |
| mriedem | Jan 04 20:06:18.133057 ubuntu-xenial-rax-ord-0001690099 nova-scheduler[9487]: WARNING nova.scheduler.filters.compute_filter [None req-370806fa-5640-485d-adc2-21808de9ccb4 tempest-MigrationsAdminTest-1101936831 tempest-MigrationsAdminTest-1101936831] (ubuntu-xenial-rax-ord-0001690099, ubuntu-xenial-rax-ord-0001690099) ram: 6446MB disk: 58368MB io_ops: 15 instances: 15 has not been heard from in a while | 15:46 |
| mriedem | but no errors in the n-cpu logs | 15:46 |
| hrw | melwitt: o yes ;D | 15:46 |
| hrw | melwitt: can you take a look at https://review.openstack.org/#/c/530965/ too? | 15:46 |
| johnthetubaguy | mriedem: if your cache interval is larger than than how long you thing it is dead, it starts to ignore some of your nodes randomly | 15:46 |
| mriedem | ah | 15:46 |
| hrw | melwitt: I am open for any questions | 15:46 |
| mnaser | mriedem: i think i found out how i got that weird state. doing a host-evacuate-live sends a live-migration request for all instances, as nova processes them one by one, the states of all vms in the compute host are in "migrating".. but then its possible that a delete request comes in while the live migration is happening. | 15:46 |
| sean-k-mooney | fried_rice: not upstream, libvirt and qemu dont even have support for vhost-vfio yet. way to early to propose upstrem in openstack | 15:47 |
| melwitt | hrw: I'll add it to my list | 15:47 |
| hrw | melwitt: thanks | 15:47 |
| hrw | melwitt: with those two merged getting openstack on aarch64 is much easier ;D | 15:47 |
| mnaser | in the rpc code, there doesn't seem to be any handling if the VM is in migrating state | 15:48 |
| sean-k-mooney | fried_rice: i would like to have a poc working ptg/early rocky timeframe but i doubt the dependcies will align for it to land even in rocky | 15:48 |
| mnaser | for deletes | 15:48 |
| hrw | melwitt: uefi change is most important as with it in nova we cut 90% of users questions ;d | 15:48 |
| kashyap | mriedem: Hey was AFK | 15:48 |
| fried_rice | sean-k-mooney Okay, gotcha. You going to be around for the sched meeting on Monday? This is exactly the kind of rationale cdent and Radoslav were bringing up in https://review.openstack.org/#/c/526539/ (to pose the question, "Why are we artificially restricting in-tree virt drivers from talking directly to placement?" | 15:49 |
| kashyap | Reading the scroll | 15:49 |
| fried_rice | ) | 15:49 |
| mriedem | johnthetubaguy: i don't see a specific config option for how long the cachingscheduler caches it's host state information | 15:49 |
| mriedem | is that somewhere outside the actual CachingScheduler class? | 15:49 |
| sean-k-mooney | fried_rice: am what time is it?( checking meeting page) | 15:49 |
| johnthetubaguy | mriedem: ah, I think its in scheduler manager, sadly | 15:50 |
| johnthetubaguy | just digging | 15:50 |
| mriedem | @periodic_task.periodic_task(spacing=CONF.scheduler.periodic_task_interval, | 15:50 |
| mriedem | run_immediately=True) | 15:50 |
| mriedem | def _run_periodic_tasks(self, context): | 15:50 |
| mriedem | self.driver.run_periodic_tasks(context) | 15:50 |
| mriedem | ? | 15:50 |
| johnthetubaguy | mriedem, yeah https://github.com/openstack/nova/blob/d19e1252d5f2f8e8b54a276003f842ee00641026/nova/scheduler/manager.py#L79 | 15:50 |
| mriedem | yup that's it | 15:50 |
| sean-k-mooney | fried_rice: 14:00 UTC i should be able to attend. | 15:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce framework for RFB authentication https://review.openstack.org/345397 | 15:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce the VeNCrypt RFB authentication scheme https://review.openstack.org/345398 | 15:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: Provide an RFB security proxy implementation https://review.openstack.org/345399 | 15:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Document TLS security setup for noVNC proxy https://review.openstack.org/500544 | 15:51 |
| fried_rice | sean-k-mooney Cool. | 15:51 |
| leakypipes | cdent, fried_rice: see my comment on https://review.openstack.org/#/c/526539/ | 15:51 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: [libvirt] Allow multiple volume attachments https://review.openstack.org/267587 | 15:51 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass multiattach flag to reserve_block_device_name https://review.openstack.org/531244 | 15:51 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: [api] Allow multi-attach in compute api https://review.openstack.org/271047 | 15:51 |
| johnthetubaguy | mriedem: trying to find the docks I wrote about this, failing :( | 15:51 |
| *** Drankis has quit IRC | 15:51 | |
| *** awaugama has joined #openstack-nova | 15:52 | |
| stephenfin | mriedem: Could you hit this again at some point today? Got an open question on it for you https://review.openstack.org/#/c/526329/ | 15:53 |
| mriedem | the config option help for that actually points out the service_down_time option too | 15:53 |
| cdent | leakypipes: thanks reading. I think I tend to use "arbitrary" incorrectly or at least with different connotations that most peole do. I tend to mean it as "something we chose" (as opposed to "a thing we must do") | 15:53 |
| mriedem | so i'm pleasantly surprised | 15:53 |
| johnthetubaguy | mriedem: https://github.com/openstack/nova/blob/d19e1252d5f2f8e8b54a276003f842ee00641026/nova/conf/scheduler.py#L78 | 15:53 |
| johnthetubaguy | mriedem: yeah, I knew I put that somewhere! | 15:53 |
| mriedem | johnthetubaguy: yup, was just reading that | 15:53 |
| mriedem | nice | 15:53 |
| stephenfin | oh | 15:53 |
| *** stephenfin is now known as finucannot | 15:53 | |
| leakypipes | cdent: sure, understood. | 15:54 |
| sean-k-mooney | fried_rice: im hoping i wont actully need to modify the virt driver as part of the poc beyond the xml generation. on of the advantages of mdevs is you create them using arbitray uuids(neutron port uuid in my case) dynamically so i may be able to skip the resouce tracker entrily as i basically just need a count of howmany can be created per host which the placement inventories will already have. | 15:54 |
| *** Tom-Tom has joined #openstack-nova | 15:54 | |
| johnthetubaguy | mriedem: there is a type there s/scheduler service as down/compute service as down/ | 15:55 |
| fried_rice | leakypipes cdent Good deal. I can see both sides. I don't mind the idea of having intra-nova placement work funneled through this spot for the reasons stated (thread safety, code commonality) as long as we're not doing it with the expectation that e.g. OOT drivers have to conform. | 15:55 |
| fried_rice | sean-k-mooney So where are you going to get that request info from? Just directly from the flavor? | 15:55 |
| mriedem | finucannot: replied | 15:56 |
| mriedem | finucannot: we could backport that to stable/pike upstream, but no further given ocata g-r requires glanceclient>=2.5 | 15:56 |
| mriedem | johnthetubaguy: yup i noticed that too | 15:56 |
| mriedem | johnthetubaguy: i'm going to remove the deprecated names for that option, so i'll fix the typo at the same time | 15:57 |
| leakypipes | fried_rice: well, it's Python so of course OOT drivers can always do whatever they want with things ;) but that said, yes, I'd prefer to have the virt drivers just update the ProviderTree object and rely on something else (the reportclient called from the resource tracker most likely) do the work of making placement REST API calls. | 15:57 |
| finucannot | mriedem: Ta | 15:57 |
| johnthetubaguy | mriedem: sweet, thank you | 15:57 |
| sean-k-mooney | fried_rice: of course when i try to do that perhaps ill discovery why mriedem thinks ill what to stabs ye lol. am the requst for the port is encode by the new vnic type + neutron port bining profile info for mdev_type if needed. | 15:57 |
| *** gszasz has quit IRC | 15:59 | |
| fried_rice | sean-k-mooney IMO what you're doing here is closer to what should be happening long term. It would be nice if the scheduler and resource tracker could accept requests for resources, allocate them via placement, and pass those allocations through to virt without introspecting or special-casing them at all. | 15:59 |
| mriedem | johnthetubaguy: actually, a bit confused | 15:59 |
| mriedem | johnthetubaguy: it says, "This is because the scheduler driver is responsible for sending a heartbeat and it will only do that as often as this option allows." | 16:00 |
| fried_rice | sean-k-mooney I.e. compute code outside of virt doesn't need to care if a resource is a CPU, GPU, mdev (whatever that is), or peanut. | 16:00 |
| mriedem | johnthetubaguy: i don't see how the compute service down time and the scheduler periodic task interval are linke | 16:00 |
| mriedem | *linked | 16:00 |
| mriedem | sean-k-mooney: you will get stabby because of the constant spelling corrections | 16:00 |
| mriedem | like, "spell knife in the kidneys!" | 16:01 |
| fried_rice | Oh, did I do that? Not consciously. | 16:01 |
| sean-k-mooney | fried_rice: yes i had hopped to work on this as part of the nova neutron negociation stuff in queens and the multiple port binding before we change from upstream first to more poc/internal focoused. | 16:02 |
| *** jmlowe has quit IRC | 16:02 | |
| sean-k-mooney | mriedem: haha i would have taught i would be the other way round. jay has very kindly help me with this area over the past few years and im very greatful for that. | 16:03 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add functional test for resize reschedules https://review.openstack.org/531022 | 16:03 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436 | 16:03 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add regression test for resizing failing during retries https://review.openstack.org/531405 | 16:03 |
| figleaf | mriedem: ^^ added regression test and fix | 16:03 |
| mriedem | cool | 16:04 |
| *** tbachman has quit IRC | 16:04 | |
| leakypipes | sean-k-mooney: you would have *thought*. | 16:04 |
| leakypipes | sean-k-mooney: you're welcome. | 16:04 |
| sean-k-mooney | leakypipes: :) | 16:04 |
| leakypipes | sean-k-mooney: also... it's *grateful", not greatful. you're welcome, too. | 16:04 |
| leakypipes | sean-k-mooney: :P | 16:04 |
| kashyap | mriedem: Hope you recorded your observation about raw & the shareable thing in the multi-attach review | 16:05 |
| openstackgerrit | melanie witt proposed openstack/nova stable/pike: libvirt: Re-initialise volumes, encryptors, and vifs on hard reboot https://review.openstack.org/531407 | 16:06 |
| kashyap | Currently, I'm in split-brains mode, and trying to finishing something before the 'cache is flushed | 16:06 |
| mriedem | kashyap: i did, and it was just something i should have realized wouldn't apply here earlier on | 16:06 |
| mriedem | since imagebackend != volumes | 16:06 |
| * kashyap nods | 16:07 | |
| mriedem | johnthetubaguy: oh i think i see, | 16:08 |
| figleaf | fried_rice: sorry, missed your question earlier - network issues. | 16:08 |
| mriedem | the ComputeFilter is running every 60 seconds due to the caching scheduler's periodic task interval, | 16:08 |
| mriedem | which means it's potentially using a stale version of the compute service reference, | 16:08 |
| figleaf | fried_rice: mriedem answered what I would have said, so no worries | 16:08 |
| johnthetubaguy | mriedem: sorry, yeah, that's it | 16:08 |
| mriedem | which means it's last_seen_up would be old | 16:08 |
| johnthetubaguy | mriedem: yeah | 16:08 |
| *** mtreinish has quit IRC | 16:08 | |
| *** mtreinish has joined #openstack-nova | 16:09 | |
| johnthetubaguy | mriedem: hence the note about it not seeing instances being deleted, and being really bad if you run two schedulers | 16:09 |
| *** dhellmann has left #openstack-nova | 16:09 | |
| * johnthetubaguy all hail placement | 16:09 | |
| mriedem | heh | 16:09 |
| leakypipes | johnthetubaguy: make checks payable to fried_rice. | 16:10 |
| mriedem | if you're wondering why i'm asking https://review.openstack.org/#/c/531020/ | 16:10 |
| Roamer` | johnthetubaguy, did you catch my earlier messages about your procedural -2 on https://review.openstack.org/140733/? or am I being annoying already? :) | 16:10 |
| mriedem | people are still using the cachingscheduler but we don't really test it functionally anywhere, so i'm trying to flush out some squirrels | 16:10 |
| leakypipes | totally off-topic, but why does gerrit allow someone to hit a "quote" button on a review comment that is on a source file but won't provide a "quote" button to respond to a review comment that is on the review (not a source file)... | 16:11 |
| johnthetubaguy | Roamer: ah, sorry, I missed those, was visiting a customer this morning | 16:11 |
| melwitt | leakypipes: there's a button but it doesn't say "quote". it's a curved arrow next to the comment timestamp | 16:12 |
| mriedem | Roamer`: you should probably be talking to me - i haven't been tracking that blueprint for nova in queens at all | 16:12 |
| johnthetubaguy | mriedem: I don't think this once has been re-approved: https://blueprints.launchpad.net/nova/+spec/libvirt-storpool-volume-attach | 16:12 |
| mriedem | Roamer`: where is the patch that adds the storpool driver to cinder? | 16:12 |
| leakypipes | melwitt: well, holy crap. | 16:13 |
| mriedem | johnthetubaguy: yeah, because i didn't know about it until now and we're <2 weeks from FF | 16:13 |
| mriedem | :) | 16:13 |
| leakypipes | melwitt: I thought that was to close the comment... | 16:13 |
| Roamer` | mriedem, yeah, actually things happened 1. a bit suddenly at the start of December, and then 2. a bit slower than we expected with getting our CI system running, so our timing is a bit less than impeccable | 16:13 |
| * johnthetubaguy nods | 16:13 | |
| mriedem | Roamer`: you also need an os-brick release | 16:13 |
| Roamer` | mriedem, https://review.openstack.org/#/c/220155/ is Cinder and https://review.openstack.org/#/c/192639/ is os-brick | 16:13 |
| *** stvnoyes has joined #openstack-nova | 16:13 | |
| * johnthetubaguy learns new things about gerrit | 16:13 | |
| leakypipes | melwitt: heh, and the more you click the button, the more gerrit repeats the comment in the reply box. fun! | 16:14 |
| melwitt | leakypipes: hah, awesome | 16:14 |
| * leakypipes thinks up some evil DDoS that emulates clicking on comment quote buttons | 16:15 | |
| Roamer` | mriedem, and, yeah, my last comment to 140733 was "oof, yeah, Zuul cannot pass without an os-brick release" | 16:15 |
| mriedem | the unit tests are also all failing | 16:15 |
| Roamer` | yep, since our driver refers to initiator.STORPOOL | 16:15 |
| Roamer` | I could make it pass the "storpool" literal string, then it might fail in a slightly different way somewhat further | 16:16 |
| Roamer` | but I think that since os-brick has the constants, it'd be best to use them | 16:16 |
| sean-k-mooney | leakypipes: did you not tell me once you used gertty mainly for reviews or has the new mac forced you to the web in protest. | 16:17 |
| *** moshele has joined #openstack-nova | 16:17 | |
| openstackgerrit | Merged openstack/nova master: conf: hyperv: fix a comment typo https://review.openstack.org/531329 | 16:17 |
| Roamer` | mriedem, to make it clear: yes, the unit tests are also failing because the released version of os-brick doesn't know about the StorPool driver... if I patch it manually within the tox venv, the tests pass | 16:17 |
| mriedem | Roamer`: so you need an os-brick release and a bump to the required minimum version of os-brick in global-requirements in the openstack/requirements repo, | 16:19 |
| mriedem | non-client library freeze is jan 18 | 16:19 |
| mriedem | nova feature freeze is jan 25 | 16:19 |
| leakypipes | sean-k-mooney: I don't use the Mac for anything other than Verizon Slack and email. I use gertty as well but also use the Gerrit web UI just as much nowadays now that the whole "comment on this and the whole page goes haywire" bug was solved by mriedem. | 16:19 |
| mriedem | s/mriedem/smcginnis/ | 16:19 |
| Roamer` | mriedem, so you're saying that if I bother the os-brick folks enough, there might be a chance? Thanks! | 16:19 |
| *** moshele has quit IRC | 16:19 | |
| mriedem | Roamer`: i'm not terribly keen on approving a nova blueprint 1 week before feature freeze | 16:20 |
| mriedem | since it's a libvirt volume driver, it might get an exception | 16:20 |
| sean-k-mooney | leakypipes: wait that has been fixed? | 16:20 |
| mriedem | Roamer`: but the ducks need to be in a row first | 16:20 |
| Roamer` | mriedem, okay, thanks a lot! I'll be on my way to bother others now | 16:20 |
| *** jmlowe has joined #openstack-nova | 16:21 | |
| Roamer` | hmm, does this mean that, at least for the next couple of days, it might be a good idea for johnthetubaguy to remove his procedural -2, or shall we think about that only if we do get our ducks in a row first? | 16:21 |
| leakypipes | cdent: answered :) | 16:23 |
| cdent | thanks | 16:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove the deprecated scheduler_driver_task_period option https://review.openstack.org/531413 | 16:24 |
| mriedem | johnthetubaguy: see how that wording sounds ^ | 16:24 |
| mriedem | Roamer`: it's fine for johnthetubaguy to remove his -2 | 16:24 |
| mriedem | we can replace it with mine :) | 16:24 |
| openstackgerrit | Merged openstack/nova master: Remove a duplicate line in a unit test https://review.openstack.org/531317 | 16:24 |
| Roamer` | :) | 16:24 |
| leakypipes | sean-k-mooney: yeah. go into your profile -> settings -> diff preferences and set Render to "Slow" | 16:25 |
| leakypipes | mriedem: is that right? ^ | 16:25 |
| mriedem | yup | 16:26 |
| *** gszasz has joined #openstack-nova | 16:26 | |
| *** yamamoto has quit IRC | 16:26 | |
| leakypipes | cdent: great questions, btw | 16:28 |
| cdent | thanks, I'll try to make some more, by monday's meeting we can have a grand chat | 16:28 |
| sean-k-mooney | leakypipes: mriedem awsome that bug was painful. | 16:29 |
| leakypipes | sean-k-mooney: yeah, it sucks. | 16:29 |
| leakypipes | it's kinda funny. the Gerrit UI seems to deliberately try and emulate late 1990s style. | 16:30 |
| *** weshay_interview is now known as weshay | 16:30 | |
| mriedem | what is 2018 style? animal avitars like the iphone x? | 16:30 |
| leakypipes | mriedem: you know it. | 16:31 |
| mriedem | i'll gladly fork out $1000 for that piece of shit | 16:31 |
| leakypipes | not. | 16:31 |
| *** damien_r1 has quit IRC | 16:33 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/ocata: libvirt: Re-initialise volumes, encryptors, and vifs on hard reboot https://review.openstack.org/531422 | 16:35 |
| *** damien_r has joined #openstack-nova | 16:37 | |
| *** armax has joined #openstack-nova | 16:39 | |
| *** openstackstatus has quit IRC | 16:40 | |
| cdent | leakypipes: made a response, in which besides opening up some more worm cans, I note that the good questions still stand | 16:41 |
| *** openstackstatus has joined #openstack-nova | 16:42 | |
| *** ChanServ sets mode: +v openstackstatus | 16:42 | |
| *** mikal has quit IRC | 16:43 | |
| mriedem | melwitt: i think we should split the index add out of this https://review.openstack.org/#/c/334614/ and do that in a separate change | 16:45 |
| *** damien_r has quit IRC | 16:45 | |
| *** mikal has joined #openstack-nova | 16:45 | |
| *** jaosorior has quit IRC | 16:45 | |
| melwitt | rats. okay | 16:45 |
| sean-k-mooney | leakypipes: well gerrit is written in java useing gwt so its not exactly html5 native. its better then github pull requests though for code review so im not complaining | 16:47 |
| leakypipes | cdent: re: allocations for vCenter-owned (not OpenStack-owned) resources... the allocation records in placement don't care who creates them, of course. so yes, if there were some external agent that claimed resources for some non-OpenStack consumers, that would be fine I suppose. As long as that agent uses the POST /allocations interface to ensure read and write consistency, that doesn't bother me at all. | 16:47 |
| leakypipes | cdent: I just want to make sure that for *OpenStack consumers*, it's the scheduler (or conductor for move operations) that is the thing that claims resources for the system. | 16:47 |
| leakypipes | cdent: for all the reasons that we moved to scheduler doing claims in Pike... | 16:48 |
| *** chyka has joined #openstack-nova | 16:48 | |
| * cdent nods | 16:48 | |
| sean-k-mooney | leakypipes: speaking of code review. regarding your nrp api patch that merged in early december, is the best way to play around with that just use curl/postman and do it manually or have there been any osc patches created? | 16:49 |
| *** damien_r has joined #openstack-nova | 16:49 | |
| leakypipes | sean-k-mooney: :) that's actually the patch series we're currently discussing :) | 16:49 |
| melwitt | mriedem: I changed the name of the ConsoleConnection object too. let me know if that wasn't a good idea | 16:50 |
| leakypipes | sean-k-mooney: https://review.openstack.org/#/q/topic:bp/nested-resource-providers+(status:open) | 16:50 |
| *** yamamoto has joined #openstack-nova | 16:50 | |
| mriedem | melwitt: i like it, going through that diff now | 16:50 |
| leakypipes | sean-k-mooney: I'm currently working on integrating n-r-p with the allocation candidates stuff. fried_rice is focusing on the integration with the virt driver piece. | 16:50 |
| leakypipes | sean-k-mooney: so besides playing around with the hierarchy stuff in providers, there's not much you can yet do. | 16:51 |
| *** Apoorva has joined #openstack-nova | 16:51 | |
| sean-k-mooney | leakypipes: yep i was brefily talking to fried_rice about a poc im hoping to do in the next 6-8 to use it to support vhost-vfio interfaces. | 16:52 |
| leakypipes | ++ | 16:53 |
| sean-k-mooney | *6-8 weeks... units are important | 16:54 |
| mriedem | melwitt: which service should i see these log statements? cauth? https://review.openstack.org/#/c/320063/25/nova/objects/console_auth_token.py@116 | 16:54 |
| mriedem | or will this not actually run yet in ci in this change? | 16:54 |
| melwitt | mriedem: yeah I think you won't see it until the last change in the series, in the novnc service log | 16:56 |
| mriedem | ah yes | 16:57 |
| mriedem | http://logs.openstack.org/12/527812/1/check/tempest-full/26f5e5f/controller/logs/screen-n-novnc-cell1.txt | 16:57 |
| mriedem | Jan 05 01:44:25.338490 ubuntu-xenial-citycloud-sto2-0001695415 nova-novncproxy[10280]: DEBUG nova.objects.console_auth_token [None req-166854c4-3f01-4db1-890b-212b7ba78e95 None None] Validated token - console connection is ConsoleAuthToken(access_url_base='http://10.0.1.151:6080/vnc_auto.html',console_type='novnc',created_at=2018-01-05T01:44:25Z,host='127.0.0.1',id=1,instance_uuid=4453afe4-e6eb-4479-a073-0f99a76c71f1,internal | 16:57 |
| mriedem | ess_path=None,port=5900,token='***',updated_at=None) {{(pid=6917) validate /opt/stack/nova/nova/objects/console_auth_token.py:159}} | 16:57 |
| mriedem | NOICE | 16:57 |
| melwitt | :D | 16:57 |
| mriedem | finucannot: you were +2 on https://review.openstack.org/#/c/320063/ before a rebase and some changes | 16:58 |
| leakypipes | fried_rice: question... | 16:58 |
| melwitt | I did a bunch of token masking for the logs and then realized the websocketproxy logs the whole thing on its own, not our code | 16:58 |
| leakypipes | fried_rice: did we say that for allocation candidates responses, we would include "intermediary nodes" in the provider_summaries section even if those nodes weren't involved in any of the allocation_requests? | 16:59 |
| melwitt | but it's at level INFO so if someone cares they can turn the level up | 16:59 |
| leakypipes | fried_rice: for example, say we have a compute node provider, two numa cell providers and two pfs that are children, one of each numa cell. and the allocation_requests contains the compute node (for VCPU and MEMORY_MB) and both PFs (for SRIOV_NET_VF resources), should the provider_summaries include the numa cell providers as well even though no resources are directly consumed from them? | 17:00 |
| *** damien_r1 has joined #openstack-nova | 17:01 | |
| cdent | bbs | 17:01 |
| *** cdent has quit IRC | 17:01 | |
| mriedem | melwitt: on that index, i'd be fine with it in the same change as long as you call it out in the commit message and check the columns instead of the index name - i doubt anyone would want/need to backport that index add | 17:02 |
| *** jackie-truong has joined #openstack-nova | 17:02 | |
| mriedem | if that makes life easier | 17:02 |
| *** damien_r has quit IRC | 17:02 | |
| figleaf | leakypipes: it would make sense to include the whole "tree" of RPs, so that filters etc. could operate on that info | 17:03 |
| leakypipes | figleaf: ack, that's what I thought I remembered. thanks for reminding me. :) | 17:04 |
| sean-k-mooney | leakypipes: that is assuimg the resouce provider tree has 3 branches basically host->numa_node->pf, host->vcpu, host->memory_mb and vcpu and memory are not inventories of the numa nodes correct | 17:04 |
| *** mriedem is now known as mriedem_luncharo | 17:04 | |
| *** Apoorva has quit IRC | 17:04 | |
| melwitt | mriedem: okay. it probably makes more sense to be separate since the query isn't till a later change anyway. but curious, how could it end up part of a backport? | 17:04 |
| leakypipes | sean-k-mooney: right. | 17:04 |
| *** Tom-Tom has quit IRC | 17:05 | |
| leakypipes | sean-k-mooney: plus, keep in mind the allocation_requests and the provider_summaries sections of GET /allocation_candidates response are different things... the former section is the providers that would be actually allocated against. the latter section is just informational. | 17:05 |
| openstackgerrit | Merged openstack/nova master: Use UEFI as the default boot for AArch64 https://review.openstack.org/489951 | 17:06 |
| *** ljjjustin has quit IRC | 17:08 | |
| sean-k-mooney | leakypipes: if the summery is just informational and wont be just to make desision then i dont see any harm in simplfying the representation and just weak referncing the numa afinity of the resouces. | 17:09 |
| leakypipes | sean-k-mooney: could you elaborate on what you mean by that? | 17:09 |
| leakypipes | sean-k-mooney: the numa affinity of the PFs is not a tag/trait. rather, it's the structure of the tree itself. | 17:10 |
| sean-k-mooney | leakypipes: if the provider_summaries was used by a weigher for example then it would be good to keep the numa afinity info in the summary however if the chose beteewn which allocation candiate is made based on the tree structure then the summary could be less detailed | 17:12 |
| melwitt | mriedem_luncharo: nevermind, my question is answered in your review comment | 17:12 |
| leakypipes | sean-k-mooney: understood. | 17:14 |
| leakypipes | thx | 17:14 |
| *** jafeha__ has joined #openstack-nova | 17:14 | |
| *** jafeha has quit IRC | 17:16 | |
| *** jafeha__ has quit IRC | 17:20 | |
| *** markmcclain has quit IRC | 17:20 | |
| *** markmcclain has joined #openstack-nova | 17:21 | |
| *** pcaruana has quit IRC | 17:21 | |
| *** dtantsur is now known as dtantsur|afk | 17:22 | |
| openstackgerrit | Merged openstack/nova stable/pike: Use instance.project_id when creating request specs for old instances https://review.openstack.org/529384 | 17:23 |
| openstackgerrit | Merged openstack/nova stable/pike: Workaround missing RequestSpec.project_id when moving an instance https://review.openstack.org/529385 | 17:24 |
| fried_rice | leakypipes Sorry, was otp. My understanding was that we did intend to include resource *classes* that weren't part of the request. I don't know if we talked about including other unused providers in the same tree. I don't see the harm in doing it, and rather have it and not need it than need it and not have it. But no strong feelings either way. | 17:25 |
| fried_rice | And to be clear, that's in the provider summaries, *not* in the allocations portion. | 17:25 |
| *** damien_r has joined #openstack-nova | 17:28 | |
| *** Guest13421 has quit IRC | 17:28 | |
| *** damien_r1 has quit IRC | 17:29 | |
| leakypipes | fried_rice: ack | 17:30 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Fix race condition in retrying migrations https://review.openstack.org/531022 | 17:30 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436 | 17:30 |
| *** lpetrut has quit IRC | 17:31 | |
| *** Guest13421 has joined #openstack-nova | 17:31 | |
| sean-k-mooney | fried_rice: leakypipes haveing the extra info in the summery could help debuging i guess but do ye enviosion end users reading them directly? e.g. would it be stored in the instance info when you do an openstack server show like the cached flavor or something similar? | 17:33 |
| *** cdent has joined #openstack-nova | 17:33 | |
| sean-k-mooney | leakypipes: fried_rice basically is the summary for people or python? | 17:34 |
| leakypipes | sean-k-mooney: no, this is an admin-only API endpoint that is only for the scheduler to make better decisions. none of this information is available to end users. | 17:35 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: func tests for nested providers in alloc candidate https://review.openstack.org/531443 | 17:35 |
| leakypipes | fried_rice, figleaf, sean-k-mooney: thou comments welcome... ^^ | 17:35 |
| sean-k-mooney | leakypipes: i like that the fist think i see is an ascii diagram of what is about to be tested :) | 17:36 |
| leakypipes | sean-k-mooney: you can thank gibi_away for that practice :) | 17:37 |
| *** danpawlik has quit IRC | 17:37 | |
| sean-k-mooney | leakypipes: out of scope of queens but rocky+ could the VCPU and memory_mb(or perhaps just hugepages) inventories be moved to the numa node resouce providers? | 17:41 |
| leakypipes | sean-k-mooney: possible. definitely something we need to be (very carefully) handle and discuss in Dublion. | 17:42 |
| leakypipes | or even Dublin | 17:42 |
| *** inara has quit IRC | 17:42 | |
| sean-k-mooney | memory_mb is basically the non hugepage memory(e.g. 4k pages) which is basically managed by the kernel auptomatically so may that shoudl stay at the compute node level but vcpus i think would be a gould fit for the numa resouce provider. im just not sure how straight forword it would be do do the db migration required. | 17:44 |
| *** inara has joined #openstack-nova | 17:45 | |
| leakypipes | sean-k-mooney: right | 17:45 |
| cdent | db migration? presumably the resource tracker would intead choose to change the inventory for its tree | 17:46 |
| cdent | we _really_ need to not think of placement as authoritative on that stuff. reality should be. | 17:46 |
| cdent | with placement second | 17:46 |
| cdent | ideally reality should be able to recover all of placement | 17:47 |
| *** yamamoto has quit IRC | 17:47 | |
| leakypipes | fried_rice, figleaf: do you think it would be better to have an entirely different code path in the allocation candidates code when we notice that there are provider trees? you know how we currently have a fast-path for when there are no sharing providers? should we do the same kind of thing for provider trees? | 17:47 |
| leakypipes | cdent: ^^ | 17:47 |
| cdent | my initial reaction is "yes" | 17:48 |
| leakypipes | didn't know you were back from your walkabout... ;) | 17:48 |
| sean-k-mooney | cdent: well what i ment by db migration was going from 1 inventory of all the cpus to n, one per numa node and updating the inventries to match what were actully used | 17:48 |
| cdent | my walkabout was "drive home from the place where that dog was" | 17:48 |
| leakypipes | cdent: yes, as in "separate code path for the provider tree deployments"? | 17:48 |
| *** derekh has quit IRC | 17:48 | |
| cdent | yeah, if only to make it more scrutable | 17:49 |
| leakypipes | ack | 17:49 |
| leakypipes | that was my initial thought as well. | 17:49 |
| cdent | I still kinda wish, however, that there was one single magical sql expression (that we never have to see but we know works) that did the whole thing | 17:50 |
| * cdent likes to dream | 17:50 | |
| sean-k-mooney | leakypipes: as long as the second code path is not like cells v1 and solves a proablem maybe. | 17:50 |
| leakypipes | sean-k-mooney: no, it would be just fancier SQL/Python to determine the results. | 17:51 |
| leakypipes | cdent: there is... but it would be inscrutable... | 17:51 |
| cdent | thus "that we never have to see" | 17:51 |
| leakypipes | heh | 17:51 |
| leakypipes | always remember, all of OpenStack can be rewritten entirely in SQL. | 17:51 |
| cdent | as well as rewritten without any | 17:52 |
| leakypipes | or Golang. | 17:52 |
| sean-k-mooney | leakypipes: you could tripple your consluting fee to debug it if you wrote it lol | 17:52 |
| leakypipes | sean-k-mooney: zero times three is zero. :) | 17:52 |
| SamYaple | leakypipes: you mispelled rust | 17:54 |
| *** Apoorva has joined #openstack-nova | 17:54 | |
| sean-k-mooney | you know if you joke about rewriting openstack in golang 3 times it might summon the Ciao gods... | 17:54 |
| leakypipes | SamYaple: :) | 17:54 |
| leakypipes | SamYaple: you misspelled misspelled. | 17:54 |
| SamYaple | i speel with the best of em | 17:54 |
| leakypipes | :P | 17:54 |
| leakypipes | sean-k-mooney: Beetlejuice! | 17:55 |
| SamYaple | i did start on a libvirt replacement in rust (not 100% replacement, just spawn/monitor qemu process replacement) | 17:55 |
| *** elod has quit IRC | 17:55 | |
| SamYaple | rust is suuuuuuuper ugly syntax wise | 17:55 |
| sean-k-mooney | SamYaple: danial berage is considing that too. or golang | 17:56 |
| *** elod has joined #openstack-nova | 17:56 | |
| SamYaple | im pretty sure i pushed *something* to git about it | 17:56 |
| *** sree has joined #openstack-nova | 17:56 | |
| SamYaple | i had it spawning and interfacing with the monitor socket | 17:56 |
| SamYaple | https://github.com/SamYaple/qemuwatch | 17:56 |
| SamYaple | sean-k-mooney: i would love to not have to use libvirt anymore | 17:57 |
| *** dave-mccowan has quit IRC | 17:57 | |
| sean-k-mooney | SamYaple: there was a faily active thread on the libvirt mailing list back in december not sure if they reached a decision or not | 17:57 |
| leakypipes | SamYaple: libvirt is a fine library. except for the XML. :) | 17:57 |
| SamYaple | leakypipes: and the 500MB of deps needed to compile it | 17:57 |
| leakypipes | SamYaple: the XML deps you mean, yeah? | 17:58 |
| SamYaple | probably. i never dug into why libvirt was such a pita to build from source | 17:58 |
| SamYaple | probably xml :) | 17:58 |
| *** elod has quit IRC | 17:58 | |
| *** elod has joined #openstack-nova | 17:58 | |
| *** amodi has joined #openstack-nova | 17:59 | |
| SamYaple | in truth, i was writing the above to spawn vms in kubernetes, libvirt is a bit overkill for that scenario (container per vm) | 17:59 |
| SamYaple | but i stopped working on it because there are 1001 projects doing that right now and i prefer to get a more openstack native solution going | 17:59 |
| sean-k-mooney | i havent done anything to maintain this since i gave it rodolfo to upstream but this made it less of a pain https://github.com/openstack/devstack-plugin-libvirt-qemu | 18:00 |
| sean-k-mooney | i mean you are replaceing the pain of building libvirt from source with using devstack but at least you get to chose your poision | 18:01 |
| *** lpetrut has joined #openstack-nova | 18:02 | |
| *** lucasagomes is now known as lucas-afk | 18:02 | |
| SamYaple | i just want to use the native qemu interface more directly. live differential backups. add/remove hardware. better metrics. that kind of thing | 18:02 |
| SamYaple | but libvirt will get all that.... eventually.... probably | 18:02 |
| *** yamamoto has joined #openstack-nova | 18:03 | |
| figleaf | win 15 | 18:04 |
| figleaf | ugh | 18:04 |
| leakypipes | SamYaple: ack | 18:05 |
| *** yamamoto has quit IRC | 18:07 | |
| figleaf | leakypipes: +1 on separate code path | 18:08 |
| figleaf | leakypipes: I'd rather avoid lots of nested logic | 18:08 |
| leakypipes | ya | 18:08 |
| *** harlowja has joined #openstack-nova | 18:09 | |
| *** sree has quit IRC | 18:09 | |
| *** mriedem_luncharo is now known as mriedem | 18:17 | |
| *** sree has joined #openstack-nova | 18:17 | |
| *** _pewp_ has quit IRC | 18:20 | |
| *** _pewp_ has joined #openstack-nova | 18:22 | |
| mriedem | melwitt: how required are the dependent os-brick changes for these backports? https://review.openstack.org/#/q/Id188d48609f3d22d14e16c7f6114291d547a8986 | 18:25 |
| mriedem | because we can bump upper-constraints in stable but not global-requirements | 18:25 |
| *** sree has quit IRC | 18:26 | |
| melwitt | mriedem: without the os-brick changes, the 'nova start' after a compute host reboot would fail because the device won't be found during the detach during re-initialization | 18:27 |
| mriedem | hmm | 18:27 |
| mriedem | well then | 18:27 |
| mriedem | i don't think we can backport those then | 18:28 |
| melwitt | I've requested .z release for os-brick stable/pike and stable/ocata, jungleboyj said he can do that next week | 18:28 |
| mriedem | unless you have some compat code in nova to handle os-brick not having that functionality | 18:28 |
| *** damien_r has quit IRC | 18:28 | |
| melwitt | yeah, we can handle the os-brick exit code thing in nova. do you think that's more appropriate for backport land? it would make things easier for me | 18:29 |
| melwitt | I had been thinking we had to go the .z stable release + upper-constraints route | 18:29 |
| *** sree has joined #openstack-nova | 18:30 | |
| mriedem | upper-constraints doesn't mean people are going to use that versoin | 18:30 |
| mriedem | that's what g-r is for | 18:30 |
| mriedem | rhosp can of course require whichever package deps it wants for patch releases, but upstream we generally don't bump the minimum required version of a dependency on stable b/c we have to assume people have already shipped and possibly frozen those deps | 18:31 |
| mriedem | "we can handle the os-brick exit code thing in nova" is probably best, if you can determine the failure and log something like, "make sure you upgrade os-brick to avoid this problem" or whatever | 18:32 |
| melwitt | yeah, I know. I thought it was going to be like, people will get the compatible os-brick because the latest .z release would be picked up automatically. is that not how it works? does it grab the minimum only? | 18:32 |
| mriedem | our CI uses what's in upper-constraints | 18:33 |
| mriedem | we can't assume that's how people deploy though | 18:33 |
| mriedem | at least post-GA | 18:33 |
| melwitt | I see. okay | 18:34 |
| openstackgerrit | sean mooney proposed openstack/os-vif stable/pike: Check if interface belongs to a Linux Bridge before removing https://review.openstack.org/531465 | 18:35 |
| melwitt | the os-brick thing is just that we added an additional exit code for a detach call to ignore, that means "ignore if not found". we can catch that in nova too, from os-brick, and look at the exit code and ignore it if the code == "not found" | 18:35 |
| mriedem | by parsing the message? | 18:35 |
| melwitt | it's just more correct to do the check in os-brick since os-brick is the one making the detach call | 18:36 |
| mriedem | oh | 18:36 |
| melwitt | no | 18:36 |
| mriedem | ok | 18:36 |
| mriedem | well that doesn't seem too terrible | 18:36 |
| melwitt | os-brick will raise ProcessExecutionError and one of the attributes is what exit code it was | 18:36 |
| mriedem | yeah | 18:36 |
| melwitt | yeah, it's not terrible IMHO either | 18:36 |
| *** sambetts is now known as sambetts|afk | 18:37 | |
| *** pooja has joined #openstack-nova | 18:37 | |
| *** damien_r has joined #openstack-nova | 18:37 | |
| pooja | Happy Friday all! I had an upgrade related question for nova database.. is it safe to truncate the nova.reservations table when upgrading the controller? As per my understanding, when there is no instance creation in progress, all rows will always be in soft-deleted state. | 18:38 |
| mriedem | pooja: why not just run the "nova-manage db archive_deleted_rows" CLI? | 18:40 |
| pooja | mriedem: I ran that db command, but it doesn't seem to cleanup reservations table rows | 18:43 |
| mriedem | which release are you on? does the command complete without errors? what value are you using for --max_rows? | 18:45 |
| pooja | I am on Newton release.. Ran the command as - nova-manage --debug --config-file /etc/nova/nova.conf db archive_deleted_rows --max_rows 100 | 18:45 |
| pooja | It didn't throw any errors but I also don't see any logs if it did anything | 18:46 |
| mriedem | --max_rows is likely not a big enough number | 18:46 |
| mriedem | --max_rows is the total number, so if you remove 100 records in the first table processed, you likely are done before getting to the reservations table | 18:47 |
| pooja | ah okay.. I thought that number was per table. Let me try with a higher value | 18:47 |
| mriedem | ildikov: well, running without the pike uca now but n-cpu fails to start because: "libvirtError: Failed to connect socket to '/var/run/libvirt/libvirt-sock': Permission denied" | 18:47 |
| *** sree has quit IRC | 18:47 | |
| *** yamamoto has joined #openstack-nova | 18:48 | |
| mriedem | pooja: you can run it with the --verbose option | 18:48 |
| mriedem | https://github.com/openstack/nova/blob/stable/newton/nova/cmd/manage.py#L836 | 18:48 |
| mriedem | pooja: in ocata there is a --until_complete option too https://github.com/openstack/nova/blob/stable/ocata/nova/cmd/manage.py#L665 | 18:48 |
| mriedem | so you don't have to deal with --max_rows | 18:49 |
| mriedem | you could run that in a venv/container, or backport that change to your internal repo | 18:49 |
| pooja | mriedem: Thanks! Running it with max_rows=1000 couple of times seems to have purged the reservations table. Out of curiosity, is truncating the table safe operation during downtime though? | 18:49 |
| ildikov | mriedem: hmm, I saw this error before but I couldn't tell right now whether it was during testing multi-attach or not | 18:50 |
| mriedem | pooja: archive_deleted_rows takes records where deleted != 0 and moves them to the shadow table, then deletes them from the main table | 18:50 |
| mriedem | shadow tables are named shadow_<table_name> | 18:50 |
| mriedem | so shadow_instances, shadow_reservations, etc | 18:50 |
| mriedem | ildikov: i have a feeling it's related to not using pike uca | 18:50 |
| mriedem | pooja: archive deleted records should be safe about any time, but yeah certainly during downtime/maintenance | 18:50 |
| mriedem | *downtime of the control plane | 18:50 |
| ildikov | mriedem: in what sense do you mean? | 18:51 |
| mriedem | ildikov: that's the only thing that's different about this CI run, | 18:51 |
| mriedem | is that it's not using the pike uca, which is the default in devstack - so i'm guessing maybe something changed in devstack and implicitly relied on newer libvirt/qemu, | 18:51 |
| mriedem | and now doesn't work if you're not using that | 18:51 |
| pooja | Got it.. makes sense. It may be a good practice to run archive_deleted_rows periodically as a cronjob with low max_rows count such that there is no visible performance impact then? | 18:52 |
| ildikov | mriedem: I was just wondering what's different in the setup that can lead to a permission denied error | 18:52 |
| mriedem | could be that libvirtd isn't even running | 18:52 |
| mriedem | pooja: i'd ask that in the #openstack-operators channel or mailing list | 18:52 |
| mriedem | to see what other operators are doing | 18:52 |
| *** yamamoto has quit IRC | 18:52 | |
| pooja | mriedem: Sounds good, will do that. Thanks a lot for your help! | 18:53 |
| mriedem | yw | 18:53 |
| *** gszasz has quit IRC | 18:53 | |
| mriedem | looks like libvirtd is running http://logs.openstack.org/86/531386/2/check/tempest-full/4eacc3c/controller/logs/libvirt/ | 18:53 |
| *** damien_r has quit IRC | 18:54 | |
| mriedem | hmm | 18:56 |
| mriedem | 2018-01-05 16:50:52.125+0000: 11136: error : virSecurityDriverLookup:80 : unsupported configuration: Security driver apparmor not enabled | 18:56 |
| *** damien_r has joined #openstack-nova | 18:58 | |
| *** damien_r has joined #openstack-nova | 18:58 | |
| mriedem | hmm https://review.openstack.org/#/c/451492/ | 18:59 |
| SamYaple | ive definetely seen that error | 19:00 |
| SamYaple | alot | 19:00 |
| mriedem | which version? | 19:00 |
| mriedem | or maybe we just don't care about the apparmor error | 19:00 |
| ildikov | there are a couple other errors there too | 19:01 |
| SamYaple | mriedem: primarily on 14.04, but that would have been with UCA libvirt 1.3.1 | 19:01 |
| SamYaple | mriedem: ive seen it on 16.04 too, but only when some old 14.04 configs werent cleaned up properly | 19:01 |
| mriedem | this is xenial so 1.3.1 | 19:01 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: add _has_provider_trees() utility function https://review.openstack.org/531474 | 19:01 |
| SamYaple | i do not see it when running libvirt in containers with UCA libvirt | 19:02 |
| mriedem | ii libvirt-bin 1.3.1-1ubuntu10.15 | 19:02 |
| SamYaple | yep, thats the version ive seen it with, but it was 14.04 with mitaka UCA | 19:02 |
| mriedem | this is just devstack with ENABLE_UBUNTU_CLOUD_ARCHIVE=False | 19:03 |
| SamYaple | now that were talking about this, i dont know if that error broke anything, i just remember seeing it | 19:03 |
| SamYaple | it could be a red herring | 19:03 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add access_url_base to console_auth_tokens table https://review.openstack.org/334614 | 19:06 |
| openstackgerrit | melanie witt proposed openstack/nova master: Optionalize instance_uuid in console_auth_token_get_valid() https://review.openstack.org/481700 | 19:06 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add ConsoleAuthToken object https://review.openstack.org/320063 | 19:06 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add periodic task to clean expired console tokens https://review.openstack.org/325381 | 19:06 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use ConsoleAuthToken object to generate authorizations https://review.openstack.org/325414 | 19:06 |
| openstackgerrit | melanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation https://review.openstack.org/333990 | 19:06 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add index on token_hash and instance_uuid for console_auth_tokens https://review.openstack.org/531477 | 19:06 |
| clarkb | mriedem: SamYaple the issue with non UCA libvirt was segfaulting and other memory access faults | 19:06 |
| clarkb | when we upgraded to UCA libvirt those went away (not sure if that is helpful) | 19:07 |
| mriedem | clarkb: i'm getting a permission denied error on startup | 19:07 |
| mriedem | connecting to libvirt-sock | 19:07 |
| clarkb | mriedem: thats the group issue I think | 19:07 |
| clarkb | (I thought we handled both possible groups but maybe that is broken?) | 19:07 |
| mriedem | clarkb: right i was looking at this https://review.openstack.org/#/c/451492/15/stackrc | 19:07 |
| SamYaple | clarkb: that helps me, and i think its safe to ignore those apparmor issues fwiw | 19:07 |
| clarkb | SamYaple: we never root caused the memory issues because upstream basically said EOLD and upgrade | 19:08 |
| melwitt | mriedem: when I separate the index add, is it supposed to get its own migration file under migrate_repo/versions/? | 19:08 |
| mriedem | melwitt: yeah it would have to | 19:08 |
| melwitt | oops. okay | 19:08 |
| SamYaple | clarkb: upstream as in libvirt? or ubuntu? because ubuntu should be fixing that for the next 3(?) years or so | 19:08 |
| SamYaple | clarkb: did you pop a bug with canonical? | 19:08 |
| clarkb | SamYaple: upstream as in libvirt, ya we filed a bug against canonical/ubuntu | 19:09 |
| mriedem | hmm, do we not have a worlddump anymore? | 19:09 |
| mriedem | did that dump the groups? | 19:09 |
| *** openstack has joined #openstack-nova | 21:15 | |
| *** ChanServ sets mode: +o openstack | 21:15 | |
| dansmith | and I dunno what to do with the randomize thing.. maybe also a flag about whether to do that or not (spread/pack) ? | 21:15 |
| mriedem | dansmith: that's in that change | 21:15 |
| mriedem | so that's already done | 21:15 |
| dansmith | oh, | 21:16 |
| leakypipes | dansmith: that's already there. | 21:16 |
| dansmith | placement has a config not a query param for the randomize? | 21:16 |
| mriedem | i think the idea being, if your limit is smaller, you do random, and if it's bigger, you don't | 21:16 |
| leakypipes | sorry, that's why I was confused :) | 21:16 |
| dansmith | gotcha | 21:16 |
| mriedem | dansmith: correct | 21:16 |
| mriedem | does seem like it should be a per-request on the client side thing | 21:16 |
| dansmith | right I hadn't actually paid attention to that part | 21:16 |
| mriedem | config-driven api behavior | 21:16 |
| dansmith | the randomize? I would have kinda thought so, since cinder and nova might have different requirements for which 1000 to return | 21:17 |
| mriedem | yeah | 21:17 |
| mriedem | welp, i guess that's a future improvement for rocky | 21:17 |
| dansmith | yeah, that's what I had been assuming, but it | 21:17 |
| dansmith | is something we can do later | 21:17 |
| dansmith | yeah | 21:17 |
| *** jose-phillips has quit IRC | 21:17 | |
| mriedem | i wonder if we'd want to make the limit option on the nova side a multiple of the number of instances to build in a given request...or is that getting too cute? | 21:18 |
| *** jose-phillips has joined #openstack-nova | 21:18 | |
| dansmith | opens a DoS though | 21:18 |
| mriedem | true | 21:19 |
| dansmith | I would make it static and then if people need cuteness, we can ask for safe suggestions | 21:19 |
| *** smatzek has quit IRC | 21:20 | |
| mriedem | alright, now how to track this - could do it against the blueprint if someone is going to work on it now, else i can open a bug since it's kind of a bug on the nova side that we don't limit | 21:20 |
| mriedem | i'm sure no one cares about that tracking business except me | 21:20 |
| dansmith | I can cook up a patch while you decide how to appease your paperwork fetish | 21:20 |
| mriedem | cool, because i'm already getting rashy | 21:20 |
| *** smatzek has joined #openstack-nova | 21:20 | |
| *** tonyb has quit IRC | 21:21 | |
| edmondsw | the placement api-ref isn't linked from https://developer.openstack.org/api-guide/quick-start/ ... is that intentional or an oversight? | 21:21 |
| *** smatzek has quit IRC | 21:25 | |
| fried_rice | mriedem leakypipes dansmith FYI using GET /allocation_candidates limiting is on the sched mtg agenda for Monday. | 21:27 |
| leakypipes | cool, thanks | 21:27 |
| leakypipes | edmondsw: good question... | 21:28 |
| mriedem | edmondsw: likely an oversight | 21:28 |
| mriedem | edmondsw: you should totally add that | 21:28 |
| edmondsw | mriedem leakypipes alright, will do | 21:29 |
| *** jose-phillips has quit IRC | 21:29 | |
| *** lpetrut has quit IRC | 21:29 | |
| *** jose-phillips has joined #openstack-nova | 21:29 | |
| *** lpetrut has joined #openstack-nova | 21:30 | |
| dansmith | I look forward to the rash of "you didn't write this conf option help text right" comments | 21:35 |
| leakypipes | :w | 21:36 |
| openstackgerrit | Merged openstack/nova master: VMware: add support for different firmwares https://review.openstack.org/448034 | 21:40 |
| *** sree has joined #openstack-nova | 21:44 | |
| *** tidwellr has joined #openstack-nova | 21:45 | |
| *** gouthamr has joined #openstack-nova | 21:47 | |
| *** Apoorva has joined #openstack-nova | 21:48 | |
| *** tidwellr has quit IRC | 21:48 | |
| *** dave-mccowan has quit IRC | 21:50 | |
| openstackgerrit | Merged openstack/nova stable/pike: Retry _trait_sync on deadlock https://review.openstack.org/528094 | 21:52 |
| *** jose-phillips has quit IRC | 21:55 | |
| *** Apoorva_ has joined #openstack-nova | 21:56 | |
| *** sree has quit IRC | 21:58 | |
| *** jose-phillips has joined #openstack-nova | 21:59 | |
| *** Apoorva has quit IRC | 21:59 | |
| *** sree has joined #openstack-nova | 22:02 | |
| *** yamamoto has joined #openstack-nova | 22:04 | |
| *** sree has quit IRC | 22:06 | |
| *** gouthamr has quit IRC | 22:07 | |
| *** sree has joined #openstack-nova | 22:10 | |
| *** gouthamr has joined #openstack-nova | 22:12 | |
| mriedem | stvnoyes: tempest patch updated with the detach logic and todos for more tests https://review.openstack.org/266605 | 22:12 |
| dansmith | hmm, between 1.10 and 1.16 /allocation_candidates result changed ? | 22:13 |
| *** gouthamr has quit IRC | 22:15 | |
| *** gouthamr has joined #openstack-nova | 22:16 | |
| *** jose-phillips has quit IRC | 22:16 | |
| *** gouthamr has quit IRC | 22:16 | |
| *** yamamoto has quit IRC | 22:17 | |
| figleaf | dansmith: yep - https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/microversion.py#L52-L55 | 22:18 |
| dansmith | yeah | 22:18 |
| dansmith | figleaf: have links to what they looked like before/after? | 22:18 |
| dansmith | I would go for api_samples normally | 22:19 |
| *** edmondsw has quit IRC | 22:22 | |
| *** sree has quit IRC | 22:22 | |
| *** edmondsw has joined #openstack-nova | 22:23 | |
| figleaf | dansmith: IIRC, they were identical, with only the addition of 'project_id' and 'user_id' | 22:26 |
| figleaf | dansmith: but no, I don't have such links handy | 22:26 |
| dansmith | figleaf: no i think the "format now matches that of get" was more of a change | 22:26 |
| *** edmondsw has quit IRC | 22:26 | |
| dansmith | I'm getting some issues that are related to trying to treat an array like a dict | 22:26 |
| *** smatzek has joined #openstack-nova | 22:27 | |
| *** sree has joined #openstack-nova | 22:27 | |
| fried_rice | leakypipes Looks like today we don't handle RP generation when we update aggregates. | 22:28 |
| fried_rice | leakypipes At least according to the API ref as it stands. I think that's a problem. | 22:28 |
| *** jose-phillips has joined #openstack-nova | 22:29 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: _get_trees_matching_all() https://review.openstack.org/531512 | 22:30 |
| leakypipes | fried_rice: add it as an item on Monday? | 22:30 |
| fried_rice | leakypipes Ight. | 22:30 |
| fried_rice | leakypipes It comes into play in the discussion around coordinating shared providers from multiple compute nodes | 22:30 |
| leakypipes | ack | 22:31 |
| fried_rice | Unless the agg UUIDs are deterministic, we absolutely need generation handling there. | 22:31 |
| *** smatzek has quit IRC | 22:32 | |
| leakypipes | fried_rice: to be discussed :) (I am heading off for dinner...) | 22:32 |
| fried_rice | leakypipes Enjoy | 22:32 |
| mriedem | dansmith: https://developer.openstack.org/api-ref/placement/#list-allocation-candidates | 22:34 |
| dansmith | oh I didn't realize both versions were in there | 22:35 |
| dansmith | awesome | 22:35 |
| mriedem | lbragstad: looks like your patch fixes the issue http://logs.openstack.org/97/531497/2/check/legacy-tempest-dsvm-neutron-src/a196420/logs/screen-n-cpu.txt.gz?level=WARNING | 22:38 |
| mriedem | lbragstad: my question was really, let's say nova has 10 deprecated policies in code, | 22:39 |
| mriedem | and i've overridden one of those deprecated policy rules in my policy.yaml, | 22:39 |
| mriedem | but not the other 9 | 22:39 |
| mriedem | will i see warnings about all 10, or just the 1 that overrode the default? | 22:39 |
| lbragstad | you will see a warning for the one you overrode | 22:39 |
| mriedem | ok i figured self.file_rules was just checking if there are any | 22:40 |
| mriedem | but not specific ones | 22:40 |
| lbragstad | that's what https://review.openstack.org/#/c/531497/2/oslo_policy/tests/test_policy.py@1004 tests for | 22:40 |
| lbragstad | since that specific test isn't writing a temp file for policy rules (or overrides) | 22:40 |
| mriedem | oh duh | 22:41 |
| mriedem | default.name in self.file_rules | 22:41 |
| mriedem | i didn't realize it was looping over the rules | 22:41 |
| lbragstad | yup | 22:41 |
| lbragstad | yeah - it goes through everything | 22:41 |
| *** amodi has quit IRC | 22:41 | |
| mriedem | +1 | 22:41 |
| mriedem | thanks | 22:41 |
| lbragstad | and logs a single warning (so warnings aren't constantly emitted every time a poilcy is run through enforce()) | 22:41 |
| lbragstad | no problem - thanks for raising the issue | 22:42 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: [libvirt] Allow multiple volume attachments https://review.openstack.org/267587 | 22:42 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass multiattach flag to reserve_block_device_name https://review.openstack.org/531244 | 22:42 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: [api] Allow multi-attach in compute api https://review.openstack.org/271047 | 22:42 |
| *** jose-phillips has quit IRC | 22:42 | |
| *** burt has quit IRC | 22:44 | |
| *** hongbin has quit IRC | 22:46 | |
| dansmith | bah, have to figure that format thing out on monday | 22:48 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Pass limit to /allocation_requests https://review.openstack.org/531517 | 22:48 |
| *** lyan has quit IRC | 22:48 | |
| *** slaweq_ has quit IRC | 22:48 | |
| *** sree has quit IRC | 22:49 | |
| *** sree has joined #openstack-nova | 22:53 | |
| *** amodi has joined #openstack-nova | 22:57 | |
| *** sree has quit IRC | 22:58 | |
| *** vishwanathj has quit IRC | 22:59 | |
| *** figleaf is now known as edleafe | 23:01 | |
| *** sree has joined #openstack-nova | 23:02 | |
| *** david-lyle has joined #openstack-nova | 23:04 | |
| *** sree has quit IRC | 23:07 | |
| *** sree has joined #openstack-nova | 23:11 | |
| *** markmc has quit IRC | 23:11 | |
| *** ltomasbo has quit IRC | 23:11 | |
| *** moshele has joined #openstack-nova | 23:13 | |
| *** jpena|off has quit IRC | 23:14 | |
| *** sree has quit IRC | 23:15 | |
| *** lpetrut has quit IRC | 23:19 | |
| *** lpetrut has joined #openstack-nova | 23:20 | |
| *** moshele has quit IRC | 23:21 | |
| *** sree has joined #openstack-nova | 23:23 | |
| *** sree has quit IRC | 23:28 | |
| *** lpetrut has quit IRC | 23:28 | |
| *** Apoorva_ has quit IRC | 23:28 | |
| *** ltomasbo has joined #openstack-nova | 23:30 | |
| *** vishwanathj has joined #openstack-nova | 23:31 | |
| *** sree has joined #openstack-nova | 23:32 | |
| *** esberglu has quit IRC | 23:34 | |
| *** markmc has joined #openstack-nova | 23:34 | |
| *** esberglu has joined #openstack-nova | 23:34 | |
| *** gyee has quit IRC | 23:35 | |
| *** stvnoyes has quit IRC | 23:35 | |
| *** esberglu has quit IRC | 23:39 | |
| *** slaweq has joined #openstack-nova | 23:39 | |
| *** slaweq has quit IRC | 23:44 | |
| *** sree has quit IRC | 23:44 | |
| *** jackie-truong_ has joined #openstack-nova | 23:45 | |
| *** sree has joined #openstack-nova | 23:45 | |
| *** jackie-truong has quit IRC | 23:48 | |
| *** liverpooler has quit IRC | 23:48 | |
| *** liverpooler has joined #openstack-nova | 23:50 | |
| *** jackie-truong_ has quit IRC | 23:52 | |
| *** jose-phillips has joined #openstack-nova | 23:52 | |
| *** Guest13421 has quit IRC | 23:57 | |
| *** sdague has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!