| *** jmlowe has quit IRC | 00:00 | |
| *** edmondsw has quit IRC | 00:00 | |
| *** jmlowe has joined #openstack-nova | 00:01 | |
| openstackgerrit | Hironori Shiina proposed openstack/nova master: [WIP] Ironic: Get IP address for volume connector from ports/portgroups https://review.openstack.org/517322 | 00:03 |
|---|---|---|
| *** hshiina has joined #openstack-nova | 00:12 | |
| *** suresh12 has joined #openstack-nova | 00:14 | |
| *** hoonetorg has quit IRC | 00:15 | |
| openstackgerrit | Hironori Shiina proposed openstack/nova master: Ironic: Get IP address for volume connector from ports/portgroups https://review.openstack.org/517322 | 00:16 |
| *** hoonetorg has joined #openstack-nova | 00:16 | |
| *** felipemonteiro has joined #openstack-nova | 00:19 | |
| *** jobewan has quit IRC | 00:23 | |
| *** yamamoto has quit IRC | 00:24 | |
| *** yamamoto has joined #openstack-nova | 00:27 | |
| *** armax has joined #openstack-nova | 00:31 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | 00:32 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in delete (2) https://review.openstack.org/526263 | 00:34 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in delete (3) https://review.openstack.org/526557 | 00:34 |
| *** browne has joined #openstack-nova | 00:36 | |
| *** browne has quit IRC | 00:36 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | 00:38 |
| *** yamamoto has quit IRC | 00:39 | |
| *** tetsuro has joined #openstack-nova | 00:41 | |
| *** liuzz_ has quit IRC | 00:42 | |
| *** liuzz has joined #openstack-nova | 00:42 | |
| *** claudiub has quit IRC | 00:43 | |
| *** sree has joined #openstack-nova | 00:43 | |
| *** Dinesh_Bhor has joined #openstack-nova | 00:46 | |
| *** sree has quit IRC | 00:48 | |
| *** jichen has joined #openstack-nova | 00:51 | |
| *** jamiec has quit IRC | 00:52 | |
| *** lyan has joined #openstack-nova | 00:58 | |
| *** hiro-kobayashi has joined #openstack-nova | 00:58 | |
| *** jamiec has joined #openstack-nova | 00:59 | |
| *** mvk has quit IRC | 01:01 | |
| *** tidwellr has joined #openstack-nova | 01:02 | |
| *** threestrands has quit IRC | 01:03 | |
| *** zhaochao has joined #openstack-nova | 01:04 | |
| *** phuongnh has joined #openstack-nova | 01:08 | |
| *** Dinesh_Bhor has quit IRC | 01:19 | |
| *** slaweq_ has joined #openstack-nova | 01:21 | |
| *** mdnadeem has joined #openstack-nova | 01:22 | |
| *** slaweq_ has quit IRC | 01:25 | |
| *** Dinesh_Bhor has joined #openstack-nova | 01:26 | |
| *** masayukig_ has quit IRC | 01:28 | |
| *** masayukig has joined #openstack-nova | 01:30 | |
| *** zhurong has joined #openstack-nova | 01:34 | |
| *** kumarmn has joined #openstack-nova | 01:34 | |
| *** felipemonteiro has quit IRC | 01:35 | |
| *** kumarmn has quit IRC | 01:35 | |
| Kevin_Zheng | It seems to me that this one is useless https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2304 | 01:39 |
| *** yamamoto has joined #openstack-nova | 01:39 | |
| Kevin_Zheng | since fixed_ip is not considered as an valid filter both in schema and api-ref | 01:39 |
| Kevin_Zheng | after remap, its value is put into filters['ip'] | 01:40 |
| Kevin_Zheng | as we consider 'ip' and 'ip6' as valid filters | 01:40 |
| Kevin_Zheng | those values didn't got remapped as what has been done for fixed_ip filter | 01:41 |
| Kevin_Zheng | seems strange to me | 01:41 |
| *** rcernin has quit IRC | 01:42 | |
| *** edmondsw has joined #openstack-nova | 01:44 | |
| *** yamamoto has quit IRC | 01:47 | |
| *** edmondsw has quit IRC | 01:48 | |
| *** markvoelker has joined #openstack-nova | 01:50 | |
| *** rcernin has joined #openstack-nova | 01:50 | |
| *** Dinesh_Bhor has quit IRC | 01:52 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Use neutron port_list when filtering instance by ip https://review.openstack.org/525505 | 01:53 |
| *** Apoorva has quit IRC | 01:58 | |
| *** mlavalle has quit IRC | 01:58 | |
| *** lyan has quit IRC | 02:00 | |
| *** moshele has joined #openstack-nova | 02:01 | |
| *** kumarmn has joined #openstack-nova | 02:02 | |
| *** kumarmn has quit IRC | 02:04 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:08 | |
| Kevin_Zheng | mriedem alex_xu ^^ | 02:09 |
| Kevin_Zheng | I mean the fixed_ip thing | 02:09 |
| *** gouthamr has joined #openstack-nova | 02:10 | |
| *** annp has joined #openstack-nova | 02:11 | |
| *** Apoorva has joined #openstack-nova | 02:14 | |
| *** gouthamr_ has joined #openstack-nova | 02:15 | |
| *** gouthamr has quit IRC | 02:15 | |
| *** yamahata has joined #openstack-nova | 02:18 | |
| *** namnh has joined #openstack-nova | 02:18 | |
| mriedem | Kevin_Zheng: we should probably have a release note for that, | 02:19 |
| *** gouthamr_ has quit IRC | 02:19 | |
| mriedem | something about how nova will proxy ip filtering to neutron as long as the neutron extension is available | 02:19 |
| *** yamamoto has joined #openstack-nova | 02:19 | |
| *** Apoorva has quit IRC | 02:19 | |
| Kevin_Zheng | OK | 02:19 |
| mriedem | you can do that on top | 02:19 |
| mriedem | so you don't lose jay's +2 | 02:19 |
| Kevin_Zheng | OK | 02:19 |
| Kevin_Zheng | what do you think about the fixed_ip thing? | 02:20 |
| Kevin_Zheng | I was mislead by it at the beginning | 02:20 |
| mriedem | i'm not sure what you're referring to | 02:21 |
| Kevin_Zheng | It seems to me that this one is useless https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2304 | 02:21 |
| Kevin_Zheng | since fixed_ip is not considered as an valid filter both in schema and api-ref | 02:21 |
| Kevin_Zheng | 09:38 after remap, its value is put into filters['ip'] | 02:21 |
| Kevin_Zheng | 09:39 as we consider 'ip' and 'ip6' as valid filters | 02:21 |
| Kevin_Zheng | 09:39 those values didn't got remapped as what has been done for fixed_ip filter | 02:21 |
| Kevin_Zheng | 09:39 seems strange to me | 02:21 |
| mriedem | the schema won't block it though | 02:22 |
| mriedem | because additionalProperties=True | 02:22 |
| Kevin_Zheng | yeah | 02:22 |
| mriedem | otherwise yes i agree the fixed_ip filter mapping doesn't really make sense | 02:22 |
| mriedem | but i wouldn't propose removing that in this same change | 02:22 |
| Kevin_Zheng | but why it has been mapped but ip and ip6 didn't | 02:23 |
| mriedem | no idea | 02:23 |
| Kevin_Zheng | is what I'm curious about | 02:23 |
| mriedem | probably was written 6 years ago | 02:23 |
| mriedem | it could predate the ip/ip6 filters | 02:23 |
| Kevin_Zheng | yeah, I checked the history | 02:23 |
| mriedem | or was a rackspace only thing | 02:23 |
| mriedem | who knows | 02:23 |
| *** gouthamr has joined #openstack-nova | 02:23 | |
| Kevin_Zheng | seems for ec2 | 02:23 |
| mriedem | ah ok | 02:24 |
| Kevin_Zheng | so probably just leave it alone | 02:24 |
| mriedem | yeah i would | 02:25 |
| mriedem | i don't see anything obvious about it in here though https://github.com/openstack/ec2-api/blob/master/ec2api/api/instance.py | 02:25 |
| openstackgerrit | Chen Hanxiao proposed openstack/nova master: libvirt: add Linux distribution guest only description for inject_xxx options https://review.openstack.org/528441 | 02:28 |
| *** kwathore has quit IRC | 02:28 | |
| *** suresh12 has quit IRC | 02:28 | |
| mriedem | Kevin_Zheng: comments inline | 02:29 |
| *** kwathore has joined #openstack-nova | 02:29 | |
| mriedem | easy stuff though | 02:29 |
| mriedem | looks really good otherwise | 02:29 |
| Kevin_Zheng | I missread | 02:30 |
| Kevin_Zheng | it has a logic bellow in the previous code in 2011 | 02:30 |
| Kevin_Zheng | and it says ec2 specific | 02:30 |
| mriedem | you said the neutron extension wasn't being caught when you did the performance test right? | 02:31 |
| mriedem | that's probably because the neutron patch changed the name to "IP address substring filtering" | 02:31 |
| Kevin_Zheng | yeah | 02:31 |
| Kevin_Zheng | It should be OK now | 02:31 |
| mriedem | https://review.openstack.org/#/c/521683/19/neutron/extensions/ip_substring_port_filtering_lib.py#34 | 02:32 |
| mriedem | you're using the old ext name in the nova patch | 02:32 |
| mriedem | https://review.openstack.org/#/c/521683/19/neutron/extensions/ip_substring_port_filtering_lib.py@34 | 02:32 |
| Kevin_Zheng | oh, no | 02:33 |
| Kevin_Zheng | the previous error was in neutron | 02:33 |
| Kevin_Zheng | it cannot list the new extension | 02:33 |
| Kevin_Zheng | because the name is not correct, in neutron | 02:33 |
| Kevin_Zheng | now it is good | 02:33 |
| *** suresh12 has joined #openstack-nova | 02:34 | |
| Kevin_Zheng | I will change the name in nova | 02:34 |
| mriedem | ok | 02:34 |
| mriedem | add the missing tests and release note and i think it's ready | 02:34 |
| mriedem | i can't +2 b/c i'm co-author though | 02:34 |
| *** Dinesh_Bhor has quit IRC | 02:36 | |
| *** markvoelker has quit IRC | 02:36 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:36 | |
| *** yamahata has quit IRC | 02:38 | |
| *** suresh12 has quit IRC | 02:38 | |
| *** yamahata has joined #openstack-nova | 02:38 | |
| mriedem | alex_xu: i addressed your issue on that migrations changes-since thing https://review.openstack.org/#/c/330406/ - also found a couple of issues in the unit tests that were already in there, so fixed those as well | 02:39 |
| *** gouthamr has quit IRC | 02:40 | |
| mriedem | CI has been way backed up all day though | 02:40 |
| *** hongbin has joined #openstack-nova | 02:44 | |
| *** tidwellr has quit IRC | 02:46 | |
| *** tidwellr has joined #openstack-nova | 02:46 | |
| *** threestrands has joined #openstack-nova | 02:47 | |
| *** threestrands has quit IRC | 02:47 | |
| *** threestrands has joined #openstack-nova | 02:47 | |
| *** tidwellr has quit IRC | 02:50 | |
| *** yamahata has quit IRC | 02:54 | |
| *** mriedem has quit IRC | 02:56 | |
| *** moshele has quit IRC | 02:58 | |
| *** suresh12 has joined #openstack-nova | 02:59 | |
| *** Dinesh_Bhor has quit IRC | 03:01 | |
| *** masber has quit IRC | 03:02 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | 03:03 |
| *** suresh12 has quit IRC | 03:03 | |
| *** masber has joined #openstack-nova | 03:05 | |
| *** yamamoto_ has joined #openstack-nova | 03:12 | |
| *** yamamoto has quit IRC | 03:16 | |
| *** gyee has quit IRC | 03:16 | |
| *** felipemonteiro has joined #openstack-nova | 03:18 | |
| *** harlowja_ has quit IRC | 03:21 | |
| *** slaweq_ has joined #openstack-nova | 03:21 | |
| *** slaweq_ has quit IRC | 03:26 | |
| *** kumarmn has joined #openstack-nova | 03:28 | |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP: add zvm document into https://review.openstack.org/532720 | 03:33 |
| *** vladikr has quit IRC | 03:45 | |
| *** kumarmn has quit IRC | 03:54 | |
| *** abhishekk has joined #openstack-nova | 03:54 | |
| *** felipemonteiro has quit IRC | 03:57 | |
| *** diga has joined #openstack-nova | 03:59 | |
| *** kumarmn has joined #openstack-nova | 04:03 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:05 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Use neutron port_list when filtering instance by ip https://review.openstack.org/525505 | 04:07 |
| *** diga has quit IRC | 04:08 | |
| *** kumarmn has quit IRC | 04:09 | |
| *** kumarmn has joined #openstack-nova | 04:09 | |
| *** esberglu has quit IRC | 04:10 | |
| *** kumarmn has quit IRC | 04:10 | |
| *** kumarmn has joined #openstack-nova | 04:11 | |
| *** zhurong has quit IRC | 04:12 | |
| *** felipemonteiro has joined #openstack-nova | 04:15 | |
| *** kumarmn has quit IRC | 04:16 | |
| *** sree has joined #openstack-nova | 04:21 | |
| *** armax has quit IRC | 04:24 | |
| *** links has joined #openstack-nova | 04:25 | |
| *** hiro-kobayashi has quit IRC | 04:26 | |
| *** kumarmn has joined #openstack-nova | 04:28 | |
| *** andreas_s has joined #openstack-nova | 04:32 | |
| *** karthiks has joined #openstack-nova | 04:33 | |
| *** andreas_s has quit IRC | 04:37 | |
| *** Dinesh_Bhor has quit IRC | 04:38 | |
| *** kumarmn has quit IRC | 04:38 | |
| *** felipemonteiro has quit IRC | 04:39 | |
| *** kumarmn has joined #openstack-nova | 04:39 | |
| *** tuanla____ has joined #openstack-nova | 04:41 | |
| *** kumarmn has quit IRC | 04:44 | |
| *** diga has joined #openstack-nova | 04:45 | |
| *** suresh12 has joined #openstack-nova | 04:45 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:53 | |
| *** Dinesh_Bhor has quit IRC | 04:56 | |
| *** links has quit IRC | 04:56 | |
| *** links has joined #openstack-nova | 04:57 | |
| *** suresh12 has quit IRC | 04:58 | |
| *** suresh12 has joined #openstack-nova | 04:58 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:58 | |
| *** hshiina has quit IRC | 05:00 | |
| *** ratailor has joined #openstack-nova | 05:06 | |
| *** janki has joined #openstack-nova | 05:07 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add a warning in 'nova-manage cell_v2 delete_cell' https://review.openstack.org/513771 | 05:11 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | 05:11 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix missing marker functions https://review.openstack.org/514579 | 05:12 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add functional tests for traits API https://review.openstack.org/524094 | 05:13 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add functional tests for traits API https://review.openstack.org/524094 | 05:14 |
| *** itlinux has quit IRC | 05:14 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Move body examples to an isolated directory https://review.openstack.org/529998 | 05:15 |
| *** claudiub has joined #openstack-nova | 05:15 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller https://review.openstack.org/347289 | 05:16 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/pike: Add 'delete_host' command in 'nova-manage cell_v2' https://review.openstack.org/513717 | 05:18 |
| *** sree has quit IRC | 05:19 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix the order of target host checks https://review.openstack.org/526225 | 05:19 |
| *** edmondsw has joined #openstack-nova | 05:20 | |
| *** psachin has joined #openstack-nova | 05:21 | |
| *** edmondsw has quit IRC | 05:24 | |
| *** psachin has quit IRC | 05:27 | |
| *** zhurong has joined #openstack-nova | 05:28 | |
| *** rcernin has quit IRC | 05:29 | |
| *** harlowja has joined #openstack-nova | 05:29 | |
| *** sree has joined #openstack-nova | 05:29 | |
| *** gcb has quit IRC | 05:30 | |
| *** gcb has joined #openstack-nova | 05:31 | |
| *** hongbin has quit IRC | 05:32 | |
| *** sridharg has joined #openstack-nova | 05:32 | |
| *** psachin has joined #openstack-nova | 05:35 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483 | 05:42 |
| *** hiro-kobayashi has joined #openstack-nova | 05:44 | |
| *** markvoelker has joined #openstack-nova | 05:47 | |
| *** karthiks has quit IRC | 05:50 | |
| *** Dinesh_Bhor has quit IRC | 05:52 | |
| *** suresh12 has quit IRC | 05:54 | |
| *** xinliang has quit IRC | 05:56 | |
| *** Dinesh_Bhor has joined #openstack-nova | 05:56 | |
| *** Tom-Tom has joined #openstack-nova | 05:57 | |
| *** moshele has joined #openstack-nova | 05:58 | |
| *** sandanar has joined #openstack-nova | 05:58 | |
| *** karthiks has joined #openstack-nova | 06:02 | |
| *** Dinesh_Bhor has quit IRC | 06:04 | |
| *** hoonetorg has quit IRC | 06:08 | |
| *** xinliang has joined #openstack-nova | 06:08 | |
| *** slaweq has joined #openstack-nova | 06:09 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in post https://review.openstack.org/526823 | 06:09 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (1) https://review.openstack.org/531258 | 06:10 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (2) https://review.openstack.org/531266 | 06:10 |
| *** Dinesh_Bhor has joined #openstack-nova | 06:12 | |
| *** slaweq has quit IRC | 06:13 | |
| *** suresh12 has joined #openstack-nova | 06:14 | |
| *** Dinesh_Bhor has quit IRC | 06:17 | |
| *** hoonetorg has joined #openstack-nova | 06:20 | |
| *** Eran_Kuris has joined #openstack-nova | 06:24 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (3) https://review.openstack.org/531280 | 06:28 |
| *** suresh12 has quit IRC | 06:30 | |
| *** Dinesh_Bhor has joined #openstack-nova | 06:32 | |
| *** moshele has quit IRC | 06:37 | |
| *** annp has quit IRC | 06:38 | |
| *** lajoskatona has joined #openstack-nova | 06:40 | |
| *** markvoelker has quit IRC | 06:40 | |
| openstackgerrit | Chen Hanxiao proposed openstack/nova master: libvirt: add Linux distribution guest only description for inject_xxx options https://review.openstack.org/528441 | 06:41 |
| *** markvoelker has joined #openstack-nova | 06:42 | |
| *** yamamoto has joined #openstack-nova | 06:45 | |
| *** alexchadin has joined #openstack-nova | 06:46 | |
| *** harlowja has quit IRC | 06:47 | |
| *** yamamoto_ has quit IRC | 06:49 | |
| *** tianhui has joined #openstack-nova | 06:52 | |
| *** Dinesh_Bhor has quit IRC | 06:59 | |
| *** Dinesh_Bhor has joined #openstack-nova | 06:59 | |
| *** Dinesh_Bhor has quit IRC | 06:59 | |
| *** threestrands has quit IRC | 07:00 | |
| *** threestrands has joined #openstack-nova | 07:01 | |
| *** threestrands has quit IRC | 07:01 | |
| *** threestrands has joined #openstack-nova | 07:01 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in get https://review.openstack.org/531299 | 07:01 |
| *** threestrands has quit IRC | 07:02 | |
| *** threestrands has joined #openstack-nova | 07:03 | |
| *** threestrands has quit IRC | 07:03 | |
| *** threestrands has joined #openstack-nova | 07:03 | |
| *** threestrands has quit IRC | 07:04 | |
| *** threestrands has joined #openstack-nova | 07:04 | |
| *** edmondsw has joined #openstack-nova | 07:08 | |
| *** yjk has joined #openstack-nova | 07:08 | |
| *** hshiina has joined #openstack-nova | 07:09 | |
| *** kholkina has joined #openstack-nova | 07:10 | |
| *** edmondsw has quit IRC | 07:13 | |
| *** pcaruana has joined #openstack-nova | 07:21 | |
| *** dims_ has quit IRC | 07:21 | |
| *** hemna_ has quit IRC | 07:21 | |
| *** jafeha__ is now known as jafeha | 07:23 | |
| *** dims has joined #openstack-nova | 07:25 | |
| *** sahid has joined #openstack-nova | 07:33 | |
| *** xnox has quit IRC | 07:33 | |
| *** moshele has joined #openstack-nova | 07:35 | |
| *** xnox has joined #openstack-nova | 07:36 | |
| *** xnox has joined #openstack-nova | 07:36 | |
| *** Eran_Kuris has quit IRC | 07:38 | |
| *** yjk has quit IRC | 07:39 | |
| *** kumarmn has joined #openstack-nova | 07:39 | |
| *** Eran_Kuris has joined #openstack-nova | 07:42 | |
| *** kumarmn has quit IRC | 07:44 | |
| *** andreas_s has joined #openstack-nova | 07:53 | |
| *** xnox has quit IRC | 07:54 | |
| *** xnox has joined #openstack-nova | 07:56 | |
| *** xnox has joined #openstack-nova | 07:56 | |
| *** sapcc-bot has quit IRC | 07:59 | |
| *** annp has joined #openstack-nova | 08:01 | |
| *** mkoderer_6 has quit IRC | 08:03 | |
| *** tpatzig_8 has quit IRC | 08:03 | |
| *** david_10 has quit IRC | 08:03 | |
| *** tpatzig_3 has quit IRC | 08:03 | |
| *** carthaca_2 has quit IRC | 08:03 | |
| *** mkoderer_ has quit IRC | 08:03 | |
| *** AlexeyAbashkin has joined #openstack-nova | 08:08 | |
| *** threestrands has quit IRC | 08:08 | |
| *** slaweq_ has joined #openstack-nova | 08:10 | |
| *** matrohon has joined #openstack-nova | 08:11 | |
| *** slaweq_ has quit IRC | 08:14 | |
| ameeda | Morning :) | 08:15 |
| maciejjozefczyk | Morning! | 08:15 |
| ameeda | can you please check this question https://stackoverflow.com/questions/48202352/write-functional-regression-test-for-nova | 08:15 |
| *** ttsiouts has quit IRC | 08:16 | |
| *** ttsiouts has joined #openstack-nova | 08:17 | |
| *** tesseract has joined #openstack-nova | 08:17 | |
| ameeda | maciejjozefczyk: I try to deploy openstack on baremetal from undercloud installed at vm, I got this error "CREATE_FAILED ResourceInError: resources.NovaCompute: Went to status ERROR due to "Message: No valid host was found. There are not enough hosts available., Code: 500"" | 08:19 |
| *** damien_r has joined #openstack-nova | 08:20 | |
| *** yjk has joined #openstack-nova | 08:21 | |
| ameeda | I found this error "ComputeHostNotFound: Compute host undercloud could not be found." in nova-compute.log | 08:22 |
| *** slaweq has joined #openstack-nova | 08:22 | |
| *** avolkov has joined #openstack-nova | 08:22 | |
| *** alexchadin has quit IRC | 08:28 | |
| *** suresh12 has joined #openstack-nova | 08:30 | |
| maciejjozefczyk | ameeda: It shoudl be quite similiar to https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1554631.py | 08:31 |
| maciejjozefczyk | about functional regression test | 08:31 |
| ameeda | maciejjozefczyk: thanks you very much. I will check it now | 08:32 |
| maciejjozefczyk | ameeda: I mean you need some mocking and it could be possible to check if the field is not truncated | 08:32 |
| ameeda | maciejjozefczyk: the problem is that I am beginner with openstack and also I never write regression code, I will do my best to do that | 08:33 |
| maciejjozefczyk | ameeda: I've never written any regression test also :D | 08:34 |
| *** jpena|off is now known as jpena | 08:34 | |
| maciejjozefczyk | ameeda: about second question; check scheduler logs | 08:34 |
| ameeda | maciejjozefczyk: great :D | 08:35 |
| *** yjk has quit IRC | 08:35 | |
| ameeda | maciejjozefczyk: let me check it now | 08:35 |
| maciejjozefczyk | ameeda: Do understand it well I recommend to move log_level to debug and then restart scheduler; you'll find which filter removes the host from list | 08:35 |
| *** suresh12 has quit IRC | 08:35 | |
| ameeda | let me see how to change log_level :$ | 08:37 |
| *** alexchadin has joined #openstack-nova | 08:41 | |
| *** pcaruana has quit IRC | 08:44 | |
| *** ragiman has joined #openstack-nova | 08:46 | |
| *** links has quit IRC | 08:46 | |
| *** jaosorior has joined #openstack-nova | 08:47 | |
| openstackgerrit | Silvan Kaiser proposed openstack/nova master: Added mount fstype based validation of Quobyte mounts https://review.openstack.org/522245 | 08:48 |
| *** ralonsoh has joined #openstack-nova | 08:50 | |
| *** ratailor_ has joined #openstack-nova | 08:53 | |
| *** tianhui has quit IRC | 08:54 | |
| *** tianhui has joined #openstack-nova | 08:54 | |
| *** ratailor has quit IRC | 08:55 | |
| maciejjozefczyk | ameeda: /etc/nova/nova.conf - add debug=True | 08:56 |
| *** edmondsw has joined #openstack-nova | 08:56 | |
| ameeda | maciejjozefczyk: yes I did that, and I restart the services and I need to empty log files contents | 08:57 |
| *** hiro-kobayashi has quit IRC | 08:58 | |
| *** links has joined #openstack-nova | 08:59 | |
| *** edmondsw has quit IRC | 09:01 | |
| bauzas | good morning Novaers | 09:01 |
| ameeda | Morning :) | 09:01 |
| ameeda | maciejjozefczyk: I will start openstack deploy. | 09:02 |
| *** hshiina has quit IRC | 09:06 | |
| *** sree_ has joined #openstack-nova | 09:10 | |
| *** sree_ is now known as Guest37375 | 09:11 | |
| *** sree has quit IRC | 09:12 | |
| *** Tom-Tom has quit IRC | 09:12 | |
| *** sree has joined #openstack-nova | 09:12 | |
| *** Tom-Tom has joined #openstack-nova | 09:13 | |
| kashyap | mdbooth: Hi, when you're about: Given this — https://review.openstack.org/#/c/505673/ (which adds the '--force-share' option to Nova Git master). For operators that are running already released version (e.g. Pike), updating to QEMU 2.10, would there be any impact? | 09:13 |
| kashyap | Or we'd be expecting them to _not_ upgrade as each Nova release comes with its specific version cap of libvirt & QEMU? | 09:13 |
| *** Guest37375 has quit IRC | 09:15 | |
| *** ljjjustin has joined #openstack-nova | 09:15 | |
| kashyap | Oh, it's actually cherry-picked to Pike | 09:16 |
| *** Tom-Tom has quit IRC | 09:17 | |
| kashyap | But not to Ocata (because it's in Phase-II). | 09:18 |
| *** lucas-afk is now known as lucasagomes | 09:26 | |
| mdbooth | kashyap: I suspect there would be an impact. | 09:31 |
| mdbooth | I think downstreams will have to backport that as required. | 09:32 |
| kashyap | mdbooth: Yeah, was thinking so. So for Ocata and Newton users (https://releases.openstack.org/) who upgrade to 2.10 QEMU will see problems | 09:32 |
| kashyap | Yeah | 09:32 |
| mdbooth | kashyap: Yep. | 09:32 |
| kashyap | The Pike backport was already done to alleviate an Ubuntu user running 2.10 -- https://review.openstack.org/#/c/509774/ | 09:32 |
| redondo-mk | Morning. Question...does anyone know some fast/simple way to estimate available capacity in terms of number of instances if you want to estimate that for specific flavor? | 09:36 |
| *** dtantsur|afk is now known as dtantsur | 09:38 | |
| *** takashin has left #openstack-nova | 09:38 | |
| *** gnuoy has quit IRC | 09:43 | |
| *** hrw has left #openstack-nova | 09:46 | |
| *** links has quit IRC | 09:51 | |
| *** Tom-Tom has joined #openstack-nova | 09:58 | |
| *** kholkina has quit IRC | 10:02 | |
| *** Tom-Tom has quit IRC | 10:02 | |
| *** kholkina has joined #openstack-nova | 10:03 | |
| *** jichen has quit IRC | 10:04 | |
| *** pcaruana has joined #openstack-nova | 10:04 | |
| *** links has joined #openstack-nova | 10:05 | |
| *** ljjjustin has quit IRC | 10:05 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Default some flavor fields loaded from instance https://review.openstack.org/529194 | 10:06 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Default some flavor fields loaded from instance https://review.openstack.org/529194 | 10:07 |
| *** phuongnh has quit IRC | 10:10 | |
| *** slaweq_ has joined #openstack-nova | 10:11 | |
| *** yjk_ has joined #openstack-nova | 10:11 | |
| yjk_ | Hi, I am currently on Newton release. (I am new to openstack) I am facing the following issue: - Event notifications generated by nova do not show the actual user who initiated the event. It rather shows the VM/object owner. For Example, If a "test-tenant" has two users an admin "test-admin" and a SSO user "test-ssu". If "test-admin" reboots a VM created by "test-ssu", event notification shows "test-admin" rather than "tes | 10:12 |
| *** moshele has quit IRC | 10:12 | |
| yjk_ | This I believe is because while generating the event notification payload, information from instance is used instead of context information. Code wise, in this line https://github.com/openstack/nova/blob/808d36475103e373f1deb3344b6829ce68d6cdd5/nova/notifications/base.py#L432 Here we use: user_id=instance.user_id Should'nt we use, user that has come from context, something like user_id=context.user_id Just wanted to know co | 10:12 |
| *** markvoelker has quit IRC | 10:13 | |
| *** sambetts|afk is now known as sambetts | 10:14 | |
| *** namnh has quit IRC | 10:14 | |
| *** mvk has joined #openstack-nova | 10:14 | |
| *** slaweq_ has quit IRC | 10:15 | |
| bauzas | mmm, I'm slapped by an InventoryInUse exception when I start testing VGPU allocations | 10:16 |
| gibi | yjk_: interesting finding. | 10:16 |
| bauzas | jianghuaw_: have you faced the same ? | 10:16 |
| bauzas | jianghuaw_: I had an exception when I started a new instance, so I destroyed it (it was in ERROR state) | 10:16 |
| bauzas | but since now, every inventory update leads to InventoryInUse thingy | 10:17 |
| gibi | yjk_: do you see the same problem for versioned notifications? | 10:17 |
| jianghuaw_ | bauzas, I don't have the issue at the moment. Is the exception reported when deleting inventory? | 10:19 |
| jianghuaw_ | Is it the first instance booted with a vgpu? | 10:20 |
| gibi | yjk_: anyhow could you please file a bug about it? | 10:20 |
| bauzas | jianghuaw_: no, the story is more like that : | 10:20 |
| bauzas | Jan 11 05:10:18 virtlab606.virt.lab.eng.bos.redhat.com nova-compute[80886]: INFO nova.scheduler.client.report [None req-4fdc9878-61e9-4b2f-8e92-1913486f0c9a demo admin] [req-b7b27fd5-31f8-43da-9d52-c2066d0b7af2] Inventory update conflict for e4304148-2f21-417b-bf78-9f3bc90f0ec7 with generation ID 7 | 10:20 |
| bauzas | because of the generation bit | 10:20 |
| bauzas | that would lead to deleting the inventory as it's planned *but* the scheduler client is checking whether that inventory is in use - and yes, it's the case | 10:21 |
| bauzas | because I have 3 fully functional VMs | 10:21 |
| bauzas | with VGPU allocations to them | 10:21 |
| bauzas | cdent is off, edleafe, jaypipes and efried aren't there yet | 10:21 |
| jianghuaw_ | Ah, then it should be a bug. | 10:21 |
| bauzas | so I dunno who could help me | 10:22 |
| bauzas | yes, this is a bug I guess | 10:22 |
| jianghuaw_ | Is it in a single compute node env or multiple nodes? | 10:23 |
| bauzas | single one | 10:23 |
| bauzas | so, it tries to update with generation=8 but the RP already has generation=8 so I guess it's the problem | 10:24 |
| *** sree_ has joined #openstack-nova | 10:25 | |
| *** sree_ is now known as Guest88600 | 10:26 | |
| gibi | yjk_: the code you linked above has a comment "Owner properties" so I think the original intention was to include the user id of the owner of the VM there | 10:27 |
| gibi | yjk_: but still I can understand the need to know the user id of the user who initiated the action | 10:28 |
| jianghuaw_ | bauzas, checking in my side. May you share me your procedure? Just boots 3 VMs with vGPU in sequence? And met the exception as the 3rd vm boots up? | 10:29 |
| gibi | yjk_: I think we can add that as a separate field, so both the owner and the action initiator is available in the notification | 10:29 |
| *** sree has quit IRC | 10:29 | |
| bauzas | jianghuaw_: #1 just create a new instance using a VGPU allocation | 10:29 |
| bauzas | #2 then, make sure you'll get an exception (and the instance being in ERROR) for a second instance asking for the same VGPU class | 10:30 |
| bauzas | #3 restart nova-compute | 10:30 |
| bauzas | #4 you'll see that InventoryInUse exception then | 10:30 |
| yjk_ | @gibi: That sounds good. | 10:30 |
| *** cdent has joined #openstack-nova | 10:30 | |
| jianghuaw_ | bauzas, for #2 how did you trigger the exception? | 10:31 |
| jianghuaw_ | or what's the exception met in #2? | 10:33 |
| *** alexchadin has quit IRC | 10:34 | |
| *** diga has quit IRC | 10:35 | |
| *** zhurong has quit IRC | 10:35 | |
| bauzas | jianghuaw_: it was just an exception raised by privsep when I was trying to create a new mdev | 10:35 |
| bauzas | jianghuaw_: but I guess any exception raised by the virt driver is fine | 10:35 |
| bauzas | I'll need to disappear for 2 hours | 10:36 |
| jianghuaw_ | yep, understood. | 10:36 |
| *** aloga_ has joined #openstack-nova | 10:37 | |
| yjk_ | Thanks for the reply gibi. | 10:39 |
| *** dr_gogeta86 has joined #openstack-nova | 10:39 | |
| yjk_ | I have another query. | 10:39 |
| *** dr_gogeta86 has quit IRC | 10:39 | |
| *** dr_gogeta86 has joined #openstack-nova | 10:39 | |
| yjk_ | I have an openstack Newton setup with 3 compute nodes. I have booted VMs from a bootable volume. Setup uses iSCSI disk shared between computes. Whenever, I try nova evacuate, it fails with an ERROR: FailedISCSITargetPortalLogin: Could not login to any iSCSI portal It seems that "connect_volume" call on the new host fails because it is not able to authenticate with iSCSI. | 10:39 |
| *** sandanar has quit IRC | 10:39 | |
| yjk_ | I believe it (whoever responsible) creates isci credentials when volume attach is initiated from a host. During migration, it should cleanly update the credentials so new host can access. | 10:40 |
| *** sandanar has joined #openstack-nova | 10:40 | |
| yjk_ | Any ideas on what may be causing this issue? | 10:41 |
| *** edmondsw has joined #openstack-nova | 10:44 | |
| *** slaweq_ has joined #openstack-nova | 10:46 | |
| *** maciejjo1 has joined #openstack-nova | 10:46 | |
| *** danpawlik_ has joined #openstack-nova | 10:46 | |
| *** andreas_s has quit IRC | 10:48 | |
| *** slaweq_ has quit IRC | 10:48 | |
| *** maciejjozefczyk has quit IRC | 10:48 | |
| *** danpawlik has quit IRC | 10:48 | |
| *** slaweq_ has joined #openstack-nova | 10:48 | |
| *** slaweq has quit IRC | 10:48 | |
| *** edmondsw has quit IRC | 10:49 | |
| *** andreas_s has joined #openstack-nova | 10:58 | |
| *** hiro-kobayashi has joined #openstack-nova | 11:02 | |
| jianghuaw_ | bauzas, I've tried several ways to trigger the exception in #2 but I didn't see the issue " Inventory update conflict " on my side. | 11:02 |
| cdent | bauzas: I'm here now (re [t 3csz] ). What's up? | 11:03 |
| purplerbot | <bauzas> cdent is off, edleafe, jaypipes and efried aren't there yet [2018-01-11 10:21:54.269899] [n 3csz] | 11:03 |
| *** moshele has joined #openstack-nova | 11:03 | |
| *** abhishekk has quit IRC | 11:03 | |
| yjk_ | Compute host logs where the VM was getting migrated (evacuated) to are available on http://paste.openstack.org/show/642545/. Your help would be really appreciated. Thanks | 11:04 |
| *** AlexeyAbashkin has quit IRC | 11:06 | |
| bauzas | jianghuaw_: cdent: nevermind, I found the root cause : PEBKAC | 11:06 |
| bauzas | lemme tell you the story tho | 11:06 |
| * cdent listens | 11:06 | |
| bauzas | so, in my changes, I said that the min version for mdevs is 3.4.0 | 11:06 |
| jianghuaw_ | listening | 11:06 |
| bauzas | but for RHEL7.4, it's 3.2.0 | 11:07 |
| bauzas | so I directly modified the version in the libvirt driver | 11:07 |
| bauzas | after that, I had a problem (for the #2 exception) so I just rebased my git repo into a separate change | 11:07 |
| bauzas | but then the min version was 3.4.0 again | 11:08 |
| bauzas | so when looking at the inventory, it wasn't supporting mdevs, so the scheduler client tried to delete the inventory | 11:08 |
| bauzas | hence the problem | 11:08 |
| cdent | ah | 11:08 |
| cdent | I can see how that would have been hard to uncover :( | 11:09 |
| bauzas | the problem with VGPU resource classes is that we only use them if needed | 11:09 |
| bauzas | so when you want to stop supporting it, then it would be problme | 11:10 |
| bauzas | we don't have the other problem for other standard RCs | 11:10 |
| bauzas | but it *could* be a problem later | 11:10 |
| bauzas | at least with nested RPs | 11:10 |
| bauzas | I totally understand why we provide that exception | 11:11 |
| bauzas | but maybe it could be a confusion for operatoes | 11:11 |
| cdent | I suspect we're going to find a lot if interesting bits of a confusion as we start using the stuff for real. Which I hope we can start doing sooner than later. | 11:12 |
| bauzas | anyway, thanks for your help | 11:13 |
| bauzas | I'm just punting my thoughts, just keeping it in my mind | 11:13 |
| bauzas | food for thoughts, that's it | 11:14 |
| jianghuaw_ | bauzas, understood. thanks for the sharing. | 11:14 |
| *** gszasz has joined #openstack-nova | 11:15 | |
| *** andreas_s has quit IRC | 11:19 | |
| mdbooth | bauzas: Is 'allocations' persisted anywhere? That is, can we recall it after spawn e.g. during live migration/reboot/rescue? | 11:20 |
| * mdbooth guesses it's not really for that? | 11:20 | |
| *** tuanla____ has quit IRC | 11:21 | |
| *** AlexeyAbashkin has joined #openstack-nova | 11:25 | |
| *** derekh has joined #openstack-nova | 11:25 | |
| *** maciejjo1 is now known as maciejjozefczyk | 11:27 | |
| bauzas | mdbooth: you mean where are persisted 'allocations' ? in the API DB | 11:27 |
| bauzas | I'm just amazed to see a feature working with new inventory classes :è) | 11:28 |
| bauzas | :-) | 11:28 |
| bauzas | the era of tech debt is just behind us now, huzzah \o/ | 11:28 |
| gibi | yjk_: I filed a bp about your notification ehancement https://blueprints.launchpad.net/nova/+spec/add-action-initiator-to-instance-action-notifications | 11:28 |
| bauzas | PCIManager, trust me, you're going to have a bad day ! | 11:28 |
| cdent | mdbooth: they are recalled during migration | 11:31 |
| *** andreas_s has joined #openstack-nova | 11:36 | |
| *** sdague has joined #openstack-nova | 11:39 | |
| *** kumarmn has joined #openstack-nova | 11:40 | |
| *** andreas_s has quit IRC | 11:40 | |
| *** tetsuro has quit IRC | 11:44 | |
| *** kumarmn has quit IRC | 11:45 | |
| *** hiro-kobayashi has quit IRC | 11:45 | |
| *** andreas_s has joined #openstack-nova | 11:50 | |
| *** liuzz has quit IRC | 11:54 | |
| *** andreas_s has quit IRC | 11:55 | |
| mdbooth | cdent: Do you have a pointer? | 11:57 |
| cdent | mdbooth: yeah, just a sec | 11:58 |
| *** gszasz has quit IRC | 11:58 | |
| mdbooth | locations = self.reportclient.get_allocations_for_consumer( | 11:59 |
| mdbooth | instance.uuid) | 11:59 |
| mdbooth | ^^^ ? | 11:59 |
| mdbooth | s/locations/allocations/ | 11:59 |
| cdent | I was thinking of https://github.com/openstack/nova/blob/master/nova/conductor/tasks/migrate.py#L129 | 11:59 |
| *** janki has quit IRC | 11:59 | |
| cdent | which calls replace_allocation_with_migration | 11:59 |
| *** yjk_ has quit IRC | 11:59 | |
| mdbooth | cdent: Does an instance have 2 sets of allocations during a migration, btw? | 12:00 |
| *** yamamoto has quit IRC | 12:01 | |
| cdent | yes, but one of them is identified by the uuid of the migration (in queens). For a while there were two, both identified by the instance | 12:01 |
| *** yamamoto has joined #openstack-nova | 12:01 | |
| mdbooth | cdent: Thanks | 12:01 |
| *** icey has quit IRC | 12:02 | |
| *** pcaruana has quit IRC | 12:02 | |
| *** pcaruana|afk| has joined #openstack-nova | 12:02 | |
| *** cdent has quit IRC | 12:02 | |
| *** icey has joined #openstack-nova | 12:02 | |
| *** gszasz has joined #openstack-nova | 12:03 | |
| *** jpena is now known as jpena|lunch | 12:04 | |
| *** annp has quit IRC | 12:05 | |
| *** slaweq has joined #openstack-nova | 12:11 | |
| *** markvoelker has joined #openstack-nova | 12:14 | |
| *** cdent has joined #openstack-nova | 12:16 | |
| *** slaweq has quit IRC | 12:16 | |
| *** sandanar has quit IRC | 12:18 | |
| *** smatzek has joined #openstack-nova | 12:21 | |
| *** yjk has joined #openstack-nova | 12:23 | |
| yjk | Hi gibi, I have opened an openstack bug. Please check https://bugs.launchpad.net/nova/+bug/1742674 | 12:23 |
| openstack | Launchpad bug 1742674 in OpenStack Compute (nova) "[Newton] Nova notifications do not show the user which initiates the event." [Undecided,New] | 12:23 |
| *** redondo-mk has quit IRC | 12:24 | |
| *** redondo-mk has joined #openstack-nova | 12:24 | |
| *** tomhambleton_ has quit IRC | 12:24 | |
| *** jose-phi_ has joined #openstack-nova | 12:25 | |
| *** mvk has quit IRC | 12:25 | |
| *** lucasagomes is now known as lucas-hungry | 12:25 | |
| *** markmc has quit IRC | 12:27 | |
| *** jose-phillips has quit IRC | 12:27 | |
| *** takashin has joined #openstack-nova | 12:27 | |
| *** markmc has joined #openstack-nova | 12:28 | |
| gibi | yjk: I think it needs to be handled as a new feature, hence the blueprint I opened | 12:29 |
| gibi | yjk: if you have time to work on such a feature I can help you | 12:29 |
| *** Eran_Kuris has quit IRC | 12:29 | |
| *** tetsuro has joined #openstack-nova | 12:29 | |
| *** edmondsw has joined #openstack-nova | 12:33 | |
| yjk | gibi: I though you had asked me to open an openstack bug. That is why opened a bug. | 12:33 |
| gibi | yjk: yes, but then based on the code comment I realized that it was the original intention to send the owner's user_id | 12:35 |
| gibi | yjk: so I think we should add a separate field for the user id of the user that called the action | 12:35 |
| gibi | yjk: and that will be more like a new feature than a bugfix | 12:35 |
| yjk | gibi: I though you had asked me to open an openstack bug. That is why opened a bug. | 12:36 |
| *** edmondsw has quit IRC | 12:38 | |
| gibi | yjk: yes, first I thought that it is a bug then I realzied that it is more like a new feature | 12:38 |
| gibi | yjk: sorry for the confusion | 12:38 |
| ameeda | Hello, Please help me , please check this "http://paste.openstack.org/show/642597/" that caused when I introspect the node. | 12:38 |
| *** Eran_Kuris has joined #openstack-nova | 12:42 | |
| *** ljjjustin has joined #openstack-nova | 12:44 | |
| *** ljjjustin has quit IRC | 12:44 | |
| *** sapcc-bot has joined #openstack-nova | 12:44 | |
| *** moshele has quit IRC | 12:46 | |
| *** markvoelker has quit IRC | 12:48 | |
| *** ratailor_ has quit IRC | 12:49 | |
| *** pcaruana|afk| has quit IRC | 12:49 | |
| *** moshele has joined #openstack-nova | 12:50 | |
| *** krtaylor_ has quit IRC | 12:50 | |
| *** ygl has joined #openstack-nova | 12:50 | |
| *** yjk has quit IRC | 12:54 | |
| ygl | hi all can someone help me with nova-scheduler please ? | 12:55 |
| bauzas | ygl: sure? | 12:55 |
| *** andreas_s has joined #openstack-nova | 12:58 | |
| ameeda | bauzas: can you please help me ? | 12:59 |
| ygl | bauzas: recently my openstack setup took a hit. it is not launching any instances. I cant see any use ful logs indicative of the problem, even though I enabled debug in nova.conf. After a lot of investigation I found that one of the computes is not reachable by it mgmt IP | 13:00 |
| ygl | bauzas: why is it that the scheduler was not lookin gto for other good computes even though they are available but looking always for that unrechable compute node ? | 13:00 |
| ygl | bauzas: ununtil I removed that compute from the nova zone, it did not work | 13:00 |
| *** jpena|lunch is now known as jpena | 13:00 | |
| ygl | bauzas: why is it so with the scheduler ? | 13:00 |
| *** pcaruana|afk| has joined #openstack-nova | 13:02 | |
| *** kholkina has quit IRC | 13:02 | |
| ygl | bauzas: any idea ? | 13:02 |
| *** kholkina has joined #openstack-nova | 13:03 | |
| bauzas | ygl: not sure I understand your problem | 13:03 |
| *** ljjjustin has joined #openstack-nova | 13:03 | |
| *** andreas_s has quit IRC | 13:04 | |
| bauzas | mdbooth: thanks for your review on https://review.openstack.org/#/c/528832/ | 13:04 |
| bauzas | mdbooth: there are 3 "stages" on having VGPU capabiliities with libvirt | 13:05 |
| mdbooth | bauzas: Thanks for a morning of discovery :) | 13:05 |
| bauzas | mdbooth: first of all, you need a vGPU capable device | 13:05 |
| ygl | bauzas: because of unreachable compute by its management IP, the nova-scheduler is not allowing to launch new instances on remaining compute nodes | 13:05 |
| bauzas | mdbooth: this is expressed by a "mdev capable" PCI device | 13:05 |
| *** Tom-Tom has joined #openstack-nova | 13:06 | |
| bauzas | ie. a PCI device having mdev "capabilities" that say "for that type, you can have X vGPUs" | 13:06 |
| *** gszasz has quit IRC | 13:06 | |
| bauzas | but a single PCI device can support multiple profiles, ie. types | 13:06 |
| bauzas | that's only when you *create* a mediated device that the other types become unavailable | 13:07 |
| bauzas | creating a mediated device is stage #2 | 13:07 |
| bauzas | for creating a mediated device, you can't call the libvirt API but you rather need to use sysfs directly | 13:07 |
| bauzas | that will generate a mediated device that you can see in the sysfs, but no guests are allocated yet to that host | 13:08 |
| ygl | bauzas: any idea ? | 13:08 |
| bauzas | ygl: seriously, no, we filter out unreachable computes but the others are still checked | 13:08 |
| ygl | bauzas: but in my case it was failing | 13:09 |
| mdbooth | bauzas: I think the above is in line with my (very newly acquired) understanding. | 13:09 |
| bauzas | mdbooth: for having a guest having VGPUs, you need a stage #3 | 13:09 |
| ygl | bauzas: until I dsiabled the bad compute, it didi not work | 13:09 |
| *** jaosorior has quit IRC | 13:09 | |
| bauzas | mdbooth: which is basically use that mediated device in the guest config | 13:09 |
| mdbooth | bauzas: Yep. This is the parallel I drew with host-connected volumes. | 13:10 |
| bauzas | mdbooth: so, about the risk of having all the mdevs not cleaned up, it's a non-problem | 13:10 |
| *** Tom-Tom has quit IRC | 13:10 | |
| mdbooth | Step 0 is create the volume (in cinder) | 13:10 |
| bauzas | mdbooth: because we only care of how many mediated devices are still unassigned to a guest | 13:10 |
| mdbooth | Step 1 is create a host device corresponding to that volume | 13:10 |
| bauzas | if all the mediated devices are already created by the operator, that's not an issue | 13:11 |
| mdbooth | Step 2 is add it to a guest. | 13:11 |
| bauzas | and btw. there is a kernel race that prevents libvirtd to see the newly created mediated device, see my relnote | 13:11 |
| mdbooth | Yeah, I read that. That's annoying. | 13:11 |
| bauzas | so, in general, it's better to just create by yourself all the mediated devices beforehand | 13:11 |
| mdbooth | FWIW I wouldn't bother working round that in Nova. Just note that here be dragons and wait for the fix. | 13:12 |
| mdbooth | There are enough caveats for the experimental flag already, I think. | 13:12 |
| bauzas | so, see, given each mediated device is cleaned up when it's detached from the guest, I don't see any problem with reusing them in between all the instances | 13:12 |
| mdbooth | Thanks for that release note, btw. Best I've read. | 13:12 |
| bauzas | (wrt. your last comment) | 13:12 |
| bauzas | "Looking forward, we're not cleaning up mdevs. I don't think this is a problem right now when we only support 1 type, but IIUC allocating an mdev of type X can reduce the availability for type Y, right? If that's the case, I think we should consider cleaning up. This wouldn't be an immediate priority, though.'" | 13:13 |
| mdbooth | bauzas: Got it. Yeah, that would only apply if these are mix and match. i.e. You can have 6 X and 6 Y. | 13:13 |
| mdbooth | But I think you're saying as soon as you have 1 X you can only have X | 13:13 |
| bauzas | because, and I told you that, if you have a physical device that can support X and Y types, once you create *one* single mediated device of X, then you litterally have 0 available for Y | 13:14 |
| bauzas | exactly | 13:14 |
| *** janki has joined #openstack-nova | 13:14 | |
| bauzas | (at least for the nvidia driver) | 13:14 |
| mdbooth | Right, so the only advantage to cleanup is that you could potentially repurpose it later to be Y if you removed all X without requiring a restart. | 13:14 |
| bauzas | mdbooth: http://images.nvidia.com/content/grid/pdf/GRID-vGPU-User-Guide.pdf section 1.3.2 "homogeneous vGPUs" | 13:15 |
| mdbooth | That's in the realms of optimisation, though. Very much not important. | 13:15 |
| bauzas | mdbooth: right, as an operator, you really need to consider which type to use, and not try to mix them up in between a single node | 13:15 |
| mdbooth | The major issues were the races, the inconsistent XML generation, and that as a maintainer of the libvirt driver, in general I don't want _get_guest_xml doing even more surprising things. | 13:16 |
| bauzas | I'd be in favor to limit as the maximum the fact to mix up different types across a single compute, even if you have multiple GPUs | 13:16 |
| bauzas | mdbooth: the races are a concern, but I'd be in favor of adding the locks in a follow-up if you don't mind | 13:16 |
| mdbooth | So if you create one of these instances, stop it, then start it, you've lost your vgpu. | 13:16 |
| bauzas | mdbooth: that code is already pretty heavy | 13:16 |
| bauzas | mdbooth: that's part of the extra testing I'm doing on my box | 13:17 |
| *** sahid has quit IRC | 13:17 | |
| mdbooth | bauzas: I think we can safely say it won't work without testing though, right? | 13:17 |
| bauzas | I'm just tackling the last bits of privsep, but I was considering a shelve | 13:17 |
| *** ameeda has quit IRC | 13:17 | |
| mdbooth | Because we don't pass allocations to power_on. | 13:17 |
| bauzas | mdbooth: we could if necessary | 13:18 |
| mdbooth | It would also be nice to block live migrations, don't know if we do that alrady. | 13:18 |
| *** gszasz has joined #openstack-nova | 13:18 | |
| bauzas | mdbooth: well, live migrating an instance having a VGPU attached is like "hold my beer" | 13:18 |
| mdbooth | Similarly, if you rescue one, when you unrescue it you'll have lost your vgpu | 13:18 |
| bauzas | mdbooth: okay, here is what I propose | 13:19 |
| mdbooth | bauzas: Hehe, yeah. I wouldn't expect that to work, tbh. | 13:19 |
| bauzas | mdbooth: step #1 amend the relnote and mention the caveats you noticed | 13:19 |
| mdbooth | Can we split the mdev allocation code into a function which does: | 13:19 |
| bauzas | mdbooth: step #2 do a follow-up on the race | 13:19 |
| bauzas | mdbooth: step #3 and beyond : patch each caller of get_guest_config to pass the allocation | 13:20 |
| mdbooth | _grab_mdevs(allocations) -> list of mdev uuids | 13:20 |
| mdbooth | Then pass list of mdev uuids to _get_guest_xml | 13:20 |
| mdbooth | It would also give us the opportunity to do explicitly different things to generate that list in different contexts. | 13:21 |
| mdbooth | e.g. at startup, our mdevs may exist already or they may not. | 13:21 |
| bauzas | right, that's another caveat, mdevs aren't persistent | 13:22 |
| mdbooth | If we just restarted Nova, they will exist. If we rebooted the host, they won't. | 13:22 |
| bauzas | but I was considering to use init_host to just lookup all the guest XMLs and recreate the mdevs | 13:22 |
| mdbooth | We don't want to be trying to handle weird situations like that in the middle of _get_guest_xml | 13:22 |
| bauzas | (if of course your node kernel doesn't have that uevent race) | 13:22 |
| mdbooth | So my structural concern is with my 'maintainer of the libvirt driver' hat on. It isn't specifically related to mdevs. | 13:23 |
| *** tetsuro has quit IRC | 13:23 | |
| mdbooth | I'd prefer that we didn't do host configuration in _get_guest_xml. | 13:23 |
| mdbooth | s/do/do more/ | 13:24 |
| bauzas | mdbooth: btw. issue confirmed : if you stop/start your instance, then goodbye my dev | 13:25 |
| *** tetsuro_ has joined #openstack-nova | 13:25 | |
| bauzas | ok, I'm gonna tackle one issue at time | 13:25 |
| mdbooth | bauzas: We can get allocations back, I think. I'm pretty sure we can do this without having to persist it anywhere, although that was my first thought. | 13:26 |
| bauzas | mdbooth: I'll just spin another revision modifying the privsep call, could you please post your comments back on the next rev ? | 13:26 |
| mdbooth | bauzas: Sure thing. | 13:26 |
| bauzas | mdbooth: this is more a scheduling problem | 13:26 |
| *** mvk has joined #openstack-nova | 13:26 | |
| bauzas | mdbooth: because if we stop the guest, then we loose the mediated device | 13:26 |
| mdbooth | Oh, true. | 13:27 |
| bauzas | mdbooth: I wonder if we keep the mdev attachment when we restart | 13:27 |
| bauzas | mdbooth: that needs to be tested, because I ask to lookup all libvirt guests, including those stopped | 13:27 |
| mdbooth | I think the domain sticks around of you just stop it. | 13:27 |
| mdbooth | I think you're good there. | 13:27 |
| bauzas | so, in theory, we still get the association even if the domain is destroyed | 13:27 |
| bauzas | because it's not undefined | 13:27 |
| bauzas | so I think we're good | 13:28 |
| mdbooth | I'm also assuming, btw, that it doesn't matter *which* vgpu we get. | 13:28 |
| bauzas | we could just need to pass the allocations to power_on | 13:28 |
| mdbooth | So stop/start, get a new vgpu, we don't care. | 13:28 |
| bauzas | mdbooth: right, all VGPUs are equally equal :p | 13:28 |
| bauzas | based on the same type, of course :) | 13:28 |
| bauzas | it's cloud, brah | 13:28 |
| mdbooth | Hehe. | 13:29 |
| * mdbooth submits a patch to delete live-migration | 13:29 | |
| * bauzas submits a patch to rename live-migration to 'hold-my-beer' | 13:29 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: Send bytes to sockets https://review.openstack.org/531834 | 13:31 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce framework for RFB authentication https://review.openstack.org/345397 | 13:31 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce the VeNCrypt RFB authentication scheme https://review.openstack.org/345398 | 13:31 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: Provide an RFB security proxy implementation https://review.openstack.org/345399 | 13:31 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Document TLS security setup for noVNC proxy https://review.openstack.org/500544 | 13:31 |
| stephenfin | melwitt: Addressed concerns in ^ | 13:31 |
| ygl | bauzas: any idea about the scheduler behaving this way ? | 13:31 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Increase notification wait timeout in functional tests https://review.openstack.org/532816 | 13:32 |
| bauzas | mdbooth: https://twitter.com/sylvainbauza/status/951446715470577664 | 13:33 |
| gibi | melwitt: hi!, https://bugs.launchpad.net/nova/+bug/1742688 and https://review.openstack.org/532816 It seems we are the victim of the gate slowness | 13:33 |
| openstack | Launchpad bug 1742688 in OpenStack Compute (nova) "test_live_migration_actions notification sample test fails intermittently with 'notification instance.live_migration_rollback.start hasn't been received'" [Undecided,In progress] - Assigned to Balazs Gibizer (balazs-gibizer) | 13:33 |
| bauzas | gibi: yup, the gate is like super-slow | 13:36 |
| bauzas | mdbooth: so, tell me more about what you want | 13:39 |
| *** mdnadeem has quit IRC | 13:39 | |
| bauzas | mdbooth: you said to have a magical _grab_mdevs(allocations) that would return you a list of mdev UUIDs, right? | 13:40 |
| bauzas | mdbooth: so basically identical to _guest_add_vgpus() except the very last line ? | 13:40 |
| mdbooth | bauzas: Sec, lemme look | 13:40 |
| bauzas | mdbooth: tl;dr: I only care about the guest parameter because I eventually do a guest.add_device() | 13:42 |
| bauzas | but at the very very end of that method | 13:42 |
| mdbooth | bauzas: Yes. There's only like 3 lines of that function which relate to xml generation :) | 13:42 |
| bauzas | and 2 of them are unrelated to the guest itself | 13:43 |
| bauzas | so, then, what would be the interest of splitting that ? | 13:43 |
| mdbooth | bauzas: A few | 13:43 |
| mdbooth | The first as I mentioned is that it's surprising | 13:44 |
| mdbooth | Somebody coming along looking for where this stuff is configured in the workflow isn't going to see _get_guest_xml() and guess that it's there. | 13:44 |
| *** lucas-hungry is now known as lucasagomes | 13:44 | |
| *** markvoelker has joined #openstack-nova | 13:44 | |
| bauzas | mdbooth: that said, we do that *a lot*, right? :p | 13:44 |
| mdbooth | We do a whole lot of surprising stuff, sure :) | 13:45 |
| bauzas | mdbooth: I mean, that's precisely there where we attach what we want, right ? | 13:45 |
| mdbooth | Second is I suspect we're going to want to have different ways to create this list. | 13:45 |
| bauzas | it's not only the GPU thing, it's all the devices we create | 13:45 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Resolve 'oslo.context' deprecation warnings https://review.openstack.org/532822 | 13:45 |
| mdbooth | e.g. creating new mdevs vs re-using existing mdevs | 13:45 |
| mdbooth | s/existing/already allocated to this instance/ | 13:46 |
| bauzas | mdbooth: that is precisely something that should kept hidden from the other libvirt places | 13:46 |
| bauzas | for tech debt reasons | 13:46 |
| mdbooth | Where creating == create or reallocate | 13:46 |
| bauzas | how the vGPUs are implemented in libvirt should be kept very isolated from the rest | 13:46 |
| mdbooth | I'm talking about the code in libvirt/driver.py here | 13:47 |
| bauzas | sure | 13:47 |
| mdbooth | So it shouldn't affect the decisions of other drivers. | 13:47 |
| bauzas | I still think we need to limit the driver knowledge about what is a vGPU | 13:47 |
| mdbooth | I think the guest needs to end up with a list of mdevs it should add | 13:48 |
| bauzas | mdbooth: that's just basically splitting the method in twice | 13:48 |
| bauzas | and introducing a new level of indirection, but okay | 13:48 |
| bauzas | mdbooth: I still don't see why we really need to split in twice but okay | 13:49 |
| mdbooth | Well I think the split is helpful to the reader, because it calls out a different type of operation in a different place. It also allows us to generate the list in different ways based on caller context without having to pass the context all the way down into _get_guest_xml | 13:50 |
| bauzas | it just makes the interfaces a bit cleaner, but that's it | 13:50 |
| mdbooth | e.g. If we're creating a new guest, allocating new instances, vs re-generating our existing xml with our current mdevs. | 13:50 |
| bauzas | mdbooth: a-ha, that's different | 13:50 |
| bauzas | mdbooth: I see your thoughts | 13:51 |
| *** liverpooler has joined #openstack-nova | 13:51 | |
| *** abhishekk has joined #openstack-nova | 13:51 | |
| bauzas | mdbooth: ie. not passing allocated all the way down to _get_guest_xml() but rather just call _give_me_vgpus() in the caller itself ? | 13:51 |
| mdbooth | bauzas: Something like that would be my preference. | 13:51 |
| bauzas | and then the caller attaching those vgpus *after* it got the XML ? | 13:51 |
| mdbooth | No, you have to do it before | 13:52 |
| *** masber has quit IRC | 13:52 | |
| bauzas | mdbooth: you understand that it's mostly a convenience problem ? | 13:52 |
| mdbooth | So you have to do the host config first, then you can generate the guest xml based on how you did it | 13:52 |
| *** rabel_b1 has joined #openstack-nova | 13:52 | |
| mdbooth | It's the same as the volume attachment problem. You can't generate the guest xml until you can tell libvirt where you mounted the volume. | 13:53 |
| bauzas | mdbooth: so you would pass the extra bits down _get_guest_xml, right? | 13:53 |
| *** efried has joined #openstack-nova | 13:53 | |
| mdbooth | Yes. | 13:53 |
| bauzas | mdbooth: and then the whole _give_me_mdevs() would be a synchronized section? | 13:54 |
| *** lyan_ has joined #openstack-nova | 13:54 | |
| bauzas | gibi: chairing the nova meeting, right? | 13:55 |
| mdbooth | bauzas: Yes, it would have to be. | 13:55 |
| bauzas | mdbooth: I still consider the synchronized section to be in a follow-up | 13:55 |
| bauzas | mdbooth: timeline wise | 13:56 |
| bauzas | because we're 2 weeks away from the FF, and I don't want that feature to be punted | 13:56 |
| mdbooth | bauzas: Adding that would be way simpler than moving code around out of _get_guest_xml | 13:56 |
| mdbooth | Just a simple host-wide local lock | 13:57 |
| bauzas | I agree | 13:57 |
| bauzas | here are my thoughts | 13:57 |
| bauzas | based on what I see important to be merged before end of Queens | 13:58 |
| bauzas | #1 the patch itself | 13:58 |
| bauzas | (with the synchronized lock) | 13:58 |
| bauzas | #2 the possibility to disallow nova to create mdevs | 13:58 |
| *** alexchadin has joined #openstack-nova | 13:59 | |
| bauzas | #3 the fix for power-on and others | 13:59 |
| bauzas | #4 the possibility to recreate mdevs after a reboot | 13:59 |
| bauzas | and the rest looks optional to me | 13:59 |
| bauzas | we can refine the interfaces in Rocky | 13:59 |
| bauzas | besides the fact that the problem you mention isn't particular to the VGPU feature, but rather for a shit ton of extra devices and features we add to the guest | 14:00 |
| bauzas | mdbooth: agree ? | 14:00 |
| mdbooth | Only volumes, I think. | 14:00 |
| mdbooth | I agree with your prioritisation. | 14:00 |
| gibi | bauzas: I did not get the memo that I'm the chair | 14:00 |
| bauzas | mdbooth: no, we litterally generate all the devices at the same place | 14:00 |
| gibi | bauzas: but I can jump in | 14:01 |
| efried | gibi bauzas Somebody oughtta do it. The time is now :) | 14:01 |
| *** vladikr has joined #openstack-nova | 14:01 | |
| mdbooth | bauzas: I really think it's only volumes. | 14:03 |
| mdbooth | The others we're just adding devices to the guest. The different with volumes and now vgpus is that we're reconfiguring the host. | 14:03 |
| mdbooth | So we're doing _get_guest_xml() and it has surprising side-effects | 14:03 |
| bauzas | mdbooth: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4882 ? | 14:03 |
| mdbooth | bauzas: Yeah, that's just pulling them out of the instance. | 14:04 |
| mdbooth | IIUC they've already been allocated elsewhere. | 14:04 |
| bauzas | mdbooth: what's the difference between attaching a PCI device or a mediated device ? | 14:04 |
| mdbooth | Because you're not creating the pci device, or doing any kind of 'scheduling' | 14:04 |
| *** ragiman has quit IRC | 14:05 | |
| mdbooth | You're not calling _get_guest_xml() and suddenly you've created a new pci device | 14:05 |
| mdbooth | Anyway, I agree with your prioritisation. That said, I really don't like it about volumes, and I'm uncomfortable adding more of it. | 14:05 |
| bauzas | mdbooth: but the allocation was made way earlier :) | 14:06 |
| bauzas | for the VGPU | 14:06 |
| bauzas | if you go to that compute, that's because it has free space for a vGPU | 14:06 |
| bauzas | because placement told you | 14:06 |
| bauzas | exactly like NUMA things | 14:06 |
| bauzas | the scheduler or placement won't know which specific device you're assigned | 14:07 |
| *** eharney has joined #openstack-nova | 14:07 | |
| bauzas | but it will know there is room for you | 14:07 |
| bauzas | in theory, you should never raise the exception I added | 14:07 |
| mdbooth | bauzas: There's also the case of recreating the domain xml with existing mdevs. | 14:08 |
| mdbooth | Although perhaps that doesn't matter as long as we're absolutely certain the domain isn't running. | 14:09 |
| mdbooth | But again that's an embedded assumption which makes everything harder to understand. | 14:09 |
| bauzas | mdbooth: the problem is that the XML isn't persisted when you stop the instance | 14:10 |
| bauzas | I mean in Nova | 14:10 |
| bauzas | that's surprising to me | 14:10 |
| bauzas | we regenerate the XML when we start again the instance | 14:10 |
| bauzas | while it's already been defined ! | 14:11 |
| bauzas | mdbooth: any idea you know why ? | 14:11 |
| mdbooth | Yeah, that's... suboptimal. | 14:11 |
| bauzas | that's rather errorprone | 14:11 |
| mdbooth | A legacy design choice that Nova is the ultimate source of truth. It means we lose stuff like device ordering and address assignments. | 14:11 |
| *** slaweq has joined #openstack-nova | 14:12 | |
| bauzas | I can understand the reasoning | 14:13 |
| bauzas | but then, you somehow need to persist that | 14:13 |
| bauzas | and rather not rebuilding it | 14:13 |
| bauzas | but that's MHO | 14:13 |
| bauzas | and I'm possibly missing some design choices | 14:13 |
| artom | It may have come from the need to support other drivers? | 14:14 |
| artom | Who don't necessarily keep state like libvirt does? | 14:14 |
| *** ygl has quit IRC | 14:14 | |
| mdbooth | artom: This is an internal libvirt driver detail. | 14:14 |
| bauzas | anyway | 14:15 |
| bauzas | I have some stupid formatting to do, because pci names are different from filesystem | 14:15 |
| bauzas | I mean pci names in libvirt | 14:15 |
| bauzas | grrrr | 14:15 |
| *** yangyapeng has quit IRC | 14:15 | |
| mdbooth | bauzas: I agree that moving that stuff is less important, though. | 14:15 |
| mdbooth | I think where we differ is much less important we think it is ;) | 14:16 |
| *** dave-mccowan has joined #openstack-nova | 14:16 | |
| cdent | "source of truth" is definitely a common issue | 14:16 |
| bauzas | distributed systems is a NP-problem by definition | 14:17 |
| bauzas | so I'm not afraid | 14:17 |
| *** slaweq has quit IRC | 14:17 | |
| *** markvoelker has quit IRC | 14:18 | |
| *** ragiman has joined #openstack-nova | 14:19 | |
| mdbooth | bauzas: The other things are bugs, anyway. This is an issue of ongoing maintainability. | 14:20 |
| kashyap | stephenfin: Hey, have you setup DevStack lately on an older branch (Mitaka) on CentOS? | 14:21 |
| *** edmondsw has joined #openstack-nova | 14:21 | |
| stephenfin | kashyap: Newton is as far back I've gone in a while, I think | 14:21 |
| kashyap | I don't see Mitaka branch in DevStack, do they "delete" the older branches? | 14:21 |
| *** tomhambleton_ has joined #openstack-nova | 14:21 | |
| stephenfin | and that was before it was EOL | 14:21 |
| stephenfin | I guess they do. Look for the mitaka-eol tag | 14:21 |
| kashyap | stack@devstack-centos ~/src/cloud/devstack (master) $ git branch -a | grep -i mitaka | 14:22 |
| kashyap | stack@devstack-centos ~/src/cloud/devstack (master) $ echo $? | 14:22 |
| kashyap | 1 | 14:22 |
| stephenfin | git tag -a | grep -i mitaka | 14:22 |
| *** moshele has quit IRC | 14:22 | |
| kashyap | s/-a/-l/ | 14:23 |
| stephenfin | Indeed | 14:23 |
| kashyap | Yep, could fetch from the tag. Thx. | 14:23 |
| stephenfin | Once you've that checked out, you'll also want to modify the branches that are checked out, e.g. https://gist.github.com/stephenfin/d1c000f7e52ff181c4673322b28eaf47#file-local-conf-L71-L81https://gist.github.com/stephenfin/d1c000f7e52ff181c4673322b28eaf47#file-local-conf-L71-L81 | 14:23 |
| * kashyap clicks | 14:23 | |
| stephenfin | I guess they should all be 'mitaka-eol' | 14:23 |
| *** edmondsw_ has joined #openstack-nova | 14:24 | |
| *** psachin has quit IRC | 14:24 | |
| kashyap | stephenfin: Yeah, my attempt on Fedora for Mitaka failed | 14:24 |
| *** pchavva has joined #openstack-nova | 14:24 | |
| kashyap | Failed as in, the libvirt-python wonkiness: http://paste.openstack.org/show/642707/ | 14:25 |
| stephenfin | Aye, an LTS distro is probably the way to go. Guess either Ubuntu 14.04 or CentOS 7.4 is your best bet | 14:25 |
| kashyap | It's missing two of the events, when building libvirt-python | 14:25 |
| kashyap | Didn't wanted to duke around there, so just went w/ CentOS. Let's see how that goes. | 14:25 |
| kashyap | stephenfin: I used to use -- https://kashyapc.fedorapeople.org/virt/openstack/Minimal-DevStack-local.conf | 14:27 |
| kashyap | I know it could be improved (Neutron is now default, etc). | 14:27 |
| *** esberglu has joined #openstack-nova | 14:28 | |
| *** edmondsw has quit IRC | 14:28 | |
| *** awaugama has joined #openstack-nova | 14:29 | |
| *** ljjjustin has quit IRC | 14:29 | |
| *** tetsuro_ has quit IRC | 14:34 | |
| *** archit has joined #openstack-nova | 14:40 | |
| *** zhaochao has quit IRC | 14:40 | |
| *** kholkina has quit IRC | 14:43 | |
| *** kholkina has joined #openstack-nova | 14:43 | |
| *** edmondsw_ is now known as edmondsw | 14:45 | |
| *** abhishekk has quit IRC | 14:46 | |
| *** ragiman has quit IRC | 14:48 | |
| *** hongbin has joined #openstack-nova | 14:48 | |
| *** jobewan has joined #openstack-nova | 14:49 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Collocate encryptor and volume driver calls https://review.openstack.org/460243 | 14:50 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Introduce disk encryption config classes https://review.openstack.org/464008 | 14:50 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: QEMU native LUKS decryption for volumes https://review.openstack.org/523958 | 14:50 |
| *** Swami has joined #openstack-nova | 14:52 | |
| *** moshele has joined #openstack-nova | 14:54 | |
| *** moshele has quit IRC | 14:56 | |
| *** bkopilov has quit IRC | 14:58 | |
| *** sahid has joined #openstack-nova | 14:58 | |
| *** mlavalle has joined #openstack-nova | 14:58 | |
| *** eharney has quit IRC | 15:00 | |
| *** yangyapeng has joined #openstack-nova | 15:00 | |
| *** gouthamr has joined #openstack-nova | 15:01 | |
| *** takashin has left #openstack-nova | 15:01 | |
| *** ragiman has joined #openstack-nova | 15:01 | |
| *** markvoelker has joined #openstack-nova | 15:02 | |
| *** markvoelker has quit IRC | 15:02 | |
| *** mriedem has joined #openstack-nova | 15:02 | |
| mriedem | oops, totally forgot about the team meeting | 15:03 |
| *** rabel__b1 has joined #openstack-nova | 15:03 | |
| *** eharney has joined #openstack-nova | 15:03 | |
| mriedem | gibi: thanks for running that | 15:03 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: slow live-migration to ensure network is ready https://review.openstack.org/497457 | 15:05 |
| gibi | mriedem: no problem, I was not prepared but I could run it | 15:05 |
| *** ihrachys has quit IRC | 15:05 | |
| *** rabel_b1 has quit IRC | 15:05 | |
| *** ihrachys has joined #openstack-nova | 15:05 | |
| efried | Hi cores, would anyone be willing to look at the first two patches for the PowerVM integration bp? https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/powervm-nova-it-compute-driver | 15:10 |
| efried | stephenfin gibi bauzas perhaps if you have time? | 15:11 |
| stephenfin | efried: I've been meaning to review the OVS VIF one, but I'll have to leave the storage patches to someone else | 15:11 |
| bauzas | efried: I'm still rushing on my feature branch :/ | 15:11 |
| bauzas | efried: blame mdbooth | 15:11 |
| mdbooth | bauzas: Sorry :P | 15:12 |
| *** Apoorva has joined #openstack-nova | 15:12 | |
| bauzas | mdbooth: no worries, you just owe me a beer :p | 15:12 |
| bauzas | et voila! | 15:12 |
| bauzas | interesting, creating a new mdev even if you have a kernel race works | 15:13 |
| bauzas | that's awesome news | 15:13 |
| bauzas | since the mdev is *really* created, you can ask libvirt to use it | 15:13 |
| bauzas | even if libvirt isn't able to show it per its API | 15:13 |
| bauzas | amazing | 15:13 |
| bauzas | so, one big caveat isn't really a big deal and not requiring a separate change | 15:14 |
| bauzas | just docs | 15:14 |
| bauzas | huzzah | 15:14 |
| efried | stephenfin Thanks, anything helps. TBH, there's not a lot of storage (or network) understanding required for these. The guts are in the pypowervm lib; these patches are really just translating the nova-ese to powervm-ese. | 15:14 |
| *** kumarmn has joined #openstack-nova | 15:14 | |
| *** hamzy has quit IRC | 15:17 | |
| *** tidwellr has joined #openstack-nova | 15:18 | |
| *** edmondsw has quit IRC | 15:18 | |
| mriedem | stephenfin: do you see anything obviously wrong with https://review.openstack.org/#/c/532689/ ? i ran it last night through the experimental queue but results were never posted back on the patch | 15:19 |
| * stephenfin looks | 15:19 | |
| *** cleong has joined #openstack-nova | 15:20 | |
| mriedem | i can see it queued up in the experimental queue in zuul right now | 15:20 |
| *** READ10 has joined #openstack-nova | 15:20 | |
| mriedem | gmann: https://review.openstack.org/#/c/330406/85/nova/api/openstack/compute/migrations.py@119 | 15:22 |
| mriedem | we have 2.0 and 2.1 all over the API, it doesn't seem to make a difference | 15:22 |
| openstackgerrit | sahid proposed openstack/nova master: hardware: only take into account small pages https://review.openstack.org/532168 | 15:24 |
| *** markvoelker has joined #openstack-nova | 15:24 | |
| *** edmondsw has joined #openstack-nova | 15:24 | |
| *** lajoskatona has quit IRC | 15:26 | |
| hongbin | mrodden: mlavalle : want to make a call on the full substring or partial substring debate https://review.openstack.org/#/c/521683/ ? | 15:26 |
| mlavalle | hongbin: I will later today. Thanks for the heads up | 15:27 |
| *** alexchad_ has joined #openstack-nova | 15:28 | |
| *** Eran_Kuris has quit IRC | 15:28 | |
| gibi | efried: opened the patches, but it won't fitt to my today's schedule | 15:29 |
| efried | gibi Thanks in advance | 15:29 |
| mriedem | hongbin: full substring | 15:30 |
| hongbin | mlavalle: mriedem : ack | 15:30 |
| *** slaweq_ has quit IRC | 15:30 | |
| *** slaweq has joined #openstack-nova | 15:31 | |
| *** alexchadin has quit IRC | 15:31 | |
| kashyap | Does anyone know what provides this one? I'm on CentOS 7.4, and DevStack fails with: | 15:32 |
| kashyap | $ rpm -qf `which generate-subunit` | 15:32 |
| kashyap | file /usr/bin/generate-subunit is not owned by any package | 15:32 |
| kashyap | (Err the failure message was: "./stack.sh: line 488: generate-subunit: command not found") | 15:32 |
| mriedem | ask in qa | 15:33 |
| *** yangyapeng has quit IRC | 15:33 | |
| kashyap | Yep, checking there | 15:33 |
| *** Swami has quit IRC | 15:33 | |
| *** kumarmn has left #openstack-nova | 15:35 | |
| *** janki has quit IRC | 15:35 | |
| kashyap | mriedem: Hehe, I found a bug with your comment (#5) -- https://bugs.launchpad.net/devstack/+bug/1547379 | 15:35 |
| openstack | Launchpad bug 1547379 in devstack "./stack.sh: line 488: generate-subunit: command not found" [Undecided,Invalid] | 15:35 |
| *** slaweq has quit IRC | 15:35 | |
| kashyap | It's indeed a mistake in my local.conf! | 15:36 |
| mriedem | exellent | 15:36 |
| mriedem | *excellent event | 15:36 |
| mriedem | *gdi | 15:36 |
| kashyap | (Because I copied my F27 local.conf to the old and sloth-like CentOS) | 15:36 |
| *** itlinux has joined #openstack-nova | 15:37 | |
| *** yamamoto has quit IRC | 15:37 | |
| *** felipemonteiro has joined #openstack-nova | 15:37 | |
| *** alexchad_ has quit IRC | 15:37 | |
| *** links has quit IRC | 15:38 | |
| *** yamamoto has joined #openstack-nova | 15:38 | |
| *** felipemonteiro_ has joined #openstack-nova | 15:38 | |
| *** yangyapeng has joined #openstack-nova | 15:38 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver https://review.openstack.org/526094 | 15:40 |
| *** yamamoto has quit IRC | 15:43 | |
| *** felipemonteiro has quit IRC | 15:43 | |
| stephenfin | mriedem: I can't see anything obvious, no. I'm guessing it's just zuul funkiness | 15:44 |
| stephenfin | There's been a lot of that this week | 15:44 |
| *** sshwarts has joined #openstack-nova | 15:45 | |
| *** itlinux has quit IRC | 15:47 | |
| *** hamzy has joined #openstack-nova | 15:48 | |
| mriedem | stvnoyes: ildikov: jgriffith: about 10pm last night i thought about this https://etherpad.openstack.org/p/multi-attach-volume-queens - see L48 | 15:48 |
| mriedem | stephenfin: yeah, thanks for looking. have'nt merged any patches in 2 days... | 15:48 |
| *** ragiman has quit IRC | 15:50 | |
| ildikov | mriedem: does that apply to live_migrate as well? | 15:50 |
| *** kholkina has quit IRC | 15:50 | |
| *** tidwellr_ has joined #openstack-nova | 15:50 | |
| *** kholkina has joined #openstack-nova | 15:51 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver https://review.openstack.org/526094 | 15:51 |
| mriedem | ildikov: no | 15:51 |
| mriedem | ildikov: with live migration, it's the same volume attached on both the source and dest nodes, | 15:51 |
| mriedem | and it's using the same disk config xml which already has the shareable flag set for the source guest xml | 15:51 |
| *** bkopilov has joined #openstack-nova | 15:51 | |
| ildikov | ok, I wasn't sure about the config on the dest | 15:51 |
| mriedem | i think this is purely a swap volume wrinkle | 15:51 |
| *** esberglu has quit IRC | 15:52 | |
| mriedem | so i think i need to handle that in between the libvirt patch and https://review.openstack.org/#/c/531244/ | 15:52 |
| mriedem | since https://review.openstack.org/#/c/531244/ bumps the rpc version | 15:52 |
| stvnoyes | mriedem: at this point in Queens, what about explicitly not allowing swap volume if the volume is MA'd? Then we can test swap more exhaustively for rocky... | 15:52 |
| *** xnox has quit IRC | 15:53 | |
| *** sshwarts has quit IRC | 15:53 | |
| *** tidwellr has quit IRC | 15:53 | |
| mriedem | stvnoyes: because that means you'd need a new microversion for swap volume with multiattach support in rocky, and that would mean cinder (using nova client) would have to know to send that microversoin if swapping with a MA volume | 15:53 |
| *** alexchadin has joined #openstack-nova | 15:53 | |
| mriedem | stvnoyes: what needs to happen is like a 3 line code change i think | 15:54 |
| ildikov | mriedem: I'm good with your solution | 15:54 |
| stvnoyes | ah ok | 15:54 |
| mriedem | if new_volume['multattach']: new_connection_info['multiattach'] = True | 15:54 |
| ildikov | yep | 15:54 |
| mriedem | thinking about a tempest test scenario to tickle this... | 15:54 |
| mriedem | attach non-multiattach volume A, swap to multiattach volume B, then attach B to a 2nd serer | 15:55 |
| mriedem | *server | 15:55 |
| mriedem | if we didn't fix the swap volume piece, the 2nd attach for B on the 2nd server should be wonky | 15:55 |
| ildikov | mriedem: do we track if the old volume was multiattach, but the new one is not? | 15:55 |
| *** kholkina has quit IRC | 15:55 | |
| mriedem | ildikov: no. we can figure that out if needed, but i'm not sure if we care. | 15:55 |
| mriedem | we did say in the cinder spec that you can't retype an in-use volume to change it's multiattach value | 15:56 |
| ildikov | but with swap it's a new volume? | 15:56 |
| ildikov | anyway, if the shareable flag cannot appear in the xml by accident for a non-multiattach volume, then good | 15:57 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: create vGPU for instance https://review.openstack.org/528832 | 15:57 |
| *** xnox has joined #openstack-nova | 15:58 | |
| *** xnox has joined #openstack-nova | 15:58 | |
| mriedem | i'm not entirely sure how the various retype and volume migration stuff works on the cinder side | 15:58 |
| mriedem | retype is like a resize in nova right? new flavor/volume type | 15:58 |
| mriedem | volume migration is not a change in volume type, but it migrates the volume from one backend to another of the same type? | 15:58 |
| *** derekh has quit IRC | 15:59 | |
| mriedem | anywho, meeting time | 15:59 |
| ildikov | yeah, I guess you're right, I always confuse myself with the different types of swap... | 15:59 |
| *** Guest88600 has quit IRC | 16:03 | |
| *** sree has joined #openstack-nova | 16:04 | |
| *** itlinux has joined #openstack-nova | 16:08 | |
| *** sree has quit IRC | 16:09 | |
| *** slaweq has joined #openstack-nova | 16:09 | |
| *** miguel1 has joined #openstack-nova | 16:09 | |
| bauzas | mdbooth: updated based on your comments | 16:10 |
| *** slaweq has quit IRC | 16:13 | |
| *** slaweq_ has joined #openstack-nova | 16:13 | |
| *** mlavalle has quit IRC | 16:14 | |
| *** miguel1 has quit IRC | 16:14 | |
| *** mlavalle has joined #openstack-nova | 16:15 | |
| *** tidwellr_ has quit IRC | 16:17 | |
| *** slaweq_ has quit IRC | 16:17 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Address nits in change I7e01f95d7173d9217f76e838b3ea71555151ef56 https://review.openstack.org/532898 | 16:18 |
| *** tidwellr has joined #openstack-nova | 16:18 | |
| *** sahid has quit IRC | 16:19 | |
| *** alexchadin has quit IRC | 16:24 | |
| *** alexchadin has joined #openstack-nova | 16:25 | |
| *** esberglu has joined #openstack-nova | 16:26 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Amend the migration paging spec for uuid in server migrations response https://review.openstack.org/532904 | 16:27 |
| mriedem | nova-multiattach job failed with NODE_FAILURE in the experimental queue :( | 16:28 |
| mdbooth | bauzas: Hey, can you try a couple of things on your mdev box and document the results: create more mdevs than permitted, and create an mdev with an invalid name. | 16:28 |
| bauzas | mdbooth: I'm just trying the former :) | 16:28 |
| *** alexchadin has quit IRC | 16:29 | |
| mdbooth | bauzas: The BFL around that function is fine by me. How do you plan to address all the other places which call _get_guest_xml? | 16:29 |
| *** sree has joined #openstack-nova | 16:30 | |
| ildikov | mriedem: sadness :( | 16:31 |
| *** Eran_Kuris has joined #openstack-nova | 16:34 | |
| *** sree has quit IRC | 16:34 | |
| *** maciejjozefczyk has quit IRC | 16:35 | |
| mnaser | from what i understand, once an instance is scheduled in a cell, it will forever remain in that cell (rebuilds, live migrations, etc?) | 16:36 |
| *** maciejjozefczyk has joined #openstack-nova | 16:36 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Track provider traits in report client https://review.openstack.org/521686 | 16:36 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Track associated sharing RPs in report client https://review.openstack.org/526539 | 16:36 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Raise on API errors getting aggregates/traits https://review.openstack.org/526540 | 16:36 |
| openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.populate_from_iterable https://review.openstack.org/520756 | 16:36 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Track tree-associated providers in report client https://review.openstack.org/526541 | 16:36 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Raise conflict exception on RP create 409 https://review.openstack.org/532563 | 16:36 |
| openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.set_traits_for_provider https://review.openstack.org/532564 | 16:36 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Scheduler[Report]Client.get_provider_tree https://review.openstack.org/521098 | 16:36 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | 16:36 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 16:36 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | 16:36 |
| bauzas | mdbooth: yup, in separate change | 16:36 |
| efried | gibi If you're still around, would you please re+W https://review.openstack.org/521686 (just rebased) | 16:37 |
| bauzas | mdbooth: oh shit, I forgot to amend the relnote telling that limitation | 16:37 |
| bauzas | (basically, don't touch your instance for the moment once it's up) | 16:37 |
| mdbooth | bauzas: Commented. | 16:37 |
| efried | mgoddard Un-WIP'd SchedulerReportClient.set_traits_for_provider https://review.openstack.org/532564 -- see how ya like it. | 16:37 |
| efried | mgoddard And maybe let's talk about peeling it out of that series so you can make use of it. | 16:38 |
| mriedem | need a couple of cores to review the 2.57 novaclient change https://review.openstack.org/#/c/528128/ | 16:38 |
| mriedem | and 2.58 above it | 16:38 |
| mriedem | and 2.59 is approved | 16:38 |
| mriedem | client freeze is in 2 weeks | 16:38 |
| maciejjozefczyk | mriedem: about https://review.openstack.org/#/c/520024/ | 16:38 |
| maciejjozefczyk | mriedem: found :) | 16:38 |
| mdbooth | bauzas: Is it really useful to land in that state? The code is pretty cleanly separated. It's kinda annoying that the libvirt folks half-landed mdev for eg, and now we can't tell which version we're supposed to required. | 16:39 |
| maciejjozefczyk | mriedem: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py?utf8=✓#L613 | 16:39 |
| bauzas | mriedem: ack, top prio list of reviews, starred | 16:40 |
| bauzas | API microversion client side changes are like more important than feature prios to me | 16:40 |
| *** burt has joined #openstack-nova | 16:40 | |
| mriedem | maciejjozefczyk: so it overwrites the ComputeNode allocation ratios which are set in code, to the self allocation ratios set in the RT via the config options? | 16:41 |
| mriedem | maciejjozefczyk: i'm guessing that's in there in case the operator changed the configs and restarted the service | 16:41 |
| maciejjozefczyk | mriedem: yes | 16:42 |
| mriedem | but maybe https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py?utf8=%E2%9C%93#L148 should match what's in the compute node object... | 16:42 |
| maciejjozefczyk | mriedem: if not 0; then rewrite ;P ? | 16:42 |
| mriedem | CONF.cpu_allocation_ratio or 16.0 | 16:42 |
| mriedem | something like that | 16:42 |
| mriedem | maciejjozefczyk: or that | 16:42 |
| *** gszasz has quit IRC | 16:42 | |
| mriedem | it's definitely shitty that we have multiple places writing this value into the ocmpute node record | 16:42 |
| maciejjozefczyk | mriedem: so.. should i create other bug and then fix it? | 16:43 |
| mriedem | as evidenced by the fact it took 3 of us 3 hours yesterday to figure this out | 16:43 |
| maciejjozefczyk | mriedem: maybe move it to common | 16:43 |
| mriedem | maciejjozefczyk: sure | 16:43 |
| mriedem | i think we have to leave what's in the compute node object | 16:43 |
| mriedem | but the RT stuff definitely isn't obvious | 16:43 |
| mriedem | fyi to anyone that's interested in what's going on with the gate http://grafana.openstack.org/dashboard/db/zuul-status | 16:44 |
| mriedem | executors are maxed out so throughput is down | 16:45 |
| mriedem | recheck grind is also killing things | 16:45 |
| mriedem | so if you have a patch queued up in zuul, no need to recheck it | 16:45 |
| mriedem | add the change number to http://status.openstack.org/zuul/ if you want to see if it's queue | 16:45 |
| mriedem | *queued | 16:45 |
| mriedem | or use https://github.com/openstack/gerrit-dash-creator | 16:46 |
| *** cdent has quit IRC | 16:47 | |
| *** mlavalle has quit IRC | 16:47 | |
| bauzas | mdbooth: very interesting, I'm trying to allocate 2 vGPUs on a single VM | 16:47 |
| bauzas | libvirt fails miserably | 16:47 |
| *** dtantsur is now known as dtantsur|afk | 16:47 | |
| *** mlavalle has joined #openstack-nova | 16:47 | |
| bauzas | I guess because of the nvidia driver | 16:48 |
| mdbooth | bauzas: Other fun things: allocate 1 vgpu to 2 vms. Create an mdev of each of 2 different types. | 16:48 |
| *** mlavalle has quit IRC | 16:48 | |
| mdbooth | bauzas: It would be awesome to document all these failure modes somewhere in a code comment. Maybe the privsep function? | 16:49 |
| bauzas | mdbooth: my code prevents that | 16:49 |
| bauzas | mdbooth: we only support one type | 16:49 |
| mdbooth | Yeah, I know. | 16:49 |
| bauzas | and that's documented in the relnote | 16:49 |
| mdbooth | bauzas: Right, but I'm just thinking it's interesting to understand our failure modes, and most people don't have the hardware to hand to test it. | 16:49 |
| bauzas | for the multi-assignment of the same mediated device, that should also be in theory avoided by my code, except if bugs | 16:49 |
| mdbooth | Will help reviewers/maintainers, for eg | 16:50 |
| bauzas | mdbooth: I mean, what would you like to see ? | 16:50 |
| *** aloga_ has quit IRC | 16:50 | |
| * mdbooth is interested to know what the bugs would look like if they happened | 16:50 | |
| bauzas | mdbooth: I can try to change the conf opt | 16:50 |
| mdbooth | So do we see a failure on creating the mdev? | 16:50 |
| *** mlavalle has joined #openstack-nova | 16:50 | |
| mdbooth | Or subsequently when we try to use it? | 16:50 |
| bauzas | you mean the privsep call ? | 16:50 |
| mdbooth | And in either case, what form does the failure take? | 16:51 |
| mdbooth | Yeah | 16:51 |
| *** damien_r has quit IRC | 16:51 | |
| bauzas | what I haven't checked is what happens if I modify the conf opt and ask for another type | 16:51 |
| mdbooth | bauzas: That's an extremely nice to have, btw. | 16:51 |
| *** aloga_ has joined #openstack-nova | 16:51 | |
| bauzas | in theory, it should say 0 available resources | 16:51 |
| bauzas | because some mediated devices are already created for the existing guests, so the other resources are 0 | 16:52 |
| mdbooth | If you're testing this stuff anyway, if you could squirrel away what real failures look like it would be really useful. | 16:52 |
| bauzas | well, for that physical GPU | 16:52 |
| *** cdent has joined #openstack-nova | 16:52 | |
| bauzas | mdbooth: well, an instance leading to an ERROR state is okay to me, if that's documented why | 16:53 |
| bauzas | like, if you make a flavor that asks for 2 VGPUs, it won't work | 16:53 |
| bauzas | that's the caveats I mentioned in my note | 16:53 |
| *** AlexeyAbashkin has quit IRC | 16:53 | |
| *** chyka has joined #openstack-nova | 16:55 | |
| *** pcaruana|afk| has quit IRC | 16:57 | |
| *** felipemonteiro_ has quit IRC | 16:58 | |
| *** penick has joined #openstack-nova | 17:00 | |
| *** mlavalle has quit IRC | 17:01 | |
| *** penick has quit IRC | 17:04 | |
| *** matrohon has quit IRC | 17:07 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver https://review.openstack.org/526094 | 17:07 |
| *** fragatina has joined #openstack-nova | 17:11 | |
| dansmith | mriedem: cdent: I just want to say that us passing around dicts of placement api goo in our scheduler paths is really not ideal | 17:12 |
| dansmith | I'm changing the microversion I make a call at, which changes that format, | 17:12 |
| dansmith | and thus a bunch of obscure dict manipulation code paths have to change in weird ways | 17:12 |
| cdent | yeah, I made a similar comment on a recent bug report | 17:13 |
| dansmith | if we had a proper client-side model of this it would be a lot easier to maintain | 17:13 |
| cdent | of the 'when we bump to the new microversion this stuff gonna go funkity' | 17:13 |
| mriedem | client side model like an object? | 17:13 |
| dansmith | mriedem: yes | 17:13 |
| mriedem | leave a todo in the patch? | 17:14 |
| dansmith | if I ever get it working | 17:14 |
| *** mlavalle has joined #openstack-nova | 17:15 | |
| *** links has joined #openstack-nova | 17:17 | |
| *** links has quit IRC | 17:17 | |
| *** lucasagomes is now known as lucas-afk | 17:19 | |
| *** suresh12 has joined #openstack-nova | 17:21 | |
| *** fragatina has quit IRC | 17:23 | |
| *** fragatina has joined #openstack-nova | 17:23 | |
| *** amotoki has quit IRC | 17:24 | |
| *** penick has joined #openstack-nova | 17:24 | |
| *** rabel__b1 has quit IRC | 17:27 | |
| *** Apoorva has quit IRC | 17:28 | |
| efried | dansmith An object like ProviderTree? Though also presumably an equivalent for allocation candidates. | 17:29 |
| dansmith | efried: well, kinda yeah | 17:29 |
| edleafe | dansmith: aren't we treating them as opaque blobs, as originally designed? I know there was the doubking up hack, but that should no longer be necessary | 17:31 |
| cdent | edleafe: they've changed shape | 17:31 |
| cdent | and they get manipulated | 17:31 |
| cdent | so not really opaque (last I checked) | 17:31 |
| * edleafe dies a little more | 17:31 | |
| bauzas | dansmith: not sure you saw the long convo I had with mdbooth but before I leave for 2.5 hours (will be back later), just food for thoughts | 17:32 |
| cdent | I can't remember why they get manipulated | 17:32 |
| cdent | My ability to index this stuff for memory is broken | 17:32 |
| dansmith | edleafe: not in the scheduler | 17:33 |
| dansmith | edleafe: I'm not having any problems with the code that treats it as opaque | 17:33 |
| bauzas | dansmith: since we create mediated devices on the fly (or allocate them) based on allocations, and generate the guest config with that, thanks to allocations, it means that when you power off and then power on again, you get a guest that no longer has VGPUs because we don't pass (yet) the allocations to power_on() | 17:33 |
| *** slaweq has joined #openstack-nova | 17:33 | |
| dansmith | bauzas: okay | 17:33 |
| bauzas | dansmith: everything works seamlessly when booting, so https://review.openstack.org/#/c/528832/ is ready for reviews, but I'll need to address that issue in a follow-up | 17:33 |
| *** homeski has joined #openstack-nova | 17:34 | |
| homeski | Question for anyone ... | 17:34 |
| homeski | I have a instance booted from volume, where the volume gets attached using the IDE bus | 17:34 |
| homeski | is there a way, using OSP CLI, to have the boot device remounted using virtio ? | 17:34 |
| homeski | ight now I have to manually `virsh edit` the XML | 17:34 |
| homeski | Also, if I attach any additional volumes, they always get attached using IDE, even if I have `disk_bus=virtio` set on the volume metadata | 17:35 |
| homeski | I have to keep messing with the XML manually | 17:35 |
| dansmith | edleafe: and we can't get rid of the doubling until rocky, AFAIK, because pike computes still depends on it | 17:35 |
| dansmith | homeski: see topic please | 17:36 |
| homeski | gotcha, thx | 17:36 |
| edleafe | dansmith: sure, what I was asking was if that was a one-off thing, and that we aren't doing any more of it | 17:36 |
| dansmith | edleafe: that's the biggest wart, yeah | 17:37 |
| *** slaweq has quit IRC | 17:37 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.generation_for https://review.openstack.org/532922 | 17:39 |
| *** aloga_ has quit IRC | 17:40 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver https://review.openstack.org/526094 | 17:46 |
| -openstackstatus- NOTICE: Due to an unexpected issue with zuulv3.o.o, we were not able to preserve running jobs for a restart. As a result, you'll need to recheck your previous patchsets | 17:47 | |
| *** Apoorva has joined #openstack-nova | 17:53 | |
| *** sambetts is now known as sambetts|afk | 17:54 | |
| *** jistr is now known as jistr|afk | 17:55 | |
| *** penick has quit IRC | 17:56 | |
| openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: WIP: Do not normalize allocation_ratios https://review.openstack.org/532924 | 17:57 |
| maciejjozefczyk | mriedem: https://review.openstack.org/532924 | 17:58 |
| *** suresh12 has quit IRC | 17:58 | |
| maciejjozefczyk | mriedem: IMO instead doing additional if statements in RT we should do it clean and set default values in config files as it should be done eariler (starting from newton) - if I understand the problem correctly | 17:58 |
| maciejjozefczyk | its draft, without test changes | 17:59 |
| *** liverpooler has quit IRC | 17:59 | |
| maciejjozefczyk | tests* | 17:59 |
| mriedem | maciejjozefczyk: i don't know about the implications of changing the defaults in the config file | 17:59 |
| *** jdillaman has quit IRC | 17:59 | |
| mriedem | that's all bauzas territory | 17:59 |
| *** yamamoto has joined #openstack-nova | 18:00 | |
| *** nicolasbock has joined #openstack-nova | 18:00 | |
| mriedem | i don't know the history behind why we had 0.0 in config and hard-coded values in code | 18:00 |
| maciejjozefczyk | mriedem: It was (at least I can read it from comments) about backwards compatibility to Liberty, i think | 18:01 |
| maciejjozefczyk | bauzas: hello :) could you please check https://review.openstack.org/532924 if the idea is ok for you? thanks! | 18:02 |
| *** liverpooler has joined #openstack-nova | 18:02 | |
| *** ralonsoh has quit IRC | 18:04 | |
| *** yamamoto has quit IRC | 18:04 | |
| *** penick has joined #openstack-nova | 18:05 | |
| dansmith | mriedem: for the overcommit ratios? | 18:05 |
| dansmith | allocation_ratio yeah | 18:05 |
| dansmith | that is our sentinel to the scheduler to obey what the compute reports in the db instead of using config | 18:06 |
| dansmith | when we moved that stuff | 18:06 |
| dansmith | if 0.0, then 16.0 for cpu, etc | 18:06 |
| dansmith | heh that patch just undoes it without historical context I think | 18:06 |
| dansmith | bauzas: ^ | 18:06 |
| dansmith | he has the full story in his head I bet | 18:07 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Pass limit to /allocation_requests https://review.openstack.org/531517 | 18:08 |
| *** maciejjozefczyk is now known as maciejjozefczyk_ | 18:09 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass multiattach flag to reserve_block_device_name https://review.openstack.org/531244 | 18:10 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: [api] Allow multi-attach in compute api https://review.openstack.org/271047 | 18:10 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle swapping to a multiattach volume https://review.openstack.org/532928 | 18:10 |
| mriedem | ildikov: gibi: johnthetubaguy: ^ swap volume change is in the middle | 18:10 |
| ildikov | mriedem: gorgeous, thank you! | 18:11 |
| *** weshay is now known as weshay_interview | 18:14 | |
| *** jpena is now known as jpena|off | 18:16 | |
| *** jdillaman has joined #openstack-nova | 18:16 | |
| *** AlexeyAbashkin has joined #openstack-nova | 18:20 | |
| *** AlexeyAbashkin has quit IRC | 18:24 | |
| *** mvk has quit IRC | 18:32 | |
| *** suresh12 has joined #openstack-nova | 18:33 | |
| *** Tom-Tom has joined #openstack-nova | 18:36 | |
| *** suresh12 has quit IRC | 18:39 | |
| *** Tom-Tom has quit IRC | 18:40 | |
| *** Tom-Tom has joined #openstack-nova | 18:41 | |
| *** sree has joined #openstack-nova | 18:43 | |
| *** suresh12 has joined #openstack-nova | 18:44 | |
| *** tesseract has quit IRC | 18:45 | |
| *** sree has quit IRC | 18:47 | |
| *** sridharg has quit IRC | 18:48 | |
| *** penick has quit IRC | 18:50 | |
| *** yamahata has joined #openstack-nova | 18:53 | |
| *** felipemonteiro has joined #openstack-nova | 18:55 | |
| *** felipemonteiro_ has joined #openstack-nova | 18:56 | |
| *** AlexeyAbashkin has joined #openstack-nova | 18:57 | |
| *** cdent has quit IRC | 18:59 | |
| *** hemna_ has joined #openstack-nova | 18:59 | |
| *** sree has joined #openstack-nova | 19:00 | |
| *** felipemonteiro has quit IRC | 19:00 | |
| *** AlexeyAbashkin has quit IRC | 19:01 | |
| *** penick has joined #openstack-nova | 19:04 | |
| *** sree has quit IRC | 19:05 | |
| *** sree has joined #openstack-nova | 19:06 | |
| *** sree has quit IRC | 19:10 | |
| *** penick has quit IRC | 19:10 | |
| *** suresh12 has quit IRC | 19:15 | |
| *** penick has joined #openstack-nova | 19:15 | |
| *** liverpooler has quit IRC | 19:15 | |
| *** weshay_interview is now known as weshay | 19:16 | |
| *** suresh12 has joined #openstack-nova | 19:18 | |
| *** penick has quit IRC | 19:20 | |
| *** slaweq has joined #openstack-nova | 19:20 | |
| *** avolkov has quit IRC | 19:22 | |
| *** karthiks has quit IRC | 19:23 | |
| *** karthiks has joined #openstack-nova | 19:24 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.populate_from_iterable https://review.openstack.org/520756 | 19:24 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Track tree-associated providers in report client https://review.openstack.org/526541 | 19:24 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Raise conflict exception on RP create 409 https://review.openstack.org/532563 | 19:24 |
| openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.set_traits_for_provider https://review.openstack.org/532564 | 19:24 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Scheduler[Report]Client.get_provider_tree https://review.openstack.org/521098 | 19:24 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | 19:24 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 19:24 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | 19:24 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Fix invalid UUIDs in test_compute.py https://review.openstack.org/531479 | 19:24 |
| *** itlinux has quit IRC | 19:26 | |
| *** suresh12 has quit IRC | 19:26 | |
| *** smatzek has quit IRC | 19:27 | |
| mriedem | edleafe: comments in the resize + alternates patch https://review.openstack.org/#/c/526436/ | 19:28 |
| *** smatzek has joined #openstack-nova | 19:28 | |
| mriedem | as far as i can tell, there is nothing in there claiminig resources on the alternate hosts | 19:28 |
| *** alexchadin has joined #openstack-nova | 19:29 | |
| mriedem | dansmith: we need to get this fixed before rc1 https://review.openstack.org/#/q/topic:bug/1741307+project:openstack/nova | 19:30 |
| *** suresh12 has joined #openstack-nova | 19:30 | |
| *** sree has joined #openstack-nova | 19:30 | |
| dansmith | okay | 19:30 |
| *** smatzek has quit IRC | 19:33 | |
| *** sree has quit IRC | 19:34 | |
| *** liverpooler has joined #openstack-nova | 19:38 | |
| sean-k-mooney | mriedem: if we do a release of os-vif on monday are you ok with bumping the minium version for queens | 19:38 |
| *** suresh12 has quit IRC | 19:39 | |
| mriedem | i won't be around on monday | 19:40 |
| mriedem | i was going to do the os-vif release today, and os-traits for that matter | 19:40 |
| mriedem | now that you mention it | 19:40 |
| mriedem | dansmith: melwitt: thanks for getting those; i'll add something to the ptg etherpad about migrating caching scheduler people to filter scheduler | 19:40 |
| sean-k-mooney | mriedem: it would be nice to include https://review.openstack.org/#/q/status:open+project:openstack/os-vif+branch:master+topic:bug/1672812 and https://review.openstack.org/#/q/status:open+project:openstack/os-vif+branch:master+topic:bug/1666917 in queens | 19:41 |
| mriedem | jesus | 19:42 |
| *** eharney has quit IRC | 19:42 | |
| mriedem | and what requires the minimum version bumps for those? | 19:42 |
| *** harlowja has joined #openstack-nova | 19:43 | |
| mriedem | with jay on his deathbed i'm not sure how that's going to get done | 19:43 |
| sean-k-mooney | mriedem: sorry i ment to say upperconstriats not minium version | 19:43 |
| mriedem | u-c bumps are automatic | 19:43 |
| mriedem | g-r bumps are when some consumer needs to rely on the changes | 19:43 |
| mriedem | and presumably we're doing this work so something can use it | 19:44 |
| *** eharney has joined #openstack-nova | 19:44 | |
| sean-k-mooney | its used by os-vif itself it allow use to not use process exec to create port and insted use the openvswitch python libs | 19:44 |
| mriedem | sean-k-mooney: ok, but that's not a super high priority is it? | 19:45 |
| mriedem | at this point in queens i think that's a bit risky | 19:45 |
| mriedem | and would be better deferred to an early release in rocky | 19:45 |
| *** suresh12 has joined #openstack-nova | 19:45 | |
| sean-k-mooney | its just a nice to have yes so it we branched today and did a release it would not break anything | 19:46 |
| mriedem | has claudiub seen this? https://review.openstack.org/#/c/487405/ | 19:47 |
| mriedem | i think the hyperv driver is using os-vif so how are they not blowing up? | 19:47 |
| sean-k-mooney | the code that is pertected by the if would not fail if the if was removed so it does not explode | 19:47 |
| *** edmondsw_ has joined #openstack-nova | 19:48 | |
| *** edmonds__ has joined #openstack-nova | 19:48 | |
| sean-k-mooney | that said checking if an interface exists via a file exits check under sys on windows is not exactly well fucntional | 19:48 |
| mriedem | the other 2 things in https://review.openstack.org/#/q/status:open+project:openstack/os-vif+branch:master+topic:bug/1672812 are not really something we need to get released | 19:49 |
| mriedem | the testing related patches i mean | 19:49 |
| mriedem | so i'm going to push an os-vif release today, and if something else gets in afteward before next thursday, bauzas or someone can propose a release | 19:49 |
| sean-k-mooney | mriedem: ok that sound fine to me | 19:50 |
| sean-k-mooney | as i said they are just nice to have not required | 19:50 |
| mriedem | sean-k-mooney: kit me up when rocky rolls around and we can push for the native ovs ones | 19:50 |
| mriedem | *hit me up | 19:50 |
| *** alexchadin has quit IRC | 19:51 | |
| sean-k-mooney | sure. we are keeping support for process exec and not enableing it by default anyway. we had push out makeing that change to S instead. | 19:51 |
| *** edmondsw has quit IRC | 19:52 | |
| sean-k-mooney | has a name been chosen for S yet by the way | 19:52 |
| *** edmondsw_ has quit IRC | 19:52 | |
| *** itlinux has joined #openstack-nova | 19:54 | |
| *** itlinux has quit IRC | 19:55 | |
| *** jistr|afk is now known as jistr | 19:57 | |
| *** smatzek has joined #openstack-nova | 19:57 | |
| *** sree has joined #openstack-nova | 19:59 | |
| *** Apoorva has quit IRC | 20:01 | |
| *** sree has quit IRC | 20:04 | |
| mriedem | squish | 20:07 |
| mriedem | shizer? | 20:07 |
| *** mvk has joined #openstack-nova | 20:08 | |
| bauzas | mriedem: sylvain :p | 20:10 |
| mriedem | there is nothing german about that | 20:10 |
| mriedem | shizer it is | 20:10 |
| bauzas | schnauze :p | 20:11 |
| bauzas | mriedem: question for https://review.openstack.org/#/c/528128/7/novaclient/exceptions.py | 20:12 |
| bauzas | mriedem: why ? | 20:12 |
| mriedem | because if you do six.text_type(ex) you don't get the message from the exception | 20:12 |
| *** sree has joined #openstack-nova | 20:12 | |
| bauzas | interesting to know | 20:13 |
| mriedem | https://review.openstack.org/#/c/528128/7/novaclient/tests/unit/v2/test_servers.py@1640 | 20:13 |
| mriedem | if you remove it, that stuff blows up | 20:13 |
| dansmith | bauzas: if we name it that, people will be pronouncing it wrong for a long time | 20:13 |
| bauzas | I know :p | 20:14 |
| *** sree has quit IRC | 20:16 | |
| sean-k-mooney | like meltdown and specter im sure marketing will prevent any name being chossen that would not be family frendly | 20:22 |
| sean-k-mooney | or well are inside/techy jokes | 20:23 |
| bauzas | dansmith: got a sec ? | 20:25 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: QEMU native LUKS decryption for volumes https://review.openstack.org/523958 | 20:25 |
| dansmith | bauzas: finishing an email, but then yes | 20:25 |
| bauzas | dansmith: cool | 20:25 |
| bauzas | dansmith: that's just about the libvirt issue about regenerating a wrong XML because missing allocs | 20:26 |
| bauzas | so take your time | 20:26 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver https://review.openstack.org/526094 | 20:27 |
| efried | Could one of y'all please re+W https://review.openstack.org/#/c/521686/ (auto rebase) | 20:27 |
| *** penick has joined #openstack-nova | 20:27 | |
| bauzas | efried: . | 20:28 |
| efried | bauzas Merci bien. | 20:28 |
| *** READ10 has quit IRC | 20:29 | |
| *** Tom-Tom has quit IRC | 20:31 | |
| *** pchavva has quit IRC | 20:31 | |
| mriedem | stvnoyes: on those tempest patches, when you push the changes, you need to use git review -R | 20:32 |
| *** Tom-Tom has joined #openstack-nova | 20:32 | |
| mriedem | you pulled my approved changes out of the gate | 20:32 |
| mriedem | stvnoyes: i thought you were going to push a separate patch on top of https://review.openstack.org/#/c/266605/ ? not add to it. | 20:32 |
| *** imacdonn has quit IRC | 20:33 | |
| stvnoyes | hmm cr*p. what's the best way to undo that? | 20:33 |
| *** imacdonn has joined #openstack-nova | 20:33 | |
| stvnoyes | i can submit a new change that pulls it out... | 20:33 |
| claudiub | mriedem: so, at the moment, hyperv-neutron-agent is still used in the CI. But i've fetched that patch and instances still spawn when using OVS. | 20:34 |
| mriedem | stvnoyes: too late now | 20:34 |
| mriedem | well too late for the git review -R | 20:34 |
| mriedem | stvnoyes: you could just put the resize test on top in a different change | 20:34 |
| mriedem | just don't git commit --amend | 20:34 |
| *** tbachman has quit IRC | 20:35 | |
| stvnoyes | just to be clear, on top, you mean by using depends on? | 20:35 |
| *** penick has quit IRC | 20:35 | |
| mriedem | no | 20:35 |
| mriedem | stack the changes like i've done in that series | 20:35 |
| mriedem | you don't need depends-on within the same repo | 20:35 |
| mriedem | so just remove the resize test from the top patch, then commit it into a new change at the top of the series, | 20:36 |
| sean-k-mooney | claudiub: ya the way os-vif is written it should work with or without the patch but it annoys me that it works just because we happened ot make the functions not fail if there preconditions were violated | 20:36 |
| mriedem | and then git review -R -y | 20:36 |
| stvnoyes | ok | 20:36 |
| *** Tom-Tom has quit IRC | 20:36 | |
| mriedem | if you need to go back within the series to change something, you do an interactive rebase (git rebase -i HEAD~4) or whatever | 20:36 |
| *** tbachman has joined #openstack-nova | 20:37 | |
| efried | git restack is your friend | 20:39 |
| efried | Well, *my* friend, anyway. | 20:40 |
| sean-k-mooney | efried: git restack? | 20:40 |
| sean-k-mooney | i use git rebase -i often but never heard of git restack | 20:41 |
| efried | sean-k-mooney It rolls up rebase -i and some of the other paperwork associated with managing a big series. | 20:41 |
| *** eharney has quit IRC | 20:41 | |
| efried | sean-k-mooney I think it was developed by stackers. Separate plugin. pip install git-restack (I think) | 20:41 |
| sean-k-mooney | https://github.com/openstack-infra/git-restack so yes | 20:41 |
| sean-k-mooney | git review is also an infra tool | 20:41 |
| efried | no kidding, really? TIL | 20:42 |
| efried | Was using that long before I got involved with openstack. | 20:42 |
| sean-k-mooney | yep https://github.com/openstack-infra/git-review | 20:42 |
| *** matrohon has joined #openstack-nova | 20:43 | |
| sean-k-mooney | efried: stephenfin: also intoduced me to gerrithub.io which allows you to add gerrit to any github project so you can use the openstack/gerrit workflow with it insteadk of pull requests | 20:44 |
| efried | oooooooo | 20:44 |
| bauzas | I don't like git restack | 20:44 |
| *** penick has joined #openstack-nova | 20:44 | |
| bauzas | I prefer the old but clean way | 20:44 |
| efried | Would you like it better if it was git restaque? | 20:45 |
| bauzas | because something you can be messed up in a long series and then git reflog is your friend | 20:45 |
| * efried looks up reflog... | 20:45 | |
| *** penick has quit IRC | 20:45 | |
| dansmith | bauzas: you never started talking | 20:45 |
| bauzas | dansmith: I was holding my breath till your email :p | 20:46 |
| dansmith | bauzas: I was expecting you to start asking your question and I'd get to it when I was done | 20:46 |
| dansmith | bauzas: but then I got distracted with no ping :) | 20:46 |
| bauzas | my bad, misunderstanding | 20:46 |
| dansmith | anyway, shoot | 20:46 |
| bauzas | so | 20:46 |
| bauzas | dansmith: in case you don't know yet, we're attaching a mdev device based on the allocation | 20:47 |
| bauzas | that works fine | 20:47 |
| bauzas | but the issue we have is that there are a shit ton of other methods that rebuild that guest XML, and those don't have the allocations passed yet | 20:47 |
| dansmith | 1.0 shit tons?\ | 20:48 |
| bauzas | I mean, spawn() is calling it, but also for example hard_reboot | 20:49 |
| bauzas | which itself is called by power_on()... | 20:49 |
| bauzas | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L2658 | 20:49 |
| dansmith | yeah, I get it | 20:49 |
| bauzas | so, I tested on my node, and indeed, if you stop/start your instance, you're not missing the mdev | 20:50 |
| bauzas | you're missing* | 20:50 |
| dansmith | not missing? | 20:50 |
| dansmith | heh yeah okay | 20:50 |
| bauzas | so there are 2 options | 20:50 |
| *** eharney has joined #openstack-nova | 20:51 | |
| bauzas | #1 pass the allocations down to where we need, exactly like we did for spawn() | 20:51 |
| bauzas | that means we need to modify every caller | 20:51 |
| *** aloga_ has joined #openstack-nova | 20:51 | |
| bauzas | #2 introspect the flavor rather than allocations | 20:51 |
| dansmith | #2 is cheating | 20:52 |
| *** eharney has quit IRC | 20:52 | |
| dansmith | the reason I asked about the fraction of shit tons is... how many actual calls are we talking about here? | 20:52 |
| *** penick has joined #openstack-nova | 20:52 | |
| *** mm6021 has joined #openstack-nova | 20:53 | |
| bauzas | lemme grep that | 20:53 |
| bauzas | my grep tells me 6 times | 20:54 |
| dansmith | that doesn't seem untenable to me | 20:54 |
| dansmith | granted you have to do it in multiple drivers, but.. it's not a billion | 20:55 |
| dansmith | that's like 0.0001 shit tons :) | 20:55 |
| bauzas | resume, unrescue, finish_migration, power_on and so far | 20:55 |
| dansmith | I guess the other thing we need to do is cache those in compute manager for when we need them because spawn brings them, but the other calls won't | 20:55 |
| dansmith | so the other way to look at this is, | 20:55 |
| bauzas | dansmith: 'those' == allocs ? | 20:56 |
| dansmith | that maybe this is a libvirt problem | 20:56 |
| dansmith | yes those == allocs | 20:56 |
| dansmith | like, I wonder if the other drivers would have this problem, or if they would just not blindly regenerate the vm definition | 20:56 |
| *** bigdogstl has joined #openstack-nova | 20:56 | |
| dansmith | you could just read the xml to get the mdev info before you blow it away, right? | 20:57 |
| *** matrohon has quit IRC | 20:57 | |
| dansmith | and you wouldn't need the full allocation | 20:57 |
| bauzas | dansmith: that's something I wondered earlier in the day | 20:57 |
| bauzas | I mean I was surprised to see we were generating the XML every time | 20:57 |
| dansmith | well, | 20:57 |
| dansmith | I don't think that refreshing it all the time is bad, | 20:57 |
| dansmith | because it gives us a chance to update things like the ceph monitor ip address and such | 20:58 |
| dansmith | but we don't have to do it blindly | 20:58 |
| bauzas | yeah I can understand that reasoning | 20:58 |
| bauzas | but yeah, instead of just amending what's needed, we're just wiping out the whole config | 20:58 |
| bauzas | anyway | 20:58 |
| bauzas | this is what it is | 20:58 |
| dansmith | you could probably write a clean utility method that is "get me the mdev(s) from $guest" and just call that everywhere | 20:58 |
| *** kenperkins has joined #openstack-nova | 20:59 | |
| dansmith | everywhere you need it that is.. don't call it EVERYWHERE :P | 20:59 |
| dansmith | and don't call it everywhere() because that won't be very obvious | 20:59 |
| * dansmith is a barrel of laughs this afternoon | 20:59 | |
| bauzas | I need to look at the driver code | 21:00 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Fix being able to create a reno using tox -e venv https://review.openstack.org/532971 | 21:00 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove deprecated MigrationManager.list cell_name kwarg https://review.openstack.org/532972 | 21:00 |
| *** Apoorva has joined #openstack-nova | 21:02 | |
| *** krtaylor has joined #openstack-nova | 21:02 | |
| cfriesen | Is it documented anywhere that deleting a quota-set for a tenant will also delete it for any users within that tenant? (This seems to be how it behaves, but I don't see it in the API ref.) | 21:02 |
| *** david-lyle has quit IRC | 21:03 | |
| melwitt | cfriesen: user quota is a subset of tenant quota so I think it would behave that way. and I doubt it's documented | 21:03 |
| *** krtaylor has quit IRC | 21:03 | |
| *** david-lyle has joined #openstack-nova | 21:04 | |
| cfriesen | melwitt: I can see the rationale, was just a bit unexpected. | 21:04 |
| *** krtaylor has joined #openstack-nova | 21:04 | |
| bauzas | dansmith: mmm, your last approach could work, except for migrations (but I think it's a silverlining) | 21:05 |
| dansmith | bauzas: we should have allocations passed for migrations I imagine | 21:05 |
| bauzas | dansmith: I mean, we can get the guest, hence its mdevs, before we regenerate it | 21:05 |
| dansmith | we have to look them up anyway | 21:05 |
| melwitt | cfriesen: yeah. user quota was an afterthought. originally it was tenant quota only (and I think it might go back that way eventually). so to tack on user quota, all they did was add a user column and filter on project AND user if user quota | 21:05 |
| bauzas | dansmith: right, I just feel migrations are off the scope for queens | 21:06 |
| *** Apoorva has quit IRC | 21:06 | |
| dansmith | yeah, but it's good to think about how it'd be handled | 21:06 |
| stvnoyes | mriedem: how exactly do I remove the test from the top patch? I don't want to make things worse. (git is not my strong point). | 21:06 |
| dansmith | we don't even know if libvirt could do that I guess | 21:06 |
| mriedem | stvnoyes: you just undo your change | 21:07 |
| mriedem | stvnoyes: want me to do it? | 21:07 |
| *** gouthamr has quit IRC | 21:07 | |
| stvnoyes | that might be easier, just let me know what you did, for future reference. | 21:07 |
| *** edmonds__ is now known as edmondsw | 21:07 | |
| stvnoyes | once you do that I'll submit a new change | 21:08 |
| edmondsw | mriedem sdague the PowerVM vSCSI patch is also ready for review now, which is the last one for that bp | 21:09 |
| sean-k-mooney | dansmith: bauzas just reading back im not that surprised to seee the xml being regenerated on hard reboots its requried for some config changes | 21:09 |
| dansmith | sean-k-mooney: yup | 21:09 |
| *** liverpooler has quit IRC | 21:10 | |
| dansmith | I've argued for doing it more often than we need even so we can freshen it, since some instances run for years without us getting to tweak things | 21:10 |
| sean-k-mooney | bauzas: you will need to be careful not to miss livemigration too as we regenerate part of the xml there also + resize | 21:10 |
| dansmith | we just don't need to do it blindly | 21:10 |
| *** masber has joined #openstack-nova | 21:10 | |
| *** matrohon has joined #openstack-nova | 21:12 | |
| *** sree has joined #openstack-nova | 21:12 | |
| cfriesen | sean-k-mooney: and for "proper" resource tracking on live migration with we need to update the XML before the live-migration call and update it with the resources to use on the new compute node. | 21:14 |
| mriedem | stvnoyes: done | 21:14 |
| *** gouthamr has joined #openstack-nova | 21:15 | |
| sean-k-mooney | cfriesen: yep we discussed that in some depth in the multiple port binding spec | 21:15 |
| mriedem | stvnoyes: i did this basically: | 21:15 |
| mriedem | 1. git review -d 266605 | 21:15 |
| *** bigdogstl has quit IRC | 21:15 | |
| mriedem | to pull down the series from gerrit since it's no longer my local changes | 21:15 |
| mriedem | 2. removed your test and committed that | 21:15 |
| sean-k-mooney | cfriesen: in that specific case we were talking about nics but its the same problem statement just in a different domain | 21:16 |
| mriedem | 3. added your test as a new commit | 21:16 |
| mriedem | 4. changed the author to you: git commit --amend --author <steve-o> | 21:16 |
| mriedem | 5. push it up: git review -R -y | 21:16 |
| *** sree has quit IRC | 21:17 | |
| stvnoyes | mriedem: thanks | 21:18 |
| *** penick has quit IRC | 21:18 | |
| *** penick has joined #openstack-nova | 21:23 | |
| *** aloga_ has quit IRC | 21:25 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove deprecate certs CLIs and python bindings https://review.openstack.org/532974 | 21:25 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove deprecated certs CLIs and python bindings https://review.openstack.org/532974 | 21:25 |
| *** suresh12 has quit IRC | 21:30 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove deprecated cloudpipe CLIs and python API bindings https://review.openstack.org/532976 | 21:31 |
| *** mlavalle has quit IRC | 21:32 | |
| *** mlavalle has joined #openstack-nova | 21:33 | |
| *** oomichi_ has joined #openstack-nova | 21:33 | |
| *** cleong has quit IRC | 21:33 | |
| *** smatzek has quit IRC | 21:42 | |
| bauzas | sean-k-mooney: dansmith: understood, will consider migrations in general by looking at allocations | 21:42 |
| bauzas | sean-k-mooney: dansmith: that said, my change is working for just spawning new instances https://review.openstack.org/#/c/528832/ | 21:43 |
| bauzas | so you can review it | 21:43 |
| *** sree has joined #openstack-nova | 21:43 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove deprecated MigrationManager.list cell_name kwarg https://review.openstack.org/532972 | 21:45 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove deprecated certs CLIs and python bindings https://review.openstack.org/532974 | 21:45 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove deprecated cloudpipe CLIs and python API bindings https://review.openstack.org/532976 | 21:45 |
| *** bigdogstl has joined #openstack-nova | 21:45 | |
| *** eharney has joined #openstack-nova | 21:46 | |
| *** rcernin has joined #openstack-nova | 21:46 | |
| *** jackie-truong has joined #openstack-nova | 21:47 | |
| *** sree has quit IRC | 21:48 | |
| *** eharney has quit IRC | 21:48 | |
| *** suresh12 has joined #openstack-nova | 21:51 | |
| *** bigdogstl has quit IRC | 21:53 | |
| *** slaweq has quit IRC | 21:55 | |
| *** slaweq has joined #openstack-nova | 21:56 | |
| *** threestrands has joined #openstack-nova | 21:58 | |
| *** threestrands has quit IRC | 21:58 | |
| *** threestrands has joined #openstack-nova | 21:58 | |
| *** hamzy has quit IRC | 21:58 | |
| *** threestrands has quit IRC | 21:59 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove deprecate os-hosts CLIs and python API bindings https://review.openstack.org/532989 | 21:59 |
| *** threestrands has joined #openstack-nova | 21:59 | |
| *** threestrands has quit IRC | 21:59 | |
| *** threestrands has joined #openstack-nova | 21:59 | |
| mriedem | let's fing remove everything | 21:59 |
| *** threestrands has quit IRC | 22:00 | |
| *** threestrands has joined #openstack-nova | 22:01 | |
| *** threestrands has quit IRC | 22:02 | |
| *** gyee has joined #openstack-nova | 22:02 | |
| *** threestrands has joined #openstack-nova | 22:02 | |
| ildikov | mriedem: made my day; 'fing' in Hungarian means 'fart' :) | 22:03 |
| *** Apoorva has joined #openstack-nova | 22:03 | |
| mriedem | excellent | 22:03 |
| mriedem | mtreinish: how do you say "staying alive" in czech again? | 22:03 |
| mriedem | hodina ho? | 22:04 |
| *** sree has joined #openstack-nova | 22:06 | |
| *** penick has quit IRC | 22:07 | |
| *** penick has joined #openstack-nova | 22:07 | |
| *** bjolo has quit IRC | 22:09 | |
| *** nicolasbock has quit IRC | 22:10 | |
| *** sree has quit IRC | 22:10 | |
| *** bigdogstl has joined #openstack-nova | 22:12 | |
| *** kumarmn has joined #openstack-nova | 22:13 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Raise conflict exception on RP create 409 https://review.openstack.org/532563 | 22:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.set_traits_for_provider https://review.openstack.org/532564 | 22:15 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Track associated sharing RPs in report client https://review.openstack.org/526539 | 22:15 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Raise on API errors getting aggregates/traits https://review.openstack.org/526540 | 22:15 |
| openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.populate_from_iterable https://review.openstack.org/520756 | 22:15 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Track tree-associated providers in report client https://review.openstack.org/526541 | 22:15 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Scheduler[Report]Client.get_provider_tree https://review.openstack.org/521098 | 22:15 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | 22:15 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 22:15 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | 22:15 |
| *** matrohon has quit IRC | 22:15 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: SchedulerReportClient.set_aggregates_for_provider https://review.openstack.org/532995 | 22:15 |
| *** dave-mccowan has quit IRC | 22:16 | |
| *** dave-mccowan has joined #openstack-nova | 22:16 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove deprecated fixedip/floatingip/virtual interface CLIs/APIs https://review.openstack.org/532999 | 22:21 |
| *** awaugama has quit IRC | 22:22 | |
| *** Apoorva_ has joined #openstack-nova | 22:23 | |
| *** tidwellr has quit IRC | 22:23 | |
| *** tidwellr has joined #openstack-nova | 22:23 | |
| *** NostawRm has quit IRC | 22:23 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove deprecated os-hosts CLIs and python API bindings https://review.openstack.org/532989 | 22:24 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove deprecated fixedip/floatingip/virtual interface CLIs/APIs https://review.openstack.org/532999 | 22:24 |
| *** NostawRm has joined #openstack-nova | 22:25 | |
| *** dave-mccowan has quit IRC | 22:25 | |
| mtreinish | mriedem: "Hodina H" is the title | 22:25 |
| mriedem | yeah but the song is called staying alive | 22:25 |
| *** Apoorva has quit IRC | 22:26 | |
| *** lyan_ has quit IRC | 22:26 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove deprecated fixedip/floatingip/virtual interface CLIs/APIs https://review.openstack.org/532999 | 22:26 |
| *** bigdogstl has quit IRC | 22:26 | |
| *** bigdogstl has joined #openstack-nova | 22:26 | |
| *** tidwellr has quit IRC | 22:28 | |
| *** Apoorva_ has quit IRC | 22:30 | |
| *** kumarmn has quit IRC | 22:30 | |
| *** itlinux has joined #openstack-nova | 22:30 | |
| *** mlavalle has quit IRC | 22:31 | |
| *** Apoorva has joined #openstack-nova | 22:31 | |
| *** mlavalle has joined #openstack-nova | 22:31 | |
| *** sree has joined #openstack-nova | 22:32 | |
| *** sree has quit IRC | 22:36 | |
| *** esberglu has quit IRC | 22:36 | |
| *** sree has joined #openstack-nova | 22:38 | |
| *** sree has quit IRC | 22:43 | |
| *** vladikr has quit IRC | 22:43 | |
| *** bjolo has joined #openstack-nova | 22:44 | |
| *** kenperkins has quit IRC | 22:45 | |
| *** slaweq has quit IRC | 22:46 | |
| *** markvoelker has quit IRC | 22:49 | |
| *** markvoelker has joined #openstack-nova | 22:49 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove deprecated fixedip/floatingip/virtual interface CLIs/APIs https://review.openstack.org/532999 | 22:52 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove deprecated services binary CLI arg https://review.openstack.org/533005 | 22:52 |
| mriedem | Vek is earning his salt today | 22:52 |
| *** Jeffrey4l has quit IRC | 22:53 | |
| mriedem | melwitt: i'm going to try and get https://review.openstack.org/#/q/topic:bug/1668743+status:open into novaclient and then we'll cut the major 10.0.0 release | 22:53 |
| *** markvoelker has quit IRC | 22:54 | |
| *** andreas_s has joined #openstack-nova | 22:54 | |
| mriedem | it's always nice to flush the toilet once every 6 months | 22:54 |
| *** sree has joined #openstack-nova | 22:54 | |
| *** edmondsw has quit IRC | 22:54 | |
| melwitt | lol | 22:54 |
| *** penick has quit IRC | 22:54 | |
| *** edmondsw has joined #openstack-nova | 22:55 | |
| *** felipemonteiro_ has quit IRC | 22:55 | |
| *** itlinux has quit IRC | 22:55 | |
| *** Jeffrey4l has joined #openstack-nova | 22:56 | |
| *** markvoelker has joined #openstack-nova | 22:56 | |
| *** itlinux has joined #openstack-nova | 22:57 | |
| *** penick has joined #openstack-nova | 22:57 | |
| *** sree has quit IRC | 22:58 | |
| *** jackie-truong has quit IRC | 22:58 | |
| *** edmondsw has quit IRC | 22:59 | |
| *** markvoelker has quit IRC | 22:59 | |
| *** andreas_s has quit IRC | 23:00 | |
| *** markvoelker has joined #openstack-nova | 23:00 | |
| *** penick has quit IRC | 23:01 | |
| *** markvoelker has quit IRC | 23:05 | |
| *** sree has joined #openstack-nova | 23:05 | |
| *** sree has quit IRC | 23:10 | |
| *** itlinux has quit IRC | 23:12 | |
| *** browne has joined #openstack-nova | 23:14 | |
| *** browne has quit IRC | 23:15 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: QEMU native LUKS decryption for volumes https://review.openstack.org/523958 | 23:17 |
| *** bigdogstl has quit IRC | 23:19 | |
| *** bigdogstl has joined #openstack-nova | 23:31 | |
| *** bigdogstl has quit IRC | 23:36 | |
| mriedem | edleafe: left comments on the resize patch with what i think needs to happen wrt allocations getting moved from the primary selected host to the alternate | 23:41 |
| *** smatzek has joined #openstack-nova | 23:43 | |
| *** sree has joined #openstack-nova | 23:43 | |
| *** bigdogstl has joined #openstack-nova | 23:46 | |
| *** takashin has joined #openstack-nova | 23:47 | |
| *** smatzek has quit IRC | 23:47 | |
| *** sree has quit IRC | 23:47 | |
| *** hongbin has quit IRC | 23:53 | |
| gmann | mriedem: re: https://review.openstack.org/#/c/330406/85/nova/api/openstack/compute/migrations.py | 23:53 |
| gmann | mriedem: it will stop schema validation for legacy v2 compatibility mode | 23:54 |
| gmann | mriedem: https://github.com/openstack/nova/blob/90a92d33edaea2b7411a5fd528f3159a486e1fd0/nova/api/validation/__init__.py#L74 | 23:54 |
| rybridges | Good afternoon! Might have found a bug with user_storage_quota in glance-api.conf. It looks like when we are out of quota and try to directly upload an image we get the error on the command line "Image exceeds the storage quota". However, when we attempt to make a snapshot with "openstack server image create", we do not see the error on the command line. The snapshot gets created and is in queued | 23:57 |
| rybridges | state, but then just disappears. We then see a stack trace on the hypervisor with the error in the log, but the user is never directly informed | 23:57 |
| rybridges | Is this the expected behavior? | 23:57 |
| gmann | mriedem: 1 query on this. why we did not add paging on GET /servers/{server_id}/migrations -https://review.openstack.org/#/c/532904/1 | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!