Monday, 2018-01-15

*** kumarmn has joined #openstack-nova00:03
*** kumarmn has quit IRC00:05
*** kumarmn has joined #openstack-nova00:05
*** bigdogstl has quit IRC00:06
*** superdan is now known as dansmith00:11
*** yingjun has joined #openstack-nova00:12
*** fragatina has joined #openstack-nova00:13
*** kumarmn has quit IRC00:15
*** hiro-kobayashi has joined #openstack-nova00:17
*** bigdogstl has joined #openstack-nova00:18
*** markvoelker has joined #openstack-nova00:20
*** edmondsw has joined #openstack-nova00:24
*** markvoelker has quit IRC00:24
*** yangyapeng has quit IRC00:28
*** edmondsw has quit IRC00:28
*** yangyapeng has joined #openstack-nova00:29
*** claudiub has quit IRC00:31
*** fragatina has quit IRC00:31
*** yangyapeng has quit IRC00:33
*** john51 has quit IRC00:37
*** john51 has joined #openstack-nova00:37
*** Dinesh_Bhor has joined #openstack-nova00:42
*** Dinesh_Bhor has quit IRC00:44
*** Dinesh_Bhor has joined #openstack-nova00:44
*** Dinesh_Bhor has quit IRC00:45
prometheanfirenova doesn't look like it supports the new os_vif https://review.openstack.org/53298700:49
*** TTris has joined #openstack-nova00:50
*** auggy has quit IRC00:55
*** auggy has joined #openstack-nova00:55
*** Dinesh_Bhor has joined #openstack-nova00:56
*** hoangcx has joined #openstack-nova00:59
openstackgerritTetsuro Nakamura proposed openstack/nova master: Fix allocation_candidates not to ignore shared RPs  https://review.openstack.org/53339601:01
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support relay RP for allocation candidates  https://review.openstack.org/53343701:01
*** zhaochao has joined #openstack-nova01:03
*** phuongnh has joined #openstack-nova01:07
*** jichen has joined #openstack-nova01:08
*** lyan has quit IRC01:09
*** yangyapeng has joined #openstack-nova01:13
*** eharney has quit IRC01:14
*** kumarmn has joined #openstack-nova01:15
*** hongbin has joined #openstack-nova01:17
*** tetsuro_ has joined #openstack-nova01:18
*** yangyapeng has quit IRC01:21
*** yangyapeng has joined #openstack-nova01:21
*** kumarmn has quit IRC01:21
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: [placement] Fix resource provider delete  https://review.openstack.org/52951901:25
*** Dinesh_Bhor has quit IRC01:28
*** Dinesh_Bhor has joined #openstack-nova01:30
*** Dinesh_Bhor has quit IRC01:34
openstackgerritWangpan proposed openstack/nova stable/pike: Handle glance exception during rotating instance backup  https://review.openstack.org/53343901:36
*** Dinesh_Bhor has joined #openstack-nova01:40
*** threestrands_ has joined #openstack-nova01:40
*** threestrands has quit IRC01:43
*** tiendc has joined #openstack-nova01:43
*** armax has joined #openstack-nova01:44
*** Dinesh_Bhor has quit IRC01:52
*** Dinesh_Bhor has joined #openstack-nova01:52
*** namnh has joined #openstack-nova01:56
*** yassine has joined #openstack-nova01:59
*** yassine is now known as Guest5466901:59
openstackgerritHuang Rui proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver  https://review.openstack.org/52338702:02
*** Dinesh_Bhor has quit IRC02:03
*** itlinux has joined #openstack-nova02:07
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2)  https://review.openstack.org/43060802:09
*** Dinesh_Bhor has joined #openstack-nova02:14
*** Dinesh_Bhor has quit IRC02:23
*** zhurong has joined #openstack-nova02:28
*** itlinux has quit IRC02:34
*** Dinesh_Bhor has joined #openstack-nova02:36
*** bigdogstl has quit IRC02:40
*** hshiina has joined #openstack-nova02:45
*** elmaciej has joined #openstack-nova02:46
openstackgerritHuang Rui proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver  https://review.openstack.org/52338702:47
*** itlinux has joined #openstack-nova02:48
*** kwathore has quit IRC02:48
*** dkliban has joined #openstack-nova02:50
*** sree has joined #openstack-nova02:51
*** markvoelker has joined #openstack-nova02:51
*** dkliban has left #openstack-nova02:53
*** annp has joined #openstack-nova02:54
*** tbachman has quit IRC02:54
*** elmaciej has quit IRC03:01
openstackgerritTakashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers.inc  https://review.openstack.org/52820103:03
openstackgerritTakashi NATSUME proposed openstack/nova master: api-ref: Example verification for servers.inc  https://review.openstack.org/52952003:04
*** abhishekk has joined #openstack-nova03:04
*** Dinesh_Bhor has quit IRC03:04
*** bigdogstl has joined #openstack-nova03:06
*** kumarmn has joined #openstack-nova03:10
*** jappleii__ has joined #openstack-nova03:12
*** jappleii__ has quit IRC03:13
*** jappleii__ has joined #openstack-nova03:13
*** threestrands_ has quit IRC03:15
*** bigdogstl has quit IRC03:18
*** kumarmn has quit IRC03:19
*** markvoelker has quit IRC03:25
*** bigdogstl has joined #openstack-nova03:27
*** bigdogstl has quit IRC03:32
*** namnh has quit IRC03:34
*** namnh has joined #openstack-nova03:35
*** kumarmn has joined #openstack-nova03:45
*** sdake has quit IRC03:46
*** sdake has joined #openstack-nova03:47
*** sdake has quit IRC03:47
*** sdake has joined #openstack-nova03:47
*** psachin has joined #openstack-nova03:47
*** bigdogstl has joined #openstack-nova03:55
*** edmondsw has joined #openstack-nova04:00
*** bigdogstl has quit IRC04:03
*** Dinesh_Bhor has joined #openstack-nova04:04
*** yamamoto has joined #openstack-nova04:05
*** edmondsw has quit IRC04:05
*** claudiub has joined #openstack-nova04:08
*** bigdogstl has joined #openstack-nova04:08
*** hiro-kobayashi has quit IRC04:10
*** Dinesh_Bhor has quit IRC04:13
openstackgerritChen Hanxiao proposed openstack/nova master: test: Use assertEqual() instead of assertXXXEqual()  https://review.openstack.org/53349304:16
*** itlinux has quit IRC04:17
*** bigdogstl has quit IRC04:18
*** yingjun has quit IRC04:21
*** Dinesh_Bhor has joined #openstack-nova04:36
*** zhurong has quit IRC04:39
*** kumarmn has quit IRC04:42
*** hiro-kobayashi has joined #openstack-nova04:46
-openstackstatus- NOTICE: The logs.openstack.org filesystem has been restored to full health. We are attempting to keep logs uploaded between the prior alert and this one, however if your job logs are missing please issue a recheck.04:49
*** ChanServ changes topic to "The logs.openstack.org filesystem has been restored to full health. We are attempting to keep logs uploaded between the prior alert and this one, however if your job logs are missing please issue a recheck."04:49
*** bigdogstl has joined #openstack-nova04:51
*** ChanServ changes topic to "This channel is for Nova development. For support of Nova deployments, please use #openstack. Please see: https://wiki.openstack.org/wiki/Nova/Queens_Release_Schedule"04:53
*** Dinesh_Bhor has quit IRC04:59
*** janki has joined #openstack-nova04:59
*** Dinesh_Bhor has joined #openstack-nova05:00
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2)  https://review.openstack.org/45948305:06
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2)  https://review.openstack.org/45948305:09
*** bigdogstl has quit IRC05:10
*** links has joined #openstack-nova05:11
*** suresh12 has joined #openstack-nova05:14
*** bigdogstl has joined #openstack-nova05:17
*** markvoelker has joined #openstack-nova05:22
*** pcaruana has joined #openstack-nova05:23
*** Eran_Kuris has joined #openstack-nova05:24
*** zhurong has joined #openstack-nova05:24
*** bigdogstl has quit IRC05:26
openstackgerritTakashi NATSUME proposed openstack/nova master: [placement] Add functional tests for resource class API  https://review.openstack.org/52450605:27
openstackgerritTakashi NATSUME proposed openstack/nova master: [placement] Add functional tests for resource class API  https://review.openstack.org/52450605:27
*** pcaruana has quit IRC05:32
*** ratailor has joined #openstack-nova05:32
*** gouthamr has joined #openstack-nova05:35
*** kumarmn has joined #openstack-nova05:43
*** hongbin has quit IRC05:43
*** xinliang has quit IRC05:46
openstackgerritHuang Rui proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver  https://review.openstack.org/52338705:47
*** kumarmn has quit IRC05:48
*** edmondsw has joined #openstack-nova05:48
*** sridharg has joined #openstack-nova05:51
*** edmondsw has quit IRC05:53
*** gouthamr has quit IRC05:54
*** yamamoto_ has joined #openstack-nova05:55
*** yamamoto_ has quit IRC05:55
*** markvoelker has quit IRC05:55
*** bigdogstl has joined #openstack-nova05:56
*** yamamoto has quit IRC05:59
openstackgerritRajesh Tailor proposed openstack/nova master: Host addition host-aggregate should be case-sensitive  https://review.openstack.org/49833406:00
*** bigdogstl has quit IRC06:00
*** xinliang has joined #openstack-nova06:01
*** Tom-Tom has joined #openstack-nova06:06
*** Dinesh_Bhor has quit IRC06:07
*** moshele has joined #openstack-nova06:07
*** janki is now known as janki|afk06:10
*** janki|afk has quit IRC06:10
*** janki has joined #openstack-nova06:11
*** bigdogstl has joined #openstack-nova06:12
*** janki is now known as janki|afk06:12
*** Dinesh_Bhor has joined #openstack-nova06:12
*** yamamoto has joined #openstack-nova06:16
*** bigdogstl has quit IRC06:22
*** shaohe_feng has quit IRC06:27
*** suresh12 has quit IRC06:29
*** Eran_Kuris has quit IRC06:29
*** suresh12 has joined #openstack-nova06:31
*** bigdogstl has joined #openstack-nova06:34
*** goutham has joined #openstack-nova06:37
*** felipemonteiro_ has joined #openstack-nova06:37
*** liuzz has joined #openstack-nova06:37
*** abhishekk has quit IRC06:37
*** bigdogstl has quit IRC06:39
*** shaohe_feng has joined #openstack-nova06:40
*** suresh12 has quit IRC06:40
*** hieulq has quit IRC06:41
*** kumarmn has joined #openstack-nova06:44
openstackgerritYikun Jiang (Kero) proposed openstack/python-novaclient master: Add support for the 2.57 microversion  https://review.openstack.org/52812806:45
openstackgerritYikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.58 - Instance actions list pagination  https://review.openstack.org/52860106:45
openstackgerritYikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.59 - Migrations list pagination  https://review.openstack.org/51616806:45
*** kumarmn has quit IRC06:49
*** abhishekk has joined #openstack-nova06:50
openstackgerritjichenjc proposed openstack/nova master: WIP: Add zvm CI information  https://review.openstack.org/53351206:56
*** felipemonteiro_ has quit IRC06:58
*** liuzz has quit IRC06:59
*** liuzz has joined #openstack-nova07:00
*** lajoskatona has joined #openstack-nova07:02
*** jappleii__ has quit IRC07:02
*** bigdogstl has joined #openstack-nova07:03
*** MasterofJOKers_ has joined #openstack-nova07:07
*** bigdogstl has quit IRC07:07
*** slaweq has joined #openstack-nova07:10
*** MasterofJOKers has quit IRC07:10
*** MasterofJOKers_ is now known as MasterofJOKers07:10
*** sapd_ has quit IRC07:16
*** r-daneel has quit IRC07:17
*** sapd has joined #openstack-nova07:17
*** r-daneel has joined #openstack-nova07:17
*** goutham has quit IRC07:19
*** sapd_ has joined #openstack-nova07:20
*** sapd has quit IRC07:22
*** alexchadin has joined #openstack-nova07:25
*** maciejjozefczyk_ is now known as maciejjozefczyk07:29
*** Dinesh_Bhor has quit IRC07:31
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Fix 500 in test_resize_server_negative_invalid_state  https://review.openstack.org/53111707:33
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add index(instance_uuid, updated_at) on instance_actions table  https://review.openstack.org/53042907:33
*** Dinesh_Bhor has joined #openstack-nova07:33
*** Dinesh_Bhor has quit IRC07:33
*** sapd has joined #openstack-nova07:34
openstackgerritYikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.59 - Migrations list pagination  https://review.openstack.org/51616807:35
*** edmondsw has joined #openstack-nova07:36
*** Dinesh_Bhor has joined #openstack-nova07:37
*** bigdogstl has joined #openstack-nova07:39
*** edmondsw has quit IRC07:41
*** kumarmn has joined #openstack-nova07:45
*** janki|afk is now known as janki07:46
*** bigdogstl has quit IRC07:48
*** alexchadin has quit IRC07:49
*** kumarmn has quit IRC07:49
*** Spazmotic has joined #openstack-nova07:51
*** markvoelker has joined #openstack-nova07:53
*** AlexeyAbashkin has joined #openstack-nova07:54
*** hoonetorg has quit IRC07:58
*** matrohon has joined #openstack-nova07:58
*** rcernin has quit IRC07:59
*** Eran_Kuris has joined #openstack-nova08:00
*** kholkina has joined #openstack-nova08:02
*** alexchadin has joined #openstack-nova08:05
ameedaHi08:06
ameedahow can I update image properties in regression test function ? "self.image["properties"] = {key: value}"08:06
*** hoonetorg has joined #openstack-nova08:11
*** bigdogstl has joined #openstack-nova08:17
*** zhurong has quit IRC08:18
*** ralonsoh has joined #openstack-nova08:19
*** avolkov has joined #openstack-nova08:20
*** zhurong has joined #openstack-nova08:20
*** hiro-kobayashi has quit IRC08:23
*** ragiman has joined #openstack-nova08:25
*** jichen has quit IRC08:26
*** bigdogstl has quit IRC08:26
*** markvoelker has quit IRC08:26
*** fragatina has joined #openstack-nova08:26
*** jichen has joined #openstack-nova08:26
*** Dinesh_Bhor has quit IRC08:30
*** Dinesh_Bhor has joined #openstack-nova08:32
*** sahid has joined #openstack-nova08:34
*** moshele has quit IRC08:39
*** kumarmn has joined #openstack-nova08:46
*** moshele has joined #openstack-nova08:46
*** jpena|off is now known as jpena08:49
*** kumarmn has quit IRC08:50
*** fragatina has quit IRC08:50
*** moshele has quit IRC08:52
*** bauwser is now known as bauzas08:57
bauzasmorning Novaers08:57
bauzasbusy days08:58
gibimorning bauzas08:58
*** jaianshu has joined #openstack-nova08:59
bauzas:)08:59
*** psachin has quit IRC08:59
*** moshele has joined #openstack-nova09:00
*** alexchadin has quit IRC09:04
*** alexchadin has joined #openstack-nova09:05
*** moshele has quit IRC09:05
*** ociuhandu_ has quit IRC09:10
*** lucas-afk is now known as lucasagomes09:15
*** hshiina has quit IRC09:15
openstackgerritYikun Jiang (Kero) proposed openstack/python-novaclient master: Add missing spaces in `nova list --changes-since` help  https://review.openstack.org/53357509:16
*** alexchadin has quit IRC09:17
*** jafeha__ is now known as jafeha09:17
*** tssurya has joined #openstack-nova09:17
*** Dinesh_Bhor has quit IRC09:18
ameedabauzas: how can I update image properties in regression test function ? "self.image["properties"] = {key: value}"09:18
ameedagibi: how can I update image properties in regression test function ? "self.image["properties"] = {key: value}"09:19
*** Dinesh_Bhor has joined #openstack-nova09:19
*** ttsiouts has joined #openstack-nova09:21
*** bigdogstl has joined #openstack-nova09:22
*** edmondsw has joined #openstack-nova09:25
bauzasameeda: you'd like to test some specific image properties ?09:25
bauzasis that in a unit test or a functional test ?09:25
bauzasif so, you'd mock the image09:26
ameedabauzas: this is functional test, I want to update image properties then check if the value is changes "truncates" or not.09:28
bauzasameeda: if that's for a functional test, you should just pass a specific image09:29
*** edmondsw has quit IRC09:29
openstackgerritÉdouard Thuleau proposed openstack/nova master: Update plugs Contrail methods to work with privsep  https://review.openstack.org/53321209:29
*** bigdogstl has quit IRC09:29
ameedabauzas: you can see what I do here "http://paste.openstack.org/show/644825/"09:31
ameedabauzas: I have to check if image properties of original image is same as image properties of snapshot image.09:32
ameedabauzas: so I have to update image['properties'] , but I did that like this " image['properties']={key: value}, it doesn't works09:33
Spazmoticmorning friends09:35
bauzasameeda: I'd rather generate an image that would contain the property I'd like to test, and check eventually what I give09:35
bauzass/give/get09:35
*** alexchadin has joined #openstack-nova09:36
bauzasmorning09:36
*** derekh has joined #openstack-nova09:36
*** takashin has left #openstack-nova09:37
ameedabauzas: when I tried to do client api.post_image(image) that give me API not found09:37
openstackgerritLee Yarwood proposed openstack/nova stable/pike: Handle glance exception during rotating instance backup  https://review.openstack.org/53343909:37
bauzasameeda: there is a fake Glance service that you can use for your purpose https://github.com/openstack/nova/blob/master/nova/tests/unit/image/fake.py09:37
bauzasthen, you need to stub that service in the functional test09:37
ameedabauzas: thank you for your time. do you have an example of stub ?09:38
bauzaslike https://github.com/openstack/nova/blob/master/nova/tests/functional/test_servers.py#L136909:38
ameedabauzas: thanks!09:39
bauzasthat should give you a "fake Glance" where you could create an image like you wish and pass the image ref to the Nova call you wish09:39
bauzasameeda: HTH09:40
*** larsks has quit IRC09:40
ameedabauzas: let me check , I will ask you if I have another question :$09:40
ameedaThanks09:40
*** moshele has joined #openstack-nova09:40
bauzasameeda: np and good luck09:42
*** larsks has joined #openstack-nova09:43
ratailorCan anyone review https://review.openstack.org/#/c/498334/09:46
ratailorIt goes in merge conflict every now and then..09:46
*** zhurong has quit IRC09:46
*** kumarmn has joined #openstack-nova09:46
*** sapd has quit IRC09:46
mdboothratailor: I'll look fwiw.09:49
*** kumarmn has quit IRC09:51
*** xinliang has quit IRC09:52
*** lpetrut has joined #openstack-nova09:52
*** moshele has quit IRC09:53
*** moshele has joined #openstack-nova09:54
*** slaweq has quit IRC09:54
*** slaweq has joined #openstack-nova09:55
Spazmoticwhew... that was a good meal09:55
*** gszasz has joined #openstack-nova09:56
*** Dinesh_Bhor has quit IRC09:57
SpazmoticDid Gerritt go through any major changes in the past year?  I logged in to make my first commit in a long time and old commits were gone09:57
Spazmoticwondering if i just accidentallied an ew user ㅋㅋㅋㅋ09:58
SpazmoticNot that it matters too terribly.. just curious09:58
*** sapd has joined #openstack-nova09:59
*** hieulq has joined #openstack-nova09:59
*** slaweq has quit IRC09:59
*** sahid has quit IRC10:02
*** jaosorior has joined #openstack-nova10:03
*** jichen has quit IRC10:04
*** xinliang has joined #openstack-nova10:05
*** slaweq has joined #openstack-nova10:06
*** sahid has joined #openstack-nova10:07
mdboothSpazmotic: Don't think so. Were they just abandoned for you?10:08
SpazmoticPossible.. was also a whole different release so maybe just something there.10:08
*** bigdogstl has joined #openstack-nova10:08
Spazmotici'll pull up the commit some time later to see just how dumb I am.. too lazy and full now :D10:10
SpazmoticCheat day.. so many carbs.. so many10:10
*** namnh has quit IRC10:11
*** matrohon has quit IRC10:12
*** matrohon has joined #openstack-nova10:12
*** mvk has joined #openstack-nova10:13
*** bigdogstl has quit IRC10:19
*** elmaciej has joined #openstack-nova10:22
*** markvoelker has joined #openstack-nova10:24
*** psachin has joined #openstack-nova10:24
*** sambetts|afk is now known as sambetts10:26
*** rabel_b1 has joined #openstack-nova10:26
*** rabel_b1 has quit IRC10:32
*** alexchadin has quit IRC10:36
ameedabauzas: Thank you very much, its work !!10:36
*** alexchadin has joined #openstack-nova10:36
ameedaRegarding this gerrit https://review.openstack.org/#/c/52838510:36
bauzascool10:36
ameedaI have another issue10:37
ameedaI was added the detach_volume function outside of _cleanup_volumes to avoid regression,10:37
ameedasince this function used in many places.10:37
ameedaas you see, two code-reviewers asked me why I added that outside.10:37
ameedahttps://review.openstack.org/#/c/528385/4/nova/compute/manager.py10:37
ameeda So I move my code to be inside of _cleanup_volumes as here10:37
ameedahttps://review.openstack.org/#/c/528385/5/nova/compute/manager.py10:37
ameedabut I faced many issues with py27 and I solve them all.    now, I faced many issues with functional test,10:37
ameeda what if I return my code to be outside of _cleanup_volumes?10:37
*** sree has quit IRC10:39
*** sree has joined #openstack-nova10:39
kashyapPSA: If you're hitting: "devstackf27 httpd[5096]: AH00534: httpd: Configuration error: More than one MPM loaded." with DevStack, there's apparently a fix merged for Apache this morning10:42
kashyaphttps://bugs.launchpad.net/devstack/+bug/174019410:42
openstackLaunchpad bug 1740194 in devstack "Apache2 unable to start as 2 MPM modules enabled on Fedora 27" [Undecided,Fix released] - Assigned to Attila Fazekas (afazekas)10:42
*** sapd has quit IRC10:45
*** sree has quit IRC10:46
*** kumarmn has joined #openstack-nova10:47
*** cdent has joined #openstack-nova10:47
*** dtantsur is now known as dtantsur|bbl10:48
*** phuongnh has quit IRC10:51
*** annp has quit IRC10:51
*** abhishekk has quit IRC10:51
elmaciejHi!10:51
*** kumarmn has quit IRC10:53
*** alexchadin has quit IRC10:54
*** alexchadin has joined #openstack-nova10:55
ameedabauzas: can you help me with that ?10:56
*** markvoelker has quit IRC10:57
*** alexchadin has quit IRC11:00
*** bigdogstl has joined #openstack-nova11:03
*** bigdogstl has quit IRC11:07
*** alexchadin has joined #openstack-nova11:09
*** cdent has quit IRC11:10
*** yamamoto has quit IRC11:11
*** cdent has joined #openstack-nova11:11
*** yamamoto has joined #openstack-nova11:11
*** bigdogstl has joined #openstack-nova11:12
*** edmondsw has joined #openstack-nova11:13
*** tbachman has joined #openstack-nova11:13
*** cdent has quit IRC11:16
*** cdent has joined #openstack-nova11:17
*** edmondsw has quit IRC11:17
*** bigdogstl has quit IRC11:17
*** alexchadin has quit IRC11:22
*** alexchadin has joined #openstack-nova11:23
*** matrohon has quit IRC11:26
*** yamamoto_ has joined #openstack-nova11:26
*** gszasz has quit IRC11:27
*** yamamoto has quit IRC11:29
*** bigdogstl has joined #openstack-nova11:33
lyarwoodhttps://review.openstack.org/#/c/531407/ - Any stable cores able to +2/+W this? I'd rather not fast approve something with my name all over it :)11:34
SpazmoticIt's not so muc hthat it's a problem that it's there, ameeda, but you're making that particular function set have an incorrect purpose by placing it inside. of the build process.11:36
SpazmoticWhen there is already a cleanup process11:36
SpazmoticEspecially since it already calls cleanup, would be a ..cleaner system to let cleanup do the...cleanup..  sorry it's late hehe11:37
SpazmoticIf you can provide a good reason to have it out of there i'm sure people will understand, but unfortuantely to appease the unit test heavens is going to be a tough sell11:40
*** tiendc has quit IRC11:41
*** bigdogstl has quit IRC11:41
*** sdague has joined #openstack-nova11:41
*** matrohon has joined #openstack-nova11:42
*** bigdogstl has joined #openstack-nova11:42
*** nicolasbock has joined #openstack-nova11:44
*** pcaruana has joined #openstack-nova11:44
*** sree has joined #openstack-nova11:46
*** bigdogstl has quit IRC11:46
*** kumarmn has joined #openstack-nova11:48
*** sree has quit IRC11:50
*** kumarmn has quit IRC11:53
*** alexchadin has quit IRC11:55
ameedaSpazmotic: I still beginner with Openstack, I am not sure by what I said "to avoid regression, since the _cleanup_volumes used in another places", So you guess that I have to keep the code as its now , I mean inside cleanup and fix tests failures ?11:56
*** liuzz has quit IRC11:57
*** liuzz has joined #openstack-nova11:57
*** alexchadin has joined #openstack-nova11:57
kashyapDoes anyone have a link to DevStack Ceph job, please?12:00
kashyapOkay, that's it: "gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial"12:01
SpazmoticI'm sorry, these patch sets are so different from each other i'm struggling to keep up here.. give me a few to read it12:02
*** liuzz has quit IRC12:03
ameedaI'm sorry for that12:03
SpazmoticOk I've got it.12:03
ameedagreat12:06
ameedaso what do you think ?12:06
Spazmoticreading the code12:06
ameedasorry, take your time12:06
*** bigdogstl has joined #openstack-nova12:06
Spazmoticinteresting bug... wouldn't midn testing it myself, but reading12:06
*** tetsuro_ has quit IRC12:07
ameedasure :)12:07
SpazmoticI think I agree there's no reason to throw if instance in there btw since you have already checked for this in the try/except it should be guarunteed to be there12:08
ameedaok, I agree with you too12:08
SpazmoticI would also recommend leaving it here in cleanup and not try to move it back out.. this is definately hwere it belongs12:09
ameedaso I have to complete my work to fix all failures of tests12:09
Spazmotici glanced through the console log of zuul.. some nasty exceptiosn in there you're going to have to paly with. my guess is since this ia pretty big change to the cleanup method you may need to adjust the test a bit.. but remember not to Mock your way to victory.. .make sure it makes sense for your new conditions :)12:09
Spazmoticback in aw hile12:09
*** psachin has quit IRC12:10
ameedatake your time12:10
*** bigdogstl has quit IRC12:11
*** lucasagomes is now known as lucas-hungry12:13
mdboothratailor: Hey, just commented on your patch. Did you respond to bauzas comments oob at any point? I was going to make the same point, but saw he'd already done it.12:13
*** tesseract has joined #openstack-nova12:15
*** mvk has quit IRC12:16
*** sree has joined #openstack-nova12:18
*** sree_ has joined #openstack-nova12:22
*** sree_ is now known as Guest1824912:23
*** sree has quit IRC12:25
gmannalex_xu: can you check this - https://review.openstack.org/#/c/522918/12:29
* efried waves12:30
*** bigdogstl has joined #openstack-nova12:33
cdentefried: aren't you supposed to be on holiday?12:36
efriedcdent gibi Thanks for the rechecks.  Zuul had a really bad week last week; let's hope this one is better.12:36
efriedcdent No?12:36
efriedI believe mriedem is on holiday this week.12:36
cdentIt's mlk day. I guess that's not an enforced US holiday. I think my us employer-colleagues are taking it off. I can never remember.12:37
efriedohhh, right.12:37
cdentzuul probably wants sacrifices12:37
efriedI don't think this is one of those, but let me check...12:37
efriednope, doesn't look like it.  I've got pto scheduled for tomorrow, though.12:37
efriedMy kids are off.  But not me.12:37
*** jpena is now known as jpena|lunch12:38
kashyapmdbooth: Hey, when you get a sec, is there a way I can see a Gate job result for an instance boot with an ephemeral disk?12:39
*** andreas_s has joined #openstack-nova12:39
*** bigdogstl has quit IRC12:40
*** bigdogstl has joined #openstack-nova12:41
mdboothkashyap: Almost certainly, but I wouldn't know off the top of my head which tempest tests cover ephemerals.12:41
*** takashin has joined #openstack-nova12:41
kashyapmdbooth: No problem, I'll plough through them.12:42
*** r-daneel_ has joined #openstack-nova12:42
*** r-daneel has quit IRC12:43
*** r-daneel_ is now known as r-daneel12:43
SpazmoticMy commit handles ephs, one sec12:45
*** bigdogstl has quit IRC12:46
SpazmoticAh you wanted gate, not initial check didn't you12:46
kashyapSpazmotic: I want to see the libvirt XML on any of the Gate jobs with an instance boot with ephemeral disk12:48
kashyapOkido, my local DevStack run just finished after 24 minutes (real    24m49.794s), so I'll try locally12:48
*** smatzek has joined #openstack-nova12:49
SpazmoticAhhh I see, I cannot help so much with that, hehe.  Sorry i'll go back into the shadows12:49
*** kumarmn has joined #openstack-nova12:49
kashyapHeh, np.12:49
*** bigdogstl has joined #openstack-nova12:50
*** andreaf has quit IRC12:53
*** andreaf has joined #openstack-nova12:53
*** kumarmn has quit IRC12:54
*** markvoelker has joined #openstack-nova12:54
*** edmondsw has joined #openstack-nova12:55
*** ragiman has quit IRC12:57
*** dtantsur|bbl is now known as dtantsur13:01
*** bigdogstl has quit IRC13:01
*** vladikr has joined #openstack-nova13:02
*** dikonoor has joined #openstack-nova13:03
openstackgerritBalazs Gibizer proposed openstack/nova master: Make sure that functional test triggered on sample changes  https://review.openstack.org/53321013:03
openstackgerritBalazs Gibizer proposed openstack/nova master: DNM: Testing if funct test is triggered  https://review.openstack.org/53321113:04
*** tetsuro has joined #openstack-nova13:04
*** sahid has quit IRC13:05
*** jaypipes has joined #openstack-nova13:08
elmaciejHi! Maybe someone can point me how to start contributing to openstack. I made some fix to allow live migration on lvm based shared storage and don't know if it's worthly to put it official or not. Where should I get started.13:10
zioprotosdague: ping, is it business hours in your timezone now ? :)13:10
zioprotoelmaciej: you need to "git review" your patch. More info here https://docs.openstack.org/infra/manual/developers.html13:11
elmaciejzioproto - so I can create my own branch, push to it and call the review? just like that?13:11
zioprotoelmaciej: you need to "Sign the appropriate Individual Contributor License Agreement"13:11
zioprotoelmaciej: it is exaplained in that page13:12
zioprotothen you can push13:12
zioprotoand somebody will review your patch13:12
zioprotoyou dont need to create a branch13:12
zioprotoall the work should be in 1 single commit13:12
zioprotothen on your shell13:12
zioprotojust type13:12
zioprotogit review13:12
zioprotothis will automatically create a branch13:12
elmaciejok,got this,  thanks, will take a look at evening then.13:13
*** mvk has joined #openstack-nova13:13
*** lucas-hungry is now known as lucasagomes13:13
zioprotoelmaciej: thanks for contributing to openstack13:13
*** bigdogstl has joined #openstack-nova13:13
SpazmoticReally no need to create a local branch? have always done it :D13:13
elmaciejit's a pleasure :) I needed live migration on lvm :) buisness requirment13:13
*** ratailor has quit IRC13:13
*** danpawlik_ has quit IRC13:17
*** bigdogstl has quit IRC13:17
*** openstackgerrit has quit IRC13:18
*** sahid has joined #openstack-nova13:19
*** alexchadin has quit IRC13:19
*** r-daneel has quit IRC13:21
cdentbauzas, gibi: 500 fix, already one +2, about 6 months old, would be nice to have: https://review.openstack.org/#/c/389798/13:23
*** lajoskatona has quit IRC13:25
*** yangyapeng has quit IRC13:26
*** yangyapeng has joined #openstack-nova13:27
*** bigdogstl has joined #openstack-nova13:27
*** tetsuro has quit IRC13:27
*** jdillaman has joined #openstack-nova13:27
*** markvoelker has quit IRC13:28
jaypipescdent: done.13:28
cdentdanke jaypipes wasn't sure if you were a) still alive, b) here today, c) here yet13:29
cdentfeeling better?13:29
*** jpena|lunch is now known as jpena13:29
jaypipescdent: much, thank you. I'm back around 75% I think.13:29
cdentflu sucks13:30
cdent(I think it was diana on much of that thing, I just did a rebase towards the end)13:30
*** janki has quit IRC13:31
*** jaianshu has quit IRC13:31
*** janki has joined #openstack-nova13:32
*** yangyapeng has quit IRC13:32
gibijaypipes: welcome back!13:32
*** bigdogstl has quit IRC13:32
*** Eran_Kuris has quit IRC13:32
jaypipesgibi: thanks mate :)13:32
jaypipesfeels good to be able to work again.13:32
lyarwoodbauzas: so https://review.openstack.org/#/c/531407/ wasn't really my change FWIW, mdbooth and melwitt rewrote most of it in master so we should be good to +W this now.13:33
*** krtaylor has quit IRC13:33
*** lennyb_ has joined #openstack-nova13:33
*** lennyb_ has quit IRC13:34
efriedjaypipes Howdy sir, welcome back to the land of the living.13:35
*** Guest18249 has quit IRC13:35
*** sree has joined #openstack-nova13:36
*** matrohon has quit IRC13:36
*** matrohon has joined #openstack-nova13:36
jaypipesefried: thanks :)13:37
*** danpawlik has joined #openstack-nova13:37
*** r-daneel has joined #openstack-nova13:38
*** esberglu has joined #openstack-nova13:40
*** Guest54669 has quit IRC13:40
mdboothlyarwood: IIUC we're expecting failures in https://review.openstack.org/#/c/523958/ because we're assuming c-vol has done its thing, which it hasn't, right?13:41
mdboothlyarwood: i.e. A lack of tempest failures would indicate a lack of test coverage?13:42
mdboothAnd we need a couple of Depends-On: for c-vol patches which don't exist, yet?13:42
* mdbooth would like to make it clear that he considers ^^^ to be a very good thing13:43
*** Guest54669 has joined #openstack-nova13:43
lyarwoodmdbooth: yes and yes, there's some additional coverage in the barbican plugin but there's also alot missing from standard tempest13:43
*** openstackgerrit has joined #openstack-nova13:43
openstackgerritSylvain Bauza proposed openstack/nova master: libvirt: create vGPU for instance  https://review.openstack.org/52883213:43
openstackgerritSylvain Bauza proposed openstack/nova master: Recreate mediated devices on reboot  https://review.openstack.org/53364213:43
bauzasAFAIK, mriedem is not around today, right?13:43
mdboothlyarwood: Ok, thanks.13:43
*** sree has quit IRC13:44
*** bigdogstl has joined #openstack-nova13:44
*** Eran_Kuris has joined #openstack-nova13:47
*** esberglu has quit IRC13:48
*** sree has joined #openstack-nova13:48
*** Guest54669 has quit IRC13:48
openstackgerritSylvain Bauza proposed openstack/nova master: Recreate mediated devices on reboot  https://review.openstack.org/53364213:48
*** tbachman has quit IRC13:49
*** bigdogstl has quit IRC13:49
*** yassine has joined #openstack-nova13:49
cdentedleafe, efried: can I assume we are having the usual scheduler meeting?13:49
*** yassine is now known as Guest5521913:49
jaypipescdent: yes, but edleafe is commuting.13:50
*** kumarmn has joined #openstack-nova13:50
jaypipescdent: unless he's off for MLK day?13:50
jaypipesnot sure..13:50
*** finucannot is now known as stephenfin13:50
efriedIBM doesn't have MLK as a site holiday.  But edleafe asked me to run it, so either he's off anyway, or he's commuting.13:51
*** kumarmn has quit IRC13:54
efriedcdent You didn't find the first paragraph of the commit message adequately explanatory?  https://review.openstack.org/#/c/533244/13:56
cdentefried: imagine you didn't know what a _Provider is?13:56
cdentThat's what I mean by "in isolation"13:56
*** sree has quit IRC13:57
*** zhaochao has quit IRC13:57
efriedokay.13:57
*** krtaylor has joined #openstack-nova13:57
cdentefried: I know it is tedious, and I know I dont do that to everyone, but a) I should, b) I feel like you'll take it in good intent intended13:58
cdent(also I didn't -1 it, just commented)13:58
efriedcdent I'm planning to slot this change into the existing series, so that would give it some context.  But I'll add some words.13:59
*** yangyapeng has joined #openstack-nova13:59
efriedScheduler meeting NOW in #openstack-meeting-alt13:59
Spazmoticjohnthetubaguy I was going to hit you up about a commit the other day but realized I no longer work with you.. too sad.13:59
cdentefried: imagine yourself in the shoes of a drunk, stupid, tired, angry git bisector14:00
SpazmoticI made a commit with some code against the resize_up xenapi stuff if you want to take a look, you're probably one of the best to review it and offer me some suggestions if you find the chance :)  https://review.openstack.org/#/c/533168/14:00
Spazmoticback after a while, stupid.. house.. not self cleaning..14:00
*** gszasz has joined #openstack-nova14:03
*** liverpooler has joined #openstack-nova14:04
openstackgerritAmeed Ashour proposed openstack/nova master: change instance_system_metadata column type  https://review.openstack.org/52690014:05
*** lyan has joined #openstack-nova14:05
*** bigdogstl has joined #openstack-nova14:05
*** eharney has joined #openstack-nova14:06
ameedaalex_xu: are you around ?14:06
*** sahid has quit IRC14:06
*** Eran_Kuris has quit IRC14:07
*** esberglu has joined #openstack-nova14:07
openstackgerritMerged openstack/nova master: console: introduce the VeNCrypt RFB authentication scheme  https://review.openstack.org/34539814:10
ameedagmann: Ameed Ashour proposed openstack/nova master: change instance_system_metadata column type  https://review.openstack.org/52690014:10
ameedagmann: can you please review the code ?14:10
*** andreas_s has quit IRC14:15
openstackgerritMerged openstack/nova master: console: Provide an RFB security proxy implementation  https://review.openstack.org/34539914:15
openstackgerritBalazs Gibizer proposed openstack/nova master: Deduplicate aggregate notification samples  https://review.openstack.org/53116214:15
*** bigdogstl has quit IRC14:15
stephenfin#success After 3 years and 7 (?) releases, encryption between nova's consoleproxy service and compute nodes is finally possible ✌️14:16
openstackstatusstephenfin: Added success to Success page14:16
cdentstephenfin:14:17
cdent++14:17
*** Eran_Kuris has joined #openstack-nova14:18
ameedastephenfin: Congratulations14:19
*** andreas_s has joined #openstack-nova14:19
*** r-daneel has quit IRC14:23
*** andreas_s has quit IRC14:25
*** andreas_s has joined #openstack-nova14:25
*** sahid has joined #openstack-nova14:25
*** andreas__ has joined #openstack-nova14:26
*** cdent has quit IRC14:28
jaypipesit's breakfast time.14:28
*** kumarmn has joined #openstack-nova14:30
*** andreas_s has quit IRC14:30
*** kumarmn_ has joined #openstack-nova14:30
gibistephenfin: nice!14:31
ildikovstephenfin: yaaay! nice job! congrats! :)14:33
stephenfinjaypipes: I'll have you know it's basically supper time, actually ;)14:34
stephenfinjohnthetubaguy: You're hardly about, are you?14:34
*** kumarmn has quit IRC14:34
*** tssurya has quit IRC14:35
* stephenfin wants openstack-doc-core added to the os-api-ref-core Gerrit group14:35
*** ratailor has joined #openstack-nova14:38
openstackgerritEric Fried proposed openstack/nova master: Change compute RPC to use alternates for resize  https://review.openstack.org/52643614:40
openstackgerritTakashi NATSUME proposed openstack/nova master: Transform instance.resize_prep notification  https://review.openstack.org/46508114:40
*** matrohon has quit IRC14:41
*** matrohon has joined #openstack-nova14:41
*** gcb has joined #openstack-nova14:44
openstackgerritJackie Truong proposed openstack/python-novaclient master: Microversion 2.59 - Add trusted_image_certificates  https://review.openstack.org/50039614:44
openstackgerritAmeed Ashour proposed openstack/nova master: change instance_system_metadata column type  https://review.openstack.org/52690014:48
*** tssurya has joined #openstack-nova14:50
*** eharney has quit IRC14:52
*** elmaciej has quit IRC14:52
*** dulek has joined #openstack-nova14:52
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove unnecessary execute permissions in files  https://review.openstack.org/53368614:54
*** awaugama has joined #openstack-nova14:54
*** tbh_ has joined #openstack-nova14:55
*** mgariepy has quit IRC14:55
*** matrohon has quit IRC14:58
*** yamahata has joined #openstack-nova14:59
*** elmaciej has joined #openstack-nova15:01
*** ratailor has quit IRC15:03
*** takashin has left #openstack-nova15:04
*** mgariepy has joined #openstack-nova15:05
*** eharney has joined #openstack-nova15:05
*** cdent has joined #openstack-nova15:05
*** yamamoto_ has quit IRC15:06
bauzasdansmith: mdbooth: FYI, just posted a new revision for the VGPU series starting with https://review.openstack.org/#/c/528832/8 that now lookups existing instances when restarting nova-compute15:10
bauzasdansmith: mdbooth: that said, I still need to work around the XML removal when rebooting/restarting/etc.15:10
bauzaswondering if that could be a follow-up patch15:11
dansmithbauzas: yeah I think we just can't merge the first one until that follow-up is ready behind it15:11
bauzask15:12
mdboothbauzas: What dansmith said.15:12
*** tssurya has quit IRC15:15
*** armax has quit IRC15:17
*** r-daneel has joined #openstack-nova15:17
openstackgerritCarlos Goncalves proposed openstack/os-vif master: Git ignore .stestr  https://review.openstack.org/53369915:19
*** links has quit IRC15:20
*** kumarmn_ has left #openstack-nova15:23
*** bigdogstl has joined #openstack-nova15:24
*** moshele has quit IRC15:25
*** markvoelker has joined #openstack-nova15:25
*** tssurya has joined #openstack-nova15:28
*** gszasz has quit IRC15:28
*** matrohon has joined #openstack-nova15:28
*** hongbin has joined #openstack-nova15:29
*** archit has joined #openstack-nova15:33
*** r-daneel has quit IRC15:34
*** elmaciej has quit IRC15:34
*** r-daneel has joined #openstack-nova15:35
*** slaweq has quit IRC15:40
*** mlavalle has joined #openstack-nova15:40
*** slaweq has joined #openstack-nova15:40
*** bigdogstl has quit IRC15:41
*** andreas__ has quit IRC15:42
*** andreas_s has joined #openstack-nova15:43
*** tidwellr has joined #openstack-nova15:43
*** slaweq has quit IRC15:44
*** andreas_s has quit IRC15:46
*** andreas_s has joined #openstack-nova15:46
*** armax has joined #openstack-nova15:47
lyarwoodstephenfin: https://review.openstack.org/#/c/527046/ - any chance of a +W? Had to rebase over the weekend.15:49
*** elmaciej has joined #openstack-nova15:49
*** felipemonteiro has joined #openstack-nova15:50
dansmithbauzas: that recreate on boot patch is nice.. and pretty simple.. too simple not to do :)15:50
bauzasdansmith: I'll need to fully rewrite the bottom change15:51
stephenfinlyarwood: Sure, done15:51
dansmithbauzas: because why?15:51
bauzasdansmith: given I'm changing all the interfaces by not passing the allocations to _get_guest_xml() but rather asks to allocate a mdev for spawn() and passing it to _get_guest_xml()15:52
dansmithbauzas: ah okay15:52
lyarwoodstephenfin: thanks15:52
openstackgerritCarlos Goncalves proposed openstack/os-vif master: WIP: vif_plug_ovs: add should_provide_port  https://review.openstack.org/53371315:52
bauzasdansmith: so for hard_reboot(), I'll instead ask for the current mdev for passing it to _get_guest_xml()15:52
dansmithbauzas: aye15:53
*** gcb has quit IRC15:54
*** felipemonteiro_ has joined #openstack-nova15:54
*** kholkina has quit IRC15:58
edleafeefried: thanks for that huge fix on https://review.openstack.org/#/c/526436/  :)15:58
*** tssurya has left #openstack-nova15:58
*** felipemonteiro has quit IRC15:58
efriedIt was an enormous sacrifice of time and mental anguish, but you're worth it edleafe15:58
*** tssurya has joined #openstack-nova15:58
edleafeYour suffering has not gone unnoticed15:58
efriededleafe Caught up on sched meeting yet?15:59
*** markvoelker has quit IRC15:59
edleafeno, just poured me a cup of coffee and was getting ready to read back15:59
efriedight.  There was some question of how you felt about ProviderTree.snapshot (formerly known as ReadOnlyProvider)16:00
bauzasjaypipes: I think we already discussed about that previously, but someone pinged me about reviewing https://review.openstack.org/#/c/526900/19/nova/db/sqlalchemy/models.py16:01
bauzasjaypipes: would it be a performance issue ?16:01
jaypipesbauzas: no16:01
*** chyka has joined #openstack-nova16:01
jaypipesbauzas: shouldn't be a performance issue at all.16:02
bauzasok, I remembered your point, but I wasn't sure it was for VARCHAR(255) > TEXT16:02
*** chyka has quit IRC16:02
bauzasok, will review it when I have time then16:02
*** chyka has joined #openstack-nova16:02
jaypipesbauzas: that said, doesn't the REST API limit the length of the metadata value?16:03
jaypipesbauzas: in which case a microversion is gonna be necessary16:03
bauzasjaypipes: yup, possibly16:03
bauzastbh, I haven't reviewed it16:04
bauzasjust looking at the main modification16:04
bauzasjaypipes: for your point, that'll depend if we cut the string by the API or not16:04
bauzasbut yeah, if it's all about having the API giving more than 255 chars for that, then yes, it's a microversion needed16:05
*** jackie-truong has joined #openstack-nova16:06
*** yamamoto has joined #openstack-nova16:07
* efried hands gibi a cookie16:09
efriednamedtuple.  Fabulous.16:09
*** hoonetorg has quit IRC16:09
*** slaweq has joined #openstack-nova16:11
*** itlinux has joined #openstack-nova16:12
prometheanfirenova doesn't look like it supports the new os_vif https://review.openstack.org/53298716:12
prometheanfirewill bug the list if you want16:12
edleafeefried: not that fabulous16:12
efriededleafe You don't like?16:12
edleafeefried: see the comment I just posted16:12
*** yamamoto has quit IRC16:14
efriededleafe You set an attribute on the class, not an instance thereof.16:14
edleafeugh, was just thinking that through more. Coffee hasn't fully kicked in yet16:15
openstackgerritMerged openstack/nova master: Do not attempt volume swap when guest is stopped/suspended  https://review.openstack.org/38979816:15
openstackgerritMerged openstack/nova master: Add aggregates check in allocation candidates  https://review.openstack.org/52240716:15
*** slaweq has quit IRC16:16
* gibi takes the cookie and goes home with it16:17
*** bigdogstl has joined #openstack-nova16:18
stephenfinprometheanfire: Oh, looking16:20
stephenfinsean-k-mooney, ralonsoh: Seen https://review.openstack.org/#/c/532987/ ?16:20
sean-k-mooneystephenfin: looking now16:21
prometheanfirestephenfin: cool16:21
prometheanfirehopefully it's just a overly specific test16:21
ralonsohstephenfin: I'm taking a look now16:21
sean-k-mooneystephenfin: at first glance these see unrelated to os-vif16:22
stephenfinsean-k-mooney: Quite possibly. I haven't looked into it in detail16:23
stephenfinJust saw the multiple rechecks. Usually a sign of something more sinister16:23
sean-k-mooneystephenfin: the network basic opts test were failing due to a an ip confict16:23
*** bigdogstl has quit IRC16:23
openstackgerritJackie Truong proposed openstack/nova master: Add trusted_certs object  https://review.openstack.org/48940816:24
sean-k-mooneystephenfin: yes however that fact that tempest.scenario.test_network_basic_ops.TestNetworkBasicOps passes on multinode (one of the failing test) means its likely not a os-vif issue16:25
*** bigdogstl has joined #openstack-nova16:25
sean-k-mooneystephenfin: ill dig a little deeper16:25
*** dave-mccowan has joined #openstack-nova16:27
sean-k-mooneystephenfin: there are a whole bunch of  Too many open files errors in n-cpu logs16:27
*** sridharg has quit IRC16:27
sean-k-mooneye.g. http://logs.openstack.org/87/532987/1/check/legacy-tempest-dsvm-neutron-full/cb9c0bb/logs/screen-n-cpu.txt.gz?level=ERROR#_Jan_12_14_00_56_22232816:27
openstackgerritEric Fried proposed openstack/nova master: SchedulerReportClient.set_traits_for_provider  https://review.openstack.org/53256416:29
openstackgerritEric Fried proposed openstack/nova master: Track associated sharing RPs in report client  https://review.openstack.org/52653916:29
openstackgerritEric Fried proposed openstack/nova master: Raise on API errors getting aggregates/traits  https://review.openstack.org/52654016:29
openstackgerritEric Fried proposed openstack/nova master: ProviderTree.populate_from_iterable  https://review.openstack.org/52075616:29
openstackgerritEric Fried proposed openstack/nova master: Track tree-associated providers in report client  https://review.openstack.org/52654116:29
openstackgerritEric Fried proposed openstack/nova master: WIP: Scheduler[Report]Client.get_provider_tree  https://review.openstack.org/52109816:29
openstackgerritEric Fried proposed openstack/nova master: WIP: ComputeDriver.update_provider_tree()  https://review.openstack.org/52118716:29
openstackgerritEric Fried proposed openstack/nova master: ProviderTree.snapshot => ProviderSnapshot  https://review.openstack.org/53324416:29
openstackgerritEric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker  https://review.openstack.org/52024616:29
efriedjaypipes cdent edleafe ^  -- and FYI, the bottom patch is also needed by mgoddard to get ironic traits moving.16:29
jaypipesefried: sure, just finishing up a rebase16:29
*** dave-mcc_ has joined #openstack-nova16:30
efriedgibi also ^ -- thanks for the comments on the ProviderTree.snapshot patch.  I've now slotted it into the series where it's gonna wind up.16:30
edleafeefried: ack16:30
cdentnoted16:31
*** suresh12 has joined #openstack-nova16:31
*** dave-mccowan has quit IRC16:32
*** READ10 has joined #openstack-nova16:32
*** andreas_s has quit IRC16:33
*** andreas_s has joined #openstack-nova16:33
*** itlinux has quit IRC16:34
*** AlexeyAbashkin has quit IRC16:39
*** AlexeyAbashkin has joined #openstack-nova16:39
*** tesseract has quit IRC16:40
artomPci knowledgable folks, if I have a PciDevice (a <hostdev> in the libvirt xml), what would be the best way to find its MAC?16:42
*** gouthamr has joined #openstack-nova16:42
artomsahid, stephenfin ^^ ?16:42
*** andreas_s has quit IRC16:42
sean-k-mooneystephenfin: ill stack with the latest release of os-vif and see if i can replicate the ci failure on my end16:43
*** gyee has joined #openstack-nova16:43
sahidartom: not sure i understand, we do set the mac address when configuring the libvirt <interface>, no?16:44
*** jpena is now known as jpena|brb16:44
artomsahid, I mean when passing through an entire PF16:44
artomIt's a <hostdev> in the XML, not an <interface>16:44
artomSo there's no MAC16:44
sahidoh i see16:44
stephenfinsean-k-mooney: Sounds good. I'll take a look myself tomorrow16:45
stephenfinSee if we can figure out what's going on16:45
sahidartom: no idea sorry16:45
artomsahid, no worries :)16:45
artomWho's the most knowledgeable PCI person we have now that vladikr and nikola aren't with us anymore?16:46
*** itlinux has joined #openstack-nova16:46
*** bigdogstl has quit IRC16:46
*** sree has joined #openstack-nova16:46
sean-k-mooneystephenfin: it could be litally that we are not hitting the openfile limit but it could be something else too. if its ulimit then it something we need to fix in devstack16:47
*** markvoelker has joined #openstack-nova16:47
*** AlexeyAbashkin has quit IRC16:47
*** nicolasbock has quit IRC16:48
sahidartom: in such situation it's the guest os which have the device, the host can't really see it16:48
sahidi mean i guess it can't16:48
sean-k-mooneystephenfin: fyi this local.conf should allow you to reproduce http://paste.openstack.org/show/645256/16:49
sahidso probably your change is qemu-guest-agent16:49
stephenfinsean-k-mooney: Funny how it would trigger now. Surely we were using privsep before?16:49
sahids/have the device/own the device16:49
*** gouthamr has quit IRC16:50
sean-k-mooneystephenfin: we were but maybe with the change to useing the python libs we are a using more filedicriptors or b we are leaking them?16:50
*** nicolasbock has joined #openstack-nova16:50
stephenfinWe could validate that by turning on warnings. Python 3 warns for open fds16:50
*** sree has quit IRC16:51
*** liverpooler has quit IRC16:53
openstackgerritLee Yarwood proposed openstack/nova stable/pike: Do not attempt volume swap when guest is stopped/suspended  https://review.openstack.org/53373316:54
*** itlinux has quit IRC16:55
sean-k-mooneystephenfin: it could possibly be a provider difference? the test that were failing on rackspace were passing on inap when run as part of the grenade multinode job. anyway ill see if i can reproduce locally16:55
*** itlinux has joined #openstack-nova16:57
*** gouthamr has joined #openstack-nova16:57
sean-k-mooneystephenfin: apparently https://review.openstack.org/508498 broke Kuryr-Kubernetes so we might need to do a 1.8.1/1.9.0 release to fix them though im not conviced the fix should not be on there end yet16:58
stephenfinsean-k-mooney: Oh, someone else is using os-vif. Interesting...16:59
sean-k-mooneyya i was aware kuryr was using it but i did not think they were ever saving os-vif objects16:59
*** itlinux has quit IRC17:03
*** tbh_ has quit IRC17:05
*** bigdogstl has joined #openstack-nova17:06
*** dave-mcc_ has quit IRC17:08
*** andreas_s has joined #openstack-nova17:09
*** felipemonteiro_ has quit IRC17:10
*** itlinux has joined #openstack-nova17:11
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: QEMU native LUKS decryption for volumes  https://review.openstack.org/52395817:12
*** bigdogstl has quit IRC17:12
*** hoonetorg has joined #openstack-nova17:14
*** suresh12 has quit IRC17:16
*** janki has quit IRC17:17
*** andreas_s has quit IRC17:19
*** efried is now known as efried_rollin17:19
*** links has joined #openstack-nova17:21
jaypipessean-k-mooney: I'm currently replying to mdulko about that...17:23
jaypipessean-k-mooney: bottom line, even if we did do obj_make_compatible(), that wouldn't have magically caused the client side to not break.17:23
*** matrohon has quit IRC17:24
jaypipessean-k-mooney: they still will need to advertise what versions of the objects they need (Nova does it via the nova-specific oslo versionedobject registry, etc)17:24
jaypipessean-k-mooney: there's no free lunch here...17:24
sean-k-mooneyjaypipes: right v2 of the patch had the make compatible code but you would have to do the down grade and i think the compat code just created an empty list of ip17:24
jaypipesright.17:25
openstackgerritEric Berglund proposed openstack/nova master: PowerVM driver: ovs vif  https://review.openstack.org/42251217:25
jaypipesanyway, writing an answer...17:25
jaypipesdansmith might be interested in this thread, too..17:25
sean-k-mooneythe main point i wanted to get across was the lib freeze is thusday so if we can fix it by then it needs to be fixed in kuryr kubernetes17:25
jaypipessean-k-mooney: "fix" is relative here, which is my point :)17:26
sean-k-mooneywe could revert the patch i guess since nova is not using that field17:26
jaypipessean-k-mooney: "fix" might be just a flat revert, yeah17:26
*** jpena|brb is now known as jpena17:27
sean-k-mooneywell we could certenly do that but they are using the object i a way we specifcially intoduced that patch to prevent so longterm we would have to adress the migration issue17:27
*** elmaciej has quit IRC17:28
*** lucasagomes is now known as lucas-afk17:30
jaypipessean-k-mooney: did you even know that kuryr-kubernetes was consuming os-vif objects? I certainly didn't...17:31
openstackgerritEric Berglund proposed openstack/nova master: PowerVM driver: ovs vif  https://review.openstack.org/42251217:35
*** andreas_s has joined #openstack-nova17:36
*** avolkov has quit IRC17:38
melwittbauzas: this was previously approved by mriedem, so I think we can re-approve it after the rebase https://review.openstack.org/#/c/53140717:38
*** bigdogstl has joined #openstack-nova17:39
*** bigdogstl has quit IRC17:44
openstackgerritSylvain Bauza proposed openstack/nova master: libvirt: create vGPU for instance  https://review.openstack.org/52883217:45
openstackgerritSylvain Bauza proposed openstack/nova master: Recreate mediated devices on reboot  https://review.openstack.org/53364217:45
bauzasmelwitt: okie17:46
* bauzas moves out for a while but will back tonight17:46
melwittthanks bauzas17:47
*** andreas_s_ has joined #openstack-nova17:47
*** links has quit IRC17:50
*** andreas_s has quit IRC17:50
*** gszasz has joined #openstack-nova17:50
*** hemna_ has joined #openstack-nova17:51
*** dikonoor has quit IRC17:52
*** bigdogstl has joined #openstack-nova17:52
itlinuxhello nova team.. I have a OOO deployment looking to implement cells2, by default cells2 has one already any tips on how to expand that? Thanks17:54
sean-k-mooneyjaypipes: i knew that  kuryr was for port plugging but i did not think they were ever storing if the os-vif objects17:55
openstackgerritJackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API  https://review.openstack.org/48620417:56
sean-k-mooneyjaypipes: the ips field that we moved form the subnet object to the vif object is never used in os-vif or nova hence why i taught it was safe to move it17:56
*** bigdogstl has quit IRC17:58
sean-k-mooneystephenfin: by the way looking at the nova unit test failuer in https://review.openstack.org/#/c/532987 i dont think we should ever be comparein the serialised form of os-vif objects in nova. we can add the  datapath_type field to allow this to pass but i think we should reduce the specificity of the test in the long run18:01
*** derekh has quit IRC18:02
stephenfinsean-k-mooney: Agreed18:03
stephenfinJust about to leave the office, but I can tackle that first thing in the morning18:03
stephenfinSoon as I finish mriedem's comments on the websocket security series18:03
stephenfino/18:03
sean-k-mooneystephenfin: ill give it a go tonight but if i have not pushed anything then please do18:04
*** ralonsoh has quit IRC18:07
*** gszasz has quit IRC18:08
*** bigdogstl has joined #openstack-nova18:09
melwittitlinux: do you mean you want to know how to add an additional cells v2 cell to a deployment?18:09
*** mvk has quit IRC18:10
itlinuxthanks melwitt: I need to add other cell2 to the env.18:10
itlinuxsince OOO has a default but I need to include other DC18:10
*** jackie-truong has quit IRC18:10
*** andreas_s_ has quit IRC18:11
melwittitlinux: sorry what's DC?18:13
itlinuxDatacenter.18:13
melwittitlinux: we have docs for adding a new cell here https://docs.openstack.org/nova/latest/user/cells.html#adding-a-new-cell-to-an-existing-deployment18:14
itlinuxthanks18:14
itlinuxthis is for cell2 right?18:14
melwittyou'll have to set up a database, message queue, etc for the new cell first, then you'll use nova-manage commands to create_cell and discover_hosts18:14
*** sambetts is now known as sambetts|afk18:14
melwittyes. the doc doesn't cover how to deploy the new message queue etc18:15
itlinuxok so I could run another OOO and then merge them?18:15
itlinuxbut it also says . Note, however, that this command is deprecated as of the 16.0.0 Pike release.18:15
itlinuxI am in Pike..18:15
melwitthm, no, I don't think you'd want to do that because OOO is going to create new controllers and you don't want that18:15
itlinuxok18:16
itlinuxthat's right..18:16
*** dtantsur is now known as dtantsur|afk18:16
itlinuxso do we have steps on how to create the Q18:16
*** bigdogstl has quit IRC18:16
openstackgerritChris Dent proposed openstack/nova master: [placement] use simple FaultWrapper  https://review.openstack.org/53375218:17
*** jpena is now known as jpena|off18:18
*** kmalloc has joined #openstack-nova18:19
*** Swami_ has joined #openstack-nova18:20
*** gouthamr has quit IRC18:20
*** Tom-Tom has quit IRC18:21
*** corvus is now known as jeblair18:21
*** jeblair is now known as corvus18:21
*** sahid has quit IRC18:21
*** lpetrut has quit IRC18:22
-openstackstatus- NOTICE: Zuul has been restarted and has lost queue contents; changes in progress will need to be rechecked.18:23
cdentdo I recall correctly that changing etc/nova/api-paste.ini is not something we can do easily?18:27
melwittitlinux: no, I don't think so. and I don't think OOO yet has the ability to add a new cells v2 cell18:27
itlinuxahh I heard that cells2 is enabled .. so just want to check how to find out18:28
*** elmaciej has joined #openstack-nova18:28
melwittit's enabled for one cell already, I just don't think they have a way of adding more cells18:29
itlinuxok..18:30
itlinuxyes one is there..18:30
itlinuxso how do we find that out? thanks melwitt:18:30
melwittitlinux: I would try asking in #tripleo about if there's support for multiple cells or if it's in the works18:32
*** felipemonteiro has joined #openstack-nova18:34
*** moshele has joined #openstack-nova18:34
*** felipemonteiro_ has joined #openstack-nova18:35
*** tidwellr has quit IRC18:35
*** tidwellr has joined #openstack-nova18:36
*** felipemonteiro has quit IRC18:39
*** moshele has quit IRC18:44
itlinuxhow about regions..18:46
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: SEA  https://review.openstack.org/52321618:48
*** AlexeyAbashkin has joined #openstack-nova18:50
openstackgerritJackie Truong proposed openstack/python-novaclient master: Microversion 2.60 - Add trusted_image_certificates  https://review.openstack.org/50039618:55
*** AlexeyAbashkin has quit IRC18:55
*** corvus is now known as jeblair18:58
*** jeblair is now known as corvus18:58
openstackgerritJay Pipes proposed openstack/nova master: func tests for nested providers in alloc candidate  https://review.openstack.org/53144319:11
openstackgerritJay Pipes proposed openstack/nova master: add _has_provider_trees() utility function  https://review.openstack.org/53147419:11
openstackgerritJay Pipes proposed openstack/nova master: placement: _get_trees_matching_all()  https://review.openstack.org/53151219:11
openstackgerritJay Pipes proposed openstack/nova master: add tests for _get_trees_matching_all() with trait  https://review.openstack.org/53189919:11
melwittjaypipes: o/ hope you're feeling better19:11
jaypipesmelwitt: thanks Melanie, I am :)19:13
*** suresh12 has joined #openstack-nova19:13
openstackgerritEric Berglund proposed openstack/nova master: PowerVM driver: ovs vif  https://review.openstack.org/42251219:13
*** suresh12 has quit IRC19:13
melwittjaypipes: glad to hear it :)19:15
prometheanfiresean-k-mooney: for the os-vif thing, is it gating related (open files) or neutron related (db deadlock)?19:15
melwittitlinux: you'll want to consult tripleo folks for questions about managing regions in a OOO deployment. this is a nova development channel19:16
sean-k-mooneyprometheanfire: i ran the senario test locally and all the failing test passed so im guessing the openfile issue is the real reason for the tempest failure19:16
sean-k-mooneyprometheanfire: ill be pushing a patch for the nova unit tests in a few seconds19:16
*** felipemonteiro__ has joined #openstack-nova19:17
prometheanfiresean-k-mooney: cool, if that works we can just depend on that19:17
*** edleafe- has joined #openstack-nova19:17
sean-k-mooneyprometheanfire: ya i think so i was going to update https://review.openstack.org/#/c/532987/1 also with a depends on. just need to copy some ssh keys as the vm im using has not been used for dev before.19:18
prometheanfiresean-k-mooney: wgm19:18
prometheanfirewfm19:18
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: SEA  https://review.openstack.org/52321619:19
melwittdansmith: do you think multiple cells with a global MQ could be a thing? I can't recall if you ever mentioned that in your cells talks19:19
melwittasking in reference to this review https://review.openstack.org/#/c/51855619:19
*** edleafe has quit IRC19:19
*** edleafe- is now known as edleafe19:19
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver  https://review.openstack.org/52609419:19
*** felipemonteiro_ has quit IRC19:20
dansmithmelwitt: you can't really because a compute will ask for conductor to do something, and you might get a conductor from your cell and you might not19:20
melwittdansmith: oh, yeah ... I didn't think of that. okay, cool19:20
*** bigdogstl has joined #openstack-nova19:20
openstackgerritsean mooney proposed openstack/nova master: make unit tests compatible with os-vif 0.8.0  https://review.openstack.org/53376619:22
sean-k-mooney... that should be 1.8.019:23
openstackgerritsean mooney proposed openstack/nova master: make unit tests compatible with os-vif 1.8.0  https://review.openstack.org/53376619:23
*** andreas_s has joined #openstack-nova19:23
*** moshele has joined #openstack-nova19:25
sean-k-mooneyprometheanfire: is it Depend-On or Depends-On:19:26
*** bigdogstl has quit IRC19:28
sean-k-mooneyprometheanfire: its Depends-On: .. one sec19:28
sean-k-mooneystephenfin: prometheanfire https://review.openstack.org/#/c/533766/ + https://review.openstack.org/#/c/532987/ should now hopefully work19:30
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: SEA  https://review.openstack.org/52321619:30
prometheanfirecool19:31
sean-k-mooneyprometheanfire: the issue was only in the unit tests. really execution paths would have worked so this is just a minor change.19:32
*** fragatina has joined #openstack-nova19:33
*** andreas_s has quit IRC19:38
edleafegolang flag parse19:39
edleafewrong channel?19:39
*** chyka has quit IRC19:42
cdentno edleafe, we've started, nova is going go19:49
*** AlexeyAbashkin has joined #openstack-nova19:51
sean-k-mooneycdent: is that toung and cheek or have we decided nova is not hipster enought lol19:53
cdentif we wanted to be hipster, go is surely too mainstream19:54
edleafenova is hipster only ironically19:54
sean-k-mooneycdent: but the alternitive would be rust and that too painful19:55
*** efried_rollin is now known as efried19:55
edleafeIronic should be written in rust19:55
*** AlexeyAbashkin has quit IRC19:55
cdentof course19:56
sean-k-mooneyedleafe: are you a parent because that right there is a dad joke19:56
edleafeoh, I could dad-joke you to death19:56
* cdent died long ago19:57
* edleafe thought cdent smelled funny19:58
*** moshele has quit IRC20:02
*** suresh12 has joined #openstack-nova20:03
*** tidwellr_ has joined #openstack-nova20:06
*** tidwellr has quit IRC20:06
*** slaweq has joined #openstack-nova20:15
jaypipesedleafe: is it wrong that I dad-joke but have no children (that I know of)20:16
edleafejaypipes: without kids it20:17
edleafeit's just bad-joke20:17
cdentjaypipes: your brother is your twin, yeah? maybe that's it?20:17
*** lpetrut has joined #openstack-nova20:19
*** bigdogstl has joined #openstack-nova20:20
*** dansmith has quit IRC20:22
*** markvoelker has quit IRC20:22
jaypipescdent: yes. yes, that's it. I'll blame him.20:25
cdentalways happy so sow brotherly discord20:26
openstackgerritMatthew Edmonds proposed openstack/nova master: Add taskflow to requirements  https://review.openstack.org/53377920:27
*** bigdogstl has quit IRC20:28
*** jdillaman has quit IRC20:29
*** matrohon has joined #openstack-nova20:34
*** jdillaman has joined #openstack-nova20:34
*** fragatina has quit IRC20:35
*** Guest49522 has joined #openstack-nova20:35
*** Guest49522 is now known as dansmith20:40
*** awaugama has quit IRC20:42
*** matrohon has quit IRC20:45
*** matrohon has joined #openstack-nova20:46
*** sree has joined #openstack-nova20:47
*** AlexeyAbashkin has joined #openstack-nova20:50
*** sree has quit IRC20:52
*** AlexeyAbashkin has quit IRC20:54
*** lpetrut has quit IRC20:56
openstackgerritJackie Truong proposed openstack/nova master: Add trusted_certs object  https://review.openstack.org/48940820:58
*** bigdogstl has joined #openstack-nova20:58
*** chyka has joined #openstack-nova20:59
*** vivsoni_ has joined #openstack-nova21:03
*** tidwellr_ has quit IRC21:06
*** suresh12 has quit IRC21:06
*** tidwellr has joined #openstack-nova21:06
*** vivsoni has quit IRC21:06
*** suresh12 has joined #openstack-nova21:07
*** bigdogstl has quit IRC21:10
openstackgerritChris Dent proposed openstack/nova master: WIP: Refactor WSGI apps and utils to limit imports  https://review.openstack.org/53379721:10
*** prometheanfire has left #openstack-nova21:10
cdentefried, edleafe, jaypipes: you might find that ^ interesting. Not done yet, but a potentially useful tidy up21:11
cdentwill get back to it tomorrow21:11
*** flwang has quit IRC21:11
jaypipesbauzas: https://review.openstack.org/#/c/528832/9/nova/virt/libvirt/config.py :)21:13
*** fragatina has joined #openstack-nova21:13
jaypipescdent: ack21:13
jaypipesbauzas: maybe 10th time is the charm? ;P21:13
jaypipesok, now on to efried'21:15
jaypipess series :)21:15
* efried waits, with breath abated...21:16
bauzasjaypipes: oh fuuuuuuu21:20
bauzaschilds is because I stupidly copied some other patch :p21:20
bauzasI have two children21:21
bauzasso I know that :p21:21
*** suresh12 has quit IRC21:21
jaypipesbauzas: :)21:22
openstackgerritSylvain Bauza proposed openstack/nova master: libvirt: create vGPU for instance  https://review.openstack.org/52883221:24
openstackgerritSylvain Bauza proposed openstack/nova master: Recreate mediated devices on reboot  https://review.openstack.org/53364221:24
bauzashop là21:24
*** flwang has joined #openstack-nova21:25
bauzasdansmith: just in case you're still around, I'm thinking about hard reboot21:25
bauzasdansmith: I could just ask for the existing mdev before destroying the guest, and then pass it back to _get_guest_xml() like I said21:26
*** nicolasbock has quit IRC21:26
*** fragatina has quit IRC21:26
bauzasdansmith: but then, that means that for example, if we have a lot of months in between stopping the instance and restarting it, then we won't verify if that's still okay21:27
bauzasthe reason actually why we try to retry the xml21:28
bauzasand not just reusing it21:28
bauzasif we agree with that, fine21:28
bauzasif we don't want that, then we would need to pass again the allocation21:28
bauzasthoughts ?21:28
sean-k-mooneyjaypipes: bauzas melwitt dansmith when ye get a chance can ye take a look at https://review.openstack.org/#/c/533766/ to unblock https://review.openstack.org/#/c/532987/21:29
bauzassean-k-mooney: easy +221:29
bauzasoh wait21:30
bauzassean-k-mooney: what is the min os-vif version for Nova ?21:30
*** pcaruana has quit IRC21:30
sean-k-mooneycurrently 1.6 i think let me check21:30
*** dave-mccowan has joined #openstack-nova21:31
sean-k-mooney1.7.021:31
*** jappleii__ has joined #openstack-nova21:32
*** dgonzalez has quit IRC21:33
*** bigdogstl has joined #openstack-nova21:33
bauzassean-k-mooney: -1 because https://github.com/openstack/os-vif/blob/1.7.0/os_vif/objects/vif.py21:34
jaypipeswhy do we have open-ended dependencies like >=1.7.0 again? :(21:34
sean-k-mooneywell we have a catch 22 then21:35
sean-k-mooneythe change that increases the upper constriants need this change21:35
sean-k-mooneyjaypipes: they are closed by upper-constratints21:36
bauzassean-k-mooney: before merging the nova change, we should IMHO first bump the min version21:36
bauzassean-k-mooney: is g-r accepting >= 1.8.0 ?21:36
bauzasif so, just change directly nova requirements.txt21:36
bauzasin the same change21:37
bauzasif not, you need first to modify g-r21:37
sean-k-mooneybauzas: no g-r is os-vif>=1.7.0 u-c is os-vif===1.7.021:37
sean-k-mooneywe cant increase g-r without first increaseing u-c and u-c need that patch21:38
*** bigdogstl has quit IRC21:38
*** dgonzalez has joined #openstack-nova21:42
bauzassean-k-mooney: mmm, looks like a Depends-On change then21:42
sean-k-mooneythe depends-on is currently from https://review.openstack.org/#/c/532987/ to https://review.openstack.org/#/c/533766/221:43
openstackgerritArtom Lifshitz proposed openstack/nova master: Refactor _build_device_metadata  https://review.openstack.org/53380421:43
openstackgerritArtom Lifshitz proposed openstack/nova master: Consider hostdev devices when building metadata  https://review.openstack.org/53380521:43
bauzassean-k-mooney: I guess the gate is not accepting to upgrade upper-constraints because it tests nova ?21:43
sean-k-mooneyyep21:43
bauzasshit21:43
*** lbragstad has quit IRC21:44
sean-k-mooneywe could pin os-vif in nova then increase the upperconstraints then fix the test and bump minium21:44
sean-k-mooneyand unpin21:44
bauzassean-k-mooney: I think we can possibly ask nova to bump os-vif to 1.8.0 and in the meantime have the g-r change that bumps both global-reqs.txt and upper-constraints.txt21:45
bauzassince there will be a depends-on, that should gate correctly21:45
bauzasbut I'm not a requirements expert21:46
bauzastonyb: around ?21:46
bauzastonyb: questions for a requirements upgrade loop21:46
sean-k-mooneythe change that fixes the tests for 1.8 also works on 1.7 because of weird ness with ovo hence why the patch is currently passing zuul without using os-vif 1.8.021:46
*** lbragstad has joined #openstack-nova21:47
*** matrohon has quit IRC21:48
bauzassean-k-mooney: no I think the nova change uses 1.8.021:48
bauzassean-k-mooney: because pypi will give you the last version21:48
sean-k-mooneybasically https://github.com/openstack/nova/blob/6a5673a16f8329007880b67a6dbecbe62ac368d7/nova/tests/unit/network/test_os_vif_util.py#L34-L38 means that the extra datapath_type field is discarded21:48
sean-k-mooneybauzas: no i checked locally it was using 1.7.021:49
sean-k-mooneylet me check the test logs21:49
bauzasoh fun, you're right http://logs.openstack.org/66/533766/2/check/openstack-tox-py27/45f0378/job-output.txt.gz#_2018-01-15_20_03_47_08891821:50
*** AlexeyAbashkin has joined #openstack-nova21:50
*** chyka_ has joined #openstack-nova21:50
sean-k-mooneyyep so normally this would be a pain in the ass and we would have to bump the minium but in this case we dont21:51
bauzas:/21:51
bauzaswait21:51
bauzasthat works because it's using o.vo so maybe it's just downgrading the version21:52
bauzasI mean the object version21:52
bauzashence why it works21:52
*** chyka has quit IRC21:53
sean-k-mooneywell im adding a new filed to the expected value so use if it downgraded it would discard it but os-vif 1.7.0 does not have explcit down grade logic for 1.8.0 objects21:53
*** AlexeyAbashkin has quit IRC21:54
sean-k-mooneybauzas: basically it works because of this https://github.com/openstack/oslo.versionedobjects/blob/1.18.0/oslo_versionedobjects/base.py#L514-L52021:54
sean-k-mooneyobj_to_primitive loops over the ovo fields and uses that to generate the dictionary retrunt by obj_to_primitive21:55
bauzassean-k-mooney: right, it works thanks of the ovo framework, that's it21:56
bauzassoooooo...21:56
sean-k-mooneysince datapath_type is not in the 1.7.0 field list it just gets discared21:56
bauzaswhat to do ?21:56
bauzasI think I'll +221:56
bauzasit's harmless21:56
bauzasand unblocks things21:56
sean-k-mooneyout side of unit tests we have defencive logic  which will only populate the datapath_type if it is defined in the vif object21:57
sean-k-mooneyand in os-vif we also default to the original hardcoded values if the datapath_type is not set in the profile21:58
sean-k-mooneyso in real code this is safe21:58
*** bigdogstl has joined #openstack-nova21:58
bauzasright21:58
sean-k-mooneyanyway its almost 10 so its 2 hours past when i should have gone home. catch ye tommorow o/21:59
*** archit has quit IRC22:00
bauzas\o22:00
openstackgerritJay Pipes proposed openstack/nova master: placement: _get_trees_matching_all()  https://review.openstack.org/53151222:01
openstackgerritJay Pipes proposed openstack/nova master: add tests for _get_trees_matching_all() with trait  https://review.openstack.org/53189922:01
*** dillaman has joined #openstack-nova22:01
*** bigdogstl has quit IRC22:03
*** matrohon has joined #openstack-nova22:03
*** bigdogstl has joined #openstack-nova22:09
*** jackie-truong has joined #openstack-nova22:09
*** suresh12 has joined #openstack-nova22:09
*** lbragstad has quit IRC22:10
*** mvk has joined #openstack-nova22:11
*** suresh12 has quit IRC22:16
*** fragatina has joined #openstack-nova22:16
*** lbragstad has joined #openstack-nova22:19
*** matrohon has quit IRC22:21
*** rcernin has joined #openstack-nova22:21
openstackgerritEric Fried proposed openstack/nova master: SchedulerReportClient.set_traits_for_provider  https://review.openstack.org/53256422:22
openstackgerritEric Fried proposed openstack/nova master: Track associated sharing RPs in report client  https://review.openstack.org/52653922:22
openstackgerritEric Fried proposed openstack/nova master: Raise on API errors getting aggregates/traits  https://review.openstack.org/52654022:22
openstackgerritEric Fried proposed openstack/nova master: ProviderTree.populate_from_iterable  https://review.openstack.org/52075622:22
openstackgerritEric Fried proposed openstack/nova master: Track tree-associated providers in report client  https://review.openstack.org/52654122:22
openstackgerritEric Fried proposed openstack/nova master: Scheduler[Report]Client.get_provider_tree  https://review.openstack.org/52109822:22
openstackgerritEric Fried proposed openstack/nova master: WIP: ComputeDriver.update_provider_tree()  https://review.openstack.org/52118722:22
openstackgerritEric Fried proposed openstack/nova master: ProviderTree.snapshot => ProviderSnapshot  https://review.openstack.org/53324422:22
openstackgerritEric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker  https://review.openstack.org/52024622:22
openstackgerritEric Fried proposed openstack/nova master: SchedulerReportClient.set_aggregates_for_provider  https://review.openstack.org/53380822:22
efriedjaypipes I removed that 'generation' param in the snapshot patch (where I also cleaned up the other _Provider-accessing cheats).22:23
*** bigdogstl has quit IRC22:23
efriedjaypipes If that's too messy for ya, I'll reshuffle the whole series.22:23
*** slaweq has quit IRC22:24
*** smatzek has quit IRC22:24
*** slaweq has joined #openstack-nova22:24
tonybbauzas: you need 1 review to bump u-c; a second that bumps g-r and have the nova change gate on that 2nd chnage ... which I think is basically what you said22:27
*** slaweq has quit IRC22:29
*** bigdogstl has joined #openstack-nova22:30
*** jackie-truong has quit IRC22:33
*** felipemonteiro__ has quit IRC22:33
bauzastonyb: the problem is that it seems the u-c change is gated by nova which needs the test modification22:34
bauzasas per sean-k-mooney22:35
*** moshele has joined #openstack-nova22:37
efriedjaypipes I'm not convinced that ProviderTree.delta(other_provider_tree) is the way to go, because whatever that guy returns is going to be an ugly blob of unstructured data.  I was thinking to do the diff-and-update logic in a single method either in report client or resource tracker.22:38
*** slaweq has joined #openstack-nova22:39
*** bigdogstl has quit IRC22:39
*** suresh12 has joined #openstack-nova22:40
*** lyan has quit IRC22:43
*** slaweq has quit IRC22:44
*** tidwellr has quit IRC22:44
*** fragatina has quit IRC22:45
*** suresh12 has quit IRC22:45
*** moshele has quit IRC22:48
*** bigdogstl has joined #openstack-nova22:51
*** markvoelker has joined #openstack-nova22:53
*** chyka_ has quit IRC22:55
*** chyka has joined #openstack-nova22:56
*** eharney has quit IRC22:57
*** markvoelker has quit IRC22:58
*** john51 has quit IRC22:59
*** lbragstad has quit IRC23:00
*** john51 has joined #openstack-nova23:00
*** bigdogstl has quit IRC23:01
*** john51 has quit IRC23:02
*** hieulq has quit IRC23:02
*** hieulq has joined #openstack-nova23:03
*** john51 has joined #openstack-nova23:05
*** esberglu has quit IRC23:10
*** esberglu has joined #openstack-nova23:11
*** esberglu has quit IRC23:16
*** cdent has quit IRC23:17
*** bigdogstl has joined #openstack-nova23:17
jaypipesefried: I'd be fine with that (single method diff-and-update thing)23:20
efriedjaypipes coo, working on it.23:20
jaypipesefried: and will re-review your bottom series tomrrow morn.23:20
efriedack23:21
jaypipesefried: signing off for the night.23:21
efriedsleep tight23:21
jaypipesdanke23:21
*** takashin has joined #openstack-nova23:22
openstackgerritChris Dent proposed openstack/nova master: WIP: Refactor WSGI apps and utils to limit imports  https://review.openstack.org/53379723:25
*** bigdogstl has quit IRC23:25
*** esberglu has joined #openstack-nova23:27
openstackgerritSylvain Bauza proposed openstack/nova master: WIP: libvirt: pass the mdevs when rebooting the guest  https://review.openstack.org/53381823:27
*** esberglu has quit IRC23:28
*** hongbin has quit IRC23:28
gmannameeda: sure, ll check that23:29
openstackgerritEric Fried proposed openstack/nova master: ComputeDriver.update_provider_tree()  https://review.openstack.org/52118723:30
openstackgerritEric Fried proposed openstack/nova master: ProviderTree.snapshot => ProviderSnapshot  https://review.openstack.org/53324423:30
openstackgerritEric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker  https://review.openstack.org/52024623:31
openstackgerritEric Fried proposed openstack/nova master: WIP: Scheduler[Report]Client.update_from_provider_tree  https://review.openstack.org/53382123:31
*** itlinux has quit IRC23:33
*** r-daneel has quit IRC23:33
*** bigdogstl has joined #openstack-nova23:40
*** chyka_ has joined #openstack-nova23:44
*** nicolasbock has joined #openstack-nova23:47
*** chyka has quit IRC23:49
*** suresh12 has joined #openstack-nova23:51
*** lbragstad has joined #openstack-nova23:53
*** armax has quit IRC23:54
*** bigdogstl has quit IRC23:54

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!