*** karthiks has joined #openstack-nova | 00:01 | |
*** yankcrime has quit IRC | 00:04 | |
*** _nick has joined #openstack-nova | 00:05 | |
*** sree has joined #openstack-nova | 00:08 | |
*** karthiks has quit IRC | 00:09 | |
*** armax has quit IRC | 00:10 | |
*** sree has quit IRC | 00:12 | |
*** dave-mccowan has joined #openstack-nova | 00:18 | |
*** karthiks has joined #openstack-nova | 00:22 | |
*** yingjun has joined #openstack-nova | 00:22 | |
*** sree has joined #openstack-nova | 00:27 | |
*** sree has quit IRC | 00:32 | |
*** suresh12 has joined #openstack-nova | 00:38 | |
*** edmondsw has joined #openstack-nova | 00:46 | |
*** hiro-kobayahi has joined #openstack-nova | 00:48 | |
*** liuzz has joined #openstack-nova | 00:48 | |
*** yassine has joined #openstack-nova | 00:51 | |
*** edmondsw has quit IRC | 00:51 | |
*** yassine is now known as Guest78703 | 00:51 | |
*** Tom-Tom has joined #openstack-nova | 00:52 | |
*** Tom-Tom has quit IRC | 00:59 | |
*** Tom-Tom has joined #openstack-nova | 01:00 | |
*** Tom-Tom has quit IRC | 01:01 | |
*** Tom-Tom has joined #openstack-nova | 01:01 | |
*** Tom-Tom_ has joined #openstack-nova | 01:03 | |
*** hshiina has joined #openstack-nova | 01:03 | |
*** Tom-Tom has quit IRC | 01:06 | |
*** phuongnh has joined #openstack-nova | 01:06 | |
*** zhaochao has joined #openstack-nova | 01:08 | |
*** hieulq has joined #openstack-nova | 01:12 | |
*** tiendc has joined #openstack-nova | 01:14 | |
*** yangyapeng has joined #openstack-nova | 01:15 | |
*** tuanla____ has joined #openstack-nova | 01:24 | |
*** zhurong has joined #openstack-nova | 01:29 | |
*** suresh12 has quit IRC | 01:29 | |
*** suresh12 has joined #openstack-nova | 01:31 | |
*** zhurong has quit IRC | 01:33 | |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Fix 500 in test_resize_server_negative_invalid_state https://review.openstack.org/531117 | 01:33 |
---|---|---|
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add index(instance_uuid, updated_at) on instance_actions table https://review.openstack.org/530429 | 01:34 |
*** suresh12 has quit IRC | 01:36 | |
*** markvoelker has joined #openstack-nova | 01:47 | |
*** gongysh has joined #openstack-nova | 01:49 | |
*** hongbin has joined #openstack-nova | 02:02 | |
*** fragatina has quit IRC | 02:05 | |
*** Dinesh_Bhor has joined #openstack-nova | 02:06 | |
openstackgerrit | jichenjc proposed openstack/nova-specs master: add z/VM Driver in Rocky https://review.openstack.org/536186 | 02:08 |
*** gcb has joined #openstack-nova | 02:09 | |
*** crushil_ has joined #openstack-nova | 02:11 | |
*** weshay has quit IRC | 02:14 | |
openstackgerrit | int32bit proposed openstack/nova master: Fix wrong disk size for sparse flat files https://review.openstack.org/396873 | 02:14 |
*** weshay has joined #openstack-nova | 02:15 | |
*** markvoelker has quit IRC | 02:21 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in delete (3) https://review.openstack.org/526557 | 02:23 |
*** takashin has left #openstack-nova | 02:26 | |
*** zhurong has joined #openstack-nova | 02:32 | |
openstackgerrit | Ya Lian Pan proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 02:34 |
openstackgerrit | Ya Lian Pan proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 02:34 |
*** takashin has joined #openstack-nova | 02:34 | |
*** annp has joined #openstack-nova | 02:50 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers.inc https://review.openstack.org/528201 | 02:52 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Example verification for servers.inc https://review.openstack.org/529520 | 02:52 |
*** crushil_ has quit IRC | 02:53 | |
*** yamamoto has joined #openstack-nova | 02:57 | |
*** hiro-kobayahi has quit IRC | 03:12 | |
*** ljjjustin has joined #openstack-nova | 03:16 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in post https://review.openstack.org/526823 | 03:17 |
*** markvoelker has joined #openstack-nova | 03:17 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (1) https://review.openstack.org/531258 | 03:17 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (2) https://review.openstack.org/531266 | 03:18 |
*** karthiks has quit IRC | 03:18 | |
*** sree has joined #openstack-nova | 03:24 | |
*** ljjjustin has quit IRC | 03:27 | |
*** karthiks has joined #openstack-nova | 03:31 | |
*** psachin has joined #openstack-nova | 03:39 | |
*** hshiina has quit IRC | 03:43 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (3) https://review.openstack.org/531280 | 03:45 |
*** hshiina has joined #openstack-nova | 03:47 | |
*** suresh12 has joined #openstack-nova | 03:49 | |
*** markvoelker has quit IRC | 03:51 | |
*** Tom-Tom_ has quit IRC | 03:52 | |
*** yangyapeng has quit IRC | 03:55 | |
*** hiro-kobayashi has joined #openstack-nova | 03:56 | |
*** chyka has joined #openstack-nova | 03:56 | |
*** links has joined #openstack-nova | 04:00 | |
*** abhishekk has joined #openstack-nova | 04:05 | |
*** chyka has quit IRC | 04:09 | |
*** crushil_ has joined #openstack-nova | 04:10 | |
*** Tom-Tom has joined #openstack-nova | 04:12 | |
*** sapd has quit IRC | 04:14 | |
*** Tom-Tom has quit IRC | 04:16 | |
*** lyan has quit IRC | 04:17 | |
*** dave-mccowan has quit IRC | 04:21 | |
*** edmondsw has joined #openstack-nova | 04:22 | |
*** suresh12 has quit IRC | 04:23 | |
*** chyka has joined #openstack-nova | 04:26 | |
*** edmondsw has quit IRC | 04:27 | |
*** sapd has joined #openstack-nova | 04:28 | |
*** chyka has quit IRC | 04:30 | |
*** bhujay has joined #openstack-nova | 04:32 | |
*** yangyapeng has joined #openstack-nova | 04:34 | |
*** crushil_ has quit IRC | 04:36 | |
*** zhurong has quit IRC | 04:39 | |
*** tetsuro_ has joined #openstack-nova | 04:40 | |
*** vivsoni has joined #openstack-nova | 04:46 | |
vivsoni | hi team, i am having master setup created 2 days back, 'nova net-list' command not found | 04:46 |
vivsoni | error: argument <subcommand>: invalid choice: u'net-list' | 04:47 |
vivsoni | is this command deprecated ? | 04:47 |
*** gongysh has quit IRC | 04:47 | |
*** markvoelker has joined #openstack-nova | 04:48 | |
takashin | vivsoni: 'nova net-list' has been removed in Pike. See https://docs.openstack.org/releasenotes/python-novaclient/pike.html#id10 . | 04:51 |
*** karthiks has quit IRC | 04:58 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in get https://review.openstack.org/531299 | 05:01 |
vivsoni | takashin: thanks :) | 05:01 |
jianghuaw | vivsoni, now you can use "openstack network list" instead. | 05:02 |
*** hongbin has quit IRC | 05:03 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Add CLI to show instance usage audit logs https://review.openstack.org/409413 | 05:04 |
*** suresh12 has joined #openstack-nova | 05:04 | |
*** Tom-Tom has joined #openstack-nova | 05:13 | |
openstackgerrit | Deepak Mourya proposed openstack/nova master: Handle TZ change in iso8601 >=1.12.0 https://review.openstack.org/535700 | 05:15 |
*** yangyapeng has quit IRC | 05:16 | |
vivsoni | jianghuaw: ohk.. i was searching for that only. Thanks.. also it would be great if you can share link from which in future i can refer to | 05:20 |
*** markvoelker has quit IRC | 05:21 | |
jianghuaw | vivsoni, the commands are included in openstack client. See here: https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/network.html | 05:24 |
vivsoni | jianghuaw: Thanks !!! | 05:25 |
*** gongysh has joined #openstack-nova | 05:26 | |
*** chyka has joined #openstack-nova | 05:30 | |
*** trinaths has joined #openstack-nova | 05:33 | |
*** chyka has quit IRC | 05:34 | |
*** suresh12 has quit IRC | 05:38 | |
openstackgerrit | Merged openstack/nova master: Fix instance evacuation with PCI devices https://review.openstack.org/484381 | 05:38 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (1) https://review.openstack.org/531258 | 05:38 |
*** threestrands has quit IRC | 05:40 | |
*** yangyapeng has joined #openstack-nova | 05:41 | |
*** zhurong has joined #openstack-nova | 05:44 | |
*** yangyapeng has quit IRC | 05:45 | |
*** hiro-kobayashi has quit IRC | 05:50 | |
*** ratailor has joined #openstack-nova | 05:51 | |
*** chyka has joined #openstack-nova | 05:51 | |
*** sapd has quit IRC | 05:51 | |
*** gongysh has quit IRC | 05:52 | |
*** gongysh has joined #openstack-nova | 05:55 | |
*** oanson has quit IRC | 05:55 | |
*** chyka has quit IRC | 05:56 | |
*** sapd has joined #openstack-nova | 05:56 | |
*** hshiina has quit IRC | 05:56 | |
*** yamahata has quit IRC | 05:56 | |
*** yangyapeng has joined #openstack-nova | 05:59 | |
*** Dinesh_Bhor has quit IRC | 06:02 | |
*** Dinesh_Bhor has joined #openstack-nova | 06:04 | |
*** suresh12 has joined #openstack-nova | 06:08 | |
*** Dinesh_Bhor has quit IRC | 06:08 | |
*** edmondsw has joined #openstack-nova | 06:11 | |
*** suresh12 has quit IRC | 06:12 | |
*** Dinesh_Bhor has joined #openstack-nova | 06:14 | |
*** Dinesh_Bhor has quit IRC | 06:14 | |
*** edmondsw has quit IRC | 06:15 | |
*** markvoelker has joined #openstack-nova | 06:18 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (2) https://review.openstack.org/531266 | 06:21 |
*** jmlowe_ has joined #openstack-nova | 06:22 | |
*** sapd has quit IRC | 06:24 | |
*** sapd has joined #openstack-nova | 06:24 | |
*** jmlowe has quit IRC | 06:26 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (3) https://review.openstack.org/531280 | 06:29 |
*** lajoskatona has joined #openstack-nova | 06:30 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in get https://review.openstack.org/531299 | 06:30 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: [cellv2] Improve getting BDMs in multiple cells https://review.openstack.org/521400 | 06:32 |
*** trinaths has quit IRC | 06:32 | |
*** trinaths has joined #openstack-nova | 06:33 | |
*** sree_ has joined #openstack-nova | 06:33 | |
*** sree_ is now known as Guest86250 | 06:34 | |
*** sree has quit IRC | 06:36 | |
*** ratailor has quit IRC | 06:39 | |
*** ratailor has joined #openstack-nova | 06:40 | |
*** tianhui has quit IRC | 06:45 | |
*** tianhui has joined #openstack-nova | 06:45 | |
*** hieulq has quit IRC | 06:45 | |
*** markvoelker has quit IRC | 06:51 | |
*** sridharg has joined #openstack-nova | 06:51 | |
*** vipul has quit IRC | 06:54 | |
*** dikonoor has joined #openstack-nova | 06:59 | |
*** hieulq has joined #openstack-nova | 07:00 | |
*** ttallgren has joined #openstack-nova | 07:01 | |
*** edand has joined #openstack-nova | 07:02 | |
*** oanson has joined #openstack-nova | 07:02 | |
*** alexchadin has joined #openstack-nova | 07:05 | |
openstackgerrit | shuangyang.qian proposed openstack/nova master: Fix the metadata re to match the Chinese https://review.openstack.org/536236 | 07:13 |
*** qsyqian has joined #openstack-nova | 07:15 | |
*** rcernin has quit IRC | 07:17 | |
*** andreas_s has joined #openstack-nova | 07:26 | |
*** gszasz has joined #openstack-nova | 07:26 | |
*** chyka has joined #openstack-nova | 07:27 | |
*** Guest86250 has quit IRC | 07:32 | |
*** sree has joined #openstack-nova | 07:32 | |
*** yingjun has quit IRC | 07:32 | |
*** ratailor is now known as ratailor|Lunch | 07:34 | |
*** fragatina has joined #openstack-nova | 07:36 | |
*** chyka has quit IRC | 07:36 | |
*** avolkov has joined #openstack-nova | 07:40 | |
*** slaweq has joined #openstack-nova | 07:47 | |
*** markvoelker has joined #openstack-nova | 07:48 | |
*** sapd_ has joined #openstack-nova | 07:48 | |
*** sapd has quit IRC | 07:48 | |
*** sahid has joined #openstack-nova | 07:49 | |
*** pcaruana has joined #openstack-nova | 07:52 | |
*** janki has joined #openstack-nova | 07:55 | |
*** edmondsw has joined #openstack-nova | 07:59 | |
*** matrohon has joined #openstack-nova | 07:59 | |
openstackgerrit | shuangyang.qian proposed openstack/nova master: Fix the wrong user_id record in the log https://review.openstack.org/536243 | 08:00 |
*** edmondsw has quit IRC | 08:03 | |
*** rgerganov has joined #openstack-nova | 08:07 | |
*** Tom-Tom has quit IRC | 08:08 | |
*** chyka has joined #openstack-nova | 08:08 | |
*** Tom-Tom has joined #openstack-nova | 08:09 | |
*** chyka has quit IRC | 08:13 | |
*** Tom-Tom has quit IRC | 08:13 | |
*** Tom-Tom has joined #openstack-nova | 08:14 | |
*** qsyqian has quit IRC | 08:14 | |
*** alexchadin has quit IRC | 08:15 | |
*** AlexeyAbashkin has joined #openstack-nova | 08:15 | |
*** alexchadin has joined #openstack-nova | 08:18 | |
*** tesseract has joined #openstack-nova | 08:19 | |
*** ratailor|Lunch is now known as ratailor | 08:20 | |
*** markvoelker has quit IRC | 08:21 | |
*** fragatina has quit IRC | 08:22 | |
*** tssurya has joined #openstack-nova | 08:23 | |
*** ralonsoh has joined #openstack-nova | 08:26 | |
*** danpawlik has joined #openstack-nova | 08:29 | |
*** zhaochao has quit IRC | 08:31 | |
*** slaweq_ has joined #openstack-nova | 08:31 | |
*** zhaochao has joined #openstack-nova | 08:31 | |
*** slaweq_ has quit IRC | 08:36 | |
*** giblet is now known as gibi | 08:39 | |
gibi | good morning nova | 08:39 |
Spazmotic | mornin gibi | 08:40 |
*** damien_r has joined #openstack-nova | 08:41 | |
Spazmotic | UK Slowly waking up and my 3rd shift US butt over here just sitting over here all lonely :D | 08:41 |
*** tovin07 has joined #openstack-nova | 08:43 | |
*** andreas_s has quit IRC | 08:43 | |
*** tovin07 has quit IRC | 08:43 | |
*** andreas_s has joined #openstack-nova | 08:44 | |
*** sidx64 has joined #openstack-nova | 08:46 | |
*** jpena|off is now known as jpena | 08:46 | |
*** migi has quit IRC | 08:49 | |
*** migi has joined #openstack-nova | 08:50 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform instance-evacuate notification https://review.openstack.org/482148 | 08:51 |
*** slaweq_ has joined #openstack-nova | 08:53 | |
*** andreas_s has quit IRC | 08:53 | |
*** sidx64 has quit IRC | 08:56 | |
*** gaurangt has quit IRC | 08:56 | |
*** gaurangt has joined #openstack-nova | 08:56 | |
*** sidx64 has joined #openstack-nova | 08:57 | |
*** slaweq_ has quit IRC | 08:57 | |
*** andreas_s has joined #openstack-nova | 08:58 | |
*** alexchadin has quit IRC | 08:59 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix a comment in a notification functional test https://review.openstack.org/536262 | 09:06 |
*** andreas_s has quit IRC | 09:07 | |
*** andreas_s has joined #openstack-nova | 09:09 | |
*** jaosorior has joined #openstack-nova | 09:10 | |
bauzas | good morning folks | 09:10 |
Spazmotic | morning | 09:12 |
ameeda | Morning | 09:13 |
*** damien_r has quit IRC | 09:13 | |
ameeda | can you please check my comments here ? https://review.openstack.org/#/c/526900/ | 09:13 |
*** damien_r has joined #openstack-nova | 09:14 | |
*** mgoddard_ has joined #openstack-nova | 09:16 | |
*** andreas_s has quit IRC | 09:16 | |
*** andreas_s has joined #openstack-nova | 09:17 | |
*** Eran_Kuris has quit IRC | 09:19 | |
*** markvoelker has joined #openstack-nova | 09:19 | |
openstackgerrit | int32bit proposed openstack/nova master: Rollback original image info if server fail to rebuild https://review.openstack.org/536268 | 09:19 |
*** Eran_Kuris has joined #openstack-nova | 09:19 | |
openstackgerrit | Alex Xu proposed openstack/nova master: placement: enable required traits from the flavor extra specs https://review.openstack.org/536085 | 09:19 |
*** markvoelker has quit IRC | 09:23 | |
*** derekh has joined #openstack-nova | 09:25 | |
*** _nick is now known as yankcrime | 09:31 | |
*** gcb has quit IRC | 09:32 | |
*** gszasz has quit IRC | 09:35 | |
*** Tom-Tom has quit IRC | 09:36 | |
*** Tom-Tom has joined #openstack-nova | 09:37 | |
*** Tom-Tom has quit IRC | 09:37 | |
*** Tom-Tom has joined #openstack-nova | 09:37 | |
*** Tom-Tom has quit IRC | 09:38 | |
*** Tom-Tom has joined #openstack-nova | 09:39 | |
*** Tom-Tom_ has joined #openstack-nova | 09:43 | |
*** Tom-Tom has quit IRC | 09:44 | |
*** bhagyashris has joined #openstack-nova | 09:44 | |
*** edmondsw has joined #openstack-nova | 09:47 | |
*** edmondsw has quit IRC | 09:52 | |
*** rmart04 has joined #openstack-nova | 09:52 | |
*** raorn has joined #openstack-nova | 09:53 | |
*** pooja_jadhav has joined #openstack-nova | 09:54 | |
*** pooja-jadhav has joined #openstack-nova | 09:54 | |
*** pooja-jadhav has quit IRC | 09:54 | |
*** yamamoto has quit IRC | 09:57 | |
*** chyka has joined #openstack-nova | 09:58 | |
*** yamamoto has joined #openstack-nova | 09:58 | |
*** chyka has quit IRC | 10:02 | |
*** szaher has joined #openstack-nova | 10:02 | |
*** yamamoto has quit IRC | 10:03 | |
*** dtantsur|afk is now known as dtantsur | 10:05 | |
*** sree has quit IRC | 10:06 | |
*** sree has joined #openstack-nova | 10:06 | |
*** yamamoto has joined #openstack-nova | 10:09 | |
*** trinaths has left #openstack-nova | 10:10 | |
*** yamamoto has quit IRC | 10:10 | |
*** sree has quit IRC | 10:11 | |
*** yamamoto has joined #openstack-nova | 10:12 | |
*** mgoddard_ has quit IRC | 10:13 | |
*** alexchadin has joined #openstack-nova | 10:16 | |
*** yangyapeng has quit IRC | 10:18 | |
*** takashin_ has joined #openstack-nova | 10:19 | |
*** takashin has quit IRC | 10:21 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameter type in server-migrations.inc https://review.openstack.org/536293 | 10:21 |
*** sidx64 has quit IRC | 10:22 | |
*** Tom-Tom_ has quit IRC | 10:23 | |
*** Tom-Tom has joined #openstack-nova | 10:24 | |
*** mgoddard_ has joined #openstack-nova | 10:25 | |
*** Tom-Tom has quit IRC | 10:29 | |
*** Tom-Tom has joined #openstack-nova | 10:29 | |
*** liuzz has quit IRC | 10:30 | |
*** tuanla____ has quit IRC | 10:30 | |
*** tetsuro_ has quit IRC | 10:30 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameter order in rebuild https://review.openstack.org/529718 | 10:31 |
*** itlinux has joined #openstack-nova | 10:32 | |
*** zhurong has quit IRC | 10:33 | |
*** Tom-Tom has quit IRC | 10:34 | |
openstackgerrit | sahid proposed openstack/nova stable/pike: Fixes 'Not enough available memory' log message https://review.openstack.org/536297 | 10:36 |
*** gszasz has joined #openstack-nova | 10:36 | |
*** sidx64 has joined #openstack-nova | 10:37 | |
*** yangyapeng has joined #openstack-nova | 10:38 | |
*** sidx64 has quit IRC | 10:39 | |
*** itlinux has quit IRC | 10:41 | |
*** rmart04 has quit IRC | 10:42 | |
*** yangyapeng has quit IRC | 10:44 | |
*** Tom-Tom has joined #openstack-nova | 10:45 | |
*** yangyapeng has joined #openstack-nova | 10:49 | |
*** Tom-Tom has quit IRC | 10:49 | |
*** zhurong has joined #openstack-nova | 10:51 | |
*** yangyapeng has quit IRC | 10:53 | |
*** sdague has joined #openstack-nova | 10:54 | |
*** ratailor has quit IRC | 10:58 | |
*** lpetrut has joined #openstack-nova | 11:00 | |
*** sidx64 has joined #openstack-nova | 11:02 | |
openstackgerrit | Matthew Booth proposed openstack/nova master: Pass DriverBlockDevice to driver.attach_volume https://review.openstack.org/528363 | 11:02 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Use real block_device_info data in libvirt tests https://review.openstack.org/527916 | 11:02 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Fix libvirt volume tests passing invalid disk_info https://review.openstack.org/529328 | 11:02 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Pass disk_info dict to libvirt_info https://review.openstack.org/529329 | 11:02 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Expose volume host type and path independent of libvirt config https://review.openstack.org/530786 | 11:02 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Don't generate fake disk_info in swap_volume https://review.openstack.org/530787 | 11:02 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Local disk serial numbers for the libvirt driver https://review.openstack.org/529380 | 11:02 |
*** abhishekk has quit IRC | 11:02 | |
*** lpetrut has quit IRC | 11:03 | |
*** ratailor has joined #openstack-nova | 11:05 | |
*** andreas_s has quit IRC | 11:07 | |
*** andreas_s has joined #openstack-nova | 11:08 | |
*** andreas_s has quit IRC | 11:12 | |
*** kwathore_ has quit IRC | 11:13 | |
*** vivsoni has quit IRC | 11:13 | |
*** kwathore has joined #openstack-nova | 11:14 | |
*** vivsoni has joined #openstack-nova | 11:14 | |
*** yangyapeng has joined #openstack-nova | 11:17 | |
*** andreas_s has joined #openstack-nova | 11:17 | |
*** markvoelker has joined #openstack-nova | 11:19 | |
*** chyka has joined #openstack-nova | 11:20 | |
*** chyka has quit IRC | 11:21 | |
openstackgerrit | Jiri Suchomel proposed openstack/nova master: Do not multiply megabytes with 1024 to get gigabytes. https://review.openstack.org/536335 | 11:21 |
*** annp has quit IRC | 11:22 | |
*** links has quit IRC | 11:23 | |
*** gaurangt has quit IRC | 11:24 | |
*** gaurangt has joined #openstack-nova | 11:25 | |
*** alexchadin has quit IRC | 11:28 | |
openstackgerrit | int32bit proposed openstack/nova master: Rollback original image info if server fail to rebuild https://review.openstack.org/536268 | 11:29 |
*** gongysh has quit IRC | 11:30 | |
*** andreas_s has quit IRC | 11:32 | |
*** AlexeyAbashkin has quit IRC | 11:32 | |
*** andreas_s has joined #openstack-nova | 11:33 | |
*** openstackgerrit has quit IRC | 11:33 | |
*** alexchadin has joined #openstack-nova | 11:33 | |
*** links has joined #openstack-nova | 11:35 | |
*** yangyapeng has quit IRC | 11:37 | |
*** yangyapeng has joined #openstack-nova | 11:37 | |
*** sidx64 has quit IRC | 11:39 | |
*** AlexeyAbashkin has joined #openstack-nova | 11:41 | |
*** andreas_s has quit IRC | 11:42 | |
*** sidx64 has joined #openstack-nova | 11:43 | |
*** janki has quit IRC | 11:43 | |
*** andreas_s has joined #openstack-nova | 11:47 | |
*** sree has joined #openstack-nova | 11:49 | |
*** andreas_s has quit IRC | 11:49 | |
*** andreas_s has joined #openstack-nova | 11:50 | |
*** psachin has quit IRC | 11:53 | |
*** sree has quit IRC | 11:53 | |
*** markvoelker has quit IRC | 11:54 | |
*** tesseract-RH has joined #openstack-nova | 11:55 | |
*** chyka has joined #openstack-nova | 11:57 | |
*** tesseract has quit IRC | 11:57 | |
*** openstackgerrit has joined #openstack-nova | 11:59 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Format NIC features using os-traits definitions https://review.openstack.org/466051 | 11:59 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add support for Windows network commands https://review.openstack.org/487405 | 12:00 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | 12:01 |
*** chyka has quit IRC | 12:02 | |
*** sidx64 has quit IRC | 12:07 | |
openstackgerrit | Radoslav Gerganov proposed openstack/nova master: WIP: VMware: implement update_provider_tree() https://review.openstack.org/536348 | 12:08 |
*** sidx64 has joined #openstack-nova | 12:08 | |
*** janki has joined #openstack-nova | 12:10 | |
*** dave-mccowan has joined #openstack-nova | 12:13 | |
*** cdent has joined #openstack-nova | 12:17 | |
*** bhujay has quit IRC | 12:18 | |
*** bhujay has joined #openstack-nova | 12:18 | |
*** krtaylor has joined #openstack-nova | 12:19 | |
*** dave-mcc_ has joined #openstack-nova | 12:21 | |
*** dave-mccowan has quit IRC | 12:22 | |
*** sidx64 has quit IRC | 12:23 | |
*** claudiub has joined #openstack-nova | 12:25 | |
*** yikun_ has joined #openstack-nova | 12:28 | |
Spazmotic | Poor Xenapi code~ | 12:28 |
*** ttsiouts has joined #openstack-nova | 12:29 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM: Test LM with encrypted volumes https://review.openstack.org/536350 | 12:32 |
*** sidx64 has joined #openstack-nova | 12:33 | |
openstackgerrit | int32bit proposed openstack/nova master: Refix disk size during live migration with disk over-commit https://review.openstack.org/536351 | 12:33 |
*** sidx64 has quit IRC | 12:33 | |
*** jpena is now known as jpena|lunch | 12:33 | |
*** smatzek has joined #openstack-nova | 12:33 | |
*** sidx64 has joined #openstack-nova | 12:34 | |
*** alexchadin has quit IRC | 12:35 | |
*** bhujay has quit IRC | 12:39 | |
*** phuongnh has quit IRC | 12:39 | |
*** dikonoor has quit IRC | 12:39 | |
*** phuongnh has joined #openstack-nova | 12:40 | |
*** alexchadin has joined #openstack-nova | 12:42 | |
*** smatzek has left #openstack-nova | 12:44 | |
*** phuongnh has quit IRC | 12:49 | |
*** markvoelker has joined #openstack-nova | 12:51 | |
*** sidx64 has quit IRC | 12:52 | |
*** ratailor has quit IRC | 12:53 | |
openstackgerrit | Lajos Katona proposed openstack/nova master: WIP: Add nested resources to server moving tests https://review.openstack.org/527728 | 12:56 |
*** yamamoto has quit IRC | 12:59 | |
openstackgerrit | Matthew Booth proposed openstack/nova master: Automatically revert resize which fails on destination https://review.openstack.org/462521 | 13:01 |
*** dikonoor has joined #openstack-nova | 13:02 | |
*** markvoelker has quit IRC | 13:02 | |
*** markvoelker has joined #openstack-nova | 13:02 | |
lyarwood | mdbooth: https://review.openstack.org/#/c/523958/ - Anything left to get your +1 on that? | 13:06 |
lyarwood | mdbooth: FWIW https://review.openstack.org/#/c/536350/ is testing this at the moment, I'll add a note if/when I respin the original. | 13:07 |
mdbooth | Nope. Do you think you'll address the diff comment if you respin? | 13:07 |
lyarwood | mdbooth: ah yeah, I can look at that now | 13:08 |
mdbooth | lyarwood: You can have my +1 without it, though. | 13:08 |
*** tiendc has quit IRC | 13:08 | |
lyarwood | mdbooth: if you could for now, just writing up a ML post to get additional reviewers before FF | 13:08 |
mdbooth | lyarwood: kk | 13:12 |
*** moshele has joined #openstack-nova | 13:13 | |
*** chyka has joined #openstack-nova | 13:15 | |
*** crushil_ has joined #openstack-nova | 13:15 | |
*** artom has joined #openstack-nova | 13:17 | |
openstackgerrit | Jiri Suchomel proposed openstack/nova master: Do not multiply megabytes with 1024 to get gigabytes. https://review.openstack.org/536335 | 13:17 |
*** yamamoto has joined #openstack-nova | 13:19 | |
*** chyka has quit IRC | 13:19 | |
*** Tom-Tom has joined #openstack-nova | 13:21 | |
alex_xu | cdent: thanks for https://review.openstack.org/#/c/535642/2/nova/tests/functional/api/openstack/placement/gabbits/allocation-candidates.yaml@227 | 13:21 |
cdent | alex_xu: does it do the right thing? | 13:22 |
alex_xu | cdent: working on it now | 13:22 |
*** jpena|lunch is now known as jpena | 13:26 | |
*** gongysh has joined #openstack-nova | 13:27 | |
*** zhurong has quit IRC | 13:28 | |
efried | Greetings all | 13:29 |
efried | cdent Welcome back. | 13:29 |
cdent | hold efried | 13:31 |
cdent | hola! | 13:31 |
efried | That too | 13:31 |
*** Eran_Kuris has quit IRC | 13:31 | |
*** fanzhang has quit IRC | 13:31 | |
cdent | expect me to leave again, because I left my house, therefore any moment now will be ill | 13:31 |
*** fanzhang has joined #openstack-nova | 13:32 | |
*** andreas_s has quit IRC | 13:35 | |
alex_xu | cdent: I guess that required to sort the response 'GET /allocation_candidates' API also, since that API response is unorder also | 13:35 |
cdent | efried: is there a pending implementation of the in virt driver side of update provider tree somewhere? | 13:35 |
*** andreas_s has joined #openstack-nova | 13:35 | |
efried | cdent Xen and VMWare are both working on that. | 13:36 |
cdent | alex_xu: no, the idea is that whatever the order of the output, you can sort it in gabbi to alpha, and then compare with an alpha expected result | 13:36 |
alex_xu | cdent: ah, I got it | 13:36 |
cdent | efried: yeah, was looking at the VMware one this morning (with the author) and was hoping for something with more flesh on the bones | 13:36 |
*** Drankis has joined #openstack-nova | 13:36 | |
sean-k-mooney | alex_xu: qq do you know if ironic is tagging resouce providers for ironic nodes with traits? just want to chenc if your traits work will only be consumable with nova vm based driver in queeens or if you can use traits with ironic in queens also. | 13:37 |
cdent | efried: because rado had some questions about the use of the 'generation' parameter in update_inventory | 13:37 |
efried | cdent Oh, I haven't seen the vmware one yet, though I chatted with rgerganov about it last week. Link please? | 13:37 |
efried | ah, okay. | 13:37 |
efried | Let me find the xen series, though I'm not sure it has any more "flesh"... | 13:37 |
cdent | efried: https://review.openstack.org/#/c/536348/ | 13:38 |
efried | sean-k-mooney Yes, there's a series for that. | 13:38 |
cdent | efried: see especially the commens at https://review.openstack.org/#/c/536348/1/nova/virt/vmwareapi/driver.py | 13:38 |
efried | sean-k-mooney They're implementing a get_traits() driver method, which is going to be a kind of bastardized bridge between get_inventory and update_provider_tree, hopefully short-lived. | 13:38 |
sean-k-mooney | efried: oh ok cool. thats what i was hoping to hear. so provided the ironic discoverd or the admin applys traits to the resouce providers then it should work | 13:38 |
*** gcb has joined #openstack-nova | 13:39 | |
efried | sean-k-mooney I believe that's the theory. They're staying pretty close to the blueprint from what I've seen so far. | 13:39 |
alex_xu | sean-k-mooney: yea, efried already answer that | 13:39 |
sean-k-mooney | efried: ah ok so it will be ironic backend driver dependent then. | 13:39 |
efried | sean-k-mooney Let me find the series so you can go after the authors for specifics... | 13:40 |
sean-k-mooney | alex_xu: yep sound like ye have that covered :) | 13:40 |
alex_xu | yea, my traits works just generic thing, needs each driver to report traits | 13:40 |
sean-k-mooney | efried: its on i can follow up myself dont put yourself out if you dont have it to had. | 13:40 |
alex_xu | cdent: it works \o/ | 13:40 |
cdent | alex_xu: yay! | 13:41 |
*** liverpooler has joined #openstack-nova | 13:41 | |
efried | cdent Series is a bit wobbly at this point, but kinda starts here: https://review.openstack.org/#/c/520313/ | 13:42 |
rgerganov | efried, the doc string of provider_tree.update_inventory says that it will update the generation or the RP which I find strange | 13:42 |
efried | cdent (That's the xen one) | 13:42 |
cdent | thanks efried | 13:42 |
efried | rgerganov The *placement* side will update the generation, yes. | 13:42 |
efried | cdent Here's where they actually implement update_provider_tree, which just calls the helpers in the other couple of patches in the "series": https://review.openstack.org/#/c/521041/4/nova/virt/xenapi/driver.py | 13:43 |
efried | rgerganov There has been some confusion (not least on my part) about how the generation works. | 13:43 |
*** andreas_s has quit IRC | 13:43 | |
*** andreas_s has joined #openstack-nova | 13:44 | |
cdent | efried: in this case the question is why is update_inventory accepting a generation param? | 13:44 |
efried | sean-k-mooney Here's mgoddard's series on ironic traits: https://review.openstack.org/#/c/508116/ | 13:44 |
*** Eran_Kuris has joined #openstack-nova | 13:44 | |
efried | cdent We have to send the generation as we know it back to the placement API so it can detect concurrent updates. | 13:44 |
cdent | efried: yes, but doesn't the tree already know it? | 13:45 |
efried | cdent rgerganov I do a GET, and receive inventory at generation 1. Joe-Bob's server over there does a GET and receives the same inventory, generation 1. Now Joe-Bob does a PUT with a new version of the inventory, which is now at generation 2. When I do my PUT, my payload would blow away Joe-Bob's. | 13:46 |
* alex_xu happy with dublin warm than beijing | 13:46 | |
*** edmondsw_ has joined #openstack-nova | 13:46 | |
efried | So the solution: I send "generation 1" when I do my PUT, and placement says, "whoah, I'm at generation 2, 409". | 13:46 |
efried | So I have to re-GET so I can make sure my updates to the inventory are still valid in the context of Joe-Bob's. | 13:47 |
efried | Can you dig it, dogg? | 13:47 |
*** itlinux has joined #openstack-nova | 13:47 | |
openstackgerrit | Alex Xu proposed openstack/nova master: placement: support traits in allocation candidates API https://review.openstack.org/535642 | 13:47 |
openstackgerrit | Alex Xu proposed openstack/nova master: placement: using the dict format for the allocations https://review.openstack.org/536083 | 13:47 |
openstackgerrit | Alex Xu proposed openstack/nova master: placement: enable required traits from the flavor extra specs https://review.openstack.org/536085 | 13:47 |
cdent | efried: so here https://review.openstack.org/#/c/536348/1/nova/virt/vmwareapi/driver.py the expectatin is that gen = provider_tree.generation ? | 13:48 |
alex_xu | gibi: cdent yikun_ ^ updated | 13:48 |
cdent | thanks alex_xu will look soon | 13:48 |
alex_xu | cdent: thanks | 13:48 |
efried | ohh, cdent sorry, I was thinking of report client's update_inventory_for_provider_or_whatever_it's_called. | 13:49 |
efried | cdent Why does ProviderTree.update_inventory take a generation. | 13:49 |
efried | One sec. | 13:49 |
efried | cdent rgerganov It's so report client can keep its internal cache up to date. | 13:50 |
efried | cdent rgerganov I agree it shouldn't be required - for any of the ProviderTree update_* methods - because update_provider_tree shouldn't use it, because update_provider_tree shouldn't be talking directly to placement. | 13:50 |
efried | edleafe You've got the sched meeting today, yes? | 13:51 |
bauzas | jianghuaw: hola | 13:51 |
bauzas | jianghuaw: I'm hardly testing my vGPU changes for libvirt | 13:51 |
bauzas | jianghuaw: I saw some problems due to libvirt | 13:51 |
bauzas | jianghuaw: have you also tested for example suspending your instances ? | 13:52 |
*** pchavva has joined #openstack-nova | 13:52 | |
sean-k-mooney | efried: thanks :) it will make my pm happy to know that this is well in hand. it was on our potential gaps list for a while. | 13:52 |
*** esberglu has joined #openstack-nova | 13:55 | |
*** edmondsw_ is now known as edmondsw | 13:56 | |
*** yangyapeng has quit IRC | 13:58 | |
*** ttallgren has quit IRC | 13:58 | |
edleafe | efried: yes, scheduler meeting in 2 minutes in #openstack-nova-alt | 13:58 |
efried | Or #openstack-meeting-alt | 13:58 |
efried | Mondays | 13:58 |
* efried rolls eyes | 13:58 | |
edleafe | and lack of caffeine :( | 13:59 |
bauzas | nova alternative ? | 13:59 |
bauzas | man | 13:59 |
* bauzas looks at Intel ;) | 13:59 | |
edleafe | too early to have to think clearly | 13:59 |
bauzas | just rename nova-alt to ciao | 14:00 |
bauzas | shorter FTW | 14:00 |
jroll | hey nova friends, the ironic rolling upgrade testing is down. while we try to track down why nova-conductor segfaults after upgrading ironic (without restarting n-cond), this patch will help us work around it by allowing nova queens to work with ironic pike (which is a good thing for users anyway). reviews would be super helpful, thank you :) https://review.openstack.org/#/c/535786/ | 14:00 |
*** weshay is now known as weshay|rover | 14:00 | |
sean-k-mooney | bauzas: :) but its in go so obvioulsy better even though it has no epa/numa or any other kind of plathform awerness | 14:01 |
bauzas | shhhhhhtttttttttt | 14:01 |
edleafe | Scheduler subteam meeting running now in #openstack-meeting-alt | 14:02 |
sean-k-mooney | bauzas: by the way if its not clear i am not a ciao fan | 14:03 |
bauzas | sean-k-mooney: that's fine | 14:03 |
bauzas | sean-k-mooney: just say now you're a Kata fan :p | 14:04 |
bauzas | be corp, man | 14:04 |
sean-k-mooney | bauzas: haha well kata is a merger of clear containers and hyper right. its more of a libvirt alternitve then nova as far as i understand | 14:04 |
bauzas | that's at least a big question I have in mind | 14:05 |
bauzas | and I saw noone talking about that | 14:05 |
bauzas | I should learn Go, if I'm not foolish | 14:05 |
sean-k-mooney | reading go is not that hard, reversing the type/name order of things when writing it will drive me nuts for at least 6 months if i ever try to write it | 14:06 |
*** sree has joined #openstack-nova | 14:06 | |
edmondsw | gibi finucannot think you'll be able to get to the PowerVM SEA networking patch? should be easy after the OVS one | 14:07 |
edmondsw | https://review.openstack.org/#/c/523216/ | 14:07 |
finucannot | edmondsw: Sure will. Got four series on my backlog but I'm working through an emulator threads bug today. Will probably be tomorrow, I'd say | 14:08 |
*** lyan has joined #openstack-nova | 14:08 | |
*** finucannot is now known as stephenfin | 14:08 | |
edmondsw | finucannot thanks! | 14:08 |
*** itlinux has quit IRC | 14:09 | |
openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: SEA https://review.openstack.org/523216 | 14:09 |
edmondsw | ^ is just a rebase | 14:11 |
*** yamamoto has quit IRC | 14:17 | |
*** tbachman has joined #openstack-nova | 14:18 | |
*** yamamoto has joined #openstack-nova | 14:18 | |
*** dillaman has quit IRC | 14:20 | |
lyarwood | stephenfin: https://review.openstack.org/#/c/523958/ - Do you have time to go over this today? :) | 14:22 |
openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver https://review.openstack.org/526094 | 14:23 |
stephenfin | lyarwood: Depends on how big it is. See above :) (tl;dr: /me side-tracked by a bug today) | 14:23 |
*** yamamoto has quit IRC | 14:23 | |
*** alexchadin has quit IRC | 14:25 | |
lyarwood | stephenfin: kk, pretty big but tomorrow (morning?) would be fine if that's possible | 14:25 |
stephenfin | lyarwood: It's top of my list | 14:26 |
stephenfin | Sorry edmondsw :) You're next in line | 14:26 |
*** eharney has joined #openstack-nova | 14:26 | |
edmondsw | stephenfin sure :) | 14:26 |
*** mriedem has joined #openstack-nova | 14:27 | |
*** bhujay has joined #openstack-nova | 14:27 | |
*** zhurong has joined #openstack-nova | 14:28 | |
*** Guest86649 is now known as dansmith | 14:29 | |
*** tssurya has quit IRC | 14:29 | |
sean-k-mooney | stephenfin: i was talking to rodoflo eairlier regarding https://review.openstack.org/#/c/449257/ he needs to move on to yardstick work which means he wont be able to work on this before the code freeze | 14:29 |
sean-k-mooney | stephenfin: im going to try an pick it up | 14:29 |
sean-k-mooney | stephenfin: you had some changes you wanted regarding the spec dict/object can i ping you later once i have it setup locally to confirm what needs to be done | 14:30 |
stephenfin | sean-k-mooney: Sure can. I _think_ they make sense but I'll leave that to you to decide :) | 14:30 |
sean-k-mooney | stephenfin: this barly missed pike then we made a lot of change in queens so dont want it to slip to rocky if it can be avoided | 14:31 |
stephenfin | Agreed. I'd like to get that in, if at all possible | 14:31 |
*** yangyapeng has joined #openstack-nova | 14:32 | |
sean-k-mooney | stephenfin: cool am i need to get dan smit to look at that too as he previous gave feedback re using objects | 14:32 |
stephenfin | sean-k-mooney: Yup, about versioning. I think the tl;dr: of it was that you can't really remove a field, even if it's unused, and type changes have to have backwards compatibility wrappers provided | 14:33 |
ameeda | jaypipes: are you around ? | 14:33 |
*** lucasagomes is now known as lucas-hungry | 14:34 | |
sean-k-mooney | stephenfin: yes he suggested synatsizing the new field form the old using a lazy loader if it was not set. i think rodlofo has that done i just want to make sure he is ok with the filed change you asked for too as i think that field existed before the patch so we cant just convert it to an object. | 14:35 |
*** jackie-truong has joined #openstack-nova | 14:35 | |
sean-k-mooney | stephenfin: i need to read the patch again since its been a few weeks since i did so i may be mis remembering | 14:36 |
*** yikun_ has quit IRC | 14:39 | |
*** trozet has quit IRC | 14:39 | |
*** takashin_ has left #openstack-nova | 14:40 | |
*** takashin has joined #openstack-nova | 14:40 | |
* edleafe goes to brew more coffee | 14:40 | |
gibi | alex_xu: thanks for the update. I'm +2 on the bottom patch. I will review further in that chain soon | 14:43 |
efried | ameeda I believe Jay is trying to find a spot to work from at the moment. | 14:43 |
*** tssurya has joined #openstack-nova | 14:43 | |
gibi | edmondsw: the SEA patch is on my list | 14:44 |
edmondsw | gibi great, tx | 14:44 |
ameeda | efried: hehe, so can you help me ? | 14:44 |
efried | ameeda Gosh, that depends. What's going on? | 14:45 |
mriedem | stephenfin: were you working on a nit fixes patch for the websocket proxy security series? | 14:45 |
ameeda | efried: can you please check this "https://review.openstack.org/#/c/526900/" and notice the scenario from the bug side ? | 14:45 |
stephenfin | mriedem: Yup, it merged. Lemme know if there's stuff I missed https://review.openstack.org/#/c/534368/ | 14:46 |
*** trozet has joined #openstack-nova | 14:46 | |
mriedem | stephenfin: ah ok - was just wondering if you wanted to update that docs patch for my one comment or do it in a follow up? | 14:46 |
efried | ameeda Oh, this patch. Yeah, I looked it over a bit last week and accepted that it's not really in my wheelhouse, sorry. | 14:47 |
stephenfin | mriedem: If it's just that, I can edit on Gerrit | 14:47 |
stephenfin | mriedem: reply left, in any case | 14:47 |
mriedem | stephenfin: just edit inline and i'll +W | 14:48 |
bauzas | mriedem: welcome back | 14:48 |
mriedem | thanks | 14:48 |
bauzas | mriedem: for your pleasure, we have https://bugs.launchpad.net/nova/+bug/1744325 | 14:48 |
openstack | Launchpad bug 1744325 in OpenStack Compute (nova) "If a rebuild is refused by the scheduler, the instance's imageref is not rolled back" [Critical,In progress] - Assigned to int32bit (int32bit) | 14:48 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Document TLS security setup for noVNC proxy https://review.openstack.org/500544 | 14:48 |
*** yamamoto has joined #openstack-nova | 14:49 | |
stephenfin | mriedem: Done (y) | 14:49 |
mriedem | bauzas: tagged for rc potential but not going to look at it for awhile | 14:49 |
bauzas | mriedem: I'm following the change | 14:49 |
bauzas | I'll see how it goes, and try to help next week if we haven't reached to a clear solution | 14:50 |
ameeda | efried: thank you ! | 14:51 |
mriedem | it's not fun but i wouldn't say it's the worst bug i've ever seen, | 14:51 |
mriedem | considering until queens, if you tried rebuilding a volume-backed server, we'd always fail to do so and still change the imageref on the instance | 14:51 |
*** jaypipes has joined #openstack-nova | 14:52 | |
bauzas | mriedem: hmmm, you're right | 14:54 |
*** yamamoto has quit IRC | 14:54 | |
*** gongysh has quit IRC | 14:54 | |
*** jaypipes has quit IRC | 14:55 | |
*** moshele has quit IRC | 14:59 | |
*** takashin has left #openstack-nova | 15:00 | |
cdent | edleafe, efried: would be good to get this stack merged before we start merging all the big stuff so that it is useful in the inevitable debugging we will need to do: https://review.openstack.org/#/c/526557/ | 15:02 |
edleafe | cdent: ack | 15:04 |
*** awaugama has joined #openstack-nova | 15:04 | |
*** archit has joined #openstack-nova | 15:04 | |
Roamer` | mriedem, welcome back! What are the chances of the StorPool volume attachment driver? I know it's close to the deadline, but you said if we got our ducks in a row... and the last duck, 533046, has been merged for a week | 15:05 |
*** namnh has joined #openstack-nova | 15:05 | |
*** jaypipes has joined #openstack-nova | 15:05 | |
Roamer` | and right now we're in a weird position where the main use case for our Cinder and os-brick drivers is not in OpenStack proper :) | 15:05 |
mriedem | bauzas: comments inline in https://review.openstack.org/#/c/536268/ | 15:06 |
bauzas | mriedem: k, will look | 15:06 |
mriedem | bauzas: it's breaking evacuate potentially, and it's also missing rolling back a bunch of other properties, so it's probably not worth trying to rollback any properties since we'd be totally half assing it | 15:06 |
*** armax has joined #openstack-nova | 15:06 | |
mriedem | might as well just put the instance into ERROR state and make the user rebuild with a valid image to fix things | 15:06 |
Roamer` | mriedem, sorry, of course I'm talking about https://review.openstack.org/#/c/140733/ (certainly this is not the only thing on your plate...) | 15:06 |
mriedem | Roamer`: i'll take a look | 15:07 |
bauzas | mriedem: oh, excellent catch | 15:07 |
mriedem | still trying to get my bearings | 15:07 |
*** Tom-Tom has quit IRC | 15:07 | |
Roamer` | mriedem, of course, thanks a lot! | 15:07 |
mriedem | bauzas: can you re-approve https://review.openstack.org/#/c/528128/ ? | 15:07 |
*** Tom-Tom has joined #openstack-nova | 15:08 | |
mriedem | so we can get the series of novaclient microversion changes flushed for a final release | 15:08 |
bauzas | mriedem: I'm half-reviewing, half-testing my own series, so apologies for not fully getting all the context in mind | 15:08 |
mriedem | bauzas: np | 15:08 |
bauzas | mriedem: oh, the novaclient change is just a rebase ? +wd | 15:08 |
mriedem | yeah | 15:09 |
mriedem | thanks | 15:09 |
*** r-daneel has joined #openstack-nova | 15:09 | |
bauzas | mriedem: I tried to look at the multiattach thing while you were on vacations | 15:09 |
bauzas | mriedem: that's an excellent job you made honestly | 15:09 |
bauzas | we're still missing the API bits, but I understand now the logic | 15:10 |
bauzas | I like the fact to short-cut the multiattach if we don't support that by the compute | 15:10 |
*** crushil_ has quit IRC | 15:11 | |
*** Tom-Tom has quit IRC | 15:12 | |
mriedem | bauzas: i saw thanks for reviewing those, | 15:12 |
mriedem | the short circuit was copied from artom's tagged attach stuff | 15:12 |
*** bhujay has quit IRC | 15:13 | |
*** Eran_Kuris has quit IRC | 15:14 | |
efried | cdent I'm still pretty confused what you're getting at here https://review.openstack.org/#/c/532290/ | 15:14 |
bauzas | mriedem: btw. I have a question for you | 15:14 |
bauzas | mriedem: I'm hardly-testing my vGPU changes on a dedicated box | 15:15 |
bauzas | mriedem: and I'm testing all the instance operations | 15:15 |
bauzas | mriedem: for providing a good release note about what can be supported and what not | 15:15 |
*** stelucz_ has joined #openstack-nova | 15:15 | |
*** mlavalle has joined #openstack-nova | 15:15 | |
openstackgerrit | Matthew Booth proposed openstack/nova master: Local disk serial numbers for the libvirt driver https://review.openstack.org/529380 | 15:15 |
efried | cdent If ironic gets its traits and they're not different from what's in the cache, we won't make the API call. Which is as it should be. Am I missing something? | 15:15 |
*** yamamoto has joined #openstack-nova | 15:15 | |
bauzas | mriedem: so, the point is, when I tried to suspend an instance, libvirt popped up an exception | 15:15 |
*** yamamoto has quit IRC | 15:15 | |
cdent | efried: I'm asking for the authors of the patch to acknowledge that they are aware of the quoted lines of provider tree code. This is because elsewhere in the stack there's been discussion of "this doesn't work with provider tree yet" | 15:15 |
bauzas | mriedem: basically because we don't accept to hot-unplug mediated devices | 15:16 |
cdent | It could be all that is needed is "yeah, we know, it's fine" | 15:16 |
bauzas | mriedem: now, the question is, would you be OK if I would just transform that libvirt exception in a more-readable exception like "sorry, but you can't suspend your instance because $vGPUs" | 15:16 |
*** stelucz_ is now known as stelucz | 15:17 | |
bauzas | and leave the instance into ERROR | 15:17 |
bauzas | of course, the user can reset the state or rebuild | 15:17 |
*** larsks has left #openstack-nova | 15:17 | |
mriedem | bauzas: i don't think the instance should be in ERROR state in that case, | 15:17 |
mriedem | since we didn't change the guest | 15:17 |
mriedem | you'd get a fault recorded as to why the suspend failed | 15:17 |
mriedem | which is probably good enough | 15:18 |
bauzas | set it back to ACTIVE | 15:18 |
bauzas | then | 15:18 |
bauzas | mmm, good call | 15:18 |
*** sree_ has joined #openstack-nova | 15:18 | |
mriedem | yeah i guess you'd revert to the original vm_state, which right now can only be active in the API | 15:18 |
*** sree_ is now known as Guest8761 | 15:18 | |
mriedem | johnthetubaguy: replied to your question in the multiattach api change https://review.openstack.org/#/c/271047/ - i think we're covered for the attach flow, but in a different way | 15:19 |
*** armax has quit IRC | 15:20 | |
johnthetubaguy | mriedem: ah... got it | 15:20 |
*** edand has quit IRC | 15:21 | |
*** armax has joined #openstack-nova | 15:21 | |
*** hongbin has joined #openstack-nova | 15:22 | |
*** sree has quit IRC | 15:22 | |
cdent | efried: so, based on your response are you aserting "don't worry, the provider tree will always be right because we've merged enough code for that to be true". If so, cool, but that wasn't clear from earlier discussion on the patches. | 15:22 |
*** lucas-hungry is now known as lucasagomes | 15:23 | |
efried | cdent I'll grant you we still have work to do on concurrency management, though we've asserted that that's only a theoretical problem at the moment due to The Big Semaphore and the single-source-of-control-ness for compute node RPs at the moment. | 15:24 |
mgoddard_ | cdent, efried: I think a simple answer here is that the resource tracker will always have called set_inventory_for_provider prior to calling set_traits_for_provider, and this ensures that the RPs are present | 15:24 |
efried | mgoddard_ cdent Ohhh, are we worried about having populated the cache with the relevant provider at this point? I didn't pick up on that at all. | 15:25 |
cdent | efried: yes, my query has been, all along: is the provider tree active for this code path? | 15:25 |
efried | cdent That's definitely a legitimate concern, because as documented on set_traits_for_provider (https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1042) we don't attempt to create the provider. But furthermore, we don't do _ensure_provider either, so there had better have been something prior that populated the cache for that guy. | 15:26 |
efried | cdent I'm sure I'm just being obtuse, but I didn't understand that from your comments at all :( | 15:27 |
mgoddard_ | efried: yes, it's set_inventory_for_provider | 15:27 |
efried | mgoddard_ That's good; and I think it's worth adding a code comment to that effect to affirm that it's been considered. Good call cdent | 15:28 |
cdent | mgoddard_: how/where does set_inventory_for_provider get involved in the management of the ProviderTree? | 15:29 |
efried | cdent It calls _ensure_resource_provider first thing. | 15:29 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add the nova-multiattach job https://review.openstack.org/532689 | 15:29 |
efried | cdent Which creates the provider if it doesn't exist, but in any case populates/refreshes the cache | 15:30 |
cdent | okay, that's the missing piece of the pie, thank you. | 15:31 |
mgoddard_ | efried: good call, I'll add a comment | 15:31 |
efried | cdent The other code path, update_compute_node, does the same (_ensure_resource_provider) | 15:31 |
cdent | I just wanted to be sure, because of what people had said earlier about the potential for confusion | 15:31 |
*** trinaths has joined #openstack-nova | 15:32 | |
cdent | those comments about potential for confusion had made it seem like there was a chance that the provider tree could either be wrong or even not exist | 15:32 |
cdent | but since it is established by _ensure_* is cool | 15:32 |
efried | cdent I doubt it's perfect | 15:32 |
cdent | and how does that make you feel? | 15:33 |
efried | cdent Dirty. So dirty. | 15:34 |
cdent | woot | 15:34 |
efried | cdent For one thing, as noted above, I've convinced myself that concurrency isn't an issue YET. | 15:35 |
efried | cdent And we're also working on the theory of merge big stuff early so we can shake out the bugs. | 15:35 |
efried | cdent Not that I think it's a great policy to count on shaking out bugs later rather than avoiding them by careful inspection beforehand... | 15:35 |
efried | cdent But we also can't get into analysis paralysis. Gotta walk the line. | 15:36 |
cdent | i like merge big stuff early | 15:36 |
cdent | as long as we actually exercise | 15:36 |
edleafe | "early" != "days before feature freeze" | 15:36 |
johnthetubaguy | mriedem: gibi: apologies, lots of things been getting in my way, but I am +2 on the multi-attach now, went back though the merged chain, I don't feel qualified for +W for some reason, but gibi you might be happy with that? | 15:37 |
efried | Well, unless feature freeze is deliberately early in the cycle, to allow time to exercise. | 15:37 |
*** zhaochao has quit IRC | 15:37 | |
*** namnh has quit IRC | 15:38 | |
mriedem | johnthetubaguy: thanks; just cleaning up the patch that adds the CI job so it's run in the check/gate queue | 15:38 |
*** namnh has joined #openstack-nova | 15:39 | |
*** namnh has quit IRC | 15:39 | |
johnthetubaguy | mriedem: ah, cool, I did see the -1 on there | 15:39 |
mriedem | i think zuul got lost in the long chain of deps | 15:39 |
mriedem | rechecking it | 15:39 |
johnthetubaguy | cool | 15:39 |
*** namnh has joined #openstack-nova | 15:39 | |
*** namnh has quit IRC | 15:39 | |
*** namnh has joined #openstack-nova | 15:40 | |
*** namnh has quit IRC | 15:40 | |
mriedem | johnthetubaguy: sdague: we'll need this bug fix to get the multiattach job in - relies on not using pike UCA https://review.openstack.org/#/c/532214/ | 15:40 |
*** namnh has joined #openstack-nova | 15:40 | |
*** ameade has quit IRC | 15:40 | |
*** markmc has quit IRC | 15:40 | |
*** DuncanT has quit IRC | 15:40 | |
*** andrewbogott has quit IRC | 15:40 | |
*** catmando has quit IRC | 15:40 | |
*** BlackDex has quit IRC | 15:40 | |
*** Adri2000 has quit IRC | 15:40 | |
*** ekhugen_alt has quit IRC | 15:40 | |
mriedem | which means you can't snapshot a paused instance with older libvirt | 15:40 |
*** markmc has joined #openstack-nova | 15:40 | |
*** ekhugen_alt has joined #openstack-nova | 15:40 | |
*** Adri2000 has joined #openstack-nova | 15:40 | |
*** Adri2000 has quit IRC | 15:40 | |
*** Adri2000 has joined #openstack-nova | 15:40 | |
*** BlackDex has joined #openstack-nova | 15:40 | |
*** catmando has joined #openstack-nova | 15:41 | |
*** andrewbogott has joined #openstack-nova | 15:41 | |
*** andrewbogott has quit IRC | 15:41 | |
*** andrewbogott has joined #openstack-nova | 15:41 | |
*** ameade has joined #openstack-nova | 15:41 | |
*** DuncanT has joined #openstack-nova | 15:41 | |
gibi | johnthetubaguy: thanks for the review | 15:43 |
gibi | mriedem: is it OK for you that I +W the multiattach api patch as john is +2 on it or I should wait for new job to run? | 15:45 |
efried | rgerganov If you're willing to have https://review.openstack.org/#/c/536348/ rebased onto https://review.openstack.org/#/c/535517/ instead of https://review.openstack.org/#/c/531260/ I'll keep it up to date as I work on those WIPs. | 15:46 |
mriedem | gibi: should be fine to +W - the CI results have already passed for awhile now | 15:46 |
efried | rgerganov At the moment you're off on a side branch | 15:46 |
mriedem | i'm just changing the job config | 15:46 |
gibi | mriedem: OK, thanks | 15:46 |
*** yikun_jiang has quit IRC | 15:47 | |
efried | gibi Thanks for the reviews! Knocking 'em out today | 15:47 |
*** yikun has joined #openstack-nova | 15:48 | |
*** felipemonteiro_ has joined #openstack-nova | 15:49 | |
mriedem | edleafe: looks like https://review.openstack.org/#/c/526436/ needs a rebase? | 15:50 |
*** slaweq has quit IRC | 15:50 | |
*** tovin07 has joined #openstack-nova | 15:51 | |
jaypipes | cdent: I see you liked my country music song joke. | 15:51 |
cdent | quite | 15:51 |
jaypipes | there's been a plethora of jokes and movie references in reviews on efried's latest patch series. | 15:52 |
jaypipes | I've been having quite a bit of fun. | 15:52 |
*** yikun_jiang has joined #openstack-nova | 15:52 | |
*** yikun has quit IRC | 15:52 | |
edleafe | mriedem: working on it | 15:52 |
*** efried has left #openstack-nova | 15:52 | |
*** efried has joined #openstack-nova | 15:52 | |
edleafe | multiattach stepped on RPC versions | 15:52 |
mriedem | oh yeah | 15:53 |
mriedem | it was a race | 15:53 |
amorin | hello everybody | 15:53 |
*** david-lyle has joined #openstack-nova | 15:53 | |
*** tidwellr has joined #openstack-nova | 15:53 | |
jaypipes | amorin: mornin. | 15:54 |
*** julienc has joined #openstack-nova | 15:54 | |
amorin | I'd like to know if there is a reason of this if iso9660 line: | 15:54 |
*** felipemonteiro__ has joined #openstack-nova | 15:55 | |
amorin | https://github.com/openstack/nova/blob/stable/newton/nova/virt/libvirt/driver.py#L6602 | 15:55 |
amorin | I mean, other possibility is vfat afaik | 15:55 |
amorin | what if nova is transfering the config drive from remote if it is vfat? | 15:55 |
*** derekh has quit IRC | 15:56 | |
*** derekh has joined #openstack-nova | 15:56 | |
amorin | jaypipes: evenin :p | 15:56 |
amorin | (almost 5 pm here) | 15:56 |
tovin07 | mriedem, hi | 15:56 |
jaypipes | amorin: well, evening then :) | 15:57 |
amorin | :) | 15:58 |
*** felipemonteiro_ has quit IRC | 15:58 | |
efried | UGT | 15:59 |
jaypipes | amorin: as for your question... no idea. perhaps mdbooth or lyarwood might know the answer on that one. | 16:00 |
* mdbooth looks | 16:00 | |
amorin | jaypipes mdbooth thanks | 16:00 |
*** bhujay has joined #openstack-nova | 16:01 | |
mdbooth | amorin: What's the question? | 16:02 |
mdbooth | amorin: Ah, you're wondering why the handling difference between iso9660 and vfat? | 16:02 |
amorin | what if we copy the config-drive no matter its kind (vfat or iso) | 16:02 |
amorin | yup | 16:02 |
efried | cdent "For future reference, in the future this loop could be replaced with a single request to POST /allocations, clearing the allocations for all the consumers." <== This must have been a difficult comment to write. The war between "use lots of little API calls" and "use stuff I wrote!" :P | 16:03 |
amorin | I understand that libvirt is able to copy it if its vfat | 16:03 |
amorin | but it seems that if nova copy it first, | 16:03 |
mdbooth | It was (is? but I doubt it) a bug in libvirt/qemu in the handling of iso9660 disks | 16:03 |
amorin | then libvirt will do nothing | 16:03 |
efried | cdent Only joshing you of course. The POST is a great idea there. | 16:03 |
mdbooth | Did you look at the referenced lp bug? | 16:03 |
amorin | mdbooth: yes | 16:03 |
amorin | seems that libvirt is still failing with iso | 16:04 |
amorin | I was just wondering if copying vfat with nova is a bad idea or not | 16:04 |
sean-k-mooney | amorin: mdbooth i would guesss the bug in libvirt is related to iso beeing treated as cdroms and vfat ect disk being considered hdds or somthin in that vain? | 16:05 |
*** tssurya has quit IRC | 16:06 | |
sean-k-mooney | amorin: well one way to check would be remove that line and look at the livemigration gate jobs. it might result in both nova and neutron coping the config drive | 16:06 |
*** chyka has joined #openstack-nova | 16:06 | |
openstackgerrit | Mark Goddard proposed openstack/nova master: Send traits to ironic on server boot https://review.openstack.org/508116 | 16:06 |
openstackgerrit | Mark Goddard proposed openstack/nova master: Add get_traits() method to ComputeDriver https://review.openstack.org/532290 | 16:06 |
openstackgerrit | Mark Goddard proposed openstack/nova master: Implement get_traits() for the ironic virt driver https://review.openstack.org/532288 | 16:06 |
amorin | problem is, imagine you already spawn instances with iso kind, nova needs to copy it before (because of libvirt bug), but in the meantime, you updated the nova config, so CONF.config_drive = vfat | 16:06 |
amorin | then you never enter this if, and live-migration fail | 16:06 |
*** lpetrut has joined #openstack-nova | 16:07 | |
mdbooth | sean-k-mooney: Pretty sure it's something like that. Long time since I had this cached. | 16:07 |
mdbooth | amorin: So, the other thing that happened since then is that we explicitly specify which disks to migrate using migrateToURI3 | 16:07 |
amorin | sean-k-mooney: I did try to remove it in my lab, seems to work, I'll try to submit and patch and see the results in gate jobs | 16:07 |
amorin | mdbooth: ok, got it, migrateToURI3 is then able to migrate the vfat config-drive | 16:08 |
amorin | mdbooth: but are we sure that migrateToURI3 is able to handle the iso kind? | 16:10 |
amorin | i'll check | 16:10 |
mdbooth | IIRC it's because cd-rom drives are read-only, and qemu won't let us write to a read-only disk, even during live migration | 16:10 |
mdbooth | amorin: The pertinent point about migrateToURI3 is that we specify a list of disks to block migrate explicitly | 16:10 |
zzzeek | jaypipes: my connection monitoring thing currently lets you put ?plugin=connmon on the SQLAlchemy URL. But Nova Cells shoves DB urls into the database the first time it runs and then they never change :(. So need to add a config flag to oslo.db. But then Nova hardcodes all the oslo flags :) | 16:10 |
mdbooth | Whereas before it was all disks | 16:10 |
sean-k-mooney | amorin: is there a reason we migate configdirve instead of recreating on remote side our of interest. technically with vfat it can be readwrite but they are intended to be readonly | 16:11 |
*** chyka has quit IRC | 16:11 | |
sean-k-mooney | mdbooth: ^ | 16:11 |
mdbooth | amorin: So previously we didn't avoid the problematic disks, iirc | 16:11 |
mdbooth | sean-k-mooney: I believe we do recreate it now | 16:11 |
*** tidwellr has quit IRC | 16:12 | |
*** tidwellr_ has joined #openstack-nova | 16:12 | |
*** mvk has quit IRC | 16:13 | |
tovin07 | this patch passed all zuul gate (had 2+2, A+1). however, it's still open. https://review.openstack.org/#/c/519664/ | 16:14 |
jaypipes | zzzeek: that is indeed the suck :( | 16:14 |
zzzeek | jaypipes: this "nova puts the URLs into the DB | 16:14 |
zzzeek | " thing has been a really huge problem | 16:14 |
jaypipes | zzzeek: as opposed to, say, a config management system? :) | 16:14 |
zzzeek | it is far and away the worst design decision | 16:14 |
zzzeek | jaypipes: it means I cannot change the URL in the config file and have it take effect, *and* it means whatever is in the config file on one server is *implicitly shared* with all other nova servers on other machines | 16:15 |
jaypipes | zzzeek: well, I don't disagree it's a bad design but it's not something we can "fix" right away... | 16:15 |
zzzeek | jaypipes: we have all kind of workarounds. it's just v v inconvenient to constantly hit it | 16:15 |
jaypipes | zzzeek: is there a hack/workaround that will allow you to proceed with your ?plugin=XXX enhancements? | 16:16 |
*** yamamoto has joined #openstack-nova | 16:16 | |
zzzeek | jaypipes: yes I am going to add it to oslo.db so it's a separate config option outside of the URL | 16:16 |
jaypipes | zzzeek: again, I don't disagree with you at all | 16:16 |
zzzeek | jaypipes: which means when I document how to use connmon w/ nova, the answer will be "it depends :) " | 16:16 |
zzzeek | like older nova, OK there's no cells, put it in the URL. newer nova, OK we have the olso.db thing. middle-nova, erg, rewrite your cells URLs w/ the command line thing | 16:17 |
*** itlinux has joined #openstack-nova | 16:17 | |
jaypipes | zzzeek: another annoying this about oslo.cfg: you can't tell whether a CONF option has been set or not. i.e. has the CONF option value been set (via either argparse or configparser) to any value. | 16:17 |
sean-k-mooney | stephenfin: just looking at https://review.openstack.org/#/c/449257/52/nova/pci/request.py@93 the clean up you are asking for are not directly related to the patch rodlfo is doing so i should probably pull it out into another patch above or below rodolfos. is that ok? and do you have a prefernece? | 16:17 |
jaypipes | zzzeek: s/this/thing | 16:17 |
zzzeek | jaypipes: I might have observed the other day that putting something in [DEFAULT] doesn't actually "default" the value elsewhere? i struggled for days getting region_name / os_region_name setup to work | 16:18 |
jaypipes | zzzeek: yeah | 16:18 |
*** david-lyle has quit IRC | 16:19 | |
bauzas | does anyone know more than just by the name the "nova backup" command ? | 16:19 |
*** armax has quit IRC | 16:19 | |
zzzeek | jaypipes: and another thing! why is the keystone auth URL in nova.conf but then if my region is wrong it seems to ask keystone for the *other* URL then it starts using that one (and fails) ? | 16:19 |
bauzas | I guess the retention period is just for calculating whether we should delete an old image or not | 16:19 |
bauzas | but hopefully nova isn't periodically running a task to clean that up | 16:19 |
bauzas | (ie. that's a per-call retention calculation) | 16:20 |
stephenfin | sean-k-mooney: What cleanup is this now? | 16:20 |
*** Guest8761 has quit IRC | 16:20 | |
bauzas | I'm just amazed to discover such API after 5 years working for Nova | 16:20 |
*** sree has joined #openstack-nova | 16:20 | |
bauzas | nevermind, got my answer https://elastx.se/en/blog/backups-openstack-cloud | 16:21 |
sean-k-mooney | stephenfin: basically the comment here https://review.openstack.org/#/c/449257/52/nova/pci/request.py@93 | 16:21 |
*** tssurya has joined #openstack-nova | 16:21 | |
*** armax has joined #openstack-nova | 16:22 | |
stephenfin | sean-k-mooney: Aye, the lines I actually commented on are a cleanup task. However, my comments about what the object should actually look like are not | 16:22 |
sean-k-mooney | stephenfin: they are against lines not modified by rodolfos patch so im wondering should it be a seperate patch or in this one | 16:22 |
mriedem | bauzas: note you can't use backup with a volume-backed instance, but you can snapshot a volume-backed instance, another fun wrinkle, and something people have wanted to fix for probably 5 years as well | 16:22 |
stephenfin | sean-k-mooney: What I was suggesting is that rather than having two generic container fields on the object, we actually define the fields we want | 16:23 |
bauzas | mriedem: but you can backup a volume, right? | 16:23 |
bauzas | not with nova, of course | 16:23 |
stephenfin | sean-k-mooney: The two generic container fields being 'dict_of_lists' and 'dict_of_strings' | 16:23 |
bauzas | anyway, I'm just testing my patches against https://developer.openstack.org/api-guide/compute/server_concepts.html#server-actions | 16:23 |
bauzas | whatever the backup does, it works | 16:24 |
bauzas | period. | 16:24 |
mriedem | backup creates a snapshot with a rotating retention period yeah | 16:24 |
jaypipes | zzzeek: see: vestigial tail? :) | 16:24 |
stephenfin | sean-k-mooney: Rather than using 'dict_of_lists', add a ListOpt for each key that we'd expect to store in there. Similarly, instead of 'dict_of_strings', add a ListOpt for each key | 16:24 |
*** namnh has quit IRC | 16:24 | |
stephenfin | Does that make sense? | 16:24 |
*** lajoskatona has left #openstack-nova | 16:25 | |
*** namnh has joined #openstack-nova | 16:25 | |
bauzas | mriedem: it tags the snapshot, I see | 16:25 |
*** sree has quit IRC | 16:25 | |
bauzas | mriedem: my question was just about what was enforcing that retention | 16:25 |
bauzas | but that's fine, I see that | 16:25 |
sean-k-mooney | ok i can do that would you like it in this patch or a seperate one | 16:25 |
stephenfin | sean-k-mooney: That one, please. If not, we're going to have to immediately issue a MAJOR version bump on the object so we can remove the 'dict_of_*' fields | 16:26 |
stephenfin | Which seems awfully silly :) | 16:26 |
*** itlinux has quit IRC | 16:26 | |
*** yamamoto has quit IRC | 16:27 | |
*** AlexeyAbashkin has quit IRC | 16:27 | |
sean-k-mooney | stephenfin: the network capablites will still need to remain a list of stings in the object as it can technicall by any trait includeing custom_ ones | 16:27 |
*** eharney has quit IRC | 16:27 | |
sean-k-mooney | stephenfin: ok will do. | 16:27 |
stephenfin | sean-k-mooney: Yup, I'd expect to see 'capabilities = ListOpt(...)' | 16:27 |
stephenfin | sean-k-mooney: Shhhhooound | 16:28 |
*** _pewp_ has quit IRC | 16:28 | |
*** david-lyle has joined #openstack-nova | 16:28 | |
sean-k-mooney | am that might also want to be an object actully capablities:{ network = listOpts(...);} | 16:29 |
*** _pewp_ has joined #openstack-nova | 16:29 | |
sean-k-mooney | for pci device we could have compute or other non netowrk capablites later | 16:29 |
*** vladikr has joined #openstack-nova | 16:30 | |
*** namnh has quit IRC | 16:30 | |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Microversion 2.59 - Migrations list pagination https://review.openstack.org/516168 | 16:30 |
sean-k-mooney | e.g. gpus could have opengl/cuda level as a trait but they are still pcidevices. | 16:30 |
lyarwood | kashyap: random question, have you ever had to file a bug against libvirt as shipped in UCA? | 16:31 |
*** zhurong has quit IRC | 16:31 | |
kashyap | lyarwood: Good random question | 16:31 |
kashyap | lyarwood: I haven't, but what I did was--- | 16:32 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436 | 16:32 |
lyarwood | kashyap: hitting this http://logs.openstack.org/50/536350/1/check/legacy-grenade-dsvm-neutron-multinode-live-migration/5f7ed57/logs/screen-n-cpu.txt.gz?level=ERROR#_Jan_22_15_09_28_467904 that I think is the result of libvirt being compiled without gnutls installed, somehow. | 16:32 |
kashyap | Jump on their IRC channel, and some friendly Ubuntu person did i | 16:32 |
edleafe | mriedem: jaypipes: ^^ rebased w/new RPC version | 16:32 |
kashyap | s/did i/it/ | 16:32 |
lyarwood | kashyap: kk, which channel? | 16:32 |
edmondsw | zzzeek if you're referring to the keystone_authtoken section, keystone url has to be there so that nova knows how to talk to keystone at all | 16:32 |
kashyap | lyarwood: #ubuntu-dev | 16:32 |
*** tovin07 has quit IRC | 16:32 | |
kashyap | lyarwood: If it's a packaging but, #ubuntu-packaging | 16:32 |
kashyap | s/but/bug/ | 16:32 |
zzzeek | edmondsw: yes, but I have observed that once it does that initial talk to keystone thing, it looks into endpoints and gets whatever it finds there for keystone, then starts talking to that | 16:33 |
kashyap | Why are they compiling _out_ GnuTLS? Libvirt depends on it, as you know | 16:33 |
edmondsw | zzzeek yep. Which should be all well and good unless you've got something misconfigured | 16:33 |
lyarwood | kashyap: no idea :) | 16:33 |
*** sree has joined #openstack-nova | 16:33 | |
kashyap | lyarwood: Try if you can find Christian Ehrhardt from Canonical on those channels | 16:34 |
kashyap | lyarwood: He's the active libvirt dev from Canononical that I see | 16:34 |
kashyap | (On the upstream lists) | 16:34 |
zzzeek | edmondsw: sure. these things are just v hard to debug in an HA setup | 16:34 |
*** namnh has joined #openstack-nova | 16:35 | |
edmondsw | zzzeek yeah :( I'm not sure the exact reason there (or if there is a good reason). lbragstad would have a better idea | 16:35 |
*** moshele has joined #openstack-nova | 16:36 | |
openstackgerrit | Merged openstack/python-novaclient master: Add support for the 2.57 microversion https://review.openstack.org/528128 | 16:36 |
openstackgerrit | Merged openstack/python-novaclient master: Microversion 2.58 - Instance actions list pagination https://review.openstack.org/528601 | 16:36 |
zzzeek | edmondsw: well w regions I guess you are saying "here we'd prefer you use this address for this service" so even though you already gave it a "bootstrap" keystone, sure I'd probably like that it does that. depends on wht you're using regions for | 16:37 |
edmondsw | zzzeek yeah, regions get all kinds of funky | 16:38 |
*** andreas_s has quit IRC | 16:39 | |
*** namnh has quit IRC | 16:39 | |
*** moshele has quit IRC | 16:40 | |
kashyap | lyarwood: Probably best to report it on the tracker, to save your time | 16:41 |
openstackgerrit | Jackie Truong proposed openstack/python-novaclient master: Microversion 2.60 - Add trusted_image_certificates https://review.openstack.org/500396 | 16:41 |
kashyap | lyarwood: I see UCA libvirt bugs are filed just "normally" like this -- https://bugs.launchpad.net/fuel/+bug/1670220 | 16:41 |
openstack | Launchpad bug 1670220 in Fuel for OpenStack ocata "Libvirt service name is different for UCA" [High,Fix committed] - Assigned to Vladimir Kuklin (vkuklin) | 16:41 |
lyarwood | kashyap: kk, I created https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1744758 | 16:42 |
openstack | Launchpad bug 1744758 in libvirt (Ubuntu) "libvirt 2.5.0 appears to be compiled without gnutls" [Undecided,New] | 16:42 |
*** julienc has left #openstack-nova | 16:42 | |
kashyap | lyarwood: Yeah, checking w/ a libvirt upstream dev, seems there's no 'special' flag, but certainly something is wonky in the build | 16:43 |
kashyap | So your bug looks fine | 16:43 |
*** andreas_s has joined #openstack-nova | 16:44 | |
*** sridharg has quit IRC | 16:44 | |
lyarwood | kashyap: yeah, there's no flag for this, we just check if gnutls_cipher_encrypt is available during the build. | 16:45 |
lyarwood | kashyap: thanks for asking :) | 16:45 |
*** jackie-truong has quit IRC | 16:46 | |
*** penick has joined #openstack-nova | 16:46 | |
*** jpena is now known as jpena|brb | 16:46 | |
jaypipes | lyarwood: quick ? for you on https://review.openstack.org/#/c/460243/ | 16:47 |
lyarwood | jaypipes: looking | 16:47 |
*** chyka has joined #openstack-nova | 16:47 | |
*** dikonoor has quit IRC | 16:47 | |
lyarwood | jaypipes: yeah correct, _get_guest_xml calls down into _get_guest_storage_config that eventually calls _connect_volume | 16:50 |
*** tesseract-RH has quit IRC | 16:51 | |
bauzas | cdent: saw your -1 but that seems a bit harsh given it's for grammatical issues | 16:52 |
bauzas | cdent: would you like to see the fixes by a follow-up ? | 16:53 |
*** _pewp_ has quit IRC | 16:53 | |
bauzas | cdent: context is https://review.openstack.org/#/c/533642/5 | 16:53 |
*** andreas_s has quit IRC | 16:53 | |
cdent | bauzas: is fine as a followup, but it seemed pretty relevant since it was a release note | 16:53 |
cdent | however, since there are later changes to the same release note, followups would be fine | 16:53 |
*** _pewp_ has joined #openstack-nova | 16:53 | |
dansmith | bauzas: I think getting the reno right is worthwhile, FWIW | 16:53 |
dansmith | it's not just one typo | 16:54 |
bauzas | dansmith: cdent: okay, I'm just afraid of any possible gate slowness so close by the milestone | 16:54 |
bauzas | but I'll spin another rev | 16:54 |
dansmith | bauzas: I'll pounce on it as soon as you do | 16:54 |
bauzas | I'll also clarify what has been tested and what not | 16:54 |
cdent | jaypipes: feh, I struggle to remember '"special" filters and weighers' | 16:56 |
bauzas | also, I'm interested in getting some Oxford/Thesaurus link about the difference between a "this" and a "that" :p | 16:57 |
bauzas | because we don't have that with "ce truc" :p | 16:57 |
cdent | this is here, that is there | 16:58 |
bauzas | but we have a "tu/vous" rule that is silly | 16:58 |
cdent | english is full of silly | 16:58 |
dansmith | cdent: heh, was trying to think of a way to explain that | 16:58 |
*** sree has quit IRC | 16:58 | |
bauzas | I have a 7-yr old daughter just learning French grammar | 16:58 |
*** trinaths has quit IRC | 16:58 | |
bauzas | never say English is full of silly, or I'll just compare with French | 16:59 |
efried | Most Americans never learn English grammar, so... | 16:59 |
*** sree has joined #openstack-nova | 16:59 | |
efried | bauzas this ~= celui-çi; that ~= celui-là | 17:00 |
bauzas | this = person, that = object ? | 17:00 |
openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Ironic: negotiate microversion to allow downgrade to Pike https://review.openstack.org/535786 | 17:00 |
*** suresh12 has joined #openstack-nova | 17:00 | |
efried | no | 17:00 |
efried | just ceci vs cela | 17:00 |
bauzas | mmmm | 17:00 |
*** derekh_ has joined #openstack-nova | 17:00 | |
jroll | hey (again) nova friends, the ironic rolling upgrade testing is down. while we try to track down why nova-conductor segfaults after upgrading ironic (without restarting n-cond), this patch will help us work around it by allowing nova queens to work with ironic pike (which is a good thing for users anyway). reviews would be super helpful, thank you :) https://review.openstack.org/#/c/535786/ | 17:01 |
efried | bauzas Mais je peux voir que "ça" peut servir pour les deux | 17:01 |
bauzas | efried: 'Remove that code' looks to be wrong | 17:02 |
bauzas | that means "ce" to me | 17:02 |
bauzas | anyway | 17:02 |
bauzas | just rebasing now | 17:02 |
*** smatzek has joined #openstack-nova | 17:02 | |
mriedem | edleafe: ok comments inline | 17:02 |
efried | bauzas Depends on the context. And it's definitely subtle. If I highlighted a chunk and made a gerrit comment on it, I would sai "Remove this code". If I was talking about some code somewhere else, or in the future, I would say "Remove that code". | 17:03 |
*** matrohon has quit IRC | 17:03 | |
*** derekh has quit IRC | 17:03 | |
*** felipemonteiro__ has quit IRC | 17:04 | |
*** ralonsoh_ has joined #openstack-nova | 17:04 | |
* efried doesn't speculate on who would say, "Keep all the code" | 17:04 | |
bauzas | efried: I see, it's more the intent itself | 17:05 |
bauzas | I'll try to play with this | 17:06 |
bauzas | (and not that) | 17:06 |
bauzas | thanks | 17:06 |
efried | Bonne chance. | 17:06 |
edleafe | mriedem: will review in a bit | 17:06 |
efried | I'll argue English-is-sillier-than-French any day. | 17:07 |
*** fragatina has joined #openstack-nova | 17:07 | |
*** ralonsoh has quit IRC | 17:08 | |
*** bhujay has quit IRC | 17:08 | |
*** Yikun has joined #openstack-nova | 17:10 | |
*** yikun_jiang has quit IRC | 17:11 | |
*** pcaruana has quit IRC | 17:11 | |
*** sree has quit IRC | 17:11 | |
jaypipes | lyarwood: thx. just wanted to be sure. | 17:11 |
*** jpena|brb is now known as jpena | 17:11 | |
*** moshele has joined #openstack-nova | 17:13 | |
*** hieulq has quit IRC | 17:16 | |
mriedem | stvnoyes: your swap volume multiattach tempest test patch is a merge conflict with the resize test, i'm going to rebase those so they are in a series, otherwise i can't test them together | 17:16 |
stvnoyes | ok | 17:17 |
*** janki has quit IRC | 17:17 | |
*** armax has quit IRC | 17:18 | |
openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: SEA https://review.openstack.org/523216 | 17:19 |
*** armax has joined #openstack-nova | 17:20 | |
esberglu | gibi: Removed the nova-net references from ^ so it's ready whenever you have a chance. Thanks for the reviews! | 17:22 |
*** smatzek has quit IRC | 17:22 | |
*** smatzek has joined #openstack-nova | 17:23 | |
*** archit is now known as amodi | 17:23 | |
*** suresh12 has quit IRC | 17:24 | |
*** moshele has quit IRC | 17:24 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: [api] Allow multi-attach in compute api https://review.openstack.org/271047 | 17:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add the nova-multiattach job https://review.openstack.org/532689 | 17:25 |
mriedem | ah crap | 17:25 |
mriedem | gibi: accidental rebase on https://review.openstack.org/#/c/271047/ - want to +W again? | 17:25 |
*** jose-phillips has joined #openstack-nova | 17:26 | |
*** smatzek_ has joined #openstack-nova | 17:27 | |
*** smatzek has quit IRC | 17:28 | |
*** suresh12 has joined #openstack-nova | 17:30 | |
dansmith | jroll: is that a thing you want separate from working around the segv issue? because I thought we always expect ironic to be newer and this changes that | 17:32 |
*** smatzek_ has quit IRC | 17:33 | |
jroll | dansmith: yes, we want to be able to go one release either way between ironic and nova. click the bug there, there's a plan where we drop most of the negotiation in the client to do so, this is just the quick way to do it | 17:34 |
*** suresh12 has quit IRC | 17:34 | |
openstackgerrit | Merged openstack/nova master: doc: Document TLS security setup for noVNC proxy https://review.openstack.org/500544 | 17:35 |
*** smatzek has joined #openstack-nova | 17:35 | |
mriedem | efried: thanks for running the nova meeting last week | 17:35 |
efried | mriedem Sure thing, for what it was worth :) I didn't update the agenda or anything, so it was a bit slipshod. | 17:35 |
mriedem | was fine | 17:36 |
mriedem | you are now, incidentally, the PTL for Rocky, congratulations; it was a trap. | 17:36 |
dansmith | woohoo! | 17:37 |
efried | hahahaha, so THAT's all it takes? | 17:37 |
dansmith | jroll: mkay, I'm not sure how I feel about this.. the mechanism hasn't changed since this was titled "hacky negotiation to let us do a thing" and ... I agree | 17:37 |
*** tidwellr_ has quit IRC | 17:37 | |
jroll | dansmith: I mean, it's a bit of a hack but it works. the client patches are nearly done to do the better way, but it likely won't make this cycle. our options are basically do this or release without tested rolling upgrades, AIUI | 17:38 |
dansmith | mriedem: you marked this bug as wishlist so I assume you're okay with it? (having a random previous ironic microversion the driver is willing to use) | 17:38 |
dansmith | jroll: because some library is crashing conductor? | 17:39 |
jroll | dansmith: suggestions welcome. especially if you can figure out the conductor exploding | 17:39 |
dansmith | jroll: everything we add after this will have to either bump that "previous" thing or add infrastructure and handling for the newer feature, IFF the version is new enough | 17:40 |
edleafe | efried: it's so cute that you think mriedem is kidding. | 17:40 |
dansmith | jroll: is it some action that causes conductor to crash and is a restart enough? It's odd since conductor shouldn't be related to ironic at all | 17:40 |
mriedem | dansmith: which bug? | 17:41 |
dansmith | mriedem: well, it's a combo thing.. they want "N-1 ironic support in the driver" as well as this configdrive optionality which uses it, which I guess works around some other unrelated issue by chance | 17:41 |
dansmith | mriedem: https://review.openstack.org/#/c/535786/5 | 17:42 |
jroll | dansmith: debugging notes so far are at line 47 here: https://etherpad.openstack.org/p/IronicWhiteBoard . as far as we can tell, upon upgrade, some shared library is being deleted, that is being loaded at runtime in the conductor | 17:42 |
jroll | see also https://bugs.launchpad.net/ironic/+bug/1744139 | 17:42 |
openstack | Launchpad bug 1744139 in Ironic "Grenade job fails due to systemd stopping n-cpu" [Critical,In progress] - Assigned to Julia Kreger (juliaashleykreger) | 17:42 |
dansmith | jroll: right, so just a restart of the service because of that issue would be all we need right? | 17:42 |
dansmith | that seems like a reasonable thing to have in a from-foo script in grenade with a note about the shared library thing | 17:43 |
jroll | dansmith: pike conductor won't start with queens version of global-reqs | 17:43 |
dansmith | jroll: yikes, well that kinda breaks upgrades across the board for everyone then | 17:43 |
* jroll attempting to find details | 17:43 | |
jroll | dansmith: yeah, you're the first to respond to cries for help here :P | 17:44 |
mriedem | jroll: note that dan and i were out last week too on unrelated adventures | 17:45 |
sean-k-mooney | dansmith: only if you use systemd. if you use kolla you should be fine | 17:45 |
sean-k-mooney | dansmith: well i guess it breaks the gate for everyone | 17:45 |
dansmith | jroll: this N-1 patch is a really bad way to work around this grenade breakage, IMHO, because it sounds like you're suggesting changing the ordering to "fix" things with help from this | 17:45 |
*** penick has quit IRC | 17:45 | |
jroll | sean-k-mooney: s/use systemd/run other services co-located with nova conductor without some isolation/ | 17:46 |
*** jdillaman has joined #openstack-nova | 17:47 | |
jroll | dansmith: don't disagree - I know smart people spent a lot of time debugging the real issue and didn't get very far. I jumped in to help write this patch, which is something we want anyway. (of course we'll need to document this special case as well) | 17:47 |
mriedem | has grenade ever supported n-1 nova-conductor with n requirements? i thought with multinode grenade, we always brought down the controller services and brought everything up with N code and dependencies, and left the subnode n-cpu at N-1? | 17:48 |
dansmith | mriedem: right, conductor can't be backlevel | 17:48 |
jroll | ironic's grenade has always supported n-1 nova with n ironic | 17:48 |
dansmith | zero detail on the reason for the segv in the logs it looks like | 17:48 |
sean-k-mooney | johnthetubaguy: oh ya i had not read the full bug but i see its really a python lib issue so ya unless you use contaienrs or other isolation mechanisum(venvs ...) your kindo of screwed | 17:48 |
sean-k-mooney | * jroll not johnthetubaguy | 17:49 |
mriedem | jroll: sure but that's different, | 17:49 |
dansmith | jroll: we're talking about nova-conductor and the rest of nova | 17:49 |
*** Eran_Kuris has joined #openstack-nova | 17:49 | |
mriedem | and the release notes in nova have always said, "make sure you upgrade ironic first before nova" which is how we always hedged against version discovery/negotiation | 17:49 |
dansmith | so I'm pretty hard -2 on working around this issue, which will break lots of people, by changing the upgrade order rules in the eleventh hour | 17:49 |
*** mjturek has joined #openstack-nova | 17:50 | |
dansmith | independent of whether or not we support an n-1 ironic | 17:50 |
jroll | dansmith: mriedem: right, we haven't upgraded nova at all. but upgrading ironic upgrades a number of libraries. we don't restart n-cond with the new libraries, but somehow at runtime it's causing these segfaults | 17:50 |
jroll | sure, if someone can help fix the actual issue, I'm happy to kill this patch | 17:50 |
dansmith | jroll: yep, I get that as the cause here | 17:50 |
*** hoonetorg has quit IRC | 17:50 | |
dansmith | we probably need gate/devstack/grenade people help here to capture a core or something | 17:50 |
dansmith | jroll: is there any temporal locality about when this started happening related to some bump in g-reqs? | 17:51 |
jroll | sorry, was pointing out that how nova does grenade is irrelevant here | 17:51 |
*** amorin is now known as amorin[away] | 17:51 | |
dansmith | jroll: sure, the ordering of services within grenade shouldn't change to cover this up, is what Imeant | 17:51 |
jroll | dansmith: not sure offhand, TheJulia do you know? | 17:51 |
* TheJulia context switches | 17:51 | |
jroll | :) | 17:51 |
dansmith | I see now why it affects conductor, because of the worker forking, which likely means it could affect other things the same way under load | 17:52 |
TheJulia | ironic is a plugin, aiui, we're stuck with the order of ironic after nova | 17:52 |
openstackgerrit | Jay Pipes proposed openstack/nova master: tests for alloc candidates with nested and traits https://review.openstack.org/531899 | 17:52 |
openstackgerrit | Jay Pipes proposed openstack/nova master: add test for scenario with sum of child resources https://review.openstack.org/534339 | 17:52 |
openstackgerrit | Jay Pipes proposed openstack/nova master: _get_trees_matching_all_resources() sum children https://review.openstack.org/534866 | 17:52 |
openstackgerrit | Jay Pipes proposed openstack/nova master: add _get_usages_from_trees() function https://review.openstack.org/534967 | 17:52 |
openstackgerrit | Jay Pipes proposed openstack/nova master: WIP - populate alloc cands for trees https://review.openstack.org/534968 | 17:52 |
openstackgerrit | Jay Pipes proposed openstack/nova master: validate provider summary structure https://review.openstack.org/536516 | 17:52 |
dansmith | no, ironic goes before nova, which is why this is happening, right? | 17:52 |
TheJulia | no | 17:53 |
jroll | we disable the nova upgrade altogether in our rolling upgrades test | 17:53 |
dansmith | ah, well, then the same difference | 17:53 |
TheJulia | the operational order of upgade as defined in grenade is nova before ironic can be even upgraded, however things go sideways in the logs starting around swift/glance being updated | 17:53 |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: Recreate mediated devices on reboot https://review.openstack.org/533642 | 17:53 |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: pass the mdevs when rebooting the guest https://review.openstack.org/533818 | 17:53 |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Avoid suspending guest with attached vGPUs https://review.openstack.org/535693 | 17:53 |
dansmith | going before isn't a solution because it changes the ordering, which you're forcing by just disabling the nova upgrade | 17:54 |
*** AlexeyAbashkin has joined #openstack-nova | 17:54 | |
*** Tom-Tom has joined #openstack-nova | 17:54 | |
TheJulia | going before requires retooling grenade _or_ moving ironic's upgrade scripting into grenade | 17:54 |
TheJulia | both have been objected to in the past | 17:54 |
dansmith | and changing the expectations of the operators, documentation, and anything else that may be different as a result | 17:54 |
jroll | sorry, we got off-track a bit - TheJulia, I meant to ask if you know if there are any g-r bumps around the same time as this started happening? (I'm attempting to find that right now) | 17:55 |
TheJulia | Ironic has always stated that ironic must be upgraded prior to nova, however some nova contributors have expressed desire that ironic can be upgrded earlier. The API pin is what kills us | 17:55 |
*** mvenesio has joined #openstack-nova | 17:56 | |
TheJulia | jroll: I don't believe | 17:56 |
dansmith | you said "goes before" and "people want earlier" which doesn't seem different to me | 17:56 |
*** AlexeyAbashkin has quit IRC | 17:56 | |
TheJulia | I don't believe so, however we had two different grenade breaks in about 24 hours | 17:56 |
dansmith | why is nova-conductor not segfaulting like crazy after the thing that upgrades g-reqs (swift/glance) in other jobs? | 17:56 |
TheJulia | I think because it gets restarted | 17:56 |
dansmith | or is it and we don't notice because we don't care until after? | 17:56 |
*** Eran_Kuris has quit IRC | 17:57 | |
jroll | I think nova gets upgraded first in most grenade runs, right? | 17:57 |
dansmith | okay and so it matters for you because you never upgrade nova at the end? | 17:57 |
TheJulia | the state it is left in prior to that restart is referring to a bunch of modules/libraries/paths that have been deleted due to prior python module upgrades | 17:57 |
*** Eran_Kuris has joined #openstack-nova | 17:57 | |
dansmith | jroll: no I don't think so | 17:57 |
jroll | hm | 17:57 |
*** jaypipes has quit IRC | 17:58 | |
TheJulia | just restarting didn't work because of a sqlalchemy change | 17:58 |
*** amodi has quit IRC | 17:58 | |
TheJulia | since python requirements no longer match up because some processes have upgraded parts and pieces of the libraries | 17:58 |
*** Tom-Tom has quit IRC | 17:58 | |
sean-k-mooney | TheJulia: ie ironic installed new sqlalcamy and since nova is not upgraded its not compatible? | 17:59 |
TheJulia | sean-k-mooney: no | 17:59 |
TheJulia | Ironic has not yet upgraded at that point | 17:59 |
TheJulia | it is earlier on in the glance execution | 17:59 |
dansmith | what is the sqlalchemy fail? because that seems like a bad thing | 17:59 |
*** derekh_ has quit IRC | 18:00 | |
TheJulia | yes, an argument was removed from sqlalchemy and oslo_db changed accordingly | 18:00 |
TheJulia | I believe | 18:00 |
* TheJulia looks in notes for link | 18:00 | |
* jroll puts for the record the first message he sees in logstash is at 2018-01-17T09:52:37.119Z | 18:01 | |
TheJulia | https://github.com/openstack/oslo.db/commit/4a727233dc2b7d1021ed7932d2cd27d8053dca31 | 18:01 |
*** ralonsoh_ has quit IRC | 18:02 | |
jroll | looks like oslo.middleware 3.34.0, oslo.utils 3.35.0, and osprofiler 1.15.1 are the most relevant g-r updates | 18:03 |
TheJulia | jroll: but also, our grenade jobs were failing due to a neutron change for about 24-36 hours prior to that | 18:03 |
dansmith | so some glue around this change might get us out of the jam? https://review.openstack.org/#/c/501073/1/nova/db/sqlalchemy/api.py | 18:03 |
sean-k-mooney | is this for master? g-r for SQLAlchemy on master has a minium of 1.0.10 and pike has an upperconstaint of 1.1.12 so you should be able to install master without needing to upgrade SQLAlchemy | 18:03 |
*** penick has joined #openstack-nova | 18:03 | |
jroll | TheJulia: oh right, were they getting into the upgrade bits? | 18:03 |
sean-k-mooney | i guess it upgrades because we allway install the newest requirement allowed in greade | 18:03 |
dansmith | I'd guess that's just a library API breakage in oslo.db | 18:03 |
TheJulia | jroll: what do you mean? | 18:04 |
jroll | TheJulia: with the neutron failure, was that before or after the upgrade, do you remember? | 18:04 |
dansmith | TheJulia: yeah, so that commit you linked from oslo.db needs to be graceful I think as it's an API breakage, AFAICT | 18:05 |
TheJulia | before, neutron's upgrade would fail | 18:05 |
jroll | TheJulia: ah, thanks. | 18:05 |
TheJulia | because of networking-generic-swtich | 18:05 |
dansmith | or, maybe since it was deprecated we need to backport a fix to nova pike to stop passing it? | 18:05 |
*** mgoddard_ has quit IRC | 18:05 | |
jroll | oslo.concurrency feels like a likely suspect in that range then, too (believe that touches some C libraries) | 18:06 |
mriedem | how is nova-conductor even picking up the new oslo.db if it's not being restarted? | 18:06 |
jroll | dansmith: that would let us restart it, yeah, though that isn't ideal | 18:06 |
dansmith | mriedem: worker forking | 18:06 |
jroll | well, there's two things going on | 18:07 |
*** hoonetorg has joined #openstack-nova | 18:07 | |
jroll | the worker fork segfaults | 18:07 |
dansmith | jroll: ah right I got lost that this can't be the segv issue, it's the breakage that prevents the restart, correct | 18:07 |
jroll | if we restart the main process, it fails due to oslo.db | 18:07 |
dansmith | right right | 18:07 |
mriedem | ah ok, so not an intentional restart | 18:07 |
mriedem | something triggers a failure and restart, which then fails | 18:07 |
dansmith | mriedem: it's just workers being cycled in and out I think, not failure related initially | 18:08 |
mriedem | i'll go ahead and say i don't understand | 18:09 |
mriedem | i welcome the ridicule | 18:09 |
sean-k-mooney | dansmith: the minium version of SQLAlchemy on master is below the max on pike currently. the commit TheJulia referenced does not seem to indicate what version of SQLAlchemy removed the retry arg. it sound like there is a min version bump missing also if that change is not graceful | 18:09 |
*** david-lyle has quit IRC | 18:09 | |
*** dtantsur is now known as dtantsur|afk | 18:09 | |
jroll | mriedem: it looks like this http://logs.openstack.org/36/509336/31/check/ironic-grenade-dsvm-multinode-multitenant/6da9163/logs/screen-n-cond.txt.gz#_Jan_18_05_52_41_241366 | 18:09 |
TheJulia | if the fork causes a dynamic library to be referenced that hasn't already been opened by the parent process, that would explain the segfault in that some of the things the parent was still running with that spanws the worker is gone because pip deleted them | 18:09 |
jroll | and then systemd starts killing n-cpu and such, because insanity | 18:09 |
TheJulia | and then people begin drinking fine spirits | 18:10 |
*** moshele has joined #openstack-nova | 18:10 | |
dansmith | I have to run to a thing for a bit, back in a bit | 18:11 |
*** felipemonteiro has joined #openstack-nova | 18:12 | |
jroll | I feel like this is related but I can't prove it https://github.com/openstack/oslo.concurrency/commit/55e06261aa86c87c7c059fbddc97cdbaae06e8dd | 18:12 |
sean-k-mooney | jroll: i would assume systemd did not kill n-cpu and it segfaulted by trying to deref a fuction pointer from a module that nologer existed due to the upgrade and systemd just noticed the process died. | 18:12 |
jroll | sean-k-mooney: n-conductor does the segfaulting, n-cpu gets killed by systemd | 18:13 |
jroll | iirc | 18:13 |
mriedem | if this has been happening for <=10 days we could hopefully figure out when it started from logstash | 18:14 |
TheJulia | jroll: that is correct | 18:14 |
*** jackie-truong has joined #openstack-nova | 18:14 | |
jroll | mriedem: we had another failure for about 24-36 hours before that, so it's a bit masked, but the first instance is 2018-01-17T09:52:37.119Z in logstash | 18:14 |
mriedem | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Forking%20too%20fast%2C%20sleeping%5C%22%20AND%20tags%3A%5C%22screen-n-cond.txt%5C%22&from=10d | 18:15 |
*** felipemonteiro_ has joined #openstack-nova | 18:15 | |
mriedem | https://github.com/openstack/requirements/commit/482fca3e04b820045bb87d9b37470bc076d2216d was 1/16 | 18:16 |
jroll | right | 18:17 |
mriedem | not sure that commit should be a problem though since something has to opt into passing the new kwarg, else it defaults to the same as before | 18:18 |
mriedem | https://github.com/openstack/oslo.concurrency/compare/3.24.0...3.25.0 | 18:18 |
*** jpena is now known as jpena|off | 18:18 | |
jroll | ah true | 18:18 |
mriedem | and i don't think we run with osprofiler enabled in this job do we? | 18:18 |
mriedem | worth checking | 18:18 |
*** felipemonteiro has quit IRC | 18:18 | |
jroll | not that I know of | 18:18 |
jroll | I don't think any ironic jobs have ever enabled that | 18:19 |
*** jackie-truong has quit IRC | 18:19 | |
mriedem | Jan 18 04:49:32.628690 ubuntu-xenial-inap-mtl01-0001976291 nova-conductor[19600]: DEBUG oslo_service.service [None req-db5ca533-98f7-4358-8448-0201fe9a04d8 None None] profiler.enabled = False {{(pid=19600) log_opt_values /usr/local/lib/python2.7/dist-packages/oslo_config/cfg.py:2883}} | 18:19 |
mriedem | yeah osprofiler isn't enabled | 18:19 |
mriedem | https://github.com/openstack/requirements/commit/34d56244a87ac2a61170ab8fa81dc86dba70fc1f was 1/17 | 18:20 |
mriedem | cffi? | 18:20 |
*** armax has quit IRC | 18:20 | |
jroll | could be | 18:20 |
mriedem | could try reverting that back to 1.11.2 and run a depends-on with an ironic patch | 18:21 |
jroll | https://github.com/cffi/cffi/compare/1.11.2...1.11.4 | 18:21 |
jroll | nothing O_o | 18:21 |
*** Eran_Kuris has quit IRC | 18:21 | |
*** jackie-truong has joined #openstack-nova | 18:21 | |
jroll | oh, they don't tag, good | 18:21 |
mriedem | http://cffi.readthedocs.io/en/latest/whatsnew.html#v1-11-4 | 18:21 |
*** armax has joined #openstack-nova | 18:22 | |
jroll | windows, py3, meh | 18:22 |
mriedem | that's just the stuff they call out in the release notes | 18:22 |
*** sree has joined #openstack-nova | 18:22 | |
mriedem | but yeah | 18:22 |
*** suresh12 has joined #openstack-nova | 18:23 | |
mriedem | https://github.com/openstack/requirements/commit/93d488328bfc780c322338226b6c62e9141637f4 | 18:24 |
mriedem | note the "and introduces a file handel leak due to an upstream bug in pyroute2" | 18:24 |
mriedem | https://github.com/openstack/os-vif/compare/1.7.0...1.9.0 | 18:24 |
jroll | mmmm | 18:24 |
mriedem | https://github.com/openstack/os-vif/commit/570c05266fa6231a21d70f2917ac0a933ac8ce7b | 18:26 |
sean-k-mooney | i dont think os-vif is the cause as in 1.7 we did not use pyroute2 and in 1.9.0 we have disabled and use ip tools instead. | 18:26 |
jroll | doesn't look like os-vif gets upgraded, though: http://logs.openstack.org/36/509336/31/check/ironic-grenade-dsvm-multinode-multitenant/6da9163/logs/grenade.sh.txt.gz | 18:26 |
sean-k-mooney | jroll: the only project useing os-vif are nova and kuyr-kubernetes | 18:27 |
*** sree has quit IRC | 18:27 | |
efried | rgerganov yt? | 18:27 |
sean-k-mooney | im assumeing you dont have the later installed in this gate and you disable nova upgrade right ? | 18:27 |
mriedem | yeah os-vif is 1.7.0 in pip freeze | 18:28 |
mriedem | http://logs.openstack.org/36/509336/31/check/ironic-grenade-dsvm-multinode-multitenant/6da9163/logs/pip2-freeze.txt.gz | 18:28 |
jroll | so in this run, it started segfaulting at 05:49:48.642840 | 18:28 |
jroll | here is grenade.txt at that time-ish http://logs.openstack.org/36/509336/31/check/ironic-grenade-dsvm-multinode-multitenant/6da9163/logs/grenade.sh.txt.gz#_2018-01-18_05_49_47_199 | 18:28 |
jroll | gotta be one of those first few imo | 18:29 |
cdent | efried: he's a time zone before me, and usually pretty sane with regards to going home, so he's probably not around | 18:29 |
*** felipemonteiro_ has quit IRC | 18:29 | |
efried | cdent Swhat I figured, but it was worth a shot. Perhaps you can see it: https://review.openstack.org/#/c/533821/6/nova/scheduler/client/report.py@1399 | 18:30 |
jroll | simplejson does lots of C things: https://github.com/simplejson/simplejson/compare/v3.11.1...v3.13.2 | 18:31 |
* cdent looks | 18:31 | |
mriedem | simplejson 3.13.2 has been in u-c for 2 months though | 18:32 |
mriedem | so it's not that | 18:32 |
mriedem | looking at things in https://github.com/openstack/requirements/commit/34d56244a87ac2a61170ab8fa81dc86dba70fc1f from 1/17 that are in that list | 18:32 |
mriedem | and which nova usess | 18:32 |
*** pcaruana has joined #openstack-nova | 18:32 | |
mriedem | i think that would only be babel, sphinx and cffi, and runtime code doesn't use sphinx | 18:33 |
mriedem | nor babel i don't think | 18:33 |
mriedem | so my money is on cffi | 18:33 |
jroll | right | 18:33 |
jroll | cffi isn't being upgraded at that time though | 18:33 |
cdent | efried: I think you're right | 18:34 |
efried | cdent Thanks for looking. | 18:34 |
efried | cdent I coded it all up as if I wasn't, then started writing tests... | 18:34 |
*** jackie-truong has quit IRC | 18:34 | |
jroll | mriedem: hrm, there's also 2018-01-18 05:49:32.589 | + /opt/stack/new/grenade/projects/50_neutron/upgrade.sh:main:96 : sudo apt-get -y install python-qpid | 18:34 |
edleafe | efried: just looked, too, and I can't find any way it could be None, either | 18:35 |
efried | edleafe Thank you. | 18:35 |
*** jackie-truong has joined #openstack-nova | 18:35 | |
sean-k-mooney | jroll: the gate runs on rabbitmq but perhaps python-qupid has a dep that upgraded something | 18:35 |
jroll | mriedem: oh, and from apt-get update about 3 minutes before crashy crashy http://logs.openstack.org/36/509336/31/check/ironic-grenade-dsvm-multinode-multitenant/6da9163/logs/grenade.sh.txt.gz#_2018-01-18_05_46_59_521 | 18:35 |
cdent | efried: I think one of the thing that makes me confused about the ProviderTree stuff is that it behaves as if it is a strong Type. Which may make sense in this context, but I struggle to get used to it; it changes some idioms. | 18:35 |
efried | cdent What do you mean by "strong Type"? | 18:36 |
jroll | nova definitely uses python-libvirt | 18:36 |
mriedem | qpid shouldn't be getting installed | 18:36 |
edleafe | cdent: you mean static type? | 18:36 |
sean-k-mooney | finding the lib that change however wont resolve the issue will it. this seams like a general class of problem. | 18:36 |
sean-k-mooney | python-libvirt is used by n-cpu but not the conductor | 18:36 |
jroll | there's definitely a possibility it's imported by the conductor, though | 18:37 |
jroll | in some way | 18:37 |
*** jmlowe_ has quit IRC | 18:37 | |
*** AlexeyAbashkin has joined #openstack-nova | 18:38 | |
jroll | sean-k-mooney: yes, it's a general class of problem with a known solution: don't use system packages :P | 18:38 |
cdent | edleafe, efried: I guess static could work as well, but what I mean is that it is written as if we're in a strongly typed language and the ProviderTree itself is a (static) type, made of up of statically typed things. <- This is not a relevant though, really, I'm just trying to suss out some of the sources of my anxiety with ProviderTree so I can flush them. | 18:38 |
jroll | I gotta step away for a bit so I can eat and stuff, sorry | 18:39 |
sean-k-mooney | jroll: i dont think the conductor is aware of the hypervisor so i dont think it would ever import phyton-libvirt. unless for the livemigration events? | 18:39 |
cdent | stuff | 18:39 |
jroll | cdent: short for stuff my face :D | 18:39 |
jroll | sean-k-mooney: not on purpose, but it's a tangled web | 18:39 |
* jroll bbiab | 18:39 | |
*** tidwellr has joined #openstack-nova | 18:40 | |
mriedem | conductor only talks to n-cpu over rpc | 18:40 |
cdent | but yes, edleafe, I'm noodling in a way that uses terms incorrectly | 18:40 |
edleafe | cdent: no worries; just wanted to be sure I understood your thoughts | 18:41 |
sean-k-mooney | mriedem: ya i think python-libvirts use shoudl be limited to just the libvirt virt driver correct | 18:41 |
mriedem | yes | 18:41 |
*** AlexeyAbashkin has quit IRC | 18:42 | |
*** esberglu has quit IRC | 18:46 | |
mriedem | jroll: for when you get back, it looks like ovs was getting updated too around the time things started crashing http://logs.openstack.org/36/509336/31/check/ironic-grenade-dsvm-multinode-multitenant/6da9163/logs/openvswitch/ovs-vswitchd.txt.gz | 18:48 |
mriedem | 2018-01-18T05:46:42.826Z|05730|rconn|INFO|brbm<->tcp:127.0.0.1:6633: connection closed by peer | 18:48 |
*** eharney has joined #openstack-nova | 18:48 | |
*** esberglu has joined #openstack-nova | 18:49 | |
mriedem | 2018-01-18T05:46:38.988Z|00007|jsonrpc|WARN|tcp:127.0.0.1:47588: receive error: Connection reset by peer | 18:50 |
mriedem | and neutron is upgraded right before ironic when things start blowing up | 18:51 |
*** cdent has quit IRC | 18:52 | |
*** lpetrut has quit IRC | 18:54 | |
*** links has quit IRC | 18:55 | |
mriedem | 2018-01-18 05:46:41.213 | + /opt/stack/new/devstack/functions-common:stop_process:1528 : sudo systemctl stop devstack@q-agt.service | 18:57 |
*** fragatina has quit IRC | 18:58 | |
*** chyka has quit IRC | 19:00 | |
*** jmlowe has joined #openstack-nova | 19:00 | |
sean-k-mooney | mriedem: looking at the systemd service files on my local system there is no depency between q-agt or n-cpu and n-cond or the supper conductor for that matter so that service stop should not propegate to nova services | 19:01 |
sean-k-mooney | if the connect reset is in ovs-vswitchd.txt.gz it indicates teh q-agt was upgraded rather then ovs | 19:02 |
*** amodi has joined #openstack-nova | 19:03 | |
mriedem | yeah q-agt is being stopped at 5:46:42 | 19:03 |
sean-k-mooney | so its likely one (proably several) of neutron deps is common with nova | 19:04 |
*** lucasagomes is now known as lucas-afk | 19:04 | |
sean-k-mooney | in the normal upgrade sequence nova would upgrade before neutron correct | 19:04 |
sean-k-mooney | i mean technicall i dont think it has to but i think that is correct for greade | 19:05 |
mriedem | no | 19:05 |
*** penick has quit IRC | 19:05 | |
mriedem | neutron goes before nova | 19:05 |
sean-k-mooney | oh ok | 19:05 |
mriedem | Jan 18 05:48:49 ubuntu-xenial-inap-mtl01-0001976291 kernel: traps: nova-compute[1669] general protection ip:4a7f54 sp:7ffd13de8328 error:0 in python2.7[400000+2e9000] | 19:06 |
mriedem | http://logs.openstack.org/36/509336/31/check/ironic-grenade-dsvm-multinode-multitenant/6da9163/logs/syslog.txt.gz#_Jan_18_05_48_49 | 19:06 |
mriedem | Jan 18 05:49:48 ubuntu-xenial-inap-mtl01-0001976291 kernel: nova-conductor[20023]: segfault at d0 ip 0000000000500211 sp 00007ffdae038760 error 4 in python2.7[400000+2e9000] | 19:07 |
sean-k-mooney | mriedem: ya so that basically a segfault | 19:07 |
mriedem | yeah, and not helpful as to what failed | 19:07 |
*** jackie-truong has quit IRC | 19:07 | |
*** david-lyle has joined #openstack-nova | 19:07 | |
mriedem | right before it: | 19:08 |
mriedem | Jan 18 05:49:36 ubuntu-xenial-inap-mtl01-0001976291 sudo[24307]: stack : TTY=unknown ; PWD=/opt/stack/old/tempest ; USER=root ; ENV=http_proxy= https_proxy= no_proxy= PIP_FIND_LINKS= SETUPTOOLS_SYS_PATH_TECHNIQUE=rewrite ; COMMAND=/usr/local/bin/pip2.7 install -c /opt/stack/new/requirements/upper-constraints.txt -r /opt/stack/new/neutron/test-requirements.txt -e /opt/stack/new/neutron | 19:08 |
mriedem | neutron is installing stuff | 19:08 |
*** AlexeyAbashkin has joined #openstack-nova | 19:08 | |
sean-k-mooney | well it happend 5 seconds after we start installing the swift test-requirements http://logs.openstack.org/36/509336/31/check/ironic-grenade-dsvm-multinode-multitenant/6da9163/logs/syslog.txt.gz#_Jan_18_05_48_44 | 19:09 |
sean-k-mooney | the sudo process for install the swift test requiremetns pid:15728 end at http://logs.openstack.org/36/509336/31/check/ironic-grenade-dsvm-multinode-multitenant/6da9163/logs/syslog.txt.gz#_Jan_18_05_48_54 | 19:12 |
sean-k-mooney | so the compute agent segfault while we are upgradeing the test requiremets for swift | 19:13 |
*** sree has joined #openstack-nova | 19:14 | |
sean-k-mooney | that said nothing in https://github.com/openstack/swift/blob/master/test-requirements.txt jumps out at me | 19:14 |
mriedem | i don't know why test-requirement would be getting installed in a devstack env anyway | 19:15 |
mriedem | test-requirements should be for unit tests | 19:15 |
sean-k-mooney | mriedem: that is a dispute i have had with devstack for 2-3 releases | 19:16 |
sean-k-mooney | devstack installs all test-requiremets systemwide | 19:16 |
sdague | test-requirements also got overloaded by lots of projects as "optional requirements" and people put all their drivers in there | 19:16 |
sdague | it's never had clear definitions | 19:17 |
sdague | it was made to always install... 3 years ago? | 19:17 |
mriedem | ok so neutron reqs are installed here for queens | 19:17 |
mriedem | Jan 18 05:49:36 ubuntu-xenial-inap-mtl01-0001976291 sudo[24307]: stack : TTY=unknown ; PWD=/opt/stack/old/tempest ; USER=root ; ENV=http_proxy= https_proxy= no_proxy= PIP_FIND_LINKS= SETUPTOOLS_SYS_PATH_TECHNIQUE=rewrite ; COMMAND=/usr/local/bin/pip2.7 install -c /opt/stack/new/requirements/upper-constraints.txt -r /opt/stack/new/neutron/test-requirements.txt -e /opt/stack/new/neutron | 19:17 |
sean-k-mooney | sdague: yes but if they are optional they should only be installed in the gates that need them :) | 19:17 |
mriedem | then nova-conductor segfaults Jan 18 05:49:48 ubuntu-xenial-inap-mtl01-0001976291 kernel: nova-conductor[20023]: segfault at d0 ip 0000000000500211 sp 00007ffdae038760 error 4 in python2.7[400000+2e9000] | 19:17 |
mriedem | and nova-conductor is pike at this point | 19:18 |
sean-k-mooney | sdague: yep but it only bit me with the flake8 import ording plugin that was added then blacklisted to nova test-requriement that ended up brakeing our ovs-dpdk gates because ovs enabled pip but disable that check internally | 19:19 |
*** sree has quit IRC | 19:19 | |
sean-k-mooney | mriedem: well that appears to be the same memory adress in both python2.7[400000+2e9000] | 19:19 |
*** AlexeyAbashkin has quit IRC | 19:20 | |
sean-k-mooney | mriedem: this is a time issue tool any of the previous pip installs could have cased it, as we cant know how long it will be betwen the module being replaced and the dangeling function pointer being deferenced | 19:22 |
sean-k-mooney | * timing issue too | 19:23 |
openstackgerrit | Mark Goddard proposed openstack/nova master: Implement get_traits() for the ironic virt driver https://review.openstack.org/532288 | 19:23 |
*** itlinux has joined #openstack-nova | 19:23 | |
*** jaypipes has joined #openstack-nova | 19:24 | |
*** sree has joined #openstack-nova | 19:25 | |
efried | edleafe jaypipes Just found a nice leetle bug | 19:25 |
sean-k-mooney | sdague: by the way that was not a did at you. i know why you made the change i.e the multiple code paths and the dep issue it was causeing. | 19:25 |
mriedem | hmm, so n-cpu starts failing around 5:46 and fails to connect to the ironic api | 19:26 |
efried | sdague too | 19:26 |
openstackgerrit | Mark Goddard proposed openstack/nova master: Send traits to ironic on server boot https://review.openstack.org/508116 | 19:26 |
openstackgerrit | Mark Goddard proposed openstack/nova master: Add get_traits() method to ComputeDriver https://review.openstack.org/532290 | 19:26 |
openstackgerrit | Mark Goddard proposed openstack/nova master: Implement get_traits() for the ironic virt driver https://review.openstack.org/532288 | 19:26 |
efried | https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L296-L302 | 19:26 |
mriedem | and i think that's around when glance is being upgraded/restarted | 19:26 |
*** penick has joined #openstack-nova | 19:26 | |
mriedem | maybe some weird uwsgi stuff? | 19:26 |
efried | edleafe jaypipes sdague The bug is that e.g. [] is a valid json payload. | 19:27 |
sdague | efried: nice | 19:27 |
jaypipes | efried: sure, I suppose. though I prefer DELETE :) | 19:28 |
sean-k-mooney | mriedem: http://logs.openstack.org/36/509336/31/check/ironic-grenade-dsvm-multinode-multitenant/6da9163/logs/apache/error.txt.gz | 19:28 |
sean-k-mooney | keysonten is dead from 5:47 | 19:28 |
*** itlinux has quit IRC | 19:28 | |
efried | jaypipes No DELETE API for aggs :( | 19:29 |
owalsh | dansmith: hey, hitting an issue with cell_v2 setup https://bugs.launchpad.net/nova/+bug/1744780 | 19:29 |
openstack | Launchpad bug 1744780 in tripleo "Nova::Cell_v2::Simple_setup/Nova_cell_v2[cell0] fails on master promote" [Critical,Triaged] | 19:29 |
jaypipes | efried: ooh, yeah... | 19:29 |
mriedem | [Thu Jan 18 05:50:49.905807 2018] [wsgi:warn] [pid 30759:tid 139966291453824] mod_wsgi: Compiled for Python/2.7.11. | 19:29 |
efried | fixing | 19:29 |
jaypipes | efried: prolly should have one, but yeah | 19:29 |
mriedem | [Thu Jan 18 05:50:49.905865 2018] [wsgi:warn] [pid 30759:tid 139966291453824] mod_wsgi: Runtime using Python/2.7.12. | 19:29 |
*** sree has quit IRC | 19:30 | |
mriedem | mtreinish: is anything using this code yet? https://review.openstack.org/#/c/531493/ | 19:31 |
mriedem | i guess not https://review.openstack.org/#/c/531498/ | 19:31 |
melwitt | owalsh: that's a recent change that we're not allowing creation/update of a cell with a DB connection + transport URL combination that already exists | 19:33 |
owalsh | melwitt: yea, but it's not removing the target cell from the cells it checks for dups | 19:34 |
owalsh | melwitt: so it fails on itself | 19:34 |
melwitt | hm | 19:34 |
*** mgoddard has quit IRC | 19:36 | |
* owalsh biab | 19:36 | |
*** mgoddard has joined #openstack-nova | 19:36 | |
efried | jaypipes edleafe sdague https://bugs.launchpad.net/nova/+bug/1744786 FYI | 19:37 |
openstack | Launchpad bug 1744786 in OpenStack Compute (nova) "SchedulerReportClient.put with empty (not None) payload errors 415" [Undecided,New] | 19:37 |
jroll | mriedem: looks like n-cpu is because we shut down ironic-api while upgrading things (which seems weird to me, but) | 19:40 |
jroll | http://logs.openstack.org/36/509336/31/check/ironic-grenade-dsvm-multinode-multitenant/6da9163/logs/grenade.sh.txt.gz#_2018-01-18_05_44_56_948 | 19:40 |
*** itlinux has joined #openstack-nova | 19:43 | |
*** pcaruana has quit IRC | 19:43 | |
*** sree has joined #openstack-nova | 19:45 | |
melwitt | owalsh: I see what you mean. so the case you're hitting is trying to update_cell with only one of DB connection or transport URL being different then? | 19:46 |
dansmith | melwitt: yeah I expect so | 19:46 |
*** itlinux has quit IRC | 19:46 | |
*** fragatina has joined #openstack-nova | 19:47 | |
melwitt | yeah, just looking at the unit tests and the case of both being different should go through. guh | 19:47 |
dansmith | melwitt: er, what I meant was I think they're likely just running update_cell all the time, expecting it to be idempotent | 19:47 |
dansmith | so it might not be different, but the pre-check finds an existing (identical) record and so it fails | 19:48 |
melwitt | oh, I see | 19:48 |
dansmith | where it should only fail if they set cell1 to the same thing as cell2 | 19:48 |
* melwitt nods | 19:48 | |
mriedem | stephenfin: jaypipes: i don't see the reason for this change at all https://review.openstack.org/#/c/534849/ | 19:49 |
mriedem | those tests all default to send 2.1 so explicitly hard-coding something isn't necessary | 19:50 |
*** sree has quit IRC | 19:50 | |
melwitt | dansmith: do you want to cook up a patch for that or should I? | 19:51 |
dansmith | melwitt: grilling one currently | 19:51 |
melwitt | sweet | 19:51 |
jaypipes | mriedem: that was originally in one of jackie's other patches that was unrelated and I had asked her to split it out. | 19:53 |
*** suresh12 has quit IRC | 19:54 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Report Client: PUT empty (not None) JSON data https://review.openstack.org/536545 | 19:54 |
efried | sdague jaypipes dansmith ^ | 19:54 |
efried | Would rather not put it in the dep chain of the update_provider_tree series, but it's gonna foul my test cases for update_from_provider_tree (which is how I found it) | 19:54 |
mriedem | jaypipes: ok | 19:54 |
jaypipes | mriedem: without it, patches that test the new certificates REST API functionality were failing due to the personality stuff still being around for some reason | 19:54 |
mriedem | new tests should have just overrode the personality files stuff rather than need to hack up old tests | 19:55 |
mriedem | and...the mailman is stuck outside my house | 19:56 |
openstackgerrit | Sen Yang proposed openstack/python-novaclient master: Implement hypervisor hostname exact patten match for server cold migrate https://review.openstack.org/520187 | 19:56 |
mriedem | he knows i work from home, so i guess i have to suit up now | 19:56 |
* efried admires mriedem for letting the mailman hang out for an extra few seconds while he updates us. | 19:56 | |
*** slaweq has joined #openstack-nova | 19:57 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Fix update_cell to ignore existing identical cells https://review.openstack.org/536546 | 19:59 |
dansmith | melwitt: owalsh: ^ | 19:59 |
*** dave-mcc_ is now known as dave-mcowan | 19:59 | |
*** dave-mcowan is now known as dave-mccowan | 19:59 | |
*** dave-mccowan is now known as dave-mcc_ | 20:00 | |
*** jmlowe has quit IRC | 20:00 | |
*** namnh has joined #openstack-nova | 20:02 | |
*** armax has quit IRC | 20:02 | |
*** namnh has quit IRC | 20:03 | |
*** namnh has joined #openstack-nova | 20:03 | |
*** armax has joined #openstack-nova | 20:03 | |
*** suresh12_ has joined #openstack-nova | 20:04 | |
*** harlowja has joined #openstack-nova | 20:04 | |
*** jmlowe has joined #openstack-nova | 20:06 | |
*** chyka has joined #openstack-nova | 20:06 | |
*** namnh has quit IRC | 20:07 | |
*** armax has quit IRC | 20:08 | |
openstackgerrit | Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436 | 20:09 |
edleafe | mriedem: ^^ responded to your comments | 20:09 |
*** sree has joined #openstack-nova | 20:12 | |
*** amodi has quit IRC | 20:13 | |
dansmith | melwitt: I think you meant assertFalse() when you pointed out my mind-o | 20:13 |
openstackgerrit | Dan Smith proposed openstack/nova master: Fix update_cell to ignore existing identical cells https://review.openstack.org/536546 | 20:14 |
dansmith | melwitt: I had another bug in the test that that uncovered, but the functional code worked thankfully | 20:14 |
melwitt | dansmith: yes, heh. I was thinking 0 == no error == True for some reason | 20:14 |
dansmith | aye | 20:15 |
*** Drankis has quit IRC | 20:15 | |
mtreinish | mriedem: yeah, not yet. But I need get that landed in glance soon | 20:15 |
*** kwathore_ has joined #openstack-nova | 20:16 | |
*** sree has quit IRC | 20:17 | |
*** suresh12_ has quit IRC | 20:19 | |
*** kwathore has quit IRC | 20:20 | |
*** suresh12 has joined #openstack-nova | 20:20 | |
mtreinish | mriedem: were you looking to use that option for something? | 20:22 |
*** avolkov has quit IRC | 20:23 | |
*** amodi has joined #openstack-nova | 20:26 | |
*** moshele has quit IRC | 20:27 | |
*** penick has quit IRC | 20:32 | |
*** namnh_ has joined #openstack-nova | 20:32 | |
*** mhenkel_ has quit IRC | 20:32 | |
*** mjturek has quit IRC | 20:33 | |
*** namnh_ has quit IRC | 20:33 | |
*** namnh_ has joined #openstack-nova | 20:33 | |
*** johnthetubaguy has quit IRC | 20:33 | |
*** jcosmao has joined #openstack-nova | 20:36 | |
*** itlinux has joined #openstack-nova | 20:38 | |
*** smatzek has quit IRC | 20:38 | |
*** mhenkel has joined #openstack-nova | 20:39 | |
*** jmlowe has quit IRC | 20:39 | |
*** johnthetubaguy has joined #openstack-nova | 20:40 | |
*** awaugama has quit IRC | 20:40 | |
*** jcosmao has left #openstack-nova | 20:41 | |
*** pooja has joined #openstack-nova | 20:41 | |
*** sree has joined #openstack-nova | 20:44 | |
*** namnh_ has quit IRC | 20:45 | |
owalsh | melwitt, dansmith: LTGM, thanks! | 20:45 |
*** r-daneel has quit IRC | 20:46 | |
*** sree has quit IRC | 20:49 | |
*** gszasz has quit IRC | 20:51 | |
ildikov | gibi: johnthetubaguy: mriedem: thank you!!! :) | 20:52 |
bauzas | mriedem: dansmith: gibi: rebased https://review.openstack.org/#/c/533642/ for cdent's comments about relnotes | 20:53 |
*** mhenkel has quit IRC | 20:54 | |
*** andreas_s has joined #openstack-nova | 20:56 | |
*** suresh12 has quit IRC | 20:58 | |
*** liverpooler has quit IRC | 20:59 | |
*** mhenkel has joined #openstack-nova | 21:00 | |
*** andreas_s has quit IRC | 21:00 | |
*** Tom-Tom has joined #openstack-nova | 21:03 | |
openstackgerrit | Eric Berglund proposed openstack/nova master: Add PowerVM to feature-classification https://review.openstack.org/533237 | 21:03 |
*** r-daneel has joined #openstack-nova | 21:04 | |
*** sree has joined #openstack-nova | 21:04 | |
*** mhenkel has quit IRC | 21:04 | |
*** dave-mcc_ has quit IRC | 21:05 | |
*** penick has joined #openstack-nova | 21:05 | |
*** suresh12 has joined #openstack-nova | 21:06 | |
mriedem | mtreinish: no, trying to figure out why the ironic multinode grenade job starting having random seg faults since 1/17 | 21:06 |
*** mhenkel has joined #openstack-nova | 21:06 | |
pooja | Hello! Is it possible to use the Placement API in Newton with a non-cells deployment? | 21:06 |
mriedem | pooja: yes | 21:07 |
pooja | mriedem: Thanks! I am trying to go from Newton non-cells to Pike release with cells v2. | 21:07 |
*** Tom-Tom has quit IRC | 21:08 | |
*** jackie-truong has joined #openstack-nova | 21:08 | |
pooja | So adding placement api in Newton and then upgrading packages to Pike and creating nova_cell0 and nova_cell1 databases would work? | 21:08 |
*** sree has quit IRC | 21:09 | |
mriedem | pooja: placement and cells v2 don't really have anything to do with each other, so yes that should be fine | 21:09 |
pooja | ah okay, thanks! My understanding was it needed a cell for filtering hosts. | 21:09 |
mriedem | no placement doesn't know anything about nova internals | 21:13 |
mriedem | or deployment setup like cellsv2 | 21:13 |
dansmith | and cells are not visible outside nova | 21:13 |
*** esberglu has quit IRC | 21:16 | |
*** esberglu has joined #openstack-nova | 21:16 | |
mriedem | jesus tempest-full is now 2 hours long | 21:17 |
mriedem | well maybe depends on the node you land on | 21:18 |
mriedem | rax dfw must be nice and slow | 21:19 |
melwitt | yeah, I was about to say we've been getting lots more job run fails related to timeouts, and I'm not sure if it's about the nodes or if it's about tempest run time creeping over the timeout line | 21:19 |
*** esberglu_ has joined #openstack-nova | 21:19 | |
mriedem | one tempest-full i saw was 2 hours and 8 minutes, another was 1 hour and 20 minutes | 21:20 |
melwitt | ah, okay | 21:20 |
*** esberglu has quit IRC | 21:20 | |
*** sahid has quit IRC | 21:21 | |
*** sahid has joined #openstack-nova | 21:22 | |
mriedem | seeing rpc messaging timeouts in cinder logs too on rax dfw | 21:25 |
*** suresh12 has quit IRC | 21:26 | |
*** jaypipes has quit IRC | 21:27 | |
*** amodi has quit IRC | 21:28 | |
openstackgerrit | Carlos Goncalves proposed openstack/os-vif master: [DNM] vif_plug_ovs: add should_provide_port https://review.openstack.org/533713 | 21:28 |
*** dave-mccowan has joined #openstack-nova | 21:30 | |
*** armax has joined #openstack-nova | 21:32 | |
*** jmlowe has joined #openstack-nova | 21:34 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Start moving users of parted to privsep. https://review.openstack.org/519011 | 21:37 |
*** jaypipes has joined #openstack-nova | 21:40 | |
*** suresh12 has joined #openstack-nova | 21:40 | |
*** gszasz has joined #openstack-nova | 21:44 | |
*** lpetrut has joined #openstack-nova | 21:47 | |
*** jaypipes has quit IRC | 21:49 | |
*** gszasz has quit IRC | 21:50 | |
*** gszasz has joined #openstack-nova | 21:50 | |
*** edmondsw has quit IRC | 21:52 | |
*** dave-mccowan has quit IRC | 21:52 | |
*** dave-mcc_ has joined #openstack-nova | 21:52 | |
hongbin | mriedem: hi matt, a question. i am looking at this bug: https://bugs.launchpad.net/neutron/+bug/1723026 , the use case there seems to require nova to add an api to support filter instances by floating ip. do you know if it makes sense to have this api in nova? | 21:53 |
openstack | Launchpad bug 1723026 in neutron "[RFE]Support get device_ids from floatingips" [Wishlist,Confirmed] - Assigned to Hongbin Lu (hongbin.lu) | 21:53 |
*** liverpooler has joined #openstack-nova | 21:58 | |
*** yamahata has joined #openstack-nova | 22:00 | |
*** pchavva has quit IRC | 22:01 | |
*** mvenesio has quit IRC | 22:06 | |
*** yamahata has quit IRC | 22:11 | |
mriedem | hongbin: that doesn't seem like a nova api change, sounds like a neutron api change | 22:11 |
mriedem | hongbin: nova has deprecated all of it's floating IP related APIs since they were just proxies to neutron and nova-network is deprecated | 22:13 |
*** jaosorior has quit IRC | 22:13 | |
hongbin | mriedem: ack, i see | 22:13 |
mriedem | hongbin: is that RFE asking that GET /servers adds a query parameter to filter instances by floating IP substring? like the "ip" filter which filters on the fixed IP? | 22:14 |
hongbin | mriedem: thanks for the remarks | 22:14 |
hongbin | mriedem: per my understanding, yes | 22:14 |
*** mvk has joined #openstack-nova | 22:15 | |
hongbin | mriedem: but if nova thinks this doesn't make sense, i need to re-discuss this ref in neutron | 22:15 |
mriedem | well, i could see the floatingip filter param to GET /servers maybe, but it's just another proxy; | 22:16 |
mriedem | the best thing is probably to add something to neutron to allow filtering ports by floating IP substring? | 22:16 |
*** slaweq has quit IRC | 22:17 | |
hongbin | yes, if nova is removing proxies to neutron, then this request doesn't seem to fit into the scope | 22:17 |
hongbin | yes, this can be done | 22:18 |
*** openstackgerrit has quit IRC | 22:18 | |
hongbin | however, the question from neutron team is if this will be used by nova | 22:19 |
mriedem | it won't, | 22:19 |
*** rcernin has joined #openstack-nova | 22:19 | |
mriedem | unless we plumb something into the compute API to proxy that through when listing servers | 22:19 |
hongbin | yes, get it | 22:19 |
hongbin | mlavalle: ping, fyi (above) | 22:20 |
*** sree has joined #openstack-nova | 22:20 | |
mriedem | if the requestor says, "well then i get the device_id from the port(s) and then i have to call the compute API to get server details and that's too much work" then i'd ask what they need from the server details beyond just the server uuid | 22:20 |
*** openstackgerrit has joined #openstack-nova | 22:21 | |
openstackgerrit | Merged openstack/nova master: libvirt: Collocate encryptor and volume driver calls https://review.openstack.org/460243 | 22:21 |
openstackgerrit | Merged openstack/nova master: libvirt: Introduce disk encryption config classes https://review.openstack.org/464008 | 22:21 |
openstackgerrit | Merged openstack/nova master: [api] Allow multi-attach in compute api https://review.openstack.org/271047 | 22:22 |
efried | mriedem dansmith Easy fix, one +2 already, can I get a quick look please? https://review.openstack.org/#/c/536545/ | 22:22 |
hongbin | mriedem: my understanding is that they want a new filter in nova (i.e. nova list --floating-ip <xxx>), and under the hook, nova calls neutron api with the device_id to query the floating ips | 22:23 |
hongbin | and the addition of device_id in neutron side is for nova to query the floating ips fast | 22:24 |
*** lpetrut has quit IRC | 22:24 | |
mriedem | hongbin: we do'nt know the device_id until we get the ports, which would be filtered by the floating IP the user passes in | 22:24 |
mriedem | right? | 22:24 |
*** amodi has joined #openstack-nova | 22:24 | |
*** sree has quit IRC | 22:25 | |
*** lpetrut has joined #openstack-nova | 22:25 | |
hongbin | mriedem: yes, so the proposal said "make the device_id of floating ip same as the instance uuid" | 22:26 |
hongbin | then, nova uses the uuid as the device_id to query | 22:26 |
hongbin | s/uuid/instance uuid/ | 22:27 |
mriedem | umm | 22:27 |
*** claudiub has quit IRC | 22:27 | |
mriedem | so (1) list all instances, (2) then call neutron with all of those instance uuids to get the ports AND also filter the floating IPs from that list of ports by the provided floating IP substring match? | 22:28 |
mriedem | the port.device_id is the same as the instance uuid already | 22:29 |
mriedem | the port and floating IP have a relationship somewhere | 22:29 |
mriedem | so if you can list/filter ports by floating IP, you can build a list of server uuids | 22:29 |
sean-k-mooney | mriedem: i think the owner of teh floating ip in neutron is the port uuid | 22:29 |
*** lpetrut has quit IRC | 22:30 | |
sean-k-mooney | so really what you want to do is say neutron give be the owner of the port that has this uuid | 22:30 |
*** lpetrut has joined #openstack-nova | 22:30 | |
sean-k-mooney | * floating ip | 22:30 |
hongbin | (2) is performed only if users insert the --floating-ip filter when listing the instances | 22:31 |
*** lyan has quit IRC | 22:33 | |
*** jackie-truong has quit IRC | 22:34 | |
hongbin | mriedem: yes, it is confusing, i will ask the bug reportor to clarify | 22:36 |
mriedem | if the request is just, "do the same thing as the ip filter but for floating ips when listing instances" then that's easy to understand | 22:38 |
mriedem | the ip filter works on fixed ips, the floating ip filter (being requested) works on floating ips | 22:38 |
sean-k-mooney | hongbin: mriedem this is the basic workflow today http://paste.openstack.org/show/650595/ | 22:38 |
*** smatzek has joined #openstack-nova | 22:38 | |
*** jaosorior has joined #openstack-nova | 22:39 | |
sean-k-mooney | the device id of the neutron port is the nova instance id so today tyou do a floating ip show by it ip then get the port_id it is bound to look up the port and then get the device id of the port | 22:40 |
mriedem | sean-k-mooney: the floating IP has a fixed IP on it | 22:40 |
mriedem | so, | 22:40 |
mriedem | nova list --ip 172.20.50.10 | 22:40 |
mriedem | done | 22:40 |
sean-k-mooney | the fixed ips can overlap | 22:40 |
*** sahid has quit IRC | 22:40 | |
sean-k-mooney | e.g. one tenant can have two networks with the same subnet | 22:41 |
mriedem | i have a request, | 22:41 |
mriedem | can one of you hand me that shotgun in the corner? | 22:41 |
sean-k-mooney | if its any concilation the floating ip has to be unique. i think... | 22:42 |
*** smatzek has quit IRC | 22:43 | |
sean-k-mooney | mriedem: if the floating ip show included the device id direclty would that work for you | 22:43 |
mriedem | sean-k-mooney: any of this being handled outside of nova works for me | 22:44 |
sean-k-mooney | then its jsut nova show ${device-id} | 22:44 |
sean-k-mooney | well to be honest its only 3 command today | 22:44 |
*** sahid has joined #openstack-nova | 22:44 | |
sean-k-mooney | i can proably make that a 1 liner with fome bash foo | 22:44 |
mriedem | so is creating a volume of a specific type and then creating a server from that volume, but people have always wanted to proxy through the volume type for boot from volume | 22:45 |
sean-k-mooney | i think the real issue is if you support regex or partical matches on the ip in stead of exact match | 22:45 |
mriedem | because bash is hard | 22:45 |
sean-k-mooney | mriedem: thats fair was the original request to do this in the client or api | 22:46 |
hongbin | the scalability is also an issue, i.e. how to list the instances with a specific floating ip when there are thousands of instances | 22:46 |
*** lpetrut has quit IRC | 22:47 | |
melwitt | mriedem: easy fix for 'nova-manage cell_v2 update_cell' where it wasn't excluding 'self' in its search for duplicate DB connection or transport URL https://review.openstack.org/#/c/536546/ | 22:48 |
mriedem | sean-k-mooney: the api | 22:48 |
mriedem | hongbin: if you filter the ports by the floating ip first, then you've already narrowed down the instances because the port has the device_id | 22:49 |
*** sahid has quit IRC | 22:49 | |
hongbin | mriedem: i see, if what they want is one instance, then it is not a problem | 22:50 |
hongbin | if they want a list instances with a floating ip prefix, then it is | 22:50 |
sean-k-mooney | hongbin: well the oneline is openstack server show $(openstack port show $(openstack ip floating show 172.20.64.168 --column port_id -f value) -f value --column device_id) but yes you would have to call this for all instance in the prfix in a loop | 22:51 |
*** suresh12 has quit IRC | 22:51 | |
hongbin | sean-k-mooney: ack | 22:51 |
sean-k-mooney | so ideally you would extend floating ip list to accpet a cider to match agenst | 22:51 |
*** suresh12 has joined #openstack-nova | 22:52 | |
sean-k-mooney | and also add the device id to the floating ip so you can just do a show on the nova instance that the end | 22:52 |
dansmith | efried: got it | 22:53 |
*** dikonoor has joined #openstack-nova | 22:53 | |
mriedem | melwitt: ack; currently trudging through internal email backlog of misery | 23:00 |
sean-k-mooney | hongbin: mriedem looking at https://developer.openstack.org/api-ref/network/v2/#list-floating-ips | 23:01 |
sean-k-mooney | hongbin: mriedem what we really want in the neutron api is the ablity to do /v2.0/floatingips/?floatingip=<cidr>&fields=device_id | 23:01 |
sean-k-mooney | the blocker being current floatingip=<cidr> has to be an exact match not a cider and the port device_id is not returned as part of the floating_ip object | 23:02 |
hongbin | sean-k-mooney: yes, agree | 23:03 |
*** liverpooler has quit IRC | 23:04 | |
hongbin | if neutron supports matching floating ip prefix, and adding the device_id to the floating ip resource, it seems to resolve the problem | 23:04 |
efried | dansmith Thank you sir. Now if we can just get zuul to cooperate | 23:05 |
dansmith | good luck | 23:05 |
efried | ikr. It's been awful last couple weeks. | 23:05 |
sean-k-mooney | hongbin: based on http://specs.openstack.org/openstack/neutron-specs/specs/api/networking_general_api_information.html#filtering-and-column-selection they already support some simple filtering so addign cidr support should be possible instead of exact match | 23:06 |
hongbin | sean-k-mooney: yes, technically, it is an easy job | 23:08 |
*** eharney has quit IRC | 23:09 | |
sean-k-mooney | well you say that but it depends on where the filtering is done. if its in sql whic i would guess it is based on what is currently supported that less trivial | 23:09 |
hongbin | i think what needs to be done in neutron side is to change the sql query from '==' to 'like' | 23:11 |
hongbin | e.g. input==<exact_floating_ip> to input.like('%floating_ip_substring%') | 23:12 |
sean-k-mooney | hongbin: if you wnat to suport queries like all fluting ips containing "192.168" yes but you cant say all floating ips in 192.168.1.0/24 | 23:13 |
sean-k-mooney | im not sure what the original goal was | 23:13 |
hongbin | yes, i also a bit confusing, asking my colleague to clarify | 23:14 |
*** yasemin has quit IRC | 23:14 | |
sean-k-mooney | adding the device_id to the floating ip need a change to the floating ip api which i think is defiended in neutron-lib and that cant be reved until rocky as we are past the non-client lib freeze | 23:14 |
hongbin | yes, know that | 23:15 |
sean-k-mooney | hongbin: i was just checking for my own sake but this is what would have to be modified https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/l3.py#L103-L137 | 23:16 |
hongbin | sean-k-mooney: like this https://review.openstack.org/#/c/534882/1/neutron_lib/api/definitions/fip_device_id.py ? | 23:18 |
*** AlexeyAbashkin has joined #openstack-nova | 23:18 | |
hongbin | so i already have a poc for that | 23:18 |
sean-k-mooney | hongbin: oh haha yes exactly like that :) | 23:19 |
hongbin | :) | 23:19 |
sean-k-mooney | hongbin: so ya all that is missing then is adding support for a partial match on the floating ip so input==<exact_floating_ip> to input.like('%floating_ip_substring%') as you said above | 23:21 |
*** vladikr has quit IRC | 23:22 | |
hongbin | yes, and also need a clear picture that how nova will use it | 23:22 |
*** mlavalle has quit IRC | 23:23 | |
*** AlexeyAbashkin has quit IRC | 23:23 | |
sean-k-mooney | prosumably nova would call /v2.0/floatingips/?floatingip=<ip substing>&fields=device_id then do a a server list for each insance uuid returned. | 23:23 |
sean-k-mooney | but mriedem could comment on that better then i ^ | 23:24 |
mriedem | i think i said that like an hour ago | 23:25 |
mriedem | "do the same thing as the ip filter but with a floating ip" | 23:25 |
mriedem | question was why does nova need to add this proxy filter support at all | 23:25 |
*** vladikr has joined #openstack-nova | 23:25 | |
*** betherly has quit IRC | 23:26 | |
*** kmalloc has quit IRC | 23:26 | |
*** DuncanT has quit IRC | 23:26 | |
*** icey has quit IRC | 23:26 | |
*** catmando has quit IRC | 23:26 | |
*** andrewbogott has quit IRC | 23:26 | |
*** rajinir has quit IRC | 23:26 | |
*** gregwork has quit IRC | 23:27 | |
*** catmando has joined #openstack-nova | 23:27 | |
*** betherly has joined #openstack-nova | 23:27 | |
*** Hazelesque has quit IRC | 23:27 | |
*** kmalloc has joined #openstack-nova | 23:27 | |
*** icey has joined #openstack-nova | 23:27 | |
*** andrewbogott has joined #openstack-nova | 23:27 | |
*** rajinir has joined #openstack-nova | 23:27 | |
*** suresh12 has quit IRC | 23:27 | |
*** gregwork has joined #openstack-nova | 23:27 | |
*** lennyb has quit IRC | 23:27 | |
*** DuncanT has joined #openstack-nova | 23:27 | |
sean-k-mooney | i think when this came up in the ptg i liked the idea of the neutorn change but fealt the nova change did not need to be in the api and could be in the client | 23:27 |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Add support for microversion 2.60 - volume multiattach https://review.openstack.org/536621 | 23:27 |
*** Adri2000 has quit IRC | 23:28 | |
*** Guest78703 has quit IRC | 23:28 | |
*** lennyb has joined #openstack-nova | 23:28 | |
mriedem | sean-k-mooney: this floating ip filtering thing didn't come up in denver | 23:28 |
mriedem | at least that i can recall - we talked about how to improve the performance of the *existing* ip filter when listing instances | 23:29 |
*** Adri2000 has joined #openstack-nova | 23:29 | |
*** Hazelesque has joined #openstack-nova | 23:29 | |
mriedem | and that's done: https://review.openstack.org/#/c/525505/ | 23:29 |
sean-k-mooney | mriedem: are you sure im pretty sure i asked migle about adding the api change to neutron in dever | 23:29 |
sean-k-mooney | mriedem: oh maybe that is what im thinking about | 23:30 |
*** suresh12 has joined #openstack-nova | 23:31 | |
sean-k-mooney | mriedem: so this is the same just adding support for floating ip | 23:31 |
mriedem | sounds like it yes | 23:31 |
mriedem | melwitt: dansmith: so on https://review.openstack.org/#/c/536546/ we're just wanting to like change the name of an existing cell right? | 23:34 |
dansmith | mriedem: or puppet is just running update_cell all the time because that's how it works | 23:34 |
dansmith | s/all the/every/ | 23:35 |
*** Guest78703 has joined #openstack-nova | 23:35 | |
dansmith | like, there's probably a piece of puppet that says "ensure that cell0 has db url $foo and mq url $bar" and they just run update_cell blindly | 23:35 |
melwitt | mriedem: yeah, the update name would be one but the situation reported in the bug was that update_cell is not idempotent | 23:35 |
mriedem | alright | 23:36 |
melwitt | I think it would also fail if you wanted to change only one of DB connection or transport URL with update_cell | 23:36 |
dansmith | right | 23:36 |
dansmith | well, | 23:36 |
dansmith | no, I think it shouldn't because that wouldn't match one of the existing ones right? | 23:36 |
*** suresh12 has quit IRC | 23:37 | |
melwitt | it would match one of them with itself (before the fix) I think | 23:37 |
dansmith | oh you're right, it's an or | 23:37 |
dansmith | so yeah | 23:37 |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP: SchedulerReportClient.update_from_provider_tree https://review.openstack.org/533821 | 23:38 |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 23:38 |
openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | 23:38 |
openstackgerrit | Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517 | 23:38 |
openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.get_provider_uuids: Top-down ordering https://review.openstack.org/536624 | 23:38 |
openstackgerrit | Eric Fried proposed openstack/nova master: set_{aggregates|traits}_for_provider: tolerate set https://review.openstack.org/536625 | 23:38 |
sean-k-mooney | mriedem: this makes me sad https://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_instance_pci_requests.py#L26-L53 device_id should be product_id according to https://github.com/openstack/nova/blob/master/doc/source/admin/pci-passthrough.rst and other tests | 23:38 |
melwitt | yeah. historically it was an 'and' but recently it was changed to an 'or' since global MQ can't be a thing anyway and each cell should have unique DB and transport URL combo | 23:38 |
sean-k-mooney | mriedem: unless wew chanded for device_id to product id a some point. those thest have been using incorrect mocks for 3 years | 23:39 |
mriedem | sean-k-mooney: that's a pci request, not a port | 23:39 |
mriedem | or you're just talking about something different and i have no idea | 23:40 |
sean-k-mooney | mriedem: sorry yes this was what i was working on before the floating ip conversation | 23:40 |
melwitt | (corrects self) er, or there shouldn't be two cells with dupe DB connection or dupe MQ URL | 23:41 |
mriedem | sean-k-mooney: well you'll be happy to know it's just a json blob of whackiness so it doesn't matter https://github.com/openstack/nova/blob/master/nova/objects/instance_pci_requests.py#L32 | 23:41 |
openstackgerrit | Merged openstack/nova master: Generalize DB conf group copying https://review.openstack.org/484908 | 23:41 |
sean-k-mooney | mriedem: thats what im changing at stephenfin request | 23:41 |
openstackgerrit | Merged openstack/nova master: Recreate mediated devices on reboot https://review.openstack.org/533642 | 23:42 |
sean-k-mooney | mriedem: which is why my tests are failing because i dont allow device id since the spec says it product_id | 23:42 |
mriedem | ok | 23:43 |
mriedem | ... | 23:43 |
sean-k-mooney | mriedem: im reworking https://review.openstack.org/#/c/449257 with stephenfin comments since rodolfo had to move on to opnfv work | 23:43 |
openstackgerrit | melanie witt proposed openstack/nova master: Detach volume after deleting instance with no host https://review.openstack.org/340614 | 23:44 |
sean-k-mooney | i think this is really just at test bug but it still hurts to look at the git blame. anyway i think ill get back to this in the morning since its almost midnight my time | 23:45 |
*** penick has quit IRC | 23:46 | |
*** efried is now known as efried_back_wed | 23:46 | |
*** suresh12 has joined #openstack-nova | 23:50 | |
*** takashin has joined #openstack-nova | 23:52 | |
*** liverpooler has joined #openstack-nova | 23:55 | |
*** openstack has quit IRC | 23:55 | |
*** openstack has joined #openstack-nova | 23:57 | |
*** ChanServ sets mode: +o openstack | 23:57 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!