| *** mvk has joined #openstack-nova | 00:02 | |
| *** jangutter has joined #openstack-nova | 00:03 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: New-style _set_inventory_for_provider https://review.openstack.org/537648 | 00:04 |
|---|---|---|
| openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.update_from_provider_tree https://review.openstack.org/533821 | 00:04 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 00:04 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | 00:04 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517 | 00:04 |
| *** jangutter has quit IRC | 00:08 | |
| *** hoonetorg has quit IRC | 00:10 | |
| jaypipes | efried: the client should just know it's an *atomically* increasing integer that, if it changed from the client's previous view of the generation, should trigger a re-read of the expected state. | 00:11 |
| *** AlexeyAbashkin has joined #openstack-nova | 00:11 | |
| jaypipes | (and now I have to leave, I'm sorry :( | 00:11 |
| efried | jaypipes Have a good one. | 00:11 |
| Spazmotic | see ya jay | 00:11 |
| Spazmotic | Just waking up and drinking my coffee and getting ready for hte gym.. whew | 00:11 |
| *** AlexeyAbashkin has quit IRC | 00:15 | |
| *** edmondsw has joined #openstack-nova | 00:19 | |
| *** edmondsw has quit IRC | 00:23 | |
| *** acormier has joined #openstack-nova | 00:24 | |
| *** acormier has joined #openstack-nova | 00:25 | |
| *** hiro-kobayashi has joined #openstack-nova | 00:27 | |
| *** takedakn has joined #openstack-nova | 00:28 | |
| *** hoonetorg has joined #openstack-nova | 00:30 | |
| *** edmondsw has joined #openstack-nova | 00:31 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform instance.resize_prep notification https://review.openstack.org/465081 | 00:32 |
| *** edmondsw has quit IRC | 00:36 | |
| *** edmondsw has joined #openstack-nova | 00:37 | |
| *** chyka has quit IRC | 00:37 | |
| *** edmondsw has quit IRC | 00:41 | |
| *** SpazZz has joined #openstack-nova | 00:43 | |
| *** dave-mccowan has joined #openstack-nova | 00:43 | |
| *** edmondsw has joined #openstack-nova | 00:44 | |
| *** edmondsw has quit IRC | 00:45 | |
| *** edmondsw has joined #openstack-nova | 00:46 | |
| *** Spazmotic has quit IRC | 00:46 | |
| *** liuzz has joined #openstack-nova | 00:47 | |
| *** edmondsw has quit IRC | 00:50 | |
| *** gaoyan has joined #openstack-nova | 00:54 | |
| mnaser | mriedem: awesome stuff about osc-placement :D | 00:54 |
| *** tiendc has joined #openstack-nova | 00:57 | |
| *** jangutter has joined #openstack-nova | 00:57 | |
| *** gaoyan has quit IRC | 01:00 | |
| *** jangutter has quit IRC | 01:02 | |
| *** acormier has quit IRC | 01:04 | |
| *** phuongnh has joined #openstack-nova | 01:04 | |
| *** zhurong has joined #openstack-nova | 01:05 | |
| *** zhaochao has joined #openstack-nova | 01:12 | |
| *** phuongnh has quit IRC | 01:16 | |
| *** hoonetorg has quit IRC | 01:17 | |
| *** mdnadeem has joined #openstack-nova | 01:18 | |
| *** phuongnh has joined #openstack-nova | 01:19 | |
| *** hoonetorg has joined #openstack-nova | 01:21 | |
| *** dave-mccowan has quit IRC | 01:22 | |
| *** yangyapeng has quit IRC | 01:23 | |
| *** yangyapeng has joined #openstack-nova | 01:24 | |
| *** takashin has left #openstack-nova | 01:25 | |
| *** oomichi has joined #openstack-nova | 01:27 | |
| *** crushil has joined #openstack-nova | 01:27 | |
| *** takashin has joined #openstack-nova | 01:28 | |
| *** jangutter has joined #openstack-nova | 01:33 | |
| *** jangutter has quit IRC | 01:37 | |
| *** tianhui has joined #openstack-nova | 01:41 | |
| *** acormier has joined #openstack-nova | 01:43 | |
| *** acormier has quit IRC | 01:43 | |
| *** acormier has joined #openstack-nova | 01:44 | |
| oomichi | takashin: hi, still isn't https://review.openstack.org/#/c/533134/ favorite? | 01:46 |
| *** acormier_ has joined #openstack-nova | 01:46 | |
| *** acormier_ has joined #openstack-nova | 01:47 | |
| *** yikun_ has joined #openstack-nova | 01:47 | |
| takashin | oomichi: Hi. There are redirects. So the modification is not necessary. | 01:47 |
| *** hoangcx has joined #openstack-nova | 01:47 | |
| oomichi | takashin: do you see my comment? | 01:48 |
| *** bjolo has quit IRC | 01:49 | |
| *** acormier has quit IRC | 01:49 | |
| *** bjolo has joined #openstack-nova | 01:49 | |
| takashin | oomichi: Yes. but my patch was not just replacing http with https. | 01:49 |
| Yikun | gmann, https://review.openstack.org/#/c/534721/, hi, I saw your inline comments, so, should we add 2 config like project_network_cidr[1 & 2] to keep this? or some other idea? | 01:50 |
| oomichi | takashin: then, why did you change it even if there was a redirecting? | 01:50 |
| *** acormier has joined #openstack-nova | 01:51 | |
| *** tojuvone has quit IRC | 01:51 | |
| *** dave-mccowan has joined #openstack-nova | 01:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix bug case by none token context https://review.openstack.org/522112 | 01:54 |
| mriedem | efried: can you tell me if the release note i threw in here sounds ok? ^ | 01:54 |
| efried | ... | 01:54 |
| *** acormier_ has quit IRC | 01:54 | |
| *** acormier has quit IRC | 01:54 | |
| takashin | oomichi: My patch was changing 'pike' to 'queens'. Replaceing http with https was done at the same time, but it is not worth doing it separately. | 01:55 |
| efried | mriedem LGTM, +1 | 01:56 |
| oomichi | takashin: I am not sure why it is not worth doing it *separately* | 01:58 |
| efried | mriedem Course, you coulda addressed my nit, but meh. | 01:58 |
| efried | takashin Glad to catch you online. I've been wanting to tell you how much I appreciate your super-thorough code reviews. | 01:58 |
| efried | takashin ありがとうございました ;) | 01:59 |
| jose-phi_ | hi any idea | 02:00 |
| takashin | efied: You are welcome. | 02:00 |
| jose-phi_ | of why when i set data-port=br-ext:eno1 this interface got dead "eno1" | 02:00 |
| jose-phi_ | and this is my data network so i lost all connectivity to the compute node | 02:00 |
| takashin | oomichi: it is not worth doing it alone. | 02:01 |
| *** fragatina has quit IRC | 02:01 | |
| takashin | efried: You are welcome. | 02:02 |
| openstackgerrit | Eric Fried proposed openstack/nova master: set_{aggregates|traits}_for_provider: tolerate set https://review.openstack.org/536625 | 02:02 |
| openstackgerrit | Eric Fried proposed openstack/nova master: New-style _set_inventory_for_provider https://review.openstack.org/537648 | 02:02 |
| openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.update_from_provider_tree https://review.openstack.org/533821 | 02:02 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 02:02 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | 02:02 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517 | 02:02 |
| gmann | mriedem: let me rebase them, not all are required. i will do it today and let you know | 02:03 |
| *** tojuvone has joined #openstack-nova | 02:03 | |
| *** salv-orl_ has joined #openstack-nova | 02:04 | |
| *** chyka has joined #openstack-nova | 02:05 | |
| oomichi | takashin: I just don't want to see similar patches in the future even after dropping the patch | 02:05 |
| efried | d'oh | 02:05 |
| openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.get_provider_uuids: Top-down ordering https://review.openstack.org/536624 | 02:05 |
| openstackgerrit | Eric Fried proposed openstack/nova master: set_{aggregates|traits}_for_provider: tolerate set https://review.openstack.org/536625 | 02:05 |
| openstackgerrit | Eric Fried proposed openstack/nova master: New-style _set_inventory_for_provider https://review.openstack.org/537648 | 02:05 |
| openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.update_from_provider_tree https://review.openstack.org/533821 | 02:05 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 02:05 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | 02:05 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517 | 02:05 |
| takashin | oomichi: okay. I agree with the change. | 02:06 |
| *** salv-orlando has quit IRC | 02:07 | |
| *** gibi has quit IRC | 02:07 | |
| *** chyka has quit IRC | 02:09 | |
| *** tinwood has quit IRC | 02:10 | |
| takashin | oomichi: I voted +1 for the patch. | 02:10 |
| oomichi | takashin: thanks :-) | 02:11 |
| *** tinwood has joined #openstack-nova | 02:11 | |
| *** crushil has quit IRC | 02:12 | |
| *** zhurong has quit IRC | 02:14 | |
| *** fragatina has joined #openstack-nova | 02:14 | |
| *** gcb has joined #openstack-nova | 02:15 | |
| *** fragatina has quit IRC | 02:19 | |
| *** stakeda has joined #openstack-nova | 02:21 | |
| *** oomichi has quit IRC | 02:22 | |
| *** slaweq has joined #openstack-nova | 02:23 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Add CLI to show instance usage audit logs https://review.openstack.org/409413 | 02:25 |
| *** acormier has joined #openstack-nova | 02:26 | |
| *** hongbin has joined #openstack-nova | 02:27 | |
| *** jangutter has joined #openstack-nova | 02:27 | |
| *** slaweq has quit IRC | 02:27 | |
| *** acormier_ has joined #openstack-nova | 02:29 | |
| *** acormier_ has quit IRC | 02:29 | |
| *** acormier_ has joined #openstack-nova | 02:29 | |
| *** lyan has joined #openstack-nova | 02:30 | |
| *** jangutter has quit IRC | 02:31 | |
| *** acormier has quit IRC | 02:32 | |
| *** dave-mccowan has quit IRC | 02:33 | |
| *** acormier has joined #openstack-nova | 02:41 | |
| *** acormier_ has quit IRC | 02:45 | |
| *** suresh12 has quit IRC | 02:52 | |
| *** acormier has quit IRC | 02:53 | |
| *** acormier has joined #openstack-nova | 02:53 | |
| *** dave-mccowan has joined #openstack-nova | 02:54 | |
| *** acormier_ has joined #openstack-nova | 02:55 | |
| *** acormier has quit IRC | 02:59 | |
| *** hiro-kobayashi has quit IRC | 03:06 | |
| *** zhurong has joined #openstack-nova | 03:08 | |
| *** acormier_ has quit IRC | 03:09 | |
| alex_xu | mriedem: thanks, will cleanup in a follow up | 03:09 |
| *** acormier has joined #openstack-nova | 03:09 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge server create schema for availability zone extension https://review.openstack.org/451331 | 03:12 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge server create for availability zone extension https://review.openstack.org/502574 | 03:13 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Reduce complexity of _from_db_object https://review.openstack.org/537728 | 03:14 |
| alex_xu | mriedem: Kevin_Zheng, it would be great we add some testcase ensure the substring format can pass the regex format in the followup patch, since our API schema value the ip filter input with regex format. https://review.openstack.org/525505 | 03:16 |
| alex_xu | mriedem: Kevin_Zheng and, I'm curious how neutron side handle the different of 'like' in the different db | 03:17 |
| *** chyka has joined #openstack-nova | 03:19 | |
| Kevin_Zheng | alex_xu, sure | 03:20 |
| *** harlowja has quit IRC | 03:21 | |
| *** jangutter has joined #openstack-nova | 03:21 | |
| *** chyka has quit IRC | 03:23 | |
| *** acormier has quit IRC | 03:23 | |
| *** suresh12 has joined #openstack-nova | 03:23 | |
| *** armax has joined #openstack-nova | 03:24 | |
| *** jangutter has quit IRC | 03:25 | |
| *** zhurong_ has joined #openstack-nova | 03:27 | |
| *** takashin has quit IRC | 03:27 | |
| *** suresh12 has quit IRC | 03:28 | |
| Yikun | alex_xu, https://review.openstack.org/#/c/521683/21/neutron/plugins/ml2/plugin.py@1862, here is 'like' | 03:32 |
| *** openstackgerrit has quit IRC | 03:33 | |
| *** openstackgerrit has joined #openstack-nova | 03:34 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Reduce complexity of _from_db_object https://review.openstack.org/537728 | 03:34 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix missing marker functions https://review.openstack.org/514579 | 03:37 |
| *** yamamoto has joined #openstack-nova | 03:37 | |
| *** lyan has quit IRC | 03:38 | |
| *** takashin has joined #openstack-nova | 03:38 | |
| *** tbachman has quit IRC | 03:40 | |
| *** armax_ has joined #openstack-nova | 03:43 | |
| *** armax has quit IRC | 03:43 | |
| *** armax_ is now known as armax | 03:43 | |
| *** jackie-truong has joined #openstack-nova | 03:44 | |
| *** abhishekk has joined #openstack-nova | 03:44 | |
| *** annp has joined #openstack-nova | 03:49 | |
| *** namnh has joined #openstack-nova | 03:57 | |
| *** Spazmotic has joined #openstack-nova | 04:04 | |
| Spazmotic | Morning | 04:04 |
| *** janki has joined #openstack-nova | 04:09 | |
| *** links has joined #openstack-nova | 04:09 | |
| *** jangutter has joined #openstack-nova | 04:15 | |
| *** mdnadeem_ has joined #openstack-nova | 04:18 | |
| *** mdnadeem has quit IRC | 04:20 | |
| *** jangutter has quit IRC | 04:20 | |
| *** sree has joined #openstack-nova | 04:22 | |
| *** dave-mccowan has quit IRC | 04:24 | |
| *** bhujay has joined #openstack-nova | 04:28 | |
| *** harlowja has joined #openstack-nova | 04:28 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers.inc https://review.openstack.org/528201 | 04:30 |
| *** fragatina has joined #openstack-nova | 04:34 | |
| *** fragatina has quit IRC | 04:35 | |
| *** fragatina has joined #openstack-nova | 04:35 | |
| *** zhurong_ has quit IRC | 04:39 | |
| *** psachin has joined #openstack-nova | 04:42 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408 | 04:45 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 04:46 |
| *** claudiub has joined #openstack-nova | 04:48 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 04:51 |
| *** zhenguo has quit IRC | 04:54 | |
| *** bhujay has quit IRC | 04:54 | |
| *** bhujay has joined #openstack-nova | 04:55 | |
| openstackgerrit | Brooks Kaminski proposed openstack/nova master: XenAPI/Stops the migration of volume backed VHDS https://review.openstack.org/533168 | 04:57 |
| *** crushil has joined #openstack-nova | 04:58 | |
| *** ratailor has joined #openstack-nova | 05:07 | |
| *** jangutter has joined #openstack-nova | 05:10 | |
| *** sree has quit IRC | 05:10 | |
| *** chyka has joined #openstack-nova | 05:10 | |
| *** bhujay has quit IRC | 05:11 | |
| *** sree has joined #openstack-nova | 05:12 | |
| *** bhujay has joined #openstack-nova | 05:12 | |
| *** jangutter has quit IRC | 05:14 | |
| *** chyka has quit IRC | 05:15 | |
| *** sree has quit IRC | 05:16 | |
| *** harlowja has quit IRC | 05:17 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix missing 'if_notifications_enabled' decorator https://review.openstack.org/537745 | 05:18 |
| *** fragatina has quit IRC | 05:20 | |
| *** jaosorior has joined #openstack-nova | 05:23 | |
| *** hongbin has quit IRC | 05:25 | |
| openstackgerrit | Brooks Kaminski proposed openstack/nova master: XenAPI/Stops the migration of volume backed VHDS https://review.openstack.org/533168 | 05:27 |
| Spazmotic | My first rebase.. kind of scary | 05:27 |
| Spazmotic | things are puckered | 05:27 |
| *** salv-orlando has joined #openstack-nova | 05:31 | |
| *** salv-orl_ has quit IRC | 05:31 | |
| *** suresh12 has joined #openstack-nova | 05:32 | |
| *** sree has joined #openstack-nova | 05:33 | |
| *** sree has quit IRC | 05:37 | |
| *** gongysh has joined #openstack-nova | 05:41 | |
| *** yikun_ has quit IRC | 05:47 | |
| *** sridharg has joined #openstack-nova | 05:47 | |
| *** jackie-truong has quit IRC | 05:48 | |
| *** bhujay has quit IRC | 05:53 | |
| *** crushil has quit IRC | 05:54 | |
| alex_xu | Yikun: ah, thanks | 05:56 |
| *** bhujay has joined #openstack-nova | 06:03 | |
| *** jangutter has joined #openstack-nova | 06:04 | |
| *** bhujay has quit IRC | 06:08 | |
| *** jangutter has quit IRC | 06:08 | |
| *** sree has joined #openstack-nova | 06:09 | |
| *** xinliang has quit IRC | 06:09 | |
| *** suresh12 has quit IRC | 06:11 | |
| *** zhurong has quit IRC | 06:13 | |
| *** sree has quit IRC | 06:13 | |
| *** rcernin has quit IRC | 06:14 | |
| *** sree has joined #openstack-nova | 06:16 | |
| *** sree has quit IRC | 06:20 | |
| *** AlexeyAbashkin has joined #openstack-nova | 06:22 | |
| *** xinliang has joined #openstack-nova | 06:22 | |
| *** zhurong has joined #openstack-nova | 06:23 | |
| *** lajoskatona has joined #openstack-nova | 06:25 | |
| *** Spazmotic has quit IRC | 06:25 | |
| *** Spazmotic has joined #openstack-nova | 06:28 | |
| *** bhujay has joined #openstack-nova | 06:29 | |
| *** Spazmotic has quit IRC | 06:29 | |
| *** AlexeyAbashkin has quit IRC | 06:30 | |
| *** Spazmotic has joined #openstack-nova | 06:31 | |
| *** Eran_Kuris has joined #openstack-nova | 06:31 | |
| *** Spaz-Work has joined #openstack-nova | 06:37 | |
| *** Spazmotic has quit IRC | 06:39 | |
| *** sree has joined #openstack-nova | 06:40 | |
| *** Eran_Kuris has quit IRC | 06:41 | |
| *** Spaz-Work has quit IRC | 06:41 | |
| *** Spazmotic has joined #openstack-nova | 06:41 | |
| *** janki has quit IRC | 06:42 | |
| *** janki has joined #openstack-nova | 06:43 | |
| *** Eran_Kuris has joined #openstack-nova | 06:44 | |
| *** armax has quit IRC | 06:45 | |
| *** armax has joined #openstack-nova | 06:46 | |
| *** armax has quit IRC | 06:46 | |
| *** armax has joined #openstack-nova | 06:46 | |
| *** armax has quit IRC | 06:47 | |
| *** sree has quit IRC | 06:47 | |
| *** armax has joined #openstack-nova | 06:47 | |
| *** armax has quit IRC | 06:47 | |
| *** armax has joined #openstack-nova | 06:48 | |
| *** armax has quit IRC | 06:48 | |
| openstackgerrit | Merged openstack/nova master: add whereto for testing redirect rules https://review.openstack.org/516385 | 06:48 |
| *** armax has joined #openstack-nova | 06:49 | |
| *** armax has quit IRC | 06:49 | |
| *** armax has joined #openstack-nova | 06:49 | |
| *** armax has quit IRC | 06:50 | |
| *** sree has joined #openstack-nova | 06:51 | |
| *** markvoelker has quit IRC | 06:52 | |
| *** markvoelker has joined #openstack-nova | 06:53 | |
| *** vladikr has quit IRC | 06:54 | |
| *** vladikr has joined #openstack-nova | 06:54 | |
| *** sree has quit IRC | 06:55 | |
| *** bhujay has quit IRC | 06:57 | |
| *** markvoelker has quit IRC | 06:57 | |
| *** jangutter has joined #openstack-nova | 06:58 | |
| *** threestrands_ has quit IRC | 07:02 | |
| *** gouthamr has joined #openstack-nova | 07:02 | |
| *** jangutter has quit IRC | 07:02 | |
| *** bhujay has joined #openstack-nova | 07:03 | |
| *** tbachman has joined #openstack-nova | 07:03 | |
| *** tbachman has quit IRC | 07:05 | |
| *** vladikr has quit IRC | 07:06 | |
| *** vladikr has joined #openstack-nova | 07:06 | |
| *** tbachman has joined #openstack-nova | 07:09 | |
| *** avolkov has joined #openstack-nova | 07:10 | |
| *** takashin has left #openstack-nova | 07:11 | |
| *** phuongnh has quit IRC | 07:11 | |
| *** acormier has joined #openstack-nova | 07:14 | |
| *** acormier has joined #openstack-nova | 07:15 | |
| *** hoonetorg has quit IRC | 07:17 | |
| *** tbachman has quit IRC | 07:18 | |
| *** chyka has joined #openstack-nova | 07:21 | |
| *** edand__ has joined #openstack-nova | 07:22 | |
| *** chyka has quit IRC | 07:26 | |
| *** jose-phi_ has quit IRC | 07:26 | |
| *** slaweq has joined #openstack-nova | 07:28 | |
| *** hoonetorg has joined #openstack-nova | 07:29 | |
| *** acormier has quit IRC | 07:31 | |
| *** tianhui_ has joined #openstack-nova | 07:31 | |
| *** slaweq has quit IRC | 07:32 | |
| *** jangutter has joined #openstack-nova | 07:32 | |
| *** slaweq has joined #openstack-nova | 07:32 | |
| *** tianhui has quit IRC | 07:34 | |
| *** jangutter has quit IRC | 07:36 | |
| *** hshiina has joined #openstack-nova | 07:46 | |
| Spazmotic | jianghuaw: addressed the nits by Bob and and rebased if you get a chance on Zuul confirms it :) | 07:46 |
| Spazmotic | once* zuul | 07:46 |
| *** stakeda has quit IRC | 07:47 | |
| jianghuaw | Spazmotic, thanks for the update. It looks good to me:-) | 07:49 |
| Spazmotic | Thanks so much sir! | 07:49 |
| Spazmotic | hunting around for my next project | 07:49 |
| *** amorin has left #openstack-nova | 07:50 | |
| *** maciejjozefczyk_ is now known as maciejjozefczyk | 07:51 | |
| *** abhishekk is now known as abhishekk|away | 07:51 | |
| jianghuaw | Spazmotic, you may have interesting on this patch: https://review.openstack.org/#/c/532118/ | 07:54 |
| *** sree has joined #openstack-nova | 07:54 | |
| jianghuaw | Huan created it for getting advices. | 07:54 |
| jianghuaw | it's to fix a migration issue with xenapi. | 07:55 |
| Spazmotic | sure will take a look | 07:55 |
| *** pcaruana has joined #openstack-nova | 07:55 | |
| jianghuaw | Spazmotic, thanks. | 07:55 |
| Spazmotic | Interesting. We do volume based LM quite a bit but we get around this with --block-migrate for iSCSI | 07:57 |
| *** jangutter has joined #openstack-nova | 07:57 | |
| *** sree has quit IRC | 07:59 | |
| jianghuaw | Spazmotic, iirc the issue happens only in the XS7.0 and forwarding releases. | 07:59 |
| Spazmotic | That's definately going to be a problem i'll need to test out | 08:00 |
| jianghuaw | or maybe 7.1 => . I put 7.1 in the log. | 08:00 |
| jianghuaw | But anyway it will be issue for latest XS releases. | 08:01 |
| jianghuaw | feel free to put comments in it. | 08:01 |
| jianghuaw | If you interest, feel free to take it over:-) | 08:01 |
| Spazmotic | I'll certainly look at it heavily, appeals to me greatly | 08:02 |
| *** blkart has quit IRC | 08:02 | |
| jianghuaw | Thanks. | 08:02 |
| *** tianhui has joined #openstack-nova | 08:04 | |
| *** AlexeyAbashkin has joined #openstack-nova | 08:04 | |
| *** tianhui_ has quit IRC | 08:05 | |
| *** mvk has quit IRC | 08:08 | |
| *** tianhui_ has joined #openstack-nova | 08:08 | |
| Spazmotic | Do you know if Huan has refactored it at all recently? Mentions they wanted to tweak the vmops method around, but i'm sure time was tight for you guys | 08:08 |
| *** tianhui has quit IRC | 08:09 | |
| jianghuaw | Spazmotic, not yet I'm sure. | 08:14 |
| Spazmotic | Alrighty cool.. I've got some 7.1s in an env, i'll run some tests over the next few days and get familiar with these maps, havn't had to use them before | 08:15 |
| Spazmotic | Thanks for bringing to my attention is actually more important than you may know | 08:15 |
| *** jose-phillips has joined #openstack-nova | 08:16 | |
| jianghuaw | cool. | 08:16 |
| *** huanxie has joined #openstack-nova | 08:16 | |
| *** tesseract has joined #openstack-nova | 08:20 | |
| *** bhujay has quit IRC | 08:21 | |
| *** sahid has joined #openstack-nova | 08:21 | |
| *** vivsoni has quit IRC | 08:24 | |
| *** jose-phillips has quit IRC | 08:25 | |
| *** edand_ has joined #openstack-nova | 08:25 | |
| *** jose-phillips has joined #openstack-nova | 08:25 | |
| *** zhaochao has quit IRC | 08:26 | |
| *** gongysh has quit IRC | 08:26 | |
| *** gcb has quit IRC | 08:26 | |
| *** edand__ has quit IRC | 08:26 | |
| *** zhaochao has joined #openstack-nova | 08:27 | |
| *** gcb has joined #openstack-nova | 08:29 | |
| openstackgerrit | Hironori Shiina proposed openstack/nova master: virt/ironic: Implement rescue and unrescue https://review.openstack.org/416487 | 08:29 |
| *** gibi has joined #openstack-nova | 08:30 | |
| *** janki has quit IRC | 08:31 | |
| *** rha has joined #openstack-nova | 08:31 | |
| *** rha has quit IRC | 08:31 | |
| *** rha has joined #openstack-nova | 08:31 | |
| *** gongysh has joined #openstack-nova | 08:33 | |
| *** takedakn has quit IRC | 08:34 | |
| *** sahid has quit IRC | 08:34 | |
| *** sahid has joined #openstack-nova | 08:34 | |
| openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: Do not normalize allocation_ratios https://review.openstack.org/532924 | 08:35 |
| *** kwathore has quit IRC | 08:36 | |
| *** vivsoni has joined #openstack-nova | 08:38 | |
| maciejjozefczyk | Hello | 08:38 |
| *** gibi has quit IRC | 08:39 | |
| *** gibi has joined #openstack-nova | 08:41 | |
| *** bhujay has joined #openstack-nova | 08:42 | |
| *** damien_r has joined #openstack-nova | 08:43 | |
| *** jpena|off is now known as jpena | 08:44 | |
| *** mdnadeem_ has quit IRC | 08:45 | |
| *** mdnadeem has joined #openstack-nova | 08:45 | |
| *** sree has joined #openstack-nova | 08:45 | |
| *** abhishekk|away is now known as abhishekk | 08:47 | |
| *** janki has joined #openstack-nova | 08:47 | |
| *** jose-phillips has quit IRC | 08:47 | |
| * kashyap waves | 08:48 | |
| *** ralonsoh has joined #openstack-nova | 08:48 | |
| gmann | mriedem: updated those. 2 are ready to go and 1 i need more work on test which i will tomorrow - https://review.openstack.org/#/q/topic:bp/api-extensions-merge-queens+status:open | 08:49 |
| *** sree has quit IRC | 08:50 | |
| * Spazmotic waves | 08:50 | |
| gmann | mriedem: there are other work also needed on this BP which we will continue on continued Rocky BP. if you want to move current patches to new one, it should be ok | 08:50 |
| *** slaweq has quit IRC | 08:52 | |
| gmann | mriedem: or we defer the queens one to Rocky ? | 08:52 |
| *** slaweq has joined #openstack-nova | 08:54 | |
| *** markvoelker has joined #openstack-nova | 08:54 | |
| *** zhurong has quit IRC | 08:55 | |
| *** bhujay has quit IRC | 08:56 | |
| *** takedakn has joined #openstack-nova | 09:00 | |
| kashyap | It's middle of the night for Matt, so will take a few more hours for him to come online. | 09:05 |
| *** sree has joined #openstack-nova | 09:09 | |
| *** chyka has joined #openstack-nova | 09:10 | |
| *** jafeha has joined #openstack-nova | 09:12 | |
| *** sree has quit IRC | 09:14 | |
| *** jafeha__ has quit IRC | 09:14 | |
| *** chyka has quit IRC | 09:15 | |
| *** jmlowe has quit IRC | 09:16 | |
| *** huanxie has quit IRC | 09:18 | |
| *** chyka has joined #openstack-nova | 09:24 | |
| Spazmotic | Aargh Zuul why you hate me | 09:24 |
| *** zhurong has joined #openstack-nova | 09:26 | |
| *** huanxie has joined #openstack-nova | 09:26 | |
| Roamer` | Spazmotic, if it's any help, I doubt it's personal - it's in Zuul's nature to be very, very paranoid and suspicious of everyone, you just have to catch one of its rare good moods... :) | 09:27 |
| *** markvoelker has quit IRC | 09:27 | |
| *** chyka has quit IRC | 09:28 | |
| *** amoralej|off is now known as amoralej | 09:29 | |
| *** gibi_ has joined #openstack-nova | 09:29 | |
| *** hshiina has quit IRC | 09:29 | |
| *** derekh has joined #openstack-nova | 09:29 | |
| openstackgerrit | Zengzhi Wang proposed openstack/nova stable/pike: Make eventlet hub use a monotonic clock https://review.openstack.org/537811 | 09:30 |
| *** itlinux has joined #openstack-nova | 09:31 | |
| *** vivsoni has quit IRC | 09:34 | |
| *** vivsoni has joined #openstack-nova | 09:35 | |
| *** vivsoni_ has joined #openstack-nova | 09:43 | |
| *** vivsoni has quit IRC | 09:47 | |
| *** huanxie has quit IRC | 09:48 | |
| *** blkart has joined #openstack-nova | 09:50 | |
| *** zhurong_ has joined #openstack-nova | 09:57 | |
| *** hrw has joined #openstack-nova | 09:57 | |
| hrw | morning | 09:57 |
| *** gszasz has joined #openstack-nova | 09:57 | |
| *** huanxie has joined #openstack-nova | 09:58 | |
| *** itlinux has quit IRC | 09:58 | |
| hrw | I am looking at nova's code. it adds graphics if it is needed. but I did not see where it adds usb host for usbtablet | 09:58 |
| hrw | does it assume that usb host is already present in VM configuration? | 09:58 |
| Roamer` | OK, so the StorPool volume attachment driver finally passed the Zuul check pipeline (after the Cinder backup bug was fixed)... I'm pretty sure mriedem intends to +W it once he wakes up and sees it's passed the tests, but the gate being what it is, I'd be really obliged if somebody else could +W it earlier :) Of course, "let's just wait for him" is a very reasonable option. | 09:59 |
| Roamer` | oof, and that would be https://review.openstack.org/#/c/140733/19 of course | 10:00 |
| *** kevinz has joined #openstack-nova | 10:01 | |
| *** itlinux has joined #openstack-nova | 10:01 | |
| *** bhujay has joined #openstack-nova | 10:03 | |
| kevinz | alex_xu: Could you review https://review.openstack.org/#/c/494156/ if you have time? Stephen already give +2 :-) | 10:03 |
| *** yamamoto has quit IRC | 10:04 | |
| *** bkopilov has quit IRC | 10:05 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | 10:05 |
| *** bkopilov has joined #openstack-nova | 10:06 | |
| alex_xu | kevinz: got it | 10:08 |
| *** itlinux has quit IRC | 10:09 | |
| *** hoonetorg has quit IRC | 10:09 | |
| *** jchhatbar has joined #openstack-nova | 10:10 | |
| hrw | tracking how nova gets guest components suxx | 10:11 |
| *** janki has quit IRC | 10:11 | |
| stephenfin | mriedem, melwitt: Yeah, sorry about https://review.openstack.org/#/c/523958/ I was the approver and that's my bad. Won't happen again | 10:13 |
| *** jchhatbar has quit IRC | 10:14 | |
| hrw | ok. nova assumes that usb host is present | 10:18 |
| kashyap | stephenfin: mriedem: As I've said in the past, I don't quite agree with that line of thinking. Happy to also elaborate why in Dublin. | 10:19 |
| mdbooth | mriedem: melwitt stephenfin I wonder if that policy of old might be up for review, especially in a case like this which is uncontroversial. IIRC the understanding came about after RH was accused of railroading a particular controversial patch. That's an entirely valid concern, but I don't think anybody is claiming it happened here. | 10:19 |
| kashyap | (It somehow seem to imply / assume "malice") | 10:20 |
| * hrw -> bugtracker | 10:20 | |
| kashyap | (But it _should_ be a concern, if it's a _pattern_ of two people from the same company ACKing changes in rapid succession without giving time for others to chime in.) | 10:20 |
| kashyap | (Or for some goddamned deadline's sake.) | 10:20 |
| stephenfin | mdbooth: Indeed, but the discussion should have happened _before_ /me did that :) EAFP probably doesn't apply where matters of trust are involved | 10:21 |
| stephenfin | A good PTG topic though, for sure | 10:21 |
| kashyap | Sure. But I do agree with Matt that, we shouldn't be too eager to push something for a deadline | 10:22 |
| *** hoonetorg has joined #openstack-nova | 10:22 | |
| kashyap | Because, let's be honest --- most deadlines milestones don't matter. It's all artificial lines in the sand. | 10:22 |
| mdbooth | stephenfin: There was a spec, many rounds of review, at least 3 ML posts that I recall over a period of a few weeks, and additional thorough review from 2 core reviewers, including yourself. I resent the implication, tbh. | 10:23 |
| *** markvoelker has joined #openstack-nova | 10:25 | |
| kashyap | Yeah, I recall the history / and even postmortem done by markmc. | 10:25 |
| kashyap | http://lists.openstack.org/pipermail/openstack-dev/2014-August/044550.html -- [openstack-dev] [nova] libvirt version_cap, a postmortem | 10:25 |
| kashyap | mdbooth: Ah, I thought you were talking about a previous case which caused this no two +2s from the same company thing.) | 10:25 |
| mdbooth | The previous case was also a misunderstanding, tbh, although there was more substance to it. | 10:27 |
| kashyap | Yeah, absolutely it was a case: "too eager to misunderstand" | 10:27 |
| hrw | https://bugs.launchpad.net/nova/+bug/1745340 - what should I add to get it more complete? | 10:27 |
| openstack | Launchpad bug 1745340 in OpenStack Compute (nova) "Nova assumes that USB Host is present" [Undecided,New] | 10:27 |
| stephenfin | More complete? | 10:28 |
| hrw | stephenfin: more useful to anyone who would look at issue | 10:29 |
| hrw | if anyone at all ;D | 10:29 |
| stephenfin | I think you've pretty much got it | 10:30 |
| *** liuzz has quit IRC | 10:30 | |
| stephenfin | I assume the solution would be to check if we have a USB hub and either (a) add it if not or (b) refuse to start with a USB tablet? | 10:30 |
| stephenfin | *refuse to start with a USB tablet if the platform doesn't support the USB hub | 10:31 |
| stephenfin | hrw: I can point you to the code that needs modification, if you fancy the challenge? ;) | 10:31 |
| hrw | stephenfin: please do. in a bug comment | 10:31 |
| hrw | stephenfin: it may end on my or kevinz's plate or maybe we assign it to someone else at Linaro | 10:32 |
| hrw | stephenfin: imho the proper way would be to add usb-host device if not present | 10:32 |
| *** acormier has joined #openstack-nova | 10:32 | |
| hrw | as the goal is to have graphical console in Rocky (as it is too late for Queens) | 10:33 |
| *** jpena is now known as jpena|off | 10:33 | |
| *** jpena|off is now known as jpena | 10:33 | |
| hrw | during ptg I have to track nova sticker for my laptop ;D to put it next to kolla one | 10:34 |
| stephenfin | hrw: https://bugs.launchpad.net/nova/+bug/1745340/comments/3 | 10:36 |
| openstack | Launchpad bug 1745340 in OpenStack Compute (nova) "Nova assumes that USB Host is present" [Undecided,New] | 10:36 |
| * stephenfin notices some cleanup that should have been done in Ocata there | 10:36 | |
| hrw | stephenfin: exactly where I was looking at | 10:37 |
| *** acormier has quit IRC | 10:37 | |
| *** lucas-afk is now known as lucasagomes | 10:37 | |
| hrw | stephenfin: probably some code in nova.virt.libvirt.* too | 10:37 |
| hrw | to 'plug' host | 10:37 |
| hrw | will later look into | 10:38 |
| * hrw -> lunch | 10:38 | |
| *** abhishekk has quit IRC | 10:38 | |
| Spazmotic | Come on tempest... you running slow but i have faith in you | 10:38 |
| *** edand_ has quit IRC | 10:41 | |
| *** hrw has quit IRC | 10:43 | |
| *** edand_ has joined #openstack-nova | 10:44 | |
| *** annp has quit IRC | 10:46 | |
| *** mdnadeem has quit IRC | 10:48 | |
| *** jistr is now known as jistr|mtg | 10:49 | |
| *** gongysh has quit IRC | 10:54 | |
| *** kevinz has quit IRC | 10:55 | |
| *** sree has joined #openstack-nova | 10:56 | |
| *** markvoelker has quit IRC | 10:58 | |
| *** sree has quit IRC | 11:01 | |
| *** yamamoto has joined #openstack-nova | 11:05 | |
| *** bhujay has quit IRC | 11:07 | |
| *** sree has joined #openstack-nova | 11:08 | |
| *** hrw has joined #openstack-nova | 11:09 | |
| *** huanxie has quit IRC | 11:09 | |
| *** bhujay has joined #openstack-nova | 11:12 | |
| *** sree has quit IRC | 11:13 | |
| *** chyka has joined #openstack-nova | 11:13 | |
| *** rmart04 has joined #openstack-nova | 11:16 | |
| *** gcb has quit IRC | 11:17 | |
| *** yamamoto has quit IRC | 11:18 | |
| *** chyka has quit IRC | 11:18 | |
| *** gcb has joined #openstack-nova | 11:20 | |
| *** takedakn has quit IRC | 11:25 | |
| *** alexchadin has joined #openstack-nova | 11:31 | |
| *** yamamoto has joined #openstack-nova | 11:31 | |
| *** namnh has quit IRC | 11:31 | |
| *** jangutter has quit IRC | 11:32 | |
| *** tiendc has quit IRC | 11:35 | |
| *** zhurong has quit IRC | 11:35 | |
| *** gibi has left #openstack-nova | 11:36 | |
| *** sapd_ has quit IRC | 11:45 | |
| stephenfin | sean-k-mooney: Think I've reviewed all of bp/enable-sriov-nic-features now :) | 11:46 |
| stephenfin | Lemme know if you have questions | 11:46 |
| *** gaoyan has joined #openstack-nova | 11:48 | |
| *** zhurong has joined #openstack-nova | 11:55 | |
| *** markvoelker has joined #openstack-nova | 11:55 | |
| Spazmotic | hey huanxie you still around | 11:55 |
| Spazmotic | or jianghuaw can you explain to me what XS expects of these VDI MAPS on a live migration? | 11:56 |
| *** gaoyan has quit IRC | 11:57 | |
| *** AlexeyAbashkin has quit IRC | 11:58 | |
| *** AlexeyAbashkin has joined #openstack-nova | 11:58 | |
| *** sapd_ has joined #openstack-nova | 11:58 | |
| *** tetsuro has quit IRC | 12:01 | |
| *** smatzek has joined #openstack-nova | 12:02 | |
| *** jangutter has joined #openstack-nova | 12:03 | |
| *** jpena is now known as jpena|lunch | 12:03 | |
| jianghuaw | Spazmotic, I've talked with Huan. You can chat with her on tomorrow. | 12:06 |
| Spazmotic | Sounds good, thanks, i'll stop by tomorrow :) | 12:06 |
| lyarwood | mriedem: iirc live snapshot was only for local images and not volumes right? Even then we skip it for rbd? | 12:06 |
| *** jangutter has quit IRC | 12:07 | |
| Spazmotic | IBM PowerKVM CI failing constantly | 12:12 |
| *** sree has joined #openstack-nova | 12:14 | |
| Spazmotic | Looks like past 4 or 5 hours all failures on its tempest-dsvm-full-xenialchecks | 12:17 |
| sean-k-mooney | stephenfin: just in so ill take a look at them now | 12:17 |
| *** janki has joined #openstack-nova | 12:19 | |
| *** gouthamr has quit IRC | 12:19 | |
| *** sree has quit IRC | 12:19 | |
| *** gouthamr has joined #openstack-nova | 12:20 | |
| *** tesseract has quit IRC | 12:24 | |
| owalsh | stephenfin: is vencrypt_ca_certs required when vencrypt is enabled? doesn't looks like it default to the system ca certs so I'm guessing yea | 12:27 |
| *** janki has quit IRC | 12:28 | |
| *** markvoelker has quit IRC | 12:29 | |
| *** yamamoto has quit IRC | 12:31 | |
| *** yamamoto has joined #openstack-nova | 12:31 | |
| *** sambetts|afk is now known as sambetts | 12:35 | |
| *** alexchadin has quit IRC | 12:35 | |
| *** alexchadin has joined #openstack-nova | 12:36 | |
| *** hrw has quit IRC | 12:38 | |
| *** jistr|mtg is now known as jistr | 12:38 | |
| *** hrw has joined #openstack-nova | 12:38 | |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Reduce complexity of _from_db_object https://review.openstack.org/537728 | 12:38 |
| openstackgerrit | Gaudenz Steinlin proposed openstack/nova master: Ignore some updates from virt driver https://review.openstack.org/523006 | 12:39 |
| *** jangutter has joined #openstack-nova | 12:39 | |
| *** tianhui has joined #openstack-nova | 12:45 | |
| *** tianhui_ has quit IRC | 12:48 | |
| *** takashin has joined #openstack-nova | 12:50 | |
| *** yamamoto has quit IRC | 12:52 | |
| *** alexchadin has quit IRC | 12:52 | |
| *** alexchadin has joined #openstack-nova | 12:53 | |
| *** ratailor has quit IRC | 12:54 | |
| *** alexchadin has quit IRC | 13:00 | |
| *** alexchadin has joined #openstack-nova | 13:00 | |
| *** lpetrut has joined #openstack-nova | 13:03 | |
| *** bhujay has quit IRC | 13:03 | |
| *** belmoreira has joined #openstack-nova | 13:04 | |
| *** dave-mccowan has joined #openstack-nova | 13:05 | |
| *** kevzha01 has joined #openstack-nova | 13:05 | |
| *** yamamoto has joined #openstack-nova | 13:07 | |
| *** kevzha01_ has joined #openstack-nova | 13:07 | |
| *** elod has quit IRC | 13:09 | |
| *** kevzha01 has quit IRC | 13:10 | |
| *** zhurong has quit IRC | 13:16 | |
| *** elod has joined #openstack-nova | 13:16 | |
| *** acormier has joined #openstack-nova | 13:16 | |
| *** alexchadin has quit IRC | 13:18 | |
| *** acormier has quit IRC | 13:19 | |
| ameeda | jaypipes: Sir are you around ? | 13:20 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408 | 13:21 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 13:21 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 13:21 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/537897 | 13:21 |
| *** pchavva has joined #openstack-nova | 13:22 | |
| *** abhishekk has joined #openstack-nova | 13:24 | |
| *** elod has quit IRC | 13:25 | |
| *** elod has joined #openstack-nova | 13:25 | |
| *** markvoelker has joined #openstack-nova | 13:26 | |
| *** tesseract has joined #openstack-nova | 13:27 | |
| *** liverpooler has joined #openstack-nova | 13:28 | |
| *** sree has joined #openstack-nova | 13:30 | |
| *** edmondsw_ has joined #openstack-nova | 13:30 | |
| *** liusheng has quit IRC | 13:32 | |
| *** sree has quit IRC | 13:39 | |
| stephenfin | owalsh: I think so, yup. I should probably encode that | 13:41 |
| *** yamamoto has quit IRC | 13:42 | |
| *** tesseract has quit IRC | 13:42 | |
| *** cleong has joined #openstack-nova | 13:42 | |
| *** tesseract has joined #openstack-nova | 13:42 | |
| *** tetsuro has joined #openstack-nova | 13:44 | |
| *** zhurong_ has quit IRC | 13:44 | |
| *** Yikun has quit IRC | 13:47 | |
| *** Yikun has joined #openstack-nova | 13:47 | |
| *** sree has joined #openstack-nova | 13:48 | |
| *** edmondsw_ is now known as edmondsw | 13:48 | |
| *** alexchadin has joined #openstack-nova | 13:49 | |
| *** eharney has quit IRC | 13:49 | |
| *** acormier has joined #openstack-nova | 13:51 | |
| Spazmotic | IBM CI what is wrong with you :( http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/index.html | 13:51 |
| mmedvede | Spazmotic: it should be fixed now, at least the original problem that was causing earlier failures | 13:52 |
| *** Tom-Tom has joined #openstack-nova | 13:52 | |
| Spazmotic | Ahhh thanks mmedvede | 13:52 |
| Spazmotic | I'll give it a new recheck hehe | 13:52 |
| *** sree has quit IRC | 13:52 | |
| *** alexchadin has quit IRC | 13:52 | |
| mriedem | Roamer`: i won't be +Wing your change because we require 2 +2s | 13:53 |
| *** acormier has quit IRC | 13:54 | |
| *** esberglu has joined #openstack-nova | 13:55 | |
| *** bhujay has joined #openstack-nova | 13:56 | |
| mriedem | gibi_: we should probably consider bumping the nova functional job timeouts as a change on top of your patch to move them into the nova tree | 13:58 |
| *** gongysh has joined #openstack-nova | 13:58 | |
| *** weshay|rover is now known as weshay|ruck | 13:58 | |
| *** jmlowe has joined #openstack-nova | 13:59 | |
| *** markvoelker has quit IRC | 13:59 | |
| hrw | stephenfin: turns out that one change to libvirt makes life easier. | 14:00 |
| hrw | stephenfin: will wait for libvirt devs to respond before testing it further | 14:00 |
| mriedem | nova meeting starting in #openstack-meeting | 14:00 |
| gibi_ | mriedem: I can do that | 14:00 |
| gibi_ | mriedem: is it just the functional or also the functional-py35 job that times out frequently? | 14:01 |
| *** lyan has joined #openstack-nova | 14:01 | |
| mriedem | both | 14:01 |
| *** david-lyle has quit IRC | 14:01 | |
| gibi_ | mriedem: OK | 14:01 |
| *** psachin has quit IRC | 14:02 | |
| *** yamamoto has joined #openstack-nova | 14:02 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't filter out sibling sets with one core https://review.openstack.org/537361 | 14:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Ensure emulator threads are always calculated https://review.openstack.org/537363 | 14:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Always pass 'NUMACell.siblings' to _pack_instance_onto_cores' https://review.openstack.org/537364 | 14:04 |
| *** esberglu has quit IRC | 14:08 | |
| *** jose-phillips has joined #openstack-nova | 14:09 | |
| *** kevzha01__ has joined #openstack-nova | 14:09 | |
| *** tbachman has joined #openstack-nova | 14:09 | |
| *** kevzha01_ has quit IRC | 14:12 | |
| *** huanxie has joined #openstack-nova | 14:13 | |
| *** kevzha01_ has joined #openstack-nova | 14:13 | |
| stephenfin | mriedem: Could you take a look at this after the meeting? https://review.openstack.org/#/c/527182/ It's blocking https://review.openstack.org/#/c/526329/ | 14:13 |
| stephenfin | Maybe gibi_ too, if you have the time ^ | 14:14 |
| mriedem | sure | 14:15 |
| mriedem | stephenfin: trade you https://review.openstack.org/#/c/140733/ | 14:15 |
| stephenfin | Sounds good | 14:16 |
| *** kevzha01__ has quit IRC | 14:16 | |
| efried | holy crap, that one's >3 years old | 14:16 |
| *** tesseract has quit IRC | 14:17 | |
| *** tesseract has joined #openstack-nova | 14:18 | |
| mriedem | b/c the cinder driver for it was removed awhile back | 14:19 |
| *** sahid has quit IRC | 14:19 | |
| Roamer` | stephenfin, efried, we (StorPool) and, actually, also Canonical would be very, very happy for if this could go in | 14:20 |
| Roamer` | sorry... | 14:20 |
| *** sahid has joined #openstack-nova | 14:20 | |
| Roamer` | I honestly hadn't realized that it needed a second +2 vote, my bad, my very bad :( | 14:20 |
| Roamer` | and yeah, there's history... we tried submitting a driver too late for Juno, then it went into Kilo, then we messed up and it was removed, and now we're trying to get it back | 14:21 |
| Roamer` | aaaaand I'll shut up now | 14:21 |
| kashyap | mriedem: Heya, so...I wrote this: https://review.openstack.org/#/c/523958/18. I agree with you on most / all topics. Besides this. Wonder what you think of my POV there. | 14:22 |
| *** smatzek has quit IRC | 14:24 | |
| *** smatzek has joined #openstack-nova | 14:24 | |
| *** smatzek has quit IRC | 14:24 | |
| *** esberglu has joined #openstack-nova | 14:24 | |
| *** mgoddard_ has joined #openstack-nova | 14:24 | |
| *** huanxie has quit IRC | 14:25 | |
| *** alexchadin has joined #openstack-nova | 14:25 | |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: disconnect volume from host during detach https://review.openstack.org/515008 | 14:26 |
| -openstackstatus- NOTICE: We're currently experiencing issues with the logs.openstack.org server which will result in POST_FAILURE for jobs, please stand by and don't needlessly recheck jobs while we troubleshoot the problem. | 14:26 | |
| gibi_ | stephenfin: lgtm! +2 | 14:26 |
| *** lucasagomes is now known as lucas-hungry | 14:27 | |
| *** Yikun has quit IRC | 14:27 | |
| *** psachin has joined #openstack-nova | 14:27 | |
| efried | gibi_ But don't +W it, cause the gate's broken. Or whatever. | 14:27 |
| *** Yikun has joined #openstack-nova | 14:27 | |
| gibi_ | efried: I was the first +2 | 14:28 |
| *** burt has joined #openstack-nova | 14:29 | |
| *** jose-phillips has quit IRC | 14:29 | |
| *** gibi_ is now known as gibi | 14:29 | |
| *** elmaciej has joined #openstack-nova | 14:30 | |
| *** kevzha01 has joined #openstack-nova | 14:31 | |
| *** psachin has quit IRC | 14:32 | |
| *** yangyapeng has quit IRC | 14:32 | |
| *** amodi has joined #openstack-nova | 14:32 | |
| *** jaypipes has quit IRC | 14:32 | |
| *** psachin has joined #openstack-nova | 14:33 | |
| *** kevzha01_ has quit IRC | 14:33 | |
| *** markvoelker has joined #openstack-nova | 14:34 | |
| *** eharney has joined #openstack-nova | 14:34 | |
| *** jpena|lunch is now known as jpena | 14:35 | |
| gibi | stephenfin: could you look at these? https://review.openstack.org/#/q/topic:bp/versioned-notification-transformation-queens+status:open+label:Code-Review%253D%252B2 to easy notification transformation before FF :) | 14:35 |
| mriedem | gibi: stephenfin: i'll look at https://review.openstack.org/#/c/465081/ again, | 14:35 |
| mriedem | since i was -1 on it | 14:35 |
| *** edand_ has quit IRC | 14:35 | |
| gibi | mriedem: thanks | 14:36 |
| stephenfin | gibi: Sure, it's been on my list | 14:36 |
| takashin | mriedem: Thank you. | 14:36 |
| stephenfin | Along with some of gmann's API stuff | 14:36 |
| gibi | stephenfin: thanks | 14:36 |
| *** jaypipes has joined #openstack-nova | 14:37 | |
| * dansmith yawns | 14:38 | |
| ameeda | hello, how to run pep8 for one class ? | 14:39 |
| ameeda | tox -e pep8 -- -n nova/tests/unit/compute/test_compute_api.py , doesn't work | 14:39 |
| maciejjozefczyk | ameeda: tox -e pep8 nova/virt/libvirt/driver.py ? | 14:41 |
| mriedem | kashyap: replied | 14:41 |
| stephenfin | ^ that | 14:41 |
| ameeda | maciejjozefczyk: Thanks, let me try | 14:42 |
| SpazZz | Why is it still 40 degrees in south texas | 14:42 |
| ameeda | maciejjozefczyk: Thanks ^_^ | 14:42 |
| efried | ameeda You can run flake8 directly from the pep8 venv. source .tox/pep8/bin/activate; flake8 path/to/file.py path/to/another.py etc.py | 14:42 |
| SpazZz | One more day of this and i'll die | 14:42 |
| SpazZz | thems the rules | 14:42 |
| *** tetsuro has quit IRC | 14:42 | |
| efried | SpazZz ++ | 14:42 |
| ameeda | thanks all | 14:42 |
| maciejjozefczyk | ameeda: :) | 14:42 |
| sean-k-mooney | ameeda: if you have commited the chagne you can use tox -e fast8 to just run tox on the files you changed in the last commit | 14:42 |
| maciejjozefczyk | sean-k-mooney: good to know | 14:43 |
| SpazZz | If any cores got some cycles today for this would be much appreciated. +1'd by two citrix folks, need mah +2 love now :) https://review.openstack.org/#/c/533168/ | 14:43 |
| efried | And to nerd out just a little bit more, to check the last e.g. 6 commits in a series, I do this from my pep8 venv: git diff --name-only HEAD~6 | grep '\.py$' | xargs flake8 | 14:43 |
| mdbooth | sean-k-mooney: If that's the same as 'tox -e pep8 -- -HEAD' it will also include uncommitted changes in the working directory. | 14:44 |
| SpazZz | Ignore the IBM.. it'll go away eventually :P | 14:44 |
| ameeda | sean-k-mooney: thank you, I appreciate all your help | 14:44 |
| mdbooth | efried: Nice... | 14:44 |
| sean-k-mooney | mdbooth: oh am yes it is. i sometiems have line lenght issue in my commit message so i prefer to commit first out of habbit | 14:45 |
| mriedem | lyarwood: mdbooth: regarding https://review.openstack.org/#/c/523958/ - since it knowingly regresses swap volume with a luks-encrypted volume, is anyone working on a nova patch to workaround that and fallback to the old non-native routine? | 14:45 |
| mdbooth | mriedem: I responded to that on the ML | 14:45 |
| mriedem | lyarwood: mdbooth: because it's getting pretty late to just merge this and put something in the release notes about oopsies | 14:45 |
| mdbooth | I don't really regard it as a regression, tbh, as it was entirely broken until this Monday | 14:45 |
| mdbooth | And there's already an upstream bug tracking it in libvirt | 14:46 |
| jaypipes | mriedem, efried: good morning fellas. I have a few hours before I need to go to the airport. so I'll try to focus on patch reviews during this time. do we have a priority list? | 14:46 |
| jaypipes | dansmith: you too.. | 14:46 |
| *** ralonsoh_ has joined #openstack-nova | 14:46 | |
| *** Adri2000 has left #openstack-nova | 14:46 | |
| mdbooth | mriedem: We'd be adding in workaround code for something which needs an underlying fix. | 14:46 |
| mriedem | mdbooth: then we need something more discoverable than a small note in a release note, | 14:47 |
| *** kevzha01 has quit IRC | 14:47 | |
| mriedem | e.g. maybe a docs update to cinder saying that you can't migrate/retype an encrypted volume for now | 14:47 |
| efried | jaypipes The update_provider_tree series is ready up to update_from_provider_tree. There's some possibly-controversial stuff towards the top. Not sure how much chance of getting approved before FF, but at least worth skimming. | 14:47 |
| mdbooth | mriedem: Well you never could... | 14:48 |
| jaypipes | mriedem, efried: I'm also continuing my patch series on the alloc candidates and n-r-p. been slow going because of $work the last two days | 14:48 |
| mdbooth | mriedem: It's only a disappointment to anybody running master who updated on Monday | 14:48 |
| *** ralonsoh has quit IRC | 14:48 | |
| jaypipes | efried: what's the latest status on alex_xu's patches around traits in alloc candidates? | 14:48 |
| efried | Heh. $work meaning work you get a paycheck for? :) | 14:48 |
| jaypipes | efried: yeah, that :) | 14:48 |
| mriedem | mdbooth: ok - my point is, i don't know if no one else in the world knows you never could | 14:48 |
| efried | jaypipes I believe we're +W and in recheck hell, but that could just be the bottom patch. | 14:48 |
| mriedem | so, docs would be a good start | 14:48 |
| efried | looking... | 14:48 |
| mriedem | because users of openstack do'nt know, or shouldn't need to know, low level details about how the code works | 14:49 |
| jaypipes | efried: the REST API change one? | 14:49 |
| alex_xu | jaypipes: yes, all of those patches get approved...then recheck and recheck... | 14:49 |
| jaypipes | alex_xu: gotcha, k, thx for the update | 14:49 |
| *** rmcall has joined #openstack-nova | 14:49 | |
| stephenfin | Roamer`, mriedem: That's done now. There's some cleanup/simplification that can be done, but that's a separate effort | 14:49 |
| mdbooth | mriedem: Critically we're not regressing. | 14:50 |
| jaypipes | mriedem: depends. if you've an NFV user, of *course* you need to know all the low-level details of everything going on. ;) | 14:50 |
| *** andreas_s has joined #openstack-nova | 14:50 | |
| Roamer` | stephenfin, thanks a lot! And, yes, good catch on the exception... | 14:51 |
| mriedem | jaypipes: yeah that's true | 14:52 |
| mdbooth | mriedem: The way I see it is this implementation is much simpler and more robust for Nova, as I mentioned on the ML. | 14:52 |
| mriedem | jaypipes: well, except for the part where you just tell nova to put the instance on this host and this numa node and this set of cpus, totally bypassing the scheduler | 14:52 |
| jaypipes | efried: is the recheck hell due to timeouts in zuul jobs or is it due to a particular bug in a dependency (or nova etc) | 14:52 |
| jaypipes | mriedem: right. NFV. | 14:52 |
| efried | jaypipes The latest and greatest is the log server went read-only. We're supposed to not recheck anything until they've sent another broadcast saying it's fixed. | 14:53 |
| mriedem | jaypipes: there was a big regression on tuesday that caused most dsvm jobs to fail. the fix for that merged yesterday. | 14:53 |
| mdbooth | We can add complexity to work around a temporary limitation in the underlying library, but given that the feature in question never worked anyway I think it would be better just to note that it doesn't work. | 14:53 |
| jaypipes | mriedem: that's pretty much what I've been talking about at this $work thing for 2 days. | 14:53 |
| mriedem | however, still hitting job timeouts and post failures | 14:53 |
| jaypipes | k | 14:53 |
| jaypipes | efried: ack | 14:53 |
| mdbooth | mriedem: Specifically, I don't want to add yet anothing config option for this: it should be transparent to the operator. | 14:53 |
| efried | jaypipes I also noticed (not sure if there's actual cause->effect here) that rechecking jobs *later* in The Big Series caused the bottom patch to stall in the gate. | 14:54 |
| jaypipes | hmm. | 14:54 |
| efried | jaypipes So I think whenever stuff opens up again, I'm going to try just checking the bottom one. | 14:54 |
| jaypipes | not sure I've personally seen that yet. | 14:54 |
| efried | yeah, it was weird. The bottom one was in the gate and blue worms creeping along, looking good. Then I rechecked some above it. And then the bottom one stopped having blue worms (but stayed in the gate queue). | 14:55 |
| mriedem | mdbooth: i'm not asking for a config option | 14:55 |
| efried | ...where it has been for ~11.5h now | 14:55 |
| *** zhaochao has quit IRC | 14:56 | |
| openstackgerrit | Ameed Ashour proposed openstack/nova master: detaching volumes when deleted VM is in error state https://review.openstack.org/528069 | 14:56 |
| openstackgerrit | Ameed Ashour proposed openstack/nova master: detach instance volumes when VM creation fails https://review.openstack.org/528385 | 14:56 |
| *** alexchadin has quit IRC | 14:57 | |
| mdbooth | mriedem: It's not a regression though, right? Specifically because it was always broken. There is nobody currently using this feature who will have their workflow broken by this change. | 14:57 |
| *** Guest14094 has quit IRC | 14:58 | |
| mriedem | mdbooth: if we're not going to put some kind of conditional fallback code in place, then i don't think the release note should mention it really - it's confusing and alarming if you didn't realize this iddn't work until recently; and on top of that, we likely need an api-ref update to cinder to mention that retype/migration of an attached encrypted volume won't work on the compute side because of some bug | 14:58 |
| mriedem | s/of some bug/it's not yet supported/ | 14:59 |
| mdbooth | mriedem: Well we discovered that swap volume was broken in review, about a month ago. Lee opened a bug about it. | 14:59 |
| *** yangyapeng has joined #openstack-nova | 14:59 | |
| * mdbooth finds the bug | 14:59 | |
| *** jackie-truong has joined #openstack-nova | 15:00 | |
| ameeda | please review my code for this two gerrit https://review.openstack.org/528069 and https://review.openstack.org/528385 , thanks in advance :) | 15:00 |
| *** smatzek has joined #openstack-nova | 15:00 | |
| mriedem | mdbooth: https://bugs.launchpad.net/nova/+bug/1739593 | 15:00 |
| openstack | Launchpad bug 1739593 in OpenStack Security Advisory "Swapping encrypted volumes can lead to data loss and a possible compute host DOS attack" [Undecided,Incomplete] | 15:00 |
| mdbooth | https://bugs.launchpad.net/nova/+bug/1739593 | 15:00 |
| *** mlavalle has joined #openstack-nova | 15:00 | |
| mdbooth | Yeah, that's the one | 15:00 |
| mriedem | ok so that says fix released | 15:00 |
| mdbooth | Yep, last Monday | 15:00 |
| *** smatzek has quit IRC | 15:00 | |
| *** smatzek has joined #openstack-nova | 15:01 | |
| mriedem | so if i'm a new user to openstack and trying to swap an encrypted volume with libvirt, and it doesn't work, i might look for a bug and find this and it says it's fixed, | 15:01 |
| dansmith | bauzas: are you around today? | 15:01 |
| mriedem | but now my operator is running new enough libvirt/qemu for the native stuff, and it doesn't work | 15:01 |
| *** takashin has left #openstack-nova | 15:01 | |
| mriedem | which is a new bug/regression technically | 15:01 |
| *** Guest14094 has joined #openstack-nova | 15:01 | |
| mriedem | mdbooth: so what do you tell that user? | 15:01 |
| mriedem | "it never worked, until it did, and then it didn't again" | 15:01 |
| mdbooth | I think we're splitting hairs here, as nobody at all will have used it in the intervening period, and it will be fixed upstream at some point anyway. | 15:02 |
| *** r-daneel has joined #openstack-nova | 15:02 | |
| mdbooth | And as I said, this does simplify Nova. | 15:02 |
| mriedem | mdbooth: "fixed upstream at some point" in libvirt/qemu could be ages before someone actually picks up the versions of those packages that have those fixes, that's not using RHOSP | 15:02 |
| mriedem | mdbooth: if there is a bz for libvirt/qemu, then that's the known issue, | 15:03 |
| mriedem | and i think we should have something in the docs about this is a known limitation | 15:03 |
| mdbooth | mriedem: It's linked in a code comment | 15:03 |
| mriedem | jesus christ | 15:03 |
| mriedem | end users shouldn't have to read code | 15:03 |
| mriedem | nevermind, i'll push the patch | 15:04 |
| mdbooth | mriedem: Thanks. | 15:04 |
| mriedem | what's the bz? | 15:04 |
| mdbooth | Sec... | 15:04 |
| *** belmoreira has quit IRC | 15:05 | |
| *** tobasco has quit IRC | 15:05 | |
| mdbooth | mriedem: Incidentally, swap volume is also broken for multi attach. | 15:05 |
| mdbooth | It's generally a difficult feature. | 15:06 |
| *** _pewp_ has quit IRC | 15:06 | |
| mdbooth | https://bugzilla.redhat.com/show_bug.cgi?id=760547 | 15:07 |
| openstack | bugzilla.redhat.com bug 760547 in libvirt "[RFE] specifying the entire image chain as a qemu drive (blockdev-add) (libvirt)" [Medium,Assigned] - Assigned to pkrempa | 15:07 |
| mriedem | how is swap volume broken for multiattach? | 15:07 |
| *** _pewp_ has joined #openstack-nova | 15:07 | |
| mdbooth | mriedem: Do we not disable swap volume on multiattached volumes? | 15:07 |
| kashyap | The above bugzilla in turn depends on libvirt wiring up the new QMP command 'blockdev-add' | 15:07 |
| * mdbooth remembers pointing out in spec review that we needed to do that. | 15:07 | |
| kashyap | (New from QEMU 2.9 onwards.) | 15:07 |
| mdbooth | mriedem: So, swap volume does a block rebase in Nova, which is local to a single instance. | 15:08 |
| *** pooja-jadhav has joined #openstack-nova | 15:08 | |
| mdbooth | It makes a bunch of assumptions about things not changing under it, which are broken by multi attach. | 15:08 |
| mdbooth | So if you do a volume migration on a multi-attach volume, that would cause data corruption. | 15:08 |
| mdbooth | Incidentally, I had some ideas about how you might make it work but they're crazy complex. Simplest just to disable it, which is what I assumed we'd done. | 15:10 |
| *** tobasco has joined #openstack-nova | 15:10 | |
| kashyap | mriedem: Swapping an ecrypted volume won't be solved soon -- as it requires libvirt doing some surgery as noted above. | 15:10 |
| *** pooja_jadhav has quit IRC | 15:10 | |
| kashyap | Nova _swap_volume() method uses blockRebase() API. And libvirt's current notion of encryption key is persistent only to the active layer. | 15:11 |
| *** tidwellr has joined #openstack-nova | 15:11 | |
| kashyap | Where 'active layer' means, given A.raw <-- B.qcow2 (live) | 15:11 |
| mriedem | kashyap: that's why i said, "meh, it'll eventually be fixed upstream so who cares" isn't a good response to a user | 15:11 |
| kashyap | B is the "active layer", where A is the backing file of B. | 15:11 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Bumping functional test job timeouts https://review.openstack.org/537933 | 15:11 |
| gibi | mriedem: ^^ | 15:12 |
| mriedem | mdbooth: we don't currently block swap volume with a multiattach volume | 15:12 |
| *** patriciadomin has joined #openstack-nova | 15:12 | |
| mriedem | on the nova side | 15:12 |
| mdbooth | mriedem: Cool, so we just prevent it? I didn't look specifically last time I reviewed that patch. | 15:13 |
| mriedem | i believe on the cinder side, you can't retype a multiattach volume that is attached to an instance | 15:13 |
| mriedem | jgriffith: right ^ ? | 15:13 |
| mriedem | mdbooth: i said we don't bloc kit | 15:13 |
| mriedem | meaning we allow it | 15:13 |
| mdbooth | mriedem: Ah... | 15:14 |
| mriedem | mdbooth: if the volume's secondary attachments are only read-only, it shouldn't be an issue right? | 15:14 |
| mdbooth | mriedem: Well that's going to get a bit weird, but it won't cause data corruption. | 15:14 |
| mdbooth | Although presumably they're also going to have to swap volume, because the old one goes away, right? | 15:15 |
| *** andreas_s has quit IRC | 15:15 | |
| mriedem | not parsing that | 15:15 |
| mriedem | see L50 here for what i'm talking about https://etherpad.openstack.org/p/nova-ptg-rocky | 15:16 |
| *** andreas_s has joined #openstack-nova | 15:16 | |
| *** lajoskatona has quit IRC | 15:18 | |
| *** andreas_s_ has joined #openstack-nova | 15:18 | |
| mdbooth | The way swap volume works is we create a local COW for the volume, which means we're no longer making changes to it. We (Nova) then copies all the data from the source to the dest. During this copy, all writes are written to the COW, which is local to a compute. When the copy is complete, we commit all the changes in the COW to the new copy, then flip to the new copy. | 15:18 |
| *** janki has joined #openstack-nova | 15:18 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408 | 15:18 |
| mriedem | https://specs.openstack.org/openstack/cinder-specs/specs/queens/enable-multiattach.html | 15:18 |
| mriedem | "Again NOTE we will NOT allow retype of multiattachment setting for an in-use volume." | 15:18 |
| *** andreas_s has quit IRC | 15:18 | |
| mdbooth | mriedem: Right. If I'm understanding you correctly we missed that? | 15:18 |
| mriedem | it's supposed to be handled on the cinder side | 15:19 |
| mriedem | i don't know if that includes volume migration | 15:19 |
| *** giodeco has joined #openstack-nova | 15:19 | |
| mriedem | where it's not a retype | 15:19 |
| mriedem | jgriffith: smcginnis: ildikov: ^ | 15:19 |
| jgriffith | mriedem: it's set in the policy | 15:19 |
| *** gongysh has quit IRC | 15:19 | |
| mriedem | jgriffith: i thought we said you simply couldn't retype a multiattach in-use volume, regardless of policy | 15:19 |
| jgriffith | mriedem: You can if policy permits, default policy being admin/owner | 15:19 |
| jgriffith | mriedem: Oh | 15:20 |
| jgriffith | yes you're correct | 15:20 |
| mriedem | ok cool | 15:20 |
| jgriffith | sorry, I was confusing the bootable policy | 15:20 |
| mriedem | jgriffith: and does that apply to both retype and migration? | 15:20 |
| jgriffith | You're correct, in-use should just return and error immediately | 15:20 |
| *** pcaruana has quit IRC | 15:20 | |
| giodeco | When trying to create a new instance on my Newton Openstack env, I have an error in /var/log/nova-conductor.api of type "Corrupt image download. Checksum was d41d8cd98f00b204e9800998ecf8427e expected f8ab98ff5e73ebab884d80c9dc9c7290". I believe it is something related to network or rabbitmq. Any suggestion? | 15:20 |
| mriedem | jackie-truong: ^ | 15:21 |
| jgriffith | mriedem: that's a great question :) | 15:21 |
| mriedem | jgriffith: heh :) basically anything that triggers a call to nova's swap volume api | 15:21 |
| *** armax has joined #openstack-nova | 15:22 | |
| jackie-truong | mriedem: which question are you pointing me to? | 15:22 |
| mriedem | jackie-truong: the image checksum one | 15:22 |
| mriedem | sounds like a john hopkins image signature validation question | 15:22 |
| *** lucas-hungry is now known as lucasagomes | 15:22 | |
| jackie-truong | it does | 15:23 |
| mdbooth | mriedem: Bizarrely, we've also had users call it directly. However, I don't think that would cause a data corruption issue specifically. | 15:23 |
| jackie-truong | lemme look | 15:23 |
| *** abhishekk has quit IRC | 15:23 | |
| mriedem | mdbooth: it's an admin-only api in nova by default | 15:24 |
| jgriffith | mriedem: so currently anything that calls retype on a multiattach that's in use is going to return an exception | 15:24 |
| mriedem | so normal end users shouldn't be able to do that | 15:24 |
| jgriffith | mriedem: regardless of *how* it tries to do it | 15:24 |
| mriedem | jgriffith: does volume migration go through the retype flow even if it's not a retype? | 15:24 |
| jgriffith | mriedem: nope | 15:24 |
| mriedem | sort of like how we call cold migration a resize in nova | 15:24 |
| jgriffith | I don't know that swap ever goes through a cidner retype? | 15:24 |
| jgriffith | remember it's cinder's retype with migration that calls swap and get us in that weird case | 15:25 |
| *** alexchadin has joined #openstack-nova | 15:25 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM: test if tempest-full is triggered or not https://review.openstack.org/537936 | 15:26 |
| mriedem | jgriffith: looks like nova's swap volume is called from VolumeManager._migrate_volume_generic | 15:26 |
| *** damien_r has quit IRC | 15:26 | |
| mdbooth | mriedem: Anyway, I only brought that up to point out that it's not without precedent. Ideally it would work, but given that it has never worked I think it's a simple enough message to users that: 'This doesn't work'. In the meantime we take the reduced complexity in Nova and wait for the upstream fix. | 15:26 |
| mriedem | called from migrate_volume | 15:26 |
| jgriffith | mriedem: right, the live-migration of volumes is the trigger | 15:26 |
| jgriffith | either from the Cinder side or the Nova side; but not the swap call itself | 15:27 |
| *** itlinux has joined #openstack-nova | 15:27 | |
| jgriffith | mriedem: what I was getting at is that the swap process itself takes two volumes so that's not an issue; migrate is another story | 15:28 |
| mriedem | yeah ok i found in the volume manager code where retype calls migrate_volume | 15:29 |
| mriedem | and then there is just the migrate_volume called directly from the api | 15:29 |
| jgriffith | mriedem: my point is that I don't think there is ever a case where Nova calls cinders retype is there? | 15:29 |
| mriedem | no | 15:30 |
| mdbooth | No | 15:30 |
| mriedem | i'm only worried about the case that cinder calls nova | 15:30 |
| mriedem | to swap with a multiattach volume | 15:30 |
| jgriffith | mriedem: yeah, but in that case Cinder should've already completed (or failed) to do the work of creating the destination volume etc | 15:30 |
| mriedem | and this is the retype check in the API https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L1647 | 15:30 |
| jgriffith | so we should be *ok* | 15:30 |
| *** dave-mccowan has quit IRC | 15:31 | |
| mriedem | jgriffith: isn't ^ saying, that if i'm retyping from a multiattach=True to a multiattach=True type, we don't care if it's attached or not? | 15:31 |
| jgriffith | mriedem: right, no options there; it just won't let you do it with in-use | 15:31 |
| mriedem | well, the in-use check is only if the src/dst multiattach values are changing | 15:31 |
| mriedem | s/changing/different/ | 15:32 |
| jgriffith | mriedem: yes | 15:32 |
| jgriffith | mriedem: yes to the if the multiattach setting is the same we don't care | 15:32 |
| jgriffith | then we behave like any other retype command | 15:32 |
| mriedem | ok so we can call swap_volume in nova for a retype/migrate on a multiattach volume | 15:33 |
| mriedem | mdbooth: ^ | 15:33 |
| mriedem | we == cinder | 15:33 |
| SpazZz | hehe when yo uassociate too closely to your code | 15:33 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/537897 | 15:34 |
| jgriffith | hehe | 15:34 |
| mdbooth | mriedem: Yeah, that would definitely cause a problem. | 15:34 |
| mdbooth | SpazZz: hehe | 15:34 |
| mdbooth | I think you're right though, that cinder is probably best placed to handle that. | 15:35 |
| *** dave-mccowan has joined #openstack-nova | 15:35 | |
| mriedem | well i'll try to write up a cinder api-ref docs patch | 15:36 |
| mriedem | for all the things | 15:36 |
| mdbooth | jgriffith: Incidentally, this might be handled by context, but at first glance it looks like you've got a race there even if you fix the multiattach check. | 15:37 |
| *** david-lyle has joined #openstack-nova | 15:38 | |
| mdbooth | We're checking that volume.status is available, and if it is then we're proceeding. However, I don't see any assertion that volume.status continues to be available. | 15:38 |
| mdbooth | In Nova we typically do this by atomically changing task state. | 15:39 |
| mriedem | mdbooth: they do that here https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L1699 | 15:40 |
| mdbooth | So we'd do: if instance.status == 'all good': atomic_update(instance.task_state = 'doing my thang', expected task_state = 'whatever') | 15:40 |
| jgriffith | mdbooth: We have a conditional on the volume object IIRC | 15:40 |
| jgriffith | mdbooth: after that yeah we don't lock or anything if that's what you mean | 15:41 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 15:41 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 15:41 |
| SpazZz | IBM CI looks like it's cleaning up.. can hopefully get the my +1 back and look sexier for the Core Reviewers | 15:41 |
| SpazZz | Walk by and be like, "girlll look at all these +1's over here.." | 15:42 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408 | 15:42 |
| *** belmoreira has joined #openstack-nova | 15:42 | |
| mdbooth | jgriffith: Ah, yes. So in this case we'd want to modify 'expected' on line 1685 to contain only available. | 15:43 |
| mdbooth | Assuming conditional_update is an atomic CAS, that would completely close the race window. | 15:43 |
| mdbooth | But yeah, it's currently very short. | 15:44 |
| *** jangutter has quit IRC | 15:44 | |
| *** alexchadin has quit IRC | 15:45 | |
| *** elmaciej has quit IRC | 15:46 | |
| jgriffith | mdbooth: yeah, IMO there's probably going to be some additions/fixes that are more critical to this before we get to things like closing that up. | 15:47 |
| mdbooth | jgriffith: Easy to close, hard to spot... | 15:48 |
| *** sree has joined #openstack-nova | 15:49 | |
| *** bpoulos has joined #openstack-nova | 15:50 | |
| *** damien_r has joined #openstack-nova | 15:50 | |
| *** rmart04 has quit IRC | 15:50 | |
| *** Guest14094 has quit IRC | 15:51 | |
| *** hongbin has joined #openstack-nova | 15:52 | |
| *** matrohon has joined #openstack-nova | 15:53 | |
| *** sree has quit IRC | 15:53 | |
| *** jackie-truong has quit IRC | 15:57 | |
| *** slaweq has quit IRC | 15:57 | |
| *** slaweq has joined #openstack-nova | 15:58 | |
| *** elmaciej has joined #openstack-nova | 16:00 | |
| *** belmoreira has quit IRC | 16:00 | |
| *** armax_ has joined #openstack-nova | 16:01 | |
| *** smatzek has left #openstack-nova | 16:01 | |
| -openstackstatus- NOTICE: logs.openstack.org is stabilized and there should no longer be *new* POST_FAILURE errors. Logs for jobs that ran in the past weeks until earlier today are currently unavailable pending FSCK completion. We're going to temporarily disable *successful* jobs from uploading their logs to reduce strain on our current limited capacity. Thanks for your patience ! | 16:02 | |
| *** slaweq has quit IRC | 16:02 | |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Reduce complexity of _from_db_object https://review.openstack.org/537728 | 16:02 |
| *** Tom-Tom_ has joined #openstack-nova | 16:03 | |
| *** armax has quit IRC | 16:03 | |
| *** armax_ is now known as armax | 16:03 | |
| *** Guest14094 has joined #openstack-nova | 16:04 | |
| *** Tom-Tom has quit IRC | 16:06 | |
| *** gszasz has quit IRC | 16:07 | |
| Tengu | hello, anyone can tell me what the error "NovaException: Unsupported VIF type unbound convert '_nova_to_osvif_vif_unbound'" means? it apparently prevents launching a new instance in a specific project/tenant on openstack pike. | 16:11 |
| *** yamahata has quit IRC | 16:11 | |
| mriedem | Tengu: probably means an unexpected vif type for the port and nova doesn't know how to handle it | 16:11 |
| mriedem | sean-k-mooney: ^ | 16:11 |
| Tengu | mriedem: hmm. weird thing is: this happens only in one project :/. | 16:12 |
| bpoulos | giodeco: The checksum error you're seeing isn't related to image signature verification. It looks like it's a Glance Exception raised if the MD5 checksum of the image isn't as expected (signature verification doesn't use MD5). See http://git.openstack.org/cgit/openstack/python-glanceclient/tree/glanceclient/common/utils.py#n415 | 16:12 |
| mriedem | Tengu: then i don't know | 16:12 |
| Tengu | and I didn't change anything in the configuration :/. | 16:12 |
| Tengu | might it be related to some kind of quota? | 16:12 |
| mriedem | not on the nova side | 16:12 |
| Tengu | hmm. | 16:12 |
| Tengu | shall I ping on neutron channel? | 16:13 |
| mriedem | http://codesearch.openstack.org/?q=Unsupported%20VIF%20type&i=nope&files=&repos= | 16:13 |
| *** Tom-Tom_ has quit IRC | 16:13 | |
| Tengu | hmmm, nova-network is deprecated and not in use anymore in pike, is it? | 16:13 |
| mriedem | this isn't nova-network | 16:14 |
| Tengu | oh. | 16:14 |
| mriedem | the libvirt driver in nova needs to know how to handle the vif type to setup the guest xml properly when attaching the network interface | 16:14 |
| Tengu | hmm. | 16:15 |
| Tengu | if it was for all project in the openstack deploy, I'd say "due to update"… but this isn't the case. | 16:15 |
| mriedem | what is the vif type? the error is saying the vif type is "unbound" for some reason | 16:15 |
| mriedem | which isn't correct | 16:15 |
| sean-k-mooney | mriedem: it means some how the ovs_vif_utill.py fucntion with a neutron port that we have not done port binding on yet | 16:15 |
| sean-k-mooney | mriedem: e.g. vif_unbound is the state a port is in before it is added to a vm | 16:16 |
| Tengu | mriedem: how may I check that? | 16:16 |
| mriedem | Tengu: check the neutron logs for an error with port binding | 16:16 |
| mriedem | it's probably a port binding failure on the neutron side | 16:16 |
| mriedem | causing a side effect issue in nova | 16:16 |
| mriedem | which could possibly be due to quota in neutron, idk | 16:16 |
| Tengu | mriedem: hmm ok. I'll check on the neutron channel then. | 16:17 |
| ildikov | jgriffith: mriedem: smcginnis: jungleboyj: sorry, I admit I'm a bit more disorganized this week than I expected :/ | 16:17 |
| *** jafeha has quit IRC | 16:17 | |
| ildikov | jgriffith: mriedem: smcginnis: jungleboyj: shall we have a short meeting? | 16:17 |
| Tengu | mriedem: thank you for your support :). | 16:17 |
| mriedem | ildikov: i'd like to skip this week if possible | 16:18 |
| mriedem | lots of stuff to deal with today | 16:18 |
| mriedem | Tengu: np | 16:18 |
| *** klindgren__ has quit IRC | 16:18 | |
| ildikov | mriedem: all good, just wanted to check in whether there's anything we should talk about today or we can skip | 16:18 |
| ildikov | mriedem: tnx | 16:19 |
| *** andreas_s_ has quit IRC | 16:23 | |
| sean-k-mooney | mriedem: if it was a port binding failure in neutron it should be VIF_BINDING_FAILED not unbound | 16:23 |
| *** andreas_s has joined #openstack-nova | 16:24 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add release note for QEMU native LUKS decryption https://review.openstack.org/537642 | 16:25 |
| *** andreas_s_ has joined #openstack-nova | 16:25 | |
| *** beagles has joined #openstack-nova | 16:26 | |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/537897 | 16:27 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408 | 16:27 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 16:27 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 16:27 |
| *** suresh12 has joined #openstack-nova | 16:27 | |
| mriedem | gmann: here is the patch that adds the nova-multiattach job to tempest: https://review.openstack.org/#/c/537957/ | 16:27 |
| *** andreas_s has quit IRC | 16:28 | |
| *** matrohon has quit IRC | 16:29 | |
| *** andreas_s_ has quit IRC | 16:30 | |
| Tengu | sahid: hello! are you here? | 16:30 |
| *** dtantsur|afk is now known as dtantsur | 16:31 | |
| efried | jaypipes I've now noticed that weird stalling behavior without having rechecked anything nearby, so it was probably just coincidence. I still don't like it, though. | 16:32 |
| Tengu | sean-k-mooney: hello! are you here? | 16:33 |
| *** jangutter has joined #openstack-nova | 16:33 | |
| Tengu | mriedem: I was sent back here in order to get info from either sahid or sean-k-mooney - as they are the devs of the os-vif-core :). Pretty sure they will know a bit more about my issue. | 16:34 |
| * mriedem hides | 16:34 | |
| Tengu | :) | 16:35 |
| *** chyka has joined #openstack-nova | 16:35 | |
| *** jangutter has quit IRC | 16:38 | |
| *** elmaciej has quit IRC | 16:40 | |
| *** tidwellr has quit IRC | 16:40 | |
| *** tidwellr has joined #openstack-nova | 16:41 | |
| *** bhujay has quit IRC | 16:41 | |
| *** openstackstatus has quit IRC | 16:41 | |
| *** hrw has quit IRC | 16:42 | |
| *** sahid has quit IRC | 16:42 | |
| *** linkmark has joined #openstack-nova | 16:43 | |
| *** openstackstatus has joined #openstack-nova | 16:43 | |
| *** ChanServ sets mode: +v openstackstatus | 16:43 | |
| *** hrw has joined #openstack-nova | 16:44 | |
| *** Eran_Kuris has quit IRC | 16:45 | |
| efried | gibi stephenfin If you're still around, care to push this 'un? https://review.openstack.org/#/c/536624/ | 16:45 |
| *** andreas_s has joined #openstack-nova | 16:45 | |
| *** jafeha has joined #openstack-nova | 16:46 | |
| efried | or mriedem dansmith if you don't mind jumping into the middle of this series. The change itself is fairly small and straightforward, though understanding how and where it fits in is a bigger job. | 16:47 |
| *** chyka has quit IRC | 16:48 | |
| *** hamzy has quit IRC | 16:49 | |
| *** chyka has joined #openstack-nova | 16:49 | |
| ameeda | gmann: can you please check this "https://review.openstack.org/#/c/526900/" ? | 16:49 |
| *** slaweq has joined #openstack-nova | 16:49 | |
| *** andreas_s has quit IRC | 16:50 | |
| stephenfin | efried: Yeah, I can grab that | 16:50 |
| efried | stephenfin Thanks! | 16:50 |
| mriedem | looking | 16:51 |
| mriedem | why was it using sets? | 16:51 |
| gibi | efried: done | 16:51 |
| mriedem | and are there problems if we're not ensuring uniqueness now? | 16:51 |
| efried | gibi Thanks! stephenfin ^ | 16:51 |
| gibi | stephenfin: sorry | 16:51 |
| stephenfin | gibi: Nope, suits me :) | 16:51 |
| efried | mriedem The only real reason it was using sets before was for O(1) operations. | 16:51 |
| stephenfin | bauzas has been bugging me about this vGPU thing anyway | 16:51 |
| * stephenfin wonders if that one's also gone in already | 16:52 | |
| mriedem | stephenfin: the vgpu stuff is all approved | 16:52 |
| efried | mriedem And as super-double-insurance that we don't have cycles in the "tree". But that's prevented elsewise in a number of ways. | 16:52 |
| stephenfin | Ha! | 16:52 |
| stephenfin | I should work on bugs more often | 16:52 |
| mriedem | god this provider tree stuff, | 16:52 |
| stephenfin | Everyone does my work for me | 16:52 |
| mriedem | all reminds me of some graph traversal stuff i wrote like 10 years ago at ibm | 16:52 |
| efried | mriedem But the trees should be small enough that O(lognN) is no big deal, and is a rounding error anyway against all the placement API calls that feed it. | 16:52 |
| mriedem | back when i was young and smart | 16:52 |
| efried | Not sure how that makes me feel, considering I'm older than you (pretty sure) | 16:53 |
| mriedem | <- 36 | 16:53 |
| efried | 41 | 16:53 |
| mriedem | jesus you're old | 16:53 |
| efried | ikr | 16:53 |
| *** slaweq has quit IRC | 16:53 | |
| efried | Man, when I was 36 I could do anything. | 16:53 |
| efried | Now I sound like a bowl of rice krispies getting out of bed. | 16:54 |
| efried | So anyway, I think I now have 8 patches at the mercy of zuul. Bottom one of that series has been thrashing around for three full days. | 16:55 |
| mriedem | ooo nice osc-placement docs are published https://docs.openstack.org/osc-placement/latest/ | 16:55 |
| *** links has quit IRC | 16:57 | |
| mriedem | and releasenotes, although the version isn't what i expected https://docs.openstack.org/releasenotes/osc-placement/unreleased.html | 16:57 |
| *** tesseract has quit IRC | 16:58 | |
| * gibi calls it a day. Happy FF folks! | 16:58 | |
| edmondsw | stephenfin if you're looking for something to review... :) https://review.openstack.org/#/c/526094/ | 16:59 |
| stephenfin | edmondsw: Darn, I thought I'd got away with the powerVM stuff | 16:59 |
| edmondsw | and they just reel ya back in... | 17:00 |
| edmondsw | that's the last one | 17:00 |
| *** slaweq has joined #openstack-nova | 17:00 | |
| *** penick has joined #openstack-nova | 17:01 | |
| dansmith | efried: looks like that set has a pretty healthy set of +2+W already, up to a patch with a -1 and no response | 17:01 |
| *** giodeco has quit IRC | 17:01 | |
| *** jackie-truong has joined #openstack-nova | 17:02 | |
| *** slaweq has quit IRC | 17:02 | |
| *** fragatina has joined #openstack-nova | 17:02 | |
| openstackgerrit | Stephen Finucane proposed openstack/osc-placement master: Resolve nits from I552688b9ee32b719a576a7a9ed5e4d5aa31d7b3f https://review.openstack.org/537971 | 17:03 |
| *** fragatin_ has joined #openstack-nova | 17:03 | |
| stephenfin | mriedem, melwitt: Fancy pushing that through? ^ | 17:03 |
| mriedem | stephenfin: i know you love to `` everything | 17:04 |
| mriedem | but that's going to look weird in a shell | 17:04 |
| *** janki has quit IRC | 17:05 | |
| stephenfin | Yeah, that's a good point actually | 17:05 |
| stephenfin | cliff should probably strip those | 17:06 |
| mriedem | it's the best point i've ever made i think | 17:06 |
| *** abhishekk has joined #openstack-nova | 17:06 | |
| *** Supun has joined #openstack-nova | 17:06 | |
| *** munimeha has joined #openstack-nova | 17:06 | |
| openstackgerrit | Stephen Finucane proposed openstack/osc-placement master: Resolve nits from I552688b9ee32b719a576a7a9ed5e4d5aa31d7b3f https://review.openstack.org/537971 | 17:07 |
| *** fragatina has quit IRC | 17:07 | |
| mriedem | stephenfin: you didn't even have nits in https://review.openstack.org/#/c/536858/ :) | 17:10 |
| stephenfin | Let's call it muscle memory | 17:10 |
| stephenfin | Or me not waiting for the CI to build docs before approving them 🙈 | 17:10 |
| dansmith | er, I guess that one is not part of the main stack | 17:11 |
| jlvillal | stephenfin, dansmith mriedem: You may want to move your jobs out of the Zuul 'integrated' queue. | 17:11 |
| jlvillal | We (Ironic) set our queue as 'ironic' | 17:12 |
| *** sree has joined #openstack-nova | 17:12 | |
| jlvillal | I notice the 'integrated' queue is enormous at the moment. | 17:12 |
| jlvillal | http://zuul.openstack.org/ | 17:12 |
| dansmith | jlvillal: um, what? doesn't that mean you don't co-gate with other projects? | 17:12 |
| jlvillal | dansmith, Yeah. | 17:12 |
| mriedem | kind of defeats the purpose of gating | 17:12 |
| dansmith | doesn't that defeat the whole thing we're doing here? | 17:12 |
| dansmith | yeah. | 17:13 |
| *** jistr is now known as jistr|conf | 17:13 | |
| jlvillal | Well we gate with our patches. | 17:13 |
| jlvillal | But yeah, not with cinder, glance, nova, etc... | 17:13 |
| dansmith | right, but it means you don't get tested against ours, and we don't get tested with yours | 17:13 |
| jlvillal | True. We did that after we migrated over. | 17:14 |
| mriedem | can someone turn on the sdague signal | 17:14 |
| jlvillal | Not sure if the tradeoffs are worth it or not. | 17:14 |
| *** dtantsur is now known as dtantsur|afk | 17:15 | |
| jlvillal | Too bad they don't have a 'depend' on queue. Instead of everyone goes in the same bucket queue | 17:15 |
| *** jaypipes has quit IRC | 17:16 | |
| *** sree has quit IRC | 17:16 | |
| dansmith | jlvillal: depends-on between queues just makes it one queue no? | 17:17 |
| jlvillal | dansmith, Not a gerrit depends-on for one. | 17:18 |
| * dansmith is oh-so-confused | 17:19 | |
| jlvillal | dansmith, Now if 'ironic' depends on 'nova'. And 'glance' depends on 'nova' But ironic and glance don't depend on each other. | 17:19 |
| jlvillal | dansmith, So in the gate queue a failed glance wouldn't cause the ironic job to get re-queued. | 17:20 |
| jlvillal | dansmith, They do not have this idea of a 'depend' in zuul queues. There is just a queue. | 17:20 |
| jlvillal | It was a random idea. | 17:20 |
| dansmith | I see what you mean, but I'm not sure the benefit is worth that complexity | 17:21 |
| jlvillal | dansmith, Yeah probably right. I just saw your nova jobs that have been 18 hours + in the gate queue. So that is why I mentioned it. | 17:21 |
| *** abhishekk has quit IRC | 17:22 | |
| dansmith | yeah, we're definitely feeling that pain, but.. | 17:22 |
| *** hrw has quit IRC | 17:25 | |
| *** jangutter has joined #openstack-nova | 17:28 | |
| *** jangutter has quit IRC | 17:31 | |
| *** jangutter has joined #openstack-nova | 17:32 | |
| *** jose-phillips has joined #openstack-nova | 17:32 | |
| *** jangutter has quit IRC | 17:33 | |
| *** jangutter has joined #openstack-nova | 17:33 | |
| mriedem | gibi: once the two approved versioned notification transformation changes are merged https://review.openstack.org/#/q/topic:bp/versioned-notification-transformation-queens+status:open i'm going to close that bp and open another one for rocky for anything left | 17:34 |
| *** abhishekk has joined #openstack-nova | 17:37 | |
| mriedem | so is bauzas out today? | 17:38 |
| dansmith | apparently | 17:38 |
| *** itlinux has quit IRC | 17:38 | |
| dansmith | he's not on our calendar as being out, but I've pinged him a few times yesterday and today already and haven't seen any response | 17:38 |
| *** gouthamr has quit IRC | 17:38 | |
| *** penick has quit IRC | 17:38 | |
| dansmith | he was doing some conf thing earlier in the week, but I'm surprised he hasn't popped back up yet | 17:39 |
| *** gouthamr has joined #openstack-nova | 17:40 | |
| *** yamamoto has quit IRC | 17:40 | |
| *** slaweq has joined #openstack-nova | 17:41 | |
| *** penick has joined #openstack-nova | 17:42 | |
| *** esberglu has quit IRC | 17:42 | |
| *** abhishekk has quit IRC | 17:42 | |
| *** yamamoto has joined #openstack-nova | 17:43 | |
| *** yamamoto has quit IRC | 17:44 | |
| *** yamamoto has joined #openstack-nova | 17:44 | |
| *** slaweq has quit IRC | 17:46 | |
| mriedem | oh right snowbunnies | 17:48 |
| *** abhishekk has joined #openstack-nova | 17:51 | |
| *** derekh has quit IRC | 17:54 | |
| *** slaweq has joined #openstack-nova | 17:54 | |
| jackie-truong | dansmith: RE: https://review.openstack.org/#/c/537728/ | 17:55 |
| jackie-truong | dansmith: I wasn't sure if we needed to reassign instance._context | 17:55 |
| jackie-truong | dansmith: The more I look at it, I'm thinking "no" | 17:55 |
| jackie-truong | dansmith: Should I remove? | 17:55 |
| dansmith | jackie-truong: it's done on L342 why would you have to do it again? | 17:56 |
| jackie-truong | dansmith: i was a little confused as to how things were getting passed around | 17:56 |
| dansmith | jackie-truong: you're calling that method :) | 17:56 |
| *** Guest14094 has quit IRC | 17:57 | |
| dansmith | jackie-truong: it's set on instance above, then you pass it to another method, so... it's still set | 17:57 |
| jackie-truong | dansmith: kk i'll remove | 17:57 |
| *** abhishekk has quit IRC | 17:58 | |
| * dansmith notes jackie-truong has her gerrit reviews on 5-second refresh | 17:58 | |
| *** jangutter has quit IRC | 17:58 | |
| *** AlexeyAbashkin has quit IRC | 17:59 | |
| jackie-truong | outlook pop-ups ;-) | 17:59 |
| * dansmith shudders | 17:59 | |
| dansmith | I figured you had an army of interns, one patch per intern, tasked with rapid-fire refreshing until midnight | 17:59 |
| jackie-truong | nope, that was just me sitting on the couch, eating nachos | 18:00 |
| dansmith | hah nice | 18:00 |
| *** Guest14094 has joined #openstack-nova | 18:00 | |
| *** slaweq has quit IRC | 18:02 | |
| *** ralonsoh_ has quit IRC | 18:02 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Reduce complexity of _from_db_object https://review.openstack.org/537728 | 18:05 |
| *** sridharg has quit IRC | 18:05 | |
| dansmith | jackie-truong: why do you keep pushing these up one by one? do you not have them in a proper stack? | 18:05 |
| *** sapcc-bot1 has joined #openstack-nova | 18:06 | |
| jackie-truong | dansmith: i don't think i know what i'm doing when it comes to tying the patches together for gerrit | 18:06 |
| *** suresh12 has quit IRC | 18:07 | |
| *** brault_ has joined #openstack-nova | 18:07 | |
| dansmith | jackie-truong: so you're doing what? rebasing the second one on the first, then the third on the second, etc? | 18:07 |
| dansmith | all in separate branches? | 18:07 |
| mriedem | git rebase -i | 18:07 |
| *** lyan has quit IRC | 18:07 | |
| *** sapcc-bot has quit IRC | 18:07 | |
| mriedem | is your friend | 18:07 |
| dansmith | yeah | 18:07 |
| mriedem | rebase the entire series at once, | 18:07 |
| *** izombie has joined #openstack-nova | 18:07 | |
| mriedem | modify the patches you need | 18:07 |
| *** lyan has joined #openstack-nova | 18:07 | |
| *** david-lyle has quit IRC | 18:08 | |
| mriedem | https://docs.openstack.org/infra/manual/developers.html#rebasing-a-commit | 18:08 |
| jackie-truong | oh. i was definitely doing "rebasing the second one on the first, then the third on the second, etc"... | 18:08 |
| dansmith | then you'll hate us a little less for asking them to be split up :) | 18:08 |
| mriedem | step 2 there can be 'git rebase -i master' | 18:08 |
| mriedem | in which case you get a menu to select the commits you want to edit | 18:08 |
| dansmith | jackie-truong: so do your rebase thing like normal this time, but before you submit, rebase the whole thing on master and then try "git rebase -i master" and see what it gives you | 18:09 |
| izombie | I'm trying to setup nova api manually and paste api seems to evasive. When I'm trying to list servers, I'm getting 404. Any suggestions on what could be the reason? | 18:09 |
| dansmith | i.e. git checkout master; git pull; git checkout last-patch-branch; git rebase -i master | 18:09 |
| *** weshay|ruck is now known as weshay|ruck|brb | 18:09 | |
| *** penick has quit IRC | 18:09 | |
| *** mgoddard_ has quit IRC | 18:09 | |
| *** brault has quit IRC | 18:09 | |
| jackie-truong | yeah, so i usually rebase on master (git rebase -i master), but that's just for one patch | 18:10 |
| jackie-truong | so you're saying checkout the api patch in this case, then rebase on master | 18:10 |
| *** bpoulos has quit IRC | 18:11 | |
| *** jangutter has joined #openstack-nova | 18:11 | |
| dansmith | jackie-truong: well, you have modified the bottom one now, so you need to do your normal rebase one by one thing | 18:11 |
| dansmith | jackie-truong: but then once that is done, | 18:11 |
| dansmith | only use the api patch's branch from now on, and run git rebase -i master from that one | 18:12 |
| jackie-truong | dansmith: got it, thanks! | 18:12 |
| dansmith | jackie-truong: it'll show you all your patches from master on, and let you edit them without changing the stack | 18:12 |
| jackie-truong | so much time has been wasted on individual pushes... | 18:12 |
| dansmith | jackie-truong: then when you git review, it'll show you all the ones pending, and you'll see them all go up in one go here in channel | 18:12 |
| dansmith | jackie-truong: ....yeah :) | 18:13 |
| *** gouthamr has quit IRC | 18:13 | |
| *** hamzy has joined #openstack-nova | 18:13 | |
| *** izombie has quit IRC | 18:13 | |
| *** jistr|conf is now known as jistr | 18:14 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: fixes mock autospec usage https://review.openstack.org/447505 | 18:14 |
| *** lpetrut has quit IRC | 18:16 | |
| *** munimeha has quit IRC | 18:16 | |
| *** izombie_ has joined #openstack-nova | 18:16 | |
| mriedem | git review -y to push the entire stack | 18:16 |
| *** fragatin_ has quit IRC | 18:16 | |
| mriedem | it will prompt you though | 18:16 |
| mriedem | if you don't use -y | 18:16 |
| mriedem | -R if you don't want to rebase unchanged patches at the bottom the stack | 18:17 |
| *** izombie_ is now known as izombie | 18:17 | |
| mriedem | but maybe that's getting advanced | 18:17 |
| dansmith | I never use -y | 18:17 |
| mriedem | git rebase -i HEAD~3 etc | 18:17 |
| dansmith | because if I have messed up the rebase, I might resubmit a year's worth of changes | 18:17 |
| mriedem | i use git rebase -R -y quite often | 18:17 |
| *** hamzy has quit IRC | 18:18 | |
| *** damien_r has quit IRC | 18:20 | |
| *** rmcall has quit IRC | 18:20 | |
| *** gouthamr has joined #openstack-nova | 18:20 | |
| *** hamzy has joined #openstack-nova | 18:21 | |
| *** sambetts is now known as sambetts|afk | 18:22 | |
| *** READ10 has joined #openstack-nova | 18:23 | |
| *** imacdonn has quit IRC | 18:26 | |
| *** jackie-truong has quit IRC | 18:26 | |
| *** imacdonn has joined #openstack-nova | 18:26 | |
| *** naichuans_ has quit IRC | 18:27 | |
| *** jangutter has quit IRC | 18:27 | |
| *** weshay|ruck|brb is now known as weshay | 18:27 | |
| *** esberglu has joined #openstack-nova | 18:28 | |
| *** fragatina has joined #openstack-nova | 18:30 | |
| melwitt | mriedem: I'm good with this ironic "get IP address for volume connector" change if you wanted to revisit it https://review.openstack.org/#/c/468353 | 18:31 |
| *** gouthamr has quit IRC | 18:35 | |
| *** goutham__ has joined #openstack-nova | 18:35 | |
| mriedem | melwitt: ok | 18:39 |
| *** Spazmotic has quit IRC | 18:39 | |
| *** lyan has quit IRC | 18:39 | |
| *** Spazmotic has joined #openstack-nova | 18:41 | |
| *** yamamoto has quit IRC | 18:42 | |
| *** amoralej is now known as amoralej|off | 18:43 | |
| *** jpena is now known as jpena|off | 18:45 | |
| *** fragatina has quit IRC | 18:49 | |
| *** lucasagomes is now known as lucas-afk | 18:50 | |
| *** hrw has joined #openstack-nova | 18:52 | |
| hrw | hello again | 18:52 |
| hrw | stephenfin: https://paste.fedoraproject.org/paste/2PNsiE0OF0VYnF~sKHdXdw is initial version of 'lets add usb host' patch | 18:53 |
| hrw | stephenfin: I though it will be more complicated | 18:53 |
| mriedem | melwitt: wording question in https://review.openstack.org/#/c/537642/ | 18:54 |
| mriedem | edleafe: i don't think your alternate hosts change is ever going to get out of the check queue... | 18:56 |
| *** yamahata has joined #openstack-nova | 18:56 | |
| edleafe | mriedem: maybe we need alternate CI | 18:57 |
| edleafe | :) | 18:57 |
| *** lyan has joined #openstack-nova | 19:00 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add release note for QEMU native LUKS decryption https://review.openstack.org/537642 | 19:01 |
| *** psachin has quit IRC | 19:02 | |
| openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: [dnm] Make sure that we have USB Host controller for tablet https://review.openstack.org/538003 | 19:05 |
| *** lyan has quit IRC | 19:06 | |
| hrw | please take a look as I am not sure is it proper way of doing that | 19:06 |
| *** hoonetorg has quit IRC | 19:07 | |
| *** david-lyle has joined #openstack-nova | 19:09 | |
| *** david-lyle has quit IRC | 19:09 | |
| *** yamahata has quit IRC | 19:09 | |
| *** lyan has joined #openstack-nova | 19:10 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Ironic: Get IP address for volume connector https://review.openstack.org/468353 | 19:10 |
| mriedem | melwitt: check my release note update on ^ and see if that's still OK, then i'll +W | 19:10 |
| * melwitt looks | 19:11 | |
| *** chyka has quit IRC | 19:12 | |
| *** chyka has joined #openstack-nova | 19:13 | |
| melwitt | mriedem: looks good to me | 19:13 |
| mriedem | want to put your +2 back on? | 19:14 |
| melwitt | yep done | 19:14 |
| *** lpetrut has joined #openstack-nova | 19:16 | |
| mriedem | efried: so i should defer https://blueprints.launchpad.net/nova/+spec/granular-resource-requests to rocky right? | 19:18 |
| mriedem | i think that was mentioned as a rocky thing at this point in the meeting today | 19:18 |
| *** slaweq has joined #openstack-nova | 19:19 | |
| efried | mriedem It can't be finished in Q, because dependent on nrp alloc cands work, which probably also won't make Q. But 95% of the code is done and merged (months ago). | 19:19 |
| efried | mriedem So however you want to paperwork that... | 19:19 |
| mriedem | can't functionality use it yet from the API right? | 19:19 |
| efried | correct | 19:19 |
| mriedem | ok, then i'll defer | 19:20 |
| efried | ack | 19:20 |
| *** chyka has quit IRC | 19:23 | |
| *** chyka has joined #openstack-nova | 19:24 | |
| *** AlexeyAbashkin has joined #openstack-nova | 19:24 | |
| mriedem | mgoddard: so on the nova ironic traits stuff, | 19:24 |
| mriedem | it looks like the ironic API changes are done https://review.openstack.org/#/q/topic:bug/1722194+(status:open+OR+status:merged) | 19:25 |
| mriedem | and the ironicclient changes to support it are approved, but not yet released, and today is client release freeze | 19:25 |
| mriedem | and nova would need to bump the minimum required version of this in global-requirements to use the new client stuff, and i think the requirements team is going to freeze the requirements repo after today too | 19:25 |
| mriedem | jlvillal: are you waiting for these ironicclient changes to merge before you do the final ironicclient release for queens? ^ | 19:26 |
| *** david-lyle has joined #openstack-nova | 19:26 | |
| efried | mriedem The nova side stuff isn't all approved yet either FYI: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/ironic-driver-traits | 19:27 |
| *** bpoulos has joined #openstack-nova | 19:27 | |
| mriedem | efried: i know, | 19:27 |
| efried | k :) | 19:27 |
| mriedem | i'm asking because i don't want to waste my time on the nova stuff if the deps won't get merged int time | 19:27 |
| mriedem | the ironic client change failed in the gate with a post failure, so it's going to have at least one recheck yet | 19:27 |
| mriedem | plus a release, plus a g-r bump | 19:28 |
| efried | Not happening today. | 19:28 |
| efried | no chance | 19:28 |
| *** AlexeyAbashkin has quit IRC | 19:28 | |
| jlvillal | mriedem, I am not sure rloo and TheJulia know more the current status than me. | 19:28 |
| mriedem | ok jroll is asking in -release too | 19:29 |
| TheJulia | Moving to laptop with battery power | 19:29 |
| *** rloo has joined #openstack-nova | 19:29 | |
| TheJulia | mriedem: thanks for the recheck | 19:31 |
| TheJulia | mriedem: yes, waiting for the client changes we need to merge before cutting the release :( | 19:32 |
| rloo | mriedem: the traits work will land for sure; just one client patch in gate. the rescue work has been approved but we need 2 ironic patches to land before client can land. and gate is super not-fast today as you probably know :-( | 19:33 |
| mriedem | there hasn't been any review on the nova patches for rescue, so that's going to be deferred | 19:34 |
| mriedem | also https://review.openstack.org/#/c/508116/ - that doesn't bump the minimum required ironic api version to 1.37 before trying to patch the node with traits | 19:35 |
| mriedem | but that's required isn't it? | 19:35 |
| mriedem | jroll: ^ | 19:35 |
| *** rmcall has joined #openstack-nova | 19:35 | |
| mriedem | we'll likely need someone to work the nova patches at this point since i'm guessing mgoddard and johnthetubaguy are eating boiled meat at this point | 19:35 |
| rloo | mriedem: boiled meat. yummmy. which is better, doing that or reviewing? i'll take a look at the nova patches in a few min. | 19:36 |
| jroll | I can help too | 19:37 |
| mriedem | well i'm assuming the mv needs to change to 1.37 since that's the ironic api version that added traits support | 19:37 |
| jroll | it doesn't | 19:37 |
| mriedem | i could be wrong, there are a lot of +1s on there | 19:37 |
| jroll | explaining in gerrit now | 19:37 |
| mriedem | ok | 19:37 |
| jroll | comment is there mriedem | 19:38 |
| jroll | and this is the one that needs the api version bump https://review.openstack.org/#/c/532288/9 | 19:38 |
| jroll | since it's grabbing the traits from the node | 19:39 |
| *** fragatina has joined #openstack-nova | 19:39 | |
| *** chyka has quit IRC | 19:40 | |
| *** chyka_ has joined #openstack-nova | 19:41 | |
| *** slaweq has quit IRC | 19:41 | |
| izombie | Trying to list servers and I'm hitting 404 and I can't understand why | 19:41 |
| izombie | Any help? | 19:41 |
| TheJulia | on a plus side jroll, that is the correct version :) | 19:42 |
| *** yamamoto has joined #openstack-nova | 19:43 | |
| jroll | yep! | 19:44 |
| *** Guest14094 has quit IRC | 19:44 | |
| *** harlowja has joined #openstack-nova | 19:44 | |
| mriedem | izombie: check the nova-api logs | 19:45 |
| mriedem | jroll: ah ok, thanks | 19:45 |
| izombie | :) I did. Even debugged! I'm lost the route is not matched. It reaches till route middleware and then throws HTTPNotFound | 19:46 |
| *** Guest14094 has joined #openstack-nova | 19:48 | |
| artom | izombie, technically I'm supposed to send you to #openstack (see /topic) | 19:48 |
| melwitt | mriedem: any particular reviews I can help with today? | 19:49 |
| artom | izombie, but, what request are you making? | 19:49 |
| izombie | Simple nova list. And it breaks here https://github.com/openstack/nova/blob/master/nova/wsgi.py#L458 | 19:49 |
| izombie | artom: thanks for not sending :P | 19:50 |
| artom | izombie, well, I did, in a hint-y sort of way ;) | 19:50 |
| artom | izombie, can you run the client in --debug? | 19:50 |
| artom | And what are you running it against? devstack? | 19:50 |
| izombie | I will try my luck there, meanwhile I thought to try my luck here as I'm out of it now | 19:51 |
| mriedem | melwitt: i'm just going through this ironic driver traits series | 19:51 |
| mriedem | https://review.openstack.org/#/c/508116/ | 19:51 |
| *** jackie-truong has joined #openstack-nova | 19:51 | |
| *** yamamoto has quit IRC | 19:55 | |
| *** avolkov has quit IRC | 19:57 | |
| *** esberglu has quit IRC | 19:57 | |
| *** goutham__ has quit IRC | 19:58 | |
| *** Supun has quit IRC | 19:58 | |
| izombie | guess, I won't fix it today. | 19:58 |
| *** izombie has quit IRC | 19:58 | |
| artom | I mean, I did ask them --debug output :/ | 19:58 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Refactor _build_device_metadata https://review.openstack.org/533804 | 19:59 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Consider hostdev devices when building metadata https://review.openstack.org/533805 | 19:59 |
| efried | mriedem The ironic traits thing, we're trying to get it in? | 20:00 |
| efried | mriedem I can probably do any last-minute changes if you didn't get another volunteer. | 20:00 |
| mriedem | we'll see | 20:01 |
| mriedem | i'm reviewing the changes now yes, | 20:01 |
| jroll | I'm happy to help too | 20:01 |
| mriedem | which requires looking at some of the provider tree stuff that already merged, like set_traits_for_provider | 20:01 |
| efried | mriedem Yes, that was a prereq. Let me know if you want the exec summary on that. | 20:01 |
| mriedem | i don't suppose there are any integration tests anywhere in ironic that run something that plumbs this all through | 20:03 |
| mriedem | like, create a flavor with a required trait, decorate a node with it, pass the trait from the node to the resource provider in placement, etc | 20:03 |
| *** chyka_ has quit IRC | 20:03 | |
| jroll | nope | 20:03 |
| *** chyka has joined #openstack-nova | 20:04 | |
| jroll | not terribly hard to do other than the time crunch | 20:04 |
| mriedem | you gonna tattoo a todo for yourself? | 20:05 |
| jroll | I'll think about it :P | 20:05 |
| mriedem | we could also have a simple functional test in-tree that has a fake virt driver that returns a fake trait, and we make sure that the RT and such creates it in placement for us | 20:05 |
| jroll | I can add it to the existing job pretty easy | 20:05 |
| mriedem | rather than just these lowly unit test | 20:05 |
| *** esberglu has joined #openstack-nova | 20:06 | |
| mriedem | jroll: that test_get_traits_with_no_traits_attr test can also go away once we require 1.37 and depend on ironicclient to give us a node object that has a traits attribute | 20:12 |
| mriedem | jroll: you want to update https://review.openstack.org/#/c/532288/ then? | 20:13 |
| mriedem | i'll be +2 after removing the hasattr thing | 20:13 |
| jroll | mriedem: heh, we wrote a test for that? fun | 20:13 |
| jroll | I can do that but it'll fail hard until we release a new client | 20:14 |
| mriedem | welp, | 20:14 |
| mriedem | alternative is, | 20:14 |
| *** hoonetorg has joined #openstack-nova | 20:14 | |
| *** slaweq has joined #openstack-nova | 20:14 | |
| mriedem | we push a change on top that removes that, and has a dependency on whatever g-r bump we're going to have for the new ironicclient release version | 20:15 |
| jroll | oh, I'm fine with the former, just letting you know it won't be landable | 20:15 |
| jroll | (see also my -1 for the hasattr thing) | 20:15 |
| mriedem | i'm ok with it not being landable until the deps are done | 20:15 |
| mriedem | i did | 20:15 |
| mriedem | i'll FFE this | 20:16 |
| jroll | I'll hack out some sort of functional or integration test too | 20:16 |
| mriedem | alright, you might want to save any in-tree functional test patch for something that goes on top of the series | 20:16 |
| jroll | sure | 20:16 |
| *** Jeffrey4l has quit IRC | 20:19 | |
| *** chyka has quit IRC | 20:21 | |
| *** chyka has joined #openstack-nova | 20:21 | |
| *** Guest14094 has quit IRC | 20:22 | |
| *** flwang has quit IRC | 20:23 | |
| *** Jeffrey4l has joined #openstack-nova | 20:24 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: refactors and cleans up test_rbd.py https://review.openstack.org/538022 | 20:24 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Implement get_traits() for the ironic virt driver https://review.openstack.org/532288 | 20:24 |
| jroll | mriedem: efried: there you are | 20:25 |
| * jroll attempts to find a good place for this functional test | 20:25 | |
| mriedem | jroll: likely somewhere in nova.tests.functional.test_servers | 20:26 |
| mriedem | there are lots of examples of tests using a specific fake virt driver, | 20:26 |
| jroll | mriedem: I'm liking nova/tests/functional/compute/test_resource_tracker.py | 20:26 |
| mriedem | and using a placement api client to assert things | 20:26 |
| jroll | has a bunch of RT + ironic things already | 20:26 |
| mriedem | this doesn't necessarily need to be an ironic virt driver functional test | 20:27 |
| mriedem | just a fake driver (see nova/virt/fake.py) that returns a standard and custom trait | 20:27 |
| jroll | true | 20:27 |
| mriedem | test_resource_tracker.py is probably fine as a new test class | 20:27 |
| mriedem | *with a new test class | 20:27 |
| jroll | yeah, I'll poke around, thanks | 20:28 |
| *** slaweq has quit IRC | 20:28 | |
| *** READ10 has quit IRC | 20:31 | |
| *** flwang has joined #openstack-nova | 20:36 | |
| *** slaweq has joined #openstack-nova | 20:37 | |
| *** Guest14094 has joined #openstack-nova | 20:40 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: fixes mock autospec usage https://review.openstack.org/447505 | 20:43 |
| mriedem | fyi, the cinder backup bug is still in the gate | 20:43 |
| mriedem | there is another thing going on | 20:43 |
| mriedem | swiftclient is logging within the thread | 20:43 |
| dansmith | still in the gate as in, unmerged? | 20:43 |
| mriedem | no, | 20:43 |
| mriedem | another issue, same bug | 20:43 |
| mriedem | http://logs.openstack.org/05/266605/33/check/neutron-tempest-dvr/8a5dd5f/logs/screen-c-bak.txt.gz#_Jan_25_19_26_01_896832 | 20:44 |
| dansmith | ah | 20:44 |
| mriedem | swiftclient is logging while their are in a thread and it switches | 20:44 |
| mriedem | *they are | 20:44 |
| efried | shitballs, does this mean stuff that's been sitting in the gate for 18h is now going to fail?? | 20:44 |
| mriedem | seeing if i can patch cinder-backup to not do debug logging for swiftclient if using that backup driver | 20:44 |
| mriedem | efried: it means it has a good chance of failing | 20:45 |
| mriedem | :) | 20:45 |
| efried | (That longish pause was me vocalizing my opinion of the situation) | 20:46 |
| mriedem | i'm pushing a cinder patch | 20:46 |
| efried | mriedem, thanks for tracking it down. | 20:46 |
| efried | Sonofa... three of my patches were all green & blue, alllmost through the gate, and then stalled again. | 20:47 |
| *** jackie-truong has quit IRC | 20:47 | |
| dansmith | heh | 20:49 |
| efried | at least they didn't outright fail, and have to start 18+h cycle over again | 20:51 |
| * efried knocks wood | 20:51 | |
| mriedem | efried: dansmith: https://review.openstack.org/538027 | 20:52 |
| *** matrohon has joined #openstack-nova | 20:52 | |
| *** andreas_s has joined #openstack-nova | 20:52 | |
| efried | mriedem What happens if swiftclient=SOMETHING_ELSE was already in the string? Does last win? | 20:53 |
| mriedem | don't know | 20:54 |
| mriedem | i know it's not in the default list of log levels in oslo.log | 20:54 |
| *** mvk has joined #openstack-nova | 20:55 | |
| efried | but if it's explicitly in whatever conf (on customer site), we don't want to override it. | 20:56 |
| *** andreas_s has quit IRC | 20:56 | |
| mriedem | that's why it's default_log_levels yeah? | 20:59 |
| efried | Could be, could be. I don't know. I left comments, but +0 - smarter people can decide whether those things are really an issue. | 21:00 |
| mriedem | look efried, do you want your 20 patches to merge or not | 21:01 |
| mriedem | :) | 21:01 |
| efried | I have NO IDEA what's actually best for my karma at this point. Walkin on eggshells, here. | 21:02 |
| *** Jeffrey4l has quit IRC | 21:02 | |
| mriedem | yeah, i'm about to just call it a day | 21:03 |
| mriedem | not really much that can be done about anything | 21:03 |
| efried | No, you have to stick around to +2+W stuff so us peons can sit around rechecking them through the night. | 21:04 |
| mriedem | i was rechecking things until about 11:30 last night | 21:04 |
| mriedem | i've done my job | 21:05 |
| *** tidwellr has quit IRC | 21:05 | |
| *** tidwellr has joined #openstack-nova | 21:06 | |
| efried | BTW, I was tooling around on stackalytics the other day - how did you manage to merge 18KLOC while pushing PTL paperwork 18 hours a day? | 21:06 |
| efried | Impressive. Most impressive. | 21:06 |
| *** jackie-truong has joined #openstack-nova | 21:07 | |
| Roamer` | hm, so here's a stupid question about stackalytics: if I put my name and e-mail address in default_data.json, will it pick up the patches that have already been merged, or does it just go forward? | 21:08 |
| efried | Roamer` me no idea. Someone in -infra might know, but they're frying great big fish at the moment. | 21:09 |
| Roamer` | efried, thanks, and yeah, I'm following the discussions there | 21:13 |
| *** liverpooler has quit IRC | 21:13 | |
| *** Jeffrey4l has joined #openstack-nova | 21:14 | |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Reduce complexity of _from_db_object https://review.openstack.org/537728 | 21:14 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/537897 | 21:14 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408 | 21:14 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 21:14 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 21:14 |
| openstackgerrit | Merged openstack/nova master: Update VMWare vSphere link address https://review.openstack.org/535244 | 21:15 |
| mriedem | efried: don't know | 21:17 |
| mriedem | amphetamines | 21:17 |
| mriedem | likely api changes with lots of api samples | 21:18 |
| efried | Tell ya, wait til you're my age. You'll never have the stamina. | 21:18 |
| mriedem | that's why i take that thing that frank thomas is selling | 21:18 |
| * efried googles... | 21:18 | |
| mriedem | nugenix | 21:18 |
| mriedem | https://www.ispot.tv/ad/wZA8/nugenix-fan-featuring-frank-thomas | 21:18 |
| mriedem | "stronger and leaner" | 21:19 |
| efried | a powerful, man-boosting innovation | 21:19 |
| mriedem | the guy has been like 300lb for 20 years | 21:19 |
| mriedem | man boosting testafen | 21:19 |
| mriedem | my passion levels will be through the roof! | 21:19 |
| edleafe | It's cute watching you young 'uns talking about being old. | 21:27 |
| dansmith | hush, dad's home! | 21:29 |
| *** pramodrj07 has joined #openstack-nova | 21:29 | |
| melwitt | hah :D | 21:29 |
| mriedem | i'll grab the hearin' cone | 21:29 |
| dansmith | that said, I'm quite sure edleafe remembers being 36 and feeling like life was over | 21:30 |
| *** eharney has quit IRC | 21:31 | |
| *** cleong has quit IRC | 21:32 | |
| *** esberglu has quit IRC | 21:32 | |
| efried | Any time I think of 36... https://youtu.be/q6zhOdroJCE?t=1347 | 21:33 |
| *** pchavva has quit IRC | 21:33 | |
| mriedem | umm, yikes | 21:33 |
| melwitt | for the native thread logging related gate issues, will there always be a message somewhere in the logs that says "cannot switch to a different thread"? | 21:38 |
| mriedem | yeah | 21:38 |
| melwitt | okay. I was wondering if it could be related to the stable branch cells v1 job 100% fails. libvirt is getting "connection broke" as though something is holding up the tpool and never letting it continue | 21:39 |
| melwitt | (I noticed all the libvirt calls go through eventlet.tpool) | 21:39 |
| melwitt | but the "cannot switch to a different thread" isn't in the logs anywhere | 21:40 |
| *** jheroux has joined #openstack-nova | 21:40 | |
| melwitt | I've been investigating it but haven't figured out anything yet | 21:41 |
| dansmith | the libvirt driver uses native threads properly | 21:41 |
| dansmith | so it should be fine unless something has regressed (or was never right) | 21:42 |
| dansmith | the connection issue with libvirt almost always means libvirtd crashed, | 21:42 |
| dansmith | which happens a lot more than it should | 21:42 |
| *** jheroux has quit IRC | 21:43 | |
| *** hamzy has quit IRC | 21:43 | |
| melwitt | yeah. in this case it hasn't crashed. it's as if something held it up so long that the connection dropped from not getting keepalive, or something like that | 21:43 |
| Roamer` | melwitt, what OS is this happening on? Could it be the Ubuntu py27/eventlet problem? http://lists.openstack.org/pipermail/openstack-dev/2018-January/126580.html | 21:44 |
| melwitt | I was wondering if any other library also using eventlet could have made it so it never switches back to the libvirt driver | 21:44 |
| dansmith | melwitt: why do you say it hasn't crashed? | 21:44 |
| melwitt | dansmith: because from syslog and libvirtd I couldn't find any crashing. unless I totally don't know what I'm looking at, which is possible | 21:45 |
| *** lpetrut has quit IRC | 21:45 | |
| dansmith | melwitt: link? | 21:45 |
| melwitt | Roamer`: it's ubuntu xenial. and that's what I was wondering, but I'm still grasping at straws at this point | 21:45 |
| melwitt | dansmith: here's an example from recently http://logs.openstack.org/04/536904/3/check/legacy-tempest-dsvm-cells/13aacfc/logs/screen-n-cpu.txt.gz#_2018-01-25_19_06_13_271 | 21:46 |
| dansmith | hmm, empty journal on that one? | 21:50 |
| dansmith | that's weird | 21:50 |
| *** amodi has quit IRC | 21:50 | |
| melwitt | I feel like I've seen that before | 21:51 |
| *** takashin has joined #openstack-nova | 21:52 | |
| dansmith | yeah, libvirtd doesn't look like it was restarted across that connection failure boundary | 21:52 |
| mriedem | interestingly, it's the first guest to be created it looks like http://logs.openstack.org/04/536904/3/check/legacy-tempest-dsvm-cells/13aacfc/logs/libvirt/qemu/instance-0000000a.txt.gz | 21:52 |
| dansmith | this would be the first time I've ever seen that symptom not associated with a crash | 21:53 |
| dansmith | so I still feel a little doubtful, but it's certainly not as glaring as normal | 21:53 |
| mriedem | makes me think of this https://review.openstack.org/#/c/526748/ | 21:53 |
| mriedem | where guestfs on the first bring up runs in a tpool | 21:53 |
| mriedem | to get the guestfs capabilities | 21:53 |
| dansmith | so I wonder if it's something like qemu crashes and the libvirt thread we're talking to exits or something | 21:54 |
| melwitt | yeah, that's kinda how I found that patch of yours mriedem | 21:54 |
| dansmith | the journal should have dmesg in it to capture any segv | 21:54 |
| *** bpoulos has quit IRC | 21:54 | |
| dansmith | but we don't have qemu logs otherwise | 21:55 |
| melwitt | I wonder if the journal collection on the jobs has been busted this whole time | 21:55 |
| melwitt | or is it not always empty? | 21:55 |
| dansmith | it wasn't busted a month or so ago | 21:55 |
| melwitt | I haven't tried to look at it before | 21:55 |
| melwitt | oh okay | 21:55 |
| dansmith | I expect it would be in syslog too, but it's clearer in the journal | 21:56 |
| melwitt | I didn't see anything that looked like crashing in syslog http://logs.openstack.org/04/536904/3/check/legacy-tempest-dsvm-cells/13aacfc/logs/syslog.txt.gz | 21:57 |
| dansmith | 2018-01-25 19:06:13.215+0000: 3732: error : virKeepAliveTimerInternal:143 : internal error: connection closed due to keepalive timeout | 21:57 |
| dansmith | is right before you get it in nova | 21:57 |
| melwitt | where do you see that? libvirtd.log? | 21:59 |
| dansmith | I think this is all in a separate thread in nova so it shouldn't be that nova is hung up and unable to do the keepalive bit, unless it's just system starvation of some sort | 21:59 |
| dansmith | yeah, libvirt | 21:59 |
| melwitt | damn | 21:59 |
| dansmith | and nova is doing stuff milliseconds before that, so it's not hung I don't think | 22:00 |
| *** linkmark has quit IRC | 22:00 | |
| dansmith | oh yeah in the nova log: | 22:00 |
| dansmith | 2018-01-25 19:06:13.224 16016 INFO nova.virt.libvirt.driver [req-ea2c4c13-3bbe-4b35-a2b3-84976c11fc4b - -] Connection event '0' reason 'Connection to libvirt lost' | 22:00 |
| dansmith | that's the real thread detecting the connection close | 22:01 |
| dansmith | oooh, but | 22:01 |
| dansmith | 2018-01-25 19:06:09.554 16016 DEBUG oslo_messaging._drivers.amqpdriver [-] received reply msg_id: 9ebc51b2583b4f4da811e951e41068c9 __call__ /usr/local/lib/python2.7/dist-packages/oslo_messaging/_drivers/amqpdriver.py:407 | 22:01 |
| dansmith | 2018-01-25 19:06:13.218 16016 DEBUG nova.virt.libvirt.firewall [req-733b7704-8aa3-45a5-8798-67eab246baf8 tempest-InstanceActionsV221TestJSON-176157016 tempest-InstanceActionsV221TestJSON-176157016] Cannot find UUID for filter 'nova-instance-instance-0000000d-fa163e269665': 'Cannot recv data: Connection reset by peer' _get_filter_uuid /opt/stack/new/nova/nova/virt/libvirt/firewall.py:254 | 22:01 |
| dansmith | that is five seconds apart with nothing in between | 22:02 |
| *** yamahata has joined #openstack-nova | 22:02 | |
| *** matrohon has quit IRC | 22:02 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Add functional tests for virt driver get_traits() method https://review.openstack.org/538047 | 22:02 |
| melwitt | hm | 22:02 |
| dansmith | meh, I dunno, looking around that I don't think that's anything related to being stuck though | 22:03 |
| dansmith | because that's the exact instant libvirt logs its message | 22:03 |
| *** slaweq has quit IRC | 22:04 | |
| *** slaweq has joined #openstack-nova | 22:05 | |
| *** yamamoto has joined #openstack-nova | 22:05 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Add functional tests for virt driver get_traits() method https://review.openstack.org/538047 | 22:06 |
| jackie-truong | dansmit, mriedem: re: git commands | 22:08 |
| jroll | mriedem: ^ see my comment there, fairly certain some of this traits stack is somewhat broken. probably fine to land as drivers aren't using it yet, but ya know. | 22:08 |
| jackie-truong | i want to add a /new/ file (test_trusted_certs.py) to a patch in the middle of my patch stack | 22:09 |
| jackie-truong | checking out the top of the patch stack, then adding and committing the file results in the file being added to the top patch | 22:09 |
| mriedem | efried: https://gist.github.com/jimrollenhagen/384077e2ed606ee84051cb4a7f66c51c | 22:09 |
| mriedem | jackie-truong: git rebase -i master | 22:10 |
| dansmith | jackie-truong: right, so git rebase -i master, edit the middle patch, git add path/to/file, git commit --amend -a | 22:10 |
| mriedem | jackie-truong: edit the commit you want to add the file to, | 22:10 |
| mriedem | create said file, | 22:10 |
| mriedem | git add <file> | 22:10 |
| mriedem | git rebase --continue | 22:10 |
| jackie-truong | ah, i rarely actually edit commits when rebasing from master. got it, thanks again | 22:11 |
| efried | mriedem VMX ain't a standard trait, or a valid CUSTOM_ one. | 22:11 |
| efried | jroll ^ | 22:11 |
| mriedem | efried: it's in os-traits | 22:11 |
| jroll | ^ | 22:11 |
| mriedem | oh wait | 22:12 |
| mriedem | i see | 22:12 |
| mriedem | jroll: he's right | 22:12 |
| efried | HW_CPU_X86_VMX ? | 22:12 |
| mriedem | yeah, the traits are generated from their directory structure within os-traits | 22:12 |
| jroll | oh gdi | 22:12 |
| * jroll tries | 22:12 | |
| mriedem | https://docs.openstack.org/os-traits/latest/user/index.html | 22:12 |
| *** slaweq_ has joined #openstack-nova | 22:13 | |
| *** slaweq_ has quit IRC | 22:15 | |
| jroll | mriedem: efried: that did it, now I feel dumb, thanks :) | 22:15 |
| mriedem | don't feel dumb | 22:16 |
| *** slaweq_ has joined #openstack-nova | 22:16 | |
| efried | For not understanding the bizarre architecture of os-traits? Yeah, what mriedem said. | 22:16 |
| mriedem | ironicclient change is 85 in the gate | 22:16 |
| efried | I always just GET /traits from the API to find my testable traits. | 22:16 |
| efried | Because you'll also get tripped up by this one at some point in the future: Your compute's os-traits may not be the same as the placement server's os-traits. | 22:17 |
| efried | which is why https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1005-L1009 | 22:18 |
| *** slaweq_ has quit IRC | 22:18 | |
| *** slaweq has quit IRC | 22:19 | |
| *** slaweq_ has joined #openstack-nova | 22:19 | |
| *** slaweq has joined #openstack-nova | 22:19 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Reduce complexity of _from_db_object https://review.openstack.org/537728 | 22:22 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/537897 | 22:22 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408 | 22:22 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 22:22 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 22:22 |
| *** slaweq_ has quit IRC | 22:23 | |
| dansmith | woot | 22:25 |
| *** swamireddy has quit IRC | 22:25 | |
| dansmith | I shall gaze upon thy patches upon my return from a brief respite | 22:25 |
| mriedem | melwitt: this makes me think about the eventlet/python thing in the ML https://review.openstack.org/#/c/537811/1 | 22:25 |
| jackie-truong | *\o/* | 22:26 |
| melwitt | are those pom poms? | 22:26 |
| melwitt | mriedem: interesting | 22:28 |
| melwitt | seems like it could be related. nothing makes too much sense so far, only cells v1 job is getting constant libvirt keepalive timeouts, starting about 10 days ago, and only on stable | 22:29 |
| melwitt | pike and ocata | 22:30 |
| mriedem | melwitt: unrelated, but related to lyarwood's change to hard reboot and blow things away all the time https://bugs.launchpad.net/nova/+bug/1744361 | 22:30 |
| openstack | Launchpad bug 1744361 in neutron "test_server_security_groups failed to reboot with "Domain not found: no domain with matching uuid" because of missing vif event from linuxbridge agent" [Undecided,Confirmed] | 22:30 |
| *** jackie-truong has quit IRC | 22:30 | |
| mriedem | i thought there were some assertions in the review that we didn't need to wait for vif plugged events, or something along those lines | 22:31 |
| melwitt | ah, suck | 22:31 |
| mriedem | https://review.openstack.org/#/c/400384/ | 22:31 |
| melwitt | well, I had commented that we do need to wait for them since we are re-plugging vifs. but I didn't realize we'd be in a vm_state that would ignore them | 22:32 |
| jroll | efried: fun, thanks | 22:32 |
| melwitt | that is, I didn't expect the events to be ignored when they're being waited for | 22:33 |
| mriedem | melwitt: it's not saying it's ignored b/c of the instance state | 22:36 |
| mriedem | it's saying the compute got the event but no callback was registered waiting for it | 22:36 |
| mriedem | Jan 19 10:33:35.986648 ubuntu-xenial-rax-iad-0002010825 nova-compute[28907]: DEBUG nova.compute.manager [None req-4bcf94cf-2048-4e99-94e6-646519900469 service nova] [instance: dd2ec3b0-f909-4104-ae2a-9b878d936ed4] No waiting events found dispatching network-vif-plugged-567525a4-4b16-4004-91d5-545086d01227 {{(pid=28907) pop_instance_event /opt/stack/new/nova/nova/compute/manager.py:363}} | 22:36 |
| melwitt | mriedem: okay, I was going by the last comment in the bug. okay, so maybe there's a bug in the _create_domain_and_network vifs_already_plugged logic somewhere | 22:37 |
| *** itlinux has joined #openstack-nova | 22:37 | |
| melwitt | or maybe vifs_already_plugged doesn't mean what I thought it means | 22:38 |
| *** lyan has quit IRC | 22:40 | |
| mriedem | i wonder if we don't register the callback before the vif plug event has already happened | 22:40 |
| mriedem | no that doesn't make sense | 22:41 |
| mriedem | we register the callback before calling plug_vifs | 22:41 |
| melwitt | "Timeout waiting for vif plugging callback for instance with vm_state active and task_state reboot_started_hard.: Timeout: 300 seconds" so that means it was waiting | 22:41 |
| melwitt | so "Received unexpected event" happens when there weren't events in self.instance_events in compute manager. so how do they get there ... | 22:45 |
| dansmith | mriedem: yeah the whole design of that thing is so you can't trigger before you're registered | 22:45 |
| *** amodi has joined #openstack-nova | 22:46 | |
| *** jmlowe has quit IRC | 22:48 | |
| *** tidwellr has quit IRC | 22:49 | |
| mriedem | i don't know what to do about this bug https://bugs.launchpad.net/nova/+bug/1740123 | 22:56 |
| openstack | Launchpad bug 1740123 in OpenStack Compute (nova) "Can we create server group with empty policies?" [Undecided,New] | 22:56 |
| mriedem | it's not a bug per se | 22:56 |
| melwitt | mriedem: it seems like the patch is related to the new bug. I think the only way this can happen is if _get_neutron_events(network_info) is returning no events, meaning there are no vifs in network_info. I'm looking to see where/how does network_info get reset after a reboot | 22:56 |
| mriedem | melwitt: if it doesn't return any events, wouldn't we just not wait for anything? | 22:57 |
| mriedem | and then no timeout? | 22:57 |
| melwitt | I would have thought network_info would remain as it was during a reboot (network_info came from when we originally allocated ports, right?) | 22:57 |
| mriedem | yes network_info should have whatever ports are attached to the instance, regardless of whether or not the vifs are actually plugged | 22:58 |
| mriedem | it's like bdms | 22:58 |
| mriedem | for ports | 22:58 |
| melwitt | good point ... one would think. I'm not that familiar with how the events work. you pass a list of events to the "wait" context manager | 22:58 |
| melwitt | yeah, looks like it would just pass by all the waiting if that list is empty. so the list isn't empty. yet it's not matching up the events | 22:59 |
| *** armax has quit IRC | 23:00 | |
| *** mvk has quit IRC | 23:00 | |
| *** amodi has quit IRC | 23:01 | |
| mriedem | we should probably log the list of stuff we're registering when we register it | 23:03 |
| mriedem | for debuggabilityamortiziation | 23:04 |
| *** itlinux has quit IRC | 23:04 | |
| melwitt | yeah. cause so far this don't make no sense | 23:04 |
| dansmith | you mean log at debug level I assume.. otherwise it's too chatty | 23:05 |
| mriedem | yes debug | 23:05 |
| melwitt | debugaroo | 23:05 |
| mriedem | i can't be chattier than the virt topology shit we log 20 things for | 23:05 |
| mriedem | even though we don't do any stuff with that in the gate | 23:05 |
| mriedem | *it | 23:05 |
| *** itlinux has joined #openstack-nova | 23:06 | |
| *** slaweq has quit IRC | 23:06 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Add functional tests for virt driver get_traits() method https://review.openstack.org/538047 | 23:07 |
| jroll | mriedem: ^ all yours, that worked out well | 23:07 |
| *** yamahata has quit IRC | 23:08 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Add functional tests for virt driver get_traits() method https://review.openstack.org/538047 | 23:09 |
| jroll | and pep8'd | 23:09 |
| *** Pramod has joined #openstack-nova | 23:09 | |
| *** Aibot has joined #openstack-nova | 23:10 | |
| mriedem | damn it | 23:10 |
| mriedem | comment in the last patchset | 23:10 |
| mriedem | seems like those could be one test, | 23:10 |
| *** Aibot has quit IRC | 23:10 | |
| mriedem | but idk | 23:10 |
| *** Pramod has quit IRC | 23:10 | |
| *** pramodrj07 has quit IRC | 23:10 | |
| *** itlinux has quit IRC | 23:11 | |
| melwitt | hm, the 'No waiting events found dispatching' message means that the result from _pop_event was no_events_sentinel which has another log message in it 'Unexpected attempt to pop events during shutdown' | 23:11 |
| *** pramodrj07 has joined #openstack-nova | 23:11 | |
| mriedem | i think that's when the compute service is shutting down | 23:11 |
| mriedem | not the guest | 23:11 |
| melwitt | oh, there's another way to get no_events_sentinel, if no result for self._events.get(instance.uuid) | 23:11 |
| melwitt | so it should be from that | 23:12 |
| *** amodi has joined #openstack-nova | 23:12 | |
| mriedem | rloo: TheJulia: jroll: is someone putting out a release? https://review.openstack.org/#/c/532622/ | 23:15 |
| rloo | mriedem: TheJulia is in charge of that! | 23:15 |
| TheJulia | we have a reno in the gate that should only take like 10 minutes | 23:15 |
| mriedem | yeah i see | 23:16 |
| mriedem | so, you could start the release patch with a depends-on the reno patch | 23:16 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Add functional tests for virt driver get_traits() method https://review.openstack.org/538047 | 23:16 |
| mriedem | then you just have to mod the git hash once it merges | 23:16 |
| mriedem | i.e. we could start stacking up the dependencies for the release | 23:16 |
| TheJulia | docs and pep8, even less time | 23:19 |
| *** rmcall has quit IRC | 23:20 | |
| *** chyka has quit IRC | 23:23 | |
| openstackgerrit | OpenStack Release Bot proposed openstack/python-novaclient master: Update reno for stable/queens https://review.openstack.org/538061 | 23:23 |
| *** chyka has joined #openstack-nova | 23:23 | |
| *** edmondsw has quit IRC | 23:27 | |
| *** dave-mccowan has quit IRC | 23:28 | |
| *** chyka has quit IRC | 23:28 | |
| mriedem | TheJulia: ship it | 23:29 |
| mriedem | woot | 23:30 |
| mriedem | https://review.openstack.org/538063 | 23:30 |
| TheJulia | yup | 23:30 |
| *** chyka has joined #openstack-nova | 23:30 | |
| TheJulia | had to just fix an excess space | 23:30 |
| TheJulia | but yup | 23:31 |
| * TheJulia goes and has a drink | 23:31 | |
| *** armax has joined #openstack-nova | 23:31 | |
| mriedem | jroll: since you've got the series localm | 23:33 |
| mriedem | want to change the depends-on in https://review.openstack.org/#/c/532288/ to https://review.openstack.org/#/c/538066/ | 23:33 |
| mriedem | and add the requirements.txt change in nova | 23:33 |
| mriedem | *test-requirements.txt | 23:33 |
| *** chyka_ has joined #openstack-nova | 23:34 | |
| *** chyka has quit IRC | 23:35 | |
| mriedem | the gpu patches failed on the volume backup thing, so i'm going to wait to recheck those | 23:42 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement get_traits() for the ironic virt driver https://review.openstack.org/532288 | 23:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional tests for virt driver get_traits() method https://review.openstack.org/538047 | 23:44 |
| mriedem | jroll: nvm i did it | 23:44 |
| mriedem | dansmith: https://review.openstack.org/#/c/532288/ | 23:45 |
| dansmith | mriedem: cool, I was waiting for you to say it was good with that dep | 23:47 |
| *** claudiub has quit IRC | 23:47 | |
| *** gongysh has joined #openstack-nova | 23:54 | |
| *** r-daneel has quit IRC | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!