| *** amodi has joined #openstack-nova | 00:02 | |
| *** oomichi has quit IRC | 00:03 | |
| *** wolverineav has quit IRC | 00:03 | |
| *** wolverineav has joined #openstack-nova | 00:04 | |
| *** yassine has joined #openstack-nova | 00:05 | |
| *** vladikr has quit IRC | 00:06 | |
| *** vladikr has joined #openstack-nova | 00:07 | |
| *** xinliang has quit IRC | 00:07 | |
| *** sean-k-mooney has quit IRC | 00:07 | |
| *** odyssey4me has quit IRC | 00:10 | |
| *** odyssey4me has joined #openstack-nova | 00:10 | |
| *** sean-k-mooney has joined #openstack-nova | 00:10 | |
| *** germs has joined #openstack-nova | 00:11 | |
| *** germs has quit IRC | 00:11 | |
| *** germs has joined #openstack-nova | 00:11 | |
| *** itlinux has joined #openstack-nova | 00:12 | |
| *** _ix has joined #openstack-nova | 00:13 | |
| *** germs has quit IRC | 00:15 | |
| *** _ix_ has joined #openstack-nova | 00:18 | |
| *** AlexeyAbashkin has joined #openstack-nova | 00:18 | |
| *** wolverineav has quit IRC | 00:18 | |
| *** _ix has quit IRC | 00:19 | |
| *** xinliang has joined #openstack-nova | 00:19 | |
| *** wolverineav has joined #openstack-nova | 00:21 | |
| *** AlexeyAbashkin has quit IRC | 00:22 | |
| mriedem | alex_xu_: gmann_: there is a question in here about API validation outside of the json schema, would be nice to get your input https://review.openstack.org/#/c/546925/ | 00:23 |
|---|---|---|
| *** wolverineav has quit IRC | 00:29 | |
| *** wolverineav has joined #openstack-nova | 00:30 | |
| *** r-daneel has quit IRC | 00:31 | |
| *** wolverineav has quit IRC | 00:40 | |
| *** yamamoto has joined #openstack-nova | 00:43 | |
| *** yamamoto has quit IRC | 00:48 | |
| gmann_ | mriedem: sure, ll check | 00:49 |
| *** claudiub has quit IRC | 00:50 | |
| *** hongbin has joined #openstack-nova | 00:51 | |
| *** felipemonteiro_ has joined #openstack-nova | 00:52 | |
| *** wolverineav has joined #openstack-nova | 00:53 | |
| *** felipemonteiro__ has joined #openstack-nova | 00:54 | |
| *** wolverin_ has joined #openstack-nova | 00:55 | |
| *** felipemonteiro_ has quit IRC | 00:58 | |
| *** sdague has quit IRC | 00:58 | |
| *** wolverineav has quit IRC | 00:59 | |
| *** zhaochao has joined #openstack-nova | 01:00 | |
| *** yassine has quit IRC | 01:02 | |
| *** yassine has joined #openstack-nova | 01:03 | |
| *** _ix_ has quit IRC | 01:05 | |
| *** gjayavelu has quit IRC | 01:07 | |
| *** chyka has joined #openstack-nova | 01:07 | |
| *** harlowja has quit IRC | 01:07 | |
| *** phuongnh has joined #openstack-nova | 01:08 | |
| *** vladikr has quit IRC | 01:08 | |
| Kevin_Zheng | mriedem got it | 01:08 |
| *** vladikr has joined #openstack-nova | 01:08 | |
| *** gcb has joined #openstack-nova | 01:08 | |
| *** chyka has quit IRC | 01:12 | |
| *** wolverin_ has quit IRC | 01:13 | |
| *** wolverineav has joined #openstack-nova | 01:13 | |
| *** vladikr has quit IRC | 01:14 | |
| *** vladikr has joined #openstack-nova | 01:14 | |
| *** tiendc has joined #openstack-nova | 01:15 | |
| *** wolverineav has quit IRC | 01:17 | |
| *** AlexeyAbashkin has joined #openstack-nova | 01:18 | |
| *** AlexeyAbashkin has quit IRC | 01:22 | |
| *** yingjun has joined #openstack-nova | 01:31 | |
| *** felipemonteiro_ has joined #openstack-nova | 01:32 | |
| *** felipemonteiro__ has quit IRC | 01:32 | |
| *** suresh12 has quit IRC | 01:33 | |
| *** suresh12 has joined #openstack-nova | 01:38 | |
| mriedem | johnthetubaguy: thanks for the review on https://review.openstack.org/#/c/520248/ - i didn't see the -1 until now; as for the script thing where someone starts using an IP before the server is ready, we don't show the server address while it's building | 01:38 |
| mriedem | because of this fun guy https://github.com/openstack/nova/blob/3fd863d8bf2fa1fc09acd08d976689462cffd2e3/nova/conf/api.py#L264 | 01:38 |
| *** moshele has joined #openstack-nova | 01:39 | |
| mriedem | gmann_: btw, i think you can remove that option now, it's been over 3 months | 01:39 |
| mriedem | ^ | 01:39 |
| *** fragatina has quit IRC | 01:39 | |
| *** suresh12_ has joined #openstack-nova | 01:40 | |
| *** fragatina has joined #openstack-nova | 01:41 | |
| *** vladikr has quit IRC | 01:42 | |
| *** vladikr has joined #openstack-nova | 01:43 | |
| *** suresh12 has quit IRC | 01:43 | |
| *** suresh12_ has quit IRC | 01:45 | |
| *** yamamoto has joined #openstack-nova | 01:45 | |
| *** fragatina has quit IRC | 01:46 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add [placement]/region_name to compute manager placement config check https://review.openstack.org/554759 | 01:47 |
| *** yamamoto has quit IRC | 01:51 | |
| *** amodi has quit IRC | 01:53 | |
| *** licanwei has joined #openstack-nova | 01:54 | |
| yikun | mriedem, sorry, I misunderstand your means to have to use the schema to validate per-policy rule. : ) | 01:56 |
| yikun | so, you mean it's just a code validation after schema validation, right? | 01:56 |
| mriedem | yikun: yes, since we can't define a mapping in the json schema document | 01:57 |
| mriedem | not that i know of anyway, without some custom schema code | 01:57 |
| yikun | ok, got it. :) | 01:59 |
| mriedem | but alex_xu_ might have other ideas | 02:06 |
| mriedem | anyway, time for me to stop working, ttyl | 02:06 |
| *** mriedem has quit IRC | 02:06 | |
| *** AlexeyAbashkin has joined #openstack-nova | 02:18 | |
| *** AlexeyAbashkin has quit IRC | 02:23 | |
| *** yamamoto has joined #openstack-nova | 02:37 | |
| *** yassine has quit IRC | 02:38 | |
| *** psachin has joined #openstack-nova | 02:38 | |
| openstackgerrit | Julia Kreger proposed openstack/nova master: WIP: Add microversion to ironic client wrapper call https://review.openstack.org/554762 | 02:39 |
| *** zhurong has joined #openstack-nova | 02:40 | |
| *** Zames has joined #openstack-nova | 02:45 | |
| *** suresh12 has joined #openstack-nova | 02:46 | |
| *** salv-orl_ has joined #openstack-nova | 02:48 | |
| vivsoni_ | if we have two compute node, compute1 & compute2 | 02:48 |
| *** andreas_s has joined #openstack-nova | 02:49 | |
| vivsoni_ | and if we create nova instance1 from compute1 | 02:49 |
| vivsoni_ | then is that instance1 visible from compute2 as well | 02:49 |
| vivsoni_ | ? | 02:49 |
| vivsoni_ | i mean when i execute 'nova list' command from compute2, will that instance1 will be listed ? | 02:50 |
| *** suresh12 has quit IRC | 02:51 | |
| *** salv-orlando has quit IRC | 02:51 | |
| *** Zames has quit IRC | 02:51 | |
| *** yassine has joined #openstack-nova | 02:53 | |
| *** andreas_s has quit IRC | 02:53 | |
| *** yamamoto has quit IRC | 02:55 | |
| *** felipemonteiro_ has quit IRC | 02:55 | |
| *** wolverineav has joined #openstack-nova | 02:56 | |
| *** fragatina has joined #openstack-nova | 03:00 | |
| *** tianhui has quit IRC | 03:06 | |
| *** tianhui has joined #openstack-nova | 03:07 | |
| *** tianhui has quit IRC | 03:11 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova-specs master: Complex (Anti)-Affinity Policies https://review.openstack.org/546925 | 03:12 |
| *** tianhui has joined #openstack-nova | 03:13 | |
| yikun | mriedem, :), thanks, have a good rest. | 03:14 |
| *** sree has joined #openstack-nova | 03:16 | |
| *** wolverineav has quit IRC | 03:16 | |
| *** sree has quit IRC | 03:16 | |
| *** dave-mccowan has quit IRC | 03:16 | |
| yikun | and alex_xu_ any other idea about it, : ) Cloud you give me some advice about how to validate? https://review.openstack.org/#/c/546925/ | 03:17 |
| *** wolverineav has joined #openstack-nova | 03:17 | |
| *** tianhui_ has joined #openstack-nova | 03:17 | |
| *** sree has joined #openstack-nova | 03:17 | |
| *** tianhui has quit IRC | 03:18 | |
| *** sree_ has joined #openstack-nova | 03:18 | |
| *** sree_ is now known as Guest21977 | 03:19 | |
| *** hongbin has quit IRC | 03:19 | |
| *** Guest21977 has quit IRC | 03:20 | |
| *** wolverineav has quit IRC | 03:21 | |
| *** sree has quit IRC | 03:21 | |
| *** sree has joined #openstack-nova | 03:22 | |
| *** zhurong has quit IRC | 03:44 | |
| *** yamamoto has joined #openstack-nova | 03:45 | |
| *** diga has joined #openstack-nova | 03:58 | |
| *** links has joined #openstack-nova | 04:00 | |
| *** links has quit IRC | 04:00 | |
| *** Zames has joined #openstack-nova | 04:04 | |
| *** jaypipes has quit IRC | 04:05 | |
| *** jaypipes has joined #openstack-nova | 04:06 | |
| *** Zames has quit IRC | 04:06 | |
| *** yamamoto has quit IRC | 04:07 | |
| *** yamamoto has joined #openstack-nova | 04:08 | |
| *** udesale has joined #openstack-nova | 04:09 | |
| *** abhishekk has joined #openstack-nova | 04:15 | |
| diga | jaypipes: Hi | 04:16 |
| diga | jaypipes: I have assigned https://bugs.launchpad.net/nova/+bug/1751692 bug to me from the shared list | 04:17 |
| openstack | Launchpad bug 1751692 in OpenStack Compute (nova) "os_region_name an unnecessary required option for placement " [Low,Triaged] - Assigned to Digambar (digambarpatil15) | 04:17 |
| *** Zames has joined #openstack-nova | 04:18 | |
| *** Zames has quit IRC | 04:23 | |
| *** yamamoto has quit IRC | 04:33 | |
| *** diga has quit IRC | 04:33 | |
| *** chyka has joined #openstack-nova | 04:34 | |
| *** suresh12 has joined #openstack-nova | 04:35 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Remove duplicative implementation of temporary directories. https://review.openstack.org/554791 | 04:36 |
| openstackgerrit | Michael Still proposed openstack/nova master: Use a pythonic delete. https://review.openstack.org/554792 | 04:36 |
| openstackgerrit | Michael Still proposed openstack/nova master: Use a pythonic delete, with a retry. https://review.openstack.org/554793 | 04:36 |
| *** Spazmotic has quit IRC | 04:37 | |
| *** harlowja has joined #openstack-nova | 04:39 | |
| *** chyka has quit IRC | 04:39 | |
| *** sree has quit IRC | 04:54 | |
| *** sree has joined #openstack-nova | 04:55 | |
| *** harlowja has quit IRC | 04:56 | |
| *** sree has quit IRC | 04:59 | |
| *** ratailor has joined #openstack-nova | 05:02 | |
| *** suresh12 has quit IRC | 05:03 | |
| *** ratailor_ has joined #openstack-nova | 05:04 | |
| *** sree has joined #openstack-nova | 05:05 | |
| *** lpetrut has joined #openstack-nova | 05:06 | |
| *** ratailor has quit IRC | 05:07 | |
| *** sree has quit IRC | 05:09 | |
| *** imacdonn has quit IRC | 05:14 | |
| *** imacdonn has joined #openstack-nova | 05:14 | |
| *** sree has joined #openstack-nova | 05:27 | |
| *** vladikr has quit IRC | 05:28 | |
| *** vladikr has joined #openstack-nova | 05:28 | |
| *** rybridges has quit IRC | 05:30 | |
| *** sridharg has joined #openstack-nova | 05:30 | |
| *** sree has quit IRC | 05:31 | |
| *** mdnadeem has joined #openstack-nova | 05:32 | |
| *** vladikr has quit IRC | 05:34 | |
| *** vladikr has joined #openstack-nova | 05:35 | |
| *** fragatina has quit IRC | 05:35 | |
| *** fragatina has joined #openstack-nova | 05:35 | |
| *** moshele has quit IRC | 05:39 | |
| *** rybridges has joined #openstack-nova | 05:43 | |
| *** claudiub has joined #openstack-nova | 05:43 | |
| gmann_ | yikun: i think we can do using json schema with power of oneOf/anyOf. i wrote my comments on patch | 05:43 |
| gmann_ | yikun: oneOf might be good here as at a time only 1 policy can exist | 05:44 |
| *** kholkina has joined #openstack-nova | 05:44 | |
| *** gjayavelu has joined #openstack-nova | 05:45 | |
| *** kholkina has quit IRC | 05:49 | |
| *** rybridges has quit IRC | 05:51 | |
| *** sidx64 has joined #openstack-nova | 06:01 | |
| *** rybridges has joined #openstack-nova | 06:04 | |
| *** masuberu has quit IRC | 06:04 | |
| *** sidx64 has quit IRC | 06:05 | |
| *** zhurong has joined #openstack-nova | 06:05 | |
| *** sidx64 has joined #openstack-nova | 06:07 | |
| *** sree_ has joined #openstack-nova | 06:07 | |
| *** sree_ is now known as Guest83294 | 06:08 | |
| *** sidx64 has quit IRC | 06:08 | |
| *** rybridges has quit IRC | 06:09 | |
| *** sidx64 has joined #openstack-nova | 06:09 | |
| *** Guest83294 has quit IRC | 06:12 | |
| *** sree_ has joined #openstack-nova | 06:12 | |
| *** sree_ is now known as Guest56076 | 06:13 | |
| *** germs has joined #openstack-nova | 06:13 | |
| *** germs has quit IRC | 06:13 | |
| *** germs has joined #openstack-nova | 06:13 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/548772 | 06:15 |
| *** germs has quit IRC | 06:18 | |
| *** lpetrut has quit IRC | 06:19 | |
| *** udesale has quit IRC | 06:21 | |
| *** udesale has joined #openstack-nova | 06:21 | |
| *** ratailor_ has quit IRC | 06:22 | |
| *** rybridges has joined #openstack-nova | 06:23 | |
| *** ratailor has joined #openstack-nova | 06:24 | |
| *** lajoskatona has joined #openstack-nova | 06:25 | |
| *** Guest56076 has quit IRC | 06:27 | |
| *** yamamoto has joined #openstack-nova | 06:28 | |
| openstackgerrit | jichenjc proposed openstack/nova master: mv generate_glance_url to get_image_endpoint_url https://review.openstack.org/511400 | 06:30 |
| *** moshele has joined #openstack-nova | 06:31 | |
| *** masber has joined #openstack-nova | 06:31 | |
| *** jichen has joined #openstack-nova | 06:31 | |
| *** suresh12 has joined #openstack-nova | 06:31 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Avoid raise InstanceNotRunning exception https://review.openstack.org/541152 | 06:32 |
| yikun | gmann_, Thanks, cool, ``oneOf`` is like a powerful enum, and we can use it in here. | 06:32 |
| *** ratailor_ has joined #openstack-nova | 06:32 | |
| yikun | gmann_, and for the things about policy name, I just think it's ok to me to change ``policy`` to ``name``, and do some convert in api to transfer this ``name`` to the ``policy`` in db. | 06:32 |
| openstackgerrit | jichenjc proposed openstack/nova master: Move placement test cases from db to placement https://review.openstack.org/553149 | 06:34 |
| *** gus has quit IRC | 06:34 | |
| *** lpetrut has joined #openstack-nova | 06:35 | |
| *** ratailor has quit IRC | 06:35 | |
| *** StevenK has quit IRC | 06:35 | |
| *** sdake has quit IRC | 06:35 | |
| *** gus has joined #openstack-nova | 06:36 | |
| *** StevenK has joined #openstack-nova | 06:36 | |
| *** ratailor_ has quit IRC | 06:37 | |
| *** suresh12 has quit IRC | 06:37 | |
| *** sdake has joined #openstack-nova | 06:37 | |
| *** sdake has quit IRC | 06:37 | |
| *** sdake has joined #openstack-nova | 06:37 | |
| yikun | gmann_, actually, the 'name/type' also as a alternative name for policy, as I mentioned, in PS2: | 06:38 |
| yikun | https://review.openstack.org/#/c/546925/2/specs/rocky/approved/allow-specifying-limit-for-affrinity-group.rst@49 | 06:38 |
| yikun | But I thought it seems we need keep consist between api and db, so, in current PS, I use the 2 times policy which look like a bit redundant. | 06:39 |
| *** diga has joined #openstack-nova | 06:39 | |
| *** ratailor has joined #openstack-nova | 06:41 | |
| *** elmaciej has joined #openstack-nova | 06:46 | |
| *** elmaciej has quit IRC | 06:54 | |
| *** gongysh has joined #openstack-nova | 06:55 | |
| *** lpetrut has quit IRC | 06:55 | |
| openstackgerrit | zhufl proposed openstack/nova master: Fix api-ref: nova image-meta is deprecated from 2.39 https://review.openstack.org/554813 | 06:55 |
| *** vladikr has quit IRC | 06:56 | |
| *** Spazmotic has joined #openstack-nova | 06:58 | |
| *** logan- has quit IRC | 06:58 | |
| *** logan- has joined #openstack-nova | 06:58 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Remove quota reserve/commit/rollback https://review.openstack.org/521470 | 06:59 |
| *** Eran_Kuris has joined #openstack-nova | 07:02 | |
| *** rmart04 has joined #openstack-nova | 07:02 | |
| *** jaosorior has quit IRC | 07:05 | |
| *** masber has quit IRC | 07:05 | |
| *** masber has joined #openstack-nova | 07:06 | |
| *** rmart04 has quit IRC | 07:07 | |
| openstackgerrit | jichenjc proposed openstack/nova master: deprecate fping_path config option https://review.openstack.org/526602 | 07:07 |
| *** sidx64_ has joined #openstack-nova | 07:12 | |
| *** salv-orl_ has quit IRC | 07:12 | |
| *** sree_ has joined #openstack-nova | 07:13 | |
| *** sree_ is now known as Guest70027 | 07:14 | |
| *** sidx64 has quit IRC | 07:14 | |
| *** alexchadin has joined #openstack-nova | 07:14 | |
| *** salv-orlando has joined #openstack-nova | 07:16 | |
| *** sidx64_ has quit IRC | 07:16 | |
| *** gjayavelu has quit IRC | 07:17 | |
| *** sidx64 has joined #openstack-nova | 07:17 | |
| *** Guest70027 has quit IRC | 07:18 | |
| *** sar has joined #openstack-nova | 07:19 | |
| *** rcernin has quit IRC | 07:21 | |
| *** voelzmo has joined #openstack-nova | 07:21 | |
| *** andreas_s has joined #openstack-nova | 07:26 | |
| *** yamamoto has quit IRC | 07:32 | |
| *** moshele has quit IRC | 07:36 | |
| *** jaosorior has joined #openstack-nova | 07:44 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:44 | |
| *** ralonsoh has joined #openstack-nova | 07:46 | |
| *** moshele has joined #openstack-nova | 07:46 | |
| *** moshele has quit IRC | 07:50 | |
| *** moshele has joined #openstack-nova | 07:51 | |
| *** priteau has joined #openstack-nova | 07:52 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Add more functional test for placement.usage https://review.openstack.org/513264 | 07:53 |
| *** AlexeyAbashkin has joined #openstack-nova | 07:55 | |
| *** yamahata has joined #openstack-nova | 07:55 | |
| *** jmlowe has quit IRC | 07:57 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154 | 07:59 |
| *** yamamoto has joined #openstack-nova | 08:00 | |
| *** yamamoto has quit IRC | 08:03 | |
| gmann_ | yikun: i see, just respond. changing to name looks ok to me. | 08:05 |
| gmann_ | yikun: i will give try to test the schema in parallel but tomorrow as it is holiday in japan so not allowed to work much due to wife order :) | 08:06 |
| *** priteau has quit IRC | 08:07 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Remove translate and a TODO https://review.openstack.org/554827 | 08:07 |
| yikun | ha, really thanks, and I also try it now, but it seems doesn't work, I'm trying to find the reason. | 08:08 |
| yikun | gmann_, | 08:08 |
| yikun | ^ | 08:08 |
| gmann_ | ohk, sure | 08:08 |
| *** danpawlik has joined #openstack-nova | 08:10 | |
| *** damien_r has joined #openstack-nova | 08:11 | |
| *** ragiman has joined #openstack-nova | 08:12 | |
| *** yamamoto has joined #openstack-nova | 08:13 | |
| *** yamamoto has quit IRC | 08:16 | |
| *** yamamoto has joined #openstack-nova | 08:16 | |
| *** Zames has joined #openstack-nova | 08:21 | |
| *** kholkina has joined #openstack-nova | 08:23 | |
| yikun | gmann_, good msg, it works. | 08:24 |
| yikun | it didn't work well before, the reason is a typo in "s/aditionalProperties/additionalProperties", | 08:24 |
| yikun | sorry, I just copy from your comment and didn't find this tiny typo. | 08:24 |
| yikun | and my result paste here: | 08:24 |
| yikun | http://paste.openstack.org/show/707232/ | 08:24 |
| *** chyka has joined #openstack-nova | 08:24 | |
| *** Zames has quit IRC | 08:26 | |
| gmann_ | yikun: ahhh, thanks that's my bad finger when editing on vim :) good to hear that worked | 08:26 |
| yikun | gmann_, lol, I will update specs later, and have a good holiday. : ) | 08:29 |
| *** sahid has joined #openstack-nova | 08:29 | |
| *** chyka has quit IRC | 08:29 | |
| gmann_ | yikun: thanks, ll review that once you push new version. | 08:29 |
| *** sidx64 has quit IRC | 08:30 | |
| *** tesseract has joined #openstack-nova | 08:31 | |
| *** sidx64 has joined #openstack-nova | 08:31 | |
| *** sidx64 has quit IRC | 08:32 | |
| openstackgerrit | Merged openstack/nova stable/ocata: Fix joins in instance_get_all_by_host https://review.openstack.org/511682 | 08:33 |
| *** sidx64 has joined #openstack-nova | 08:33 | |
| *** brad[] has quit IRC | 08:34 | |
| *** sidx64 has quit IRC | 08:34 | |
| *** ratailor has quit IRC | 08:35 | |
| *** ratailor has joined #openstack-nova | 08:35 | |
| *** amoralej|off is now known as amoralej | 08:36 | |
| *** ccamacho has joined #openstack-nova | 08:38 | |
| *** masber has quit IRC | 08:40 | |
| *** jpena|off is now known as jpena | 08:43 | |
| *** lpetrut has joined #openstack-nova | 08:45 | |
| *** lpetrut has quit IRC | 08:48 | |
| *** lpetrut_ has joined #openstack-nova | 08:48 | |
| *** claudiub has quit IRC | 08:50 | |
| *** tesseract has quit IRC | 08:51 | |
| *** tesseract has joined #openstack-nova | 08:52 | |
| *** tesseract has quit IRC | 08:54 | |
| *** tesseract has joined #openstack-nova | 08:57 | |
| *** lucas-afk is now known as lucasagomes | 08:59 | |
| *** sidx64 has joined #openstack-nova | 09:00 | |
| *** sidx64 has quit IRC | 09:02 | |
| *** mgoddard has joined #openstack-nova | 09:03 | |
| *** zhurong has quit IRC | 09:04 | |
| *** sidx64 has joined #openstack-nova | 09:09 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova-specs master: Complex (Anti)-Affinity Policies https://review.openstack.org/546925 | 09:12 |
| *** zhurong has joined #openstack-nova | 09:14 | |
| *** licanwei has quit IRC | 09:15 | |
| *** mdbooth has joined #openstack-nova | 09:17 | |
| *** masber has joined #openstack-nova | 09:20 | |
| *** zhaochao has quit IRC | 09:29 | |
| *** gongysh has quit IRC | 09:30 | |
| *** zhaochao has joined #openstack-nova | 09:31 | |
| *** derekh has joined #openstack-nova | 09:34 | |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 09:37 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 09:37 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240 | 09:37 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340 | 09:37 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344 | 09:37 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 09:41 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240 | 09:41 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340 | 09:41 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344 | 09:41 |
| *** Zames has joined #openstack-nova | 09:41 | |
| *** yamamoto has quit IRC | 09:42 | |
| openstackgerrit | zhufl proposed openstack/nova master: Fix api-ref: nova image-meta is deprecated from 2.39 https://review.openstack.org/554813 | 09:42 |
| *** Zames has quit IRC | 09:43 | |
| *** yingjun has quit IRC | 09:43 | |
| *** yamamoto has joined #openstack-nova | 09:43 | |
| *** sdague has joined #openstack-nova | 09:43 | |
| *** Zames has joined #openstack-nova | 09:46 | |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: move get_numa_memnode in designer module https://review.openstack.org/554850 | 09:47 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: move vpu_realtime_scheduler in designer https://review.openstack.org/554851 | 09:47 |
| *** yamamoto has quit IRC | 09:48 | |
| *** yamamoto has joined #openstack-nova | 09:48 | |
| *** yamamoto has quit IRC | 09:48 | |
| *** Zames has quit IRC | 09:48 | |
| *** yingjun has joined #openstack-nova | 09:49 | |
| *** Zames has joined #openstack-nova | 09:49 | |
| *** Zames has quit IRC | 09:52 | |
| *** Zames has joined #openstack-nova | 09:53 | |
| *** yingjun has quit IRC | 09:54 | |
| *** voelzmo has quit IRC | 09:54 | |
| *** voelzmo has joined #openstack-nova | 09:55 | |
| *** voelzmo has quit IRC | 09:55 | |
| *** claudiub has joined #openstack-nova | 09:55 | |
| *** voelzmo has joined #openstack-nova | 09:56 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154 | 09:58 |
| *** phuongnh has quit IRC | 09:59 | |
| *** Zames has quit IRC | 10:00 | |
| *** phuongnh has joined #openstack-nova | 10:00 | |
| *** voelzmo has quit IRC | 10:00 | |
| *** sridharg has quit IRC | 10:03 | |
| *** sidx64 has quit IRC | 10:04 | |
| *** sidx64 has joined #openstack-nova | 10:05 | |
| *** priteau has joined #openstack-nova | 10:11 | |
| *** jichen has quit IRC | 10:17 | |
| *** alexchadin has quit IRC | 10:27 | |
| *** alexchadin has joined #openstack-nova | 10:28 | |
| *** phuongnh has quit IRC | 10:28 | |
| *** elmaciej has joined #openstack-nova | 10:29 | |
| *** alexchadin has quit IRC | 10:30 | |
| *** alexchadin has joined #openstack-nova | 10:35 | |
| *** sidx64 has quit IRC | 10:36 | |
| *** tssurya has joined #openstack-nova | 10:37 | |
| *** sapd_ has quit IRC | 10:38 | |
| *** sapd has joined #openstack-nova | 10:39 | |
| *** sidx64 has joined #openstack-nova | 10:40 | |
| *** diga has quit IRC | 10:44 | |
| *** alexchadin has quit IRC | 10:46 | |
| *** yamamoto has joined #openstack-nova | 10:48 | |
| *** dtantsur|afk is now known as dtantsur | 10:49 | |
| *** yamahata has quit IRC | 10:52 | |
| *** yamamoto has quit IRC | 10:54 | |
| *** zhurong has quit IRC | 10:55 | |
| *** yamamoto has joined #openstack-nova | 10:56 | |
| lyarwood | quick sanity check if anyone has a second, rebuild is the only way to propagate changes to the metadata of an image into an instance previously created from that image right? | 10:59 |
| lyarwood | say I wanted to enable the QEMU guest agent in an instance, I'd need to add hw_qemu_guest_agent=yes to the image and then rebuild? | 11:00 |
| *** yamamoto has quit IRC | 11:01 | |
| *** chyka has joined #openstack-nova | 11:02 | |
| *** yamamoto has joined #openstack-nova | 11:02 | |
| openstackgerrit | sahid proposed openstack/nova-specs master: libvirt: add support for virtio-net rx/tx queue sizes https://review.openstack.org/539605 | 11:03 |
| *** voelzmo has joined #openstack-nova | 11:04 | |
| *** udesale_ has joined #openstack-nova | 11:04 | |
| *** suresh12 has joined #openstack-nova | 11:04 | |
| lyarwood | stephenfin, mdbooth, sahid ^ quick sanity-check question above if you have time | 11:06 |
| *** yamamoto has quit IRC | 11:06 | |
| *** udesale has quit IRC | 11:07 | |
| *** chyka has quit IRC | 11:07 | |
| * mdbooth looks | 11:07 | |
| stephenfin | lyarwood: That sounds correct, yes. If you rebuild with an image specifying differing CPU policies, the newer policy will get applied | 11:08 |
| stephenfin | I assume it's the same for other options | 11:08 |
| mdbooth | lyarwood: Sounds correct to me, but I'd need to check to be sure. Do you need me to check code? | 11:08 |
| *** suresh12 has quit IRC | 11:09 | |
| *** gyankum has joined #openstack-nova | 11:10 | |
| *** udesale_ has quit IRC | 11:13 | |
| *** yamamoto has joined #openstack-nova | 11:16 | |
| *** yamamoto has quit IRC | 11:16 | |
| *** alexchadin has joined #openstack-nova | 11:16 | |
| *** cdent has joined #openstack-nova | 11:18 | |
| *** abhishekk has quit IRC | 11:21 | |
| lyarwood | stephenfin / mdbooth ; thanks, I've quickly scanned the compute code around this so no need to dive any deeper, just wanted to make sure I hadn't missed something obvious. | 11:21 |
| *** sidx64 has quit IRC | 11:29 | |
| *** stvnoyes1 has joined #openstack-nova | 11:31 | |
| *** voelzmo has quit IRC | 11:32 | |
| *** sidx64 has joined #openstack-nova | 11:33 | |
| *** sidx64 has quit IRC | 11:34 | |
| *** claudiub has quit IRC | 11:35 | |
| *** claudiub has joined #openstack-nova | 11:36 | |
| *** jpena is now known as jpena|off | 11:39 | |
| *** jpena|off is now known as jpena | 11:40 | |
| *** sar has quit IRC | 11:41 | |
| *** tiendc has quit IRC | 11:42 | |
| gibi | melwitt, mriedem: reported a followup bug for the yestardays notification issue https://bugs.launchpad.net/nova/+bug/1757407 | 11:44 |
| openstack | Launchpad bug 1757407 in OpenStack Compute (nova) "Notification sending sometimes hits the keystone API to get glance endpoints" [Undecided,New] | 11:44 |
| *** Zames has joined #openstack-nova | 11:45 | |
| *** yamamoto has joined #openstack-nova | 11:48 | |
| *** Zames has quit IRC | 11:48 | |
| *** takedakn has joined #openstack-nova | 11:50 | |
| *** yamamoto has quit IRC | 11:52 | |
| *** takedakn has quit IRC | 11:52 | |
| *** sidx64 has joined #openstack-nova | 11:54 | |
| *** RaoulHC has joined #openstack-nova | 11:54 | |
| *** sidx64 has quit IRC | 11:55 | |
| *** sidx64 has joined #openstack-nova | 11:56 | |
| *** sidx64 has quit IRC | 11:58 | |
| *** sar has joined #openstack-nova | 12:03 | |
| openstackgerrit | Merged openstack/nova stable/queens: Update the nova-manage db archive_deleted_rows description https://review.openstack.org/553733 | 12:03 |
| *** yamamoto has joined #openstack-nova | 12:03 | |
| *** odyssey4me has quit IRC | 12:03 | |
| *** odyssey4me has joined #openstack-nova | 12:03 | |
| *** sidx64 has joined #openstack-nova | 12:04 | |
| *** sidx64 has quit IRC | 12:06 | |
| jaypipes | morning supernovas | 12:06 |
| * jaypipes hopes to have a ore productive day today | 12:06 | |
| *** ragiman has quit IRC | 12:06 | |
| *** pchavva has joined #openstack-nova | 12:07 | |
| *** jmlowe has joined #openstack-nova | 12:08 | |
| *** yamamoto has quit IRC | 12:08 | |
| cdent | jaypipes: you making steel? | 12:08 |
| jaypipes | heh :) | 12:08 |
| cdent | Because I would totally go for a "Sword by Jay" sword | 12:09 |
| *** sidx64 has joined #openstack-nova | 12:09 | |
| jaypipes | cdent: '"s"words', said in the voice of Sean Connery from Celebrity Jeopardy. | 12:09 |
| cdent | bum cover! | 12:10 |
| jaypipes | I'll play your game, you rogue. | 12:10 |
| cdent | I rarely get the fits of laughing from thing on tv, but that skit kills me | 12:10 |
| jaypipes | indeed. | 12:11 |
| *** sidx64 has quit IRC | 12:11 | |
| jaypipes | cdent: although I must say Keenan Thompson doing Steve Harvey on Family Feud over the last 5 years or so is also pretty hysterical. | 12:11 |
| cdent | I'll have to check that out, as a foreigner these days I'm out of touch | 12:12 |
| jaypipes | :) | 12:12 |
| *** lucasagomes is now known as lucas-hungry | 12:16 | |
| *** yamamoto has joined #openstack-nova | 12:18 | |
| *** jpena is now known as jpena|lunch | 12:20 | |
| *** READ10 has joined #openstack-nova | 12:22 | |
| *** yamamoto has quit IRC | 12:22 | |
| *** efried has quit IRC | 12:23 | |
| *** sambetts|afk is now known as sambetts | 12:24 | |
| *** efried has joined #openstack-nova | 12:24 | |
| *** sidx64 has joined #openstack-nova | 12:28 | |
| *** artom has joined #openstack-nova | 12:29 | |
| sahid | jaypipes: anychance you have a look at https://review.openstack.org/#/c/511188/ ? | 12:30 |
| *** artom has quit IRC | 12:31 | |
| *** lajoskatona has quit IRC | 12:31 | |
| *** yamamoto has joined #openstack-nova | 12:33 | |
| *** artom has joined #openstack-nova | 12:34 | |
| jaypipes | sahid: yes, will do this morning. sorry for delay. yesterday was a lost day for me. | 12:35 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/534384 | 12:37 |
| sahid | jaypipes: no worries :) thanks for looking at it | 12:37 |
| *** sridharg has joined #openstack-nova | 12:38 | |
| *** yamamoto has quit IRC | 12:38 | |
| *** edmondsw has joined #openstack-nova | 12:40 | |
| tssurya | cfriesen: around ? | 12:41 |
| *** gcb has quit IRC | 12:42 | |
| *** yamamoto has joined #openstack-nova | 12:48 | |
| *** lyan has joined #openstack-nova | 12:52 | |
| *** lyan is now known as Guest17101 | 12:52 | |
| *** yamamoto has quit IRC | 12:53 | |
| sean-k-mooney | QQ is there any gate issues currently, the nova-tox-functional-py35 timed out on one of my patches so just wondering if i should recheck or is the gate under heavy load? | 12:57 |
| jaypipes | sean-k-mooney: I've noticed the same... | 13:00 |
| *** felipemonteiro_ has joined #openstack-nova | 13:01 | |
| jaypipes | sean-k-mooney: not sure if it's temporary, though. I've seen a few patches get through, which indicates it probably is (plus all the failures I see have been POST_FAILURE) | 13:01 |
| *** eharney has joined #openstack-nova | 13:01 | |
| sean-k-mooney | jaypipes perhaps the timeout needs t obe raised over 90 mins that said the py27 fucntional tests only last 18 mins. ill look at the log | 13:02 |
| *** felipemonteiro__ has joined #openstack-nova | 13:02 | |
| *** yamamoto has joined #openstack-nova | 13:03 | |
| jaypipes | sean-k-mooney: yeah, the func tests should *not* take more than around 20 minutes max. | 13:04 |
| efried | bauzas: You around? | 13:04 |
| *** germs has joined #openstack-nova | 13:04 | |
| *** germs has quit IRC | 13:04 | |
| *** germs has joined #openstack-nova | 13:04 | |
| gibi | jaypipes, sean-k-mooney: I think we had to increase the functional timeout recently due to slowness of the instances running the tests in CI | 13:05 |
| sean-k-mooney | jaypipes: its stange i can see the func tests running fine until here http://logs.openstack.org/72/553072/3/check/nova-tox-functional-py35/6ccdce3/job-output.txt.gz#_2018-03-20_20_02_28_641084 and then it just stops outputing until it hits the time out | 13:05 |
| gibi | jaypipes, sean-k-mooney: https://review.openstack.org/#/c/537933/ | 13:05 |
| sean-k-mooney | gibi: perhaps but it looks like the func tests are haning after like 5 mins | 13:06 |
| gibi | sean-k-mooney: OK then that is a different issue | 13:06 |
| *** felipemonteiro_ has quit IRC | 13:06 | |
| gibi | sean-k-mooney: anyhow the current func test timeout is 60 minutes | 13:06 |
| sean-k-mooney | gibi: ya that should be more then enough | 13:06 |
| *** yamamoto has quit IRC | 13:08 | |
| jaypipes | indeed. | 13:08 |
| *** udesale has joined #openstack-nova | 13:12 | |
| *** vladikr has joined #openstack-nova | 13:12 | |
| openstackgerrit | Jon Schlueter proposed openstack/os-vif stable/queens: Fix VF-rep lookup routine to use parent PF number https://review.openstack.org/554917 | 13:12 |
| *** yamamoto has joined #openstack-nova | 13:18 | |
| *** lajoskatona has joined #openstack-nova | 13:19 | |
| *** mriedem has joined #openstack-nova | 13:20 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: [WIP] Cleanup RP and HM records while deleting a compute service. https://review.openstack.org/554920 | 13:21 |
| *** _pewp_ has quit IRC | 13:22 | |
| *** yamamoto has quit IRC | 13:22 | |
| kashyap | sahid: Hey, thanks for the review here: https://review.openstack.org/#/c/534384/ | 13:23 |
| kashyap | Looking now... | 13:24 |
| *** ratailor has quit IRC | 13:24 | |
| *** alexchad_ has joined #openstack-nova | 13:24 | |
| *** jpena|lunch is now known as jpena | 13:25 | |
| *** alexchadin has quit IRC | 13:25 | |
| *** awaugama has joined #openstack-nova | 13:26 | |
| *** tssurya has quit IRC | 13:26 | |
| *** amoralej is now known as amoralej|lunch | 13:27 | |
| *** edleafe- has joined #openstack-nova | 13:28 | |
| *** lucas-hungry is now known as lucasagomes | 13:29 | |
| *** edleafe has quit IRC | 13:29 | |
| *** edleafe- is now known as edleafe | 13:29 | |
| *** eharney has quit IRC | 13:30 | |
| *** mvk has quit IRC | 13:31 | |
| *** yamamoto has joined #openstack-nova | 13:33 | |
| *** elmaciej has quit IRC | 13:36 | |
| openstackgerrit | Merged openstack/nova stable/pike: Add regression test for BFV+IsolatedHostsFilter failure https://review.openstack.org/543602 | 13:37 |
| *** tbachman has quit IRC | 13:37 | |
| *** brad[] has joined #openstack-nova | 13:38 | |
| *** yamamoto has quit IRC | 13:38 | |
| *** tssurya has joined #openstack-nova | 13:40 | |
| efried | bauzas: I wanted to get some feedback on vGPU inventorying/reporting through the Nova API, when you've got a minute. | 13:40 |
| *** dklyle has joined #openstack-nova | 13:44 | |
| *** david-lyle has quit IRC | 13:44 | |
| *** mvk has joined #openstack-nova | 13:47 | |
| bauzas | efried: sure ? | 13:47 |
| *** yamamoto has joined #openstack-nova | 13:48 | |
| efried | bauzas: What I'm wondering is: 1) Does the host's inventory of (v)GPUs show up in some nova API?; 2) Once you've created an instance with a vGPU, does that vGPU show up anywhere on the instance when you query it through the nova API? | 13:48 |
| *** psachin has quit IRC | 13:48 | |
| efried | ...and then assuming 'yes' to either/both, more details... | 13:48 |
| bauzas | efried: 1) no | 13:49 |
| bauzas | efried: 2) it's just a new PCI device | 13:49 |
| efried | bauzas: Okay, cool. | 13:50 |
| efried | edmondsw: ^ | 13:51 |
| edmondsw | bauzas any plans to address that gap? | 13:52 |
| *** yamamoto has quit IRC | 13:53 | |
| efried | jaypipes, edleafe, cdent: Is there a Nova API (as opposed to a placement API) where I can see an instance's allocations? In particular, for an arbitrary resource class I sent through via flavor extra_specs. | 13:54 |
| *** alexchad_ is now known as alexchadin | 13:54 | |
| bauzas | edmondsw: you mean, how to know the vGPU inventory by the API ? | 13:54 |
| *** idlemind has joined #openstack-nova | 13:54 | |
| bauzas | well, good question | 13:54 |
| bauzas | I haven't planned it yet | 13:54 |
| bauzas | using the Placement API, that said, you can ask for it | 13:55 |
| cdent | efried: I don't know, but you might dig around in the instance object to see which objects it links to and what method it and the have | 13:55 |
| *** jackie-truong has joined #openstack-nova | 13:56 | |
| jaypipes | efried: os-simple-tenant-usage | 13:56 |
| jaypipes | efried: is about the closest. | 13:56 |
| jaypipes | efried: doesn't look at placement though. | 13:56 |
| jaypipes | efried: and doesn't look at flavor extra specs :( | 13:56 |
| bauzas | yeah, for the moment, Placement API rather | 13:57 |
| efried | so resources other than proc, mem, disk, and PCI won't appear | 13:57 |
| *** tidwellr has joined #openstack-nova | 13:57 | |
| cdent | efried: did you mean HTTP API? | 13:57 |
| bauzas | efried: for vGPUs yeah | 13:57 |
| *** tbachman has joined #openstack-nova | 13:57 | |
| efried | cdent: Um, I think so? | 13:57 |
| efried | As opposed to, like, driver methods or whatever. | 13:57 |
| efried | Not sure whether it's HTTP or RPC - but yeah, remote officially-supported API. | 13:58 |
| efried | I guess it's HTTP. | 13:58 |
| mriedem | vgpu is stored as a vgpu resource / allocation in placement isn't it? | 13:58 |
| *** jackie-truong has quit IRC | 14:00 | |
| *** crushil has joined #openstack-nova | 14:00 | |
| *** tidwellr has quit IRC | 14:02 | |
| *** yamamoto has joined #openstack-nova | 14:03 | |
| bauzas | mriedem: that's correct, a specific RC | 14:03 |
| *** jackie-truong has joined #openstack-nova | 14:03 | |
| bauzas | so, specific inventories and allocations | 14:04 |
| bauzas | I have a devstack running somewhere | 14:05 |
| bauzas | I can show it | 14:05 |
| bauzas | mriedem: replied on https://bugs.launchpad.net/nova/+bug/1752463 | 14:05 |
| openstack | Launchpad bug 1752463 in OpenStack Compute (nova) "Attaching virtual GPU devices to guests in nova" [Medium,Incomplete] | 14:05 |
| bauzas | mriedem: thoughts on providing docs related to a specific device ? | 14:05 |
| *** swamireddy has quit IRC | 14:05 | |
| mriedem | yeah so vgpu will show up in placement, and you can use osc-placement to get the CLI | 14:06 |
| mriedem | simple tenant usage is going to be woefully out of date wrt the new fangled placement resources | 14:06 |
| bauzas | mriedem: IMHO, those kinds of driver-specific docs should be done downstream (like with RH OSP) | 14:06 |
| edmondsw | use case 1... need to query inventory data (type, whether / to what VM they are allocated, etc.) of GPUs and vGPUs on a given host | 14:06 |
| bauzas | mriedem: but if you'd like to get some nvidia specific details in https://docs.openstack.org/nova/queens/admin/virtual-gpu.html , lemme know | 14:07 |
| mriedem | bauzas: a small 'driver notes' section or something for known issues seems ok in the openstack docs | 14:07 |
| bauzas | mriedem: okay,n | 14:07 |
| bauzas | mriedem: I can add a note then | 14:07 |
| edmondsw | use case 2... need to query inventory data of GPUs and vGPUs allocated to a given VM | 14:07 |
| mriedem | doesn't answer my question if https://review.openstack.org/#/c/459753/ handles this | 14:07 |
| mriedem | for nvidia | 14:07 |
| edmondsw | I think we can get some of that from placement, but not all? | 14:07 |
| bauzas | mriedem: no, it's not helping | 14:07 |
| mriedem | edmondsw: i think you can get all of that from placement | 14:07 |
| bauzas | mriedem: hiding is just for PCI passthrough | 14:07 |
| *** yamamoto has quit IRC | 14:07 | |
| *** sar has quit IRC | 14:07 | |
| mriedem | edmondsw: and with what's already available in the CLI https://docs.openstack.org/osc-placement/latest/index.html | 14:08 |
| bauzas | mriedem: the problem with OVH is that they use some product lines that are not accepted by the nvidia driver :p | 14:08 |
| bauzas | mriedem: so they hide the fact they're virtualizging | 14:08 |
| *** hongbin has joined #openstack-nova | 14:08 | |
| bauzas | mriedem: but in order to make virtual GPUs, you need a specific product line anyway | 14:08 |
| *** swamireddy has joined #openstack-nova | 14:10 | |
| edmondsw | mriedem can you query the placement API by server instance? | 14:10 |
| bauzas | shit, pilgrimstack isn't here | 14:10 |
| edmondsw | if not, then placement doesn't give you use case 2 | 14:11 |
| bauzas | can't remember the product that OVH used for their production boxes, but it's not a Tesla line | 14:11 |
| bauzas | hence the need for hiding the virt driver | 14:11 |
| *** sar has joined #openstack-nova | 14:12 | |
| bauzas | edmondsw: https://developer.openstack.org/api-ref/placement/#list-allocations | 14:13 |
| bauzas | edmondsw: the consumer_uuid is the instance UUID | 14:13 |
| mriedem | edmondsw: yes | 14:14 |
| edmondsw | bauzas ah tx | 14:14 |
| bauzas | edmondsw: it'll show up the existing allocations for each RP | 14:14 |
| *** Zames has joined #openstack-nova | 14:14 | |
| mriedem | edmondsw: in the CLI, the instance == the consumer | 14:14 |
| *** mgoddard has quit IRC | 14:14 | |
| mriedem | edmondsw: https://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-show | 14:14 |
| mriedem | that's the one you want i think | 14:14 |
| mriedem | shows allocations for a given consumer (instance) | 14:14 |
| mriedem | https://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-inventory-show shows inventory for a given provider (compute node) | 14:15 |
| edmondsw | thanks | 14:15 |
| mriedem | if you love that stuff, https://review.openstack.org/#/q/status:open+project:openstack/osc-placement+branch:master+topic:bp/placement-osc-plugin-rocky | 14:15 |
| mriedem | reviews welcome | 14:15 |
| *** itlinux has quit IRC | 14:16 | |
| *** Zames has quit IRC | 14:16 | |
| *** itlinux has joined #openstack-nova | 14:17 | |
| *** mlavalle has joined #openstack-nova | 14:18 | |
| *** yamamoto has joined #openstack-nova | 14:18 | |
| *** esberglu has joined #openstack-nova | 14:19 | |
| bauzas | jaypipes: cfriesen: stephenfin: efried: thanks for your reviews on https://review.openstack.org/#/c/552924/3 | 14:20 |
| bauzas | I need to look at all of them | 14:20 |
| *** tssurya has quit IRC | 14:20 | |
| *** itlinux has quit IRC | 14:22 | |
| Kevin_Zheng | Hi, could anyone kindly provide some suggestions on funcional tests in https://review.openstack.org/#/c/553288/ | 14:22 |
| *** yamamoto has quit IRC | 14:23 | |
| *** tidwellr has joined #openstack-nova | 14:24 | |
| bauzas | jaypipes: efried: stephenfin: could we maybe do a hangout based on https://review.openstack.org/#/c/552924/3/specs/rocky/approved/numa-topology-with-rps.rst ? | 14:24 |
| *** derekh has quit IRC | 14:25 | |
| jaypipes | bauzas: maybe tomorrow morning? | 14:25 |
| *** r-daneel has joined #openstack-nova | 14:25 | |
| jaypipes | bauzas: currently working on a number of things that might affect that | 14:25 |
| Kevin_Zheng | I'm adding 'request_id' field to the nofitications, while testing, I have to compare the 'request_id' field in the payload with the reference, as req_id is in the response header, so it seems I have to modify the return value in common methods in nova.tests.functional.api.client, don't know if this is a suitable approach or not | 14:25 |
| bauzas | jaypipes: I'm not in a rush | 14:25 |
| efried | bauzas: I'm game. Just let me know. | 14:25 |
| bauzas | jaypipes: I just felt that sharding our resources between NUMA nodes is at risk | 14:26 |
| bauzas | jaypipes: hence the use of specific RCs | 14:26 |
| openstackgerrit | Dan Smith proposed openstack/nova stable/queens: Add --by-service to discover_hosts https://review.openstack.org/554600 | 14:26 |
| *** derekh has joined #openstack-nova | 14:27 | |
| *** tidwellr has quit IRC | 14:28 | |
| *** jackie-truong has quit IRC | 14:29 | |
| stephenfin | bauzas, jaypipes: Tomorrow afternoon (GMT) would be OK with me, yes | 14:30 |
| bauzas | k | 14:31 |
| bauzas | we could need cfriesen too | 14:31 |
| bauzas | but he's in another TZ | 14:31 |
| *** sar has quit IRC | 14:31 | |
| *** elmaciej has joined #openstack-nova | 14:32 | |
| *** gouthamr has joined #openstack-nova | 14:32 | |
| *** yamamoto has joined #openstack-nova | 14:33 | |
| *** tssurya has joined #openstack-nova | 14:34 | |
| *** suresh12 has joined #openstack-nova | 14:34 | |
| mriedem | Kevin_Zheng: it looks like that patch is already testing what you want | 14:36 |
| mriedem | the sample in https://review.openstack.org/#/c/553288/4/doc/notification_samples/common_payloads/InstanceActionPayload.json is just for docs, | 14:36 |
| mriedem | the request id generated in the functional test run is going to be unique, | 14:36 |
| mriedem | which is why you are doing the replacement stuff in https://review.openstack.org/#/c/553288/4/nova/tests/functional/notification_sample_tests/test_instance.py | 14:37 |
| *** yamamoto has quit IRC | 14:38 | |
| mriedem | Kevin_Zheng: left a comment / suggestion about possibly cleaning up the copy/paste in ^ | 14:38 |
| *** abhishekk has joined #openstack-nova | 14:38 | |
| *** suresh12 has quit IRC | 14:39 | |
| mriedem | seems you have a bug in the functional tests http://logs.openstack.org/88/553288/4/check/nova-tox-functional/6049993/testr_results.html.gz | 14:39 |
| *** amoralej|lunch is now known as amoralej | 14:40 | |
| Kevin_Zheng | actually I only changed test_create_server_error thistest | 14:40 |
| Kevin_Zheng | for testing | 14:40 |
| Kevin_Zheng | you can check the result for this one | 14:40 |
| Kevin_Zheng | the req_id didn't match | 14:41 |
| Kevin_Zheng | which I did replaced | 14:41 |
| *** jbernard has quit IRC | 14:42 | |
| *** jbernard has joined #openstack-nova | 14:42 | |
| mriedem | is an admin context getting generated somewhere? | 14:43 |
| mriedem | context.get_admin_context() will return a unique request id | 14:43 |
| Kevin_Zheng | I will check | 14:44 |
| *** yamamoto has joined #openstack-nova | 14:46 | |
| *** yamamoto has quit IRC | 14:46 | |
| *** dave-mccowan has joined #openstack-nova | 14:47 | |
| openstackgerrit | Merged openstack/nova master: trivialfix: cleanup _pack_instance_onto_cores() https://review.openstack.org/538698 | 14:47 |
| *** felipemonteiro__ has quit IRC | 14:47 | |
| *** felipemonteiro__ has joined #openstack-nova | 14:47 | |
| openstackgerrit | Merged openstack/nova master: Handle EndpointNotFound when building image_ref_url in notifications https://review.openstack.org/554703 | 14:47 |
| openstackgerrit | Merged openstack/nova stable/queens: Only attempt a rebuild claim for an evacuation to a new host https://review.openstack.org/550545 | 14:47 |
| openstackgerrit | Merged openstack/nova stable/queens: Unmap compute nodes when deleting host mappings in delete cell operation https://review.openstack.org/553496 | 14:48 |
| jaypipes | bauzas: cfriesen is in EST timezone I think? | 14:48 |
| openstackgerrit | Merged openstack/nova stable/pike: Detach volumes when VM creation fails https://review.openstack.org/544143 | 14:48 |
| bauzas | jaypipes: living in Alberta IIRC | 14:49 |
| jaypipes | ah.. I thought it was Ottawa | 14:49 |
| *** sidx64 has quit IRC | 14:49 | |
| *** alexchadin has quit IRC | 14:50 | |
| *** germs has quit IRC | 14:51 | |
| *** gyankum has quit IRC | 14:51 | |
| *** felipemonteiro_ has joined #openstack-nova | 14:52 | |
| *** germs has joined #openstack-nova | 14:52 | |
| mriedem | dansmith: thoughts on a better name for this thing in tssurya's disabled cells series? https://review.openstack.org/#/c/550188/12/nova/objects/cell_mapping.py@165 | 14:53 |
| Kevin_Zheng | mriedem thanks for the comment and advise, I will have to check the details tomorrow, it is late here :) | 14:54 |
| mriedem | Kevin_Zheng: np, ttyl | 14:54 |
| mriedem | tssurya: also, i wonder if it would be better if the 'disabled' param doesn't have a default | 14:54 |
| mriedem | since 'enabled_or_disabled' is further confused by the fact it has a default behavior | 14:54 |
| tssurya | yea I was waiting for inputs regarding the name for that function | 14:55 |
| *** felipemonteiro__ has quit IRC | 14:55 | |
| openstackgerrit | Silvan Kaiser proposed openstack/nova master: Exec systemd-run with privileges in Quobyte driver https://review.openstack.org/554195 | 14:55 |
| dansmith | mriedem: commented | 14:55 |
| *** Eran_Kuris has quit IRC | 14:56 | |
| mriedem | i'm cool with get_by_disabled, but don't default the 'disabled' param? | 14:56 |
| mriedem | so caller has to know what they are asking for | 14:56 |
| dansmith | yep | 14:56 |
| mriedem | ok wfm | 14:57 |
| tssurya | wiat, so get_by_disabled() will give enabled by default right ? | 14:57 |
| mriedem | no | 14:57 |
| mriedem | no default | 14:57 |
| mriedem | no kwarg | 14:57 |
| stephenfin | Is there another stable core that could take a look at this, please? https://review.openstack.org/#/c/550079/ | 14:57 |
| tssurya | ah so the user has to pass a value | 14:57 |
| mriedem | stephenfin: i can | 14:57 |
| mriedem | tssurya: yeah | 14:57 |
| tssurya | it becomes mandatory, got it | 14:57 |
| tssurya | works for me as well | 14:57 |
| tssurya | thanks | 14:57 |
| stephenfin | mriedem: Thank you | 14:59 |
| *** yamahata has joined #openstack-nova | 14:59 | |
| *** amodi has joined #openstack-nova | 15:00 | |
| mriedem | stephenfin: do you want to propose a release for os-vif on master? | 15:00 |
| mriedem | if this is high severity | 15:00 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add aggregates list to Destination object https://review.openstack.org/544729 | 15:00 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add request filter functionality to scheduler https://review.openstack.org/544730 | 15:00 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make get_allocation_candidates() honor aggregate restrictions https://review.openstack.org/547990 | 15:00 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | 15:00 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282 | 15:00 |
| *** crushil has quit IRC | 15:04 | |
| mriedem | stephenfin: what is the minimum version that --may-exist exists in ovs-vsctl? | 15:04 |
| *** mdnadeem has quit IRC | 15:06 | |
| *** felipemonteiro__ has joined #openstack-nova | 15:07 | |
| *** sidx64 has joined #openstack-nova | 15:07 | |
| *** moshele has quit IRC | 15:09 | |
| mriedem | looks like forever ago https://github.com/openvswitch/ovs/commit/bb1c67c813c9bd80c2bd9acf2bf5158b48841c61 | 15:10 |
| *** Drankis has joined #openstack-nova | 15:10 | |
| *** felipemonteiro_ has quit IRC | 15:11 | |
| *** gjayavelu has joined #openstack-nova | 15:11 | |
| cfriesen | bauzas: you wanted to set up a meeting? I'm in CST timezone...it's 9:12. | 15:12 |
| *** _ix has joined #openstack-nova | 15:12 | |
| bauzas | cfriesen: just discussing about NUMA topology | 15:12 |
| bauzas | cfriesen: but jaypipes asked for tomorrow morning EST | 15:12 |
| cfriesen | should be doable | 15:13 |
| cfriesen | jaypipes: my team is in Ottawa, I'm in Saskatchewan | 15:13 |
| *** sidx64 has quit IRC | 15:14 | |
| mriedem | sean-k-mooney: are you ok with this on stable/queens? https://review.openstack.org/#/c/554917/ | 15:16 |
| gibi | Kevin_Zheng: sorry I haven't had time yet to think about your request_id functional test problem but I did not forget it | 15:16 |
| gibi | mriedem: fyi here is a followup bug for the notifications-calling-keystone problem https://bugs.launchpad.net/nova/+bug/1757407 | 15:18 |
| openstack | Launchpad bug 1757407 in OpenStack Compute (nova) "Notification sending sometimes hits the keystone API to get glance endpoints" [Undecided,New] | 15:18 |
| gibi | mriedem: there is a case where we hit keystone even if only versioned notifications are configured to be emitted | 15:18 |
| Kevin_Zheng | gibi: np I was also busy these days so I didn’t dig deeper, I will try to find out what’s going on tomorrow:) | 15:18 |
| stephenfin | mriedem: Yup, it's there since forever. There was an issue with it but that was resolved in...OVS 2.5, iirc | 15:19 |
| stephenfin | and it wasn't a significant issue. Could only be reproduced under very specific circumstances | 15:19 |
| *** elmaciej_ has joined #openstack-nova | 15:19 | |
| mriedem | gibi: yeah so we could optimize to not even do that lookup if only using versioned notifications, | 15:21 |
| mriedem | also, efried said the glance endpoint / service catalog information should be cached in ksa, so we shouldn't be hitting the keystone API every time, only the first time, | 15:21 |
| stephenfin | mriedem: Also, I can propose a fix, yup | 15:21 |
| mriedem | but it's curious that we could create a server (which would fetch the image on the compute) and then the periodic (without a token) would have problems stopping it | 15:22 |
| *** sridharg has quit IRC | 15:22 | |
| mriedem | unless you did something like had (1) cached images on the compute or (2) restarted nova-compute in between to invalidate the ksa cache | 15:22 |
| *** elmaciej has quit IRC | 15:22 | |
| openstackgerrit | Merged openstack/os-vif stable/queens: ovs: do not delete port if already exists https://review.openstack.org/550079 | 15:22 |
| mriedem | unless the cache has a timer on it? or is somehow otherwise request-specific | 15:22 |
| gibi | mriedem: I can try to create a functional test for this | 15:23 |
| sahid | jaypipes, mriedem, anychance to have you ack this ? https://review.openstack.org/#/c/485522/ | 15:23 |
| mriedem | sahid: i'll look at it again today | 15:23 |
| mriedem | s/today/now | 15:24 |
| sahid | cool thanks | 15:24 |
| efried | mriedem, gibi: The caching would be specific to the context. So you would be hitting the endpoint (to do version discovery) once per unique context (as opposed to just the first time overall). | 15:24 |
| *** jamesdenton has quit IRC | 15:24 | |
| efried | ...I think. | 15:25 |
| mriedem | ah ok | 15:25 |
| mriedem | well that makes sense then | 15:25 |
| *** sridharg has joined #openstack-nova | 15:25 | |
| *** sridharg has quit IRC | 15:25 | |
| gibi | efried, mriedem: a periodic task runs with the same context every time, i guess | 15:25 |
| *** sridharg has joined #openstack-nova | 15:25 | |
| mriedem | gibi: nope | 15:26 |
| mriedem | gibi: periodic tasks actually run with the last context stored in the local thread, | 15:26 |
| mriedem | something like that, but that's why we see request IDs for user contexts get mixed up with periodic tasks in the logs | 15:26 |
| mriedem | and it's totally confusing | 15:26 |
| gibi | mriedem: I thought about this https://review.openstack.org/#/c/524306 | 15:26 |
| mriedem | yes we were talking about that the otherday | 15:27 |
| *** abhishekk has quit IRC | 15:27 | |
| gibi | mriedem: so that patch will make sure that the periodic task runs with the same context every time | 15:27 |
| mriedem | for the lifetime of that service process yes i think so | 15:28 |
| gibi | mriedem: which will limit the performance impact of the notifications calling keystone | 15:28 |
| mriedem | well, the notifications can't call keystone anyway | 15:28 |
| gibi | mriedem: due to the cache in ksa | 15:28 |
| mriedem | they don't have a token | 15:28 |
| gibi | mriedem: OK, I'm confused. :) | 15:29 |
| mriedem | we realized that "ctxt = context.get_admin_context()" has this overwrite=False flag: https://github.com/openstack/nova/blob/master/nova/context.py#L290 | 15:29 |
| mriedem | which is used in the parent class in oslo.context | 15:29 |
| mriedem | https://github.com/openstack/oslo.context/blob/master/oslo_context/context.py#L225 | 15:29 |
| gibi | mriedem: so if the first call to keystone from the periodic task fails then there is nothing to cache so the next call will also go to keystone and fail again | 15:31 |
| mriedem | from what i can tell, that's why periodic tasks re-use the request id from the local thread store | 15:31 |
| mriedem | gibi: i think so | 15:31 |
| dansmith | mriedem: stvnoyes1: this patch is changing code you wrote for the new attachment workflow, but makes it much simpler.. what am I missing? https://review.openstack.org/#/c/551302 | 15:31 |
| gibi | mriedem: then definitely need remove the keystone call from the notification codepath | 15:32 |
| gibi | mriedem: what do you think can we do someting with the legacy notifications top of what you already did by catching the exception? | 15:32 |
| gibi | mriedem: to avoid the keystone call | 15:32 |
| mriedem | dansmith: i haven't dug into that one in detail yet | 15:33 |
| *** yamamoto has joined #openstack-nova | 15:33 | |
| mriedem | because it's going to require loading a bunch of context into my head, including stuff like mixed version compute issues | 15:33 |
| dansmith | mriedem: I don't think it does actually, | 15:34 |
| gibi | mriedem: maybe not even trying to generate the glance url (and call keystone) if the glance/api_server config is not set | 15:34 |
| dansmith | mriedem: it doesn't change what we do over the wire | 15:34 |
| mriedem | gibi: can't really do much there for the legacy ones | 15:34 |
| *** zhaochao has quit IRC | 15:34 | |
| mriedem | i'm mid-review in sahid's spec review so will have to look in a bit | 15:35 |
| dansmith | ack, thanks | 15:35 |
| stvnoyes1 | dansmith, thanks, I'll take a look at it. I'll have to remember what I did and why. | 15:35 |
| *** liverpooler has joined #openstack-nova | 15:35 | |
| *** kholkina has quit IRC | 15:35 | |
| mriedem | everything stvnoyes1 added would have just been conditional logic on the flow for the new attachment ID stuff | 15:36 |
| mriedem | which was fairly mechanical, i.e. 'we used to call initialize_connection to get a new connection_info, now we call attachment_update' | 15:37 |
| dansmith | mriedem: yeah, but the intersection is that this seems to preclude adding old_attachment_id to the migratedata stuff for the v3 attach, | 15:37 |
| dansmith | but also fixes the same issue that old_attachment_id fixes for v3, but for v2 | 15:38 |
| dansmith | I mean, that's the assertion | 15:38 |
| *** tidwellr has joined #openstack-nova | 15:38 | |
| dansmith | mdbooth: the bug is basically just the commit message on the patch.. can you add some more detail (logs, traces, etc) to help make it more convincingly problematic? | 15:39 |
| *** RaoulHC has quit IRC | 15:39 | |
| dansmith | mdbooth: because since the old side of all this code has been around for a while, it's legit to question that it's been broken this long, even if it's just for one driver | 15:39 |
| *** elmaciej has joined #openstack-nova | 15:40 | |
| *** elmaciej_ has quit IRC | 15:42 | |
| *** tidwellr has quit IRC | 15:43 | |
| openstackgerrit | Merged openstack/nova master: ironic: stop lying to the RT when ironic is down https://review.openstack.org/545479 | 15:46 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add aggregates list to Destination object https://review.openstack.org/544729 | 15:48 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add request filter functionality to scheduler https://review.openstack.org/544730 | 15:48 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make get_allocation_candidates() honor aggregate restrictions https://review.openstack.org/547990 | 15:48 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | 15:48 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282 | 15:48 |
| *** eharney has joined #openstack-nova | 15:48 | |
| mriedem | sahid: question in https://review.openstack.org/#/c/485522/ about how the guest knows if the VFs are trusted | 15:50 |
| *** chyka has joined #openstack-nova | 15:50 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Handle EndpointNotFound when building image_ref_url in notifications https://review.openstack.org/554963 | 15:52 |
| *** Drankis has quit IRC | 15:52 | |
| *** mgoddard has joined #openstack-nova | 15:56 | |
| mriedem | alright now for this live migration funbag | 15:57 |
| dansmith | mriedem: I just threw some more info into the bug from our downstream details | 15:58 |
| dansmith | might be worth reading first, it's short | 15:58 |
| *** munimeha1 has joined #openstack-nova | 15:58 | |
| *** gjayavelu has quit IRC | 15:59 | |
| mriedem | alright. i do remember talking about this a bit with mdbooth pre-patch | 16:00 |
| *** yamahata has quit IRC | 16:00 | |
| *** lajoskatona has quit IRC | 16:00 | |
| *** efried is now known as efried_rollin | 16:01 | |
| mriedem | oh btw, here i can trade a volume issue during cold migration https://review.openstack.org/#/c/554667/ | 16:04 |
| mriedem | much easier | 16:04 |
| dansmith | sure, I'll take that trade | 16:05 |
| sahid | mriedem: good i did not provided any information about that point, do you know that there is a ask for that? | 16:06 |
| sahid | s/good/good question | 16:06 |
| *** itlinux has joined #openstack-nova | 16:07 | |
| mriedem | sahid: i think the user impact section of the spec says that with this, the user can change the mac address, | 16:07 |
| mriedem | but that happens in the guest (not noted clearly really in that section), | 16:07 |
| sahid | mriedem: yes in the guest | 16:07 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add CellMappingList.get_by_disabled() query method https://review.openstack.org/550188 | 16:07 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Allow scheduling only to enabled cells (Filter Scheduler) https://review.openstack.org/550527 | 16:07 |
| mriedem | and i was thinking, how is the guest going to know if it can do this unless there are device tags on that sriov port in the config drive / metadata | 16:07 |
| mriedem | or is there another way? | 16:08 |
| mriedem | we don't model VFs in the metadata that goes into the guest do we? | 16:08 |
| mriedem | i thought it was just block devices and ports | 16:09 |
| sahid | from the guest, instead of trying to change the MAC address, we can't really know if the VF is using trusted or mode | 16:10 |
| sahid | about metadata | 16:10 |
| sahid | i think there were some work around that | 16:10 |
| sahid | i will check | 16:10 |
| sahid | perhaps we could add a new attribute | 16:10 |
| mriedem | i'm looking at nova.network.netutils.get_network_metadata | 16:10 |
| *** danpawlik has quit IRC | 16:11 | |
| mriedem | seems like the _get_eth_link method would be the place to take information off the vif's port binding profile that has the 'trusted' flag and put that into the entry | 16:12 |
| artom | mriedem, we have a generic 'devices' section in the metadata, we can add stuff to it | 16:12 |
| artom | hyperv already do stuff in there that's not related to device tagging | 16:12 |
| mriedem | this is specific to network data though | 16:13 |
| mriedem | idk what's the best solution here, i'm not an expert on the metadata service or how a guest would consume trusted SRIOV ports in the guest, | 16:13 |
| mriedem | but it's obviously something we should think about how that gets modeled so the guest application can actually leverage the thing | 16:14 |
| artom | mriedem, wait, we're talking about trusted VFs? | 16:14 |
| mriedem | yes | 16:15 |
| artom | What's wrong with just having an interface: {mac: blah, trusted:true} blob in there. | 16:15 |
| artom | ? | 16:15 |
| *** itlinux has quit IRC | 16:15 | |
| artom | The exact format is obviously to be worked out :) | 16:15 |
| mriedem | hold dear caller | 16:15 |
| mriedem | artom: https://review.openstack.org/#/c/485522/ | 16:16 |
| mriedem | questions/comments are in there | 16:16 |
| *** diga has joined #openstack-nova | 16:16 | |
| *** andreas_s has quit IRC | 16:16 | |
| diga | jaypipes: Hi | 16:16 |
| *** Guest17101 has quit IRC | 16:16 | |
| *** jackie-truong has joined #openstack-nova | 16:17 | |
| diga | jaypipes: assigned this bug - https://bugs.launchpad.net/nova/+bug/1751692 to me | 16:17 |
| openstack | Launchpad bug 1751692 in OpenStack Compute (nova) "os_region_name an unnecessary required option for placement " [Low,Triaged] - Assigned to Digambar (digambarpatil15) | 16:17 |
| artom | mriedem, aha, thanks - I keep being dragged off for downstream stuff, but I've already added myself in there, will try to take a look | 16:17 |
| * sahid on call | 16:17 | |
| *** derekh has quit IRC | 16:21 | |
| *** derekh has joined #openstack-nova | 16:22 | |
| *** wolverineav has joined #openstack-nova | 16:22 | |
| mriedem | dansmith: mdbooth: ok for this bug, first thing, the bug report says, "During live migration we update bdm.connection_info for attached volumes in pre_live_migration to reflect the new connection on the destination node." - in the libvirt driver pre_live_migration i see where we connect the volumes on the dest host: https://github.com/openstack/nova/blob/2ec8c49f6cb4a0e7dba217e824c20d9c703d2105/nova/virt/libvirt/driver.py#L | 16:23 |
| mriedem | and we stash the bdm info for the migration data object https://github.com/openstack/nova/blob/2ec8c49f6cb4a0e7dba217e824c20d9c703d2105/nova/virt/libvirt/driver.py#L7621 | 16:23 |
| mriedem | but don't see where the bdm.connection_info gets updated and saved off from the dest host into the db | 16:23 |
| dansmith | hang on | 16:24 |
| dansmith | oh, where it gets saved | 16:24 |
| mdbooth | mriedem: I think I put that in a review comment somewhere because it's super obtuse | 16:24 |
| dansmith | we look it up from the db again, but.. | 16:24 |
| dansmith | is this the weird commit() decorator thing? | 16:24 |
| mriedem | update_db()? | 16:24 |
| mdbooth | Hmm, perhaps I'm imagining the review comment. Or perhaps it was a different review. | 16:25 |
| dansmith | yeah I don't see a comment | 16:25 |
| mriedem | i don't see pre_live_migration() go through nova.virt.block_device to attach anything though | 16:25 |
| dansmith | but BDMs get magically saved I think no? | 16:26 |
| mriedem | the virt driver gets the bdms and connects them on the host directly | 16:26 |
| *** andreas_s has joined #openstack-nova | 16:26 | |
| mriedem | so, pre_live_migration on the dest host calls this | 16:26 |
| mriedem | block_device_info = self._get_instance_block_device_info( | 16:26 |
| mriedem | context, instance, refresh_conn_info=True, | 16:26 |
| mriedem | bdms=bdms) | 16:26 |
| mriedem | and that will initialize the connection on the dest host and update the connection_info and save it | 16:26 |
| mriedem | so that's likely it | 16:26 |
| mdbooth | It's in _get_instance_block_device_info() I think | 16:26 |
| mriedem | yeah ^ | 16:27 |
| mdbooth | Yeah, that's it | 16:27 |
| mdbooth | refresh_conn_info | 16:27 |
| mriedem | the thing dansmith just approved my multiattach patch | 16:27 |
| *** masber has quit IRC | 16:27 | |
| mriedem | right so during pre_live_migration on the dest host the compute manager gets here https://github.com/openstack/nova/blob/2ec8c49f6cb4a0e7dba217e824c20d9c703d2105/nova/virt/block_device.py#L633 | 16:27 |
| mriedem | uses the host connector from the dest host | 16:27 |
| mriedem | gets a new connection_info and updates the bdm | 16:27 |
| openstackgerrit | Saju M proposed openstack/python-novaclient master: pypy is not checked at gate https://review.openstack.org/554983 | 16:27 |
| mriedem | because @update_db | 16:27 |
| mriedem | and then uses that to connect the volumes in the virt driver | 16:28 |
| mriedem | and that gets put into the LibvirtLiveMigrateBDMInfo objects | 16:28 |
| mriedem | with the new flow, the connection_info for the source and dest attachments are stored in cinder with those attachments, so not a problem for the new flow | 16:28 |
| *** diga has quit IRC | 16:29 | |
| mriedem | problem in nova is we have 1 bdm for all attachments so the connection_info gets overwritten | 16:29 |
| dansmith | jump down, turn around, pick a bail of cotton | 16:29 |
| *** afaranha has quit IRC | 16:29 | |
| *** AlexeyAbashkin has quit IRC | 16:29 | |
| dansmith | teag | 16:29 |
| dansmith | er, yeah | 16:29 |
| mriedem | now i'm thining about line dancing to brooks and dunn in 6th grade gym class, | 16:29 |
| mriedem | thanks for that | 16:29 |
| dansmith | mriedem: so did you see my comment about not changing the new path? | 16:30 |
| dansmith | since I think it's immune | 16:30 |
| mriedem | i'm just loading context from the first sentence in the bug report at this point :) | 16:30 |
| mriedem | and also https://www.youtube.com/watch?v=d05tQrhNMkA | 16:30 |
| dansmith | heh, okay | 16:30 |
| *** andreas_s has quit IRC | 16:30 | |
| dansmith | ain't nothin' wrong with that | 16:31 |
| mriedem | there is plenty wrong with that | 16:31 |
| mriedem | ok so back to this | 16:31 |
| *** tidwellr has joined #openstack-nova | 16:32 | |
| mriedem | ok so in _post_live_migration in the compute, we get the BDMs again but don't refresh their connection_info b/c that would screw up the bdms which are now on the dest host, | 16:32 |
| mriedem | we call into the virt driver's post_live_migration method to disconnect the volumes and have to call initialize_connection from the source host to get the proper connection_info for the source host | 16:33 |
| mriedem | for the old flow | 16:33 |
| mriedem | and at this point, the cinder driver is returning different connection_info from what was used to originally connect the volume on the source host, and we blow up | 16:34 |
| dansmith | mriedem: youtube tells me there's an upcoming Brooks & Dunn concert in MN in July.. better get on that | 16:35 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/534384 | 16:35 |
| mriedem | now, the goal here is to stash off the original source host connection_info so we can use that to disconnect later? | 16:35 |
| mriedem | post-live migrate | 16:35 |
| dansmith | yeah | 16:35 |
| mriedem | what if we should be using the latest connection_info from cinder for the source host to disconnect? | 16:35 |
| mriedem | like, what if the rbd driver changed the auth information for the ceph backend? | 16:35 |
| mriedem | and the original stuff in the source host connection_info is stale | 16:36 |
| *** elmaciej_ has joined #openstack-nova | 16:36 | |
| *** elmaciej has quit IRC | 16:36 | |
| dansmith | mriedem: did you check out the cinder bug and patch? | 16:36 |
| dansmith | gorka says we shouldn't sending the latest | 16:36 |
| mriedem | looking | 16:36 |
| dansmith | I dunno if that means we shouldn't be sending the thing we grabbed before the migration if it changed right after, | 16:37 |
| dansmith | but that'd be fairly obscure and hard to do I think | 16:37 |
| *** danpawlik has joined #openstack-nova | 16:37 | |
| dansmith | we'd have to catch it before it gets set and overwritten | 16:37 |
| dansmith | well, I guess gorka's comments are in our downstream bug actually | 16:38 |
| mriedem | yeah was going to say | 16:38 |
| mriedem | i feel like i'll get different answers based on which cinder cores i ask | 16:38 |
| *** gyee has joined #openstack-nova | 16:38 | |
| mriedem | jgriffith: smcginnis | 16:38 |
| mriedem | hemna | 16:38 |
| mriedem | having said that, for the new flow, the original connection_info from the source host is stored in cinder with the attachment record for the source host, | 16:39 |
| dansmith | mriedem: can you see this? https://bugzilla.redhat.com/show_bug.cgi?id=1552232 | 16:39 |
| openstack | dansmith: Error: Error getting bugzilla.redhat.com bug #1552232: NotPermitted | 16:39 |
| mriedem | so when we disconnect post live migration, we'll be using that original value, not something new | 16:39 |
| *** sar has joined #openstack-nova | 16:39 | |
| dansmith | guess not | 16:39 |
| mriedem | dansmith: nope | 16:39 |
| dansmith | mriedem: yeah, using the original attachment id is definitely better than having to have these connectors line up and potentially be changed if you're saying that could happen mid-migration | 16:40 |
| *** damien_r has quit IRC | 16:41 | |
| mriedem | i guess my point is just, i wouldn't be surprised if at some later date, someone reports a bug saying something in the storage backend or source host changed and they actually need to get the latest information to disconnect | 16:41 |
| mriedem | sort of like the discussion in denver about always refreshing connection_info whenever we do stuff | 16:42 |
| mriedem | to get things like latest ceph mon address and creds | 16:42 |
| dansmith | mriedem: so actually, re-reading gorka's comments, | 16:42 |
| *** danpawlik has quit IRC | 16:42 | |
| dansmith | mriedem: what he's saying we shouldn't be doing is calling initialize_connection again to get the connector from the volume | 16:43 |
| dansmith | which we're then using to detach | 16:43 |
| dansmith | so old line 7724 here: https://review.openstack.org/#/c/551302/6/nova/virt/libvirt/driver.py | 16:43 |
| mriedem | yeah i understand, but as noted, we have to do that because right now with the old flow, the bdm.connection_info is from the dest host, and the only way to get the connection_info with the old flow for the source host is to call initialize_connection with the source host connector | 16:44 |
| *** jackie-truong has quit IRC | 16:44 | |
| dansmith | yeah I know | 16:44 |
| mriedem | so i guess the point is calling initialize_connection when the volume is already connected on another host can cause problems if you call it again, for some cinder backends | 16:45 |
| mriedem | but we've been doing this forever | 16:45 |
| dansmith | mriedem: "So Nova should not be making a second initialize connection for a volume that is already attached to the node and use the information it already has in the DB to do the disconnect" | 16:45 |
| mriedem | except we didn't have that information in the db | 16:46 |
| dansmith | ^ gorka's comments from the downstream bug | 16:46 |
| mriedem | hence the workaround | 16:46 |
| dansmith | mriedem: well, it's just one backend remember, and that one is fixed now | 16:46 |
| mriedem | if initialize_connection is supposed to be idempotent, which i always thought it was, i don't see the issue | 16:46 |
| jgriffith | mriedem: you have a link to the bug? | 16:46 |
| mriedem | jgriffith: nova bug https://bugs.launchpad.net/nova/+bug/1754716 | 16:46 |
| openstack | Launchpad bug 1754716 in OpenStack Compute (nova) "Disconnect volume on live migration source fails if initialize_connection doesn't return identical output" [Undecided,In progress] - Assigned to Matthew Booth (mbooth-9) | 16:46 |
| mriedem | jgriffith: cinder bug https://bugs.launchpad.net/cinder/+bug/1756914 | 16:46 |
| openstack | Launchpad bug 1756914 in Cinder "Dell EMC SC: Initialize_connection returns all connections" [Undecided,Fix released] - Assigned to Tom Swanson (tom-swanson) | 16:46 |
| mriedem | plus a red hat bz that we don't have access to | 16:47 |
| dansmith | yeah, sorry :( | 16:47 |
| *** lyan has joined #openstack-nova | 16:47 | |
| dansmith | jgriffith: gorka has context on this but I don't see him around here | 16:47 |
| *** lyan is now known as Guest90893 | 16:47 | |
| mriedem | he's in -cinder | 16:47 |
| jgriffith | Yeah, not in this channel, I'll ping him | 16:47 |
| dansmith | I looked, maybe I don't know his nick? | 16:47 |
| dansmith | I thought it was geguilar or something | 16:48 |
| mriedem | he's been pung | 16:48 |
| *** geguileo has joined #openstack-nova | 16:48 | |
| dansmith | huh, sorry, I looked and just missed it | 16:48 |
| geguileo | mriedem: jgriffith hi | 16:48 |
| *** Swanson has joined #openstack-nova | 16:49 | |
| mriedem | who wants to update him? | 16:49 |
| mriedem | i can start | 16:49 |
| mriedem | geguileo: so you're familiar with https://bugs.launchpad.net/nova/+bug/1754716 right? | 16:49 |
| openstack | Launchpad bug 1754716 in OpenStack Compute (nova) "Disconnect volume on live migration source fails if initialize_connection doesn't return identical output" [Undecided,In progress] - Assigned to Matthew Booth (mbooth-9) | 16:49 |
| dansmith | geguileo: it's about this: https://bugs.launchpad.net/nova/+bug/1754716 | 16:49 |
| dansmith | geguileo: which was a cinder backend fix for the dell driver, plus making nova not call initialize_connection() a second time | 16:49 |
| mriedem | geguileo: i'm trying to understand if initialize_connection is supposed to be idempotent or not | 16:49 |
| smcginnis | Swanson: You may be interested too. ^^ | 16:49 |
| Swanson | smcginnis, already there | 16:49 |
| dansmith | geguileo: you asserted in our downstream bug that calling initialize_connection really late during disconnect after a live migration was wrong and we should avoid doing it | 16:50 |
| geguileo | mriedem: the problem is that Cinder never asked drivers to be idempotent | 16:50 |
| Swanson | here | 16:50 |
| jgriffith | mriedem: you're just begging for 3 different answers :) | 16:50 |
| smcginnis | mriedem: It is, but that was a surprise to most around the Liberty timeframe. | 16:50 |
| * dansmith shuts up | 16:50 | |
| smcginnis | Or rather, it wasn't, until we found out around liberty that nova was initializing repeatedly. | 16:50 |
| geguileo | dansmith: it's wrong because Cinder never specified that initialize_connection should be idempotent :-( | 16:50 |
| *** itlinux has joined #openstack-nova | 16:50 | |
| jgriffith | ummm..... | 16:50 |
| mriedem | smcginnis: yeah we do it all the time during migrations because we only have one copy of the connection_info at any time with the old flow | 16:50 |
| mriedem | so the only copy of the connection_info is in the nova bdm table, and it's host-specific | 16:51 |
| mriedem | on which was the last host to update it | 16:51 |
| *** diga has joined #openstack-nova | 16:51 | |
| mriedem | with the new flow, that's all stored in cinder per-host attachment | 16:51 |
| mriedem | so nova doesn't have to care | 16:51 |
| jgriffith | initialize_connection has never been designed as an idempotent thing, in fact it was intentionally abused for that very reason | 16:51 |
| geguileo | mriedem: but if Nova is the source of truth it shouldn't overwrite their data | 16:51 |
| geguileo | for old API I mean | 16:52 |
| mriedem | geguileo: cinder is the source of truth when it comes to volume informatoin imo | 16:52 |
| mriedem | but, | 16:52 |
| geguileo | mriedem: not for attach information on the old API | 16:52 |
| mriedem | if 'source of truth' means, when you disconnect a volume, regardless of host, you need to use the exact same connection_info as you used when you connected it, | 16:52 |
| mriedem | then yes nova needs to track that for the old flow | 16:52 |
| geguileo | yup, that's what I meant by 'source of truth' | 16:53 |
| mriedem | it's just a surprise to me that after all these years it's a new problem | 16:53 |
| dansmith | mriedem: with one (known) driver, remember | 16:53 |
| smcginnis | mriedem: Why is this a new problem? | 16:53 |
| jgriffith | mriedem: so the trick is that early drivers (and a large percentage) don't care here | 16:53 |
| mriedem | and, as i said to dan earlier here, "i wouldn't be surprised if at some later date, someone reports a bug saying something in the storage backend or source host changed and they actually need to get the latest information to disconnect" | 16:53 |
| *** gjayavelu has joined #openstack-nova | 16:53 | |
| smcginnis | I thought we mostly had fixed all instances we identified when we realized the call was being used this way. | 16:54 |
| jgriffith | mriedem: they don't have any interaction with the initiator or it's settings, that's just been extra *data* | 16:54 |
| dansmith | smcginnis: all but one, which was recently fixed: | 16:54 |
| dansmith | https://review.openstack.org/#/c/552933/ | 16:54 |
| jgriffith | but now with new fangled iSCSI stuff and LIO drivers that's not the case any more | 16:54 |
| geguileo | mriedem: the big problem here is not as much the data you pass to disconnect to Cinder, it's what you pass to os-brick | 16:54 |
| mriedem | geguileo: yeah i realize | 16:54 |
| mriedem | detach api in cinder is just flipping the volume status in the db | 16:55 |
| mriedem | so another question in that regard, | 16:55 |
| mriedem | we use a host connector with the original initialize_connection call, | 16:55 |
| mriedem | and we pass a host connector to terminate_connection, | 16:55 |
| mriedem | do those host connectors have to be the same? | 16:55 |
| jgriffith | mriedem: but terminate con has implications for some devices, that's the part that matters (which is what I think you're saying right now) | 16:55 |
| mriedem | nova just gets the host connector from os-brick on the fly | 16:56 |
| mriedem | except in some weird edge cases like when the source compute is down (evacuate) | 16:56 |
| geguileo | mriedem: For the RBD driver (which is the one I primarily touch) it doesn't matter, but I don't know about other drivers | 16:56 |
| geguileo | in theory it should not matter | 16:57 |
| jgriffith | mriedem: for some drivers it matters, they modify and access entry for the initiator iqn | 16:57 |
| mriedem | ok. i'm alright with us being told that we shouldn't assume initialize_connection is idempotent and we should use the same connection_info to disconnect the volume as was used to connect the volume | 16:57 |
| jgriffith | mriedem: and they get that from the connector | 16:57 |
| geguileo | as long as you haven't changed the initiator name or something crazy like that (I've seen bugs around this) | 16:57 |
| mriedem | i just don't want to find out later that someone relied on us always getting the latest info | 16:58 |
| jgriffith | mriedem: +1 for NOT assuming idempotency, AND +2 for suggesting upgrades and using the new API's instead :) | 16:58 |
| mriedem | with the new flow, we don't get the latest info anyway, it's all stored in cinder and we just re-use it | 16:58 |
| dansmith | mriedem: "much later" we expect to always be using the new API that doesn't suffer from this right? | 16:58 |
| mriedem | dansmith: yeah | 16:58 |
| jgriffith | of course, assumign we're not broken in there as well somewhere | 16:58 |
| mriedem | any existing attached volumes would have the old flow stuff until they get migrated | 16:59 |
| jgriffith | because I think we may be now in our efforts to emulate the old behavior | 16:59 |
| mriedem | which now this makes me paranoid about https://review.openstack.org/#/c/549130/ | 16:59 |
| melwitt | gibi: are you able to run the nova meeting tomorrow? | 16:59 |
| mriedem | jgriffith: this is the problematic code https://github.com/openstack/nova/blob/2ec8c49f6cb4a0e7dba217e824c20d9c703d2105/nova/virt/libvirt/driver.py#L7743 | 17:00 |
| mriedem | that runs on the source host post-live migration | 17:00 |
| gibi | melwitt: yes I can run it | 17:00 |
| mriedem | for the new flow, we just get the connection_info out of the attachment record | 17:00 |
| melwitt | gibi: cool, ty for confirming | 17:00 |
| jgriffith | ahh, yeah | 17:00 |
| mriedem | so the old flow thing there to call init_connectoin was a workaroudn | 17:01 |
| gibi | melwitt: will you update the agenda or shall I do it? | 17:01 |
| mriedem | b/c at this point in the flow, in the nova db, the bdm.connection_info is actually for the dest host | 17:01 |
| melwitt | gibi: I'll update the agenda | 17:01 |
| gibi | melwitt: OK, thanks | 17:02 |
| jgriffith | mriedem: yeah, I get ya | 17:02 |
| mriedem | ok so to summarize, i think i'm hearing the majority of the cinder peeps in here saying doing https://github.com/openstack/nova/blob/2ec8c49f6cb4a0e7dba217e824c20d9c703d2105/nova/virt/libvirt/driver.py#L7749 is a bad workaround and only works for some drivers b/c we're getting lucky | 17:02 |
| melwitt | gibi: no, thank YOU :) | 17:03 |
| mriedem | even though we've always done it....but anyway | 17:03 |
| *** bradjones has quit IRC | 17:03 | |
| dansmith | mriedem: well, we've always done it which ended up in them changing a bunch of drivers to tolerate it | 17:03 |
| *** udesale has quit IRC | 17:03 | |
| mriedem | sure, good point | 17:03 |
| mriedem | it's a fun incestual relationship | 17:03 |
| geguileo | rofl | 17:03 |
| dansmith | really? I don't enjoy any of it :) | 17:04 |
| dansmith | but you're into some weird shit, granted | 17:04 |
| mriedem | jgriffith: btw, we should remember to talk about this in vancouver about why the new flow is much better.... | 17:04 |
| jgriffith | mriedem: +1 | 17:04 |
| mriedem | alright i'll move onto reviewing the nova patch then, thanks geguileo jgriffith smcginnis | 17:04 |
| geguileo | no problem, and thanks for fixing that :-) | 17:05 |
| *** geguileo has left #openstack-nova | 17:05 | |
| jgriffith | mriedem: just for the record one more time and to hope it sticks in peoples heads... "Never update/modify and attachment, just delete it and create a new one" | 17:05 |
| jgriffith | That way you still have the ability to access the old data if you need it and nothing gets funky behind your back | 17:06 |
| jgriffith | hmmm... well, anyway | 17:06 |
| jgriffith | "funky behind your back" isn't the best phrase I guess | 17:06 |
| mriedem | because that would be like calling initialize_connection again | 17:06 |
| jgriffith | mriedem: exact-u-mundo | 17:06 |
| *** danpawlik has joined #openstack-nova | 17:06 | |
| *** felipemonteiro__ has quit IRC | 17:11 | |
| *** danpawlik has quit IRC | 17:11 | |
| *** felipemonteiro__ has joined #openstack-nova | 17:11 | |
| dansmith | mdbooth: did you follow all that ^ ? | 17:11 |
| *** gjayavelu has quit IRC | 17:12 | |
| mriedem | i put the link into the bug for the irc log and a summary | 17:13 |
| dansmith | cool | 17:13 |
| *** sahid has quit IRC | 17:13 | |
| mriedem | while we're on the topic https://review.openstack.org/#/c/549130/2/nova/compute/manager.py@616 | 17:14 |
| mriedem | in case any cinder people are still here and can direct me | 17:14 |
| *** elmaciej_ has quit IRC | 17:16 | |
| dansmith | mriedem: btw, I changed this to fixes and left a snarky remark: https://review.openstack.org/#/c/554600/ | 17:16 |
| dansmith | if you say that's good I'll fix the pike backport | 17:16 |
| dansmith | mriedem: melwitt: tssurya: do we need to have a cells meeting today? I know there are a bunch of tssurya's patches to review, but other than that, I don't know of anything else burning that justifies it | 17:18 |
| tssurya | dansmith: not needed | 17:19 |
| dansmith | tssurya: especially if it means I spend the time reviewing your stuff yeah? :) | 17:19 |
| tssurya | yeaaaaa :D | 17:19 |
| *** danpawlik has joined #openstack-nova | 17:20 | |
| melwitt | +1 to skipping today | 17:20 |
| cdent | the whole day | 17:20 |
| dansmith | woot, even if mriedem really wants a meeting, he's outnumbered | 17:20 |
| ildikov | jgriffith: you need to repeat those that thousands of times so they stick in people's heads :) | 17:21 |
| cfriesen | tssurya: you pinged earlier? | 17:22 |
| *** danpawlik has quit IRC | 17:25 | |
| mriedem | ildikov: or push a patch to nova to add something to the docstring for the attachment_update method so we don't forget | 17:25 |
| mriedem | i'd +2 that | 17:25 |
| ildikov | mriedem: I can when I'm off booth duty and got to the next hotel today | 17:26 |
| mriedem | dansmith: we've changed 'features' to 'fixes' in release notes in backports for other nova-manage changes for optional things, in order to fix bugs, so i think that's fine | 17:26 |
| tssurya | cfriesen: yea just to ask about the third point in the bug description, since you explicitly stated delete service/compute node, I wanted to just confirm we are still doing a soft delete | 17:27 |
| tssurya | cfriesen: saw you review btw, will change it to cascade, working on some tests and then will update the patch | 17:27 |
| ildikov | mriedem: It won't replace the need of repeating the phrase a thousand times everywhere else | 17:27 |
| cfriesen | tssurya: I think the service/node portion can remain as it is currently. what you have looks reasonable to me with the cascade change | 17:28 |
| tssurya | cfriesen: ack, however I think maybe we need to provide a new command at some point to allow compute node deletions ? like we have osc placement allowing resource provider deletions ? | 17:29 |
| cfriesen | tssurya: dansmith is the go-to guy in this area. :) | 17:29 |
| cfriesen | tssurya: you mean compute node deletions without service deletion? | 17:30 |
| dansmith | mriedem: fine, fine | 17:30 |
| tssurya | cfriesen: yes he is, he just promised he will review ^^ ;) | 17:30 |
| tssurya | cfriesen: yes | 17:30 |
| sean-k-mooney | mriedem: just looked at https://review.openstack.org/#/c/554917 and yes i think that is fine for stable/queens | 17:31 |
| tssurya | I mean deletion of cn, along with its dependencies | 17:31 |
| *** lucasagomes is now known as lucas-afk | 17:31 | |
| tssurya | the record as such does not get removed right ? | 17:32 |
| tssurya | or I don't know when its moved to shadow tables | 17:32 |
| *** lpetrut_ has quit IRC | 17:32 | |
| dansmith | in the nova database, | 17:34 |
| dansmith | deleting a thing marks it as deleted (deleted=row['id']) | 17:34 |
| mdbooth | dansmith: Thanks for the ping, caught up. | 17:34 |
| dansmith | "nova-manage db archive-deleted rows" moves it to shadow tables | 17:34 |
| dansmith | "nova-manage db purge" removes it from shadow tables | 17:34 |
| dansmith | tssurya: ^ | 17:34 |
| dansmith | mdbooth: ack, I assume we're to expect a review from mriedem forthwith | 17:34 |
| *** moshele has joined #openstack-nova | 17:34 | |
| * dansmith checks his use of forthwith on google | 17:34 | |
| tssurya | ah yes was just checking this, I don't know why for some reason I though only the instance* tables were archived | 17:34 |
| mdbooth | dansmith: Fortunately the above is consistent with my understanding having spoken to Gorka the other week. | 17:35 |
| dansmith | \o/ | 17:35 |
| * mdbooth wipes his brow | 17:35 | |
| dansmith | mdbooth: ack, that's good :) | 17:35 |
| mdbooth | dansmith: Heh, I do that, except I tend to google first :) | 17:35 |
| dansmith | mdbooth: this is 'merica.. fire from the hip and ask questions later | 17:35 |
| cfriesen | tssurya: under what scenario would we want to delete only a compute node and not a service? | 17:35 |
| dansmith | cfriesen: ironic nodes outnumber the service(s) they're owned by | 17:36 |
| dansmith | cfriesen: and, ironic nodes balance between services, and could potentially be orphaned | 17:36 |
| tssurya | cfriesen: nope, I was talking about the delete records in the compute node table | 17:36 |
| dansmith | cfriesen: I would guess maybe the same could happen if you change the hostname on a virt host | 17:36 |
| tssurya | but that is done by archive_deleted_rows | 17:36 |
| tssurya | already so taken care of :) | 17:36 |
| tssurya | sorry for the confusion | 17:37 |
| mdbooth | mriedem: Incidentally lyarwood pointed out that we're not running volume tests in the live migration job by default, so on his suggestion I hacked a run based on another patch he pointed me at. Link is in a review comment. | 17:37 |
| *** jmlowe has quit IRC | 17:37 | |
| *** NobodyCam has quit IRC | 17:37 | |
| *** r-daneel has quit IRC | 17:37 | |
| *** r-daneel has joined #openstack-nova | 17:37 | |
| *** toan has quit IRC | 17:37 | |
| *** icey has quit IRC | 17:37 | |
| *** Hazelesque has quit IRC | 17:38 | |
| *** gus has quit IRC | 17:38 | |
| *** Hazelesque has joined #openstack-nova | 17:38 | |
| *** gmann_ has quit IRC | 17:38 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Update spec to reflect reality https://review.openstack.org/555000 | 17:38 |
| *** andreaf has quit IRC | 17:39 | |
| *** NobodyCam has joined #openstack-nova | 17:39 | |
| *** gus has joined #openstack-nova | 17:39 | |
| *** andreaf_ has joined #openstack-nova | 17:39 | |
| stephenfin | jaypipes, gibi: Could you stick this on your review queue. Just ensure the spec for a Queens feature matches the actual implementation https://review.openstack.org/555000 | 17:39 |
| stephenfin | *? | 17:39 |
| *** felipemonteiro_ has joined #openstack-nova | 17:40 | |
| *** gmann_ has joined #openstack-nova | 17:40 | |
| *** icey has joined #openstack-nova | 17:40 | |
| *** danpawlik has joined #openstack-nova | 17:40 | |
| sean-k-mooney | stephenfin: is that the pci numa policy stuff? | 17:40 |
| *** toan has joined #openstack-nova | 17:41 | |
| sean-k-mooney | stephenfin: i taught we did not want to put the policy in the alias? | 17:41 |
| *** sridharg has quit IRC | 17:41 | |
| *** moshele has quit IRC | 17:41 | |
| *** andreaf_ is now known as andreaf | 17:41 | |
| *** felipemonteiro__ has quit IRC | 17:41 | |
| sean-k-mooney | stephenfin: hum well its in the code here https://github.com/openstack/nova/blob/master/nova/pci/request.py#L90-L92 so i guess we did | 17:43 |
| cfriesen | sean-k-mooney: ah, but we did...that way you can be flexible for one device and strict for another | 17:43 |
| openstackgerrit | Dan Smith proposed openstack/nova stable/pike: Add --by-service to discover_hosts https://review.openstack.org/554603 | 17:43 |
| sean-k-mooney | cfriesen: yes i see that i guess it works but eventually i would hope we can get this kind of stuff out of configs and into openstack server create --device vendor-id=xyz ... | 17:45 |
| *** cdent has quit IRC | 17:45 | |
| *** suresh12 has joined #openstack-nova | 17:45 | |
| *** danpawlik has quit IRC | 17:45 | |
| sean-k-mooney | cfriesen: with cyborg becoming a thing that seams like the correct route long term | 17:45 |
| cfriesen | sean-k-mooney: I'd be fine with that, but it might affect the instance packing (which dansmith has smacked me with before) | 17:46 |
| sean-k-mooney | instance packing? | 17:46 |
| sean-k-mooney | in placement | 17:46 |
| cfriesen | defining flavors to pack instances neatly onto a compute node with minimal waste | 17:46 |
| *** oomichi has joined #openstack-nova | 17:46 | |
| *** mdbooth has quit IRC | 17:46 | |
| *** Drankis has joined #openstack-nova | 17:47 | |
| dansmith | cfriesen: I don't believe I smacked you, I just made a big farting noise and gave it a thumbs down | 17:47 |
| dansmith | you know, to be respectfyul | 17:47 |
| sean-k-mooney | cfriesen: ah ok. well currently passh through devices are not first class resouces. if they are it changes the usage model and billing model | 17:47 |
| *** gjayavelu has joined #openstack-nova | 17:47 | |
| sean-k-mooney | but ya in any case having the numa policy in the alias kind of works but its not discoverable by the tenant so it wont work for everyone. espcilally the people that dont like setting things in the nova conf | 17:49 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add periodic task to clean expired console tokens https://review.openstack.org/325381 | 17:50 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use ConsoleAuthToken object to generate authorizations https://review.openstack.org/325414 | 17:50 |
| openstackgerrit | melanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation https://review.openstack.org/333990 | 17:50 |
| cfriesen | sean-k-mooney: are you proposing that we add an HTTP API for PCI aliases? | 17:51 |
| sean-k-mooney | cfriesen: well no i dont think we should keep adding features to the aliases but maybe in the flavour details show some of the alais fields | 17:53 |
| sean-k-mooney | cfriesen: long term however i would much prefer this handeled with resouce requests and traits in the flavor then using aliases | 17:53 |
| sean-k-mooney | cfriesen: the mater of how that resource request gets there(set by admin directly or via boot option e.g. --device) is a seperate disction | 17:55 |
| sean-k-mooney | /disction/topic/ | 17:55 |
| sean-k-mooney | cfriesen: these https://github.com/openstack/nova/blob/master/nova/pci/request.py#L74-L89 can all be modeled as traits on the RP in placement and the numa_policy can be modeled as a flavor extra spec key that is consumed by the numa_topology/pci passhtrough filters. | 17:58 |
| *** derekh has quit IRC | 18:00 | |
| *** sambetts is now known as sambetts|afk | 18:00 | |
| *** diga has quit IRC | 18:02 | |
| *** felipemonteiro__ has joined #openstack-nova | 18:02 | |
| *** AlexeyAbashkin has joined #openstack-nova | 18:03 | |
| openstackgerrit | Mark Goddard proposed openstack/nova master: Request only instance_uuid in ironic node list https://review.openstack.org/539509 | 18:04 |
| *** felipemonteiro_ has quit IRC | 18:06 | |
| *** danpawlik has joined #openstack-nova | 18:12 | |
| *** jpena is now known as jpena|off | 18:14 | |
| *** jmlowe has joined #openstack-nova | 18:15 | |
| *** dtantsur is now known as dtantsur|afk | 18:15 | |
| *** danpawlik has quit IRC | 18:17 | |
| cfriesen | once nova-compute spawns a privsep daemon, does it stay running after that? | 18:18 |
| *** tidwellr has quit IRC | 18:19 | |
| *** tidwellr has joined #openstack-nova | 18:19 | |
| *** ircuser-1 has quit IRC | 18:20 | |
| *** lpetrut has joined #openstack-nova | 18:20 | |
| sean-k-mooney | cfriesen: yes and a seperate priv sep deamon is spawned for each context | 18:21 |
| *** AlexeyAbashkin has quit IRC | 18:21 | |
| *** EmilienM is now known as mimi | 18:21 | |
| *** mimi is now known as EmilienM | 18:21 | |
| sean-k-mooney | cfriesen: so if you have two contexts with 2 different permission sets you will have 2 privsep deamons running for nova-compute | 18:22 |
| sean-k-mooney | when nova compute exits the deamons also exits when the unix socket gets closed | 18:22 |
| *** harlowja has joined #openstack-nova | 18:24 | |
| melwitt | dansmith: patch for removing the useless non-periodic task line has acks from efried_rollin and gibi https://review.openstack.org/#/c/554381 | 18:26 |
| dansmith | melwitt: ah yeah thanks for the reminder | 18:27 |
| dansmith | melwitt: so confirmed what I was saying about that test yeah? | 18:27 |
| melwitt | yes, I tried it out and indeed it was only covering that one line : | 18:27 |
| dansmith | melwitt: and I also wonder if that was the only source of the overwriting-context problem initially | 18:27 |
| melwitt | :\ | 18:27 |
| dansmith | ack | 18:27 |
| *** amodi has quit IRC | 18:27 | |
| melwitt | yeah, I think it was -_- | 18:27 |
| *** jmlowe has quit IRC | 18:36 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Snapshot https://review.openstack.org/543023 | 18:38 |
| edmondsw | https://review.openstack.org/#/c/547169/ should be a quick review if someone has a few minutes | 18:40 |
| edmondsw | prereq to starting to flip some of those capabilities to True as we introduce functions in later commits | 18:40 |
| cfriesen | sean-k-mooney: cool, thanks | 18:42 |
| *** tssurya has quit IRC | 18:42 | |
| *** yamamoto has quit IRC | 18:43 | |
| *** andreas_s has joined #openstack-nova | 18:45 | |
| mriedem | dansmith: commented on mdbooth's change https://review.openstack.org/#/c/551302/ | 18:46 |
| mriedem | dansmith: overall it's ok, but i think we also have a problem in rollback | 18:46 |
| *** jmlowe has joined #openstack-nova | 18:46 | |
| dansmith | mriedem: cool thanks | 18:48 |
| *** Swami has joined #openstack-nova | 18:48 | |
| *** ralonsoh has quit IRC | 18:49 | |
| *** andreas_s has quit IRC | 18:50 | |
| *** lpetrut has quit IRC | 18:51 | |
| *** danpawlik has joined #openstack-nova | 18:52 | |
| *** fragatina has quit IRC | 18:53 | |
| mriedem | i looked at his live migration test patch that enabled the volume-backed live migration tests, | 18:53 |
| mriedem | the grenade live migration job passed, which uses mixed computes | 18:54 |
| mriedem | and goes back and forth (rocky->queens->rocky) | 18:54 |
| mriedem | and vice-versa | 18:54 |
| mriedem | the other non-grenade live migration job failed, looks like all rpc messaging timeouts | 18:54 |
| *** danpawlik has quit IRC | 18:56 | |
| mriedem | huh, same thing in melwitt's patch to enable the volume-backed live migratoin tests http://logs.openstack.org/04/528104/6/check/legacy-tempest-dsvm-multinode-live-migration/ff90ecb/logs/subnode-2/screen-n-cpu.txt.gz?level=TRACE | 18:57 |
| mriedem | i wonder if there is just something about doing a volume-backed live migration that takes that much longer such that pre_live_migration rpc call times out | 18:57 |
| *** jmlowe has quit IRC | 18:57 | |
| melwitt | yeah, I had been rechecking the patch periodically but it never passed reliably upon multiple rechecks | 18:58 |
| mriedem | i'm seeing the same rpc timeouts in your patch and https://review.openstack.org/#/c/553377/ | 18:58 |
| mriedem | which depends on your patch | 18:58 |
| melwitt | yeah | 18:58 |
| melwitt | I just mean I had been checking on it to see if we were going to be able to re-enable those tests but it wasn't panning out. will try depending on your queens uca patch | 18:59 |
| mriedem | you could try setting the rpc timeout to 120 in nova-cpu.conf in the job config and see if that makes a difference | 18:59 |
| mriedem | i don't think libvirt is the problem here | 18:59 |
| melwitt | okay, will do that instead | 18:59 |
| *** mgoddard has quit IRC | 19:00 | |
| *** lpetrut has joined #openstack-nova | 19:00 | |
| mriedem | this is how you do something like that https://review.openstack.org/#/c/549789/9/playbooks/legacy/nova-cells-v1/run.yaml@38 | 19:00 |
| mriedem | except you'll use $NOVA_CPU_CONF | 19:00 |
| mriedem | oh, but, | 19:01 |
| mriedem | first you need to move the live migratoin job defs in tree | 19:01 |
| mriedem | something i've been thinking about doing anyway | 19:01 |
| melwitt | hm, okay. (on a call atm) | 19:02 |
| dansmith | or I could finish my live heartbeating thing in oslo.messaging | 19:04 |
| *** sidx64 has joined #openstack-nova | 19:05 | |
| *** brault has joined #openstack-nova | 19:05 | |
| *** jmlowe has joined #openstack-nova | 19:06 | |
| *** brault_ has quit IRC | 19:07 | |
| mriedem | or you could take this over https://review.openstack.org/#/c/452546/ | 19:09 |
| *** mvk has quit IRC | 19:09 | |
| mriedem | like you PROMISED at the PTG | 19:10 |
| dansmith | um, wut? | 19:10 |
| dansmith | I thought you said you were going to do that? | 19:11 |
| mriedem | oh on | 19:11 |
| mriedem | *no | 19:11 |
| mriedem | i said i had tried at one point and was shot down | 19:11 |
| mriedem | and was welcome to others getting shot | 19:11 |
| mriedem | btw i think the cellsv1 + neutron job is ready to go https://review.openstack.org/#/c/549789/ | 19:12 |
| mriedem | i can't drop the old cells v1 job from master until that flushes through | 19:12 |
| *** READ10 has quit IRC | 19:13 | |
| *** felipemonteiro__ has quit IRC | 19:13 | |
| *** felipemonteiro__ has joined #openstack-nova | 19:13 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class https://review.openstack.org/549053 | 19:14 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: WIP: PowerVM Driver: Localdisk https://review.openstack.org/549300 | 19:14 |
| dansmith | mriedem: that's a long ways from "promised" :) | 19:14 |
| mriedem | i know, i was hoping the caps would convey the joke | 19:15 |
| mriedem | like, "omfg there was pug shit EVERYWHERE!" | 19:15 |
| dansmith | mriedem: so this patch's cells job came from the in-tree version https://review.openstack.org/#/c/549780/2 ? | 19:16 |
| dansmith | ah, I guess there are two on there | 19:16 |
| *** sidx64 has quit IRC | 19:17 | |
| *** AlexeyAbashkin has joined #openstack-nova | 19:17 | |
| *** suresh12 has quit IRC | 19:18 | |
| dansmith | mriedem: your job's cells-child log has a little extra red in it from the base job: http://logs.openstack.org/80/549780/2/check/nova-cells-v1/66d336e/logs/screen-n-cell-child.txt.gz?level=TRACE | 19:18 |
| dansmith | although that looks vaguely familiar, so maybe not a problem | 19:18 |
| *** suresh12 has joined #openstack-nova | 19:18 | |
| mriedem | i've seen those before | 19:18 |
| mriedem | race in the metadata updates | 19:19 |
| dansmith | okay | 19:19 |
| mriedem | so yeah what i did was move the existing job in-tree | 19:19 |
| *** tidwellr has quit IRC | 19:19 | |
| mriedem | and renamed it | 19:19 |
| mriedem | b/c that's what we do when we move them in tree, | 19:19 |
| *** tidwellr has joined #openstack-nova | 19:19 | |
| mriedem | and then tweaked it to be the new thing with neutron | 19:19 |
| dansmith | so after we merge that first one, we can remove the base job from infra, right? | 19:20 |
| mriedem | in https://review.openstack.org/#/c/549789/ we are getting both jobs b/c at this point the legacy job is still in openstack-zuul-jobs | 19:20 |
| mriedem | yeah i have all of thoes patches lined up | 19:20 |
| mriedem | https://review.openstack.org/#/q/topic:bp/remove-nova-network+(status:open+OR+status:merged) | 19:20 |
| *** amodi has joined #openstack-nova | 19:21 | |
| *** AlexeyAbashkin has quit IRC | 19:21 | |
| *** suresh12 has quit IRC | 19:22 | |
| *** jaosorior has quit IRC | 19:23 | |
| dansmith | mriedem: cool, +2 on the bottom two | 19:24 |
| dansmith | melwitt: ^ | 19:24 |
| *** eharney has quit IRC | 19:26 | |
| *** sree has joined #openstack-nova | 19:26 | |
| *** mgoddard has joined #openstack-nova | 19:27 | |
| *** eharney has joined #openstack-nova | 19:28 | |
| *** danpawlik has joined #openstack-nova | 19:28 | |
| *** suresh12 has joined #openstack-nova | 19:29 | |
| *** sree has quit IRC | 19:31 | |
| *** danpawlik has quit IRC | 19:33 | |
| *** salv-orlando has quit IRC | 19:34 | |
| *** liverpooler has quit IRC | 19:34 | |
| *** salv-orlando has joined #openstack-nova | 19:35 | |
| *** sidx64 has joined #openstack-nova | 19:37 | |
| *** efried_rollin is now known as efried | 19:37 | |
| *** tesseract has quit IRC | 19:38 | |
| *** salv-orlando has quit IRC | 19:38 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Preserve multiattach flag when refreshing connection_info https://review.openstack.org/555029 | 19:44 |
| *** jaosorior has joined #openstack-nova | 19:44 | |
| openstackgerrit | Matt Riedemann proposed openstack/os-vif stable/pike: ovs: do not delete port if already exists https://review.openstack.org/550080 | 19:44 |
| *** yamamoto has joined #openstack-nova | 19:44 | |
| *** salv-orlando has joined #openstack-nova | 19:44 | |
| *** kuzko_ has quit IRC | 19:46 | |
| *** yamamoto has quit IRC | 19:49 | |
| *** sidx64_ has joined #openstack-nova | 19:53 | |
| mriedem | dansmith: i skimmed the review comments on https://review.openstack.org/#/c/452546/ again and there were some todos that came out of that as prereqs, one of which was tagged attach which we've had since pike. there was another about returning bdm tags out of the volume attachments API. i had a separate spec for that which got held up in committee because of local disk tags and also exposing vifs tags in GET requests but which | 19:53 |
| mriedem | to do that from. | 19:53 |
| mriedem | one thing that could move it forward was just remove device_name from the volume attach API (not bfv), because that doesn't have the sneaky ec2 thing that ftersin was -1ing this for | 19:54 |
| *** sidx64 has quit IRC | 19:55 | |
| dansmith | mriedem: ah, that seems like incremental improvement and probably the 90% case where people attach a volume and expect it to go in a certain place | 19:55 |
| *** moshele has joined #openstack-nova | 19:55 | |
| mriedem | the device name is also presumably for correlating on the guest right? | 19:57 |
| mriedem | i know this volume has something in it that my app needs, so i'll attach it at vdc and my guest will expect it to be at vdc | 19:57 |
| dansmith | yeah | 19:57 |
| dansmith | it's the only use for it | 19:57 |
| *** eharney has quit IRC | 19:57 | |
| mriedem | so i think what i'd propose, if i were to redo this, is (1) drop device_name from attach volume API, (2) return tags in GET calls to the os-volume_attachments and os-interface APIs | 19:59 |
| *** sidx64 has joined #openstack-nova | 19:59 | |
| mriedem | and then cross my fingers that john, booth, feodor and artom don't show up to review the spec | 19:59 |
| *** ekhugen has quit IRC | 19:59 | |
| *** egarbade has quit IRC | 19:59 | |
| dansmith | and take tags in volume/interface attach? | 19:59 |
| dansmith | or do we already have that? | 20:00 |
| mriedem | we've had that since pike | 20:00 |
| mriedem | that was one of the pre-reqs for this other removal spec | 20:00 |
| dansmith | on both interface and volume? but not sriov or something? | 20:00 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Network interface attach/detach https://review.openstack.org/546813 | 20:00 |
| mriedem | same | 20:00 |
| mriedem | sriov ports are attached the same way | 20:00 |
| mriedem | they have to be pre-created in neutron is all with the special binding profile i think | 20:00 |
| *** sidx64_ has quit IRC | 20:00 | |
| dansmith | I thought there was some way to attach something where we were still missing tag function | 20:01 |
| mriedem | or are you referring to the bug that artom was trying to fix | 20:01 |
| mriedem | https://review.openstack.org/#/c/533805/ ? | 20:01 |
| dansmith | anyway, yes, I think making those three changes together makes sense. I need to refresh on the bfv/ec2 issue I guess, | 20:01 |
| *** danpawlik has joined #openstack-nova | 20:01 | |
| dansmith | because that doesn't sound like a great reason to remove it from bfv either but.. | 20:01 |
| dansmith | to nop | 20:02 |
| dansmith | not | 20:02 |
| mriedem | yeah, i said the same to ftersin basically, it is completely undocumented and untested behavior | 20:02 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver https://review.openstack.org/526094 | 20:03 |
| *** egarbade has joined #openstack-nova | 20:03 | |
| *** ekhugen has joined #openstack-nova | 20:03 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Snapshot https://review.openstack.org/543023 | 20:04 |
| artom | mriedem, I thought we matches volume tags based on device name? | 20:04 |
| artom | *matched | 20:04 |
| dansmith | mriedem: if we remove it, it prevents them from using the boot call past that microversion forever I guess? | 20:05 |
| *** tssurya has joined #openstack-nova | 20:05 | |
| dansmith | mriedem: I guess I don't see why a tag on bfv won't work the same for them, | 20:05 |
| mriedem | dansmith: if we removed device_name from the bdm object in server create, yeah. | 20:05 |
| dansmith | but I also don't really understand the exchange between you two either | 20:05 |
| dansmith | I think there's ML context probably | 20:05 |
| mriedem | ftersin pointed out some stuff about image-defined BDMs don't have tags | 20:05 |
| mriedem | it's in the spec review | 20:06 |
| mriedem | artom: not sure | 20:06 |
| *** moshele has quit IRC | 20:06 | |
| mriedem | you wrote that code :) | 20:06 |
| artom | mriedem, I have the memory of a goldfish | 20:06 |
| dansmith | oh, image-defined I see.. either way, those device names don't get honored any more than the volume-attach ones, so I don't see what that matters | 20:06 |
| *** danpawlik has quit IRC | 20:06 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class https://review.openstack.org/549053 | 20:06 |
| artom | mriedem, yeah, we do: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L8570 | 20:07 |
| *** suresh12 has quit IRC | 20:07 | |
| artom | But... where does that device name come from? | 20:07 |
| mriedem | oh i guess there was some ML stuff http://lists.openstack.org/pipermail/openstack-dev/2017-April/114858.html | 20:07 |
| mriedem | artom: i think nova.virt.libvirt.blockinfo.py | 20:07 |
| artom | mriedem, is that the one the user gives in the boot request? | 20:08 |
| artom | Or attach request, whatever | 20:08 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L8703 | 20:08 |
| mriedem | no, | 20:08 |
| mriedem | the libvirt driver completely ignores what the user requested | 20:08 |
| mriedem | since liberty | 20:08 |
| mriedem | see ^ | 20:09 |
| mriedem | when you attach a volume, the api rpc calls the compute to create the bdm and get the device name from the driver | 20:09 |
| mriedem | assuming the stupid instance isn't shelved offload | 20:09 |
| dansmith | mriedem: yeah, from that thread I'm not sure why tags won't work | 20:09 |
| dansmith | oh, because the image properties | 20:10 |
| mriedem | yeah it's a different use case, | 20:10 |
| mriedem | i think the image has bdms in it, | 20:10 |
| mriedem | the user can override those, | 20:10 |
| mriedem | but the override relies on the device name as the primary key | 20:11 |
| dansmith | but .. if they're providing bdms, they're doing full override, or is it that they're doing override of individual bdms referenced by name? | 20:11 |
| mriedem | so you say, the image has vda/vdb/vdc and i don't like the image-defined vdc bdm, so i'm going to overwrite it | 20:11 |
| mriedem | the latter i think | 20:11 |
| dansmith | yeah, okay | 20:11 |
| dansmith | that seems like a really odd thing that we ever allowed | 20:11 |
| mriedem | heh, that's what i said | 20:11 |
| mriedem | "people do this?!" | 20:12 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: WIP: PowerVM Driver: Localdisk https://review.openstack.org/549300 | 20:12 |
| dansmith | like, it seems weird that you would expect to provide bdms, but get a union of the bdms on the image and the ones you provided, with some replacement | 20:12 |
| dansmith | mriedem: so since this is so obscure, | 20:12 |
| *** eharney has joined #openstack-nova | 20:13 | |
| dansmith | what if we just defined a pattern like volume-bdm-$devname and auto-tag BDMs from the image, and then you can use the tag on the bdm command line to override those? | 20:13 |
| dansmith | I mean, I know it's kinda secret sauce, but so is what we have today | 20:13 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: WIP: PowerVM Driver: Localdisk https://review.openstack.org/549300 | 20:13 |
| *** suresh12 has joined #openstack-nova | 20:13 | |
| dansmith | we could actually document it though going forward | 20:13 |
| mriedem | this is the merge-a-roo https://github.com/openstack/nova/blob/master/nova/compute/api.py#L670 | 20:13 |
| dansmith | and avoid the surprise later when we all forget gain | 20:13 |
| dansmith | that that suck-a-roo-s | 20:14 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: WIP: Resize https://review.openstack.org/553583 | 20:14 |
| dansmith | the ML thread made it sound like he was amenable to something else if you provided it | 20:15 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: WIP: Resize https://review.openstack.org/553583 | 20:15 |
| *** priteau has quit IRC | 20:15 | |
| dansmith | presumably the client (ec2api in this case) could also just get the properties from the image, and generate a fresh new set of BDMs that are the union of the two, if we convert over to not merging in some microversion | 20:15 |
| mriedem | yeah they'd have to do the full override client side | 20:17 |
| dansmith | yeah, and what's wrong with that? | 20:17 |
| dansmith | it'd suck for someone using novaclient, but not so much for ec2api using REST | 20:17 |
| *** suresh12 has quit IRC | 20:18 | |
| *** suresh12 has joined #openstack-nova | 20:18 | |
| dansmith | what does horizon do if you have an image with BDMs in it? does it properly show what your instance is going to look like pre-boot? | 20:18 |
| *** AlexeyAbashkin has joined #openstack-nova | 20:18 | |
| mriedem | not sure, don't have a devstack handy | 20:19 |
| mriedem | oh, but, i have a vexxhost handy :) | 20:20 |
| mriedem | also, if we stopped doing the merging in a new microversion that drops device name, the client has two options: use an older microversion for the server create request and hope they didn't need a newer microversion, or merge client side | 20:20 |
| mriedem | nvm i don't know if vexxhost has any images with BDMs in them | 20:21 |
| dansmith | mriedem: did you look or find any documentation that advertises this as a thing? | 20:21 |
| mriedem | https://docs.openstack.org/nova/pike/user/block-device-mapping.html#intermezzo-problem-with-device-names | 20:22 |
| mriedem | "Currently (mid Liberty) users are discouraged from specifying device names for all calls requiring or allowing block device mapping, except when trying to override the image block device mapping on instance boot, and it will likely remain like that in the future. " | 20:22 |
| *** AlexeyAbashkin has quit IRC | 20:22 | |
| *** suresh12 has quit IRC | 20:23 | |
| dansmith | hrm | 20:24 |
| *** mgoddard has quit IRC | 20:24 | |
| mriedem | that's about all i can find | 20:24 |
| mriedem | from that ML thread: http://lists.openstack.org/pipermail/openstack-dev/2017-April/114866.html | 20:24 |
| mriedem | this is also timely: "Well, i cannot estimate the importance in absolute measurement, but in comparison with OpenStack this use case is more important in AWS. Volume backed images (EBS images) are used in AWS much more widely than in OpenStack. There are some difficulties in Nova and Cinder because that users try to avoid using volume backed images in favor of disk based (instance-store) ones. This explain why this use case | 20:24 |
| mriedem | ess important for pure OpenStack users." | 20:24 |
| mriedem | i.e. bfv in openstack sucks ux-wise | 20:25 |
| *** gouthamr has quit IRC | 20:26 | |
| dansmith | yeah | 20:26 |
| mriedem | from what i can tell, we don't even have any direct tests for _merge_bdms_lists | 20:26 |
| dansmith | mriedem: well, I commented and summarized my feelings | 20:26 |
| dansmith | mriedem: heh, nice | 20:27 |
| dansmith | and no tempest test, | 20:27 |
| dansmith | which means it's not part of the are-you-openstack test right? | 20:27 |
| mriedem | interop, no | 20:31 |
| mriedem | most things aren't in interop though fwiw | 20:31 |
| dansmith | I know, I'm just poking | 20:31 |
| *** salv-orlando has quit IRC | 20:32 | |
| mriedem | alright i'll give myself a todo to re-spec-ify this | 20:32 |
| *** jaosorior_ has joined #openstack-nova | 20:33 | |
| *** danpawlik has joined #openstack-nova | 20:33 | |
| *** jaosorior has quit IRC | 20:37 | |
| *** suresh12 has joined #openstack-nova | 20:37 | |
| *** danpawlik has quit IRC | 20:38 | |
| *** amoralej is now known as amoralej|off | 20:43 | |
| *** yamamoto has joined #openstack-nova | 20:45 | |
| openstackgerrit | Julia Kreger proposed openstack/nova master: WIP: Add microversion to ironic client wrapper call https://review.openstack.org/554762 | 20:47 |
| melwitt | ran into something unexpected today, apparently when you specify a non-existent field when creating a nova object, it doesn't complain about it upon create(), it just silently never applies it https://github.com/openstack/nova/blob/master/nova/tests/functional/compute/test_instance_list.py#L69 | 20:49 |
| *** arvindn05 has left #openstack-nova | 20:50 | |
| *** yamamoto has quit IRC | 20:51 | |
| *** jmlowe has quit IRC | 20:56 | |
| *** suresh12 has quit IRC | 20:57 | |
| cfriesen | when we evacuate a boot-from-volume instance and it's starting up on the new compute node, would we expect the HTTP API calls to cinder to have the same "req-*" number as the evacuate in nova? | 20:58 |
| *** suresh12 has joined #openstack-nova | 20:59 | |
| *** esberglu has quit IRC | 21:01 | |
| *** tidwellr has quit IRC | 21:01 | |
| dansmith | melwitt: yeah, it's always been that non-field properties are free-form | 21:04 |
| dansmith | that's how we manage local caching of stuff, and some of the other things instance does, for example | 21:05 |
| dansmith | I found it surprising the first time someone else brought it up and was surprised by it :) | 21:05 |
| melwitt | yeah, I guess I haven't used the non-field properties too much. or I keep forgetting about them | 21:05 |
| sean-k-mooney[m] | melwitt: ya that has come up a few times | 21:06 |
| * melwitt is late to the party ... again | 21:06 | |
| *** fragatina has joined #openstack-nova | 21:06 | |
| *** danpawlik has joined #openstack-nova | 21:07 | |
| sean-k-mooney[m] | Eveyone finds it surprising as they expect ovo/nova objects to prevent python being python and allowing you to add attributes to objects when ever you feel like it | 21:07 |
| melwitt | I think it was the use of it in the init that threw me off. InstanceMapping(user_id=<id>) looked so official | 21:09 |
| *** moshele has joined #openstack-nova | 21:09 | |
| sean-k-mooney[m] | Hum it could still be a bug. Non fields are not serialised, the user id sounds like it should be persistent | 21:10 |
| *** eharney has quit IRC | 21:10 | |
| *** pchavva has quit IRC | 21:11 | |
| melwitt | yeah, I'm guessing the use wasn't intentional (it's just in a test) | 21:11 |
| melwitt | I'm trying to recreate a bug and been poking around these functional tests | 21:11 |
| *** bnemec is now known as sin-master | 21:12 | |
| *** sin-master is now known as bnemec | 21:12 | |
| *** danpawlik has quit IRC | 21:12 | |
| sean-k-mooney[m] | Thats always an interesting experience, your never sure what you will find | 21:13 |
| openstackgerrit | melanie witt proposed openstack/nova stable/pike: DNM: reproducing bug 1746509 https://review.openstack.org/555058 | 21:13 |
| openstack | bug 1722404 in OpenStack Compute (nova) ocata "duplicate for #1746509 Database transactions can fail with "TypeError: Can't upgrade a READER transaction to a WRITER mid-transaction" because of scatter_gather_cells" [Undecided,In progress] https://launchpad.net/bugs/1722404 - Assigned to Matt Riedemann (mriedem) | 21:13 |
| *** esberglu has joined #openstack-nova | 21:14 | |
| *** AlexeyAbashkin has joined #openstack-nova | 21:17 | |
| dansmith | melwitt: ah, I'd be fine restricting init to only things in fields, that makes plenty of sense to me | 21:18 |
| dansmith | melwitt: just not instance.does_not_exist = True | 21:19 |
| mriedem | ^ is definitely something that tripped me up with something in the nova-network API code that relies on setting things on an object which aren't in fields, and reads that attribute in the REST API | 21:19 |
| mriedem | can't remember which one specifically, but it was probably me that surprised dan about being surprised | 21:19 |
| dansmith | heh | 21:20 |
| mriedem | unrelated, but coincidental to the service / compute node delete and host discovery stuff lately https://bugs.launchpad.net/nova/+bug/1757207 | 21:20 |
| openstack | Launchpad bug 1757207 in OpenStack Compute (nova) "compute resource providers not equal to compute nodes in deployment" [Undecided,Incomplete] | 21:20 |
| sean-k-mooney[m] | dansmith: personally i think the best solution would be to add a mixin to ovo to all strict dield checks and then use it where it is correct to. | 21:21 |
| *** AlexeyAbashkin has quit IRC | 21:21 | |
| *** jmlowe has joined #openstack-nova | 21:21 | |
| sean-k-mooney[m] | *allow strict field checks | 21:22 |
| dansmith | sean-k-mooney[m]: it's just not a thing I care much about, but if it's a mixin, then that's better than changing the behavior of the base object | 21:22 |
| dansmith | they behave like any other python object right now, which seems more like I would expect | 21:22 |
| dansmith | it just only version-tracks the things in fields | 21:23 |
| dansmith | I agree we should only set things in init if they're in fields, and explode otherwise | 21:23 |
| *** awaugama has quit IRC | 21:24 | |
| sean-k-mooney[m] | Ya the current behavior has helped us break some circular depency too so the current behavior makes sense as the default. | 21:24 |
| tssurya | mriedem: the new bug is again the same thing right ? because a) RPs are not deleted and b)probably the compute service was not shut down before deleting ? so the compute_node record keeps getting recreated ? | 21:25 |
| mriedem | mikal: nice topic https://review.openstack.org/#/q/topic:bp/execs-ive-had-a-few+(status:open+OR+status:merged) | 21:25 |
| melwitt | dansmith: so it would be a mixin in ovo and then use the mixin only in the nova base object? just making sure I understand the best way to go about it | 21:25 |
| mriedem | tssurya: yes | 21:25 |
| tssurya | mriedem: just saw you updated the bug, cool | 21:26 |
| dansmith | melwitt: well you couldn't do it in the nova base object because we utilize the fact that we can set non-field properties on some of our objects | 21:26 |
| dansmith | melwitt: but you could mix it into certain objects if you want | 21:26 |
| dansmith | melwitt: the init fix though could go to the base object in o.vo I think | 21:27 |
| melwitt | I mean to restrict only when calling __init__ | 21:27 |
| melwitt | oh, I see | 21:27 |
| *** priteau has joined #openstack-nova | 21:27 | |
| dansmith | oh no, that can co straight to the core as far as I'm concerned | 21:27 |
| dansmith | although we might break some things by doing that, but they're broken now silently | 21:27 |
| melwitt | the setting of non-field properties hasn't confused me before, it's only the passing them in __init__ that has | 21:27 |
| melwitt | (for whatever that's worth :P) | 21:27 |
| dansmith | I guess some library types might want a warning instead of a failure in a minor/rev release or something | 21:27 |
| dansmith | melwitt: ah okay | 21:28 |
| mikal | mriedem: you're welcome | 21:28 |
| sean-k-mooney[m] | Melwitt probably 2 mixins. One for init check that could be in base nova object and one for all assignments that would not be in base nova object | 21:28 |
| dansmith | like, mark it as deprecated, warn and then fail later | 21:28 |
| dansmith | sean-k-mooney[m]: I dunno, we don't actually set the values from init if they're not in fields, do we? | 21:28 |
| dansmith | ah I guess we do | 21:29 |
| dansmith | well, I dunno, | 21:29 |
| dansmith | a warning initially would be totally fine on the base object IMHO | 21:29 |
| dansmith | and the make it required in a year on a version bump | 21:29 |
| sean-k-mooney[m] | Dansmith apparently in the tests mel found | 21:29 |
| dansmith | sean-k-mooney[m]: yeah, I just didn't think it was actually _setting_ it, but I see it is | 21:29 |
| *** sidx64 has quit IRC | 21:30 | |
| sean-k-mooney[m] | Yeah more warning in test output :) | 21:30 |
| dansmith | well, then we fix it :) | 21:30 |
| dansmith | we could do it in our nova object to pre-fix everything | 21:30 |
| melwitt | yeah, I'm not clear on if everyone would want to warn/fail if they call init with non-existent fields. maybe someone likes a shortcut like that | 21:31 |
| dansmith | *shrug* I guess | 21:31 |
| sean-k-mooney[m] | Ya im sure you could phase it in gradually | 21:31 |
| dansmith | it was my intent to allow free-form properties, not to allow anything in init(), that's my bias I guess :) | 21:32 |
| *** felipemonteiro_ has joined #openstack-nova | 21:32 | |
| melwitt | yeah, I had the same thinking too as a user of objects | 21:32 |
| *** salv-orlando has joined #openstack-nova | 21:32 | |
| sean-k-mooney[m] | Melwitt well if they ever call make compatible or serialise the object those non fields are lost so you still have to be careful with thwm or you will get weird bugs | 21:33 |
| melwitt | yeah. I agree it makes sense to make it more intentional when setting free-form properties, i.e. you have to do that outside of init | 21:34 |
| melwitt | being that those will be lost as you said in those situations | 21:34 |
| sean-k-mooney[m] | Yep. We don't really use the free form attributes that often but they can be useful sometimes | 21:35 |
| *** felipemonteiro__ has quit IRC | 21:35 | |
| *** salv-orlando has quit IRC | 21:38 | |
| *** jackie-truong has joined #openstack-nova | 21:42 | |
| openstackgerrit | Merged openstack/nova stable/pike: Handle volume-backed instances in IsolatedHostsFilter https://review.openstack.org/543603 | 21:42 |
| openstackgerrit | Merged openstack/nova stable/pike: Fix docs for IsolatedHostsFilter https://review.openstack.org/543604 | 21:42 |
| mriedem | so uh, | 21:42 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1755392 | 21:42 |
| openstack | Launchpad bug 1755392 in OpenStack Compute (nova) "resize the instance is fail" [Undecided,New] | 21:42 |
| openstackgerrit | Merged openstack/nova master: Remove useless run_periodic_tasks call in ClientRouter https://review.openstack.org/554381 | 21:42 |
| mriedem | i thought there was a thing where you couldn't resize/migrate ephemeral/swap disks? | 21:43 |
| mriedem | am i making that up? | 21:43 |
| *** danpawlik has joined #openstack-nova | 21:45 | |
| mriedem | similar https://bugs.launchpad.net/nova/+bug/1755266 | 21:45 |
| openstack | Launchpad bug 1755266 in OpenStack Compute (nova) "Instance resize with swap on cinder volume fails" [Undecided,New] | 21:45 |
| *** yamamoto has joined #openstack-nova | 21:47 | |
| *** vladikr has quit IRC | 21:49 | |
| *** moshele has quit IRC | 21:50 | |
| *** danpawlik has quit IRC | 21:50 | |
| *** itlinux has quit IRC | 21:51 | |
| *** danpawlik has joined #openstack-nova | 21:52 | |
| *** yamamoto has quit IRC | 21:53 | |
| *** tbachman_ has joined #openstack-nova | 21:54 | |
| *** priteau has quit IRC | 21:54 | |
| *** tbachman has quit IRC | 21:55 | |
| *** tbachman_ is now known as tbachman | 21:55 | |
| *** pcaruana has quit IRC | 21:55 | |
| *** danpawlik has quit IRC | 21:57 | |
| *** salv-orlando has joined #openstack-nova | 21:59 | |
| openstackgerrit | Julia Kreger proposed openstack/nova master: WIP: Add microversion to ironic client wrapper call https://review.openstack.org/554762 | 22:02 |
| *** vladikr has joined #openstack-nova | 22:02 | |
| sean-k-mooney[m] | mriedem: i believe its undefined behavior if you change the number of ephemeral disk on resize. Migration of swap is fine. Resize is not | 22:02 |
| sean-k-mooney[m] | Actually swap resize should be fine since we basically reboot | 22:03 |
| *** tbachman_ has joined #openstack-nova | 22:04 | |
| *** tbachman has quit IRC | 22:04 | |
| *** tbachman_ is now known as tbachman | 22:04 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Remove duplicative implementation of temporary directories. https://review.openstack.org/554791 | 22:04 |
| openstackgerrit | Michael Still proposed openstack/nova master: Use a pythonic delete. https://review.openstack.org/554792 | 22:04 |
| openstackgerrit | Michael Still proposed openstack/nova master: Use a pythonic delete, with a retry. https://review.openstack.org/554793 | 22:04 |
| melwitt | mriedem, dansmith: finally tracked down what's going on in the bug where after upgrading the pike, if there are service records with no uuid (from the N-1 version), they get the "TypeError: Can't upgrade a READER transaction to a WRITER mid-transaction" error | 22:05 |
| melwitt | explained it here https://bugs.launchpad.net/nova/+bug/1746509/comments/9 | 22:05 |
| openstack | Launchpad bug 1746509 in OpenStack Compute (nova) "TypeError: Can't upgrade a READER transaction to a WRITER mid-transaction" [Medium,Confirmed] | 22:05 |
| *** sc has joined #openstack-nova | 22:05 | |
| mriedem | sean-k-mooney[m]: i seem to remember diana clarke trying to fix something wrt swap disks and resize, found https://github.com/dianaclarke/openstack-notes/wiki/resize-disks but not the thing she was trying to fix | 22:06 |
| melwitt | the good news is it's no longer a bug in queens or rocky, but it is a bug in pike | 22:06 |
| *** burt has quit IRC | 22:08 | |
| melwitt | is it cool if I propose a fix only for pike? how does that usually work? | 22:08 |
| dansmith | melwitt: ah yeah that sort of nesting is exactly what I was saying would have to happen, but was skeptical of it existing | 22:08 |
| dansmith | melwitt: so.. glad you traced it all the way down :) | 22:08 |
| cfriesen | mriedem: what about this? https://bugs.launchpad.net/nova/+bug/1552777 | 22:09 |
| openstack | Launchpad bug 1552777 in OpenStack Compute (nova) "resizing from flavor with swap to one without swap puts instance into Error status" [Medium,In progress] - Assigned to Kam Nasim (knasim-wrs) | 22:09 |
| dansmith | melwitt: mriedem would know better than me, but we've had to do that before, IIRC | 22:09 |
| mriedem | reminds me of https://review.openstack.org/#/c/507854/ | 22:09 |
| *** sar has quit IRC | 22:09 | |
| cfriesen | mriedem: though it looks like that one went away in pike | 22:10 |
| sean-k-mooney[m] | Cfriesen resize with swap is picky. I think it works more or less now | 22:10 |
| melwitt | dansmith: yeah, initially I couldn't repro it (as expected) with only a service query. but yeah, got to the bottom of it :) I think it could be easily fixed by just splitting the _make_instance_list call out from under the _get_by_filters_impl, that is, move it to get_by_filters | 22:10 |
| dansmith | melwitt: okay, I just read your comment but I didn't go look at the (old) code to see, but.. sounds good? :) | 22:11 |
| melwitt | dansmith: yeah, just chattering aloud. I'm excited that this makes sense now | 22:11 |
| dansmith | melwitt: I will put a dan dummy in my chair who will continue to listen to your chattering. he doesn't type though, so just assume he's saying "uh huh, yeah, oh. sounds good. uh huh, yeah..." | 22:12 |
| melwitt | haha | 22:12 |
| dansmith | mriedem: and no snide comments from you mister. | 22:13 |
| openstackgerrit | Jay Pipes proposed openstack/nova-specs master: Standardize CPU resource tracking https://review.openstack.org/555081 | 22:13 |
| mikal | pick me pick me! | 22:15 |
| mriedem | i'd have to see the proposed fix | 22:15 |
| mikal | Basically snide comments is all I do now. | 22:16 |
| melwitt | Snide Comment Czar | 22:17 |
| mriedem | melwitt: so you want to move this call to _make_instance_list from here https://github.com/openstack/nova/blob/9465d1c/nova/objects/instance.py#L1235 to right after _get_by_filters_impl is called here https://github.com/openstack/nova/blob/9465d1c/nova/objects/instance.py#L1243 ? | 22:17 |
| mikal | I would accept that job | 22:17 |
| mikal | Or anything entitled "Old man shakes fist at clouds" | 22:18 |
| melwitt | mriedem: yeah, that's what I'm trying right now. already have the func test written. let's see if it works | 22:18 |
| melwitt | yay | 22:19 |
| *** mlavalle has quit IRC | 22:21 | |
| *** lpetrut has quit IRC | 22:22 | |
| mriedem | so why couldn't we just also make this change on master and backport it? | 22:23 |
| *** yamahata has joined #openstack-nova | 22:23 | |
| *** danpawlik has joined #openstack-nova | 22:23 | |
| mriedem | even if it's not a problem on master, | 22:24 |
| mriedem | would changing the same code cause any problems? | 22:24 |
| melwitt | oh yeah, that's a better idea actually | 22:24 |
| melwitt | when I first asked, I wasn't thinking the code was going to be the same on master but it is | 22:25 |
| *** munimeha1 has quit IRC | 22:25 | |
| *** rcernin has joined #openstack-nova | 22:25 | |
| mriedem | dansmith: it would be best if your dan dummy looked like https://www.youtube.com/watch?v=_WQfZYacEAw | 22:26 |
| melwitt | I'll have to rewrite this func test a bit to be a regression func test that will still fail on master. not a big deal | 22:26 |
| *** liverpooler has joined #openstack-nova | 22:26 | |
| mriedem | melwitt: writing a test on master to fail for a thing that doesn't fail on master...breaks my brain | 22:26 |
| dansmith | mriedem: what else would it look like? | 22:26 |
| mriedem | unless you're not going to reproduce it through the API | 22:27 |
| mriedem | but just through the object methods directly | 22:27 |
| melwitt | mriedem: sorry, it will fail on master in an artificial scenario that isn't currently being run. yeah, I don't think I can reproduce it through the API, from what I've seen so far | 22:27 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: List instances performace optimization https://review.openstack.org/507854 | 22:27 |
| melwitt | but calling InstanceList.get_by_filters with expected_attrs=['services'] with a service record with no uuid should do it | 22:28 |
| mriedem | that'd be fine then | 22:28 |
| melwitt | k, doing | 22:28 |
| mriedem | i'd like to note that i can't remember the last time i've had so many "is this appropriate for stable" conversations in the same week | 22:28 |
| *** danpawlik has quit IRC | 22:28 | |
| melwitt | Stable Czar | 22:29 |
| *** threestrands has joined #openstack-nova | 22:29 | |
| mriedem | i would like to avoid the term "czar" for anything | 22:29 |
| mriedem | or tsar | 22:29 |
| melwitt | yeah, good point | 22:29 |
| mriedem | or caesar | 22:29 |
| *** felipemonteiro_ has quit IRC | 22:29 | |
| *** felipemonteiro_ has joined #openstack-nova | 22:29 | |
| *** threestrands has quit IRC | 22:30 | |
| mriedem | isn't the point of czar kind of that there is only one anyway... | 22:30 |
| *** threestrands has joined #openstack-nova | 22:30 | |
| *** threestrands has quit IRC | 22:30 | |
| *** threestrands has joined #openstack-nova | 22:30 | |
| melwitt | I dunno. years ago there was a czar for everything and I was thinking back to that | 22:30 |
| mriedem | i got the reference, i just never liked that | 22:30 |
| mriedem | https://wiki.openstack.org/wiki/Nova#People | 22:30 |
| melwitt | yeah, same. I guess it stuck in my brain though | 22:31 |
| dansmith | mriedem is the sarcasm czar whether he likes it or not | 22:31 |
| dansmith | sorry mikal | 22:31 |
| mriedem | cfriesen: heh https://bugs.launchpad.net/nova/+bug/1754782 | 22:34 |
| openstack | Launchpad bug 1754782 in OpenStack Compute (nova) "we skip critical scheduler filters when forcing the host on instance boot" [Undecided,Opinion] | 22:34 |
| mriedem | "nova put the instance on the host where i told it to" | 22:34 |
| mriedem | cfriesen: if you haven't realized it yet, the RUN_ON_BUILD = True thing is not something we enjoy having in the scheduler | 22:35 |
| mriedem | *RUN_ON_REBUILD | 22:35 |
| mriedem | also, remember the -5 to forcing a host during cold migration | 22:35 |
| *** ccamacho has quit IRC | 22:35 | |
| cfriesen | mriedem: so why don't we just run all the filters and only evaluate the specified hostname? | 22:35 |
| cfriesen | other than "because that's how we've always done it" | 22:36 |
| *** ccamacho has joined #openstack-nova | 22:36 | |
| mriedem | ask bauzas | 22:36 |
| mriedem | he talks at least semi-annually about changing the forst host/node stuff in server create to be a 'requested' destination | 22:37 |
| mriedem | evaluated by the scheduler | 22:37 |
| cfriesen | do it | 22:37 |
| cfriesen | ;) | 22:37 |
| mriedem | that would be a microversion of course | 22:37 |
| mriedem | which i'd be ok with, it would be like passing a host to evacuate or live migrate | 22:37 |
| mriedem | and cold migrate now i guess | 22:37 |
| cfriesen | did we do a microversion when we started prefiltering via placement when forcing the destination? | 22:38 |
| cfriesen | I guess it's the claim in placement that I mean, not the prefiltering | 22:39 |
| mriedem | no, but i don't buy that argument | 22:41 |
| mriedem | i believe you could still fail the claim in the compute even if you force | 22:41 |
| mriedem | but i might be wrong, as i think the filters add the limits to the dict that gets passed down from scheduler to compute | 22:42 |
| mriedem | anyway, we have to claim in placement (Create the allocations) otherwise our tracking gets all screwed up, so i don't feel bad about breaking the 'force host' contract there | 22:43 |
| cfriesen | I think the limits happen after the filters...but in any case I get that we don't want to change behaviour without a microversion even if we never really defined the behaviour. | 22:43 |
| mriedem | the limits dict is passed from the scheduler down through conductor to the compute | 22:44 |
| mriedem | and used for the claim | 22:44 |
| mriedem | the limits dict in the scheduler is i believe populated via the filters | 22:44 |
| mriedem | which is why we can't remove the old school claim stuff in compute until we at least drop something like the caching scheduler, which doesn't use placement and relies on the late ass claim | 22:45 |
| cfriesen | I think you're right...I see the filters updating host_state.limits | 22:46 |
| mriedem | guh, i've triaged at least 2 bugs like this today https://bugs.launchpad.net/nova/+bug/1754543 | 22:46 |
| openstack | Launchpad bug 1754543 in OpenStack Compute (nova) "not update request_spec.request_networks after attach or detach interface" [Undecided,Invalid] - Assigned to Deepak Mourya (mourya007) | 22:46 |
| *** andreas_s has joined #openstack-nova | 22:47 | |
| mriedem | "request spec isn't what i expect it to be" | 22:47 |
| mriedem | how is that a bug, except for wanting to hack in your own private stuff | 22:47 |
| *** tssurya has quit IRC | 22:48 | |
| *** yamamoto has joined #openstack-nova | 22:49 | |
| *** elmaciej has joined #openstack-nova | 22:49 | |
| *** hongbin has quit IRC | 22:50 | |
| *** sapcc-bot3 has joined #openstack-nova | 22:50 | |
| *** sapcc-bot has quit IRC | 22:50 | |
| *** andreas_s has quit IRC | 22:51 | |
| *** esberglu has quit IRC | 22:51 | |
| cfriesen | heh...so they want request spec to reflect the instance as it is now, rather than as it was at boot time? | 22:51 |
| sean-k-mooney[m] | mriedem: i havent read it yet but i would expect the request spec in the instance to be updated when i attach or detach an interface so livemigration would work right | 22:51 |
| mriedem | cfriesen: i guess | 22:52 |
| mriedem | sean-k-mooney[m]: we already have a thing that tracks that, | 22:52 |
| mriedem | it's called, | 22:52 |
| mriedem | the instance | 22:52 |
| mriedem | the request spec is not in the instance | 22:53 |
| mriedem | it's a copy of the initial server create request | 22:53 |
| cfriesen | mriedem: don't we feed the request spec to the scheduler when searching for a dest? | 22:53 |
| mriedem | minus ports and bdms | 22:53 |
| mriedem | cfriesen: sure do | 22:53 |
| mriedem | sometimes slightly modified | 22:53 |
| mriedem | so my guess would be, people have out of tree filters, | 22:53 |
| mriedem | and those filters need to know information about volumes and ports on the instance, | 22:54 |
| mriedem | and they want to get it from the request spec, | 22:54 |
| *** _ix has quit IRC | 22:54 | |
| cfriesen | I was going to ask about ports/bdms, but then you pointed out that they were subtracted anyways. | 22:54 |
| mriedem | because they are too lazy to hit the DB, or cinder or neutron APIs | 22:54 |
| mriedem | they aren't subtracted, they just aren't persisted in the request spec | 22:54 |
| sean-k-mooney[m] | mriedem: well if we send the request spec to the schduler when livemigrating then would you not want it to have the list of networks you vm currently has instead of the inital set | 22:54 |
| *** yamamoto has quit IRC | 22:54 | |
| mriedem | sean-k-mooney[m]: we don't have any filters that look at that | 22:55 |
| mriedem | "nova doesn't provide the thing my private out of tree filter needs" isn't a bug | 22:55 |
| sean-k-mooney[m] | the pci passthrough fileter looks at this | 22:56 |
| sean-k-mooney[m] | that said i guess we dont supprot hot attach for sriov interfaces currently | 22:56 |
| sean-k-mooney[m] | you can detach actully but just not attach | 22:56 |
| sean-k-mooney[m] | actully the pci passthroguh filter looks at the pci requests specs which i guess is a little different | 22:57 |
| mriedem | right | 22:57 |
| mriedem | now i'm sure it's possible to attach a port to an instance where the network that port is on is available to the current compute host, and then live migrate the instance to another host where that network is't available, | 22:58 |
| mriedem | but that's also a problem we have with server create today | 22:58 |
| sean-k-mooney[m] | i always forget how the routed networks stuff works but do they just track the subnets in placement or is there also a sechuler filter | 22:59 |
| mriedem | there isn't a filter | 22:59 |
| mriedem | they use aggregates somehow | 22:59 |
| mriedem | i still don't know how it actually works | 22:59 |
| sean-k-mooney[m] | mriedem: on boot that is "fine" because we can retry. on livemigrate not so much | 23:00 |
| mriedem | without doing the port stuff in conductor | 23:00 |
| *** gjayavelu has quit IRC | 23:02 | |
| sean-k-mooney[m] | well if the request spec is intended to store teh inital request then ya thats not a bug | 23:03 |
| *** masber has joined #openstack-nova | 23:04 | |
| *** danpawlik has joined #openstack-nova | 23:04 | |
| *** gjayavelu has joined #openstack-nova | 23:04 | |
| sean-k-mooney[m] | mriedem: by the way was i chatting to you at the ptg about the pci white list parser bug i found. i think i tracked it to here https://github.com/openstack/nova/blob/master/nova/pci/whitelist.py#L58 do you know if there is a reason we use jsonutils directly here and not oslo.config | 23:07 |
| *** edmondsw has quit IRC | 23:07 | |
| *** danpawlik has quit IRC | 23:08 | |
| *** suresh12 has quit IRC | 23:08 | |
| mriedem | sean-k-mooney[m]: wasn't me | 23:10 |
| sean-k-mooney[m] | not looking to blame :) | 23:12 |
| *** suresh12 has joined #openstack-nova | 23:13 | |
| sean-k-mooney[m] | the call to jsonutils.loads(jsonspec) can raise error other then value error so if you have unicode in your whitelist the nova compute agent can die because the exception is not caught | 23:13 |
| mriedem | lyarwood was looking at something similar before the ptg | 23:14 |
| sean-k-mooney[m] | mriedem: i hard locked 15 server with this bug + a docker/centos kernel bug the week before the ptg | 23:15 |
| sean-k-mooney[m] | our lab time was interested in why our rack was suddenly draw 5% of the total phase | 23:15 |
| mriedem | efried: this is a fun one up your ksa alley https://bugs.launchpad.net/nova/+bug/1752152 | 23:15 |
| openstack | Launchpad bug 1752152 in OpenStack Compute (nova) queens "Attach Volume Fails with secure call to cinder" [Undecided,Triaged] | 23:15 |
| sean-k-mooney[m] | any way i was talking to dug helmen about if i should "fix" it in oslo or nova ill proably submit a patch to both and see which one merges first | 23:17 |
| *** elmaciej has quit IRC | 23:17 | |
| efried | mriedem: Looks like it has an owner? | 23:18 |
| *** itlinux has joined #openstack-nova | 23:20 | |
| mriedem | efried: dikonoor doesn't seem to actually be working on it | 23:20 |
| mriedem | maybe run that through the internal powervc sametime channel :) | 23:21 |
| mriedem | er verse | 23:21 |
| mriedem | er slack | 23:21 |
| efried | mriedem: Do we need to use https to get the version document?? | 23:21 |
| mriedem | i assume https is what's in the service catalog? | 23:22 |
| mriedem | apparently you don't need a token to get the version document, which is ok with http | 23:23 |
| mriedem | so uh, | 23:23 |
| mriedem | how terrible would it be if we s/https/http/ in this cinderclient code? | 23:23 |
| efried | MITM? | 23:24 |
| mriedem | aaS | 23:24 |
| efried | mordred: Care to render an opinion? (TL;DR: is it okay to demote https to http if we're just getting the version document?) | 23:25 |
| *** salv-orlando has quit IRC | 23:26 | |
| cfriesen | any way to do a MiTM attack with the version document? | 23:26 |
| cfriesen | whoops, efried already said that | 23:26 |
| efried | Other than, like, corrupting it. | 23:26 |
| *** salv-orlando has joined #openstack-nova | 23:26 | |
| efried | Or maybe spoofing a microversion with a known security flaw? | 23:26 |
| cfriesen | yeah, that's what I was thinking | 23:26 |
| mriedem | otherwise i can probably hack something like where we actually create a cinderclient client object, and then use it's internal client to make the request | 23:28 |
| efried | mriedem: The alternative, though, is for this method (still in cinderclient) to use proper ksa loading instead of direct requests.get | 23:28 |
| mriedem | or, just use ksa | 23:28 |
| efried | yeah, any of that. | 23:28 |
| *** r-daneel has quit IRC | 23:30 | |
| *** salv-orlando has quit IRC | 23:30 | |
| efried | mriedem: If we want to keep that method in cinderclient, we could add a kwarg that lets you pass in a ksa session. Then from nova use the _SESSION global which we've already loaded by that point. | 23:31 |
| openstackgerrit | Jay Pipes proposed openstack/nova-specs master: Standardize CPU resource tracking https://review.openstack.org/555081 | 23:31 |
| efried | mriedem: Howzat sound? | 23:31 |
| mriedem | efried: i'd then have to plumb that through into cinderclient i think | 23:31 |
| efried | yes, that's what I mean. | 23:31 |
| mriedem | see https://bugs.launchpad.net/nova/+bug/1752152/comments/2 | 23:31 |
| openstack | Launchpad bug 1752152 in OpenStack Compute (nova) queens "Attach Volume Fails with secure call to cinder" [Undecided,Triaged] | 23:31 |
| mriedem | i would like to just cut out cinderclient altogether | 23:31 |
| efried | The alternative is duplicating the cinderclient code in nova. | 23:31 |
| efried | yeah, that. | 23:32 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add functional regression test for bug 1746509 https://review.openstack.org/555092 | 23:32 |
| openstack | bug 1746509 in OpenStack Compute (nova) "TypeError: Can't upgrade a READER transaction to a WRITER mid-transaction" [Medium,Confirmed] https://launchpad.net/bugs/1746509 | 23:32 |
| openstackgerrit | melanie witt proposed openstack/nova master: Move _make_instance_list call outside of DB transaction context https://review.openstack.org/555093 | 23:32 |
| mriedem | also, we can't change cinderclient API code and require a new minimum version on stable | 23:32 |
| mriedem | so that's kind of a non-starter | 23:32 |
| mriedem | alright, i can make that my tomorrow if i can get a recreate with devstack configuring cinder for ssl | 23:34 |
| mriedem | actually this is strange because devstack already sets up the endpoint using https if tls-proxy is enabled, which it is in our CI runs | 23:37 |
| *** danpawlik has joined #openstack-nova | 23:39 | |
| *** chyka has quit IRC | 23:39 | |
| melwitt | mriedem: not always right? we had to enable it explicitly for nova-next, right? | 23:40 |
| mriedem | http://logs.openstack.org/45/508345/13/check/tempest-full/893771e/controller/logs/devstacklog.txt.gz#_2018-03-15_19_48_10_167 | 23:40 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add functional regression test for bug 1746509 https://review.openstack.org/555092 | 23:40 |
| openstack | bug 1746509 in OpenStack Compute (nova) "TypeError: Can't upgrade a READER transaction to a WRITER mid-transaction" [Medium,In progress] https://launchpad.net/bugs/1746509 - Assigned to melanie witt (melwitt) | 23:40 |
| openstackgerrit | melanie witt proposed openstack/nova master: Move _make_instance_list call outside of DB transaction context https://review.openstack.org/555093 | 23:40 |
| mriedem | ENABLED_SERVICES=g-reg,rabbit,n-api,c-api,g-api,mysql,tempest,etcd3,s-proxy,q-dhcp,n-api-meta,tls-proxy,q-l3,c-sch,n-novnc,s-object,peakmem_tracker,n-cauth,q-metering,key,n-cond,s-container,q-meta,q-svc,placement-api,n-cpu,s-account,c-vol,n-obj,c-bak,q-agt,cinder,n-sch,dstat | 23:40 |
| *** felipemonteiro_ has quit IRC | 23:41 | |
| melwitt | hm, okay | 23:42 |
| mriedem | maybe it's a legacy job vs zuulv3 job thing, not sure | 23:42 |
| mriedem | tempest-full is zuulv3 native | 23:42 |
| melwitt | yep, enabled there. not sure why we had to enable it in nova-next | 23:42 |
| *** danpawlik has quit IRC | 23:44 | |
| *** gyee has quit IRC | 23:45 | |
| mriedem | yeah right here http://logs.openstack.org/45/508345/13/check/nova-next/aa61d86/logs/screen-c-api.txt.gz#_Mar_15_20_00_06_201395 | 23:45 |
| mriedem | Mar 15 20:00:06.201395 ubuntu-xenial-inap-mtl01-0002993032 devstack@c-api.service[32240]: INFO cinder.api.openstack.wsgi [req-2e3a55fd-3ed7-4b7f-b902-c4671afa83c4 req-d6e11ad6-95b0-42ed-bcb2-af3996a69096 admin admin] GET https://198.72.124.205/volume/ | 23:45 |
| mriedem | Mar 15 20:00:06.201628 ubuntu-xenial-inap-mtl01-0002993032 devstack@c-api.service[32240]: DEBUG cinder.api.openstack.wsgi [req-2e3a55fd-3ed7-4b7f-b902-c4671afa83c4 req-d6e11ad6-95b0-42ed-bcb2-af3996a69096 admin admin] Empty body provided in request {{(pid=32243) get_body /opt/stack/new/cinder/cinder/api/openstack/wsgi.py:718}} Mar 15 20:00:06.202003 ubuntu-xenial-inap-mtl01-0002993032 devstack@c-api.service[32240]: DEBUG cind | 23:46 |
| mriedem | pi.openstack.wsgi [req-2e3a55fd-3ed7-4b7f-b902-c4671afa83c4 req-d6e11ad6-95b0-42ed-bcb2-af3996a69096 admin admin] Calling method '<bound method VersionsController.all of <cinder.api.versions.VersionsController object at 0x7f81c53a0550>>' {{(pid=32243) _process_stack /opt/stack/new/cinder/cinder/api/openstack/wsgi.py:872}} Mar 15 20:00:06.202926 ubuntu-xenial-inap-mtl01-0002993032 devstack@c-api.service[32240]: INFO cinder.api | 23:46 |
| mriedem | nstack.wsgi [req-2e3a55fd-3ed7-4b7f-b902-c4671afa83c4 req-d6e11ad6-95b0-42ed-bcb2-af3996a69096 admin admin] https://198.72.124.205/volume/ returned with HTTP 300 | 23:46 |
| mriedem | yikes | 23:46 |
| mriedem | Mar 15 20:00:06.202003 ubuntu-xenial-inap-mtl01-0002993032 devstack@c-api.service[32240]: DEBUG cinder.api.openstack.wsgi [req-2e3a55fd-3ed7-4b7f-b902-c4671afa83c4 req-d6e11ad6-95b0-42ed-bcb2-af3996a69096 admin admin] Calling method '<bound method VersionsController.all of <cinder.api.versions.VersionsController object at 0x7f81c53a0550>>' {{(pid=32243) _process_stack /opt/stack/new/cinder/cinder/api/openstack/wsgi.py:872}} | 23:46 |
| mriedem | that's hitting the versions controller | 23:46 |
| mriedem | Mar 15 20:00:06.202926 ubuntu-xenial-inap-mtl01-0002993032 devstack@c-api.service[32240]: INFO cinder.api.openstack.wsgi [req-2e3a55fd-3ed7-4b7f-b902-c4671afa83c4 req-d6e11ad6-95b0-42ed-bcb2-af3996a69096 admin admin] https://198.72.124.205/volume/ returned with HTTP 300 | 23:46 |
| mriedem | idk, maybe that's via the client doing it's own version negotiation | 23:47 |
| mriedem | also, if this has been regressed since pike, i'm pretty sure we would have heard more about this by now right? | 23:48 |
| mriedem | i assume most clouds are using ssl | 23:48 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova-specs master: NUMA-aware live migration https://review.openstack.org/552722 | 23:50 |
| *** claudiub has quit IRC | 23:51 | |
| *** yamamoto has joined #openstack-nova | 23:51 | |
| *** jackie-truong has quit IRC | 23:54 | |
| *** yamamoto has quit IRC | 23:55 | |
| openstackgerrit | Merged openstack/nova master: Rename '_numa_get_constraints_XXX' functions https://review.openstack.org/385072 | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!