*** hshiina has joined #openstack-nova | 00:06 | |
*** Tom-Tom has joined #openstack-nova | 00:19 | |
*** trozet has quit IRC | 00:20 | |
*** liverpooler has joined #openstack-nova | 00:22 | |
*** gus has left #openstack-nova | 00:23 | |
*** Tom-Tom has quit IRC | 00:23 | |
*** yangyapeng has quit IRC | 00:26 | |
*** gouthamr has joined #openstack-nova | 00:27 | |
*** jaypipes has quit IRC | 00:34 | |
*** liuzz has joined #openstack-nova | 00:35 | |
*** odyssey4me has quit IRC | 00:35 | |
*** odyssey4me has joined #openstack-nova | 00:35 | |
*** pchavva has joined #openstack-nova | 00:36 | |
*** masber has joined #openstack-nova | 00:37 | |
*** yassine has quit IRC | 00:37 | |
*** zhurong has joined #openstack-nova | 00:37 | |
*** yamahata has joined #openstack-nova | 00:38 | |
*** elmaciej has quit IRC | 00:39 | |
*** Dinesh_Bhor has joined #openstack-nova | 00:45 | |
*** hoangcx has joined #openstack-nova | 00:51 | |
*** yassine has joined #openstack-nova | 00:51 | |
*** jichen has joined #openstack-nova | 00:52 | |
*** zhurong has quit IRC | 01:01 | |
*** sree has joined #openstack-nova | 01:03 | |
*** phuongnh has joined #openstack-nova | 01:04 | |
*** sree has quit IRC | 01:08 | |
*** yangyapeng has joined #openstack-nova | 01:10 | |
*** yingjun has joined #openstack-nova | 01:10 | |
*** zhaochao has joined #openstack-nova | 01:11 | |
*** hongbin has joined #openstack-nova | 01:12 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add check if neutron "binding-extended" extension is available https://review.openstack.org/523548 | 01:12 |
---|---|---|
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add code to bind a port against a dest host during live migration https://review.openstack.org/523604 | 01:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423 | 01:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370 | 01:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170 | 01:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947 | 01:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371 | 01:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Port binding based on events during live migration https://review.openstack.org/434870 | 01:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | 01:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Turn on new port binding extended live migrate flow https://review.openstack.org/552173 | 01:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Avoid unnecessary port update during live migration https://review.openstack.org/556332 | 01:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333 | 01:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334 | 01:12 |
*** mriedem has quit IRC | 01:13 | |
*** Tom-Tom has joined #openstack-nova | 01:13 | |
*** yangyapeng has quit IRC | 01:14 | |
*** artom has joined #openstack-nova | 01:17 | |
*** Tom-Tom has quit IRC | 01:17 | |
*** yingjun has quit IRC | 01:17 | |
*** yangyapeng has joined #openstack-nova | 01:19 | |
*** salv-orl_ has joined #openstack-nova | 01:30 | |
*** tiendc has joined #openstack-nova | 01:30 | |
*** fanzhang has quit IRC | 01:31 | |
*** fanzhang has joined #openstack-nova | 01:32 | |
*** salv-orlando has quit IRC | 01:33 | |
*** Dinesh_Bhor has quit IRC | 01:35 | |
*** Dinesh_Bhor has joined #openstack-nova | 01:36 | |
*** sree has joined #openstack-nova | 01:37 | |
*** sree has quit IRC | 01:41 | |
*** Tom-Tom has joined #openstack-nova | 01:47 | |
*** tbachman has joined #openstack-nova | 01:47 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 01:50 |
*** sree has joined #openstack-nova | 01:54 | |
*** _pewp_ has quit IRC | 01:56 | |
*** sree has quit IRC | 01:58 | |
*** _pewp_ has joined #openstack-nova | 01:59 | |
*** tbachman has quit IRC | 02:02 | |
*** david-lyle has joined #openstack-nova | 02:08 | |
*** takashin has joined #openstack-nova | 02:10 | |
*** germs has quit IRC | 02:11 | |
*** germs has joined #openstack-nova | 02:11 | |
*** germs has quit IRC | 02:11 | |
*** germs has joined #openstack-nova | 02:11 | |
*** _pewp_ has quit IRC | 02:17 | |
*** archit has joined #openstack-nova | 02:17 | |
*** masber has quit IRC | 02:21 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 02:22 |
*** vivsoni__ has quit IRC | 02:32 | |
*** annp has joined #openstack-nova | 02:34 | |
*** Dinesh_Bhor has quit IRC | 02:36 | |
*** moshele has joined #openstack-nova | 02:36 | |
openstackgerrit | melissaml proposed openstack/nova master: Use http code constant instead of int https://review.openstack.org/556340 | 02:38 |
*** moshele has quit IRC | 02:42 | |
*** Dinesh_Bhor has joined #openstack-nova | 02:42 | |
*** kmalloc has quit IRC | 02:46 | |
*** pchavva has quit IRC | 02:47 | |
*** vivsoni has joined #openstack-nova | 02:49 | |
*** Dinesh_Bhor has quit IRC | 02:54 | |
*** Dinesh_Bhor has joined #openstack-nova | 02:59 | |
*** lei-zh has joined #openstack-nova | 03:00 | |
*** david-lyle has quit IRC | 03:01 | |
*** lei-zh has quit IRC | 03:01 | |
*** lei-zh has joined #openstack-nova | 03:02 | |
*** Dinesh_Bhor has quit IRC | 03:07 | |
*** masber has joined #openstack-nova | 03:17 | |
*** suresh12 has joined #openstack-nova | 03:24 | |
*** Tom-Tom has quit IRC | 03:25 | |
*** Tom-Tom has joined #openstack-nova | 03:26 | |
*** suresh12 has quit IRC | 03:26 | |
*** yamamoto has joined #openstack-nova | 03:27 | |
*** takashin has quit IRC | 03:27 | |
*** zhaochao has quit IRC | 03:28 | |
*** jroll has quit IRC | 03:28 | |
*** gouthamr has quit IRC | 03:29 | |
*** zhaochao has joined #openstack-nova | 03:30 | |
*** Tom-Tom has quit IRC | 03:30 | |
*** jroll has joined #openstack-nova | 03:31 | |
*** yamamoto has quit IRC | 03:31 | |
*** dave-mccowan has quit IRC | 03:34 | |
*** _pewp_ has joined #openstack-nova | 03:35 | |
*** zhurong has joined #openstack-nova | 03:37 | |
*** hongbin has quit IRC | 03:45 | |
*** pooja_jadhav has joined #openstack-nova | 03:45 | |
*** suresh12 has joined #openstack-nova | 03:46 | |
*** sree has joined #openstack-nova | 03:47 | |
*** yassine has quit IRC | 03:48 | |
*** rcernin has quit IRC | 03:55 | |
*** rcernin has joined #openstack-nova | 03:55 | |
*** abhishekk has joined #openstack-nova | 04:00 | |
*** abhishekk is now known as akekane|wfh | 04:00 | |
*** akekane|wfh is now known as abhishekk | 04:00 | |
*** ratailor has joined #openstack-nova | 04:01 | |
*** bhagyashris has joined #openstack-nova | 04:01 | |
*** yassine has joined #openstack-nova | 04:02 | |
*** archit has quit IRC | 04:04 | |
*** Dinesh_Bhor has joined #openstack-nova | 04:05 | |
*** _pewp_ has quit IRC | 04:07 | |
*** _pewp_ has joined #openstack-nova | 04:08 | |
*** bhujay has joined #openstack-nova | 04:09 | |
*** vivsoni has quit IRC | 04:27 | |
*** psachin has joined #openstack-nova | 04:28 | |
*** yamamoto has joined #openstack-nova | 04:28 | |
*** vivsoni has joined #openstack-nova | 04:30 | |
*** rha has quit IRC | 04:34 | |
*** Tom-Tom has joined #openstack-nova | 04:35 | |
*** udesale has joined #openstack-nova | 04:35 | |
*** zhurong has quit IRC | 04:42 | |
*** masber has quit IRC | 04:47 | |
*** gyankum has joined #openstack-nova | 04:49 | |
*** masber has joined #openstack-nova | 04:49 | |
*** Dinesh__Bhor has joined #openstack-nova | 05:02 | |
*** Dinesh_Bhor has quit IRC | 05:02 | |
*** sdeath has joined #openstack-nova | 05:02 | |
*** jichen has quit IRC | 05:02 | |
*** sdeath has quit IRC | 05:02 | |
*** jichen has joined #openstack-nova | 05:02 | |
*** sdeath has joined #openstack-nova | 05:02 | |
*** vivsoni has quit IRC | 05:08 | |
*** moshele has joined #openstack-nova | 05:14 | |
*** vivsoni has joined #openstack-nova | 05:14 | |
*** moshele has quit IRC | 05:16 | |
*** lpetrut has joined #openstack-nova | 05:19 | |
*** takashin has joined #openstack-nova | 05:25 | |
*** lpetrut has quit IRC | 05:32 | |
*** lpetrut has joined #openstack-nova | 05:32 | |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 05:33 |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 05:33 |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240 | 05:33 |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340 | 05:33 |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344 | 05:33 |
*** Dinesh__Bhor has quit IRC | 05:37 | |
*** suresh12 has quit IRC | 05:43 | |
*** suresh12 has joined #openstack-nova | 05:45 | |
*** suresh12 has quit IRC | 05:49 | |
*** Dinesh__Bhor has joined #openstack-nova | 05:53 | |
*** Dinesh__Bhor has quit IRC | 05:56 | |
*** Dinesh__Bhor has joined #openstack-nova | 05:56 | |
*** jaosorior has joined #openstack-nova | 05:59 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | 05:59 |
*** lajoskatona has joined #openstack-nova | 06:04 | |
*** Eran_Kuris has joined #openstack-nova | 06:08 | |
*** moshele has joined #openstack-nova | 06:09 | |
*** jaosorior has quit IRC | 06:14 | |
*** kmalloc has joined #openstack-nova | 06:17 | |
*** links has joined #openstack-nova | 06:19 | |
*** AlexeyAbashkin has joined #openstack-nova | 06:19 | |
*** jaosorior has joined #openstack-nova | 06:21 | |
*** maciejjozefczyk has joined #openstack-nova | 06:22 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483 | 06:23 |
openstackgerrit | Takashi NATSUME proposed openstack/nova stable/queens: [placement] Add sending global request ID in get https://review.openstack.org/543116 | 06:24 |
openstackgerrit | Naichuan Sun proposed openstack/nova master: (WIP)xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041 | 06:24 |
*** AlexeyAbashkin has quit IRC | 06:24 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.61 - List/Show all server migration types https://review.openstack.org/430839 | 06:25 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | 06:26 |
*** claudiub has quit IRC | 06:26 | |
*** claudiub has joined #openstack-nova | 06:27 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller https://review.openstack.org/347289 | 06:27 |
*** Eran_Kuris has quit IRC | 06:29 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix api-ref: nova image-meta is deprecated from 2.39 https://review.openstack.org/554813 | 06:31 |
*** toabctl has joined #openstack-nova | 06:32 | |
*** sar has joined #openstack-nova | 06:32 | |
*** moshele has quit IRC | 06:35 | |
*** Eran_Kuris has joined #openstack-nova | 06:39 | |
*** masber has quit IRC | 06:41 | |
*** jaosorior has quit IRC | 06:41 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 06:41 |
*** moshele has joined #openstack-nova | 06:42 | |
*** andreas_s has joined #openstack-nova | 06:50 | |
*** jaosorior has joined #openstack-nova | 06:50 | |
*** lpetrut has quit IRC | 06:58 | |
*** afaranha has joined #openstack-nova | 06:59 | |
*** fragatina has quit IRC | 07:03 | |
*** fragatina has joined #openstack-nova | 07:03 | |
openstackgerrit | Merged openstack/python-novaclient master: add lower-constraints job https://review.openstack.org/556169 | 07:04 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/548772 | 07:06 |
*** pcaruana has joined #openstack-nova | 07:08 | |
*** rcernin has quit IRC | 07:10 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers.inc (1/3) https://review.openstack.org/528201 | 07:13 |
*** damien_r has joined #openstack-nova | 07:15 | |
*** elod has quit IRC | 07:16 | |
*** sahid has joined #openstack-nova | 07:17 | |
*** elod has joined #openstack-nova | 07:18 | |
*** damien_r has quit IRC | 07:19 | |
*** damien_r has joined #openstack-nova | 07:19 | |
*** tesseract has joined #openstack-nova | 07:23 | |
*** moshele has quit IRC | 07:25 | |
*** moshele has joined #openstack-nova | 07:26 | |
*** ralonsoh has joined #openstack-nova | 07:26 | |
*** maciejjozefczyk has quit IRC | 07:35 | |
*** maciejjozefczyk has joined #openstack-nova | 07:35 | |
*** markmcclain has quit IRC | 07:40 | |
*** fanzhang has quit IRC | 07:42 | |
*** fanzhang has joined #openstack-nova | 07:42 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform aggregate.update_metadata notification https://review.openstack.org/460625 | 07:46 |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.61 - List/Show all server migration types https://review.openstack.org/430839 | 07:48 |
*** AlexeyAbashkin has joined #openstack-nova | 07:50 | |
*** abhishekk has quit IRC | 07:51 | |
*** mdnadeem has joined #openstack-nova | 07:52 | |
*** dineshbhor__ has joined #openstack-nova | 07:52 | |
*** Dinesh__Bhor has quit IRC | 07:53 | |
*** fragatina has quit IRC | 07:53 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for Granular API policy https://review.openstack.org/547850 | 07:54 |
gmann_ | johnthetubaguy: can you please check granular API policy spec - https://review.openstack.org/#/c/547850/5 | 07:55 |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 07:55 |
*** lucas-afk is now known as lucasagomes | 07:58 | |
*** moshele has quit IRC | 08:08 | |
*** masber has joined #openstack-nova | 08:09 | |
*** moshele has joined #openstack-nova | 08:12 | |
bauwser | good morning Nova | 08:12 |
*** bauwser is now known as bauzas | 08:12 | |
*** gjayavelu has joined #openstack-nova | 08:13 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/556418 | 08:15 |
*** dineshbhor__ has quit IRC | 08:16 | |
*** Dinesh_Bhor has joined #openstack-nova | 08:16 | |
*** claudiub|2 has joined #openstack-nova | 08:16 | |
*** danpawlik has joined #openstack-nova | 08:17 | |
*** sususuryashines has joined #openstack-nova | 08:18 | |
*** sususuryashines is now known as tssurya | 08:18 | |
*** claudiub has quit IRC | 08:19 | |
*** ktibi has joined #openstack-nova | 08:20 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/533918 | 08:20 |
openstackgerrit | Surya Seetharaman proposed openstack/nova master: Allow scheduling only to enabled cells (Filter Scheduler) https://review.openstack.org/550527 | 08:20 |
*** derekh has joined #openstack-nova | 08:23 | |
*** mdbooth has joined #openstack-nova | 08:28 | |
*** abhishekk has joined #openstack-nova | 08:28 | |
*** abhishekk has quit IRC | 08:29 | |
bauzas | jianghuaw_: around ? | 08:29 |
*** abhishekk has joined #openstack-nova | 08:29 | |
*** gjayavelu has quit IRC | 08:29 | |
*** takashin has left #openstack-nova | 08:30 | |
*** lpetrut has joined #openstack-nova | 08:35 | |
*** alexchadin has joined #openstack-nova | 08:40 | |
*** abhishekk has quit IRC | 08:42 | |
*** ragiman has joined #openstack-nova | 08:46 | |
*** bjolo has joined #openstack-nova | 08:49 | |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova-specs master: Complex (Anti)-Affinity Policies https://review.openstack.org/546925 | 08:53 |
*** masber has quit IRC | 08:54 | |
*** masber has joined #openstack-nova | 08:57 | |
*** hshiina has quit IRC | 08:57 | |
*** abhishekk has joined #openstack-nova | 08:58 | |
*** abhishekk has quit IRC | 08:59 | |
*** abhishekk has joined #openstack-nova | 08:59 | |
*** masber has quit IRC | 09:02 | |
*** ccamacho has joined #openstack-nova | 09:02 | |
*** ccamacho is now known as ccamacho|PTO | 09:03 | |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: [WIP] Consider nested RPs in get_all_with_shared https://review.openstack.org/556450 | 09:03 |
*** masber has joined #openstack-nova | 09:03 | |
*** finucannot is now known as stephenfin | 09:03 | |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: [WIP] Consider nested RPs in get_all_with_shared https://review.openstack.org/556450 | 09:08 |
*** Kvisle has quit IRC | 09:10 | |
*** voelzmo has joined #openstack-nova | 09:10 | |
*** udesale_ has joined #openstack-nova | 09:10 | |
*** udesale has quit IRC | 09:10 | |
*** Kvisle has joined #openstack-nova | 09:11 | |
kashyap | is the CloudBase "nova-dsvm-full-tempest" a voting job? | 09:12 |
kashyap | s/is/Is/ (OCD: Capitalize the first letter of a sentence.) | 09:12 |
*** abhishekk_ has joined #openstack-nova | 09:13 | |
kashyap | Hmm, `reno lint` doesn't catch indentation problems, I thought it does | 09:13 |
*** udesale_ has quit IRC | 09:15 | |
*** abhishekk has quit IRC | 09:15 | |
openstackgerrit | wangqi proposed openstack/nova master: fix a typo https://review.openstack.org/556455 | 09:15 |
*** udesale has joined #openstack-nova | 09:16 | |
*** voelzmo has quit IRC | 09:16 | |
kashyap | stephenfin: Hey there, when you get a moment, can you tell what is wrong with this rel note? | 09:20 |
kashyap | https://review.openstack.org/#/c/534384/12/releasenotes/notes/libvirt-cpu-model-extra-flags-a23085f58bd22d27.yaml | 09:20 |
kashyap | Here's the relasenotes build error: http://logs.openstack.org/84/534384/12/check/build-openstack-releasenotes/c53ebd5/job-output.txt.gz | 09:20 |
* kashyap ran `reno lint` a couple of times. And it didn't show me any actionable errors | 09:21 | |
bauzas | gosh, I'm getting an headache just by trying to reconcile all the comments in between https://review.openstack.org/#/c/555081/3..4/specs/rocky/approved/cpu-resources.rst and https://review.openstack.org/#/c/552924/3/specs/rocky/approved/numa-topology-with-rps.rst | 09:28 |
* bauzas needs a serious shot of coffee | 09:28 | |
bauzas | that looks like a hard start for a Monday | 09:28 |
* bauzas needs to warm up | 09:28 | |
openstackgerrit | Surya Seetharaman proposed openstack/nova master: Update the cells FAQs and scheduler maintenance docs. https://review.openstack.org/556459 | 09:29 |
*** markmcclain has joined #openstack-nova | 09:32 | |
*** srini_ has joined #openstack-nova | 09:34 | |
stephenfin | kashyap: Done | 09:35 |
stephenfin | comments in the review | 09:35 |
* kashyap clicks; thank you | 09:36 | |
*** Dinesh_Bhor has quit IRC | 09:36 | |
kashyap | stephenfin: For DefinitionLists, is the below indentation valid? | 09:37 |
kashyap | Foo: | 09:37 |
kashyap | BarWhizz | 09:37 |
kashyap | (4 spaces) | 09:37 |
* kashyap gives it a whirl | 09:37 | |
stephenfin | Yup. I think any level of indentation is fine. Just don't leave a newline between the two | 09:37 |
stephenfin | Or it becomes a paragraph followed by a block comment | 09:37 |
*** aloga_ has joined #openstack-nova | 09:38 | |
*** masber has quit IRC | 09:38 | |
kashyap | Yeah, I'll give a pastebin before I waste precious Gate resources, if you can take a quick gander | 09:38 |
kashyap | Hmm, `reno lint .` should catch that. (TODO: File a ticket on StoryBoard for that) | 09:38 |
*** zhurong has joined #openstack-nova | 09:39 | |
*** giblet is now known as gibi | 09:39 | |
gibi | good day nova | 09:40 |
*** Tom-Tom has quit IRC | 09:43 | |
*** Tom-Tom has joined #openstack-nova | 09:44 | |
*** Tom-Tom has quit IRC | 09:48 | |
kashyap | How to re-trigger CloudBase CI? Is it 'check hyper-v'? | 09:56 |
*** sambetts|afk is now known as sambetts | 09:57 | |
*** lei-zh has quit IRC | 09:59 | |
*** gyankum has quit IRC | 10:01 | |
openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Filter resource providers by forbidden traits in db https://review.openstack.org/556472 | 10:03 |
*** alexchadin has quit IRC | 10:03 | |
lpetrut | kashyap: yep, "check hyper-v" should work | 10:04 |
kashyap | lpetrut: Thank you | 10:04 |
*** vivsoni has quit IRC | 10:04 | |
*** yassine has quit IRC | 10:06 | |
*** phuongnh has quit IRC | 10:06 | |
*** sdague has joined #openstack-nova | 10:06 | |
*** sree has quit IRC | 10:07 | |
*** vivsoni has joined #openstack-nova | 10:07 | |
kashyap | lpetrut: Do you know if this is a legit faliure? http://cloudbase-ci.com//nova/534384/12/console.log.gz | 10:11 |
lpetrut | kashyap: checking | 10:14 |
*** jichen has quit IRC | 10:16 | |
lpetrut | looks like nova-compute does not start on the Hyper-V node, it's an unrelated issue but thanks for checking. we'll look into it | 10:18 |
lpetrut | also, I took a look at the patch and it was only changing libvirt driver code, which won't be used on Windows | 10:18 |
kashyap | Exactly :-) | 10:21 |
kashyap | Thanks for looking, lpetrut | 10:21 |
*** lpetrut has quit IRC | 10:22 | |
kashyap | stephenfin: When you get another minute, mind taking a look: https://kashyapc.fedorapeople.org/libvirt-cpu-model-extra-flags-a23085f58bd22d27.yaml.txt | 10:23 |
*** lpetrut has joined #openstack-nova | 10:23 | |
kashyap | (Before I upload the change.) | 10:23 |
stephenfin | kashyap: Looks correct, aye | 10:23 |
kashyap | stephenfin: Even the indentation of two 'dashed' bullet points under item 3.? | 10:24 |
stephenfin | Yup, that's what I'd expect to see | 10:24 |
kashyap | Most excellent; thank you! | 10:24 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/534384 | 10:26 |
*** tiendc has quit IRC | 10:34 | |
*** abhishekk_ has quit IRC | 10:36 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/534384 | 10:40 |
*** alexchadin has joined #openstack-nova | 10:50 | |
*** lei-zh has joined #openstack-nova | 10:56 | |
*** alexchad_ has joined #openstack-nova | 10:56 | |
*** alexchadin has quit IRC | 10:56 | |
*** elmaciej has joined #openstack-nova | 10:58 | |
openstackgerrit | sahid proposed openstack/nova-specs master: update: isolate guests emulthreads on CONF.cpu_shared_set https://review.openstack.org/511188 | 10:58 |
sahid | stephenfin, cfriesen I updated the emultor threads spec, if you have a moment to take a look ^ | 10:59 |
sahid | much simple | 11:00 |
alex_xu_ | sean-k-mooney: efried, found one use-case for the granular reqs in images https://review.openstack.org/#/c/554305/2/specs/rocky/approved/glance-image-traits.rst@86 | 11:00 |
*** bhagyashris has quit IRC | 11:01 | |
*** jaosorior has quit IRC | 11:01 | |
*** lei-zh has quit IRC | 11:05 | |
*** lei-zh has joined #openstack-nova | 11:06 | |
*** AlexeyAbashkin has quit IRC | 11:14 | |
*** bhujay has quit IRC | 11:15 | |
*** lei-zh has quit IRC | 11:16 | |
*** bhujay has joined #openstack-nova | 11:16 | |
*** yassine has joined #openstack-nova | 11:24 | |
*** liverpooler has quit IRC | 11:25 | |
*** bhagyashris has joined #openstack-nova | 11:25 | |
*** yamamoto has quit IRC | 11:27 | |
*** zhurong has quit IRC | 11:27 | |
*** AlexeyAbashkin has joined #openstack-nova | 11:29 | |
*** slagle has joined #openstack-nova | 11:30 | |
*** andreas_s_ has joined #openstack-nova | 11:33 | |
*** elmaciej has quit IRC | 11:33 | |
*** andreas_s has quit IRC | 11:35 | |
*** yamamoto has joined #openstack-nova | 11:36 | |
*** dtantsur|afk is now known as dtantsur | 11:37 | |
*** cdent has joined #openstack-nova | 11:40 | |
*** jaosorior has joined #openstack-nova | 11:40 | |
*** yamamoto has quit IRC | 11:45 | |
*** rmart04 has joined #openstack-nova | 11:47 | |
*** sree has joined #openstack-nova | 11:47 | |
sean-k-mooney | alex_xu_: im sure there are several | 11:49 |
*** sree has quit IRC | 11:51 | |
sean-k-mooney | alex_xu_: im not sure that is a usecase at least not in the normal sense | 11:51 |
sean-k-mooney | alex_xu_: we had dicussed haveing specific metadata keys for the FPGA usecase not useing the generic resouces and traits workflow | 11:52 |
*** lucasagomes is now known as lucas-hungry | 11:52 | |
*** sree has joined #openstack-nova | 11:53 | |
gibi | efried: I left some clarification about the numbered request group usage in https://review.openstack.org/#/c/502306/20/specs/rocky/approved/bandwidth-resource-provider.rst@490 | 12:01 |
gibi | efried: I want to make sure we are on the same page before I clarify the situation in the spec directly | 12:02 |
*** dave-mccowan has joined #openstack-nova | 12:03 | |
*** yamamoto has joined #openstack-nova | 12:05 | |
*** elmaciej has joined #openstack-nova | 12:06 | |
*** alexchad_ has quit IRC | 12:07 | |
*** andreas_s_ has quit IRC | 12:08 | |
*** andreas_s has joined #openstack-nova | 12:09 | |
*** andreas_s has quit IRC | 12:09 | |
*** andreas_s has joined #openstack-nova | 12:09 | |
*** eharney has quit IRC | 12:10 | |
openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add --enable and --disable options to nova-manage update_cell https://review.openstack.org/555416 | 12:11 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: remove not necessary short cut https://review.openstack.org/553122 | 12:12 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Fix allocation_candidates not to ignore shared RPs https://review.openstack.org/533396 | 12:12 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: [WIP] Consider nested RPs in get_all_with_shared https://review.openstack.org/556450 | 12:12 |
*** andreas_s_ has joined #openstack-nova | 12:12 | |
*** edmondsw has joined #openstack-nova | 12:13 | |
*** andreas_s has quit IRC | 12:15 | |
*** fragatina has joined #openstack-nova | 12:16 | |
*** elmaciej has quit IRC | 12:18 | |
*** lajoskatona has quit IRC | 12:19 | |
*** lucas-hungry is now known as lucasagomes | 12:25 | |
*** ratailor has quit IRC | 12:26 | |
*** ratailor has joined #openstack-nova | 12:26 | |
*** belmoreira has joined #openstack-nova | 12:28 | |
*** ratailor has quit IRC | 12:30 | |
*** elmaciej has joined #openstack-nova | 12:30 | |
*** yamamoto has quit IRC | 12:30 | |
efried | alex_xu_, gibi: looking... | 12:31 |
efried | ...and good UGT morning! | 12:31 |
*** vladikr has joined #openstack-nova | 12:31 | |
gibi | efried: good morning to you too | 12:32 |
*** andreas_s has joined #openstack-nova | 12:34 | |
efried | alex_xu_: You around? I need help understanding the use case. | 12:34 |
efried | edleafe: Is the sched meeting in 25 or 1:25? | 12:34 |
cdent | efried: latter | 12:34 |
cdent | unless my calendar is borked | 12:35 |
efried | damn, I thought I had my reminders set up to take SFDST into account. | 12:35 |
cdent | yeah, latter | 12:35 |
efried | ...last two weeks were | 12:35 |
efried | weird | 12:35 |
cdent | yeah, really bad planning by the illumanit, rotschilds and other members of world government | 12:36 |
efried | oh, I think it's because I've got it set to GMT - because my calendar doesn't do UTC - and GMT switches two weeks after US. So it looked like it was working... but only for a couple of weeks. | 12:36 |
efried | eff | 12:36 |
cdent | use iceland as your timezone | 12:37 |
cdent | I _think_ that may work | 12:37 |
*** andreas_s_ has quit IRC | 12:37 | |
bauzas | efried: scheduler meeting is planned in 1h 20 mins-ish | 12:38 |
*** liverpooler has joined #openstack-nova | 12:38 | |
bauzas | because CET and GMT moved to DST yesterday, not UTC | 12:38 |
bauzas | and yeah, Iceland TZ == UTC | 12:39 |
efried | thanks y'all. cdent - Rekjavik worked -- nice. | 12:39 |
bauzas | because they don't do dayshift | 12:39 |
efried | Awesome. | 12:39 |
bauzas | efried: using gcal ? | 12:39 |
efried | Notes :( | 12:39 |
openstackgerrit | Merged openstack/osc-placement master: Migrate legacy-osc-placement-dsvm-functional job in-tree https://review.openstack.org/547812 | 12:39 |
openstackgerrit | Merged openstack/osc-placement master: Add osc-placement-dsvm-functional-py3 job https://review.openstack.org/547815 | 12:39 |
bauzas | because TB/Lightning has a UTC TZ | 12:39 |
bauzas | hah | 12:39 |
bauzas | FWIW, for the next 6 months, I will only be possible to be in the scheduler meeting for the first 20 mins :( | 12:40 |
bauzas | efried: cdent: edleafe: ^ | 12:40 |
efried | ack | 12:41 |
openstackgerrit | Roman Dobosz proposed openstack/nova master: allow compute nodes to be associated with host agg https://review.openstack.org/526753 | 12:41 |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add host to API and Conductor https://review.openstack.org/556513 | 12:42 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: [WIP] shared and nested allocation candidates https://review.openstack.org/556514 | 12:43 |
*** suresh12 has joined #openstack-nova | 12:43 | |
cdent | gerrit seems to be dragging a bit? | 12:47 |
*** odyssey4me has quit IRC | 12:47 | |
*** odyssey4me has joined #openstack-nova | 12:47 | |
kashyap | It's always dragging a bit | 12:47 |
kashyap | FFS, releasenotes still fails for reasons I can't see: http://logs.openstack.org/84/534384/14/check/build-openstack-releasenotes/4507437/job-output.txt.gz#_2018-03-26_10_58_14_063277 | 12:47 |
kashyap | Can anyone tell? (The original change: https://review.openstack.org/#/c/534384/) | 12:48 |
*** suresh12 has quit IRC | 12:48 | |
kashyap | (In unreleased.rst; it seems to be moaning about a "Literal block expected", thus treating a warning as an error.) | 12:48 |
*** dtantsur is now known as dtantsur|brb | 12:49 | |
efried | gibi: Responded. Let me know if you want to talk through the alternatives. | 12:49 |
*** hoonetorg has quit IRC | 12:49 | |
* kashyap goes to fix the "unreleased.rst" | 12:50 | |
*** pchavva has joined #openstack-nova | 12:50 | |
*** fragatina has quit IRC | 12:51 | |
*** sahid has quit IRC | 12:51 | |
*** psachin has quit IRC | 12:53 | |
kashyap | bauzas: You seem to have added the unreleased.rst file. I don't see anyone using it. Can it be deleted? | 12:53 |
kashyap | (That is the Nova commit: 4c2dfa5) | 12:53 |
bauzas | please, no. | 12:53 |
bauzas | it's used for good reasons | 12:53 |
bauzas | https://docs.openstack.org/releasenotes/nova/unreleased.html | 12:53 |
stephenfin | kashyap: The reno extension isn't reporting your issues correctly | 12:54 |
kashyap | bauzas: Do you spot what is the failure here: http://logs.openstack.org/84/534384/14/check/build-openstack-releasenotes/4507437/job-output.txt.gz#_2018-03-26_10_58_14_063277 | 12:54 |
stephenfin | *reno sphinx extension | 12:54 |
kashyap | stephenfin: Hmm, how can I put myself out of my misery, then? | 12:54 |
bauzas | I guess some relnote had a problem | 12:54 |
bauzas | hence the sphinx build error | 12:54 |
bauzas | but the rst page itself is empty | 12:54 |
bauzas | that's only reno which generates that file using the sphinx ext | 12:55 |
stephenfin | kashyap: This is what I did for oslo.config. The reno extension works the same way so the fix should be similar https://review.openstack.org/#/c/554632/ | 12:55 |
* kashyap clicks | 12:55 | |
gibi | efried: thanks, looking... | 12:55 |
stephenfin | kashyap: tl;dr: you need to keep an offset counter as you emit rST lines, and it's worth writing what you generate to temporary file so you can view it | 12:56 |
kashyap | Yeah, was reading this change: https://review.openstack.org/#/c/554632/1/oslo_config/sphinxext.py | 12:57 |
stephenfin | kashyap: I'm pretty sure there's a better way to do it (maybe dumping the offending lines to the terminal) but I haven't figure it out | 12:57 |
kashyap | Thanks for the summary. | 12:57 |
gibi | efried: thanks for the namespacing alternative. Will it mean that Neutron can say in the port that 'resources-neutron-1': {'BW': 10000} ? | 12:57 |
efried | gibi: Yeah, something like that. | 12:58 |
*** sahid has joined #openstack-nova | 12:58 | |
kashyap | stephenfin: Right now I don't have time to fix 'reno', I wonder what I can do to figure out what needs to be fixed in this:https://review.openstack.org/#/c/534384/14/releasenotes/notes/libvirt-cpu-model-extra-flags-a23085f58bd22d27.yaml | 12:58 |
efried | gibi: Since we haven't connected the final dots on granular even for intra-nova cases, we probably still have the flexibility to flip to using resources-nova-N there. | 12:58 |
edleafe | efried: Looks like you got your answer. I'm just dragging myself to start working at 8am. | 12:59 |
gibi | efried: so to keep ports separate it should look more like resources-neutron-<port-uuid> | 12:59 |
efried | or resources-flavor-N / resources-image-N | 12:59 |
gibi | or resources-port-<port-uuid> | 12:59 |
stephenfin | kashyap: It's ugly, but I'd strip it down and start adding parts until it stops working :/ | 13:00 |
kashyap | stephenfin: Hmm, is there a way locally verify that? Because, 'reno lint .` isn't catching what I need | 13:01 |
kashyap | (Lest I'll be stuck with this yak) | 13:01 |
stephenfin | 'tox -e releasenotes' should do the trick | 13:01 |
kashyap | stephenfin: But did I do anything "fancy" there? I'll see what I can "trip down" | 13:01 |
kashyap | stephenfin: I did run that | 13:01 |
kashyap | The _only_ thing that gave me was: | 13:01 |
stephenfin | and it worked? | 13:01 |
kashyap | stephenfin: This is what I see: http://paste.openstack.org/show/714071/ | 13:02 |
kashyap | stephenfin: The same warning I see in the Gate. | 13:03 |
kashyap | But it doesn't show any problems with my own file | 13:03 |
stephenfin | It probably is your file that's causing the issue though | 13:04 |
stephenfin | It's saying the error is in 'unreleased.rst', but that's just because that file contains the 'release-notes' directive | 13:04 |
kashyap | stephenfin: I see my content in the releasenotes/build/doctrees/unreleased.doctree | 13:04 |
kashyap | But nothing in the 'html' dir | 13:05 |
kashyap | Right | 13:05 |
stephenfin | yeah, there won't be anything in the html directory because the build failed | 13:05 |
kashyap | Right; I'll check w/ the #openstack-release folks | 13:06 |
*** hoonetorg has joined #openstack-nova | 13:06 | |
*** eharney has joined #openstack-nova | 13:09 | |
*** dikonoor has joined #openstack-nova | 13:10 | |
openstackgerrit | Merged openstack/nova master: Modify nova-manage cell_v2 list_cells to display "disabled" column https://review.openstack.org/555415 | 13:11 |
*** dikonoor has quit IRC | 13:15 | |
*** dikonoor has joined #openstack-nova | 13:16 | |
stephenfin | sahid: Done https://review.openstack.org/#/c/511188/ | 13:16 |
sahid | stephenfin: thanks, i will address your comments | 13:17 |
*** ttsiouts_ has joined #openstack-nova | 13:18 | |
*** lyan has joined #openstack-nova | 13:19 | |
*** awaugama has joined #openstack-nova | 13:19 | |
*** lyan is now known as Guest75421 | 13:19 | |
*** yamamoto has joined #openstack-nova | 13:20 | |
*** yamamoto has quit IRC | 13:20 | |
*** yamamoto has joined #openstack-nova | 13:20 | |
*** gouthamr has joined #openstack-nova | 13:23 | |
openstackgerrit | Merged openstack/nova master: Add disabled option to create_cell command https://review.openstack.org/555417 | 13:26 |
*** jroll has quit IRC | 13:27 | |
*** jroll has joined #openstack-nova | 13:27 | |
*** yangyapeng has quit IRC | 13:31 | |
*** belmorei_ has joined #openstack-nova | 13:31 | |
*** aloga_ has quit IRC | 13:31 | |
*** belmoreira has quit IRC | 13:33 | |
*** jaypipes has joined #openstack-nova | 13:35 | |
*** aloga_ has joined #openstack-nova | 13:35 | |
*** aloga_ has quit IRC | 13:37 | |
jaypipes | morning supernovas | 13:39 |
gibi | jaypipes: good morning | 13:39 |
Spazmotic | morning jay | 13:39 |
*** READ10 has joined #openstack-nova | 13:39 | |
*** mriedem has joined #openstack-nova | 13:40 | |
gibi | jaypipes: I added reasoning about the need of the vnic_type in https://review.openstack.org/#/c/502306/20/specs/rocky/approved/bandwidth-resource-provider.rst@396 please let me know what you think | 13:41 |
bauzas | jaypipes: morning | 13:41 |
bauzas | still working on updating my spec | 13:41 |
jaypipes | gibi: cool, will do right now. | 13:41 |
gibi | jaypipes: thanks | 13:42 |
*** elmaciej has quit IRC | 13:43 | |
stephenfin | kashyap: What was the fix? | 13:43 |
*** damien_r has quit IRC | 13:44 | |
kashyap | stephenfin: I'm embarassed to tell | 13:44 |
kashyap | stephenfin: But I will tell | 13:44 |
kashyap | stephenfin: A mis-quoting a CPU model like this: "'Foo" | 13:44 |
*** masuberu has joined #openstack-nova | 13:45 | |
kashyap | stephenfin: (s/mis-quoting a/mis-quoting of a/) And another spurious "::" | 13:45 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/534384 | 13:46 |
stephenfin | kashyap: aha. Good to hear you got it sorted :) | 13:47 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Add CPUWeigher https://review.openstack.org/379525 | 13:48 |
*** lpetrut_ has joined #openstack-nova | 13:48 | |
*** abalutoiu_ has joined #openstack-nova | 13:48 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Standardize '_get_XXX_constraint' functions https://review.openstack.org/385071 | 13:49 |
*** jmlowe has quit IRC | 13:49 | |
kashyap | sean-k-mooney: Do you spot anything else here: https://review.openstack.org/#/c/534384/ | 13:50 |
openstackgerrit | sahid proposed openstack/nova-specs master: update: isolate guests emulthreads on CONF.cpu_shared_set https://review.openstack.org/511188 | 13:50 |
kashyap | sean-k-mooney: I think it's ready for "prime time". I restricted the options for now to only PCID. | 13:50 |
*** mvk has quit IRC | 13:51 | |
kashyap | sean-k-mooney: (To keep it backportable; and in a future patch, remove that restriction, thus making way for other useful stuff.) | 13:51 |
*** lpetrut has quit IRC | 13:52 | |
*** abalutoiu has quit IRC | 13:52 | |
*** udesale has quit IRC | 13:53 | |
*** yangyapeng has joined #openstack-nova | 13:54 | |
*** hongbin has joined #openstack-nova | 13:55 | |
*** udesale has joined #openstack-nova | 13:55 | |
*** damien_r has joined #openstack-nova | 13:57 | |
*** jaosorior has quit IRC | 13:58 | |
*** jistr is now known as jistr|mtg | 14:02 | |
jaypipes | gibi: done | 14:03 |
*** yamamoto has quit IRC | 14:03 | |
edleafe | Scheduler subteam meeting running now in #openstack-meeting-alt | 14:03 |
*** beekneemech is now known as bnemec | 14:03 | |
*** burt has joined #openstack-nova | 14:04 | |
*** Zames has joined #openstack-nova | 14:04 | |
gibi | jaypipes: thanks, I will check after the scheduler meeting | 14:04 |
*** mlavalle has joined #openstack-nova | 14:05 | |
*** brault has joined #openstack-nova | 14:07 | |
*** Zames has quit IRC | 14:07 | |
*** Tom-Tom has joined #openstack-nova | 14:08 | |
*** moshele has quit IRC | 14:09 | |
*** Zames has joined #openstack-nova | 14:10 | |
*** r-daneel has joined #openstack-nova | 14:10 | |
*** Zames has quit IRC | 14:12 | |
*** masuberu has quit IRC | 14:12 | |
*** masuberu has joined #openstack-nova | 14:12 | |
*** archit has joined #openstack-nova | 14:15 | |
*** dtantsur|brb is now known as dtantsur | 14:15 | |
openstackgerrit | Konstantinos Samaras-Tsakiris proposed openstack/nova master: Add `hide_hypervisor_id` flavor extra_spec https://review.openstack.org/555861 | 14:17 |
*** sree_ has joined #openstack-nova | 14:17 | |
*** sree_ is now known as Guest5787 | 14:18 | |
*** felipemonteiro has joined #openstack-nova | 14:18 | |
*** Guest75421 has quit IRC | 14:18 | |
*** felipemonteiro_ has joined #openstack-nova | 14:20 | |
*** sree has quit IRC | 14:20 | |
*** jmlowe has joined #openstack-nova | 14:22 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Speed things up and document them https://review.openstack.org/534382 | 14:23 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove 'tools/releasenotes_tox.sh' https://review.openstack.org/534383 | 14:23 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Fix indentation https://review.openstack.org/556543 | 14:23 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Remove unnecessary configuration https://review.openstack.org/556544 | 14:23 |
*** felipemonteiro has quit IRC | 14:23 | |
*** mvk has joined #openstack-nova | 14:24 | |
*** lyan has joined #openstack-nova | 14:26 | |
*** lyan is now known as Guest22224 | 14:27 | |
*** jistr|mtg is now known as jistr | 14:27 | |
*** links has quit IRC | 14:32 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Use new-style choice values https://review.openstack.org/530924 | 14:34 |
*** markvoelker_ has joined #openstack-nova | 14:34 | |
*** bhujay has quit IRC | 14:34 | |
*** markvoelker has quit IRC | 14:35 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Add mypy target https://review.openstack.org/538221 | 14:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Store list of converted files https://review.openstack.org/538222 | 14:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.openstack.org/538224 | 14:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: zuul: Add 'mypy' job https://review.openstack.org/539168 | 14:35 |
mriedem | tssurya: this was merged out of order imo https://review.openstack.org/#/c/555417/ | 14:36 |
mriedem | since the scheduler patch to filter disabled cells isn't merged yet | 14:36 |
*** markvoelker has joined #openstack-nova | 14:37 | |
*** jobewan has joined #openstack-nova | 14:37 | |
*** ttsiouts_ has quit IRC | 14:38 | |
*** markvoelker_ has quit IRC | 14:39 | |
mriedem | i guess if we get https://review.openstack.org/#/c/550527/ in soon then it's not a big deal | 14:39 |
dansmith | I think these got re-ordered at some point, | 14:39 |
dansmith | because the doc patch is before the update_cell patch it talks about | 14:40 |
dansmith | so maybe just an accident | 14:40 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Remove duplicate 'vnc' config opt descriptions https://review.openstack.org/534724 | 14:41 |
stephenfin | mriedem: Fancy hitting that? ^ | 14:41 |
stephenfin | there's a couple of those in the old admin guide (as you've seen) | 14:41 |
mriedem | stephenfin: yeah after the scheduler meeting | 14:41 |
stephenfin | (y) | 14:41 |
mriedem | dansmith: ok that series should probably be rebased then, and the docs patch should come at the end | 14:42 |
mriedem | i'll look at the scheduler patch after the scheduling meeting | 14:42 |
dansmith | mriedem: I -1d the docs patch so it should be okay until after, | 14:42 |
dansmith | mriedem: it's actually not a linear set anymore | 14:42 |
mriedem | yeah i see that now, which is why the create_cell change merged probably | 14:42 |
mriedem | anywho | 14:43 |
*** prometheanfire has left #openstack-nova | 14:43 | |
dansmith | yeah, not a huge deal to me, but whatever you want | 14:43 |
mriedem | johnthetubaguy: can i get you to come back on this nova-status ironic flavor migratoin patch? https://review.openstack.org/#/c/527541/ | 14:43 |
kashyap | Dan / Matt, when you get a moment, does this look better? https://review.openstack.org/#/c/534384/15/nova/virt/libvirt/driver.py | 14:43 |
kashyap | (Tests pass, and also release note builds.) | 14:43 |
mriedem | i don't think we can drop the ironic flavor migration stuff in the driver until nova-status has a check for it | 14:43 |
mriedem | kashyap: what happened to putting a 'choices' or hard-coding the only option to pcie for the backport? | 14:43 |
mriedem | not a different option, but restricting the single choice for the backport and then opening it up on master | 14:44 |
kashyap | mriedem: Yep, that's what I did. But, the check is in driver.py | 14:44 |
mriedem | oh | 14:44 |
kashyap | mriedem: That's exactly what I did :-) | 14:44 |
mriedem | why not 'choices' kwarg on the config option itself? | 14:44 |
kashyap | Because, there's no 'choices' for ListOpt() for Oslo class | 14:44 |
efried | see dev ML :) | 14:44 |
kashyap | Only for StrOpt(0 | 14:44 |
efried | kashyap: Propose it! | 14:44 |
mriedem | ok, i guess that doesn't surprise me | 14:45 |
dansmith | man the queues are deep | 14:45 |
kashyap | efried: Heh :-) Haven't checked the list responses yet, still ploughing through other stuff | 14:45 |
efried | I don't know if anyone responded thusly. That was off the cuff. | 14:45 |
kashyap | dansmith: Hey, since you're a stickler for words, I'd love if you see any grammatical mistakes in the release note (I spent 3 hours writing it) | 14:46 |
kashyap | dansmith: 'Grr'it is slow for me; but here's a quick-loading file: https://review.openstack.org/#/c/534384/15/nova/virt/libvirt/driver.py | 14:46 |
kashyap | Err, "wrong" URL :P -- https://kashyapc.fedorapeople.org/libvirt-cpu-model-extra-flags-a23085f58bd22d27.yaml.txt | 14:46 |
tssurya | mriedem: oops | 14:46 |
tssurya | mriedem: I guess they did get merged out of order | 14:47 |
dansmith | kashyap: in a bit | 14:48 |
tssurya | dansmith, mriedem: dansmith has a comment on the debug stuff in the main filter patch, | 14:48 |
tssurya | I will fix it and we can merge that soon | 14:48 |
*** yamahata has quit IRC | 14:49 | |
kashyap | dansmith: No rush at all. In an hour-ish, I'll be disappearing to my Dutch class, so I'll respond to questions on the review (if you have them) | 14:49 |
*** tbachman has joined #openstack-nova | 14:49 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Unit test framework: common FakeResponse https://review.openstack.org/556551 | 14:53 |
*** felipemonteiro_ has quit IRC | 14:53 | |
*** felipemonteiro__ has joined #openstack-nova | 14:53 | |
efried | mriedem: You are interested in this ^ | 14:53 |
* efried declares with confidence | 14:53 | |
*** esberglu has joined #openstack-nova | 14:54 | |
mriedem | i am interested in that yes | 14:54 |
*** gcb has joined #openstack-nova | 14:54 | |
*** mdnadeem has quit IRC | 14:54 | |
efried | mriedem: (While I was reviewing https://review.openstack.org/#/c/556334/1/nova/tests/unit/network/test_neutronv2.py) | 14:55 |
mriedem | yeah i figured | 14:55 |
mriedem | i was going to get there eventually | 14:55 |
efried | mriedem: But note that I implemented it differently than the one in test_identity. | 14:55 |
openstackgerrit | Tyler Blakeslee proposed openstack/nova master: Add __repr__ for NovaException https://review.openstack.org/555812 | 14:56 |
mriedem | fix the typo and i'm +2 | 14:58 |
*** cdent has quit IRC | 14:59 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Unit test framework: common FakeResponse https://review.openstack.org/556551 | 15:00 |
efried | mriedem: Done. Though I kinda like 'evalue'. | 15:00 |
gibi | jaypipes: do you have a minute for discussing the vnic_type issue or you prefer to have my reply in the review? | 15:00 |
*** germs has quit IRC | 15:00 | |
tssurya | dansmith, mriedem: do you guys have some time now for a question ? | 15:03 |
*** sree has joined #openstack-nova | 15:03 | |
dansmith | tssurya: shoot | 15:03 |
*** yamamoto has joined #openstack-nova | 15:03 | |
mriedem | efried: i lied | 15:04 |
tssurya | dansmith: regarding adding the "queued_for_delete" column | 15:04 |
tssurya | to handle a down cell, | 15:04 |
tssurya | does it need a spec ? | 15:04 |
efried | mriedem: you lying liar | 15:04 |
rybridges | mriedem: The example of an AttributeError being raised in the Python terminal that you showed on Friday is not meaningful at all. Of course it will throw an exception at the Python CLI. What you did does not represent how Neutron executes the code. Neutron wraps that call with the eventlet spawn_n() method which blanket catches all exceptions and prints them to stderr rather than using the standard | 15:04 |
rybridges | Python logging framework. | 15:04 |
rybridges | This means that exceptions thrown within eventlet loops will not be logged to files that are setup in a deployer's standard logging conf. Long story short, exceptions ARE actually being masked / swallowed which is why we had this problem. See my patch which improves the error handling: https://review.openstack.org/#/c/556120/ | 15:04 |
efried | mriedem: Ah, nice finds | 15:04 |
tssurya | the use cases are nova list, nova service-list and blocking VM creations if a user has VMs in the down cell | 15:05 |
tssurya | however each of this has a bug opened | 15:05 |
dansmith | tssurya: yeah I think it probably should be a spec because there will be lots of behavioral changes to describe ... | 15:05 |
tssurya | so was wondering if it needs a spec, since the only common part would be adding the new column to the instance_mapping table | 15:05 |
tssurya | dansmith: ah okay, | 15:05 |
tssurya | also are we going to consider melwitt's proposal of adding user_id as well ? | 15:06 |
tssurya | since she said that is the only info missing for calculating per project per user quptas | 15:06 |
tssurya | quotas* | 15:06 |
*** Guest5787 has quit IRC | 15:06 | |
belmorei_ | are user quotas something that nova will continue to support? | 15:07 |
dansmith | tssurya: is that related to the down-cell behavior thing? I thought that solved one of the quota issues, but not enough to calculate enough of the quota to enable booting when a cell is down | 15:07 |
dansmith | tssurya: regardless, if you think it's related and/or should be done at the same time, that's a thing to document the justification for in the spec I think | 15:07 |
dansmith | belmorei_: I think we have some we have to support because of history right? | 15:08 |
dansmith | belmorei_: I don't have those details in my head, so maybe we should discuss when melwitt is awake | 15:08 |
tssurya | dansmith: yea sure, the reason I was asking about the user_id is if its going to be incorporated then it changes the solution I would be proposing in this spec for VM booting | 15:09 |
mriedem | keypairs | 15:09 |
mriedem | keypair quota is based on user_id, not project_id | 15:09 |
*** chyka has joined #openstack-nova | 15:10 | |
dansmith | tssurya: yeah, so maybe it needs to be two specs, I dunno, I don't have it all in my head right now, so just use your judgment about whether or not to include it or mention it as a related effort I guess | 15:10 |
mriedem | https://github.com/openstack/nova/blob/master/nova/quota.py#L1248 | 15:10 |
belmorei_ | mriedem right, missed that | 15:10 |
tssurya | dansmith: so without the user_id, it would be something like - user can spawn new VMs if he/she doesn't have any in the cell which is down, with the user_id it would be done from placement and VM booting can be allowed even if the user has VMs in the down cell | 15:10 |
tssurya | dansmith: yea will do that | 15:10 |
tssurya | and consult melwitt | 15:11 |
tssurya | when she is awake | 15:11 |
gibi | jaypipes: I'm falling back replying to you in the spec as I have to go offline soonish | 15:11 |
dansmith | tssurya: oh you mean user_id in placement for calculating quotas? | 15:11 |
mriedem | we can't use placement for quota calculations | 15:11 |
mriedem | not yet anyway | 15:11 |
dansmith | yeah, I thought you meant user_id on something else.. instance mapping or something | 15:11 |
tssurya | dansmith: trying to find the mailing list email in which melwitt was talking about this | 15:11 |
tssurya | yes its about adding user_id to instance_mapping table | 15:12 |
*** danpawlik has quit IRC | 15:12 | |
dansmith | hmm, okay, well, idk | 15:12 |
tssurya | but using placement db for quotas calculation | 15:12 |
dansmith | probably two specs though | 15:12 |
tssurya | so that we no longer depend on individual cell_db's | 15:12 |
dansmith | yeah, that placement quotas thing is a larger can of worms, | 15:12 |
dansmith | don't depend on that for your queued_for_delete thing | 15:12 |
*** moshele has joined #openstack-nova | 15:13 | |
tssurya | dansmith: http://lists.openstack.org/pipermail/openstack-dev/2018-March/128334.html | 15:14 |
tssurya | dansmith: yes okay then will do a spec without thinking about ^^ | 15:14 |
*** yamamoto has quit IRC | 15:15 | |
dansmith | tssurya: we can sneak that column in so we just have one db migration to add both, but the actual work is a separate spec I think | 15:16 |
tssurya | dansmith: yea I agree, | 15:16 |
*** kmalloc has quit IRC | 15:16 | |
*** pcaruana has quit IRC | 15:18 | |
*** derekh has quit IRC | 15:19 | |
gibi | jaypipes: replied in https://review.openstack.org/#/c/502306 but I have to go offline in 5. I will check your reply tomorrow morning | 15:21 |
mriedem | stephenfin: https://review.openstack.org/#/c/534724 drops a lot of info | 15:21 |
stephenfin | mriedem: Fair points. I'll address those | 15:22 |
stephenfin | Thanks for the review (y) | 15:22 |
gibi | Kevin_Zheng: I left some suggestion in https://review.openstack.org/#/c/553288 | 15:23 |
*** mdnadeem has joined #openstack-nova | 15:24 | |
mriedem | tssurya: figured out why you can't run nova-api without having [database]/connection setup http://logs.openstack.org/46/555346/2/check/tempest-full/69cf0dc/controller/logs/screen-n-api.txt.gz#_Mar_24_00_53_19_452955 | 15:25 |
mriedem | tssurya: File "/opt/stack/nova/nova/api/openstack/wsgi_app.py", line 49, in _setup_service is not multi-cell aware | 15:25 |
mriedem | belmorei_: ^ | 15:25 |
*** imacdonn has joined #openstack-nova | 15:26 | |
mriedem | that code should likely just lookup the cell0 mapping and use it's context | 15:26 |
tssurya | mriedem: ah okay | 15:27 |
kashyap | dansmith: Responded; I'm not quite sure if a soft log warning would suffice... | 15:27 |
belmorei_ | mriedem thanks | 15:28 |
openstackgerrit | Eric Fried proposed openstack/nova master: Unit test framework: common FakeResponse https://review.openstack.org/556551 | 15:28 |
efried | mriedem: Done. More red! Yay! | 15:29 |
kashyap | dansmith: Also, about verbosity in the `reno`, I was aware of it; but I was not merely describing _what_ are those 3 modes. | 15:29 |
tssurya | mriedem: thanks for spotting it | 15:29 |
*** david-lyle has joined #openstack-nova | 15:29 | |
kashyap | dansmith: Rather, what would Operators want to do in context of the three modes Nova allows. | 15:29 |
kashyap | (As I've lost count on other Virt lists & IRC where people have asked about it.) | 15:29 |
kashyap | That said ... happy to snip it, and add it to a separate blog post or something. I'm all for brevity with clarity. | 15:30 |
dansmith | kashyap: ask someone else, but IMHO, it's about 500% too wordy | 15:31 |
kashyap | dansmith: Folks on #openstack-release said it reads very well, FWIW. smcginnis and dhellmann reviewed it | 15:31 |
dansmith | kashyap: cool, but I think it's too much | 15:31 |
kashyap | dansmith: I can cut it down. But I'd rather want to definitely retain the info about what an Operator would do with each of the 3 modes | 15:32 |
kashyap | It _certainly_ makes sense. As it's a completely valid question that will come up. | 15:32 |
kashyap | (As not everyone dwells on it.) | 15:32 |
dansmith | kashyap: that's fine, but I'll still be -1 on it | 15:32 |
kashyap | I'd rather first get someone else's view too in Nova. | 15:33 |
*** sahid has quit IRC | 15:34 | |
*** _ix has joined #openstack-nova | 15:34 | |
dansmith | kashyap: didn't I say ask someone else? :) | 15:34 |
*** cdent has joined #openstack-nova | 15:34 | |
kashyap | Sure :-) | 15:34 |
* kashyap AFK; bbiab | 15:35 | |
dansmith | efried: are you looking for me to add aggregates to ResourceRequest, or just to slap it into the result of resources_from_request_spec? because it seems like that function does some weirdness where it requests some resource group and then jams extra resources into the result | 15:35 |
dansmith | efried: this specifically: https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L334 | 15:36 |
dansmith | I guess it's returning some internal object and then jamming the resource request in there | 15:36 |
efried | dansmith: That bit is for special handling of the "default resource classes". Wouldn't think aggregates would play in there. | 15:37 |
dansmith | efried: yeah, I'm trying to figure out where aggregates go and reading that is confusing to me | 15:37 |
efried | dansmith: Anyway, yeah, I was looking for ResourceRequest to get an agg field (similar to the traits field) which would be populated based on the request spec. | 15:37 |
dansmith | efried: you want an setter method on ResourceRequest that takes aggregates? | 15:37 |
efried | ...using the code you already done wrote. | 15:37 |
dansmith | or can I just set res_req.aggregates = [] | 15:37 |
dansmith | ? | 15:37 |
dansmith | like, resources_from_request_spec() seems like it should be a classmethod on ResourceRequest, but it's not so I'm trying to figure out how much of "friends" they are | 15:38 |
efried | dansmith: um, looks like I already have member_of on RequestGroup . | 15:38 |
dansmith | okay and I don't really get the RequestGroup thing | 15:39 |
dansmith | and that comes out of placement, | 15:39 |
*** bhujay has joined #openstack-nova | 15:39 | |
*** andreas_s has quit IRC | 15:39 | |
dansmith | so in that case, I _would_ actually do aggregates like the extra resources are getting jammed in there? | 15:40 |
dansmith | res_req.get_request_group(None).member_of = aggregates ? | 15:40 |
*** andreas_s has joined #openstack-nova | 15:40 | |
*** ragiman has quit IRC | 15:40 | |
*** jobewan has quit IRC | 15:40 | |
efried | yeah | 15:40 |
dansmith | mkay | 15:40 |
dansmith | I don't really get what this is doing, but.. as you wish | 15:40 |
efried | dansmith: It's the framework for granular. | 15:40 |
dansmith | ah, and that's what ident is then.. okay | 15:41 |
efried | dansmith: Puts in one place the parsing of the extra specs into the RequestGroups which will feed into the placement call. | 15:41 |
dansmith | efried: so, RequestGroup doesn't have much schema, so do you want me to: | 15:42 |
dansmith | grp.member_of = ['foo,bar', 'baz'] | 15:42 |
dansmith | or | 15:42 |
dansmith | grp.member_of = [('foo','bar'), ('baz',)] | 15:42 |
dansmith | ? | 15:42 |
efried | dansmith: Guess it depends on how that spec shakes out :P | 15:42 |
*** david-lyle has quit IRC | 15:42 | |
jaypipes | gibi: hey, sorry, went to get something to eat. I'll respond on the spec. | 15:43 |
openstackgerrit | Matthew Booth proposed openstack/nova-specs master: Add serial numbers for local disks https://review.openstack.org/556565 | 15:43 |
dansmith | efried: I don't think it really does, this is just the internal way we communicate the request to report client right? | 15:43 |
*** afaranha has quit IRC | 15:43 | |
dansmith | efried: I'm not really sure why this lives in placement.lib I mean | 15:43 |
dansmith | because later that will be out of tree and we won't use it to communicate with our own reportclient I think | 15:43 |
efried | dansmith: yeah. I think the sooner we get to the list-of-tuples representation, the better. So option 2 | 15:43 |
dansmith | mkay | 15:43 |
efried | dansmith: It's just because RequestGroup is used by both nova side and placement side. | 15:44 |
efried | on the placement side, we parse the incoming querystring into the exact same representation. | 15:44 |
*** jobewan has joined #openstack-nova | 15:44 | |
dansmith | yeah, this seems like code sharing we should be removing so that we don't have any ties | 15:44 |
efried | It's like... having a serializable object without having a serializable object. | 15:44 |
efried | dansmith: Well, cdent is aware, and was involved in the review process (I think). I imagine there will come a time when there will be a placement_lib module that both of them will import. | 15:45 |
dansmith | I don't see why we'd use that to communicate between internal components of nova, unless it provides a lot of pre-calculation of things or something, which it does not do now, | 15:45 |
*** david-lyle has joined #openstack-nova | 15:46 | |
dansmith | but just be advised how hard it will be to land changes to that across both projects and update requirements and such before you can use a new thing if we go that route | 15:46 |
cdent | I think I expressed reservations at the time, but mostly shrugged in a "we'll figure it out" and "if it helps now, cool" kind of way. | 15:46 |
dansmith | this provides zero help in its current form, IMHO :) | 15:46 |
*** bhujay has quit IRC | 15:47 | |
efried | dansmith: Well, only because we haven't closed the final switches on granular yet. | 15:47 |
cdent | It helps on the placement side to decode the query string, but on the nova side, dunno. I'm not paying huge amounts on the nova side as it is just too hard to keep track of _all_ things | 15:47 |
cdent | yeah, I think it is groundwork for stuff that was expected sooner than turned out | 15:47 |
efried | dansmith, cdent: On the nova side it lets us parse extra_specs; on the placement side it lets us parse the querystring. On both sides they parse into the same representation. | 15:48 |
efried | which is (or will be) useful). | 15:48 |
efried | )) | 15:48 |
efried | ((( | 15:48 |
dansmith | cdent: it's just a class with a few variables righ tnow | 15:48 |
dansmith | anyway, I'm just pre-complaining, nothing that is going to block me right now | 15:48 |
*** andreas_s has quit IRC | 15:48 | |
*** fragatina has joined #openstack-nova | 15:49 | |
cdent | dansmith: yeah, I know. I'm mostly speaking generally: I've de-prioritized my attention to the nova side of things for sake of being able to get anything done | 15:49 |
*** damien_r has quit IRC | 15:50 | |
*** yamahata has joined #openstack-nova | 15:53 | |
*** andreas_s has joined #openstack-nova | 15:54 | |
openstackgerrit | melissaml proposed openstack/nova master: fix a typo in service.py https://review.openstack.org/556575 | 15:55 |
openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/556418 | 15:56 |
*** rnoriega has quit IRC | 15:56 | |
*** jaosorior has joined #openstack-nova | 15:56 | |
openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM: Add proc_units_factor conf option https://review.openstack.org/554688 | 15:57 |
*** rnoriega has joined #openstack-nova | 15:57 | |
*** pchavva has quit IRC | 15:57 | |
*** weshay has quit IRC | 15:57 | |
openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM: Add proc_units_factor conf option https://review.openstack.org/554688 | 15:57 |
*** kashyap has quit IRC | 15:58 | |
*** belmorei_ has quit IRC | 15:59 | |
*** kashyap has joined #openstack-nova | 16:02 | |
*** weshay has joined #openstack-nova | 16:02 | |
*** liverpooler has quit IRC | 16:02 | |
*** pchavva has joined #openstack-nova | 16:02 | |
*** gcb has quit IRC | 16:03 | |
*** bhujay has joined #openstack-nova | 16:04 | |
mriedem | like killing mosquitoes https://review.openstack.org/#/c/556575/ | 16:06 |
mriedem | https://review.openstack.org/#/c/545528/ | 16:06 |
mriedem | https://review.openstack.org/#/c/555404/ | 16:07 |
mriedem | geez | 16:07 |
mriedem | yay! | 16:07 |
mriedem | efried: "Note that some people are opposed to typo-in-comment-or-docstring patches. It's a religious thing, I think. So don't be surprised if this gets the kibosh." heh | 16:07 |
mriedem | i'm not opposed to fixing documentation if it makes the documentation more clear, i am opposed to stat padding py pushing several 1-line spell check fixes across openstack at random | 16:08 |
mriedem | *by pushing | 16:08 |
*** felipemonteiro__ has quit IRC | 16:09 | |
*** yangyapeng has quit IRC | 16:10 | |
efried | mriedem: I thought we didn't put enough stock in stats to make that the sole reason for rejecting things like this. IMO patches like this could be fast-approved more quickly than they can be squashed. And let the author have the stats - what difference does it really make? | 16:10 |
efried | Anyway, that's my 2c | 16:10 |
mriedem | it's not the sole reason | 16:10 |
stephenfin | I'd be more lenient. If it doesn't cause merge conflicts, it's good and could be conceivably fast approved. If someone's basing their employee reviews on Stackalytics, they're the fools | 16:10 |
mriedem | it's also noise | 16:10 |
*** yangyapeng has joined #openstack-nova | 16:11 | |
efried | Meh, how much noise is it really? Are you worried about an explosion of trivial patches if you start approving these? | 16:11 |
mriedem | imo it encourages bad behavior | 16:12 |
cdent | FWIW I agree with efried | 16:13 |
cdent | the only thing that should matter in the end is the quality of the code | 16:13 |
stephenfin | cdent: With the caveat that it's trivial and doesn't cause merge conflicts. Functional changes still have to take priority | 16:14 |
efried | I agree there's a balance to be struck against reviewer time. In this case, it's eta/eta | 16:14 |
*** yamahata has quit IRC | 16:14 | |
*** david-lyle has quit IRC | 16:14 | |
efried | (or whatever greek letter means "something really small") | 16:14 |
bauzas | gosh, I'm about to ragequit because of all the NUMA quirks we need to support | 16:15 |
stephenfin | bauzas: You're welcome :) | 16:15 |
bauzas | faking cpu sockets for licensing reasons => booooh | 16:15 |
bauzas | the question I wonder is, should https://docs.openstack.org/nova/latest/admin/cpu-topologies.html#customizing-instance-cpu-topologies be Placement-specific ? | 16:16 |
bauzas | my guts say no | 16:16 |
bauzas | stephenfin: jaypipes: thoughts on that ? | 16:16 |
stephenfin | What do you mean, "placement-specific"? | 16:17 |
bauzas | Resource classes and other things | 16:17 |
*** udesale has quit IRC | 16:17 | |
bauzas | IMHO, we should just provide the NUMA topology, find a node and period. | 16:17 |
jaypipes | bauzas: on a call... gimme a bit. | 16:17 |
stephenfin | bauzas: It doesn't affect what you need to claim so IMO no | 16:17 |
*** udesale has joined #openstack-nova | 16:17 | |
bauzas | yup, cool | 16:17 |
stephenfin | but jaypipes might have other ideas, once he's free | 16:17 |
*** andreas_s has quit IRC | 16:18 | |
openstackgerrit | Merged openstack/nova master: Fix api-ref: nova image-meta is deprecated from 2.39 https://review.openstack.org/554813 | 16:18 |
*** masuberu has quit IRC | 16:18 | |
bauzas | efried: question, can I ask for both a resource query on a root node *and* a child RP ? | 16:22 |
*** andreas_s has joined #openstack-nova | 16:22 | |
* bauzas trying to wrap his head around a loooong transition period for having all the NUMA features checked by Placement queries | 16:23 | |
efried | bauzas: The only place you can ask for resources that span RPs is in the un-numbered request group. | 16:23 |
bauzas | ideally, I'd love to see something like MEMORY_MB on both the root RP *and* the NUMA node | 16:23 |
bauzas | efried: can you please explain further ? | 16:24 |
efried | bauzas: Are those separate blocks of memory? | 16:24 |
bauzas | I dunno yet | 16:24 |
bauzas | (tbh) | 16:24 |
*** ktibi has quit IRC | 16:24 | |
bauzas | I'm just hardly trying to not lock all the world | 16:24 |
efried | IMO we should not try to do the thing where we have e.g. 2048MB of memory in each NUMA node and then represent 4096MB on the compute node which isn't really there. | 16:25 |
bauzas | like I'd like to provide a mechanism to select a NUMA node but huge pages could still be checked by the virt driver | 16:25 |
*** salv-orl_ has quit IRC | 16:25 | |
bauzas | efried: I got your point, my problem is more about trying hard to not draw a house of cards | 16:26 |
*** salv-orlando has joined #openstack-nova | 16:26 | |
efried | bauzas: is there a fixed ratio between memory MB and number of huge pages? | 16:26 |
*** moshele has quit IRC | 16:26 | |
bauzas | efried: the solution is simple in my mind | 16:26 |
bauzas | that's all about traits and step_size | 16:26 |
bauzas | but | 16:26 |
*** sambetts is now known as sambetts|afk | 16:26 | |
bauzas | if we go decide to provide a tree of NUMA nodes | 16:26 |
bauzas | but we don't support yet hugepages, then we have a problem because flavors asking for hugepages would get NoValidHosts | 16:27 |
*** gyee has joined #openstack-nova | 16:27 | |
bauzas | we somehow still need to accept compute nodes to report their memory the old way | 16:28 |
efried | what's a hugepage? | 16:28 |
efried | (use little words) | 16:28 |
bauzas | https://docs.openstack.org/nova/latest/admin/huge-pages.html | 16:28 |
bauzas | it's a defined memory page size | 16:28 |
bauzas | but that's just an example | 16:28 |
bauzas | for the moment, placement only checks the total memory of the host, right? | 16:28 |
bauzas | then the scheduler filter does magic things to find a destination | 16:29 |
*** suresh12 has joined #openstack-nova | 16:29 | |
efried | Well, yeah, so this is kind of in line with what we need to do wrt bandwidth. | 16:29 |
efried | We represent the number of huge pages as inventory alongside the MEMORY_MB inventory. | 16:29 |
efried | but | 16:29 |
efried | if the consumer is going to include hugepages as part of their request, they *always* need to do so. | 16:30 |
bauzas | so, my concern is that if I'm beginning to shard the memory between NUMA nodes, then it requires the flavors to be updated to explicitly ask for a NUMA node, whereas huge pages are totally NUMA unrelated | 16:30 |
*** salv-orlando has quit IRC | 16:30 | |
efried | because what we can't (or shouldn't) do is try to convert a request for MEMORY_MB:4096 into MEMORY_MB:4096,HUGEPAGES:4 (or whatever) | 16:30 |
bauzas | efried: I'm not trying to design now how to make placement queries for hugepages | 16:31 |
efried | bauzas: But does a huge page come from the same place as a MEMORY_MB or is it a separate thing? | 16:31 |
*** masuberu has joined #openstack-nova | 16:31 | |
bauzas | efried: what I'm trying is to make sure we keep a compatible behaviour for the existing feature | 16:31 |
bauzas | others, later, will try to solve that design and use placement resources for that | 16:32 |
bauzas | like the PCPU spec | 16:32 |
efried | bauzas: okay, maybe we back up and I just answer your original question :) | 16:33 |
bauzas | but again, what I want is to make sure that if operators enable reporting of NUMA nodes using NRPs, then it can still be possible to use hugepages flavors for finding a destination | 16:33 |
*** bhujay has quit IRC | 16:34 | |
efried | You can specify multiple resources of different classes in a request group. A numbered request group will get *all* of those resources from the *one* resource provider. The un-numbered request group will get the resources from any provider in a tree or associated sharing providers. However, even in the latter case, all resources of a specific resource *class* will still come from a single provider. | 16:34 |
*** suresh12 has quit IRC | 16:35 | |
*** udesale has quit IRC | 16:35 | |
*** andreas_s has quit IRC | 16:36 | |
*** germs has joined #openstack-nova | 16:36 | |
*** germs has quit IRC | 16:36 | |
*** germs has joined #openstack-nova | 16:36 | |
*** lucasagomes is now known as lucas-afk | 16:37 | |
*** sree has quit IRC | 16:38 | |
*** srini_ has quit IRC | 16:38 | |
bauzas | efried: I see, thanks | 16:39 |
bauzas | so that could work | 16:40 |
bauzas | if I'm providing a NUMA topology through nested RPs, placement will give me a resource provider that supports that memory | 16:40 |
*** germs has quit IRC | 16:41 | |
*** trozet has joined #openstack-nova | 16:42 | |
bauzas | efried: from a scheduler perspective, when it finds a nested resource provider as a destination when calling Placement API, I guess it uses the root RP for passing it down to the filters ? | 16:42 |
*** srini_ has joined #openstack-nova | 16:43 | |
efried | bauzas: We haven't fully closed the switch on that yet, but yes, even if zero resource comes from the root RP, it'll still be the thing used as the "destination host". Not sure if that's a full answer to your question. Because filtering might need more info than that. | 16:43 |
efried | I'm guessing the entire allocation_request will need to be considered for some filters. | 16:43 |
*** pcaruana has joined #openstack-nova | 16:44 | |
bauzas | efried: that's the problem I see with NUMA filter | 16:44 |
bauzas | efried: because say placement finds a NUMA node, then it will return the child to the scheduler on a classic call | 16:44 |
bauzas | eg. a regular flavor | 16:45 |
bauzas | so we need to pass down the root RP | 16:45 |
bauzas | but then, the NUMA filter could try to find another NUMA node instead of using the one allocated | 16:45 |
efried | bauzas: Correlating the allocation_request with the provider_summary ought to allow you to figure out which NUMA node the resources were allocated from. | 16:46 |
efried | But yeah, without further invention, only the virt driver will know which RP UUID corresponds to which NUMA node. | 16:46 |
*** dklyle has joined #openstack-nova | 16:47 | |
bauzas | that's not really the problme | 16:47 |
efried | ...which is kind of appropriate, because "identifying a NUMA node" is a virt-specific thing. | 16:47 |
efried | I.e. libvirt is gonna do it a different way than hyperv or whatever. | 16:47 |
bauzas | the problem is, say you ask for 2GB of memory within a NUMA node, then placement gives you host A with 2 NUMA nodes but only one NUMA node for host B | 16:48 |
bauzas | because the other NUMA node of host B is full | 16:48 |
bauzas | then, we need to pass to the scheduler filters the root RP | 16:48 |
bauzas | in theory, when it goes on NUMA filter for host B, it could consider the second NUMA node for host B as legit | 16:49 |
bauzas | there be dragons | 16:49 |
*** dklyle has quit IRC | 16:49 | |
*** david-lyle has joined #openstack-nova | 16:49 | |
efried | how could it? | 16:50 |
efried | There's no candidate with allocations in that second NUMA node on host B. | 16:50 |
sean-k-mooney | bauzas: there might be dragons but the host state object for host b should also know that the second numa node is fully used and ignore it | 16:50 |
sean-k-mooney | bauzas: what is an issue if both numa nodes are valid and the filter chooses the other one form placement | 16:51 |
sean-k-mooney | e.g. placement decremetes the inventor that corresponds to node 0 but the numa topology filter decrements node 1 | 16:51 |
bauzas | okay, then I'm maybe overthinking | 16:51 |
*** yangyapeng has quit IRC | 16:52 | |
sean-k-mooney | bauzas: there is an edge case here but its for host A with 2 NUMA not host B with 1 | 16:52 |
*** kmalloc has joined #openstack-nova | 16:52 | |
sean-k-mooney | for host b the resouce tracker will have updted the numatoplogy blob to also show the second numa nodes as full but in the case of host A both are valid from its point of view | 16:53 |
*** lpetrut_ has quit IRC | 16:54 | |
bauzas | I guess my fears are coming from the fact we litterally try to draw something out of nowhere, and without good testing for making sure we don't trample folks | 16:55 |
*** sree has joined #openstack-nova | 16:55 | |
openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class https://review.openstack.org/549053 | 16:55 |
bauzas | if I was able to just test what I write, I wouldn't be trying to consider all the edge cases | 16:55 |
*** gjayavelu has joined #openstack-nova | 16:55 | |
*** david-lyle has quit IRC | 16:55 | |
*** andreas_s has joined #openstack-nova | 16:55 | |
openstackgerrit | Eric Berglund proposed openstack/nova master: WIP: PowerVM Driver: Localdisk https://review.openstack.org/549300 | 16:55 |
*** tssurya has quit IRC | 16:56 | |
bauzas | and I just feel I'm just trying to sink all the ocean's water | 16:56 |
*** suresh12 has joined #openstack-nova | 16:57 | |
sean-k-mooney | bauzas: i think you have raised a valid issue here. the virt driver will likely need to tag the resouce providres with a trait or aggregat to allow it to map its internal view(in the resouce tracker/numa toploygy bob) to the view it gets back in the allocation canditates | 16:57 |
bauzas | sean-k-mooney: how do you see that ? | 16:58 |
*** sree has quit IRC | 16:59 | |
*** JunoMan is now known as penick | 16:59 | |
sean-k-mooney | how would you do it? when the virt driver create the RP for the numanode in the provider tree update it would include a CUSTOM_HOST_NUMA_ID_X trait where X is its internal identify for the numa node e.g. 0 or 1 | 16:59 |
*** rmart04 has quit IRC | 16:59 | |
sean-k-mooney | then in the allocation canditates resoponce the numa topology filter can use that trait to map the the correct cell in the numa topology blob | 17:00 |
*** mdnadeem has quit IRC | 17:00 | |
sean-k-mooney | you could also use an agregate but that would be harder to map to the topoploy blob unless we add teh aggregate uuid to the blob | 17:00 |
bauzas | sean-k-mooney: ouch. | 17:01 |
sean-k-mooney | that trait/aggreage would be uses soly by the virtdriver/filter and never passed in any request to placement | 17:01 |
*** suresh12 has quit IRC | 17:01 | |
bauzas | sean-k-mooney: the problem is that the virt.hardware module is a pleasure to modify | 17:02 |
bauzas | I'd really want to avoid any subsequent modification | 17:02 |
sean-k-mooney | bauzas: yes well if we use a trait then we dont need to modify it | 17:03 |
sean-k-mooney | we just need to modify the update provider tree stuff to also include the cell id | 17:03 |
sean-k-mooney | as a trait on the numa node | 17:03 |
bauzas | not sure I'm getting you | 17:04 |
sean-k-mooney | i have not looked but im assumeing the numa patches where going to use the info from the numa topology blob to create teh RPs for the NUMA node and the sub resouces of that node | 17:04 |
bauzas | because the virt.hardware module gets a topology from both the hoststate and the instance proposed topolgy | 17:04 |
bauzas | here, we would need to hack the module to look at the resource providers, right ? | 17:05 |
bauzas | instead of the host state | 17:05 |
bauzas | anyway, I'm running out of fuel for my brain | 17:06 |
sean-k-mooney | bauzas: i think we would need to pass in the allocation candiates to the filter yes and then pass that down into the fit_instance_to_host fucntion or whatever it is called so that it could make a descission based on the allcoation candiate | 17:06 |
bauzas | right, that's what I meant | 17:07 |
*** masuberu has quit IRC | 17:07 | |
sean-k-mooney | ya that fuction is a pain to modify or debug but its going to need to be scoped to the allocation candiate to work correct when numa is in placement | 17:07 |
*** ralonsoh has quit IRC | 17:08 | |
*** archit has quit IRC | 17:08 | |
*** andreas_s has quit IRC | 17:09 | |
*** liverpooler has joined #openstack-nova | 17:09 | |
jaypipes | bauzas, stephenfin, sean-k-mooney, efried: sorry, done with call now. | 17:09 |
*** yassine has quit IRC | 17:09 | |
* jaypipes reads back | 17:09 | |
bauzas | jaypipes: I'm just rat-holing | 17:10 |
bauzas | my concern is, how to make sure we can still have all the NUMA features be workable in a world with nested RPs albeit all things solved in the future++ with placement resources | 17:11 |
sean-k-mooney | jaypipes: the issue is basically how to correlate placement RPs with the compute node resouce tracker so that when the the numa topology filter or pining code runs we only look at the resouce selected by placement in the allocation candidate and not all numa nodes for example. | 17:12 |
*** mdbooth has quit IRC | 17:12 | |
*** moshele has joined #openstack-nova | 17:12 | |
*** andreas_s has joined #openstack-nova | 17:14 | |
*** AlexeyAbashkin has quit IRC | 17:15 | |
*** dtantsur is now known as dtantsur|afk | 17:15 | |
*** david-lyle has joined #openstack-nova | 17:18 | |
jaypipes | efried: iota? | 17:20 |
*** moshele has quit IRC | 17:23 | |
*** david-lyle has quit IRC | 17:25 | |
*** lpetrut_ has joined #openstack-nova | 17:25 | |
*** szaher has joined #openstack-nova | 17:25 | |
*** salv-orlando has joined #openstack-nova | 17:26 | |
*** srini_ has quit IRC | 17:27 | |
*** salv-orlando has quit IRC | 17:31 | |
*** tssurya has joined #openstack-nova | 17:31 | |
jaypipes | sean-k-mooney: I don't think it's really a big issue. Basically, let the NUMA topology filter just run as-is. It will "pick" a NUMA node to pin the instance to (and then promptly forget about its pick). The scheduler will claim resources against one of the NUMA nodes on the host (via the normal allocation request claim_resources() process). The build request gets to the compute host. During the instance_claim() process, the numa_fit_instance_to_ | 17:33 |
jaypipes | host() is run again. If that picks a different NUMA node than what is in the allocation_request that is sent along with the build request, then we raise an exception and just retry the scheduling. | 17:33 |
dansmith | efried: so, questions about L371 here: https://review.openstack.org/#/c/547990/10/nova/scheduler/client/report.py | 17:35 |
dansmith | efried: what 406 are you talking about? | 17:35 |
dansmith | the only one I know of is if the version isn't supported that we need for member_of | 17:35 |
dansmith | efried: and, I'm only running the intersection and setting of the member_of if aggregates is non-empty, which is what you're saying I'll need to do | 17:36 |
sean-k-mooney | jaypipes: thats one option be se should really not have to retry here | 17:36 |
sean-k-mooney | jaypipes: we should be able to just look at the cell that was selected by placement | 17:36 |
sean-k-mooney | also when numa_fit_instance_to_host runs how to you tell if it picked a different node to the one in the allocation_request if you cant correlate between them | 17:38 |
efried | dansmith: The functionality you want is to be able to do the set logic on aggregates. We plan to allow placement to do that via some new syntax (your pending spec delta). Once that happens, there'll be a microversion for that. And at that time, if you try to use that new microversion, you'll also have to handle the case where placement is downlevel, just like we do everywhere else where we might be straddling versions. | 17:39 |
edleafe | efried: is there a spec/bp/bug for adding the consumer generation? | 17:40 |
efried | dansmith: And what I'm saying is that the 406 branch will have to do the placement query without taking member_of into account (or using the intersection thing as a prefilter) and then do the set logic on the candidates that come back for that too-broad query. | 17:40 |
dansmith | efried: why? the last couple times we've bumped that version we have't supported an older placement | 17:40 |
efried | Whoah. Yes, we do, every time. | 17:41 |
dansmith | efried: we've been saying placement goes first in the upgrade stack | 17:41 |
efried | edleafe: Not as of the last time I checked, which I think was yesterday. | 17:41 |
dansmith | efried: where? that code has changed several times while I was working on this and we don't have any fallback code there | 17:41 |
*** suresh12 has joined #openstack-nova | 17:41 | |
efried | dansmith: I think we say that as a best practice or something, but we've got somewhere else that defines the minimum placement microversion for a given release and it's always lower than the maximum for same release. mriedem help me out here. | 17:42 |
jaypipes | dansmith: example? the code has changed in a backwards *incompatible* way and we don't have fallback code? | 17:42 |
efried | dansmith: Just look for 406 in report.py | 17:42 |
efried | cdent culled the stale ones at the end of Queens, so there aren't many left, but still some. | 17:42 |
dansmith | jaypipes: the last couple of times this exact method has changed | 17:42 |
sean-k-mooney | efried: the grenagde job in the gate is proably upgradeing placement first so even if it could work its proably not tested today | 17:43 |
*** r-daneel has quit IRC | 17:43 | |
dansmith | I can go actually dig up reviews if you care | 17:43 |
edleafe | efried: yeah, I didn't see anything either. So would you call this a bug fix or a new feature? | 17:43 |
dansmith | efried: why are we using different initial versions for any of those calls then? | 17:43 |
efried | edleafe: needs a bp fo sho | 17:43 |
edleafe | efried: ok. Is there any discussion I can refer to? I'm not clear on the reasons for doing this | 17:44 |
efried | dansmith: Because the newer way is usually more efficient or similar; and it gives us an easier delta when we do bump the min | 17:44 |
cdent | edleafe: needs a spec, is a new feature and an api change | 17:44 |
dansmith | efried: jaypipes this one is the one I have in my head right now: https://review.openstack.org/#/c/536085/9/nova/scheduler/client/report.py | 17:45 |
cdent | edleafe: if you want to chat about a bit later this evening I can do a bit of a brain dump on you if you want | 17:45 |
cdent | but in the midst of something at the moment | 17:45 |
edleafe | cdent: you mean you haven't dumped it in an email yet? :) | 17:45 |
dansmith | efried: the problem is that if placement doesn't go first, scheduler depends on it for az calculation, then we have to fail any request that cares about az if placement doesn't support 1.21 _anyway_ | 17:46 |
cdent | no, because I was trying not to own this one. I did have a to do list item which said "write email about consumer uuid" but deleted it when you "got ownershipw of this" :) | 17:46 |
*** andreas_s has quit IRC | 17:47 | |
edleafe | cdent: ah, I was just volunteering my cycles to code it. If I gotta write a spec, I should at least understand the motivation behind it. | 17:47 |
edleafe | (that usually helps) :) | 17:47 |
efried | edleafe: I got you, gimme sec | 17:47 |
cdent | edleafe: details! but yeah, I can dump some brain shortly if efried doesn't beat me to it | 17:47 |
jaypipes | dansmith: you will note I did not review that. | 17:47 |
dansmith | jaypipes: so cdent was culling all the microversions when, at the end of each release? | 17:49 |
efried | dansmith, jaypipes: Agree that one should have had the 406-fallback conditions. I shoulda reviewed it too, but didn't. IIRC that got jammed in really late in Q because we weren't going to make granular happen in time. | 17:49 |
dansmith | jaypipes: so you want a bunch of microversion handling code for within-release changes? | 17:49 |
cdent | jaypipes, dansmith: we've been inconsistent about our expectation with nova-side microversion fallback. I've not been able to discern a pattern, mostly because _some_ of the time we say "we expect placement to upgrade first" at which point why bother falling back? | 17:49 |
cdent | I didn't cull them all, just anything less than 1.14 (I think it was 1.14, would need to check to be sure) | 17:49 |
dansmith | cdent: yeah I see some places where we do fallback, and some where we don't | 17:49 |
dansmith | cdent: it was 1.14 | 17:49 |
jaypipes | dansmith: I'm just noting I did not review that patch (didn't know about it at all). I believe I was in Dallas that week. | 17:50 |
*** r-daneel has joined #openstack-nova | 17:50 | |
jaypipes | dansmith: I do support the reportclient supporting fallback code (406 handling) for at least a release, yes. | 17:50 |
dansmith | so what do you people propose? scheduler fails if you request an az and placement is old? fall back but make sure the old filter is enabled otherwise fail? | 17:50 |
jaypipes | dansmith: yes, that sounds reasonable to me. | 17:51 |
dansmith | jaypipes: we're not testing nova against an older placement, so it basically doesn't work | 17:51 |
dansmith | jaypipes: seriously? that was a joke :) | 17:51 |
*** wolverineav has joined #openstack-nova | 17:51 | |
dansmith | well, the second part was a joke | 17:51 |
dansmith | maybe you mean the first part? | 17:51 |
dansmith | but that doesn't seem very friendly to me | 17:51 |
jaypipes | dansmith: well, the "make sure the old filter is enabled" was a joke, right? | 17:51 |
*** wolverineav has quit IRC | 17:52 | |
dansmith | yes | 17:52 |
sean-k-mooney | jaypipes: as other service start using placement it will likely make sense to have placement upgrade early in the sequence. is there a reason you do not want to commit to placement before nova in general? | 17:52 |
*** wolverin_ has joined #openstack-nova | 17:52 | |
jaypipes | dansmith: the "fail if placement doesn't support the az filter" wasn't. | 17:52 |
dansmith | jaypipes: I think if we're adding code for all those branches we need a grenade test where we leave placement behind on queens and run master against it | 17:52 |
efried | dansmith: I think what I'm saying is that nova can support the AZ filter even without support for GET /a_c?member_of= | 17:53 |
dansmith | like we did for nova-compute | 17:53 |
dansmith | otherwise it's broken | 17:53 |
*** felipemonteiro has joined #openstack-nova | 17:53 | |
efried | dansmith: And if we need to support N-1 release of placement in nova, we've gotta write that code "the hard way". | 17:53 |
dansmith | efried: it can if you leave the post-processing filter enabled | 17:53 |
mriedem | efried: nova-status has a min placement API version check | 17:53 |
jaypipes | sean-k-mooney: if the change in the placement API is backwards compatible (which a *new* query param is), I don't see a reason to fixate an upgrade to always do placement first. | 17:53 |
dansmith | efried: yeah, I'm asserting we do not | 17:53 |
efried | mriedem: So the discussion here is: why isn't that minimum version always the same as the max-in-release? | 17:53 |
*** archit has joined #openstack-nova | 17:54 | |
mriedem | because the nova side code might not be using the max yet | 17:54 |
*** felipemonteiro_ has joined #openstack-nova | 17:54 | |
dansmith | mriedem: in most cases it's not | 17:54 |
efried | mriedem: Under what circumstances? Haven't we always said you have to upgrade placement first? | 17:54 |
mriedem | generally it likely is because we added the new placement api versions for things nova needs | 17:54 |
sean-k-mooney | jaypipes: that is true but it appears we are not quite to that point yet. as dan said we likely need a gate job that leaves placement on N-1 to validate it works if that is the guareentee we want to give | 17:54 |
dansmith | mriedem: that's why I'm saying we might as well use the same default microversion in the whole file if we're going to require this, which i think defeats a lot of the point of microversioning this at all | 17:55 |
mriedem | see first bullet in #2 here https://docs.openstack.org/nova/latest/user/upgrade.html#rolling-upgrade-process | 17:55 |
mriedem | i haven't been paying attention to this conversation so don't have context | 17:55 |
*** owalsh_ is now known as owalsh | 17:56 | |
dansmith | so by the same argument, | 17:56 |
dansmith | if a flavor has any required trait in it, | 17:56 |
sean-k-mooney | mriedem: that likely should be expanded to "before and openstack service that uses placement" rather then nova but ya. | 17:56 |
dansmith | we must fail if placement doesn't support 1.17 for that rev I linked above | 17:57 |
mriedem | sean-k-mooney: these are nova upgrade docs... | 17:57 |
dansmith | sean-k-mooney: those are nova upgrade notes | 17:57 |
dansmith | heh | 17:57 |
efried | dansmith: Or write a post-filter. Yeah. | 17:57 |
sean-k-mooney | hehe ok fair point :) | 17:57 |
dansmith | efried: we can't do that, AFAIK | 17:57 |
mriedem | dansmith: i thought we did fail if a flavor has required traits in it but 1.17 isn't available? | 17:57 |
dansmith | efried: filters don't have access to the actual a-c I don't think | 17:57 |
dansmith | mriedem: we do, but they are arguing that it should fall back to 1.14 | 17:58 |
efried | dansmith: I'm not talking about a Filter. Talking about code in the report client that manually does the trait filtering. | 17:58 |
dansmith | and I'm saying I don't know what we do in that case, because 1.14 isn't enough | 17:58 |
mriedem | i disagree, | 17:58 |
mriedem | if the flavor has required traits, the admin is saying, 'i require traits for this flavor so make it happen or fail' | 17:58 |
*** felipemonteiro has quit IRC | 17:58 | |
dansmith | mriedem: agreed, and same for my aggregate requirement | 17:58 |
dansmith | there's no point in falling back | 17:58 |
efried | dansmith: Except that putting a trait in a flavor is a new thing the admin would do. | 17:59 |
mriedem | https://docs.openstack.org/nova/latest/user/flavors.html has something about required traits but doesn't say we fail explicitly if 1.17 isn't available | 17:59 |
dansmith | efried: so? | 17:59 |
efried | dansmith: But AZ filtering is something we're trying to make compatible with existing setups... no? | 17:59 |
dansmith | efried: but we can't test for membership from the client side | 18:00 |
dansmith | efried: at least not providing the same semantics the user is expecting | 18:00 |
dansmith | we can approximate it by looking in nova's notion of the aggregate, but it's not the same | 18:00 |
efried | dansmith: Sure, why not? That method has received the list of aggregate UUIDs. We can glean RP UUIDs by looking at placement. We just do the filtering on the client side rather than at the placement server. | 18:01 |
efried | I mean, it's likely to be horribly inefficient. | 18:01 |
dansmith | mriedem: that text implies NoValidHost if we can't find RPs with the traits requested, which is even less obvious about why it's failing | 18:01 |
efried | mriedem: TBC, I think we agree it was a miss that this issue wasn't considered one way or another in that traits review. We're kind of post-morteming what we *should* have done there. | 18:01 |
dansmith | well, fwiw, I had been assuming what our docs say, which is placement goes first | 18:02 |
efried | s/glean RP UUIDs/glean aggregate UUIDs for those RPs/ | 18:02 |
*** salv-orlando has joined #openstack-nova | 18:02 | |
cdent | Is there a reason we can't assume placement goes first? | 18:02 |
cdent | I mean can we decide today that's how it is going to be? | 18:03 |
dansmith | or acknowledge that we already did? :) | 18:03 |
mriedem | efried: eh? if placement 1.17 isn't available for required traits in a flavor, i think we should fail | 18:03 |
cdent | dansmith: well, sure, yeah | 18:03 |
efried | mriedem: That seems like a reasonable decision to me. I wasn't necessarily advocating for anything else, just pointing out that there are other options. | 18:04 |
*** mvk has quit IRC | 18:04 | |
efried | ableit sucky ones. | 18:04 |
dansmith | efried: BS you were too :) | 18:04 |
efried | dansmith: Well I certainly was advocating for that in the case of your patch. | 18:04 |
dansmith | <efried>Whoah. Yes, we do, every time. | 18:04 |
dansmith | ^ | 18:04 |
dansmith | heh, okay | 18:04 |
efried | dansmith: Yeah, that was before I realized we had screwed the pug on the traits one. | 18:05 |
mriedem | for the traits one, the pug needed to get laid imo | 18:05 |
mriedem | not every case is a fallback situation | 18:05 |
dansmith | right | 18:05 |
efried | I (now) agree with that. | 18:05 |
efried | But dansmith I'm still needing to be told that it won't represent a regression if we go the failure path in the agg filtering case. | 18:06 |
efried | Like, does an existing flavor in an existing cloud quit working because we made this path fail (if they don't have recent placement)? | 18:07 |
dansmith | az is per user request | 18:07 |
dansmith | nothing to do with flavor | 18:07 |
dansmith | in this case | 18:07 |
efried | same thing as far as I'm concerned. Clouds have scripts. Or orchestrators, or whatever. That expect it to work a certain way. | 18:07 |
efried | If we put a real stake in the ground about upgrading placement first, it's moot. We can rip out the existing 406 code, never have to implement it again going forward. | 18:08 |
dansmith | okay I'm not sure what you're looking for here | 18:08 |
dansmith | efried: as mriedem said, I'm not opposed to all failback code | 18:08 |
dansmith | by any means, but this one has no legit alternate path imho | 18:09 |
efried | I would love to see us say placement must always be upgraded first. I just wasn't aware that was even a possibility. | 18:09 |
dansmith | for example, | 18:09 |
dansmith | the compute code paths may be able to tolerate older or newer placement because they're mostly just massaging data into the right format, | 18:09 |
dansmith | and we changed POST (or GET) once already and meh they can handle it | 18:09 |
dansmith | but this is more than just format and it's something the scheduler is hard depending on | 18:09 |
dansmith | so, I can use 1.17 if no aggregates are required, and only request 1.21 if they are, if you think that's better, but I don't think falling back to 1.17 is a thing for this | 18:10 |
dansmith | so we'll tolerate older placement if we don't need it, | 18:10 |
*** tesseract has quit IRC | 18:10 | |
dansmith | although that just means the operator says "half these requests work, wtf?" | 18:10 |
dansmith | and, I think if we're going to do any of that, we need a real grenade test where the service is left unupgraded | 18:11 |
dansmith | otherwise we have nfi if it works or not | 18:11 |
jaypipes | -1 just because efried just said "screwed the pug" | 18:11 |
efried | I was wondering when you would catch up with that. | 18:11 |
* jaypipes having ten conversations at once | 18:11 | |
efried | dansmith: My concern is this: will there be some script "out there" that says "do this AZ thing" that works on Queens, and then when they upgrade to Rocky, that same script will no longer work IF they're downlevel placement. | 18:12 |
dansmith | efried: yeah and I don't see that as a problem | 18:13 |
efried | And if the answer is yes, are we accepting that and our response would be "go upgrade placement" | 18:13 |
dansmith | efried: if the rule is placement goes first | 18:13 |
dansmith | efried: any idea how much will break if you upgrade nova-compute and nothing else? | 18:13 |
efried | dansmith: Then w00t and let's update the docs (mandatory) and let's rip out all the fallback code (optional) and let's forget anyone ever mentioned a grenade test. | 18:13 |
efried | dansmith: And in this case, use 1.21 and be done. | 18:14 |
efried | dansmith: Although actually it'll be 1.2x whenever the list-of-tuples business is approved and written. | 18:14 |
sean-k-mooney | efried: well if you boot a vm via horizon i think it forces you to specify an availablity zone so if nova has a hard dependcy on 1.21 for AZs to work that would break horizon booted vms if you did not upgrade placement | 18:14 |
dansmith | efried: see, I don't think that's the way to go.. using 1.21 means every time I need to bump the level for g-a-c, I have to go fix all the other code in that file which is perfectly fine with 1.1 | 18:14 |
dansmith | efried: that's the whole point of microversions, as I see it.. that you don't need to do that | 18:15 |
efried | dansmith: I'm talking about using 1.2x for just this method, not for the whole file. | 18:15 |
dansmith | efried: you opt into new features (and maintenance) on a per-call basis as you need it | 18:15 |
*** jmlowe has quit IRC | 18:15 | |
dansmith | efried: ack, okay | 18:15 |
*** jmlowe_ has joined #openstack-nova | 18:15 | |
efried | dansmith: But I *am* saying the fallback code elsewhere in the file (two places, I think) becomes dead and can be removed. | 18:15 |
jaypipes | right, exactly. | 18:15 |
dansmith | jaypipes: who are you agreeing with? | 18:16 |
jaypipes | dansmith: you. | 18:16 |
jaypipes | "you opt in ..." | 18:16 |
dansmith | jaypipes: okay I'm totes confused about where you sit on this then ;) | 18:16 |
efried | I was agreeing with that too. So everybody agrees. | 18:16 |
*** yamahata has joined #openstack-nova | 18:16 | |
jaypipes | dansmith: I guess my butt hurts from the fence. | 18:16 |
* dansmith walks away, wide-eyed | 18:17 | |
jaypipes | dansmith: on the one hand I don't want to *always* force users to upgrade placement first when it's not necessary to. on the other hand, I see the futility of operators upgrading nova-scheduler first, placement second and having a time when some requests involving AZs suddenly start failing. | 18:18 |
*** lpetrut_ has quit IRC | 18:18 | |
jaypipes | dansmith: I was referring to sitting on the fence, there... | 18:18 |
jaypipes | in case that wasn't obvious ;) | 18:19 |
dansmith | jaypipes: yeah, and I also don't think operators are at all complaining about having a clear order of services for upgrades | 18:19 |
sean-k-mooney | jaypipes: well we would only be frocing them to upgrade placement first if they need a placement feature in nova | 18:19 |
*** wolverin_ has quit IRC | 18:19 | |
jaypipes | dansmith: ok, then I'm cool with all of this, then. :) | 18:19 |
jaypipes | carry on. | 18:19 |
dansmith | aight | 18:19 |
jaypipes | sorry for being dense. | 18:19 |
sean-k-mooney | dansmith: well from an install tool poing of view ya most installers would perfer to always have a clear order of operations even if it wasnt strictly required. | 18:20 |
efried | jaypipes: Ugh, why is maxlength for a RP name 200? (As opposed to 255, like for trait and RC?) | 18:20 |
dansmith | sean-k-mooney: in the early days of making nova upgrade smoothly, that was the #1 request.. "just tell me which order and I'll do it." | 18:20 |
jaypipes | efried: UGH. Why would you need an rp name longer than 200 characters. UGH! | 18:21 |
efried | jaypipes: Sorry, the ugh was because inconsistent with trait/RC. | 18:21 |
sean-k-mooney | dansmith: i think that is still the case although "keep it running without any downtime magically while i upgrade" may have over taken it | 18:21 |
jaypipes | efried: no idea | 18:21 |
efried | cdent: any idea? | 18:22 |
sean-k-mooney | efried: its saves you half a KB per RP? do you have a reason to have a name over 200 | 18:23 |
cdent | well, rp name came first, so I reckon it was arbitrary decision at the time and then when custom traits and resource classes came along people expressed concern about wanting to make them super long and 255 some some random compromise. AKA: I don't think there were _reasons_ as such | 18:23 |
efried | sean-k-mooney: No. I'm writing code to sanitize RP/RC/trait names and the inconsistency is gonna make me write >1 method instead of just 1. | 18:24 |
sean-k-mooney | efried: or jsut assume make 200 for all names | 18:24 |
sean-k-mooney | there is no harm in makeing it a 255 lenght however you would need a sql schema update which likely is not worth it for this allow | 18:25 |
* cdent suspects efried is optimizing again, rather than letting the api tell him when things are wrong | 18:25 | |
cdent | ? | 18:25 |
melwitt | tssurya: hey, thanks for bringing up the user_id column in instance_mappings table thing. I agree it should be a separate spec to handle the "quota when cell-down" issue. I have an old spec for it that I can resurrect. my spec will depend on yours because I also need the queued_for_delete column | 18:25 |
tssurya | melwitt: okay, :) I guess we can co-ordinate on this then, I will let you know as soon as I put up a spec for it then. | 18:27 |
melwitt | tssurya: cool, thank you :) | 18:27 |
efried | cdent: Not quite. I was reviewing 520313 which has code that will wind up sending down an RP name that will fail - https://review.openstack.org/#/c/520313/23/nova/tests/unit/virt/xenapi/test_driver.py@443. Letting the API fail in this case will be worse than suboptimal, because by the time that happens, we're outside of where virt can do anything about it. | 18:27 |
efried | cdent: This isn't the first time I've seen a need for a method to "slugify" a placement identifier, so I thought I would write it. | 18:27 |
tssurya | melwitt: the only concern I have is that at the PTG, we discussed that we would not use placement and do a solution of allowing the users to create VMs if they don't have any in the down cell | 18:28 |
cdent | efried: I was teasing | 18:28 |
cdent | gentle ribbing and all that | 18:28 |
melwitt | tssurya: you mean disallowing? | 18:28 |
tssurya | melwitt: however if we are going to use placement, then this changes things i guess | 18:28 |
efried | cdent: It's a valid concern that you should check me on constantly, even though (or perhaps especially because) you and I fundamentally disagree on whether such pre-optimizations are desirable. | 18:28 |
efried | cdent: But in this case, it's more than that. | 18:29 |
tssurya | melwitt: no, I mean allowing VM creation as long as there are no living VMs in the down cell | 18:29 |
tssurya | melwitt: since in that case the quota calculation will be correct | 18:29 |
melwitt | tssurya: yeah, that was when we had thought being able to count instances while cells are down would require adding a "type" to placement allocations. that is something that will take a lot of work to figure out | 18:29 |
cdent | Fair enough. I never really said they are not desierable, I suggested that they should wait for the road to show they are needed. | 18:29 |
sean-k-mooney | efried: maybe just take the lenght as an optional param that you defalt to 255 and the caller can set 200 or what ever if they no its less for that field | 18:29 |
tssurya | melwitt: ah okay, so then I will do a spec for queued_for_delete and we can take it from there then | 18:30 |
melwitt | tssurya: yeah. we had said that because at the time we were thinking to remove the dependency on reading cell databases, we would have to add a "type" to placement allocations and that was not going to be straightforward and needed a lot more time and design | 18:31 |
*** mvk has joined #openstack-nova | 18:32 | |
tssurya | melwitt: hmm yea now I remember, thanks! | 18:32 |
*** vipul has quit IRC | 18:32 | |
melwitt | tssurya: but when I was thinking about it later, if we have queued_for_delete (from your spec) that was the main missing piece preventing us from being able to count instances in the instance_mappings table. the other piece is user_id | 18:32 |
melwitt | the "queued_for_delete" column was controversial in the past, but now that it's not, it opens that door again | 18:33 |
tssurya | melwitt: yea I agree, I guess I will go ahead with the queued_for_delete and will leave out the user_id for a separate spec and we (you) can battle out adding the "type" with the placement guys later | 18:33 |
melwitt | user_id I think is not controversial because we already have project_id, I'm actually not sure why we didn't add user_id too | 18:33 |
tssurya | melwitt: the reason I was asking for the user_id is because I could do these two in the same spec if you want like dansmith said its one migration | 18:34 |
melwitt | tssurya: sounds good | 18:34 |
melwitt | tssurya: yeah, I agree with him that it can be one migration, just two specs where each problem being solved for down cells is described in detail separately | 18:35 |
melwitt | just so it's easier to organize | 18:35 |
tssurya | melwitt: cool, I was waiting to get your opinion too, so I will do it in two specs, one for nova-list/service-list when a cell is down, second for quotas when a cell goes down, however I won't touch any from placement | 18:36 |
tssurya | calculations since you already have a spec | 18:36 |
*** germs has joined #openstack-nova | 18:37 | |
melwitt | tssurya: okay, won't that mean we would have three specs then? I was thinking I would just roll the "add user_id column" stuff into the spec I have https://review.openstack.org/#/c/509042 | 18:37 |
melwitt | and then also add reference to your spec where it depends on your queued_for_delete column | 18:38 |
tssurya | melwitt: oh yes that's fine with me | 18:38 |
tssurya | melwitt: so I will do one single spec with queued_for_delete, | 18:38 |
tssurya | melwitt: sounds good ? | 18:39 |
melwitt | tssurya: yep sounds good | 18:39 |
tssurya | melwitt: thank you | 18:39 |
*** yamahata has quit IRC | 18:39 | |
openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk https://review.openstack.org/549300 | 18:40 |
*** germs has quit IRC | 18:42 | |
*** jobewan has quit IRC | 18:42 | |
*** AlexeyAbashkin has joined #openstack-nova | 18:42 | |
*** jobewan has joined #openstack-nova | 18:44 | |
*** fragatina has quit IRC | 18:45 | |
*** fragatina has joined #openstack-nova | 18:45 | |
*** pcaruana has quit IRC | 18:46 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Add request filter functionality to scheduler https://review.openstack.org/544730 | 18:52 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add aggregates list to Destination object https://review.openstack.org/544729 | 18:52 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make get_allocation_candidates() honor aggregate restrictions https://review.openstack.org/547990 | 18:52 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add an index on aggregate_metadata.value https://review.openstack.org/555851 | 18:52 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method https://review.openstack.org/544728 | 18:52 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | 18:52 |
openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282 | 18:52 |
*** AlexeyAbashkin has quit IRC | 18:54 | |
*** voelzmo has joined #openstack-nova | 18:54 | |
*** fragatina has quit IRC | 18:57 | |
*** voelzmo has quit IRC | 19:00 | |
*** yangyapeng has joined #openstack-nova | 19:02 | |
*** yangyapeng has quit IRC | 19:07 | |
*** moshele has joined #openstack-nova | 19:10 | |
*** trozet has quit IRC | 19:11 | |
*** AlexeyAbashkin has joined #openstack-nova | 19:14 | |
*** voelzmo has joined #openstack-nova | 19:15 | |
*** moshele has quit IRC | 19:15 | |
imacdonn | mriedem or toabctl : either of you around ? | 19:16 |
*** AlexeyAbashkin has quit IRC | 19:18 | |
imacdonn | mriedem toabctl In case you show up while I'm at lunch:) Regarding https://github.com/openstack/nova/commit/3a3b0f09db318faf1a1ea711a73bb365cab8b233 - I think we have the same issue with the "image" service, if glance.api_servers is not configured (which is recommended) | 19:19 |
*** ccamacho|PTO has quit IRC | 19:21 | |
imacdonn | efried: your name is on this too :) https://github.com/openstack/nova/blob/master/nova/image/glance.py#L114-L116 | 19:21 |
mriedem | imacdonn: 'image' is already in that list https://github.com/openstack/nova/commit/3a3b0f09db318faf1a1ea711a73bb365cab8b233#diff-c83f1fae2a677ed29036e293dd0e63caR121 | 19:23 |
efried | yeah, what he said. | 19:23 |
mriedem | devstack doesn't set glance.api_servers either | 19:23 |
imacdonn | oh yeah, I'm blind | 19:23 |
imacdonn | I wonder why I'm getting this, then... | 19:23 |
imacdonn | 2018-03-26 19:00:54.238 46339 ERROR nova.compute.manager [instance: 41164565-c7a2-4f96-9fcf-222847ecf113] File "/usr/lib/python2.7/site-packages/nova/image/glance.py", line 126, in get_api_servers | 19:24 |
imacdonn | 2018-03-26 19:00:54.238 46339 ERROR nova.compute.manager [instance: 41164565-c7a2-4f96-9fcf-222847ecf113] endpoint = utils.get_endpoint(ksa_adap) | 19:24 |
imacdonn | 2018-03-26 19:00:54.238 46339 ERROR nova.compute.manager [instance: 41164565-c7a2-4f96-9fcf-222847ecf113] File "/usr/lib/python2.7/site-packages/nova/utils.py", line 1373, in get_endpoint | 19:24 |
imacdonn | 2018-03-26 19:00:54.238 46339 ERROR nova.compute.manager [instance: 41164565-c7a2-4f96-9fcf-222847ecf113] "interfaces: %s" % interfaces) | 19:24 |
imacdonn | 2018-03-26 19:00:54.238 46339 ERROR nova.compute.manager [instance: 41164565-c7a2-4f96-9fcf-222847ecf113] EndpointNotFound: Could not find requested endpoint for any of the following interfaces: ['internal', 'public'] | 19:24 |
mriedem | i probably know why | 19:24 |
mriedem | https://review.openstack.org/#/c/554703/ | 19:24 |
imacdonn | 4 days ago, eh? that seems plausible | 19:25 |
imacdonn | will have to see if I'm doing something "the old way" ... removed the api_servers option to try to be current :) | 19:26 |
*** READ10 has quit IRC | 19:27 | |
imacdonn | I guess maybe it's the code, not me ... not using versioned notifications | 19:27 |
*** salv-orlando has quit IRC | 19:31 | |
mriedem | this isn't about versioned notifications | 19:31 |
mriedem | it's about notifications sent during periodic tasks where we don't have a token | 19:31 |
*** salv-orlando has joined #openstack-nova | 19:31 | |
imacdonn | You comment says "there isn't much the operator can do about it outside of (1) switching entirely to versioned notifications, which not many people are using yet if at all, or ...." | 19:32 |
openstackgerrit | Eric Fried proposed openstack/nova master: Slugification utilities for placement names https://review.openstack.org/556628 | 19:32 |
efried | cdent: For nosey parkers ^ | 19:32 |
*** fragatina has joined #openstack-nova | 19:32 | |
*** salv-orlando has quit IRC | 19:37 | |
*** harlowja has joined #openstack-nova | 19:37 | |
*** voelzmo_ has joined #openstack-nova | 19:38 | |
openstackgerrit | melanie witt proposed openstack/nova master: Migrate tempest-dsvm-multinode-live-migration job in-tree https://review.openstack.org/555945 | 19:39 |
*** fragatina has quit IRC | 19:41 | |
*** voelzmo has quit IRC | 19:42 | |
openstackgerrit | Eric Fried proposed openstack/nova master: doc: Upgrade placement first https://review.openstack.org/556631 | 19:42 |
efried | mriedem, jaypipes, dansmith, sean-k-mooney cdent edleafe ^ | 19:42 |
*** yamamoto has joined #openstack-nova | 19:45 | |
*** voelzmo_ has quit IRC | 19:46 | |
*** salv-orlando has joined #openstack-nova | 19:46 | |
*** yamamoto has quit IRC | 19:50 | |
*** danpawlik has joined #openstack-nova | 19:50 | |
*** voelzmo has joined #openstack-nova | 19:51 | |
*** voelzmo has quit IRC | 19:51 | |
*** voelzmo has joined #openstack-nova | 19:51 | |
*** voelzmo_ has joined #openstack-nova | 19:52 | |
*** cdent is now known as nosey_parker | 19:54 | |
* nosey_parker shakes fist at efried | 19:54 | |
*** nosey_parker is now known as cdent | 19:54 | |
*** voelzmo has quit IRC | 19:55 | |
*** moshele has joined #openstack-nova | 19:56 | |
*** EmilienM has quit IRC | 19:57 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Get rid of 406 paths in report client https://review.openstack.org/556633 | 19:57 |
efried | mriedem, jaypipes, dansmith, sean-k-mooney cdent edleafe and ^ | 19:57 |
efried | dev ML note coming soon | 19:57 |
*** EmilienM has joined #openstack-nova | 19:57 | |
cdent | efried is a stack not a queue | 19:57 |
efried | cdent: Too true, much to my dismay. | 19:58 |
cdent | takes all kinds | 19:58 |
*** awaugama has quit IRC | 19:59 | |
*** yassine has joined #openstack-nova | 20:01 | |
*** voelzmo_ has quit IRC | 20:02 | |
*** voelzmo has joined #openstack-nova | 20:02 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "bind_ports_to_host" neutron API method https://review.openstack.org/523604 | 20:02 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423 | 20:02 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370 | 20:02 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170 | 20:02 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947 | 20:02 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333 | 20:02 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334 | 20:02 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371 | 20:02 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Port binding based on events during live migration https://review.openstack.org/434870 | 20:02 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | 20:02 |
openstackgerrit | Matt Riedemann proposed openstack/osc-placement stable/queens: Migrate legacy-osc-placement-dsvm-functional job in-tree https://review.openstack.org/556635 | 20:05 |
*** liverpooler has quit IRC | 20:08 | |
*** suresh12 has quit IRC | 20:09 | |
*** suresh12 has joined #openstack-nova | 20:09 | |
mriedem | esberglu: why is tempest.api.compute.servers.test_attach_interfaces.AttachInterfacesTestJSON.test_create_list_show_delete_interfaces_by_network_port[id-73fe8f02-590d-4bf1-b184-e9ca81065051,network] skipped in https://review.openstack.org/#/c/546813/ ? | 20:09 |
*** jobewan has quit IRC | 20:11 | |
*** suresh12 has quit IRC | 20:14 | |
*** trozet has joined #openstack-nova | 20:15 | |
openstackgerrit | Merged openstack/nova master: Standardize '_get_XXX_constraint' functions https://review.openstack.org/385071 | 20:15 |
*** felipemonteiro__ has joined #openstack-nova | 20:16 | |
*** felipemonteiro_ has quit IRC | 20:16 | |
*** suresh12 has joined #openstack-nova | 20:19 | |
*** r-daneel has quit IRC | 20:21 | |
*** edmondsw has quit IRC | 20:21 | |
*** r-daneel has joined #openstack-nova | 20:22 | |
cfriesen | Suppose I have a stopped instance. I then restart nova-compute. It appears that _init_instance() will call self.driver.plug_vifs() unconditionally. Is this expected/necessary? Won't we call plug_vifs from the power_on() code anyways? | 20:23 |
*** fragatina has joined #openstack-nova | 20:25 | |
*** eharney has quit IRC | 20:28 | |
*** suresh12 has quit IRC | 20:28 | |
*** yassine has quit IRC | 20:29 | |
*** suresh12 has joined #openstack-nova | 20:29 | |
*** fragatin_ has joined #openstack-nova | 20:29 | |
*** fragatina has quit IRC | 20:33 | |
*** moshele has quit IRC | 20:33 | |
*** suresh12 has quit IRC | 20:33 | |
*** gouthamr has quit IRC | 20:33 | |
openstackgerrit | Merged openstack/nova master: tox: Fix indentation https://review.openstack.org/556543 | 20:36 |
*** suresh12 has joined #openstack-nova | 20:36 | |
*** germs has joined #openstack-nova | 20:38 | |
*** germs has quit IRC | 20:38 | |
*** germs has joined #openstack-nova | 20:38 | |
esberglu | mriedem: We're working on a solution to that. Right now to attach interfaces we need to wait for the RMC connection to become active for the instance | 20:38 |
esberglu | Which takes a really long time (like 10 minutes) | 20:38 |
esberglu | We're trying to get something going in our CI that will pre-spawn the instances so that they are ready by the time tempest gets to that test | 20:39 |
*** vipul has joined #openstack-nova | 20:39 | |
mriedem | esberglu: ok then you just have some small things to update in that patch and i'll be +2 on it | 20:41 |
*** germs has quit IRC | 20:42 | |
esberglu | mriedem: ack. Thanks for the review | 20:43 |
efried | mriedem: D'oh, I totally shoulda thought to send that mail to the ops list. Thanks for forwarding. | 20:47 |
*** edmondsw has joined #openstack-nova | 20:47 | |
*** vipul has quit IRC | 20:48 | |
*** vipul has joined #openstack-nova | 20:51 | |
*** yamahata has joined #openstack-nova | 20:52 | |
*** ttsiouts_ has joined #openstack-nova | 20:54 | |
*** vivsoni has quit IRC | 20:56 | |
*** vivsoni has joined #openstack-nova | 20:56 | |
*** vipul has quit IRC | 20:58 | |
imacdonn | mriedem efried Another stupid question.... for things like neutron, placement, etc., is it reasonable to assume that if I don't need to override them, the keystone stuff from [keystone_authtoken] (auth_url, auth_type, etc.) should apply? It seems somewhat inconsistent .. e.g. it seems to work for cinder, but not for neutron | 20:59 |
efried | imacdonn: Some services operate under admin context, some user context, some both depending on the code path. | 21:00 |
*** jaypipes has quit IRC | 21:01 | |
efried | imacdonn: ...uuhhhh, and that's apparently all I've got to say on that. | 21:01 |
*** voelzmo has quit IRC | 21:01 | |
*** voelzmo has joined #openstack-nova | 21:02 | |
efried | imacdonn: I was composing more stuff to say and realized I really don't know how it works. | 21:02 |
efried | I would have to go do some digging. | 21:02 |
imacdonn | efried: heh, OK ... thinking through this ... does it mean that cinder is working because it's reusing the user's auth token ? | 21:02 |
*** voelzmo has quit IRC | 21:02 | |
efried | I think sdague probably has this in his head without sleuthing. | 21:02 |
*** voelzmo has joined #openstack-nova | 21:02 | |
*** vipul has joined #openstack-nova | 21:03 | |
*** pchavva has quit IRC | 21:03 | |
*** voelzmo has quit IRC | 21:03 | |
sdague | imacdonn: it is working because it uses the user's token | 21:03 |
*** voelzmo has joined #openstack-nova | 21:04 | |
*** voelzmo has quit IRC | 21:04 | |
imacdonn | sdague: right ... that makes sense .. thanks | 21:04 |
*** voelzmo has joined #openstack-nova | 21:04 | |
sdague | the prefered model is the user auths to the first service or keystone, and then that token gets used for the users through the whole flow | 21:04 |
sdague | which ensures that if there is a bug in the code, the user permissions restrict how much damage they can do | 21:04 |
*** voelzmo has quit IRC | 21:05 | |
*** edmondsw has quit IRC | 21:05 | |
*** voelzmo has joined #openstack-nova | 21:05 | |
*** voelzmo has quit IRC | 21:05 | |
imacdonn | sdague: Understood. It makes sense now. | 21:05 |
*** edmondsw has joined #openstack-nova | 21:08 | |
openstackgerrit | Eric Fried proposed openstack/nova master: doc: Upgrade placement first https://review.openstack.org/556631 | 21:10 |
cfriesen | does anyone know why we call driver.plug_vifs() in _init_instance() for a stopped instance? | 21:22 |
cfriesen | looks like that code has been there forever | 21:22 |
cfriesen | I'm wondering if it's a lowest-common-denominator virt driver thing | 21:23 |
kashyap | cfriesen: melwitt: dansmith: Since I'm awake, thinking a bit more on https://review.openstack.org/#/c/534384/15/nova/virt/libvirt/driver.py: While I agree that failing at Nova start up is better it seems better to hard-fail _at_ instance start up, much like we do for 'mode' and 'model'? | 21:23 |
kashyap | If you see we're actually hard-failing for 'custom' and 'mode' just in the driver.py file | 21:23 |
cfriesen | kashyap: arguably we should hard-fail those at nova-compute startup too. | 21:24 |
kashyap | IMHO, it just is consistent (for better or worse) to raise exception.Invalid()fail for the closely related 'extra_flags' too. | 21:24 |
kashyap | cfriesen: Yes, exactly! | 21:24 |
kashyap | cfriesen: But that's a surgery for different day | 21:24 |
kashyap | I'm curious if anyone can poke holes in the above logic | 21:24 |
dansmith | cfriesen: mode is protected by choices | 21:24 |
*** vladikr has quit IRC | 21:24 | |
dansmith | er, kashyap | 21:24 |
* kashyap waits to get dansmith'ed | 21:24 | |
dansmith | kashyap: and model is defined in the libvirt cpu models xml, which can be custom-written | 21:24 |
*** vladikr has joined #openstack-nova | 21:24 | |
kashyap | dansmith: Custom-writing models is a horrible thing to do | 21:25 |
dansmith | kashyap: that has nothing to do with it | 21:25 |
kashyap | (It'll just cause untold pain.) | 21:25 |
dansmith | kashyap: also, we've paved the way for you to be able to backport this with minimal change, so it'd be cool if we could just not argue over minutia | 21:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs https://review.openstack.org/552924 | 21:25 |
dansmith | lots of people have opined at this point | 21:25 |
kashyap | dansmith: Sure, I'm not saying otherwise (on your earlier point). | 21:25 |
kashyap | dansmith: Oh, I actually _did_ make the LOG.warning thing | 21:26 |
*** edmondsw has quit IRC | 21:26 | |
kashyap | Locally | 21:26 |
kashyap | dansmith: But I'm just trying to discus in good spirit, as it seems to make logical sense given the existing structure | 21:26 |
* kashyap thinks a bit more | 21:27 | |
*** dave-mccowan has quit IRC | 21:27 | |
dansmith | kashyap: one could argue that if we made you do it as a workaround flag this would be moot, | 21:27 |
dansmith | so arguing for it further might work against us here :) | 21:28 |
kashyap | dansmith: C'mon :-) | 21:28 |
kashyap | dansmith: I'm amenable to reason (contrary to what you seem to imply :P) | 21:28 |
kashyap | But we know that the 'workaround' is just needless work for the poor deployment folks. That's why you concurred w/ me on that | 21:29 |
kashyap | Anyway. | 21:29 |
*** vipul has quit IRC | 21:29 | |
melwitt | I thought we were restricting choices to 'pcid' through the config option choices anyway, no? why do we need this check? | 21:30 |
dansmith | melwitt: we can't via config | 21:30 |
kashyap | melwitt: We are restricting the choices, indeed. | 21:30 |
dansmith | for listopt | 21:30 |
kashyap | Ah, not via config, though. | 21:30 |
dansmith | that's the point of the thread | 21:30 |
melwitt | I replied to the ML with an example where we do. does that not work? | 21:30 |
kashyap | Sorry, haven't checked the thread yet. (It's late, and I'm slowly getting back to thinking in English, after 3-ish hours of straight Dutch.) | 21:31 |
openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM: Add proc_units_factor conf option https://review.openstack.org/554688 | 21:31 |
dansmith | melwitt: ah I see now, I guess kashyap was confused? | 21:31 |
melwitt | okay, when you get a chance to check the thread, I'd try it out and see if it works. danpb used that technique to limit ListOpt choices for VNC auth_schemes for the console TLS stuff | 21:32 |
* kashyap goes to quickly read the email archive | 21:33 | |
cfriesen | kashyap: I would suggest that it would make sense to do your check at LibvirtDriver.init_host(), then in a followup patch move the sanity checks from LibvirtDriver._get_guest_cpu_model_config() to init_host(). | 21:33 |
dansmith | cfriesen: looks to me like it will be checked early during config parsing now | 21:33 |
openstackgerrit | Eric Fried proposed openstack/nova master: Slugification utilities for placement names https://review.openstack.org/556628 | 21:33 |
*** yamahata has quit IRC | 21:33 | |
dansmith | which is what we originally suggested | 21:33 |
cfriesen | sure, if we can restrict it via the config parsing for backport that'd be even better. | 21:34 |
*** vipul has joined #openstack-nova | 21:34 | |
kashyap | melwitt: Ah, this one: https://github.com/openstack/nova/blob/cd15c3d/nova/conf/vnc.py#L226,232 | 21:34 |
melwitt | yes | 21:35 |
kashyap | melwitt: Interesting pointer; I'll give it a whirl and see what comes | 21:35 |
melwitt | cool, hope it works, else we have a bug in the vnc opts too :P | 21:35 |
*** vipul has quit IRC | 21:36 | |
kashyap | LOL | 21:37 |
* kashyap hits the hay before the date changes | 21:37 | |
*** vipul has joined #openstack-nova | 21:42 | |
*** burt has quit IRC | 21:44 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Migrate tempest-dsvm-cells job to an in-tree job definition https://review.openstack.org/556656 | 21:44 |
*** gouthamr has joined #openstack-nova | 21:45 | |
*** ttsiouts_ has quit IRC | 21:46 | |
*** felipemonteiro_ has joined #openstack-nova | 21:49 | |
mriedem | so uh, | 21:49 |
mriedem | sahid would likely explode if i mentioned this, but https://review.openstack.org/#/c/458820/ could arguably require a microversion right? | 21:49 |
mriedem | i.e. i create an sriov port in neutron with trusted=true, | 21:49 |
mriedem | and try to create a server with that port, but nova api isn't new enough to move that in the pci request for scheduling, | 21:50 |
mriedem | so i get a server without a trusted VF | 21:50 |
mriedem | thought about this because of the bandwidth-aware scheduling stuff that relies on the qos policy on the ports in neutron, which impacts scheduling behavior in nova | 21:51 |
openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Filter resource providers by forbidden traits in db https://review.openstack.org/556472 | 21:52 |
openstackgerrit | Chris Dent proposed openstack/nova master: Support forbidden traits in allocation_candidates in db https://review.openstack.org/556660 | 21:52 |
*** tssurya has quit IRC | 21:52 | |
* mriedem should probably just pretend he didn't ask or notice this because it's a discussion he doesn't really want to have | 21:52 | |
*** felipemonteiro__ has quit IRC | 21:53 | |
cdent | edleafe, efried, jaypipes: that ^ batch of stuff is the initial db support for forbidden traits. most of the rest of the code is done too, but needs to be extracted from a lump of random stuff. I'm not super confident I've got enough tests yet. | 21:53 |
efried | ack | 21:54 |
*** cdent has quit IRC | 22:03 | |
*** esberglu has quit IRC | 22:04 | |
*** esberglu has joined #openstack-nova | 22:04 | |
openstackgerrit | Matt Riedemann proposed openstack/osc-placement stable/queens: Do not depend on jenkins user in devstack gate https://review.openstack.org/556666 | 22:05 |
*** felipemonteiro_ has quit IRC | 22:05 | |
openstackgerrit | Matt Riedemann proposed openstack/osc-placement stable/queens: Migrate legacy-osc-placement-dsvm-functional job in-tree https://review.openstack.org/556635 | 22:05 |
*** esberglu has quit IRC | 22:09 | |
*** AlexeyAbashkin has joined #openstack-nova | 22:12 | |
*** Guest22224 has quit IRC | 22:12 | |
*** AlexeyAbashkin has quit IRC | 22:16 | |
*** mlavalle has quit IRC | 22:17 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Handle agg generation conflict in report client https://review.openstack.org/556669 | 22:19 |
efried | dansmith, cdent, jaypipes, edleafe ^ | 22:20 |
*** rcernin has joined #openstack-nova | 22:20 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Create/lookup API services in cell0 on WSGI app startup https://review.openstack.org/556670 | 22:20 |
*** salv-orlando has quit IRC | 22:22 | |
*** salv-orlando has joined #openstack-nova | 22:23 | |
mriedem | dansmith: i can't convince myself that there would be any upgrade impact with this ^ | 22:27 |
mriedem | even if you had mistakenly started up API services pointing at cell1 | 22:27 |
*** salv-orlando has quit IRC | 22:27 | |
*** dave-mccowan has joined #openstack-nova | 22:29 | |
dansmith | well, you'd have some nova-api type services that will still list out of a service listing | 22:29 |
dansmith | from cell1 | 22:29 |
mriedem | service list filters out api services | 22:29 |
dansmith | we don't need this wsgi_app stuff for metadata? | 22:29 |
mriedem | https://github.com/openstack/nova/blob/88f6c3b7b892f2a05066ac6f0e3353f4ce80f6b0/nova/api/openstack/compute/services.py#L48 | 22:29 |
dansmith | hmm | 22:29 |
mriedem | is nova-metadata global or per-cell? | 22:30 |
melwitt | I think it's global | 22:31 |
dansmith | yeah, it hits api db | 22:31 |
dansmith | I really didn't think services would filter out api, that's kindof confusing to me | 22:31 |
mriedem | the os-services REST API is mostly biased to compute services | 22:32 |
mriedem | i.e. things you can enable/disable | 22:32 |
mriedem | and service group stuff | 22:32 |
dansmith | it shows scheduler | 22:32 |
mriedem | i know, but... | 22:32 |
dansmith | which is probably why I'm thinking that, | 22:32 |
dansmith | although,. | 22:32 |
dansmith | now that I think of it, | 22:32 |
mriedem | that all predates host mappings too | 22:32 |
mriedem | and this api relies on host mappings to do any actions on services | 22:32 |
dansmith | we didn't even have api service records until we needed it for SERVICE_VERSION | 22:32 |
dansmith | so that makes sense now | 22:32 |
mriedem | so it's restricted to compute | 22:32 |
mriedem | this is as close as we get to nova-metadata being global for cells v2 in our docs https://docs.openstack.org/nova/latest/user/cellsv2-layout.html#neutron-metadata-api-proxy | 22:34 |
dansmith | so I guess no upgrade impact, through a weird set of reasons | 22:34 |
mriedem | alternatively to this, i could base it on if CONF.database.connection is None | 22:34 |
mriedem | but.. | 22:34 |
mriedem | but that just seems weird | 22:35 |
dansmith | I guess I'm not sure why we should make this change | 22:35 |
mriedem | anyway, there might be more fallout before https://review.openstack.org/#/c/555346/ is done | 22:35 |
dansmith | I mean, it's okay I guess, | 22:35 |
mriedem | ease of configuration/deployment i guess? | 22:36 |
dansmith | but it seems like more of a departure to have [database] be unconfigured | 22:36 |
mriedem | https://bugs.launchpad.net/nova/+bug/1757472 | 22:36 |
openstack | Launchpad bug 1757472 in OpenStack Compute (nova) "Required to define database/connection when running services for nova_api cell" [Medium,In progress] - Assigned to Matt Riedemann (mriedem) | 22:36 |
dansmith | I guess | 22:36 |
mriedem | would have to ask belmiro, but i also just triaged another duplicate of this same bug | 22:36 |
mriedem | if i've got access to the api db and cell0 is in there, then i don't really need the config | 22:37 |
dansmith | is that really the only place you'll blow up by not having that there? | 22:37 |
mriedem | we'll see | 22:37 |
mriedem | the service wouldn't start in devstack w/o it | 22:37 |
dansmith | yeah | 22:38 |
mriedem | i just rev'ed the devstack patch | 22:38 |
dansmith | I don't really see the justification, especially since config is where db urls and credentials are _supposed_ to be | 22:38 |
dansmith | but if it's really just that one place, then I guess meh | 22:38 |
*** germs has joined #openstack-nova | 22:38 | |
*** germs has quit IRC | 22:38 | |
*** germs has joined #openstack-nova | 22:38 | |
mriedem | it certainly makes the db sync for cell0 a pain in the ass https://review.openstack.org/#/c/555346/3/lib/nova@742 | 22:40 |
mriedem | if you're not using simple_cell_setup anyway | 22:40 |
dansmith | well, --all-cells will make that easier | 22:41 |
dansmith | but that's also kindof a weirdness | 22:41 |
dansmith | anyway, whatever | 22:41 |
dansmith | see what else breaks I guess | 22:41 |
*** germs has quit IRC | 22:43 | |
openstackgerrit | melanie witt proposed openstack/nova master: Add periodic task to clean expired console tokens https://review.openstack.org/325381 | 22:52 |
openstackgerrit | melanie witt proposed openstack/nova master: Use ConsoleAuthToken object to generate authorizations https://review.openstack.org/325414 | 22:52 |
openstackgerrit | melanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation https://review.openstack.org/333990 | 22:52 |
*** hongbin has quit IRC | 22:58 | |
*** sdague has quit IRC | 23:07 | |
*** yangyapeng has joined #openstack-nova | 23:09 | |
*** r-daneel has quit IRC | 23:10 | |
cfriesen | why do we still call plug_vifs() when we call _create_domain_and_network() with vifs_already_plugged=True ? | 23:11 |
*** AlexeyAbashkin has joined #openstack-nova | 23:12 | |
*** yangyapeng has quit IRC | 23:14 | |
*** danpawlik has quit IRC | 23:16 | |
*** AlexeyAbashkin has quit IRC | 23:16 | |
*** gouthamr has quit IRC | 23:18 | |
*** yassine has joined #openstack-nova | 23:18 | |
*** salv-orlando has joined #openstack-nova | 23:23 | |
*** yangyapeng has joined #openstack-nova | 23:25 | |
*** salv-orlando has quit IRC | 23:28 | |
*** yangyapeng has quit IRC | 23:31 | |
*** _ix has quit IRC | 23:45 | |
*** andreas_s has joined #openstack-nova | 23:50 | |
*** germs has joined #openstack-nova | 23:51 | |
*** germs has quit IRC | 23:51 | |
*** germs has joined #openstack-nova | 23:51 | |
*** READ10 has joined #openstack-nova | 23:52 | |
*** andreas_s has quit IRC | 23:54 | |
*** vipul has quit IRC | 23:55 | |
*** germs has quit IRC | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!