Wednesday, 2018-03-28

*** germs has quit IRC00:04
*** fragatina has quit IRC00:04
*** salv-orlando has joined #openstack-nova00:05
*** Swami has quit IRC00:06
*** fragatina has joined #openstack-nova00:06
*** salv-orlando has quit IRC00:10
*** fragatina has quit IRC00:10
*** liverpooler has joined #openstack-nova00:11
*** yamamoto has joined #openstack-nova00:12
*** openstack has joined #openstack-nova00:15
*** ChanServ sets mode: +o openstack00:15
*** sdague has quit IRC00:17
*** yamamoto has quit IRC00:17
*** stakeda has joined #openstack-nova00:20
*** Dinesh_Bhor has joined #openstack-nova00:21
*** dave-mccowan has joined #openstack-nova00:22
openstackgerritMerged openstack/nova-specs master: Add serial numbers for local disks  https://review.openstack.org/55656500:29
*** gyee has quit IRC00:33
*** yamahata has joined #openstack-nova00:38
*** yamamoto has joined #openstack-nova00:38
*** fragatina has joined #openstack-nova00:39
*** fragatina has quit IRC00:43
*** yamamoto has quit IRC00:45
*** vladikr has quit IRC00:48
*** vladikr has joined #openstack-nova00:49
*** yamahata has quit IRC00:49
*** jichen has joined #openstack-nova00:50
*** odyssey4me has quit IRC00:53
*** odyssey4me has joined #openstack-nova00:53
openstackgerritMichael Still proposed openstack/nova master: Remove duplicative implementation of temporary directories.  https://review.openstack.org/55479100:55
openstackgerritMichael Still proposed openstack/nova master: Use a pythonic delete.  https://review.openstack.org/55479200:55
openstackgerritMichael Still proposed openstack/nova master: Use a pythonic delete, with a retry.  https://review.openstack.org/55479300:55
*** yamamoto has joined #openstack-nova00:56
*** yangyapeng has joined #openstack-nova00:58
*** tuanla____ has joined #openstack-nova01:01
*** chyka has joined #openstack-nova01:02
*** yangyapeng has quit IRC01:03
*** gjayavelu has quit IRC01:04
*** chyka has quit IRC01:06
*** itlinux has joined #openstack-nova01:07
*** tiendc has joined #openstack-nova01:08
*** gyankum has joined #openstack-nova01:12
*** yangyapeng has joined #openstack-nova01:14
*** yamamoto has quit IRC01:14
openstackgerritZhenyu Zheng proposed openstack/nova-specs master: Allow abort live migrations in queued status  https://review.openstack.org/53672201:14
*** itlinux has quit IRC01:15
*** gongysh has joined #openstack-nova01:16
*** Matias has quit IRC01:20
*** hongbin has joined #openstack-nova01:22
openstackgerritTakashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers.inc (2/3)  https://review.openstack.org/55064801:23
openstackgerritTakashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers.inc (3/3)  https://review.openstack.org/55065901:24
openstackgerritTakashi NATSUME proposed openstack/nova master: api-ref: Fix parameter order in rebuild  https://review.openstack.org/52971801:25
*** suresh12 has quit IRC01:34
*** sree has quit IRC01:36
*** sree has joined #openstack-nova01:37
*** gongysh has quit IRC01:38
*** vivsoni has quit IRC01:39
*** gouthamr has joined #openstack-nova01:40
*** vivsoni has joined #openstack-nova01:41
*** sree has quit IRC01:41
*** liusheng has quit IRC01:51
*** liusheng has joined #openstack-nova01:52
*** takashin has quit IRC01:53
*** _ix has quit IRC01:56
Spaz-HomeMorning novafriends01:58
*** germs has joined #openstack-nova02:00
*** germs has quit IRC02:00
*** germs has joined #openstack-nova02:00
*** hshiina has quit IRC02:02
*** tbachman has quit IRC02:02
*** tbachman has joined #openstack-nova02:03
*** germs has quit IRC02:04
*** liusheng has quit IRC02:06
*** salv-orlando has joined #openstack-nova02:07
*** liusheng has joined #openstack-nova02:07
*** dikonoo has joined #openstack-nova02:09
*** psachin has joined #openstack-nova02:11
*** salv-orlando has quit IRC02:12
*** AlexeyAbashkin has joined #openstack-nova02:12
*** yamamoto has joined #openstack-nova02:15
*** AlexeyAbashkin has quit IRC02:16
*** yamamoto has quit IRC02:21
openstackgerritYikun Jiang (Kero) proposed openstack/nova-specs master: Complex (Anti)-Affinity Policies  https://review.openstack.org/54692502:21
*** suresh12 has joined #openstack-nova02:28
*** zhurong has joined #openstack-nova02:32
*** suresh12 has quit IRC02:33
*** gongysh has joined #openstack-nova02:35
*** hshiina has joined #openstack-nova02:36
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Extract generate_hostid method into utils.py  https://review.openstack.org/55528202:36
*** yamamoto has joined #openstack-nova02:37
*** ccamacho|PTO has quit IRC02:38
*** sree has joined #openstack-nova02:39
*** sree has quit IRC02:39
*** sree has joined #openstack-nova02:39
openstackgerritTakashi NATSUME proposed openstack/nova master: api-ref: Fix parameter order in rebuild  https://review.openstack.org/52971802:42
*** fragatina has joined #openstack-nova02:44
openstackgerritTakashi NATSUME proposed openstack/nova master: api-ref: Fix parameter order in rebuild  https://review.openstack.org/52971802:45
*** fragatin_ has joined #openstack-nova02:46
*** takashin has joined #openstack-nova02:48
*** fragatina has quit IRC02:48
*** tbachman has joined #openstack-nova02:50
*** tbachman_ has joined #openstack-nova02:53
*** tbachman has quit IRC02:54
*** tbachman_ is now known as tbachman02:54
*** vladikr has quit IRC02:59
*** vladikr has joined #openstack-nova02:59
*** licanwei has joined #openstack-nova03:07
openstackgerritGhanshyam Mann proposed openstack/nova-specs master: Spec for Granular API policy  https://review.openstack.org/54785003:10
*** ccamacho has joined #openstack-nova03:11
*** takashin has quit IRC03:14
*** takashin has joined #openstack-nova03:15
*** itlinux has joined #openstack-nova03:18
openstackgerritNguyen Hai proposed openstack/nova-specs master: Enhance nova-specs webpage and clean up repo  https://review.openstack.org/55180203:18
*** yamamoto has quit IRC03:18
*** tbachman has quit IRC03:18
openstackgerritZhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware  https://review.openstack.org/50748603:20
*** yingjun has joined #openstack-nova03:26
*** takashin has quit IRC03:26
*** janki has joined #openstack-nova03:32
openstackgerritJianle He proposed openstack/nova-specs master: Back up volume-backed-instance  https://review.openstack.org/53021403:33
*** hongbin has quit IRC03:43
*** andreas_s has joined #openstack-nova03:46
*** andreas_s has quit IRC03:51
*** dave-mccowan has quit IRC03:55
*** jaosorior has joined #openstack-nova03:56
*** yangyapeng has quit IRC03:56
*** udesale has joined #openstack-nova03:57
*** germs has joined #openstack-nova04:01
*** germs has quit IRC04:01
*** germs has joined #openstack-nova04:01
openstackgerritYikun Jiang (Kero) proposed openstack/nova-specs master: Fix typo in GET os-instance-actions url.  https://review.openstack.org/55714304:02
*** germs has quit IRC04:06
*** stakeda has quit IRC04:07
*** yingjun has quit IRC04:08
*** salv-orlando has joined #openstack-nova04:08
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: [WIP] Add host/hostId to instance action events API  https://review.openstack.org/55714504:09
*** salv-orlando has quit IRC04:13
*** yamamoto has joined #openstack-nova04:19
*** gongysh has quit IRC04:19
*** gouthamr has quit IRC04:22
*** suresh12 has joined #openstack-nova04:24
*** yamamoto has quit IRC04:25
*** psachin has quit IRC04:25
*** namnh has joined #openstack-nova04:27
*** abhishekk has joined #openstack-nova04:29
*** Eran_Kuris has joined #openstack-nova04:35
*** Spazmotic1 has joined #openstack-nova04:38
*** sdeath has joined #openstack-nova04:41
*** Spaz-Home has quit IRC04:42
*** psachin has joined #openstack-nova04:43
*** links has joined #openstack-nova04:46
*** ratailor has joined #openstack-nova04:48
*** takashin has joined #openstack-nova04:48
*** sdeath has quit IRC04:49
openstackgerritTetsuro Nakamura proposed openstack/nova master: Fix comments in get_all_with_shared()  https://review.openstack.org/53319504:51
openstackgerritTetsuro Nakamura proposed openstack/nova master: remove unnecessary short cut in placement  https://review.openstack.org/55312204:51
openstackgerritTetsuro Nakamura proposed openstack/nova master: Fix allocation_candidates not to ignore shared RPs  https://review.openstack.org/53339604:51
openstackgerritTetsuro Nakamura proposed openstack/nova master: Consider nested RPs in get_all_with_shared  https://review.openstack.org/55645004:51
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support shared and nested allocation candidates  https://review.openstack.org/55651404:51
*** ratailor_ has joined #openstack-nova04:52
*** Zames has joined #openstack-nova04:53
*** lpetrut has joined #openstack-nova04:55
*** ratailor has quit IRC04:57
*** udesale has quit IRC04:58
openstackgerritTetsuro Nakamura proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs  https://review.openstack.org/51960104:58
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support relay RP for allocation candidates  https://review.openstack.org/53343704:58
*** udesale has joined #openstack-nova04:59
*** Dinesh_Bhor has quit IRC05:00
*** Zames has quit IRC05:01
*** Dinesh_Bhor has joined #openstack-nova05:06
openstackgerritjichenjc proposed openstack/nova master: WIP: remove Ec2 object  https://review.openstack.org/55715005:08
*** salv-orlando has joined #openstack-nova05:09
*** salv-orlando has quit IRC05:09
*** salv-orlando has joined #openstack-nova05:09
*** yangyapeng has joined #openstack-nova05:14
*** yangyapeng has quit IRC05:19
openstackgerritjichenjc proposed openstack/nova master: Avoid raise InstanceNotRunning exception  https://review.openstack.org/54115205:20
*** yamamoto has joined #openstack-nova05:21
*** moshele has joined #openstack-nova05:22
*** lpetrut has quit IRC05:26
*** lpetrut has joined #openstack-nova05:27
*** yamamoto has quit IRC05:27
openstackgerritRoman Dobosz proposed openstack/nova master: allow compute nodes to be associated with host agg  https://review.openstack.org/52675305:30
openstackgerritRoman Dobosz proposed openstack/nova master: Remove server group sched filter support caching  https://review.openstack.org/52920005:30
openstackgerritRoman Dobosz proposed openstack/nova master: get instance group's aggregate associations  https://review.openstack.org/53124305:30
openstackgerritRoman Dobosz proposed openstack/nova master: Support aggregate affinity filters  https://review.openstack.org/52920105:30
openstackgerritRoman Dobosz proposed openstack/nova master: Add nodes to group hosts to be checked against aggregation  https://review.openstack.org/55676105:30
openstackgerritRoman Dobosz proposed openstack/nova master: Added weight for aggregate soft (anti) affinity.  https://review.openstack.org/55676205:30
*** liusheng has quit IRC05:35
*** liusheng has joined #openstack-nova05:36
*** lpetrut has quit IRC05:39
*** takashin has quit IRC05:43
*** tbachman has joined #openstack-nova05:44
*** takashin has joined #openstack-nova05:45
*** yingjun has joined #openstack-nova05:45
*** licanwei has quit IRC05:46
openstackgerritjichenjc proposed openstack/nova master: Move update_task_state out of try/except  https://review.openstack.org/55715205:47
*** lpetrut has joined #openstack-nova05:52
*** suresh12 has quit IRC05:53
*** trinaths has joined #openstack-nova05:53
*** belmoreira has joined #openstack-nova05:55
*** claudiub|2 has joined #openstack-nova05:59
*** gaoyan has joined #openstack-nova06:00
*** kholkina has joined #openstack-nova06:01
*** germs has joined #openstack-nova06:02
*** germs has quit IRC06:02
*** germs has joined #openstack-nova06:02
*** gongysh has joined #openstack-nova06:02
*** luckybird1 has joined #openstack-nova06:03
*** luckybird1 has left #openstack-nova06:03
*** luckybird1 has joined #openstack-nova06:03
*** luckybird1 has left #openstack-nova06:05
*** germs has quit IRC06:06
*** licanwei has joined #openstack-nova06:08
*** suresh12 has joined #openstack-nova06:09
*** swamireddy has quit IRC06:11
*** suresh12 has quit IRC06:13
*** Gorian has quit IRC06:14
*** moshele has quit IRC06:14
*** tbachman has quit IRC06:16
*** voelzmo has joined #openstack-nova06:18
*** Gorian has joined #openstack-nova06:21
*** yamamoto has joined #openstack-nova06:23
*** sahid has joined #openstack-nova06:24
*** claudiub has joined #openstack-nova06:26
*** udesale_ has joined #openstack-nova06:28
*** lajoskatona has joined #openstack-nova06:28
*** yamamoto has quit IRC06:28
*** claudiub|2 has quit IRC06:29
*** jaosorior has quit IRC06:29
*** udesale has quit IRC06:30
*** udesale__ has joined #openstack-nova06:30
*** udesale_ has quit IRC06:33
*** pcaruana has joined #openstack-nova06:38
*** alexchadin has joined #openstack-nova06:39
*** ccamacho has quit IRC06:41
*** yangyapeng has joined #openstack-nova06:42
*** xinliang has quit IRC06:52
*** voelzmo has quit IRC06:55
*** andreas_s has joined #openstack-nova06:55
*** voelzmo has joined #openstack-nova06:55
*** lpetrut has quit IRC06:58
*** ccamacho has joined #openstack-nova06:59
*** yangyapeng has quit IRC07:00
*** yangyapeng has joined #openstack-nova07:01
*** gongysh has quit IRC07:04
*** xinliang has joined #openstack-nova07:05
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata  https://review.openstack.org/54877207:06
*** zhurong has quit IRC07:08
*** voelzmo has quit IRC07:08
*** jaosorior has joined #openstack-nova07:10
*** gongysh has joined #openstack-nova07:10
openstackgerritdo3meli proposed openstack/nova-specs master: Adds resize on shared storage without ssh keys  https://review.openstack.org/55192707:10
*** voelzmo has joined #openstack-nova07:10
*** voelzmo has quit IRC07:11
*** rcernin has quit IRC07:15
*** priya__ has joined #openstack-nova07:15
*** voelzmo has joined #openstack-nova07:15
priya__Hi team, my code breaks with "flavor not found" issue. It is seen that instance_types table is empty. The same code works in Mitaka. Is there any issue/upgrade for pike?07:16
*** pooja_jadhav has quit IRC07:21
*** salv-orlando has quit IRC07:22
*** mdnadeem has joined #openstack-nova07:22
*** pooja_jadhav has joined #openstack-nova07:22
*** salv-orlando has joined #openstack-nova07:22
*** yamamoto has joined #openstack-nova07:25
*** tesseract has joined #openstack-nova07:25
*** alexchadin has quit IRC07:26
*** tssurya has joined #openstack-nova07:26
*** salv-orlando has quit IRC07:27
*** Zames has joined #openstack-nova07:29
*** zz9pzza has joined #openstack-nova07:29
*** yamamoto has quit IRC07:30
*** alexchadin has joined #openstack-nova07:31
*** Zames has quit IRC07:32
priya__Hi team, my code breaks with "flavor not found" issue. It is seen that instance_types table is empty. The same code works in Mitaka. Is there any issue/upgrade for pike?07:35
*** voelzmo has quit IRC07:36
openstackgerritZhenyu Zheng proposed openstack/nova master: Add request_id to instance action notifications  https://review.openstack.org/55328807:42
priya__ Hi team, my code breaks with "flavor not found" issue. It is seen that instance_types table is empty. The same code works in Mitaka. Is there any issue/upgrade for pike?07:43
*** damien_r has joined #openstack-nova07:43
*** udesale__ is now known as udesale07:43
*** salv-orlando has joined #openstack-nova07:45
openstackgerritZhenyu Zheng proposed openstack/nova master: Add request_id to instance action notifications  https://review.openstack.org/55328807:48
*** belmoreira has quit IRC07:49
*** mdnadeem has quit IRC07:51
Kevin_Zhenggibi, Hi, thanks for the advice in https://review.openstack.org/553288 , but it still cannot work, so I still mocked the req_id generation call07:53
Kevin_ZhengI put the reason in comment reply07:54
*** salv-orlando has quit IRC07:54
*** ralonsoh has joined #openstack-nova07:54
*** salv-orlando has joined #openstack-nova07:54
kaisers1mikal: ping (reg. https://review.openstack.org/#/c/554195/7/nova/privsep/libvirt.py comments from Stephen)07:56
*** lucas-afk is now known as lucasagomes07:56
*** salv-orlando has quit IRC07:59
bauzasgood morning folks07:59
*** AlexeyAbashkin has joined #openstack-nova08:00
*** takashin has left #openstack-nova08:01
bauzasjianghuaw_: here ?08:02
* bauzas was looking at http://docs.nvidia.com/grid/5.0/grid-vgpu-user-guide/index.html#view-gpu-group-object-details-citrix-xenserver-xe08:02
bauzasjianghuaw_: IIUC, a pGPU group is having multiple types, right?08:02
*** germs has joined #openstack-nova08:03
*** germs has quit IRC08:03
*** germs has joined #openstack-nova08:03
jianghuaw_bauzas. good morning.08:03
jianghuaw_yes.08:03
*** sar has quit IRC08:04
jianghuaw_XenServer supply vGPUs from GPU groups.08:04
*** voelzmo has joined #openstack-nova08:04
bauzasjianghuaw_: okay, so I don't understand your comment in https://review.openstack.org/#/c/557065/1/specs/rocky/approved/vgpu-rocky.rst@4708:04
*** ktibi has joined #openstack-nova08:05
bauzashow can you know which type to use for that group ?08:05
jianghuaw_just treat a group in xenserver as a pGPU in kvm.08:05
*** belmoreira has joined #openstack-nova08:06
jianghuaw_the enabled_vgpu_types listed the enabled vGPU types.08:07
jianghuaw_we only put one vGPU type from the supported list by GPU group.08:07
jianghuaw_in the configure option.08:07
*** germs has quit IRC08:08
jianghuaw_If there are multiple types of PGPUs, there will be multiple GPU group.08:08
*** derekh has joined #openstack-nova08:08
jianghuaw_e.g. PGPU type 1 => grp1 (support type1-1, type1-2);  pGPU type 2 => grp 2 (support type2-1, type2-2);08:09
jianghuaw_then we set enabled_vgpu_types = type1-1, type2-108:10
jianghuaw_It's able to ensure each group will expose one type of VGPUs.08:10
bauzassec08:10
*** mdnadeem has joined #openstack-nova08:11
sahidbauzas: i think we have an agreement here, if you can take a moment for https://review.openstack.org/#/c/511188/08:12
bauzasjianghuaw_: hah, that's because pGPU groups in Xen are mutually exclusive08:13
bauzas?08:13
bauzasie. you can't have both two groups sharing the same type ?08:13
bauzassahid: sure, it's in my radar, like I said ;)08:14
bauzassahid: I have to follow up on some specs :)08:14
sahidbauzas: cool thanks08:14
*** yingjun has quit IRC08:15
jianghuaw_bauzas, yes.08:16
*** yingjun has joined #openstack-nova08:16
bauzasjianghuaw_: okay, so what if the operator says enabled_vgpu_types = type1-1, type1-2 ?08:16
bauzasjianghuaw_: taking the example of http://docs.nvidia.com/grid/5.0/grid-vgpu-user-guide/index.html#view-gpu-group-object-details-citrix-xenserver-xe08:17
jianghuaw_Then follow the behavior as Queens, choose the first type supported by the group.08:17
bauzasjianghuaw_: but then it won't use the second type for a second pGPU in the same group ?08:18
jianghuaw_yes.08:18
jianghuaw_That's expected. the type in group must be predictable.08:20
jianghuaw_Otherwise it's not able to calculate the inventories' total.08:20
*** priteau has joined #openstack-nova08:20
bauzasjianghuaw_: but then it's unfortunate for the operator08:21
bauzasbecause they can do something like http://docs.nvidia.com/grid/5.0/grid-vgpu-user-guide/index.html#homogeneous-grid-vgpus08:21
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: [WIP] Add host/hostId to instance action events API  https://review.openstack.org/55714508:21
bauzasjianghuaw_: (first valid config)08:21
*** voelzmo has quit IRC08:22
*** voelzmo has joined #openstack-nova08:22
*** mdbooth has joined #openstack-nova08:22
*** ccamacho has quit IRC08:23
*** voelzmo has quit IRC08:23
*** gongysh has quit IRC08:23
*** voelzmo has joined #openstack-nova08:23
*** voelzmo has quit IRC08:24
*** voelzmo has joined #openstack-nova08:24
*** rcernin has joined #openstack-nova08:24
*** voelzmo has quit IRC08:24
* gibi reads back08:25
*** voelzmo has joined #openstack-nova08:25
*** voelzmo has quit IRC08:25
*** voelzmo has joined #openstack-nova08:25
*** voelzmo has quit IRC08:26
*** yamamoto has joined #openstack-nova08:26
*** tianhui has quit IRC08:29
openstackgerritJohannes Kulik proposed openstack/nova master: Fix spelling mistake of HTTPNotFound exception  https://review.openstack.org/55718708:29
*** tianhui has joined #openstack-nova08:29
*** yamamoto has quit IRC08:30
jianghuaw_bauzas, Do you mean we can't create different type vGPUs on different pgpu belong to a group?08:32
bauzasjianghuaw_: a group is multiple pGPUs, right?08:33
jianghuaw_yes.08:33
jianghuaw_with same type08:33
bauzasjianghuaw_: so, you can have one type per pGPU08:33
bauzasjianghuaw_: no, not the same type, you just said there are multiple types per group08:33
*** oanson has quit IRC08:34
jianghuaw_I mean a group can be multiple PGPUs which belong to the same PGPU type e.g. all are "Tesla M60"08:34
*** oanson has joined #openstack-nova08:36
jianghuaw_Each PGPU can support multiple vGPU types; as we make group as the unit to expose vGPUs, we have to restrict each group having only one vgpu type enabled.08:37
*** lpetrut has joined #openstack-nova08:40
jianghuaw_bauzas, with the new configure option, we can't enable multiple types in each group either.08:41
*** rcernin has quit IRC08:42
*** hoangcx has quit IRC08:42
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Allow to specify granular CPU feature flags  https://review.openstack.org/53438408:43
*** ccamacho has joined #openstack-nova08:46
*** lpetrut has quit IRC08:47
*** hoangcx has joined #openstack-nova08:47
*** lpetrut has joined #openstack-nova08:47
*** sdague has joined #openstack-nova08:55
*** ccamacho has quit IRC08:56
*** alexchadin has quit IRC08:57
*** udesale has quit IRC08:58
*** alexchadin has joined #openstack-nova08:58
kashyapsean-k-mooney[m]: ^ Can you re-ACK it, please09:02
kashyap(Since I moved the 'choices' stuff into config, I just removed the uppercase/lowercase check in driver.py; small mechanical change.)09:02
*** udesale has joined #openstack-nova09:05
*** bhujay has joined #openstack-nova09:10
*** cdent has joined #openstack-nova09:11
*** ragiman has joined #openstack-nova09:12
kashyapimacdonn: stvnoyes1 Follow-up from last night, please update the versions of libvirt, QEMU, libguestfs for Oracle Linux here: https://wiki.openstack.org/wiki/LibvirtDistroSupportMatrix09:16
*** maciejjozefczyk has quit IRC09:17
openstackgerritgaryk proposed openstack/nova master: VMware: add log message for VIF info details  https://review.openstack.org/55725609:17
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver  https://review.openstack.org/52338709:18
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver  https://review.openstack.org/52765809:18
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add snapshot function  https://review.openstack.org/53424009:18
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add power actions  https://review.openstack.org/54334009:18
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add get console output  https://review.openstack.org/54334409:18
bauzasjianghuaw_: anyway, I don't want to rathole on Xen specifics09:25
bauzasjianghuaw_: if you feel you don't need that spec, all fair, I'll make that conf opt libvirt-specific09:25
*** yamamoto has joined #openstack-nova09:27
openstackgerritBhagyashri Shewale proposed openstack/nova-specs master: Disallow rotation parameter 0 for 'createBackup' API  https://review.openstack.org/51182509:28
openstackgerritjichenjc proposed openstack/nova master: WIP: remove Ec2 object  https://review.openstack.org/55715009:28
*** Spazmotic1 has quit IRC09:30
openstackgerritJie Li proposed openstack/nova-specs master: Support volume-backed server rescue  https://review.openstack.org/53241009:31
*** yingjun has quit IRC09:32
jianghuaw_bauzas, thanks.09:32
*** yamamoto has quit IRC09:32
*** alexchadin has quit IRC09:34
*** swamireddy has joined #openstack-nova09:34
*** yingjun has joined #openstack-nova09:36
*** itlinux has quit IRC09:36
*** Dinesh_Bhor has quit IRC09:36
*** _ix has joined #openstack-nova09:37
*** lpetrut_ has joined #openstack-nova09:41
*** trinaths has quit IRC09:44
*** dtantsur|afk is now known as dtantsur09:46
*** chyka has joined #openstack-nova09:48
*** yingjun has quit IRC09:50
*** hoangcx has quit IRC09:51
*** chyka has quit IRC09:52
openstackgerritBhagyashri Shewale proposed openstack/nova-specs master: Disallow rotation parameter 0 for 'createBackup' API  https://review.openstack.org/51182509:54
*** hoangcx has joined #openstack-nova09:56
jianghuaw_bauzas, In the queens vGPU spec, we have display heads as consumable resource. Now we will make it as a trait.09:56
openstackgerritjichenjc proposed openstack/nova master: Move update_task_state out of try/except  https://review.openstack.org/55715209:56
*** sree has quit IRC09:56
jianghuaw_Should we just update the queens spec or should make a new spec in Rocky?09:57
*** sree has joined #openstack-nova09:57
*** salv-orlando has joined #openstack-nova09:58
*** liverpooler has quit IRC09:59
*** ratailor_ is now known as rtailor10:00
*** sree has quit IRC10:02
*** germs has joined #openstack-nova10:03
*** hoangcx has quit IRC10:03
*** namnh has quit IRC10:03
*** jichen has quit IRC10:06
*** germs has quit IRC10:08
*** suresh12 has joined #openstack-nova10:09
*** hoangcx has joined #openstack-nova10:10
*** cdent has quit IRC10:12
*** suresh12 has quit IRC10:14
*** sambetts|afk is now known as sambetts10:18
*** yamamoto has joined #openstack-nova10:29
*** yamamoto has quit IRC10:34
*** alexchadin has joined #openstack-nova10:35
*** gaoyan has quit IRC10:36
*** moshele has joined #openstack-nova10:36
*** sahid has quit IRC10:39
*** rmart04 has joined #openstack-nova10:42
openstackgerritClaudiu Belu proposed openstack/nova master: tests: autospecs all the mock.patch usages  https://review.openstack.org/47077510:43
*** abhishekk has quit IRC10:45
*** udesale_ has joined #openstack-nova10:46
*** Zames has joined #openstack-nova10:46
*** udesale has quit IRC10:49
*** Zames has quit IRC10:49
*** swamireddy has quit IRC10:51
*** tiendc has quit IRC10:52
*** udesale_ has quit IRC10:52
*** salv-orl_ has joined #openstack-nova10:53
*** zhurong has joined #openstack-nova10:55
*** salv-orlando has quit IRC10:56
*** gyankum has quit IRC10:56
*** salv-orlando has joined #openstack-nova10:58
*** lajoskatona has quit IRC10:58
*** salv-orl_ has quit IRC10:58
*** cdent has joined #openstack-nova11:01
*** Conqueror has joined #openstack-nova11:03
openstackgerritClaudiu Belu proposed openstack/nova master: WIP: replace spec with autospec  https://review.openstack.org/55729911:03
*** abalutoiu_ has quit IRC11:03
*** mdnadeem_ has joined #openstack-nova11:03
*** ratailor_ has joined #openstack-nova11:03
*** rtailor has quit IRC11:04
*** mdnadeem has quit IRC11:04
*** links has quit IRC11:04
*** salv-orlando has quit IRC11:05
*** links has joined #openstack-nova11:05
*** ratailor__ has joined #openstack-nova11:05
*** salv-orlando has joined #openstack-nova11:06
*** abalutoiu has joined #openstack-nova11:06
*** shaohe_feng has quit IRC11:08
*** mdnadeem_ has quit IRC11:08
*** ratailor_ has quit IRC11:08
*** dave-mccowan has joined #openstack-nova11:09
*** yingjun has joined #openstack-nova11:09
*** shaohe_feng has joined #openstack-nova11:13
*** sree has joined #openstack-nova11:14
*** READ10 has quit IRC11:17
*** lajoskatona has joined #openstack-nova11:19
*** sree has quit IRC11:19
*** Zames has joined #openstack-nova11:21
*** mdnadeem_ has joined #openstack-nova11:21
openstackgerritClaudiu Belu proposed openstack/nova master: WIP: replace spec with autospec  https://review.openstack.org/55729911:22
*** tuanla____ has quit IRC11:23
*** Zames has quit IRC11:24
*** tianhui has quit IRC11:24
*** tianhui has joined #openstack-nova11:25
*** shaohe_feng has quit IRC11:25
*** sree has joined #openstack-nova11:29
*** sahid has joined #openstack-nova11:30
*** yamamoto has joined #openstack-nova11:31
*** dtantsur is now known as dtantsur|brb11:31
*** sree_ has joined #openstack-nova11:32
*** sree_ is now known as Guest4082211:33
*** Zames has joined #openstack-nova11:35
*** yamamoto has quit IRC11:35
*** mvk has quit IRC11:35
*** sree has quit IRC11:35
*** salv-orl_ has joined #openstack-nova11:36
*** avolkov has joined #openstack-nova11:37
*** Zames has quit IRC11:37
priya__Hi team, my code breaks with "flavor not found" issue. It is seen that instance_types table is empty. The same code works in Mitaka. Is there any issue/upgrade for pike?11:38
*** salv-orlando has quit IRC11:41
*** moshele has quit IRC11:47
*** efried has quit IRC11:47
*** efried has joined #openstack-nova11:48
*** ktibi has quit IRC11:54
Kevin_Zhengpriya__ seems related with cells v2 structure,11:55
*** lucasagomes is now known as lucas-hungry11:55
Kevin_Zhengpike reads api_db for flavor, mitaka reads nova db, so it will work with mitaka but cannot work with pike11:58
Kevin_Zhengshould perform data migration11:58
priya__Kevin_Zheng flavor = db.flavor_get(context, inst_type_id) is the call which breaks. how do i perform data migration?12:00
*** andreas_s has quit IRC12:01
Kevin_Zhengpriya__ how did you install your nova?12:02
Kevin_Zhengwith source code or packages?12:02
*** udesale has joined #openstack-nova12:02
*** andreas_s_ has joined #openstack-nova12:02
Kevin_Zhengor devstack12:03
openstackgerritStephen Finucane proposed openstack/nova master: tox: Make everything work with Python 3  https://review.openstack.org/55689412:03
openstackgerritStephen Finucane proposed openstack/nova master: tox: Speed things up and document them  https://review.openstack.org/53438212:03
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Remove 'tools/releasenotes_tox.sh'  https://review.openstack.org/53438312:03
Kevin_Zhenganother thing is that the default flavors are removed after mitaka12:03
Kevin_Zhengso you have to create your own flavor before use12:03
*** andreas__ has joined #openstack-nova12:03
*** lajoskatona has quit IRC12:03
*** germs has joined #openstack-nova12:04
*** germs has quit IRC12:04
*** germs has joined #openstack-nova12:04
*** cdent has quit IRC12:05
*** edmondsw has joined #openstack-nova12:06
*** sapd__ has joined #openstack-nova12:06
*** andreas_s_ has quit IRC12:07
*** ragiman has quit IRC12:08
*** germs has quit IRC12:08
*** sapd_ has quit IRC12:09
*** kolesovdv has joined #openstack-nova12:10
*** ragiman has joined #openstack-nova12:11
*** abalutoiu_ has joined #openstack-nova12:11
*** abalutoiu has quit IRC12:15
*** lpetrut_ has quit IRC12:15
*** sapd__ has quit IRC12:17
*** sapd_ has joined #openstack-nova12:17
*** moshele has joined #openstack-nova12:18
*** odyssey4me has quit IRC12:22
*** odyssey4me has joined #openstack-nova12:22
*** yamamoto has joined #openstack-nova12:22
*** moshele has quit IRC12:23
priya__Kevin_Zheng through package12:25
Kevin_ZhengThen I guess you should create your own flavor before use12:25
Kevin_Zhengbecause there will be no default flavors after mitaka12:26
*** sapd_ has quit IRC12:27
*** sapd_ has joined #openstack-nova12:27
priya__Kevin_Zheng yes i have created a flavor, and that shows up in nova_api,flavors table. But it is not updated in instance_types.12:28
priya__Kevin_Zheng flavor = db.flavor_get(context, inst_type_id) refers to instance_types table and my code breaks here..i dont understand why12:28
Kevin_Zhengwhere is this code?12:30
priya__this is my custom code12:31
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Allow to specify granular CPU feature flags  https://review.openstack.org/53438412:31
kashyapalex_xu_: Thanks for the eagle eyes; I think '20' is the lucky number :-)12:31
Kevin_ZhengOK then you access the wrong db12:31
Kevin_Zhengbecause in Pike the flavor is not in that table anymore12:31
Kevin_Zhengit moved to flavors in api_db12:32
*** sapd_ has quit IRC12:32
*** sapd_ has joined #openstack-nova12:32
Kevin_Zhengyou should query that12:32
*** _ix has quit IRC12:32
alex_xu_kashyap: hah12:32
priya__Kevin_Zheng  how do i change the database to access? because db.flavor_get is in nova api code12:33
kashyapalex_xu_: Thank you!12:33
Kevin_Zhengbut you said it is your cutom code?12:33
*** zhurong has quit IRC12:34
*** abalutoiu__ has joined #openstack-nova12:34
*** andreas__ has quit IRC12:35
priya__Kevin_Zheng The call is in my custom code, howevr the db.flavor_get method def refers to nova/db/api.py(1579)flavor_get()12:35
*** andreas_s has joined #openstack-nova12:35
*** pchavva has joined #openstack-nova12:36
*** lajoskatona has joined #openstack-nova12:36
Kevin_Zhengwhich nova api did your code call?12:37
*** andreas_s has quit IRC12:37
*** _ix has joined #openstack-nova12:38
openstackgerritHironori Shiina proposed openstack/nova master: virt/ironic: Implement rescue and unrescue  https://review.openstack.org/41648712:38
*** abalutoiu_ has quit IRC12:39
*** andreas_s has joined #openstack-nova12:39
*** jackie-truong has joined #openstack-nova12:39
*** cdent has joined #openstack-nova12:40
Kevin_Zhengpriya__ sorry I have to go12:40
priya__Kevin_Zheng thank you for the help.12:41
priya__Kevin_Zheng i have used the db api12:41
gibistephenfin: I left some questions in the numa aware switches spec https://review.openstack.org/#/c/54129012:41
*** _ix has quit IRC12:47
*** MarkMielke has joined #openstack-nova12:48
cdentjaypipes, stephenfin: quick test coverage win in placement one +2 already: https://review.openstack.org/#/c/513264/12:50
jaypipescdent: cool.12:50
*** hshiina is now known as hshiina|afk12:51
*** sapd__ has joined #openstack-nova12:52
cdentthanks jaypipes12:52
*** sapd_ has quit IRC12:52
*** lucas-hungry is now known as lucasagomes12:55
*** salv-orlando has joined #openstack-nova12:56
*** salv-or__ has joined #openstack-nova12:57
efriedmikal: I do not accept your admonishment.  I may have been mistaken or talked out of the more substantive issues, but taken at face value, those would have justified further work on the patch.12:58
*** salv-orl_ has quit IRC12:58
*** mvk has joined #openstack-nova12:58
efriedmikal: Thank you for the updates.  Hugs!12:58
jaypipesefried: so...13:00
jaypipesefried: on https://review.openstack.org/#/c/557187/ I'm torn13:01
jaypipesefried: we don't have a good set of unit tests for the placement HTTP handlers13:01
cdent(on purpose)13:01
*** salv-orlando has quit IRC13:02
jaypipesefried: and asking Johannes to create one from scratch is a bit much for a one-byte patch13:02
jaypipesefried: I would just as much say let's merge the thing13:02
*** salv-or__ has quit IRC13:02
efriedThat's fair, I didn't realize we didn't have a framework in place that would make it trivial (I didn't look).13:02
jaypipesefried: yeah, we don't have unit tests for this stuff really.13:03
*** salv-orlando has joined #openstack-nova13:03
jaypipesefried: that said, we could ask for a gabbit to be added that would force this code path13:03
cdentJust so it is clear, the lack of unit tests is supposed to reflect that anything that ought to have a unit test is in a different file13:03
jaypipesI think..13:03
cdentjaypipes: it won't work without multiple processes13:03
efriedBut in any case, not in this patch.13:04
jaypipescdent: right.13:04
cdentdelicately controlled multiple processes13:04
efriedjaypipes, cdent: I flipped to +1.13:04
efriedthanks for setting me straight there.13:04
*** lbragstad has joined #openstack-nova13:04
* cdent adds something to his to do list for the placement contrib docs13:04
jaypipesefried: like I said, I'm a bit torn, but I think I land on the "just merge this" side.13:05
efriedjaypipes: I'm fine with that, especially given it's a clearly correct fix to a clear mistake in the code.13:05
efriedIf writing the test were trivial, that would be one thing.13:05
*** mriedem has joined #openstack-nova13:06
jaypipesefried: right, agreed.13:07
*** salv-orlando has quit IRC13:08
*** _ix has joined #openstack-nova13:09
openstackgerritSurya Seetharaman proposed openstack/nova master: Allow scheduling only to enabled cells (Filter Scheduler)  https://review.openstack.org/55052713:09
openstackgerritSurya Seetharaman proposed openstack/nova master: Add --enable and --disable options to  nova-manage update_cell  https://review.openstack.org/55541613:10
openstackgerritSurya Seetharaman proposed openstack/nova master: Update the cells FAQs and scheduler maintenance docs.  https://review.openstack.org/55645913:10
*** lyan has joined #openstack-nova13:12
*** lyan is now known as Guest3332013:13
*** Zames has joined #openstack-nova13:13
*** _ix has quit IRC13:14
*** eharney has joined #openstack-nova13:14
*** dtantsur|brb is now known as dtantsur13:15
*** Zames has quit IRC13:17
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Allow abort live migrations in queued status  https://review.openstack.org/53672213:17
*** gouthamr has joined #openstack-nova13:19
efriedjaypipes, edleafe: turns out we're not restricting characters on RP names.  I just created RPs with names chr(0)-chr(127).  Do we have a SQL injection hole, or is sqla providing the necessary escaping security blanket so we don't have to worry about it?13:25
*** Guest40822 has quit IRC13:27
*** sree has joined #openstack-nova13:28
jaypipesefried: sqlalchemy (and in fact the Python DB API) provides the protection against SQL injection attacks.13:29
*** psachin has quit IRC13:30
mriedemdansmith: regarding that [database]/connection setting in nova.conf for the api / controller services, i just noticed that the install guide for the controller tells you to set the [database]/connection to the 'nova' db, rather than nova_cell0 https://docs.openstack.org/nova/latest/install/controller-install-ubuntu.html#install-and-configure-components13:31
mriedemwhich, if you're not doing 'superconductor' mode, isn't a big deal13:32
dansmithmriedem: probably from pre-cells switchover though13:32
dansmithlike we never updated it13:32
*** udesale has quit IRC13:32
*** sree has quit IRC13:33
*** olivenwk has joined #openstack-nova13:33
mriedemyeah, https://docs.openstack.org/nova/latest/user/cells.html#first-time-setup says, "If your databases are on separate hosts then you should specify --database_connection or make certain that the nova.conf being used has the [database]/connection value pointing to the same user/password/host that will work for the cell0 database."13:33
*** kolesovdv has quit IRC13:34
mriedemwith the current install guide instructions, i don't think cell0 db sync ever runs13:34
dansmithack, we should probably audit all that stuff in modern times13:35
*** yangyapeng has quit IRC13:35
*** alexchadin has quit IRC13:37
mriedemoh nvm, db sync defaults to find the cell0 mapping and sync it13:37
*** zhaochao has joined #openstack-nova13:37
olivenwkHello, I try to add aliases in nova. Why alias ={ "vendor_id":"1002", "product_id":"6938", "device_type":"type-PCI", "name":"R9-380X" } followed by alias ={ "vendor_id":"10de", "product_id":"1b06", "device_type":"type-PCI", "name":"GTX1080Ti" } works and not alias=[{ "vendor_id":"1002", "product_id":"6938", "device_type":"type-PCI", "name":"R9-380X" },{ "vendor_id":"10de", "product_id":"1b06", "device_type":"type-PCI", "name":"GTX1080Ti" }]13:37
olivenwkbut if I write my alias in the array fashion ONLY on the compute node it works13:38
olivenwkseems to be controller node related, any ideas?13:38
*** alexchadin has joined #openstack-nova13:39
*** damien_r has quit IRC13:40
*** liverpooler has joined #openstack-nova13:41
*** damien_r has joined #openstack-nova13:42
*** damien_r has quit IRC13:43
openstackgerritKonstantinos Samaras-Tsakiris proposed openstack/nova master: Add `hide_hypervisor_id` flavor extra_spec  https://review.openstack.org/55586113:45
*** tbachman has joined #openstack-nova13:46
*** cdent has quit IRC13:47
*** amodi has joined #openstack-nova13:48
*** damien_r has joined #openstack-nova13:49
*** burt has joined #openstack-nova13:49
*** tbachman_ has joined #openstack-nova13:49
*** tbachman has quit IRC13:51
*** tbachman_ is now known as tbachman13:51
*** damien_r has quit IRC13:51
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Allow abort live migrations in queued status  https://review.openstack.org/53672213:52
gibijaypipes: I left two questions in the nested a_c spec https://review.openstack.org/#/c/556873/13:52
*** salv-orlando has joined #openstack-nova13:53
*** _ix has joined #openstack-nova13:53
*** Spazmotic has joined #openstack-nova13:54
*** awaugama has joined #openstack-nova13:54
mriedemeric-young: https://review.openstack.org/#/c/554679/ is now released in os-brick 2.4.0, you should push a change to the openstack/requirements repo to bump the minimum required version to 2.4.0 in global-requirements13:55
*** cdent has joined #openstack-nova13:55
mriedemand then make https://review.openstack.org/#/c/554679/ depend on it13:55
*** efried has quit IRC13:56
*** efried has joined #openstack-nova13:56
*** damien_r has joined #openstack-nova13:56
*** ratailor_ has joined #openstack-nova13:58
dansmithhmm, someone removed the placement-req series from the runways etherpad queue13:58
dansmithoh, nevermind, it got moved down apparently13:59
mriedemheh, the glory of etherpads14:00
mriedempre-emptible runways14:00
mriedemso uh, do we wait for melwitt to move things from the queue into the actual slots?14:00
*** yassine has quit IRC14:00
dansmithyeah I went to look because I expected she moved things into the slots after yesterday14:01
dansmithwe have a meeting at 8 so she should be around then-ish I think14:01
*** ratailor__ has quit IRC14:01
mriedemthere is a procedure on L24 so i guess anyone could just follow that14:01
openstackgerritEric Fried proposed openstack/nova master: Slugification utilities for placement names  https://review.openstack.org/55662814:02
*** yassine has joined #openstack-nova14:02
bauzasdo we really need slots for priority series ?14:02
mriedemefried: please confirm your availability for the update_provider_tree bp for runways slot numero uno for the next dos weeks14:02
openstackgerritSurya Seetharaman proposed openstack/nova master: Allow scheduling only to enabled cells (Filter Scheduler)  https://review.openstack.org/55052714:02
openstackgerritSurya Seetharaman proposed openstack/nova master: Add --enable and --disable options to  nova-manage update_cell  https://review.openstack.org/55541614:02
openstackgerritSurya Seetharaman proposed openstack/nova master: Update the cells FAQs and scheduler maintenance docs.  https://review.openstack.org/55645914:02
efriedcdent: edleafe: Any idea how I can finagle my string so that json encoding doesn't bounce with UnicodeDecodeError for characters >127?14:02
efriedmriedem: Confirmed.14:03
bauzasI mean, I can review those priority series without needing a slot14:03
efriedmriedem: Confirmado?14:03
*** jackie-truong has quit IRC14:03
bauzasbecause I know about the implementations, and I don't need to understand it14:03
cdentefried: I'm non in-conext. Have you got code to point at?14:04
mriedemANNOUNCEMENT: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/update-provider-tree is now in runway slow #114:04
efriedmriedem: Nice freudian slip there.14:04
*** damien_r has quit IRC14:04
mriedemha14:04
mriedemoh well, it's not recorded14:04
mriedemi mean, it is14:04
mriedembut not via bot14:04
mriedemis kashyap going to write a runway bot?14:04
* kashyap hides14:05
mriedemthat would actually be kind of nice...to post to a wiki rather than etherpad14:05
*** udesale has joined #openstack-nova14:05
dansmithwe could tweak the channel topic14:05
*** germs has joined #openstack-nova14:05
*** germs has quit IRC14:05
*** germs has joined #openstack-nova14:05
*** udesale has quit IRC14:05
dansmithI dunno that release schedule is that necessary as it's easily google-able14:05
*** dklyle has joined #openstack-nova14:05
*** david-lyle has quit IRC14:05
*** udesale has joined #openstack-nova14:05
efriedcdent: In writing https://review.openstack.org/#/c/556628/ I was brought to realize we're not restricting characters for RP names.  I tried chr(0)-chr(127) and they all worked fine.  But when I start trying chr(128)-chr(256) I get UnicodeDecodeError from the ksa session json encoder.14:05
*** esberglu has joined #openstack-nova14:05
cdent128-256 is not valid unicode14:06
mriedemdansmith: or just link https://etherpad.openstack.org/p/rocky-nova-priorities-tracking in the channel topic and link the runways etherpad from the top of that14:06
mriedemor a gerrit dashboard link,14:06
mriedemwhere mel controls the starred patches per runway that go into said dashboard14:06
mriedemor something14:06
*** hongbin has joined #openstack-nova14:06
dansmithwell, it'd just be nice to see names as reminders instead of the same url week to week, is what I meant14:07
dansmith(hence the irc announcement part of that procedure)14:07
*** dklyle has quit IRC14:07
mriedemso like, current runways: update-provider-tree, placement-req, foobars14:07
dansmithcha14:07
openstackgerritElod Illes proposed openstack/nova stable/ocata: Functional test for regression bug #1713783  https://review.openstack.org/50516014:07
openstackbug 1713783 in OpenStack Compute (nova) ocata "After failed evacuation the recovered source compute tries to delete the instance" [High,In progress] https://launchpad.net/bugs/1713783 - Assigned to Balazs Gibizer (balazs-gibizer)14:07
openstackgerritElod Illes proposed openstack/nova stable/ocata: Set error state after failed evacuation  https://review.openstack.org/51873314:07
*** dklyle has joined #openstack-nova14:07
*** damien_r has joined #openstack-nova14:08
mriedemwfm14:08
*** ChanServ sets mode: +o dansmith14:08
*** hemna_ has joined #openstack-nova14:08
efriedcdent: So JSON strings have to be unicode I take it.14:08
*** dansmith changes topic to "Current runways: update-provider-tree / <EMPTY> / <EMPTY> -- This channel is for Nova development. For support of Nova deployments, please use #openstack."14:08
mriedemso i guess next in line is privsep14:08
cdentefried: it depends on which layer you're at, over the wire JSON is supposed to always be utf-8 encode unicode14:09
*** dansmith changes topic to "Current runways: update-provider-tree / hurrah-for-privsep-again / <EMPTY> -- This channel is for Nova development. For support of Nova deployments, please use #openstack."14:09
*** germs has quit IRC14:09
*** jbernard has quit IRC14:09
mriedemmikal: please confirm your availability for https://blueprints.launchpad.net/nova/+spec/hurrah-for-privsep-again reviews for the next 2 weeks14:09
*** jbernard has joined #openstack-nova14:10
*** jackie-truong has joined #openstack-nova14:10
*** damien_r has quit IRC14:10
mriedemlikely not to hear about that for several hours14:10
dansmithmriedem: heh, that answer won't come for 10 hours14:10
dansmithyeah14:10
*** yangyapeng has joined #openstack-nova14:10
cdentefried: once you see the results in python, it should be unicode strings (or numbers)14:10
dansmithsince the queue is fresh I tend to think we can assume in this case, but...14:10
mriedemdansmith: please confirm your availability for https://blueprints.launchpad.net/nova/+spec/placement-req-filter reviews for the next 2 weeks14:11
*** ratailor_ has quit IRC14:11
dansmithmriedem: I will be available with the exception of this coming friday which is a company holiday, but I don't anticipate that being significant14:11
mriedemEASTER!14:11
efrieddansmith, mriedem: FWIW mikal has been responsive to those patches within a couple days up to this point.  And with I think one or two exceptions, they've all been scrubbed to multiple-+1-ness at this point.14:11
dansmithefried: aye14:12
mriedemCONFIRMED14:12
edleafeHeh - "slow" [t2LP0]14:12
*** dansmith changes topic to "Current runways: update-provider-tree / hurrah-for-privsep-again / placement-req-filter -- This channel is for Nova development. For support of Nova deployments, please use #openstack."14:12
edleafeLemme fix that [t 2LP0]14:12
purplerbot<mriedem> ANNOUNCEMENT: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/update-provider-tree is now in runway slow #1 [2018-03-28 14:04:13.785517] [n 2LP0]14:12
* mriedem goes to review non-runway stuff14:12
dansmithheh14:12
efrieddansmith: I happened to notice that mikal (whether on purpose or not) changed the commit message tags from 'hurrah-for-privsep-again' to 'hurrah-for-privsep' in the last spin.14:13
efriedI didn't go and check what the bp is actually called.14:13
dansmithefried: that's likely git-review14:13
efriedit was in the commit message, not the topic14:13
dansmithoh14:15
*** mchlumsky has joined #openstack-nova14:17
bhagyashrismriedem, alex_xu_: Hi, Thanks for review! Addressed review comments on spec https://review.openstack.org/#/c/511825/ request to re-visit14:18
*** mlavalle has joined #openstack-nova14:18
mriedemok14:18
kashyap20 is the lucky number, if anyone looking for a trivial feature to +2 (it already has +2 from Alex): https://review.openstack.org/#/c/534384/14:21
kashyapZuul has to bless & kiss it, though14:23
openstackgerritLee Yarwood proposed openstack/nova stable/pike: Remove usage of kwarg retry_on_request in API  https://review.openstack.org/55734814:23
*** alexchadin has quit IRC14:24
bauzasefried: I don't know if it's you that wrote https://etherpad.openstack.org/p/nova-runways-rocky L39 but I think virt driver changes using nested resources shoukdn't be using that slot14:25
mriedemthe placement aggregates api confuses me every time i look at it14:25
efriedbauzas: It was, and I agree they shouldn't.14:25
efriedmriedem: How so?  Maybe we can fix the docs.14:25
bauzasefried: because those need specific domain expertise, and I think it's a separate runway slot then14:25
efriedbauzas: They're also a separate piece of work, *using* the upt bp, not part of its implementation.14:26
mriedemefried: i think it's just because there is no POST for aggregates14:26
*** damien_r has joined #openstack-nova14:26
mriedembut i know that's intentional14:26
efriedmriedem: Yeah, they get created (but not deleted!) dynamically.14:26
*** jogo has quit IRC14:26
mriedemPUT /resource_providers/{uuid}/aggregates means to just associate a resource provider with an aggregate uuid which may or may not exist14:26
efriedcdent, mriedem: by the same token, I think https://review.openstack.org/#/c/556669/ is not technically part of bp/placement-aggregate-generation, in which case that bp can be marked as implemented.14:27
efriedbauzas: ^14:27
*** r-daneel has joined #openstack-nova14:28
*** ralonsoh has quit IRC14:29
efriedmriedem: disregard, I see it already is.14:30
* efried doesn't know how to read blueprints.14:30
*** r-daneel has quit IRC14:32
*** r-daneel has joined #openstack-nova14:33
*** felipemonteiro has joined #openstack-nova14:33
*** jogo has joined #openstack-nova14:33
*** moshele has joined #openstack-nova14:33
openstackgerritLee Yarwood proposed openstack/nova stable/pike: Remove usage of kwarg retry_on_request in API  https://review.openstack.org/55734814:34
cdentefried: did you figure out the unicode thing? I'm timeslicing, so not sure if that loop is closed14:34
efriedcdent: I was about to go start playing with u'\xXXX' strings.  I'll pester you again, I'm sure :)14:35
cdent14:35
*** sapd__ has quit IRC14:37
*** sapd__ has joined #openstack-nova14:38
*** sapd__ has quit IRC14:40
*** moshele has quit IRC14:40
*** sapd__ has joined #openstack-nova14:41
*** sapd__ has quit IRC14:41
*** kholkina has quit IRC14:41
*** sapd__ has joined #openstack-nova14:41
*** sapd__ has quit IRC14:41
*** sapd__ has joined #openstack-nova14:42
*** damien_r has quit IRC14:42
*** moshele has joined #openstack-nova14:43
*** moshele has quit IRC14:45
openstackgerritChris Dent proposed openstack/nova master: [placement] Add to contributor docs about handler testing  https://review.openstack.org/55735514:45
cdentjaypipes, efried: the aforementioned to do list item related to handler unit testing ^14:45
cdentsigh, had to be at least one typo14:47
openstackgerritChris Dent proposed openstack/nova master: [placement] Add to contributor docs about handler testing  https://review.openstack.org/55735514:48
mriedemi need a non-lee stable core to approve https://review.openstack.org/#/c/555029/ so we can do a queens release14:50
mriedemthere is also a bunch more https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/queens+label:Code-Review=214:50
mriedemif someone were so inclined14:50
*** udesale has quit IRC14:50
*** efried has quit IRC14:51
dansmithmriedem: got that one14:51
*** efried has joined #openstack-nova14:52
*** damien_r has joined #openstack-nova14:54
*** Conqueror has quit IRC14:55
*** Spaz-Home has joined #openstack-nova14:55
* alex_xu_ gives up today14:57
*** kevinbenton has quit IRC14:58
*** udesale has joined #openstack-nova14:59
*** damien_r has quit IRC14:59
*** Spazmotic has quit IRC14:59
*** r-daneel has quit IRC15:00
efriedcdent: FYI, using unichr(x) let me run numbers over 127 just fine.15:01
efriedcdent, jaypipes: I created RPs with names up to unichr(64K) and they all succeeded.15:01
efriedJFYI.15:01
* cdent wonders what promped efried to not believe in python15:02
efriedwhich part was me not believing in python?15:02
cdentis unichr codepoints or byte descriptions of unicode encodings15:02
efriedYou're just talking gibberish now.15:02
edleafeefried: please use six.unichr()15:02
edleafe'unichr' is undefined in python315:03
efriedI'm not using it for code edleafe, was just using it for testing purposes.15:03
*** links has quit IRC15:03
cdentefried: do you mean you don't know what a codepoint is?15:03
edleafeefried: ok, I thought that this was going in your slugify stuff15:03
*** udesale has quit IRC15:03
efriedthough edleafe cdent it makes me wonder whether https://review.openstack.org/#/c/556628/ is going to DTRT when translating a unicode input.15:03
efriedcdent: I don't really even know what unicode is.15:04
*** felipemonteiro_ has joined #openstack-nova15:04
efriedcdent: I mean, beyond "a big freaking table of character encodings"15:04
cdentefried: then you've answered my question about beliving in python15:04
melwittdansmith, mriedem: I had been thinking that anyone in the core team could move things from the queue into the runways, not only me15:04
*** damien_r has joined #openstack-nova15:05
edleafecdent: to answer your question, bytes15:05
cdentefried: I will look at that code for real when I get home, but it looks like overkill. Is there associated brokenness that demands it (other than length)15:05
efriededleafe, cdent: Answer: it breaks handily.15:05
kashyapmriedem: dansmith: Thanks for the thorough review, I'll address the comments tomm; today I have to head out early15:05
*** kevinbenton has joined #openstack-nova15:06
kashyapdansmith: BTW, if I use a warning, instead of 'exception.Invalid', would you still want a test for that? -- https://review.openstack.org/#/c/534384/20/nova/virt/libvirt/driver.py15:06
efriedcdent: The commit message explains the need for it.  Basically, I don't want every impl of update_provider_tree (or other things that need to generate names for placement entities) to have to be aware of character restrictions and length rules, and write their own slugifier.15:06
dansmithkashyap: yes15:06
kashyapdansmith: Not that I _don't_ want to write, just trying to keep things as minimal as possible :-)15:06
*** r-daneel has joined #openstack-nova15:07
* cdent nods and heads home15:07
kashyapdansmith: Alright15:07
*** felipemonteiro has quit IRC15:07
kashyapmriedem:  Especially, appreciate the eagle eyes on wording.  I agree with all those points.15:08
*** pcaruana has quit IRC15:09
*** cdent has quit IRC15:10
kashyapmriedem: On expanding acroynms ... I have a handy little package (less than 1MB) on my linux distribution.  That goes like:15:10
kashyap$> wtf is wrt15:11
kashyapWRT: with respect to15:11
kashyap$> wtf is iirc15:11
kashyapIIRC: if I {recall,remember} correctly15:11
kashyapAnd lastly:15:11
kashyap$> wtf is wtf15:11
kashyapWTF: where's the food15:11
kashyap{what,when,where,who,why} the fuck15:11
* kashyap stops the spam15:11
kashyapThe RPM is called:15:11
kashyap$> rpm -qf `which wtf`15:11
kashyapbsd-games-2.17-53.fc26.x86_6415:11
*** gyankum has joined #openstack-nova15:11
mriedemi know what wrt means15:12
mriedemi wouldn't assume that all non-native english speakers have that nifty package15:12
kashyapmriedem: Only joking; I know what you meant: "Be sensitive to non-native speakers"15:12
*** zhaochao has quit IRC15:13
bauzasmriedem: will look at stable changes soon or later15:13
*** Spazmotic has joined #openstack-nova15:13
*** Spaz-Home has quit IRC15:14
mriedembauzas: that's a time range i can bank on15:15
* bauzas tries to duplicate himself15:15
bauzasbut for the moment, kids are too young to code15:16
bauzasthat's a shame15:16
bauzasI'm pretty sure a 7-yo kid can code better than me15:16
*** bhujay has quit IRC15:18
* edleafe notices no one is arguing that point15:18
bauzasif you consider it that way, algorithms are easily understood by young children, and sometimes they can guess patterns better than adults15:21
bauzasso yeah I affirm some kid can beat me on that15:21
*** rmart04 has left #openstack-nova15:23
dansmithlyarwood: can you hit this? https://review.openstack.org/#/c/554600/15:24
* lyarwood looking15:24
openstackgerritSurya Seetharaman proposed openstack/nova-specs master: Handling a down cell  https://review.openstack.org/55736915:26
*** imacdonn has quit IRC15:26
*** imacdonn has joined #openstack-nova15:27
openstackgerritClaudiu Belu proposed openstack/nova master: tests: fixes mock autospec usage  https://review.openstack.org/44750515:29
openstackgerritClaudiu Belu proposed openstack/nova master: tests: autospecs all the mock.patch usages  https://review.openstack.org/47077515:29
openstackgerritClaudiu Belu proposed openstack/nova master: WIP: replace spec with autospec  https://review.openstack.org/55729915:29
*** olivenwk has quit IRC15:30
mriedemso i guess the placement api-ref hasn't been updated for 1.21 yet? https://docs.openstack.org/nova/latest/user/placement.html#support-member-of-aggregates-queryparam-on-get-allocation-candidates15:30
mriedemhttps://developer.openstack.org/api-ref/placement/#list-allocation-candidates15:30
*** jaypipes is now known as jaypipes-away15:30
claudiubwelp, I've found a bug in the vmware driver because of the mock autospec patch. :D https://review.openstack.org/#/c/470775/28/nova/virt/vmwareapi/driver.py15:31
*** lajoskatona has quit IRC15:31
claudiubshould create a bug report.15:31
mriedembauzas: in the time you spent talking about your kid out-coding you, you could have just looked at those stable patches15:31
bauzasfor 2 mins ?15:32
* bauzas hides then15:32
mriedemedleafe: can you push a fix for this? https://review.openstack.org/#/c/552098/9/placement-api-ref/source/allocation_candidates.inc@3515:33
*** sahid has quit IRC15:34
edleafemriedem: in a meeting - will get to it soon15:35
mriedemjaypipes-away: dansmith: alex_xu_: efried: edleafe: did i miss the point about https://review.openstack.org/#/c/555413/ being ok to change the member_of behavior in the 1.21 microversion?15:36
dansmithmriedem: it's not going to change 1.2115:36
efriedmriedem: You're right, we weren't being particularly precise, but it was understood that we were going to cut a new microversion.15:37
mriedemok https://review.openstack.org/#/c/555413/3/specs/rocky/approved/alloc-candidates-member-of.rst@17215:37
mriedemi see that now15:37
openstackgerritArtom Lifshitz proposed openstack/nova-specs master: NUMA-aware live migration  https://review.openstack.org/55272215:37
mriedemwhew15:37
melwittdansmith: can you hit these queens backports pls https://review.openstack.org/#/c/55591415:38
dansmithmelwitt: when I'm done with downstream bug paperwork :/15:39
melwitt:(15:39
mriedemso i guess we should re-open https://blueprints.launchpad.net/nova/+spec/alloc-candidates-member-of15:40
mriedemright?15:40
dansmithmriedem: I don't care what we do for the process15:42
openstackgerritClaudiu Belu proposed openstack/nova master: vmware: Fixes _detach_instance_volumes method  https://review.openstack.org/55737715:43
openstackgerritEric Fried proposed openstack/nova master: Slugification utilities for placement names  https://review.openstack.org/55662815:44
claudiubwho's working on the vmware driver?15:44
*** sree has joined #openstack-nova15:44
claudiubso i can add them as reviewers to the patch15:45
*** sahid has joined #openstack-nova15:45
mriedemclaudiub: cdent is the gateway15:45
mriedemb/c the others aren't ever in channel15:45
claudiubah, cool.15:45
claudiubthanks. :)15:45
claudiubadded him to the vmware driver patch, he doesn't seem to be here though.15:46
openstackgerritMerged openstack/nova master: Add more functional test for placement.usage  https://review.openstack.org/51326415:46
openstackgerritMerged openstack/nova master: Fix spelling mistake of HTTPNotFound exception  https://review.openstack.org/55718715:46
openstackgerritMerged openstack/nova-specs master: Amend the member_of spec for multiple query sets  https://review.openstack.org/55541315:47
*** abhishekk has joined #openstack-nova15:48
melwittclaudiub: thanks for the patch, I'll take a look at it too15:49
*** sree has quit IRC15:49
claudiubnp. :)15:50
*** andreas_s has quit IRC15:51
claudiubIMO, we should merge the autospec stuff as soon as possible, so we can avoid simple stuff like this. :)15:51
mriedemso uh,15:51
mriedemthis means you basically can't attach/detach volumes with the vmware driver,15:51
*** andreas_s has joined #openstack-nova15:51
mriedemsince...who knows how long, right?15:51
*** Zames has joined #openstack-nova15:51
mriedemand their CI never caught this?15:51
claudiubyeah, that's pretty much what I get from it as well.15:51
mriedemshould be a -2 on all vmware driver specs until they can fix their CI then15:52
openstackgerritEric Fried proposed openstack/nova master: Slugification utilities for placement names  https://review.openstack.org/55662815:52
melwittyeah, I'm trying to find what's up with their CI. maybe it only runs on vmware driver patches?15:52
claudiubthat method is called in destroy15:52
melwittI noticed the xen driver CI works like that. it only runs on xen driver patches15:52
claudiubi think that they can still attach / detach volumes, but it will fail when they're destroying instances with volumes attached.15:53
claudiubstill should have been caught by their CI in boot-from-volume cases15:54
*** Zames has quit IRC15:54
mriedemso maybe just got lucky by tempest always detaching volumes before they were deleted15:54
*** itlinux has joined #openstack-nova15:54
claudiubcan you detach a volume which is used as boot-from-volume?15:54
melwittI didn't think so15:55
mriedemno15:55
*** Eran_Kuris has quit IRC15:55
*** andreas_s_ has joined #openstack-nova15:55
mriedemtheir CI doesn't usually report at all15:55
mriedemhttps://review.openstack.org/#/c/553411/ was posted on march 1515:55
mriedemno CI response15:55
melwittah, bummer. I checked on the xen one recently and it has recent runs but only on xen patches15:56
*** andreas_s has quit IRC15:56
mriedemi'm personally fine with 3rd party CI running on restricted sets of the tree15:56
mriedemfor the most part15:56
mriedembut to not run on changes for that driver at all, is unacceptable15:57
melwittyup, same. the only downside is it's harder to notice when it goes MIA15:57
mriedemi used to have to post a quarterly thing to the ML about how the vmware CI wasn't running or was broken15:57
melwittbut that's a lot more minor thing15:57
*** belmoreira has quit IRC15:57
melwittyeah, I remember15:57
* mriedem posts patch to warn about quality on startup15:58
*** chyka has joined #openstack-nova15:59
*** chyka has quit IRC15:59
melwittI'll mail the list about the vmware CI, see if anyone responds this time16:00
*** chyka has joined #openstack-nova16:00
*** felipemonteiro_ has quit IRC16:00
*** andreas_s_ has quit IRC16:00
openstackgerritClaudiu Belu proposed openstack/nova master: vmware: Fixes _detach_instance_volumes method  https://review.openstack.org/55737716:01
openstackgerritMatt Riedemann proposed openstack/nova master: vmware: log quality warning on startup  https://review.openstack.org/55739816:02
openstackgerritEric Fried proposed openstack/nova master: Make generation optional in ProviderTree  https://review.openstack.org/53932416:04
*** fragatin_ has quit IRC16:05
*** gyee has joined #openstack-nova16:06
*** andreas_s has joined #openstack-nova16:06
*** sahid has quit IRC16:08
*** amodi has quit IRC16:10
*** andreas_s has quit IRC16:10
*** gjayavelu has joined #openstack-nova16:12
mriedemedleafe: nvm, the docs thing for placement and 1.21 can be fixed in https://review.openstack.org/#/c/554357/16:12
edleafemriedem: heh, I was just about to push a fix16:13
*** lucasagomes is now known as lucas-afk16:13
edleafeI'll just combine them16:13
*** yingjun has quit IRC16:17
*** ragiman has quit IRC16:18
*** cdent has joined #openstack-nova16:18
lyarwooddansmith: https://review.openstack.org/#/c/557348/ - would you mind looking at this retry_on_request removal backport to stable/pike that came up internally earlier?16:18
dansmithlyarwood: I assume we don't need to do that in upstream stable because of g-r right?16:18
dansmith(if it's not already broken I mean)16:19
lyarwooddansmith: well upstream outside of TripleO no we don't need to do this16:19
lyarwooddansmith: but even with g-r I think this is broken for TripleO16:20
dansmithI would defer to mriedem on that16:20
dansmithif it's capped by u-c I think we're fine as-is, and if not, we broke ourselves16:20
dansmithI would suspect maybe upstream tripleo isn't honoring u-c?16:21
lyarwoodvery likely16:21
lyarwoodit's all RPMs there and I don't recall seeing the same u-c rules in the specs16:21
mriedem-16:23
mriedem-116:23
mriedem-516:23
mriedemb/c of what dan said16:23
mriedemthe decorator was removed in oslo.db 4.30,16:23
mriedemstable/pike is capped at 4.25.1 https://github.com/openstack/requirements/blob/stable/pike/upper-constraints.txt#L43316:23
mriedemso tripleo should be relying on u-c16:23
lyarwoodmriedem: nice thanks16:23
edleafeugh, heavy lightning around here - power drops have kicked me off the internet 3 times already.16:24
* mriedem waits for the 30 tripleo cores to explain why they are special16:24
dansmithmriedem: oh they're special alright16:25
*** diga has joined #openstack-nova16:25
cdentmriedem, melwitt: all I'm able to update on the vmware sitiuation is that you've got their attention, so reasonable strategy16:28
*** sshwarts has quit IRC16:28
*** jackie-truong has quit IRC16:28
melwittcdent: ack16:29
openstackgerritMerged openstack/nova stable/queens: Preserve multiattach flag when refreshing connection_info  https://review.openstack.org/55502916:29
mriedemdansmith: tssurya: melwitt: i assume we're having a cells meeting today?16:30
mriedemthere is at least one new bug i wanted to talk about16:30
dansmithmriedem: I was going to ask if we needed to16:31
dansmithsounds like we do16:31
melwittyeah, if we have topics, we can meet16:31
*** yangyapeng has quit IRC16:32
mriedemunless we just want to skip and talk about the specific bug here16:32
melwitteither way wfm16:32
dansmithI'm good to skip if it's just one bug16:33
dansmithI got nothing else16:33
mriedemwait to see what tssurya says, she's the busy one16:37
*** Spaz-Home has joined #openstack-nova16:37
tssuryaI am good to skip too16:37
mriedemhot dog16:38
mriedemok so just wanted to talk about options for https://bugs.launchpad.net/nova/+bug/175931616:38
openstackLaunchpad bug 1759316 in OpenStack Compute (nova) queens "pre-cells_v2 nova-osapi_compute service in database breaks instance lookup" [Medium,Confirmed]16:38
dansmithokay16:38
mriedembasically an upgrade issue for someone that was hard to figure out since there are no logs16:38
mriedemupgrading newton->ocata16:38
mriedemat this point, if you're not using cells v1 and you get here, https://github.com/openstack/nova/blob/ed55dcad83d5db2fa7e43fc3d5465df1550b554c/nova/compute/api.py#L2269  - i think we should log a warning16:39
mriedem^ was added in newton16:39
mriedemso if you're hitting that in ocata+ it likely means you're going to have issues16:39
dansmithso, I thought we removed some of this recently16:39
dansmithwhen I did the instance list bit16:39
mriedemi've had some patches to try and remove some things from the cells v2 transition but they are in limbo,16:40
*** fragatina has joined #openstack-nova16:40
mriedemthere was also a thing i tried removing from the local delete flow and was hitting weird errors, but i forget the details16:40
dansmithbut on ocata we can't eliminate that check just yet16:40
*** yamahata has joined #openstack-nova16:40
dansmithso yeah, you want to warn if we take that path and we're not on cellsv1 right?16:40
mriedemi'm not saying remove it,16:40
mriedemyes16:40
mriedemwarn and backport that warning16:41
dansmithyeah I think that makes sense16:41
melwittyeah, warning makes sense16:41
mriedemok16:41
mriedemthey were also asking if nova-status could check for this,16:41
mriedemwhich isn't unreasonable16:41
dansmithif you will do the nova-status change I'll do the warning :D16:41
mriedemha16:41
*** Spazmotic has quit IRC16:41
mriedemi'm ok with nova-status, but need input on how the check is going to work, see 2nd paragraph in https://bugs.launchpad.net/nova/+bug/1759316/comments/116:41
openstackLaunchpad bug 1759316 in OpenStack Compute (nova) queens "pre-cells_v2 nova-osapi_compute service in database breaks instance lookup" [Medium,Confirmed]16:41
openstackgerritEd Leafe proposed openstack/nova master: Address issues raised in adding member_of to GET /a-c  https://review.openstack.org/55435716:42
edleafejaypipes-away: mriedem: ^^ Addressed the outstanding issues16:43
dansmithyou can just return "maybe a problem" with basically that text right? "I found an old entry in cell foo and it might be a problem or might not, but fyi"16:43
*** germs has joined #openstack-nova16:43
*** germs has quit IRC16:43
*** germs has joined #openstack-nova16:43
mriedemdansmith: yeah that's what i was thinking, we have ok, warning and error for nova-status16:43
mriedemso this would be a warning16:43
mriedemsince we aren't sure how you've configured the api16:43
dansmithrigh16:43
*** germs has quit IRC16:43
mriedemalright i can work up a nova-status patch for that16:44
mriedemor die trying16:44
*** germs has joined #openstack-nova16:44
*** germs has quit IRC16:44
*** germs has joined #openstack-nova16:44
dansmithcool16:44
melwittlol, pls don't die16:44
*** ChanServ sets mode: -o dansmith16:44
*** lpetrut has quit IRC16:45
tssuryamelwitt: https://review.openstack.org/#/c/557369/16:45
tssuryaJust informing16:45
melwittokay, cool. spec for handling a down cell, we can start reviewing that. and I can depend on it for my related quotas-from-placement-and-instance-mappings spec16:47
melwittthanks16:47
tssuryadansmith: this is the re-rebase after the UUID shift revert, https://review.openstack.org/#/c/539501/ , whenever you have the time have a look16:49
dansmithokay16:49
mriedembhagyashris: so i guess we don't send notifications for createBackup?16:51
*** diga has quit IRC16:51
openstackgerritMerged openstack/nova stable/queens: Add --by-service to discover_hosts  https://review.openstack.org/55460016:52
mriedembhagyashris: replies in https://review.openstack.org/#/c/511825/16:53
*** trozet has quit IRC16:53
openstackgerritMathieu Gagné proposed openstack/nova-specs master: Multiple Fixed-IPs support in network information  https://review.openstack.org/31262616:54
*** tssurya has quit IRC16:54
*** gouthamr has quit IRC16:55
*** mvk has quit IRC16:56
melwittmriedem, dansmith: on this spec ^ it's about changing 'ip_address' in the metadata API to 'ip_addresses' to include all available interfaces for the guest, in a new metadata API version. there was a related issue about changing the metadata API to to show IP addresses even if there is a DHCP server present (currently it does not). there was a question on the spec about whether those two issues should be combined in one spec and one16:58
melwitt new metadata API version or if they should be separated into two specs and versions16:58
melwittI had been thinking they two things would be separate specs and metadata API versions, but more input would be helpful16:59
dansmithmetadata changes have to be purely additive,16:59
dansmithand in the past we've only ever had one metadata version per release AFAIK16:59
*** r-daneel_ has joined #openstack-nova16:59
melwittokay, I wasn't aware of that. so it would not be allowed to change ip_address -> ip_addresses, but instead the possibility would be to add ip_addresses17:00
dansmithright17:00
*** r-daneel has quit IRC17:01
*** r-daneel_ is now known as r-daneel17:01
melwittokay. and then on the "show IP addresses even if DHCP server is present", is that type of change never allowed then? or maybe it would be because that is technically additive. that is, the behavior in the past would be "didn't show IP addresses if DHCP server" and it changes to "shows IP addresses if DHCP server"17:01
melwitt(the use case there is, there is a DHCP server present but it's not being leveraged and IPs were statically configured)17:02
melwittcurrently, the presence of the DHCP server makes the API hide the static IP addresses17:02
dansmithit's hard to say.. does cloud-init use the presence of that (or absence) to decide if it should try dhcp?17:02
dansmithany custom-rolled cloud-init-like thing could though, so..17:03
dansmithit's less additive really17:03
melwittthat, I don't know17:03
dansmithbut dan-init could have,17:04
dansmithwhich means it's probably not a great change17:04
melwittyeah. I see17:04
melwittthere is some discussion about breaking compat on the spec, so now I understand in the metadata API we can never break compat. I had been thinking it would be like microversions17:05
*** mdbooth has quit IRC17:06
melwittmgagne ^17:06
dansmithyeah, not microversions17:06
*** derekh has quit IRC17:07
mgagnemelwitt: I was under the impression that there is already a versioning system in place based on release date17:07
melwittmgagne: there is, but apparently it can only be additive and cannot break backward compat17:07
melwittI didn't know this before17:07
mgagnemelwitt: that's news to me too :O17:07
dansmiththere isn't17:07
dansmiththe date thing is just because that's how EC2 metadata is used,17:07
dansmithbut we don't really do it right17:07
dansmithso it's once per release, and additive because we don't really generate the backward-looking versions properly17:08
melwittokay. I mistook the release date version to be microversion-like17:08
*** Swami has joined #openstack-nova17:08
*** AlexeyAbashkin has quit IRC17:08
*** janki has quit IRC17:09
dansmithmelwitt: look at the comment above the version definitions17:09
melwittmgagne: so we can add 'ip_addresses' but have to also keep 'ip_address' there. and we can't change the behavior of the DHCP server + IP address show/not show17:09
dansmiththat doesn't fully explain the details I guess, but you can kinda see the "meh, this is .. meh"17:09
*** amodi has joined #openstack-nova17:10
mriedemwe've had more than one version in a release i think,17:10
*** dtantsur is now known as dtantsur|afk17:10
mriedemand the $release version alias had to point at the newer one i think17:10
mgagneNEWTON_ONE = '2016-06-30'17:10
mgagneNEWTON_TWO = '2016-10-06'17:10
mriedemright17:10
mgagnebut can't find comment about backward compatibility17:11
mriedemmgagne: probably unwritten,17:12
dansmithmriedem: that was because we had some problem.. it was an exception but I don't recall the details17:12
mriedembut b/c it doesn't have microversions, that's about the only option17:12
melwittyeah, I'm guessing cloud-init and friends don't do anything to specify a version, so if you upgrade metadata API and compat is broken, everything breaks if you haven't grabbed the latest cloud-init that can handle it17:13
*** sambetts is now known as sambetts|afk17:13
mriedemif you don't specify a version,17:13
mgagnewhat's microversion? a number you can increase to indicate a change? it's already done with date, just a different format. other than a different philosophical pov, I don't see the difference.17:13
mriedemi believe you get a versioned dict back17:14
mriedemor maybe that's just config drive17:14
mriedemhaving said all this, mikal should probably be roped in17:14
mriedemhe's an old school metadata API guy17:14
mgagneoh, I'm not familiar with metadata api at all, I only consume configdrive which does have all date/version in there17:14
melwittyeah, I was about to say, we need a mikal17:14
*** gjayavelu has quit IRC17:15
*** vivsoni_ has joined #openstack-nova17:15
*** gjayavelu has joined #openstack-nova17:16
dansmithI don't think we do17:16
dansmithI mean, we need him in the cosmic sense17:16
dansmithbut we need to be additive here17:16
mgagneok, I don't mind update spec17:17
*** stvnoyes has joined #openstack-nova17:17
mgagnebut this needs to be documented somewhere because I thought for years that you could break compat17:18
melwittagreed, we should add explanation of that under the existing comment above the version list, at least17:18
*** stvnoyes1 has quit IRC17:18
mgagneand cloud-init consumes configdrive by date: https://github.com/cloud-init/cloud-init/blob/master/cloudinit/sources/helpers/openstack.py17:19
melwittI'd appreciate a sanity check from mikal since those comments about the versioning are from him17:19
*** gjayavelu has quit IRC17:20
dansmithmgagne: it also has a latest, which we honor and use the latest field17:22
openstackgerritMerged openstack/nova stable/queens: Fix and update compute schedulers config guide  https://review.openstack.org/54887317:22
mgagnedansmith: yes and IMO, it's like using master from git, if you want stability/predictability, don't use it.17:23
*** bhujay has joined #openstack-nova17:27
*** mvk has joined #openstack-nova17:28
*** mdnadeem_ has quit IRC17:28
*** yamamoto has quit IRC17:29
*** gouthamr has joined #openstack-nova17:29
melwittlyarwood, dansmith: may I get reviews on this stable backport pls https://review.openstack.org/#/c/550498 for saving admin password to sysmeta17:30
*** moshele has joined #openstack-nova17:30
*** lpetrut has joined #openstack-nova17:30
melwitter sorry, didn't realize queens backport didn't merge yet. dansmith https://review.openstack.org/#/c/550489 instead17:31
*** suresh12 has joined #openstack-nova17:31
*** gouthamr has quit IRC17:32
lyarwoodmelwitt: np, noted in the review for now17:33
melwittlyarwood: perfect thanks17:33
*** fragatina has quit IRC17:35
*** bhujay has quit IRC17:35
*** tesseract has quit IRC17:35
*** yamahata has quit IRC17:38
*** abhishekk has quit IRC17:41
*** felipemonteiro has joined #openstack-nova17:43
*** felipemonteiro_ has joined #openstack-nova17:43
openstackgerritEric Fried proposed openstack/nova master: Use ksa adapter for cinder client  https://review.openstack.org/50834517:45
efriedmriedem: Let's see how that shakes out ^17:45
*** trozet has joined #openstack-nova17:45
*** gjayavelu has joined #openstack-nova17:45
*** yamamoto has joined #openstack-nova17:46
openstackgerritMerged openstack/nova stable/queens: libvirt: mask InjectionInfo.admin_pass  https://review.openstack.org/54828917:47
*** felipemonteiro has quit IRC17:47
*** moshele has quit IRC17:49
mriedemefried: hmm, we do need a backportable fix for bug 1752152 though17:51
openstackbug 1752152 in OpenStack Compute (nova) "Attach Volume Fails with secure call to cinder" [Undecided,In progress] https://launchpad.net/bugs/1752152 - Assigned to Eric Fried (efried)17:51
mriedemi also don't understand why our CI jobs don't fail with that bug17:51
*** r-daneel_ has joined #openstack-nova17:51
efriedmriedem: The problem with backportability is that I can't use the _SESSION if I... don't have a _SESSION.17:52
*** psachin has joined #openstack-nova17:52
*** r-daneel has quit IRC17:53
*** r-daneel_ is now known as r-daneel17:53
efriedmriedem: It's a chicken/egg: I would have to use the CinderClient to make the request, cause that guy handles https already.  But the microversion check is *before* the CinderClient is created.  Soooo....17:53
efriedmriedem: Are you sure the CIs are using https?  If it were me, I would have switched that off first thing to make things easier.17:53
mriedemi thought there was a backportable way to fix this when i was posting stuff in the bug report before, but that's exited my brain so would have to look at all of this again, but in the middle of something17:54
mriedempretty sure yes17:54
mriedemhttp://logs.openstack.org/45/508345/13/check/nova-next/aa61d86/logs/screen-c-api.txt.gz#_Mar_15_20_00_06_20139517:54
efriedmriedem: The backportable way would have been to s/https/http/ for the version discovery.17:54
efriedwhich is not a good solution.17:54
efriedmriedem: I'm not well versed on ssl etc, but isn't there a way to use https without a cert file?17:55
mriedemdon't konw17:55
dansmithefried: no17:56
mriedemanother thing i mentioned as a hack workaround for backports, is use the internal cinderclient.Client.session17:56
mriedemto get the version doc17:56
mriedemthen we replace all of that with the KSA thing in master17:56
mriedemthen it's just a session.get()17:56
*** vladikr has quit IRC17:56
*** tssurya has joined #openstack-nova17:56
efriedcinderclient.Client.session doesn't exist until we've created the client though, does it?17:57
efriedthat's the chicken/egg17:57
*** itlinux has quit IRC18:00
*** lpetrut has quit IRC18:02
efriedmriedem: (I know you're busy, but when you're available...) Any reason not to move the microversion check to after the client construction?18:03
mriedemi think that was my idea from the bug report18:03
mriedem"The alternative is on the nova side, we just construct a cinderclient  Client object and use it's internal client (session) to make a request,  or use a keystoneauth1 adapter to make the request."18:03
efriedokey, I'll see if I can work that up.18:05
*** swamireddy has joined #openstack-nova18:08
*** vladikr has joined #openstack-nova18:10
*** liverpooler has quit IRC18:11
*** yamamoto has quit IRC18:12
*** itlinux has joined #openstack-nova18:15
*** yamahata has joined #openstack-nova18:16
*** lpetrut has joined #openstack-nova18:16
*** psachin has quit IRC18:16
*** suresh12 has quit IRC18:19
*** yamamoto has joined #openstack-nova18:21
*** suresh12 has joined #openstack-nova18:23
*** yamamoto has quit IRC18:26
*** fragatina has joined #openstack-nova18:27
openstackgerritDan Smith proposed openstack/nova master: Add aggregates list to Destination object  https://review.openstack.org/54472918:29
openstackgerritDan Smith proposed openstack/nova master: Make get_allocation_candidates() honor aggregate restrictions  https://review.openstack.org/54799018:29
openstackgerritDan Smith proposed openstack/nova master: Add an index on aggregate_metadata.value  https://review.openstack.org/55585118:29
openstackgerritDan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method  https://review.openstack.org/54472818:29
openstackgerritDan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter  https://review.openstack.org/54500218:29
openstackgerritDan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement  https://review.openstack.org/54628218:29
*** vivsoni_ has quit IRC18:31
*** gjayavelu has quit IRC18:33
*** voelzmo has joined #openstack-nova18:33
*** gyankum has quit IRC18:36
*** yamamoto has joined #openstack-nova18:36
*** gyankum has joined #openstack-nova18:40
*** yamamoto has quit IRC18:41
*** corvus is now known as kermitf18:42
*** kermitf is now known as corvus18:42
openstackgerritDan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter  https://review.openstack.org/54500218:43
*** gyankum has quit IRC18:48
*** voelzmo has quit IRC18:48
*** yamamoto has joined #openstack-nova18:52
*** moshele has joined #openstack-nova18:54
*** AlexeyAbashkin has joined #openstack-nova18:54
*** lpetrut has quit IRC18:54
*** moshele has quit IRC18:56
*** yamamoto has quit IRC18:56
*** AlexeyAbashkin has quit IRC18:59
openstackgerritDan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter  https://review.openstack.org/54500219:02
*** yamahata has quit IRC19:11
*** yamahata has joined #openstack-nova19:12
openstackgerritMathieu Gagné proposed openstack/nova-specs master: Multiple Fixed-IPs support in network information  https://review.openstack.org/31262619:15
*** avolkov has quit IRC19:16
*** yamamoto has joined #openstack-nova19:17
*** yamamoto has quit IRC19:17
openstackgerritmelanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation  https://review.openstack.org/33399019:17
openstackgerritmelanie witt proposed openstack/nova master: Update layout docs for running console proxies  https://review.openstack.org/55748919:17
*** sree has joined #openstack-nova19:19
*** dikonoo has quit IRC19:19
openstackgerritmelanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation  https://review.openstack.org/33399019:20
openstackgerritmelanie witt proposed openstack/nova master: Update layout docs for running console proxies  https://review.openstack.org/55748919:20
dansmithmriedem: do you have a recent devstack running  by chance?19:21
dansmith(or anyone)19:21
mriedemnope19:21
dansmithokay I was asking you since I'm writing the docs you demand and I don't have a recent one myself19:23
*** sree has quit IRC19:23
*** esberglu has quit IRC19:25
*** esberglu has joined #openstack-nova19:26
*** yamamoto has joined #openstack-nova19:28
openstackgerritDan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement  https://review.openstack.org/54628219:30
openstackgerritDan Smith proposed openstack/nova master: WIP: Documentation for tenant isolation with placement  https://review.openstack.org/55749019:30
*** esberglu has quit IRC19:31
*** yamamoto has quit IRC19:32
openstackgerritDan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter  https://review.openstack.org/54500219:33
openstackgerritDan Smith proposed openstack/nova master: WIP: Documentation for tenant isolation with placement  https://review.openstack.org/55749019:33
openstackgerritDan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement  https://review.openstack.org/54628219:33
*** MarkMielke has quit IRC19:37
*** esberglu has joined #openstack-nova19:38
efriedmriedem, jgriffith: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3964  Is this here to avoid a DB lookup?19:39
*** felipemonteiro_ has quit IRC19:40
*** felipemonteiro_ has joined #openstack-nova19:40
efriedIt looks to me like the guts of _check_volume_already_attached_to_instance don't actually depend on cinder microversion 3.44 -- and we're just doing this because, if 3.44 isn't supported, we couldn't possibly have >1 volume attached, so there's no need to do _check_volume_already_attached_to_instance.19:40
jgriffithefried: well, no.. not really; the cinder mv can be dynamic19:40
jgriffithefried: yeah, once that attachment is made we use the bdm entry for determining which flow is in use19:41
jgriffithefried: sorry, I might not understand completely what you're looking for19:42
mriedemefried: the point is the comment in the else block below it19:42
* efried reads again...19:42
jgriffithOh, specifically that call right there :)19:43
*** yamamoto has joined #openstack-nova19:43
mriedemi'm having a hard time remembering too19:44
efriedLemme make sure I have the logic right:19:44
efriedIf multiattach not supported by cinder, proceed.19:44
efriedOtherwise, fail if the volume is attached.19:44
mriedem3.44 isn't about multiattach19:44
mriedemit starts with https://review.openstack.org/#/c/525622/19:44
mriedemwith the new attachments api stuff, cinder will let us create multiple attachments between the same volume and instance19:44
mriedemto enable things like live migration where the instance is attached to the volume on different hosts19:45
mriedembut because of that, we found we had a bug where you could attach the same volume to the instance via the api multiple times19:45
mriedemso we had to add a specific check for that19:45
jgriffithmriedem: yeah, the comment actually is pretty good :)19:46
mriedembefore using new style attachments, cinder would not allow this19:46
mriedemthat's why in https://review.openstack.org/#/c/525622/ we have to rely on the bdm table19:46
*** awaugama has quit IRC19:46
*** yamamoto has quit IRC19:47
efriedUltimately I was trying to figure out if I could get rid of that microversion check :)  I think I now understand why I can't.19:47
mriedemso going back to https://github.com/openstack/nova/blob/master/nova/compute/api.py#L396419:47
efriedWhich kinda sucks, because it means I'm gonna have to build up a whole cinder client just to do that microversion check.19:48
mriedemif 3.44 is supported, we know we're doing the new style attachment_create, and we have to make sure the instance isn't already attached to that volume, so we call _check_volume_already_attached_to_instance19:48
mriedemif 3.44 isn't available, we'll do the old style reserve flow19:48
mriedemwhich cinder enforces you can only have the instance attached to the volume once19:48
*** yamahata has quit IRC19:48
mriedemefried: yeah but that is only temporary for the backport,19:49
mriedemand we can replace that stuff with ksa in master right?19:49
efriedmriedem: Except I still haven't figured out how to get ksa stuff working for cinder, period.19:49
mriedemheh19:49
mriedemwell,19:49
mriedemit's just code right?!19:49
efriedSigh.  Right.19:49
mriedemsylvain's daughter will have it done by tomorrow19:50
efriedI know, I can't let her show me up like that.  Not again.19:50
*** felipemonteiro__ has joined #openstack-nova19:53
dansmithcripes19:54
openstackgerritDan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter  https://review.openstack.org/54500219:56
*** yamamoto has joined #openstack-nova19:57
*** yamamoto has quit IRC19:57
*** felipemonteiro_ has quit IRC19:58
*** moshele has joined #openstack-nova20:11
mriedemdansmith: not sure if you care about any of the comments in https://review.openstack.org/#/c/544730/1520:12
*** eharney has quit IRC20:13
dansmithmriedem: sorry hadn't seen those20:14
dansmithreplied20:14
mriedemi've got this nova-status check ready to go basically for the cells api service version check thing, i think i'll just munge the api log warning into the same patch20:18
dansmithseems reasonable20:20
*** awaugama has joined #openstack-nova20:23
*** tssurya has quit IRC20:26
*** sapd__ has quit IRC20:30
*** sapd__ has joined #openstack-nova20:31
*** r-daneel_ has joined #openstack-nova20:32
*** r-daneel has quit IRC20:33
*** r-daneel_ is now known as r-daneel20:33
openstackgerritDan Smith proposed openstack/nova master: Add request filter functionality to scheduler  https://review.openstack.org/54473020:38
openstackgerritDan Smith proposed openstack/nova master: Add aggregates list to Destination object  https://review.openstack.org/54472920:38
openstackgerritDan Smith proposed openstack/nova master: Make get_allocation_candidates() honor aggregate restrictions  https://review.openstack.org/54799020:38
openstackgerritDan Smith proposed openstack/nova master: Add an index on aggregate_metadata.value  https://review.openstack.org/55585120:38
openstackgerritDan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method  https://review.openstack.org/54472820:38
openstackgerritDan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter  https://review.openstack.org/54500220:38
openstackgerritDan Smith proposed openstack/nova master: WIP: Documentation for tenant isolation with placement  https://review.openstack.org/55749020:38
openstackgerritDan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement  https://review.openstack.org/54628220:38
*** nicolasbock has joined #openstack-nova20:39
mikalmriedem: yeah, I can be around to interate on privsep for the next couple of weeks. Noting that both of the next two weeks are short because of easter.20:40
openstackgerritMerged openstack/nova stable/queens: Avoid exploding if guest refuses to detach a volume  https://review.openstack.org/55194820:41
mikalmriedem: what's blocking removing nova-net? The last couple of privsep patches aren't mergable until nova-net is gone, but I can WIP those or something. It would be nice to get them landed this cycle though.20:41
*** pchavva has quit IRC20:41
mriedemmikal: nothing is blocking it20:43
mriedemmikal: but,20:43
mriedemi imagine it's not trivial since a ton of the test code in-tree assumes nova-net20:43
mriedemand that's including non-nova-net things20:44
mikalIs anyone working on it?20:44
mriedemso all of that has to be unwound20:44
mriedemmikal: not that i know of,20:44
mriedemi got the cells v1 job running with neutron and that was step 120:44
*** moshele has quit IRC20:44
*** andreas_s has joined #openstack-nova20:45
mriedemwhich reminds me,20:46
mriedemmelwitt: dansmith: efried: i'm out on monday and tuesday20:47
dansmithorly20:47
melwittk, thanks for the heads up20:47
dansmithI'm out friday for "GENERIC SPRING HOLIDAY"20:47
melwittme too20:47
efriedroger that, mriedem.  Means you have to review this bug fix tonight/tomorrow I guess.20:47
openstackgerritMatt Riedemann proposed openstack/nova master: Log a warning and add nova-status check for old API service versions  https://review.openstack.org/55750620:49
mriedemSamYaple: ^ for your bug from yesterday, i hope i get a bag of jelly beans for this20:49
*** andreas_s has quit IRC20:49
SamYapleoh snap!20:50
SamYaplethat was quick. i promise you regular flavored jelly beans20:50
mriedemis there such a thing as unflavored jelly beans?20:52
SamYaplei said "regular". as opposed to.... other flavors20:52
mriedemoh right20:53
mriedemyeah brachs20:53
mriedemnot that new fangled starburts stuff20:53
mriedem*starbursts20:53
SamYaplehaha20:53
dansmithstarburts?20:53
openstackgerritDan Smith proposed openstack/nova master: Make get_allocation_candidates() honor aggregate restrictions  https://review.openstack.org/54799020:53
openstackgerritDan Smith proposed openstack/nova master: Add an index on aggregate_metadata.value  https://review.openstack.org/55585120:53
openstackgerritDan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method  https://review.openstack.org/54472820:53
openstackgerritDan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter  https://review.openstack.org/54500220:54
openstackgerritDan Smith proposed openstack/nova master: WIP: Documentation for tenant isolation with placement  https://review.openstack.org/55749020:54
openstackgerritDan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement  https://review.openstack.org/54628220:54
openstackgerritEric Fried proposed openstack/nova master: Use ksa session for cinder microversion check  https://review.openstack.org/55750820:54
dansmith(man I suck)20:54
efriedmriedem: ^20:54
efriedHahaha20:54
mriedem?20:54
mriedemstarburts are burt reynolds flavored candies20:54
mriedemmostly taste like oil and stache20:54
mikalDoes anyone else see pep8 failures with master by the way?20:55
efriedmriedem: I was pointing out the bug fix patch I just posted.  But crossed streams with dansmith, so it looked like I was bringing your attention to the fact that dansmith, by his own admission, sucks.20:55
mikalRunning flake8 on all files20:55
mikal./nova/tests/unit/virt/libvirt/volume/test_quobyte.py:230:18: E211 whitespace before '('20:55
mikal./nova/virt/libvirt/guest.py:664:68: F821 undefined name 'unicode'20:55
mriedemmikal: nope20:55
mikalHerm, how odd.20:55
dansmithefried: I ain't swordfightin' with you dude.. ever.20:55
openstackgerritMerged openstack/nova stable/pike: Avoid exploding if guest refuses to detach a volume  https://review.openstack.org/55195020:55
efriedPromises promises.20:55
openstackgerritMerged openstack/nova stable/queens: Add functional regression test for bug 1746509  https://review.openstack.org/55591420:56
openstackbug 1746509 in OpenStack Compute (nova) pike "TypeError: Can't upgrade a READER transaction to a WRITER mid-transaction" [High,In progress] https://launchpad.net/bugs/1746509 - Assigned to melanie witt (melwitt)20:56
openstackgerritMerged openstack/nova stable/queens: Move _make_instance_list call outside of DB transaction context  https://review.openstack.org/55591520:56
openstackgerritMerged openstack/nova master: tox: Make everything work with Python 3  https://review.openstack.org/55689420:56
openstackgerritMerged openstack/nova master: tests: fixes mock autospec usage  https://review.openstack.org/44750520:56
*** gjayavelu has joined #openstack-nova20:57
openstackgerritMerged openstack/nova stable/queens: Save admin password to sysmeta in libvirt driver  https://review.openstack.org/55048920:57
*** yamamoto has joined #openstack-nova20:57
mriedemmordred must have just flushed the zuul toilet20:57
*** yamahata has joined #openstack-nova20:58
* mordred passes the communal roll of toilet paper to mriedem20:58
melwittmriedem, dansmith: pike backports ready2rock https://review.openstack.org/#/c/55505820:59
efrieddansmith: Did you mean to do this or not? https://review.openstack.org/#/c/544730/15..16/nova/scheduler/manager.py21:00
efriedAm I just failing to detect sarcasm via gerrit?21:00
dansmithefried: no, I meant I meant to do what mriedem was suggesting21:00
efriedight21:00
efriedcause he seems to have taken you at face value also.21:00
*** r-daneel_ has joined #openstack-nova21:01
dansmithmelwitt: why is that patch strikeouted21:02
dansmith?21:02
melwittI dunno. usually that means it merged but it didn't merge21:03
*** r-daneel has quit IRC21:03
*** r-daneel_ is now known as r-daneel21:03
*** yamahata has quit IRC21:03
*** yamamoto has quit IRC21:03
melwittor no, that's the dot that means it merged.21:03
melwittit's not strikeouted anymore now. not sure what that was21:04
efriedWere you looking at the cherry-picks tabbydoo?21:04
melwittyes21:04
melwittRelated Changes21:04
melwittso no, but similar21:05
efriedThe Cherry Picks one (rightly) shows black-dotted patches from the other branches.  I don't see black dots under Related Changes.21:05
mriedemdansmith: one more time through the ringer https://review.openstack.org/#/c/547990/21:05
efriedYou say temporary glitch.  I say it never happened.  Need new glasses.21:06
melwittearlier before mriedem +2ed it, it was strikeouted in the Related Changes tabbydoo21:06
mriedemi saw it21:06
*** moshele has joined #openstack-nova21:08
mriedemefried: since we don't have that https failure in devstack, we'll likely need divya to assert it fixes the bug21:09
mriedemi don't have the setup for it21:09
efriedmriedem: Roger that.  If it looks okay to you at a glance, I'll send it that way.21:09
mikalmriedem: its not just unit tests, look at nova.virt.xenapi.firewall for example.21:10
mriedemmikal: yeah linux_net is going to be mingled into everything21:11
mriedemso i'm not really sure what the best way is to unwind the nova-net stuff since it's mixed into everything21:11
mikalOrbital nukes?21:12
mikalFor a start, do we even know if xen people still use the dom0 firewalling stuff? Its copyright 8 years ago now.21:12
mriedemwell, what i know i don't want to see is a single giant patch that just deletes everything21:12
mriedemmikal: would have to ask BobBall or jianghuaw_21:12
mikalI think you just did?21:12
cdentdansmith or mriedem : were either of you aware of jaypipes-away asking about some tweaks to oslo config to know if an option's value was coming from a default or elsewhere (even if the value was the same)? dhellman implemented a feature to support that in oslo_config but it seems to have bad mojo and maybe it can die: https://bugs.launchpad.net/oslo.config/+bug/175968921:13
openstackLaunchpad bug 1759689 in oslo.config "In 1.6.0 startup can be extremely slow when checking many config items" [Undecided,New]21:13
*** itlinux has quit IRC21:14
mikalThis nova.virt.firewall thing is news to me and is going to be an issue I think21:14
mikalIts used quite widely.21:14
mriedemcdent: nope21:14
cdent(sorry that's 6.0.0 above, not 1.6.0)21:14
mriedemi saw the ML thread21:14
mikalOh, its security groups21:15
mikalThat makes sense. Why not just call it that then?21:15
mriedemi will be amused when i found out that you wrote most of this mikal21:15
mikalI did not21:15
mikalI am innocent. My tech debt is elsewhere.21:16
mriedemefried: i think https://review.openstack.org/#/c/557508/ looks ok for the most part21:22
efriedmriedem: Thanks.21:22
mriedemi think the diff could be smaller,21:22
mriedembut it's ready for divya to test21:22
*** yamahata has joined #openstack-nova21:24
efriedmriedem: It's really just gerrit being silly.  I didn't move the method - just put the new stuff in front of it (because it makes more sense ordered that way).21:24
mriedemok21:25
mriedemor,21:25
mikalmriedem: looking at this, I think the first step is like privsep. Remove nova-net support from just one driver (presumably libvirt). Learn what it looks like by doing that, and then repeat for other drivers.21:25
mriedemyou're anal about functions being defined before they are used, like in21:25
openstackgerritEd Leafe proposed openstack/nova master: Address issues raised in adding member_of to GET /a-c  https://review.openstack.org/55435721:25
mriedemc21:25
mriedemmikal: yeah you're probably right21:25
mriedemalso,21:25
mriedemthe apis that are solely nova-net only will need to be cleansed to just fast-fail at any microversion21:26
mriedemcan't remember if we 404 or 405 for those today after the deprecation versions21:26
*** moshele has quit IRC21:26
mikalIt looks to me like linux_net and nova-net are also not synonyms like I thought they were. nova.virt.libvirt.vif uses linux-net to plug devices for example.21:27
mriedemyes, dansmith loves that21:27
mriedemi think for the deprecated apis, you get a 404 https://github.com/openstack/nova/blob/master/nova/api/openstack/wsgi.py#L73921:28
mriedemso one thing one could start with, is neutering all of those APIs21:28
mikalI had assumed for privsep I could ignore nova-net, but I don't think that's true now that I learn that vif plugging calls into it.21:29
mikalThis is a tangled mess.21:29
mikali.e. I might be forced to privsep a bunch of "nova-net" in order to land the final couple of privsep patches.21:30
mriedemmikal: or just help with the nova-net removal21:31
mikalPerhaps, but I'm a hobbyist. Any critical part of nova's roadmap depending on me is going to be a problem.21:32
*** cdent has quit IRC21:37
mriedemok, let's drop privsep from runways then :)21:39
mriedemor, be OK with saying privsep won't be done by the end of your runway21:39
mikalmriedem: sure, if you want. You've been saying its a low priority the whole time though. You can't have it both ways.21:39
mriedemb/c of the nova-net stuff21:39
*** sticker has joined #openstack-nova21:40
mriedemwhat do i want both ways?21:40
mriedemmy point is,21:40
mriedemi don't think you should do more privsep stuff for nova-net specific things when we're going to drop nova-net,21:40
mikalEither you want privsep or you don't. I don't really care either way any more.21:40
mriedemand if that means the privsep conversion isn't done at the end of your current runway, i think that's ok21:40
mriedemalso, i'm not the only person here21:41
mikalI've said all along that privsep wouldn't be done at the end of the runway. The last couple of patches which need nova-net to go can just sit around until someone removes nova-net.21:41
*** edmondsw has quit IRC21:43
*** sree has joined #openstack-nova21:45
efriedThis seems simple to me.  The scope of the runway is the privsep series up to but not including the patches that require nova-net removal.  Runways don't have to encompass an entire blueprint.  That was something we talked about early on, but later relaxed our stance on.21:46
*** sree has quit IRC21:51
-openstackstatus- NOTICE: the zuul web dashboard will experience a short downtime as we roll out some changes - no job execution should be affected21:52
*** harlowja has joined #openstack-nova21:53
melwittagreed, privsep up until the nova-net requiring ones can be done as part of the runway and that's it21:59
*** yamamoto has joined #openstack-nova21:59
*** yamamoto has quit IRC22:04
*** yamahata has quit IRC22:04
openstackgerritMatt Riedemann proposed openstack/nova master: Add nova-status check for ironic flavor migration  https://review.openstack.org/52754122:07
openstackgerritEric Fried proposed openstack/nova master: Slugification utilities for placement names  https://review.openstack.org/55662822:10
mriedemefried: maybe you'd like to rev https://review.openstack.org/#/c/546813/ ?22:14
mriedemi'm itching to +2 that22:14
efriedmriedem: sec...22:15
melwittmikal: earlier today we were talking about metadata API versioning because of a spec review where the proposal wants to change the network_data.json format in a new version. dansmith said new versions can be only additive and that was news to me and mgagne. is that also your understanding? we see this code comment by you above the version list https://github.com/openstack/nova/blob/master/nova/api/metadata/base.py#L6022:16
melwittand I'm not aware of any other documentation about the versioning22:17
esberglumriedem: efried: Sorry I've been caught up in some other stuff. Was planning on hitting that either tonight or 1st thing in the am22:17
efriedesberglu: I can punch it rn if you like.22:17
mikalmelwitt: I don't think we've ever done a non-additive change, but I'd have to check. The scheme is inherited from ec2, so I guess what they've done might also matter. Mostly this comes down to looking at the cloud-init implementation and seeing how it would handle the data changing.22:19
*** mlavalle has quit IRC22:19
esbergluefried: If you want to go for it. I'm trying to finish out a bunch system upgrades today22:20
mriedemKevin_Zheng: just a small change to add to https://review.openstack.org/#/c/536722/ about older computes22:21
mriedemthen i'll be +2 again22:21
melwittmikal: yeah, I think you're right that we haven't done a non-additive change. ack on having to look at cloud-init. although there might be other things consuming the API that might not handle a compat change even if cloud-init does22:21
mikalmelwitt: very true. You can totally write a shell script to parse metadata, that's the whole idea.22:22
mikalmelwitt: the original cloud-init was in fact a shell script.22:22
mgagnemelwitt, mikal: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-metadata.html22:25
mgagne"The earlier versions are available to you in case you have scripts that rely on the structure and information present in a previous version."22:26
*** Guest33320 has quit IRC22:26
mgagnemy understanding of this statement is that newer versions can remove information or change structure in non-backward compatible ways22:26
*** rcernin has joined #openstack-nova22:28
efriedmriedem: Does that reno need to say anything beyond "The PowerVM driver now supports hot plugging/unplugging of network interfaces." ?22:29
mriedemefried: nope22:29
openstackgerritEric Fried proposed openstack/nova master: PowerVM Driver: Network interface attach/detach  https://review.openstack.org/54681322:29
efriedmriedem: ight.  ^22:29
mriedemthanks22:29
efriedMy daughter cooked me a steak.  I'm out.22:29
* efried waves22:30
esbergluefried: tx22:30
melwittmgagne: I interpret it the same way. so, the source material for this API was intended to be able to change things between versions and break compat. it will be interesting to see how cloud-init is written and whether it would be insulated to such an API change. (and that's aside from all of the other things people may have written to consume the metadata API)22:30
mikalcloud-init has heavy contributions from amazon, so we're probably ok then22:30
mikalAlthough the openstack implementation in cloud-init probably doesn't get much love from amazon22:31
melwittyeah, that's my concern22:31
mikalI do think asking someone to check cloud-init as part of the spec review is reasonable22:31
mgagnemelwitt: supported versions are hardcoded: https://git.launchpad.net/cloud-init/tree/cloudinit/sources/helpers/openstack.py?h=ubuntu/xenial#n4422:31
mikalLOL, they're quite far behind.22:32
*** jaypipes-away is now known as jaypipes22:32
mikalUnless xenial is shipping an old version?22:32
mgagnethat's for xenial, should check for latest22:32
*** esberglu has quit IRC22:32
mgagnebut it supports network_data.json so I'm happy =)22:32
*** awaugama has quit IRC22:32
*** priteau has quit IRC22:33
mgagnesame for latest version it seems: https://git.launchpad.net/cloud-init/tree/cloudinit/sources/helpers/openstack.py?h=ubuntu/devel#n4422:33
mikalhttps://github.com/cloud-init/cloud-init/blob/master/cloudinit/sources/helpers/openstack.py22:33
mikalTrunk is just as far behind22:33
mikalI guess maybe they expect us to be keeping that stuff up to date22:34
mikalThat means no vendordata v2 for anyone in cloud-init land for example22:34
mgagneup to date => support older versions ?22:34
*** mriedem has quit IRC22:34
mgagneif nobody asks ¯\_(ツ)_/¯22:34
mgagnehad to ask for network_data.json and contribute, wasn't easy22:34
*** priteau has joined #openstack-nova22:35
*** mriedem has joined #openstack-nova22:36
dansmithmikal: melwitt mgagne: we've not done non-additive changes in the past, and I don't really see any reason to make that change here.. we can totally do it additive-ly22:37
dansmithwe could re-audit all that stuff and make those checks more explicit about version spans (i.e start doing a thing in X, stop doing it in Y) but I don't see the point22:38
dansmithyes, anything consuming latest is playing with fire, but.. shell scripts22:38
mgagnedansmith: sure, just want to make sure we don't force ourselves to abide ourselves to some non-written rules which happens to have no reasons to exist22:39
mgagneI updated spec to keep backward compat22:39
*** priteau has quit IRC22:40
*** felipemonteiro__ has quit IRC22:43
melwittyeah, ip_address and ip_addresses would be redundant but maybe that's not that big of a deal22:43
melwittor, ip_address would be redundant22:43
*** mriedem has quit IRC22:47
*** ansiwen[q] has joined #openstack-nova22:47
openstackgerritMichael Still proposed openstack/nova master: Start untangling network utilities.  https://review.openstack.org/55754222:52
openstackgerritMichael Still proposed openstack/nova master: Move two more generic network utilities to a move obvious place.  https://review.openstack.org/55754322:52
mikalmelwitt: ^--- that's the sort of untangling I was talking about22:52
melwittah, okay. thanks for getting that started22:53
mikalmelwitt: some of that makes it more apparently that there is some privsep to do in nova.network, event if nova-net is nuked from orbit22:54
*** hongbin has quit IRC22:54
mikalmelwitt: which wasn't as obvious before22:54
melwittmikal: so that means, some privsep work is needed to support the utils that are not really part of nova-net?22:55
mikalmelwitt: yes, as we split out the bits of nova-net that we need post nova-net, we will find things that need to be privsep'ed22:55
mikalmelwitt: none of them look hard to do, but the previous assumption was that all of nova-net was just getting deleted22:56
mikalmelwitt: which is not true22:56
melwittmikal: understood22:56
mikalmelwitt: so, these ones got the remove-nova-network bp tag, but could have had the privsep one if we'd wanted to, they're all tangled up together22:56
mikalI don't think you can tag two blueprints. Maybe you can?22:57
melwittI think you can, but from what I can tell, they make more sense under nova-net removal being that they're decoupling things that need to remain after removing nova-net22:57
mikalYeah22:57
mikalI also don't care how they're tagged as long as they get reviewed one day22:58
melwittthat work would have to be done anyway to remove nova-net, even without privsep22:58
mikalI'mma just going to keep rebasing them and smashing the gate until someone gives in and reviews them22:58
melwittyeah, same22:58
mikalGiven we're up to 13 interrelated patches so far, and that list will grow22:58
openstackgerritDan Smith proposed openstack/nova master: Make get_allocation_candidates() honor aggregate restrictions  https://review.openstack.org/54799022:58
openstackgerritDan Smith proposed openstack/nova master: Add an index on aggregate_metadata.value  https://review.openstack.org/55585122:58
openstackgerritDan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method  https://review.openstack.org/54472822:58
openstackgerritDan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter  https://review.openstack.org/54500222:58
openstackgerritDan Smith proposed openstack/nova master: WIP: Documentation for tenant isolation with placement  https://review.openstack.org/55749022:58
openstackgerritDan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement  https://review.openstack.org/54628222:58
*** yamamoto has joined #openstack-nova23:00
*** cfriesen has quit IRC23:03
*** yamamoto has quit IRC23:06
*** salv-orlando has quit IRC23:21
*** salv-orlando has joined #openstack-nova23:22
*** salv-orlando has quit IRC23:27
*** chyka has quit IRC23:32
*** gyee has quit IRC23:32
*** chyka has joined #openstack-nova23:33
*** chyka has quit IRC23:37
*** Zames has joined #openstack-nova23:45
*** Zames has quit IRC23:48
*** tbachman has quit IRC23:52
*** claudiub has quit IRC23:52
-openstackstatus- NOTICE: Zuul has been restarted to update to the latest code; existing changes have been re-enqueued, you may need to recheck changes uploaded in the past 10 minutes23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!