| *** tetsuro has joined #openstack-nova | 00:00 | |
| *** takashin has joined #openstack-nova | 00:00 | |
| tetsuro | good morning! | 00:01 |
|---|---|---|
| *** abalutoiu_ has joined #openstack-nova | 00:02 | |
| *** germs has joined #openstack-nova | 00:05 | |
| *** germs has quit IRC | 00:05 | |
| *** germs has joined #openstack-nova | 00:05 | |
| *** abalutoiu__ has quit IRC | 00:05 | |
| *** ssurana has joined #openstack-nova | 00:07 | |
| *** odyssey4me has quit IRC | 00:08 | |
| *** odyssey4me has joined #openstack-nova | 00:08 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Replace GB with GiB https://review.openstack.org/558364 | 00:09 |
| *** germs has quit IRC | 00:10 | |
| *** jaypipes has quit IRC | 00:10 | |
| *** esberglu has quit IRC | 00:15 | |
| *** esberglu has joined #openstack-nova | 00:16 | |
| *** esberglu has quit IRC | 00:20 | |
| *** yamamoto has joined #openstack-nova | 00:28 | |
| *** voelzmo has quit IRC | 00:32 | |
| *** jackie-truong has joined #openstack-nova | 00:33 | |
| *** lbragstad has quit IRC | 00:33 | |
| *** yamamoto has quit IRC | 00:34 | |
| *** liuzz has quit IRC | 00:40 | |
| *** hoangcx has joined #openstack-nova | 00:51 | |
| *** itlinux has quit IRC | 00:51 | |
| *** hongbin has joined #openstack-nova | 00:57 | |
| *** AlexeyAbashkin has joined #openstack-nova | 00:58 | |
| *** voelzmo has joined #openstack-nova | 00:59 | |
| *** gjayavelu has quit IRC | 00:59 | |
| *** AlexeyAbashkin has quit IRC | 01:03 | |
| *** amodi has quit IRC | 01:05 | |
| *** jichen has joined #openstack-nova | 01:06 | |
| *** armaan has quit IRC | 01:09 | |
| *** gyan__ has joined #openstack-nova | 01:13 | |
| *** zhaochao has joined #openstack-nova | 01:13 | |
| *** fragatina has quit IRC | 01:16 | |
| openstackgerrit | Merged openstack/nova master: [placement] Add test for provider summaries https://review.openstack.org/558044 | 01:18 |
| openstackgerrit | Merged openstack/nova master: Unit test framework: common FakeResponse https://review.openstack.org/556551 | 01:18 |
| *** harlowja has quit IRC | 01:19 | |
| openstackgerrit | Merged openstack/nova master: [placement] Add to contributor docs about handler testing https://review.openstack.org/557355 | 01:19 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Noauth should also use request_id from compute_req_id.py https://review.openstack.org/555266 | 01:21 |
| *** takashin has quit IRC | 01:22 | |
| *** yamamoto has joined #openstack-nova | 01:30 | |
| *** tiendc has joined #openstack-nova | 01:32 | |
| *** voelzmo has quit IRC | 01:33 | |
| *** armaan has joined #openstack-nova | 01:35 | |
| *** yamamoto has quit IRC | 01:35 | |
| *** vladikr has quit IRC | 01:36 | |
| *** vladikr has joined #openstack-nova | 01:36 | |
| *** nicolasbock has quit IRC | 01:36 | |
| *** yangyapeng has joined #openstack-nova | 01:48 | |
| *** yangyape_ has joined #openstack-nova | 01:50 | |
| *** yangyapeng has quit IRC | 01:50 | |
| *** phuongnh has joined #openstack-nova | 01:52 | |
| *** naichuans has joined #openstack-nova | 01:52 | |
| *** jogo has quit IRC | 01:58 | |
| *** voelzmo has joined #openstack-nova | 02:00 | |
| *** takashin has joined #openstack-nova | 02:01 | |
| *** germs has joined #openstack-nova | 02:06 | |
| *** germs has quit IRC | 02:06 | |
| *** germs has joined #openstack-nova | 02:06 | |
| *** germs has quit IRC | 02:11 | |
| *** moshele has joined #openstack-nova | 02:12 | |
| *** Tom-Tom has joined #openstack-nova | 02:14 | |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240 | 02:19 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340 | 02:19 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344 | 02:19 |
| *** lbragstad has joined #openstack-nova | 02:20 | |
| *** sdague has quit IRC | 02:22 | |
| *** hongbin has quit IRC | 02:22 | |
| *** ssurana has quit IRC | 02:22 | |
| *** dave-mccowan has joined #openstack-nova | 02:24 | |
| *** annp has quit IRC | 02:24 | |
| *** hoangcx has quit IRC | 02:24 | |
| *** ircuser-1 has joined #openstack-nova | 02:24 | |
| *** annp has joined #openstack-nova | 02:25 | |
| *** hoangcx has joined #openstack-nova | 02:25 | |
| *** zhurong has joined #openstack-nova | 02:29 | |
| *** yamamoto has joined #openstack-nova | 02:32 | |
| *** jogo has joined #openstack-nova | 02:33 | |
| *** voelzmo has quit IRC | 02:34 | |
| *** yamamoto has quit IRC | 02:37 | |
| *** moshele has quit IRC | 02:39 | |
| *** armaan has quit IRC | 02:43 | |
| *** armaan has joined #openstack-nova | 02:43 | |
| *** psachin has joined #openstack-nova | 02:44 | |
| *** threestrands has quit IRC | 02:47 | |
| *** threestrands has joined #openstack-nova | 02:47 | |
| *** threestrands has quit IRC | 02:47 | |
| *** threestrands has joined #openstack-nova | 02:47 | |
| *** threestrands has quit IRC | 02:48 | |
| *** threestrands has joined #openstack-nova | 02:49 | |
| *** threestrands has quit IRC | 02:49 | |
| *** threestrands has joined #openstack-nova | 02:49 | |
| *** yangyape_ has quit IRC | 02:50 | |
| *** yangyapeng has joined #openstack-nova | 02:50 | |
| *** yangyapeng has quit IRC | 02:55 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/osc-placement master: Should we remove 'provider' in resource provider allocation https://review.openstack.org/558682 | 02:58 |
| *** voelzmo has joined #openstack-nova | 02:58 | |
| *** hemna_ has quit IRC | 02:59 | |
| *** dave-mccowan has quit IRC | 03:01 | |
| *** yangyapeng has joined #openstack-nova | 03:19 | |
| openstackgerrit | Jay Pipes proposed openstack/nova-specs master: Handle nested providers for allocation candidates https://review.openstack.org/556873 | 03:19 |
| *** Yikun has quit IRC | 03:19 | |
| *** yikun_jiang has joined #openstack-nova | 03:19 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Replace mox stubs with stub_out https://review.openstack.org/558685 | 03:21 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Replace mox stubs with stub_out in test_extended_volumes.py https://review.openstack.org/558685 | 03:22 |
| *** yangyapeng has quit IRC | 03:24 | |
| *** lbragstad has quit IRC | 03:25 | |
| openstackgerrit | Jay Pipes proposed openstack/nova-specs master: mirror nova host aggregates to placement API https://review.openstack.org/545057 | 03:25 |
| *** voelzmo has quit IRC | 03:32 | |
| *** yamamoto has joined #openstack-nova | 03:33 | |
| *** yangyapeng has joined #openstack-nova | 03:35 | |
| *** yamamoto has quit IRC | 03:38 | |
| *** yangyapeng has quit IRC | 03:40 | |
| *** liverpooler has quit IRC | 03:42 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 03:44 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 03:44 |
| *** fragatina has joined #openstack-nova | 03:48 | |
| *** fragatina has quit IRC | 03:48 | |
| *** fragatina has joined #openstack-nova | 03:49 | |
| *** lpetrut has joined #openstack-nova | 03:49 | |
| *** fragatina has quit IRC | 03:50 | |
| *** fragatina has joined #openstack-nova | 03:50 | |
| *** Sukhdev has joined #openstack-nova | 03:51 | |
| *** takashin has quit IRC | 03:54 | |
| *** Tom-Tom has quit IRC | 03:54 | |
| *** hongbin has joined #openstack-nova | 03:56 | |
| *** Sukhdev has quit IRC | 03:56 | |
| openstackgerrit | Merged openstack/nova master: api-ref: add a note about volume-backed rescue not being supported https://review.openstack.org/556996 | 03:57 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 03:57 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 03:57 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240 | 03:57 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340 | 03:57 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344 | 03:57 |
| *** yangyapeng has joined #openstack-nova | 04:01 | |
| *** voelzmo has joined #openstack-nova | 04:02 | |
| openstackgerrit | Merged openstack/nova master: ironic: Get correct inventory for deployed node https://review.openstack.org/553367 | 04:04 |
| *** hongbin has quit IRC | 04:05 | |
| *** yangyapeng has quit IRC | 04:06 | |
| *** udesale has joined #openstack-nova | 04:07 | |
| *** takashin has joined #openstack-nova | 04:08 | |
| *** moshele has joined #openstack-nova | 04:12 | |
| *** voelzmo has quit IRC | 04:12 | |
| *** moshele has quit IRC | 04:14 | |
| *** sridharg has joined #openstack-nova | 04:24 | |
| *** lpetrut has quit IRC | 04:24 | |
| *** pcaruana has joined #openstack-nova | 04:27 | |
| *** pcaruana has quit IRC | 04:30 | |
| *** abhishekk has joined #openstack-nova | 04:30 | |
| *** yangyapeng has joined #openstack-nova | 04:30 | |
| *** jackie-truong has quit IRC | 04:33 | |
| *** yamamoto has joined #openstack-nova | 04:35 | |
| *** vladikr has quit IRC | 04:37 | |
| *** threestrands has quit IRC | 04:38 | |
| *** links has joined #openstack-nova | 04:39 | |
| *** links has quit IRC | 04:40 | |
| *** yamamoto has quit IRC | 04:40 | |
| *** lpetrut has joined #openstack-nova | 04:40 | |
| *** Eran_Kuris has joined #openstack-nova | 04:42 | |
| *** tonyb has quit IRC | 04:45 | |
| *** links has joined #openstack-nova | 04:46 | |
| *** yamamoto has joined #openstack-nova | 04:51 | |
| *** zhurong has quit IRC | 04:55 | |
| *** lpetrut has quit IRC | 05:00 | |
| *** ratailor has joined #openstack-nova | 05:07 | |
| *** ratailor_ has joined #openstack-nova | 05:10 | |
| *** Tom-Tom has joined #openstack-nova | 05:12 | |
| *** ratailor has quit IRC | 05:12 | |
| *** moshele has joined #openstack-nova | 05:16 | |
| *** harlowja has joined #openstack-nova | 05:16 | |
| *** yangyapeng has quit IRC | 05:18 | |
| *** harlowja has quit IRC | 05:20 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Avoid showing password in log https://review.openstack.org/558694 | 05:32 |
| *** dave-mccowan has joined #openstack-nova | 05:43 | |
| *** yangyapeng has joined #openstack-nova | 05:43 | |
| *** yangyapeng has quit IRC | 05:48 | |
| *** liuzz has joined #openstack-nova | 05:49 | |
| *** Tom-Tom has quit IRC | 05:51 | |
| *** moshele has quit IRC | 05:53 | |
| *** kholkina has joined #openstack-nova | 05:56 | |
| *** Tom-Tom has joined #openstack-nova | 06:01 | |
| *** yangyapeng has joined #openstack-nova | 06:02 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Remove a outdated warning https://review.openstack.org/557898 | 06:03 |
| *** belmoreira has joined #openstack-nova | 06:03 | |
| *** janki has joined #openstack-nova | 06:06 | |
| *** gmann_ is now known as gmann | 06:06 | |
| *** gjayavelu has joined #openstack-nova | 06:06 | |
| *** Tom-Tom has quit IRC | 06:06 | |
| *** yangyapeng has quit IRC | 06:07 | |
| *** dave-mccowan has quit IRC | 06:09 | |
| *** sar has joined #openstack-nova | 06:12 | |
| *** licanwei has joined #openstack-nova | 06:16 | |
| *** sree_ has joined #openstack-nova | 06:16 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (1) https://review.openstack.org/558704 | 06:16 |
| *** sree_ is now known as Guest90995 | 06:16 | |
| *** yangyapeng has joined #openstack-nova | 06:23 | |
| *** jaosorior has quit IRC | 06:25 | |
| *** sahid has joined #openstack-nova | 06:26 | |
| *** yangyapeng has quit IRC | 06:28 | |
| *** voelzmo has joined #openstack-nova | 06:31 | |
| *** rubasov has quit IRC | 06:31 | |
| *** voelzmo has quit IRC | 06:35 | |
| *** lajoskatona has joined #openstack-nova | 06:36 | |
| *** alexchadin has joined #openstack-nova | 06:37 | |
| *** rubasov has joined #openstack-nova | 06:42 | |
| openstackgerrit | sahid proposed openstack/nova-specs master: update: isolate guests emulthreads on CONF.cpu_shared_set https://review.openstack.org/511188 | 06:49 |
| openstackgerrit | Merged openstack/nova master: PowerVM Driver: Network interface attach/detach https://review.openstack.org/546813 | 06:49 |
| openstackgerrit | sahid proposed openstack/nova-specs master: update: isolate guests emulthreads on CONF.cpu_shared_set https://review.openstack.org/511188 | 06:57 |
| *** jaosorior has joined #openstack-nova | 06:58 | |
| *** fragatina has quit IRC | 07:00 | |
| *** pcaruana has joined #openstack-nova | 07:01 | |
| *** gjayavelu has quit IRC | 07:02 | |
| *** imacdonn has quit IRC | 07:04 | |
| *** imacdonn has joined #openstack-nova | 07:04 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/548772 | 07:06 |
| *** voelzmo has joined #openstack-nova | 07:08 | |
| *** chyka has joined #openstack-nova | 07:10 | |
| *** armaan has quit IRC | 07:12 | |
| *** andreas_s has joined #openstack-nova | 07:12 | |
| *** armaan has joined #openstack-nova | 07:12 | |
| *** chyka has quit IRC | 07:14 | |
| *** voelzmo has quit IRC | 07:22 | |
| *** rcernin has quit IRC | 07:23 | |
| *** sapd1 has joined #openstack-nova | 07:24 | |
| *** tesseract has joined #openstack-nova | 07:26 | |
| *** ccamacho has joined #openstack-nova | 07:32 | |
| *** amoralej|off is now known as amoralej | 07:34 | |
| *** yangyapeng has joined #openstack-nova | 07:34 | |
| *** moshele has joined #openstack-nova | 07:35 | |
| *** fragatina has joined #openstack-nova | 07:35 | |
| *** lpetrut has joined #openstack-nova | 07:36 | |
| *** damien_r has joined #openstack-nova | 07:39 | |
| *** AlexeyAbashkin has joined #openstack-nova | 07:44 | |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 07:45 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 07:45 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240 | 07:45 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340 | 07:45 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344 | 07:45 |
| *** jpena|off is now known as jpena | 07:46 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Avoid showing password in log https://review.openstack.org/558694 | 07:53 |
| kashyap | johnthetubaguy: Morning; this is ready, if it's merged, can get going with the backports: https://review.openstack.org/#/c/534384/ | 07:53 |
| *** voelzmo has joined #openstack-nova | 07:59 | |
| gmann | johnthetubaguy: alex_xu_ gibi_away looking for feedback on this - https://review.openstack.org/#/c/547850/ | 08:01 |
| *** alexchadin has quit IRC | 08:02 | |
| *** fnordahl_ is now known as fnordahl | 08:04 | |
| *** tinwood_ is now known as tinwood | 08:06 | |
| *** fragatina has quit IRC | 08:07 | |
| *** germs has joined #openstack-nova | 08:08 | |
| *** germs has quit IRC | 08:08 | |
| *** germs has joined #openstack-nova | 08:08 | |
| *** alexchadin has joined #openstack-nova | 08:12 | |
| *** germs has quit IRC | 08:12 | |
| *** avolkov has joined #openstack-nova | 08:14 | |
| *** mgoddard has joined #openstack-nova | 08:16 | |
| *** lucas-afk is now known as lucasagomes | 08:17 | |
| *** kholkina has quit IRC | 08:18 | |
| *** Tom-Tom has joined #openstack-nova | 08:19 | |
| *** mdnadeem has joined #openstack-nova | 08:21 | |
| *** yassine has joined #openstack-nova | 08:29 | |
| *** ragiman has joined #openstack-nova | 08:29 | |
| *** voelzmo has quit IRC | 08:31 | |
| *** voelzmo_ has joined #openstack-nova | 08:31 | |
| *** Zames has joined #openstack-nova | 08:35 | |
| *** Zames has quit IRC | 08:39 | |
| *** tssurya has joined #openstack-nova | 08:40 | |
| *** jichen has quit IRC | 08:43 | |
| *** voelzmo_ has quit IRC | 08:49 | |
| *** voelzmo has joined #openstack-nova | 08:50 | |
| *** yangyapeng has quit IRC | 08:50 | |
| *** links has quit IRC | 08:53 | |
| *** links has joined #openstack-nova | 08:57 | |
| *** takashin has left #openstack-nova | 09:02 | |
| *** sdague has joined #openstack-nova | 09:03 | |
| *** sapd1 has quit IRC | 09:03 | |
| *** mdbooth has joined #openstack-nova | 09:05 | |
| *** sree_ has joined #openstack-nova | 09:05 | |
| *** sree_ is now known as Guest18520 | 09:05 | |
| *** tetsuro has left #openstack-nova | 09:06 | |
| *** Guest90995 has quit IRC | 09:08 | |
| *** yangyapeng has joined #openstack-nova | 09:09 | |
| *** edmondsw has joined #openstack-nova | 09:10 | |
| *** Zames has joined #openstack-nova | 09:13 | |
| *** yangyapeng has quit IRC | 09:14 | |
| *** edmondsw has quit IRC | 09:15 | |
| *** Zames has quit IRC | 09:16 | |
| *** liuzz has quit IRC | 09:16 | |
| *** pmannidi has joined #openstack-nova | 09:25 | |
| *** sree_ has joined #openstack-nova | 09:26 | |
| *** sree_ is now known as Guest55808 | 09:26 | |
| *** yangyapeng has joined #openstack-nova | 09:26 | |
| *** Guest18520 has quit IRC | 09:28 | |
| *** yangyapeng has quit IRC | 09:31 | |
| *** Guest55808 has quit IRC | 09:31 | |
| *** sridharg has quit IRC | 09:33 | |
| *** voelzmo has quit IRC | 09:33 | |
| *** voelzmo has joined #openstack-nova | 09:34 | |
| *** alexchadin has quit IRC | 09:35 | |
| *** huanxie has joined #openstack-nova | 09:37 | |
| *** voelzmo has quit IRC | 09:38 | |
| *** yamahata has quit IRC | 09:44 | |
| *** Shilpa has joined #openstack-nova | 09:44 | |
| *** licanwei has quit IRC | 09:45 | |
| openstackgerrit | sahid proposed openstack/nova-specs master: update: isolate guests emulthreads on CONF.cpu_shared_set https://review.openstack.org/511188 | 09:46 |
| *** Tom-Tom has quit IRC | 09:48 | |
| naichuans | Hi, dansmith, do you have the time to review below patches: https://review.openstack.org/#/c/554154/, https://review.openstack.org/#/c/489451/. It all about use xapi-pool instead of aggregate pool. We have finished internal review and the test. Thank you very much. | 09:50 |
| *** yangyapeng has joined #openstack-nova | 09:53 | |
| *** dtantsur|afk is now known as dtantsur | 09:54 | |
| *** yangyapeng has quit IRC | 09:58 | |
| openstackgerrit | Rajesh Tailor proposed openstack/nova master: Fix host validity check for live-migration https://review.openstack.org/401009 | 09:59 |
| johnthetubaguy | gmann: policy wise, I would prefer we concentrated on adopting the new set of roles, which I think we can do at the same time? | 10:00 |
| johnthetubaguy | gmann: that might be stupid, what do you think? | 10:00 |
| kashyap | johnthetubaguy: Sorry to nag, but I don't suppose you'd have time to have a gander again on the above? | 10:02 |
| kashyap | Just trying to curb the "dragging on" of this | 10:03 |
| johnthetubaguy | kashyap: its in my next tab :) | 10:03 |
| * kashyap nods; thanks :-) | 10:03 | |
| *** dtruong_ has joined #openstack-nova | 10:05 | |
| *** artom_ has joined #openstack-nova | 10:06 | |
| *** HW_Peter has joined #openstack-nova | 10:06 | |
| *** stvnoyes1 has joined #openstack-nova | 10:06 | |
| *** tiendc_ has joined #openstack-nova | 10:06 | |
| *** evin has joined #openstack-nova | 10:07 | |
| *** tianhui_ has joined #openstack-nova | 10:07 | |
| *** armaan_ has joined #openstack-nova | 10:07 | |
| *** yamamoto_ has joined #openstack-nova | 10:08 | |
| *** phuongnh has quit IRC | 10:08 | |
| *** cfriesen_ has joined #openstack-nova | 10:09 | |
| *** annp_ has joined #openstack-nova | 10:09 | |
| *** beekneemech has joined #openstack-nova | 10:10 | |
| *** ejat_ has joined #openstack-nova | 10:11 | |
| *** gibi_awa1 has joined #openstack-nova | 10:11 | |
| *** lifeless_ has joined #openstack-nova | 10:11 | |
| *** pcaruana|afk| has joined #openstack-nova | 10:12 | |
| *** shaohe_feng_ has joined #openstack-nova | 10:13 | |
| johnthetubaguy | kashyap: you get my first +2 of the day, its a relief to actually +2 something! | 10:13 |
| kashyap | johnthetubaguy: Haha | 10:14 |
| kashyap | johnthetubaguy: Thank you! If your fingers are itching, here's another one: https://review.openstack.org/#/c/558171/ | 10:14 |
| kashyap | But it requires more discussion on the list | 10:14 |
| *** weshay_ has joined #openstack-nova | 10:14 | |
| *** markmc` has joined #openstack-nova | 10:14 | |
| kashyap | Topic of it: [RFC] Pick next minimum libvirt / QEMU versions for "Stein" | 10:14 |
| johnthetubaguy | kashyap: ah right, I usually let distro people argue that one out, good to have the discussion though! | 10:15 |
| kashyap | Yeah, I did an hour's sleuthing and wrote a new email | 10:15 |
| kashyap | But `postfix` isn't letting me send it to openstack-{dev,operator} lists | 10:15 |
| * kashyap shaves that local yak first | 10:15 | |
| *** sdague has quit IRC | 10:15 | |
| *** lajoskatona has quit IRC | 10:15 | |
| *** sar has quit IRC | 10:15 | |
| *** yamamoto has quit IRC | 10:15 | |
| *** Eran_Kuris has quit IRC | 10:15 | |
| *** annp has quit IRC | 10:15 | |
| *** tiendc has quit IRC | 10:15 | |
| *** brad[] has quit IRC | 10:15 | |
| *** mvk has quit IRC | 10:15 | |
| *** artom has quit IRC | 10:15 | |
| *** ejat has quit IRC | 10:15 | |
| *** owalsh has quit IRC | 10:15 | |
| *** bandini has quit IRC | 10:15 | |
| *** stvnoyes has quit IRC | 10:15 | |
| *** shaohe_feng has quit IRC | 10:15 | |
| *** markmc has quit IRC | 10:15 | |
| *** bnemec has quit IRC | 10:15 | |
| *** lifeless has quit IRC | 10:15 | |
| *** mdnadeem has quit IRC | 10:15 | |
| *** armaan has quit IRC | 10:15 | |
| *** pcaruana has quit IRC | 10:15 | |
| *** ircuser-1 has quit IRC | 10:15 | |
| *** sapd has quit IRC | 10:15 | |
| *** tianhui has quit IRC | 10:15 | |
| *** dtruong has quit IRC | 10:15 | |
| *** HW-Peter has quit IRC | 10:15 | |
| *** jdillaman has quit IRC | 10:15 | |
| *** gibi_away has quit IRC | 10:15 | |
| *** weshay has quit IRC | 10:15 | |
| *** cfriesen has quit IRC | 10:15 | |
| *** lucasagomes has quit IRC | 10:15 | |
| *** ingy has quit IRC | 10:15 | |
| *** belmoreira has quit IRC | 10:16 | |
| *** shaohe_feng_ is now known as shaohe_feng | 10:16 | |
| *** owalsh has joined #openstack-nova | 10:17 | |
| *** mdnadeem has joined #openstack-nova | 10:17 | |
| *** lajoskatona has joined #openstack-nova | 10:18 | |
| *** sapd has joined #openstack-nova | 10:18 | |
| *** lucasagomes has joined #openstack-nova | 10:19 | |
| *** jdillaman has joined #openstack-nova | 10:20 | |
| johnthetubaguy | kashyap: your libvirt version looks too new for Debian, did I miss something there? | 10:20 |
| *** mvk has joined #openstack-nova | 10:21 | |
| kashyap | johnthetubaguy: I know, this morning I even spent time on #debian-backports | 10:21 |
| kashyap | johnthetubaguy: The discussion was: | 10:21 |
| kashyap | I also talked on #debian-backports IRC channel on OFTC network, where I | 10:21 |
| kashyap | asked: | 10:21 |
| kashyap | "What I'm essentially looking for is: "How can 'stretch' users get | 10:21 |
| kashyap | libvirt 3.2.0 and QEMU 2.9.0, even if via a different repository. | 10:21 |
| kashyap | As they are proposed to be least common denominator versions across | 10:21 |
| kashyap | distributions." | 10:21 |
| kashyap | And two people said: Then the versions from 'Buster' could be backported | 10:21 |
| kashyap | to 'stretch-backports'. The process for that is to: "ask the maintainer | 10:21 |
| kashyap | of those package and Cc to the backports mailing list." | 10:21 |
| johnthetubaguy | why 3.2 not 3.0.0? | 10:22 |
| johnthetubaguy | well, and 2.9 rather than 2.8? | 10:22 |
| *** Eran_Kuris has joined #openstack-nova | 10:22 | |
| *** udesale has quit IRC | 10:23 | |
| *** ircuser-1 has joined #openstack-nova | 10:23 | |
| johnthetubaguy | totally not against better stretch-backports, sounds like a good plan either way | 10:23 |
| *** ingy has joined #openstack-nova | 10:23 | |
| kashyap | johnthetubaguy: That is possible, actually -- to accomodate 'Stretch' | 10:24 |
| kashyap | To use 3.0.0 and 2.8 | 10:24 |
| *** sdague has joined #openstack-nova | 10:24 | |
| johnthetubaguy | its not a ... stretch (giggles like a school boy) | 10:24 |
| kashyap | But we should remember that 3.2.0 and 2.9 are already much older | 10:24 |
| *** udesale has joined #openstack-nova | 10:24 | |
| kashyap | Hehe | 10:25 |
| kashyap | johnthetubaguy: Did you also catch the email -- http://lists.openstack.org/pipermail/openstack-operators/2018-March/015067.html | 10:25 |
| kashyap | Where I actually called out the Debian thing, and asked people to chime in | 10:25 |
| johnthetubaguy | cool, seems like a step too far to exclude Debian, but its good to ask | 10:26 |
| kashyap | Yeah, exactly. I *don't* want to exclude it | 10:26 |
| *** bandini has joined #openstack-nova | 10:26 | |
| kashyap | That's why I even spent an hour or two talking to the upstream Debian folks on OFTC | 10:26 |
| kashyap | Just to see what could be done; since we can get rid of backward-compatibility code | 10:27 |
| *** pcaruana|afk| has quit IRC | 10:28 | |
| *** pcaruana|afk| has joined #openstack-nova | 10:28 | |
| *** shaohe_feng has quit IRC | 10:28 | |
| *** shaohe_feng has joined #openstack-nova | 10:28 | |
| *** weshay_ has quit IRC | 10:28 | |
| *** weshay_ has joined #openstack-nova | 10:28 | |
| *** markmc` has quit IRC | 10:28 | |
| *** markmc` has joined #openstack-nova | 10:28 | |
| *** lucasagomes has quit IRC | 10:28 | |
| *** lucasagomes has joined #openstack-nova | 10:28 | |
| *** nicolasbock has joined #openstack-nova | 10:30 | |
| johnthetubaguy | kashyap: so can't we do the bump to 1.3.1 and 2.5.0 now ish? | 10:31 |
| kashyap | johnthetubaguy: Yes, we can; that's what I'm working on. | 10:31 |
| kashyap | > As it stands, during the "Pike" release the advertized NEXT_MIN versions | 10:32 |
| kashyap | > were set to: libvirt 1.3.1 and QEMU 2.5.0 -- but they weren't actually | 10:32 |
| kashyap | > bumped for the "Queens" release. So they will now be applied for the | 10:32 |
| kashyap | > "Rocky" release. | 10:32 |
| kashyap | johnthetubaguy: I think that's what you were referring to | 10:32 |
| johnthetubaguy | kashyap: yeah, totally, just I would +2 that one | 10:32 |
| kashyap | Yeah, it requires going through the whole codebase removing conditional cruft, etc. And fix relevant unit tests | 10:33 |
| kashyap | Will post here once I'm ready in a bit | 10:33 |
| johnthetubaguy | true... well there are two changes, the bump then the removal, depending on how you look at it :) | 10:33 |
| johnthetubaguy | anyways, glad you are pushing on that, sounds worthwhile to me | 10:33 |
| *** bandini has quit IRC | 10:38 | |
| kashyap | johnthetubaguy: Yeah; there are multiple changes | 10:39 |
| kashyap | Just bumping it won't magically pass everything, would it? :-) | 10:39 |
| kashyap | Only one way to try | 10:40 |
| kashyap | s/try/figure/ | 10:40 |
| *** pmannidi has quit IRC | 10:40 | |
| *** alexchadin has joined #openstack-nova | 10:41 | |
| *** rcernin has joined #openstack-nova | 10:44 | |
| *** salv-orlando has joined #openstack-nova | 10:44 | |
| *** bandini has joined #openstack-nova | 10:45 | |
| *** annp_ has quit IRC | 10:46 | |
| *** Zames has joined #openstack-nova | 10:46 | |
| johnthetubaguy | kashyap: ha, good question, it might do | 10:46 |
| johnthetubaguy | not for good reasons, our testing of the min version is laughable, AFAIK | 10:47 |
| * kashyap is trying; will bump first, and fix the minimum required stuff | 10:47 | |
| kashyap | :D | 10:47 |
| *** Zames has quit IRC | 10:48 | |
| *** Zames has joined #openstack-nova | 10:50 | |
| openstackgerrit | Merged openstack/nova-specs master: Fix endpoint URI /allocation_requests https://review.openstack.org/557580 | 10:51 |
| *** tbachman has quit IRC | 10:54 | |
| *** hoangcx has quit IRC | 10:54 | |
| openstackgerrit | Merged openstack/nova-specs master: Provide error codes for placement API https://review.openstack.org/418393 | 10:55 |
| *** abhishekk has quit IRC | 10:56 | |
| *** Zames has quit IRC | 10:56 | |
| *** brad[] has joined #openstack-nova | 11:01 | |
| *** moshele has quit IRC | 11:02 | |
| sean-k-mooney | johnthetubaguy: kashyap for the rocky realse are we then not going to bump byond those verions and just use what we had planned for queens | 11:02 |
| kashyap | sean-k-mooney: That's a good question | 11:03 |
| kashyap | sean-k-mooney: I don't know, since we didn't give a heads-up, then we should simply stick with the versions what we planned for 'Queens'? | 11:03 |
| kashyap | I know it sucks | 11:03 |
| *** moshele has joined #openstack-nova | 11:03 | |
| kashyap | sean-k-mooney: But we _can_ bump it; if we all agree | 11:04 |
| sean-k-mooney | its less then ideal but if we dont depend on somthing form a newer release then i guess we dont have to bump | 11:04 |
| kashyap | That's why I added the note to my post to the list: | 11:04 |
| kashyap | > (Hmm, but note that libvirt 1.3.1 was released more | 11:04 |
| kashyap | > than 2 years ago[1].) | 11:04 |
| sean-k-mooney | ya i know | 11:04 |
| sean-k-mooney | thats why i asked :) | 11:04 |
| *** mdbooth has quit IRC | 11:05 | |
| sean-k-mooney | it finally means we dont have to check libvirt verions for vhost multi queue once we require 1.3.1+ | 11:05 |
| *** mdbooth has joined #openstack-nova | 11:05 | |
| * kashyap nods | 11:07 | |
| *** yikun_jiang has quit IRC | 11:07 | |
| openstackgerrit | Merged openstack/nova master: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 11:14 |
| *** lucasagomes is now known as lucas-hungry | 11:19 | |
| *** yassine has quit IRC | 11:22 | |
| *** yassine has joined #openstack-nova | 11:25 | |
| *** nicolasbock has left #openstack-nova | 11:26 | |
| *** nicolasbock has quit IRC | 11:26 | |
| *** belmoreira has joined #openstack-nova | 11:31 | |
| *** nicolasbock has joined #openstack-nova | 11:31 | |
| *** gyan__ has quit IRC | 11:38 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU} versions for "Rocky" https://review.openstack.org/558783 | 11:41 |
| *** damien_r has quit IRC | 11:41 | |
| *** alexchadin has quit IRC | 11:47 | |
| kashyap | johnthetubaguy: ^ | 11:50 |
| johnthetubaguy | kashyap: cool, ping me when zuul says yes | 11:50 |
| kashyap | Yeap | 11:50 |
| *** jpena is now known as jpena|lunch | 11:53 | |
| *** damien_r has joined #openstack-nova | 11:59 | |
| *** damien_r1 has joined #openstack-nova | 12:01 | |
| *** yangyapeng has joined #openstack-nova | 12:02 | |
| *** damien_r1 has quit IRC | 12:02 | |
| *** damien_r1 has joined #openstack-nova | 12:02 | |
| *** tbachman has joined #openstack-nova | 12:02 | |
| *** damien_r has quit IRC | 12:03 | |
| *** jackie-truong has joined #openstack-nova | 12:05 | |
| *** sree_ has joined #openstack-nova | 12:05 | |
| *** sree_ is now known as Guest18685 | 12:06 | |
| *** yangyapeng has quit IRC | 12:06 | |
| *** alexchadin has joined #openstack-nova | 12:06 | |
| *** tbachman_ has joined #openstack-nova | 12:06 | |
| *** mvk has quit IRC | 12:07 | |
| kashyap | johnthetubaguy: We did in the past: https://review.openstack.org/#/c/432700/2/releasenotes/notes/pike-libvirt-min-version-bb7f43020995ac10.yaml | 12:07 |
| *** tbachman has quit IRC | 12:07 | |
| *** tbachman_ is now known as tbachman | 12:07 | |
| johnthetubaguy | kashyap: ah, cool, upgrade sounds correct | 12:07 |
| kashyap | Err, you're right | 12:08 |
| kashyap | I'll do the s/feature/upgrade/ | 12:08 |
| *** Guest18685 has quit IRC | 12:09 | |
| *** germs has joined #openstack-nova | 12:10 | |
| *** germs has quit IRC | 12:10 | |
| *** germs has joined #openstack-nova | 12:10 | |
| *** lucas-hungry is now known as lucasagomes | 12:11 | |
| *** yangyapeng has joined #openstack-nova | 12:14 | |
| *** germs has quit IRC | 12:15 | |
| gmann | johnthetubaguy: i might not be getting you completely but yes we can adopt the new set of rules at same time based on old rule is overridden or not. If not then check new rule otherwise go for old rules till we remove them after deprecation phase | 12:15 |
| *** damien_r1 has quit IRC | 12:17 | |
| *** salv-orlando has quit IRC | 12:18 | |
| *** salv-orlando has joined #openstack-nova | 12:18 | |
| johnthetubaguy | gmann: not sure, do we have a spec for the Admin vs Read vs Write policy roles? | 12:19 |
| gmann | johnthetubaguy: i think not yet. | 12:19 |
| gmann | johnthetubaguy: just read your comment on patch. | 12:19 |
| *** damien_r has joined #openstack-nova | 12:19 | |
| johnthetubaguy | gmann: I see that as way more important, and the best reason to add the more granular rules, if that makes sense? | 12:20 |
| gmann | johnthetubaguy: i see your point | 12:20 |
| johnthetubaguy | I assume its operators that want those read only roles that want the extra granularity? | 12:20 |
| johnthetubaguy | so we can give them what the want, rather than what they are asking for, maybe? | 12:20 |
| gmann | yea mainly those | 12:20 |
| gmann | but with admin, read and write roles still we need granular rules with right default out of admin, read, write whatever suitable | 12:21 |
| johnthetubaguy | yes, but I think adding admin, read, write is the reason to add the granular rules | 12:22 |
| *** salv-orlando has quit IRC | 12:23 | |
| *** odyssey4me has quit IRC | 12:23 | |
| *** odyssey4me has joined #openstack-nova | 12:23 | |
| *** tiendc_ has quit IRC | 12:23 | |
| johnthetubaguy | gmann: I think there is a patch to add the global vs non-global stuff somewhere, I should dig that up too | 12:23 |
| *** yangyapeng has quit IRC | 12:25 | |
| gmann | johnthetubaguy: ok, i ll search it tomorrow. and yea i think i agree on your point. it makes sense of granular rules with those role. otherwise operator keep having complexity of their own defined roles. | 12:26 |
| johnthetubaguy | gmann: cool, that is the way I was thinking anyways, have a good evening/night | 12:28 |
| *** lbragstad has joined #openstack-nova | 12:29 | |
| *** amoralej is now known as amoralej|lunch | 12:29 | |
| kashyap | johnthetubaguy: A quick one: I think you meant to use FAKE_LIBVIRT_VERSION throughout consistently: https://review.openstack.org/#/c/558783/1 | 12:30 |
| gmann | johnthetubaguy: thanks. ll update based on the role patch. | 12:30 |
| * kashyap taps on the table and thinks making such changes will cause any issues in "backports" context | 12:30 | |
| *** pchavva has joined #openstack-nova | 12:30 | |
| johnthetubaguy | kashyap: yeah, that is what I meant to say | 12:32 |
| kashyap | Okido; should also probably add a constant for QEMU | 12:33 |
| johnthetubaguy | yeah, I thought there was one already, but yeah | 12:36 |
| *** Eran_Kuris has quit IRC | 12:36 | |
| *** salv-orlando has joined #openstack-nova | 12:36 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" https://review.openstack.org/558783 | 12:37 |
| kashyap | johnthetubaguy: Seems like (from a `git grep`) I'm the first user of the constant FAKE_LIBVIRT_VERSION in tests | 12:38 |
| *** ratailor_ has quit IRC | 12:38 | |
| *** gcb has quit IRC | 12:40 | |
| johnthetubaguy | hmm, that is curious | 12:41 |
| *** vladikr has joined #openstack-nova | 12:42 | |
| *** yangyapeng has joined #openstack-nova | 12:42 | |
| *** mvk has joined #openstack-nova | 12:42 | |
| *** edmondsw has joined #openstack-nova | 12:47 | |
| *** yangyapeng has quit IRC | 12:47 | |
| *** jpena|lunch is now known as jpena | 12:53 | |
| efried | johnthetubaguy: Thanks for merging the error codes spec. Do you know who's authorized to approve the blueprint (other than mriedem, who doesn't seem to be around)? | 12:58 |
| *** zhaochao has quit IRC | 13:00 | |
| *** moshele has quit IRC | 13:00 | |
| *** eharney has joined #openstack-nova | 13:01 | |
| *** lyan has joined #openstack-nova | 13:03 | |
| *** pchavva has quit IRC | 13:03 | |
| *** lyan is now known as Guest44505 | 13:03 | |
| *** psachin has quit IRC | 13:04 | |
| *** evin has quit IRC | 13:05 | |
| johnthetubaguy | efried: I can I think, in theory anyone with nova-specs core should be able to | 13:05 |
| efried | johnthetubaguy: Okay, thanks. | 13:06 |
| johnthetubaguy | that should look better now | 13:06 |
| *** weshay_ is now known as weshay | 13:06 | |
| efried | johnthetubaguy: Nice, thanks! In case you felt like looking at the code while the spec is still fresh, it's ready: https://review.openstack.org/#/c/546177/ | 13:07 |
| efried | be nice to have this code in place for edleafe's work on consumer generations. | 13:07 |
| johnthetubaguy | ah, I see your +2 there already, I will try take a look at that today | 13:07 |
| *** mriedem has joined #openstack-nova | 13:07 | |
| efried | cool, thank you. | 13:08 |
| mriedem | artom_: can you create https://blueprints.launchpad.net/nova/+spec/numa-aware-live-migration please? | 13:14 |
| *** udesale has quit IRC | 13:20 | |
| *** sahid has quit IRC | 13:21 | |
| *** amoralej|lunch is now known as amoralej | 13:21 | |
| artom_ | mriedem, ack | 13:22 |
| *** artom_ is now known as artom | 13:22 | |
| *** armaan_ has quit IRC | 13:22 | |
| *** armaan has joined #openstack-nova | 13:23 | |
| *** liverpooler has joined #openstack-nova | 13:23 | |
| artom | mriedem, done | 13:24 |
| mriedem | thanks | 13:24 |
| *** ragiman has quit IRC | 13:28 | |
| *** amodi has joined #openstack-nova | 13:29 | |
| *** esberglu has joined #openstack-nova | 13:29 | |
| *** yangyapeng has joined #openstack-nova | 13:30 | |
| *** jmlowe has joined #openstack-nova | 13:31 | |
| *** yangyapeng has quit IRC | 13:31 | |
| edleafe | jaypipes: around? | 13:35 |
| *** links has quit IRC | 13:35 | |
| edleafe | efried: cdent: maybe you guys could help with a question | 13:36 |
| efried | edleafe: I'm listening. | 13:36 |
| edleafe | ok, <1.8, allocations didn't have project_id/user_id | 13:36 |
| edleafe | in those cases, they are None on the object | 13:37 |
| edleafe | the code I'm doing for consumer generations tries to insert a record in the consumer table if one doesn't yet exist | 13:37 |
| edleafe | But there is a NOT NULL constraint on the project_id and user_id columns, so in that case (and many of our tests) the insert fails | 13:38 |
| edleafe | Should I just punt and say that for <1.8, no consumer record can be created? | 13:38 |
| efried | edleafe: tbc, this is because you wanted to be able to put the generation into the consumers table even for earlier microversions, yah? | 13:39 |
| dansmith | mriedem: I was holding this for your approval: https://review.openstack.org/#/c/558059/4 | 13:40 |
| edleafe | efried: well, normally I'd put a conditional and skip for <1.8. But that means that later calls can and will overwrite | 13:40 |
| edleafe | efried: It does seem that that's the best we can do here | 13:40 |
| edleafe | Just wanted to get a second opinion | 13:40 |
| efried | edleafe: So backing up for a second: today (before your code) if you try to create a consumer record with microversion <1.8, what happens? | 13:41 |
| efried | ...because presumably the request payload doesn't require the proj/user IDs at <1.8 | 13:41 |
| edleafe | efried: the code checks for the presence of those two fields on the allocation object, and if they aren't there, or are None, it skips the creation | 13:41 |
| efried | But how does it ultimately close the loop, then? | 13:42 |
| *** evin has joined #openstack-nova | 13:42 | |
| efried | The allocation gets created with... no consumer? | 13:42 |
| edleafe | So my feeling is we should continue that behavior, even if it sucks | 13:42 |
| *** dklyle has quit IRC | 13:42 | |
| edleafe | efried: yep | 13:42 |
| efried | So the consumer in that case is represented only by its UUID in the allocations table; it doesn't truly exist otherwise | 13:42 |
| edleafe | TBC, no consumer *record* | 13:42 |
| edleafe | it still has the instance UUID in the consumer_id field | 13:43 |
| efried | ...of the allocations table | 13:43 |
| edleafe | yes | 13:43 |
| * efried thinks | 13:43 | |
| efried | so presumably if you GET an allocation record at 1.8 that was created at <1.8, the proj/user doesn't show up in the response. | 13:44 |
| efried | or it shows up, but with null? | 13:44 |
| edleafe | yeah, they are None >=1.8 | 13:45 |
| efried | Seems to me like the right thing would be to make proj/user be nullable. | 13:45 |
| efried | and always create the record, even <1.8 | 13:45 |
| efried | ...which isn't a behavior change, because the API will still be doing exactly the same thing. | 13:46 |
| *** awaugama has joined #openstack-nova | 13:46 | |
| edleafe | It's a teeny behavior change, but a real edge of an edge case | 13:46 |
| edleafe | here's the case: | 13:47 |
| efried | How would it be a behavior change? You're just changing the condition from "if the record doesn't exist, assume null/null" to "use what's in the record, which will always be there (oh, and btw, might be null)" | 13:47 |
| mriedem | dansmith: i saw, but haven't dug into the changes yet | 13:47 |
| dansmith | mriedem: okay just wanted to make sure you did | 13:47 |
| edleafe | allocations are created <1.8. No consumer record in the past; now there is w/generation=0 | 13:47 |
| efried | dansmith, mriedem: You'll be delighted to know that I checked our OOT driver, and you don't break it with that change. | 13:48 |
| *** tbachman has quit IRC | 13:48 | |
| efried | ...because we use the tuple form already. | 13:48 |
| efried | edleafe: Sorry, still listening. | 13:48 |
| edleafe | np | 13:49 |
| *** armaan has quit IRC | 13:49 | |
| *** links has joined #openstack-nova | 13:49 | |
| mriedem | efried: i don't know why your out of tree driver would care about that change | 13:49 |
| *** armaan has joined #openstack-nova | 13:49 | |
| edleafe | A later attempt to allocate that provides the generation may or may not succeed, depending on the gen. If there were no consumer record, though, it would always succeed | 13:49 |
| edleafe | IMO, that's not a bad change, but it is a change | 13:50 |
| *** damien_r has quit IRC | 13:50 | |
| *** damien_r has joined #openstack-nova | 13:51 | |
| *** jbernard has quit IRC | 13:51 | |
| belmoreira | dansmith mriedem can you have a look into https://bugs.launchpad.net/nova/+bug/1761197 and give me your opinion? | 13:51 |
| openstack | Launchpad bug 1761197 in OpenStack Compute (nova) "Not defined keypairs in instance_extra cellsV1 DBs" [Undecided,New] - Assigned to Surya Seetharaman (tssurya) | 13:51 |
| *** jbernard has joined #openstack-nova | 13:51 | |
| efried | mriedem: https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/tasks/network.py#L183-L186 where _get_vif_events uses the tuple form: https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/tasks/network.py#L226 | 13:51 |
| mriedem | efried: that's how it's used in tree today too | 13:52 |
| efried | edleafe: But the "later attempt to allocate that provides the generation" *should not* "always succeed" | 13:52 |
| efried | mriedem: Right, I guess we've ported that code over already. | 13:52 |
| kashyap | dansmith: Hi there, if you get time today, I too (like johnthetubaguy, who +2ed) am going blind on this: https://review.openstack.org/#/c/534384/ | 13:52 |
| efried | edleafe: Besides, there's not a behavior change wrt generation handling cause we don't *have* generation handling yet. | 13:52 |
| efried | edleafe: IMO this is all tasty goodness. | 13:53 |
| edleafe | efried: sure, but if we preserve the behavior with allocations <1.8 (who even uses that anymore?), it will always succeed | 13:53 |
| edleafe | As I said, an edge of an edge case | 13:53 |
| mriedem | efried: i guess you're referring to how event_names in that interface can be a list of names, rather than tuples https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L447 | 13:53 |
| efried | mriedem: right. Was allowable before dansmith's patch on your change. | 13:53 |
| dansmith | belmoreira: hmm, are you saying that back when you ran the keypair migration they weren't sync'd down to the v1 cell databases and thus nothing happened? | 13:54 |
| dansmith | efried: everyone copied the first implementation in libvirt I imagine, which was luckily done the more explicit way..I checked all the in-tree drivers | 13:55 |
| efried | edleafe: Still not sure I follow. If you're using <1.8, you'll get generations incremented under the covers and you'll never know about it. As soon as you start using the new microversion (the one you're writing), you'll see the generation (whatever it is) when you GET, and you'll push it back when you PUT/POST. That's as it should be. But that behavior ought to be the same regardless of what we do with the proj/user | 13:55 |
| efried | dansmith: nod | 13:55 |
| efried | edleafe: The proj/user isn't required even at 1.8, is it? | 13:56 |
| *** damien_r1 has joined #openstack-nova | 13:56 | |
| *** _ix has joined #openstack-nova | 13:56 | |
| *** lbragstad has quit IRC | 13:56 | |
| efried | hm, looks like the user_id isn't marked as optional. | 13:56 |
| efried | sorry, neither is marked as optional. | 13:56 |
| efried | but are they in fact required? (That would seem weird, tbh) | 13:57 |
| *** damien_r has quit IRC | 13:58 | |
| efried | edleafe: But my point is that you would already have this weirdness if you straddled microversions like that. You would have to deal with the fact that proj/user were null before (whether it's because the record doesn't exist or because the record exists with nulls in it) and now are required (or whatever). | 13:58 |
| *** moshele has joined #openstack-nova | 13:58 | |
| edleafe | efried: they are required >=1.8 | 13:58 |
| efried | edleafe: We're probably talking in circles around an issue that's insignificant if it even exists at all. | 13:59 |
| efried | Is there any reason we can't make those fields nullable? | 13:59 |
| edleafe | efried: [t 2tEe] | 13:59 |
| purplerbot | <edleafe> It's a teeny behavior change, but a real edge of an edge case [2018-04-04 13:46:43.828800] [n 2tEe] | 13:59 |
| *** belmoreira has quit IRC | 13:59 | |
| *** sahid has joined #openstack-nova | 13:59 | |
| edleafe | Like, if you're a purist... | 14:00 |
| efried | and make the logic that returns them tolerate <record absent> and <record present with nulls> with the same result. | 14:00 |
| *** hongbin_ has joined #openstack-nova | 14:00 | |
| edleafe | sure, nulls would have to work in all cases | 14:00 |
| edleafe | ok, let me make that change to the consumers table and see how that works | 14:01 |
| *** moshele has quit IRC | 14:01 | |
| efried | ++ | 14:02 |
| *** gouthamr has joined #openstack-nova | 14:02 | |
| *** eharney has quit IRC | 14:04 | |
| *** eharney has joined #openstack-nova | 14:04 | |
| *** burt has joined #openstack-nova | 14:05 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Cleanup RP and HM records while deleting a compute service. https://review.openstack.org/554920 | 14:08 |
| *** lpetrut_ has joined #openstack-nova | 14:12 | |
| openstackgerrit | Merged openstack/nova master: Teardown networking when rolling back live migration even if shared disk https://review.openstack.org/555481 | 14:13 |
| *** lpetrut has quit IRC | 14:14 | |
| *** alexchadin has quit IRC | 14:16 | |
| *** sree_ has joined #openstack-nova | 14:20 | |
| *** sree_ is now known as Guest51139 | 14:20 | |
| *** cdent has joined #openstack-nova | 14:22 | |
| *** belmoreira has joined #openstack-nova | 14:24 | |
| belmoreira | dansmith: sorry was away... yes, the migration was only correctly done in top DB | 14:25 |
| *** armaan has quit IRC | 14:25 | |
| dansmith | belmoreira: but you mean the top api cell db, not the api_db, yes? | 14:25 |
| belmoreira | yes, the top DB in cellsV1 | 14:26 |
| dansmith | belmoreira: we just removed the code that did that migration, but even still, it would be out of the ordinary to make nova-manage reach across cellsv1 DBs | 14:26 |
| *** alexchadin has joined #openstack-nova | 14:27 | |
| *** Guest51139 has quit IRC | 14:28 | |
| *** sree has joined #openstack-nova | 14:28 | |
| *** mlavalle has joined #openstack-nova | 14:28 | |
| belmoreira | dansmith: yes I saw that the code was removed. But when running nova-manage in cells DBs it should go to nova_api for the keypair | 14:28 |
| *** amodi has quit IRC | 14:29 | |
| belmoreira | I can cook something to keep me going but not sure how many people will have the same problem when moving to cellsV2 | 14:29 |
| *** r-daneel has joined #openstack-nova | 14:29 | |
| dansmith | oh..wait, | 14:29 |
| efried | dansmith, mriedem: Any reason we should be waiting to merge https://review.openstack.org/#/c/558648/ ? | 14:29 |
| *** archit has joined #openstack-nova | 14:29 | |
| efried | (and... what's Kevin's IRC nick?) | 14:29 |
| dansmith | belmoreira: you're saying if you run the migration against a child cell it doesn't look to api_db for the keypair, but does if you run it against the api cell? | 14:30 |
| mriedem | Vek | 14:30 |
| efried | k, not on. Just wondering why he didn't +W it. | 14:30 |
| *** archit is now known as amodi | 14:30 | |
| dansmith | efried: *shrug* if it works I guess it's fine, I have no strong opinions | 14:31 |
| efried | dansmith: ight, done. | 14:31 |
| mriedem | efried: that patch doesn't cover fast8 | 14:32 |
| mriedem | which is the only thing i use | 14:32 |
| *** rcernin has quit IRC | 14:32 | |
| mriedem | *only thing i use for pep8 locally | 14:32 |
| dansmith | that's all I use too, | 14:32 |
| dansmith | but it's run by a script, so maybe it's a different issue? | 14:32 |
| * cdent quotes dansmith for future use in legal battles "I have no strong opinions" | 14:33 | |
| *** salv-orlando has quit IRC | 14:33 | |
| dansmith | oh, I guess it's the same as pep8 actually | 14:33 |
| mriedem | yeah | 14:33 |
| dansmith | cdent: *on this | 14:33 |
| mriedem | just smaller scope of changes | 14:33 |
| dansmith | yeah | 14:33 |
| * cdent darns | 14:33 | |
| dansmith | I thought it was different for some reason | 14:33 |
| belmoreira | dansmith: no, what I was trying to say is that the original migration was not considering cells. It was only looking to the keypairs in the same DB. But, maybe we can have a new migration to look into the nova_api DB for the keypair when running nova-manage in child cells | 14:33 |
| mriedem | efried: removing your -W doesn't pull it out of the queue | 14:33 |
| sean-k-mooney | fast8 just runs pep8 on the files you changed in the current patch or working tree | 14:34 |
| efried | mriedem: I suspected that might be the case :( | 14:34 |
| sean-k-mooney | its a nice speed up | 14:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Default to py3 for the pep8 tox env because it's stricter https://review.openstack.org/558648 | 14:34 |
| mriedem | that pulled it out | 14:34 |
| dansmith | belmoreira: oh, did that one come before the ->api_db migration? it's not in my tree so I didn't go look | 14:34 |
| dansmith | belmoreira: that makes more sense, but also.. :/ | 14:34 |
| *** jmlowe has quit IRC | 14:34 | |
| efried | mriedem: thanks. It also occurs to me: does setting basepython actually do anything given that the commands are being run from within a sh script? | 14:35 |
| *** lbragstad has joined #openstack-nova | 14:35 | |
| mriedem | efried: not sure, unless that's the version of python 'installed' into the venv | 14:35 |
| mriedem | and then the script runs in that venv | 14:36 |
| belmoreira | dansmith: yes, it was before the keypair migration to nova_api | 14:36 |
| dansmith | mriedem: I think it's the version that gets linked to bin/python yeah | 14:36 |
| dansmith | so if that script is just running "python ..." then ... | 14:36 |
| efried | dansmith, mriedem: It's not. | 14:37 |
| efried | The script runs flake8, which is a python script with its own #! | 14:37 |
| dansmith | right, but does the pip install from the basepython link it thusly? | 14:38 |
| efried | ah, which in the venv does indeed invoke `python` | 14:38 |
| efried | ...the venv's python. So yeah, should work. | 14:38 |
| *** fanzhang has quit IRC | 14:42 | |
| *** fanzhang has joined #openstack-nova | 14:44 | |
| *** r-daneel has quit IRC | 14:47 | |
| *** dosaboy_ is now known as dosaboy | 14:47 | |
| *** dklyle has joined #openstack-nova | 14:48 | |
| *** felipemonteiro has joined #openstack-nova | 14:52 | |
| *** jmlowe has joined #openstack-nova | 14:53 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova-specs master: Fix typos in NUMA-aware live migration https://review.openstack.org/558842 | 14:55 |
| *** david-lyle has joined #openstack-nova | 14:57 | |
| artom | bauzas, ^^ | 14:57 |
| *** Kevin_Zheng has joined #openstack-nova | 14:57 | |
| *** dklyle has quit IRC | 14:57 | |
| *** mlavalle has quit IRC | 14:57 | |
| *** pchavva has joined #openstack-nova | 14:58 | |
| *** sree has quit IRC | 14:59 | |
| *** lajoskatona has quit IRC | 15:00 | |
| *** sree has joined #openstack-nova | 15:00 | |
| *** links has quit IRC | 15:00 | |
| *** mlavalle has joined #openstack-nova | 15:00 | |
| bauzas | specs cores, easy +W on https://review.openstack.org/#/c/558842/ (typos fixes) | 15:03 |
| *** r-daneel has joined #openstack-nova | 15:04 | |
| *** alexchadin has quit IRC | 15:04 | |
| *** sree has quit IRC | 15:04 | |
| *** Zames has joined #openstack-nova | 15:08 | |
| *** Zames has quit IRC | 15:08 | |
| *** r-daneel_ has joined #openstack-nova | 15:08 | |
| *** r-daneel has quit IRC | 15:08 | |
| *** r-daneel_ is now known as r-daneel | 15:08 | |
| *** Zames has joined #openstack-nova | 15:09 | |
| *** Spazmotic1 has joined #openstack-nova | 15:13 | |
| *** janki has quit IRC | 15:14 | |
| *** zhurong has joined #openstack-nova | 15:14 | |
| *** Zames has quit IRC | 15:16 | |
| *** Spaz-Home has quit IRC | 15:17 | |
| *** Zames has joined #openstack-nova | 15:17 | |
| *** tblakes has joined #openstack-nova | 15:19 | |
| *** amodi has quit IRC | 15:19 | |
| *** Zames has quit IRC | 15:19 | |
| tblakes | mriedem: gibi: When you have a chance, could you please review the updated changes for https://review.openstack.org/#/c/555812/? | 15:20 |
| *** felipemonteiro_ has joined #openstack-nova | 15:22 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Default to py3 for the pep8 tox env because it's stricter https://review.openstack.org/558648 | 15:24 |
| *** felipemonteiro has quit IRC | 15:26 | |
| *** yamahata has joined #openstack-nova | 15:30 | |
| efried | tblakes: FYI, gibi is on vacation for another week and a half. (Honeymoon) | 15:31 |
| *** felipemonteiro__ has joined #openstack-nova | 15:33 | |
| *** felipemonteiro_ has quit IRC | 15:33 | |
| *** salv-orlando has joined #openstack-nova | 15:33 | |
| tblakes | efried: Thank you for the heads up. | 15:33 |
| *** evrardjp_ has joined #openstack-nova | 15:35 | |
| *** evrardjp has quit IRC | 15:36 | |
| *** salv-orlando has quit IRC | 15:38 | |
| *** germs has joined #openstack-nova | 15:38 | |
| *** germs has quit IRC | 15:38 | |
| *** germs has joined #openstack-nova | 15:38 | |
| *** tesseract has quit IRC | 15:38 | |
| *** dtantsur is now known as dtantsur|brb | 15:38 | |
| *** germs has quit IRC | 15:39 | |
| *** germs has joined #openstack-nova | 15:39 | |
| *** germs has quit IRC | 15:39 | |
| *** germs has joined #openstack-nova | 15:39 | |
| *** Spaz-Home has joined #openstack-nova | 15:40 | |
| *** andreas_s has quit IRC | 15:41 | |
| *** tesseract has joined #openstack-nova | 15:41 | |
| *** tbachman has joined #openstack-nova | 15:41 | |
| *** dtruong_ has quit IRC | 15:41 | |
| *** dtruong has joined #openstack-nova | 15:42 | |
| *** links has joined #openstack-nova | 15:43 | |
| *** Spazmotic1 has quit IRC | 15:43 | |
| *** pcaruana|afk| has quit IRC | 15:45 | |
| *** armaan has joined #openstack-nova | 15:46 | |
| belmoreira | dansmith: also, it's not only the migration. New instances don't have the keypair (NULL) defined in instance_extra in child cells DBs when running cellsV1. It's only in the top DB of cellsV1. | 15:46 |
| belmoreira | dansmith: running ocata | 15:47 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: libvirt: Block swap volume attempts with encrypted volumes prior to Queens https://review.openstack.org/543569 | 15:47 |
| dansmith | belmoreira: because instance_extra post-dates cellsv1 and isn't sync'd AFAIK | 15:47 |
| belmoreira | dansmith: the keypair, because other fields are | 15:48 |
| dansmith | belmoreira: other fields of instance_extra? | 15:48 |
| belmoreira | dansmith: yes, for example flavor | 15:49 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Filter resource providers by forbidden traits in db https://review.openstack.org/556472 | 15:49 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Filter allocation candidates by forbidden traits in db https://review.openstack.org/556660 | 15:49 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Parse forbidden traits in query strings https://review.openstack.org/556819 | 15:49 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Support forbidden traits in API https://review.openstack.org/556820 | 15:49 |
| dansmith | belmoreira: okay maybe we added something for flavor, I need to go look | 15:52 |
| *** chyka has joined #openstack-nova | 15:53 | |
| *** amodi has joined #openstack-nova | 16:01 | |
| *** tblakes has quit IRC | 16:04 | |
| *** evrardjp_ is now known as evrardjp | 16:05 | |
| *** links has quit IRC | 16:05 | |
| *** kuzko has joined #openstack-nova | 16:07 | |
| *** sahid has quit IRC | 16:09 | |
| *** salv-orlando has joined #openstack-nova | 16:09 | |
| belmoreira | dansmith: humm... vcpu_model in instance_extra is also not sync. It only exists in the top DB in cellsV1 | 16:11 |
| *** eharney has quit IRC | 16:13 | |
| sean-k-mooney | belmoreira: the vcpu_model should be stored in the instance object itself in the celldb no? | 16:13 |
| *** eharney has joined #openstack-nova | 16:14 | |
| *** mriedem has quit IRC | 16:15 | |
| belmoreira | sean-k-mooney: not sure if I'm understanding to what you are referring | 16:16 |
| *** tbachman has quit IRC | 16:17 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" https://review.openstack.org/558783 | 16:18 |
| sean-k-mooney | so the vcpu modle is stored in instance extra as declared here https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L58-L60. so you are saying in the cell1 db that field is not populated on the instance record but it is in the api db? | 16:18 |
| *** links has joined #openstack-nova | 16:20 | |
| sean-k-mooney | belmoreira: vcpu_model is also declared as an instance field here https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L211 so i assumed it would be stored in the instnace object iteslef not in instrance_extra | 16:20 |
| *** jaypipes has joined #openstack-nova | 16:20 | |
| dansmith | sean-k-mooney: he's talking about cellsv1 | 16:20 |
| belmoreira | sean-k-mooney: I'm using cellsV1. the vcpu_model is in the top DB (cellsV1) but then is not sync to the child cells DBs | 16:20 |
| dansmith | which is more complicated | 16:20 |
| belmoreira | dansmith sean-k-mooney: thanks for the help. I need to leave now | 16:21 |
| sean-k-mooney | dansmith: ya i have kindof hopped to never need to know how v1 worked. | 16:21 |
| *** belmoreira has quit IRC | 16:23 | |
| *** efried is now known as efried_rollin | 16:25 | |
| *** udesale has joined #openstack-nova | 16:26 | |
| *** naichuans has quit IRC | 16:29 | |
| *** zhurong has quit IRC | 16:29 | |
| *** gjayavelu has joined #openstack-nova | 16:35 | |
| lbragstad | melwitt: we have another iteration of the default roles specification up for review (re: the identity intregration track from dublin) in case you're still interested in taking a look | 16:37 |
| *** mriedem has joined #openstack-nova | 16:37 | |
| *** AlexeyAbashkin has quit IRC | 16:38 | |
| lbragstad | https://review.openstack.org/#/c/523973/ consists of the latest changes | 16:38 |
| melwitt | lbragstad: great, thanks for the heads up | 16:38 |
| lbragstad | melwitt: no problem - let me know if you still want to go through the scope_types thing, too (cc mriedem) | 16:39 |
| *** beekneemech is now known as bnemec | 16:42 | |
| *** lucasagomes is now known as lucas-afk | 16:45 | |
| *** claudiub|2 has quit IRC | 16:45 | |
| johnthetubaguy | lbragstad: I keep meaning to hit that one too | 16:45 |
| *** claudiub|2 has joined #openstack-nova | 16:46 | |
| *** udesale has quit IRC | 16:46 | |
| *** gjayavelu has quit IRC | 16:50 | |
| mriedem | dansmith: on the heels of this wait_for_instance_event thing, i'm probably going to need a handle to the registered events so that i can cancel them, related to the TODO here https://review.openstack.org/#/c/558001/1/nova/compute/manager.py@6100 | 16:50 |
| mriedem | i.e. i need to start waiting before calling the dest compute which returns a flag telling me if i should in fact be waiting | 16:51 |
| mriedem | if dest says it doesn't care, then i need not wait | 16:51 |
| dansmith | um, I'm not sure I understand | 16:51 |
| mriedem | this is the thing where the source waits for vif plugged events, | 16:52 |
| mriedem | pre_live_migration on the dest host does the vif plugging, | 16:52 |
| mriedem | source is waiting | 16:52 |
| dansmith | as long as you do your call to the remote side within the "with wait_for_events.." then whatever | 16:52 |
| dansmith | oh so you don't hang exiting the with? | 16:52 |
| mriedem | the change adds a config option to enable this, because we know some backends in neutron won't send the event unless the port host binding changes | 16:52 |
| mriedem | well, the dest could set the flag saying don't wait, because it's using opendaylight or something | 16:52 |
| mriedem | so then we want the source to not wait the 5 minutes and then die | 16:53 |
| dansmith | right, but you've already entered the context manager at the point at which you realize the destination says not to wait yeah? | 16:53 |
| mriedem | right, not yet in this patch, but that's the TODO | 16:53 |
| dansmith | yeah, | 16:53 |
| mriedem | to avoid a race window | 16:53 |
| mriedem | as mentioned in the commit message, we could arguably say that we assume computes in the same cell to be using the same networking backend and just apply the config from the source host | 16:54 |
| dansmith | so you can just raise in there and catch it outside the context manager.. something like "raise BelayThatOrderCapN()" | 16:54 |
| dansmith | I don't think you need anything more complicated than that | 16:54 |
| mriedem | raise from within the wait_for_instance_event context? | 16:55 |
| dansmith | yeah | 16:55 |
| mriedem | wouldn't that call the error_callback registered with the event? | 16:56 |
| dansmith | not if you don't have one, which you don't right? but either way, handle it in the error_callback if you want | 16:56 |
| dansmith | er, no | 16:57 |
| dansmith | actually if you raise yourself then it doesn't call error_callback even | 16:57 |
| dansmith | that's only if the event fails | 16:57 |
| dansmith | so just raise | 16:57 |
| mriedem | yeah, flow control might get a bit wonky in this code, will have to deal with that | 16:58 |
| *** fragatina has joined #openstack-nova | 16:58 | |
| mriedem | with the rpc change to the migrate data object we can't backport this either, but it's been such a latent issue maybe it's not something we really care about backporting anyway | 16:59 |
| dansmith | I dunno, you're already catching exceptions around the context manager, so I would think it's just a catch/log/ignore and fall through sort of deal | 16:59 |
| dansmith | oh, well, I guess you need to do that inside maybe | 17:00 |
| dansmith | anyway | 17:00 |
| dansmith | easier that building a cancel mechanism I think | 17:00 |
| dansmith | *than | 17:00 |
| mriedem | yeah i can also refactor our the existing meat if necessary for the part that actually calls the driver to transfer the guest | 17:00 |
| mriedem | these live migration methods tend to get overly complicated | 17:00 |
| dansmith | aye | 17:01 |
| mriedem | *out | 17:01 |
| *** mdbooth has quit IRC | 17:01 | |
| *** germs has quit IRC | 17:03 | |
| *** mgoddard has quit IRC | 17:03 | |
| *** felipemonteiro_ has joined #openstack-nova | 17:05 | |
| *** germs has joined #openstack-nova | 17:06 | |
| *** germs has quit IRC | 17:06 | |
| *** germs has joined #openstack-nova | 17:06 | |
| *** munimeha1 has joined #openstack-nova | 17:06 | |
| *** fragatina has quit IRC | 17:06 | |
| *** fragatina has joined #openstack-nova | 17:06 | |
| *** Kevin_Zheng has quit IRC | 17:07 | |
| *** tbachman has joined #openstack-nova | 17:08 | |
| *** links has quit IRC | 17:08 | |
| *** felipemonteiro__ has quit IRC | 17:08 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: DRY up test_rollback_live_migration_set_migration_status https://review.openstack.org/555489 | 17:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Avoid unnecessary port update during live migration https://review.openstack.org/556332 | 17:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Wait for network-vif-plugged before starting live migration https://review.openstack.org/558001 | 17:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add check if neutron "binding-extended" extension is available https://review.openstack.org/523548 | 17:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "bind_ports_to_host" neutron API method https://review.openstack.org/523604 | 17:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423 | 17:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370 | 17:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170 | 17:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947 | 17:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334 | 17:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371 | 17:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Port binding based on events during live migration https://review.openstack.org/434870 | 17:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | 17:11 |
| *** fragatina has quit IRC | 17:11 | |
| openstackgerrit | Merged openstack/nova master: trivial: Fix nits in code comments https://review.openstack.org/558133 | 17:12 |
| openstackgerrit | Merged openstack/nova master: Complement tests in allocation candidates https://review.openstack.org/558135 | 17:12 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: test live_migration_wait_for_vif_plug=True https://review.openstack.org/558006 | 17:12 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: test live_migration_wait_for_vif_plug=True https://review.openstack.org/558006 | 17:12 |
| *** tbachman has quit IRC | 17:13 | |
| *** felipemonteiro_ has quit IRC | 17:13 | |
| *** felipemonteiro_ has joined #openstack-nova | 17:14 | |
| lbragstad | johnthetubaguy: ++ yeah - it'd be awesome to get your input there | 17:15 |
| *** jackie-truong has quit IRC | 17:15 | |
| *** jackie-truong has joined #openstack-nova | 17:15 | |
| *** david-lyle has quit IRC | 17:16 | |
| *** felipemonteiro_ has quit IRC | 17:18 | |
| *** tbachman has joined #openstack-nova | 17:18 | |
| *** jpena is now known as jpena|off | 17:19 | |
| *** felipemonteiro_ has joined #openstack-nova | 17:20 | |
| *** tianhui has joined #openstack-nova | 17:20 | |
| *** tianhui_ has quit IRC | 17:22 | |
| *** lpetrut_ has quit IRC | 17:22 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 17:22 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 17:22 |
| *** gouthamr has quit IRC | 17:24 | |
| *** fragatina has joined #openstack-nova | 17:30 | |
| *** mdnadeem has quit IRC | 17:32 | |
| *** Guest44505 has quit IRC | 17:32 | |
| *** Guest44505 has joined #openstack-nova | 17:33 | |
| *** adriano has joined #openstack-nova | 17:36 | |
| *** alexchadin has joined #openstack-nova | 17:44 | |
| *** tssurya has quit IRC | 17:45 | |
| *** mikal_ has joined #openstack-nova | 17:45 | |
| *** hongbin_ has quit IRC | 17:45 | |
| *** gouthamr has joined #openstack-nova | 17:45 | |
| *** mikal has quit IRC | 17:48 | |
| *** tianhui_ has joined #openstack-nova | 17:50 | |
| *** hongbin_ has joined #openstack-nova | 17:52 | |
| *** tianhui has quit IRC | 17:53 | |
| *** amodi has quit IRC | 17:53 | |
| *** fragatina has quit IRC | 17:55 | |
| *** fragatina has joined #openstack-nova | 17:56 | |
| *** yamamoto_ has quit IRC | 17:58 | |
| *** yamamoto has joined #openstack-nova | 17:59 | |
| *** felipemonteiro__ has joined #openstack-nova | 18:01 | |
| *** felipemonteiro_ has quit IRC | 18:02 | |
| *** adriano has quit IRC | 18:02 | |
| *** yamamoto_ has joined #openstack-nova | 18:06 | |
| *** AlexeyAbashkin has joined #openstack-nova | 18:08 | |
| *** amodi has joined #openstack-nova | 18:08 | |
| *** yamamoto has quit IRC | 18:10 | |
| *** lpetrut_ has joined #openstack-nova | 18:12 | |
| *** AlexeyAbashkin has quit IRC | 18:12 | |
| *** mchlumsky has quit IRC | 18:13 | |
| *** mrjk has quit IRC | 18:14 | |
| *** tesseract has quit IRC | 18:14 | |
| *** shaohe_feng has quit IRC | 18:15 | |
| *** shaohe_feng has joined #openstack-nova | 18:15 | |
| *** armaan has quit IRC | 18:16 | |
| *** voelzmo has joined #openstack-nova | 18:16 | |
| *** gjayavelu has joined #openstack-nova | 18:18 | |
| *** alexchadin has quit IRC | 18:18 | |
| *** Swami has joined #openstack-nova | 18:21 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Noauth should also use request_id from compute_req_id.py https://review.openstack.org/555266 | 18:22 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM: Add proc_units_factor conf option https://review.openstack.org/554688 | 18:22 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM: Add proc_units_factor conf option https://review.openstack.org/554688 | 18:23 |
| *** huanxie has quit IRC | 18:24 | |
| *** salv-orlando has quit IRC | 18:24 | |
| *** dtantsur|brb is now known as dtantsur | 18:29 | |
| *** armaan has joined #openstack-nova | 18:30 | |
| sean-k-mooney | dansmith: o/ do you have a minute to weigh in on unit test for the nic feature based schulding change set? | 18:31 |
| dansmith | sean-k-mooney: I dunno, ask and then I'll answer :) | 18:31 |
| sean-k-mooney | dansmith: alot of the test changes look like this https://review.openstack.org/#/c/449257/59/nova/tests/unit/compute/test_resource_tracker.py swapping from dicts to objects. if i do the lazy load change you requested the dict form would still work because we would have two fields. | 18:32 |
| sean-k-mooney | dansmith: i dont want to duplicate all the test but im wondering should i migrate all the tests as i had done before to the object form or keep the dict form | 18:33 |
| openstackgerrit | Merged openstack/nova master: Fix typos in release notes https://review.openstack.org/554175 | 18:33 |
| *** amodi has quit IRC | 18:33 | |
| openstackgerrit | Merged openstack/nova master: Remove unnecessary code encoding specification https://review.openstack.org/557903 | 18:34 |
| *** mgoddard has joined #openstack-nova | 18:34 | |
| dansmith | sean-k-mooney: well, what you have there doesn't really test anything other than kwarg dispatch of the init of that object, | 18:34 |
| dansmith | which shouldn't be **dict, IMHO | 18:34 |
| openstackgerrit | Merged openstack/nova master: Move pypowervm requirement to 1.1.12 https://review.openstack.org/558254 | 18:34 |
| openstackgerrit | Merged openstack/nova master: Remove a outdated warning https://review.openstack.org/557898 | 18:34 |
| dansmith | sean-k-mooney: on the field change, | 18:34 |
| sean-k-mooney | well the ** was because i originally used sed for the conversion | 18:34 |
| dansmith | uh huh :) | 18:35 |
| dansmith | you need to add this as a spec_obj field, and yes, I would expect to see at least a test that uses the old dict-y spec field with the rest of the code | 18:35 |
| *** armaan has quit IRC | 18:35 | |
| *** Sukhdev has joined #openstack-nova | 18:36 | |
| sean-k-mooney | im going to get rid of the ** but im just wonding if i should get rid of all uses of spec=[{}] and move them to spec_objs=[objects] | 18:36 |
| dansmith | I would expect to make all the existing tests use the object, and add one more new test that just makes sure something basic still works if you only have the dict field set | 18:36 |
| *** armaan has joined #openstack-nova | 18:36 | |
| cdent | sean-k-mooney, jaypipes (and dansmith and cfriesen_ you probably know this too): On jay's spec about cpu resource tracking ( https://review.openstack.org/#/c/555081/ ) the existing situation is that any given host can only be shared or dedicated, but not mixed? Is that just an OpenStack/Nova limitation, or is it also a limitation in libvirt/KVM? | 18:36 |
| dansmith | sean-k-mooney: yeah, except for the new test to validate the old dict path | 18:36 |
| dansmith | cdent: just nova AFAIK | 18:36 |
| sean-k-mooney | dansmith: ok ill convert them all to use objects like i had started and then add in test just for the old path thanks. | 18:37 |
| dansmith | sean-k-mooney: yup | 18:37 |
| cdent | so if we get nova sorted (via jay's ideas) we'll need to cook some code in the virtdriver, but not deeper in the stack? cool. | 18:37 |
| *** felipemonteiro has joined #openstack-nova | 18:38 | |
| sean-k-mooney | cdent: am nova will happliy allow a mixed host but it is not preventing the shared cpus from stomping over the pinned ones today. so we use host aggregates to seperate them | 18:38 |
| *** felipemonteiro__ has quit IRC | 18:38 | |
| cdent | sean-k-mooney: ah, okah, thanks | 18:39 |
| dansmith | right, thatg | 18:39 |
| *** Sukhdev has quit IRC | 18:41 | |
| melwitt | bhagyashris: I have a question about your spec on deleteBackups. my assumption has been that you have users that are currently using rotation '0' to purge backups as a side effect. is that correct? | 18:41 |
| melwitt | *using rotation '0' to the createBackup API | 18:41 |
| *** avolkov has quit IRC | 18:41 | |
| *** mgoddard has quit IRC | 18:45 | |
| *** amodi has joined #openstack-nova | 18:47 | |
| *** amoralej is now known as amoralej|off | 18:51 | |
| *** dtantsur is now known as dtantsur|afk | 18:52 | |
| *** AlexeyAbashkin has joined #openstack-nova | 18:58 | |
| *** tssurya has joined #openstack-nova | 19:02 | |
| *** AlexeyAbashkin has quit IRC | 19:02 | |
| mriedem | anyone know the tl;dr on the 'a plan to stop syncing requirements into projects' thread? | 19:07 |
| mriedem | sounds like requirements.txt changes are now all done manually? | 19:07 |
| dansmith | from the oslo room ptg, | 19:08 |
| dansmith | I think they were saying that they would only sync (or manually sync) requirements when the minimum was being raised past what the project has listed | 19:09 |
| dansmith | instead of just always syncing always | 19:09 |
| sean-k-mooney | mriedem: i get why we might want to do this to prevent raising minimums higher then needed but i think we are also losing that auto blacklisting of specific versions e.g. x>1.0,x!=1.1 | 19:09 |
| dansmith | so that things like swift can continue supporting the older versions of some libraries they have because of workarounds or lack of actual requirements for the newer one | 19:09 |
| *** jackie-truong has quit IRC | 19:10 | |
| mriedem | i just see that it's throwing people off e.g. https://review.openstack.org/#/c/554679/ | 19:10 |
| *** harlowja has joined #openstack-nova | 19:10 | |
| mriedem | and https://review.openstack.org/#/c/558254/ | 19:11 |
| dansmith | just yet another change in process | 19:11 |
| mriedem | which is actually < than what's in g-r | 19:11 |
| *** tbachman has quit IRC | 19:11 | |
| openstackgerrit | Tyler Blakeslee proposed openstack/nova master: Add __repr__ for NovaException https://review.openstack.org/555812 | 19:11 |
| sean-k-mooney | oh so in the scale io case they had expect the version bump but the proposal bot is not making it | 19:11 |
| openstackgerrit | Merged openstack/nova master: [placement] api-ref: Fix parameters https://review.openstack.org/558142 | 19:12 |
| mriedem | i'm not sure why we'd even have g-r then | 19:12 |
| sean-k-mooney | mriedem: i gues g-r keeps the minium for all pojects and nova requirments.txt has minium for nova | 19:12 |
| cdent | mriedem: upper constraints remains the one true thing, even without a globally sync requirements.txt, maybe? | 19:13 |
| mriedem | which means we could bump our minimum required version in nova for a library, but not care about bumping it in g-r | 19:13 |
| dansmith | we still have to be below u-c | 19:13 |
| sean-k-mooney | so if you dont deploy something that need the newer requirement you can still use version below g-r. that said our gate jobs always run with whatever is allowed by u-c | 19:13 |
| mriedem | u-c bumps are automated | 19:14 |
| mriedem | and merged in batches | 19:14 |
| openstackgerrit | Eric Young proposed openstack/nova master: Support extending attached ScaleIO volumes https://review.openstack.org/554679 | 19:14 |
| dansmith | my feeling is that we'll still have some things where you can't actually use nova at the version pinned by cinder for a given thing | 19:14 |
| mriedem | yeah. forget i asked. i need to find a hole to put my head. | 19:15 |
| * dansmith notes that mriedem is in an great mood following vacay | 19:15 | |
| mriedem | the foot of snow we got yesterday doesn't help | 19:15 |
| dansmith | better you than me | 19:16 |
| *** salv-orlando has joined #openstack-nova | 19:18 | |
| *** felipemonteiro_ has joined #openstack-nova | 19:18 | |
| kashyap | [nag] Since I'm awake at this random hour in front of the screen, might as well point out this if you are looking for something to +A: https://review.openstack.org/#/c/534384/ | 19:19 |
| kashyap | It already has a +2 | 19:19 |
| smcginnis | mriedem: I don't think g-r matters anymore and is probably going away at some point. | 19:20 |
| smcginnis | Things just need to be between lower-constraint and upper-constraint. | 19:20 |
| *** felipemonteiro has quit IRC | 19:21 | |
| sean-k-mooney | smcginnis: isnt g-r the lower-constraint | 19:21 |
| sean-k-mooney | smcginnis: or at least openstack wide lower-constraint | 19:22 |
| smcginnis | sean-k-mooney: No, there is a new lower-constraint.txt file. | 19:22 |
| smcginnis | sean-k-mooney: Well, I guess you could call that the new g-r. | 19:22 |
| smcginnis | It's slightly different though: https://github.com/openstack/requirements/blob/master/lower-constraints.txt | 19:23 |
| sean-k-mooney | smcginnis: oh ok is that updated automatically some how? just not sure what the delta is between it and g-r | 19:23 |
| sean-k-mooney | oh its expcitly === with no ranges | 19:23 |
| smcginnis | Right. It's saying "the minimum required is exactly this" rather than "it needs to be above this version, but not this one, etc." | 19:24 |
| sean-k-mooney | so in theroy we could use it to test with minium supported version | 19:24 |
| smcginnis | sean-k-mooney: Yep, I think that's the plan. | 19:24 |
| smcginnis | It's a bit of a long read, but Doug wrote out the whole plan here: http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html | 19:25 |
| *** jmlowe has quit IRC | 19:26 | |
| sean-k-mooney | smcginnis: oh good to know. i basically assume that since we only tested with what upperconstraties allowed that anything lower might work but not worth the heart ache of finding out | 19:26 |
| smcginnis | sean-k-mooney: Hah, yeah. And I think in a lot of cases, our lower bound didn't/doesn't accurately reflect what really is the minimum required. | 19:27 |
| smcginnis | This makes it plausible to have a test that can verify that. | 19:27 |
| sean-k-mooney | smcginnis: well the distros. esspcially centos et al would be happy with knowing that a minium is actully checked before they start intergrating | 19:28 |
| sean-k-mooney | ill give the ml post a read thanks | 19:28 |
| smcginnis | sean-k-mooney: Pour yourselve a nice cup of tea first - it will take a while. ;) | 19:28 |
| *** jmlowe has joined #openstack-nova | 19:29 | |
| *** efried_rollin is now known as efried | 19:29 | |
| *** armaan has quit IRC | 19:31 | |
| *** adriano_ has joined #openstack-nova | 19:34 | |
| *** armaan has joined #openstack-nova | 19:38 | |
| *** david-lyle has joined #openstack-nova | 19:42 | |
| *** felipemonteiro__ has joined #openstack-nova | 19:48 | |
| *** yassine has quit IRC | 19:49 | |
| *** felipemonteiro__ has quit IRC | 19:49 | |
| *** felipemonteiro__ has joined #openstack-nova | 19:49 | |
| *** tbachman has joined #openstack-nova | 19:51 | |
| *** felipemonteiro_ has quit IRC | 19:52 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt https://review.openstack.org/544238 | 19:52 |
| *** gouthamr has quit IRC | 19:52 | |
| *** felipemonteiro_ has joined #openstack-nova | 19:54 | |
| *** claudiub|2 has quit IRC | 19:54 | |
| *** armaan has quit IRC | 19:54 | |
| *** eharney has quit IRC | 19:56 | |
| *** felipemonteiro__ has quit IRC | 19:57 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Move test_report_client out of placement namespace https://review.openstack.org/558911 | 19:59 |
| *** yassine has joined #openstack-nova | 20:01 | |
| *** mvk has quit IRC | 20:01 | |
| *** burt has quit IRC | 20:02 | |
| *** esberglu has quit IRC | 20:03 | |
| *** burt has joined #openstack-nova | 20:04 | |
| *** yangyapeng has joined #openstack-nova | 20:05 | |
| *** esberglu_ has joined #openstack-nova | 20:08 | |
| *** jaypipes has quit IRC | 20:09 | |
| *** yangyapeng has quit IRC | 20:09 | |
| *** _ix has quit IRC | 20:15 | |
| *** liverpooler has quit IRC | 20:19 | |
| *** suresh12 has joined #openstack-nova | 20:19 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Fix incorrect exception import https://review.openstack.org/558916 | 20:20 |
| cdent | efried, mriedem, dansmith : that's ^ a fun little bug fix that would be nice to have | 20:20 |
| *** evin has quit IRC | 20:22 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add --enable and --disable options to nova-manage update_cell https://review.openstack.org/555416 | 20:24 |
| mriedem | cdent: we can't even have a simple unit test for that if gabbi won't cover it? | 20:24 |
| cdent | mriedem: we can have a unit test for it but it would be...very mocky | 20:25 |
| mriedem | that's fine, it's testing error handling | 20:25 |
| melwitt | yeah, I was about to ask that. I'm not seeing unit tests in the tree for the aggregate handler, guess there hasn't been need of one yet | 20:25 |
| cdent | melwitt, mriedem : as a general rule we haven't done unit tests for the handler code | 20:26 |
| melwitt | that is, gabbit tests cover most of it | 20:26 |
| melwitt | gabbi | 20:26 |
| mriedem | cdent: i know | 20:26 |
| mriedem | but... | 20:26 |
| mriedem | clearly there is a need for it in some cases | 20:26 |
| melwitt | aye | 20:26 |
| * cdent shrugs | 20:26 | |
| cdent | I'm not saying I'm agin it, just that it hasn't happened yet | 20:26 |
| mriedem | you can be a trailblazer here | 20:27 |
| *** lpetrut_ has quit IRC | 20:27 | |
| cdent | I was hoping to go to sleep instead | 20:27 |
| mriedem | blaze that treasure trail in the morning | 20:27 |
| mriedem | or lose sleep over it tonight :) | 20:27 |
| cdent | I will lose sleep over trying to generate caring | 20:28 |
| cdent | mriedem: so I can both think about it and not think about it, what is that you're hoping for here? | 20:29 |
| *** Sukhdev has joined #openstack-nova | 20:29 | |
| mriedem | i'm -1 without a unit test | 20:29 |
| mriedem | which can be dealt with whenever you feel like it i guess | 20:29 |
| cdent | a test that confirms that the handler raises a 409 when it seens a ConcurrentUpdate, or that a ConcurrentUpdate happens when there is an increment generation failure that casues a ConcurrentUpdate | 20:30 |
| mriedem | i'm fine with the former | 20:30 |
| mriedem | seems easy enough | 20:30 |
| cdent | one of the reasons we haven't done it in the past is because the answer to that ^ is unclear | 20:30 |
| *** sapd has quit IRC | 20:30 | |
| melwitt | +1 on the former | 20:30 |
| *** sapd has joined #openstack-nova | 20:30 | |
| mriedem | making sure we don't spew 500 out of the REST API is a simple enough thing to say is a good test | 20:30 |
| cdent | hmmm. Would that even have caught this particular problem? | 20:31 |
| *** yamamoto_ has quit IRC | 20:31 | |
| mriedem | the exception moved, | 20:31 |
| cdent | I suppose so, as the unit test itself would have had an import error when it tried to side effet | 20:31 |
| mriedem | so yes it should | 20:31 |
| melwitt | is ConcurrentUpdate a base nova exception too? | 20:31 |
| mriedem | no | 20:31 |
| cdent | not any more | 20:31 |
| mriedem | it moved | 20:31 |
| melwitt | okay, so you'd think it would blow up there | 20:31 |
| *** sapd has quit IRC | 20:31 | |
| *** sapd has joined #openstack-nova | 20:32 | |
| * cdent shrugs in resignation | 20:32 | |
| melwitt | my concern is just let's patch that test coverage gap since we know it's there. so if that path breaks in the future, we'll catch it. whether that happens now or in a follow up is fine IMHO but I think it's worth doing | 20:37 |
| *** suresh12 has quit IRC | 20:41 | |
| *** suresh12 has joined #openstack-nova | 20:42 | |
| *** Nil_ has quit IRC | 20:42 | |
| cdent | I get the concern, my reluctance is mostly because we've done a good job of avoid mock madness in the tests associated with placement | 20:43 |
| openstackgerrit | Merged openstack/nova master: network: add command to configure trusted mode for VFs https://review.openstack.org/458513 | 20:43 |
| cdent | I even added https://review.openstack.org/#/c/557355/ | 20:44 |
| *** vladikr has quit IRC | 20:46 | |
| melwitt | yeah, I understand. I do really like the gabbi testing of the placement APIs. I'm just not immediately seeing another way to cover this particular testing gap | 20:48 |
| openstackgerrit | Tyler Blakeslee proposed openstack/nova master: Add __repr__ for NovaException https://review.openstack.org/555812 | 20:49 |
| *** yassine has quit IRC | 20:49 | |
| *** edmondsw has quit IRC | 20:50 | |
| *** Nil_ has joined #openstack-nova | 20:52 | |
| *** yassine has joined #openstack-nova | 20:57 | |
| *** rcernin has joined #openstack-nova | 20:59 | |
| *** vladikr has joined #openstack-nova | 21:00 | |
| dansmith | mriedem: melwitt cells meeting? | 21:01 |
| mriedem | oh yeah | 21:03 |
| *** Sukhdev has quit IRC | 21:04 | |
| *** idlemind has joined #openstack-nova | 21:04 | |
| *** r-daneel has quit IRC | 21:06 | |
| cdent | efried: on https://review.openstack.org/#/c/548249/ do you remember why you are catching DBDuplicateError around set_aggregates? | 21:09 |
| efried | ... | 21:10 |
| *** pchavva has quit IRC | 21:10 | |
| *** mrjk has joined #openstack-nova | 21:10 | |
| cdent | efried: s/Error/Entry. That exception is handled in set_aggregates but with a pass, so I'm wondering if there's something else. it's not clear | 21:11 |
| efried | cdent: Because Jay via https://review.openstack.org/#/c/548249/6/nova/api/openstack/placement/handlers/aggregate.py@100 pointed me to https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handlers/inventory.py#L171-L174 which I copy/pasted. | 21:12 |
| * cdent reads | 21:12 | |
| *** tbachman has quit IRC | 21:13 | |
| cdent | hrmm | 21:13 |
| efried | cdent: Looking through a little bit, it's possible it's not necessary. | 21:14 |
| cdent | will leave a NOTE next to it for the time being | 21:14 |
| efried | ight. | 21:15 |
| *** yamahata has quit IRC | 21:19 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova-status check for ironic flavor migration https://review.openstack.org/527541 | 21:23 |
| *** jaypipes has joined #openstack-nova | 21:25 | |
| *** mvk has joined #openstack-nova | 21:27 | |
| *** yamamoto has joined #openstack-nova | 21:28 | |
| *** rcernin has quit IRC | 21:29 | |
| *** jaypipes has quit IRC | 21:30 | |
| *** yamamoto has quit IRC | 21:33 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Fix incorrect exception import https://review.openstack.org/558916 | 21:34 |
| cdent | that version adds a unit test, but does it by extracting the problematic code to its own method (as suggested by https://docs.openstack.org/nova/latest/contributor/placement.html#testing ) | 21:35 |
| *** bhagyashri_s has joined #openstack-nova | 21:40 | |
| *** voelzmo_ has joined #openstack-nova | 21:42 | |
| mriedem | melwitt: i've got a question in https://review.openstack.org/#/c/540258/ | 21:42 |
| mriedem | you and dan might have already covered that months ago though | 21:42 |
| *** bhagyashris has quit IRC | 21:43 | |
| *** jmlowe has quit IRC | 21:44 | |
| *** voelzmo has quit IRC | 21:46 | |
| mriedem | so for initial scheduling, it seems necessary to hit all cells since we don't know which one the scheduler is going to pick for the instances in the create request, but for operations on an existing instance, it seems we should only need to care about hosts that are in the same cell as the instance, since we don't support move operations across cells | 21:46 |
| *** voelzmo_ has quit IRC | 21:47 | |
| *** voelzmo has joined #openstack-nova | 21:47 | |
| *** yamahata has joined #openstack-nova | 21:50 | |
| *** voelzmo has quit IRC | 21:52 | |
| *** yangyapeng has joined #openstack-nova | 21:53 | |
| *** tbachman has joined #openstack-nova | 21:54 | |
| *** takashin has joined #openstack-nova | 21:55 | |
| *** esberglu_ has quit IRC | 21:57 | |
| *** yangyapeng has quit IRC | 21:58 | |
| *** AlexeyAbashkin has joined #openstack-nova | 21:59 | |
| *** suresh12 has quit IRC | 22:03 | |
| *** suresh12 has joined #openstack-nova | 22:03 | |
| *** cdent has quit IRC | 22:03 | |
| *** voelzmo has joined #openstack-nova | 22:04 | |
| *** voelzmo has quit IRC | 22:04 | |
| *** AlexeyAbashkin has quit IRC | 22:04 | |
| *** voelzmo has joined #openstack-nova | 22:05 | |
| *** voelzmo_ has joined #openstack-nova | 22:07 | |
| *** voelzmo has quit IRC | 22:07 | |
| *** suresh12 has quit IRC | 22:08 | |
| *** suresh12 has joined #openstack-nova | 22:10 | |
| *** suresh12 has quit IRC | 22:11 | |
| *** voelzmo_ has quit IRC | 22:11 | |
| *** suresh12 has joined #openstack-nova | 22:12 | |
| *** suresh12 has quit IRC | 22:16 | |
| *** lbragstad has quit IRC | 22:18 | |
| *** mlavalle has quit IRC | 22:20 | |
| *** felipemonteiro_ has quit IRC | 22:21 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947 | 22:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333 | 22:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334 | 22:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371 | 22:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Port binding based on events during live migration https://review.openstack.org/434870 | 22:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | 22:23 |
| melwitt | mriedem: thanks, looking. it's true that at present we don't support migrate across cells and we restrict it via request_spec.requested_destination.cell in the conductor task. someday when we do migrate across cells, we'll not want to restrict it | 22:24 |
| *** suresh12 has joined #openstack-nova | 22:25 | |
| melwitt | I'm trying to see if similar could be done with the instance group hosts query, if we can rely on request_spec.requested_destination.cell to limit it and put a NOTE on it that will remind us to remove that along with the others if we get cross-cell migration down the road | 22:27 |
| melwitt | checking if task.execute happens before or after the setup_instance_group call | 22:28 |
| *** sdague has quit IRC | 22:29 | |
| *** yamamoto has joined #openstack-nova | 22:30 | |
| melwitt | oh, it's _in_ execute. so yeah looks like we could read requested_destination.cell to know to limit it | 22:32 |
| melwitt | for live migrate we'd have to move the setup_instance_group call down after the requested cell is set | 22:34 |
| *** munimeha1 has quit IRC | 22:35 | |
| mriedem | efried: edleafe: fyi https://review.openstack.org/#/c/556529/ | 22:35 |
| *** yamamoto has quit IRC | 22:36 | |
| mriedem | melwitt: so you mean from within the InstanceGroup.get_hosts() call, determine that you have a requested_destination.cell set and use it for the targeted context when doing InstanceList.get_by_filters? | 22:36 |
| mriedem | or whatever the instance query method is, | 22:36 |
| *** tssurya has quit IRC | 22:37 | |
| mriedem | you could do that, but you still have setup_instance_group doing a scatter/gather on the cells, so it would likely be redundant | 22:37 |
| melwitt | mriedem: I was thinking in the setup_instance_group method, choose whether to scatter-gather based on whether request_spec.requested_destination.cell is set. (after making sure the setup_instance_group calls are moved until after .cell is set) | 22:39 |
| *** voelzmo has joined #openstack-nova | 22:41 | |
| mriedem | ah | 22:42 |
| mriedem | yeah that might do it | 22:42 |
| *** awaugama has quit IRC | 22:43 | |
| mriedem | one problem is InstanceGroup.get_hosts() doesn't take a context | 22:43 |
| mriedem | but, | 22:43 |
| mriedem | you could temporarily mutate it's _context to be the cell-targeted one from the RequestSpec | 22:44 |
| mriedem | well... | 22:44 |
| mriedem | that's not how this is called, it happens via reqspec.instance_group.hosts | 22:44 |
| mriedem | suppose we don't need to mess with the objects at all, just control it in _get_instance_group_hosts_all_cells | 22:45 |
| *** rcernin has joined #openstack-nova | 22:45 | |
| melwitt | maybe safest to target_cell(context, requested_destination.cell) as cctxt then obj_alternate_context(cctxt) or something | 22:46 |
| mriedem | yeah that's probably cleanest | 22:46 |
| *** _ix has joined #openstack-nova | 22:47 | |
| mriedem | anywho, before you go changing anything, would probably also be good to run it by dan in the morrow in case i'm missing something with this | 22:47 |
| melwitt | unless what you were saying earlier is that the context in setup_instance_group(context, request_spec) is already targeted | 22:47 |
| melwitt | k, will do | 22:47 |
| mriedem | i believe it is | 22:47 |
| mriedem | in the move cases | 22:47 |
| mriedem | so the regression i think you're trying to fix is for server create, | 22:48 |
| openstackgerrit | Merged openstack/nova master: Noauth should also use request_id from compute_req_id.py https://review.openstack.org/555266 | 22:48 |
| mriedem | but i'm not sure it's broken for move operations | 22:48 |
| mriedem | kind of hard to tell without functional regression tests | 22:48 |
| melwitt | yeah | 22:49 |
| mriedem | i think all of those move operations use the @targets_cell decorator in conductor manager | 22:49 |
| mriedem | well before we get to setup_instance_group | 22:49 |
| melwitt | I see | 22:49 |
| *** mriedem is now known as mriedem_away | 22:51 | |
| *** tbachman has quit IRC | 22:51 | |
| *** _ix_ has joined #openstack-nova | 22:52 | |
| *** _ix has quit IRC | 22:52 | |
| *** tssurya has joined #openstack-nova | 22:52 | |
| *** mrjk_ has joined #openstack-nova | 22:53 | |
| *** mrjk has quit IRC | 22:55 | |
| *** ssurana has joined #openstack-nova | 22:56 | |
| *** tssurya has quit IRC | 22:57 | |
| *** felipemonteiro has joined #openstack-nova | 23:00 | |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add columns for generation to consumers https://review.openstack.org/557958 | 23:05 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add handlers for consumer_generation https://review.openstack.org/557959 | 23:05 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - Add a microversion for consumer generation https://review.openstack.org/558958 | 23:05 |
| *** hongbin_ has quit IRC | 23:06 | |
| *** mrjk_ has quit IRC | 23:10 | |
| *** suresh12 has quit IRC | 23:14 | |
| *** voelzmo has quit IRC | 23:14 | |
| *** suresh12 has joined #openstack-nova | 23:15 | |
| *** _ix has joined #openstack-nova | 23:16 | |
| *** _ix_ has quit IRC | 23:18 | |
| *** suresh12 has quit IRC | 23:20 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | 23:22 |
| *** suresh12 has joined #openstack-nova | 23:23 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483 | 23:23 |
| *** tbachman has joined #openstack-nova | 23:25 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | 23:25 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform aggregate.update_metadata notification https://review.openstack.org/460625 | 23:25 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Change a validation in creating a server group https://review.openstack.org/546484 | 23:26 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller https://review.openstack.org/347289 | 23:26 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers.inc (2/3) https://review.openstack.org/550648 | 23:28 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers.inc (3/3) https://review.openstack.org/550659 | 23:28 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameter order in rebuild https://review.openstack.org/529718 | 23:29 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Example verification for servers.inc https://review.openstack.org/529520 | 23:29 |
| *** chyka has quit IRC | 23:30 | |
| *** edleafe- has joined #openstack-nova | 23:31 | |
| *** yamamoto has joined #openstack-nova | 23:32 | |
| *** edleafe has quit IRC | 23:33 | |
| *** edleafe- is now known as edleafe | 23:33 | |
| *** yamamoto has quit IRC | 23:38 | |
| *** yamahata has quit IRC | 23:42 | |
| *** amodi has quit IRC | 23:42 | |
| *** Zames has joined #openstack-nova | 23:51 | |
| *** Zames has quit IRC | 23:57 | |
| *** _ix_ has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!