Friday, 2018-04-13

*** moetunes0B2646 has joined #openstack-nova00:00
*** salv-orlando has joined #openstack-nova00:01
*** dillaman has quit IRC00:01
*** hamzy_ has joined #openstack-nova00:02
*** itlinux has quit IRC00:03
*** fragatina has quit IRC00:04
*** fragatina has joined #openstack-nova00:05
*** liverpooler has joined #openstack-nova00:06
*** salv-orlando has quit IRC00:06
*** itlinux has joined #openstack-nova00:06
*** liverpooler has quit IRC00:07
melwittmriedem_afk: alright, thanks00:08
*** hamzy has joined #openstack-nova00:08
*** fragatina has quit IRC00:09
*** gyee has quit IRC00:10
*** hamzy_ has quit IRC00:10
*** Sukhdev has quit IRC00:10
*** moetunes0B2646 has quit IRC00:12
*** didelspk has quit IRC00:15
*** r-daneel has quit IRC00:21
*** stakeda has joined #openstack-nova00:33
*** _ix has joined #openstack-nova00:36
*** felipemonteiro_ has quit IRC00:38
*** liuzz_ has quit IRC00:39
*** liuzz has joined #openstack-nova00:40
*** itlinux has quit IRC00:41
*** yingjun has joined #openstack-nova00:42
*** hshiina has joined #openstack-nova00:45
*** itlinux has joined #openstack-nova00:46
*** jichen has joined #openstack-nova00:48
*** harlowja has quit IRC00:52
*** hoangcx has joined #openstack-nova00:56
*** yangyape_ has quit IRC00:57
*** itlinux has quit IRC00:58
*** _ix has quit IRC00:59
*** gouthamr has quit IRC00:59
*** phuongnh has joined #openstack-nova01:02
*** salv-orlando has joined #openstack-nova01:02
*** artom has joined #openstack-nova01:04
*** hongbin has joined #openstack-nova01:05
*** gouthamr has joined #openstack-nova01:05
openstackgerritMerged openstack/nova master: Move get_stashed_volume_connector to compute.utils  https://review.openstack.org/55781001:05
*** salv-orlando has quit IRC01:06
*** itlinux has joined #openstack-nova01:08
*** tiendc has joined #openstack-nova01:10
*** itlinux has quit IRC01:10
*** zhaochao has joined #openstack-nova01:13
openstackgerritMerged openstack/nova master: ProviderTree.{add|remove}_{traits|aggregates}  https://review.openstack.org/55347501:14
*** moshele has joined #openstack-nova01:14
*** caisan has joined #openstack-nova01:15
*** hemna_ has quit IRC01:16
*** moshele has quit IRC01:16
*** wolverineav has quit IRC01:17
*** wolverineav has joined #openstack-nova01:17
*** itlinux has joined #openstack-nova01:20
*** wolverineav has quit IRC01:21
*** chenyb4 has joined #openstack-nova01:27
*** r-daneel has joined #openstack-nova01:29
*** phuongnh has quit IRC01:33
*** yangyapeng has joined #openstack-nova01:33
*** phuongnh has joined #openstack-nova01:33
*** yamahata has quit IRC01:35
*** itlinux has quit IRC01:35
*** gouthamr_ has joined #openstack-nova01:37
*** gouthamr has quit IRC01:37
*** gouthamr_ is now known as gouthamr01:37
*** yangyapeng has quit IRC01:39
*** yingjun has quit IRC01:43
*** swamireddy has joined #openstack-nova01:43
*** mriedem_afk has quit IRC01:50
*** yingjun has joined #openstack-nova01:55
*** ssurana has quit IRC01:55
*** yangyapeng has joined #openstack-nova01:56
*** yangyapeng has quit IRC01:58
*** phuongnh has quit IRC02:02
*** salv-orlando has joined #openstack-nova02:02
*** gjayavelu has quit IRC02:06
*** salv-orlando has quit IRC02:07
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in test_serversV21.py (2)  https://review.openstack.org/56082902:10
*** gaoyan has joined #openstack-nova02:13
*** phuongnh has joined #openstack-nova02:16
*** phuongnh has quit IRC02:21
*** phuongnh has joined #openstack-nova02:22
*** Spaz-Work has quit IRC02:25
*** Spazmotic has joined #openstack-nova02:25
*** armaan has quit IRC02:25
*** armaan has joined #openstack-nova02:26
*** READ10 has quit IRC02:29
*** gongysh has joined #openstack-nova02:30
*** germs has quit IRC02:34
*** germs has joined #openstack-nova02:35
*** germs has quit IRC02:35
*** germs has joined #openstack-nova02:35
*** vivsoni has joined #openstack-nova02:41
*** xinliang has quit IRC02:47
*** nicolasbock has quit IRC02:47
*** xinliang has joined #openstack-nova02:58
openstackgerritMerged openstack/nova master: Remove mox in test_neutron_security_groups.py  https://review.openstack.org/56026703:01
openstackgerritJackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API  https://review.openstack.org/48620403:02
*** salv-orlando has joined #openstack-nova03:03
*** psachin has joined #openstack-nova03:04
*** dave-mccowan has quit IRC03:05
*** salv-orlando has quit IRC03:07
*** imacdonn has quit IRC03:09
*** imacdonn has joined #openstack-nova03:09
*** Tom-Tom has joined #openstack-nova03:10
openstackgerritjichenjc proposed openstack/nova master: Add config drive link to api-guide  https://review.openstack.org/56111303:13
*** fragatina has joined #openstack-nova03:16
*** fragatina has quit IRC03:17
*** fragatina has joined #openstack-nova03:17
*** sdeath has joined #openstack-nova03:19
openstackgerritjichenjc proposed openstack/nova master: Update link of metadata  https://review.openstack.org/56111403:21
*** annp has joined #openstack-nova03:21
*** sree has joined #openstack-nova03:25
*** sree has quit IRC03:26
phuongnhhi all, I would like to add one more line in file https://review.openstack.org/#/c/462759/3/os_traits/hw/cpu/x86.py for CPU_FPGA03:33
phuongnh the link to this is: https://en.wikipedia.org/wiki/Field-programmable_gate_array03:33
phuongnhDo I need to propose a blueprint in launchpad?03:33
*** yingjun has quit IRC03:39
*** otih_T89NZ8 has joined #openstack-nova03:40
*** fragatina has quit IRC03:42
*** sree has joined #openstack-nova03:45
*** otih_T89NZ8 has quit IRC03:47
*** gaoyan has quit IRC03:48
*** itlinux has joined #openstack-nova03:49
*** sidx64 has joined #openstack-nova03:50
*** gaoyan has joined #openstack-nova03:51
*** caisan has quit IRC03:57
*** aqScotteh has joined #openstack-nova03:57
*** aqScotteh has quit IRC03:59
*** gjayavelu has joined #openstack-nova03:59
*** udesale has joined #openstack-nova04:01
*** liusheng has quit IRC04:01
*** liusheng has joined #openstack-nova04:01
openstackgerritNguyen Hung Phuong proposed openstack/os-traits master: [WIP] add fpga cpu for the future  https://review.openstack.org/56111704:02
*** salv-orlando has joined #openstack-nova04:04
sapd_Hi guys, I want to pass volume_type to block_device_mapping_v2, I saw this specs: https://review.openstack.org/#/c/362698/5/specs/ocata/approved/add-volume-type-when-boot-instances.rst , but have it implemented yet?04:07
*** salv-orlando has quit IRC04:08
*** gouthamr_ has joined #openstack-nova04:09
*** sapd has joined #openstack-nova04:10
*** hongbin has quit IRC04:11
*** gouthamr has quit IRC04:11
*** gouthamr_ is now known as gouthamr04:12
*** gouthamr_ has joined #openstack-nova04:12
*** rajinir has quit IRC04:14
*** gouthamr has quit IRC04:20
*** gouthamr_ has quit IRC04:20
*** gouthamr has joined #openstack-nova04:21
*** blkart has quit IRC04:23
*** itlinux has quit IRC04:23
*** namnh has joined #openstack-nova04:24
*** yamahata has joined #openstack-nova04:24
*** lbragstad has joined #openstack-nova04:26
*** lbragstad has quit IRC04:28
*** gongysh has quit IRC04:30
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: WIP: complex policy  https://review.openstack.org/55377604:32
*** gongysh has joined #openstack-nova04:37
*** ssurana has joined #openstack-nova04:41
*** gaoyan has quit IRC04:41
*** gongysh has quit IRC04:42
*** harlowja has joined #openstack-nova04:44
*** sapd has quit IRC04:44
*** abhishekk has joined #openstack-nova04:45
*** diga has joined #openstack-nova04:46
*** sapd has joined #openstack-nova04:47
openstackgerritTakashi NATSUME proposed openstack/nova master: Partially revert "Remove mox in unit/virt/xenapi/test_vm_utils.py (3)"  https://review.openstack.org/56112104:47
*** ssurana has quit IRC04:50
*** caisan has joined #openstack-nova04:50
openstackgerritjichenjc proposed openstack/nova master: [libvirt] Avoid create swap definition in xml  https://review.openstack.org/56112204:51
*** liuzz_ has joined #openstack-nova04:56
*** liuzz has quit IRC04:59
*** andreas_s has joined #openstack-nova05:01
*** salv-orlando has joined #openstack-nova05:05
*** andreas_s has quit IRC05:06
*** caisan has quit IRC05:06
*** salv-orlando has quit IRC05:09
*** links has joined #openstack-nova05:12
*** lpetrut has joined #openstack-nova05:12
openstackgerritMerged openstack/nova master: Move xenapi disk resizing to privsep.  https://review.openstack.org/55224205:14
*** ratailor has joined #openstack-nova05:15
*** salv-orlando has joined #openstack-nova05:17
*** sridharg has joined #openstack-nova05:24
*** gongysh has joined #openstack-nova05:26
*** mordred has quit IRC05:29
*** harlowja has quit IRC05:39
*** gaoyan has joined #openstack-nova05:39
*** mordred has joined #openstack-nova05:41
*** sidx64 has quit IRC05:42
*** fragatina has joined #openstack-nova05:44
*** sapd has quit IRC05:45
*** caisan has joined #openstack-nova05:48
*** andreas_s has joined #openstack-nova05:48
*** andreas_s has quit IRC05:48
*** andreas_s has joined #openstack-nova05:48
*** claudiub|2 has joined #openstack-nova05:48
*** sidx64 has joined #openstack-nova05:49
gmannsapd_: this is not implemented and idea is not to implement. you can check the details in that spec05:53
*** lajoskatona has joined #openstack-nova05:54
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2)  https://review.openstack.org/43060805:57
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2)  https://review.openstack.org/45948305:58
*** lpetrut has quit IRC06:03
*** gjayavelu has quit IRC06:04
*** gjayavelu has joined #openstack-nova06:05
*** gongysh has quit IRC06:14
*** armaan has quit IRC06:14
*** armaan has joined #openstack-nova06:14
*** stvnoyes has joined #openstack-nova06:15
*** gjayavelu has quit IRC06:16
*** stvnoyes1 has quit IRC06:17
*** sahid has joined #openstack-nova06:17
*** evin has joined #openstack-nova06:18
*** do3meli has joined #openstack-nova06:19
openstackgerritMerged openstack/nova master: Get rid of 406 paths in report client  https://review.openstack.org/55663306:19
*** ssurana has joined #openstack-nova06:20
*** sambetts_ is now known as sambetts06:21
*** jaosorior has joined #openstack-nova06:21
*** hshiina2 has joined #openstack-nova06:29
*** hshiina has quit IRC06:32
*** phuongnh has quit IRC06:32
*** phuongnh has joined #openstack-nova06:33
*** liuzz has joined #openstack-nova06:35
*** AlexeyAbashkin has joined #openstack-nova06:37
*** liuzz_ has quit IRC06:37
alex_xujohnthetubaguy_: here is something about policy, want to hear your idea https://review.openstack.org/#/c/554159/06:38
*** yikun_ has joined #openstack-nova06:39
*** yikun has quit IRC06:39
*** evin has quit IRC06:43
*** gongysh has joined #openstack-nova06:43
*** phuongnh has quit IRC06:45
*** mdnadeem has joined #openstack-nova06:47
*** phuongnh has joined #openstack-nova06:47
*** janki has joined #openstack-nova06:49
openstackgerritTetsuro Nakamura proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs  https://review.openstack.org/51960106:52
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support relay RP for allocation candidates  https://review.openstack.org/53343706:52
*** evin has joined #openstack-nova06:53
*** slaweq has joined #openstack-nova06:54
*** tetsuro has joined #openstack-nova06:54
*** ygl has joined #openstack-nova06:55
*** phuongnh has quit IRC06:57
*** AlexeyAbashkin has quit IRC06:58
*** tetsuro has left #openstack-nova07:00
*** tetsuro has joined #openstack-nova07:01
*** phuongnh has joined #openstack-nova07:01
*** armaan has quit IRC07:01
*** armaan has joined #openstack-nova07:02
tetsuro^ rebased to avoid merge conflict and to let them be independent from return-all-resources stuff.07:02
*** jchhatbar has joined #openstack-nova07:09
*** hshiina2 has quit IRC07:10
*** janki has quit IRC07:12
*** sidx64 has quit IRC07:14
openstackgerritsahid proposed openstack/nova master: libvirt: move version to string in utils  https://review.openstack.org/56045507:16
openstackgerritsahid proposed openstack/nova master: libvirt: refactor get_base_config to accept host arg  https://review.openstack.org/56045607:16
openstackgerritsahid proposed openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes  https://review.openstack.org/48499707:16
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/api/openstack/compute/test_hosts.py  https://review.openstack.org/55926607:17
*** tesseract has joined #openstack-nova07:17
*** alexchadin has joined #openstack-nova07:19
*** sidx64 has joined #openstack-nova07:21
*** ttsiouts has quit IRC07:22
*** ttsiouts has joined #openstack-nova07:23
*** bingqianglin has joined #openstack-nova07:24
*** rcernin has quit IRC07:33
*** namnh_ has joined #openstack-nova07:33
*** dpawlik has joined #openstack-nova07:34
*** namnh has quit IRC07:35
*** damien_r has joined #openstack-nova07:35
*** mdnadeem has quit IRC07:36
*** amoralej|off is now known as amoralej07:40
*** AlexeyAbashkin has joined #openstack-nova07:41
*** lajoskatona has quit IRC07:41
*** lpetrut has joined #openstack-nova07:41
*** ygl has left #openstack-nova07:41
*** gcb has joined #openstack-nova07:43
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration  https://review.openstack.org/55415407:46
*** AlexeyAbashkin has quit IRC07:46
*** bingqianglin has quit IRC07:47
*** bingqianglin has joined #openstack-nova07:48
*** jpena|off is now known as jpena07:49
*** lpetrut has quit IRC07:51
*** namnh_ has quit IRC07:53
*** lajoskatona has joined #openstack-nova07:57
*** sree_ has joined #openstack-nova08:01
*** sree_ is now known as Guest2586608:01
*** sree has quit IRC08:03
openstackgerritSurya Seetharaman proposed openstack/nova master: Cleanup patch for the cell-disable series  https://review.openstack.org/55929908:04
*** hshiina has joined #openstack-nova08:07
*** armaan has quit IRC08:07
*** armaan has joined #openstack-nova08:07
openstackgerritjichenjc proposed openstack/nova master: Add config drive link to api-guide  https://review.openstack.org/56111308:07
*** tssurya has joined #openstack-nova08:09
*** mgoddard has joined #openstack-nova08:09
*** gcb has quit IRC08:11
*** kalyan has quit IRC08:12
*** alexchad_ has joined #openstack-nova08:15
*** ktibi has joined #openstack-nova08:16
*** gcb has joined #openstack-nova08:17
*** lucas-afk is now known as lucasagomes08:17
*** alexchadin has quit IRC08:18
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration  https://review.openstack.org/55415408:19
*** gcb has quit IRC08:21
*** evin has quit IRC08:23
*** ktibi_ has joined #openstack-nova08:23
*** ktibi_ has quit IRC08:23
*** lajoskatona has quit IRC08:23
*** ktibi_ has joined #openstack-nova08:24
*** Zames has joined #openstack-nova08:25
*** QianYu has joined #openstack-nova08:26
*** ktibi has quit IRC08:26
*** Zames has quit IRC08:27
*** gcb has joined #openstack-nova08:28
*** lpetrut has joined #openstack-nova08:28
*** yamamoto has quit IRC08:33
*** moshele has joined #openstack-nova08:34
*** derekh has joined #openstack-nova08:41
*** gcb has quit IRC08:44
*** yamamoto has joined #openstack-nova08:44
*** gcb has joined #openstack-nova08:48
*** yamamoto has quit IRC08:51
*** moshele has quit IRC08:53
*** lpetrut has quit IRC08:54
openstackgerritjichenjc proposed openstack/nova master: Move update_task_state out of try/except  https://review.openstack.org/55715208:55
*** sar has joined #openstack-nova08:57
*** mdbooth has joined #openstack-nova08:59
*** alexchad_ has quit IRC09:00
*** elmaciej has joined #openstack-nova09:02
*** gcb has quit IRC09:02
*** gcb has joined #openstack-nova09:03
openstackgerritZhenyu Zheng proposed openstack/nova-specs master: Amend allow abort live migrations in queued status spec  https://review.openstack.org/56087209:03
*** tetsuro has left #openstack-nova09:04
openstackgerritLee Yarwood proposed openstack/nova stable/ocata: libvirt: Allow to specify granular CPU feature flags  https://review.openstack.org/56116809:05
*** QianYu is now known as Roger_09:06
kashyaplyarwood: Hmm, forgot for Ocata; thanks :-009:07
lyarwoodkashyap: np09:07
*** ktibi_ is now known as ktibi09:07
kashyaplyarwood: I actually thought about it; but given where Ocata is, thought upstream would reject it anyway09:08
kashyapBut this is a special circumstance, though09:08
lyarwoodkashyap: yeah and we have recently changed stable policy FWIW so this is valid09:09
*** jogo has quit IRC09:10
kashyaplyarwood: Got a link to the policy?09:10
*** hshiina has quit IRC09:11
lyarwoodkashyap: https://docs.openstack.org/project-team-guide/stable-branches.html09:11
kashyapThanks.09:12
*** pcaruana has joined #openstack-nova09:12
*** ralonsoh has joined #openstack-nova09:14
*** jogo has joined #openstack-nova09:14
*** sdague has joined #openstack-nova09:14
openstackgerritZhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 7  https://review.openstack.org/56074809:14
*** liusheng has quit IRC09:18
*** liusheng has joined #openstack-nova09:18
openstackgerritJianghua Wang proposed openstack/nova master: XenAPI: deprecate the config for image handler class path  https://review.openstack.org/49720109:25
*** sridharg has quit IRC09:29
*** udesale_ has joined #openstack-nova09:30
*** gcb has quit IRC09:31
*** ssurana has quit IRC09:31
*** liuzz has quit IRC09:32
takashinCore reviwers, would you review https://review.openstack.org/#/c/561121/ ?  It is a temporaly fix for gate failure ( https://bugs.launchpad.net/nova/+bug/1763535 ) .09:33
openstackLaunchpad bug 1763535 in OpenStack Compute (nova) "nova.tests.unit.virt.xenapi.test_vm_utils.StreamDiskTestCase.test_non_ami intermittently fails" [High,Confirmed]09:33
*** udesale has quit IRC09:33
stephenfintakashin: You've no idea what's causing that, I assume?09:36
takashinstephenfin: I have no ideas.09:37
takashinstephenfin: I could not reproduce failure in my local environment.09:37
sapd_gmann: I think this is a important feature when want to create instance use volume based instead of create volume after launch instance09:37
*** mdbooth has quit IRC09:37
*** mdbooth has joined #openstack-nova09:38
*** sridharg has joined #openstack-nova09:38
*** tojuvone has quit IRC09:38
stephenfintakashin: I'm guessing there's some kind of race going on. Let me see if I can reproduce quickly09:38
takashinstephenfin: Thank you.09:39
sahidstephenfin: can you re-ACK 2 first patches here: https://review.openstack.org/#/c/560455/?09:41
sahidthey lost the bit because of a rebase09:41
openstackgerritZhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 7  https://review.openstack.org/56074809:43
*** xinliang has quit IRC09:45
*** gcb has joined #openstack-nova09:45
*** takashin has left #openstack-nova09:46
*** Tom-Tom has quit IRC09:49
*** armaan has quit IRC09:55
*** xinliang has joined #openstack-nova09:57
*** xinliang has quit IRC09:57
*** xinliang has joined #openstack-nova09:57
*** elmaciej has quit IRC09:59
*** _ix has joined #openstack-nova09:59
*** elmaciej has joined #openstack-nova10:00
*** Roger_ has quit IRC10:00
*** elmaciej_ has joined #openstack-nova10:03
*** _ix_ has joined #openstack-nova10:04
*** _ix has quit IRC10:05
*** elmaciej has quit IRC10:05
*** gaoyan has quit IRC10:05
*** jichen has quit IRC10:11
*** Guest25866 has quit IRC10:12
*** sree has joined #openstack-nova10:12
*** hoangcx has quit IRC10:13
*** phuongnh has quit IRC10:14
*** sree has quit IRC10:16
*** caisan has quit IRC10:17
*** elmaciej_ has quit IRC10:17
*** elmaciej has joined #openstack-nova10:19
*** gongysh has quit IRC10:23
*** lpetrut has joined #openstack-nova10:27
*** annp has quit IRC10:29
*** nicolasbock has joined #openstack-nova10:31
*** chenyb4 has quit IRC10:36
*** bingqianglin has quit IRC10:38
openstackgerritStephen Finucane proposed openstack/nova master: tests: Fix how context managers are mocked  https://review.openstack.org/56119010:39
stephenfintakashin: That should do the trick ^10:39
openstackgerritMerged openstack/nova master: only increment disk address unit for scsi devices  https://review.openstack.org/53831010:42
*** udesale__ has joined #openstack-nova10:42
*** diga has quit IRC10:43
*** _ix_ has quit IRC10:44
*** oanson has quit IRC10:44
*** udesale_ has quit IRC10:45
openstackgerritMerged openstack/nova master: trivial: fix a comment typo  https://review.openstack.org/56034910:47
kashyapI wonder if Gerrit can be tweaked to retain the +2 post-rebase10:49
kashyap(Post-successful rebase)10:49
odyssey4mekashyap it already does, assuming the only thing changing in the rebase is the parent commit and date/time10:50
*** _ix has joined #openstack-nova10:50
kashyaplyarwood: Seems like 'pep8' failures on that Ocata backport; will look post meetings10:51
kashyapodyssey4me: Ah, I meant +W10:51
lyarwoodkashyap: yeah sorting it out now10:51
odyssey4meah no, workflow is lost10:51
*** xinliang has quit IRC10:51
*** stakeda has quit IRC10:52
*** cdent has joined #openstack-nova10:52
openstackgerritLee Yarwood proposed openstack/nova stable/ocata: libvirt: Allow to specify granular CPU feature flags  https://review.openstack.org/56116810:57
lyarwoodkashyap: ^ just a missing _LW10:57
*** alexchadin has joined #openstack-nova10:58
kashyaplyarwood: Ah-ha; /me quickly takes a peek10:58
*** abhishekk has quit IRC10:58
*** rodolof has joined #openstack-nova11:02
*** lpetrut has quit IRC11:04
*** xinliang has joined #openstack-nova11:05
*** bhagyashris has quit IRC11:05
*** pooja_jadhav has quit IRC11:05
*** Shilpa has quit IRC11:05
*** pooja_jadhav has joined #openstack-nova11:06
*** Shilpa has joined #openstack-nova11:06
*** bhagyashris has joined #openstack-nova11:06
*** tiendc has quit IRC11:07
openstackgerritsahid proposed openstack/nova stable/queens: only increment disk address unit for scsi devices  https://review.openstack.org/56119611:08
*** ccamacho is now known as ccamacho|hungy11:10
*** dave-mccowan has joined #openstack-nova11:17
*** armaan has joined #openstack-nova11:17
*** vivsoni has quit IRC11:19
*** rodolof has quit IRC11:24
*** rodolof has joined #openstack-nova11:25
*** lucasagomes is now known as lucas-hungry11:27
*** udesale_ has joined #openstack-nova11:30
*** damien_r has quit IRC11:30
*** udesale__ has quit IRC11:32
*** cdent has quit IRC11:33
*** udesale_ has quit IRC11:35
*** lpetrut has joined #openstack-nova11:40
*** jpena is now known as jpena|lunch11:41
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Record the host info in EventReporter  https://review.openstack.org/55674611:47
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Extract generate_hostid method into utils.py  https://review.openstack.org/55528211:47
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add host/hostId to instance action events API  https://review.openstack.org/55714511:47
*** sar has quit IRC11:47
*** damien_r has joined #openstack-nova11:48
*** salv-orlando has quit IRC11:48
*** salv-orlando has joined #openstack-nova11:49
*** aloga has quit IRC11:49
*** aloga has joined #openstack-nova11:50
*** salv-orlando has quit IRC11:53
*** bhujay has joined #openstack-nova11:53
*** Roger_ has joined #openstack-nova11:55
*** armaan has quit IRC11:57
*** sar has joined #openstack-nova11:58
*** armaan has joined #openstack-nova11:59
*** Roger_ has quit IRC12:00
*** salv-orlando has joined #openstack-nova12:02
sahiddansmith: in case you have a moment to look at this today https://review.openstack.org/#/c/484997/12:03
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Address nits in Idf57fb5fbc611abb83943bd7e36d3cebf03b3977  https://review.openstack.org/56120512:14
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Address nits in Idf57fb5fbc611abb83943bd7e36d3cebf03b3977  https://review.openstack.org/56120512:15
*** ccamacho|hungy is now known as ccamacho12:17
*** liverpooler has joined #openstack-nova12:20
bhujayHello everybody , would be  grateful if someone can give me a hint why my openstack environment timestamp is not showing localtime that is set in  operating system /etc/timezone12:23
bhujaynova vm create , key create or any such  creation date is showing utc time and i cant figure out how to change this to localtime12:24
*** edleafe is now known as figleaf12:26
*** cdent has joined #openstack-nova12:26
*** armaan has quit IRC12:26
*** lucas-hungry is now known as lucasagomes12:27
*** _ix has quit IRC12:29
*** jpena|lunch is now known as jpena12:29
*** alexchadin has quit IRC12:31
*** eharney has joined #openstack-nova12:34
*** alexchadin has joined #openstack-nova12:35
*** gcb has quit IRC12:36
*** pchavva has joined #openstack-nova12:38
*** gaoyan has joined #openstack-nova12:41
*** gaoyan has quit IRC12:42
*** edmondsw_ has joined #openstack-nova12:46
*** Roger_ has joined #openstack-nova12:47
*** edmonds__ has joined #openstack-nova12:47
*** ratailor has quit IRC12:49
*** gaoyan has joined #openstack-nova12:49
*** xinliang has quit IRC12:49
*** damien_r has left #openstack-nova12:49
*** edmondsw has quit IRC12:50
*** xinliang has joined #openstack-nova12:50
*** edmondsw_ has quit IRC12:51
*** chenyb4 has joined #openstack-nova12:51
*** udesale has joined #openstack-nova12:53
*** edmondsw has joined #openstack-nova12:54
*** efried is now known as fried_rice12:55
*** jmlowe has joined #openstack-nova12:55
fried_riceö/12:55
*** edmondsw_ has joined #openstack-nova12:56
*** edmonds__ has quit IRC12:56
*** mchlumsky has joined #openstack-nova12:57
*** jmlowe_ has quit IRC12:58
fried_ricestephenfin: is https://review.openstack.org/561190 intended to fix test_non_ami?12:59
fried_rice(Which is French for "No, friend")12:59
stephenfinfried_rice: That's the intention, yup12:59
*** edmondsw has quit IRC12:59
*** stephenfin is now known as finucannot12:59
*** pchavva has quit IRC13:00
*** amoralej is now known as amoralej|lunch13:02
*** psachin has quit IRC13:02
fried_ricefinucannot: +A  (which is French for "Oui, ami")13:04
*** jaypipes is now known as leakypipes13:05
*** Tom-Tom has joined #openstack-nova13:07
*** r-daneel has quit IRC13:09
*** Tom-Tom has quit IRC13:12
*** pchavva has joined #openstack-nova13:17
*** mriedem has joined #openstack-nova13:18
*** chenyb4 has quit IRC13:18
Spaz-HomeHappy friday folks.. time for me to call it an ight13:22
*** Roger_ has quit IRC13:23
*** salv-orlando has quit IRC13:24
*** salv-orlando has joined #openstack-nova13:24
*** jaosorior has quit IRC13:27
*** Roger_ has joined #openstack-nova13:27
*** felipemonteiro_ has joined #openstack-nova13:28
*** salv-orlando has quit IRC13:28
*** alexchadin has quit IRC13:29
*** sar has quit IRC13:29
*** r-daneel has joined #openstack-nova13:30
*** dansmith is now known as superdan13:31
*** caisan has joined #openstack-nova13:31
*** mchlumsky has quit IRC13:33
openstackgerritMerged openstack/nova stable/queens: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt  https://review.openstack.org/55998713:34
*** alexchadin has joined #openstack-nova13:34
*** mlavalle has joined #openstack-nova13:34
*** mchlumsky has joined #openstack-nova13:35
*** lbragstad has joined #openstack-nova13:36
*** edmondsw_ is now known as edmondsw13:39
*** Roger_ has quit IRC13:40
mriedemfinucannot: thanks for https://review.openstack.org/#/c/561190/13:42
finucannotmriedem: np13:44
*** hoonetorg has quit IRC13:48
*** Roger_ has joined #openstack-nova13:49
*** caisan_ has joined #openstack-nova13:50
*** caisan has quit IRC13:50
*** amoralej|lunch is now known as amoralej13:50
openstackgerritMatt Riedemann proposed openstack/nova master: doc: cleanup API guide about instance faults  https://review.openstack.org/56017813:52
*** _ix has joined #openstack-nova13:53
mriedemthat would have been merged by now except with the zuulv3 reswizzle on irrelevant_files we're running tempest jobs on unit test only changes still13:54
*** awaugama has joined #openstack-nova13:55
mriedemfinucannot: can't we define our own nova-tox-py27 and then define our own irrelevant-files list?13:55
mriedemgmann: ^?13:55
mriedemi remember gibi asking about this in the ML13:55
finucannotmriedem: IIRC, we can't override the global state13:56
finucannotfor that one anyway13:56
mriedemwe can't just define our own job that doesn't extend openstack-tox-py27?13:57
mriedemlike, copy openstack-tox-py27 and tweak but not extend13:57
finucannotOhh, I guess we could do that, yeah13:57
*** cdent has quit IRC13:58
finucannotI think openstack-tox-py27 is run by default though. I'm not sure how/if we can disable that13:58
mriedemit's run because of the "openstack-python-jobs" usage in project-config13:59
finucannoti.e. it's defined in openstack/project-config or the likes13:59
finucannotyup13:59
mriedemwhich runs:13:59
finucannot*openstack-infra/project-config13:59
mriedem- openstack-tox-pep813:59
mriedem        - openstack-tox-py2713:59
*** Roger_ has quit IRC13:59
*** esberglu has joined #openstack-nova14:00
mriedemyeah so if we defined our own job, we'd have to list openstack-tox-pep8 in our own .zuul.yaml along with nova-tox-py27, but that seems ok,14:00
mriedemand we'd have to backport it to all stable branches before removing the template usage from project-config14:00
mriedemtrivial but time consuming14:00
finucannotHmm. Can zuulv3 not support this use case?14:01
mriedemi don't know why you can't extend an existing job and override attributes of it, like irrelevant-files14:01
mriedemif we could do that, we'd be set14:01
finucannotThat sounds like a more effective use of time, if we can do it. I wonder if mordred is around?14:02
mriedemi'm asking again in -infra,14:02
mriedembut last time this came up there were lots of words in the ML14:02
mriedemmy head exploded, and i moved on14:02
*** sidx64 has quit IRC14:03
*** alexchadin has quit IRC14:03
mriedemjust sucks that we have to wait 2+ hours for a 15 min job14:03
mriedemheh, maybe i should be asking, why is this taking nearly 2 hours14:04
mriedemtempest-full-py3SUCCESS in 1h 50m 17s14:04
fried_ricemriedem: How long does it take when you run it locally?  Did you say you can run the whole thing in 15m?14:04
mriedemfried_rice: i just mean the unit test job takes 15 minutes14:05
*** archit has joined #openstack-nova14:05
mriedemand that's all we care about in this unit test only patch14:05
fried_riceah, I see.14:05
fried_riceWell, I know I've seen special cases where what you've changed influences which jobs are run.14:05
fried_riceCan't remember specifically for sure, but I think e.g. if you only change docs, only docs jobs are run.14:05
fried_riceSo there's a precedent for it.14:06
mriedemyes that's how things used to all work when the jobs were centralized in project-config, pre-zuulv314:06
mriedemlooking at http://logs.openstack.org/90/561190/1/check/tempest-full-py3/41adeca/controller/logs/stackviz/#/stdin/timeline some of the tempest tests are taking over 7 minutes14:06
mriedemmaybe that's all related to meltdown/spectre fallout...14:07
mriedemslow nodes14:07
mriedemalright, i'll take my cup o coffee and go back into my old man hole now14:07
*** zhaochao has quit IRC14:08
*** armaan has joined #openstack-nova14:10
*** archit has quit IRC14:11
*** felipemonteiro__ has joined #openstack-nova14:16
*** rajinir has joined #openstack-nova14:17
*** felipemonteiro_ has quit IRC14:19
*** sahid has quit IRC14:20
*** bnemec is now known as beekneemech14:23
*** Spazmotic has quit IRC14:23
*** Roger_ has joined #openstack-nova14:24
*** felipemonteiro__ has quit IRC14:25
mordredfinucannot: uhoh14:25
mordredfinucannot: what did I do this time?14:25
mriedemalex_xu: bauzas: per https://review.openstack.org/#/c/554159/ - this is doing the same thing that 2.47 does with showing embedded flavors with extra specs in GET /servers/{server_id}14:26
*** felipemonteiro__ has joined #openstack-nova14:26
*** Spazmotic has joined #openstack-nova14:26
fried_ricemordred: Da boyz were noodling whether/how we could make certain jobs conditional.14:26
finucannotmordred: It's mriedem you've to worry about. He's mad about not being able to override 'irrelevant-files' on our tox-py27 job14:27
*** lyan has joined #openstack-nova14:27
fried_ricemordred: E.g. https://review.openstack.org/#/c/561190/ changed only a UT file, so it would be nice if we didn't bother running all the tempest suites, and we could merge the sucker in 15 minutes instead of 2h.14:27
*** lyan is now known as Guest7876914:27
mordredtotallly understand14:27
bauzasmriedem: so it's using a same policy rule for that ?14:27
mriedembauzas: see my reply to alex_xu in https://review.openstack.org/#/c/554159/ just now14:28
bauzaslemme check the code but I need to disappear in like 2 mins14:28
bauzasmriedem: okay, lemme change my vote, but it'll require a docfix14:29
bauzasthat's the other option I had in mind, so it was a soft -114:29
mordredI would actually think that just adding a nova-specific openstack-tox-py35 variant with some additional irrelevant-files added would work14:29
mordredI'm assuming y'all have tried that already?14:29
bauzasmriedem: +W'd with a comment asking for a followup14:30
mriedembauzas: thanks14:32
mriedemi replied to more of the inline stuff too14:33
*** germs has quit IRC14:35
* bauzas disappears14:35
*** germs has joined #openstack-nova14:35
*** germs has quit IRC14:35
*** germs has joined #openstack-nova14:35
*** psachin has joined #openstack-nova14:36
*** READ10 has joined #openstack-nova14:37
mriedemmordred: already talked about that above, and the implications of doing so14:38
mriedemmordred: tl;dr is i know it's trivial to do, just time consuming14:39
mriedemgiven backports to stable and changes to project-config14:39
*** sar has joined #openstack-nova14:39
mriedemit would help e-r to have project-specific tox jobs again http://status.openstack.org/elastic-recheck/data/integrated_gate.html#openstack-tox-py3514:39
*** elmaciej has quit IRC14:39
*** tssurya has quit IRC14:40
*** Roger_ has quit IRC14:41
*** Roger_ has joined #openstack-nova14:41
Shilpamriedem: Hi, i was going thorugh https://review.openstack.org/#/c/511965/1 >> Spec for volume-backed flavors, any reason why workflow is -1 here14:42
mordredmriedem: I tink we're collecting enough metadata so that elastic recheck could know job + project - we sohuld probably update it to use the data14:43
*** elmaciej has joined #openstack-nova14:44
*** idlemind has joined #openstack-nova14:44
*** AlexeyAbashkin has joined #openstack-nova14:45
mriedemShilpa: because it's complicated and mostly a brain dump to docs for something we've talked about sporadically when we have meetups (PTG, Forum, etc)14:46
mriedemit's not something i'm actively pursuing for Rocky14:46
leakypipesmriedem, mdbooth, superdan: so, question coming from one of our ops teams... is it possible to (live) migrate from a host using ceph for ephemeral disk storage to a host that uses local disk storage (this is temporarily during an upgrade procedure)14:47
superdanleakypipes: with block migration maybe14:47
superdanI'm not an expert there, I'd ask mdbooth when he gets off a call in 13 mins14:48
leakypipessuperdan: cool, thx14:48
superdanleakypipes: also please see channel topic14:48
mriedemit's going from an ephemeral ceph to a non-ceph ephemeral?14:48
Shilpamriedem: ok, one more thing pl confirm,  specs not talikng @ to have root_gb=0 for flavor `volume_backed=True`14:48
mriedemi know our live migration job tests ceph with ephemeral imagebackend and with volume-backed14:49
mriedembut it's ceph on both sides, not changing image types for the ephemeral case14:49
mriedemShilpa: can you rephrase the question?14:49
*** gaoyan has quit IRC14:49
*** AlexeyAbashkin has quit IRC14:49
melwittmriedem, superdan, leakypipes: just remembered we need to propose forum topics today (deadline is sunday april 15) https://etherpad.openstack.org/p/YVR-nova-brainstorming14:50
*** openstackgerrit has quit IRC14:50
melwittI see cdent already proposed a couple of placement-related ones14:50
superdanmdbooth: I added a thing in there14:50
leakypipesmelwitt: ack. (I won't be at the forum, but will try to add items)14:51
mriedemShilpa: based on https://review.openstack.org/#/c/511965/1/specs/queens/approved/volume-backed-flavors.rst@74 - you couldn't have volume_backed=True and root_gb=014:51
mriedembecause that would result in creating a 0gb vlume14:51
mriedem*volume14:51
melwittleakypipes: :( to not being there, k thanks14:51
mriedemwhich i'm pretty sure cinder doesn't allow, volumes have to be at least size>=114:51
Shilpamriedem: actually root_gb should be 0 for volume-backed instances (LP bug https://bugs.launchpad.net/nova/+bug/1469179), so here in specs we are marking ``volume_backed=True` for volume-backed instance14:51
openstackLaunchpad bug 1469179 in OpenStack Compute (nova) "instance.root_gb should be 0 for volume-backed instances" [Medium,In progress] - Assigned to Dan Smith (danms)14:51
leakypipesmelwitt: a certain money-lending institution isn't getting their Friday dues.14:53
melwittlol14:53
mriedemShilpa: then i think you're looking for https://review.openstack.org/#/q/topic:fix-bfv-boot-resources+(status:open+OR+status:merged)14:53
*** melwitt is now known as jgwentworth14:53
leakypipesthere she is :)14:53
*** germs has quit IRC14:53
mriedemShilpa: feel free to comment on the spec as a reminder, but as noted, it's not something i'm actively pursuing14:54
*** germs has joined #openstack-nova14:54
Shilpamriedem: yes iam looking for https://review.openstack.org/#/q/topic:fix-bfv-boot-resources+(status:open+OR+status:merged) , is spec resolves this?14:56
*** links has quit IRC14:58
*** germs has quit IRC14:58
*** amodi has joined #openstack-nova14:59
*** germs has joined #openstack-nova14:59
*** germs has quit IRC14:59
*** germs has joined #openstack-nova14:59
mriedemShilpa: no, it's unrelated14:59
mriedemShilpa: think of that spec basically like the 'get me a network' feature in the 2.37 microversion, but like 'get me a volume-backed instance'15:00
mriedemsimply the bdm_v2 stuff the user has to do15:00
mriedem*simplify15:00
mriedemand allow operators to easily define volume-backed flavors globally15:00
*** rodolof has quit IRC15:00
mriedemShilpa: btw, root_gb=0 doesn't mean volume-backed per se, https://developer.openstack.org/api-ref/compute/#create-flavor15:01
mriedem"The size of the root disk that will be created in GiB. If 0 the root disk will be set to exactly the size of the image used to deploy the instance. However, in this case filter scheduler cannot select the compute host based on the virtual image size. Therefore, 0 should only be used for volume booted instances or for testing purposes."15:01
mriedemroot_gb=0 and server.image_id = '' would definitely indicate volume-backed15:02
jgwentworthoh, that reminds me of a bug I wanted to ask people about15:02
*** amodi has quit IRC15:03
mriedemsuperdan: heh you'll like this https://bugs.launchpad.net/nova/+bug/176303915:03
openstackLaunchpad bug 1763039 in OpenStack Compute (nova) "evacuate instance documentation not mentioning host-evacuate" [Undecided,New]15:03
jgwentworththis one, issues with 0 GB disk flavor + image-based instance https://bugs.launchpad.net/nova/+bug/175827815:04
openstackLaunchpad bug 1758278 in OpenStack Compute (nova) "disk_available_least become a negative value unexpectedly" [Undecided,New]15:04
*** germs has quit IRC15:04
superdanmriedem: guh15:05
mriedemjgwentworth: i think that might be a duplicate of one that mnaser reported, looking15:05
*** felipemonteiro_ has joined #openstack-nova15:05
jgwentworthdoes anyone understand that? ^ I keep getting confused about what actually happens when you do image-based + 0 GB disk15:05
corvusmriedem: how about you just stop using the template that adds the unit test jobs and just add them to your project stanza in repo with your own irrelevant file matchers.  done.15:05
mriedemcorvus: that's what i said we could do above15:06
jgwentworthmriedem: I saw that too a second ago and wondered if it's the same thing15:06
corvusmriedem: i missed what's complicated about that15:06
mriedemcorvus: it's not complicated,15:07
corvusok i'm poor at reading scrollback :)15:07
*** openstackgerrit has joined #openstack-nova15:07
openstackgerritMerged openstack/nova master: tests: Fix how context managers are mocked  https://review.openstack.org/56119015:07
mriedemit's just we also have to backport that to all stable branches before we can remove the openstack-python-jobs template usage from project-config15:07
mriedemagain, not complicated, just tedious15:07
openstackgerritMerged openstack/nova master: Update link of metadata  https://review.openstack.org/56111415:07
*** amodi has joined #openstack-nova15:07
corvusmriedem: okay, yeah.  maybe worth the effort though? :)  it's a one-time cost.15:08
*** felipemonteiro__ has quit IRC15:09
Shilpamriedem: thank you for clarification, earlier thought that volume-backed flavors spec and https://review.openstack.org/#/q/topic:fix-bfv-boot-resources+(status:open+OR+status:merged) has relation.15:09
*** READ10 has quit IRC15:10
corvusmriedem: we did come up with some ways of maybe doing something sensible with irrelevant-files and project-templates, but it's probably going to be a while till we can implement them.15:10
*** Roger_ has quit IRC15:12
*** pcaruana has quit IRC15:12
*** sahid has joined #openstack-nova15:12
*** slaweq has quit IRC15:12
*** amodi has quit IRC15:13
mriedemcorvus: yeah, i've likely already spent more time complaining about this than what it would take to just fix it15:14
*** dpawlik has quit IRC15:17
mdboothleakypipes superdan: re live migration non-ceph->ceph there's no fundamental reason it can't work that I can think of. As was mentioned, though, it's not tested, so it's probably broken for reasons I can't think of, which are probably fixable.15:18
openstackgerritMerged openstack/nova master: Test case: ResourceClass.normalize_name with ß  https://review.openstack.org/56009215:19
superdanI would assume that our driver probably tries to do smart things assuming it is shared, which might defeat other things like block migration if it doesn't account for the possibility15:19
*** slaweq has joined #openstack-nova15:19
mriedemlive migration should try to see if it can talk to the dest host over a shared filesystem though,15:20
mriedemwhich if you're going ceph to non-ceph, will say you can't do that15:20
mriedemso block migration would be required15:20
mdboothI think the shared test is only for shared instance directory15:21
superdanright15:21
mdboothThe shared block iirc is in imagebackend at the class level15:21
mdboothSo super-hacky15:21
openstackgerritMerged openstack/nova master: Make ResourceClass.normalize_name handle sharp S  https://review.openstack.org/56009315:21
mdboothSo yeah, that could potentially break it.15:21
mdboothBut fundamentally, if we wired it up correctly there's no reason you can't block migration from non-ceph to ceph, or vice versa.15:22
mriedemright i think it should work,15:22
mriedembut there are probably assumptions in the code15:22
superdanyep and that's what I'm saying15:22
*** amodi has joined #openstack-nova15:22
superdanI bet it doesn't work.. for stupid reasons15:22
mriedemthis is where i'd look https://github.com/openstack/nova/blob/master/nova/virt/libvirt/migration.py#L8015:23
mriedemthat updates the guest xml on the source host, but updates the xml intended for the dest host15:23
leakypipeswell, they're going to test it. I'll let you know if/what blows up :)15:23
mriedemnothing in ^ indicates it cares about non-volume disks15:23
mriedemthis would be the other place to look https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L756215:24
mriedemrun on the dest, get the info to pass back to the source to tell it how to migrate it15:24
*** Roger_ has joined #openstack-nova15:25
*** salv-orlando has joined #openstack-nova15:26
* mnaser reads buffer15:27
mdboothmriedem: Yeah, that's broken for at least the first reason (disk xml isn't updated)15:27
*** amodi has quit IRC15:28
*** Roger_ has quit IRC15:29
openstackgerritChris Friesen proposed openstack/nova stable/pike: libvirt: disconnect volume from host during detach  https://review.openstack.org/56069015:29
*** slaweq has quit IRC15:30
mriedemcorvus: finucannot: mordred: heh now i realize the flaw in my logic - the problem isn't in defining our own py27 job for unit tests,15:30
mdboothmriedem: This came up today: https://review.openstack.org/#/c/533249/ tl;dr support for ip_allocation='none'. By any chance are you aware of any other existing work on this?15:30
mriedemit's that the tempest-full jobs get run on unit test-only patches in nova15:30
superdankashyap: finucannot: do you guys understand the vhostuser override stuff in this? https://review.openstack.org/#/c/484997/16/nova/virt/libvirt/vif.py line 17115:30
mriedemso we'd have to write our own tempest-full...15:30
mriedemmdbooth: yes, carl_baldwin added that in newton15:31
*** salv-orlando has quit IRC15:31
mdboothmriedem: That was ip_allocation='deferred'15:31
mriedemmdbooth: https://blueprints.launchpad.net/nova/+spec/neutron-routed-networks15:31
mriedemoh15:31
corvusmriedem: wait, no don't write your own unit test or tempest jobs15:31
*** Shilpa has quit IRC15:31
mdboothmriedem: This is for when the user literally never wants an ip15:31
corvusmriedem: when you attach a job to a project, you can specify the irrelevant files.  so if you do that in-repo, as opposed to using the templates, you can specify your own irrelevant files.15:32
cfriesenleakypipes: try it and see?  :)15:32
mriedemmdbooth: then they should use networks='none' with 2.3715:32
leakypipescfriesen: yeah, they are :)15:32
mdboothCan they still attach the port without an ip?15:33
leakypipeswill report back with my findings from the field.15:33
mriedemcorvus: i think nova gets tempest-full via the integrated-gate template https://github.com/openstack-infra/project-config/blob/master/zuul.d/projects.yaml#L1031615:33
corvusmriedem: (the complication is that andreaf would like you to please use the project template for tempest jobs for the time being so can can adjust it centrally.  so until we come up with a way to support overriding the matchers of a project-template in-repo, we have to choose between local or central control)15:33
mriedemright,15:34
*** andreas_s has quit IRC15:34
mriedemso i'm not sure if nova would have to drop using the integrated-gate template or what15:34
andreafmriedem yeah that's the conclusion we came to at the PTG15:35
corvusmriedem: yes.  options are: drop that template and add the jobs it has directly; or wait until i (or someone) can get around to implementing some way to alter the irrelevant-files matchers on jobs in that template in your repo (probably wont happen for weeks at least)15:35
mriedemi choose not to make a choice, like geddy said15:36
mriedemhttps://www.youtube.com/watch?v=hX9VGUaIpds15:37
mriedemwhere are all my rush fans?!15:37
*** salv-orlando has joined #openstack-nova15:37
mriedemcfriesen: surely you ^15:37
corvuseverone take the day off and listen to rush15:37
jgwentworthgeddy, I wonder if he speaks like an ordinary guy15:38
*** Roger_ has joined #openstack-nova15:38
leakypipescfriesen: ? for you on https://bugs.launchpad.net/nova/+bug/175062315:39
openstackLaunchpad bug 1750623 in OpenStack Compute (nova) queens "rebuild to same host with different image shouldn't check with placement" [Medium,In progress] - Assigned to Hongbin Lu (hongbin.lu)15:39
cfriesenmriedem: I don't think you can avoid it up here. :)15:40
mdboothmriedem: Just reading the get-me-a-network stuff. I think networks='none' is different. They *do* want to attach the port to a network, it's just that the network has no subnets, will never be associated with an IP, and therefore can't have a security group (iiuc).15:40
cfriesenleakypipes: yes?15:40
cfriesenleakypipes: ah, checking.15:41
mdboothmriedem: Don't worry if it doesn't ring any bells, btw. Just wanted to check if you knew of any work going on in this area other than the above review.15:41
*** cdent has joined #openstack-nova15:42
*** Roger_ has quit IRC15:43
*** beekneemech has quit IRC15:45
cfriesenleakypipes: yep, good catch.  that just opened a huge can of worms I think.15:46
*** armaan has quit IRC15:46
leakypipescfriesen: well, shit. I didn't intend it to. :)15:46
leakypipescfriesen: you mean *more* than the can of worms that rebuild already is? ;)15:46
mriedemleakypipes: we still run the new image through the image properties filter and numa topology filter15:47
mriedembut we won't claim on the compute, in the case of numa15:47
cfriesenmriedem: yeah, but if the numa topology changes then placement allocations need to change15:47
mriedemso we probably need some filter that says you can't rebuild with a new image that has new numa topo15:48
mriedemcan you specify numa topo via image props? https://docs.openstack.org/python-glanceclient/latest/cli/property-keys.html15:48
*** itlinux has joined #openstack-nova15:48
cfriesenmriedem: and that additional restriction would be a behaviour change15:48
cfriesenmriedem: yeah, hw_numa_nodes=215:48
*** dpawlik has joined #openstack-nova15:48
mriedemnot really, it's a bug fix15:48
mriedemhuh, ok that's not in that doc...15:49
*** bnemec has joined #openstack-nova15:49
mriedemor https://docs.openstack.org/nova/latest/admin/cpu-topologies.html#smp-numa-and-smt for that matter15:49
cfriesenalso hw_numa_cpus.1=2, hw_numa_mem.1=51215:49
*** bnemec is now known as beekneemech15:50
mriedemyeah i see it in ImageMetaProps now15:50
*** elmaciej has quit IRC15:50
cfriesenyou can even specify pagesize in the image if the flavor specifies "any" or "large"15:51
jgwentworthanyone know if this is a known gate bug? I find some hits in logstash http://logs.openstack.org/78/554078/12/gate/legacy-tempest-dsvm-multinode-live-migration/cc18c8c/logs/testr_results.html.gz15:52
*** amodi has joined #openstack-nova15:52
mriedemcfriesen: if you're so inclined, you could dump other image props in https://bugs.launchpad.net/nova/+bug/176376115:52
openstackLaunchpad bug 1763761 in OpenStack Compute (nova) "CPU topologies in nova - doesn't mention numa specific image properties" [Medium,Confirmed]15:52
mriedemjgwentworth: likely yes, but you have to find the qemu guest log to see what the actual failure was15:53
jgwentworthah okay15:53
*** dpawlik has quit IRC15:53
mriedemhttp://logs.openstack.org/78/554078/12/gate/legacy-tempest-dsvm-multinode-live-migration/cc18c8c/logs/subnode-2/libvirt/qemu/instance-0000000a.txt.gz15:54
mriedemVQ 1 size 0x100 Guest index 0x4 inconsistent with Host index 0x5: delta 0xffff15:54
superdanhmm, jackie_truong not around on irc today eh?15:54
mriedemjgwentworth: http://status.openstack.org/elastic-recheck/#176179815:54
jgwentworthahoy15:54
mriedemjgwentworth: that fingerprint needs to be updated15:54
mriedemit relies on VQ 0 only15:55
mriedembut this has "VQ 1 size"15:55
mriedemjgwentworth: can you push an update to the query in e-r?15:55
jgwentworthmriedem: yis15:55
mriedemhttp://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22VQ%5C%22%20AND%20message%3A%5C%22size%5C%22%20AND%20message%3A%5C%22Guest%20index%5C%22%20AND%20message%3A%5C%22inconsistent%20with%20Host%20index%5C%22%20AND%20tags%3A%5C%22screen-n-cpu.txt%5C%22%20AND%20voting%3A1&from=7d15:55
mriedemthat should handle it15:55
mriedemcfriesen: leakypipes: so yeah, sounds like we should fail rebuild if you attempt to use a new image that has any different numa/cpu/hw stuff in it15:57
jgwentworththankee15:57
mriedemwhich would be a bug since....juno?15:57
*** sc has left #openstack-nova15:57
*** amodi has quit IRC15:58
mriedemjohnthetubaguy_: i added you to https://review.openstack.org/#/c/552078/ in case you can give any feedback before i rev it15:59
*** do3meli has quit IRC15:59
*** caisan_ has quit IRC16:00
johnthetubaguy_mriedem: will try take a peak at that, been out at a conference-ey thing all week, so miles behind the curve right now16:00
*** Spazmotic has quit IRC16:00
*** lpetrut has quit IRC16:00
*** Spazmotic has joined #openstack-nova16:01
mriedemack thanks16:01
*** slaweq has joined #openstack-nova16:01
cfriesenmriedem: I think the issue is more that we don't recalculate the numa topology on a rebuild....we actually used to do a claim on a rebuild16:01
mriedemjohnthetubaguy_: were these guys there? https://i.ytimg.com/vi/sVw0i5Rd_Is/maxresdefault.jpg16:02
mriedemcfriesen: when did we ever do a claim on a rebuild?16:02
mriedemand don't confuse rebuild with evacuate16:02
cfriesenmriedem: yeah, you're right it was for the evac case.16:02
johnthetubaguy_mriedem: I hadn't noticed the resemblance till just now, but yes they were16:02
johnthetubaguy_mriedem: although it probably makes me scooter16:03
*** diga has joined #openstack-nova16:03
mriedemha16:04
jgwentworthmriedem: https://review.openstack.org/#/c/56126116:04
openstackgerritDan Smith proposed openstack/nova master: Implement certificate_utils  https://review.openstack.org/47994916:04
openstackgerritDan Smith proposed openstack/nova master: Add trusted_image_certificates to REST API  https://review.openstack.org/48620416:04
openstackgerritDan Smith proposed openstack/nova master: Plumb trusted_certs through libvirt driver image paths  https://review.openstack.org/56126216:04
cfriesenmriedem: you going to raise a bug report for the image validation on rebuild?16:04
mriedemcfriesen: no, can you please?16:04
cfriesensure16:04
mriedemthanks16:04
jgwentworthsuperdan, mriedem, leakypipes, alex_xu, johnthetubaguy_, finucannot, bauzas, fried_rice: been meaning to ask for review on the rocky priorities doc page https://review.openstack.org/#/c/55779616:06
*** r-daneel has quit IRC16:06
mriedemack16:06
fried_ricejgwentworth: There was a typo it looked like Mel wanted to fix.  Otherwise I'm +1 (discussion inline leading to possible external actions, not in the patch)16:07
fried_ricejgwentworth: ...a typo and a link16:07
jgwentworthoh, right. I forgot16:07
jgwentworthI don't think there's a way to filter only Approved blueprints in launchpad, which sucks16:08
jgwentworthfor linking16:08
*** lucasagomes is now known as lucas-afk16:08
fried_ricejgwentworth: There is some mystical querystring syntax that only mriedem knows how to use.16:09
jgwentworthI thought I've asked him about that before. maybe he's holding out on me16:10
mriedemnot in the UI that i know of,16:10
mriedemvia the REST API yes16:10
superdanI think LP has a bunch of inaccessible query strings you can use16:11
mriedemright16:11
mriedemhttps://github.com/openstack/nova-specs/blob/master/tools/move_implemented_specs.py16:11
*** jchhatbar has quit IRC16:12
sahidsuperdan: i saw your comments and questioning on the tx/rx queue size patch. I tried to give more details I hope that is going to help16:12
superdansahid: okay the thing I'm worried about is I thought that the guest had to support vhost (or is it vhostuser?) in a specific way, and I haven't gone to chase down all the places where we choose between those different types of virtio backends16:15
jgwentworthmriedem: cool script16:15
*** pcaruana has joined #openstack-nova16:15
*** amodi has joined #openstack-nova16:17
*** amodi has quit IRC16:18
cfriesenmriedem: here's the bug:16:18
cfriesenLOG.info("Device %s not found in instance.",16:18
cfriesen                     disk_dev, instance=instance16:18
cfriesengrr......https://bugs.launchpad.net/nova/+bug/176376616:18
openstackLaunchpad bug 1763766 in OpenStack Compute (nova) "nova needs to disallow topology changes on image rebuild" [Undecided,New]16:18
*** sree has joined #openstack-nova16:19
*** jchhatbar has joined #openstack-nova16:20
superdansahid: okay re-reading this with your context I have a little better idea on what to look at16:20
sahidsuperdan: the driver are on the guest OS. that is your question?16:20
superdansahid: I'll try to do that while you wor on your unit test16:20
superdansahid: yeah, the guest16:20
superdansahid: I thought that if we specify one of those (I think vhostuser) the guest _has_ to have something new enough to support it?16:21
superdanalthough maybe that doesn't matter since you're only overriding back to vhost/16:21
superdansahid: I guess it would be less confusing if you did your refactor of get_base_config() first16:22
mriedemjgwentworth: one thing i've always meant to do with that is move the validation that the spec filename matches the blueprint in LP into the doc/test validation code that runs on each patch16:23
sahidwell for vhostuser the virtio driver needs to be recent enough and for vhost the kernel recent enough16:23
superdansahid: can/do we validate some of these types in upstream CI?16:23
mriedemsince people frequently make that mistake and then we have to fix it up later16:23
*** mdbooth has quit IRC16:23
jgwentworthmriedem: you mean in the tox run of nova-specs16:24
mriedemyeah16:24
sahidsuperdan: yes probably i was thinking about to refactor that method first...16:24
superdansahid: yeah, I'm just trying to make sure we're not ever selecting something different after this patch, or at least, selecting something different than what would work today16:24
sahidoh i see16:24
jgwentworthmakes sense16:24
sahidnormally no :)16:24
superdansahid: if you did that first, then if we have a problem with this later, it would point to the refactor patch instead of your queues patch which would be better I think16:24
*** r-daneel has joined #openstack-nova16:24
superdansahid: "if we had a problem" meaning.. we selected vhostuser when we should/would have selected vhost or something16:25
jgwentworthmriedem: I think the only wrinkle there could be the LP timeouts that I've run into a fair bit blocking people's specs from passing the tox check16:26
sahidsuperdan: the thing is the refactor could be big i wanted to limit the scope16:26
sahidi will have to touch lot of thing like the multiqueue support16:27
superdansahid: so we call all of this from a block that says "if os_vif, do _get_config_os_vif(), otherwise call these per-type methods"16:27
superdansahid: do we call the os_vif path in this case or not?16:28
*** ktibi has quit IRC16:28
sahidsuperdan: yes for bridge16:28
sahidand actually for vhostuser16:29
superdanokay, so, vif_type could be bridge, where we end up with driver as qemu or vhost, and then vif_type could be vhostuser where we always have driver as vhostuser, is that right?16:29
sahidyes that is the point16:30
superdanany other types that would have driver=vhost16:30
superdan/16:30
superdan?16:30
sahidyes except if the virt_type is qemu16:30
mriedemjgwentworth: yeah good point16:31
*** sree has quit IRC16:31
superdansahid: I'm not sure I know what you mean.. bridge can be vhost or qemu, are there things other than bridge that can use vhost as the driver?16:31
*** sree has joined #openstack-nova16:32
*** sar has quit IRC16:32
superdanoh, virt-type you meant parallels being the alternative I guess16:32
sahidi mean we always want driver=vhost except when virt-type!=kvm16:32
sahidi need to check my thinking is other driver may use vhost16:33
sahidother vif16:34
openstackgerritayoung proposed openstack/nova master: Set scope_types for admin password policies  https://review.openstack.org/55361316:34
superdansahid: did you say that vhostuser would go through os_vif now too?16:34
sahidi'm not sure i understand what you mean by go throught os_vif16:36
*** sree has quit IRC16:36
sahidall ovs and linux bridge vifs pass go through os_vif16:37
sahidhere we are configuring guest xml16:37
sahidos vif is configuring the network on host16:37
superdansahid: this: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L554-L55916:38
superdanbecause if we take that path, we never call get_config_vhostuser()16:38
sahidget_base_config is called anytime, and yes we have a specific class in os-vif for vhostuser16:39
sahideverytime16:39
superdansahid: right, so will this ever get run? https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L42016:39
sahidbut no real relation is just about to pass some metadata which will be used by ovs16:39
sahidhum that is why i said i need to double check i think vrouter is using that method16:40
sahidbut perhaps they now have a plugin in os_vif16:40
superdanokay I'm not sure how that would get called16:41
*** damien_r has joined #openstack-nova16:41
*** salv-orlando has quit IRC16:41
*** salv-orlando has joined #openstack-nova16:41
*** fried_rice is now known as fried_rolls16:41
*** damien_r has quit IRC16:42
*** damien_r has joined #openstack-nova16:42
sahidsuperdan: i just check, you think we sould remove it?16:42
superdansahid: well, your patch modifies it, and it's one of the things I was trying to verify, so if it's dead code then we should remove it so I don't have to ask questions about whether or not your changes are correct :)16:43
*** yamahata has quit IRC16:43
*** salv-orlando has quit IRC16:44
*** salv-orlando has joined #openstack-nova16:44
sahidi'm just asking myself why we don't have removed it when we have introduced it in os_vif16:45
sahidi will try to find the git commit log16:45
superdanit looks like we do have a vhostuser conversion in that utils moduke,16:46
superdanbut it can raise NotImplemented, so maybe there are cases where it isn't covered?16:46
*** ssurana has joined #openstack-nova16:47
*** damien_r has quit IRC16:48
sahidi can't see when it can raise a NotImplemented, can yu point me the line?16:49
superdanyep, sec16:49
*** damien_r has joined #openstack-nova16:49
superdanhttps://github.com/openstack/nova/blob/master/nova/network/os_vif_util.py#L408-L40816:49
*** hongbin has joined #openstack-nova16:50
superdanother methods in there don't raise it in a final else16:50
superdanbut maybe you can tell that that should never happen?16:50
sahidsuperdan: i can't :/16:50
sahidlet see what it blame is saying16:51
*** gyee has joined #openstack-nova16:51
*** esberglu has quit IRC16:52
*** ssurana has quit IRC16:53
*** links has joined #openstack-nova16:53
superdanthe set_config_VIFVHostUser method is only used from the os_vif path16:54
superdanso that covers us for the os_vif vif_types I guess16:55
*** damien_r has quit IRC16:57
sahidsuperdan: so what is your thinking?16:59
superdansahid: I just added some more comments to the review,16:59
superdanbut you're only setting the queue sizes if we do _not_ convert the vif in os_vif_util,17:00
superdanmeaning only if it raises NotImplementedError,17:00
*** germs has joined #openstack-nova17:00
*** germs has quit IRC17:00
*** germs has joined #openstack-nova17:00
superdanwhich would mean we're not setting queue sizes for the more common types of VIFs right?17:00
superdani.e. you're only setting the sizes if we _fail_ the os_vif test and fall back to this method that we think might actually be dead code17:00
*** derekh has quit IRC17:00
sahidsuperdan: for you first question, get_base_config is called even when we build os_vif object17:04
superdansahid: ah wait, nevermind that last point17:04
*** germs has quit IRC17:05
*** jpena is now known as jpena|off17:07
superdansahid: okay, I think I've got this more in my head now,17:08
superdanso this is what I think I want to see:17:08
superdan1. I want to know if we're ever really calling the non-os_vif path (i.e. get_config_vhostuser). If we're not, we should just nuke that in a patch before this and then remove from this17:08
*** jchhatbar has quit IRC17:09
superdan2. I'd really like it if we could avoid setting driver in get_base_config and then re-setting it for the vhostuser cases17:09
superdanfor #2, we need an answer to the question I had before of whether or not things other than bridge use driver=vhost17:09
*** amoralej is now known as amoralej|off17:09
superdanif we don't then I think we could set driver=vhost in set_config_VIFBridge (right?) and then set driver=vhostuser for _set_config_VIFHostUser() (right?)17:10
*** mgoddard has quit IRC17:10
superdanfor #1, who can we ask that would know the answer to how we could get to the NotImplementedError in os_vif_util17:10
superdan?17:10
sahidfor #1 I think sean-k-mooney can help17:11
superdanokay that would have been my first thought17:11
sahidfor #2 we are using vhost for more that bridge17:11
sahidi was confusing17:11
sahidbut basicallt for every net device type virtio17:12
sahidwhich is always the case17:12
sahidwe use vhost user if the host support it17:12
sahidbasically to plug a tap device in qemu we always use a device virtio-net17:12
superdanokay and that gets set in get_base_config() today because of _get_virtio_mq_settings() ?17:13
*** sambetts is now known as sambetts|afk17:13
sahidyes, we specically set it because we want the driver node to pass the attirbute queues17:14
superdanokay, so today before your patch, how do we get driver=vhostuser in the vhostuser case?17:14
sahidthat was the point of the TODOs i added17:15
superdanmeaning, why didn't we need L549 in your patch before?17:15
sahidbefore of my patch we where setting vhost even for a vhostuser interface17:16
*** jackie-truong has joined #openstack-nova17:16
*** wolverineav has joined #openstack-nova17:16
superdanah, okay and you were saying that was just getting ignored?17:16
sahidexactly17:16
superdan"since QEMU ignores the driver17:16
superdan            # argument for vhostuser "17:16
superdanokay17:16
superdanthere are waaaay too many things in here with almost the same name :)17:17
sahidyes that is what i meant17:17
sahidit's really confusing yes17:17
superdanokay, so,17:17
superdanthis seems silly, but can we remove L549 from this patch and put it either before or after?17:17
superdanI think it's super confusing because I thought you were changing something,17:17
superdanbut really you're just correcting something that is ignored17:18
sahidyes :)17:18
sahidbut...17:18
sahidno, ok I can provide a patch to set driver_name = vhostuser for set_config_VIFHostUser17:19
*** slaweq has quit IRC17:19
sahidand then provide the queue sizes change17:19
sahidlooks good for you?17:19
superdanyeah, do that17:19
sahidok17:19
superdanbut also,17:19
superdanI want to know that answer to #117:19
sahidyea, i think that will be diffuclt to response for example i'm sure before of the update for vrouter they were using that17:20
sahidso i imagine it might have other kind of switch which are using it17:20
sahidbut let see with sean17:20
superdanokay, one other thing:17:21
superdanthe L171 override,17:21
superdaner, nevermind17:22
superdanI forgot about setting the rx_queue_size for the frontend17:22
sahidok cool17:23
sahidthanks for you time superdan. time for me to take a break17:23
superdansahid: yeah, thanks for your patience, I will summarize in the review (again :P)17:23
sahid:)17:24
*** sahid has quit IRC17:25
*** felipemonteiro_ has quit IRC17:27
*** felipemonteiro_ has joined #openstack-nova17:27
*** ssurana has joined #openstack-nova17:28
*** yamahata has joined #openstack-nova17:29
*** ssurana1 has joined #openstack-nova17:32
*** ssurana has quit IRC17:32
*** ssurana1 has quit IRC17:34
superdanjgwentworth: you wanna take a trip through this? https://review.openstack.org/#/c/479949/5717:38
superdannow that it's split into a smaller piece I think it's close to reasonable but I'm getting a little blind to it at this point17:39
*** felipemonteiro_ has quit IRC17:39
jgwentworthsuperdan: yes, will do that today17:40
superdanthanks17:41
superdanI bet jackie-truong thanks you too17:41
jgwentworth:)17:41
*** lpetrut has joined #openstack-nova17:41
jackie-truongYes, please :-) Thanks, jgwentworth and superdan17:42
superdanjackie-truong: I was looking for you on here earlier today to ask forgiveness for asking to split the patch so late17:42
superdanyou not being here led to guilt and me splitting it for you17:42
superdanso, good job.17:42
kashyapsuperdan: Was AFK; just re-launched IRC client, /me scrolls back17:43
jackie-truongsuperdan: Sorry I wasn't around. Friday meetings suck. Thanks for splitting the patch - I think it makes a lot more sense that way17:43
superdankashyap: not a thing anymore17:44
kashyapsuperdan: Ah, noted.17:45
superdankashyap: I spent an epic hour or so with sahid getting it all figured out myself17:45
* kashyap bows17:45
kashyaplyarwood: or any "Stable People": Want to put this out of its misery: https://review.openstack.org/#/c/561168/17:45
kashyapsuperdan: FWIW, so many TODOs in already one patch: https://review.openstack.org/#/c/484997/16/nova/virt/libvirt/vif.py?17:47
kashyapA bit moderation would be nice17:47
superdankashyap: yeah, he's going to move some of the stuff out to another patch, which will pull some TODOs with it17:48
superdankashyap: they're not TODOs about the patch itself, but some stupid stuff that was in the file before this17:48
superdanlike "I noticed this was already wrong when I was in here"17:48
kashyapAh, I see.17:48
superdanwhich should be in another patch,17:48
superdanespecially because it took me days to suss that out :)17:48
kashyapRight.  "One logical change per patch"17:48
jgwentworthjackie-truong: is this the tempest test where we can see the cert validation working end-to-end? https://review.openstack.org/#/c/52648517:49
*** psachin has quit IRC17:49
superdanjgwentworth: it's linked in the bottom patch17:50
superdanI don't think that's it17:50
superdanjgwentworth: https://review.openstack.org/#/c/515210/17:50
jgwentworthlinked in the comments? cause I don't see anything in the commit message17:50
superdanyeah comments17:50
jgwentworthk, thanks17:50
kashyapsuperdan: Also, it's never a "mess" (as you put it there) to do connsciousness stream write-ups on reviews are perfectly "legal", as you know :P17:50
superdanI just rechecked it a bit ago after pushing up the split, but it wasn't a change, so the last run of that should be fine for validation17:51
jgwentworthoh, k. I did see that patch but missed that it's tempest via pluginness17:51
superdankashyap: it's a total mess17:51
kashyapIf you say so...17:51
cfriesendo we do anything to prevent a port deletion of a port that is connected to an instance?  or should I be asking the neutron folks?17:52
*** tesseract has quit IRC17:53
kashyapUnrelated: Are Gerrit review comments look-up-able?  As in: I know that dansmith said $unique-phrase on a change, putting that phrase in double quotes in Google will yield the right URL?17:53
*** udesale has quit IRC17:53
superdanwhat did I say?17:53
jgwentworthyes they are. can't remember how off the top of my head17:53
openstackgerritMatt Riedemann proposed openstack/nova master: Add config option to block image-backed servers with 0 root disk flavor  https://review.openstack.org/56128417:54
mriedemjgwentworth: mnaser: ^17:54
*** burt has joined #openstack-nova17:54
jgwentworthkashyap: https://review.openstack.org/Documentation/user-search.html#comment17:54
kashyapsuperdan: Heh, not what you said, but I just took you as an example.  Any unique phrase that I know of17:54
mriedem95% of that patch is test and docs17:54
jgwentworthmriedem: whew, thanks17:55
*** mgoddard has joined #openstack-nova17:55
kashyapjgwentworth: Thanks.  So that is searching in review.openstack.org itself.17:55
arvindn05mriedem: morning :)17:55
jgwentworthkashyap: yeah, like in the serach box you do comment:"unique phrase"17:56
jgwentworth*search17:56
kashyapThanks.  That's useful17:56
arvindn05mriedem: looks like bauza does not like special case logic in scheduler :(17:56
*** ralonsoh has quit IRC17:56
*** esberglu has joined #openstack-nova17:56
arvindn05mriedem: i did mention to him that we plan to have the logic in the scheduler already as part of the bug fix for https://bugs.launchpad.net/nova/+bug/175062317:57
openstackLaunchpad bug 1750623 in OpenStack Compute (nova) queens "rebuild to same host with different image shouldn't check with placement" [Medium,In progress] - Assigned to Hongbin Lu (hongbin.lu)17:57
*** Sukhdev has joined #openstack-nova17:57
arvindn05bauzas: can we discuss your comments on https://review.openstack.org/#/c/560718/  - Handle rebuild of instance with new image?18:00
*** links has quit IRC18:02
mriedemarvindn05: bauzas is in france so probably done for the day (it's 8pm there)18:03
mriedemjgwentworth: mnaser: as soon as i pushed that up for review and stepped away for a minute, i thought that is probably better as a policy rule rather than a config option...18:03
mnaserthats an interesting approach18:04
mriedembecause if you don't allow users to upload images, then you don't need the warning spam in the nova-api logs,18:04
openstackgerritChris Dent proposed openstack/nova master: [placement] Parse forbidden traits in query strings  https://review.openstack.org/55681918:04
openstackgerritChris Dent proposed openstack/nova master: [placement] Filter resource providers by forbidden traits in db  https://review.openstack.org/55647218:04
openstackgerritChris Dent proposed openstack/nova master: [placement] Filter allocation candidates by forbidden traits in db  https://review.openstack.org/55666018:04
openstackgerritChris Dent proposed openstack/nova master: [placement] Support forbidden traits in API  https://review.openstack.org/55682018:04
jgwentworthI could see that18:04
mriedemand if you want to play with this feature but only for admins, then you can do that with policy but the config option is either on or off18:04
jgwentworthah, for the dev/test scenario. yeah18:05
mriedemwell, we might have the warning in the logs either way since we don't know if glance is configured to allow image uploads18:05
mriedemfor tenants18:05
mriedemthe warning is really my way of trying to get people to realize this is a thing if they aren't reading release notes18:05
mnaseri like the idea of making it a policy flag thing, in case you want to allow specific tenants that rely on old behaviour (but you know won't be breaking things)18:11
mriedemyeah me too, it's more flexible18:12
mriedemi'll wait a bit before making changes18:12
openstackgerritMerged openstack/nova master: Remove the branch specifier from the nova-multiattach job  https://review.openstack.org/56093018:14
openstackgerritMerged openstack/nova master: libvirt: move version to string in utils  https://review.openstack.org/56045518:15
*** links has joined #openstack-nova18:15
openstackgerritMerged openstack/nova master: libvirt: refactor get_base_config to accept host arg  https://review.openstack.org/56045618:15
mriedemsuperdan: can you fast approve this on stable? https://review.openstack.org/#/c/560931/18:15
mriedemneed that to get the multiattach job voting again on master18:16
superdancan I or will I?18:16
mriedemcan you will it18:16
*** bhujay has quit IRC18:16
*** stvnoyes has quit IRC18:19
kashyapsuperdan: I know you did a more robust review, I hope my -1 here is still in the spirit of it: https://review.openstack.org/#/c/484997/16/nova/conf/libvirt.py18:21
* kashyap winds up for the night18:21
*** gjayavelu has joined #openstack-nova18:23
openstackgerritChris Dent proposed openstack/nova master: [placement] Parse forbidden traits in query strings  https://review.openstack.org/55681918:24
openstackgerritChris Dent proposed openstack/nova master: [placement] Filter resource providers by forbidden traits in db  https://review.openstack.org/55647218:24
openstackgerritChris Dent proposed openstack/nova master: [placement] Filter allocation candidates by forbidden traits in db  https://review.openstack.org/55666018:24
openstackgerritChris Dent proposed openstack/nova master: [placement] Support forbidden traits in API  https://review.openstack.org/55682018:24
mriedemjgwentworth: mlavalle: posted http://forumtopics.openstack.org/cfp/details/12418:28
jgwentworthcoolness. thanks. superdan, want to post the cells one?18:29
mlavallemriedem: thanks18:29
openstackgerritHongbin Lu proposed openstack/nova stable/pike: Skip placement on rebuild in same host  https://review.openstack.org/56101518:30
*** bkopilov has quit IRC18:30
mriedemmlavalle: ops might want to ask about routed networsk too, i don't know how much you get for questions about that18:31
*** links has quit IRC18:31
mlavallemriedem: I am not getting many questions lately18:32
*** lpetrut has quit IRC18:34
*** lpetrut has joined #openstack-nova18:34
superdanjgwentworth: okay18:38
*** Guest35063 has quit IRC18:44
jgwentworththankee18:45
superdanjgwentworth: http://forumtopics.openstack.org/cfp/details/12518:46
jgwentworthwoot18:46
cfriesengot a weird setup.  we had in instance on a host in Newton, then deleted the host, then upgraded to Pike (which added uuids to the Service records but apparently not deleted ones), then created the compute node again with the same name.  Now when we try to get that instance from the db it chokes, I suspect because it pulls in the deleted host record which has no uuid.18:49
cfriesenshould we have applied UUIDs to deleted hosts as well in the Pike online data migration?18:49
jgwentworththere's a bug for that18:49
* jgwentworth rummages through bag of bugs18:49
jgwentworthcfriesen: https://bugs.launchpad.net/nova/+bug/174650918:50
openstackLaunchpad bug 1746509 in OpenStack Compute (nova) pike "TypeError: Can't upgrade a READER transaction to a WRITER mid-transaction" [High,Fix committed] - Assigned to melanie witt (melwitt)18:50
jgwentworthdid you do your pike upgrade before that merged or was released?18:51
openstackgerritMerged openstack/nova master: Add host field to InstanceActionEvent  https://review.openstack.org/55514618:51
cfriesenjgwentworth: cool, looks interesting.  I need to dig into this a bit more to get the details.18:53
jgwentworthk. yeah, this was specifically having to do with an upgrade scenario where there were already existing service records with no UUID18:54
jgwentworthand instance list failed18:54
cfriesenjgwentworth: do you know why we didn't just apply uuids to deleted services for consistency?18:54
jgwentworthcfriesen: we were but on-the-fly upon access. so the bug unfortunately was shown *during* the generation of service UUID for one that did not yet have a UUID :/18:55
cfriesenah, got it.18:55
jgwentworthbecause of nested database transaction contexts. unrelated to the generation but nothing hit the path until the generation was added to the instance read flow18:56
*** dklyle has quit IRC18:56
cfriesenjg: I was thinking in service_uuids_online_data_migration()18:56
cfriesenjgwentworth: ^18:56
jgwentworthyeah, I figured that's what you meant. was not done in a batch like that and I don't know why not18:57
*** dklyle has joined #openstack-nova18:57
jgwentworthsuperdan might know. why we didn't do service UUID as a batch online data migration?18:57
superdandid we not?18:59
superdanwe did18:59
superdanwe normally skip deleted records for expediency, which is what he's asking right?18:59
jgwentworthhm, okay. so that means they didn't run nova-manage online_data_migrations?19:00
jgwentworthno, not deleted records19:00
cfriesenjgwentworth: pretty sure we ran it but it would have skipped the deleted records19:00
superdan[11:54:35]  <cfriesen>jgwentworth: do you know why we didn't just apply uuids to deleted services for consistency?19:00
jgwentworthexisting non-deleted service records that lacked a service UUID19:00
jgwentworthoh, I missed that19:00
*** germs has joined #openstack-nova19:01
*** germs has quit IRC19:01
*** germs has joined #openstack-nova19:01
cfriesenjgwentworth: we'll try that fix you pointed me at...hopefully that solves the on-demand issue19:01
superdancfriesen: for instance-related things, skipping deleted saves us a ton of work of course19:01
superdanmaybe less on services, but .. if there's no way to undelete a service there's not much point19:01
jgwentworthokay, yeah if they service was in the deleted state then it could be skipped. but how could an active instance have a deleted service record?19:01
cfriesensuperdan: yeah, I get that.  just bad luck that it triggered another bug19:01
jgwentworthI guess that goes back to our discussion from the other day19:02
superdanjgwentworth: we just went over that you can delete services even when instances are on it right? :)19:02
superdanyeah that19:02
jgwentworthwe allow service delete while instances are alive19:02
cfriesenjgwentworth: boot instance, migrate it, delete service, upgrade, add new service with same name, migrate instance19:02
superdanor just boot instance, delete service19:02
jgwentworthokay, I didn't realize that was a thing19:02
superdanjgwentworth: remember me saying I thought it was probably bad to allow this anyway? :P19:03
openstackgerritMatt Riedemann proposed openstack/nova master: Make service all-cells min version helper use scatter-gather  https://review.openstack.org/53959019:03
openstackgerritMatt Riedemann proposed openstack/nova master: Make host_manager use scatter-gather and ignore down cells  https://review.openstack.org/53961719:03
jgwentworthcfriesen: so you would have a problem if we made it so services can't be deleted if they have running instances?19:03
mriedemsuperdan: i've got a patch up for that, testing it in devstack atm19:03
jgwentworthsuperdan: yes19:03
mriedemhttps://review.openstack.org/#/c/560674/119:03
* jgwentworth opens a billionth tab19:04
cfriesenjgwentworth: I wouldn't, no.  In our case we did the sequence I described...the issue is that the back reference from instance to service is by host name19:04
cfriesenso if you delete a service then make another with the same name, they'll both get matched19:04
superdanwhich is another reason why that hostname-based keying is kinda bad19:04
jgwentworthoh, okay, so because you migrated the instance already the service delete would be okay with you as no running instances left on it19:05
cfriesenyep19:05
jgwentworthk, cool19:05
*** germs has quit IRC19:06
*** Tom-Tom has joined #openstack-nova19:07
*** claudiub|2 has quit IRC19:09
*** harlowja has joined #openstack-nova19:10
*** Tom-Tom has quit IRC19:11
*** idlemind has quit IRC19:15
*** idlemind has joined #openstack-nova19:16
*** lpetrut has quit IRC19:19
*** sidx64_ has joined #openstack-nova19:20
*** jackie-truong has quit IRC19:20
*** mgoddard has quit IRC19:21
*** fried_rolls is now known as fried_rice19:26
*** Sukhdev has quit IRC19:28
jgwentworthsuperdan: on this patch about multi-cell query for instance group members, mriedem and I had some discussion over whether or not I should make changes to limit the query to the cell we're already in, if it's a move operation. we wanted to get your opinion if there's some reason not to do that, that we might have missed https://review.openstack.org/#/c/54025819:29
mriedemnice http://paste.openstack.org/show/719188/ shows that n-api doesn't barf when trying to delete allocations during server delete if the n-cpu is down and [placement] isn't configured19:29
*** pchavva has quit IRC19:34
imacdonnmriedem: FYI, in case you run into it somewhere .... after re-enabling UCA for Oracle ZFSSA CI, I hit this - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891315 - 'apt-get upgrade' installed a 'libnettle6 amd64 3.4-1~cloud0' (from the UCA), and i'm hoping that'll fix it19:42
openstackDebian bug 891315 in dnsmasq "[dnsmasq] libnettle6 dependency" [Normal,Fixed]19:42
*** liverpooler has quit IRC19:42
*** slaweq has joined #openstack-nova19:43
mriedemjgwentworth: https://review.openstack.org/#/c/557796/ lgtm, i'll +2 once you fix that typo19:43
jgwentworthmriedem: thanks19:44
mriedemimacdonn: which UCA?19:44
mriedempike or queens?19:44
imacdonnmriedem: queens ... it's devstack master19:44
mriedemimacdonn: haven't had any issues like that here https://review.openstack.org/#/c/554317/19:45
imacdonnmriedem: perhaps you got the new libnettle6 by some other means19:45
mriedemidk, infra builds the images19:45
imacdonnmriedem: OK, well, just a heads-up in case you see it19:45
mriedemack19:46
imacdonnother than that, ZFSSA CI seems to work (with multiattach) with the UCA19:46
mriedemoutstanding19:46
*** dklyle has quit IRC19:47
superdanjgwentworth: sure seems reasonable19:47
jgwentworthk, thanks19:48
*** wolverineav has quit IRC19:49
openstackgerritmelanie witt proposed openstack/nova-specs master: Document Rocky review priorities  https://review.openstack.org/55779619:49
*** wolverineav has joined #openstack-nova19:49
*** dklyle has joined #openstack-nova19:50
*** wolverineav has quit IRC19:53
mriedemany opinions on removing the redundant unit tests from tssurya's patch here? https://review.openstack.org/#/c/554920/10/nova/tests/unit/compute/test_host_api.py@439 the functional test in that change will now cover that19:56
openstackgerritJay Pipes proposed openstack/nova master: support multiple member_of qparams for GET /r-ps  https://review.openstack.org/56131519:57
leakypipessuperdan: that should help when we need >1 placement req filters...19:58
openstackgerritJay Pipes proposed openstack/nova master: support multiple member_of qparams for GET /r-ps  https://review.openstack.org/56131520:00
openstackgerritJay Pipes proposed openstack/nova master: support multiple member_of qparams for GET /r-ps  https://review.openstack.org/56131520:02
jgwentworthmriedem: yeah, seems like that unit test can go20:08
*** wolverineav has joined #openstack-nova20:08
*** felipemonteiro_ has joined #openstack-nova20:09
jgwentworthI don't see it covering anything additional unless I'm missing something20:09
*** wolverineav has quit IRC20:09
superdanleakypipes: that's implementing what we said int the spec revision right?20:09
*** wolverineav has joined #openstack-nova20:09
leakypipessuperdan: yessir20:10
superdancools20:10
*** felipemonteiro__ has joined #openstack-nova20:13
jgwentworthwow, assert_called_once() is a thing. *mind blown*20:16
*** felipemonteiro_ has quit IRC20:16
*** jackie-truong has joined #openstack-nova20:17
*** felipemonteiro_ has joined #openstack-nova20:18
*** felipemonteiro__ has quit IRC20:18
*** jmlowe_ has joined #openstack-nova20:22
*** jmlowe has quit IRC20:23
*** sridharg has quit IRC20:27
*** sar has joined #openstack-nova20:28
*** tbachman has joined #openstack-nova20:30
*** claudiub|2 has joined #openstack-nova20:30
*** wolverineav has quit IRC20:40
mriedemusing fixtures as context managers - put that in your bag of tricks too for when a test needs to conditionally use a fixture20:42
jgwentworthI think I've done that before already with MonkeyPatch fixture20:43
jgwentworthcause I'm cool like that20:43
mriedemunfortunately our api fixtures might not be setup properly to handle running them as fixtures...20:49
mriedemdagnabbit20:49
*** r-daneel has quit IRC20:49
*** ccamacho has quit IRC20:49
*** wolverineav has joined #openstack-nova20:50
*** fragatina has quit IRC20:50
mriedemcdent: i know you probably want to figure this out on your friday night, but it's not clear to me that we stop the wsgi app when PlacementFixture or OSAPIFixture tear down20:55
mriedemspecifically, i get a timeout b/c the request seems to hang on a connection error at L77 http://paste.openstack.org/show/719198/20:56
mriedemhttp://paste.openstack.org/show/719199/20:57
*** sdeath has quit IRC20:57
openstackgerritJackie Truong proposed openstack/nova master: Implement certificate_utils  https://review.openstack.org/47994921:01
*** germs has joined #openstack-nova21:01
*** germs has quit IRC21:01
*** germs has joined #openstack-nova21:01
*** awaugama has quit IRC21:02
jgwentworthjackie-truong: hey, thanks for the quick update :) I'm going through the last patch now and to peruse the tempest test logs. sorry for the delay on review21:05
jackie-truongjgwentworth: np! thanks :-)21:06
*** ccamacho has joined #openstack-nova21:06
*** germs has quit IRC21:06
*** sidx64_ has quit IRC21:13
*** sree has joined #openstack-nova21:14
*** esberglu has quit IRC21:15
*** sree has quit IRC21:19
openstackgerritJackie Truong proposed openstack/nova master: Add certificate validation docs  https://review.openstack.org/56015821:21
openstackgerritJackie Truong proposed openstack/nova master: Add certificate validation docs  https://review.openstack.org/56015821:22
*** felipemonteiro_ has quit IRC21:22
*** arvindn05 has quit IRC21:30
*** sdeath has joined #openstack-nova21:33
*** jackie-truong has quit IRC21:34
cdentmriedem: Imma gonna need you to parse that a bit more for me, or I can think harder about it some other time, but at the moment, I don't get what you're saying supposed to be happening there21:34
mriedemi'm just going to leave it as a note in my test for now,21:35
mriedembut in that test i'm using the placement fixture and the compute api fixture,21:35
*** dave-mccowan has quit IRC21:36
mriedembut i need the placement fixture to be used conditionally based on what i'm doing,21:36
*** arvindn05 has joined #openstack-nova21:36
mriedemso i use it when i'm creating a server because the compute service needs it, but then i don't want placement fixture in place when i delete the server21:36
mriedembut when i go to delete the server i get this weird connection error,21:36
mriedemso i'm not sure if/why the placement fixture is messing with the osapifixture21:36
mriedemi figured maybe the placement fixture isn't cleaning up after itself properly21:37
cdentthat a url for the compute api though?21:37
mriedemyeah21:38
mriedemMax retries exceeded with url: /v2.1/6f70656e737461636b20342065766572//servers/ee29ce1f-ca1e-4466-84cd-23d57bb7020621:38
*** slaweq has quit IRC21:38
cdentis there a check behind that compute api call for the placement api? that is, at that step of the game, how is placement involved?21:38
mriedemwsgi-intercept is working on unique endpoints between placement and osapifixture so i'm not sure how things could overlap21:38
*** slaweq has joined #openstack-nova21:39
cdentis there any asynchrony/eventlet/similar magic going on?21:39
mriedemthe delete flow in this patch now adds a call to the scheduler report client to delete allocations for the instance21:39
mriedemwhich i was hoping would bomb out and @safe_connect would handle it21:39
mriedemsince placement fixture wouldn't be in place when the server delete call happens21:39
mriedembut...it's likely trying to hit ksa...?21:40
*** evrardjp has quit IRC21:40
cdentif you push the code up somewhere and add me to the review I'll look at it tomorrow (eagerly even, because I'm curious)21:40
mriedemok; i might know how to do this w/o the ugly stub i've got in place too, will test21:41
cdentit's entirely possible there are some global bits in wsgi-intercept being naughty (it is old and gross)21:41
cdentand if we can find them that would be a nice fix21:41
cdentif nothing else, I'll play with the paste tomorrow21:42
mriedemit's bugging me so i'll have something up tonight most likely and just add yo uto the review21:43
cdentI'm going to not get sucked in for of fear of being glared at by family21:43
*** slaweq has quit IRC21:44
*** slaweq has joined #openstack-nova21:44
*** fragatina has joined #openstack-nova21:45
*** r-daneel has joined #openstack-nova21:46
* cdent waves goodnight21:47
*** cdent has quit IRC21:47
*** Tom-Tom has joined #openstack-nova21:50
*** mchlumsky has quit IRC21:53
openstackgerritMatt Riedemann proposed openstack/nova master: Block deleting compute services which are hosting instances  https://review.openstack.org/56067421:54
openstackgerritMatt Riedemann proposed openstack/nova master: Delete allocations from API if nova-compute is down  https://review.openstack.org/56070621:54
openstackgerritMatt Riedemann proposed openstack/nova master: Cleanup RP and HM records while deleting a compute service.  https://review.openstack.org/55492021:54
*** Tom-Tom has quit IRC21:55
*** burt has quit IRC22:04
*** icRobby has joined #openstack-nova22:04
*** avolkov has quit IRC22:05
*** r-daneel has quit IRC22:05
*** icRobby has quit IRC22:05
*** sdeath has quit IRC22:07
*** r-daneel has joined #openstack-nova22:09
*** slaweq has quit IRC22:10
*** linkmark has quit IRC22:12
*** esberglu has joined #openstack-nova22:20
*** esberglu has quit IRC22:21
*** vladikr_ has quit IRC22:25
*** itlinux has quit IRC22:27
*** sdague has quit IRC22:31
*** Guest78769 has quit IRC22:39
*** figleaf is now known as edleafe22:46
openstackgerritMerged openstack/nova master: Rename network.utils to network.linux_utils.  https://review.openstack.org/55919722:47
openstackgerritMerged openstack/nova master: Add microversion to support extra_specs in flavor API.  https://review.openstack.org/55415922:47
openstackgerritMerged openstack/nova stable/queens: Remove the branch specifier from the nova-multiattach job  https://review.openstack.org/56093122:47
openstackgerritMerged openstack/nova master: Skip placement on rebuild in same host  https://review.openstack.org/54635722:47
*** Sukhdev has joined #openstack-nova22:52
*** sar has quit IRC22:58
jgwentworthmriedem: fyi I see the ceph job on master is busted, looking into what's going on http://logs.openstack.org/49/479949/58/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/eecfbb1/logs/devstacklog.txt.gz#_2018-04-13_21_24_31_94723:00
jgwentworthI don't see anything wrong with that identity URL23:00
*** germs has joined #openstack-nova23:02
*** germs has quit IRC23:02
*** germs has joined #openstack-nova23:02
*** _ix has quit IRC23:04
*** germs has quit IRC23:06
*** hongbin has quit IRC23:13
*** Zames has joined #openstack-nova23:15
*** jgwentworth is now known as melwitt23:22
*** Zames has quit IRC23:23
lbragstadleakypipes: thanks for the review on https://review.openstack.org/#/c/553613/223:27
lbragstadi tried to answer some of your comments, but let me know if bits are still unclear23:28
*** wolverineav has quit IRC23:31
*** wolverineav has joined #openstack-nova23:32
lbragstadmelwitt: http://logs.openstack.org/49/479949/58/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/eecfbb1/logs/screen-keystone.txt.gz#_Apr_13_21_24_28_551060 looks new23:34
lbragstadlooks like a missing dependency of paste23:36
*** wolverineav has quit IRC23:36
*** bhagyashris has quit IRC23:40
*** hoonetorg has joined #openstack-nova23:45
*** gjayavelu has quit IRC23:45
openstackgerritEric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates  https://review.openstack.org/51775723:47
*** wolverineav has joined #openstack-nova23:47
*** wolverineav has quit IRC23:51
*** wolverin_ has joined #openstack-nova23:52
*** claudiub|2 has quit IRC23:52
melwittlbragstad: oh, thank you!23:53
melwittfor whatever reason, I didn't think to look in the keystone log. my bad23:54
lbragstadmelwitt: yep - not sure what would have caused that though?23:54
melwittyeah, that I don't know. it's really recent, started within the last couple of days I think23:54
*** Sukhdev has quit IRC23:54
lbragstadhuh23:54
lbragstadsounds like it's consistent?23:54
melwittI think it is, yeah. I've seen a few examples so far23:55
melwittI feel like something like this has happened before too and I can't remember what it was, of course23:55
melwittat least I have something to go on now, so I'll find it eventually23:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!