*** fragatina has quit IRC | 00:05 | |
*** liusheng has quit IRC | 00:07 | |
*** QianYu has quit IRC | 00:07 | |
*** fragatina has joined #openstack-nova | 00:09 | |
*** gouthamr has joined #openstack-nova | 00:09 | |
*** fragatina has quit IRC | 00:13 | |
*** gjayavel_ has quit IRC | 00:14 | |
*** hoangcx has joined #openstack-nova | 00:15 | |
*** edmondsw has joined #openstack-nova | 00:16 | |
*** Nisha_Agarwal has joined #openstack-nova | 00:20 | |
*** tbachman has joined #openstack-nova | 00:22 | |
*** edmondsw has quit IRC | 00:23 | |
*** edmondsw has joined #openstack-nova | 00:24 | |
*** tbachman_ has joined #openstack-nova | 00:24 | |
*** Nisha_Agarwal has quit IRC | 00:24 | |
*** zhurong has joined #openstack-nova | 00:27 | |
*** tbachman has quit IRC | 00:27 | |
*** tbachman_ is now known as tbachman | 00:27 | |
*** edmondsw has quit IRC | 00:28 | |
*** edmondsw has joined #openstack-nova | 00:29 | |
*** hshiina|afk is now known as hshiina | 00:29 | |
*** Dinesh_Bhor has joined #openstack-nova | 00:31 | |
*** edmondsw has quit IRC | 00:32 | |
*** edmondsw has joined #openstack-nova | 00:32 | |
*** edmondsw has quit IRC | 00:37 | |
*** felipemonteiro_ has joined #openstack-nova | 00:40 | |
*** gjayavelu has joined #openstack-nova | 00:43 | |
*** felipemonteiro_ has quit IRC | 00:46 | |
*** wolverin_ has quit IRC | 01:04 | |
*** wolverineav has joined #openstack-nova | 01:05 | |
*** jichen has joined #openstack-nova | 01:07 | |
*** wolverineav has quit IRC | 01:12 | |
*** zhaochao has joined #openstack-nova | 01:16 | |
*** Kevin_Zheng has joined #openstack-nova | 01:19 | |
*** yamahata has quit IRC | 01:19 | |
*** slaweq has joined #openstack-nova | 01:20 | |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 01:21 |
---|---|---|
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 01:21 |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240 | 01:21 |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340 | 01:21 |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344 | 01:21 |
*** takashin_ has joined #openstack-nova | 01:22 | |
*** jaypipes_ has joined #openstack-nova | 01:23 | |
*** takashin has quit IRC | 01:23 | |
*** jaypipes has quit IRC | 01:23 | |
*** slaweq has quit IRC | 01:25 | |
*** fragatina has joined #openstack-nova | 01:28 | |
*** zhurong has quit IRC | 01:29 | |
*** germs has quit IRC | 01:30 | |
*** germs has joined #openstack-nova | 01:30 | |
*** germs has quit IRC | 01:30 | |
*** germs has joined #openstack-nova | 01:30 | |
*** Tom-Tom has joined #openstack-nova | 01:33 | |
*** fragatina has quit IRC | 01:35 | |
*** Tom-Tom has quit IRC | 01:35 | |
*** dave-mccowan has joined #openstack-nova | 01:37 | |
*** tianhui has quit IRC | 01:38 | |
*** tianhui has joined #openstack-nova | 01:39 | |
*** AlexeyAbashkin has joined #openstack-nova | 01:39 | |
*** AlexeyAbashkin has quit IRC | 01:43 | |
*** gjayavelu has quit IRC | 01:45 | |
*** phuongnh has joined #openstack-nova | 01:48 | |
*** takashin_ has left #openstack-nova | 01:48 | |
*** takashin has joined #openstack-nova | 01:48 | |
*** Tom-Tom has joined #openstack-nova | 01:51 | |
*** markvoelker_ has joined #openstack-nova | 01:52 | |
*** blkart has joined #openstack-nova | 01:53 | |
*** markvoelker has quit IRC | 01:53 | |
*** salv-orl_ has joined #openstack-nova | 01:59 | |
*** dougshelley66 has quit IRC | 01:59 | |
*** dougshelley66 has joined #openstack-nova | 02:00 | |
*** dougshelley66 has quit IRC | 02:00 | |
*** dougshelley66 has joined #openstack-nova | 02:01 | |
*** jichen has quit IRC | 02:01 | |
*** dougshelley66 has quit IRC | 02:01 | |
*** dougshelley66 has joined #openstack-nova | 02:02 | |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova-specs master: Complex (Anti)-Affinity Policies https://review.openstack.org/546925 | 02:02 |
*** salv-orlando has quit IRC | 02:02 | |
*** dougshelley66 has quit IRC | 02:02 | |
*** dougshelley66 has joined #openstack-nova | 02:02 | |
*** dougshelley66 has quit IRC | 02:03 | |
*** tianhui has quit IRC | 02:04 | |
*** tianhui has joined #openstack-nova | 02:04 | |
*** jichen has joined #openstack-nova | 02:06 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | 02:06 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller https://review.openstack.org/347289 | 02:07 |
*** janki has joined #openstack-nova | 02:07 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/api/openstack/compute/test_hosts.py https://review.openstack.org/559266 | 02:07 |
*** hongbin_ has joined #openstack-nova | 02:10 | |
*** jchhatbar has joined #openstack-nova | 02:10 | |
*** salv-orl_ has quit IRC | 02:11 | |
*** janki has quit IRC | 02:12 | |
*** gcb has joined #openstack-nova | 02:13 | |
*** salv-orlando has joined #openstack-nova | 02:13 | |
*** takashin_ has joined #openstack-nova | 02:17 | |
*** takashin has quit IRC | 02:18 | |
*** salv-orlando has quit IRC | 02:20 | |
*** salv-orlando has joined #openstack-nova | 02:22 | |
*** jichen has quit IRC | 02:23 | |
*** jichen has joined #openstack-nova | 02:25 | |
*** masuberu has joined #openstack-nova | 02:27 | |
*** masber has quit IRC | 02:31 | |
*** stakeda has joined #openstack-nova | 02:39 | |
*** psachin has joined #openstack-nova | 02:42 | |
*** zhurong has joined #openstack-nova | 02:49 | |
*** harlowja_ has quit IRC | 02:53 | |
*** jichen has quit IRC | 02:53 | |
*** vivsoni has quit IRC | 02:56 | |
*** vivsoni has joined #openstack-nova | 02:58 | |
*** toabctl has quit IRC | 03:00 | |
*** zhaochao has quit IRC | 03:00 | |
*** zhaochao has joined #openstack-nova | 03:01 | |
*** sdeath has joined #openstack-nova | 03:04 | |
*** udesale has joined #openstack-nova | 03:08 | |
*** yinxq has joined #openstack-nova | 03:09 | |
*** takashin has joined #openstack-nova | 03:11 | |
*** jichen has joined #openstack-nova | 03:13 | |
openstackgerrit | Jackie Truong proposed openstack/python-novaclient master: Microversion 2.62 - Add trusted_image_certificates https://review.openstack.org/500396 | 03:13 |
*** takashin_ has quit IRC | 03:13 | |
*** esberglu has joined #openstack-nova | 03:18 | |
*** slaweq has joined #openstack-nova | 03:21 | |
*** harlowja has joined #openstack-nova | 03:22 | |
*** masuberu has quit IRC | 03:23 | |
*** Tom-Tom has quit IRC | 03:23 | |
*** Tom-Tom has joined #openstack-nova | 03:24 | |
*** slaweq has quit IRC | 03:26 | |
*** Tom-Tom has quit IRC | 03:29 | |
*** masuberu has joined #openstack-nova | 03:33 | |
*** nicolasbock has quit IRC | 03:34 | |
*** fragatina has joined #openstack-nova | 03:35 | |
*** masber has joined #openstack-nova | 03:35 | |
*** masuberu has quit IRC | 03:38 | |
*** bingqianglin has quit IRC | 03:57 | |
*** gaoyan has joined #openstack-nova | 04:09 | |
*** gaoyan has quit IRC | 04:10 | |
*** yamahata has joined #openstack-nova | 04:11 | |
*** hongbin_ has quit IRC | 04:11 | |
*** germs has quit IRC | 04:12 | |
*** gaoyan has joined #openstack-nova | 04:13 | |
openstackgerrit | Nguyen Hai proposed openstack/nova-specs master: Follow the new PTI for document build https://review.openstack.org/551802 | 04:14 |
*** jackie-truong has quit IRC | 04:14 | |
*** gaoyan has quit IRC | 04:16 | |
*** jchhatba_ has joined #openstack-nova | 04:18 | |
*** jchhatba_ has quit IRC | 04:19 | |
*** jchhatba_ has joined #openstack-nova | 04:19 | |
*** jchhatbar has quit IRC | 04:21 | |
*** zhurong has quit IRC | 04:21 | |
*** Nisha_Agarwal has joined #openstack-nova | 04:22 | |
*** hoonetorg has quit IRC | 04:27 | |
openstackgerrit | Michael Still proposed openstack/nova master: Use os.rename, not mv. https://review.openstack.org/562463 | 04:33 |
*** hoonetorg has joined #openstack-nova | 04:41 | |
*** vladikr has quit IRC | 04:45 | |
*** vladikr has joined #openstack-nova | 04:46 | |
openstackgerrit | Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437 | 04:46 |
openstackgerrit | Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439 | 04:46 |
openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | 04:46 |
*** takashin_ has joined #openstack-nova | 04:48 | |
*** abhishekk has joined #openstack-nova | 04:49 | |
*** takashin has quit IRC | 04:50 | |
openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 04:50 |
openstackgerrit | Jackie Truong proposed openstack/nova master: Plumb trusted_certs through libvirt driver image paths https://review.openstack.org/561262 | 04:50 |
openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 04:50 |
openstackgerrit | Jackie Truong proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158 | 04:50 |
*** rajinir has quit IRC | 04:50 | |
*** jchhatbar has joined #openstack-nova | 04:50 | |
*** harlowja has quit IRC | 04:52 | |
openstackgerrit | Michael Still proposed openstack/nova master: Move IVS VIF plugging into the new utilities module. https://review.openstack.org/557552 | 04:53 |
openstackgerrit | Michael Still proposed openstack/nova master: Move create_tap_dev to the new utility module. https://review.openstack.org/557835 | 04:53 |
openstackgerrit | Michael Still proposed openstack/nova master: Move set_vf_interface_vlan to the new utility module. https://review.openstack.org/558487 | 04:53 |
*** jchhatba_ has quit IRC | 04:53 | |
*** ratailor has joined #openstack-nova | 04:54 | |
*** takashin_ has left #openstack-nova | 04:57 | |
*** takashin has joined #openstack-nova | 04:58 | |
*** Dinesh_Bhor has quit IRC | 05:00 | |
*** bhujay has joined #openstack-nova | 05:05 | |
*** claudiub|2 has joined #openstack-nova | 05:10 | |
*** Dinesh_Bhor has joined #openstack-nova | 05:12 | |
*** annp has quit IRC | 05:15 | |
*** annp has joined #openstack-nova | 05:15 | |
*** links has joined #openstack-nova | 05:18 | |
*** udesale_ has joined #openstack-nova | 05:19 | |
*** yinxq has quit IRC | 05:19 | |
*** udesale has quit IRC | 05:19 | |
*** armaan has joined #openstack-nova | 05:20 | |
*** slaweq has joined #openstack-nova | 05:22 | |
*** Nisha_Agarwal has quit IRC | 05:23 | |
*** slaweq has quit IRC | 05:27 | |
*** elmaciej has joined #openstack-nova | 05:29 | |
*** jichen has quit IRC | 05:31 | |
*** jichen has joined #openstack-nova | 05:36 | |
*** zhurong has joined #openstack-nova | 05:37 | |
*** ccamacho has quit IRC | 05:38 | |
*** sridharg has joined #openstack-nova | 05:40 | |
*** sidx64 has joined #openstack-nova | 05:43 | |
*** armaan has quit IRC | 05:51 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154 | 05:53 |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Documents update for XAPI pool shared SR migration https://review.openstack.org/562482 | 05:53 |
*** TobbeCN has joined #openstack-nova | 05:57 | |
*** lajoskatona has joined #openstack-nova | 05:58 | |
*** itlinux has joined #openstack-nova | 06:02 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Documents update for XAPI pool shared SR migration https://review.openstack.org/562482 | 06:03 |
*** bhujay has quit IRC | 06:04 | |
*** bhujay has joined #openstack-nova | 06:04 | |
*** toabctl has joined #openstack-nova | 06:04 | |
melwitt | bauzas, lyarwood: could y'all please help go through and review stuff on stable/queens, stable/pike, and stable/ocata today for r-1? I'm going to propose releases by my EOD. thanks! | 06:09 |
*** itlinux has quit IRC | 06:09 | |
*** itlinux has joined #openstack-nova | 06:12 | |
*** armaan has joined #openstack-nova | 06:16 | |
*** sar has joined #openstack-nova | 06:16 | |
*** Tom-Tom has joined #openstack-nova | 06:16 | |
openstackgerrit | melanie witt proposed openstack/nova master: Add periodic task to clean expired console tokens https://review.openstack.org/325381 | 06:18 |
openstackgerrit | melanie witt proposed openstack/nova master: Use ConsoleAuthToken object to generate authorizations https://review.openstack.org/325414 | 06:18 |
openstackgerrit | melanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation https://review.openstack.org/333990 | 06:18 |
openstackgerrit | melanie witt proposed openstack/nova master: Update layout docs for running console proxies https://review.openstack.org/557489 | 06:18 |
*** bhujay has quit IRC | 06:20 | |
*** bhujay has joined #openstack-nova | 06:20 | |
*** pcaruana has joined #openstack-nova | 06:21 | |
*** ratailor has quit IRC | 06:23 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 7 https://review.openstack.org/560748 | 06:23 |
bauzas | melwitt: ack | 06:23 |
*** ratailor has joined #openstack-nova | 06:24 | |
*** ratailor has quit IRC | 06:24 | |
*** stakeda has quit IRC | 06:26 | |
*** sapd_ has joined #openstack-nova | 06:26 | |
*** sapd__ has quit IRC | 06:26 | |
*** ratailor has joined #openstack-nova | 06:26 | |
*** Dinesh_Bhor has quit IRC | 06:31 | |
*** itlinux has quit IRC | 06:32 | |
*** slaweq has joined #openstack-nova | 06:36 | |
*** itlinux has joined #openstack-nova | 06:37 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Documents update for XAPI pool shared SR migration https://review.openstack.org/562482 | 06:38 |
*** sidx64_ has joined #openstack-nova | 06:38 | |
*** slaweq_ has joined #openstack-nova | 06:39 | |
*** sidx64 has quit IRC | 06:40 | |
*** slaweq has quit IRC | 06:41 | |
*** dklyle has joined #openstack-nova | 06:41 | |
*** david-lyle has joined #openstack-nova | 06:41 | |
*** Dinesh_Bhor has joined #openstack-nova | 06:43 | |
*** sidx64 has joined #openstack-nova | 06:43 | |
*** sidx64_ has quit IRC | 06:44 | |
*** fanzhang_ is now known as fanzhang | 06:48 | |
yikun_ | @gmann, hey, I saw your reply in link: | 06:51 |
yikun_ | https://review.openstack.org/#/c/557145/12/nova/tests/functional/api_sample_tests/test_instance_actions.py@127 | 06:51 |
yikun_ | and I want to sure your means is: | 06:51 |
yikun_ | 1. we need put a sample file in common dir. | 06:52 |
yikun_ | 2. create a hard code python map to record the version section and sample maping | 06:52 |
yikun_ | 3. set the use_common_server_api_samples to true when I call the req func | 06:52 |
yikun_ | right? | 06:52 |
*** elmaciej has quit IRC | 06:54 | |
*** dims has quit IRC | 06:54 | |
*** do3meli has joined #openstack-nova | 06:55 | |
*** dims has joined #openstack-nova | 06:56 | |
*** ccamacho has joined #openstack-nova | 06:58 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add request_id to instance action notifications https://review.openstack.org/553288 | 06:59 |
*** dims has quit IRC | 07:01 | |
*** itlinux has quit IRC | 07:02 | |
gmann | yikun_: kind of but those cannot be in common dir as they are specific to microversion. server samples are commonly used in other tests so they were in common dir | 07:02 |
*** alexchadin has joined #openstack-nova | 07:02 | |
*** dims has joined #openstack-nova | 07:02 | |
gmann | yikun_: i need to think more that what can be more optimized and not too magic way | 07:03 |
*** hemna_ has quit IRC | 07:03 | |
gmann | yikun_: but for your change let's go back to the PS where you had 2.58 tests as base | 07:04 |
*** namnh has joined #openstack-nova | 07:05 | |
*** diga has joined #openstack-nova | 07:07 | |
yikun_ | gmann, yes, sure, I will update soon. | 07:07 |
*** mgoddard has joined #openstack-nova | 07:07 | |
yikun_ | and I will think about it too, and if you have some idea or I can offer you some help, don't hesitate to ping me. : ) | 07:08 |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient stable/pike: Use generic user for both zuul v2 and v3 https://review.openstack.org/562500 | 07:09 |
*** tesseract has joined #openstack-nova | 07:10 | |
*** Mr_Smurf has joined #openstack-nova | 07:12 | |
gmann | yikun_: sure thanks. | 07:12 |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient stable/pike: Use generic user for both zuul v2 and v3 https://review.openstack.org/562500 | 07:13 |
Mr_Smurf | I have some strange issues with live migration.. The instance is moved to the other hypervisor but ends up in error state and in the database it is on the wrong hypervisor. | 07:13 |
*** sidx64_ has joined #openstack-nova | 07:14 | |
*** sidx64 has quit IRC | 07:14 | |
Mr_Smurf | Anyone experienced something like this? | 07:14 |
Mr_Smurf | (openstack newton) | 07:14 |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add host/hostId to instance action events API https://review.openstack.org/557145 | 07:15 |
*** ociuhandu has joined #openstack-nova | 07:16 | |
*** fghaas has joined #openstack-nova | 07:17 | |
*** ociuhandu has quit IRC | 07:17 | |
*** zhurong has quit IRC | 07:18 | |
*** salv-orlando has quit IRC | 07:23 | |
*** salv-orlando has joined #openstack-nova | 07:24 | |
*** AlexeyAbashkin has joined #openstack-nova | 07:26 | |
*** gjayavelu has joined #openstack-nova | 07:26 | |
*** salv-orlando has quit IRC | 07:28 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Documents update for XAPI pool shared SR migration https://review.openstack.org/562482 | 07:31 |
*** amoralej|off is now known as amoralej | 07:32 | |
*** rcernin has quit IRC | 07:33 | |
*** salv-orlando has joined #openstack-nova | 07:37 | |
*** damien_r has joined #openstack-nova | 07:38 | |
*** jpena|off is now known as jpena | 07:39 | |
*** Nisha_Agarwal has joined #openstack-nova | 07:41 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Documents update for XAPI pool shared SR migration https://review.openstack.org/562482 | 07:41 |
*** pcaruana has quit IRC | 07:45 | |
*** pcaruana has joined #openstack-nova | 07:46 | |
*** yamahata has quit IRC | 07:49 | |
*** trinaths has joined #openstack-nova | 07:50 | |
*** sahid has joined #openstack-nova | 07:51 | |
gibi | Kevin_Zheng: hi! I left some comments in https://review.openstack.org/#/c/553288/20 | 07:55 |
Kevin_Zheng | gibi, Thanks I will fix them | 07:57 |
*** trinaths has quit IRC | 07:58 | |
Kevin_Zheng | very good comments :) | 07:58 |
gibi | Kevin_Zheng: just ping me when you push the fix and I will quickly re-review as this patch is really close now | 07:59 |
Kevin_Zheng | gibi, sure thanks | 08:00 |
openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: deprecate the config for image handler class path https://review.openstack.org/497201 | 08:00 |
*** sapd_ has quit IRC | 08:00 | |
*** gjayavelu has quit IRC | 08:00 | |
*** salv-orlando has quit IRC | 08:00 | |
*** sapd_ has joined #openstack-nova | 08:00 | |
*** salv-orlando has joined #openstack-nova | 08:01 | |
kashyap | takashin: Just FYI, I'll abandon this change: https://review.openstack.org/#/c/560365/ ("libvirt: Drop MIN_LIBVIRT_VIRTUOZZO_VERSION"), and the other two existing "Drop" constant series | 08:03 |
kashyap | takashin: As they're now merged into the top-level change: https://review.openstack.org/#/c/558783/ | 08:03 |
*** salv-orlando has quit IRC | 08:05 | |
*** mdbooth has joined #openstack-nova | 08:06 | |
*** damien_r has quit IRC | 08:06 | |
*** tssurya has joined #openstack-nova | 08:07 | |
*** damien_r has joined #openstack-nova | 08:08 | |
openstackgerrit | Merged openstack/nova-specs master: Handle nested providers for allocation candidates https://review.openstack.org/556873 | 08:08 |
*** phuongnh has quit IRC | 08:09 | |
*** phuongnh has joined #openstack-nova | 08:09 | |
*** bhujay has quit IRC | 08:10 | |
*** lucas-afk is now known as lucasagomes | 08:11 | |
*** alexchadin has quit IRC | 08:13 | |
takashin | kashyap: Than you for your notice. | 08:14 |
*** owalsh_afk is now known as owalsh | 08:16 | |
*** damien_r has quit IRC | 08:21 | |
*** damien_r has joined #openstack-nova | 08:22 | |
*** damien_r has quit IRC | 08:23 | |
*** damien_r has joined #openstack-nova | 08:23 | |
*** david-lyle has quit IRC | 08:23 | |
*** dklyle has quit IRC | 08:23 | |
*** avolkov has joined #openstack-nova | 08:27 | |
*** itlinux has joined #openstack-nova | 08:27 | |
kashyap | stephenfin: Morning, when you get a sec — | 08:28 |
kashyap | stephenfin: I think I can simply delete the "test_invalid_libvirt_version()" test now, post MIN libvirt / QEMU version bump: https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_rt_servers.py#L71,L95 | 08:29 |
kashyap | Given the failure here: http://logs.openstack.org/83/558783/10/check/nova-tox-functional/ac56391/testr_results.html.gz | 08:29 |
*** sidx64_ has quit IRC | 08:31 | |
openstackgerrit | Merged openstack/nova master: conf: Remove deprecated 'multi_instance_display_name_template' opt https://review.openstack.org/499612 | 08:31 |
*** sidx64 has joined #openstack-nova | 08:33 | |
*** vivsoni has quit IRC | 08:38 | |
*** derekh has joined #openstack-nova | 08:40 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Suggest when to propose notification changes https://review.openstack.org/562265 | 08:42 |
*** damien_r has quit IRC | 08:44 | |
*** damien_r has joined #openstack-nova | 08:45 | |
*** damien_r has quit IRC | 08:46 | |
*** damien_r has joined #openstack-nova | 08:47 | |
*** damien_r has quit IRC | 08:52 | |
openstackgerrit | Chen Hanxiao proposed openstack/nova master: _cleanup_resize: remove rbd swap disk if resize to flavor without swap https://review.openstack.org/534711 | 08:53 |
*** damien_r has joined #openstack-nova | 08:55 | |
*** vivsoni has joined #openstack-nova | 08:55 | |
*** damien_r has quit IRC | 08:56 | |
*** salv-orlando has joined #openstack-nova | 08:58 | |
*** Zames has joined #openstack-nova | 08:59 | |
*** trinaths has joined #openstack-nova | 09:00 | |
*** bhujay has joined #openstack-nova | 09:00 | |
*** damien_r has joined #openstack-nova | 09:00 | |
*** Zames has quit IRC | 09:02 | |
*** abalutoiu has joined #openstack-nova | 09:07 | |
*** itlinux has quit IRC | 09:09 | |
*** cdent has joined #openstack-nova | 09:09 | |
*** elmaciej has joined #openstack-nova | 09:21 | |
*** elmaciej_ has joined #openstack-nova | 09:23 | |
*** elmaciej has quit IRC | 09:26 | |
*** maciejjozefczyk has joined #openstack-nova | 09:30 | |
maciejjozefczyk | Hey :) | 09:31 |
*** Nisha_ has joined #openstack-nova | 09:32 | |
*** Nisha_Agarwal has quit IRC | 09:32 | |
openstackgerrit | Chris Dent proposed openstack/nova master: Add root and parent provider uuid to group by clause https://review.openstack.org/562379 | 09:34 |
*** Dinesh__Bhor has joined #openstack-nova | 09:34 | |
*** tuanla____ has joined #openstack-nova | 09:34 | |
*** Dinesh_Bhor has quit IRC | 09:36 | |
*** sdague has joined #openstack-nova | 09:38 | |
*** trinaths has quit IRC | 09:42 | |
*** salv-orl_ has joined #openstack-nova | 09:43 | |
*** salv-orlando has quit IRC | 09:47 | |
*** damien_r has quit IRC | 09:51 | |
*** damien_r has joined #openstack-nova | 09:53 | |
*** damien_r has quit IRC | 09:55 | |
*** armaan has quit IRC | 09:55 | |
*** armaan has joined #openstack-nova | 09:55 | |
*** damien_r has joined #openstack-nova | 09:59 | |
*** dougshelley66 has joined #openstack-nova | 09:59 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 10:01 |
*** namnh has quit IRC | 10:05 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" https://review.openstack.org/558783 | 10:07 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: Drop MIN_LIBVIRT_SET_ADMIN_PASSWD https://review.openstack.org/562312 | 10:07 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_PARALLELS_SET_ADMIN_PASSWD https://review.openstack.org/562313 | 10:07 |
*** sambetts|afk is now known as sambetts | 10:09 | |
*** fghaas1 has joined #openstack-nova | 10:10 | |
*** fghaas has quit IRC | 10:13 | |
*** ygl has joined #openstack-nova | 10:15 | |
ygl | hi all | 10:17 |
ygl | can anyone explain to me how to find out the flavor id for an instance from the nova database ? | 10:17 |
*** jichen has quit IRC | 10:19 | |
*** liverpooler has joined #openstack-nova | 10:19 | |
openstackgerrit | zhangyangyang proposed openstack/nova master: Deprecate auth_uri option https://review.openstack.org/562537 | 10:26 |
ygl | can anyone help me please with my query | 10:30 |
ygl | I want to find out the flavor id for an instance from the nova database | 10:30 |
*** fghaas has joined #openstack-nova | 10:32 | |
*** liverpooler has quit IRC | 10:33 | |
*** bhujay has quit IRC | 10:33 | |
*** fghaas1 has quit IRC | 10:34 | |
*** Tom-Tom has quit IRC | 10:37 | |
*** xinliang has quit IRC | 10:39 | |
*** sar has quit IRC | 10:40 | |
*** abhishekk has quit IRC | 10:40 | |
*** fghaas has quit IRC | 10:41 | |
*** fghaas has joined #openstack-nova | 10:41 | |
*** Dinesh__Bhor has quit IRC | 10:43 | |
*** Dinesh__Bhor has joined #openstack-nova | 10:43 | |
*** ygl has quit IRC | 10:44 | |
*** Dinesh__Bhor has quit IRC | 10:47 | |
*** mvk has quit IRC | 10:47 | |
*** tbachman has quit IRC | 10:49 | |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Support inherit api samples in ApiSampleTestBase https://review.openstack.org/562547 | 10:50 |
*** xinliang has joined #openstack-nova | 10:51 | |
*** nicolasbock has joined #openstack-nova | 10:57 | |
yikun_ | ^ @gmann I'm not sure it's a best solution or not, but it is a way to solve our problem at least. | 10:58 |
*** jpena is now known as jpena|lunch | 10:59 | |
yikun_ | gmann, you could take a look when u have time. :) https://review.openstack.org/562547 | 10:59 |
*** armaan has quit IRC | 10:59 | |
*** armaan has joined #openstack-nova | 10:59 | |
*** sar has joined #openstack-nova | 11:00 | |
*** phuongnh has quit IRC | 11:00 | |
*** mdbooth has quit IRC | 11:06 | |
*** pchavva has joined #openstack-nova | 11:10 | |
*** vivsoni has quit IRC | 11:14 | |
Kevin_Zheng | gibi are you around? | 11:17 |
*** vivsoni has joined #openstack-nova | 11:19 | |
gibi | Kevin_Zheng: yes | 11:20 |
Kevin_Zheng | I almost done the coding, but again, there are some problems with the tests | 11:21 |
gibi | Kevin_Zheng: you can push the patch up then I can take a look at it and might be able to help with the test | 11:22 |
Kevin_Zheng | as you guys left in the comments, I suppose to adding req_id for instance update notifications and not include it for periodic tasks | 11:22 |
*** zhurong has joined #openstack-nova | 11:22 | |
Kevin_Zheng | which matt suggested using the judgement of whether context.auth_token is present | 11:23 |
*** Nisha_away has joined #openstack-nova | 11:23 | |
Kevin_Zheng | since we use noauth middleware | 11:23 |
Kevin_Zheng | there will always be no context.auth | 11:23 |
Kevin_Zheng | https://github.com/openstack/nova/blob/324899c621ee02d877122ba3412712ebb92831f2/nova/api/openstack/auth.py#L57 | 11:23 |
Kevin_Zheng | I will put it up if I cannot come up with ideas before I go | 11:24 |
gibi | Kevin_Zheng: your understanding seems correct to me | 11:24 |
Kevin_Zheng | maybe we shouldn't judge by authtoken | 11:25 |
Kevin_Zheng | because if someone is actually using Noauth middleware, he will always got no req_id in the notification | 11:26 |
gibi | Kevin_Zheng: then we have to find another way to distinguish between context from a periodic task and another normal context | 11:26 |
gibi | Kevin_Zheng: let me dig a bit | 11:26 |
Kevin_Zheng | Thanks | 11:26 |
*** Nisha_ has quit IRC | 11:27 | |
*** abhishekk has joined #openstack-nova | 11:28 | |
*** hshiina is now known as hshiina|afk | 11:29 | |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Return all resources in provider_summaries https://review.openstack.org/558045 | 11:31 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Return all nested providers in tree https://review.openstack.org/559480 | 11:31 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Return resource providers without inventories https://review.openstack.org/559554 | 11:31 |
*** vladikr has quit IRC | 11:32 | |
*** vladikr has joined #openstack-nova | 11:32 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add request_id to instance action notifications https://review.openstack.org/553288 | 11:34 |
*** lucasagomes is now known as lucas-hungry | 11:35 | |
*** dougshelley66 has quit IRC | 11:36 | |
kashyap | Are others hitting these IBM zVM CI failures too: http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-16984/console.html | 11:36 |
kashyap | It is all: "Exceeded maximum number of retries. Exhausted all hosts available for retrying build failures for instance" | 11:37 |
*** armaan has quit IRC | 11:37 | |
*** mdbooth has joined #openstack-nova | 11:38 | |
Kevin_Zheng | gibi Hi, I got it, maybe I should use (context.is_admin and not context.auth_token) rather than just context.auth_token | 11:41 |
*** vivsoni has quit IRC | 11:42 | |
gibi | Kevin_Zheng: I think that is a partial solution. If the deployer use NoAuth and the user is an admin or the non admin context is elevated somewhere in the code path then your condition will be true | 11:43 |
Kevin_Zheng | yeah | 11:43 |
*** mvk has joined #openstack-nova | 11:44 | |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Support inherit api samples in ApiSampleTestBase https://review.openstack.org/562547 | 11:50 |
gibi | the NoAuth set user_id and project_id but the get_admin_context() call used by the periodic task set them to None | 11:51 |
*** psachin has quit IRC | 11:52 | |
Kevin_Zheng | Hmm | 11:52 |
gibi | Kevin_Zheng: so instead of checking for the auth_token you can check the project_id and user_id | 11:52 |
Kevin_Zheng | Let me try | 11:52 |
openstackgerrit | Merged openstack/osc-placement master: RP list: member_of and resources parameters (v1.3, v1.4) https://review.openstack.org/511183 | 11:54 |
*** sar has quit IRC | 11:54 | |
*** swamireddy has quit IRC | 11:57 | |
*** sar has joined #openstack-nova | 11:58 | |
*** armaan has joined #openstack-nova | 12:00 | |
*** mriedem has joined #openstack-nova | 12:00 | |
*** sidx64 has quit IRC | 12:01 | |
*** psachin has joined #openstack-nova | 12:01 | |
*** tuanla____ has quit IRC | 12:02 | |
*** jpena|lunch is now known as jpena | 12:02 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add request_id to instance action notifications https://review.openstack.org/553288 | 12:02 |
Kevin_Zheng | gibi ^ done | 12:02 |
gibi | Kevin_Zheng: thanks, looking | 12:03 |
*** sidx64 has joined #openstack-nova | 12:04 | |
mriedem | lyarwood: bauzas: today is rocky-1 and i think melwitt wanted to do some stable branch releases too - stable/ocata has a bunch of patches which need a final +2 if you can go through those https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/ocata | 12:05 |
*** Nisha_away has quit IRC | 12:05 | |
gibi | Kevin_Zheng: you have to update the comment in https://review.openstack.org/#/c/553288/22/nova/notifications/objects/instance.py@124 | 12:05 |
*** amoralej is now known as amoralej|lunch | 12:06 | |
bauzas | mriedem: yup, I reviewed the queens branch this morning and I was about to look at the pike and ocata branches this afternoon ;) | 12:06 |
*** dougshelley66 has joined #openstack-nova | 12:07 | |
*** Guest4072 has quit IRC | 12:07 | |
*** yassine has joined #openstack-nova | 12:07 | |
*** yassine is now known as Guest58458 | 12:08 | |
Kevin_Zheng | gibi maybe shouldn't write about auth_token anymore? | 12:08 |
gibi | Kevin_Zheng: I'm OK with that too | 12:09 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add request_id to instance action notifications https://review.openstack.org/553288 | 12:10 |
gibi | Kevin_Zheng: but then we have to explain in the commit message that we could not simply use the auth_token as Matt suggested | 12:10 |
Kevin_Zheng | ...really? just updated | 12:10 |
*** armaan has quit IRC | 12:11 | |
*** swamireddy has joined #openstack-nova | 12:12 | |
*** QianYu has joined #openstack-nova | 12:13 | |
gibi | Kevin_Zheng: or we can tell mriedem on IRC so he will know why we not used context.auth_token ;) | 12:13 |
*** QianYu has quit IRC | 12:14 | |
*** QianYu has joined #openstack-nova | 12:14 | |
Kevin_Zheng | gibi I like this one | 12:15 |
mriedem | i don't think anyone uses NoAuthMiddleware in production fwiw | 12:15 |
mriedem | or shouldn't | 12:15 |
Kevin_Zheng | yeah well, judging by project_id and user_id could work right? | 12:17 |
*** armaan has joined #openstack-nova | 12:17 | |
Kevin_Zheng | in the tests, we have admin actions so (is_admin and not auth_token) cannot work as well | 12:18 |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient master: [CLI] Fix token auth type https://review.openstack.org/424256 | 12:18 |
gibi | mriedem: still our functional env uses NoAuth which means if the code checks for the auth_token then our functional tests become useless | 12:18 |
gibi | mriedem: and checking for project_id and user_id seems meaningful for me as if the request comes from the user, then those should be set on the context and that also means a proper request_id is also set | 12:19 |
mriedem | yeah that's fine | 12:19 |
mriedem | an appropriate follow up for this is probably putting a helper method on the RequestContext itself to tell if it's a real user request | 12:20 |
mriedem | we have RequestContext.is_user_context but that returns False if is_admin is True | 12:21 |
*** yamamoto_ has quit IRC | 12:21 | |
gibi | mriedem: I think the appropriate follow up is to merge https://review.openstack.org/#/c/524306 which means we have a proper request_id for periodic tasks as well and therefore we can remove the check from the payload generation | 12:21 |
*** armaan has quit IRC | 12:22 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: only increment disk address unit for scsi devices https://review.openstack.org/561613 | 12:22 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 7 https://review.openstack.org/560748 | 12:23 |
openstackgerrit | sahid proposed openstack/nova master: compute: introduce cpu_shared_set option https://review.openstack.org/561912 | 12:23 |
openstackgerrit | sahid proposed openstack/nova master: libvirt: always pass emulator threads policy https://review.openstack.org/561913 | 12:23 |
openstackgerrit | sahid proposed openstack/nova master: libvirt: place emulator threads on CONF.cpu_shared_set https://review.openstack.org/510897 | 12:23 |
openstackgerrit | sahid proposed openstack/nova master: libvirt: update emulator threads docstring https://review.openstack.org/562565 | 12:23 |
*** liverpooler has joined #openstack-nova | 12:24 | |
openstackgerrit | Merged openstack/nova stable/queens: Add regression test for persisted RequestSpec.retry from failed resize https://review.openstack.org/560142 | 12:24 |
openstackgerrit | Merged openstack/nova stable/queens: Don't persist RequestSpec.retry https://review.openstack.org/560143 | 12:24 |
openstackgerrit | sahid proposed openstack/nova master: compute: introduce cpu_shared_set option https://review.openstack.org/561912 | 12:25 |
openstackgerrit | sahid proposed openstack/nova master: libvirt: always pass emulator threads policy https://review.openstack.org/561913 | 12:25 |
openstackgerrit | sahid proposed openstack/nova master: libvirt: place emulator threads on CONF.cpu_shared_set https://review.openstack.org/510897 | 12:25 |
openstackgerrit | sahid proposed openstack/nova master: libvirt: update emulator threads docstring https://review.openstack.org/562565 | 12:25 |
openstackgerrit | Merged openstack/nova stable/queens: List instances performace optimization https://review.openstack.org/561715 | 12:26 |
*** yamamoto has joined #openstack-nova | 12:27 | |
kashyap | mriedem: Morning, I think this is ready for some review: https://review.openstack.org/#/c/558783/ -- libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" | 12:28 |
kashyap | mriedem: I'd like to build other compat code clean-up patches based on the above | 12:28 |
kashyap | Which is the bulk of the change | 12:28 |
kashyap | (Also my eyes are a bit hazy after arriving at that patch iterating a couple of weeks. A fresh pair of eyes taking a look at it would be nice.) | 12:30 |
mriedem | kashyap: i can put it in a tab for now | 12:31 |
kashyap | Merci. Some look at it and comments will give me a bit more push to fix whatever stuff reviewers might find. | 12:31 |
*** sidx64 has quit IRC | 12:32 | |
*** lucas-hungry is now known as lucasagomes | 12:33 | |
lyarwood | mriedem: ack will do | 12:33 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 7 https://review.openstack.org/560748 | 12:33 |
*** sidx64 has joined #openstack-nova | 12:34 | |
openstackgerrit | sahid proposed openstack/nova-specs master: fix blueprint related to the spec overhead-pin-set https://review.openstack.org/561916 | 12:34 |
*** AlexeyAbashkin has quit IRC | 12:34 | |
*** AlexeyAbashkin has joined #openstack-nova | 12:36 | |
*** edmondsw has joined #openstack-nova | 12:38 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add request_id to instance action notifications https://review.openstack.org/553288 | 12:40 |
*** lyan has joined #openstack-nova | 12:42 | |
*** lyan is now known as Guest54827 | 12:42 | |
*** zhurong has quit IRC | 12:43 | |
openstackgerrit | Merged openstack/nova stable/queens: Document how to disable notifications https://review.openstack.org/561954 | 12:44 |
openstackgerrit | Merged openstack/nova stable/queens: libvirt: Report the allocated size of preallocated file based disks https://review.openstack.org/562074 | 12:44 |
*** sar has quit IRC | 12:45 | |
sahid | mriedem: about your comment on the trusted tag we are going to erase, i let a comment in the review | 12:45 |
sahid | https://review.openstack.org/#/c/562565/ | 12:46 |
sahid | i think there are some condition where that could be an issue | 12:46 |
mriedem | sahid: wrong patch? | 12:52 |
sahid | mriedem: yep sorry https://review.openstack.org/#/c/458820/ | 12:57 |
*** mchlumsky has joined #openstack-nova | 12:58 | |
*** ratailor has quit IRC | 12:59 | |
*** jaypipes_ has quit IRC | 13:01 | |
*** jaypipes has joined #openstack-nova | 13:02 | |
*** jaypipes is now known as leakypipes | 13:02 | |
*** armaan has joined #openstack-nova | 13:02 | |
*** tbachman has joined #openstack-nova | 13:03 | |
*** leakypipes is now known as jaypipes | 13:04 | |
*** esberglu has quit IRC | 13:05 | |
*** hoangcx has quit IRC | 13:06 | |
openstackgerrit | Matthew Booth proposed openstack/nova master: Rename recreate to evacuate in driver signatures https://review.openstack.org/560900 | 13:08 |
*** pchavva has quit IRC | 13:08 | |
*** tbachman has quit IRC | 13:08 | |
openstackgerrit | Lei Zhang proposed openstack/nova master: Improve check capacity sql https://review.openstack.org/561862 | 13:12 |
*** jistr is now known as jistr|mtg | 13:14 | |
*** markvoelker_ has quit IRC | 13:16 | |
*** Nisha_Agarwal has joined #openstack-nova | 13:17 | |
*** markvoelker has joined #openstack-nova | 13:18 | |
maciejjozefczyk | Guys, maybe you remember any problem related to metadata-agent and cloud-init during openstack upgrade? I heard about bugs like cleaning of instance ssh service keys during upgrades but I'm not able to track any details. | 13:20 |
*** AlexeyAbashkin has quit IRC | 13:23 | |
*** esberglu has joined #openstack-nova | 13:24 | |
*** AlexeyAbashkin has joined #openstack-nova | 13:25 | |
mriedem | sahid: replied | 13:25 |
mriedem | cdent: i guess we already had a postgresql job in nova's experimental queue | 13:25 |
mriedem | but that doesn't help you | 13:26 |
*** salv-orl_ has quit IRC | 13:27 | |
cdent | mriedem: yeah, looks like both jay and eric are happy to merge my fix without test proof | 13:27 |
cdent | which would require a functional environment running pg or a new tempest test | 13:28 |
cdent | I explored doing a functional pg environment locally but it quickly fell apart for reasons I couldn't care to figure out (at least not last night) | 13:28 |
sahid | mriedem: ok so you may have right, i thought about that hard-reboot thing but it seems i'm wrong i will build that env and re-put my head in that whole serie | 13:29 |
jaypipes | what did I mess up now? | 13:29 |
*** eharney has joined #openstack-nova | 13:30 | |
cdent | jaypipes: you're safe this time | 13:32 |
openstackgerrit | Chris Dent proposed openstack/nova master: Add root and parent provider uuid to group by clause https://review.openstack.org/562379 | 13:32 |
*** wolverineav has joined #openstack-nova | 13:33 | |
*** psachin has quit IRC | 13:33 | |
*** TobbeCN has quit IRC | 13:35 | |
*** TobbeCN has joined #openstack-nova | 13:36 | |
*** gryf has quit IRC | 13:36 | |
*** _gryf has joined #openstack-nova | 13:37 | |
*** wolverineav has quit IRC | 13:37 | |
*** _gryf has quit IRC | 13:37 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: Skip placement on rebuild in same host https://review.openstack.org/561015 | 13:38 |
*** _gryf has joined #openstack-nova | 13:38 | |
*** Tom-Tom has joined #openstack-nova | 13:38 | |
*** _gryf is now known as gryf | 13:40 | |
*** TobbeCN has quit IRC | 13:40 | |
*** Tom-Tom has quit IRC | 13:43 | |
*** amoralej|lunch is now known as amoralej | 13:45 | |
*** hongbin_ has joined #openstack-nova | 13:46 | |
*** mlavalle has joined #openstack-nova | 13:51 | |
*** artom has joined #openstack-nova | 13:51 | |
*** AlexeyAbashkin has quit IRC | 13:52 | |
*** awaugama has joined #openstack-nova | 13:53 | |
mriedem | cdent: as in functional tests in-tree? you have to have the pg env setup, there is a script for it | 13:54 |
mriedem | nova/tools/test-setup.sh | 13:54 |
mriedem | sets up the openstack_citest creds for mysql and pg | 13:54 |
bauzas | efried: jaypipes: thanks for providing the explanations about granular groups | 13:55 |
bauzas | efried: jaypipes: fine with me about defaulting 400 if you don't provide the qparam | 13:56 |
bauzas | mriedem: I guess you running the meeting ? | 13:56 |
bauzas | or gibi? | 13:56 |
efried | bauzas: ack. Does the "global" any|isolate option give you enough control to do what you need to do for NUMA? | 13:56 |
bauzas | efried: I think so yeah | 13:56 |
gibi | bauzas: I talked to melwitt yesterday and she said she will run it today | 13:56 |
efried | bauzas: It seems like it should: user who doesn't care about topo uses `any`; user who does care uses `isolate` | 13:56 |
bauzas | efried: I provided two qpery parameters | 13:56 |
jaypipes | efried: should be any|isolate|same, right? | 13:57 |
bauzas | efried: one would be the one you discussed | 13:57 |
melwitt | nova meeting in 3 minutes | 13:57 |
efried | jaypipes: If you want two granular groups to go into the same provider, you should combine them into a single numbered group. | 13:57 |
bauzas | efried: the second was 'in_tree' | 13:57 |
*** AlexeyAbashkin has joined #openstack-nova | 13:57 | |
bauzas | efried: so I think it answers one of two | 13:57 |
efried | bauzas: We need to discuss that one further. | 13:57 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: libvirt: slow live-migration to ensure network is ready https://review.openstack.org/557930 | 13:57 |
cdent | mriedem: how do the functional tests become aware of that stuff? as in how does the new database string get connected to the code? that's the part I was struggling to make go. (simply overrdingn the default db connection string fell on its face) | 13:58 |
bauzas | efried: jaypipes: fine if I'm discussing that qpuery param by my own spec ? | 13:58 |
bauzas | efried: jaypipes: I tihnk we don't need a separate one | 13:58 |
efried | bauzas: As I stated somewhere or other, we can't use the keyword "in_tree" because that already has implications for GET /resource_providers to return *all* the providers in the same tree as the specified RP. | 13:58 |
bauzas | efried: I don't remember which exact param name I used but got it | 13:58 |
mriedem | cdent: i've always been confused by the framework for this, but you'd have to figure out how TestNovaMigrationsPostgreSQL works | 13:58 |
efried | bauzas: Also, it's not sufficient to say "same subtree" in any form, because we need an indication of where that subtree "starts". | 13:58 |
bauzas | efried: mmm k | 13:59 |
mriedem | the oslo.db opportunistic tests only run if a given backend is configured | 13:59 |
efried | bauzas: I did explain this further in one of the ML notes, but it was kinda buried. Let me find it... | 13:59 |
cdent | mriedem: i'll see if I can wrap my brain around that while vagueing out during the meeting | 13:59 |
*** arvindn0_ has joined #openstack-nova | 14:01 | |
cdent | wooph, some serious magic going on here | 14:01 |
openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Suggest when to propose notification changes https://review.openstack.org/562265 | 14:02 |
*** rajinir has joined #openstack-nova | 14:02 | |
efried | bauzas: this one, scroll about 3/4 of the way down: http://lists.openstack.org/pipermail/openstack-dev/2018-April/129511.html | 14:03 |
Nisha_Agarwal | hi, I have stable pike setup where i was trying nova boot for ironic nodes. It always give "OrphanedObjectError" as soon as it spawns the thread for deploy. This happens due to the context getting set to None at some point. After debugging we found context is set to None here https://github.com/openstack/nova/blob/stable/pike/nova/objects/instance.py#L824 | 14:03 |
bauzas | efried: sorry, was probably not enough caffeinated | 14:03 |
bauzas | or my French | 14:03 |
bauzas | -ETOOMUCHWORDS | 14:04 |
Nisha_Agarwal | When i just comment out this line ironic deploy goes through successfully, | 14:04 |
Nisha_Agarwal | i tried on two Pike setups, i see this behaviour consistently | 14:04 |
efried | Dis-moi si tu veux que je l'explique en français :) | 14:04 |
*** Tom-Tom has joined #openstack-nova | 14:05 | |
Nisha_Agarwal | should i go ahead and raise bug against nova? | 14:05 |
Nisha_Agarwal | mriedem, ^^^^ | 14:07 |
*** jackie-truong has joined #openstack-nova | 14:07 | |
*** yamahata has joined #openstack-nova | 14:09 | |
*** Spaz-Work has quit IRC | 14:09 | |
*** Spazmotic has joined #openstack-nova | 14:10 | |
*** jistr|mtg is now known as jistr | 14:10 | |
*** nicolasbock has quit IRC | 14:10 | |
*** Spazmotic has quit IRC | 14:14 | |
*** artom has quit IRC | 14:15 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add request_id to instance action notifications https://review.openstack.org/553288 | 14:15 |
sahid | dansmith: arg... unsupported configuration: Unknown interface <driver name='vhost-user'> | 14:15 |
mriedem | Nisha_Agarwal: do you have the latest fixes for pike? | 14:16 |
Nisha_Agarwal | mriedem, yes | 14:16 |
sahid | it's not really like libvirt ignores the driver name... only way to make it working is to avoid passing name attribute | 14:17 |
dansmith | sahid: that's really unfortunate... I guess I should push to see more real testing... | 14:17 |
Nisha_Agarwal | i have pulled all the patches for stable/pike | 14:17 |
*** fghaas has left #openstack-nova | 14:17 | |
sahid | dansmith: nothing is merged | 14:17 |
dansmith | sahid: I know, I mean before +2ing.. I expected you were testing these other configs locally before review | 14:18 |
sahid | i expected to have that env with DPDK ready before the final +2+W | 14:18 |
sahid | i'm going to fix the issue in libvirt but for nova i guess we should just avoid using name attribute for vhostuser interface | 14:19 |
*** AlexeyAbashkin has quit IRC | 14:23 | |
dansmith | sean-k-mooney[m]: are there jobs anywhere in neutron or experimental that use vhost/vhostuser that we can depends-on changes like this to get at least a smoke test? | 14:24 |
*** AlexeyAbashkin has joined #openstack-nova | 14:25 | |
*** abhishekk has quit IRC | 14:28 | |
*** armaan has quit IRC | 14:28 | |
jaypipes | sahid: quick update needed on https://review.openstack.org/#/c/562565/ commit message and then I'm +2 on the whole series. | 14:28 |
*** pchavva has joined #openstack-nova | 14:30 | |
*** zhaochao has quit IRC | 14:30 | |
sahid | jaypipes: cool, i will fix that, thanks | 14:30 |
Nisha_Agarwal | mriedem, then i will go ahhead n raise the defect? | 14:30 |
mriedem | Nisha_Agarwal: i'm in a meeting so don't have time to investigate this, nor the ironic background, so for tracking it yes if you want to report a bug that's fine | 14:32 |
openstackgerrit | Merged openstack/nova stable/ocata: Avoid unnecessary lazy-loads in mutated_migration_context https://review.openstack.org/515581 | 14:32 |
openstackgerrit | Merged openstack/nova stable/ocata: Only attempt a rebuild claim for an evacuation to a new host https://review.openstack.org/550560 | 14:32 |
*** eharney_ has joined #openstack-nova | 14:32 | |
*** eharney has quit IRC | 14:35 | |
*** AlexeyAbashkin has quit IRC | 14:40 | |
*** AlexeyAbashkin has joined #openstack-nova | 14:42 | |
*** markvoelker has quit IRC | 14:47 | |
*** markvoelker has joined #openstack-nova | 14:48 | |
openstackgerrit | zhangyangyang proposed openstack/nova master: Deprecate auth_uri option https://review.openstack.org/562537 | 14:49 |
*** salv-orlando has joined #openstack-nova | 14:51 | |
*** sidx64 has quit IRC | 14:54 | |
*** AlexeyAbashkin has quit IRC | 14:54 | |
*** AlexeyAbashkin has joined #openstack-nova | 14:56 | |
*** do3meli has quit IRC | 14:59 | |
stephenfin | jaypipes, bauzas: Tell me more about https://review.openstack.org/#/c/557065/2/specs/rocky/approved/vgpu-rocky.rst | 15:00 |
stephenfin | jaypipes, bauzas: That's a very similar issue we have for NUMA-aware vSwitch | 15:01 |
bauzas | it's about configuring things | 15:01 |
stephenfin | I've been trying to get dynamic '[physnet_$PHYSNET_NAME]' groups created on the fly but oslo.config isn't designed that way | 15:01 |
bauzas | stephenfin: yeah I remember your spec | 15:01 |
stephenfin | So what I've done is ugly enough to not even push to Gerrit, heh https://github.com/stephenfin/nova/commit/b2c0421e64d627aaad2cf9ac71c6e1c79357a970 | 15:02 |
bauzas | looks like we're limited for describing resources or topologies | 15:02 |
bauzas | stephenfin: the problem is that oslo.config is pretty freeform | 15:02 |
bauzas | stephenfin: and IMHO the pci whitelist is a terrible interface | 15:03 |
*** artom has joined #openstack-nova | 15:03 | |
stephenfin | Right, well I'd be interested in figuring out what you do. I don't think what I have is good enough so I'm open to ideas | 15:03 |
stephenfin | Until then, I'll probably revert back to a JSON option just so I can proceed | 15:04 |
*** TobbeCN has joined #openstack-nova | 15:04 | |
*** AlexeyAbashkin has quit IRC | 15:04 | |
jaypipes | stephenfin: dansmith is gonna hate that. | 15:05 |
mriedem | stephenfin: as in StrOpt with serialized json? | 15:05 |
mriedem | i also hate that | 15:05 |
takashin | python-novaclient stable maintainers for pike, would you review https://review.openstack.org/#/c/562500/ ? This patch fixes pike gate job failure. | 15:05 |
mriedem | i would rather us load in a yaml file | 15:05 |
stephenfin | jaypipes: Oh, I'm not planning to keep it | 15:05 |
mriedem | if that's the alternative | 15:05 |
melwitt | takashin: I think you need to backport that to queens first, then to pike | 15:05 |
stephenfin | It just seems like we don't have a decided-upon alternative and I need to load _something_ | 15:06 |
mriedem | takashin: done | 15:06 |
dansmith | stephenfin: I thought I suggested the cinder model for encoding single-level dicts in config with sections? | 15:06 |
mriedem | melwitt: fix came from queens | 15:06 |
dansmith | it's stupid simple | 15:06 |
takashin | melwitt: it has already merged in queens. | 15:06 |
stephenfin | dansmith: Yeah, it seems horrible though -> https://github.com/stephenfin/nova/commit/b2c0421e64d627aaad2cf9ac71c6e1c79357a970 | 15:06 |
melwitt | mriedem, takashin: oh, okay. my bad | 15:06 |
takashin | mriedem: Thank you. | 15:07 |
stephenfin | dansmith: With cinder, they still know the group names ahead of time. We're having to build that based on another value | 15:07 |
stephenfin | It works, but it seem...wrong (IMO, anyway) | 15:07 |
*** Nisha_Agarwal has quit IRC | 15:07 | |
dansmith | stephenfin: eh? they let you set your own section names.. backend_foo and what not | 15:07 |
*** yikun_ has quit IRC | 15:07 | |
*** takashin has left #openstack-nova | 15:08 | |
*** AlexeyAbashkin has joined #openstack-nova | 15:08 | |
*** yikun_ has joined #openstack-nova | 15:08 | |
bauzas | dansmith: I don't have the context, what were you suggesting and do you think it could apply for https://review.openstack.org/#/c/557065/ ? | 15:08 |
*** TobbeCN has quit IRC | 15:08 | |
dansmith | bauzas: stephenfin: https://wiki.openstack.org/wiki/Cinder-multi-backend | 15:09 |
mriedem | bauzas: http://logs.openstack.org/54/554154/27/check/tempest-full/fbfe7c5/controller/logs/etc/cinder/cinder_conf.txt.gz | 15:09 |
mriedem | enabled_backends = lvmdriver-1 | 15:09 |
mriedem | [lvmdriver-1] | 15:09 |
dansmith | exactly that | 15:09 |
bauzas | I see | 15:10 |
bauzas | so dynamically importing opt groups ? | 15:10 |
mriedem | http://logs.openstack.org/54/554154/27/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/b88aa0b/logs/etc/cinder/cinder.conf.txt.gz for ceph | 15:10 |
stephenfin | dansmith: I need to figure out the heck that is working so. All I could find was this https://github.com/openstack/cinder/blob/master/cinder/volume/configuration.py | 15:10 |
stephenfin | and all calls to that were statically defined | 15:10 |
bauzas | mriedem: dansmith: okay, I need to consider that for https://review.openstack.org/#/c/557065/ | 15:10 |
stephenfin | dansmith, mriedem, bauzas: but yeah, my configuration was looking like this http://paste.openstack.org/show/719567/ | 15:10 |
stephenfin | think that was what was proposed in the review | 15:11 |
dansmith | stephenfin: right I think that's highly desirable over a separate yaml or json blob unless there's a really good reason not to | 15:11 |
stephenfin | dansmith: I concur | 15:11 |
mriedem | you could always....ask someone in -cinder about how that impl works | 15:12 |
dansmith | WAT | 15:12 |
*** Nil_ has joined #openstack-nova | 15:12 | |
dansmith | can you do that? | 15:12 |
mriedem | or if it can be shared into oslo.config so we can re-use it | 15:12 |
mriedem | remember oslo-incubator? | 15:12 |
stephenfin | but what if they're mean to me? | 15:12 |
mriedem | they are pretty nice | 15:12 |
mriedem | nicer than us | 15:12 |
mriedem | maybe...too nice | 15:12 |
*** yamamoto has quit IRC | 15:13 | |
*** yamamoto has joined #openstack-nova | 15:14 | |
bauzas | I have one terrible thought | 15:15 |
bauzas | if we say we want to configure things on the fly | 15:16 |
bauzas | wouldn't that be something in nova-manage ? | 15:16 |
* bauzas prepares for the tomatoes | 15:16 | |
stephenfin | bauzas: Isn't this stuff based on pretty static configuration though? | 15:16 |
stephenfin | I mean, unless you're hotplugging vGPUs/NICs | 15:17 |
bauzas | isn't the purpose of nova-manage to make nova aware of things that you want to set either once or multiple times ? | 15:17 |
*** tbachman has joined #openstack-nova | 15:17 | |
stephenfin | OK, solved it (the missing piece was knowing that 'enabled_backends' was where this was used) | 15:19 |
*** yamamoto has quit IRC | 15:19 | |
stephenfin | https://github.com/openstack/cinder/blob/master/cinder/cmd/volume.py#L161-L162 and https://github.com/openstack/cinder/blob/master/cinder/cmd/volume.py#L89 for anyone interested | 15:19 |
*** tssurya has quit IRC | 15:19 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Suggest when to propose notification changes https://review.openstack.org/562265 | 15:21 |
*** ccamacho has quit IRC | 15:23 | |
*** yamahata has quit IRC | 15:23 | |
*** germs has joined #openstack-nova | 15:24 | |
*** germs has quit IRC | 15:24 | |
*** germs has joined #openstack-nova | 15:24 | |
arvindn0_ | mriedem: i see you replied to https://review.openstack.org/#/c/560718/ | 15:25 |
arvindn0_ | any thoughts on the approach i proposed in the spec? | 15:25 |
*** Tom-Tom_ has joined #openstack-nova | 15:26 | |
*** elmaciej_ has quit IRC | 15:27 | |
arvindn0_ | trying to reduce the chance of encountering the rebuild bug...but cant seem to avoid the bug completely... | 15:28 |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Granular: group_policy={none|isolate} https://review.openstack.org/562687 | 15:28 |
*** lajoskatona has quit IRC | 15:29 | |
*** Tom-Tom has quit IRC | 15:29 | |
*** QianYu has quit IRC | 15:34 | |
*** yamamoto has joined #openstack-nova | 15:34 | |
openstackgerrit | sahid proposed openstack/nova master: libvirt: fix wrong driver name for vhostuser interface https://review.openstack.org/561562 | 15:35 |
openstackgerrit | sahid proposed openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes https://review.openstack.org/484997 | 15:35 |
openstackgerrit | sahid proposed openstack/nova master: libvirt: don't set interface backend for vhostuser https://review.openstack.org/562708 | 15:35 |
mriedem | arvindn0_: i will have to get to it later, but it's in the queue | 15:36 |
*** QianYu has joined #openstack-nova | 15:38 | |
arvindn0_ | got it. i put 2 alternatives in there along with why we may not want to go with them based on previous discussions..fyi | 15:38 |
*** PsionTheory has joined #openstack-nova | 15:38 | |
*** artom has quit IRC | 15:39 | |
*** arvindn0_ has quit IRC | 15:40 | |
*** armaan has joined #openstack-nova | 15:42 | |
*** ccamacho has joined #openstack-nova | 15:42 | |
*** ccamacho has quit IRC | 15:43 | |
*** tbachman_ has joined #openstack-nova | 15:43 | |
*** hemna_ has joined #openstack-nova | 15:43 | |
*** ccamacho has joined #openstack-nova | 15:43 | |
*** tbachman has quit IRC | 15:44 | |
*** tbachman has joined #openstack-nova | 15:45 | |
*** armaan has quit IRC | 15:47 | |
*** cdent has quit IRC | 15:47 | |
*** tbachman_ has quit IRC | 15:47 | |
*** armaan has joined #openstack-nova | 15:48 | |
*** cdent has joined #openstack-nova | 15:49 | |
*** Tom-Tom_ has quit IRC | 15:49 | |
*** dklyle has joined #openstack-nova | 15:52 | |
*** david-lyle has joined #openstack-nova | 15:52 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Network bandwidth resource provider https://review.openstack.org/502306 | 15:52 |
*** QianYu has quit IRC | 15:53 | |
*** dklyle_ has joined #openstack-nova | 15:53 | |
*** Nisha_Agarwal has joined #openstack-nova | 15:54 | |
*** AlexeyAbashkin has quit IRC | 15:55 | |
*** yamahata has joined #openstack-nova | 15:56 | |
*** AlexeyAbashkin has joined #openstack-nova | 15:56 | |
openstackgerrit | Merged openstack/nova master: Deduplicate notification samples Rocky - 7 https://review.openstack.org/560748 | 15:58 |
*** slaweq_ has quit IRC | 15:59 | |
*** mvk has quit IRC | 15:59 | |
*** slaweq has joined #openstack-nova | 15:59 | |
*** slaweq has quit IRC | 16:00 | |
*** slaweq has joined #openstack-nova | 16:00 | |
*** links has quit IRC | 16:01 | |
*** armaan has quit IRC | 16:02 | |
*** nicolasbock has joined #openstack-nova | 16:02 | |
*** pcaruana has quit IRC | 16:03 | |
*** felipemonteiro has joined #openstack-nova | 16:05 | |
*** fragatina has quit IRC | 16:05 | |
*** slaweq has quit IRC | 16:05 | |
*** ccamacho has quit IRC | 16:06 | |
*** sahid has quit IRC | 16:08 | |
openstackgerrit | zhangyangyang proposed openstack/nova master: Deprecate auth_uri option https://review.openstack.org/562537 | 16:09 |
openstackgerrit | Chris Friesen proposed openstack/nova stable/pike: libvirt: disconnect volume from host during detach https://review.openstack.org/560690 | 16:09 |
lyarwood | http://logs.openstack.org/04/516404/3/gate/legacy-tempest-dsvm-neutron-full/6d5d851/logs/screen-n-cpu.txt.gz?level=ERROR#_2018-04-19_14_41_33_712 - `AttributeError: 'NoneType' object has no attribute 'generation'` is leading to stable/ocata gate failures FWIW | 16:09 |
melwitt | urgh | 16:10 |
melwitt | how did that happen | 16:10 |
*** AlexeyAbashkin has quit IRC | 16:11 | |
lyarwood | https://review.openstack.org/#/c/525309/ maybe? | 16:12 |
lyarwood | efried: ^ any ideas? | 16:13 |
*** AlexeyAbashkin has joined #openstack-nova | 16:14 | |
*** itlinux has joined #openstack-nova | 16:19 | |
melwitt | hm, maybe. a resource provider is ending up as None | 16:19 |
*** QianYu has joined #openstack-nova | 16:20 | |
efried | lyarwood: looking... | 16:23 |
*** mvk has joined #openstack-nova | 16:25 | |
*** chyka has joined #openstack-nova | 16:27 | |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates https://review.openstack.org/517757 | 16:29 |
openstackgerrit | zhangyangyang proposed openstack/nova master: Deprecate auth_uri option https://review.openstack.org/562537 | 16:29 |
cfriesen | mriedem: melwitt: Do we want to address bug 1764556? If so, is there a better option than changing the online data migration in Pike to add UUIDs to deleted services? | 16:30 |
openstack | bug 1764556 in OpenStack Compute (nova) queens ""nova list" fails with exception.ServiceNotFound if service is deleted and has no UUID" [Medium,Confirmed] https://launchpad.net/bugs/1764556 | 16:30 |
cfriesen | it does require a pretty specific set of actions to reproduce | 16:30 |
efried | lyarwood: That does seem to be the only possible culprit. Haven't figured out how/why yet, though. | 16:31 |
efried | lyarwood: Can we propose a revert and see if it fixes? | 16:31 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/ocata: Revert "Proper error handling by _ensure_resource_provider" https://review.openstack.org/562739 | 16:33 |
lyarwood | efried: ^ sure, there you go | 16:33 |
efried | lyarwood: ack | 16:33 |
*** Alex_ has joined #openstack-nova | 16:33 | |
mriedem | does that cause CI failures or just ugly logs? | 16:33 |
mriedem | because https://review.openstack.org/#/c/525309/ itself didn't fail CI | 16:33 |
lyarwood | efried: and thanks, that was a guess given the change history tbh | 16:33 |
mriedem | cfriesen: we usually want to fix bugs | 16:34 |
efried | lyarwood: Right, I'm not basing my opinion on anything deeper at the moment. | 16:34 |
*** jchhatbar has quit IRC | 16:35 | |
lyarwood | mriedem: that last check run was in 2017 | 16:35 |
mriedem | lyarwood: it ran through the gate yesterday though | 16:35 |
lyarwood | mriedem: so maybe this change and another are causing this? | 16:35 |
lyarwood | mriedem: ah yeah true sorry | 16:36 |
mriedem | https://review.openstack.org/#/q/openstack/nova+status:merged+branch:stable/ocata | 16:36 |
*** QianYu has quit IRC | 16:37 | |
cfriesen | mriedem: just thought I'd check given the specific sequence of events needed. I appreciate the time you spent getting the functional test going. | 16:40 |
*** lucasagomes is now known as lucas-afk | 16:40 | |
efried | jeez, how far back could we go? Are we sure that same exception trace isn't showing up everywhere? | 16:40 |
openstackgerrit | Merged openstack/python-novaclient stable/pike: Use generic user for both zuul v2 and v3 https://review.openstack.org/562500 | 16:41 |
mriedem | it's not in http://logs.openstack.org/09/525309/1/gate/legacy-tempest-dsvm-neutron-full/ddcc396/logs/screen-n-cpu.txt.gz which was from the gate run | 16:42 |
mriedem | i don't see anything else remotely close to that same code though in here https://github.com/openstack/nova/commits/stable/ocata | 16:43 |
*** wolverineav has joined #openstack-nova | 16:43 | |
*** fragatina has joined #openstack-nova | 16:45 | |
melwitt | cfriesen: I agree we need to fix it, just not sure how yet | 16:46 |
cfriesen | I think tweaking the online data migration for services would prevent the one scenario we know about. the question is whether we need something to deal with clouds that have already upgraded to pike | 16:48 |
*** damien_r has quit IRC | 16:53 | |
melwitt | yeah. not sure | 16:54 |
*** mdbooth has quit IRC | 16:56 | |
*** AlexeyAbashkin has quit IRC | 16:57 | |
*** Nisha_Agarwal has quit IRC | 16:58 | |
*** Guest58458 has quit IRC | 16:59 | |
*** derekh has quit IRC | 17:01 | |
*** itlinux has quit IRC | 17:02 | |
*** Guest58458 has joined #openstack-nova | 17:03 | |
*** mgoddard has quit IRC | 17:03 | |
*** wolverineav has quit IRC | 17:05 | |
*** gjayavelu has joined #openstack-nova | 17:05 | |
*** wolverineav has joined #openstack-nova | 17:06 | |
*** cdent has quit IRC | 17:06 | |
*** gouthamr is now known as gouthamr|afk | 17:06 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add request_id to instance action notifications https://review.openstack.org/553288 | 17:08 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Leave a hint when populate_schema fails https://review.openstack.org/562757 | 17:08 |
*** artom has joined #openstack-nova | 17:08 | |
*** jpena is now known as jpena|off | 17:10 | |
*** wolverineav has quit IRC | 17:10 | |
*** cdent has joined #openstack-nova | 17:10 | |
*** artom_ has joined #openstack-nova | 17:12 | |
*** artom has quit IRC | 17:15 | |
*** wolverineav has joined #openstack-nova | 17:15 | |
*** sdeath has quit IRC | 17:19 | |
*** yamamoto has quit IRC | 17:20 | |
cfriesen | mriedem: for "Add request_id to instance action notifications", why are we bumping the version for nova / doc/notification_samples/common_payloads/InstanceActionPayload.json (and other similar ones where the version is the only change)? | 17:20 |
efried | cfriesen: base class? | 17:21 |
*** artom__ has joined #openstack-nova | 17:21 | |
efried | cfriesen: Sorry, to explain that comment: The request ID is being added in a base class, so all derived classes need to bump. | 17:22 |
*** artom_ has quit IRC | 17:24 | |
*** armaan has joined #openstack-nova | 17:24 | |
openstackgerrit | melanie witt proposed openstack/nova stable/ocata: Stop globally caching host states in scheduler HostManager https://review.openstack.org/539013 | 17:24 |
*** udesale_ has quit IRC | 17:24 | |
*** artom_ has joined #openstack-nova | 17:26 | |
*** efried has quit IRC | 17:26 | |
cfriesen | efried: okay, that makes sense. I missed the implications of the logical reference to InstancePayload.json in InstanceActionPayload.json | 17:28 |
melwitt | looks like the next PTG is gonna be at HOOOOONNNNNNKKKKKK again | 17:29 |
*** artom__ has quit IRC | 17:29 | |
cfriesen | they must have gotten a really good deal there | 17:31 |
jaypipes | melwitt: and double the price. | 17:31 |
melwitt | that too | 17:32 |
*** david-lyle has quit IRC | 17:32 | |
mriedem | remember, if your room is loud, make sure the window is closed | 17:32 |
edleafe | The Foundation doesn't think that developer productivity is worth spending money on | 17:32 |
jaypipes | apparently the train honking situation has been fixed. | 17:33 |
*** dklyle_ has quit IRC | 17:33 | |
*** dklyle has quit IRC | 17:33 | |
mriedem | "All aboard! Next stop Denver!" is pretty funny though | 17:33 |
jaypipes | indeed. | 17:33 |
*** awaugama has quit IRC | 17:35 | |
*** efried has joined #openstack-nova | 17:35 | |
*** patriciadomin has quit IRC | 17:35 | |
*** gigo has joined #openstack-nova | 17:36 | |
*** gigo has left #openstack-nova | 17:36 | |
*** munimeha1 has joined #openstack-nova | 17:36 | |
mriedem | well this doesn't look good http://grafana.openstack.org/dashboard/db/zuul-status?panelId=19&fullscreen | 17:37 |
efried | if you say so | 17:38 |
mriedem | is the total drop out normal? maybe it is. | 17:38 |
melwitt | what does taht mean | 17:39 |
*** wolverineav has quit IRC | 17:39 | |
mriedem | i've just been noticing that stuff is sitting in the queue for awhile | 17:39 |
mriedem | i'm watching lee's revert on ocata | 17:39 |
*** wolverineav has joined #openstack-nova | 17:39 | |
melwitt | yeah, online vs accepting. I would have thought online means "has the ability to accept" so the drop means things no longer being accepted. but why | 17:41 |
efried | Oh, I would have thought 0 means "we're all busy doing stuff right now" and the worrisome part would be when the line is all the way at the top ("there's nothing in the gate at the moment" - which does that ever happen, ever??) | 17:42 |
*** avolkov has quit IRC | 17:43 | |
*** wolverineav has quit IRC | 17:44 | |
*** efried has quit IRC | 17:44 | |
*** sridharg has quit IRC | 17:46 | |
*** chyka_ has joined #openstack-nova | 17:47 | |
melwitt | asking in -infra. inquiring minds want to know | 17:48 |
*** chyka has quit IRC | 17:50 | |
*** eharney_ is now known as eharney | 17:50 | |
*** sambetts is now known as sambetts|afk | 17:52 | |
*** mvk has quit IRC | 17:52 | |
*** fragatina has quit IRC | 17:53 | |
*** fragatina has joined #openstack-nova | 17:53 | |
*** efried has joined #openstack-nova | 17:53 | |
*** felipemonteiro_ has joined #openstack-nova | 17:55 | |
*** armaan has quit IRC | 17:56 | |
efried | dansmith: Not sure if you've been following the ML thread, but you're one likely to have a strong opinion, so can I pester you for the second nod? https://review.openstack.org/#/c/562687/ | 17:57 |
*** gouthamr|afk is now known as gouthamr | 17:57 | |
dansmith | efried: honestly I'm a little worn out on that stuff | 17:58 |
*** felipemonteiro has quit IRC | 17:59 | |
efried | dansmith: Aren't we all | 17:59 |
*** Nisha_Agarwal has joined #openstack-nova | 18:00 | |
*** slaweq has joined #openstack-nova | 18:01 | |
*** amoralej is now known as amoralej|off | 18:03 | |
*** slaweq has quit IRC | 18:06 | |
*** felipemonteiro__ has joined #openstack-nova | 18:08 | |
*** felipemonteiro_ has quit IRC | 18:08 | |
mriedem | arvindn05: done https://review.openstack.org/#/c/560718/ | 18:10 |
openstackgerrit | Merged openstack/nova stable/pike: ironic: Get correct inventory for deployed node https://review.openstack.org/561925 | 18:11 |
*** Guest58458 has quit IRC | 18:11 | |
*** Nisha_Agarwal has quit IRC | 18:14 | |
melwitt | this looks like something we might want to get in before novaclient release https://review.openstack.org/#/c/424256 | 18:17 |
melwitt | not sure if all the concerns from the -1 got answered, but it was updated this morning | 18:19 |
*** yamamoto has joined #openstack-nova | 18:20 | |
*** yikun__ has joined #openstack-nova | 18:25 | |
*** Guest58458 has joined #openstack-nova | 18:27 | |
*** yikun_ has quit IRC | 18:28 | |
*** yamamoto has quit IRC | 18:30 | |
melwitt | mriedem: wanna double check this osc-placement release patch pls? https://review.openstack.org/#/c/56278 | 18:33 |
mriedem | melwitt: wrong patch | 18:35 |
mriedem | https://review.openstack.org/#/c/562787/ | 18:35 |
mriedem | RIP hartsocks | 18:35 |
melwitt | aw | 18:36 |
melwitt | I failed at copy-pate | 18:36 |
melwitt | *paste | 18:36 |
melwitt | and typing | 18:36 |
*** TobbeCN has joined #openstack-nova | 18:36 | |
melwitt | efried, jaypipes: did y'all want to get these two things in before os-traits release today? https://review.openstack.org/546713 and https://review.openstack.org/553277 | 18:37 |
melwitt | or is it cool to just go ahead | 18:38 |
*** wolverineav has joined #openstack-nova | 18:38 | |
efried | It looks like we want gibi to sign off on the former | 18:38 |
*** TobbeCN has quit IRC | 18:41 | |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: [CLI] Fix token auth type https://review.openstack.org/424256 | 18:43 |
mriedem | melwitt: +2 on ^ | 18:44 |
melwitt | ack | 18:44 |
jaypipes | melwitt: can't merge https://review.openstack.org/#/c/546713/ until mriedem signs off in. The proposed supports_recreate capability would be changed to supports_evacuate by mdbooth's patch. | 18:47 |
mriedem | there is no supports_recreate capability in that os-traits patch | 18:47 |
jaypipes | melwitt: never mind... I forgot I didn't put supports_recreate in there. | 18:47 |
jaypipes | melwitt: either way, since I proposed the patch, someone else needs to +2. | 18:48 |
jaypipes | melwitt: as for the CPU max display heads one, I'm already +2 on it. | 18:49 |
jaypipes | GPU... | 18:49 |
*** AlexeyAbashkin has joined #openstack-nova | 18:49 | |
melwitt | yeah, I mean, were those two things important for the release today or are they fine to wait till a future release | 18:49 |
jaypipes | melwitt: I wouldn't mind having them merged. | 18:50 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Move some tests into nova.tests.unit.notifications.objects.test_instance https://review.openstack.org/562793 | 18:50 |
*** diga has quit IRC | 18:53 | |
*** tesseract has quit IRC | 18:55 | |
mriedem | jroll: does https://bugs.launchpad.net/nova/+bug/1765334 sound familiar to you as something we might have fixed already outside of https://review.openstack.org/#/c/518294/ ? | 18:55 |
openstack | Launchpad bug 1765334 in OpenStack Compute (nova) "Ironic resource class may not be put into inventory in Pike" [Undecided,New] | 18:55 |
mriedem | johnthetubaguy_: ^ | 18:55 |
*** AlexeyAbashkin has quit IRC | 18:59 | |
mriedem | looks like https://github.com/openstack/nova/commit/9ed692bf8c84e0a702536101cd6cb084d33e1c26#diff-6243ddf138dd43ec84fc716722531cb8 | 19:02 |
jroll | mriedem: sounds like 518294 might need a backport to pike? | 19:06 |
mriedem | eh, idk | 19:07 |
jroll | mriedem: or it's a race against the resource tracker | 19:07 |
melwitt | mriedem: novaclient release patch https://review.openstack.org/#/c/562804 | 19:07 |
mriedem | https://review.openstack.org/#/c/518294/ is specifically about resource inventory that's not in the compute node, only placement | 19:07 |
jroll | ah | 19:08 |
mriedem | in the case of this ironic bug on pike, it's a custom resource class that gets proxied into the node later | 19:08 |
mriedem | so rather than create the ironic node with a custom resource class, they create the node, then add the resource class, and that doesn't get reported, via nova (RT) into placement | 19:08 |
jroll | mriedem: don't think it's the commit you linked, though, that one is about nodes with instances, the bug is before an instance is places | 19:08 |
mriedem | because nova doesn't think that custom resource classes are something worth reporting for inventory i guess, unless a *known* inventory class changes, like VCPU, MEMORY_MB and DISK_GB | 19:08 |
mriedem | ah yeah | 19:09 |
mriedem | that's what i asked in the bug, is the node deployed or not which might make it different from dtantsur|pto's patch | 19:09 |
*** felipemonteiro_ has joined #openstack-nova | 19:09 | |
mriedem | "1. Always reporting the custom resource class for deployed nodes, if present." | 19:09 |
mriedem | so they need to always report custom resource class inventory regardless of node state | 19:10 |
mriedem | bleh, yay proxy fun | 19:10 |
*** felipemonteiro__ has quit IRC | 19:13 | |
mriedem | melwitt: was there something specifically in the novaclient changelog that made you think we should do a major version bump? | 19:14 |
melwitt | mriedem: the addition of the 2.61 microversion support. is that not necessarily a major version? | 19:15 |
mriedem | no, that's a feature | 19:15 |
mriedem | minor version bump | 19:15 |
melwitt | oh, guh. okay. | 19:16 |
*** wolverineav has quit IRC | 19:18 | |
*** wolverineav has joined #openstack-nova | 19:18 | |
mriedem | lbragstad: is this right? https://bugs.launchpad.net/nova/+bug/1765144 | 19:19 |
openstack | Launchpad bug 1765144 in OpenStack Compute (nova) "[keystone_authtoken] auth_url = http://controller:35357 port error, it should be 5000" [Undecided,New] | 19:19 |
lbragstad | mriedem: yes and no | 19:20 |
lbragstad | technically we removed the legacy v2.0 app in queens, so we no longer require two ports | 19:20 |
lbragstad | but it certainly don't have to be port 5000, or 35357 | 19:21 |
mriedem | yeah looking in http://logs.openstack.org/20/554920/12/check/tempest-full/df42a0d/controller/logs/etc/nova/nova_conf.txt.gz | 19:21 |
mriedem | we don't specify a port at all | 19:21 |
lbragstad | oh - sure v | 19:21 |
lbragstad | https://github.com/openstack/releases/blob/master/deliverables/queens/keystoneauth.yaml#L17 | 19:21 |
* lbragstad fails copy/paste | 19:21 | |
lbragstad | auth_url = https://198.72.124.213/identity | 19:22 |
mriedem | and auth_uri isn't specified at all | 19:22 |
mriedem | was auth_uri keystone v1/v2 only? | 19:22 |
*** sar has joined #openstack-nova | 19:23 | |
lbragstad | you should use auth_url | 19:23 |
lbragstad | auth_url and auth_uri was causing a lot of confusion | 19:23 |
lbragstad | so we renamed it https://github.com/openstack/keystonemiddleware/commit/409b482253dec248ed828e92e52b09d4c02e51dd | 19:23 |
lbragstad | it was ultimately a side-effect of integrating keystoneauth into keystonemiddleware | 19:24 |
*** wolverineav has quit IRC | 19:25 | |
*** wolverineav has joined #openstack-nova | 19:25 | |
mriedem | ok so the note at step 5 here https://docs.openstack.org/keystone/latest/install/keystone-install-ubuntu.html#install-and-configure-components | 19:27 |
mriedem | "Before the Queens release, keystone needed to be run on two separate ports to accommodate the Identity v2 API which ran a separate admin-only service commonly on port 35357. With the removal of the v2 API, keystone can be run on the same port for all interfaces." | 19:27 |
*** elmaciej has joined #openstack-nova | 19:28 | |
openstackgerrit | Merged openstack/nova stable/ocata: Clean up volumes on boot failure https://review.openstack.org/545086 | 19:28 |
mriedem | lbragstad: and i'm assuming that keystone-manage bootstrap creates the identity service endpoint in the catalog? | 19:28 |
lbragstad | it does | 19:28 |
mriedem | so if hte docs say "--bootstrap-public-url http://controller:5000/v3/" | 19:29 |
mriedem | then that's probably what the nova docs should use | 19:29 |
mriedem | or internal url i guess, but they are the same in the docs | 19:29 |
*** slaweq has joined #openstack-nova | 19:30 | |
mriedem | ok i'll push a change to fix the nova install guide docs to remove auth_uri and change auth_url to use port 5000 | 19:30 |
*** slaweq has quit IRC | 19:30 | |
mriedem | thanks | 19:30 |
*** awaugama has joined #openstack-nova | 19:31 | |
lbragstad | mriedem: cool - that's a good idea.. | 19:32 |
lbragstad | i just left a comment on that bug | 19:32 |
lbragstad | the only things is that people started noticing this when moving from one installation guide to another (and different services were referencing different ports) | 19:32 |
*** imacdonn has quit IRC | 19:36 | |
*** imacdonn has joined #openstack-nova | 19:36 | |
*** QianYu has joined #openstack-nova | 19:38 | |
mriedem | yeah. i've also always been confused by auth_uri and auth_url, glad i wasn't the only one | 19:38 |
melwitt | mriedem: nova queens 17.0.3 release patch https://review.openstack.org/#/c/562806 | 19:38 |
*** eharney has quit IRC | 19:39 | |
mriedem | lgtm | 19:40 |
*** QianYu has quit IRC | 19:42 | |
jaypipes | lol. turning off @safe_connect blows up unit tests but functional tests work just fine... | 19:48 |
jaypipes | turns out our unit tests are depending on the behaviour of safe_connect hiding placement connectivity problems. | 19:48 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Update docs for [keystone_authtoken] changes since Queens https://review.openstack.org/562812 | 19:50 |
*** inara has quit IRC | 19:52 | |
melwitt | I'm still +1 on https://review.openstack.org/#/c/560690 but bauzas had some concerns | 19:54 |
*** slaweq has joined #openstack-nova | 19:54 | |
*** inara has joined #openstack-nova | 19:54 | |
*** cdent has quit IRC | 19:55 | |
efried | jaypipes: I noticed something like that in https://review.openstack.org/#/c/562060/ (except my func tests failed too, obviously) | 19:57 |
mriedem | melwitt: i can't tell if bauzas is concerned about the encryption thing that was added, or because of the os-brick masssage-a-roo | 20:01 |
mriedem | *massage | 20:01 |
melwitt | I assumed both | 20:02 |
*** harlowja has joined #openstack-nova | 20:03 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: libvirt: disconnect volume from host during detach https://review.openstack.org/560690 | 20:04 |
melwitt | I think the fix itself is important, we had customers hit the problem and then cfriesen's org also hit the problem. and AFAIK what we did to handle the lack of refactoring stuff and os-brick non lower-constraints stuff was the proper thing to do | 20:05 |
*** wolverineav has quit IRC | 20:05 | |
mriedem | i don't disagree | 20:06 |
melwitt | *encryption refactoring | 20:06 |
mriedem | so https://review.openstack.org/#/c/562739/ passed except for an rpc messaging timeout in the live migration job | 20:08 |
mriedem | given stable/ocata is blocked otherwise, i think i'm going to just fast approve that revert | 20:08 |
*** sidx64_ has joined #openstack-nova | 20:09 | |
melwitt | k, makes sense | 20:10 |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates https://review.openstack.org/517757 | 20:10 |
mriedem | cfriesen: this might be something you can docify https://bugs.launchpad.net/nova/+bug/1764729 | 20:12 |
openstack | Launchpad bug 1764729 in OpenStack Compute (nova) "doc: live migration missing part about different cpu models/flags" [Medium,Confirmed] | 20:12 |
*** artom_ has quit IRC | 20:14 | |
*** jackie-truong has quit IRC | 20:26 | |
*** jackie-truong has joined #openstack-nova | 20:27 | |
jackie-truong | mriedem: For the trusted certs policy rules, since we're looking for a single admin_or_owner rule for all trusted certs related API calls, there's no need to split things up like this?: https://github.com/openstack/nova/blob/master/nova/policies/server_tags.py | 20:30 |
jackie-truong | Or are splitting individual calls up like that preferred? | 20:30 |
melwitt | dansmith: wanna send this in for novaclient stable/pike? fixes a user-facing error message https://review.openstack.org/#/c/562392 | 20:31 |
*** gyee has joined #openstack-nova | 20:32 | |
mriedem | jackie-truong: it's not really the same thing, tags are their own resource, we aren't implementing trusted_certs as a subresource on the server resource like that, i.e. POST /servers/{id}/trusted_certs | 20:32 |
openstackgerrit | Giridhar Jayavelu proposed openstack/nova-specs master: VMware: place instances on resource pool https://review.openstack.org/549067 | 20:33 |
mriedem | jackie-truong: so i think a single policy rule for allowing trusted_certs for POST /servers (server create) and POST /servers/{id}/action (rebuild) is ok | 20:33 |
dansmith | melwitt: done | 20:33 |
melwitt | thank ye | 20:33 |
mriedem | jackie-truong: furthermore, i don't think we need to apply the policy rule to omit 'trusted_certs' from the server response body, it would just always be empty if the user can't create a server with trusted certs | 20:34 |
efried | melwitt: Sending https://review.openstack.org/#/c/553277/ (sorry for the delay) | 20:34 |
openstackgerrit | Merged openstack/nova master: Use Queens UCA for nova-multiattach job https://review.openstack.org/554317 | 20:34 |
jackie-truong | mriedem: I think Nova API extension concept was removed in Pike: https://github.com/openstack/nova/commit/f2d18c2e9989f007a6576be6c9a6fcc5bcd67322 | 20:35 |
melwitt | efried: coolness, thanks | 20:35 |
mriedem | jackie-truong: ? i'm not talking about extensions | 20:35 |
jackie-truong | For example, security_groups policy rules are deprecated for POST /servers https://github.com/openstack/nova/blob/master/nova/policies/security_groups.py | 20:35 |
jackie-truong | Sorry, I'm confused | 20:36 |
mriedem | this is similar, imo, to os_compute_api:servers:attach_volume | 20:36 |
mriedem | which blocks boot from volume on server create, if for example, you don't have cinder in your cloud | 20:36 |
mriedem | if i don't have barbican, i can't support trusted certs | 20:36 |
mriedem | s/barbican/any castellan implementation' | 20:37 |
mriedem | heh looks like we don't have os_compute_api:servers:attach_volume documented | 20:38 |
mriedem | oh os_compute_api:servers:create:attach_volume | 20:38 |
mriedem | jackie-truong: yeah so i'd expect to see a policy rule like os_compute_api:servers:trusted_certs | 20:39 |
jackie-truong | oh okay, i see | 20:39 |
mriedem | use that for both server create and rebuild | 20:39 |
mriedem | and no need to check the policy rule on the response (in the view builder) | 20:39 |
*** sdeath has joined #openstack-nova | 20:39 | |
mriedem | if we wanted to get super granular we could have both os_compute_api:servers:create:trusted_certs and os_compute_api:servers:rebuild:trusted_certs | 20:40 |
mriedem | i do'nt know why we would need to, maybe edmondsw has a preference | 20:40 |
mriedem | he dreams about this stuff | 20:40 |
openstackgerrit | Merged openstack/nova stable/ocata: Refactor a test method including 3 test cases https://review.openstack.org/561603 | 20:41 |
edmondsw | lol | 20:41 |
mriedem | you know it's true, waking up in a sweat, | 20:41 |
edmondsw | why are we creating a policy for this? | 20:41 |
mriedem | "what was it honey? bad dream?" | 20:41 |
mriedem | "POLICY?!!?!" | 20:41 |
edmondsw | definitely a bad dream | 20:41 |
mriedem | edmondsw: http://lists.openstack.org/pipermail/openstack-dev/2018-April/129494.html | 20:42 |
edmondsw | I saw that, haven't gotten to replying... but seems more like a conf than policy thing | 20:42 |
dansmith | heh | 20:42 |
edmondsw | policy is when you want to allow some folks to do it but not others | 20:42 |
edmondsw | not when you want to enable/disable something entirely | 20:42 |
edmondsw | did I misunderstand? | 20:42 |
mriedem | well, | 20:43 |
dansmith | 🍿 | 20:43 |
jaypipes | zzzeek_: noticed this littering unit test output nowadays: http://paste.openstack.org/show/719587/. I'm actually not sure how to fix... any ideas? | 20:43 |
mriedem | consider you have some tenants that want/can do the trusted certs thing, | 20:43 |
mriedem | and you have those tenants tied to host aggregates via the tenant isolation multitenancy filter | 20:43 |
melwitt | well, can be both right? if one cloud wants to disable something but another wants to enable it, having it controlled by policy at least gives a consistent behavior where you can get 403 if you're not allowed or if that cloud doesn't allow | 20:43 |
mriedem | and you know those hosts are configured for cert validation | 20:44 |
mriedem | melwitt: yes | 20:44 |
mriedem | i'm looking for consistent api behavior with a 403 | 20:44 |
edmondsw | ok, so that's what I missed... you DO want to allow it for some folks and not for others in a single cloud | 20:44 |
melwitt | dansmith: good job putting emoji in here, didn't know we could do that | 20:44 |
dansmith | melwitt: really? cdent does it incessantly | 20:45 |
openstackgerrit | Merged openstack/os-traits master: GPU: define traits for maximum display heads https://review.openstack.org/553277 | 20:45 |
melwitt | oh, that checkmark thing. I have seen that | 20:45 |
edmondsw | dansmith cdent who wants to teach the rest of us? ;) | 20:45 |
dansmith | um.. paste? | 20:46 |
melwitt | but the popcorn has at least three colors in it | 20:46 |
edmondsw | oh, that simple | 20:46 |
dansmith | https://emojipedia.org/popcorn/ | 20:46 |
dansmith | click copy | 20:46 |
dansmith | then paste | 20:46 |
dansmith | it's like | 20:46 |
dansmith | rocket surgery | 20:46 |
edmondsw | lol | 20:46 |
melwitt | wah, that's hard | 20:46 |
zzzeek_ | jaypipes: this is the context for that: https://bitbucket.org/zzzeek/sqlalchemy/commits/63a7b2d2d940#chg-test/orm/test_evaluator.py | 20:47 |
zzzeek_ | jaypipes: it means you are doing query.update({Object.foo = column('bar')}) | 20:48 |
zzzeek_ | jaypipes: need to use the real Whereever.bar column. that was an error raise until nova caused a lot of failures :) | 20:48 |
zzzeek_ | jaypipes: *or*, dont use the "evaluate" strategy | 20:48 |
melwitt | 🍿<-- dazzling | 20:49 |
jaypipes | zzzeek_: I have no idea what that means :( | 20:49 |
*** sar has quit IRC | 20:49 | |
zzzeek_ | jaypipes: need to show me where you are caling query.update() | 20:49 |
melwitt | mriedem: looks like things are happy with this backport now. care to reapply +W? https://review.openstack.org/#/c/539013 | 20:50 |
*** eharney has joined #openstack-nova | 20:50 | |
jaypipes | zzzeek_: I'm not... it's literally appears thousands of times when I run the unit tests in nova. | 20:50 |
zzzeek_ | jaypipes: ok by "you" i mean, "you nova people" | 20:50 |
jaypipes | zzzeek_: fresh master checkout, nothing to do with my local changes. | 20:50 |
melwitt | *gasp* | 20:50 |
zzzeek_ | jaypipes: it's not related to your changes it's related to existing code in nova | 20:51 |
jaypipes | zzzeek_: ok. where we are calling query.update() or query.delete()? | 20:51 |
edmondsw | mriedem jackie-truong so I don't reallly have a strong opinion between 1) os_compute_api:servers:trusted_certs and 2) both os_compute_api:servers:create:trusted_certs and os_compute_api:servers:rebuild:trusted_certs | 20:51 |
edmondsw | at least not today :) | 20:51 |
mriedem | alright | 20:51 |
zzzeek_ | jaypipes: i dunno. maybe turn those warnigs into error raises and stacktrace will show | 20:51 |
zzzeek_ | jaypipes: unless nova is calling some other ORM-related application | 20:52 |
jackie-truong | edmondsw: Np. I went with option 2 | 20:52 |
edmondsw | I'd probably go granular, but there are pros and cons | 20:52 |
edmondsw | cool | 20:52 |
melwitt | gmann has a spec proposed for making policy more granular | 20:52 |
edmondsw | oh? | 20:52 |
edmondsw | I'll have to go find that | 20:53 |
melwitt | or consistently granular https://review.openstack.org/#/c/547850 | 20:53 |
melwitt | more granular | 20:53 |
* jaypipes curses unit test that aren't unit tests. | 20:54 | |
*** slaweq has quit IRC | 20:54 | |
mriedem | melwitt: hmm, how is https://review.openstack.org/#/c/539013/ passing if https://review.openstack.org/#/c/562739/ isn't merged yet? | 20:54 |
*** felipemonteiro_ has quit IRC | 20:54 | |
melwitt | mriedem: hah, good question | 20:54 |
*** slaweq has joined #openstack-nova | 20:54 | |
edmondsw | melwitt tx, added to my queue | 20:54 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: WIP Revert "Proper error handling by _ensure_resource_provider" https://review.openstack.org/562739 | 20:55 |
mriedem | melwitt: unless it's a race | 20:55 |
melwitt | yeah, might be. that would make more sense | 20:55 |
melwitt | ugh, hit the same on the ceph job on stable/ocata http://logs.openstack.org/30/511230/1/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/819c5da/logs/screen-n-cpu.txt.gz?level=TRACE | 20:57 |
melwitt | well, in trying to fix the ceph job on stable/ocata | 20:57 |
melwitt | that patch is what I thought would fix it, but then ran into the AttributeError: 'NoneType' object has no attribute 'generation' afterward | 20:58 |
*** slaweq has quit IRC | 20:59 | |
*** Shilpa has quit IRC | 21:03 | |
mriedem | ok that would explain how it slipped through the gate too | 21:05 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Revert "Proper error handling by _ensure_resource_provider" https://review.openstack.org/562739 | 21:06 |
*** pchavva has quit IRC | 21:07 | |
*** Shilpa has joined #openstack-nova | 21:08 | |
jackie-truong | mriedem: Do you just want the rules. Or also to enforce it when booting from volume? Or are we just relying on the fail message when booting from volume? | 21:10 |
mriedem | jackie-truong: the policy rule is separate from boot from volume | 21:11 |
mriedem | bfv is a flat out 400 when used with trusted_certs because it's not supported | 21:11 |
mriedem | the policy rule is for disabling the feature if your cloud can't support it, regardless of bfv | 21:11 |
jackie-truong | got it | 21:11 |
jackie-truong | And should the policy rule be a separate patch? | 21:11 |
jackie-truong | Or can I just plug it into the API patch? | 21:11 |
*** dougshelley66 has quit IRC | 21:12 | |
*** armaan has joined #openstack-nova | 21:14 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: fix a typo https://review.openstack.org/556455 | 21:15 |
dansmith | jackie-truong: kinda has to be in the api patch no? | 21:17 |
*** liverpooler has quit IRC | 21:17 | |
dansmith | otherwise you'd open it to everyone in one and then close it off in the next one | 21:17 |
*** dklyle has joined #openstack-nova | 21:17 | |
jackie-truong | dansmith: mmm yeah good point | 21:18 |
mriedem | this is a fun bug https://bugs.launchpad.net/nova/+bug/1761062 | 21:18 |
openstack | Launchpad bug 1761062 in OpenStack Compute (nova) " clean source instance directory failed in _cleanup_resize when images_type is rbd" [Undecided,New] | 21:18 |
mriedem | you red hat people might enjoy that one | 21:18 |
dansmith | doubtful | 21:18 |
*** sdeath has quit IRC | 21:19 | |
mriedem | you will enjoy it | 21:19 |
zzzeek_ | jaypipes: a simple grep is not finding it nova seems to use query.update() a lot with a bunch of abstraction on top of it | 21:20 |
zzzeek_ | jaypipes: would need to get a stack trace | 21:20 |
zzzeek_ | jaypipes: pdb into it and look for an unattached Column(), i have a feeling this might be local to the test suite | 21:21 |
melwitt | nooo not more ceph bugs | 21:24 |
*** sidx64_ has quit IRC | 21:27 | |
*** wolverineav has joined #openstack-nova | 21:29 | |
*** esberglu has quit IRC | 21:30 | |
jaypipes | zzzeek_: k, will try a bit later. | 21:39 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: xenapi: handle InstanceNotFound in detach_interface() https://review.openstack.org/562838 | 21:43 |
*** dougshelley66 has joined #openstack-nova | 21:44 | |
*** yamamoto has joined #openstack-nova | 21:49 | |
*** Tom-Tom has joined #openstack-nova | 21:50 | |
*** Tom-Tom has quit IRC | 21:54 | |
*** Guest54827 has quit IRC | 21:55 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Mention that users need noVNC >= 0.6 https://review.openstack.org/562847 | 22:01 |
openstackgerrit | Merged openstack/nova stable/pike: libvirt: Report the allocated size of preallocated file based disks https://review.openstack.org/562077 | 22:04 |
*** mchlumsky has quit IRC | 22:04 | |
*** jackie-truong has quit IRC | 22:07 | |
*** dklyle has quit IRC | 22:08 | |
*** liverpooler has joined #openstack-nova | 22:09 | |
*** liverpooler has quit IRC | 22:15 | |
*** awaugama has quit IRC | 22:17 | |
openstackgerrit | Merged openstack/python-novaclient stable/pike: Correct typo in deprecation for floating-ip commands https://review.openstack.org/562392 | 22:20 |
openstackgerrit | Merged openstack/python-novaclient master: [CLI] Fix token auth type https://review.openstack.org/424256 | 22:20 |
*** munimeha1 has quit IRC | 22:21 | |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates https://review.openstack.org/517757 | 22:22 |
*** mvk has joined #openstack-nova | 22:24 | |
openstackgerrit | Merged openstack/nova stable/pike: Add regression test for persisted RequestSpec.retry from failed resize https://review.openstack.org/560145 | 22:25 |
melwitt | hm, was just looking at this for our bug meeting tomorrow and noticed someone commented a couple of months ago that this was not fixed for them in ocata after all https://bugs.launchpad.net/nova/+bug/1670627 | 22:25 |
openstack | Launchpad bug 1670627 in OpenStack Compute (nova) ocata "quota is always in-use after delete the ERROR instances " [Critical,Fix released] - Assigned to Matt Riedemann (mriedem) | 22:25 |
mriedem | hmm | 22:27 |
mriedem | well | 22:27 |
mriedem | they also didn't really give any details | 22:27 |
mriedem | left a comment | 22:28 |
melwitt | yeah, I know. I just meant it sucks that there's still the bug after all those fixes we did. at least two people have run into it. I'll be able to get more detail from the internal bug too | 22:29 |
mriedem | well | 22:29 |
mriedem | how do we know that those people applied fixes correctly | 22:29 |
mriedem | or didn't hit something else | 22:29 |
mriedem | if they have 3 nova-apis running and only patched one... | 22:29 |
melwitt | maybe. in the internal bug case they're running ocata 15.0.8 | 22:30 |
melwitt | but yeah, not guaranteed it's really a problem, just looks like it is so far | 22:30 |
mriedem | i refuse to believe there are bugs | 22:30 |
*** rcernin has joined #openstack-nova | 22:30 | |
melwitt | okay :) | 22:30 |
melwitt | I could dust off my ocata devstack maybe | 22:32 |
melwitt | for a sanity check | 22:32 |
melwitt | I wonder if it might be something like, instances in ERROR state that were *not* in cell0. like, if the instance ERRORed for a reason other than failing to schedule | 22:33 |
*** chyka has joined #openstack-nova | 22:34 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Add `hide_hypervisor_id` flavor extra_spec https://review.openstack.org/555861 | 22:36 |
*** chyka_ has quit IRC | 22:37 | |
mriedem | yeah maybe, | 22:37 |
*** TobbeCN has joined #openstack-nova | 22:37 | |
mriedem | like that one you fixed, instance in error with no host b/c it failed to build in a cell | 22:37 |
*** mriedem is now known as mriedem_away | 22:38 | |
*** elmaciej_ has joined #openstack-nova | 22:40 | |
melwitt | yeah, I wonder if it's that actually | 22:40 |
*** elmaciej has quit IRC | 22:41 | |
melwitt | if that fix is needed to make things take the path that will decrement quota usage | 22:41 |
*** TobbeCN has quit IRC | 22:41 | |
*** sdague has quit IRC | 22:45 | |
*** edmondsw has quit IRC | 22:49 | |
*** edmondsw has joined #openstack-nova | 22:49 | |
*** Sukhdev has joined #openstack-nova | 22:49 | |
*** armaan has quit IRC | 22:50 | |
*** armaan has joined #openstack-nova | 22:50 | |
*** edmondsw has quit IRC | 22:53 | |
*** slaweq has joined #openstack-nova | 22:55 | |
*** hongbin_ has quit IRC | 22:57 | |
*** hshiina2 has joined #openstack-nova | 22:58 | |
*** hshiina3 has joined #openstack-nova | 22:59 | |
*** slaweq has quit IRC | 23:00 | |
*** hshiina|afk has quit IRC | 23:02 | |
melwitt | nah, instance in ERROR state after failing to build on a compute host should take this path, which would decrement usage https://github.com/openstack/nova/blob/stable/ocata/nova/compute/api.py#L1788-L1825 | 23:02 |
*** hshiina2 has quit IRC | 23:03 | |
*** Guest58458 has quit IRC | 23:05 | |
melwitt | (because the instance.host is set to None if build fails on compute) | 23:11 |
*** salv-orlando has quit IRC | 23:13 | |
*** salv-orlando has joined #openstack-nova | 23:13 | |
*** chyka_ has joined #openstack-nova | 23:15 | |
*** gjayavelu has quit IRC | 23:17 | |
*** chyka has quit IRC | 23:19 | |
*** chyka_ has quit IRC | 23:20 | |
*** hemna_ has quit IRC | 23:20 | |
openstackgerrit | Merged openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154 | 23:28 |
*** elmaciej_ has quit IRC | 23:35 | |
*** mlavalle has quit IRC | 23:36 | |
*** chyka has joined #openstack-nova | 23:41 | |
*** QianYu has joined #openstack-nova | 23:43 | |
*** takashin has joined #openstack-nova | 23:44 | |
*** chyka has quit IRC | 23:46 | |
openstackgerrit | Merged openstack/nova master: Improve check capacity sql https://review.openstack.org/561862 | 23:59 |
openstackgerrit | Merged openstack/nova stable/queens: libvirt: slow live-migration to ensure network is ready https://review.openstack.org/557930 | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!