Monday, 2018-06-04

*** GonZo2000 has joined #openstack-nova00:00
*** GonZo2000 has quit IRC00:00
*** GonZo2000 has joined #openstack-nova00:00
*** shaohe_feng has quit IRC00:00
*** shaohe_feng has joined #openstack-nova00:01
*** shaohe_feng has quit IRC00:11
*** shaohe_feng has joined #openstack-nova00:12
*** bigdogstl has joined #openstack-nova00:19
*** Tom-Tom has joined #openstack-nova00:20
*** shaohe_feng has quit IRC00:21
*** shaohe_feng has joined #openstack-nova00:22
*** bigdogstl has quit IRC00:24
*** Tom-Tom has quit IRC00:24
*** shaohe_feng has quit IRC00:31
*** shaohe_feng has joined #openstack-nova00:32
*** bigdogstl has joined #openstack-nova00:34
*** bigdogstl has quit IRC00:39
*** shaohe_feng has quit IRC00:41
*** shaohe_feng has joined #openstack-nova00:44
*** bigdogstl has joined #openstack-nova00:45
*** bigdogstl has quit IRC00:50
*** shaohe_feng has quit IRC00:52
*** GonZo2000 has quit IRC00:52
*** gbarros has joined #openstack-nova00:53
*** shaohe_feng has joined #openstack-nova00:53
*** GonZo2000 has joined #openstack-nova00:57
*** phuongnh has joined #openstack-nova01:01
*** shaohe_feng has quit IRC01:02
*** jichen has joined #openstack-nova01:02
*** shaohe_feng has joined #openstack-nova01:03
*** tiendc has joined #openstack-nova01:07
*** bigdogstl has joined #openstack-nova01:11
*** shaohe_feng has quit IRC01:12
*** shaohe_feng has joined #openstack-nova01:13
*** xinliang has quit IRC01:14
*** bigdogstl has quit IRC01:16
*** bigdogstl has joined #openstack-nova01:18
*** shaohe_feng has quit IRC01:22
*** bigdogstl has quit IRC01:23
*** shaohe_feng has joined #openstack-nova01:23
*** liuyulong__ has joined #openstack-nova01:25
*** liuyulong has joined #openstack-nova01:27
*** dpawlik has joined #openstack-nova01:27
*** mdnadeem has joined #openstack-nova01:27
*** liuyulong_ has quit IRC01:29
*** hongbin has joined #openstack-nova01:29
*** liuyulong__ has quit IRC01:29
*** xinliang has joined #openstack-nova01:30
*** weshay has quit IRC01:30
*** dpawlik has quit IRC01:32
*** zhaochao has joined #openstack-nova01:32
*** shaohe_feng has quit IRC01:33
*** shaohe_feng has joined #openstack-nova01:33
*** namnh has joined #openstack-nova01:34
*** bigdogstl has joined #openstack-nova01:35
*** weshay has joined #openstack-nova01:36
*** gongysh has joined #openstack-nova01:38
*** bigdogstl has quit IRC01:39
*** Tom-Tom has joined #openstack-nova01:40
*** germs has quit IRC01:40
*** germs has joined #openstack-nova01:41
*** germs has quit IRC01:41
*** germs has joined #openstack-nova01:41
*** shaohe_feng has quit IRC01:43
*** shaohe_feng has joined #openstack-nova01:47
*** yassine has joined #openstack-nova01:50
*** yassine is now known as Guest4663701:50
*** shaohe_feng has quit IRC01:53
*** bkopilov has quit IRC01:56
*** shaohe_feng has joined #openstack-nova01:56
*** hamzy has quit IRC01:56
*** hamzy has joined #openstack-nova01:56
*** shaohe_feng has quit IRC02:03
*** shaohe_feng has joined #openstack-nova02:04
*** yamamoto has joined #openstack-nova02:05
*** gbarros has quit IRC02:13
*** shaohe_feng has quit IRC02:14
*** shaohe_feng has joined #openstack-nova02:14
*** bigdogstl has joined #openstack-nova02:16
openstackgerrittianhui proposed openstack/nova master: Fix bug to filter_scheduler  https://review.openstack.org/57199802:20
*** bigdogstl has quit IRC02:20
*** shaohe_feng has quit IRC02:24
*** shaohe_feng has joined #openstack-nova02:25
*** bigdogstl has joined #openstack-nova02:29
*** liuyulong has quit IRC02:30
*** namnh has quit IRC02:33
*** bigdogstl has quit IRC02:34
*** shaohe_feng has quit IRC02:34
*** namnh has joined #openstack-nova02:34
*** sapd has joined #openstack-nova02:36
*** shaohe_feng has joined #openstack-nova02:37
*** bigdogstl has joined #openstack-nova02:39
*** gcb has joined #openstack-nova02:43
*** shaohe_feng has quit IRC02:44
*** gbarros has joined #openstack-nova02:46
*** shaohe_feng has joined #openstack-nova02:46
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver  https://review.openstack.org/52338702:46
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver  https://review.openstack.org/52765802:46
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add snapshot function  https://review.openstack.org/53424002:46
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add power actions  https://review.openstack.org/54334002:46
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add get console output  https://review.openstack.org/54334402:47
*** annp has joined #openstack-nova02:47
*** Dinesh_Bhor has joined #openstack-nova02:48
*** bigdogstl has quit IRC02:52
*** shaohe_feng has quit IRC02:55
*** shaohe_feng has joined #openstack-nova02:56
*** Guest46637 has quit IRC03:02
*** Guest46637 has joined #openstack-nova03:03
*** fragatina has joined #openstack-nova03:04
*** shaohe_feng has quit IRC03:05
*** shaohe_feng has joined #openstack-nova03:05
*** lifeless_ has joined #openstack-nova03:08
*** lifeless has quit IRC03:09
*** fragatina has quit IRC03:13
*** slaweq has joined #openstack-nova03:14
*** shaohe_feng has quit IRC03:15
*** Tom-Tom has quit IRC03:15
*** Tom-Tom has joined #openstack-nova03:16
*** shaohe_feng has joined #openstack-nova03:17
*** slaweq has quit IRC03:19
*** EmilienM has quit IRC03:22
*** gyankum has joined #openstack-nova03:22
*** Tom-Tom has quit IRC03:23
*** EmilienM has joined #openstack-nova03:23
*** sridharg has joined #openstack-nova03:24
*** gyankum has quit IRC03:24
*** shaohe_feng has quit IRC03:25
*** shaohe_feng has joined #openstack-nova03:27
*** lifeless has joined #openstack-nova03:29
*** lifeless_ has quit IRC03:29
*** pooja_jadhav has joined #openstack-nova03:30
*** bigdogstl has joined #openstack-nova03:31
*** bkopilov has joined #openstack-nova03:34
*** shaohe_feng has quit IRC03:36
*** shaohe_feng has joined #openstack-nova03:37
*** bigdogstl has quit IRC03:40
*** shaohe_feng has quit IRC03:46
*** shaohe_feng has joined #openstack-nova03:47
openstackgerrittianhui proposed openstack/nova master: Fix bug to filter_scheduler  https://review.openstack.org/57199803:49
*** Tom-Tom has joined #openstack-nova03:49
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add rules column to instance_group_policy table.  https://review.openstack.org/56083203:50
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object and api models.  https://review.openstack.org/56337503:50
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object  https://review.openstack.org/56340103:50
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Change the anti-affinity Filter to adapt to new policy  https://review.openstack.org/57116603:50
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model  https://review.openstack.org/57146503:50
*** Tom-Tom has quit IRC03:50
*** Tom-Tom has joined #openstack-nova03:50
*** bigdogstl has joined #openstack-nova03:52
*** udesale has joined #openstack-nova03:54
*** suresh12 has joined #openstack-nova03:56
*** shaohe_feng has quit IRC03:56
*** bigdogstl has quit IRC03:59
*** shaohe_feng has joined #openstack-nova04:00
*** vivsoni has joined #openstack-nova04:01
*** Nel1x has quit IRC04:06
*** shaohe_feng has quit IRC04:06
*** shaohe_feng has joined #openstack-nova04:07
*** jogo has quit IRC04:09
*** bkopilov has quit IRC04:15
*** shaohe_feng has quit IRC04:17
*** ivve has joined #openstack-nova04:17
*** msufiyan has joined #openstack-nova04:18
*** shaohe_feng has joined #openstack-nova04:18
*** bigdogstl has joined #openstack-nova04:22
*** jogo has joined #openstack-nova04:24
*** shaohe_feng has quit IRC04:27
*** bigdogstl has quit IRC04:27
*** Guest46637 has quit IRC04:29
*** gongysh has quit IRC04:31
*** shaohe_feng has joined #openstack-nova04:31
*** bkopilov has joined #openstack-nova04:34
*** germs has quit IRC04:34
*** bigdogstl has joined #openstack-nova04:37
*** shaohe_feng has quit IRC04:37
*** stakeda has joined #openstack-nova04:38
*** shaohe_feng has joined #openstack-nova04:39
*** hshiina|afk is now known as hshiina04:39
*** psachin has joined #openstack-nova04:41
*** Guest46637 has joined #openstack-nova04:43
*** hongbin has quit IRC04:44
*** gbarros has quit IRC04:45
*** abhishekk has joined #openstack-nova04:45
*** shaohe_feng has quit IRC04:47
*** bkopilov has quit IRC04:47
*** shaohe_feng has joined #openstack-nova04:48
*** shaohe_feng has quit IRC04:58
*** bigdogstl has quit IRC04:58
*** shaohe_feng has joined #openstack-nova04:59
*** bigdogstl has joined #openstack-nova05:02
*** Dinesh_Bhor has quit IRC05:03
*** dpawlik has joined #openstack-nova05:05
*** dpawlik has quit IRC05:05
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (1)  https://review.openstack.org/57201805:06
*** bigdogstl has quit IRC05:07
*** shaohe_feng has quit IRC05:08
*** shaohe_feng has joined #openstack-nova05:09
*** hamzy has quit IRC05:12
*** bigdogstl has joined #openstack-nova05:12
*** bigdogstl has quit IRC05:17
*** shaohe_feng has quit IRC05:18
*** shaohe_feng has joined #openstack-nova05:20
*** Tom-Tom has quit IRC05:23
*** bigdogstl has joined #openstack-nova05:25
*** Tom-Tom has joined #openstack-nova05:25
*** Tom-Tom has quit IRC05:25
*** Tom-Tom has joined #openstack-nova05:26
*** Tom-Tom has quit IRC05:26
*** ivve has quit IRC05:26
*** shaohe_feng has quit IRC05:28
*** suresh12 has quit IRC05:29
*** shaohe_feng has joined #openstack-nova05:29
*** Tom-Tom has joined #openstack-nova05:29
*** bigdogstl has quit IRC05:30
openstackgerritMerged openstack/nova stable/pike: libvirt: handle DiskNotFound during update_available_resource  https://review.openstack.org/57142605:31
openstackgerritMerged openstack/nova stable/pike: libvirt: Skip fetching the virtual size of block devices  https://review.openstack.org/57142705:31
*** udesale_ has joined #openstack-nova05:35
*** s1061123 has quit IRC05:36
*** s1061123 has joined #openstack-nova05:36
*** dpawlik has joined #openstack-nova05:37
*** dpawlik has quit IRC05:37
*** dpawlik has joined #openstack-nova05:37
*** udesale has quit IRC05:37
*** links has joined #openstack-nova05:38
*** shaohe_feng has quit IRC05:39
*** shaohe_feng has joined #openstack-nova05:40
*** dpawlik has quit IRC05:44
*** bigdogstl has joined #openstack-nova05:46
*** hoonetorg has joined #openstack-nova05:49
*** shaohe_feng has quit IRC05:49
*** shaohe_feng has joined #openstack-nova05:50
*** klindgren_ has joined #openstack-nova05:50
*** bigdogstl has quit IRC05:58
*** Dinesh_Bhor has joined #openstack-nova05:58
*** shaohe_feng has quit IRC05:59
*** shaohe_feng has joined #openstack-nova06:01
*** Luzi has joined #openstack-nova06:01
*** hamdyk has joined #openstack-nova06:04
*** takashin_ has joined #openstack-nova06:09
*** shaohe_feng has quit IRC06:09
*** takashin has quit IRC06:11
*** Eran_Kuris has joined #openstack-nova06:11
*** shaohe_feng has joined #openstack-nova06:13
*** udesale__ has joined #openstack-nova06:16
*** udesale_ has quit IRC06:18
*** klindgren_ has quit IRC06:19
*** shaohe_feng has quit IRC06:20
*** shaohe_feng has joined #openstack-nova06:20
*** kholkina has joined #openstack-nova06:21
*** Dinesh_Bhor has quit IRC06:25
*** kholkina has quit IRC06:25
*** Dinesh_Bhor has joined #openstack-nova06:27
*** shaohe_feng has quit IRC06:30
*** armaan has joined #openstack-nova06:30
*** shaohe_feng has joined #openstack-nova06:32
*** bigdogstl has joined #openstack-nova06:34
*** bigdogstl has quit IRC06:39
*** ccamacho has joined #openstack-nova06:40
*** shaohe_feng has quit IRC06:40
*** shaohe_feng has joined #openstack-nova06:42
*** wznoinsk has quit IRC06:43
openstackgerritjichenjc proposed openstack/nova master: Remove unused _disk_qcow2_to_raw  https://review.openstack.org/57202506:48
*** Tom-Tom has quit IRC06:48
*** wznoinsk has joined #openstack-nova06:48
*** Tom-Tom has joined #openstack-nova06:48
*** Tom-Tom has quit IRC06:49
*** Tom-Tom has joined #openstack-nova06:49
*** shaohe_feng has quit IRC06:50
*** shaohe_feng has joined #openstack-nova06:51
*** ispp has joined #openstack-nova06:53
openstackgerritjichenjc proposed openstack/nova master: Enhance api-guide general info some updates  https://review.openstack.org/56177306:53
*** myrat has joined #openstack-nova06:54
*** slaweq has joined #openstack-nova06:54
*** slaweq has quit IRC06:55
*** slaweq has joined #openstack-nova06:55
*** artom has joined #openstack-nova06:56
*** hiro-kobayashi has joined #openstack-nova06:57
*** liuzz has joined #openstack-nova06:58
*** shaohe_feng has quit IRC07:01
*** bigdogstl has joined #openstack-nova07:01
*** armaan has quit IRC07:01
*** shaohe_feng has joined #openstack-nova07:01
*** armaan has joined #openstack-nova07:02
*** sususuryashines has joined #openstack-nova07:04
openstackgerritjichenjc proposed openstack/nova master: Downgrade overquota warning  https://review.openstack.org/57202807:05
*** bigdogstl has quit IRC07:05
*** armaan has quit IRC07:07
*** andreas_s has joined #openstack-nova07:08
*** sususuryashines is now known as tssurya07:08
*** shaohe_feng has quit IRC07:11
*** ircuser-1 has quit IRC07:11
*** pcaruana has joined #openstack-nova07:12
*** shaohe_feng has joined #openstack-nova07:12
*** ratailor has joined #openstack-nova07:14
*** pcaruana is now known as pcaruana|worksho07:14
*** Dinesh__Bhor has joined #openstack-nova07:15
*** sapd_ has quit IRC07:15
*** sapd_ has joined #openstack-nova07:15
*** bigdogstl has joined #openstack-nova07:16
*** tesseract has joined #openstack-nova07:16
*** Dinesh_Bhor has quit IRC07:17
*** janki has joined #openstack-nova07:17
*** bigdogstl has quit IRC07:20
*** armaan has joined #openstack-nova07:21
*** shaohe_feng has quit IRC07:21
*** shaohe_feng has joined #openstack-nova07:22
*** takashin_ has left #openstack-nova07:23
openstackgerritjichenjc proposed openstack/nova master: Enhance api-guide general info some updates  https://review.openstack.org/56177307:23
*** takashin has joined #openstack-nova07:24
*** yamamoto has quit IRC07:24
*** Dinesh__Bhor has quit IRC07:26
*** giblet is now known as gibi07:27
gibigood mornin nova07:27
openstackgerritZhenyu Zheng proposed openstack/nova master: Use ThreadPoolExecutor for max_concurrent_live_migrations  https://review.openstack.org/56350507:27
*** suresh12 has joined #openstack-nova07:29
*** amoralej|off is now known as amoralej07:31
*** Dinesh__Bhor has joined #openstack-nova07:31
*** shaohe_feng has quit IRC07:31
openstackgerritZhenyu Zheng proposed openstack/nova master: Only run placement request filters when Placement will be called  https://review.openstack.org/56996907:33
*** suresh12 has quit IRC07:33
*** bigdogstl has joined #openstack-nova07:34
*** shaohe_feng has joined #openstack-nova07:34
*** AlexeyAbashkin has joined #openstack-nova07:35
*** sapd has quit IRC07:38
*** jistr is now known as jistr|mtgs07:38
*** sapd has joined #openstack-nova07:38
bauzasgibi: good morning07:38
*** bigdogstl has quit IRC07:39
*** shaohe_feng has quit IRC07:42
*** shaohe_feng has joined #openstack-nova07:42
*** tesseract-RH has joined #openstack-nova07:45
*** tesseract has quit IRC07:48
*** alexchadin has joined #openstack-nova07:48
*** tesseract-RH has quit IRC07:48
*** tesseract has joined #openstack-nova07:49
*** ttsiouts has joined #openstack-nova07:50
*** sahid has joined #openstack-nova07:52
*** shaohe_feng has quit IRC07:52
*** jangutter has joined #openstack-nova07:53
*** jpena|off is now known as jpena07:53
*** shaohe_feng has joined #openstack-nova07:53
*** ttsiouts has quit IRC07:53
*** pvc has joined #openstack-nova07:54
*** bigdogstl has joined #openstack-nova07:54
pvchi07:54
pvcwhere should i add this07:54
pvcsscheduler_default_filters = ..... ,PciPassthroughFilter07:54
*** ispp has quit IRC07:56
*** ttsiouts has joined #openstack-nova07:57
*** ispp has joined #openstack-nova07:58
*** bigdogstl has quit IRC07:59
gibipvc: to the nova.conf on the hosts where your nova-scheduler services are running08:00
pvcim using kolla then i add that on [default]08:00
*** shaohe_feng has quit IRC08:02
gibipvc: add it to the [scheduler] section08:02
pvcself._waiter.wait(msg_id, timeout) File "/var/lib/kolla/venv/lib/python2.7/site-packages/oslo_messaging/_drivers/amqpdriver.py", line 440, in wait message = self.waiters.get(msg_id, timeout=timeout) File "/var/lib/kolla/venv/lib/python2.7/site-packages/oslo_messaging/_drivers/amqpdriver.py", line 328, in get 'to message ID %s' % msg_id)08:03
*** shaohe_feng has joined #openstack-nova08:03
gibipvc:  and please note that scheduler_default_filters are deprecated and renamed to enabled_filters as of https://review.openstack.org/#/c/349959/08:04
pvcthis is my error08:04
pvc- Fault Message Timed out waiting for a reply to message ID ad3febe91f124965a547ffe931d16e7e08:04
pvcNoMatches: No 'nova.scheduler.driver' driver found, looking for 'nova.scheduler.filter_scheduler.FilterScheduler'08:05
*** jaosorior has joined #openstack-nova08:05
pvcthis is my conf gibi http://paste.openstack.org/show/722636/08:06
gibipvc: what nova version do you use?08:07
pvcim using queens08:07
gibipvc: instead of scheduler_driver=nova.scheduler.filter_scheduler.FilterScheduler try scheduler_driver=filter_scheduler08:10
gibipvc: https://github.com/openstack/nova/blob/stable/queens/nova/conf/scheduler.py#L4008:11
*** shaohe_feng has quit IRC08:12
*** rcernin has quit IRC08:13
*** liuzz has quit IRC08:13
*** shaohe_feng has joined #openstack-nova08:14
*** Eran_Kuris has quit IRC08:15
*** gongysh has joined #openstack-nova08:16
openstackgerritTakashi NATSUME proposed openstack/nova-specs master: Change a validation in creating a server group  https://review.openstack.org/54648408:16
openstackgerritTakashi NATSUME proposed openstack/nova-specs master: Change a validation in creating a server group  https://review.openstack.org/54648408:16
*** Eran_Kuris has joined #openstack-nova08:16
*** ttsiouts has quit IRC08:16
*** bigdogstl has joined #openstack-nova08:22
*** shaohe_feng has quit IRC08:23
*** yamamoto has joined #openstack-nova08:25
*** shaohe_feng has joined #openstack-nova08:25
*** AlexeyAbashkin has quit IRC08:27
*** bigdogstl has quit IRC08:27
*** AlexeyAbashkin has joined #openstack-nova08:27
*** hiro-kobayashi has quit IRC08:32
*** yamamoto has quit IRC08:33
*** shaohe_feng has quit IRC08:33
*** shaohe_feng has joined #openstack-nova08:34
*** takashin has left #openstack-nova08:35
*** GonZo2000 has quit IRC08:39
*** GonZo2000 has joined #openstack-nova08:40
*** shaohe_feng has quit IRC08:43
*** shaohe_feng has joined #openstack-nova08:44
*** ttsiouts has joined #openstack-nova08:46
*** ispp has quit IRC08:47
pvcgibi updated http://paste.openstack.org/show/722639/08:48
*** bzhao__ has quit IRC08:49
*** bigdogstl has joined #openstack-nova08:49
*** ispp has joined #openstack-nova08:49
gibipvc: I think you dont need line:508:52
gibipvc: line:4 already makes the pci filter available08:52
gibipvc: line:7 needs to be in the [scheduler] section08:53
*** shaohe_feng has quit IRC08:53
*** bigdogstl has quit IRC08:54
*** shaohe_feng has joined #openstack-nova08:55
pvchere gibi http://paste.openstack.org/show/722642/08:56
pvcokay now sir gibi?08:58
*** sapd has quit IRC08:58
gibipvc: looks good to me now08:59
*** sapd has joined #openstack-nova08:59
pvcokay i'll reconfigure again.08:59
pvci just add it on the flavor08:59
pvc--property pci_passthrough:alias='GTX:2' is that okay gibi09:00
gibipvc: you are transitioning to an area which I have less experties09:03
gibipvc: but it looks good09:04
*** shaohe_feng has quit IRC09:04
*** shaohe_feng has joined #openstack-nova09:06
pvcgibi No valid host was found. There are not enough hosts available.09:09
pvcgibi http://paste.openstack.org/show/722644/09:09
gibipvc: try to check the scheduler log to see which filter removed your host as potential target for your vm09:12
kashyapcfriesen: Responded on the review09:13
*** shaohe_feng has quit IRC09:14
pvcgibi  Filter PciPassthroughFilter returned 0 hosts09:14
*** shaohe_feng has joined #openstack-nova09:17
*** mdbooth has joined #openstack-nova09:19
*** armaan has quit IRC09:19
*** armaan has joined #openstack-nova09:20
*** mgoddard has joined #openstack-nova09:20
kashyapmdbooth: Morning09:21
kashyapmdbooth: Was trying to debug this only failure: http://logs.openstack.org/58/567258/4/check/openstack-tox-py35/727a7d4/testr_results.html.gz09:21
kashyap(Context patch: https://review.openstack.org/#/c/567258/)09:22
*** GonZo2000 has quit IRC09:23
*** bigdogstl has joined #openstack-nova09:23
mdboothkashyap: Looking09:23
kashyapThank you09:24
*** shaohe_feng has quit IRC09:24
kashyapmdbooth: So, it is blowing up here: nova/tests/unit/virt/test_virt_drivers.py --> test_live_migration()09:24
mdboothkashyap: Ah, this is syntactic09:25
*** GonZo2000 has joined #openstack-nova09:25
mdboothHopefully an easy one :)09:25
kashyapOh, really?09:25
kashyapPlease enlighten, /me is not feeling his best today09:26
mdboothkashyap: Those words normally precede a severe humbling09:26
mdboothSo we'll see09:26
kashyapmdbooth: If you want to apply the patch locally, here is a convenient: https://kashyapc.fedorapeople.org/0001-libvirt-Remove-usage-of-migrateToURI-2-APIs.patch09:26
gibipvc: then something is wrong with your pci setup09:26
kashyapYou can `git am` it, if you like.09:27
*** yamamoto has joined #openstack-nova09:27
*** shaohe_feng has joined #openstack-nova09:27
*** bigdogstl has quit IRC09:27
pvcgibi on what side09:27
mdboothkashyap: git review -d is fine09:28
gibipvc: that is a good question :)09:28
kashyapmdbooth: Yep, I find it a tad slower, though.  But only a few seconds :-)09:28
pvci already enabled VT-d and VT-x09:28
*** armaan has quit IRC09:30
*** armaan has joined #openstack-nova09:30
openstackgerritChen proposed openstack/nova master: Fix a typo  https://review.openstack.org/57206109:33
*** shaohe_feng has quit IRC09:34
*** GonZo2000 has quit IRC09:35
*** shaohe_feng has joined #openstack-nova09:37
openstackgerrittianhui proposed openstack/nova master: Fix bug for hypervisors  https://review.openstack.org/57206309:37
*** bigdogstl has joined #openstack-nova09:42
*** shaohe_feng has quit IRC09:45
*** sapd_ has quit IRC09:45
*** sapd_ has joined #openstack-nova09:45
*** Dinesh__Bhor has quit IRC09:47
openstackgerritZhenyu Zheng proposed openstack/nova master: Use ThreadPoolExecutor for max_concurrent_live_migrations  https://review.openstack.org/56350509:47
*** GonZo2000 has joined #openstack-nova09:48
*** GonZo2000 has quit IRC09:48
*** GonZo2000 has joined #openstack-nova09:48
*** shaohe_feng has joined #openstack-nova09:48
*** bigdogstl has quit IRC09:48
janguttersahid: would you like me to build a lower-level unit test specifically for _set_config_VIFGeneric (re https://review.openstack.org/571461 )? I can do that.09:50
*** ttsiouts has quit IRC09:50
*** ttsiouts has joined #openstack-nova09:51
*** shaohe_feng has quit IRC09:55
*** ttsiouts has quit IRC09:55
*** shaohe_feng has joined #openstack-nova09:57
mdboothkashyap: Found it.09:57
mdboothkashyap: Ok, that was obtuse :)09:58
kashyapmdbooth: I am still wading through PDB09:58
kashyapThanks for taking time to debug :-)09:58
kashyapRight now I have debugger here: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L734709:58
*** bigdogstl has joined #openstack-nova10:01
mdboothkashyap: Commented10:02
* kashyap goes to look10:02
kashyapThanks!10:02
mdboothkashyap: I eventually resorted to grep :/10:03
mdboothPython was hiding that mock extremely well.10:03
kashyap:-)  Still reading10:03
*** zhaochao has quit IRC10:03
*** hshiina has quit IRC10:03
mdboothI couldn't even work it out from the debugger, even though I was almost 100% sure that guest.migrate was being mocked.10:03
*** blkart has quit IRC10:04
kashyapmdbooth: If you couldn't work it out...then I had little hope :P10:04
*** namnh has quit IRC10:05
*** shaohe_feng has quit IRC10:05
*** bigdogstl has quit IRC10:06
*** shaohe_feng has joined #openstack-nova10:08
kashyapmdbooth: So, this part was dodgy:10:10
kashyap135         self.stub_out('nova.virt.libvirt.guest.Guest.migrate',10:10
kashyap136                       lambda self, destination, migrate_uri, params, flags,10:10
kashyap137                       domain_xml, bandwidth: None)10:10
*** ispp has quit IRC10:11
mdboothkashyap: Yep. You need to pop the domain_xml argument from that lambda.10:11
kashyapYep, now that I've removed it10:11
kashyapHuh, "obtuse" was the apt word I was looking for.  Thanks10:11
*** mrjk__ has joined #openstack-nova10:11
kashyapI'll also see about the 'params' dict comments10:11
mdboothIt was buried in an unrelated file in a function called by the setUp of a Grandparent class.10:12
*** gongysh has quit IRC10:13
*** gongysh has joined #openstack-nova10:14
*** ebbex_ has joined #openstack-nova10:15
mdboothMight do better to convert those few to Mock with an autospec10:15
*** gongysh has quit IRC10:15
*** shaohe_feng has quit IRC10:15
*** elod_ has joined #openstack-nova10:16
*** frickler_ has joined #openstack-nova10:16
mdboothI believe that will behave the same, but will automatically copy the argument signature of the function being mocked10:16
*** GonZo2000 has quit IRC10:16
kashyapmdbooth: Probably in separate change?10:16
mdboothAlthough tbh it smells that we're looking so deep inside the libvirt driver in that test anyway10:17
kashyap(Prefer to avoid fixing everything in this one change)10:17
mdboothkashyap: Indeed. It would obviously have to be a preceding change, though.10:17
*** shaohe_feng has joined #openstack-nova10:17
*** alex_xu_ has joined #openstack-nova10:17
*** egarbade- has joined #openstack-nova10:17
kashyapmdbooth: Yeah, noted.  Thanks, you saved my Monday morning10:18
*** bigdogstl has joined #openstack-nova10:18
*** sambetts_ has joined #openstack-nova10:19
*** zzzeek_ has joined #openstack-nova10:19
*** gouthamr_ has joined #openstack-nova10:20
*** sambetts|afk has quit IRC10:20
*** mrjk_ has quit IRC10:20
*** elod has quit IRC10:20
*** zzzeek has quit IRC10:20
*** gouthamr has quit IRC10:20
*** ebbex has quit IRC10:20
*** egarbade has quit IRC10:20
*** purplerbot has quit IRC10:20
*** alex_xu has quit IRC10:20
*** frickler has quit IRC10:20
*** ingy has quit IRC10:20
*** msufiyan has quit IRC10:20
*** bigdogstl has quit IRC10:23
*** udesale__ has quit IRC10:23
kashyapmdbooth: You went looking for 'domain_xml' via `grep`?10:23
*** rha has quit IRC10:23
mdboothkashyap: Yep :(10:24
*** armaan has quit IRC10:24
mdboothkashyap: Was looking for mocks including domain_xml10:24
kashyapI see10:24
*** armaan has joined #openstack-nova10:24
mdboothI was pretty sure that migrate() was being mocked and I just couldn't find it.10:24
*** rha has joined #openstack-nova10:25
*** rha has joined #openstack-nova10:25
mdboothkashyap: Disappointingly brute force.10:25
kashyapYeah, I was stupefied.  Embarassed that I didn't do the `grep` :-)10:26
sahidjangutter: i think you can just add an assertion on the vif_name value10:26
*** shaohe_feng has quit IRC10:26
sahidis that not enough?10:26
*** mdnadeem has quit IRC10:26
*** yamamoto has quit IRC10:26
*** shaohe_feng has joined #openstack-nova10:26
*** hamzy has joined #openstack-nova10:27
*** alexchadin has quit IRC10:28
*** ingy has joined #openstack-nova10:28
kashyapsahid: Hey, thanks for the review10:28
kashyapsahid: Are you really -1 on the 'params' thing?10:30
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Remove usage of migrateToURI{2} APIs  https://review.openstack.org/56725810:30
kashyapsahid: Haven't addressed your comment yet, still thinking and playing locally.10:31
sahidseems reasonable yes, it's convention we have. unfortunatly for that method we had two handle several prototypes but now that you are remove the old method that looks reasonable10:31
sahids/two/to10:31
*** ttsiouts has joined #openstack-nova10:32
*** psachin has quit IRC10:32
sahidkashyap: that should not be so difficult to change, i'm ok if you do that in a next patch10:32
kashyapsahid: Yeah, I am not opposed to it.  But you make a good point.  So still considering.10:33
kashyapsahid: Would prefer to change it in a next patch, if that's alright10:33
sahidkashyap: ok so please make it to happen and i will review both patch. since that does not really make sence to generate the params dict for only bandwidth and migrate_uri10:34
sahidok... if you don't want do it now, adding a todo note seems the thing to do10:35
sahids/ok/or10:36
kashyapsahid: No worries, I'll make a second patch10:36
kashyapsahid: And post it as a two-patch series.10:36
*** shaohe_feng has quit IRC10:36
kashyapsahid: Thanks for looking10:37
*** shaohe_feng has joined #openstack-nova10:37
*** bigdogstl has joined #openstack-nova10:37
*** rha has quit IRC10:38
*** tesseract has quit IRC10:41
*** rha has joined #openstack-nova10:41
*** rha has joined #openstack-nova10:41
*** phuongnh has quit IRC10:41
*** alexchadin has joined #openstack-nova10:41
*** bigdogstl has quit IRC10:42
*** dave-mccowan has joined #openstack-nova10:42
kashyapMaybe it makes more sense to do it all in one change.10:43
*** tesseract has joined #openstack-nova10:44
*** sapd has quit IRC10:45
*** shaohe_feng has quit IRC10:46
*** shaohe_feng has joined #openstack-nova10:47
*** dave-mcc_ has joined #openstack-nova10:47
*** dave-mccowan has quit IRC10:47
*** ispp has joined #openstack-nova10:47
*** tbachman has quit IRC10:49
*** msufiyan has joined #openstack-nova10:51
*** bigdogstl has joined #openstack-nova10:52
*** shaohe_feng has quit IRC10:56
*** shaohe_feng has joined #openstack-nova10:58
*** alexchadin has quit IRC11:02
*** bigdogstl has quit IRC11:02
*** alexchadin has joined #openstack-nova11:03
*** alexchadin has quit IRC11:03
*** alexchadin has joined #openstack-nova11:03
*** alexchadin has quit IRC11:04
*** alexchadin has joined #openstack-nova11:04
*** alexchadin has quit IRC11:05
*** alexchadin has joined #openstack-nova11:05
*** alexchadin has quit IRC11:05
*** shaohe_feng has quit IRC11:07
*** shaohe_feng has joined #openstack-nova11:07
*** bigdogstl has joined #openstack-nova11:09
*** jpena is now known as jpena|lunch11:09
*** psachin has joined #openstack-nova11:10
*** abhishekk has quit IRC11:10
*** bigdogstl has quit IRC11:13
*** shaohe_feng has quit IRC11:17
*** shaohe_feng has joined #openstack-nova11:18
*** jrollinhatin is now known as jroll11:20
pvcFilter PciPassthroughFilter returned 0 hosts11:21
*** lifeless_ has joined #openstack-nova11:21
*** lifeless has quit IRC11:22
*** pvc has quit IRC11:24
*** yamamoto has joined #openstack-nova11:26
*** shaohe_feng has quit IRC11:27
*** shaohe_feng has joined #openstack-nova11:28
*** amoralej is now known as amoralej|lunch11:31
*** gibi has quit IRC11:31
openstackgerritJan Gutter proposed openstack/os-vif master: Add support for generic offload representors  https://review.openstack.org/57208111:32
openstackgerritJan Gutter proposed openstack/nova-specs master: Spec to implement vRouter HW offloads  https://review.openstack.org/56714811:32
openstackgerritJan Gutter proposed openstack/nova master: Convert vrouter legacy plugging to os-vif  https://review.openstack.org/57132511:32
openstackgerritJan Gutter proposed openstack/nova master: [WIP] Add support for vrouter HW offloads  https://review.openstack.org/57208211:32
*** dpawlik has joined #openstack-nova11:33
*** yamamoto has quit IRC11:35
*** myrat has quit IRC11:36
*** tiendc has quit IRC11:37
*** shaohe_feng has quit IRC11:37
*** dpawlik has quit IRC11:38
*** shaohe_feng has joined #openstack-nova11:38
*** slaweq has quit IRC11:38
*** slaweq has joined #openstack-nova11:39
*** alexchadin has joined #openstack-nova11:39
*** Bhujay has joined #openstack-nova11:40
*** stakeda has quit IRC11:40
*** blkart has joined #openstack-nova11:41
*** Tom-Tom has quit IRC11:43
*** gibi has joined #openstack-nova11:43
*** alexchadin has quit IRC11:45
*** shaohe_feng has quit IRC11:48
*** shaohe_feng has joined #openstack-nova11:49
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object and api models.  https://review.openstack.org/56337511:49
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object  https://review.openstack.org/56340111:49
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Change the anti-affinity Filter to adapt to new policy  https://review.openstack.org/57116611:49
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model  https://review.openstack.org/57146511:49
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Microversion 2.63 - Use new format policy in server group  https://review.openstack.org/56753411:49
*** udesale has joined #openstack-nova11:57
*** shaohe_feng has quit IRC11:58
*** shaohe_feng has joined #openstack-nova11:59
*** Tom-Tom has joined #openstack-nova12:02
*** tbachman has joined #openstack-nova12:05
*** armaan has quit IRC12:06
*** armaan has joined #openstack-nova12:06
*** Tom-Tom has quit IRC12:07
*** wolverineav has joined #openstack-nova12:07
openstackgerritDamon Li proposed openstack/nova master: Remove minimum version check when save service  https://review.openstack.org/57208912:07
*** hamdyk has quit IRC12:08
*** shaohe_feng has quit IRC12:08
*** shaohe_feng has joined #openstack-nova12:08
*** gibi has quit IRC12:10
*** tbachman has quit IRC12:10
*** gibi has joined #openstack-nova12:10
*** edmondsw has joined #openstack-nova12:12
openstackgerritDamon Li proposed openstack/nova master: Remove minimum version check when save service  https://review.openstack.org/57208912:13
*** alexchadin has joined #openstack-nova12:14
*** psachin has quit IRC12:18
*** tbachman has joined #openstack-nova12:18
*** yamamoto has joined #openstack-nova12:18
*** shaohe_feng has quit IRC12:18
*** amoralej|lunch is now known as amoralej12:19
*** shaohe_feng has joined #openstack-nova12:20
*** lyan has joined #openstack-nova12:20
*** wolverineav has quit IRC12:22
*** armaan has quit IRC12:26
openstackgerritJan Gutter proposed openstack/os-vif master: Add support for generic offload representors  https://review.openstack.org/57208112:26
*** armaan has joined #openstack-nova12:27
*** shaohe_feng has quit IRC12:29
*** jroll has quit IRC12:29
*** jroll has joined #openstack-nova12:30
*** gibi has quit IRC12:30
*** shaohe_feng has joined #openstack-nova12:30
*** armaan has quit IRC12:31
*** armaan has joined #openstack-nova12:32
openstackgerritJan Gutter proposed openstack/nova-specs master: Spec to implement vRouter HW offloads  https://review.openstack.org/56714812:32
*** Nel1x has joined #openstack-nova12:33
*** dpawlik has joined #openstack-nova12:33
*** bigdogstl has joined #openstack-nova12:34
*** openstackgerrit has quit IRC12:34
*** msufiyan_ has joined #openstack-nova12:36
*** msufiyan__ has joined #openstack-nova12:38
*** frickler_ is now known as frickler12:39
*** msufiyan has quit IRC12:39
*** shaohe_feng has quit IRC12:39
*** bigdogstl has quit IRC12:39
*** msufiyan_ has quit IRC12:40
*** jamesdenton has joined #openstack-nova12:41
*** shaohe_feng has joined #openstack-nova12:42
*** takashin has joined #openstack-nova12:49
*** shaohe_feng has quit IRC12:49
*** mike99201-gone is now known as mike9920112:50
*** Nel1x has quit IRC12:53
*** moshele has joined #openstack-nova12:54
*** shaohe_feng has joined #openstack-nova12:54
*** shaohe_feng has quit IRC12:59
*** shaohe_feng has joined #openstack-nova13:00
*** rodolof has joined #openstack-nova13:04
*** gibi has joined #openstack-nova13:05
*** liverpooler has joined #openstack-nova13:07
*** liverpoo1er has joined #openstack-nova13:08
*** shaohe_feng has quit IRC13:10
*** shaohe_feng has joined #openstack-nova13:11
*** liverpooler has quit IRC13:12
*** gibi has quit IRC13:14
*** yamamoto has quit IRC13:16
*** yamamoto has joined #openstack-nova13:16
*** jangutter has quit IRC13:18
*** shaohe_feng has quit IRC13:20
*** jaypipes has joined #openstack-nova13:20
*** dpawlik has quit IRC13:20
*** gibi has joined #openstack-nova13:20
*** shaohe_feng has joined #openstack-nova13:23
*** Guest34116 has quit IRC13:24
*** ispp has quit IRC13:27
*** armaan has quit IRC13:27
*** ispp has joined #openstack-nova13:28
mike99201does nova-conductor call transport_url from anywhere other than nova.conf or is it possibly cached somewhere?13:28
*** shaohe_feng has quit IRC13:30
naichuansjaypipes: Hi, jay. I have a disscuss with Eric on a vgpu n-rp patch:https://review.openstack.org/#/c/520313/40/nova/virt/xenapi/driver.py. Could you review it and give some suggestion when you have the time?13:31
jaypipesnaichuans: yep!13:32
naichuansjaypipes: Thanks!13:32
*** shaohe_feng has joined #openstack-nova13:32
jaypipesmike99201: it's cached in the API database, unfortunately: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api_models.py#L11813:33
mike99201could that be a reason that conductor service starts find and connects to rabbitmq, but when i launch an instance i'm getting invalid credentials when connecting to rabbitmq?13:33
mike99201i've changed the password between the time the database was setup and now13:33
*** jangutter has joined #openstack-nova13:34
*** tbachman has quit IRC13:35
*** yamamoto has quit IRC13:36
jaypipesmike99201: no, I don't think that's an issue. Instances cannot connect to the infrastructure message bus.13:36
jaypipes(by design)13:36
efriednaichuans: Hi there.  I'm still having trouble seeing the reserved=total case.  Since you're online, perhaps you can explain it?13:36
dansmithmike99201: yes13:36
*** yamamoto has joined #openstack-nova13:36
dansmithmike99201: if you changed it in the config and in rabbit after that DB was setup, you need to update the db13:36
mike99201should I update the database, or can I just delete/recreate it13:36
dansmithupdate13:37
mike99201thanks, I'll give it a try13:37
*** tetsuro has joined #openstack-nova13:38
*** jichen has quit IRC13:39
*** Bhujay has quit IRC13:39
*** dpawlik has joined #openstack-nova13:39
*** Bhujay has joined #openstack-nova13:39
*** slaweq_ has joined #openstack-nova13:40
*** slaweq has quit IRC13:40
*** shaohe_feng has quit IRC13:40
*** elbragstad is now known as lbragstad13:42
*** jpena|lunch is now known as jpena13:42
*** shaohe_feng has joined #openstack-nova13:43
*** openstackgerrit has joined #openstack-nova13:44
openstackgerritChen proposed openstack/nova master: Fix some inconsistencies in doc  https://review.openstack.org/57040713:44
efriedjaypipes: In case you were in the middle of looking at the xen thing, I just posted some responses.13:45
*** esberglu has joined #openstack-nova13:47
*** r-daneel has joined #openstack-nova13:48
bauzasjaypipes: dansmith: I tried to follow your convo for the upgrade thread, but could you please give me the consensus ?13:50
*** shaohe_feng has quit IRC13:51
*** shaohe_feng has joined #openstack-nova13:51
efriedbauzas: We're trying to figure out a way to do the upgrade smoothly, in-band, without a separate script.13:52
efriedbauzas: It starts with the algorithm I suggested, which is having the virt driver, via update_provider_tree, indicate which resource classes have "moved" from one provider to another.13:53
bauzasefried: by having a new API ?13:53
efriedbauzas: Then jaypipes pointed out some race conditions in that algorithm that we can resolve via a new placement API, yes.13:54
efriedbauzas: The latter is being worked at https://etherpad.openstack.org/p/placement-migrate-operations13:54
*** cdent has joined #openstack-nova13:54
efriedbrb13:55
*** gbarros has joined #openstack-nova13:55
*** awaugama has joined #openstack-nova13:55
*** pchavva has joined #openstack-nova13:55
*** burt has joined #openstack-nova13:57
*** mriedem has joined #openstack-nova14:00
mriedemalex_xu_: i have a couple of questions regarding server query parameter validation in this trusted certs patch https://review.openstack.org/#/c/486204/101/nova/api/openstack/compute/schemas/servers.py14:00
alex_xu_mriedem: yea14:00
mriedemtomorrow if you get a chance14:00
*** shaohe_feng has quit IRC14:01
*** moshele has quit IRC14:02
mriedemdansmith: we should probably talk about this in the trusted certs series https://review.openstack.org/#/c/561262/17/nova/virt/driver.py@13414:02
*** shaohe_feng has joined #openstack-nova14:02
*** ivve has joined #openstack-nova14:03
*** Sukhdev_ has joined #openstack-nova14:03
dansmithmriedem: you know that is just under my name because I split their patch up right?14:03
mriedemyes, but that's not why i'm bringing it up with you specifically14:04
mriedemit's because you and i talk about this same type of thing quite a bit14:04
*** r-daneel_ has joined #openstack-nova14:04
dansmithokay just checking14:04
dansmithI'm trying to figure something out but I'll go read that comment in a bit14:05
*** beekneemech is now known as bnemec14:06
melwittsahid: hi, just wanted to double check with you that https://blueprints.launchpad.net/nova/+spec/overhead-pin-set has had all related changes merged and okay to mark as complete?14:06
*** ispp has quit IRC14:06
*** dave-mcc_ is now known as dave-mccowan14:06
*** r-daneel has quit IRC14:06
*** Eran_Kuris has quit IRC14:08
*** ispp has joined #openstack-nova14:08
*** r-daneel_ has quit IRC14:09
mriedemthe other thing that bothers me with the trusted image certs stuff is that by default the policy allows anyone to specify trusted cert image IDs when creating a server, but the default config says that image validation isn't enabled14:09
*** r-daneel has joined #openstack-nova14:10
mriedemthe config option just says,14:10
mriedem"If left disabled, image signature verification can still14:10
mriedemoccur but the end user will not have any assurance that the signing14:10
mriedemcertificate used to generate the image signature is still trustworthy."14:10
openstackgerritMultipleCrashes proposed openstack/nova master: Retry decorator fix for autoscale delete  https://review.openstack.org/56341814:10
*** links has quit IRC14:10
mriedemthe end user isn't going to have any idea if the cloud is configured to validate image certs14:11
*** shaohe_feng has quit IRC14:11
mriedemi guess if you just aren't going to support trusted certs in your cloud at all, you should disable the feature by policy so the user can't pass those into server create and rebuild?14:11
*** dpawlik has quit IRC14:11
*** shaohe_feng has joined #openstack-nova14:12
dansmithyeah I mean I dunno what else to tell them to do.. maybe we log a warning if the config and policy don't match?14:12
dansmithso they know they're advertising a bad setup?14:12
alex_xu_mriedem: replied14:13
mriedemalex_xu_: thanks14:13
*** felipemonteiro__ has joined #openstack-nova14:13
sahidmelwitt: yep you can mark it as completed14:14
alex_xu_np14:14
sahidmelwitt: there is also the vf-trusted one14:14
*** felipemonteiro_ has joined #openstack-nova14:15
mriedemsahid: i completed that on friday14:15
sahidah ok i did not notice14:15
*** r-daneel has quit IRC14:15
*** r-daneel has joined #openstack-nova14:16
melwittsahid: cool, thanks for confirming14:16
*** bpoulos has joined #openstack-nova14:16
*** TheJulia is now known as needsleep14:18
*** vladikr has joined #openstack-nova14:18
*** felipemonteiro__ has quit IRC14:18
*** elod_ is now known as elod14:19
*** alex_xu_ has quit IRC14:20
*** alex_xu has joined #openstack-nova14:20
*** shaohe_feng has quit IRC14:21
jangutterIs it possible I could add a spec to the review queue for tomorrow?14:22
*** shaohe_feng has joined #openstack-nova14:22
naichuansefried: Hi, Eric14:22
efriednaichuans: hello14:23
*** itlinux has quit IRC14:23
mriedemdansmith: ok there is a bug in the libvirt plumbing patch too, and it looks like the barbican plugin test for this certs stuff isn't enabling cert validation either, which is probably how it was passing CI https://review.openstack.org/#/c/515210/14:24
mriedemso :(14:24
*** mlavalle has joined #openstack-nova14:24
*** Luzi has quit IRC14:25
*** felipemonteiro_ has quit IRC14:25
*** felipemonteiro_ has joined #openstack-nova14:25
naichuansefried: I do the modification when we discuss the case: customers modified nova.conf, changed the vgpu type. If the gpu already has a vgpu with the previous vgpu type, we can't allocate new gpu type instance(becase we only support one vgpu type per gpug), so we set `reserve` = `total` to prevent scheduling.14:27
efriednaichuans: So help me understand which part of the code is detecting old vs new vgpu type.  That's the part I'm missing.14:28
naichuansefried: Now we check inventory change to determine if there is vgpu configure changes14:28
efriedbut inventory changes when you allocate a vgpu14:29
naichuansNo14:29
efriedno???14:29
*** throwsb1 has joined #openstack-nova14:29
naichuansinventory only contains the vgpu type, total, such kinds of features, no resource count14:30
naichuansresouce amount related information is include in allocation(about used), and the real time host states from hypervisor14:31
melwittmriedem: it looks like the -W can be lifted from this patch now https://review.openstack.org/568382 and the rest of the series be reviewed for the ocata release https://review.openstack.org/57152214:31
*** shaohe_feng has quit IRC14:32
*** shaohe_feng has joined #openstack-nova14:33
*** READ10 has joined #openstack-nova14:34
*** tetsuro has quit IRC14:35
naichuansefried: check inventory define in the patch, we only have `total` field, no `remain`14:35
naichuans                fields.ResourceClass.VGPU: {14:36
naichuans                    'total': grp_value['total'],14:36
naichuans                    'min_unit': 1,14:36
naichuans                    'max_unit': 1,14:36
naichuans                    'step_size': 1,14:36
naichuans                }14:36
naichuans            }14:36
*** hamzy has quit IRC14:36
efriednaichuans: I understand that 'remaining' comes from the hypervisor.14:36
*** felipemonteiro_ has quit IRC14:36
*** ispp has quit IRC14:37
*** felipemonteiro has joined #openstack-nova14:37
naichuansvGPU type changes would effect total and display heads, I will add traits detecting code in the following patches14:37
naichuanseffect -> affect. sorry14:38
*** felipemonteiro_ has joined #openstack-nova14:38
efried(wow, that's one English speakers have trouble with :)14:38
efriednaichuans: Okay, so the key here is has_inventory_changed - meaning, is the inventory in the provider tree different from the inventory you expect...14:39
efriedlet me stare at this for a sec...14:39
naichuansefried: almost14:40
*** ttsiouts has quit IRC14:40
efriednaichuans: So you're using has_inventory_changed to detect that the vgpu type is different?  That's the part that doesn't make sense to me.14:40
*** tidwellr has joined #openstack-nova14:40
*** tidwellr has quit IRC14:40
*** tidwellr has joined #openstack-nova14:41
efriedSurely there are vgpu types that will have the same total as each other.14:41
efriedso that check won't do anything.14:41
*** tbachman has joined #openstack-nova14:41
efriedI would expect if you're trying to detect a changed vgpu type, you would be looking for the grp_id to be different.14:41
*** felipemonteiro has quit IRC14:42
*** shaohe_feng has quit IRC14:42
*** shaohe_feng has joined #openstack-nova14:42
efriedsee, at the moment, your condition says "the resource provider for the expected grp_id already exists, but its inventory total isn't what I expected.  Let's see if anything is allocated.  Okay, it is - let's disable this GPU."14:42
naichuansThe check is for the gpug with same uuid14:42
*** alexchadin has quit IRC14:42
efrieddoes that correspond to a distinct gpu type?14:43
efriedor vgpu type?14:43
*** rodolof has quit IRC14:43
naichuansalmost means it is the same gpug, but there is configure changes on it. we can't support vgpu type checking, jianghua and jay has reject this field14:44
*** sahid has quit IRC14:44
*** sahid has joined #openstack-nova14:44
*** cdent has quit IRC14:44
mriedemmelwitt: we don't run the nova-lvm job in ocata, so not sure if we should hold and backport/verify that? if even in a WIP patch. note that we also merged the pike backports w/o having nova-lvm running in pike either.14:45
efriednaichuans: Same group, but config has changed.  Okay, I think I can buy that.  But why does that mean you have to disable the gpu?14:45
*** ispp has joined #openstack-nova14:45
*** sahid has joined #openstack-nova14:45
*** tbachman has quit IRC14:46
*** ttsiouts has joined #openstack-nova14:46
efried...and how did the configuration change if there are existing allocations?14:47
melwittmriedem: oh, it's -W just waiting for the higher branches to merge14:47
naichuansefried: we can't support multi-type vgpu on one gpug. so if the old type instance still on the gpug, we can't allocate new type on it. So we want to disable it. At first I suggest to set `total` to 0, but Jay suggests use `reserved`14:47
*** alex_xu has quit IRC14:47
*** gcb has quit IRC14:47
naichuanschange nova.conf to modify vgpu type white list14:47
*** rodolof has joined #openstack-nova14:47
mriedemmelwitt: what is?14:48
naichuanswe only need a service resart after that.14:48
melwittmriedem: this https://review.openstack.org/56838214:48
mriedemmelwitt: that was waiting for https://review.openstack.org/#/c/571433/14:48
mriedembut i'm saying,14:48
mriedemhttps://review.openstack.org/#/c/571433/ is to fix a nova-lvm regression,14:48
mriedemand we don't run the nova-lvm job in pike or ocata,14:48
*** alex_xu has joined #openstack-nova14:49
mriedemso should we hold until we verify nova-lvm works with that change, or just...punt14:49
efriednaichuans: But I thought "changing vgpu type" and "changing the configuration (which leads to a different 'total')" were two different things.14:49
naichuansYou mean change the `total` without change the conf?14:50
melwittmriedem: oh, I thought it was waiting for the higher branches version of it to merge (and they have). I was thinking to just punt ... we verified it worked on master, so tbh I wasn't thinking of doing it per branch even though maybe we should have. we don't have access to the old experimental jobs on older branches do we? we'd have to do something like upload a change that adds a new nova-lvm job for ocata, for example?14:51
mriedemwe would have to backport https://github.com/openstack/nova/commit/0db7b77b4615f25217ad646b2e4082994e8dfb73#diff-7415f5ff7beee2cdf9ffe31e12e4c086 to pike and then ocata14:52
melwittokay, I see14:52
*** shaohe_feng has quit IRC14:52
mriedemhttps://review.openstack.org/568382 was waiting for https://review.openstack.org/#/c/571433/ because https://review.openstack.org/568382 regressed lvm14:52
mriedemgiven my current lack of energy, i'm ok with punting14:53
melwittoh, right. I didn't realize that was that change14:53
*** shaohe_feng has joined #openstack-nova14:53
*** tbachman has joined #openstack-nova14:54
*** gcb has joined #openstack-nova14:54
naichuansefried: as I know, we don't supoort hot plugin/plugout, so that case should not happen.14:54
*** mlavalle has quit IRC14:55
*** dpawlik has joined #openstack-nova14:55
efriednaichuans: I'm still trying to wrap my head around all of this, but what I think I've gathered so far is that there are two scenarios we need to be worried about:14:55
efried1) User reconfigures which vgpu type they want to use.  They do this by changing CONF.devices.enabled_vgpu_types.14:55
efried2) User somehow changes the configuration of their vgpu so it now has a different 'total' than it did before.  <== how does this happen?14:55
*** needsleep is now known as TheJulia14:56
efriednaichuans: In the case of 1), if there are existing allocations of the old type, we need to block any subsequent allocations of the new type because we only support one type at a time.  Right?14:57
efriedAnd I don't understand which part of the code is doing ^ this.14:57
mnasermonday morning fun14:57
mnasernova boot foo.123 fails because14:57
mnaser.123 isn't a tld14:57
mnaserand it doesn't even fail in the api layer, it gets rescheduled14:57
mnaserRescheduledException: Build of instance e142e418-7c47-409f-8892-542d5e86e442 was re-scheduled: Invalid input for dns_name. Reason: 'foo.123' not a valid PQDN or FQDN. Reason: TLD '123' must not be all numeric.\nNeutron server returns request_ids: ['req-3ddffd11-e41e-4be2-98a8-d2c22b8c515c14:58
mnaserwell i guess you could say it's a neutron bug, i dunno what'd you'd classify this at14:58
*** mlavalle has joined #openstack-nova14:58
*** chyka has joined #openstack-nova14:58
dansmithI wasn't aware that we assigned any special significance to names with dots14:59
mnaserif nova team feels like this is a nova bug, ill file and start looking into fixes14:59
naichuansefried: we set `reserve` = `total`, to avoid scheduling for new vgpu14:59
mnaseri think neutron does validation and we might not be doing proper sanitization when creating a port14:59
melwittI feel like I've seen that before. because we use display_name as the hostname14:59
dansmithmnaser: I wonder if we're just passing the display name to neutron and it's inferring some signficance?14:59
*** tbachman has quit IRC14:59
mnaseri think that's exactly whats happening14:59
dansmithmelwitt: ah, that'd make sense14:59
*** dpawlik has quit IRC14:59
melwittdansmith: I think that's why14:59
dansmithso I don't think that's an us thing14:59
mnaserit creates a port with dns_name=display_name and poof14:59
mnaserwell if nova is giving a non-valid dns_name, i'd say it's okay for neutron to complain?15:00
dansmithunless we shouldn't be passing the display name15:00
melwittwe do this kind of sanitizing https://github.com/openstack/nova/blob/master/nova/compute/api.py#L141615:00
*** ispp has quit IRC15:00
efriednaichuans: Yes, I'm not arguing with that part.  When we need to "disable" a vgpu, we set reserved = total.  What I'm trying to figure out is, under what circumstances do we decide we *need* to disable a vgpu?  Am I on the right track with 1 and 2 above?15:00
melwitthttps://github.com/openstack/nova/blob/master/nova/utils.py#L48515:00
*** klindgren_ has joined #openstack-nova15:01
dansmithright, but DNS validation shouldn't be part of the sanitization15:01
*** takashin has left #openstack-nova15:01
*** tesseract-RH has joined #openstack-nova15:01
melwittyeah, it isn't15:02
*** tesseract has quit IRC15:02
naichuansefried: I see. In truth each vgput type consume different resource, the `total` = `whole resource` / `resource for one vgpu of certain type`. so change the vgpu type, you will change the `total`15:02
efriednot necessarily?15:02
*** shaohe_feng has quit IRC15:02
dansmithmnaser: surely there's some configuration of neutron that doesn't require valid TLDs right?15:02
*** ivve has quit IRC15:02
efriednaichuans: Surely there are some "types" that will have the same `total`?15:03
naichuansefried: it should not.15:03
*** shaohe_feng has joined #openstack-nova15:03
naichuansespecially on a same pgpu group15:03
efriednaichuans: But different types can have the same group ID?15:03
jaypipesbauzas: so, I note that you didn't respond to any of my review comments on your multi-gpu-types spec...15:04
*** artom has quit IRC15:04
*** gbarros has quit IRC15:04
naichuansefried: right, one pgug has one id, but it would support more than one vgpu type, each of them has different resource amount15:04
bauzasjaypipes: wait? while I haven't replied to your comments, I think I fixed given your opinions :)15:04
*** armaan has joined #openstack-nova15:05
bauzasjaypipes: https://review.openstack.org/#/c/557065/5..6/specs/rocky/approved/vgpu-rocky.rst ;)15:05
jaypipesbauzas: ok. I was just expecting you to come back at me with words :)15:06
*** armaan has quit IRC15:06
*** armaan has joined #openstack-nova15:06
*** armaan has quit IRC15:06
*** bigdogstl has joined #openstack-nova15:06
bauzasjaypipes: heh, sometimes I'm just revisiting my patches if the comment is good for me :)15:07
*** armaan has joined #openstack-nova15:07
efriednaichuans: I'm having a hard time understanding that.  But okay, so the code we're looking at is meant to handle #2.  What are we doing to handle #1?15:08
jaypipesbauzas: good to know! :)15:08
*** lifeless_ has quit IRC15:08
bauzasjaypipes: sorry about the confusion :)15:09
*** esberglu has quit IRC15:10
*** cdent has joined #openstack-nova15:10
jaypipesbauzas: no worries!15:10
bauzasjaypipes: cdent: efried: btw. not sure when the hangout will be ?15:12
bauzasfor the upgrade issues ?15:12
efriedbauzas: I don't think we discussed it further.15:12
bauzask15:12
naichuansefried: Eric, I can't catch your minde... in truth we have only one way to configure vgpu type on OpenStack side, change `CONF.devices.enabled_vgpu_type` by modify nova.conf. So I think #1 and #2 comes from the same reason, nova.conf changed. could you explain more?15:12
efriedI think tomorrow morning (for some U.S. value of "morning")15:12
*** bigdogstl has quit IRC15:12
bauzaslemme look at my agenda15:12
cdentthat's my understanding as well. we were going to figure it out here. hopefully with some input from edleafe15:12
*** shaohe_feng has quit IRC15:13
efriednaichuans: Okay, enabled_vgpu_types=foo.  Create an instance with a vGPU.  Change enabled_vgpu_types=bar, restart compute service.  Try to create an instance with a vGPU.  It should fail.  Where's the code that makes it fail?15:13
*** bigdogstl has joined #openstack-nova15:13
*** shaohe_feng has joined #openstack-nova15:13
bauzasefried: FWIW about the discussion we had with naichuans, I think we agreed on saying that if an operator modifies nova.conf for changing the types, then meh, it's their responsibility to make sure there is not existing instances15:14
bauzasefried: we can document it15:14
*** felipemonteiro_ is now known as felipemonteiro15:14
*** felipemonteiro has quit IRC15:14
efriedbauzas: Hm, okay.  It's certainly possible to detect this and throw an error.15:14
naichuansNo, it would not failed, we changed the `reserve` when you restart(after modify conf), the schduling to this rp would be impossile15:15
naichuansimpossible15:15
*** chyka has quit IRC15:15
*** chyka has joined #openstack-nova15:15
*** ispp has joined #openstack-nova15:17
openstackgerritmelanie witt proposed openstack/nova stable/pike: zuul: Move legacy jobs to project  https://review.openstack.org/57213015:17
bauzasnaichuans: you mean, we *should* do that ?15:17
*** purplerbot has joined #openstack-nova15:17
*** ispp has quit IRC15:18
*** andreas_s has quit IRC15:19
*** ttsiouts has quit IRC15:19
naichuansefried: Although the customer may want to configure to a new vgpu type, but we stop to support fureture allocation. bauzas: I also think it is a mistake by OpenStack operator. Fix by us, or just let scheduling fail and let operator to mange it, both OK for me, my code now take the first choice.15:20
efriedscheduling won't fail, though.15:20
naichuansYes15:20
*** rodolof has quit IRC15:21
naichuansIt would looking for another rp on a anther host15:21
*** rodolof has joined #openstack-nova15:21
efriednaichuans: Right now you're looping over the vgpu types.  If you restart the compute service with a different configured type, you'll ignore the old one entirely and just start using the new one.15:21
openstackgerritmelanie witt proposed openstack/nova stable/ocata: zuul: Move legacy jobs to project  https://review.openstack.org/57213215:21
*** hamzy has joined #openstack-nova15:21
bauzasefried: naichuans: so we would need to check the existing allocations when init_host() then15:22
bauzasjust for that15:22
*** itlinux has joined #openstack-nova15:23
*** shaohe_feng has quit IRC15:23
*** esberglu has joined #openstack-nova15:23
efriedBut this also dovetails with my other issue, which is that you need to be detecting and deleting resource providers for other vgpu types than the one (or in future, ones) you're currently managing.15:23
*** smatzek has joined #openstack-nova15:23
*** shaohe_feng has joined #openstack-nova15:24
*** smatzek has quit IRC15:24
bauzasefried: yup, that'z the problem15:25
*** esberglu has quit IRC15:25
efriedbauzas: I'm saying with the naming convention being used, you can totally do that.15:25
*** hongbin has joined #openstack-nova15:26
*** suresh12 has joined #openstack-nova15:26
*** rodolof has quit IRC15:26
*** rodolof has joined #openstack-nova15:26
naichuansefried: currently yes, we detect the configure changes by checking inventory changes. Like bauzas said, we also can communicate with hypervisor to check previous allocated vgpu instances15:26
*** pchavva has quit IRC15:26
*** sahid has quit IRC15:27
bauzasnaichuans: we could pass the allocations to the virt driver with init_host()15:27
*** Bhujay has quit IRC15:27
bauzasexactly like we do for spawn() or other virt methods15:27
mnasermelwitt, dansmith: https://bugs.launchpad.net/nova/+bug/158197715:27
openstackLaunchpad bug 1581977 in OpenStack Compute (nova) "Invalid input for dns_name when spawning instance with .number at the end" [Undecided,Invalid]15:27
bauzasnaichuans: but for the moment, I think we can just document this15:27
*** esberglu has joined #openstack-nova15:27
*** esberglu_ has joined #openstack-nova15:28
*** sahid has joined #openstack-nova15:28
*** bigdogstl has quit IRC15:29
naichuansbauzas: yes, we can do it. could we use it to determin vgpu type current used? Looks difficult15:29
naichuanspreviously used15:29
bauzasnaichuans: I did that for reboot :)15:30
*** tbachman has joined #openstack-nova15:30
bauzasI'm just looking up the existing instances and check whether the mdev is there or not15:30
bauzasand just recreate it15:30
naichuansbauzas: currently, we defined vgpu type in nova.conf. these types is same with the types in hpyervisor record, so it may easier to compare with hypervisor15:32
*** esberglu has quit IRC15:32
*** ratailor has quit IRC15:32
*** shaohe_feng has quit IRC15:33
*** shaohe_feng has joined #openstack-nova15:35
naichuansand vgpu type is transparent for placement15:35
*** pcaruana|worksho has quit IRC15:35
*** r-daneel_ has joined #openstack-nova15:36
*** janki has quit IRC15:37
*** r-daneel has quit IRC15:38
*** r-daneel_ is now known as r-daneel15:38
*** pchavva has joined #openstack-nova15:39
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Spec for volume multiattach enhancements  https://review.openstack.org/55207815:40
naichuansbauzas: efried: It is late at night in China now, I'm going to sleep. I will keep close touch with you in the email.15:43
*** shaohe_feng has quit IRC15:43
openstackgerritDan Smith proposed openstack/nova master: Use oslo.messaging per-call monitoring  https://review.openstack.org/56669615:44
*** rodolof has quit IRC15:44
efriednaichuans: Thanks for helping me understand this stuff.  I think with some updates on the comments we might be there now.15:44
*** shaohe_feng has joined #openstack-nova15:44
naichuansefried: Np, thank you very much for the review :)15:44
*** AlexeyAbashkin has quit IRC15:45
*** slaweq_ is now known as slaweq15:45
*** mvenesio has joined #openstack-nova15:45
*** tssurya has quit IRC15:48
*** jmlowe has quit IRC15:49
*** moshele has joined #openstack-nova15:52
openstackgerritMultipleCrashes proposed openstack/nova master: Retry decorator fix for autoscale delete  https://review.openstack.org/57037015:53
*** shaohe_feng has quit IRC15:54
*** yamamoto has quit IRC15:55
*** shaohe_feng has joined #openstack-nova15:55
*** gbarros has joined #openstack-nova15:57
*** moshele has quit IRC15:58
*** shaohe_feng has quit IRC16:04
*** shaohe_feng has joined #openstack-nova16:07
*** tbachman has quit IRC16:07
*** rajinir has joined #openstack-nova16:08
*** gyee has joined #openstack-nova16:08
*** sahid has quit IRC16:09
*** sridharg has quit IRC16:11
*** shaohe_feng has quit IRC16:14
*** shaohe_feng has joined #openstack-nova16:14
*** gcb has quit IRC16:15
*** shaohe_feng has quit IRC16:24
*** msufiyan__ has quit IRC16:24
*** shaohe_feng has joined #openstack-nova16:26
*** lyan has quit IRC16:27
*** bigdogstl has joined #openstack-nova16:28
*** harlowja has joined #openstack-nova16:28
*** tidwellr has quit IRC16:30
*** udesale has quit IRC16:30
*** tidwellr has joined #openstack-nova16:31
*** bigdogstl has quit IRC16:32
*** tesseract-RH has quit IRC16:34
*** shaohe_feng has quit IRC16:35
*** fragatina has joined #openstack-nova16:36
*** shaohe_feng has joined #openstack-nova16:36
*** edmondsw has quit IRC16:41
*** ttsiouts has joined #openstack-nova16:41
*** fragatina has quit IRC16:43
*** mgoddard has quit IRC16:43
*** fragatina has joined #openstack-nova16:43
*** tssurya has joined #openstack-nova16:45
*** shaohe_feng has quit IRC16:45
*** edmondsw has joined #openstack-nova16:46
*** ttsiouts has quit IRC16:49
*** pcaruana|worksho has joined #openstack-nova16:51
*** suresh12 has quit IRC16:54
*** shaohe_feng has joined #openstack-nova16:55
*** tbachman has joined #openstack-nova16:55
*** shaohe_feng has quit IRC16:55
*** yamamoto has joined #openstack-nova16:55
*** gouthamr_ is now known as gouthamr16:56
*** shaohe_feng has joined #openstack-nova16:56
*** jmlowe has joined #openstack-nova16:59
*** GonZo2000 has joined #openstack-nova17:02
*** yamamoto has quit IRC17:03
*** fragatina has quit IRC17:04
*** fragatina has joined #openstack-nova17:04
*** fragatina has quit IRC17:04
*** fragatina has joined #openstack-nova17:05
*** sambetts_ is now known as sambetts|afk17:05
*** shaohe_feng has quit IRC17:05
*** fragatina has quit IRC17:06
*** fragatina has joined #openstack-nova17:06
*** shaohe_feng has joined #openstack-nova17:08
*** esberglu_ has quit IRC17:09
*** esberglu has joined #openstack-nova17:10
*** harlowja has quit IRC17:10
*** bigdogstl has joined #openstack-nova17:14
*** esberglu has quit IRC17:14
*** shaohe_feng has quit IRC17:16
*** bigdogstl has quit IRC17:18
*** shaohe_feng has joined #openstack-nova17:18
*** pcaruana|worksho is now known as pcaruana17:18
*** jpena is now known as jpena|off17:19
*** smatzek has joined #openstack-nova17:21
*** germs has joined #openstack-nova17:21
*** germs has quit IRC17:21
*** germs has joined #openstack-nova17:21
*** yamahata has joined #openstack-nova17:21
*** smatzek has quit IRC17:23
*** smatzek_ has joined #openstack-nova17:23
*** ttsiouts has joined #openstack-nova17:24
*** shaohe_feng has quit IRC17:26
*** shaohe_feng has joined #openstack-nova17:28
*** AlexeyAbashkin has joined #openstack-nova17:33
*** moshele has joined #openstack-nova17:35
*** Eran_Kuris has joined #openstack-nova17:35
*** Alexey_Abashkin has joined #openstack-nova17:36
*** shaohe_feng has quit IRC17:36
*** bigdogstl has joined #openstack-nova17:36
*** AlexeyAbashkin has quit IRC17:37
*** Alexey_Abashkin is now known as AlexeyAbashkin17:37
*** shaohe_feng has joined #openstack-nova17:38
*** moshele has quit IRC17:38
*** smatzek_ has quit IRC17:39
karimullHi ...need your reviews on https://review.openstack.org/#/c/569498/17:39
*** suresh12 has joined #openstack-nova17:40
*** bigdogstl has quit IRC17:41
*** ttsiouts has quit IRC17:41
*** amoralej is now known as amoralej|off17:45
*** ttsiouts has joined #openstack-nova17:46
*** shaohe_feng has quit IRC17:46
*** shaohe_feng has joined #openstack-nova17:47
*** harlowja has joined #openstack-nova17:49
*** mgoddard has joined #openstack-nova17:55
*** ircuser-1 has joined #openstack-nova17:56
*** shaohe_feng has quit IRC17:57
*** shaohe_feng has joined #openstack-nova17:57
*** r-daneel has quit IRC17:58
*** fragatina has quit IRC17:59
*** markvoelker has quit IRC17:59
*** fragatina has joined #openstack-nova17:59
*** markvoelker has joined #openstack-nova18:00
*** rodolof has joined #openstack-nova18:03
*** shaohe_feng has quit IRC18:07
*** shaohe_feng has joined #openstack-nova18:08
*** suresh12 has quit IRC18:09
*** AlexeyAbashkin has quit IRC18:09
*** r-daneel has joined #openstack-nova18:09
*** suresh12 has joined #openstack-nova18:09
*** rodolof has quit IRC18:10
*** esberglu has joined #openstack-nova18:11
*** suresh12 has quit IRC18:14
*** suresh12 has joined #openstack-nova18:15
*** shaohe_feng has quit IRC18:17
*** lyan has joined #openstack-nova18:17
mriedemkarimull: i suggest putting that into the runways review queue https://etherpad.openstack.org/p/nova-runways-rocky18:17
*** shaohe_feng has joined #openstack-nova18:18
*** tssurya has quit IRC18:20
*** NostawRm has quit IRC18:26
*** NostawRm has joined #openstack-nova18:26
*** shaohe_feng has quit IRC18:27
*** shaohe_feng has joined #openstack-nova18:29
*** moshele has joined #openstack-nova18:36
*** tssurya has joined #openstack-nova18:37
*** shaohe_feng has quit IRC18:38
*** shaohe_feng has joined #openstack-nova18:39
*** mriedem has quit IRC18:40
*** mgoddard has quit IRC18:41
*** tbachman has quit IRC18:42
*** mriedem has joined #openstack-nova18:43
efriedkarimull: Reviewed.18:43
*** smatzek has joined #openstack-nova18:43
*** smatzek has quit IRC18:43
efriedkarimull: But I agree with mriedem - this definitely needs eyes from the likes of jaypipes, dansmith, mriedem.18:43
*** Tom-Tom has joined #openstack-nova18:44
*** tbachman has joined #openstack-nova18:45
*** Sukhdev has joined #openstack-nova18:47
*** mvenesio has quit IRC18:47
*** shaohe_feng has quit IRC18:48
*** shaohe_feng has joined #openstack-nova18:48
*** Tom-Tom has quit IRC18:49
*** tbachman has quit IRC18:50
openstackgerritMatt Riedemann proposed openstack/nova master: Fix typo in enable_certificate_validation config option help  https://review.openstack.org/57218518:51
openstackgerritJay Pipes proposed openstack/nova-specs master: Standardize CPU resource tracking  https://review.openstack.org/55508118:55
*** shaohe_feng has quit IRC18:58
*** shaohe_feng has joined #openstack-nova18:59
*** suresh12 has quit IRC19:00
*** ttsiouts has quit IRC19:04
*** cdent has quit IRC19:05
*** salv-orlando has joined #openstack-nova19:05
*** mvk has quit IRC19:08
*** shaohe_feng has quit IRC19:08
*** lpetrut has joined #openstack-nova19:09
*** salv-orlando has quit IRC19:09
*** shaohe_feng has joined #openstack-nova19:11
*** mvenesio has joined #openstack-nova19:14
*** moshele has quit IRC19:17
*** shaohe_feng has quit IRC19:19
*** lpetrut has quit IRC19:19
*** jaosorior has quit IRC19:19
*** armaan has quit IRC19:19
*** lpetrut has joined #openstack-nova19:19
*** armaan has joined #openstack-nova19:20
*** shaohe_feng has joined #openstack-nova19:20
*** lpetrut has quit IRC19:20
*** lpetrut has joined #openstack-nova19:21
*** GonZo2000 has quit IRC19:21
*** bigdogstl has joined #openstack-nova19:21
*** lpetrut has quit IRC19:22
*** sambetts|afk has quit IRC19:22
*** lpetrut has joined #openstack-nova19:22
*** mvenesio has quit IRC19:24
*** sambetts_ has joined #openstack-nova19:25
*** bigdogstl has quit IRC19:26
*** tbachman has joined #openstack-nova19:28
*** shaohe_feng has quit IRC19:29
*** zcorneli has joined #openstack-nova19:29
*** harlowja has quit IRC19:29
*** shaohe_feng has joined #openstack-nova19:30
*** bigdogstl has joined #openstack-nova19:30
*** ivve has joined #openstack-nova19:31
*** lifeless has joined #openstack-nova19:34
*** bigdogstl has quit IRC19:35
*** slaweq has quit IRC19:38
*** slaweq has joined #openstack-nova19:38
*** mdbooth has quit IRC19:38
*** shaohe_feng has quit IRC19:39
*** Sukhdev has quit IRC19:39
*** shaohe_feng has joined #openstack-nova19:43
*** calebb has quit IRC19:47
openstackgerritDan Smith proposed openstack/nova master: Change consecutive build failure limit to a weigher  https://review.openstack.org/57219519:47
*** suresh12 has joined #openstack-nova19:48
*** shaohe_feng has quit IRC19:49
*** READ10 has quit IRC19:50
*** shaohe_feng has joined #openstack-nova19:50
*** calebb has joined #openstack-nova19:51
*** ttsiouts has joined #openstack-nova19:53
*** Sukhdev has joined #openstack-nova19:55
*** cdent has joined #openstack-nova19:57
*** harlowja has joined #openstack-nova19:59
*** shaohe_feng has quit IRC20:00
*** lpetrut has quit IRC20:00
*** lpetrut has joined #openstack-nova20:01
*** shaohe_feng has joined #openstack-nova20:01
*** salv-orlando has joined #openstack-nova20:05
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Remove device from volume attach requests (spec)  https://review.openstack.org/45254620:06
mriedemdansmith: finally got around to updating this old spec ^20:06
*** liverpoo1er has quit IRC20:07
*** slaweq has quit IRC20:09
*** slaweq has joined #openstack-nova20:09
*** fragatina has quit IRC20:09
*** fragatina has joined #openstack-nova20:10
*** shaohe_feng has quit IRC20:10
*** salv-orlando has quit IRC20:10
*** shaohe_feng has joined #openstack-nova20:12
*** sapd_ has quit IRC20:17
openstackgerritJay Pipes proposed openstack/nova-specs master: Standardize CPU resource tracking  https://review.openstack.org/55508120:18
*** shaohe_feng has quit IRC20:20
*** shaohe_feng has joined #openstack-nova20:23
*** ttsiouts has quit IRC20:23
*** rodolof has joined #openstack-nova20:26
*** pchavva has quit IRC20:28
*** shaohe_feng has quit IRC20:30
*** Sukhdev has quit IRC20:31
*** ttsiouts has joined #openstack-nova20:31
*** shaohe_feng has joined #openstack-nova20:31
*** sapd has joined #openstack-nova20:40
*** shaohe_feng has quit IRC20:41
*** tidwellr has left #openstack-nova20:42
*** shaohe_feng has joined #openstack-nova20:43
lyarwoodefried: https://bugs.launchpad.net/nova/+bug/1775075 - afternoon, if you have a second could you take a look at this bug and the comment I left on the original change? https://review.openstack.org/#/c/510947/1/nova/context.py@12120:43
openstackLaunchpad bug 1775075 in OpenStack Compute (nova) "EndpointNotFound raised by Pike n-cpu when running alongside Queens n-api" [Undecided,New]20:43
efriedlyarwood: looking...20:45
lyarwoodefried: thanks :)20:45
efriedlyarwood: Okay, I think this may come down to what version of ksa exists on pike, and whether os-service-types is available.20:48
*** lifeless_ has joined #openstack-nova20:49
lyarwoodefried: 3.1.0 iirc20:50
*** armaan has quit IRC20:50
*** lifeless has quit IRC20:50
lyarwoodefried: adding volumev2 back in nova/context.py is enough in my local env FWIW20:50
lyarwoodefried: on the n-api host that is20:50
cdentis tomorrow spec sprint again?20:51
*** shaohe_feng has quit IRC20:51
efriedlyarwood: I'm fine with that as a resolution; but we should probably bring mordred in on this issue, since he was basically leading me through a lot of the service catalog work.20:51
efriedcdent: yes, afaik20:51
melwittcdent: yes20:51
cdentcool, thanks20:51
melwittI'll send another email to remind to the dev ML late today20:52
*** shaohe_feng has joined #openstack-nova20:52
*** Eran_Kuris has quit IRC20:52
*** lpetrut has quit IRC20:52
lyarwoodefried: ack, I'll push something to stable/queens now20:52
lyarwoodefried: thanks :)20:52
efriedlyarwood: os-service-types is not in requirements in pike, and I think that's probably the source of the problem.20:53
lyarwoodefried: hmm okay, AFAICT the Queens n-api was just stripping the volumev2 endpoints from the request context it was sending to the Pike compute, I'm not sure how os-service-types could help there but I've never really touched this area before.20:54
*** janki has joined #openstack-nova20:54
*** armaan has joined #openstack-nova20:55
efriedlyarwood: The endpoints themselves should be getting picked up correctly on the queens side.  If we're sending actual endpoints across the wire, that should work fine.20:55
efriedlyarwood: Because the queens side will have os-service-types, which means it'll find the correct endpoints (whether they're called volumev2 or whatever) for block-storage.20:56
mordredefried: aroo?20:57
*** ttsiouts has quit IRC20:57
*** ttsiouts has joined #openstack-nova20:57
efriedmordred: See  https://bugs.launchpad.net/nova/+bug/1775075 and  https://review.openstack.org/#/c/510947/1/nova/context.py@12120:59
openstackLaunchpad bug 1775075 in OpenStack Compute (nova) "EndpointNotFound raised by Pike n-cpu when running alongside Queens n-api" [Undecided,New]20:59
*** pcaruana has quit IRC20:59
efriedmordred: What lyarwood is finding is that when he adds 'volumev2' back in on the queens side, it fixes the problem.  Which I don't quite understand why doing that on the *queens* side would fix.  Because that guy has os-service-types and the right ksa... oh, unless this is one of those ksa bugs we've since fixed, where endpoint lookup isn't happening right.21:00
*** bigdogstl has joined #openstack-nova21:01
*** shaohe_feng has quit IRC21:01
lyarwoodefried: so the Pike side is looking for the cinderv2 endpoint in the catalog stashed in the request context21:02
*** shaohe_feng has joined #openstack-nova21:02
lyarwoodefried: the cinderv3 endpoint is there correctly, but without the cinderv2 endpoint it just fails21:02
mordredefried: probably. when you say "queens side" and "pike side" - what does that mean here?21:02
lyarwoodmordred: queens n-api, pike n-cpu21:02
mordredgotcha21:02
*** MikeG451 has quit IRC21:03
mordredyah - I think you'll need the volumev2 in there until everything is on queens - I think efried is correct about there being missing fixes21:03
*** harlowja has quit IRC21:04
*** stewie925 has quit IRC21:04
lyarwoodoh I forgot to say that our P n-cpu's have catalog_info=volumev2:cinderv2:internal in nova.conf forcing them to look for cinderv221:05
*** rodolof has quit IRC21:05
*** bigdogstl has quit IRC21:06
*** rodolof has joined #openstack-nova21:06
efriedah21:06
efriedwell then yeah21:06
lyarwoodyeah my bad, the default is cinderv3 right?21:06
*** salv-orlando has joined #openstack-nova21:06
efriedso is this a bug in the code, or is this something that should be fixed via conf on site?21:06
lyarwoodI'd say code still if possible21:07
efriedlyarwood: Is there a similar argument for restoring 'volume' ?21:08
*** jmlowe has quit IRC21:08
lyarwoodefried: yeah assuming you could set catalog_info to look for it21:08
*** dpawlik has joined #openstack-nova21:09
*** janki has quit IRC21:10
*** tssurya has quit IRC21:10
*** tssurya has joined #openstack-nova21:11
efriedlyarwood: tbc, this patch doesn't exist on pike, right?21:11
efriedhttps://review.openstack.org/#/c/510947/ that is21:11
lyarwoodefried: correct21:11
lyarwoodefried: just Queens21:11
*** salv-orlando has quit IRC21:11
*** shaohe_feng has quit IRC21:11
efriedlyarwood: Okay, well, restoring 'volume' is not necessary because https://review.openstack.org/#/c/409904/21:12
*** rodolof has quit IRC21:12
*** shaohe_feng has joined #openstack-nova21:12
efriedlyarwood: But volumev2 was dropped in q (https://review.openstack.org/#/c/501874/)21:12
efriedlyarwood: So I guess unless queens n-api can talk to ocata n-cpu?  Is that a thing?21:13
lyarwoodefried: nope, shouldn't be.21:13
*** dpawlik has quit IRC21:13
efriedokay.  Then I suppose restoring volumev2 on the premise that q can talk to p is a reasonable thing.  Though I'm still confused as to why the problem would manifest if the endpoint lookup is being done on the q side.21:14
efriedlyarwood: Do you have the ability to check whether upgrading ksa (without reintroducing 'volumev2' in that RequestContext filter) also fixes the problem?21:14
lyarwoodefried: on the Q n-api host?21:15
efriedyeah - upgrade ksa and service-types-authoryt.21:15
efriedauthority21:15
efriedlyarwood: That would give us the info as to whether the issue lies with missing ksa fixes, as mordred quasi-corroborated.21:15
lyarwoodefried: just to the latest stable versions I assume?21:16
lyarwoodefried: I can give that a try21:16
efriedlyarwood: yeah, that should be adequate.21:16
*** Guest46637 has quit IRC21:18
*** ttsiouts has quit IRC21:19
*** ttsiouts has joined #openstack-nova21:19
mordredlatest ksa SHOULD make this happier21:20
*** shaohe_feng has quit IRC21:22
*** bpoulos has quit IRC21:23
*** shaohe_feng has joined #openstack-nova21:23
*** ivve has quit IRC21:26
*** throwsb1 has quit IRC21:26
lyarwoodefried / mordred ; still fails with ksa 3.7.021:27
*** tssurya has quit IRC21:27
efriedlyarwood: Okay, that's an interesting data point.  Are you sure the RequestContext itself is really going across the wire, complete with its service catalog?21:27
efriedlyarwood: If the cached service catalog is being stripped, but the remainder of the context is being trasmitted, then that would certainly cause the problem.  Because the pike side doesn't have os-service-types so it doesn't know what to do with 'block-storage'.21:28
efriedor maybe we haven't looked up (the cinder endpoint in) the service catalog yet by the time it's being sent over.21:29
lyarwoodefried: yeah I'm sure, cinderv3 is there when it's going over the wire from Q21:29
*** tssurya has joined #openstack-nova21:29
efriedlyarwood: Ohh, because the queens side would be using the cinderv3 endpoint.21:30
*** tssurya has quit IRC21:30
efriedlyarwood: But the pike side wants the v2 endpoint.21:30
lyarwoodefried: yeah indeed21:30
efriedSo if the q request context only looked up v3, even if it sent the cached service catalog over the wire, the p side wouldn't see the v2 endpoint in it.21:30
lyarwoodefried: it's actually finding both before we hit nova/context.py iirc21:31
efriedlyarwood: But would have no reason to load up the discovery info for v221:32
lyarwoodefried: on Q, but we then strip cinderv2 out causing the problem21:32
efriedoh, I see, yes.21:32
*** shaohe_feng has quit IRC21:32
efriedlyarwood: IMO the bug sounds like we shouldn't be sending the RequestContext from Q to P.  But we're not gonna fix that at this point.  Adding volumev2 back in sounds like the less intrusive fix.21:32
*** shaohe_feng has joined #openstack-nova21:33
*** edmondsw has quit IRC21:35
*** bigdogstl has joined #openstack-nova21:35
*** awaugama has quit IRC21:35
*** harlowja has joined #openstack-nova21:36
*** esberglu_ has joined #openstack-nova21:42
*** shaohe_feng has quit IRC21:42
*** shaohe_feng has joined #openstack-nova21:43
*** bigdogstl has quit IRC21:44
*** esberglu has quit IRC21:44
openstackgerritLee Yarwood proposed openstack/nova stable/queens: Allow cinderv2 endpoints within the request context catalog  https://review.openstack.org/57221321:46
lyarwoodefried: ^ I'll follow up with more tests in the morning.21:47
lyarwoodefried: thanks again :)21:47
efriedlyarwood: Thank you21:47
*** slaweq has quit IRC21:48
*** dave-mccowan has quit IRC21:50
*** itlinux has quit IRC21:51
*** ttsiouts has quit IRC21:52
*** shaohe_feng has quit IRC21:52
*** shaohe_feng has joined #openstack-nova21:53
*** itlinux has joined #openstack-nova22:01
*** itlinux has quit IRC22:01
*** shaohe_feng has quit IRC22:03
*** rcernin has joined #openstack-nova22:03
*** shaohe_feng has joined #openstack-nova22:06
*** salv-orlando has joined #openstack-nova22:07
openstackgerritDavid Bingham proposed openstack/nova master: Adding apply_cells to nova-manage to enable automated cells_v2 configuration.  https://review.openstack.org/57221622:08
*** rodolof has joined #openstack-nova22:11
*** salv-orlando has quit IRC22:12
*** r-daneel has quit IRC22:12
*** idlemind has quit IRC22:12
*** jmlowe has joined #openstack-nova22:12
*** shaohe_feng has quit IRC22:13
*** r-daneel has joined #openstack-nova22:13
*** shaohe_feng has joined #openstack-nova22:14
*** lyan has quit IRC22:16
*** mlavalle has quit IRC22:19
*** dave-mccowan has joined #openstack-nova22:21
*** shaohe_feng has quit IRC22:23
*** shaohe_feng has joined #openstack-nova22:24
openstackgerritDavid Bingham proposed openstack/nova master: Adding apply_cells to nova-manage to enable automated cells_v2 configuration.  https://review.openstack.org/56898722:28
*** klindgren_ has quit IRC22:29
*** mriedem has quit IRC22:30
*** lifeless has joined #openstack-nova22:31
*** lifeless_ has quit IRC22:31
*** shaohe_feng has quit IRC22:33
*** klindgren_ has joined #openstack-nova22:33
*** yamamoto has joined #openstack-nova22:34
*** shaohe_feng has joined #openstack-nova22:34
*** wwriverrat has joined #openstack-nova22:35
*** kb__ has joined #openstack-nova22:35
kb__I am running Mitaka with log leve in nova.conf set to INFO.. I want to capture the compute host info in any of the nova-*.logs . Setting up Verbose=True doesn't help, only setting debug=True in the nova.conf displays the compute host info.22:36
kb__Is there a way to display compute host info while having log level set to INFO.22:36
*** yamamoto has quit IRC22:38
*** shaohe_feng has quit IRC22:44
*** shaohe_feng has joined #openstack-nova22:45
*** mriedem has joined #openstack-nova22:48
*** shaohe_feng has quit IRC22:54
*** shaohe_feng has joined #openstack-nova22:55
*** chyka has quit IRC22:58
*** fragatina has quit IRC22:58
*** hongbin has quit IRC22:59
*** fragatina has joined #openstack-nova22:59
*** cdent_ has joined #openstack-nova23:03
*** cdent has quit IRC23:04
*** cdent_ is now known as cdent23:04
*** shaohe_feng has quit IRC23:04
*** r-daneel has quit IRC23:05
*** shaohe_feng has joined #openstack-nova23:05
*** salv-orlando has joined #openstack-nova23:08
*** salv-orlando has quit IRC23:12
*** yassine has joined #openstack-nova23:14
*** yassine is now known as Guest7564823:14
*** shaohe_feng has quit IRC23:14
*** shaohe_feng has joined #openstack-nova23:16
*** blkart has quit IRC23:17
*** blkart has joined #openstack-nova23:17
*** Guest75648 has quit IRC23:24
*** cdent_ has joined #openstack-nova23:24
*** shaohe_feng has quit IRC23:25
*** shaohe_feng has joined #openstack-nova23:25
*** cdent has quit IRC23:26
*** cdent_ is now known as cdent23:26
*** esbergl__ has joined #openstack-nova23:27
*** esberglu_ has quit IRC23:30
*** yassine_ has joined #openstack-nova23:32
*** takashin has joined #openstack-nova23:34
*** shaohe_feng has quit IRC23:35
*** bigdogstl has joined #openstack-nova23:35
*** klindgren__ has joined #openstack-nova23:35
*** pooja-jadhav has joined #openstack-nova23:36
*** bhagyashri_s has joined #openstack-nova23:36
*** klindgren_ has quit IRC23:36
*** shaohe_feng has joined #openstack-nova23:38
*** pooja_jadhav has quit IRC23:39
*** bhagyashris has quit IRC23:39
*** moshele has joined #openstack-nova23:41
*** shaohe_feng has quit IRC23:45
*** bigdogstl has quit IRC23:46
*** shaohe_feng has joined #openstack-nova23:46
*** kb__ has quit IRC23:46
*** mriedem has quit IRC23:48
*** masber has joined #openstack-nova23:49
*** bigdogstl has joined #openstack-nova23:49
*** stakeda has joined #openstack-nova23:51
*** masuberu has quit IRC23:52
*** shaohe_feng has quit IRC23:55
*** rodolof has quit IRC23:56
*** bigdogstl has quit IRC23:56
*** rodolof has joined #openstack-nova23:57
*** shaohe_feng has joined #openstack-nova23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!