| *** shaohe_feng has quit IRC | 00:06 | |
| *** shaohe_feng has joined #openstack-nova | 00:08 | |
| *** gyee has quit IRC | 00:09 | |
| *** medberry has quit IRC | 00:12 | |
| *** jmlowe has joined #openstack-nova | 00:13 | |
| *** ccamacho has quit IRC | 00:14 | |
| *** shaohe_feng has quit IRC | 00:16 | |
| *** shaohe_feng has joined #openstack-nova | 00:20 | |
| *** chyka has quit IRC | 00:23 | |
| *** shaohe_feng has quit IRC | 00:27 | |
| *** shaohe_feng has joined #openstack-nova | 00:27 | |
| *** yamamoto has joined #openstack-nova | 00:34 | |
| *** shaohe_feng has quit IRC | 00:37 | |
| *** medberry has joined #openstack-nova | 00:37 | |
| *** shaohe_feng has joined #openstack-nova | 00:38 | |
| *** yamamoto has quit IRC | 00:39 | |
| *** shaohe_feng has quit IRC | 00:47 | |
| *** shaohe_feng has joined #openstack-nova | 00:48 | |
| *** ccamacho has joined #openstack-nova | 00:48 | |
| *** swamireddy has quit IRC | 00:49 | |
| *** jamesdenton has joined #openstack-nova | 00:52 | |
| *** shaohe_feng has quit IRC | 00:57 | |
| *** isq has quit IRC | 00:58 | |
| *** isq has joined #openstack-nova | 00:58 | |
| *** shaohe_feng has joined #openstack-nova | 00:59 | |
| *** tiendc has joined #openstack-nova | 00:59 | |
| *** takashin has joined #openstack-nova | 01:01 | |
| *** swamireddy has joined #openstack-nova | 01:01 | |
| takashin | oomichi: Would you review https://review.openstack.org/#/c/529520/ again? It got one +2. | 01:02 |
|---|---|---|
| openstackgerrit | Mike Lowe proposed openstack/nova master: Option needed for ceph rbd erasure coding support https://review.openstack.org/581055 | 01:04 |
| oomichi | takashin: thanks for doing this, +A | 01:06 |
| takashin | oomichi: Thanks! | 01:06 |
| *** hongbin has joined #openstack-nova | 01:08 | |
| *** shaohe_feng has quit IRC | 01:08 | |
| *** shaohe_feng has joined #openstack-nova | 01:09 | |
| *** masuberu has quit IRC | 01:09 | |
| *** chenyb4 has joined #openstack-nova | 01:10 | |
| *** shaohe_feng has quit IRC | 01:18 | |
| *** shaohe_feng has joined #openstack-nova | 01:21 | |
| *** shaohe_feng has quit IRC | 01:28 | |
| *** wwriverrat has quit IRC | 01:29 | |
| *** masber has joined #openstack-nova | 01:29 | |
| *** shaohe_feng has joined #openstack-nova | 01:30 | |
| *** wwriverrat has joined #openstack-nova | 01:30 | |
| *** wwriverrat has quit IRC | 01:31 | |
| *** mrsoul_ has joined #openstack-nova | 01:31 | |
| *** wwriverrat has joined #openstack-nova | 01:31 | |
| *** mrsoul` has joined #openstack-nova | 01:31 | |
| yikun | mriedem, dansmith, Thanks for your help on group policy patch~and I will address left comments today. | 01:34 |
| *** mrsoul has quit IRC | 01:34 | |
| *** mschuppert has quit IRC | 01:34 | |
| *** wwriverrat has quit IRC | 01:38 | |
| *** shaohe_feng has quit IRC | 01:38 | |
| *** moshele has joined #openstack-nova | 01:39 | |
| *** shaohe_feng has joined #openstack-nova | 01:40 | |
| *** ccamacho has quit IRC | 01:41 | |
| *** yamahata has quit IRC | 01:46 | |
| *** lei-zh has joined #openstack-nova | 01:48 | |
| *** shaohe_feng has quit IRC | 01:49 | |
| *** shaohe_feng has joined #openstack-nova | 01:50 | |
| *** andymccr has quit IRC | 01:57 | |
| *** andymccr has joined #openstack-nova | 01:57 | |
| *** shaohe_feng has quit IRC | 01:59 | |
| *** shaohe_feng has joined #openstack-nova | 02:00 | |
| *** oomichi has quit IRC | 02:05 | |
| openstackgerrit | huanhongda proposed openstack/nova stable/queens: [Stable Only] Remove soft-deleted instances from quota_usages https://review.openstack.org/579093 | 02:08 |
| *** shaohe_feng has quit IRC | 02:09 | |
| *** ircuser-1 has quit IRC | 02:10 | |
| *** shaohe_feng has joined #openstack-nova | 02:10 | |
| *** masuberu has joined #openstack-nova | 02:12 | |
| *** jmlowe_ has joined #openstack-nova | 02:13 | |
| *** spotz_ has joined #openstack-nova | 02:14 | |
| *** damien_r has joined #openstack-nova | 02:14 | |
| *** wwriverrat has joined #openstack-nova | 02:15 | |
| *** shaohe_feng_ has joined #openstack-nova | 02:15 | |
| *** corvus_ has joined #openstack-nova | 02:17 | |
| *** burt has quit IRC | 02:19 | |
| *** kaisers has quit IRC | 02:19 | |
| *** rnoriega has quit IRC | 02:19 | |
| *** corvus has quit IRC | 02:19 | |
| *** masber has quit IRC | 02:19 | |
| *** vishakha has quit IRC | 02:19 | |
| *** krtaylor has quit IRC | 02:19 | |
| *** tojuvone has quit IRC | 02:19 | |
| *** aarents has quit IRC | 02:19 | |
| *** sgordon has quit IRC | 02:19 | |
| *** brtknr has quit IRC | 02:19 | |
| *** bandini has quit IRC | 02:19 | |
| *** karimull1 has joined #openstack-nova | 02:19 | |
| *** krtaylor has joined #openstack-nova | 02:19 | |
| *** spotz has quit IRC | 02:19 | |
| *** jmlowe has quit IRC | 02:19 | |
| *** _pewp_ has quit IRC | 02:19 | |
| *** karimull has quit IRC | 02:19 | |
| *** shaohe_feng has quit IRC | 02:19 | |
| *** damien_r1 has quit IRC | 02:19 | |
| *** lei-zh has quit IRC | 02:19 | |
| *** jamesdenton has quit IRC | 02:19 | |
| *** ivve has quit IRC | 02:19 | |
| *** tobasco has quit IRC | 02:19 | |
| *** kukacz_ has quit IRC | 02:19 | |
| *** shaohe_feng_ has quit IRC | 02:19 | |
| *** shaohe_feng_ has joined #openstack-nova | 02:19 | |
| *** burt1 has joined #openstack-nova | 02:19 | |
| *** _pewp_ has joined #openstack-nova | 02:19 | |
| *** shaohe_feng_ is now known as shaohe_feng | 02:19 | |
| *** sgordon` has joined #openstack-nova | 02:19 | |
| *** vishakha has joined #openstack-nova | 02:19 | |
| *** sgordon` is now known as sgordon | 02:19 | |
| *** shaohe_feng has quit IRC | 02:19 | |
| *** tojuvone has joined #openstack-nova | 02:20 | |
| *** rnoriega has joined #openstack-nova | 02:20 | |
| *** kaisers has joined #openstack-nova | 02:20 | |
| *** kaisers has quit IRC | 02:20 | |
| *** krtaylor has quit IRC | 02:20 | |
| *** karimull1 has quit IRC | 02:20 | |
| *** aarents has joined #openstack-nova | 02:20 | |
| *** karimull has joined #openstack-nova | 02:21 | |
| *** brtknr has joined #openstack-nova | 02:21 | |
| *** tobasco has joined #openstack-nova | 02:22 | |
| *** shaohe_feng has joined #openstack-nova | 02:25 | |
| *** bandini has joined #openstack-nova | 02:25 | |
| *** kaisers has joined #openstack-nova | 02:25 | |
| *** krtaylor has joined #openstack-nova | 02:25 | |
| *** shaohe_feng has quit IRC | 02:25 | |
| *** shaohe_feng has joined #openstack-nova | 02:25 | |
| *** ivve has joined #openstack-nova | 02:28 | |
| *** shaohe_feng has quit IRC | 02:30 | |
| *** kukacz_ has joined #openstack-nova | 02:30 | |
| *** shaohe_feng has joined #openstack-nova | 02:30 | |
| *** hoonetorg has quit IRC | 02:31 | |
| *** shaohe_feng has quit IRC | 02:40 | |
| *** shaohe_feng has joined #openstack-nova | 02:41 | |
| *** psachin has joined #openstack-nova | 02:45 | |
| *** hoonetorg has joined #openstack-nova | 02:47 | |
| *** shaohe_feng has quit IRC | 02:50 | |
| *** shaohe_feng has joined #openstack-nova | 02:52 | |
| *** mriedem has quit IRC | 02:54 | |
| *** moshele has quit IRC | 02:54 | |
| *** shaohe_feng has quit IRC | 03:00 | |
| *** shaohe_feng has joined #openstack-nova | 03:02 | |
| *** sapd_ has joined #openstack-nova | 03:04 | |
| *** sapd__ has quit IRC | 03:04 | |
| *** shaohe_feng has quit IRC | 03:11 | |
| *** shaohe_feng has joined #openstack-nova | 03:12 | |
| *** ccamacho has joined #openstack-nova | 03:18 | |
| *** shaohe_feng has quit IRC | 03:21 | |
| *** shaohe_feng has joined #openstack-nova | 03:24 | |
| *** shaohe_feng has quit IRC | 03:31 | |
| *** shaohe_feng has joined #openstack-nova | 03:33 | |
| *** Guest61318 has quit IRC | 03:34 | |
| *** Guest61318 has joined #openstack-nova | 03:35 | |
| *** corvus_ is now known as corvus | 03:36 | |
| *** corvus is now known as Guest78457 | 03:37 | |
| *** Guest78457 is now known as jeblair | 03:38 | |
| *** hongbin has quit IRC | 03:39 | |
| *** shaohe_feng has quit IRC | 03:41 | |
| *** jeblair is now known as corvus | 03:43 | |
| *** masuberu has quit IRC | 03:43 | |
| *** shaohe_feng has joined #openstack-nova | 03:47 | |
| *** udesale has joined #openstack-nova | 03:48 | |
| *** lpetrut has joined #openstack-nova | 03:48 | |
| *** Bhujay has joined #openstack-nova | 03:49 | |
| *** shaohe_feng has quit IRC | 03:52 | |
| *** yamamoto has joined #openstack-nova | 03:52 | |
| *** shaohe_feng has joined #openstack-nova | 03:53 | |
| *** shaohe_feng has quit IRC | 04:02 | |
| *** tetsuro has joined #openstack-nova | 04:03 | |
| *** shaohe_feng has joined #openstack-nova | 04:05 | |
| *** lpetrut has quit IRC | 04:08 | |
| *** medberry has quit IRC | 04:08 | |
| *** lpetrut has joined #openstack-nova | 04:09 | |
| *** ccamacho has quit IRC | 04:09 | |
| *** mdnadeem has joined #openstack-nova | 04:11 | |
| *** hongbin has joined #openstack-nova | 04:12 | |
| *** shaohe_feng has quit IRC | 04:12 | |
| *** shaohe_feng has joined #openstack-nova | 04:13 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object https://review.openstack.org/563375 | 04:17 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | 04:17 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Change the ServerGroupAntiAffinityFilter to adapt to new policy https://review.openstack.org/571166 | 04:17 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465 | 04:17 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 04:17 |
| *** hongbin has quit IRC | 04:20 | |
| *** shaohe_feng has quit IRC | 04:22 | |
| *** shaohe_feng has joined #openstack-nova | 04:24 | |
| *** jappleii__ has quit IRC | 04:25 | |
| *** threestrands has joined #openstack-nova | 04:25 | |
| openstackgerrit | Merged openstack/nova master: Add rules column to instance_group_policy table. https://review.openstack.org/560832 | 04:28 |
| *** shaohe_feng has quit IRC | 04:33 | |
| *** shaohe_feng has joined #openstack-nova | 04:33 | |
| *** janki has joined #openstack-nova | 04:35 | |
| *** lpetrut has quit IRC | 04:35 | |
| *** yamamoto_ has joined #openstack-nova | 04:42 | |
| *** shaohe_feng has quit IRC | 04:43 | |
| *** shaohe_feng has joined #openstack-nova | 04:44 | |
| *** yamamoto has quit IRC | 04:45 | |
| *** brault has joined #openstack-nova | 04:49 | |
| *** abhishekk has joined #openstack-nova | 04:53 | |
| *** moshele has joined #openstack-nova | 04:53 | |
| *** shaohe_feng has quit IRC | 04:53 | |
| *** shaohe_feng has joined #openstack-nova | 04:54 | |
| *** brault has quit IRC | 04:54 | |
| *** moshele has quit IRC | 04:55 | |
| *** shaohe_feng has quit IRC | 05:03 | |
| *** shaohe_feng has joined #openstack-nova | 05:05 | |
| *** shaohe_feng has quit IRC | 05:14 | |
| *** shaohe_feng has joined #openstack-nova | 05:15 | |
| *** yamamoto_ has quit IRC | 05:16 | |
| *** lpetrut has joined #openstack-nova | 05:18 | |
| *** links has joined #openstack-nova | 05:22 | |
| *** shaohe_feng has quit IRC | 05:24 | |
| *** shaohe_feng has joined #openstack-nova | 05:26 | |
| *** ratailor has joined #openstack-nova | 05:32 | |
| *** quiquell|off is now known as quiquell | 05:33 | |
| *** lpetrut has quit IRC | 05:33 | |
| *** shaohe_feng has quit IRC | 05:34 | |
| *** yamamoto has joined #openstack-nova | 05:35 | |
| *** shaohe_feng has joined #openstack-nova | 05:36 | |
| *** jichen has joined #openstack-nova | 05:38 | |
| *** Guest61318 has quit IRC | 05:44 | |
| *** shaohe_feng has quit IRC | 05:44 | |
| *** armaan has joined #openstack-nova | 05:45 | |
| *** shaohe_feng has joined #openstack-nova | 05:45 | |
| *** brault has joined #openstack-nova | 05:45 | |
| openstackgerrit | huanhongda proposed openstack/nova master: Remove duplicate parameter in API sample documents https://review.openstack.org/581203 | 05:47 |
| *** Luzi has joined #openstack-nova | 05:47 | |
| *** brault has quit IRC | 05:50 | |
| *** brault has joined #openstack-nova | 05:51 | |
| *** Guest61318 has joined #openstack-nova | 05:53 | |
| *** shaohe_feng has quit IRC | 05:55 | |
| *** moshele has joined #openstack-nova | 05:55 | |
| *** shaohe_feng has joined #openstack-nova | 05:55 | |
| *** shaohe_feng has quit IRC | 06:05 | |
| *** shaohe_feng has joined #openstack-nova | 06:06 | |
| *** hshiina has joined #openstack-nova | 06:09 | |
| *** sidx64 has joined #openstack-nova | 06:09 | |
| openstackgerrit | Merged openstack/nova master: Remove mox in unit/network/test_neutronv2.py (2) https://review.openstack.org/573481 | 06:10 |
| openstackgerrit | Merged openstack/nova master: Allow templated cell_mapping URLs https://review.openstack.org/578163 | 06:10 |
| openstackgerrit | Merged openstack/nova master: api-ref: Example verification for servers.inc https://review.openstack.org/529520 | 06:10 |
| openstackgerrit | Merged openstack/nova master: placement: delete auto-created consumers on fail https://review.openstack.org/579921 | 06:10 |
| openstackgerrit | Merged openstack/nova master: delete consumers which no longer have allocations https://review.openstack.org/581086 | 06:10 |
| *** shaohe_feng has quit IRC | 06:15 | |
| *** shaohe_feng has joined #openstack-nova | 06:16 | |
| *** andreas_s has joined #openstack-nova | 06:17 | |
| *** mrsoul_ is now known as mschuppert | 06:20 | |
| *** shaohe_feng has quit IRC | 06:25 | |
| *** shaohe_feng has joined #openstack-nova | 06:26 | |
| *** abhishekk has quit IRC | 06:26 | |
| *** yamahata has joined #openstack-nova | 06:27 | |
| *** medberry has joined #openstack-nova | 06:27 | |
| *** medberry has quit IRC | 06:27 | |
| *** medberry has joined #openstack-nova | 06:27 | |
| *** ispp has joined #openstack-nova | 06:29 | |
| *** med_ has quit IRC | 06:29 | |
| *** armaan has quit IRC | 06:30 | |
| *** threestrands has quit IRC | 06:30 | |
| *** armaan has joined #openstack-nova | 06:31 | |
| *** hamzy has quit IRC | 06:31 | |
| *** armaan has quit IRC | 06:35 | |
| *** mdnadeem has quit IRC | 06:35 | |
| *** shaohe_feng has quit IRC | 06:36 | |
| *** links has quit IRC | 06:38 | |
| *** shaohe_feng has joined #openstack-nova | 06:39 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Complete the api-ref of security group rule https://review.openstack.org/580109 | 06:41 |
| *** abhishekk has joined #openstack-nova | 06:42 | |
| *** shaohe_feng has quit IRC | 06:46 | |
| *** shaohe_feng has joined #openstack-nova | 06:46 | |
| *** naichuans_ has quit IRC | 06:47 | |
| *** mdnadeem has joined #openstack-nova | 06:48 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/578019 | 06:48 |
| *** ccamacho has joined #openstack-nova | 06:50 | |
| openstackgerrit | Neha Alhat proposed openstack/python-novaclient master: Remove initialization of logger if logger is None https://review.openstack.org/581218 | 06:51 |
| *** links has joined #openstack-nova | 06:53 | |
| *** lpetrut has joined #openstack-nova | 06:53 | |
| *** shaohe_feng has quit IRC | 06:56 | |
| *** shaohe_feng has joined #openstack-nova | 06:57 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add unshelve instance error info to fault table https://review.openstack.org/579747 | 06:59 |
| *** tssurya has joined #openstack-nova | 06:59 | |
| *** armaan has joined #openstack-nova | 07:00 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add unshelve instance error info to fault table https://review.openstack.org/579747 | 07:01 |
| *** hiro-kobayashi has joined #openstack-nova | 07:01 | |
| *** shaohe_feng has quit IRC | 07:06 | |
| *** aloga has joined #openstack-nova | 07:07 | |
| *** shaohe_feng has joined #openstack-nova | 07:07 | |
| *** mgoddard has joined #openstack-nova | 07:07 | |
| *** sidx64 has quit IRC | 07:09 | |
| *** phuongnh has joined #openstack-nova | 07:10 | |
| *** phuongnh has quit IRC | 07:11 | |
| *** sidx64 has joined #openstack-nova | 07:11 | |
| *** phuongnh has joined #openstack-nova | 07:11 | |
| *** tesseract has joined #openstack-nova | 07:13 | |
| *** hiro-kobayashi has quit IRC | 07:14 | |
| *** shaohe_feng has quit IRC | 07:17 | |
| *** jmccarthy has joined #openstack-nova | 07:17 | |
| *** shaohe_feng has joined #openstack-nova | 07:18 | |
| *** alexchadin has joined #openstack-nova | 07:19 | |
| *** peereb has joined #openstack-nova | 07:19 | |
| *** ragiman has joined #openstack-nova | 07:20 | |
| *** yamahata has quit IRC | 07:25 | |
| *** yamahata has joined #openstack-nova | 07:26 | |
| *** hamzy has joined #openstack-nova | 07:27 | |
| *** shaohe_feng has quit IRC | 07:27 | |
| *** sahid has joined #openstack-nova | 07:27 | |
| *** shaohe_feng has joined #openstack-nova | 07:28 | |
| *** abhishekk has quit IRC | 07:30 | |
| openstackgerrit | karim proposed openstack/nova master: Handle rebuild of instances with image traits https://review.openstack.org/569498 | 07:35 |
| *** shaohe_feng has quit IRC | 07:37 | |
| *** shaohe_feng has joined #openstack-nova | 07:38 | |
| *** mgoddard has quit IRC | 07:41 | |
| *** ispp has quit IRC | 07:43 | |
| *** links has quit IRC | 07:44 | |
| *** abhishekk has joined #openstack-nova | 07:46 | |
| *** rcernin has quit IRC | 07:47 | |
| *** shaohe_feng has quit IRC | 07:47 | |
| *** amoralej|off is now known as amoralej | 07:48 | |
| *** shaohe_feng has joined #openstack-nova | 07:49 | |
| *** alexchadin has quit IRC | 07:50 | |
| *** shaohe_feng has quit IRC | 07:50 | |
| *** shaohe_feng has joined #openstack-nova | 07:50 | |
| *** alexchadin has joined #openstack-nova | 07:52 | |
| *** sq4ind has left #openstack-nova | 07:54 | |
| *** links has joined #openstack-nova | 07:57 | |
| *** shaohe_feng has quit IRC | 07:58 | |
| *** shaohe_feng has joined #openstack-nova | 07:59 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova-specs master: Fix nits in the handling down cell spec https://review.openstack.org/581243 | 08:01 |
| openstackgerrit | huanhongda proposed openstack/nova master: Microversion 2.64 - Add "deleted" time in GET server response https://review.openstack.org/574159 | 08:02 |
| *** sidx64 has quit IRC | 08:02 | |
| *** takashin has left #openstack-nova | 08:02 | |
| *** ttsiouts has joined #openstack-nova | 08:05 | |
| *** mgoddard has joined #openstack-nova | 08:06 | |
| *** shaohe_feng has quit IRC | 08:08 | |
| *** shaohe_feng has joined #openstack-nova | 08:09 | |
| *** rodolof has joined #openstack-nova | 08:11 | |
| *** derekh has joined #openstack-nova | 08:15 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | 08:17 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459 | 08:17 |
| *** shaohe_feng has quit IRC | 08:18 | |
| *** shaohe_feng has joined #openstack-nova | 08:19 | |
| *** hshiina has quit IRC | 08:22 | |
| *** sidx64 has joined #openstack-nova | 08:26 | |
| *** bkopilov has quit IRC | 08:26 | |
| *** vishakha has quit IRC | 08:28 | |
| *** shaohe_feng has quit IRC | 08:29 | |
| *** bkopilov has joined #openstack-nova | 08:30 | |
| *** shaohe_feng has joined #openstack-nova | 08:30 | |
| *** rmart04 has joined #openstack-nova | 08:32 | |
| *** sridharg has joined #openstack-nova | 08:36 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 08:36 |
| *** yamahata has quit IRC | 08:38 | |
| *** shaohe_feng has quit IRC | 08:39 | |
| *** shaohe_feng has joined #openstack-nova | 08:40 | |
| *** hiro-kobayashi has joined #openstack-nova | 08:47 | |
| *** toabctl has quit IRC | 08:48 | |
| *** shaohe_feng has quit IRC | 08:49 | |
| openstackgerrit | Vu Cong Tuan proposed openstack/os-traits master: Switch to stestr https://review.openstack.org/581265 | 08:49 |
| *** mago_ has joined #openstack-nova | 08:51 | |
| *** shaohe_feng has joined #openstack-nova | 08:51 | |
| *** toabctl has joined #openstack-nova | 08:54 | |
| *** sidx64 has quit IRC | 08:55 | |
| *** priteau has joined #openstack-nova | 08:55 | |
| *** sidx64 has joined #openstack-nova | 08:56 | |
| *** cdent has joined #openstack-nova | 08:56 | |
| *** shaohe_feng has quit IRC | 08:59 | |
| *** shaohe_feng has joined #openstack-nova | 09:00 | |
| *** bkopilov has quit IRC | 09:05 | |
| *** bkopilov has joined #openstack-nova | 09:06 | |
| *** mago_ has quit IRC | 09:06 | |
| *** flwang1 has joined #openstack-nova | 09:09 | |
| *** shaohe_feng has quit IRC | 09:10 | |
| *** Guest61318 has quit IRC | 09:10 | |
| *** shaohe_feng has joined #openstack-nova | 09:11 | |
| flwang1 | greetings, can anybody help me understand how the local_gb set for hypervisor? | 09:11 |
| *** sambetts_ is now known as sambetts | 09:12 | |
| *** sidx64 has quit IRC | 09:13 | |
| flwang1 | after installed devstack, i found the local_gb of hypervisor is so small, but i have a big cinder volume vg, stack-volumes-default 1 0 0 wz--n- 100.00g 100.00g | 09:13 |
| flwang1 | so the question is, how can I let the hypervisor to use the stack-volumes? thanks | 09:14 |
| *** jangutter has quit IRC | 09:15 | |
| *** ccamacho has quit IRC | 09:16 | |
| *** ratailor has quit IRC | 09:17 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add queued for delete to instance_mappings table. https://review.openstack.org/566788 | 09:18 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add queued_for_delete field to InstanceMapping object https://review.openstack.org/566795 | 09:18 |
| *** vivsoni has joined #openstack-nova | 09:18 | |
| *** ratailor has joined #openstack-nova | 09:19 | |
| *** sidx64 has joined #openstack-nova | 09:19 | |
| *** shaohe_feng has quit IRC | 09:20 | |
| *** shaohe_feng has joined #openstack-nova | 09:20 | |
| fanzhang | hi flwang1 I think it's the resource tracker updates the hypervisor info. As for the loca_gb, check configuration option 'state_path' in /etc/nova/nova.conf, you can change this item with your cinder volume vg path | 09:22 |
| openstackgerrit | Vu Cong Tuan proposed openstack/os-traits master: Switch to stestr https://review.openstack.org/581265 | 09:24 |
| * fanzhang e.g. I have changed state_path=/mnt/vdc/nova which I mounted a 500G volume on it /dev/vdc1 493G 1.2G 466G 1% /mnt/vdc | 09:25 | |
| fanzhang | flwang1 ^ | 09:25 |
| jmccarthy | Is it a common problem, when deleting instances, that volumes which were attached to it may be left with stuck attachments to the instance afterwards ? (queens) | 09:25 |
| *** Guest61318 has joined #openstack-nova | 09:25 | |
| *** deepak_mourya has quit IRC | 09:26 | |
| flwang1 | fanzhang: cool, i will give it a try | 09:26 |
| flwang1 | cheers | 09:26 |
| fanzhang | jmccarthy I think it's just about the hypervisor configuration :) | 09:27 |
| fanzhang | flwang1 good luck \o/ | 09:27 |
| *** sidx64 has quit IRC | 09:28 | |
| flwang1 | fanzhang: seems it doesn't work | 09:29 |
| openstackgerrit | Vu Cong Tuan proposed openstack/nova-specs master: Switch to stestr https://review.openstack.org/581284 | 09:29 |
| jmccarthy | Oh I was asking about a different issue, I seem to have an issue with multiattach volumes that get stuck to instances which have been deleted | 09:29 |
| fanzhang | flwang1 do you restart openstack-nova-comput service? Try to wait awhile for periodic task updating the hypervisor info. | 09:30 |
| *** shaohe_feng has quit IRC | 09:30 | |
| *** itlinux has joined #openstack-nova | 09:30 | |
| *** shaohe_feng has joined #openstack-nova | 09:31 | |
| *** mdnadeem has quit IRC | 09:31 | |
| *** ccamacho has joined #openstack-nova | 09:33 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use hard coded values in schema than reference https://review.openstack.org/581288 | 09:35 |
| *** jangutter has joined #openstack-nova | 09:35 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use hard coded values in schema than reference https://review.openstack.org/581288 | 09:36 |
| *** mdnadeem has joined #openstack-nova | 09:37 | |
| *** shaohe_feng has quit IRC | 09:40 | |
| *** jmccarthy has left #openstack-nova | 09:42 | |
| *** shaohe_feng has joined #openstack-nova | 09:42 | |
| *** stakeda has quit IRC | 09:44 | |
| *** rcernin has joined #openstack-nova | 09:44 | |
| *** stakeda has joined #openstack-nova | 09:44 | |
| *** rcernin has quit IRC | 09:47 | |
| *** ratailor has quit IRC | 09:47 | |
| flwang1 | fanzhang: i restarted all nova services and wait quite a white | 09:48 |
| flwang1 | while | 09:48 |
| flwang1 | but it's still using my root and it's 30GB | 09:48 |
| *** ratailor has joined #openstack-nova | 09:48 | |
| fanzhang | flwang1 emmm...it's odd... | 09:49 |
| *** shaohe_feng has quit IRC | 09:51 | |
| fanzhang | oh, do you change the folder's owner and owning group with nova:nova ? | 09:51 |
| fanzhang | flwang1 | 09:52 |
| *** shaohe_feng has joined #openstack-nova | 09:52 | |
| flwang1 | fanzhang: nope, let me try | 09:52 |
| flwang1 | oh, i don't have nova user in my system | 09:53 |
| *** sidx64 has joined #openstack-nova | 09:54 | |
| *** zhangbailin_ has joined #openstack-nova | 09:55 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 09:56 |
| *** itlinux has quit IRC | 09:56 | |
| fanzhang | flwang1 emmm...my env is packstack, and I am pretty sure I have nova user :) Check the owner and owning group of your folder on previous state_patch ? | 09:58 |
| *** mago_ has joined #openstack-nova | 09:58 | |
| flwang1 | i did and i'm using the same user/user group and it still doesn't work :( | 09:58 |
| *** sidx64 has quit IRC | 09:59 | |
| flwang1 | fanzhang: i will monitor it for a while and will see | 09:59 |
| sapd_ | Hi everyone. I'm looking for the change which implement rebuild for volume-backed instance. | 10:01 |
| *** shaohe_feng has quit IRC | 10:01 | |
| flwang1 | sapd_: that's the one i worked on 3 years ago :( | 10:01 |
| flwang1 | and i failed | 10:01 |
| fanzhang | flwang1 ok, good luck :) | 10:02 |
| flwang1 | fanzhang: thank you very much anyway ;) | 10:02 |
| *** shaohe_feng has joined #openstack-nova | 10:02 | |
| openstackgerrit | huanhongda proposed openstack/nova master: Microversion 2.64 - Add "deleted" time in GET server response https://review.openstack.org/574159 | 10:02 |
| sapd_ | flwang1: I'm using this patch https://review.openstack.org/#/c/528740/ for Pike release, But when I apply this patch for Queens release, It's not work again. | 10:02 |
| *** Guest61318 has quit IRC | 10:03 | |
| openstackgerrit | Merged openstack/nova master: Regression test for bug 1779818 https://review.openstack.org/580011 | 10:03 |
| openstack | bug 1779818 in OpenStack Compute (nova) "child's root provider is not updated." [Medium,In progress] https://launchpad.net/bugs/1779818 - Assigned to Tetsuro Nakamura (tetsuro0907) | 10:03 |
| *** itlinux has joined #openstack-nova | 10:04 | |
| *** ttsiouts has quit IRC | 10:07 | |
| *** sidx64 has joined #openstack-nova | 10:09 | |
| *** neha_alhat_ has joined #openstack-nova | 10:10 | |
| neha_alhat_ | cdent: Hi | 10:10 |
| *** shaohe_feng has quit IRC | 10:11 | |
| *** sapd_ has quit IRC | 10:11 | |
| *** sapd has joined #openstack-nova | 10:11 | |
| *** shaohe_feng has joined #openstack-nova | 10:12 | |
| *** chenyb4 has quit IRC | 10:12 | |
| cdent | hi neha_alhat_ | 10:12 |
| stephenfin | sahid: Comments left on https://review.openstack.org/#/c/580657. Fancy taking a look? | 10:12 |
| neha_alhat_ | cdent: For some performance testing I want to create 100 RPs, for that I am writing python code. | 10:13 |
| * cdent nods | 10:13 | |
| neha_alhat_ | cdent: 100 Resource providers* | 10:13 |
| neha_alhat_ | cdent: using openstackclient: openstack resource provider create rp1 | 10:14 |
| stephenfin | mdbooth, lyarwood: I'm guessing this failing test is a race or the likes in our unit tests? http://logs.openstack.org/57/580657/2/check/openstack-tox-lower-constraints/607ab0c/job-output.txt.gz | 10:14 |
| stephenfin | Looks unrelated to the actual change https://review.openstack.org/#/c/580657 | 10:15 |
| *** yamamoto has quit IRC | 10:15 | |
| mdbooth | stephenfin: clicking | 10:15 |
| *** Bhujay has quit IRC | 10:15 | |
| *** Bhujay has joined #openstack-nova | 10:15 | |
| cdent | neha_alhat_: if you do that in a loop with a different name each time, that ought to work. another way to do it is directly in python code that makes its own http requests to the service | 10:17 |
| *** Bhujay has quit IRC | 10:17 | |
| neha_alhat_ | cdent: But I am unable to create novaclient using openstackclient in python code. Like we can do in cinderclient: https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/client.py#L51 | 10:17 |
| mdbooth | stephenfin: Weird! | 10:17 |
| *** Bhujay has joined #openstack-nova | 10:18 | |
| stephenfin | Right? It's the lower constraints job so we're using different requirements to usual but I can't see how that would be an issue | 10:18 |
| *** Bhujay has quit IRC | 10:19 | |
| mdbooth | stephenfin: I hit failures in those tests recently which didn't hit on python2. Any chance they run a different set of tests? | 10:19 |
| *** Bhujay has joined #openstack-nova | 10:19 | |
| neha_alhat_ | cdent: How can I create a http requests to the service through python code | 10:19 |
| stephenfin | mdbooth: What do you mean a different set of tests? | 10:19 |
| *** yamamoto has joined #openstack-nova | 10:19 | |
| neha_alhat_ | cdent: like https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/client.py#L51 | 10:20 |
| cdent | neha_alhat_: that's right, there is no "for use in code" placement client. This is because making your own is very straightforward. Have a look at the code around https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L270 for some ideas | 10:20 |
| mdbooth | stephenfin: i.e. it runs unit tests which don't run in py27 | 10:20 |
| stephenfin | I don't think so https://github.com/openstack/nova/blob/master/tox.ini#L249 | 10:20 |
| gibi | stephenfin: I think you see this https://bugs.launchpad.net/nova/+bug/1779711 | 10:20 |
| openstack | Launchpad bug 1779711 in OpenStack Compute (nova) "test_pre_live_migration_volume_backed* intermittently fails serialized json compare" [Critical,Fix released] - Assigned to Matt Riedemann (mriedem) | 10:20 |
| stephenfin | gibi: Yup, that looks like the one and the same | 10:20 |
| mdbooth | gibi: Whoa... | 10:21 |
| mdbooth | gibi: Ah... dict ordering | 10:21 |
| gibi | yeah, good old dict ordering | 10:21 |
| *** shaohe_feng has quit IRC | 10:21 | |
| stephenfin | gibi: Not the first thing I've been caught out by ordering in recent days :) | 10:21 |
| stephenfin | *first time | 10:21 |
| *** shaohe_feng has joined #openstack-nova | 10:22 | |
| *** mvk_ has quit IRC | 10:22 | |
| gibi | python 3.7 adds stable dict key ordering https://docs.python.org/3/tutorial/datastructures.html#dictionaries | 10:23 |
| mdbooth | Aren't all dicts ordered in the newest anguine offering? | 10:23 |
| stephenfin | fwiw, Python 3.6+ dicts are insertion ordered, which is rather nice | 10:23 |
| mdbooth | gibi: Snap ;) | 10:23 |
| stephenfin | mdbooth: double snap | 10:23 |
| gibi | :D | 10:23 |
| stephenfin | I'm sure whoever is working on nova in 10 years or whenever we can drop Python < 3.6 support will be very happy | 10:24 |
| * kashyap wonders about those who will be debugging Nova live migration problems in 10 years... | 10:31 | |
| kashyap | (Maybe there won't be any.) | 10:31 |
| *** shaohe_feng has quit IRC | 10:32 | |
| *** phuongnh has quit IRC | 10:32 | |
| *** shaohe_feng has joined #openstack-nova | 10:33 | |
| neha_alhat_ | cdent: yes, will check. Thanks | 10:35 |
| *** stakeda has quit IRC | 10:37 | |
| *** abhishekk has quit IRC | 10:39 | |
| *** shaohe_feng has quit IRC | 10:42 | |
| *** shaohe_feng has joined #openstack-nova | 10:42 | |
| *** alexchadin has quit IRC | 10:43 | |
| *** alexchadin has joined #openstack-nova | 10:43 | |
| *** alexchadin has quit IRC | 10:44 | |
| *** yamamoto has quit IRC | 10:45 | |
| *** jichen has quit IRC | 10:48 | |
| *** mvk_ has joined #openstack-nova | 10:48 | |
| *** shaohe_feng has quit IRC | 10:52 | |
| *** pchavva has joined #openstack-nova | 10:55 | |
| *** shaohe_feng has joined #openstack-nova | 10:55 | |
| *** udesale has quit IRC | 10:56 | |
| *** sidx64 has quit IRC | 10:58 | |
| *** hiro-kobayashi has quit IRC | 11:00 | |
| *** tetsuro has quit IRC | 11:00 | |
| *** tiendc has quit IRC | 11:00 | |
| *** ttsiouts has joined #openstack-nova | 11:02 | |
| *** sidx64 has joined #openstack-nova | 11:02 | |
| *** shaohe_feng has quit IRC | 11:02 | |
| *** shaohe_feng has joined #openstack-nova | 11:04 | |
| *** sidx64 has quit IRC | 11:06 | |
| *** sidx64 has joined #openstack-nova | 11:07 | |
| *** yassine has joined #openstack-nova | 11:09 | |
| *** yassine is now known as Guest88425 | 11:09 | |
| *** shaohe_feng has quit IRC | 11:13 | |
| cdent | johnthetubaguy: you still happy with https://review.openstack.org/#/c/543262/ ? | 11:13 |
| *** shaohe_feng has joined #openstack-nova | 11:15 | |
| *** itlinux has quit IRC | 11:21 | |
| *** sidx64 has quit IRC | 11:21 | |
| *** blkart has quit IRC | 11:23 | |
| *** shaohe_feng has quit IRC | 11:23 | |
| *** shaohe_feng has joined #openstack-nova | 11:23 | |
| *** alexchadin has joined #openstack-nova | 11:24 | |
| *** edmondsw has joined #openstack-nova | 11:25 | |
| *** sidx64 has joined #openstack-nova | 11:31 | |
| *** yamamoto has joined #openstack-nova | 11:33 | |
| *** shaohe_feng has quit IRC | 11:33 | |
| *** shaohe_feng has joined #openstack-nova | 11:34 | |
| flwang1 | i'm going to ask again, can anybody help understand how to set the local_gb for hypervisor? thanks | 11:34 |
| *** sidx64 has quit IRC | 11:36 | |
| *** blkart has joined #openstack-nova | 11:40 | |
| jroll | flwang1: that's set by nova-compute when it updates its resources. it looks at the size of the block device that instances are on | 11:43 |
| *** vivsoni_ has joined #openstack-nova | 11:43 | |
| *** shaohe_feng has quit IRC | 11:43 | |
| flwang1 | jroll: thanks, then my question is how can i change it? | 11:43 |
| jroll | change local_gb? I don't believe you can. why do you want to? | 11:44 |
| *** vivsoni has quit IRC | 11:44 | |
| *** ttsiouts_ has joined #openstack-nova | 11:45 | |
| *** shaohe_feng has joined #openstack-nova | 11:45 | |
| flwang1 | after installed devstack, i found the local_gb is too small because it's using my root /, though i have almost 800GB at /home | 11:45 |
| jroll | ah | 11:45 |
| flwang1 | but my / only has 30GB | 11:45 |
| jroll | flwang1: there's a config option for where the instance data lives, you can change that | 11:46 |
| * jroll looks for it | 11:46 | |
| *** lyan has joined #openstack-nova | 11:46 | |
| *** lyan is now known as Guest23991 | 11:46 | |
| flwang1 | #instances_path = /opt/stack/data/nova/instances | 11:46 |
| flwang1 | #state_path = /opt/stack/data/nova | 11:46 |
| flwang1 | ? | 11:46 |
| jroll | yes, instances_path | 11:47 |
| *** ttsiouts has quit IRC | 11:47 | |
| flwang1 | i changed them both and doesn't work | 11:47 |
| jroll | did you restart nova-compute (and give it time to update resources)? | 11:48 |
| *** ispp has joined #openstack-nova | 11:48 | |
| flwang1 | yes, i did. i restarted all nova services | 11:48 |
| *** ttsiouts_ has quit IRC | 11:48 | |
| jroll | hm, that's odd. I'm not sure if there's something else that needs to be done, hopefully someone else can help, sorry | 11:49 |
| *** dpawlik_ has quit IRC | 11:50 | |
| flwang1 | jroll: no worries, thank you for the help | 11:50 |
| jroll | :) | 11:51 |
| *** ttsiouts has joined #openstack-nova | 11:51 | |
| efried | Anyone happen to know where it's documented how/where we, as developers, are supposed to use translation macros in code? | 11:52 |
| flwang1 | jroll: i think that's the issue, after restart the nova-compute, it's still trying to talk to the old path | 11:53 |
| flwang1 | not sure why | 11:53 |
| *** shaohe_feng has quit IRC | 11:54 | |
| jroll | yeah, that would be my guess | 11:54 |
| jroll | efried: this is a good start: https://docs.openstack.org/oslo.i18n/latest/user/guidelines.html | 11:54 |
| *** mgoddard has quit IRC | 11:54 | |
| efried | Thanks jroll | 11:54 |
| jroll | primarily "All text messages the user sees via exceptions or API calls should be marked for translation" | 11:55 |
| *** dpawlik has joined #openstack-nova | 11:55 | |
| efried | jroll: Yeah, I need something even more basic than that, for karimull. | 11:55 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Fix all invalid obj_make_compatible test case https://review.openstack.org/574240 | 11:55 |
| jroll | I'm not sure how to make that more basic :/ | 11:55 |
| *** amoralej is now known as amoralej|lunch | 11:55 | |
| *** shaohe_feng has joined #openstack-nova | 11:56 | |
| efried | jroll: See https://review.openstack.org/#/c/569498/10..11/nova/conductor/manager.py | 11:56 |
| *** med_ has joined #openstack-nova | 11:59 | |
| efried | I.e. need to describe what "marked for translation" means. I think that doc works. | 11:59 |
| jroll | efried: yeah, I don't have anything better | 11:59 |
| efried | karimull: After you've looked at the doc, let me know if you'd like some more background. | 12:00 |
| *** armaan has quit IRC | 12:00 | |
| *** armaan has joined #openstack-nova | 12:00 | |
| *** shaohe_feng has quit IRC | 12:04 | |
| *** shaohe_feng has joined #openstack-nova | 12:05 | |
| sahid | stephenfin: thanks for your eye on this. I just replied | 12:06 |
| openstackgerrit | Merged openstack/nova master: Handle compare in test_pre_live_migration_volume_backed* directly https://review.openstack.org/580702 | 12:07 |
| *** shaohe_feng has quit IRC | 12:14 | |
| *** sidx64 has joined #openstack-nova | 12:15 | |
| *** shaohe_feng has joined #openstack-nova | 12:15 | |
| *** markvoelker has quit IRC | 12:18 | |
| *** hamzy has quit IRC | 12:18 | |
| mago_ | Hi team, I'm working on GPU Passtrough on OpenStack. I would like to limit the number of GPUs available to a user / project. There is no quotas for Passthrough resources and I was wondering why ? I was googling around but found no where a similar question. | 12:18 |
| *** markvoelker has joined #openstack-nova | 12:21 | |
| mago_ | Side question, as quotas are not only for Nova, but also for the Network and Block Storage services, is there a better place to ask my question ? | 12:22 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/578261 | 12:23 |
| *** janki has quit IRC | 12:24 | |
| *** sidx64 has quit IRC | 12:24 | |
| efried | mago_: You mean like project-wide? Cause I would imagine there probably wouldn't be enough GPUs on a single host for quotas to make much sense. | 12:24 |
| *** shaohe_feng has quit IRC | 12:24 | |
| efried | mago_: but are you talking about physical or virtual GPUs? | 12:24 |
| *** shaohe_feng has joined #openstack-nova | 12:25 | |
| *** yamamoto has quit IRC | 12:26 | |
| jaypipes | johnthetubaguy: https://review.openstack.org/#/c/543262/ could use your +2 restoration. | 12:26 |
| *** yamamoto has joined #openstack-nova | 12:26 | |
| *** sidx64 has joined #openstack-nova | 12:27 | |
| mago_ | efried, well you could imagine a cluster with nodes with 4 to 8 GPU cards, if you have let's say 10 nodes, you can have up to 80 GPUs available. I think a quota would make sense. | 12:27 |
| jaypipes | mago_: there is no quota class for either virtual or physical GPUs, no. | 12:27 |
| mago_ | efried, I talk about GPU cards, passed to VMs using passthrough (also called Direct Device Assignment) | 12:28 |
| efried | mago_: Yup, got it. I defer to jaypipes here, perhaps he can explain why there are no quotas. | 12:29 |
| jaypipes | mago_: I can't explain *why* there are no quotas for GPUs. or at least, I can't explain that without some seriously opinionated rant about how our PCI manager system was created. | 12:30 |
| mago_ | jaypipes, do you know why, I mean is it technically not possible because of the way quotas are implemented, or could it be imagined ? for GPUs, or for passthrough resources in general | 12:31 |
| *** markvoelker has quit IRC | 12:31 | |
| jaypipes | mago_: quotas were not considered by the creators of the pci management module in nova. | 12:32 |
| jaypipes | mago_: when and if we move the management of PCI resources to the placement service, we will be able to use quotas for those PCI resource classes, but until then, it's not going to happen. | 12:33 |
| *** shaohe_feng has quit IRC | 12:35 | |
| mago_ | jaypipes, ok, understood. It does not seem to be an easy task, but do you know if this is already addressed / under discussion ? | 12:35 |
| *** markvoelker has joined #openstack-nova | 12:35 | |
| *** shaohe_feng has joined #openstack-nova | 12:35 | |
| mdbooth | stephenfin gibi: Do we have something like a fixture which perturbs dicts? Running nova.tests.unit.virt.libvirt.test_driver.LibvirtConnTestCase.test_pre_live_migration_volume_backed_encrypted fails for me literally every other time when running only that test. | 12:38 |
| mdbooth | It's weird. | 12:38 |
| mdbooth | I know dict order isn't guaranteed, but all things being equal I'd expect it to be consistent in practise unless something is deliberately making it inconsistent. | 12:39 |
| gibi | mdbooth: I don't think we have. I think the order depends on the PYTHONHASHSEED | 12:39 |
| jaypipes | mago_: we've been planning on moving the queries for calculation of resource usage out of the nova-api service and towards the placement service for a while (https://review.openstack.org/#/c/509042/) but until we are tracking all the different types of resources using the placement service consistently, such an effort is only ever going to yield a small benefit. PCI devices, NUMA topology and dedicated CPUs, and certain networking resources | 12:39 |
| jaypipes | like SR-IOV VFs are some of the resource types we do *not* currently track using the placement service. our work on nested resource providers, granular request groups, and the "reshaper" effort are paving the way to supporting these types of resources in the placement service. I predict that we'll have most of that work done by the end of the "T" release series, at which point the quotas-in-placement work can become a reality. | 12:39 |
| efried | mdbooth: There's an open bug and proposed fix for this. | 12:39 |
| mdbooth | efried: Yeah, we discussed it earlier. | 12:39 |
| efried | mdbooth: Okay, upon rereading I figured that's not what you were getting at :) | 12:40 |
| mdbooth | But even knowing the bug, I'm still surprised by the behaviour in practise. | 12:40 |
| efried | mdbooth: You mean that there's some apparent predictability to the unpredictability of the hash ordering? | 12:40 |
| mdbooth | I mean, I'd expect potentially different ordering if we were creating objects in a different order, or running things in a different order, or doing *anything* different. | 12:41 |
| mdbooth | But in 2 consecutive absolutely identical test runs I'm surprised to see a difference in behaviour unless we're intentionally perturbing it somehow. | 12:41 |
| gibi | mdbooth: try the same PYTHONHASHSEED | 12:41 |
| mago_ | jaypipes, efried thank you very much for the explanations. | 12:41 |
| gibi | mdbooth: I think if PYTHONHASHSEED=0 then you will get the same order every time | 12:43 |
| gibi | mdbooth: but by default PYTHONHASHSEED=random | 12:43 |
| mdbooth | gibi: PYTHONHASHSEED=1 ./.tox/lower-constraints/bin/python -m testtools.run nova.tests.unit.virt.libvirt.test_driver.LibvirtConnTestCase.test_pre_live_migration_volume_backed_encrypted | 12:44 |
| mdbooth | Still inconsistent | 12:44 |
| mdbooth | Meh, I was just curious | 12:44 |
| mdbooth | This doesn't actually matter in the slightest :) | 12:44 |
| gibi | :) | 12:44 |
| *** shaohe_feng has quit IRC | 12:45 | |
| *** shaohe_feng has joined #openstack-nova | 12:45 | |
| *** sidx64 has quit IRC | 12:45 | |
| jaypipes | mago_: np. sorry to not have great news! | 12:46 |
| *** mdnadeem has quit IRC | 12:47 | |
| *** amoralej|lunch is now known as amoralej | 12:49 | |
| *** danny is now known as dabukaam | 12:49 | |
| *** dabukaam is now known as dabukalam | 12:50 | |
| *** dabukalam has quit IRC | 12:50 | |
| *** dabukalam has joined #openstack-nova | 12:50 | |
| *** andreas_s has quit IRC | 12:53 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: [WIP/POC] Updating queued_for_delete from instance_destroy() https://review.openstack.org/566813 | 12:53 |
| jangutter | jaypipes: for SR-IOV VF's there's a rough a proxy: Neutron Ports can under quota.... but it's very very very leaky at best. | 12:53 |
| *** sidx64 has joined #openstack-nova | 12:54 | |
| jangutter | jaypipes: very difficult to see how that model would translate to GPU, though. | 12:54 |
| *** andreas_s has joined #openstack-nova | 12:54 | |
| *** shaohe_feng has quit IRC | 12:55 | |
| efried | cdent, jaypipes: +A on https://review.openstack.org/#/c/543262/ -- great stuff. | 12:57 |
| efried | johnthetubaguy: FYI ^ | 12:58 |
| *** shaohe_feng has joined #openstack-nova | 12:58 | |
| *** mriedem has joined #openstack-nova | 12:59 | |
| *** andreas_s_ has joined #openstack-nova | 13:00 | |
| *** andreas_s has quit IRC | 13:00 | |
| *** andreas_s_ has quit IRC | 13:00 | |
| *** andreas_s has joined #openstack-nova | 13:01 | |
| cdent | efried: On self.compute thing, it's been long enoug since I made that change that I can't remember the details :( | 13:03 |
| efried | no worries; gate-bound in any case. If it passes zuul, it's good enough for me. | 13:03 |
| *** mdnadeem has joined #openstack-nova | 13:04 | |
| efried | cdent: But as I'm sure you're aware, mock.patch.object(actual object, 'method') is not quite the same thing as mock.patch.object(path to lib containing method, 'method') | 13:04 |
| efried | cdent: But in this case I think both things were actually pointing to the lib ultimately. | 13:04 |
| efried | so in this case I think it *was* the same. | 13:04 |
| cdent | yes, that's why it ended up as it did, because the indirection of self.compute was meaningless | 13:05 |
| *** alexchadin has quit IRC | 13:05 | |
| *** mgoddard has joined #openstack-nova | 13:05 | |
| *** shaohe_feng has quit IRC | 13:05 | |
| *** eharney has joined #openstack-nova | 13:05 | |
| *** shaohe_feng has joined #openstack-nova | 13:06 | |
| *** sidx64 has quit IRC | 13:06 | |
| *** zhangbailin_ has quit IRC | 13:08 | |
| *** andreas_s has quit IRC | 13:09 | |
| *** sidx64 has joined #openstack-nova | 13:11 | |
| *** ispp has quit IRC | 13:11 | |
| openstackgerrit | Merged openstack/os-vif master: add noop plugin https://review.openstack.org/567924 | 13:12 |
| tssurya | mriedem, dansmith: do you have some time now or shall I ping you back later ? | 13:13 |
| mriedem | i'm here | 13:14 |
| *** andreas_s has joined #openstack-nova | 13:15 | |
| tssurya | mriedem: so is it documented somewhere that when a user does nova list --deleted, it silently ignores this | 13:15 |
| tssurya | without complaining about policy ? | 13:15 |
| *** shaohe_feng has quit IRC | 13:16 | |
| mriedem | for non-admins? | 13:16 |
| tssurya | yes | 13:16 |
| mriedem | i'm not aware of something saying it's not an error for non-admins | 13:16 |
| mriedem | https://docs.openstack.org/python-novaclient/latest/cli/nova.html#nova-list says (admin only) | 13:16 |
| tssurya | hmm okay then I will open a bug | 13:17 |
| mriedem | bug for what? | 13:17 |
| tssurya | because currently if you do nova list --deleted as a non-admin | 13:17 |
| tssurya | it just ignores the filter | 13:17 |
| tssurya | and gives you all the active instances | 13:17 |
| mriedem | it's been that way forever | 13:17 |
| mriedem | changing that would likely be a non-trivial backward incompatible behavior change in the api | 13:18 |
| *** shaohe_feng has joined #openstack-nova | 13:18 | |
| tssurya | oh so why do the rest of the admin only filters give policy errors | 13:18 |
| mriedem | see remove_invalid_options() | 13:18 |
| *** janki has joined #openstack-nova | 13:18 | |
| mriedem | which filters for example? | 13:18 |
| mriedem | also, you should probably include alex_xu and/or gmann in this discussion | 13:19 |
| tssurya | --user or --all-tenants etcc | 13:19 |
| tssurya | I mean all those filters which say (admin only) | 13:19 |
| tssurya | shouldn't they all behave in the same way ? | 13:19 |
| mriedem | i see | 13:19 |
| mriedem | msg = _("Only administrators may list deleted instances") | 13:20 |
| mriedem | raise exc.HTTPForbidden(explanation=msg) | 13:20 |
| mriedem | but looks like that's only if you're filtering on vm_state='deleted' | 13:20 |
| tssurya | yea | 13:20 |
| openstackgerrit | Merged openstack/nova master: Remove duplicate parameter in API sample documents https://review.openstack.org/581203 | 13:20 |
| tssurya | doing --status DELETED is caught correctly | 13:20 |
| * alex_xu is looking the chat log | 13:20 | |
| tssurya | thanks alex_xu | 13:21 |
| *** burt1 is now known as burt | 13:21 | |
| mriedem | tssurya: it's also possible today to just pass random query params w/o an error | 13:21 |
| mriedem | GET /servers?foo=bar | 13:21 |
| mriedem | for backward compatibility reasons | 13:21 |
| tssurya | mriedem: ah okay | 13:22 |
| mriedem | if we made the query parameter whitelist a true whitelist and failure for unknown parameters, that would be a microversion | 13:22 |
| tssurya | mriedem: hmm, yea I don't know if it needs to change, I noticed this when I was playing around with policy/filters | 13:23 |
| alex_xu | the API behaviour is ignoring any invalid parameters | 13:23 |
| *** ispp has joined #openstack-nova | 13:23 | |
| mriedem | https://github.com/openstack/nova/blob/b67a9a111ab0cf68084f62017a74f9a41377244f/nova/api/openstack/compute/schemas/servers.py#L599 | 13:23 |
| *** andreas_s has quit IRC | 13:24 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Avoid redundant initialize_connection on source post live migration https://review.openstack.org/551302 | 13:24 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Restore connection_info after live migration rollback https://review.openstack.org/551349 | 13:24 |
| openstackgerrit | Silvan Kaiser proposed openstack/nova master: Exec systemd-run with privileges in Quobyte driver https://review.openstack.org/554195 | 13:26 |
| *** shaohe_feng has quit IRC | 13:26 | |
| mriedem | also, for example, 2.26 adds the *tags* query params but they are only effective if using >= 2.26, if you pass tags=1,2 with 2.1, they are just ignored | 13:27 |
| tssurya | alex_xu, mriedem: thanks for the pointer to the code/confirmation! it was just strange that nova list --deleted and nova list --status DELETED behaved differently. | 13:27 |
| mriedem | because 'additionalProperties': True, | 13:27 |
| *** shaohe_feng has joined #openstack-nova | 13:27 | |
| tssurya | right | 13:28 |
| mriedem | it also looks like if you pass deleted=cookies it will accept that and default deleted=False | 13:28 |
| tssurya | heh yea | 13:29 |
| mriedem | https://github.com/openstack/nova/blob/b67a9a111ab0cf68084f62017a74f9a41377244f/nova/api/openstack/compute/servers.py#L187 | 13:29 |
| mriedem | why we treat --status DELETED and --deleted differently, idk | 13:30 |
| mriedem | looks like that was pre-microversions | 13:30 |
| tssurya | yea , well is this documented somewhere outside the code ? | 13:30 |
| *** rodolof has quit IRC | 13:31 | |
| tssurya | (I couldn't find it) | 13:31 |
| mriedem | tssurya: i'm not aware of something about this being documented off the top of my head - i'd check the compute API guide since that's where i'd expect something like this to exist, if at all | 13:31 |
| alex_xu | tssurya: mriedem in the before, we have a proposal to change the all_tenants policy https://review.openstack.org/#/c/527019/3/specs/ocata/implemented/add-whitelist-for-server-list-filter-sort-parameters.rst@68 | 13:31 |
| alex_xu | but we didn't implement it | 13:31 |
| openstackgerrit | Silvan Kaiser proposed openstack/nova master: Exec systemd-run with privileges in Quobyte driver https://review.openstack.org/554195 | 13:31 |
| *** rodolof has joined #openstack-nova | 13:32 | |
| *** psachin has quit IRC | 13:32 | |
| tssurya | mriedem, alex_xu: ack | 13:32 |
| *** tssurya_ has joined #openstack-nova | 13:34 | |
| *** shaohe_feng has quit IRC | 13:36 | |
| mriedem | https://review.openstack.org/#/c/11469/ added the ability to do nova list --status DELETED | 13:37 |
| mriedem | and fails for non-admins | 13:37 |
| *** dabukalam has left #openstack-nova | 13:37 | |
| mriedem | which is so long ago there would have been no consideration of consistency with failing a non-admin passing deleted=True | 13:38 |
| *** shaohe_feng has joined #openstack-nova | 13:38 | |
| mriedem | it feels like changing that now to fail for non-admins would require a microversion but i could see the argument both ways | 13:39 |
| mriedem | there is something to be said for explicit api behavior, i.e. if i'm a non-admin doing nova list --deleted and not getting back deleted instances, i might not realize i'm using the wrong rc file and think it's a bug | 13:39 |
| mriedem | i'm sure we have crap like this all over the api | 13:40 |
| tssurya_ | Haha | 13:40 |
| mriedem | there are lots of "make this strict in a new microversion" notes in lots of that code | 13:40 |
| mriedem | for example, lots of the schema validation that has additionalProperties: true | 13:40 |
| *** hongbin has joined #openstack-nova | 13:40 | |
| mriedem | and fixing error response codes | 13:40 |
| mriedem | if someone had the energy and care to wrangle a lot of those things into a spec we could fix them in a single microversion | 13:41 |
| mriedem | validation just gets hard when you have 80 *known* query params and some of those have behavior characteristics depending on microversion and/or what other parameters are passed | 13:42 |
| tssurya_ | Hmm okay so for now I just ignore this or should I open a bug / should we resurrect the whitelist spec next cycle ? | 13:42 |
| mriedem | if you care to document it, that would be something | 13:43 |
| mriedem | https://developer.openstack.org/api-guide/compute/server_concepts.html#server-query | 13:43 |
| * alex_xu still remember the nightmare of creating a schema for query parameters | 13:43 | |
| tssurya_ | Ack I will put some doc patch then | 13:43 |
| mriedem | "Other options will be ignored by nova silently." | 13:43 |
| mriedem | that first bullet basically says what you're hitting | 13:44 |
| mriedem | "For general user, there is limited set of attributes of the servers can be used as query option. reservation_id, name, status, image, flavor, ip, changes-since, ip6, tags, tags-any, not-tags, not-tags-any are supported options to be used. Other options will be ignored by nova silently." | 13:44 |
| openstackgerrit | sahid proposed openstack/nova master: hardware: fix hugepages memory usage per intances https://review.openstack.org/580657 | 13:44 |
| openstackgerrit | sahid proposed openstack/nova master: hardware: fix memory check usage for small/large pages https://review.openstack.org/532168 | 13:44 |
| openstackgerrit | sahid proposed openstack/nova master: hardware: remove duplicate memory check https://review.openstack.org/581365 | 13:44 |
| *** itlinux has joined #openstack-nova | 13:44 | |
| *** Luzi has quit IRC | 13:45 | |
| mriedem | alex_xu: do you know why we have all_tenants in _get_server_search_options and then we just check a policy if you specify it and fail with a 403 if you're not an admin? | 13:45 |
| *** ttsiouts has quit IRC | 13:46 | |
| *** shaohe_feng has quit IRC | 13:46 | |
| alex_xu | mriedem: I don't know why, probably just a feature people want to control the visibility of all_tenant by the policy in the before | 13:46 |
| mriedem | that's one way we could handle filtering on deleted - add a policy rule which defaults to rule:admin_api | 13:47 |
| *** shaohe_feng has joined #openstack-nova | 13:47 | |
| *** lpetrut_ has joined #openstack-nova | 13:47 | |
| openstackgerrit | sahid proposed openstack/nova master: hardware: fix hugepages memory usage per intances https://review.openstack.org/580657 | 13:48 |
| openstackgerrit | sahid proposed openstack/nova master: hardware: remove duplicate memory check https://review.openstack.org/581365 | 13:48 |
| openstackgerrit | sahid proposed openstack/nova master: hardware: fix memory check usage for small/large pages https://review.openstack.org/532168 | 13:48 |
| alex_xu | you mean the status=deleted? | 13:48 |
| mriedem | well, that and deleted=True | 13:48 |
| mriedem | we're inconsistent today, | 13:48 |
| mriedem | for a non-admin, if i do 'nova list --deleted' it's ignored | 13:48 |
| mriedem | but if i do 'nova list --status DELETED' i get a 403 | 13:48 |
| mriedem | but it's essentially the same filter | 13:49 |
| alex_xu | yes... | 13:49 |
| mriedem | this is all the api guide says about the deleted filter: "deleted returns (or excludes) deleted servers" | 13:50 |
| *** ratailor has quit IRC | 13:50 | |
| mriedem | so we could expand on that if we wanted to include a note about the difference in behavior between --status DELETED and --deleted | 13:50 |
| *** lpetrut has quit IRC | 13:50 | |
| mriedem | and that it's admin-only either way | 13:50 |
| efried | stephenfin: Then should the non-systemd mount be run under privsep too? | 13:50 |
| mriedem | tssurya: so if you're going to update the api guide, that's what i'd update | 13:51 |
| *** awaugama has joined #openstack-nova | 13:51 | |
| alex_xu | mriedem: nova list --deleted consistent with the query parameter behaviour. nova list --status DELETED consistent with the behavour of valid value of query parameter. | 13:52 |
| tssurya_ | mriedem: okay, | 13:53 |
| mriedem | alex_xu: i'm not sure i get your point | 13:53 |
| alex_xu | mriedem: we also return 400 if you fill invalid date format for --change-sinces, we won't ignore that invalid value | 13:53 |
| stephenfin | efried: Based on silvans comments, the umount is more generic and therefore needs the additional permissions | 13:53 |
| stephenfin | This is where I'd normally have lyarwood weigh in but I think he's not around this week | 13:54 |
| mriedem | alex_xu: i mean this https://github.com/openstack/nova/blob/b67a9a111ab0cf68084f62017a74f9a41377244f/nova/api/openstack/compute/servers.py#L194 | 13:54 |
| *** ttsiouts has joined #openstack-nova | 13:54 | |
| mriedem | for nova list --status DELETED | 13:54 |
| stephenfin | Maybe mdbooth would have an opinion though? ^ | 13:54 |
| stephenfin | mdbooth: RE: efried's second comment here https://review.openstack.org/#/c/554195/14/nova/privsep/libvirt.py Any ideas? | 13:54 |
| alex_xu | mriedem: yes, DELETED is invalid value for status parameter for non-admin | 13:54 |
| tssurya | mriedem: alex_xu :wouldn't the right way to deal with --deleted actually be to add the default rule:is_admin so that it behaves sanely ? | 13:54 |
| tssurya | like mriedem said above | 13:55 |
| mdbooth | stephenfin: Reading... | 13:55 |
| alex_xu | mriedem: it is same with the other parameters. If you put an invalid date format in changes-since parameter you will get a 400 also | 13:55 |
| mriedem | but deleted=cookies is ok | 13:55 |
| mriedem | i found the change that added that too, and it was a compromise on existing behavior | 13:56 |
| *** med_ has quit IRC | 13:56 | |
| alex_xu | mriedem: we didn't ignore deleted=cookikes, I guess, it is just map to a bool | 13:56 |
| mriedem | it defaults to False if it's an invalid bool | 13:56 |
| *** shaohe_feng has quit IRC | 13:57 | |
| mriedem | https://review.openstack.org/#/c/173296/ | 13:57 |
| mriedem | there was a young alex_xu fighting the good fight on that too https://review.openstack.org/#/c/173296/2/nova/api/openstack/compute/plugins/v3/servers.py | 13:58 |
| alex_xu | in my childhood | 13:58 |
| mriedem | ha | 13:58 |
| mriedem | looks like the TODO from that review was never added | 13:59 |
| mriedem | we could start an etherpad to track various gross little api issues like this if we wanted to tackle those in a single microversion in stein | 13:59 |
| *** shaohe_feng has joined #openstack-nova | 14:00 | |
| *** ttsiouts has quit IRC | 14:00 | |
| * alex_xu still remember how many microversion bump to finish the deprecation..... | 14:01 | |
| *** dklyle has quit IRC | 14:01 | |
| *** dklyle has joined #openstack-nova | 14:01 | |
| openstackgerrit | sahid proposed openstack/nova master: hardware: fix hugepages memory usage per intances https://review.openstack.org/580657 | 14:02 |
| openstackgerrit | sahid proposed openstack/nova master: hardware: remove duplicate memory check https://review.openstack.org/581365 | 14:02 |
| openstackgerrit | sahid proposed openstack/nova master: hardware: fix memory check usage for small/large pages https://review.openstack.org/532168 | 14:02 |
| *** sidx64 has quit IRC | 14:02 | |
| *** itlinux has quit IRC | 14:04 | |
| *** sidx64 has joined #openstack-nova | 14:05 | |
| *** yikun has quit IRC | 14:06 | |
| *** shaohe_feng has quit IRC | 14:07 | |
| *** sidx64 has quit IRC | 14:07 | |
| *** shaohe_feng has joined #openstack-nova | 14:08 | |
| *** mlavalle has joined #openstack-nova | 14:09 | |
| *** ttsiouts has joined #openstack-nova | 14:09 | |
| *** felipemonteiro has joined #openstack-nova | 14:09 | |
| *** sidx64 has joined #openstack-nova | 14:10 | |
| *** sidx64 has quit IRC | 14:10 | |
| *** QG has joined #openstack-nova | 14:10 | |
| tssurya | mriedem, dansmith: another question I had was regarding https://review.openstack.org/#/c/557369/5/specs/rocky/approved/handling-down-cell.rst@74 , for updating queued_for_delete, since I can't do upcalls, can I just go ahead and mark this in the compute API before it is casted, even if the deletion fails ? and we document this specifically since its only "queued" for deletion ? | 14:10 |
| tssurya | (although it doesn't seem very right/ its kind of stale) | 14:10 |
| mriedem | tssurya: i commented on that specific issue in one of my earlier reviews | 14:11 |
| mriedem | yes we have to set the flag in the api before casting to compute to do the soft_delete | 14:11 |
| tssurya | which is what I am pointing at :) | 14:11 |
| *** felipemonteiro_ has joined #openstack-nova | 14:11 | |
| mdbooth | stephenfin efried: What are you asking specifically? | 14:11 |
| *** ispp has quit IRC | 14:11 | |
| dansmith | tssurya: mriedem right, and only look at that if the cell is down, otherwise honor what is in the cell db right? | 14:11 |
| stephenfin | mdbooth: Why it's necessary to get root privileges to unmount volumes yet not to mount | 14:12 |
| mdbooth | stephenfin: That doesn't look like a robust way to determine if systemd is functional to me. | 14:12 |
| mdbooth | stephenfin: I assume that's because quobyte is weird? | 14:12 |
| mriedem | dansmith: this is setting queued_for_delete=True when the cell is up | 14:12 |
| mriedem | which you have to do in the api before casting to compute | 14:12 |
| dansmith | mriedem: *setting* for sure, but then you don't *look* at it unless the cell is down and have to decide whether or not to show the shell instance yeah? | 14:12 |
| mdbooth | stephenfin: Not being facetious, btw. A quobyte driver seems like the right place to hide that sort of stuff. | 14:13 |
| mriedem | and there are 3 places that can happen (1) normal delete (Cast to compute), (2) local delete (compute is down), and (3) soft delete | 14:13 |
| tssurya | dansmith: at the time of deletion | 14:13 |
| *** sidx64 has joined #openstack-nova | 14:13 | |
| stephenfin | mdbooth: Neither do I, but I guess that's a separate issue and someone will eventually report it if not | 14:13 |
| dansmith | tssurya: I know, at time of deletion, you have to set it in the api when they first request it | 14:13 |
| mdbooth | stephenfin: I couldn't work out from the bug report what the actual problem was. | 14:13 |
| tssurya | dansmith: right we will not look at this unless a cell is down | 14:13 |
| tssurya | got it | 14:13 |
| dansmith | tssurya: mriedem: right, I'm just trying to explain, that's why we set it presumptively, because even though the delete hasn't happened, we only use this as a backup, so the fact that it might be a little aggressive (set before the delete happens), it's only for the emergency cas | 14:14 |
| dansmith | *case | 14:14 |
| dansmith | and why we _can_ set it that way, because it won't affect normal get/list calls | 14:14 |
| *** mdnadeem has quit IRC | 14:15 | |
| *** felipemonteiro has quit IRC | 14:15 | |
| stephenfin | mdbooth: Yeah, I was working on the same assumption but I was curious if there was something I was missing | 14:15 |
| tssurya | dansmith: absolutely, thanks for confirming | 14:15 |
| tssurya | thanks mriedem | 14:15 |
| *** andreas_s has joined #openstack-nova | 14:15 | |
| mdbooth | stephenfin: Although... it could be that root isn't required. | 14:16 |
| mdbooth | stephenfin: kaisers blames it on the (nova) volume rather than quobyte | 14:16 |
| mdbooth | s/volume/driver/ | 14:16 |
| stephenfin | mdbooth: I think it's systemd itself at fault here https://github.com/systemd/systemd/issues/3388 | 14:17 |
| QG | Hello everyone, I have some question about tags/properties, do you know a way for an operator to let the customer set some specific tags/properties on server but not delete them ? | 14:17 |
| *** shaohe_feng has quit IRC | 14:17 | |
| *** med_ has joined #openstack-nova | 14:17 | |
| *** ispp has joined #openstack-nova | 14:17 | |
| *** tssurya_ has quit IRC | 14:18 | |
| *** shaohe_feng has joined #openstack-nova | 14:19 | |
| mriedem | QG: yes it looks like there are specific policy rules for tags | 14:21 |
| mriedem | https://docs.openstack.org/nova/latest/configuration/policy.html | 14:21 |
| mriedem | see https://docs.openstack.org/nova/latest/configuration/policy.html | 14:21 |
| mriedem | oops | 14:21 |
| mriedem | https://docs.openstack.org/nova/latest/configuration/policy.html | 14:21 |
| mriedem | guh | 14:21 |
| mriedem | os_compute_api:os-server-tags: | 14:22 |
| *** moshele has quit IRC | 14:23 | |
| *** antosh has joined #openstack-nova | 14:23 | |
| *** hamzy has joined #openstack-nova | 14:24 | |
| QG | mriedem: Thanks and is there any way to filter on specific tags / properties that start with a string of caraters? | 14:25 |
| openstackgerrit | Konstantinos Samaras-Tsakiris proposed openstack/nova master: Hide hypervisor id on windows guests https://review.openstack.org/579897 | 14:25 |
| *** Bhujay has quit IRC | 14:26 | |
| stephenfin | mdbooth: I've left comments against the bug. If this is resolved in new version of systemd, we should probably just wait on that rather than unnecessarily seeking root privileges | 14:26 |
| mdbooth | stephenfin: Yeah, that's where I was going to go with that. | 14:26 |
| stephenfin | mdbooth: Cool. Thanks for the input :) | 14:26 |
| mdbooth | It seems we're adding code to Nova to replicate a function of systemd. | 14:26 |
| mriedem | QG: no, tags are free-form defined by the user | 14:27 |
| *** shaohe_feng has quit IRC | 14:27 | |
| *** tidwellr has joined #openstack-nova | 14:28 | |
| *** shaohe_feng has joined #openstack-nova | 14:29 | |
| QG | mriedem: Ok thanks | 14:29 |
| gibi | mriedem: I have bad news about https://bugs.launchpad.net/nova/+bug/1770434 | 14:30 |
| openstack | Launchpad bug 1770434 in OpenStack Compute (nova) "affinity filter not work on master branch" [High,Confirmed] | 14:30 |
| gibi | mriedem: it is really broken | 14:30 |
| gibi | mriedem: I had to change the existing tempest test to reproduce it but it is now failing http://logs.openstack.org/49/581349/1/check/tempest-multinode-full/0ac326a/testr_results.html.gz | 14:31 |
| *** spotz_ is now known as spotz | 14:31 | |
| gibi | mriedem: so far I only found that querying the instances that are members of the group returns an empty list https://github.com/openstack/nova/blob/c0350da4a1607d7aa113caceaefb5d29303c7eed/nova/objects/instance_group.py#L422 | 14:33 |
| *** shaohe_feng has quit IRC | 14:38 | |
| *** shaohe_feng has joined #openstack-nova | 14:38 | |
| openstackgerrit | Merged openstack/osc-placement master: Fix the 1.6 release note format https://review.openstack.org/579042 | 14:38 |
| openstackgerrit | Merged openstack/nova master: make incomplete_consumer_project_id a valid UUID https://review.openstack.org/580358 | 14:39 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Update root providers in same tree https://review.openstack.org/580246 | 14:39 |
| openstackgerrit | Merged openstack/osc-placement master: Remove doc/build during tox -e docs https://review.openstack.org/579041 | 14:40 |
| openstackgerrit | Merged openstack/osc-placement master: Fix docstring for delete allocation method https://review.openstack.org/577075 | 14:40 |
| mriedem | gibi: probably want to ask melwitt if that's related to the bug she's already working on | 14:41 |
| gibi | mriedem: to gather the hosts of the members of an instance group we would need to read instances from every cell where are member instances | 14:41 |
| mriedem | https://review.openstack.org/#/c/540258/ | 14:41 |
| gibi | mriedem: thanks, seems related | 14:41 |
| *** EmilienM is now known as EvilienM | 14:42 | |
| *** quiquell is now known as quiquell|off | 14:43 | |
| *** beagles has joined #openstack-nova | 14:44 | |
| *** quiquell|off is now known as quiquell | 14:45 | |
| *** peereb has quit IRC | 14:45 | |
| *** ispp has quit IRC | 14:45 | |
| *** quiquell is now known as quiquell|off | 14:46 | |
| mnaser | thanks to whoeve decided to strip out all the extra crazy quotas out of the api | 14:46 |
| mnaser | things are so much cleaner now. | 14:46 |
| *** quiquell|off is now known as quiquell | 14:47 | |
| *** shaohe_feng has quit IRC | 14:48 | |
| *** quiquell is now known as quiquell|off | 14:48 | |
| *** shaohe_feng has joined #openstack-nova | 14:49 | |
| mriedem | mnaser: docs or microversion? | 14:49 |
| mriedem | https://developer.openstack.org/api-ref/compute/#show-a-quota | 14:49 |
| mnaser | microversion i tihnk, nova quota-show shows a lot less things now | 14:50 |
| mriedem | the networking and file injection ones are still there unless you're using nova CLI which defaults to latest available microversion in the server so you won't see those | 14:50 |
| mriedem | yup | 14:50 |
| mnaser | nice on the eyes. | 14:50 |
| mriedem | that's what they said about me in the Mr Minnesota Pageant | 14:51 |
| *** tssurya_ has joined #openstack-nova | 14:51 | |
| mnaser | i wouldnt disagree | 14:52 |
| mnaser | ha | 14:52 |
| mriedem | <# | 14:52 |
| mriedem | <3 | 14:52 |
| *** tssurya_ has quit IRC | 14:53 | |
| kashyap | mriedem: I only get hits for "Mr & Ms Natural Minnesota" peasants. /me wonders about the 'natural' word there... | 14:54 |
| kashyap | s/peasant/pageant/ | 14:54 |
| *** ispp has joined #openstack-nova | 14:54 | |
| *** abhishekk has joined #openstack-nova | 14:56 | |
| *** ragiman has quit IRC | 14:56 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262 | 14:56 |
| mriedem | in case it's not clear, mr minnesota is not a real thing, nor was i a contestant | 14:58 |
| *** shaohe_feng has quit IRC | 14:58 | |
| mriedem | but a guy can dream... | 14:58 |
| *** shaohe_feng has joined #openstack-nova | 15:00 | |
| * dansmith stops his google image search | 15:00 | |
| gibi | melwitt: Can I help somehow with https://review.openstack.org/#/c/540258 ? | 15:00 |
| *** udesale has joined #openstack-nova | 15:01 | |
| *** lpetrut_ has quit IRC | 15:05 | |
| *** ccamacho has quit IRC | 15:05 | |
| *** ccamacho has joined #openstack-nova | 15:06 | |
| *** shaohe_feng has quit IRC | 15:08 | |
| *** shaohe_feng has joined #openstack-nova | 15:09 | |
| *** armaan has quit IRC | 15:10 | |
| *** QG has quit IRC | 15:10 | |
| *** armaan has joined #openstack-nova | 15:10 | |
| *** armaan has quit IRC | 15:11 | |
| *** armaan has joined #openstack-nova | 15:11 | |
| *** armaan has joined #openstack-nova | 15:12 | |
| *** armaan has quit IRC | 15:16 | |
| kashyap | mriedem: Hehe, I know it's not a _real_ thing! Was just teasing :P | 15:17 |
| *** shaohe_feng has quit IRC | 15:19 | |
| *** shaohe_feng has joined #openstack-nova | 15:19 | |
| *** ttsiouts has quit IRC | 15:20 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova stable/queens: Refactor _build_device_metadata https://review.openstack.org/581398 | 15:21 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova stable/queens: Consider hostdev devices when building metadata https://review.openstack.org/581399 | 15:21 |
| *** rodolof has quit IRC | 15:22 | |
| mriedem | gibi: until we're using placement for affinity scheduling, i don't think we can ever do https://review.openstack.org/#/c/581349/ in tempest | 15:23 |
| mriedem | it will always be racy - which is why we have the late affinity check in the compute (which is disabled in default devstack b/c we can't upcall to the api db) | 15:23 |
| gibi | mriedem: that test does not intended to show a race condition | 15:24 |
| gibi | mriedem: I can add sleep between the server create requests and it will still fail | 15:24 |
| mriedem | sure, but when the bug is fixed and we're properly pulling group members, it would start to race | 15:25 |
| mriedem | i'd been meaning to write a functional test for https://review.openstack.org/#/c/540258 but need to look at my notes - it's been awhile | 15:26 |
| *** ccamacho has quit IRC | 15:26 | |
| *** links has quit IRC | 15:26 | |
| mriedem | oh i guess i was going to write a new bug for something that came up during review: | 15:26 |
| mriedem | "We need a new bug and test for the multi-cell affinity scenario where two instances are scheduled at the same time in the same affinity group. We need 2 cells with 1 host each, with exactly enough capacity to fit just one instance so that placement will fail the first request and throw it into the other host in the other cell. The late affinity check in the compute won't fail because it can't see the other member in the | 15:26 |
| mriedem | her cell, so it will think it's fine." | 15:26 |
| mriedem | the tricky part there is our functional tests are able to make up-calls from nova-compute | 15:27 |
| mriedem | we don't have a split mq in our tests | 15:27 |
| mriedem | not sure how easy that would be to do | 15:27 |
| mriedem | dansmith: ^ ? | 15:27 |
| *** ttsiouts has joined #openstack-nova | 15:27 | |
| mriedem | well, maybe won't need split mq - just the instances being in different hosts in different cell dbs might do it | 15:28 |
| dansmith | ....yeah | 15:28 |
| dansmith | with the workaround flag you can disable the check right? | 15:28 |
| mriedem | yes | 15:29 |
| *** yamamoto has quit IRC | 15:29 | |
| *** shaohe_feng has quit IRC | 15:29 | |
| dansmith | although I guess that doesn't really do much, | 15:29 |
| gibi | mriedem: do I understand correclty that on master server groups only work if the late check using upcall is enabled? | 15:29 |
| dansmith | obviously if you disable that check it's not going to check | 15:30 |
| mriedem | maybe that type of request wouldn't get past scheduling | 15:30 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Remove irrelevant comment https://review.openstack.org/578821 | 15:30 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Move static _get_power_off_values to compute_utils https://review.openstack.org/578822 | 15:30 |
| *** shaohe_feng has joined #openstack-nova | 15:30 | |
| mriedem | gibi: i don't think so... | 15:30 |
| mriedem | tempest has an anti-affinity test | 15:30 |
| *** Bhujay has joined #openstack-nova | 15:30 | |
| dansmith | mriedem: so, scheduler will look at group.members, get the instance.host for each, and affine to those hosts, right? | 15:30 |
| gibi | mriedem: that is the test I changed to show that master is broken | 15:30 |
| *** yamamoto has joined #openstack-nova | 15:31 | |
| mriedem | gibi: test_create_server_with_scheduler_hint_group_anti_affinity | 15:31 |
| dansmith | which is lossy because those instances might be pre-scheduling | 15:31 |
| dansmith | or rather, pre-build | 15:31 |
| openstackgerrit | Chen proposed openstack/nova master: WIP https://review.openstack.org/581403 | 15:31 |
| *** tidwellr has quit IRC | 15:31 | |
| gibi | mriedem: that tempest test only works because it sends two server create in the same API request | 15:32 |
| mriedem | right, because servers in separate requests is a known race | 15:32 |
| *** ttsiouts has quit IRC | 15:32 | |
| gibi | mriedem: if you wait 10 minutes between the two requests it still doesnt work | 15:32 |
| gibi | mriedem: I tried :) | 15:32 |
| dansmith | gibi: really? why is that? | 15:32 |
| dansmith | the filter is using a potentially stale version of server group, from the beginning of the request, I just noticed | 15:33 |
| mriedem | yeah the HostState.instances dict should be populated per request | 15:33 |
| dansmith | that shouldn't be a problem 10 minutes later though | 15:33 |
| gibi | dansmith: this returns an empty list for the second scheduling https://github.com/openstack/nova/blob/c0350da4a1607d7aa113caceaefb5d29303c7eed/nova/objects/instance_group.py#L422 | 15:33 |
| mdbooth | Just working on this patch: https://review.openstack.org/#/c/578846/ I called it out in the commit message: the cut/paste in there is horrible, but avoids a refactor. Am I going to get that landed as is, or do I need to look at refactoring the driver interface? | 15:33 |
| *** tidwellr has joined #openstack-nova | 15:33 | |
| mriedem | gibi: and i think that's the bug melwitt is fixing | 15:34 |
| dansmith | gibi: oh on multi-cell? | 15:34 |
| dansmith | that needs to stripe | 15:34 |
| dansmith | yeah | 15:34 |
| *** yamamoto has quit IRC | 15:34 | |
| gibi | don't we deploy with multi cell _by default_ ? | 15:34 |
| mdbooth | It goes without saying that I don't mind refactoring :) However, I'd also like to both land and backport the code. | 15:34 |
| mriedem | gibi: in devstack yes | 15:34 |
| dansmith | gibi: yeah, this would hit cell0 if your default is cell0, and always be empty | 15:34 |
| mriedem | it's not really 'multi cell' so much as superconductor mode in devstack and how the services are configured | 15:35 |
| gibi | let me rephrase. I our suggested deployment mode (cell_v2) the server group policies are broken | 15:35 |
| gibi | that is my understanding | 15:35 |
| dansmith | gibi: because your default connection is to cell0, which will never return the list of instances, yeah | 15:35 |
| *** felipemonteiro_ has quit IRC | 15:35 | |
| *** lpetrut_ has joined #openstack-nova | 15:36 | |
| gibi | dansmith: thanks, that explains what I see | 15:36 |
| *** mago_ has quit IRC | 15:36 | |
| dansmith | but striping across cells is what needs to happen, which is that bug afaik | 15:36 |
| *** priteau has quit IRC | 15:36 | |
| gibi | dansmith: yeah. this is why offered my help to melwitt above on the fix | 15:36 |
| dansmith | gibi: are we in violent agreement? :) | 15:36 |
| gibi | dansmith: yes | 15:37 |
| * dansmith stabs gibi with his agreement knife | 15:37 | |
| gibi | I was not sure we are on the same page about the size of the problem. server groups are useless now | 15:37 |
| *** rodolof has joined #openstack-nova | 15:37 | |
| * gibi silently bleeds | 15:38 | |
| dansmith | gibi: if your controllers are pointing at your main cell by default it'll be fine, fwiw | 15:38 |
| dansmith | but it definitely needs changing | 15:38 |
| mriedem | gibi: so, if you want to help, we need a functional test in-tree that recreates the regression | 15:38 |
| mriedem | that's what i was -1 on the change for - the mock based unit tests had logic flaws in them | 15:39 |
| *** shaohe_feng has quit IRC | 15:39 | |
| gibi | dansmith: how can a deployer change the default cell to cell1? | 15:39 |
| gibi | mriedem: ack. I offered a tempest test :) | 15:40 |
| dansmith | gibi: [database]/connection :) | 15:40 |
| gibi | dansmith: in the super conductor conductor conf? | 15:41 |
| *** shaohe_feng has joined #openstack-nova | 15:41 | |
| dansmith | gibi: in any controller config | 15:41 |
| dansmith | gibi: you don't have to be running a superconductor layout with only one non-cell0 cell | 15:41 |
| *** chyka has joined #openstack-nova | 15:41 | |
| *** chyka has quit IRC | 15:41 | |
| mriedem | gibi: yeah, but we can't use that tempest change long-term because of the otherwise known race issue | 15:41 |
| *** chyka has joined #openstack-nova | 15:42 | |
| gibi | dansmith: I see | 15:42 |
| gibi | dansmith: thanks | 15:42 |
| *** rodolof has quit IRC | 15:42 | |
| gibi | mriedem: is it racy even if the test waits for the first server to go to ACTIVE state before start creating the second one? | 15:43 |
| *** rodolof has joined #openstack-nova | 15:43 | |
| mriedem | gibi: in that case maybe not | 15:43 |
| mriedem | because per scheduling request, we should pull the set of instances per host | 15:43 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L781 | 15:44 |
| mriedem | that's if the compute isn't sending it's instance info to the scheduler (which it's not in default devstack b/c we disable that ability) | 15:44 |
| gibi | OK, so the second scheduling will see the first instance sitting on the host | 15:45 |
| mriedem | which reminds me of https://review.openstack.org/#/c/569247/ but haven't had good large scale performance testing to see if that's justified | 15:45 |
| mriedem | gibi: it should yeah | 15:45 |
| *** armaan has joined #openstack-nova | 15:46 | |
| gibi | mriedem: then I don't see how the currently proposed tempest test be racy | 15:46 |
| *** chyka_ has joined #openstack-nova | 15:46 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: update project/user for consumer in allocation https://review.openstack.org/581139 | 15:47 |
| *** chyka has quit IRC | 15:48 | |
| mriedem | gibi: ok updated comments | 15:49 |
| *** yamahata has joined #openstack-nova | 15:49 | |
| *** shaohe_feng has quit IRC | 15:49 | |
| gibi | mriedem: ack, I can cover both single and multi request cases in tempest | 15:50 |
| *** shaohe_feng has joined #openstack-nova | 15:50 | |
| *** jmlowe_ has quit IRC | 15:50 | |
| gibi | mriedem: if we have the tempest do you still require the functional test in melwitt's patch? | 15:50 |
| *** andreas_s has quit IRC | 15:51 | |
| mriedem | maybe not | 15:51 |
| mriedem | does your tempest test also cover affinity? | 15:52 |
| *** andreas_s has joined #openstack-nova | 15:52 | |
| mriedem | looks like it doesn't for separate requests | 15:52 |
| gibi | mriedem: both the affinity and the anti-affinity case fails now | 15:52 |
| *** rmart04 has quit IRC | 15:52 | |
| gibi | mriedem: both uses the same helper to create the servers | 15:53 |
| *** ttsiouts has joined #openstack-nova | 15:53 | |
| gibi | mriedem: but in case of affinity we might want to fill the compute to see NoValid host | 15:53 |
| mriedem | that's what i was going to try with a functional test | 15:54 |
| mriedem | to set available vcpu inventory to 1 or something | 15:54 |
| gibi | mriedem: sure we have plenty of such functional tests already but they are not cell aware and passing | 15:54 |
| gibi | mriedem: https://github.com/openstack/nova/blob/master/nova/tests/functional/test_server_group.py | 15:55 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Document differences and similaries between extra specs and hints https://review.openstack.org/581410 | 15:55 |
| mriedem | right, i plan on writing a multi-cell affinity regression functional test | 15:55 |
| *** gyee has joined #openstack-nova | 15:55 | |
| gibi | mriedem: https://github.com/openstack/nova/blob/master/nova/tests/functional/test_server_group.py#L292 | 15:56 |
| *** andreas_s has quit IRC | 15:56 | |
| gibi | mriedem: ohh there is one case where functional is needed. multiple non-cell0 cells case | 15:57 |
| gibi | mriedem: as in tempest we have only cell0 and cell1 | 15:57 |
| mriedem | yes, that's what i've been saying :) | 15:58 |
| *** antosh has quit IRC | 15:58 | |
| mriedem | when i say 'multi-cell' i mean multiple non-cell0 cells | 15:58 |
| gibi | mriedem: now I understand ;) | 15:58 |
| mriedem | i don't consider cell0 a 'real' cell since it doesn't contain compute hosts | 15:58 |
| *** shaohe_feng has quit IRC | 16:00 | |
| *** Guest88425 has quit IRC | 16:00 | |
| gibi | mriedem: OK, I will extend the tempest test tomorrow. Thanks for the explanation | 16:00 |
| *** shaohe_feng has joined #openstack-nova | 16:01 | |
| *** antosh has joined #openstack-nova | 16:01 | |
| *** wwriverr_ has joined #openstack-nova | 16:02 | |
| *** ircuser-1 has joined #openstack-nova | 16:02 | |
| *** wwriverr_ has quit IRC | 16:02 | |
| *** wwriverr_ has joined #openstack-nova | 16:03 | |
| *** wwriverrat has quit IRC | 16:05 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: update project/user for consumer in allocation https://review.openstack.org/581139 | 16:05 |
| *** sidx64 has quit IRC | 16:06 | |
| openstackgerrit | karim proposed openstack/nova master: Handle rebuild of instances with image traits https://review.openstack.org/569498 | 16:06 |
| *** jmlowe has joined #openstack-nova | 16:08 | |
| *** jmlowe has quit IRC | 16:09 | |
| *** shaohe_feng has quit IRC | 16:10 | |
| *** janki has quit IRC | 16:11 | |
| *** shaohe_feng has joined #openstack-nova | 16:11 | |
| *** ispp has quit IRC | 16:13 | |
| mriedem | dansmith: i found another candidate for your long_rpc_timeout https://bugs.launchpad.net/cinder/+bug/1739482 | 16:13 |
| openstack | Launchpad bug 1739482 in Cinder "test_snapshot_backup fails to build backup due to MessagingTimeout" [Medium,Confirmed] | 16:13 |
| dansmith | mriedem: that's on the cinder side though yeah? | 16:14 |
| mriedem | yup | 16:14 |
| mriedem | but i'd do the exact same thing there | 16:14 |
| mriedem | ala oslo.incubator style | 16:14 |
| dansmith | aye | 16:14 |
| *** udesale has quit IRC | 16:15 | |
| *** ttsiouts has quit IRC | 16:16 | |
| mriedem | dansmith: so in https://review.openstack.org/#/c/563375/35/nova/objects/instance_group.py it seems weird that _rules is nullable but we default to {} if it's not set in the db | 16:19 |
| *** lpetrut_ has quit IRC | 16:19 | |
| mriedem | so i can create a group with rules=None but then what i'll get back is group.rules == {} | 16:19 |
| dansmith | mriedem: so, the reason I left it that way is because he had the first patch passing None from the api | 16:19 |
| dansmith | but now that I think about it with a fresh head, | 16:20 |
| dansmith | that can and maybe should just pass {} there | 16:20 |
| *** shaohe_feng has quit IRC | 16:20 | |
| mriedem | why {} over None? | 16:20 |
| mriedem | just so callers don't hit NoneType on access? | 16:21 |
| dansmith | I tend to prefer things like dicts to be empty instead of None, just because it means you always have to check to see if the thing is none, then check to see if your thing is in the dict, and then check to see if the value is what you want | 16:21 |
| dansmith | that's why I was asking for it to be {} on return, but we should be consistent either way | 16:21 |
| mriedem | so if we just pass in {} we can drop nullable=true | 16:22 |
| *** shaohe_feng has joined #openstack-nova | 16:22 | |
| dansmith | yeah i think that was the only place | 16:22 |
| mriedem | there is one in the request spec as well | 16:22 |
| mriedem | https://review.openstack.org/#/c/563375/35/nova/objects/request_spec.py | 16:22 |
| dansmith | I remember de-null-ing it but then flipping it back when the api test failed | 16:22 |
| dansmith | okay | 16:22 |
| dansmith | I'll pull it down and make that change and see what breaks | 16:22 |
| *** sahid has quit IRC | 16:23 | |
| mriedem | this is the only thing (later in the series) i know of that will | 16:23 |
| mriedem | https://review.openstack.org/#/c/563401/25/doc/notification_samples/common_payloads/ServerGroupPolicyPayload.json@7 | 16:23 |
| mriedem | but that's an easy change | 16:24 |
| * dansmith kicks off a test run | 16:24 | |
| *** antosh has quit IRC | 16:29 | |
| *** shaohe_feng has quit IRC | 16:30 | |
| *** antosh has joined #openstack-nova | 16:32 | |
| *** shaohe_feng has joined #openstack-nova | 16:32 | |
| *** yamamoto has joined #openstack-nova | 16:34 | |
| *** Bhujay has quit IRC | 16:38 | |
| *** yamamoto has quit IRC | 16:40 | |
| *** shaohe_feng has quit IRC | 16:41 | |
| *** shaohe_feng has joined #openstack-nova | 16:41 | |
| *** tssurya has quit IRC | 16:41 | |
| *** armaan has quit IRC | 16:42 | |
| *** armaan has joined #openstack-nova | 16:43 | |
| *** shaohe_feng has quit IRC | 16:51 | |
| *** shaohe_feng has joined #openstack-nova | 16:51 | |
| *** sambetts is now known as sambetts|afk | 16:53 | |
| *** abhishekk is now known as abhishekk|afk | 16:54 | |
| *** derekh has quit IRC | 16:57 | |
| *** yamahata has quit IRC | 17:00 | |
| *** shaohe_feng has quit IRC | 17:01 | |
| *** shaohe_feng has joined #openstack-nova | 17:03 | |
| *** imacdonn has quit IRC | 17:03 | |
| *** amoralej is now known as amoralej|off | 17:03 | |
| *** imacdonn has joined #openstack-nova | 17:03 | |
| *** mgoddard has quit IRC | 17:06 | |
| *** tesseract has quit IRC | 17:07 | |
| *** jmlowe has joined #openstack-nova | 17:09 | |
| *** mvk_ has quit IRC | 17:11 | |
| *** shaohe_feng has quit IRC | 17:11 | |
| dansmith | mriedem: hmm, I didn't get a failure on that | 17:14 |
| dansmith | er, wait, | 17:16 |
| *** shaohe_feng has joined #openstack-nova | 17:16 | |
| dansmith | maybe that would manifest in the notification patch but not in the last one | 17:16 |
| dansmith | oh, that's what you linked to | 17:16 |
| *** abhishekk|afk is now known as abhishekk | 17:18 | |
| dansmith | hrm | 17:20 |
| dansmith | no fail | 17:20 |
| dansmith | maybe I'll push this up and you can look/comment | 17:20 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add policy to InstanceGroup object https://review.openstack.org/563375 | 17:20 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | 17:20 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Change the ServerGroupAntiAffinityFilter to adapt to new policy https://review.openstack.org/571166 | 17:20 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465 | 17:20 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 17:20 |
| *** shaohe_feng has quit IRC | 17:22 | |
| *** shaohe_feng has joined #openstack-nova | 17:22 | |
| mriedem | dansmith: did you run just unit tests? | 17:26 |
| mriedem | the notification sample will fail functional | 17:26 |
| dansmith | I ran functional, but maybe not on the actual notification patch, looking at my history | 17:27 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Heal allocations with incomplete consumer information https://review.openstack.org/574488 | 17:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Refactor _heal_instances_in_cell https://review.openstack.org/577896 | 17:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Use consumer generation in _heal_allocations_for_instance https://review.openstack.org/577905 | 17:28 |
| dansmith | mriedem: yeah, I did and just re-ran with "notification" regex and all passed | 17:29 |
| dansmith | and it's running notification sample tests... | 17:29 |
| dansmith | nova.tests.functional.notification_sample_tests.test_server_group.TestServerGroupNotificationSample.test_server_group_add_member | 17:30 |
| dansmith | (as an example) | 17:30 |
| *** quiquell|off has quit IRC | 17:31 | |
| *** shaohe_feng has quit IRC | 17:32 | |
| mriedem | hmm | 17:32 |
| mriedem | oh i see why | 17:33 |
| mriedem | https://review.openstack.org/#/c/563375/35..36/nova/objects/instance_group.py@142 | 17:33 |
| *** shaohe_feng has joined #openstack-nova | 17:33 | |
| mriedem | that should be removed or changed to {} | 17:33 |
| dansmith | oh | 17:33 |
| dansmith | sho nuf | 17:33 |
| mriedem | and then we can make the rules field on the payload object no longer nullable as well https://review.openstack.org/#/c/563401/26/nova/notifications/objects/server_group.py@68 | 17:34 |
| *** yamahata has joined #openstack-nova | 17:34 | |
| dansmith | lemme write a test for that behavior | 17:35 |
| mriedem | yeah that group = objects.InstanceGroup(rules={}) && self.assertEqual({}, group.rules) | 17:36 |
| *** sridharg has quit IRC | 17:36 | |
| *** felipemonteiro has joined #openstack-nova | 17:36 | |
| *** yamamoto has joined #openstack-nova | 17:37 | |
| *** yamamoto has quit IRC | 17:41 | |
| *** shaohe_feng has quit IRC | 17:42 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add policy to InstanceGroup object https://review.openstack.org/563375 | 17:42 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | 17:42 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Change the ServerGroupAntiAffinityFilter to adapt to new policy https://review.openstack.org/571166 | 17:42 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465 | 17:42 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 17:42 |
| dansmith | okay here we go | 17:42 |
| mriedem | pep8 brotha | 17:44 |
| *** shaohe_feng has joined #openstack-nova | 17:44 | |
| dansmith | come on | 17:45 |
| mriedem | want me to tag in? | 17:45 |
| dansmith | oh that's not my fault.. no I can just fix and push easy | 17:45 |
| mriedem | https://review.openstack.org/#/c/563401/27/nova/notifications/objects/server_group.py@68 | 17:46 |
| mriedem | also ^ | 17:46 |
| dansmith | do I need to re-run tests after snipping that out? | 17:48 |
| dansmith | the nullable thing | 17:48 |
| dansmith | ah maybe hash will change? | 17:48 |
| melwitt | gibi, mriedem: my bug fix got stalled on the functional test. I wasn't able to recreate the bug in a functional test so far | 17:50 |
| *** shaohe_feng has quit IRC | 17:52 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add policy to InstanceGroup object https://review.openstack.org/563375 | 17:53 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | 17:53 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Change the ServerGroupAntiAffinityFilter to adapt to new policy https://review.openstack.org/571166 | 17:53 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465 | 17:53 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 17:53 |
| *** shaohe_feng has joined #openstack-nova | 17:53 | |
| *** mriedem has quit IRC | 17:53 | |
| *** moshele has joined #openstack-nova | 17:55 | |
| *** mriedem1 has joined #openstack-nova | 17:57 | |
| *** mvk_ has joined #openstack-nova | 17:57 | |
| mriedem1 | i assume bauzas is in his futbol chamber | 18:00 |
| *** mriedem1 is now known as mriedem | 18:00 | |
| *** shaohe_feng has quit IRC | 18:03 | |
| *** armaan has quit IRC | 18:03 | |
| *** armaan has joined #openstack-nova | 18:03 | |
| *** armaan has quit IRC | 18:03 | |
| *** armaan has joined #openstack-nova | 18:04 | |
| *** shaohe_feng has joined #openstack-nova | 18:04 | |
| *** antosh has quit IRC | 18:08 | |
| *** antosh has joined #openstack-nova | 18:09 | |
| mriedem | dansmith: ok i'm +2 up that stack to the point of the rest api change, reviewing that during this game | 18:10 |
| *** mgoddard has joined #openstack-nova | 18:10 | |
| dansmith | mriedem: okay we might want to find someone else to do that policy one since it's like half mine now | 18:11 |
| dansmith | but I'll hit the rest | 18:11 |
| *** shaohe_feng has quit IRC | 18:13 | |
| dansmith | mriedem: hmm, so I wonder if that notification one should have been squashed into the main servergrouppayload like the objects were? | 18:13 |
| dansmith | I was just mechanically updating it but hadn't really thought about it | 18:14 |
| mriedem | i thought about that yesterday | 18:14 |
| mriedem | and thought the separate payload isn't bad since it's the singular policy and the rules, | 18:14 |
| mriedem | which in the rest api you just get a singular policy and (eventually) rules | 18:14 |
| mriedem | so if we squashed, | 18:15 |
| mriedem | the notification payload would have policies (deprecated list), policy and rules | 18:15 |
| mriedem | so the nested object for the payload seems ok to me | 18:15 |
| dansmith | so this mirrors more of what the api does? | 18:15 |
| mriedem | doesn't matter to me much either way | 18:15 |
| *** shaohe_feng has joined #openstack-nova | 18:15 | |
| mriedem | the api will be flat | 18:15 |
| mriedem | well, sorry, it's not flat | 18:15 |
| mriedem | https://review.openstack.org/#/c/567534/28/doc/api_samples/os-server-groups/v2.64/server-groups-get-resp.json | 18:15 |
| mriedem | yes it mirrors the rest api | 18:16 |
| dansmith | hmm | 18:16 |
| mriedem | we don't have to model it that way in the notification or api of course | 18:17 |
| mriedem | could all be flat | 18:17 |
| mriedem | gibi wanted both the old policies field and new policy payload in the notification for compat since notification consumers can't request a specific versoin of the notification payload | 18:18 |
| mriedem | but that's not the same in the rest api | 18:18 |
| dansmith | yeah, I dunno | 18:18 |
| dansmith | just not sure I see the point of the nesting in either the api or the notification object | 18:18 |
| dansmith | it's not bad, it just seems unnecessary | 18:18 |
| dansmith | just another object and hash to track | 18:18 |
| dansmith | anyway, if you want to just steam on I'll play along | 18:19 |
| *** shaohe_feng has quit IRC | 18:23 | |
| *** shaohe_feng has joined #openstack-nova | 18:24 | |
| mriedem | i'm ok with making them flat if we want | 18:26 |
| mriedem | thinking about stuff we nest in the rest api for servers, those are things like security groups, volumes, ports, etc - things that have their own resources in the api | 18:26 |
| mriedem | server group policies wouldn't count like that since they aren't separate resources | 18:26 |
| dansmith | yeah | 18:26 |
| mriedem | gibi is probably the only other person that would have an opinion and he's probably gone by now | 18:27 |
| mriedem | should we just wait and ask yikun what he thinks? if he doesn't care, then we can flatify tomorrow | 18:28 |
| dansmith | if you're cool with that | 18:28 |
| mriedem | yeah i'm fine with it | 18:28 |
| mriedem | need to review Kevin_Zheng's abort queued live migration stuff today anyway | 18:28 |
| mriedem | i'll drop my +2 on yikun's notification patch | 18:29 |
| dansmith | aight | 18:30 |
| dansmith | I'll comment | 18:30 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Tighten up ReportClient use of generation https://review.openstack.org/556669 | 18:31 |
| mriedem | me too | 18:33 |
| mriedem | https://review.openstack.org/#/c/563401/28/nova/notifications/objects/server_group.py@41 | 18:33 |
| mriedem | gibi: fyi ^ | 18:33 |
| *** shaohe_feng has quit IRC | 18:33 | |
| *** shaohe_feng has joined #openstack-nova | 18:34 | |
| *** tssurya has joined #openstack-nova | 18:36 | |
| *** gyee has quit IRC | 18:38 | |
| *** yamamoto has joined #openstack-nova | 18:39 | |
| *** eharney has quit IRC | 18:40 | |
| *** abhishekk has quit IRC | 18:41 | |
| *** shaohe_feng has quit IRC | 18:44 | |
| *** yamamoto has quit IRC | 18:44 | |
| *** shaohe_feng has joined #openstack-nova | 18:44 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Use ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa in tree https://review.openstack.org/581444 | 18:46 |
| *** itlinux has joined #openstack-nova | 18:47 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Use ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa in tree https://review.openstack.org/581445 | 18:48 |
| melwitt | looking for a +W on this ironic driver change needed to solve a race during instance creates https://review.openstack.org/563722 | 18:53 |
| *** eharney has joined #openstack-nova | 18:53 | |
| *** shaohe_feng has quit IRC | 18:54 | |
| efried | Looks like jaypipes, dansmith, and johnthetubaguy have reviewed ^ in the past, so I'll stay away for now. | 18:55 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: unquiesce instance after quiesce failure https://review.openstack.org/581451 | 18:56 |
| *** mgoddard has quit IRC | 18:56 | |
| *** shaohe_feng has joined #openstack-nova | 18:57 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Delete orphan nodes before updating resources https://review.openstack.org/579922 | 19:04 |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Avoid BadRequest error log on volume attachment https://review.openstack.org/581453 | 19:04 |
| *** shaohe_feng has quit IRC | 19:04 | |
| *** felipemonteiro_ has joined #openstack-nova | 19:04 | |
| *** itlinux has quit IRC | 19:05 | |
| *** shaohe_feng has joined #openstack-nova | 19:05 | |
| *** felipemonteiro has quit IRC | 19:08 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Address nits from consumer generation https://review.openstack.org/577227 | 19:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: unquiesce instance after quiesce failure https://review.openstack.org/581454 | 19:09 |
| mriedem | 7 days left to submit talks for berlin.... | 19:11 |
| melwitt | I just swapped the runways (a day late, apologies) https://etherpad.openstack.org/p/nova-runways-rocky if anyone would like to add log notes for the removed ones and if dansmith could please update the channel topic | 19:14 |
| *** shaohe_feng has quit IRC | 19:14 | |
| *** lpetrut_ has joined #openstack-nova | 19:16 | |
| *** ChanServ sets mode: +o dansmith | 19:17 | |
| *** shaohe_feng has joined #openstack-nova | 19:17 | |
| dansmith | the first one doesn't have the blueprint slug in it | 19:18 |
| * dansmith goes to look it up | 19:18 | |
| melwitt | argh, sorry | 19:18 |
| *** dansmith changes topic to "Current runways: abort-live-migration-in-queued-status / add-zvm-driver-rocky / glance-image-traits -- This channel is for Nova development. For support of Nova deployments, please use #openstack." | 19:19 | |
| *** ChanServ sets mode: -o dansmith | 19:19 | |
| melwitt | thanks | 19:19 |
| *** lpetrut_ has quit IRC | 19:20 | |
| melwitt | vdrok, jroll, TheJulia: is this patch needed for https://blueprints.launchpad.net/openstack/?searchtext=allow-reserved-equal-total-inventory ? it's in merge conflict https://review.openstack.org/565841 | 19:21 |
| *** med_ has quit IRC | 19:22 | |
| melwitt | link correction https://blueprints.launchpad.net/nova/+spec/allow-reserved-equal-total-inventory | 19:22 |
| *** pchavva has quit IRC | 19:23 | |
| *** rmart04 has joined #openstack-nova | 19:25 | |
| *** shaohe_feng has quit IRC | 19:25 | |
| *** shaohe_feng has joined #openstack-nova | 19:25 | |
| TheJulia | melwitt: I think jroll is the only person who can know for sure, it looks like it just ought to be abandoned based upon the discussion. I know jroll has been super busy as of recent. | 19:26 |
| *** jmlowe has quit IRC | 19:27 | |
| melwitt | TheJulia: ack, thanks | 19:27 |
| jroll | melwitt: I'll look post-meeting, been meaning to get back to that | 19:28 |
| melwitt | jroll: thx | 19:28 |
| jroll | I'd say it's needed but not for that BP | 19:28 |
| melwitt | jroll: thanks for confirming. I'll update https://etherpad.openstack.org/p/nova-rocky-blueprint-status to call out just the one patch as needing review | 19:31 |
| jroll | ++ | 19:31 |
| melwitt | (this one https://review.openstack.org/517921) | 19:31 |
| *** yamamoto has joined #openstack-nova | 19:32 | |
| jroll | right | 19:34 |
| melwitt | ty | 19:34 |
| jroll | thanks for checking on that :) | 19:34 |
| *** shaohe_feng has quit IRC | 19:35 | |
| *** flwang1 has quit IRC | 19:36 | |
| *** shaohe_feng has joined #openstack-nova | 19:36 | |
| *** pchavva has joined #openstack-nova | 19:37 | |
| *** yamamoto has quit IRC | 19:37 | |
| *** rmart04 has quit IRC | 19:38 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Nova objects for Libvirt NUMA config https://review.openstack.org/581456 | 19:40 |
| *** bkopilov has quit IRC | 19:45 | |
| *** shaohe_feng has quit IRC | 19:45 | |
| melwitt | does anyone know what's the deal with vgpu work this cycle? is it blocked on reshaper work or is some of it okay to merge at the moment? https://review.openstack.org/#/q/topic:bp/vgpu-rocky+(status:open+OR+status:merged) | 19:46 |
| *** shaohe_feng has joined #openstack-nova | 19:46 | |
| dansmith | the numa-ness is blocked on reshaper AFAIK | 19:47 |
| dansmith | which would be the NRP ones up there I guess, and some libvirt ones that don't appear to be in the list (and maybe aren't written yet) | 19:48 |
| melwitt | hm, ok | 19:48 |
| melwitt | efried: should we -W this one if we need to hold it behind reshaper? https://review.openstack.org/520313 | 19:49 |
| dansmith | man that's a lot of rechecks | 19:50 |
| efried | melwitt: I had previously -2'd https://review.openstack.org/#/c/521041/ which is the patch that actually puts the code in the way of the compute manager. But perhaps we want to move that -2 to the bottom as you say, since the first two patches don't do anything without the top one. | 19:51 |
| *** jmlowe has joined #openstack-nova | 19:51 | |
| melwitt | efried: k. at a glance, it looked like things we could merge as progress so it would help to -W or -2 to show that it needs to wait | 19:52 |
| *** bkopilov has joined #openstack-nova | 19:52 | |
| efried | melwitt: Yes, we could merge the bottom two without hurting anything. | 19:52 |
| *** itlinux has joined #openstack-nova | 19:53 | |
| efried | melwitt: I think some people might object to merging what's essentially "dead code". | 19:53 |
| efried | melwitt: Me, I'd rather see it merged so we've got a shorter path when we're ready to pull the trigger. | 19:53 |
| efried | But no strong feelings either way. | 19:54 |
| dansmith | I think we should wait | 19:54 |
| dansmith | merging refactors early in a set or something are useful, but if it's really dead code, we might as well wait, IMHO | 19:54 |
| *** shaohe_feng has quit IRC | 19:55 | |
| melwitt | I don't have a strong feeling about it. I think it'd be okay to merge some progress but waiting is also fine | 19:55 |
| *** shaohe_feng has joined #openstack-nova | 19:56 | |
| melwitt | mriedem: we have a proof-of-concept patch for the rbd erasure coding config option as of today, fyi https://review.openstack.org/581055 | 19:56 |
| *** moshele has quit IRC | 19:57 | |
| melwitt | jmlowe: is this something we can see working in the ceph job results? using the erasure coding? http://logs.openstack.org/55/581055/2/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/d6331b3/ | 19:57 |
| *** moshele has joined #openstack-nova | 19:58 | |
| jmlowe | you're thinking functional test? | 19:58 |
| melwitt | jmlowe: no, I mean I was wondering if there's anything ceph would log (in the ceph job I linked) that shows passing the data_pool did something. just curious if it's something we could see | 19:59 |
| jmlowe | I don't think so, let me poke around a little more, you can check the data pool of a rbd device with the ceph api but it's supposed to be relatively transparent aside from disk usage increasing in some other pool | 20:01 |
| jmlowe | or is that what you are thinking, write a gig and check the disk usage of the pools? | 20:02 |
| *** rmart04 has joined #openstack-nova | 20:02 | |
| melwitt | okay, that's cool. no, I wasn't thinking ahead that complex, just thought it'd be handy if something got reflected in the ceph job run for free | 20:02 |
| melwitt | for one thing, I doubt the job is running luminous so it wouldn't do anything anyway | 20:04 |
| *** shaohe_feng has quit IRC | 20:06 | |
| melwitt | oh, it actually is. cool. http://logs.openstack.org/55/581055/2/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/d6331b3/logs/ceph/ceph-mgr.x.txt.gz#_2018-07-10_01_16_55_913130 | 20:07 |
| *** shaohe_feng has joined #openstack-nova | 20:07 | |
| jmlowe | yeah, it is running luminous so it doesn't blow up | 20:08 |
| *** pchavva has quit IRC | 20:08 | |
| melwitt | jmlowe: what do you mean, what would make it blow up if not luminous? | 20:08 |
| dansmith | passing the flag that turns it on right? | 20:09 |
| dansmith | because EC isn't supported pre-limunous? | 20:09 |
| jmlowe | I'm pretty sure it's a generic abstraction, so you can do stupid ceph tricks like set the data pool to some other replicated pool, that wouldn't do anything useful except save you the extra work of setting up an erasure coded pool in a testing environment | 20:09 |
| dansmith | luminous | 20:09 |
| melwitt | well, I thought jmlowe had said that passing data_pool=None pre-luminous would make sure it doesn't hurt anything | 20:10 |
| jmlowe | guessing if you used the EOL jewel python binding it wouldn't have the kwarg for data_pool | 20:10 |
| melwitt | oh, I see. so we need to guard this behavior with a check for ceph version | 20:10 |
| jmlowe | yeah, nobody should be using jewel by the time this lands | 20:11 |
| melwitt | or are we safe assuming has to be >= luminous at this point? | 20:11 |
| melwitt | okay | 20:11 |
| jmlowe | you have to do stupid rpm tricks with centos if you wanted to use it with queens or later | 20:11 |
| melwitt | okay, good to know | 20:12 |
| jmlowe | I think the queens repo forces install of luminous repo for centos, was an annoyance when I was going to mimic | 20:12 |
| *** felipemonteiro__ has joined #openstack-nova | 20:13 | |
| *** felipemonteiro_ has quit IRC | 20:13 | |
| *** shaohe_feng has quit IRC | 20:16 | |
| *** felipemonteiro__ is now known as felipemonteiro | 20:16 | |
| *** shaohe_feng has joined #openstack-nova | 20:16 | |
| *** rmart04 has quit IRC | 20:18 | |
| mriedem | dansmith: i just went through Kevin_Zheng's 2nd in series live migration abort queued patch and only thing that kind of bothers me is the duplicate validation in the rpc api here https://review.openstack.org/#/c/568542/15/nova/compute/rpcapi.py - i've left an alternative and looking for a 2nd opinion on that | 20:21 |
| dansmith | mriedem: your link in that comment doesn't seem to point to anything relevant | 20:23 |
| dansmith | presumably you're looking at something that is checking service version | 20:24 |
| dansmith | which is cool, but if the service_version says things are okay, but they still have their rpc api manually pinned, they could conflict, so failing somehow is probably appropriate | 20:25 |
| *** shaohe_feng has quit IRC | 20:26 | |
| *** shaohe_feng has joined #openstack-nova | 20:27 | |
| *** felipemonteiro_ has joined #openstack-nova | 20:28 | |
| dansmith | oh sorry, are you talking about the migration status? | 20:28 |
| mriedem | yeah | 20:29 |
| dansmith | sorry, I totally focused on the version checks | 20:29 |
| mriedem | the api already checks if the migration status is running and if not it bombs out (today) | 20:29 |
| mriedem | then calls the rpc api which if the compute is old, makes the same check | 20:29 |
| dansmith | I don't think I understand why we need to check the status of the migration again | 20:29 |
| mriedem | see my comment | 20:29 |
| mriedem | i think the scenario is you are attempting to abort a queued live migration but the compute is old | 20:30 |
| dansmith | yeah I see it, but.. this code runs in the api itself, and doesn't actually know the version of the compute it's going to talk to | 20:30 |
| mriedem | his check for 'compute too old' is the can_send_version | 20:30 |
| dansmith | that's not compute-aware | 20:31 |
| mriedem | so his version check on the nova-compute service needs to happen in the api change if the user is trying to abort a !running migration and the host is old | 20:31 |
| mriedem | s/host/service/ | 20:32 |
| dansmith | can_send_version() is looking at the api service's rpc pin, which might be computed from service version, or manually set | 20:32 |
| *** felipemonteiro has quit IRC | 20:32 | |
| dansmith | mriedem: right | 20:32 |
| mriedem | ok, he's just following similar checks in compute rpc api for things like tagged attachments and such | 20:32 |
| dansmith | mriedem: and by the time we get to rpcapi, we don't have any new information we didn't have a couple frames up on the stack, so no need to do it again | 20:32 |
| openstackgerrit | Matt Rabe proposed openstack/nova master: Add destination MSP IP address to PowerVM migrate data https://review.openstack.org/581463 | 20:32 |
| dansmith | yeah, those are for things that haven't already checked service version for the actual compute and are relying on the pin I think | 20:33 |
| dansmith | which is a way to do it, but you don't need to do it in both places | 20:33 |
| mriedem | so if we check the nova-compute service version, we don't need the can_send_version (or any) changes to the compute rpcapi at all right? | 20:33 |
| *** yamamoto has joined #openstack-nova | 20:33 | |
| dansmith | well, no, | 20:34 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Remove unused variable in migration https://review.openstack.org/581464 | 20:34 |
| dansmith | which is why I was saying earlier | 20:34 |
| dansmith | you can check the service version to know whether all computes or the compute supports the !running cancel, but you don't know if the rpc pin is manually set low, | 20:34 |
| dansmith | so you need to do the can_send_version check in rpcapi | 20:34 |
| openstackgerrit | Matt Rabe proposed openstack/nova master: Add destination MSP IP address to PowerVM migrate data https://review.openstack.org/579676 | 20:35 |
| dansmith | which might be a reason to just do it there only, and not also up in api and just catch the exception | 20:35 |
| dansmith | let rpcapi tell you if the thing you're asking for is doable right now, and if not tell the user they can't have it | 20:35 |
| dansmith | since rpcapi can check both things | 20:35 |
| dansmith | don't need to check the service version itself for this I don't think | 20:36 |
| mriedem | yeah ok - i was wondering why he didn't just *move* the status check to rpcapi instead of duplicate it | 20:36 |
| dansmith | yeah | 20:36 |
| mriedem | you want to leave a comment in that change? | 20:36 |
| dansmith | not really, but I will :P | 20:36 |
| mriedem | thanks | 20:36 |
| *** shaohe_feng has quit IRC | 20:36 | |
| *** shaohe_feng has joined #openstack-nova | 20:38 | |
| *** yamamoto has quit IRC | 20:39 | |
| *** med_ has joined #openstack-nova | 20:43 | |
| *** moshele has quit IRC | 20:44 | |
| *** shaohe_feng has quit IRC | 20:47 | |
| *** shaohe_feng has joined #openstack-nova | 20:47 | |
| *** tidwellr has quit IRC | 20:52 | |
| *** itlinux has quit IRC | 20:53 | |
| *** Guest88425 has joined #openstack-nova | 20:54 | |
| mriedem | this is weird https://github.com/openstack/nova/blob/8469fa70dafa83cb068538679100bede7679edc3/nova/objects/service.py#L323 | 20:55 |
| *** med_ has quit IRC | 20:55 | |
| *** shaohe_feng has quit IRC | 20:57 | |
| *** priteau has joined #openstack-nova | 20:57 | |
| cdent | mriedem: that is odd | 20:57 |
| *** shaohe_feng has joined #openstack-nova | 20:57 | |
| mriedem | https://review.openstack.org/#/c/161822/5/nova/objects/service.py | 20:58 |
| openstackgerrit | Rick Bartra proposed openstack/nova master: Add granularity to os-services API https://review.openstack.org/578553 | 20:58 |
| *** felipemonteiro_ has quit IRC | 20:58 | |
| *** felipemonteiro_ has joined #openstack-nova | 20:59 | |
| mriedem | i have no idea why that was added there, | 20:59 |
| mriedem | but lots of people were approving of the chnage | 20:59 |
| mriedem | *change | 20:59 |
| mriedem | aha https://review.openstack.org/#/c/161822/2/nova/db/sqlalchemy/api.py@425 | 20:59 |
| mriedem | the db api used to behave that way | 20:59 |
| mriedem | so it was mirrored in the object | 21:00 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Tighten up ReportClient use of generation https://review.openstack.org/556669 | 21:01 |
| mriedem | apparently the service startup code relies on that to determine if it needs to create the service record | 21:01 |
| mriedem | rather than just handling the notfound | 21:01 |
| *** med_ has joined #openstack-nova | 21:03 | |
| *** flwang1 has joined #openstack-nova | 21:06 | |
| *** shaohe_feng has quit IRC | 21:07 | |
| *** shaohe_feng has joined #openstack-nova | 21:09 | |
| *** jmlowe has quit IRC | 21:10 | |
| *** cdent has quit IRC | 21:10 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Check provider generation and retry on conflict https://review.openstack.org/556669 | 21:11 |
| *** eharney has quit IRC | 21:13 | |
| *** shaohe_feng has quit IRC | 21:17 | |
| *** jmlowe has joined #openstack-nova | 21:18 | |
| *** shaohe_feng has joined #openstack-nova | 21:19 | |
| *** med_ has quit IRC | 21:20 | |
| *** antosh has quit IRC | 21:20 | |
| *** jmlowe has quit IRC | 21:23 | |
| *** med_ has joined #openstack-nova | 21:25 | |
| *** shaohe_feng has quit IRC | 21:28 | |
| *** shaohe_feng has joined #openstack-nova | 21:29 | |
| *** mago_ has joined #openstack-nova | 21:34 | |
| *** jmlowe has joined #openstack-nova | 21:36 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Avoid BadRequest error log on volume attachment https://review.openstack.org/581453 | 21:37 |
| *** priteau has quit IRC | 21:37 | |
| *** priteau has joined #openstack-nova | 21:37 | |
| *** shaohe_feng has quit IRC | 21:38 | |
| *** shaohe_feng has joined #openstack-nova | 21:38 | |
| *** mago_ has quit IRC | 21:39 | |
| *** Guest23991 has quit IRC | 21:40 | |
| *** antosh has joined #openstack-nova | 21:43 | |
| mriedem | dansmith: question in the numa aware vswitch hardware change here https://review.openstack.org/#/c/564448/14/nova/tests/unit/virt/test_hardware.py@3343 | 21:45 |
| dansmith | mriedem: see my comment on that in an earlier PS? | 21:46 |
| mriedem | nope | 21:46 |
| dansmith | mriedem: I think the deal is, the physnet may be available on the host, but the operator hasn't said that it's particularly affined to some node | 21:47 |
| dansmith | I stumbled on that as well, but worked out the reasoning from the comments and the tests | 21:47 |
| mriedem | but the point is, | 21:48 |
| dansmith | I dunno if that would just be "the operator doesn't care enough to configure the thing" or if there's some reason why it may not be affined, like it's too dynamic or something | 21:48 |
| mriedem | as a user i can say i want to be affined to baz and if the operator hasn't reported baz, we'll still do the build even though you might not be affined to baz | 21:48 |
| *** shaohe_feng has quit IRC | 21:48 | |
| mriedem | i'm thinking of it like inventory - is that the wrong way to think about this? | 21:48 |
| dansmith | no, that comment says that the user has requested network baz, and the compute node will do it, | 21:48 |
| mriedem | i see stephenfin has also dropped the patch that does any RT claims code | 21:49 |
| dansmith | but there is no *numa* affinity between a numa node and network baz | 21:49 |
| *** jogo has quit IRC | 21:49 | |
| mriedem | 'compute node will do it' as in, wire up the ports on network baz | 21:49 |
| dansmith | yeah | 21:49 |
| dansmith | the user doesn't request numa affinity to a network, | 21:49 |
| *** shaohe_feng has joined #openstack-nova | 21:50 | |
| dansmith | they request some network, and maybe some numa layout, but this process makes sure we select a favorable numa pinning of guest nodes to host nodes such that they won't end up on no affined nodes to the network they want | 21:50 |
| mriedem | assuming the operator has exposed that affinity info on the host... | 21:51 |
| mriedem | yeah? | 21:51 |
| dansmith | has configured it, yeah | 21:51 |
| dansmith | the user doesn't really know anything about this behind the scenes optimization | 21:52 |
| dansmith | they may know that their network performance isn't what it should be, | 21:52 |
| dansmith | but they ask for high-level things like being connected to network baz, | 21:52 |
| dansmith | and expect the backend is configuring their numa layout and pinning properly | 21:52 |
| dansmith | right now that doesn't happen, | 21:52 |
| dansmith | and if an operator doesn't or can't configure that information, they'll get what they get today | 21:53 |
| mriedem | can they, or can't they, throw a fit when they don't like what they get | 21:53 |
| mriedem | ignore that | 21:53 |
| *** med_ has quit IRC | 21:54 | |
| mriedem | ok that helps anyway, i was approaching this whole bp as a pass/fail type thing (hence the inventory thinking) rather than an optimization | 21:54 |
| dansmith | well, the hardware fitting thing is pass/fail | 21:55 |
| dansmith | meaning, | 21:55 |
| dansmith | "these nodes pass/fail my test for good-enough" | 21:55 |
| mriedem | so if i want baz and only foo and bar are reported, i get whatever. but if i want foo and foo is reported somewhere, scheduler picks that one specifically. | 21:55 |
| mriedem | right | 21:55 |
| dansmith | but in the case of no information, they pass as they do today | 21:55 |
| dansmith | yeah | 21:55 |
| mriedem | ok yeah - i should have read the tests when reviewing the code earlier | 21:55 |
| mriedem | ok +2 up through that point as well | 21:57 |
| *** tssurya has quit IRC | 21:58 | |
| *** shaohe_feng has quit IRC | 21:58 | |
| dansmith | okay, I won't get back to that today but I'll plan on it first thing in the morning | 21:59 |
| dansmith | and then circle back on yikun's assuming he gets it re-worked overnight | 21:59 |
| *** burt has quit IRC | 22:00 | |
| *** shaohe_feng has joined #openstack-nova | 22:00 | |
| mriedem | i'm sure his first and most pleasurable thing to do in the morning is figure out wtf we've done to his code series :) | 22:01 |
| *** edmondsw has quit IRC | 22:01 | |
| dansmith | hah yeah | 22:03 |
| *** felipemonteiro_ has quit IRC | 22:04 | |
| *** shaohe_feng has quit IRC | 22:09 | |
| *** shaohe_feng has joined #openstack-nova | 22:10 | |
| *** priteau has quit IRC | 22:13 | |
| *** shaohe_feng has quit IRC | 22:19 | |
| *** shaohe_feng has joined #openstack-nova | 22:20 | |
| *** rcernin has joined #openstack-nova | 22:22 | |
| mriedem | stephenfin: why was the numa-affined vswitch RT claims change dropped? https://review.openstack.org/#/c/564449/3/nova/compute/claims.py | 22:22 |
| mriedem | we can still have a late race/collision during the claim on the compute can't we? | 22:23 |
| *** med_ has joined #openstack-nova | 22:27 | |
| *** shaohe_feng has quit IRC | 22:29 | |
| *** shaohe_feng has joined #openstack-nova | 22:30 | |
| *** med_ has quit IRC | 22:32 | |
| *** yamamoto has joined #openstack-nova | 22:36 | |
| *** shaohe_feng has quit IRC | 22:39 | |
| *** shaohe_feng has joined #openstack-nova | 22:41 | |
| openstackgerrit | Merged openstack/nova master: hardware: fix hugepages memory usage per intances https://review.openstack.org/580657 | 22:41 |
| *** yamamoto has quit IRC | 22:42 | |
| *** med_ has joined #openstack-nova | 22:48 | |
| *** med_ has quit IRC | 22:48 | |
| *** med_ has joined #openstack-nova | 22:48 | |
| *** shaohe_feng has quit IRC | 22:50 | |
| *** shaohe_feng has joined #openstack-nova | 22:51 | |
| *** awaugama has quit IRC | 22:53 | |
| openstackgerrit | Merged openstack/nova master: Update root providers in same tree https://review.openstack.org/580246 | 22:59 |
| openstackgerrit | Merged openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262 | 22:59 |
| openstackgerrit | Merged openstack/nova master: Refactor policies to policy in InstanceGroup DB model https://review.openstack.org/579113 | 22:59 |
| *** shaohe_feng has quit IRC | 23:00 | |
| *** shaohe_feng has joined #openstack-nova | 23:01 | |
| *** hongbin has quit IRC | 23:06 | |
| *** shaohe_feng has quit IRC | 23:10 | |
| *** shaohe_feng has joined #openstack-nova | 23:13 | |
| *** edmondsw has joined #openstack-nova | 23:16 | |
| *** shaohe_feng has quit IRC | 23:20 | |
| *** edmondsw has quit IRC | 23:21 | |
| *** shaohe_feng has joined #openstack-nova | 23:22 | |
| *** bhagyashri_s has quit IRC | 23:27 | |
| *** antosh has quit IRC | 23:28 | |
| *** bhagyashri_s has joined #openstack-nova | 23:28 | |
| *** chyka_ has quit IRC | 23:29 | |
| *** shaohe_feng has quit IRC | 23:31 | |
| openstackgerrit | Merged openstack/os-vif master: doc: Fix formatting issues https://review.openstack.org/580443 | 23:31 |
| *** shaohe_feng has joined #openstack-nova | 23:31 | |
| *** yamamoto has joined #openstack-nova | 23:38 | |
| *** shaohe_feng has quit IRC | 23:41 | |
| *** shaohe_feng has joined #openstack-nova | 23:43 | |
| *** yamamoto has quit IRC | 23:44 | |
| *** Guest88425 has quit IRC | 23:51 | |
| *** shaohe_feng has quit IRC | 23:51 | |
| *** takashin has joined #openstack-nova | 23:51 | |
| *** shaohe_feng has joined #openstack-nova | 23:52 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!