Tuesday, 2018-07-10

*** shaohe_feng has quit IRC00:06
*** shaohe_feng has joined #openstack-nova00:08
*** gyee has quit IRC00:09
*** medberry has quit IRC00:12
*** jmlowe has joined #openstack-nova00:13
*** ccamacho has quit IRC00:14
*** shaohe_feng has quit IRC00:16
*** shaohe_feng has joined #openstack-nova00:20
*** chyka has quit IRC00:23
*** shaohe_feng has quit IRC00:27
*** shaohe_feng has joined #openstack-nova00:27
*** yamamoto has joined #openstack-nova00:34
*** shaohe_feng has quit IRC00:37
*** medberry has joined #openstack-nova00:37
*** shaohe_feng has joined #openstack-nova00:38
*** yamamoto has quit IRC00:39
*** shaohe_feng has quit IRC00:47
*** shaohe_feng has joined #openstack-nova00:48
*** ccamacho has joined #openstack-nova00:48
*** swamireddy has quit IRC00:49
*** jamesdenton has joined #openstack-nova00:52
*** shaohe_feng has quit IRC00:57
*** isq has quit IRC00:58
*** isq has joined #openstack-nova00:58
*** shaohe_feng has joined #openstack-nova00:59
*** tiendc has joined #openstack-nova00:59
*** takashin has joined #openstack-nova01:01
*** swamireddy has joined #openstack-nova01:01
takashinoomichi: Would you review https://review.openstack.org/#/c/529520/ again? It got one +2.01:02
openstackgerritMike Lowe proposed openstack/nova master: Option needed for ceph rbd erasure coding support  https://review.openstack.org/58105501:04
oomichitakashin: thanks for doing this, +A01:06
takashinoomichi: Thanks!01:06
*** hongbin has joined #openstack-nova01:08
*** shaohe_feng has quit IRC01:08
*** shaohe_feng has joined #openstack-nova01:09
*** masuberu has quit IRC01:09
*** chenyb4 has joined #openstack-nova01:10
*** shaohe_feng has quit IRC01:18
*** shaohe_feng has joined #openstack-nova01:21
*** shaohe_feng has quit IRC01:28
*** wwriverrat has quit IRC01:29
*** masber has joined #openstack-nova01:29
*** shaohe_feng has joined #openstack-nova01:30
*** wwriverrat has joined #openstack-nova01:30
*** wwriverrat has quit IRC01:31
*** mrsoul_ has joined #openstack-nova01:31
*** wwriverrat has joined #openstack-nova01:31
*** mrsoul` has joined #openstack-nova01:31
yikunmriedem, dansmith, Thanks for your help on group policy patch~and I will address left comments today.01:34
*** mrsoul has quit IRC01:34
*** mschuppert has quit IRC01:34
*** wwriverrat has quit IRC01:38
*** shaohe_feng has quit IRC01:38
*** moshele has joined #openstack-nova01:39
*** shaohe_feng has joined #openstack-nova01:40
*** ccamacho has quit IRC01:41
*** yamahata has quit IRC01:46
*** lei-zh has joined #openstack-nova01:48
*** shaohe_feng has quit IRC01:49
*** shaohe_feng has joined #openstack-nova01:50
*** andymccr has quit IRC01:57
*** andymccr has joined #openstack-nova01:57
*** shaohe_feng has quit IRC01:59
*** shaohe_feng has joined #openstack-nova02:00
*** oomichi has quit IRC02:05
openstackgerrithuanhongda proposed openstack/nova stable/queens: [Stable Only] Remove soft-deleted instances from quota_usages  https://review.openstack.org/57909302:08
*** shaohe_feng has quit IRC02:09
*** ircuser-1 has quit IRC02:10
*** shaohe_feng has joined #openstack-nova02:10
*** masuberu has joined #openstack-nova02:12
*** jmlowe_ has joined #openstack-nova02:13
*** spotz_ has joined #openstack-nova02:14
*** damien_r has joined #openstack-nova02:14
*** wwriverrat has joined #openstack-nova02:15
*** shaohe_feng_ has joined #openstack-nova02:15
*** corvus_ has joined #openstack-nova02:17
*** burt has quit IRC02:19
*** kaisers has quit IRC02:19
*** rnoriega has quit IRC02:19
*** corvus has quit IRC02:19
*** masber has quit IRC02:19
*** vishakha has quit IRC02:19
*** krtaylor has quit IRC02:19
*** tojuvone has quit IRC02:19
*** aarents has quit IRC02:19
*** sgordon has quit IRC02:19
*** brtknr has quit IRC02:19
*** bandini has quit IRC02:19
*** karimull1 has joined #openstack-nova02:19
*** krtaylor has joined #openstack-nova02:19
*** spotz has quit IRC02:19
*** jmlowe has quit IRC02:19
*** _pewp_ has quit IRC02:19
*** karimull has quit IRC02:19
*** shaohe_feng has quit IRC02:19
*** damien_r1 has quit IRC02:19
*** lei-zh has quit IRC02:19
*** jamesdenton has quit IRC02:19
*** ivve has quit IRC02:19
*** tobasco has quit IRC02:19
*** kukacz_ has quit IRC02:19
*** shaohe_feng_ has quit IRC02:19
*** shaohe_feng_ has joined #openstack-nova02:19
*** burt1 has joined #openstack-nova02:19
*** _pewp_ has joined #openstack-nova02:19
*** shaohe_feng_ is now known as shaohe_feng02:19
*** sgordon` has joined #openstack-nova02:19
*** vishakha has joined #openstack-nova02:19
*** sgordon` is now known as sgordon02:19
*** shaohe_feng has quit IRC02:19
*** tojuvone has joined #openstack-nova02:20
*** rnoriega has joined #openstack-nova02:20
*** kaisers has joined #openstack-nova02:20
*** kaisers has quit IRC02:20
*** krtaylor has quit IRC02:20
*** karimull1 has quit IRC02:20
*** aarents has joined #openstack-nova02:20
*** karimull has joined #openstack-nova02:21
*** brtknr has joined #openstack-nova02:21
*** tobasco has joined #openstack-nova02:22
*** shaohe_feng has joined #openstack-nova02:25
*** bandini has joined #openstack-nova02:25
*** kaisers has joined #openstack-nova02:25
*** krtaylor has joined #openstack-nova02:25
*** shaohe_feng has quit IRC02:25
*** shaohe_feng has joined #openstack-nova02:25
*** ivve has joined #openstack-nova02:28
*** shaohe_feng has quit IRC02:30
*** kukacz_ has joined #openstack-nova02:30
*** shaohe_feng has joined #openstack-nova02:30
*** hoonetorg has quit IRC02:31
*** shaohe_feng has quit IRC02:40
*** shaohe_feng has joined #openstack-nova02:41
*** psachin has joined #openstack-nova02:45
*** hoonetorg has joined #openstack-nova02:47
*** shaohe_feng has quit IRC02:50
*** shaohe_feng has joined #openstack-nova02:52
*** mriedem has quit IRC02:54
*** moshele has quit IRC02:54
*** shaohe_feng has quit IRC03:00
*** shaohe_feng has joined #openstack-nova03:02
*** sapd_ has joined #openstack-nova03:04
*** sapd__ has quit IRC03:04
*** shaohe_feng has quit IRC03:11
*** shaohe_feng has joined #openstack-nova03:12
*** ccamacho has joined #openstack-nova03:18
*** shaohe_feng has quit IRC03:21
*** shaohe_feng has joined #openstack-nova03:24
*** shaohe_feng has quit IRC03:31
*** shaohe_feng has joined #openstack-nova03:33
*** Guest61318 has quit IRC03:34
*** Guest61318 has joined #openstack-nova03:35
*** corvus_ is now known as corvus03:36
*** corvus is now known as Guest7845703:37
*** Guest78457 is now known as jeblair03:38
*** hongbin has quit IRC03:39
*** shaohe_feng has quit IRC03:41
*** jeblair is now known as corvus03:43
*** masuberu has quit IRC03:43
*** shaohe_feng has joined #openstack-nova03:47
*** udesale has joined #openstack-nova03:48
*** lpetrut has joined #openstack-nova03:48
*** Bhujay has joined #openstack-nova03:49
*** shaohe_feng has quit IRC03:52
*** yamamoto has joined #openstack-nova03:52
*** shaohe_feng has joined #openstack-nova03:53
*** shaohe_feng has quit IRC04:02
*** tetsuro has joined #openstack-nova04:03
*** shaohe_feng has joined #openstack-nova04:05
*** lpetrut has quit IRC04:08
*** medberry has quit IRC04:08
*** lpetrut has joined #openstack-nova04:09
*** ccamacho has quit IRC04:09
*** mdnadeem has joined #openstack-nova04:11
*** hongbin has joined #openstack-nova04:12
*** shaohe_feng has quit IRC04:12
*** shaohe_feng has joined #openstack-nova04:13
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object  https://review.openstack.org/56337504:17
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object  https://review.openstack.org/56340104:17
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Change the ServerGroupAntiAffinityFilter to adapt to new policy  https://review.openstack.org/57116604:17
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model  https://review.openstack.org/57146504:17
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group  https://review.openstack.org/56753404:17
*** hongbin has quit IRC04:20
*** shaohe_feng has quit IRC04:22
*** shaohe_feng has joined #openstack-nova04:24
*** jappleii__ has quit IRC04:25
*** threestrands has joined #openstack-nova04:25
openstackgerritMerged openstack/nova master: Add rules column to instance_group_policy table.  https://review.openstack.org/56083204:28
*** shaohe_feng has quit IRC04:33
*** shaohe_feng has joined #openstack-nova04:33
*** janki has joined #openstack-nova04:35
*** lpetrut has quit IRC04:35
*** yamamoto_ has joined #openstack-nova04:42
*** shaohe_feng has quit IRC04:43
*** shaohe_feng has joined #openstack-nova04:44
*** yamamoto has quit IRC04:45
*** brault has joined #openstack-nova04:49
*** abhishekk has joined #openstack-nova04:53
*** moshele has joined #openstack-nova04:53
*** shaohe_feng has quit IRC04:53
*** shaohe_feng has joined #openstack-nova04:54
*** brault has quit IRC04:54
*** moshele has quit IRC04:55
*** shaohe_feng has quit IRC05:03
*** shaohe_feng has joined #openstack-nova05:05
*** shaohe_feng has quit IRC05:14
*** shaohe_feng has joined #openstack-nova05:15
*** yamamoto_ has quit IRC05:16
*** lpetrut has joined #openstack-nova05:18
*** links has joined #openstack-nova05:22
*** shaohe_feng has quit IRC05:24
*** shaohe_feng has joined #openstack-nova05:26
*** ratailor has joined #openstack-nova05:32
*** quiquell|off is now known as quiquell05:33
*** lpetrut has quit IRC05:33
*** shaohe_feng has quit IRC05:34
*** yamamoto has joined #openstack-nova05:35
*** shaohe_feng has joined #openstack-nova05:36
*** jichen has joined #openstack-nova05:38
*** Guest61318 has quit IRC05:44
*** shaohe_feng has quit IRC05:44
*** armaan has joined #openstack-nova05:45
*** shaohe_feng has joined #openstack-nova05:45
*** brault has joined #openstack-nova05:45
openstackgerrithuanhongda proposed openstack/nova master: Remove duplicate parameter in API sample documents  https://review.openstack.org/58120305:47
*** Luzi has joined #openstack-nova05:47
*** brault has quit IRC05:50
*** brault has joined #openstack-nova05:51
*** Guest61318 has joined #openstack-nova05:53
*** shaohe_feng has quit IRC05:55
*** moshele has joined #openstack-nova05:55
*** shaohe_feng has joined #openstack-nova05:55
*** shaohe_feng has quit IRC06:05
*** shaohe_feng has joined #openstack-nova06:06
*** hshiina has joined #openstack-nova06:09
*** sidx64 has joined #openstack-nova06:09
openstackgerritMerged openstack/nova master: Remove mox in unit/network/test_neutronv2.py (2)  https://review.openstack.org/57348106:10
openstackgerritMerged openstack/nova master: Allow templated cell_mapping URLs  https://review.openstack.org/57816306:10
openstackgerritMerged openstack/nova master: api-ref: Example verification for servers.inc  https://review.openstack.org/52952006:10
openstackgerritMerged openstack/nova master: placement: delete auto-created consumers on fail  https://review.openstack.org/57992106:10
openstackgerritMerged openstack/nova master: delete consumers which no longer have allocations  https://review.openstack.org/58108606:10
*** shaohe_feng has quit IRC06:15
*** shaohe_feng has joined #openstack-nova06:16
*** andreas_s has joined #openstack-nova06:17
*** mrsoul_ is now known as mschuppert06:20
*** shaohe_feng has quit IRC06:25
*** shaohe_feng has joined #openstack-nova06:26
*** abhishekk has quit IRC06:26
*** yamahata has joined #openstack-nova06:27
*** medberry has joined #openstack-nova06:27
*** medberry has quit IRC06:27
*** medberry has joined #openstack-nova06:27
*** ispp has joined #openstack-nova06:29
*** med_ has quit IRC06:29
*** armaan has quit IRC06:30
*** threestrands has quit IRC06:30
*** armaan has joined #openstack-nova06:31
*** hamzy has quit IRC06:31
*** armaan has quit IRC06:35
*** mdnadeem has quit IRC06:35
*** shaohe_feng has quit IRC06:36
*** links has quit IRC06:38
*** shaohe_feng has joined #openstack-nova06:39
openstackgerritGhanshyam Mann proposed openstack/nova master: Complete the api-ref of security group rule  https://review.openstack.org/58010906:41
*** abhishekk has joined #openstack-nova06:42
*** shaohe_feng has quit IRC06:46
*** shaohe_feng has joined #openstack-nova06:46
*** naichuans_ has quit IRC06:47
*** mdnadeem has joined #openstack-nova06:48
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata  https://review.openstack.org/57801906:48
*** ccamacho has joined #openstack-nova06:50
openstackgerritNeha Alhat proposed openstack/python-novaclient master: Remove initialization of logger if logger is None  https://review.openstack.org/58121806:51
*** links has joined #openstack-nova06:53
*** lpetrut has joined #openstack-nova06:53
*** shaohe_feng has quit IRC06:56
*** shaohe_feng has joined #openstack-nova06:57
openstackgerritBrin Zhang proposed openstack/nova master: Add unshelve instance error info to fault table  https://review.openstack.org/57974706:59
*** tssurya has joined #openstack-nova06:59
*** armaan has joined #openstack-nova07:00
openstackgerritBrin Zhang proposed openstack/nova master: Add unshelve instance error info to fault table  https://review.openstack.org/57974707:01
*** hiro-kobayashi has joined #openstack-nova07:01
*** shaohe_feng has quit IRC07:06
*** aloga has joined #openstack-nova07:07
*** shaohe_feng has joined #openstack-nova07:07
*** mgoddard has joined #openstack-nova07:07
*** sidx64 has quit IRC07:09
*** phuongnh has joined #openstack-nova07:10
*** phuongnh has quit IRC07:11
*** sidx64 has joined #openstack-nova07:11
*** phuongnh has joined #openstack-nova07:11
*** tesseract has joined #openstack-nova07:13
*** hiro-kobayashi has quit IRC07:14
*** shaohe_feng has quit IRC07:17
*** jmccarthy has joined #openstack-nova07:17
*** shaohe_feng has joined #openstack-nova07:18
*** alexchadin has joined #openstack-nova07:19
*** peereb has joined #openstack-nova07:19
*** ragiman has joined #openstack-nova07:20
*** yamahata has quit IRC07:25
*** yamahata has joined #openstack-nova07:26
*** hamzy has joined #openstack-nova07:27
*** shaohe_feng has quit IRC07:27
*** sahid has joined #openstack-nova07:27
*** shaohe_feng has joined #openstack-nova07:28
*** abhishekk has quit IRC07:30
openstackgerritkarim proposed openstack/nova master: Handle rebuild of instances with image traits  https://review.openstack.org/56949807:35
*** shaohe_feng has quit IRC07:37
*** shaohe_feng has joined #openstack-nova07:38
*** mgoddard has quit IRC07:41
*** ispp has quit IRC07:43
*** links has quit IRC07:44
*** abhishekk has joined #openstack-nova07:46
*** rcernin has quit IRC07:47
*** shaohe_feng has quit IRC07:47
*** amoralej|off is now known as amoralej07:48
*** shaohe_feng has joined #openstack-nova07:49
*** alexchadin has quit IRC07:50
*** shaohe_feng has quit IRC07:50
*** shaohe_feng has joined #openstack-nova07:50
*** alexchadin has joined #openstack-nova07:52
*** sq4ind has left #openstack-nova07:54
*** links has joined #openstack-nova07:57
*** shaohe_feng has quit IRC07:58
*** shaohe_feng has joined #openstack-nova07:59
openstackgerritSurya Seetharaman proposed openstack/nova-specs master: Fix nits in the handling down cell spec  https://review.openstack.org/58124308:01
openstackgerrithuanhongda proposed openstack/nova master: Microversion 2.64 - Add "deleted" time in GET server response  https://review.openstack.org/57415908:02
*** sidx64 has quit IRC08:02
*** takashin has left #openstack-nova08:02
*** ttsiouts has joined #openstack-nova08:05
*** mgoddard has joined #openstack-nova08:06
*** shaohe_feng has quit IRC08:08
*** shaohe_feng has joined #openstack-nova08:09
*** rodolof has joined #openstack-nova08:11
*** derekh has joined #openstack-nova08:15
openstackgerritBalazs Gibizer proposed openstack/nova master: Transform missing delete notifications  https://review.openstack.org/41029708:17
openstackgerritBalazs Gibizer proposed openstack/nova master: Send soft_delete from context manager  https://review.openstack.org/47645908:17
*** shaohe_feng has quit IRC08:18
*** shaohe_feng has joined #openstack-nova08:19
*** hshiina has quit IRC08:22
*** sidx64 has joined #openstack-nova08:26
*** bkopilov has quit IRC08:26
*** vishakha has quit IRC08:28
*** shaohe_feng has quit IRC08:29
*** bkopilov has joined #openstack-nova08:30
*** shaohe_feng has joined #openstack-nova08:30
*** rmart04 has joined #openstack-nova08:32
*** sridharg has joined #openstack-nova08:36
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group  https://review.openstack.org/56753408:36
*** yamahata has quit IRC08:38
*** shaohe_feng has quit IRC08:39
*** shaohe_feng has joined #openstack-nova08:40
*** hiro-kobayashi has joined #openstack-nova08:47
*** toabctl has quit IRC08:48
*** shaohe_feng has quit IRC08:49
openstackgerritVu Cong Tuan proposed openstack/os-traits master: Switch to stestr  https://review.openstack.org/58126508:49
*** mago_ has joined #openstack-nova08:51
*** shaohe_feng has joined #openstack-nova08:51
*** toabctl has joined #openstack-nova08:54
*** sidx64 has quit IRC08:55
*** priteau has joined #openstack-nova08:55
*** sidx64 has joined #openstack-nova08:56
*** cdent has joined #openstack-nova08:56
*** shaohe_feng has quit IRC08:59
*** shaohe_feng has joined #openstack-nova09:00
*** bkopilov has quit IRC09:05
*** bkopilov has joined #openstack-nova09:06
*** mago_ has quit IRC09:06
*** flwang1 has joined #openstack-nova09:09
*** shaohe_feng has quit IRC09:10
*** Guest61318 has quit IRC09:10
*** shaohe_feng has joined #openstack-nova09:11
flwang1greetings, can anybody help me understand how the local_gb set for hypervisor?09:11
*** sambetts_ is now known as sambetts09:12
*** sidx64 has quit IRC09:13
flwang1after installed devstack, i found the local_gb of hypervisor is so small, but i have a big cinder volume vg, stack-volumes-default       1   0   0 wz--n- 100.00g 100.00g09:13
flwang1so the question is, how can I let the hypervisor to use the stack-volumes? thanks09:14
*** jangutter has quit IRC09:15
*** ccamacho has quit IRC09:16
*** ratailor has quit IRC09:17
openstackgerritSurya Seetharaman proposed openstack/nova master: Add queued for delete to instance_mappings table.  https://review.openstack.org/56678809:18
openstackgerritSurya Seetharaman proposed openstack/nova master: Add queued_for_delete field to InstanceMapping object  https://review.openstack.org/56679509:18
*** vivsoni has joined #openstack-nova09:18
*** ratailor has joined #openstack-nova09:19
*** sidx64 has joined #openstack-nova09:19
*** shaohe_feng has quit IRC09:20
*** shaohe_feng has joined #openstack-nova09:20
fanzhanghi flwang1 I think it's the resource tracker updates the hypervisor info. As for the loca_gb, check configuration option 'state_path' in /etc/nova/nova.conf, you can change this item with your cinder volume vg path09:22
openstackgerritVu Cong Tuan proposed openstack/os-traits master: Switch to stestr  https://review.openstack.org/58126509:24
* fanzhang e.g. I have changed state_path=/mnt/vdc/nova which I mounted a 500G volume on it /dev/vdc1 493G 1.2G 466G 1% /mnt/vdc09:25
fanzhangflwang1 ^09:25
jmccarthyIs it a common problem, when deleting instances, that volumes which were attached to it may be left with stuck attachments to the instance afterwards ? (queens)09:25
*** Guest61318 has joined #openstack-nova09:25
*** deepak_mourya has quit IRC09:26
flwang1fanzhang: cool, i will give it a try09:26
fanzhangjmccarthy I think it's just about the hypervisor configuration  :)09:27
fanzhangflwang1 good luck \o/09:27
*** sidx64 has quit IRC09:28
flwang1fanzhang: seems it doesn't work09:29
openstackgerritVu Cong Tuan proposed openstack/nova-specs master: Switch to stestr  https://review.openstack.org/58128409:29
jmccarthyOh I was asking about a different issue, I seem to have an issue with multiattach volumes that get stuck to instances which have been deleted09:29
fanzhangflwang1 do you restart openstack-nova-comput service? Try to wait awhile for periodic task updating the hypervisor info.09:30
*** shaohe_feng has quit IRC09:30
*** itlinux has joined #openstack-nova09:30
*** shaohe_feng has joined #openstack-nova09:31
*** mdnadeem has quit IRC09:31
*** ccamacho has joined #openstack-nova09:33
openstackgerritGhanshyam Mann proposed openstack/nova master: Use hard coded values in schema than reference  https://review.openstack.org/58128809:35
*** jangutter has joined #openstack-nova09:35
openstackgerritGhanshyam Mann proposed openstack/nova master: Use hard coded values in schema than reference  https://review.openstack.org/58128809:36
*** mdnadeem has joined #openstack-nova09:37
*** shaohe_feng has quit IRC09:40
*** jmccarthy has left #openstack-nova09:42
*** shaohe_feng has joined #openstack-nova09:42
*** stakeda has quit IRC09:44
*** rcernin has joined #openstack-nova09:44
*** stakeda has joined #openstack-nova09:44
*** rcernin has quit IRC09:47
*** ratailor has quit IRC09:47
flwang1fanzhang: i restarted all nova services and wait quite a white09:48
flwang1but it's still using my root and it's 30GB09:48
*** ratailor has joined #openstack-nova09:48
fanzhangflwang1 emmm...it's odd...09:49
*** shaohe_feng has quit IRC09:51
fanzhangoh, do you change the folder's owner and owning group with nova:nova ?09:51
*** shaohe_feng has joined #openstack-nova09:52
flwang1fanzhang: nope, let me try09:52
flwang1oh, i don't have nova user in my system09:53
*** sidx64 has joined #openstack-nova09:54
*** zhangbailin_ has joined #openstack-nova09:55
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group  https://review.openstack.org/56753409:56
*** itlinux has quit IRC09:56
fanzhangflwang1 emmm...my env is packstack, and I am pretty sure I have nova user :) Check the owner and owning group of your folder on previous state_patch ?09:58
*** mago_ has joined #openstack-nova09:58
flwang1i did and i'm using the same user/user group and it still doesn't work :(09:58
*** sidx64 has quit IRC09:59
flwang1fanzhang: i will monitor it for a while and will see09:59
sapd_Hi everyone. I'm looking for the change which implement rebuild for volume-backed instance.10:01
*** shaohe_feng has quit IRC10:01
flwang1sapd_: that's the one i worked on 3 years ago :(10:01
flwang1and i failed10:01
fanzhangflwang1 ok, good luck :)10:02
flwang1fanzhang: thank you very much anyway ;)10:02
*** shaohe_feng has joined #openstack-nova10:02
openstackgerrithuanhongda proposed openstack/nova master: Microversion 2.64 - Add "deleted" time in GET server response  https://review.openstack.org/57415910:02
sapd_flwang1: I'm using this patch https://review.openstack.org/#/c/528740/ for Pike release, But when I apply this patch for Queens release, It's not work again.10:02
*** Guest61318 has quit IRC10:03
openstackgerritMerged openstack/nova master: Regression test for bug 1779818  https://review.openstack.org/58001110:03
openstackbug 1779818 in OpenStack Compute (nova) "child's root provider is not updated." [Medium,In progress] https://launchpad.net/bugs/1779818 - Assigned to Tetsuro Nakamura (tetsuro0907)10:03
*** itlinux has joined #openstack-nova10:04
*** ttsiouts has quit IRC10:07
*** sidx64 has joined #openstack-nova10:09
*** neha_alhat_ has joined #openstack-nova10:10
neha_alhat_cdent: Hi10:10
*** shaohe_feng has quit IRC10:11
*** sapd_ has quit IRC10:11
*** sapd has joined #openstack-nova10:11
*** shaohe_feng has joined #openstack-nova10:12
*** chenyb4 has quit IRC10:12
cdenthi neha_alhat_10:12
stephenfinsahid: Comments left on https://review.openstack.org/#/c/580657. Fancy taking a look?10:12
neha_alhat_cdent: For some performance testing I want to create 100 RPs, for that I am writing python code.10:13
* cdent nods10:13
neha_alhat_cdent: 100 Resource providers*10:13
neha_alhat_cdent: using openstackclient: openstack resource provider create rp110:14
stephenfinmdbooth, lyarwood: I'm guessing this failing test is a race or the likes in our unit tests? http://logs.openstack.org/57/580657/2/check/openstack-tox-lower-constraints/607ab0c/job-output.txt.gz10:14
stephenfinLooks unrelated to the actual change https://review.openstack.org/#/c/58065710:15
*** yamamoto has quit IRC10:15
mdboothstephenfin: clicking10:15
*** Bhujay has quit IRC10:15
*** Bhujay has joined #openstack-nova10:15
cdentneha_alhat_: if you do that in a loop with a different name each time, that ought to work. another way to do it is directly in python code that makes its own http requests to the service10:17
*** Bhujay has quit IRC10:17
neha_alhat_cdent: But I am unable to create novaclient using openstackclient in python code. Like we can do in cinderclient: https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/client.py#L5110:17
mdboothstephenfin: Weird!10:17
*** Bhujay has joined #openstack-nova10:18
stephenfinRight? It's the lower constraints job so we're using different requirements to usual but I can't see how that would be an issue10:18
*** Bhujay has quit IRC10:19
mdboothstephenfin: I hit failures in those tests recently which didn't hit on python2. Any chance they run a different set of tests?10:19
*** Bhujay has joined #openstack-nova10:19
neha_alhat_cdent: How can I create a http requests to the service through python code10:19
stephenfinmdbooth: What do you mean a different set of tests?10:19
*** yamamoto has joined #openstack-nova10:19
neha_alhat_cdent: like https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/client.py#L5110:20
cdentneha_alhat_: that's right, there is no "for use in code" placement client. This is because making your own is very straightforward. Have a look at the code around https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L270 for some ideas10:20
mdboothstephenfin: i.e. it runs unit tests which don't run in py2710:20
stephenfinI don't think so https://github.com/openstack/nova/blob/master/tox.ini#L24910:20
gibistephenfin: I think you see this https://bugs.launchpad.net/nova/+bug/177971110:20
openstackLaunchpad bug 1779711 in OpenStack Compute (nova) "test_pre_live_migration_volume_backed* intermittently fails serialized json compare" [Critical,Fix released] - Assigned to Matt Riedemann (mriedem)10:20
stephenfingibi: Yup, that looks like the one and the same10:20
mdboothgibi: Whoa...10:21
mdboothgibi: Ah... dict ordering10:21
gibiyeah, good old dict ordering10:21
*** shaohe_feng has quit IRC10:21
stephenfingibi: Not the first thing I've been caught out by ordering in recent days :)10:21
stephenfin*first time10:21
*** shaohe_feng has joined #openstack-nova10:22
*** mvk_ has quit IRC10:22
gibipython 3.7 adds stable dict key ordering https://docs.python.org/3/tutorial/datastructures.html#dictionaries10:23
mdboothAren't all dicts ordered in the newest anguine offering?10:23
stephenfinfwiw, Python 3.6+ dicts are insertion ordered, which is rather nice10:23
mdboothgibi: Snap ;)10:23
stephenfinmdbooth: double snap10:23
stephenfinI'm sure whoever is working on nova in 10 years or whenever we can drop Python < 3.6 support will be very happy10:24
* kashyap wonders about those who will be debugging Nova live migration problems in 10 years...10:31
kashyap(Maybe there won't be any.)10:31
*** shaohe_feng has quit IRC10:32
*** phuongnh has quit IRC10:32
*** shaohe_feng has joined #openstack-nova10:33
neha_alhat_cdent: yes, will check. Thanks10:35
*** stakeda has quit IRC10:37
*** abhishekk has quit IRC10:39
*** shaohe_feng has quit IRC10:42
*** shaohe_feng has joined #openstack-nova10:42
*** alexchadin has quit IRC10:43
*** alexchadin has joined #openstack-nova10:43
*** alexchadin has quit IRC10:44
*** yamamoto has quit IRC10:45
*** jichen has quit IRC10:48
*** mvk_ has joined #openstack-nova10:48
*** shaohe_feng has quit IRC10:52
*** pchavva has joined #openstack-nova10:55
*** shaohe_feng has joined #openstack-nova10:55
*** udesale has quit IRC10:56
*** sidx64 has quit IRC10:58
*** hiro-kobayashi has quit IRC11:00
*** tetsuro has quit IRC11:00
*** tiendc has quit IRC11:00
*** ttsiouts has joined #openstack-nova11:02
*** sidx64 has joined #openstack-nova11:02
*** shaohe_feng has quit IRC11:02
*** shaohe_feng has joined #openstack-nova11:04
*** sidx64 has quit IRC11:06
*** sidx64 has joined #openstack-nova11:07
*** yassine has joined #openstack-nova11:09
*** yassine is now known as Guest8842511:09
*** shaohe_feng has quit IRC11:13
cdentjohnthetubaguy: you still happy with https://review.openstack.org/#/c/543262/ ?11:13
*** shaohe_feng has joined #openstack-nova11:15
*** itlinux has quit IRC11:21
*** sidx64 has quit IRC11:21
*** blkart has quit IRC11:23
*** shaohe_feng has quit IRC11:23
*** shaohe_feng has joined #openstack-nova11:23
*** alexchadin has joined #openstack-nova11:24
*** edmondsw has joined #openstack-nova11:25
*** sidx64 has joined #openstack-nova11:31
*** yamamoto has joined #openstack-nova11:33
*** shaohe_feng has quit IRC11:33
*** shaohe_feng has joined #openstack-nova11:34
flwang1i'm going to ask again, can anybody help understand how to set the local_gb for hypervisor? thanks11:34
*** sidx64 has quit IRC11:36
*** blkart has joined #openstack-nova11:40
jrollflwang1: that's set by nova-compute when it updates its resources. it looks at the size of the block device that instances are on11:43
*** vivsoni_ has joined #openstack-nova11:43
*** shaohe_feng has quit IRC11:43
flwang1jroll: thanks, then my question is how can i change it?11:43
jrollchange local_gb? I don't believe you can. why do you want to?11:44
*** vivsoni has quit IRC11:44
*** ttsiouts_ has joined #openstack-nova11:45
*** shaohe_feng has joined #openstack-nova11:45
flwang1after installed devstack, i found the local_gb is too small because it's using my root /, though i have almost 800GB at /home11:45
flwang1but my / only has 30GB11:45
jrollflwang1: there's a config option for where the instance data lives, you can change that11:46
* jroll looks for it11:46
*** lyan has joined #openstack-nova11:46
*** lyan is now known as Guest2399111:46
flwang1#instances_path = /opt/stack/data/nova/instances11:46
flwang1#state_path = /opt/stack/data/nova11:46
jrollyes, instances_path11:47
*** ttsiouts has quit IRC11:47
flwang1i changed them both and doesn't work11:47
jrolldid you restart nova-compute (and give it time to update resources)?11:48
*** ispp has joined #openstack-nova11:48
flwang1yes, i did. i restarted all nova services11:48
*** ttsiouts_ has quit IRC11:48
jrollhm, that's odd. I'm not sure if there's something else that needs to be done, hopefully someone else can help, sorry11:49
*** dpawlik_ has quit IRC11:50
flwang1jroll: no worries, thank you for the help11:50
*** ttsiouts has joined #openstack-nova11:51
efriedAnyone happen to know where it's documented how/where we, as developers, are supposed to use translation macros in code?11:52
flwang1jroll: i think that's the issue, after restart the nova-compute, it's still trying to talk to the old path11:53
flwang1not sure why11:53
*** shaohe_feng has quit IRC11:54
jrollyeah, that would be my guess11:54
jrollefried: this is a good start: https://docs.openstack.org/oslo.i18n/latest/user/guidelines.html11:54
*** mgoddard has quit IRC11:54
efriedThanks jroll11:54
jrollprimarily "All text messages the user sees via exceptions or API calls should be marked for translation"11:55
*** dpawlik has joined #openstack-nova11:55
efriedjroll: Yeah, I need something even more basic than that, for karimull.11:55
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Fix all invalid obj_make_compatible test case  https://review.openstack.org/57424011:55
jrollI'm not sure how to make that more basic :/11:55
*** amoralej is now known as amoralej|lunch11:55
*** shaohe_feng has joined #openstack-nova11:56
efriedjroll: See https://review.openstack.org/#/c/569498/10..11/nova/conductor/manager.py11:56
*** med_ has joined #openstack-nova11:59
efriedI.e. need to describe what "marked for translation" means.  I think that doc works.11:59
jrollefried: yeah, I don't have anything better11:59
efriedkarimull: After you've looked at the doc, let me know if you'd like some more background.12:00
*** armaan has quit IRC12:00
*** armaan has joined #openstack-nova12:00
*** shaohe_feng has quit IRC12:04
*** shaohe_feng has joined #openstack-nova12:05
sahidstephenfin: thanks for your eye on this. I just replied12:06
openstackgerritMerged openstack/nova master: Handle compare in test_pre_live_migration_volume_backed* directly  https://review.openstack.org/58070212:07
*** shaohe_feng has quit IRC12:14
*** sidx64 has joined #openstack-nova12:15
*** shaohe_feng has joined #openstack-nova12:15
*** markvoelker has quit IRC12:18
*** hamzy has quit IRC12:18
mago_Hi team, I'm working on GPU Passtrough on OpenStack. I would like to limit the number of GPUs available to a user / project. There is no quotas for Passthrough resources and I was wondering why ? I was googling around but found no where a similar question.12:18
*** markvoelker has joined #openstack-nova12:21
mago_Side question, as quotas are not only for Nova, but also for the Network and Block Storage services, is there a better place to ask my question ?12:22
openstackgerritYikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.64 - Use new format policy in server group  https://review.openstack.org/57826112:23
*** janki has quit IRC12:24
*** sidx64 has quit IRC12:24
efriedmago_: You mean like project-wide?  Cause I would imagine there probably wouldn't be enough GPUs on a single host for quotas to make much sense.12:24
*** shaohe_feng has quit IRC12:24
efriedmago_: but are you talking about physical or virtual GPUs?12:24
*** shaohe_feng has joined #openstack-nova12:25
*** yamamoto has quit IRC12:26
jaypipesjohnthetubaguy: https://review.openstack.org/#/c/543262/ could use your +2 restoration.12:26
*** yamamoto has joined #openstack-nova12:26
*** sidx64 has joined #openstack-nova12:27
mago_efried, well you could imagine a cluster with nodes with 4 to 8 GPU cards, if you have let's say 10 nodes, you can have up to 80 GPUs available. I think a quota would make sense.12:27
jaypipesmago_: there is no quota class for either virtual or physical GPUs, no.12:27
mago_efried, I talk about GPU cards, passed to VMs using passthrough (also called Direct Device Assignment)12:28
efriedmago_: Yup, got it.  I defer to jaypipes here, perhaps he can explain why there are no quotas.12:29
jaypipesmago_: I can't explain *why* there are no quotas for GPUs. or at least, I can't explain that without some seriously opinionated rant about how our PCI manager system was created.12:30
mago_jaypipes, do you know why, I mean is it technically not possible because of the way quotas are implemented, or could it be imagined ? for GPUs, or for passthrough resources in general12:31
*** markvoelker has quit IRC12:31
jaypipesmago_: quotas were not considered by the creators of the pci management module in nova.12:32
jaypipesmago_: when and if we move the management of PCI resources to the placement service, we will be able to use quotas for those PCI resource classes, but until then, it's not going to happen.12:33
*** shaohe_feng has quit IRC12:35
mago_jaypipes, ok, understood. It does not seem to be an easy task, but do you know if this is already addressed / under discussion ?12:35
*** markvoelker has joined #openstack-nova12:35
*** shaohe_feng has joined #openstack-nova12:35
mdboothstephenfin gibi: Do we have something like a fixture which perturbs dicts? Running nova.tests.unit.virt.libvirt.test_driver.LibvirtConnTestCase.test_pre_live_migration_volume_backed_encrypted fails for me literally every other time when running only that test.12:38
mdboothIt's weird.12:38
mdboothI know dict order isn't guaranteed, but all things being equal I'd expect it to be consistent in practise unless something is deliberately making it inconsistent.12:39
gibimdbooth: I don't think we have. I think the order depends on the PYTHONHASHSEED12:39
jaypipesmago_: we've been planning on moving the queries for calculation of resource usage out of the nova-api service and towards the placement service for a while (https://review.openstack.org/#/c/509042/) but until we are tracking all the different types of resources using the placement service consistently, such an effort is only ever going to yield a small benefit. PCI devices, NUMA topology and dedicated CPUs, and certain networking resources12:39
jaypipeslike SR-IOV VFs are some of the resource types we do *not* currently track using the placement service. our work on nested resource providers, granular request groups, and the "reshaper" effort are paving the way to supporting these types of resources in the placement service. I predict that we'll have most of that work done by the end of the "T" release series, at which point the quotas-in-placement work can become a reality.12:39
efriedmdbooth: There's an open bug and proposed fix for this.12:39
mdboothefried: Yeah, we discussed it earlier.12:39
efriedmdbooth: Okay, upon rereading I figured that's not what you were getting at :)12:40
mdboothBut even knowing the bug, I'm still surprised by the behaviour in practise.12:40
efriedmdbooth: You mean that there's some apparent predictability to the unpredictability of the hash ordering?12:40
mdboothI mean, I'd expect potentially different ordering if we were creating objects in a different order, or running things in a different order, or doing *anything* different.12:41
mdboothBut in 2 consecutive absolutely identical test runs I'm surprised to see a difference in behaviour unless we're intentionally perturbing it somehow.12:41
gibimdbooth: try the same PYTHONHASHSEED12:41
mago_jaypipes, efried thank you very much for the explanations.12:41
gibimdbooth: I think if PYTHONHASHSEED=0 then you will get the same order every time12:43
gibimdbooth: but by default PYTHONHASHSEED=random12:43
mdboothgibi: PYTHONHASHSEED=1 ./.tox/lower-constraints/bin/python -m testtools.run nova.tests.unit.virt.libvirt.test_driver.LibvirtConnTestCase.test_pre_live_migration_volume_backed_encrypted12:44
mdboothStill inconsistent12:44
mdboothMeh, I was just curious12:44
mdboothThis doesn't actually matter in the slightest :)12:44
*** shaohe_feng has quit IRC12:45
*** shaohe_feng has joined #openstack-nova12:45
*** sidx64 has quit IRC12:45
jaypipesmago_: np. sorry to not have great news!12:46
*** mdnadeem has quit IRC12:47
*** amoralej|lunch is now known as amoralej12:49
*** danny is now known as dabukaam12:49
*** dabukaam is now known as dabukalam12:50
*** dabukalam has quit IRC12:50
*** dabukalam has joined #openstack-nova12:50
*** andreas_s has quit IRC12:53
openstackgerritSurya Seetharaman proposed openstack/nova master: [WIP/POC] Updating queued_for_delete from instance_destroy()  https://review.openstack.org/56681312:53
jangutterjaypipes: for SR-IOV VF's there's a rough a proxy: Neutron Ports can under quota.... but it's very very very leaky at best.12:53
*** sidx64 has joined #openstack-nova12:54
jangutterjaypipes: very difficult to see how that model would translate to GPU, though.12:54
*** andreas_s has joined #openstack-nova12:54
*** shaohe_feng has quit IRC12:55
efriedcdent, jaypipes: +A on https://review.openstack.org/#/c/543262/ -- great stuff.12:57
efriedjohnthetubaguy: FYI ^12:58
*** shaohe_feng has joined #openstack-nova12:58
*** mriedem has joined #openstack-nova12:59
*** andreas_s_ has joined #openstack-nova13:00
*** andreas_s has quit IRC13:00
*** andreas_s_ has quit IRC13:00
*** andreas_s has joined #openstack-nova13:01
cdentefried: On self.compute thing, it's been long enoug since I made that change that I can't remember the details :(13:03
efriedno worries; gate-bound in any case.  If it passes zuul, it's good enough for me.13:03
*** mdnadeem has joined #openstack-nova13:04
efriedcdent: But as I'm sure you're aware, mock.patch.object(actual object, 'method') is not quite the same thing as mock.patch.object(path to lib containing method, 'method')13:04
efriedcdent: But in this case I think both things were actually pointing to the lib ultimately.13:04
efriedso in this case I think it *was* the same.13:04
cdentyes, that's why it ended up as it did, because the indirection of self.compute was meaningless13:05
*** alexchadin has quit IRC13:05
*** mgoddard has joined #openstack-nova13:05
*** shaohe_feng has quit IRC13:05
*** eharney has joined #openstack-nova13:05
*** shaohe_feng has joined #openstack-nova13:06
*** sidx64 has quit IRC13:06
*** zhangbailin_ has quit IRC13:08
*** andreas_s has quit IRC13:09
*** sidx64 has joined #openstack-nova13:11
*** ispp has quit IRC13:11
openstackgerritMerged openstack/os-vif master: add noop plugin  https://review.openstack.org/56792413:12
tssuryamriedem, dansmith: do you have some time now or shall I ping you back later ?13:13
mriedemi'm here13:14
*** andreas_s has joined #openstack-nova13:15
tssuryamriedem: so is it documented somewhere that when a user does nova list --deleted, it silently ignores this13:15
tssuryawithout complaining about policy ?13:15
*** shaohe_feng has quit IRC13:16
mriedemfor non-admins?13:16
mriedemi'm not aware of something saying it's not an error for non-admins13:16
mriedemhttps://docs.openstack.org/python-novaclient/latest/cli/nova.html#nova-list says (admin only)13:16
tssuryahmm okay then I will open a bug13:17
mriedembug for what?13:17
tssuryabecause currently if you do nova list --deleted as a non-admin13:17
tssuryait just ignores the filter13:17
tssuryaand gives you all the active instances13:17
mriedemit's been that way forever13:17
mriedemchanging that would likely be a non-trivial backward incompatible behavior change in the api13:18
*** shaohe_feng has joined #openstack-nova13:18
tssuryaoh so why do the rest of the admin only filters give policy errors13:18
mriedemsee remove_invalid_options()13:18
*** janki has joined #openstack-nova13:18
mriedemwhich filters for example?13:18
mriedemalso, you should probably include alex_xu and/or gmann in this discussion13:19
tssurya--user or --all-tenants etcc13:19
tssuryaI mean all those filters which say (admin only)13:19
tssuryashouldn't they all behave in the same way ?13:19
mriedemi see13:19
mriedemmsg = _("Only administrators may list deleted instances")13:20
mriedem                raise exc.HTTPForbidden(explanation=msg)13:20
mriedembut looks like that's only if you're filtering on vm_state='deleted'13:20
openstackgerritMerged openstack/nova master: Remove duplicate parameter in API sample documents  https://review.openstack.org/58120313:20
tssuryadoing --status DELETED is caught correctly13:20
* alex_xu is looking the chat log13:20
tssuryathanks alex_xu13:21
*** burt1 is now known as burt13:21
mriedemtssurya: it's also possible today to just pass random query params w/o an error13:21
mriedemGET /servers?foo=bar13:21
mriedemfor backward compatibility reasons13:21
tssuryamriedem: ah okay13:22
mriedemif we made the query parameter whitelist a true whitelist and failure for unknown parameters, that would be a microversion13:22
tssuryamriedem: hmm, yea I don't know if it needs to change, I noticed this when I was playing around with policy/filters13:23
alex_xuthe API behaviour is ignoring any invalid parameters13:23
*** ispp has joined #openstack-nova13:23
*** andreas_s has quit IRC13:24
openstackgerritMatthew Booth proposed openstack/nova master: Avoid redundant initialize_connection on source post live migration  https://review.openstack.org/55130213:24
openstackgerritMatthew Booth proposed openstack/nova master: Restore connection_info after live migration rollback  https://review.openstack.org/55134913:24
openstackgerritSilvan Kaiser proposed openstack/nova master: Exec systemd-run with privileges in Quobyte driver  https://review.openstack.org/55419513:26
*** shaohe_feng has quit IRC13:26
mriedemalso, for example, 2.26 adds the *tags* query params but they are only effective if using >= 2.26, if you pass tags=1,2 with 2.1, they are just ignored13:27
tssuryaalex_xu, mriedem: thanks for the pointer to the code/confirmation! it was just strange that nova list --deleted and nova list --status DELETED behaved differently.13:27
mriedembecause 'additionalProperties': True,13:27
*** shaohe_feng has joined #openstack-nova13:27
mriedemit also looks like if you pass deleted=cookies it will accept that and default deleted=False13:28
tssuryaheh yea13:29
mriedemwhy we treat --status DELETED and --deleted differently, idk13:30
mriedemlooks like that was pre-microversions13:30
tssuryayea , well is this documented somewhere outside the code ?13:30
*** rodolof has quit IRC13:31
tssurya(I couldn't find it)13:31
mriedemtssurya: i'm not aware of something about this being documented off the top of my head - i'd check the compute API guide since that's where i'd expect something like this to exist, if at all13:31
alex_xutssurya: mriedem in the before, we have a proposal to change the all_tenants policy https://review.openstack.org/#/c/527019/3/specs/ocata/implemented/add-whitelist-for-server-list-filter-sort-parameters.rst@6813:31
alex_xubut we didn't implement it13:31
openstackgerritSilvan Kaiser proposed openstack/nova master: Exec systemd-run with privileges in Quobyte driver  https://review.openstack.org/55419513:31
*** rodolof has joined #openstack-nova13:32
*** psachin has quit IRC13:32
tssuryamriedem, alex_xu: ack13:32
*** tssurya_ has joined #openstack-nova13:34
*** shaohe_feng has quit IRC13:36
mriedemhttps://review.openstack.org/#/c/11469/ added the ability to do nova list --status DELETED13:37
mriedemand fails for non-admins13:37
*** dabukalam has left #openstack-nova13:37
mriedemwhich is so long ago there would have been no consideration of consistency with failing a non-admin passing deleted=True13:38
*** shaohe_feng has joined #openstack-nova13:38
mriedemit feels like changing that now to fail for non-admins would require a microversion but i could see the argument both ways13:39
mriedemthere is something to be said for explicit api behavior, i.e. if i'm a non-admin doing nova list --deleted and not getting back deleted instances, i might not realize i'm using the wrong rc file and think it's a bug13:39
mriedemi'm sure we have crap like this all over the api13:40
mriedemthere are lots of "make this strict in a new microversion" notes in lots of that code13:40
mriedemfor example, lots of the schema validation that has additionalProperties: true13:40
*** hongbin has joined #openstack-nova13:40
mriedemand fixing error response codes13:40
mriedemif someone had the energy and care to wrangle a lot of those things into a spec we could fix them in a single microversion13:41
mriedemvalidation just gets hard when you have 80 *known* query params and some of those have behavior characteristics depending on microversion and/or what other parameters are passed13:42
tssurya_Hmm okay so for now I just ignore this or should I open a bug / should we resurrect the whitelist spec next cycle ?13:42
mriedemif you care to document it, that would be something13:43
* alex_xu still remember the nightmare of creating a schema for query parameters13:43
tssurya_Ack I will put some doc patch then13:43
mriedem"Other options will be ignored by nova silently."13:43
mriedemthat first bullet basically says what you're hitting13:44
mriedem"For general user, there is limited set of attributes of the servers can be used as query option. reservation_id, name, status, image, flavor, ip, changes-since, ip6, tags, tags-any, not-tags, not-tags-any are supported options to be used. Other options will be ignored by nova silently."13:44
openstackgerritsahid proposed openstack/nova master: hardware: fix hugepages memory usage per intances  https://review.openstack.org/58065713:44
openstackgerritsahid proposed openstack/nova master: hardware: fix memory check usage for small/large pages  https://review.openstack.org/53216813:44
openstackgerritsahid proposed openstack/nova master: hardware: remove duplicate memory check  https://review.openstack.org/58136513:44
*** itlinux has joined #openstack-nova13:44
*** Luzi has quit IRC13:45
mriedemalex_xu: do you know why we have all_tenants in _get_server_search_options and then we just check a policy if you specify it and fail with a 403 if you're not an admin?13:45
*** ttsiouts has quit IRC13:46
*** shaohe_feng has quit IRC13:46
alex_xumriedem: I don't know why, probably just a feature people want to control the visibility of all_tenant by the policy in the before13:46
mriedemthat's one way we could handle filtering on deleted - add a policy rule which defaults to rule:admin_api13:47
*** shaohe_feng has joined #openstack-nova13:47
*** lpetrut_ has joined #openstack-nova13:47
openstackgerritsahid proposed openstack/nova master: hardware: fix hugepages memory usage per intances  https://review.openstack.org/58065713:48
openstackgerritsahid proposed openstack/nova master: hardware: remove duplicate memory check  https://review.openstack.org/58136513:48
openstackgerritsahid proposed openstack/nova master: hardware: fix memory check usage for small/large pages  https://review.openstack.org/53216813:48
alex_xuyou mean the status=deleted?13:48
mriedemwell, that and deleted=True13:48
mriedemwe're inconsistent today,13:48
mriedemfor a non-admin, if i do 'nova list --deleted' it's ignored13:48
mriedembut if i do 'nova list --status DELETED' i get a 40313:48
mriedembut it's essentially the same filter13:49
mriedemthis is all the api guide says about the deleted filter: "deleted returns (or excludes) deleted servers"13:50
*** ratailor has quit IRC13:50
mriedemso we could expand on that if we wanted to include a note about the difference in behavior between --status DELETED and --deleted13:50
*** lpetrut has quit IRC13:50
mriedemand that it's admin-only either way13:50
efriedstephenfin: Then should the non-systemd mount be run under privsep too?13:50
mriedemtssurya: so if you're going to update the api guide, that's what i'd update13:51
*** awaugama has joined #openstack-nova13:51
alex_xumriedem: nova list --deleted consistent with the query parameter behaviour. nova list --status DELETED consistent with the behavour of valid value of query parameter.13:52
tssurya_mriedem: okay,13:53
mriedemalex_xu: i'm not sure i get your point13:53
alex_xumriedem: we also return 400 if you fill invalid date format for --change-sinces, we won't ignore that invalid value13:53
stephenfinefried: Based on silvans comments, the umount is more generic and therefore needs the additional permissions13:53
stephenfinThis is where I'd normally have lyarwood weigh in but I think he's not around this week13:54
mriedemalex_xu: i mean this https://github.com/openstack/nova/blob/b67a9a111ab0cf68084f62017a74f9a41377244f/nova/api/openstack/compute/servers.py#L19413:54
*** ttsiouts has joined #openstack-nova13:54
mriedemfor nova list --status DELETED13:54
stephenfinMaybe mdbooth would have an opinion though? ^13:54
stephenfinmdbooth: RE: efried's second comment here https://review.openstack.org/#/c/554195/14/nova/privsep/libvirt.py Any ideas?13:54
alex_xumriedem: yes, DELETED is invalid value for status parameter for non-admin13:54
tssuryamriedem: alex_xu :wouldn't the right way to deal with --deleted actually be to add the default rule:is_admin so that it behaves sanely ?13:54
tssuryalike mriedem said above13:55
mdboothstephenfin: Reading...13:55
alex_xumriedem: it is same with the other parameters. If you put an invalid date format in changes-since parameter you will get a 400 also13:55
mriedembut deleted=cookies is ok13:55
mriedemi found the change that added that too, and it was a compromise on existing behavior13:56
*** med_ has quit IRC13:56
alex_xumriedem: we didn't ignore deleted=cookikes, I guess, it is just map to a bool13:56
mriedemit defaults to False if it's an invalid bool13:56
*** shaohe_feng has quit IRC13:57
mriedemthere was a young alex_xu fighting the good fight on that too https://review.openstack.org/#/c/173296/2/nova/api/openstack/compute/plugins/v3/servers.py13:58
alex_xuin my childhood13:58
mriedemlooks like the TODO from that review was never added13:59
mriedemwe could start an etherpad to track various gross little api issues like this if we wanted to tackle those in a single microversion in stein13:59
*** shaohe_feng has joined #openstack-nova14:00
*** ttsiouts has quit IRC14:00
* alex_xu still remember how many microversion bump to finish the deprecation.....14:01
*** dklyle has quit IRC14:01
*** dklyle has joined #openstack-nova14:01
openstackgerritsahid proposed openstack/nova master: hardware: fix hugepages memory usage per intances  https://review.openstack.org/58065714:02
openstackgerritsahid proposed openstack/nova master: hardware: remove duplicate memory check  https://review.openstack.org/58136514:02
openstackgerritsahid proposed openstack/nova master: hardware: fix memory check usage for small/large pages  https://review.openstack.org/53216814:02
*** sidx64 has quit IRC14:02
*** itlinux has quit IRC14:04
*** sidx64 has joined #openstack-nova14:05
*** yikun has quit IRC14:06
*** shaohe_feng has quit IRC14:07
*** sidx64 has quit IRC14:07
*** shaohe_feng has joined #openstack-nova14:08
*** mlavalle has joined #openstack-nova14:09
*** ttsiouts has joined #openstack-nova14:09
*** felipemonteiro has joined #openstack-nova14:09
*** sidx64 has joined #openstack-nova14:10
*** sidx64 has quit IRC14:10
*** QG has joined #openstack-nova14:10
tssuryamriedem, dansmith: another question I had was regarding https://review.openstack.org/#/c/557369/5/specs/rocky/approved/handling-down-cell.rst@74 , for updating queued_for_delete, since I can't do upcalls, can I just go ahead and  mark this in the compute API before it is casted, even if the deletion fails ? and we document this specifically since its only "queued" for deletion ?14:10
tssurya(although it doesn't seem very right/ its kind of stale)14:10
mriedemtssurya: i commented on that specific issue in one of my earlier reviews14:11
mriedemyes we have to set the flag in the api before casting to compute to do the soft_delete14:11
tssuryawhich is what I am pointing at :)14:11
*** felipemonteiro_ has joined #openstack-nova14:11
mdboothstephenfin efried: What are you asking specifically?14:11
*** ispp has quit IRC14:11
dansmithtssurya: mriedem right, and only look at that if the cell is down, otherwise honor what is in the cell db right?14:11
stephenfinmdbooth: Why it's necessary to get root privileges to unmount volumes yet not to mount14:12
mdboothstephenfin: That doesn't look like a robust way to determine if systemd is functional to me.14:12
mdboothstephenfin: I assume that's because quobyte is weird?14:12
mriedemdansmith: this is setting queued_for_delete=True when the cell is up14:12
mriedemwhich you have to do in the api before casting to compute14:12
dansmithmriedem: *setting* for sure, but then you don't *look* at it unless the cell is down and have to decide whether or not to show the shell instance yeah?14:12
mdboothstephenfin: Not being facetious, btw. A quobyte driver seems like the right place to hide that sort of stuff.14:13
mriedemand there are 3 places that can happen (1) normal delete (Cast to compute), (2) local delete (compute is down), and (3) soft delete14:13
tssuryadansmith: at the time of deletion14:13
*** sidx64 has joined #openstack-nova14:13
stephenfinmdbooth: Neither do I, but I guess that's a separate issue and someone will eventually report it if not14:13
dansmithtssurya: I know, at time of deletion, you have to set it in the api when they first request it14:13
mdboothstephenfin: I couldn't work out from the bug report what the actual problem was.14:13
tssuryadansmith: right we will not look at this unless a cell is down14:13
tssuryagot it14:13
dansmithtssurya: mriedem: right, I'm just trying to explain, that's why we set it presumptively, because even though the delete hasn't happened, we only use this as a backup, so the fact that it might be a little aggressive (set before the delete happens), it's only for the emergency cas14:14
dansmithand why we _can_ set it that way, because it won't affect normal get/list calls14:14
*** mdnadeem has quit IRC14:15
*** felipemonteiro has quit IRC14:15
stephenfinmdbooth: Yeah, I was working on the same assumption but I was curious if there was something I was missing14:15
tssuryadansmith: absolutely, thanks for confirming14:15
tssuryathanks mriedem14:15
*** andreas_s has joined #openstack-nova14:15
mdboothstephenfin: Although... it could be that root isn't required.14:16
mdboothstephenfin: kaisers blames it on the (nova) volume rather than quobyte14:16
stephenfinmdbooth: I think it's systemd itself at fault here https://github.com/systemd/systemd/issues/338814:17
QGHello everyone, I have some question about tags/properties, do you know a way for an operator to let the customer set some specific tags/properties on server but not delete them ?14:17
*** shaohe_feng has quit IRC14:17
*** med_ has joined #openstack-nova14:17
*** ispp has joined #openstack-nova14:17
*** tssurya_ has quit IRC14:18
*** shaohe_feng has joined #openstack-nova14:19
mriedemQG: yes it looks like there are specific policy rules for tags14:21
mriedemsee https://docs.openstack.org/nova/latest/configuration/policy.html14:21
*** moshele has quit IRC14:23
*** antosh has joined #openstack-nova14:23
*** hamzy has joined #openstack-nova14:24
QGmriedem: Thanks and is there any way to filter on specific tags / properties that start with a string of caraters?14:25
openstackgerritKonstantinos Samaras-Tsakiris proposed openstack/nova master: Hide hypervisor id on windows guests  https://review.openstack.org/57989714:25
*** Bhujay has quit IRC14:26
stephenfinmdbooth: I've left comments against the bug. If this is resolved in new version of systemd, we should probably just wait on that rather than unnecessarily seeking root privileges14:26
mdboothstephenfin: Yeah, that's where I was going to go with that.14:26
stephenfinmdbooth: Cool. Thanks for the input :)14:26
mdboothIt seems we're adding code to Nova to replicate a function of systemd.14:26
mriedemQG: no, tags are free-form defined by the user14:27
*** shaohe_feng has quit IRC14:27
*** tidwellr has joined #openstack-nova14:28
*** shaohe_feng has joined #openstack-nova14:29
QGmriedem: Ok thanks14:29
gibimriedem: I have bad news about https://bugs.launchpad.net/nova/+bug/177043414:30
openstackLaunchpad bug 1770434 in OpenStack Compute (nova) "affinity filter not work on master branch" [High,Confirmed]14:30
gibimriedem: it is really broken14:30
gibimriedem: I had to change the existing tempest test to reproduce it but it is now failing http://logs.openstack.org/49/581349/1/check/tempest-multinode-full/0ac326a/testr_results.html.gz14:31
*** spotz_ is now known as spotz14:31
gibimriedem: so far I only found that querying the instances that are members of the group returns an empty list https://github.com/openstack/nova/blob/c0350da4a1607d7aa113caceaefb5d29303c7eed/nova/objects/instance_group.py#L42214:33
*** shaohe_feng has quit IRC14:38
*** shaohe_feng has joined #openstack-nova14:38
openstackgerritMerged openstack/osc-placement master: Fix the 1.6 release note format  https://review.openstack.org/57904214:38
openstackgerritMerged openstack/nova master: make incomplete_consumer_project_id a valid UUID  https://review.openstack.org/58035814:39
openstackgerritEric Fried proposed openstack/nova master: Update root providers in same tree  https://review.openstack.org/58024614:39
openstackgerritMerged openstack/osc-placement master: Remove doc/build during tox -e docs  https://review.openstack.org/57904114:40
openstackgerritMerged openstack/osc-placement master: Fix docstring for delete allocation method  https://review.openstack.org/57707514:40
mriedemgibi: probably want to ask melwitt if that's related to the bug she's already working on14:41
gibimriedem: to gather the hosts of the members of an instance group we would need to read instances from every cell where are member instances14:41
gibimriedem: thanks, seems related14:41
*** EmilienM is now known as EvilienM14:42
*** quiquell is now known as quiquell|off14:43
*** beagles has joined #openstack-nova14:44
*** quiquell|off is now known as quiquell14:45
*** peereb has quit IRC14:45
*** ispp has quit IRC14:45
*** quiquell is now known as quiquell|off14:46
mnaserthanks to whoeve decided to strip out all the extra crazy quotas out of the api14:46
mnaserthings are so much cleaner now.14:46
*** quiquell|off is now known as quiquell14:47
*** shaohe_feng has quit IRC14:48
*** quiquell is now known as quiquell|off14:48
*** shaohe_feng has joined #openstack-nova14:49
mriedemmnaser: docs or microversion?14:49
mnasermicroversion i tihnk, nova quota-show shows a lot less things now14:50
mriedemthe networking and file injection ones are still there unless you're using nova CLI which defaults to latest available microversion in the server so you won't see those14:50
mnasernice on the eyes.14:50
mriedemthat's what they said about me in the Mr Minnesota Pageant14:51
*** tssurya_ has joined #openstack-nova14:51
mnaseri wouldnt disagree14:52
*** tssurya_ has quit IRC14:53
kashyapmriedem: I only get hits for "Mr & Ms Natural Minnesota" peasants.  /me wonders about the 'natural' word there...14:54
*** ispp has joined #openstack-nova14:54
*** abhishekk has joined #openstack-nova14:56
*** ragiman has quit IRC14:56
openstackgerritEric Fried proposed openstack/nova master: Use nova.db.api directly  https://review.openstack.org/54326214:56
mriedemin case it's not clear, mr minnesota is not a real thing, nor was i a contestant14:58
*** shaohe_feng has quit IRC14:58
mriedembut a guy can dream...14:58
*** shaohe_feng has joined #openstack-nova15:00
* dansmith stops his google image search15:00
gibimelwitt: Can I help somehow with https://review.openstack.org/#/c/540258 ?15:00
*** udesale has joined #openstack-nova15:01
*** lpetrut_ has quit IRC15:05
*** ccamacho has quit IRC15:05
*** ccamacho has joined #openstack-nova15:06
*** shaohe_feng has quit IRC15:08
*** shaohe_feng has joined #openstack-nova15:09
*** armaan has quit IRC15:10
*** QG has quit IRC15:10
*** armaan has joined #openstack-nova15:10
*** armaan has quit IRC15:11
*** armaan has joined #openstack-nova15:11
*** armaan has joined #openstack-nova15:12
*** armaan has quit IRC15:16
kashyapmriedem: Hehe, I know it's not a _real_ thing!  Was just teasing :P15:17
*** shaohe_feng has quit IRC15:19
*** shaohe_feng has joined #openstack-nova15:19
*** ttsiouts has quit IRC15:20
openstackgerritArtom Lifshitz proposed openstack/nova stable/queens: Refactor _build_device_metadata  https://review.openstack.org/58139815:21
openstackgerritArtom Lifshitz proposed openstack/nova stable/queens: Consider hostdev devices when building metadata  https://review.openstack.org/58139915:21
*** rodolof has quit IRC15:22
mriedemgibi: until we're using placement for affinity scheduling, i don't think we can ever do https://review.openstack.org/#/c/581349/ in tempest15:23
mriedemit will always be racy - which is why we have the late affinity check in the compute (which is disabled in default devstack b/c we can't upcall to the api db)15:23
gibimriedem: that test does not intended to show a race condition15:24
gibimriedem: I can add sleep between the server create requests and it will still fail15:24
mriedemsure, but when the bug is fixed and we're properly pulling group members, it would start to race15:25
mriedemi'd been meaning to write a functional test for https://review.openstack.org/#/c/540258 but need to look at my notes - it's been awhile15:26
*** ccamacho has quit IRC15:26
*** links has quit IRC15:26
mriedemoh i guess i was going to write a new bug for something that came up during review:15:26
mriedem"We need a new bug and test for the multi-cell affinity scenario  where two instances are scheduled at the same time in the same affinity  group. We need 2 cells with 1 host each, with exactly enough capacity to  fit just one instance so that placement will fail the first request and  throw it into the other host in the other cell. The late affinity check  in the compute won't fail because it can't see the other member in the15:26
mriedemher cell, so it will think it's fine."15:26
mriedemthe tricky part there is our functional tests are able to make up-calls from nova-compute15:27
mriedemwe don't have a split mq in our tests15:27
mriedemnot sure how easy that would be to do15:27
mriedemdansmith: ^ ?15:27
*** ttsiouts has joined #openstack-nova15:27
mriedemwell, maybe won't need split mq - just the instances being in different hosts in different cell dbs might do it15:28
dansmithwith the workaround flag you can disable the check right?15:28
*** yamamoto has quit IRC15:29
*** shaohe_feng has quit IRC15:29
dansmithalthough I guess that doesn't really do much,15:29
gibimriedem: do I understand correclty that on master server groups only work if the late check using upcall is enabled?15:29
dansmithobviously if you disable that check it's not going to check15:30
mriedemmaybe that type of request wouldn't get past scheduling15:30
openstackgerritMatthew Booth proposed openstack/nova master: Remove irrelevant comment  https://review.openstack.org/57882115:30
openstackgerritMatthew Booth proposed openstack/nova master: Move static _get_power_off_values to compute_utils  https://review.openstack.org/57882215:30
*** shaohe_feng has joined #openstack-nova15:30
mriedemgibi: i don't think so...15:30
mriedemtempest has an anti-affinity test15:30
*** Bhujay has joined #openstack-nova15:30
dansmithmriedem: so, scheduler will look at group.members, get the instance.host for each, and affine to those hosts, right?15:30
gibimriedem: that is the test I changed to show that master is broken15:30
*** yamamoto has joined #openstack-nova15:31
mriedemgibi: test_create_server_with_scheduler_hint_group_anti_affinity15:31
dansmithwhich is lossy because those instances might be pre-scheduling15:31
dansmithor rather, pre-build15:31
openstackgerritChen proposed openstack/nova master: WIP  https://review.openstack.org/58140315:31
*** tidwellr has quit IRC15:31
gibimriedem: that tempest test only works because it sends two server create in the same API request15:32
mriedemright, because servers in separate requests is a known race15:32
*** ttsiouts has quit IRC15:32
gibimriedem: if you wait 10 minutes between the two requests it still doesnt work15:32
gibimriedem: I tried :)15:32
dansmithgibi: really? why is that?15:32
dansmiththe filter is using a potentially stale version of server group, from the beginning of the request, I just noticed15:33
mriedemyeah the HostState.instances dict should be populated per request15:33
dansmiththat shouldn't be a problem 10 minutes later though15:33
gibidansmith: this returns an empty list for the second scheduling https://github.com/openstack/nova/blob/c0350da4a1607d7aa113caceaefb5d29303c7eed/nova/objects/instance_group.py#L42215:33
mdboothJust working on this patch: https://review.openstack.org/#/c/578846/ I called it out in the commit message: the cut/paste in there is horrible, but avoids a refactor. Am I going to get that landed as is, or do I need to look at refactoring the driver interface?15:33
*** tidwellr has joined #openstack-nova15:33
mriedemgibi: and i think that's the bug melwitt is fixing15:34
dansmithgibi: oh on multi-cell?15:34
dansmiththat needs to stripe15:34
*** yamamoto has quit IRC15:34
gibidon't we deploy with multi cell _by default_ ?15:34
mdboothIt goes without saying that I don't mind refactoring :) However, I'd also like to both land and backport the code.15:34
mriedemgibi: in devstack yes15:34
dansmithgibi: yeah, this would hit cell0 if your default is cell0, and always be empty15:34
mriedemit's not really 'multi cell' so much as superconductor mode in devstack and how the services are configured15:35
gibilet me rephrase. I our suggested deployment mode (cell_v2) the server group policies are broken15:35
gibithat is my understanding15:35
dansmithgibi: because your default connection is to cell0, which will never return the list of instances, yeah15:35
*** felipemonteiro_ has quit IRC15:35
*** lpetrut_ has joined #openstack-nova15:36
gibidansmith: thanks, that explains what I see15:36
*** mago_ has quit IRC15:36
dansmithbut striping across cells is what needs to happen, which is that bug afaik15:36
*** priteau has quit IRC15:36
gibidansmith: yeah. this is why offered my help to melwitt above on the fix15:36
dansmithgibi: are we in violent agreement? :)15:36
gibidansmith: yes15:37
* dansmith stabs gibi with his agreement knife15:37
gibiI was not sure we are on the same page about the size of the problem. server groups are useless now15:37
*** rodolof has joined #openstack-nova15:37
* gibi silently bleeds15:38
dansmithgibi: if your controllers are pointing at your main cell by default it'll be fine, fwiw15:38
dansmithbut it definitely needs changing15:38
mriedemgibi: so, if you want to help, we need a functional test in-tree that recreates the regression15:38
mriedemthat's what i was -1 on the change for - the mock based unit tests had logic flaws in them15:39
*** shaohe_feng has quit IRC15:39
gibidansmith: how can a deployer change the default cell to cell1?15:39
gibimriedem: ack. I offered a tempest test :)15:40
dansmithgibi: [database]/connection :)15:40
gibidansmith: in the super conductor conductor conf?15:41
*** shaohe_feng has joined #openstack-nova15:41
dansmithgibi: in any controller config15:41
dansmithgibi: you don't have to be running a superconductor layout with only one non-cell0 cell15:41
*** chyka has joined #openstack-nova15:41
*** chyka has quit IRC15:41
mriedemgibi: yeah, but we can't use that tempest change long-term because of the otherwise known race issue15:41
*** chyka has joined #openstack-nova15:42
gibidansmith: I see15:42
gibidansmith: thanks15:42
*** rodolof has quit IRC15:42
gibimriedem: is it racy even if the test waits for the first server to go to ACTIVE state before start creating the second one?15:43
*** rodolof has joined #openstack-nova15:43
mriedemgibi: in that case maybe not15:43
mriedembecause per scheduling request, we should pull the set of instances per host15:43
mriedemthat's if the compute isn't sending it's instance info to the scheduler (which it's not in default devstack b/c we disable that ability)15:44
gibiOK, so the second scheduling will see the first instance sitting on the host15:45
mriedemwhich reminds me of https://review.openstack.org/#/c/569247/ but haven't had good large scale performance testing to see if that's justified15:45
mriedemgibi: it should yeah15:45
*** armaan has joined #openstack-nova15:46
gibimriedem: then I don't see how the currently proposed tempest test be racy15:46
*** chyka_ has joined #openstack-nova15:46
openstackgerritJay Pipes proposed openstack/nova master: update project/user for consumer in allocation  https://review.openstack.org/58113915:47
*** chyka has quit IRC15:48
mriedemgibi: ok updated comments15:49
*** yamahata has joined #openstack-nova15:49
*** shaohe_feng has quit IRC15:49
gibimriedem: ack, I can cover both single and multi request cases in tempest15:50
*** shaohe_feng has joined #openstack-nova15:50
*** jmlowe_ has quit IRC15:50
gibimriedem: if we have the tempest do you still require the functional test in melwitt's patch?15:50
*** andreas_s has quit IRC15:51
mriedemmaybe not15:51
mriedemdoes your tempest test also cover affinity?15:52
*** andreas_s has joined #openstack-nova15:52
mriedemlooks like it doesn't for separate requests15:52
gibimriedem: both the affinity and the anti-affinity case fails now15:52
*** rmart04 has quit IRC15:52
gibimriedem: both uses the same helper to create the servers15:53
*** ttsiouts has joined #openstack-nova15:53
gibimriedem: but in case of affinity we might want to fill the compute to see NoValid host15:53
mriedemthat's what i was going to try with a functional test15:54
mriedemto set available vcpu inventory to 1 or something15:54
gibimriedem: sure we have plenty of such functional tests already but they are not cell aware and passing15:54
gibimriedem: https://github.com/openstack/nova/blob/master/nova/tests/functional/test_server_group.py15:55
openstackgerritMatt Riedemann proposed openstack/nova master: Document differences and similaries between extra specs and hints  https://review.openstack.org/58141015:55
mriedemright, i plan on writing a multi-cell affinity regression functional test15:55
*** gyee has joined #openstack-nova15:55
gibimriedem: https://github.com/openstack/nova/blob/master/nova/tests/functional/test_server_group.py#L29215:56
*** andreas_s has quit IRC15:56
gibimriedem: ohh there is one case where functional is needed. multiple non-cell0 cells case15:57
gibimriedem: as in tempest we have only cell0 and cell115:57
mriedemyes, that's what i've been saying :)15:58
*** antosh has quit IRC15:58
mriedemwhen i say 'multi-cell' i mean multiple non-cell0 cells15:58
gibimriedem: now I understand ;)15:58
mriedemi don't consider cell0 a 'real' cell since it doesn't contain compute hosts15:58
*** shaohe_feng has quit IRC16:00
*** Guest88425 has quit IRC16:00
gibimriedem: OK, I will extend the tempest test tomorrow. Thanks for the explanation16:00
*** shaohe_feng has joined #openstack-nova16:01
*** antosh has joined #openstack-nova16:01
*** wwriverr_ has joined #openstack-nova16:02
*** ircuser-1 has joined #openstack-nova16:02
*** wwriverr_ has quit IRC16:02
*** wwriverr_ has joined #openstack-nova16:03
*** wwriverrat has quit IRC16:05
openstackgerritEric Fried proposed openstack/nova master: update project/user for consumer in allocation  https://review.openstack.org/58113916:05
*** sidx64 has quit IRC16:06
openstackgerritkarim proposed openstack/nova master: Handle rebuild of instances with image traits  https://review.openstack.org/56949816:06
*** jmlowe has joined #openstack-nova16:08
*** jmlowe has quit IRC16:09
*** shaohe_feng has quit IRC16:10
*** janki has quit IRC16:11
*** shaohe_feng has joined #openstack-nova16:11
*** ispp has quit IRC16:13
mriedemdansmith: i found another candidate for your long_rpc_timeout https://bugs.launchpad.net/cinder/+bug/173948216:13
openstackLaunchpad bug 1739482 in Cinder "test_snapshot_backup fails to build backup due to MessagingTimeout" [Medium,Confirmed]16:13
dansmithmriedem: that's on the cinder side though yeah?16:14
mriedembut i'd do the exact same thing there16:14
mriedemala oslo.incubator style16:14
*** udesale has quit IRC16:15
*** ttsiouts has quit IRC16:16
mriedemdansmith: so in https://review.openstack.org/#/c/563375/35/nova/objects/instance_group.py it seems weird that _rules is nullable but we default to {} if it's not set in the db16:19
*** lpetrut_ has quit IRC16:19
mriedemso i can create a group with rules=None but then what i'll get back is group.rules == {}16:19
dansmithmriedem: so, the reason I left it that way is because he had the first patch passing None from the api16:19
dansmithbut now that I think about it with a fresh head,16:20
dansmiththat can and maybe should just pass {} there16:20
*** shaohe_feng has quit IRC16:20
mriedemwhy {} over None?16:20
mriedemjust so callers don't hit NoneType on access?16:21
dansmithI tend to prefer things like dicts to be empty instead of None, just because it means you always have to check to see if the thing is none, then check to see if your thing is in the dict, and then check to see if the value is what you want16:21
dansmiththat's why I was asking for it to be {} on return, but we should be consistent either way16:21
mriedemso if we just pass in {} we can drop nullable=true16:22
*** shaohe_feng has joined #openstack-nova16:22
dansmithyeah i think that was the only place16:22
mriedemthere is one in the request spec as well16:22
dansmithI remember de-null-ing it but then flipping it back when the api test failed16:22
dansmithI'll pull it down and make that change and see what breaks16:22
*** sahid has quit IRC16:23
mriedemthis is the only thing (later in the series) i know of that will16:23
mriedembut that's an easy change16:24
* dansmith kicks off a test run16:24
*** antosh has quit IRC16:29
*** shaohe_feng has quit IRC16:30
*** antosh has joined #openstack-nova16:32
*** shaohe_feng has joined #openstack-nova16:32
*** yamamoto has joined #openstack-nova16:34
*** Bhujay has quit IRC16:38
*** yamamoto has quit IRC16:40
*** shaohe_feng has quit IRC16:41
*** shaohe_feng has joined #openstack-nova16:41
*** tssurya has quit IRC16:41
*** armaan has quit IRC16:42
*** armaan has joined #openstack-nova16:43
*** shaohe_feng has quit IRC16:51
*** shaohe_feng has joined #openstack-nova16:51
*** sambetts is now known as sambetts|afk16:53
*** abhishekk is now known as abhishekk|afk16:54
*** derekh has quit IRC16:57
*** yamahata has quit IRC17:00
*** shaohe_feng has quit IRC17:01
*** shaohe_feng has joined #openstack-nova17:03
*** imacdonn has quit IRC17:03
*** amoralej is now known as amoralej|off17:03
*** imacdonn has joined #openstack-nova17:03
*** mgoddard has quit IRC17:06
*** tesseract has quit IRC17:07
*** jmlowe has joined #openstack-nova17:09
*** mvk_ has quit IRC17:11
*** shaohe_feng has quit IRC17:11
dansmithmriedem: hmm, I didn't get a failure on that17:14
dansmither, wait,17:16
*** shaohe_feng has joined #openstack-nova17:16
dansmithmaybe that would manifest in the notification patch but not in the last one17:16
dansmithoh, that's what you linked to17:16
*** abhishekk|afk is now known as abhishekk17:18
dansmithno fail17:20
dansmithmaybe I'll push this up and you can look/comment17:20
openstackgerritDan Smith proposed openstack/nova master: Add policy to InstanceGroup object  https://review.openstack.org/56337517:20
openstackgerritDan Smith proposed openstack/nova master: Add policy field to ServerGroup notification object  https://review.openstack.org/56340117:20
openstackgerritDan Smith proposed openstack/nova master: Change the ServerGroupAntiAffinityFilter to adapt to new policy  https://review.openstack.org/57116617:20
openstackgerritDan Smith proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model  https://review.openstack.org/57146517:20
openstackgerritDan Smith proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group  https://review.openstack.org/56753417:20
*** shaohe_feng has quit IRC17:22
*** shaohe_feng has joined #openstack-nova17:22
mriedemdansmith: did you run just unit tests?17:26
mriedemthe notification sample will fail functional17:26
dansmithI ran functional, but maybe not on the actual notification patch, looking at my history17:27
openstackgerritMatt Riedemann proposed openstack/nova master: Heal allocations with incomplete consumer information  https://review.openstack.org/57448817:28
openstackgerritMatt Riedemann proposed openstack/nova master: Refactor _heal_instances_in_cell  https://review.openstack.org/57789617:28
openstackgerritMatt Riedemann proposed openstack/nova master: Use consumer generation in _heal_allocations_for_instance  https://review.openstack.org/57790517:28
dansmithmriedem: yeah, I did  and just re-ran with "notification" regex and all passed17:29
dansmithand it's running notification sample tests...17:29
dansmith(as an example)17:30
*** quiquell|off has quit IRC17:31
*** shaohe_feng has quit IRC17:32
mriedemoh i see why17:33
*** shaohe_feng has joined #openstack-nova17:33
mriedemthat should be removed or changed to {}17:33
dansmithsho nuf17:33
mriedemand then we can make the rules field on the payload object no longer nullable as well https://review.openstack.org/#/c/563401/26/nova/notifications/objects/server_group.py@6817:34
*** yamahata has joined #openstack-nova17:34
dansmithlemme write a test for that behavior17:35
mriedemyeah that group = objects.InstanceGroup(rules={}) && self.assertEqual({}, group.rules)17:36
*** sridharg has quit IRC17:36
*** felipemonteiro has joined #openstack-nova17:36
*** yamamoto has joined #openstack-nova17:37
*** yamamoto has quit IRC17:41
*** shaohe_feng has quit IRC17:42
openstackgerritDan Smith proposed openstack/nova master: Add policy to InstanceGroup object  https://review.openstack.org/56337517:42
openstackgerritDan Smith proposed openstack/nova master: Add policy field to ServerGroup notification object  https://review.openstack.org/56340117:42
openstackgerritDan Smith proposed openstack/nova master: Change the ServerGroupAntiAffinityFilter to adapt to new policy  https://review.openstack.org/57116617:42
openstackgerritDan Smith proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model  https://review.openstack.org/57146517:42
openstackgerritDan Smith proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group  https://review.openstack.org/56753417:42
dansmithokay here we go17:42
mriedempep8 brotha17:44
*** shaohe_feng has joined #openstack-nova17:44
dansmithcome on17:45
mriedemwant me to tag in?17:45
dansmithoh that's not my fault.. no I can just fix and push easy17:45
mriedemalso ^17:46
dansmithdo I need to re-run tests after snipping that out?17:48
dansmiththe nullable thing17:48
dansmithah maybe hash will change?17:48
melwittgibi, mriedem: my bug fix got stalled on the functional test. I wasn't able to recreate the bug in a functional test so far17:50
*** shaohe_feng has quit IRC17:52
openstackgerritDan Smith proposed openstack/nova master: Add policy to InstanceGroup object  https://review.openstack.org/56337517:53
openstackgerritDan Smith proposed openstack/nova master: Add policy field to ServerGroup notification object  https://review.openstack.org/56340117:53
openstackgerritDan Smith proposed openstack/nova master: Change the ServerGroupAntiAffinityFilter to adapt to new policy  https://review.openstack.org/57116617:53
openstackgerritDan Smith proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model  https://review.openstack.org/57146517:53
openstackgerritDan Smith proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group  https://review.openstack.org/56753417:53
*** shaohe_feng has joined #openstack-nova17:53
*** mriedem has quit IRC17:53
*** moshele has joined #openstack-nova17:55
*** mriedem1 has joined #openstack-nova17:57
*** mvk_ has joined #openstack-nova17:57
mriedem1i assume bauzas is in his futbol chamber18:00
*** mriedem1 is now known as mriedem18:00
*** shaohe_feng has quit IRC18:03
*** armaan has quit IRC18:03
*** armaan has joined #openstack-nova18:03
*** armaan has quit IRC18:03
*** armaan has joined #openstack-nova18:04
*** shaohe_feng has joined #openstack-nova18:04
*** antosh has quit IRC18:08
*** antosh has joined #openstack-nova18:09
mriedemdansmith: ok i'm +2 up that stack to the point of the rest api change, reviewing that during this game18:10
*** mgoddard has joined #openstack-nova18:10
dansmithmriedem: okay we might want to find someone else to do that policy one since it's like half mine now18:11
dansmithbut I'll hit the rest18:11
*** shaohe_feng has quit IRC18:13
dansmithmriedem: hmm, so I wonder if that notification one should have been squashed into the main servergrouppayload like the objects were?18:13
dansmithI was just mechanically updating it but hadn't really thought about it18:14
mriedemi thought about that yesterday18:14
mriedemand thought the separate payload isn't bad since it's the singular policy and the rules,18:14
mriedemwhich in the rest api you just get a singular policy and (eventually) rules18:14
mriedemso if we squashed,18:15
mriedemthe notification payload would have policies (deprecated list), policy and rules18:15
mriedemso the nested object for the payload seems ok to me18:15
dansmithso this mirrors more of what the api does?18:15
mriedemdoesn't matter to me much either way18:15
*** shaohe_feng has joined #openstack-nova18:15
mriedemthe api will be flat18:15
mriedemwell, sorry, it's not flat18:15
mriedemyes it mirrors the rest api18:16
mriedemwe don't have to model it that way in the notification or api of course18:17
mriedemcould all be flat18:17
mriedemgibi wanted both the old policies field and new policy payload in the notification for compat since notification consumers can't request a specific versoin of the notification payload18:18
mriedembut that's not the same in the rest api18:18
dansmithyeah, I dunno18:18
dansmithjust not sure I see the point of the nesting in either the api or the notification object18:18
dansmithit's not bad, it just seems unnecessary18:18
dansmithjust another object and hash to track18:18
dansmithanyway, if you want to just steam on I'll play along18:19
*** shaohe_feng has quit IRC18:23
*** shaohe_feng has joined #openstack-nova18:24
mriedemi'm ok with making them flat if we want18:26
mriedemthinking about stuff we nest in the rest api for servers, those are things like security groups, volumes, ports, etc - things that have their own resources in the api18:26
mriedemserver group policies wouldn't count like that since they aren't separate resources18:26
mriedemgibi is probably the only other person that would have an opinion and he's probably gone by now18:27
mriedemshould we just wait and ask yikun what he thinks? if he doesn't care, then we can flatify tomorrow18:28
dansmithif you're cool with that18:28
mriedemyeah i'm fine with it18:28
mriedemneed to review Kevin_Zheng's abort queued live migration stuff today anyway18:28
mriedemi'll drop my +2 on yikun's notification patch18:29
dansmithI'll comment18:30
openstackgerritEric Fried proposed openstack/nova master: Tighten up ReportClient use of generation  https://review.openstack.org/55666918:31
mriedemme too18:33
mriedemgibi: fyi ^18:33
*** shaohe_feng has quit IRC18:33
*** shaohe_feng has joined #openstack-nova18:34
*** tssurya has joined #openstack-nova18:36
*** gyee has quit IRC18:38
*** yamamoto has joined #openstack-nova18:39
*** eharney has quit IRC18:40
*** abhishekk has quit IRC18:41
*** shaohe_feng has quit IRC18:44
*** yamamoto has quit IRC18:44
*** shaohe_feng has joined #openstack-nova18:44
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Use ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa in tree  https://review.openstack.org/58144418:46
*** itlinux has joined #openstack-nova18:47
openstackgerritMatt Riedemann proposed openstack/nova stable/ocata: Use ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa in tree  https://review.openstack.org/58144518:48
melwittlooking for a +W on this ironic driver change needed to solve a race during instance creates https://review.openstack.org/56372218:53
*** eharney has joined #openstack-nova18:53
*** shaohe_feng has quit IRC18:54
efriedLooks like jaypipes, dansmith, and johnthetubaguy have reviewed ^ in the past, so I'll stay away for now.18:55
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: unquiesce instance after quiesce failure  https://review.openstack.org/58145118:56
*** mgoddard has quit IRC18:56
*** shaohe_feng has joined #openstack-nova18:57
openstackgerritEric Fried proposed openstack/nova master: Delete orphan nodes before updating resources  https://review.openstack.org/57992219:04
openstackgerritKen'ichi Ohmichi proposed openstack/nova master: Avoid BadRequest error log on volume attachment  https://review.openstack.org/58145319:04
*** shaohe_feng has quit IRC19:04
*** felipemonteiro_ has joined #openstack-nova19:04
*** itlinux has quit IRC19:05
*** shaohe_feng has joined #openstack-nova19:05
*** felipemonteiro has quit IRC19:08
openstackgerritEric Fried proposed openstack/nova master: Address nits from consumer generation  https://review.openstack.org/57722719:09
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: unquiesce instance after quiesce failure  https://review.openstack.org/58145419:09
mriedem7 days left to submit talks for berlin....19:11
melwittI just swapped the runways (a day late, apologies) https://etherpad.openstack.org/p/nova-runways-rocky if anyone would like to add log notes for the removed ones and if dansmith could please update the channel topic19:14
*** shaohe_feng has quit IRC19:14
*** lpetrut_ has joined #openstack-nova19:16
*** ChanServ sets mode: +o dansmith19:17
*** shaohe_feng has joined #openstack-nova19:17
dansmiththe first one doesn't have the blueprint slug in it19:18
* dansmith goes to look it up19:18
melwittargh, sorry19:18
*** dansmith changes topic to "Current runways: abort-live-migration-in-queued-status / add-zvm-driver-rocky / glance-image-traits -- This channel is for Nova development. For support of Nova deployments, please use #openstack."19:19
*** ChanServ sets mode: -o dansmith19:19
*** lpetrut_ has quit IRC19:20
melwittvdrok, jroll, TheJulia: is this patch needed for https://blueprints.launchpad.net/openstack/?searchtext=allow-reserved-equal-total-inventory ? it's in merge conflict https://review.openstack.org/56584119:21
*** med_ has quit IRC19:22
melwittlink correction https://blueprints.launchpad.net/nova/+spec/allow-reserved-equal-total-inventory19:22
*** pchavva has quit IRC19:23
*** rmart04 has joined #openstack-nova19:25
*** shaohe_feng has quit IRC19:25
*** shaohe_feng has joined #openstack-nova19:25
TheJuliamelwitt: I think jroll is the only person who can know for sure, it looks like it just ought to be abandoned based upon the discussion. I know jroll has been super busy as of recent.19:26
*** jmlowe has quit IRC19:27
melwittTheJulia: ack, thanks19:27
jrollmelwitt: I'll look post-meeting, been meaning to get back to that19:28
melwittjroll: thx19:28
jrollI'd say it's needed but not for that BP19:28
melwittjroll: thanks for confirming. I'll update https://etherpad.openstack.org/p/nova-rocky-blueprint-status to call out just the one patch as needing review19:31
melwitt(this one https://review.openstack.org/517921)19:31
*** yamamoto has joined #openstack-nova19:32
jrollthanks for checking on that :)19:34
*** shaohe_feng has quit IRC19:35
*** flwang1 has quit IRC19:36
*** shaohe_feng has joined #openstack-nova19:36
*** pchavva has joined #openstack-nova19:37
*** yamamoto has quit IRC19:37
*** rmart04 has quit IRC19:38
openstackgerritArtom Lifshitz proposed openstack/nova master: WIP: Nova objects for Libvirt NUMA config  https://review.openstack.org/58145619:40
*** bkopilov has quit IRC19:45
*** shaohe_feng has quit IRC19:45
melwittdoes anyone know what's the deal with vgpu work this cycle? is it blocked on reshaper work or is some of it okay to merge at the moment? https://review.openstack.org/#/q/topic:bp/vgpu-rocky+(status:open+OR+status:merged)19:46
*** shaohe_feng has joined #openstack-nova19:46
dansmiththe numa-ness is blocked on reshaper AFAIK19:47
dansmithwhich would be the NRP ones up there I guess, and some libvirt ones that don't appear to be in the list (and maybe aren't written yet)19:48
melwitthm, ok19:48
melwittefried: should we -W this one if we need to hold it behind reshaper? https://review.openstack.org/52031319:49
dansmithman that's a lot of rechecks19:50
efriedmelwitt: I had previously -2'd https://review.openstack.org/#/c/521041/ which is the patch that actually puts the code in the way of the compute manager.  But perhaps we want to move that -2 to the bottom as you say, since the first two patches don't do anything without the top one.19:51
*** jmlowe has joined #openstack-nova19:51
melwittefried: k. at a glance, it looked like things we could merge as progress so it would help to -W or -2 to show that it needs to wait19:52
*** bkopilov has joined #openstack-nova19:52
efriedmelwitt: Yes, we could merge the bottom two without hurting anything.19:52
*** itlinux has joined #openstack-nova19:53
efriedmelwitt: I think some people might object to merging what's essentially "dead code".19:53
efriedmelwitt: Me, I'd rather see it merged so we've got a shorter path when we're ready to pull the trigger.19:53
efriedBut no strong feelings either way.19:54
dansmithI think we should wait19:54
dansmithmerging refactors early in a set or something are useful, but if it's really dead code, we might as well wait, IMHO19:54
*** shaohe_feng has quit IRC19:55
melwittI don't have a strong feeling about it. I think it'd be okay to merge some progress but waiting is also fine19:55
*** shaohe_feng has joined #openstack-nova19:56
melwittmriedem: we have a proof-of-concept patch for the rbd erasure coding config option as of today, fyi https://review.openstack.org/58105519:56
*** moshele has quit IRC19:57
melwittjmlowe: is this something we can see working in the ceph job results? using the erasure coding? http://logs.openstack.org/55/581055/2/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/d6331b3/19:57
*** moshele has joined #openstack-nova19:58
jmloweyou're thinking functional test?19:58
melwittjmlowe: no, I mean I was wondering if there's anything ceph would log (in the ceph job I linked) that shows passing the data_pool did something. just curious if it's something we could see19:59
jmloweI don't think so, let me poke around a little more, you can check the data pool of a rbd device with the ceph api but it's supposed to be relatively transparent aside from disk usage increasing in some other pool20:01
jmloweor is that what you are thinking, write a gig and check the disk usage of the pools?20:02
*** rmart04 has joined #openstack-nova20:02
melwittokay, that's cool. no, I wasn't thinking ahead that complex, just thought it'd be handy if something got reflected in the ceph job run for free20:02
melwittfor one thing, I doubt the job is running luminous so it wouldn't do anything anyway20:04
*** shaohe_feng has quit IRC20:06
melwittoh, it actually is. cool. http://logs.openstack.org/55/581055/2/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/d6331b3/logs/ceph/ceph-mgr.x.txt.gz#_2018-07-10_01_16_55_91313020:07
*** shaohe_feng has joined #openstack-nova20:07
jmloweyeah, it is running luminous so it doesn't blow up20:08
*** pchavva has quit IRC20:08
melwittjmlowe: what do you mean, what would make it blow up if not luminous?20:08
dansmithpassing the flag that turns it on right?20:09
dansmithbecause EC isn't supported pre-limunous?20:09
jmloweI'm pretty sure it's a generic abstraction, so you can do stupid ceph tricks like set the data pool to some other replicated pool, that wouldn't do anything useful except save you the extra work of setting up an erasure coded pool in a testing environment20:09
melwittwell, I thought jmlowe had said that passing data_pool=None pre-luminous would make sure it doesn't hurt anything20:10
jmloweguessing if you used the EOL jewel python binding it wouldn't have the kwarg for data_pool20:10
melwittoh, I see. so we need to guard this behavior with a check for ceph version20:10
jmloweyeah, nobody should be using jewel by the time this lands20:11
melwittor are we safe assuming has to be >= luminous at this point?20:11
jmloweyou have to do stupid rpm tricks with centos if you wanted to use it with queens or later20:11
melwittokay, good to know20:12
jmloweI think the queens repo forces install of luminous repo for centos, was an annoyance when I was going to mimic20:12
*** felipemonteiro__ has joined #openstack-nova20:13
*** felipemonteiro_ has quit IRC20:13
*** shaohe_feng has quit IRC20:16
*** felipemonteiro__ is now known as felipemonteiro20:16
*** shaohe_feng has joined #openstack-nova20:16
*** rmart04 has quit IRC20:18
mriedemdansmith: i just went through Kevin_Zheng's 2nd in series live migration abort queued patch and only thing that kind of bothers me is the duplicate validation in the rpc api here https://review.openstack.org/#/c/568542/15/nova/compute/rpcapi.py - i've left an alternative and looking for a 2nd opinion on that20:21
dansmithmriedem: your link in that comment doesn't seem to point to anything relevant20:23
dansmithpresumably you're looking at something that is checking service version20:24
dansmithwhich is cool, but if the service_version says things are okay, but they still have their rpc api manually pinned, they could conflict, so failing somehow is probably appropriate20:25
*** shaohe_feng has quit IRC20:26
*** shaohe_feng has joined #openstack-nova20:27
*** felipemonteiro_ has joined #openstack-nova20:28
dansmithoh sorry, are you talking about the migration status?20:28
dansmithsorry, I totally focused on the version checks20:29
mriedemthe api already checks if the migration status is running and if not it bombs out (today)20:29
mriedemthen calls the rpc api which if the compute is old, makes the same check20:29
dansmithI don't think I understand why we need to check the status of the migration again20:29
mriedemsee my comment20:29
mriedemi think the scenario is you are attempting to abort a queued live migration but the compute is old20:30
dansmithyeah I see it, but.. this code runs in the api itself, and doesn't actually know the version of the compute it's going to talk to20:30
mriedemhis check for 'compute too old' is the can_send_version20:30
dansmiththat's not compute-aware20:31
mriedemso his version check on the nova-compute service needs to happen in the api change if the user is trying to abort a !running migration and the host is old20:31
dansmithcan_send_version() is looking at the api service's rpc pin, which might be computed from service version, or manually set20:32
*** felipemonteiro has quit IRC20:32
dansmithmriedem: right20:32
mriedemok, he's just following similar checks in compute rpc api for things like tagged attachments and such20:32
dansmithmriedem: and by the time we get to rpcapi, we don't have any new information we didn't have a couple frames up on the stack, so no need to do it again20:32
openstackgerritMatt Rabe proposed openstack/nova master: Add destination MSP IP address to PowerVM migrate data  https://review.openstack.org/58146320:32
dansmithyeah, those are for things that haven't already checked service version for the actual compute and are relying on the pin I think20:33
dansmithwhich is a way to do it, but you don't need to do it in both places20:33
mriedemso if we check the nova-compute service version, we don't need the can_send_version (or any) changes to the compute rpcapi at all right?20:33
*** yamamoto has joined #openstack-nova20:33
dansmithwell, no,20:34
openstackgerritChris Dent proposed openstack/nova master: Remove unused variable in migration  https://review.openstack.org/58146420:34
dansmithwhich is why I was saying earlier20:34
dansmithyou can check the service version to know whether all computes or the compute supports the !running cancel, but you don't know if the rpc pin is manually set low,20:34
dansmithso you need to do the can_send_version check in rpcapi20:34
openstackgerritMatt Rabe proposed openstack/nova master: Add destination MSP IP address to PowerVM migrate data  https://review.openstack.org/57967620:35
dansmithwhich might be a reason to just do it there only, and not also up in api and just catch the exception20:35
dansmithlet rpcapi tell you if the thing you're asking for is doable right now, and if not tell the user they can't have it20:35
dansmithsince rpcapi can check both things20:35
dansmithdon't need to check the service version itself for this I don't think20:36
mriedemyeah ok - i was wondering why he didn't just *move* the status check to rpcapi instead of duplicate it20:36
mriedemyou want to leave a comment in that change?20:36
dansmithnot really, but I will :P20:36
*** shaohe_feng has quit IRC20:36
*** shaohe_feng has joined #openstack-nova20:38
*** yamamoto has quit IRC20:39
*** med_ has joined #openstack-nova20:43
*** moshele has quit IRC20:44
*** shaohe_feng has quit IRC20:47
*** shaohe_feng has joined #openstack-nova20:47
*** tidwellr has quit IRC20:52
*** itlinux has quit IRC20:53
*** Guest88425 has joined #openstack-nova20:54
mriedemthis is weird https://github.com/openstack/nova/blob/8469fa70dafa83cb068538679100bede7679edc3/nova/objects/service.py#L32320:55
*** med_ has quit IRC20:55
*** shaohe_feng has quit IRC20:57
*** priteau has joined #openstack-nova20:57
cdentmriedem: that is odd20:57
*** shaohe_feng has joined #openstack-nova20:57
openstackgerritRick Bartra proposed openstack/nova master: Add granularity to os-services API  https://review.openstack.org/57855320:58
*** felipemonteiro_ has quit IRC20:58
*** felipemonteiro_ has joined #openstack-nova20:59
mriedemi have no idea why that was added there,20:59
mriedembut lots of people were approving of the chnage20:59
mriedemaha https://review.openstack.org/#/c/161822/2/nova/db/sqlalchemy/api.py@42520:59
mriedemthe db api used to behave that way20:59
mriedemso it was mirrored in the object21:00
openstackgerritEric Fried proposed openstack/nova master: Tighten up ReportClient use of generation  https://review.openstack.org/55666921:01
mriedemapparently the service startup code relies on that to determine if it needs to create the service record21:01
mriedemrather than just handling the notfound21:01
*** med_ has joined #openstack-nova21:03
*** flwang1 has joined #openstack-nova21:06
*** shaohe_feng has quit IRC21:07
*** shaohe_feng has joined #openstack-nova21:09
*** jmlowe has quit IRC21:10
*** cdent has quit IRC21:10
openstackgerritEric Fried proposed openstack/nova master: Check provider generation and retry on conflict  https://review.openstack.org/55666921:11
*** eharney has quit IRC21:13
*** shaohe_feng has quit IRC21:17
*** jmlowe has joined #openstack-nova21:18
*** shaohe_feng has joined #openstack-nova21:19
*** med_ has quit IRC21:20
*** antosh has quit IRC21:20
*** jmlowe has quit IRC21:23
*** med_ has joined #openstack-nova21:25
*** shaohe_feng has quit IRC21:28
*** shaohe_feng has joined #openstack-nova21:29
*** mago_ has joined #openstack-nova21:34
*** jmlowe has joined #openstack-nova21:36
openstackgerritKen'ichi Ohmichi proposed openstack/nova master: Avoid BadRequest error log on volume attachment  https://review.openstack.org/58145321:37
*** priteau has quit IRC21:37
*** priteau has joined #openstack-nova21:37
*** shaohe_feng has quit IRC21:38
*** shaohe_feng has joined #openstack-nova21:38
*** mago_ has quit IRC21:39
*** Guest23991 has quit IRC21:40
*** antosh has joined #openstack-nova21:43
mriedemdansmith: question in the numa aware vswitch hardware change here https://review.openstack.org/#/c/564448/14/nova/tests/unit/virt/test_hardware.py@334321:45
dansmithmriedem: see my comment on that in an earlier PS?21:46
dansmithmriedem: I think the deal is, the physnet may be available on the host, but the operator hasn't said that it's particularly affined to some node21:47
dansmithI stumbled on that as well, but worked out the reasoning from the comments and the tests21:47
mriedembut the point is,21:48
dansmithI dunno if that would just be "the operator doesn't care enough to configure the thing" or if there's some reason why it may not be affined, like it's too dynamic or something21:48
mriedemas a user i can say i want to be affined to baz and if the operator hasn't reported baz, we'll still do the build even though you might not be affined to baz21:48
*** shaohe_feng has quit IRC21:48
mriedemi'm thinking of it like inventory - is that the wrong way to think about this?21:48
dansmithno, that comment says that the user has requested network baz, and the compute node will do it,21:48
mriedemi see stephenfin has also dropped the patch that does any RT claims code21:49
dansmithbut there is no *numa* affinity between a numa node and network baz21:49
*** jogo has quit IRC21:49
mriedem'compute node will do it' as in, wire up the ports on network baz21:49
dansmiththe user doesn't request numa affinity to a network,21:49
*** shaohe_feng has joined #openstack-nova21:50
dansmiththey request some network, and maybe some numa layout, but this process makes sure we select a favorable numa pinning of guest nodes to host nodes such that they won't end up on no affined nodes to the network they want21:50
mriedemassuming the operator has exposed that affinity info on the host...21:51
dansmithhas configured it, yeah21:51
dansmiththe user doesn't really know anything about this behind the scenes optimization21:52
dansmiththey may know that their network performance isn't what it should be,21:52
dansmithbut they ask for high-level things like being connected to network baz,21:52
dansmithand expect the backend is configuring their numa layout and pinning properly21:52
dansmithright now that doesn't happen,21:52
dansmithand if an operator doesn't or can't configure that information, they'll get what they get today21:53
mriedemcan they, or can't they, throw a fit when they don't like what they get21:53
mriedemignore that21:53
*** med_ has quit IRC21:54
mriedemok that helps anyway, i was approaching this whole bp as a pass/fail type thing (hence the inventory thinking) rather than an optimization21:54
dansmithwell, the hardware fitting thing is pass/fail21:55
dansmith"these nodes pass/fail my test for good-enough"21:55
mriedemso if i want baz and only foo and bar are reported, i get whatever. but if i want foo and foo is reported somewhere, scheduler picks that one specifically.21:55
dansmithbut in the case of no information, they pass as they do today21:55
mriedemok yeah - i should have read the tests when reviewing the code earlier21:55
mriedemok +2 up through that point as well21:57
*** tssurya has quit IRC21:58
*** shaohe_feng has quit IRC21:58
dansmithokay, I won't get back to that today but I'll plan on it first thing in the morning21:59
dansmithand then circle back on yikun's assuming he gets it re-worked overnight21:59
*** burt has quit IRC22:00
*** shaohe_feng has joined #openstack-nova22:00
mriedemi'm sure his first and most pleasurable thing to do in the morning is figure out wtf we've done to his code series :)22:01
*** edmondsw has quit IRC22:01
dansmithhah yeah22:03
*** felipemonteiro_ has quit IRC22:04
*** shaohe_feng has quit IRC22:09
*** shaohe_feng has joined #openstack-nova22:10
*** priteau has quit IRC22:13
*** shaohe_feng has quit IRC22:19
*** shaohe_feng has joined #openstack-nova22:20
*** rcernin has joined #openstack-nova22:22
mriedemstephenfin: why was the numa-affined vswitch RT claims change dropped? https://review.openstack.org/#/c/564449/3/nova/compute/claims.py22:22
mriedemwe can still have a late race/collision during the claim on the compute can't we?22:23
*** med_ has joined #openstack-nova22:27
*** shaohe_feng has quit IRC22:29
*** shaohe_feng has joined #openstack-nova22:30
*** med_ has quit IRC22:32
*** yamamoto has joined #openstack-nova22:36
*** shaohe_feng has quit IRC22:39
*** shaohe_feng has joined #openstack-nova22:41
openstackgerritMerged openstack/nova master: hardware: fix hugepages memory usage per intances  https://review.openstack.org/58065722:41
*** yamamoto has quit IRC22:42
*** med_ has joined #openstack-nova22:48
*** med_ has quit IRC22:48
*** med_ has joined #openstack-nova22:48
*** shaohe_feng has quit IRC22:50
*** shaohe_feng has joined #openstack-nova22:51
*** awaugama has quit IRC22:53
openstackgerritMerged openstack/nova master: Update root providers in same tree  https://review.openstack.org/58024622:59
openstackgerritMerged openstack/nova master: Use nova.db.api directly  https://review.openstack.org/54326222:59
openstackgerritMerged openstack/nova master: Refactor policies to policy in InstanceGroup DB model  https://review.openstack.org/57911322:59
*** shaohe_feng has quit IRC23:00
*** shaohe_feng has joined #openstack-nova23:01
*** hongbin has quit IRC23:06
*** shaohe_feng has quit IRC23:10
*** shaohe_feng has joined #openstack-nova23:13
*** edmondsw has joined #openstack-nova23:16
*** shaohe_feng has quit IRC23:20
*** edmondsw has quit IRC23:21
*** shaohe_feng has joined #openstack-nova23:22
*** bhagyashri_s has quit IRC23:27
*** antosh has quit IRC23:28
*** bhagyashri_s has joined #openstack-nova23:28
*** chyka_ has quit IRC23:29
*** shaohe_feng has quit IRC23:31
openstackgerritMerged openstack/os-vif master: doc: Fix formatting issues  https://review.openstack.org/58044323:31
*** shaohe_feng has joined #openstack-nova23:31
*** yamamoto has joined #openstack-nova23:38
*** shaohe_feng has quit IRC23:41
*** shaohe_feng has joined #openstack-nova23:43
*** yamamoto has quit IRC23:44
*** Guest88425 has quit IRC23:51
*** shaohe_feng has quit IRC23:51
*** takashin has joined #openstack-nova23:51
*** shaohe_feng has joined #openstack-nova23:52

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!