Monday, 2018-07-23

*** shaohe_feng has quit IRC00:04
*** shaohe_feng has joined #openstack-nova00:05
*** shaohe_feng has quit IRC00:14
*** shaohe_feng has joined #openstack-nova00:15
*** shaohe_feng has quit IRC00:24
*** shaohe_feng has joined #openstack-nova00:28
*** shaohe_feng has quit IRC00:34
*** shaohe_feng has joined #openstack-nova00:35
*** yamamoto has joined #openstack-nova00:39
*** shaohe_feng has quit IRC00:45
*** yamamoto has quit IRC00:45
openstackgerritfupingxie proposed openstack/nova master: Delete allocations when it is re-allocated  https://review.openstack.org/58289900:46
*** wolverineav has joined #openstack-nova00:49
*** shaohe_feng has joined #openstack-nova00:49
*** wolverineav has quit IRC00:54
*** shaohe_feng has quit IRC00:55
*** shaohe_feng has joined #openstack-nova00:58
*** med_ has joined #openstack-nova01:02
*** med_ has quit IRC01:02
*** med_ has joined #openstack-nova01:02
*** Dinesh_Bhor has joined #openstack-nova01:02
*** shaohe_feng has quit IRC01:05
*** shaohe_feng has joined #openstack-nova01:08
*** edmondsw has joined #openstack-nova01:11
*** hongbin has joined #openstack-nova01:13
*** shaohe_feng has quit IRC01:15
*** edmondsw has quit IRC01:15
*** mrsoul has joined #openstack-nova01:16
*** shaohe_feng has joined #openstack-nova01:17
*** mrsoul` has quit IRC01:19
*** liuyulong has joined #openstack-nova01:25
*** shaohe_feng has quit IRC01:26
*** shaohe_feng has joined #openstack-nova01:27
openstackgerritZhenyu Zheng proposed openstack/nova master: Func test for improper cn local DISK_GB reporting  https://review.openstack.org/58364601:34
*** shaohe_feng has quit IRC01:36
*** shaohe_feng has joined #openstack-nova01:38
*** yamamoto has joined #openstack-nova01:41
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (5)  https://review.openstack.org/57084201:43
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (6)  https://review.openstack.org/57133001:43
*** shaohe_feng has quit IRC01:46
*** yamamoto has quit IRC01:47
*** shaohe_feng has joined #openstack-nova01:47
*** yamamoto has joined #openstack-nova01:51
*** yamamoto has quit IRC01:54
*** shaohe_feng has quit IRC01:56
*** hshiina has joined #openstack-nova01:57
*** shaohe_feng has joined #openstack-nova01:58
*** lei-zh has joined #openstack-nova01:58
*** Dinesh_Bhor has quit IRC01:58
*** med_ has quit IRC02:01
*** Dinesh_Bhor has joined #openstack-nova02:04
*** shaohe_feng has quit IRC02:07
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (7)  https://review.openstack.org/57199202:07
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (8)  https://review.openstack.org/57199302:09
*** gongysh has joined #openstack-nova02:09
*** shaohe_feng has joined #openstack-nova02:10
*** shaohe_feng has quit IRC02:17
*** shaohe_feng has joined #openstack-nova02:19
openstackgerrityanpuqing proposed openstack/nova master: Rename auth_uri to www_authenticate_uri  https://review.openstack.org/57682002:19
*** tetsuro has joined #openstack-nova02:25
*** shaohe_feng has quit IRC02:27
*** shaohe_feng has joined #openstack-nova02:29
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3)  https://review.openstack.org/57410402:36
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4)  https://review.openstack.org/57410602:36
*** shaohe_feng has quit IRC02:37
*** shaohe_feng has joined #openstack-nova02:38
openstackgerritMerged openstack/nova master: Add regression test for bug 1781710  https://review.openstack.org/58333902:38
openstackbug 1781710 in OpenStack Compute (nova) "ServersOnMultiNodesTest.test_create_server_with_scheduler_hint_group_anti_affinity failing with "Servers are on the same host"" [High,In progress] https://launchpad.net/bugs/1781710 - Assigned to Matt Riedemann (mriedem)02:38
*** flwang1 has joined #openstack-nova02:45
*** yamamoto has joined #openstack-nova02:45
*** shaohe_feng has quit IRC02:48
*** psachin has joined #openstack-nova02:49
*** shaohe_feng has joined #openstack-nova02:49
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5)  https://review.openstack.org/57411002:53
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6)  https://review.openstack.org/57411302:53
*** vladikr has quit IRC02:54
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (7)  https://review.openstack.org/57497402:54
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8)  https://review.openstack.org/57531102:54
*** vladikr has joined #openstack-nova02:54
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9)  https://review.openstack.org/57558102:54
*** dave-mcc_ has quit IRC02:54
*** brault has quit IRC02:54
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10)  https://review.openstack.org/57601702:54
*** brault has joined #openstack-nova02:55
*** shaohe_feng has quit IRC02:58
*** vladikr has quit IRC02:58
*** shaohe_feng has joined #openstack-nova02:59
*** edmondsw has joined #openstack-nova02:59
*** vladikr has joined #openstack-nova02:59
*** gongysh has quit IRC03:01
*** edmondsw has quit IRC03:04
*** shaohe_feng has quit IRC03:08
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11)  https://review.openstack.org/57601803:09
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12)  https://review.openstack.org/57601903:09
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13)  https://review.openstack.org/57602003:09
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14)  https://review.openstack.org/57602703:09
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15)  https://review.openstack.org/57603103:10
*** shaohe_feng has joined #openstack-nova03:10
*** yamamoto has quit IRC03:16
*** yamamoto has joined #openstack-nova03:16
*** vladikr has quit IRC03:18
*** vladikr has joined #openstack-nova03:18
*** shaohe_feng has quit IRC03:18
*** shaohe_feng has joined #openstack-nova03:19
*** yamamoto has quit IRC03:20
*** psachin has quit IRC03:22
openstackgerritZhenyu Zheng proposed openstack/nova master: Report 0 root_gb in resource tracker if instance is bfv.  https://review.openstack.org/58420403:25
*** shaohe_feng has quit IRC03:29
*** shaohe_feng has joined #openstack-nova03:30
*** Dinesh_Bhor has quit IRC03:34
*** psachin has joined #openstack-nova03:38
*** shaohe_feng has quit IRC03:39
*** shaohe_feng has joined #openstack-nova03:42
*** vladikr has quit IRC03:45
*** vladikr has joined #openstack-nova03:45
*** Dinesh_Bhor has joined #openstack-nova03:47
*** shaohe_feng has quit IRC03:49
*** Dinesh_Bhor has quit IRC03:50
*** slaweq has quit IRC03:52
*** shaohe_feng has joined #openstack-nova03:52
*** udesale has joined #openstack-nova03:55
*** slaweq has joined #openstack-nova03:59
*** shaohe_feng has quit IRC03:59
*** kevinbenton has quit IRC04:00
*** lpetrut has joined #openstack-nova04:00
*** kevinbenton has joined #openstack-nova04:00
*** shaohe_feng has joined #openstack-nova04:02
*** mdnadeem has joined #openstack-nova04:06
*** lei-zh has quit IRC04:06
*** shaohe_feng has quit IRC04:10
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Fix the help text for server-group-create  https://review.openstack.org/58470904:11
*** shaohe_feng has joined #openstack-nova04:12
*** shaohe_feng has quit IRC04:20
*** flwang1 has quit IRC04:21
*** shaohe_feng has joined #openstack-nova04:21
*** flwang1 has joined #openstack-nova04:21
*** jamesdenton has quit IRC04:27
*** shaohe_feng has quit IRC04:30
*** shaohe_feng has joined #openstack-nova04:31
*** flwang1 has quit IRC04:37
*** shaohe_feng has quit IRC04:40
*** shaohe_feng has joined #openstack-nova04:42
*** owalsh has quit IRC04:43
*** lpetrut has quit IRC04:45
*** Dinesh_Bhor has joined #openstack-nova04:46
*** edmondsw has joined #openstack-nova04:47
*** shaohe_feng has quit IRC04:51
*** edmondsw has quit IRC04:52
*** yamamoto has joined #openstack-nova04:52
*** shaohe_feng has joined #openstack-nova04:53
*** janki has joined #openstack-nova04:54
openstackgerritMerged openstack/nova master: Merge server create for multiple-create extension  https://review.openstack.org/58001704:54
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16)  https://review.openstack.org/57629904:55
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17)  https://review.openstack.org/57634404:55
*** hongbin has quit IRC04:55
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18)  https://review.openstack.org/57667304:55
*** shaohe_feng has quit IRC05:01
*** shaohe_feng has joined #openstack-nova05:03
*** yamamoto has quit IRC05:03
*** janki has quit IRC05:03
*** janki has joined #openstack-nova05:04
*** yamamoto has joined #openstack-nova05:07
*** brault_ has joined #openstack-nova05:07
*** brault has quit IRC05:09
*** sridharg has joined #openstack-nova05:10
*** brault has joined #openstack-nova05:11
*** shaohe_feng has quit IRC05:11
*** ircuser-1 has joined #openstack-nova05:12
openstackgerritGhanshyam Mann proposed openstack/nova master: Merge extended availability zone response into server controller  https://review.openstack.org/50285905:12
*** brault_ has quit IRC05:13
openstackgerritGhanshyam Mann proposed openstack/nova master: Merge config drive extension response into server controller  https://review.openstack.org/58422305:14
*** shaohe_feng has joined #openstack-nova05:15
*** gongysh has joined #openstack-nova05:16
*** ratailor has joined #openstack-nova05:21
*** shaohe_feng has quit IRC05:21
*** gongysh has quit IRC05:21
openstackgerritGhanshyam Mann proposed openstack/nova master: Merge config drive extension response into server controller  https://review.openstack.org/58422305:22
openstackgerritGhanshyam Mann proposed openstack/nova master: Merge extended server attributes extension response  https://review.openstack.org/58459005:23
*** shaohe_feng has joined #openstack-nova05:24
*** armaan has joined #openstack-nova05:26
*** yamamoto has quit IRC05:28
*** lei-zh has joined #openstack-nova05:29
*** abhishekk has joined #openstack-nova05:29
*** brault has quit IRC05:30
*** shaohe_feng has quit IRC05:32
*** mlavalle has joined #openstack-nova05:32
*** shaohe_feng has joined #openstack-nova05:33
*** armaan has quit IRC05:35
*** links has joined #openstack-nova05:38
openstackgerritGhanshyam Mann proposed openstack/nova master: Merge extended server attributes extension response  https://review.openstack.org/58459005:42
*** udesale_ has joined #openstack-nova05:42
*** shaohe_feng has quit IRC05:42
*** shaohe_feng has joined #openstack-nova05:43
*** udesale has quit IRC05:45
*** shaohe_feng has quit IRC05:52
*** shaohe_feng has joined #openstack-nova05:53
deepak_mouryatakashin:  Hi, What is the default direction of sort when we will do 'nova list' ?05:56
deepak_mouryaNovaClient : It shows default is descending https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/shell.py#L145405:56
deepak_mouryaNova Sqlalchemy : It shows default is Ascending https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L245405:56
*** mlavalle has quit IRC05:56
*** zhurong has joined #openstack-nova05:58
*** trungnv has joined #openstack-nova05:59
takashindeepak_mourya: In the compute API refrence, the default value of 'sort_dir' parameter is 'desc'.06:01
*** psachin has quit IRC06:01
*** Dinesh_Bhor has quit IRC06:01
takashindeepak_mourya: https://developer.openstack.org/api-ref/compute/#list-server-request06:01
takashindeepak_mourya: https://developer.openstack.org/api-ref/compute/#id1506:01
*** psachin` has joined #openstack-nova06:02
*** shaohe_feng has quit IRC06:02
takashindeepak_mourya: So compute API and nova client have same default value.06:02
*** shaohe_feng has joined #openstack-nova06:04
*** vivsoni has joined #openstack-nova06:04
deepak_mouryatakashin: Ok, so when we do 'nova list' default servers should come sorted on the basis of  column 'name' (sortby_index=1) in the Descending order . Isn't it ?06:04
vishakhatakashin : Hi, I have updated the patch https://review.openstack.org/#/c/580271/. Pls review. Thanks06:06
*** shaohe_feng has quit IRC06:13
*** mschuppert has joined #openstack-nova06:13
*** Dinesh_Bhor has joined #openstack-nova06:13
takashindeepak_mourya: In nova, the result is sorted by 'created_at' value (descending order).06:13
takashindeepak_mourya: https://github.com/openstack/nova/blob/master/nova/api/openstack/common.py#L143-L14406:14
*** brault has joined #openstack-nova06:14
takashindeepak_mourya: I'm not sure that the server name should be sorted by descending order in novaclient.06:14
takashinvishakha: okay. I will.06:14
openstackgerritjichenjc proposed openstack/nova master: add zvm into support matrix  https://review.openstack.org/53272006:14
openstackgerritjichenjc proposed openstack/nova master: Add zvm admin intro and hypervisor information  https://review.openstack.org/53312506:14
*** shaohe_feng has joined #openstack-nova06:14
openstackgerritjichenjc proposed openstack/nova master: Add zvm CI information  https://review.openstack.org/53351206:14
vishakhatakashin : Thanks06:17
deepak_mouryatakashin:06:19
deepak_mouryaOk thanks got it, but I think result is still not sorted.06:19
deepak_mouryanova list --sort created_at06:19
deepak_mourya+--------------------------------------+------+--------+------------+-------------+---------------------------------+06:19
deepak_mourya| ID                                   | Name | Status | Task State | Power State | Networks                        |06:19
deepak_mourya+--------------------------------------+------+--------+------------+-------------+---------------------------------+06:19
deepak_mourya| b56b3bee-df66-43a2-90ad-a6ab522390e6 | abbc | ACTIVE | -          | Running     | public=2001:db8::e, 172.24.4.6  |06:19
deepak_mourya| 58c19cbc-57e8-49b3-8676-54f57e7df1ab | aab  | ACTIVE | -          | Running     | public=2001:db8::9, 172.24.4.13 |06:19
deepak_mourya| d0900044-f59a-4032-8bb1-0347c2f30bae | abc  | ACTIVE | -          | Running     | public=2001:db8::d, 172.24.4.8  |06:19
deepak_mourya| 307afbb8-131f-42f0-ba96-7a6e1f4a7846 | ab   | ACTIVE | -          | Running     | public=2001:db8::8, 172.24.4.11 |06:19
deepak_mourya+--------------------------------------+------+--------+------------+-------------+---------------------------------+06:19
deepak_mouryanova list06:19
deepak_mourya'+--------------------------------------+------+--------+------------+-------------+---------------------------------+06:19
deepak_mourya| ID                                   | Name | Status | Task State | Power State | Networks                        |06:19
deepak_mouryanova list06:20
deepak_mourya'+--------------------------------------+------+--------+------------+-------------+---------------------------------+06:20
deepak_mourya| ID                                   | Name | Status | Task State | Power State | Networks                        |06:20
deepak_mourya+--------------------------------------+------+--------+------------+-------------+---------------------------------+06:20
deepak_mourya| 58c19cbc-57e8-49b3-8676-54f57e7df1ab | aab  | ACTIVE | -          | Running     | public=2001:db8::9, 172.24.4.13 |06:20
deepak_mourya| 307afbb8-131f-42f0-ba96-7a6e1f4a7846 | ab   | ACTIVE | -          | Running     | public=2001:db8::8, 172.24.4.11 |06:20
deepak_mourya| b56b3bee-df66-43a2-90ad-a6ab522390e6 | abbc | ACTIVE | -          | Running     | public=2001:db8::e, 172.24.4.6  |06:20
deepak_mourya| d0900044-f59a-4032-8bb1-0347c2f30bae | abc  | ACTIVE | -          | Running     | public=2001:db8::d, 172.24.4.8  |06:20
deepak_mourya+--------------------------------------+------+--------+------------+-------------+---------------------------------+06:20
gmanndeepak_mourya: is it not sorted by created_at or you are checking sort with name ?06:20
deepak_mouryagmann:  When we do 'nova list' , it should sort on the basis of the created_at  paramemter06:22
gmannyea06:22
deepak_mouryabut what i don't think the resulted output  is  sorted on the same basis .06:22
*** shaohe_feng has quit IRC06:23
gmannbut did you check the server create_at field for them06:23
deepak_mouryagmann:  http://paste.openstack.org/show/726419/06:24
*** shaohe_feng has joined #openstack-nova06:24
openstackgerritLei Zhang proposed openstack/nova master: Add method to get cpu traits  https://review.openstack.org/56031706:24
openstackgerritZhenyu Zheng proposed openstack/nova master: Report 0 root_gb in resource tracker if instance is bfv.  https://review.openstack.org/58420406:25
*** sahid has joined #openstack-nova06:28
*** lpetrut has joined #openstack-nova06:29
openstackgerritLei Zhang proposed openstack/nova master: Add method to get cpu traits  https://review.openstack.org/56031706:29
gmanndeepak_mourya: seems like it is n or sorted by default.06:30
gmanndeepak_mourya: let me check on my env06:30
deepak_mouryagmann: ok06:30
*** shaohe_feng has quit IRC06:33
*** shaohe_feng has joined #openstack-nova06:35
*** edmondsw has joined #openstack-nova06:35
*** ccamacho has joined #openstack-nova06:39
*** edmondsw has quit IRC06:39
*** links has quit IRC06:41
*** udesale__ has joined #openstack-nova06:43
*** shaohe_feng has quit IRC06:43
*** shaohe_feng has joined #openstack-nova06:44
*** udesale_ has quit IRC06:45
*** dtantsur|afk is now known as dtantsur06:45
*** hshiina has quit IRC06:50
openstackgerritjichenjc proposed openstack/nova master: add zvm into support matrix  https://review.openstack.org/53272006:51
openstackgerritjichenjc proposed openstack/nova master: Add zvm admin intro and hypervisor information  https://review.openstack.org/53312506:51
openstackgerritjichenjc proposed openstack/nova master: Add zvm CI information  https://review.openstack.org/53351206:51
*** shaohe_feng has quit IRC06:54
*** jaosorior has joined #openstack-nova06:55
*** shaohe_feng has joined #openstack-nova06:56
*** armaan has joined #openstack-nova06:59
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19)  https://review.openstack.org/57667607:00
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20)  https://review.openstack.org/57668907:00
*** links has joined #openstack-nova07:00
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21)  https://review.openstack.org/57670907:00
*** alexchadin has joined #openstack-nova07:00
*** pcaruana has joined #openstack-nova07:02
*** shaohe_feng has quit IRC07:04
*** shaohe_feng has joined #openstack-nova07:04
*** Luzi has joined #openstack-nova07:05
*** evrardjp_ is now known as evrardjp07:09
*** pooja_jadhav has joined #openstack-nova07:10
*** tssurya has joined #openstack-nova07:14
*** shaohe_feng has quit IRC07:14
*** ispp has joined #openstack-nova07:14
*** shaohe_feng has joined #openstack-nova07:17
*** yamamoto has joined #openstack-nova07:20
*** ispp has quit IRC07:21
*** tesseract has joined #openstack-nova07:21
*** mgoddard has joined #openstack-nova07:22
*** damien_r has joined #openstack-nova07:23
openstackgerritjichenjc proposed openstack/nova master: Add zvm admin intro and hypervisor information  https://review.openstack.org/53312507:24
openstackgerritjichenjc proposed openstack/nova master: Add zvm CI information  https://review.openstack.org/53351207:24
*** zhurong has quit IRC07:24
*** yamamoto has quit IRC07:24
*** shaohe_feng has quit IRC07:24
*** shaohe_feng has joined #openstack-nova07:25
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22)  https://review.openstack.org/57671207:29
openstackgerrithuanhongda proposed openstack/nova master: WIP: hypervisor-stats shows wrong disk usages with shared storage  https://review.openstack.org/14987807:32
*** ragiman has joined #openstack-nova07:33
*** links has quit IRC07:34
*** shaohe_feng has quit IRC07:35
*** shaohe_feng has joined #openstack-nova07:35
*** rmart04 has joined #openstack-nova07:35
*** rpittau has joined #openstack-nova07:38
openstackgerritGhanshyam Mann proposed openstack/nova master: Merge keypair extension response into server view builder  https://review.openstack.org/58474807:40
*** AlexeyAbashkin has joined #openstack-nova07:42
*** shaohe_feng has quit IRC07:45
*** shaohe_feng has joined #openstack-nova07:47
*** links has joined #openstack-nova07:47
*** zhurong has joined #openstack-nova07:49
*** adrianc has joined #openstack-nova07:51
*** shaohe_feng has quit IRC07:55
*** shaohe_feng has joined #openstack-nova07:56
*** avolkov has joined #openstack-nova07:57
*** avolkov has quit IRC07:59
*** adrianc has quit IRC08:00
*** ispp has joined #openstack-nova08:01
*** takashin has left #openstack-nova08:03
*** armaan has quit IRC08:04
*** shaohe_feng has quit IRC08:05
*** shaohe_feng has joined #openstack-nova08:06
*** blkart has quit IRC08:12
*** blkart has joined #openstack-nova08:15
*** shaohe_feng has quit IRC08:16
*** shaohe_feng has joined #openstack-nova08:17
*** dtantsur is now known as dtantsur|brb08:18
*** owalsh has joined #openstack-nova08:22
*** edmondsw has joined #openstack-nova08:23
*** mgoddard has quit IRC08:24
*** armaan has joined #openstack-nova08:25
*** shaohe_feng has quit IRC08:26
*** owalsh_ has joined #openstack-nova08:27
*** owalsh has quit IRC08:27
*** edmondsw has quit IRC08:28
*** shaohe_feng has joined #openstack-nova08:28
*** flwang1 has joined #openstack-nova08:31
*** derekh has joined #openstack-nova08:33
*** gongysh has joined #openstack-nova08:35
*** shaohe_feng has quit IRC08:36
gibigood morning08:38
*** shaohe_feng has joined #openstack-nova08:39
openstackgerritBoxiang Zhu proposed openstack/nova stable/pike: Fix "instance snap min disk size err after resize instance"  https://review.openstack.org/58477008:40
*** shaohe_feng has quit IRC08:46
*** zhurong has quit IRC08:47
*** Dinesh_Bhor has quit IRC08:47
*** shaohe_feng has joined #openstack-nova08:47
*** jaosorior has quit IRC08:50
*** shaohe_feng has quit IRC08:57
*** shaohe_feng has joined #openstack-nova08:57
*** Dinesh_Bhor has joined #openstack-nova08:58
*** wolverineav has joined #openstack-nova09:01
*** wolverineav has quit IRC09:06
*** shaohe_feng has quit IRC09:07
*** shaohe_feng has joined #openstack-nova09:08
*** shaohe_feng has quit IRC09:17
*** alexchadin has quit IRC09:17
*** shaohe_feng has joined #openstack-nova09:18
*** Dinesh_Bhor has quit IRC09:19
*** alexchadin has joined #openstack-nova09:23
bauzasgood morning stackers09:27
*** shaohe_feng has quit IRC09:27
* bauzas is back from a long non-available period09:27
*** shaohe_feng has joined #openstack-nova09:29
*** jistr|off is now known as jistr09:29
gibibauzas: welcome back09:31
bauzasthanks09:32
* bauzas starts back with a placement bug, so cool09:32
*** Dinesh_Bhor has joined #openstack-nova09:34
*** links has quit IRC09:34
*** yamamoto has joined #openstack-nova09:36
*** shaohe_feng has quit IRC09:38
*** dtantsur|brb is now known as dtantsur09:38
*** shaohe_feng has joined #openstack-nova09:38
*** cdent has joined #openstack-nova09:39
*** links has joined #openstack-nova09:41
*** yamamoto has quit IRC09:41
*** owalsh_ is now known as owalsh09:41
sean-k-mooneybauzas: o/09:46
*** shaohe_feng has quit IRC09:48
*** shaohe_feng has joined #openstack-nova09:50
*** lei-zh has quit IRC09:50
*** finucannot has quit IRC09:53
*** stephenfin has joined #openstack-nova09:55
*** shaohe_feng has quit IRC09:58
*** shaohe_feng has joined #openstack-nova09:59
*** shaohe_feng has quit IRC10:08
*** shaohe_feng has joined #openstack-nova10:10
*** edmondsw has joined #openstack-nova10:11
*** edmondsw has quit IRC10:16
*** shaohe_feng has quit IRC10:19
openstackgerritChris Dent proposed openstack/nova master: [placement] Add /reshaper handler for POST  https://review.openstack.org/57692710:20
bauzascdent: around ?10:20
cdentbauzas: yup, hi10:20
bauzascdent: can you please refresh my mind ?10:20
* cdent presses the refresh button10:21
bauzascdent: we stopped auto-healing allocations from the RT since Queens, right?10:21
cdentyes, that's how I remember it10:21
bauzascdent: on a RH BZ, some customer got some phantom allocations10:21
*** shaohe_feng has joined #openstack-nova10:21
bauzascdent: so I wonder how their allocations were created10:22
bauzasbut the related instance wasn't there10:22
cdentI have a vague memory of some bugs with cleaning up allocations under certain failure conditions. Do you know whether it was a normal server create or a migration?10:23
bauzasno sorry10:24
bauzasI think it was a server create10:24
bauzasbut I'm not sure10:24
*** ragiman has quit IRC10:25
cdentany chance they deleted the compute service? any of these bugs look relevant?10:27
cdenthttps://bugs.launchpad.net/nova/+bug/175617910:27
openstackLaunchpad bug 1756179 in OpenStack Compute (nova) queens "deleting a nova-compute service leaves orphaned records in placement and host mapping" [Medium,Fix committed] - Assigned to Surya Seetharaman (tssurya)10:27
cdenthttps://bugs.launchpad.net/nova/+bug/167975010:27
openstackLaunchpad bug 1679750 in OpenStack Compute (nova) queens "Allocations are not cleaned up in placement for instance 'local delete' case" [Medium,Fix committed] - Assigned to Matt Riedemann (mriedem)10:27
cdenthttps://bugs.launchpad.net/nova/+bug/166286710:28
openstackLaunchpad bug 1662867 in OpenStack Compute (nova) queens "update_available_resource_for_node racing instance deletion" [Medium,Fix committed] - Assigned to Lee Yarwood (lyarwood)10:28
*** mdbooth has joined #openstack-nova10:28
*** jaosorior has joined #openstack-nova10:28
*** shaohe_feng has quit IRC10:29
*** shaohe_feng has joined #openstack-nova10:30
*** alexchadin has quit IRC10:30
cdentbauzas: I gotta step away, but will be back. I hope some of the above is useful10:32
*** janki has quit IRC10:33
bauzascdent: thanks for the help, I'll look at the bugs10:33
bauzasand I'll try to discuss with the customer10:33
*** alexchadin has joined #openstack-nova10:36
*** Dinesh_Bhor has quit IRC10:37
*** janki has joined #openstack-nova10:39
*** shaohe_feng has quit IRC10:39
*** alexchadin has quit IRC10:41
*** shaohe_feng has joined #openstack-nova10:42
*** links has quit IRC10:44
*** Dinesh_Bhor has joined #openstack-nova10:45
*** alexchadin has joined #openstack-nova10:45
*** med_ has joined #openstack-nova10:46
*** med_ has quit IRC10:46
*** med_ has joined #openstack-nova10:46
*** Dinesh_Bhor has quit IRC10:46
*** links has joined #openstack-nova10:48
*** mlavalle has joined #openstack-nova10:49
*** ragiman has joined #openstack-nova10:49
*** shaohe_feng has quit IRC10:49
*** shaohe_feng has joined #openstack-nova10:51
*** s10 has joined #openstack-nova10:54
*** shaohe_feng has quit IRC11:00
*** shaohe_feng has joined #openstack-nova11:00
*** lucasagomes is now known as lucas-hungry11:03
*** lucas-hungry is now known as lucasagomes11:03
*** dave-mccowan has joined #openstack-nova11:06
*** vladikr has quit IRC11:07
*** vladikr has joined #openstack-nova11:07
*** shaohe_feng has quit IRC11:10
*** shaohe_feng has joined #openstack-nova11:11
ratailorcould anybody review this https://review.openstack.org/#/c/498334/  need one more +2.11:12
ratailorbauzas, ^^11:13
*** links has quit IRC11:13
*** links has joined #openstack-nova11:15
*** gongysh has quit IRC11:15
s10Hello. Is there any possibility to somehow optimise host_state.update(), which runs on every instance scheduling? Specifically this: https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L18111:16
*** gongysh has joined #openstack-nova11:16
s10Our tests show, that this step (load list of instances to host_state) takes ~10 seconds for deployments with thousands of instances.11:17
*** liuyulong has quit IRC11:19
*** abhishekk has quit IRC11:19
*** liuyulong has joined #openstack-nova11:19
*** ratailor has quit IRC11:20
*** shaohe_feng has quit IRC11:20
*** avolkov has joined #openstack-nova11:22
openstackgerritAndrey Volkov proposed openstack/nova master: Docs: Add Placement to Nova system architecture  https://review.openstack.org/58433811:22
*** shaohe_feng has joined #openstack-nova11:23
s10So if we want to start 1000 new instances with 6 nova-scheduler process, without this step (if we commented it out), all of them are being started tens of minutes minutes faster.11:25
*** udesale__ has quit IRC11:25
s10And the only place, where host_state.instances is being used is ServerGroupAntiAffinityFilter and ServerGroupAffinityFilter...11:26
*** shaohe_feng has quit IRC11:30
isppHi, could anyone give me a hand with this? https://bugs.launchpad.net/nova/+bug/178307911:30
openstackLaunchpad bug 1783079 in OpenStack Compute (nova) "Unable to attach interface to a VM" [Undecided,New]11:30
*** shaohe_feng has joined #openstack-nova11:32
*** brault has quit IRC11:33
*** brault has joined #openstack-nova11:34
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove reference to transient domain when detaching devices  https://review.openstack.org/58443311:35
lyarwoodstephenfin: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1764883 - would you mind taking a swing at this today if you have time?11:35
*** GonZo2000 has joined #openstack-nova11:40
*** GonZo2000 has quit IRC11:40
*** GonZo2000 has joined #openstack-nova11:40
*** shaohe_feng has quit IRC11:41
*** jamesdenton has joined #openstack-nova11:41
*** shaohe_feng has joined #openstack-nova11:42
*** mvk_ has quit IRC11:44
*** ispp has quit IRC11:45
*** ispp has joined #openstack-nova11:47
*** vladikr has quit IRC11:49
*** vladikr has joined #openstack-nova11:49
*** shaohe_feng has quit IRC11:51
*** alexpilotti has quit IRC11:53
*** shaohe_feng has joined #openstack-nova11:53
openstackgerritAndrey Volkov proposed openstack/nova master: Docs: Add Placement to Nova system architecture  https://review.openstack.org/58433811:54
*** adrianc_ has joined #openstack-nova11:54
openstackgerritSurya Seetharaman proposed openstack/nova master: Add queued_for_delete field to InstanceMapping object  https://review.openstack.org/56679511:54
openstackgerritSurya Seetharaman proposed openstack/nova master: Online migration tool for populating queued-for-delete  https://review.openstack.org/58253611:54
openstackgerritSurya Seetharaman proposed openstack/nova master: Update queued-for-delete from the ComputeAPI during deletion/restoration  https://review.openstack.org/56681311:54
openstackgerritSurya Seetharaman proposed openstack/nova master: Return a minimal construct for nova service-list when a cell is down  https://review.openstack.org/58482911:54
*** ispp has quit IRC11:55
*** gongysh has quit IRC12:00
*** ispp has joined #openstack-nova12:00
*** shaohe_feng has quit IRC12:01
*** tetsuro has quit IRC12:04
*** shaohe_feng has joined #openstack-nova12:05
*** lyan has joined #openstack-nova12:08
*** lyan is now known as Guest6731312:09
*** tetsuro has joined #openstack-nova12:09
*** tetsuro has quit IRC12:10
*** mdbooth_ has joined #openstack-nova12:11
*** shaohe_feng has quit IRC12:11
*** mdbooth has quit IRC12:12
*** adrianc_ has quit IRC12:12
*** pchavva has joined #openstack-nova12:12
*** edmondsw has joined #openstack-nova12:13
*** shaohe_feng has joined #openstack-nova12:13
*** aloga has quit IRC12:16
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Wire up a force disconnect_volume flag  https://review.openstack.org/58484912:20
openstackgerritLee Yarwood proposed openstack/nova master: WIP libvirt: Forcibly disconnect volumes during post_live_migration  https://review.openstack.org/58485012:20
*** Eran_Kuris has quit IRC12:20
*** Bhujay has joined #openstack-nova12:21
*** shaohe_feng has quit IRC12:22
*** shaohe_feng has joined #openstack-nova12:22
*** yamamoto has joined #openstack-nova12:26
*** leakypipes is now known as jaypipes12:29
*** yamamoto has quit IRC12:30
*** mdnadeem_ has joined #openstack-nova12:31
openstackgerrithuanhongda proposed openstack/nova master: hypervisor-stats shows wrong disk usages with shared storage  https://review.openstack.org/14987812:32
*** shaohe_feng has quit IRC12:32
*** shaohe_feng has joined #openstack-nova12:34
*** mdnadeem has quit IRC12:35
*** Eran_Kuris has joined #openstack-nova12:35
*** beagles_afk is now known as beagles12:38
*** liuyulong has quit IRC12:39
*** liuyulong has joined #openstack-nova12:39
*** wolverineav has joined #openstack-nova12:40
*** jistr is now known as jistr|mtg12:41
*** shaohe_feng has quit IRC12:42
*** yamamoto has joined #openstack-nova12:43
*** s1061123_ has quit IRC12:43
*** shaohe_feng has joined #openstack-nova12:43
*** s1061123 has joined #openstack-nova12:44
*** yamamoto has quit IRC12:46
stephenfinlyarwood: Sure12:48
*** yamamoto has joined #openstack-nova12:49
*** mvk_ has joined #openstack-nova12:51
*** shaohe_feng has quit IRC12:52
*** mriedem has joined #openstack-nova12:53
*** mhg has quit IRC12:53
*** adrianc_ has joined #openstack-nova12:53
*** yamamoto has quit IRC12:54
gibistephenfin: hi! You were +2 on https://review.openstack.org/#/c/410297 before but I lost the +2 in merge conflict resolution. Could you look at it again please?12:54
*** sridharg has quit IRC12:54
*** shaohe_feng has joined #openstack-nova12:54
stephenfingibi: yessir12:55
gibistephenfin: thank you sir12:55
*** udesale has joined #openstack-nova12:56
*** simondodsley_ has quit IRC13:00
*** trozet has joined #openstack-nova13:00
*** simondodsley_ has joined #openstack-nova13:01
*** yamamoto has joined #openstack-nova13:01
stephenfingibi: One question here https://review.openstack.org/#/c/410297/42/nova/tests/unit/compute/test_compute_api.py13:03
*** shaohe_feng has quit IRC13:03
*** lei-zh has joined #openstack-nova13:03
*** yamamoto has quit IRC13:03
gibistephenfin: let me check it locally without that line13:03
gibistephenfin: could be some rebase artifact13:04
*** shaohe_feng has joined #openstack-nova13:04
*** sridharg has joined #openstack-nova13:04
*** alexpilotti has joined #openstack-nova13:05
*** gongysh has joined #openstack-nova13:06
*** Eran_Kuris has quit IRC13:07
gibistephenfin: tests pass without it so I'm going to respin the patch13:12
*** shaohe_feng has quit IRC13:13
openstackgerritBalazs Gibizer proposed openstack/nova master: Transform missing delete notifications  https://review.openstack.org/41029713:13
gibistephenfin: ^^ removed the extra line13:14
*** shaohe_feng has joined #openstack-nova13:14
stephenfingibi: Cool. +2 now13:14
gibicdent: stephenfin thanks13:15
gibibahh13:16
gibistephenfin: thanks13:16
*** lei-zh has quit IRC13:16
*** lei-zh has joined #openstack-nova13:17
*** Eran_Kuris has joined #openstack-nova13:20
*** ccamacho has quit IRC13:20
*** alexchadin has quit IRC13:21
kashyapmdbooth_: Hi, when you get a moment, I'm blind and can't figure out why 'migrate_uri' is still "None" in the actual call here: http://paste.openstack.org/show/726442/13:22
kashyapPlease enlighten, throw rotten tomatoes, etc.13:22
*** shaohe_feng has quit IRC13:23
*** shaohe_feng has joined #openstack-nova13:24
alex_xumriedem: re: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2018-07-20.log.html#t2018-07-20T13:20:3013:24
alex_xumriedem: agree with just merge 'server create' part in Rocky13:24
tssuryaalex_xu: so the merge into view builder would only be in Stein?13:25
*** alexchadin has joined #openstack-nova13:26
alex_xutssurya: yea, is there anything you need about view builder, I see there are something you need, but I didn't follow it yet13:26
*** Bhujay has quit IRC13:26
tssuryaalex_xu: yea, its mainly for this patch: https://review.openstack.org/#/c/567785/13:26
tssuryarelated to the handling a down cell, I need to basically return a minimal response for nova show and list servers13:27
*** takashin has joined #openstack-nova13:27
alex_xutssurya: got it, let me check, thanks13:27
tssuryafor which I would have to handle it seperately for each of the deprecated extensions since they are being merged into the response individually13:27
tssuryaalex_xu: thanks13:27
mriedemalex_xu: yeah gmann has some patches up in the same series for moving things from extensions to server view builder,13:29
mriedembut with the state of the gate the last couple of weeks, i doubt all of this will get merged before feature freeze13:29
*** Eran_Kuris has quit IRC13:30
tssuryamriedem: meanwhile I have a patch for nova service-list here : https://review.openstack.org/#/c/584829/13:31
*** lbragstad has joined #openstack-nova13:31
tssuryawhich doesn't depend on those changes13:31
* tssurya wiritng the version bump test case for that13:32
*** sridharg has quit IRC13:32
*** sridharg has joined #openstack-nova13:32
mriedemtssurya: i assumed that the service list and server list changes for partial results would all be in the same microversion13:32
*** mhg has joined #openstack-nova13:32
mriedemit's kind of weird if they aren't13:32
tssuryaand then I will also do the poliy change for nova boot13:32
tssuryamriedem: true that,13:32
tssuryaso we stall the API changes for now ?13:32
tssuryaor nvm, I will keep working on them and we can see,13:33
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Fix the help text for server-group-create  https://review.openstack.org/58470913:33
mriedemi don't think the server list/show partial results stuff will get in rocky at this rate, if i'm being honest13:33
tssuryamriedem: got it13:33
mriedemi think we're way too close to feature freeze for a change like that, and even if we approved it all today, it would take 4 days to merge13:33
*** shaohe_feng has quit IRC13:33
mriedembut we can see what dansmith and melwitt think about doing the service list partial results in a separate microversion for rocky since that's much smaller scope and admin-only so impacts are smaller13:34
gmannmriedem: yeah, 5-6 are on zuul -2 let’s see how much gets in13:34
tssuryamriedem: hmm ack13:34
*** shaohe_feng has joined #openstack-nova13:35
mriedemtssurya: my personal goal for the bp is getting the queued_for_delete data migration in for rocky, which means choosing between yours and dan's13:35
tssuryamriedem: right, okay let's wait for dansmith then13:35
dansmithmriedem: I guess I would think returning shell results for missing services would be super low priority to me13:35
dansmithmriedem: if a cell is down and we just return the services we can find, I would think the admins would be fine with that given they know the cell is down13:36
mriedemdansmith: as in might as well make them a single microversion13:36
*** amrith has quit IRC13:36
mriedemthem = nova list & service list13:36
dansmithmriedem: we are already returning partial results for service list if a cell is down right?13:36
mriedemyes13:36
mriedemtssurya did the fix for that as a bug13:37
tssuryanot partial results,13:37
tssuryalike skips that cell13:37
dansmithI'm saying, focus on instance list returning shell instances to patch up the instance list, but not care about service list13:37
dansmithtssurya: that's what I mean by partial results13:37
dansmithjust omitting the downed cell13:37
tssuryaah yes sorry,13:37
dansmithI'm not sure why we really need to try to patch up the service list tbh13:37
dansmithand I imagine it's going to be hard13:38
*** belmoreira has joined #openstack-nova13:38
mriedemyou can patch up the compute services, but that's about it13:38
tssuryayea just the host and binary fields13:38
mriedemi don't think it's all that hard. the value question is the question13:38
dansmithI always get this confused, but aren't the host mappings done by compute node and not service?13:38
mriedemshould be the service13:39
dansmithit's by compute node by default,13:39
tssuryaI guess its compute-node for normal cases and service for ironic ?13:39
dansmithI added by-service recently13:39
mriedemsure, but https://github.com/openstack/nova/commit/64e76de43dc55e584c100005fa60da50dd06d35213:40
mriedemoops13:40
mriedemHostMapping.get_by_host(ctxt, compute.host)13:40
mriedemthe host mappings are still 1:1 with the nova-compute service host13:40
dansmithah, compute.host is service host yeah?13:40
dansmithokay13:40
mriedemthere isn't a host mapping per compute.hypervisor_hostname13:40
mriedemwhich is the 1:M thing13:40
dansmithright right okay13:40
*** alexchadin has quit IRC13:40
dansmithI was thinking it would be hard if it was one mapping per node, but fair enough13:41
dansmithanyway, it just seems like really low prio to me13:41
dansmithbrb13:41
mriedemgiven ^ why did we need the discover by service again?13:41
*** alexchadin has joined #openstack-nova13:41
*** alexchadin has quit IRC13:41
mriedemoh b/c ironic doesn't have the nodes yet13:42
mriedemby the time we need to discover the hosts13:42
*** alexchadin has joined #openstack-nova13:42
*** tetsuro has joined #openstack-nova13:42
*** alexchadin has quit IRC13:42
mriedemanyway, i agree doing shell results for service list is also low(er) priority so that's why i figured it would be part of the single microversion for doing nova list/show shell results13:42
*** alexchadin has joined #openstack-nova13:43
*** alexchadin has quit IRC13:43
tssuryaokay, so we do all of that in the same microversion then13:43
openstackgerritBalazs Gibizer proposed openstack/nova master: Send soft_delete from context manager  https://review.openstack.org/47645913:43
*** alexchadin has joined #openstack-nova13:43
*** alexchadin has quit IRC13:44
*** shaohe_feng has quit IRC13:44
tssuryaand for now, we just decide to go with dansmith's migration ? thb, I don't have any particular preference between the two patches13:44
tssuryaso both works for us13:44
*** shaohe_feng has joined #openstack-nova13:44
*** Eran_Kuris has joined #openstack-nova13:45
dansmithmriedem: well my point about being lower priority meant I wouldn't want to hold up the instance side for the service side13:45
mriedemdansmith: sure, she has the service one done*13:46
mriedemand i'm saying i figured just leave it until the instance one is done and make them a single microversion13:46
mriedemthen that is the "down cell" microversion13:47
mriedembut that's just how i've always been thinking this would happen13:47
dansmithoh I see,13:47
dansmithI had assumed the opposite13:47
dansmith(that the instance one was done already)13:47
dansmithmy fault for not being up to date13:47
tssuryanova list is held up for now because it would be neater if this goes in: https://review.openstack.org/#/q/topic:bp/api-extensions-merge-rocky+(status:open+OR+status:merged)13:48
mriedemand we'll be lucky to just get ^ in to rocky13:48
mriedemgiven our current merge rates13:48
dansmithoye13:48
mriedemit's taken a week to land code right now13:48
*** r-daneel has joined #openstack-nova13:49
dansmithyarp13:49
mriedemso i'm really only mostly interested in pushing things across the line this week that is already ready to go and has had a lot of review already13:49
mriedempersonally,13:49
mriedemplus i'm going to have a shitty week with some personal stuff going on so won't be fully available13:49
*** gongysh has quit IRC13:50
pooja_jadhavdansmith: hello13:50
*** gongysh has joined #openstack-nova13:50
dansmithmriedem: ack13:50
dansmithpooja_jadhav: hi13:50
efriedScheduler meeting in ten minutes in #openstack-meeting-alt13:50
tssuryamriedem: ack thanks a lot for all the time an review doen on this spec (if I haven't yet thanked you)13:50
tssuryadansmith: thanks to you too for all the help and reviews13:51
pooja_jadhavdansmith: Actually, gone through your patch, https://review.openstack.org/#/c/580720/. Now testing the move operations (resize, unshelve, evacuate and migrate).13:51
*** mdnadeem_ has quit IRC13:52
openstackgerritDan Smith proposed openstack/nova master: Online data migration for queued_for_delete flag  https://review.openstack.org/58450413:52
dansmithtssurya: mriedem: fixed py35 issue in the test ^13:53
mriedempooja_jadhav: are there problems or you're just letting us know you're testing?13:53
mriedempooja_jadhav: also, thanks for testing this stuff13:53
tssuryadansmith: ack13:53
pooja_jadhavdansmith, mriedem: I have 2 nodes, I am facing issue for migrate API. Can u tell me what are the pre requisites?13:53
mriedempooja_jadhav: cold migrate?13:54
*** shaohe_feng has quit IRC13:54
mriedemunless the nodes are on the same shared storage pool you have to configure ssh access for the nova user between the nodes13:54
pooja_jadhavmriedem, dansmith: for unshelve, there is issue (DISK_GB record is added after unshelve the instance).13:55
*** shaohe_feng has joined #openstack-nova13:55
mriedempooja_jadhav: added where?13:55
dansmithmriedem: you have a patch for that right?13:55
mriedemto placement?13:55
mriedemdansmith: yeah13:55
pooja_jadhavmriedem: yes, in the allocation table13:55
pooja_jadhavcan I provide the details, I have tested?13:56
mriedemunshelve should be handled here https://review.openstack.org/#/c/583715/3/nova/conductor/manager.py@80613:56
mriedemi could update the functional test in that change to run a shelve/unshelve routine to make sure DISK_GB still doesn't show up in placement allocations13:57
pooja_jadhavmriedem: cold/live migrate (both trying to test)13:58
mriedemdamn i have to rebase this series because https://review.openstack.org/#/c/583646/ was rebased13:58
mriedempooja_jadhav: https://docs.openstack.org/devstack/latest/guides/multinode-lab.html13:58
mriedemif you're using devstack13:58
*** hongbin has joined #openstack-nova13:59
pooja_jadhavmriedem: thanks, will check and let u know if the queries :)13:59
pooja_jadhavyes, I am using devstack14:00
mriedemthat doc might be old14:00
*** amrith has joined #openstack-nova14:00
*** amrith is now known as Guest9876614:01
*** Guest98766 has quit IRC14:02
*** amrith_ has joined #openstack-nova14:02
*** alexchadin has joined #openstack-nova14:02
*** adrianc_ has quit IRC14:03
*** amrith_ is now known as Guest5882814:03
*** eharney has joined #openstack-nova14:03
*** alexpilotti has quit IRC14:04
*** shaohe_feng has quit IRC14:04
pooja_jadhavmriedem: Also tested resize and evacuate, but no allocation records get added for DISK_GB.14:04
*** shaohe_feng has joined #openstack-nova14:05
pooja_jadhavmriedem: But for evacuate, hypervisor-stats showing incorrect incorrect usages.14:06
openstackgerritBoxiang Zhu proposed openstack/nova stable/pike: Fix "instance snap min disk size err after resize instance"  https://review.openstack.org/58477014:06
*** alexchadin has quit IRC14:08
*** psachin` has quit IRC14:08
*** gongysh has quit IRC14:08
mriedempooja_jadhav: we already know that hypervisor-stats has latent bugs for reporting disk based on the flavor and not if the server is volume-backed14:08
mriedemthat's what https://review.openstack.org/#/c/583646/ shows14:09
pooja_jadhavmriedem: Ohk14:09
*** ccamacho has joined #openstack-nova14:09
*** tbachman has joined #openstack-nova14:10
pooja_jadhavmriedem: Have tested live/cold migrate then? for allocation of DISK_GB or not?14:10
mriedempooja_jadhav: https://review.openstack.org/#/c/583715/ functionally tests that for cold migration14:11
mriedemhttps://review.openstack.org/#/c/583715/3/nova/tests/functional/test_servers.py14:11
*** Luzi has quit IRC14:11
mriedemi was saying i could add a shelve/unshelve wrinkle to that test as well since you said you saw allocations for DISK_GB in placement after unshelve14:12
*** Eran_Kuris has quit IRC14:12
*** cfriesen_ has joined #openstack-nova14:12
mriedembut i need to rebase this series now14:13
*** alexpilotti has joined #openstack-nova14:13
*** jistr|mtg is now known as jistr14:13
pooja_jadhavmriedem: thanks :)14:14
*** shaohe_feng has quit IRC14:14
*** shaohe_feng has joined #openstack-nova14:15
*** alexpilotti has quit IRC14:15
*** derekh has quit IRC14:19
*** links has quit IRC14:22
*** antosh has joined #openstack-nova14:23
*** derekh has joined #openstack-nova14:23
openstackgerritChris Dent proposed openstack/nova master: [placement] Add /reshaper handler for POST  https://review.openstack.org/57692714:24
*** shaohe_feng has quit IRC14:25
*** Guest58828 has quit IRC14:25
*** alexchadin has joined #openstack-nova14:26
*** shaohe_feng has joined #openstack-nova14:27
*** ispp has quit IRC14:27
*** ispp has joined #openstack-nova14:30
*** amrith- has joined #openstack-nova14:30
*** armaan has quit IRC14:32
*** armaan has joined #openstack-nova14:32
*** dave-mccowan has quit IRC14:33
*** shaohe_feng has quit IRC14:35
*** shaohe_feng has joined #openstack-nova14:37
*** Bhujay has joined #openstack-nova14:40
*** purplerbot has quit IRC14:41
*** purplerbot has joined #openstack-nova14:41
*** dave-mccowan has joined #openstack-nova14:42
*** lei-zh has quit IRC14:42
*** tidwellr has joined #openstack-nova14:44
*** mdbooth_ is now known as mdbooth14:45
*** shaohe_feng has quit IRC14:45
*** shaohe_feng has joined #openstack-nova14:47
*** tetsuro has quit IRC14:48
*** felipemonteiro has joined #openstack-nova14:51
*** alexpilotti has joined #openstack-nova14:54
*** shaohe_feng has quit IRC14:55
*** felipemonteiro has quit IRC14:56
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Remove usage of migrateToURI{2} APIs  https://review.openstack.org/56725814:56
*** shaohe_feng has joined #openstack-nova14:57
*** alexpilotti has quit IRC14:59
*** AlexeyAbashkin has quit IRC14:59
*** AlexeyAbashkin has joined #openstack-nova14:59
mriedemefried: hmm, looks like the retrying package might not be thread safe http://logs.openstack.org/03/583203/2/check/tempest-full-py3/0b5111a/controller/logs/screen-n-cond-cell1.txt.gz#_Jul_23_13_35_01_49135014:59
mriedemgot a thread switch there which looks like it caused a failure during RT._update14:59
mriedemwell, maybe not15:00
*** hshiina has joined #openstack-nova15:00
mriedemcould just be throwing me b/c it's in the trace b/c of the decorator15:00
*** chyka has joined #openstack-nova15:00
*** beekneemech is now known as bnemec15:00
mriedemhit a messaging timeout, maybe just a slow node15:00
*** bnemec is now known as beekneemech15:01
*** beekneemech is now known as bnemec15:01
mriedemyeah15:01
efriedmriedem: afaik, retrying doesn't use threads at all. Are you saying it has a global or something?15:01
mriedemJul 23 13:35:01.252889 ubuntu-xenial-packethost-us-west-1-0000896864 nova-compute[22210]: WARNING nova.servicegroup.drivers.db [None req-93269558-9418-452a-b391-8766a59984a5 tempest-TestVolumeSwap-747104316 tempest-TestVolumeSwap-747104316] Lost connection to nova-conductor for reporting service status.: oslo_messaging.exceptions.MessagingTimeout: Timed out waiting for a reply to message ID 06f920f1d628445b877ff4100980047e15:01
mriedemefried: no i think it just threw me in the stacktrace15:01
efriedight15:01
*** chyka has quit IRC15:02
*** eharney has quit IRC15:02
*** chyka has joined #openstack-nova15:02
sean-k-mooneyQQ are the functional tests safe to run with devstack stacked?15:02
mriedemnova tox -e functional?15:03
mriedemthey run in a venv so yes15:03
sean-k-mooneyok cool was just wondering if i would get any failures due to haveing opentack running15:03
*** takashin has left #openstack-nova15:04
*** rmart04_ has joined #openstack-nova15:05
*** rmart04 has quit IRC15:06
*** shaohe_feng has quit IRC15:06
*** shaohe_feng has joined #openstack-nova15:08
*** rmart04_ has quit IRC15:09
*** belmoreira has quit IRC15:12
*** yamamoto has joined #openstack-nova15:15
stephenfinmriedem: RE: numa-aware-vswitches and move operations. Rebuilds don't run through the scheduler and don't make claims so I ignore that kind of rebuild operation, right?15:15
*** eharney has joined #openstack-nova15:15
openstackgerritMatt Riedemann proposed openstack/nova master: Report 0 root_gb in resource tracker if instance is bfv.  https://review.openstack.org/58420415:15
openstackgerritMatt Riedemann proposed openstack/nova master: Heal RequestSpec.is_bfv for legacy instances during moves  https://review.openstack.org/58371515:15
openstackgerritMatt Riedemann proposed openstack/nova master: Fix wonky reqspec handling in conductor.unshelve_instance  https://review.openstack.org/58373915:15
openstackgerritMatt Riedemann proposed openstack/nova master: Add shelve/unshelve wrinkle to volume-backed disk func test  https://review.openstack.org/58493115:15
mriedempooja_jadhav: ^ added a shelve/unshelve functional test to the end of the series and that shows things working as designed15:15
sean-k-mooneystephenfin: rebuilds should still go through the scheuler15:16
mriedemstephenfin: depends, what does the RUN_ON_REBUILD flag say for NUMATopologyFilter?15:16
mriedemsean-k-mooney: not in all cases, and not for all filters15:16
*** shaohe_feng has quit IRC15:16
*** AlexeyAbashkin has quit IRC15:16
mriedemstephenfin: and to be clear, you're talking about rebuild, not evacuate, yes?15:16
*** AlexeyAbashkin has joined #openstack-nova15:16
mriedemstephenfin: class NUMATopologyFilter(filters.BaseHostFilter):15:16
mriedem    """Filter on requested NUMA topology."""15:16
mriedem    RUN_ON_REBUILD = True15:16
stephenfinmriedem: It's True and yes15:17
mriedemstephenfin: so then you need to put the stuff in the request spec if we're going through the scheduler during rebuild b/c the image changes15:17
mriedembecause image_props.get('hw_cpu_policy')] and image_props.get('hw_cpu_thread_policy')]15:17
mriedemif the image changes, the numa stuff can change15:17
mriedemstephenfin: rebuild isn't a move, but we have to validate the new image15:17
mriedem*validate the new image still works on the current host15:18
*** shaohe_feng has joined #openstack-nova15:18
sean-k-mooneymriedem: a rebuilt instance could land on a different host then the instace was on previously though right. its effectivly a new boot with the same port/volumes as the original instance15:19
*** samueldmq has quit IRC15:19
*** patrickeast has quit IRC15:19
mriedemsean-k-mooney: no15:19
mriedemsean-k-mooney: are you talking about evacuate?15:19
*** yikun has quit IRC15:19
*** test222___ has quit IRC15:19
*** csatari has quit IRC15:19
*** yamamoto has quit IRC15:20
sean-k-mooneyno i taught if we rebuilt and the previous host was nolonger valid we would schdule to another host that was15:20
sean-k-mooneyi gues we just fail to rebuild15:20
*** raorn has quit IRC15:20
*** andrewbogott has quit IRC15:20
*** d34dh0r53 has quit IRC15:20
*** lamt has quit IRC15:20
*** TheJulia has quit IRC15:20
*** theanalyst has quit IRC15:20
*** ispp has quit IRC15:20
*** Shilpa has joined #openstack-nova15:21
*** Hazelesque has quit IRC15:21
*** andreaf has quit IRC15:21
mriedemyou get a novalidhost15:21
*** patrickeast has joined #openstack-nova15:21
mriedemif the rebuild + new image doesn't fit on the current host15:21
mriedeminstance goes to error state and you have to fix it15:21
*** samueldmq has joined #openstack-nova15:21
*** raorn has joined #openstack-nova15:21
*** ispp has joined #openstack-nova15:21
mriedembauzas: ping https://review.openstack.org/#/c/583715/15:22
*** Hazelesque has joined #openstack-nova15:22
*** chason has quit IRC15:22
*** lamt has joined #openstack-nova15:22
*** csatari has joined #openstack-nova15:23
mriedembauzas: also ping https://review.openstack.org/#/c/581813/ - that's the nova-status check for request spec migrations which means if we get that in rocky, we can drop the reqspec migrations and compat code in stein15:23
mriedemwhich is something i desperatly want to do15:23
*** test222___ has joined #openstack-nova15:23
sean-k-mooneymriedem: right i was assuming we would hit the retry fileter and try another host but i guess not. in my mind i was assuming we did the host affinity for rebuil via a weigher rather then filtering to just the current host15:23
mriedemthat and spellcheck15:23
*** raorn has quit IRC15:23
*** raorn has joined #openstack-nova15:23
*** yikun has joined #openstack-nova15:23
mriedemsean-k-mooney: we pass a hint to the scheduler telling it to filter on the existing instance host15:23
*** Hazelesque has quit IRC15:24
*** Hazelesque has joined #openstack-nova15:24
*** chason has joined #openstack-nova15:24
*** felipemonteiro has joined #openstack-nova15:24
sean-k-mooneymriedem: cool ill look into how that work more closely in the future. good to know15:24
*** lamt is now known as Guest2358115:24
*** andreaf has joined #openstack-nova15:25
*** d34dh0r53 has joined #openstack-nova15:25
mriedemstephenfin: so i assume you might have 2 patches: 1 to add the physnet and tunneled plumbing to the nova.network.model.Network object and populate it during _build_network_info_model, and then another change to call some utils method in the various conductor spots to populate ReuqestSpec.network_metadata using instance.info_cache.network_info15:26
stephenfinmriedem: That's exactly what I have, albeit rolled into one patch15:26
mriedemstephenfin: btw, this change is doing the same call spots in conductor that you'll need https://review.openstack.org/#/c/583715/15:26
*** shaohe_feng has quit IRC15:26
stephenfinmriedem: However, are you sure about the "scheduler getting called" bit. Comments/logic in the code suggest otherwise mriedem: Are you sure. Your comments here say something else https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L901-L91615:26
*** shaohe_feng has joined #openstack-nova15:27
mriedemhttps://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L92015:27
stephenfinBy rebuild I'm referring to the 'openstack server rebuild $NAME" command15:27
mriedemnote the "*unless* a new image                                   #       was specified"15:27
stephenfinRiiiight, missed that15:28
mriedemthe rebuild_instance method in conductor manager is totally coupled to how the api code works15:28
stephenfinSo, what do I do in the "no new instance" case15:28
stephenfinHappily carry on?15:28
mriedemno request spec15:28
mriedem?15:28
sean-k-mooneymriedem: even if the same image is passed we should proably reschdule as the image metadata could have changed15:28
mriedemno new image?15:28
mriedemstephenfin: if the image doesn't change, we don't call the scheduler15:29
mriedemsean-k-mooney: yeah, maybe, which would be new logic in the api to detect that since we persist the original image properties on the instance system_metadata i think15:30
stephenfinmriedem: Right, so I can't recalculate NUMA affinity for any network changes. That's OK, yeah?15:30
dansmithmriedem: right, and I think we said that we shouldn't refuse a rebuild because an image has changed metadata since the user then has very little recourse15:30
mriedemdansmith: i don't remember talking about image meta changing on the original image, but ok15:31
dansmithI do15:31
sean-k-mooneymriedem: hum well if we are using the cached copy it should safe but if we pull them down from glance then we might violate one of the image requests or not be able to supprot one of them15:31
mriedemstephenfin: yes because we assume the network affinity on the same host for the same image hasn't changed15:31
stephenfinmriedem: Sweet15:32
stephenfinhttps://imgflip.com/i/2ejmw415:32
sean-k-mooneydansmith: mriedem do we also use the embeded flavor on rebuild? changes to image meta on rebuild is logically the same as changes to flavour extra specs so we should proably have the same behavior15:34
dansmithwe do15:34
*** imacdonn has quit IRC15:34
dansmithI'm not actually sure we do use the embedded _image_ properties for rebuild, but I'm saying I don't think that's a problem15:35
*** TheJulia has joined #openstack-nova15:35
mriedemhttps://github.com/openstack/nova/blob/master/nova/compute/api.py#L317215:35
sean-k-mooneyi think we dont15:35
dansmithbecause changing image metadata such that people can't continue to be on a host they're currently on is pretty bad15:35
dansmithand15:35
dansmithrunning instances aren't going to move, so not allowing a rebuild is very surprising to the user who knows nothing of such changes15:35
sean-k-mooneydansmith: it might be unitentionaly also image metadata and images can be set by enduesrs15:35
*** ragiman has quit IRC15:36
dansmithyes, but they don't see the scheduling policy15:36
*** shaohe_feng has quit IRC15:36
*** shaohe_feng has joined #openstack-nova15:38
*** imacdonn has joined #openstack-nova15:38
*** andrewbogott has joined #openstack-nova15:38
sean-k-mooneydansmith: so ya i just checked locally we do use the updated image meta on rebuild15:39
*** manjeets has joined #openstack-nova15:40
*** alexchadin has quit IRC15:44
*** itlinux has joined #openstack-nova15:44
sean-k-mooneyi guess this is one of those things that an operator should not do. i would feel more comfortable with always going to the schduler but i guess that would be a behavior change so it would need at least a microversion bump.15:46
*** abhishekk has joined #openstack-nova15:46
*** ispp has quit IRC15:47
*** shaohe_feng has quit IRC15:47
*** mdbooth has quit IRC15:47
*** andrewbogott has quit IRC15:48
*** andrewbogott has joined #openstack-nova15:48
*** hshiina has quit IRC15:49
sean-k-mooneystephenfin: fyi, when cpus and memory are modeled in placement as the numa topoloy can be altered via the image metadata you will have to recalulate it on rebuild and check if the placement allocation still fufil the request even when we use the same image since we do not use a cached copy of the image metadata.15:50
*** lei-zh has joined #openstack-nova15:50
*** gyee has joined #openstack-nova15:51
*** lpetrut has quit IRC15:53
stephenfinsean-k-mooney: Sounds fair. Best tell jaypipes to get a move on then ;)15:53
s10Hi. Is there any possibility to somehow optimise host_state.update(), which runs on every instance scheduling? Specifically this: https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L18115:53
s10Our tests show, that this step (loading list of instances to the host_state) takes ~10 seconds for deployments with thousands of instances and hundreds of hosts.15:53
s10So if we want to start 1000 new instances with 6 nova-scheduler process, without this step (if we commented it out), all of them end up being started tens of minutes faster.15:53
*** shaohe_feng has joined #openstack-nova15:54
sean-k-mooneystephenfin: well personally i think simply always going to the schduler on a rebuild would be a better change since the numatopolgy filter would assert the correct behavior15:55
cdents10: I'd recommend posting to the openstack-dev list about that. It's a topic that I've seen come up from multiple peope lately, and they're not all here rightnow.15:55
*** udesale has quit IRC15:56
mriedems10: yeah it's a known issue, i have a semi-related patch, sec15:56
mriedems10: https://review.openstack.org/#/c/569247/15:57
s10I see https://bugs.launchpad.net/nova/+bug/173746515:57
openstackLaunchpad bug 1737465 in OpenStack Compute (nova) "[cellv2] the performance issue of cellv2 when creating 500 instances concurrently" [Medium,In progress] - Assigned to Matt Riedemann (mriedem)15:57
s10We use Pike15:57
*** shaohe_feng has quit IRC15:57
sean-k-mooneymriedem: s10 is this not required to make sure we are not using statle hostsate info?15:57
mriedems10: yes same related bug15:57
*** shaohe_feng has joined #openstack-nova15:57
mriedemsean-k-mooney: yes it is15:58
mriedemfor the affinity filters15:58
mriedems10: for starters, i've been hoping someone with a large enough deployment can tell me if this makes an improvement https://review.openstack.org/#/c/569247/ because CERN was reporting the same issue15:58
mriedems10: if you can test that out we could move it forward15:59
sean-k-mooneymriedem: so commenting it out while faster would be incorrect unless we updated the afinit filters to get the updated info but that would break multicreate15:59
mriedemthere are more ways to optimize these calls15:59
*** rpittau has quit IRC15:59
s10Yes, we can't really comment them out, because we rely on the anti-affinity filter for the octavia load-balancers.15:59
mriedemthe information is also somewhat cached and the computes rpc cast to the scheduler whenever an instance is created/deleted/moved assuming you have that setup16:00
s10And we use host_state.instances in our custom RealRamFilter...16:00
mriedemthat's the track_instance_changes config option,16:00
*** dave-mccowan has quit IRC16:00
mriedemhttps://docs.openstack.org/nova/latest/configuration/config.html#filter_scheduler.track_instance_changes16:01
*** s1061123 has quit IRC16:01
*** martin__ has joined #openstack-nova16:01
mriedemif you're doing split MQ though then the comptues can't reach the scheduler16:01
mriedemand that doesn't help16:01
mriedemwe also know that we can optimize here https://review.openstack.org/#/c/571928/2/nova/scheduler/host_manager.py with some db join magic16:02
sean-k-mooneymriedem: looking at https://review.openstack.org/#/c/569247 the optimisationis storing a list of uuids per host rather then the full instance objects correct? i can see how that would work for the in tree affintiy filters and the num instance weigher16:02
mriedemsean-k-mooney: well it's also the db query16:03
*** mdbooth has joined #openstack-nova16:03
mriedemrather than query the full instance objects and such per host, just get the uuids16:03
*** rpittau has joined #openstack-nova16:04
mriedems10: if you can test out https://review.openstack.org/#/c/569247/ and report back that would be very helpful in moving this forward16:04
sean-k-mooneymriedem: sure that makes sense.16:04
cdentmriedem, s10: whatever you work out here, it would still be great to see some kind of summary to the mailing list16:04
s10mriedem: Ok, I will test it16:05
s10mriedem: could this change be cherry-picked without rework to Pike?16:05
sean-k-mooneys10 it looks pretty trivial in terms of code change. this would not qualify for backport however as it is not fixing a bug. it is a performance enhancement16:06
*** shaohe_feng has quit IRC16:07
mriedems10: probably, there was another change merged in the series before it that you'll need https://review.openstack.org/#/q/topic:bug/1737465+(status:open+OR+status:merged)16:08
*** shaohe_feng has joined #openstack-nova16:08
mriedemhttps://review.openstack.org/#/q/Iccefbfdfa578515a004ef6ac718bac1a49d5c5fd16:08
mriedemyou'll need that in pike first16:09
mriedemand then https://review.openstack.org/#/c/569247/16:09
*** sahid has quit IRC16:09
*** dave-mccowan has joined #openstack-nova16:09
s10Our out-of-tree filter rely on host_state.instances.values(), we need values of the instance.memory_mb. Will we be hit with a lazy-load penalty in this case, with https://review.openstack.org/#/c/570083/?16:15
*** lei-zh has quit IRC16:15
*** blkart has quit IRC16:16
dansmithyup16:16
*** blkart has joined #openstack-nova16:17
*** shaohe_feng has quit IRC16:17
sean-k-mooneys10: what does your real ram filter actully check vs what placement will do?16:18
sean-k-mooneys10: are you trying to disable oversubscription?16:19
*** shaohe_feng has joined #openstack-nova16:19
s10sean-k-mooney: actual usage of the ram on compute nodes. Every QEMU process produces some memory overhead (up to 500-1000mb in some cases, depends on disk usage and rbd cached, I believe). Placement doesn't know anything about it and can schedule instance to the host, where real size of free ram is less than reserved_memory_mb.16:20
*** AlexeyAbashkin has quit IRC16:20
mriedemyeah we don't track overhead in placement, that's a known thing16:20
mriedemand we've said for now, buffer that with reserved_host_memory_mb16:21
sean-k-mooneys10: how are you getting the real host memory usage?16:21
mriedems10: also fyi http://lists.openstack.org/pipermail/openstack-dev/2018-May/130624.html16:23
s10We patched nova/scheduler/host_manager.py, added self.memory_mb_used = compute.memory_mb_used16:23
mriedems10: then why would you need host_state.instances.values()?16:23
*** dave-mccowan has quit IRC16:23
s10Because without it we can't compute reserved_memory_mb, it's in config...16:23
*** theanalyst has joined #openstack-nova16:23
openstackgerritMatt Riedemann proposed openstack/nova master: Heal RequestSpec.is_bfv for legacy instances during moves  https://review.openstack.org/58371516:24
openstackgerritMatt Riedemann proposed openstack/nova master: Fix wonky reqspec handling in conductor.unshelve_instance  https://review.openstack.org/58373916:24
openstackgerritMatt Riedemann proposed openstack/nova master: Add shelve/unshelve wrinkle to volume-backed disk func test  https://review.openstack.org/58493116:24
openstackgerritMatt Riedemann proposed openstack/nova master: Cache is_bfv check in ResourceTracker  https://review.openstack.org/58496216:24
s10Maybe we should pass reserved_memory_mb same way as we pass memory_mb_used...16:24
*** dave-mccowan has joined #openstack-nova16:24
sean-k-mooneys10: it would make sense to me to just embed the reserved memory in the host state object16:25
mriedemto be clear, CONF.reserved_host_memory_mb is used to reserve capacity for MEMORY_MB in the compute node resource provider's inventory in placement16:25
mriedemwhich is used to filter hosts before they even get to your filter16:25
*** Bhujay has quit IRC16:25
mriedemif you need to reserve space on the host for qemu/rbd, you should increase reserved_host_memory_mb per host16:25
s10But it is still calculated per compute, based on the config in nova-compute, right?16:26
mriedemthe config is read in compute yes16:26
mriedemcompute node memory_mb_used is later adjusted in the resource tracker based on the instance flavor16:27
mriedemper instance on that host16:27
sean-k-mooneymriedem: ture but s10's filter would catch the case where they did not reserve enough and the free ram is actully less then the reserved16:27
mriedembut that information is also available via placement and is used to calculate the allocation candidates that the scheduler gets before we even hit the filters16:27
*** shaohe_feng has quit IRC16:28
mriedemsean-k-mooney: you might need to be conservative then in the reserved memory_mb16:28
sean-k-mooneymriedem: placement only has allocations based on the flavor request. not the actul memory used by the instance16:28
mriedemif this is a persistent problem16:28
mriedemKevin_Zheng: fyi https://review.openstack.org/#/c/584962/16:29
s10We used reserved_host_memory_mb for that purpose, but it doesn't work well for us, some instances produces memory overhead over time, and in this case we might end up reserving 50% of host memory16:29
sean-k-mooneymriedem: im just wondering could we symplify this by comparing free_ram_mb > reseved in the fileter if we added reserved to the hostsate object16:29
*** ekhugen has quit IRC16:30
*** egarbade has quit IRC16:30
mriedems10: hmm, ok, it would be helpful to write something up about this problem in the openstack-dev mailing list, tag the subject line with [nova] and describe the issue and what your scheduler filter does to resolve it16:30
*** shaohe_feng has joined #openstack-nova16:30
*** dave-mccowan has quit IRC16:30
mriedems10: upstream changes only affect out of tree filters while those filters are out of tree,16:30
mriedemif your filter were in tree, we would have considered this when making that change16:30
*** s1061123 has joined #openstack-nova16:30
*** mdrabe has quit IRC16:31
sean-k-mooneys10: well one of the main issue with reserved_host_memory_mb is that it does not take account of numa topology of the host so your instance can be killed by oom if you are not useing hugepages and a numa node is exausted but non local memory is free16:31
mriedemsean-k-mooney: maybe, but solutions should be discussed in the ML16:31
s10Thank you. I will test performance with fixes for the host_state, and ask our developers to change our filter not to use host_state.16:31
sean-k-mooneymriedem: sure :) it was just a taught16:31
mriedemmostly just because this is a bad week with FF on thursday16:32
mriedemdon't really have time to design solutions for things that can go into the ML16:32
*** ekhugen has joined #openstack-nova16:34
*** s1061123_ has joined #openstack-nova16:34
sean-k-mooneys10: is there a bug open for your usecase? its 2 late to adress in rocky but we could likely adrss in early stien if we captured the request.16:35
*** s1061123 has quit IRC16:35
*** egarbade has joined #openstack-nova16:35
s10sean-k-mooney: I didn't see bugs, related to real memory overhead problem. Only remember, that there was a thread in openstack-operators (?)16:38
*** shaohe_feng has quit IRC16:38
*** shaohe_feng has joined #openstack-nova16:39
s10https://bugs.launchpad.net/nova/+bug/168385816:40
openstackLaunchpad bug 1683858 in OpenStack Compute (nova) "Allocation records do not contain overhead information" [Medium,Won't fix]16:40
*** betherly_ is now known as betherly16:40
sean-k-mooneys10: based on the wording i assume that was suggesting this in placement hence the wont fix.16:41
sean-k-mooneys10: i dont think placement is the right place to adress this but an in tree filter would be potentially reasonable.16:41
*** dave-mccowan has joined #openstack-nova16:43
mriedemstephenfin: we've got a runway slot opening so i'm going to throw the numa vswitch series back in ther16:44
mriedem*there16:44
mriedemjust FYI16:44
*** armaan has quit IRC16:45
stephenfinSweet. Should have that move thing done in a short bit16:45
*** armaan has joined #openstack-nova16:45
*** pcaruana has quit IRC16:47
*** shaohe_feng has quit IRC16:48
*** dklyle has joined #openstack-nova16:49
*** ccamacho has quit IRC16:49
sean-k-mooneys10: i wont promise anything but i have added this usecase to my whiteboard of random TODOs. i might see if i can come up with somthing for stien if there is still interest.16:49
*** AJaeger has joined #openstack-nova16:50
AJaegernova cores, could you review https://review.openstack.org/#/c/583023/ to move the job in-tree, please? that'S a followup to work for os-vif. stephenfin and sean-k-mooney, want to look at it again, please?16:50
*** shaohe_feng has joined #openstack-nova16:51
stephenfinAJaeger: ack16:52
stephenfinlyarwood: I didn't get to https://review.openstack.org/#/c/562072/ yet :( It's first thing I'm doing tomorrow morning though, I promise16:53
mriedemdansmith should probably look at those16:53
mriedemgiven evacness16:53
stephenfinmriedem: Suits me down to the ground16:53
sean-k-mooneyAJaeger: will nova beable to import the job from os-vif? i just kicked off an experimental job to make sure it all works16:54
*** s10 has quit IRC16:55
*** tssurya has quit IRC16:55
*** _pewp_ has quit IRC16:56
openstackgerritMerged openstack/nova master: perform reshaper operations in single transaction  https://review.openstack.org/58238316:57
*** _pewp_ has joined #openstack-nova16:57
openstackgerritMerged openstack/nova master: Refactor _heal_instances_in_cell  https://review.openstack.org/57789616:57
AJaegersean-k-mooney: that'S how zuul was designed ;)16:58
AJaegersean-k-mooney: but yeah, I just have done that - thanks16:58
*** shaohe_feng has quit IRC16:58
AJaegerthanks, stephenfin16:59
*** shaohe_feng has joined #openstack-nova16:59
*** adrianc_ has joined #openstack-nova16:59
AJaegersean-k-mooney: it's "check experimental"17:00
sean-k-mooneyAJaeger: os-vif has to be whitelisted in the tenant config to suppy job definitons... that said it is in project-config  already is so ya i guess this should work.17:00
AJaegersean-k-mooney: all active repos are in that list ;)17:00
sean-k-mooneyAJaeger: ya i was just getting a little confused with how i was configuring my thridparty ci when i was playying with zuulv317:01
*** GonZo2000 has quit IRC17:01
*** felipemonteiro has quit IRC17:01
*** felipemonteiro has joined #openstack-nova17:02
*** tesseract has quit IRC17:02
AJaeger;)17:02
*** derekh has quit IRC17:02
AJaegersean-k-mooney: the job is scheduled to run according to zuul.openstack.org, so it's fine.17:02
*** felipemonteiro_ has joined #openstack-nova17:02
*** adrianc_ has quit IRC17:04
sean-k-mooneyAJaeger: yep i was just checking that myself17:04
openstackgerritElod Illes proposed openstack/nova stable/queens: Call generate_image_url only for legacy notification  https://review.openstack.org/58496917:05
*** mvk_ has quit IRC17:05
*** gongysh has joined #openstack-nova17:05
AJaegerok, hope another core will review the job change in 583023 then - so that we can cleanup the infra files.17:06
*** felipemonteiro has quit IRC17:07
*** shaohe_feng has quit IRC17:09
sean-k-mooneyAJaeger: two quick questions by the way. i plan on converting it to a non legacy job. are there good examples of a vannily devstack job i can base it off. and 2 have ye updated the zuul from scratch to cover creating your own base job yet?17:10
*** shaohe_feng has joined #openstack-nova17:10
sean-k-mooneyAJaeger: perhaps those are better asked on the zuul/infra channels instead.17:11
*** vivsoni__ has joined #openstack-nova17:11
AJaegersean-k-mooney: for your second question: better ask on #zuul - I'm not involved there. For the devstack job, best ask andreaf on #openstack-qa. I know he converted some but don't know which one is a good example. You might want to search using codesearch, e.g. http://codesearch.openstack.org/?q=parent%3A%20devstack&i=nope&files=&repos=17:12
sean-k-mooneyAJaeger: thanks. its too late for rocky but i hope to convert the os-vif legacy job to non legacy and add a linux bridge version in the next month or so17:14
kashyapcfriesen_: Thanks for the quick review17:17
AJaegersean-k-mooney: IMHO never too late to convert it ;)17:18
*** shaohe_feng has quit IRC17:19
*** shaohe_feng has joined #openstack-nova17:20
sean-k-mooneyAJaeger: well what i ment is we are past non-client ff so it wont be on the stable/rocky branch unless we backport it17:22
*** gongysh has quit IRC17:24
*** dtantsur is now known as dtantsur|afk17:24
*** s1061123_ has quit IRC17:26
*** felipemonteiro_ has quit IRC17:27
*** felipemonteiro_ has joined #openstack-nova17:27
*** s1061123 has joined #openstack-nova17:28
*** shaohe_feng has quit IRC17:29
*** shaohe_feng has joined #openstack-nova17:31
*** felipemonteiro_ has quit IRC17:31
*** felipemonteiro has joined #openstack-nova17:33
*** felipemonteiro_ has joined #openstack-nova17:35
*** david-lyle has joined #openstack-nova17:36
*** dklyle has quit IRC17:37
*** felipemonteiro has quit IRC17:39
*** yamahata has quit IRC17:39
mriedemstephenfin: heh, sorry, just meant dan has special context on that code17:39
mriedemso he should (also) review it17:39
*** shaohe_feng has quit IRC17:39
*** shaohe_feng has joined #openstack-nova17:40
*** swamireddy has quit IRC17:44
*** mvk_ has joined #openstack-nova17:44
*** lpetrut has joined #openstack-nova17:46
*** shaohe_feng has quit IRC17:50
*** armaan has quit IRC17:50
*** armaan has joined #openstack-nova17:51
*** shaohe_feng has joined #openstack-nova17:51
*** anupn_ has joined #openstack-nova17:52
*** karimull has quit IRC17:52
sean-k-mooneydo you ever read code and have to fight the urge to delete it all.17:52
*** anupn has quit IRC17:53
*** manjeets has quit IRC17:53
*** manjeets has joined #openstack-nova17:53
*** karimull has joined #openstack-nova17:54
*** shaohe_feng has quit IRC18:00
*** shaohe_feng has joined #openstack-nova18:01
*** armaan has quit IRC18:01
*** armaan has joined #openstack-nova18:01
*** med_ has quit IRC18:02
AJaegersean-k-mooney: ah, yes18:02
*** david-lyle has quit IRC18:04
*** dklyle has joined #openstack-nova18:04
*** itlinux has quit IRC18:05
mriedemzzzeek: is there any major difference between doing a select query filter with == None vs == null() https://review.openstack.org/#/c/584504/3/nova/objects/instance_mapping.py@156 ?18:05
zzzeekmriedem: shouldn't make a difference18:06
mriedemok thanks18:06
*** armaan has quit IRC18:06
*** david-lyle has joined #openstack-nova18:07
*** armaan has joined #openstack-nova18:07
zzzeekmriedem: null() is helpful in other cases where None might mean something different, like you want to force a SQL expression in some cases.  but here == None will do "IS NULL" anyway18:07
*** dklyle has quit IRC18:07
openstackgerritMatt Riedemann proposed openstack/nova master: Use consumer generation in _heal_allocations_for_instance  https://review.openstack.org/57790518:10
*** r-daneel has quit IRC18:10
*** shaohe_feng has quit IRC18:10
*** shaohe_feng has joined #openstack-nova18:11
*** yamahata has joined #openstack-nova18:12
*** luzC has quit IRC18:12
*** rmart04 has joined #openstack-nova18:12
*** rmart04 has quit IRC18:13
mriedemdansmith: i'm +2 on your queued_for_delete migration, i guess we can rebase the series to swap those18:13
dansmithcool18:13
mriedemlooks like powervm might have some ci issues http://184.172.12.213/17/560317/30/check/nova-in-tree-pvm/bf5d5bc/logs/stack.sh.txt.gz18:15
mriedemerror: command 'powerpc64le-linux-gnu-gcc' failed with exit status 118:15
mriedemerror: PIC register clobbered by ‘r30’ in ‘asm’18:15
mriedempowerkvm ci failing on the same https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/17/560317/30/check/tempest-dsvm-full-xenial/ac71b2d/devstacklog.txt.gz18:16
*** luzC has joined #openstack-nova18:16
mriedemedmondsw: ^18:16
edmondswmriedem yep, we're aware, have a fix proposed to requirements to block greenlet 0.4.1418:17
mriedemhttps://pypi.org/project/greenlet/0.4.14/18:17
mriedemah cool18:17
edmondswalso broken the KVM CI from what I heard18:17
edmondswbroke*18:17
mriedemit did18:17
edmondswgetting a little pushback from the requirements guys, so we'll see how this goes18:17
edmondswhttps://review.openstack.org/#/c/584881/18:18
mriedemyeah i'm looking at it18:18
edmondswjust posted a comment in response18:18
mriedemhmm, so in the before times we would have also blacklisted greenlet 0.4.14 in global-requirements.txt,18:19
mriedembut that's per-project now,18:19
mriedemso i'm wondering if nova can just blacklist 0.4.14 in nova's requirements.txt?18:20
mriedemsmcginnis: do you know ^ ?18:20
*** shaohe_feng has quit IRC18:20
smcginnismriedem: Yeah, I believe Nova can just block that now.18:21
*** sridharg has quit IRC18:21
*** shaohe_feng has joined #openstack-nova18:21
*** sridharg has joined #openstack-nova18:21
*** AJaeger has left #openstack-nova18:22
*** david-lyle is now known as dklyle18:22
*** sridharg has quit IRC18:25
*** AlexeyAbashkin has joined #openstack-nova18:25
*** abhishekk has quit IRC18:26
smcginnisFWIW, until the gcc issue gets clarified I think we should block it in requirements too.18:27
*** swamireddy has joined #openstack-nova18:27
openstackgerritMerged openstack/nova master: Rename auth_uri to www_authenticate_uri  https://review.openstack.org/57682018:27
*** shaohe_feng has quit IRC18:31
*** vivsoni__ has quit IRC18:31
*** felipemonteiro_ has quit IRC18:33
*** shaohe_feng has joined #openstack-nova18:33
*** felipemonteiro_ has joined #openstack-nova18:34
*** med_ has joined #openstack-nova18:34
*** med_ has quit IRC18:34
*** med_ has joined #openstack-nova18:34
*** shaohe_feng has quit IRC18:41
*** shaohe_feng has joined #openstack-nova18:42
openstackgerritsean mooney proposed openstack/nova master: fix disk_bus handeling  https://review.openstack.org/58499918:43
*** med_ has quit IRC18:45
*** tbachman has quit IRC18:45
*** AlexeyAbashkin has quit IRC18:45
*** lbragstad_ has joined #openstack-nova18:47
*** lbragstad has quit IRC18:48
*** med_ has joined #openstack-nova18:48
*** med_ has quit IRC18:48
*** med_ has joined #openstack-nova18:48
*** lbragstad_ is now known as lbragstad18:51
*** shaohe_feng has quit IRC18:51
*** shaohe_feng has joined #openstack-nova18:52
*** tbachman has joined #openstack-nova18:54
openstackgerritMerged openstack/nova master: Func test for improper cn local DISK_GB reporting  https://review.openstack.org/58364618:55
openstackgerritMerged openstack/nova master: [placement] disallow additional fields in allocations  https://review.openstack.org/58390718:56
*** shaohe_feng has quit IRC19:01
*** felipemonteiro_ is now known as felipemonteiro19:02
*** arvindn05 has joined #openstack-nova19:03
*** arvindn05 has left #openstack-nova19:03
*** felipemonteiro_ has joined #openstack-nova19:04
*** cdent has quit IRC19:04
*** shaohe_feng has joined #openstack-nova19:05
*** felipemonteiro has quit IRC19:07
*** tbachman has quit IRC19:10
*** shaohe_feng has quit IRC19:12
*** shaohe_feng has joined #openstack-nova19:14
mriedemefried: if you agree with my comments on https://review.openstack.org/#/c/560317/ i'll update those quick19:15
*** blkart has quit IRC19:15
efriedlooking19:16
*** blkart has joined #openstack-nova19:16
*** tbachman has joined #openstack-nova19:16
mriedemand i'll probably blacklist greenlet 0.4.14 in a change below this so we can get the powerkvm ci passing again19:17
efriedmriedem: I assume https://review.openstack.org/#/c/560317/30/nova/virt/libvirt/driver.py@8940 you meant, "I'd make this an info"19:18
efriedmriedem: I'm fine if you make those changes, sure.19:18
mriedemyeah heh19:18
mriedemok will do19:18
efriedkashyap: You good with https://review.openstack.org/#/c/560317/ at this point?19:18
mriedemkashyap is likely done for the day19:19
*** felipemonteiro_ has quit IRC19:20
*** felipemonteiro_ has joined #openstack-nova19:21
*** shaohe_feng has quit IRC19:22
*** shaohe_feng has joined #openstack-nova19:23
*** shaohe_feng has quit IRC19:32
*** shaohe_feng has joined #openstack-nova19:33
*** eharney has quit IRC19:35
*** mdbooth has quit IRC19:39
*** shaohe_feng has quit IRC19:42
*** shaohe_feng has joined #openstack-nova19:43
*** janki has quit IRC19:47
*** r-daneel has joined #openstack-nova19:47
openstackgerritMatt Riedemann proposed openstack/nova master: Add method to get cpu traits  https://review.openstack.org/56031719:53
openstackgerritMatt Riedemann proposed openstack/nova master: FakeLibvirtFixture: mock get_fs_info  https://review.openstack.org/57920119:53
openstackgerritMatt Riedemann proposed openstack/nova master: Blacklist greenlet 0.4.14  https://review.openstack.org/58501619:53
*** shaohe_feng has quit IRC19:53
mriedemedmondsw: ^19:53
*** felipemonteiro_ has quit IRC19:53
*** felipemonteiro_ has joined #openstack-nova19:54
*** shaohe_feng has joined #openstack-nova19:54
edmondswmriedem +119:55
edmondswmmedvede ^19:55
*** shaohe_feng has quit IRC20:03
*** hongbin has quit IRC20:05
mnaserlols here's interesting behaviour20:06
*** shaohe_feng has joined #openstack-nova20:07
mnaserlist doesn't hit cells so vms that were stuck in 'scheduling' are shown when you list the vms in horizon20:07
mnaserbut then as horizon tries to 'refresh' them by doing a GET, nova returns a 40420:07
mnaserso they disappear afterwards20:07
dansmithmnaser: what do you mean by "list doesn't hit cells" ?20:07
dansmithalso, GET on a scheduling vm shouldn't return a 40420:08
mnaserdansmith: well those are instances which seem to have gotten somehow stuck in 'scheduling' status20:08
mnaserok, let me verify this20:08
dansmithoh, if they're scheduling they're not created in any cell, maybe that's what you mean, but list should still show them from their buildrequest of course20:08
*** brault has quit IRC20:08
dansmithand GET during/after should all work20:09
mnaserwell list seems to show them, but GET gives a 404 afaik20:09
*** edmondsw has quit IRC20:09
mnaserim double checking the behaviour20:09
mnaseryeah, they show up in list, but GET gives 40420:09
dansmithsomething's broken then20:10
dansmiththat shouldn't happen20:10
mnaserwell i guess the db got in some weird state20:10
mnaseror even if the db is mucked it shouldn't be like this?20:10
dansmithwell, depends on the level of mucking I guess, but.. it should never be like this20:11
mnaserso as i understand it, list just grabs stuff from the 'api' db, but the 'get' actually hits the cell20:11
dansmithno20:11
dansmithlist grabs stuff from the api and cell databases together20:11
mnaserso it must know the mapping too i guess20:12
dansmithget will pull the mapping from the api db, and if it looks like it is scheduled, will talk to the cell, and if not will return the build request data20:12
*** jmlowe has joined #openstack-nova20:12
mnaserah okay20:12
mnaserso it's in a state where it's doing neither talk to cell or return build request data20:12
dansmithif it'20:12
dansmithif it is 404'ing a scheduling instance,20:12
dansmiththen it's getting the mapping and then not returning the buildrequest or something20:13
*** shaohe_feng has quit IRC20:13
dansmithmnaser: all this logic is fairly straightforward here: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2298-L235720:14
dansmithstart with L232820:14
dansmithwe get the mapping (which should always exist once we've returned a uuid to the user)20:14
dansmithmaybe check to see if that failed to get written?20:14
mnaserlet me check the db mapping20:14
dansmithif there's no mapping but it did get created in a cell, that would cause it to show up in list and not get20:14
dansmithbecause of L2355 there20:15
*** brault has joined #openstack-nova20:15
mnasercell_id=NULL in the db20:15
dansmiththat's what it should be for scheduling20:15
mnaserso it should def go into the elif20:15
dansmiththat triggers L2333 to get it from the api db's buildrequest20:16
mnaserlet me check the build request20:16
mnaserno build_request20:16
mriedemi have a patch for this20:16
mriedemhttps://review.openstack.org/#/c/575556/ ?20:16
*** jmlowe has quit IRC20:16
mriedembut that's listing, not showing20:16
mriedemsounds similar though20:16
mriedembuild request is gone, instance mapping isn't pointing at a cell20:17
dansmithand it's marker20:17
dansmithhow does that situation happen?20:17
mriedemdo not know20:17
mnaseri mean20:17
*** shaohe_feng has joined #openstack-nova20:17
dansmiththis patch doesn't address his problem,20:17
mnaserrabbitmq had a field day a few days ago for us20:17
dansmithbut papers over it for list I guess20:17
mnaserso i would totally attribute it to anything related to that20:17
mriedemi believe jroll was seeing similar20:17
dansmithmnaser: mm, shouldn't really as we don't use rabbit to create the instance in the cell db20:18
dansmithwell,20:18
mnaseroh true20:18
dansmithunless we dropped something between superconductors or something20:18
mnaserno superconductor here20:18
mnaser1 cell, 1 conductor20:18
dansmiths/super//20:18
mriedemlast i looked at this, we do have a window between the time we delete the build request and set the instance mapping cell20:18
*** felipemonteiro__ has joined #openstack-nova20:18
dansmithmriedem: we should be setting the mapping and then deleting the BR20:19
mnaserwouldn't it be safer to set the instance mapping first and then delete the br?20:19
mnaseryeah ^20:19
dansmithbecause that's how the get logic expects it to work20:19
dansmithif the mapping is set, then BR is ignored20:19
dansmithso we can delete it late20:19
dansmithand that's what we're doing20:19
mriedemschedule_and_build_instances in the conductor does set the cell in the instance mapping and then attempt to delete the build request,20:19
mriedembut the build request can be deleted by the api first20:20
dansmithhttps://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L1155-L118220:20
dansmiththat's for cell020:20
dansmithwhich presumably is what his situation is if it never scheduled20:20
mriedemnot sure why we'd pass here https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L117820:20
dansmithif it got deleted20:21
mriedemthe instance mapping?20:21
dansmithon the non-cell0 case we also target the mapping before deleting the BR20:21
mriedemwhy would that get deleted during scheduling20:21
mnaseris it possible this happened when a vm was quickly deleted while it was scheduled20:21
dansmithmriedem: if it got deleted by the user I mean20:21
mriedemthe instance mapping isn't deleted when the instance is deleted20:21
dansmithmriedem: and we did a local delete because it wasn't scheudled20:21
dansmithon local delete?20:21
mriedemno20:21
mriedemonly on archive20:21
mnaserlet me check the actual cell db20:22
*** felipemonteiro_ has quit IRC20:22
dansmithmriedem: I think we delete them somewhere else20:22
dansmithmulti-create maube?20:22
mnaserso this went to cell020:22
mnaserand it's state in cell0 is 'scheduling'20:22
mriedemdansmith: i'm pretty sure not, because that's what bauzas had originally written and we were against it in case the actual delete in the compute failed20:23
mnaserdeleted=0 in cell020:23
mnaserso it's not even deleted20:23
dansmithmriedem: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L127120:23
mnasermaybe this is something in the bury in cell0 code20:23
mriedemdansmith: ok so before we even get to conductor20:23
*** brault has quit IRC20:23
dansmithyeah fair20:23
*** shaohe_feng has quit IRC20:23
mriedemif the instance mapping is gone and the build request is gone, shouldn't be able to list it20:23
*** brault has joined #openstack-nova20:23
dansmithwe will though20:24
dansmithbecase we'll just hit each db and list anything we find, mappings be damned20:24
mriedembut if we deleted the build request and instance mapping in ^20:24
mriedemwe don't get to conductor to schedule20:24
mriedemso we don't create the instance in any cell20:25
*** shaohe_feng has joined #openstack-nova20:25
dansmithyeah, in the delete_build_artifacts case yep, I meant if we end up with an instance in a cell with no mapping,20:25
dansmithwe'll still list it20:25
mriedemsure, i just don't know how that could happen20:25
dansmithwell, I'm not sure how we could end up with a deleted BR and untargeted instance mapping20:26
*** felipemonteiro__ has quit IRC20:29
*** felipemonteiro__ has joined #openstack-nova20:29
mriedemso we could delete a build request here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L184820:30
mriedemwhile scheduling20:30
mnaserthis was deleted via the api (while scheduling)20:30
mnaserit def didnt fail to schedule20:30
*** lpetrut has quit IRC20:30
mriedemassuming we deleted the build request in the api, the api would check to see if the instance mapping is pointing at a cell yet https://github.com/openstack/nova/blob/master/nova/compute/api.py#L176020:31
dansmithif we do that,20:31
dansmithwe should also delete the instance in the cell db if we race with the conversion from BR to instance20:31
dansmithbut maybe we're slipping through those cracks20:31
*** alexpilotti has joined #openstack-nova20:31
dansmithhere: https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L118420:32
dansmithnot really sure how that could be wrong tbh20:32
dansmitheither we fail to delete it "during booting" and then fall through to regular delete,20:33
mriedemmnaser: so you have any old nova-osapi_compute services? https://github.com/openstack/nova/blob/master/nova/compute/api.py#L180320:33
dansmithor we succeed, conductor tries/fails to delete the BR, and destroys the instance20:33
mriedem*do you have20:33
dansmithor old service records20:33
mnaserlet me check the db rather than service-list20:33
mriedemservice list doesn't show api servies20:33
mriedemso yeah you have to check the db20:33
*** shaohe_feng has quit IRC20:34
mriedemyou could have some api services with version 0 from running with wsgi before we fixed that?20:34
*** slaweq has quit IRC20:34
*** shaohe_feng has joined #openstack-nova20:34
mnaserthere are some stale records but i see 16/22/3020:34
*** eharney has joined #openstack-nova20:34
mnasercan i safely delete those older ones in the db20:35
mnaser(no 0's though)20:35
* dansmith checks to see if he has anything on vexxhost20:35
*** slaweq has joined #openstack-nova20:35
mnaserhaha20:35
mriedemit's checking for version < 15 so those shouldn't be a problem for this issue20:35
mnasertruncate table services;20:35
mnaser"it'll autopopulate"20:35
*** itlinux has joined #openstack-nova20:35
*** alexpilotti has quit IRC20:36
mriedemdansmith: umm, couldn't we have an instance mapping with no cell mapping if we hit this? https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L124420:36
mriedemapi deletes the build request, we catch it and just continue20:37
dansmithinstance mapping with no cell is not a problem if the instance is deleted from the cell20:37
mriedemin ^ the instance wouldn't be created in a cell20:37
mnaserthis instance was created in cell0 though (i checked via the db)20:38
dansmithmriedem: then it wouldn't fit his problem20:38
mnaseris _bury_in_cell0 the only codebase that puts things into cell0?20:38
dansmithyeah20:39
mnaserso we know it got at least to here - https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L115520:39
mnaserlet me check if it created bdms20:39
dansmithshould have,20:40
dansmithnothing to stop it there I think20:40
dansmithit must not have hit 1183 because if so, the instance would be deleted20:40
mnaserare bdms created when one is given?20:40
mnasercause: select * from block_device_mapping where instance_uuid='f5ce0c5f-0484-496f-a497-6d1a1fb370d3'; => nada20:41
dansmithwhen one is _not_ given?20:41
dansmithI think we can have no BDMs here20:41
mnaseryes sorry, when one is not given20:42
mriedemwhen you're not booting from volume,20:42
mnaserhmm20:42
mriedemi want to say we create a bdm record for the local image20:42
mnaserthe status should be ERROR but the status in cell0 is not error20:42
*** yamamoto has joined #openstack-nova20:42
mnaserstate in cell0 is building/scheduling20:43
mnaserwhich it should not be?20:43
mriedem_set_vm_state_and_notify probably failed then20:43
dansmithI'm not sure where/when it goes to error20:43
mriedemhttps://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L116620:43
mriedemupdates = {'vm_state': vm_states.ERROR, 'task_state': None}20:43
dansmithmaybe it failed on a task_state conflict?20:43
mriedemscheduler_utils.set_vm_state_and_notify does a few things...20:43
mnaserthis should all be in the conductor right?20:44
dansmithyeah20:44
mnaserjust to look at logs20:44
*** shaohe_feng has quit IRC20:44
*** r-daneel_ has joined #openstack-nova20:44
dansmithoh20:44
dansmiththat could be the rabbit connection20:44
*** r-daneel has quit IRC20:44
*** r-daneel_ is now known as r-daneel20:44
dansmithtrying to send the notify20:44
dansmithamirite?20:44
mriedemwe send the notification last,20:45
mriedemand save the instance changes before that20:45
dansmithah20:45
mriedemhttps://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L60020:45
dansmithdoes get_notifier() fail if we can't talk to rabbit?20:45
mriedemno idea20:46
*** shaohe_feng has joined #openstack-nova20:46
mriedemneed to know if this is in the conductor logs for the instance in question https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L58120:46
*** yamamoto has quit IRC20:46
melwittmnaser: this is a similar bug jroll opened https://bugs.launchpad.net/nova/+bug/1775934 instance was in cell0 db but the instance mapping had cell_id = NULL20:47
openstackLaunchpad bug 1775934 in OpenStack Compute (nova) "Cannot run "openstack server list" with instance stuck in scheduling state" [Undecided,New]20:47
mriedemmelwitt: yeah see https://github.com/openstack/nova/blob/bcbc1f9aeddb060513768489450c429bf53e1e46/nova/conductor/manager.py#L124420:47
mriedemwe don't bury in cell0 there20:47
mriedemso that might be what jroll hit20:47
melwittI don't think so bc his instance was buried in cell0 but the instance mapping did not reflect cell0, it was still pointing at NULL for cell_id20:48
*** brault_ has joined #openstack-nova20:48
mriedemthat's what mnaser is seeing as well20:48
melwittokay, yeah so that's what dansmith was saying if the notify failed (or if nova-conductor somehow was restarted at the exact moment) we'd create in cell0 and not update the instance mapping20:50
*** brault has quit IRC20:51
mnaseryeah20:53
mnaserrabbit was having a field day at that point in time20:53
dansmithbut the task/vm states should be updated, as mriedem was saying20:54
dansmithand they're not20:54
mnaserUnexpected error during heartbeart thread processing, retrying...: error: [Errno 104] ECONNRESET20:54
mriedemmnaser: do you see this in the logs for that instance? https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L58120:54
*** shaohe_feng has quit IRC20:54
mnaserin conductor right?20:54
mriedemyeah20:55
mriedemdansmith: oh btw, instance.save() sends it's own notification20:55
mriedemi always forget about that20:55
dansmithtrue story20:55
mriedemshould be after the db update20:55
*** shaohe_feng has joined #openstack-nova20:55
mnasernot a single reference to that instance id in the logs20:56
mnaser:\20:56
mnaserin that range of time at least20:56
*** edmondsw has joined #openstack-nova20:56
mnaserunless zgrep is failing me but i dont think so20:56
dansmithwell, that's good20:56
dansmithmnaser: whatabout https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L56720:57
mnaseri see other references to it but this instance odes not have one20:57
mriedemFailed to compute_task_build_instances20:57
mnaserlet me get the tenant id of this vm20:58
mnaserjust no valid hosts20:58
openstackgerritJim Rollenhagen proposed openstack/nova master: ironic: add instance_uuid before any other spawn activity  https://review.openstack.org/56372220:59
dansmithand this if you have debug on: https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L109820:59
mnaserhmm20:59
mnaser"Failed to get aggregates for resource provider with UUID 04ae18f3-7226-4d0f-81f3-74a73eb1722a"20:59
mnaserfor some failures in the similar timeline20:59
dansmithmnaser: and I guess you've looked for any stack traces in this instance's build time window yeah?20:59
mnaserif an instance tries scheduling several times and fails does it end up in cell0 as well?21:00
jrollmelwitt: jaypipes: you were both +2 on https://review.openstack.org/#/c/563722/10, had a trivial rebase conflict21:00
*** munimeha1 has joined #openstack-nova21:00
dansmithmnaser: yeah21:00
dansmithnovalidhost -> cell021:00
mriedemtries scheduling several times?21:00
*** jmlowe has joined #openstack-nova21:00
mnaserwell as in21:00
mnaserretrying build on another host21:00
mriedemreschedules?21:00
mnaseri guess thats the term21:00
mriedemnot in this case21:00
mriedemreschedules happen within a cell21:00
mriedemcell0 is when you don't get a host to start with21:01
dansmithoh I guess that's right, once you've picked your first host, you're stuck in there21:01
mnaseroh21:01
mnaseruhoh21:01
mnasery'all are never gonna listen to me again21:01
dansmithI was writing off a lot of that given that he's flat, but I guess that ain't right21:01
melwittjroll: +W21:01
mnaseri just noticed a failure with21:01
mnaser"WSREP has not yet prepared node for application use"21:01
jrollmelwitt: thanks21:01
mnaserthat is quite possibly the cause why21:02
dansmithI don't know what that menas21:02
mnaserit might have happened exactly in between the update for cells?21:02
mnaserthat message comes up if something happens with the galera cluster and it refuses to accept mysql requests21:02
mnaseraka "i am bootstrapping and syncing up with other masters, leave me alone till im ready"21:03
dansmithah21:03
mnaserso it refuses to complete read/writes21:03
openstackgerritEric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST  https://review.openstack.org/57692721:03
openstackgerritEric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider sane  https://review.openstack.org/58459821:03
dansmithwell, that would explain a dropped update21:03
openstackgerritEric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer  https://review.openstack.org/58459921:03
openstackgerritEric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree  https://review.openstack.org/58464821:03
openstackgerritEric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories  https://review.openstack.org/58503321:03
openstackgerritEric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump  https://review.openstack.org/58503421:03
mnaserurgh, sorry for the noise :(21:03
mriedemmnaser: so you're thinking that happened during the save to make the instance in error state in cell0?21:03
mnasersomehow galera manages to find more people than me to bother!21:03
mnasermriedem: my guess.. i cant imagine any other scenario21:03
mnaserthough i'm still so confused how like21:04
mriedembtw, we could just put those updates on the instance before calling create() here so it's a single operation https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L115521:04
mnaseri cant manage to find a SINGLE log entry for that instance uuid21:04
dansmithmriedem: the state->error stuff you mean?21:04
*** shaohe_feng has quit IRC21:04
mriedemdansmith: right21:04
dansmithyeah21:05
mriedemsaves us the other instance.save() later21:05
dansmithalthough21:05
*** jmlowe has quit IRC21:05
dansmithI was wondering if that would mess up the notificaitons21:05
dansmithso you'd get a create notification in error state,21:05
dansmithinstead of a create of scheduling and then another updated one with error, then deleted, etc21:05
*** shaohe_feng has joined #openstack-nova21:06
mriedemi don't know if that's a big problem21:06
mriedemdepends on the consumer i guess21:07
dansmithwell, if you're currently watching for instance.updated,vm_state=ERROR for your logging thing21:07
mriedembut i'm pretty sure we are not good about notifications as a proper state machine21:07
dansmithand now it's instance.created21:07
dansmithyeah21:07
dansmithobvi21:07
mriedemstill thinking this is a bad idea https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L117821:07
dansmithwe have to pass there or we won't clean up the BRs21:07
dansmithlog it maybe if you want21:08
mriedemmnaser: did you say the instance mapping existed for this instance but the cell_mapping was NULL?21:08
dansmithyes21:08
mriedemwhich could be the case if the instance.save() in _set_vm_state_and_notify blew up21:09
mnaseryes ^21:10
mriedemdansmith: also, doesn't it seem like we should bury in cell0 here? https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L124421:10
mriedemseems like a glaring omission21:10
*** hongbin has joined #openstack-nova21:10
mriedemwell,21:11
dansmithI dunno,21:11
dansmithwe've picked a host/cell21:11
mriedemi guess the idea is that if the user deleted the build request, and we don't create it in a cell,21:11
mriedemthen you can't list/show it21:11
dansmithah right this is the pre-create lookup21:11
*** itlinux has quit IRC21:12
dansmithcould argue that you should still be able to show deleted I guess21:12
*** oomichi has joined #openstack-nova21:12
dansmithbut not sure it's worth changing now21:12
mriedemheh i guess i added that https://github.com/openstack/nova/commit/8ba92778fe14b47ad4ff5b53022e0550a93f37d321:12
mriedemi knew it looked familiar21:12
dansmithso on second thought it looks perfect? :)21:12
mriedemit is pretty f'ing nice21:13
dansmithyou lost me about two minutes ago since 'Josie' came up on the jukebox21:13
dansmithvolume -> 100%, butt -> out of seat21:13
mriedemwell it is pretty funky21:14
*** shaohe_feng has quit IRC21:15
eanderssonWhat is the general strategy for dealing with hypervisor maintenance (e.g. os updates etc)?21:15
eanderssonWe wanted to look into a similar implementation to what Amazon does21:15
eanderssonLike tagging a hypervisor for downtime21:16
mriedemthere used to be a maintenance guide in the ops guide21:16
mnaseri think that's beyond the scope of nova and more like business/operational processes21:16
mriedembut i don't know where the ops guide stuff is being worked on now21:16
mriedemhttps://github.com/openstack/openstack-manuals/blob/mitaka-eol/doc/ops-guide/source/ops_maintenance.rst21:17
eanderssonYea - I was hoping that maybe someone wrote some exteranl tools for managing this already, or maybe even a feature inbuilt into nova to allow you to set a timer on a compute21:17
*** shaohe_feng has joined #openstack-nova21:17
mnaseri mean21:18
mriedemdidn't we talk about this at some point you and i?21:18
eanderssonWe did21:18
mriedemyou can mark a compute as disabled from scheduling21:18
mnaserand the user will see the status as 'maintenance' or something21:18
mriedemhttps://developer.openstack.org/api-ref/compute/#compute-services-os-services21:18
mnaserin the api21:18
mnaseri think there is a hoststatus field or something21:18
mnaserunless thats' admin only21:18
mriedemthe user doesn't see services21:18
mnasernot but for vms running in that host21:18
mriedemthe guests on the host are unaffected if you disable the compute service21:18
mnaserin /servers/<uuid>21:18
mriedemyou just can't schedule or migrate new instances to that host while the service is disabled21:19
mriedemyou can force the service status to 'down' to evacuate guests from it21:19
mriedembut if it's up and normal otherwise just live migrate21:20
mnasereandersson: and for customer facing stuff, the nova instance has field 'host_status' which will be 'MAINTENANCE' if the vm is ona disabled host21:20
mnaserso that might be a way to warn consumers that something will happen21:20
mnaserif you wanna say disable it for a few days before21:20
* mriedem checks to see if mnaser forked that in21:21
mnaserhttps://developer.openstack.org/api-ref/compute/#show-server-details21:21
mnaseri swear it's there >:(21:21
mriedemoh right,21:21
mriedemadmin only by default21:21
mriedemconfigurable via policy21:21
mnaserah yeah, so maybe that might be something you want to mess with policy then21:21
mriedemand only with microversion >= 2.16 which is probably newer than eandersson has21:21
eanderssonYea - we are working hard on upgrading to Queens.. but still stuck on Mitaka for now21:22
eanderssonAlso, us NUMA pinning everything does not help21:23
mriedemnot if you actually want to move things21:23
mnaserwhile latency goes down with NUMA pinning21:23
mnaseri've noticed overall performance is not as good21:23
mnaserfor workloads in general21:24
eanderssonGaming is a bit of a odd one unfortunately21:24
eanderssonlatency is everything for players (and not only talking about network latency here :D)21:25
*** shaohe_feng has quit IRC21:25
*** rcernin has joined #openstack-nova21:26
*** shaohe_feng has joined #openstack-nova21:28
*** munimeha1 has quit IRC21:30
*** felipemonteiro_ has joined #openstack-nova21:31
*** pchavva has quit IRC21:33
*** felipemonteiro__ has quit IRC21:34
*** shaohe_feng has quit IRC21:35
*** Guest67313 has quit IRC21:35
mriedemdansmith: i was going to rebase the queued_for_delete series but jaypipes has comments on your migration patch (and the change below it in the series) https://review.openstack.org/#/c/584504/ so you should probably look first21:35
*** shaohe_feng has joined #openstack-nova21:36
*** avolkov has quit IRC21:42
openstackgerritDan Smith proposed openstack/nova master: Online data migration for queued_for_delete flag  https://review.openstack.org/58450421:43
dansmith(that was just the rebase)21:43
*** shaohe_feng has quit IRC21:45
*** shaohe_feng has joined #openstack-nova21:46
openstackgerritDan Smith proposed openstack/nova master: Online data migration for queued_for_delete flag  https://review.openstack.org/58450421:48
openstackgerritEric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST  https://review.openstack.org/57692721:50
openstackgerritEric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories  https://review.openstack.org/58503321:50
openstackgerritEric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider sane  https://review.openstack.org/58459821:50
openstackgerritEric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer  https://review.openstack.org/58459921:50
openstackgerritEric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree  https://review.openstack.org/58464821:50
openstackgerritEric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump  https://review.openstack.org/58503421:50
*** tidwellr has quit IRC21:51
*** gongysh has joined #openstack-nova21:51
jaypipesdansmith, mriedem: I'm +2 on em.21:51
*** shaohe_feng has quit IRC21:56
*** shaohe_feng has joined #openstack-nova21:56
mriedemthat makes 2 of us21:58
mriedemdansmith: there is an email in the ops ML with some cells v2 questions, i replied with what i could but might be a couple of things in there you want to expand on21:59
*** edmondsw has quit IRC22:04
openstackgerritMatt Riedemann proposed openstack/nova master: Update queued-for-delete from the ComputeAPI during deletion/restoration  https://review.openstack.org/56681322:05
*** antosh has quit IRC22:05
*** shaohe_feng has quit IRC22:06
*** shaohe_feng has joined #openstack-nova22:08
openstackgerritMerged openstack/nova master: Add VIFMigrateData object for live migration  https://review.openstack.org/51542322:10
mriedemoh wow something merged today22:13
openstackgerritMatt Riedemann proposed openstack/nova master: doc: link to CERN summit video about upgrading from cells v1 to v2  https://review.openstack.org/58504422:16
*** shaohe_feng has quit IRC22:16
*** shaohe_feng has joined #openstack-nova22:18
*** slaweq has quit IRC22:23
*** owalsh_ has joined #openstack-nova22:25
openstackgerritMatt Riedemann proposed openstack/nova master: doc: link to AZ talk from the Rocky summit  https://review.openstack.org/58504522:25
*** shaohe_feng has quit IRC22:26
*** shaohe_feng has joined #openstack-nova22:27
*** owalsh has quit IRC22:28
*** owalsh- has joined #openstack-nova22:28
*** antosh has joined #openstack-nova22:29
*** hoonetorg has quit IRC22:31
*** owalsh has joined #openstack-nova22:31
*** owalsh_ has quit IRC22:31
*** owalsh- has quit IRC22:34
*** wolverineav has quit IRC22:34
*** wolverineav has joined #openstack-nova22:35
*** owalsh_ has joined #openstack-nova22:35
*** owalsh has quit IRC22:36
*** shaohe_feng has quit IRC22:37
*** shaohe_feng has joined #openstack-nova22:37
*** mriedem has quit IRC22:39
*** wolverineav has quit IRC22:40
*** shaohe_feng has quit IRC22:47
*** hoonetorg has joined #openstack-nova22:47
*** shaohe_feng has joined #openstack-nova22:48
*** vladikr has quit IRC22:50
*** hongbin has quit IRC22:50
*** itlinux has joined #openstack-nova22:53
*** martin__ has quit IRC22:55
*** shaohe_feng has quit IRC22:57
*** shaohe_feng has joined #openstack-nova22:58
*** chyka has quit IRC23:02
*** chyka has joined #openstack-nova23:03
*** vladikr has joined #openstack-nova23:03
*** mschuppert has quit IRC23:04
*** yamamoto has joined #openstack-nova23:04
openstackgerritEric Fried proposed openstack/nova master: WIP: Compute: Handle reshaped provider trees  https://review.openstack.org/57623623:06
openstackgerritEric Fried proposed openstack/nova master: WIP: Report client: update_from_provider_tree w/reshape  https://review.openstack.org/58504923:06
*** shaohe_feng has quit IRC23:07
*** yamamoto has quit IRC23:08
*** r-daneel has quit IRC23:08
*** shaohe_feng has joined #openstack-nova23:09
*** slaweq has joined #openstack-nova23:11
*** felipemonteiro_ has quit IRC23:11
*** slaweq has quit IRC23:16
*** shaohe_feng has quit IRC23:18
*** shaohe_feng has joined #openstack-nova23:18
*** tetsuro has joined #openstack-nova23:19
*** mriedem has joined #openstack-nova23:21
*** oomichi has quit IRC23:24
*** lpetrut has joined #openstack-nova23:26
*** shaohe_feng has quit IRC23:28
*** threestrands has joined #openstack-nova23:30
*** lpetrut has quit IRC23:30
*** shaohe_feng has joined #openstack-nova23:31
*** shaohe_feng has quit IRC23:38
*** edmondsw has joined #openstack-nova23:38
*** vladikr has quit IRC23:38
*** shaohe_feng has joined #openstack-nova23:39
*** edmondsw has quit IRC23:43
*** chyka has quit IRC23:48
openstackgerritMatt Riedemann proposed openstack/nova master: Enhance doc to guide user to use nova user  https://review.openstack.org/58311523:48
*** shaohe_feng has quit IRC23:48
*** mriedem has quit IRC23:50
*** shaohe_feng has joined #openstack-nova23:50
*** takashin has joined #openstack-nova23:51
*** vladikr has joined #openstack-nova23:52
*** brault has joined #openstack-nova23:53
*** brault_ has quit IRC23:55
*** shaohe_feng has quit IRC23:59
*** shaohe_feng has joined #openstack-nova23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!