*** shaohe_feng has quit IRC | 00:04 | |
*** shaohe_feng has joined #openstack-nova | 00:05 | |
*** shaohe_feng has quit IRC | 00:14 | |
*** shaohe_feng has joined #openstack-nova | 00:15 | |
*** shaohe_feng has quit IRC | 00:24 | |
*** shaohe_feng has joined #openstack-nova | 00:28 | |
*** shaohe_feng has quit IRC | 00:34 | |
*** shaohe_feng has joined #openstack-nova | 00:35 | |
*** yamamoto has joined #openstack-nova | 00:39 | |
*** shaohe_feng has quit IRC | 00:45 | |
*** yamamoto has quit IRC | 00:45 | |
openstackgerrit | fupingxie proposed openstack/nova master: Delete allocations when it is re-allocated https://review.openstack.org/582899 | 00:46 |
---|---|---|
*** wolverineav has joined #openstack-nova | 00:49 | |
*** shaohe_feng has joined #openstack-nova | 00:49 | |
*** wolverineav has quit IRC | 00:54 | |
*** shaohe_feng has quit IRC | 00:55 | |
*** shaohe_feng has joined #openstack-nova | 00:58 | |
*** med_ has joined #openstack-nova | 01:02 | |
*** med_ has quit IRC | 01:02 | |
*** med_ has joined #openstack-nova | 01:02 | |
*** Dinesh_Bhor has joined #openstack-nova | 01:02 | |
*** shaohe_feng has quit IRC | 01:05 | |
*** shaohe_feng has joined #openstack-nova | 01:08 | |
*** edmondsw has joined #openstack-nova | 01:11 | |
*** hongbin has joined #openstack-nova | 01:13 | |
*** shaohe_feng has quit IRC | 01:15 | |
*** edmondsw has quit IRC | 01:15 | |
*** mrsoul has joined #openstack-nova | 01:16 | |
*** shaohe_feng has joined #openstack-nova | 01:17 | |
*** mrsoul` has quit IRC | 01:19 | |
*** liuyulong has joined #openstack-nova | 01:25 | |
*** shaohe_feng has quit IRC | 01:26 | |
*** shaohe_feng has joined #openstack-nova | 01:27 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Func test for improper cn local DISK_GB reporting https://review.openstack.org/583646 | 01:34 |
*** shaohe_feng has quit IRC | 01:36 | |
*** shaohe_feng has joined #openstack-nova | 01:38 | |
*** yamamoto has joined #openstack-nova | 01:41 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (5) https://review.openstack.org/570842 | 01:43 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (6) https://review.openstack.org/571330 | 01:43 |
*** shaohe_feng has quit IRC | 01:46 | |
*** yamamoto has quit IRC | 01:47 | |
*** shaohe_feng has joined #openstack-nova | 01:47 | |
*** yamamoto has joined #openstack-nova | 01:51 | |
*** yamamoto has quit IRC | 01:54 | |
*** shaohe_feng has quit IRC | 01:56 | |
*** hshiina has joined #openstack-nova | 01:57 | |
*** shaohe_feng has joined #openstack-nova | 01:58 | |
*** lei-zh has joined #openstack-nova | 01:58 | |
*** Dinesh_Bhor has quit IRC | 01:58 | |
*** med_ has quit IRC | 02:01 | |
*** Dinesh_Bhor has joined #openstack-nova | 02:04 | |
*** shaohe_feng has quit IRC | 02:07 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (7) https://review.openstack.org/571992 | 02:07 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (8) https://review.openstack.org/571993 | 02:09 |
*** gongysh has joined #openstack-nova | 02:09 | |
*** shaohe_feng has joined #openstack-nova | 02:10 | |
*** shaohe_feng has quit IRC | 02:17 | |
*** shaohe_feng has joined #openstack-nova | 02:19 | |
openstackgerrit | yanpuqing proposed openstack/nova master: Rename auth_uri to www_authenticate_uri https://review.openstack.org/576820 | 02:19 |
*** tetsuro has joined #openstack-nova | 02:25 | |
*** shaohe_feng has quit IRC | 02:27 | |
*** shaohe_feng has joined #openstack-nova | 02:29 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3) https://review.openstack.org/574104 | 02:36 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4) https://review.openstack.org/574106 | 02:36 |
*** shaohe_feng has quit IRC | 02:37 | |
*** shaohe_feng has joined #openstack-nova | 02:38 | |
openstackgerrit | Merged openstack/nova master: Add regression test for bug 1781710 https://review.openstack.org/583339 | 02:38 |
openstack | bug 1781710 in OpenStack Compute (nova) "ServersOnMultiNodesTest.test_create_server_with_scheduler_hint_group_anti_affinity failing with "Servers are on the same host"" [High,In progress] https://launchpad.net/bugs/1781710 - Assigned to Matt Riedemann (mriedem) | 02:38 |
*** flwang1 has joined #openstack-nova | 02:45 | |
*** yamamoto has joined #openstack-nova | 02:45 | |
*** shaohe_feng has quit IRC | 02:48 | |
*** psachin has joined #openstack-nova | 02:49 | |
*** shaohe_feng has joined #openstack-nova | 02:49 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5) https://review.openstack.org/574110 | 02:53 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6) https://review.openstack.org/574113 | 02:53 |
*** vladikr has quit IRC | 02:54 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (7) https://review.openstack.org/574974 | 02:54 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8) https://review.openstack.org/575311 | 02:54 |
*** vladikr has joined #openstack-nova | 02:54 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.openstack.org/575581 | 02:54 |
*** dave-mcc_ has quit IRC | 02:54 | |
*** brault has quit IRC | 02:54 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10) https://review.openstack.org/576017 | 02:54 |
*** brault has joined #openstack-nova | 02:55 | |
*** shaohe_feng has quit IRC | 02:58 | |
*** vladikr has quit IRC | 02:58 | |
*** shaohe_feng has joined #openstack-nova | 02:59 | |
*** edmondsw has joined #openstack-nova | 02:59 | |
*** vladikr has joined #openstack-nova | 02:59 | |
*** gongysh has quit IRC | 03:01 | |
*** edmondsw has quit IRC | 03:04 | |
*** shaohe_feng has quit IRC | 03:08 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11) https://review.openstack.org/576018 | 03:09 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.openstack.org/576019 | 03:09 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.openstack.org/576020 | 03:09 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.openstack.org/576027 | 03:09 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.openstack.org/576031 | 03:10 |
*** shaohe_feng has joined #openstack-nova | 03:10 | |
*** yamamoto has quit IRC | 03:16 | |
*** yamamoto has joined #openstack-nova | 03:16 | |
*** vladikr has quit IRC | 03:18 | |
*** vladikr has joined #openstack-nova | 03:18 | |
*** shaohe_feng has quit IRC | 03:18 | |
*** shaohe_feng has joined #openstack-nova | 03:19 | |
*** yamamoto has quit IRC | 03:20 | |
*** psachin has quit IRC | 03:22 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Report 0 root_gb in resource tracker if instance is bfv. https://review.openstack.org/584204 | 03:25 |
*** shaohe_feng has quit IRC | 03:29 | |
*** shaohe_feng has joined #openstack-nova | 03:30 | |
*** Dinesh_Bhor has quit IRC | 03:34 | |
*** psachin has joined #openstack-nova | 03:38 | |
*** shaohe_feng has quit IRC | 03:39 | |
*** shaohe_feng has joined #openstack-nova | 03:42 | |
*** vladikr has quit IRC | 03:45 | |
*** vladikr has joined #openstack-nova | 03:45 | |
*** Dinesh_Bhor has joined #openstack-nova | 03:47 | |
*** shaohe_feng has quit IRC | 03:49 | |
*** Dinesh_Bhor has quit IRC | 03:50 | |
*** slaweq has quit IRC | 03:52 | |
*** shaohe_feng has joined #openstack-nova | 03:52 | |
*** udesale has joined #openstack-nova | 03:55 | |
*** slaweq has joined #openstack-nova | 03:59 | |
*** shaohe_feng has quit IRC | 03:59 | |
*** kevinbenton has quit IRC | 04:00 | |
*** lpetrut has joined #openstack-nova | 04:00 | |
*** kevinbenton has joined #openstack-nova | 04:00 | |
*** shaohe_feng has joined #openstack-nova | 04:02 | |
*** mdnadeem has joined #openstack-nova | 04:06 | |
*** lei-zh has quit IRC | 04:06 | |
*** shaohe_feng has quit IRC | 04:10 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Fix the help text for server-group-create https://review.openstack.org/584709 | 04:11 |
*** shaohe_feng has joined #openstack-nova | 04:12 | |
*** shaohe_feng has quit IRC | 04:20 | |
*** flwang1 has quit IRC | 04:21 | |
*** shaohe_feng has joined #openstack-nova | 04:21 | |
*** flwang1 has joined #openstack-nova | 04:21 | |
*** jamesdenton has quit IRC | 04:27 | |
*** shaohe_feng has quit IRC | 04:30 | |
*** shaohe_feng has joined #openstack-nova | 04:31 | |
*** flwang1 has quit IRC | 04:37 | |
*** shaohe_feng has quit IRC | 04:40 | |
*** shaohe_feng has joined #openstack-nova | 04:42 | |
*** owalsh has quit IRC | 04:43 | |
*** lpetrut has quit IRC | 04:45 | |
*** Dinesh_Bhor has joined #openstack-nova | 04:46 | |
*** edmondsw has joined #openstack-nova | 04:47 | |
*** shaohe_feng has quit IRC | 04:51 | |
*** edmondsw has quit IRC | 04:52 | |
*** yamamoto has joined #openstack-nova | 04:52 | |
*** shaohe_feng has joined #openstack-nova | 04:53 | |
*** janki has joined #openstack-nova | 04:54 | |
openstackgerrit | Merged openstack/nova master: Merge server create for multiple-create extension https://review.openstack.org/580017 | 04:54 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.openstack.org/576299 | 04:55 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.openstack.org/576344 | 04:55 |
*** hongbin has quit IRC | 04:55 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.openstack.org/576673 | 04:55 |
*** shaohe_feng has quit IRC | 05:01 | |
*** shaohe_feng has joined #openstack-nova | 05:03 | |
*** yamamoto has quit IRC | 05:03 | |
*** janki has quit IRC | 05:03 | |
*** janki has joined #openstack-nova | 05:04 | |
*** yamamoto has joined #openstack-nova | 05:07 | |
*** brault_ has joined #openstack-nova | 05:07 | |
*** brault has quit IRC | 05:09 | |
*** sridharg has joined #openstack-nova | 05:10 | |
*** brault has joined #openstack-nova | 05:11 | |
*** shaohe_feng has quit IRC | 05:11 | |
*** ircuser-1 has joined #openstack-nova | 05:12 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge extended availability zone response into server controller https://review.openstack.org/502859 | 05:12 |
*** brault_ has quit IRC | 05:13 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge config drive extension response into server controller https://review.openstack.org/584223 | 05:14 |
*** shaohe_feng has joined #openstack-nova | 05:15 | |
*** gongysh has joined #openstack-nova | 05:16 | |
*** ratailor has joined #openstack-nova | 05:21 | |
*** shaohe_feng has quit IRC | 05:21 | |
*** gongysh has quit IRC | 05:21 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge config drive extension response into server controller https://review.openstack.org/584223 | 05:22 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge extended server attributes extension response https://review.openstack.org/584590 | 05:23 |
*** shaohe_feng has joined #openstack-nova | 05:24 | |
*** armaan has joined #openstack-nova | 05:26 | |
*** yamamoto has quit IRC | 05:28 | |
*** lei-zh has joined #openstack-nova | 05:29 | |
*** abhishekk has joined #openstack-nova | 05:29 | |
*** brault has quit IRC | 05:30 | |
*** shaohe_feng has quit IRC | 05:32 | |
*** mlavalle has joined #openstack-nova | 05:32 | |
*** shaohe_feng has joined #openstack-nova | 05:33 | |
*** armaan has quit IRC | 05:35 | |
*** links has joined #openstack-nova | 05:38 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge extended server attributes extension response https://review.openstack.org/584590 | 05:42 |
*** udesale_ has joined #openstack-nova | 05:42 | |
*** shaohe_feng has quit IRC | 05:42 | |
*** shaohe_feng has joined #openstack-nova | 05:43 | |
*** udesale has quit IRC | 05:45 | |
*** shaohe_feng has quit IRC | 05:52 | |
*** shaohe_feng has joined #openstack-nova | 05:53 | |
deepak_mourya | takashin: Hi, What is the default direction of sort when we will do 'nova list' ? | 05:56 |
deepak_mourya | NovaClient : It shows default is descending https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/shell.py#L1454 | 05:56 |
deepak_mourya | Nova Sqlalchemy : It shows default is Ascending https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L2454 | 05:56 |
*** mlavalle has quit IRC | 05:56 | |
*** zhurong has joined #openstack-nova | 05:58 | |
*** trungnv has joined #openstack-nova | 05:59 | |
takashin | deepak_mourya: In the compute API refrence, the default value of 'sort_dir' parameter is 'desc'. | 06:01 |
*** psachin has quit IRC | 06:01 | |
*** Dinesh_Bhor has quit IRC | 06:01 | |
takashin | deepak_mourya: https://developer.openstack.org/api-ref/compute/#list-server-request | 06:01 |
takashin | deepak_mourya: https://developer.openstack.org/api-ref/compute/#id15 | 06:01 |
*** psachin` has joined #openstack-nova | 06:02 | |
*** shaohe_feng has quit IRC | 06:02 | |
takashin | deepak_mourya: So compute API and nova client have same default value. | 06:02 |
*** shaohe_feng has joined #openstack-nova | 06:04 | |
*** vivsoni has joined #openstack-nova | 06:04 | |
deepak_mourya | takashin: Ok, so when we do 'nova list' default servers should come sorted on the basis of column 'name' (sortby_index=1) in the Descending order . Isn't it ? | 06:04 |
vishakha | takashin : Hi, I have updated the patch https://review.openstack.org/#/c/580271/. Pls review. Thanks | 06:06 |
*** shaohe_feng has quit IRC | 06:13 | |
*** mschuppert has joined #openstack-nova | 06:13 | |
*** Dinesh_Bhor has joined #openstack-nova | 06:13 | |
takashin | deepak_mourya: In nova, the result is sorted by 'created_at' value (descending order). | 06:13 |
takashin | deepak_mourya: https://github.com/openstack/nova/blob/master/nova/api/openstack/common.py#L143-L144 | 06:14 |
*** brault has joined #openstack-nova | 06:14 | |
takashin | deepak_mourya: I'm not sure that the server name should be sorted by descending order in novaclient. | 06:14 |
takashin | vishakha: okay. I will. | 06:14 |
openstackgerrit | jichenjc proposed openstack/nova master: add zvm into support matrix https://review.openstack.org/532720 | 06:14 |
openstackgerrit | jichenjc proposed openstack/nova master: Add zvm admin intro and hypervisor information https://review.openstack.org/533125 | 06:14 |
*** shaohe_feng has joined #openstack-nova | 06:14 | |
openstackgerrit | jichenjc proposed openstack/nova master: Add zvm CI information https://review.openstack.org/533512 | 06:14 |
vishakha | takashin : Thanks | 06:17 |
deepak_mourya | takashin: | 06:19 |
deepak_mourya | Ok thanks got it, but I think result is still not sorted. | 06:19 |
deepak_mourya | nova list --sort created_at | 06:19 |
deepak_mourya | +--------------------------------------+------+--------+------------+-------------+---------------------------------+ | 06:19 |
deepak_mourya | | ID | Name | Status | Task State | Power State | Networks | | 06:19 |
deepak_mourya | +--------------------------------------+------+--------+------------+-------------+---------------------------------+ | 06:19 |
deepak_mourya | | b56b3bee-df66-43a2-90ad-a6ab522390e6 | abbc | ACTIVE | - | Running | public=2001:db8::e, 172.24.4.6 | | 06:19 |
deepak_mourya | | 58c19cbc-57e8-49b3-8676-54f57e7df1ab | aab | ACTIVE | - | Running | public=2001:db8::9, 172.24.4.13 | | 06:19 |
deepak_mourya | | d0900044-f59a-4032-8bb1-0347c2f30bae | abc | ACTIVE | - | Running | public=2001:db8::d, 172.24.4.8 | | 06:19 |
deepak_mourya | | 307afbb8-131f-42f0-ba96-7a6e1f4a7846 | ab | ACTIVE | - | Running | public=2001:db8::8, 172.24.4.11 | | 06:19 |
deepak_mourya | +--------------------------------------+------+--------+------------+-------------+---------------------------------+ | 06:19 |
deepak_mourya | nova list | 06:19 |
deepak_mourya | '+--------------------------------------+------+--------+------------+-------------+---------------------------------+ | 06:19 |
deepak_mourya | | ID | Name | Status | Task State | Power State | Networks | | 06:19 |
deepak_mourya | nova list | 06:20 |
deepak_mourya | '+--------------------------------------+------+--------+------------+-------------+---------------------------------+ | 06:20 |
deepak_mourya | | ID | Name | Status | Task State | Power State | Networks | | 06:20 |
deepak_mourya | +--------------------------------------+------+--------+------------+-------------+---------------------------------+ | 06:20 |
deepak_mourya | | 58c19cbc-57e8-49b3-8676-54f57e7df1ab | aab | ACTIVE | - | Running | public=2001:db8::9, 172.24.4.13 | | 06:20 |
deepak_mourya | | 307afbb8-131f-42f0-ba96-7a6e1f4a7846 | ab | ACTIVE | - | Running | public=2001:db8::8, 172.24.4.11 | | 06:20 |
deepak_mourya | | b56b3bee-df66-43a2-90ad-a6ab522390e6 | abbc | ACTIVE | - | Running | public=2001:db8::e, 172.24.4.6 | | 06:20 |
deepak_mourya | | d0900044-f59a-4032-8bb1-0347c2f30bae | abc | ACTIVE | - | Running | public=2001:db8::d, 172.24.4.8 | | 06:20 |
deepak_mourya | +--------------------------------------+------+--------+------------+-------------+---------------------------------+ | 06:20 |
gmann | deepak_mourya: is it not sorted by created_at or you are checking sort with name ? | 06:20 |
deepak_mourya | gmann: When we do 'nova list' , it should sort on the basis of the created_at paramemter | 06:22 |
gmann | yea | 06:22 |
deepak_mourya | but what i don't think the resulted output is sorted on the same basis . | 06:22 |
*** shaohe_feng has quit IRC | 06:23 | |
gmann | but did you check the server create_at field for them | 06:23 |
deepak_mourya | gmann: http://paste.openstack.org/show/726419/ | 06:24 |
*** shaohe_feng has joined #openstack-nova | 06:24 | |
openstackgerrit | Lei Zhang proposed openstack/nova master: Add method to get cpu traits https://review.openstack.org/560317 | 06:24 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Report 0 root_gb in resource tracker if instance is bfv. https://review.openstack.org/584204 | 06:25 |
*** sahid has joined #openstack-nova | 06:28 | |
*** lpetrut has joined #openstack-nova | 06:29 | |
openstackgerrit | Lei Zhang proposed openstack/nova master: Add method to get cpu traits https://review.openstack.org/560317 | 06:29 |
gmann | deepak_mourya: seems like it is n or sorted by default. | 06:30 |
gmann | deepak_mourya: let me check on my env | 06:30 |
deepak_mourya | gmann: ok | 06:30 |
*** shaohe_feng has quit IRC | 06:33 | |
*** shaohe_feng has joined #openstack-nova | 06:35 | |
*** edmondsw has joined #openstack-nova | 06:35 | |
*** ccamacho has joined #openstack-nova | 06:39 | |
*** edmondsw has quit IRC | 06:39 | |
*** links has quit IRC | 06:41 | |
*** udesale__ has joined #openstack-nova | 06:43 | |
*** shaohe_feng has quit IRC | 06:43 | |
*** shaohe_feng has joined #openstack-nova | 06:44 | |
*** udesale_ has quit IRC | 06:45 | |
*** dtantsur|afk is now known as dtantsur | 06:45 | |
*** hshiina has quit IRC | 06:50 | |
openstackgerrit | jichenjc proposed openstack/nova master: add zvm into support matrix https://review.openstack.org/532720 | 06:51 |
openstackgerrit | jichenjc proposed openstack/nova master: Add zvm admin intro and hypervisor information https://review.openstack.org/533125 | 06:51 |
openstackgerrit | jichenjc proposed openstack/nova master: Add zvm CI information https://review.openstack.org/533512 | 06:51 |
*** shaohe_feng has quit IRC | 06:54 | |
*** jaosorior has joined #openstack-nova | 06:55 | |
*** shaohe_feng has joined #openstack-nova | 06:56 | |
*** armaan has joined #openstack-nova | 06:59 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.openstack.org/576676 | 07:00 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.openstack.org/576689 | 07:00 |
*** links has joined #openstack-nova | 07:00 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.openstack.org/576709 | 07:00 |
*** alexchadin has joined #openstack-nova | 07:00 | |
*** pcaruana has joined #openstack-nova | 07:02 | |
*** shaohe_feng has quit IRC | 07:04 | |
*** shaohe_feng has joined #openstack-nova | 07:04 | |
*** Luzi has joined #openstack-nova | 07:05 | |
*** evrardjp_ is now known as evrardjp | 07:09 | |
*** pooja_jadhav has joined #openstack-nova | 07:10 | |
*** tssurya has joined #openstack-nova | 07:14 | |
*** shaohe_feng has quit IRC | 07:14 | |
*** ispp has joined #openstack-nova | 07:14 | |
*** shaohe_feng has joined #openstack-nova | 07:17 | |
*** yamamoto has joined #openstack-nova | 07:20 | |
*** ispp has quit IRC | 07:21 | |
*** tesseract has joined #openstack-nova | 07:21 | |
*** mgoddard has joined #openstack-nova | 07:22 | |
*** damien_r has joined #openstack-nova | 07:23 | |
openstackgerrit | jichenjc proposed openstack/nova master: Add zvm admin intro and hypervisor information https://review.openstack.org/533125 | 07:24 |
openstackgerrit | jichenjc proposed openstack/nova master: Add zvm CI information https://review.openstack.org/533512 | 07:24 |
*** zhurong has quit IRC | 07:24 | |
*** yamamoto has quit IRC | 07:24 | |
*** shaohe_feng has quit IRC | 07:24 | |
*** shaohe_feng has joined #openstack-nova | 07:25 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.openstack.org/576712 | 07:29 |
openstackgerrit | huanhongda proposed openstack/nova master: WIP: hypervisor-stats shows wrong disk usages with shared storage https://review.openstack.org/149878 | 07:32 |
*** ragiman has joined #openstack-nova | 07:33 | |
*** links has quit IRC | 07:34 | |
*** shaohe_feng has quit IRC | 07:35 | |
*** shaohe_feng has joined #openstack-nova | 07:35 | |
*** rmart04 has joined #openstack-nova | 07:35 | |
*** rpittau has joined #openstack-nova | 07:38 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge keypair extension response into server view builder https://review.openstack.org/584748 | 07:40 |
*** AlexeyAbashkin has joined #openstack-nova | 07:42 | |
*** shaohe_feng has quit IRC | 07:45 | |
*** shaohe_feng has joined #openstack-nova | 07:47 | |
*** links has joined #openstack-nova | 07:47 | |
*** zhurong has joined #openstack-nova | 07:49 | |
*** adrianc has joined #openstack-nova | 07:51 | |
*** shaohe_feng has quit IRC | 07:55 | |
*** shaohe_feng has joined #openstack-nova | 07:56 | |
*** avolkov has joined #openstack-nova | 07:57 | |
*** avolkov has quit IRC | 07:59 | |
*** adrianc has quit IRC | 08:00 | |
*** ispp has joined #openstack-nova | 08:01 | |
*** takashin has left #openstack-nova | 08:03 | |
*** armaan has quit IRC | 08:04 | |
*** shaohe_feng has quit IRC | 08:05 | |
*** shaohe_feng has joined #openstack-nova | 08:06 | |
*** blkart has quit IRC | 08:12 | |
*** blkart has joined #openstack-nova | 08:15 | |
*** shaohe_feng has quit IRC | 08:16 | |
*** shaohe_feng has joined #openstack-nova | 08:17 | |
*** dtantsur is now known as dtantsur|brb | 08:18 | |
*** owalsh has joined #openstack-nova | 08:22 | |
*** edmondsw has joined #openstack-nova | 08:23 | |
*** mgoddard has quit IRC | 08:24 | |
*** armaan has joined #openstack-nova | 08:25 | |
*** shaohe_feng has quit IRC | 08:26 | |
*** owalsh_ has joined #openstack-nova | 08:27 | |
*** owalsh has quit IRC | 08:27 | |
*** edmondsw has quit IRC | 08:28 | |
*** shaohe_feng has joined #openstack-nova | 08:28 | |
*** flwang1 has joined #openstack-nova | 08:31 | |
*** derekh has joined #openstack-nova | 08:33 | |
*** gongysh has joined #openstack-nova | 08:35 | |
*** shaohe_feng has quit IRC | 08:36 | |
gibi | good morning | 08:38 |
*** shaohe_feng has joined #openstack-nova | 08:39 | |
openstackgerrit | Boxiang Zhu proposed openstack/nova stable/pike: Fix "instance snap min disk size err after resize instance" https://review.openstack.org/584770 | 08:40 |
*** shaohe_feng has quit IRC | 08:46 | |
*** zhurong has quit IRC | 08:47 | |
*** Dinesh_Bhor has quit IRC | 08:47 | |
*** shaohe_feng has joined #openstack-nova | 08:47 | |
*** jaosorior has quit IRC | 08:50 | |
*** shaohe_feng has quit IRC | 08:57 | |
*** shaohe_feng has joined #openstack-nova | 08:57 | |
*** Dinesh_Bhor has joined #openstack-nova | 08:58 | |
*** wolverineav has joined #openstack-nova | 09:01 | |
*** wolverineav has quit IRC | 09:06 | |
*** shaohe_feng has quit IRC | 09:07 | |
*** shaohe_feng has joined #openstack-nova | 09:08 | |
*** shaohe_feng has quit IRC | 09:17 | |
*** alexchadin has quit IRC | 09:17 | |
*** shaohe_feng has joined #openstack-nova | 09:18 | |
*** Dinesh_Bhor has quit IRC | 09:19 | |
*** alexchadin has joined #openstack-nova | 09:23 | |
bauzas | good morning stackers | 09:27 |
*** shaohe_feng has quit IRC | 09:27 | |
* bauzas is back from a long non-available period | 09:27 | |
*** shaohe_feng has joined #openstack-nova | 09:29 | |
*** jistr|off is now known as jistr | 09:29 | |
gibi | bauzas: welcome back | 09:31 |
bauzas | thanks | 09:32 |
* bauzas starts back with a placement bug, so cool | 09:32 | |
*** Dinesh_Bhor has joined #openstack-nova | 09:34 | |
*** links has quit IRC | 09:34 | |
*** yamamoto has joined #openstack-nova | 09:36 | |
*** shaohe_feng has quit IRC | 09:38 | |
*** dtantsur|brb is now known as dtantsur | 09:38 | |
*** shaohe_feng has joined #openstack-nova | 09:38 | |
*** cdent has joined #openstack-nova | 09:39 | |
*** links has joined #openstack-nova | 09:41 | |
*** yamamoto has quit IRC | 09:41 | |
*** owalsh_ is now known as owalsh | 09:41 | |
sean-k-mooney | bauzas: o/ | 09:46 |
*** shaohe_feng has quit IRC | 09:48 | |
*** shaohe_feng has joined #openstack-nova | 09:50 | |
*** lei-zh has quit IRC | 09:50 | |
*** finucannot has quit IRC | 09:53 | |
*** stephenfin has joined #openstack-nova | 09:55 | |
*** shaohe_feng has quit IRC | 09:58 | |
*** shaohe_feng has joined #openstack-nova | 09:59 | |
*** shaohe_feng has quit IRC | 10:08 | |
*** shaohe_feng has joined #openstack-nova | 10:10 | |
*** edmondsw has joined #openstack-nova | 10:11 | |
*** edmondsw has quit IRC | 10:16 | |
*** shaohe_feng has quit IRC | 10:19 | |
openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Add /reshaper handler for POST https://review.openstack.org/576927 | 10:20 |
bauzas | cdent: around ? | 10:20 |
cdent | bauzas: yup, hi | 10:20 |
bauzas | cdent: can you please refresh my mind ? | 10:20 |
* cdent presses the refresh button | 10:21 | |
bauzas | cdent: we stopped auto-healing allocations from the RT since Queens, right? | 10:21 |
cdent | yes, that's how I remember it | 10:21 |
bauzas | cdent: on a RH BZ, some customer got some phantom allocations | 10:21 |
*** shaohe_feng has joined #openstack-nova | 10:21 | |
bauzas | cdent: so I wonder how their allocations were created | 10:22 |
bauzas | but the related instance wasn't there | 10:22 |
cdent | I have a vague memory of some bugs with cleaning up allocations under certain failure conditions. Do you know whether it was a normal server create or a migration? | 10:23 |
bauzas | no sorry | 10:24 |
bauzas | I think it was a server create | 10:24 |
bauzas | but I'm not sure | 10:24 |
*** ragiman has quit IRC | 10:25 | |
cdent | any chance they deleted the compute service? any of these bugs look relevant? | 10:27 |
cdent | https://bugs.launchpad.net/nova/+bug/1756179 | 10:27 |
openstack | Launchpad bug 1756179 in OpenStack Compute (nova) queens "deleting a nova-compute service leaves orphaned records in placement and host mapping" [Medium,Fix committed] - Assigned to Surya Seetharaman (tssurya) | 10:27 |
cdent | https://bugs.launchpad.net/nova/+bug/1679750 | 10:27 |
openstack | Launchpad bug 1679750 in OpenStack Compute (nova) queens "Allocations are not cleaned up in placement for instance 'local delete' case" [Medium,Fix committed] - Assigned to Matt Riedemann (mriedem) | 10:27 |
cdent | https://bugs.launchpad.net/nova/+bug/1662867 | 10:28 |
openstack | Launchpad bug 1662867 in OpenStack Compute (nova) queens "update_available_resource_for_node racing instance deletion" [Medium,Fix committed] - Assigned to Lee Yarwood (lyarwood) | 10:28 |
*** mdbooth has joined #openstack-nova | 10:28 | |
*** jaosorior has joined #openstack-nova | 10:28 | |
*** shaohe_feng has quit IRC | 10:29 | |
*** shaohe_feng has joined #openstack-nova | 10:30 | |
*** alexchadin has quit IRC | 10:30 | |
cdent | bauzas: I gotta step away, but will be back. I hope some of the above is useful | 10:32 |
*** janki has quit IRC | 10:33 | |
bauzas | cdent: thanks for the help, I'll look at the bugs | 10:33 |
bauzas | and I'll try to discuss with the customer | 10:33 |
*** alexchadin has joined #openstack-nova | 10:36 | |
*** Dinesh_Bhor has quit IRC | 10:37 | |
*** janki has joined #openstack-nova | 10:39 | |
*** shaohe_feng has quit IRC | 10:39 | |
*** alexchadin has quit IRC | 10:41 | |
*** shaohe_feng has joined #openstack-nova | 10:42 | |
*** links has quit IRC | 10:44 | |
*** Dinesh_Bhor has joined #openstack-nova | 10:45 | |
*** alexchadin has joined #openstack-nova | 10:45 | |
*** med_ has joined #openstack-nova | 10:46 | |
*** med_ has quit IRC | 10:46 | |
*** med_ has joined #openstack-nova | 10:46 | |
*** Dinesh_Bhor has quit IRC | 10:46 | |
*** links has joined #openstack-nova | 10:48 | |
*** mlavalle has joined #openstack-nova | 10:49 | |
*** ragiman has joined #openstack-nova | 10:49 | |
*** shaohe_feng has quit IRC | 10:49 | |
*** shaohe_feng has joined #openstack-nova | 10:51 | |
*** s10 has joined #openstack-nova | 10:54 | |
*** shaohe_feng has quit IRC | 11:00 | |
*** shaohe_feng has joined #openstack-nova | 11:00 | |
*** lucasagomes is now known as lucas-hungry | 11:03 | |
*** lucas-hungry is now known as lucasagomes | 11:03 | |
*** dave-mccowan has joined #openstack-nova | 11:06 | |
*** vladikr has quit IRC | 11:07 | |
*** vladikr has joined #openstack-nova | 11:07 | |
*** shaohe_feng has quit IRC | 11:10 | |
*** shaohe_feng has joined #openstack-nova | 11:11 | |
ratailor | could anybody review this https://review.openstack.org/#/c/498334/ need one more +2. | 11:12 |
ratailor | bauzas, ^^ | 11:13 |
*** links has quit IRC | 11:13 | |
*** links has joined #openstack-nova | 11:15 | |
*** gongysh has quit IRC | 11:15 | |
s10 | Hello. Is there any possibility to somehow optimise host_state.update(), which runs on every instance scheduling? Specifically this: https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L181 | 11:16 |
*** gongysh has joined #openstack-nova | 11:16 | |
s10 | Our tests show, that this step (load list of instances to host_state) takes ~10 seconds for deployments with thousands of instances. | 11:17 |
*** liuyulong has quit IRC | 11:19 | |
*** abhishekk has quit IRC | 11:19 | |
*** liuyulong has joined #openstack-nova | 11:19 | |
*** ratailor has quit IRC | 11:20 | |
*** shaohe_feng has quit IRC | 11:20 | |
*** avolkov has joined #openstack-nova | 11:22 | |
openstackgerrit | Andrey Volkov proposed openstack/nova master: Docs: Add Placement to Nova system architecture https://review.openstack.org/584338 | 11:22 |
*** shaohe_feng has joined #openstack-nova | 11:23 | |
s10 | So if we want to start 1000 new instances with 6 nova-scheduler process, without this step (if we commented it out), all of them are being started tens of minutes minutes faster. | 11:25 |
*** udesale__ has quit IRC | 11:25 | |
s10 | And the only place, where host_state.instances is being used is ServerGroupAntiAffinityFilter and ServerGroupAffinityFilter... | 11:26 |
*** shaohe_feng has quit IRC | 11:30 | |
ispp | Hi, could anyone give me a hand with this? https://bugs.launchpad.net/nova/+bug/1783079 | 11:30 |
openstack | Launchpad bug 1783079 in OpenStack Compute (nova) "Unable to attach interface to a VM" [Undecided,New] | 11:30 |
*** shaohe_feng has joined #openstack-nova | 11:32 | |
*** brault has quit IRC | 11:33 | |
*** brault has joined #openstack-nova | 11:34 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove reference to transient domain when detaching devices https://review.openstack.org/584433 | 11:35 |
lyarwood | stephenfin: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1764883 - would you mind taking a swing at this today if you have time? | 11:35 |
*** GonZo2000 has joined #openstack-nova | 11:40 | |
*** GonZo2000 has quit IRC | 11:40 | |
*** GonZo2000 has joined #openstack-nova | 11:40 | |
*** shaohe_feng has quit IRC | 11:41 | |
*** jamesdenton has joined #openstack-nova | 11:41 | |
*** shaohe_feng has joined #openstack-nova | 11:42 | |
*** mvk_ has quit IRC | 11:44 | |
*** ispp has quit IRC | 11:45 | |
*** ispp has joined #openstack-nova | 11:47 | |
*** vladikr has quit IRC | 11:49 | |
*** vladikr has joined #openstack-nova | 11:49 | |
*** shaohe_feng has quit IRC | 11:51 | |
*** alexpilotti has quit IRC | 11:53 | |
*** shaohe_feng has joined #openstack-nova | 11:53 | |
openstackgerrit | Andrey Volkov proposed openstack/nova master: Docs: Add Placement to Nova system architecture https://review.openstack.org/584338 | 11:54 |
*** adrianc_ has joined #openstack-nova | 11:54 | |
openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add queued_for_delete field to InstanceMapping object https://review.openstack.org/566795 | 11:54 |
openstackgerrit | Surya Seetharaman proposed openstack/nova master: Online migration tool for populating queued-for-delete https://review.openstack.org/582536 | 11:54 |
openstackgerrit | Surya Seetharaman proposed openstack/nova master: Update queued-for-delete from the ComputeAPI during deletion/restoration https://review.openstack.org/566813 | 11:54 |
openstackgerrit | Surya Seetharaman proposed openstack/nova master: Return a minimal construct for nova service-list when a cell is down https://review.openstack.org/584829 | 11:54 |
*** ispp has quit IRC | 11:55 | |
*** gongysh has quit IRC | 12:00 | |
*** ispp has joined #openstack-nova | 12:00 | |
*** shaohe_feng has quit IRC | 12:01 | |
*** tetsuro has quit IRC | 12:04 | |
*** shaohe_feng has joined #openstack-nova | 12:05 | |
*** lyan has joined #openstack-nova | 12:08 | |
*** lyan is now known as Guest67313 | 12:09 | |
*** tetsuro has joined #openstack-nova | 12:09 | |
*** tetsuro has quit IRC | 12:10 | |
*** mdbooth_ has joined #openstack-nova | 12:11 | |
*** shaohe_feng has quit IRC | 12:11 | |
*** mdbooth has quit IRC | 12:12 | |
*** adrianc_ has quit IRC | 12:12 | |
*** pchavva has joined #openstack-nova | 12:12 | |
*** edmondsw has joined #openstack-nova | 12:13 | |
*** shaohe_feng has joined #openstack-nova | 12:13 | |
*** aloga has quit IRC | 12:16 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Wire up a force disconnect_volume flag https://review.openstack.org/584849 | 12:20 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Forcibly disconnect volumes during post_live_migration https://review.openstack.org/584850 | 12:20 |
*** Eran_Kuris has quit IRC | 12:20 | |
*** Bhujay has joined #openstack-nova | 12:21 | |
*** shaohe_feng has quit IRC | 12:22 | |
*** shaohe_feng has joined #openstack-nova | 12:22 | |
*** yamamoto has joined #openstack-nova | 12:26 | |
*** leakypipes is now known as jaypipes | 12:29 | |
*** yamamoto has quit IRC | 12:30 | |
*** mdnadeem_ has joined #openstack-nova | 12:31 | |
openstackgerrit | huanhongda proposed openstack/nova master: hypervisor-stats shows wrong disk usages with shared storage https://review.openstack.org/149878 | 12:32 |
*** shaohe_feng has quit IRC | 12:32 | |
*** shaohe_feng has joined #openstack-nova | 12:34 | |
*** mdnadeem has quit IRC | 12:35 | |
*** Eran_Kuris has joined #openstack-nova | 12:35 | |
*** beagles_afk is now known as beagles | 12:38 | |
*** liuyulong has quit IRC | 12:39 | |
*** liuyulong has joined #openstack-nova | 12:39 | |
*** wolverineav has joined #openstack-nova | 12:40 | |
*** jistr is now known as jistr|mtg | 12:41 | |
*** shaohe_feng has quit IRC | 12:42 | |
*** yamamoto has joined #openstack-nova | 12:43 | |
*** s1061123_ has quit IRC | 12:43 | |
*** shaohe_feng has joined #openstack-nova | 12:43 | |
*** s1061123 has joined #openstack-nova | 12:44 | |
*** yamamoto has quit IRC | 12:46 | |
stephenfin | lyarwood: Sure | 12:48 |
*** yamamoto has joined #openstack-nova | 12:49 | |
*** mvk_ has joined #openstack-nova | 12:51 | |
*** shaohe_feng has quit IRC | 12:52 | |
*** mriedem has joined #openstack-nova | 12:53 | |
*** mhg has quit IRC | 12:53 | |
*** adrianc_ has joined #openstack-nova | 12:53 | |
*** yamamoto has quit IRC | 12:54 | |
gibi | stephenfin: hi! You were +2 on https://review.openstack.org/#/c/410297 before but I lost the +2 in merge conflict resolution. Could you look at it again please? | 12:54 |
*** sridharg has quit IRC | 12:54 | |
*** shaohe_feng has joined #openstack-nova | 12:54 | |
stephenfin | gibi: yessir | 12:55 |
gibi | stephenfin: thank you sir | 12:55 |
*** udesale has joined #openstack-nova | 12:56 | |
*** simondodsley_ has quit IRC | 13:00 | |
*** trozet has joined #openstack-nova | 13:00 | |
*** simondodsley_ has joined #openstack-nova | 13:01 | |
*** yamamoto has joined #openstack-nova | 13:01 | |
stephenfin | gibi: One question here https://review.openstack.org/#/c/410297/42/nova/tests/unit/compute/test_compute_api.py | 13:03 |
*** shaohe_feng has quit IRC | 13:03 | |
*** lei-zh has joined #openstack-nova | 13:03 | |
*** yamamoto has quit IRC | 13:03 | |
gibi | stephenfin: let me check it locally without that line | 13:03 |
gibi | stephenfin: could be some rebase artifact | 13:04 |
*** shaohe_feng has joined #openstack-nova | 13:04 | |
*** sridharg has joined #openstack-nova | 13:04 | |
*** alexpilotti has joined #openstack-nova | 13:05 | |
*** gongysh has joined #openstack-nova | 13:06 | |
*** Eran_Kuris has quit IRC | 13:07 | |
gibi | stephenfin: tests pass without it so I'm going to respin the patch | 13:12 |
*** shaohe_feng has quit IRC | 13:13 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | 13:13 |
gibi | stephenfin: ^^ removed the extra line | 13:14 |
*** shaohe_feng has joined #openstack-nova | 13:14 | |
stephenfin | gibi: Cool. +2 now | 13:14 |
gibi | cdent: stephenfin thanks | 13:15 |
gibi | bahh | 13:16 |
gibi | stephenfin: thanks | 13:16 |
*** lei-zh has quit IRC | 13:16 | |
*** lei-zh has joined #openstack-nova | 13:17 | |
*** Eran_Kuris has joined #openstack-nova | 13:20 | |
*** ccamacho has quit IRC | 13:20 | |
*** alexchadin has quit IRC | 13:21 | |
kashyap | mdbooth_: Hi, when you get a moment, I'm blind and can't figure out why 'migrate_uri' is still "None" in the actual call here: http://paste.openstack.org/show/726442/ | 13:22 |
kashyap | Please enlighten, throw rotten tomatoes, etc. | 13:22 |
*** shaohe_feng has quit IRC | 13:23 | |
*** shaohe_feng has joined #openstack-nova | 13:24 | |
alex_xu | mriedem: re: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2018-07-20.log.html#t2018-07-20T13:20:30 | 13:24 |
alex_xu | mriedem: agree with just merge 'server create' part in Rocky | 13:24 |
tssurya | alex_xu: so the merge into view builder would only be in Stein? | 13:25 |
*** alexchadin has joined #openstack-nova | 13:26 | |
alex_xu | tssurya: yea, is there anything you need about view builder, I see there are something you need, but I didn't follow it yet | 13:26 |
*** Bhujay has quit IRC | 13:26 | |
tssurya | alex_xu: yea, its mainly for this patch: https://review.openstack.org/#/c/567785/ | 13:26 |
tssurya | related to the handling a down cell, I need to basically return a minimal response for nova show and list servers | 13:27 |
*** takashin has joined #openstack-nova | 13:27 | |
alex_xu | tssurya: got it, let me check, thanks | 13:27 |
tssurya | for which I would have to handle it seperately for each of the deprecated extensions since they are being merged into the response individually | 13:27 |
tssurya | alex_xu: thanks | 13:27 |
mriedem | alex_xu: yeah gmann has some patches up in the same series for moving things from extensions to server view builder, | 13:29 |
mriedem | but with the state of the gate the last couple of weeks, i doubt all of this will get merged before feature freeze | 13:29 |
*** Eran_Kuris has quit IRC | 13:30 | |
tssurya | mriedem: meanwhile I have a patch for nova service-list here : https://review.openstack.org/#/c/584829/ | 13:31 |
*** lbragstad has joined #openstack-nova | 13:31 | |
tssurya | which doesn't depend on those changes | 13:31 |
* tssurya wiritng the version bump test case for that | 13:32 | |
*** sridharg has quit IRC | 13:32 | |
*** sridharg has joined #openstack-nova | 13:32 | |
mriedem | tssurya: i assumed that the service list and server list changes for partial results would all be in the same microversion | 13:32 |
*** mhg has joined #openstack-nova | 13:32 | |
mriedem | it's kind of weird if they aren't | 13:32 |
tssurya | and then I will also do the poliy change for nova boot | 13:32 |
tssurya | mriedem: true that, | 13:32 |
tssurya | so we stall the API changes for now ? | 13:32 |
tssurya | or nvm, I will keep working on them and we can see, | 13:33 |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Fix the help text for server-group-create https://review.openstack.org/584709 | 13:33 |
mriedem | i don't think the server list/show partial results stuff will get in rocky at this rate, if i'm being honest | 13:33 |
tssurya | mriedem: got it | 13:33 |
mriedem | i think we're way too close to feature freeze for a change like that, and even if we approved it all today, it would take 4 days to merge | 13:33 |
*** shaohe_feng has quit IRC | 13:33 | |
mriedem | but we can see what dansmith and melwitt think about doing the service list partial results in a separate microversion for rocky since that's much smaller scope and admin-only so impacts are smaller | 13:34 |
gmann | mriedem: yeah, 5-6 are on zuul -2 let’s see how much gets in | 13:34 |
tssurya | mriedem: hmm ack | 13:34 |
*** shaohe_feng has joined #openstack-nova | 13:35 | |
mriedem | tssurya: my personal goal for the bp is getting the queued_for_delete data migration in for rocky, which means choosing between yours and dan's | 13:35 |
tssurya | mriedem: right, okay let's wait for dansmith then | 13:35 |
dansmith | mriedem: I guess I would think returning shell results for missing services would be super low priority to me | 13:35 |
dansmith | mriedem: if a cell is down and we just return the services we can find, I would think the admins would be fine with that given they know the cell is down | 13:36 |
mriedem | dansmith: as in might as well make them a single microversion | 13:36 |
*** amrith has quit IRC | 13:36 | |
mriedem | them = nova list & service list | 13:36 |
dansmith | mriedem: we are already returning partial results for service list if a cell is down right? | 13:36 |
mriedem | yes | 13:36 |
mriedem | tssurya did the fix for that as a bug | 13:37 |
tssurya | not partial results, | 13:37 |
tssurya | like skips that cell | 13:37 |
dansmith | I'm saying, focus on instance list returning shell instances to patch up the instance list, but not care about service list | 13:37 |
dansmith | tssurya: that's what I mean by partial results | 13:37 |
dansmith | just omitting the downed cell | 13:37 |
tssurya | ah yes sorry, | 13:37 |
dansmith | I'm not sure why we really need to try to patch up the service list tbh | 13:37 |
dansmith | and I imagine it's going to be hard | 13:38 |
*** belmoreira has joined #openstack-nova | 13:38 | |
mriedem | you can patch up the compute services, but that's about it | 13:38 |
tssurya | yea just the host and binary fields | 13:38 |
mriedem | i don't think it's all that hard. the value question is the question | 13:38 |
dansmith | I always get this confused, but aren't the host mappings done by compute node and not service? | 13:38 |
mriedem | should be the service | 13:39 |
dansmith | it's by compute node by default, | 13:39 |
tssurya | I guess its compute-node for normal cases and service for ironic ? | 13:39 |
dansmith | I added by-service recently | 13:39 |
mriedem | sure, but https://github.com/openstack/nova/commit/64e76de43dc55e584c100005fa60da50dd06d352 | 13:40 |
mriedem | oops | 13:40 |
mriedem | HostMapping.get_by_host(ctxt, compute.host) | 13:40 |
mriedem | the host mappings are still 1:1 with the nova-compute service host | 13:40 |
dansmith | ah, compute.host is service host yeah? | 13:40 |
dansmith | okay | 13:40 |
mriedem | there isn't a host mapping per compute.hypervisor_hostname | 13:40 |
mriedem | which is the 1:M thing | 13:40 |
dansmith | right right okay | 13:40 |
*** alexchadin has quit IRC | 13:40 | |
dansmith | I was thinking it would be hard if it was one mapping per node, but fair enough | 13:41 |
dansmith | anyway, it just seems like really low prio to me | 13:41 |
dansmith | brb | 13:41 |
mriedem | given ^ why did we need the discover by service again? | 13:41 |
*** alexchadin has joined #openstack-nova | 13:41 | |
*** alexchadin has quit IRC | 13:41 | |
mriedem | oh b/c ironic doesn't have the nodes yet | 13:42 |
mriedem | by the time we need to discover the hosts | 13:42 |
*** alexchadin has joined #openstack-nova | 13:42 | |
*** tetsuro has joined #openstack-nova | 13:42 | |
*** alexchadin has quit IRC | 13:42 | |
mriedem | anyway, i agree doing shell results for service list is also low(er) priority so that's why i figured it would be part of the single microversion for doing nova list/show shell results | 13:42 |
*** alexchadin has joined #openstack-nova | 13:43 | |
*** alexchadin has quit IRC | 13:43 | |
tssurya | okay, so we do all of that in the same microversion then | 13:43 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459 | 13:43 |
*** alexchadin has joined #openstack-nova | 13:43 | |
*** alexchadin has quit IRC | 13:44 | |
*** shaohe_feng has quit IRC | 13:44 | |
tssurya | and for now, we just decide to go with dansmith's migration ? thb, I don't have any particular preference between the two patches | 13:44 |
tssurya | so both works for us | 13:44 |
*** shaohe_feng has joined #openstack-nova | 13:44 | |
*** Eran_Kuris has joined #openstack-nova | 13:45 | |
dansmith | mriedem: well my point about being lower priority meant I wouldn't want to hold up the instance side for the service side | 13:45 |
mriedem | dansmith: sure, she has the service one done* | 13:46 |
mriedem | and i'm saying i figured just leave it until the instance one is done and make them a single microversion | 13:46 |
mriedem | then that is the "down cell" microversion | 13:47 |
mriedem | but that's just how i've always been thinking this would happen | 13:47 |
dansmith | oh I see, | 13:47 |
dansmith | I had assumed the opposite | 13:47 |
dansmith | (that the instance one was done already) | 13:47 |
dansmith | my fault for not being up to date | 13:47 |
tssurya | nova list is held up for now because it would be neater if this goes in: https://review.openstack.org/#/q/topic:bp/api-extensions-merge-rocky+(status:open+OR+status:merged) | 13:48 |
mriedem | and we'll be lucky to just get ^ in to rocky | 13:48 |
mriedem | given our current merge rates | 13:48 |
dansmith | oye | 13:48 |
mriedem | it's taken a week to land code right now | 13:48 |
*** r-daneel has joined #openstack-nova | 13:49 | |
dansmith | yarp | 13:49 |
mriedem | so i'm really only mostly interested in pushing things across the line this week that is already ready to go and has had a lot of review already | 13:49 |
mriedem | personally, | 13:49 |
mriedem | plus i'm going to have a shitty week with some personal stuff going on so won't be fully available | 13:49 |
*** gongysh has quit IRC | 13:50 | |
pooja_jadhav | dansmith: hello | 13:50 |
*** gongysh has joined #openstack-nova | 13:50 | |
dansmith | mriedem: ack | 13:50 |
dansmith | pooja_jadhav: hi | 13:50 |
efried | Scheduler meeting in ten minutes in #openstack-meeting-alt | 13:50 |
tssurya | mriedem: ack thanks a lot for all the time an review doen on this spec (if I haven't yet thanked you) | 13:50 |
tssurya | dansmith: thanks to you too for all the help and reviews | 13:51 |
pooja_jadhav | dansmith: Actually, gone through your patch, https://review.openstack.org/#/c/580720/. Now testing the move operations (resize, unshelve, evacuate and migrate). | 13:51 |
*** mdnadeem_ has quit IRC | 13:52 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Online data migration for queued_for_delete flag https://review.openstack.org/584504 | 13:52 |
dansmith | tssurya: mriedem: fixed py35 issue in the test ^ | 13:53 |
mriedem | pooja_jadhav: are there problems or you're just letting us know you're testing? | 13:53 |
mriedem | pooja_jadhav: also, thanks for testing this stuff | 13:53 |
tssurya | dansmith: ack | 13:53 |
pooja_jadhav | dansmith, mriedem: I have 2 nodes, I am facing issue for migrate API. Can u tell me what are the pre requisites? | 13:53 |
mriedem | pooja_jadhav: cold migrate? | 13:54 |
*** shaohe_feng has quit IRC | 13:54 | |
mriedem | unless the nodes are on the same shared storage pool you have to configure ssh access for the nova user between the nodes | 13:54 |
pooja_jadhav | mriedem, dansmith: for unshelve, there is issue (DISK_GB record is added after unshelve the instance). | 13:55 |
*** shaohe_feng has joined #openstack-nova | 13:55 | |
mriedem | pooja_jadhav: added where? | 13:55 |
dansmith | mriedem: you have a patch for that right? | 13:55 |
mriedem | to placement? | 13:55 |
mriedem | dansmith: yeah | 13:55 |
pooja_jadhav | mriedem: yes, in the allocation table | 13:55 |
pooja_jadhav | can I provide the details, I have tested? | 13:56 |
mriedem | unshelve should be handled here https://review.openstack.org/#/c/583715/3/nova/conductor/manager.py@806 | 13:56 |
mriedem | i could update the functional test in that change to run a shelve/unshelve routine to make sure DISK_GB still doesn't show up in placement allocations | 13:57 |
pooja_jadhav | mriedem: cold/live migrate (both trying to test) | 13:58 |
mriedem | damn i have to rebase this series because https://review.openstack.org/#/c/583646/ was rebased | 13:58 |
mriedem | pooja_jadhav: https://docs.openstack.org/devstack/latest/guides/multinode-lab.html | 13:58 |
mriedem | if you're using devstack | 13:58 |
*** hongbin has joined #openstack-nova | 13:59 | |
pooja_jadhav | mriedem: thanks, will check and let u know if the queries :) | 13:59 |
pooja_jadhav | yes, I am using devstack | 14:00 |
mriedem | that doc might be old | 14:00 |
*** amrith has joined #openstack-nova | 14:00 | |
*** amrith is now known as Guest98766 | 14:01 | |
*** Guest98766 has quit IRC | 14:02 | |
*** amrith_ has joined #openstack-nova | 14:02 | |
*** alexchadin has joined #openstack-nova | 14:02 | |
*** adrianc_ has quit IRC | 14:03 | |
*** amrith_ is now known as Guest58828 | 14:03 | |
*** eharney has joined #openstack-nova | 14:03 | |
*** alexpilotti has quit IRC | 14:04 | |
*** shaohe_feng has quit IRC | 14:04 | |
pooja_jadhav | mriedem: Also tested resize and evacuate, but no allocation records get added for DISK_GB. | 14:04 |
*** shaohe_feng has joined #openstack-nova | 14:05 | |
pooja_jadhav | mriedem: But for evacuate, hypervisor-stats showing incorrect incorrect usages. | 14:06 |
openstackgerrit | Boxiang Zhu proposed openstack/nova stable/pike: Fix "instance snap min disk size err after resize instance" https://review.openstack.org/584770 | 14:06 |
*** alexchadin has quit IRC | 14:08 | |
*** psachin` has quit IRC | 14:08 | |
*** gongysh has quit IRC | 14:08 | |
mriedem | pooja_jadhav: we already know that hypervisor-stats has latent bugs for reporting disk based on the flavor and not if the server is volume-backed | 14:08 |
mriedem | that's what https://review.openstack.org/#/c/583646/ shows | 14:09 |
pooja_jadhav | mriedem: Ohk | 14:09 |
*** ccamacho has joined #openstack-nova | 14:09 | |
*** tbachman has joined #openstack-nova | 14:10 | |
pooja_jadhav | mriedem: Have tested live/cold migrate then? for allocation of DISK_GB or not? | 14:10 |
mriedem | pooja_jadhav: https://review.openstack.org/#/c/583715/ functionally tests that for cold migration | 14:11 |
mriedem | https://review.openstack.org/#/c/583715/3/nova/tests/functional/test_servers.py | 14:11 |
*** Luzi has quit IRC | 14:11 | |
mriedem | i was saying i could add a shelve/unshelve wrinkle to that test as well since you said you saw allocations for DISK_GB in placement after unshelve | 14:12 |
*** Eran_Kuris has quit IRC | 14:12 | |
*** cfriesen_ has joined #openstack-nova | 14:12 | |
mriedem | but i need to rebase this series now | 14:13 |
*** alexpilotti has joined #openstack-nova | 14:13 | |
*** jistr|mtg is now known as jistr | 14:13 | |
pooja_jadhav | mriedem: thanks :) | 14:14 |
*** shaohe_feng has quit IRC | 14:14 | |
*** shaohe_feng has joined #openstack-nova | 14:15 | |
*** alexpilotti has quit IRC | 14:15 | |
*** derekh has quit IRC | 14:19 | |
*** links has quit IRC | 14:22 | |
*** antosh has joined #openstack-nova | 14:23 | |
*** derekh has joined #openstack-nova | 14:23 | |
openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Add /reshaper handler for POST https://review.openstack.org/576927 | 14:24 |
*** shaohe_feng has quit IRC | 14:25 | |
*** Guest58828 has quit IRC | 14:25 | |
*** alexchadin has joined #openstack-nova | 14:26 | |
*** shaohe_feng has joined #openstack-nova | 14:27 | |
*** ispp has quit IRC | 14:27 | |
*** ispp has joined #openstack-nova | 14:30 | |
*** amrith- has joined #openstack-nova | 14:30 | |
*** armaan has quit IRC | 14:32 | |
*** armaan has joined #openstack-nova | 14:32 | |
*** dave-mccowan has quit IRC | 14:33 | |
*** shaohe_feng has quit IRC | 14:35 | |
*** shaohe_feng has joined #openstack-nova | 14:37 | |
*** Bhujay has joined #openstack-nova | 14:40 | |
*** purplerbot has quit IRC | 14:41 | |
*** purplerbot has joined #openstack-nova | 14:41 | |
*** dave-mccowan has joined #openstack-nova | 14:42 | |
*** lei-zh has quit IRC | 14:42 | |
*** tidwellr has joined #openstack-nova | 14:44 | |
*** mdbooth_ is now known as mdbooth | 14:45 | |
*** shaohe_feng has quit IRC | 14:45 | |
*** shaohe_feng has joined #openstack-nova | 14:47 | |
*** tetsuro has quit IRC | 14:48 | |
*** felipemonteiro has joined #openstack-nova | 14:51 | |
*** alexpilotti has joined #openstack-nova | 14:54 | |
*** shaohe_feng has quit IRC | 14:55 | |
*** felipemonteiro has quit IRC | 14:56 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove usage of migrateToURI{2} APIs https://review.openstack.org/567258 | 14:56 |
*** shaohe_feng has joined #openstack-nova | 14:57 | |
*** alexpilotti has quit IRC | 14:59 | |
*** AlexeyAbashkin has quit IRC | 14:59 | |
*** AlexeyAbashkin has joined #openstack-nova | 14:59 | |
mriedem | efried: hmm, looks like the retrying package might not be thread safe http://logs.openstack.org/03/583203/2/check/tempest-full-py3/0b5111a/controller/logs/screen-n-cond-cell1.txt.gz#_Jul_23_13_35_01_491350 | 14:59 |
mriedem | got a thread switch there which looks like it caused a failure during RT._update | 14:59 |
mriedem | well, maybe not | 15:00 |
*** hshiina has joined #openstack-nova | 15:00 | |
mriedem | could just be throwing me b/c it's in the trace b/c of the decorator | 15:00 |
*** chyka has joined #openstack-nova | 15:00 | |
*** beekneemech is now known as bnemec | 15:00 | |
mriedem | hit a messaging timeout, maybe just a slow node | 15:00 |
*** bnemec is now known as beekneemech | 15:01 | |
*** beekneemech is now known as bnemec | 15:01 | |
mriedem | yeah | 15:01 |
efried | mriedem: afaik, retrying doesn't use threads at all. Are you saying it has a global or something? | 15:01 |
mriedem | Jul 23 13:35:01.252889 ubuntu-xenial-packethost-us-west-1-0000896864 nova-compute[22210]: WARNING nova.servicegroup.drivers.db [None req-93269558-9418-452a-b391-8766a59984a5 tempest-TestVolumeSwap-747104316 tempest-TestVolumeSwap-747104316] Lost connection to nova-conductor for reporting service status.: oslo_messaging.exceptions.MessagingTimeout: Timed out waiting for a reply to message ID 06f920f1d628445b877ff4100980047e | 15:01 |
mriedem | efried: no i think it just threw me in the stacktrace | 15:01 |
efried | ight | 15:01 |
*** chyka has quit IRC | 15:02 | |
*** eharney has quit IRC | 15:02 | |
*** chyka has joined #openstack-nova | 15:02 | |
sean-k-mooney | QQ are the functional tests safe to run with devstack stacked? | 15:02 |
mriedem | nova tox -e functional? | 15:03 |
mriedem | they run in a venv so yes | 15:03 |
sean-k-mooney | ok cool was just wondering if i would get any failures due to haveing opentack running | 15:03 |
*** takashin has left #openstack-nova | 15:04 | |
*** rmart04_ has joined #openstack-nova | 15:05 | |
*** rmart04 has quit IRC | 15:06 | |
*** shaohe_feng has quit IRC | 15:06 | |
*** shaohe_feng has joined #openstack-nova | 15:08 | |
*** rmart04_ has quit IRC | 15:09 | |
*** belmoreira has quit IRC | 15:12 | |
*** yamamoto has joined #openstack-nova | 15:15 | |
stephenfin | mriedem: RE: numa-aware-vswitches and move operations. Rebuilds don't run through the scheduler and don't make claims so I ignore that kind of rebuild operation, right? | 15:15 |
*** eharney has joined #openstack-nova | 15:15 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Report 0 root_gb in resource tracker if instance is bfv. https://review.openstack.org/584204 | 15:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Heal RequestSpec.is_bfv for legacy instances during moves https://review.openstack.org/583715 | 15:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix wonky reqspec handling in conductor.unshelve_instance https://review.openstack.org/583739 | 15:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add shelve/unshelve wrinkle to volume-backed disk func test https://review.openstack.org/584931 | 15:15 |
mriedem | pooja_jadhav: ^ added a shelve/unshelve functional test to the end of the series and that shows things working as designed | 15:15 |
sean-k-mooney | stephenfin: rebuilds should still go through the scheuler | 15:16 |
mriedem | stephenfin: depends, what does the RUN_ON_REBUILD flag say for NUMATopologyFilter? | 15:16 |
mriedem | sean-k-mooney: not in all cases, and not for all filters | 15:16 |
*** shaohe_feng has quit IRC | 15:16 | |
*** AlexeyAbashkin has quit IRC | 15:16 | |
mriedem | stephenfin: and to be clear, you're talking about rebuild, not evacuate, yes? | 15:16 |
*** AlexeyAbashkin has joined #openstack-nova | 15:16 | |
mriedem | stephenfin: class NUMATopologyFilter(filters.BaseHostFilter): | 15:16 |
mriedem | """Filter on requested NUMA topology.""" | 15:16 |
mriedem | RUN_ON_REBUILD = True | 15:16 |
stephenfin | mriedem: It's True and yes | 15:17 |
mriedem | stephenfin: so then you need to put the stuff in the request spec if we're going through the scheduler during rebuild b/c the image changes | 15:17 |
mriedem | because image_props.get('hw_cpu_policy')] and image_props.get('hw_cpu_thread_policy')] | 15:17 |
mriedem | if the image changes, the numa stuff can change | 15:17 |
mriedem | stephenfin: rebuild isn't a move, but we have to validate the new image | 15:17 |
mriedem | *validate the new image still works on the current host | 15:18 |
*** shaohe_feng has joined #openstack-nova | 15:18 | |
sean-k-mooney | mriedem: a rebuilt instance could land on a different host then the instace was on previously though right. its effectivly a new boot with the same port/volumes as the original instance | 15:19 |
*** samueldmq has quit IRC | 15:19 | |
*** patrickeast has quit IRC | 15:19 | |
mriedem | sean-k-mooney: no | 15:19 |
mriedem | sean-k-mooney: are you talking about evacuate? | 15:19 |
*** yikun has quit IRC | 15:19 | |
*** test222___ has quit IRC | 15:19 | |
*** csatari has quit IRC | 15:19 | |
*** yamamoto has quit IRC | 15:20 | |
sean-k-mooney | no i taught if we rebuilt and the previous host was nolonger valid we would schdule to another host that was | 15:20 |
sean-k-mooney | i gues we just fail to rebuild | 15:20 |
*** raorn has quit IRC | 15:20 | |
*** andrewbogott has quit IRC | 15:20 | |
*** d34dh0r53 has quit IRC | 15:20 | |
*** lamt has quit IRC | 15:20 | |
*** TheJulia has quit IRC | 15:20 | |
*** theanalyst has quit IRC | 15:20 | |
*** ispp has quit IRC | 15:20 | |
*** Shilpa has joined #openstack-nova | 15:21 | |
*** Hazelesque has quit IRC | 15:21 | |
*** andreaf has quit IRC | 15:21 | |
mriedem | you get a novalidhost | 15:21 |
*** patrickeast has joined #openstack-nova | 15:21 | |
mriedem | if the rebuild + new image doesn't fit on the current host | 15:21 |
mriedem | instance goes to error state and you have to fix it | 15:21 |
*** samueldmq has joined #openstack-nova | 15:21 | |
*** raorn has joined #openstack-nova | 15:21 | |
*** ispp has joined #openstack-nova | 15:21 | |
mriedem | bauzas: ping https://review.openstack.org/#/c/583715/ | 15:22 |
*** Hazelesque has joined #openstack-nova | 15:22 | |
*** chason has quit IRC | 15:22 | |
*** lamt has joined #openstack-nova | 15:22 | |
*** csatari has joined #openstack-nova | 15:23 | |
mriedem | bauzas: also ping https://review.openstack.org/#/c/581813/ - that's the nova-status check for request spec migrations which means if we get that in rocky, we can drop the reqspec migrations and compat code in stein | 15:23 |
mriedem | which is something i desperatly want to do | 15:23 |
*** test222___ has joined #openstack-nova | 15:23 | |
sean-k-mooney | mriedem: right i was assuming we would hit the retry fileter and try another host but i guess not. in my mind i was assuming we did the host affinity for rebuil via a weigher rather then filtering to just the current host | 15:23 |
mriedem | that and spellcheck | 15:23 |
*** raorn has quit IRC | 15:23 | |
*** raorn has joined #openstack-nova | 15:23 | |
*** yikun has joined #openstack-nova | 15:23 | |
mriedem | sean-k-mooney: we pass a hint to the scheduler telling it to filter on the existing instance host | 15:23 |
*** Hazelesque has quit IRC | 15:24 | |
*** Hazelesque has joined #openstack-nova | 15:24 | |
*** chason has joined #openstack-nova | 15:24 | |
*** felipemonteiro has joined #openstack-nova | 15:24 | |
sean-k-mooney | mriedem: cool ill look into how that work more closely in the future. good to know | 15:24 |
*** lamt is now known as Guest23581 | 15:24 | |
*** andreaf has joined #openstack-nova | 15:25 | |
*** d34dh0r53 has joined #openstack-nova | 15:25 | |
mriedem | stephenfin: so i assume you might have 2 patches: 1 to add the physnet and tunneled plumbing to the nova.network.model.Network object and populate it during _build_network_info_model, and then another change to call some utils method in the various conductor spots to populate ReuqestSpec.network_metadata using instance.info_cache.network_info | 15:26 |
stephenfin | mriedem: That's exactly what I have, albeit rolled into one patch | 15:26 |
mriedem | stephenfin: btw, this change is doing the same call spots in conductor that you'll need https://review.openstack.org/#/c/583715/ | 15:26 |
*** shaohe_feng has quit IRC | 15:26 | |
stephenfin | mriedem: However, are you sure about the "scheduler getting called" bit. Comments/logic in the code suggest otherwise mriedem: Are you sure. Your comments here say something else https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L901-L916 | 15:26 |
*** shaohe_feng has joined #openstack-nova | 15:27 | |
mriedem | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L920 | 15:27 |
stephenfin | By rebuild I'm referring to the 'openstack server rebuild $NAME" command | 15:27 |
mriedem | note the "*unless* a new image # was specified" | 15:27 |
stephenfin | Riiiight, missed that | 15:28 |
mriedem | the rebuild_instance method in conductor manager is totally coupled to how the api code works | 15:28 |
stephenfin | So, what do I do in the "no new instance" case | 15:28 |
stephenfin | Happily carry on? | 15:28 |
mriedem | no request spec | 15:28 |
mriedem | ? | 15:28 |
sean-k-mooney | mriedem: even if the same image is passed we should proably reschdule as the image metadata could have changed | 15:28 |
mriedem | no new image? | 15:28 |
mriedem | stephenfin: if the image doesn't change, we don't call the scheduler | 15:29 |
mriedem | sean-k-mooney: yeah, maybe, which would be new logic in the api to detect that since we persist the original image properties on the instance system_metadata i think | 15:30 |
stephenfin | mriedem: Right, so I can't recalculate NUMA affinity for any network changes. That's OK, yeah? | 15:30 |
dansmith | mriedem: right, and I think we said that we shouldn't refuse a rebuild because an image has changed metadata since the user then has very little recourse | 15:30 |
mriedem | dansmith: i don't remember talking about image meta changing on the original image, but ok | 15:31 |
dansmith | I do | 15:31 |
sean-k-mooney | mriedem: hum well if we are using the cached copy it should safe but if we pull them down from glance then we might violate one of the image requests or not be able to supprot one of them | 15:31 |
mriedem | stephenfin: yes because we assume the network affinity on the same host for the same image hasn't changed | 15:31 |
stephenfin | mriedem: Sweet | 15:32 |
stephenfin | https://imgflip.com/i/2ejmw4 | 15:32 |
sean-k-mooney | dansmith: mriedem do we also use the embeded flavor on rebuild? changes to image meta on rebuild is logically the same as changes to flavour extra specs so we should proably have the same behavior | 15:34 |
dansmith | we do | 15:34 |
*** imacdonn has quit IRC | 15:34 | |
dansmith | I'm not actually sure we do use the embedded _image_ properties for rebuild, but I'm saying I don't think that's a problem | 15:35 |
*** TheJulia has joined #openstack-nova | 15:35 | |
mriedem | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3172 | 15:35 |
sean-k-mooney | i think we dont | 15:35 |
dansmith | because changing image metadata such that people can't continue to be on a host they're currently on is pretty bad | 15:35 |
dansmith | and | 15:35 |
dansmith | running instances aren't going to move, so not allowing a rebuild is very surprising to the user who knows nothing of such changes | 15:35 |
sean-k-mooney | dansmith: it might be unitentionaly also image metadata and images can be set by enduesrs | 15:35 |
*** ragiman has quit IRC | 15:36 | |
dansmith | yes, but they don't see the scheduling policy | 15:36 |
*** shaohe_feng has quit IRC | 15:36 | |
*** shaohe_feng has joined #openstack-nova | 15:38 | |
*** imacdonn has joined #openstack-nova | 15:38 | |
*** andrewbogott has joined #openstack-nova | 15:38 | |
sean-k-mooney | dansmith: so ya i just checked locally we do use the updated image meta on rebuild | 15:39 |
*** manjeets has joined #openstack-nova | 15:40 | |
*** alexchadin has quit IRC | 15:44 | |
*** itlinux has joined #openstack-nova | 15:44 | |
sean-k-mooney | i guess this is one of those things that an operator should not do. i would feel more comfortable with always going to the schduler but i guess that would be a behavior change so it would need at least a microversion bump. | 15:46 |
*** abhishekk has joined #openstack-nova | 15:46 | |
*** ispp has quit IRC | 15:47 | |
*** shaohe_feng has quit IRC | 15:47 | |
*** mdbooth has quit IRC | 15:47 | |
*** andrewbogott has quit IRC | 15:48 | |
*** andrewbogott has joined #openstack-nova | 15:48 | |
*** hshiina has quit IRC | 15:49 | |
sean-k-mooney | stephenfin: fyi, when cpus and memory are modeled in placement as the numa topoloy can be altered via the image metadata you will have to recalulate it on rebuild and check if the placement allocation still fufil the request even when we use the same image since we do not use a cached copy of the image metadata. | 15:50 |
*** lei-zh has joined #openstack-nova | 15:50 | |
*** gyee has joined #openstack-nova | 15:51 | |
*** lpetrut has quit IRC | 15:53 | |
stephenfin | sean-k-mooney: Sounds fair. Best tell jaypipes to get a move on then ;) | 15:53 |
s10 | Hi. Is there any possibility to somehow optimise host_state.update(), which runs on every instance scheduling? Specifically this: https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L181 | 15:53 |
s10 | Our tests show, that this step (loading list of instances to the host_state) takes ~10 seconds for deployments with thousands of instances and hundreds of hosts. | 15:53 |
s10 | So if we want to start 1000 new instances with 6 nova-scheduler process, without this step (if we commented it out), all of them end up being started tens of minutes faster. | 15:53 |
*** shaohe_feng has joined #openstack-nova | 15:54 | |
sean-k-mooney | stephenfin: well personally i think simply always going to the schduler on a rebuild would be a better change since the numatopolgy filter would assert the correct behavior | 15:55 |
cdent | s10: I'd recommend posting to the openstack-dev list about that. It's a topic that I've seen come up from multiple peope lately, and they're not all here rightnow. | 15:55 |
*** udesale has quit IRC | 15:56 | |
mriedem | s10: yeah it's a known issue, i have a semi-related patch, sec | 15:56 |
mriedem | s10: https://review.openstack.org/#/c/569247/ | 15:57 |
s10 | I see https://bugs.launchpad.net/nova/+bug/1737465 | 15:57 |
openstack | Launchpad bug 1737465 in OpenStack Compute (nova) "[cellv2] the performance issue of cellv2 when creating 500 instances concurrently" [Medium,In progress] - Assigned to Matt Riedemann (mriedem) | 15:57 |
s10 | We use Pike | 15:57 |
*** shaohe_feng has quit IRC | 15:57 | |
sean-k-mooney | mriedem: s10 is this not required to make sure we are not using statle hostsate info? | 15:57 |
mriedem | s10: yes same related bug | 15:57 |
*** shaohe_feng has joined #openstack-nova | 15:57 | |
mriedem | sean-k-mooney: yes it is | 15:58 |
mriedem | for the affinity filters | 15:58 |
mriedem | s10: for starters, i've been hoping someone with a large enough deployment can tell me if this makes an improvement https://review.openstack.org/#/c/569247/ because CERN was reporting the same issue | 15:58 |
mriedem | s10: if you can test that out we could move it forward | 15:59 |
sean-k-mooney | mriedem: so commenting it out while faster would be incorrect unless we updated the afinit filters to get the updated info but that would break multicreate | 15:59 |
mriedem | there are more ways to optimize these calls | 15:59 |
*** rpittau has quit IRC | 15:59 | |
s10 | Yes, we can't really comment them out, because we rely on the anti-affinity filter for the octavia load-balancers. | 15:59 |
mriedem | the information is also somewhat cached and the computes rpc cast to the scheduler whenever an instance is created/deleted/moved assuming you have that setup | 16:00 |
s10 | And we use host_state.instances in our custom RealRamFilter... | 16:00 |
mriedem | that's the track_instance_changes config option, | 16:00 |
*** dave-mccowan has quit IRC | 16:00 | |
mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#filter_scheduler.track_instance_changes | 16:01 |
*** s1061123 has quit IRC | 16:01 | |
*** martin__ has joined #openstack-nova | 16:01 | |
mriedem | if you're doing split MQ though then the comptues can't reach the scheduler | 16:01 |
mriedem | and that doesn't help | 16:01 |
mriedem | we also know that we can optimize here https://review.openstack.org/#/c/571928/2/nova/scheduler/host_manager.py with some db join magic | 16:02 |
sean-k-mooney | mriedem: looking at https://review.openstack.org/#/c/569247 the optimisationis storing a list of uuids per host rather then the full instance objects correct? i can see how that would work for the in tree affintiy filters and the num instance weigher | 16:02 |
mriedem | sean-k-mooney: well it's also the db query | 16:03 |
*** mdbooth has joined #openstack-nova | 16:03 | |
mriedem | rather than query the full instance objects and such per host, just get the uuids | 16:03 |
*** rpittau has joined #openstack-nova | 16:04 | |
mriedem | s10: if you can test out https://review.openstack.org/#/c/569247/ and report back that would be very helpful in moving this forward | 16:04 |
sean-k-mooney | mriedem: sure that makes sense. | 16:04 |
cdent | mriedem, s10: whatever you work out here, it would still be great to see some kind of summary to the mailing list | 16:04 |
s10 | mriedem: Ok, I will test it | 16:05 |
s10 | mriedem: could this change be cherry-picked without rework to Pike? | 16:05 |
sean-k-mooney | s10 it looks pretty trivial in terms of code change. this would not qualify for backport however as it is not fixing a bug. it is a performance enhancement | 16:06 |
*** shaohe_feng has quit IRC | 16:07 | |
mriedem | s10: probably, there was another change merged in the series before it that you'll need https://review.openstack.org/#/q/topic:bug/1737465+(status:open+OR+status:merged) | 16:08 |
*** shaohe_feng has joined #openstack-nova | 16:08 | |
mriedem | https://review.openstack.org/#/q/Iccefbfdfa578515a004ef6ac718bac1a49d5c5fd | 16:08 |
mriedem | you'll need that in pike first | 16:09 |
mriedem | and then https://review.openstack.org/#/c/569247/ | 16:09 |
*** sahid has quit IRC | 16:09 | |
*** dave-mccowan has joined #openstack-nova | 16:09 | |
s10 | Our out-of-tree filter rely on host_state.instances.values(), we need values of the instance.memory_mb. Will we be hit with a lazy-load penalty in this case, with https://review.openstack.org/#/c/570083/? | 16:15 |
*** lei-zh has quit IRC | 16:15 | |
*** blkart has quit IRC | 16:16 | |
dansmith | yup | 16:16 |
*** blkart has joined #openstack-nova | 16:17 | |
*** shaohe_feng has quit IRC | 16:17 | |
sean-k-mooney | s10: what does your real ram filter actully check vs what placement will do? | 16:18 |
sean-k-mooney | s10: are you trying to disable oversubscription? | 16:19 |
*** shaohe_feng has joined #openstack-nova | 16:19 | |
s10 | sean-k-mooney: actual usage of the ram on compute nodes. Every QEMU process produces some memory overhead (up to 500-1000mb in some cases, depends on disk usage and rbd cached, I believe). Placement doesn't know anything about it and can schedule instance to the host, where real size of free ram is less than reserved_memory_mb. | 16:20 |
*** AlexeyAbashkin has quit IRC | 16:20 | |
mriedem | yeah we don't track overhead in placement, that's a known thing | 16:20 |
mriedem | and we've said for now, buffer that with reserved_host_memory_mb | 16:21 |
sean-k-mooney | s10: how are you getting the real host memory usage? | 16:21 |
mriedem | s10: also fyi http://lists.openstack.org/pipermail/openstack-dev/2018-May/130624.html | 16:23 |
s10 | We patched nova/scheduler/host_manager.py, added self.memory_mb_used = compute.memory_mb_used | 16:23 |
mriedem | s10: then why would you need host_state.instances.values()? | 16:23 |
*** dave-mccowan has quit IRC | 16:23 | |
s10 | Because without it we can't compute reserved_memory_mb, it's in config... | 16:23 |
*** theanalyst has joined #openstack-nova | 16:23 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Heal RequestSpec.is_bfv for legacy instances during moves https://review.openstack.org/583715 | 16:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix wonky reqspec handling in conductor.unshelve_instance https://review.openstack.org/583739 | 16:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add shelve/unshelve wrinkle to volume-backed disk func test https://review.openstack.org/584931 | 16:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Cache is_bfv check in ResourceTracker https://review.openstack.org/584962 | 16:24 |
s10 | Maybe we should pass reserved_memory_mb same way as we pass memory_mb_used... | 16:24 |
*** dave-mccowan has joined #openstack-nova | 16:24 | |
sean-k-mooney | s10: it would make sense to me to just embed the reserved memory in the host state object | 16:25 |
mriedem | to be clear, CONF.reserved_host_memory_mb is used to reserve capacity for MEMORY_MB in the compute node resource provider's inventory in placement | 16:25 |
mriedem | which is used to filter hosts before they even get to your filter | 16:25 |
*** Bhujay has quit IRC | 16:25 | |
mriedem | if you need to reserve space on the host for qemu/rbd, you should increase reserved_host_memory_mb per host | 16:25 |
s10 | But it is still calculated per compute, based on the config in nova-compute, right? | 16:26 |
mriedem | the config is read in compute yes | 16:26 |
mriedem | compute node memory_mb_used is later adjusted in the resource tracker based on the instance flavor | 16:27 |
mriedem | per instance on that host | 16:27 |
sean-k-mooney | mriedem: ture but s10's filter would catch the case where they did not reserve enough and the free ram is actully less then the reserved | 16:27 |
mriedem | but that information is also available via placement and is used to calculate the allocation candidates that the scheduler gets before we even hit the filters | 16:27 |
*** shaohe_feng has quit IRC | 16:28 | |
mriedem | sean-k-mooney: you might need to be conservative then in the reserved memory_mb | 16:28 |
sean-k-mooney | mriedem: placement only has allocations based on the flavor request. not the actul memory used by the instance | 16:28 |
mriedem | if this is a persistent problem | 16:28 |
mriedem | Kevin_Zheng: fyi https://review.openstack.org/#/c/584962/ | 16:29 |
s10 | We used reserved_host_memory_mb for that purpose, but it doesn't work well for us, some instances produces memory overhead over time, and in this case we might end up reserving 50% of host memory | 16:29 |
sean-k-mooney | mriedem: im just wondering could we symplify this by comparing free_ram_mb > reseved in the fileter if we added reserved to the hostsate object | 16:29 |
*** ekhugen has quit IRC | 16:30 | |
*** egarbade has quit IRC | 16:30 | |
mriedem | s10: hmm, ok, it would be helpful to write something up about this problem in the openstack-dev mailing list, tag the subject line with [nova] and describe the issue and what your scheduler filter does to resolve it | 16:30 |
*** shaohe_feng has joined #openstack-nova | 16:30 | |
*** dave-mccowan has quit IRC | 16:30 | |
mriedem | s10: upstream changes only affect out of tree filters while those filters are out of tree, | 16:30 |
mriedem | if your filter were in tree, we would have considered this when making that change | 16:30 |
*** s1061123 has joined #openstack-nova | 16:30 | |
*** mdrabe has quit IRC | 16:31 | |
sean-k-mooney | s10: well one of the main issue with reserved_host_memory_mb is that it does not take account of numa topology of the host so your instance can be killed by oom if you are not useing hugepages and a numa node is exausted but non local memory is free | 16:31 |
mriedem | sean-k-mooney: maybe, but solutions should be discussed in the ML | 16:31 |
s10 | Thank you. I will test performance with fixes for the host_state, and ask our developers to change our filter not to use host_state. | 16:31 |
sean-k-mooney | mriedem: sure :) it was just a taught | 16:31 |
mriedem | mostly just because this is a bad week with FF on thursday | 16:32 |
mriedem | don't really have time to design solutions for things that can go into the ML | 16:32 |
*** ekhugen has joined #openstack-nova | 16:34 | |
*** s1061123_ has joined #openstack-nova | 16:34 | |
sean-k-mooney | s10: is there a bug open for your usecase? its 2 late to adress in rocky but we could likely adrss in early stien if we captured the request. | 16:35 |
*** s1061123 has quit IRC | 16:35 | |
*** egarbade has joined #openstack-nova | 16:35 | |
s10 | sean-k-mooney: I didn't see bugs, related to real memory overhead problem. Only remember, that there was a thread in openstack-operators (?) | 16:38 |
*** shaohe_feng has quit IRC | 16:38 | |
*** shaohe_feng has joined #openstack-nova | 16:39 | |
s10 | https://bugs.launchpad.net/nova/+bug/1683858 | 16:40 |
openstack | Launchpad bug 1683858 in OpenStack Compute (nova) "Allocation records do not contain overhead information" [Medium,Won't fix] | 16:40 |
*** betherly_ is now known as betherly | 16:40 | |
sean-k-mooney | s10: based on the wording i assume that was suggesting this in placement hence the wont fix. | 16:41 |
sean-k-mooney | s10: i dont think placement is the right place to adress this but an in tree filter would be potentially reasonable. | 16:41 |
*** dave-mccowan has joined #openstack-nova | 16:43 | |
mriedem | stephenfin: we've got a runway slot opening so i'm going to throw the numa vswitch series back in ther | 16:44 |
mriedem | *there | 16:44 |
mriedem | just FYI | 16:44 |
*** armaan has quit IRC | 16:45 | |
stephenfin | Sweet. Should have that move thing done in a short bit | 16:45 |
*** armaan has joined #openstack-nova | 16:45 | |
*** pcaruana has quit IRC | 16:47 | |
*** shaohe_feng has quit IRC | 16:48 | |
*** dklyle has joined #openstack-nova | 16:49 | |
*** ccamacho has quit IRC | 16:49 | |
sean-k-mooney | s10: i wont promise anything but i have added this usecase to my whiteboard of random TODOs. i might see if i can come up with somthing for stien if there is still interest. | 16:49 |
*** AJaeger has joined #openstack-nova | 16:50 | |
AJaeger | nova cores, could you review https://review.openstack.org/#/c/583023/ to move the job in-tree, please? that'S a followup to work for os-vif. stephenfin and sean-k-mooney, want to look at it again, please? | 16:50 |
*** shaohe_feng has joined #openstack-nova | 16:51 | |
stephenfin | AJaeger: ack | 16:52 |
stephenfin | lyarwood: I didn't get to https://review.openstack.org/#/c/562072/ yet :( It's first thing I'm doing tomorrow morning though, I promise | 16:53 |
mriedem | dansmith should probably look at those | 16:53 |
mriedem | given evacness | 16:53 |
stephenfin | mriedem: Suits me down to the ground | 16:53 |
sean-k-mooney | AJaeger: will nova beable to import the job from os-vif? i just kicked off an experimental job to make sure it all works | 16:54 |
*** s10 has quit IRC | 16:55 | |
*** tssurya has quit IRC | 16:55 | |
*** _pewp_ has quit IRC | 16:56 | |
openstackgerrit | Merged openstack/nova master: perform reshaper operations in single transaction https://review.openstack.org/582383 | 16:57 |
*** _pewp_ has joined #openstack-nova | 16:57 | |
openstackgerrit | Merged openstack/nova master: Refactor _heal_instances_in_cell https://review.openstack.org/577896 | 16:57 |
AJaeger | sean-k-mooney: that'S how zuul was designed ;) | 16:58 |
AJaeger | sean-k-mooney: but yeah, I just have done that - thanks | 16:58 |
*** shaohe_feng has quit IRC | 16:58 | |
AJaeger | thanks, stephenfin | 16:59 |
*** shaohe_feng has joined #openstack-nova | 16:59 | |
*** adrianc_ has joined #openstack-nova | 16:59 | |
AJaeger | sean-k-mooney: it's "check experimental" | 17:00 |
sean-k-mooney | AJaeger: os-vif has to be whitelisted in the tenant config to suppy job definitons... that said it is in project-config already is so ya i guess this should work. | 17:00 |
AJaeger | sean-k-mooney: all active repos are in that list ;) | 17:00 |
sean-k-mooney | AJaeger: ya i was just getting a little confused with how i was configuring my thridparty ci when i was playying with zuulv3 | 17:01 |
*** GonZo2000 has quit IRC | 17:01 | |
*** felipemonteiro has quit IRC | 17:01 | |
*** felipemonteiro has joined #openstack-nova | 17:02 | |
*** tesseract has quit IRC | 17:02 | |
AJaeger | ;) | 17:02 |
*** derekh has quit IRC | 17:02 | |
AJaeger | sean-k-mooney: the job is scheduled to run according to zuul.openstack.org, so it's fine. | 17:02 |
*** felipemonteiro_ has joined #openstack-nova | 17:02 | |
*** adrianc_ has quit IRC | 17:04 | |
sean-k-mooney | AJaeger: yep i was just checking that myself | 17:04 |
openstackgerrit | Elod Illes proposed openstack/nova stable/queens: Call generate_image_url only for legacy notification https://review.openstack.org/584969 | 17:05 |
*** mvk_ has quit IRC | 17:05 | |
*** gongysh has joined #openstack-nova | 17:05 | |
AJaeger | ok, hope another core will review the job change in 583023 then - so that we can cleanup the infra files. | 17:06 |
*** felipemonteiro has quit IRC | 17:07 | |
*** shaohe_feng has quit IRC | 17:09 | |
sean-k-mooney | AJaeger: two quick questions by the way. i plan on converting it to a non legacy job. are there good examples of a vannily devstack job i can base it off. and 2 have ye updated the zuul from scratch to cover creating your own base job yet? | 17:10 |
*** shaohe_feng has joined #openstack-nova | 17:10 | |
sean-k-mooney | AJaeger: perhaps those are better asked on the zuul/infra channels instead. | 17:11 |
*** vivsoni__ has joined #openstack-nova | 17:11 | |
AJaeger | sean-k-mooney: for your second question: better ask on #zuul - I'm not involved there. For the devstack job, best ask andreaf on #openstack-qa. I know he converted some but don't know which one is a good example. You might want to search using codesearch, e.g. http://codesearch.openstack.org/?q=parent%3A%20devstack&i=nope&files=&repos= | 17:12 |
sean-k-mooney | AJaeger: thanks. its too late for rocky but i hope to convert the os-vif legacy job to non legacy and add a linux bridge version in the next month or so | 17:14 |
kashyap | cfriesen_: Thanks for the quick review | 17:17 |
AJaeger | sean-k-mooney: IMHO never too late to convert it ;) | 17:18 |
*** shaohe_feng has quit IRC | 17:19 | |
*** shaohe_feng has joined #openstack-nova | 17:20 | |
sean-k-mooney | AJaeger: well what i ment is we are past non-client ff so it wont be on the stable/rocky branch unless we backport it | 17:22 |
*** gongysh has quit IRC | 17:24 | |
*** dtantsur is now known as dtantsur|afk | 17:24 | |
*** s1061123_ has quit IRC | 17:26 | |
*** felipemonteiro_ has quit IRC | 17:27 | |
*** felipemonteiro_ has joined #openstack-nova | 17:27 | |
*** s1061123 has joined #openstack-nova | 17:28 | |
*** shaohe_feng has quit IRC | 17:29 | |
*** shaohe_feng has joined #openstack-nova | 17:31 | |
*** felipemonteiro_ has quit IRC | 17:31 | |
*** felipemonteiro has joined #openstack-nova | 17:33 | |
*** felipemonteiro_ has joined #openstack-nova | 17:35 | |
*** david-lyle has joined #openstack-nova | 17:36 | |
*** dklyle has quit IRC | 17:37 | |
*** felipemonteiro has quit IRC | 17:39 | |
*** yamahata has quit IRC | 17:39 | |
mriedem | stephenfin: heh, sorry, just meant dan has special context on that code | 17:39 |
mriedem | so he should (also) review it | 17:39 |
*** shaohe_feng has quit IRC | 17:39 | |
*** shaohe_feng has joined #openstack-nova | 17:40 | |
*** swamireddy has quit IRC | 17:44 | |
*** mvk_ has joined #openstack-nova | 17:44 | |
*** lpetrut has joined #openstack-nova | 17:46 | |
*** shaohe_feng has quit IRC | 17:50 | |
*** armaan has quit IRC | 17:50 | |
*** armaan has joined #openstack-nova | 17:51 | |
*** shaohe_feng has joined #openstack-nova | 17:51 | |
*** anupn_ has joined #openstack-nova | 17:52 | |
*** karimull has quit IRC | 17:52 | |
sean-k-mooney | do you ever read code and have to fight the urge to delete it all. | 17:52 |
*** anupn has quit IRC | 17:53 | |
*** manjeets has quit IRC | 17:53 | |
*** manjeets has joined #openstack-nova | 17:53 | |
*** karimull has joined #openstack-nova | 17:54 | |
*** shaohe_feng has quit IRC | 18:00 | |
*** shaohe_feng has joined #openstack-nova | 18:01 | |
*** armaan has quit IRC | 18:01 | |
*** armaan has joined #openstack-nova | 18:01 | |
*** med_ has quit IRC | 18:02 | |
AJaeger | sean-k-mooney: ah, yes | 18:02 |
*** david-lyle has quit IRC | 18:04 | |
*** dklyle has joined #openstack-nova | 18:04 | |
*** itlinux has quit IRC | 18:05 | |
mriedem | zzzeek: is there any major difference between doing a select query filter with == None vs == null() https://review.openstack.org/#/c/584504/3/nova/objects/instance_mapping.py@156 ? | 18:05 |
zzzeek | mriedem: shouldn't make a difference | 18:06 |
mriedem | ok thanks | 18:06 |
*** armaan has quit IRC | 18:06 | |
*** david-lyle has joined #openstack-nova | 18:07 | |
*** armaan has joined #openstack-nova | 18:07 | |
zzzeek | mriedem: null() is helpful in other cases where None might mean something different, like you want to force a SQL expression in some cases. but here == None will do "IS NULL" anyway | 18:07 |
*** dklyle has quit IRC | 18:07 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Use consumer generation in _heal_allocations_for_instance https://review.openstack.org/577905 | 18:10 |
*** r-daneel has quit IRC | 18:10 | |
*** shaohe_feng has quit IRC | 18:10 | |
*** shaohe_feng has joined #openstack-nova | 18:11 | |
*** yamahata has joined #openstack-nova | 18:12 | |
*** luzC has quit IRC | 18:12 | |
*** rmart04 has joined #openstack-nova | 18:12 | |
*** rmart04 has quit IRC | 18:13 | |
mriedem | dansmith: i'm +2 on your queued_for_delete migration, i guess we can rebase the series to swap those | 18:13 |
dansmith | cool | 18:13 |
mriedem | looks like powervm might have some ci issues http://184.172.12.213/17/560317/30/check/nova-in-tree-pvm/bf5d5bc/logs/stack.sh.txt.gz | 18:15 |
mriedem | error: command 'powerpc64le-linux-gnu-gcc' failed with exit status 1 | 18:15 |
mriedem | error: PIC register clobbered by ‘r30’ in ‘asm’ | 18:15 |
mriedem | powerkvm ci failing on the same https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/17/560317/30/check/tempest-dsvm-full-xenial/ac71b2d/devstacklog.txt.gz | 18:16 |
*** luzC has joined #openstack-nova | 18:16 | |
mriedem | edmondsw: ^ | 18:16 |
edmondsw | mriedem yep, we're aware, have a fix proposed to requirements to block greenlet 0.4.14 | 18:17 |
mriedem | https://pypi.org/project/greenlet/0.4.14/ | 18:17 |
mriedem | ah cool | 18:17 |
edmondsw | also broken the KVM CI from what I heard | 18:17 |
edmondsw | broke* | 18:17 |
mriedem | it did | 18:17 |
edmondsw | getting a little pushback from the requirements guys, so we'll see how this goes | 18:17 |
edmondsw | https://review.openstack.org/#/c/584881/ | 18:18 |
mriedem | yeah i'm looking at it | 18:18 |
edmondsw | just posted a comment in response | 18:18 |
mriedem | hmm, so in the before times we would have also blacklisted greenlet 0.4.14 in global-requirements.txt, | 18:19 |
mriedem | but that's per-project now, | 18:19 |
mriedem | so i'm wondering if nova can just blacklist 0.4.14 in nova's requirements.txt? | 18:20 |
mriedem | smcginnis: do you know ^ ? | 18:20 |
*** shaohe_feng has quit IRC | 18:20 | |
smcginnis | mriedem: Yeah, I believe Nova can just block that now. | 18:21 |
*** sridharg has quit IRC | 18:21 | |
*** shaohe_feng has joined #openstack-nova | 18:21 | |
*** sridharg has joined #openstack-nova | 18:21 | |
*** AJaeger has left #openstack-nova | 18:22 | |
*** david-lyle is now known as dklyle | 18:22 | |
*** sridharg has quit IRC | 18:25 | |
*** AlexeyAbashkin has joined #openstack-nova | 18:25 | |
*** abhishekk has quit IRC | 18:26 | |
smcginnis | FWIW, until the gcc issue gets clarified I think we should block it in requirements too. | 18:27 |
*** swamireddy has joined #openstack-nova | 18:27 | |
openstackgerrit | Merged openstack/nova master: Rename auth_uri to www_authenticate_uri https://review.openstack.org/576820 | 18:27 |
*** shaohe_feng has quit IRC | 18:31 | |
*** vivsoni__ has quit IRC | 18:31 | |
*** felipemonteiro_ has quit IRC | 18:33 | |
*** shaohe_feng has joined #openstack-nova | 18:33 | |
*** felipemonteiro_ has joined #openstack-nova | 18:34 | |
*** med_ has joined #openstack-nova | 18:34 | |
*** med_ has quit IRC | 18:34 | |
*** med_ has joined #openstack-nova | 18:34 | |
*** shaohe_feng has quit IRC | 18:41 | |
*** shaohe_feng has joined #openstack-nova | 18:42 | |
openstackgerrit | sean mooney proposed openstack/nova master: fix disk_bus handeling https://review.openstack.org/584999 | 18:43 |
*** med_ has quit IRC | 18:45 | |
*** tbachman has quit IRC | 18:45 | |
*** AlexeyAbashkin has quit IRC | 18:45 | |
*** lbragstad_ has joined #openstack-nova | 18:47 | |
*** lbragstad has quit IRC | 18:48 | |
*** med_ has joined #openstack-nova | 18:48 | |
*** med_ has quit IRC | 18:48 | |
*** med_ has joined #openstack-nova | 18:48 | |
*** lbragstad_ is now known as lbragstad | 18:51 | |
*** shaohe_feng has quit IRC | 18:51 | |
*** shaohe_feng has joined #openstack-nova | 18:52 | |
*** tbachman has joined #openstack-nova | 18:54 | |
openstackgerrit | Merged openstack/nova master: Func test for improper cn local DISK_GB reporting https://review.openstack.org/583646 | 18:55 |
openstackgerrit | Merged openstack/nova master: [placement] disallow additional fields in allocations https://review.openstack.org/583907 | 18:56 |
*** shaohe_feng has quit IRC | 19:01 | |
*** felipemonteiro_ is now known as felipemonteiro | 19:02 | |
*** arvindn05 has joined #openstack-nova | 19:03 | |
*** arvindn05 has left #openstack-nova | 19:03 | |
*** felipemonteiro_ has joined #openstack-nova | 19:04 | |
*** cdent has quit IRC | 19:04 | |
*** shaohe_feng has joined #openstack-nova | 19:05 | |
*** felipemonteiro has quit IRC | 19:07 | |
*** tbachman has quit IRC | 19:10 | |
*** shaohe_feng has quit IRC | 19:12 | |
*** shaohe_feng has joined #openstack-nova | 19:14 | |
mriedem | efried: if you agree with my comments on https://review.openstack.org/#/c/560317/ i'll update those quick | 19:15 |
*** blkart has quit IRC | 19:15 | |
efried | looking | 19:16 |
*** blkart has joined #openstack-nova | 19:16 | |
*** tbachman has joined #openstack-nova | 19:16 | |
mriedem | and i'll probably blacklist greenlet 0.4.14 in a change below this so we can get the powerkvm ci passing again | 19:17 |
efried | mriedem: I assume https://review.openstack.org/#/c/560317/30/nova/virt/libvirt/driver.py@8940 you meant, "I'd make this an info" | 19:18 |
efried | mriedem: I'm fine if you make those changes, sure. | 19:18 |
mriedem | yeah heh | 19:18 |
mriedem | ok will do | 19:18 |
efried | kashyap: You good with https://review.openstack.org/#/c/560317/ at this point? | 19:18 |
mriedem | kashyap is likely done for the day | 19:19 |
*** felipemonteiro_ has quit IRC | 19:20 | |
*** felipemonteiro_ has joined #openstack-nova | 19:21 | |
*** shaohe_feng has quit IRC | 19:22 | |
*** shaohe_feng has joined #openstack-nova | 19:23 | |
*** shaohe_feng has quit IRC | 19:32 | |
*** shaohe_feng has joined #openstack-nova | 19:33 | |
*** eharney has quit IRC | 19:35 | |
*** mdbooth has quit IRC | 19:39 | |
*** shaohe_feng has quit IRC | 19:42 | |
*** shaohe_feng has joined #openstack-nova | 19:43 | |
*** janki has quit IRC | 19:47 | |
*** r-daneel has joined #openstack-nova | 19:47 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add method to get cpu traits https://review.openstack.org/560317 | 19:53 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: FakeLibvirtFixture: mock get_fs_info https://review.openstack.org/579201 | 19:53 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Blacklist greenlet 0.4.14 https://review.openstack.org/585016 | 19:53 |
*** shaohe_feng has quit IRC | 19:53 | |
mriedem | edmondsw: ^ | 19:53 |
*** felipemonteiro_ has quit IRC | 19:53 | |
*** felipemonteiro_ has joined #openstack-nova | 19:54 | |
*** shaohe_feng has joined #openstack-nova | 19:54 | |
edmondsw | mriedem +1 | 19:55 |
edmondsw | mmedvede ^ | 19:55 |
*** shaohe_feng has quit IRC | 20:03 | |
*** hongbin has quit IRC | 20:05 | |
mnaser | lols here's interesting behaviour | 20:06 |
*** shaohe_feng has joined #openstack-nova | 20:07 | |
mnaser | list doesn't hit cells so vms that were stuck in 'scheduling' are shown when you list the vms in horizon | 20:07 |
mnaser | but then as horizon tries to 'refresh' them by doing a GET, nova returns a 404 | 20:07 |
mnaser | so they disappear afterwards | 20:07 |
dansmith | mnaser: what do you mean by "list doesn't hit cells" ? | 20:07 |
dansmith | also, GET on a scheduling vm shouldn't return a 404 | 20:08 |
mnaser | dansmith: well those are instances which seem to have gotten somehow stuck in 'scheduling' status | 20:08 |
mnaser | ok, let me verify this | 20:08 |
dansmith | oh, if they're scheduling they're not created in any cell, maybe that's what you mean, but list should still show them from their buildrequest of course | 20:08 |
*** brault has quit IRC | 20:08 | |
dansmith | and GET during/after should all work | 20:09 |
mnaser | well list seems to show them, but GET gives a 404 afaik | 20:09 |
*** edmondsw has quit IRC | 20:09 | |
mnaser | im double checking the behaviour | 20:09 |
mnaser | yeah, they show up in list, but GET gives 404 | 20:09 |
dansmith | something's broken then | 20:10 |
dansmith | that shouldn't happen | 20:10 |
mnaser | well i guess the db got in some weird state | 20:10 |
mnaser | or even if the db is mucked it shouldn't be like this? | 20:10 |
dansmith | well, depends on the level of mucking I guess, but.. it should never be like this | 20:11 |
mnaser | so as i understand it, list just grabs stuff from the 'api' db, but the 'get' actually hits the cell | 20:11 |
dansmith | no | 20:11 |
dansmith | list grabs stuff from the api and cell databases together | 20:11 |
mnaser | so it must know the mapping too i guess | 20:12 |
dansmith | get will pull the mapping from the api db, and if it looks like it is scheduled, will talk to the cell, and if not will return the build request data | 20:12 |
*** jmlowe has joined #openstack-nova | 20:12 | |
mnaser | ah okay | 20:12 |
mnaser | so it's in a state where it's doing neither talk to cell or return build request data | 20:12 |
dansmith | if it' | 20:12 |
dansmith | if it is 404'ing a scheduling instance, | 20:12 |
dansmith | then it's getting the mapping and then not returning the buildrequest or something | 20:13 |
*** shaohe_feng has quit IRC | 20:13 | |
dansmith | mnaser: all this logic is fairly straightforward here: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2298-L2357 | 20:14 |
dansmith | start with L2328 | 20:14 |
dansmith | we get the mapping (which should always exist once we've returned a uuid to the user) | 20:14 |
dansmith | maybe check to see if that failed to get written? | 20:14 |
mnaser | let me check the db mapping | 20:14 |
dansmith | if there's no mapping but it did get created in a cell, that would cause it to show up in list and not get | 20:14 |
dansmith | because of L2355 there | 20:15 |
*** brault has joined #openstack-nova | 20:15 | |
mnaser | cell_id=NULL in the db | 20:15 |
dansmith | that's what it should be for scheduling | 20:15 |
mnaser | so it should def go into the elif | 20:15 |
dansmith | that triggers L2333 to get it from the api db's buildrequest | 20:16 |
mnaser | let me check the build request | 20:16 |
mnaser | no build_request | 20:16 |
mriedem | i have a patch for this | 20:16 |
mriedem | https://review.openstack.org/#/c/575556/ ? | 20:16 |
*** jmlowe has quit IRC | 20:16 | |
mriedem | but that's listing, not showing | 20:16 |
mriedem | sounds similar though | 20:16 |
mriedem | build request is gone, instance mapping isn't pointing at a cell | 20:17 |
dansmith | and it's marker | 20:17 |
dansmith | how does that situation happen? | 20:17 |
mriedem | do not know | 20:17 |
mnaser | i mean | 20:17 |
*** shaohe_feng has joined #openstack-nova | 20:17 | |
dansmith | this patch doesn't address his problem, | 20:17 |
mnaser | rabbitmq had a field day a few days ago for us | 20:17 |
dansmith | but papers over it for list I guess | 20:17 |
mnaser | so i would totally attribute it to anything related to that | 20:17 |
mriedem | i believe jroll was seeing similar | 20:17 |
dansmith | mnaser: mm, shouldn't really as we don't use rabbit to create the instance in the cell db | 20:18 |
dansmith | well, | 20:18 |
mnaser | oh true | 20:18 |
dansmith | unless we dropped something between superconductors or something | 20:18 |
mnaser | no superconductor here | 20:18 |
mnaser | 1 cell, 1 conductor | 20:18 |
dansmith | s/super// | 20:18 |
mriedem | last i looked at this, we do have a window between the time we delete the build request and set the instance mapping cell | 20:18 |
*** felipemonteiro__ has joined #openstack-nova | 20:18 | |
dansmith | mriedem: we should be setting the mapping and then deleting the BR | 20:19 |
mnaser | wouldn't it be safer to set the instance mapping first and then delete the br? | 20:19 |
mnaser | yeah ^ | 20:19 |
dansmith | because that's how the get logic expects it to work | 20:19 |
dansmith | if the mapping is set, then BR is ignored | 20:19 |
dansmith | so we can delete it late | 20:19 |
dansmith | and that's what we're doing | 20:19 |
mriedem | schedule_and_build_instances in the conductor does set the cell in the instance mapping and then attempt to delete the build request, | 20:19 |
mriedem | but the build request can be deleted by the api first | 20:20 |
dansmith | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L1155-L1182 | 20:20 |
dansmith | that's for cell0 | 20:20 |
dansmith | which presumably is what his situation is if it never scheduled | 20:20 |
mriedem | not sure why we'd pass here https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L1178 | 20:20 |
dansmith | if it got deleted | 20:21 |
mriedem | the instance mapping? | 20:21 |
dansmith | on the non-cell0 case we also target the mapping before deleting the BR | 20:21 |
mriedem | why would that get deleted during scheduling | 20:21 |
mnaser | is it possible this happened when a vm was quickly deleted while it was scheduled | 20:21 |
dansmith | mriedem: if it got deleted by the user I mean | 20:21 |
mriedem | the instance mapping isn't deleted when the instance is deleted | 20:21 |
dansmith | mriedem: and we did a local delete because it wasn't scheudled | 20:21 |
dansmith | on local delete? | 20:21 |
mriedem | no | 20:21 |
mriedem | only on archive | 20:21 |
mnaser | let me check the actual cell db | 20:22 |
*** felipemonteiro_ has quit IRC | 20:22 | |
dansmith | mriedem: I think we delete them somewhere else | 20:22 |
dansmith | multi-create maube? | 20:22 |
mnaser | so this went to cell0 | 20:22 |
mnaser | and it's state in cell0 is 'scheduling' | 20:22 |
mriedem | dansmith: i'm pretty sure not, because that's what bauzas had originally written and we were against it in case the actual delete in the compute failed | 20:23 |
mnaser | deleted=0 in cell0 | 20:23 |
mnaser | so it's not even deleted | 20:23 |
dansmith | mriedem: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1271 | 20:23 |
mnaser | maybe this is something in the bury in cell0 code | 20:23 |
mriedem | dansmith: ok so before we even get to conductor | 20:23 |
*** brault has quit IRC | 20:23 | |
dansmith | yeah fair | 20:23 |
*** shaohe_feng has quit IRC | 20:23 | |
mriedem | if the instance mapping is gone and the build request is gone, shouldn't be able to list it | 20:23 |
*** brault has joined #openstack-nova | 20:23 | |
dansmith | we will though | 20:24 |
dansmith | becase we'll just hit each db and list anything we find, mappings be damned | 20:24 |
mriedem | but if we deleted the build request and instance mapping in ^ | 20:24 |
mriedem | we don't get to conductor to schedule | 20:24 |
mriedem | so we don't create the instance in any cell | 20:25 |
*** shaohe_feng has joined #openstack-nova | 20:25 | |
dansmith | yeah, in the delete_build_artifacts case yep, I meant if we end up with an instance in a cell with no mapping, | 20:25 |
dansmith | we'll still list it | 20:25 |
mriedem | sure, i just don't know how that could happen | 20:25 |
dansmith | well, I'm not sure how we could end up with a deleted BR and untargeted instance mapping | 20:26 |
*** felipemonteiro__ has quit IRC | 20:29 | |
*** felipemonteiro__ has joined #openstack-nova | 20:29 | |
mriedem | so we could delete a build request here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1848 | 20:30 |
mriedem | while scheduling | 20:30 |
mnaser | this was deleted via the api (while scheduling) | 20:30 |
mnaser | it def didnt fail to schedule | 20:30 |
*** lpetrut has quit IRC | 20:30 | |
mriedem | assuming we deleted the build request in the api, the api would check to see if the instance mapping is pointing at a cell yet https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1760 | 20:31 |
dansmith | if we do that, | 20:31 |
dansmith | we should also delete the instance in the cell db if we race with the conversion from BR to instance | 20:31 |
dansmith | but maybe we're slipping through those cracks | 20:31 |
*** alexpilotti has joined #openstack-nova | 20:31 | |
dansmith | here: https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L1184 | 20:32 |
dansmith | not really sure how that could be wrong tbh | 20:32 |
dansmith | either we fail to delete it "during booting" and then fall through to regular delete, | 20:33 |
mriedem | mnaser: so you have any old nova-osapi_compute services? https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1803 | 20:33 |
dansmith | or we succeed, conductor tries/fails to delete the BR, and destroys the instance | 20:33 |
mriedem | *do you have | 20:33 |
dansmith | or old service records | 20:33 |
mnaser | let me check the db rather than service-list | 20:33 |
mriedem | service list doesn't show api servies | 20:33 |
mriedem | so yeah you have to check the db | 20:33 |
*** shaohe_feng has quit IRC | 20:34 | |
mriedem | you could have some api services with version 0 from running with wsgi before we fixed that? | 20:34 |
*** slaweq has quit IRC | 20:34 | |
*** shaohe_feng has joined #openstack-nova | 20:34 | |
mnaser | there are some stale records but i see 16/22/30 | 20:34 |
*** eharney has joined #openstack-nova | 20:34 | |
mnaser | can i safely delete those older ones in the db | 20:35 |
mnaser | (no 0's though) | 20:35 |
* dansmith checks to see if he has anything on vexxhost | 20:35 | |
*** slaweq has joined #openstack-nova | 20:35 | |
mnaser | haha | 20:35 |
mriedem | it's checking for version < 15 so those shouldn't be a problem for this issue | 20:35 |
mnaser | truncate table services; | 20:35 |
mnaser | "it'll autopopulate" | 20:35 |
*** itlinux has joined #openstack-nova | 20:35 | |
*** alexpilotti has quit IRC | 20:36 | |
mriedem | dansmith: umm, couldn't we have an instance mapping with no cell mapping if we hit this? https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L1244 | 20:36 |
mriedem | api deletes the build request, we catch it and just continue | 20:37 |
dansmith | instance mapping with no cell is not a problem if the instance is deleted from the cell | 20:37 |
mriedem | in ^ the instance wouldn't be created in a cell | 20:37 |
mnaser | this instance was created in cell0 though (i checked via the db) | 20:38 |
dansmith | mriedem: then it wouldn't fit his problem | 20:38 |
mnaser | is _bury_in_cell0 the only codebase that puts things into cell0? | 20:38 |
dansmith | yeah | 20:39 |
mnaser | so we know it got at least to here - https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L1155 | 20:39 |
mnaser | let me check if it created bdms | 20:39 |
dansmith | should have, | 20:40 |
dansmith | nothing to stop it there I think | 20:40 |
dansmith | it must not have hit 1183 because if so, the instance would be deleted | 20:40 |
mnaser | are bdms created when one is given? | 20:40 |
mnaser | cause: select * from block_device_mapping where instance_uuid='f5ce0c5f-0484-496f-a497-6d1a1fb370d3'; => nada | 20:41 |
dansmith | when one is _not_ given? | 20:41 |
dansmith | I think we can have no BDMs here | 20:41 |
mnaser | yes sorry, when one is not given | 20:42 |
mriedem | when you're not booting from volume, | 20:42 |
mnaser | hmm | 20:42 |
mriedem | i want to say we create a bdm record for the local image | 20:42 |
mnaser | the status should be ERROR but the status in cell0 is not error | 20:42 |
*** yamamoto has joined #openstack-nova | 20:42 | |
mnaser | state in cell0 is building/scheduling | 20:43 |
mnaser | which it should not be? | 20:43 |
mriedem | _set_vm_state_and_notify probably failed then | 20:43 |
dansmith | I'm not sure where/when it goes to error | 20:43 |
mriedem | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L1166 | 20:43 |
mriedem | updates = {'vm_state': vm_states.ERROR, 'task_state': None} | 20:43 |
dansmith | maybe it failed on a task_state conflict? | 20:43 |
mriedem | scheduler_utils.set_vm_state_and_notify does a few things... | 20:43 |
mnaser | this should all be in the conductor right? | 20:44 |
dansmith | yeah | 20:44 |
mnaser | just to look at logs | 20:44 |
*** shaohe_feng has quit IRC | 20:44 | |
*** r-daneel_ has joined #openstack-nova | 20:44 | |
dansmith | oh | 20:44 |
dansmith | that could be the rabbit connection | 20:44 |
*** r-daneel has quit IRC | 20:44 | |
*** r-daneel_ is now known as r-daneel | 20:44 | |
dansmith | trying to send the notify | 20:44 |
dansmith | amirite? | 20:44 |
mriedem | we send the notification last, | 20:45 |
mriedem | and save the instance changes before that | 20:45 |
dansmith | ah | 20:45 |
mriedem | https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L600 | 20:45 |
dansmith | does get_notifier() fail if we can't talk to rabbit? | 20:45 |
mriedem | no idea | 20:46 |
*** shaohe_feng has joined #openstack-nova | 20:46 | |
mriedem | need to know if this is in the conductor logs for the instance in question https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L581 | 20:46 |
*** yamamoto has quit IRC | 20:46 | |
melwitt | mnaser: this is a similar bug jroll opened https://bugs.launchpad.net/nova/+bug/1775934 instance was in cell0 db but the instance mapping had cell_id = NULL | 20:47 |
openstack | Launchpad bug 1775934 in OpenStack Compute (nova) "Cannot run "openstack server list" with instance stuck in scheduling state" [Undecided,New] | 20:47 |
mriedem | melwitt: yeah see https://github.com/openstack/nova/blob/bcbc1f9aeddb060513768489450c429bf53e1e46/nova/conductor/manager.py#L1244 | 20:47 |
mriedem | we don't bury in cell0 there | 20:47 |
mriedem | so that might be what jroll hit | 20:47 |
melwitt | I don't think so bc his instance was buried in cell0 but the instance mapping did not reflect cell0, it was still pointing at NULL for cell_id | 20:48 |
*** brault_ has joined #openstack-nova | 20:48 | |
mriedem | that's what mnaser is seeing as well | 20:48 |
melwitt | okay, yeah so that's what dansmith was saying if the notify failed (or if nova-conductor somehow was restarted at the exact moment) we'd create in cell0 and not update the instance mapping | 20:50 |
*** brault has quit IRC | 20:51 | |
mnaser | yeah | 20:53 |
mnaser | rabbit was having a field day at that point in time | 20:53 |
dansmith | but the task/vm states should be updated, as mriedem was saying | 20:54 |
dansmith | and they're not | 20:54 |
mnaser | Unexpected error during heartbeart thread processing, retrying...: error: [Errno 104] ECONNRESET | 20:54 |
mriedem | mnaser: do you see this in the logs for that instance? https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L581 | 20:54 |
*** shaohe_feng has quit IRC | 20:54 | |
mnaser | in conductor right? | 20:54 |
mriedem | yeah | 20:55 |
mriedem | dansmith: oh btw, instance.save() sends it's own notification | 20:55 |
mriedem | i always forget about that | 20:55 |
dansmith | true story | 20:55 |
mriedem | should be after the db update | 20:55 |
*** shaohe_feng has joined #openstack-nova | 20:55 | |
mnaser | not a single reference to that instance id in the logs | 20:56 |
mnaser | :\ | 20:56 |
mnaser | in that range of time at least | 20:56 |
*** edmondsw has joined #openstack-nova | 20:56 | |
mnaser | unless zgrep is failing me but i dont think so | 20:56 |
dansmith | well, that's good | 20:56 |
dansmith | mnaser: whatabout https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L567 | 20:57 |
mnaser | i see other references to it but this instance odes not have one | 20:57 |
mriedem | Failed to compute_task_build_instances | 20:57 |
mnaser | let me get the tenant id of this vm | 20:58 |
mnaser | just no valid hosts | 20:58 |
openstackgerrit | Jim Rollenhagen proposed openstack/nova master: ironic: add instance_uuid before any other spawn activity https://review.openstack.org/563722 | 20:59 |
dansmith | and this if you have debug on: https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L1098 | 20:59 |
mnaser | hmm | 20:59 |
mnaser | "Failed to get aggregates for resource provider with UUID 04ae18f3-7226-4d0f-81f3-74a73eb1722a" | 20:59 |
mnaser | for some failures in the similar timeline | 20:59 |
dansmith | mnaser: and I guess you've looked for any stack traces in this instance's build time window yeah? | 20:59 |
mnaser | if an instance tries scheduling several times and fails does it end up in cell0 as well? | 21:00 |
jroll | melwitt: jaypipes: you were both +2 on https://review.openstack.org/#/c/563722/10, had a trivial rebase conflict | 21:00 |
*** munimeha1 has joined #openstack-nova | 21:00 | |
dansmith | mnaser: yeah | 21:00 |
dansmith | novalidhost -> cell0 | 21:00 |
mriedem | tries scheduling several times? | 21:00 |
*** jmlowe has joined #openstack-nova | 21:00 | |
mnaser | well as in | 21:00 |
mnaser | retrying build on another host | 21:00 |
mriedem | reschedules? | 21:00 |
mnaser | i guess thats the term | 21:00 |
mriedem | not in this case | 21:00 |
mriedem | reschedules happen within a cell | 21:00 |
mriedem | cell0 is when you don't get a host to start with | 21:01 |
dansmith | oh I guess that's right, once you've picked your first host, you're stuck in there | 21:01 |
mnaser | oh | 21:01 |
mnaser | uhoh | 21:01 |
mnaser | y'all are never gonna listen to me again | 21:01 |
dansmith | I was writing off a lot of that given that he's flat, but I guess that ain't right | 21:01 |
melwitt | jroll: +W | 21:01 |
mnaser | i just noticed a failure with | 21:01 |
mnaser | "WSREP has not yet prepared node for application use" | 21:01 |
jroll | melwitt: thanks | 21:01 |
mnaser | that is quite possibly the cause why | 21:02 |
dansmith | I don't know what that menas | 21:02 |
mnaser | it might have happened exactly in between the update for cells? | 21:02 |
mnaser | that message comes up if something happens with the galera cluster and it refuses to accept mysql requests | 21:02 |
mnaser | aka "i am bootstrapping and syncing up with other masters, leave me alone till im ready" | 21:03 |
dansmith | ah | 21:03 |
mnaser | so it refuses to complete read/writes | 21:03 |
openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST https://review.openstack.org/576927 | 21:03 |
openstackgerrit | Eric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider sane https://review.openstack.org/584598 | 21:03 |
dansmith | well, that would explain a dropped update | 21:03 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer https://review.openstack.org/584599 | 21:03 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648 | 21:03 |
openstackgerrit | Eric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories https://review.openstack.org/585033 | 21:03 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034 | 21:03 |
mnaser | urgh, sorry for the noise :( | 21:03 |
mriedem | mnaser: so you're thinking that happened during the save to make the instance in error state in cell0? | 21:03 |
mnaser | somehow galera manages to find more people than me to bother! | 21:03 |
mnaser | mriedem: my guess.. i cant imagine any other scenario | 21:03 |
mnaser | though i'm still so confused how like | 21:04 |
mriedem | btw, we could just put those updates on the instance before calling create() here so it's a single operation https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L1155 | 21:04 |
mnaser | i cant manage to find a SINGLE log entry for that instance uuid | 21:04 |
dansmith | mriedem: the state->error stuff you mean? | 21:04 |
*** shaohe_feng has quit IRC | 21:04 | |
mriedem | dansmith: right | 21:04 |
dansmith | yeah | 21:05 |
mriedem | saves us the other instance.save() later | 21:05 |
dansmith | although | 21:05 |
*** jmlowe has quit IRC | 21:05 | |
dansmith | I was wondering if that would mess up the notificaitons | 21:05 |
dansmith | so you'd get a create notification in error state, | 21:05 |
dansmith | instead of a create of scheduling and then another updated one with error, then deleted, etc | 21:05 |
*** shaohe_feng has joined #openstack-nova | 21:06 | |
mriedem | i don't know if that's a big problem | 21:06 |
mriedem | depends on the consumer i guess | 21:07 |
dansmith | well, if you're currently watching for instance.updated,vm_state=ERROR for your logging thing | 21:07 |
mriedem | but i'm pretty sure we are not good about notifications as a proper state machine | 21:07 |
dansmith | and now it's instance.created | 21:07 |
dansmith | yeah | 21:07 |
dansmith | obvi | 21:07 |
mriedem | still thinking this is a bad idea https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L1178 | 21:07 |
dansmith | we have to pass there or we won't clean up the BRs | 21:07 |
dansmith | log it maybe if you want | 21:08 |
mriedem | mnaser: did you say the instance mapping existed for this instance but the cell_mapping was NULL? | 21:08 |
dansmith | yes | 21:08 |
mriedem | which could be the case if the instance.save() in _set_vm_state_and_notify blew up | 21:09 |
mnaser | yes ^ | 21:10 |
mriedem | dansmith: also, doesn't it seem like we should bury in cell0 here? https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L1244 | 21:10 |
mriedem | seems like a glaring omission | 21:10 |
*** hongbin has joined #openstack-nova | 21:10 | |
mriedem | well, | 21:11 |
dansmith | I dunno, | 21:11 |
dansmith | we've picked a host/cell | 21:11 |
mriedem | i guess the idea is that if the user deleted the build request, and we don't create it in a cell, | 21:11 |
mriedem | then you can't list/show it | 21:11 |
dansmith | ah right this is the pre-create lookup | 21:11 |
*** itlinux has quit IRC | 21:12 | |
dansmith | could argue that you should still be able to show deleted I guess | 21:12 |
*** oomichi has joined #openstack-nova | 21:12 | |
dansmith | but not sure it's worth changing now | 21:12 |
mriedem | heh i guess i added that https://github.com/openstack/nova/commit/8ba92778fe14b47ad4ff5b53022e0550a93f37d3 | 21:12 |
mriedem | i knew it looked familiar | 21:12 |
dansmith | so on second thought it looks perfect? :) | 21:12 |
mriedem | it is pretty f'ing nice | 21:13 |
dansmith | you lost me about two minutes ago since 'Josie' came up on the jukebox | 21:13 |
dansmith | volume -> 100%, butt -> out of seat | 21:13 |
mriedem | well it is pretty funky | 21:14 |
*** shaohe_feng has quit IRC | 21:15 | |
eandersson | What is the general strategy for dealing with hypervisor maintenance (e.g. os updates etc)? | 21:15 |
eandersson | We wanted to look into a similar implementation to what Amazon does | 21:15 |
eandersson | Like tagging a hypervisor for downtime | 21:16 |
mriedem | there used to be a maintenance guide in the ops guide | 21:16 |
mnaser | i think that's beyond the scope of nova and more like business/operational processes | 21:16 |
mriedem | but i don't know where the ops guide stuff is being worked on now | 21:16 |
mriedem | https://github.com/openstack/openstack-manuals/blob/mitaka-eol/doc/ops-guide/source/ops_maintenance.rst | 21:17 |
eandersson | Yea - I was hoping that maybe someone wrote some exteranl tools for managing this already, or maybe even a feature inbuilt into nova to allow you to set a timer on a compute | 21:17 |
*** shaohe_feng has joined #openstack-nova | 21:17 | |
mnaser | i mean | 21:18 |
mriedem | didn't we talk about this at some point you and i? | 21:18 |
eandersson | We did | 21:18 |
mriedem | you can mark a compute as disabled from scheduling | 21:18 |
mnaser | and the user will see the status as 'maintenance' or something | 21:18 |
mriedem | https://developer.openstack.org/api-ref/compute/#compute-services-os-services | 21:18 |
mnaser | in the api | 21:18 |
mnaser | i think there is a hoststatus field or something | 21:18 |
mnaser | unless thats' admin only | 21:18 |
mriedem | the user doesn't see services | 21:18 |
mnaser | not but for vms running in that host | 21:18 |
mriedem | the guests on the host are unaffected if you disable the compute service | 21:18 |
mnaser | in /servers/<uuid> | 21:18 |
mriedem | you just can't schedule or migrate new instances to that host while the service is disabled | 21:19 |
mriedem | you can force the service status to 'down' to evacuate guests from it | 21:19 |
mriedem | but if it's up and normal otherwise just live migrate | 21:20 |
mnaser | eandersson: and for customer facing stuff, the nova instance has field 'host_status' which will be 'MAINTENANCE' if the vm is ona disabled host | 21:20 |
mnaser | so that might be a way to warn consumers that something will happen | 21:20 |
mnaser | if you wanna say disable it for a few days before | 21:20 |
* mriedem checks to see if mnaser forked that in | 21:21 | |
mnaser | https://developer.openstack.org/api-ref/compute/#show-server-details | 21:21 |
mnaser | i swear it's there >:( | 21:21 |
mriedem | oh right, | 21:21 |
mriedem | admin only by default | 21:21 |
mriedem | configurable via policy | 21:21 |
mnaser | ah yeah, so maybe that might be something you want to mess with policy then | 21:21 |
mriedem | and only with microversion >= 2.16 which is probably newer than eandersson has | 21:21 |
eandersson | Yea - we are working hard on upgrading to Queens.. but still stuck on Mitaka for now | 21:22 |
eandersson | Also, us NUMA pinning everything does not help | 21:23 |
mriedem | not if you actually want to move things | 21:23 |
mnaser | while latency goes down with NUMA pinning | 21:23 |
mnaser | i've noticed overall performance is not as good | 21:23 |
mnaser | for workloads in general | 21:24 |
eandersson | Gaming is a bit of a odd one unfortunately | 21:24 |
eandersson | latency is everything for players (and not only talking about network latency here :D) | 21:25 |
*** shaohe_feng has quit IRC | 21:25 | |
*** rcernin has joined #openstack-nova | 21:26 | |
*** shaohe_feng has joined #openstack-nova | 21:28 | |
*** munimeha1 has quit IRC | 21:30 | |
*** felipemonteiro_ has joined #openstack-nova | 21:31 | |
*** pchavva has quit IRC | 21:33 | |
*** felipemonteiro__ has quit IRC | 21:34 | |
*** shaohe_feng has quit IRC | 21:35 | |
*** Guest67313 has quit IRC | 21:35 | |
mriedem | dansmith: i was going to rebase the queued_for_delete series but jaypipes has comments on your migration patch (and the change below it in the series) https://review.openstack.org/#/c/584504/ so you should probably look first | 21:35 |
*** shaohe_feng has joined #openstack-nova | 21:36 | |
*** avolkov has quit IRC | 21:42 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Online data migration for queued_for_delete flag https://review.openstack.org/584504 | 21:43 |
dansmith | (that was just the rebase) | 21:43 |
*** shaohe_feng has quit IRC | 21:45 | |
*** shaohe_feng has joined #openstack-nova | 21:46 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Online data migration for queued_for_delete flag https://review.openstack.org/584504 | 21:48 |
openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST https://review.openstack.org/576927 | 21:50 |
openstackgerrit | Eric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories https://review.openstack.org/585033 | 21:50 |
openstackgerrit | Eric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider sane https://review.openstack.org/584598 | 21:50 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer https://review.openstack.org/584599 | 21:50 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648 | 21:50 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034 | 21:50 |
*** tidwellr has quit IRC | 21:51 | |
*** gongysh has joined #openstack-nova | 21:51 | |
jaypipes | dansmith, mriedem: I'm +2 on em. | 21:51 |
*** shaohe_feng has quit IRC | 21:56 | |
*** shaohe_feng has joined #openstack-nova | 21:56 | |
mriedem | that makes 2 of us | 21:58 |
mriedem | dansmith: there is an email in the ops ML with some cells v2 questions, i replied with what i could but might be a couple of things in there you want to expand on | 21:59 |
*** edmondsw has quit IRC | 22:04 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Update queued-for-delete from the ComputeAPI during deletion/restoration https://review.openstack.org/566813 | 22:05 |
*** antosh has quit IRC | 22:05 | |
*** shaohe_feng has quit IRC | 22:06 | |
*** shaohe_feng has joined #openstack-nova | 22:08 | |
openstackgerrit | Merged openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423 | 22:10 |
mriedem | oh wow something merged today | 22:13 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: link to CERN summit video about upgrading from cells v1 to v2 https://review.openstack.org/585044 | 22:16 |
*** shaohe_feng has quit IRC | 22:16 | |
*** shaohe_feng has joined #openstack-nova | 22:18 | |
*** slaweq has quit IRC | 22:23 | |
*** owalsh_ has joined #openstack-nova | 22:25 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: link to AZ talk from the Rocky summit https://review.openstack.org/585045 | 22:25 |
*** shaohe_feng has quit IRC | 22:26 | |
*** shaohe_feng has joined #openstack-nova | 22:27 | |
*** owalsh has quit IRC | 22:28 | |
*** owalsh- has joined #openstack-nova | 22:28 | |
*** antosh has joined #openstack-nova | 22:29 | |
*** hoonetorg has quit IRC | 22:31 | |
*** owalsh has joined #openstack-nova | 22:31 | |
*** owalsh_ has quit IRC | 22:31 | |
*** owalsh- has quit IRC | 22:34 | |
*** wolverineav has quit IRC | 22:34 | |
*** wolverineav has joined #openstack-nova | 22:35 | |
*** owalsh_ has joined #openstack-nova | 22:35 | |
*** owalsh has quit IRC | 22:36 | |
*** shaohe_feng has quit IRC | 22:37 | |
*** shaohe_feng has joined #openstack-nova | 22:37 | |
*** mriedem has quit IRC | 22:39 | |
*** wolverineav has quit IRC | 22:40 | |
*** shaohe_feng has quit IRC | 22:47 | |
*** hoonetorg has joined #openstack-nova | 22:47 | |
*** shaohe_feng has joined #openstack-nova | 22:48 | |
*** vladikr has quit IRC | 22:50 | |
*** hongbin has quit IRC | 22:50 | |
*** itlinux has joined #openstack-nova | 22:53 | |
*** martin__ has quit IRC | 22:55 | |
*** shaohe_feng has quit IRC | 22:57 | |
*** shaohe_feng has joined #openstack-nova | 22:58 | |
*** chyka has quit IRC | 23:02 | |
*** chyka has joined #openstack-nova | 23:03 | |
*** vladikr has joined #openstack-nova | 23:03 | |
*** mschuppert has quit IRC | 23:04 | |
*** yamamoto has joined #openstack-nova | 23:04 | |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Compute: Handle reshaped provider trees https://review.openstack.org/576236 | 23:06 |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Report client: update_from_provider_tree w/reshape https://review.openstack.org/585049 | 23:06 |
*** shaohe_feng has quit IRC | 23:07 | |
*** yamamoto has quit IRC | 23:08 | |
*** r-daneel has quit IRC | 23:08 | |
*** shaohe_feng has joined #openstack-nova | 23:09 | |
*** slaweq has joined #openstack-nova | 23:11 | |
*** felipemonteiro_ has quit IRC | 23:11 | |
*** slaweq has quit IRC | 23:16 | |
*** shaohe_feng has quit IRC | 23:18 | |
*** shaohe_feng has joined #openstack-nova | 23:18 | |
*** tetsuro has joined #openstack-nova | 23:19 | |
*** mriedem has joined #openstack-nova | 23:21 | |
*** oomichi has quit IRC | 23:24 | |
*** lpetrut has joined #openstack-nova | 23:26 | |
*** shaohe_feng has quit IRC | 23:28 | |
*** threestrands has joined #openstack-nova | 23:30 | |
*** lpetrut has quit IRC | 23:30 | |
*** shaohe_feng has joined #openstack-nova | 23:31 | |
*** shaohe_feng has quit IRC | 23:38 | |
*** edmondsw has joined #openstack-nova | 23:38 | |
*** vladikr has quit IRC | 23:38 | |
*** shaohe_feng has joined #openstack-nova | 23:39 | |
*** edmondsw has quit IRC | 23:43 | |
*** chyka has quit IRC | 23:48 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Enhance doc to guide user to use nova user https://review.openstack.org/583115 | 23:48 |
*** shaohe_feng has quit IRC | 23:48 | |
*** mriedem has quit IRC | 23:50 | |
*** shaohe_feng has joined #openstack-nova | 23:50 | |
*** takashin has joined #openstack-nova | 23:51 | |
*** vladikr has joined #openstack-nova | 23:52 | |
*** brault has joined #openstack-nova | 23:53 | |
*** brault_ has quit IRC | 23:55 | |
*** shaohe_feng has quit IRC | 23:59 | |
*** shaohe_feng has joined #openstack-nova | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!