Wednesday, 2018-07-25

*** shaohe_feng has quit IRC00:04
cfriesen_how much is "slightly higher"?00:05
*** shaohe_feng has joined #openstack-nova00:05
*** wolverineav has quit IRC00:06
*** wolverineav has joined #openstack-nova00:07
*** liuyulong has quit IRC00:08
*** artom has joined #openstack-nova00:09
*** slaweq has joined #openstack-nova00:11
*** medberry has joined #openstack-nova00:11
*** hongbin has joined #openstack-nova00:12
*** wolverineav has quit IRC00:14
*** hamzy_ has joined #openstack-nova00:14
*** shaohe_feng has quit IRC00:14
eanderssoncfriesen_, 2GB for ~128gb and 4GB for 256GB00:15
*** shaohe_feng has joined #openstack-nova00:15
*** slaweq has quit IRC00:16
*** takashin has joined #openstack-nova00:18
*** gongysh has quit IRC00:24
*** shaohe_feng has quit IRC00:25
*** shaohe_feng has joined #openstack-nova00:25
*** wolverineav has joined #openstack-nova00:26
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (5)  https://review.openstack.org/57084200:27
*** liuyulong has joined #openstack-nova00:28
*** wolverineav has quit IRC00:28
*** BrinZhang has joined #openstack-nova00:30
*** wolverineav has joined #openstack-nova00:32
*** shaohe_feng has quit IRC00:35
*** dave-mcc_ has quit IRC00:35
*** dklyle_ has quit IRC00:36
*** dklyle has joined #openstack-nova00:36
*** wolverineav has quit IRC00:36
*** shaohe_feng has joined #openstack-nova00:36
*** wolverineav has joined #openstack-nova00:40
eanderssoncfriesen_, basically in libvirt 1.x virsh nodeinfo and virsh nodememstats shows the same memory size00:41
eanderssonbut in 2+ the size is different (at least on our machines)00:41
mriedemcfriesen_: shouldn't, unless it's a reschedule00:43
mriedemin which case the compute doesn't pass the reqspec back up00:43
mriedemi have a patch for that00:43
mriedemcfriesen_: https://review.openstack.org/#/c/582417/00:43
mriedemneeds an rpc api change00:43
mriedemcfriesen_: but starting in queens we wouldn't call back to the scheduler on a reschedule because we have alternate hosts from the top level scheduling call00:45
mriedemand any instance created after newton would have a request spec, so that first RequestSpecNotFound block shouldn't be hit00:45
*** shaohe_feng has quit IRC00:45
*** wolverineav has quit IRC00:45
*** shaohe_feng has joined #openstack-nova00:46
mriedemcfriesen_: yeah i can't see how http://paste.openstack.org/show/726559/ is needed b/c the request spec has the original pci requests and that's what the scheduler filter uses00:46
mriedemand anything on the compute which claims using instance.pci_requests would lazy-load it00:46
*** wolverineav has joined #openstack-nova00:49
*** wolverineav has quit IRC00:54
*** shaohe_feng has quit IRC00:55
*** shaohe_feng has joined #openstack-nova00:57
*** wolverineav has joined #openstack-nova01:03
*** phuongnh has joined #openstack-nova01:03
*** phuongnh has quit IRC01:04
*** phuongnh has joined #openstack-nova01:04
*** shaohe_feng has quit IRC01:06
*** shaohe_feng has joined #openstack-nova01:07
*** wolverineav has quit IRC01:08
Kevin_Zhengmriedem, do you have a minute? I need some help on https://review.openstack.org/#/c/583927/01:11
*** slaweq has joined #openstack-nova01:11
*** mrsoul has joined #openstack-nova01:14
*** shaohe_feng has quit IRC01:16
*** slaweq has quit IRC01:16
*** GonZo2000 has quit IRC01:17
*** shaohe_feng has joined #openstack-nova01:17
*** mrsoul` has quit IRC01:17
*** yedongcan has joined #openstack-nova01:21
*** wolverineav has joined #openstack-nova01:21
*** wolverineav has quit IRC01:22
*** artom has quit IRC01:23
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (6)  https://review.openstack.org/57133001:26
*** shaohe_feng has quit IRC01:26
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (7)  https://review.openstack.org/57199201:26
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (8)  https://review.openstack.org/57199301:27
*** shaohe_feng has joined #openstack-nova01:27
openstackgerritMerged openstack/nova master: libvirt: use dest host vif migrate details for live migration  https://review.openstack.org/55137001:27
*** wolverineav has joined #openstack-nova01:28
*** links has joined #openstack-nova01:30
*** wolverineav has quit IRC01:32
*** wolverineav has joined #openstack-nova01:34
*** dave-mccowan has joined #openstack-nova01:35
*** tiendc has joined #openstack-nova01:35
*** shaohe_feng has quit IRC01:36
*** shaohe_feng has joined #openstack-nova01:37
*** wolverineav has quit IRC01:39
*** wolverineav has joined #openstack-nova01:41
*** yamahata has quit IRC01:43
*** trungnv has quit IRC01:46
*** trungnv has joined #openstack-nova01:46
*** shaohe_feng has quit IRC01:47
*** lei-zh has joined #openstack-nova01:47
*** shaohe_feng has joined #openstack-nova01:48
*** wolverineav has quit IRC01:49
*** gyee has quit IRC01:55
*** shaohe_feng has quit IRC01:57
*** shaohe_feng has joined #openstack-nova01:57
*** wolverineav has joined #openstack-nova01:59
*** gbarros has joined #openstack-nova02:02
*** wolverineav has quit IRC02:04
*** shaohe_feng has quit IRC02:07
*** shaohe_feng has joined #openstack-nova02:09
*** medberry has quit IRC02:11
*** slaweq has joined #openstack-nova02:11
*** gbarros has quit IRC02:12
*** Dinesh_Bhor has joined #openstack-nova02:13
*** yamahata has joined #openstack-nova02:15
*** slaweq has quit IRC02:16
*** wolverineav has joined #openstack-nova02:17
*** shaohe_feng has quit IRC02:17
*** tbachman has quit IRC02:18
*** shaohe_feng has joined #openstack-nova02:20
*** sapd has joined #openstack-nova02:21
*** wolverineav has quit IRC02:23
*** shaohe_feng has quit IRC02:28
*** wolverineav has joined #openstack-nova02:29
*** shaohe_feng has joined #openstack-nova02:29
*** dave-mccowan has quit IRC02:29
*** dave-mccowan has joined #openstack-nova02:30
*** gongysh has joined #openstack-nova02:30
*** alexpilo_ has joined #openstack-nova02:32
*** wolverineav has quit IRC02:33
*** StevenK has quit IRC02:35
*** alexpilotti has quit IRC02:35
*** StevenK has joined #openstack-nova02:35
*** alexpilo_ has quit IRC02:36
*** shaohe_feng has quit IRC02:38
*** shaohe_feng has joined #openstack-nova02:40
*** alexpilotti has joined #openstack-nova02:41
*** jmlowe has joined #openstack-nova02:43
openstackgerritTakashi NATSUME proposed openstack/nova master: Transform volume.usage notification  https://review.openstack.org/58034502:44
openstackgerritTakashi NATSUME proposed openstack/nova master: Transform libvirt.error notification  https://review.openstack.org/48485102:44
*** tbachman has joined #openstack-nova02:45
*** tbachman has quit IRC02:46
*** shaohe_feng has quit IRC02:48
*** shaohe_feng has joined #openstack-nova02:48
openstackgerritGhanshyam Mann proposed openstack/nova master: Merge server usage extension response into server view builder  https://review.openstack.org/58526202:53
*** brault has quit IRC02:53
*** tbachman has joined #openstack-nova02:56
*** brault has joined #openstack-nova02:57
*** shaohe_feng has quit IRC02:58
*** sapd has quit IRC02:58
*** shaohe_feng has joined #openstack-nova02:59
*** takashin has left #openstack-nova03:01
vishakhastephenfin, Hi. Are you working on https://bugs.launchpad.net/nova/+bug/1651319 ??03:06
openstackLaunchpad bug 1651319 in OpenStack Compute (nova) ""nova list --delete" failed due to InstanceNotFound exception" [Undecided,In progress] - Assigned to Stephen Finucane (stephenfinucane)03:06
*** sapd has joined #openstack-nova03:07
openstackgerritTakashi NATSUME proposed openstack/nova master: Add the guideline to write API reference  https://review.openstack.org/56905803:08
*** shaohe_feng has quit IRC03:09
*** dave-mcc_ has joined #openstack-nova03:09
*** shaohe_feng has joined #openstack-nova03:09
*** slaweq has joined #openstack-nova03:11
*** dave-mccowan has quit IRC03:12
*** dave-mcc_ has quit IRC03:12
*** armaan has joined #openstack-nova03:13
*** slaweq has quit IRC03:15
*** janki has joined #openstack-nova03:17
*** wolverineav has joined #openstack-nova03:17
*** shaohe_feng has quit IRC03:19
*** shaohe_feng has joined #openstack-nova03:20
*** wolverineav has quit IRC03:22
*** vladikr has quit IRC03:23
*** vladikr has joined #openstack-nova03:23
*** lei-zh has quit IRC03:28
*** zhurong has joined #openstack-nova03:29
*** vladikr has quit IRC03:29
*** lei-zh has joined #openstack-nova03:29
*** shaohe_feng has quit IRC03:29
*** vladikr has joined #openstack-nova03:30
*** shaohe_feng has joined #openstack-nova03:31
*** vladikr has quit IRC03:35
*** vladikr has joined #openstack-nova03:35
*** shaohe_feng has quit IRC03:39
*** shaohe_feng has joined #openstack-nova03:40
*** wolverineav has joined #openstack-nova03:40
*** vladikr has quit IRC03:41
*** vladikr has joined #openstack-nova03:42
*** vladikr has quit IRC03:47
*** vladikr has joined #openstack-nova03:47
*** wolverineav has quit IRC03:48
*** shaohe_feng has quit IRC03:50
*** wolverineav has joined #openstack-nova03:50
*** shaohe_feng has joined #openstack-nova03:51
*** lpetrut has joined #openstack-nova03:52
*** wolverineav has quit IRC03:55
*** vladikr has quit IRC03:55
*** vladikr has joined #openstack-nova03:56
*** shaohe_feng has quit IRC04:00
*** psachin` has joined #openstack-nova04:00
*** shaohe_feng has joined #openstack-nova04:01
*** tbachman has quit IRC04:04
*** psachin`` has joined #openstack-nova04:05
*** mschuppert has joined #openstack-nova04:06
*** psachin` has quit IRC04:07
*** shaohe_feng has quit IRC04:10
*** slaweq has joined #openstack-nova04:11
*** mdnadeem has joined #openstack-nova04:12
*** shaohe_feng has joined #openstack-nova04:12
*** wolverineav has joined #openstack-nova04:15
*** tbachman has joined #openstack-nova04:15
*** slaweq has quit IRC04:16
*** lei-zh has quit IRC04:17
*** armaan has quit IRC04:19
*** armaan has joined #openstack-nova04:20
*** wolverineav has quit IRC04:20
*** shaohe_feng has quit IRC04:20
*** shaohe_feng has joined #openstack-nova04:21
*** wolverineav has joined #openstack-nova04:22
*** wolverineav has quit IRC04:27
*** zhurong has quit IRC04:27
*** shaohe_feng has quit IRC04:31
*** s1061123 has quit IRC04:31
*** shaohe_feng has joined #openstack-nova04:31
*** wolverineav has joined #openstack-nova04:31
*** s1061123 has joined #openstack-nova04:36
*** tbachman has quit IRC04:37
*** r-daneel has joined #openstack-nova04:37
openstackgerritMerged openstack/nova master: compute: Ensure pre-migrating instances are destroyed during init_host  https://review.openstack.org/56228404:38
*** udesale has joined #openstack-nova04:39
*** wolverineav has quit IRC04:40
*** hongbin has quit IRC04:40
*** shaohe_feng has quit IRC04:41
*** shaohe_feng has joined #openstack-nova04:42
*** lpetrut has quit IRC04:42
*** udesale has quit IRC04:42
*** udesale has joined #openstack-nova04:43
*** wolverineav has joined #openstack-nova04:49
*** shaohe_feng has quit IRC04:51
*** shaohe_feng has joined #openstack-nova04:52
*** wolverineav has quit IRC04:54
*** gongysh has quit IRC04:55
*** flwang1 has quit IRC04:56
*** armaan has quit IRC04:56
*** armaan has joined #openstack-nova04:56
*** hongbin has joined #openstack-nova04:58
openstackgerritMerged openstack/nova master: Add queued_for_delete field to InstanceMapping object  https://review.openstack.org/56679504:59
*** hongbin has quit IRC05:00
*** tbachman has joined #openstack-nova05:00
*** shaohe_feng has quit IRC05:01
*** s1061123_ has joined #openstack-nova05:02
*** s1061123 has quit IRC05:03
*** wolverineav has joined #openstack-nova05:04
*** shaohe_feng has joined #openstack-nova05:05
*** wwriverrat has quit IRC05:05
*** s1061123_ has quit IRC05:09
*** s1061123 has joined #openstack-nova05:11
*** slaweq has joined #openstack-nova05:11
*** shaohe_feng has quit IRC05:12
*** tbachman has quit IRC05:12
*** wolverineav has quit IRC05:12
*** shaohe_feng has joined #openstack-nova05:13
*** udesale_ has joined #openstack-nova05:13
*** s1061123 has quit IRC05:14
*** lei-zh has joined #openstack-nova05:15
*** udesale has quit IRC05:15
*** slaweq has quit IRC05:15
*** s1061123 has joined #openstack-nova05:16
*** armaan has quit IRC05:17
*** armaan has joined #openstack-nova05:18
*** udesale_ has quit IRC05:19
*** udesale has joined #openstack-nova05:20
*** shaohe_feng has quit IRC05:22
*** ratailor has joined #openstack-nova05:22
*** shaohe_feng has joined #openstack-nova05:26
*** gongysh has joined #openstack-nova05:27
*** Guest85335 has quit IRC05:28
*** sridharg has joined #openstack-nova05:31
*** armaan has quit IRC05:32
*** shaohe_feng has quit IRC05:32
*** armaan has joined #openstack-nova05:32
*** shaohe_feng has joined #openstack-nova05:34
*** wolverineav has joined #openstack-nova05:38
*** Dinesh_Bhor has quit IRC05:38
*** Dinesh_Bhor has joined #openstack-nova05:38
*** wolverineav has quit IRC05:42
*** shaohe_feng has quit IRC05:42
*** shaohe_feng has joined #openstack-nova05:43
*** Eran_Kuris has joined #openstack-nova05:43
*** wolverineav has joined #openstack-nova05:52
*** shaohe_feng has quit IRC05:53
*** shaohe_feng has joined #openstack-nova05:54
*** wolverineav has quit IRC05:58
*** XueFeng has quit IRC06:00
*** wolverineav has joined #openstack-nova06:00
*** hoonetorg has quit IRC06:01
gmannnova api office hour time06:01
*** Dinesh_Bhor has quit IRC06:02
gmann#startmeeting nova api06:02
openstackMeeting started Wed Jul 25 06:02:24 2018 UTC and is due to finish in 60 minutes.  The chair is gmann. Information about MeetBot at http://wiki.debian.org/MeetBot.06:02
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.06:02
*** openstack changes topic to " (Meeting topic: nova api)"06:02
openstackThe meeting name has been set to 'nova_api'06:02
*** yamahata has quit IRC06:02
gmannPING List: gmann, alex_xu06:02
gmannwho all here today06:02
*** yamahata has joined #openstack-nova06:02
*** shaohe_feng has quit IRC06:03
*** 3NAAATYZV has joined #openstack-nova06:03
*** shaohe_feng has joined #openstack-nova06:04
*** armaan has quit IRC06:04
*** annp has joined #openstack-nova06:05
*** armaan has joined #openstack-nova06:05
*** s1061123 has quit IRC06:07
*** luzC has quit IRC06:07
*** luzC has joined #openstack-nova06:07
Kevin_Zhengo/06:08
gmannKevin_Zheng: hi06:08
Kevin_Zheng:)06:08
*** wolverineav has quit IRC06:08
gmannseems like 2 of us. let's wait couple of min06:08
alex_xuo/06:08
*** s1061123 has joined #openstack-nova06:08
gmannalex_xu: hi06:09
*** ccamacho has joined #openstack-nova06:09
alex_xugmann: good afternoon06:09
gmanngood afternoon06:09
gmannlet's start06:10
gmann#topic Priorities06:10
*** openstack changes topic to "Priorities (Meeting topic: nova api)"06:10
gmann#link https://etherpad.openstack.org/p/rocky-nova-priorities-tracking06:11
gmannL5706:11
openstackgerritRajesh Tailor proposed openstack/nova master: Fix host validity check for live-migration  https://review.openstack.org/40100906:11
*** slaweq has joined #openstack-nova06:11
gmann1. Servers Ips non-unique network names06:11
*** 3NAAATYZV has quit IRC06:11
gmannthis one is no progress. i did not get time to start this due to extensions merge work06:11
gmannwhich mean this would not go in Rocky. and we need to carry this to Stein06:12
gmann2.Abort live migration in queued state:06:13
gmannthis is done, thanks Kevin_Zheng06:13
*** shaohe_feng has quit IRC06:13
gmann3. Complex anti-affinity policies:06:13
gmannthis is also done, thanks yikun06:13
gmann4. Volume multiattach enhancements:06:14
gmannthis is on same state. and most probably will be stein one06:14
*** shaohe_feng has joined #openstack-nova06:15
gmann5. API Extensions merge work06:15
*** tetsuro has quit IRC06:15
gmannthis is partially done06:15
*** Luzi has joined #openstack-nova06:15
*** slaweq has quit IRC06:16
gmannpart-1 schema merge - Completed06:16
gmannpart-2 server_create merge - last patch on gate06:16
alex_xugmann: so we just done the server_create merge in Rocky, right?06:16
gmannalex_xu: yes, last patch is on gate -06:17
gmann#link https://review.openstack.org/#/c/583882/206:17
gmanntrying to get this in06:17
*** hoonetorg has joined #openstack-nova06:17
gmannalex_xu: part-3 merging the view builder is left to merge. I have many of them up for review06:17
gmann#link https://review.openstack.org/#/q/topic:bp/api-extensions-merge-rocky+status:open06:18
gmannwhich will be in Stein i think.06:18
gmannalex_xu: ?06:18
alex_xugmann: yea, just as mriedem said06:18
gmannyeah, it is too late to merge them and gate also not so good since last week06:19
gmannnone of them are reviewed so i do not think they can make it06:19
gmannalex_xu: today is FF or tomorrow ?06:19
alex_xutomorrow, our evening06:20
*** tetsuro has joined #openstack-nova06:20
gmannok06:20
*** tetsuro has quit IRC06:20
*** tetsuro has joined #openstack-nova06:20
*** abhishekk has joined #openstack-nova06:20
gmanni have left for 3 patch to push to complete it but at least 6-7 total are left for review06:20
vishakhagmann, Hi, i've been working on the bug https://bugs.launchpad.net/nova/+bug/1644457 but i found out that key_pair is a special case in which in_use remains always 0 as seen here https://github.com/openstack/nova/blob/master/nova/quota.py#L18906:21
openstackLaunchpad bug 1644457 in OpenStack Compute (nova) "keypair quota error" [Medium,Confirmed] - Assigned to Vishakha Agarwal (vishakha.agarwal)06:21
gmann7 up for review + 5 remaining to push06:21
*** armaan has quit IRC06:22
gmannvishakha: ok, let's discuss that during bug topic06:22
*** armaan has joined #openstack-nova06:22
gmannalex_xu: so we make final to postponed view builder to stein?06:22
*** XueFeng has joined #openstack-nova06:22
alex_xugmann: yea, I think so, there are a lot of view builder, right?06:23
alex_xu#link https://review.openstack.org/#/q/topic:bp/handling-down-cell+(status:open+OR+status:merged)06:23
alex_xu^this one is looking for your view builder change06:23
*** shaohe_feng has quit IRC06:23
gmannyeah, that makes this series easy06:23
vishakhagmann, ok06:23
gmannalex_xu:  total 12 patches to get in (7 up for review  + 5 need to push)06:24
*** psachin`` has quit IRC06:24
alex_xugmann: doesn't sound we can make it in one day06:24
*** shaohe_feng has joined #openstack-nova06:24
gmannalex_xu: yes, not possible.06:25
gmannalex_xu: ok i will postponed them to stein.  and will push them soon so that we can merge them early in stein06:25
*** lpetrut has joined #openstack-nova06:26
gmannand on same topic mriedem had query regarding moving the buildling of create_kwargs into helper method than in create() itself which makes it huge06:27
gmannand deprecating the extensions policy which we already done in queens and i will remove them in stein06:27
gmannmoving the building of create_kwargs into helper can be discussed in stein as this is late to change them now in Rocky06:29
gmannalex_xu: i am not sure we should open another specless BP for stein or just merge them as it is. anyways Rocky BP needs to be closed anyways.06:30
gmannmay be melwitt mriedem can suggest ^^06:30
alex_xugmann: yea, that should be a question for them06:32
gmannok06:32
gmannlet's move next06:32
gmann6. Handling a down cell06:32
gmann#link https://review.openstack.org/#/q/topic:bp/handling-down-cell+(status:open+OR+status:merged)06:33
gmannactually i am not following this one. alex_xu you know if that is target for Rocky i mean can it make it by tomorrow ?06:33
*** pcaruana has joined #openstack-nova06:33
*** shaohe_feng has quit IRC06:34
alex_xugmann: sounds like target to Rocky, at least we have spec for rocky http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/handling-down-cell.html06:34
gmannyeah06:34
alex_xugmann: but looks like it starts very late06:34
gmanni saw mriedem comment of doing service list change also in same microversion of server list - #link https://review.openstack.org/#/c/584829/06:35
gmannyea it is started late like me :) i also did start the extensions work too late due to QA things.06:35
gmannanyways let's see how far it will go tomorrow06:36
*** wolverineav has joined #openstack-nova06:36
gmannthat is all Rokcy items06:36
*** shaohe_feng has joined #openstack-nova06:36
*** sm806 has quit IRC06:36
gmannnext may be after FF, we can keep eyes on API bugs and Stein specs for review06:37
gmann#link https://review.openstack.org/#/q/project:openstack/nova-specs+status:open+message:%22apiimpact%2206:37
gmannthat's all on priority, anything else to discuss otherwise we move to bug discussion06:37
gmannseems no. let's move then06:39
gmann#topic Bug Triage/Discussion06:39
*** openstack changes topic to "Bug Triage/Discussion (Meeting topic: nova api)"06:39
gmann#link https://etherpad.openstack.org/p/nova-api-weekly-bug-report06:39
gmanncurren total open bugs are 68.06:40
Kevin_Zhengomg06:40
gmannhonestly saying i was getting less time for bugs due to extensions work but after FF i will give more time on this to burn it down to less06:41
*** wolverineav has quit IRC06:41
gmann34 out of them are in-progress06:42
gmannvishakha: you wanted to discuss some bug?06:42
*** wolverineav has joined #openstack-nova06:42
*** shaohe_feng has quit IRC06:44
vishakhagmann, yes06:44
*** shaohe_feng has joined #openstack-nova06:44
alex_xuvishakha: can you reproduce it in master? the bug is reported in newton, and we change quota a lot recently, like we remove the commit, rollback stuff for cellv206:44
vishakhagmann, Hi, i've been working on the bug https://bugs.launchpad.net/nova/+bug/1644457 but i found out that key_pair is a special case in which in_use remains always 0 as seen here https://github.com/openstack/nova/blob/master/nova/quota.py#L18906:44
openstackLaunchpad bug 1644457 in OpenStack Compute (nova) "keypair quota error" [Medium,Confirmed] - Assigned to Vishakha Agarwal (vishakha.agarwal)06:44
gmannalex_xu: it seems key_pairs is in special case for in_use always 006:45
gmann#link https://github.com/openstack/nova/blob/master/nova/quota.py#L18906:45
vishakhagmann, I have a doubt  when adding a key to instance. It should come in 'in_use' of quota_usage?06:45
*** wolverineav has quit IRC06:46
gmannvishakha: is it reproducible on master as alex_xu asked06:48
vishakhagmann, yes it is06:48
vishakhaalex_xu, the 'in_use' for keypair is coming 0 always06:49
alex_xuinteresting...06:51
alex_xuI thought it should call this https://github.com/openstack/nova/blob/master/nova/quota.py#L124406:52
*** shaohe_feng has quit IRC06:54
*** blkart has quit IRC06:55
alex_xuvishakha: the `nova quota-show --detial` should show 0, but `nova quota-show --detail --user {user_id}` indeed should show the usage as my understand06:55
alex_xuvishakha: I'm not sure whether https://github.com/openstack/nova/blob/master/nova/quota.py#L189 missing a check for the user_id isn't None06:56
gmannyeah, db count id per user - https://github.com/openstack/nova/blob/e019be3724d949b1239c2cc3fbc00f1f69a3477c/nova/db/sqlalchemy/api.py#L304306:57
gmanns/id/it06:57
*** shaohe_feng has joined #openstack-nova06:58
*** rcernin has quit IRC06:59
*** sahid has joined #openstack-nova07:01
vishakhaalex_xu, gmann : I have tried with --user parameter also, still showing 0 in_use07:02
gmannalex_xu: i found some context of doing it intentionally or say as per old behaviour07:03
gmannalex_xu: #link https://review.openstack.org/#/c/446239/3/nova/tests/unit/test_quota.py@103107:03
*** sridharg has quit IRC07:04
*** tssurya has joined #openstack-nova07:04
*** shaohe_feng has quit IRC07:04
*** shaohe_feng has joined #openstack-nova07:05
alex_xugmann: interesting07:05
gmannmay be we can fix that per user but sot sure we can fix it easily as melwitt metnioned on that reivew07:07
alex_xugmann: it sounds make sense to show keypair for specific user, but for the server_group_member we really have no way to express that07:07
gmannyeah that per server group07:08
*** rmart04 has joined #openstack-nova07:08
alex_xugmann: then do we need microversion :)07:09
gmannhumm07:09
*** ispp has joined #openstack-nova07:09
*** vladikr has quit IRC07:09
*** armaan has quit IRC07:09
*** armaan has joined #openstack-nova07:10
gmannit change the behaviour but not sure we need microversion as it would not cause any backward incompatibility in iterface usage07:10
alex_xugmann: but there is no way for the user to know whether the usage is valid in the deployment07:11
*** slaweq has joined #openstack-nova07:11
sean-k-mooneymriedem: melwitt regarding the noop plugin im just looking into it now. it looks related to how we dynamicaly load plugins here https://github.com/openstack/os-vif/blob/master/os_vif/__init__.py#L41-L4907:12
sean-k-mooneymriedem: melwitt ill take a look at it now07:12
*** vladikr has joined #openstack-nova07:12
gmannyeah, that's true.07:12
gmannmicroversion bump can be done but then it cannot be backported if we want to.07:13
alex_xugmann: we have user quota since long time ago, not sure whether is it always 007:14
alex_xugmann: this bug is newton07:14
*** armaan has quit IRC07:14
*** shaohe_feng has quit IRC07:15
alex_xugmann: or just send this question to maillist to get wider agreement07:15
alex_xuI'm really not good at answering the microversion question07:15
*** slaweq has quit IRC07:16
gmannalex_xu: you mean to ask for microversion bump or to fix the bug for showing the key_pair usage per suer ?07:16
*** tesseract has joined #openstack-nova07:16
*** shaohe_feng has joined #openstack-nova07:16
*** slaweq has joined #openstack-nova07:16
alex_xugmann: both I guess since we already ask question, at least it make sense to show user qutoa for keypair for me07:17
gmannalex_xu: ok.07:17
gmanni can send the ML, tough i do not have full context of quota calculation background07:18
*** XueFeng has quit IRC07:18
gmanns/tough/though07:18
alex_xuI can help that07:18
gmannalex_xu: thanks,07:20
gmannalex_xu: you mean you can send mail or reply on the query i sent?07:20
alex_xugmann: ethier works for me :)07:21
*** ispp has quit IRC07:21
alex_xus/ethier/either/07:22
gmannalex_xu: cool, I will bring the query on ML and then you can respond.  thanks07:22
alex_xugmann: got it, thanks07:22
gmannanything else on bug or we move next07:22
gmann#topic Open Discussion07:22
*** openstack changes topic to "Open Discussion (Meeting topic: nova api)"07:22
vishakhagmann, should I look for another?07:23
gmannvishakha: sorry did not conclude that. we are bringing your question on ML and their you can see the discussion or respond07:23
vishakhagmann, alex_xu : ok thanks07:23
gmannvishakha: yeah, if you can help on other bug also it will be great. if you are looking for more then you can choose from API one07:23
*** rmart04_ has joined #openstack-nova07:24
gmannvishakha: #link07:24
gmannhttps://bugs.launchpad.net/nova/+bugs?field.searchtext=&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&field.assignee=&field.bug_reporter=&field.bug_commenter=&field.subscriber=&field.structural_subscriber=&field.tag=api%20api-ref&field.tags_com07:24
gmannbinator=ANY&field.has_cve.used=&field.omit_dupes.used=&field.omit_dupes=on&field.affects_me.used=&field.has_patch.used=&field.has_branches.used=&field.has_branches=on&field.has_no_branches.used=&field.has_no_branches=on&field.has_blueprints.used=&field.has_blueprints=on&field.has_no_blueprints.used=&field.has_no_blueprints=on&search=Search&orderby=-importance&start=007:24
gmannopps07:24
vishakhagmann, yes sure07:24
gmannanything else to discuss or we close the office hour07:24
gmannlet's close then.07:25
vishakhagmann, just wanted you to review https://review.openstack.org/#/c/580271/07:25
Kevin_Zhengme07:25
gmannKevin_Zheng: go ahead07:25
*** shaohe_feng has quit IRC07:25
Kevin_ZhengOur product team found out a strange API behaviour07:25
Kevin_Zhenghttps://developer.openstack.org/api-ref/compute/#get-availability-zone-information07:25
*** rmart04 has quit IRC07:25
*** rmart04_ is now known as rmart0407:25
gmannvishakha: sure, ll add in my list07:25
Kevin_Zhengthere is a hosts field07:25
Kevin_Zhengand it will always be "null"07:25
Kevin_Zhengit was just added here:07:26
Kevin_Zhenghttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/availability_zone.py#L4207:26
Kevin_Zhengso any particular reason why it is added?07:26
Kevin_ZhengOr should we just remove it07:26
*** wolverineav has joined #openstack-nova07:27
*** shaohe_feng has joined #openstack-nova07:27
gmannKevin_Zheng: may be for consistency for GET and GET detail API07:27
gmannKevin_Zheng: Detail give the host information07:28
vishakhagmann, Thanks :)07:28
*** dtantsur|afk is now known as dtantsur07:28
Kevin_Zhengbut do we need this kind of consistency?07:28
Kevin_Zhenglooks strange07:28
gmann#link https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/availability_zone.py#L9107:28
Kevin_Zhengwe do not have this kind of consistency in list server and list server details07:28
*** lei-zh has quit IRC07:29
Kevin_Zhengyeah, I know that, just think this is not necessary07:29
gmannohk it is not get particular AZ07:29
*** lei-zh has joined #openstack-nova07:29
gmannwe can remove but need microversion. what harm in keeping it ?07:29
Kevin_Zhengno harm, just found it strange07:30
Kevin_Zhengand the customer asks07:30
Kevin_Zhengso we have to tell them why it is like that all the time07:30
gmanni remember we kept it for v2.1 for compatibility07:30
*** XueFeng has joined #openstack-nova07:30
Kevin_ZhengSo might be good to remove it in S?07:31
Kevin_Zhengwith microversion07:31
gmannKevin_Zheng: ok. i can note down this on API improvement etherpad  (which i need to create yet)and then we can decide if we can fix this with other consistent changes07:32
*** wolverineav has quit IRC07:32
Kevin_Zhengyeah cool07:32
gmannmicroversion alone for this seems little overhead for me07:32
Kevin_Zhengyeah07:32
*** wolverineav has joined #openstack-nova07:32
gmannKevin_Zheng: thanks for finding and reporting this.07:33
Kevin_ZhengNP, just solving our problems07:33
gmannanything else to discuss07:33
gmannok let's close then07:34
gmannthanks everyone for joining07:34
gmann#endmeeting07:34
*** openstack changes topic to "Current runways: abort-live-migration-in-queued-status / add-zvm-driver-rocky / glance-image-traits -- This channel is for Nova development. For support of Nova deployments, please use #openstack."07:34
openstackgerritLucian Petrut proposed openstack/nova master: Hyper-V + OVS: plug vifs before starting VMs  https://review.openstack.org/58566107:34
openstackMeeting ended Wed Jul 25 07:34:39 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)07:34
openstackMinutes:        http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-07-25-06.02.html07:34
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-07-25-06.02.txt07:34
openstackLog:            http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-07-25-06.02.log.html07:34
Kevin_Zhenggmann a test related question07:34
gmannKevin_Zheng: yup07:34
Kevin_Zhenghttps://review.openstack.org/#/c/583927/ I'm working on this07:35
*** lpetrut_ has joined #openstack-nova07:35
*** shaohe_feng has quit IRC07:35
Kevin_Zhengand Matt asked me to use a real mc backend instead of mock07:35
Kevin_ZhengSeems like it need to have some set_up besides just override the configs07:36
gmannchecking07:36
Kevin_ZhengI have no clue how do it, do you have this kind of experience/07:36
Kevin_Zheng?07:36
Kevin_ZhengThanks07:36
*** wolverineav has quit IRC07:37
*** lpetrut has quit IRC07:38
*** shaohe_feng has joined #openstack-nova07:38
gmanni have not done yet but trying to look07:39
gmannKevin_Zheng: it did not work with dogpile.cache.memory also ?07:41
gibimriedem: No worries, I didn't planned to have a meeting this week (either) http://lists.openstack.org/pipermail/openstack-dev/2018-July/132410.html07:41
Kevin_Zhengyeah, seems the backend is not working, the client can be correctly initialized, but no data was saved07:42
*** ragiman has joined #openstack-nova07:42
Kevin_Zhengso cannot retrive any data07:42
*** cdent has joined #openstack-nova07:42
*** AlexeyAbashkin has joined #openstack-nova07:42
*** avolkov has joined #openstack-nova07:43
*** shaohe_feng has quit IRC07:45
*** shaohe_feng has joined #openstack-nova07:46
*** ispp has joined #openstack-nova07:47
openstackgerritLucian Petrut proposed openstack/nova master: Hyper-V + OVS: plug vifs before starting VMs  https://review.openstack.org/58566107:50
gmannKevin_Zheng: i was thinking expiration_time is missing but is defaulted here - https://github.com/openstack/nova/blob/ddc807f85aad4e3d2ed6434809325320c1c21281/nova/cache_utils.py#L6907:53
Kevin_Zhenghmm, yeah07:53
Kevin_Zhengso you don't think we should do any setup action?07:54
gmannKevin_Zheng: means?07:55
Kevin_ZhengI mean, do we need to setup the backend?07:55
gmannKevin_Zheng: i do not think so07:55
*** shaohe_feng has quit IRC07:56
Kevin_Zhenghmm ok07:56
Kevin_ZhengThen I should check more on the params07:56
gmannlet me dig into that. need to go for firstcontact SIG now.07:56
Kevin_ZhengNP, thanks anyway07:56
gmannll check later and let you know07:56
Kevin_Zhengthanks07:56
*** shaohe_feng has joined #openstack-nova07:57
*** vivsoni_ has joined #openstack-nova08:02
*** vivsoni has quit IRC08:02
*** alexchadin has joined #openstack-nova08:04
*** armaan has joined #openstack-nova08:05
*** shaohe_feng has quit IRC08:06
*** shaohe_feng has joined #openstack-nova08:07
openstackgerritTetsuro Nakamura proposed openstack/nova master: WIP: Enable nested allocation candidates in scheduler  https://review.openstack.org/58567208:09
tetsuro^gibi, jaypipes, efried and everyone: I'd like to help you on consuming nrp-aloc-cands work in nova side, but I think I need brief feedback if this is a right way and where I should go.08:15
*** shaohe_feng has quit IRC08:16
tetsuroThis is at least working on getting candidates with child rp + custom resource class inventory and have allocations on them with compute host resources.08:17
tetsuro...with a new instance08:17
*** shaohe_feng has joined #openstack-nova08:18
*** rmart04 has quit IRC08:19
*** lucas-afk is now known as lucasagomes08:22
*** shaohe_feng has quit IRC08:26
*** shaohe_feng has joined #openstack-nova08:27
cdenttetsuro: I looked at that, looks like a good start and the right thing for there. The complexity is going to happen if/when an instance with nested wants to do a migration. There's quite a bit of a TODO in the report client about that kind of thing.08:28
gmanntetsuro: we were discussing about your BP in api office hour - https://review.openstack.org/#/q/topic:bp/handling-down-cell+(status:open+OR+status:merged)08:29
*** rcernin has joined #openstack-nova08:29
gmanntetsuro: what's the plan for this? is it still target for Rocky or stein. i saw the comment of doing service list also along with server list08:30
gibitetsuro: left some feedback in that patch. I think simply reading the consumer generation from placement during the claim_resources is defeate the purpose of having consumer generations08:30
gibitetsuro: I'm trying to add support for consumer generations here https://review.openstack.org/#/c/583667/08:30
cdenttetsuro, gibi: for the case where we have a new instance the consumer is new, so generation is meaningless?08:31
gibicdent: unfortunately that is not the only case when claim_resources are called08:31
cdentyeah, I know, I'm trying to work out if we can streamline the easy path08:32
cdentbecause it is the common path too08:32
cdentin the uncommon cases there will be existing allocations, yes?08:32
cdentthus what the code is doing is at least close, if not fully correct08:32
gibicdent: plus when we assume that it is a new consumer we can still need to prepare that we get consumer generation conflict and handle that (most probably fail the build)08:33
cdentclearly there needs to be some conflict detection, but bar that the logic is mostly right unless there's a detail I'm not aware of (which is very likely)08:33
cdentyes, a generation conflict on a new build would mean that UUIDs are broken :)08:34
gibicdent: or that our assumption in the claim_resources about the fact that it is a new build is invalid08:34
gibicdent: even if we are coming from the scheduer select_destination it is possible that the consumer exists as evacuate does not use migration.uuid to hold the allocation of the source host08:36
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Do not reraise DiskNotFound exceptions during resize  https://review.openstack.org/57141008:36
*** shaohe_feng has quit IRC08:37
gibicdent: I agree that assuming consumer_generation = None in claim_resource a good first step08:37
*** shaohe_feng has joined #openstack-nova08:37
*** wolverineav has joined #openstack-nova08:38
gibicdent: I just fustrated about the hairy cases that I have to takle in my patch and I don't think we can merge support for 1.29 before solving 1.28 for the edge cases too08:38
lyarwoodmdbooth: ^ would you mind taking a look at that again?08:38
cdentI'm not disputing that we need to merge (and understand) your 1.28 code first08:38
cdentjust, as I said, trying to make sure that we don't overcomplicate things when we claim, if possible08:39
mdboothlyarwood: yup08:39
cdentif new: gen is none, if gen conflict bail, something went badly wrong08:39
gibicdent: when you say 'if new' do you mean checking if there is no other allocation in placement for the consumer?08:40
cdentif existing allocations for this consumer uuid, do something else08:41
*** sridharg has joined #openstack-nova08:41
cdentthat would be one way, but I assume the caller of claim also knows?08:41
cdentthe "something else" looks to me to be very close to what is already being done in the code: merge the allocations, set the generation to what the server told us08:42
gibicdent: what if the caller thinks that it is not a new consumer but the claim_resources checks in placement and sees it is a new consumer and silently uses consumer_generation None instead of raise?08:42
gibicdent: I think in this case the caller needs to provider his view of the consumer generation and not let claim_resource decide08:43
cdentthen we should fix the caller because it sounds like the caller is broken? I'm not sure why we should overcomplicate the report client to deal with the fact that other code is flakey. What situation would cause what you're describing?08:43
*** wolverineav has quit IRC08:43
gibicdent: sure it needs fix on the caller side but to know that the caller is broken we need to see the conflict and not simply use the consumer gen that will succeed in placement by asking it from placement08:45
cdentI don't mean a fix at runtime, I mean a fix in the code08:45
cdentThus my question of  "what situation.."08:46
*** armaan has quit IRC08:46
gibicdent: I don't know exactly the case. I guess some parallel consumer update can happen. This is why we introduced consumer generation in the first place, isn't it?08:47
cdentIf we take this back to very basics there are two main situations: the consumer has existing allocations and this consumer does not have existing allocations. Are there others?08:47
*** armaan has joined #openstack-nova08:47
*** shaohe_feng has quit IRC08:47
gibithere is the case when caller thing consumer gen is 1 but in the meantime somebody else modified the consumer08:47
gibis/thing/thinks/08:47
cdentfor "gen is 1 but somebody else modified" that is a specifc case of "the consumer has existing allocations"08:48
*** shaohe_feng has joined #openstack-nova08:48
*** openstackgerrit has quit IRC08:48
gibicdent: OK, then that is the two basic case08:48
cdentFrom the point of the scheduler's management of allocations, consumer generations are not very important (we have to manage conflict detection, but we still just want to claim) because the act of claiming for an instance is a single task. We want to claim if at all possible. Nobody else is trying to find a destination for this instance.08:49
*** wolverineav has joined #openstack-nova08:50
gibiof course we can say that consumers handled by nova is owned by nova and no parallel update is done from nova on those and then we don't need to take consumers generations too seriously08:50
cdentI'm saying that's true for in the scheduler. It's not true in the compute node, or in neutron agents, or whatever08:50
cdentAnd we should keep it true in the scheudler if at all possible08:51
*** armaan has quit IRC08:51
gibibut scheduler coexists with all the others so I don't know how to ensure that the consumer the scheduler uses are not modified by other sources08:52
gibiif scheduler would only ever create a new consumer during claim then it would be easier08:52
cdentindeed08:52
gibidue to evacuate it is not the case today08:53
cdentbut in the (presumably rare) cases where it doesn't the only real option we have is to get the existing allocations and do some kind of merge or choose to clobber08:53
gibithere is an item in the PTG etherpad to 'fix' evacuate08:53
cdent_move_operation_alloc_request is the code that is supposed to handle that sort of thing, but may not be mature enough of for nested and shared08:54
*** wolverineav has quit IRC08:55
cdentI think (or perhaps just hope) that we have a chance here to keep the happy path relatively smooth. I hope for that because we keep talking about how we want the claim stage to be as fast and unencumbered as possible.08:55
gibicdent: I agree that in case of non-forced evac when the scheduler claims on the target host we cannot do anything else just read the generation from placement. I will try to be really explicit in my patch about the different cases.08:55
cdenttetsuro: you have anything to add to all that ^08:56
*** shaohe_feng has quit IRC08:57
gibicdent: I share your hope. My bad feeling is about our assumption that I can identify the happy path unambigously08:57
*** openstackgerrit has joined #openstack-nova08:58
openstackgerritRadoslav Gerganov proposed openstack/nova master: doc: add missing permission for the vCenter service account  https://review.openstack.org/58568308:58
cdentthat we can't should be considered a bug ;)08:58
*** diga has joined #openstack-nova08:58
*** shaohe_feng has joined #openstack-nova08:59
gibicdent: I guess I need to lower my expectations about my ability to cover every cases at once in my patch and let a bug born if it needs to be born09:00
cdentyeah, I think that's going to be the case for a lot of this stuff because it's so hard to see clearly how things work09:00
cdentAnd bugs are _good_. They give people a clear way to contribute.09:01
*** josecastroleon has quit IRC09:01
*** josecastroleon1 has joined #openstack-nova09:01
*** josecastroleon1 is now known as josecastroleon09:01
gibicdent: I thikn _these_ possible bugs will give a clear message for new contributors not to touch nova ;)09:02
cdentI don't know, I think we misunderstand the mechanics of why people choose or choose not to contribute09:02
cdentSo often with nova if you want to contribute you have to spend 4 years understanding things09:02
cdentthere are few easy entries09:03
cdentplenty of people are using nova because they have to and would like to be able to make it better09:03
cdentbut are put off09:03
gibicdent: you are right, I should not generalize to all new contributors as I don't know their motives.09:04
gibicdent: what I wanted to say that I think these bugs will be scary even for me after 4 years of nova09:04
cdent:)09:05
cdentIt's easier to fix them after they happen then it is easy to guess when they might happen?09:05
gibicdent: yeah I agree about cost of guessing is bigger. But I also don't know the seriosuness of the effect of these unknown bugs on a live deployment09:07
*** shaohe_feng has quit IRC09:07
gibicdent: anyhow I think I hear you and understand you to move forward with the happy path09:09
gibicdent: and I think that is reasonable09:09
*** shaohe_feng has joined #openstack-nova09:10
*** armaan has joined #openstack-nova09:11
*** ispp has quit IRC09:11
*** rmart04 has joined #openstack-nova09:14
*** chason has quit IRC09:16
*** chason has joined #openstack-nova09:17
*** shaohe_feng has quit IRC09:18
*** ispp has joined #openstack-nova09:19
*** shaohe_feng has joined #openstack-nova09:19
*** armaan has quit IRC09:26
*** armaan has joined #openstack-nova09:26
*** shaohe_feng has quit IRC09:28
*** mgoddard has joined #openstack-nova09:28
*** armaan has quit IRC09:30
*** shaohe_feng has joined #openstack-nova09:31
*** lifeless has quit IRC09:37
*** shaohe_feng has quit IRC09:38
*** shaohe_feng has joined #openstack-nova09:39
openstackgerritsean mooney proposed openstack/os-vif master: add fuctional test for os-vif init  https://review.openstack.org/58569309:40
openstackgerritRajesh Tailor proposed openstack/nova stable/queens: Make host_aggregate_map dictionary case-insensitive  https://review.openstack.org/58533409:41
openstackgerritRajesh Tailor proposed openstack/nova stable/pike: Make host_aggregate_map dictionary case-insensitive  https://review.openstack.org/58533509:43
sean-k-mooneymriedem: melwitt  i have added a fuctionl test https://review.openstack.org/#/c/585693/ to try and reproduce the error in https://bit.ly/2v0ueZp but at least locally it looks like it should work as is.09:45
openstackgerritRajesh Tailor proposed openstack/nova master: Fix case-sensitivity for metadata keys  https://review.openstack.org/50488509:46
*** wolverineav has joined #openstack-nova09:46
*** zhangbailin_ has joined #openstack-nova09:47
*** flwang1 has joined #openstack-nova09:48
*** shaohe_feng has quit IRC09:48
*** blkart has joined #openstack-nova09:48
*** shaohe_feng has joined #openstack-nova09:49
*** Tahvok has quit IRC09:50
*** BrinZhang has quit IRC09:50
*** wolverineav has quit IRC09:51
*** Tahvok has joined #openstack-nova09:51
*** wolverineav has joined #openstack-nova09:53
*** kiseok7 has joined #openstack-nova09:55
*** shaohe_feng has quit IRC09:59
*** wolverineav has quit IRC09:59
*** alexchadin has quit IRC09:59
*** GonZo2000 has joined #openstack-nova09:59
*** GonZo2000 has quit IRC09:59
*** GonZo2000 has joined #openstack-nova09:59
*** lei-zh has quit IRC09:59
*** shaohe_feng has joined #openstack-nova10:00
*** ispp has quit IRC10:01
*** vipul has quit IRC10:01
*** rmart04 has quit IRC10:03
*** vipul has joined #openstack-nova10:05
*** shyamb has joined #openstack-nova10:05
*** alexchadin has joined #openstack-nova10:08
*** shaohe_feng has quit IRC10:09
*** shaohe_feng has joined #openstack-nova10:10
*** josecastroleon has quit IRC10:10
*** josecastroleon has joined #openstack-nova10:10
*** tssurya has quit IRC10:11
*** shyamb has left #openstack-nova10:15
*** chason has quit IRC10:15
*** chason has joined #openstack-nova10:17
*** josecastroleon has quit IRC10:17
*** chason[m] has joined #openstack-nova10:17
*** shaohe_feng has quit IRC10:19
*** shaohe_feng has joined #openstack-nova10:20
*** vladikr has quit IRC10:21
*** wolverineav has joined #openstack-nova10:22
*** jamesden_ has joined #openstack-nova10:22
*** kukacz_ has quit IRC10:23
*** kukacz_ has joined #openstack-nova10:23
*** lifeless has joined #openstack-nova10:23
*** vladikr has joined #openstack-nova10:25
*** wolverineav has quit IRC10:26
*** wolverineav has joined #openstack-nova10:28
*** shaohe_feng has quit IRC10:29
*** shaohe_feng has joined #openstack-nova10:30
openstackgerritLenny Verkhovsky proposed openstack/nova master: WIP workaround for RHEL7.5 qemu 2.0  https://review.openstack.org/57728010:30
*** wolverineav has quit IRC10:32
*** wolverineav has joined #openstack-nova10:33
*** alexchad_ has joined #openstack-nova10:35
*** alexchad_ has quit IRC10:36
*** alexchadin has quit IRC10:36
openstackgerritBalazs Gibizer proposed openstack/nova master: Functional test for booting with nested resources  https://review.openstack.org/52772810:37
*** wolverineav has quit IRC10:37
mdboothkashyap: My +1 to sahid's suggestions was before the subsequent discussion. I'll defer to that discussion.10:38
kashyapmdbooth: Hi10:38
*** wolverineav has joined #openstack-nova10:39
*** shaohe_feng has quit IRC10:40
kashyapmdbooth: So, you mean: you are OK with moving to guest.migrate() can be done as a separate patch?10:40
*** shaohe_feng has joined #openstack-nova10:40
mdboothkashyap: I think moving to guest.migrate() is better, but if you discussed that already and decided to put it in a later change I'm ok with that.10:40
kashyapmdbooth: Yeah, we discussed it, and will do it later10:41
kashyapAs I am dealing with too much churn in this change10:41
mdboothkashyap: That is, I don't mind what colour you paint the bike shed :)10:41
*** gongysh has quit IRC10:41
kashyapI'd like to get it done before I head out for 2 weeks starting 01-Aug10:41
kashyapmdbooth: Hehe, nod10:41
kashyapThanks for looking, BTW!10:41
kashyapmdbooth: About the "parallels" question: it seems alright to me, but I'll go over carefully again10:42
mdboothkashyap: Ack. Specifically, is it ok to call migrateToURI3() without that parameter?10:43
mdboothI don't know the answer, btw, just worth checking.10:43
kashyapmdbooth: Without 'destination_xml', you mean?10:43
kashyapYeah, I'll see10:43
*** wolverineav has quit IRC10:43
*** blkart has quit IRC10:45
kashyapmdbooth: Right now debugging the test failure from hell: nova.tests.unit.virt.test_virt_drivers.LibvirtConnTestCase.test_live_migration10:45
*** armaan has joined #openstack-nova10:45
kashyapOnce I'm done w/ it, will look10:45
*** wolverineav has joined #openstack-nova10:46
*** blkart has joined #openstack-nova10:48
*** liuyulong_ has joined #openstack-nova10:48
*** edmondsw has joined #openstack-nova10:49
* stephenfin wonders how much of a "stub" service does one need to implement before it's no longer a stub10:49
*** ispp has joined #openstack-nova10:49
*** shaohe_feng has quit IRC10:50
kashyapstephenfin: LOL10:50
kashyapI'm dealing with a bloody obtuse stubbing failure for 2 hours!10:50
*** wolverineav has quit IRC10:50
stephenfinkashyap: Try 3 days :(10:50
kashyapThe here is incredibly dense; sheesh10:50
kashyapstephenfin: I lied to you10:51
kashyap2 hours only today10:51
kashyapI spent yesterday & day before too10:51
kashyapAfter all this debugging, realized the fix is "simple" :-(10:51
* kashyap goes to try his "simple" fix to the stubs10:51
mdboothstephenfin: stub -> simulator. simulators are also really useful, just not as simple.10:51
*** wolverineav has joined #openstack-nova10:52
*** liuyulong has quit IRC10:52
*** shaohe_feng has joined #openstack-nova10:52
*** armaan has quit IRC10:55
*** armaan has joined #openstack-nova10:56
*** armaan has quit IRC10:56
stephenfinmdbooth: I think that's what I'm writing. God damn neutron10:57
*** physpi| has joined #openstack-nova10:57
*** wolverin_ has joined #openstack-nova10:59
*** wolverineav has quit IRC11:00
*** shaohe_feng has quit IRC11:00
kashyapmdbooth: Got a minute?  Does this stub look OK to you:11:01
kashyap135         self.stub_out('nova.virt.libvirt.guest.Guest.migrate',11:01
kashyap136                       lambda self, destination, migrate_uri=None,11:01
kashyap137                       migrate_disks=None, destination_xml=None, flags=0,11:01
*** shaohe_feng has joined #openstack-nova11:01
kashyap138                       bandwidth: None)11:01
kashyap(That's from nova/tests/unit/virt/test_virt_drivers.py)11:01
*** physpi| has quit IRC11:01
*** wolverin_ has quit IRC11:01
*** wolverineav has joined #openstack-nova11:01
mdboothkashyap: No, because bandwidth doesn't have a default, and comes after args with defaults.11:02
kashyapmdbooth: Ah11:02
mdboothIs there any other reason it might not be ok?11:03
*** wolverin_ has joined #openstack-nova11:03
*** wolverineav has quit IRC11:03
mdboothkashyap: Also, you could probably just mock it.11:03
kashyapmdbooth: What do I give 'bandwidth' then?11:03
kashyapHmm11:03
mdboothkashyap: Doesn't matter, because you're not going to use it anyway.11:04
*** diga has quit IRC11:04
kashyapmdbooth: Ah, this works!11:04
kashyapbandwith=0: None11:04
mdboothself.useFixture(fixtures.MockPatch('nova.virt.libvirt.guest.Guest', 'migrate'))11:04
kashyapIn summary:11:04
kashyap        self.stub_out('nova.virt.libvirt.guest.Guest.migrate',11:04
kashyap                      lambda self, destination, migrate_uri=None,11:04
kashyap                      migrate_disks=None, destination_xml=None, flags=0,11:04
kashyap                      bandwidth=0: None)11:04
kashyapmdbooth: How about the above?11:04
mdboothfoo=^^^11:04
mdboothfoo.return_value=None11:04
mdboothkashyap: Looks syntactically correct, at least.11:05
kashyapYeah, it is!11:05
openstackgerritStephen Finucane proposed openstack/nova master: Assorted cleanups from numa-aware-vswitches series  https://review.openstack.org/58265111:05
kashyapAnd the test from hell passes!~11:05
openstackgerritStephen Finucane proposed openstack/nova master: WIP: Add functional tests for rebuild with NUMA networks  https://review.openstack.org/58538511:05
mdbooth\o/11:06
stephenfinmdbooth: If you have time, fancy taking a look at ^ to see if I'm missing anything really obvious?11:06
stephenfinI'm seeing "AttributeError: 'module' object has no attribute 'vif'" but I've no idea why11:06
sean-k-mooneystephenfin: i was just going to ask you about the functional tests11:06
*** phuongnh has quit IRC11:07
sean-k-mooneydo you want me to pull them down and step through them more or did you get them to work?11:07
stephenfinThought it was a namespace conflict (mocking "objects" or something) but I renamed the import to no effect. Can't find any global mocks or anything11:07
*** armaan has joined #openstack-nova11:07
stephenfinsean-k-mooney: That'd be great11:07
stephenfinI've got it to the point where it's attempting to plug11:07
sean-k-mooneystephenfin: cool will do11:07
stephenfinBut the plug is failing with the above11:07
stephenfinsean-k-mooney: Awesome. Thank you :)11:08
*** wolverin_ has quit IRC11:08
*** alexchadin has joined #openstack-nova11:09
*** shaohe_feng has quit IRC11:10
*** tssurya has joined #openstack-nova11:12
*** shaohe_feng has joined #openstack-nova11:12
*** abhishekk has quit IRC11:12
*** josecastroleon has joined #openstack-nova11:13
*** ratailor has quit IRC11:14
*** alexchadin has quit IRC11:15
*** chyka has joined #openstack-nova11:18
*** shaohe_feng has quit IRC11:21
*** rcernin has quit IRC11:21
*** shaohe_feng has joined #openstack-nova11:22
*** ragiman has quit IRC11:23
*** chyka has quit IRC11:23
*** tiendc has quit IRC11:24
*** liuyulong__ has joined #openstack-nova11:26
*** liuyulong_ has quit IRC11:26
*** armaan has quit IRC11:27
*** armaan has joined #openstack-nova11:27
*** armaan has quit IRC11:29
*** armaan has joined #openstack-nova11:30
*** shaohe_feng has quit IRC11:31
*** artom has joined #openstack-nova11:32
*** shaohe_feng has joined #openstack-nova11:32
*** alexchadin has joined #openstack-nova11:37
*** ccamacho has quit IRC11:38
*** shaohe_feng has quit IRC11:41
*** shaohe_feng has joined #openstack-nova11:42
*** ccamacho has joined #openstack-nova11:44
*** shaohe_feng has quit IRC11:51
*** shaohe_feng has joined #openstack-nova11:54
*** ispp has quit IRC11:54
*** ispp has joined #openstack-nova11:57
*** medberry has joined #openstack-nova12:01
*** shaohe_feng has quit IRC12:02
*** shaohe_feng has joined #openstack-nova12:03
*** armaan has quit IRC12:03
*** armaan has joined #openstack-nova12:04
*** armaan has quit IRC12:06
*** armaan has joined #openstack-nova12:07
*** wolverineav has joined #openstack-nova12:08
openstackgerritNeha Alhat proposed openstack/python-novaclient master: Enable split logging for cinder-novaclient interaction  https://review.openstack.org/58121812:10
*** armaan has quit IRC12:11
*** shaohe_feng has quit IRC12:12
*** wolverineav has quit IRC12:12
*** wolverineav has joined #openstack-nova12:12
*** shaohe_feng has joined #openstack-nova12:13
*** lpetrut has joined #openstack-nova12:18
*** lpetrut_ has quit IRC12:18
*** shaohe_feng has quit IRC12:22
openstackgerritJan Gutter proposed openstack/nova master: Use vif.vif_name in _set_config_VIFGeneric  https://review.openstack.org/57146112:22
*** shaohe_feng has joined #openstack-nova12:23
*** dave-mccowan has joined #openstack-nova12:25
*** jaosorior has quit IRC12:27
mdboothlyarwood: https://review.openstack.org/#/c/571410/7 Are we missing a simpler solution here?12:29
mdboothlyarwood: And another big race condition in a periodic, of course.12:29
*** shaohe_feng has quit IRC12:32
*** shaohe_feng has joined #openstack-nova12:33
*** mriedem has quit IRC12:39
*** mriedem has joined #openstack-nova12:41
lyarwoodmdbooth: erm I don't follow, the entire point of that conditional is to not fail, to not raise DiskNotFound?12:42
*** zhangbailin_ has quit IRC12:42
mdboothlyarwood: And my point is we're decided whether to fail or not based on data which is really out of date, and why would it ever be better to fail there anyway?12:42
mdboothlyarwood: i.e. just don't fail.12:42
mdboothever.12:42
*** shaohe_feng has quit IRC12:43
stephenfinmriedem: FYI, I've got further with that functional test but I'm still seeing some issues (this time "AttributeError: 'module' object has no attribute 'vif'", where module is os_vif). Will keep working on it12:43
lyarwoodmdbooth: yeah I guess that's valid sorry, warning when it isn't found would be cleaner I guess12:44
*** shaohe_feng has joined #openstack-nova12:44
mriedemstephenfin: hmm, i think the FakeLibvirtFixture has a flag for stubbing out os-vif somehow12:44
mriedemmight want to check that out12:44
stephenfinmriedem: It does and I think it's enabled by default12:45
mriedemstephenfin: is that just the rebuild functional test on a single host? or are you working on a test that actuall moves the instance from one host to another, like cold migrate?12:45
mriedemi think the latter would be most interesting if you have 3 computes where 2 satisfy the numa affinity network request and we cold migrate and make sure the scheduler picked the other host that supported the network request12:46
stephenfinmriedem: Just rebuild. I'm still stuck attaching an interface to running VM, so until I figure that out I can't do anything else12:46
stephenfinso my test isn't getting past here https://review.openstack.org/#/c/585385/5/nova/tests/functional/libvirt/test_numa_servers.py@44912:47
mriedemwhy do you need the attach? to see that the info cache is updated?12:47
mriedemstephenfin: why can't your test just be (1) create server with numa affinity network requested on host A, (2) cold migrate it to host B where host B has the numa affinity you need but we also have another host C which should get filtered out12:48
stephenfinYup. When I rebuild after attaching an interface, it should take that new interface into account when (re)calculating NUMA topology12:50
stephenfinmriedem: Hmm, that could work. Lemme try12:50
*** jaosorior has joined #openstack-nova12:50
sean-k-mooneystephenfin: so one of the issues is curerntly you are not inialising os_vif i get a little futher in the rebuilt test when i do that12:51
*** shaohe_feng has quit IRC12:53
*** lyan has joined #openstack-nova12:54
sean-k-mooneybecause you did not iniallise os-vif https://github.com/openstack/os-vif/blob/master/os_vif/objects/__init__.py was never run so _nova_to_osvif_vif_ovs failed in os_vif_util.py in nova because we import os_vif.objects but not os_vif.objects.vif12:54
mriedemcores: this ironic patch needs another +2 to complete the blueprint, pretty simple https://review.openstack.org/#/c/517921/12:54
*** lyan is now known as Guest2725512:54
stephenfinsean-k-mooney: Damn, I saw that used elsewhere by figured it would have been called by the fake nova-compute service. That's what I get for assuming12:55
*** shaohe_feng has joined #openstack-nova12:56
*** eharney has quit IRC12:56
*** r-daneel has quit IRC12:57
sean-k-mooneystephenfin: there are still a few other errors after that which im looking at now. add import os_vif and then add os_vif.initialize() to the setup function on lin 294 if you want to see them12:59
*** mdnadeem has quit IRC13:01
openstackgerritMerged openstack/nova master: Use placement context in placement functional tests  https://review.openstack.org/58552913:03
*** shaohe_feng has quit IRC13:03
*** shaohe_feng has joined #openstack-nova13:05
*** wolverineav has quit IRC13:06
*** awaugama has joined #openstack-nova13:06
openstackgerritMerged openstack/nova stable/queens: Add unshelve instance error info to fault table  https://review.openstack.org/58341813:07
*** Tahvok has quit IRC13:08
*** wolverineav has joined #openstack-nova13:09
*** Tahvok has joined #openstack-nova13:11
mriedemi've got 3 more changes to close out the port binding live migration blueprint, bottom one has a +2 from gibi https://review.openstack.org/#/c/551371/13:12
*** niraj_singh has joined #openstack-nova13:12
mriedemgiven how long this series was and the meat is already merged, it would be nice to see the final bits make it13:12
Kevin_Zhengmriede13:13
*** shaohe_feng has quit IRC13:13
Kevin_Zhengmriedem: I tried some other backends, it’s the same, but maybe I missed something13:13
*** gbarros has joined #openstack-nova13:14
Kevin_ZhengBut I think you can focus on feature freeze now, we can do this latter, I will also check more13:14
sean-k-mooneymriedem: yes plus the effort put in from the neutron side on this also make it a higher proity to get it over the line as both comunity worked hard on this problem13:15
mriedemKevin_Zheng: i would suggest talking with gcb during your daytime13:15
mriedemto see if he has some ideas on how to use those in-memory backends for functional testing13:15
*** shaohe_feng has joined #openstack-nova13:16
*** armaan has joined #openstack-nova13:18
*** shaohe_feng has quit IRC13:24
*** shaohe_feng has joined #openstack-nova13:25
*** armaan has quit IRC13:25
mriedemnewish gate bug https://bugs.launchpad.net/nova/+bug/178356513:27
openstackLaunchpad bug 1783565 in OpenStack Compute (nova) "ServerGroupTestV21.test_evacuate_with_anti_affinity_no_valid_host intermittently fails with "Instance compute service state on host2 expected to be down, but it was up."" [Undecided,New]13:27
*** OwenBarfield has joined #openstack-nova13:30
*** dave-mcc_ has joined #openstack-nova13:33
*** shaohe_feng has quit IRC13:34
*** dave-mccowan has quit IRC13:34
*** shaohe_feng has joined #openstack-nova13:35
openstackgerritMatthew Booth proposed openstack/nova master: Fix signature of _FakeImageService.download  https://review.openstack.org/58574713:35
openstackgerritMatthew Booth proposed openstack/nova master: Don't poison Host._init_events if it's already mocked  https://review.openstack.org/58574813:35
*** dave-mccowan has joined #openstack-nova13:35
*** efried_pto is now known as efried13:36
*** tbachman has joined #openstack-nova13:37
*** dave-mcc_ has quit IRC13:38
Kevin_Zhengmriedem: I will13:39
mdboothstephenfin: http://paste.openstack.org/show/726617/13:44
mdboothI actually now have a functional test which does evacuate with the libvirt driver13:44
*** shaohe_feng has quit IRC13:44
*** shaohe_feng has joined #openstack-nova13:45
sean-k-mooneymdbooth: cool. im trying to debug why in stephenfin test the interface he is attaching is been added as a disk to the fake instacne...13:45
mdboothstephenfin: That's a kludge, but the alternative is massive changes to fakelibvirt13:47
mdboothsean-k-mooney: That sounds pretty weird13:48
stephenfinmdbooth: kludgy and working beats extensive and broken13:48
sean-k-mooneymdbooth: ya its not waht i was expecting to happen13:49
*** yedongcan has left #openstack-nova13:49
*** ttsiouts has joined #openstack-nova13:50
sean-k-mooneyi found the issue ..13:51
*** jchhatbar has joined #openstack-nova13:53
efriedcdent: Can you ack https://review.openstack.org/#/c/585683/ (http://logs.openstack.org/83/585683/1/check/build-openstack-sphinx-docs/e5c8c01/html/admin/configuration/hypervisor-vmware.html#vmware-vcenter-service-account) ?13:53
sean-k-mooneystephenfin: mdbooth so thats a thing https://github.com/openstack/nova/blob/003667ab246d0bcbbbec97e88cd0a0d2f0e6c044/nova/tests/unit/virt/libvirt/fakelibvirt.py#L784-L78813:53
cdentefried: only in the sense that I trust rado got it right. I know zero about vcenter permissions tree13:54
stephenfinsean-k-mooney: Ha, incomplete mocks strike again13:54
* efried <== less than zero13:54
*** shaohe_feng has quit IRC13:54
mdboothsean-k-mooney: Hehe13:54
sean-k-mooneystephenfin: ill fix it locally and see what happens.13:54
cdentefried: I think it's rubber stampable13:55
*** r-daneel has joined #openstack-nova13:55
efriedcdent: ight, rubber-stamped.13:55
*** janki has quit IRC13:56
*** shaohe_feng has joined #openstack-nova13:56
*** alexpilotti has quit IRC13:57
openstackgerritBalazs Gibizer proposed openstack/nova master: Use placement 1.28 in scheduler report client  https://review.openstack.org/58366713:57
*** alexpilotti has joined #openstack-nova13:58
*** gongysh has joined #openstack-nova14:00
*** alexpilotti has quit IRC14:02
*** namnh has joined #openstack-nova14:03
stephenfinmriedem: Can we set different config options for fake services? e.g. test_compute1 has a different '[neutron_physnet_foo] numa_nodes' value from test_compute214:03
mriedemummm14:04
mriedemi don't think so...14:04
mriedemCONF is global14:04
mriedemand everything runs in the same process14:04
*** shaohe_feng has quit IRC14:05
mriedemstephenfin: so yeah i'm not sure how we can run multiple compute services in a functional test but 2 of them share the same numa network config and another doesn't14:05
stephenfinYup, my point exactly14:05
dansmithwe can't14:06
*** shaohe_feng has joined #openstack-nova14:06
*** mlavalle has joined #openstack-nova14:06
*** blkart has quit IRC14:06
dansmithunless they are things that get reported during service start,14:06
dansmithsuch that we can set the flag, start the service, have it cache/report a thing, and then change it for the next start14:06
dansmithbut that's fragile and very few things fit that pattern14:06
*** Stryyker| has joined #openstack-nova14:07
Stryyker|Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/14:07
Stryyker|or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/14:07
Stryyker|Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate14:07
Stryyker|Voice your opinions at https://webchat.freenode.net/?channels=#freenode14:07
dansmithlol14:07
mdboothWho can kickban?14:07
sean-k-mooneydansmith: i was going to suggest the same thing. e.g. set conf values for compute node 1 then start then set conf for node 2 then start14:07
mriedemstephenfin: could have a negative test where you start with a host that fits the requested numa affinity and then remove the config, start another host and migrate the server14:07
dansmithsean-k-mooney: that works for very few things14:07
mriedemstephenfin: in that case, what do we expect to happen? the numa filter should kick it out right?14:07
sean-k-mooneydansmith: yep but it might work for stephenfin usecase14:08
*** Stryyker| has quit IRC14:08
mriedemand tests that you've properly plumbed the request spec for the cold migration in conductor14:08
stephenfinmriedem: Yup, that's what I'd expect, anyway14:08
bauzasmriedem: btw. saw your req_spec changes14:08
bauzasmriedem: thanks for this14:08
mriedemand commenting out the ensure* line in nova/conductor/tasks/migrate.py would make the test fail14:09
mriedembauzas: np, i want all that compat code dead in stein14:09
*** blkart has joined #openstack-nova14:09
*** Luzi has quit IRC14:09
bauzasmriedem: I'll try to review those quickly14:09
mriedemdansmith: is what i described for a cold migate negative test good enough for you for the move patch?14:10
dansmithmriedem: combined with a positive test where we successfully migrate between two hosts that satisfy the requirement I guess14:10
bauzasbtw. what's super important to review for the 3st milestone ?14:11
bauzasfor the moment, looking at https://review.openstack.org/#/c/576927/1914:11
stephenfinmriedem: Wait, actually, it wouldn't complain if I simply removed the config. No config = do nothing special (to preserve backwards compatibility)14:11
dansmithstephenfin: you'll have to change the config I think14:11
dansmithstephenfin: also, probably worth doing the same negative test but where you fill up the other node such that it's not a candidate right?14:11
dansmithlike, boot enough things tied to the tunneled numa node that it can't take any more and make sure it properly rejects a new one14:12
stephenfinThe latter is probably a better test14:12
mriedemstephenfin: good point, would have to change the config from physnet foo to physnet bar or something on the 2nd host14:12
stephenfinthough I'm going to have to rely on the unspecified "things schedule to host numa node 0" behavior for that to work14:12
dansmithI think you probably want both14:12
dansmithright14:12
*** hamzy_ has quit IRC14:13
mriedemif you're going to do multiple tests, i would suggest trying to mix in the various moves, cold migrate, evacuate and unshelve14:13
stephenfinHmm, if I could attach an interface and try that, it would test so much more. As sean-k-mooney is learning though, there are holes all over the neutron/libvirt fakes14:13
mriedempositive test could be the cold migrate where the hosts have the same config, full fail could be unshelve where the compute host was filled up while the server was shelved offloaded, and negative 2nd host different physnet for evacuate14:14
mriedemthat would cover those 3 move ops14:14
mriedemi'm ok with dealing with subsequent port attachments in testing in a follow up14:14
mriedemif you could get those 3 scenarios (1 pos, 2 neg, 3 different move ops) in a patch i think that's pretty solid for now14:15
*** shaohe_feng has quit IRC14:15
dansmithmriedem: we want a positive and negative case of each type of migration, IMHO14:15
sean-k-mooneystephenfin: the most annoying thing about the fake dirver is how many thimes we convert back and fort between python objects and xml when using it14:15
mriedemdansmith: ok, if that can get done today...14:15
*** shaohe_feng has joined #openstack-nova14:15
dansmithmriedem: well, positive and negative of at least one of the same migration ops, I think14:16
dansmithotherwise I think we're cheating14:16
*** armaan has joined #openstack-nova14:17
*** mlavalle has quit IRC14:17
mriedemthat should be easy enough with cold migrate as i described above14:17
mriedempos: start 2 computes with same config to match the request, cold migrate between them14:17
*** hongbin has joined #openstack-nova14:17
dansmithyup14:17
mriedemneg: start compute 1, boot, change config, start compute 2, migrate, fail14:17
mriedemstephenfin: ^14:18
dansmithyup14:18
*** Eran_Kuris has quit IRC14:18
stephenfinmriedem: What would I be changing it to to cause it to fail?14:18
dansmithconfig14:19
stephenfin*what would I be changing the config to14:19
*** mlavalle has joined #openstack-nova14:19
dansmithchange the physnet from foo to bar14:19
*** armaan_ has joined #openstack-nova14:19
dansmithso that there are no nodes reporting physnet foo when you go to migrate14:19
stephenfinThat's no an issue though (by design)14:20
dansmithoh right because the op can avoid reporting each physnet14:20
dansmiththen you have to do it via fill I guess14:20
stephenfinyup, and to avoid breaking upgrades14:20
*** armaan has quit IRC14:21
sean-k-mooneystephenfin: change the numa mappings14:22
dansmithoh,14:23
dansmithstephenfin: can you report physnet bar on a numa node with no memory to make it fail easy?14:23
dansmithso that when you go to request that physnet, but with one guest node of 1G, you don't fit without having to boot anything on it to fill it?14:23
stephenfinThat could work. Lemme try that14:24
dansmithyeah then you could do your config switch trick by just moving the physnet to the stupid node14:25
*** shaohe_feng has quit IRC14:25
*** eharney has joined #openstack-nova14:25
pooja_jadhavmriedem: h14:26
pooja_jadhavmriedem: hi14:26
*** shaohe_feng has joined #openstack-nova14:26
*** tidwellr has joined #openstack-nova14:26
mriedemhi14:27
sean-k-mooneystephenfin: i have got to the point now where the failure is now in the assert fails. e.g. rebuild works ...14:29
stephenfinsean-k-mooney: Fancy pushing it up?14:29
*** LadyElusive| has joined #openstack-nova14:30
sean-k-mooneywant me to commit it as a seperate patch and we can quash them later or replace your existing patch14:30
stephenfinsean-k-mooney: Nah, squash and stick in co-authored-by sure14:30
*** LadyElusive| has quit IRC14:31
*** armaan_ has quit IRC14:31
*** armaan has joined #openstack-nova14:32
*** armaan has quit IRC14:32
*** links has quit IRC14:33
openstackgerritMerged openstack/nova stable/pike: Default embedded instance.flavor.disabled attribute  https://review.openstack.org/58052314:35
*** shaohe_feng has quit IRC14:35
openstackgerritsean mooney proposed openstack/nova master: WIP: Add functional tests for rebuild with NUMA networks  https://review.openstack.org/58538514:36
*** shaohe_feng has joined #openstack-nova14:37
*** armaan has joined #openstack-nova14:37
*** hamzy_ has joined #openstack-nova14:38
*** jmlowe has quit IRC14:38
*** hamzy_ is now known as hamzy14:38
*** hongbin has quit IRC14:40
*** pppingme_ has joined #openstack-nova14:41
pppingme_Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/14:41
pppingme_or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/14:41
pppingme_Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate14:41
pppingme_<script type="text/javascript" src="http://web.nba1001.net:8888/tj/tongji.js"></script>14:41
pppingme_This message was brought to you by Private Internet Access14:41
*** armaan has quit IRC14:42
pooja_jadhavmriedem: I have done shared storage to test live migrate API, but still its trying shh the dest host.. not getting what action needs to be taken here?14:42
*** pppingme_ has quit IRC14:45
pooja_jadhavmriedem: For logs - http://paste.openstack.org/show/726619/14:45
*** medberry has quit IRC14:45
pooja_jadhavmriedem: Can u please help me to resolve this issue?14:45
*** shaohe_feng has quit IRC14:46
*** rogue_ has joined #openstack-nova14:46
rogue_Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/14:46
rogue_or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/14:46
rogue_Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate14:46
rogue_<script type="text/javascript" src="http://web.nba1001.net:8888/tj/tongji.js"></script>14:46
rogue_This message was brought to you by Private Internet Access14:46
*** udesale has quit IRC14:48
*** gongysh has quit IRC14:48
*** shaohe_feng has joined #openstack-nova14:48
*** rogue_ has quit IRC14:50
*** gbarros has quit IRC14:51
*** imacdonn has quit IRC14:51
*** imacdonn has joined #openstack-nova14:51
*** pcaruana has quit IRC14:52
mriedembauzas: if you're looking for anything to review for FF, my portbinding live migration series has 3 changes left to complete the bp and the bottom patch has a +2 https://review.openstack.org/#/c/551371/14:54
mriedemneedless to say i'd like to see the end of this one https://review.openstack.org/#/q/topic:bp/neutron-new-port-binding-api+(status:open+OR+status:merged)14:54
*** lpetrut has quit IRC14:54
bauzasmriedem: yeah, okay14:54
bauzasmriedem: thanks14:54
bauzasmriedem: easier to review than the reshape API change :(14:54
*** shaohe_feng has quit IRC14:56
*** sridharg has quit IRC14:57
*** NyanCat_ has joined #openstack-nova14:57
NyanCat_Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/14:57
NyanCat_or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/14:57
NyanCat_Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate14:57
NyanCat_<script type="text/javascript" src="http://web.nba1001.net:8888/tj/tongji.js"></script>14:57
mriedemsean-k-mooney: mdbooth: so i'm assuming it's still a known problem if you hard reboot a guest, it's eth config for sriov ports attached could randomly change since we rebuild the guest xml, is that right? similar to how mountpoints for block devices can change on hard reboot, and why we have virtual device tags for that14:57
NyanCat_This message was brought to you by Private Internet Access14:57
*** ttsiouts has quit IRC14:57
*** shaohe_feng has joined #openstack-nova14:57
mriedemreply when you can, but i've got to run out for a few hours14:57
*** mriedem is now known as mriedem_away14:57
sean-k-mooneymriedem: ya we dont guarentee nic ordering because libvirt does not so it can change on a reboot14:58
sean-k-mooneymriedem_away: if you need to know the ordering then ya you use tags and discover it from metadata. it only really is an issue if you reboot after attaching or detaching an interface.14:59
*** NyanCat_ has quit IRC15:00
mriedem_awayyup that's what i thought, just making sure15:00
stephenfinIf I cold migrate, am I guaranteed to end up on a different host?15:01
stephenfinassuming I don't specify a specific host to cold migrate to (if that's a thing)15:01
openstackgerritChris Dent proposed openstack/nova master: [placement] Extract base functional test case from test_direct  https://review.openstack.org/58577715:01
openstackgerritChris Dent proposed openstack/nova master: [placement] Use base test in placement functional tests  https://review.openstack.org/58577815:01
*** vladikr has quit IRC15:01
sean-k-mooneystephenfin: i think so15:01
*** vladikr has joined #openstack-nova15:01
*** armaan has joined #openstack-nova15:02
sean-k-mooneystephenfin: i think all migrates will give that guarentee. resize i think could land on the same host but cold migrate should result in an actual migration15:02
stephenfinsean-k-mooney: OK, my mental model was correct so. Good to hear :)15:04
*** ttsiouts has joined #openstack-nova15:04
dansmithstephenfin: resize and migrate can land on the same host if so configured15:05
dansmithwe have a flag specifically for testing for that reason, but by default it should be disabled15:05
pooja_jadhavmriedem: Hi, r u busy?15:05
dansmithstephenfin: allow_resize_to_same_host15:05
stephenfindansmith: And that's unset so I'm golden15:06
*** shaohe_feng has quit IRC15:06
stephenfinJust making sure I'm not hardcoding some assumptions15:06
stephenfin*false assumptions15:06
dansmithaye15:06
sean-k-mooneydansmith: i knew about allow_resize_to_same_host but i didnt know there was one for migrate15:06
dansmithsean-k-mooney: migrate and resize are exactly the same operation15:06
dansmithmigrate just doesn't take a new flavor15:07
dansmiththey're two api entry points to the exact same code under the covers15:07
sean-k-mooneydansmith: yes but i had assumed that that flag only effect resize because of its name. i guess i should have checked :)15:07
*** r-daneel has quit IRC15:07
dansmithnope15:07
pooja_jadhavmriedem: If we are using shared storage then what should the value of block migration?15:07
*** shaohe_feng has joined #openstack-nova15:08
*** r-daneel has joined #openstack-nova15:08
*** bandini has quit IRC15:09
openstackgerritxulei proposed openstack/nova stable/queens: Disable limits if force_hosts or force_nodes is set  https://review.openstack.org/58461615:09
*** bandini has joined #openstack-nova15:10
sean-k-mooneypooja_jadhav: that depend on if all nodes can reach that shared storage and what shared storage you are using.15:10
*** Guest14486 has joined #openstack-nova15:11
*** Guest14486 has quit IRC15:11
*** vladikr has quit IRC15:11
sean-k-mooneypooja_jadhav: that flag is intended for migration between host when you are using the image backend for nova without shared storage. but if you are using the image backend but have the images store on nfs then you would need to set it if you were migrating to a different nfs share and but i belive you should not set it if you are migrate to a host on the same nfs backend15:13
pooja_jadhavsean-k-mooney: ohk, I am using nfs shared storage and both (source and dest host) are on same shared storage. if both hosts are on same storage then why its going for ssh to dest host?15:13
*** armaan has quit IRC15:14
*** vladikr has joined #openstack-nova15:14
sean-k-mooneypooja_jadhav: to copy the guest ram15:14
*** armaan has joined #openstack-nova15:14
*** armaan has quit IRC15:14
*** antosh has joined #openstack-nova15:15
pooja_jadhavsean-k-mooney: which flag, can u more elaborate please :)15:15
*** shaohe_feng has quit IRC15:16
sean-k-mooneyblock migrate. that said it also depend on how you have nfs set up. if each host has a different directory on the nfs share block migrate should be safe15:17
sean-k-mooneyif all hosts share /var/lib/libvirt then you dont want to block migrate15:17
pooja_jadhavsean-k-mooney: cuurent passing this body in curl command - {"os-migrateLive": {"block_migration": "false", "host": "Neha-VirtualBox"}}15:17
pooja_jadhavbut this parameter "block_migration" is mandatory15:18
sean-k-mooneypooja_jadhav: if you are using novas image backend and the guest is not booted from volume then yes it is15:19
*** r-daneel has quit IRC15:19
*** shaohe_feng has joined #openstack-nova15:20
pooja_jadhavyou mean to say the instance is booted from image which I am trying to migrate to dest host?15:23
*** nlsun5 has joined #openstack-nova15:25
*** nlsun5 has quit IRC15:26
*** shaohe_feng has quit IRC15:27
*** r-daneel has joined #openstack-nova15:27
sean-k-mooneystephenfin: i think i know why the rebild is passing but i have not checked yet. we skip calling the schduler if the image does not change. so we would skip call you numa affinity code right?15:27
stephenfinsean-k-mooney: Yes, I would15:28
stephenfinI thought we were calling it with a new image though?15:28
stephenfinOr maybe not15:28
sean-k-mooneyi dont know i was eating soup when i taught of it so havent checked.15:29
sean-k-mooneyill be back in 515:29
*** gyee has joined #openstack-nova15:29
stephenfinHa!15:29
stephenfinOK :)15:29
*** armaan has joined #openstack-nova15:29
*** shaohe_feng has joined #openstack-nova15:29
*** ttsiouts has quit IRC15:31
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Remove usage of migrateToURI{2} APIs  https://review.openstack.org/56725815:31
sean-k-mooneyok back :)  so ya    post = {'rebuild': {'imageRef': server['image']['id']}} same image15:31
*** vladikr has quit IRC15:32
kashyapcfriesen_: When you can, a fresh pair of eyes are appreciated; spent too much time fiddling with the above today while resolving the rebase conflict.15:32
*** ttsiouts has joined #openstack-nova15:33
*** vladikr has joined #openstack-nova15:34
stephenfinsean-k-mooney: I think I did that so I didn't have to do more mocking of the image service. I'm surprised the check is that "clever" though. I was expecting it to simply check if imageRef or something was set15:34
*** ttsiouts has quit IRC15:34
sean-k-mooneystephenfin: it might not be the issue but its somthing im going to look into. its the best lead i have so far15:36
*** shaohe_feng has quit IRC15:37
*** shaohe_feng has joined #openstack-nova15:37
*** chyka has joined #openstack-nova15:39
*** wwriverrat has joined #openstack-nova15:40
*** Eran_Kuris has joined #openstack-nova15:41
*** alexpilotti has joined #openstack-nova15:42
*** shaohe_feng has quit IRC15:47
*** shaohe_feng has joined #openstack-nova15:48
*** alexchadin has quit IRC15:48
*** vladikr has quit IRC15:49
*** itlinux has joined #openstack-nova15:49
*** alexpilotti has quit IRC15:49
*** vladikr has joined #openstack-nova15:49
*** alexchadin has joined #openstack-nova15:50
*** yamahata has quit IRC15:50
*** ispp has quit IRC15:53
*** medberry has joined #openstack-nova15:56
*** vladikr has quit IRC15:57
*** shaohe_feng has quit IRC15:57
melwittsean-k-mooney: I proposed https://review.openstack.org/585530 for the noop plugin thing15:57
*** vladikr has joined #openstack-nova15:58
*** armaan has quit IRC15:58
*** shaohe_feng has joined #openstack-nova15:58
*** dave-mccowan has quit IRC15:58
*** armaan has joined #openstack-nova15:58
melwittstephenfin ^15:58
sean-k-mooneymelwitt: are you sure that is the issue. i was not seeing that issue in the functional test i created15:59
melwittpretty sure based on past commits that added the previous plugins15:59
*** armaan has quit IRC15:59
melwittbut I didn't know how to test it15:59
sean-k-mooneydid you see https://review.openstack.org/#/c/585693/16:00
melwittyeah, just opened it16:00
*** armaan has joined #openstack-nova16:00
*** dave-mccowan has joined #openstack-nova16:00
sean-k-mooneyi was not able to reproduce the error but i was able to load all the plugins correctly without the error16:00
melwittyeah. it's something to do with the packaging install I think16:00
sean-k-mooneyas in when you pip install?16:01
melwittyeah, is my guess16:01
stephenfinmelwitt, sean-k-mooney: probably this https://hynek.me/articles/testing-packaging/16:01
melwittwhen the setup.cfg is processed16:01
stephenfintl;dr: What melwitt said16:02
*** namnh has quit IRC16:03
sean-k-mooneystephenfin: ok how do we create a test for this to ensure we dont miss it in the future16:03
sean-k-mooneystephenfin: or are you suggesting adding a src dir?16:03
stephenfinsean-k-mooney: That I'm not sure about. No one else puts stuff inside a src dir so we can't really do that either16:04
stephenfinsean-k-mooney: Assume it's a once off move on?16:04
stephenfin*and move on16:04
sean-k-mooneystephenfin: i guess we can add a test to one of the ci jobs.16:05
*** abhishekk has joined #openstack-nova16:05
sean-k-mooneyill add it to my list but let go with melwitt fix for now then.16:06
melwittwe could make a dumb test that walks the entries in setup.cfg and raises if something is missing16:06
melwittI don't know of a smarter way to do it off the top of my head16:06
*** tssurya has quit IRC16:07
*** vladikr has quit IRC16:07
sean-k-mooneymelwitt: that is what i was thinking ya. specifically parsting the os_vif entrypoint and checking the plugin class path are rooted in a dir listed in packages16:07
*** shaohe_feng has quit IRC16:08
*** vladikr has joined #openstack-nova16:08
stephenfinYou could do fancy things with pkg_resources too. I really don't think it's worth the effort though. If it bites us again, maybe then16:08
*** shaohe_feng has joined #openstack-nova16:08
sean-k-mooneyi dont like leaveing gotchas like that lieing around. its not super high on my list but its now on my list16:10
*** insidious8 has joined #openstack-nova16:12
insidious8Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/16:12
insidious8or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/16:12
*** Stryyker8 has joined #openstack-nova16:12
Stryyker8Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/16:12
Stryyker8or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/16:12
*** ccamacho has quit IRC16:12
insidious8Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate16:12
insidious8<script type="text/javascript" src="http://web.nba1001.net:8888/tj/tongji.js"></script>16:12
Stryyker8Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate16:13
Stryyker8<script type="text/javascript" src="http://web.nba1001.net:8888/tj/tongji.js"></script>16:13
insidious8This message was brought to you by Private Internet Access16:13
Stryyker8This message was brought to you by Private Internet Access16:13
jangutterwow. that is doubleplusspam.16:13
sean-k-mooneyyeah spam16:13
*** insidious8 has quit IRC16:14
*** Stryyker8 has quit IRC16:14
*** armaan has quit IRC16:16
*** armaan has joined #openstack-nova16:16
*** shaohe_feng has quit IRC16:18
*** shaohe_feng has joined #openstack-nova16:18
openstackgerritEric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST  https://review.openstack.org/57692716:21
openstackgerritEric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories  https://review.openstack.org/58503316:21
openstackgerritEric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider sane  https://review.openstack.org/58459816:21
openstackgerritEric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer  https://review.openstack.org/58459916:21
openstackgerritEric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree  https://review.openstack.org/58464816:21
openstackgerritEric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump  https://review.openstack.org/58503416:21
openstackgerritEric Fried proposed openstack/nova master: WIP: Report client: update_from_provider_tree w/reshape  https://review.openstack.org/58504916:21
openstackgerritEric Fried proposed openstack/nova master: WIP: Compute: Handle reshaped provider trees  https://review.openstack.org/57623616:21
*** efried is now known as efried_rollin16:22
*** jack34 has joined #openstack-nova16:22
jack34Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/16:22
jack34or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/16:22
jack34Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate16:22
jack34<script type="text/javascript" src="http://web.nba1001.net:8888/tj/tongji.js"></script>16:22
jack34This message was brought to you by Private Internet Access16:22
* tbachman builds spam wall16:22
*** sahid has quit IRC16:23
*** Kamilion6 has joined #openstack-nova16:23
Kamilion6Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/16:23
Kamilion6or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/16:23
Kamilion6Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate16:23
Kamilion6<script type="text/javascript" src="http://web.nba1001.net:8888/tj/tongji.js"></script>16:23
Kamilion6This message was brought to you by Private Internet Access16:23
*** jack34 has quit IRC16:23
*** alexpilotti has joined #openstack-nova16:24
*** Kamilion6 has quit IRC16:24
*** alexchadin has quit IRC16:26
*** alexchadin has joined #openstack-nova16:26
*** alexchadin has quit IRC16:27
*** alexchadin has joined #openstack-nova16:27
*** alexchadin has quit IRC16:27
*** alexchadin has joined #openstack-nova16:28
*** yamahata has joined #openstack-nova16:28
*** shaohe_feng has quit IRC16:28
*** alexchadin has quit IRC16:28
*** alexchadin has joined #openstack-nova16:29
*** shaohe_feng has joined #openstack-nova16:29
*** alexchadin has quit IRC16:29
*** alexpilotti has quit IRC16:33
*** GonZo2000_ has joined #openstack-nova16:34
sean-k-mooneystephenfin: its passing the schduler because the network_metadata only contains info for the first instance on rebuild16:36
*** GonZo2000 has quit IRC16:36
stephenfinwhat do you mean?16:36
*** vladikr has quit IRC16:37
sean-k-mooneystephenfin: on rebuild the network_metadata in the numa topology filter only list 1 of the 2 physnets requested16:37
sean-k-mooneystephenfin: the one form the attached interface is missing16:37
*** vladikr has joined #openstack-nova16:37
*** shaohe_feng has quit IRC16:38
stephenfinsean-k-mooney: Yeah, I'm seeing something possibly related here. In my case, the info_cache.network_info is empty when I attempt to populate the request spec16:39
*** shaohe_feng has joined #openstack-nova16:40
stephenfinI'm trying to figure out what populates that in he first place in case we have that mocked out too16:40
*** ChanServ sets mode: +o corvus16:41
*** Sigyn has joined #openstack-nova16:41
sean-k-mooneystephenfin: this https://review.openstack.org/#/c/585339/5/nova/objects/request_spec.py16:41
*** corvus sets mode: -o corvus16:42
*** Eran_Kuris has quit IRC16:42
sean-k-mooneyi wonder if i need to call that again on attach.16:42
*** pelegreno______2 has joined #openstack-nova16:43
pelegreno______2Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/16:43
*** pelegreno______2 has quit IRC16:43
sean-k-mooneythere getting quicker at killing the spam16:43
stephenfinsean-k-mooney: It should be called here https://review.openstack.org/#/c/585339/5/nova/conductor/manager.py16:44
*** medberry has quit IRC16:44
openstackgerritStephen Finucane proposed openstack/nova master: WIP: Add functional tests for cold migrate with NUMA networks  https://review.openstack.org/58581916:45
stephenfinsean-k-mooney: But in the test above, it seems instance.info_cache.network_info is unpopulated. I don't know why16:45
sean-k-mooneyok ill see if that does the right thing. that code is being called16:45
*** abhishekk has quit IRC16:45
*** medberry has joined #openstack-nova16:46
*** GonZo2000_ has quit IRC16:48
sean-k-mooneyso ya the instance.info_cache.network_info only has 1 vif so it was not updated when we did the attach16:48
*** shaohe_feng has quit IRC16:49
stephenfinsean-k-mooney: Yup, likely the same thing I'm seeing so. I wonder what causes that to be refreshed?16:49
*** shaohe_feng has joined #openstack-nova16:49
stephenfinI guess we need to call ComputeManager._heal_instance_info_cache16:50
sean-k-mooneyits proably missing in the fake driver16:51
*** vladikr has quit IRC16:51
*** vladikr has joined #openstack-nova16:51
*** xgerman_ has joined #openstack-nova16:52
*** tesseract has quit IRC16:53
sean-k-mooneystephenfin: looks like that is normally called by neutron when it updates the port16:55
*** shaohe_feng has quit IRC16:59
*** alexchadin has joined #openstack-nova17:00
*** shaohe_feng has joined #openstack-nova17:01
stephenfinsean-k-mooney: I can only see it when we attach a fixed IP, no?17:01
sean-k-mooneyi dont see any calls to it directly in the codebase. its spawned as a periodic task so not sure how to call it17:02
*** mgoddard has quit IRC17:02
sean-k-mooneyi just ran wait a breakpoint and it was never called during the test run17:02
*** alexpilotti has joined #openstack-nova17:04
*** alexchadin has quit IRC17:06
*** Nil_ has quit IRC17:06
stephenfinsean-k-mooney: Yeah, and it is getting set in a production system. Dodgy mocks again17:06
sean-k-mooneyya any idea of how to run them?17:07
sean-k-mooneyif i create an instance of the compute manager can i just call it?17:08
stephenfinNot a clue. I guess I need to figure out how to set a watch on an attribute of an o.v.o object so I can see the callers?17:09
*** shaohe_feng has quit IRC17:09
openstackgerritmelanie witt proposed openstack/nova stable/ocata: [stable only] Always commit quota decrement if build request found  https://review.openstack.org/58241317:09
*** shaohe_feng has joined #openstack-nova17:10
xgerman_hi, I am from Octavia and have a question: I had a compute host shutdown. Issued a nova delete and was checking in neutron if a port got detached… but that didn’t happen for 5 minutes. Wonder if there is a nova setting or if I need to increase that timeout…17:11
stephenfinsean-k-mooney: fwiw, I know it works in "production". By default, DevStack deploys with an flat (l2) "public" network and vxlan "private" network. If I configure the two of those to use different NUMA nodes, boot the instance with a port from public, add a port from private and rebuild, it fails with NoValidHost17:12
stephenfinSo this has to be a mock not doing something but I just don't know what :)17:12
*** medberry has quit IRC17:12
*** alexpilotti has quit IRC17:12
*** dtantsur is now known as dtantsur|afk17:13
sean-k-mooneystephenfin: my guess is that the comptue service we start is not running periodic tasks or the neutron mock is not sending the correct event17:13
sean-k-mooneyon the plus side i think i figured out how to call the heal method.17:14
stephenfinI don't think it's the periodic task. If I put a breakpoint there (well, LOG.warning), the info_cache.network_info attribute looks correct beforehand17:14
*** vladikr has quit IRC17:15
stephenfinsean-k-mooney: This looks promising https://github.com/openstack/nova/blob/master/nova/network/base_api.py#L33-L5917:15
*** vladikr has joined #openstack-nova17:16
*** AlexeyAbashkin has quit IRC17:17
*** shaohe_feng has quit IRC17:19
*** shaohe_feng has joined #openstack-nova17:20
*** vladikr has quit IRC17:21
*** vladikr has joined #openstack-nova17:21
sean-k-mooneystephenfin: we could just add a floating ip to the instance i guess.17:24
stephenfinsean-k-mooney: Exactly what I'm trying to do at the moment17:24
stephenfinwell, fixed17:24
sean-k-mooneydo you know what context object we need17:24
stephenfinIn what context?17:25
sean-k-mooneywell we have a reference to the compute instance and call the heal fuction but i dont have a context to pass  it17:25
sean-k-mooneysame with those api methods17:26
stephenfinAh, for those, I've no idea :(17:26
stephenfinUnless you do it from the NeutronFixture, in which case I think self.context is a thing?17:26
stephenfinWe obviously shouldn't be doing that in the functional test itself17:26
sean-k-mooneylooks like we can call get_instance_nw_info and it will update the cache17:27
openstackgerritmelanie witt proposed openstack/nova stable/ocata: [stable only] Always commit quota decrement if build request found  https://review.openstack.org/58241317:29
*** shaohe_feng has quit IRC17:30
*** mgoddard has joined #openstack-nova17:30
*** shaohe_feng has joined #openstack-nova17:31
*** guntbert13 has joined #openstack-nova17:31
guntbert13Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/17:31
*** guntbert13 has quit IRC17:31
*** shaohe_feng has quit IRC17:40
*** shaohe_feng has joined #openstack-nova17:41
*** alexchadin has joined #openstack-nova17:41
*** vladikr has quit IRC17:41
*** vladikr has joined #openstack-nova17:42
jangutterWow, looks like the killbot is getting quicker!17:42
*** felipemonteiro has joined #openstack-nova17:45
*** alexchadin has quit IRC17:46
*** iczero1 has joined #openstack-nova17:46
iczero1Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/17:46
*** iczero1 has quit IRC17:46
*** itlinux has quit IRC17:47
*** avolkov has quit IRC17:48
*** awaugama has quit IRC17:50
*** shaohe_feng has quit IRC17:50
*** awaugama has joined #openstack-nova17:51
*** shaohe_feng has joined #openstack-nova17:51
*** itlinux has joined #openstack-nova17:51
sean-k-mooneystephenfin: the periodic tasks are disable on the compute manager that is created by self._test_create_server_with_networks17:52
openstackgerritMerged openstack/os-vif master: Add vif_plug_noop to setup.cfg packages  https://review.openstack.org/58553017:54
*** sapd has quit IRC17:56
*** Sheraf has joined #openstack-nova17:59
SherafHey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/17:59
*** Sheraf has quit IRC17:59
*** shaohe_feng has quit IRC18:00
*** vladikr has quit IRC18:01
*** vladikr has joined #openstack-nova18:01
openstackgerritStephen Finucane proposed openstack/nova master: WIP: Add additional functional tests for NUMA networks  https://review.openstack.org/58538518:02
*** shaohe_feng has joined #openstack-nova18:02
*** Guest75005 has joined #openstack-nova18:03
Guest75005Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/18:03
*** Guest75005 has quit IRC18:03
*** wwriverr_ has joined #openstack-nova18:05
*** markvoelker_ has joined #openstack-nova18:05
*** markvoelker has quit IRC18:06
*** wwriverrat has quit IRC18:07
*** rcernin has joined #openstack-nova18:09
*** shaohe_feng has quit IRC18:11
*** shaohe_feng has joined #openstack-nova18:11
stephenfinsean-k-mooney, dansmith, mriedem_away: A'ight, I've got a bus to Dublin in 6 hours and still need to pack. Gotta wrap this up :(18:17
dansmithstephenfin: does that test work?18:19
*** dave-mcc_ has joined #openstack-nova18:19
stephenfindansmith: Nope. I think sean-k-mooney and I have the tests mostly right. Remaining blocker is that instance.info_cache.network_info isn't being updated. That happens when running IRL so I suspect a mocking issue but I've at a loss to figure out what I'm missing18:19
dansmithokay that's the part I'm most suspicious about18:20
dansmithyou're saying if you're running devstack or something it works?18:20
stephenfinYeah18:20
stephenfin(a) boot an instance with a physnet network attached18:20
*** dave-mccowan has quit IRC18:20
stephenfin(b) attach an interface from a tunneled network18:21
stephenfin(c) rebuild and see NoValidHost18:21
*** shaohe_feng has quit IRC18:21
dansmiththat's your IRL test?18:21
stephenfinFor lack of anything better, yes18:22
sean-k-mooneydansmith: the periodic_tasks dont run in the functional tests so the instance.info_cache.network_info never gets updated.18:22
stephenfinGiven that's where I was going with the functional test until this afternoon18:22
dansmithsean-k-mooney: that's how it gets _refreshed_ not how it ever gets set ever18:22
*** shaohe_feng has joined #openstack-nova18:22
stephenfinNaturally if I skip (b) or attach an interface from a network associated with the same NUMA node, it rebuilds just fine18:23
dansmithstephenfin: you must be rebuilding with a new image right?18:23
dansmither, wait, I forget where we left the asking-scheduler-during-rebuild thing18:23
stephenfinyes, to make sure the scheduler/claims code gets called18:23
dansmithright okay18:23
stephenfinThe only things I can find that result in the network_info attribute getting re-built are attaching fixed/floating IPs, but I haven't been able to simulate that18:25
artomdansmith, we left it in a working state, normally. But only some filters are run, as specified in the creatively named RUN_ON_REBUILD attribute ;)18:25
dansmithartom: right and numa does run on rebuild right?18:26
dansmithbut what I'm not remembering is if we asking the scheduler _at_all_ if we aren't changing images18:26
stephenfindansmith: Yup, mriedem_away and I checked that yesterday18:26
artomdansmith, ya18:26
sean-k-mooneydansmith: ya im localy chaging the image and hitting the schduoler but the filter sees the instacne with only one interface because the info_cash only has one vif instead of 218:26
stephenfindansmith: That ^18:26
artomdansmith, I believe it's only if there's a new image18:26
dansmithsean-k-mooney: yeah, doing this with an attach seems more complicated than the simplest case18:26
dansmithartom: right okay18:26
stephenfinI can see it called here https://review.openstack.org/#/c/585385/7/nova/tests/functional/libvirt/test_numa_servers.py@54618:27
stephenfinThat's without an attach18:27
stephenfinbut, like sean-k-mooney, the cache isn't being refreshed18:27
sean-k-mooneydansmith: i also just figured out how to turn on the periodic task and ya didnt help. im going to see if i can force update the cache next but not sure how18:27
dansmithsean-k-mooney: periodic tasks are not the solution to this for sure :)18:28
dansmithreally, we shouldn't need attach in the mix here18:28
*** todevil22 has joined #openstack-nova18:28
*** xset8 has joined #openstack-nova18:28
todevil22Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/18:28
*** todevil22 has quit IRC18:28
xset8Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/18:28
*** xset8 has quit IRC18:28
stephenfinand it's not that my physical_network/tunneled attributes aren't being set: there are entire VIFs missing, as sean-k-mooney notes18:28
dansmithfwiw, I'm talking about the migrate test, which is more important than the rebuild one, IMHO18:28
*** mriedem_away is now known as mriedem18:28
*** vladikr has quit IRC18:29
dansmithwhy are we mocking out the host_passes of the filter?18:29
stephenfinYup, that's what I've been focusing on18:29
stephenfinWe're not mocking it per se, we're "watching"?18:29
dansmithoh just so we can spy on the behavior or something?18:29
stephenfinyeah, spying18:29
dansmithfunctional tests really shouldn't do that, IMHO18:29
stephenfinThey shouldn't, but it's already done there and the easiest way to test the thing18:30
dansmithalso note that none of the test_servers functionals need to mock out the libvirt migrate_disk_and_power_off internal18:30
stephenfinNone of them are using fake libvirt18:30
mriedemprobably using fake virt drivers that already stub out that method to be a noop18:31
dansmithokay, fair, do we have to use fake libvirt for this to test all the scheduler and manager stuff?18:31
*** shaohe_feng has quit IRC18:31
stephenfinfwict, this is the second time anyone's attempted live migration functional tests with the libvirt functional driver, the first being mdbooth earlier this week18:31
dansmithstephenfin: this is cold migration18:31
stephenfinsorry, cold migration18:31
stephenfin(which is what mdbooth did too)18:32
dansmithokay, well, I'm missing what the attach and info_cache stale-ness has to do with this resize test18:32
*** shaohe_feng has joined #openstack-nova18:32
stephenfindansmith: I need the information in my RequestSpec, which is what I'm doing here https://review.openstack.org/#/c/585339/5/nova/conductor/tasks/migrate.py@22418:34
stephenfinHowever, in the functional test, when I get there instance.info_cache is stale18:34
dansmithstephenfin: right, I know you need it, but is your problem that it's stale, even without an attach?18:34
dansmithstephenfin: and your IRL test, have you tried migration or just rebuild?18:35
stephenfinYeah, correct18:35
dansmithbecause the random fishing of data from info_cache is exactly how I expected this to fail18:35
dansmithso I'm just wondering if it's really working IRL18:36
stephenfinand just rebuild, yeah, so it's possible something is off, aye18:36
dansmithso this test passes all the way to the spy verification where we check .physnets, right?18:37
stephenfinyup18:37
dansmithstephenfin: are you sure the info was there during the initial boot?18:40
*** mgoddard has quit IRC18:40
dansmithyou're checking that it wasn't for the second schedule, but.. since you can't validate based on where it landed, do you know it was present when you went to place it initially?18:40
dansmithactually18:41
dansmither, yeah, your spy is just there for the reschedule so you don't have the data I think18:41
*** shaohe_feng has quit IRC18:41
stephenfinYeah, I limited its scope there since it was already tested in other tests18:42
stephenfinBut yeah, I still need to get home, eat, pack and sleep. There's no more I can do on this18:42
dansmithso, I moved the boot into the spy mock, and left it checking the first (which would be the boot), and it still fails18:43
dansmither, on something else, hang on18:43
dansmithokay, nm, so the boot has it right18:43
stephenfinUnless something drastic changes tomorrow, this is either (a) punt, (b) apply for a feature freeze exception, or (c) merge without functional tests. If (c), someone needs to test cold migrate this IRL on a two-node deployment18:45
dansmithI'm -2 on (c)18:45
*** dtruong_ has joined #openstack-nova18:45
stephenfinI'll let mriedem, melwitt et all debate that, but I do really need to go. Sorry :(18:45
dansmithI put some debugs in the neutronapi code and they're not getting called18:45
*** shaohe_feng has joined #openstack-nova18:46
mriedem(d) mriedem spends the rest of the day figuring it out and fixes it18:47
mriedemi just go back online like 5 minutes ago so i'm getting caught up, but maybe i can sort something out here this afternoon18:47
mriedem*got18:47
dansmithmriedem: sean-k-mooney: I put a raise Exception() here and nothing changes: https://review.openstack.org/#/c/585339/5/nova/network/neutronv2/api.py@265718:47
mriedemdansmith: that's b/c we're not using that code with the NeutronFixture...18:48
dansmithoh?18:48
mriedemthe neutron fixture stubs out nova/network/neutronv2/api18:48
mriedemwell,18:48
mriedemat least the python-neutronclient in there, looking18:48
dansmiththe fixture doesn't do any of this meta stuff, which would explain why it's empty if what you say is right18:48
mriedemhttps://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L111118:49
dansmithwell, that I can see18:49
sean-k-mooneydansmith: ill put a breakpoint there to confirm18:49
mriedemhttps://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L126718:49
*** dtruong has quit IRC18:49
mriedemshould still have something in the instance.info_cache from that,18:50
mriedemotherwise our versioned notification samples wouldn't have address info in them (which they do18:50
mriedemthe neutron fixture is using stubbed networks and ports and such though18:50
dansmithmriedem: I think there's something in there, it's just not augmented with the extra stuff from the link I pasted above18:50
dansmithand that's why they think it's stale18:50
sean-k-mooneymriedem: we have something in the info cache. its just the vaule form when the instace was booted. not the updated vaules form after the attach18:51
mriedemstephen added a NUMAAffinityNeutronFixture or whatever that had fake networks with those values18:51
mriedemoh i didn't know you were doing attach stuff in these tests...18:51
dansmithnot in fixtures that I see18:51
mriedemwhy are we trying to test attach in this basic test?18:51
dansmithmriedem: that's what I said,18:51
dansmithmriedem: but we're talking about the migration test below the rebuilds18:51
mriedemheh, let's get the dumb simple flows working first18:51
dansmithright18:51
dansmithbut.. scroll down :)18:51
mriedembefore we try to land on the moon18:51
sean-k-mooneythe attahced interface is connected to a network which is mapped to a different numa node then the first network18:51
*** shaohe_feng has quit IRC18:52
sean-k-mooneythe instance has 1 numa node requested so its invalid and should fail18:52
*** shaohe_feng has joined #openstack-nova18:52
dansmithmriedem: so, that fixture he added has neutron responses with those values,18:53
*** rcernin has quit IRC18:53
dansmithbut something has to copy them into the info cache's network_model, which is the neutronv2/api code, unless that's implemented somewhere else for this test18:53
dansmithah, I might know18:55
openstackgerritMerged openstack/nova master: Add nova-manage placement sync_aggregates  https://review.openstack.org/57591218:56
dansmithhmm,18:58
dansmithwell the neutron fixture has a canned nw_info structure18:58
dansmithwhich doesn't have the physnet stuff in it18:58
*** chyka_ has joined #openstack-nova18:59
mriedembut that's only used for add_fixed_ip_to_instance and remove18:59
dansmithand it mocks out networkinfo.hydrate (!) to return that18:59
mriedemwhich isn't the same as attach/detach18:59
dansmithmriedem: there's no attach/detach in this test18:59
mriedemstill, we don't call add_fixed_ip_to_instance at all so that canned one shouldn't matter19:00
dansmithit mocks out hydrate in that fixture19:00
mriedemwhere?19:00
dansmithoh sorry19:01
dansmithI was reading it wrong, it mocks the thing you said and calls hydrate from the lambda19:01
dansmithsorry19:01
*** shaohe_feng has quit IRC19:02
*** chyka has quit IRC19:02
*** shaohe_feng has joined #openstack-nova19:02
*** dklyle has quit IRC19:03
dansmithwell, in that case, like I said, I'm not sure how we'll ever get those new things into the network model if we're not running the neutronv2/api code19:03
mriedemi think we are but with the stubbed list_ports, list_networks, show_network stuff19:06
sean-k-mooneydansmith: this is whats in instance.info_cache.network_info if it helps http://paste.openstack.org/show/726641/19:07
*** blkart has quit IRC19:07
*** blkart has joined #openstack-nova19:07
mriedemso that does have the physical_network and tunneled network meta19:08
mriedemmelwitt: https://review.openstack.org/#/c/517921/ and below need a final +@19:08
mriedem+219:08
dansmithmriedem: we're not running the _nw_info_build_network code19:08
*** alexpilotti has joined #openstack-nova19:08
melwittmriedem: thanks, will look19:09
mriedemdansmith: hmm19:09
mriedemi'm not sure why we wouldn't, i don't see anything stubbing that out19:09
dansmithmriedem: that was my point above19:09
dansmithand you shat upon it19:09
mriedemoh wait,19:09
mriedemwe do have other things that stub some shit out in the nw api19:09
mriedemand i bet that is getting stubbed in the parent test base class19:09
*** rcernin has joined #openstack-nova19:10
* dansmith throws his hands up19:10
mriedemin the air like you just don't care!?19:10
dansmithlike jan brady when marcia suggests the same thing she just did and now everyone thinks it's cool19:10
mriedemServersTestBase19:11
mriedemfake_network.set_stub_network_methods(self)19:12
mriedemthar she blar19:12
*** shaohe_feng has quit IRC19:12
mriedemso if stephenfin's test calls unset_stub_network_methods we should hit the cache rebuilder19:13
*** shaohe_feng has joined #openstack-nova19:13
mriedemi'm not sure why someone didn't figure this all out hours ago :P19:14
sean-k-mooneyso _nw_info_build_network is being called when weer are booting19:14
mriedemsean-k-mooney: yes, at the end of allocate_for_instance,19:14
mriedembut we don't get that far b/c of set_stub_network_methods19:14
sean-k-mooneyyes19:14
sean-k-mooneyits not called in the rebuild19:14
mriedemit doesn't need to be,19:15
mriedemb/c after the server is created, the nw info cache is persisted in the db with the instance19:15
mriedemassuming we had something in the db, but we don't b/c of set_stub_network_methods19:15
dansmithyep, that fixes it, I'll push this up19:15
mriedemWOOT19:15
sean-k-mooneydansmith: awsome :)19:15
*** rcernin has quit IRC19:16
openstackgerritDan Smith proposed openstack/nova master: WIP: Add additional functional tests for NUMA networks  https://review.openstack.org/58538519:16
*** lbft14 has joined #openstack-nova19:19
lbft14Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/19:19
*** lbft14 has quit IRC19:19
*** tidwellr has quit IRC19:19
*** avolkov has joined #openstack-nova19:21
*** alexpilotti has quit IRC19:22
*** shaohe_feng has quit IRC19:22
*** tidwellr has joined #openstack-nova19:22
dansmithmelwitt: mriedem: I'm assuming no cells meeting with the crunch and all19:23
melwitt+119:23
mriedemagree19:23
*** shaohe_feng has joined #openstack-nova19:24
*** eharney has quit IRC19:26
mriedemoh sweet irony as soon as we approve artom's test_tagged_attachment debug patch, it fails on that test19:31
mriedemhttp://logs.openstack.org/32/584032/5/check/nova-next/caee4e1/logs/testr_results.html.gz19:31
*** shaohe_feng has quit IRC19:33
*** flwang1 has quit IRC19:34
*** shaohe_feng has joined #openstack-nova19:35
*** efried_rollin is now known as efried19:38
mriedemdoesn't show any of artom's new debug messages for the instance or volume19:39
*** alexpilotti has joined #openstack-nova19:39
sean-k-mooneyok my server says i loged into it 12 hour and 21 minutes ago. my brain is fried so im going to call it a day. i have the functional test for dansmith updated version running local.  if test_rebuild_server_network_changes still fails perhaps we should remove it given cold migrate and test_rebuild_server_no_network_changes pass19:41
dansmithyeah the rebuild tests don't work,19:42
mriedemdansmith: what do you want me to do re ^? otherwise i'm just watching zuul and need to book a flight to china. do we have more tests that need to be written and/or cleaned up in the patch?19:42
*** alexchadin has joined #openstack-nova19:42
*** sujeet28 has joined #openstack-nova19:43
*** pendo32411 has joined #openstack-nova19:43
sujeet28Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/19:43
*** sujeet28 has quit IRC19:43
pendo32411Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/19:43
*** pendo32411 has quit IRC19:43
dansmithI think we need the negative test19:43
*** shaohe_feng has quit IRC19:43
mriedemi'm not sure i know how to do that19:43
mriedemthat's where the nodes on the host are all claimed?19:43
*** alexpilotti has quit IRC19:43
dansmithno, there's an easier way19:44
dansmithjan will take a crack at it while marcia brushes her hair19:44
mriedemalright, wfm19:44
mriedemworks. for. marcia.19:44
mriedemoh btw i'm in full summer feather hair mode atm19:44
*** shaohe_feng has joined #openstack-nova19:45
mriedembut it will be shorn before denver19:45
*** alexchadin has quit IRC19:47
*** tidwellr has quit IRC19:48
* dansmith scowls19:48
sean-k-mooneyso ya that just finished running all the nova fuctional tests. nova.tests.functional.libvirt.test_numa_servers.NUMAServersWithNetworksTest.test_rebuild_server_network_changes is the only one that failed in dans version so its just the attch suff thats failing.19:49
*** mgoddard has joined #openstack-nova19:49
*** tidwellr has joined #openstack-nova19:50
*** medberry has joined #openstack-nova19:50
*** medberry has quit IRC19:50
*** medberry has joined #openstack-nova19:50
*** sean-k-mooney has quit IRC19:51
*** felipemonteiro_ has joined #openstack-nova19:52
*** shaohe_feng has quit IRC19:53
*** slaweq has quit IRC19:55
*** shaohe_feng has joined #openstack-nova19:55
*** felipemonteiro has quit IRC19:56
*** slaweq has joined #openstack-nova20:00
*** alexpilotti has joined #openstack-nova20:01
openstackgerritDan Smith proposed openstack/nova master: WIP: Add additional functional tests for NUMA networks  https://review.openstack.org/58538520:03
*** mgoddard has quit IRC20:03
*** shaohe_feng has quit IRC20:03
*** alexpilotti has quit IRC20:04
*** alexpilotti has joined #openstack-nova20:04
*** shaohe_feng has joined #openstack-nova20:07
*** jchhatbar has quit IRC20:11
*** shaohe_feng has quit IRC20:14
*** shaohe_feng has joined #openstack-nova20:14
artommriedem, wait, it failed and logged nothing at all o_O20:16
*** Shilpa has quit IRC20:17
*** alexchadin has joined #openstack-nova20:17
*** Shilpa has joined #openstack-nova20:17
*** alexchadin has quit IRC20:17
dansmithmriedem: so you'll convert your +1 to +2 on the functional move patch?20:19
efriedDoes he have to deny you three times, or something?20:21
*** jamesde__ has joined #openstack-nova20:22
efriednot that kind of conversion, maybe.20:22
*** jamesden_ has quit IRC20:22
*** shaohe_feng has quit IRC20:24
*** shaohe_feng has joined #openstack-nova20:25
*** edmondsw has quit IRC20:28
*** edmondsw has joined #openstack-nova20:28
*** edmondsw has quit IRC20:32
*** shaohe_feng has quit IRC20:34
*** medberry has quit IRC20:34
*** shaohe_feng has joined #openstack-nova20:35
*** wolverineav has quit IRC20:38
*** thejoecarroll29 has joined #openstack-nova20:43
thejoecarroll29Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/20:43
*** thejoecarroll29 has quit IRC20:43
*** shaohe_feng has quit IRC20:44
*** shaohe_feng has joined #openstack-nova20:46
*** Pyrrhic4 has joined #openstack-nova20:49
Pyrrhic4Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/20:49
*** Pyrrhic4 has quit IRC20:49
*** gongysh has joined #openstack-nova20:50
*** wwriverr_ has quit IRC20:51
*** mgoddard has joined #openstack-nova20:54
*** shaohe_feng has quit IRC20:55
*** hamzy has quit IRC20:55
*** medberry has joined #openstack-nova20:56
*** shaohe_feng has joined #openstack-nova20:58
*** flwang1 has joined #openstack-nova20:58
openstackgerritMathieu Gagné proposed openstack/nova master: Add support for multiple fixed-ips in metadata  https://review.openstack.org/58074220:58
*** jamesde__ has quit IRC20:59
mriedemdansmith: yeah21:00
mriedemartom: right21:00
*** jamesden_ has joined #openstack-nova21:01
melwittdoes anyone know anything about metadata API versions and what's valid? for the addition of 'ip_addresses' to network_data.json, it means we have a second version update this cycle and we apparently already used a date in the future 2018-08-27 https://review.openstack.org/#/c/580742/2/nova/api/metadata/base.py@7721:02
*** owalsh_ has joined #openstack-nova21:02
mriedemapparently we already did that once with NEWTON_TWO even though NEWTON_ONE was using the wrong date21:03
*** mgoddard has quit IRC21:03
melwittwhat's proposed is 2018-08-27-2 which is a format we haven't done before21:03
mriedem# NOTE(mikal): think of these strings as version numbers. They traditionally21:03
mriedem# correlate with OpenStack release dates, with all the changes for a given21:03
mriedem# release bundled into a single version. Note that versions in the future are21:03
mriedem# hidden from the listing, but can still be requested explicitly, which is21:03
mriedem# required for testing purposes. We know this isn't great, but its inherited21:03
mriedem# from EC2, which this needs to be compatible with.21:03
mriedemi would -1 on the fomrat21:04
mriedem*format21:04
mriedembased on "They traditionally21:04
mriedem# correlate with OpenStack release dates, with all the changes for a given21:04
mriedem# release bundled into a single version." we could lump the changes into the existing ROCKY version21:04
mriedemwhich isn't CI/CD friendly, so if we cared, i'd just make the ROCKY_TWO a day later than ROCKY_ONE21:04
mriedemi'm a big meh on either approach21:04
*** gongysh has quit IRC21:04
*** openstackgerrit has quit IRC21:04
*** mrjk has quit IRC21:05
melwittokay, I was wondering about that. else we could use 2018-08-30 the actual rocky release date? I haven't been able to find examples of consumers using version strings to request versions21:05
*** shaohe_feng has quit IRC21:05
*** owalsh has quit IRC21:05
mriedemit says versions in the future are hidden from the listing,21:05
mriedemso if that's true, rocky doesn't even show up today,21:05
mriedembut would need to confirm21:05
melwittand it looks like this new version won't break anyone because it adds a field, doesn't change any fields. so cloud-init defaulting to latest (I think it does, based on the code) will still work with the new version with 'ip_addresses' in it21:06
melwittohh, I see21:06
*** shaohe_feng has joined #openstack-nova21:06
mriedemi have a hell of a time ever knowing where the route code in this thing works21:06
melwittso rolling together should work on that basis. I didn't understand what "hidden" meant until you said that21:06
*** mrjk has joined #openstack-nova21:06
mriedemwell, i'd want to know where that hiding happens21:07
mriedemi don't have a devstack handy to test this21:07
dansmithright, should be rocky release date, and we shouldn't have multiple versions for rocky21:07
dansmithI think that the date-based one is hidden,21:07
dansmithbut current takes you to it,21:07
mriedemhttps://review.openstack.org/#/c/580742/2/nova/api/metadata/base.py@59721:07
*** wolverineav has joined #openstack-nova21:07
dansmithand the idea is that until the release happens, it's not really codified as the date-based version,21:07
dansmithso we can add stuff to it21:07
mriedemyup,21:07
*** lutoma18 has joined #openstack-nova21:07
lutoma18Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/21:07
lutoma18or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/21:07
mriedemfound that code21:07
*** lutoma18 has quit IRC21:07
*** Bonn33322 has joined #openstack-nova21:08
Bonn33322Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/21:08
Bonn33322or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/21:08
*** Bonn33322 has quit IRC21:08
melwitta-ha, cool. thanks for all that info21:10
*** awaugama has quit IRC21:10
melwittfyi mgagne ^ (backscroll for more context on the latest review comment)21:12
mgagnemelwitt: so no new metadata api version and call it a day?21:13
melwittmgagne: yeah, the code mriedem highlighted on the review will hide version dates that are in the future, so that they stay 'unreleased' until the release date. so you can roll your changes into the existing ROCKY version21:14
mgagne+121:14
*** shaohe_feng has quit IRC21:15
*** openstackgerrit has joined #openstack-nova21:16
openstackgerritMathieu Gagné proposed openstack/nova master: Add support for multiple fixed-ips in metadata  https://review.openstack.org/58074221:16
artommriedem, yeah, am looking into it21:16
artomReally weird21:16
*** shaohe_feng has joined #openstack-nova21:18
mriedemdansmith: so does that mean we're good with the move patch for my +2 since we have the functional WIP patch for the move ops?21:18
artommriedem, no chance we can merge and later revert really excessive logging?21:18
mriedemlike, are you ok approving the stack and cleaning up the functional patch test later or?21:18
artomBack in a bit, picking up daughter from daycare21:18
mriedemi also have to do ^21:18
*** mriedem is now known as mriedem_afk21:18
dansmithmriedem_afk: oh I should have removed the WIP on that as I think it's okay21:19
dansmithmriedem_afk: but yeah, I think we need to merge that stack if you're good with it21:19
dansmiththat's what I meant when I asked about your +221:19
*** tidwellr has quit IRC21:21
mriedem_afkwant me to +W the bottom change too?21:21
mriedem_afkdid it anyway21:22
mriedem_afkgotta run21:22
*** shaohe_feng has quit IRC21:25
*** shaohe_feng has joined #openstack-nova21:26
*** itlinux has quit IRC21:31
*** brault has quit IRC21:32
*** medberry has quit IRC21:33
*** shaohe_feng has quit IRC21:36
*** itlinux has joined #openstack-nova21:36
*** shaohe_feng has joined #openstack-nova21:36
*** dklyle has joined #openstack-nova21:38
*** edmondsw has joined #openstack-nova21:40
*** edmondsw has quit IRC21:45
*** shaohe_feng has quit IRC21:46
openstackgerritDan Smith proposed openstack/nova master: Add additional functional tests for NUMA networks  https://review.openstack.org/58538521:47
*** felipemonteiro_ has quit IRC21:48
*** Guest27255 has quit IRC21:50
*** shaohe_feng has joined #openstack-nova21:51
*** takashin has joined #openstack-nova21:52
*** Guest53662 has joined #openstack-nova21:52
Guest53662Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/21:52
Guest53662or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/21:52
*** Guest53662 has quit IRC21:52
*** Contessa19 has joined #openstack-nova21:52
Contessa19Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/21:52
Contessa19or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/21:52
*** Contessa19 has quit IRC21:52
*** shaohe_feng has quit IRC21:56
*** shaohe_feng has joined #openstack-nova21:59
*** wolverineav has quit IRC22:03
*** EvilRoey18 has joined #openstack-nova22:03
EvilRoey18Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/22:03
EvilRoey18or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/22:03
*** EvilRoey18 has quit IRC22:03
*** shaohe_feng has quit IRC22:06
*** mchlumsky has quit IRC22:07
*** shaohe_feng has joined #openstack-nova22:08
openstackgerritMathieu Gagné proposed openstack/nova master: Add support for multiple fixed-ips in metadata  https://review.openstack.org/58074222:12
mgagnemriedem_afk: sorry, I was a bit too hasty in updating the change. Let me know about the expected services field behavior. I will update accordingly.22:13
*** mlavalle has quit IRC22:14
*** cdent has quit IRC22:15
*** shaohe_feng has quit IRC22:17
*** shaohe_feng has joined #openstack-nova22:17
melwittmgagne: well, tbh, I'm not sure what it should be, just pointing out that my prior understanding of the change was that it just adds the ip_addresses field and nothing else changes22:18
melwittit might be fine to include more services in 'services' too. I'll add a comment and ask mriedem_afk and dansmith about it tomorrow to see what they think22:19
*** antosh has quit IRC22:22
*** jiteka has quit IRC22:22
*** eandersson has quit IRC22:22
*** jiteka has joined #openstack-nova22:23
*** ynyounuo8 has joined #openstack-nova22:23
*** bleepy2 has joined #openstack-nova22:23
*** ynyounuo8 has quit IRC22:23
bleepy2Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/22:23
*** bleepy2 has quit IRC22:23
*** eandersson has joined #openstack-nova22:24
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py  https://review.openstack.org/56615322:25
*** itlinux has quit IRC22:25
*** shaohe_feng has quit IRC22:27
*** shaohe_feng has joined #openstack-nova22:27
*** Jan\24 has joined #openstack-nova22:28
Jan\24Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/22:28
*** Jan\24 has quit IRC22:28
*** mtreinish has quit IRC22:33
*** mtreinish has joined #openstack-nova22:36
*** shaohe_feng has quit IRC22:37
*** shaohe_feng has joined #openstack-nova22:38
*** avolkov has quit IRC22:39
*** antosh has joined #openstack-nova22:42
*** shaohe_feng has quit IRC22:47
*** shaohe_feng has joined #openstack-nova22:48
*** antosh has quit IRC22:52
*** antosh has joined #openstack-nova22:52
*** Corvus`26 has joined #openstack-nova22:53
Corvus`26Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/22:53
*** Corvus`26 has quit IRC22:53
*** Freejack4 has joined #openstack-nova22:57
Freejack4Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/22:57
Freejack4or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/22:57
*** Freejack4 has quit IRC22:57
*** shaohe_feng has quit IRC22:58
*** chyka_ has quit IRC23:00
*** shaohe_feng has joined #openstack-nova23:00
*** mschuppert has quit IRC23:03
*** namnh has joined #openstack-nova23:03
*** vladikr has joined #openstack-nova23:05
*** shaohe_feng has quit IRC23:08
*** wolverineav has joined #openstack-nova23:10
*** shaohe_feng has joined #openstack-nova23:10
*** medberry has joined #openstack-nova23:12
mgagnemelwitt: thanks for the review, much appreciated. sorry if I didn't make the full extend of the change clear in the initial spec :-/23:13
*** aphex`5 has joined #openstack-nova23:13
aphex`5Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/23:13
aphex`5or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/23:13
aphex`5Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate23:13
*** aphex`5 has quit IRC23:13
*** wolverineav has quit IRC23:14
melwittmgagne: that's okay, I'm guessing it's obvious to those more familiar than I. thanks for the prompt replies23:16
mgagneI shouldn't assume people are familiar with that part ;)23:16
melwittI learned new things, that's a plus :)23:18
*** shaohe_feng has quit IRC23:18
openstackgerritEric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST  https://review.openstack.org/57692723:18
openstackgerritEric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories  https://review.openstack.org/58503323:18
openstackgerritEric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider sane  https://review.openstack.org/58459823:18
openstackgerritEric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer  https://review.openstack.org/58459923:18
openstackgerritEric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree  https://review.openstack.org/58464823:18
openstackgerritEric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump  https://review.openstack.org/58503423:19
openstackgerritEric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape  https://review.openstack.org/58504923:19
openstackgerritEric Fried proposed openstack/nova master: WIP: Compute: Handle reshaped provider trees  https://review.openstack.org/57623623:19
*** medberry has quit IRC23:20
*** shaohe_feng has joined #openstack-nova23:20
*** namnh has quit IRC23:22
*** namnh has joined #openstack-nova23:23
*** namnh has quit IRC23:25
*** namnh has joined #openstack-nova23:25
*** r-daneel has quit IRC23:28
*** shaohe_feng has quit IRC23:28
*** edmondsw has joined #openstack-nova23:29
*** medberry has joined #openstack-nova23:29
*** namnh has quit IRC23:29
*** medberry has quit IRC23:29
*** medberry has joined #openstack-nova23:29
*** namnh has joined #openstack-nova23:30
*** shaohe_feng has joined #openstack-nova23:30
*** edmondsw has quit IRC23:33
*** namnh has quit IRC23:34
*** shaohe_feng has quit IRC23:39
*** shaohe_feng has joined #openstack-nova23:40
*** itlinux has joined #openstack-nova23:44
*** jangutter has quit IRC23:48
*** shaohe_feng has quit IRC23:49
*** shaohe_feng has joined #openstack-nova23:49
*** antosh has quit IRC23:50
*** shaohe_feng has quit IRC23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!